[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [[XSATOOL]] repo: Add missing spaces in the configure cmdline for "xentools"



Hmmm I forgot to CC George. Sorry for that.

On 27/07/2020 17:04, Julien Grall wrote:
From: Julien Grall <jgrall@xxxxxxxxxx>

The operator + will just concatenate two strings. As the result, the
configure cmdline for "xentools" will look like:

./configure --disable-stubdom 
--disable-qemu-traditional--with-system-qemu=/bin/false 
--with-system-seabios=/bin/false--disable-ovmf

This can be avoided by explicitely adding the spaces.

Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
---
  repo.go | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/repo.go b/repo.go
index 1e7802f8142c..f00b7469101f 100644
--- a/repo.go
+++ b/repo.go
@@ -139,8 +139,8 @@ func MainRepoInit(unused *XSAMeta, args []string) (ret int) 
{
        G.config.Tool.BuildSequences = map[string]BuildSequence{
                "simple": {"./configure", "make -j 8"},
                "xen":    {"make -j 8 xen"},
-               "xentools": {"./configure --disable-stubdom 
--disable-qemu-traditional" +
-                       "--with-system-qemu=/bin/false 
--with-system-seabios=/bin/false" +
+               "xentools": {"./configure --disable-stubdom 
--disable-qemu-traditional " +
+                       "--with-system-qemu=/bin/false 
--with-system-seabios=/bin/false " +
                        "--disable-ovmf",
                        "make -j 8"},
        }


--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.