Re: [Embedded-pv-devel] Driver domain under Xen

[Andrii Tseglytskyi <andrii.tseglytskyi@xxxxxxxxxxxxxxx>]

24 ÑÑÑ. 2015 00:32, ÐÐÑÐÑÑÑÐÐÑ "Julien Grall" <julien.grall@xxxxxxxxxx> ÐÐÐÐÑÐÐ:
>
> On 23 January 2015 at 16:20, Andrii Tseglytskyi
> <andrii.tseglytskyi@xxxxxxxxxxxxxxx> wrote:
> > This is why I didn't want to send you code right now. All these
> > changes work for us to have 1 to 1 IRQ mapping in driver domain and to
> > release them correctly in case of domain crash. Before get them
> > upstreamed I would prefer to think twice on each of them and rework if
> > needed.
>
> I was mostly interesting to know if you have found new race condition in
> the guest physical IRQ management. I spent the last couple of months fixing
> multiple race condition in my series. I don't consider the v1 neither v2 safe to
> use for interrupts passthrough.

Actually I did not find any new races. But I need to mention that I do not use complete series - just first 3 or 4 patches. Not sure what version I am using - might be v2. At some point of time I stopped rebasing to newer revisions, because I realize a lot of differences between them, and I was really out of time that days. Now I am planning to rebase to latest irq and devtree passthrough series, and check do we need anything else to map irqs 1 to 1. Will comment in public list as soon as done.
The same with devtree passthrough - we decided not to use it in our CES demo, but now need to check it again and comment if something needed.

>
> For instance, your clear_bit(_IRQ_DISABLED, &desc->status) is too
> workaround a latent bug in gic_remove_irq_from_guest().

Exactly )). Quick and dirty hack to force gic_remove_irq_from_guest() not to return with error, but to remove irqs from dom0. Works pretty stable - I forward about 30 irqs to driver domain and 4 irqs to Android. Verified with domain restart. For sure - solution is not for upstream ))

Regards,
Andrii

>
> Anyway, it's fine to use as long as it's used for a prototype.
>
> Regards,
>
> --
> Julien Grall

_______________________________________________
Embedded-pv-devel mailing list
Embedded-pv-devel@xxxxxxxxxxxxxxxxxxxx
http://lists.xenproject.org/cgi-bin/mailman/listinfo/embedded-pv-devel