Re: [Embedded-pv-devel] [PATCH v11] xen: add para-virtual sound interface header file

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.11.16 at 12:19, <andr2000@xxxxxxxxx> wrote:
> On 11/25/2016 11:18 AM, Jan Beulich wrote:
>>>>> On 25.11.16 at 09:03, <andr2000@xxxxxxxxx> wrote:
>>> +struct xensnd_close_req {
>>> +    /* place holder, remove if changing the structure (C89 concern) */
>>> +    uint8_t __placeholder;
>>> +};
> changed __placeholder to placeholder
>> The comment ought to be correct - did you verify this is permitted
>> in e.g. C99? I don't think it is, and I've referred to C89 only to give
>> you an understanding with what standard the header as a whole
>> is expected to comply (i.e. to avoid you using C99 constructs
>> elsewhere).
> you are right, C99 says ( 6.2.5.20):
> " A structure type describes a sequentially allocated *nonempty* set of 
> member objects"
> C11 doesn't say anything that it is allowed
> So, I will change in the comments *C89 concern* to *(C99 6.2.5.20)*

Well, I'd prefer if you omitted this - C language details don't really
belong here. And of course all this would be moot if these dummy
structures weren't there in the first place.

Jan


_______________________________________________
Embedded-pv-devel mailing list
Embedded-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/cgi-bin/mailman/listinfo/embedded-pv-devel