Re: [Embedded-pv-devel] [PATCH v13] This is the ABI for the two halves of a para-virtualized sound driver to communicate with each to other.

[Julien Grall <julien.grall@xxxxxxx>]

Hi Oleksandr,

On 28/11/16 14:12, Oleksandr Andrushchenko wrote:
> On 11/28/2016 03:27 PM, Jan Beulich wrote:
> > > + *
> > > + * gref_dir_next_page - grant_ref_t, reference to the next page
> > > describing
> > > + *   page directory. Must be 0 if no more pages in the list.
If I am not mistaken 0 is a valid grant.

> > > + * gref[i] - grant_ref_t, reference to a shared page of the buffer
> > > + *   allocated at XENSND_OP_OPEN
> > > + *
> > > + * Number of grant_ref_t entries in the whole page directory is not
> > > + * passed, but instead can be calculated as:
> > > + *   num_grefs_total = DIV_ROUND_UP(XENSND_OP_OPEN.buffer_sz,
> > > PAGE_SIZE);
> > The header should be self contained, and there's no DIV_ROUND_UP()
> > anywhere under public/io/ for a reader to refer to. Please express this
> > using mathematical terms plus, if needed, standard C library ones.
> done, will put:
> num_grefs_total = (XENSND_OP_OPEN.buffer_sz + PAGE_SIZE - 1) / PAGE_SIZE
Can we avoid to use PAGE_SIZE in the header? Xen, the front-end and the 
back-end may have different page size.
Regards,

--
Julien Grall

_______________________________________________
Embedded-pv-devel mailing list
Embedded-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/cgi-bin/mailman/listinfo/embedded-pv-devel