Re: [Embedded-pv-devel] [PATCH v15] This is the ABI for the two halves of a para-virtualized sound driver to communicate with each to other.

[Oleksandr Andrushchenko <andr2000@xxxxxxxxx>]

On 01/27/2017 08:13 PM, Konrad Rzeszutek Wilk wrote:
> .snip..
> > I am looking at this from FAE's or integrator's POV, when one would need
> FAE?
Field Applications Engineer
> > to touch different parts of the system. "/0/0/0" makes me feel
> > sad just because either you have to keep all those numbers in mind (like you
> > do)
> > or have documentation available (and know where it is, e.g. sources
> > of Xen or kernel).
> > I have a strong feeling that if you can change configuration without
> > knowing what index stands for it is always better and fail-safer then
> > just having numbers...
> Not sure I follow that.
>
> How would you change configuration without knowing the index?
>
> ..snip..
if one looks at
.../pcm-dev-0/stream-1/...
most probably he/she will understand this w/o any documentation,
because it is human readable

if one looks at
.../0/1/...
well, I believe you can almost do nothing w/o looking at the documentation
> > ok, then
> >
> > struct xensnd_rw_req {
> >      uint32_t offset;
> >      uint32_t len;
> > };
> > covers all the requests, but open/close
> > Do you want me to keep the same structure name (xensnd_rw_req)
> > or rename it to something like xensnd_io_req?
> The name is fine.
> > Thank you,
> > Oleksandr

_______________________________________________
Embedded-pv-devel mailing list
Embedded-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/cgi-bin/mailman/listinfo/embedded-pv-devel