From embedded-pv-devel-bounces@lists.xenproject.org Thu Apr 02 15:05:25 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 02 Apr 2015 15:05:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YdggP-0001tb-51; Thu, 02 Apr 2015 15:05:25 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YdggN-0001sm-09 for Embedded-pv-devel@lists.xenproject.org; Thu, 02 Apr 2015 15:05:23 +0000 Received: from [85.158.139.211] by server-7.bemta-5.messagelabs.com id 1D/4C-02028-2BA5D155; Thu, 02 Apr 2015 15:05:22 +0000 X-Env-Sender: iurii.konovalenko@globallogic.com X-Msg-Ref: server-11.tower-206.messagelabs.com!1427987119!9409119!1 X-Originating-IP: [64.18.0.212] X-SpamReason: No, hits=0.3 required=7.0 tests=RCVD_BY_IP X-StarScan-Received: X-StarScan-Version: 6.13.6; banners=-,-,- X-VirusChecked: Checked Received: (qmail 17591 invoked from network); 2 Apr 2015 15:05:21 -0000 Received: from exprod5og124.obsmtp.com (HELO exprod5og124.obsmtp.com) (64.18.0.212) by server-11.tower-206.messagelabs.com with DHE-RSA-AES256-SHA encrypted SMTP; 2 Apr 2015 15:05:21 -0000 Received: from mail-ig0-f175.google.com ([209.85.213.175]) (using TLSv1) by exprod5ob124.postini.com ([64.18.4.12]) with SMTP ID DSNKVR1ar/LHjvIqba9fYXt43eXxA7Ip6079@postini.com; Thu, 02 Apr 2015 08:05:21 PDT Received: by igbqf9 with SMTP id qf9so75386324igb.1 for ; Thu, 02 Apr 2015 08:05:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=globallogic.com; s=google; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=n+OJhHO9MmhBwGAm9ZFcQOnMPk4h58QYcVxL9TmhzmA=; b=Us8bSncgzga9QPEypn6wQFMTIi7/aEo1y+YGj/+qkj2QWvZ4ADq7yI2CAandTopg8j xcb9O6fNZG7l8aNmllbZ/K6XWVPEwmBai4TXrC56Vi6r3bldvH2e1i8seVBDBvNczMjN 39nPDpP/gEm6c+Wph2uMxOeb/nuwcMryPtw+U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to:cc :content-type; bh=n+OJhHO9MmhBwGAm9ZFcQOnMPk4h58QYcVxL9TmhzmA=; b=JNKnqyriOxtrC7J2+zt6U9AAsoxRechu1cQBS1IFJf5cdZnm39Ws1iwDQuDFCe62CU 05ABQBQfG6pzrKf7ItiU6hJqQHxqQMJ+G2+8TxMzpDsSexkKvU6w6ChpGtIc2zIq8W29 kjDodlo1pXVPOE9FtlX4mMlfvzDRL1AaoAS0bhXOxis37iHdQTG84zinFGc5Ng686tAr 1ZglmCfyCOXRxbLf61+KO9OfmC6+lG32NhWyKz4twVCDad+imM031A7DlUNMzwLuF9BQ 98HfFWZR82qgh1/l5wAQcCBwB/6SQobqBC0/CBXEutSRVo2r5qxOI+D6mGX/mKk/XGgR Ixtw== X-Received: by 10.107.6.42 with SMTP id 42mr49349856iog.52.1427987119090; Thu, 02 Apr 2015 08:05:19 -0700 (PDT) X-Gm-Message-State: ALoCoQl85o97My7GhJfTDpzcGTkQWyaBF4uq4LR1QWS6hl+uf3MpGKBCvxeW4ATu5E6/nDpzJfdrGK0raDaFS5vX2wqHoMCoVDpxE8SIIOM8nT4mgbCV3Y/dws9Ig/Jd9CGq02OC1/wkrYgD9+1mjI9bcBaHXDDPpHoAU13CtngKBDLzq8+ZfeQ= MIME-Version: 1.0 X-Received: by 10.107.6.42 with SMTP id 42mr49349834iog.52.1427987118943; Thu, 02 Apr 2015 08:05:18 -0700 (PDT) Received: by 10.36.123.207 with HTTP; Thu, 2 Apr 2015 08:05:18 -0700 (PDT) Date: Thu, 2 Apr 2015 18:05:18 +0300 Message-ID: From: Iurii Konovalenko To: Julien Grall Cc: Embedded-pv-devel@lists.xenproject.org, "xen-devel@lists.xen.org" Subject: [Embedded-pv-devel] Size of irq field X-BeenThere: embedded-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: embedded-pv-devel-bounces@lists.xenproject.org Errors-To: embedded-pv-devel-bounces@lists.xenproject.org Hi, Julien! During bringing up Xen on Renesas Lager board we faced with problem. A lot of Xen sources relies on statement, that IRQ number is less then 256 and variables, parameters, fields etc. are of type uint8_t. But we can have IRQs, that are greater then 255, for example on RCar H2 SoC. Also, as I saw from one of your latest commits, GICv supports 1020 physical interrupts. As a result, overflow can occur. So it seems logical to increase all irq staff to uint16_t or uint32_t. We have local patches for increasing some structures, functions etc. But before pushing these patches I want to know your opinion, what do you think about this problem? What type should we use uint16_t or uint32_t? How to find all places where uint8_t type is used for IRQ? Best regards. Iurii Konovalenko | Senior Software Engineer GlobalLogic _______________________________________________ Embedded-pv-devel mailing list Embedded-pv-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/embedded-pv-devel From embedded-pv-devel-bounces@lists.xenproject.org Thu Apr 02 15:05:25 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 02 Apr 2015 15:05:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YdggP-0001tb-51; Thu, 02 Apr 2015 15:05:25 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YdggN-0001sm-09 for Embedded-pv-devel@lists.xenproject.org; Thu, 02 Apr 2015 15:05:23 +0000 Received: from [85.158.139.211] by server-7.bemta-5.messagelabs.com id 1D/4C-02028-2BA5D155; Thu, 02 Apr 2015 15:05:22 +0000 X-Env-Sender: iurii.konovalenko@globallogic.com X-Msg-Ref: server-11.tower-206.messagelabs.com!1427987119!9409119!1 X-Originating-IP: [64.18.0.212] X-SpamReason: No, hits=0.3 required=7.0 tests=RCVD_BY_IP X-StarScan-Received: X-StarScan-Version: 6.13.6; banners=-,-,- X-VirusChecked: Checked Received: (qmail 17591 invoked from network); 2 Apr 2015 15:05:21 -0000 Received: from exprod5og124.obsmtp.com (HELO exprod5og124.obsmtp.com) (64.18.0.212) by server-11.tower-206.messagelabs.com with DHE-RSA-AES256-SHA encrypted SMTP; 2 Apr 2015 15:05:21 -0000 Received: from mail-ig0-f175.google.com ([209.85.213.175]) (using TLSv1) by exprod5ob124.postini.com ([64.18.4.12]) with SMTP ID DSNKVR1ar/LHjvIqba9fYXt43eXxA7Ip6079@postini.com; Thu, 02 Apr 2015 08:05:21 PDT Received: by igbqf9 with SMTP id qf9so75386324igb.1 for ; Thu, 02 Apr 2015 08:05:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=globallogic.com; s=google; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=n+OJhHO9MmhBwGAm9ZFcQOnMPk4h58QYcVxL9TmhzmA=; b=Us8bSncgzga9QPEypn6wQFMTIi7/aEo1y+YGj/+qkj2QWvZ4ADq7yI2CAandTopg8j xcb9O6fNZG7l8aNmllbZ/K6XWVPEwmBai4TXrC56Vi6r3bldvH2e1i8seVBDBvNczMjN 39nPDpP/gEm6c+Wph2uMxOeb/nuwcMryPtw+U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to:cc :content-type; bh=n+OJhHO9MmhBwGAm9ZFcQOnMPk4h58QYcVxL9TmhzmA=; b=JNKnqyriOxtrC7J2+zt6U9AAsoxRechu1cQBS1IFJf5cdZnm39Ws1iwDQuDFCe62CU 05ABQBQfG6pzrKf7ItiU6hJqQHxqQMJ+G2+8TxMzpDsSexkKvU6w6ChpGtIc2zIq8W29 kjDodlo1pXVPOE9FtlX4mMlfvzDRL1AaoAS0bhXOxis37iHdQTG84zinFGc5Ng686tAr 1ZglmCfyCOXRxbLf61+KO9OfmC6+lG32NhWyKz4twVCDad+imM031A7DlUNMzwLuF9BQ 98HfFWZR82qgh1/l5wAQcCBwB/6SQobqBC0/CBXEutSRVo2r5qxOI+D6mGX/mKk/XGgR Ixtw== X-Received: by 10.107.6.42 with SMTP id 42mr49349856iog.52.1427987119090; Thu, 02 Apr 2015 08:05:19 -0700 (PDT) X-Gm-Message-State: ALoCoQl85o97My7GhJfTDpzcGTkQWyaBF4uq4LR1QWS6hl+uf3MpGKBCvxeW4ATu5E6/nDpzJfdrGK0raDaFS5vX2wqHoMCoVDpxE8SIIOM8nT4mgbCV3Y/dws9Ig/Jd9CGq02OC1/wkrYgD9+1mjI9bcBaHXDDPpHoAU13CtngKBDLzq8+ZfeQ= MIME-Version: 1.0 X-Received: by 10.107.6.42 with SMTP id 42mr49349834iog.52.1427987118943; Thu, 02 Apr 2015 08:05:18 -0700 (PDT) Received: by 10.36.123.207 with HTTP; Thu, 2 Apr 2015 08:05:18 -0700 (PDT) Date: Thu, 2 Apr 2015 18:05:18 +0300 Message-ID: From: Iurii Konovalenko To: Julien Grall Cc: Embedded-pv-devel@lists.xenproject.org, "xen-devel@lists.xen.org" Subject: [Embedded-pv-devel] Size of irq field X-BeenThere: embedded-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: embedded-pv-devel-bounces@lists.xenproject.org Errors-To: embedded-pv-devel-bounces@lists.xenproject.org Hi, Julien! During bringing up Xen on Renesas Lager board we faced with problem. A lot of Xen sources relies on statement, that IRQ number is less then 256 and variables, parameters, fields etc. are of type uint8_t. But we can have IRQs, that are greater then 255, for example on RCar H2 SoC. Also, as I saw from one of your latest commits, GICv supports 1020 physical interrupts. As a result, overflow can occur. So it seems logical to increase all irq staff to uint16_t or uint32_t. We have local patches for increasing some structures, functions etc. But before pushing these patches I want to know your opinion, what do you think about this problem? What type should we use uint16_t or uint32_t? How to find all places where uint8_t type is used for IRQ? Best regards. Iurii Konovalenko | Senior Software Engineer GlobalLogic _______________________________________________ Embedded-pv-devel mailing list Embedded-pv-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/embedded-pv-devel From embedded-pv-devel-bounces@lists.xenproject.org Thu Apr 02 15:25:51 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 02 Apr 2015 15:25:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Ydh0B-0006Of-9R; Thu, 02 Apr 2015 15:25:51 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Ydh09-0006Nn-U4 for Embedded-pv-devel@lists.xenproject.org; Thu, 02 Apr 2015 15:25:50 +0000 Received: from [193.109.254.147] by server-8.bemta-14.messagelabs.com id BF/63-27592-D7F5D155; Thu, 02 Apr 2015 15:25:49 +0000 X-Env-Sender: Ian.Campbell@citrix.com X-Msg-Ref: server-3.tower-27.messagelabs.com!1427988345!11897054!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.6; banners=-,-,- X-VirusChecked: Checked Received: (qmail 9083 invoked from network); 2 Apr 2015 15:25:46 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-3.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 2 Apr 2015 15:25:46 -0000 X-IronPort-AV: E=Sophos;i="5.11,511,1422921600"; d="scan'208";a="249184336" Message-ID: <1427987951.4037.92.camel@citrix.com> From: Ian Campbell To: Iurii Konovalenko Date: Thu, 2 Apr 2015 16:19:11 +0100 In-Reply-To: References: X-Mailer: Evolution 3.12.9-1+b1 MIME-Version: 1.0 X-DLP: MIA1 Cc: Embedded-pv-devel@lists.xenproject.org, Julien Grall , "xen-devel@lists.xen.org" Subject: Re: [Embedded-pv-devel] [Xen-devel] Size of irq field X-BeenThere: embedded-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: embedded-pv-devel-bounces@lists.xenproject.org Errors-To: embedded-pv-devel-bounces@lists.xenproject.org On Thu, 2015-04-02 at 18:05 +0300, Iurii Konovalenko wrote: > Hi, Julien! > > During bringing up Xen on Renesas Lager board we faced with problem. > A lot of Xen sources relies on statement, that IRQ number is less then > 256 and variables, parameters, fields etc. are of type uint8_t. Please can you give some example of this? Internally most irq stuff is unsigned int I think and "git grep uint8_t.*irq -- xen" is not showing lots of hits, there are a few but none which seem terribly scary or hard to fix. > But we > can have IRQs, that are greater then 255, for example on RCar H2 SoC. > Also, as I saw from one of your latest commits, GICv supports 1020 > physical interrupts. This has always been true, in fact Julien's commit was reducing the limit (which was too high), not increasing it. > As a result, overflow can occur. So it seems > logical to increase all irq staff to uint16_t or uint32_t. We have > local patches for increasing some structures, functions etc. > But before pushing these patches I want to know your opinion, what do > you think about this problem? What type should we use uint16_t or > uint32_t? How to find all places where uint8_t type is used for IRQ? We should certainly fix anywhere which is not using a large enough data type. Ian. _______________________________________________ Embedded-pv-devel mailing list Embedded-pv-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/embedded-pv-devel From embedded-pv-devel-bounces@lists.xenproject.org Thu Apr 02 15:25:51 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 02 Apr 2015 15:25:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Ydh0B-0006Of-9R; Thu, 02 Apr 2015 15:25:51 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Ydh09-0006Nn-U4 for Embedded-pv-devel@lists.xenproject.org; Thu, 02 Apr 2015 15:25:50 +0000 Received: from [193.109.254.147] by server-8.bemta-14.messagelabs.com id BF/63-27592-D7F5D155; Thu, 02 Apr 2015 15:25:49 +0000 X-Env-Sender: Ian.Campbell@citrix.com X-Msg-Ref: server-3.tower-27.messagelabs.com!1427988345!11897054!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.6; banners=-,-,- X-VirusChecked: Checked Received: (qmail 9083 invoked from network); 2 Apr 2015 15:25:46 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-3.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 2 Apr 2015 15:25:46 -0000 X-IronPort-AV: E=Sophos;i="5.11,511,1422921600"; d="scan'208";a="249184336" Message-ID: <1427987951.4037.92.camel@citrix.com> From: Ian Campbell To: Iurii Konovalenko Date: Thu, 2 Apr 2015 16:19:11 +0100 In-Reply-To: References: X-Mailer: Evolution 3.12.9-1+b1 MIME-Version: 1.0 X-DLP: MIA1 Cc: Embedded-pv-devel@lists.xenproject.org, Julien Grall , "xen-devel@lists.xen.org" Subject: Re: [Embedded-pv-devel] [Xen-devel] Size of irq field X-BeenThere: embedded-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: embedded-pv-devel-bounces@lists.xenproject.org Errors-To: embedded-pv-devel-bounces@lists.xenproject.org On Thu, 2015-04-02 at 18:05 +0300, Iurii Konovalenko wrote: > Hi, Julien! > > During bringing up Xen on Renesas Lager board we faced with problem. > A lot of Xen sources relies on statement, that IRQ number is less then > 256 and variables, parameters, fields etc. are of type uint8_t. Please can you give some example of this? Internally most irq stuff is unsigned int I think and "git grep uint8_t.*irq -- xen" is not showing lots of hits, there are a few but none which seem terribly scary or hard to fix. > But we > can have IRQs, that are greater then 255, for example on RCar H2 SoC. > Also, as I saw from one of your latest commits, GICv supports 1020 > physical interrupts. This has always been true, in fact Julien's commit was reducing the limit (which was too high), not increasing it. > As a result, overflow can occur. So it seems > logical to increase all irq staff to uint16_t or uint32_t. We have > local patches for increasing some structures, functions etc. > But before pushing these patches I want to know your opinion, what do > you think about this problem? What type should we use uint16_t or > uint32_t? How to find all places where uint8_t type is used for IRQ? We should certainly fix anywhere which is not using a large enough data type. Ian. _______________________________________________ Embedded-pv-devel mailing list Embedded-pv-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/embedded-pv-devel From embedded-pv-devel-bounces@lists.xenproject.org Fri Apr 03 12:40:06 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 03 Apr 2015 12:40:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Ye0tK-0006Dh-BQ; Fri, 03 Apr 2015 12:40:06 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Ye0tJ-0006DL-Ap for Embedded-pv-devel@lists.xenproject.org; Fri, 03 Apr 2015 12:40:05 +0000 Received: from [193.109.254.147] by server-15.bemta-14.messagelabs.com id 9D/2B-29893-42A8E155; Fri, 03 Apr 2015 12:40:04 +0000 X-Env-Sender: iurii.konovalenko@globallogic.com X-Msg-Ref: server-10.tower-27.messagelabs.com!1428064800!15447539!1 X-Originating-IP: [64.18.0.192] X-SpamReason: No, hits=0.4 required=7.0 tests=HTML_30_40,HTML_MESSAGE, RCVD_BY_IP X-StarScan-Received: X-StarScan-Version: 6.13.6; banners=-,-,- X-VirusChecked: Checked Received: (qmail 11665 invoked from network); 3 Apr 2015 12:40:02 -0000 Received: from exprod5og122.obsmtp.com (HELO exprod5og122.obsmtp.com) (64.18.0.192) by server-10.tower-27.messagelabs.com with DHE-RSA-AES256-SHA encrypted SMTP; 3 Apr 2015 12:40:02 -0000 Received: from mail-ig0-f177.google.com ([209.85.213.177]) (using TLSv1) by exprod5ob122.postini.com ([64.18.4.12]) with SMTP ID DSNKVR6KIGM1pZPHmUKU+Mpyg1EE0Q9uayDt@postini.com; Fri, 03 Apr 2015 05:40:02 PDT Received: by igbqf9 with SMTP id qf9so94274257igb.1 for ; Fri, 03 Apr 2015 05:40:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=globallogic.com; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=pbwOxb2Bsxcnp37s5FUaGr85nI1KDiCzcpn2XNyNgbU=; b=YXFHre83cb5oYn4EH3enwTlAwGlo6g0qXhWMX0oAlveem0+rLqXG+AlxSNJHVm7MMW Hr387s63y07+2q2dtoFPAKjmQlewOcrS7VuKMEuSjQCE8AWVgVJXkyNkGZqGWpnz66e+ NV4a7OwmPgu6nn1LRp9n/WKP2AQYw/YD42nHU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=pbwOxb2Bsxcnp37s5FUaGr85nI1KDiCzcpn2XNyNgbU=; b=LoYTXr0L4J5cu30uTydVACpbo95FRg9X+/Hi5u95aWdl0hjdZ52eGqoTL/MBgnO+Fe tyawjOJt4WTlBbRZKzsT1LcVZqSzXRdPl98AkNa63DitD0s9jvh0OWDMD3mDOtHYLEti lJZa/QmeZHHGgdAY2K1bYnUAco9z5TemH250VS9nGFKdBNiarsuqrqiLRCibA7kRW376 gGjVwNXZjJkfPqe/NC/Tu0cfoBB6o8hjS6cJDpQ5ilhzFmu+l6vkyhpHh5E/WEd/Y2Cf ATlbQea+aw322KvkHF50/T5NfIQxrDocm8drRSquXy+VcWF29L/DYDy5bO71FqCGPCWH 2Qpg== X-Gm-Message-State: ALoCoQnSDQG0r1+XKfWmgEAOB0LndtcSA+d/MPjQPpA55r+PFC1fYluC9tEXgQGKrOd0dg0tVnTjnzHfytFn0yLKLweImjp+5cMWhUmEfgIiC2uAZtPcsAoSWh4hc7Pg+kKY+Mg2uAP/34DMNUOXnWaHhRGypRTL6//MYpzgO75vQuAEMQrffpY= X-Received: by 10.107.31.206 with SMTP id f197mr3504244iof.19.1428064800223; Fri, 03 Apr 2015 05:40:00 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.107.31.206 with SMTP id f197mr3504220iof.19.1428064800091; Fri, 03 Apr 2015 05:40:00 -0700 (PDT) Received: by 10.36.123.207 with HTTP; Fri, 3 Apr 2015 05:40:00 -0700 (PDT) In-Reply-To: <551D61A2.6020201@citrix.com> References: <551D61A2.6020201@citrix.com> Date: Fri, 3 Apr 2015 15:40:00 +0300 Message-ID: From: Iurii Konovalenko To: Julien Grall Cc: Embedded-pv-devel@lists.xenproject.org, Julien Grall , Ian Campbell , Stefano Stabellini , "xen-devel@lists.xen.org" Subject: Re: [Embedded-pv-devel] [Xen-devel] Size of irq field X-BeenThere: embedded-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3607453400884939019==" Sender: embedded-pv-devel-bounces@lists.xenproject.org Errors-To: embedded-pv-devel-bounces@lists.xenproject.org --===============3607453400884939019== Content-Type: multipart/alternative; boundary=001a11402ada20656e0512d13f60 --001a11402ada20656e0512d13f60 Content-Type: text/plain; charset=UTF-8 Hi, Ian! Hi, Julien! Thank you for your replies. On Thu, Apr 2, 2015 at 6:19 PM, Ian Campbell wrote: > Please can you give some example of this? On Thu, Apr 2, 2015 at 6:34 PM, Julien Grall wrote: > Can you give an example of files/structures using uint8_t for IRQ? As Julien wrote, it is related to irq_permission. I am not sure if it is supported on ARM, but we use it, and this function fails during domain creation, because IRQ number is truncated and permission operation is applied for incorrect IRQ, so domain creation fails. So, do we need to change logic and do not check IRQ permissions? In tools/libxc/include/xenctrl.h: int xc_domain_irq_permission(xc_interface *xch, uint32_t domid, *uint8_t* pirq, uint8_t allow_access); In tools/libxc/xc_domain.c: int xc_domain_irq_permission(xc_interface *xch, uint32_t domid, *uint8_t* pirq, uint8_t allow_access) In xen/include/public/domctl.h: struct xen_domctl_irq_permission { *uint8_t* pirq; uint8_t allow_access; }; Also, as we plan to use passtrough, we there are such places: In tools/libxc/include/xenctrl.h: int xc_domain_bind_pt_irq(xc_interface *xch, uint32_t domid, *uint8_t* machine_irq, uint8_t irq_type, uint8_t bus, uint8_t device, uint8_t intx, uint8_t isa_irq); int xc_domain_unbind_pt_irq(xc_interface *xch, uint32_t domid, *uint8_t* machine_irq, uint8_t irq_type, uint8_t bus, uint8_t device, uint8_t intx, uint8_t isa_irq); int xc_domain_bind_pt_pci_irq(xc_interface *xch, uint32_t domid, *uint8_t* machine_irq, uint8_t bus, uint8_t device, uint8_t intx); int xc_domain_bind_pt_isa_irq(xc_interface *xch, uint32_t domid, *uint8_t* machine_irq); And theirs implementation in tools/libxc/xc_domain.c On Thu, Apr 2, 2015 at 6:19 PM, Ian Campbell wrote: > We should certainly fix anywhere which is not using a large enough data > type. On Thu, Apr 2, 2015 at 6:34 PM, Julien Grall wrote: > Ideally the IRQ should use uint32_t. This is allow us to support LPIs (IRQ > number start a 8192 up to a very high number). I have patch that increase size to uint32_t for cases, I described previously. Can I push it for review? Best regards. Iurii Konovalenko | Senior Software Engineer GlobalLogic --001a11402ada20656e0512d13f60 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: base64 PGRpdiBkaXI9Imx0ciI+PGRpdj48ZGl2PjxkaXY+PGRpdj5IaSwgSWFuISBIaSwgSnVsaWVuITxi cj5UaGFuayB5b3UgZm9yIHlvdXIgcmVwbGllcy48YnI+PGJyPk9uIFRodSwgQXByIDIsIDIwMTUg YXQgNjoxOSBQTSwgSWFuIENhbXBiZWxsICZsdDs8YSBocmVmPSJtYWlsdG86aWFuLmNhbXBiZWxs QGNpdHJpeC5jb20iPmlhbi5jYW1wYmVsbEBjaXRyaXguY29tPC9hPiZndDsgd3JvdGU6PGJyPiZn dDsgUGxlYXNlIGNhbiB5b3UgZ2l2ZSBzb21lIGV4YW1wbGUgb2YgdGhpcz88YnI+T24gVGh1LCBB cHIgMiwgMjAxNSBhdCA2OjM0IFBNLCBKdWxpZW4gR3JhbGwgJmx0OzxhIGhyZWY9Im1haWx0bzpq dWxpZW4uZ3JhbGxAY2l0cml4LmNvbSI+anVsaWVuLmdyYWxsQGNpdHJpeC5jb208L2E+Jmd0OyB3 cm90ZTo8YnI+Jmd0OyBDYW4geW91IGdpdmUgYW4gZXhhbXBsZSBvZiBmaWxlcy9zdHJ1Y3R1cmVz IHVzaW5nIHVpbnQ4X3QgZm9yIElSUT88YnI+PGJyPkFzIEp1bGllbiB3cm90ZSwgaXQgaXMgcmVs YXRlZCB0byBpcnFfcGVybWlzc2lvbi4gSSBhbSBub3Qgc3VyZSBpZiBpdCBpcyBzdXBwb3J0ZWQg b24gQVJNLCBidXQgd2UgdXNlIGl0LCBhbmQgdGhpcyBmdW5jdGlvbiBmYWlscyBkdXJpbmcgZG9t YWluIGNyZWF0aW9uLCBiZWNhdXNlIElSUSBudW1iZXIgaXMgdHJ1bmNhdGVkIGFuZCBwZXJtaXNz aW9uIG9wZXJhdGlvbiBpcyBhcHBsaWVkIGZvciBpbmNvcnJlY3QgSVJRLCBzbyBkb21haW4gY3Jl YXRpb24gZmFpbHMuIFNvLCBkbyB3ZSBuZWVkIHRvIGNoYW5nZSBsb2dpYyBhbmQgZG8gbm90IGNo ZWNrIElSUSBwZXJtaXNzaW9ucz88YnI+PGJyPkluIHRvb2xzL2xpYnhjL2luY2x1ZGUveGVuY3Ry bC5oOjxicj5pbnQgeGNfZG9tYWluX2lycV9wZXJtaXNzaW9uKHhjX2ludGVyZmFjZSAqeGNoLDxi cj7CoMKgwqAgdWludDMyX3QgZG9taWQsIDxicj7CoMKgwqAgPGI+dWludDhfdDwvYj4gcGlycSw8 YnI+wqDCoMKgIHVpbnQ4X3QgYWxsb3dfYWNjZXNzKTs8YnI+PC9kaXY+PGJyPkluIDxzcGFuIGNs YXNzPSIiPnRvb2xzL2xpYnhjL3hjX2RvbWFpbi5jOjxicj48L3NwYW4+aW50IHhjX2RvbWFpbl9p cnFfcGVybWlzc2lvbih4Y19pbnRlcmZhY2UgKnhjaCw8YnI+wqDCoMKgIHVpbnQzMl90IGRvbWlk LCA8YnI+wqDCoMKgIDxiPnVpbnQ4X3Q8L2I+IHBpcnEsPGJyPsKgwqDCoCB1aW50OF90IGFsbG93 X2FjY2Vzcyk8YnI+PGJyPjwvZGl2PkluIDxzcGFuIGNsYXNzPSIiPnhlbi9pbmNsdWRlL3B1Ymxp Yy9kb21jdGwuaDo8YnI+PC9zcGFuPjxzcGFuIGNsYXNzPSIiPnN0cnVjdDwvc3Bhbj48c3BhbiBj bGFzcz0iIj4geGVuX2RvbWN0bF9pcnFfcGVybWlzc2lvbiA8L3NwYW4+PHNwYW4gY2xhc3M9IiI+ ezxicj7CoMKgwqAgPC9zcGFuPjxiPjxzcGFuIGNsYXNzPSIiPjxzcGFuIGNsYXNzPSIiPnVpbnQ8 L3NwYW4+PC9zcGFuPjxzcGFuIGNsYXNzPSIiPjxzcGFuIGNsYXNzPSIiPjg8L3NwYW4+PC9zcGFu PjxzcGFuIGNsYXNzPSIiPl90PC9zcGFuPjwvYj48c3BhbiBjbGFzcz0iIj4gcGlycTwvc3Bhbj48 c3BhbiBjbGFzcz0iIj47PGJyPsKgwqDCoCA8L3NwYW4+PHNwYW4gY2xhc3M9IiI+dWludDhfdDwv c3Bhbj48c3BhbiBjbGFzcz0iIj4gYWxsb3dfYWNjZXNzPC9zcGFuPjxzcGFuIGNsYXNzPSIiPjs8 L3NwYW4+PHNwYW4gY2xhc3M9IiI+PGJyPn07PGJyPjxicj48L3NwYW4+PC9kaXY+PHNwYW4gY2xh c3M9IiI+QWxzbywgYXMgd2UgcGxhbiB0byB1c2UgcGFzc3Ryb3VnaCwgd2UgdGhlcmUgYXJlIHN1 Y2ggcGxhY2VzOjxicj48L3NwYW4+PC9kaXY+PHNwYW4gY2xhc3M9IiI+SW4gdG9vbHMvbGlieGMv aW5jbHVkZS94ZW5jdHJsLmg6PGJyPmludCB4Y19kb21haW5fYmluZF9wdF9pcnEoeGNfaW50ZXJm YWNlICp4Y2gsPGJyPsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgIHVpbnQzMl90IGRvbWlkLDxicj7CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCA8Yj51aW50OF90PC9iPiBtYWNoaW5lX2lycSw8YnI+wqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdWludDhfdCBpcnFf dHlwZSw8YnI+wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgdWludDhfdCBidXMsPGJyPsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIHVpbnQ4X3QgZGV2aWNlLDxicj7CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1aW50OF90IGludHgsPGJyPsKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVpbnQ4X3QgaXNhX2lycSk7PGJy Pjxicj5pbnQgeGNfZG9tYWluX3VuYmluZF9wdF9pcnEoeGNfaW50ZXJmYWNlICp4Y2gsPGJyPsKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVpbnQzMl90 IGRvbWlkLDxicj7CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoCA8Yj51aW50OF90PC9iPiBtYWNoaW5lX2lycSw8YnI+wqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdWludDhfdCBpcnFfdHlwZSw8YnI+wqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdWludDhfdCBidXMs PGJyPsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVp bnQ4X3QgZGV2aWNlLDxicj7CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCB1aW50OF90IGludHgsPGJyPsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVpbnQ4X3QgaXNhX2lycSk7PGJyPjxicj5pbnQgeGNfZG9t YWluX2JpbmRfcHRfcGNpX2lycSh4Y19pbnRlcmZhY2UgKnhjaCw8YnI+wqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1aW50MzJfdCBkb21p ZCw8YnI+wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCA8Yj51aW50OF90PC9iPiBtYWNoaW5lX2lycSw8YnI+wqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1aW50OF90IGJ1cyw8YnI+ wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCB1aW50OF90IGRldmljZSw8YnI+wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1aW50OF90IGludHgpOzxicj48YnI+aW50IHhjX2RvbWFp bl9iaW5kX3B0X2lzYV9pcnEoeGNfaW50ZXJmYWNlICp4Y2gsPGJyPsKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdWludDMyX3QgZG9taWQs PGJyPsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqAgPGI+dWludDhfdDwvYj4gbWFjaGluZV9pcnEpOzxicj48YnI+PC9zcGFuPjxkaXY+PHNw YW4gY2xhc3M9IiI+QW5kIHRoZWlycyBpbXBsZW1lbnRhdGlvbiBpbiB0b29scy9saWJ4Yy94Y19k b21haW4uYzxicj48YnI+PC9zcGFuPjwvZGl2PjxkaXY+PGRpdj48ZGl2PjxkaXY+PGJyPk9uIFRo dSwgQXByIDIsIDIwMTUgYXQgNjoxOSBQTSwgSWFuIENhbXBiZWxsICZsdDs8YSBocmVmPSJtYWls dG86aWFuLmNhbXBiZWxsQGNpdHJpeC5jb20iPmlhbi5jYW1wYmVsbEBjaXRyaXguY29tPC9hPiZn dDsgd3JvdGU6PGJyPiZndDsgV2Ugc2hvdWxkIGNlcnRhaW5seSBmaXggYW55d2hlcmUgd2hpY2gg aXMgbm90IHVzaW5nIGEgbGFyZ2UgZW5vdWdoIGRhdGE8YnI+Jmd0OyB0eXBlLjxicj5PbiBUaHUs IEFwciAyLCAyMDE1IGF0IDY6MzQgUE0sIEp1bGllbiBHcmFsbCAmbHQ7PGEgaHJlZj0ibWFpbHRv Omp1bGllbi5ncmFsbEBjaXRyaXguY29tIj5qdWxpZW4uZ3JhbGxAY2l0cml4LmNvbTwvYT4mZ3Q7 IHdyb3RlOjxicj4mZ3Q7IElkZWFsbHkgdGhlIElSUSBzaG91bGQgdXNlIHVpbnQzMl90LiBUaGlz IGlzIGFsbG93IHVzIHRvIHN1cHBvcnQgTFBJcyAoSVJRPGJyPiZndDsgbnVtYmVyIHN0YXJ0IGEg ODE5MiB1cCB0byBhIHZlcnkgaGlnaCBudW1iZXIpLjxicj48YnI+PC9kaXY+PGRpdj5JIGhhdmUg cGF0Y2ggdGhhdCBpbmNyZWFzZSBzaXplIHRvIHVpbnQzMl90IGZvciBjYXNlcywgSSBkZXNjcmli ZWQgcHJldmlvdXNseS4gQ2FuIEkgcHVzaCBpdCBmb3IgcmV2aWV3Pzxicj48YnI+PGRpdj5CZXN0 IHJlZ2FyZHMuPC9kaXY+PGRpdj48YnI+PHNwYW4gc3R5bGU9ImZvbnQtZmFtaWx5OkFyaWFsO2Zv bnQtc2l6ZToxMnB4O2ZvbnQtc3R5bGU6bm9ybWFsO2ZvbnQtdmFyaWFudDpub3JtYWw7dGV4dC1k ZWNvcmF0aW9uOm5vbmU7dmVydGljYWwtYWxpZ246YmFzZWxpbmU7YmFja2dyb3VuZC1jb2xvcjp0 cmFuc3BhcmVudCI+SXVyaWkgS29ub3ZhbGVua2/CoHwgU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy PC9zcGFuPjwvZGl2PjxkaXY+PHNwYW4gc3R5bGU9ImZvbnQtZmFtaWx5OkFyaWFsO2ZvbnQtc2l6 ZToxMnB4O2ZvbnQtc3R5bGU6bm9ybWFsO2ZvbnQtdmFyaWFudDpub3JtYWw7Zm9udC13ZWlnaHQ6 Ym9sZDt0ZXh0LWRlY29yYXRpb246bm9uZTt2ZXJ0aWNhbC1hbGlnbjpiYXNlbGluZTtiYWNrZ3Jv dW5kLWNvbG9yOnRyYW5zcGFyZW50Ij48L3NwYW4+PHNwYW4gc3R5bGU9ImZvbnQtZmFtaWx5OkFy aWFsO2ZvbnQtc2l6ZToxMnB4O2ZvbnQtc3R5bGU6bm9ybWFsO2ZvbnQtdmFyaWFudDpub3JtYWw7 Zm9udC13ZWlnaHQ6bm9ybWFsO3RleHQtZGVjb3JhdGlvbjpub25lO3ZlcnRpY2FsLWFsaWduOmJh c2VsaW5lO2JhY2tncm91bmQtY29sb3I6dHJhbnNwYXJlbnQiPkdsb2JhbExvZ2ljPC9zcGFuPjwv ZGl2Pjxicj48L2Rpdj48L2Rpdj48L2Rpdj48L2Rpdj48L2Rpdj4NCg== --001a11402ada20656e0512d13f60-- --===============3607453400884939019== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Embedded-pv-devel mailing list Embedded-pv-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/embedded-pv-devel --===============3607453400884939019==-- From embedded-pv-devel-bounces@lists.xenproject.org Fri Apr 03 12:40:06 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 03 Apr 2015 12:40:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Ye0tK-0006Dh-BQ; Fri, 03 Apr 2015 12:40:06 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Ye0tJ-0006DL-Ap for Embedded-pv-devel@lists.xenproject.org; Fri, 03 Apr 2015 12:40:05 +0000 Received: from [193.109.254.147] by server-15.bemta-14.messagelabs.com id 9D/2B-29893-42A8E155; Fri, 03 Apr 2015 12:40:04 +0000 X-Env-Sender: iurii.konovalenko@globallogic.com X-Msg-Ref: server-10.tower-27.messagelabs.com!1428064800!15447539!1 X-Originating-IP: [64.18.0.192] X-SpamReason: No, hits=0.4 required=7.0 tests=HTML_30_40,HTML_MESSAGE, RCVD_BY_IP X-StarScan-Received: X-StarScan-Version: 6.13.6; banners=-,-,- X-VirusChecked: Checked Received: (qmail 11665 invoked from network); 3 Apr 2015 12:40:02 -0000 Received: from exprod5og122.obsmtp.com (HELO exprod5og122.obsmtp.com) (64.18.0.192) by server-10.tower-27.messagelabs.com with DHE-RSA-AES256-SHA encrypted SMTP; 3 Apr 2015 12:40:02 -0000 Received: from mail-ig0-f177.google.com ([209.85.213.177]) (using TLSv1) by exprod5ob122.postini.com ([64.18.4.12]) with SMTP ID DSNKVR6KIGM1pZPHmUKU+Mpyg1EE0Q9uayDt@postini.com; Fri, 03 Apr 2015 05:40:02 PDT Received: by igbqf9 with SMTP id qf9so94274257igb.1 for ; Fri, 03 Apr 2015 05:40:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=globallogic.com; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=pbwOxb2Bsxcnp37s5FUaGr85nI1KDiCzcpn2XNyNgbU=; b=YXFHre83cb5oYn4EH3enwTlAwGlo6g0qXhWMX0oAlveem0+rLqXG+AlxSNJHVm7MMW Hr387s63y07+2q2dtoFPAKjmQlewOcrS7VuKMEuSjQCE8AWVgVJXkyNkGZqGWpnz66e+ NV4a7OwmPgu6nn1LRp9n/WKP2AQYw/YD42nHU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=pbwOxb2Bsxcnp37s5FUaGr85nI1KDiCzcpn2XNyNgbU=; b=LoYTXr0L4J5cu30uTydVACpbo95FRg9X+/Hi5u95aWdl0hjdZ52eGqoTL/MBgnO+Fe tyawjOJt4WTlBbRZKzsT1LcVZqSzXRdPl98AkNa63DitD0s9jvh0OWDMD3mDOtHYLEti lJZa/QmeZHHGgdAY2K1bYnUAco9z5TemH250VS9nGFKdBNiarsuqrqiLRCibA7kRW376 gGjVwNXZjJkfPqe/NC/Tu0cfoBB6o8hjS6cJDpQ5ilhzFmu+l6vkyhpHh5E/WEd/Y2Cf ATlbQea+aw322KvkHF50/T5NfIQxrDocm8drRSquXy+VcWF29L/DYDy5bO71FqCGPCWH 2Qpg== X-Gm-Message-State: ALoCoQnSDQG0r1+XKfWmgEAOB0LndtcSA+d/MPjQPpA55r+PFC1fYluC9tEXgQGKrOd0dg0tVnTjnzHfytFn0yLKLweImjp+5cMWhUmEfgIiC2uAZtPcsAoSWh4hc7Pg+kKY+Mg2uAP/34DMNUOXnWaHhRGypRTL6//MYpzgO75vQuAEMQrffpY= X-Received: by 10.107.31.206 with SMTP id f197mr3504244iof.19.1428064800223; Fri, 03 Apr 2015 05:40:00 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.107.31.206 with SMTP id f197mr3504220iof.19.1428064800091; Fri, 03 Apr 2015 05:40:00 -0700 (PDT) Received: by 10.36.123.207 with HTTP; Fri, 3 Apr 2015 05:40:00 -0700 (PDT) In-Reply-To: <551D61A2.6020201@citrix.com> References: <551D61A2.6020201@citrix.com> Date: Fri, 3 Apr 2015 15:40:00 +0300 Message-ID: From: Iurii Konovalenko To: Julien Grall Cc: Embedded-pv-devel@lists.xenproject.org, Julien Grall , Ian Campbell , Stefano Stabellini , "xen-devel@lists.xen.org" Subject: Re: [Embedded-pv-devel] [Xen-devel] Size of irq field X-BeenThere: embedded-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3607453400884939019==" Sender: embedded-pv-devel-bounces@lists.xenproject.org Errors-To: embedded-pv-devel-bounces@lists.xenproject.org --===============3607453400884939019== Content-Type: multipart/alternative; boundary=001a11402ada20656e0512d13f60 --001a11402ada20656e0512d13f60 Content-Type: text/plain; charset=UTF-8 Hi, Ian! Hi, Julien! Thank you for your replies. On Thu, Apr 2, 2015 at 6:19 PM, Ian Campbell wrote: > Please can you give some example of this? On Thu, Apr 2, 2015 at 6:34 PM, Julien Grall wrote: > Can you give an example of files/structures using uint8_t for IRQ? As Julien wrote, it is related to irq_permission. I am not sure if it is supported on ARM, but we use it, and this function fails during domain creation, because IRQ number is truncated and permission operation is applied for incorrect IRQ, so domain creation fails. So, do we need to change logic and do not check IRQ permissions? In tools/libxc/include/xenctrl.h: int xc_domain_irq_permission(xc_interface *xch, uint32_t domid, *uint8_t* pirq, uint8_t allow_access); In tools/libxc/xc_domain.c: int xc_domain_irq_permission(xc_interface *xch, uint32_t domid, *uint8_t* pirq, uint8_t allow_access) In xen/include/public/domctl.h: struct xen_domctl_irq_permission { *uint8_t* pirq; uint8_t allow_access; }; Also, as we plan to use passtrough, we there are such places: In tools/libxc/include/xenctrl.h: int xc_domain_bind_pt_irq(xc_interface *xch, uint32_t domid, *uint8_t* machine_irq, uint8_t irq_type, uint8_t bus, uint8_t device, uint8_t intx, uint8_t isa_irq); int xc_domain_unbind_pt_irq(xc_interface *xch, uint32_t domid, *uint8_t* machine_irq, uint8_t irq_type, uint8_t bus, uint8_t device, uint8_t intx, uint8_t isa_irq); int xc_domain_bind_pt_pci_irq(xc_interface *xch, uint32_t domid, *uint8_t* machine_irq, uint8_t bus, uint8_t device, uint8_t intx); int xc_domain_bind_pt_isa_irq(xc_interface *xch, uint32_t domid, *uint8_t* machine_irq); And theirs implementation in tools/libxc/xc_domain.c On Thu, Apr 2, 2015 at 6:19 PM, Ian Campbell wrote: > We should certainly fix anywhere which is not using a large enough data > type. On Thu, Apr 2, 2015 at 6:34 PM, Julien Grall wrote: > Ideally the IRQ should use uint32_t. This is allow us to support LPIs (IRQ > number start a 8192 up to a very high number). I have patch that increase size to uint32_t for cases, I described previously. Can I push it for review? Best regards. Iurii Konovalenko | Senior Software Engineer GlobalLogic --001a11402ada20656e0512d13f60 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: base64 PGRpdiBkaXI9Imx0ciI+PGRpdj48ZGl2PjxkaXY+PGRpdj5IaSwgSWFuISBIaSwgSnVsaWVuITxi cj5UaGFuayB5b3UgZm9yIHlvdXIgcmVwbGllcy48YnI+PGJyPk9uIFRodSwgQXByIDIsIDIwMTUg YXQgNjoxOSBQTSwgSWFuIENhbXBiZWxsICZsdDs8YSBocmVmPSJtYWlsdG86aWFuLmNhbXBiZWxs QGNpdHJpeC5jb20iPmlhbi5jYW1wYmVsbEBjaXRyaXguY29tPC9hPiZndDsgd3JvdGU6PGJyPiZn dDsgUGxlYXNlIGNhbiB5b3UgZ2l2ZSBzb21lIGV4YW1wbGUgb2YgdGhpcz88YnI+T24gVGh1LCBB cHIgMiwgMjAxNSBhdCA2OjM0IFBNLCBKdWxpZW4gR3JhbGwgJmx0OzxhIGhyZWY9Im1haWx0bzpq dWxpZW4uZ3JhbGxAY2l0cml4LmNvbSI+anVsaWVuLmdyYWxsQGNpdHJpeC5jb208L2E+Jmd0OyB3 cm90ZTo8YnI+Jmd0OyBDYW4geW91IGdpdmUgYW4gZXhhbXBsZSBvZiBmaWxlcy9zdHJ1Y3R1cmVz IHVzaW5nIHVpbnQ4X3QgZm9yIElSUT88YnI+PGJyPkFzIEp1bGllbiB3cm90ZSwgaXQgaXMgcmVs YXRlZCB0byBpcnFfcGVybWlzc2lvbi4gSSBhbSBub3Qgc3VyZSBpZiBpdCBpcyBzdXBwb3J0ZWQg b24gQVJNLCBidXQgd2UgdXNlIGl0LCBhbmQgdGhpcyBmdW5jdGlvbiBmYWlscyBkdXJpbmcgZG9t YWluIGNyZWF0aW9uLCBiZWNhdXNlIElSUSBudW1iZXIgaXMgdHJ1bmNhdGVkIGFuZCBwZXJtaXNz aW9uIG9wZXJhdGlvbiBpcyBhcHBsaWVkIGZvciBpbmNvcnJlY3QgSVJRLCBzbyBkb21haW4gY3Jl YXRpb24gZmFpbHMuIFNvLCBkbyB3ZSBuZWVkIHRvIGNoYW5nZSBsb2dpYyBhbmQgZG8gbm90IGNo ZWNrIElSUSBwZXJtaXNzaW9ucz88YnI+PGJyPkluIHRvb2xzL2xpYnhjL2luY2x1ZGUveGVuY3Ry bC5oOjxicj5pbnQgeGNfZG9tYWluX2lycV9wZXJtaXNzaW9uKHhjX2ludGVyZmFjZSAqeGNoLDxi cj7CoMKgwqAgdWludDMyX3QgZG9taWQsIDxicj7CoMKgwqAgPGI+dWludDhfdDwvYj4gcGlycSw8 YnI+wqDCoMKgIHVpbnQ4X3QgYWxsb3dfYWNjZXNzKTs8YnI+PC9kaXY+PGJyPkluIDxzcGFuIGNs YXNzPSIiPnRvb2xzL2xpYnhjL3hjX2RvbWFpbi5jOjxicj48L3NwYW4+aW50IHhjX2RvbWFpbl9p cnFfcGVybWlzc2lvbih4Y19pbnRlcmZhY2UgKnhjaCw8YnI+wqDCoMKgIHVpbnQzMl90IGRvbWlk LCA8YnI+wqDCoMKgIDxiPnVpbnQ4X3Q8L2I+IHBpcnEsPGJyPsKgwqDCoCB1aW50OF90IGFsbG93 X2FjY2Vzcyk8YnI+PGJyPjwvZGl2PkluIDxzcGFuIGNsYXNzPSIiPnhlbi9pbmNsdWRlL3B1Ymxp Yy9kb21jdGwuaDo8YnI+PC9zcGFuPjxzcGFuIGNsYXNzPSIiPnN0cnVjdDwvc3Bhbj48c3BhbiBj bGFzcz0iIj4geGVuX2RvbWN0bF9pcnFfcGVybWlzc2lvbiA8L3NwYW4+PHNwYW4gY2xhc3M9IiI+ ezxicj7CoMKgwqAgPC9zcGFuPjxiPjxzcGFuIGNsYXNzPSIiPjxzcGFuIGNsYXNzPSIiPnVpbnQ8 L3NwYW4+PC9zcGFuPjxzcGFuIGNsYXNzPSIiPjxzcGFuIGNsYXNzPSIiPjg8L3NwYW4+PC9zcGFu PjxzcGFuIGNsYXNzPSIiPl90PC9zcGFuPjwvYj48c3BhbiBjbGFzcz0iIj4gcGlycTwvc3Bhbj48 c3BhbiBjbGFzcz0iIj47PGJyPsKgwqDCoCA8L3NwYW4+PHNwYW4gY2xhc3M9IiI+dWludDhfdDwv c3Bhbj48c3BhbiBjbGFzcz0iIj4gYWxsb3dfYWNjZXNzPC9zcGFuPjxzcGFuIGNsYXNzPSIiPjs8 L3NwYW4+PHNwYW4gY2xhc3M9IiI+PGJyPn07PGJyPjxicj48L3NwYW4+PC9kaXY+PHNwYW4gY2xh c3M9IiI+QWxzbywgYXMgd2UgcGxhbiB0byB1c2UgcGFzc3Ryb3VnaCwgd2UgdGhlcmUgYXJlIHN1 Y2ggcGxhY2VzOjxicj48L3NwYW4+PC9kaXY+PHNwYW4gY2xhc3M9IiI+SW4gdG9vbHMvbGlieGMv aW5jbHVkZS94ZW5jdHJsLmg6PGJyPmludCB4Y19kb21haW5fYmluZF9wdF9pcnEoeGNfaW50ZXJm YWNlICp4Y2gsPGJyPsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgIHVpbnQzMl90IGRvbWlkLDxicj7CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCA8Yj51aW50OF90PC9iPiBtYWNoaW5lX2lycSw8YnI+wqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdWludDhfdCBpcnFf dHlwZSw8YnI+wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgdWludDhfdCBidXMsPGJyPsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIHVpbnQ4X3QgZGV2aWNlLDxicj7CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1aW50OF90IGludHgsPGJyPsKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVpbnQ4X3QgaXNhX2lycSk7PGJy Pjxicj5pbnQgeGNfZG9tYWluX3VuYmluZF9wdF9pcnEoeGNfaW50ZXJmYWNlICp4Y2gsPGJyPsKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVpbnQzMl90 IGRvbWlkLDxicj7CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoCA8Yj51aW50OF90PC9iPiBtYWNoaW5lX2lycSw8YnI+wqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdWludDhfdCBpcnFfdHlwZSw8YnI+wqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdWludDhfdCBidXMs PGJyPsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVp bnQ4X3QgZGV2aWNlLDxicj7CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCB1aW50OF90IGludHgsPGJyPsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVpbnQ4X3QgaXNhX2lycSk7PGJyPjxicj5pbnQgeGNfZG9t YWluX2JpbmRfcHRfcGNpX2lycSh4Y19pbnRlcmZhY2UgKnhjaCw8YnI+wqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1aW50MzJfdCBkb21p ZCw8YnI+wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCA8Yj51aW50OF90PC9iPiBtYWNoaW5lX2lycSw8YnI+wqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1aW50OF90IGJ1cyw8YnI+ wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCB1aW50OF90IGRldmljZSw8YnI+wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1aW50OF90IGludHgpOzxicj48YnI+aW50IHhjX2RvbWFp bl9iaW5kX3B0X2lzYV9pcnEoeGNfaW50ZXJmYWNlICp4Y2gsPGJyPsKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdWludDMyX3QgZG9taWQs PGJyPsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqAgPGI+dWludDhfdDwvYj4gbWFjaGluZV9pcnEpOzxicj48YnI+PC9zcGFuPjxkaXY+PHNw YW4gY2xhc3M9IiI+QW5kIHRoZWlycyBpbXBsZW1lbnRhdGlvbiBpbiB0b29scy9saWJ4Yy94Y19k b21haW4uYzxicj48YnI+PC9zcGFuPjwvZGl2PjxkaXY+PGRpdj48ZGl2PjxkaXY+PGJyPk9uIFRo dSwgQXByIDIsIDIwMTUgYXQgNjoxOSBQTSwgSWFuIENhbXBiZWxsICZsdDs8YSBocmVmPSJtYWls dG86aWFuLmNhbXBiZWxsQGNpdHJpeC5jb20iPmlhbi5jYW1wYmVsbEBjaXRyaXguY29tPC9hPiZn dDsgd3JvdGU6PGJyPiZndDsgV2Ugc2hvdWxkIGNlcnRhaW5seSBmaXggYW55d2hlcmUgd2hpY2gg aXMgbm90IHVzaW5nIGEgbGFyZ2UgZW5vdWdoIGRhdGE8YnI+Jmd0OyB0eXBlLjxicj5PbiBUaHUs IEFwciAyLCAyMDE1IGF0IDY6MzQgUE0sIEp1bGllbiBHcmFsbCAmbHQ7PGEgaHJlZj0ibWFpbHRv Omp1bGllbi5ncmFsbEBjaXRyaXguY29tIj5qdWxpZW4uZ3JhbGxAY2l0cml4LmNvbTwvYT4mZ3Q7 IHdyb3RlOjxicj4mZ3Q7IElkZWFsbHkgdGhlIElSUSBzaG91bGQgdXNlIHVpbnQzMl90LiBUaGlz IGlzIGFsbG93IHVzIHRvIHN1cHBvcnQgTFBJcyAoSVJRPGJyPiZndDsgbnVtYmVyIHN0YXJ0IGEg ODE5MiB1cCB0byBhIHZlcnkgaGlnaCBudW1iZXIpLjxicj48YnI+PC9kaXY+PGRpdj5JIGhhdmUg cGF0Y2ggdGhhdCBpbmNyZWFzZSBzaXplIHRvIHVpbnQzMl90IGZvciBjYXNlcywgSSBkZXNjcmli ZWQgcHJldmlvdXNseS4gQ2FuIEkgcHVzaCBpdCBmb3IgcmV2aWV3Pzxicj48YnI+PGRpdj5CZXN0 IHJlZ2FyZHMuPC9kaXY+PGRpdj48YnI+PHNwYW4gc3R5bGU9ImZvbnQtZmFtaWx5OkFyaWFsO2Zv bnQtc2l6ZToxMnB4O2ZvbnQtc3R5bGU6bm9ybWFsO2ZvbnQtdmFyaWFudDpub3JtYWw7dGV4dC1k ZWNvcmF0aW9uOm5vbmU7dmVydGljYWwtYWxpZ246YmFzZWxpbmU7YmFja2dyb3VuZC1jb2xvcjp0 cmFuc3BhcmVudCI+SXVyaWkgS29ub3ZhbGVua2/CoHwgU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy PC9zcGFuPjwvZGl2PjxkaXY+PHNwYW4gc3R5bGU9ImZvbnQtZmFtaWx5OkFyaWFsO2ZvbnQtc2l6 ZToxMnB4O2ZvbnQtc3R5bGU6bm9ybWFsO2ZvbnQtdmFyaWFudDpub3JtYWw7Zm9udC13ZWlnaHQ6 Ym9sZDt0ZXh0LWRlY29yYXRpb246bm9uZTt2ZXJ0aWNhbC1hbGlnbjpiYXNlbGluZTtiYWNrZ3Jv dW5kLWNvbG9yOnRyYW5zcGFyZW50Ij48L3NwYW4+PHNwYW4gc3R5bGU9ImZvbnQtZmFtaWx5OkFy aWFsO2ZvbnQtc2l6ZToxMnB4O2ZvbnQtc3R5bGU6bm9ybWFsO2ZvbnQtdmFyaWFudDpub3JtYWw7 Zm9udC13ZWlnaHQ6bm9ybWFsO3RleHQtZGVjb3JhdGlvbjpub25lO3ZlcnRpY2FsLWFsaWduOmJh c2VsaW5lO2JhY2tncm91bmQtY29sb3I6dHJhbnNwYXJlbnQiPkdsb2JhbExvZ2ljPC9zcGFuPjwv ZGl2Pjxicj48L2Rpdj48L2Rpdj48L2Rpdj48L2Rpdj48L2Rpdj4NCg== --001a11402ada20656e0512d13f60-- --===============3607453400884939019== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Embedded-pv-devel mailing list Embedded-pv-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/embedded-pv-devel --===============3607453400884939019==-- From embedded-pv-devel-bounces@lists.xenproject.org Fri Apr 03 15:14:34 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 03 Apr 2015 15:14:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Ye3In-0003dG-MG; Fri, 03 Apr 2015 15:14:33 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Ye1hL-0000iL-Ev for Embedded-pv-devel@lists.xenproject.org; Fri, 03 Apr 2015 13:31:47 +0000 Received: from [85.158.139.211] by server-2.bemta-5.messagelabs.com id 08/D7-12190-2469E155; Fri, 03 Apr 2015 13:31:46 +0000 X-Env-Sender: julien.grall@citrix.com X-Msg-Ref: server-9.tower-206.messagelabs.com!1428067904!13676638!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.6; banners=-,-,- X-VirusChecked: Checked Received: (qmail 17716 invoked from network); 3 Apr 2015 13:31:45 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-9.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 3 Apr 2015 13:31:45 -0000 X-IronPort-AV: E=Sophos;i="5.11,517,1422921600"; d="scan'208";a="249642738" Message-ID: <551E963C.8000606@citrix.com> Date: Fri, 3 Apr 2015 15:31:40 +0200 From: Julien Grall User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Iurii Konovalenko , Julien Grall References: <551D61A2.6020201@citrix.com> In-Reply-To: X-DLP: MIA2 X-Mailman-Approved-At: Fri, 03 Apr 2015 15:14:33 +0000 Cc: Embedded-pv-devel@lists.xenproject.org, Julien Grall , "xen-devel@lists.xen.org" , Ian Campbell , Stefano Stabellini Subject: Re: [Embedded-pv-devel] [Xen-devel] Size of irq field X-BeenThere: embedded-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: embedded-pv-devel-bounces@lists.xenproject.org Errors-To: embedded-pv-devel-bounces@lists.xenproject.org On 03/04/2015 14:40, Iurii Konovalenko wrote: > Hi, Ian! Hi, Julien! Hi Iurii, > Thank you for your replies. > > On Thu, Apr 2, 2015 at 6:19 PM, Ian Campbell > wrote: > > Please can you give some example of this? > On Thu, Apr 2, 2015 at 6:34 PM, Julien Grall > wrote: > > Can you give an example of files/structures using uint8_t for IRQ? > > As Julien wrote, it is related to irq_permission. I am not sure if it is > supported on ARM, but we use it, and this function fails during domain > creation, because IRQ number is truncated and permission operation is > applied for incorrect IRQ, so domain creation fails. So, do we need to > change logic and do not check IRQ permissions? Where do you need to check the IRQ permission? Currently (with my DT device passthrough series) only DOM0 is able to manage the IRQ (i.e bind/unbind) and we don't let the guest to do it. So I don't think it's necessary to to call xc_domain_irq_permission for guest. The DOMCTL is buggy because it relies on vIRQ == IRQ as many place in Xen. Although it would work now because, we chose to map 1:1 the IRQ in the guest. > Also, as we plan to use passtrough, we there are such places: > In tools/libxc/include/xenctrl.h: > int xc_domain_bind_pt_irq(xc_interface *xch, > uint32_t domid, > *uint8_t* machine_irq, > uint8_t irq_type, > uint8_t bus, > uint8_t device, > uint8_t intx, > uint8_t isa_irq); > > int xc_domain_unbind_pt_irq(xc_interface *xch, > uint32_t domid, > *uint8_t* machine_irq, > uint8_t irq_type, > uint8_t bus, > uint8_t device, > uint8_t intx, > uint8_t isa_irq); > > int xc_domain_bind_pt_pci_irq(xc_interface *xch, > uint32_t domid, > *uint8_t* machine_irq, > uint8_t bus, > uint8_t device, > uint8_t intx); > > int xc_domain_bind_pt_isa_irq(xc_interface *xch, > uint32_t domid, > *uint8_t* machine_irq); > > And theirs implementation in tools/libxc/xc_domain.c Whoops. I didn't spot those one thanks. > > On Thu, Apr 2, 2015 at 6:19 PM, Ian Campbell > wrote: > > We should certainly fix anywhere which is not using a large enough data > > type. > On Thu, Apr 2, 2015 at 6:34 PM, Julien Grall > wrote: > > Ideally the IRQ should use uint32_t. This is allow us to support LPIs > (IRQ > > number start a 8192 up to a very high number). > > I have patch that increase size to uint32_t for cases, I described > previously. Can I push it for review? Yes please. Regards, -- Julien Grall _______________________________________________ Embedded-pv-devel mailing list Embedded-pv-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/embedded-pv-devel From embedded-pv-devel-bounces@lists.xenproject.org Fri Apr 03 15:14:34 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 03 Apr 2015 15:14:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Ye3In-0003dC-LK; Fri, 03 Apr 2015 15:14:33 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Ydh9l-0001mb-6u for Embedded-pv-devel@lists.xenproject.org; Thu, 02 Apr 2015 15:35:45 +0000 Received: from [193.109.254.147] by server-10.bemta-14.messagelabs.com id 3E/1A-06062-0D16D155; Thu, 02 Apr 2015 15:35:44 +0000 X-Env-Sender: julien.grall@citrix.com X-Msg-Ref: server-7.tower-27.messagelabs.com!1427988941!15253766!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.6; banners=-,-,- X-VirusChecked: Checked Received: (qmail 26765 invoked from network); 2 Apr 2015 15:35:43 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-7.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 2 Apr 2015 15:35:43 -0000 X-IronPort-AV: E=Sophos;i="5.11,511,1422921600"; d="scan'208";a="249191470" Message-ID: <551D61A2.6020201@citrix.com> Date: Thu, 2 Apr 2015 16:34:58 +0100 From: Julien Grall User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Iurii Konovalenko , Julien Grall References: In-Reply-To: X-DLP: MIA2 X-Mailman-Approved-At: Fri, 03 Apr 2015 15:14:33 +0000 Cc: Embedded-pv-devel@lists.xenproject.org, Stefano Stabellini , Ian Campbell , "xen-devel@lists.xen.org" Subject: Re: [Embedded-pv-devel] [Xen-devel] Size of irq field X-BeenThere: embedded-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: embedded-pv-devel-bounces@lists.xenproject.org Errors-To: embedded-pv-devel-bounces@lists.xenproject.org (CC Stefano and Ian) On 02/04/2015 16:05, Iurii Konovalenko wrote: > Hi, Julien! Hello Iurii, > > During bringing up Xen on Renesas Lager board we faced with problem. > A lot of Xen sources relies on statement, that IRQ number is less then > 256 and variables, parameters, fields etc. are of type uint8_t. But we > can have IRQs, that are greater then 255, for example on RCar H2 SoC. > Also, as I saw from one of your latest commits, GICv supports 1020 > physical interrupts. As a result, overflow can occur. So it seems > logical to increase all irq staff to uint16_t or uint32_t. We have > local patches for increasing some structures, functions etc. > But before pushing these patches I want to know your opinion, what do > you think about this problem? What type should we use uint16_t or > uint32_t? How to find all places where uint8_t type is used for IRQ? I'm a bit surprised. I looked through the hypervisor and libxl and I was able to found only one place (DOMCTL_irq_permission which is not really supported on ARM). We are usually using uint32_t/int for IRQ. Can you give an example of files/structures using uint8_t for IRQ? Ideally the IRQ should use uint32_t. This is allow us to support LPIs (IRQ number start a 8192 up to a very high number). > Best regards. Regards, -- Julien Grall _______________________________________________ Embedded-pv-devel mailing list Embedded-pv-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/embedded-pv-devel From embedded-pv-devel-bounces@lists.xenproject.org Fri Apr 03 15:14:34 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 03 Apr 2015 15:14:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Ye3In-0003dG-MG; Fri, 03 Apr 2015 15:14:33 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Ye1hL-0000iL-Ev for Embedded-pv-devel@lists.xenproject.org; Fri, 03 Apr 2015 13:31:47 +0000 Received: from [85.158.139.211] by server-2.bemta-5.messagelabs.com id 08/D7-12190-2469E155; Fri, 03 Apr 2015 13:31:46 +0000 X-Env-Sender: julien.grall@citrix.com X-Msg-Ref: server-9.tower-206.messagelabs.com!1428067904!13676638!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.6; banners=-,-,- X-VirusChecked: Checked Received: (qmail 17716 invoked from network); 3 Apr 2015 13:31:45 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-9.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 3 Apr 2015 13:31:45 -0000 X-IronPort-AV: E=Sophos;i="5.11,517,1422921600"; d="scan'208";a="249642738" Message-ID: <551E963C.8000606@citrix.com> Date: Fri, 3 Apr 2015 15:31:40 +0200 From: Julien Grall User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Iurii Konovalenko , Julien Grall References: <551D61A2.6020201@citrix.com> In-Reply-To: X-DLP: MIA2 X-Mailman-Approved-At: Fri, 03 Apr 2015 15:14:33 +0000 Cc: Embedded-pv-devel@lists.xenproject.org, Julien Grall , "xen-devel@lists.xen.org" , Ian Campbell , Stefano Stabellini Subject: Re: [Embedded-pv-devel] [Xen-devel] Size of irq field X-BeenThere: embedded-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: embedded-pv-devel-bounces@lists.xenproject.org Errors-To: embedded-pv-devel-bounces@lists.xenproject.org On 03/04/2015 14:40, Iurii Konovalenko wrote: > Hi, Ian! Hi, Julien! Hi Iurii, > Thank you for your replies. > > On Thu, Apr 2, 2015 at 6:19 PM, Ian Campbell > wrote: > > Please can you give some example of this? > On Thu, Apr 2, 2015 at 6:34 PM, Julien Grall > wrote: > > Can you give an example of files/structures using uint8_t for IRQ? > > As Julien wrote, it is related to irq_permission. I am not sure if it is > supported on ARM, but we use it, and this function fails during domain > creation, because IRQ number is truncated and permission operation is > applied for incorrect IRQ, so domain creation fails. So, do we need to > change logic and do not check IRQ permissions? Where do you need to check the IRQ permission? Currently (with my DT device passthrough series) only DOM0 is able to manage the IRQ (i.e bind/unbind) and we don't let the guest to do it. So I don't think it's necessary to to call xc_domain_irq_permission for guest. The DOMCTL is buggy because it relies on vIRQ == IRQ as many place in Xen. Although it would work now because, we chose to map 1:1 the IRQ in the guest. > Also, as we plan to use passtrough, we there are such places: > In tools/libxc/include/xenctrl.h: > int xc_domain_bind_pt_irq(xc_interface *xch, > uint32_t domid, > *uint8_t* machine_irq, > uint8_t irq_type, > uint8_t bus, > uint8_t device, > uint8_t intx, > uint8_t isa_irq); > > int xc_domain_unbind_pt_irq(xc_interface *xch, > uint32_t domid, > *uint8_t* machine_irq, > uint8_t irq_type, > uint8_t bus, > uint8_t device, > uint8_t intx, > uint8_t isa_irq); > > int xc_domain_bind_pt_pci_irq(xc_interface *xch, > uint32_t domid, > *uint8_t* machine_irq, > uint8_t bus, > uint8_t device, > uint8_t intx); > > int xc_domain_bind_pt_isa_irq(xc_interface *xch, > uint32_t domid, > *uint8_t* machine_irq); > > And theirs implementation in tools/libxc/xc_domain.c Whoops. I didn't spot those one thanks. > > On Thu, Apr 2, 2015 at 6:19 PM, Ian Campbell > wrote: > > We should certainly fix anywhere which is not using a large enough data > > type. > On Thu, Apr 2, 2015 at 6:34 PM, Julien Grall > wrote: > > Ideally the IRQ should use uint32_t. This is allow us to support LPIs > (IRQ > > number start a 8192 up to a very high number). > > I have patch that increase size to uint32_t for cases, I described > previously. Can I push it for review? Yes please. Regards, -- Julien Grall _______________________________________________ Embedded-pv-devel mailing list Embedded-pv-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/embedded-pv-devel From embedded-pv-devel-bounces@lists.xenproject.org Fri Apr 03 15:14:34 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 03 Apr 2015 15:14:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Ye3In-0003dC-LK; Fri, 03 Apr 2015 15:14:33 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Ydh9l-0001mb-6u for Embedded-pv-devel@lists.xenproject.org; Thu, 02 Apr 2015 15:35:45 +0000 Received: from [193.109.254.147] by server-10.bemta-14.messagelabs.com id 3E/1A-06062-0D16D155; Thu, 02 Apr 2015 15:35:44 +0000 X-Env-Sender: julien.grall@citrix.com X-Msg-Ref: server-7.tower-27.messagelabs.com!1427988941!15253766!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.6; banners=-,-,- X-VirusChecked: Checked Received: (qmail 26765 invoked from network); 2 Apr 2015 15:35:43 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-7.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 2 Apr 2015 15:35:43 -0000 X-IronPort-AV: E=Sophos;i="5.11,511,1422921600"; d="scan'208";a="249191470" Message-ID: <551D61A2.6020201@citrix.com> Date: Thu, 2 Apr 2015 16:34:58 +0100 From: Julien Grall User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Iurii Konovalenko , Julien Grall References: In-Reply-To: X-DLP: MIA2 X-Mailman-Approved-At: Fri, 03 Apr 2015 15:14:33 +0000 Cc: Embedded-pv-devel@lists.xenproject.org, Stefano Stabellini , Ian Campbell , "xen-devel@lists.xen.org" Subject: Re: [Embedded-pv-devel] [Xen-devel] Size of irq field X-BeenThere: embedded-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: embedded-pv-devel-bounces@lists.xenproject.org Errors-To: embedded-pv-devel-bounces@lists.xenproject.org (CC Stefano and Ian) On 02/04/2015 16:05, Iurii Konovalenko wrote: > Hi, Julien! Hello Iurii, > > During bringing up Xen on Renesas Lager board we faced with problem. > A lot of Xen sources relies on statement, that IRQ number is less then > 256 and variables, parameters, fields etc. are of type uint8_t. But we > can have IRQs, that are greater then 255, for example on RCar H2 SoC. > Also, as I saw from one of your latest commits, GICv supports 1020 > physical interrupts. As a result, overflow can occur. So it seems > logical to increase all irq staff to uint16_t or uint32_t. We have > local patches for increasing some structures, functions etc. > But before pushing these patches I want to know your opinion, what do > you think about this problem? What type should we use uint16_t or > uint32_t? How to find all places where uint8_t type is used for IRQ? I'm a bit surprised. I looked through the hypervisor and libxl and I was able to found only one place (DOMCTL_irq_permission which is not really supported on ARM). We are usually using uint32_t/int for IRQ. Can you give an example of files/structures using uint8_t for IRQ? Ideally the IRQ should use uint32_t. This is allow us to support LPIs (IRQ number start a 8192 up to a very high number). > Best regards. Regards, -- Julien Grall _______________________________________________ Embedded-pv-devel mailing list Embedded-pv-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/embedded-pv-devel From embedded-pv-devel-bounces@lists.xenproject.org Tue Apr 14 10:20:22 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 14 Apr 2015 10:20:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Yhxx8-0008F6-IN; Tue, 14 Apr 2015 10:20:22 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Yhxx6-0008EB-Pi; Tue, 14 Apr 2015 10:20:20 +0000 Received: from [85.158.137.68] by server-17.bemta-3.messagelabs.com id D9/64-14975-3E9EC255; Tue, 14 Apr 2015 10:20:19 +0000 X-Env-Sender: lars.kurth.xen@gmail.com X-Msg-Ref: server-12.tower-31.messagelabs.com!1429006818!16207764!1 X-Originating-IP: [74.125.82.41] X-SpamReason: No, hits=0.0 required=7.0 tests=HTML_MESSAGE X-StarScan-Received: X-StarScan-Version: 6.13.6; banners=-,-,- X-VirusChecked: Checked Received: (qmail 30466 invoked from network); 14 Apr 2015 10:20:18 -0000 Received: from mail-wg0-f41.google.com (HELO mail-wg0-f41.google.com) (74.125.82.41) by server-12.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 14 Apr 2015 10:20:18 -0000 Received: by wgin8 with SMTP id n8so6435457wgi.0; Tue, 14 Apr 2015 03:20:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:content-type:subject:date:message-id:cc:to:mime-version; bh=vSblshgxs5ALvnkkVGrsAJBiAl5RZJHDwfATCml3QbI=; b=ma+RHzrGCgC5fSYMKgs64ZGgxRViE5B7XPd4JFONXmUfJ4q0mBpfMppjBGGe0Prh9j C9IJlSvZabgH65QzbVS30Z4I+YltFpUqV8PRpka18kNK5Eu0er+xOxCf62y3iIVmq2Vk Z5NXGzMkcuZwpkEAaGUtk7YbObExZFmXF8/xEkeoJ13jzw1U6jToz+nARmsU+UR04jxi tEbeXjzHDL40rCaoq6kgp42s04sKUI+Bm9DbXfOUt5xO9YlUM2ZNPXQPKQJYqnJvwIOv KgbLtkdWgaOGoAZfawQSwXQZ8obAIe0LcjxSOE45DHNMAidi6uBpZoHJbnPZXcAtfZMm x97Q== X-Received: by 10.195.12.138 with SMTP id eq10mr36359569wjd.65.1429006818461; Tue, 14 Apr 2015 03:20:18 -0700 (PDT) Received: from [192.168.0.12] (97e5522d.skybroadband.com. [151.229.82.45]) by mx.google.com with ESMTPSA id gu7sm14944489wib.21.2015.04.14.03.20.16 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 14 Apr 2015 03:20:17 -0700 (PDT) From: Lars Kurth Date: Tue, 14 Apr 2015 11:20:16 +0100 Message-Id: To: "" , xen-api@lists.xenproject.org, mirageos-devel@xenproject.org, embedded-pv-devel@lists.xenproject.org, Win-pv-devel@lists.xenproject.org Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) X-Mailer: Apple Mail (2.2070.6) Cc: xen-users@lists.xenproject.org Subject: [Embedded-pv-devel] Reminder: CfP for Xen Project Development Summit is closing on May 1st X-BeenThere: embedded-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6164175582546569440==" Sender: embedded-pv-devel-bounces@lists.xenproject.org Errors-To: embedded-pv-devel-bounces@lists.xenproject.org --===============6164175582546569440== Content-Type: multipart/alternative; boundary="Apple-Mail=_6B14DE52-3863-4A22-80AB-5CD642AF2320" --Apple-Mail=_6B14DE52-3863-4A22-80AB-5CD642AF2320 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii The CfP is at = http://events.linuxfoundation.org/events/xen-project-developer-summit/prog= ram/cfp = Regards Lars= --Apple-Mail=_6B14DE52-3863-4A22-80AB-5CD642AF2320 Content-Transfer-Encoding: 7bit Content-Type: text/html; charset=us-ascii The CfP is at http://events.linuxfoundation.org/events/xen-project-developer-summit/program/cfp
Regards
Lars
--Apple-Mail=_6B14DE52-3863-4A22-80AB-5CD642AF2320-- --===============6164175582546569440== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Embedded-pv-devel mailing list Embedded-pv-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/embedded-pv-devel --===============6164175582546569440==-- From embedded-pv-devel-bounces@lists.xenproject.org Tue Apr 14 10:20:22 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 14 Apr 2015 10:20:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Yhxx8-0008F6-IN; Tue, 14 Apr 2015 10:20:22 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Yhxx6-0008EB-Pi; Tue, 14 Apr 2015 10:20:20 +0000 Received: from [85.158.137.68] by server-17.bemta-3.messagelabs.com id D9/64-14975-3E9EC255; Tue, 14 Apr 2015 10:20:19 +0000 X-Env-Sender: lars.kurth.xen@gmail.com X-Msg-Ref: server-12.tower-31.messagelabs.com!1429006818!16207764!1 X-Originating-IP: [74.125.82.41] X-SpamReason: No, hits=0.0 required=7.0 tests=HTML_MESSAGE X-StarScan-Received: X-StarScan-Version: 6.13.6; banners=-,-,- X-VirusChecked: Checked Received: (qmail 30466 invoked from network); 14 Apr 2015 10:20:18 -0000 Received: from mail-wg0-f41.google.com (HELO mail-wg0-f41.google.com) (74.125.82.41) by server-12.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 14 Apr 2015 10:20:18 -0000 Received: by wgin8 with SMTP id n8so6435457wgi.0; Tue, 14 Apr 2015 03:20:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:content-type:subject:date:message-id:cc:to:mime-version; bh=vSblshgxs5ALvnkkVGrsAJBiAl5RZJHDwfATCml3QbI=; b=ma+RHzrGCgC5fSYMKgs64ZGgxRViE5B7XPd4JFONXmUfJ4q0mBpfMppjBGGe0Prh9j C9IJlSvZabgH65QzbVS30Z4I+YltFpUqV8PRpka18kNK5Eu0er+xOxCf62y3iIVmq2Vk Z5NXGzMkcuZwpkEAaGUtk7YbObExZFmXF8/xEkeoJ13jzw1U6jToz+nARmsU+UR04jxi tEbeXjzHDL40rCaoq6kgp42s04sKUI+Bm9DbXfOUt5xO9YlUM2ZNPXQPKQJYqnJvwIOv KgbLtkdWgaOGoAZfawQSwXQZ8obAIe0LcjxSOE45DHNMAidi6uBpZoHJbnPZXcAtfZMm x97Q== X-Received: by 10.195.12.138 with SMTP id eq10mr36359569wjd.65.1429006818461; Tue, 14 Apr 2015 03:20:18 -0700 (PDT) Received: from [192.168.0.12] (97e5522d.skybroadband.com. [151.229.82.45]) by mx.google.com with ESMTPSA id gu7sm14944489wib.21.2015.04.14.03.20.16 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 14 Apr 2015 03:20:17 -0700 (PDT) From: Lars Kurth Date: Tue, 14 Apr 2015 11:20:16 +0100 Message-Id: To: "" , xen-api@lists.xenproject.org, mirageos-devel@xenproject.org, embedded-pv-devel@lists.xenproject.org, Win-pv-devel@lists.xenproject.org Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) X-Mailer: Apple Mail (2.2070.6) Cc: xen-users@lists.xenproject.org Subject: [Embedded-pv-devel] Reminder: CfP for Xen Project Development Summit is closing on May 1st X-BeenThere: embedded-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6164175582546569440==" Sender: embedded-pv-devel-bounces@lists.xenproject.org Errors-To: embedded-pv-devel-bounces@lists.xenproject.org --===============6164175582546569440== Content-Type: multipart/alternative; boundary="Apple-Mail=_6B14DE52-3863-4A22-80AB-5CD642AF2320" --Apple-Mail=_6B14DE52-3863-4A22-80AB-5CD642AF2320 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii The CfP is at = http://events.linuxfoundation.org/events/xen-project-developer-summit/prog= ram/cfp = Regards Lars= --Apple-Mail=_6B14DE52-3863-4A22-80AB-5CD642AF2320 Content-Transfer-Encoding: 7bit Content-Type: text/html; charset=us-ascii The CfP is at http://events.linuxfoundation.org/events/xen-project-developer-summit/program/cfp
Regards
Lars
--Apple-Mail=_6B14DE52-3863-4A22-80AB-5CD642AF2320-- --===============6164175582546569440== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Embedded-pv-devel mailing list Embedded-pv-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/embedded-pv-devel --===============6164175582546569440==-- From embedded-pv-devel-bounces@lists.xenproject.org Tue Apr 14 10:33:45 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 14 Apr 2015 10:33:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YhyA5-0001SE-Pm; Tue, 14 Apr 2015 10:33:45 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YhyA4-0001Rl-3X for Embedded-pv-devel@lists.xenproject.org; Tue, 14 Apr 2015 10:33:44 +0000 Received: from [85.158.137.68] by server-15.bemta-3.messagelabs.com id CF/39-32487-70DEC255; Tue, 14 Apr 2015 10:33:43 +0000 X-Env-Sender: Ian.Campbell@citrix.com X-Msg-Ref: server-2.tower-31.messagelabs.com!1429007620!16301955!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.6; banners=-,-,- X-VirusChecked: Checked Received: (qmail 30958 invoked from network); 14 Apr 2015 10:33:42 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-2.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 14 Apr 2015 10:33:42 -0000 X-IronPort-AV: E=Sophos;i="5.11,575,1422921600"; d="scan'208";a="254817207" Message-ID: <1429007619.15516.22.camel@citrix.com> From: Ian Campbell To: Julien Grall Date: Tue, 14 Apr 2015 11:33:39 +0100 In-Reply-To: <551E963C.8000606@citrix.com> References: <551D61A2.6020201@citrix.com> <551E963C.8000606@citrix.com> X-Mailer: Evolution 3.12.9-1+b1 MIME-Version: 1.0 X-DLP: MIA2 Cc: Embedded-pv-devel@lists.xenproject.org, Iurii Konovalenko , Julien Grall , "xen-devel@lists.xen.org" , Stefano Stabellini Subject: Re: [Embedded-pv-devel] [Xen-devel] Size of irq field X-BeenThere: embedded-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: embedded-pv-devel-bounces@lists.xenproject.org Errors-To: embedded-pv-devel-bounces@lists.xenproject.org On Fri, 2015-04-03 at 15:31 +0200, Julien Grall wrote: > > Also, as we plan to use passtrough, we there are such places: > > > In tools/libxc/include/xenctrl.h: > > int xc_domain_bind_pt_irq(xc_interface *xch, > > uint32_t domid, > > *uint8_t* machine_irq, > > uint8_t irq_type, > > uint8_t bus, > > uint8_t device, > > uint8_t intx, > > uint8_t isa_irq); > > > > int xc_domain_unbind_pt_irq(xc_interface *xch, > > uint32_t domid, > > *uint8_t* machine_irq, > > uint8_t irq_type, > > uint8_t bus, > > uint8_t device, > > uint8_t intx, > > uint8_t isa_irq); > > > > int xc_domain_bind_pt_pci_irq(xc_interface *xch, > > uint32_t domid, > > *uint8_t* machine_irq, > > uint8_t bus, > > uint8_t device, > > uint8_t intx); > > > > int xc_domain_bind_pt_isa_irq(xc_interface *xch, > > uint32_t domid, > > *uint8_t* machine_irq); > > > > And theirs implementation in tools/libxc/xc_domain.c > > Whoops. I didn't spot those one thanks. libxc is not ABI stable, we can make these bigger if necessary, or introduce new interface etc as required depending on how things pan out at the hypercall layer. Ian. _______________________________________________ Embedded-pv-devel mailing list Embedded-pv-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/embedded-pv-devel From embedded-pv-devel-bounces@lists.xenproject.org Tue Apr 14 10:33:45 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 14 Apr 2015 10:33:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YhyA5-0001SE-Pm; Tue, 14 Apr 2015 10:33:45 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YhyA4-0001Rl-3X for Embedded-pv-devel@lists.xenproject.org; Tue, 14 Apr 2015 10:33:44 +0000 Received: from [85.158.137.68] by server-15.bemta-3.messagelabs.com id CF/39-32487-70DEC255; Tue, 14 Apr 2015 10:33:43 +0000 X-Env-Sender: Ian.Campbell@citrix.com X-Msg-Ref: server-2.tower-31.messagelabs.com!1429007620!16301955!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.6; banners=-,-,- X-VirusChecked: Checked Received: (qmail 30958 invoked from network); 14 Apr 2015 10:33:42 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-2.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 14 Apr 2015 10:33:42 -0000 X-IronPort-AV: E=Sophos;i="5.11,575,1422921600"; d="scan'208";a="254817207" Message-ID: <1429007619.15516.22.camel@citrix.com> From: Ian Campbell To: Julien Grall Date: Tue, 14 Apr 2015 11:33:39 +0100 In-Reply-To: <551E963C.8000606@citrix.com> References: <551D61A2.6020201@citrix.com> <551E963C.8000606@citrix.com> X-Mailer: Evolution 3.12.9-1+b1 MIME-Version: 1.0 X-DLP: MIA2 Cc: Embedded-pv-devel@lists.xenproject.org, Iurii Konovalenko , Julien Grall , "xen-devel@lists.xen.org" , Stefano Stabellini Subject: Re: [Embedded-pv-devel] [Xen-devel] Size of irq field X-BeenThere: embedded-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: embedded-pv-devel-bounces@lists.xenproject.org Errors-To: embedded-pv-devel-bounces@lists.xenproject.org On Fri, 2015-04-03 at 15:31 +0200, Julien Grall wrote: > > Also, as we plan to use passtrough, we there are such places: > > > In tools/libxc/include/xenctrl.h: > > int xc_domain_bind_pt_irq(xc_interface *xch, > > uint32_t domid, > > *uint8_t* machine_irq, > > uint8_t irq_type, > > uint8_t bus, > > uint8_t device, > > uint8_t intx, > > uint8_t isa_irq); > > > > int xc_domain_unbind_pt_irq(xc_interface *xch, > > uint32_t domid, > > *uint8_t* machine_irq, > > uint8_t irq_type, > > uint8_t bus, > > uint8_t device, > > uint8_t intx, > > uint8_t isa_irq); > > > > int xc_domain_bind_pt_pci_irq(xc_interface *xch, > > uint32_t domid, > > *uint8_t* machine_irq, > > uint8_t bus, > > uint8_t device, > > uint8_t intx); > > > > int xc_domain_bind_pt_isa_irq(xc_interface *xch, > > uint32_t domid, > > *uint8_t* machine_irq); > > > > And theirs implementation in tools/libxc/xc_domain.c > > Whoops. I didn't spot those one thanks. libxc is not ABI stable, we can make these bigger if necessary, or introduce new interface etc as required depending on how things pan out at the hypercall layer. Ian. _______________________________________________ Embedded-pv-devel mailing list Embedded-pv-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/embedded-pv-devel From embedded-pv-devel-bounces@lists.xenproject.org Tue Apr 14 11:06:11 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 14 Apr 2015 11:06:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YhyfT-00066y-Fu; Tue, 14 Apr 2015 11:06:11 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YhyBs-0001iG-1K for Embedded-pv-devel@lists.xenproject.org; Tue, 14 Apr 2015 10:35:36 +0000 Received: from [85.158.139.211] by server-13.bemta-5.messagelabs.com id 6A/36-08090-77DEC255; Tue, 14 Apr 2015 10:35:35 +0000 X-Env-Sender: julien.grall@citrix.com X-Msg-Ref: server-16.tower-206.messagelabs.com!1429007733!12863701!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.6; banners=-,-,- X-VirusChecked: Checked Received: (qmail 24395 invoked from network); 14 Apr 2015 10:35:34 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-16.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 14 Apr 2015 10:35:34 -0000 X-IronPort-AV: E=Sophos;i="5.11,575,1422921600"; d="scan'208";a="252916074" Message-ID: <552CED4F.7000006@citrix.com> Date: Tue, 14 Apr 2015 11:34:55 +0100 From: Julien Grall User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: Ian Campbell References: <551D61A2.6020201@citrix.com> <551E963C.8000606@citrix.com> <1429007619.15516.22.camel@citrix.com> In-Reply-To: <1429007619.15516.22.camel@citrix.com> X-DLP: MIA1 X-Mailman-Approved-At: Tue, 14 Apr 2015 11:06:10 +0000 Cc: Embedded-pv-devel@lists.xenproject.org, Iurii Konovalenko , Julien Grall , "xen-devel@lists.xen.org" , Stefano Stabellini Subject: Re: [Embedded-pv-devel] [Xen-devel] Size of irq field X-BeenThere: embedded-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: embedded-pv-devel-bounces@lists.xenproject.org Errors-To: embedded-pv-devel-bounces@lists.xenproject.org On 14/04/15 11:33, Ian Campbell wrote: >> Whoops. I didn't spot those one thanks. > > libxc is not ABI stable, we can make these bigger if necessary, or > introduce new interface etc as required depending on how things pan out > at the hypercall layer. FIY, a patch has been sent on the ML see "[PATCH v3] increase size of irq from uint8_t to uint32_t" in order to fix it. Regards, -- Julien Grall _______________________________________________ Embedded-pv-devel mailing list Embedded-pv-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/embedded-pv-devel From embedded-pv-devel-bounces@lists.xenproject.org Tue Apr 14 11:06:11 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 14 Apr 2015 11:06:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YhyfT-00066y-Fu; Tue, 14 Apr 2015 11:06:11 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YhyBs-0001iG-1K for Embedded-pv-devel@lists.xenproject.org; Tue, 14 Apr 2015 10:35:36 +0000 Received: from [85.158.139.211] by server-13.bemta-5.messagelabs.com id 6A/36-08090-77DEC255; Tue, 14 Apr 2015 10:35:35 +0000 X-Env-Sender: julien.grall@citrix.com X-Msg-Ref: server-16.tower-206.messagelabs.com!1429007733!12863701!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.6; banners=-,-,- X-VirusChecked: Checked Received: (qmail 24395 invoked from network); 14 Apr 2015 10:35:34 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-16.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 14 Apr 2015 10:35:34 -0000 X-IronPort-AV: E=Sophos;i="5.11,575,1422921600"; d="scan'208";a="252916074" Message-ID: <552CED4F.7000006@citrix.com> Date: Tue, 14 Apr 2015 11:34:55 +0100 From: Julien Grall User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: Ian Campbell References: <551D61A2.6020201@citrix.com> <551E963C.8000606@citrix.com> <1429007619.15516.22.camel@citrix.com> In-Reply-To: <1429007619.15516.22.camel@citrix.com> X-DLP: MIA1 X-Mailman-Approved-At: Tue, 14 Apr 2015 11:06:10 +0000 Cc: Embedded-pv-devel@lists.xenproject.org, Iurii Konovalenko , Julien Grall , "xen-devel@lists.xen.org" , Stefano Stabellini Subject: Re: [Embedded-pv-devel] [Xen-devel] Size of irq field X-BeenThere: embedded-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: embedded-pv-devel-bounces@lists.xenproject.org Errors-To: embedded-pv-devel-bounces@lists.xenproject.org On 14/04/15 11:33, Ian Campbell wrote: >> Whoops. I didn't spot those one thanks. > > libxc is not ABI stable, we can make these bigger if necessary, or > introduce new interface etc as required depending on how things pan out > at the hypercall layer. FIY, a patch has been sent on the ML see "[PATCH v3] increase size of irq from uint8_t to uint32_t" in order to fix it. Regards, -- Julien Grall _______________________________________________ Embedded-pv-devel mailing list Embedded-pv-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/embedded-pv-devel