From minios-devel-bounces@lists.xenproject.org Wed Jul 01 09:24:57 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 01 Jul 2015 09:24:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAEGG-0003Gm-G0; Wed, 01 Jul 2015 09:24:56 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAEGE-0003Ge-GL for Minios-devel@lists.xenproject.org; Wed, 01 Jul 2015 09:24:54 +0000 Received: from [85.158.137.68] by server-6.bemta-3.messagelabs.com id 0A/B7-13517-5E1B3955; Wed, 01 Jul 2015 09:24:53 +0000 X-Env-Sender: talex5@gmail.com X-Msg-Ref: server-8.tower-31.messagelabs.com!1435742693!21520092!1 X-Originating-IP: [209.85.212.173] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 27752 invoked from network); 1 Jul 2015 09:24:53 -0000 Received: from mail-wi0-f173.google.com (HELO mail-wi0-f173.google.com) (209.85.212.173) by server-8.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 1 Jul 2015 09:24:53 -0000 Received: by wiwl6 with SMTP id l6so158536905wiw.0 for ; Wed, 01 Jul 2015 02:24:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=BykjyTQ2Fb/zgtWWaKHtb0qynytFVkBG0P9ShgZ0ZwQ=; b=e+XjBR2ikHia2ovPfgDbZwBhqC2gYGsAoUne30ocHQ+RMrpc0aRmp6BNqlv+cXO6JI J3h6AJylwC8SGuaanWkGS/DWNhP5FVoyaM0axcXDdE2EOYT1nbGkd+HOsban4QZn5jNf OeqEvbb96vNDxlXDipGfIx84lYBEKqft13Ee6OdQxT3topj+6i7Qo2Zluu9roJa+7ckN x74dfwRNZIgUlbQpl0v+MpAobahcW+4BayACpZWMq0Zg2ajQPYYYHmKXwA+f4ZHrlOoy C2TZ7KTlhUqd29xgHkXJGHJzzRTtZy2+h6BsRYncQOywoyvk2txGONO7UT14it3spEl+ vf0w== X-Received: by 10.181.12.111 with SMTP id ep15mr4435022wid.15.1435742693071; Wed, 01 Jul 2015 02:24:53 -0700 (PDT) Received: from cam.localdomain (82-69-101-169.dsl.in-addr.zen.co.uk. [82.69.101.169]) by mx.google.com with ESMTPSA id r6sm21074129wiy.13.2015.07.01.02.24.51 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 01 Jul 2015 02:24:52 -0700 (PDT) From: Thomas Leonard To: Minios-devel@lists.xenproject.org Date: Wed, 1 Jul 2015 10:24:50 +0100 Message-Id: <1435742690-4755-1-git-send-email-talex5@gmail.com> X-Mailer: git-send-email 2.4.2 Cc: samuel.thibault@ens-lyon.org, Thomas Leonard , Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com Subject: [Minios-devel] [PATCH] Accept %z in printf formats X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Before, we only supported %Z (upper-case). It seems that the lower-case version is standard, and this matches the behaviour of Xen's vsprintf.c. Signed-off-by: Thomas Leonard --- lib/printf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/printf.c b/lib/printf.c index 3d02e95..40f92fc 100644 --- a/lib/printf.c +++ b/lib/printf.c @@ -346,12 +346,14 @@ int vsnprintf(char *buf, size_t size, const char *fmt, va_list args) /* get the conversion qualifier */ qualifier = -1; - if (*fmt == 'h' || *fmt == 'l' || *fmt == 'L' || *fmt =='Z') { + if (*fmt == 'h' || *fmt == 'l' || *fmt == 'L' || *fmt =='Z' || *fmt == 'z') { qualifier = *fmt; ++fmt; if (qualifier == 'l' && *fmt == 'l') { qualifier = 'L'; ++fmt; + } else if (qualifier == 'z') { + qualifier = 'Z'; } } if (*fmt == 'q') { -- 2.4.2 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Jul 01 09:24:57 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 01 Jul 2015 09:24:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAEGG-0003Gm-G0; Wed, 01 Jul 2015 09:24:56 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAEGE-0003Ge-GL for Minios-devel@lists.xenproject.org; Wed, 01 Jul 2015 09:24:54 +0000 Received: from [85.158.137.68] by server-6.bemta-3.messagelabs.com id 0A/B7-13517-5E1B3955; Wed, 01 Jul 2015 09:24:53 +0000 X-Env-Sender: talex5@gmail.com X-Msg-Ref: server-8.tower-31.messagelabs.com!1435742693!21520092!1 X-Originating-IP: [209.85.212.173] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 27752 invoked from network); 1 Jul 2015 09:24:53 -0000 Received: from mail-wi0-f173.google.com (HELO mail-wi0-f173.google.com) (209.85.212.173) by server-8.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 1 Jul 2015 09:24:53 -0000 Received: by wiwl6 with SMTP id l6so158536905wiw.0 for ; Wed, 01 Jul 2015 02:24:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=BykjyTQ2Fb/zgtWWaKHtb0qynytFVkBG0P9ShgZ0ZwQ=; b=e+XjBR2ikHia2ovPfgDbZwBhqC2gYGsAoUne30ocHQ+RMrpc0aRmp6BNqlv+cXO6JI J3h6AJylwC8SGuaanWkGS/DWNhP5FVoyaM0axcXDdE2EOYT1nbGkd+HOsban4QZn5jNf OeqEvbb96vNDxlXDipGfIx84lYBEKqft13Ee6OdQxT3topj+6i7Qo2Zluu9roJa+7ckN x74dfwRNZIgUlbQpl0v+MpAobahcW+4BayACpZWMq0Zg2ajQPYYYHmKXwA+f4ZHrlOoy C2TZ7KTlhUqd29xgHkXJGHJzzRTtZy2+h6BsRYncQOywoyvk2txGONO7UT14it3spEl+ vf0w== X-Received: by 10.181.12.111 with SMTP id ep15mr4435022wid.15.1435742693071; Wed, 01 Jul 2015 02:24:53 -0700 (PDT) Received: from cam.localdomain (82-69-101-169.dsl.in-addr.zen.co.uk. [82.69.101.169]) by mx.google.com with ESMTPSA id r6sm21074129wiy.13.2015.07.01.02.24.51 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 01 Jul 2015 02:24:52 -0700 (PDT) From: Thomas Leonard To: Minios-devel@lists.xenproject.org Date: Wed, 1 Jul 2015 10:24:50 +0100 Message-Id: <1435742690-4755-1-git-send-email-talex5@gmail.com> X-Mailer: git-send-email 2.4.2 Cc: samuel.thibault@ens-lyon.org, Thomas Leonard , Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com Subject: [Minios-devel] [PATCH] Accept %z in printf formats X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Before, we only supported %Z (upper-case). It seems that the lower-case version is standard, and this matches the behaviour of Xen's vsprintf.c. Signed-off-by: Thomas Leonard --- lib/printf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/printf.c b/lib/printf.c index 3d02e95..40f92fc 100644 --- a/lib/printf.c +++ b/lib/printf.c @@ -346,12 +346,14 @@ int vsnprintf(char *buf, size_t size, const char *fmt, va_list args) /* get the conversion qualifier */ qualifier = -1; - if (*fmt == 'h' || *fmt == 'l' || *fmt == 'L' || *fmt =='Z') { + if (*fmt == 'h' || *fmt == 'l' || *fmt == 'L' || *fmt =='Z' || *fmt == 'z') { qualifier = *fmt; ++fmt; if (qualifier == 'l' && *fmt == 'l') { qualifier = 'L'; ++fmt; + } else if (qualifier == 'z') { + qualifier = 'Z'; } } if (*fmt == 'q') { -- 2.4.2 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Thu Jul 02 09:04:09 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 02 Jul 2015 09:04:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAaPg-0007xS-GO; Thu, 02 Jul 2015 09:04:08 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAaPf-0007xA-B9 for minios-devel@lists.xenproject.org; Thu, 02 Jul 2015 09:04:07 +0000 Received: from [85.158.139.211] by server-2.bemta-5.messagelabs.com id 3E/AB-31304-68EF4955; Thu, 02 Jul 2015 09:04:06 +0000 X-Env-Sender: prvs=6180f4332=Ian.Campbell@citrix.com X-Msg-Ref: server-6.tower-206.messagelabs.com!1435827844!18403182!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 22478 invoked from network); 2 Jul 2015 09:04:05 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-6.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 2 Jul 2015 09:04:05 -0000 X-IronPort-AV: E=Sophos;i="5.15,391,1432598400"; d="scan'208";a="277650974" Message-ID: <1435827841.21469.322.camel@citrix.com> From: Ian Campbell To: Samuel Thibault Date: Thu, 2 Jul 2015 10:04:01 +0100 In-Reply-To: <20150702002335.GZ3245@type.home> References: <1435316320-1811-1-git-send-email-ian.campbell@citrix.com> <1435316769-5784-1-git-send-email-ian.campbell@citrix.com> <20150702002335.GZ3245@type.home> X-Mailer: Evolution 3.12.9-1+b1 MIME-Version: 1.0 X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, Daniel De Graaf , xen-devel@lists.xen.org, Thomas Leonard , Stefano Stabellini Subject: Re: [Minios-devel] [Xen-devel] [PATCH xen] stubdom: vtpmmgr: Correctly format size_t with %z when printing. X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org T24gVGh1LCAyMDE1LTA3LTAyIGF0IDAyOjIzICswMjAwLCBTYW11ZWwgVGhpYmF1bHQgd3JvdGU6 Cj4gSWFuIENhbXBiZWxsLCBsZSBGcmkgMjYgSnVuIDIwMTUgMTI6MDY6MDkgKzAxMDAsIGEgw6lj cml0IDoKPiA+IEFsc28gY29udGFpbnMgYSBmaXggZnJvbSBUaG9tYXMgTGVvbmFyZCAodG8gdXNl ICV1IGZvciAiNCArIDMyIiwgbm90Cj4gPiAlbHUpIHByZXZpb3VzbHkgcG9zdGVkIGFzIHBhcnQg b2YgIm1pbmktb3M6IGVuYWJsZSBjb21waWxlciBjaGVjayBmb3IKPiA+IHByaW50ayBmb3JtYXQg dHlwZXMiIGJ1dCB3aXRoIG1pbmktb3Mgbm93IGhhdmluZyBiZWVuIHNwbGl0IGEgc2VwYXJhdGUK PiA+IHJlcG8gbW9zdCBvZiB0aGF0IGNoYW5nZSBoYXMgYmVlbiBhcHBsaWVkIHRoZXJlLgo+ID4g Cj4gPiBUaGlzIGZpeGVzIHRoZSAzMi1iaXQgYnVpbGQgd2l0aCB1cGRhdGVkIG1pbmktb3Mgd2hp Y2ggaW5jbHVkZXMgZm9ybWF0Cj4gPiBzdHJpbmcgY2hlY2tpbmcuCj4gPiAKPiA+IFNpZ25lZC1v ZmYtYnk6IFRob21hcyBMZW9uYXJkIDx0YWxleDVAZ21haWwuY29tPgo+ID4gU2lnbmVkLW9mZi1i eTogSWFuIENhbXBiZWxsIDxpYW4uY2FtcGJlbGxAY2l0cml4LmNvbT4KPiA+IENjOiBEYW5pZWwg RGUgR3JhYWYgPGRnZGVncmFAdHljaG8ubnNhLmdvdj4KPiA+IENjOiBTdGVmYW5vIFN0YWJlbGxp bmkgPHN0ZWZhbm8uc3RhYmVsbGluaUBldS5jaXRyaXguY29tPgo+IAo+IEFja2VkLUJ5OiBTYW11 ZWwgVGhpYmF1bHQgPHNhbXVlbC50aGliYXVsdEBlbnMtbHlvbi5vcmc+Cj4gCj4gKGFmdGVyIHRo ZSAneicgbW9kaWZpZXIgc3VwcG9ydCBpcyBjb21taXRlZCwgb2YgY291cnNlKQoKRXIsIHllcywg d2VsbCBzcG90dGVkIQoKPiA+IC0tLQo+ID4gSSBpbnRlbmQgdG8gZm9sZCBpbiBhbiB1cGRhdGUg dG8gTUlOSU9TX1VQU1RSRUFNX1JFVklTSU9OIHVwb24gY29tbWl0Cj4gPiB0byBwdWxsIGluIHRo ZSB1cGRhdGVkIG1pbmktb3MgcGx1cyB0aGUgIkNvcnJlY3QgcHJpbnRmIGZvcm1hdHRpbmcgZm9y Cj4gPiB0cG1fdGlzIG1lc3NhZ2UuIiBwYXRjaCBJJ3ZlIGp1c3QgcG9zdGVkLgo+ID4gLS0tCj4g PiAgc3R1YmRvbS92dHBtbWdyL2Rpc2tfcmVhZC5jIHwgICAxMiArKysrKystLS0tLS0KPiA+ICAx IGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQo+ID4gCj4gPiBk aWZmIC0tZ2l0IGEvc3R1YmRvbS92dHBtbWdyL2Rpc2tfcmVhZC5jIGIvc3R1YmRvbS92dHBtbWdy L2Rpc2tfcmVhZC5jCj4gPiBpbmRleCBlOWRjMjBmLi45NDRkM2ZmIDEwMDY0NAo+ID4gLS0tIGEv c3R1YmRvbS92dHBtbWdyL2Rpc2tfcmVhZC5jCj4gPiArKysgYi9zdHViZG9tL3Z0cG1tZ3IvZGlz a19yZWFkLmMKPiA+IEBAIC01NDgsMTggKzU0OCwxOCBAQCBpbnQgdnRwbV9sb2FkX2Rpc2sodm9p ZCkKPiA+ICAJVFBNX3JlYWRfcGNycygpOwo+ID4gIAo+ID4gIAlwcmludGsoIlRQTSBNYW5hZ2Vy IC0gZGlzayBmb3JtYXQgJWRcbiIsIFRQTV9NR1JfVkVSU0lPTik7Cj4gPiAtCXByaW50aygiIHJv b3Qgc2VhbDogJWx1OyBzZWN0b3Igb2YgJWQ6ICVsdVxuIiwKPiA+ICsJcHJpbnRrKCIgcm9vdCBz ZWFsOiAlenU7IHNlY3RvciBvZiAlZDogJXp1XG4iLAo+ID4gIAkJc2l6ZW9mKHN0cnVjdCBkaXNr X3Jvb3Rfc2VhbGVkX2RhdGEpLCBTRUFMU19QRVJfUk9PVF9TRUFMX0xJU1QsIHNpemVvZihzdHJ1 Y3QgZGlza19zZWFsX2xpc3QpKTsKPiA+IC0JcHJpbnRrKCIgcm9vdDogJWx1IHY9JWx1XG4iLCBz aXplb2Yocm9vdDEpLCBzaXplb2Yocm9vdDEudikpOwo+ID4gLQlwcmludGsoIiBpdHJlZTogJWx1 OyBzZWN0b3Igb2YgJWQ6ICVsdVxuIiwKPiA+ICsJcHJpbnRrKCIgcm9vdDogJXp1IHY9JXp1XG4i LCBzaXplb2Yocm9vdDEpLCBzaXplb2Yocm9vdDEudikpOwo+ID4gKwlwcmludGsoIiBpdHJlZTog JXU7IHNlY3RvciBvZiAlZDogJXp1XG4iLAo+ID4gIAkJNCArIDMyLCBOUl9FTlRSSUVTX1BFUl9J VFJFRSwgc2l6ZW9mKHN0cnVjdCBkaXNrX2l0cmVlX3NlY3RvcikpOwo+ID4gLQlwcmludGsoIiBn cm91cDogJWx1IHY9JWx1IGlkPSVsdSBtZD0lbHVcbiIsCj4gPiArCXByaW50aygiIGdyb3VwOiAl enUgdj0lenUgaWQ9JXp1IG1kPSV6dVxuIiwKPiA+ICAJCXNpemVvZihzdHJ1Y3QgZGlza19ncm91 cF9zZWN0b3IpLCBzaXplb2Yoc3RydWN0IGRpc2tfZ3JvdXBfc2VjdG9yX21hYzNfYXJlYSksCj4g PiAgCQlzaXplb2Yoc3RydWN0IGdyb3VwX2lkX2RhdGEpLCBzaXplb2Yoc3RydWN0IGdyb3VwX2Rl dGFpbHMpKTsKPiA+IC0JcHJpbnRrKCIgZ3JvdXAgc2VhbDogJWx1OyAlZCBpbiBwYXJlbnQ6ICVs dTsgc2VjdG9yIG9mICVkOiAlbHVcbiIsCj4gPiArCXByaW50aygiIGdyb3VwIHNlYWw6ICV6dTsg JWQgaW4gcGFyZW50OiAlenU7IHNlY3RvciBvZiAlZDogJXp1XG4iLAo+ID4gIAkJc2l6ZW9mKHN0 cnVjdCBkaXNrX2dyb3VwX3NlYWxlZF9kYXRhKSwgTlJfU0VBTFNfUEVSX0dST1VQLCBzaXplb2Yo c3RydWN0IGRpc2tfZ3JvdXBfYm9vdF9jb25maWdfbGlzdCksCj4gPiAgCQlTRUFMU19QRVJfR1JP VVBfU0VBTF9MSVNULCBzaXplb2Yoc3RydWN0IGRpc2tfZ3JvdXBfc2VhbF9saXN0KSk7Cj4gPiAt CXByaW50aygiIHZ0cG06ICVsdSslbHU7IHNlY3RvciBvZiAlZDogJWx1XG4iLAo+ID4gKwlwcmlu dGsoIiB2dHBtOiAlenUrJXp1OyBzZWN0b3Igb2YgJWQ6ICV6dVxuIiwKPiA+ICAJCXNpemVvZihz dHJ1Y3QgZGlza192dHBtX3BsYWluKSwgc2l6ZW9mKHN0cnVjdCBkaXNrX3Z0cG1fc2VjcmV0KSwK PiA+ICAJCVZUUE1TX1BFUl9TRUNUT1IsIHNpemVvZihzdHJ1Y3QgZGlza192dHBtX3NlY3Rvcikp Owo+ID4gIAo+ID4gLS0gCj4gPiAxLjcuMTAuNAo+ID4gCj4gCgoKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCk1pbmlvcy1kZXZlbCBtYWlsaW5nIGxpc3QK TWluaW9zLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHA6Ly9saXN0cy54ZW5wcm9qZWN0 Lm9yZy9jZ2ktYmluL21haWxtYW4vbGlzdGluZm8vbWluaW9zLWRldmVs From minios-devel-bounces@lists.xenproject.org Thu Jul 02 09:04:09 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 02 Jul 2015 09:04:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAaPg-0007xS-GO; Thu, 02 Jul 2015 09:04:08 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAaPf-0007xA-B9 for minios-devel@lists.xenproject.org; Thu, 02 Jul 2015 09:04:07 +0000 Received: from [85.158.139.211] by server-2.bemta-5.messagelabs.com id 3E/AB-31304-68EF4955; Thu, 02 Jul 2015 09:04:06 +0000 X-Env-Sender: prvs=6180f4332=Ian.Campbell@citrix.com X-Msg-Ref: server-6.tower-206.messagelabs.com!1435827844!18403182!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 22478 invoked from network); 2 Jul 2015 09:04:05 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-6.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 2 Jul 2015 09:04:05 -0000 X-IronPort-AV: E=Sophos;i="5.15,391,1432598400"; d="scan'208";a="277650974" Message-ID: <1435827841.21469.322.camel@citrix.com> From: Ian Campbell To: Samuel Thibault Date: Thu, 2 Jul 2015 10:04:01 +0100 In-Reply-To: <20150702002335.GZ3245@type.home> References: <1435316320-1811-1-git-send-email-ian.campbell@citrix.com> <1435316769-5784-1-git-send-email-ian.campbell@citrix.com> <20150702002335.GZ3245@type.home> X-Mailer: Evolution 3.12.9-1+b1 MIME-Version: 1.0 X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, Daniel De Graaf , xen-devel@lists.xen.org, Thomas Leonard , Stefano Stabellini Subject: Re: [Minios-devel] [Xen-devel] [PATCH xen] stubdom: vtpmmgr: Correctly format size_t with %z when printing. X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org T24gVGh1LCAyMDE1LTA3LTAyIGF0IDAyOjIzICswMjAwLCBTYW11ZWwgVGhpYmF1bHQgd3JvdGU6 Cj4gSWFuIENhbXBiZWxsLCBsZSBGcmkgMjYgSnVuIDIwMTUgMTI6MDY6MDkgKzAxMDAsIGEgw6lj cml0IDoKPiA+IEFsc28gY29udGFpbnMgYSBmaXggZnJvbSBUaG9tYXMgTGVvbmFyZCAodG8gdXNl ICV1IGZvciAiNCArIDMyIiwgbm90Cj4gPiAlbHUpIHByZXZpb3VzbHkgcG9zdGVkIGFzIHBhcnQg b2YgIm1pbmktb3M6IGVuYWJsZSBjb21waWxlciBjaGVjayBmb3IKPiA+IHByaW50ayBmb3JtYXQg dHlwZXMiIGJ1dCB3aXRoIG1pbmktb3Mgbm93IGhhdmluZyBiZWVuIHNwbGl0IGEgc2VwYXJhdGUK PiA+IHJlcG8gbW9zdCBvZiB0aGF0IGNoYW5nZSBoYXMgYmVlbiBhcHBsaWVkIHRoZXJlLgo+ID4g Cj4gPiBUaGlzIGZpeGVzIHRoZSAzMi1iaXQgYnVpbGQgd2l0aCB1cGRhdGVkIG1pbmktb3Mgd2hp Y2ggaW5jbHVkZXMgZm9ybWF0Cj4gPiBzdHJpbmcgY2hlY2tpbmcuCj4gPiAKPiA+IFNpZ25lZC1v ZmYtYnk6IFRob21hcyBMZW9uYXJkIDx0YWxleDVAZ21haWwuY29tPgo+ID4gU2lnbmVkLW9mZi1i eTogSWFuIENhbXBiZWxsIDxpYW4uY2FtcGJlbGxAY2l0cml4LmNvbT4KPiA+IENjOiBEYW5pZWwg RGUgR3JhYWYgPGRnZGVncmFAdHljaG8ubnNhLmdvdj4KPiA+IENjOiBTdGVmYW5vIFN0YWJlbGxp bmkgPHN0ZWZhbm8uc3RhYmVsbGluaUBldS5jaXRyaXguY29tPgo+IAo+IEFja2VkLUJ5OiBTYW11 ZWwgVGhpYmF1bHQgPHNhbXVlbC50aGliYXVsdEBlbnMtbHlvbi5vcmc+Cj4gCj4gKGFmdGVyIHRo ZSAneicgbW9kaWZpZXIgc3VwcG9ydCBpcyBjb21taXRlZCwgb2YgY291cnNlKQoKRXIsIHllcywg d2VsbCBzcG90dGVkIQoKPiA+IC0tLQo+ID4gSSBpbnRlbmQgdG8gZm9sZCBpbiBhbiB1cGRhdGUg dG8gTUlOSU9TX1VQU1RSRUFNX1JFVklTSU9OIHVwb24gY29tbWl0Cj4gPiB0byBwdWxsIGluIHRo ZSB1cGRhdGVkIG1pbmktb3MgcGx1cyB0aGUgIkNvcnJlY3QgcHJpbnRmIGZvcm1hdHRpbmcgZm9y Cj4gPiB0cG1fdGlzIG1lc3NhZ2UuIiBwYXRjaCBJJ3ZlIGp1c3QgcG9zdGVkLgo+ID4gLS0tCj4g PiAgc3R1YmRvbS92dHBtbWdyL2Rpc2tfcmVhZC5jIHwgICAxMiArKysrKystLS0tLS0KPiA+ICAx IGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQo+ID4gCj4gPiBk aWZmIC0tZ2l0IGEvc3R1YmRvbS92dHBtbWdyL2Rpc2tfcmVhZC5jIGIvc3R1YmRvbS92dHBtbWdy L2Rpc2tfcmVhZC5jCj4gPiBpbmRleCBlOWRjMjBmLi45NDRkM2ZmIDEwMDY0NAo+ID4gLS0tIGEv c3R1YmRvbS92dHBtbWdyL2Rpc2tfcmVhZC5jCj4gPiArKysgYi9zdHViZG9tL3Z0cG1tZ3IvZGlz a19yZWFkLmMKPiA+IEBAIC01NDgsMTggKzU0OCwxOCBAQCBpbnQgdnRwbV9sb2FkX2Rpc2sodm9p ZCkKPiA+ICAJVFBNX3JlYWRfcGNycygpOwo+ID4gIAo+ID4gIAlwcmludGsoIlRQTSBNYW5hZ2Vy IC0gZGlzayBmb3JtYXQgJWRcbiIsIFRQTV9NR1JfVkVSU0lPTik7Cj4gPiAtCXByaW50aygiIHJv b3Qgc2VhbDogJWx1OyBzZWN0b3Igb2YgJWQ6ICVsdVxuIiwKPiA+ICsJcHJpbnRrKCIgcm9vdCBz ZWFsOiAlenU7IHNlY3RvciBvZiAlZDogJXp1XG4iLAo+ID4gIAkJc2l6ZW9mKHN0cnVjdCBkaXNr X3Jvb3Rfc2VhbGVkX2RhdGEpLCBTRUFMU19QRVJfUk9PVF9TRUFMX0xJU1QsIHNpemVvZihzdHJ1 Y3QgZGlza19zZWFsX2xpc3QpKTsKPiA+IC0JcHJpbnRrKCIgcm9vdDogJWx1IHY9JWx1XG4iLCBz aXplb2Yocm9vdDEpLCBzaXplb2Yocm9vdDEudikpOwo+ID4gLQlwcmludGsoIiBpdHJlZTogJWx1 OyBzZWN0b3Igb2YgJWQ6ICVsdVxuIiwKPiA+ICsJcHJpbnRrKCIgcm9vdDogJXp1IHY9JXp1XG4i LCBzaXplb2Yocm9vdDEpLCBzaXplb2Yocm9vdDEudikpOwo+ID4gKwlwcmludGsoIiBpdHJlZTog JXU7IHNlY3RvciBvZiAlZDogJXp1XG4iLAo+ID4gIAkJNCArIDMyLCBOUl9FTlRSSUVTX1BFUl9J VFJFRSwgc2l6ZW9mKHN0cnVjdCBkaXNrX2l0cmVlX3NlY3RvcikpOwo+ID4gLQlwcmludGsoIiBn cm91cDogJWx1IHY9JWx1IGlkPSVsdSBtZD0lbHVcbiIsCj4gPiArCXByaW50aygiIGdyb3VwOiAl enUgdj0lenUgaWQ9JXp1IG1kPSV6dVxuIiwKPiA+ICAJCXNpemVvZihzdHJ1Y3QgZGlza19ncm91 cF9zZWN0b3IpLCBzaXplb2Yoc3RydWN0IGRpc2tfZ3JvdXBfc2VjdG9yX21hYzNfYXJlYSksCj4g PiAgCQlzaXplb2Yoc3RydWN0IGdyb3VwX2lkX2RhdGEpLCBzaXplb2Yoc3RydWN0IGdyb3VwX2Rl dGFpbHMpKTsKPiA+IC0JcHJpbnRrKCIgZ3JvdXAgc2VhbDogJWx1OyAlZCBpbiBwYXJlbnQ6ICVs dTsgc2VjdG9yIG9mICVkOiAlbHVcbiIsCj4gPiArCXByaW50aygiIGdyb3VwIHNlYWw6ICV6dTsg JWQgaW4gcGFyZW50OiAlenU7IHNlY3RvciBvZiAlZDogJXp1XG4iLAo+ID4gIAkJc2l6ZW9mKHN0 cnVjdCBkaXNrX2dyb3VwX3NlYWxlZF9kYXRhKSwgTlJfU0VBTFNfUEVSX0dST1VQLCBzaXplb2Yo c3RydWN0IGRpc2tfZ3JvdXBfYm9vdF9jb25maWdfbGlzdCksCj4gPiAgCQlTRUFMU19QRVJfR1JP VVBfU0VBTF9MSVNULCBzaXplb2Yoc3RydWN0IGRpc2tfZ3JvdXBfc2VhbF9saXN0KSk7Cj4gPiAt CXByaW50aygiIHZ0cG06ICVsdSslbHU7IHNlY3RvciBvZiAlZDogJWx1XG4iLAo+ID4gKwlwcmlu dGsoIiB2dHBtOiAlenUrJXp1OyBzZWN0b3Igb2YgJWQ6ICV6dVxuIiwKPiA+ICAJCXNpemVvZihz dHJ1Y3QgZGlza192dHBtX3BsYWluKSwgc2l6ZW9mKHN0cnVjdCBkaXNrX3Z0cG1fc2VjcmV0KSwK PiA+ICAJCVZUUE1TX1BFUl9TRUNUT1IsIHNpemVvZihzdHJ1Y3QgZGlza192dHBtX3NlY3Rvcikp Owo+ID4gIAo+ID4gLS0gCj4gPiAxLjcuMTAuNAo+ID4gCj4gCgoKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCk1pbmlvcy1kZXZlbCBtYWlsaW5nIGxpc3QK TWluaW9zLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHA6Ly9saXN0cy54ZW5wcm9qZWN0 Lm9yZy9jZ2ktYmluL21haWxtYW4vbGlzdGluZm8vbWluaW9zLWRldmVs From minios-devel-bounces@lists.xenproject.org Thu Jul 02 13:46:54 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 02 Jul 2015 13:46:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAepI-0001oj-O1; Thu, 02 Jul 2015 13:46:52 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZASGA-0002Ca-Pn for minios-devel@lists.xenproject.org; Thu, 02 Jul 2015 00:21:46 +0000 Received: from [85.158.139.211] by server-1.bemta-5.messagelabs.com id C6/9B-31880-A1484955; Thu, 02 Jul 2015 00:21:46 +0000 X-Env-Sender: SRS0=65XX=HK=ens-lyon.org=samuel.thibault@bounce.ens-lyon.o rg X-Msg-Ref: server-15.tower-206.messagelabs.com!1435796504!14967745!1 X-Originating-IP: [140.77.166.138] X-SpamReason: No, hits=0.2 required=7.0 tests=RCVD_ILLEGAL_IP X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 16844 invoked from network); 2 Jul 2015 00:21:45 -0000 Received: from sonata.ens-lyon.org (HELO sonata.ens-lyon.org) (140.77.166.138) by server-15.tower-206.messagelabs.com with DHE-RSA-AES256-SHA encrypted SMTP; 2 Jul 2015 00:21:45 -0000 Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id DEE6E200C6; Thu, 2 Jul 2015 02:21:44 +0200 (CEST) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JCf58kRmsjir; Thu, 2 Jul 2015 02:21:44 +0200 (CEST) Received: from type.youpi.perso.aquilenet.fr (ABordeaux-652-1-107-213.w2-6.abo.wanadoo.fr [2.6.154.213]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 46CC9200C5; Thu, 2 Jul 2015 02:21:44 +0200 (CEST) Received: from samy by type.youpi.perso.aquilenet.fr with local (Exim 4.86_RC3) (envelope-from ) id 1ZASG7-0007A0-RS; Thu, 02 Jul 2015 02:21:43 +0200 Date: Thu, 2 Jul 2015 02:21:43 +0200 From: Samuel Thibault To: Ian Campbell Message-ID: <20150702002143.GY3245@type.home> Mail-Followup-To: Samuel Thibault , Ian Campbell , minios-devel@lists.xenproject.org, xen-devel@lists.xen.org, Daniel De Graaf , Thomas Leonard References: <1435316320-1811-1-git-send-email-ian.campbell@citrix.com> MIME-Version: 1.0 Content-Length: 1205 Content-Disposition: inline In-Reply-To: <1435316320-1811-1-git-send-email-ian.campbell@citrix.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) X-Mailman-Approved-At: Thu, 02 Jul 2015 13:46:51 +0000 Cc: minios-devel@lists.xenproject.org, Daniel De Graaf , Thomas Leonard , xen-devel@lists.xen.org Subject: Re: [Minios-devel] [PATCH mini-os] Correct printf formatting for tpm_tis message. X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Ian Campbell, le Fri 26 Jun 2015 11:58:40 +0100, a =E9crit : > This is under #ifdef HAVE_LIBC so went unnoticed before. > = > Signed-off-by: Ian Campbell Acked-by: Samuel Thibault > --- > tpm_tis.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > = > diff --git a/tpm_tis.c b/tpm_tis.c > index 98fe837..475ac5d 100644 > --- a/tpm_tis.c > +++ b/tpm_tis.c > @@ -1429,7 +1429,7 @@ struct tpm_chip* init_tpm2_tis(unsigned long basead= dr, int localities, unsigned > = > /* Map the page in now */ > if ((tpm->pages[i] =3D ioremap_nocache(addr, PAGE_SIZE)) =3D= =3D NULL) { > - printk("Unable to map iomem page a address %p\n", addr); > + printk("Unable to map iomem page a address %lx\n", addr); > goto abort_egress; > } > = > -- = > 1.7.10.4 > = -- = Samuel d-_-b how u make that inverted b? wait never mind _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Thu Jul 02 13:46:54 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 02 Jul 2015 13:46:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAepI-0001op-PQ; Thu, 02 Jul 2015 13:46:52 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZASHy-0002Ln-Bn for minios-devel@lists.xenproject.org; Thu, 02 Jul 2015 00:23:38 +0000 Received: from [85.158.139.211] by server-15.bemta-5.messagelabs.com id 5A/C4-25881-98484955; Thu, 02 Jul 2015 00:23:37 +0000 X-Env-Sender: SRS0=65XX=HK=ens-lyon.org=samuel.thibault@bounce.ens-lyon.o rg X-Msg-Ref: server-5.tower-206.messagelabs.com!1435796616!18299349!1 X-Originating-IP: [140.77.166.138] X-SpamReason: No, hits=0.2 required=7.0 tests=RCVD_ILLEGAL_IP X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 24095 invoked from network); 2 Jul 2015 00:23:36 -0000 Received: from domu-toccata.ens-lyon.fr (HELO sonata.ens-lyon.org) (140.77.166.138) by server-5.tower-206.messagelabs.com with DHE-RSA-AES256-SHA encrypted SMTP; 2 Jul 2015 00:23:36 -0000 Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 1414D200C6; Thu, 2 Jul 2015 02:23:36 +0200 (CEST) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qQgEdyMi8kRv; Thu, 2 Jul 2015 02:23:35 +0200 (CEST) Received: from type.youpi.perso.aquilenet.fr (ABordeaux-652-1-107-213.w2-6.abo.wanadoo.fr [2.6.154.213]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id E5CB0200C5; Thu, 2 Jul 2015 02:23:35 +0200 (CEST) Received: from samy by type.youpi.perso.aquilenet.fr with local (Exim 4.86_RC3) (envelope-from ) id 1ZASHv-0007E6-Dq; Thu, 02 Jul 2015 02:23:35 +0200 Date: Thu, 2 Jul 2015 02:23:35 +0200 From: Samuel Thibault To: Ian Campbell Message-ID: <20150702002335.GZ3245@type.home> Mail-Followup-To: Samuel Thibault , Ian Campbell , xen-devel@lists.xen.org, minios-devel@lists.xenproject.org, Daniel De Graaf , Thomas Leonard , Stefano Stabellini References: <1435316320-1811-1-git-send-email-ian.campbell@citrix.com> <1435316769-5784-1-git-send-email-ian.campbell@citrix.com> MIME-Version: 1.0 Content-Length: 3132 Content-Disposition: inline In-Reply-To: <1435316769-5784-1-git-send-email-ian.campbell@citrix.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) X-Mailman-Approved-At: Thu, 02 Jul 2015 13:46:51 +0000 Cc: minios-devel@lists.xenproject.org, Daniel De Graaf , Stefano Stabellini , Thomas Leonard , xen-devel@lists.xen.org Subject: Re: [Minios-devel] [PATCH xen] stubdom: vtpmmgr: Correctly format size_t with %z when printing. X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Ian Campbell, le Fri 26 Jun 2015 12:06:09 +0100, a =E9crit : > Also contains a fix from Thomas Leonard (to use %u for "4 + 32", not > %lu) previously posted as part of "mini-os: enable compiler check for > printk format types" but with mini-os now having been split a separate > repo most of that change has been applied there. > = > This fixes the 32-bit build with updated mini-os which includes format > string checking. > = > Signed-off-by: Thomas Leonard > Signed-off-by: Ian Campbell > Cc: Daniel De Graaf > Cc: Stefano Stabellini Acked-By: Samuel Thibault (after the 'z' modifier support is commited, of course) > --- > I intend to fold in an update to MINIOS_UPSTREAM_REVISION upon commit > to pull in the updated mini-os plus the "Correct printf formatting for > tpm_tis message." patch I've just posted. > --- > stubdom/vtpmmgr/disk_read.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > = > diff --git a/stubdom/vtpmmgr/disk_read.c b/stubdom/vtpmmgr/disk_read.c > index e9dc20f..944d3ff 100644 > --- a/stubdom/vtpmmgr/disk_read.c > +++ b/stubdom/vtpmmgr/disk_read.c > @@ -548,18 +548,18 @@ int vtpm_load_disk(void) > TPM_read_pcrs(); > = > printk("TPM Manager - disk format %d\n", TPM_MGR_VERSION); > - printk(" root seal: %lu; sector of %d: %lu\n", > + printk(" root seal: %zu; sector of %d: %zu\n", > sizeof(struct disk_root_sealed_data), SEALS_PER_ROOT_SEAL_LIST, sizeof= (struct disk_seal_list)); > - printk(" root: %lu v=3D%lu\n", sizeof(root1), sizeof(root1.v)); > - printk(" itree: %lu; sector of %d: %lu\n", > + printk(" root: %zu v=3D%zu\n", sizeof(root1), sizeof(root1.v)); > + printk(" itree: %u; sector of %d: %zu\n", > 4 + 32, NR_ENTRIES_PER_ITREE, sizeof(struct disk_itree_sector)); > - printk(" group: %lu v=3D%lu id=3D%lu md=3D%lu\n", > + printk(" group: %zu v=3D%zu id=3D%zu md=3D%zu\n", > sizeof(struct disk_group_sector), sizeof(struct disk_group_sector_mac3= _area), > sizeof(struct group_id_data), sizeof(struct group_details)); > - printk(" group seal: %lu; %d in parent: %lu; sector of %d: %lu\n", > + printk(" group seal: %zu; %d in parent: %zu; sector of %d: %zu\n", > sizeof(struct disk_group_sealed_data), NR_SEALS_PER_GROUP, sizeof(stru= ct disk_group_boot_config_list), > SEALS_PER_GROUP_SEAL_LIST, sizeof(struct disk_group_seal_list)); > - printk(" vtpm: %lu+%lu; sector of %d: %lu\n", > + printk(" vtpm: %zu+%zu; sector of %d: %zu\n", > sizeof(struct disk_vtpm_plain), sizeof(struct disk_vtpm_secret), > VTPMS_PER_SECTOR, sizeof(struct disk_vtpm_sector)); > = > -- = > 1.7.10.4 > = -- = Samuel /* Amuse the user. */ printk( " \\|/ ____ \\|/\n" " \"@'/ ,. \\`@\"\n" " /_| \\__/ |_\\\n" " \\__U_/\n"); (From linux/arch/sparc/kernel/traps.c:die_if_kernel()) _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Thu Jul 02 13:46:54 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 02 Jul 2015 13:46:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAepI-0001oR-JQ; Thu, 02 Jul 2015 13:46:52 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAEIy-0003UP-Ku for Minios-devel@lists.xenproject.org; Wed, 01 Jul 2015 09:27:44 +0000 Received: from [193.109.254.147] by server-12.bemta-14.messagelabs.com id 66/64-18733-F82B3955; Wed, 01 Jul 2015 09:27:43 +0000 X-Env-Sender: samuel.thibault@ens-lyon.org X-Msg-Ref: server-9.tower-27.messagelabs.com!1435742862!28247004!1 X-Originating-IP: [192.134.164.104] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 29567 invoked from network); 1 Jul 2015 09:27:43 -0000 Received: from mail3-relais-sop.national.inria.fr (HELO mail3-relais-sop.national.inria.fr) (192.134.164.104) by server-9.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 1 Jul 2015 09:27:43 -0000 X-IronPort-AV: E=Sophos;i="5.15,384,1432591200"; d="scan'208";a="138572898" Received: from unknown (HELO type.youpi.perso.aquilenet.fr) ([193.50.110.192]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/AES128-SHA; 01 Jul 2015 11:27:42 +0200 Received: from samy by type.youpi.perso.aquilenet.fr with local (Exim 4.86_RC3) (envelope-from ) id 1ZAEIw-0004jX-0W; Wed, 01 Jul 2015 11:27:42 +0200 Date: Wed, 1 Jul 2015 11:27:41 +0200 From: Samuel Thibault To: Thomas Leonard Message-ID: <20150701092741.GG3147@type.bordeaux.inria.fr> Mail-Followup-To: Samuel Thibault , Thomas Leonard , Minios-devel@lists.xenproject.org, stefano.stabellini@eu.citrix.com, Ian.Campbell@citrix.com References: <1435742690-4755-1-git-send-email-talex5@gmail.com> MIME-Version: 1.0 Content-Length: 1667 Content-Disposition: inline In-Reply-To: <1435742690-4755-1-git-send-email-talex5@gmail.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) X-Mailman-Approved-At: Thu, 02 Jul 2015 13:46:51 +0000 Cc: Minios-devel@lists.xenproject.org, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com Subject: Re: [Minios-devel] [PATCH] Accept %z in printf formats X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Thomas Leonard, le Wed 01 Jul 2015 10:24:50 +0100, a =E9crit : > Before, we only supported %Z (upper-case). It seems that the lower-case > version is standard, and this matches the behaviour of Xen's vsprintf.c. > = > Signed-off-by: Thomas Leonard Acked-by: Samuel Thibault > --- > lib/printf.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > = > diff --git a/lib/printf.c b/lib/printf.c > index 3d02e95..40f92fc 100644 > --- a/lib/printf.c > +++ b/lib/printf.c > @@ -346,12 +346,14 @@ int vsnprintf(char *buf, size_t size, const char *f= mt, va_list args) > = > /* get the conversion qualifier */ > qualifier =3D -1; > - if (*fmt =3D=3D 'h' || *fmt =3D=3D 'l' || *fmt =3D=3D 'L' || *fm= t =3D=3D'Z') { > + if (*fmt =3D=3D 'h' || *fmt =3D=3D 'l' || *fmt =3D=3D 'L' || *fm= t =3D=3D'Z' || *fmt =3D=3D 'z') { > qualifier =3D *fmt; > ++fmt; > if (qualifier =3D=3D 'l' && *fmt =3D=3D 'l') { > qualifier =3D 'L'; > ++fmt; > + } else if (qualifier =3D=3D 'z') { > + qualifier =3D 'Z'; > } > } > if (*fmt =3D=3D 'q') { > -- = > 2.4.2 > = -- = Samuel Anyone who thinks UNIX is intuitive should be forced to write 5000 lines of = code using nothing but vi or emacs. AAAAACK! (Discussion in comp.os.linux.misc on the intuitiveness of commands, especia= lly Emacs.) _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Thu Jul 02 13:46:54 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 02 Jul 2015 13:46:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAepI-0001od-Me; Thu, 02 Jul 2015 13:46:52 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZASFX-0002Bc-Da for Minios-devel@lists.xenproject.org; Thu, 02 Jul 2015 00:21:07 +0000 Received: from [85.158.139.211] by server-15.bemta-5.messagelabs.com id 9E/43-25881-FE384955; Thu, 02 Jul 2015 00:21:03 +0000 X-Env-Sender: SRS0=65XX=HK=ens-lyon.org=samuel.thibault@bounce.ens-lyon.o rg X-Msg-Ref: server-10.tower-206.messagelabs.com!1435796462!13026713!1 X-Originating-IP: [140.77.166.138] X-SpamReason: No, hits=0.7 required=7.0 tests=BODY_RANDOM_LONG, RCVD_ILLEGAL_IP,UPPERCASE_25_50 X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 15152 invoked from network); 2 Jul 2015 00:21:02 -0000 Received: from domu-toccata.ens-lyon.fr (HELO sonata.ens-lyon.org) (140.77.166.138) by server-10.tower-206.messagelabs.com with DHE-RSA-AES256-SHA encrypted SMTP; 2 Jul 2015 00:21:02 -0000 Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 44126200C9; Thu, 2 Jul 2015 02:21:02 +0200 (CEST) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q94EzLcUNaPp; Thu, 2 Jul 2015 02:21:02 +0200 (CEST) Received: from type.youpi.perso.aquilenet.fr (ABordeaux-652-1-107-213.w2-6.abo.wanadoo.fr [2.6.154.213]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 1BA3E200C5; Thu, 2 Jul 2015 02:21:02 +0200 (CEST) Received: from samy by type.youpi.perso.aquilenet.fr with local (Exim 4.86_RC3) (envelope-from ) id 1ZASFR-000793-Ic; Thu, 02 Jul 2015 02:21:01 +0200 Date: Thu, 2 Jul 2015 02:21:01 +0200 From: Samuel Thibault To: Thomas Leonard Message-ID: <20150702002101.GX3245@type.home> Mail-Followup-To: Samuel Thibault , Thomas Leonard , Minios-devel@lists.xenproject.org, stefano.stabellini@eu.citrix.com, anil@recoil.org, Dave.Scott@eu.citrix.com, karim.allah.ahmed@gmail.com, Ian.Campbell@citrix.com References: <1435240089-23413-1-git-send-email-talex5@gmail.com> <1435240089-23413-4-git-send-email-talex5@gmail.com> MIME-Version: 1.0 Content-Length: 12457 Content-Disposition: inline In-Reply-To: <1435240089-23413-4-git-send-email-talex5@gmail.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) X-Mailman-Approved-At: Thu, 02 Jul 2015 13:46:51 +0000 Cc: Ian.Campbell@citrix.com, anil@recoil.org, karim.allah.ahmed@gmail.com, stefano.stabellini@eu.citrix.com, Minios-devel@lists.xenproject.org, Dave.Scott@eu.citrix.com Subject: Re: [Minios-devel] [PATCH ARM v9 3/3] mini-os: arm: build system X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Thomas Leonard, le Thu 25 Jun 2015 14:48:09 +0100, a =E9crit : > Based on an initial patch by Karim Raslan. > = > This activates the ARM code added in the previous patches. On ARM, > Mini-OS will boot and display some output on the console. Tested with: > = > make XEN_TARGET_ARCH=3Darm32 CROSS_COMPILE=3Darm-linux-gnueabihf- \ > CONFIG_TEST=3Dy CONFIG_START_NETWORK=3Dn CONFIG_BLKFRONT=3Dn \ > CONFIG_NETFRONT=3Dn CONFIG_FBFRONT=3Dn CONFIG_KBDFRONT=3Dn \ > CONFIG_CONSFRONT=3Dn CONFIG_XC=3Dn -j4 > = > The memmove implementation is from FreeBSD's > contrib/ldns/compat/memmove.c (r246827). Then it should have its own copyright header copied from there, not just refer to COPYING. Apart from that it looks fine. > Signed-off-by: Karim Allah Ahmed > Signed-off-by: Thomas Leonard > = > --- > = > Changes since v8: > = > - updated for standalone Mini-OS repository > --- > .gitmodules | 3 +++ > COPYING | 27 +++++++++++++++++++++++++++ > Config.mk | 2 ++ > Makefile | 27 ++++++++++++++++++++++++++- > arch/arm/Makefile | 35 +++++++++++++++++++++++++++++++++++ > arch/arm/arch.mk | 6 ++++++ > dtc | 1 + > include/lib.h | 4 +++- > include/libfdt_env.h | 33 +++++++++++++++++++++++++++++++++ > lib/memmove.c | 45 +++++++++++++++++++++++++++++++++++++++++++++ > lib/string.c | 12 ++++++++++++ > 11 files changed, 193 insertions(+), 2 deletions(-) > create mode 100644 .gitmodules > create mode 100755 arch/arm/Makefile > create mode 100644 arch/arm/arch.mk > create mode 160000 dtc > create mode 100644 include/libfdt_env.h > create mode 100644 lib/memmove.c > = > diff --git a/.gitmodules b/.gitmodules > new file mode 100644 > index 0000000..221102d > --- /dev/null > +++ b/.gitmodules > @@ -0,0 +1,3 @@ > +[submodule "dtc"] > + path =3D dtc > + url =3D git://git.kernel.org/pub/scm/utils/dtc/dtc.git > diff --git a/COPYING b/COPYING > index 1d9df6c..b676bb6 100644 > --- a/COPYING > +++ b/COPYING > @@ -34,3 +34,30 @@ LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)= ARISING IN ANY WAY > OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF > SUCH DAMAGE. > = > + > +Copyright (c) 2005,2006, NLnetLabs > +All rights reserved. > + > +Redistribution and use in source and binary forms, with or without > +modification, are permitted provided that the following conditions are m= et: > + > + * Redistributions of source code must retain the above copyright not= ice, > + this list of conditions and the following disclaimer. > + * Redistributions in binary form must reproduce the above copyright > + notice, this list of conditions and the following disclaimer in the > + documentation and/or other materials provided with the distributio= n. > + * Neither the name of NLnetLabs nor the names of its > + contributors may be used to endorse or promote products derived fr= om this > + software without specific prior written permission. > + > +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS = IS" > +AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE > +IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPO= SE > +ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE > +LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR > +CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF > +SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS > +INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN > +CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) > +ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF T= HE > +POSSIBILITY OF SUCH DAMAGE. > diff --git a/Config.mk b/Config.mk > index e5d8ade..eb53f2d 100644 > --- a/Config.mk > +++ b/Config.mk > @@ -54,6 +54,8 @@ export XEN_INTERFACE_VERSION > # If not x86 then use $(MINIOS_TARGET_ARCH) > ifeq ($(findstring x86_,$(MINIOS_TARGET_ARCH)),x86_) > TARGET_ARCH_FAM =3D x86 > +else ifeq ($(findstring arm,$(MINIOS_TARGET_ARCH)),arm) > +TARGET_ARCH_FAM =3D arm > else > TARGET_ARCH_FAM =3D $(MINIOS_TARGET_ARCH) > endif > diff --git a/Makefile b/Makefile > index 2cb5e51..d06fc3b 100644 > --- a/Makefile > +++ b/Makefile > @@ -54,8 +54,15 @@ DEF_CFLAGS +=3D $(flags-y) > # Symlinks and headers that must be created before building the C files > GENERATED_HEADERS :=3D include/list.h $(ARCH_LINKS) include/mini-os incl= ude/$(TARGET_ARCH_FAM)/mini-os > = > +ifeq ($(MINIOS_TARGET_ARCH),arm32) > +GENERATED_HEADERS +=3D include/fdt.h include/libfdt.h > +endif > + > EXTRA_DEPS +=3D $(GENERATED_HEADERS) > = > +include/%.h: dtc/libfdt/%.h > + ln -s ../$^ $@ > + > # Include common mini-os makerules. > include minios.mk > = > @@ -76,7 +83,18 @@ EXTRA_OBJS =3D > TARGET :=3D mini-os > = > # Subdirectories common to mini-os > -SUBDIRS :=3D lib xenbus console > +SUBDIRS :=3D lib xenbus console dtc/libfdt > + > +FDT_SRC :=3D > +ifeq ($(MINIOS_TARGET_ARCH),arm32) > +# Need libgcc.a for division helpers > +LDLIBS +=3D `$(CC) -print-libgcc-file-name` > + > +# Device tree support > +FDT_SRC :=3D dtc/libfdt/fdt.c dtc/libfdt/fdt_ro.c dtc/libfdt/fdt_strerro= r.c > + > +src-y +=3D ${FDT_SRC} > +endif > = > src-$(CONFIG_BLKFRONT) +=3D blkfront.c > src-$(CONFIG_TPMFRONT) +=3D tpmfront.c > @@ -98,10 +116,13 @@ src-y +=3D sched.c > src-$(CONFIG_TEST) +=3D test.c > = > src-y +=3D lib/ctype.c > +ifneq ($(MINIOS_TARGET_ARCH),arm32) > src-y +=3D lib/math.c > +endif > src-y +=3D lib/printf.c > src-y +=3D lib/stack_chk_fail.c > src-y +=3D lib/string.c > +src-y +=3D lib/memmove.c > src-y +=3D lib/sys.c > src-y +=3D lib/xmalloc.c > src-$(CONFIG_XENBUS) +=3D lib/xs.c > @@ -188,7 +209,11 @@ $(OBJ_DIR)/$(TARGET): $(OBJS) $(APP_O) arch_lib > $(LD) -r $(LDFLAGS) $(HEAD_OBJ) $(APP_O) $(OBJS) $(LDARCHLIB) $(LDLIBS)= -o $@.o > $(OBJCOPY) -w -G $(GLOBAL_PREFIX)* -G _start $@.o $@.o > $(LD) $(LDFLAGS) $(LDFLAGS_FINAL) $@.o $(EXTRA_OBJS) -o $@ > +ifeq ($(MINIOS_TARGET_ARCH),arm32) > + $(OBJCOPY) -O binary $@ $@.img > +else > gzip -f -9 -c $@ >$@.gz > +endif > = > .PHONY: clean arch_clean > = > diff --git a/arch/arm/Makefile b/arch/arm/Makefile > new file mode 100755 > index 0000000..e018dad > --- /dev/null > +++ b/arch/arm/Makefile > @@ -0,0 +1,35 @@ > +# > +# ARM architecture specific makefiles. > +# > + > +TOPLEVEL_DIR =3D $(CURDIR)/../.. > +OBJ_DIR=3D$(CURDIR) > +include ../../Config.mk > + > +# include arch.mk has to be before minios.mk! > + > +include arch.mk > +include ../../minios.mk > + > +include $(MINI-OS_ROOT)/config/MiniOS.mk > + > + > +# Sources here are all *.c (without $(MINIOS_TARGET_ARCH).S) > +# This is handled in $(HEAD_ARCH_OBJ) > +ARCH_SRCS :=3D $(wildcard *.c) > + > +# The objects built from the sources. > +ARCH_OBJS :=3D $(patsubst %.c,$(OBJ_DIR)/%.o,$(ARCH_SRCS)) > + > +ARCH_OBJS +=3D $(OBJ_DIR)/hypercalls32.o > + > +all: $(OBJ_DIR)/$(ARCH_LIB) > + > +# $(HEAD_ARCH_OBJ) is only built here, needed on linking > +# in ../../Makefile. > +$(OBJ_DIR)/$(ARCH_LIB): $(ARCH_OBJS) $(OBJ_DIR)/$(HEAD_ARCH_OBJ) > + $(AR) rv $(OBJ_DIR)/$(ARCH_LIB) $(ARCH_OBJS) > + > +clean: > + rm -f $(OBJ_DIR)/$(ARCH_LIB) $(ARCH_OBJS) $(OBJ_DIR)/$(HEAD_ARCH_OBJ) > + > diff --git a/arch/arm/arch.mk b/arch/arm/arch.mk > new file mode 100644 > index 0000000..b4cb65b > --- /dev/null > +++ b/arch/arm/arch.mk > @@ -0,0 +1,6 @@ > +ifeq ($(MINIOS_TARGET_ARCH),arm32) > +DEF_ASFLAGS +=3D -march=3Darmv7-a -mfpu=3Dvfpv3 > +ARCH_CFLAGS :=3D -march=3Darmv7-a -marm -fms-extensions -D__arm__ -DXEN= _HAVE_PV_GUEST_ENTRY #-DCPU_EXCLUSIVE_LDST > +EXTRA_INC +=3D $(TARGET_ARCH_FAM)/$(MINIOS_TARGET_ARCH) > +EXTRA_SRC +=3D arch/$(EXTRA_INC) > +endif > diff --git a/dtc b/dtc > new file mode 160000 > index 0000000..64c46b0 > --- /dev/null > +++ b/dtc > @@ -0,0 +1 @@ > +Subproject commit 64c46b098b969502a74c8b0fd97e6f5e4aa07e21 > diff --git a/include/lib.h b/include/lib.h > index 62836c7..326e39f 100644 > --- a/include/lib.h > +++ b/include/lib.h > @@ -95,6 +95,7 @@ char *strncpy(char * __restrict, const char * __restric= t, size_t); > = > char *strstr(const char *, const char *); > = > +void *memmove(void *, const void *, size_t); > void *memset(void *, int, size_t); > = > char *strchr(const char *p, int ch); > @@ -104,7 +105,8 @@ char *strrchr(const char *p, int ch); > * @(#)systm.h 8.7 (Berkeley) 3/29/95 > * $FreeBSD$ > */ > -void *memcpy(void *to, const void *from, size_t len); > +void *memcpy(void *to, const void *from, size_t len); > +void *memchr(const void *s, int c, size_t n); > = > size_t strnlen(const char *, size_t); > #endif > diff --git a/include/libfdt_env.h b/include/libfdt_env.h > new file mode 100644 > index 0000000..722fac6 > --- /dev/null > +++ b/include/libfdt_env.h > @@ -0,0 +1,33 @@ > +#ifndef _LIBFDT_ENV_H > +#define _LIBFDT_ENV_H > + > +#include > +#include > +#include > + > +typedef uint16_t fdt16_t; > +typedef uint32_t fdt32_t; > +typedef uint64_t fdt64_t; > + > +#define EXTRACT_BYTE(n) ((unsigned long long)((uint8_t *)&x)[n]) > +static inline uint16_t fdt16_to_cpu(uint16_t x) > +{ > + return (EXTRACT_BYTE(0) << 8) | EXTRACT_BYTE(1); > +} > +#define cpu_to_fdt16(x) fdt16_to_cpu(x) > + > +static inline uint32_t fdt32_to_cpu(uint32_t x) > +{ > + return (EXTRACT_BYTE(0) << 24) | (EXTRACT_BYTE(1) << 16) | (EXTRACT_= BYTE(2) << 8) | EXTRACT_BYTE(3); > +} > +#define cpu_to_fdt32(x) fdt32_to_cpu(x) > + > +static inline uint64_t fdt64_to_cpu(uint64_t x) > +{ > + return (EXTRACT_BYTE(0) << 56) | (EXTRACT_BYTE(1) << 48) | (EXTRACT_= BYTE(2) << 40) | (EXTRACT_BYTE(3) << 32) > + | (EXTRACT_BYTE(4) << 24) | (EXTRACT_BYTE(5) << 16) | (EXTRA= CT_BYTE(6) << 8) | EXTRACT_BYTE(7); > +} > +#define cpu_to_fdt64(x) fdt64_to_cpu(x) > +#undef EXTRACT_BYTE > + > +#endif /* _LIBFDT_ENV_H */ > diff --git a/lib/memmove.c b/lib/memmove.c > new file mode 100644 > index 0000000..0298b7c > --- /dev/null > +++ b/lib/memmove.c > @@ -0,0 +1,45 @@ > +/* > + * memmove.c: memmove compat implementation. > + * > + * Copyright (c) 2001-2008, NLnet Labs. All rights reserved. > + * > + * See COPYING for the license. > +*/ > + > +#include > +#include > + > +#ifndef HAVE_LIBC > + > +void *memmove(void *dest, const void *src, size_t n) > +{ > + uint8_t* from =3D (uint8_t*) src; > + uint8_t* to =3D (uint8_t*) dest; > + > + if (from =3D=3D to || n =3D=3D 0) > + return dest; > + if (to > from && to-from < (int)n) { > + /* to overlaps with from */ > + /* */ > + /* */ > + /* copy in reverse, to avoid overwriting from */ > + int i; > + for(i=3Dn-1; i>=3D0; i--) > + to[i] =3D from[i]; > + return dest; > + } > + if (from > to && from-to < (int)n) { > + /* to overlaps with from */ > + /* */ > + /* */ > + /* copy forwards, to avoid overwriting from */ > + size_t i; > + for(i=3D0; i + to[i] =3D from[i]; > + return dest; > + } > + memcpy(dest, src, n); > + return dest; > +} > + > +#endif > diff --git a/lib/string.c b/lib/string.c > index 8b24146..c96ca41 100644 > --- a/lib/string.c > +++ b/lib/string.c > @@ -225,4 +225,16 @@ int ffs(int i) > return 0; > } > = > +void *memchr(const void *s, int c, size_t n) > +{ > + if (n !=3D 0) { > + const unsigned char *p =3D s; > + > + do { > + if (*p++ =3D=3D (unsigned char)c) > + return ((void *)(uintptr_t)(p - 1)); > + } while (--n !=3D 0); > + } > + return (NULL); > +} > #endif > -- = > 2.4.2 > = -- = Samuel /* Amuse the user in a SPARC fashion */ if (err) printk( KERN_CRIT " _______________________________ \n" KERN_CRIT " < Your System ate a SPARC! Gah! >\n" KERN_CRIT " ------------------------------- \n" KERN_CRIT " \\ ^__^\n" KERN_CRIT " \\ (xx)\\_______\n" KERN_CRIT " (__)\\ )\\/\\\n" KERN_CRIT " U ||----w |\n" KERN_CRIT " || ||\n"); (From linux/arch/parisc/kernel/traps.c:die_if_kernel()) _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Thu Jul 02 13:46:54 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 02 Jul 2015 13:46:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAepI-0001oW-Kf; Thu, 02 Jul 2015 13:46:52 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZASAi-00028s-FU for Minios-devel@lists.xenproject.org; Thu, 02 Jul 2015 00:16:08 +0000 Received: from [85.158.137.68] by server-16.bemta-3.messagelabs.com id BA/49-01068-7C284955; Thu, 02 Jul 2015 00:16:07 +0000 X-Env-Sender: SRS0=65XX=HK=ens-lyon.org=samuel.thibault@bounce.ens-lyon.o rg X-Msg-Ref: server-5.tower-31.messagelabs.com!1435796166!21855727!1 X-Originating-IP: [140.77.166.138] X-SpamReason: No, hits=0.2 required=7.0 tests=RCVD_ILLEGAL_IP X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 23363 invoked from network); 2 Jul 2015 00:16:07 -0000 Received: from sonata.ens-lyon.org (HELO sonata.ens-lyon.org) (140.77.166.138) by server-5.tower-31.messagelabs.com with DHE-RSA-AES256-SHA encrypted SMTP; 2 Jul 2015 00:16:07 -0000 Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id B2654200C6; Thu, 2 Jul 2015 02:16:06 +0200 (CEST) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lMwSh7mWmCb1; Thu, 2 Jul 2015 02:16:06 +0200 (CEST) Received: from type.youpi.perso.aquilenet.fr (ABordeaux-652-1-107-213.w2-6.abo.wanadoo.fr [2.6.154.213]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 2C2EB200C5; Thu, 2 Jul 2015 02:16:05 +0200 (CEST) Received: from samy by type.youpi.perso.aquilenet.fr with local (Exim 4.86_RC3) (envelope-from ) id 1ZASAf-00073x-5D; Thu, 02 Jul 2015 02:16:05 +0200 Date: Thu, 2 Jul 2015 02:16:05 +0200 From: Samuel Thibault To: Ian Campbell Message-ID: <20150702001605.GW3245@type.home> Mail-Followup-To: Samuel Thibault , Ian Campbell , Anil Madhavapeddy , Thomas Leonard , Dave.Scott@eu.citrix.com, stefano.stabellini@eu.citrix.com, karim.allah.ahmed@gmail.com, Minios-devel@lists.xenproject.org References: <1435240089-23413-1-git-send-email-talex5@gmail.com> <1435240089-23413-2-git-send-email-talex5@gmail.com> <1435247348.32500.98.camel@citrix.com> <1435303373.17598.33.camel@citrix.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="J/dobhs11T7y2rNN" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1435303373.17598.33.camel@citrix.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) X-Mailman-Approved-At: Thu, 02 Jul 2015 13:46:51 +0000 Cc: Thomas Leonard , Dave.Scott@eu.citrix.com, stefano.stabellini@eu.citrix.com, karim.allah.ahmed@gmail.com, Anil Madhavapeddy , Minios-devel@lists.xenproject.org Subject: Re: [Minios-devel] [PATCH ARM v9 1/3] mini-os: fix compiling with debug=n X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org --J/dobhs11T7y2rNN Content-Type: text/plain; charset=iso-8859-1 Content-Length: 2182 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Ian Campbell, le Fri 26 Jun 2015 08:22:53 +0100, a =E9crit : > On Thu, 2015-06-25 at 18:03 +0100, Anil Madhavapeddy wrote: > > On 25 Jun 2015, at 16:49, Ian Campbell wrote: > > > > > > On Thu, 2015-06-25 at 14:48 +0100, Thomas Leonard wrote: > > >> Without -fno-tree-loop-distribute-patterns, gcc -O3 recognises that our > > >> "memset" is doing a memset operation and tries to make it call the > > >> standard "memset", creating a loop. > > > > > > Isn't this what -nostdlib and such like are for=3F -nostdlib only has effect at link time. -ffreestanding would probably have that effect, but we are actually hosted really. string.c could however be built with -ffreestanding, since that part is not "hosted" actually. > > > In any case if we are to go down this route I think we'd be better off > > > applying it only to lib/string.c or even better just to the memset > > > function, if there is a way to do that. > > > > I think -nostdlib is distinct from -fno-builtins. If the issue is > > convincing GCC to not replace the memset with a builtin one, would > > -fno-builtin-memset be more appropriate here=3F Actually we already have -fno-builtin in minios.mk... > Ideally the tweak would be applied with the smallest possible scope, > such that when compiling application code gcc can spot memset > opportunities and call the "builtin" which is actually the one provided > by mini-os. Yes. > If it's more complicated than > __attribute__((no-builtin-memset)) on the function then it's probably > not worth losing too much sleep over though. This does have the proper scope. I don't know whether -ffreestanding does fix the issue at stake. diff --git a/minios.mk b/minios.mk index b0d9f71..9958554 100644 --- a/minios.mk +++ b/minios.mk @@ -12,6 +12,8 @@ DEF_CFLAGS +=3D $(call cc-option,$(CC),-fgnu89-inline) DEF_CFLAGS +=3D -Wstrict-prototypes -Wnested-externs -Wpointer-arith -Winline DEF_CPPFLAGS +=3D -D__XEN_INTERFACE_VERSION__=3D$(XEN_INTERFACE_VERSION) +$(OBJ_DIR)/lib/string.o: CFLAGS +=3D -ffreestanding + DEF_ASFLAGS +=3D -D__ASSEMBLY__ DEF_LDFLAGS +=3D Samuel --J/dobhs11T7y2rNN Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=patch diff --git a/minios.mk b/minios.mk index b0d9f71..9958554 100644 --- a/minios.mk +++ b/minios.mk @@ -12,6 +12,8 @@ DEF_CFLAGS += $(call cc-option,$(CC),-fgnu89-inline) DEF_CFLAGS += -Wstrict-prototypes -Wnested-externs -Wpointer-arith -Winline DEF_CPPFLAGS += -D__XEN_INTERFACE_VERSION__=$(XEN_INTERFACE_VERSION) +$(OBJ_DIR)/lib/string.o: CFLAGS += -ffreestanding + DEF_ASFLAGS += -D__ASSEMBLY__ DEF_LDFLAGS += --J/dobhs11T7y2rNN Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel --J/dobhs11T7y2rNN-- From minios-devel-bounces@lists.xenproject.org Thu Jul 02 13:46:54 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 02 Jul 2015 13:46:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAepI-0001oR-JQ; Thu, 02 Jul 2015 13:46:52 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAEIy-0003UP-Ku for Minios-devel@lists.xenproject.org; Wed, 01 Jul 2015 09:27:44 +0000 Received: from [193.109.254.147] by server-12.bemta-14.messagelabs.com id 66/64-18733-F82B3955; Wed, 01 Jul 2015 09:27:43 +0000 X-Env-Sender: samuel.thibault@ens-lyon.org X-Msg-Ref: server-9.tower-27.messagelabs.com!1435742862!28247004!1 X-Originating-IP: [192.134.164.104] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 29567 invoked from network); 1 Jul 2015 09:27:43 -0000 Received: from mail3-relais-sop.national.inria.fr (HELO mail3-relais-sop.national.inria.fr) (192.134.164.104) by server-9.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 1 Jul 2015 09:27:43 -0000 X-IronPort-AV: E=Sophos;i="5.15,384,1432591200"; d="scan'208";a="138572898" Received: from unknown (HELO type.youpi.perso.aquilenet.fr) ([193.50.110.192]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/AES128-SHA; 01 Jul 2015 11:27:42 +0200 Received: from samy by type.youpi.perso.aquilenet.fr with local (Exim 4.86_RC3) (envelope-from ) id 1ZAEIw-0004jX-0W; Wed, 01 Jul 2015 11:27:42 +0200 Date: Wed, 1 Jul 2015 11:27:41 +0200 From: Samuel Thibault To: Thomas Leonard Message-ID: <20150701092741.GG3147@type.bordeaux.inria.fr> Mail-Followup-To: Samuel Thibault , Thomas Leonard , Minios-devel@lists.xenproject.org, stefano.stabellini@eu.citrix.com, Ian.Campbell@citrix.com References: <1435742690-4755-1-git-send-email-talex5@gmail.com> MIME-Version: 1.0 Content-Length: 1667 Content-Disposition: inline In-Reply-To: <1435742690-4755-1-git-send-email-talex5@gmail.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) X-Mailman-Approved-At: Thu, 02 Jul 2015 13:46:51 +0000 Cc: Minios-devel@lists.xenproject.org, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com Subject: Re: [Minios-devel] [PATCH] Accept %z in printf formats X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Thomas Leonard, le Wed 01 Jul 2015 10:24:50 +0100, a =E9crit : > Before, we only supported %Z (upper-case). It seems that the lower-case > version is standard, and this matches the behaviour of Xen's vsprintf.c. > = > Signed-off-by: Thomas Leonard Acked-by: Samuel Thibault > --- > lib/printf.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > = > diff --git a/lib/printf.c b/lib/printf.c > index 3d02e95..40f92fc 100644 > --- a/lib/printf.c > +++ b/lib/printf.c > @@ -346,12 +346,14 @@ int vsnprintf(char *buf, size_t size, const char *f= mt, va_list args) > = > /* get the conversion qualifier */ > qualifier =3D -1; > - if (*fmt =3D=3D 'h' || *fmt =3D=3D 'l' || *fmt =3D=3D 'L' || *fm= t =3D=3D'Z') { > + if (*fmt =3D=3D 'h' || *fmt =3D=3D 'l' || *fmt =3D=3D 'L' || *fm= t =3D=3D'Z' || *fmt =3D=3D 'z') { > qualifier =3D *fmt; > ++fmt; > if (qualifier =3D=3D 'l' && *fmt =3D=3D 'l') { > qualifier =3D 'L'; > ++fmt; > + } else if (qualifier =3D=3D 'z') { > + qualifier =3D 'Z'; > } > } > if (*fmt =3D=3D 'q') { > -- = > 2.4.2 > = -- = Samuel Anyone who thinks UNIX is intuitive should be forced to write 5000 lines of = code using nothing but vi or emacs. AAAAACK! (Discussion in comp.os.linux.misc on the intuitiveness of commands, especia= lly Emacs.) _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Thu Jul 02 13:46:54 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 02 Jul 2015 13:46:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAepI-0001op-PQ; Thu, 02 Jul 2015 13:46:52 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZASHy-0002Ln-Bn for minios-devel@lists.xenproject.org; Thu, 02 Jul 2015 00:23:38 +0000 Received: from [85.158.139.211] by server-15.bemta-5.messagelabs.com id 5A/C4-25881-98484955; Thu, 02 Jul 2015 00:23:37 +0000 X-Env-Sender: SRS0=65XX=HK=ens-lyon.org=samuel.thibault@bounce.ens-lyon.o rg X-Msg-Ref: server-5.tower-206.messagelabs.com!1435796616!18299349!1 X-Originating-IP: [140.77.166.138] X-SpamReason: No, hits=0.2 required=7.0 tests=RCVD_ILLEGAL_IP X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 24095 invoked from network); 2 Jul 2015 00:23:36 -0000 Received: from domu-toccata.ens-lyon.fr (HELO sonata.ens-lyon.org) (140.77.166.138) by server-5.tower-206.messagelabs.com with DHE-RSA-AES256-SHA encrypted SMTP; 2 Jul 2015 00:23:36 -0000 Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 1414D200C6; Thu, 2 Jul 2015 02:23:36 +0200 (CEST) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qQgEdyMi8kRv; Thu, 2 Jul 2015 02:23:35 +0200 (CEST) Received: from type.youpi.perso.aquilenet.fr (ABordeaux-652-1-107-213.w2-6.abo.wanadoo.fr [2.6.154.213]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id E5CB0200C5; Thu, 2 Jul 2015 02:23:35 +0200 (CEST) Received: from samy by type.youpi.perso.aquilenet.fr with local (Exim 4.86_RC3) (envelope-from ) id 1ZASHv-0007E6-Dq; Thu, 02 Jul 2015 02:23:35 +0200 Date: Thu, 2 Jul 2015 02:23:35 +0200 From: Samuel Thibault To: Ian Campbell Message-ID: <20150702002335.GZ3245@type.home> Mail-Followup-To: Samuel Thibault , Ian Campbell , xen-devel@lists.xen.org, minios-devel@lists.xenproject.org, Daniel De Graaf , Thomas Leonard , Stefano Stabellini References: <1435316320-1811-1-git-send-email-ian.campbell@citrix.com> <1435316769-5784-1-git-send-email-ian.campbell@citrix.com> MIME-Version: 1.0 Content-Length: 3132 Content-Disposition: inline In-Reply-To: <1435316769-5784-1-git-send-email-ian.campbell@citrix.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) X-Mailman-Approved-At: Thu, 02 Jul 2015 13:46:51 +0000 Cc: minios-devel@lists.xenproject.org, Daniel De Graaf , Stefano Stabellini , Thomas Leonard , xen-devel@lists.xen.org Subject: Re: [Minios-devel] [PATCH xen] stubdom: vtpmmgr: Correctly format size_t with %z when printing. X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Ian Campbell, le Fri 26 Jun 2015 12:06:09 +0100, a =E9crit : > Also contains a fix from Thomas Leonard (to use %u for "4 + 32", not > %lu) previously posted as part of "mini-os: enable compiler check for > printk format types" but with mini-os now having been split a separate > repo most of that change has been applied there. > = > This fixes the 32-bit build with updated mini-os which includes format > string checking. > = > Signed-off-by: Thomas Leonard > Signed-off-by: Ian Campbell > Cc: Daniel De Graaf > Cc: Stefano Stabellini Acked-By: Samuel Thibault (after the 'z' modifier support is commited, of course) > --- > I intend to fold in an update to MINIOS_UPSTREAM_REVISION upon commit > to pull in the updated mini-os plus the "Correct printf formatting for > tpm_tis message." patch I've just posted. > --- > stubdom/vtpmmgr/disk_read.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > = > diff --git a/stubdom/vtpmmgr/disk_read.c b/stubdom/vtpmmgr/disk_read.c > index e9dc20f..944d3ff 100644 > --- a/stubdom/vtpmmgr/disk_read.c > +++ b/stubdom/vtpmmgr/disk_read.c > @@ -548,18 +548,18 @@ int vtpm_load_disk(void) > TPM_read_pcrs(); > = > printk("TPM Manager - disk format %d\n", TPM_MGR_VERSION); > - printk(" root seal: %lu; sector of %d: %lu\n", > + printk(" root seal: %zu; sector of %d: %zu\n", > sizeof(struct disk_root_sealed_data), SEALS_PER_ROOT_SEAL_LIST, sizeof= (struct disk_seal_list)); > - printk(" root: %lu v=3D%lu\n", sizeof(root1), sizeof(root1.v)); > - printk(" itree: %lu; sector of %d: %lu\n", > + printk(" root: %zu v=3D%zu\n", sizeof(root1), sizeof(root1.v)); > + printk(" itree: %u; sector of %d: %zu\n", > 4 + 32, NR_ENTRIES_PER_ITREE, sizeof(struct disk_itree_sector)); > - printk(" group: %lu v=3D%lu id=3D%lu md=3D%lu\n", > + printk(" group: %zu v=3D%zu id=3D%zu md=3D%zu\n", > sizeof(struct disk_group_sector), sizeof(struct disk_group_sector_mac3= _area), > sizeof(struct group_id_data), sizeof(struct group_details)); > - printk(" group seal: %lu; %d in parent: %lu; sector of %d: %lu\n", > + printk(" group seal: %zu; %d in parent: %zu; sector of %d: %zu\n", > sizeof(struct disk_group_sealed_data), NR_SEALS_PER_GROUP, sizeof(stru= ct disk_group_boot_config_list), > SEALS_PER_GROUP_SEAL_LIST, sizeof(struct disk_group_seal_list)); > - printk(" vtpm: %lu+%lu; sector of %d: %lu\n", > + printk(" vtpm: %zu+%zu; sector of %d: %zu\n", > sizeof(struct disk_vtpm_plain), sizeof(struct disk_vtpm_secret), > VTPMS_PER_SECTOR, sizeof(struct disk_vtpm_sector)); > = > -- = > 1.7.10.4 > = -- = Samuel /* Amuse the user. */ printk( " \\|/ ____ \\|/\n" " \"@'/ ,. \\`@\"\n" " /_| \\__/ |_\\\n" " \\__U_/\n"); (From linux/arch/sparc/kernel/traps.c:die_if_kernel()) _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Thu Jul 02 13:46:54 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 02 Jul 2015 13:46:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAepI-0001oj-O1; Thu, 02 Jul 2015 13:46:52 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZASGA-0002Ca-Pn for minios-devel@lists.xenproject.org; Thu, 02 Jul 2015 00:21:46 +0000 Received: from [85.158.139.211] by server-1.bemta-5.messagelabs.com id C6/9B-31880-A1484955; Thu, 02 Jul 2015 00:21:46 +0000 X-Env-Sender: SRS0=65XX=HK=ens-lyon.org=samuel.thibault@bounce.ens-lyon.o rg X-Msg-Ref: server-15.tower-206.messagelabs.com!1435796504!14967745!1 X-Originating-IP: [140.77.166.138] X-SpamReason: No, hits=0.2 required=7.0 tests=RCVD_ILLEGAL_IP X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 16844 invoked from network); 2 Jul 2015 00:21:45 -0000 Received: from sonata.ens-lyon.org (HELO sonata.ens-lyon.org) (140.77.166.138) by server-15.tower-206.messagelabs.com with DHE-RSA-AES256-SHA encrypted SMTP; 2 Jul 2015 00:21:45 -0000 Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id DEE6E200C6; Thu, 2 Jul 2015 02:21:44 +0200 (CEST) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JCf58kRmsjir; Thu, 2 Jul 2015 02:21:44 +0200 (CEST) Received: from type.youpi.perso.aquilenet.fr (ABordeaux-652-1-107-213.w2-6.abo.wanadoo.fr [2.6.154.213]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 46CC9200C5; Thu, 2 Jul 2015 02:21:44 +0200 (CEST) Received: from samy by type.youpi.perso.aquilenet.fr with local (Exim 4.86_RC3) (envelope-from ) id 1ZASG7-0007A0-RS; Thu, 02 Jul 2015 02:21:43 +0200 Date: Thu, 2 Jul 2015 02:21:43 +0200 From: Samuel Thibault To: Ian Campbell Message-ID: <20150702002143.GY3245@type.home> Mail-Followup-To: Samuel Thibault , Ian Campbell , minios-devel@lists.xenproject.org, xen-devel@lists.xen.org, Daniel De Graaf , Thomas Leonard References: <1435316320-1811-1-git-send-email-ian.campbell@citrix.com> MIME-Version: 1.0 Content-Length: 1205 Content-Disposition: inline In-Reply-To: <1435316320-1811-1-git-send-email-ian.campbell@citrix.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) X-Mailman-Approved-At: Thu, 02 Jul 2015 13:46:51 +0000 Cc: minios-devel@lists.xenproject.org, Daniel De Graaf , Thomas Leonard , xen-devel@lists.xen.org Subject: Re: [Minios-devel] [PATCH mini-os] Correct printf formatting for tpm_tis message. X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Ian Campbell, le Fri 26 Jun 2015 11:58:40 +0100, a =E9crit : > This is under #ifdef HAVE_LIBC so went unnoticed before. > = > Signed-off-by: Ian Campbell Acked-by: Samuel Thibault > --- > tpm_tis.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > = > diff --git a/tpm_tis.c b/tpm_tis.c > index 98fe837..475ac5d 100644 > --- a/tpm_tis.c > +++ b/tpm_tis.c > @@ -1429,7 +1429,7 @@ struct tpm_chip* init_tpm2_tis(unsigned long basead= dr, int localities, unsigned > = > /* Map the page in now */ > if ((tpm->pages[i] =3D ioremap_nocache(addr, PAGE_SIZE)) =3D= =3D NULL) { > - printk("Unable to map iomem page a address %p\n", addr); > + printk("Unable to map iomem page a address %lx\n", addr); > goto abort_egress; > } > = > -- = > 1.7.10.4 > = -- = Samuel d-_-b how u make that inverted b? wait never mind _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Thu Jul 02 13:46:54 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 02 Jul 2015 13:46:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAepI-0001od-Me; Thu, 02 Jul 2015 13:46:52 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZASFX-0002Bc-Da for Minios-devel@lists.xenproject.org; Thu, 02 Jul 2015 00:21:07 +0000 Received: from [85.158.139.211] by server-15.bemta-5.messagelabs.com id 9E/43-25881-FE384955; Thu, 02 Jul 2015 00:21:03 +0000 X-Env-Sender: SRS0=65XX=HK=ens-lyon.org=samuel.thibault@bounce.ens-lyon.o rg X-Msg-Ref: server-10.tower-206.messagelabs.com!1435796462!13026713!1 X-Originating-IP: [140.77.166.138] X-SpamReason: No, hits=0.7 required=7.0 tests=BODY_RANDOM_LONG, RCVD_ILLEGAL_IP,UPPERCASE_25_50 X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 15152 invoked from network); 2 Jul 2015 00:21:02 -0000 Received: from domu-toccata.ens-lyon.fr (HELO sonata.ens-lyon.org) (140.77.166.138) by server-10.tower-206.messagelabs.com with DHE-RSA-AES256-SHA encrypted SMTP; 2 Jul 2015 00:21:02 -0000 Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 44126200C9; Thu, 2 Jul 2015 02:21:02 +0200 (CEST) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q94EzLcUNaPp; Thu, 2 Jul 2015 02:21:02 +0200 (CEST) Received: from type.youpi.perso.aquilenet.fr (ABordeaux-652-1-107-213.w2-6.abo.wanadoo.fr [2.6.154.213]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 1BA3E200C5; Thu, 2 Jul 2015 02:21:02 +0200 (CEST) Received: from samy by type.youpi.perso.aquilenet.fr with local (Exim 4.86_RC3) (envelope-from ) id 1ZASFR-000793-Ic; Thu, 02 Jul 2015 02:21:01 +0200 Date: Thu, 2 Jul 2015 02:21:01 +0200 From: Samuel Thibault To: Thomas Leonard Message-ID: <20150702002101.GX3245@type.home> Mail-Followup-To: Samuel Thibault , Thomas Leonard , Minios-devel@lists.xenproject.org, stefano.stabellini@eu.citrix.com, anil@recoil.org, Dave.Scott@eu.citrix.com, karim.allah.ahmed@gmail.com, Ian.Campbell@citrix.com References: <1435240089-23413-1-git-send-email-talex5@gmail.com> <1435240089-23413-4-git-send-email-talex5@gmail.com> MIME-Version: 1.0 Content-Length: 12457 Content-Disposition: inline In-Reply-To: <1435240089-23413-4-git-send-email-talex5@gmail.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) X-Mailman-Approved-At: Thu, 02 Jul 2015 13:46:51 +0000 Cc: Ian.Campbell@citrix.com, anil@recoil.org, karim.allah.ahmed@gmail.com, stefano.stabellini@eu.citrix.com, Minios-devel@lists.xenproject.org, Dave.Scott@eu.citrix.com Subject: Re: [Minios-devel] [PATCH ARM v9 3/3] mini-os: arm: build system X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Thomas Leonard, le Thu 25 Jun 2015 14:48:09 +0100, a =E9crit : > Based on an initial patch by Karim Raslan. > = > This activates the ARM code added in the previous patches. On ARM, > Mini-OS will boot and display some output on the console. Tested with: > = > make XEN_TARGET_ARCH=3Darm32 CROSS_COMPILE=3Darm-linux-gnueabihf- \ > CONFIG_TEST=3Dy CONFIG_START_NETWORK=3Dn CONFIG_BLKFRONT=3Dn \ > CONFIG_NETFRONT=3Dn CONFIG_FBFRONT=3Dn CONFIG_KBDFRONT=3Dn \ > CONFIG_CONSFRONT=3Dn CONFIG_XC=3Dn -j4 > = > The memmove implementation is from FreeBSD's > contrib/ldns/compat/memmove.c (r246827). Then it should have its own copyright header copied from there, not just refer to COPYING. Apart from that it looks fine. > Signed-off-by: Karim Allah Ahmed > Signed-off-by: Thomas Leonard > = > --- > = > Changes since v8: > = > - updated for standalone Mini-OS repository > --- > .gitmodules | 3 +++ > COPYING | 27 +++++++++++++++++++++++++++ > Config.mk | 2 ++ > Makefile | 27 ++++++++++++++++++++++++++- > arch/arm/Makefile | 35 +++++++++++++++++++++++++++++++++++ > arch/arm/arch.mk | 6 ++++++ > dtc | 1 + > include/lib.h | 4 +++- > include/libfdt_env.h | 33 +++++++++++++++++++++++++++++++++ > lib/memmove.c | 45 +++++++++++++++++++++++++++++++++++++++++++++ > lib/string.c | 12 ++++++++++++ > 11 files changed, 193 insertions(+), 2 deletions(-) > create mode 100644 .gitmodules > create mode 100755 arch/arm/Makefile > create mode 100644 arch/arm/arch.mk > create mode 160000 dtc > create mode 100644 include/libfdt_env.h > create mode 100644 lib/memmove.c > = > diff --git a/.gitmodules b/.gitmodules > new file mode 100644 > index 0000000..221102d > --- /dev/null > +++ b/.gitmodules > @@ -0,0 +1,3 @@ > +[submodule "dtc"] > + path =3D dtc > + url =3D git://git.kernel.org/pub/scm/utils/dtc/dtc.git > diff --git a/COPYING b/COPYING > index 1d9df6c..b676bb6 100644 > --- a/COPYING > +++ b/COPYING > @@ -34,3 +34,30 @@ LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)= ARISING IN ANY WAY > OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF > SUCH DAMAGE. > = > + > +Copyright (c) 2005,2006, NLnetLabs > +All rights reserved. > + > +Redistribution and use in source and binary forms, with or without > +modification, are permitted provided that the following conditions are m= et: > + > + * Redistributions of source code must retain the above copyright not= ice, > + this list of conditions and the following disclaimer. > + * Redistributions in binary form must reproduce the above copyright > + notice, this list of conditions and the following disclaimer in the > + documentation and/or other materials provided with the distributio= n. > + * Neither the name of NLnetLabs nor the names of its > + contributors may be used to endorse or promote products derived fr= om this > + software without specific prior written permission. > + > +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS = IS" > +AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE > +IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPO= SE > +ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE > +LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR > +CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF > +SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS > +INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN > +CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) > +ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF T= HE > +POSSIBILITY OF SUCH DAMAGE. > diff --git a/Config.mk b/Config.mk > index e5d8ade..eb53f2d 100644 > --- a/Config.mk > +++ b/Config.mk > @@ -54,6 +54,8 @@ export XEN_INTERFACE_VERSION > # If not x86 then use $(MINIOS_TARGET_ARCH) > ifeq ($(findstring x86_,$(MINIOS_TARGET_ARCH)),x86_) > TARGET_ARCH_FAM =3D x86 > +else ifeq ($(findstring arm,$(MINIOS_TARGET_ARCH)),arm) > +TARGET_ARCH_FAM =3D arm > else > TARGET_ARCH_FAM =3D $(MINIOS_TARGET_ARCH) > endif > diff --git a/Makefile b/Makefile > index 2cb5e51..d06fc3b 100644 > --- a/Makefile > +++ b/Makefile > @@ -54,8 +54,15 @@ DEF_CFLAGS +=3D $(flags-y) > # Symlinks and headers that must be created before building the C files > GENERATED_HEADERS :=3D include/list.h $(ARCH_LINKS) include/mini-os incl= ude/$(TARGET_ARCH_FAM)/mini-os > = > +ifeq ($(MINIOS_TARGET_ARCH),arm32) > +GENERATED_HEADERS +=3D include/fdt.h include/libfdt.h > +endif > + > EXTRA_DEPS +=3D $(GENERATED_HEADERS) > = > +include/%.h: dtc/libfdt/%.h > + ln -s ../$^ $@ > + > # Include common mini-os makerules. > include minios.mk > = > @@ -76,7 +83,18 @@ EXTRA_OBJS =3D > TARGET :=3D mini-os > = > # Subdirectories common to mini-os > -SUBDIRS :=3D lib xenbus console > +SUBDIRS :=3D lib xenbus console dtc/libfdt > + > +FDT_SRC :=3D > +ifeq ($(MINIOS_TARGET_ARCH),arm32) > +# Need libgcc.a for division helpers > +LDLIBS +=3D `$(CC) -print-libgcc-file-name` > + > +# Device tree support > +FDT_SRC :=3D dtc/libfdt/fdt.c dtc/libfdt/fdt_ro.c dtc/libfdt/fdt_strerro= r.c > + > +src-y +=3D ${FDT_SRC} > +endif > = > src-$(CONFIG_BLKFRONT) +=3D blkfront.c > src-$(CONFIG_TPMFRONT) +=3D tpmfront.c > @@ -98,10 +116,13 @@ src-y +=3D sched.c > src-$(CONFIG_TEST) +=3D test.c > = > src-y +=3D lib/ctype.c > +ifneq ($(MINIOS_TARGET_ARCH),arm32) > src-y +=3D lib/math.c > +endif > src-y +=3D lib/printf.c > src-y +=3D lib/stack_chk_fail.c > src-y +=3D lib/string.c > +src-y +=3D lib/memmove.c > src-y +=3D lib/sys.c > src-y +=3D lib/xmalloc.c > src-$(CONFIG_XENBUS) +=3D lib/xs.c > @@ -188,7 +209,11 @@ $(OBJ_DIR)/$(TARGET): $(OBJS) $(APP_O) arch_lib > $(LD) -r $(LDFLAGS) $(HEAD_OBJ) $(APP_O) $(OBJS) $(LDARCHLIB) $(LDLIBS)= -o $@.o > $(OBJCOPY) -w -G $(GLOBAL_PREFIX)* -G _start $@.o $@.o > $(LD) $(LDFLAGS) $(LDFLAGS_FINAL) $@.o $(EXTRA_OBJS) -o $@ > +ifeq ($(MINIOS_TARGET_ARCH),arm32) > + $(OBJCOPY) -O binary $@ $@.img > +else > gzip -f -9 -c $@ >$@.gz > +endif > = > .PHONY: clean arch_clean > = > diff --git a/arch/arm/Makefile b/arch/arm/Makefile > new file mode 100755 > index 0000000..e018dad > --- /dev/null > +++ b/arch/arm/Makefile > @@ -0,0 +1,35 @@ > +# > +# ARM architecture specific makefiles. > +# > + > +TOPLEVEL_DIR =3D $(CURDIR)/../.. > +OBJ_DIR=3D$(CURDIR) > +include ../../Config.mk > + > +# include arch.mk has to be before minios.mk! > + > +include arch.mk > +include ../../minios.mk > + > +include $(MINI-OS_ROOT)/config/MiniOS.mk > + > + > +# Sources here are all *.c (without $(MINIOS_TARGET_ARCH).S) > +# This is handled in $(HEAD_ARCH_OBJ) > +ARCH_SRCS :=3D $(wildcard *.c) > + > +# The objects built from the sources. > +ARCH_OBJS :=3D $(patsubst %.c,$(OBJ_DIR)/%.o,$(ARCH_SRCS)) > + > +ARCH_OBJS +=3D $(OBJ_DIR)/hypercalls32.o > + > +all: $(OBJ_DIR)/$(ARCH_LIB) > + > +# $(HEAD_ARCH_OBJ) is only built here, needed on linking > +# in ../../Makefile. > +$(OBJ_DIR)/$(ARCH_LIB): $(ARCH_OBJS) $(OBJ_DIR)/$(HEAD_ARCH_OBJ) > + $(AR) rv $(OBJ_DIR)/$(ARCH_LIB) $(ARCH_OBJS) > + > +clean: > + rm -f $(OBJ_DIR)/$(ARCH_LIB) $(ARCH_OBJS) $(OBJ_DIR)/$(HEAD_ARCH_OBJ) > + > diff --git a/arch/arm/arch.mk b/arch/arm/arch.mk > new file mode 100644 > index 0000000..b4cb65b > --- /dev/null > +++ b/arch/arm/arch.mk > @@ -0,0 +1,6 @@ > +ifeq ($(MINIOS_TARGET_ARCH),arm32) > +DEF_ASFLAGS +=3D -march=3Darmv7-a -mfpu=3Dvfpv3 > +ARCH_CFLAGS :=3D -march=3Darmv7-a -marm -fms-extensions -D__arm__ -DXEN= _HAVE_PV_GUEST_ENTRY #-DCPU_EXCLUSIVE_LDST > +EXTRA_INC +=3D $(TARGET_ARCH_FAM)/$(MINIOS_TARGET_ARCH) > +EXTRA_SRC +=3D arch/$(EXTRA_INC) > +endif > diff --git a/dtc b/dtc > new file mode 160000 > index 0000000..64c46b0 > --- /dev/null > +++ b/dtc > @@ -0,0 +1 @@ > +Subproject commit 64c46b098b969502a74c8b0fd97e6f5e4aa07e21 > diff --git a/include/lib.h b/include/lib.h > index 62836c7..326e39f 100644 > --- a/include/lib.h > +++ b/include/lib.h > @@ -95,6 +95,7 @@ char *strncpy(char * __restrict, const char * __restric= t, size_t); > = > char *strstr(const char *, const char *); > = > +void *memmove(void *, const void *, size_t); > void *memset(void *, int, size_t); > = > char *strchr(const char *p, int ch); > @@ -104,7 +105,8 @@ char *strrchr(const char *p, int ch); > * @(#)systm.h 8.7 (Berkeley) 3/29/95 > * $FreeBSD$ > */ > -void *memcpy(void *to, const void *from, size_t len); > +void *memcpy(void *to, const void *from, size_t len); > +void *memchr(const void *s, int c, size_t n); > = > size_t strnlen(const char *, size_t); > #endif > diff --git a/include/libfdt_env.h b/include/libfdt_env.h > new file mode 100644 > index 0000000..722fac6 > --- /dev/null > +++ b/include/libfdt_env.h > @@ -0,0 +1,33 @@ > +#ifndef _LIBFDT_ENV_H > +#define _LIBFDT_ENV_H > + > +#include > +#include > +#include > + > +typedef uint16_t fdt16_t; > +typedef uint32_t fdt32_t; > +typedef uint64_t fdt64_t; > + > +#define EXTRACT_BYTE(n) ((unsigned long long)((uint8_t *)&x)[n]) > +static inline uint16_t fdt16_to_cpu(uint16_t x) > +{ > + return (EXTRACT_BYTE(0) << 8) | EXTRACT_BYTE(1); > +} > +#define cpu_to_fdt16(x) fdt16_to_cpu(x) > + > +static inline uint32_t fdt32_to_cpu(uint32_t x) > +{ > + return (EXTRACT_BYTE(0) << 24) | (EXTRACT_BYTE(1) << 16) | (EXTRACT_= BYTE(2) << 8) | EXTRACT_BYTE(3); > +} > +#define cpu_to_fdt32(x) fdt32_to_cpu(x) > + > +static inline uint64_t fdt64_to_cpu(uint64_t x) > +{ > + return (EXTRACT_BYTE(0) << 56) | (EXTRACT_BYTE(1) << 48) | (EXTRACT_= BYTE(2) << 40) | (EXTRACT_BYTE(3) << 32) > + | (EXTRACT_BYTE(4) << 24) | (EXTRACT_BYTE(5) << 16) | (EXTRA= CT_BYTE(6) << 8) | EXTRACT_BYTE(7); > +} > +#define cpu_to_fdt64(x) fdt64_to_cpu(x) > +#undef EXTRACT_BYTE > + > +#endif /* _LIBFDT_ENV_H */ > diff --git a/lib/memmove.c b/lib/memmove.c > new file mode 100644 > index 0000000..0298b7c > --- /dev/null > +++ b/lib/memmove.c > @@ -0,0 +1,45 @@ > +/* > + * memmove.c: memmove compat implementation. > + * > + * Copyright (c) 2001-2008, NLnet Labs. All rights reserved. > + * > + * See COPYING for the license. > +*/ > + > +#include > +#include > + > +#ifndef HAVE_LIBC > + > +void *memmove(void *dest, const void *src, size_t n) > +{ > + uint8_t* from =3D (uint8_t*) src; > + uint8_t* to =3D (uint8_t*) dest; > + > + if (from =3D=3D to || n =3D=3D 0) > + return dest; > + if (to > from && to-from < (int)n) { > + /* to overlaps with from */ > + /* */ > + /* */ > + /* copy in reverse, to avoid overwriting from */ > + int i; > + for(i=3Dn-1; i>=3D0; i--) > + to[i] =3D from[i]; > + return dest; > + } > + if (from > to && from-to < (int)n) { > + /* to overlaps with from */ > + /* */ > + /* */ > + /* copy forwards, to avoid overwriting from */ > + size_t i; > + for(i=3D0; i + to[i] =3D from[i]; > + return dest; > + } > + memcpy(dest, src, n); > + return dest; > +} > + > +#endif > diff --git a/lib/string.c b/lib/string.c > index 8b24146..c96ca41 100644 > --- a/lib/string.c > +++ b/lib/string.c > @@ -225,4 +225,16 @@ int ffs(int i) > return 0; > } > = > +void *memchr(const void *s, int c, size_t n) > +{ > + if (n !=3D 0) { > + const unsigned char *p =3D s; > + > + do { > + if (*p++ =3D=3D (unsigned char)c) > + return ((void *)(uintptr_t)(p - 1)); > + } while (--n !=3D 0); > + } > + return (NULL); > +} > #endif > -- = > 2.4.2 > = -- = Samuel /* Amuse the user in a SPARC fashion */ if (err) printk( KERN_CRIT " _______________________________ \n" KERN_CRIT " < Your System ate a SPARC! Gah! >\n" KERN_CRIT " ------------------------------- \n" KERN_CRIT " \\ ^__^\n" KERN_CRIT " \\ (xx)\\_______\n" KERN_CRIT " (__)\\ )\\/\\\n" KERN_CRIT " U ||----w |\n" KERN_CRIT " || ||\n"); (From linux/arch/parisc/kernel/traps.c:die_if_kernel()) _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Thu Jul 02 13:46:54 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 02 Jul 2015 13:46:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAepI-0001oW-Kf; Thu, 02 Jul 2015 13:46:52 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZASAi-00028s-FU for Minios-devel@lists.xenproject.org; Thu, 02 Jul 2015 00:16:08 +0000 Received: from [85.158.137.68] by server-16.bemta-3.messagelabs.com id BA/49-01068-7C284955; Thu, 02 Jul 2015 00:16:07 +0000 X-Env-Sender: SRS0=65XX=HK=ens-lyon.org=samuel.thibault@bounce.ens-lyon.o rg X-Msg-Ref: server-5.tower-31.messagelabs.com!1435796166!21855727!1 X-Originating-IP: [140.77.166.138] X-SpamReason: No, hits=0.2 required=7.0 tests=RCVD_ILLEGAL_IP X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 23363 invoked from network); 2 Jul 2015 00:16:07 -0000 Received: from sonata.ens-lyon.org (HELO sonata.ens-lyon.org) (140.77.166.138) by server-5.tower-31.messagelabs.com with DHE-RSA-AES256-SHA encrypted SMTP; 2 Jul 2015 00:16:07 -0000 Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id B2654200C6; Thu, 2 Jul 2015 02:16:06 +0200 (CEST) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lMwSh7mWmCb1; Thu, 2 Jul 2015 02:16:06 +0200 (CEST) Received: from type.youpi.perso.aquilenet.fr (ABordeaux-652-1-107-213.w2-6.abo.wanadoo.fr [2.6.154.213]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 2C2EB200C5; Thu, 2 Jul 2015 02:16:05 +0200 (CEST) Received: from samy by type.youpi.perso.aquilenet.fr with local (Exim 4.86_RC3) (envelope-from ) id 1ZASAf-00073x-5D; Thu, 02 Jul 2015 02:16:05 +0200 Date: Thu, 2 Jul 2015 02:16:05 +0200 From: Samuel Thibault To: Ian Campbell Message-ID: <20150702001605.GW3245@type.home> Mail-Followup-To: Samuel Thibault , Ian Campbell , Anil Madhavapeddy , Thomas Leonard , Dave.Scott@eu.citrix.com, stefano.stabellini@eu.citrix.com, karim.allah.ahmed@gmail.com, Minios-devel@lists.xenproject.org References: <1435240089-23413-1-git-send-email-talex5@gmail.com> <1435240089-23413-2-git-send-email-talex5@gmail.com> <1435247348.32500.98.camel@citrix.com> <1435303373.17598.33.camel@citrix.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="J/dobhs11T7y2rNN" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1435303373.17598.33.camel@citrix.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) X-Mailman-Approved-At: Thu, 02 Jul 2015 13:46:51 +0000 Cc: Thomas Leonard , Dave.Scott@eu.citrix.com, stefano.stabellini@eu.citrix.com, karim.allah.ahmed@gmail.com, Anil Madhavapeddy , Minios-devel@lists.xenproject.org Subject: Re: [Minios-devel] [PATCH ARM v9 1/3] mini-os: fix compiling with debug=n X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org --J/dobhs11T7y2rNN Content-Type: text/plain; charset=iso-8859-1 Content-Length: 2182 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Ian Campbell, le Fri 26 Jun 2015 08:22:53 +0100, a =E9crit : > On Thu, 2015-06-25 at 18:03 +0100, Anil Madhavapeddy wrote: > > On 25 Jun 2015, at 16:49, Ian Campbell wrote: > > > > > > On Thu, 2015-06-25 at 14:48 +0100, Thomas Leonard wrote: > > >> Without -fno-tree-loop-distribute-patterns, gcc -O3 recognises that our > > >> "memset" is doing a memset operation and tries to make it call the > > >> standard "memset", creating a loop. > > > > > > Isn't this what -nostdlib and such like are for=3F -nostdlib only has effect at link time. -ffreestanding would probably have that effect, but we are actually hosted really. string.c could however be built with -ffreestanding, since that part is not "hosted" actually. > > > In any case if we are to go down this route I think we'd be better off > > > applying it only to lib/string.c or even better just to the memset > > > function, if there is a way to do that. > > > > I think -nostdlib is distinct from -fno-builtins. If the issue is > > convincing GCC to not replace the memset with a builtin one, would > > -fno-builtin-memset be more appropriate here=3F Actually we already have -fno-builtin in minios.mk... > Ideally the tweak would be applied with the smallest possible scope, > such that when compiling application code gcc can spot memset > opportunities and call the "builtin" which is actually the one provided > by mini-os. Yes. > If it's more complicated than > __attribute__((no-builtin-memset)) on the function then it's probably > not worth losing too much sleep over though. This does have the proper scope. I don't know whether -ffreestanding does fix the issue at stake. diff --git a/minios.mk b/minios.mk index b0d9f71..9958554 100644 --- a/minios.mk +++ b/minios.mk @@ -12,6 +12,8 @@ DEF_CFLAGS +=3D $(call cc-option,$(CC),-fgnu89-inline) DEF_CFLAGS +=3D -Wstrict-prototypes -Wnested-externs -Wpointer-arith -Winline DEF_CPPFLAGS +=3D -D__XEN_INTERFACE_VERSION__=3D$(XEN_INTERFACE_VERSION) +$(OBJ_DIR)/lib/string.o: CFLAGS +=3D -ffreestanding + DEF_ASFLAGS +=3D -D__ASSEMBLY__ DEF_LDFLAGS +=3D Samuel --J/dobhs11T7y2rNN Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=patch diff --git a/minios.mk b/minios.mk index b0d9f71..9958554 100644 --- a/minios.mk +++ b/minios.mk @@ -12,6 +12,8 @@ DEF_CFLAGS += $(call cc-option,$(CC),-fgnu89-inline) DEF_CFLAGS += -Wstrict-prototypes -Wnested-externs -Wpointer-arith -Winline DEF_CPPFLAGS += -D__XEN_INTERFACE_VERSION__=$(XEN_INTERFACE_VERSION) +$(OBJ_DIR)/lib/string.o: CFLAGS += -ffreestanding + DEF_ASFLAGS += -D__ASSEMBLY__ DEF_LDFLAGS += --J/dobhs11T7y2rNN Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel --J/dobhs11T7y2rNN-- From minios-devel-bounces@lists.xenproject.org Fri Jul 03 09:22:45 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 03 Jul 2015 09:22:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAxBE-0002EG-Hx; Fri, 03 Jul 2015 09:22:44 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAxBD-0002EB-J1 for Minios-devel@lists.xenproject.org; Fri, 03 Jul 2015 09:22:43 +0000 Received: from [85.158.139.211] by server-7.bemta-5.messagelabs.com id 30/4A-23096-26456955; Fri, 03 Jul 2015 09:22:42 +0000 X-Env-Sender: prvs=6194caab5=Ian.Campbell@citrix.com X-Msg-Ref: server-10.tower-206.messagelabs.com!1435915361!13395744!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 19484 invoked from network); 3 Jul 2015 09:22:42 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-10.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 3 Jul 2015 09:22:42 -0000 X-IronPort-AV: E=Sophos;i="5.15,399,1432598400"; d="scan'208";a="277927493" Message-ID: <1435915358.9447.37.camel@citrix.com> From: Ian Campbell To: Samuel Thibault Date: Fri, 3 Jul 2015 10:22:38 +0100 In-Reply-To: <20150702002101.GX3245@type.home> References: <1435240089-23413-1-git-send-email-talex5@gmail.com> <1435240089-23413-4-git-send-email-talex5@gmail.com> <20150702002101.GX3245@type.home> X-Mailer: Evolution 3.12.9-1+b1 MIME-Version: 1.0 X-DLP: MIA2 Cc: Thomas Leonard , Dave.Scott@eu.citrix.com, anil@recoil.org, karim.allah.ahmed@gmail.com, stefano.stabellini@eu.citrix.com, Minios-devel@lists.xenproject.org Subject: Re: [Minios-devel] [PATCH ARM v9 3/3] mini-os: arm: build system X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org T24gVGh1LCAyMDE1LTA3LTAyIGF0IDAyOjIxICswMjAwLCBTYW11ZWwgVGhpYmF1bHQgd3JvdGU6 Cj4gVGhvbWFzIExlb25hcmQsIGxlIFRodSAyNSBKdW4gMjAxNSAxNDo0ODowOSArMDEwMCwgYSDD qWNyaXQgOgo+ID4gQmFzZWQgb24gYW4gaW5pdGlhbCBwYXRjaCBieSBLYXJpbSBSYXNsYW4uCj4g PiAKPiA+IFRoaXMgYWN0aXZhdGVzIHRoZSBBUk0gY29kZSBhZGRlZCBpbiB0aGUgcHJldmlvdXMg cGF0Y2hlcy4gT24gQVJNLAo+ID4gTWluaS1PUyB3aWxsIGJvb3QgYW5kIGRpc3BsYXkgc29tZSBv dXRwdXQgb24gdGhlIGNvbnNvbGUuIFRlc3RlZCB3aXRoOgo+ID4gCj4gPiBtYWtlIFhFTl9UQVJH RVRfQVJDSD1hcm0zMiBDUk9TU19DT01QSUxFPWFybS1saW51eC1nbnVlYWJpaGYtIFwKPiA+IAlD T05GSUdfVEVTVD15IENPTkZJR19TVEFSVF9ORVRXT1JLPW4gQ09ORklHX0JMS0ZST05UPW4gXAo+ ID4gCUNPTkZJR19ORVRGUk9OVD1uIENPTkZJR19GQkZST05UPW4gQ09ORklHX0tCREZST05UPW4g XAo+ID4gCUNPTkZJR19DT05TRlJPTlQ9biBDT05GSUdfWEM9biAtajQKPiA+IAo+ID4gVGhlIG1l bW1vdmUgaW1wbGVtZW50YXRpb24gaXMgZnJvbSBGcmVlQlNEJ3MKPiA+IGNvbnRyaWIvbGRucy9j b21wYXQvbWVtbW92ZS5jIChyMjQ2ODI3KS4KPiAKPiBUaGVuIGl0IHNob3VsZCBoYXZlIGl0cyBv d24gY29weXJpZ2h0IGhlYWRlciBjb3BpZWQgZnJvbSB0aGVyZSwgbm90IGp1c3QKPiByZWZlciB0 byBDT1BZSU5HLiAgQXBhcnQgZnJvbSB0aGF0IGl0IGxvb2tzIGZpbmUuCgpJIHJlbWVtYmVyIGRp c2N1c3NpbmcgYmVmb3JlIGJ1dCBub3QgY29uY2x1c2lvbjogSXMgdGhlIDNjIEJTRCBsaWNlbnNl CnVzZWQgaGVyZSBPSz8gU28gSSBkb24ndCBmb3JnZXQgdGhlIGFuc3dlciBhZ2FpbjogVGhlIDNy ZCBjbGF1c2UgaXMgdGhlCiJOZWl0aGVyIHRoZSBuYW1lIG9mICROQU1FIG5vciB0aGUgbmFtZXMg b2YgaXRzIiBvbmUsIHdoaWNoIGFscmVhZHkKYXBwZWFycyBpbiBvbmUgb3IgdHdvIGZpbGVzLCBz byBvdGhlciB0aGFuIGEgbmV3ICROQU1FIHRoZXJlIGlzIG5vCmRpZmZlcmVuY2UgdG8gdGhlIGxp Y2Vuc2luZy4gSWYgeW91IGNvdWxkIGluY2x1ZGUgc29tZXRoaW5nIGxpZSB0aGF0CnNuaXBwZXQg bmV4dCB0aW1lIGVpdGhlciBpbiB0aGUgbWFpbiBjb21taXQgbWVzc2FnZSBvciBpbiBhbgphaWRl LW1lbW9pcmUgYWZ0ZXIgdGhlIGZpcnN0ICItLS0iIEknZCBhcHByZWNpYXRlIGl0IHNvIEkgZG9u J3QgaGF2ZSB0bwplbmdhZ2UgbXkgYnJhaW4gbmV4dCB0aW1lLgoKTkI6IFRoZSAiM3JkIiBjbGF1 c2UgaXMgYWN0dWFsbHkgbnVtYmVyZWQgIjQuIiBpbiB0aG9zZSBleGlzdGluZwppbnN0YW5jZXMs IGJlY2F1c2UgdGhlIGFyZSBjb2RlIHdoaWNoIHdhcyByZWxpY2Vuc2VkIGZyb20gdGhlIG9sZCA0 CmNsYXVzZSBkcm9wcGluZyB3aGF0IGlzIGNsYXVzZSAzIGluIHRoYXQgY29udGV4dC4gSW4gY2Fz ZSBhbnlvbmUgcmVwZWF0cwpteSBncmVwIGFuZCB0aGluZ3Mgd2UndmUgc29tZSA0IGNsYXVzZSBC U0QgaW4gdGhlcmUuCgpTcGVha2luZyBvZiB3aGljaDogV291bGQgc29tZW9uZSBtaW5kIGRvaW5n IGEgc3dlZXAgYW5kIHVwZGF0aW5nIENPUFlJTkcKdG8gYWN0dWFsbHkgcmVmbGVjdCBhbGwgdGhl IGxpY2Vuc2VzPyBDdXJyZW50bHkgaXQganVzdCBoYXMgYSAyY0JTRCBmcm9tCkNpdHJpeCBhbmQg YSB3YXJuaW5nIGFib3V0IHRoZSBHUEwnZCBjb21wb25lbnRzLi4uCgpJYW4uCgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTWluaW9zLWRldmVsIG1haWxp bmcgbGlzdApNaW5pb3MtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cDovL2xpc3RzLnhl bnByb2plY3Qub3JnL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9taW5pb3MtZGV2ZWw= From minios-devel-bounces@lists.xenproject.org Fri Jul 03 09:22:45 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 03 Jul 2015 09:22:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAxBE-0002EG-Hx; Fri, 03 Jul 2015 09:22:44 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAxBD-0002EB-J1 for Minios-devel@lists.xenproject.org; Fri, 03 Jul 2015 09:22:43 +0000 Received: from [85.158.139.211] by server-7.bemta-5.messagelabs.com id 30/4A-23096-26456955; Fri, 03 Jul 2015 09:22:42 +0000 X-Env-Sender: prvs=6194caab5=Ian.Campbell@citrix.com X-Msg-Ref: server-10.tower-206.messagelabs.com!1435915361!13395744!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 19484 invoked from network); 3 Jul 2015 09:22:42 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-10.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 3 Jul 2015 09:22:42 -0000 X-IronPort-AV: E=Sophos;i="5.15,399,1432598400"; d="scan'208";a="277927493" Message-ID: <1435915358.9447.37.camel@citrix.com> From: Ian Campbell To: Samuel Thibault Date: Fri, 3 Jul 2015 10:22:38 +0100 In-Reply-To: <20150702002101.GX3245@type.home> References: <1435240089-23413-1-git-send-email-talex5@gmail.com> <1435240089-23413-4-git-send-email-talex5@gmail.com> <20150702002101.GX3245@type.home> X-Mailer: Evolution 3.12.9-1+b1 MIME-Version: 1.0 X-DLP: MIA2 Cc: Thomas Leonard , Dave.Scott@eu.citrix.com, anil@recoil.org, karim.allah.ahmed@gmail.com, stefano.stabellini@eu.citrix.com, Minios-devel@lists.xenproject.org Subject: Re: [Minios-devel] [PATCH ARM v9 3/3] mini-os: arm: build system X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org T24gVGh1LCAyMDE1LTA3LTAyIGF0IDAyOjIxICswMjAwLCBTYW11ZWwgVGhpYmF1bHQgd3JvdGU6 Cj4gVGhvbWFzIExlb25hcmQsIGxlIFRodSAyNSBKdW4gMjAxNSAxNDo0ODowOSArMDEwMCwgYSDD qWNyaXQgOgo+ID4gQmFzZWQgb24gYW4gaW5pdGlhbCBwYXRjaCBieSBLYXJpbSBSYXNsYW4uCj4g PiAKPiA+IFRoaXMgYWN0aXZhdGVzIHRoZSBBUk0gY29kZSBhZGRlZCBpbiB0aGUgcHJldmlvdXMg cGF0Y2hlcy4gT24gQVJNLAo+ID4gTWluaS1PUyB3aWxsIGJvb3QgYW5kIGRpc3BsYXkgc29tZSBv dXRwdXQgb24gdGhlIGNvbnNvbGUuIFRlc3RlZCB3aXRoOgo+ID4gCj4gPiBtYWtlIFhFTl9UQVJH RVRfQVJDSD1hcm0zMiBDUk9TU19DT01QSUxFPWFybS1saW51eC1nbnVlYWJpaGYtIFwKPiA+IAlD T05GSUdfVEVTVD15IENPTkZJR19TVEFSVF9ORVRXT1JLPW4gQ09ORklHX0JMS0ZST05UPW4gXAo+ ID4gCUNPTkZJR19ORVRGUk9OVD1uIENPTkZJR19GQkZST05UPW4gQ09ORklHX0tCREZST05UPW4g XAo+ID4gCUNPTkZJR19DT05TRlJPTlQ9biBDT05GSUdfWEM9biAtajQKPiA+IAo+ID4gVGhlIG1l bW1vdmUgaW1wbGVtZW50YXRpb24gaXMgZnJvbSBGcmVlQlNEJ3MKPiA+IGNvbnRyaWIvbGRucy9j b21wYXQvbWVtbW92ZS5jIChyMjQ2ODI3KS4KPiAKPiBUaGVuIGl0IHNob3VsZCBoYXZlIGl0cyBv d24gY29weXJpZ2h0IGhlYWRlciBjb3BpZWQgZnJvbSB0aGVyZSwgbm90IGp1c3QKPiByZWZlciB0 byBDT1BZSU5HLiAgQXBhcnQgZnJvbSB0aGF0IGl0IGxvb2tzIGZpbmUuCgpJIHJlbWVtYmVyIGRp c2N1c3NpbmcgYmVmb3JlIGJ1dCBub3QgY29uY2x1c2lvbjogSXMgdGhlIDNjIEJTRCBsaWNlbnNl CnVzZWQgaGVyZSBPSz8gU28gSSBkb24ndCBmb3JnZXQgdGhlIGFuc3dlciBhZ2FpbjogVGhlIDNy ZCBjbGF1c2UgaXMgdGhlCiJOZWl0aGVyIHRoZSBuYW1lIG9mICROQU1FIG5vciB0aGUgbmFtZXMg b2YgaXRzIiBvbmUsIHdoaWNoIGFscmVhZHkKYXBwZWFycyBpbiBvbmUgb3IgdHdvIGZpbGVzLCBz byBvdGhlciB0aGFuIGEgbmV3ICROQU1FIHRoZXJlIGlzIG5vCmRpZmZlcmVuY2UgdG8gdGhlIGxp Y2Vuc2luZy4gSWYgeW91IGNvdWxkIGluY2x1ZGUgc29tZXRoaW5nIGxpZSB0aGF0CnNuaXBwZXQg bmV4dCB0aW1lIGVpdGhlciBpbiB0aGUgbWFpbiBjb21taXQgbWVzc2FnZSBvciBpbiBhbgphaWRl LW1lbW9pcmUgYWZ0ZXIgdGhlIGZpcnN0ICItLS0iIEknZCBhcHByZWNpYXRlIGl0IHNvIEkgZG9u J3QgaGF2ZSB0bwplbmdhZ2UgbXkgYnJhaW4gbmV4dCB0aW1lLgoKTkI6IFRoZSAiM3JkIiBjbGF1 c2UgaXMgYWN0dWFsbHkgbnVtYmVyZWQgIjQuIiBpbiB0aG9zZSBleGlzdGluZwppbnN0YW5jZXMs IGJlY2F1c2UgdGhlIGFyZSBjb2RlIHdoaWNoIHdhcyByZWxpY2Vuc2VkIGZyb20gdGhlIG9sZCA0 CmNsYXVzZSBkcm9wcGluZyB3aGF0IGlzIGNsYXVzZSAzIGluIHRoYXQgY29udGV4dC4gSW4gY2Fz ZSBhbnlvbmUgcmVwZWF0cwpteSBncmVwIGFuZCB0aGluZ3Mgd2UndmUgc29tZSA0IGNsYXVzZSBC U0QgaW4gdGhlcmUuCgpTcGVha2luZyBvZiB3aGljaDogV291bGQgc29tZW9uZSBtaW5kIGRvaW5n IGEgc3dlZXAgYW5kIHVwZGF0aW5nIENPUFlJTkcKdG8gYWN0dWFsbHkgcmVmbGVjdCBhbGwgdGhl IGxpY2Vuc2VzPyBDdXJyZW50bHkgaXQganVzdCBoYXMgYSAyY0JTRCBmcm9tCkNpdHJpeCBhbmQg YSB3YXJuaW5nIGFib3V0IHRoZSBHUEwnZCBjb21wb25lbnRzLi4uCgpJYW4uCgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTWluaW9zLWRldmVsIG1haWxp bmcgbGlzdApNaW5pb3MtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cDovL2xpc3RzLnhl bnByb2plY3Qub3JnL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9taW5pb3MtZGV2ZWw= From minios-devel-bounces@lists.xenproject.org Fri Jul 03 09:29:44 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 03 Jul 2015 09:29:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAxHz-0002Vh-1t; Fri, 03 Jul 2015 09:29:43 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAxHx-0002Vc-R1 for Minios-devel@lists.xenproject.org; Fri, 03 Jul 2015 09:29:41 +0000 Received: from [85.158.139.211] by server-3.bemta-5.messagelabs.com id F6/08-05081-50656955; Fri, 03 Jul 2015 09:29:41 +0000 X-Env-Sender: prvs=6194caab5=Ian.Campbell@citrix.com X-Msg-Ref: server-15.tower-206.messagelabs.com!1435915779!15338719!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 5764 invoked from network); 3 Jul 2015 09:29:40 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-15.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 3 Jul 2015 09:29:40 -0000 X-IronPort-AV: E=Sophos;i="5.15,399,1432598400"; d="scan'208";a="277928580" Message-ID: <1435915776.9447.40.camel@citrix.com> From: Ian Campbell To: Samuel Thibault Date: Fri, 3 Jul 2015 10:29:36 +0100 In-Reply-To: <20150701092741.GG3147@type.bordeaux.inria.fr> References: <1435742690-4755-1-git-send-email-talex5@gmail.com> <20150701092741.GG3147@type.bordeaux.inria.fr> X-Mailer: Evolution 3.12.9-1+b1 MIME-Version: 1.0 X-DLP: MIA2 Cc: Minios-devel@lists.xenproject.org, Thomas Leonard , stefano.stabellini@eu.citrix.com Subject: Re: [Minios-devel] [PATCH] Accept %z in printf formats X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org T24gV2VkLCAyMDE1LTA3LTAxIGF0IDExOjI3ICswMjAwLCBTYW11ZWwgVGhpYmF1bHQgd3JvdGU6 Cj4gVGhvbWFzIExlb25hcmQsIGxlIFdlZCAwMSBKdWwgMjAxNSAxMDoyNDo1MCArMDEwMCwgYSDD qWNyaXQgOgo+ID4gQmVmb3JlLCB3ZSBvbmx5IHN1cHBvcnRlZCAlWiAodXBwZXItY2FzZSkuIEl0 IHNlZW1zIHRoYXQgdGhlIGxvd2VyLWNhc2UKPiA+IHZlcnNpb24gaXMgc3RhbmRhcmQsIGFuZCB0 aGlzIG1hdGNoZXMgdGhlIGJlaGF2aW91ciBvZiBYZW4ncyB2c3ByaW50Zi5jLgo+ID4gCj4gPiBT aWduZWQtb2ZmLWJ5OiBUaG9tYXMgTGVvbmFyZCA8dGFsZXg1QGdtYWlsLmNvbT4KPiAKPiBBY2tl ZC1ieTogU2FtdWVsIFRoaWJhdWx0IDxzYW11ZWwudGhpYmF1bHRAZW5zLWx5b24ub3JnPgoKQXBw bGllZCwgdGhhbmtzLgoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpNaW5pb3MtZGV2ZWwgbWFpbGluZyBsaXN0Ck1pbmlvcy1kZXZlbEBsaXN0cy54ZW5w cm9qZWN0Lm9yZwpodHRwOi8vbGlzdHMueGVucHJvamVjdC5vcmcvY2dpLWJpbi9tYWlsbWFuL2xp c3RpbmZvL21pbmlvcy1kZXZlbA== From minios-devel-bounces@lists.xenproject.org Fri Jul 03 09:29:44 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 03 Jul 2015 09:29:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAxHz-0002Vh-1t; Fri, 03 Jul 2015 09:29:43 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAxHx-0002Vc-R1 for Minios-devel@lists.xenproject.org; Fri, 03 Jul 2015 09:29:41 +0000 Received: from [85.158.139.211] by server-3.bemta-5.messagelabs.com id F6/08-05081-50656955; Fri, 03 Jul 2015 09:29:41 +0000 X-Env-Sender: prvs=6194caab5=Ian.Campbell@citrix.com X-Msg-Ref: server-15.tower-206.messagelabs.com!1435915779!15338719!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 5764 invoked from network); 3 Jul 2015 09:29:40 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-15.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 3 Jul 2015 09:29:40 -0000 X-IronPort-AV: E=Sophos;i="5.15,399,1432598400"; d="scan'208";a="277928580" Message-ID: <1435915776.9447.40.camel@citrix.com> From: Ian Campbell To: Samuel Thibault Date: Fri, 3 Jul 2015 10:29:36 +0100 In-Reply-To: <20150701092741.GG3147@type.bordeaux.inria.fr> References: <1435742690-4755-1-git-send-email-talex5@gmail.com> <20150701092741.GG3147@type.bordeaux.inria.fr> X-Mailer: Evolution 3.12.9-1+b1 MIME-Version: 1.0 X-DLP: MIA2 Cc: Minios-devel@lists.xenproject.org, Thomas Leonard , stefano.stabellini@eu.citrix.com Subject: Re: [Minios-devel] [PATCH] Accept %z in printf formats X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org T24gV2VkLCAyMDE1LTA3LTAxIGF0IDExOjI3ICswMjAwLCBTYW11ZWwgVGhpYmF1bHQgd3JvdGU6 Cj4gVGhvbWFzIExlb25hcmQsIGxlIFdlZCAwMSBKdWwgMjAxNSAxMDoyNDo1MCArMDEwMCwgYSDD qWNyaXQgOgo+ID4gQmVmb3JlLCB3ZSBvbmx5IHN1cHBvcnRlZCAlWiAodXBwZXItY2FzZSkuIEl0 IHNlZW1zIHRoYXQgdGhlIGxvd2VyLWNhc2UKPiA+IHZlcnNpb24gaXMgc3RhbmRhcmQsIGFuZCB0 aGlzIG1hdGNoZXMgdGhlIGJlaGF2aW91ciBvZiBYZW4ncyB2c3ByaW50Zi5jLgo+ID4gCj4gPiBT aWduZWQtb2ZmLWJ5OiBUaG9tYXMgTGVvbmFyZCA8dGFsZXg1QGdtYWlsLmNvbT4KPiAKPiBBY2tl ZC1ieTogU2FtdWVsIFRoaWJhdWx0IDxzYW11ZWwudGhpYmF1bHRAZW5zLWx5b24ub3JnPgoKQXBw bGllZCwgdGhhbmtzLgoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpNaW5pb3MtZGV2ZWwgbWFpbGluZyBsaXN0Ck1pbmlvcy1kZXZlbEBsaXN0cy54ZW5w cm9qZWN0Lm9yZwpodHRwOi8vbGlzdHMueGVucHJvamVjdC5vcmcvY2dpLWJpbi9tYWlsbWFuL2xp c3RpbmZvL21pbmlvcy1kZXZlbA== From minios-devel-bounces@lists.xenproject.org Fri Jul 03 09:45:48 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 03 Jul 2015 09:45:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAxXY-0002sz-2v; Fri, 03 Jul 2015 09:45:48 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAxXW-0002sc-G5 for minios-devel@lists.xenproject.org; Fri, 03 Jul 2015 09:45:46 +0000 Received: from [85.158.139.211] by server-12.bemta-5.messagelabs.com id 4B/FF-25925-9C956955; Fri, 03 Jul 2015 09:45:45 +0000 X-Env-Sender: prvs=6194caab5=Ian.Campbell@citrix.com X-Msg-Ref: server-13.tower-206.messagelabs.com!1435916744!18719199!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 2155 invoked from network); 3 Jul 2015 09:45:45 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-13.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 3 Jul 2015 09:45:45 -0000 X-IronPort-AV: E=Sophos;i="5.15,399,1432598400"; d="scan'208";a="277931338" Message-ID: <1435915792.9447.41.camel@citrix.com> From: Ian Campbell To: Samuel Thibault Date: Fri, 3 Jul 2015 10:29:52 +0100 In-Reply-To: <20150702002143.GY3245@type.home> References: <1435316320-1811-1-git-send-email-ian.campbell@citrix.com> <20150702002143.GY3245@type.home> X-Mailer: Evolution 3.12.9-1+b1 MIME-Version: 1.0 X-DLP: MIA1 Cc: minios-devel@lists.xenproject.org, Daniel De Graaf , Thomas Leonard , xen-devel@lists.xen.org Subject: Re: [Minios-devel] [Xen-devel] [PATCH mini-os] Correct printf formatting for tpm_tis message. X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org T24gVGh1LCAyMDE1LTA3LTAyIGF0IDAyOjIxICswMjAwLCBTYW11ZWwgVGhpYmF1bHQgd3JvdGU6 Cj4gSWFuIENhbXBiZWxsLCBsZSBGcmkgMjYgSnVuIDIwMTUgMTE6NTg6NDAgKzAxMDAsIGEgw6lj cml0IDoKPiA+IFRoaXMgaXMgdW5kZXIgI2lmZGVmIEhBVkVfTElCQyBzbyB3ZW50IHVubm90aWNl ZCBiZWZvcmUuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IElhbiBDYW1wYmVsbCA8aWFuLmNhbXBi ZWxsQGNpdHJpeC5jb20+Cj4gCj4gQWNrZWQtYnk6IFNhbXVlbCBUaGliYXVsdCA8c2FtdWVsLnRo aWJhdWx0QGVucy1seW9uLm9yZz4KCkFwcGxpZWQsIHRoYW5rcy4KCgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTWluaW9zLWRldmVsIG1haWxpbmcgbGlz dApNaW5pb3MtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cDovL2xpc3RzLnhlbnByb2pl Y3Qub3JnL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9taW5pb3MtZGV2ZWw= From minios-devel-bounces@lists.xenproject.org Fri Jul 03 09:45:48 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 03 Jul 2015 09:45:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAxXY-0002sz-2v; Fri, 03 Jul 2015 09:45:48 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAxXW-0002sc-G5 for minios-devel@lists.xenproject.org; Fri, 03 Jul 2015 09:45:46 +0000 Received: from [85.158.139.211] by server-12.bemta-5.messagelabs.com id 4B/FF-25925-9C956955; Fri, 03 Jul 2015 09:45:45 +0000 X-Env-Sender: prvs=6194caab5=Ian.Campbell@citrix.com X-Msg-Ref: server-13.tower-206.messagelabs.com!1435916744!18719199!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 2155 invoked from network); 3 Jul 2015 09:45:45 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-13.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 3 Jul 2015 09:45:45 -0000 X-IronPort-AV: E=Sophos;i="5.15,399,1432598400"; d="scan'208";a="277931338" Message-ID: <1435915792.9447.41.camel@citrix.com> From: Ian Campbell To: Samuel Thibault Date: Fri, 3 Jul 2015 10:29:52 +0100 In-Reply-To: <20150702002143.GY3245@type.home> References: <1435316320-1811-1-git-send-email-ian.campbell@citrix.com> <20150702002143.GY3245@type.home> X-Mailer: Evolution 3.12.9-1+b1 MIME-Version: 1.0 X-DLP: MIA1 Cc: minios-devel@lists.xenproject.org, Daniel De Graaf , Thomas Leonard , xen-devel@lists.xen.org Subject: Re: [Minios-devel] [Xen-devel] [PATCH mini-os] Correct printf formatting for tpm_tis message. X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org T24gVGh1LCAyMDE1LTA3LTAyIGF0IDAyOjIxICswMjAwLCBTYW11ZWwgVGhpYmF1bHQgd3JvdGU6 Cj4gSWFuIENhbXBiZWxsLCBsZSBGcmkgMjYgSnVuIDIwMTUgMTE6NTg6NDAgKzAxMDAsIGEgw6lj cml0IDoKPiA+IFRoaXMgaXMgdW5kZXIgI2lmZGVmIEhBVkVfTElCQyBzbyB3ZW50IHVubm90aWNl ZCBiZWZvcmUuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IElhbiBDYW1wYmVsbCA8aWFuLmNhbXBi ZWxsQGNpdHJpeC5jb20+Cj4gCj4gQWNrZWQtYnk6IFNhbXVlbCBUaGliYXVsdCA8c2FtdWVsLnRo aWJhdWx0QGVucy1seW9uLm9yZz4KCkFwcGxpZWQsIHRoYW5rcy4KCgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTWluaW9zLWRldmVsIG1haWxpbmcgbGlz dApNaW5pb3MtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cDovL2xpc3RzLnhlbnByb2pl Y3Qub3JnL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9taW5pb3MtZGV2ZWw= From minios-devel-bounces@lists.xenproject.org Fri Jul 03 10:37:06 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 03 Jul 2015 10:37:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAyLB-00073T-TZ; Fri, 03 Jul 2015 10:37:05 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAyLB-000736-1Q for minios-devel@lists.xenproject.org; Fri, 03 Jul 2015 10:37:05 +0000 Received: from [85.158.137.68] by server-3.bemta-3.messagelabs.com id E5/B0-03035-0D566955; Fri, 03 Jul 2015 10:37:04 +0000 X-Env-Sender: prvs=6194caab5=Ian.Campbell@citrix.com X-Msg-Ref: server-14.tower-31.messagelabs.com!1435919822!19921158!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 24897 invoked from network); 3 Jul 2015 10:37:03 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-14.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 3 Jul 2015 10:37:03 -0000 X-IronPort-AV: E=Sophos;i="5.15,399,1432598400"; d="scan'208";a="277940342" Message-ID: <1435919799.9447.75.camel@citrix.com> From: Ian Campbell To: Samuel Thibault Date: Fri, 3 Jul 2015 11:36:39 +0100 In-Reply-To: <20150702002335.GZ3245@type.home> References: <1435316320-1811-1-git-send-email-ian.campbell@citrix.com> <1435316769-5784-1-git-send-email-ian.campbell@citrix.com> <20150702002335.GZ3245@type.home> X-Mailer: Evolution 3.12.9-1+b1 MIME-Version: 1.0 X-DLP: MIA1 Cc: minios-devel@lists.xenproject.org, Daniel De Graaf , xen-devel@lists.xen.org, Thomas Leonard , Stefano Stabellini Subject: Re: [Minios-devel] [Xen-devel] [PATCH xen] stubdom: vtpmmgr: Correctly format size_t with %z when printing. X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org T24gVGh1LCAyMDE1LTA3LTAyIGF0IDAyOjIzICswMjAwLCBTYW11ZWwgVGhpYmF1bHQgd3JvdGU6 Cj4gSWFuIENhbXBiZWxsLCBsZSBGcmkgMjYgSnVuIDIwMTUgMTI6MDY6MDkgKzAxMDAsIGEgw6lj cml0IDoKPiA+IEFsc28gY29udGFpbnMgYSBmaXggZnJvbSBUaG9tYXMgTGVvbmFyZCAodG8gdXNl ICV1IGZvciAiNCArIDMyIiwgbm90Cj4gPiAlbHUpIHByZXZpb3VzbHkgcG9zdGVkIGFzIHBhcnQg b2YgIm1pbmktb3M6IGVuYWJsZSBjb21waWxlciBjaGVjayBmb3IKPiA+IHByaW50ayBmb3JtYXQg dHlwZXMiIGJ1dCB3aXRoIG1pbmktb3Mgbm93IGhhdmluZyBiZWVuIHNwbGl0IGEgc2VwYXJhdGUK PiA+IHJlcG8gbW9zdCBvZiB0aGF0IGNoYW5nZSBoYXMgYmVlbiBhcHBsaWVkIHRoZXJlLgo+ID4g Cj4gPiBUaGlzIGZpeGVzIHRoZSAzMi1iaXQgYnVpbGQgd2l0aCB1cGRhdGVkIG1pbmktb3Mgd2hp Y2ggaW5jbHVkZXMgZm9ybWF0Cj4gPiBzdHJpbmcgY2hlY2tpbmcuCj4gPiAKPiA+IFNpZ25lZC1v ZmYtYnk6IFRob21hcyBMZW9uYXJkIDx0YWxleDVAZ21haWwuY29tPgo+ID4gU2lnbmVkLW9mZi1i eTogSWFuIENhbXBiZWxsIDxpYW4uY2FtcGJlbGxAY2l0cml4LmNvbT4KPiA+IENjOiBEYW5pZWwg RGUgR3JhYWYgPGRnZGVncmFAdHljaG8ubnNhLmdvdj4KPiA+IENjOiBTdGVmYW5vIFN0YWJlbGxp bmkgPHN0ZWZhbm8uc3RhYmVsbGluaUBldS5jaXRyaXguY29tPgo+IAo+IEFja2VkLUJ5OiBTYW11 ZWwgVGhpYmF1bHQgPHNhbXVlbC50aGliYXVsdEBlbnMtbHlvbi5vcmc+Cj4gCj4gKGFmdGVyIHRo ZSAneicgbW9kaWZpZXIgc3VwcG9ydCBpcyBjb21taXRlZCwgb2YgY291cnNlKQoKVGhhdCBoYXBw ZW5lZCwgc28gSSB1cGRhdGVkIHRoZSBDb25maWcubWsgcmVmIGFuZCBjb21taXR0ZWQsIHRoYW5r cy4KCklhbi4KCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KTWluaW9zLWRldmVsIG1haWxpbmcgbGlzdApNaW5pb3MtZGV2ZWxAbGlzdHMueGVucHJvamVj dC5vcmcKaHR0cDovL2xpc3RzLnhlbnByb2plY3Qub3JnL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5m by9taW5pb3MtZGV2ZWw= From minios-devel-bounces@lists.xenproject.org Fri Jul 03 10:37:06 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 03 Jul 2015 10:37:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAyLB-00073T-TZ; Fri, 03 Jul 2015 10:37:05 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAyLB-000736-1Q for minios-devel@lists.xenproject.org; Fri, 03 Jul 2015 10:37:05 +0000 Received: from [85.158.137.68] by server-3.bemta-3.messagelabs.com id E5/B0-03035-0D566955; Fri, 03 Jul 2015 10:37:04 +0000 X-Env-Sender: prvs=6194caab5=Ian.Campbell@citrix.com X-Msg-Ref: server-14.tower-31.messagelabs.com!1435919822!19921158!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 24897 invoked from network); 3 Jul 2015 10:37:03 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-14.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 3 Jul 2015 10:37:03 -0000 X-IronPort-AV: E=Sophos;i="5.15,399,1432598400"; d="scan'208";a="277940342" Message-ID: <1435919799.9447.75.camel@citrix.com> From: Ian Campbell To: Samuel Thibault Date: Fri, 3 Jul 2015 11:36:39 +0100 In-Reply-To: <20150702002335.GZ3245@type.home> References: <1435316320-1811-1-git-send-email-ian.campbell@citrix.com> <1435316769-5784-1-git-send-email-ian.campbell@citrix.com> <20150702002335.GZ3245@type.home> X-Mailer: Evolution 3.12.9-1+b1 MIME-Version: 1.0 X-DLP: MIA1 Cc: minios-devel@lists.xenproject.org, Daniel De Graaf , xen-devel@lists.xen.org, Thomas Leonard , Stefano Stabellini Subject: Re: [Minios-devel] [Xen-devel] [PATCH xen] stubdom: vtpmmgr: Correctly format size_t with %z when printing. X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org T24gVGh1LCAyMDE1LTA3LTAyIGF0IDAyOjIzICswMjAwLCBTYW11ZWwgVGhpYmF1bHQgd3JvdGU6 Cj4gSWFuIENhbXBiZWxsLCBsZSBGcmkgMjYgSnVuIDIwMTUgMTI6MDY6MDkgKzAxMDAsIGEgw6lj cml0IDoKPiA+IEFsc28gY29udGFpbnMgYSBmaXggZnJvbSBUaG9tYXMgTGVvbmFyZCAodG8gdXNl ICV1IGZvciAiNCArIDMyIiwgbm90Cj4gPiAlbHUpIHByZXZpb3VzbHkgcG9zdGVkIGFzIHBhcnQg b2YgIm1pbmktb3M6IGVuYWJsZSBjb21waWxlciBjaGVjayBmb3IKPiA+IHByaW50ayBmb3JtYXQg dHlwZXMiIGJ1dCB3aXRoIG1pbmktb3Mgbm93IGhhdmluZyBiZWVuIHNwbGl0IGEgc2VwYXJhdGUK PiA+IHJlcG8gbW9zdCBvZiB0aGF0IGNoYW5nZSBoYXMgYmVlbiBhcHBsaWVkIHRoZXJlLgo+ID4g Cj4gPiBUaGlzIGZpeGVzIHRoZSAzMi1iaXQgYnVpbGQgd2l0aCB1cGRhdGVkIG1pbmktb3Mgd2hp Y2ggaW5jbHVkZXMgZm9ybWF0Cj4gPiBzdHJpbmcgY2hlY2tpbmcuCj4gPiAKPiA+IFNpZ25lZC1v ZmYtYnk6IFRob21hcyBMZW9uYXJkIDx0YWxleDVAZ21haWwuY29tPgo+ID4gU2lnbmVkLW9mZi1i eTogSWFuIENhbXBiZWxsIDxpYW4uY2FtcGJlbGxAY2l0cml4LmNvbT4KPiA+IENjOiBEYW5pZWwg RGUgR3JhYWYgPGRnZGVncmFAdHljaG8ubnNhLmdvdj4KPiA+IENjOiBTdGVmYW5vIFN0YWJlbGxp bmkgPHN0ZWZhbm8uc3RhYmVsbGluaUBldS5jaXRyaXguY29tPgo+IAo+IEFja2VkLUJ5OiBTYW11 ZWwgVGhpYmF1bHQgPHNhbXVlbC50aGliYXVsdEBlbnMtbHlvbi5vcmc+Cj4gCj4gKGFmdGVyIHRo ZSAneicgbW9kaWZpZXIgc3VwcG9ydCBpcyBjb21taXRlZCwgb2YgY291cnNlKQoKVGhhdCBoYXBw ZW5lZCwgc28gSSB1cGRhdGVkIHRoZSBDb25maWcubWsgcmVmIGFuZCBjb21taXR0ZWQsIHRoYW5r cy4KCklhbi4KCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KTWluaW9zLWRldmVsIG1haWxpbmcgbGlzdApNaW5pb3MtZGV2ZWxAbGlzdHMueGVucHJvamVj dC5vcmcKaHR0cDovL2xpc3RzLnhlbnByb2plY3Qub3JnL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5m by9taW5pb3MtZGV2ZWw= From minios-devel-bounces@lists.xenproject.org Fri Jul 03 14:31:50 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 03 Jul 2015 14:31:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZB20L-0002Ti-Jc; Fri, 03 Jul 2015 14:31:49 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZB20K-0002Tc-Pw for Minios-devel@lists.xenproject.org; Fri, 03 Jul 2015 14:31:48 +0000 Received: from [85.158.139.211] by server-10.bemta-5.messagelabs.com id EA/0B-11201-4DC96955; Fri, 03 Jul 2015 14:31:48 +0000 X-Env-Sender: prvs=6194caab5=Ian.Campbell@citrix.com X-Msg-Ref: server-16.tower-206.messagelabs.com!1435933906!15900681!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 13166 invoked from network); 3 Jul 2015 14:31:47 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-16.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 3 Jul 2015 14:31:47 -0000 X-IronPort-AV: E=Sophos;i="5.15,400,1432598400"; d="scan'208";a="280996755" Message-ID: <1435933904.9447.135.camel@citrix.com> From: Ian Campbell To: Thomas Leonard Date: Fri, 3 Jul 2015 15:31:44 +0100 In-Reply-To: <1435240089-23413-3-git-send-email-talex5@gmail.com> References: <1435240089-23413-1-git-send-email-talex5@gmail.com> <1435240089-23413-3-git-send-email-talex5@gmail.com> X-Mailer: Evolution 3.12.9-1+b1 MIME-Version: 1.0 X-DLP: MIA1 Cc: Dave.Scott@eu.citrix.com, anil@recoil.org, karim.allah.ahmed@gmail.com, stefano.stabellini@eu.citrix.com, Minios-devel@lists.xenproject.org, samuel.thibault@ens-lyon.org Subject: Re: [Minios-devel] [PATCH ARM v9 2/3] mini-os: arm: interrupt controller X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Thu, 2015-06-25 at 14:48 +0100, Thomas Leonard wrote: This patch looks good to me, but this: [...] > +//FIXME Get event_irq from dt > +#define EVENTS_IRQ 31 > +#define VIRTUALTIMER_IRQ 27 I think deserves a prominent comment in at least the commit message, if not somewhere like the README, since it means that binaries built with this mini-os are not guaranteed to be portable to other versions of Xen on ARM. You know this but other potential users of this code might take umbrage when they find this out the hard way. Ian. _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Fri Jul 03 14:31:50 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 03 Jul 2015 14:31:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZB20L-0002Ti-Jc; Fri, 03 Jul 2015 14:31:49 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZB20K-0002Tc-Pw for Minios-devel@lists.xenproject.org; Fri, 03 Jul 2015 14:31:48 +0000 Received: from [85.158.139.211] by server-10.bemta-5.messagelabs.com id EA/0B-11201-4DC96955; Fri, 03 Jul 2015 14:31:48 +0000 X-Env-Sender: prvs=6194caab5=Ian.Campbell@citrix.com X-Msg-Ref: server-16.tower-206.messagelabs.com!1435933906!15900681!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 13166 invoked from network); 3 Jul 2015 14:31:47 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-16.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 3 Jul 2015 14:31:47 -0000 X-IronPort-AV: E=Sophos;i="5.15,400,1432598400"; d="scan'208";a="280996755" Message-ID: <1435933904.9447.135.camel@citrix.com> From: Ian Campbell To: Thomas Leonard Date: Fri, 3 Jul 2015 15:31:44 +0100 In-Reply-To: <1435240089-23413-3-git-send-email-talex5@gmail.com> References: <1435240089-23413-1-git-send-email-talex5@gmail.com> <1435240089-23413-3-git-send-email-talex5@gmail.com> X-Mailer: Evolution 3.12.9-1+b1 MIME-Version: 1.0 X-DLP: MIA1 Cc: Dave.Scott@eu.citrix.com, anil@recoil.org, karim.allah.ahmed@gmail.com, stefano.stabellini@eu.citrix.com, Minios-devel@lists.xenproject.org, samuel.thibault@ens-lyon.org Subject: Re: [Minios-devel] [PATCH ARM v9 2/3] mini-os: arm: interrupt controller X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Thu, 2015-06-25 at 14:48 +0100, Thomas Leonard wrote: This patch looks good to me, but this: [...] > +//FIXME Get event_irq from dt > +#define EVENTS_IRQ 31 > +#define VIRTUALTIMER_IRQ 27 I think deserves a prominent comment in at least the commit message, if not somewhere like the README, since it means that binaries built with this mini-os are not guaranteed to be portable to other versions of Xen on ARM. You know this but other potential users of this code might take umbrage when they find this out the hard way. Ian. _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Sat Jul 04 12:35:07 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Sat, 04 Jul 2015 12:35:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZBMew-00089V-3A; Sat, 04 Jul 2015 12:35:06 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZBMeu-00089Q-KG for Minios-devel@lists.xenproject.org; Sat, 04 Jul 2015 12:35:04 +0000 Received: from [85.158.139.211] by server-14.bemta-5.messagelabs.com id B6/F5-12923-7F2D7955; Sat, 04 Jul 2015 12:35:03 +0000 X-Env-Sender: talex5@gmail.com X-Msg-Ref: server-12.tower-206.messagelabs.com!1436013302!18871291!1 X-Originating-IP: [209.85.216.43] X-SpamReason: No, hits=0.3 required=7.0 tests=RCVD_BY_IP,UPPERCASE_25_50 X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 28019 invoked from network); 4 Jul 2015 12:35:03 -0000 Received: from mail-vn0-f43.google.com (HELO mail-vn0-f43.google.com) (209.85.216.43) by server-12.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 4 Jul 2015 12:35:03 -0000 Received: by vnbg1 with SMTP id g1so18372747vnb.7 for ; Sat, 04 Jul 2015 05:35:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; bh=XNiByygLaLH3HkWMe0+s6xdqYXeXW1Q4u6OzDP2MBAs=; b=kvm6JDS8U87N8OM9pAhhttKhq+Wt8fxy+AiCkvzz9A3/bLcA/UMmZ1RAQF4iAhf+BA ixvW+0DygjAWz0PNkw3LcrFeHY8zwplurl+6asug6JJ+FVMiRr19500RMqQovb/sUPSu FfyFEt8DZel40dIGxvL6by5bAz0hmDIdJnaYZ6k7M4+05gKal8ZdI1IY9X0YhHqUjFwd yZdFpk4InzMaWd/EsSkEvzWgiNmI8ktjWRxihB7vcD+xmFg306q2ExMgOtq20zIZVLn1 SJmG9/dYBIW52AW2Q+XWv+V7+XQdpinfSrCegJlHXT7qwPFonpTpZ4orEwVDyt+V5I7p W2ug== MIME-Version: 1.0 X-Received: by 10.52.228.3 with SMTP id se3mr5175761vdc.43.1436013302079; Sat, 04 Jul 2015 05:35:02 -0700 (PDT) Received: by 10.31.65.132 with HTTP; Sat, 4 Jul 2015 05:35:02 -0700 (PDT) In-Reply-To: <20150702002101.GX3245@type.home> References: <1435240089-23413-1-git-send-email-talex5@gmail.com> <1435240089-23413-4-git-send-email-talex5@gmail.com> <20150702002101.GX3245@type.home> Date: Sat, 4 Jul 2015 13:35:02 +0100 Message-ID: From: Thomas Leonard To: Samuel Thibault , Thomas Leonard , Minios-devel@lists.xenproject.org, Stefano Stabellini , Anil Madhavapeddy , David Scott , KarimAllah Ahmed , Ian Campbell Subject: Re: [Minios-devel] [PATCH ARM v9 3/3] mini-os: arm: build system X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org T24gMiBKdWx5IDIwMTUgYXQgMDE6MjEsIFNhbXVlbCBUaGliYXVsdCA8c2FtdWVsLnRoaWJhdWx0 QGVucy1seW9uLm9yZz4gd3JvdGU6Cj4gVGhvbWFzIExlb25hcmQsIGxlIFRodSAyNSBKdW4gMjAx NSAxNDo0ODowOSArMDEwMCwgYSDDqWNyaXQgOgo+PiBCYXNlZCBvbiBhbiBpbml0aWFsIHBhdGNo IGJ5IEthcmltIFJhc2xhbi4KPj4KPj4gVGhpcyBhY3RpdmF0ZXMgdGhlIEFSTSBjb2RlIGFkZGVk IGluIHRoZSBwcmV2aW91cyBwYXRjaGVzLiBPbiBBUk0sCj4+IE1pbmktT1Mgd2lsbCBib290IGFu ZCBkaXNwbGF5IHNvbWUgb3V0cHV0IG9uIHRoZSBjb25zb2xlLiBUZXN0ZWQgd2l0aDoKPj4KPj4g bWFrZSBYRU5fVEFSR0VUX0FSQ0g9YXJtMzIgQ1JPU1NfQ09NUElMRT1hcm0tbGludXgtZ251ZWFi aWhmLSBcCj4+ICAgICAgIENPTkZJR19URVNUPXkgQ09ORklHX1NUQVJUX05FVFdPUks9biBDT05G SUdfQkxLRlJPTlQ9biBcCj4+ICAgICAgIENPTkZJR19ORVRGUk9OVD1uIENPTkZJR19GQkZST05U PW4gQ09ORklHX0tCREZST05UPW4gXAo+PiAgICAgICBDT05GSUdfQ09OU0ZST05UPW4gQ09ORklH X1hDPW4gLWo0Cj4+Cj4+IFRoZSBtZW1tb3ZlIGltcGxlbWVudGF0aW9uIGlzIGZyb20gRnJlZUJT RCdzCj4+IGNvbnRyaWIvbGRucy9jb21wYXQvbWVtbW92ZS5jIChyMjQ2ODI3KS4KPgo+IFRoZW4g aXQgc2hvdWxkIGhhdmUgaXRzIG93biBjb3B5cmlnaHQgaGVhZGVyIGNvcGllZCBmcm9tIHRoZXJl LCBub3QganVzdAo+IHJlZmVyIHRvIENPUFlJTkcuICBBcGFydCBmcm9tIHRoYXQgaXQgbG9va3Mg ZmluZS4KCkkgZGlkbid0IHJlbW92ZSBhbnl0aGluZyAtIHRoYXQncyB0aGUgb3JpZ2luYWwgaGVh ZGVyIChleGNlcHQgSQpjaGFuZ2VkICJTZWUgTElDRU5TRSIgdG8gIlNlZSBDT1BZSU5HIik6Cgpo dHRwczovL2dpdGh1Yi5jb20vZnJlZWJzZC9mcmVlYnNkL2Jsb2IvbWFzdGVyL2NvbnRyaWIvbGRu cy9jb21wYXQvbWVtbW92ZS5jCgoKLS0gCkRyIFRob21hcyBMZW9uYXJkICAgICAgICBodHRwOi8v cm9zY2lkdXMuY29tL2Jsb2cvCkdQRzogREE5OCAyNUFFIENBRDAgODk3NSA3Q0RBICBCRDhFIDA3 MTMgM0Y5NiBDQTc0IEQ4QkEKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCk1pbmlvcy1kZXZlbCBtYWlsaW5nIGxpc3QKTWluaW9zLWRldmVsQGxpc3RzLnhl bnByb2plY3Qub3JnCmh0dHA6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9jZ2ktYmluL21haWxtYW4v bGlzdGluZm8vbWluaW9zLWRldmVs From minios-devel-bounces@lists.xenproject.org Sat Jul 04 12:35:07 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Sat, 04 Jul 2015 12:35:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZBMew-00089V-3A; Sat, 04 Jul 2015 12:35:06 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZBMeu-00089Q-KG for Minios-devel@lists.xenproject.org; Sat, 04 Jul 2015 12:35:04 +0000 Received: from [85.158.139.211] by server-14.bemta-5.messagelabs.com id B6/F5-12923-7F2D7955; Sat, 04 Jul 2015 12:35:03 +0000 X-Env-Sender: talex5@gmail.com X-Msg-Ref: server-12.tower-206.messagelabs.com!1436013302!18871291!1 X-Originating-IP: [209.85.216.43] X-SpamReason: No, hits=0.3 required=7.0 tests=RCVD_BY_IP,UPPERCASE_25_50 X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 28019 invoked from network); 4 Jul 2015 12:35:03 -0000 Received: from mail-vn0-f43.google.com (HELO mail-vn0-f43.google.com) (209.85.216.43) by server-12.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 4 Jul 2015 12:35:03 -0000 Received: by vnbg1 with SMTP id g1so18372747vnb.7 for ; Sat, 04 Jul 2015 05:35:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; bh=XNiByygLaLH3HkWMe0+s6xdqYXeXW1Q4u6OzDP2MBAs=; b=kvm6JDS8U87N8OM9pAhhttKhq+Wt8fxy+AiCkvzz9A3/bLcA/UMmZ1RAQF4iAhf+BA ixvW+0DygjAWz0PNkw3LcrFeHY8zwplurl+6asug6JJ+FVMiRr19500RMqQovb/sUPSu FfyFEt8DZel40dIGxvL6by5bAz0hmDIdJnaYZ6k7M4+05gKal8ZdI1IY9X0YhHqUjFwd yZdFpk4InzMaWd/EsSkEvzWgiNmI8ktjWRxihB7vcD+xmFg306q2ExMgOtq20zIZVLn1 SJmG9/dYBIW52AW2Q+XWv+V7+XQdpinfSrCegJlHXT7qwPFonpTpZ4orEwVDyt+V5I7p W2ug== MIME-Version: 1.0 X-Received: by 10.52.228.3 with SMTP id se3mr5175761vdc.43.1436013302079; Sat, 04 Jul 2015 05:35:02 -0700 (PDT) Received: by 10.31.65.132 with HTTP; Sat, 4 Jul 2015 05:35:02 -0700 (PDT) In-Reply-To: <20150702002101.GX3245@type.home> References: <1435240089-23413-1-git-send-email-talex5@gmail.com> <1435240089-23413-4-git-send-email-talex5@gmail.com> <20150702002101.GX3245@type.home> Date: Sat, 4 Jul 2015 13:35:02 +0100 Message-ID: From: Thomas Leonard To: Samuel Thibault , Thomas Leonard , Minios-devel@lists.xenproject.org, Stefano Stabellini , Anil Madhavapeddy , David Scott , KarimAllah Ahmed , Ian Campbell Subject: Re: [Minios-devel] [PATCH ARM v9 3/3] mini-os: arm: build system X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org T24gMiBKdWx5IDIwMTUgYXQgMDE6MjEsIFNhbXVlbCBUaGliYXVsdCA8c2FtdWVsLnRoaWJhdWx0 QGVucy1seW9uLm9yZz4gd3JvdGU6Cj4gVGhvbWFzIExlb25hcmQsIGxlIFRodSAyNSBKdW4gMjAx NSAxNDo0ODowOSArMDEwMCwgYSDDqWNyaXQgOgo+PiBCYXNlZCBvbiBhbiBpbml0aWFsIHBhdGNo IGJ5IEthcmltIFJhc2xhbi4KPj4KPj4gVGhpcyBhY3RpdmF0ZXMgdGhlIEFSTSBjb2RlIGFkZGVk IGluIHRoZSBwcmV2aW91cyBwYXRjaGVzLiBPbiBBUk0sCj4+IE1pbmktT1Mgd2lsbCBib290IGFu ZCBkaXNwbGF5IHNvbWUgb3V0cHV0IG9uIHRoZSBjb25zb2xlLiBUZXN0ZWQgd2l0aDoKPj4KPj4g bWFrZSBYRU5fVEFSR0VUX0FSQ0g9YXJtMzIgQ1JPU1NfQ09NUElMRT1hcm0tbGludXgtZ251ZWFi aWhmLSBcCj4+ICAgICAgIENPTkZJR19URVNUPXkgQ09ORklHX1NUQVJUX05FVFdPUks9biBDT05G SUdfQkxLRlJPTlQ9biBcCj4+ICAgICAgIENPTkZJR19ORVRGUk9OVD1uIENPTkZJR19GQkZST05U PW4gQ09ORklHX0tCREZST05UPW4gXAo+PiAgICAgICBDT05GSUdfQ09OU0ZST05UPW4gQ09ORklH X1hDPW4gLWo0Cj4+Cj4+IFRoZSBtZW1tb3ZlIGltcGxlbWVudGF0aW9uIGlzIGZyb20gRnJlZUJT RCdzCj4+IGNvbnRyaWIvbGRucy9jb21wYXQvbWVtbW92ZS5jIChyMjQ2ODI3KS4KPgo+IFRoZW4g aXQgc2hvdWxkIGhhdmUgaXRzIG93biBjb3B5cmlnaHQgaGVhZGVyIGNvcGllZCBmcm9tIHRoZXJl LCBub3QganVzdAo+IHJlZmVyIHRvIENPUFlJTkcuICBBcGFydCBmcm9tIHRoYXQgaXQgbG9va3Mg ZmluZS4KCkkgZGlkbid0IHJlbW92ZSBhbnl0aGluZyAtIHRoYXQncyB0aGUgb3JpZ2luYWwgaGVh ZGVyIChleGNlcHQgSQpjaGFuZ2VkICJTZWUgTElDRU5TRSIgdG8gIlNlZSBDT1BZSU5HIik6Cgpo dHRwczovL2dpdGh1Yi5jb20vZnJlZWJzZC9mcmVlYnNkL2Jsb2IvbWFzdGVyL2NvbnRyaWIvbGRu cy9jb21wYXQvbWVtbW92ZS5jCgoKLS0gCkRyIFRob21hcyBMZW9uYXJkICAgICAgICBodHRwOi8v cm9zY2lkdXMuY29tL2Jsb2cvCkdQRzogREE5OCAyNUFFIENBRDAgODk3NSA3Q0RBICBCRDhFIDA3 MTMgM0Y5NiBDQTc0IEQ4QkEKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCk1pbmlvcy1kZXZlbCBtYWlsaW5nIGxpc3QKTWluaW9zLWRldmVsQGxpc3RzLnhl bnByb2plY3Qub3JnCmh0dHA6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9jZ2ktYmluL21haWxtYW4v bGlzdGluZm8vbWluaW9zLWRldmVs From minios-devel-bounces@lists.xenproject.org Sat Jul 04 12:44:28 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Sat, 04 Jul 2015 12:44:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZBMny-0008Bk-PV; Sat, 04 Jul 2015 12:44:26 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZBMnx-0008Bf-KC for Minios-devel@lists.xenproject.org; Sat, 04 Jul 2015 12:44:25 +0000 Received: from [85.158.137.68] by server-1.bemta-3.messagelabs.com id A0/51-10437-825D7955; Sat, 04 Jul 2015 12:44:24 +0000 X-Env-Sender: SRS0=IHCt=HM=ens-lyon.org=samuel.thibault@bounce.ens-lyon.o rg X-Msg-Ref: server-5.tower-31.messagelabs.com!1436013864!22674629!1 X-Originating-IP: [140.77.166.138] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 7488 invoked from network); 4 Jul 2015 12:44:24 -0000 Received: from sonata.ens-lyon.org (HELO sonata.ens-lyon.org) (140.77.166.138) by server-5.tower-31.messagelabs.com with DHE-RSA-AES256-SHA encrypted SMTP; 4 Jul 2015 12:44:24 -0000 Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id E4E43200E0; Sat, 4 Jul 2015 14:44:23 +0200 (CEST) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ldjXiShMNhct; Sat, 4 Jul 2015 14:44:23 +0200 (CEST) Received: from type.youpi.perso.aquilenet.fr (ABordeaux-652-1-224-69.w92-146.abo.wanadoo.fr [92.146.199.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 20CB0200DF; Sat, 4 Jul 2015 14:44:22 +0200 (CEST) Received: from samy by type.youpi.perso.aquilenet.fr with local (Exim 4.86_RC3) (envelope-from ) id 1ZBMnu-0000AP-Ed; Sat, 04 Jul 2015 14:44:22 +0200 Date: Sat, 4 Jul 2015 14:44:22 +0200 From: Samuel Thibault To: Thomas Leonard Message-ID: <20150704124422.GZ19343@type.home> Mail-Followup-To: Samuel Thibault , Thomas Leonard , Minios-devel@lists.xenproject.org, Stefano Stabellini , Anil Madhavapeddy , David Scott , KarimAllah Ahmed , Ian Campbell References: <1435240089-23413-1-git-send-email-talex5@gmail.com> <1435240089-23413-4-git-send-email-talex5@gmail.com> <20150702002101.GX3245@type.home> MIME-Version: 1.0 Content-Length: 904 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Cc: Ian Campbell , Anil Madhavapeddy , KarimAllah Ahmed , Stefano Stabellini , Minios-devel@lists.xenproject.org, David Scott Subject: Re: [Minios-devel] [PATCH ARM v9 3/3] mini-os: arm: build system X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Thomas Leonard, le Sat 04 Jul 2015 13:35:02 +0100, a =E9crit : > On 2 July 2015 at 01:21, Samuel Thibault w= rote: > > Then it should have its own copyright header copied from there, not just > > refer to COPYING. Apart from that it looks fine. > = > I didn't remove anything - that's the original header (except I > changed "See LICENSE" to "See COPYING"): > = > https://github.com/freebsd/freebsd/blob/master/contrib/ldns/compat/memmov= e.c Ok, but the content of the "COPYING" file is not the same as the "LICENSE" file, very notably the copyright notice, which *has* to be kept as BSD writes it (that's actually the only requirement of the BSD licence, but is has to be respected!) Samuel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Sat Jul 04 12:44:28 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Sat, 04 Jul 2015 12:44:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZBMny-0008Bk-PV; Sat, 04 Jul 2015 12:44:26 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZBMnx-0008Bf-KC for Minios-devel@lists.xenproject.org; Sat, 04 Jul 2015 12:44:25 +0000 Received: from [85.158.137.68] by server-1.bemta-3.messagelabs.com id A0/51-10437-825D7955; Sat, 04 Jul 2015 12:44:24 +0000 X-Env-Sender: SRS0=IHCt=HM=ens-lyon.org=samuel.thibault@bounce.ens-lyon.o rg X-Msg-Ref: server-5.tower-31.messagelabs.com!1436013864!22674629!1 X-Originating-IP: [140.77.166.138] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 7488 invoked from network); 4 Jul 2015 12:44:24 -0000 Received: from sonata.ens-lyon.org (HELO sonata.ens-lyon.org) (140.77.166.138) by server-5.tower-31.messagelabs.com with DHE-RSA-AES256-SHA encrypted SMTP; 4 Jul 2015 12:44:24 -0000 Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id E4E43200E0; Sat, 4 Jul 2015 14:44:23 +0200 (CEST) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ldjXiShMNhct; Sat, 4 Jul 2015 14:44:23 +0200 (CEST) Received: from type.youpi.perso.aquilenet.fr (ABordeaux-652-1-224-69.w92-146.abo.wanadoo.fr [92.146.199.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 20CB0200DF; Sat, 4 Jul 2015 14:44:22 +0200 (CEST) Received: from samy by type.youpi.perso.aquilenet.fr with local (Exim 4.86_RC3) (envelope-from ) id 1ZBMnu-0000AP-Ed; Sat, 04 Jul 2015 14:44:22 +0200 Date: Sat, 4 Jul 2015 14:44:22 +0200 From: Samuel Thibault To: Thomas Leonard Message-ID: <20150704124422.GZ19343@type.home> Mail-Followup-To: Samuel Thibault , Thomas Leonard , Minios-devel@lists.xenproject.org, Stefano Stabellini , Anil Madhavapeddy , David Scott , KarimAllah Ahmed , Ian Campbell References: <1435240089-23413-1-git-send-email-talex5@gmail.com> <1435240089-23413-4-git-send-email-talex5@gmail.com> <20150702002101.GX3245@type.home> MIME-Version: 1.0 Content-Length: 904 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Cc: Ian Campbell , Anil Madhavapeddy , KarimAllah Ahmed , Stefano Stabellini , Minios-devel@lists.xenproject.org, David Scott Subject: Re: [Minios-devel] [PATCH ARM v9 3/3] mini-os: arm: build system X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Thomas Leonard, le Sat 04 Jul 2015 13:35:02 +0100, a =E9crit : > On 2 July 2015 at 01:21, Samuel Thibault w= rote: > > Then it should have its own copyright header copied from there, not just > > refer to COPYING. Apart from that it looks fine. > = > I didn't remove anything - that's the original header (except I > changed "See LICENSE" to "See COPYING"): > = > https://github.com/freebsd/freebsd/blob/master/contrib/ldns/compat/memmov= e.c Ok, but the content of the "COPYING" file is not the same as the "LICENSE" file, very notably the copyright notice, which *has* to be kept as BSD writes it (that's actually the only requirement of the BSD licence, but is has to be respected!) Samuel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Sat Jul 04 12:53:51 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Sat, 04 Jul 2015 12:53:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZBMx5-0008Ds-G5; Sat, 04 Jul 2015 12:53:51 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZBMx3-0008Dn-RV for Minios-devel@lists.xenproject.org; Sat, 04 Jul 2015 12:53:49 +0000 Received: from [85.158.137.68] by server-14.bemta-3.messagelabs.com id 6A/64-02969-D57D7955; Sat, 04 Jul 2015 12:53:49 +0000 X-Env-Sender: talex5@gmail.com X-Msg-Ref: server-10.tower-31.messagelabs.com!1436014427!22607193!1 X-Originating-IP: [209.85.216.53] X-SpamReason: No, hits=0.3 required=7.0 tests=RCVD_BY_IP X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 23737 invoked from network); 4 Jul 2015 12:53:48 -0000 Received: from mail-vn0-f53.google.com (HELO mail-vn0-f53.google.com) (209.85.216.53) by server-10.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 4 Jul 2015 12:53:48 -0000 Received: by vnbf129 with SMTP id f129so18850968vnb.5 for ; Sat, 04 Jul 2015 05:53:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; bh=Aex+61lvSJc7j3jaNM2QZmhRRnYOBbMG1nFPCz5VIDw=; b=KvxcvPcTlNv9IOTKn0WinKKI6l87mJbY7inc+1ID6L3StjgaBs3mxH/O3NazOQap2G A1wiPSDzB8nE8FcUvJxyn/G7bMo7QJUqUrjZb/Byc7RM020d+HiBp6nLYe8oOeyw4WEP mliv3UZx/yC1VTE18YNzTrjP+CkU3z5VnfUc858tvhoaGO7wFgcFNm3VO6p1nN5RJlr6 8TTl0d9NyOJv98EcQpoWZ3ddXIEwCdoF+gd69Hzcm8QOfXhFcS+RIo8sBO3kam1O7amr 0eakoKt64vOjAa14Q1t/tZqes/kn6oQZncSPMLC2bGDkaaI8tQ8Qp0lc0YZvYi3aPJcb f+Og== MIME-Version: 1.0 X-Received: by 10.52.38.138 with SMTP id g10mr4523507vdk.24.1436014427224; Sat, 04 Jul 2015 05:53:47 -0700 (PDT) Received: by 10.31.65.132 with HTTP; Sat, 4 Jul 2015 05:53:47 -0700 (PDT) In-Reply-To: <20150704124422.GZ19343@type.home> References: <1435240089-23413-1-git-send-email-talex5@gmail.com> <1435240089-23413-4-git-send-email-talex5@gmail.com> <20150702002101.GX3245@type.home> <20150704124422.GZ19343@type.home> Date: Sat, 4 Jul 2015 13:53:47 +0100 Message-ID: From: Thomas Leonard To: Samuel Thibault , Thomas Leonard , Minios-devel@lists.xenproject.org, Stefano Stabellini , Anil Madhavapeddy , David Scott , KarimAllah Ahmed , Ian Campbell Subject: Re: [Minios-devel] [PATCH ARM v9 3/3] mini-os: arm: build system X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org T24gNCBKdWx5IDIwMTUgYXQgMTM6NDQsIFNhbXVlbCBUaGliYXVsdCA8c2FtdWVsLnRoaWJhdWx0 QGVucy1seW9uLm9yZz4gd3JvdGU6Cj4gVGhvbWFzIExlb25hcmQsIGxlIFNhdCAwNCBKdWwgMjAx NSAxMzozNTowMiArMDEwMCwgYSDDqWNyaXQgOgo+PiBPbiAyIEp1bHkgMjAxNSBhdCAwMToyMSwg U2FtdWVsIFRoaWJhdWx0IDxzYW11ZWwudGhpYmF1bHRAZW5zLWx5b24ub3JnPiB3cm90ZToKPj4g PiBUaGVuIGl0IHNob3VsZCBoYXZlIGl0cyBvd24gY29weXJpZ2h0IGhlYWRlciBjb3BpZWQgZnJv bSB0aGVyZSwgbm90IGp1c3QKPj4gPiByZWZlciB0byBDT1BZSU5HLiAgQXBhcnQgZnJvbSB0aGF0 IGl0IGxvb2tzIGZpbmUuCj4+Cj4+IEkgZGlkbid0IHJlbW92ZSBhbnl0aGluZyAtIHRoYXQncyB0 aGUgb3JpZ2luYWwgaGVhZGVyIChleGNlcHQgSQo+PiBjaGFuZ2VkICJTZWUgTElDRU5TRSIgdG8g IlNlZSBDT1BZSU5HIik6Cj4+Cj4+IGh0dHBzOi8vZ2l0aHViLmNvbS9mcmVlYnNkL2ZyZWVic2Qv YmxvYi9tYXN0ZXIvY29udHJpYi9sZG5zL2NvbXBhdC9tZW1tb3ZlLmMKPgo+IE9rLCBidXQgdGhl IGNvbnRlbnQgb2YgdGhlICJDT1BZSU5HIiBmaWxlIGlzIG5vdCB0aGUgc2FtZSBhcyB0aGUKPiAi TElDRU5TRSIgZmlsZSwgdmVyeSBub3RhYmx5IHRoZSBjb3B5cmlnaHQgbm90aWNlLCB3aGljaCAq aGFzKiB0byBiZQo+IGtlcHQgYXMgQlNEIHdyaXRlcyBpdCAodGhhdCdzIGFjdHVhbGx5IHRoZSBv bmx5IHJlcXVpcmVtZW50IG9mIHRoZSBCU0QKPiBsaWNlbmNlLCBidXQgaXMgaGFzIHRvIGJlIHJl c3BlY3RlZCEpCgpJdCBsb29rcyB0aGUgc2FtZSB0byBtZSwgZXhjZXB0IHRoZXJlIGFyZSBzb21l IGV4dHJhIHNlY3Rpb25zIGZvciB0aGUKb3RoZXIgbGljZW5zZXMgd2UgdXNlLiBEbyB5b3UgbWVh biB0aGUgQlNEIGxpY2Vuc2UgbXVzdCBiZSBpbiBhCnNlcGFyYXRlIGZpbGU/IEkgZG9uJ3Qgc2Vl IHdoZXJlIGl0IHJlcXVpcmVzIHRoYXQsIG9ubHkgdGhhdCB3ZSBtdXN0CiJyZXRhaW4gdGhlIGFi b3ZlIGNvcHlyaWdodCBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUKZm9s bG93aW5nIGRpc2NsYWltZXIiLCB3aGljaCB3ZSBkby4KCj4gU2FtdWVsCgoKCi0tIApEciBUaG9t YXMgTGVvbmFyZCAgICAgICAgaHR0cDovL3Jvc2NpZHVzLmNvbS9ibG9nLwpHUEc6IERBOTggMjVB RSBDQUQwIDg5NzUgN0NEQSAgQkQ4RSAwNzEzIDNGOTYgQ0E3NCBEOEJBCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpNaW5pb3MtZGV2ZWwgbWFpbGluZyBs aXN0Ck1pbmlvcy1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwOi8vbGlzdHMueGVucHJv amVjdC5vcmcvY2dpLWJpbi9tYWlsbWFuL2xpc3RpbmZvL21pbmlvcy1kZXZlbA== From minios-devel-bounces@lists.xenproject.org Sat Jul 04 12:53:51 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Sat, 04 Jul 2015 12:53:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZBMx5-0008Ds-G5; Sat, 04 Jul 2015 12:53:51 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZBMx3-0008Dn-RV for Minios-devel@lists.xenproject.org; Sat, 04 Jul 2015 12:53:49 +0000 Received: from [85.158.137.68] by server-14.bemta-3.messagelabs.com id 6A/64-02969-D57D7955; Sat, 04 Jul 2015 12:53:49 +0000 X-Env-Sender: talex5@gmail.com X-Msg-Ref: server-10.tower-31.messagelabs.com!1436014427!22607193!1 X-Originating-IP: [209.85.216.53] X-SpamReason: No, hits=0.3 required=7.0 tests=RCVD_BY_IP X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 23737 invoked from network); 4 Jul 2015 12:53:48 -0000 Received: from mail-vn0-f53.google.com (HELO mail-vn0-f53.google.com) (209.85.216.53) by server-10.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 4 Jul 2015 12:53:48 -0000 Received: by vnbf129 with SMTP id f129so18850968vnb.5 for ; Sat, 04 Jul 2015 05:53:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; bh=Aex+61lvSJc7j3jaNM2QZmhRRnYOBbMG1nFPCz5VIDw=; b=KvxcvPcTlNv9IOTKn0WinKKI6l87mJbY7inc+1ID6L3StjgaBs3mxH/O3NazOQap2G A1wiPSDzB8nE8FcUvJxyn/G7bMo7QJUqUrjZb/Byc7RM020d+HiBp6nLYe8oOeyw4WEP mliv3UZx/yC1VTE18YNzTrjP+CkU3z5VnfUc858tvhoaGO7wFgcFNm3VO6p1nN5RJlr6 8TTl0d9NyOJv98EcQpoWZ3ddXIEwCdoF+gd69Hzcm8QOfXhFcS+RIo8sBO3kam1O7amr 0eakoKt64vOjAa14Q1t/tZqes/kn6oQZncSPMLC2bGDkaaI8tQ8Qp0lc0YZvYi3aPJcb f+Og== MIME-Version: 1.0 X-Received: by 10.52.38.138 with SMTP id g10mr4523507vdk.24.1436014427224; Sat, 04 Jul 2015 05:53:47 -0700 (PDT) Received: by 10.31.65.132 with HTTP; Sat, 4 Jul 2015 05:53:47 -0700 (PDT) In-Reply-To: <20150704124422.GZ19343@type.home> References: <1435240089-23413-1-git-send-email-talex5@gmail.com> <1435240089-23413-4-git-send-email-talex5@gmail.com> <20150702002101.GX3245@type.home> <20150704124422.GZ19343@type.home> Date: Sat, 4 Jul 2015 13:53:47 +0100 Message-ID: From: Thomas Leonard To: Samuel Thibault , Thomas Leonard , Minios-devel@lists.xenproject.org, Stefano Stabellini , Anil Madhavapeddy , David Scott , KarimAllah Ahmed , Ian Campbell Subject: Re: [Minios-devel] [PATCH ARM v9 3/3] mini-os: arm: build system X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org T24gNCBKdWx5IDIwMTUgYXQgMTM6NDQsIFNhbXVlbCBUaGliYXVsdCA8c2FtdWVsLnRoaWJhdWx0 QGVucy1seW9uLm9yZz4gd3JvdGU6Cj4gVGhvbWFzIExlb25hcmQsIGxlIFNhdCAwNCBKdWwgMjAx NSAxMzozNTowMiArMDEwMCwgYSDDqWNyaXQgOgo+PiBPbiAyIEp1bHkgMjAxNSBhdCAwMToyMSwg U2FtdWVsIFRoaWJhdWx0IDxzYW11ZWwudGhpYmF1bHRAZW5zLWx5b24ub3JnPiB3cm90ZToKPj4g PiBUaGVuIGl0IHNob3VsZCBoYXZlIGl0cyBvd24gY29weXJpZ2h0IGhlYWRlciBjb3BpZWQgZnJv bSB0aGVyZSwgbm90IGp1c3QKPj4gPiByZWZlciB0byBDT1BZSU5HLiAgQXBhcnQgZnJvbSB0aGF0 IGl0IGxvb2tzIGZpbmUuCj4+Cj4+IEkgZGlkbid0IHJlbW92ZSBhbnl0aGluZyAtIHRoYXQncyB0 aGUgb3JpZ2luYWwgaGVhZGVyIChleGNlcHQgSQo+PiBjaGFuZ2VkICJTZWUgTElDRU5TRSIgdG8g IlNlZSBDT1BZSU5HIik6Cj4+Cj4+IGh0dHBzOi8vZ2l0aHViLmNvbS9mcmVlYnNkL2ZyZWVic2Qv YmxvYi9tYXN0ZXIvY29udHJpYi9sZG5zL2NvbXBhdC9tZW1tb3ZlLmMKPgo+IE9rLCBidXQgdGhl IGNvbnRlbnQgb2YgdGhlICJDT1BZSU5HIiBmaWxlIGlzIG5vdCB0aGUgc2FtZSBhcyB0aGUKPiAi TElDRU5TRSIgZmlsZSwgdmVyeSBub3RhYmx5IHRoZSBjb3B5cmlnaHQgbm90aWNlLCB3aGljaCAq aGFzKiB0byBiZQo+IGtlcHQgYXMgQlNEIHdyaXRlcyBpdCAodGhhdCdzIGFjdHVhbGx5IHRoZSBv bmx5IHJlcXVpcmVtZW50IG9mIHRoZSBCU0QKPiBsaWNlbmNlLCBidXQgaXMgaGFzIHRvIGJlIHJl c3BlY3RlZCEpCgpJdCBsb29rcyB0aGUgc2FtZSB0byBtZSwgZXhjZXB0IHRoZXJlIGFyZSBzb21l IGV4dHJhIHNlY3Rpb25zIGZvciB0aGUKb3RoZXIgbGljZW5zZXMgd2UgdXNlLiBEbyB5b3UgbWVh biB0aGUgQlNEIGxpY2Vuc2UgbXVzdCBiZSBpbiBhCnNlcGFyYXRlIGZpbGU/IEkgZG9uJ3Qgc2Vl IHdoZXJlIGl0IHJlcXVpcmVzIHRoYXQsIG9ubHkgdGhhdCB3ZSBtdXN0CiJyZXRhaW4gdGhlIGFi b3ZlIGNvcHlyaWdodCBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUKZm9s bG93aW5nIGRpc2NsYWltZXIiLCB3aGljaCB3ZSBkby4KCj4gU2FtdWVsCgoKCi0tIApEciBUaG9t YXMgTGVvbmFyZCAgICAgICAgaHR0cDovL3Jvc2NpZHVzLmNvbS9ibG9nLwpHUEc6IERBOTggMjVB RSBDQUQwIDg5NzUgN0NEQSAgQkQ4RSAwNzEzIDNGOTYgQ0E3NCBEOEJBCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpNaW5pb3MtZGV2ZWwgbWFpbGluZyBs aXN0Ck1pbmlvcy1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwOi8vbGlzdHMueGVucHJv amVjdC5vcmcvY2dpLWJpbi9tYWlsbWFuL2xpc3RpbmZvL21pbmlvcy1kZXZlbA== From minios-devel-bounces@lists.xenproject.org Sat Jul 04 13:04:20 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Sat, 04 Jul 2015 13:04:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZBN7E-0008Ie-9Q; Sat, 04 Jul 2015 13:04:20 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZBN7C-0008IZ-RD for Minios-devel@lists.xenproject.org; Sat, 04 Jul 2015 13:04:18 +0000 Received: from [193.109.254.147] by server-13.bemta-14.messagelabs.com id BE/04-16813-2D9D7955; Sat, 04 Jul 2015 13:04:18 +0000 X-Env-Sender: SRS0=IHCt=HM=ens-lyon.org=samuel.thibault@bounce.ens-lyon.o rg X-Msg-Ref: server-3.tower-27.messagelabs.com!1436015056!29147071!1 X-Originating-IP: [140.77.166.138] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 32713 invoked from network); 4 Jul 2015 13:04:17 -0000 Received: from sonata.ens-lyon.org (HELO sonata.ens-lyon.org) (140.77.166.138) by server-3.tower-27.messagelabs.com with DHE-RSA-AES256-SHA encrypted SMTP; 4 Jul 2015 13:04:17 -0000 Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id BDD90200DA; Sat, 4 Jul 2015 15:04:16 +0200 (CEST) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DBbgr9GoI7pk; Sat, 4 Jul 2015 15:04:16 +0200 (CEST) Received: from type.youpi.perso.aquilenet.fr (ABordeaux-652-1-224-69.w92-146.abo.wanadoo.fr [92.146.199.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 4F85F200D5; Sat, 4 Jul 2015 15:04:16 +0200 (CEST) Received: from samy by type.youpi.perso.aquilenet.fr with local (Exim 4.86_RC3) (envelope-from ) id 1ZBN79-0000ln-BI; Sat, 04 Jul 2015 15:04:15 +0200 Date: Sat, 4 Jul 2015 15:04:15 +0200 From: Samuel Thibault To: Thomas Leonard Message-ID: <20150704130415.GI19343@type.home> Mail-Followup-To: Samuel Thibault , Thomas Leonard , Minios-devel@lists.xenproject.org, Stefano Stabellini , Anil Madhavapeddy , David Scott , KarimAllah Ahmed , Ian Campbell References: <1435240089-23413-1-git-send-email-talex5@gmail.com> <1435240089-23413-4-git-send-email-talex5@gmail.com> <20150702002101.GX3245@type.home> <20150704124422.GZ19343@type.home> MIME-Version: 1.0 Content-Length: 908 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Cc: Ian Campbell , Anil Madhavapeddy , KarimAllah Ahmed , Stefano Stabellini , Minios-devel@lists.xenproject.org, David Scott Subject: Re: [Minios-devel] [PATCH ARM v9 3/3] mini-os: arm: build system X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Thomas Leonard, le Sat 04 Jul 2015 13:53:47 +0100, a =E9crit : > On 4 July 2015 at 13:44, Samuel Thibault w= rote: > > Thomas Leonard, le Sat 04 Jul 2015 13:35:02 +0100, a =E9crit : > >> On 2 July 2015 at 01:21, Samuel Thibault wrote: > >> > Then it should have its own copyright header copied from there, not = just > >> > refer to COPYING. Apart from that it looks fine. Oops, sorry, reading the proposed patch again, I hadn't noticed that you copied the content of LICENSE into COPYING. That is fine, then. > Do you mean the BSD license must be in a separate file? It's not a must, but it might be useful. I'd leave that decision to the xen maintainers. Samuel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Sat Jul 04 13:04:20 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Sat, 04 Jul 2015 13:04:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZBN7E-0008Ie-9Q; Sat, 04 Jul 2015 13:04:20 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZBN7C-0008IZ-RD for Minios-devel@lists.xenproject.org; Sat, 04 Jul 2015 13:04:18 +0000 Received: from [193.109.254.147] by server-13.bemta-14.messagelabs.com id BE/04-16813-2D9D7955; Sat, 04 Jul 2015 13:04:18 +0000 X-Env-Sender: SRS0=IHCt=HM=ens-lyon.org=samuel.thibault@bounce.ens-lyon.o rg X-Msg-Ref: server-3.tower-27.messagelabs.com!1436015056!29147071!1 X-Originating-IP: [140.77.166.138] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 32713 invoked from network); 4 Jul 2015 13:04:17 -0000 Received: from sonata.ens-lyon.org (HELO sonata.ens-lyon.org) (140.77.166.138) by server-3.tower-27.messagelabs.com with DHE-RSA-AES256-SHA encrypted SMTP; 4 Jul 2015 13:04:17 -0000 Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id BDD90200DA; Sat, 4 Jul 2015 15:04:16 +0200 (CEST) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DBbgr9GoI7pk; Sat, 4 Jul 2015 15:04:16 +0200 (CEST) Received: from type.youpi.perso.aquilenet.fr (ABordeaux-652-1-224-69.w92-146.abo.wanadoo.fr [92.146.199.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 4F85F200D5; Sat, 4 Jul 2015 15:04:16 +0200 (CEST) Received: from samy by type.youpi.perso.aquilenet.fr with local (Exim 4.86_RC3) (envelope-from ) id 1ZBN79-0000ln-BI; Sat, 04 Jul 2015 15:04:15 +0200 Date: Sat, 4 Jul 2015 15:04:15 +0200 From: Samuel Thibault To: Thomas Leonard Message-ID: <20150704130415.GI19343@type.home> Mail-Followup-To: Samuel Thibault , Thomas Leonard , Minios-devel@lists.xenproject.org, Stefano Stabellini , Anil Madhavapeddy , David Scott , KarimAllah Ahmed , Ian Campbell References: <1435240089-23413-1-git-send-email-talex5@gmail.com> <1435240089-23413-4-git-send-email-talex5@gmail.com> <20150702002101.GX3245@type.home> <20150704124422.GZ19343@type.home> MIME-Version: 1.0 Content-Length: 908 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Cc: Ian Campbell , Anil Madhavapeddy , KarimAllah Ahmed , Stefano Stabellini , Minios-devel@lists.xenproject.org, David Scott Subject: Re: [Minios-devel] [PATCH ARM v9 3/3] mini-os: arm: build system X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Thomas Leonard, le Sat 04 Jul 2015 13:53:47 +0100, a =E9crit : > On 4 July 2015 at 13:44, Samuel Thibault w= rote: > > Thomas Leonard, le Sat 04 Jul 2015 13:35:02 +0100, a =E9crit : > >> On 2 July 2015 at 01:21, Samuel Thibault wrote: > >> > Then it should have its own copyright header copied from there, not = just > >> > refer to COPYING. Apart from that it looks fine. Oops, sorry, reading the proposed patch again, I hadn't noticed that you copied the content of LICENSE into COPYING. That is fine, then. > Do you mean the BSD license must be in a separate file? It's not a must, but it might be useful. I'd leave that decision to the xen maintainers. Samuel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Jul 15 15:46:29 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 15 Jul 2015 15:46:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZFOtA-0004Bh-4y; Wed, 15 Jul 2015 15:46:28 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZFOt8-0004B5-UL for minios-devel@lists.xenproject.org; Wed, 15 Jul 2015 15:46:27 +0000 Received: from [193.109.254.147] by server-5.bemta-14.messagelabs.com id 78/E4-29123-25086A55; Wed, 15 Jul 2015 15:46:26 +0000 X-Env-Sender: prvs=631330d48=Ian.Campbell@citrix.com X-Msg-Ref: server-8.tower-27.messagelabs.com!1436975183!32405809!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 3860 invoked from network); 15 Jul 2015 15:46:25 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-8.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 15 Jul 2015 15:46:25 -0000 X-IronPort-AV: E=Sophos;i="5.15,480,1432598400"; d="scan'208";a="281253986" Message-ID: <1436975173.32371.121.camel@citrix.com> From: Ian Campbell To: xen-devel Date: Wed, 15 Jul 2015 16:46:13 +0100 X-Mailer: Evolution 3.12.9-1+b1 MIME-Version: 1.0 X-DLP: MIA1 Cc: minios-devel@lists.xenproject.org, Wei Liu , Stefano Stabellini , Ian Jackson , Roger Pau Monne Subject: [Minios-devel] [Xen-devel] [PATCH v2 0/15+5+5] Begin to disentangle libxenctrl and provide some stable libraries X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org (this is clearly not 4.6 material, aiming for 4.7) In <1431963008.4944.80.camel@citrix.com> I proposed stabilising some parts of the libxenctrl API/ABI by disaggregating into separate libraries. After the previous proof of concept I have now split out: * xentoollog * evtch * gntdev and gntshr * hypercalls * privileged foreign memory mappings These represent the core low level functionality which everything else needs, I think, and so are moving things down into a layer below libxc (i.e. libxc uses all of these). There are 3 series, against xen.git (15 patches), mini-os.git (5 patches) and qemu-xen-trad.git (5 patches). The patches against xen.git point to the patches in the other two trees via instructions to update the relevant Config.mk field. The perils of changing unstable interfaces! NB: minios-devel will only get the mini-os side. The code in for all three can be found in: git://xenbits.xen.org/people/ianc/xen.git libxenctrl-split-v2 git://xenbits.xen.org/people/ianc/qemu-xen-unstable.git libxenctrl-split-v2 git://xenbits.xen.org/people/ianc/mini-os.git libxenctrl-split-v2 The tip of the xen.git branch contains an extra patch adding a .config into the tree which should get the correct things for the HEAD of the branch, but not further back. Still to come would be libraries for specific out of tree purposes (device model, kexec), which would be adding new library at the same level as libxc I think, rather than underneath, i.e. also using the libraries split out here, but hopefully not libxenctrl itself. The new libraries use linker version-scripts to hopefully make future ABI changes be possible in a compatible way. I'm stilling mulling over putting everything into tools/libs/FOO instead of tools/libxenFOO, I still haven't but I could if people think it is worthwhile. Eventually I'd like to split libxc into libxenguest and libxenctrl to cut down on the amount of strange cross talk... I've now completely removed the osdep layer. The whole thing has been build and runtime tested on Linux and stubdoms, and built (but not run) on FreeBSD. Neither NetBSD nor Solaris have been tested at all. It's certainly not impossible that I've not got the #includes in the new files quite right. The original proposal has morphed into docs/misc/toolstack-library-abis.pandoc here, and I've been trying to update in the patches which touch things, which is useful for book keeping as this work progresses. However I'm not sure it serves a useful long term purpose (certainly not with the level of detail of the per-library function names). I shall likely keep it around for a few iterations but I think eventually I'll strip it out or replace it with something more suitable for long term documentation. Ian _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Jul 15 15:46:29 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 15 Jul 2015 15:46:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZFOtA-0004Bh-4y; Wed, 15 Jul 2015 15:46:28 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZFOt8-0004B5-UL for minios-devel@lists.xenproject.org; Wed, 15 Jul 2015 15:46:27 +0000 Received: from [193.109.254.147] by server-5.bemta-14.messagelabs.com id 78/E4-29123-25086A55; Wed, 15 Jul 2015 15:46:26 +0000 X-Env-Sender: prvs=631330d48=Ian.Campbell@citrix.com X-Msg-Ref: server-8.tower-27.messagelabs.com!1436975183!32405809!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 3860 invoked from network); 15 Jul 2015 15:46:25 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-8.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 15 Jul 2015 15:46:25 -0000 X-IronPort-AV: E=Sophos;i="5.15,480,1432598400"; d="scan'208";a="281253986" Message-ID: <1436975173.32371.121.camel@citrix.com> From: Ian Campbell To: xen-devel Date: Wed, 15 Jul 2015 16:46:13 +0100 X-Mailer: Evolution 3.12.9-1+b1 MIME-Version: 1.0 X-DLP: MIA1 Cc: minios-devel@lists.xenproject.org, Wei Liu , Stefano Stabellini , Ian Jackson , Roger Pau Monne Subject: [Minios-devel] [Xen-devel] [PATCH v2 0/15+5+5] Begin to disentangle libxenctrl and provide some stable libraries X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org (this is clearly not 4.6 material, aiming for 4.7) In <1431963008.4944.80.camel@citrix.com> I proposed stabilising some parts of the libxenctrl API/ABI by disaggregating into separate libraries. After the previous proof of concept I have now split out: * xentoollog * evtch * gntdev and gntshr * hypercalls * privileged foreign memory mappings These represent the core low level functionality which everything else needs, I think, and so are moving things down into a layer below libxc (i.e. libxc uses all of these). There are 3 series, against xen.git (15 patches), mini-os.git (5 patches) and qemu-xen-trad.git (5 patches). The patches against xen.git point to the patches in the other two trees via instructions to update the relevant Config.mk field. The perils of changing unstable interfaces! NB: minios-devel will only get the mini-os side. The code in for all three can be found in: git://xenbits.xen.org/people/ianc/xen.git libxenctrl-split-v2 git://xenbits.xen.org/people/ianc/qemu-xen-unstable.git libxenctrl-split-v2 git://xenbits.xen.org/people/ianc/mini-os.git libxenctrl-split-v2 The tip of the xen.git branch contains an extra patch adding a .config into the tree which should get the correct things for the HEAD of the branch, but not further back. Still to come would be libraries for specific out of tree purposes (device model, kexec), which would be adding new library at the same level as libxc I think, rather than underneath, i.e. also using the libraries split out here, but hopefully not libxenctrl itself. The new libraries use linker version-scripts to hopefully make future ABI changes be possible in a compatible way. I'm stilling mulling over putting everything into tools/libs/FOO instead of tools/libxenFOO, I still haven't but I could if people think it is worthwhile. Eventually I'd like to split libxc into libxenguest and libxenctrl to cut down on the amount of strange cross talk... I've now completely removed the osdep layer. The whole thing has been build and runtime tested on Linux and stubdoms, and built (but not run) on FreeBSD. Neither NetBSD nor Solaris have been tested at all. It's certainly not impossible that I've not got the #includes in the new files quite right. The original proposal has morphed into docs/misc/toolstack-library-abis.pandoc here, and I've been trying to update in the patches which touch things, which is useful for book keeping as this work progresses. However I'm not sure it serves a useful long term purpose (certainly not with the level of detail of the per-library function names). I shall likely keep it around for a few iterations but I think eventually I'll strip it out or replace it with something more suitable for long term documentation. Ian _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Jul 15 15:48:32 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 15 Jul 2015 15:48:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZFOvA-0005qu-Kp; Wed, 15 Jul 2015 15:48:32 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZFOv9-0005nX-2x for minios-devel@lists.xenproject.org; Wed, 15 Jul 2015 15:48:31 +0000 Received: from [85.158.139.211] by server-5.bemta-5.messagelabs.com id 00/B1-00913-EC086A55; Wed, 15 Jul 2015 15:48:30 +0000 X-Env-Sender: prvs=631330d48=Ian.Campbell@citrix.com X-Msg-Ref: server-12.tower-206.messagelabs.com!1436975308!21365291!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 6505 invoked from network); 15 Jul 2015 15:48:29 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-12.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 15 Jul 2015 15:48:29 -0000 X-IronPort-AV: E=Sophos;i="5.15,480,1432598400"; d="scan'208";a="284369208" From: Ian Campbell To: , , Date: Wed, 15 Jul 2015 16:48:21 +0100 Message-ID: <1436975305-13258-1-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1436975173.32371.121.camel@citrix.com> References: <1436975173.32371.121.camel@citrix.com> MIME-Version: 1.0 X-DLP: MIA1 Cc: minios-devel@lists.xenproject.org, roger.pau@citrix.com, Ian Campbell , stefano.stabellini@eu.citrix.com Subject: [Minios-devel] [PATCH MINI-OS v2 1/5] mini-os: Include libxentoollog with libxc X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org libxentoollog has just been split out from libxc. From mini-os's point of view we don't care about the distinction, so keep things simple by just including libxentoollog if libxc is enabled. Signed-off-by: Ian Campbell --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 2cb5e51..757bd70 100644 --- a/Makefile +++ b/Makefile @@ -165,6 +165,7 @@ OBJS := $(filter-out $(OBJ_DIR)/lwip%.o $(LWO), $(OBJS)) ifeq ($(libc),y) ifeq ($(CONFIG_XC),y) +APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxentoollog-$(MINIOS_TARGET_ARCH) -whole-archive -lxentoollog -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxc-$(MINIOS_TARGET_ARCH) -whole-archive -lxenguest -lxenctrl -no-whole-archive endif APP_LDLIBS += -lpci -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Jul 15 15:48:32 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 15 Jul 2015 15:48:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZFOvA-0005qu-Kp; Wed, 15 Jul 2015 15:48:32 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZFOv9-0005nX-2x for minios-devel@lists.xenproject.org; Wed, 15 Jul 2015 15:48:31 +0000 Received: from [85.158.139.211] by server-5.bemta-5.messagelabs.com id 00/B1-00913-EC086A55; Wed, 15 Jul 2015 15:48:30 +0000 X-Env-Sender: prvs=631330d48=Ian.Campbell@citrix.com X-Msg-Ref: server-12.tower-206.messagelabs.com!1436975308!21365291!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 6505 invoked from network); 15 Jul 2015 15:48:29 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-12.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 15 Jul 2015 15:48:29 -0000 X-IronPort-AV: E=Sophos;i="5.15,480,1432598400"; d="scan'208";a="284369208" From: Ian Campbell To: , , Date: Wed, 15 Jul 2015 16:48:21 +0100 Message-ID: <1436975305-13258-1-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1436975173.32371.121.camel@citrix.com> References: <1436975173.32371.121.camel@citrix.com> MIME-Version: 1.0 X-DLP: MIA1 Cc: minios-devel@lists.xenproject.org, roger.pau@citrix.com, Ian Campbell , stefano.stabellini@eu.citrix.com Subject: [Minios-devel] [PATCH MINI-OS v2 1/5] mini-os: Include libxentoollog with libxc X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org libxentoollog has just been split out from libxc. From mini-os's point of view we don't care about the distinction, so keep things simple by just including libxentoollog if libxc is enabled. Signed-off-by: Ian Campbell --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 2cb5e51..757bd70 100644 --- a/Makefile +++ b/Makefile @@ -165,6 +165,7 @@ OBJS := $(filter-out $(OBJ_DIR)/lwip%.o $(LWO), $(OBJS)) ifeq ($(libc),y) ifeq ($(CONFIG_XC),y) +APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxentoollog-$(MINIOS_TARGET_ARCH) -whole-archive -lxentoollog -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxc-$(MINIOS_TARGET_ARCH) -whole-archive -lxenguest -lxenctrl -no-whole-archive endif APP_LDLIBS += -lpci -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Jul 15 15:48:35 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 15 Jul 2015 15:48:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZFOvD-0005x4-7d; Wed, 15 Jul 2015 15:48:35 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZFOvA-0005pS-5E for minios-devel@lists.xenproject.org; Wed, 15 Jul 2015 15:48:32 +0000 Received: from [85.158.139.211] by server-1.bemta-5.messagelabs.com id 77/3A-01637-FC086A55; Wed, 15 Jul 2015 15:48:31 +0000 X-Env-Sender: prvs=631330d48=Ian.Campbell@citrix.com X-Msg-Ref: server-12.tower-206.messagelabs.com!1436975308!21365291!2 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 6688 invoked from network); 15 Jul 2015 15:48:30 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-12.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 15 Jul 2015 15:48:30 -0000 X-IronPort-AV: E=Sophos;i="5.15,480,1432598400"; d="scan'208";a="284369223" From: Ian Campbell To: , , Date: Wed, 15 Jul 2015 16:48:23 +0100 Message-ID: <1436975305-13258-3-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1436975173.32371.121.camel@citrix.com> References: <1436975173.32371.121.camel@citrix.com> MIME-Version: 1.0 X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, roger.pau@citrix.com, Ian Campbell , stefano.stabellini@eu.citrix.com Subject: [Minios-devel] [PATCH MINI-OS v2 3/5] mini-os: Include libxengnttab with libxc X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org libxengnttab has just been split out from libxc. From mini-os's point of view we don't care about the distinction, so keep things simple by just including libxengnttab if libxc is enabled. Signed-off-by: Ian Campbell --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 66ed510..5e67e6c 100644 --- a/Makefile +++ b/Makefile @@ -167,6 +167,7 @@ ifeq ($(libc),y) ifeq ($(CONFIG_XC),y) APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxentoollog-$(MINIOS_TARGET_ARCH) -whole-archive -lxentoollog -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxenevtchn-$(MINIOS_TARGET_ARCH) -whole-archive -lxenevtchn -no-whole-archive +APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxengnttab-$(MINIOS_TARGET_ARCH) -whole-archive -lxengnttab -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxc-$(MINIOS_TARGET_ARCH) -whole-archive -lxenguest -lxenctrl -no-whole-archive endif APP_LDLIBS += -lpci -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Jul 15 15:48:35 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 15 Jul 2015 15:48:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZFOvD-0005x4-7d; Wed, 15 Jul 2015 15:48:35 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZFOvA-0005pS-5E for minios-devel@lists.xenproject.org; Wed, 15 Jul 2015 15:48:32 +0000 Received: from [85.158.139.211] by server-1.bemta-5.messagelabs.com id 77/3A-01637-FC086A55; Wed, 15 Jul 2015 15:48:31 +0000 X-Env-Sender: prvs=631330d48=Ian.Campbell@citrix.com X-Msg-Ref: server-12.tower-206.messagelabs.com!1436975308!21365291!2 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 6688 invoked from network); 15 Jul 2015 15:48:30 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-12.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 15 Jul 2015 15:48:30 -0000 X-IronPort-AV: E=Sophos;i="5.15,480,1432598400"; d="scan'208";a="284369223" From: Ian Campbell To: , , Date: Wed, 15 Jul 2015 16:48:23 +0100 Message-ID: <1436975305-13258-3-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1436975173.32371.121.camel@citrix.com> References: <1436975173.32371.121.camel@citrix.com> MIME-Version: 1.0 X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, roger.pau@citrix.com, Ian Campbell , stefano.stabellini@eu.citrix.com Subject: [Minios-devel] [PATCH MINI-OS v2 3/5] mini-os: Include libxengnttab with libxc X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org libxengnttab has just been split out from libxc. From mini-os's point of view we don't care about the distinction, so keep things simple by just including libxengnttab if libxc is enabled. Signed-off-by: Ian Campbell --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 66ed510..5e67e6c 100644 --- a/Makefile +++ b/Makefile @@ -167,6 +167,7 @@ ifeq ($(libc),y) ifeq ($(CONFIG_XC),y) APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxentoollog-$(MINIOS_TARGET_ARCH) -whole-archive -lxentoollog -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxenevtchn-$(MINIOS_TARGET_ARCH) -whole-archive -lxenevtchn -no-whole-archive +APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxengnttab-$(MINIOS_TARGET_ARCH) -whole-archive -lxengnttab -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxc-$(MINIOS_TARGET_ARCH) -whole-archive -lxenguest -lxenctrl -no-whole-archive endif APP_LDLIBS += -lpci -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Jul 15 15:48:37 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 15 Jul 2015 15:48:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZFOvF-00061t-8X; Wed, 15 Jul 2015 15:48:37 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZFOvC-0005u9-HJ for minios-devel@lists.xenproject.org; Wed, 15 Jul 2015 15:48:34 +0000 Received: from [85.158.137.68] by server-4.bemta-3.messagelabs.com id 9C/0C-32406-1D086A55; Wed, 15 Jul 2015 15:48:33 +0000 X-Env-Sender: prvs=631330d48=Ian.Campbell@citrix.com X-Msg-Ref: server-6.tower-31.messagelabs.com!1436975309!21719314!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 12535 invoked from network); 15 Jul 2015 15:48:30 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-6.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 15 Jul 2015 15:48:30 -0000 X-IronPort-AV: E=Sophos;i="5.15,480,1432598400"; d="scan'208";a="284369216" From: Ian Campbell To: , , Date: Wed, 15 Jul 2015 16:48:22 +0100 Message-ID: <1436975305-13258-2-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1436975173.32371.121.camel@citrix.com> References: <1436975173.32371.121.camel@citrix.com> MIME-Version: 1.0 X-DLP: MIA1 Cc: minios-devel@lists.xenproject.org, roger.pau@citrix.com, Ian Campbell , stefano.stabellini@eu.citrix.com Subject: [Minios-devel] [PATCH MINI-OS v2 2/5] mini-os: Include libxenevtchn with libxc X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org libxenevtchn has just been split out from libxc. From mini-os's point of view we don't care about the distinction, so keep things simple by just including libxenevtchn if libxc is enabled. Signed-off-by: Ian Campbell --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 757bd70..66ed510 100644 --- a/Makefile +++ b/Makefile @@ -166,6 +166,7 @@ OBJS := $(filter-out $(OBJ_DIR)/lwip%.o $(LWO), $(OBJS)) ifeq ($(libc),y) ifeq ($(CONFIG_XC),y) APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxentoollog-$(MINIOS_TARGET_ARCH) -whole-archive -lxentoollog -no-whole-archive +APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxenevtchn-$(MINIOS_TARGET_ARCH) -whole-archive -lxenevtchn -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxc-$(MINIOS_TARGET_ARCH) -whole-archive -lxenguest -lxenctrl -no-whole-archive endif APP_LDLIBS += -lpci -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Jul 15 15:48:37 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 15 Jul 2015 15:48:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZFOvF-00061t-8X; Wed, 15 Jul 2015 15:48:37 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZFOvC-0005u9-HJ for minios-devel@lists.xenproject.org; Wed, 15 Jul 2015 15:48:34 +0000 Received: from [85.158.137.68] by server-4.bemta-3.messagelabs.com id 9C/0C-32406-1D086A55; Wed, 15 Jul 2015 15:48:33 +0000 X-Env-Sender: prvs=631330d48=Ian.Campbell@citrix.com X-Msg-Ref: server-6.tower-31.messagelabs.com!1436975309!21719314!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 12535 invoked from network); 15 Jul 2015 15:48:30 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-6.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 15 Jul 2015 15:48:30 -0000 X-IronPort-AV: E=Sophos;i="5.15,480,1432598400"; d="scan'208";a="284369216" From: Ian Campbell To: , , Date: Wed, 15 Jul 2015 16:48:22 +0100 Message-ID: <1436975305-13258-2-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1436975173.32371.121.camel@citrix.com> References: <1436975173.32371.121.camel@citrix.com> MIME-Version: 1.0 X-DLP: MIA1 Cc: minios-devel@lists.xenproject.org, roger.pau@citrix.com, Ian Campbell , stefano.stabellini@eu.citrix.com Subject: [Minios-devel] [PATCH MINI-OS v2 2/5] mini-os: Include libxenevtchn with libxc X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org libxenevtchn has just been split out from libxc. From mini-os's point of view we don't care about the distinction, so keep things simple by just including libxenevtchn if libxc is enabled. Signed-off-by: Ian Campbell --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 757bd70..66ed510 100644 --- a/Makefile +++ b/Makefile @@ -166,6 +166,7 @@ OBJS := $(filter-out $(OBJ_DIR)/lwip%.o $(LWO), $(OBJS)) ifeq ($(libc),y) ifeq ($(CONFIG_XC),y) APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxentoollog-$(MINIOS_TARGET_ARCH) -whole-archive -lxentoollog -no-whole-archive +APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxenevtchn-$(MINIOS_TARGET_ARCH) -whole-archive -lxenevtchn -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxc-$(MINIOS_TARGET_ARCH) -whole-archive -lxenguest -lxenctrl -no-whole-archive endif APP_LDLIBS += -lpci -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Jul 15 15:48:37 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 15 Jul 2015 15:48:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZFOvF-00062R-F3; Wed, 15 Jul 2015 15:48:37 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZFOvC-0005td-Af for minios-devel@lists.xenproject.org; Wed, 15 Jul 2015 15:48:34 +0000 Received: from [85.158.137.68] by server-6.bemta-3.messagelabs.com id BD/E9-13517-1D086A55; Wed, 15 Jul 2015 15:48:33 +0000 X-Env-Sender: prvs=631330d48=Ian.Campbell@citrix.com X-Msg-Ref: server-8.tower-31.messagelabs.com!1436975311!26108812!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 4678 invoked from network); 15 Jul 2015 15:48:32 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-8.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 15 Jul 2015 15:48:32 -0000 X-IronPort-AV: E=Sophos;i="5.15,480,1432598400"; d="scan'208";a="284369232" From: Ian Campbell To: , , Date: Wed, 15 Jul 2015 16:48:24 +0100 Message-ID: <1436975305-13258-4-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1436975173.32371.121.camel@citrix.com> References: <1436975173.32371.121.camel@citrix.com> MIME-Version: 1.0 X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, roger.pau@citrix.com, Ian Campbell , stefano.stabellini@eu.citrix.com Subject: [Minios-devel] [PATCH MINI-OS v2 4/5] mini-os: Include libxencall with libxc X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org libxencall has just been split out from libxc. From mini-os's point of view we don't care about the distinction, so keep things simple by just including libxencall if libxc is enabled. Signed-off-by: Ian Campbell --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 5e67e6c..835c47b 100644 --- a/Makefile +++ b/Makefile @@ -168,6 +168,7 @@ ifeq ($(CONFIG_XC),y) APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxentoollog-$(MINIOS_TARGET_ARCH) -whole-archive -lxentoollog -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxenevtchn-$(MINIOS_TARGET_ARCH) -whole-archive -lxenevtchn -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxengnttab-$(MINIOS_TARGET_ARCH) -whole-archive -lxengnttab -no-whole-archive +APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxencall-$(MINIOS_TARGET_ARCH) -whole-archive -lxencall -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxc-$(MINIOS_TARGET_ARCH) -whole-archive -lxenguest -lxenctrl -no-whole-archive endif APP_LDLIBS += -lpci -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Jul 15 15:48:37 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 15 Jul 2015 15:48:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZFOvF-00062R-F3; Wed, 15 Jul 2015 15:48:37 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZFOvC-0005td-Af for minios-devel@lists.xenproject.org; Wed, 15 Jul 2015 15:48:34 +0000 Received: from [85.158.137.68] by server-6.bemta-3.messagelabs.com id BD/E9-13517-1D086A55; Wed, 15 Jul 2015 15:48:33 +0000 X-Env-Sender: prvs=631330d48=Ian.Campbell@citrix.com X-Msg-Ref: server-8.tower-31.messagelabs.com!1436975311!26108812!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 4678 invoked from network); 15 Jul 2015 15:48:32 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-8.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 15 Jul 2015 15:48:32 -0000 X-IronPort-AV: E=Sophos;i="5.15,480,1432598400"; d="scan'208";a="284369232" From: Ian Campbell To: , , Date: Wed, 15 Jul 2015 16:48:24 +0100 Message-ID: <1436975305-13258-4-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1436975173.32371.121.camel@citrix.com> References: <1436975173.32371.121.camel@citrix.com> MIME-Version: 1.0 X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, roger.pau@citrix.com, Ian Campbell , stefano.stabellini@eu.citrix.com Subject: [Minios-devel] [PATCH MINI-OS v2 4/5] mini-os: Include libxencall with libxc X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org libxencall has just been split out from libxc. From mini-os's point of view we don't care about the distinction, so keep things simple by just including libxencall if libxc is enabled. Signed-off-by: Ian Campbell --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 5e67e6c..835c47b 100644 --- a/Makefile +++ b/Makefile @@ -168,6 +168,7 @@ ifeq ($(CONFIG_XC),y) APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxentoollog-$(MINIOS_TARGET_ARCH) -whole-archive -lxentoollog -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxenevtchn-$(MINIOS_TARGET_ARCH) -whole-archive -lxenevtchn -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxengnttab-$(MINIOS_TARGET_ARCH) -whole-archive -lxengnttab -no-whole-archive +APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxencall-$(MINIOS_TARGET_ARCH) -whole-archive -lxencall -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxc-$(MINIOS_TARGET_ARCH) -whole-archive -lxenguest -lxenctrl -no-whole-archive endif APP_LDLIBS += -lpci -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Jul 15 15:48:37 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 15 Jul 2015 15:48:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZFOvF-000635-PL; Wed, 15 Jul 2015 15:48:37 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZFOvD-0005td-NO for minios-devel@lists.xenproject.org; Wed, 15 Jul 2015 15:48:35 +0000 Received: from [85.158.137.68] by server-6.bemta-3.messagelabs.com id 5F/F9-13517-3D086A55; Wed, 15 Jul 2015 15:48:35 +0000 X-Env-Sender: prvs=631330d48=Ian.Campbell@citrix.com X-Msg-Ref: server-8.tower-31.messagelabs.com!1436975311!26108812!2 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 4886 invoked from network); 15 Jul 2015 15:48:34 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-8.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 15 Jul 2015 15:48:34 -0000 X-IronPort-AV: E=Sophos;i="5.15,480,1432598400"; d="scan'208";a="284369238" From: Ian Campbell To: , , Date: Wed, 15 Jul 2015 16:48:25 +0100 Message-ID: <1436975305-13258-5-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1436975173.32371.121.camel@citrix.com> References: <1436975173.32371.121.camel@citrix.com> MIME-Version: 1.0 X-DLP: MIA1 Cc: minios-devel@lists.xenproject.org, roger.pau@citrix.com, Ian Campbell , stefano.stabellini@eu.citrix.com Subject: [Minios-devel] [PATCH MINI-OS v2 5/5] mini-os: Include libxenforeignmemory with libxc X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org libxenforeignmemory has just been split out from libxc. From mini-os's point of view we don't care about the distinction, so keep things simple by just including libxenforeignmemory if libxc is enabled. Signed-off-by: Ian Campbell --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 835c47b..f4e10c0 100644 --- a/Makefile +++ b/Makefile @@ -169,6 +169,7 @@ APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxentoollog-$(MINIOS_TARGET_ARCH) -whole-a APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxenevtchn-$(MINIOS_TARGET_ARCH) -whole-archive -lxenevtchn -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxengnttab-$(MINIOS_TARGET_ARCH) -whole-archive -lxengnttab -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxencall-$(MINIOS_TARGET_ARCH) -whole-archive -lxencall -no-whole-archive +APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxenforeignmemory-$(MINIOS_TARGET_ARCH) -whole-archive -lxenforeignmemory -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxc-$(MINIOS_TARGET_ARCH) -whole-archive -lxenguest -lxenctrl -no-whole-archive endif APP_LDLIBS += -lpci -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Jul 15 15:48:37 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 15 Jul 2015 15:48:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZFOvF-000635-PL; Wed, 15 Jul 2015 15:48:37 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZFOvD-0005td-NO for minios-devel@lists.xenproject.org; Wed, 15 Jul 2015 15:48:35 +0000 Received: from [85.158.137.68] by server-6.bemta-3.messagelabs.com id 5F/F9-13517-3D086A55; Wed, 15 Jul 2015 15:48:35 +0000 X-Env-Sender: prvs=631330d48=Ian.Campbell@citrix.com X-Msg-Ref: server-8.tower-31.messagelabs.com!1436975311!26108812!2 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 4886 invoked from network); 15 Jul 2015 15:48:34 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-8.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 15 Jul 2015 15:48:34 -0000 X-IronPort-AV: E=Sophos;i="5.15,480,1432598400"; d="scan'208";a="284369238" From: Ian Campbell To: , , Date: Wed, 15 Jul 2015 16:48:25 +0100 Message-ID: <1436975305-13258-5-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1436975173.32371.121.camel@citrix.com> References: <1436975173.32371.121.camel@citrix.com> MIME-Version: 1.0 X-DLP: MIA1 Cc: minios-devel@lists.xenproject.org, roger.pau@citrix.com, Ian Campbell , stefano.stabellini@eu.citrix.com Subject: [Minios-devel] [PATCH MINI-OS v2 5/5] mini-os: Include libxenforeignmemory with libxc X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org libxenforeignmemory has just been split out from libxc. From mini-os's point of view we don't care about the distinction, so keep things simple by just including libxenforeignmemory if libxc is enabled. Signed-off-by: Ian Campbell --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 835c47b..f4e10c0 100644 --- a/Makefile +++ b/Makefile @@ -169,6 +169,7 @@ APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxentoollog-$(MINIOS_TARGET_ARCH) -whole-a APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxenevtchn-$(MINIOS_TARGET_ARCH) -whole-archive -lxenevtchn -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxengnttab-$(MINIOS_TARGET_ARCH) -whole-archive -lxengnttab -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxencall-$(MINIOS_TARGET_ARCH) -whole-archive -lxencall -no-whole-archive +APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxenforeignmemory-$(MINIOS_TARGET_ARCH) -whole-archive -lxenforeignmemory -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxc-$(MINIOS_TARGET_ARCH) -whole-archive -lxenguest -lxenctrl -no-whole-archive endif APP_LDLIBS += -lpci -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Jul 15 15:55:54 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 15 Jul 2015 15:55:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZFP2I-0000Tg-KR; Wed, 15 Jul 2015 15:55:54 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZFP04-0008V4-JS for minios-devel@lists.xenproject.org; Wed, 15 Jul 2015 15:53:36 +0000 Received: from [85.158.137.68] by server-7.bemta-3.messagelabs.com id 22/55-06457-FF186A55; Wed, 15 Jul 2015 15:53:35 +0000 X-Env-Sender: prvs=6318a4954=Andrew.Cooper3@citrix.com X-Msg-Ref: server-4.tower-31.messagelabs.com!1436975614!24880285!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 3563 invoked from network); 15 Jul 2015 15:53:35 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-4.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 15 Jul 2015 15:53:35 -0000 X-IronPort-AV: E=Sophos;i="5.15,480,1432598400"; d="scan'208";a="281256669" Message-ID: <55A681EC.2050508@citrix.com> Date: Wed, 15 Jul 2015 16:53:16 +0100 From: Andrew Cooper User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Ian Campbell , xen-devel References: <1436975173.32371.121.camel@citrix.com> In-Reply-To: <1436975173.32371.121.camel@citrix.com> X-DLP: MIA1 X-Mailman-Approved-At: Wed, 15 Jul 2015 15:55:53 +0000 Cc: minios-devel@lists.xenproject.org, Ian Jackson , Roger Pau Monne , Wei Liu , Stefano Stabellini Subject: Re: [Minios-devel] [Xen-devel] [PATCH v2 0/15+5+5] Begin to disentangle libxenctrl and provide some stable libraries X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On 15/07/15 16:46, Ian Campbell wrote: > (this is clearly not 4.6 material, aiming for 4.7) > > In <1431963008.4944.80.camel@citrix.com> I proposed stabilising some > parts of the libxenctrl API/ABI by disaggregating into separate > libraries. > > After the previous proof of concept I have now split out: > * xentoollog > * evtch > * gntdev and gntshr > * hypercalls > * privileged foreign memory mappings > > These represent the core low level functionality which everything else > needs, I think, and so are moving things down into a layer below libxc > (i.e. libxc uses all of these). > > There are 3 series, against xen.git (15 patches), mini-os.git (5 > patches) and qemu-xen-trad.git (5 patches). The patches against xen.git > point to the patches in the other two trees via instructions to update > the relevant Config.mk field. The perils of changing unstable > interfaces! > > NB: minios-devel will only get the mini-os side. > > The code in for all three can be found in: > git://xenbits.xen.org/people/ianc/xen.git libxenctrl-split-v2 > git://xenbits.xen.org/people/ianc/qemu-xen-unstable.git libxenctrl-split-v2 > git://xenbits.xen.org/people/ianc/mini-os.git libxenctrl-split-v2 > > The tip of the xen.git branch contains an extra patch adding a .config > into the tree which should get the correct things for the HEAD of the > branch, but not further back. > > Still to come would be libraries for specific out of tree purposes > (device model, kexec), which would be adding new library at the same > level as libxc I think, rather than underneath, i.e. also using the > libraries split out here, but hopefully not libxenctrl itself. > > The new libraries use linker version-scripts to hopefully make future > ABI changes be possible in a compatible way. > > I'm stilling mulling over putting everything into tools/libs/FOO > instead of tools/libxenFOO On balance, +1. tools/ is already quite a mixed bag of stuff. > , I still haven't but I could if people think > it is worthwhile. Eventually I'd like to split libxc into libxenguest > and libxenctrl to cut down on the amount of strange cross talk... Very much +1. FWIW, also splitting xl and libxl into different directories. ~Andrew _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Jul 15 15:55:54 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 15 Jul 2015 15:55:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZFP2I-0000Tg-KR; Wed, 15 Jul 2015 15:55:54 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZFP04-0008V4-JS for minios-devel@lists.xenproject.org; Wed, 15 Jul 2015 15:53:36 +0000 Received: from [85.158.137.68] by server-7.bemta-3.messagelabs.com id 22/55-06457-FF186A55; Wed, 15 Jul 2015 15:53:35 +0000 X-Env-Sender: prvs=6318a4954=Andrew.Cooper3@citrix.com X-Msg-Ref: server-4.tower-31.messagelabs.com!1436975614!24880285!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 3563 invoked from network); 15 Jul 2015 15:53:35 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-4.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 15 Jul 2015 15:53:35 -0000 X-IronPort-AV: E=Sophos;i="5.15,480,1432598400"; d="scan'208";a="281256669" Message-ID: <55A681EC.2050508@citrix.com> Date: Wed, 15 Jul 2015 16:53:16 +0100 From: Andrew Cooper User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Ian Campbell , xen-devel References: <1436975173.32371.121.camel@citrix.com> In-Reply-To: <1436975173.32371.121.camel@citrix.com> X-DLP: MIA1 X-Mailman-Approved-At: Wed, 15 Jul 2015 15:55:53 +0000 Cc: minios-devel@lists.xenproject.org, Ian Jackson , Roger Pau Monne , Wei Liu , Stefano Stabellini Subject: Re: [Minios-devel] [Xen-devel] [PATCH v2 0/15+5+5] Begin to disentangle libxenctrl and provide some stable libraries X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On 15/07/15 16:46, Ian Campbell wrote: > (this is clearly not 4.6 material, aiming for 4.7) > > In <1431963008.4944.80.camel@citrix.com> I proposed stabilising some > parts of the libxenctrl API/ABI by disaggregating into separate > libraries. > > After the previous proof of concept I have now split out: > * xentoollog > * evtch > * gntdev and gntshr > * hypercalls > * privileged foreign memory mappings > > These represent the core low level functionality which everything else > needs, I think, and so are moving things down into a layer below libxc > (i.e. libxc uses all of these). > > There are 3 series, against xen.git (15 patches), mini-os.git (5 > patches) and qemu-xen-trad.git (5 patches). The patches against xen.git > point to the patches in the other two trees via instructions to update > the relevant Config.mk field. The perils of changing unstable > interfaces! > > NB: minios-devel will only get the mini-os side. > > The code in for all three can be found in: > git://xenbits.xen.org/people/ianc/xen.git libxenctrl-split-v2 > git://xenbits.xen.org/people/ianc/qemu-xen-unstable.git libxenctrl-split-v2 > git://xenbits.xen.org/people/ianc/mini-os.git libxenctrl-split-v2 > > The tip of the xen.git branch contains an extra patch adding a .config > into the tree which should get the correct things for the HEAD of the > branch, but not further back. > > Still to come would be libraries for specific out of tree purposes > (device model, kexec), which would be adding new library at the same > level as libxc I think, rather than underneath, i.e. also using the > libraries split out here, but hopefully not libxenctrl itself. > > The new libraries use linker version-scripts to hopefully make future > ABI changes be possible in a compatible way. > > I'm stilling mulling over putting everything into tools/libs/FOO > instead of tools/libxenFOO On balance, +1. tools/ is already quite a mixed bag of stuff. > , I still haven't but I could if people think > it is worthwhile. Eventually I'd like to split libxc into libxenguest > and libxenctrl to cut down on the amount of strange cross talk... Very much +1. FWIW, also splitting xl and libxl into different directories. ~Andrew _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Sat Jul 18 13:44:30 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Sat, 18 Jul 2015 13:44:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZGSPk-0003ec-Sc; Sat, 18 Jul 2015 13:44:28 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZGSPk-0003eV-3e for minios-devel@lists.xenproject.org; Sat, 18 Jul 2015 13:44:28 +0000 Received: from [193.109.254.147] by server-3.bemta-14.messagelabs.com id E7/08-18676-B385AA55; Sat, 18 Jul 2015 13:44:27 +0000 X-Env-Sender: mihaicristianpirvu@gmail.com X-Msg-Ref: server-3.tower-27.messagelabs.com!1437227064!33130539!1 X-Originating-IP: [209.85.223.179] X-SpamReason: No, hits=1.2 required=7.0 tests=HTML_20_30,HTML_MESSAGE, RCVD_BY_IP X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 1159 invoked from network); 18 Jul 2015 13:44:25 -0000 Received: from mail-ie0-f179.google.com (HELO mail-ie0-f179.google.com) (209.85.223.179) by server-3.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 18 Jul 2015 13:44:25 -0000 Received: by iehx8 with SMTP id x8so12967006ieh.3 for ; Sat, 18 Jul 2015 06:44:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=M89HJZ8DaNRFR5Cj7QQxK/KMi/msJ0scllb/lw1fRJM=; b=mckIC9XIRNfWFT9ETeScSX8QxUlJ2l3ceupmNjIlZF4fh64MpSMPL858YIby6N6vhN VWXLigToZaehgIoApzlAfLRP9UGCjc/Kd8AFUFLSXWXHIoVZsZx4/RXciuC0KOtav/lp d+0N0e0ny9o9yfIUUv52tXUSNlcUVLdKGGcb1aA4vGPCPjj6ZXabUUymrT66UeuNklsM 69t5MZeoG2/2Zdqyxfhzoe3hMFDA2TCOIMWCp8iHE2GmkUhUMXEXhXhs37fPGYpg8xia E1BIjTO97f89SQqhnVVtk0ZmPToY8RPfGVnzl4SwWDgbJbUYfkWd9STLAiiY6mJltFSO o3uA== MIME-Version: 1.0 X-Received: by 10.107.164.196 with SMTP id d65mr25197533ioj.3.1437227064076; Sat, 18 Jul 2015 06:44:24 -0700 (PDT) Received: by 10.107.143.215 with HTTP; Sat, 18 Jul 2015 06:44:24 -0700 (PDT) Date: Sat, 18 Jul 2015 16:44:24 +0300 Message-ID: From: =?UTF-8?B?UMOucnZ1IE1paGFp?= To: minios-devel@lists.xenproject.org Subject: [Minios-devel] Problems with MiniOS and lwIP (daytime server) X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8884754420133430661==" Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org --===============8884754420133430661== Content-Type: multipart/alternative; boundary=001a1141cad69dad0c051b2680df --001a1141cad69dad0c051b2680df Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hello, I want to start by saying that I'm really new with the platform (like 3 days of research), but i stumbled upon a problem i can't fix. I hope this won't be considered spam :) Anyway, my problem is pretty simple probably. I'm trying to access the daytime server, which is ran default when compiling with lwIP I looked inside the source of daytime.c and I saw that the setting up of an IP address is disabled with an "if(0) { ... }" construct, so I changed that and set my ip to: 10.0.2.10/24 like this: .... start_networking(); if (1) { struct ip_addr ipaddr =3D { htonl(0x0a00020A) }; struct ip_addr netmask =3D { htonl(0xffffff00) }; struct ip_addr gw =3D { 0 }; networking_set_addr(&ipaddr, &netmask, &gw); } .... The compiling is fine (though I also have something to say about this, but in the footer of the mail). I start the VM, with xl create domain_config, which looks like this: kernel =3D "mini-os.gz" memory =3D 32 name =3D "Mini-OS" on_crash =3D 'destroy' vif=3D['xenif'] I go into the console, and it all seems fine: ..... mac is 00:16:3e:70:4a:02 ************************** [server] IP 0 netmask 0 gateway 0. [server] TCP/IP bringup begins. Thread "tcpip_thread": pointer: 0x00000000000ca738, stack: 0x0000000000220000 [tcpip_thread] TCP/IP bringup ends. [server] Network is ready. [server] Opening connection [server] Connection at 0000000000042820 This is where I'm lost a little. I try to ping 10.0.2.10 and it works! root@ubuntuZen:/home/mihai/xen/extras/mini-os# ping 10.0.2.10 PING 10.0.2.10 (10.0.2.10) 56(84) bytes of data. 64 bytes from 10.0.2.10: icmp_seq=3D1 ttl=3D255 time=3D0.546 ms 64 bytes from 10.0.2.10: icmp_seq=3D2 ttl=3D255 time=3D0.189 ms 64 bytes from 10.0.2.10: icmp_seq=3D3 ttl=3D255 time=3D0.142 ms 64 bytes from 10.0.2.10: icmp_seq=3D4 ttl=3D255 time=3D0.247 ms But when I try to connect to 10.0.2.10:13 nothing happens. My netcat just hangs, but it hangs on all ports, not just 13. I have to ctrl+c it so it dies, so it's not like the connection is rejected. But, on the console, nothing is printed. I even put a little print code after the session =3D netconn_accept(listener); part, so it shows me when that function has returned a "session", thus the connection is understood, but it never gets there, the function just blocks and never returns. Here's the entire code, if you think I've done something wrong: http://pastebin.com/riuh5n0w I tried to look with nmap, and all ports are closed. Alright, besides that I also have a few other issues. 1. First of all, I couldn't compile mini-os outside of /home/user/xen/extras/mini-os directory. If I want to put my mini-os in /home/user/mini-os and use the enviorment variable XEN_ROOT=3D/home/user/xe= n I get compiling problems when trying to use LWIP. I can compile just fine without it, but when setting the LWIPDIR variable, I get the this: /home/mihai/mini-os/include/netfront.h:4:31: fatal error: lwip/netif/etharp.h: No such file or directory #include If I compile from inside xen/extras/mini-os directory, it works just fine. I'm haven't investigated a lot, but since mini-os is now a separate project from Xen, and this is probably some hardcoded pathing thing, it probably should work to compile, without solving the dependenices on your own, out of the box, from anywhere. 2. I saw that Mini-OS supports lwip1.3.2, but the last version is 1.4.1. I tried using that, but some function headers have been changed, specifically - struct netconn *netconn_accept (struct netconn *) to err_t netconn_accept(struct netconn*, struct netconn**); When I change it in daytime.c, I also get this /home/mihai/lwip-1.4.1//src/core/dhcp.c: In function =E2=80=98dhcp_cleanup= =E2=80=99: /home/mihai/lwip-1.4.1//src/core/dhcp.c:611:5: error: implicit declaration of function =E2=80=98free=E2=80=99 [-Werror=3Dimplicit-function-declaration= ] mem_free(netif->dhcp); I tried to see why in version 1.3.2 caling mem_free is okay, but here calling it calls free, which is "undeclared". Anyway, this isn't really a problem, but I though as a rule of thumb that if you use a library, you should update your code accordingly to the library's updates and it seems like pretty trivial changes for someone who's already a developer for the project. Sorry if the question is 'stupid' or the suggestions are bad, I'm new to both projects (mini os and lwip) and I'm just trying to learn. Mihai --001a1141cad69dad0c051b2680df Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hello, I want to start by saying that I'm really new w= ith the platform (like 3 days of research), but i stumbled upon a problem i= can't fix. I hope this won't be considered spam :)

<= div>Anyway, my problem is pretty simple probably. I'm trying to access = the daytime server, which is ran default when compiling with lwIP=C2=A0

I looked inside the source of daytime.c and I saw tha= t the setting up of an IP address is disabled with an "if(0) { ... }&q= uot; construct, so I changed that and set my ip to: 10.0.2.10/24 like this:

....
=C2=A0 =C2=A0 start_networking();

=C2=A0 = =C2=A0 if (1) {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 struct ip_addr ipaddr= =3D { htonl(0x0a00020A) };
=C2=A0 =C2=A0 =C2=A0 =C2=A0 struct ip= _addr netmask =3D { htonl(0xffffff00) };
=C2=A0 =C2=A0 =C2=A0 =C2= =A0 struct ip_addr gw =3D { 0 };
=C2=A0 =C2=A0 =C2=A0 =C2=A0 netw= orking_set_addr(&ipaddr, &netmask, &gw);
=C2=A0 =C2= =A0 }
....

The compiling is fine (= though I also have something to say about this, but in the footer of the ma= il).

I start the VM, with xl create domain_config,= which looks like this:
kernel =3D "mini-os.gz"
memory =3D 32
name =3D "Mini-OS"
<= div>on_crash =3D 'destroy'
vif=3D['xenif']
<= /div>

I go into the console, and it all seems fine:

.....
mac is 00:16:3e:70:4a:02
**************************
[server] IP 0 netmask 0 gateway 0.
[server] TCP/IP bringup begins.
Thread "tcpip_threa= d": pointer: 0x00000000000ca738, stack: 0x0000000000220000
[= tcpip_thread] TCP/IP bringup ends.
[server] Network is ready.
[server] Opening connection
[server] Connection at 0000000= 000042820


This is where I'= ;m lost a little. I try to ping 10.0.2.10 and it works!

root@ubuntuZen:/home/mihai/xen/extras/mini-os# ping 10.0.2.10
PING 10.0.2.10 (10.0.2.10) 56(84) bytes of data.
64 bytes= from 10.0.2.10: icmp_seq=3D1 ttl=3D255 ti= me=3D0.546 ms
64 bytes from 10.0.2.1= 0: icmp_seq=3D2 ttl=3D255 time=3D0.189 ms
64 bytes from 10.0.2.10: icmp_seq=3D3 ttl=3D255 time=3D0.142 = ms
64 bytes from 10.0.2.10: icmp= _seq=3D4 ttl=3D255 time=3D0.247 ms

But when = I try to connect to 10.0.2.10:13 nothin= g happens.
My netcat just hangs, but it hangs on all ports, not j= ust 13. I have to ctrl+c it so it dies, so it's not like the connection= is rejected. But, on the console, nothing is printed. I even put a little = print code after the=C2=A0

session =3D netconn_acc= ept(listener);=C2=A0

part, so it shows me when tha= t function has returned a "session", thus the connection is under= stood, but it never gets there, the function just blocks and never returns.=

Here's the entire code, if you think I've= done something wrong:=C2=A0http:/= /pastebin.com/riuh5n0w

I tried to look with nm= ap, and all ports are closed.


Alrig= ht, besides that I also have a few other issues.

1= . First of all, I couldn't compile mini-os outside of /home/user/xen/ex= tras/mini-os directory. If I want to put my mini-os in /home/user/mini-os a= nd use the enviorment variable XEN_ROOT=3D/home/user/xen I get compiling pr= oblems when trying to use LWIP. I can compile just fine without it, but whe= n setting the LWIPDIR variable, I get the this:

/home/mihai/mini-os/include/netfront.h:4:31: fatal error: lwip/netif/eth= arp.h: No such file or directory
=C2=A0#include <lwip/netif/et= harp.h>

If I compile from inside xen/extr= as/mini-os directory, it works just fine. I'm haven't investigated = a lot, but since mini-os is now a separate project from Xen, and this is pr= obably some hardcoded pathing thing, it probably should work to compile, wi= thout solving the dependenices on your own, out of the box, from anywhere.<= /div>

2. I saw that Mini-OS supports lwip1.3.2, but the = last version is 1.4.1. I tried using that, but some function headers have b= een changed, specifically=C2=A0

- struct netconn *= netconn_accept (struct netconn *) to err_t netconn_accept(struct netconn*, = struct netconn**);

When I change it in daytime.c, = I also get this=C2=A0

/home/mihai/lwip-1.4.1/= /src/core/dhcp.c: In function =E2=80=98dhcp_cleanup=E2=80=99:
/ho= me/mihai/lwip-1.4.1//src/core/dhcp.c:611:5: error: implicit declaration of = function =E2=80=98free=E2=80=99 [-Werror=3Dimplicit-function-declaration]
=C2=A0 =C2=A0 =C2=A0mem_free(netif->dhcp);

=
I tried to see why in version 1.3.2 caling mem_free is okay, but= here calling it calls free, which is "undeclared". Anyway, this = isn't really a problem, but I though as a rule of thumb that if you use= a library, you should update your code accordingly to the library's up= dates and it seems like pretty trivial changes for someone who's alread= y a developer for the project.


Sorr= y if the question is 'stupid' or the suggestions are bad, I'm n= ew to both projects (mini os and lwip) and I'm just trying to learn.=C2= =A0


Mihai
--001a1141cad69dad0c051b2680df-- --===============8884754420133430661== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel --===============8884754420133430661==-- From minios-devel-bounces@lists.xenproject.org Sat Jul 18 13:44:30 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Sat, 18 Jul 2015 13:44:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZGSPk-0003ec-Sc; Sat, 18 Jul 2015 13:44:28 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZGSPk-0003eV-3e for minios-devel@lists.xenproject.org; Sat, 18 Jul 2015 13:44:28 +0000 Received: from [193.109.254.147] by server-3.bemta-14.messagelabs.com id E7/08-18676-B385AA55; Sat, 18 Jul 2015 13:44:27 +0000 X-Env-Sender: mihaicristianpirvu@gmail.com X-Msg-Ref: server-3.tower-27.messagelabs.com!1437227064!33130539!1 X-Originating-IP: [209.85.223.179] X-SpamReason: No, hits=1.2 required=7.0 tests=HTML_20_30,HTML_MESSAGE, RCVD_BY_IP X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 1159 invoked from network); 18 Jul 2015 13:44:25 -0000 Received: from mail-ie0-f179.google.com (HELO mail-ie0-f179.google.com) (209.85.223.179) by server-3.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 18 Jul 2015 13:44:25 -0000 Received: by iehx8 with SMTP id x8so12967006ieh.3 for ; Sat, 18 Jul 2015 06:44:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=M89HJZ8DaNRFR5Cj7QQxK/KMi/msJ0scllb/lw1fRJM=; b=mckIC9XIRNfWFT9ETeScSX8QxUlJ2l3ceupmNjIlZF4fh64MpSMPL858YIby6N6vhN VWXLigToZaehgIoApzlAfLRP9UGCjc/Kd8AFUFLSXWXHIoVZsZx4/RXciuC0KOtav/lp d+0N0e0ny9o9yfIUUv52tXUSNlcUVLdKGGcb1aA4vGPCPjj6ZXabUUymrT66UeuNklsM 69t5MZeoG2/2Zdqyxfhzoe3hMFDA2TCOIMWCp8iHE2GmkUhUMXEXhXhs37fPGYpg8xia E1BIjTO97f89SQqhnVVtk0ZmPToY8RPfGVnzl4SwWDgbJbUYfkWd9STLAiiY6mJltFSO o3uA== MIME-Version: 1.0 X-Received: by 10.107.164.196 with SMTP id d65mr25197533ioj.3.1437227064076; Sat, 18 Jul 2015 06:44:24 -0700 (PDT) Received: by 10.107.143.215 with HTTP; Sat, 18 Jul 2015 06:44:24 -0700 (PDT) Date: Sat, 18 Jul 2015 16:44:24 +0300 Message-ID: From: =?UTF-8?B?UMOucnZ1IE1paGFp?= To: minios-devel@lists.xenproject.org Subject: [Minios-devel] Problems with MiniOS and lwIP (daytime server) X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8884754420133430661==" Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org --===============8884754420133430661== Content-Type: multipart/alternative; boundary=001a1141cad69dad0c051b2680df --001a1141cad69dad0c051b2680df Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hello, I want to start by saying that I'm really new with the platform (like 3 days of research), but i stumbled upon a problem i can't fix. I hope this won't be considered spam :) Anyway, my problem is pretty simple probably. I'm trying to access the daytime server, which is ran default when compiling with lwIP I looked inside the source of daytime.c and I saw that the setting up of an IP address is disabled with an "if(0) { ... }" construct, so I changed that and set my ip to: 10.0.2.10/24 like this: .... start_networking(); if (1) { struct ip_addr ipaddr =3D { htonl(0x0a00020A) }; struct ip_addr netmask =3D { htonl(0xffffff00) }; struct ip_addr gw =3D { 0 }; networking_set_addr(&ipaddr, &netmask, &gw); } .... The compiling is fine (though I also have something to say about this, but in the footer of the mail). I start the VM, with xl create domain_config, which looks like this: kernel =3D "mini-os.gz" memory =3D 32 name =3D "Mini-OS" on_crash =3D 'destroy' vif=3D['xenif'] I go into the console, and it all seems fine: ..... mac is 00:16:3e:70:4a:02 ************************** [server] IP 0 netmask 0 gateway 0. [server] TCP/IP bringup begins. Thread "tcpip_thread": pointer: 0x00000000000ca738, stack: 0x0000000000220000 [tcpip_thread] TCP/IP bringup ends. [server] Network is ready. [server] Opening connection [server] Connection at 0000000000042820 This is where I'm lost a little. I try to ping 10.0.2.10 and it works! root@ubuntuZen:/home/mihai/xen/extras/mini-os# ping 10.0.2.10 PING 10.0.2.10 (10.0.2.10) 56(84) bytes of data. 64 bytes from 10.0.2.10: icmp_seq=3D1 ttl=3D255 time=3D0.546 ms 64 bytes from 10.0.2.10: icmp_seq=3D2 ttl=3D255 time=3D0.189 ms 64 bytes from 10.0.2.10: icmp_seq=3D3 ttl=3D255 time=3D0.142 ms 64 bytes from 10.0.2.10: icmp_seq=3D4 ttl=3D255 time=3D0.247 ms But when I try to connect to 10.0.2.10:13 nothing happens. My netcat just hangs, but it hangs on all ports, not just 13. I have to ctrl+c it so it dies, so it's not like the connection is rejected. But, on the console, nothing is printed. I even put a little print code after the session =3D netconn_accept(listener); part, so it shows me when that function has returned a "session", thus the connection is understood, but it never gets there, the function just blocks and never returns. Here's the entire code, if you think I've done something wrong: http://pastebin.com/riuh5n0w I tried to look with nmap, and all ports are closed. Alright, besides that I also have a few other issues. 1. First of all, I couldn't compile mini-os outside of /home/user/xen/extras/mini-os directory. If I want to put my mini-os in /home/user/mini-os and use the enviorment variable XEN_ROOT=3D/home/user/xe= n I get compiling problems when trying to use LWIP. I can compile just fine without it, but when setting the LWIPDIR variable, I get the this: /home/mihai/mini-os/include/netfront.h:4:31: fatal error: lwip/netif/etharp.h: No such file or directory #include If I compile from inside xen/extras/mini-os directory, it works just fine. I'm haven't investigated a lot, but since mini-os is now a separate project from Xen, and this is probably some hardcoded pathing thing, it probably should work to compile, without solving the dependenices on your own, out of the box, from anywhere. 2. I saw that Mini-OS supports lwip1.3.2, but the last version is 1.4.1. I tried using that, but some function headers have been changed, specifically - struct netconn *netconn_accept (struct netconn *) to err_t netconn_accept(struct netconn*, struct netconn**); When I change it in daytime.c, I also get this /home/mihai/lwip-1.4.1//src/core/dhcp.c: In function =E2=80=98dhcp_cleanup= =E2=80=99: /home/mihai/lwip-1.4.1//src/core/dhcp.c:611:5: error: implicit declaration of function =E2=80=98free=E2=80=99 [-Werror=3Dimplicit-function-declaration= ] mem_free(netif->dhcp); I tried to see why in version 1.3.2 caling mem_free is okay, but here calling it calls free, which is "undeclared". Anyway, this isn't really a problem, but I though as a rule of thumb that if you use a library, you should update your code accordingly to the library's updates and it seems like pretty trivial changes for someone who's already a developer for the project. Sorry if the question is 'stupid' or the suggestions are bad, I'm new to both projects (mini os and lwip) and I'm just trying to learn. Mihai --001a1141cad69dad0c051b2680df Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hello, I want to start by saying that I'm really new w= ith the platform (like 3 days of research), but i stumbled upon a problem i= can't fix. I hope this won't be considered spam :)

<= div>Anyway, my problem is pretty simple probably. I'm trying to access = the daytime server, which is ran default when compiling with lwIP=C2=A0

I looked inside the source of daytime.c and I saw tha= t the setting up of an IP address is disabled with an "if(0) { ... }&q= uot; construct, so I changed that and set my ip to: 10.0.2.10/24 like this:

....
=C2=A0 =C2=A0 start_networking();

=C2=A0 = =C2=A0 if (1) {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 struct ip_addr ipaddr= =3D { htonl(0x0a00020A) };
=C2=A0 =C2=A0 =C2=A0 =C2=A0 struct ip= _addr netmask =3D { htonl(0xffffff00) };
=C2=A0 =C2=A0 =C2=A0 =C2= =A0 struct ip_addr gw =3D { 0 };
=C2=A0 =C2=A0 =C2=A0 =C2=A0 netw= orking_set_addr(&ipaddr, &netmask, &gw);
=C2=A0 =C2= =A0 }
....

The compiling is fine (= though I also have something to say about this, but in the footer of the ma= il).

I start the VM, with xl create domain_config,= which looks like this:
kernel =3D "mini-os.gz"
memory =3D 32
name =3D "Mini-OS"
<= div>on_crash =3D 'destroy'
vif=3D['xenif']
<= /div>

I go into the console, and it all seems fine:

.....
mac is 00:16:3e:70:4a:02
**************************
[server] IP 0 netmask 0 gateway 0.
[server] TCP/IP bringup begins.
Thread "tcpip_threa= d": pointer: 0x00000000000ca738, stack: 0x0000000000220000
[= tcpip_thread] TCP/IP bringup ends.
[server] Network is ready.
[server] Opening connection
[server] Connection at 0000000= 000042820


This is where I'= ;m lost a little. I try to ping 10.0.2.10 and it works!

root@ubuntuZen:/home/mihai/xen/extras/mini-os# ping 10.0.2.10
PING 10.0.2.10 (10.0.2.10) 56(84) bytes of data.
64 bytes= from 10.0.2.10: icmp_seq=3D1 ttl=3D255 ti= me=3D0.546 ms
64 bytes from 10.0.2.1= 0: icmp_seq=3D2 ttl=3D255 time=3D0.189 ms
64 bytes from 10.0.2.10: icmp_seq=3D3 ttl=3D255 time=3D0.142 = ms
64 bytes from 10.0.2.10: icmp= _seq=3D4 ttl=3D255 time=3D0.247 ms

But when = I try to connect to 10.0.2.10:13 nothin= g happens.
My netcat just hangs, but it hangs on all ports, not j= ust 13. I have to ctrl+c it so it dies, so it's not like the connection= is rejected. But, on the console, nothing is printed. I even put a little = print code after the=C2=A0

session =3D netconn_acc= ept(listener);=C2=A0

part, so it shows me when tha= t function has returned a "session", thus the connection is under= stood, but it never gets there, the function just blocks and never returns.=

Here's the entire code, if you think I've= done something wrong:=C2=A0http:/= /pastebin.com/riuh5n0w

I tried to look with nm= ap, and all ports are closed.


Alrig= ht, besides that I also have a few other issues.

1= . First of all, I couldn't compile mini-os outside of /home/user/xen/ex= tras/mini-os directory. If I want to put my mini-os in /home/user/mini-os a= nd use the enviorment variable XEN_ROOT=3D/home/user/xen I get compiling pr= oblems when trying to use LWIP. I can compile just fine without it, but whe= n setting the LWIPDIR variable, I get the this:

/home/mihai/mini-os/include/netfront.h:4:31: fatal error: lwip/netif/eth= arp.h: No such file or directory
=C2=A0#include <lwip/netif/et= harp.h>

If I compile from inside xen/extr= as/mini-os directory, it works just fine. I'm haven't investigated = a lot, but since mini-os is now a separate project from Xen, and this is pr= obably some hardcoded pathing thing, it probably should work to compile, wi= thout solving the dependenices on your own, out of the box, from anywhere.<= /div>

2. I saw that Mini-OS supports lwip1.3.2, but the = last version is 1.4.1. I tried using that, but some function headers have b= een changed, specifically=C2=A0

- struct netconn *= netconn_accept (struct netconn *) to err_t netconn_accept(struct netconn*, = struct netconn**);

When I change it in daytime.c, = I also get this=C2=A0

/home/mihai/lwip-1.4.1/= /src/core/dhcp.c: In function =E2=80=98dhcp_cleanup=E2=80=99:
/ho= me/mihai/lwip-1.4.1//src/core/dhcp.c:611:5: error: implicit declaration of = function =E2=80=98free=E2=80=99 [-Werror=3Dimplicit-function-declaration]
=C2=A0 =C2=A0 =C2=A0mem_free(netif->dhcp);

=
I tried to see why in version 1.3.2 caling mem_free is okay, but= here calling it calls free, which is "undeclared". Anyway, this = isn't really a problem, but I though as a rule of thumb that if you use= a library, you should update your code accordingly to the library's up= dates and it seems like pretty trivial changes for someone who's alread= y a developer for the project.


Sorr= y if the question is 'stupid' or the suggestions are bad, I'm n= ew to both projects (mini os and lwip) and I'm just trying to learn.=C2= =A0


Mihai
--001a1141cad69dad0c051b2680df-- --===============8884754420133430661== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel --===============8884754420133430661==-- From minios-devel-bounces@lists.xenproject.org Wed Jul 22 11:12:47 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 22 Jul 2015 11:12:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZHrx7-0000pQ-VJ; Wed, 22 Jul 2015 11:12:45 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZHrx6-0000p9-AX for minios-devel@lists.xenproject.org; Wed, 22 Jul 2015 11:12:44 +0000 Received: from [85.158.137.68] by server-9.bemta-3.messagelabs.com id E9/2D-17050-BAA7FA55; Wed, 22 Jul 2015 11:12:43 +0000 X-Env-Sender: prvs=638d64336=Ian.Campbell@citrix.com X-Msg-Ref: server-3.tower-31.messagelabs.com!1437563561!28247649!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 8935 invoked from network); 22 Jul 2015 11:12:42 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-3.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 22 Jul 2015 11:12:42 -0000 X-IronPort-AV: E=Sophos;i="5.15,523,1432598400"; d="scan'208";a="283262348" Message-ID: <1437563556.12884.32.camel@citrix.com> From: Ian Campbell To: Andrew Cooper , xen-devel Date: Wed, 22 Jul 2015 12:12:36 +0100 In-Reply-To: <55A681EC.2050508@citrix.com> References: <1436975173.32371.121.camel@citrix.com> <55A681EC.2050508@citrix.com> X-Mailer: Evolution 3.16.3-1 MIME-Version: 1.0 X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, Ian Jackson , Roger Pau Monne , Wei Liu , Stefano Stabellini Subject: Re: [Minios-devel] [Xen-devel] [PATCH v2 0/15+5+5] Begin to disentangle libxenctrl and provide some stable libraries X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Wed, 2015-07-15 at 16:53 +0100, Andrew Cooper wrote: > > > I'm stilling mulling over putting everything into tools/libs/FOO > > instead of tools/libxenFOO > > On balance, +1. tools/ is already quite a mixed bag of stuff. OK, I think I'm going to go ahead with this. > > , I still haven't but I could if people think > > it is worthwhile. Eventually I'd like to split libxc into > > libxenguest > > and libxenctrl to cut down on the amount of strange cross talk... > > Very much +1. OK (eventually ;-)) > FWIW, also splitting xl and libxl into different directories. Yes, good idea (also "eventually ;-)"). While I'm accumulating TODO items in this thread, every library which gets split out needs a careful review before it should be declared A[PBI] stable. I'm thinking at least: * Consistent error handling (return -1 + setting errno=EFOO) * Correct types * Const correctness * General interface sanity check Anything else? Ian. _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Jul 22 11:12:47 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 22 Jul 2015 11:12:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZHrx7-0000pQ-VJ; Wed, 22 Jul 2015 11:12:45 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZHrx6-0000p9-AX for minios-devel@lists.xenproject.org; Wed, 22 Jul 2015 11:12:44 +0000 Received: from [85.158.137.68] by server-9.bemta-3.messagelabs.com id E9/2D-17050-BAA7FA55; Wed, 22 Jul 2015 11:12:43 +0000 X-Env-Sender: prvs=638d64336=Ian.Campbell@citrix.com X-Msg-Ref: server-3.tower-31.messagelabs.com!1437563561!28247649!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 8935 invoked from network); 22 Jul 2015 11:12:42 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-3.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 22 Jul 2015 11:12:42 -0000 X-IronPort-AV: E=Sophos;i="5.15,523,1432598400"; d="scan'208";a="283262348" Message-ID: <1437563556.12884.32.camel@citrix.com> From: Ian Campbell To: Andrew Cooper , xen-devel Date: Wed, 22 Jul 2015 12:12:36 +0100 In-Reply-To: <55A681EC.2050508@citrix.com> References: <1436975173.32371.121.camel@citrix.com> <55A681EC.2050508@citrix.com> X-Mailer: Evolution 3.16.3-1 MIME-Version: 1.0 X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, Ian Jackson , Roger Pau Monne , Wei Liu , Stefano Stabellini Subject: Re: [Minios-devel] [Xen-devel] [PATCH v2 0/15+5+5] Begin to disentangle libxenctrl and provide some stable libraries X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Wed, 2015-07-15 at 16:53 +0100, Andrew Cooper wrote: > > > I'm stilling mulling over putting everything into tools/libs/FOO > > instead of tools/libxenFOO > > On balance, +1. tools/ is already quite a mixed bag of stuff. OK, I think I'm going to go ahead with this. > > , I still haven't but I could if people think > > it is worthwhile. Eventually I'd like to split libxc into > > libxenguest > > and libxenctrl to cut down on the amount of strange cross talk... > > Very much +1. OK (eventually ;-)) > FWIW, also splitting xl and libxl into different directories. Yes, good idea (also "eventually ;-)"). While I'm accumulating TODO items in this thread, every library which gets split out needs a careful review before it should be declared A[PBI] stable. I'm thinking at least: * Consistent error handling (return -1 + setting errno=EFOO) * Correct types * Const correctness * General interface sanity check Anything else? Ian. _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Jul 22 12:58:47 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 22 Jul 2015 12:58:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZHtbh-00022H-SO; Wed, 22 Jul 2015 12:58:45 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZHtbg-000226-Ti for minios-devel@lists.xenproject.org; Wed, 22 Jul 2015 12:58:45 +0000 Received: from [193.109.254.147] by server-15.bemta-14.messagelabs.com id 58/D9-18947-3839FA55; Wed, 22 Jul 2015 12:58:43 +0000 X-Env-Sender: prvs=6381c0ebe=Andrew.Cooper3@citrix.com X-Msg-Ref: server-10.tower-27.messagelabs.com!1437569921!34245133!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 32124 invoked from network); 22 Jul 2015 12:58:43 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-10.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 22 Jul 2015 12:58:43 -0000 X-IronPort-AV: E=Sophos;i="5.15,523,1432598400"; d="scan'208";a="286452909" Message-ID: <55AF935E.3080605@citrix.com> Date: Wed, 22 Jul 2015 13:58:06 +0100 From: Andrew Cooper User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Ian Campbell , xen-devel References: <1436975173.32371.121.camel@citrix.com> <55A681EC.2050508@citrix.com> <1437563556.12884.32.camel@citrix.com> In-Reply-To: <1437563556.12884.32.camel@citrix.com> X-DLP: MIA1 Cc: minios-devel@lists.xenproject.org, Ian Jackson , Roger Pau Monne , Wei Liu , Stefano Stabellini Subject: Re: [Minios-devel] [Xen-devel] [PATCH v2 0/15+5+5] Begin to disentangle libxenctrl and provide some stable libraries X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On 22/07/15 12:12, Ian Campbell wrote: > >> FWIW, also splitting xl and libxl into different directories. > Yes, good idea (also "eventually ;-)"). > > While I'm accumulating TODO items in this thread, every library which > gets split out needs a careful review before it should be declared > A[PBI] stable. I'm thinking at least: > > * Consistent error handling (return -1 + setting errno=EFOO) > * Correct types > * Const correctness > * General interface sanity check > > Anything else? If we are filling even more copious free time, * Thoughts about documentation in the header files. I think a suitably-configured doxygen ought to suffice for this. (I feel like I am nominating myself to try and get this sorted in a satisfactory fashon.) ~Andrew _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Jul 22 12:58:47 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 22 Jul 2015 12:58:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZHtbh-00022H-SO; Wed, 22 Jul 2015 12:58:45 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZHtbg-000226-Ti for minios-devel@lists.xenproject.org; Wed, 22 Jul 2015 12:58:45 +0000 Received: from [193.109.254.147] by server-15.bemta-14.messagelabs.com id 58/D9-18947-3839FA55; Wed, 22 Jul 2015 12:58:43 +0000 X-Env-Sender: prvs=6381c0ebe=Andrew.Cooper3@citrix.com X-Msg-Ref: server-10.tower-27.messagelabs.com!1437569921!34245133!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 32124 invoked from network); 22 Jul 2015 12:58:43 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-10.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 22 Jul 2015 12:58:43 -0000 X-IronPort-AV: E=Sophos;i="5.15,523,1432598400"; d="scan'208";a="286452909" Message-ID: <55AF935E.3080605@citrix.com> Date: Wed, 22 Jul 2015 13:58:06 +0100 From: Andrew Cooper User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Ian Campbell , xen-devel References: <1436975173.32371.121.camel@citrix.com> <55A681EC.2050508@citrix.com> <1437563556.12884.32.camel@citrix.com> In-Reply-To: <1437563556.12884.32.camel@citrix.com> X-DLP: MIA1 Cc: minios-devel@lists.xenproject.org, Ian Jackson , Roger Pau Monne , Wei Liu , Stefano Stabellini Subject: Re: [Minios-devel] [Xen-devel] [PATCH v2 0/15+5+5] Begin to disentangle libxenctrl and provide some stable libraries X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On 22/07/15 12:12, Ian Campbell wrote: > >> FWIW, also splitting xl and libxl into different directories. > Yes, good idea (also "eventually ;-)"). > > While I'm accumulating TODO items in this thread, every library which > gets split out needs a careful review before it should be declared > A[PBI] stable. I'm thinking at least: > > * Consistent error handling (return -1 + setting errno=EFOO) > * Correct types > * Const correctness > * General interface sanity check > > Anything else? If we are filling even more copious free time, * Thoughts about documentation in the header files. I think a suitably-configured doxygen ought to suffice for this. (I feel like I am nominating myself to try and get this sorted in a satisfactory fashon.) ~Andrew _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Jul 22 13:05:25 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 22 Jul 2015 13:05:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZHti9-0002Sc-49; Wed, 22 Jul 2015 13:05:25 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZHti7-0002SR-Fj for minios-devel@lists.xenproject.org; Wed, 22 Jul 2015 13:05:23 +0000 Received: from [193.109.254.147] by server-14.bemta-14.messagelabs.com id 0C/24-21300-2159FA55; Wed, 22 Jul 2015 13:05:22 +0000 X-Env-Sender: prvs=638d64336=Ian.Campbell@citrix.com X-Msg-Ref: server-12.tower-27.messagelabs.com!1437570320!34329679!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 16899 invoked from network); 22 Jul 2015 13:05:22 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-12.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 22 Jul 2015 13:05:22 -0000 X-IronPort-AV: E=Sophos;i="5.15,523,1432598400"; d="scan'208";a="286456372" Message-ID: <1437570318.12884.52.camel@citrix.com> From: Ian Campbell To: Andrew Cooper , xen-devel Date: Wed, 22 Jul 2015 14:05:18 +0100 In-Reply-To: <55AF935E.3080605@citrix.com> References: <1436975173.32371.121.camel@citrix.com> <55A681EC.2050508@citrix.com> <1437563556.12884.32.camel@citrix.com> <55AF935E.3080605@citrix.com> X-Mailer: Evolution 3.16.3-1 MIME-Version: 1.0 X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, Ian Jackson , Roger Pau Monne , Wei Liu , Stefano Stabellini Subject: Re: [Minios-devel] [Xen-devel] [PATCH v2 0/15+5+5] Begin to disentangle libxenctrl and provide some stable libraries X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Wed, 2015-07-22 at 13:58 +0100, Andrew Cooper wrote: > On 22/07/15 12:12, Ian Campbell wrote: > > > > > FWIW, also splitting xl and libxl into different directories. > > Yes, good idea (also "eventually ;-)"). > > > > While I'm accumulating TODO items in this thread, every library > > which > > gets split out needs a careful review before it should be declared > > A[PBI] stable. I'm thinking at least: > > > > * Consistent error handling (return -1 + setting errno=EFOO) > > * Correct types > > * Const correctness > > * General interface sanity check > > > > Anything else? > > If we are filling even more copious free time, > > * Thoughts about documentation in the header files. Yes, I think that would be good. As it happens the stuff being stripped out is from among the better documented bits of libxc. Surely not perfect though. > I think a suitably-configured doxygen ought to suffice for this. (I > feel like I am nominating myself to try and get this sorted in a > satisfactory fashon.) I think this is rather secondary to accurate comments existing in the header in some form. Perhaps rather than doing any work up front it would be better to point us to an existing example of something produced by what you consider a suitable-configured doxygen so we can see if we agree? Ian. _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Jul 22 13:05:25 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 22 Jul 2015 13:05:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZHti9-0002Sc-49; Wed, 22 Jul 2015 13:05:25 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZHti7-0002SR-Fj for minios-devel@lists.xenproject.org; Wed, 22 Jul 2015 13:05:23 +0000 Received: from [193.109.254.147] by server-14.bemta-14.messagelabs.com id 0C/24-21300-2159FA55; Wed, 22 Jul 2015 13:05:22 +0000 X-Env-Sender: prvs=638d64336=Ian.Campbell@citrix.com X-Msg-Ref: server-12.tower-27.messagelabs.com!1437570320!34329679!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 16899 invoked from network); 22 Jul 2015 13:05:22 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-12.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 22 Jul 2015 13:05:22 -0000 X-IronPort-AV: E=Sophos;i="5.15,523,1432598400"; d="scan'208";a="286456372" Message-ID: <1437570318.12884.52.camel@citrix.com> From: Ian Campbell To: Andrew Cooper , xen-devel Date: Wed, 22 Jul 2015 14:05:18 +0100 In-Reply-To: <55AF935E.3080605@citrix.com> References: <1436975173.32371.121.camel@citrix.com> <55A681EC.2050508@citrix.com> <1437563556.12884.32.camel@citrix.com> <55AF935E.3080605@citrix.com> X-Mailer: Evolution 3.16.3-1 MIME-Version: 1.0 X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, Ian Jackson , Roger Pau Monne , Wei Liu , Stefano Stabellini Subject: Re: [Minios-devel] [Xen-devel] [PATCH v2 0/15+5+5] Begin to disentangle libxenctrl and provide some stable libraries X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Wed, 2015-07-22 at 13:58 +0100, Andrew Cooper wrote: > On 22/07/15 12:12, Ian Campbell wrote: > > > > > FWIW, also splitting xl and libxl into different directories. > > Yes, good idea (also "eventually ;-)"). > > > > While I'm accumulating TODO items in this thread, every library > > which > > gets split out needs a careful review before it should be declared > > A[PBI] stable. I'm thinking at least: > > > > * Consistent error handling (return -1 + setting errno=EFOO) > > * Correct types > > * Const correctness > > * General interface sanity check > > > > Anything else? > > If we are filling even more copious free time, > > * Thoughts about documentation in the header files. Yes, I think that would be good. As it happens the stuff being stripped out is from among the better documented bits of libxc. Surely not perfect though. > I think a suitably-configured doxygen ought to suffice for this. (I > feel like I am nominating myself to try and get this sorted in a > satisfactory fashon.) I think this is rather secondary to accurate comments existing in the header in some form. Perhaps rather than doing any work up front it would be better to point us to an existing example of something produced by what you consider a suitable-configured doxygen so we can see if we agree? Ian. _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Thu Jul 23 10:03:34 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 23 Jul 2015 10:03:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZIDLh-0003Y3-Ps; Thu, 23 Jul 2015 10:03:33 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZIDLg-0003Xt-1q for Minios-devel@lists.xenproject.org; Thu, 23 Jul 2015 10:03:32 +0000 Received: from [193.109.254.147] by server-7.bemta-14.messagelabs.com id 1E/5D-01469-3FBB0B55; Thu, 23 Jul 2015 10:03:31 +0000 X-Env-Sender: talex5@gmail.com X-Msg-Ref: server-15.tower-27.messagelabs.com!1437645809!34580779!1 X-Originating-IP: [209.85.212.182] X-SpamReason: No, hits=0.5 required=7.0 tests=BODY_RANDOM_LONG, UPPERCASE_25_50 X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 7644 invoked from network); 23 Jul 2015 10:03:30 -0000 Received: from mail-wi0-f182.google.com (HELO mail-wi0-f182.google.com) (209.85.212.182) by server-15.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 23 Jul 2015 10:03:30 -0000 Received: by wibxm9 with SMTP id xm9so200765843wib.0 for ; Thu, 23 Jul 2015 03:03:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=WjPW7ZcKQ7aiDqvhJDqj0Wk8kPJDg2ayjbDkfgHSPmw=; b=UOd5eU753K5dD2xkq2kPZ/KnI6lfZ01/1QchlDUq3ZTAlXvsPi+Xb9V70nKp0YPKcR Z2+bOiAA9WTALNg3OfKRebklhDsaLlMHHqhl8eg7LGUbB4jYvZ0RJYTtd2WcVwWH2f+n Xa25OI9raXGlASCe5TVoPrZQEP41ubXiddNbccmtl4OFt+wwk2FjftYzKRSwTFxY0W2t xz5udCwED+6XajWp8RjDrzFLQfy6V6sEI2DgD1xvlMtX38Rstzz9P9ZsRud/4tOLlguy 0e6Ik0vHzQ7X+9MzDsJTIuV5iZanV34x1myEiLVCuR1MGdKd7G2H0tzIknmKIlnzwgEx GA4w== X-Received: by 10.194.187.170 with SMTP id ft10mr14095169wjc.26.1437645809793; Thu, 23 Jul 2015 03:03:29 -0700 (PDT) Received: from cam.localdomain (82-69-101-169.dsl.in-addr.zen.co.uk. [82.69.101.169]) by smtp.gmail.com with ESMTPSA id ft5sm26370659wib.4.2015.07.23.03.03.28 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 23 Jul 2015 03:03:29 -0700 (PDT) From: Thomas Leonard To: Minios-devel@lists.xenproject.org Date: Thu, 23 Jul 2015 11:08:39 +0100 Message-Id: <1437646119-32175-3-git-send-email-talex5@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <1437646119-32175-1-git-send-email-talex5@gmail.com> References: <1437646119-32175-1-git-send-email-talex5@gmail.com> Cc: Thomas Leonard , Ian.Campbell@citrix.com, anil@recoil.org, karim.allah.ahmed@gmail.com, stefano.stabellini@eu.citrix.com, samuel.thibault@ens-lyon.org, Dave.Scott@eu.citrix.com Subject: [Minios-devel] [PATCH ARM v10 2/2] arm: build system X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Based on an initial patch by Karim Raslan. This activates the ARM code added in the previous patches. On ARM, Mini-OS will boot and display some output on the console. Tested with: make XEN_TARGET_ARCH=arm32 CROSS_COMPILE=arm-linux-gnueabihf- \ CONFIG_TEST=y CONFIG_START_NETWORK=n CONFIG_BLKFRONT=n \ CONFIG_NETFRONT=n CONFIG_FBFRONT=n CONFIG_KBDFRONT=n \ CONFIG_CONSFRONT=n CONFIG_XC=n -j4 The memmove implementation is from FreeBSD's contrib/ldns/compat/memmove.c (r246827). Signed-off-by: Karim Allah Ahmed Signed-off-by: Thomas Leonard --- Same as v9. Note that COPYING contains the BSD license needed for memmove. --- .gitmodules | 3 +++ COPYING | 27 +++++++++++++++++++++++++++ Config.mk | 2 ++ Makefile | 27 ++++++++++++++++++++++++++- arch/arm/Makefile | 35 +++++++++++++++++++++++++++++++++++ arch/arm/arch.mk | 6 ++++++ dtc | 1 + include/lib.h | 4 +++- include/libfdt_env.h | 33 +++++++++++++++++++++++++++++++++ lib/memmove.c | 45 +++++++++++++++++++++++++++++++++++++++++++++ lib/string.c | 12 ++++++++++++ 11 files changed, 193 insertions(+), 2 deletions(-) create mode 100644 .gitmodules create mode 100755 arch/arm/Makefile create mode 100644 arch/arm/arch.mk create mode 160000 dtc create mode 100644 include/libfdt_env.h create mode 100644 lib/memmove.c diff --git a/.gitmodules b/.gitmodules new file mode 100644 index 0000000..221102d --- /dev/null +++ b/.gitmodules @@ -0,0 +1,3 @@ +[submodule "dtc"] + path = dtc + url = git://git.kernel.org/pub/scm/utils/dtc/dtc.git diff --git a/COPYING b/COPYING index 1d9df6c..b676bb6 100644 --- a/COPYING +++ b/COPYING @@ -34,3 +34,30 @@ LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +Copyright (c) 2005,2006, NLnetLabs +All rights reserved. + +Redistribution and use in source and binary forms, with or without +modification, are permitted provided that the following conditions are met: + + * Redistributions of source code must retain the above copyright notice, + this list of conditions and the following disclaimer. + * Redistributions in binary form must reproduce the above copyright + notice, this list of conditions and the following disclaimer in the + documentation and/or other materials provided with the distribution. + * Neither the name of NLnetLabs nor the names of its + contributors may be used to endorse or promote products derived from this + software without specific prior written permission. + +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" +AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE +IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE +ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE +LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR +CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF +SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS +INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN +CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) +ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE +POSSIBILITY OF SUCH DAMAGE. diff --git a/Config.mk b/Config.mk index e5d8ade..eb53f2d 100644 --- a/Config.mk +++ b/Config.mk @@ -54,6 +54,8 @@ export XEN_INTERFACE_VERSION # If not x86 then use $(MINIOS_TARGET_ARCH) ifeq ($(findstring x86_,$(MINIOS_TARGET_ARCH)),x86_) TARGET_ARCH_FAM = x86 +else ifeq ($(findstring arm,$(MINIOS_TARGET_ARCH)),arm) +TARGET_ARCH_FAM = arm else TARGET_ARCH_FAM = $(MINIOS_TARGET_ARCH) endif diff --git a/Makefile b/Makefile index 2cb5e51..d06fc3b 100644 --- a/Makefile +++ b/Makefile @@ -54,8 +54,15 @@ DEF_CFLAGS += $(flags-y) # Symlinks and headers that must be created before building the C files GENERATED_HEADERS := include/list.h $(ARCH_LINKS) include/mini-os include/$(TARGET_ARCH_FAM)/mini-os +ifeq ($(MINIOS_TARGET_ARCH),arm32) +GENERATED_HEADERS += include/fdt.h include/libfdt.h +endif + EXTRA_DEPS += $(GENERATED_HEADERS) +include/%.h: dtc/libfdt/%.h + ln -s ../$^ $@ + # Include common mini-os makerules. include minios.mk @@ -76,7 +83,18 @@ EXTRA_OBJS = TARGET := mini-os # Subdirectories common to mini-os -SUBDIRS := lib xenbus console +SUBDIRS := lib xenbus console dtc/libfdt + +FDT_SRC := +ifeq ($(MINIOS_TARGET_ARCH),arm32) +# Need libgcc.a for division helpers +LDLIBS += `$(CC) -print-libgcc-file-name` + +# Device tree support +FDT_SRC := dtc/libfdt/fdt.c dtc/libfdt/fdt_ro.c dtc/libfdt/fdt_strerror.c + +src-y += ${FDT_SRC} +endif src-$(CONFIG_BLKFRONT) += blkfront.c src-$(CONFIG_TPMFRONT) += tpmfront.c @@ -98,10 +116,13 @@ src-y += sched.c src-$(CONFIG_TEST) += test.c src-y += lib/ctype.c +ifneq ($(MINIOS_TARGET_ARCH),arm32) src-y += lib/math.c +endif src-y += lib/printf.c src-y += lib/stack_chk_fail.c src-y += lib/string.c +src-y += lib/memmove.c src-y += lib/sys.c src-y += lib/xmalloc.c src-$(CONFIG_XENBUS) += lib/xs.c @@ -188,7 +209,11 @@ $(OBJ_DIR)/$(TARGET): $(OBJS) $(APP_O) arch_lib $(LD) -r $(LDFLAGS) $(HEAD_OBJ) $(APP_O) $(OBJS) $(LDARCHLIB) $(LDLIBS) -o $@.o $(OBJCOPY) -w -G $(GLOBAL_PREFIX)* -G _start $@.o $@.o $(LD) $(LDFLAGS) $(LDFLAGS_FINAL) $@.o $(EXTRA_OBJS) -o $@ +ifeq ($(MINIOS_TARGET_ARCH),arm32) + $(OBJCOPY) -O binary $@ $@.img +else gzip -f -9 -c $@ >$@.gz +endif .PHONY: clean arch_clean diff --git a/arch/arm/Makefile b/arch/arm/Makefile new file mode 100755 index 0000000..e018dad --- /dev/null +++ b/arch/arm/Makefile @@ -0,0 +1,35 @@ +# +# ARM architecture specific makefiles. +# + +TOPLEVEL_DIR = $(CURDIR)/../.. +OBJ_DIR=$(CURDIR) +include ../../Config.mk + +# include arch.mk has to be before minios.mk! + +include arch.mk +include ../../minios.mk + +include $(MINI-OS_ROOT)/config/MiniOS.mk + + +# Sources here are all *.c (without $(MINIOS_TARGET_ARCH).S) +# This is handled in $(HEAD_ARCH_OBJ) +ARCH_SRCS := $(wildcard *.c) + +# The objects built from the sources. +ARCH_OBJS := $(patsubst %.c,$(OBJ_DIR)/%.o,$(ARCH_SRCS)) + +ARCH_OBJS += $(OBJ_DIR)/hypercalls32.o + +all: $(OBJ_DIR)/$(ARCH_LIB) + +# $(HEAD_ARCH_OBJ) is only built here, needed on linking +# in ../../Makefile. +$(OBJ_DIR)/$(ARCH_LIB): $(ARCH_OBJS) $(OBJ_DIR)/$(HEAD_ARCH_OBJ) + $(AR) rv $(OBJ_DIR)/$(ARCH_LIB) $(ARCH_OBJS) + +clean: + rm -f $(OBJ_DIR)/$(ARCH_LIB) $(ARCH_OBJS) $(OBJ_DIR)/$(HEAD_ARCH_OBJ) + diff --git a/arch/arm/arch.mk b/arch/arm/arch.mk new file mode 100644 index 0000000..b4cb65b --- /dev/null +++ b/arch/arm/arch.mk @@ -0,0 +1,6 @@ +ifeq ($(MINIOS_TARGET_ARCH),arm32) +DEF_ASFLAGS += -march=armv7-a -mfpu=vfpv3 +ARCH_CFLAGS := -march=armv7-a -marm -fms-extensions -D__arm__ -DXEN_HAVE_PV_GUEST_ENTRY #-DCPU_EXCLUSIVE_LDST +EXTRA_INC += $(TARGET_ARCH_FAM)/$(MINIOS_TARGET_ARCH) +EXTRA_SRC += arch/$(EXTRA_INC) +endif diff --git a/dtc b/dtc new file mode 160000 index 0000000..64c46b0 --- /dev/null +++ b/dtc @@ -0,0 +1 @@ +Subproject commit 64c46b098b969502a74c8b0fd97e6f5e4aa07e21 diff --git a/include/lib.h b/include/lib.h index 62836c7..326e39f 100644 --- a/include/lib.h +++ b/include/lib.h @@ -95,6 +95,7 @@ char *strncpy(char * __restrict, const char * __restrict, size_t); char *strstr(const char *, const char *); +void *memmove(void *, const void *, size_t); void *memset(void *, int, size_t); char *strchr(const char *p, int ch); @@ -104,7 +105,8 @@ char *strrchr(const char *p, int ch); * @(#)systm.h 8.7 (Berkeley) 3/29/95 * $FreeBSD$ */ -void *memcpy(void *to, const void *from, size_t len); +void *memcpy(void *to, const void *from, size_t len); +void *memchr(const void *s, int c, size_t n); size_t strnlen(const char *, size_t); #endif diff --git a/include/libfdt_env.h b/include/libfdt_env.h new file mode 100644 index 0000000..722fac6 --- /dev/null +++ b/include/libfdt_env.h @@ -0,0 +1,33 @@ +#ifndef _LIBFDT_ENV_H +#define _LIBFDT_ENV_H + +#include +#include +#include + +typedef uint16_t fdt16_t; +typedef uint32_t fdt32_t; +typedef uint64_t fdt64_t; + +#define EXTRACT_BYTE(n) ((unsigned long long)((uint8_t *)&x)[n]) +static inline uint16_t fdt16_to_cpu(uint16_t x) +{ + return (EXTRACT_BYTE(0) << 8) | EXTRACT_BYTE(1); +} +#define cpu_to_fdt16(x) fdt16_to_cpu(x) + +static inline uint32_t fdt32_to_cpu(uint32_t x) +{ + return (EXTRACT_BYTE(0) << 24) | (EXTRACT_BYTE(1) << 16) | (EXTRACT_BYTE(2) << 8) | EXTRACT_BYTE(3); +} +#define cpu_to_fdt32(x) fdt32_to_cpu(x) + +static inline uint64_t fdt64_to_cpu(uint64_t x) +{ + return (EXTRACT_BYTE(0) << 56) | (EXTRACT_BYTE(1) << 48) | (EXTRACT_BYTE(2) << 40) | (EXTRACT_BYTE(3) << 32) + | (EXTRACT_BYTE(4) << 24) | (EXTRACT_BYTE(5) << 16) | (EXTRACT_BYTE(6) << 8) | EXTRACT_BYTE(7); +} +#define cpu_to_fdt64(x) fdt64_to_cpu(x) +#undef EXTRACT_BYTE + +#endif /* _LIBFDT_ENV_H */ diff --git a/lib/memmove.c b/lib/memmove.c new file mode 100644 index 0000000..0298b7c --- /dev/null +++ b/lib/memmove.c @@ -0,0 +1,45 @@ +/* + * memmove.c: memmove compat implementation. + * + * Copyright (c) 2001-2008, NLnet Labs. All rights reserved. + * + * See COPYING for the license. +*/ + +#include +#include + +#ifndef HAVE_LIBC + +void *memmove(void *dest, const void *src, size_t n) +{ + uint8_t* from = (uint8_t*) src; + uint8_t* to = (uint8_t*) dest; + + if (from == to || n == 0) + return dest; + if (to > from && to-from < (int)n) { + /* to overlaps with from */ + /* */ + /* */ + /* copy in reverse, to avoid overwriting from */ + int i; + for(i=n-1; i>=0; i--) + to[i] = from[i]; + return dest; + } + if (from > to && from-to < (int)n) { + /* to overlaps with from */ + /* */ + /* */ + /* copy forwards, to avoid overwriting from */ + size_t i; + for(i=0; i Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 23 Jul 2015 10:03:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZIDLi-0003Y9-S1; Thu, 23 Jul 2015 10:03:34 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZIDLg-0003Xu-Og for Minios-devel@lists.xenproject.org; Thu, 23 Jul 2015 10:03:32 +0000 Received: from [85.158.137.68] by server-14.bemta-3.messagelabs.com id 14/B6-02968-3FBB0B55; Thu, 23 Jul 2015 10:03:31 +0000 X-Env-Sender: talex5@gmail.com X-Msg-Ref: server-12.tower-31.messagelabs.com!1437645808!28483471!1 X-Originating-IP: [209.85.212.182] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 31717 invoked from network); 23 Jul 2015 10:03:29 -0000 Received: from mail-wi0-f182.google.com (HELO mail-wi0-f182.google.com) (209.85.212.182) by server-12.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 23 Jul 2015 10:03:29 -0000 Received: by wibud3 with SMTP id ud3so210986778wib.0 for ; Thu, 23 Jul 2015 03:03:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xymNiCGOQnM5DytwRaDpT2j9F6UehwiXiJQFkwXoumg=; b=EwuXKh83eTdHiDQRDLNY/BIowMd5lpwQPrmQ1B4dxuVDQRirq4/D/uUlqLEQgIeNGH b7oGtSzVGgA73W0a6zKcN+hVLFbF0dwwUXTMs598lLH9Ilf0x9uQCovR2QmT8EIffuLP RbclYWRQ9BKJ4fonBRgpM+u/XN66NUrQN9erPFag2JbyqrKkuE2MNCFEZHlJgqLzdRb/ V/LFJsKEOjaShjyZLe765icWkrJ2T+Sbjzljc4T7O/FQhuQylO1vz2ZLn2Jt86pqMh9F 4QOWN0qu/9AeIuwKiDYfzzrBdL0aVx6+HFeMznwnJuCPseVW0G0ApjfrJXl+FHvP+78Q +5RQ== X-Received: by 10.180.80.138 with SMTP id r10mr14615697wix.18.1437645808359; Thu, 23 Jul 2015 03:03:28 -0700 (PDT) Received: from cam.localdomain (82-69-101-169.dsl.in-addr.zen.co.uk. [82.69.101.169]) by smtp.gmail.com with ESMTPSA id ft5sm26370659wib.4.2015.07.23.03.03.26 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 23 Jul 2015 03:03:27 -0700 (PDT) From: Thomas Leonard To: Minios-devel@lists.xenproject.org Date: Thu, 23 Jul 2015 11:08:38 +0100 Message-Id: <1437646119-32175-2-git-send-email-talex5@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <1437646119-32175-1-git-send-email-talex5@gmail.com> References: <1437646119-32175-1-git-send-email-talex5@gmail.com> Cc: Thomas Leonard , Ian.Campbell@citrix.com, anil@recoil.org, karim.allah.ahmed@gmail.com, stefano.stabellini@eu.citrix.com, samuel.thibault@ens-lyon.org, Dave.Scott@eu.citrix.com Subject: [Minios-devel] [PATCH ARM v10 1/2] arm: interrupt controller X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Based on an initial patch by Karim Raslan. Signed-off-by: Karim Allah Ahmed Signed-off-by: Thomas Leonard --- Changes since v9 Addressed comments from Ian Campbell: - Added note about hard-coded IRQ numbers to README --- README | 7 ++ arch/arm/gic.c | 238 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 245 insertions(+) create mode 100644 arch/arm/gic.c diff --git a/README b/README index 7960314..7e9c07a 100644 --- a/README +++ b/README @@ -44,3 +44,10 @@ show a mouse with which you can draw color squares. If you have compiled it with TCP/IP support, it will run a daytime server on TCP port 13. + + + ARM notes + ========= + +- The IRQ numbers are currently hard-coded in gic.c and may need to be updated if + future versions of Xen change them. diff --git a/arch/arm/gic.c b/arch/arm/gic.c new file mode 100644 index 0000000..1855293 --- /dev/null +++ b/arch/arm/gic.c @@ -0,0 +1,238 @@ +// ARM GIC implementation + +#include +#include +#include +#include + +//#define VGIC_DEBUG +#ifdef VGIC_DEBUG +#define DEBUG(_f, _a...) \ + printk("MINI_OS(file=vgic.c, line=%d) " _f , __LINE__, ## _a) +#else +#define DEBUG(_f, _a...) ((void)0) +#endif + +extern void (*IRQ_handler)(void); + +struct gic { + volatile char *gicd_base; + volatile char *gicc_base; +}; + +static struct gic gic; + +// Distributor Interface +#define GICD_CTLR 0x0 +#define GICD_ISENABLER 0x100 +#define GICD_IPRIORITYR 0x400 +#define GICD_ITARGETSR 0x800 +#define GICD_ICFGR 0xC00 + +// CPU Interface +#define GICC_CTLR 0x0 +#define GICC_PMR 0x4 +#define GICC_IAR 0xc +#define GICC_EOIR 0x10 +#define GICC_HPPIR 0x18 + +#define gicd(gic, offset) ((gic)->gicd_base + (offset)) +#define gicc(gic, offset) ((gic)->gicc_base + (offset)) + +#define REG(addr) ((uint32_t *)(addr)) + +static inline uint32_t REG_READ32(volatile uint32_t *addr) +{ + uint32_t value; + __asm__ __volatile__("ldr %0, [%1]":"=&r"(value):"r"(addr)); + rmb(); + return value; +} + +static inline void REG_WRITE32(volatile uint32_t *addr, unsigned int value) +{ + __asm__ __volatile__("str %0, [%1]"::"r"(value), "r"(addr)); + wmb(); +} + +static void gic_set_priority(struct gic *gic, int irq_number, unsigned char priority) +{ + uint32_t value; + uint32_t *addr = REG(gicd(gic, GICD_IPRIORITYR)) + (irq_number >> 2); + value = REG_READ32(addr); + value &= ~(0xff << (8 * (irq_number & 0x3))); // clear old priority + value |= priority << (8 * (irq_number & 0x3)); // set new priority + REG_WRITE32(addr, value); +} + +static void gic_route_interrupt(struct gic *gic, int irq_number, unsigned char cpu_set) +{ + uint32_t value; + uint32_t *addr = REG(gicd(gic, GICD_ITARGETSR)) + (irq_number >> 2); + value = REG_READ32(addr); + value &= ~(0xff << (8 * (irq_number & 0x3))); // clear old target + value |= cpu_set << (8 * (irq_number & 0x3)); // set new target + REG_WRITE32(addr, value); +} + +/* When accessing the GIC registers, we can't use LDREX/STREX because it's not regular memory. */ +static __inline__ void clear_bit_non_atomic(int nr, volatile void *base) +{ + volatile uint32_t *tmp = base; + tmp[nr >> 5] &= (unsigned long)~(1 << (nr & 0x1f)); +} + +static __inline__ void set_bit_non_atomic(int nr, volatile void *base) +{ + volatile uint32_t *tmp = base; + tmp[nr >> 5] |= (1 << (nr & 0x1f)); +} + +/* Note: not thread safe (but we only support one CPU for now anyway) */ +static void gic_enable_interrupt(struct gic *gic, int irq_number, + unsigned char cpu_set, unsigned char level_sensitive) +{ + int *set_enable_reg; + void *cfg_reg; + + // set priority + gic_set_priority(gic, irq_number, 0x0); + + // set target cpus for this interrupt + gic_route_interrupt(gic, irq_number, cpu_set); + + // set level/edge triggered + cfg_reg = (void *)gicd(gic, GICD_ICFGR); + if (level_sensitive) { + clear_bit_non_atomic((irq_number * 2) + 1, cfg_reg); + } else { + set_bit_non_atomic((irq_number * 2) + 1, cfg_reg); + } + + wmb(); + + // enable forwarding interrupt from distributor to cpu interface + set_enable_reg = (int *)gicd(gic, GICD_ISENABLER); + set_enable_reg[irq_number >> 5] = 1 << (irq_number & 0x1f); + wmb(); +} + +static void gic_enable_interrupts(struct gic *gic) +{ + // Global enable forwarding interrupts from distributor to cpu interface + REG_WRITE32(REG(gicd(gic, GICD_CTLR)), 0x00000001); + + // Global enable signalling of interrupt from the cpu interface + REG_WRITE32(REG(gicc(gic, GICC_CTLR)), 0x00000001); +} + +static void gic_disable_interrupts(struct gic *gic) +{ + // Global disable signalling of interrupt from the cpu interface + REG_WRITE32(REG(gicc(gic, GICC_CTLR)), 0x00000000); + + // Global disable forwarding interrupts from distributor to cpu interface + REG_WRITE32(REG(gicd(gic, GICD_CTLR)), 0x00000000); +} + +static void gic_cpu_set_priority(struct gic *gic, char priority) +{ + REG_WRITE32(REG(gicc(gic, GICC_PMR)), priority & 0x000000FF); +} + +static unsigned long gic_readiar(struct gic *gic) { + return REG_READ32(REG(gicc(gic, GICC_IAR))) & 0x000003FF; // Interrupt ID +} + +static void gic_eoir(struct gic *gic, uint32_t irq) { + REG_WRITE32(REG(gicc(gic, GICC_EOIR)), irq & 0x000003FF); +} + +//FIXME Get event_irq from dt +#define EVENTS_IRQ 31 +#define VIRTUALTIMER_IRQ 27 + +static void gic_handler(void) { + unsigned int irq = gic_readiar(&gic); + + DEBUG("IRQ received : %i\n", irq); + switch(irq) { + case EVENTS_IRQ: + do_hypervisor_callback(NULL); + break; + case VIRTUALTIMER_IRQ: + /* We need to get this event to wake us up from block_domain, + * but we don't need to do anything special with it. */ + break; + case 1022: + case 1023: + return; /* Spurious interrupt */ + default: + DEBUG("Unhandled irq\n"); + break; + } + + DEBUG("EIRQ\n"); + + gic_eoir(&gic, irq); +} + +void gic_init(void) { + gic.gicd_base = NULL; + int node = 0; + int depth = 0; + for (;;) + { + node = fdt_next_node(device_tree, node, &depth); + if (node <= 0 || depth < 0) + break; + + if (fdt_getprop(device_tree, node, "interrupt-controller", NULL)) { + int len = 0; + + if (fdt_node_check_compatible(device_tree, node, "arm,cortex-a15-gic") && + fdt_node_check_compatible(device_tree, node, "arm,cortex-a7-gic")) { + printk("Skipping incompatible interrupt-controller node\n"); + continue; + } + + const uint64_t *reg = fdt_getprop(device_tree, node, "reg", &len); + + /* We have two registers (GICC and GICD), each of which contains + * two parts (an address and a size), each of which is a 64-bit + * value (8 bytes), so we expect a length of 2 * 2 * 8 = 32. + * If any extra values are passed in future, we ignore them. */ + if (reg == NULL || len < 32) { + printk("Bad 'reg' property: %p %d\n", reg, len); + continue; + } + + gic.gicd_base = to_virt((long) fdt64_to_cpu(reg[0])); + gic.gicc_base = to_virt((long) fdt64_to_cpu(reg[2])); + printk("Found GIC: gicd_base = %p, gicc_base = %p\n", gic.gicd_base, gic.gicc_base); + break; + } + } + if (!gic.gicd_base) { + printk("GIC not found!\n"); + BUG(); + } + wmb(); + + /* Note: we could mark this as "device" memory here, but Xen will have already + * set it that way in the second stage translation table, so it's not necessary. + * See "Overlaying the memory type attribute" in the Architecture Reference Manual. + */ + + IRQ_handler = gic_handler; + + gic_disable_interrupts(&gic); + gic_cpu_set_priority(&gic, 0xff); + + /* Must call gic_enable_interrupts before enabling individual interrupts, otherwise our IRQ handler + * gets called endlessly with spurious interrupts. */ + gic_enable_interrupts(&gic); + + gic_enable_interrupt(&gic, EVENTS_IRQ /* interrupt number */, 0x1 /*cpu_set*/, 1 /*level_sensitive*/); + gic_enable_interrupt(&gic, VIRTUALTIMER_IRQ /* interrupt number */, 0x1 /*cpu_set*/, 1 /*level_sensitive*/); +} -- 2.4.6 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Thu Jul 23 10:03:34 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 23 Jul 2015 10:03:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZIDLh-0003Y3-Ps; Thu, 23 Jul 2015 10:03:33 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZIDLg-0003Xt-1q for Minios-devel@lists.xenproject.org; Thu, 23 Jul 2015 10:03:32 +0000 Received: from [193.109.254.147] by server-7.bemta-14.messagelabs.com id 1E/5D-01469-3FBB0B55; Thu, 23 Jul 2015 10:03:31 +0000 X-Env-Sender: talex5@gmail.com X-Msg-Ref: server-15.tower-27.messagelabs.com!1437645809!34580779!1 X-Originating-IP: [209.85.212.182] X-SpamReason: No, hits=0.5 required=7.0 tests=BODY_RANDOM_LONG, UPPERCASE_25_50 X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 7644 invoked from network); 23 Jul 2015 10:03:30 -0000 Received: from mail-wi0-f182.google.com (HELO mail-wi0-f182.google.com) (209.85.212.182) by server-15.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 23 Jul 2015 10:03:30 -0000 Received: by wibxm9 with SMTP id xm9so200765843wib.0 for ; Thu, 23 Jul 2015 03:03:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=WjPW7ZcKQ7aiDqvhJDqj0Wk8kPJDg2ayjbDkfgHSPmw=; b=UOd5eU753K5dD2xkq2kPZ/KnI6lfZ01/1QchlDUq3ZTAlXvsPi+Xb9V70nKp0YPKcR Z2+bOiAA9WTALNg3OfKRebklhDsaLlMHHqhl8eg7LGUbB4jYvZ0RJYTtd2WcVwWH2f+n Xa25OI9raXGlASCe5TVoPrZQEP41ubXiddNbccmtl4OFt+wwk2FjftYzKRSwTFxY0W2t xz5udCwED+6XajWp8RjDrzFLQfy6V6sEI2DgD1xvlMtX38Rstzz9P9ZsRud/4tOLlguy 0e6Ik0vHzQ7X+9MzDsJTIuV5iZanV34x1myEiLVCuR1MGdKd7G2H0tzIknmKIlnzwgEx GA4w== X-Received: by 10.194.187.170 with SMTP id ft10mr14095169wjc.26.1437645809793; Thu, 23 Jul 2015 03:03:29 -0700 (PDT) Received: from cam.localdomain (82-69-101-169.dsl.in-addr.zen.co.uk. [82.69.101.169]) by smtp.gmail.com with ESMTPSA id ft5sm26370659wib.4.2015.07.23.03.03.28 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 23 Jul 2015 03:03:29 -0700 (PDT) From: Thomas Leonard To: Minios-devel@lists.xenproject.org Date: Thu, 23 Jul 2015 11:08:39 +0100 Message-Id: <1437646119-32175-3-git-send-email-talex5@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <1437646119-32175-1-git-send-email-talex5@gmail.com> References: <1437646119-32175-1-git-send-email-talex5@gmail.com> Cc: Thomas Leonard , Ian.Campbell@citrix.com, anil@recoil.org, karim.allah.ahmed@gmail.com, stefano.stabellini@eu.citrix.com, samuel.thibault@ens-lyon.org, Dave.Scott@eu.citrix.com Subject: [Minios-devel] [PATCH ARM v10 2/2] arm: build system X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Based on an initial patch by Karim Raslan. This activates the ARM code added in the previous patches. On ARM, Mini-OS will boot and display some output on the console. Tested with: make XEN_TARGET_ARCH=arm32 CROSS_COMPILE=arm-linux-gnueabihf- \ CONFIG_TEST=y CONFIG_START_NETWORK=n CONFIG_BLKFRONT=n \ CONFIG_NETFRONT=n CONFIG_FBFRONT=n CONFIG_KBDFRONT=n \ CONFIG_CONSFRONT=n CONFIG_XC=n -j4 The memmove implementation is from FreeBSD's contrib/ldns/compat/memmove.c (r246827). Signed-off-by: Karim Allah Ahmed Signed-off-by: Thomas Leonard --- Same as v9. Note that COPYING contains the BSD license needed for memmove. --- .gitmodules | 3 +++ COPYING | 27 +++++++++++++++++++++++++++ Config.mk | 2 ++ Makefile | 27 ++++++++++++++++++++++++++- arch/arm/Makefile | 35 +++++++++++++++++++++++++++++++++++ arch/arm/arch.mk | 6 ++++++ dtc | 1 + include/lib.h | 4 +++- include/libfdt_env.h | 33 +++++++++++++++++++++++++++++++++ lib/memmove.c | 45 +++++++++++++++++++++++++++++++++++++++++++++ lib/string.c | 12 ++++++++++++ 11 files changed, 193 insertions(+), 2 deletions(-) create mode 100644 .gitmodules create mode 100755 arch/arm/Makefile create mode 100644 arch/arm/arch.mk create mode 160000 dtc create mode 100644 include/libfdt_env.h create mode 100644 lib/memmove.c diff --git a/.gitmodules b/.gitmodules new file mode 100644 index 0000000..221102d --- /dev/null +++ b/.gitmodules @@ -0,0 +1,3 @@ +[submodule "dtc"] + path = dtc + url = git://git.kernel.org/pub/scm/utils/dtc/dtc.git diff --git a/COPYING b/COPYING index 1d9df6c..b676bb6 100644 --- a/COPYING +++ b/COPYING @@ -34,3 +34,30 @@ LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +Copyright (c) 2005,2006, NLnetLabs +All rights reserved. + +Redistribution and use in source and binary forms, with or without +modification, are permitted provided that the following conditions are met: + + * Redistributions of source code must retain the above copyright notice, + this list of conditions and the following disclaimer. + * Redistributions in binary form must reproduce the above copyright + notice, this list of conditions and the following disclaimer in the + documentation and/or other materials provided with the distribution. + * Neither the name of NLnetLabs nor the names of its + contributors may be used to endorse or promote products derived from this + software without specific prior written permission. + +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" +AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE +IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE +ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE +LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR +CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF +SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS +INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN +CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) +ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE +POSSIBILITY OF SUCH DAMAGE. diff --git a/Config.mk b/Config.mk index e5d8ade..eb53f2d 100644 --- a/Config.mk +++ b/Config.mk @@ -54,6 +54,8 @@ export XEN_INTERFACE_VERSION # If not x86 then use $(MINIOS_TARGET_ARCH) ifeq ($(findstring x86_,$(MINIOS_TARGET_ARCH)),x86_) TARGET_ARCH_FAM = x86 +else ifeq ($(findstring arm,$(MINIOS_TARGET_ARCH)),arm) +TARGET_ARCH_FAM = arm else TARGET_ARCH_FAM = $(MINIOS_TARGET_ARCH) endif diff --git a/Makefile b/Makefile index 2cb5e51..d06fc3b 100644 --- a/Makefile +++ b/Makefile @@ -54,8 +54,15 @@ DEF_CFLAGS += $(flags-y) # Symlinks and headers that must be created before building the C files GENERATED_HEADERS := include/list.h $(ARCH_LINKS) include/mini-os include/$(TARGET_ARCH_FAM)/mini-os +ifeq ($(MINIOS_TARGET_ARCH),arm32) +GENERATED_HEADERS += include/fdt.h include/libfdt.h +endif + EXTRA_DEPS += $(GENERATED_HEADERS) +include/%.h: dtc/libfdt/%.h + ln -s ../$^ $@ + # Include common mini-os makerules. include minios.mk @@ -76,7 +83,18 @@ EXTRA_OBJS = TARGET := mini-os # Subdirectories common to mini-os -SUBDIRS := lib xenbus console +SUBDIRS := lib xenbus console dtc/libfdt + +FDT_SRC := +ifeq ($(MINIOS_TARGET_ARCH),arm32) +# Need libgcc.a for division helpers +LDLIBS += `$(CC) -print-libgcc-file-name` + +# Device tree support +FDT_SRC := dtc/libfdt/fdt.c dtc/libfdt/fdt_ro.c dtc/libfdt/fdt_strerror.c + +src-y += ${FDT_SRC} +endif src-$(CONFIG_BLKFRONT) += blkfront.c src-$(CONFIG_TPMFRONT) += tpmfront.c @@ -98,10 +116,13 @@ src-y += sched.c src-$(CONFIG_TEST) += test.c src-y += lib/ctype.c +ifneq ($(MINIOS_TARGET_ARCH),arm32) src-y += lib/math.c +endif src-y += lib/printf.c src-y += lib/stack_chk_fail.c src-y += lib/string.c +src-y += lib/memmove.c src-y += lib/sys.c src-y += lib/xmalloc.c src-$(CONFIG_XENBUS) += lib/xs.c @@ -188,7 +209,11 @@ $(OBJ_DIR)/$(TARGET): $(OBJS) $(APP_O) arch_lib $(LD) -r $(LDFLAGS) $(HEAD_OBJ) $(APP_O) $(OBJS) $(LDARCHLIB) $(LDLIBS) -o $@.o $(OBJCOPY) -w -G $(GLOBAL_PREFIX)* -G _start $@.o $@.o $(LD) $(LDFLAGS) $(LDFLAGS_FINAL) $@.o $(EXTRA_OBJS) -o $@ +ifeq ($(MINIOS_TARGET_ARCH),arm32) + $(OBJCOPY) -O binary $@ $@.img +else gzip -f -9 -c $@ >$@.gz +endif .PHONY: clean arch_clean diff --git a/arch/arm/Makefile b/arch/arm/Makefile new file mode 100755 index 0000000..e018dad --- /dev/null +++ b/arch/arm/Makefile @@ -0,0 +1,35 @@ +# +# ARM architecture specific makefiles. +# + +TOPLEVEL_DIR = $(CURDIR)/../.. +OBJ_DIR=$(CURDIR) +include ../../Config.mk + +# include arch.mk has to be before minios.mk! + +include arch.mk +include ../../minios.mk + +include $(MINI-OS_ROOT)/config/MiniOS.mk + + +# Sources here are all *.c (without $(MINIOS_TARGET_ARCH).S) +# This is handled in $(HEAD_ARCH_OBJ) +ARCH_SRCS := $(wildcard *.c) + +# The objects built from the sources. +ARCH_OBJS := $(patsubst %.c,$(OBJ_DIR)/%.o,$(ARCH_SRCS)) + +ARCH_OBJS += $(OBJ_DIR)/hypercalls32.o + +all: $(OBJ_DIR)/$(ARCH_LIB) + +# $(HEAD_ARCH_OBJ) is only built here, needed on linking +# in ../../Makefile. +$(OBJ_DIR)/$(ARCH_LIB): $(ARCH_OBJS) $(OBJ_DIR)/$(HEAD_ARCH_OBJ) + $(AR) rv $(OBJ_DIR)/$(ARCH_LIB) $(ARCH_OBJS) + +clean: + rm -f $(OBJ_DIR)/$(ARCH_LIB) $(ARCH_OBJS) $(OBJ_DIR)/$(HEAD_ARCH_OBJ) + diff --git a/arch/arm/arch.mk b/arch/arm/arch.mk new file mode 100644 index 0000000..b4cb65b --- /dev/null +++ b/arch/arm/arch.mk @@ -0,0 +1,6 @@ +ifeq ($(MINIOS_TARGET_ARCH),arm32) +DEF_ASFLAGS += -march=armv7-a -mfpu=vfpv3 +ARCH_CFLAGS := -march=armv7-a -marm -fms-extensions -D__arm__ -DXEN_HAVE_PV_GUEST_ENTRY #-DCPU_EXCLUSIVE_LDST +EXTRA_INC += $(TARGET_ARCH_FAM)/$(MINIOS_TARGET_ARCH) +EXTRA_SRC += arch/$(EXTRA_INC) +endif diff --git a/dtc b/dtc new file mode 160000 index 0000000..64c46b0 --- /dev/null +++ b/dtc @@ -0,0 +1 @@ +Subproject commit 64c46b098b969502a74c8b0fd97e6f5e4aa07e21 diff --git a/include/lib.h b/include/lib.h index 62836c7..326e39f 100644 --- a/include/lib.h +++ b/include/lib.h @@ -95,6 +95,7 @@ char *strncpy(char * __restrict, const char * __restrict, size_t); char *strstr(const char *, const char *); +void *memmove(void *, const void *, size_t); void *memset(void *, int, size_t); char *strchr(const char *p, int ch); @@ -104,7 +105,8 @@ char *strrchr(const char *p, int ch); * @(#)systm.h 8.7 (Berkeley) 3/29/95 * $FreeBSD$ */ -void *memcpy(void *to, const void *from, size_t len); +void *memcpy(void *to, const void *from, size_t len); +void *memchr(const void *s, int c, size_t n); size_t strnlen(const char *, size_t); #endif diff --git a/include/libfdt_env.h b/include/libfdt_env.h new file mode 100644 index 0000000..722fac6 --- /dev/null +++ b/include/libfdt_env.h @@ -0,0 +1,33 @@ +#ifndef _LIBFDT_ENV_H +#define _LIBFDT_ENV_H + +#include +#include +#include + +typedef uint16_t fdt16_t; +typedef uint32_t fdt32_t; +typedef uint64_t fdt64_t; + +#define EXTRACT_BYTE(n) ((unsigned long long)((uint8_t *)&x)[n]) +static inline uint16_t fdt16_to_cpu(uint16_t x) +{ + return (EXTRACT_BYTE(0) << 8) | EXTRACT_BYTE(1); +} +#define cpu_to_fdt16(x) fdt16_to_cpu(x) + +static inline uint32_t fdt32_to_cpu(uint32_t x) +{ + return (EXTRACT_BYTE(0) << 24) | (EXTRACT_BYTE(1) << 16) | (EXTRACT_BYTE(2) << 8) | EXTRACT_BYTE(3); +} +#define cpu_to_fdt32(x) fdt32_to_cpu(x) + +static inline uint64_t fdt64_to_cpu(uint64_t x) +{ + return (EXTRACT_BYTE(0) << 56) | (EXTRACT_BYTE(1) << 48) | (EXTRACT_BYTE(2) << 40) | (EXTRACT_BYTE(3) << 32) + | (EXTRACT_BYTE(4) << 24) | (EXTRACT_BYTE(5) << 16) | (EXTRACT_BYTE(6) << 8) | EXTRACT_BYTE(7); +} +#define cpu_to_fdt64(x) fdt64_to_cpu(x) +#undef EXTRACT_BYTE + +#endif /* _LIBFDT_ENV_H */ diff --git a/lib/memmove.c b/lib/memmove.c new file mode 100644 index 0000000..0298b7c --- /dev/null +++ b/lib/memmove.c @@ -0,0 +1,45 @@ +/* + * memmove.c: memmove compat implementation. + * + * Copyright (c) 2001-2008, NLnet Labs. All rights reserved. + * + * See COPYING for the license. +*/ + +#include +#include + +#ifndef HAVE_LIBC + +void *memmove(void *dest, const void *src, size_t n) +{ + uint8_t* from = (uint8_t*) src; + uint8_t* to = (uint8_t*) dest; + + if (from == to || n == 0) + return dest; + if (to > from && to-from < (int)n) { + /* to overlaps with from */ + /* */ + /* */ + /* copy in reverse, to avoid overwriting from */ + int i; + for(i=n-1; i>=0; i--) + to[i] = from[i]; + return dest; + } + if (from > to && from-to < (int)n) { + /* to overlaps with from */ + /* */ + /* */ + /* copy forwards, to avoid overwriting from */ + size_t i; + for(i=0; i Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 23 Jul 2015 10:03:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZIDLi-0003Y9-S1; Thu, 23 Jul 2015 10:03:34 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZIDLg-0003Xu-Og for Minios-devel@lists.xenproject.org; Thu, 23 Jul 2015 10:03:32 +0000 Received: from [85.158.137.68] by server-14.bemta-3.messagelabs.com id 14/B6-02968-3FBB0B55; Thu, 23 Jul 2015 10:03:31 +0000 X-Env-Sender: talex5@gmail.com X-Msg-Ref: server-12.tower-31.messagelabs.com!1437645808!28483471!1 X-Originating-IP: [209.85.212.182] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 31717 invoked from network); 23 Jul 2015 10:03:29 -0000 Received: from mail-wi0-f182.google.com (HELO mail-wi0-f182.google.com) (209.85.212.182) by server-12.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 23 Jul 2015 10:03:29 -0000 Received: by wibud3 with SMTP id ud3so210986778wib.0 for ; Thu, 23 Jul 2015 03:03:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xymNiCGOQnM5DytwRaDpT2j9F6UehwiXiJQFkwXoumg=; b=EwuXKh83eTdHiDQRDLNY/BIowMd5lpwQPrmQ1B4dxuVDQRirq4/D/uUlqLEQgIeNGH b7oGtSzVGgA73W0a6zKcN+hVLFbF0dwwUXTMs598lLH9Ilf0x9uQCovR2QmT8EIffuLP RbclYWRQ9BKJ4fonBRgpM+u/XN66NUrQN9erPFag2JbyqrKkuE2MNCFEZHlJgqLzdRb/ V/LFJsKEOjaShjyZLe765icWkrJ2T+Sbjzljc4T7O/FQhuQylO1vz2ZLn2Jt86pqMh9F 4QOWN0qu/9AeIuwKiDYfzzrBdL0aVx6+HFeMznwnJuCPseVW0G0ApjfrJXl+FHvP+78Q +5RQ== X-Received: by 10.180.80.138 with SMTP id r10mr14615697wix.18.1437645808359; Thu, 23 Jul 2015 03:03:28 -0700 (PDT) Received: from cam.localdomain (82-69-101-169.dsl.in-addr.zen.co.uk. [82.69.101.169]) by smtp.gmail.com with ESMTPSA id ft5sm26370659wib.4.2015.07.23.03.03.26 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 23 Jul 2015 03:03:27 -0700 (PDT) From: Thomas Leonard To: Minios-devel@lists.xenproject.org Date: Thu, 23 Jul 2015 11:08:38 +0100 Message-Id: <1437646119-32175-2-git-send-email-talex5@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <1437646119-32175-1-git-send-email-talex5@gmail.com> References: <1437646119-32175-1-git-send-email-talex5@gmail.com> Cc: Thomas Leonard , Ian.Campbell@citrix.com, anil@recoil.org, karim.allah.ahmed@gmail.com, stefano.stabellini@eu.citrix.com, samuel.thibault@ens-lyon.org, Dave.Scott@eu.citrix.com Subject: [Minios-devel] [PATCH ARM v10 1/2] arm: interrupt controller X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Based on an initial patch by Karim Raslan. Signed-off-by: Karim Allah Ahmed Signed-off-by: Thomas Leonard --- Changes since v9 Addressed comments from Ian Campbell: - Added note about hard-coded IRQ numbers to README --- README | 7 ++ arch/arm/gic.c | 238 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 245 insertions(+) create mode 100644 arch/arm/gic.c diff --git a/README b/README index 7960314..7e9c07a 100644 --- a/README +++ b/README @@ -44,3 +44,10 @@ show a mouse with which you can draw color squares. If you have compiled it with TCP/IP support, it will run a daytime server on TCP port 13. + + + ARM notes + ========= + +- The IRQ numbers are currently hard-coded in gic.c and may need to be updated if + future versions of Xen change them. diff --git a/arch/arm/gic.c b/arch/arm/gic.c new file mode 100644 index 0000000..1855293 --- /dev/null +++ b/arch/arm/gic.c @@ -0,0 +1,238 @@ +// ARM GIC implementation + +#include +#include +#include +#include + +//#define VGIC_DEBUG +#ifdef VGIC_DEBUG +#define DEBUG(_f, _a...) \ + printk("MINI_OS(file=vgic.c, line=%d) " _f , __LINE__, ## _a) +#else +#define DEBUG(_f, _a...) ((void)0) +#endif + +extern void (*IRQ_handler)(void); + +struct gic { + volatile char *gicd_base; + volatile char *gicc_base; +}; + +static struct gic gic; + +// Distributor Interface +#define GICD_CTLR 0x0 +#define GICD_ISENABLER 0x100 +#define GICD_IPRIORITYR 0x400 +#define GICD_ITARGETSR 0x800 +#define GICD_ICFGR 0xC00 + +// CPU Interface +#define GICC_CTLR 0x0 +#define GICC_PMR 0x4 +#define GICC_IAR 0xc +#define GICC_EOIR 0x10 +#define GICC_HPPIR 0x18 + +#define gicd(gic, offset) ((gic)->gicd_base + (offset)) +#define gicc(gic, offset) ((gic)->gicc_base + (offset)) + +#define REG(addr) ((uint32_t *)(addr)) + +static inline uint32_t REG_READ32(volatile uint32_t *addr) +{ + uint32_t value; + __asm__ __volatile__("ldr %0, [%1]":"=&r"(value):"r"(addr)); + rmb(); + return value; +} + +static inline void REG_WRITE32(volatile uint32_t *addr, unsigned int value) +{ + __asm__ __volatile__("str %0, [%1]"::"r"(value), "r"(addr)); + wmb(); +} + +static void gic_set_priority(struct gic *gic, int irq_number, unsigned char priority) +{ + uint32_t value; + uint32_t *addr = REG(gicd(gic, GICD_IPRIORITYR)) + (irq_number >> 2); + value = REG_READ32(addr); + value &= ~(0xff << (8 * (irq_number & 0x3))); // clear old priority + value |= priority << (8 * (irq_number & 0x3)); // set new priority + REG_WRITE32(addr, value); +} + +static void gic_route_interrupt(struct gic *gic, int irq_number, unsigned char cpu_set) +{ + uint32_t value; + uint32_t *addr = REG(gicd(gic, GICD_ITARGETSR)) + (irq_number >> 2); + value = REG_READ32(addr); + value &= ~(0xff << (8 * (irq_number & 0x3))); // clear old target + value |= cpu_set << (8 * (irq_number & 0x3)); // set new target + REG_WRITE32(addr, value); +} + +/* When accessing the GIC registers, we can't use LDREX/STREX because it's not regular memory. */ +static __inline__ void clear_bit_non_atomic(int nr, volatile void *base) +{ + volatile uint32_t *tmp = base; + tmp[nr >> 5] &= (unsigned long)~(1 << (nr & 0x1f)); +} + +static __inline__ void set_bit_non_atomic(int nr, volatile void *base) +{ + volatile uint32_t *tmp = base; + tmp[nr >> 5] |= (1 << (nr & 0x1f)); +} + +/* Note: not thread safe (but we only support one CPU for now anyway) */ +static void gic_enable_interrupt(struct gic *gic, int irq_number, + unsigned char cpu_set, unsigned char level_sensitive) +{ + int *set_enable_reg; + void *cfg_reg; + + // set priority + gic_set_priority(gic, irq_number, 0x0); + + // set target cpus for this interrupt + gic_route_interrupt(gic, irq_number, cpu_set); + + // set level/edge triggered + cfg_reg = (void *)gicd(gic, GICD_ICFGR); + if (level_sensitive) { + clear_bit_non_atomic((irq_number * 2) + 1, cfg_reg); + } else { + set_bit_non_atomic((irq_number * 2) + 1, cfg_reg); + } + + wmb(); + + // enable forwarding interrupt from distributor to cpu interface + set_enable_reg = (int *)gicd(gic, GICD_ISENABLER); + set_enable_reg[irq_number >> 5] = 1 << (irq_number & 0x1f); + wmb(); +} + +static void gic_enable_interrupts(struct gic *gic) +{ + // Global enable forwarding interrupts from distributor to cpu interface + REG_WRITE32(REG(gicd(gic, GICD_CTLR)), 0x00000001); + + // Global enable signalling of interrupt from the cpu interface + REG_WRITE32(REG(gicc(gic, GICC_CTLR)), 0x00000001); +} + +static void gic_disable_interrupts(struct gic *gic) +{ + // Global disable signalling of interrupt from the cpu interface + REG_WRITE32(REG(gicc(gic, GICC_CTLR)), 0x00000000); + + // Global disable forwarding interrupts from distributor to cpu interface + REG_WRITE32(REG(gicd(gic, GICD_CTLR)), 0x00000000); +} + +static void gic_cpu_set_priority(struct gic *gic, char priority) +{ + REG_WRITE32(REG(gicc(gic, GICC_PMR)), priority & 0x000000FF); +} + +static unsigned long gic_readiar(struct gic *gic) { + return REG_READ32(REG(gicc(gic, GICC_IAR))) & 0x000003FF; // Interrupt ID +} + +static void gic_eoir(struct gic *gic, uint32_t irq) { + REG_WRITE32(REG(gicc(gic, GICC_EOIR)), irq & 0x000003FF); +} + +//FIXME Get event_irq from dt +#define EVENTS_IRQ 31 +#define VIRTUALTIMER_IRQ 27 + +static void gic_handler(void) { + unsigned int irq = gic_readiar(&gic); + + DEBUG("IRQ received : %i\n", irq); + switch(irq) { + case EVENTS_IRQ: + do_hypervisor_callback(NULL); + break; + case VIRTUALTIMER_IRQ: + /* We need to get this event to wake us up from block_domain, + * but we don't need to do anything special with it. */ + break; + case 1022: + case 1023: + return; /* Spurious interrupt */ + default: + DEBUG("Unhandled irq\n"); + break; + } + + DEBUG("EIRQ\n"); + + gic_eoir(&gic, irq); +} + +void gic_init(void) { + gic.gicd_base = NULL; + int node = 0; + int depth = 0; + for (;;) + { + node = fdt_next_node(device_tree, node, &depth); + if (node <= 0 || depth < 0) + break; + + if (fdt_getprop(device_tree, node, "interrupt-controller", NULL)) { + int len = 0; + + if (fdt_node_check_compatible(device_tree, node, "arm,cortex-a15-gic") && + fdt_node_check_compatible(device_tree, node, "arm,cortex-a7-gic")) { + printk("Skipping incompatible interrupt-controller node\n"); + continue; + } + + const uint64_t *reg = fdt_getprop(device_tree, node, "reg", &len); + + /* We have two registers (GICC and GICD), each of which contains + * two parts (an address and a size), each of which is a 64-bit + * value (8 bytes), so we expect a length of 2 * 2 * 8 = 32. + * If any extra values are passed in future, we ignore them. */ + if (reg == NULL || len < 32) { + printk("Bad 'reg' property: %p %d\n", reg, len); + continue; + } + + gic.gicd_base = to_virt((long) fdt64_to_cpu(reg[0])); + gic.gicc_base = to_virt((long) fdt64_to_cpu(reg[2])); + printk("Found GIC: gicd_base = %p, gicc_base = %p\n", gic.gicd_base, gic.gicc_base); + break; + } + } + if (!gic.gicd_base) { + printk("GIC not found!\n"); + BUG(); + } + wmb(); + + /* Note: we could mark this as "device" memory here, but Xen will have already + * set it that way in the second stage translation table, so it's not necessary. + * See "Overlaying the memory type attribute" in the Architecture Reference Manual. + */ + + IRQ_handler = gic_handler; + + gic_disable_interrupts(&gic); + gic_cpu_set_priority(&gic, 0xff); + + /* Must call gic_enable_interrupts before enabling individual interrupts, otherwise our IRQ handler + * gets called endlessly with spurious interrupts. */ + gic_enable_interrupts(&gic); + + gic_enable_interrupt(&gic, EVENTS_IRQ /* interrupt number */, 0x1 /*cpu_set*/, 1 /*level_sensitive*/); + gic_enable_interrupt(&gic, VIRTUALTIMER_IRQ /* interrupt number */, 0x1 /*cpu_set*/, 1 /*level_sensitive*/); +} -- 2.4.6 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Thu Jul 23 10:03:37 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 23 Jul 2015 10:03:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZIDLl-0003Z2-Tx; Thu, 23 Jul 2015 10:03:37 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZIDLk-0003Xs-U0 for Minios-devel@lists.xenproject.org; Thu, 23 Jul 2015 10:03:37 +0000 Received: from [85.158.137.68] by server-4.bemta-3.messagelabs.com id 27/9D-32406-FEBB0B55; Thu, 23 Jul 2015 10:03:27 +0000 X-Env-Sender: talex5@gmail.com X-Msg-Ref: server-4.tower-31.messagelabs.com!1437645807!27281436!1 X-Originating-IP: [209.85.212.170] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 2806 invoked from network); 23 Jul 2015 10:03:27 -0000 Received: from mail-wi0-f170.google.com (HELO mail-wi0-f170.google.com) (209.85.212.170) by server-4.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 23 Jul 2015 10:03:27 -0000 Received: by wibud3 with SMTP id ud3so16593002wib.1 for ; Thu, 23 Jul 2015 03:03:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=cuYcY8CG/ejM9fhGOm1LmGzbRBTS8OAg6MNM7e2znk4=; b=pVGJ6vQGxvU58jzqBjO0JkIimD3w/t/vzFS/56na/S4eX6bhm7sfYWj4pegRwS2q42 SlDeG9oT1MzhqcIonyT7ZKiuvF37LtKpKDKPM81zoY9P7JTIru1opSM9TPDa5fhus+eT ryNamhDMY6PYdfqtbfOPW5bSvZ5rI5goTt7Pf6CNyQZlY8ly7zQvIvyFiaSy174+rYdT XCKP1H/CxMeNO55bIQiFdSX/f0JQiMyxVk2Xjk3xVF9aq715PrY7yTKlcXgPq8KLRJF8 mBuJXDForhbjQNtiWa74EHPxeUEtcboT1XVyi89sF5dLzZ/2S4Y4VHDYQy3lAHbdn6iq 5Mew== X-Received: by 10.180.198.52 with SMTP id iz20mr51063809wic.77.1437645806919; Thu, 23 Jul 2015 03:03:26 -0700 (PDT) Received: from cam.localdomain (82-69-101-169.dsl.in-addr.zen.co.uk. [82.69.101.169]) by smtp.gmail.com with ESMTPSA id ft5sm26370659wib.4.2015.07.23.03.03.25 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 23 Jul 2015 03:03:25 -0700 (PDT) From: Thomas Leonard To: Minios-devel@lists.xenproject.org Date: Thu, 23 Jul 2015 11:08:37 +0100 Message-Id: <1437646119-32175-1-git-send-email-talex5@gmail.com> X-Mailer: git-send-email 2.4.6 Cc: Thomas Leonard , Ian.Campbell@citrix.com, anil@recoil.org, karim.allah.ahmed@gmail.com, stefano.stabellini@eu.citrix.com, samuel.thibault@ens-lyon.org, Dave.Scott@eu.citrix.com Subject: [Minios-devel] [PATCH ARM v10 0/2] mini-os: initial ARM support X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org This series is based on Karim's ARM support commits, further broken up into smaller patches. Changes since v9: - Added note about IRQ numbers to README - Removed fix for compiling with debug=n (not ARM-specific; will submit separately) Thomas Leonard (2): arm: interrupt controller arm: build system .gitmodules | 3 + COPYING | 27 ++++++ Config.mk | 2 + Makefile | 27 +++++- README | 7 ++ arch/arm/Makefile | 35 ++++++++ arch/arm/arch.mk | 6 ++ arch/arm/gic.c | 238 +++++++++++++++++++++++++++++++++++++++++++++++++++ dtc | 1 + include/lib.h | 4 +- include/libfdt_env.h | 33 +++++++ lib/memmove.c | 45 ++++++++++ lib/string.c | 12 +++ 13 files changed, 438 insertions(+), 2 deletions(-) create mode 100644 .gitmodules create mode 100755 arch/arm/Makefile create mode 100644 arch/arm/arch.mk create mode 100644 arch/arm/gic.c create mode 160000 dtc create mode 100644 include/libfdt_env.h create mode 100644 lib/memmove.c -- 2.4.6 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Thu Jul 23 10:03:37 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 23 Jul 2015 10:03:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZIDLl-0003Z2-Tx; Thu, 23 Jul 2015 10:03:37 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZIDLk-0003Xs-U0 for Minios-devel@lists.xenproject.org; Thu, 23 Jul 2015 10:03:37 +0000 Received: from [85.158.137.68] by server-4.bemta-3.messagelabs.com id 27/9D-32406-FEBB0B55; Thu, 23 Jul 2015 10:03:27 +0000 X-Env-Sender: talex5@gmail.com X-Msg-Ref: server-4.tower-31.messagelabs.com!1437645807!27281436!1 X-Originating-IP: [209.85.212.170] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 2806 invoked from network); 23 Jul 2015 10:03:27 -0000 Received: from mail-wi0-f170.google.com (HELO mail-wi0-f170.google.com) (209.85.212.170) by server-4.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 23 Jul 2015 10:03:27 -0000 Received: by wibud3 with SMTP id ud3so16593002wib.1 for ; Thu, 23 Jul 2015 03:03:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=cuYcY8CG/ejM9fhGOm1LmGzbRBTS8OAg6MNM7e2znk4=; b=pVGJ6vQGxvU58jzqBjO0JkIimD3w/t/vzFS/56na/S4eX6bhm7sfYWj4pegRwS2q42 SlDeG9oT1MzhqcIonyT7ZKiuvF37LtKpKDKPM81zoY9P7JTIru1opSM9TPDa5fhus+eT ryNamhDMY6PYdfqtbfOPW5bSvZ5rI5goTt7Pf6CNyQZlY8ly7zQvIvyFiaSy174+rYdT XCKP1H/CxMeNO55bIQiFdSX/f0JQiMyxVk2Xjk3xVF9aq715PrY7yTKlcXgPq8KLRJF8 mBuJXDForhbjQNtiWa74EHPxeUEtcboT1XVyi89sF5dLzZ/2S4Y4VHDYQy3lAHbdn6iq 5Mew== X-Received: by 10.180.198.52 with SMTP id iz20mr51063809wic.77.1437645806919; Thu, 23 Jul 2015 03:03:26 -0700 (PDT) Received: from cam.localdomain (82-69-101-169.dsl.in-addr.zen.co.uk. [82.69.101.169]) by smtp.gmail.com with ESMTPSA id ft5sm26370659wib.4.2015.07.23.03.03.25 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 23 Jul 2015 03:03:25 -0700 (PDT) From: Thomas Leonard To: Minios-devel@lists.xenproject.org Date: Thu, 23 Jul 2015 11:08:37 +0100 Message-Id: <1437646119-32175-1-git-send-email-talex5@gmail.com> X-Mailer: git-send-email 2.4.6 Cc: Thomas Leonard , Ian.Campbell@citrix.com, anil@recoil.org, karim.allah.ahmed@gmail.com, stefano.stabellini@eu.citrix.com, samuel.thibault@ens-lyon.org, Dave.Scott@eu.citrix.com Subject: [Minios-devel] [PATCH ARM v10 0/2] mini-os: initial ARM support X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org This series is based on Karim's ARM support commits, further broken up into smaller patches. Changes since v9: - Added note about IRQ numbers to README - Removed fix for compiling with debug=n (not ARM-specific; will submit separately) Thomas Leonard (2): arm: interrupt controller arm: build system .gitmodules | 3 + COPYING | 27 ++++++ Config.mk | 2 + Makefile | 27 +++++- README | 7 ++ arch/arm/Makefile | 35 ++++++++ arch/arm/arch.mk | 6 ++ arch/arm/gic.c | 238 +++++++++++++++++++++++++++++++++++++++++++++++++++ dtc | 1 + include/lib.h | 4 +- include/libfdt_env.h | 33 +++++++ lib/memmove.c | 45 ++++++++++ lib/string.c | 12 +++ 13 files changed, 438 insertions(+), 2 deletions(-) create mode 100644 .gitmodules create mode 100755 arch/arm/Makefile create mode 100644 arch/arm/arch.mk create mode 100644 arch/arm/gic.c create mode 160000 dtc create mode 100644 include/libfdt_env.h create mode 100644 lib/memmove.c -- 2.4.6 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Jul 27 08:57:50 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 27 Jul 2015 08:57:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZJeEH-0003Bi-FF; Mon, 27 Jul 2015 08:57:49 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZJeEG-0003BY-Pg for minios-devel@lists.xenproject.org; Mon, 27 Jul 2015 08:57:48 +0000 Received: from [85.158.137.68] by server-1.bemta-3.messagelabs.com id 72/47-10437-C82F5B55; Mon, 27 Jul 2015 08:57:48 +0000 X-Env-Sender: prvs=643792544=Ian.Campbell@citrix.com X-Msg-Ref: server-5.tower-31.messagelabs.com!1437987465!29555009!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 18177 invoked from network); 27 Jul 2015 08:57:47 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-5.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 27 Jul 2015 08:57:47 -0000 X-IronPort-AV: E=Sophos;i="5.15,552,1432598400"; d="scan'208";a="287830477" Message-ID: <1437987442.28924.24.camel@citrix.com> From: Ian Campbell To: Andrew Cooper , xen-devel Date: Mon, 27 Jul 2015 09:57:22 +0100 In-Reply-To: <1437563556.12884.32.camel@citrix.com> References: <1436975173.32371.121.camel@citrix.com> <55A681EC.2050508@citrix.com> <1437563556.12884.32.camel@citrix.com> X-Mailer: Evolution 3.16.3-1 MIME-Version: 1.0 X-DLP: MIA1 Cc: minios-devel@lists.xenproject.org, Wei Liu , Stefano Stabellini , Ian Jackson , Roger Pau Monne Subject: Re: [Minios-devel] [Xen-devel] [PATCH v2 0/15+5+5] Begin to disentangle libxenctrl and provide some stable libraries X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Wed, 2015-07-22 at 12:12 +0100, Ian Campbell wrote: > On Wed, 2015-07-15 at 16:53 +0100, Andrew Cooper wrote: > > > > > I'm stilling mulling over putting everything into tools/libs/FOO > > > instead of tools/libxenFOO > > > > On balance, +1. tools/ is already quite a mixed bag of stuff. > > OK, I think I'm going to go ahead with this. > > > > , I still haven't but I could if people think > > > it is worthwhile. Eventually I'd like to split libxc into > > > libxenguest > > > and libxenctrl to cut down on the amount of strange cross talk... > > > > Very much +1. > > OK (eventually ;-)) > > > FWIW, also splitting xl and libxl into different directories. > > Yes, good idea (also "eventually ;-)"). > > While I'm accumulating TODO items in this thread, every library which > gets split out needs a careful review before it should be declared > A[PBI] stable. I'm thinking at least: > > * Consistent error handling (return -1 + setting errno=EFOO) > * Correct types > * Const correctness > * General interface sanity check Explicit unmap operation to match the foreign map, rather than just using munmap (to allow valgrind hooks etc). Ian. _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Jul 27 08:57:50 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 27 Jul 2015 08:57:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZJeEH-0003Bi-FF; Mon, 27 Jul 2015 08:57:49 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZJeEG-0003BY-Pg for minios-devel@lists.xenproject.org; Mon, 27 Jul 2015 08:57:48 +0000 Received: from [85.158.137.68] by server-1.bemta-3.messagelabs.com id 72/47-10437-C82F5B55; Mon, 27 Jul 2015 08:57:48 +0000 X-Env-Sender: prvs=643792544=Ian.Campbell@citrix.com X-Msg-Ref: server-5.tower-31.messagelabs.com!1437987465!29555009!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 18177 invoked from network); 27 Jul 2015 08:57:47 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-5.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 27 Jul 2015 08:57:47 -0000 X-IronPort-AV: E=Sophos;i="5.15,552,1432598400"; d="scan'208";a="287830477" Message-ID: <1437987442.28924.24.camel@citrix.com> From: Ian Campbell To: Andrew Cooper , xen-devel Date: Mon, 27 Jul 2015 09:57:22 +0100 In-Reply-To: <1437563556.12884.32.camel@citrix.com> References: <1436975173.32371.121.camel@citrix.com> <55A681EC.2050508@citrix.com> <1437563556.12884.32.camel@citrix.com> X-Mailer: Evolution 3.16.3-1 MIME-Version: 1.0 X-DLP: MIA1 Cc: minios-devel@lists.xenproject.org, Wei Liu , Stefano Stabellini , Ian Jackson , Roger Pau Monne Subject: Re: [Minios-devel] [Xen-devel] [PATCH v2 0/15+5+5] Begin to disentangle libxenctrl and provide some stable libraries X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Wed, 2015-07-22 at 12:12 +0100, Ian Campbell wrote: > On Wed, 2015-07-15 at 16:53 +0100, Andrew Cooper wrote: > > > > > I'm stilling mulling over putting everything into tools/libs/FOO > > > instead of tools/libxenFOO > > > > On balance, +1. tools/ is already quite a mixed bag of stuff. > > OK, I think I'm going to go ahead with this. > > > > , I still haven't but I could if people think > > > it is worthwhile. Eventually I'd like to split libxc into > > > libxenguest > > > and libxenctrl to cut down on the amount of strange cross talk... > > > > Very much +1. > > OK (eventually ;-)) > > > FWIW, also splitting xl and libxl into different directories. > > Yes, good idea (also "eventually ;-)"). > > While I'm accumulating TODO items in this thread, every library which > gets split out needs a careful review before it should be declared > A[PBI] stable. I'm thinking at least: > > * Consistent error handling (return -1 + setting errno=EFOO) > * Correct types > * Const correctness > * General interface sanity check Explicit unmap operation to match the foreign map, rather than just using munmap (to allow valgrind hooks etc). Ian. _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Jul 29 08:47:13 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 29 Jul 2015 08:47:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZKN15-0005gs-VY; Wed, 29 Jul 2015 08:47:11 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZKN14-0005gn-89 for Minios-devel@lists.xenproject.org; Wed, 29 Jul 2015 08:47:10 +0000 Received: from [193.109.254.147] by server-6.bemta-14.messagelabs.com id 75/D4-16618-D0398B55; Wed, 29 Jul 2015 08:47:09 +0000 X-Env-Sender: prvs=6453b2377=Ian.Campbell@citrix.com X-Msg-Ref: server-7.tower-27.messagelabs.com!1438159616!36119624!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 31529 invoked from network); 29 Jul 2015 08:47:05 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-7.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 29 Jul 2015 08:47:05 -0000 X-IronPort-AV: E=Sophos;i="5.15,569,1432598400"; d="scan'208";a="288764142" Message-ID: <1438159613.11600.171.camel@citrix.com> From: Ian Campbell To: "Manfred Haertel, DB3HM" , xen-users Date: Wed, 29 Jul 2015 09:46:53 +0100 In-Reply-To: <55B7D1D3.7030200@rz-online.de> References: <55B7D1D3.7030200@rz-online.de> X-Mailer: Evolution 3.16.3-1 MIME-Version: 1.0 X-DLP: MIA2 Cc: Minios-devel@lists.xenproject.org Subject: Re: [Minios-devel] [Xen-users] Problems connecting to the daytime application provided with Mini-OS X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org T24gVHVlLCAyMDE1LTA3LTI4IGF0IDIxOjAyICswMjAwLCBNYW5mcmVkIEhhZXJ0ZWwsIERCM0hN IHdyb3RlOgoKSSdtIGNyb3NzIHBvc3RpbmcgdG8gbWluaW9zLWRldmVsIHRvbywganVzdCB0byBr ZWVwIHRoZW0gaW4gdGhlIGxvb3AuCgo+IFDDrnJ2dSBNaWhhaSBzY2hyaWViOgo+IAo+ID4gQmFz aWNhbGx5IHdoYXQgSSdtIHRyeWluZyB0byBkbyBpcyBjb25uZWN0IHRvIHRoZSBkYXl0aW1lIHNl cnZlcgo+ID4gYXBwbGljYXRpb24gbWluaS1vcyBwcm92ZGVzIGZyb20gRG9tMC4gVGhlIElQIGkg c2V0IGlzIDEwLjAuMi4xMC8yNAo+ID4gPGh0dHA6Ly8xMC4wLjIuMTAvMjQ+LiBJIGNhbiBwaW5n IGl0IGp1c3QgZmluZSwgSSBzZWUgaXQgaW4gaWZjb25maWcsIAo+ID4gaXQKPiA+IGlzIGJyaWRn ZWQgd2l0aCB4ZW5icjAuCj4gPiAKPiA+IE1vcmUsIElmIGkgY3JlYXRlIGEgTWluaS1PUyBDbGll bnQsIEkgY2FuIGNvbm5lY3QganVzdCBmaW5lIHRvIGl0LCBJCj4gPiBqdXN0IGNhbid0IGRvIGl0 IGZyb20gZXRoMCAodXNpbmcgbmV0Y2F0LCBvciB3aGF0ZXZlciBzb2NrZXQgbGF5ZXIgCj4gPiBB UEkpLgo+IAo+IEZ1bm55LCBJIHRyaWVkIHRoZSBzYW1lIHRoaW5nIHRvZGF5IChiZWZvcmUgcmVh ZGluZyB5b3VyIG1haWwpLCB3aXRoIHRoZSAKPiBzYW1lIHJlc3VsdHMuCj4gCj4gU28gZWl0aGVy IHdlIG1ha2UgdGhlIHNhbWUgbWlzdGFrZSBvciBkYXl0aW1lIGlzIGJyb2tlbiBpbiBtaW5pLW9z Li4uCgpWZXJ5IGZldyBvZiB0aGUgaW4tdHJlZSBzdHViZG9tcyB1c2UgbmV0d29ya2luZyAob25s eSBwdmdydWIgbWlnaHQsIGJ1dCBJCmJldCBpdCBpc24ndCBjb21tb25seSB1c2VkIHRoYXQgd2F5 LCBzaW5jZSBub3JtYWxseSBwZW9wbGUgYm9vdCBvZiBkaXNrIG5vdApuZXR3b3JrKSBhbmQgSSdt IHByZXR0eSBjZXJ0YWluIHRoYXQgbm9uZSBvZiB0aGVtIHVzZSBkYXl0aW1lIHNwZWNpZmljYWxs eSwKc28gaWYgdGhpcyBldmVyIHdvcmtlZCBJJ2Qgbm90IGJlIHRvbyBzdXJwcmlzZWQgaWYgaXQg aGFkIHJlZ3Jlc3NlZCBhdCBzb21lCnBvaW50IG92ZXIgdGhlIHllYXJzLgoKUGxlYXNlIGNhbiBv bmUgb3IgYm90aCBvZiB5b3UgcHJvdmlkZSBzb21lIGRldGFpbHMgb2YgZXhhY3RseSB3aGF0IHlv dSd2ZQpkb25lL2FyZSBzZWVpbmcsIHNvOgoKICAgICAgKiBXaGljaCBzdHViZG9tIHRhcmdldCB5 b3UgaGF2ZSBidWlsdCwgd2hpY2ggY29uZmlndXJhdGlvbiBpdCBpcwogICAgICAgIHVzaW5nLCB3 aGljaCBiaW5hcnkgeW91IGFyZSBsb2FkaW5nCiAgICAgICogVGhlIGd1ZXN0IENGRyBmaWxlCiAg ICAgICogVGhlIGd1ZXN0IGNvbnNvbGUgbG9nCiAgICAgICogTG9ncyBmcm9tIHRoZSBjcmVhdGlv biBvZiB0aGUgZ3Vlc3QKICAgICAgKiBicmN0bCwgaWZjb25maWcgZXRjIGZyb20gZG9tMC4KICAg ICAgKiBEZXRhaWxzIG9mIHdoYXQgY29tbWFuZHMgcnVuIGluIGRvbTAgYXJlbid0IHdvcmtpbmcu CgpNYXliZSBzb21ldGhpbmcgaW4gdGhlcmUgd2lsbCBnaXZlIHVzIGEgaGludCB3aGVyZSB0byBs b29rIG5leHQuCgpJYW4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCk1pbmlvcy1kZXZlbCBtYWlsaW5nIGxpc3QKTWluaW9zLWRldmVsQGxpc3RzLnhlbnBy b2plY3Qub3JnCmh0dHA6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9jZ2ktYmluL21haWxtYW4vbGlz dGluZm8vbWluaW9zLWRldmVs From minios-devel-bounces@lists.xenproject.org Wed Jul 29 08:47:13 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 29 Jul 2015 08:47:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZKN15-0005gs-VY; Wed, 29 Jul 2015 08:47:11 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZKN14-0005gn-89 for Minios-devel@lists.xenproject.org; Wed, 29 Jul 2015 08:47:10 +0000 Received: from [193.109.254.147] by server-6.bemta-14.messagelabs.com id 75/D4-16618-D0398B55; Wed, 29 Jul 2015 08:47:09 +0000 X-Env-Sender: prvs=6453b2377=Ian.Campbell@citrix.com X-Msg-Ref: server-7.tower-27.messagelabs.com!1438159616!36119624!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 31529 invoked from network); 29 Jul 2015 08:47:05 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-7.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 29 Jul 2015 08:47:05 -0000 X-IronPort-AV: E=Sophos;i="5.15,569,1432598400"; d="scan'208";a="288764142" Message-ID: <1438159613.11600.171.camel@citrix.com> From: Ian Campbell To: "Manfred Haertel, DB3HM" , xen-users Date: Wed, 29 Jul 2015 09:46:53 +0100 In-Reply-To: <55B7D1D3.7030200@rz-online.de> References: <55B7D1D3.7030200@rz-online.de> X-Mailer: Evolution 3.16.3-1 MIME-Version: 1.0 X-DLP: MIA2 Cc: Minios-devel@lists.xenproject.org Subject: Re: [Minios-devel] [Xen-users] Problems connecting to the daytime application provided with Mini-OS X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org T24gVHVlLCAyMDE1LTA3LTI4IGF0IDIxOjAyICswMjAwLCBNYW5mcmVkIEhhZXJ0ZWwsIERCM0hN IHdyb3RlOgoKSSdtIGNyb3NzIHBvc3RpbmcgdG8gbWluaW9zLWRldmVsIHRvbywganVzdCB0byBr ZWVwIHRoZW0gaW4gdGhlIGxvb3AuCgo+IFDDrnJ2dSBNaWhhaSBzY2hyaWViOgo+IAo+ID4gQmFz aWNhbGx5IHdoYXQgSSdtIHRyeWluZyB0byBkbyBpcyBjb25uZWN0IHRvIHRoZSBkYXl0aW1lIHNl cnZlcgo+ID4gYXBwbGljYXRpb24gbWluaS1vcyBwcm92ZGVzIGZyb20gRG9tMC4gVGhlIElQIGkg c2V0IGlzIDEwLjAuMi4xMC8yNAo+ID4gPGh0dHA6Ly8xMC4wLjIuMTAvMjQ+LiBJIGNhbiBwaW5n IGl0IGp1c3QgZmluZSwgSSBzZWUgaXQgaW4gaWZjb25maWcsIAo+ID4gaXQKPiA+IGlzIGJyaWRn ZWQgd2l0aCB4ZW5icjAuCj4gPiAKPiA+IE1vcmUsIElmIGkgY3JlYXRlIGEgTWluaS1PUyBDbGll bnQsIEkgY2FuIGNvbm5lY3QganVzdCBmaW5lIHRvIGl0LCBJCj4gPiBqdXN0IGNhbid0IGRvIGl0 IGZyb20gZXRoMCAodXNpbmcgbmV0Y2F0LCBvciB3aGF0ZXZlciBzb2NrZXQgbGF5ZXIgCj4gPiBB UEkpLgo+IAo+IEZ1bm55LCBJIHRyaWVkIHRoZSBzYW1lIHRoaW5nIHRvZGF5IChiZWZvcmUgcmVh ZGluZyB5b3VyIG1haWwpLCB3aXRoIHRoZSAKPiBzYW1lIHJlc3VsdHMuCj4gCj4gU28gZWl0aGVy IHdlIG1ha2UgdGhlIHNhbWUgbWlzdGFrZSBvciBkYXl0aW1lIGlzIGJyb2tlbiBpbiBtaW5pLW9z Li4uCgpWZXJ5IGZldyBvZiB0aGUgaW4tdHJlZSBzdHViZG9tcyB1c2UgbmV0d29ya2luZyAob25s eSBwdmdydWIgbWlnaHQsIGJ1dCBJCmJldCBpdCBpc24ndCBjb21tb25seSB1c2VkIHRoYXQgd2F5 LCBzaW5jZSBub3JtYWxseSBwZW9wbGUgYm9vdCBvZiBkaXNrIG5vdApuZXR3b3JrKSBhbmQgSSdt IHByZXR0eSBjZXJ0YWluIHRoYXQgbm9uZSBvZiB0aGVtIHVzZSBkYXl0aW1lIHNwZWNpZmljYWxs eSwKc28gaWYgdGhpcyBldmVyIHdvcmtlZCBJJ2Qgbm90IGJlIHRvbyBzdXJwcmlzZWQgaWYgaXQg aGFkIHJlZ3Jlc3NlZCBhdCBzb21lCnBvaW50IG92ZXIgdGhlIHllYXJzLgoKUGxlYXNlIGNhbiBv bmUgb3IgYm90aCBvZiB5b3UgcHJvdmlkZSBzb21lIGRldGFpbHMgb2YgZXhhY3RseSB3aGF0IHlv dSd2ZQpkb25lL2FyZSBzZWVpbmcsIHNvOgoKICAgICAgKiBXaGljaCBzdHViZG9tIHRhcmdldCB5 b3UgaGF2ZSBidWlsdCwgd2hpY2ggY29uZmlndXJhdGlvbiBpdCBpcwogICAgICAgIHVzaW5nLCB3 aGljaCBiaW5hcnkgeW91IGFyZSBsb2FkaW5nCiAgICAgICogVGhlIGd1ZXN0IENGRyBmaWxlCiAg ICAgICogVGhlIGd1ZXN0IGNvbnNvbGUgbG9nCiAgICAgICogTG9ncyBmcm9tIHRoZSBjcmVhdGlv biBvZiB0aGUgZ3Vlc3QKICAgICAgKiBicmN0bCwgaWZjb25maWcgZXRjIGZyb20gZG9tMC4KICAg ICAgKiBEZXRhaWxzIG9mIHdoYXQgY29tbWFuZHMgcnVuIGluIGRvbTAgYXJlbid0IHdvcmtpbmcu CgpNYXliZSBzb21ldGhpbmcgaW4gdGhlcmUgd2lsbCBnaXZlIHVzIGEgaGludCB3aGVyZSB0byBs b29rIG5leHQuCgpJYW4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCk1pbmlvcy1kZXZlbCBtYWlsaW5nIGxpc3QKTWluaW9zLWRldmVsQGxpc3RzLnhlbnBy b2plY3Qub3JnCmh0dHA6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9jZ2ktYmluL21haWxtYW4vbGlz dGluZm8vbWluaW9zLWRldmVs From minios-devel-bounces@lists.xenproject.org Wed Jul 29 10:26:16 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 29 Jul 2015 10:26:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZKOYy-0003cq-Lu; Wed, 29 Jul 2015 10:26:16 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZKOYw-0003cc-Pc for Minios-devel@lists.xenproject.org; Wed, 29 Jul 2015 10:26:14 +0000 Received: from [193.109.254.147] by server-8.bemta-14.messagelabs.com id F9/9A-19110-64AA8B55; Wed, 29 Jul 2015 10:26:14 +0000 X-Env-Sender: mihaicristianpirvu@gmail.com X-Msg-Ref: server-10.tower-27.messagelabs.com!1438165568!36132495!1 X-Originating-IP: [209.85.213.171] X-SpamReason: No, hits=0.9 required=7.0 tests=BODY_RANDOM_LONG, HTML_30_40,HTML_MESSAGE,RCVD_BY_IP X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 12566 invoked from network); 29 Jul 2015 10:26:09 -0000 Received: from mail-ig0-f171.google.com (HELO mail-ig0-f171.google.com) (209.85.213.171) by server-10.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 29 Jul 2015 10:26:09 -0000 Received: by igbpg9 with SMTP id pg9so9418753igb.0 for ; Wed, 29 Jul 2015 03:26:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=IV/7IkLx5bTwX7qra6vg3mveG5C0nxzp8xVX4m8oTcA=; b=n6KUNR6PYiCVrLJdO7AHzcgmBaWES2/hycZsRmdvqhk7NrdL23t07FzfWOsaqeg4uM gFdy+/AyZ08M8QYDn+1ynifg7MWWVrUsmpktmN1AMTYCVcqnKlN+neOsDts/a391pkZE VaN8PEGAktRFjg8pe4pX0dtwF2DxvjV7dbkIR/SkWk0FVrCdDwQOt4soP5cSHRkzpW4z 7wKuUy3yPYr98thxZT2Iroa+elU/uYIJIiCy54A4b4MbYRCPbN1LjQwuspyyni/A6lc+ SOPAbF5TQHmCPuBcTm09YzbhqAqJN2z0wEEAc9MdABkFPuNslPYHfhAoWTxVe6Dkih2i ddqQ== MIME-Version: 1.0 X-Received: by 10.50.67.2 with SMTP id j2mr289865igt.79.1438165568470; Wed, 29 Jul 2015 03:26:08 -0700 (PDT) Received: by 10.107.143.215 with HTTP; Wed, 29 Jul 2015 03:26:08 -0700 (PDT) In-Reply-To: <1438159613.11600.171.camel@citrix.com> References: <55B7D1D3.7030200@rz-online.de> <1438159613.11600.171.camel@citrix.com> Date: Wed, 29 Jul 2015 13:26:08 +0300 Message-ID: From: =?UTF-8?B?UMOucnZ1IE1paGFp?= To: Ian Campbell Cc: Minios-devel@lists.xenproject.org, xen-users , "Manfred Haertel, DB3HM" Subject: Re: [Minios-devel] [Xen-users] Problems connecting to the daytime application provided with Mini-OS X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4052640642480150474==" Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org --===============4052640642480150474== Content-Type: multipart/alternative; boundary=047d7bdc1004d64658051c0103d0 --047d7bdc1004d64658051c0103d0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Alright, here it is, hope we can sort this out: 1. I'm simply compiling Mini-OS from xen/extras/mini-os directory with LWIP support as stated in the README: export LWIPDIR=3D/home/mihai/lwip-1.3.2 and make. It creates this binary: http://pastebin.com/xyyg6P03 I'm not using any stubdom, so I guess the default one is used If I have informed myself good about this. 2. Guest CFG file is : http://pastebin.com/VbkVq6vV and that's it. 3. This is the guest console log: http://pastebin.com/m1AYtJB8 4. This is log from creation of the guest: http://pastebin.com/a8kfu5Fw 5. Here's brctl and ifconfig from dom0: http://pastebin.com/vAvupgLz 6. Alright, here's all the things I've tried so far: 6a) Firstly I though that since eth0 and vifX.0 are bridged, you should be able to netcat to the VM. The pings works fine: This is the mini-so provided daytime which I'm running. The only difference is that I set the IP to 10.0.2.10/24: http://pastebin.com/UURCj36d Here's where I try to ping (works) and netcat (hangs): http://pastebin.com/zHtS01Tg Here's ltrace and strace of netcat, to see what happens: http://pastebin.com/K9vXF5dX It's pretty verbose, but if you look at the last lines, you can see that connect returns EINPROGRESS. 6b) Going further, I created another VM which basically connects to 10.0.2.10/24. This is the code: http://pastebin.com/w9LCmguH Similary to above, here's the verbose creation output: http://pastebin.com/KUKmisRs Here's the console of "Client-OS": http://pastebin.com/bQQS9K9p We can see that IT WORKS, it connects to the IP just fine. So what's happening here? Here's ifconfig and brctl: http://pastebin.com/VwfXCeUu We can see that the interfaces vif5.0 and vif7.0 are bridged together, which makes sense. I get the daytime output from "Server-OS" to "Client-OS", then the "client" thread exits just fine. It works good. 6c) Obviously, I tried to make the same "experiment" using a lwip client, thinking that I need to connect using LWIP API to a LWIP server (which is wrong, I proved this later, I can connect just find using linux sockets to a LWIP server). What I have done at this step is using the netconn API to create a Linux client that connects to 10.0.2.10 and outputs the received daytime value.I have looked up and found out about lwip unix ports and that there is a shared library which I can link with my linux application. Here's the application code: http://pastebin.com/EnfYnzEC Makefile: http://pastebin.com/i5y4cnMd Here's the ifconfig/brctl: http://pastebin.com/QJakkJj6 Tap0 is bridged in xenbr0. How I did this (it's not provided by defualt): https://groups.google.com/forum/#!topic/osdeve_mirror_tcpip_lwip/yQcb1YmeP5= 4 See third answer. Basically I edited contrib/ports/unix/netif/tapif.c which is used in compiling the liblwip.so library so firstly it adds the tap0 linux interface to xenbr0 before tries to connect to 10.0.2.10/24. Here's the ltrace when running the application (SUPER VERBOSE, probably becuase I have to use root permissions to run this due to the creation of the linux interface which requires special permissions): http://pastebin.com/4vG4QMfi It hangs like netcat. 6d) Moving on, I tried to build the daytime application as a linux application (testing purposes, my target is to create a VM that accepts TCP connections from Linux/win32/whatever platform clients). I have used the same liblwip.so library, and I have compiled an application on my Linux PC. For simplicity, I have added my code to the already provided "simhost" application (which is a ping/telnet/http server application for lwip on linux). I compile that and it works just fine, I can even connect with netcat 10.0.0.2 13 (the default IP the application binds on) and it prints the daytime output. Thus I have concluded that you can connect with regular socket application to a LWIP server if it's configured properly. PS: This application comes in the "contrib-1.3.2" archive from LWIP site at ports/unix/proj/lib (for the shared library) and ports/unix/proj/simhost (for the http server/telnet/ping answerer). Sorry for the extremly long mail, but I wanted to show you all the things I've done so maybe you understand where I've gone wrong and what I should've done better. Tell me if you need additional info. Mihai On Wed, Jul 29, 2015 at 11:46 AM, Ian Campbell wrote: > On Tue, 2015-07-28 at 21:02 +0200, Manfred Haertel, DB3HM wrote: > > I'm cross posting to minios-devel too, just to keep them in the loop. > > > P=C3=AErvu Mihai schrieb: > > > > > Basically what I'm trying to do is connect to the daytime server > > > application mini-os provdes from Dom0. The IP i set is 10.0.2.10/24 > > > . I can ping it just fine, I see it in ifconfig, > > > it > > > is bridged with xenbr0. > > > > > > More, If i create a Mini-OS Client, I can connect just fine to it, I > > > just can't do it from eth0 (using netcat, or whatever socket layer > > > API). > > > > Funny, I tried the same thing today (before reading your mail), with th= e > > same results. > > > > So either we make the same mistake or daytime is broken in mini-os... > > Very few of the in-tree stubdoms use networking (only pvgrub might, but I > bet it isn't commonly used that way, since normally people boot of disk n= ot > network) and I'm pretty certain that none of them use daytime specificall= y, > so if this ever worked I'd not be too surprised if it had regressed at so= me > point over the years. > > Please can one or both of you provide some details of exactly what you've > done/are seeing, so: > > * Which stubdom target you have built, which configuration it is > using, which binary you are loading > * The guest CFG file > * The guest console log > * Logs from the creation of the guest > * brctl, ifconfig etc from dom0. > * Details of what commands run in dom0 aren't working. > > Maybe something in there will give us a hint where to look next. > > Ian > > _______________________________________________ > Minios-devel mailing list > Minios-devel@lists.xenproject.org > http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel --047d7bdc1004d64658051c0103d0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Alright, here it is, hope we can sort this out:

1. I'm simply compiling Mini-OS from xen/extras/mini-os direct= ory with LWIP support as stated in the README:=C2=A0
=C2=A0 =C2= =A0 =C2=A0 =C2=A0export LWIPDIR=3D/home/mihai/lwip-1.3.2 and make.
=C2=A0 It creates this binary: h= ttp://pastebin.com/xyyg6P03

=C2=A0 I'm not= using any stubdom, so I guess the default one is used If I have informed m= yself good about this.

2. Guest CFG file is : =C2= =A0http://pastebin.com/VbkVq6vV and that's it.


4. This is log from creation of the guest= : http://pastebin.com/a8kfu5Fw=

5. Here's brctl and ifconfig from dom0:=C2=A0= http://pastebin.com/vAvupgLz

6. Alright, here's all the things I've trie= d so far:

6a) Firstly I though that since eth0 and= vifX.0 are bridged, you should be able to netcat to the VM. The pings work= s fine:=C2=A0
=C2=A0 This is the mini-so provided daytime which I= 'm running. The only difference is that I set the IP to 10.0.2.10/24: http://pastebin.com/UURCj36d
=C2=A0=C2=A0
=C2=A0 H= ere's where I try to ping (works) and netcat (hangs): http://pastebin.com/zHtS01Tg
=C2=A0 H= ere's ltrace and strace of netcat, to see what happens: =C2=A0http://pastebin.com/K9vXF5dX
=C2=A0 It's pretty verbose, but if you look at the last lines, you ca= n see that connect returns EINPROGRESS.

6b) Going = further, I created another VM which basically connects to 10.0.2.10/24. This is the code: http://pastebin.com/w9LCmguH
Similary to abo= ve, here's the verbose creation output: http://pastebin.com/KUKmisRs
Here's the console= of "Client-OS": http://= pastebin.com/bQQS9K9p
We can see that IT WORKS, it connects t= o the IP just fine. So what's happening here?

= Here's ifconfig and brctl: htt= p://pastebin.com/VwfXCeUu
We can see that the interfaces vif5= .0 and vif7.0 are bridged together, which makes sense. I get the daytime ou= tput from "Server-OS" to "Client-OS", then the "cl= ient" thread exits just fine. It works good.

= 6c) Obviously, I tried to make the same "experiment" using a lwip= client, thinking that I need to connect using LWIP API to a LWIP server (w= hich is wrong, I proved this later, I can connect just find using linux soc= kets to a LWIP server).

What I have done at this s= tep is using the netconn =C2=A0API to create a Linux client that connects t= o 10.0.2.10 and outputs the received daytime value.I have looked up and fou= nd out about lwip unix ports and that there is a shared library which I can= link with my linux application.

Here's the ap= plication code:=C2=A0http://pasteb= in.com/EnfYnzEC
Here's the ifconf= ig/brctl:=C2=A0http://pastebin.com= /QJakkJj6

Tap0 is bridged in xenbr0. How I did= this (it's not provided by defualt):=C2=A0https://groups= .google.com/forum/#!topic/osdeve_mirror_tcpip_lwip/yQcb1YmeP54

See third answer. Basically I edited=C2=A0=C2=A0contrib/ports/u= nix/netif/tapif.c which is used in compiling the liblwip.so library so fi= rstly it adds the tap0 linux interface to xenbr0 before tries to connect to= 10.0.2.10/24.=C2=A0
<= span style=3D"font-size:13px;font-family:Arial,Helvetica,sans-serif">
Here's the ltrace when running the application (SUPER VERBOS= E, probably becuase I have to use root permissions to run this due to the c= reation of the linux interface which requires special permissions):=C2=A0http://pastebin.com/4vG4QMfi

It hangs like netcat.

6d) Moving on, I tried= to build the daytime application as a linux application (testing purposes,= my target is to create a VM that accepts TCP connections from Linux/win32/= whatever platform clients). I have used the same liblwip.so library, and I = have compiled an application on my Linux PC. For simplicity, I have added m= y code to the already provided "simhost" application (which is a = ping/telnet/http server application for lwip on linux). I compile that and = it works just fine, I can even connect with netcat 10.0.0.2 13 (the default= IP the application binds on) and it prints the daytime output. Thus I have= concluded that you can connect with regular socket application to a LWIP s= erver if it's configured properly.=C2=A0

PS: This application comes in the "contrib-1.3.2" archive from L= WIP site at ports/unix/proj/lib (for the shared library) and ports/unix/pro= j/simhost (for the http server/telnet/ping answerer).

=C2=A0=C2=A0

Sorry for the extremly= long mail, but I wanted to show you all the things I've done so maybe = you understand where I've gone wrong and what I should've done bett= er.=C2=A0 Tell me if you need additional info.

Mihai

On Wed, Jul 29, 2015 at 11:46 AM, Ian Campbell <ian.camp= bell@citrix.com> wrote:
On = Tue, 2015-07-28 at 21:02 +0200, Manfred Haertel, DB3HM wrote:

I'm cross posting to minios-devel too, just to keep them in the loop.
> P=C3=AErvu Mihai schrieb:
>
> > Basically what I'm trying to do is connect to the daytime ser= ver
> > application mini-os provdes from Dom0. The IP i set is 10.0.2.10= /24
> > <http://10.0.2.10/24>. I can ping it just fine, I see it in i= fconfig,
> > it
> > is bridged with xenbr0.
> >
> > More, If i create a Mini-OS Client, I can connect just fine to it= , I
> > just can't do it from eth0 (using netcat, or whatever socket = layer
> > API).
>
> Funny, I tried the same thing today (before re= ading your mail), with the
> same results.
>
> So either we make the same mistake or daytime is broken in mini-os...<= br>
Very few of the in-tree stubdoms use networking (only pvgrub might, = but I
bet it isn't commonly used that way, since normally people boot of disk= not
network) and I'm pretty certain that none of them use daytime specifica= lly,
so if this ever worked I'd not be too surprised if it had regressed at = some
point over the years.

Please can one or both of you provide some details of exactly what you'= ve
done/are seeing, so:

=C2=A0 =C2=A0 =C2=A0 * Which stubdom target you have built, which configura= tion it is
=C2=A0 =C2=A0 =C2=A0 =C2=A0 using, which binary you are loading
=C2=A0 =C2=A0 =C2=A0 * The guest CFG file
=C2=A0 =C2=A0 =C2=A0 * The guest console log
=C2=A0 =C2=A0 =C2=A0 * Logs from the creation of the guest
=C2=A0 =C2=A0 =C2=A0 * brctl, ifconfig etc from dom0.
=C2=A0 =C2=A0 =C2=A0 * Details of what commands run in dom0 aren't work= ing.

Maybe something in there will give us a hint where to look next.

Ian

_______________________________________________
Minios-devel mailing list
Minios-devel@lists.xen= project.org
http://lists.xenproject.org/cgi-bin= /mailman/listinfo/minios-devel

--047d7bdc1004d64658051c0103d0-- --===============4052640642480150474== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel --===============4052640642480150474==-- From minios-devel-bounces@lists.xenproject.org Wed Jul 29 10:26:16 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 29 Jul 2015 10:26:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZKOYy-0003cq-Lu; Wed, 29 Jul 2015 10:26:16 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZKOYw-0003cc-Pc for Minios-devel@lists.xenproject.org; Wed, 29 Jul 2015 10:26:14 +0000 Received: from [193.109.254.147] by server-8.bemta-14.messagelabs.com id F9/9A-19110-64AA8B55; Wed, 29 Jul 2015 10:26:14 +0000 X-Env-Sender: mihaicristianpirvu@gmail.com X-Msg-Ref: server-10.tower-27.messagelabs.com!1438165568!36132495!1 X-Originating-IP: [209.85.213.171] X-SpamReason: No, hits=0.9 required=7.0 tests=BODY_RANDOM_LONG, HTML_30_40,HTML_MESSAGE,RCVD_BY_IP X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 12566 invoked from network); 29 Jul 2015 10:26:09 -0000 Received: from mail-ig0-f171.google.com (HELO mail-ig0-f171.google.com) (209.85.213.171) by server-10.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 29 Jul 2015 10:26:09 -0000 Received: by igbpg9 with SMTP id pg9so9418753igb.0 for ; Wed, 29 Jul 2015 03:26:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=IV/7IkLx5bTwX7qra6vg3mveG5C0nxzp8xVX4m8oTcA=; b=n6KUNR6PYiCVrLJdO7AHzcgmBaWES2/hycZsRmdvqhk7NrdL23t07FzfWOsaqeg4uM gFdy+/AyZ08M8QYDn+1ynifg7MWWVrUsmpktmN1AMTYCVcqnKlN+neOsDts/a391pkZE VaN8PEGAktRFjg8pe4pX0dtwF2DxvjV7dbkIR/SkWk0FVrCdDwQOt4soP5cSHRkzpW4z 7wKuUy3yPYr98thxZT2Iroa+elU/uYIJIiCy54A4b4MbYRCPbN1LjQwuspyyni/A6lc+ SOPAbF5TQHmCPuBcTm09YzbhqAqJN2z0wEEAc9MdABkFPuNslPYHfhAoWTxVe6Dkih2i ddqQ== MIME-Version: 1.0 X-Received: by 10.50.67.2 with SMTP id j2mr289865igt.79.1438165568470; Wed, 29 Jul 2015 03:26:08 -0700 (PDT) Received: by 10.107.143.215 with HTTP; Wed, 29 Jul 2015 03:26:08 -0700 (PDT) In-Reply-To: <1438159613.11600.171.camel@citrix.com> References: <55B7D1D3.7030200@rz-online.de> <1438159613.11600.171.camel@citrix.com> Date: Wed, 29 Jul 2015 13:26:08 +0300 Message-ID: From: =?UTF-8?B?UMOucnZ1IE1paGFp?= To: Ian Campbell Cc: Minios-devel@lists.xenproject.org, xen-users , "Manfred Haertel, DB3HM" Subject: Re: [Minios-devel] [Xen-users] Problems connecting to the daytime application provided with Mini-OS X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4052640642480150474==" Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org --===============4052640642480150474== Content-Type: multipart/alternative; boundary=047d7bdc1004d64658051c0103d0 --047d7bdc1004d64658051c0103d0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Alright, here it is, hope we can sort this out: 1. I'm simply compiling Mini-OS from xen/extras/mini-os directory with LWIP support as stated in the README: export LWIPDIR=3D/home/mihai/lwip-1.3.2 and make. It creates this binary: http://pastebin.com/xyyg6P03 I'm not using any stubdom, so I guess the default one is used If I have informed myself good about this. 2. Guest CFG file is : http://pastebin.com/VbkVq6vV and that's it. 3. This is the guest console log: http://pastebin.com/m1AYtJB8 4. This is log from creation of the guest: http://pastebin.com/a8kfu5Fw 5. Here's brctl and ifconfig from dom0: http://pastebin.com/vAvupgLz 6. Alright, here's all the things I've tried so far: 6a) Firstly I though that since eth0 and vifX.0 are bridged, you should be able to netcat to the VM. The pings works fine: This is the mini-so provided daytime which I'm running. The only difference is that I set the IP to 10.0.2.10/24: http://pastebin.com/UURCj36d Here's where I try to ping (works) and netcat (hangs): http://pastebin.com/zHtS01Tg Here's ltrace and strace of netcat, to see what happens: http://pastebin.com/K9vXF5dX It's pretty verbose, but if you look at the last lines, you can see that connect returns EINPROGRESS. 6b) Going further, I created another VM which basically connects to 10.0.2.10/24. This is the code: http://pastebin.com/w9LCmguH Similary to above, here's the verbose creation output: http://pastebin.com/KUKmisRs Here's the console of "Client-OS": http://pastebin.com/bQQS9K9p We can see that IT WORKS, it connects to the IP just fine. So what's happening here? Here's ifconfig and brctl: http://pastebin.com/VwfXCeUu We can see that the interfaces vif5.0 and vif7.0 are bridged together, which makes sense. I get the daytime output from "Server-OS" to "Client-OS", then the "client" thread exits just fine. It works good. 6c) Obviously, I tried to make the same "experiment" using a lwip client, thinking that I need to connect using LWIP API to a LWIP server (which is wrong, I proved this later, I can connect just find using linux sockets to a LWIP server). What I have done at this step is using the netconn API to create a Linux client that connects to 10.0.2.10 and outputs the received daytime value.I have looked up and found out about lwip unix ports and that there is a shared library which I can link with my linux application. Here's the application code: http://pastebin.com/EnfYnzEC Makefile: http://pastebin.com/i5y4cnMd Here's the ifconfig/brctl: http://pastebin.com/QJakkJj6 Tap0 is bridged in xenbr0. How I did this (it's not provided by defualt): https://groups.google.com/forum/#!topic/osdeve_mirror_tcpip_lwip/yQcb1YmeP5= 4 See third answer. Basically I edited contrib/ports/unix/netif/tapif.c which is used in compiling the liblwip.so library so firstly it adds the tap0 linux interface to xenbr0 before tries to connect to 10.0.2.10/24. Here's the ltrace when running the application (SUPER VERBOSE, probably becuase I have to use root permissions to run this due to the creation of the linux interface which requires special permissions): http://pastebin.com/4vG4QMfi It hangs like netcat. 6d) Moving on, I tried to build the daytime application as a linux application (testing purposes, my target is to create a VM that accepts TCP connections from Linux/win32/whatever platform clients). I have used the same liblwip.so library, and I have compiled an application on my Linux PC. For simplicity, I have added my code to the already provided "simhost" application (which is a ping/telnet/http server application for lwip on linux). I compile that and it works just fine, I can even connect with netcat 10.0.0.2 13 (the default IP the application binds on) and it prints the daytime output. Thus I have concluded that you can connect with regular socket application to a LWIP server if it's configured properly. PS: This application comes in the "contrib-1.3.2" archive from LWIP site at ports/unix/proj/lib (for the shared library) and ports/unix/proj/simhost (for the http server/telnet/ping answerer). Sorry for the extremly long mail, but I wanted to show you all the things I've done so maybe you understand where I've gone wrong and what I should've done better. Tell me if you need additional info. Mihai On Wed, Jul 29, 2015 at 11:46 AM, Ian Campbell wrote: > On Tue, 2015-07-28 at 21:02 +0200, Manfred Haertel, DB3HM wrote: > > I'm cross posting to minios-devel too, just to keep them in the loop. > > > P=C3=AErvu Mihai schrieb: > > > > > Basically what I'm trying to do is connect to the daytime server > > > application mini-os provdes from Dom0. The IP i set is 10.0.2.10/24 > > > . I can ping it just fine, I see it in ifconfig, > > > it > > > is bridged with xenbr0. > > > > > > More, If i create a Mini-OS Client, I can connect just fine to it, I > > > just can't do it from eth0 (using netcat, or whatever socket layer > > > API). > > > > Funny, I tried the same thing today (before reading your mail), with th= e > > same results. > > > > So either we make the same mistake or daytime is broken in mini-os... > > Very few of the in-tree stubdoms use networking (only pvgrub might, but I > bet it isn't commonly used that way, since normally people boot of disk n= ot > network) and I'm pretty certain that none of them use daytime specificall= y, > so if this ever worked I'd not be too surprised if it had regressed at so= me > point over the years. > > Please can one or both of you provide some details of exactly what you've > done/are seeing, so: > > * Which stubdom target you have built, which configuration it is > using, which binary you are loading > * The guest CFG file > * The guest console log > * Logs from the creation of the guest > * brctl, ifconfig etc from dom0. > * Details of what commands run in dom0 aren't working. > > Maybe something in there will give us a hint where to look next. > > Ian > > _______________________________________________ > Minios-devel mailing list > Minios-devel@lists.xenproject.org > http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel --047d7bdc1004d64658051c0103d0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Alright, here it is, hope we can sort this out:

1. I'm simply compiling Mini-OS from xen/extras/mini-os direct= ory with LWIP support as stated in the README:=C2=A0
=C2=A0 =C2= =A0 =C2=A0 =C2=A0export LWIPDIR=3D/home/mihai/lwip-1.3.2 and make.
=C2=A0 It creates this binary: h= ttp://pastebin.com/xyyg6P03

=C2=A0 I'm not= using any stubdom, so I guess the default one is used If I have informed m= yself good about this.

2. Guest CFG file is : =C2= =A0http://pastebin.com/VbkVq6vV and that's it.


4. This is log from creation of the guest= : http://pastebin.com/a8kfu5Fw=

5. Here's brctl and ifconfig from dom0:=C2=A0= http://pastebin.com/vAvupgLz

6. Alright, here's all the things I've trie= d so far:

6a) Firstly I though that since eth0 and= vifX.0 are bridged, you should be able to netcat to the VM. The pings work= s fine:=C2=A0
=C2=A0 This is the mini-so provided daytime which I= 'm running. The only difference is that I set the IP to 10.0.2.10/24: http://pastebin.com/UURCj36d
=C2=A0=C2=A0
=C2=A0 H= ere's where I try to ping (works) and netcat (hangs): http://pastebin.com/zHtS01Tg
=C2=A0 H= ere's ltrace and strace of netcat, to see what happens: =C2=A0http://pastebin.com/K9vXF5dX
=C2=A0 It's pretty verbose, but if you look at the last lines, you ca= n see that connect returns EINPROGRESS.

6b) Going = further, I created another VM which basically connects to 10.0.2.10/24. This is the code: http://pastebin.com/w9LCmguH
Similary to abo= ve, here's the verbose creation output: http://pastebin.com/KUKmisRs
Here's the console= of "Client-OS": http://= pastebin.com/bQQS9K9p
We can see that IT WORKS, it connects t= o the IP just fine. So what's happening here?

= Here's ifconfig and brctl: htt= p://pastebin.com/VwfXCeUu
We can see that the interfaces vif5= .0 and vif7.0 are bridged together, which makes sense. I get the daytime ou= tput from "Server-OS" to "Client-OS", then the "cl= ient" thread exits just fine. It works good.

= 6c) Obviously, I tried to make the same "experiment" using a lwip= client, thinking that I need to connect using LWIP API to a LWIP server (w= hich is wrong, I proved this later, I can connect just find using linux soc= kets to a LWIP server).

What I have done at this s= tep is using the netconn =C2=A0API to create a Linux client that connects t= o 10.0.2.10 and outputs the received daytime value.I have looked up and fou= nd out about lwip unix ports and that there is a shared library which I can= link with my linux application.

Here's the ap= plication code:=C2=A0http://pasteb= in.com/EnfYnzEC
Here's the ifconf= ig/brctl:=C2=A0http://pastebin.com= /QJakkJj6

Tap0 is bridged in xenbr0. How I did= this (it's not provided by defualt):=C2=A0https://groups= .google.com/forum/#!topic/osdeve_mirror_tcpip_lwip/yQcb1YmeP54

See third answer. Basically I edited=C2=A0=C2=A0contrib/ports/u= nix/netif/tapif.c which is used in compiling the liblwip.so library so fi= rstly it adds the tap0 linux interface to xenbr0 before tries to connect to= 10.0.2.10/24.=C2=A0
<= span style=3D"font-size:13px;font-family:Arial,Helvetica,sans-serif">
Here's the ltrace when running the application (SUPER VERBOS= E, probably becuase I have to use root permissions to run this due to the c= reation of the linux interface which requires special permissions):=C2=A0http://pastebin.com/4vG4QMfi

It hangs like netcat.

6d) Moving on, I tried= to build the daytime application as a linux application (testing purposes,= my target is to create a VM that accepts TCP connections from Linux/win32/= whatever platform clients). I have used the same liblwip.so library, and I = have compiled an application on my Linux PC. For simplicity, I have added m= y code to the already provided "simhost" application (which is a = ping/telnet/http server application for lwip on linux). I compile that and = it works just fine, I can even connect with netcat 10.0.0.2 13 (the default= IP the application binds on) and it prints the daytime output. Thus I have= concluded that you can connect with regular socket application to a LWIP s= erver if it's configured properly.=C2=A0

PS: This application comes in the "contrib-1.3.2" archive from L= WIP site at ports/unix/proj/lib (for the shared library) and ports/unix/pro= j/simhost (for the http server/telnet/ping answerer).

=C2=A0=C2=A0

Sorry for the extremly= long mail, but I wanted to show you all the things I've done so maybe = you understand where I've gone wrong and what I should've done bett= er.=C2=A0 Tell me if you need additional info.

Mihai

On Wed, Jul 29, 2015 at 11:46 AM, Ian Campbell <ian.camp= bell@citrix.com> wrote:
On = Tue, 2015-07-28 at 21:02 +0200, Manfred Haertel, DB3HM wrote:

I'm cross posting to minios-devel too, just to keep them in the loop.
> P=C3=AErvu Mihai schrieb:
>
> > Basically what I'm trying to do is connect to the daytime ser= ver
> > application mini-os provdes from Dom0. The IP i set is 10.0.2.10= /24
> > <http://10.0.2.10/24>. I can ping it just fine, I see it in i= fconfig,
> > it
> > is bridged with xenbr0.
> >
> > More, If i create a Mini-OS Client, I can connect just fine to it= , I
> > just can't do it from eth0 (using netcat, or whatever socket = layer
> > API).
>
> Funny, I tried the same thing today (before re= ading your mail), with the
> same results.
>
> So either we make the same mistake or daytime is broken in mini-os...<= br>
Very few of the in-tree stubdoms use networking (only pvgrub might, = but I
bet it isn't commonly used that way, since normally people boot of disk= not
network) and I'm pretty certain that none of them use daytime specifica= lly,
so if this ever worked I'd not be too surprised if it had regressed at = some
point over the years.

Please can one or both of you provide some details of exactly what you'= ve
done/are seeing, so:

=C2=A0 =C2=A0 =C2=A0 * Which stubdom target you have built, which configura= tion it is
=C2=A0 =C2=A0 =C2=A0 =C2=A0 using, which binary you are loading
=C2=A0 =C2=A0 =C2=A0 * The guest CFG file
=C2=A0 =C2=A0 =C2=A0 * The guest console log
=C2=A0 =C2=A0 =C2=A0 * Logs from the creation of the guest
=C2=A0 =C2=A0 =C2=A0 * brctl, ifconfig etc from dom0.
=C2=A0 =C2=A0 =C2=A0 * Details of what commands run in dom0 aren't work= ing.

Maybe something in there will give us a hint where to look next.

Ian

_______________________________________________
Minios-devel mailing list
Minios-devel@lists.xen= project.org
http://lists.xenproject.org/cgi-bin= /mailman/listinfo/minios-devel

--047d7bdc1004d64658051c0103d0-- --===============4052640642480150474== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel --===============4052640642480150474==-- From minios-devel-bounces@lists.xenproject.org Wed Jul 29 15:04:32 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 29 Jul 2015 15:04:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZKSuG-00067v-DB; Wed, 29 Jul 2015 15:04:32 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZKSuF-00067M-4F for Minios-devel@lists.xenproject.org; Wed, 29 Jul 2015 15:04:31 +0000 Received: from [193.109.254.147] by server-10.bemta-14.messagelabs.com id 0A/AD-01143-B7BE8B55; Wed, 29 Jul 2015 15:04:27 +0000 X-Env-Sender: prvs=6453b2377=Ian.Campbell@citrix.com X-Msg-Ref: server-10.tower-27.messagelabs.com!1438182265!36228600!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 13037 invoked from network); 29 Jul 2015 15:04:26 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-10.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 29 Jul 2015 15:04:26 -0000 X-IronPort-AV: E=Sophos;i="5.15,571,1432598400"; d="scan'208";a="285678707" Message-ID: <1438182258.11600.208.camel@citrix.com> From: Ian Campbell To: =?ISO-8859-1?Q?P=EErvu?= Mihai Date: Wed, 29 Jul 2015 16:04:18 +0100 In-Reply-To: References: <55B7D1D3.7030200@rz-online.de> <1438159613.11600.171.camel@citrix.com> X-Mailer: Evolution 3.16.3-1 MIME-Version: 1.0 X-DLP: MIA2 Cc: Minios-devel@lists.xenproject.org, xen-users , "Manfred Haertel, DB3HM" Subject: Re: [Minios-devel] [Xen-users] Problems connecting to the daytime application provided with Mini-OS X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org T24gV2VkLCAyMDE1LTA3LTI5IGF0IDEzOjI2ICswMzAwLCBQw65ydnUgTWloYWkgd3JvdGU6Cj4g QWxyaWdodCwgaGVyZSBpdCBpcywgaG9wZSB3ZSBjYW4gc29ydCB0aGlzIG91dDoKClRoYW5rcywg SSB0b29rIHdoYXQgeW91IGhhZCwgYnV0IHVzaW5nIHRoZSBsd2lwLTEuMy4wICsgcGF0Y2hlcyBm cm9tCnhlbi5naXQvc3R1YmRvbSAoanVzdCBiZWNhdXNlIHRoZXkgd2VyZSB0byBoYW5kKSBhbmQg cmVwcm9kIHdoYXQgeW91J3ZlCmJlZW4gc2VlaW5nLgoKVGhlbiAob24gYSBodW5jaCkgSSBkaWQg ImV0aHRvb2wgLUsgdmlmMTMuMCB0eCBvZmYiIGFuZCBpdCBzdGFydGVkIHdvcmtpbmcuCgpTbyBJ IHRoaW5rIHRoZXJlIG11c3QgYmUgYSBidWcgZWl0aGVyIGluIG1pbmktb3MncyBuZXRmcm9udCBj aGVja3N1bQpvZmZsb2FkLCBvciBpbiB0aGUgbmVnb3RpYXRpb24gaXQgZG9lcyB3aXRoIG5ldGJh Y2suCgpIb3BlZnVsbHkgdGhhdCBpcyBlbm91Z2ggZm9yIHNvbWVvbmUgdG8gYmUgZ29pbmcgb24g d2l0aC4KCklhbi4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCk1pbmlvcy1kZXZlbCBtYWlsaW5nIGxpc3QKTWluaW9zLWRldmVsQGxpc3RzLnhlbnByb2pl Y3Qub3JnCmh0dHA6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9jZ2ktYmluL21haWxtYW4vbGlzdGlu Zm8vbWluaW9zLWRldmVs From minios-devel-bounces@lists.xenproject.org Wed Jul 29 15:04:32 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 29 Jul 2015 15:04:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZKSuG-00067v-DB; Wed, 29 Jul 2015 15:04:32 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZKSuF-00067M-4F for Minios-devel@lists.xenproject.org; Wed, 29 Jul 2015 15:04:31 +0000 Received: from [193.109.254.147] by server-10.bemta-14.messagelabs.com id 0A/AD-01143-B7BE8B55; Wed, 29 Jul 2015 15:04:27 +0000 X-Env-Sender: prvs=6453b2377=Ian.Campbell@citrix.com X-Msg-Ref: server-10.tower-27.messagelabs.com!1438182265!36228600!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 13037 invoked from network); 29 Jul 2015 15:04:26 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-10.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 29 Jul 2015 15:04:26 -0000 X-IronPort-AV: E=Sophos;i="5.15,571,1432598400"; d="scan'208";a="285678707" Message-ID: <1438182258.11600.208.camel@citrix.com> From: Ian Campbell To: =?ISO-8859-1?Q?P=EErvu?= Mihai Date: Wed, 29 Jul 2015 16:04:18 +0100 In-Reply-To: References: <55B7D1D3.7030200@rz-online.de> <1438159613.11600.171.camel@citrix.com> X-Mailer: Evolution 3.16.3-1 MIME-Version: 1.0 X-DLP: MIA2 Cc: Minios-devel@lists.xenproject.org, xen-users , "Manfred Haertel, DB3HM" Subject: Re: [Minios-devel] [Xen-users] Problems connecting to the daytime application provided with Mini-OS X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org T24gV2VkLCAyMDE1LTA3LTI5IGF0IDEzOjI2ICswMzAwLCBQw65ydnUgTWloYWkgd3JvdGU6Cj4g QWxyaWdodCwgaGVyZSBpdCBpcywgaG9wZSB3ZSBjYW4gc29ydCB0aGlzIG91dDoKClRoYW5rcywg SSB0b29rIHdoYXQgeW91IGhhZCwgYnV0IHVzaW5nIHRoZSBsd2lwLTEuMy4wICsgcGF0Y2hlcyBm cm9tCnhlbi5naXQvc3R1YmRvbSAoanVzdCBiZWNhdXNlIHRoZXkgd2VyZSB0byBoYW5kKSBhbmQg cmVwcm9kIHdoYXQgeW91J3ZlCmJlZW4gc2VlaW5nLgoKVGhlbiAob24gYSBodW5jaCkgSSBkaWQg ImV0aHRvb2wgLUsgdmlmMTMuMCB0eCBvZmYiIGFuZCBpdCBzdGFydGVkIHdvcmtpbmcuCgpTbyBJ IHRoaW5rIHRoZXJlIG11c3QgYmUgYSBidWcgZWl0aGVyIGluIG1pbmktb3MncyBuZXRmcm9udCBj aGVja3N1bQpvZmZsb2FkLCBvciBpbiB0aGUgbmVnb3RpYXRpb24gaXQgZG9lcyB3aXRoIG5ldGJh Y2suCgpIb3BlZnVsbHkgdGhhdCBpcyBlbm91Z2ggZm9yIHNvbWVvbmUgdG8gYmUgZ29pbmcgb24g d2l0aC4KCklhbi4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCk1pbmlvcy1kZXZlbCBtYWlsaW5nIGxpc3QKTWluaW9zLWRldmVsQGxpc3RzLnhlbnByb2pl Y3Qub3JnCmh0dHA6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9jZ2ktYmluL21haWxtYW4vbGlzdGlu Zm8vbWluaW9zLWRldmVs From minios-devel-bounces@lists.xenproject.org Wed Jul 29 15:50:34 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 29 Jul 2015 15:50:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZKTco-0001XC-0K; Wed, 29 Jul 2015 15:50:34 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZKTcm-0001Wx-QU for Minios-devel@lists.xenproject.org; Wed, 29 Jul 2015 15:50:32 +0000 Received: from [85.158.137.68] by server-14.bemta-3.messagelabs.com id DF/9B-05979-746F8B55; Wed, 29 Jul 2015 15:50:31 +0000 X-Env-Sender: mihaicristianpirvu@gmail.com X-Msg-Ref: server-4.tower-31.messagelabs.com!1438185028!29179701!1 X-Originating-IP: [209.85.223.176] X-SpamReason: No, hits=0.4 required=7.0 tests=HTML_30_40,HTML_MESSAGE, RCVD_BY_IP X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 797 invoked from network); 29 Jul 2015 15:50:29 -0000 Received: from mail-io0-f176.google.com (HELO mail-io0-f176.google.com) (209.85.223.176) by server-4.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 29 Jul 2015 15:50:29 -0000 Received: by ioii16 with SMTP id i16so25727638ioi.0 for ; Wed, 29 Jul 2015 08:50:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Hhh9FcMHFJR9mLYei3htHd91yx7I3bRkbi/9vPBYWbA=; b=QXufhp3vOMYKLTSoVWOIekxTNfkKZKKB5NH5OF/ejNtXk/wYAH0KkG695vu2YDRXMJ AmhYEx9gESOo8AfFBHsmPYQe67NlJqkLDL7IQri9EeK/Tqylv5QfE3aQ+hzVCMjOgwPD GeIvlk20dxLxc4hUnpN5JZLNjhXEQe3ifcL9T1DBZ5oQjAq6GD2SnWnlrAmsVz1feNbA dXjYHRaz492cW/l6Sm8eLKym+oHGe9xSFrlRa2Ki9tEqpenKaKn3b/OYly/lQ09UJuhp 2nj2frLOJSO370QdUSoIJeFMb2zW6vJdQ0HpRtP3lO3ShP0wWyQWnH6ayQzREtLoVdQD 4XuQ== MIME-Version: 1.0 X-Received: by 10.107.37.134 with SMTP id l128mr2796954iol.92.1438185028080; Wed, 29 Jul 2015 08:50:28 -0700 (PDT) Received: by 10.107.143.215 with HTTP; Wed, 29 Jul 2015 08:50:28 -0700 (PDT) In-Reply-To: <1438182258.11600.208.camel@citrix.com> References: <55B7D1D3.7030200@rz-online.de> <1438159613.11600.171.camel@citrix.com> <1438182258.11600.208.camel@citrix.com> Date: Wed, 29 Jul 2015 18:50:28 +0300 Message-ID: From: =?UTF-8?B?UMOucnZ1IE1paGFp?= To: Ian Campbell Cc: Minios-devel@lists.xenproject.org, xen-users , "Manfred Haertel, DB3HM" Subject: Re: [Minios-devel] [Xen-users] Problems connecting to the daytime application provided with Mini-OS X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4474196108860116119==" Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org --===============4474196108860116119== Content-Type: multipart/alternative; boundary=001a1140ea86b859ed051c058bda --001a1140ea86b859ed051c058bda Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I've been on this for like 10 days and you have found a solution in few hours. Thanks you, I guess this shows the difference in experience over this project :) Hope this gets sorted out. Mihai On Wed, Jul 29, 2015 at 6:04 PM, Ian Campbell wrote: > On Wed, 2015-07-29 at 13:26 +0300, P=C3=AErvu Mihai wrote: > > Alright, here it is, hope we can sort this out: > > Thanks, I took what you had, but using the lwip-1.3.0 + patches from > xen.git/stubdom (just because they were to hand) and reprod what you've > been seeing. > > Then (on a hunch) I did "ethtool -K vif13.0 tx off" and it started workin= g. > > So I think there must be a bug either in mini-os's netfront checksum > offload, or in the negotiation it does with netback. > > Hopefully that is enough for someone to be going on with. > > Ian. > --001a1140ea86b859ed051c058bda Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I've been on this for like 10 days and you have found = a solution in few hours. Thanks you, I guess this shows the difference in e= xperience over this project :) Hope this gets sorted out.

Mihai

On Wed, Jul 29, 2015 at 6:04 PM, Ian Campbell <ian.campbell@citrix= .com> wrote:
On Wed, 2015-07-29 at 13:26 +0300, P=C3=AErvu Mihai wrote:
> Alright, here it is, hope we can sort this out:

Thanks, I took what you had, but using the lwip-1.3.0 + patches from=
xen.git/stubdom (just because they were to hand) and reprod what you've=
been seeing.

Then (on a hunch) I did "ethtool -K vif13.0 tx off" and it starte= d working.

So I think there must be a bug either in mini-os's netfront checksum offload, or in the negotiation it does with netback.

Hopefully that is enough for someone to be going on with.

Ian.

--001a1140ea86b859ed051c058bda-- --===============4474196108860116119== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel --===============4474196108860116119==-- From minios-devel-bounces@lists.xenproject.org Wed Jul 29 15:50:34 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 29 Jul 2015 15:50:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZKTco-0001XC-0K; Wed, 29 Jul 2015 15:50:34 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZKTcm-0001Wx-QU for Minios-devel@lists.xenproject.org; Wed, 29 Jul 2015 15:50:32 +0000 Received: from [85.158.137.68] by server-14.bemta-3.messagelabs.com id DF/9B-05979-746F8B55; Wed, 29 Jul 2015 15:50:31 +0000 X-Env-Sender: mihaicristianpirvu@gmail.com X-Msg-Ref: server-4.tower-31.messagelabs.com!1438185028!29179701!1 X-Originating-IP: [209.85.223.176] X-SpamReason: No, hits=0.4 required=7.0 tests=HTML_30_40,HTML_MESSAGE, RCVD_BY_IP X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 797 invoked from network); 29 Jul 2015 15:50:29 -0000 Received: from mail-io0-f176.google.com (HELO mail-io0-f176.google.com) (209.85.223.176) by server-4.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 29 Jul 2015 15:50:29 -0000 Received: by ioii16 with SMTP id i16so25727638ioi.0 for ; Wed, 29 Jul 2015 08:50:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Hhh9FcMHFJR9mLYei3htHd91yx7I3bRkbi/9vPBYWbA=; b=QXufhp3vOMYKLTSoVWOIekxTNfkKZKKB5NH5OF/ejNtXk/wYAH0KkG695vu2YDRXMJ AmhYEx9gESOo8AfFBHsmPYQe67NlJqkLDL7IQri9EeK/Tqylv5QfE3aQ+hzVCMjOgwPD GeIvlk20dxLxc4hUnpN5JZLNjhXEQe3ifcL9T1DBZ5oQjAq6GD2SnWnlrAmsVz1feNbA dXjYHRaz492cW/l6Sm8eLKym+oHGe9xSFrlRa2Ki9tEqpenKaKn3b/OYly/lQ09UJuhp 2nj2frLOJSO370QdUSoIJeFMb2zW6vJdQ0HpRtP3lO3ShP0wWyQWnH6ayQzREtLoVdQD 4XuQ== MIME-Version: 1.0 X-Received: by 10.107.37.134 with SMTP id l128mr2796954iol.92.1438185028080; Wed, 29 Jul 2015 08:50:28 -0700 (PDT) Received: by 10.107.143.215 with HTTP; Wed, 29 Jul 2015 08:50:28 -0700 (PDT) In-Reply-To: <1438182258.11600.208.camel@citrix.com> References: <55B7D1D3.7030200@rz-online.de> <1438159613.11600.171.camel@citrix.com> <1438182258.11600.208.camel@citrix.com> Date: Wed, 29 Jul 2015 18:50:28 +0300 Message-ID: From: =?UTF-8?B?UMOucnZ1IE1paGFp?= To: Ian Campbell Cc: Minios-devel@lists.xenproject.org, xen-users , "Manfred Haertel, DB3HM" Subject: Re: [Minios-devel] [Xen-users] Problems connecting to the daytime application provided with Mini-OS X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4474196108860116119==" Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org --===============4474196108860116119== Content-Type: multipart/alternative; boundary=001a1140ea86b859ed051c058bda --001a1140ea86b859ed051c058bda Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I've been on this for like 10 days and you have found a solution in few hours. Thanks you, I guess this shows the difference in experience over this project :) Hope this gets sorted out. Mihai On Wed, Jul 29, 2015 at 6:04 PM, Ian Campbell wrote: > On Wed, 2015-07-29 at 13:26 +0300, P=C3=AErvu Mihai wrote: > > Alright, here it is, hope we can sort this out: > > Thanks, I took what you had, but using the lwip-1.3.0 + patches from > xen.git/stubdom (just because they were to hand) and reprod what you've > been seeing. > > Then (on a hunch) I did "ethtool -K vif13.0 tx off" and it started workin= g. > > So I think there must be a bug either in mini-os's netfront checksum > offload, or in the negotiation it does with netback. > > Hopefully that is enough for someone to be going on with. > > Ian. > --001a1140ea86b859ed051c058bda Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I've been on this for like 10 days and you have found = a solution in few hours. Thanks you, I guess this shows the difference in e= xperience over this project :) Hope this gets sorted out.

Mihai

On Wed, Jul 29, 2015 at 6:04 PM, Ian Campbell <ian.campbell@citrix= .com> wrote:
On Wed, 2015-07-29 at 13:26 +0300, P=C3=AErvu Mihai wrote:
> Alright, here it is, hope we can sort this out:

Thanks, I took what you had, but using the lwip-1.3.0 + patches from=
xen.git/stubdom (just because they were to hand) and reprod what you've=
been seeing.

Then (on a hunch) I did "ethtool -K vif13.0 tx off" and it starte= d working.

So I think there must be a bug either in mini-os's netfront checksum offload, or in the negotiation it does with netback.

Hopefully that is enough for someone to be going on with.

Ian.

--001a1140ea86b859ed051c058bda-- --===============4474196108860116119== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel --===============4474196108860116119==-- From minios-devel-bounces@lists.xenproject.org Wed Jul 29 16:46:42 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 29 Jul 2015 16:46:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZKUV8-0005fx-4I; Wed, 29 Jul 2015 16:46:42 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZKUV7-0005fj-24 for Minios-devel@lists.xenproject.org; Wed, 29 Jul 2015 16:46:41 +0000 Received: from [193.109.254.147] by server-9.bemta-14.messagelabs.com id BC/CD-26043-07309B55; Wed, 29 Jul 2015 16:46:40 +0000 X-Env-Sender: prvs=6453b2377=Ian.Campbell@citrix.com X-Msg-Ref: server-5.tower-27.messagelabs.com!1438188397!24882464!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 12222 invoked from network); 29 Jul 2015 16:46:39 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-5.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 29 Jul 2015 16:46:39 -0000 X-IronPort-AV: E=Sophos;i="5.15,572,1432598400"; d="scan'208";a="288956919" Message-ID: <1438188391.11600.219.camel@citrix.com> From: Ian Campbell To: =?ISO-8859-1?Q?P=EErvu?= Mihai Date: Wed, 29 Jul 2015 17:46:31 +0100 In-Reply-To: References: <55B7D1D3.7030200@rz-online.de> <1438159613.11600.171.camel@citrix.com> <1438182258.11600.208.camel@citrix.com> X-Mailer: Evolution 3.16.3-1 MIME-Version: 1.0 X-DLP: MIA1 Cc: Minios-devel@lists.xenproject.org, xen-users , "Manfred Haertel, DB3HM" Subject: Re: [Minios-devel] [Xen-users] Problems connecting to the daytime application provided with Mini-OS X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org T24gV2VkLCAyMDE1LTA3LTI5IGF0IDE4OjUwICswMzAwLCBQw65ydnUgTWloYWkgd3JvdGU6Cj4g SSd2ZSBiZWVuIG9uIHRoaXMgZm9yIGxpa2UgMTAgZGF5cyBhbmQgeW91IGhhdmUgZm91bmQgYSBz b2x1dGlvbiBpbiBmZXcgCj4gaG91cnMuIFRoYW5rcyB5b3UsIEkgZ3Vlc3MgdGhpcyBzaG93cyB0 aGUgZGlmZmVyZW5jZSBpbiBleHBlcmllbmNlIG92ZXIgCj4gdGhpcyBwcm9qZWN0IDopCgpJIGp1 c3Qga25vdyB3aGVyZSB0aGUgYm9kaWVzIGFyZSBidXJpZWQgOy0pCgo+ICBIb3BlIHRoaXMgZ2V0 cyBzb3J0ZWQgb3V0LgoKRkFPRCBJIHBlcnNvbmFsbHkgZG9uJ3QgaGF2ZSB0aW1lIHRvIGxvb2sg aW50byB0aGlzIGFueSBmdXJ0aGVyLiBQYXRjaGVzCmFyZSBvZiBjb3Vyc2UgdmVyeSBtdWNoIHdl bGNvbWVkLCBmcm9tIHlvdSBvciBvdGhlcnMuCgpJYW4uCgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KTWluaW9zLWRldmVsIG1haWxpbmcgbGlzdApNaW5p b3MtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cDovL2xpc3RzLnhlbnByb2plY3Qub3Jn L2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9taW5pb3MtZGV2ZWw= From minios-devel-bounces@lists.xenproject.org Wed Jul 29 16:46:42 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 29 Jul 2015 16:46:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZKUV8-0005fx-4I; Wed, 29 Jul 2015 16:46:42 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZKUV7-0005fj-24 for Minios-devel@lists.xenproject.org; Wed, 29 Jul 2015 16:46:41 +0000 Received: from [193.109.254.147] by server-9.bemta-14.messagelabs.com id BC/CD-26043-07309B55; Wed, 29 Jul 2015 16:46:40 +0000 X-Env-Sender: prvs=6453b2377=Ian.Campbell@citrix.com X-Msg-Ref: server-5.tower-27.messagelabs.com!1438188397!24882464!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 12222 invoked from network); 29 Jul 2015 16:46:39 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-5.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 29 Jul 2015 16:46:39 -0000 X-IronPort-AV: E=Sophos;i="5.15,572,1432598400"; d="scan'208";a="288956919" Message-ID: <1438188391.11600.219.camel@citrix.com> From: Ian Campbell To: =?ISO-8859-1?Q?P=EErvu?= Mihai Date: Wed, 29 Jul 2015 17:46:31 +0100 In-Reply-To: References: <55B7D1D3.7030200@rz-online.de> <1438159613.11600.171.camel@citrix.com> <1438182258.11600.208.camel@citrix.com> X-Mailer: Evolution 3.16.3-1 MIME-Version: 1.0 X-DLP: MIA1 Cc: Minios-devel@lists.xenproject.org, xen-users , "Manfred Haertel, DB3HM" Subject: Re: [Minios-devel] [Xen-users] Problems connecting to the daytime application provided with Mini-OS X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org T24gV2VkLCAyMDE1LTA3LTI5IGF0IDE4OjUwICswMzAwLCBQw65ydnUgTWloYWkgd3JvdGU6Cj4g SSd2ZSBiZWVuIG9uIHRoaXMgZm9yIGxpa2UgMTAgZGF5cyBhbmQgeW91IGhhdmUgZm91bmQgYSBz b2x1dGlvbiBpbiBmZXcgCj4gaG91cnMuIFRoYW5rcyB5b3UsIEkgZ3Vlc3MgdGhpcyBzaG93cyB0 aGUgZGlmZmVyZW5jZSBpbiBleHBlcmllbmNlIG92ZXIgCj4gdGhpcyBwcm9qZWN0IDopCgpJIGp1 c3Qga25vdyB3aGVyZSB0aGUgYm9kaWVzIGFyZSBidXJpZWQgOy0pCgo+ICBIb3BlIHRoaXMgZ2V0 cyBzb3J0ZWQgb3V0LgoKRkFPRCBJIHBlcnNvbmFsbHkgZG9uJ3QgaGF2ZSB0aW1lIHRvIGxvb2sg aW50byB0aGlzIGFueSBmdXJ0aGVyLiBQYXRjaGVzCmFyZSBvZiBjb3Vyc2UgdmVyeSBtdWNoIHdl bGNvbWVkLCBmcm9tIHlvdSBvciBvdGhlcnMuCgpJYW4uCgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KTWluaW9zLWRldmVsIG1haWxpbmcgbGlzdApNaW5p b3MtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cDovL2xpc3RzLnhlbnByb2plY3Qub3Jn L2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9taW5pb3MtZGV2ZWw=