From minios-devel-bounces@lists.xenproject.org Mon Oct 05 20:04:51 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 05 Oct 2015 20:04:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjC09-0006KN-Tn; Mon, 05 Oct 2015 20:04:49 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjC08-0006Jl-Tm for minios-devel@lists.xenproject.org; Mon, 05 Oct 2015 20:04:49 +0000 Received: from [85.158.137.68] by server-2.bemta-3.messagelabs.com id 73/C3-21201-0E7D2165; Mon, 05 Oct 2015 20:04:48 +0000 X-Env-Sender: carlpaten@gmail.com X-Msg-Ref: server-14.tower-31.messagelabs.com!1444075486!48056820!1 X-Originating-IP: [209.85.213.44] X-SpamReason: No, hits=0.3 required=7.0 tests=RCVD_BY_IP X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 2940 invoked from network); 5 Oct 2015 20:04:47 -0000 Received: from mail-vk0-f44.google.com (HELO mail-vk0-f44.google.com) (209.85.213.44) by server-14.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 5 Oct 2015 20:04:47 -0000 Received: by vkao3 with SMTP id o3so103842973vka.2 for ; Mon, 05 Oct 2015 13:04:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:from:date:message-id:subject:to:content-type; bh=+vK0JpSs2yP0B9HNbUcg4118g+x3DsPFI4hLVNNc0PU=; b=BiH7fYF0B+SQADTZiO8IdJMvDdFfJM+mUs7y0zu0X5GG82JJn2oO2htMnzcfmM048Y oKqXlnPj3f5Y2BIrsbyZ1aAcuU1qvkW56HkoIjxQCwtyerqfw+Yd/La2zSnXAQ2uW0ma yw3VoqROdMT/7MnGYgAN1IuM4BKdS7yrQj59RUWqrznowAg5mlJUQB30qniOe2ycNvL6 Xc5F7uxj3yixHd6GBDBaNn4AzHZBgqHRT+RVXaxNkSWTSN/yls1Tl3Uc06+5H/n5DpME q4kTn1IqObp6n9OhD5IStO6Pw60K8TIZg6ErCpmoOjq4ptK98ArF9EL14C42D4PpahZ7 f+oQ== X-Received: by 10.31.149.149 with SMTP id x143mr21138375vkd.12.1444075486621; Mon, 05 Oct 2015 13:04:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.31.220.198 with HTTP; Mon, 5 Oct 2015 13:04:27 -0700 (PDT) From: Carl Patenaude Poulin Date: Mon, 5 Oct 2015 16:04:27 -0400 X-Google-Sender-Auth: -QferpvG3MTMzivDH3ejgRSmg3A Message-ID: To: minios-devel@lists.xenproject.org Subject: [Minios-devel] Mini-OS debugging and development workflow X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Hi all, Is it possible to run Mini-OS with a debugger attached? More generally, what development practices do you recommend for hacking on Mini-OS? Best _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 05 20:04:51 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 05 Oct 2015 20:04:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjC09-0006KN-Tn; Mon, 05 Oct 2015 20:04:49 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjC08-0006Jl-Tm for minios-devel@lists.xenproject.org; Mon, 05 Oct 2015 20:04:49 +0000 Received: from [85.158.137.68] by server-2.bemta-3.messagelabs.com id 73/C3-21201-0E7D2165; Mon, 05 Oct 2015 20:04:48 +0000 X-Env-Sender: carlpaten@gmail.com X-Msg-Ref: server-14.tower-31.messagelabs.com!1444075486!48056820!1 X-Originating-IP: [209.85.213.44] X-SpamReason: No, hits=0.3 required=7.0 tests=RCVD_BY_IP X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 2940 invoked from network); 5 Oct 2015 20:04:47 -0000 Received: from mail-vk0-f44.google.com (HELO mail-vk0-f44.google.com) (209.85.213.44) by server-14.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 5 Oct 2015 20:04:47 -0000 Received: by vkao3 with SMTP id o3so103842973vka.2 for ; Mon, 05 Oct 2015 13:04:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:from:date:message-id:subject:to:content-type; bh=+vK0JpSs2yP0B9HNbUcg4118g+x3DsPFI4hLVNNc0PU=; b=BiH7fYF0B+SQADTZiO8IdJMvDdFfJM+mUs7y0zu0X5GG82JJn2oO2htMnzcfmM048Y oKqXlnPj3f5Y2BIrsbyZ1aAcuU1qvkW56HkoIjxQCwtyerqfw+Yd/La2zSnXAQ2uW0ma yw3VoqROdMT/7MnGYgAN1IuM4BKdS7yrQj59RUWqrznowAg5mlJUQB30qniOe2ycNvL6 Xc5F7uxj3yixHd6GBDBaNn4AzHZBgqHRT+RVXaxNkSWTSN/yls1Tl3Uc06+5H/n5DpME q4kTn1IqObp6n9OhD5IStO6Pw60K8TIZg6ErCpmoOjq4ptK98ArF9EL14C42D4PpahZ7 f+oQ== X-Received: by 10.31.149.149 with SMTP id x143mr21138375vkd.12.1444075486621; Mon, 05 Oct 2015 13:04:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.31.220.198 with HTTP; Mon, 5 Oct 2015 13:04:27 -0700 (PDT) From: Carl Patenaude Poulin Date: Mon, 5 Oct 2015 16:04:27 -0400 X-Google-Sender-Auth: -QferpvG3MTMzivDH3ejgRSmg3A Message-ID: To: minios-devel@lists.xenproject.org Subject: [Minios-devel] Mini-OS debugging and development workflow X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Hi all, Is it possible to run Mini-OS with a debugger attached? More generally, what development practices do you recommend for hacking on Mini-OS? Best _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Tue Oct 06 08:44:10 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 06 Oct 2015 08:44:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjNqz-0003Ep-KG; Tue, 06 Oct 2015 08:44:09 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjNqz-0003Ee-88 for minios-devel@lists.xenproject.org; Tue, 06 Oct 2015 08:44:09 +0000 Received: from [85.158.137.68] by server-12.bemta-3.messagelabs.com id EC/51-05269-8D983165; Tue, 06 Oct 2015 08:44:08 +0000 X-Env-Sender: prvs=7140158d9=Ian.Campbell@citrix.com X-Msg-Ref: server-4.tower-31.messagelabs.com!1444121043!49363059!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 642 invoked from network); 6 Oct 2015 08:44:04 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-4.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 6 Oct 2015 08:44:04 -0000 X-IronPort-AV: E=Sophos;i="5.17,643,1437436800"; d="scan'208";a="304523246" Message-ID: <1444121042.5302.46.camel@citrix.com> From: Ian Campbell To: Carl Patenaude Poulin , Date: Tue, 6 Oct 2015 09:44:02 +0100 In-Reply-To: References: X-Mailer: Evolution 3.16.5-1 MIME-Version: 1.0 X-DLP: MIA1 Subject: Re: [Minios-devel] Mini-OS debugging and development workflow X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Mon, 2015-10-05 at 16:04 -0400, Carl Patenaude Poulin wrote: > Hi all, > > Is it possible to run Mini-OS with a debugger attached? I've never done it, but I believe it should be possible to attach gdbsx to a mini-os domain just like any other PV domain. > More > generally, what development practices do you recommend for hacking > on Mini-OS? I don't do an awful lot of mini-os hacking, so I don't have much advise on that. Ian. _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Tue Oct 06 08:44:10 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 06 Oct 2015 08:44:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjNqz-0003Ep-KG; Tue, 06 Oct 2015 08:44:09 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjNqz-0003Ee-88 for minios-devel@lists.xenproject.org; Tue, 06 Oct 2015 08:44:09 +0000 Received: from [85.158.137.68] by server-12.bemta-3.messagelabs.com id EC/51-05269-8D983165; Tue, 06 Oct 2015 08:44:08 +0000 X-Env-Sender: prvs=7140158d9=Ian.Campbell@citrix.com X-Msg-Ref: server-4.tower-31.messagelabs.com!1444121043!49363059!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 642 invoked from network); 6 Oct 2015 08:44:04 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-4.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 6 Oct 2015 08:44:04 -0000 X-IronPort-AV: E=Sophos;i="5.17,643,1437436800"; d="scan'208";a="304523246" Message-ID: <1444121042.5302.46.camel@citrix.com> From: Ian Campbell To: Carl Patenaude Poulin , Date: Tue, 6 Oct 2015 09:44:02 +0100 In-Reply-To: References: X-Mailer: Evolution 3.16.5-1 MIME-Version: 1.0 X-DLP: MIA1 Subject: Re: [Minios-devel] Mini-OS debugging and development workflow X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Mon, 2015-10-05 at 16:04 -0400, Carl Patenaude Poulin wrote: > Hi all, > > Is it possible to run Mini-OS with a debugger attached? I've never done it, but I believe it should be possible to attach gdbsx to a mini-os domain just like any other PV domain. > More > generally, what development practices do you recommend for hacking > on Mini-OS? I don't do an awful lot of mini-os hacking, so I don't have much advise on that. Ian. _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Oct 07 14:03:59 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 07 Oct 2015 14:03:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpK2-00026k-Hw; Wed, 07 Oct 2015 14:03:58 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpK1-00026S-Hz for minios-devel@lists.xenproject.org; Wed, 07 Oct 2015 14:03:57 +0000 Received: from [85.158.137.68] by server-16.bemta-3.messagelabs.com id FD/51-03763-C4625165; Wed, 07 Oct 2015 14:03:56 +0000 X-Env-Sender: prvs=715f1a83e=Ian.Campbell@citrix.com X-Msg-Ref: server-4.tower-31.messagelabs.com!1444226583!49902514!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 26672 invoked from network); 7 Oct 2015 14:03:04 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-4.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 7 Oct 2015 14:03:04 -0000 X-IronPort-AV: E=Sophos;i="5.17,649,1437436800"; d="scan'208";a="308655497" Message-ID: <1444226543.1410.53.camel@citrix.com> From: Ian Campbell To: xen-devel Date: Wed, 7 Oct 2015 15:02:23 +0100 X-Mailer: Evolution 3.16.5-1 MIME-Version: 1.0 X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, Ian Jackson , Roger Pau Monne , Wei Liu , Stefano Stabellini Subject: [Minios-devel] [PATCH v3 0/] Begin to disentangle libxenctrl and provide some stable libraries X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org SW4gPDE0MzE5NjMwMDguNDk0NC44MC5jYW1lbEBjaXRyaXguY29tPiBJIHByb3Bvc2VkIHN0YWJp bGlzaW5nIHNvbWUKcGFydHMgb2YgdGhlIGxpYnhlbmN0cmwgQVBJL0FCSSBieSBkaXNhZ2dyZWdh dGluZyBpbnRvIHNlcGFyYXRlCmxpYnJhcmllcy4KClRoaXMgaXMgdjMgb2YgdGhhdCBzZXQgb2Yg c2VyaWVzIGFnYWluc3Q6CiAgICB4ZW4KICAgIHFlbXUteGVuIChuZXcgdGhpcyB0aW1lKQogICAg cWVtdS14ZW4tdHJhZGl0aW9uYWwKICAgIG1pbmktb3MKCk5COiBtaW5pb3MtZGV2ZWwgd2lsbCBv bmx5IGdldCB0aGUgbWluaS1vcyBzaWRlIGFuZCBTdGVmYW5vIHRoZSBxZW11LXhlbgpzaWRlLgoK VGhlIGNvZGUgaW4gZm9yIGFsbCByZXBvcyBjYW4gYmUgZm91bmQgaW46CgpnaXQ6Ly94ZW5iaXRz Lnhlbi5vcmcvcGVvcGxlL2lhbmMvbGlieGVuY3RybC1zcGxpdC94ZW4uZ2l0ICAgICAgICAgICAg ICAgICAgdjMKZ2l0Oi8veGVuYml0cy54ZW4ub3JnL3Blb3BsZS9pYW5jL2xpYnhlbmN0cmwtc3Bs aXQvcWVtdS14ZW4uZ2l0ICAgICAgICAgICAgIHYzCmdpdDovL3hlbmJpdHMueGVuLm9yZy9wZW9w bGUvaWFuYy9saWJ4ZW5jdHJsLXNwbGl0L3FlbXUteGVuLXRyYWRpdGlvbmFsLmdpdCB2MwpnaXQ6 Ly94ZW5iaXRzLnhlbi5vcmcvcGVvcGxlL2lhbmMvbGlieGVuY3RybC1zcGxpdC9taW5pLW9zLmdp dCAgICAgICAgICAgICAgdjMKCihuYiB0aGUgcmVwb3MgaGF2ZSBjaGFuZ2VkIHNpbmNlIGxhc3Qg dGltZSwgSSd2ZSBjYXJyaWVkIHRoZSB2MiB0YWdzIG92ZXIKYXMgd2VsbCkKClRoZSB0aXAgb2Yg dGhlIHhlbi5naXQgYnJhbmNoIGNvbnRhaW5zIGFuIGV4dHJhIHBhdGNoIGFkZGluZyBhIC5jb25m aWcKaW50byB0aGUgdHJlZSB3aGljaCBzaG91bGQgZ2V0IHRoZSBjb3JyZWN0IHRoaW5ncyBmb3Ig dGhlIEhFQUQgb2YgdGhlCmJyYW5jaCwgYnV0IG5vdCBmdXJ0aGVyIGJhY2suCgpUaGUgbmV3IGxp YnJhcmllcyBoZXJlIGFyZToKCiAqIGxpYnhlbnRvb2xsb2c6IENvbW1vbiBsb2dnaW5nIGluZnJh c3RydWN0dXJlCiAqIGxpYnhlbmV2dGNobjogVXNlcnNwYWNlIGFjY2VzcyB0byBldnRjaG5zICh2 aWEgL2Rldi94ZW4vZXZ0Y2huIGV0YykKICogbGlieGVuZ250dGFiOiBVc2Vyc3BhY2UgYWNjZXNz IHRvIGdyYW50IHRhYmxlcyAodmlhIC9kZXYveGVuL2dudD8/PyBldGMpCiAqIGxpYnhlbmNhbGw6 IE1ha2luZyBoeXBlcmNhbGxzIChpLmUuIHRoZcKgSU9DVExfUFJJVkNNRF9IWVBFUkNBTEwgdHlw ZQogICBmdW5jdGlvbmFsaXR5KQogKiBsaWJ4ZW5mb3JlaWdubWVtb3J5OiBQcml2aWxlZ2VkIG1h cHBpbmdzIG9mIGZvcmVpZ24gbWVtb3J5CiAgIChJT0NUTF9QUklWQ01EX01NQVAgZXQgYWwpCgpU aGUgZmlyc3QgdGhyZWUgd2VyZSBhY3R1YWxseSBwcmV0dHkgZGlzdGluY3Qgd2l0aGluIGxpYnhl bmN0cmwgYWxyZWFkeSBhbmQKaGF2ZSBub3QgY2hhbmdlZCBpbiBxdWl0ZSBzb21lIHRpbWUuCgpB bHRob3VnaCB0aGUgb3RoZXIgdHdvIGFyZSBzb21ld2hhdCBuZXcgdGhleSBhcmUgYmFzZWQgb24g dG9wIG9mIGxvbmcKc3RhbmRpbmcgc3RhYmxlIGlvY3Rscywgd2hpY2ggZ2l2ZXMgbWUgc29tZSBj b25maWRlbmNlLgoKTm9uZXRoZWxlc3MgSSB3b3VsZCBhcHByZWNpYXRlIGV4dHJhIHJldmlldyBv ZiBhdCBsZWFzdCB0aGUgaW50ZXJmYWNlCmhlYWRlcnMgb2YgYWxsIG9mIHRoZXNlIHdpdGggYSBw YXJ0aWN1bGFyIGV5ZSB0byB0aGUgc3VpdGFiaWxpdHkgb2YgdGhlc2UKaW50ZXJmYWNlcyBiZWlu ZyBtYWludGFpbmVkIGluIGFuIEFCSSAoX0JfLCBub3QgX1BfKSBzdGFibGUgd2F5IGdvaW5nCmZv cndhcmQuCgpTdGlsbCB0byBjb21lIHdvdWxkIGJlIGxpYnJhcmllcyBmb3Igc3BlY2lmaWMgb3V0 IG9mIHRyZWUgcHVycG9zZXMKKGRldmljZSBtb2RlbCwga2V4ZWMpLCB3aGljaCB3b3VsZCBiZSBh ZGRpbmcgbmV3IGxpYnJhcnkgYXQgdGhlIHNhbWUKbGV2ZWwgYXMgbGlieGMgSSB0aGluaywgcmF0 aGVyIHRoYW4gdW5kZXJuZWF0aCwgaS5lLiBhbHNvIHVzaW5nIHRoZQpsaWJyYXJpZXMgc3BsaXQg b3V0IGhlcmUsIGJ1dCBob3BlZnVsbHkgbm90IGxpYnhlbmN0cmwgaXRzZWxmLgoKVGhlIG5ldyBs aWJyYXJpZXMgdXNlIGxpbmtlciB2ZXJzaW9uLXNjcmlwdHMgdG8gaG9wZWZ1bGx5IG1ha2UgZnV0 dXJlCkFCSSBjaGFuZ2VzIGJlIHBvc3NpYmxlIGluIGEgY29tcGF0aWJsZSB3YXkuCgpTaW5jZSBs YXN0IHRpbWUgSSBoYXZlOgoKICogTW92ZWQgZXZlcnl0aGluZyBmcm9tIHRvb2xzL2xpYnhlbmZv byB0byB0b29scy9saWJzL2ZvbwogKiBBZGRlZCBwYXRjaGVzIHRvIHFlbXUteGVuIHRvIHVzZSB0 aGUgbmV3IGxpYnJhcmllcyBpbnN0ZWFkIG9mIHRoZSBjb21wYXQKICAgbGF5ZXIuIFRoZXNlIGNh biBjb21lIGFueSB0aW1lIGFmdGVyIHRoaXMgdHJhbnNpdGlvbiBhbmQgYXJlIG5vdAogICBlbnRh bmdsZWQgKGR1ZSB0byB0aGUgY29tcGF0IGxheWVyIGJlaW5nIHByZXNlbnQgaW4gdGhlIG1lYW50 aW1lKQogKiBSZXZpZXdlZCBlYWNoIG9mIHRoZSBuZXcgbGlicmFyaWVzIGZvcgogICAgKiBFcnJv ciBoYW5kbGluZywgU3BlY2lmaWNhbGx5IG5vIHJldHVybiAtZXJybm8gdHlwZSBzdHVmZiwgYnV0 IGluc3RlYWQKICAgICAgcmV0dXJuIC0xIG9yIE5VTEwgYW5kIHNldHRpbmcgZXJybm8gaWYgbmVj ZXNzYXJ5CiAgICAqIEFwcHJvcHJpYXRlIHR5cGVzIChzb21lIGRpc2N1c3Npb24gYXJvdW5kIHRo YXQgaGFzbid0IGJlZW4gZm9sZGVkIGluCiAgICAgIGhlcmUgeWV0KQogICAgKiBObyBpbmxpbmVz IGluIHRoZSBwdWJpYyBoZWFkZXJzICh0cm91Ymxlc29tZSBmb3IgQUJJIGNvbXBhdGliaWxpdHkp CiAgICAqIERvY3VtZW50YXRpb24sIGluIHRoYXQgdGhleSBhbGwgaGF2ZSBzb21lLCBub3QgdGhh dCBpdCBpcyBuZWNlc3NhcmlseQogICAgICBjb21wcmVoZW5zaXZlIG9yIGNvbXBsZXRlIChhbHRo b3VnaCBpdCBkb2VzIGxvb2sgYmV0dGVyIHRoYW4gdGhlCiAgICAgIGF2ZXJhZ2UpLgogKiBEcm9w cGVkwqAKICAgwqBhbmQgeW91CiAgIGNhbiBmaW5kIGl0cyBoaXN0b3J5CiAqIEZpeGVkIHZhcmlv dXMgaXNzdWUuCgpUaGUgd2hvbGUgdGhpbmcgaGFzIGJlZW4gYnVpbGQgYW5kIHJ1bnRpbWUgdGVz dGVkIG9uIExpbnV4IGFuZCBzdHViZG9tcywKYW5kIGJ1aWx0IChidXQgbm90IHJ1bikgb24gRnJl ZUJTRC4gTmVpdGhlciBOZXRCU0Qgbm9yIFNvbGFyaXMgaGF2ZSBiZWVuCnRlc3RlZCBhdCBhbGwu IEl0J3MgY2VydGFpbmx5IG5vdCBpbXBvc3NpYmxlIHRoYXQgSSd2ZSBub3QgZ290IHRoZQojaW5j bHVkZXMgaW4gdGhlIG5ldyBmaWxlcyBxdWl0ZSByaWdodC4KCklhbi4KCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCk1pbmlvcy1kZXZlbCBtYWlsaW5nIGxp c3QKTWluaW9zLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHA6Ly9saXN0cy54ZW5wcm9q ZWN0Lm9yZy9jZ2ktYmluL21haWxtYW4vbGlzdGluZm8vbWluaW9zLWRldmVs From minios-devel-bounces@lists.xenproject.org Wed Oct 07 14:03:59 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 07 Oct 2015 14:03:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpK2-00026k-Hw; Wed, 07 Oct 2015 14:03:58 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpK1-00026S-Hz for minios-devel@lists.xenproject.org; Wed, 07 Oct 2015 14:03:57 +0000 Received: from [85.158.137.68] by server-16.bemta-3.messagelabs.com id FD/51-03763-C4625165; Wed, 07 Oct 2015 14:03:56 +0000 X-Env-Sender: prvs=715f1a83e=Ian.Campbell@citrix.com X-Msg-Ref: server-4.tower-31.messagelabs.com!1444226583!49902514!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 26672 invoked from network); 7 Oct 2015 14:03:04 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-4.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 7 Oct 2015 14:03:04 -0000 X-IronPort-AV: E=Sophos;i="5.17,649,1437436800"; d="scan'208";a="308655497" Message-ID: <1444226543.1410.53.camel@citrix.com> From: Ian Campbell To: xen-devel Date: Wed, 7 Oct 2015 15:02:23 +0100 X-Mailer: Evolution 3.16.5-1 MIME-Version: 1.0 X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, Ian Jackson , Roger Pau Monne , Wei Liu , Stefano Stabellini Subject: [Minios-devel] [PATCH v3 0/] Begin to disentangle libxenctrl and provide some stable libraries X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org SW4gPDE0MzE5NjMwMDguNDk0NC44MC5jYW1lbEBjaXRyaXguY29tPiBJIHByb3Bvc2VkIHN0YWJp bGlzaW5nIHNvbWUKcGFydHMgb2YgdGhlIGxpYnhlbmN0cmwgQVBJL0FCSSBieSBkaXNhZ2dyZWdh dGluZyBpbnRvIHNlcGFyYXRlCmxpYnJhcmllcy4KClRoaXMgaXMgdjMgb2YgdGhhdCBzZXQgb2Yg c2VyaWVzIGFnYWluc3Q6CiAgICB4ZW4KICAgIHFlbXUteGVuIChuZXcgdGhpcyB0aW1lKQogICAg cWVtdS14ZW4tdHJhZGl0aW9uYWwKICAgIG1pbmktb3MKCk5COiBtaW5pb3MtZGV2ZWwgd2lsbCBv bmx5IGdldCB0aGUgbWluaS1vcyBzaWRlIGFuZCBTdGVmYW5vIHRoZSBxZW11LXhlbgpzaWRlLgoK VGhlIGNvZGUgaW4gZm9yIGFsbCByZXBvcyBjYW4gYmUgZm91bmQgaW46CgpnaXQ6Ly94ZW5iaXRz Lnhlbi5vcmcvcGVvcGxlL2lhbmMvbGlieGVuY3RybC1zcGxpdC94ZW4uZ2l0ICAgICAgICAgICAg ICAgICAgdjMKZ2l0Oi8veGVuYml0cy54ZW4ub3JnL3Blb3BsZS9pYW5jL2xpYnhlbmN0cmwtc3Bs aXQvcWVtdS14ZW4uZ2l0ICAgICAgICAgICAgIHYzCmdpdDovL3hlbmJpdHMueGVuLm9yZy9wZW9w bGUvaWFuYy9saWJ4ZW5jdHJsLXNwbGl0L3FlbXUteGVuLXRyYWRpdGlvbmFsLmdpdCB2MwpnaXQ6 Ly94ZW5iaXRzLnhlbi5vcmcvcGVvcGxlL2lhbmMvbGlieGVuY3RybC1zcGxpdC9taW5pLW9zLmdp dCAgICAgICAgICAgICAgdjMKCihuYiB0aGUgcmVwb3MgaGF2ZSBjaGFuZ2VkIHNpbmNlIGxhc3Qg dGltZSwgSSd2ZSBjYXJyaWVkIHRoZSB2MiB0YWdzIG92ZXIKYXMgd2VsbCkKClRoZSB0aXAgb2Yg dGhlIHhlbi5naXQgYnJhbmNoIGNvbnRhaW5zIGFuIGV4dHJhIHBhdGNoIGFkZGluZyBhIC5jb25m aWcKaW50byB0aGUgdHJlZSB3aGljaCBzaG91bGQgZ2V0IHRoZSBjb3JyZWN0IHRoaW5ncyBmb3Ig dGhlIEhFQUQgb2YgdGhlCmJyYW5jaCwgYnV0IG5vdCBmdXJ0aGVyIGJhY2suCgpUaGUgbmV3IGxp YnJhcmllcyBoZXJlIGFyZToKCiAqIGxpYnhlbnRvb2xsb2c6IENvbW1vbiBsb2dnaW5nIGluZnJh c3RydWN0dXJlCiAqIGxpYnhlbmV2dGNobjogVXNlcnNwYWNlIGFjY2VzcyB0byBldnRjaG5zICh2 aWEgL2Rldi94ZW4vZXZ0Y2huIGV0YykKICogbGlieGVuZ250dGFiOiBVc2Vyc3BhY2UgYWNjZXNz IHRvIGdyYW50IHRhYmxlcyAodmlhIC9kZXYveGVuL2dudD8/PyBldGMpCiAqIGxpYnhlbmNhbGw6 IE1ha2luZyBoeXBlcmNhbGxzIChpLmUuIHRoZcKgSU9DVExfUFJJVkNNRF9IWVBFUkNBTEwgdHlw ZQogICBmdW5jdGlvbmFsaXR5KQogKiBsaWJ4ZW5mb3JlaWdubWVtb3J5OiBQcml2aWxlZ2VkIG1h cHBpbmdzIG9mIGZvcmVpZ24gbWVtb3J5CiAgIChJT0NUTF9QUklWQ01EX01NQVAgZXQgYWwpCgpU aGUgZmlyc3QgdGhyZWUgd2VyZSBhY3R1YWxseSBwcmV0dHkgZGlzdGluY3Qgd2l0aGluIGxpYnhl bmN0cmwgYWxyZWFkeSBhbmQKaGF2ZSBub3QgY2hhbmdlZCBpbiBxdWl0ZSBzb21lIHRpbWUuCgpB bHRob3VnaCB0aGUgb3RoZXIgdHdvIGFyZSBzb21ld2hhdCBuZXcgdGhleSBhcmUgYmFzZWQgb24g dG9wIG9mIGxvbmcKc3RhbmRpbmcgc3RhYmxlIGlvY3Rscywgd2hpY2ggZ2l2ZXMgbWUgc29tZSBj b25maWRlbmNlLgoKTm9uZXRoZWxlc3MgSSB3b3VsZCBhcHByZWNpYXRlIGV4dHJhIHJldmlldyBv ZiBhdCBsZWFzdCB0aGUgaW50ZXJmYWNlCmhlYWRlcnMgb2YgYWxsIG9mIHRoZXNlIHdpdGggYSBw YXJ0aWN1bGFyIGV5ZSB0byB0aGUgc3VpdGFiaWxpdHkgb2YgdGhlc2UKaW50ZXJmYWNlcyBiZWlu ZyBtYWludGFpbmVkIGluIGFuIEFCSSAoX0JfLCBub3QgX1BfKSBzdGFibGUgd2F5IGdvaW5nCmZv cndhcmQuCgpTdGlsbCB0byBjb21lIHdvdWxkIGJlIGxpYnJhcmllcyBmb3Igc3BlY2lmaWMgb3V0 IG9mIHRyZWUgcHVycG9zZXMKKGRldmljZSBtb2RlbCwga2V4ZWMpLCB3aGljaCB3b3VsZCBiZSBh ZGRpbmcgbmV3IGxpYnJhcnkgYXQgdGhlIHNhbWUKbGV2ZWwgYXMgbGlieGMgSSB0aGluaywgcmF0 aGVyIHRoYW4gdW5kZXJuZWF0aCwgaS5lLiBhbHNvIHVzaW5nIHRoZQpsaWJyYXJpZXMgc3BsaXQg b3V0IGhlcmUsIGJ1dCBob3BlZnVsbHkgbm90IGxpYnhlbmN0cmwgaXRzZWxmLgoKVGhlIG5ldyBs aWJyYXJpZXMgdXNlIGxpbmtlciB2ZXJzaW9uLXNjcmlwdHMgdG8gaG9wZWZ1bGx5IG1ha2UgZnV0 dXJlCkFCSSBjaGFuZ2VzIGJlIHBvc3NpYmxlIGluIGEgY29tcGF0aWJsZSB3YXkuCgpTaW5jZSBs YXN0IHRpbWUgSSBoYXZlOgoKICogTW92ZWQgZXZlcnl0aGluZyBmcm9tIHRvb2xzL2xpYnhlbmZv byB0byB0b29scy9saWJzL2ZvbwogKiBBZGRlZCBwYXRjaGVzIHRvIHFlbXUteGVuIHRvIHVzZSB0 aGUgbmV3IGxpYnJhcmllcyBpbnN0ZWFkIG9mIHRoZSBjb21wYXQKICAgbGF5ZXIuIFRoZXNlIGNh biBjb21lIGFueSB0aW1lIGFmdGVyIHRoaXMgdHJhbnNpdGlvbiBhbmQgYXJlIG5vdAogICBlbnRh bmdsZWQgKGR1ZSB0byB0aGUgY29tcGF0IGxheWVyIGJlaW5nIHByZXNlbnQgaW4gdGhlIG1lYW50 aW1lKQogKiBSZXZpZXdlZCBlYWNoIG9mIHRoZSBuZXcgbGlicmFyaWVzIGZvcgogICAgKiBFcnJv ciBoYW5kbGluZywgU3BlY2lmaWNhbGx5IG5vIHJldHVybiAtZXJybm8gdHlwZSBzdHVmZiwgYnV0 IGluc3RlYWQKICAgICAgcmV0dXJuIC0xIG9yIE5VTEwgYW5kIHNldHRpbmcgZXJybm8gaWYgbmVj ZXNzYXJ5CiAgICAqIEFwcHJvcHJpYXRlIHR5cGVzIChzb21lIGRpc2N1c3Npb24gYXJvdW5kIHRo YXQgaGFzbid0IGJlZW4gZm9sZGVkIGluCiAgICAgIGhlcmUgeWV0KQogICAgKiBObyBpbmxpbmVz IGluIHRoZSBwdWJpYyBoZWFkZXJzICh0cm91Ymxlc29tZSBmb3IgQUJJIGNvbXBhdGliaWxpdHkp CiAgICAqIERvY3VtZW50YXRpb24sIGluIHRoYXQgdGhleSBhbGwgaGF2ZSBzb21lLCBub3QgdGhh dCBpdCBpcyBuZWNlc3NhcmlseQogICAgICBjb21wcmVoZW5zaXZlIG9yIGNvbXBsZXRlIChhbHRo b3VnaCBpdCBkb2VzIGxvb2sgYmV0dGVyIHRoYW4gdGhlCiAgICAgIGF2ZXJhZ2UpLgogKiBEcm9w cGVkwqAKICAgwqBhbmQgeW91CiAgIGNhbiBmaW5kIGl0cyBoaXN0b3J5CiAqIEZpeGVkIHZhcmlv dXMgaXNzdWUuCgpUaGUgd2hvbGUgdGhpbmcgaGFzIGJlZW4gYnVpbGQgYW5kIHJ1bnRpbWUgdGVz dGVkIG9uIExpbnV4IGFuZCBzdHViZG9tcywKYW5kIGJ1aWx0IChidXQgbm90IHJ1bikgb24gRnJl ZUJTRC4gTmVpdGhlciBOZXRCU0Qgbm9yIFNvbGFyaXMgaGF2ZSBiZWVuCnRlc3RlZCBhdCBhbGwu IEl0J3MgY2VydGFpbmx5IG5vdCBpbXBvc3NpYmxlIHRoYXQgSSd2ZSBub3QgZ290IHRoZQojaW5j bHVkZXMgaW4gdGhlIG5ldyBmaWxlcyBxdWl0ZSByaWdodC4KCklhbi4KCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCk1pbmlvcy1kZXZlbCBtYWlsaW5nIGxp c3QKTWluaW9zLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHA6Ly9saXN0cy54ZW5wcm9q ZWN0Lm9yZy9jZ2ktYmluL21haWxtYW4vbGlzdGluZm8vbWluaW9zLWRldmVs From minios-devel-bounces@lists.xenproject.org Wed Oct 07 14:12:31 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 07 Oct 2015 14:12:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpSJ-0003C2-QJ; Wed, 07 Oct 2015 14:12:31 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpQD-0002xN-Op for minios-devel@lists.xenproject.org; Wed, 07 Oct 2015 14:10:21 +0000 Received: from [85.158.139.211] by server-6.bemta-5.messagelabs.com id D7/A9-22089-DC725165; Wed, 07 Oct 2015 14:10:21 +0000 X-Env-Sender: prvs=71508c46d=Ian.Jackson@citrix.com X-Msg-Ref: server-3.tower-206.messagelabs.com!1444227019!8491631!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 24327 invoked from network); 7 Oct 2015 14:10:20 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-3.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 7 Oct 2015 14:10:20 -0000 X-IronPort-AV: E=Sophos;i="5.17,649,1437436800"; d="scan'208";a="308658429" From: Ian Jackson MIME-Version: 1.0 Message-ID: <22037.10182.63284.99683@mariner.uk.xensource.com> Date: Wed, 7 Oct 2015 15:10:14 +0100 To: Ian Campbell In-Reply-To: <1444226543.1410.53.camel@citrix.com> References: <1444226543.1410.53.camel@citrix.com> X-Mailer: VM 8.1.0 under 23.4.1 (i486-pc-linux-gnu) X-DLP: MIA1 X-Mailman-Approved-At: Wed, 07 Oct 2015 14:12:30 +0000 Cc: minios-devel@lists.xenproject.org, Stefano Stabellini , Wei Liu , Roger Pau Monne , xen-devel Subject: Re: [Minios-devel] [PATCH v3 0/] Begin to disentangle libxenctrl and provide some stable libraries X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Ian Campbell writes ("[PATCH v3 0/] Begin to disentangle libxenctrl and provide some stable libraries"): > The tip of the xen.git branch contains an extra patch adding a .config > into the tree which should get the correct things for the HEAD of the > branch, but not further back. Wait, what ? .config is for the user's settings. Ian. _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Oct 07 14:12:31 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 07 Oct 2015 14:12:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpSJ-0003C2-QJ; Wed, 07 Oct 2015 14:12:31 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpQD-0002xN-Op for minios-devel@lists.xenproject.org; Wed, 07 Oct 2015 14:10:21 +0000 Received: from [85.158.139.211] by server-6.bemta-5.messagelabs.com id D7/A9-22089-DC725165; Wed, 07 Oct 2015 14:10:21 +0000 X-Env-Sender: prvs=71508c46d=Ian.Jackson@citrix.com X-Msg-Ref: server-3.tower-206.messagelabs.com!1444227019!8491631!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 24327 invoked from network); 7 Oct 2015 14:10:20 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-3.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 7 Oct 2015 14:10:20 -0000 X-IronPort-AV: E=Sophos;i="5.17,649,1437436800"; d="scan'208";a="308658429" From: Ian Jackson MIME-Version: 1.0 Message-ID: <22037.10182.63284.99683@mariner.uk.xensource.com> Date: Wed, 7 Oct 2015 15:10:14 +0100 To: Ian Campbell In-Reply-To: <1444226543.1410.53.camel@citrix.com> References: <1444226543.1410.53.camel@citrix.com> X-Mailer: VM 8.1.0 under 23.4.1 (i486-pc-linux-gnu) X-DLP: MIA1 X-Mailman-Approved-At: Wed, 07 Oct 2015 14:12:30 +0000 Cc: minios-devel@lists.xenproject.org, Stefano Stabellini , Wei Liu , Roger Pau Monne , xen-devel Subject: Re: [Minios-devel] [PATCH v3 0/] Begin to disentangle libxenctrl and provide some stable libraries X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Ian Campbell writes ("[PATCH v3 0/] Begin to disentangle libxenctrl and provide some stable libraries"): > The tip of the xen.git branch contains an extra patch adding a .config > into the tree which should get the correct things for the HEAD of the > branch, but not further back. Wait, what ? .config is for the user's settings. Ian. _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Oct 07 14:16:38 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 07 Oct 2015 14:16:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpWI-0004fq-MA; Wed, 07 Oct 2015 14:16:38 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpW9-0004Gd-7o for minios-devel@lists.xenproject.org; Wed, 07 Oct 2015 14:16:29 +0000 Received: from [193.109.254.147] by server-3.bemta-14.messagelabs.com id C8/0B-25435-C3925165; Wed, 07 Oct 2015 14:16:28 +0000 X-Env-Sender: prvs=715f1a83e=Ian.Campbell@citrix.com X-Msg-Ref: server-12.tower-27.messagelabs.com!1444227386!56595820!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 8529 invoked from network); 7 Oct 2015 14:16:27 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-12.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 7 Oct 2015 14:16:27 -0000 X-IronPort-AV: E=Sophos;i="5.17,649,1437436800"; d="scan'208";a="304841775" From: Ian Campbell To: , , Date: Wed, 7 Oct 2015 15:16:18 +0100 Message-ID: <1444227381-1188-2-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1444226543.1410.53.camel@citrix.com> References: <1444226543.1410.53.camel@citrix.com> MIME-Version: 1.0 X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, Ian Campbell Subject: [Minios-devel] [PATCH MINI-OS v3 2/5] mini-os: Include libxenevtchn with libxc X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org libxenevtchn has just been split out from libxc. From mini-os's point of view we don't care about the distinction, so keep things simple by just including libxenevtchn if libxc is enabled. Signed-off-by: Ian Campbell --- v2: Adjust for libs/$lib layout. --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index daee46c..d1d8dc4 100644 --- a/Makefile +++ b/Makefile @@ -166,6 +166,7 @@ OBJS := $(filter-out $(OBJ_DIR)/lwip%.o $(LWO), $(OBJS)) ifeq ($(libc),y) ifeq ($(CONFIG_XC),y) APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/toollog -whole-archive -lxentoollog -no-whole-archive +APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/evtchn -whole-archive -lxenevtchn -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxc-$(MINIOS_TARGET_ARCH) -whole-archive -lxenguest -lxenctrl -no-whole-archive endif APP_LDLIBS += -lpci -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Oct 07 14:16:38 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 07 Oct 2015 14:16:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpWI-0004fq-MA; Wed, 07 Oct 2015 14:16:38 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpW9-0004Gd-7o for minios-devel@lists.xenproject.org; Wed, 07 Oct 2015 14:16:29 +0000 Received: from [193.109.254.147] by server-3.bemta-14.messagelabs.com id C8/0B-25435-C3925165; Wed, 07 Oct 2015 14:16:28 +0000 X-Env-Sender: prvs=715f1a83e=Ian.Campbell@citrix.com X-Msg-Ref: server-12.tower-27.messagelabs.com!1444227386!56595820!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 8529 invoked from network); 7 Oct 2015 14:16:27 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-12.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 7 Oct 2015 14:16:27 -0000 X-IronPort-AV: E=Sophos;i="5.17,649,1437436800"; d="scan'208";a="304841775" From: Ian Campbell To: , , Date: Wed, 7 Oct 2015 15:16:18 +0100 Message-ID: <1444227381-1188-2-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1444226543.1410.53.camel@citrix.com> References: <1444226543.1410.53.camel@citrix.com> MIME-Version: 1.0 X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, Ian Campbell Subject: [Minios-devel] [PATCH MINI-OS v3 2/5] mini-os: Include libxenevtchn with libxc X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org libxenevtchn has just been split out from libxc. From mini-os's point of view we don't care about the distinction, so keep things simple by just including libxenevtchn if libxc is enabled. Signed-off-by: Ian Campbell --- v2: Adjust for libs/$lib layout. --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index daee46c..d1d8dc4 100644 --- a/Makefile +++ b/Makefile @@ -166,6 +166,7 @@ OBJS := $(filter-out $(OBJ_DIR)/lwip%.o $(LWO), $(OBJS)) ifeq ($(libc),y) ifeq ($(CONFIG_XC),y) APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/toollog -whole-archive -lxentoollog -no-whole-archive +APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/evtchn -whole-archive -lxenevtchn -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxc-$(MINIOS_TARGET_ARCH) -whole-archive -lxenguest -lxenctrl -no-whole-archive endif APP_LDLIBS += -lpci -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Oct 07 14:16:43 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 07 Oct 2015 14:16:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpWN-0004uk-LP; Wed, 07 Oct 2015 14:16:43 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpWA-0004I9-3b for minios-devel@lists.xenproject.org; Wed, 07 Oct 2015 14:16:30 +0000 Received: from [193.109.254.147] by server-2.bemta-14.messagelabs.com id E6/83-12889-D3925165; Wed, 07 Oct 2015 14:16:29 +0000 X-Env-Sender: prvs=715f1a83e=Ian.Campbell@citrix.com X-Msg-Ref: server-12.tower-27.messagelabs.com!1444227386!56595820!2 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 8609 invoked from network); 7 Oct 2015 14:16:28 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-12.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 7 Oct 2015 14:16:28 -0000 X-IronPort-AV: E=Sophos;i="5.17,649,1437436800"; d="scan'208";a="304841797" From: Ian Campbell To: , , Date: Wed, 7 Oct 2015 15:16:19 +0100 Message-ID: <1444227381-1188-3-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1444226543.1410.53.camel@citrix.com> References: <1444226543.1410.53.camel@citrix.com> MIME-Version: 1.0 X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, Ian Campbell Subject: [Minios-devel] [PATCH MINI-OS v3 3/5] mini-os: Include libxengnttab with libxc X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org libxengnttab has just been split out from libxc. From mini-os's point of view we don't care about the distinction, so keep things simple by just including libxengnttab if libxc is enabled. Signed-off-by: Ian Campbell --- v2: Adjust for libs/$lib layout. --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index d1d8dc4..521f647 100644 --- a/Makefile +++ b/Makefile @@ -167,6 +167,7 @@ ifeq ($(libc),y) ifeq ($(CONFIG_XC),y) APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/toollog -whole-archive -lxentoollog -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/evtchn -whole-archive -lxenevtchn -no-whole-archive +APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/gnttab -whole-archive -lxengnttab -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxc-$(MINIOS_TARGET_ARCH) -whole-archive -lxenguest -lxenctrl -no-whole-archive endif APP_LDLIBS += -lpci -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Oct 07 14:16:43 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 07 Oct 2015 14:16:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpWN-0004uk-LP; Wed, 07 Oct 2015 14:16:43 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpWA-0004I9-3b for minios-devel@lists.xenproject.org; Wed, 07 Oct 2015 14:16:30 +0000 Received: from [193.109.254.147] by server-2.bemta-14.messagelabs.com id E6/83-12889-D3925165; Wed, 07 Oct 2015 14:16:29 +0000 X-Env-Sender: prvs=715f1a83e=Ian.Campbell@citrix.com X-Msg-Ref: server-12.tower-27.messagelabs.com!1444227386!56595820!2 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 8609 invoked from network); 7 Oct 2015 14:16:28 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-12.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 7 Oct 2015 14:16:28 -0000 X-IronPort-AV: E=Sophos;i="5.17,649,1437436800"; d="scan'208";a="304841797" From: Ian Campbell To: , , Date: Wed, 7 Oct 2015 15:16:19 +0100 Message-ID: <1444227381-1188-3-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1444226543.1410.53.camel@citrix.com> References: <1444226543.1410.53.camel@citrix.com> MIME-Version: 1.0 X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, Ian Campbell Subject: [Minios-devel] [PATCH MINI-OS v3 3/5] mini-os: Include libxengnttab with libxc X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org libxengnttab has just been split out from libxc. From mini-os's point of view we don't care about the distinction, so keep things simple by just including libxengnttab if libxc is enabled. Signed-off-by: Ian Campbell --- v2: Adjust for libs/$lib layout. --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index d1d8dc4..521f647 100644 --- a/Makefile +++ b/Makefile @@ -167,6 +167,7 @@ ifeq ($(libc),y) ifeq ($(CONFIG_XC),y) APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/toollog -whole-archive -lxentoollog -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/evtchn -whole-archive -lxenevtchn -no-whole-archive +APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/gnttab -whole-archive -lxengnttab -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxc-$(MINIOS_TARGET_ARCH) -whole-archive -lxenguest -lxenctrl -no-whole-archive endif APP_LDLIBS += -lpci -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Oct 07 14:16:44 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 07 Oct 2015 14:16:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpWO-0004vi-Bn; Wed, 07 Oct 2015 14:16:44 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpWC-0004NF-4f for minios-devel@lists.xenproject.org; Wed, 07 Oct 2015 14:16:32 +0000 Received: from [85.158.139.211] by server-6.bemta-5.messagelabs.com id 89/0D-22089-F3925165; Wed, 07 Oct 2015 14:16:31 +0000 X-Env-Sender: prvs=715f1a83e=Ian.Campbell@citrix.com X-Msg-Ref: server-6.tower-206.messagelabs.com!1444227389!40616108!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 4638 invoked from network); 7 Oct 2015 14:16:30 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-6.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 7 Oct 2015 14:16:30 -0000 X-IronPort-AV: E=Sophos;i="5.17,649,1437436800"; d="scan'208";a="308660365" From: Ian Campbell To: , , Date: Wed, 7 Oct 2015 15:16:17 +0100 Message-ID: <1444227381-1188-1-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1444226543.1410.53.camel@citrix.com> References: <1444226543.1410.53.camel@citrix.com> MIME-Version: 1.0 X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, Ian Campbell Subject: [Minios-devel] [PATCH MINI-OS v3 1/5] mini-os: Include libxentoollog with libxc X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org libxentoollog has just been split out from libxc. From mini-os's point of view we don't care about the distinction, so keep things simple by just including libxentoollog if libxc is enabled. Signed-off-by: Ian Campbell --- v2: Adjust for libs/$lib layout. --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 2cb5e51..daee46c 100644 --- a/Makefile +++ b/Makefile @@ -165,6 +165,7 @@ OBJS := $(filter-out $(OBJ_DIR)/lwip%.o $(LWO), $(OBJS)) ifeq ($(libc),y) ifeq ($(CONFIG_XC),y) +APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/toollog -whole-archive -lxentoollog -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxc-$(MINIOS_TARGET_ARCH) -whole-archive -lxenguest -lxenctrl -no-whole-archive endif APP_LDLIBS += -lpci -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Oct 07 14:16:44 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 07 Oct 2015 14:16:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpWN-0004v8-PH; Wed, 07 Oct 2015 14:16:43 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpWA-0004KP-NF for minios-devel@lists.xenproject.org; Wed, 07 Oct 2015 14:16:30 +0000 Received: from [193.109.254.147] by server-16.bemta-14.messagelabs.com id A8/76-05427-D3925165; Wed, 07 Oct 2015 14:16:29 +0000 X-Env-Sender: prvs=715f1a83e=Ian.Campbell@citrix.com X-Msg-Ref: server-12.tower-27.messagelabs.com!1444227386!56595820!3 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 8704 invoked from network); 7 Oct 2015 14:16:29 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-12.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 7 Oct 2015 14:16:29 -0000 X-IronPort-AV: E=Sophos;i="5.17,649,1437436800"; d="scan'208";a="304841809" From: Ian Campbell To: , , Date: Wed, 7 Oct 2015 15:16:20 +0100 Message-ID: <1444227381-1188-4-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1444226543.1410.53.camel@citrix.com> References: <1444226543.1410.53.camel@citrix.com> MIME-Version: 1.0 X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, Ian Campbell Subject: [Minios-devel] [PATCH MINI-OS v3 4/5] mini-os: Include libxencall with libxc X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org libxencall has just been split out from libxc. From mini-os's point of view we don't care about the distinction, so keep things simple by just including libxencall if libxc is enabled. Signed-off-by: Ian Campbell --- v2: Adjust for libs/$lib layout. --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 521f647..c900540 100644 --- a/Makefile +++ b/Makefile @@ -168,6 +168,7 @@ ifeq ($(CONFIG_XC),y) APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/toollog -whole-archive -lxentoollog -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/evtchn -whole-archive -lxenevtchn -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/gnttab -whole-archive -lxengnttab -no-whole-archive +APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/call -whole-archive -lxencall -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxc-$(MINIOS_TARGET_ARCH) -whole-archive -lxenguest -lxenctrl -no-whole-archive endif APP_LDLIBS += -lpci -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Oct 07 14:16:44 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 07 Oct 2015 14:16:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpWO-0004vi-Bn; Wed, 07 Oct 2015 14:16:44 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpWC-0004NF-4f for minios-devel@lists.xenproject.org; Wed, 07 Oct 2015 14:16:32 +0000 Received: from [85.158.139.211] by server-6.bemta-5.messagelabs.com id 89/0D-22089-F3925165; Wed, 07 Oct 2015 14:16:31 +0000 X-Env-Sender: prvs=715f1a83e=Ian.Campbell@citrix.com X-Msg-Ref: server-6.tower-206.messagelabs.com!1444227389!40616108!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 4638 invoked from network); 7 Oct 2015 14:16:30 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-6.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 7 Oct 2015 14:16:30 -0000 X-IronPort-AV: E=Sophos;i="5.17,649,1437436800"; d="scan'208";a="308660365" From: Ian Campbell To: , , Date: Wed, 7 Oct 2015 15:16:17 +0100 Message-ID: <1444227381-1188-1-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1444226543.1410.53.camel@citrix.com> References: <1444226543.1410.53.camel@citrix.com> MIME-Version: 1.0 X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, Ian Campbell Subject: [Minios-devel] [PATCH MINI-OS v3 1/5] mini-os: Include libxentoollog with libxc X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org libxentoollog has just been split out from libxc. From mini-os's point of view we don't care about the distinction, so keep things simple by just including libxentoollog if libxc is enabled. Signed-off-by: Ian Campbell --- v2: Adjust for libs/$lib layout. --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 2cb5e51..daee46c 100644 --- a/Makefile +++ b/Makefile @@ -165,6 +165,7 @@ OBJS := $(filter-out $(OBJ_DIR)/lwip%.o $(LWO), $(OBJS)) ifeq ($(libc),y) ifeq ($(CONFIG_XC),y) +APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/toollog -whole-archive -lxentoollog -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxc-$(MINIOS_TARGET_ARCH) -whole-archive -lxenguest -lxenctrl -no-whole-archive endif APP_LDLIBS += -lpci -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Oct 07 14:16:44 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 07 Oct 2015 14:16:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpWN-0004v8-PH; Wed, 07 Oct 2015 14:16:43 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpWA-0004KP-NF for minios-devel@lists.xenproject.org; Wed, 07 Oct 2015 14:16:30 +0000 Received: from [193.109.254.147] by server-16.bemta-14.messagelabs.com id A8/76-05427-D3925165; Wed, 07 Oct 2015 14:16:29 +0000 X-Env-Sender: prvs=715f1a83e=Ian.Campbell@citrix.com X-Msg-Ref: server-12.tower-27.messagelabs.com!1444227386!56595820!3 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 8704 invoked from network); 7 Oct 2015 14:16:29 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-12.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 7 Oct 2015 14:16:29 -0000 X-IronPort-AV: E=Sophos;i="5.17,649,1437436800"; d="scan'208";a="304841809" From: Ian Campbell To: , , Date: Wed, 7 Oct 2015 15:16:20 +0100 Message-ID: <1444227381-1188-4-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1444226543.1410.53.camel@citrix.com> References: <1444226543.1410.53.camel@citrix.com> MIME-Version: 1.0 X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, Ian Campbell Subject: [Minios-devel] [PATCH MINI-OS v3 4/5] mini-os: Include libxencall with libxc X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org libxencall has just been split out from libxc. From mini-os's point of view we don't care about the distinction, so keep things simple by just including libxencall if libxc is enabled. Signed-off-by: Ian Campbell --- v2: Adjust for libs/$lib layout. --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 521f647..c900540 100644 --- a/Makefile +++ b/Makefile @@ -168,6 +168,7 @@ ifeq ($(CONFIG_XC),y) APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/toollog -whole-archive -lxentoollog -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/evtchn -whole-archive -lxenevtchn -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/gnttab -whole-archive -lxengnttab -no-whole-archive +APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/call -whole-archive -lxencall -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxc-$(MINIOS_TARGET_ARCH) -whole-archive -lxenguest -lxenctrl -no-whole-archive endif APP_LDLIBS += -lpci -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Oct 07 14:16:47 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 07 Oct 2015 14:16:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpWQ-00053a-RV; Wed, 07 Oct 2015 14:16:46 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpWC-0004Ok-On for minios-devel@lists.xenproject.org; Wed, 07 Oct 2015 14:16:32 +0000 Received: from [85.158.139.211] by server-1.bemta-5.messagelabs.com id B0/4D-32615-04925165; Wed, 07 Oct 2015 14:16:32 +0000 X-Env-Sender: prvs=715f1a83e=Ian.Campbell@citrix.com X-Msg-Ref: server-6.tower-206.messagelabs.com!1444227389!40616108!2 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 4786 invoked from network); 7 Oct 2015 14:16:31 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-6.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 7 Oct 2015 14:16:31 -0000 X-IronPort-AV: E=Sophos;i="5.17,649,1437436800"; d="scan'208";a="308660382" From: Ian Campbell To: , , Date: Wed, 7 Oct 2015 15:16:21 +0100 Message-ID: <1444227381-1188-5-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1444226543.1410.53.camel@citrix.com> References: <1444226543.1410.53.camel@citrix.com> MIME-Version: 1.0 X-DLP: MIA1 Cc: minios-devel@lists.xenproject.org, Ian Campbell Subject: [Minios-devel] [PATCH MINI-OS v3 5/5] mini-os: Include libxenforeignmemory with libxc X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org libxenforeignmemory has just been split out from libxc. From mini-os's point of view we don't care about the distinction, so keep things simple by just including libxenforeignmemory if libxc is enabled. Signed-off-by: Ian Campbell --- v2: Adjust for libs/$lib layout. --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index c900540..cfe015a 100644 --- a/Makefile +++ b/Makefile @@ -169,6 +169,7 @@ APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/toollog -whole-ar APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/evtchn -whole-archive -lxenevtchn -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/gnttab -whole-archive -lxengnttab -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/call -whole-archive -lxencall -no-whole-archive +APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/foreignmemory -whole-archive -lxenforeignmemory -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxc-$(MINIOS_TARGET_ARCH) -whole-archive -lxenguest -lxenctrl -no-whole-archive endif APP_LDLIBS += -lpci -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Oct 07 14:16:47 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 07 Oct 2015 14:16:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpWQ-00053a-RV; Wed, 07 Oct 2015 14:16:46 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpWC-0004Ok-On for minios-devel@lists.xenproject.org; Wed, 07 Oct 2015 14:16:32 +0000 Received: from [85.158.139.211] by server-1.bemta-5.messagelabs.com id B0/4D-32615-04925165; Wed, 07 Oct 2015 14:16:32 +0000 X-Env-Sender: prvs=715f1a83e=Ian.Campbell@citrix.com X-Msg-Ref: server-6.tower-206.messagelabs.com!1444227389!40616108!2 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 4786 invoked from network); 7 Oct 2015 14:16:31 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-6.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 7 Oct 2015 14:16:31 -0000 X-IronPort-AV: E=Sophos;i="5.17,649,1437436800"; d="scan'208";a="308660382" From: Ian Campbell To: , , Date: Wed, 7 Oct 2015 15:16:21 +0100 Message-ID: <1444227381-1188-5-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1444226543.1410.53.camel@citrix.com> References: <1444226543.1410.53.camel@citrix.com> MIME-Version: 1.0 X-DLP: MIA1 Cc: minios-devel@lists.xenproject.org, Ian Campbell Subject: [Minios-devel] [PATCH MINI-OS v3 5/5] mini-os: Include libxenforeignmemory with libxc X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org libxenforeignmemory has just been split out from libxc. From mini-os's point of view we don't care about the distinction, so keep things simple by just including libxenforeignmemory if libxc is enabled. Signed-off-by: Ian Campbell --- v2: Adjust for libs/$lib layout. --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index c900540..cfe015a 100644 --- a/Makefile +++ b/Makefile @@ -169,6 +169,7 @@ APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/toollog -whole-ar APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/evtchn -whole-archive -lxenevtchn -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/gnttab -whole-archive -lxengnttab -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/call -whole-archive -lxencall -no-whole-archive +APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/foreignmemory -whole-archive -lxenforeignmemory -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxc-$(MINIOS_TARGET_ARCH) -whole-archive -lxenguest -lxenctrl -no-whole-archive endif APP_LDLIBS += -lpci -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Oct 07 14:19:04 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 07 Oct 2015 14:19:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpYe-0008R8-O6; Wed, 07 Oct 2015 14:19:04 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpYd-0008PJ-63 for minios-devel@lists.xenproject.org; Wed, 07 Oct 2015 14:19:03 +0000 Received: from [85.158.137.68] by server-6.bemta-3.messagelabs.com id 40/5F-29649-6D925165; Wed, 07 Oct 2015 14:19:02 +0000 X-Env-Sender: prvs=715f1a83e=Ian.Campbell@citrix.com X-Msg-Ref: server-7.tower-31.messagelabs.com!1444227540!16533824!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 14842 invoked from network); 7 Oct 2015 14:19:01 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-7.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 7 Oct 2015 14:19:01 -0000 X-IronPort-AV: E=Sophos;i="5.17,649,1437436800"; d="scan'208";a="308661197" Message-ID: <1444227539.1410.56.camel@citrix.com> From: Ian Campbell To: Ian Jackson Date: Wed, 7 Oct 2015 15:18:59 +0100 In-Reply-To: <22037.10182.63284.99683@mariner.uk.xensource.com> References: <1444226543.1410.53.camel@citrix.com> <22037.10182.63284.99683@mariner.uk.xensource.com> X-Mailer: Evolution 3.16.5-1 MIME-Version: 1.0 X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, Stefano Stabellini , Wei Liu , Roger Pau Monne , xen-devel Subject: Re: [Minios-devel] [PATCH v3 0/] Begin to disentangle libxenctrl and provide some stable libraries X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Wed, 2015-10-07 at 15:10 +0100, Ian Jackson wrote: > Ian Campbell writes ("[PATCH v3 0/] Begin to disentangle > libxenctrl and provide some stable libraries"): > > The tip of the xen.git branch contains an extra patch adding a .config > > into the tree which should get the correct things for the HEAD of the > > branch, but not further back. > > Wait, what ? .config is for the user's settings. Right, this is a convenience for people wanting to play with this stuff, not something to be committed. Hence "extra patch" and the patch title being "HACK:...". Ian. _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Oct 07 14:19:04 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 07 Oct 2015 14:19:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpYe-0008R8-O6; Wed, 07 Oct 2015 14:19:04 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpYd-0008PJ-63 for minios-devel@lists.xenproject.org; Wed, 07 Oct 2015 14:19:03 +0000 Received: from [85.158.137.68] by server-6.bemta-3.messagelabs.com id 40/5F-29649-6D925165; Wed, 07 Oct 2015 14:19:02 +0000 X-Env-Sender: prvs=715f1a83e=Ian.Campbell@citrix.com X-Msg-Ref: server-7.tower-31.messagelabs.com!1444227540!16533824!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 14842 invoked from network); 7 Oct 2015 14:19:01 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-7.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 7 Oct 2015 14:19:01 -0000 X-IronPort-AV: E=Sophos;i="5.17,649,1437436800"; d="scan'208";a="308661197" Message-ID: <1444227539.1410.56.camel@citrix.com> From: Ian Campbell To: Ian Jackson Date: Wed, 7 Oct 2015 15:18:59 +0100 In-Reply-To: <22037.10182.63284.99683@mariner.uk.xensource.com> References: <1444226543.1410.53.camel@citrix.com> <22037.10182.63284.99683@mariner.uk.xensource.com> X-Mailer: Evolution 3.16.5-1 MIME-Version: 1.0 X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, Stefano Stabellini , Wei Liu , Roger Pau Monne , xen-devel Subject: Re: [Minios-devel] [PATCH v3 0/] Begin to disentangle libxenctrl and provide some stable libraries X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Wed, 2015-10-07 at 15:10 +0100, Ian Jackson wrote: > Ian Campbell writes ("[PATCH v3 0/] Begin to disentangle > libxenctrl and provide some stable libraries"): > > The tip of the xen.git branch contains an extra patch adding a .config > > into the tree which should get the correct things for the HEAD of the > > branch, but not further back. > > Wait, what ? .config is for the user's settings. Right, this is a convenience for people wanting to play with this stuff, not something to be committed. Hence "extra patch" and the patch title being "HACK:...". Ian. _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Oct 07 14:28:57 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 07 Oct 2015 14:28:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpiD-00018a-99; Wed, 07 Oct 2015 14:28:57 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpiC-00018M-7H for minios-devel@lists.xenproject.org; Wed, 07 Oct 2015 14:28:56 +0000 Received: from [85.158.137.68] by server-7.bemta-3.messagelabs.com id 35/B6-16965-72C25165; Wed, 07 Oct 2015 14:28:55 +0000 X-Env-Sender: prvs=715f1a83e=Ian.Campbell@citrix.com X-Msg-Ref: server-7.tower-31.messagelabs.com!1444228133!16537956!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 10895 invoked from network); 7 Oct 2015 14:28:54 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-7.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 7 Oct 2015 14:28:54 -0000 X-IronPort-AV: E=Sophos;i="5.17,649,1437436800"; d="scan'208";a="304845663" Message-ID: <1444228131.1410.57.camel@citrix.com> From: Ian Campbell To: Ian Jackson Date: Wed, 7 Oct 2015 15:28:51 +0100 In-Reply-To: <1444227539.1410.56.camel@citrix.com> References: <1444226543.1410.53.camel@citrix.com> <22037.10182.63284.99683@mariner.uk.xensource.com> <1444227539.1410.56.camel@citrix.com> X-Mailer: Evolution 3.16.5-1 MIME-Version: 1.0 X-DLP: MIA1 Cc: minios-devel@lists.xenproject.org, xen-devel , Roger Pau Monne , Wei Liu , Stefano Stabellini Subject: Re: [Minios-devel] [PATCH v3 0/] Begin to disentangle libxenctrl and provide some stable libraries X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Wed, 2015-10-07 at 15:18 +0100, Ian Campbell wrote: > On Wed, 2015-10-07 at 15:10 +0100, Ian Jackson wrote: > > Ian Campbell writes ("[PATCH v3 0/] Begin to disentangle > > libxenctrl and provide some stable libraries"): > > > The tip of the xen.git branch contains an extra patch adding a > > > .config > > > into the tree which should get the correct things for the HEAD of the > > > branch, but not further back. > > > > Wait, what ? .config is for the user's settings. > > Right, this is a convenience for people wanting to play with this stuff, > not something to be committed. Hence "extra patch" and the patch title > being "HACK:...". Or maybe your point was I should have patched Config.mk instead, which is probably true but I was lazy and just committed the file I was using. Ian. _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Oct 07 14:28:57 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 07 Oct 2015 14:28:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpiD-00018a-99; Wed, 07 Oct 2015 14:28:57 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjpiC-00018M-7H for minios-devel@lists.xenproject.org; Wed, 07 Oct 2015 14:28:56 +0000 Received: from [85.158.137.68] by server-7.bemta-3.messagelabs.com id 35/B6-16965-72C25165; Wed, 07 Oct 2015 14:28:55 +0000 X-Env-Sender: prvs=715f1a83e=Ian.Campbell@citrix.com X-Msg-Ref: server-7.tower-31.messagelabs.com!1444228133!16537956!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 10895 invoked from network); 7 Oct 2015 14:28:54 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-7.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 7 Oct 2015 14:28:54 -0000 X-IronPort-AV: E=Sophos;i="5.17,649,1437436800"; d="scan'208";a="304845663" Message-ID: <1444228131.1410.57.camel@citrix.com> From: Ian Campbell To: Ian Jackson Date: Wed, 7 Oct 2015 15:28:51 +0100 In-Reply-To: <1444227539.1410.56.camel@citrix.com> References: <1444226543.1410.53.camel@citrix.com> <22037.10182.63284.99683@mariner.uk.xensource.com> <1444227539.1410.56.camel@citrix.com> X-Mailer: Evolution 3.16.5-1 MIME-Version: 1.0 X-DLP: MIA1 Cc: minios-devel@lists.xenproject.org, xen-devel , Roger Pau Monne , Wei Liu , Stefano Stabellini Subject: Re: [Minios-devel] [PATCH v3 0/] Begin to disentangle libxenctrl and provide some stable libraries X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Wed, 2015-10-07 at 15:18 +0100, Ian Campbell wrote: > On Wed, 2015-10-07 at 15:10 +0100, Ian Jackson wrote: > > Ian Campbell writes ("[PATCH v3 0/] Begin to disentangle > > libxenctrl and provide some stable libraries"): > > > The tip of the xen.git branch contains an extra patch adding a > > > .config > > > into the tree which should get the correct things for the HEAD of the > > > branch, but not further back. > > > > Wait, what ? .config is for the user's settings. > > Right, this is a convenience for people wanting to play with this stuff, > not something to be committed. Hence "extra patch" and the patch title > being "HACK:...". Or maybe your point was I should have patched Config.mk instead, which is probably true but I was lazy and just committed the file I was using. Ian. _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Tue Oct 13 11:51:44 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 13 Oct 2015 11:51:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zly7L-0006wg-8l; Tue, 13 Oct 2015 11:51:43 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZlxxD-0006Bz-BY for minios-devel@lists.xenproject.org; Tue, 13 Oct 2015 11:41:15 +0000 Received: from [85.158.137.68] by server-9.bemta-3.messagelabs.com id 9C/F4-10678-ADDEC165; Tue, 13 Oct 2015 11:41:14 +0000 X-Env-Sender: wyaozheng@gmail.com X-Msg-Ref: server-11.tower-31.messagelabs.com!1444736468!19995417!1 X-Originating-IP: [209.85.217.170] X-SpamReason: No, hits=1.2 required=7.0 tests=HTML_20_30,HTML_MESSAGE, RCVD_BY_IP X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 5337 invoked from network); 13 Oct 2015 11:41:08 -0000 Received: from mail-lb0-f170.google.com (HELO mail-lb0-f170.google.com) (209.85.217.170) by server-11.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 13 Oct 2015 11:41:08 -0000 Received: by lbcao8 with SMTP id ao8so16351575lbc.3 for ; Tue, 13 Oct 2015 04:41:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=iWExZNeyqfKjFVgxciP+BmG/2pRp8mf7mwmafTQw9QI=; b=fQanj9l3rsyaseGAmZvg+OcelfOZdRoshOjMb1qGu2HLBbaVjWRMFyeWepMW4zpUY/ OCLv+Puin9v7Naz1TWTULoJCnoim2wgZzjwFop5hpMVJx5o130m09Dj5tjQR13gHn3iv ThW+xUBAh0razsDRkZUEs8iijg9CkgwfKAI5I48hmYnUzf3jK3OF+NyEVWzcQaEhhvT/ qC2hHbjKXbXezuNPmpkfJjkYhyOt5JdW86MCteF5Z80eHFZZUCp2f/KJta7FjqC8TGkG st/UUwj+CWn7PWsv/gFkjzWcoKMHhkrrgFw65JHxdNA5mUd90Kfvd4Hx4F2Ina8oLlO0 pHjQ== MIME-Version: 1.0 X-Received: by 10.112.140.197 with SMTP id ri5mr14834334lbb.65.1444736467807; Tue, 13 Oct 2015 04:41:07 -0700 (PDT) Received: by 10.112.119.134 with HTTP; Tue, 13 Oct 2015 04:41:07 -0700 (PDT) Date: Tue, 13 Oct 2015 19:41:07 +0800 Message-ID: From: yaozheng wang To: minios-devel@lists.xenproject.org X-Mailman-Approved-At: Tue, 13 Oct 2015 11:51:42 +0000 Subject: [Minios-devel] How to share a page between dom0 and minios? X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8164662011067588068==" Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org --===============8164662011067588068== Content-Type: multipart/alternative; boundary=001a11c25b46f535220521faeb50 --001a11c25b46f535220521faeb50 Content-Type: text/plain; charset=UTF-8 I am modifying the xl, When I execute * xl create -c domain_config*, I want to shared a new page between dom0 and minios.How can I do it? --001a11c25b46f535220521faeb50 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
=C2=A0I am modifying the xl, When I execute =C2=A0xl cr= eate -c domain_config, I want to shared a new page between dom0 and min= ios.How can I do it?


--001a11c25b46f535220521faeb50-- --===============8164662011067588068== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel --===============8164662011067588068==-- From minios-devel-bounces@lists.xenproject.org Tue Oct 13 11:51:44 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 13 Oct 2015 11:51:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zly7L-0006wg-8l; Tue, 13 Oct 2015 11:51:43 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZlxxD-0006Bz-BY for minios-devel@lists.xenproject.org; Tue, 13 Oct 2015 11:41:15 +0000 Received: from [85.158.137.68] by server-9.bemta-3.messagelabs.com id 9C/F4-10678-ADDEC165; Tue, 13 Oct 2015 11:41:14 +0000 X-Env-Sender: wyaozheng@gmail.com X-Msg-Ref: server-11.tower-31.messagelabs.com!1444736468!19995417!1 X-Originating-IP: [209.85.217.170] X-SpamReason: No, hits=1.2 required=7.0 tests=HTML_20_30,HTML_MESSAGE, RCVD_BY_IP X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 5337 invoked from network); 13 Oct 2015 11:41:08 -0000 Received: from mail-lb0-f170.google.com (HELO mail-lb0-f170.google.com) (209.85.217.170) by server-11.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 13 Oct 2015 11:41:08 -0000 Received: by lbcao8 with SMTP id ao8so16351575lbc.3 for ; Tue, 13 Oct 2015 04:41:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=iWExZNeyqfKjFVgxciP+BmG/2pRp8mf7mwmafTQw9QI=; b=fQanj9l3rsyaseGAmZvg+OcelfOZdRoshOjMb1qGu2HLBbaVjWRMFyeWepMW4zpUY/ OCLv+Puin9v7Naz1TWTULoJCnoim2wgZzjwFop5hpMVJx5o130m09Dj5tjQR13gHn3iv ThW+xUBAh0razsDRkZUEs8iijg9CkgwfKAI5I48hmYnUzf3jK3OF+NyEVWzcQaEhhvT/ qC2hHbjKXbXezuNPmpkfJjkYhyOt5JdW86MCteF5Z80eHFZZUCp2f/KJta7FjqC8TGkG st/UUwj+CWn7PWsv/gFkjzWcoKMHhkrrgFw65JHxdNA5mUd90Kfvd4Hx4F2Ina8oLlO0 pHjQ== MIME-Version: 1.0 X-Received: by 10.112.140.197 with SMTP id ri5mr14834334lbb.65.1444736467807; Tue, 13 Oct 2015 04:41:07 -0700 (PDT) Received: by 10.112.119.134 with HTTP; Tue, 13 Oct 2015 04:41:07 -0700 (PDT) Date: Tue, 13 Oct 2015 19:41:07 +0800 Message-ID: From: yaozheng wang To: minios-devel@lists.xenproject.org X-Mailman-Approved-At: Tue, 13 Oct 2015 11:51:42 +0000 Subject: [Minios-devel] How to share a page between dom0 and minios? X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8164662011067588068==" Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org --===============8164662011067588068== Content-Type: multipart/alternative; boundary=001a11c25b46f535220521faeb50 --001a11c25b46f535220521faeb50 Content-Type: text/plain; charset=UTF-8 I am modifying the xl, When I execute * xl create -c domain_config*, I want to shared a new page between dom0 and minios.How can I do it? --001a11c25b46f535220521faeb50 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
=C2=A0I am modifying the xl, When I execute =C2=A0xl cr= eate -c domain_config, I want to shared a new page between dom0 and min= ios.How can I do it?


--001a11c25b46f535220521faeb50-- --===============8164662011067588068== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel --===============8164662011067588068==-- From minios-devel-bounces@lists.xenproject.org Tue Oct 13 14:55:00 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 13 Oct 2015 14:55:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zm0yi-0007Up-On; Tue, 13 Oct 2015 14:55:00 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zm0yg-0007Uk-W2 for minios-devel@lists.xenproject.org; Tue, 13 Oct 2015 14:54:59 +0000 Received: from [85.158.137.68] by server-16.bemta-3.messagelabs.com id F2/6E-03763-24B1D165; Tue, 13 Oct 2015 14:54:58 +0000 X-Env-Sender: prvs=72153cbb0=wei.liu2@citrix.com X-Msg-Ref: server-5.tower-31.messagelabs.com!1444748096!52924081!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 7250 invoked from network); 13 Oct 2015 14:54:57 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-5.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 13 Oct 2015 14:54:57 -0000 X-IronPort-AV: E=Sophos;i="5.17,678,1437436800"; d="scan'208";a="306129311" Date: Tue, 13 Oct 2015 15:54:48 +0100 From: Wei Liu To: yaozheng wang Message-ID: <20151013145448.GD1940@zion.uk.xensource.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, wei.liu2@citrix.com Subject: Re: [Minios-devel] How to share a page between dom0 and minios? X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Tue, Oct 13, 2015 at 07:41:07PM +0800, yaozheng wang wrote: > I am modifying the xl, When I execute * xl create -c domain_config*, I > want to shared a new page between dom0 and minios.How can I do it? Presumably you want to give the other side access to a page. The canonical way of doing that is to use grant table to grant a page from one side to another, write the ref in xenstore. This can't be done without some code. Wei. > _______________________________________________ > Minios-devel mailing list > Minios-devel@lists.xenproject.org > http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Tue Oct 13 14:55:00 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 13 Oct 2015 14:55:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zm0yi-0007Up-On; Tue, 13 Oct 2015 14:55:00 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zm0yg-0007Uk-W2 for minios-devel@lists.xenproject.org; Tue, 13 Oct 2015 14:54:59 +0000 Received: from [85.158.137.68] by server-16.bemta-3.messagelabs.com id F2/6E-03763-24B1D165; Tue, 13 Oct 2015 14:54:58 +0000 X-Env-Sender: prvs=72153cbb0=wei.liu2@citrix.com X-Msg-Ref: server-5.tower-31.messagelabs.com!1444748096!52924081!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 7250 invoked from network); 13 Oct 2015 14:54:57 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-5.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 13 Oct 2015 14:54:57 -0000 X-IronPort-AV: E=Sophos;i="5.17,678,1437436800"; d="scan'208";a="306129311" Date: Tue, 13 Oct 2015 15:54:48 +0100 From: Wei Liu To: yaozheng wang Message-ID: <20151013145448.GD1940@zion.uk.xensource.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, wei.liu2@citrix.com Subject: Re: [Minios-devel] How to share a page between dom0 and minios? X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Tue, Oct 13, 2015 at 07:41:07PM +0800, yaozheng wang wrote: > I am modifying the xl, When I execute * xl create -c domain_config*, I > want to shared a new page between dom0 and minios.How can I do it? Presumably you want to give the other side access to a page. The canonical way of doing that is to use grant table to grant a page from one side to another, write the ref in xenstore. This can't be done without some code. Wei. > _______________________________________________ > Minios-devel mailing list > Minios-devel@lists.xenproject.org > http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Oct 21 15:22:37 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 21 Oct 2015 15:22:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZovDo-0001fd-9C; Wed, 21 Oct 2015 15:22:36 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZovDm-0001fT-RS for minios-devel@lists.xenproject.org; Wed, 21 Oct 2015 15:22:34 +0000 Received: from [85.158.139.211] by server-11.bemta-5.messagelabs.com id 75/F2-24494-ABDA7265; Wed, 21 Oct 2015 15:22:34 +0000 X-Env-Sender: prvs=72904509b=Ian.Campbell@citrix.com X-Msg-Ref: server-14.tower-206.messagelabs.com!1445440951!38613093!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 1547 invoked from network); 21 Oct 2015 15:22:33 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-14.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 21 Oct 2015 15:22:33 -0000 X-IronPort-AV: E=Sophos;i="5.17,712,1437436800"; d="scan'208";a="307977617" Message-ID: <1445440941.9563.163.camel@citrix.com> From: Ian Campbell To: xen-devel Date: Wed, 21 Oct 2015 16:22:21 +0100 X-Mailer: Evolution 3.16.5-1 MIME-Version: 1.0 X-DLP: MIA1 Cc: Wei Liu , Stefano Stabellini , Ian Jackson , qemu-devel@nongnu.org, minios-devel@lists.xenproject.org, samuel.thibault@ens-lyon.org, Roger Pau Monne Subject: [Minios-devel] [PATCH v4 0/] Begin to disentangle libxenctrl and provide some stable libraries X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org In <1431963008.4944.80.camel@citrix.com> I proposed stabilising some parts of the libxenctrl API/ABI by disaggregating into separate libraries. This is v4 of that set of series against: xen qemu-xen qemu-xen-traditional mini-os NB: Samuel+minios-devel will only get the mini-os side and Stefano+qemu -devel the qemu-xen side. The code in for all repos can be found in: git://xenbits.xen.org/people/ianc/libxenctrl-split/xen.git v4 git://xenbits.xen.org/people/ianc/libxenctrl-split/qemu-xen.git v4 git://xenbits.xen.org/people/ianc/libxenctrl-split/qemu-xen-traditional.git v4 git://xenbits.xen.org/people/ianc/libxenctrl-split/mini-os.git v4 The tip of the xen.git branch contains an extra patch hacking Config.mk to point to all the others above, which should get the correct things for the HEAD of the branch, but not further back in time. The new libraries here are: * libxentoollog: Common logging infrastructure * libxenevtchn: Userspace access to evtchns (via /dev/xen/evtchn etc) * libxengnttab: Userspace access to grant tables (via /dev/xen/gnt??? etc) * libxencall: Making hypercalls (i.e. the IOCTL_PRIVCMD_HYPERCALL type functionality) * libxenforeignmemory: Privileged mappings of foreign memory (IOCTL_PRIVCMD_MMAP et al) The first three were actually pretty distinct within libxenctrl already and have not changed in quite some time. Although the other two are somewhat new they are based on top of long standing stable ioctls, which gives me some confidence. Nonetheless I would appreciate extra review of at least the interface headers of all of these with a particular eye to the suitability of these interfaces being maintained in an ABI (_B_, not _P_) stable way going forward. Still to come would be libraries for specific out of tree purposes (device model, kexec), which would be adding new library at the same level as libxc I think, rather than underneath, i.e. also using the libraries split out here, but hopefully not libxenctrl itself. The new libraries use linker version-scripts to hopefully make future ABI changes be possible in a compatible way. Since last time I have: * Addressed various review comments: * Addressed feedback from Stefano on the qemu-xen series (and this version now goes to qemu-devel too) * Switched the foreign mapping interfaces to use size_t for the number of pages. * Fixed the callers of xenforeignmemory_unmap (should have been pages, but everywhere was passing bytes like the previous munmap case) * HACK patch in xen.git now updates Config.mk instead of .config The whole thing has been build tested on Linux (incl stubdoms), and on FreeBSD. I have runtime tested older versions on Linux but my test boxes are currently in some netherworld having been moved to a different colo. Neither NetBSD nor Solaris have been tested at all. It's certainly not impossible that I've not got the #includes in the new files quite right. http://xenbits.xen.org/people/ianc/libxenctrl-split/v4.html is the document I've been using to try and track what I'm doing. It may not be all that useful. The history of it is in the v4-with-doc branch of the xen.git linked to above. Ian. _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Oct 21 15:22:37 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 21 Oct 2015 15:22:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZovDo-0001fd-9C; Wed, 21 Oct 2015 15:22:36 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZovDm-0001fT-RS for minios-devel@lists.xenproject.org; Wed, 21 Oct 2015 15:22:34 +0000 Received: from [85.158.139.211] by server-11.bemta-5.messagelabs.com id 75/F2-24494-ABDA7265; Wed, 21 Oct 2015 15:22:34 +0000 X-Env-Sender: prvs=72904509b=Ian.Campbell@citrix.com X-Msg-Ref: server-14.tower-206.messagelabs.com!1445440951!38613093!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 1547 invoked from network); 21 Oct 2015 15:22:33 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-14.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 21 Oct 2015 15:22:33 -0000 X-IronPort-AV: E=Sophos;i="5.17,712,1437436800"; d="scan'208";a="307977617" Message-ID: <1445440941.9563.163.camel@citrix.com> From: Ian Campbell To: xen-devel Date: Wed, 21 Oct 2015 16:22:21 +0100 X-Mailer: Evolution 3.16.5-1 MIME-Version: 1.0 X-DLP: MIA1 Cc: Wei Liu , Stefano Stabellini , Ian Jackson , qemu-devel@nongnu.org, minios-devel@lists.xenproject.org, samuel.thibault@ens-lyon.org, Roger Pau Monne Subject: [Minios-devel] [PATCH v4 0/] Begin to disentangle libxenctrl and provide some stable libraries X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org In <1431963008.4944.80.camel@citrix.com> I proposed stabilising some parts of the libxenctrl API/ABI by disaggregating into separate libraries. This is v4 of that set of series against: xen qemu-xen qemu-xen-traditional mini-os NB: Samuel+minios-devel will only get the mini-os side and Stefano+qemu -devel the qemu-xen side. The code in for all repos can be found in: git://xenbits.xen.org/people/ianc/libxenctrl-split/xen.git v4 git://xenbits.xen.org/people/ianc/libxenctrl-split/qemu-xen.git v4 git://xenbits.xen.org/people/ianc/libxenctrl-split/qemu-xen-traditional.git v4 git://xenbits.xen.org/people/ianc/libxenctrl-split/mini-os.git v4 The tip of the xen.git branch contains an extra patch hacking Config.mk to point to all the others above, which should get the correct things for the HEAD of the branch, but not further back in time. The new libraries here are: * libxentoollog: Common logging infrastructure * libxenevtchn: Userspace access to evtchns (via /dev/xen/evtchn etc) * libxengnttab: Userspace access to grant tables (via /dev/xen/gnt??? etc) * libxencall: Making hypercalls (i.e. the IOCTL_PRIVCMD_HYPERCALL type functionality) * libxenforeignmemory: Privileged mappings of foreign memory (IOCTL_PRIVCMD_MMAP et al) The first three were actually pretty distinct within libxenctrl already and have not changed in quite some time. Although the other two are somewhat new they are based on top of long standing stable ioctls, which gives me some confidence. Nonetheless I would appreciate extra review of at least the interface headers of all of these with a particular eye to the suitability of these interfaces being maintained in an ABI (_B_, not _P_) stable way going forward. Still to come would be libraries for specific out of tree purposes (device model, kexec), which would be adding new library at the same level as libxc I think, rather than underneath, i.e. also using the libraries split out here, but hopefully not libxenctrl itself. The new libraries use linker version-scripts to hopefully make future ABI changes be possible in a compatible way. Since last time I have: * Addressed various review comments: * Addressed feedback from Stefano on the qemu-xen series (and this version now goes to qemu-devel too) * Switched the foreign mapping interfaces to use size_t for the number of pages. * Fixed the callers of xenforeignmemory_unmap (should have been pages, but everywhere was passing bytes like the previous munmap case) * HACK patch in xen.git now updates Config.mk instead of .config The whole thing has been build tested on Linux (incl stubdoms), and on FreeBSD. I have runtime tested older versions on Linux but my test boxes are currently in some netherworld having been moved to a different colo. Neither NetBSD nor Solaris have been tested at all. It's certainly not impossible that I've not got the #includes in the new files quite right. http://xenbits.xen.org/people/ianc/libxenctrl-split/v4.html is the document I've been using to try and track what I'm doing. It may not be all that useful. The history of it is in the v4-with-doc branch of the xen.git linked to above. Ian. _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Oct 21 15:24:38 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 21 Oct 2015 15:24:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZovFm-0003qa-ON; Wed, 21 Oct 2015 15:24:38 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZovFZ-0003Hl-Rq for minios-devel@lists.xenproject.org; Wed, 21 Oct 2015 15:24:25 +0000 Received: from [85.158.137.68] by server-3.bemta-3.messagelabs.com id 50/7B-01753-92EA7265; Wed, 21 Oct 2015 15:24:25 +0000 X-Env-Sender: prvs=72904509b=Ian.Campbell@citrix.com X-Msg-Ref: server-2.tower-31.messagelabs.com!1445441062!24202611!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 31607 invoked from network); 21 Oct 2015 15:24:24 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-2.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 21 Oct 2015 15:24:24 -0000 X-IronPort-AV: E=Sophos;i="5.17,712,1437436800"; d="scan'208";a="307978239" From: Ian Campbell To: , , Date: Wed, 21 Oct 2015 16:24:14 +0100 Message-ID: <1445441059-26083-1-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1445440941.9563.163.camel@citrix.com> References: <1445440941.9563.163.camel@citrix.com> MIME-Version: 1.0 X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, samuel.thibault@ens-lyon.org, Ian Campbell Subject: [Minios-devel] [PATCH MINI-OS v4 0/5] Begin to disentangle libxenctrl and provide some stable libraries X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org We intend to stabilise some parts of the libxenctrl interface by splitting out some functionality into separate stable libraries. This is the mini-os part of the first phase of that change. This mail is (or is intended to be) a reply to a "0/" super-intro mail covering all of the related patch series and which contains more details. Ian Campbell (5): mini-os: Include libxentoollog with libxc mini-os: Include libxenevtchn with libxc mini-os: Include libxengnttab with libxc mini-os: Include libxencall with libxc mini-os: Include libxenforeignmemory with libxc Makefile | 5 +++++ 1 file changed, 5 insertions(+) -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Oct 21 15:24:38 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 21 Oct 2015 15:24:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZovFm-0003qa-ON; Wed, 21 Oct 2015 15:24:38 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZovFZ-0003Hl-Rq for minios-devel@lists.xenproject.org; Wed, 21 Oct 2015 15:24:25 +0000 Received: from [85.158.137.68] by server-3.bemta-3.messagelabs.com id 50/7B-01753-92EA7265; Wed, 21 Oct 2015 15:24:25 +0000 X-Env-Sender: prvs=72904509b=Ian.Campbell@citrix.com X-Msg-Ref: server-2.tower-31.messagelabs.com!1445441062!24202611!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 31607 invoked from network); 21 Oct 2015 15:24:24 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-2.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 21 Oct 2015 15:24:24 -0000 X-IronPort-AV: E=Sophos;i="5.17,712,1437436800"; d="scan'208";a="307978239" From: Ian Campbell To: , , Date: Wed, 21 Oct 2015 16:24:14 +0100 Message-ID: <1445441059-26083-1-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1445440941.9563.163.camel@citrix.com> References: <1445440941.9563.163.camel@citrix.com> MIME-Version: 1.0 X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, samuel.thibault@ens-lyon.org, Ian Campbell Subject: [Minios-devel] [PATCH MINI-OS v4 0/5] Begin to disentangle libxenctrl and provide some stable libraries X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org We intend to stabilise some parts of the libxenctrl interface by splitting out some functionality into separate stable libraries. This is the mini-os part of the first phase of that change. This mail is (or is intended to be) a reply to a "0/" super-intro mail covering all of the related patch series and which contains more details. Ian Campbell (5): mini-os: Include libxentoollog with libxc mini-os: Include libxenevtchn with libxc mini-os: Include libxengnttab with libxc mini-os: Include libxencall with libxc mini-os: Include libxenforeignmemory with libxc Makefile | 5 +++++ 1 file changed, 5 insertions(+) -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Oct 21 15:24:39 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 21 Oct 2015 15:24:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZovFn-0003r1-5J; Wed, 21 Oct 2015 15:24:39 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZovFZ-0003Hx-Ry for minios-devel@lists.xenproject.org; Wed, 21 Oct 2015 15:24:25 +0000 Received: from [85.158.139.211] by server-7.bemta-5.messagelabs.com id 63/74-13905-92EA7265; Wed, 21 Oct 2015 15:24:25 +0000 X-Env-Sender: prvs=72904509b=Ian.Campbell@citrix.com X-Msg-Ref: server-9.tower-206.messagelabs.com!1445441063!44004687!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 19265 invoked from network); 21 Oct 2015 15:24:24 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-9.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 21 Oct 2015 15:24:24 -0000 X-IronPort-AV: E=Sophos;i="5.17,712,1437436800"; d="scan'208";a="311941013" From: Ian Campbell To: , , Date: Wed, 21 Oct 2015 16:24:15 +0100 Message-ID: <1445441059-26083-2-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1445441059-26083-1-git-send-email-ian.campbell@citrix.com> References: <1445440941.9563.163.camel@citrix.com> <1445441059-26083-1-git-send-email-ian.campbell@citrix.com> MIME-Version: 1.0 X-DLP: MIA1 Cc: minios-devel@lists.xenproject.org, samuel.thibault@ens-lyon.org, Ian Campbell Subject: [Minios-devel] [PATCH MINI-OS v4 1/5] mini-os: Include libxentoollog with libxc X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org libxentoollog has just been split out from libxc. From mini-os's point of view we don't care about the distinction, so keep things simple by just including libxentoollog if libxc is enabled. Signed-off-by: Ian Campbell --- v2: Adjust for libs/$lib layout. --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 2cb5e51..daee46c 100644 --- a/Makefile +++ b/Makefile @@ -165,6 +165,7 @@ OBJS := $(filter-out $(OBJ_DIR)/lwip%.o $(LWO), $(OBJS)) ifeq ($(libc),y) ifeq ($(CONFIG_XC),y) +APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/toollog -whole-archive -lxentoollog -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxc-$(MINIOS_TARGET_ARCH) -whole-archive -lxenguest -lxenctrl -no-whole-archive endif APP_LDLIBS += -lpci -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Oct 21 15:24:39 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 21 Oct 2015 15:24:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZovFn-0003r1-5J; Wed, 21 Oct 2015 15:24:39 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZovFZ-0003Hx-Ry for minios-devel@lists.xenproject.org; Wed, 21 Oct 2015 15:24:25 +0000 Received: from [85.158.139.211] by server-7.bemta-5.messagelabs.com id 63/74-13905-92EA7265; Wed, 21 Oct 2015 15:24:25 +0000 X-Env-Sender: prvs=72904509b=Ian.Campbell@citrix.com X-Msg-Ref: server-9.tower-206.messagelabs.com!1445441063!44004687!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 19265 invoked from network); 21 Oct 2015 15:24:24 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-9.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 21 Oct 2015 15:24:24 -0000 X-IronPort-AV: E=Sophos;i="5.17,712,1437436800"; d="scan'208";a="311941013" From: Ian Campbell To: , , Date: Wed, 21 Oct 2015 16:24:15 +0100 Message-ID: <1445441059-26083-2-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1445441059-26083-1-git-send-email-ian.campbell@citrix.com> References: <1445440941.9563.163.camel@citrix.com> <1445441059-26083-1-git-send-email-ian.campbell@citrix.com> MIME-Version: 1.0 X-DLP: MIA1 Cc: minios-devel@lists.xenproject.org, samuel.thibault@ens-lyon.org, Ian Campbell Subject: [Minios-devel] [PATCH MINI-OS v4 1/5] mini-os: Include libxentoollog with libxc X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org libxentoollog has just been split out from libxc. From mini-os's point of view we don't care about the distinction, so keep things simple by just including libxentoollog if libxc is enabled. Signed-off-by: Ian Campbell --- v2: Adjust for libs/$lib layout. --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 2cb5e51..daee46c 100644 --- a/Makefile +++ b/Makefile @@ -165,6 +165,7 @@ OBJS := $(filter-out $(OBJ_DIR)/lwip%.o $(LWO), $(OBJS)) ifeq ($(libc),y) ifeq ($(CONFIG_XC),y) +APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/toollog -whole-archive -lxentoollog -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxc-$(MINIOS_TARGET_ARCH) -whole-archive -lxenguest -lxenctrl -no-whole-archive endif APP_LDLIBS += -lpci -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Oct 21 15:24:43 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 21 Oct 2015 15:24:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZovFq-0003zk-Ky; Wed, 21 Oct 2015 15:24:42 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZovFa-0003K5-KZ for minios-devel@lists.xenproject.org; Wed, 21 Oct 2015 15:24:26 +0000 Received: from [85.158.139.211] by server-4.bemta-5.messagelabs.com id 26/29-24856-92EA7265; Wed, 21 Oct 2015 15:24:25 +0000 X-Env-Sender: prvs=72904509b=Ian.Campbell@citrix.com X-Msg-Ref: server-9.tower-206.messagelabs.com!1445441063!44004687!2 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 19379 invoked from network); 21 Oct 2015 15:24:25 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-9.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 21 Oct 2015 15:24:25 -0000 X-IronPort-AV: E=Sophos;i="5.17,712,1437436800"; d="scan'208";a="311941021" From: Ian Campbell To: , , Date: Wed, 21 Oct 2015 16:24:16 +0100 Message-ID: <1445441059-26083-3-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1445441059-26083-1-git-send-email-ian.campbell@citrix.com> References: <1445440941.9563.163.camel@citrix.com> <1445441059-26083-1-git-send-email-ian.campbell@citrix.com> MIME-Version: 1.0 X-DLP: MIA1 Cc: minios-devel@lists.xenproject.org, samuel.thibault@ens-lyon.org, Ian Campbell Subject: [Minios-devel] [PATCH MINI-OS v4 2/5] mini-os: Include libxenevtchn with libxc X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org libxenevtchn has just been split out from libxc. From mini-os's point of view we don't care about the distinction, so keep things simple by just including libxenevtchn if libxc is enabled. Signed-off-by: Ian Campbell --- v2: Adjust for libs/$lib layout. --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index daee46c..d1d8dc4 100644 --- a/Makefile +++ b/Makefile @@ -166,6 +166,7 @@ OBJS := $(filter-out $(OBJ_DIR)/lwip%.o $(LWO), $(OBJS)) ifeq ($(libc),y) ifeq ($(CONFIG_XC),y) APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/toollog -whole-archive -lxentoollog -no-whole-archive +APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/evtchn -whole-archive -lxenevtchn -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxc-$(MINIOS_TARGET_ARCH) -whole-archive -lxenguest -lxenctrl -no-whole-archive endif APP_LDLIBS += -lpci -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Oct 21 15:24:43 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 21 Oct 2015 15:24:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZovFq-0003zk-Ky; Wed, 21 Oct 2015 15:24:42 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZovFa-0003K5-KZ for minios-devel@lists.xenproject.org; Wed, 21 Oct 2015 15:24:26 +0000 Received: from [85.158.139.211] by server-4.bemta-5.messagelabs.com id 26/29-24856-92EA7265; Wed, 21 Oct 2015 15:24:25 +0000 X-Env-Sender: prvs=72904509b=Ian.Campbell@citrix.com X-Msg-Ref: server-9.tower-206.messagelabs.com!1445441063!44004687!2 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 19379 invoked from network); 21 Oct 2015 15:24:25 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-9.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 21 Oct 2015 15:24:25 -0000 X-IronPort-AV: E=Sophos;i="5.17,712,1437436800"; d="scan'208";a="311941021" From: Ian Campbell To: , , Date: Wed, 21 Oct 2015 16:24:16 +0100 Message-ID: <1445441059-26083-3-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1445441059-26083-1-git-send-email-ian.campbell@citrix.com> References: <1445440941.9563.163.camel@citrix.com> <1445441059-26083-1-git-send-email-ian.campbell@citrix.com> MIME-Version: 1.0 X-DLP: MIA1 Cc: minios-devel@lists.xenproject.org, samuel.thibault@ens-lyon.org, Ian Campbell Subject: [Minios-devel] [PATCH MINI-OS v4 2/5] mini-os: Include libxenevtchn with libxc X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org libxenevtchn has just been split out from libxc. From mini-os's point of view we don't care about the distinction, so keep things simple by just including libxenevtchn if libxc is enabled. Signed-off-by: Ian Campbell --- v2: Adjust for libs/$lib layout. --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index daee46c..d1d8dc4 100644 --- a/Makefile +++ b/Makefile @@ -166,6 +166,7 @@ OBJS := $(filter-out $(OBJ_DIR)/lwip%.o $(LWO), $(OBJS)) ifeq ($(libc),y) ifeq ($(CONFIG_XC),y) APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/toollog -whole-archive -lxentoollog -no-whole-archive +APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/evtchn -whole-archive -lxenevtchn -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxc-$(MINIOS_TARGET_ARCH) -whole-archive -lxenguest -lxenctrl -no-whole-archive endif APP_LDLIBS += -lpci -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Oct 21 15:24:45 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 21 Oct 2015 15:24:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZovFt-00047S-FL; Wed, 21 Oct 2015 15:24:45 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZovFb-0003LF-3f for minios-devel@lists.xenproject.org; Wed, 21 Oct 2015 15:24:27 +0000 Received: from [85.158.137.68] by server-12.bemta-3.messagelabs.com id E8/C3-05269-A2EA7265; Wed, 21 Oct 2015 15:24:26 +0000 X-Env-Sender: prvs=72904509b=Ian.Campbell@citrix.com X-Msg-Ref: server-2.tower-31.messagelabs.com!1445441062!24202611!2 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 32196 invoked from network); 21 Oct 2015 15:24:25 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-2.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 21 Oct 2015 15:24:25 -0000 X-IronPort-AV: E=Sophos;i="5.17,712,1437436800"; d="scan'208";a="307978275" From: Ian Campbell To: , , Date: Wed, 21 Oct 2015 16:24:17 +0100 Message-ID: <1445441059-26083-4-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1445441059-26083-1-git-send-email-ian.campbell@citrix.com> References: <1445440941.9563.163.camel@citrix.com> <1445441059-26083-1-git-send-email-ian.campbell@citrix.com> MIME-Version: 1.0 X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, samuel.thibault@ens-lyon.org, Ian Campbell Subject: [Minios-devel] [PATCH MINI-OS v4 3/5] mini-os: Include libxengnttab with libxc X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org libxengnttab has just been split out from libxc. From mini-os's point of view we don't care about the distinction, so keep things simple by just including libxengnttab if libxc is enabled. Signed-off-by: Ian Campbell --- v2: Adjust for libs/$lib layout. --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index d1d8dc4..521f647 100644 --- a/Makefile +++ b/Makefile @@ -167,6 +167,7 @@ ifeq ($(libc),y) ifeq ($(CONFIG_XC),y) APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/toollog -whole-archive -lxentoollog -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/evtchn -whole-archive -lxenevtchn -no-whole-archive +APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/gnttab -whole-archive -lxengnttab -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxc-$(MINIOS_TARGET_ARCH) -whole-archive -lxenguest -lxenctrl -no-whole-archive endif APP_LDLIBS += -lpci -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Oct 21 15:24:45 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 21 Oct 2015 15:24:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZovFt-00047S-FL; Wed, 21 Oct 2015 15:24:45 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZovFb-0003LF-3f for minios-devel@lists.xenproject.org; Wed, 21 Oct 2015 15:24:27 +0000 Received: from [85.158.137.68] by server-12.bemta-3.messagelabs.com id E8/C3-05269-A2EA7265; Wed, 21 Oct 2015 15:24:26 +0000 X-Env-Sender: prvs=72904509b=Ian.Campbell@citrix.com X-Msg-Ref: server-2.tower-31.messagelabs.com!1445441062!24202611!2 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 32196 invoked from network); 21 Oct 2015 15:24:25 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-2.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 21 Oct 2015 15:24:25 -0000 X-IronPort-AV: E=Sophos;i="5.17,712,1437436800"; d="scan'208";a="307978275" From: Ian Campbell To: , , Date: Wed, 21 Oct 2015 16:24:17 +0100 Message-ID: <1445441059-26083-4-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1445441059-26083-1-git-send-email-ian.campbell@citrix.com> References: <1445440941.9563.163.camel@citrix.com> <1445441059-26083-1-git-send-email-ian.campbell@citrix.com> MIME-Version: 1.0 X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, samuel.thibault@ens-lyon.org, Ian Campbell Subject: [Minios-devel] [PATCH MINI-OS v4 3/5] mini-os: Include libxengnttab with libxc X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org libxengnttab has just been split out from libxc. From mini-os's point of view we don't care about the distinction, so keep things simple by just including libxengnttab if libxc is enabled. Signed-off-by: Ian Campbell --- v2: Adjust for libs/$lib layout. --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index d1d8dc4..521f647 100644 --- a/Makefile +++ b/Makefile @@ -167,6 +167,7 @@ ifeq ($(libc),y) ifeq ($(CONFIG_XC),y) APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/toollog -whole-archive -lxentoollog -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/evtchn -whole-archive -lxenevtchn -no-whole-archive +APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/gnttab -whole-archive -lxengnttab -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxc-$(MINIOS_TARGET_ARCH) -whole-archive -lxenguest -lxenctrl -no-whole-archive endif APP_LDLIBS += -lpci -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Oct 21 15:24:49 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 21 Oct 2015 15:24:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZovFx-0004Ik-MD; Wed, 21 Oct 2015 15:24:49 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZovFd-0003RT-Gm for minios-devel@lists.xenproject.org; Wed, 21 Oct 2015 15:24:29 +0000 Received: from [193.109.254.147] by server-9.bemta-14.messagelabs.com id 26/22-26043-C2EA7265; Wed, 21 Oct 2015 15:24:28 +0000 X-Env-Sender: prvs=72904509b=Ian.Campbell@citrix.com X-Msg-Ref: server-2.tower-27.messagelabs.com!1445441066!24301819!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 29611 invoked from network); 21 Oct 2015 15:24:28 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-2.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 21 Oct 2015 15:24:28 -0000 X-IronPort-AV: E=Sophos;i="5.17,712,1437436800"; d="scan'208";a="311941034" From: Ian Campbell To: , , Date: Wed, 21 Oct 2015 16:24:18 +0100 Message-ID: <1445441059-26083-5-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1445441059-26083-1-git-send-email-ian.campbell@citrix.com> References: <1445440941.9563.163.camel@citrix.com> <1445441059-26083-1-git-send-email-ian.campbell@citrix.com> MIME-Version: 1.0 X-DLP: MIA1 Cc: minios-devel@lists.xenproject.org, samuel.thibault@ens-lyon.org, Ian Campbell Subject: [Minios-devel] [PATCH MINI-OS v4 4/5] mini-os: Include libxencall with libxc X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org libxencall has just been split out from libxc. From mini-os's point of view we don't care about the distinction, so keep things simple by just including libxencall if libxc is enabled. Signed-off-by: Ian Campbell --- v2: Adjust for libs/$lib layout. --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 521f647..c900540 100644 --- a/Makefile +++ b/Makefile @@ -168,6 +168,7 @@ ifeq ($(CONFIG_XC),y) APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/toollog -whole-archive -lxentoollog -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/evtchn -whole-archive -lxenevtchn -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/gnttab -whole-archive -lxengnttab -no-whole-archive +APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/call -whole-archive -lxencall -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxc-$(MINIOS_TARGET_ARCH) -whole-archive -lxenguest -lxenctrl -no-whole-archive endif APP_LDLIBS += -lpci -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Oct 21 15:24:49 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 21 Oct 2015 15:24:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZovFx-0004Ik-MD; Wed, 21 Oct 2015 15:24:49 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZovFd-0003RT-Gm for minios-devel@lists.xenproject.org; Wed, 21 Oct 2015 15:24:29 +0000 Received: from [193.109.254.147] by server-9.bemta-14.messagelabs.com id 26/22-26043-C2EA7265; Wed, 21 Oct 2015 15:24:28 +0000 X-Env-Sender: prvs=72904509b=Ian.Campbell@citrix.com X-Msg-Ref: server-2.tower-27.messagelabs.com!1445441066!24301819!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 29611 invoked from network); 21 Oct 2015 15:24:28 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-2.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 21 Oct 2015 15:24:28 -0000 X-IronPort-AV: E=Sophos;i="5.17,712,1437436800"; d="scan'208";a="311941034" From: Ian Campbell To: , , Date: Wed, 21 Oct 2015 16:24:18 +0100 Message-ID: <1445441059-26083-5-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1445441059-26083-1-git-send-email-ian.campbell@citrix.com> References: <1445440941.9563.163.camel@citrix.com> <1445441059-26083-1-git-send-email-ian.campbell@citrix.com> MIME-Version: 1.0 X-DLP: MIA1 Cc: minios-devel@lists.xenproject.org, samuel.thibault@ens-lyon.org, Ian Campbell Subject: [Minios-devel] [PATCH MINI-OS v4 4/5] mini-os: Include libxencall with libxc X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org libxencall has just been split out from libxc. From mini-os's point of view we don't care about the distinction, so keep things simple by just including libxencall if libxc is enabled. Signed-off-by: Ian Campbell --- v2: Adjust for libs/$lib layout. --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 521f647..c900540 100644 --- a/Makefile +++ b/Makefile @@ -168,6 +168,7 @@ ifeq ($(CONFIG_XC),y) APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/toollog -whole-archive -lxentoollog -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/evtchn -whole-archive -lxenevtchn -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/gnttab -whole-archive -lxengnttab -no-whole-archive +APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/call -whole-archive -lxencall -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxc-$(MINIOS_TARGET_ARCH) -whole-archive -lxenguest -lxenctrl -no-whole-archive endif APP_LDLIBS += -lpci -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Oct 21 15:24:49 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 21 Oct 2015 15:24:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZovFx-0004Hg-Dl; Wed, 21 Oct 2015 15:24:49 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZovFd-0003Qe-Fj for minios-devel@lists.xenproject.org; Wed, 21 Oct 2015 15:24:29 +0000 Received: from [85.158.137.68] by server-16.bemta-3.messagelabs.com id 92/68-03763-C2EA7265; Wed, 21 Oct 2015 15:24:28 +0000 X-Env-Sender: prvs=72904509b=Ian.Campbell@citrix.com X-Msg-Ref: server-2.tower-31.messagelabs.com!1445441062!24202611!3 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 32559 invoked from network); 21 Oct 2015 15:24:27 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-2.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 21 Oct 2015 15:24:27 -0000 X-IronPort-AV: E=Sophos;i="5.17,712,1437436800"; d="scan'208";a="307978287" From: Ian Campbell To: , , Date: Wed, 21 Oct 2015 16:24:19 +0100 Message-ID: <1445441059-26083-6-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1445441059-26083-1-git-send-email-ian.campbell@citrix.com> References: <1445440941.9563.163.camel@citrix.com> <1445441059-26083-1-git-send-email-ian.campbell@citrix.com> MIME-Version: 1.0 X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, samuel.thibault@ens-lyon.org, Ian Campbell Subject: [Minios-devel] [PATCH MINI-OS v4 5/5] mini-os: Include libxenforeignmemory with libxc X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org libxenforeignmemory has just been split out from libxc. From mini-os's point of view we don't care about the distinction, so keep things simple by just including libxenforeignmemory if libxc is enabled. Signed-off-by: Ian Campbell --- v2: Adjust for libs/$lib layout. --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index c900540..cfe015a 100644 --- a/Makefile +++ b/Makefile @@ -169,6 +169,7 @@ APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/toollog -whole-ar APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/evtchn -whole-archive -lxenevtchn -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/gnttab -whole-archive -lxengnttab -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/call -whole-archive -lxencall -no-whole-archive +APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/foreignmemory -whole-archive -lxenforeignmemory -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxc-$(MINIOS_TARGET_ARCH) -whole-archive -lxenguest -lxenctrl -no-whole-archive endif APP_LDLIBS += -lpci -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Wed Oct 21 15:24:49 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 21 Oct 2015 15:24:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZovFx-0004Hg-Dl; Wed, 21 Oct 2015 15:24:49 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZovFd-0003Qe-Fj for minios-devel@lists.xenproject.org; Wed, 21 Oct 2015 15:24:29 +0000 Received: from [85.158.137.68] by server-16.bemta-3.messagelabs.com id 92/68-03763-C2EA7265; Wed, 21 Oct 2015 15:24:28 +0000 X-Env-Sender: prvs=72904509b=Ian.Campbell@citrix.com X-Msg-Ref: server-2.tower-31.messagelabs.com!1445441062!24202611!3 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 32559 invoked from network); 21 Oct 2015 15:24:27 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-2.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 21 Oct 2015 15:24:27 -0000 X-IronPort-AV: E=Sophos;i="5.17,712,1437436800"; d="scan'208";a="307978287" From: Ian Campbell To: , , Date: Wed, 21 Oct 2015 16:24:19 +0100 Message-ID: <1445441059-26083-6-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1445441059-26083-1-git-send-email-ian.campbell@citrix.com> References: <1445440941.9563.163.camel@citrix.com> <1445441059-26083-1-git-send-email-ian.campbell@citrix.com> MIME-Version: 1.0 X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, samuel.thibault@ens-lyon.org, Ian Campbell Subject: [Minios-devel] [PATCH MINI-OS v4 5/5] mini-os: Include libxenforeignmemory with libxc X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org libxenforeignmemory has just been split out from libxc. From mini-os's point of view we don't care about the distinction, so keep things simple by just including libxenforeignmemory if libxc is enabled. Signed-off-by: Ian Campbell --- v2: Adjust for libs/$lib layout. --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index c900540..cfe015a 100644 --- a/Makefile +++ b/Makefile @@ -169,6 +169,7 @@ APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/toollog -whole-ar APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/evtchn -whole-archive -lxenevtchn -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/gnttab -whole-archive -lxengnttab -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/call -whole-archive -lxencall -no-whole-archive +APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libs-$(MINIOS_TARGET_ARCH)/foreignmemory -whole-archive -lxenforeignmemory -no-whole-archive APP_LDLIBS += -L$(XEN_ROOT)/stubdom/libxc-$(MINIOS_TARGET_ARCH) -whole-archive -lxenguest -lxenctrl -no-whole-archive endif APP_LDLIBS += -lpci -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Thu Oct 22 15:20:59 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 22 Oct 2015 15:20:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZpHfm-0002Xk-6K; Thu, 22 Oct 2015 15:20:58 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZpHfl-0002Xc-Ey for minios-devel@lists.xenproject.org; Thu, 22 Oct 2015 15:20:57 +0000 Received: from [85.158.139.211] by server-12.bemta-5.messagelabs.com id B1/3C-19220-8DEF8265; Thu, 22 Oct 2015 15:20:56 +0000 X-Env-Sender: chengfeizh@gmail.com X-Msg-Ref: server-14.tower-206.messagelabs.com!1445527255!38931544!1 X-Originating-IP: [209.85.214.182] X-SpamReason: No, hits=0.9 required=7.0 tests=HTML_20_30,HTML_MESSAGE X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 5413 invoked from network); 22 Oct 2015 15:20:56 -0000 Received: from mail-ob0-f182.google.com (HELO mail-ob0-f182.google.com) (209.85.214.182) by server-14.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 22 Oct 2015 15:20:56 -0000 Received: by obctp1 with SMTP id tp1so43495727obc.2 for ; Thu, 22 Oct 2015 08:20:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:content-type; bh=ilCEobWqBiT3BsQjxiWbIS2NdqBqc7ZB1lGBrHldL4A=; b=sVpQYj/hIfSJfIlE76WEse4CJrCPdQKGh0Su7qtE6Eo3h8T2fnYlfk0TBExwrQLuUv zp9zf07cUq+E43thYiymxeU3Sz2/VpdShBPSKTEek7oDx98JewdAsJIVyb47sfUGYgwp JGHF2tvAVsOCDQl1YALH09/G1QLyUWCJhfLJu7JCpF9bcO5rFItFE28CNj0pN5xELDXS bUQH6VUxIJqM/VJCUpgZUqZywbu256FeJ1atHVytNjFKIJRNay+g4PLLLPCfTXc/PNT5 zogGZQOs9JsVnvlswLqYCZ2qg18wAwbDxq+2G01tWZ919GusJKKaNQscyYCHTFMtUpaX CLuQ== X-Received: by 10.182.128.232 with SMTP id nr8mr10751769obb.8.1445527255074; Thu, 22 Oct 2015 08:20:55 -0700 (PDT) MIME-Version: 1.0 From: zhang chengfei Date: Thu, 22 Oct 2015 15:20:45 +0000 Message-ID: To: "minios-devel@lists.xenproject.org" Subject: [Minios-devel] How to modify the network bandwidth of minios? X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3848841755719721499==" Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org --===============3848841755719721499== Content-Type: multipart/alternative; boundary=089e014948d48d4f640522b30a3f --089e014948d48d4f640522b30a3f Content-Type: text/plain; charset=UTF-8 I have implemented a redis client, I want to test the writing bandwidth of minios, I got the result about 10MB/s.How can I improve the bandwidth limit ? Thanks ! --089e014948d48d4f640522b30a3f Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
=C2=A0 =C2=A0 I have implemented a redis client, I want to= test the writing bandwidth of minios, I got the result about 10MB/s.How ca= n I improve the bandwidth limit ?=C2=A0
=C2=A0 =C2=A0 Thanks !
=
--089e014948d48d4f640522b30a3f-- --===============3848841755719721499== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel --===============3848841755719721499==-- From minios-devel-bounces@lists.xenproject.org Thu Oct 22 15:20:59 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 22 Oct 2015 15:20:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZpHfm-0002Xk-6K; Thu, 22 Oct 2015 15:20:58 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZpHfl-0002Xc-Ey for minios-devel@lists.xenproject.org; Thu, 22 Oct 2015 15:20:57 +0000 Received: from [85.158.139.211] by server-12.bemta-5.messagelabs.com id B1/3C-19220-8DEF8265; Thu, 22 Oct 2015 15:20:56 +0000 X-Env-Sender: chengfeizh@gmail.com X-Msg-Ref: server-14.tower-206.messagelabs.com!1445527255!38931544!1 X-Originating-IP: [209.85.214.182] X-SpamReason: No, hits=0.9 required=7.0 tests=HTML_20_30,HTML_MESSAGE X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 5413 invoked from network); 22 Oct 2015 15:20:56 -0000 Received: from mail-ob0-f182.google.com (HELO mail-ob0-f182.google.com) (209.85.214.182) by server-14.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 22 Oct 2015 15:20:56 -0000 Received: by obctp1 with SMTP id tp1so43495727obc.2 for ; Thu, 22 Oct 2015 08:20:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:content-type; bh=ilCEobWqBiT3BsQjxiWbIS2NdqBqc7ZB1lGBrHldL4A=; b=sVpQYj/hIfSJfIlE76WEse4CJrCPdQKGh0Su7qtE6Eo3h8T2fnYlfk0TBExwrQLuUv zp9zf07cUq+E43thYiymxeU3Sz2/VpdShBPSKTEek7oDx98JewdAsJIVyb47sfUGYgwp JGHF2tvAVsOCDQl1YALH09/G1QLyUWCJhfLJu7JCpF9bcO5rFItFE28CNj0pN5xELDXS bUQH6VUxIJqM/VJCUpgZUqZywbu256FeJ1atHVytNjFKIJRNay+g4PLLLPCfTXc/PNT5 zogGZQOs9JsVnvlswLqYCZ2qg18wAwbDxq+2G01tWZ919GusJKKaNQscyYCHTFMtUpaX CLuQ== X-Received: by 10.182.128.232 with SMTP id nr8mr10751769obb.8.1445527255074; Thu, 22 Oct 2015 08:20:55 -0700 (PDT) MIME-Version: 1.0 From: zhang chengfei Date: Thu, 22 Oct 2015 15:20:45 +0000 Message-ID: To: "minios-devel@lists.xenproject.org" Subject: [Minios-devel] How to modify the network bandwidth of minios? X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3848841755719721499==" Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org --===============3848841755719721499== Content-Type: multipart/alternative; boundary=089e014948d48d4f640522b30a3f --089e014948d48d4f640522b30a3f Content-Type: text/plain; charset=UTF-8 I have implemented a redis client, I want to test the writing bandwidth of minios, I got the result about 10MB/s.How can I improve the bandwidth limit ? Thanks ! --089e014948d48d4f640522b30a3f Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
=C2=A0 =C2=A0 I have implemented a redis client, I want to= test the writing bandwidth of minios, I got the result about 10MB/s.How ca= n I improve the bandwidth limit ?=C2=A0
=C2=A0 =C2=A0 Thanks !
=
--089e014948d48d4f640522b30a3f-- --===============3848841755719721499== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel --===============3848841755719721499==-- From minios-devel-bounces@lists.xenproject.org Thu Oct 22 20:43:08 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 22 Oct 2015 20:43:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZpMhW-0003hn-S8; Thu, 22 Oct 2015 20:43:06 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZpMhV-0003hi-Pv for minios-devel@lists.xenproject.org; Thu, 22 Oct 2015 20:43:05 +0000 Received: from [193.109.254.147] by server-15.bemta-14.messagelabs.com id 56/3C-18886-95A49265; Thu, 22 Oct 2015 20:43:05 +0000 X-Env-Sender: SRS0=+plG=K2=ens-lyon.org=samuel.thibault@bounce.ens-lyon.o rg X-Msg-Ref: server-3.tower-27.messagelabs.com!1445546580!60656354!1 X-Originating-IP: [140.77.166.138] X-SpamReason: No, hits=0.2 required=7.0 tests=RCVD_ILLEGAL_IP X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 25606 invoked from network); 22 Oct 2015 20:43:00 -0000 Received: from domu-toccata.ens-lyon.fr (HELO sonata.ens-lyon.org) (140.77.166.138) by server-3.tower-27.messagelabs.com with DHE-RSA-AES256-SHA encrypted SMTP; 22 Oct 2015 20:43:00 -0000 Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 2FBCB200CE; Thu, 22 Oct 2015 22:43:00 +0200 (CEST) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xPyGQ2aq2oWG; Thu, 22 Oct 2015 22:43:00 +0200 (CEST) Received: from var.ipv6 (ABordeaux-652-1-135-46.w2-6.abo.wanadoo.fr [2.6.118.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 7A666200C7; Thu, 22 Oct 2015 22:42:59 +0200 (CEST) Received: from samy by var.ipv6 with local (Exim 4.86) (envelope-from ) id 1ZpMhO-0008EW-Hr; Thu, 22 Oct 2015 22:42:58 +0200 Date: Thu, 22 Oct 2015 22:42:58 +0200 From: Samuel Thibault To: Ian Campbell Message-ID: <20151022204258.GX10915@var.home> Mail-Followup-To: Samuel Thibault , Ian Campbell , ian.jackson@eu.citrix.com, wei.liu2@citrix.com, xen-devel@lists.xen.org, minios-devel@lists.xenproject.org References: <1445440941.9563.163.camel@citrix.com> <1445441059-26083-1-git-send-email-ian.campbell@citrix.com> MIME-Version: 1.0 Content-Length: 957 Content-Disposition: inline In-Reply-To: <1445441059-26083-1-git-send-email-ian.campbell@citrix.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Cc: minios-devel@lists.xenproject.org, wei.liu2@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org Subject: Re: [Minios-devel] [PATCH MINI-OS v4 0/5] Begin to disentangle libxenctrl and provide some stable libraries X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Ian Campbell, le Wed 21 Oct 2015 16:24:14 +0100, a =E9crit : > We intend to stabilise some parts of the libxenctrl interface by > splitting out some functionality into separate stable libraries. > = > This is the mini-os part of the first phase of that change. > = > This mail is (or is intended to be) a reply to a "0/" > super-intro mail covering all of the related patch series and which > contains more details. > = > Ian Campbell (5): > mini-os: Include libxentoollog with libxc > mini-os: Include libxenevtchn with libxc > mini-os: Include libxengnttab with libxc > mini-os: Include libxencall with libxc > mini-os: Include libxenforeignmemory with libxc All Acked-by: Samuel Thibault in case it was really necessary :) _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Thu Oct 22 20:43:08 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 22 Oct 2015 20:43:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZpMhW-0003hn-S8; Thu, 22 Oct 2015 20:43:06 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZpMhV-0003hi-Pv for minios-devel@lists.xenproject.org; Thu, 22 Oct 2015 20:43:05 +0000 Received: from [193.109.254.147] by server-15.bemta-14.messagelabs.com id 56/3C-18886-95A49265; Thu, 22 Oct 2015 20:43:05 +0000 X-Env-Sender: SRS0=+plG=K2=ens-lyon.org=samuel.thibault@bounce.ens-lyon.o rg X-Msg-Ref: server-3.tower-27.messagelabs.com!1445546580!60656354!1 X-Originating-IP: [140.77.166.138] X-SpamReason: No, hits=0.2 required=7.0 tests=RCVD_ILLEGAL_IP X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 25606 invoked from network); 22 Oct 2015 20:43:00 -0000 Received: from domu-toccata.ens-lyon.fr (HELO sonata.ens-lyon.org) (140.77.166.138) by server-3.tower-27.messagelabs.com with DHE-RSA-AES256-SHA encrypted SMTP; 22 Oct 2015 20:43:00 -0000 Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 2FBCB200CE; Thu, 22 Oct 2015 22:43:00 +0200 (CEST) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xPyGQ2aq2oWG; Thu, 22 Oct 2015 22:43:00 +0200 (CEST) Received: from var.ipv6 (ABordeaux-652-1-135-46.w2-6.abo.wanadoo.fr [2.6.118.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 7A666200C7; Thu, 22 Oct 2015 22:42:59 +0200 (CEST) Received: from samy by var.ipv6 with local (Exim 4.86) (envelope-from ) id 1ZpMhO-0008EW-Hr; Thu, 22 Oct 2015 22:42:58 +0200 Date: Thu, 22 Oct 2015 22:42:58 +0200 From: Samuel Thibault To: Ian Campbell Message-ID: <20151022204258.GX10915@var.home> Mail-Followup-To: Samuel Thibault , Ian Campbell , ian.jackson@eu.citrix.com, wei.liu2@citrix.com, xen-devel@lists.xen.org, minios-devel@lists.xenproject.org References: <1445440941.9563.163.camel@citrix.com> <1445441059-26083-1-git-send-email-ian.campbell@citrix.com> MIME-Version: 1.0 Content-Length: 957 Content-Disposition: inline In-Reply-To: <1445441059-26083-1-git-send-email-ian.campbell@citrix.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Cc: minios-devel@lists.xenproject.org, wei.liu2@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org Subject: Re: [Minios-devel] [PATCH MINI-OS v4 0/5] Begin to disentangle libxenctrl and provide some stable libraries X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Ian Campbell, le Wed 21 Oct 2015 16:24:14 +0100, a =E9crit : > We intend to stabilise some parts of the libxenctrl interface by > splitting out some functionality into separate stable libraries. > = > This is the mini-os part of the first phase of that change. > = > This mail is (or is intended to be) a reply to a "0/" > super-intro mail covering all of the related patch series and which > contains more details. > = > Ian Campbell (5): > mini-os: Include libxentoollog with libxc > mini-os: Include libxenevtchn with libxc > mini-os: Include libxengnttab with libxc > mini-os: Include libxencall with libxc > mini-os: Include libxenforeignmemory with libxc All Acked-by: Samuel Thibault in case it was really necessary :) _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Fri Oct 23 08:47:50 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 23 Oct 2015 08:47:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZpY0r-0005OL-GU; Fri, 23 Oct 2015 08:47:49 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZpY0q-0005O6-0H for minios-devel@lists.xenproject.org; Fri, 23 Oct 2015 08:47:48 +0000 Received: from [193.109.254.147] by server-13.bemta-14.messagelabs.com id FF/32-12371-234F9265; Fri, 23 Oct 2015 08:47:46 +0000 X-Env-Sender: prvs=731336292=wei.liu2@citrix.com X-Msg-Ref: server-12.tower-27.messagelabs.com!1445590064!60857649!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 1012 invoked from network); 23 Oct 2015 08:47:46 -0000 Received: from smtp.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-12.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 23 Oct 2015 08:47:46 -0000 X-IronPort-AV: E=Sophos;i="5.20,185,1444694400"; d="scan'208";a="312462298" Date: Fri, 23 Oct 2015 09:47:43 +0100 From: Wei Liu To: zhang chengfei Message-ID: <20151023084743.GO5060@zion.uk.xensource.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-DLP: MIA1 Cc: "minios-devel@lists.xenproject.org" , wei.liu2@citrix.com Subject: Re: [Minios-devel] How to modify the network bandwidth of minios? X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Thu, Oct 22, 2015 at 03:20:45PM +0000, zhang chengfei wrote: > I have implemented a redis client, I want to test the writing bandwidth > of minios, I got the result about 10MB/s.How can I improve the bandwidth > limit ? > Thanks ! I think the only way is to look at the code and figure out where the bottleneck is. But, if your goal is to develop unikernel-like application I suggest you use rump kernel instead. Wei. > _______________________________________________ > Minios-devel mailing list > Minios-devel@lists.xenproject.org > http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Fri Oct 23 08:47:50 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 23 Oct 2015 08:47:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZpY0r-0005OL-GU; Fri, 23 Oct 2015 08:47:49 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZpY0q-0005O6-0H for minios-devel@lists.xenproject.org; Fri, 23 Oct 2015 08:47:48 +0000 Received: from [193.109.254.147] by server-13.bemta-14.messagelabs.com id FF/32-12371-234F9265; Fri, 23 Oct 2015 08:47:46 +0000 X-Env-Sender: prvs=731336292=wei.liu2@citrix.com X-Msg-Ref: server-12.tower-27.messagelabs.com!1445590064!60857649!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 1012 invoked from network); 23 Oct 2015 08:47:46 -0000 Received: from smtp.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-12.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 23 Oct 2015 08:47:46 -0000 X-IronPort-AV: E=Sophos;i="5.20,185,1444694400"; d="scan'208";a="312462298" Date: Fri, 23 Oct 2015 09:47:43 +0100 From: Wei Liu To: zhang chengfei Message-ID: <20151023084743.GO5060@zion.uk.xensource.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-DLP: MIA1 Cc: "minios-devel@lists.xenproject.org" , wei.liu2@citrix.com Subject: Re: [Minios-devel] How to modify the network bandwidth of minios? X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Thu, Oct 22, 2015 at 03:20:45PM +0000, zhang chengfei wrote: > I have implemented a redis client, I want to test the writing bandwidth > of minios, I got the result about 10MB/s.How can I improve the bandwidth > limit ? > Thanks ! I think the only way is to look at the code and figure out where the bottleneck is. But, if your goal is to develop unikernel-like application I suggest you use rump kernel instead. Wei. > _______________________________________________ > Minios-devel mailing list > Minios-devel@lists.xenproject.org > http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Fri Oct 23 09:43:53 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 23 Oct 2015 09:43:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZpYt6-0002U3-Jm; Fri, 23 Oct 2015 09:43:52 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZpYt5-0002TW-FT for minios-devel@lists.xenproject.org; Fri, 23 Oct 2015 09:43:51 +0000 Received: from [85.158.139.211] by server-2.bemta-5.messagelabs.com id 03/63-31450-6510A265; Fri, 23 Oct 2015 09:43:50 +0000 X-Env-Sender: prvs=7311588c8=Ian.Campbell@citrix.com X-Msg-Ref: server-10.tower-206.messagelabs.com!1445593428!39247518!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 8335 invoked from network); 23 Oct 2015 09:43:49 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-10.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 23 Oct 2015 09:43:49 -0000 X-IronPort-AV: E=Sophos;i="5.20,186,1444694400"; d="scan'208";a="312475463" Message-ID: <1445593401.2374.92.camel@citrix.com> From: Ian Campbell To: Samuel Thibault Date: Fri, 23 Oct 2015 10:43:21 +0100 In-Reply-To: <20151022204258.GX10915@var.home> References: <1445440941.9563.163.camel@citrix.com> <1445441059-26083-1-git-send-email-ian.campbell@citrix.com> <20151022204258.GX10915@var.home> X-Mailer: Evolution 3.16.5-1 MIME-Version: 1.0 X-DLP: MIA1 Cc: minios-devel@lists.xenproject.org, wei.liu2@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org Subject: Re: [Minios-devel] [PATCH MINI-OS v4 0/5] Begin to disentangle libxenctrl and provide some stable libraries X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org T24gVGh1LCAyMDE1LTEwLTIyIGF0IDIyOjQyICswMjAwLCBTYW11ZWwgVGhpYmF1bHQgd3JvdGU6 Cj4gSWFuIENhbXBiZWxsLCBsZSBXZWQgMjEgT2N0IDIwMTUgMTY6MjQ6MTQgKzAxMDAsIGEgw6lj cml0IDoKPiA+IFdlIGludGVuZCB0byBzdGFiaWxpc2Ugc29tZSBwYXJ0cyBvZiB0aGUgbGlieGVu Y3RybCBpbnRlcmZhY2UgYnkKPiA+IHNwbGl0dGluZyBvdXQgc29tZSBmdW5jdGlvbmFsaXR5IGlu dG8gc2VwYXJhdGUgc3RhYmxlIGxpYnJhcmllcy4KPiA+IAo+ID4gVGhpcyBpcyB0aGUgbWluaS1v cyBwYXJ0IG9mIHRoZSBmaXJzdCBwaGFzZSBvZiB0aGF0IGNoYW5nZS4KPiA+IAo+ID4gVGhpcyBt YWlsIGlzIChvciBpcyBpbnRlbmRlZCB0byBiZSkgYSByZXBseSB0byBhICIwLzxWQVJJT1VTPiIK PiA+IHN1cGVyLWludHJvIG1haWwgY292ZXJpbmcgYWxsIG9mIHRoZSByZWxhdGVkIHBhdGNoIHNl cmllcyBhbmQgd2hpY2gKPiA+IGNvbnRhaW5zIG1vcmUgZGV0YWlscy4KPiA+IAo+ID4gSWFuIENh bXBiZWxsICg1KToKPiA+ICAgbWluaS1vczogSW5jbHVkZSBsaWJ4ZW50b29sbG9nIHdpdGggbGli eGMKPiA+ICAgbWluaS1vczogSW5jbHVkZSBsaWJ4ZW5ldnRjaG4gd2l0aCBsaWJ4Ywo+ID4gICBt aW5pLW9zOiBJbmNsdWRlIGxpYnhlbmdudHRhYiB3aXRoIGxpYnhjCj4gPiAgIG1pbmktb3M6IElu Y2x1ZGUgbGlieGVuY2FsbCB3aXRoIGxpYnhjCj4gPiAgIG1pbmktb3M6IEluY2x1ZGUgbGlieGVu Zm9yZWlnbm1lbW9yeSB3aXRoIGxpYnhjCj4gCj4gQWxsCj4gCj4gQWNrZWQtYnk6IFNhbXVlbCBU aGliYXVsdCA8c2FtdWVsLnRoaWJhdWx0QGVucy1seW9uLm9yZz4KPiAKPiBpbiBjYXNlIGl0IHdh cyByZWFsbHkgbmVjZXNzYXJ5IDopCgpUaGFua3MhCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpNaW5pb3MtZGV2ZWwgbWFpbGluZyBsaXN0Ck1pbmlvcy1k ZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwOi8vbGlzdHMueGVucHJvamVjdC5vcmcvY2dp LWJpbi9tYWlsbWFuL2xpc3RpbmZvL21pbmlvcy1kZXZlbA== From minios-devel-bounces@lists.xenproject.org Fri Oct 23 09:43:53 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 23 Oct 2015 09:43:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZpYt6-0002U3-Jm; Fri, 23 Oct 2015 09:43:52 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZpYt5-0002TW-FT for minios-devel@lists.xenproject.org; Fri, 23 Oct 2015 09:43:51 +0000 Received: from [85.158.139.211] by server-2.bemta-5.messagelabs.com id 03/63-31450-6510A265; Fri, 23 Oct 2015 09:43:50 +0000 X-Env-Sender: prvs=7311588c8=Ian.Campbell@citrix.com X-Msg-Ref: server-10.tower-206.messagelabs.com!1445593428!39247518!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 8335 invoked from network); 23 Oct 2015 09:43:49 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-10.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 23 Oct 2015 09:43:49 -0000 X-IronPort-AV: E=Sophos;i="5.20,186,1444694400"; d="scan'208";a="312475463" Message-ID: <1445593401.2374.92.camel@citrix.com> From: Ian Campbell To: Samuel Thibault Date: Fri, 23 Oct 2015 10:43:21 +0100 In-Reply-To: <20151022204258.GX10915@var.home> References: <1445440941.9563.163.camel@citrix.com> <1445441059-26083-1-git-send-email-ian.campbell@citrix.com> <20151022204258.GX10915@var.home> X-Mailer: Evolution 3.16.5-1 MIME-Version: 1.0 X-DLP: MIA1 Cc: minios-devel@lists.xenproject.org, wei.liu2@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org Subject: Re: [Minios-devel] [PATCH MINI-OS v4 0/5] Begin to disentangle libxenctrl and provide some stable libraries X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org T24gVGh1LCAyMDE1LTEwLTIyIGF0IDIyOjQyICswMjAwLCBTYW11ZWwgVGhpYmF1bHQgd3JvdGU6 Cj4gSWFuIENhbXBiZWxsLCBsZSBXZWQgMjEgT2N0IDIwMTUgMTY6MjQ6MTQgKzAxMDAsIGEgw6lj cml0IDoKPiA+IFdlIGludGVuZCB0byBzdGFiaWxpc2Ugc29tZSBwYXJ0cyBvZiB0aGUgbGlieGVu Y3RybCBpbnRlcmZhY2UgYnkKPiA+IHNwbGl0dGluZyBvdXQgc29tZSBmdW5jdGlvbmFsaXR5IGlu dG8gc2VwYXJhdGUgc3RhYmxlIGxpYnJhcmllcy4KPiA+IAo+ID4gVGhpcyBpcyB0aGUgbWluaS1v cyBwYXJ0IG9mIHRoZSBmaXJzdCBwaGFzZSBvZiB0aGF0IGNoYW5nZS4KPiA+IAo+ID4gVGhpcyBt YWlsIGlzIChvciBpcyBpbnRlbmRlZCB0byBiZSkgYSByZXBseSB0byBhICIwLzxWQVJJT1VTPiIK PiA+IHN1cGVyLWludHJvIG1haWwgY292ZXJpbmcgYWxsIG9mIHRoZSByZWxhdGVkIHBhdGNoIHNl cmllcyBhbmQgd2hpY2gKPiA+IGNvbnRhaW5zIG1vcmUgZGV0YWlscy4KPiA+IAo+ID4gSWFuIENh bXBiZWxsICg1KToKPiA+ICAgbWluaS1vczogSW5jbHVkZSBsaWJ4ZW50b29sbG9nIHdpdGggbGli eGMKPiA+ICAgbWluaS1vczogSW5jbHVkZSBsaWJ4ZW5ldnRjaG4gd2l0aCBsaWJ4Ywo+ID4gICBt aW5pLW9zOiBJbmNsdWRlIGxpYnhlbmdudHRhYiB3aXRoIGxpYnhjCj4gPiAgIG1pbmktb3M6IElu Y2x1ZGUgbGlieGVuY2FsbCB3aXRoIGxpYnhjCj4gPiAgIG1pbmktb3M6IEluY2x1ZGUgbGlieGVu Zm9yZWlnbm1lbW9yeSB3aXRoIGxpYnhjCj4gCj4gQWxsCj4gCj4gQWNrZWQtYnk6IFNhbXVlbCBU aGliYXVsdCA8c2FtdWVsLnRoaWJhdWx0QGVucy1seW9uLm9yZz4KPiAKPiBpbiBjYXNlIGl0IHdh cyByZWFsbHkgbmVjZXNzYXJ5IDopCgpUaGFua3MhCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpNaW5pb3MtZGV2ZWwgbWFpbGluZyBsaXN0Ck1pbmlvcy1k ZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwOi8vbGlzdHMueGVucHJvamVjdC5vcmcvY2dp LWJpbi9tYWlsbWFuL2xpc3RpbmZvL21pbmlvcy1kZXZlbA== From minios-devel-bounces@lists.xenproject.org Mon Oct 26 09:47:59 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 09:47:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqeNh-0004Yx-No; Mon, 26 Oct 2015 09:47:57 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqeNf-0004Ye-Qm; Mon, 26 Oct 2015 09:47:55 +0000 Received: from [85.158.139.211] by server-15.bemta-5.messagelabs.com id 35/D4-16870-BC6FD265; Mon, 26 Oct 2015 09:47:55 +0000 X-Env-Sender: prvs=734318897=wei.liu2@citrix.com X-Msg-Ref: server-7.tower-206.messagelabs.com!1445852872!20684247!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 24405 invoked from network); 26 Oct 2015 09:47:54 -0000 Received: from smtp.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-7.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 09:47:54 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444694400"; d="scan'208";a="313271163" From: Wei Liu To: Date: Mon, 26 Oct 2015 09:47:48 +0000 Message-ID: <1445852868-16532-1-git-send-email-wei.liu2@citrix.com> X-Mailer: git-send-email 2.1.4 MIME-Version: 1.0 X-DLP: MIA2 Cc: Ian Jackson , Xen-devel , Wei Liu , Ian Campbell , Samuel Thibault Subject: [Minios-devel] [PATCH MINI-OS] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org The xenbus thread didn't send notification to other end when it expected more data or consumed responses, which led to stalling the ring from time to time. This is the culprit that guest was less responsive when using stubdom because the device model was stalled. Fix this by sending notification to the other end at the right places. Signed-off-by: Wei Liu --- Cc: Ian Campbell Cc: Ian Jackson Cc: Samuel Thibault With this path I can migrate a guest with stubdom a few thousand times without any issue, while before I could easily trigger time out within a few iterations. This should make OSSTest stubdom test case more reliable. Ian J, this is a patch suitable for backporting to 4.6. It's good time to branch mini-os now. --- xenbus/xenbus.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/xenbus/xenbus.c b/xenbus/xenbus.c index 4613ed6..7451161 100644 --- a/xenbus/xenbus.c +++ b/xenbus/xenbus.c @@ -205,8 +205,10 @@ static void xenbus_thread_func(void *ign) prod = xenstore_buf->rsp_prod; DEBUG("Rsp_cons %d, rsp_prod %d.\n", xenstore_buf->rsp_cons, xenstore_buf->rsp_prod); - if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < sizeof(msg)) + if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < sizeof(msg)) { + notify_remote_via_evtchn(start_info.store_evtchn); break; + } rmb(); memcpy_from_ring(xenstore_buf->rsp, &msg, @@ -217,8 +219,10 @@ static void xenbus_thread_func(void *ign) xenstore_buf->rsp_prod - xenstore_buf->rsp_cons, msg.req_id); if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < - sizeof(msg) + msg.len) + sizeof(msg) + msg.len) { + notify_remote_via_evtchn(start_info.store_evtchn); break; + } DEBUG("Message is good.\n"); @@ -265,6 +269,9 @@ static void xenbus_thread_func(void *ign) xenstore_buf->rsp_cons += msg.len + sizeof(msg); wake_up(&req_info[msg.req_id].waitq); } + + wmb(); + notify_remote_via_evtchn(start_info.store_evtchn); } } } -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 09:47:59 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 09:47:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqeNh-0004Yx-No; Mon, 26 Oct 2015 09:47:57 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqeNf-0004Ye-Qm; Mon, 26 Oct 2015 09:47:55 +0000 Received: from [85.158.139.211] by server-15.bemta-5.messagelabs.com id 35/D4-16870-BC6FD265; Mon, 26 Oct 2015 09:47:55 +0000 X-Env-Sender: prvs=734318897=wei.liu2@citrix.com X-Msg-Ref: server-7.tower-206.messagelabs.com!1445852872!20684247!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 24405 invoked from network); 26 Oct 2015 09:47:54 -0000 Received: from smtp.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-7.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 09:47:54 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444694400"; d="scan'208";a="313271163" From: Wei Liu To: Date: Mon, 26 Oct 2015 09:47:48 +0000 Message-ID: <1445852868-16532-1-git-send-email-wei.liu2@citrix.com> X-Mailer: git-send-email 2.1.4 MIME-Version: 1.0 X-DLP: MIA2 Cc: Ian Jackson , Xen-devel , Wei Liu , Ian Campbell , Samuel Thibault Subject: [Minios-devel] [PATCH MINI-OS] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org The xenbus thread didn't send notification to other end when it expected more data or consumed responses, which led to stalling the ring from time to time. This is the culprit that guest was less responsive when using stubdom because the device model was stalled. Fix this by sending notification to the other end at the right places. Signed-off-by: Wei Liu --- Cc: Ian Campbell Cc: Ian Jackson Cc: Samuel Thibault With this path I can migrate a guest with stubdom a few thousand times without any issue, while before I could easily trigger time out within a few iterations. This should make OSSTest stubdom test case more reliable. Ian J, this is a patch suitable for backporting to 4.6. It's good time to branch mini-os now. --- xenbus/xenbus.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/xenbus/xenbus.c b/xenbus/xenbus.c index 4613ed6..7451161 100644 --- a/xenbus/xenbus.c +++ b/xenbus/xenbus.c @@ -205,8 +205,10 @@ static void xenbus_thread_func(void *ign) prod = xenstore_buf->rsp_prod; DEBUG("Rsp_cons %d, rsp_prod %d.\n", xenstore_buf->rsp_cons, xenstore_buf->rsp_prod); - if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < sizeof(msg)) + if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < sizeof(msg)) { + notify_remote_via_evtchn(start_info.store_evtchn); break; + } rmb(); memcpy_from_ring(xenstore_buf->rsp, &msg, @@ -217,8 +219,10 @@ static void xenbus_thread_func(void *ign) xenstore_buf->rsp_prod - xenstore_buf->rsp_cons, msg.req_id); if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < - sizeof(msg) + msg.len) + sizeof(msg) + msg.len) { + notify_remote_via_evtchn(start_info.store_evtchn); break; + } DEBUG("Message is good.\n"); @@ -265,6 +269,9 @@ static void xenbus_thread_func(void *ign) xenstore_buf->rsp_cons += msg.len + sizeof(msg); wake_up(&req_info[msg.req_id].waitq); } + + wmb(); + notify_remote_via_evtchn(start_info.store_evtchn); } } } -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 12:02:49 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 12:02:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqgUC-00039m-P5; Mon, 26 Oct 2015 12:02:48 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqgUB-00039c-VS; Mon, 26 Oct 2015 12:02:48 +0000 Received: from [85.158.137.68] by server-5.bemta-3.messagelabs.com id CD/98-01748-7661E265; Mon, 26 Oct 2015 12:02:47 +0000 X-Env-Sender: samuel.thibault@ens-lyon.org X-Msg-Ref: server-10.tower-31.messagelabs.com!1445860965!56714751!1 X-Originating-IP: [192.134.164.83] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 10553 invoked from network); 26 Oct 2015 12:02:46 -0000 Received: from mail2-relais-roc.national.inria.fr (HELO mail2-relais-roc.national.inria.fr) (192.134.164.83) by server-10.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 12:02:46 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444687200"; d="scan'208";a="184469453" Received: from unknown (HELO var.ipv6) ([193.50.110.121]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/AES128-GCM-SHA256; 26 Oct 2015 13:02:45 +0100 Received: from samy by var.ipv6 with local (Exim 4.86) (envelope-from ) id 1ZqgU9-00061l-5D; Mon, 26 Oct 2015 13:02:45 +0100 Date: Mon, 26 Oct 2015 13:02:45 +0100 From: Samuel Thibault To: Wei Liu Message-ID: <20151026120245.GA19459@var.bordeaux.inria.fr> Mail-Followup-To: Samuel Thibault , Wei Liu , minios-devel@lists.xenproject.org, Xen-devel , Ian Campbell , Ian Jackson References: <1445852868-16532-1-git-send-email-wei.liu2@citrix.com> MIME-Version: 1.0 Content-Length: 2635 Content-Disposition: inline In-Reply-To: <1445852868-16532-1-git-send-email-wei.liu2@citrix.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Cc: minios-devel@lists.xenproject.org, Xen-devel , Ian Jackson , Ian Campbell Subject: Re: [Minios-devel] [PATCH MINI-OS] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Hello, Indeed, notification seems to have been missing since basically 2006... Wei Liu, le Mon 26 Oct 2015 09:47:48 +0000, a =E9crit : > diff --git a/xenbus/xenbus.c b/xenbus/xenbus.c > index 4613ed6..7451161 100644 > --- a/xenbus/xenbus.c > +++ b/xenbus/xenbus.c > @@ -205,8 +205,10 @@ static void xenbus_thread_func(void *ign) > prod =3D xenstore_buf->rsp_prod; > DEBUG("Rsp_cons %d, rsp_prod %d.\n", xenstore_buf->rsp_cons, > xenstore_buf->rsp_prod); > - if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < sizeof= (msg)) > + if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < sizeof= (msg)) { > + notify_remote_via_evtchn(start_info.store_evtchn); > break; > + } > rmb(); > memcpy_from_ring(xenstore_buf->rsp, > &msg, > @@ -217,8 +219,10 @@ static void xenbus_thread_func(void *ign) > xenstore_buf->rsp_prod - xenstore_buf->rsp_cons, > msg.req_id); > if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < > - sizeof(msg) + msg.len) > + sizeof(msg) + msg.len) { > + notify_remote_via_evtchn(start_info.store_evtchn); > break; > + } > = > DEBUG("Message is good.\n"); > = > @@ -265,6 +269,9 @@ static void xenbus_thread_func(void *ign) > xenstore_buf->rsp_cons +=3D msg.len + sizeof(msg); > wake_up(&req_info[msg.req_id].waitq); > } > + > + wmb(); > + notify_remote_via_evtchn(start_info.store_evtchn); > } > } > } The wmb() position seems right, but the notification could be put a bit later, after the exit of the while(1) loop. That'd make it factorized for all cases were the processing could want to stop, and make it quite naturally enough just before the wait_event call, so something like below (untested). Samuel diff --git a/xenbus/xenbus.c b/xenbus/xenbus.c index 4613ed6..858aa98 100644 --- a/xenbus/xenbus.c +++ b/xenbus/xenbus.c @@ -265,7 +265,10 @@ static void xenbus_thread_func(void *ign) xenstore_buf->rsp_cons +=3D msg.len + sizeof(msg); wake_up(&req_info[msg.req_id].waitq); } + + wmb(); } + notify_remote_via_evtchn(start_info.store_evtchn); } } = _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 12:02:49 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 12:02:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqgUC-00039m-P5; Mon, 26 Oct 2015 12:02:48 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqgUB-00039c-VS; Mon, 26 Oct 2015 12:02:48 +0000 Received: from [85.158.137.68] by server-5.bemta-3.messagelabs.com id CD/98-01748-7661E265; Mon, 26 Oct 2015 12:02:47 +0000 X-Env-Sender: samuel.thibault@ens-lyon.org X-Msg-Ref: server-10.tower-31.messagelabs.com!1445860965!56714751!1 X-Originating-IP: [192.134.164.83] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 10553 invoked from network); 26 Oct 2015 12:02:46 -0000 Received: from mail2-relais-roc.national.inria.fr (HELO mail2-relais-roc.national.inria.fr) (192.134.164.83) by server-10.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 12:02:46 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444687200"; d="scan'208";a="184469453" Received: from unknown (HELO var.ipv6) ([193.50.110.121]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/AES128-GCM-SHA256; 26 Oct 2015 13:02:45 +0100 Received: from samy by var.ipv6 with local (Exim 4.86) (envelope-from ) id 1ZqgU9-00061l-5D; Mon, 26 Oct 2015 13:02:45 +0100 Date: Mon, 26 Oct 2015 13:02:45 +0100 From: Samuel Thibault To: Wei Liu Message-ID: <20151026120245.GA19459@var.bordeaux.inria.fr> Mail-Followup-To: Samuel Thibault , Wei Liu , minios-devel@lists.xenproject.org, Xen-devel , Ian Campbell , Ian Jackson References: <1445852868-16532-1-git-send-email-wei.liu2@citrix.com> MIME-Version: 1.0 Content-Length: 2635 Content-Disposition: inline In-Reply-To: <1445852868-16532-1-git-send-email-wei.liu2@citrix.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Cc: minios-devel@lists.xenproject.org, Xen-devel , Ian Jackson , Ian Campbell Subject: Re: [Minios-devel] [PATCH MINI-OS] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Hello, Indeed, notification seems to have been missing since basically 2006... Wei Liu, le Mon 26 Oct 2015 09:47:48 +0000, a =E9crit : > diff --git a/xenbus/xenbus.c b/xenbus/xenbus.c > index 4613ed6..7451161 100644 > --- a/xenbus/xenbus.c > +++ b/xenbus/xenbus.c > @@ -205,8 +205,10 @@ static void xenbus_thread_func(void *ign) > prod =3D xenstore_buf->rsp_prod; > DEBUG("Rsp_cons %d, rsp_prod %d.\n", xenstore_buf->rsp_cons, > xenstore_buf->rsp_prod); > - if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < sizeof= (msg)) > + if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < sizeof= (msg)) { > + notify_remote_via_evtchn(start_info.store_evtchn); > break; > + } > rmb(); > memcpy_from_ring(xenstore_buf->rsp, > &msg, > @@ -217,8 +219,10 @@ static void xenbus_thread_func(void *ign) > xenstore_buf->rsp_prod - xenstore_buf->rsp_cons, > msg.req_id); > if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < > - sizeof(msg) + msg.len) > + sizeof(msg) + msg.len) { > + notify_remote_via_evtchn(start_info.store_evtchn); > break; > + } > = > DEBUG("Message is good.\n"); > = > @@ -265,6 +269,9 @@ static void xenbus_thread_func(void *ign) > xenstore_buf->rsp_cons +=3D msg.len + sizeof(msg); > wake_up(&req_info[msg.req_id].waitq); > } > + > + wmb(); > + notify_remote_via_evtchn(start_info.store_evtchn); > } > } > } The wmb() position seems right, but the notification could be put a bit later, after the exit of the while(1) loop. That'd make it factorized for all cases were the processing could want to stop, and make it quite naturally enough just before the wait_event call, so something like below (untested). Samuel diff --git a/xenbus/xenbus.c b/xenbus/xenbus.c index 4613ed6..858aa98 100644 --- a/xenbus/xenbus.c +++ b/xenbus/xenbus.c @@ -265,7 +265,10 @@ static void xenbus_thread_func(void *ign) xenstore_buf->rsp_cons +=3D msg.len + sizeof(msg); wake_up(&req_info[msg.req_id].waitq); } + + wmb(); } + notify_remote_via_evtchn(start_info.store_evtchn); } } = _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 12:14:49 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 12:14:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqgfp-00042l-Ke; Mon, 26 Oct 2015 12:14:49 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqgfn-00042b-UR; Mon, 26 Oct 2015 12:14:48 +0000 Received: from [193.109.254.147] by server-5.bemta-14.messagelabs.com id 2A/78-00475-7391E265; Mon, 26 Oct 2015 12:14:47 +0000 X-Env-Sender: prvs=734318897=wei.liu2@citrix.com X-Msg-Ref: server-6.tower-27.messagelabs.com!1445861684!24711237!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 13317 invoked from network); 26 Oct 2015 12:14:46 -0000 Received: from smtp.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-6.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 12:14:46 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444694400"; d="scan'208";a="313315228" Date: Mon, 26 Oct 2015 12:14:43 +0000 From: Wei Liu To: Samuel Thibault , Wei Liu , , Xen-devel , Ian Campbell , "Ian Jackson" Message-ID: <20151026121442.GD13118@zion.uk.xensource.com> References: <1445852868-16532-1-git-send-email-wei.liu2@citrix.com> <20151026120245.GA19459@var.bordeaux.inria.fr> MIME-Version: 1.0 Content-Length: 3104 Content-Disposition: inline In-Reply-To: <20151026120245.GA19459@var.bordeaux.inria.fr> User-Agent: Mutt/1.5.23 (2014-03-12) X-DLP: MIA2 Subject: Re: [Minios-devel] [PATCH MINI-OS] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Mon, Oct 26, 2015 at 01:02:45PM +0100, Samuel Thibault wrote: > Hello, > = > Indeed, notification seems to have been missing since basically 2006... > = > Wei Liu, le Mon 26 Oct 2015 09:47:48 +0000, a =E9crit : > > diff --git a/xenbus/xenbus.c b/xenbus/xenbus.c > > index 4613ed6..7451161 100644 > > --- a/xenbus/xenbus.c > > +++ b/xenbus/xenbus.c > > @@ -205,8 +205,10 @@ static void xenbus_thread_func(void *ign) > > prod =3D xenstore_buf->rsp_prod; > > DEBUG("Rsp_cons %d, rsp_prod %d.\n", xenstore_buf->rsp_con= s, > > xenstore_buf->rsp_prod); > > - if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < size= of(msg)) > > + if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < size= of(msg)) { > > + notify_remote_via_evtchn(start_info.store_evtchn); > > break; > > + } > > rmb(); > > memcpy_from_ring(xenstore_buf->rsp, > > &msg, > > @@ -217,8 +219,10 @@ static void xenbus_thread_func(void *ign) > > xenstore_buf->rsp_prod - xenstore_buf->rsp_cons, > > msg.req_id); > > if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < > > - sizeof(msg) + msg.len) > > + sizeof(msg) + msg.len) { > > + notify_remote_via_evtchn(start_info.store_evtchn); > > break; > > + } > > = > > DEBUG("Message is good.\n"); > > = > > @@ -265,6 +269,9 @@ static void xenbus_thread_func(void *ign) > > xenstore_buf->rsp_cons +=3D msg.len + sizeof(msg); > > wake_up(&req_info[msg.req_id].waitq); > > } > > + > > + wmb(); > > + notify_remote_via_evtchn(start_info.store_evtchn); > > } > > } > > } > = > The wmb() position seems right, but the notification could be put a bit > later, after the exit of the while(1) loop. That'd make it factorized > for all cases were the processing could want to stop, and make it quite > naturally enough just before the wait_event call, so something like > below (untested). > = > Samuel > = > diff --git a/xenbus/xenbus.c b/xenbus/xenbus.c > index 4613ed6..858aa98 100644 > --- a/xenbus/xenbus.c > +++ b/xenbus/xenbus.c > @@ -265,7 +265,10 @@ static void xenbus_thread_func(void *ign) > xenstore_buf->rsp_cons +=3D msg.len + sizeof(msg); > wake_up(&req_info[msg.req_id].waitq); > } > + > + wmb(); > } > + notify_remote_via_evtchn(start_info.store_evtchn); I am sure your patch works too but there is a subtle difference. In my patch, mini-os notifies remote whenever it consumes a message, which I think it's slightly better because backend can start putting things in the ring as mini-os processes them. Wei. > } > } > = _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 12:14:49 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 12:14:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqgfp-00042l-Ke; Mon, 26 Oct 2015 12:14:49 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqgfn-00042b-UR; Mon, 26 Oct 2015 12:14:48 +0000 Received: from [193.109.254.147] by server-5.bemta-14.messagelabs.com id 2A/78-00475-7391E265; Mon, 26 Oct 2015 12:14:47 +0000 X-Env-Sender: prvs=734318897=wei.liu2@citrix.com X-Msg-Ref: server-6.tower-27.messagelabs.com!1445861684!24711237!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 13317 invoked from network); 26 Oct 2015 12:14:46 -0000 Received: from smtp.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-6.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 12:14:46 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444694400"; d="scan'208";a="313315228" Date: Mon, 26 Oct 2015 12:14:43 +0000 From: Wei Liu To: Samuel Thibault , Wei Liu , , Xen-devel , Ian Campbell , "Ian Jackson" Message-ID: <20151026121442.GD13118@zion.uk.xensource.com> References: <1445852868-16532-1-git-send-email-wei.liu2@citrix.com> <20151026120245.GA19459@var.bordeaux.inria.fr> MIME-Version: 1.0 Content-Length: 3104 Content-Disposition: inline In-Reply-To: <20151026120245.GA19459@var.bordeaux.inria.fr> User-Agent: Mutt/1.5.23 (2014-03-12) X-DLP: MIA2 Subject: Re: [Minios-devel] [PATCH MINI-OS] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Mon, Oct 26, 2015 at 01:02:45PM +0100, Samuel Thibault wrote: > Hello, > = > Indeed, notification seems to have been missing since basically 2006... > = > Wei Liu, le Mon 26 Oct 2015 09:47:48 +0000, a =E9crit : > > diff --git a/xenbus/xenbus.c b/xenbus/xenbus.c > > index 4613ed6..7451161 100644 > > --- a/xenbus/xenbus.c > > +++ b/xenbus/xenbus.c > > @@ -205,8 +205,10 @@ static void xenbus_thread_func(void *ign) > > prod =3D xenstore_buf->rsp_prod; > > DEBUG("Rsp_cons %d, rsp_prod %d.\n", xenstore_buf->rsp_con= s, > > xenstore_buf->rsp_prod); > > - if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < size= of(msg)) > > + if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < size= of(msg)) { > > + notify_remote_via_evtchn(start_info.store_evtchn); > > break; > > + } > > rmb(); > > memcpy_from_ring(xenstore_buf->rsp, > > &msg, > > @@ -217,8 +219,10 @@ static void xenbus_thread_func(void *ign) > > xenstore_buf->rsp_prod - xenstore_buf->rsp_cons, > > msg.req_id); > > if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < > > - sizeof(msg) + msg.len) > > + sizeof(msg) + msg.len) { > > + notify_remote_via_evtchn(start_info.store_evtchn); > > break; > > + } > > = > > DEBUG("Message is good.\n"); > > = > > @@ -265,6 +269,9 @@ static void xenbus_thread_func(void *ign) > > xenstore_buf->rsp_cons +=3D msg.len + sizeof(msg); > > wake_up(&req_info[msg.req_id].waitq); > > } > > + > > + wmb(); > > + notify_remote_via_evtchn(start_info.store_evtchn); > > } > > } > > } > = > The wmb() position seems right, but the notification could be put a bit > later, after the exit of the while(1) loop. That'd make it factorized > for all cases were the processing could want to stop, and make it quite > naturally enough just before the wait_event call, so something like > below (untested). > = > Samuel > = > diff --git a/xenbus/xenbus.c b/xenbus/xenbus.c > index 4613ed6..858aa98 100644 > --- a/xenbus/xenbus.c > +++ b/xenbus/xenbus.c > @@ -265,7 +265,10 @@ static void xenbus_thread_func(void *ign) > xenstore_buf->rsp_cons +=3D msg.len + sizeof(msg); > wake_up(&req_info[msg.req_id].waitq); > } > + > + wmb(); > } > + notify_remote_via_evtchn(start_info.store_evtchn); I am sure your patch works too but there is a subtle difference. In my patch, mini-os notifies remote whenever it consumes a message, which I think it's slightly better because backend can start putting things in the ring as mini-os processes them. Wei. > } > } > = _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 12:21:56 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 12:21:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqgmi-0004HS-JA; Mon, 26 Oct 2015 12:21:56 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqgmg-0004HK-Fi; Mon, 26 Oct 2015 12:21:54 +0000 Received: from [85.158.139.211] by server-15.bemta-5.messagelabs.com id 2D/F8-16870-1EA1E265; Mon, 26 Oct 2015 12:21:53 +0000 X-Env-Sender: samuel.thibault@ens-lyon.org X-Msg-Ref: server-13.tower-206.messagelabs.com!1445862112!15215329!1 X-Originating-IP: [192.134.164.104] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 32447 invoked from network); 26 Oct 2015 12:21:53 -0000 Received: from mail3-relais-sop.national.inria.fr (HELO mail3-relais-sop.national.inria.fr) (192.134.164.104) by server-13.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 12:21:53 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444687200"; d="scan'208";a="151766070" Received: from unknown (HELO var.ipv6) ([193.50.110.121]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/AES128-GCM-SHA256; 26 Oct 2015 13:21:52 +0100 Received: from samy by var.ipv6 with local (Exim 4.86) (envelope-from ) id 1Zqgmd-0006hY-V2; Mon, 26 Oct 2015 13:21:51 +0100 Date: Mon, 26 Oct 2015 13:21:51 +0100 From: Samuel Thibault To: Wei Liu Message-ID: <20151026122151.GC19459@var.bordeaux.inria.fr> Mail-Followup-To: Samuel Thibault , Wei Liu , minios-devel@lists.xenproject.org, Xen-devel , Ian Campbell , Ian Jackson References: <1445852868-16532-1-git-send-email-wei.liu2@citrix.com> <20151026120245.GA19459@var.bordeaux.inria.fr> <20151026121442.GD13118@zion.uk.xensource.com> MIME-Version: 1.0 Content-Length: 807 Content-Disposition: inline In-Reply-To: <20151026121442.GD13118@zion.uk.xensource.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Cc: minios-devel@lists.xenproject.org, Xen-devel , Ian Jackson , Ian Campbell Subject: Re: [Minios-devel] [PATCH MINI-OS] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Wei Liu, le Mon 26 Oct 2015 12:14:43 +0000, a =E9crit : > In my patch, mini-os notifies remote whenever it consumes a message, > which I think it's slightly better because backend can start putting > things in the ring as mini-os processes them. That makes more notifications, but that can lead to more pipelining indeed. That's what the Linux driver does, so let's do the same. Also, I'm realizing: aren't we missing a full memory barrier between the memcpy_from_ring call and xenstore_buf->rsp_cons +=3D ? (in the two places) We need to make sure to have finished copying from the ring before writing the new rsp_cons. Samuel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 12:21:56 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 12:21:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqgmi-0004HS-JA; Mon, 26 Oct 2015 12:21:56 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqgmg-0004HK-Fi; Mon, 26 Oct 2015 12:21:54 +0000 Received: from [85.158.139.211] by server-15.bemta-5.messagelabs.com id 2D/F8-16870-1EA1E265; Mon, 26 Oct 2015 12:21:53 +0000 X-Env-Sender: samuel.thibault@ens-lyon.org X-Msg-Ref: server-13.tower-206.messagelabs.com!1445862112!15215329!1 X-Originating-IP: [192.134.164.104] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 32447 invoked from network); 26 Oct 2015 12:21:53 -0000 Received: from mail3-relais-sop.national.inria.fr (HELO mail3-relais-sop.national.inria.fr) (192.134.164.104) by server-13.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 12:21:53 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444687200"; d="scan'208";a="151766070" Received: from unknown (HELO var.ipv6) ([193.50.110.121]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/AES128-GCM-SHA256; 26 Oct 2015 13:21:52 +0100 Received: from samy by var.ipv6 with local (Exim 4.86) (envelope-from ) id 1Zqgmd-0006hY-V2; Mon, 26 Oct 2015 13:21:51 +0100 Date: Mon, 26 Oct 2015 13:21:51 +0100 From: Samuel Thibault To: Wei Liu Message-ID: <20151026122151.GC19459@var.bordeaux.inria.fr> Mail-Followup-To: Samuel Thibault , Wei Liu , minios-devel@lists.xenproject.org, Xen-devel , Ian Campbell , Ian Jackson References: <1445852868-16532-1-git-send-email-wei.liu2@citrix.com> <20151026120245.GA19459@var.bordeaux.inria.fr> <20151026121442.GD13118@zion.uk.xensource.com> MIME-Version: 1.0 Content-Length: 807 Content-Disposition: inline In-Reply-To: <20151026121442.GD13118@zion.uk.xensource.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Cc: minios-devel@lists.xenproject.org, Xen-devel , Ian Jackson , Ian Campbell Subject: Re: [Minios-devel] [PATCH MINI-OS] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Wei Liu, le Mon 26 Oct 2015 12:14:43 +0000, a =E9crit : > In my patch, mini-os notifies remote whenever it consumes a message, > which I think it's slightly better because backend can start putting > things in the ring as mini-os processes them. That makes more notifications, but that can lead to more pipelining indeed. That's what the Linux driver does, so let's do the same. Also, I'm realizing: aren't we missing a full memory barrier between the memcpy_from_ring call and xenstore_buf->rsp_cons +=3D ? (in the two places) We need to make sure to have finished copying from the ring before writing the new rsp_cons. Samuel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 12:30:34 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 12:30:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqgv4-0004W0-KT; Mon, 26 Oct 2015 12:30:34 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqgv3-0004Vs-5b; Mon, 26 Oct 2015 12:30:33 +0000 Received: from [85.158.139.211] by server-3.bemta-5.messagelabs.com id 3C/BF-06179-8EC1E265; Mon, 26 Oct 2015 12:30:32 +0000 X-Env-Sender: prvs=734318897=wei.liu2@citrix.com X-Msg-Ref: server-4.tower-206.messagelabs.com!1445862630!45123178!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 29106 invoked from network); 26 Oct 2015 12:30:31 -0000 Received: from smtp.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-4.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 12:30:31 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444694400"; d="scan'208";a="313321360" Date: Mon, 26 Oct 2015 12:30:28 +0000 From: Wei Liu To: Samuel Thibault , Wei Liu , , Xen-devel , Ian Campbell , "Ian Jackson" Message-ID: <20151026123028.GE13118@zion.uk.xensource.com> References: <1445852868-16532-1-git-send-email-wei.liu2@citrix.com> <20151026120245.GA19459@var.bordeaux.inria.fr> <20151026121442.GD13118@zion.uk.xensource.com> <20151026122151.GC19459@var.bordeaux.inria.fr> MIME-Version: 1.0 Content-Length:1034 Content-Disposition: inline In-Reply-To: <20151026122151.GC19459@var.bordeaux.inria.fr> User-Agent: Mutt/1.5.23 (2014-03-12) X-DLP: MIA2 Subject: Re: [Minios-devel] [PATCH MINI-OS] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Mon, Oct 26, 2015 at 01:21:51PM +0100, Samuel Thibault wrote: > Wei Liu, le Mon 26 Oct 2015 12:14:43 +0000, a =E9crit : > > In my patch, mini-os notifies remote whenever it consumes a message, > > which I think it's slightly better because backend can start putting > > things in the ring as mini-os processes them. > = > That makes more notifications, but that can lead to more pipelining > indeed. That's what the Linux driver does, so let's do the same. > = > Also, I'm realizing: aren't we missing a full memory barrier between > the memcpy_from_ring call and xenstore_buf->rsp_cons +=3D ? (in the two > places) We need to make sure to have finished copying from the ring > before writing the new rsp_cons. > = You're right. I think we should just turn that wmb() into two mb()s and place them before xenstore_buf->rsp_cons +=3D. Wei. > Samuel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 12:30:34 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 12:30:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqgv4-0004W0-KT; Mon, 26 Oct 2015 12:30:34 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqgv3-0004Vs-5b; Mon, 26 Oct 2015 12:30:33 +0000 Received: from [85.158.139.211] by server-3.bemta-5.messagelabs.com id 3C/BF-06179-8EC1E265; Mon, 26 Oct 2015 12:30:32 +0000 X-Env-Sender: prvs=734318897=wei.liu2@citrix.com X-Msg-Ref: server-4.tower-206.messagelabs.com!1445862630!45123178!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 29106 invoked from network); 26 Oct 2015 12:30:31 -0000 Received: from smtp.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-4.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 12:30:31 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444694400"; d="scan'208";a="313321360" Date: Mon, 26 Oct 2015 12:30:28 +0000 From: Wei Liu To: Samuel Thibault , Wei Liu , , Xen-devel , Ian Campbell , "Ian Jackson" Message-ID: <20151026123028.GE13118@zion.uk.xensource.com> References: <1445852868-16532-1-git-send-email-wei.liu2@citrix.com> <20151026120245.GA19459@var.bordeaux.inria.fr> <20151026121442.GD13118@zion.uk.xensource.com> <20151026122151.GC19459@var.bordeaux.inria.fr> MIME-Version: 1.0 Content-Length:1034 Content-Disposition: inline In-Reply-To: <20151026122151.GC19459@var.bordeaux.inria.fr> User-Agent: Mutt/1.5.23 (2014-03-12) X-DLP: MIA2 Subject: Re: [Minios-devel] [PATCH MINI-OS] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Mon, Oct 26, 2015 at 01:21:51PM +0100, Samuel Thibault wrote: > Wei Liu, le Mon 26 Oct 2015 12:14:43 +0000, a =E9crit : > > In my patch, mini-os notifies remote whenever it consumes a message, > > which I think it's slightly better because backend can start putting > > things in the ring as mini-os processes them. > = > That makes more notifications, but that can lead to more pipelining > indeed. That's what the Linux driver does, so let's do the same. > = > Also, I'm realizing: aren't we missing a full memory barrier between > the memcpy_from_ring call and xenstore_buf->rsp_cons +=3D ? (in the two > places) We need to make sure to have finished copying from the ring > before writing the new rsp_cons. > = You're right. I think we should just turn that wmb() into two mb()s and place them before xenstore_buf->rsp_cons +=3D. Wei. > Samuel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 12:33:35 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 12:33:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqgxz-0004fr-AO; Mon, 26 Oct 2015 12:33:35 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqgxy-0004fi-Bg; Mon, 26 Oct 2015 12:33:34 +0000 Received: from [85.158.137.68] by server-6.bemta-3.messagelabs.com id 2E/F1-29649-D9D1E265; Mon, 26 Oct 2015 12:33:33 +0000 X-Env-Sender: samuel.thibault@ens-lyon.org X-Msg-Ref: server-3.tower-31.messagelabs.com!1445862812!24766683!1 X-Originating-IP: [192.134.164.83] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 21901 invoked from network); 26 Oct 2015 12:33:32 -0000 Received: from mail2-relais-roc.national.inria.fr (HELO mail2-relais-roc.national.inria.fr) (192.134.164.83) by server-3.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 12:33:32 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444687200"; d="scan'208";a="184473665" Received: from unknown (HELO var.ipv6) ([193.50.110.121]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/AES128-GCM-SHA256; 26 Oct 2015 13:33:13 +0100 Received: from samy by var.ipv6 with local (Exim 4.86) (envelope-from ) id 1Zqgxc-0007C4-UZ; Mon, 26 Oct 2015 13:33:12 +0100 Date: Mon, 26 Oct 2015 13:33:12 +0100 From: Samuel Thibault To: Wei Liu Message-ID: <20151026123312.GJ19459@var.bordeaux.inria.fr> Mail-Followup-To: Samuel Thibault , Wei Liu , minios-devel@lists.xenproject.org, Xen-devel , Ian Campbell , Ian Jackson References: <1445852868-16532-1-git-send-email-wei.liu2@citrix.com> <20151026120245.GA19459@var.bordeaux.inria.fr> <20151026121442.GD13118@zion.uk.xensource.com> <20151026122151.GC19459@var.bordeaux.inria.fr> <20151026123028.GE13118@zion.uk.xensource.com> MIME-Version: 1.0 Content-Length: 1305 Content-Disposition: inline In-Reply-To: <20151026123028.GE13118@zion.uk.xensource.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Cc: minios-devel@lists.xenproject.org, Xen-devel , Ian Jackson , Ian Campbell Subject: Re: [Minios-devel] [PATCH MINI-OS] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Wei Liu, le Mon 26 Oct 2015 12:30:28 +0000, a =E9crit : > On Mon, Oct 26, 2015 at 01:21:51PM +0100, Samuel Thibault wrote: > > Wei Liu, le Mon 26 Oct 2015 12:14:43 +0000, a =E9crit : > > > In my patch, mini-os notifies remote whenever it consumes a message, > > > which I think it's slightly better because backend can start putting > > > things in the ring as mini-os processes them. > > = > > That makes more notifications, but that can lead to more pipelining > > indeed. That's what the Linux driver does, so let's do the same. > > = > > Also, I'm realizing: aren't we missing a full memory barrier between > > the memcpy_from_ring call and xenstore_buf->rsp_cons +=3D ? (in the two > > places) We need to make sure to have finished copying from the ring > > before writing the new rsp_cons. > > = > = > You're right. > = > I think we should just turn that wmb() into two mb()s and place them > before xenstore_buf->rsp_cons +=3D. We *also* need some barrier between rsp_cons +=3D and the notification, otherwise the notified domain may miss the rsp_cons update and thus believe it was a spurious notification. Samuel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 12:33:35 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 12:33:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqgxz-0004fr-AO; Mon, 26 Oct 2015 12:33:35 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqgxy-0004fi-Bg; Mon, 26 Oct 2015 12:33:34 +0000 Received: from [85.158.137.68] by server-6.bemta-3.messagelabs.com id 2E/F1-29649-D9D1E265; Mon, 26 Oct 2015 12:33:33 +0000 X-Env-Sender: samuel.thibault@ens-lyon.org X-Msg-Ref: server-3.tower-31.messagelabs.com!1445862812!24766683!1 X-Originating-IP: [192.134.164.83] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 21901 invoked from network); 26 Oct 2015 12:33:32 -0000 Received: from mail2-relais-roc.national.inria.fr (HELO mail2-relais-roc.national.inria.fr) (192.134.164.83) by server-3.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 12:33:32 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444687200"; d="scan'208";a="184473665" Received: from unknown (HELO var.ipv6) ([193.50.110.121]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/AES128-GCM-SHA256; 26 Oct 2015 13:33:13 +0100 Received: from samy by var.ipv6 with local (Exim 4.86) (envelope-from ) id 1Zqgxc-0007C4-UZ; Mon, 26 Oct 2015 13:33:12 +0100 Date: Mon, 26 Oct 2015 13:33:12 +0100 From: Samuel Thibault To: Wei Liu Message-ID: <20151026123312.GJ19459@var.bordeaux.inria.fr> Mail-Followup-To: Samuel Thibault , Wei Liu , minios-devel@lists.xenproject.org, Xen-devel , Ian Campbell , Ian Jackson References: <1445852868-16532-1-git-send-email-wei.liu2@citrix.com> <20151026120245.GA19459@var.bordeaux.inria.fr> <20151026121442.GD13118@zion.uk.xensource.com> <20151026122151.GC19459@var.bordeaux.inria.fr> <20151026123028.GE13118@zion.uk.xensource.com> MIME-Version: 1.0 Content-Length: 1305 Content-Disposition: inline In-Reply-To: <20151026123028.GE13118@zion.uk.xensource.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Cc: minios-devel@lists.xenproject.org, Xen-devel , Ian Jackson , Ian Campbell Subject: Re: [Minios-devel] [PATCH MINI-OS] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Wei Liu, le Mon 26 Oct 2015 12:30:28 +0000, a =E9crit : > On Mon, Oct 26, 2015 at 01:21:51PM +0100, Samuel Thibault wrote: > > Wei Liu, le Mon 26 Oct 2015 12:14:43 +0000, a =E9crit : > > > In my patch, mini-os notifies remote whenever it consumes a message, > > > which I think it's slightly better because backend can start putting > > > things in the ring as mini-os processes them. > > = > > That makes more notifications, but that can lead to more pipelining > > indeed. That's what the Linux driver does, so let's do the same. > > = > > Also, I'm realizing: aren't we missing a full memory barrier between > > the memcpy_from_ring call and xenstore_buf->rsp_cons +=3D ? (in the two > > places) We need to make sure to have finished copying from the ring > > before writing the new rsp_cons. > > = > = > You're right. > = > I think we should just turn that wmb() into two mb()s and place them > before xenstore_buf->rsp_cons +=3D. We *also* need some barrier between rsp_cons +=3D and the notification, otherwise the notified domain may miss the rsp_cons update and thus believe it was a spurious notification. Samuel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 12:36:48 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 12:36:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqh16-0004pB-1J; Mon, 26 Oct 2015 12:36:48 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqh15-0004p2-HM; Mon, 26 Oct 2015 12:36:47 +0000 Received: from [193.109.254.147] by server-10.bemta-14.messagelabs.com id E9/52-01143-E5E1E265; Mon, 26 Oct 2015 12:36:46 +0000 X-Env-Sender: prvs=734318897=wei.liu2@citrix.com X-Msg-Ref: server-12.tower-27.messagelabs.com!1445863004!61540929!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 15043 invoked from network); 26 Oct 2015 12:36:46 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-12.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 12:36:46 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444694400"; d="scan'208";a="313323778" Date: Mon, 26 Oct 2015 12:36:42 +0000 From: Wei Liu To: Samuel Thibault , Wei Liu , , Xen-devel , Ian Campbell , "Ian Jackson" Message-ID: <20151026123642.GF13118@zion.uk.xensource.com> References: <1445852868-16532-1-git-send-email-wei.liu2@citrix.com> <20151026120245.GA19459@var.bordeaux.inria.fr> <20151026121442.GD13118@zion.uk.xensource.com> <20151026122151.GC19459@var.bordeaux.inria.fr> <20151026123028.GE13118@zion.uk.xensource.com> <20151026123312.GJ19459@var.bordeaux.inria.fr> MIME-Version: 1.0 Content-Length: 1793 Content-Disposition: inline In-Reply-To: <20151026123312.GJ19459@var.bordeaux.inria.fr> User-Agent: Mutt/1.5.23 (2014-03-12) X-DLP: MIA2 Subject: Re: [Minios-devel] [PATCH MINI-OS] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Mon, Oct 26, 2015 at 01:33:12PM +0100, Samuel Thibault wrote: > Wei Liu, le Mon 26 Oct 2015 12:30:28 +0000, a =E9crit : > > On Mon, Oct 26, 2015 at 01:21:51PM +0100, Samuel Thibault wrote: > > > Wei Liu, le Mon 26 Oct 2015 12:14:43 +0000, a =E9crit : > > > > In my patch, mini-os notifies remote whenever it consumes a message, > > > > which I think it's slightly better because backend can start putting > > > > things in the ring as mini-os processes them. > > > = > > > That makes more notifications, but that can lead to more pipelining > > > indeed. That's what the Linux driver does, so let's do the same. > > > = > > > Also, I'm realizing: aren't we missing a full memory barrier between > > > the memcpy_from_ring call and xenstore_buf->rsp_cons +=3D ? (in the t= wo > > > places) We need to make sure to have finished copying from the ring > > > before writing the new rsp_cons. > > > = > > = > > You're right. > > = > > I think we should just turn that wmb() into two mb()s and place them > > before xenstore_buf->rsp_cons +=3D. > = > We *also* need some barrier between rsp_cons +=3D and the notification, > otherwise the notified domain may miss the rsp_cons update and thus > believe it was a spurious notification. > = Actually notify_remote_via_evtchn normally implies a mb(). But I think I'd stay on the safe side. I will have a wmb() there. :-) Thanks for your review. V2 coming soon. Wei. > Samuel > = > _______________________________________________ > Minios-devel mailing list > Minios-devel@lists.xenproject.org > http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 12:36:48 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 12:36:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqh16-0004pB-1J; Mon, 26 Oct 2015 12:36:48 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqh15-0004p2-HM; Mon, 26 Oct 2015 12:36:47 +0000 Received: from [193.109.254.147] by server-10.bemta-14.messagelabs.com id E9/52-01143-E5E1E265; Mon, 26 Oct 2015 12:36:46 +0000 X-Env-Sender: prvs=734318897=wei.liu2@citrix.com X-Msg-Ref: server-12.tower-27.messagelabs.com!1445863004!61540929!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 15043 invoked from network); 26 Oct 2015 12:36:46 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-12.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 12:36:46 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444694400"; d="scan'208";a="313323778" Date: Mon, 26 Oct 2015 12:36:42 +0000 From: Wei Liu To: Samuel Thibault , Wei Liu , , Xen-devel , Ian Campbell , "Ian Jackson" Message-ID: <20151026123642.GF13118@zion.uk.xensource.com> References: <1445852868-16532-1-git-send-email-wei.liu2@citrix.com> <20151026120245.GA19459@var.bordeaux.inria.fr> <20151026121442.GD13118@zion.uk.xensource.com> <20151026122151.GC19459@var.bordeaux.inria.fr> <20151026123028.GE13118@zion.uk.xensource.com> <20151026123312.GJ19459@var.bordeaux.inria.fr> MIME-Version: 1.0 Content-Length: 1793 Content-Disposition: inline In-Reply-To: <20151026123312.GJ19459@var.bordeaux.inria.fr> User-Agent: Mutt/1.5.23 (2014-03-12) X-DLP: MIA2 Subject: Re: [Minios-devel] [PATCH MINI-OS] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Mon, Oct 26, 2015 at 01:33:12PM +0100, Samuel Thibault wrote: > Wei Liu, le Mon 26 Oct 2015 12:30:28 +0000, a =E9crit : > > On Mon, Oct 26, 2015 at 01:21:51PM +0100, Samuel Thibault wrote: > > > Wei Liu, le Mon 26 Oct 2015 12:14:43 +0000, a =E9crit : > > > > In my patch, mini-os notifies remote whenever it consumes a message, > > > > which I think it's slightly better because backend can start putting > > > > things in the ring as mini-os processes them. > > > = > > > That makes more notifications, but that can lead to more pipelining > > > indeed. That's what the Linux driver does, so let's do the same. > > > = > > > Also, I'm realizing: aren't we missing a full memory barrier between > > > the memcpy_from_ring call and xenstore_buf->rsp_cons +=3D ? (in the t= wo > > > places) We need to make sure to have finished copying from the ring > > > before writing the new rsp_cons. > > > = > > = > > You're right. > > = > > I think we should just turn that wmb() into two mb()s and place them > > before xenstore_buf->rsp_cons +=3D. > = > We *also* need some barrier between rsp_cons +=3D and the notification, > otherwise the notified domain may miss the rsp_cons update and thus > believe it was a spurious notification. > = Actually notify_remote_via_evtchn normally implies a mb(). But I think I'd stay on the safe side. I will have a wmb() there. :-) Thanks for your review. V2 coming soon. Wei. > Samuel > = > _______________________________________________ > Minios-devel mailing list > Minios-devel@lists.xenproject.org > http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 12:49:01 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 12:49:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqhCu-0005Gz-U5; Mon, 26 Oct 2015 12:49:00 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqhCt-0005Gr-61; Mon, 26 Oct 2015 12:48:59 +0000 Received: from [193.109.254.147] by server-6.bemta-14.messagelabs.com id 92/B8-16618-A312E265; Mon, 26 Oct 2015 12:48:58 +0000 X-Env-Sender: prvs=734318897=wei.liu2@citrix.com X-Msg-Ref: server-2.tower-27.messagelabs.com!1445863736!25516343!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 25418 invoked from network); 26 Oct 2015 12:48:57 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-2.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 12:48:57 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444694400"; d="scan'208";a="313327555" From: Wei Liu To: Date: Mon, 26 Oct 2015 12:47:56 +0000 Message-ID: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> X-Mailer: git-send-email 2.1.4 MIME-Version: 1.0 X-DLP: MIA1 Cc: Ian Jackson , Xen-devel , Wei Liu , Ian Campbell , Samuel Thibault Subject: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org The xenbus thread didn't send notification to other end when it expected more data or consumed responses, which led to stalling the ring from time to time. This is the culprit that guest was less responsive when using stubdom because the device model was stalled. Fix this by sending notification to the other end at the right places. Signed-off-by: Wei Liu --- Cc: Ian Campbell Cc: Ian Jackson Cc: Samuel Thibault v2: add two more mb()s. With this path I can migrate a guest with stubdom a few thousand times without any issue, while before I could easily trigger time out within a few iterations. This should make OSSTest stubdom test case more reliable. Ian, this is a patch suitable for backporting to 4.6. It's good time branch mini-os now. --- xenbus/xenbus.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/xenbus/xenbus.c b/xenbus/xenbus.c index 4613ed6..bc669f2 100644 --- a/xenbus/xenbus.c +++ b/xenbus/xenbus.c @@ -205,8 +205,10 @@ static void xenbus_thread_func(void *ign) prod = xenstore_buf->rsp_prod; DEBUG("Rsp_cons %d, rsp_prod %d.\n", xenstore_buf->rsp_cons, xenstore_buf->rsp_prod); - if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < sizeof(msg)) + if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < sizeof(msg)) { + notify_remote_via_evtchn(start_info.store_evtchn); break; + } rmb(); memcpy_from_ring(xenstore_buf->rsp, &msg, @@ -217,8 +219,10 @@ static void xenbus_thread_func(void *ign) xenstore_buf->rsp_prod - xenstore_buf->rsp_cons, msg.req_id); if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < - sizeof(msg) + msg.len) + sizeof(msg) + msg.len) { + notify_remote_via_evtchn(start_info.store_evtchn); break; + } DEBUG("Message is good.\n"); @@ -237,6 +241,7 @@ static void xenbus_thread_func(void *ign) event->path = data; event->token = event->path + strlen(event->path) + 1; + mb(); xenstore_buf->rsp_cons += msg.len + sizeof(msg); for (watch = watches; watch; watch = watch->next) @@ -262,9 +267,13 @@ static void xenbus_thread_func(void *ign) req_info[msg.req_id].reply, MASK_XENSTORE_IDX(xenstore_buf->rsp_cons), msg.len + sizeof(msg)); + mb(); xenstore_buf->rsp_cons += msg.len + sizeof(msg); wake_up(&req_info[msg.req_id].waitq); } + + wmb(); + notify_remote_via_evtchn(start_info.store_evtchn); } } } -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 12:49:01 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 12:49:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqhCu-0005Gz-U5; Mon, 26 Oct 2015 12:49:00 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqhCt-0005Gr-61; Mon, 26 Oct 2015 12:48:59 +0000 Received: from [193.109.254.147] by server-6.bemta-14.messagelabs.com id 92/B8-16618-A312E265; Mon, 26 Oct 2015 12:48:58 +0000 X-Env-Sender: prvs=734318897=wei.liu2@citrix.com X-Msg-Ref: server-2.tower-27.messagelabs.com!1445863736!25516343!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 25418 invoked from network); 26 Oct 2015 12:48:57 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-2.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 12:48:57 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444694400"; d="scan'208";a="313327555" From: Wei Liu To: Date: Mon, 26 Oct 2015 12:47:56 +0000 Message-ID: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> X-Mailer: git-send-email 2.1.4 MIME-Version: 1.0 X-DLP: MIA1 Cc: Ian Jackson , Xen-devel , Wei Liu , Ian Campbell , Samuel Thibault Subject: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org The xenbus thread didn't send notification to other end when it expected more data or consumed responses, which led to stalling the ring from time to time. This is the culprit that guest was less responsive when using stubdom because the device model was stalled. Fix this by sending notification to the other end at the right places. Signed-off-by: Wei Liu --- Cc: Ian Campbell Cc: Ian Jackson Cc: Samuel Thibault v2: add two more mb()s. With this path I can migrate a guest with stubdom a few thousand times without any issue, while before I could easily trigger time out within a few iterations. This should make OSSTest stubdom test case more reliable. Ian, this is a patch suitable for backporting to 4.6. It's good time branch mini-os now. --- xenbus/xenbus.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/xenbus/xenbus.c b/xenbus/xenbus.c index 4613ed6..bc669f2 100644 --- a/xenbus/xenbus.c +++ b/xenbus/xenbus.c @@ -205,8 +205,10 @@ static void xenbus_thread_func(void *ign) prod = xenstore_buf->rsp_prod; DEBUG("Rsp_cons %d, rsp_prod %d.\n", xenstore_buf->rsp_cons, xenstore_buf->rsp_prod); - if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < sizeof(msg)) + if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < sizeof(msg)) { + notify_remote_via_evtchn(start_info.store_evtchn); break; + } rmb(); memcpy_from_ring(xenstore_buf->rsp, &msg, @@ -217,8 +219,10 @@ static void xenbus_thread_func(void *ign) xenstore_buf->rsp_prod - xenstore_buf->rsp_cons, msg.req_id); if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < - sizeof(msg) + msg.len) + sizeof(msg) + msg.len) { + notify_remote_via_evtchn(start_info.store_evtchn); break; + } DEBUG("Message is good.\n"); @@ -237,6 +241,7 @@ static void xenbus_thread_func(void *ign) event->path = data; event->token = event->path + strlen(event->path) + 1; + mb(); xenstore_buf->rsp_cons += msg.len + sizeof(msg); for (watch = watches; watch; watch = watch->next) @@ -262,9 +267,13 @@ static void xenbus_thread_func(void *ign) req_info[msg.req_id].reply, MASK_XENSTORE_IDX(xenstore_buf->rsp_cons), msg.len + sizeof(msg)); + mb(); xenstore_buf->rsp_cons += msg.len + sizeof(msg); wake_up(&req_info[msg.req_id].waitq); } + + wmb(); + notify_remote_via_evtchn(start_info.store_evtchn); } } } -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 12:52:51 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 12:52:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqhGd-0005RX-0N; Mon, 26 Oct 2015 12:52:51 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqhGb-0005RI-VI; Mon, 26 Oct 2015 12:52:50 +0000 Received: from [85.158.139.211] by server-9.bemta-5.messagelabs.com id 7E/56-30270-1222E265; Mon, 26 Oct 2015 12:52:49 +0000 X-Env-Sender: samuel.thibault@ens-lyon.org X-Msg-Ref: server-14.tower-206.messagelabs.com!1445863968!39703002!1 X-Originating-IP: [192.134.164.104] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 21699 invoked from network); 26 Oct 2015 12:52:48 -0000 Received: from mail3-relais-sop.national.inria.fr (HELO mail3-relais-sop.national.inria.fr) (192.134.164.104) by server-14.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 12:52:48 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444687200"; d="scan'208";a="151768997" Received: from unknown (HELO var.ipv6) ([193.50.110.121]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/AES128-GCM-SHA256; 26 Oct 2015 13:52:47 +0100 Received: from samy by var.ipv6 with local (Exim 4.86) (envelope-from ) id 1ZqhGZ-0007vp-Gs; Mon, 26 Oct 2015 13:52:47 +0100 Date: Mon, 26 Oct 2015 13:52:47 +0100 From: Samuel Thibault To: Wei Liu Message-ID: <20151026125247.GP19459@var.bordeaux.inria.fr> Mail-Followup-To: Samuel Thibault , Wei Liu , minios-devel@lists.xenproject.org, Xen-devel , Ian Campbell , Ian Jackson References: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> MIME-Version: 1.0 Content-Length: 992 Content-Disposition: inline In-Reply-To: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Cc: minios-devel@lists.xenproject.org, Xen-devel , Ian Jackson , Ian Campbell Subject: Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Wei Liu, le Mon 26 Oct 2015 12:47:56 +0000, a =E9crit : > - if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < sizeof= (msg)) > + if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < sizeof= (msg)) { > + notify_remote_via_evtchn(start_info.store_evtchn); > break; > + } > if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < > - sizeof(msg) + msg.len) > + sizeof(msg) + msg.len) { > + notify_remote_via_evtchn(start_info.store_evtchn); Actually thinking... In principle we should not need these two notifications: we have already notified last time we consumed a message. Notifying again shouldn't be bringing anything new. Do you actually see a difference with these? Samuel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 12:52:51 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 12:52:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqhGd-0005RX-0N; Mon, 26 Oct 2015 12:52:51 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqhGb-0005RI-VI; Mon, 26 Oct 2015 12:52:50 +0000 Received: from [85.158.139.211] by server-9.bemta-5.messagelabs.com id 7E/56-30270-1222E265; Mon, 26 Oct 2015 12:52:49 +0000 X-Env-Sender: samuel.thibault@ens-lyon.org X-Msg-Ref: server-14.tower-206.messagelabs.com!1445863968!39703002!1 X-Originating-IP: [192.134.164.104] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 21699 invoked from network); 26 Oct 2015 12:52:48 -0000 Received: from mail3-relais-sop.national.inria.fr (HELO mail3-relais-sop.national.inria.fr) (192.134.164.104) by server-14.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 12:52:48 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444687200"; d="scan'208";a="151768997" Received: from unknown (HELO var.ipv6) ([193.50.110.121]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/AES128-GCM-SHA256; 26 Oct 2015 13:52:47 +0100 Received: from samy by var.ipv6 with local (Exim 4.86) (envelope-from ) id 1ZqhGZ-0007vp-Gs; Mon, 26 Oct 2015 13:52:47 +0100 Date: Mon, 26 Oct 2015 13:52:47 +0100 From: Samuel Thibault To: Wei Liu Message-ID: <20151026125247.GP19459@var.bordeaux.inria.fr> Mail-Followup-To: Samuel Thibault , Wei Liu , minios-devel@lists.xenproject.org, Xen-devel , Ian Campbell , Ian Jackson References: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> MIME-Version: 1.0 Content-Length: 992 Content-Disposition: inline In-Reply-To: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Cc: minios-devel@lists.xenproject.org, Xen-devel , Ian Jackson , Ian Campbell Subject: Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Wei Liu, le Mon 26 Oct 2015 12:47:56 +0000, a =E9crit : > - if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < sizeof= (msg)) > + if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < sizeof= (msg)) { > + notify_remote_via_evtchn(start_info.store_evtchn); > break; > + } > if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < > - sizeof(msg) + msg.len) > + sizeof(msg) + msg.len) { > + notify_remote_via_evtchn(start_info.store_evtchn); Actually thinking... In principle we should not need these two notifications: we have already notified last time we consumed a message. Notifying again shouldn't be bringing anything new. Do you actually see a difference with these? Samuel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 13:55:39 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 13:55:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqiFN-0007hu-NE; Mon, 26 Oct 2015 13:55:37 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqiFM-0007hm-UX; Mon, 26 Oct 2015 13:55:37 +0000 Received: from [85.158.137.68] by server-9.bemta-3.messagelabs.com id 0E/8A-10678-8D03E265; Mon, 26 Oct 2015 13:55:36 +0000 X-Env-Sender: prvs=734318897=wei.liu2@citrix.com X-Msg-Ref: server-4.tower-31.messagelabs.com!1445867733!55521609!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 14734 invoked from network); 26 Oct 2015 13:55:35 -0000 Received: from smtp.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-4.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 13:55:35 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444694400"; d="scan'208";a="313357915" Date: Mon, 26 Oct 2015 13:55:31 +0000 From: Wei Liu To: Samuel Thibault , Wei Liu , , Xen-devel , Ian Campbell , "Ian Jackson" Message-ID: <20151026135531.GG13118@zion.uk.xensource.com> References: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> <20151026125247.GP19459@var.bordeaux.inria.fr> MIME-Version: 1.0 Content-Length: 1368 Content-Disposition: inline In-Reply-To: <20151026125247.GP19459@var.bordeaux.inria.fr> User-Agent: Mutt/1.5.23 (2014-03-12) X-DLP: MIA2 Subject: Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Mon, Oct 26, 2015 at 01:52:47PM +0100, Samuel Thibault wrote: > Wei Liu, le Mon 26 Oct 2015 12:47:56 +0000, a =E9crit : > > - if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < size= of(msg)) > > + if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < size= of(msg)) { > > + notify_remote_via_evtchn(start_info.store_evtchn); > > break; > > + } > = > > if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < > > - sizeof(msg) + msg.len) > > + sizeof(msg) + msg.len) { > > + notify_remote_via_evtchn(start_info.store_evtchn); > = > Actually thinking... In principle we should not need these two > notifications: we have already notified last time we consumed a message. > Notifying again shouldn't be bringing anything new. Do you actually see > a difference with these? > = Yes. The ring still gets stalled somehow without those two notifications. Wei. > Samuel > = > _______________________________________________ > Minios-devel mailing list > Minios-devel@lists.xenproject.org > http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 13:55:39 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 13:55:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqiFN-0007hu-NE; Mon, 26 Oct 2015 13:55:37 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqiFM-0007hm-UX; Mon, 26 Oct 2015 13:55:37 +0000 Received: from [85.158.137.68] by server-9.bemta-3.messagelabs.com id 0E/8A-10678-8D03E265; Mon, 26 Oct 2015 13:55:36 +0000 X-Env-Sender: prvs=734318897=wei.liu2@citrix.com X-Msg-Ref: server-4.tower-31.messagelabs.com!1445867733!55521609!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 14734 invoked from network); 26 Oct 2015 13:55:35 -0000 Received: from smtp.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-4.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 13:55:35 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444694400"; d="scan'208";a="313357915" Date: Mon, 26 Oct 2015 13:55:31 +0000 From: Wei Liu To: Samuel Thibault , Wei Liu , , Xen-devel , Ian Campbell , "Ian Jackson" Message-ID: <20151026135531.GG13118@zion.uk.xensource.com> References: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> <20151026125247.GP19459@var.bordeaux.inria.fr> MIME-Version: 1.0 Content-Length: 1368 Content-Disposition: inline In-Reply-To: <20151026125247.GP19459@var.bordeaux.inria.fr> User-Agent: Mutt/1.5.23 (2014-03-12) X-DLP: MIA2 Subject: Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Mon, Oct 26, 2015 at 01:52:47PM +0100, Samuel Thibault wrote: > Wei Liu, le Mon 26 Oct 2015 12:47:56 +0000, a =E9crit : > > - if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < size= of(msg)) > > + if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < size= of(msg)) { > > + notify_remote_via_evtchn(start_info.store_evtchn); > > break; > > + } > = > > if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < > > - sizeof(msg) + msg.len) > > + sizeof(msg) + msg.len) { > > + notify_remote_via_evtchn(start_info.store_evtchn); > = > Actually thinking... In principle we should not need these two > notifications: we have already notified last time we consumed a message. > Notifying again shouldn't be bringing anything new. Do you actually see > a difference with these? > = Yes. The ring still gets stalled somehow without those two notifications. Wei. > Samuel > = > _______________________________________________ > Minios-devel mailing list > Minios-devel@lists.xenproject.org > http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 14:43:49 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 14:43:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqj01-00019Q-0p; Mon, 26 Oct 2015 14:43:49 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqizy-00019A-NE for minios-devel@lists.xenproject.org; Mon, 26 Oct 2015 14:43:46 +0000 Received: from [85.158.139.211] by server-12.bemta-5.messagelabs.com id A1/30-12831-22C3E265; Mon, 26 Oct 2015 14:43:46 +0000 X-Env-Sender: prvs=734318897=wei.liu2@citrix.com X-Msg-Ref: server-8.tower-206.messagelabs.com!1445870622!45146474!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 20249 invoked from network); 26 Oct 2015 14:43:44 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-8.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 14:43:44 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444694400"; d="scan'208";a="313386202" Date: Mon, 26 Oct 2015 14:43:08 +0000 From: Wei Liu To: Ian Campbell Message-ID: <20151026144308.GI13118@zion.uk.xensource.com> References: <1445440941.9563.163.camel@citrix.com> <1445441059-26083-1-git-send-email-ian.campbell@citrix.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1445441059-26083-1-git-send-email-ian.campbell@citrix.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-DLP: MIA1 Cc: minios-devel@lists.xenproject.org, wei.liu2@citrix.com, ian.jackson@eu.citrix.com, samuel.thibault@ens-lyon.org, xen-devel@lists.xen.org Subject: Re: [Minios-devel] [PATCH MINI-OS v4 0/5] Begin to disentangle libxenctrl and provide some stable libraries X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Wed, Oct 21, 2015 at 04:24:14PM +0100, Ian Campbell wrote: > We intend to stabilise some parts of the libxenctrl interface by > splitting out some functionality into separate stable libraries. > > This is the mini-os part of the first phase of that change. > > This mail is (or is intended to be) a reply to a "0/" > super-intro mail covering all of the related patch series and which > contains more details. > > Ian Campbell (5): > mini-os: Include libxentoollog with libxc > mini-os: Include libxenevtchn with libxc > mini-os: Include libxengnttab with libxc > mini-os: Include libxencall with libxc > mini-os: Include libxenforeignmemory with libxc > > Makefile | 5 +++++ > 1 file changed, 5 insertions(+) Acked-by: Wei Liu > > -- > 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 14:43:49 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 14:43:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqj01-00019Q-0p; Mon, 26 Oct 2015 14:43:49 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqizy-00019A-NE for minios-devel@lists.xenproject.org; Mon, 26 Oct 2015 14:43:46 +0000 Received: from [85.158.139.211] by server-12.bemta-5.messagelabs.com id A1/30-12831-22C3E265; Mon, 26 Oct 2015 14:43:46 +0000 X-Env-Sender: prvs=734318897=wei.liu2@citrix.com X-Msg-Ref: server-8.tower-206.messagelabs.com!1445870622!45146474!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 20249 invoked from network); 26 Oct 2015 14:43:44 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-8.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 14:43:44 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444694400"; d="scan'208";a="313386202" Date: Mon, 26 Oct 2015 14:43:08 +0000 From: Wei Liu To: Ian Campbell Message-ID: <20151026144308.GI13118@zion.uk.xensource.com> References: <1445440941.9563.163.camel@citrix.com> <1445441059-26083-1-git-send-email-ian.campbell@citrix.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1445441059-26083-1-git-send-email-ian.campbell@citrix.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-DLP: MIA1 Cc: minios-devel@lists.xenproject.org, wei.liu2@citrix.com, ian.jackson@eu.citrix.com, samuel.thibault@ens-lyon.org, xen-devel@lists.xen.org Subject: Re: [Minios-devel] [PATCH MINI-OS v4 0/5] Begin to disentangle libxenctrl and provide some stable libraries X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Wed, Oct 21, 2015 at 04:24:14PM +0100, Ian Campbell wrote: > We intend to stabilise some parts of the libxenctrl interface by > splitting out some functionality into separate stable libraries. > > This is the mini-os part of the first phase of that change. > > This mail is (or is intended to be) a reply to a "0/" > super-intro mail covering all of the related patch series and which > contains more details. > > Ian Campbell (5): > mini-os: Include libxentoollog with libxc > mini-os: Include libxenevtchn with libxc > mini-os: Include libxengnttab with libxc > mini-os: Include libxencall with libxc > mini-os: Include libxenforeignmemory with libxc > > Makefile | 5 +++++ > 1 file changed, 5 insertions(+) Acked-by: Wei Liu > > -- > 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 15:17:26 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 15:17:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqjWX-00037H-Ey; Mon, 26 Oct 2015 15:17:25 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqjWW-000379-1H; Mon, 26 Oct 2015 15:17:24 +0000 Received: from [85.158.139.211] by server-3.bemta-5.messagelabs.com id ED/C2-06179-3044E265; Mon, 26 Oct 2015 15:17:23 +0000 X-Env-Sender: prvs=734ef5dec=Ian.Jackson@citrix.com X-Msg-Ref: server-14.tower-206.messagelabs.com!1445872640!39758546!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 19981 invoked from network); 26 Oct 2015 15:17:22 -0000 Received: from smtp.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-14.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 15:17:22 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444694400"; d="scan'208";a="313405077" From: Ian Jackson MIME-Version: 1.0 Message-ID: <22062.17367.954510.346644@mariner.uk.xensource.com> Date: Mon, 26 Oct 2015 15:16:39 +0000 To: Wei Liu In-Reply-To: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> References: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> X-Mailer: VM 8.1.0 under 23.4.1 (i486-pc-linux-gnu) X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, Xen-devel , Ian Campbell , Samuel Thibault Subject: Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Wei Liu writes ("[PATCH MINI-OS v2] xenbus: notify the other end when necessary"): > The xenbus thread didn't send notification to other end when it expected > more data or consumed responses, which led to stalling the ring from > time to time. Thanks for investigating this. I haven't attempted to prove correct (or incorrect) the ring handling after this patch. But: > This is the culprit that guest was less responsive when using stubdom > because the device model was stalled. ISTM with my stable tree maintainer hat on that this is a good backport candidate. Ian. _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 15:17:26 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 15:17:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqjWX-00037H-Ey; Mon, 26 Oct 2015 15:17:25 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqjWW-000379-1H; Mon, 26 Oct 2015 15:17:24 +0000 Received: from [85.158.139.211] by server-3.bemta-5.messagelabs.com id ED/C2-06179-3044E265; Mon, 26 Oct 2015 15:17:23 +0000 X-Env-Sender: prvs=734ef5dec=Ian.Jackson@citrix.com X-Msg-Ref: server-14.tower-206.messagelabs.com!1445872640!39758546!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 19981 invoked from network); 26 Oct 2015 15:17:22 -0000 Received: from smtp.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-14.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 15:17:22 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444694400"; d="scan'208";a="313405077" From: Ian Jackson MIME-Version: 1.0 Message-ID: <22062.17367.954510.346644@mariner.uk.xensource.com> Date: Mon, 26 Oct 2015 15:16:39 +0000 To: Wei Liu In-Reply-To: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> References: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> X-Mailer: VM 8.1.0 under 23.4.1 (i486-pc-linux-gnu) X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, Xen-devel , Ian Campbell , Samuel Thibault Subject: Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Wei Liu writes ("[PATCH MINI-OS v2] xenbus: notify the other end when necessary"): > The xenbus thread didn't send notification to other end when it expected > more data or consumed responses, which led to stalling the ring from > time to time. Thanks for investigating this. I haven't attempted to prove correct (or incorrect) the ring handling after this patch. But: > This is the culprit that guest was less responsive when using stubdom > because the device model was stalled. ISTM with my stable tree maintainer hat on that this is a good backport candidate. Ian. _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 16:30:05 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 16:30:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqker-0001gl-Ae; Mon, 26 Oct 2015 16:30:05 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqkeq-0001gX-Ba; Mon, 26 Oct 2015 16:30:04 +0000 Received: from [193.109.254.147] by server-14.bemta-14.messagelabs.com id DC/B1-04752-B055E265; Mon, 26 Oct 2015 16:30:03 +0000 X-Env-Sender: samuel.thibault@ens-lyon.org X-Msg-Ref: server-16.tower-27.messagelabs.com!1445877002!29273802!1 X-Originating-IP: [192.134.164.104] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 595 invoked from network); 26 Oct 2015 16:30:03 -0000 Received: from mail3-relais-sop.national.inria.fr (HELO mail3-relais-sop.national.inria.fr) (192.134.164.104) by server-16.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 16:30:03 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444687200"; d="scan'208";a="151795345" Received: from unknown (HELO var.ipv6) ([193.50.110.121]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/AES128-GCM-SHA256; 26 Oct 2015 17:30:01 +0100 Received: from samy by var.ipv6 with local (Exim 4.86) (envelope-from ) id 1Zqken-0006lR-Mt; Mon, 26 Oct 2015 17:30:01 +0100 Date: Mon, 26 Oct 2015 17:30:01 +0100 From: Samuel Thibault To: Wei Liu Message-ID: <20151026163001.GF18602@var.bordeaux.inria.fr> Mail-Followup-To: Samuel Thibault , Wei Liu , minios-devel@lists.xenproject.org, Xen-devel , Ian Campbell , Ian Jackson References: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> <20151026125247.GP19459@var.bordeaux.inria.fr> <20151026135531.GG13118@zion.uk.xensource.com> MIME-Version: 1.0 Content-Length: 1573 Content-Disposition: inline In-Reply-To: <20151026135531.GG13118@zion.uk.xensource.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Cc: minios-devel@lists.xenproject.org, Xen-devel , Ian Jackson , Ian Campbell Subject: Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Wei Liu, le Mon 26 Oct 2015 13:55:31 +0000, a =E9crit : > On Mon, Oct 26, 2015 at 01:52:47PM +0100, Samuel Thibault wrote: > > Wei Liu, le Mon 26 Oct 2015 12:47:56 +0000, a =E9crit : > > > - if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < si= zeof(msg)) > > > + if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < si= zeof(msg)) { > > > + notify_remote_via_evtchn(start_info.store_evtchn); > > > break; > > > + } > > = > > > if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < > > > - sizeof(msg) + msg.len) > > > + sizeof(msg) + msg.len) { > > > + notify_remote_via_evtchn(start_info.store_evtchn); > > = > > Actually thinking... In principle we should not need these two > > notifications: we have already notified last time we consumed a message. > > Notifying again shouldn't be bringing anything new. Do you actually see > > a difference with these? > > = > = > Yes. The ring still gets stalled somehow without those two > notifications. Ok... This is still very worrying. The more I'm thinking about it, the more I believe we shouldn't *have* to do this. Which version of the xenstore are you testing with, exactly? I guess that while we investigate this oddness we can apply this fix to stable trees, so as to be safer than sorry. Samuel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 16:30:05 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 16:30:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqker-0001gl-Ae; Mon, 26 Oct 2015 16:30:05 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqkeq-0001gX-Ba; Mon, 26 Oct 2015 16:30:04 +0000 Received: from [193.109.254.147] by server-14.bemta-14.messagelabs.com id DC/B1-04752-B055E265; Mon, 26 Oct 2015 16:30:03 +0000 X-Env-Sender: samuel.thibault@ens-lyon.org X-Msg-Ref: server-16.tower-27.messagelabs.com!1445877002!29273802!1 X-Originating-IP: [192.134.164.104] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 595 invoked from network); 26 Oct 2015 16:30:03 -0000 Received: from mail3-relais-sop.national.inria.fr (HELO mail3-relais-sop.national.inria.fr) (192.134.164.104) by server-16.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 16:30:03 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444687200"; d="scan'208";a="151795345" Received: from unknown (HELO var.ipv6) ([193.50.110.121]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/AES128-GCM-SHA256; 26 Oct 2015 17:30:01 +0100 Received: from samy by var.ipv6 with local (Exim 4.86) (envelope-from ) id 1Zqken-0006lR-Mt; Mon, 26 Oct 2015 17:30:01 +0100 Date: Mon, 26 Oct 2015 17:30:01 +0100 From: Samuel Thibault To: Wei Liu Message-ID: <20151026163001.GF18602@var.bordeaux.inria.fr> Mail-Followup-To: Samuel Thibault , Wei Liu , minios-devel@lists.xenproject.org, Xen-devel , Ian Campbell , Ian Jackson References: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> <20151026125247.GP19459@var.bordeaux.inria.fr> <20151026135531.GG13118@zion.uk.xensource.com> MIME-Version: 1.0 Content-Length: 1573 Content-Disposition: inline In-Reply-To: <20151026135531.GG13118@zion.uk.xensource.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Cc: minios-devel@lists.xenproject.org, Xen-devel , Ian Jackson , Ian Campbell Subject: Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Wei Liu, le Mon 26 Oct 2015 13:55:31 +0000, a =E9crit : > On Mon, Oct 26, 2015 at 01:52:47PM +0100, Samuel Thibault wrote: > > Wei Liu, le Mon 26 Oct 2015 12:47:56 +0000, a =E9crit : > > > - if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < si= zeof(msg)) > > > + if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < si= zeof(msg)) { > > > + notify_remote_via_evtchn(start_info.store_evtchn); > > > break; > > > + } > > = > > > if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < > > > - sizeof(msg) + msg.len) > > > + sizeof(msg) + msg.len) { > > > + notify_remote_via_evtchn(start_info.store_evtchn); > > = > > Actually thinking... In principle we should not need these two > > notifications: we have already notified last time we consumed a message. > > Notifying again shouldn't be bringing anything new. Do you actually see > > a difference with these? > > = > = > Yes. The ring still gets stalled somehow without those two > notifications. Ok... This is still very worrying. The more I'm thinking about it, the more I believe we shouldn't *have* to do this. Which version of the xenstore are you testing with, exactly? I guess that while we investigate this oddness we can apply this fix to stable trees, so as to be safer than sorry. Samuel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 16:32:16 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 16:32:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqkgx-00020Q-W2; Mon, 26 Oct 2015 16:32:15 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqkgw-00020A-SU; Mon, 26 Oct 2015 16:32:14 +0000 Received: from [85.158.137.68] by server-13.bemta-3.messagelabs.com id 18/01-00536-E855E265; Mon, 26 Oct 2015 16:32:14 +0000 X-Env-Sender: prvs=734ef5dec=Ian.Jackson@citrix.com X-Msg-Ref: server-4.tower-31.messagelabs.com!1445877132!55589152!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 31191 invoked from network); 26 Oct 2015 16:32:13 -0000 Received: from unknown (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-4.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 16:32:13 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444694400"; d="scan'208";a="308293670" From: Ian Jackson MIME-Version: 1.0 Message-ID: <22062.21898.162478.153744@mariner.uk.xensource.com> Date: Mon, 26 Oct 2015 16:32:10 +0000 To: Samuel Thibault In-Reply-To: <20151026163001.GF18602@var.bordeaux.inria.fr> References: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> <20151026125247.GP19459@var.bordeaux.inria.fr> <20151026135531.GG13118@zion.uk.xensource.com> <20151026163001.GF18602@var.bordeaux.inria.fr> X-Mailer: VM 8.1.0 under 23.4.1 (i486-pc-linux-gnu) X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, Xen-devel , Wei Liu , Ian Campbell Subject: Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Samuel Thibault writes ("Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary"): > Ok... This is still very worrying. The more I'm thinking about it, > the more I believe we shouldn't *have* to do this. Which version of > the xenstore are you testing with, exactly? I guess that while we > investigate this oddness we can apply this fix to stable trees, so as to > be safer than sorry. I would rather have only a proper fix for the stable trees, that we have confidence in. So I'll wait. Would one of you let me know if you need me to stare hard at the ring handling ? Ian. _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 16:32:16 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 16:32:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqkgx-00020Q-W2; Mon, 26 Oct 2015 16:32:15 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqkgw-00020A-SU; Mon, 26 Oct 2015 16:32:14 +0000 Received: from [85.158.137.68] by server-13.bemta-3.messagelabs.com id 18/01-00536-E855E265; Mon, 26 Oct 2015 16:32:14 +0000 X-Env-Sender: prvs=734ef5dec=Ian.Jackson@citrix.com X-Msg-Ref: server-4.tower-31.messagelabs.com!1445877132!55589152!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 31191 invoked from network); 26 Oct 2015 16:32:13 -0000 Received: from unknown (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-4.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 16:32:13 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444694400"; d="scan'208";a="308293670" From: Ian Jackson MIME-Version: 1.0 Message-ID: <22062.21898.162478.153744@mariner.uk.xensource.com> Date: Mon, 26 Oct 2015 16:32:10 +0000 To: Samuel Thibault In-Reply-To: <20151026163001.GF18602@var.bordeaux.inria.fr> References: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> <20151026125247.GP19459@var.bordeaux.inria.fr> <20151026135531.GG13118@zion.uk.xensource.com> <20151026163001.GF18602@var.bordeaux.inria.fr> X-Mailer: VM 8.1.0 under 23.4.1 (i486-pc-linux-gnu) X-DLP: MIA2 Cc: minios-devel@lists.xenproject.org, Xen-devel , Wei Liu , Ian Campbell Subject: Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Samuel Thibault writes ("Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary"): > Ok... This is still very worrying. The more I'm thinking about it, > the more I believe we shouldn't *have* to do this. Which version of > the xenstore are you testing with, exactly? I guess that while we > investigate this oddness we can apply this fix to stable trees, so as to > be safer than sorry. I would rather have only a proper fix for the stable trees, that we have confidence in. So I'll wait. Would one of you let me know if you need me to stare hard at the ring handling ? Ian. _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 16:37:57 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 16:37:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqkmT-0002Rx-39; Mon, 26 Oct 2015 16:37:57 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqkmR-0002Ri-RL; Mon, 26 Oct 2015 16:37:55 +0000 Received: from [85.158.137.68] by server-9.bemta-3.messagelabs.com id A1/80-10678-3E65E265; Mon, 26 Oct 2015 16:37:55 +0000 X-Env-Sender: samuel.thibault@ens-lyon.org X-Msg-Ref: server-10.tower-31.messagelabs.com!1445877472!56839225!1 X-Originating-IP: [192.134.164.104] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 27366 invoked from network); 26 Oct 2015 16:37:52 -0000 Received: from mail3-relais-sop.national.inria.fr (HELO mail3-relais-sop.national.inria.fr) (192.134.164.104) by server-10.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 16:37:52 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444687200"; d="scan'208";a="151796087" Received: from unknown (HELO var.ipv6) ([193.50.110.121]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/AES128-GCM-SHA256; 26 Oct 2015 17:37:52 +0100 Received: from samy by var.ipv6 with local (Exim 4.86) (envelope-from ) id 1ZqkmN-0006va-UY; Mon, 26 Oct 2015 17:37:51 +0100 Date: Mon, 26 Oct 2015 17:37:51 +0100 From: Samuel Thibault To: Ian Jackson Message-ID: <20151026163751.GH18602@var.bordeaux.inria.fr> Mail-Followup-To: Samuel Thibault , Ian Jackson , Wei Liu , minios-devel@lists.xenproject.org, Xen-devel , Ian Campbell References: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> <20151026125247.GP19459@var.bordeaux.inria.fr> <20151026135531.GG13118@zion.uk.xensource.com> <20151026163001.GF18602@var.bordeaux.inria.fr> <22062.21898.162478.153744@mariner.uk.xensource.com> MIME-Version: 1.0 Content-Length: 975 Content-Disposition: inline In-Reply-To: <22062.21898.162478.153744@mariner.uk.xensource.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Cc: minios-devel@lists.xenproject.org, Xen-devel , Wei Liu , Ian Campbell Subject: Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Ian Jackson, le Mon 26 Oct 2015 16:32:10 +0000, a =E9crit : > Samuel Thibault writes ("Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: no= tify the other end when necessary"): > > Ok... This is still very worrying. The more I'm thinking about it, > > the more I believe we shouldn't *have* to do this. Which version of > > the xenstore are you testing with, exactly? I guess that while we > > investigate this oddness we can apply this fix to stable trees, so as to > > be safer than sorry. > = > I would rather have only a proper fix for the stable trees, that we > have confidence in. So I'll wait. Well, at least the patch can not hurt. > Would one of you let me know if you need me to stare hard at the ring > handling ? Let's check which version we need to stare hard at first :) Samuel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 16:37:57 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 16:37:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqkmT-0002Rx-39; Mon, 26 Oct 2015 16:37:57 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqkmR-0002Ri-RL; Mon, 26 Oct 2015 16:37:55 +0000 Received: from [85.158.137.68] by server-9.bemta-3.messagelabs.com id A1/80-10678-3E65E265; Mon, 26 Oct 2015 16:37:55 +0000 X-Env-Sender: samuel.thibault@ens-lyon.org X-Msg-Ref: server-10.tower-31.messagelabs.com!1445877472!56839225!1 X-Originating-IP: [192.134.164.104] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 27366 invoked from network); 26 Oct 2015 16:37:52 -0000 Received: from mail3-relais-sop.national.inria.fr (HELO mail3-relais-sop.national.inria.fr) (192.134.164.104) by server-10.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 16:37:52 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444687200"; d="scan'208";a="151796087" Received: from unknown (HELO var.ipv6) ([193.50.110.121]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/AES128-GCM-SHA256; 26 Oct 2015 17:37:52 +0100 Received: from samy by var.ipv6 with local (Exim 4.86) (envelope-from ) id 1ZqkmN-0006va-UY; Mon, 26 Oct 2015 17:37:51 +0100 Date: Mon, 26 Oct 2015 17:37:51 +0100 From: Samuel Thibault To: Ian Jackson Message-ID: <20151026163751.GH18602@var.bordeaux.inria.fr> Mail-Followup-To: Samuel Thibault , Ian Jackson , Wei Liu , minios-devel@lists.xenproject.org, Xen-devel , Ian Campbell References: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> <20151026125247.GP19459@var.bordeaux.inria.fr> <20151026135531.GG13118@zion.uk.xensource.com> <20151026163001.GF18602@var.bordeaux.inria.fr> <22062.21898.162478.153744@mariner.uk.xensource.com> MIME-Version: 1.0 Content-Length: 975 Content-Disposition: inline In-Reply-To: <22062.21898.162478.153744@mariner.uk.xensource.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Cc: minios-devel@lists.xenproject.org, Xen-devel , Wei Liu , Ian Campbell Subject: Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Ian Jackson, le Mon 26 Oct 2015 16:32:10 +0000, a =E9crit : > Samuel Thibault writes ("Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: no= tify the other end when necessary"): > > Ok... This is still very worrying. The more I'm thinking about it, > > the more I believe we shouldn't *have* to do this. Which version of > > the xenstore are you testing with, exactly? I guess that while we > > investigate this oddness we can apply this fix to stable trees, so as to > > be safer than sorry. > = > I would rather have only a proper fix for the stable trees, that we > have confidence in. So I'll wait. Well, at least the patch can not hurt. > Would one of you let me know if you need me to stare hard at the ring > handling ? Let's check which version we need to stare hard at first :) Samuel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 16:41:21 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 16:41:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqkpl-0002up-3v; Mon, 26 Oct 2015 16:41:21 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqkpj-0002uW-I1; Mon, 26 Oct 2015 16:41:19 +0000 Received: from [85.158.137.68] by server-1.bemta-3.messagelabs.com id 9F/EC-01421-EA75E265; Mon, 26 Oct 2015 16:41:18 +0000 X-Env-Sender: prvs=734318897=wei.liu2@citrix.com X-Msg-Ref: server-11.tower-31.messagelabs.com!1445877676!24057142!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 940 invoked from network); 26 Oct 2015 16:41:18 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-11.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 16:41:18 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444694400"; d="scan'208";a="313450611" Date: Mon, 26 Oct 2015 16:41:15 +0000 From: Wei Liu To: Samuel Thibault , Ian Jackson , Wei Liu , , Xen-devel , Ian Campbell Message-ID: <20151026164115.GE19925@zion.uk.xensource.com> References: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> <20151026125247.GP19459@var.bordeaux.inria.fr> <20151026135531.GG13118@zion.uk.xensource.com> <20151026163001.GF18602@var.bordeaux.inria.fr> <22062.21898.162478.153744@mariner.uk.xensource.com> <20151026163751.GH18602@var.bordeaux.inria.fr> MIME-Version: 1.0 Content-Length: 1219 Content-Disposition: inline In-Reply-To: <20151026163751.GH18602@var.bordeaux.inria.fr> User-Agent: Mutt/1.5.23 (2014-03-12) X-DLP: MIA2 Subject: Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Mon, Oct 26, 2015 at 05:37:51PM +0100, Samuel Thibault wrote: > Ian Jackson, le Mon 26 Oct 2015 16:32:10 +0000, a =E9crit : > > Samuel Thibault writes ("Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: = notify the other end when necessary"): > > > Ok... This is still very worrying. The more I'm thinking about it, > > > the more I believe we shouldn't *have* to do this. Which version of > > > the xenstore are you testing with, exactly? I guess that while we > > > investigate this oddness we can apply this fix to stable trees, so as= to > > > be safer than sorry. > > = > > I would rather have only a proper fix for the stable trees, that we > > have confidence in. So I'll wait. > = > Well, at least the patch can not hurt. > = > > Would one of you let me know if you need me to stare hard at the ring > > handling ? > = > Let's check which version we need to stare hard at first :) > = The oxenstored in staging. Sorry I haven't got around to investigate more -- need to clear some patches in my inbox first. Wei. > Samuel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 16:41:21 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 16:41:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqkpl-0002up-3v; Mon, 26 Oct 2015 16:41:21 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqkpj-0002uW-I1; Mon, 26 Oct 2015 16:41:19 +0000 Received: from [85.158.137.68] by server-1.bemta-3.messagelabs.com id 9F/EC-01421-EA75E265; Mon, 26 Oct 2015 16:41:18 +0000 X-Env-Sender: prvs=734318897=wei.liu2@citrix.com X-Msg-Ref: server-11.tower-31.messagelabs.com!1445877676!24057142!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 940 invoked from network); 26 Oct 2015 16:41:18 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-11.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 16:41:18 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444694400"; d="scan'208";a="313450611" Date: Mon, 26 Oct 2015 16:41:15 +0000 From: Wei Liu To: Samuel Thibault , Ian Jackson , Wei Liu , , Xen-devel , Ian Campbell Message-ID: <20151026164115.GE19925@zion.uk.xensource.com> References: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> <20151026125247.GP19459@var.bordeaux.inria.fr> <20151026135531.GG13118@zion.uk.xensource.com> <20151026163001.GF18602@var.bordeaux.inria.fr> <22062.21898.162478.153744@mariner.uk.xensource.com> <20151026163751.GH18602@var.bordeaux.inria.fr> MIME-Version: 1.0 Content-Length: 1219 Content-Disposition: inline In-Reply-To: <20151026163751.GH18602@var.bordeaux.inria.fr> User-Agent: Mutt/1.5.23 (2014-03-12) X-DLP: MIA2 Subject: Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Mon, Oct 26, 2015 at 05:37:51PM +0100, Samuel Thibault wrote: > Ian Jackson, le Mon 26 Oct 2015 16:32:10 +0000, a =E9crit : > > Samuel Thibault writes ("Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: = notify the other end when necessary"): > > > Ok... This is still very worrying. The more I'm thinking about it, > > > the more I believe we shouldn't *have* to do this. Which version of > > > the xenstore are you testing with, exactly? I guess that while we > > > investigate this oddness we can apply this fix to stable trees, so as= to > > > be safer than sorry. > > = > > I would rather have only a proper fix for the stable trees, that we > > have confidence in. So I'll wait. > = > Well, at least the patch can not hurt. > = > > Would one of you let me know if you need me to stare hard at the ring > > handling ? > = > Let's check which version we need to stare hard at first :) > = The oxenstored in staging. Sorry I haven't got around to investigate more -- need to clear some patches in my inbox first. Wei. > Samuel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 16:44:02 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 16:44:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqksL-0003Ht-N2; Mon, 26 Oct 2015 16:44:01 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqksK-0003HY-FL; Mon, 26 Oct 2015 16:44:00 +0000 Received: from [193.109.254.147] by server-6.bemta-14.messagelabs.com id B6/DE-16618-F485E265; Mon, 26 Oct 2015 16:43:59 +0000 X-Env-Sender: samuel.thibault@ens-lyon.org X-Msg-Ref: server-12.tower-27.messagelabs.com!1445877837!61633019!1 X-Originating-IP: [192.134.164.83] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 21973 invoked from network); 26 Oct 2015 16:43:58 -0000 Received: from mail2-relais-roc.national.inria.fr (HELO mail2-relais-roc.national.inria.fr) (192.134.164.83) by server-12.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 16:43:58 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444687200"; d="scan'208";a="184521322" Received: from unknown (HELO var.ipv6) ([193.50.110.121]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/AES128-GCM-SHA256; 26 Oct 2015 17:43:53 +0100 Received: from samy by var.ipv6 with local (Exim 4.86) (envelope-from ) id 1ZqksD-00079v-2j; Mon, 26 Oct 2015 17:43:53 +0100 Date: Mon, 26 Oct 2015 17:43:53 +0100 From: Samuel Thibault To: Wei Liu Message-ID: <20151026164353.GI18602@var.bordeaux.inria.fr> Mail-Followup-To: Samuel Thibault , Wei Liu , Ian Jackson , minios-devel@lists.xenproject.org, Xen-devel , Ian Campbell References: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> <20151026125247.GP19459@var.bordeaux.inria.fr> <20151026135531.GG13118@zion.uk.xensource.com> <20151026163001.GF18602@var.bordeaux.inria.fr> <22062.21898.162478.153744@mariner.uk.xensource.com> <20151026163751.GH18602@var.bordeaux.inria.fr> <20151026164115.GE19925@zion.uk.xensource.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20151026164115.GE19925@zion.uk.xensource.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Cc: minios-devel@lists.xenproject.org, Xen-devel , Ian Jackson , Ian Campbell Subject: Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Also, just to make sure: you tested with the third and fourth hooks of your v2 patch applied, only first and second hooks were removed? Samuel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 16:44:02 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 16:44:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqksL-0003Ht-N2; Mon, 26 Oct 2015 16:44:01 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqksK-0003HY-FL; Mon, 26 Oct 2015 16:44:00 +0000 Received: from [193.109.254.147] by server-6.bemta-14.messagelabs.com id B6/DE-16618-F485E265; Mon, 26 Oct 2015 16:43:59 +0000 X-Env-Sender: samuel.thibault@ens-lyon.org X-Msg-Ref: server-12.tower-27.messagelabs.com!1445877837!61633019!1 X-Originating-IP: [192.134.164.83] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 21973 invoked from network); 26 Oct 2015 16:43:58 -0000 Received: from mail2-relais-roc.national.inria.fr (HELO mail2-relais-roc.national.inria.fr) (192.134.164.83) by server-12.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 16:43:58 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444687200"; d="scan'208";a="184521322" Received: from unknown (HELO var.ipv6) ([193.50.110.121]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/AES128-GCM-SHA256; 26 Oct 2015 17:43:53 +0100 Received: from samy by var.ipv6 with local (Exim 4.86) (envelope-from ) id 1ZqksD-00079v-2j; Mon, 26 Oct 2015 17:43:53 +0100 Date: Mon, 26 Oct 2015 17:43:53 +0100 From: Samuel Thibault To: Wei Liu Message-ID: <20151026164353.GI18602@var.bordeaux.inria.fr> Mail-Followup-To: Samuel Thibault , Wei Liu , Ian Jackson , minios-devel@lists.xenproject.org, Xen-devel , Ian Campbell References: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> <20151026125247.GP19459@var.bordeaux.inria.fr> <20151026135531.GG13118@zion.uk.xensource.com> <20151026163001.GF18602@var.bordeaux.inria.fr> <22062.21898.162478.153744@mariner.uk.xensource.com> <20151026163751.GH18602@var.bordeaux.inria.fr> <20151026164115.GE19925@zion.uk.xensource.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20151026164115.GE19925@zion.uk.xensource.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Cc: minios-devel@lists.xenproject.org, Xen-devel , Ian Jackson , Ian Campbell Subject: Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Also, just to make sure: you tested with the third and fourth hooks of your v2 patch applied, only first and second hooks were removed? Samuel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 16:52:31 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 16:52:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zql0Z-0003aF-Ig; Mon, 26 Oct 2015 16:52:31 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zql0X-0003a7-Qm; Mon, 26 Oct 2015 16:52:29 +0000 Received: from [193.109.254.147] by server-7.bemta-14.messagelabs.com id E7/AD-28221-D4A5E265; Mon, 26 Oct 2015 16:52:29 +0000 X-Env-Sender: prvs=734318897=wei.liu2@citrix.com X-Msg-Ref: server-5.tower-27.messagelabs.com!1445878347!50198950!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 12545 invoked from network); 26 Oct 2015 16:52:28 -0000 Received: from unknown (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-5.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 16:52:28 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444694400"; d="scan'208";a="308294581" Date: Mon, 26 Oct 2015 16:52:25 +0000 From: Wei Liu To: Samuel Thibault , Wei Liu , Ian Jackson , , Xen-devel , Ian Campbell Message-ID: <20151026165225.GF19925@zion.uk.xensource.com> References: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> <20151026125247.GP19459@var.bordeaux.inria.fr> <20151026135531.GG13118@zion.uk.xensource.com> <20151026163001.GF18602@var.bordeaux.inria.fr> <22062.21898.162478.153744@mariner.uk.xensource.com> <20151026163751.GH18602@var.bordeaux.inria.fr> <20151026164115.GE19925@zion.uk.xensource.com> <20151026164353.GI18602@var.bordeaux.inria.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20151026164353.GI18602@var.bordeaux.inria.fr> User-Agent: Mutt/1.5.23 (2014-03-12) X-DLP: MIA2 Subject: Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Mon, Oct 26, 2015 at 05:43:53PM +0100, Samuel Thibault wrote: > Also, just to make sure: you tested with the third and fourth hooks of > your v2 patch applied, only first and second hooks were removed? > > Samuel See the patch below. >From 0643a821ce2795e7e65e199e7caaa657f27bafcf Mon Sep 17 00:00:00 2001 From: Wei Liu Date: Fri, 23 Oct 2015 20:01:06 +0100 Subject: [PATCH] Test patch --- xenbus/xenbus.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/xenbus/xenbus.c b/xenbus/xenbus.c index 4613ed6..0ab387a 100644 --- a/xenbus/xenbus.c +++ b/xenbus/xenbus.c @@ -237,6 +237,7 @@ static void xenbus_thread_func(void *ign) event->path = data; event->token = event->path + strlen(event->path) + 1; + mb(); xenstore_buf->rsp_cons += msg.len + sizeof(msg); for (watch = watches; watch; watch = watch->next) @@ -262,9 +263,13 @@ static void xenbus_thread_func(void *ign) req_info[msg.req_id].reply, MASK_XENSTORE_IDX(xenstore_buf->rsp_cons), msg.len + sizeof(msg)); + mb(); xenstore_buf->rsp_cons += msg.len + sizeof(msg); wake_up(&req_info[msg.req_id].waitq); } + + wmb(); + notify_remote_via_evtchn(start_info.store_evtchn); } } } -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 16:52:31 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 16:52:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zql0Z-0003aF-Ig; Mon, 26 Oct 2015 16:52:31 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zql0X-0003a7-Qm; Mon, 26 Oct 2015 16:52:29 +0000 Received: from [193.109.254.147] by server-7.bemta-14.messagelabs.com id E7/AD-28221-D4A5E265; Mon, 26 Oct 2015 16:52:29 +0000 X-Env-Sender: prvs=734318897=wei.liu2@citrix.com X-Msg-Ref: server-5.tower-27.messagelabs.com!1445878347!50198950!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 12545 invoked from network); 26 Oct 2015 16:52:28 -0000 Received: from unknown (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-5.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 16:52:28 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444694400"; d="scan'208";a="308294581" Date: Mon, 26 Oct 2015 16:52:25 +0000 From: Wei Liu To: Samuel Thibault , Wei Liu , Ian Jackson , , Xen-devel , Ian Campbell Message-ID: <20151026165225.GF19925@zion.uk.xensource.com> References: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> <20151026125247.GP19459@var.bordeaux.inria.fr> <20151026135531.GG13118@zion.uk.xensource.com> <20151026163001.GF18602@var.bordeaux.inria.fr> <22062.21898.162478.153744@mariner.uk.xensource.com> <20151026163751.GH18602@var.bordeaux.inria.fr> <20151026164115.GE19925@zion.uk.xensource.com> <20151026164353.GI18602@var.bordeaux.inria.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20151026164353.GI18602@var.bordeaux.inria.fr> User-Agent: Mutt/1.5.23 (2014-03-12) X-DLP: MIA2 Subject: Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Mon, Oct 26, 2015 at 05:43:53PM +0100, Samuel Thibault wrote: > Also, just to make sure: you tested with the third and fourth hooks of > your v2 patch applied, only first and second hooks were removed? > > Samuel See the patch below. >From 0643a821ce2795e7e65e199e7caaa657f27bafcf Mon Sep 17 00:00:00 2001 From: Wei Liu Date: Fri, 23 Oct 2015 20:01:06 +0100 Subject: [PATCH] Test patch --- xenbus/xenbus.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/xenbus/xenbus.c b/xenbus/xenbus.c index 4613ed6..0ab387a 100644 --- a/xenbus/xenbus.c +++ b/xenbus/xenbus.c @@ -237,6 +237,7 @@ static void xenbus_thread_func(void *ign) event->path = data; event->token = event->path + strlen(event->path) + 1; + mb(); xenstore_buf->rsp_cons += msg.len + sizeof(msg); for (watch = watches; watch; watch = watch->next) @@ -262,9 +263,13 @@ static void xenbus_thread_func(void *ign) req_info[msg.req_id].reply, MASK_XENSTORE_IDX(xenstore_buf->rsp_cons), msg.len + sizeof(msg)); + mb(); xenstore_buf->rsp_cons += msg.len + sizeof(msg); wake_up(&req_info[msg.req_id].waitq); } + + wmb(); + notify_remote_via_evtchn(start_info.store_evtchn); } } } -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 17:11:07 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 17:11:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqlIZ-0005XJ-6z; Mon, 26 Oct 2015 17:11:07 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqlIY-0005X6-IH; Mon, 26 Oct 2015 17:11:06 +0000 Received: from [193.109.254.147] by server-15.bemta-14.messagelabs.com id C2/D3-18886-9AE5E265; Mon, 26 Oct 2015 17:11:05 +0000 X-Env-Sender: samuel.thibault@ens-lyon.org X-Msg-Ref: server-9.tower-27.messagelabs.com!1445879464!61615046!1 X-Originating-IP: [192.134.164.83] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 13391 invoked from network); 26 Oct 2015 17:11:05 -0000 Received: from mail2-relais-roc.national.inria.fr (HELO mail2-relais-roc.national.inria.fr) (192.134.164.83) by server-9.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 17:11:05 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444687200"; d="scan'208";a="184526118" Received: from unknown (HELO var.ipv6) ([193.50.110.121]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/AES128-GCM-SHA256; 26 Oct 2015 18:11:04 +0100 Received: from samy by var.ipv6 with local (Exim 4.86) (envelope-from ) id 1ZqlIW-00086S-Hb; Mon, 26 Oct 2015 18:11:04 +0100 Date: Mon, 26 Oct 2015 18:11:04 +0100 From: Samuel Thibault To: Wei Liu Message-ID: <20151026171104.GJ18602@var.bordeaux.inria.fr> Mail-Followup-To: Samuel Thibault , Wei Liu , Ian Jackson , minios-devel@lists.xenproject.org, Xen-devel , Ian Campbell References: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> <20151026125247.GP19459@var.bordeaux.inria.fr> <20151026135531.GG13118@zion.uk.xensource.com> <20151026163001.GF18602@var.bordeaux.inria.fr> <22062.21898.162478.153744@mariner.uk.xensource.com> <20151026163751.GH18602@var.bordeaux.inria.fr> <20151026164115.GE19925@zion.uk.xensource.com> MIME-Version: 1.0 Content-Length: 1403 Content-Disposition: inline In-Reply-To: <20151026164115.GE19925@zion.uk.xensource.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Cc: minios-devel@lists.xenproject.org, Xen-devel , Ian Jackson , Ian Campbell Subject: Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Wei Liu, le Mon 26 Oct 2015 16:41:15 +0000, a =E9crit : > The oxenstored in staging. Ok. For a first, one fishy thing at quick sight is that the only occurence of rsp_cons (except at closure) is when writing, and not when going to sleep. One issue there is that ml_interface_write only writes a contiguous piece of data, so when crossing the ring bound, it will return a short write while there *is* room! One quick test you could do is calling Xs_ring.write a second time in tools/ocaml/libs/xb/xb.ml's write_mmap, something like below (untested, and my caml is old, so it's ugly, but you get the idea). Samuel diff --git a/tools/ocaml/libs/xb/xb.ml b/tools/ocaml/libs/xb/xb.ml index 50944b5..33298d2 100644 --- a/tools/ocaml/libs/xb/xb.ml +++ b/tools/ocaml/libs/xb/xb.ml @@ -91,10 +91,12 @@ let write_fd back con s len =3D Unix.write back.fd s 0 len = let write_mmap back con s len =3D - let ws =3D Xs_ring.write back.mmap s len in - if ws > 0 then + let ws =3D ref (Xs_ring.write back.mmap s len) in + if !ws < len then + ws :=3D !ws + Xs_ring.write back.mmap (String.sub s !ws (len-!ws)) (len-= !ws); + if !ws > 0 then back.eventchn_notify (); - ws + !ws = let write con s len =3D match con.backend with _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 17:11:07 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 17:11:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqlIZ-0005XJ-6z; Mon, 26 Oct 2015 17:11:07 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqlIY-0005X6-IH; Mon, 26 Oct 2015 17:11:06 +0000 Received: from [193.109.254.147] by server-15.bemta-14.messagelabs.com id C2/D3-18886-9AE5E265; Mon, 26 Oct 2015 17:11:05 +0000 X-Env-Sender: samuel.thibault@ens-lyon.org X-Msg-Ref: server-9.tower-27.messagelabs.com!1445879464!61615046!1 X-Originating-IP: [192.134.164.83] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 13391 invoked from network); 26 Oct 2015 17:11:05 -0000 Received: from mail2-relais-roc.national.inria.fr (HELO mail2-relais-roc.national.inria.fr) (192.134.164.83) by server-9.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 17:11:05 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444687200"; d="scan'208";a="184526118" Received: from unknown (HELO var.ipv6) ([193.50.110.121]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/AES128-GCM-SHA256; 26 Oct 2015 18:11:04 +0100 Received: from samy by var.ipv6 with local (Exim 4.86) (envelope-from ) id 1ZqlIW-00086S-Hb; Mon, 26 Oct 2015 18:11:04 +0100 Date: Mon, 26 Oct 2015 18:11:04 +0100 From: Samuel Thibault To: Wei Liu Message-ID: <20151026171104.GJ18602@var.bordeaux.inria.fr> Mail-Followup-To: Samuel Thibault , Wei Liu , Ian Jackson , minios-devel@lists.xenproject.org, Xen-devel , Ian Campbell References: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> <20151026125247.GP19459@var.bordeaux.inria.fr> <20151026135531.GG13118@zion.uk.xensource.com> <20151026163001.GF18602@var.bordeaux.inria.fr> <22062.21898.162478.153744@mariner.uk.xensource.com> <20151026163751.GH18602@var.bordeaux.inria.fr> <20151026164115.GE19925@zion.uk.xensource.com> MIME-Version: 1.0 Content-Length: 1403 Content-Disposition: inline In-Reply-To: <20151026164115.GE19925@zion.uk.xensource.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Cc: minios-devel@lists.xenproject.org, Xen-devel , Ian Jackson , Ian Campbell Subject: Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Wei Liu, le Mon 26 Oct 2015 16:41:15 +0000, a =E9crit : > The oxenstored in staging. Ok. For a first, one fishy thing at quick sight is that the only occurence of rsp_cons (except at closure) is when writing, and not when going to sleep. One issue there is that ml_interface_write only writes a contiguous piece of data, so when crossing the ring bound, it will return a short write while there *is* room! One quick test you could do is calling Xs_ring.write a second time in tools/ocaml/libs/xb/xb.ml's write_mmap, something like below (untested, and my caml is old, so it's ugly, but you get the idea). Samuel diff --git a/tools/ocaml/libs/xb/xb.ml b/tools/ocaml/libs/xb/xb.ml index 50944b5..33298d2 100644 --- a/tools/ocaml/libs/xb/xb.ml +++ b/tools/ocaml/libs/xb/xb.ml @@ -91,10 +91,12 @@ let write_fd back con s len =3D Unix.write back.fd s 0 len = let write_mmap back con s len =3D - let ws =3D Xs_ring.write back.mmap s len in - if ws > 0 then + let ws =3D ref (Xs_ring.write back.mmap s len) in + if !ws < len then + ws :=3D !ws + Xs_ring.write back.mmap (String.sub s !ws (len-!ws)) (len-= !ws); + if !ws > 0 then back.eventchn_notify (); - ws + !ws = let write con s len =3D match con.backend with _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 18:35:07 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 18:35:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqmbo-0000vW-Rm; Mon, 26 Oct 2015 18:35:04 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqmbn-0000vO-Vo; Mon, 26 Oct 2015 18:35:04 +0000 Received: from [193.109.254.147] by server-14.bemta-14.messagelabs.com id 34/EF-04752-7527E265; Mon, 26 Oct 2015 18:35:03 +0000 X-Env-Sender: prvs=734318897=wei.liu2@citrix.com X-Msg-Ref: server-11.tower-27.messagelabs.com!1445884501!55539303!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 11414 invoked from network); 26 Oct 2015 18:35:02 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-11.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 18:35:02 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444694400"; d="scan'208";a="308300158" Date: Mon, 26 Oct 2015 18:34:59 +0000 From: Wei Liu To: Samuel Thibault , Wei Liu , Ian Jackson , , Xen-devel , Ian Campbell Message-ID: <20151026183459.GO18674@zion.uk.xensource.com> References: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> <20151026125247.GP19459@var.bordeaux.inria.fr> <20151026135531.GG13118@zion.uk.xensource.com> <20151026163001.GF18602@var.bordeaux.inria.fr> <22062.21898.162478.153744@mariner.uk.xensource.com> <20151026163751.GH18602@var.bordeaux.inria.fr> <20151026164115.GE19925@zion.uk.xensource.com> <20151026171104.GJ18602@var.bordeaux.inria.fr> MIME-Version: 1.0 Content-Length: 1924 Content-Disposition: inline In-Reply-To: <20151026171104.GJ18602@var.bordeaux.inria.fr> User-Agent: Mutt/1.5.23 (2014-03-12) X-DLP: MIA1 Subject: Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Mon, Oct 26, 2015 at 06:11:04PM +0100, Samuel Thibault wrote: > Wei Liu, le Mon 26 Oct 2015 16:41:15 +0000, a =E9crit : > > The oxenstored in staging. > = > Ok. For a first, one fishy thing at quick sight is that the only > occurence of rsp_cons (except at closure) is when writing, and not when > going to sleep. One issue there is that ml_interface_write only writes > a contiguous piece of data, so when crossing the ring bound, it will > return a short write while there *is* room! > = > One quick test you could do is calling Xs_ring.write a second time in > tools/ocaml/libs/xb/xb.ml's write_mmap, something like below (untested, > and my caml is old, so it's ugly, but you get the idea). > = > Samuel > = > diff --git a/tools/ocaml/libs/xb/xb.ml b/tools/ocaml/libs/xb/xb.ml > index 50944b5..33298d2 100644 > --- a/tools/ocaml/libs/xb/xb.ml > +++ b/tools/ocaml/libs/xb/xb.ml > @@ -91,10 +91,12 @@ let write_fd back con s len =3D > Unix.write back.fd s 0 len > = > let write_mmap back con s len =3D > - let ws =3D Xs_ring.write back.mmap s len in > - if ws > 0 then > + let ws =3D ref (Xs_ring.write back.mmap s len) in > + if !ws < len then > + ws :=3D !ws + Xs_ring.write back.mmap (String.sub s !ws (len-!ws)) (le= n-!ws); > + if !ws > 0 then > back.eventchn_notify (); > - ws > + !ws > = > let write con s len =3D > match con.backend with I'm now running a slightly modified version of this diff (to fix compilation) and a mini-os only notifies the other end when it consumes message. The result is looking good, but I will let it run overnight to be sure. If the backend is to blame, I think we need to accept the fact it is now the de facto behaviour of xenstore ring and work around it in the frontend... Wei. _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Mon Oct 26 18:35:07 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 26 Oct 2015 18:35:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqmbo-0000vW-Rm; Mon, 26 Oct 2015 18:35:04 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqmbn-0000vO-Vo; Mon, 26 Oct 2015 18:35:04 +0000 Received: from [193.109.254.147] by server-14.bemta-14.messagelabs.com id 34/EF-04752-7527E265; Mon, 26 Oct 2015 18:35:03 +0000 X-Env-Sender: prvs=734318897=wei.liu2@citrix.com X-Msg-Ref: server-11.tower-27.messagelabs.com!1445884501!55539303!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 11414 invoked from network); 26 Oct 2015 18:35:02 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-11.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2015 18:35:02 -0000 X-IronPort-AV: E=Sophos;i="5.20,201,1444694400"; d="scan'208";a="308300158" Date: Mon, 26 Oct 2015 18:34:59 +0000 From: Wei Liu To: Samuel Thibault , Wei Liu , Ian Jackson , , Xen-devel , Ian Campbell Message-ID: <20151026183459.GO18674@zion.uk.xensource.com> References: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> <20151026125247.GP19459@var.bordeaux.inria.fr> <20151026135531.GG13118@zion.uk.xensource.com> <20151026163001.GF18602@var.bordeaux.inria.fr> <22062.21898.162478.153744@mariner.uk.xensource.com> <20151026163751.GH18602@var.bordeaux.inria.fr> <20151026164115.GE19925@zion.uk.xensource.com> <20151026171104.GJ18602@var.bordeaux.inria.fr> MIME-Version: 1.0 Content-Length: 1924 Content-Disposition: inline In-Reply-To: <20151026171104.GJ18602@var.bordeaux.inria.fr> User-Agent: Mutt/1.5.23 (2014-03-12) X-DLP: MIA1 Subject: Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Mon, Oct 26, 2015 at 06:11:04PM +0100, Samuel Thibault wrote: > Wei Liu, le Mon 26 Oct 2015 16:41:15 +0000, a =E9crit : > > The oxenstored in staging. > = > Ok. For a first, one fishy thing at quick sight is that the only > occurence of rsp_cons (except at closure) is when writing, and not when > going to sleep. One issue there is that ml_interface_write only writes > a contiguous piece of data, so when crossing the ring bound, it will > return a short write while there *is* room! > = > One quick test you could do is calling Xs_ring.write a second time in > tools/ocaml/libs/xb/xb.ml's write_mmap, something like below (untested, > and my caml is old, so it's ugly, but you get the idea). > = > Samuel > = > diff --git a/tools/ocaml/libs/xb/xb.ml b/tools/ocaml/libs/xb/xb.ml > index 50944b5..33298d2 100644 > --- a/tools/ocaml/libs/xb/xb.ml > +++ b/tools/ocaml/libs/xb/xb.ml > @@ -91,10 +91,12 @@ let write_fd back con s len =3D > Unix.write back.fd s 0 len > = > let write_mmap back con s len =3D > - let ws =3D Xs_ring.write back.mmap s len in > - if ws > 0 then > + let ws =3D ref (Xs_ring.write back.mmap s len) in > + if !ws < len then > + ws :=3D !ws + Xs_ring.write back.mmap (String.sub s !ws (len-!ws)) (le= n-!ws); > + if !ws > 0 then > back.eventchn_notify (); > - ws > + !ws > = > let write con s len =3D > match con.backend with I'm now running a slightly modified version of this diff (to fix compilation) and a mini-os only notifies the other end when it consumes message. The result is looking good, but I will let it run overnight to be sure. If the backend is to blame, I think we need to accept the fact it is now the de facto behaviour of xenstore ring and work around it in the frontend... Wei. _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Tue Oct 27 10:32:30 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 27 Oct 2015 10:32:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr1YK-0000eL-BD; Tue, 27 Oct 2015 10:32:28 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr1YJ-0000eD-57; Tue, 27 Oct 2015 10:32:27 +0000 Received: from [193.109.254.147] by server-6.bemta-14.messagelabs.com id 31/08-16618-5B25F265; Tue, 27 Oct 2015 10:32:21 +0000 X-Env-Sender: prvs=7352c57fe=wei.liu2@citrix.com X-Msg-Ref: server-8.tower-27.messagelabs.com!1445941939!22947608!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 27731 invoked from network); 27 Oct 2015 10:32:21 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-8.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 27 Oct 2015 10:32:21 -0000 X-IronPort-AV: E=Sophos;i="5.20,204,1444694400"; d="scan'208";a="313669401" Date: Tue, 27 Oct 2015 10:32:18 +0000 From: Wei Liu To: Samuel Thibault , Wei Liu , Ian Jackson , , Xen-devel , Ian Campbell Message-ID: <20151027103218.GQ18674@zion.uk.xensource.com> References: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> <20151026125247.GP19459@var.bordeaux.inria.fr> <20151026135531.GG13118@zion.uk.xensource.com> <20151026163001.GF18602@var.bordeaux.inria.fr> <22062.21898.162478.153744@mariner.uk.xensource.com> <20151026163751.GH18602@var.bordeaux.inria.fr> <20151026164115.GE19925@zion.uk.xensource.com> <20151026171104.GJ18602@var.bordeaux.inria.fr> <20151026183459.GO18674@zion.uk.xensource.com> MIME-Version: 1.0 Content-Length: 2115 Content-Disposition: inline In-Reply-To: <20151026183459.GO18674@zion.uk.xensource.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-DLP: MIA2 Subject: Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Mon, Oct 26, 2015 at 06:34:59PM +0000, Wei Liu wrote: > On Mon, Oct 26, 2015 at 06:11:04PM +0100, Samuel Thibault wrote: > > Wei Liu, le Mon 26 Oct 2015 16:41:15 +0000, a =E9crit : > > > The oxenstored in staging. > > = > > Ok. For a first, one fishy thing at quick sight is that the only > > occurence of rsp_cons (except at closure) is when writing, and not when > > going to sleep. One issue there is that ml_interface_write only writes > > a contiguous piece of data, so when crossing the ring bound, it will > > return a short write while there *is* room! > > = > > One quick test you could do is calling Xs_ring.write a second time in > > tools/ocaml/libs/xb/xb.ml's write_mmap, something like below (untested, > > and my caml is old, so it's ugly, but you get the idea). > > = > > Samuel > > = > > diff --git a/tools/ocaml/libs/xb/xb.ml b/tools/ocaml/libs/xb/xb.ml > > index 50944b5..33298d2 100644 > > --- a/tools/ocaml/libs/xb/xb.ml > > +++ b/tools/ocaml/libs/xb/xb.ml > > @@ -91,10 +91,12 @@ let write_fd back con s len =3D > > Unix.write back.fd s 0 len > > = > > let write_mmap back con s len =3D > > - let ws =3D Xs_ring.write back.mmap s len in > > - if ws > 0 then > > + let ws =3D ref (Xs_ring.write back.mmap s len) in > > + if !ws < len then > > + ws :=3D !ws + Xs_ring.write back.mmap (String.sub s !ws (len-!ws)) (= len-!ws); > > + if !ws > 0 then > > back.eventchn_notify (); > > - ws > > + !ws > > = > > let write con s len =3D > > match con.backend with > = > I'm now running a slightly modified version of this diff (to fix > compilation) and a mini-os only notifies the other end when it consumes > message. > = > The result is looking good, but I will let it run overnight to be sure. > = The test ran overnight without issue. I think it would be sensible to take my v2 patch for mini-os and work on fixes for xenstored. I haven't checked if cxenstored behaves the same, though. Wei. _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Tue Oct 27 10:32:30 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 27 Oct 2015 10:32:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr1YK-0000eL-BD; Tue, 27 Oct 2015 10:32:28 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr1YJ-0000eD-57; Tue, 27 Oct 2015 10:32:27 +0000 Received: from [193.109.254.147] by server-6.bemta-14.messagelabs.com id 31/08-16618-5B25F265; Tue, 27 Oct 2015 10:32:21 +0000 X-Env-Sender: prvs=7352c57fe=wei.liu2@citrix.com X-Msg-Ref: server-8.tower-27.messagelabs.com!1445941939!22947608!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 27731 invoked from network); 27 Oct 2015 10:32:21 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-8.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 27 Oct 2015 10:32:21 -0000 X-IronPort-AV: E=Sophos;i="5.20,204,1444694400"; d="scan'208";a="313669401" Date: Tue, 27 Oct 2015 10:32:18 +0000 From: Wei Liu To: Samuel Thibault , Wei Liu , Ian Jackson , , Xen-devel , Ian Campbell Message-ID: <20151027103218.GQ18674@zion.uk.xensource.com> References: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> <20151026125247.GP19459@var.bordeaux.inria.fr> <20151026135531.GG13118@zion.uk.xensource.com> <20151026163001.GF18602@var.bordeaux.inria.fr> <22062.21898.162478.153744@mariner.uk.xensource.com> <20151026163751.GH18602@var.bordeaux.inria.fr> <20151026164115.GE19925@zion.uk.xensource.com> <20151026171104.GJ18602@var.bordeaux.inria.fr> <20151026183459.GO18674@zion.uk.xensource.com> MIME-Version: 1.0 Content-Length: 2115 Content-Disposition: inline In-Reply-To: <20151026183459.GO18674@zion.uk.xensource.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-DLP: MIA2 Subject: Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Mon, Oct 26, 2015 at 06:34:59PM +0000, Wei Liu wrote: > On Mon, Oct 26, 2015 at 06:11:04PM +0100, Samuel Thibault wrote: > > Wei Liu, le Mon 26 Oct 2015 16:41:15 +0000, a =E9crit : > > > The oxenstored in staging. > > = > > Ok. For a first, one fishy thing at quick sight is that the only > > occurence of rsp_cons (except at closure) is when writing, and not when > > going to sleep. One issue there is that ml_interface_write only writes > > a contiguous piece of data, so when crossing the ring bound, it will > > return a short write while there *is* room! > > = > > One quick test you could do is calling Xs_ring.write a second time in > > tools/ocaml/libs/xb/xb.ml's write_mmap, something like below (untested, > > and my caml is old, so it's ugly, but you get the idea). > > = > > Samuel > > = > > diff --git a/tools/ocaml/libs/xb/xb.ml b/tools/ocaml/libs/xb/xb.ml > > index 50944b5..33298d2 100644 > > --- a/tools/ocaml/libs/xb/xb.ml > > +++ b/tools/ocaml/libs/xb/xb.ml > > @@ -91,10 +91,12 @@ let write_fd back con s len =3D > > Unix.write back.fd s 0 len > > = > > let write_mmap back con s len =3D > > - let ws =3D Xs_ring.write back.mmap s len in > > - if ws > 0 then > > + let ws =3D ref (Xs_ring.write back.mmap s len) in > > + if !ws < len then > > + ws :=3D !ws + Xs_ring.write back.mmap (String.sub s !ws (len-!ws)) (= len-!ws); > > + if !ws > 0 then > > back.eventchn_notify (); > > - ws > > + !ws > > = > > let write con s len =3D > > match con.backend with > = > I'm now running a slightly modified version of this diff (to fix > compilation) and a mini-os only notifies the other end when it consumes > message. > = > The result is looking good, but I will let it run overnight to be sure. > = The test ran overnight without issue. I think it would be sensible to take my v2 patch for mini-os and work on fixes for xenstored. I haven't checked if cxenstored behaves the same, though. Wei. _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Tue Oct 27 10:54:20 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 27 Oct 2015 10:54:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr1tU-0001dR-5O; Tue, 27 Oct 2015 10:54:20 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr1tS-0001dJ-Tr; Tue, 27 Oct 2015 10:54:19 +0000 Received: from [85.158.139.211] by server-12.bemta-5.messagelabs.com id F7/9E-12831-AD75F265; Tue, 27 Oct 2015 10:54:18 +0000 X-Env-Sender: samuel.thibault@ens-lyon.org X-Msg-Ref: server-8.tower-206.messagelabs.com!1445943257!45380934!1 X-Originating-IP: [192.134.164.83] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 27176 invoked from network); 27 Oct 2015 10:54:17 -0000 Received: from mail2-relais-roc.national.inria.fr (HELO mail2-relais-roc.national.inria.fr) (192.134.164.83) by server-8.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 27 Oct 2015 10:54:17 -0000 X-IronPort-AV: E=Sophos;i="5.20,204,1444687200"; d="scan'208";a="184636566" Received: from unknown (HELO var.ipv6) ([193.50.110.121]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/AES128-GCM-SHA256; 27 Oct 2015 11:54:01 +0100 Received: from samy by var.ipv6 with local (Exim 4.86) (envelope-from ) id 1Zr1tB-00010m-C3; Tue, 27 Oct 2015 11:54:01 +0100 Date: Tue, 27 Oct 2015 11:54:01 +0100 From: Samuel Thibault To: Wei Liu Message-ID: <20151027105401.GB2483@var.bordeaux.inria.fr> Mail-Followup-To: Samuel Thibault , Wei Liu , Ian Jackson , minios-devel@lists.xenproject.org, Xen-devel , Ian Campbell References: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> <20151026125247.GP19459@var.bordeaux.inria.fr> <20151026135531.GG13118@zion.uk.xensource.com> <20151026163001.GF18602@var.bordeaux.inria.fr> <22062.21898.162478.153744@mariner.uk.xensource.com> <20151026163751.GH18602@var.bordeaux.inria.fr> <20151026164115.GE19925@zion.uk.xensource.com> <20151026171104.GJ18602@var.bordeaux.inria.fr> <20151026183459.GO18674@zion.uk.xensource.com> <20151027103218.GQ18674@zion.uk.xensource.com> MIME-Version: 1.0 Content-Length: 357 Content-Disposition: inline In-Reply-To: <20151027103218.GQ18674@zion.uk.xensource.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Cc: minios-devel@lists.xenproject.org, Xen-devel , Ian Jackson , Ian Campbell Subject: Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Wei Liu, le Tue 27 Oct 2015 10:32:18 +0000, a =E9crit : > I haven't checked if cxenstored behaves the same, though. It doesn't: it checks for room in rings before sleeping. Samuel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Tue Oct 27 10:54:20 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 27 Oct 2015 10:54:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr1tU-0001dR-5O; Tue, 27 Oct 2015 10:54:20 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr1tS-0001dJ-Tr; Tue, 27 Oct 2015 10:54:19 +0000 Received: from [85.158.139.211] by server-12.bemta-5.messagelabs.com id F7/9E-12831-AD75F265; Tue, 27 Oct 2015 10:54:18 +0000 X-Env-Sender: samuel.thibault@ens-lyon.org X-Msg-Ref: server-8.tower-206.messagelabs.com!1445943257!45380934!1 X-Originating-IP: [192.134.164.83] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 27176 invoked from network); 27 Oct 2015 10:54:17 -0000 Received: from mail2-relais-roc.national.inria.fr (HELO mail2-relais-roc.national.inria.fr) (192.134.164.83) by server-8.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 27 Oct 2015 10:54:17 -0000 X-IronPort-AV: E=Sophos;i="5.20,204,1444687200"; d="scan'208";a="184636566" Received: from unknown (HELO var.ipv6) ([193.50.110.121]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/AES128-GCM-SHA256; 27 Oct 2015 11:54:01 +0100 Received: from samy by var.ipv6 with local (Exim 4.86) (envelope-from ) id 1Zr1tB-00010m-C3; Tue, 27 Oct 2015 11:54:01 +0100 Date: Tue, 27 Oct 2015 11:54:01 +0100 From: Samuel Thibault To: Wei Liu Message-ID: <20151027105401.GB2483@var.bordeaux.inria.fr> Mail-Followup-To: Samuel Thibault , Wei Liu , Ian Jackson , minios-devel@lists.xenproject.org, Xen-devel , Ian Campbell References: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> <20151026125247.GP19459@var.bordeaux.inria.fr> <20151026135531.GG13118@zion.uk.xensource.com> <20151026163001.GF18602@var.bordeaux.inria.fr> <22062.21898.162478.153744@mariner.uk.xensource.com> <20151026163751.GH18602@var.bordeaux.inria.fr> <20151026164115.GE19925@zion.uk.xensource.com> <20151026171104.GJ18602@var.bordeaux.inria.fr> <20151026183459.GO18674@zion.uk.xensource.com> <20151027103218.GQ18674@zion.uk.xensource.com> MIME-Version: 1.0 Content-Length: 357 Content-Disposition: inline In-Reply-To: <20151027103218.GQ18674@zion.uk.xensource.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Cc: minios-devel@lists.xenproject.org, Xen-devel , Ian Jackson , Ian Campbell Subject: Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Wei Liu, le Tue 27 Oct 2015 10:32:18 +0000, a =E9crit : > I haven't checked if cxenstored behaves the same, though. It doesn't: it checks for room in rings before sleeping. Samuel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Tue Oct 27 11:46:07 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 27 Oct 2015 11:46:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr2ha-0006GA-6Q; Tue, 27 Oct 2015 11:46:06 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr2hY-0006Fw-QN; Tue, 27 Oct 2015 11:46:04 +0000 Received: from [85.158.139.211] by server-4.bemta-5.messagelabs.com id 75/00-24856-BF36F265; Tue, 27 Oct 2015 11:46:03 +0000 X-Env-Sender: prvs=7352c57fe=wei.liu2@citrix.com X-Msg-Ref: server-8.tower-206.messagelabs.com!1445946361!45400879!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 18301 invoked from network); 27 Oct 2015 11:46:03 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-8.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 27 Oct 2015 11:46:03 -0000 X-IronPort-AV: E=Sophos;i="5.20,204,1444694400"; d="scan'208";a="308446848" Date: Tue, 27 Oct 2015 11:45:55 +0000 From: Wei Liu To: Samuel Thibault , Wei Liu , Ian Jackson , , Xen-devel , Ian Campbell Message-ID: <20151027114555.GT18674@zion.uk.xensource.com> References: <20151026125247.GP19459@var.bordeaux.inria.fr> <20151026135531.GG13118@zion.uk.xensource.com> <20151026163001.GF18602@var.bordeaux.inria.fr> <22062.21898.162478.153744@mariner.uk.xensource.com> <20151026163751.GH18602@var.bordeaux.inria.fr> <20151026164115.GE19925@zion.uk.xensource.com> <20151026171104.GJ18602@var.bordeaux.inria.fr> <20151026183459.GO18674@zion.uk.xensource.com> <20151027103218.GQ18674@zion.uk.xensource.com> <20151027105401.GB2483@var.bordeaux.inria.fr> MIME-Version: 1.0 Content-Length: 533 Content-Disposition: inline In-Reply-To: <20151027105401.GB2483@var.bordeaux.inria.fr> User-Agent: Mutt/1.5.23 (2014-03-12) X-DLP: MIA2 Subject: Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Tue, Oct 27, 2015 at 11:54:01AM +0100, Samuel Thibault wrote: > Wei Liu, le Tue 27 Oct 2015 10:32:18 +0000, a =E9crit : > > I haven't checked if cxenstored behaves the same, though. > = > It doesn't: it checks for room in rings before sleeping. > = Thanks for checking! And I confirm with my test that cxenstored does the right thing. Wei. > Samuel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Tue Oct 27 11:46:07 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 27 Oct 2015 11:46:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr2ha-0006GA-6Q; Tue, 27 Oct 2015 11:46:06 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr2hY-0006Fw-QN; Tue, 27 Oct 2015 11:46:04 +0000 Received: from [85.158.139.211] by server-4.bemta-5.messagelabs.com id 75/00-24856-BF36F265; Tue, 27 Oct 2015 11:46:03 +0000 X-Env-Sender: prvs=7352c57fe=wei.liu2@citrix.com X-Msg-Ref: server-8.tower-206.messagelabs.com!1445946361!45400879!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 18301 invoked from network); 27 Oct 2015 11:46:03 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-8.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 27 Oct 2015 11:46:03 -0000 X-IronPort-AV: E=Sophos;i="5.20,204,1444694400"; d="scan'208";a="308446848" Date: Tue, 27 Oct 2015 11:45:55 +0000 From: Wei Liu To: Samuel Thibault , Wei Liu , Ian Jackson , , Xen-devel , Ian Campbell Message-ID: <20151027114555.GT18674@zion.uk.xensource.com> References: <20151026125247.GP19459@var.bordeaux.inria.fr> <20151026135531.GG13118@zion.uk.xensource.com> <20151026163001.GF18602@var.bordeaux.inria.fr> <22062.21898.162478.153744@mariner.uk.xensource.com> <20151026163751.GH18602@var.bordeaux.inria.fr> <20151026164115.GE19925@zion.uk.xensource.com> <20151026171104.GJ18602@var.bordeaux.inria.fr> <20151026183459.GO18674@zion.uk.xensource.com> <20151027103218.GQ18674@zion.uk.xensource.com> <20151027105401.GB2483@var.bordeaux.inria.fr> MIME-Version: 1.0 Content-Length: 533 Content-Disposition: inline In-Reply-To: <20151027105401.GB2483@var.bordeaux.inria.fr> User-Agent: Mutt/1.5.23 (2014-03-12) X-DLP: MIA2 Subject: Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Tue, Oct 27, 2015 at 11:54:01AM +0100, Samuel Thibault wrote: > Wei Liu, le Tue 27 Oct 2015 10:32:18 +0000, a =E9crit : > > I haven't checked if cxenstored behaves the same, though. > = > It doesn't: it checks for room in rings before sleeping. > = Thanks for checking! And I confirm with my test that cxenstored does the right thing. Wei. > Samuel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Tue Oct 27 15:43:26 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 27 Oct 2015 15:43:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr6PF-00038s-SF; Tue, 27 Oct 2015 15:43:25 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr6PE-00037i-D8; Tue, 27 Oct 2015 15:43:24 +0000 Received: from [193.109.254.147] by server-7.bemta-14.messagelabs.com id A3/C7-28221-B9B9F265; Tue, 27 Oct 2015 15:43:23 +0000 X-Env-Sender: prvs=7352c57fe=wei.liu2@citrix.com X-Msg-Ref: server-4.tower-27.messagelabs.com!1445960601!59291657!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 23473 invoked from network); 27 Oct 2015 15:43:23 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-4.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 27 Oct 2015 15:43:23 -0000 X-IronPort-AV: E=Sophos;i="5.20,205,1444694400"; d="scan'208";a="308511350" From: Wei Liu To: Date: Tue, 27 Oct 2015 15:43:27 +0000 Message-ID: <1445960609-16977-1-git-send-email-wei.liu2@citrix.com> X-Mailer: git-send-email 2.1.4 MIME-Version: 1.0 X-DLP: MIA1 Cc: Xen-devel , Wei Liu , Ian Jackson , Ian Campbell , samuel.thibault@ens-lyon.org Subject: [Minios-devel] [PATCH MINI-OS v3 0/2] Two mini-os xenbus patches X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org I broke down my previous patch to two patches. Both of them should be applied to mini-os staging. The first patch should be applied to the (to be created) stable-4.6 mini-os branch, along with a proper fix to oxenstored. Wei Liu (2): xenbus: notify the other end when necessary xenbus: workaround oxenstored short-write xenbus/xenbus.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Tue Oct 27 15:43:26 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 27 Oct 2015 15:43:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr6PF-00038s-SF; Tue, 27 Oct 2015 15:43:25 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr6PE-00037i-D8; Tue, 27 Oct 2015 15:43:24 +0000 Received: from [193.109.254.147] by server-7.bemta-14.messagelabs.com id A3/C7-28221-B9B9F265; Tue, 27 Oct 2015 15:43:23 +0000 X-Env-Sender: prvs=7352c57fe=wei.liu2@citrix.com X-Msg-Ref: server-4.tower-27.messagelabs.com!1445960601!59291657!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 23473 invoked from network); 27 Oct 2015 15:43:23 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-4.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 27 Oct 2015 15:43:23 -0000 X-IronPort-AV: E=Sophos;i="5.20,205,1444694400"; d="scan'208";a="308511350" From: Wei Liu To: Date: Tue, 27 Oct 2015 15:43:27 +0000 Message-ID: <1445960609-16977-1-git-send-email-wei.liu2@citrix.com> X-Mailer: git-send-email 2.1.4 MIME-Version: 1.0 X-DLP: MIA1 Cc: Xen-devel , Wei Liu , Ian Jackson , Ian Campbell , samuel.thibault@ens-lyon.org Subject: [Minios-devel] [PATCH MINI-OS v3 0/2] Two mini-os xenbus patches X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org I broke down my previous patch to two patches. Both of them should be applied to mini-os staging. The first patch should be applied to the (to be created) stable-4.6 mini-os branch, along with a proper fix to oxenstored. Wei Liu (2): xenbus: notify the other end when necessary xenbus: workaround oxenstored short-write xenbus/xenbus.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Tue Oct 27 15:43:27 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 27 Oct 2015 15:43:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr6PH-00039l-AE; Tue, 27 Oct 2015 15:43:27 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr6PF-000380-7y; Tue, 27 Oct 2015 15:43:25 +0000 Received: from [85.158.139.211] by server-9.bemta-5.messagelabs.com id E4/41-30270-C9B9F265; Tue, 27 Oct 2015 15:43:24 +0000 X-Env-Sender: prvs=7352c57fe=wei.liu2@citrix.com X-Msg-Ref: server-5.tower-206.messagelabs.com!1445960601!45481998!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 30398 invoked from network); 27 Oct 2015 15:43:23 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-5.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 27 Oct 2015 15:43:23 -0000 X-IronPort-AV: E=Sophos;i="5.20,205,1444694400"; d="scan'208";a="313746997" From: Wei Liu To: Date: Tue, 27 Oct 2015 15:43:29 +0000 Message-ID: <1445960609-16977-3-git-send-email-wei.liu2@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1445960609-16977-1-git-send-email-wei.liu2@citrix.com> References: <1445960609-16977-1-git-send-email-wei.liu2@citrix.com> MIME-Version: 1.0 X-DLP: MIA1 Cc: Xen-devel , Wei Liu , Ian Jackson , Ian Campbell , samuel.thibault@ens-lyon.org Subject: [Minios-devel] [PATCH MINI-OS v3 2/2] xenbus: workaround oxenstored short-write X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Oxenstored has a behaviour that it only writes a contiguous piece of data. When it writes across ring boundary it will return a short-write while there is still room. That leads to mini-os stalling when it sees there is not enough data in the ring. Given that oxenstored is the default xenstored implementation we think it would be useful to workaround this for the benefit of running mini-os (and unikernel based on it) on any Xen installation. Signed-off-by: Wei Liu --- xenbus/xenbus.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/xenbus/xenbus.c b/xenbus/xenbus.c index 0ab387a..abf8b1b 100644 --- a/xenbus/xenbus.c +++ b/xenbus/xenbus.c @@ -205,8 +205,11 @@ static void xenbus_thread_func(void *ign) prod = xenstore_buf->rsp_prod; DEBUG("Rsp_cons %d, rsp_prod %d.\n", xenstore_buf->rsp_cons, xenstore_buf->rsp_prod); - if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < sizeof(msg)) + if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < sizeof(msg)) { + /* Work around oxenstored bug */ + notify_remote_via_evtchn(start_info.store_evtchn); break; + } rmb(); memcpy_from_ring(xenstore_buf->rsp, &msg, @@ -217,8 +220,11 @@ static void xenbus_thread_func(void *ign) xenstore_buf->rsp_prod - xenstore_buf->rsp_cons, msg.req_id); if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < - sizeof(msg) + msg.len) + sizeof(msg) + msg.len) { + /* Work around oxenstored bug */ + notify_remote_via_evtchn(start_info.store_evtchn); break; + } DEBUG("Message is good.\n"); -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Tue Oct 27 15:43:27 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 27 Oct 2015 15:43:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr6PH-00039l-AE; Tue, 27 Oct 2015 15:43:27 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr6PF-000380-7y; Tue, 27 Oct 2015 15:43:25 +0000 Received: from [85.158.139.211] by server-9.bemta-5.messagelabs.com id E4/41-30270-C9B9F265; Tue, 27 Oct 2015 15:43:24 +0000 X-Env-Sender: prvs=7352c57fe=wei.liu2@citrix.com X-Msg-Ref: server-5.tower-206.messagelabs.com!1445960601!45481998!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 30398 invoked from network); 27 Oct 2015 15:43:23 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-5.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 27 Oct 2015 15:43:23 -0000 X-IronPort-AV: E=Sophos;i="5.20,205,1444694400"; d="scan'208";a="313746997" From: Wei Liu To: Date: Tue, 27 Oct 2015 15:43:29 +0000 Message-ID: <1445960609-16977-3-git-send-email-wei.liu2@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1445960609-16977-1-git-send-email-wei.liu2@citrix.com> References: <1445960609-16977-1-git-send-email-wei.liu2@citrix.com> MIME-Version: 1.0 X-DLP: MIA1 Cc: Xen-devel , Wei Liu , Ian Jackson , Ian Campbell , samuel.thibault@ens-lyon.org Subject: [Minios-devel] [PATCH MINI-OS v3 2/2] xenbus: workaround oxenstored short-write X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Oxenstored has a behaviour that it only writes a contiguous piece of data. When it writes across ring boundary it will return a short-write while there is still room. That leads to mini-os stalling when it sees there is not enough data in the ring. Given that oxenstored is the default xenstored implementation we think it would be useful to workaround this for the benefit of running mini-os (and unikernel based on it) on any Xen installation. Signed-off-by: Wei Liu --- xenbus/xenbus.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/xenbus/xenbus.c b/xenbus/xenbus.c index 0ab387a..abf8b1b 100644 --- a/xenbus/xenbus.c +++ b/xenbus/xenbus.c @@ -205,8 +205,11 @@ static void xenbus_thread_func(void *ign) prod = xenstore_buf->rsp_prod; DEBUG("Rsp_cons %d, rsp_prod %d.\n", xenstore_buf->rsp_cons, xenstore_buf->rsp_prod); - if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < sizeof(msg)) + if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < sizeof(msg)) { + /* Work around oxenstored bug */ + notify_remote_via_evtchn(start_info.store_evtchn); break; + } rmb(); memcpy_from_ring(xenstore_buf->rsp, &msg, @@ -217,8 +220,11 @@ static void xenbus_thread_func(void *ign) xenstore_buf->rsp_prod - xenstore_buf->rsp_cons, msg.req_id); if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < - sizeof(msg) + msg.len) + sizeof(msg) + msg.len) { + /* Work around oxenstored bug */ + notify_remote_via_evtchn(start_info.store_evtchn); break; + } DEBUG("Message is good.\n"); -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Tue Oct 27 15:43:27 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 27 Oct 2015 15:43:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr6PH-0003Ak-O7; Tue, 27 Oct 2015 15:43:27 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr6PF-00038D-Im; Tue, 27 Oct 2015 15:43:25 +0000 Received: from [193.109.254.147] by server-8.bemta-14.messagelabs.com id 66/AC-19110-C9B9F265; Tue, 27 Oct 2015 15:43:24 +0000 X-Env-Sender: prvs=7352c57fe=wei.liu2@citrix.com X-Msg-Ref: server-4.tower-27.messagelabs.com!1445960601!59291657!2 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 23618 invoked from network); 27 Oct 2015 15:43:24 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-4.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 27 Oct 2015 15:43:24 -0000 X-IronPort-AV: E=Sophos;i="5.20,205,1444694400"; d="scan'208";a="308511358" From: Wei Liu To: Date: Tue, 27 Oct 2015 15:43:28 +0000 Message-ID: <1445960609-16977-2-git-send-email-wei.liu2@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1445960609-16977-1-git-send-email-wei.liu2@citrix.com> References: <1445960609-16977-1-git-send-email-wei.liu2@citrix.com> MIME-Version: 1.0 X-DLP: MIA1 Cc: Xen-devel , Wei Liu , Ian Jackson , Ian Campbell , samuel.thibault@ens-lyon.org Subject: [Minios-devel] [PATCH MINI-OS v3 1/2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org The xenbus thread didn't send notification to other end when it expected more data or consumed responses, which led to stalling the ring from time to time. This is the culprit that guest was less responsive when using stubdom because the device model was stalled. Fix this by sending notification to the other end when it consumes a message. A bunch of memory barriers are also added to ensure correctness. Signed-off-by: Wei Liu --- xenbus/xenbus.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/xenbus/xenbus.c b/xenbus/xenbus.c index 4613ed6..0ab387a 100644 --- a/xenbus/xenbus.c +++ b/xenbus/xenbus.c @@ -237,6 +237,7 @@ static void xenbus_thread_func(void *ign) event->path = data; event->token = event->path + strlen(event->path) + 1; + mb(); xenstore_buf->rsp_cons += msg.len + sizeof(msg); for (watch = watches; watch; watch = watch->next) @@ -262,9 +263,13 @@ static void xenbus_thread_func(void *ign) req_info[msg.req_id].reply, MASK_XENSTORE_IDX(xenstore_buf->rsp_cons), msg.len + sizeof(msg)); + mb(); xenstore_buf->rsp_cons += msg.len + sizeof(msg); wake_up(&req_info[msg.req_id].waitq); } + + wmb(); + notify_remote_via_evtchn(start_info.store_evtchn); } } } -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Tue Oct 27 15:43:27 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 27 Oct 2015 15:43:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr6PH-0003Ak-O7; Tue, 27 Oct 2015 15:43:27 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr6PF-00038D-Im; Tue, 27 Oct 2015 15:43:25 +0000 Received: from [193.109.254.147] by server-8.bemta-14.messagelabs.com id 66/AC-19110-C9B9F265; Tue, 27 Oct 2015 15:43:24 +0000 X-Env-Sender: prvs=7352c57fe=wei.liu2@citrix.com X-Msg-Ref: server-4.tower-27.messagelabs.com!1445960601!59291657!2 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 23618 invoked from network); 27 Oct 2015 15:43:24 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-4.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 27 Oct 2015 15:43:24 -0000 X-IronPort-AV: E=Sophos;i="5.20,205,1444694400"; d="scan'208";a="308511358" From: Wei Liu To: Date: Tue, 27 Oct 2015 15:43:28 +0000 Message-ID: <1445960609-16977-2-git-send-email-wei.liu2@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1445960609-16977-1-git-send-email-wei.liu2@citrix.com> References: <1445960609-16977-1-git-send-email-wei.liu2@citrix.com> MIME-Version: 1.0 X-DLP: MIA1 Cc: Xen-devel , Wei Liu , Ian Jackson , Ian Campbell , samuel.thibault@ens-lyon.org Subject: [Minios-devel] [PATCH MINI-OS v3 1/2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org The xenbus thread didn't send notification to other end when it expected more data or consumed responses, which led to stalling the ring from time to time. This is the culprit that guest was less responsive when using stubdom because the device model was stalled. Fix this by sending notification to the other end when it consumes a message. A bunch of memory barriers are also added to ensure correctness. Signed-off-by: Wei Liu --- xenbus/xenbus.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/xenbus/xenbus.c b/xenbus/xenbus.c index 4613ed6..0ab387a 100644 --- a/xenbus/xenbus.c +++ b/xenbus/xenbus.c @@ -237,6 +237,7 @@ static void xenbus_thread_func(void *ign) event->path = data; event->token = event->path + strlen(event->path) + 1; + mb(); xenstore_buf->rsp_cons += msg.len + sizeof(msg); for (watch = watches; watch; watch = watch->next) @@ -262,9 +263,13 @@ static void xenbus_thread_func(void *ign) req_info[msg.req_id].reply, MASK_XENSTORE_IDX(xenstore_buf->rsp_cons), msg.len + sizeof(msg)); + mb(); xenstore_buf->rsp_cons += msg.len + sizeof(msg); wake_up(&req_info[msg.req_id].waitq); } + + wmb(); + notify_remote_via_evtchn(start_info.store_evtchn); } } } -- 2.1.4 _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Tue Oct 27 15:46:48 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 27 Oct 2015 15:46:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr6SW-0003oo-24; Tue, 27 Oct 2015 15:46:48 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr6SU-0003oZ-1z; Tue, 27 Oct 2015 15:46:46 +0000 Received: from [193.109.254.147] by server-6.bemta-14.messagelabs.com id A8/A2-16618-56C9F265; Tue, 27 Oct 2015 15:46:45 +0000 X-Env-Sender: samuel.thibault@ens-lyon.org X-Msg-Ref: server-10.tower-27.messagelabs.com!1445960804!61907188!1 X-Originating-IP: [192.134.164.83] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 7359 invoked from network); 27 Oct 2015 15:46:44 -0000 Received: from mail2-relais-roc.national.inria.fr (HELO mail2-relais-roc.national.inria.fr) (192.134.164.83) by server-10.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 27 Oct 2015 15:46:44 -0000 X-IronPort-AV: E=Sophos;i="5.20,205,1444687200"; d="scan'208";a="184693815" Received: from unknown (HELO var.ipv6) ([193.50.110.121]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/AES128-GCM-SHA256; 27 Oct 2015 16:46:43 +0100 Received: from samy by var.ipv6 with local (Exim 4.86) (envelope-from ) id 1Zr6SR-0000IO-Jf; Tue, 27 Oct 2015 16:46:43 +0100 Date: Tue, 27 Oct 2015 16:46:43 +0100 From: Samuel Thibault To: Wei Liu Message-ID: <20151027154643.GE2483@var.bordeaux.inria.fr> Mail-Followup-To: Samuel Thibault , Wei Liu , minios-devel@lists.xenproject.org, Xen-devel , Ian Campbell , Ian Jackson References: <1445960609-16977-1-git-send-email-wei.liu2@citrix.com> <1445960609-16977-2-git-send-email-wei.liu2@citrix.com> MIME-Version: 1.0 Content-Length: 839 Content-Disposition: inline In-Reply-To: <1445960609-16977-2-git-send-email-wei.liu2@citrix.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Cc: minios-devel@lists.xenproject.org, Xen-devel , Ian Jackson , Ian Campbell Subject: Re: [Minios-devel] [PATCH MINI-OS v3 1/2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Wei Liu, le Tue 27 Oct 2015 15:43:28 +0000, a =E9crit : > The xenbus thread didn't send notification to other end when it expected > more data or consumed responses, which led to stalling the ring from > time to time. > = > This is the culprit that guest was less responsive when using stubdom > because the device model was stalled. > = > Fix this by sending notification to the other end when it consumes a > message. A bunch of memory barriers are also added to ensure > correctness. > = > Signed-off-by: Wei Liu Acked-by: Samuel Thibault And it should clearly be backported to stable branches. Samuel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Tue Oct 27 15:46:48 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 27 Oct 2015 15:46:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr6SW-0003oo-24; Tue, 27 Oct 2015 15:46:48 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr6SU-0003oZ-1z; Tue, 27 Oct 2015 15:46:46 +0000 Received: from [193.109.254.147] by server-6.bemta-14.messagelabs.com id A8/A2-16618-56C9F265; Tue, 27 Oct 2015 15:46:45 +0000 X-Env-Sender: samuel.thibault@ens-lyon.org X-Msg-Ref: server-10.tower-27.messagelabs.com!1445960804!61907188!1 X-Originating-IP: [192.134.164.83] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 7359 invoked from network); 27 Oct 2015 15:46:44 -0000 Received: from mail2-relais-roc.national.inria.fr (HELO mail2-relais-roc.national.inria.fr) (192.134.164.83) by server-10.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 27 Oct 2015 15:46:44 -0000 X-IronPort-AV: E=Sophos;i="5.20,205,1444687200"; d="scan'208";a="184693815" Received: from unknown (HELO var.ipv6) ([193.50.110.121]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/AES128-GCM-SHA256; 27 Oct 2015 16:46:43 +0100 Received: from samy by var.ipv6 with local (Exim 4.86) (envelope-from ) id 1Zr6SR-0000IO-Jf; Tue, 27 Oct 2015 16:46:43 +0100 Date: Tue, 27 Oct 2015 16:46:43 +0100 From: Samuel Thibault To: Wei Liu Message-ID: <20151027154643.GE2483@var.bordeaux.inria.fr> Mail-Followup-To: Samuel Thibault , Wei Liu , minios-devel@lists.xenproject.org, Xen-devel , Ian Campbell , Ian Jackson References: <1445960609-16977-1-git-send-email-wei.liu2@citrix.com> <1445960609-16977-2-git-send-email-wei.liu2@citrix.com> MIME-Version: 1.0 Content-Length: 839 Content-Disposition: inline In-Reply-To: <1445960609-16977-2-git-send-email-wei.liu2@citrix.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Cc: minios-devel@lists.xenproject.org, Xen-devel , Ian Jackson , Ian Campbell Subject: Re: [Minios-devel] [PATCH MINI-OS v3 1/2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Wei Liu, le Tue 27 Oct 2015 15:43:28 +0000, a =E9crit : > The xenbus thread didn't send notification to other end when it expected > more data or consumed responses, which led to stalling the ring from > time to time. > = > This is the culprit that guest was less responsive when using stubdom > because the device model was stalled. > = > Fix this by sending notification to the other end when it consumes a > message. A bunch of memory barriers are also added to ensure > correctness. > = > Signed-off-by: Wei Liu Acked-by: Samuel Thibault And it should clearly be backported to stable branches. Samuel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Tue Oct 27 15:47:43 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 27 Oct 2015 15:47:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr6TP-0003wP-Hk; Tue, 27 Oct 2015 15:47:43 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr6TO-0003wG-W2; Tue, 27 Oct 2015 15:47:43 +0000 Received: from [85.158.137.68] by server-16.bemta-3.messagelabs.com id D0/60-03763-E9C9F265; Tue, 27 Oct 2015 15:47:42 +0000 X-Env-Sender: samuel.thibault@ens-lyon.org X-Msg-Ref: server-4.tower-31.messagelabs.com!1445960861!55974791!1 X-Originating-IP: [192.134.164.83] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 3360 invoked from network); 27 Oct 2015 15:47:41 -0000 Received: from mail2-relais-roc.national.inria.fr (HELO mail2-relais-roc.national.inria.fr) (192.134.164.83) by server-4.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 27 Oct 2015 15:47:41 -0000 X-IronPort-AV: E=Sophos;i="5.20,205,1444687200"; d="scan'208";a="184693940" Received: from unknown (HELO var.ipv6) ([193.50.110.121]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/AES128-GCM-SHA256; 27 Oct 2015 16:47:40 +0100 Received: from samy by var.ipv6 with local (Exim 4.86) (envelope-from ) id 1Zr6TM-0000Ic-Ti; Tue, 27 Oct 2015 16:47:40 +0100 Date: Tue, 27 Oct 2015 16:47:40 +0100 From: Samuel Thibault To: Wei Liu Message-ID: <20151027154740.GF2483@var.bordeaux.inria.fr> Mail-Followup-To: Samuel Thibault , Wei Liu , minios-devel@lists.xenproject.org, Xen-devel , Ian Campbell , Ian Jackson References: <1445960609-16977-1-git-send-email-wei.liu2@citrix.com> <1445960609-16977-3-git-send-email-wei.liu2@citrix.com> MIME-Version: 1.0 Content-Length: 2512 Content-Disposition: inline In-Reply-To: <1445960609-16977-3-git-send-email-wei.liu2@citrix.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Cc: minios-devel@lists.xenproject.org, Xen-devel , Ian Jackson , Ian Campbell Subject: Re: [Minios-devel] [PATCH MINI-OS v3 2/2] xenbus: workaround oxenstored short-write X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Wei Liu, le Tue 27 Oct 2015 15:43:29 +0000, a =E9crit : > Oxenstored has a behaviour that it only writes a contiguous piece of > data. When it writes across ring boundary it will return a short-write > while there is still room. That leads to mini-os stalling when it sees > there is not enough data in the ring. > = > Given that oxenstored is the default xenstored implementation we think > it would be useful to workaround this for the benefit of running mini-os > (and unikernel based on it) on any Xen installation. > = > Signed-off-by: Wei Liu As discussed in the previous thread, this is rather a workaround. Better be safe than sorry. Acked-by: Samuel Thibault And could too be backported to stable branches. > --- > xenbus/xenbus.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > = > diff --git a/xenbus/xenbus.c b/xenbus/xenbus.c > index 0ab387a..abf8b1b 100644 > --- a/xenbus/xenbus.c > +++ b/xenbus/xenbus.c > @@ -205,8 +205,11 @@ static void xenbus_thread_func(void *ign) > prod =3D xenstore_buf->rsp_prod; > DEBUG("Rsp_cons %d, rsp_prod %d.\n", xenstore_buf->rsp_cons, > xenstore_buf->rsp_prod); > - if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < sizeof= (msg)) > + if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < sizeof= (msg)) { > + /* Work around oxenstored bug */ > + notify_remote_via_evtchn(start_info.store_evtchn); > break; > + } > rmb(); > memcpy_from_ring(xenstore_buf->rsp, > &msg, > @@ -217,8 +220,11 @@ static void xenbus_thread_func(void *ign) > xenstore_buf->rsp_prod - xenstore_buf->rsp_cons, > msg.req_id); > if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < > - sizeof(msg) + msg.len) > + sizeof(msg) + msg.len) { > + /* Work around oxenstored bug */ > + notify_remote_via_evtchn(start_info.store_evtchn); > break; > + } > = > DEBUG("Message is good.\n"); > = > -- = > 2.1.4 > = -- = Samuel "c'est pas nous qui sommes =E0 la rue, c'est la rue qui est =E0 nous" _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Tue Oct 27 15:47:43 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 27 Oct 2015 15:47:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr6TP-0003wP-Hk; Tue, 27 Oct 2015 15:47:43 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr6TO-0003wG-W2; Tue, 27 Oct 2015 15:47:43 +0000 Received: from [85.158.137.68] by server-16.bemta-3.messagelabs.com id D0/60-03763-E9C9F265; Tue, 27 Oct 2015 15:47:42 +0000 X-Env-Sender: samuel.thibault@ens-lyon.org X-Msg-Ref: server-4.tower-31.messagelabs.com!1445960861!55974791!1 X-Originating-IP: [192.134.164.83] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 3360 invoked from network); 27 Oct 2015 15:47:41 -0000 Received: from mail2-relais-roc.national.inria.fr (HELO mail2-relais-roc.national.inria.fr) (192.134.164.83) by server-4.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 27 Oct 2015 15:47:41 -0000 X-IronPort-AV: E=Sophos;i="5.20,205,1444687200"; d="scan'208";a="184693940" Received: from unknown (HELO var.ipv6) ([193.50.110.121]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/AES128-GCM-SHA256; 27 Oct 2015 16:47:40 +0100 Received: from samy by var.ipv6 with local (Exim 4.86) (envelope-from ) id 1Zr6TM-0000Ic-Ti; Tue, 27 Oct 2015 16:47:40 +0100 Date: Tue, 27 Oct 2015 16:47:40 +0100 From: Samuel Thibault To: Wei Liu Message-ID: <20151027154740.GF2483@var.bordeaux.inria.fr> Mail-Followup-To: Samuel Thibault , Wei Liu , minios-devel@lists.xenproject.org, Xen-devel , Ian Campbell , Ian Jackson References: <1445960609-16977-1-git-send-email-wei.liu2@citrix.com> <1445960609-16977-3-git-send-email-wei.liu2@citrix.com> MIME-Version: 1.0 Content-Length: 2512 Content-Disposition: inline In-Reply-To: <1445960609-16977-3-git-send-email-wei.liu2@citrix.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Cc: minios-devel@lists.xenproject.org, Xen-devel , Ian Jackson , Ian Campbell Subject: Re: [Minios-devel] [PATCH MINI-OS v3 2/2] xenbus: workaround oxenstored short-write X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Wei Liu, le Tue 27 Oct 2015 15:43:29 +0000, a =E9crit : > Oxenstored has a behaviour that it only writes a contiguous piece of > data. When it writes across ring boundary it will return a short-write > while there is still room. That leads to mini-os stalling when it sees > there is not enough data in the ring. > = > Given that oxenstored is the default xenstored implementation we think > it would be useful to workaround this for the benefit of running mini-os > (and unikernel based on it) on any Xen installation. > = > Signed-off-by: Wei Liu As discussed in the previous thread, this is rather a workaround. Better be safe than sorry. Acked-by: Samuel Thibault And could too be backported to stable branches. > --- > xenbus/xenbus.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > = > diff --git a/xenbus/xenbus.c b/xenbus/xenbus.c > index 0ab387a..abf8b1b 100644 > --- a/xenbus/xenbus.c > +++ b/xenbus/xenbus.c > @@ -205,8 +205,11 @@ static void xenbus_thread_func(void *ign) > prod =3D xenstore_buf->rsp_prod; > DEBUG("Rsp_cons %d, rsp_prod %d.\n", xenstore_buf->rsp_cons, > xenstore_buf->rsp_prod); > - if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < sizeof= (msg)) > + if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < sizeof= (msg)) { > + /* Work around oxenstored bug */ > + notify_remote_via_evtchn(start_info.store_evtchn); > break; > + } > rmb(); > memcpy_from_ring(xenstore_buf->rsp, > &msg, > @@ -217,8 +220,11 @@ static void xenbus_thread_func(void *ign) > xenstore_buf->rsp_prod - xenstore_buf->rsp_cons, > msg.req_id); > if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < > - sizeof(msg) + msg.len) > + sizeof(msg) + msg.len) { > + /* Work around oxenstored bug */ > + notify_remote_via_evtchn(start_info.store_evtchn); > break; > + } > = > DEBUG("Message is good.\n"); > = > -- = > 2.1.4 > = -- = Samuel "c'est pas nous qui sommes =E0 la rue, c'est la rue qui est =E0 nous" _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Tue Oct 27 15:55:41 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 27 Oct 2015 15:55:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr6b5-0004Ld-GE; Tue, 27 Oct 2015 15:55:39 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr6b3-0004LV-TD; Tue, 27 Oct 2015 15:55:38 +0000 Received: from [85.158.139.211] by server-17.bemta-5.messagelabs.com id FF/42-18107-97E9F265; Tue, 27 Oct 2015 15:55:37 +0000 X-Env-Sender: prvs=7352c57fe=wei.liu2@citrix.com X-Msg-Ref: server-5.tower-206.messagelabs.com!1445961334!45486042!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 6782 invoked from network); 27 Oct 2015 15:55:36 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-5.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 27 Oct 2015 15:55:36 -0000 X-IronPort-AV: E=Sophos;i="5.20,205,1444694400"; d="scan'208";a="313750539" Date: Tue, 27 Oct 2015 15:55:33 +0000 From: Wei Liu To: Samuel Thibault , Wei Liu , , Xen-devel , Ian Campbell , "Ian Jackson" Message-ID: <20151027155533.GZ18674@zion.uk.xensource.com> References: <1445960609-16977-1-git-send-email-wei.liu2@citrix.com> <1445960609-16977-2-git-send-email-wei.liu2@citrix.com> <20151027154643.GE2483@var.bordeaux.inria.fr> MIME-Version: 1.0 Content-Length: 986 Content-Disposition: inline In-Reply-To: <20151027154643.GE2483@var.bordeaux.inria.fr> User-Agent: Mutt/1.5.23 (2014-03-12) X-DLP: MIA1 Subject: Re: [Minios-devel] [PATCH MINI-OS v3 1/2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Tue, Oct 27, 2015 at 04:46:43PM +0100, Samuel Thibault wrote: > Wei Liu, le Tue 27 Oct 2015 15:43:28 +0000, a =E9crit : > > The xenbus thread didn't send notification to other end when it expected > > more data or consumed responses, which led to stalling the ring from > > time to time. > > = > > This is the culprit that guest was less responsive when using stubdom > > because the device model was stalled. > > = > > Fix this by sending notification to the other end when it consumes a > > message. A bunch of memory barriers are also added to ensure > > correctness. > > = > > Signed-off-by: Wei Liu > = > Acked-by: Samuel Thibault > = Thanks for your help along the way! > And it should clearly be backported to stable branches. > = > Samuel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Tue Oct 27 15:55:41 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 27 Oct 2015 15:55:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr6b5-0004Ld-GE; Tue, 27 Oct 2015 15:55:39 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr6b3-0004LV-TD; Tue, 27 Oct 2015 15:55:38 +0000 Received: from [85.158.139.211] by server-17.bemta-5.messagelabs.com id FF/42-18107-97E9F265; Tue, 27 Oct 2015 15:55:37 +0000 X-Env-Sender: prvs=7352c57fe=wei.liu2@citrix.com X-Msg-Ref: server-5.tower-206.messagelabs.com!1445961334!45486042!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 6782 invoked from network); 27 Oct 2015 15:55:36 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-5.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 27 Oct 2015 15:55:36 -0000 X-IronPort-AV: E=Sophos;i="5.20,205,1444694400"; d="scan'208";a="313750539" Date: Tue, 27 Oct 2015 15:55:33 +0000 From: Wei Liu To: Samuel Thibault , Wei Liu , , Xen-devel , Ian Campbell , "Ian Jackson" Message-ID: <20151027155533.GZ18674@zion.uk.xensource.com> References: <1445960609-16977-1-git-send-email-wei.liu2@citrix.com> <1445960609-16977-2-git-send-email-wei.liu2@citrix.com> <20151027154643.GE2483@var.bordeaux.inria.fr> MIME-Version: 1.0 Content-Length: 986 Content-Disposition: inline In-Reply-To: <20151027154643.GE2483@var.bordeaux.inria.fr> User-Agent: Mutt/1.5.23 (2014-03-12) X-DLP: MIA1 Subject: Re: [Minios-devel] [PATCH MINI-OS v3 1/2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org On Tue, Oct 27, 2015 at 04:46:43PM +0100, Samuel Thibault wrote: > Wei Liu, le Tue 27 Oct 2015 15:43:28 +0000, a =E9crit : > > The xenbus thread didn't send notification to other end when it expected > > more data or consumed responses, which led to stalling the ring from > > time to time. > > = > > This is the culprit that guest was less responsive when using stubdom > > because the device model was stalled. > > = > > Fix this by sending notification to the other end when it consumes a > > message. A bunch of memory barriers are also added to ensure > > correctness. > > = > > Signed-off-by: Wei Liu > = > Acked-by: Samuel Thibault > = Thanks for your help along the way! > And it should clearly be backported to stable branches. > = > Samuel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Tue Oct 27 16:03:37 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 27 Oct 2015 16:03:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr6im-0005M7-WD; Tue, 27 Oct 2015 16:03:36 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr6il-0005LU-6S; Tue, 27 Oct 2015 16:03:35 +0000 Received: from [85.158.137.68] by server-5.bemta-3.messagelabs.com id 13/AE-01748-650AF265; Tue, 27 Oct 2015 16:03:34 +0000 X-Env-Sender: samuel.thibault@ens-lyon.org X-Msg-Ref: server-8.tower-31.messagelabs.com!1445961813!57221044!1 X-Originating-IP: [192.134.164.83] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 10995 invoked from network); 27 Oct 2015 16:03:33 -0000 Received: from mail2-relais-roc.national.inria.fr (HELO mail2-relais-roc.national.inria.fr) (192.134.164.83) by server-8.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 27 Oct 2015 16:03:33 -0000 X-IronPort-AV: E=Sophos;i="5.20,205,1444687200"; d="scan'208";a="184697275" Received: from unknown (HELO var.ipv6) ([193.50.110.121]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/AES128-GCM-SHA256; 27 Oct 2015 17:03:33 +0100 Received: from samy by var.ipv6 with local (Exim 4.86) (envelope-from ) id 1Zr6ii-0000pl-VZ; Tue, 27 Oct 2015 17:03:32 +0100 Date: Tue, 27 Oct 2015 17:03:32 +0100 From: Samuel Thibault To: Wei Liu , Ian Jackson , minios-devel@lists.xenproject.org, Xen-devel , Ian Campbell Message-ID: <20151027160332.GA2931@var.bordeaux.inria.fr> Mail-Followup-To: Samuel Thibault , Wei Liu , Ian Jackson , minios-devel@lists.xenproject.org, Xen-devel , Ian Campbell References: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> <20151026125247.GP19459@var.bordeaux.inria.fr> <20151026135531.GG13118@zion.uk.xensource.com> <20151026163001.GF18602@var.bordeaux.inria.fr> <22062.21898.162478.153744@mariner.uk.xensource.com> <20151026163751.GH18602@var.bordeaux.inria.fr> <20151026164115.GE19925@zion.uk.xensource.com> <20151026171104.GJ18602@var.bordeaux.inria.fr> MIME-Version: 1.0 Content-Length:1091 Content-Disposition: inline In-Reply-To: <20151026171104.GJ18602@var.bordeaux.inria.fr> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Subject: Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Samuel Thibault, le Mon 26 Oct 2015 18:11:04 +0100, a =E9crit : > diff --git a/tools/ocaml/libs/xb/xb.ml b/tools/ocaml/libs/xb/xb.ml > index 50944b5..33298d2 100644 > --- a/tools/ocaml/libs/xb/xb.ml > +++ b/tools/ocaml/libs/xb/xb.ml > @@ -91,10 +91,12 @@ let write_fd back con s len =3D > Unix.write back.fd s 0 len > = > let write_mmap back con s len =3D > - let ws =3D Xs_ring.write back.mmap s len in > - if ws > 0 then > + let ws =3D ref (Xs_ring.write back.mmap s len) in > + if !ws < len then > + ws :=3D !ws + Xs_ring.write back.mmap (String.sub s !ws (len-!ws)) (le= n-!ws); > + if !ws > 0 then > back.eventchn_notify (); > - ws > + !ws > = > let write con s len =3D > match con.backend with Signed-off-by: Samuel Thibault Not-tested-by: Samuel Thibault Not-even-compiled-by: Samuel Thibault Samuel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel From minios-devel-bounces@lists.xenproject.org Tue Oct 27 16:03:37 2015 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 27 Oct 2015 16:03:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr6im-0005M7-WD; Tue, 27 Oct 2015 16:03:36 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr6il-0005LU-6S; Tue, 27 Oct 2015 16:03:35 +0000 Received: from [85.158.137.68] by server-5.bemta-3.messagelabs.com id 13/AE-01748-650AF265; Tue, 27 Oct 2015 16:03:34 +0000 X-Env-Sender: samuel.thibault@ens-lyon.org X-Msg-Ref: server-8.tower-31.messagelabs.com!1445961813!57221044!1 X-Originating-IP: [192.134.164.83] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 10995 invoked from network); 27 Oct 2015 16:03:33 -0000 Received: from mail2-relais-roc.national.inria.fr (HELO mail2-relais-roc.national.inria.fr) (192.134.164.83) by server-8.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 27 Oct 2015 16:03:33 -0000 X-IronPort-AV: E=Sophos;i="5.20,205,1444687200"; d="scan'208";a="184697275" Received: from unknown (HELO var.ipv6) ([193.50.110.121]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/AES128-GCM-SHA256; 27 Oct 2015 17:03:33 +0100 Received: from samy by var.ipv6 with local (Exim 4.86) (envelope-from ) id 1Zr6ii-0000pl-VZ; Tue, 27 Oct 2015 17:03:32 +0100 Date: Tue, 27 Oct 2015 17:03:32 +0100 From: Samuel Thibault To: Wei Liu , Ian Jackson , minios-devel@lists.xenproject.org, Xen-devel , Ian Campbell Message-ID: <20151027160332.GA2931@var.bordeaux.inria.fr> Mail-Followup-To: Samuel Thibault , Wei Liu , Ian Jackson , minios-devel@lists.xenproject.org, Xen-devel , Ian Campbell References: <1445863676-14874-1-git-send-email-wei.liu2@citrix.com> <20151026125247.GP19459@var.bordeaux.inria.fr> <20151026135531.GG13118@zion.uk.xensource.com> <20151026163001.GF18602@var.bordeaux.inria.fr> <22062.21898.162478.153744@mariner.uk.xensource.com> <20151026163751.GH18602@var.bordeaux.inria.fr> <20151026164115.GE19925@zion.uk.xensource.com> <20151026171104.GJ18602@var.bordeaux.inria.fr> MIME-Version: 1.0 Content-Length:1091 Content-Disposition: inline In-Reply-To: <20151026171104.GJ18602@var.bordeaux.inria.fr> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Subject: Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary X-BeenThere: minios-devel@lists.xenproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: minios-devel-bounces@lists.xenproject.org Errors-To: minios-devel-bounces@lists.xenproject.org Samuel Thibault, le Mon 26 Oct 2015 18:11:04 +0100, a =E9crit : > diff --git a/tools/ocaml/libs/xb/xb.ml b/tools/ocaml/libs/xb/xb.ml > index 50944b5..33298d2 100644 > --- a/tools/ocaml/libs/xb/xb.ml > +++ b/tools/ocaml/libs/xb/xb.ml > @@ -91,10 +91,12 @@ let write_fd back con s len =3D > Unix.write back.fd s 0 len > = > let write_mmap back con s len =3D > - let ws =3D Xs_ring.write back.mmap s len in > - if ws > 0 then > + let ws =3D ref (Xs_ring.write back.mmap s len) in > + if !ws < len then > + ws :=3D !ws + Xs_ring.write back.mmap (String.sub s !ws (len-!ws)) (le= n-!ws); > + if !ws > 0 then > back.eventchn_notify (); > - ws > + !ws > = > let write con s len =3D > match con.backend with Signed-off-by: Samuel Thibault Not-tested-by: Samuel Thibault Not-even-compiled-by: Samuel Thibault Samuel _______________________________________________ Minios-devel mailing list Minios-devel@lists.xenproject.org http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel