From minios-devel-bounces@lists.xenproject.org Fri Feb 03 09:18:24 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 03 Feb 2023 09:18:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489053.757353 (Exim 4.92) (envelope-from ) id 1pNsD5-0006qP-MQ; Fri, 03 Feb 2023 09:18:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489053.757353; Fri, 03 Feb 2023 09:18:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsD5-0006qF-Gd; Fri, 03 Feb 2023 09:18:19 +0000 Received: by outflank-mailman (input) for mailman id 489053; Fri, 03 Feb 2023 09:18:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsD4-0006pI-8N for minios-devel@lists.xenproject.org; Fri, 03 Feb 2023 09:18:18 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aed2bf58-a3a3-11ed-9254-a70e01b1f5fa; Fri, 03 Feb 2023 10:18:14 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4C6923447B; Fri, 3 Feb 2023 09:18:12 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1FCA31346D; Fri, 3 Feb 2023 09:18:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id rJZoBlTR3GMEEwAAMHmgww (envelope-from ); Fri, 03 Feb 2023 09:18:12 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: aed2bf58-a3a3-11ed-9254-a70e01b1f5fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675415892; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=lKKJC6YtNCf8aiN934Ne7s/FwvZH2vXGkqQ7iJjfCoc=; b=bIVE2i7Ah9bPQR9b5WIX7DOvSsZvUP1ODjO58clZnz/27q437oW9hjZ9ZWYFmN0UqP58RJ YwyH7w+yPxuTV9r1IqFb27JpdKbHiADMvpq/gI8JGSLxu25kfdODHf/+naoUFbL8V5H+5+ XNcQdKU2va5dmK8e3lMTkPoSfGW+m0E= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH 0/7] Mini-OS: ad minimal 9pfs support Date: Fri, 3 Feb 2023 10:18:02 +0100 Message-Id: <20230203091809.14478-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series is adding minimal support to use 9pfs in Mini-OS. It is adding a PV 9pfs frontend and the ability to open, close, read and write files. The series has been tested with qemu as 9pfs backend in a PVH Mini-OS guest (I've used a slightly modified Xenstore-stubdom for that purpose in order to reuse the build runes). This series is meant to setup the stage for adding file based logging support to Xenstore-stubdom and later to add live update support (being able to save the LU data stream in a dom0 file makes this a _lot_ easier). In order to keep Mini-OS's license I have only used the protocol docs available on the internet [1] and the verified those with the qemu 9pfs backend implementation (especially for supporting the 9P2000.u variant, as qemu doesn't support the basic 9P2000 protocol). The needed fixed values of the protocol have been taken from [2]. [1]: http://ericvh.github.io/9p-rfc/rfc9p2000.html [2]: https://github.com/0intro/libixp Juergen Gross (7): Mini-OS: xenbus: add support for reading node from directory Mini-OS: add concept of mount points Mini-OS: add support for runtime mounts Mini-OS: add 9pfs frontend Mini-OS: add 9pfs transport layer Mini-OS: add open and close handling to the 9pfs frontend Mini-OS: add read and write support to 9pfsfront 9pfront.c | 1201 +++++++++++++++++++++++++++++++++ Config.mk | 1 + Makefile | 1 + arch/x86/testbuild/all-no | 1 + arch/x86/testbuild/all-yes | 1 + arch/x86/testbuild/newxen-yes | 1 + include/9pfront.h | 7 + include/lib.h | 14 + include/xenbus.h | 6 + lib/sys.c | 128 +++- xenbus.c | 39 +- 11 files changed, 1378 insertions(+), 22 deletions(-) create mode 100644 9pfront.c create mode 100644 include/9pfront.h -- 2.35.3 From minios-devel-bounces@lists.xenproject.org Fri Feb 03 09:18:25 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 03 Feb 2023 09:18:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489055.757365 (Exim 4.92) (envelope-from ) id 1pNsD7-00078t-RT; Fri, 03 Feb 2023 09:18:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489055.757365; Fri, 03 Feb 2023 09:18:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsD7-00078m-OW; Fri, 03 Feb 2023 09:18:21 +0000 Received: by outflank-mailman (input) for mailman id 489055; Fri, 03 Feb 2023 09:18:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsD6-0006sG-Qf for minios-devel@lists.xenproject.org; Fri, 03 Feb 2023 09:18:20 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b1f94e37-a3a3-11ed-933c-83870f6b2ba8; Fri, 03 Feb 2023 10:18:19 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D4C3C20FB1; Fri, 3 Feb 2023 09:18:17 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AB8B01346D; Fri, 3 Feb 2023 09:18:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id oqyuKFnR3GMREwAAMHmgww (envelope-from ); Fri, 03 Feb 2023 09:18:17 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: b1f94e37-a3a3-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675415897; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z81Lk0F6Fek1HMkTBl7IwshhUmTJkCu1CQ5yFDMGHEk=; b=qPrMTeO36fOo9LpfULKQZr0DuSFU+In+5S3JH3QghH/n9PK7erMaAdu72JKpbbe8/P5tpp arucenRLw4PDxTzX+LHI8sYVY/XY21Ydwt/mmJzhmuQFZgcd/rb8iACWWNas2uVEi0uswy cFcQYoZxRsj2afrV/yqX99DzOtCIlGs= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH 1/7] Mini-OS: xenbus: add support for reading node from directory Date: Fri, 3 Feb 2023 10:18:03 +0100 Message-Id: <20230203091809.14478-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230203091809.14478-1-jgross@suse.com> References: <20230203091809.14478-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Especially PV device drivers often need to read multiple Xenstore nodes from a common dirctory. Add support for reading a string or an unsigned value by specifying the directory and the node. Signed-off-by: Juergen Gross --- include/xenbus.h | 6 ++++++ xenbus.c | 39 ++++++++++++++++++++++++++++++++++++--- 2 files changed, 42 insertions(+), 3 deletions(-) diff --git a/include/xenbus.h b/include/xenbus.h index 3871f358..c0fc0ac5 100644 --- a/include/xenbus.h +++ b/include/xenbus.h @@ -108,6 +108,12 @@ int xenbus_read_integer(const char *path); * read and parsing were successful, 0 if not */ int xenbus_read_uuid(const char* path, unsigned char uuid[16]); +/* Support functions for reading values from directory/node tuple. */ +char *xenbus_read_string(xenbus_transaction_t xbt, const char *dir, + const char *node, char **value); +char *xenbus_read_unsigned(xenbus_transaction_t xbt, const char *dir, + const char *node, unsigned int *value); + /* Contraction of snprintf and xenbus_write(path/node). */ char* xenbus_printf(xenbus_transaction_t xbt, const char* node, const char* path, diff --git a/xenbus.c b/xenbus.c index 81e9b65d..811cde25 100644 --- a/xenbus.c +++ b/xenbus.c @@ -936,16 +936,21 @@ int xenbus_read_uuid(const char *path, unsigned char uuid[16]) return 1; } +#define BUFFER_SIZE 256 +static void xenbus_build_path(const char *dir, const char *node, char *res) +{ + BUG_ON(strlen(dir) + strlen(node) + 1 >= BUFFER_SIZE); + sprintf(res,"%s/%s", dir, node); +} + char *xenbus_printf(xenbus_transaction_t xbt, const char* node, const char* path, const char* fmt, ...) { -#define BUFFER_SIZE 256 char fullpath[BUFFER_SIZE]; char val[BUFFER_SIZE]; va_list args; - BUG_ON(strlen(node) + strlen(path) + 1 >= BUFFER_SIZE); - sprintf(fullpath,"%s/%s", node, path); + xenbus_build_path(node, path, fullpath); va_start(args, fmt); vsprintf(val, fmt, args); va_end(args); @@ -964,6 +969,34 @@ domid_t xenbus_get_self_id(void) return ret; } +char *xenbus_read_string(xenbus_transaction_t xbt, const char *dir, + const char *node, char **value) +{ + char path[BUFFER_SIZE]; + + xenbus_build_path(dir, node, path); + + return xenbus_read(xbt, path, value); +} + +char *xenbus_read_unsigned(xenbus_transaction_t xbt, const char *dir, + const char *node, unsigned int *value) +{ + char path[BUFFER_SIZE]; + char *msg; + char *str; + + xenbus_build_path(dir, node, path); + msg = xenbus_read(xbt, path, &str); + if ( msg ) + return msg; + + sscanf(str, "%u", value); + free(str); + + return NULL; +} + /* * Local variables: * mode: C -- 2.35.3 From minios-devel-bounces@lists.xenproject.org Fri Feb 03 09:18:29 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 03 Feb 2023 09:18:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489058.757392 (Exim 4.92) (envelope-from ) id 1pNsDF-0007kG-Db; Fri, 03 Feb 2023 09:18:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489058.757392; Fri, 03 Feb 2023 09:18:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsDF-0007k8-AL; Fri, 03 Feb 2023 09:18:29 +0000 Received: by outflank-mailman (input) for mailman id 489058; Fri, 03 Feb 2023 09:18:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsDD-0006pI-F5 for minios-devel@lists.xenproject.org; Fri, 03 Feb 2023 09:18:27 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b54821c0-a3a3-11ed-9254-a70e01b1f5fa; Fri, 03 Feb 2023 10:18:23 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6FA9D3447B; Fri, 3 Feb 2023 09:18:23 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 48E911346D; Fri, 3 Feb 2023 09:18:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KfqgEF/R3GMcEwAAMHmgww (envelope-from ); Fri, 03 Feb 2023 09:18:23 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: b54821c0-a3a3-11ed-9254-a70e01b1f5fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675415903; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u/eAoULjmKQ205Pb/0fKq3T8ckSspq3tkjdl4gh7sRs=; b=CWGwhVzTH3faw0JgioySSsL+u67Fu9JB16kROsA1CGyMu8YXLsaqi6t2DmoNR9S94xK3ll Llk00mmYQ9l6l4YZ9nh5mpuGobtmGGRh6AtpEwt5tXQcyUJ2suymbcTAJM9cApjGGe0Ef/ cMbNHex5rMnd25/Ra9QuSHXWbN6emWs= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH 2/7] Mini-OS: add concept of mount points Date: Fri, 3 Feb 2023 10:18:04 +0100 Message-Id: <20230203091809.14478-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230203091809.14478-1-jgross@suse.com> References: <20230203091809.14478-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the concept of mount points to Mini-OS. A mount point is a path associated with a device pointer and an open() callback. A mount point can be either a file (e.g. "/dev/mem") or a directory ("/var/log"). This allows to replace the special casing in the generic open() handling with a generic mount point handling. Prepare the open() callbacks to support creating new files by adding a mode parameter. Additionally add a close() prototype to include/lib.h, as it is missing today. Signed-off-by: Juergen Gross --- include/lib.h | 9 ++++++ lib/sys.c | 80 +++++++++++++++++++++++++++++++++++++++------------ 2 files changed, 70 insertions(+), 19 deletions(-) diff --git a/include/lib.h b/include/lib.h index bec99646..36d94ec4 100644 --- a/include/lib.h +++ b/include/lib.h @@ -187,6 +187,13 @@ struct file_ops { bool (*select_wr)(struct file *file); }; +struct mount_point { + const char *path; + int (*open)(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode); + void *dev; +}; + unsigned int alloc_file_type(const struct file_ops *ops); off_t lseek_default(struct file *file, off_t offset, int whence); @@ -198,6 +205,8 @@ int alloc_fd(unsigned int type); void close_all_files(void); extern struct thread *main_thread; void sparse(unsigned long data, size_t size); + +int close(int fd); #endif #endif /* _LIB_H_ */ diff --git a/lib/sys.c b/lib/sys.c index 8f8a3de2..1475c621 100644 --- a/lib/sys.c +++ b/lib/sys.c @@ -263,11 +263,6 @@ char *getcwd(char *buf, size_t size) return buf; } -#define LOG_PATH "/var/log/" -#define SAVE_PATH "/var/lib/xen" -#define SAVE_CONSOLE 1 -#define RESTORE_CONSOLE 2 - int mkdir(const char *pathname, mode_t mode) { errno = EIO; @@ -286,18 +281,30 @@ int posix_openpt(int flags) return fd; } +static int open_pt(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode) +{ + return posix_openpt(flags); +} + int open_savefile(const char *path, int save) { int fd; char nodename[64]; - snprintf(nodename, sizeof(nodename), "device/console/%d", save ? SAVE_CONSOLE : RESTORE_CONSOLE); + snprintf(nodename, sizeof(nodename), "device/console/%d", save ? 1 : 2); fd = open_consfront(nodename); printk("fd(%d) = open_savefile\n", fd); return fd; } + +static int open_save(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode) +{ + return open_savefile(pathname, flags & O_WRONLY); +} #else int posix_openpt(int flags) { @@ -311,24 +318,59 @@ int open_savefile(const char *path, int save) } #endif -int open(const char *pathname, int flags, ...) +static int open_log(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode) { int fd; + /* Ugly, but fine. */ - if (!strncmp(pathname,LOG_PATH,strlen(LOG_PATH))) { - fd = alloc_fd(FTYPE_CONSOLE); - printk("open(%s) -> %d\n", pathname, fd); - return fd; + fd = alloc_fd(FTYPE_CONSOLE); + printk("open(%s) -> %d\n", pathname, fd); + return fd; +} + +static int open_mem(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode) +{ + int fd; + + fd = alloc_fd(FTYPE_MEM); + printk("open(%s) -> %d\n", pathname, fd); + return fd; +} + +static struct mount_point mount_points[] = { + { .path = "/var/log", .open = open_log, .dev = NULL }, + { .path = "/dev/mem", .open = open_mem, .dev = NULL }, +#ifdef CONFIG_CONSFRONT + { .path = "/dev/ptmx", .open = open_pt, .dev = NULL }, + { .path = "/var/lib/xen", .open = open_save, .dev = NULL }, +#endif +}; + +int open(const char *pathname, int flags, ...) +{ + unsigned int m, mlen; + struct mount_point *mnt; + mode_t mode = 0; + va_list ap; + + if ( flags & O_CREAT ) + { + va_start(ap, flags); + mode = va_arg(ap, mode_t); + va_end(ap); } - if (!strncmp(pathname, "/dev/mem", strlen("/dev/mem"))) { - fd = alloc_fd(FTYPE_MEM); - printk("open(/dev/mem) -> %d\n", fd); - return fd; + + for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) + { + mnt = mount_points + m; + mlen = strlen(mnt->path); + if ( !strncmp(pathname, mnt->path, mlen) && + (pathname[mlen] == '/' || pathname[mlen] == 0) ) + return mnt->open(mnt, pathname, flags, mode); } - if (!strncmp(pathname, "/dev/ptmx", strlen("/dev/ptmx"))) - return posix_openpt(flags); - if (!strncmp(pathname,SAVE_PATH,strlen(SAVE_PATH))) - return open_savefile(pathname, flags & O_WRONLY); + errno = EIO; return -1; } -- 2.35.3 From minios-devel-bounces@lists.xenproject.org Fri Feb 03 09:18:32 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 03 Feb 2023 09:18:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489060.757406 (Exim 4.92) (envelope-from ) id 1pNsDI-00084Z-QD; Fri, 03 Feb 2023 09:18:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489060.757406; Fri, 03 Feb 2023 09:18:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsDI-000843-MP; Fri, 03 Feb 2023 09:18:32 +0000 Received: by outflank-mailman (input) for mailman id 489060; Fri, 03 Feb 2023 09:18:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsDG-0006sG-OR for minios-devel@lists.xenproject.org; Fri, 03 Feb 2023 09:18:30 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b8a0311c-a3a3-11ed-933c-83870f6b2ba8; Fri, 03 Feb 2023 10:18:29 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 079943447D; Fri, 3 Feb 2023 09:18:29 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D2CB01346D; Fri, 3 Feb 2023 09:18:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Jm4sMmTR3GMkEwAAMHmgww (envelope-from ); Fri, 03 Feb 2023 09:18:28 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: b8a0311c-a3a3-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675415909; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GtWQKRAyY57feFJk8BbUzmL2nez/i6gSp+ydtlu7X9A=; b=W2spmIMlIzYekMsW/Nktfe/U0VVGVGHAsO/wqtUDQBwSfMriG+gLhv4eU8qX16ZeD2kqxU ZwKQEMJBklXMCsymSYU8e5wjFP83bBCQJHQuI898uqC2ZZh+HcL+lDyUoAEP0pp2V4jebs xzCkqi97iujyPKCo0BapNivCn+zUZbs= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH 3/7] Mini-OS: add support for runtime mounts Date: Fri, 3 Feb 2023 10:18:05 +0100 Message-Id: <20230203091809.14478-4-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230203091809.14478-1-jgross@suse.com> References: <20230203091809.14478-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the support to mount a device at runtime. The number of dynamic mounts is limited by a #define. For devices supporting multiple files struct file is modified to hold a pointer to file specific data in contrast to device specific data. Signed-off-by: Juergen Gross --- include/lib.h | 5 +++++ lib/sys.c | 50 +++++++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 54 insertions(+), 1 deletion(-) diff --git a/include/lib.h b/include/lib.h index 36d94ec4..fd8c36de 100644 --- a/include/lib.h +++ b/include/lib.h @@ -172,6 +172,7 @@ struct file { union { int fd; /* Any fd from an upper layer. */ void *dev; + void *filedata; }; }; @@ -194,6 +195,10 @@ struct mount_point { void *dev; }; +int mount(const char *path, void *dev, + int (*open)(struct mount_point *, const char *, int, mode_t)); +void umount(const char *path); + unsigned int alloc_file_type(const struct file_ops *ops); off_t lseek_default(struct file *file, off_t offset, int whence); diff --git a/lib/sys.c b/lib/sys.c index 1475c621..4171bfd6 100644 --- a/lib/sys.c +++ b/lib/sys.c @@ -339,7 +339,14 @@ static int open_mem(struct mount_point *mnt, const char *pathname, int flags, return fd; } -static struct mount_point mount_points[] = { +#ifdef CONFIG_CONSFRONT +#define STATIC_MNTS 4 +#else +#define STATIC_MNTS 2 +#endif +#define DYNAMIC_MNTS 8 + +static struct mount_point mount_points[STATIC_MNTS + DYNAMIC_MNTS] = { { .path = "/var/log", .open = open_log, .dev = NULL }, { .path = "/dev/mem", .open = open_mem, .dev = NULL }, #ifdef CONFIG_CONSFRONT @@ -365,6 +372,8 @@ int open(const char *pathname, int flags, ...) for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) { mnt = mount_points + m; + if ( !mnt->path ) + continue; mlen = strlen(mnt->path); if ( !strncmp(pathname, mnt->path, mlen) && (pathname[mlen] == '/' || pathname[mlen] == 0) ) @@ -375,6 +384,45 @@ int open(const char *pathname, int flags, ...) return -1; } +int mount(const char *path, void *dev, + int (*open)(struct mount_point *, const char *, int, mode_t)) +{ + unsigned int m; + struct mount_point *mnt; + + for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) + { + mnt = mount_points + m; + if ( !mnt->path ) + { + mnt->path = strdup(path); + mnt->open = open; + mnt->dev = dev; + return 0; + } + } + + errno = ENOSPC; + return -1; +} + +void umount(const char *path) +{ + unsigned int m; + struct mount_point *mnt; + + for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) + { + mnt = mount_points + m; + if ( mnt->path && !strcmp(mnt->path, path) ) + { + free((char *)mnt->path); + mnt->path = NULL; + return; + } + } +} + int isatty(int fd) { return files[fd].type == FTYPE_CONSOLE; -- 2.35.3 From minios-devel-bounces@lists.xenproject.org Fri Feb 03 09:18:40 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 03 Feb 2023 09:18:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489067.757415 (Exim 4.92) (envelope-from ) id 1pNsDQ-0008PT-8b; Fri, 03 Feb 2023 09:18:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489067.757415; Fri, 03 Feb 2023 09:18:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsDQ-0008Oz-2i; Fri, 03 Feb 2023 09:18:40 +0000 Received: by outflank-mailman (input) for mailman id 489067; Fri, 03 Feb 2023 09:18:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsDO-0006pI-GU for minios-devel@lists.xenproject.org; Fri, 03 Feb 2023 09:18:38 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bc0146c9-a3a3-11ed-9254-a70e01b1f5fa; Fri, 03 Feb 2023 10:18:34 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 96F2020FB2; Fri, 3 Feb 2023 09:18:34 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 678211346D; Fri, 3 Feb 2023 09:18:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cND9F2rR3GMzEwAAMHmgww (envelope-from ); Fri, 03 Feb 2023 09:18:34 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: bc0146c9-a3a3-11ed-9254-a70e01b1f5fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675415914; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6iYbZqvNtZ/TCv37DDm/n8MEFIvNUWO9D/z+764HvEc=; b=PvSNSH+NewoOoU0ugPNEvH9zAz1FTuOTWeZRPgVfEAh2zOCt3CuVjrHsE/PVoffjxKN0EU JcvwnbAM8zx6M0mTZvzKCKjkZwm0qKCCIXNoNsUkPEH29Vb9hOPSYxgplT9PLN5adHiTON oTi/haqrs6ss8lsydRGnu13UQJRB4Q0= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH 4/7] Mini-OS: add 9pfs frontend Date: Fri, 3 Feb 2023 10:18:06 +0100 Message-Id: <20230203091809.14478-5-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230203091809.14478-1-jgross@suse.com> References: <20230203091809.14478-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a frontend for the 9pfs PV device. For now add only the code needed to connect to the backend and the related disconnect functionality. The 9pfs protocol support will be added later. Due to its nature (ability to access files) the whole code is guarded by "#ifdef HAVE_LIBC". Signed-off-by: Juergen Gross --- 9pfront.c | 280 ++++++++++++++++++++++++++++++++++ Config.mk | 1 + Makefile | 1 + arch/x86/testbuild/all-no | 1 + arch/x86/testbuild/all-yes | 1 + arch/x86/testbuild/newxen-yes | 1 + include/9pfront.h | 7 + 7 files changed, 292 insertions(+) create mode 100644 9pfront.c create mode 100644 include/9pfront.h diff --git a/9pfront.c b/9pfront.c new file mode 100644 index 00000000..cf4b5cb3 --- /dev/null +++ b/9pfront.c @@ -0,0 +1,280 @@ +/* + * Minimal 9pfs PV frontend for Mini-OS. + * Copyright (c) 2023 Juergen Gross, SUSE Software Solution GmbH + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#ifdef HAVE_LIBC +struct dev_9pfs { + int id; + char nodename[20]; + unsigned int dom; + char *backend; + + char *tag; + const char *mnt; + + struct xen_9pfs_data_intf *intf; + struct xen_9pfs_data data; + RING_IDX prod_pvt_out; + RING_IDX cons_pvt_in; + + grant_ref_t ring_ref; + evtchn_port_t evtchn; + unsigned int ring_order; + xenbus_event_queue events; +}; + +#define DEFAULT_9PFS_RING_ORDER 4 + +static unsigned int ftype_9pfs; + +static void intr_9pfs(evtchn_port_t port, struct pt_regs *regs, void *data) +{ +} + +static int open_9pfs(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode) +{ + errno = ENOSYS; + + return -1; +} + +static void free_9pfront(struct dev_9pfs *dev) +{ + unsigned int i; + + if ( dev->data.in && dev->intf ) + { + for ( i = 0; i < (1 << dev->ring_order); i++ ) + gnttab_end_access(dev->intf->ref[i]); + free_pages(dev->data.in, dev->ring_order); + } + unbind_evtchn(dev->evtchn); + gnttab_end_access(dev->ring_ref); + free_page(dev->intf); + free(dev->backend); + free(dev->tag); + free(dev); +} + +void *init_9pfront(unsigned int id, const char *mnt) +{ + struct dev_9pfs *dev; + char *msg; + char *reason = ""; + xenbus_transaction_t xbt; + int retry = 1; + char bepath[64] = { 0 }; + XenbusState state; + unsigned int i; + void *addr; + char *version; + char *v; + + printk("9pfsfront add %u, for mount at %s\n", id, mnt); + dev = malloc(sizeof(*dev)); + memset(dev, 0, sizeof(*dev)); + snprintf(dev->nodename, sizeof(dev->nodename), "device/9pfs/%u", id); + dev->id = id; + + msg = xenbus_read_unsigned(XBT_NIL, dev->nodename, "backend-id", &dev->dom); + if ( msg ) + goto err; + msg = xenbus_read_string(XBT_NIL, dev->nodename, "backend", &dev->backend); + if ( msg ) + goto err; + msg = xenbus_read_string(XBT_NIL, dev->nodename, "tag", &dev->tag); + if ( msg ) + goto err; + + snprintf(bepath, sizeof(bepath), "%s/state", dev->backend); + free(xenbus_watch_path_token(XBT_NIL, bepath, bepath, &dev->events)); + state = xenbus_read_integer(bepath); + while ( msg == NULL && state < XenbusStateInitWait ) + msg = xenbus_wait_for_state_change(bepath, &state, &dev->events); + if ( msg || state != XenbusStateInitWait ) + { + reason = "illegal backend state"; + goto err; + } + + msg = xenbus_read_unsigned(XBT_NIL, dev->backend, "max-ring-page-order", + &dev->ring_order); + if ( msg ) + goto err; + if ( dev->ring_order > DEFAULT_9PFS_RING_ORDER ) + dev->ring_order = DEFAULT_9PFS_RING_ORDER; + + msg = xenbus_read_string(XBT_NIL, dev->backend, "versions", &version); + if ( msg ) + goto err; + for ( v = version; *v; v++ ) + { + if ( strtoul(v, &v, 10) == 1 ) + { + v = NULL; + break; + } + } + free(version); + if ( v ) + { + reason = "version 1 not supported"; + goto err; + } + + dev->ring_ref = gnttab_alloc_and_grant((void **)&dev->intf); + memset(dev->intf, 0, PAGE_SIZE); + if ( evtchn_alloc_unbound(dev->dom, intr_9pfs, dev, &dev->evtchn) ) + { + reason = "no event channel"; + goto err; + } + dev->intf->ring_order = dev->ring_order; + dev->data.in = (void *)alloc_pages(dev->ring_order); + dev->data.out = dev->data.in + XEN_FLEX_RING_SIZE(dev->ring_order); + for ( i = 0; i < (1 << dev->ring_order); i++ ) + { + addr = dev->data.in + i * PAGE_SIZE; + dev->intf->ref[i] = gnttab_grant_access(dev->dom, virt_to_mfn(addr), 0); + } + + while ( retry ) + { + msg = xenbus_transaction_start(&xbt); + if ( msg ) + { + free(msg); + msg = NULL; + reason = "starting transaction"; + goto err; + } + + msg = xenbus_printf(xbt, dev->nodename, "version", "%u", 1); + if ( msg ) + goto err_tr; + msg = xenbus_printf(xbt, dev->nodename, "num-rings", "%u", 1); + if ( msg ) + goto err_tr; + msg = xenbus_printf(xbt, dev->nodename, "ring-ref0", "%u", + dev->ring_ref); + if ( msg ) + goto err_tr; + msg = xenbus_printf(xbt, dev->nodename, "event-channel-0", "%u", + dev->evtchn); + if ( msg ) + goto err_tr; + msg = xenbus_printf(xbt, dev->nodename, "state", "%u", + XenbusStateInitialised); + if ( msg ) + goto err_tr; + + free(xenbus_transaction_end(xbt, 0, &retry)); + } + + state = xenbus_read_integer(bepath); + while ( msg == NULL && state < XenbusStateConnected ) + msg = xenbus_wait_for_state_change(bepath, &state, &dev->events); + if ( msg || state != XenbusStateConnected ) + { + reason = "illegal backend state"; + goto err; + } + + msg = xenbus_printf(XBT_NIL, dev->nodename, "state", "%u", + XenbusStateConnected); + if ( msg ) + goto err; + + unmask_evtchn(dev->evtchn); + + dev->mnt = mnt; + if ( mount(dev->mnt, dev, open_9pfs) ) + { + reason = "mount failed"; + goto err; + } + + return dev; + + err_tr: + free(xenbus_transaction_end(xbt, 1, &retry)); + + err: + if ( bepath[0] ) + free(xenbus_unwatch_path_token(XBT_NIL, bepath, bepath)); + if ( msg ) + printk("9pfsfront add %u failed, error %s accessing Xenstore\n", + id, msg); + else + printk("9pfsfront add %u failed, %s\n", id, reason); + free_9pfront(dev); + free(msg); + return NULL; +} + +void shutdown_9pfront(void *dev) +{ + struct dev_9pfs *dev9p = dev; + char bepath[64]; + XenbusState state; + char *msg; + char *reason = ""; + + umount(dev9p->mnt); + snprintf(bepath, sizeof(bepath), "%s/state", dev9p->backend); + + msg = xenbus_printf(XBT_NIL, dev9p->nodename, "state", "%u", + XenbusStateClosing); + if ( msg ) + goto err; + + state = xenbus_read_integer(bepath); + while ( msg == NULL && state < XenbusStateClosing) + msg = xenbus_wait_for_state_change(bepath, &state, &dev9p->events); + if ( msg || state != XenbusStateClosing ) + { + reason = "illegal backend state"; + goto err; + } + + msg = xenbus_printf(XBT_NIL, dev9p->nodename, "state", "%u", + XenbusStateClosed); + if ( msg ) + goto err; + + free_9pfront(dev9p); + + return; + + err: + if ( msg ) + printk("9pfsfront shutdown %u failed, error %s accessing Xenstore\n", + dev9p->id, msg); + else + printk("9pfsfront shutdown %u failed, %s\n", dev9p->id, reason); + free(msg); +} + +static const struct file_ops ops_9pfs = { + .name = "9pfs", +}; + +__attribute__((constructor)) +static void initialize_9pfs(void) +{ + ftype_9pfs = alloc_file_type(&ops_9pfs); +} + +#endif /* HAVE_LIBC */ diff --git a/Config.mk b/Config.mk index 1a24b30e..677e93df 100644 --- a/Config.mk +++ b/Config.mk @@ -187,6 +187,7 @@ CONFIG-n += CONFIG_QEMU_XS_ARGS CONFIG-n += CONFIG_TEST CONFIG-n += CONFIG_PCIFRONT CONFIG-n += CONFIG_TPMFRONT +CONFIG-n += CONFIG_9PFRONT CONFIG-n += CONFIG_TPM_TIS CONFIG-n += CONFIG_TPMBACK CONFIG-n += CONFIG_BALLOON diff --git a/Makefile b/Makefile index 747c7c01..7ee181a2 100644 --- a/Makefile +++ b/Makefile @@ -39,6 +39,7 @@ SUBDIRS := lib src-$(CONFIG_BLKFRONT) += blkfront.c src-$(CONFIG_CONSFRONT) += consfront.c src-$(CONFIG_TPMFRONT) += tpmfront.c +src-$(CONFIG_9PFRONT) += 9pfront.c src-$(CONFIG_TPM_TIS) += tpm_tis.c src-$(CONFIG_TPMBACK) += tpmback.c src-y += console.c diff --git a/arch/x86/testbuild/all-no b/arch/x86/testbuild/all-no index f79a1012..5b3e99ed 100644 --- a/arch/x86/testbuild/all-no +++ b/arch/x86/testbuild/all-no @@ -12,6 +12,7 @@ CONFIG_NETFRONT = n CONFIG_FBFRONT = n CONFIG_KBDFRONT = n CONFIG_CONSFRONT = n +CONFIG_9PFRONT = n CONFIG_XENBUS = n CONFIG_LIBXS = n CONFIG_LWIP = n diff --git a/arch/x86/testbuild/all-yes b/arch/x86/testbuild/all-yes index faa3af32..8ae489a4 100644 --- a/arch/x86/testbuild/all-yes +++ b/arch/x86/testbuild/all-yes @@ -12,6 +12,7 @@ CONFIG_NETFRONT = y CONFIG_FBFRONT = y CONFIG_KBDFRONT = y CONFIG_CONSFRONT = y +CONFIG_9PFRONT = y CONFIG_XENBUS = y CONFIG_LIBXS = y CONFIG_BALLOON = y diff --git a/arch/x86/testbuild/newxen-yes b/arch/x86/testbuild/newxen-yes index dc83e670..ee27a328 100644 --- a/arch/x86/testbuild/newxen-yes +++ b/arch/x86/testbuild/newxen-yes @@ -12,6 +12,7 @@ CONFIG_NETFRONT = y CONFIG_FBFRONT = y CONFIG_KBDFRONT = y CONFIG_CONSFRONT = y +CONFIG_9PFRONT = y CONFIG_XENBUS = y CONFIG_LIBXS = y CONFIG_BALLOON = y diff --git a/include/9pfront.h b/include/9pfront.h new file mode 100644 index 00000000..722ec564 --- /dev/null +++ b/include/9pfront.h @@ -0,0 +1,7 @@ +#ifndef __9PFRONT_H__ +#define __9PFRONT_H__ + +void *init_9pfront(unsigned int id, const char *mnt); +void shutdown_9pfront(void *dev); + +#endif /* __9PFRONT_H__ */ -- 2.35.3 From minios-devel-bounces@lists.xenproject.org Fri Feb 03 09:18:42 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 03 Feb 2023 09:18:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489071.757426 (Exim 4.92) (envelope-from ) id 1pNsDS-0000Wp-KP; Fri, 03 Feb 2023 09:18:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489071.757426; Fri, 03 Feb 2023 09:18:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsDS-0000Wf-Gh; Fri, 03 Feb 2023 09:18:42 +0000 Received: by outflank-mailman (input) for mailman id 489071; Fri, 03 Feb 2023 09:18:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsDR-0006sG-Dv for minios-devel@lists.xenproject.org; Fri, 03 Feb 2023 09:18:41 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bf4baddc-a3a3-11ed-933c-83870f6b2ba8; Fri, 03 Feb 2023 10:18:40 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3189320FB2; Fri, 3 Feb 2023 09:18:40 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 03E6F1346D; Fri, 3 Feb 2023 09:18:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id FRRGO2/R3GNDEwAAMHmgww (envelope-from ); Fri, 03 Feb 2023 09:18:39 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: bf4baddc-a3a3-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675415920; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YKIS+Tj09UAtPDRHqh2MXWRos25VF1afTytdwvl7/5k=; b=KUuyPjwItpYs63kRYfGt/5oRDVOKuvoVf8vbVqFDCIx95OBQl8iVgUgkJHS5CRDVv/m8g7 EaGuJFoNQ313RSHZpRbvLvAPkx39b+PQFviBZwgjoZZp2JJa8EOTpZATR0RFk5XJ/LDiSF iAuxKUZNA28rNLGDbAMyUv39EQdaw00= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH 5/7] Mini-OS: add 9pfs transport layer Date: Fri, 3 Feb 2023 10:18:07 +0100 Message-Id: <20230203091809.14478-6-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230203091809.14478-1-jgross@suse.com> References: <20230203091809.14478-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the transport layer of 9pfs. This is basically the infrastructure to send requests to the backend and to receive the related answers via the rings. As a first example add the version and attach requests of the 9pfs protocol when mounting a new 9pfs device. For the version use the "9P2000.u" variant, as it is the smallest subset supported by the qemu based backend. Signed-off-by: Juergen Gross --- 9pfront.c | 451 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 451 insertions(+) diff --git a/9pfront.c b/9pfront.c index cf4b5cb3..f6fac50a 100644 --- a/9pfront.c +++ b/9pfront.c @@ -7,6 +7,8 @@ #include #include #include +#include +#include #include #include #include @@ -14,6 +16,9 @@ #include #ifdef HAVE_LIBC + +#define N_REQS 64 + struct dev_9pfs { int id; char nodename[20]; @@ -22,6 +27,7 @@ struct dev_9pfs { char *tag; const char *mnt; + unsigned int msize_max; struct xen_9pfs_data_intf *intf; struct xen_9pfs_data data; @@ -32,14 +38,443 @@ struct dev_9pfs { evtchn_port_t evtchn; unsigned int ring_order; xenbus_event_queue events; + + unsigned int free_reqs; + struct req { + unsigned int id; + unsigned int next_free; /* N_REQS == end of list. */ + unsigned int cmd; + int result; + bool inflight; + unsigned char *data; /* Returned data. */ + } req[N_REQS]; + + struct wait_queue_head waitq; + struct semaphore ring_out_sem; + struct semaphore ring_in_sem; }; #define DEFAULT_9PFS_RING_ORDER 4 +#define P9_CMD_VERSION 100 +#define P9_CMD_ATTACH 104 +#define P9_CMD_ERROR 107 + +struct p9_header { + uint32_t size; + uint8_t cmd; + uint16_t tag; +} __attribute__((packed)); + +#define P9_VERSION "9P2000.u" +#define P9_ROOT_FID ~0 + static unsigned int ftype_9pfs; +static struct req *get_free_req(struct dev_9pfs *dev) +{ + struct req *req; + + if ( dev->free_reqs == N_REQS ) + return NULL; + + req = dev->req + dev->free_reqs; + dev->free_reqs = req->next_free; + + return req; +} + +static void put_free_req(struct dev_9pfs *dev, struct req *req) +{ + req->next_free = dev->free_reqs; + req->inflight = false; + req->data = NULL; + dev->free_reqs = req->id; +} + +static unsigned int ring_out_free(struct dev_9pfs *dev) +{ + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); + unsigned int queued; + + queued = xen_9pfs_queued(dev->prod_pvt_out, dev->intf->out_cons, ring_size); + rmb(); + + return ring_size - queued; +} + +static unsigned int ring_in_data(struct dev_9pfs *dev) +{ + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); + unsigned int queued; + + queued = xen_9pfs_queued(dev->intf->in_prod, dev->cons_pvt_in, ring_size); + rmb(); + + return queued; +} + +static void copy_to_ring(struct dev_9pfs *dev, void *data, unsigned int len) +{ + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); + RING_IDX prod = xen_9pfs_mask(dev->prod_pvt_out, ring_size); + RING_IDX cons = xen_9pfs_mask(dev->intf->out_cons, ring_size); + + xen_9pfs_write_packet(dev->data.out, data, len, &prod, cons, ring_size); + dev->prod_pvt_out += len; +} + +static void copy_from_ring(struct dev_9pfs *dev, void *data, unsigned int len) +{ + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); + RING_IDX prod = xen_9pfs_mask(dev->intf->in_prod, ring_size); + RING_IDX cons = xen_9pfs_mask(dev->cons_pvt_in, ring_size); + + xen_9pfs_read_packet(data, dev->data.in, len, prod, &cons, ring_size); + dev->cons_pvt_in += len; +} + +/* + * send_9p() and rcv_9p() are using a special format string for specifying + * the kind of data sent/expected. Each data item is represented by a single + * character: + * U: 4 byte unsigned integer (uint32_t) + * S: String (2 byte length + characters) + * in the rcv_9p() case the data for string is allocated (length omitted, + * string terminated by a NUL character) + * Q: A 13 byte "qid", consisting of 1 byte file type, 4 byte file version + * and 8 bytes unique file id. Only valid for receiving. + */ +static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) +{ + struct p9_header hdr; + va_list ap, aq; + const char *f; + uint32_t intval; + uint16_t len; + char *strval; + + hdr.size = sizeof(hdr); + hdr.cmd = req->cmd; + hdr.tag = req->id; + + va_start(ap, fmt); + + va_copy(aq, ap); + for ( f = fmt; *f; f++ ) + { + switch ( *f ) + { + case 'U': + hdr.size += 4; + intval = va_arg(aq, unsigned int); + break; + case 'S': + hdr.size += 2; + strval = va_arg(aq, char *); + hdr.size += strlen(strval); + break; + default: + printk("send_9p: unknown format character %c\n", *f); + break; + } + } + va_end(aq); + + /* + * Waiting for free space must be done in the critical section! + * Otherwise we might get overtaken by other short requests. + */ + down(&dev->ring_out_sem); + + wait_event(dev->waitq, ring_out_free(dev) >= hdr.size); + + copy_to_ring(dev, &hdr, sizeof(hdr)); + for ( f = fmt; *f; f++ ) + { + switch ( *f ) + { + case 'U': + intval = va_arg(ap, unsigned int); + copy_to_ring(dev, &intval, sizeof(intval)); + break; + case 'S': + strval = va_arg(ap, char *); + len = strlen(strval); + copy_to_ring(dev, &len, sizeof(len)); + copy_to_ring(dev, strval, len); + break; + } + } + + wmb(); /* Data on ring must be seen before updating index. */ + dev->intf->out_prod = dev->prod_pvt_out; + req->inflight = true; + + up(&dev->ring_out_sem); + + va_end(ap); + + notify_remote_via_evtchn(dev->evtchn); +} + +/* + * Using an opportunistic approach for receiving data: in case multiple + * requests are outstanding (which is very unlikely), we nevertheless need + * to consume all data available until we reach the desired request. + * For requests other than the one we are waiting for, we link the complete + * data to the request via an intermediate buffer. For our own request we can + * omit that buffer and directly fill the caller provided variables. + */ +static void copy_bufs(unsigned char **buf1, unsigned char **buf2, + unsigned int *len1, unsigned int *len2, + void *target, unsigned int len) +{ + if ( len <= *len1 ) + { + memcpy(target, *buf1, len); + *buf1 += len; + *len1 -= len; + } + else + { + memcpy(target, *buf1, *len1); + target = (char *)target + *len1; + len -= *len1; + *buf1 = *buf2; + *len1 = *len2; + *buf2 = NULL; + *len2 = 0; + if ( len > *len1 ) + len = *len1; + memcpy(target, *buf1, *len1); + } +} + +static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, + struct p9_header *hdr, const char *fmt, va_list ap) +{ + struct p9_header *h = hdr ? hdr : (void *)req->data; + RING_IDX cons = dev->cons_pvt_in + h->size - sizeof(*h); + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); + unsigned char *buf1, *buf2; + unsigned int len1, len2; + const char *f; + char *str; + uint16_t len; + uint32_t err; + uint32_t *val; + char **strval; + uint8_t *qval; + + if ( hdr ) + { + buf1 = xen_9pfs_get_ring_ptr(dev->data.in, dev->cons_pvt_in, ring_size); + buf2 = xen_9pfs_get_ring_ptr(dev->data.in, 0, ring_size); + len1 = ring_size - xen_9pfs_mask(dev->cons_pvt_in, ring_size); + if ( len1 > h->size - sizeof(*h) ) + len1 = h->size - sizeof(*h); + len2 = h->size - sizeof(*h) - len1; + } + else + { + buf1 = req->data + sizeof(*h); + buf2 = NULL; + len1 = h->size - sizeof(*h); + len2 = 0; + } + + if ( h->cmd == P9_CMD_ERROR ) + { + copy_bufs(&buf1, &buf2, &len1, &len2, &len, sizeof(len)); + str = malloc(len + 1); + copy_bufs(&buf1, &buf2, &len1, &len2, str, len); + str[len] = 0; + printk("9pfs: request %u resulted in \"%s\"\n", req->cmd, str); + free(str); + err = EIO; + copy_bufs(&buf1, &buf2, &len1, &len2, &err, sizeof(err)); + req->result = err; + + if ( hdr ) + dev->cons_pvt_in = cons; + + return; + } + + if ( h->cmd != req->cmd + 1 ) + { + req->result = EDOM; + printk("9pfs: illegal response: wrong return type (%u instead of %u)\n", + h->cmd, req->cmd + 1); + + if ( hdr ) + dev->cons_pvt_in = cons; + + return; + } + + req->result = 0; + + for ( f = fmt; *f; f++ ) + { + switch ( *f ) + { + case 'U': + val = va_arg(ap, uint32_t *); + copy_bufs(&buf1, &buf2, &len1, &len2, val, sizeof(*val)); + break; + case 'S': + strval = va_arg(ap, char **); + copy_bufs(&buf1, &buf2, &len1, &len2, &len, sizeof(len)); + *strval = malloc(len + 1); + copy_bufs(&buf1, &buf2, &len1, &len2, *strval, len); + (*strval)[len] = 0; + break; + case 'Q': + qval = va_arg(ap, uint8_t *); + copy_bufs(&buf1, &buf2, &len1, &len2, qval, 13); + break; + default: + printk("rcv_9p: unknown format character %c\n", *f); + break; + } + } + + if ( hdr ) + dev->cons_pvt_in = cons; +} + +static bool rcv_9p_one(struct dev_9pfs *dev, struct req *req, const char *fmt, + va_list ap) +{ + struct p9_header hdr; + struct req *tmp; + + if ( req->data ) + { + rcv_9p_copy(dev, req, NULL, fmt, ap); + free(req->data); + req->data = NULL; + + return true; + } + + wait_event(dev->waitq, ring_in_data(dev) >= sizeof(hdr)); + + copy_from_ring(dev, &hdr, sizeof(hdr)); + + wait_event(dev->waitq, ring_in_data(dev) >= hdr.size - sizeof(hdr)); + + tmp = dev->req + hdr.tag; + if ( hdr.tag >= N_REQS || !tmp->inflight ) + { + printk("9pfs: illegal response: %s\n", + hdr.tag >= N_REQS ? "tag out of bounds" : "request not pending"); + dev->cons_pvt_in += hdr.size - sizeof(hdr); + + return false; + } + + tmp->inflight = false; + + if ( tmp != req ) + { + tmp->data = malloc(hdr.size); + memcpy(tmp->data, &hdr, sizeof(hdr)); + copy_from_ring(dev, tmp->data + sizeof(hdr), hdr.size - sizeof(hdr)); + + return false; + } + + rcv_9p_copy(dev, req, &hdr, fmt, ap); + + return true; +} + +static void rcv_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) +{ + va_list ap; + + va_start(ap, fmt); + + down(&dev->ring_in_sem); + + while ( !rcv_9p_one(dev, req, fmt, ap) ); + + rmb(); /* Read all data before updating ring index. */ + dev->intf->in_cons = dev->cons_pvt_in; + + up(&dev->ring_in_sem); + + va_end(ap); +} + +static int p9_version(struct dev_9pfs *dev) +{ + unsigned int msize = XEN_FLEX_RING_SIZE(dev->ring_order) / 2; + struct req *req = get_free_req(dev); + char *verret; + int ret; + + if ( !req ) + return ENOENT; + + req->cmd = P9_CMD_VERSION; + send_9p(dev, req, "US", msize, P9_VERSION); + rcv_9p(dev, req, "US", &dev->msize_max, &verret); + ret = req->result; + + put_free_req(dev, req); + + if ( ret ) + return ret; + + if ( strcmp(verret, P9_VERSION) ) + ret = ENOMSG; + free(verret); + + return ret; +} + +static int p9_attach(struct dev_9pfs *dev) +{ + uint32_t fid = P9_ROOT_FID; + uint32_t afid = 0; + uint32_t uid = 0; + uint8_t qid[13]; + struct req *req = get_free_req(dev); + int ret; + + if ( !req ) + return ENOENT; + + req->cmd = P9_CMD_ATTACH; + send_9p(dev, req, "UUSSU", fid, afid, "root", "root", uid); + rcv_9p(dev, req, "Q", qid); + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +static int connect_9pfs(struct dev_9pfs *dev) +{ + int ret; + + ret = p9_version(dev); + if ( ret ) + return ret; + + return p9_attach(dev); +} + static void intr_9pfs(evtchn_port_t port, struct pt_regs *regs, void *data) { + struct dev_9pfs *dev = data; + + wake_up(&dev->waitq); } static int open_9pfs(struct mount_point *mnt, const char *pathname, int flags, @@ -87,6 +522,16 @@ void *init_9pfront(unsigned int id, const char *mnt) memset(dev, 0, sizeof(*dev)); snprintf(dev->nodename, sizeof(dev->nodename), "device/9pfs/%u", id); dev->id = id; + init_waitqueue_head(&dev->waitq); + init_SEMAPHORE(&dev->ring_out_sem, 1); + init_SEMAPHORE(&dev->ring_in_sem, 1); + + for ( i = 0; i < N_REQS; i++ ) + { + dev->req[i].id = i; + dev->req[i].next_free = i + 1; + } + dev->free_reqs = 0; msg = xenbus_read_unsigned(XBT_NIL, dev->nodename, "backend-id", &dev->dom); if ( msg ) @@ -199,6 +644,12 @@ void *init_9pfront(unsigned int id, const char *mnt) unmask_evtchn(dev->evtchn); + if ( connect_9pfs(dev) ) + { + reason = "9pfs connect failed"; + goto err; + } + dev->mnt = mnt; if ( mount(dev->mnt, dev, open_9pfs) ) { -- 2.35.3 From minios-devel-bounces@lists.xenproject.org Fri Feb 03 09:18:49 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 03 Feb 2023 09:18:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489078.757445 (Exim 4.92) (envelope-from ) id 1pNsDZ-0001Eo-FG; Fri, 03 Feb 2023 09:18:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489078.757445; Fri, 03 Feb 2023 09:18:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsDZ-0001EI-BX; Fri, 03 Feb 2023 09:18:49 +0000 Received: by outflank-mailman (input) for mailman id 489078; Fri, 03 Feb 2023 09:18:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsDX-0006sG-Qw for minios-devel@lists.xenproject.org; Fri, 03 Feb 2023 09:18:48 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c2af7a08-a3a3-11ed-933c-83870f6b2ba8; Fri, 03 Feb 2023 10:18:46 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DCDDF20FB3; Fri, 3 Feb 2023 09:18:45 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B12891346D; Fri, 3 Feb 2023 09:18:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qiq+KXXR3GNOEwAAMHmgww (envelope-from ); Fri, 03 Feb 2023 09:18:45 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: c2af7a08-a3a3-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675415925; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DTiD9k1sCY7qPC5hUeI+17ax3Vq23ag+y7zk3UOd7aM=; b=SLfU45Jhn6S379Qf7olIldMyNbApKjP//8ON7kw9NH2TA2HhAExqlDviup7UwFR8krpqGm cl7Yqor4zT6gA1x/RrG419ScopckPtWmEuzvQGnGzygUL25bfNvZUaou/IWHJzZpn2HhB+ 6DWrguxS5RC/61hvj9l6XxIBLOk/3ws= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH 6/7] Mini-OS: add open and close handling to the 9pfs frontend Date: Fri, 3 Feb 2023 10:18:08 +0100 Message-Id: <20230203091809.14478-7-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230203091809.14478-1-jgross@suse.com> References: <20230203091809.14478-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the open() and close() support to the 9pfs frontend. This requires to split the path name and to walk to the desired directory level. The opened file needs to be queried via stat in order to obtain the data needed for proper access (access rights, size, type of file). Signed-off-by: Juergen Gross --- 9pfront.c | 285 +++++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 283 insertions(+), 2 deletions(-) diff --git a/9pfront.c b/9pfront.c index f6fac50a..ebe48601 100644 --- a/9pfront.c +++ b/9pfront.c @@ -6,6 +6,7 @@ #include #include #include +#include #include #include #include @@ -52,13 +53,32 @@ struct dev_9pfs { struct wait_queue_head waitq; struct semaphore ring_out_sem; struct semaphore ring_in_sem; + + unsigned long long fid_mask; /* Bit mask for free fids. */ +}; + +struct file_9pfs { + uint32_t fid; + struct dev_9pfs *dev; + bool append; }; #define DEFAULT_9PFS_RING_ORDER 4 +/* P9 protocol commands (response is either cmd+1 or P9_CMD_ERROR). */ #define P9_CMD_VERSION 100 #define P9_CMD_ATTACH 104 #define P9_CMD_ERROR 107 +#define P9_CMD_WALK 110 +#define P9_CMD_OPEN 112 +#define P9_CMD_CREATE 114 +#define P9_CMD_CLUNK 120 + +/* P9 protocol open flags. */ +#define P9_OREAD 0 /* read */ +#define P9_OWRITE 1 /* write */ +#define P9_ORDWR 2 /* read and write */ +#define P9_OTRUNC 16 /* or'ed in, truncate file first */ struct p9_header { uint32_t size; @@ -67,10 +87,27 @@ struct p9_header { } __attribute__((packed)); #define P9_VERSION "9P2000.u" -#define P9_ROOT_FID ~0 +#define P9_ROOT_FID 0 static unsigned int ftype_9pfs; +static unsigned int get_fid(struct dev_9pfs *dev) +{ + unsigned int fid; + + fid = ffs(dev->fid_mask); + if ( fid ) + dev->fid_mask &= 1ULL << (fid - 1); + + return fid; +} + +static void put_fid(struct dev_9pfs *dev, unsigned int fid) +{ + if ( fid ) + dev->fid_mask |= 1ULL << (fid - 1); +} + static struct req *get_free_req(struct dev_9pfs *dev) { struct req *req; @@ -138,6 +175,9 @@ static void copy_from_ring(struct dev_9pfs *dev, void *data, unsigned int len) * send_9p() and rcv_9p() are using a special format string for specifying * the kind of data sent/expected. Each data item is represented by a single * character: + * b: 1 byte unsigned integer (uint8_t) + * Only valid for sending. + * u: 2 byte unsigned integer (uint16_t) * U: 4 byte unsigned integer (uint32_t) * S: String (2 byte length + characters) * in the rcv_9p() case the data for string is allocated (length omitted, @@ -151,7 +191,9 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) va_list ap, aq; const char *f; uint32_t intval; + uint16_t shortval; uint16_t len; + uint8_t byte; char *strval; hdr.size = sizeof(hdr); @@ -165,6 +207,14 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) { switch ( *f ) { + case 'b': + hdr.size += 1; + byte = va_arg(aq, unsigned int); + break; + case 'u': + hdr.size += 2; + shortval = va_arg(aq, unsigned int); + break; case 'U': hdr.size += 4; intval = va_arg(aq, unsigned int); @@ -194,6 +244,14 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) { switch ( *f ) { + case 'b': + byte = va_arg(ap, unsigned int); + copy_to_ring(dev, &byte, sizeof(byte)); + break; + case 'u': + shortval = va_arg(ap, unsigned int); + copy_to_ring(dev, &shortval, sizeof(shortval)); + break; case 'U': intval = va_arg(ap, unsigned int); copy_to_ring(dev, &intval, sizeof(intval)); @@ -263,6 +321,7 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, char *str; uint16_t len; uint32_t err; + uint16_t *shortval; uint32_t *val; char **strval; uint8_t *qval; @@ -320,6 +379,10 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, { switch ( *f ) { + case 'u': + shortval = va_arg(ap, uint16_t *); + copy_bufs(&buf1, &buf2, &len1, &len2, shortval, sizeof(*shortval)); + break; case 'U': val = va_arg(ap, uint32_t *); copy_bufs(&buf1, &buf2, &len1, &len2, val, sizeof(*val)); @@ -459,6 +522,134 @@ static int p9_attach(struct dev_9pfs *dev) return ret; } +static int p9_clunk(struct dev_9pfs *dev, uint32_t fid) +{ + struct req *req = get_free_req(dev); + int ret; + + if ( !req ) + return ENOENT; + + req->cmd = P9_CMD_CLUNK; + send_9p(dev, req, "U", fid); + rcv_9p(dev, req, ""); + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +static int p9_walk(struct dev_9pfs *dev, uint32_t fid, uint32_t newfid, + char *name) +{ + struct req *req = get_free_req(dev); + int ret; + uint16_t nqid; + uint8_t qid[13]; + + if ( !req ) + return ENOENT; + + req->cmd = P9_CMD_WALK; + if ( name[0] ) + send_9p(dev, req, "UUuS", fid, newfid, 1, name); + else + send_9p(dev, req, "UUu", fid, newfid, 0); + rcv_9p(dev, req, "uQ", &nqid, qid); + + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +static int p9_open(struct dev_9pfs *dev, uint32_t fid, uint8_t omode) +{ + struct req *req = get_free_req(dev); + int ret; + uint8_t qid[13]; + uint32_t iounit; + + if ( !req ) + return ENOENT; + + req->cmd = P9_CMD_OPEN; + send_9p(dev, req, "Ub", fid, omode); + rcv_9p(dev, req, "QU", qid, &iounit); + + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +static int p9_create(struct dev_9pfs *dev, uint32_t fid, char *path, + uint32_t mode, uint8_t omode) +{ + struct req *req = get_free_req(dev); + int ret; + uint8_t qid[13]; + uint32_t iounit; + + if ( !req ) + return ENOENT; + + req->cmd = P9_CMD_CREATE; + send_9p(dev, req, "USUbS", fid, path, mode, omode, ""); + rcv_9p(dev, req, "QU", qid, &iounit); + + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +/* + * Walk from root levels with the levels listed in <*paths> as a + * sequence of names. Returns the number of steps not having been able to + * walk, with <*paths> pointing at the name of the failing walk step. + * will be associated with the last successful walk step. Note that + * the first step should always succeed, as it is an empty walk in order + * to start at the root (needed for creating new files in root). + */ +static unsigned int walk_9pfs(struct dev_9pfs *dev, uint32_t fid, + unsigned int steps, char **paths) +{ + uint32_t curr_fid = P9_ROOT_FID; + int ret; + + while ( steps-- ) + { + ret = p9_walk(dev, curr_fid, fid, *paths); + if ( ret ) + return steps + 1; + curr_fid = fid; + *paths += strlen(*paths) + 1; + } + + return 0; +} + +static unsigned int split_path(const char *pathname, char **split_ptr) +{ + unsigned int parts = 1; + char *p; + + *split_ptr = strdup(pathname); + + for ( p = strchr(*split_ptr, '/'); p; p = strchr(p + 1, '/') ) + { + *p = 0; + parts++; + } + + return parts; +} + static int connect_9pfs(struct dev_9pfs *dev) { int ret; @@ -477,10 +668,98 @@ static void intr_9pfs(evtchn_port_t port, struct pt_regs *regs, void *data) wake_up(&dev->waitq); } +static int close_9pfs(struct file *file) +{ + struct file_9pfs *f9pfs = file->filedata; + + if ( f9pfs->fid != P9_ROOT_FID ) + { + p9_clunk(f9pfs->dev, f9pfs->fid); + put_fid(f9pfs->dev, f9pfs->fid); + } + + free(f9pfs); + + return 0; +} + static int open_9pfs(struct mount_point *mnt, const char *pathname, int flags, mode_t mode) { - errno = ENOSYS; + int fd; + char *path = NULL; + char *p; + struct file *file; + struct file_9pfs *f9pfs; + uint16_t nwalk; + uint8_t omode; + int ret; + + f9pfs = calloc(1, sizeof(*f9pfs)); + f9pfs->dev = mnt->dev; + f9pfs->fid = P9_ROOT_FID; + + fd = alloc_fd(ftype_9pfs); + file = get_file_from_fd(fd); + file->filedata = f9pfs; + + switch ( flags & O_ACCMODE ) + { + case O_RDONLY: + omode = P9_OREAD; + break; + case O_WRONLY: + omode = P9_OWRITE; + break; + case O_RDWR: + omode = P9_ORDWR; + break; + default: + ret = EINVAL; + goto err; + } + + if ( flags & O_TRUNC ) + omode |= P9_OTRUNC; + f9pfs->append = flags & O_APPEND; + + nwalk = split_path(pathname + strlen(mnt->path), &path); + + f9pfs->fid = get_fid(mnt->dev); + if ( !f9pfs->fid ) + { + ret = ENFILE; + goto err; + } + p = path; + nwalk = walk_9pfs(mnt->dev, f9pfs->fid, nwalk, &p); + if ( nwalk ) + { + if ( nwalk > 1 || !(flags & O_CREAT) ) + { + ret = ENOENT; + goto err; + } + + ret = p9_create(mnt->dev, f9pfs->fid, p, mode, omode); + if ( ret ) + goto err; + goto out; + } + + ret = p9_open(mnt->dev, f9pfs->fid, omode); + if ( ret ) + goto err; + + out: + free(path); + + return fd; + + err: + free(path); + close(fd); + errno = ret; return -1; } @@ -525,6 +804,7 @@ void *init_9pfront(unsigned int id, const char *mnt) init_waitqueue_head(&dev->waitq); init_SEMAPHORE(&dev->ring_out_sem, 1); init_SEMAPHORE(&dev->ring_in_sem, 1); + dev->fid_mask = ~0ULL; for ( i = 0; i < N_REQS; i++ ) { @@ -720,6 +1000,7 @@ void shutdown_9pfront(void *dev) static const struct file_ops ops_9pfs = { .name = "9pfs", + .close = close_9pfs, }; __attribute__((constructor)) -- 2.35.3 From minios-devel-bounces@lists.xenproject.org Fri Feb 03 09:25:46 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 03 Feb 2023 09:25:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489117.757467 (Exim 4.92) (envelope-from ) id 1pNsKH-0004He-C7; Fri, 03 Feb 2023 09:25:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489117.757467; Fri, 03 Feb 2023 09:25:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsKH-0004HS-8v; Fri, 03 Feb 2023 09:25:45 +0000 Received: by outflank-mailman (input) for mailman id 489117; Fri, 03 Feb 2023 09:25:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsDe-0006pI-Qw for minios-devel@lists.xenproject.org; Fri, 03 Feb 2023 09:18:54 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c5face31-a3a3-11ed-9254-a70e01b1f5fa; Fri, 03 Feb 2023 10:18:51 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7053320FB3; Fri, 3 Feb 2023 09:18:51 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4555A1346D; Fri, 3 Feb 2023 09:18:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9tKnD3vR3GNUEwAAMHmgww (envelope-from ); Fri, 03 Feb 2023 09:18:51 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: c5face31-a3a3-11ed-9254-a70e01b1f5fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675415931; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Idrvyq/CByJ2DQQaGlOqPT2h9f5xudP46VSUBxT02f4=; b=WCQLk/QNq/M3jtl676+Yekybd2+OHWkHTOJVlXFQBkfIH5X6FBwVSiLfrd0f7L5TsqsUT8 mKYp2zgWqZzwgyCUmMlt+tCS08ZXNNHI9ikDDCfpqNTYAy0mtI3yBzClQ6AnoFCa2p266N HOMi8OXMPyPbsE38ZSWpET58cGWFibY= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH 7/7] Mini-OS: add read and write support to 9pfsfront Date: Fri, 3 Feb 2023 10:18:09 +0100 Message-Id: <20230203091809.14478-8-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230203091809.14478-1-jgross@suse.com> References: <20230203091809.14478-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add support to read from and write to a file handled by 9pfsfront. Signed-off-by: Juergen Gross --- 9pfront.c | 189 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 189 insertions(+) diff --git a/9pfront.c b/9pfront.c index ebe48601..45f2f9a9 100644 --- a/9pfront.c +++ b/9pfront.c @@ -72,7 +72,10 @@ struct file_9pfs { #define P9_CMD_WALK 110 #define P9_CMD_OPEN 112 #define P9_CMD_CREATE 114 +#define P9_CMD_READ 116 +#define P9_CMD_WRITE 118 #define P9_CMD_CLUNK 120 +#define P9_CMD_STAT 124 /* P9 protocol open flags. */ #define P9_OREAD 0 /* read */ @@ -86,11 +89,39 @@ struct p9_header { uint16_t tag; } __attribute__((packed)); +struct p9_stat { + uint16_t size; + uint16_t type; + uint32_t dev; + uint8_t qid[13]; + uint32_t mode; + uint32_t atime; + uint32_t mtime; + uint64_t length; + char *name; + char *uid; + char *gid; + char *muid; + char *extension; + uint32_t n_uid; + uint32_t n_gid; + uint32_t n_muid; +}; + #define P9_VERSION "9P2000.u" #define P9_ROOT_FID 0 static unsigned int ftype_9pfs; +static void free_stat(struct p9_stat *stat) +{ + free(stat->name); + free(stat->uid); + free(stat->gid); + free(stat->muid); + free(stat->extension); +} + static unsigned int get_fid(struct dev_9pfs *dev) { unsigned int fid; @@ -179,9 +210,12 @@ static void copy_from_ring(struct dev_9pfs *dev, void *data, unsigned int len) * Only valid for sending. * u: 2 byte unsigned integer (uint16_t) * U: 4 byte unsigned integer (uint32_t) + * L: 8 byte unsigned integer (uint64_t) * S: String (2 byte length + characters) * in the rcv_9p() case the data for string is allocated (length omitted, * string terminated by a NUL character) + * D: Binary data (4 byte length + bytes of data), requires a length + * and a buffer pointer parameter. * Q: A 13 byte "qid", consisting of 1 byte file type, 4 byte file version * and 8 bytes unique file id. Only valid for receiving. */ @@ -190,10 +224,12 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) struct p9_header hdr; va_list ap, aq; const char *f; + uint64_t longval; uint32_t intval; uint16_t shortval; uint16_t len; uint8_t byte; + uint8_t *data; char *strval; hdr.size = sizeof(hdr); @@ -219,11 +255,21 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) hdr.size += 4; intval = va_arg(aq, unsigned int); break; + case 'L': + hdr.size += 8; + longval = va_arg(aq, uint64_t); + break; case 'S': hdr.size += 2; strval = va_arg(aq, char *); hdr.size += strlen(strval); break; + case 'D': + hdr.size += 4; + intval = va_arg(aq, unsigned int); + hdr.size += intval; + data = va_arg(aq, uint8_t *); + break; default: printk("send_9p: unknown format character %c\n", *f); break; @@ -256,12 +302,22 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) intval = va_arg(ap, unsigned int); copy_to_ring(dev, &intval, sizeof(intval)); break; + case 'L': + longval = va_arg(ap, uint64_t); + copy_to_ring(dev, &longval, sizeof(longval)); + break; case 'S': strval = va_arg(ap, char *); len = strlen(strval); copy_to_ring(dev, &len, sizeof(len)); copy_to_ring(dev, strval, len); break; + case 'D': + intval = va_arg(ap, unsigned int); + copy_to_ring(dev, &intval, sizeof(intval)); + data = va_arg(ap, uint8_t *); + copy_to_ring(dev, data, intval); + break; } } @@ -323,6 +379,8 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, uint32_t err; uint16_t *shortval; uint32_t *val; + uint64_t *longval; + uint8_t *data; char **strval; uint8_t *qval; @@ -387,6 +445,10 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, val = va_arg(ap, uint32_t *); copy_bufs(&buf1, &buf2, &len1, &len2, val, sizeof(*val)); break; + case 'L': + longval = va_arg(ap, uint64_t *); + copy_bufs(&buf1, &buf2, &len1, &len2, longval, sizeof(*longval)); + break; case 'S': strval = va_arg(ap, char **); copy_bufs(&buf1, &buf2, &len1, &len2, &len, sizeof(len)); @@ -394,6 +456,12 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, copy_bufs(&buf1, &buf2, &len1, &len2, *strval, len); (*strval)[len] = 0; break; + case 'D': + val = va_arg(ap, uint32_t *); + data = va_arg(ap, uint8_t *); + copy_bufs(&buf1, &buf2, &len1, &len2, val, sizeof(*val)); + copy_bufs(&buf1, &buf2, &len1, &len2, data, *val); + break; case 'Q': qval = va_arg(ap, uint8_t *); copy_bufs(&buf1, &buf2, &len1, &len2, qval, 13); @@ -608,6 +676,88 @@ static int p9_create(struct dev_9pfs *dev, uint32_t fid, char *path, return ret; } +static int p9_stat(struct dev_9pfs *dev, uint32_t fid, struct p9_stat *stat) +{ + struct req *req = get_free_req(dev); + int ret; + + if ( !req ) + return ENOENT; + + memset(stat, 0, sizeof(*stat)); + req->cmd = P9_CMD_STAT; + send_9p(dev, req, "U", fid); + rcv_9p(dev, req, "uuUQUUULSSSSSUUU", &stat->size, &stat->type, &stat->dev, + stat->qid, &stat->mode, &stat->atime, &stat->mtime, &stat->length, + &stat->name, &stat->uid, &stat->gid, &stat->muid, &stat->extension, + &stat->n_uid, &stat->n_gid, &stat->n_muid); + + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +static int p9_read(struct dev_9pfs *dev, uint32_t fid, uint64_t offset, + uint8_t *data, uint32_t len) +{ + struct req *req = get_free_req(dev); + int ret; + uint32_t count; + + if ( !req ) + { + errno = EIO; + return -1; + } + + req->cmd = P9_CMD_READ; + send_9p(dev, req, "ULU", fid, offset, len); + rcv_9p(dev, req, "D", &count, data); + + if ( req->result ) + { + ret = -1; + errno = EIO; + } + else + ret = count; + + put_free_req(dev, req); + + return ret; +} + +static int p9_write(struct dev_9pfs *dev, uint32_t fid, uint64_t offset, + const uint8_t *data, uint32_t len) +{ + struct req *req = get_free_req(dev); + int ret; + uint32_t count; + + if ( !req ) + { + errno = EIO; + return -1; + } + + req->cmd = P9_CMD_WRITE; + send_9p(dev, req, "ULD", fid, offset, len, data); + rcv_9p(dev, req, "U", &count); + if ( req->result ) + { + ret = -1; + errno = EIO; + } + else + ret = count; + + put_free_req(dev, req); + + return ret; +} + /* * Walk from root levels with the levels listed in <*paths> as a * sequence of names. Returns the number of steps not having been able to @@ -668,6 +818,43 @@ static void intr_9pfs(evtchn_port_t port, struct pt_regs *regs, void *data) wake_up(&dev->waitq); } +static int read_9pfs(struct file *file, void *buf, size_t nbytes) +{ + struct file_9pfs *f9pfs = file->filedata; + int ret; + + ret = p9_read(f9pfs->dev, f9pfs->fid, file->offset, buf, nbytes); + if ( ret >= 0 ) + file->offset += ret; + + return ret; +} + +static int write_9pfs(struct file *file, const void *buf, size_t nbytes) +{ + struct file_9pfs *f9pfs = file->filedata; + struct p9_stat stat; + int ret; + + if ( f9pfs->append ) + { + ret = p9_stat(f9pfs->dev, f9pfs->fid, &stat); + free_stat(&stat); + if ( ret ) + { + errno = EIO; + return -1; + } + file->offset = stat.length; + } + + ret = p9_write(f9pfs->dev, f9pfs->fid, file->offset, buf, nbytes); + if ( ret >= 0 ) + file->offset += ret; + + return ret; +} + static int close_9pfs(struct file *file) { struct file_9pfs *f9pfs = file->filedata; @@ -1000,6 +1187,8 @@ void shutdown_9pfront(void *dev) static const struct file_ops ops_9pfs = { .name = "9pfs", + .read = read_9pfs, + .write = write_9pfs, .close = close_9pfs, }; -- 2.35.3 From minios-devel-bounces@lists.xenproject.org Fri Feb 03 12:50:58 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 03 Feb 2023 12:50:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489167.757493 (Exim 4.92) (envelope-from ) id 1pNvWn-0002t9-3e; Fri, 03 Feb 2023 12:50:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489167.757493; Fri, 03 Feb 2023 12:50:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNvWn-0002t2-0f; Fri, 03 Feb 2023 12:50:53 +0000 Received: by outflank-mailman (input) for mailman id 489167; Fri, 03 Feb 2023 12:50:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNvWl-0002dv-T4 for minios-devel@lists.xenproject.org; Fri, 03 Feb 2023 12:50:52 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 61ca4dbc-a3c1-11ed-933c-83870f6b2ba8; Fri, 03 Feb 2023 13:50:49 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 85686346CF; Fri, 3 Feb 2023 12:50:48 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 645991358A; Fri, 3 Feb 2023 12:50:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id tUvmFigD3WPAcQAAMHmgww (envelope-from ); Fri, 03 Feb 2023 12:50:48 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 61ca4dbc-a3c1-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675428648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aQz6KReeIBnxU3F9c9Bu3VhouAL47OPI7ut9qgu2Ddo=; b=DBFd9FzepLsReMCht9jqEuhhcnjKAzKnOKIbrGxXeHiSr0sfF7ofQTwocGsoYSvABo5JHk 2eL0tVgGVT2cPTx0AmIUTy/uVx+y2t+L++216P+Sf518+kjN7Yo5X2Ic4ovTHZNCZFoao9 shFLf5AXklQN65zdkDYZzP4pcNUvoJY= Message-ID: Date: Fri, 3 Feb 2023 13:50:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 6/7] Mini-OS: add open and close handling to the 9pfs frontend Content-Language: en-US To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-7-jgross@suse.com> From: Juergen Gross In-Reply-To: <20230203091809.14478-7-jgross@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------kCVE4JPEmlHYhI2VUIUK1icS" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------kCVE4JPEmlHYhI2VUIUK1icS Content-Type: multipart/mixed; boundary="------------a8J3SxOE2EmF53jgtBnHlxHu"; protected-headers="v1" From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org Message-ID: Subject: Re: [PATCH 6/7] Mini-OS: add open and close handling to the 9pfs frontend References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-7-jgross@suse.com> In-Reply-To: <20230203091809.14478-7-jgross@suse.com> --------------a8J3SxOE2EmF53jgtBnHlxHu Content-Type: multipart/mixed; boundary="------------ReT8a7108Yc03RHhExnd7ha3" --------------ReT8a7108Yc03RHhExnd7ha3 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMDIuMjMgMTA6MTgsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IEFkZCB0aGUgb3Bl bigpIGFuZCBjbG9zZSgpIHN1cHBvcnQgdG8gdGhlIDlwZnMgZnJvbnRlbmQuIFRoaXMgcmVx dWlyZXMNCj4gdG8gc3BsaXQgdGhlIHBhdGggbmFtZSBhbmQgdG8gd2FsayB0byB0aGUgZGVz aXJlZCBkaXJlY3RvcnkgbGV2ZWwuDQo+IA0KPiBUaGUgb3BlbmVkIGZpbGUgbmVlZHMgdG8g YmUgcXVlcmllZCB2aWEgc3RhdCBpbiBvcmRlciB0byBvYnRhaW4gdGhlDQo+IGRhdGEgbmVl ZGVkIGZvciBwcm9wZXIgYWNjZXNzIChhY2Nlc3MgcmlnaHRzLCBzaXplLCB0eXBlIG9mIGZp bGUpLg0KDQpPaCwgc29ycnksIHRoaXMgcGFyYWdyYXBoIHNob3VsZCBiZSBkcm9wcGVkLg0K DQoNCkp1ZXJnZW4NCg== --------------ReT8a7108Yc03RHhExnd7ha3 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------ReT8a7108Yc03RHhExnd7ha3-- --------------a8J3SxOE2EmF53jgtBnHlxHu-- --------------kCVE4JPEmlHYhI2VUIUK1icS Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPdAycFAwAAAAAACgkQsN6d1ii/Ey+P bwf+LfAWnaVYLyqy6zLJKxcMUi3OMdtmgoToAi00iP7ynTAn1uqwjweI+ySzfYtB32eMLZwffUTk QvPy4rGHg/mj7tSdYz+ksqFNo4WrM4JWZjYz0Me40zoj1tk+GjpYY+YYWdKS9jEKKrxeLOVGvv7d L1XGcgnDA8c3ZzDPPHixTAPSgKmhyR8NPM1J0jGN6TrclXLwMwXi1ayCcBP4yWanQJCF0GT3HulB V3TeYV1g1bMEHhtg3Ha4crGq2cheShocveGaaPBBvDhvgp7QmR6zqtfTe7/2TlKvlZu35mNq3g5x GiLW+zGg9er1WpMYo147OrRs6FwlRiFBWUiLQA1/Kw== =8gRQ -----END PGP SIGNATURE----- --------------kCVE4JPEmlHYhI2VUIUK1icS-- From minios-devel-bounces@lists.xenproject.org Fri Feb 03 12:52:25 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 03 Feb 2023 12:52:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489175.757507 (Exim 4.92) (envelope-from ) id 1pNvYH-0003Th-FE; Fri, 03 Feb 2023 12:52:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489175.757507; Fri, 03 Feb 2023 12:52:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNvYH-0003Ta-CR; Fri, 03 Feb 2023 12:52:25 +0000 Received: by outflank-mailman (input) for mailman id 489175; Fri, 03 Feb 2023 12:52:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNvYG-0003E4-7g for minios-devel@lists.xenproject.org; Fri, 03 Feb 2023 12:52:24 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9989a0b3-a3c1-11ed-933c-83870f6b2ba8; Fri, 03 Feb 2023 13:52:21 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5F3E6346D8; Fri, 3 Feb 2023 12:52:22 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 38D891358A; Fri, 3 Feb 2023 12:52:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id rONyDIYD3WOpcgAAMHmgww (envelope-from ); Fri, 03 Feb 2023 12:52:22 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 9989a0b3-a3c1-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675428742; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mvt2+Gv/dBnKSemdRNIgG5off+fk9kijKWONvjmudx8=; b=QNAvTrzeqiXR+KjOVuD4E6UQsDNupUCR9HsYLS8DKnAnnCdN6Z5MgGTfz5olpazSaPPZdG cYKtdm+dsT1dSGRf1bvPmipM3NvH1obcgxwtzeGhXnvd9vBe/AcO69t83b1bfmYAl3CuMv 7/HcOpqrfomuwp01zNztjvZgxdgBoMY= Message-ID: Date: Fri, 3 Feb 2023 13:52:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 7/7] Mini-OS: add read and write support to 9pfsfront Content-Language: en-US To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-8-jgross@suse.com> From: Juergen Gross In-Reply-To: <20230203091809.14478-8-jgross@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------YI0KurEEFOlVNx7w638kODkU" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------YI0KurEEFOlVNx7w638kODkU Content-Type: multipart/mixed; boundary="------------6e7YkB0oaWewm8HvMsuQzKDP"; protected-headers="v1" From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org Message-ID: Subject: Re: [PATCH 7/7] Mini-OS: add read and write support to 9pfsfront References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-8-jgross@suse.com> In-Reply-To: <20230203091809.14478-8-jgross@suse.com> --------------6e7YkB0oaWewm8HvMsuQzKDP Content-Type: multipart/mixed; boundary="------------t98G7AeIYauxvE7mHeLkHJv3" --------------t98G7AeIYauxvE7mHeLkHJv3 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMDIuMjMgMTA6MTgsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IEFkZCBzdXBwb3J0 IHRvIHJlYWQgZnJvbSBhbmQgd3JpdGUgdG8gYSBmaWxlIGhhbmRsZWQgYnkgOXBmc2Zyb250 Lg0KPiANCj4gU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29t Pg0KDQpUaGlzIHBhdGNoIGlzIG1pc3NpbmcgdGhlIGxpbWl0YXRpb24gb2YgcmVhZC93cml0 ZSBtZXNzYWdlcyB0byBzdGF5DQpiZWxvdyB0aGUgbWF4LiBzdXBwb3J0ZWQgbWVzc2FnZSBz aXplLg0KDQoNCkp1ZXJnZW4NCg0K --------------t98G7AeIYauxvE7mHeLkHJv3 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------t98G7AeIYauxvE7mHeLkHJv3-- --------------6e7YkB0oaWewm8HvMsuQzKDP-- --------------YI0KurEEFOlVNx7w638kODkU Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPdA4UFAwAAAAAACgkQsN6d1ii/Ey+3 Kwf/UvRzwAqEoNFMUpCXRjeXxJwiUBdKCMyXxZ17/p9ZkBotb1CTuegUauvU3j1QF84yS3J234Gv 1ufy25E38IV06eVrUDYGUlTeHNB5l2rpw1DkA2MkGasIVsoIHdkoMglur2bviFUmiJ7d6xzVkrb5 S8z/QjrBRpm65+NDtsFYm7k3x5n7eh1eTRsb+cfmL4Yw2IvHWKNsO1/jqlaKUwC4dA4j6UP9Vmd+ muwsPUyorgS3U0a4C+F0vwXyCCobvOrUg99Rcya9vJ9dpSnc/bjdQ/yO9LVkKlGQ5NQA8ZRrpLCL ngCwI4jbu5EHAScRYVqy/gSz4TBW6x8L1GpBekYIcA== =CEZL -----END PGP SIGNATURE----- --------------YI0KurEEFOlVNx7w638kODkU-- From minios-devel-bounces@lists.xenproject.org Sat Feb 04 14:02:02 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Sat, 04 Feb 2023 14:02:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489530.757856 (Exim 4.92) (envelope-from ) id 1pOJ76-0007MC-F2; Sat, 04 Feb 2023 14:01:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489530.757856; Sat, 04 Feb 2023 14:01:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOJ76-0007M5-CO; Sat, 04 Feb 2023 14:01:56 +0000 Received: by outflank-mailman (input) for mailman id 489530; Sat, 04 Feb 2023 14:01:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOJ75-0007Lb-4S for minios-devel@lists.xenproject.org; Sat, 04 Feb 2023 14:01:55 +0000 Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 78c5f178-a494-11ed-93b5-47a8fe42b414; Sat, 04 Feb 2023 15:01:52 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 7875120150; Sat, 4 Feb 2023 15:01:50 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qxk5DFMxO5AT; Sat, 4 Feb 2023 15:01:49 +0100 (CET) Received: from begin (unknown [164.15.244.46]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 2BB2620135; Sat, 4 Feb 2023 15:01:49 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pOJ6y-0003Pd-2J; Sat, 04 Feb 2023 15:01:48 +0100 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 78c5f178-a494-11ed-93b5-47a8fe42b414 Date: Sat, 4 Feb 2023 15:01:48 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH 1/7] Mini-OS: xenbus: add support for reading node from directory Message-ID: <20230204140148.pmhv2vnsb7ejobji@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-2-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230203091809.14478-2-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Hello, Juergen Gross, le ven. 03 févr. 2023 10:18:03 +0100, a ecrit: > +char *xenbus_read_unsigned(xenbus_transaction_t xbt, const char *dir, > + const char *node, unsigned int *value) > +{ > + char path[BUFFER_SIZE]; > + char *msg; > + char *str; > + > + xenbus_build_path(dir, node, path); > + msg = xenbus_read(xbt, path, &str); > + if ( msg ) > + return msg; > + > + sscanf(str, "%u", value); I'd say better check that sscanf returned 1 and otherwise return an error. Otherwise *value may end up uninitialized. > + free(str); > + > + return NULL; > +} From minios-devel-bounces@lists.xenproject.org Sun Feb 05 12:41:07 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Sun, 05 Feb 2023 12:41:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489807.758329 (Exim 4.92) (envelope-from ) id 1pOeKM-0006SF-1P; Sun, 05 Feb 2023 12:41:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489807.758329; Sun, 05 Feb 2023 12:41:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOeKL-0006Rf-Tf; Sun, 05 Feb 2023 12:41:01 +0000 Received: by outflank-mailman (input) for mailman id 489807; Sun, 05 Feb 2023 12:41:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOeKK-0006PP-KU for minios-devel@lists.xenproject.org; Sun, 05 Feb 2023 12:41:00 +0000 Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 551358c5-a552-11ed-933c-83870f6b2ba8; Sun, 05 Feb 2023 13:40:58 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id C683120100; Sun, 5 Feb 2023 13:40:54 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cnv66YH8ewre; Sun, 5 Feb 2023 13:40:54 +0100 (CET) Received: from begin (unknown [164.15.244.46]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 7956E200F9; Sun, 5 Feb 2023 13:40:54 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pOeKE-002nEy-0M; Sun, 05 Feb 2023 13:40:54 +0100 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 551358c5-a552-11ed-933c-83870f6b2ba8 Date: Sun, 5 Feb 2023 13:40:54 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH 2/7] Mini-OS: add concept of mount points Message-ID: <20230205124054.dwxobowog2aayi5r@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-3-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230203091809.14478-3-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le ven. 03 févr. 2023 10:18:04 +0100, a ecrit: > Add the concept of mount points to Mini-OS. A mount point is a path > associated with a device pointer and an open() callback. A mount point > can be either a file (e.g. "/dev/mem") or a directory ("/var/log"). > > This allows to replace the special casing in the generic open() > handling with a generic mount point handling. > > Prepare the open() callbacks to support creating new files by adding a > mode parameter. > > Additionally add a close() prototype to include/lib.h, as it is missing > today. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault Thanks! > --- > include/lib.h | 9 ++++++ > lib/sys.c | 80 +++++++++++++++++++++++++++++++++++++++------------ > 2 files changed, 70 insertions(+), 19 deletions(-) > > diff --git a/include/lib.h b/include/lib.h > index bec99646..36d94ec4 100644 > --- a/include/lib.h > +++ b/include/lib.h > @@ -187,6 +187,13 @@ struct file_ops { > bool (*select_wr)(struct file *file); > }; > > +struct mount_point { > + const char *path; > + int (*open)(struct mount_point *mnt, const char *pathname, int flags, > + mode_t mode); > + void *dev; > +}; > + > unsigned int alloc_file_type(const struct file_ops *ops); > > off_t lseek_default(struct file *file, off_t offset, int whence); > @@ -198,6 +205,8 @@ int alloc_fd(unsigned int type); > void close_all_files(void); > extern struct thread *main_thread; > void sparse(unsigned long data, size_t size); > + > +int close(int fd); > #endif > > #endif /* _LIB_H_ */ > diff --git a/lib/sys.c b/lib/sys.c > index 8f8a3de2..1475c621 100644 > --- a/lib/sys.c > +++ b/lib/sys.c > @@ -263,11 +263,6 @@ char *getcwd(char *buf, size_t size) > return buf; > } > > -#define LOG_PATH "/var/log/" > -#define SAVE_PATH "/var/lib/xen" > -#define SAVE_CONSOLE 1 > -#define RESTORE_CONSOLE 2 > - > int mkdir(const char *pathname, mode_t mode) > { > errno = EIO; > @@ -286,18 +281,30 @@ int posix_openpt(int flags) > return fd; > } > > +static int open_pt(struct mount_point *mnt, const char *pathname, int flags, > + mode_t mode) > +{ > + return posix_openpt(flags); > +} > + > int open_savefile(const char *path, int save) > { > int fd; > char nodename[64]; > > - snprintf(nodename, sizeof(nodename), "device/console/%d", save ? SAVE_CONSOLE : RESTORE_CONSOLE); > + snprintf(nodename, sizeof(nodename), "device/console/%d", save ? 1 : 2); > > fd = open_consfront(nodename); > printk("fd(%d) = open_savefile\n", fd); > > return fd; > } > + > +static int open_save(struct mount_point *mnt, const char *pathname, int flags, > + mode_t mode) > +{ > + return open_savefile(pathname, flags & O_WRONLY); > +} > #else > int posix_openpt(int flags) > { > @@ -311,24 +318,59 @@ int open_savefile(const char *path, int save) > } > #endif > > -int open(const char *pathname, int flags, ...) > +static int open_log(struct mount_point *mnt, const char *pathname, int flags, > + mode_t mode) > { > int fd; > + > /* Ugly, but fine. */ > - if (!strncmp(pathname,LOG_PATH,strlen(LOG_PATH))) { > - fd = alloc_fd(FTYPE_CONSOLE); > - printk("open(%s) -> %d\n", pathname, fd); > - return fd; > + fd = alloc_fd(FTYPE_CONSOLE); > + printk("open(%s) -> %d\n", pathname, fd); > + return fd; > +} > + > +static int open_mem(struct mount_point *mnt, const char *pathname, int flags, > + mode_t mode) > +{ > + int fd; > + > + fd = alloc_fd(FTYPE_MEM); > + printk("open(%s) -> %d\n", pathname, fd); > + return fd; > +} > + > +static struct mount_point mount_points[] = { > + { .path = "/var/log", .open = open_log, .dev = NULL }, > + { .path = "/dev/mem", .open = open_mem, .dev = NULL }, > +#ifdef CONFIG_CONSFRONT > + { .path = "/dev/ptmx", .open = open_pt, .dev = NULL }, > + { .path = "/var/lib/xen", .open = open_save, .dev = NULL }, > +#endif > +}; > + > +int open(const char *pathname, int flags, ...) > +{ > + unsigned int m, mlen; > + struct mount_point *mnt; > + mode_t mode = 0; > + va_list ap; > + > + if ( flags & O_CREAT ) > + { > + va_start(ap, flags); > + mode = va_arg(ap, mode_t); > + va_end(ap); > } > - if (!strncmp(pathname, "/dev/mem", strlen("/dev/mem"))) { > - fd = alloc_fd(FTYPE_MEM); > - printk("open(/dev/mem) -> %d\n", fd); > - return fd; > + > + for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) > + { > + mnt = mount_points + m; > + mlen = strlen(mnt->path); > + if ( !strncmp(pathname, mnt->path, mlen) && > + (pathname[mlen] == '/' || pathname[mlen] == 0) ) > + return mnt->open(mnt, pathname, flags, mode); > } > - if (!strncmp(pathname, "/dev/ptmx", strlen("/dev/ptmx"))) > - return posix_openpt(flags); > - if (!strncmp(pathname,SAVE_PATH,strlen(SAVE_PATH))) > - return open_savefile(pathname, flags & O_WRONLY); > + > errno = EIO; > return -1; > } > -- > 2.35.3 > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria. From minios-devel-bounces@lists.xenproject.org Sun Feb 05 12:42:24 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Sun, 05 Feb 2023 12:42:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489818.758350 (Exim 4.92) (envelope-from ) id 1pOeLf-0007GX-Dc; Sun, 05 Feb 2023 12:42:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489818.758350; Sun, 05 Feb 2023 12:42:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOeLf-0007GQ-A3; Sun, 05 Feb 2023 12:42:23 +0000 Received: by outflank-mailman (input) for mailman id 489818; Sun, 05 Feb 2023 12:42:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOeLd-0006l7-BK for minios-devel@lists.xenproject.org; Sun, 05 Feb 2023 12:42:21 +0000 Received: from sonata.ens-lyon.org (sonata.ens-lyon.org [140.77.166.138]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8567f3ca-a552-11ed-93b5-47a8fe42b414; Sun, 05 Feb 2023 13:42:16 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id A94D72013E; Sun, 5 Feb 2023 13:42:16 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6j9RGqsjjpM4; Sun, 5 Feb 2023 13:42:16 +0100 (CET) Received: from begin (unknown [164.15.244.46]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 84AE520134; Sun, 5 Feb 2023 13:42:16 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pOeLY-002nFE-0U; Sun, 05 Feb 2023 13:42:16 +0100 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 8567f3ca-a552-11ed-93b5-47a8fe42b414 Date: Sun, 5 Feb 2023 13:42:16 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH 3/7] Mini-OS: add support for runtime mounts Message-ID: <20230205124216.psjld3kc4qtijtrw@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-4-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230203091809.14478-4-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le ven. 03 févr. 2023 10:18:05 +0100, a ecrit: > Add the support to mount a device at runtime. The number of dynamic > mounts is limited by a #define. > > For devices supporting multiple files struct file is modified to hold > a pointer to file specific data in contrast to device specific data. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > include/lib.h | 5 +++++ > lib/sys.c | 50 +++++++++++++++++++++++++++++++++++++++++++++++++- > 2 files changed, 54 insertions(+), 1 deletion(-) > > diff --git a/include/lib.h b/include/lib.h > index 36d94ec4..fd8c36de 100644 > --- a/include/lib.h > +++ b/include/lib.h > @@ -172,6 +172,7 @@ struct file { > union { > int fd; /* Any fd from an upper layer. */ > void *dev; > + void *filedata; > }; > }; > > @@ -194,6 +195,10 @@ struct mount_point { > void *dev; > }; > > +int mount(const char *path, void *dev, > + int (*open)(struct mount_point *, const char *, int, mode_t)); > +void umount(const char *path); > + > unsigned int alloc_file_type(const struct file_ops *ops); > > off_t lseek_default(struct file *file, off_t offset, int whence); > diff --git a/lib/sys.c b/lib/sys.c > index 1475c621..4171bfd6 100644 > --- a/lib/sys.c > +++ b/lib/sys.c > @@ -339,7 +339,14 @@ static int open_mem(struct mount_point *mnt, const char *pathname, int flags, > return fd; > } > > -static struct mount_point mount_points[] = { > +#ifdef CONFIG_CONSFRONT > +#define STATIC_MNTS 4 > +#else > +#define STATIC_MNTS 2 > +#endif > +#define DYNAMIC_MNTS 8 > + > +static struct mount_point mount_points[STATIC_MNTS + DYNAMIC_MNTS] = { > { .path = "/var/log", .open = open_log, .dev = NULL }, > { .path = "/dev/mem", .open = open_mem, .dev = NULL }, > #ifdef CONFIG_CONSFRONT > @@ -365,6 +372,8 @@ int open(const char *pathname, int flags, ...) > for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) > { > mnt = mount_points + m; > + if ( !mnt->path ) > + continue; > mlen = strlen(mnt->path); > if ( !strncmp(pathname, mnt->path, mlen) && > (pathname[mlen] == '/' || pathname[mlen] == 0) ) > @@ -375,6 +384,45 @@ int open(const char *pathname, int flags, ...) > return -1; > } > > +int mount(const char *path, void *dev, > + int (*open)(struct mount_point *, const char *, int, mode_t)) > +{ > + unsigned int m; > + struct mount_point *mnt; > + > + for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) > + { > + mnt = mount_points + m; > + if ( !mnt->path ) > + { > + mnt->path = strdup(path); > + mnt->open = open; > + mnt->dev = dev; > + return 0; > + } > + } > + > + errno = ENOSPC; > + return -1; > +} > + > +void umount(const char *path) > +{ > + unsigned int m; > + struct mount_point *mnt; > + > + for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) > + { > + mnt = mount_points + m; > + if ( mnt->path && !strcmp(mnt->path, path) ) > + { > + free((char *)mnt->path); > + mnt->path = NULL; > + return; > + } > + } > +} > + > int isatty(int fd) > { > return files[fd].type == FTYPE_CONSOLE; > -- > 2.35.3 > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria. From minios-devel-bounces@lists.xenproject.org Sun Feb 05 12:45:14 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Sun, 05 Feb 2023 12:45:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489827.758357 (Exim 4.92) (envelope-from ) id 1pOeOP-0007kJ-LW; Sun, 05 Feb 2023 12:45:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489827.758357; Sun, 05 Feb 2023 12:45:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOeOP-0007kC-Id; Sun, 05 Feb 2023 12:45:13 +0000 Received: by outflank-mailman (input) for mailman id 489827; Sun, 05 Feb 2023 12:45:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOeOO-0007hb-9O for minios-devel@lists.xenproject.org; Sun, 05 Feb 2023 12:45:12 +0000 Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ed53ab4a-a552-11ed-933c-83870f6b2ba8; Sun, 05 Feb 2023 13:45:10 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 678422013E; Sun, 5 Feb 2023 13:45:10 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OpK39USoWs7c; Sun, 5 Feb 2023 13:45:10 +0100 (CET) Received: from begin (unknown [164.15.244.46]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 376BE20134; Sun, 5 Feb 2023 13:45:10 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pOeOL-002nFx-2b; Sun, 05 Feb 2023 13:45:09 +0100 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: ed53ab4a-a552-11ed-933c-83870f6b2ba8 Date: Sun, 5 Feb 2023 13:45:09 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH 2/7] Mini-OS: add concept of mount points Message-ID: <20230205124509.pr5xswn4ygqsqoba@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-3-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230203091809.14478-3-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le ven. 03 févr. 2023 10:18:04 +0100, a ecrit: > +int open(const char *pathname, int flags, ...) > +{ > + unsigned int m, mlen; > + struct mount_point *mnt; > + mode_t mode = 0; > + va_list ap; > + > + if ( flags & O_CREAT ) > + { > + va_start(ap, flags); > + mode = va_arg(ap, mode_t); > + va_end(ap); > } > - if (!strncmp(pathname, "/dev/mem", strlen("/dev/mem"))) { > - fd = alloc_fd(FTYPE_MEM); > - printk("open(/dev/mem) -> %d\n", fd); > - return fd; > + > + for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) > + { > + mnt = mount_points + m; > + mlen = strlen(mnt->path); > + if ( !strncmp(pathname, mnt->path, mlen) && > + (pathname[mlen] == '/' || pathname[mlen] == 0) ) > + return mnt->open(mnt, pathname, flags, mode); Thinking about it more: don't we want to pass pathname+mlen? So that the open function doesn't have to care where it's mounted. Samuel From minios-devel-bounces@lists.xenproject.org Mon Feb 06 09:01:54 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 06 Feb 2023 09:01:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490087.758663 (Exim 4.92) (envelope-from ) id 1pOxNm-0001AX-KC; Mon, 06 Feb 2023 09:01:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490087.758663; Mon, 06 Feb 2023 09:01:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOxNm-0001AQ-HJ; Mon, 06 Feb 2023 09:01:50 +0000 Received: by outflank-mailman (input) for mailman id 490087; Mon, 06 Feb 2023 09:01:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOxNk-0001AF-P8 for minios-devel@lists.xenproject.org; Mon, 06 Feb 2023 09:01:48 +0000 Received: from sonata.ens-lyon.org (sonata.ens-lyon.org [140.77.166.138]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e0d5c33d-a5fc-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 10:01:45 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id E85752011C; Mon, 6 Feb 2023 10:01:43 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HoOi5yXqfWlB; Mon, 6 Feb 2023 10:01:43 +0100 (CET) Received: from begin (unknown [89.207.171.57]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id EA0862010B; Mon, 6 Feb 2023 10:01:42 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pOxNb-008wtA-0r; Mon, 06 Feb 2023 10:01:39 +0100 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: e0d5c33d-a5fc-11ed-93b5-47a8fe42b414 Date: Mon, 6 Feb 2023 10:01:39 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH 4/7] Mini-OS: add 9pfs frontend Message-ID: <20230206090139.ehvf2czoocn6j7nc@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-5-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230203091809.14478-5-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le ven. 03 févr. 2023 10:18:06 +0100, a ecrit: > +void *init_9pfront(unsigned int id, const char *mnt) > +{ [...] > + free(xenbus_watch_path_token(XBT_NIL, bepath, bepath, &dev->events)); Better check for errors, otherwise the rest will hang without useful feedback. > + for ( v = version; *v; v++ ) > + { > + if ( strtoul(v, &v, 10) == 1 ) > + { > + v = NULL; > + break; This looks fragile? if version is "2.1" it will accept it apparently? I guess better check whether strtoul did read a number, and in that case break the loop anyway, successfully if the number is 1 and with failure otherwise. > + } > + } > + free(version); > + if ( v ) > + { > + reason = "version 1 not supported"; > + goto err; > + } This looks odd: when number 1 is detected this breaks out successfully, while the error message otherwise says that it's version 1 which is not supported? Is the message supposed to be "version greater than 1 not supported"? > + err: > + if ( bepath[0] ) > + free(xenbus_unwatch_path_token(XBT_NIL, bepath, bepath)); > + if ( msg ) > + printk("9pfsfront add %u failed, error %s accessing Xenstore\n", > + id, msg); > + else > + printk("9pfsfront add %u failed, %s\n", id, reason); > + free_9pfront(dev); In case of early errors, this will try to free uninitialized evtchn, ring_ref, etc. > + free(msg); > + return NULL; > +} Samuel From minios-devel-bounces@lists.xenproject.org Mon Feb 06 09:22:19 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 06 Feb 2023 09:22:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490127.758695 (Exim 4.92) (envelope-from ) id 1pOxhY-0004qB-Nh; Mon, 06 Feb 2023 09:22:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490127.758695; Mon, 06 Feb 2023 09:22:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOxhY-0004q4-KG; Mon, 06 Feb 2023 09:22:16 +0000 Received: by outflank-mailman (input) for mailman id 490127; Mon, 06 Feb 2023 09:22:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOxhX-0004pu-PC for minios-devel@lists.xenproject.org; Mon, 06 Feb 2023 09:22:15 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bc1dfe44-a5ff-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 10:22:11 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7F4463F282; Mon, 6 Feb 2023 09:22:11 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5A22713677; Mon, 6 Feb 2023 09:22:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id dsioFMPG4GNcNgAAMHmgww (envelope-from ); Mon, 06 Feb 2023 09:22:11 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: bc1dfe44-a5ff-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675675331; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xq9DAQJA5bLa0f2FnBAlUYRsTbrf3r86W3+9Gv9KH+Y=; b=GcgRheuijXKt5LJvz9UKO3aK4JuaTMyMnOm+r95o1mJCBaBPDEojs3tEOBYDACu7S9zYIl ecWSc9KhF1fWCzncQPI5Zp4a0aw9kcTZ17tO+hMPprVa+a2TEDXJB59TjW06y9+Qp82FKD OLXD1a/jNlRbYOos8uzmT4dl4NvmpUs= Message-ID: <383cbd1b-6518-bc1d-a3ae-5562e3dec5c1@suse.com> Date: Mon, 6 Feb 2023 10:22:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-5-jgross@suse.com> <20230206090139.ehvf2czoocn6j7nc@begin> From: Juergen Gross Subject: Re: [PATCH 4/7] Mini-OS: add 9pfs frontend In-Reply-To: <20230206090139.ehvf2czoocn6j7nc@begin> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------vx4qmPovfF4xTZ3bqa6wrOE5" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------vx4qmPovfF4xTZ3bqa6wrOE5 Content-Type: multipart/mixed; boundary="------------ufXSVO0GXigeBQDpw4HOHnfQ"; protected-headers="v1" From: Juergen Gross To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Message-ID: <383cbd1b-6518-bc1d-a3ae-5562e3dec5c1@suse.com> Subject: Re: [PATCH 4/7] Mini-OS: add 9pfs frontend References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-5-jgross@suse.com> <20230206090139.ehvf2czoocn6j7nc@begin> In-Reply-To: <20230206090139.ehvf2czoocn6j7nc@begin> --------------ufXSVO0GXigeBQDpw4HOHnfQ Content-Type: multipart/mixed; boundary="------------mvNQMwStrrqXLQfuQ1suzeyP" --------------mvNQMwStrrqXLQfuQ1suzeyP Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDYuMDIuMjMgMTA6MDEsIFNhbXVlbCBUaGliYXVsdCB3cm90ZToNCj4gSnVlcmdlbiBH cm9zcywgbGUgdmVuLiAwMyBmw6l2ci4gMjAyMyAxMDoxODowNiArMDEwMCwgYSBlY3JpdDoN Cj4+ICt2b2lkICppbml0XzlwZnJvbnQodW5zaWduZWQgaW50IGlkLCBjb25zdCBjaGFyICpt bnQpDQo+PiArew0KPiBbLi4uXQ0KPj4gKyAgICBmcmVlKHhlbmJ1c193YXRjaF9wYXRoX3Rv a2VuKFhCVF9OSUwsIGJlcGF0aCwgYmVwYXRoLCAmZGV2LT5ldmVudHMpKTsNCj4gDQo+IEJl dHRlciBjaGVjayBmb3IgZXJyb3JzLCBvdGhlcndpc2UgdGhlIHJlc3Qgd2lsbCBoYW5nIHdp dGhvdXQgdXNlZnVsDQo+IGZlZWRiYWNrLg0KDQpUaGlzIGlzIGEgY29tbW9uIHBhdHRlcm4g aW4gTWluaS1PUyBmcm9udGVuZHMuDQoNCkkgY2FuIGFkZCBhbiBlcnJvciBjaGVjaywgb2Yg Y291cnNlLg0KDQo+IA0KPj4gKyAgICBmb3IgKCB2ID0gdmVyc2lvbjsgKnY7IHYrKyApDQo+ PiArICAgIHsNCj4+ICsgICAgICAgIGlmICggc3RydG91bCh2LCAmdiwgMTApID09IDEgKQ0K Pj4gKyAgICAgICAgew0KPj4gKyAgICAgICAgICAgIHYgPSBOVUxMOw0KPj4gKyAgICAgICAg ICAgIGJyZWFrOw0KPiANCj4gVGhpcyBsb29rcyBmcmFnaWxlPyBpZiB2ZXJzaW9uIGlzICIy LjEiIGl0IHdpbGwgYWNjZXB0IGl0IGFwcGFyZW50bHk/IEkNCj4gZ3Vlc3MgYmV0dGVyIGNo ZWNrIHdoZXRoZXIgc3RydG91bCBkaWQgcmVhZCBhIG51bWJlciwgYW5kIGluIHRoYXQgY2Fz ZQ0KPiBicmVhayB0aGUgbG9vcCBhbnl3YXksIHN1Y2Nlc3NmdWxseSBpZiB0aGUgbnVtYmVy IGlzIDEgYW5kIHdpdGggZmFpbHVyZQ0KPiBvdGhlcndpc2UuDQoNClZlcnNpb25zIGFyZSBk ZWZpbmVkIHRvIGJlIGludGVnZXJzLg0KDQpJIGNhbiBhZGQgY2hlY2tzIGZvciBzYW5pdGl6 aW5nIGJhY2tlbmQgd3JpdHRlbiBkYXRhLCBidXQgSSdtIG5vdCBzdXJlIHdlDQpuZWVkIHRo YXQuIEluIGNhc2UgdGhlIGJhY2tlbmQgd2FudHMgdG8gZm9vbCB1cywgaXQgY2FuIGVhc2ls eSB0ZWxsIHVzIHRvDQpzdXBwb3J0IHZlcnNpb24gMSBldmVuIGlmIGl0IGRvZXNuJ3QuDQoN Cj4gDQo+PiArICAgICAgICB9DQo+PiArICAgIH0NCj4+ICsgICAgZnJlZSh2ZXJzaW9uKTsN Cj4+ICsgICAgaWYgKCB2ICkNCj4+ICsgICAgew0KPj4gKyAgICAgICAgcmVhc29uID0gInZl cnNpb24gMSBub3Qgc3VwcG9ydGVkIjsNCj4+ICsgICAgICAgIGdvdG8gZXJyOw0KPj4gKyAg ICB9DQo+IA0KPiBUaGlzIGxvb2tzIG9kZDogd2hlbiBudW1iZXIgMSBpcyBkZXRlY3RlZCB0 aGlzIGJyZWFrcyBvdXQgc3VjY2Vzc2Z1bGx5LA0KPiB3aGlsZSB0aGUgZXJyb3IgbWVzc2Fn ZSBvdGhlcndpc2Ugc2F5cyB0aGF0IGl0J3MgdmVyc2lvbiAxIHdoaWNoIGlzIG5vdA0KPiBz dXBwb3J0ZWQ/IElzIHRoZSBtZXNzYWdlIHN1cHBvc2VkIHRvIGJlICJ2ZXJzaW9uIGdyZWF0 ZXIgdGhhbiAxIG5vdA0KPiBzdXBwb3J0ZWQiPw0KDQpJIGNhbiBjaGFuZ2UgdGhlIG1lc3Nh Z2UgdG8gIkJhY2tlbmQgZG9lc24ndCBzdXBwb3J0IHZlcnNpb24gMSIuDQoNCj4gDQo+PiAr IGVycjoNCj4+ICsgICAgaWYgKCBiZXBhdGhbMF0gKQ0KPj4gKyAgICAgICAgZnJlZSh4ZW5i dXNfdW53YXRjaF9wYXRoX3Rva2VuKFhCVF9OSUwsIGJlcGF0aCwgYmVwYXRoKSk7DQo+PiAr ICAgIGlmICggbXNnICkNCj4+ICsgICAgICAgIHByaW50aygiOXBmc2Zyb250IGFkZCAldSBm YWlsZWQsIGVycm9yICVzIGFjY2Vzc2luZyBYZW5zdG9yZVxuIiwNCj4+ICsgICAgICAgICAg ICAgICBpZCwgbXNnKTsNCj4+ICsgICAgZWxzZQ0KPj4gKyAgICAgICAgcHJpbnRrKCI5cGZz ZnJvbnQgYWRkICV1IGZhaWxlZCwgJXNcbiIsIGlkLCByZWFzb24pOw0KPj4gKyAgICBmcmVl XzlwZnJvbnQoZGV2KTsNCj4gDQo+IEluIGNhc2Ugb2YgZWFybHkgZXJyb3JzLCB0aGlzIHdp bGwgdHJ5IHRvIGZyZWUgdW5pbml0aWFsaXplZCBldnRjaG4sDQo+IHJpbmdfcmVmLCBldGMu DQoNCk9oIHJpZ2h0LCBJIG5lZWQgdG8gY2hlY2sgdGhvc2UgZm9yIGJlaW5nIG5vdCAwLg0K DQoNCkp1ZXJnZW4NCg== --------------mvNQMwStrrqXLQfuQ1suzeyP Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------mvNQMwStrrqXLQfuQ1suzeyP-- --------------ufXSVO0GXigeBQDpw4HOHnfQ-- --------------vx4qmPovfF4xTZ3bqa6wrOE5 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPgxsIFAwAAAAAACgkQsN6d1ii/Ey9o NggAnkHMVcRn8nmL2Sn6reRQ+Y/QBblOgM7AMasT+FM1uKkklT6aV4fr0MI1lqj4q4i0uERyhASW 0FZXJ2WLSy/Jg2kSO88Ofb3+NkL+oasI2PBVjwqZJfBgOP9yXu44IiVezCe9WsxGeRd4B6t/IL2W GH+De1P21wgaeUy33rwhHLr6nv0wbYBexn/7GviDly5wyFPvH9iPqKQ4GcrWMZGOHF5OL/jN2U8o C0xPyKa2lD07SiloC+ECo7HHdm5qE0xdAUBSmwQxIr2JAB7gXspGOejIZptlCAi5EnzIousZmZXt L3bWsCGq/Y116NBHCE+Kdhx3IPTPNQ9HY5f+PMYhow== =5Wcp -----END PGP SIGNATURE----- --------------vx4qmPovfF4xTZ3bqa6wrOE5-- From minios-devel-bounces@lists.xenproject.org Mon Feb 06 09:24:01 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 06 Feb 2023 09:24:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490136.758710 (Exim 4.92) (envelope-from ) id 1pOxjF-0005Ud-5x; Mon, 06 Feb 2023 09:24:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490136.758710; Mon, 06 Feb 2023 09:24:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOxjF-0005UW-2y; Mon, 06 Feb 2023 09:24:01 +0000 Received: by outflank-mailman (input) for mailman id 490136; Mon, 06 Feb 2023 09:23:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOxjD-0005UA-Fj for minios-devel@lists.xenproject.org; Mon, 06 Feb 2023 09:23:59 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fab14662-a5ff-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 10:23:56 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A4FDC3F290; Mon, 6 Feb 2023 09:23:56 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7D14713677; Mon, 6 Feb 2023 09:23:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id q9stHSzH4GNwOAAAMHmgww (envelope-from ); Mon, 06 Feb 2023 09:23:56 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: fab14662-a5ff-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675675436; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LQXVc2EqJoXYjYOUh6r9cWLuCgbAbKl+BcBrC9LF9hA=; b=Hrbvogd19KA3WLtkkVFmxCZ/W7OlssyvXrsEDIFUPoI/WSjjltK2jzbEuLmwlrmKxKDMO4 I6oyODWogV3r86p/6yP5RREanL57fMY/pdQZlrYhrt/5FbGT4OjBjv4pYdbIf71UZgoBBN DvscIA2peR7PSmnEi5WhDseEyz2Yjf4= Message-ID: <75603739-a013-1da8-a30a-e0e549c5fcd6@suse.com> Date: Mon, 6 Feb 2023 10:23:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 1/7] Mini-OS: xenbus: add support for reading node from directory Content-Language: en-US To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-2-jgross@suse.com> <20230204140148.pmhv2vnsb7ejobji@begin> From: Juergen Gross In-Reply-To: <20230204140148.pmhv2vnsb7ejobji@begin> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------WzMtLIAV9yaN7ruULp3feNIM" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------WzMtLIAV9yaN7ruULp3feNIM Content-Type: multipart/mixed; boundary="------------0y4kSmhFGC6gfg7MtiRe0Iwo"; protected-headers="v1" From: Juergen Gross To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Message-ID: <75603739-a013-1da8-a30a-e0e549c5fcd6@suse.com> Subject: Re: [PATCH 1/7] Mini-OS: xenbus: add support for reading node from directory References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-2-jgross@suse.com> <20230204140148.pmhv2vnsb7ejobji@begin> In-Reply-To: <20230204140148.pmhv2vnsb7ejobji@begin> --------------0y4kSmhFGC6gfg7MtiRe0Iwo Content-Type: multipart/mixed; boundary="------------GPQvSeXqb39WSySrtk6ebLJ7" --------------GPQvSeXqb39WSySrtk6ebLJ7 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDQuMDIuMjMgMTU6MDEsIFNhbXVlbCBUaGliYXVsdCB3cm90ZToNCj4gSGVsbG8sDQo+ IA0KPiBKdWVyZ2VuIEdyb3NzLCBsZSB2ZW4uIDAzIGbDqXZyLiAyMDIzIDEwOjE4OjAzICsw MTAwLCBhIGVjcml0Og0KPj4gK2NoYXIgKnhlbmJ1c19yZWFkX3Vuc2lnbmVkKHhlbmJ1c190 cmFuc2FjdGlvbl90IHhidCwgY29uc3QgY2hhciAqZGlyLA0KPj4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgIGNvbnN0IGNoYXIgKm5vZGUsIHVuc2lnbmVkIGludCAqdmFsdWUpDQo+ PiArew0KPj4gKyAgICBjaGFyIHBhdGhbQlVGRkVSX1NJWkVdOw0KPj4gKyAgICBjaGFyICpt c2c7DQo+PiArICAgIGNoYXIgKnN0cjsNCj4+ICsNCj4+ICsgICAgeGVuYnVzX2J1aWxkX3Bh dGgoZGlyLCBub2RlLCBwYXRoKTsNCj4+ICsgICAgbXNnID0geGVuYnVzX3JlYWQoeGJ0LCBw YXRoLCAmc3RyKTsNCj4+ICsgICAgaWYgKCBtc2cgKQ0KPj4gKyAgICAgICAgcmV0dXJuIG1z ZzsNCj4+ICsNCj4+ICsgICAgc3NjYW5mKHN0ciwgIiV1IiwgdmFsdWUpOw0KPiANCj4gSSdk IHNheSBiZXR0ZXIgY2hlY2sgdGhhdCBzc2NhbmYgcmV0dXJuZWQgMSBhbmQgb3RoZXJ3aXNl IHJldHVybiBhbg0KPiBlcnJvci4gT3RoZXJ3aXNlICp2YWx1ZSBtYXkgZW5kIHVwIHVuaW5p dGlhbGl6ZWQuDQoNCk9rYXkuDQoNCg0KSnVlcmdlbg0KDQo= --------------GPQvSeXqb39WSySrtk6ebLJ7 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------GPQvSeXqb39WSySrtk6ebLJ7-- --------------0y4kSmhFGC6gfg7MtiRe0Iwo-- --------------WzMtLIAV9yaN7ruULp3feNIM Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPgxywFAwAAAAAACgkQsN6d1ii/Ey+g Twf/dDI8C+ha68MR6vyp6KvSH1hUT6k8f7xCYZgxPnPO36WzD28rB0Aa/SWWZKLsqWrIUoWweiT8 PudisnbyALNuqhbMF7cY0Z1QIcjYvu40od6bk+AX/bHb+EU4KSmZfpYOxtjuKbUYU5GWQK4jCQEj GQ2dbcAf9RN9azYZuYwhxXALMj7+WMRTjRK5yjjFW26q3B9yXTGbKJuj0aTrXPp4ZzhyvtKh0mAh Xh6qx1IykBXugFVs6m2TCnB3P8Z/9LibNvn5NCM0GZv8BiajuGecY9NNpHKy0dYXM4CZXLpDWJX5 Cf9nP3kItzRtzxJ7DlhX3Dx6zEDTkM/bqLfbJ/ijCA== =yYpx -----END PGP SIGNATURE----- --------------WzMtLIAV9yaN7ruULp3feNIM-- From minios-devel-bounces@lists.xenproject.org Mon Feb 06 09:25:33 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 06 Feb 2023 09:25:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490144.758725 (Exim 4.92) (envelope-from ) id 1pOxkj-0006Bn-Hv; Mon, 06 Feb 2023 09:25:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490144.758725; Mon, 06 Feb 2023 09:25:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOxkj-0006Bg-F7; Mon, 06 Feb 2023 09:25:33 +0000 Received: by outflank-mailman (input) for mailman id 490144; Mon, 06 Feb 2023 09:25:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOxki-000682-T8 for minios-devel@lists.xenproject.org; Mon, 06 Feb 2023 09:25:33 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 32594bdd-a600-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 10:25:29 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0ECDD3F291; Mon, 6 Feb 2023 09:25:30 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DD83813677; Mon, 6 Feb 2023 09:25:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id /xLKNInH4GMROgAAMHmgww (envelope-from ); Mon, 06 Feb 2023 09:25:29 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 32594bdd-a600-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675675530; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xaUPPW+RojxjSgBFSPhxWmG2HPgYboyEyG3uqWZ5qVQ=; b=UBgZUsxfife+Rzq8PKoaFYN/gWWf1qh9/MYmEeEIQv0pXJm4UA1uEP+rYNbLFTZ6ymDWuV gG98p4a8tko5jOF6GwBwvFU+toboxBFeN1s/VKojBueZpuuISxWxZtFOHCSgV7k3dqLehb xSEGVMFJosYsDITFnCFrL81vB61ATAo= Message-ID: <16b989f6-333b-10a8-c985-bfc132342f49@suse.com> Date: Mon, 6 Feb 2023 10:25:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 2/7] Mini-OS: add concept of mount points Content-Language: en-US To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-3-jgross@suse.com> <20230205124509.pr5xswn4ygqsqoba@begin> From: Juergen Gross In-Reply-To: <20230205124509.pr5xswn4ygqsqoba@begin> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------03mOFBryRpUb8qINwbY1kud5" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------03mOFBryRpUb8qINwbY1kud5 Content-Type: multipart/mixed; boundary="------------0o2qI4Dwe9qyRtfYEJ0oaCnP"; protected-headers="v1" From: Juergen Gross To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Message-ID: <16b989f6-333b-10a8-c985-bfc132342f49@suse.com> Subject: Re: [PATCH 2/7] Mini-OS: add concept of mount points References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-3-jgross@suse.com> <20230205124509.pr5xswn4ygqsqoba@begin> In-Reply-To: <20230205124509.pr5xswn4ygqsqoba@begin> --------------0o2qI4Dwe9qyRtfYEJ0oaCnP Content-Type: multipart/mixed; boundary="------------T2Tp6q2lXqPcEcjlt5KXoU94" --------------T2Tp6q2lXqPcEcjlt5KXoU94 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDUuMDIuMjMgMTM6NDUsIFNhbXVlbCBUaGliYXVsdCB3cm90ZToNCj4gSnVlcmdlbiBH cm9zcywgbGUgdmVuLiAwMyBmw6l2ci4gMjAyMyAxMDoxODowNCArMDEwMCwgYSBlY3JpdDoN Cj4+ICtpbnQgb3Blbihjb25zdCBjaGFyICpwYXRobmFtZSwgaW50IGZsYWdzLCAuLi4pDQo+ PiArew0KPj4gKyAgICB1bnNpZ25lZCBpbnQgbSwgbWxlbjsNCj4+ICsgICAgc3RydWN0IG1v dW50X3BvaW50ICptbnQ7DQo+PiArICAgIG1vZGVfdCBtb2RlID0gMDsNCj4+ICsgICAgdmFf bGlzdCBhcDsNCj4+ICsNCj4+ICsgICAgaWYgKCBmbGFncyAmIE9fQ1JFQVQgKQ0KPj4gKyAg ICB7DQo+PiArICAgICAgICB2YV9zdGFydChhcCwgZmxhZ3MpOw0KPj4gKyAgICAgICAgbW9k ZSA9IHZhX2FyZyhhcCwgbW9kZV90KTsNCj4+ICsgICAgICAgIHZhX2VuZChhcCk7DQo+PiAg ICAgICB9DQo+PiAtICAgIGlmICghc3RybmNtcChwYXRobmFtZSwgIi9kZXYvbWVtIiwgc3Ry bGVuKCIvZGV2L21lbSIpKSkgew0KPj4gLSAgICAgICAgZmQgPSBhbGxvY19mZChGVFlQRV9N RU0pOw0KPj4gLSAgICAgICAgcHJpbnRrKCJvcGVuKC9kZXYvbWVtKSAtPiAlZFxuIiwgZmQp Ow0KPj4gLSAgICAgICAgcmV0dXJuIGZkOw0KPj4gKw0KPj4gKyAgICBmb3IgKCBtID0gMDsg bSA8IEFSUkFZX1NJWkUobW91bnRfcG9pbnRzKTsgbSsrICkNCj4+ICsgICAgew0KPj4gKyAg ICAgICAgbW50ID0gbW91bnRfcG9pbnRzICsgbTsNCj4+ICsgICAgICAgIG1sZW4gPSBzdHJs ZW4obW50LT5wYXRoKTsNCj4+ICsgICAgICAgIGlmICggIXN0cm5jbXAocGF0aG5hbWUsIG1u dC0+cGF0aCwgbWxlbikgJiYNCj4+ICsgICAgICAgICAgICAgKHBhdGhuYW1lW21sZW5dID09 ICcvJyB8fCBwYXRobmFtZVttbGVuXSA9PSAwKSApDQo+PiArICAgICAgICAgICAgcmV0dXJu IG1udC0+b3BlbihtbnQsIHBhdGhuYW1lLCBmbGFncywgbW9kZSk7DQo+IA0KPiBUaGlua2lu ZyBhYm91dCBpdCBtb3JlOiBkb24ndCB3ZSB3YW50IHRvIHBhc3MgcGF0aG5hbWUrbWxlbj8N Cj4gDQo+IFNvIHRoYXQgdGhlIG9wZW4gZnVuY3Rpb24gZG9lc24ndCBoYXZlIHRvIGNhcmUg d2hlcmUgaXQncyBtb3VudGVkLg0KDQpJIHRoaW5rIGJvdGggdmFyaWFudHMgaGF2ZSB0aGVp ciBwcm9zIGFuZCBjb25zLg0KDQpBcyB0aGUgb3BlbiBmdW5jdGlvbnMgaGF2ZSB0aGUgbW91 bnQgcG9pbnQgYXZhaWxhYmxlIHZpYSB0aGUgbW50IHBhcmFtZXRlcg0KSSBjYW4gY2hhbmdl IGl0Lg0KDQoNCkp1ZXJnZW4NCg0K --------------T2Tp6q2lXqPcEcjlt5KXoU94 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------T2Tp6q2lXqPcEcjlt5KXoU94-- --------------0o2qI4Dwe9qyRtfYEJ0oaCnP-- --------------03mOFBryRpUb8qINwbY1kud5 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPgx4kFAwAAAAAACgkQsN6d1ii/Ey+z SAf/WXa7lfvar4BViWtPFOQyN7ue9FGd6zGjc/YEkZ0bx2nI1A2xpU3ZGrkLdY6Plj7q+bqig5FF md2EOQ8vF7xC5DXH4Md/Y6ABs/4nrlOyshfLmKUT9hv4x+8JHLIF13Ux3tkD6xG/xyb2JwjOOW61 aG5RDZF3yBf/1sOJfkBsWyk6QTADgv8huFotRs2MVpzNGINqjlc7hPfEvAVrk4MUFyErvxbiSye7 X/3Meh9a4MW23+EiBjquJ60Xk90Xldvq3sC4iPjukskO11TQ9u9rfzq9oOB0+eVNVtszobsrY4Lw sArR4ArFNsf3leHBlSC05SjsZ33o9CfIMdSL0d/LCA== =Z174 -----END PGP SIGNATURE----- --------------03mOFBryRpUb8qINwbY1kud5-- From minios-devel-bounces@lists.xenproject.org Mon Feb 06 09:40:43 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 06 Feb 2023 09:40:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490155.758743 (Exim 4.92) (envelope-from ) id 1pOxzO-0000P6-91; Mon, 06 Feb 2023 09:40:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490155.758743; Mon, 06 Feb 2023 09:40:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOxzO-0000OK-4r; Mon, 06 Feb 2023 09:40:42 +0000 Received: by outflank-mailman (input) for mailman id 490155; Mon, 06 Feb 2023 09:40:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOxzN-0000MP-Ap for minios-devel@lists.xenproject.org; Mon, 06 Feb 2023 09:40:41 +0000 Received: from sonata.ens-lyon.org (sonata.ens-lyon.org [140.77.166.138]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4de7cc13-a602-11ed-933c-83870f6b2ba8; Mon, 06 Feb 2023 10:40:35 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 546FE20127; Mon, 6 Feb 2023 10:40:34 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Y1HQiThQCbPM; Mon, 6 Feb 2023 10:40:34 +0100 (CET) Received: from begin (unknown [89.207.171.57]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id EDDB62010A; Mon, 6 Feb 2023 10:40:33 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pOxzE-0091TM-3B; Mon, 06 Feb 2023 10:40:32 +0100 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 4de7cc13-a602-11ed-933c-83870f6b2ba8 Date: Mon, 6 Feb 2023 10:40:32 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH 5/7] Mini-OS: add 9pfs transport layer Message-ID: <20230206094032.se33a5z3kzfauywg@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-6-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230203091809.14478-6-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le ven. 03 févr. 2023 10:18:07 +0100, a ecrit: > +/* > + * Using an opportunistic approach for receiving data: in case multiple > + * requests are outstanding (which is very unlikely), we nevertheless need > + * to consume all data available until we reach the desired request. > + * For requests other than the one we are waiting for, we link the complete > + * data to the request via an intermediate buffer. For our own request we can > + * omit that buffer and directly fill the caller provided variables. > + */ This documents the "why" which is very welcome, but does not document what the function does exactly (AIUI, copy from buf1+buf2 into target up to len bytes, and update buf/len accordingly). > +static void copy_bufs(unsigned char **buf1, unsigned char **buf2, > + unsigned int *len1, unsigned int *len2, > + void *target, unsigned int len) > +{ > + if ( len <= *len1 ) > + { > + memcpy(target, *buf1, len); > + *buf1 += len; > + *len1 -= len; > + } > + else > + { > + memcpy(target, *buf1, *len1); > + target = (char *)target + *len1; > + len -= *len1; > + *buf1 = *buf2; > + *len1 = *len2; > + *buf2 = NULL; > + *len2 = 0; > + if ( len > *len1 ) > + len = *len1; But then this is a short copy, don't we need to error out, or at least log something? Normally the other end is not supposed to push data incrementaly, but better at least catch such misprogramming. > + memcpy(target, *buf1, *len1); > + } > +} > + > +static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, > + struct p9_header *hdr, const char *fmt, va_list ap) Please document what this helper function does (at the very least which way the copy happens). The hdr != NULL vs == NULL notably needs to be explained. > + case 'Q': > + qval = va_arg(ap, uint8_t *); > + copy_bufs(&buf1, &buf2, &len1, &len2, qval, 13); I'd say make this 13 a macro. > +static void rcv_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) > +{ > + va_list ap; > + > + va_start(ap, fmt); > + > + down(&dev->ring_in_sem); > + > + while ( !rcv_9p_one(dev, req, fmt, ap) ); > + > + rmb(); /* Read all data before updating ring index. */ > + dev->intf->in_cons = dev->cons_pvt_in; Shouldn't there be an event notification after updating the consumption index? > + up(&dev->ring_in_sem); > + > + va_end(ap); > +} Samuel From minios-devel-bounces@lists.xenproject.org Mon Feb 06 09:48:36 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 06 Feb 2023 09:48:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490164.758765 (Exim 4.92) (envelope-from ) id 1pOy6y-0001Qd-0U; Mon, 06 Feb 2023 09:48:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490164.758765; Mon, 06 Feb 2023 09:48:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOy6x-0001QW-Ti; Mon, 06 Feb 2023 09:48:31 +0000 Received: by outflank-mailman (input) for mailman id 490164; Mon, 06 Feb 2023 09:48:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOy6w-0001BL-Fs for minios-devel@lists.xenproject.org; Mon, 06 Feb 2023 09:48:30 +0000 Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 686e1ae3-a603-11ed-933c-83870f6b2ba8; Mon, 06 Feb 2023 10:48:28 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 3112220137; Mon, 6 Feb 2023 10:48:28 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 37gCvjbV6Dqt; Mon, 6 Feb 2023 10:48:28 +0100 (CET) Received: from begin (unknown [89.207.171.57]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 03F7D20135; Mon, 6 Feb 2023 10:48:27 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pOy6t-0092S6-0v; Mon, 06 Feb 2023 10:48:27 +0100 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 686e1ae3-a603-11ed-933c-83870f6b2ba8 Date: Mon, 6 Feb 2023 10:48:27 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH 4/7] Mini-OS: add 9pfs frontend Message-ID: <20230206094827.rayr5tqstjnco3nf@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-5-jgross@suse.com> <20230206090139.ehvf2czoocn6j7nc@begin> <383cbd1b-6518-bc1d-a3ae-5562e3dec5c1@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <383cbd1b-6518-bc1d-a3ae-5562e3dec5c1@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le lun. 06 févr. 2023 10:22:10 +0100, a ecrit: > On 06.02.23 10:01, Samuel Thibault wrote: > > Juergen Gross, le ven. 03 févr. 2023 10:18:06 +0100, a ecrit: > > > +void *init_9pfront(unsigned int id, const char *mnt) > > > +{ > > [...] > > > + free(xenbus_watch_path_token(XBT_NIL, bepath, bepath, &dev->events)); > > > > Better check for errors, otherwise the rest will hang without useful > > feedback. > > This is a common pattern in Mini-OS frontends. Ah, indeed. Ok, then. > > > + for ( v = version; *v; v++ ) > > > + { > > > + if ( strtoul(v, &v, 10) == 1 ) > > > + { > > > + v = NULL; > > > + break; > > > > This looks fragile? if version is "2.1" it will accept it apparently? I > > guess better check whether strtoul did read a number, and in that case > > break the loop anyway, successfully if the number is 1 and with failure > > otherwise. > > Versions are defined to be integers. Ah, it's a list of versions? (I don't know the protocol at all). > I can add checks for sanitizing backend written data, but I'm not sure we > need that. In case the backend wants to fool us, it can easily tell us to > support version 1 even if it doesn't. Not necessarily fooling, but misprogramming :) > > > + } > > > + } > > > + free(version); > > > + if ( v ) > > > + { > > > + reason = "version 1 not supported"; > > > + goto err; > > > + } > > > > This looks odd: when number 1 is detected this breaks out successfully, > > while the error message otherwise says that it's version 1 which is not > > supported? Is the message supposed to be "version greater than 1 not > > supported"? > > I can change the message to "Backend doesn't support version 1". Aah, yes indeed, that was the part I missed for understanding it all :) Samuel From minios-devel-bounces@lists.xenproject.org Mon Feb 06 10:05:52 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 06 Feb 2023 10:05:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490197.758803 (Exim 4.92) (envelope-from ) id 1pOyNj-0005Zj-3X; Mon, 06 Feb 2023 10:05:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490197.758803; Mon, 06 Feb 2023 10:05:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOyNj-0005Zb-0Y; Mon, 06 Feb 2023 10:05:51 +0000 Received: by outflank-mailman (input) for mailman id 490197; Mon, 06 Feb 2023 10:05:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOyNi-0005ZR-8F for minios-devel@lists.xenproject.org; Mon, 06 Feb 2023 10:05:50 +0000 Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d32acfb1-a605-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 11:05:46 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 65B9220127; Mon, 6 Feb 2023 11:05:46 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SwxpFAkPtfR4; Mon, 6 Feb 2023 11:05:46 +0100 (CET) Received: from begin (unknown [89.207.171.57]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 334B42010E; Mon, 6 Feb 2023 11:05:46 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pOyNd-0094RX-0W; Mon, 06 Feb 2023 11:05:45 +0100 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: d32acfb1-a605-11ed-93b5-47a8fe42b414 Date: Mon, 6 Feb 2023 11:05:45 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH 6/7] Mini-OS: add open and close handling to the 9pfs frontend Message-ID: <20230206100545.xice46pygaoh53bf@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-7-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230203091809.14478-7-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le ven. 03 févr. 2023 10:18:08 +0100, a ecrit: > +static unsigned int get_fid(struct dev_9pfs *dev) > +{ > + unsigned int fid; > + > + fid = ffs(dev->fid_mask); > + if ( fid ) > + dev->fid_mask &= 1ULL << (fid - 1); Isn't that missing a ~ ? > @@ -459,6 +522,134 @@ static int p9_attach(struct dev_9pfs *dev) > return ret; > } > > +static int p9_clunk(struct dev_9pfs *dev, uint32_t fid) > +{ > + struct req *req = get_free_req(dev); > + int ret; > + > + if ( !req ) > + return ENOENT; Rather EAGAIN? (and similar in other functions) (actually p9_version and p9_attach could be updated too, even if in their case it's not supposed to happen. > + req->cmd = P9_CMD_CLUNK; > + send_9p(dev, req, "U", fid); > + rcv_9p(dev, req, ""); > + ret = req->result; > + > + put_free_req(dev, req); > + > + return ret; > +} > +static unsigned int split_path(const char *pathname, char **split_ptr) > +{ > + unsigned int parts = 1; > + char *p; > + > + *split_ptr = strdup(pathname); > + > + for ( p = strchr(*split_ptr, '/'); p; p = strchr(p + 1, '/') ) > + { > + *p = 0; > + parts++; > + } > + > + return parts; > +} Do we need to care about an empty part if we're passed "/foo//bar"? > static int open_9pfs(struct mount_point *mnt, const char *pathname, int flags, > mode_t mode) > { > - errno = ENOSYS; > + int fd; > + char *path = NULL; > + char *p; > + struct file *file; > + struct file_9pfs *f9pfs; > + uint16_t nwalk; > + uint8_t omode; > + int ret; > + > + f9pfs = calloc(1, sizeof(*f9pfs)); > + f9pfs->dev = mnt->dev; > + f9pfs->fid = P9_ROOT_FID; > + > + fd = alloc_fd(ftype_9pfs); > + file = get_file_from_fd(fd); > + file->filedata = f9pfs; > + > + switch ( flags & O_ACCMODE ) > + { > + case O_RDONLY: > + omode = P9_OREAD; > + break; > + case O_WRONLY: > + omode = P9_OWRITE; > + break; > + case O_RDWR: > + omode = P9_ORDWR; > + break; > + default: > + ret = EINVAL; > + goto err; > + } [...] > + err: > + free(path); > + close(fd); > + errno = ret; This seems missing free(f9pfs)? Samuel From minios-devel-bounces@lists.xenproject.org Mon Feb 06 10:13:50 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 06 Feb 2023 10:13:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490215.758833 (Exim 4.92) (envelope-from ) id 1pOyVR-0007hB-GI; Mon, 06 Feb 2023 10:13:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490215.758833; Mon, 06 Feb 2023 10:13:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOyVR-0007gE-Bv; Mon, 06 Feb 2023 10:13:49 +0000 Received: by outflank-mailman (input) for mailman id 490215; Mon, 06 Feb 2023 10:13:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOyVQ-0007eF-4T for minios-devel@lists.xenproject.org; Mon, 06 Feb 2023 10:13:48 +0000 Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id efd3c771-a606-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 11:13:44 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 2567720127; Mon, 6 Feb 2023 11:13:43 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Lz8KYkgw86im; Mon, 6 Feb 2023 11:13:43 +0100 (CET) Received: from begin (unknown [89.207.171.57]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 0B8452010E; Mon, 6 Feb 2023 11:13:43 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pOyVJ-0095QC-0K; Mon, 06 Feb 2023 11:13:41 +0100 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: efd3c771-a606-11ed-93b5-47a8fe42b414 Date: Mon, 6 Feb 2023 11:13:41 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH 7/7] Mini-OS: add read and write support to 9pfsfront Message-ID: <20230206101341.5l7cxb2vvregskrx@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-8-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230203091809.14478-8-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le ven. 03 févr. 2023 10:18:09 +0100, a ecrit: > This patch is missing the limitation of read/write messages to stay > below the max. supported message size. It should at least be asserted. > +static int p9_read(struct dev_9pfs *dev, uint32_t fid, uint64_t offset, > + uint8_t *data, uint32_t len) > +{ > + struct req *req = get_free_req(dev); > + int ret; > + uint32_t count; > + > + if ( !req ) > + { > + errno = EIO; Here as well (and in p9_write) we'd want EAGAIN rather than EIO which can be mistaken with the error case below. > + return -1; > + } > + > + req->cmd = P9_CMD_READ; > + send_9p(dev, req, "ULU", fid, offset, len); > + rcv_9p(dev, req, "D", &count, data); > + > + if ( req->result ) > + { > + ret = -1; > + errno = EIO; > + } > + else > + ret = count; > + > + put_free_req(dev, req); > + > + return ret; > +} Samuel From minios-devel-bounces@lists.xenproject.org Mon Feb 06 10:14:09 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 06 Feb 2023 10:14:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490219.758843 (Exim 4.92) (envelope-from ) id 1pOyVl-00088V-Hj; Mon, 06 Feb 2023 10:14:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490219.758843; Mon, 06 Feb 2023 10:14:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOyVl-00088O-ES; Mon, 06 Feb 2023 10:14:09 +0000 Received: by outflank-mailman (input) for mailman id 490219; Mon, 06 Feb 2023 10:14:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOyVj-0007eF-SW for minios-devel@lists.xenproject.org; Mon, 06 Feb 2023 10:14:07 +0000 Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fc4aa96e-a606-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 11:14:05 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 0094120127; Mon, 6 Feb 2023 11:14:05 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cdpVfKjQhtbw; Mon, 6 Feb 2023 11:14:04 +0100 (CET) Received: from begin (unknown [89.207.171.57]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id CCF2D2010E; Mon, 6 Feb 2023 11:14:04 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pOyVc-0095Qn-25; Mon, 06 Feb 2023 11:14:00 +0100 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: fc4aa96e-a606-11ed-93b5-47a8fe42b414 Date: Mon, 6 Feb 2023 11:14:00 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH 0/7] Mini-OS: ad minimal 9pfs support Message-ID: <20230206101400.arrer4sdzvxlnsuv@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230203091809.14478-1-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Hello, Juergen Gross, le ven. 03 févr. 2023 10:18:02 +0100, a ecrit: > This series is adding minimal support to use 9pfs in Mini-OS. It is > adding a PV 9pfs frontend and the ability to open, close, read and > write files. Nice, thanks! :) Samuel From minios-devel-bounces@lists.xenproject.org Mon Feb 06 10:15:12 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 06 Feb 2023 10:15:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490235.758870 (Exim 4.92) (envelope-from ) id 1pOyWl-0000gi-B4; Mon, 06 Feb 2023 10:15:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490235.758870; Mon, 06 Feb 2023 10:15:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOyWl-0000gb-89; Mon, 06 Feb 2023 10:15:11 +0000 Received: by outflank-mailman (input) for mailman id 490235; Mon, 06 Feb 2023 10:15:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOyWj-0007eF-FW for minios-devel@lists.xenproject.org; Mon, 06 Feb 2023 10:15:09 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1ffd585c-a607-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 11:15:05 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C4B3760593; Mon, 6 Feb 2023 10:15:04 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9FE57138E8; Mon, 6 Feb 2023 10:15:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6RqtJSjT4GPhBwAAMHmgww (envelope-from ); Mon, 06 Feb 2023 10:15:04 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 1ffd585c-a607-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675678504; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=24gc4b4kCjRbILk7EM18yr6i0qc8TwuEJDtNvQq1DTI=; b=WqLogXlgn7rBLXX+UWzkByzhDaH848BkHiyK0JaBs0ynVmisYXzik2VE1SZ7n6UW8lRM1g LyGshCRc6mxg9RIyCqxWsfEwfXfSl3c9MoG0N+6HEcxdojxhdrNqpQwV76CRRJ4o0031mK AaJMKo/n0LKSjaoymOJSUAiMMwnzrCA= Message-ID: <466e1389-4691-f444-4792-4f5a4a3c7847@suse.com> Date: Mon, 6 Feb 2023 11:15:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-7-jgross@suse.com> <20230206100545.xice46pygaoh53bf@begin> From: Juergen Gross Subject: Re: [PATCH 6/7] Mini-OS: add open and close handling to the 9pfs frontend In-Reply-To: <20230206100545.xice46pygaoh53bf@begin> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------8ZbwYTaDRyDJ8fqLn06001jE" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------8ZbwYTaDRyDJ8fqLn06001jE Content-Type: multipart/mixed; boundary="------------n06Dc1QYBkwAe02blN1wVy2I"; protected-headers="v1" From: Juergen Gross To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Message-ID: <466e1389-4691-f444-4792-4f5a4a3c7847@suse.com> Subject: Re: [PATCH 6/7] Mini-OS: add open and close handling to the 9pfs frontend References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-7-jgross@suse.com> <20230206100545.xice46pygaoh53bf@begin> In-Reply-To: <20230206100545.xice46pygaoh53bf@begin> --------------n06Dc1QYBkwAe02blN1wVy2I Content-Type: multipart/mixed; boundary="------------S3fzr0NNhVvsK6Ixi4OndRVK" --------------S3fzr0NNhVvsK6Ixi4OndRVK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDYuMDIuMjMgMTE6MDUsIFNhbXVlbCBUaGliYXVsdCB3cm90ZToNCj4gSnVlcmdlbiBH cm9zcywgbGUgdmVuLiAwMyBmw6l2ci4gMjAyMyAxMDoxODowOCArMDEwMCwgYSBlY3JpdDoN Cj4+ICtzdGF0aWMgdW5zaWduZWQgaW50IGdldF9maWQoc3RydWN0IGRldl85cGZzICpkZXYp DQo+PiArew0KPj4gKyAgICB1bnNpZ25lZCBpbnQgZmlkOw0KPj4gKw0KPj4gKyAgICBmaWQg PSBmZnMoZGV2LT5maWRfbWFzayk7DQo+PiArICAgIGlmICggZmlkICkNCj4+ICsgICAgICAg IGRldi0+ZmlkX21hc2sgJj0gMVVMTCA8PCAoZmlkIC0gMSk7DQo+IA0KPiBJc24ndCB0aGF0 IG1pc3NpbmcgYSB+ID8NCg0KT2gsIGluZGVlZC4NCg0KPiANCj4+IEBAIC00NTksNiArNTIy LDEzNCBAQCBzdGF0aWMgaW50IHA5X2F0dGFjaChzdHJ1Y3QgZGV2XzlwZnMgKmRldikNCj4+ ICAgICAgIHJldHVybiByZXQ7DQo+PiAgIH0NCj4+ICAgDQo+PiArc3RhdGljIGludCBwOV9j bHVuayhzdHJ1Y3QgZGV2XzlwZnMgKmRldiwgdWludDMyX3QgZmlkKQ0KPj4gK3sNCj4+ICsg ICAgc3RydWN0IHJlcSAqcmVxID0gZ2V0X2ZyZWVfcmVxKGRldik7DQo+PiArICAgIGludCBy ZXQ7DQo+PiArDQo+PiArICAgIGlmICggIXJlcSApDQo+PiArICAgICAgICByZXR1cm4gRU5P RU5UOw0KPiANCj4gUmF0aGVyIEVBR0FJTj8gKGFuZCBzaW1pbGFyIGluIG90aGVyIGZ1bmN0 aW9ucykNCj4gKGFjdHVhbGx5IHA5X3ZlcnNpb24gYW5kIHA5X2F0dGFjaCBjb3VsZCBiZSB1 cGRhdGVkIHRvbywgZXZlbiBpZiBpbg0KPiB0aGVpciBjYXNlIGl0J3Mgbm90IHN1cHBvc2Vk IHRvIGhhcHBlbi4NCg0KWWVzLCBtaWdodCBiZSBiZXR0ZXIuDQoNCj4gDQo+PiArICAgIHJl cS0+Y21kID0gUDlfQ01EX0NMVU5LOw0KPj4gKyAgICBzZW5kXzlwKGRldiwgcmVxLCAiVSIs IGZpZCk7DQo+PiArICAgIHJjdl85cChkZXYsIHJlcSwgIiIpOw0KPj4gKyAgICByZXQgPSBy ZXEtPnJlc3VsdDsNCj4+ICsNCj4+ICsgICAgcHV0X2ZyZWVfcmVxKGRldiwgcmVxKTsNCj4+ ICsNCj4+ICsgICAgcmV0dXJuIHJldDsNCj4+ICt9DQo+IA0KPiANCj4+ICtzdGF0aWMgdW5z aWduZWQgaW50IHNwbGl0X3BhdGgoY29uc3QgY2hhciAqcGF0aG5hbWUsIGNoYXIgKipzcGxp dF9wdHIpDQo+PiArew0KPj4gKyAgICB1bnNpZ25lZCBpbnQgcGFydHMgPSAxOw0KPj4gKyAg ICBjaGFyICpwOw0KPj4gKw0KPj4gKyAgICAqc3BsaXRfcHRyID0gc3RyZHVwKHBhdGhuYW1l KTsNCj4+ICsNCj4+ICsgICAgZm9yICggcCA9IHN0cmNocigqc3BsaXRfcHRyLCAnLycpOyBw OyBwID0gc3RyY2hyKHAgKyAxLCAnLycpICkNCj4+ICsgICAgew0KPj4gKyAgICAgICAgKnAg PSAwOw0KPj4gKyAgICAgICAgcGFydHMrKzsNCj4+ICsgICAgfQ0KPj4gKw0KPj4gKyAgICBy ZXR1cm4gcGFydHM7DQo+PiArfQ0KPiANCj4gRG8gd2UgbmVlZCB0byBjYXJlIGFib3V0IGFu IGVtcHR5IHBhcnQgaWYgd2UncmUgcGFzc2VkICIvZm9vLy9iYXIiPw0KDQpJJ2QgcmF0aGVy IGFkZCBhIGNoZWNrIGZvciB0aGUgZmlsZSBuYW1lIHRvIGJlIHByb3Blcmx5IGNhbm9uaWNh bGl6ZWQNCmZ1cnRoZXIgdXAgaW4gdGhlIGhpZXJhcmNoeSAoZWl0aGVyIGluIG9wZW4oKSBk aXJlY3RseSwgb3IgaW4gb3Blbl85cGZzKCkpLg0KDQo+IA0KPj4gICBzdGF0aWMgaW50IG9w ZW5fOXBmcyhzdHJ1Y3QgbW91bnRfcG9pbnQgKm1udCwgY29uc3QgY2hhciAqcGF0aG5hbWUs IGludCBmbGFncywNCj4+ICAgICAgICAgICAgICAgICAgICAgICAgbW9kZV90IG1vZGUpDQo+ PiAgIHsNCj4+IC0gICAgZXJybm8gPSBFTk9TWVM7DQo+PiArICAgIGludCBmZDsNCj4+ICsg ICAgY2hhciAqcGF0aCA9IE5VTEw7DQo+PiArICAgIGNoYXIgKnA7DQo+PiArICAgIHN0cnVj dCBmaWxlICpmaWxlOw0KPj4gKyAgICBzdHJ1Y3QgZmlsZV85cGZzICpmOXBmczsNCj4+ICsg ICAgdWludDE2X3QgbndhbGs7DQo+PiArICAgIHVpbnQ4X3Qgb21vZGU7DQo+PiArICAgIGlu dCByZXQ7DQo+PiArDQo+PiArICAgIGY5cGZzID0gY2FsbG9jKDEsIHNpemVvZigqZjlwZnMp KTsNCj4+ICsgICAgZjlwZnMtPmRldiA9IG1udC0+ZGV2Ow0KPj4gKyAgICBmOXBmcy0+Zmlk ID0gUDlfUk9PVF9GSUQ7DQo+PiArDQo+PiArICAgIGZkID0gYWxsb2NfZmQoZnR5cGVfOXBm cyk7DQo+PiArICAgIGZpbGUgPSBnZXRfZmlsZV9mcm9tX2ZkKGZkKTsNCj4+ICsgICAgZmls ZS0+ZmlsZWRhdGEgPSBmOXBmczsNCj4+ICsNCj4+ICsgICAgc3dpdGNoICggZmxhZ3MgJiBP X0FDQ01PREUgKQ0KPj4gKyAgICB7DQo+PiArICAgIGNhc2UgT19SRE9OTFk6DQo+PiArICAg ICAgICBvbW9kZSA9IFA5X09SRUFEOw0KPj4gKyAgICAgICAgYnJlYWs7DQo+PiArICAgIGNh c2UgT19XUk9OTFk6DQo+PiArICAgICAgICBvbW9kZSA9IFA5X09XUklURTsNCj4+ICsgICAg ICAgIGJyZWFrOw0KPj4gKyAgICBjYXNlIE9fUkRXUjoNCj4+ICsgICAgICAgIG9tb2RlID0g UDlfT1JEV1I7DQo+PiArICAgICAgICBicmVhazsNCj4+ICsgICAgZGVmYXVsdDoNCj4+ICsg ICAgICAgIHJldCA9IEVJTlZBTDsNCj4+ICsgICAgICAgIGdvdG8gZXJyOw0KPj4gKyAgICB9 DQo+IFsuLi5dDQo+PiArIGVycjoNCj4+ICsgICAgZnJlZShwYXRoKTsNCj4+ICsgICAgY2xv c2UoZmQpOw0KPj4gKyAgICBlcnJubyA9IHJldDsNCj4gDQo+IFRoaXMgc2VlbXMgbWlzc2lu ZyBmcmVlKGY5cGZzKT8NCg0KY2xvc2UoKSBkb2VzIHRoYXQgdmlhIGNsb3NlXzlwZnMoKS4N Cg0KDQpKdWVyZ2VuDQoNCg== --------------S3fzr0NNhVvsK6Ixi4OndRVK Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------S3fzr0NNhVvsK6Ixi4OndRVK-- --------------n06Dc1QYBkwAe02blN1wVy2I-- --------------8ZbwYTaDRyDJ8fqLn06001jE Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPg0ygFAwAAAAAACgkQsN6d1ii/Ey8Y fQf/fL7x9heXbEJBL48tSCXTW6OYw7jEzQOiizt5WRR0+/lm93CySveo90odsVzZXKI+s5gi78ft NyKLQvw+N594qURTcW1a+6f6O8cVRXC9x3CVC1OiwjgFMES3zJQ3D9FoxL2gMGNLSoyPY+fl8ekN IOwEfoGB7weTgKf3upcttULmIA6dX3lSmZbQQb8tNCrDLJ75WL5f0cdzkzvOscIcNkz4bdNE3jZw Zsc8DPKoJWXg9lMaER/W9ks/GhgW5NVf9wGEEwnQuJLfCQeECn1rxa1G5qficMjz0hPMuG/FlyWT UfNABn4wOItpOuRTYfB16NK4OkCBQz1e4qBIoxwdqQ== =aPHh -----END PGP SIGNATURE----- --------------8ZbwYTaDRyDJ8fqLn06001jE-- From minios-devel-bounces@lists.xenproject.org Mon Feb 06 10:17:35 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 06 Feb 2023 10:17:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490242.758873 (Exim 4.92) (envelope-from ) id 1pOyZ4-0001BG-Hw; Mon, 06 Feb 2023 10:17:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490242.758873; Mon, 06 Feb 2023 10:17:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOyZ4-0001B9-FC; Mon, 06 Feb 2023 10:17:34 +0000 Received: by outflank-mailman (input) for mailman id 490242; Mon, 06 Feb 2023 10:17:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOyZ2-0001Aw-Tm for minios-devel@lists.xenproject.org; Mon, 06 Feb 2023 10:17:32 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7590dc98-a607-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 11:17:28 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6432D60508; Mon, 6 Feb 2023 10:17:28 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3E58F138E8; Mon, 6 Feb 2023 10:17:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id f5vnDbjT4GPUCQAAMHmgww (envelope-from ); Mon, 06 Feb 2023 10:17:28 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 7590dc98-a607-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675678648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=evmouaSQrGwFasoc4XbxgEKPXVKqbWqSn5F4PbsDFnA=; b=VUVaSMael8ihCS3giFabVmYD+FZ2TvxlR99RRV/eh1ngmGEaV4UiIDa8aZ30kFy9Kon7er ZKbAsAV3ajUJZ8YfE4P23XHn7LSaq+LB2z8fp90LFbRttKEHKUWTfUa3CkP4I9fhr2GjOS c3f2jaBjEr3A6G70UZJ63xVauBr3d28= Message-ID: <77d6d486-5ad5-1f13-e223-79295707d090@suse.com> Date: Mon, 6 Feb 2023 11:17:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 7/7] Mini-OS: add read and write support to 9pfsfront Content-Language: en-US To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-8-jgross@suse.com> <20230206101341.5l7cxb2vvregskrx@begin> From: Juergen Gross In-Reply-To: <20230206101341.5l7cxb2vvregskrx@begin> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------yclteTcnPxnWv8Sct0dAK7cP" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------yclteTcnPxnWv8Sct0dAK7cP Content-Type: multipart/mixed; boundary="------------ZNp3eWVZTHb7uEwrN7eu7GJn"; protected-headers="v1" From: Juergen Gross To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Message-ID: <77d6d486-5ad5-1f13-e223-79295707d090@suse.com> Subject: Re: [PATCH 7/7] Mini-OS: add read and write support to 9pfsfront References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-8-jgross@suse.com> <20230206101341.5l7cxb2vvregskrx@begin> In-Reply-To: <20230206101341.5l7cxb2vvregskrx@begin> --------------ZNp3eWVZTHb7uEwrN7eu7GJn Content-Type: multipart/mixed; boundary="------------DMoWO1LRQM0vB4sWYiinpiYJ" --------------DMoWO1LRQM0vB4sWYiinpiYJ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDYuMDIuMjMgMTE6MTMsIFNhbXVlbCBUaGliYXVsdCB3cm90ZToNCj4gDQo+IEp1ZXJn ZW4gR3Jvc3MsIGxlIHZlbi4gMDMgZsOpdnIuIDIwMjMgMTA6MTg6MDkgKzAxMDAsIGEgZWNy aXQ6DQo+PiBUaGlzIHBhdGNoIGlzIG1pc3NpbmcgdGhlIGxpbWl0YXRpb24gb2YgcmVhZC93 cml0ZSBtZXNzYWdlcyB0byBzdGF5DQo+PiBiZWxvdyB0aGUgbWF4LiBzdXBwb3J0ZWQgbWVz c2FnZSBzaXplLg0KPiANCj4gSXQgc2hvdWxkIGF0IGxlYXN0IGJlIGFzc2VydGVkLg0KDQpJ dCBjYW4gZWFzaWx5IGJlIGxpbWl0ZWQgYnkgcmV0dXJuaW5nIHRoZSByZXN1bHRpbmcgbGlt aXQgYXMgdGhlDQpudW1iZXIgb2YgcHJvY2Vzc2VkIGJ5dGVzLg0KDQo+IA0KPj4gK3N0YXRp YyBpbnQgcDlfcmVhZChzdHJ1Y3QgZGV2XzlwZnMgKmRldiwgdWludDMyX3QgZmlkLCB1aW50 NjRfdCBvZmZzZXQsDQo+PiArICAgICAgICAgICAgICAgICAgIHVpbnQ4X3QgKmRhdGEsIHVp bnQzMl90IGxlbikNCj4+ICt7DQo+PiArICAgIHN0cnVjdCByZXEgKnJlcSA9IGdldF9mcmVl X3JlcShkZXYpOw0KPj4gKyAgICBpbnQgcmV0Ow0KPj4gKyAgICB1aW50MzJfdCBjb3VudDsN Cj4+ICsNCj4+ICsgICAgaWYgKCAhcmVxICkNCj4+ICsgICAgew0KPj4gKyAgICAgICAgZXJy bm8gPSBFSU87DQo+IA0KPiBIZXJlIGFzIHdlbGwgKGFuZCBpbiBwOV93cml0ZSkgd2UnZCB3 YW50IEVBR0FJTiByYXRoZXIgdGhhbiBFSU8gd2hpY2gNCj4gY2FuIGJlIG1pc3Rha2VuIHdp dGggdGhlIGVycm9yIGNhc2UgYmVsb3cuDQoNCkZpbmUgd2l0aCBtZS4NCg0KDQpKdWVyZ2Vu DQoNCg== --------------DMoWO1LRQM0vB4sWYiinpiYJ Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------DMoWO1LRQM0vB4sWYiinpiYJ-- --------------ZNp3eWVZTHb7uEwrN7eu7GJn-- --------------yclteTcnPxnWv8Sct0dAK7cP Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPg07cFAwAAAAAACgkQsN6d1ii/Ey/Y ewf/Vs2qlPU52r/B/GeotisiJJzEbN7c93ENdaydlUth3ICAPO7+W2kKy8W1ZShmDHZKM7Xa6NGW 7Bk9kde9LMp7LDsNzckJ/+5IjLvATdoZM+TmDmq3fIkcWnXv7c3dnagoFqWXJfV5JXExgAJRaEtE xatHxhq9Uh0Qv4PooJBZ+vSP7h2CaQfzGu4cwlwW9o6pTfEAY5nhjt7KXRZ3bRpJiwhvpeIIT0pm oeYEx25eIwJNNZQkBwnOwm6rS4GB/BLWiFfb7zPDoeZSdoVoiIUOrm9NkD3PlWWZV0/uchsP1HqS TXIWArImFew8eSB3o4PKwjm67DAoAKyxpR0WT/KCIw== =Wzru -----END PGP SIGNATURE----- --------------yclteTcnPxnWv8Sct0dAK7cP-- From minios-devel-bounces@lists.xenproject.org Mon Feb 06 10:23:40 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 06 Feb 2023 10:23:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490252.758892 (Exim 4.92) (envelope-from ) id 1pOyex-0002pr-Aa; Mon, 06 Feb 2023 10:23:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490252.758892; Mon, 06 Feb 2023 10:23:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOyex-0002pj-6n; Mon, 06 Feb 2023 10:23:39 +0000 Received: by outflank-mailman (input) for mailman id 490252; Mon, 06 Feb 2023 10:23:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOyev-0002pV-L8 for minios-devel@lists.xenproject.org; Mon, 06 Feb 2023 10:23:37 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4f1806d8-a608-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 11:23:33 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3941860594; Mon, 6 Feb 2023 10:23:34 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 130BE138E8; Mon, 6 Feb 2023 10:23:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id y/RVAybV4GMJDwAAMHmgww (envelope-from ); Mon, 06 Feb 2023 10:23:34 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 4f1806d8-a608-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675679014; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eGuanfrf0A3kzUhMN7lYsuKZW6Zk7dcW6JQI09EEc7E=; b=NvBgQUREx2mV11XQLWf0Gb8PzOBQ9OqzGwl8Qb7vUu+Z31/hXKBMFgXd7heDTEFWwji4pX j/sCo7cSve/4FXqQlP3RElJd3WirHlBy5AI2+K62FYBczkslE/RT1SCDRYf6EfORPwpWbs gafktPBan309XRMi70mwZMBfNgeeAYY= Message-ID: <3ba95dd4-36f7-334e-0b03-56fa2bc0cbb3@suse.com> Date: Mon, 6 Feb 2023 11:23:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-6-jgross@suse.com> <20230206094032.se33a5z3kzfauywg@begin> From: Juergen Gross Subject: Re: [PATCH 5/7] Mini-OS: add 9pfs transport layer In-Reply-To: <20230206094032.se33a5z3kzfauywg@begin> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------Bc4x9tYfP8tMKt8xWp0H1ECW" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------Bc4x9tYfP8tMKt8xWp0H1ECW Content-Type: multipart/mixed; boundary="------------xP67I5Wz0d9SdgXgy6oP56QB"; protected-headers="v1" From: Juergen Gross To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Message-ID: <3ba95dd4-36f7-334e-0b03-56fa2bc0cbb3@suse.com> Subject: Re: [PATCH 5/7] Mini-OS: add 9pfs transport layer References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-6-jgross@suse.com> <20230206094032.se33a5z3kzfauywg@begin> In-Reply-To: <20230206094032.se33a5z3kzfauywg@begin> --------------xP67I5Wz0d9SdgXgy6oP56QB Content-Type: multipart/mixed; boundary="------------ex1d1W3yAyV40Lsc7SfLXea8" --------------ex1d1W3yAyV40Lsc7SfLXea8 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDYuMDIuMjMgMTA6NDAsIFNhbXVlbCBUaGliYXVsdCB3cm90ZToNCj4gSnVlcmdlbiBH cm9zcywgbGUgdmVuLiAwMyBmw6l2ci4gMjAyMyAxMDoxODowNyArMDEwMCwgYSBlY3JpdDoN Cj4+ICsvKg0KPj4gKyAqIFVzaW5nIGFuIG9wcG9ydHVuaXN0aWMgYXBwcm9hY2ggZm9yIHJl Y2VpdmluZyBkYXRhOiBpbiBjYXNlIG11bHRpcGxlDQo+PiArICogcmVxdWVzdHMgYXJlIG91 dHN0YW5kaW5nICh3aGljaCBpcyB2ZXJ5IHVubGlrZWx5KSwgd2UgbmV2ZXJ0aGVsZXNzIG5l ZWQNCj4+ICsgKiB0byBjb25zdW1lIGFsbCBkYXRhIGF2YWlsYWJsZSB1bnRpbCB3ZSByZWFj aCB0aGUgZGVzaXJlZCByZXF1ZXN0Lg0KPj4gKyAqIEZvciByZXF1ZXN0cyBvdGhlciB0aGFu IHRoZSBvbmUgd2UgYXJlIHdhaXRpbmcgZm9yLCB3ZSBsaW5rIHRoZSBjb21wbGV0ZQ0KPj4g KyAqIGRhdGEgdG8gdGhlIHJlcXVlc3QgdmlhIGFuIGludGVybWVkaWF0ZSBidWZmZXIuIEZv ciBvdXIgb3duIHJlcXVlc3Qgd2UgY2FuDQo+PiArICogb21pdCB0aGF0IGJ1ZmZlciBhbmQg ZGlyZWN0bHkgZmlsbCB0aGUgY2FsbGVyIHByb3ZpZGVkIHZhcmlhYmxlcy4NCj4+ICsgKi8N Cj4gDQo+IFRoaXMgZG9jdW1lbnRzIHRoZSAid2h5IiB3aGljaCBpcyB2ZXJ5IHdlbGNvbWUs IGJ1dCBkb2VzIG5vdCBkb2N1bWVudA0KPiB3aGF0IHRoZSBmdW5jdGlvbiBkb2VzIGV4YWN0 bHkgKEFJVUksIGNvcHkgZnJvbSBidWYxK2J1ZjIgaW50byB0YXJnZXQgdXANCj4gdG8gbGVu IGJ5dGVzLCBhbmQgdXBkYXRlIGJ1Zi9sZW4gYWNjb3JkaW5nbHkpLg0KDQpPa2F5LCB3aWxs IGFkZCBzb21lIG1vcmUgY29tbWVudHMuDQoNCj4gDQo+PiArc3RhdGljIHZvaWQgY29weV9i dWZzKHVuc2lnbmVkIGNoYXIgKipidWYxLCB1bnNpZ25lZCBjaGFyICoqYnVmMiwNCj4+ICsg ICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50ICpsZW4xLCB1bnNpZ25lZCBpbnQg KmxlbjIsDQo+PiArICAgICAgICAgICAgICAgICAgICAgIHZvaWQgKnRhcmdldCwgdW5zaWdu ZWQgaW50IGxlbikNCj4+ICt7DQo+PiArICAgIGlmICggbGVuIDw9ICpsZW4xICkNCj4+ICsg ICAgew0KPj4gKyAgICAgICAgbWVtY3B5KHRhcmdldCwgKmJ1ZjEsIGxlbik7DQo+PiArICAg ICAgICAqYnVmMSArPSBsZW47DQo+PiArICAgICAgICAqbGVuMSAtPSBsZW47DQo+PiArICAg IH0NCj4+ICsgICAgZWxzZQ0KPj4gKyAgICB7DQo+PiArICAgICAgICBtZW1jcHkodGFyZ2V0 LCAqYnVmMSwgKmxlbjEpOw0KPj4gKyAgICAgICAgdGFyZ2V0ID0gKGNoYXIgKil0YXJnZXQg KyAqbGVuMTsNCj4+ICsgICAgICAgIGxlbiAtPSAqbGVuMTsNCj4+ICsgICAgICAgICpidWYx ID0gKmJ1ZjI7DQo+PiArICAgICAgICAqbGVuMSA9ICpsZW4yOw0KPj4gKyAgICAgICAgKmJ1 ZjIgPSBOVUxMOw0KPj4gKyAgICAgICAgKmxlbjIgPSAwOw0KPj4gKyAgICAgICAgaWYgKCBs ZW4gPiAqbGVuMSApDQo+PiArICAgICAgICAgICAgbGVuID0gKmxlbjE7DQo+IA0KPiBCdXQg dGhlbiB0aGlzIGlzIGEgc2hvcnQgY29weSwgZG9uJ3Qgd2UgbmVlZCB0byBlcnJvciBvdXQs IG9yIGF0IGxlYXN0DQo+IGxvZyBzb21ldGhpbmc/IE5vcm1hbGx5IHRoZSBvdGhlciBlbmQg aXMgbm90IHN1cHBvc2VkIHRvIHB1c2ggZGF0YQ0KPiBpbmNyZW1lbnRhbHksIGJ1dCBiZXR0 ZXIgYXQgbGVhc3QgY2F0Y2ggc3VjaCBtaXNwcm9ncmFtbWluZy4NCg0KSSBjYW4gYWRkIGEg bG9nIG1lc3NhZ2UuDQoNCj4gDQo+PiArICAgICAgICBtZW1jcHkodGFyZ2V0LCAqYnVmMSwg KmxlbjEpOw0KPj4gKyAgICB9DQo+PiArfQ0KPj4gKw0KPj4gK3N0YXRpYyB2b2lkIHJjdl85 cF9jb3B5KHN0cnVjdCBkZXZfOXBmcyAqZGV2LCBzdHJ1Y3QgcmVxICpyZXEsDQo+PiArICAg ICAgICAgICAgICAgICAgICAgICAgc3RydWN0IHA5X2hlYWRlciAqaGRyLCBjb25zdCBjaGFy ICpmbXQsIHZhX2xpc3QgYXApDQo+IA0KPiBQbGVhc2UgZG9jdW1lbnQgd2hhdCB0aGlzIGhl bHBlciBmdW5jdGlvbiBkb2VzIChhdCB0aGUgdmVyeSBsZWFzdCB3aGljaA0KPiB3YXkgdGhl IGNvcHkgaGFwcGVucykuIFRoZSBoZHIgIT0gTlVMTCB2cyA9PSBOVUxMIG5vdGFibHkgbmVl ZHMgdG8gYmUNCj4gZXhwbGFpbmVkLg0KDQpPa2F5Lg0KDQo+IA0KPj4gKyAgICAgICAgY2Fz ZSAnUSc6DQo+PiArICAgICAgICAgICAgcXZhbCA9IHZhX2FyZyhhcCwgdWludDhfdCAqKTsN Cj4+ICsgICAgICAgICAgICBjb3B5X2J1ZnMoJmJ1ZjEsICZidWYyLCAmbGVuMSwgJmxlbjIs IHF2YWwsIDEzKTsNCj4gDQo+IEknZCBzYXkgbWFrZSB0aGlzIDEzIGEgbWFjcm8uDQoNCk9r YXkuDQoNCj4gDQo+IA0KPj4gK3N0YXRpYyB2b2lkIHJjdl85cChzdHJ1Y3QgZGV2XzlwZnMg KmRldiwgc3RydWN0IHJlcSAqcmVxLCBjb25zdCBjaGFyICpmbXQsIC4uLikNCj4+ICt7DQo+ PiArICAgIHZhX2xpc3QgYXA7DQo+PiArDQo+PiArICAgIHZhX3N0YXJ0KGFwLCBmbXQpOw0K Pj4gKw0KPj4gKyAgICBkb3duKCZkZXYtPnJpbmdfaW5fc2VtKTsNCj4+ICsNCj4+ICsgICAg d2hpbGUgKCAhcmN2XzlwX29uZShkZXYsIHJlcSwgZm10LCBhcCkgKTsNCj4+ICsNCj4+ICsg ICAgcm1iKCk7IC8qIFJlYWQgYWxsIGRhdGEgYmVmb3JlIHVwZGF0aW5nIHJpbmcgaW5kZXgu ICovDQo+PiArICAgIGRldi0+aW50Zi0+aW5fY29ucyA9IGRldi0+Y29uc19wdnRfaW47DQo+ IA0KPiBTaG91bGRuJ3QgdGhlcmUgYmUgYW4gZXZlbnQgbm90aWZpY2F0aW9uIGFmdGVyIHVw ZGF0aW5nIHRoZSBjb25zdW1wdGlvbg0KPiBpbmRleD8NCg0KSG1tLCB5ZXMuDQoNCg0KSnVl cmdlbg0K --------------ex1d1W3yAyV40Lsc7SfLXea8 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------ex1d1W3yAyV40Lsc7SfLXea8-- --------------xP67I5Wz0d9SdgXgy6oP56QB-- --------------Bc4x9tYfP8tMKt8xWp0H1ECW Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPg1SUFAwAAAAAACgkQsN6d1ii/Ey92 qgf7BfSpL1a3P5Fg0ErbMeHBESKFsN0h+VmbP/vkfxIKhDG9aEiA3nDMrJCWexGqFosGUnyj0MVe EEgM8Smv+KzWG4GtERoOx28RyVpnfe3DOIj2iMx2//H1mJtEq/HsLnFS2goHjyv12H8A0Eok5j1q fWQJpIq/SKTHjEhZDT6BnxUJSfLWILIZb6s493jXHdB2kkBDN5JLdVXcCPxx/t23XziKqX37ofJe PRZZjJNyVv0FrZ+o9uGn/pn/yOAzhie27HzS4dOOHG/FicU5737HuVgah+dRngc/cs3oMO5k+urm umZO3I7T5mMu0kHwk4dgTRV8dJGGDGSKekc7f6RKmQ== =hbgf -----END PGP SIGNATURE----- --------------Bc4x9tYfP8tMKt8xWp0H1ECW-- From minios-devel-bounces@lists.xenproject.org Mon Feb 06 12:05:38 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 06 Feb 2023 12:05:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490305.758938 (Exim 4.92) (envelope-from ) id 1pP0FZ-0006Go-Hk; Mon, 06 Feb 2023 12:05:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490305.758938; Mon, 06 Feb 2023 12:05:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP0FZ-0006Gh-Ei; Mon, 06 Feb 2023 12:05:33 +0000 Received: by outflank-mailman (input) for mailman id 490305; Mon, 06 Feb 2023 12:05:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP0FX-00061a-GP for minios-devel@lists.xenproject.org; Mon, 06 Feb 2023 12:05:31 +0000 Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8b20074c-a616-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 13:05:27 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id DF5EB2012F; Mon, 6 Feb 2023 13:05:26 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zYnBPJhNB15A; Mon, 6 Feb 2023 13:05:26 +0100 (CET) Received: from begin (nat-inria-interne-52-gw-01-bso.bordeaux.inria.fr [194.199.1.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 93CEE20127; Mon, 6 Feb 2023 13:05:26 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pP0FS-009A6r-0i; Mon, 06 Feb 2023 13:05:26 +0100 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 8b20074c-a616-11ed-93b5-47a8fe42b414 Date: Mon, 6 Feb 2023 13:05:26 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH 7/7] Mini-OS: add read and write support to 9pfsfront Message-ID: <20230206120526.242njyptovkpz3jl@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-8-jgross@suse.com> <20230206101341.5l7cxb2vvregskrx@begin> <77d6d486-5ad5-1f13-e223-79295707d090@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <77d6d486-5ad5-1f13-e223-79295707d090@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le lun. 06 févr. 2023 11:17:27 +0100, a ecrit: > On 06.02.23 11:13, Samuel Thibault wrote: > > > > Juergen Gross, le ven. 03 févr. 2023 10:18:09 +0100, a ecrit: > > > This patch is missing the limitation of read/write messages to stay > > > below the max. supported message size. > > > > It should at least be asserted. > > It can easily be limited by returning the resulting limit as the > number of processed bytes. Strictly speaking, posix allows to return short reads, but that's usually only handled by applications when they know that they may get signals. I'd thus rather have read/write loop over the size. Samuel From minios-devel-bounces@lists.xenproject.org Mon Feb 06 15:35:15 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 06 Feb 2023 15:35:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490563.759316 (Exim 4.92) (envelope-from ) id 1pP3WR-00053G-TX; Mon, 06 Feb 2023 15:35:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490563.759316; Mon, 06 Feb 2023 15:35:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP3WR-000539-R2; Mon, 06 Feb 2023 15:35:11 +0000 Received: by outflank-mailman (input) for mailman id 490563; Mon, 06 Feb 2023 15:35:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP3WQ-00052w-RN for minios-devel@lists.xenproject.org; Mon, 06 Feb 2023 15:35:10 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d59f522e-a633-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 16:35:07 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4BA766061F; Mon, 6 Feb 2023 15:35:07 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 268BC138E8; Mon, 6 Feb 2023 15:35:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 5Hj2Byse4WM8bwAAMHmgww (envelope-from ); Mon, 06 Feb 2023 15:35:07 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: d59f522e-a633-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675697707; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dGfLuu/ZorhBxx/TbawrsNpt8CBswzePx7SV5hJpPYk=; b=LpQaXqH6HGS2wE18v9f6oDK3Q08Rifxy1U4VpHy4gP0CQRErkmMpUPkzOf2EG+0OtKYOyQ Ov3fzfofnQGiPMgt5ggaUTJ0PnBz8NGAHafl7MEmhArE0dUvhKqr6GJf5PSw/LVRmDn9HW O/iI6+G8FDyyY57xu3AvYHwvtqb9UEU= Message-ID: <2fcd7ba4-a388-ad28-64aa-a599882b4f9f@suse.com> Date: Mon, 6 Feb 2023 16:35:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 7/7] Mini-OS: add read and write support to 9pfsfront Content-Language: en-US To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-8-jgross@suse.com> <20230206101341.5l7cxb2vvregskrx@begin> <77d6d486-5ad5-1f13-e223-79295707d090@suse.com> <20230206120526.242njyptovkpz3jl@begin> From: Juergen Gross In-Reply-To: <20230206120526.242njyptovkpz3jl@begin> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------E0OOKWO0NiPn66yq2q0cE1v0" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------E0OOKWO0NiPn66yq2q0cE1v0 Content-Type: multipart/mixed; boundary="------------ofXfWL0jC02OPXYzfjya7tIT"; protected-headers="v1" From: Juergen Gross To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Message-ID: <2fcd7ba4-a388-ad28-64aa-a599882b4f9f@suse.com> Subject: Re: [PATCH 7/7] Mini-OS: add read and write support to 9pfsfront References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-8-jgross@suse.com> <20230206101341.5l7cxb2vvregskrx@begin> <77d6d486-5ad5-1f13-e223-79295707d090@suse.com> <20230206120526.242njyptovkpz3jl@begin> In-Reply-To: <20230206120526.242njyptovkpz3jl@begin> --------------ofXfWL0jC02OPXYzfjya7tIT Content-Type: multipart/mixed; boundary="------------CX9llXcnU2Kt063y0y38DmiH" --------------CX9llXcnU2Kt063y0y38DmiH Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDYuMDIuMjMgMTM6MDUsIFNhbXVlbCBUaGliYXVsdCB3cm90ZToNCj4gSnVlcmdlbiBH cm9zcywgbGUgbHVuLiAwNiBmw6l2ci4gMjAyMyAxMToxNzoyNyArMDEwMCwgYSBlY3JpdDoN Cj4+IE9uIDA2LjAyLjIzIDExOjEzLCBTYW11ZWwgVGhpYmF1bHQgd3JvdGU6DQo+Pj4NCj4+ PiBKdWVyZ2VuIEdyb3NzLCBsZSB2ZW4uIDAzIGbDqXZyLiAyMDIzIDEwOjE4OjA5ICswMTAw LCBhIGVjcml0Og0KPj4+PiBUaGlzIHBhdGNoIGlzIG1pc3NpbmcgdGhlIGxpbWl0YXRpb24g b2YgcmVhZC93cml0ZSBtZXNzYWdlcyB0byBzdGF5DQo+Pj4+IGJlbG93IHRoZSBtYXguIHN1 cHBvcnRlZCBtZXNzYWdlIHNpemUuDQo+Pj4NCj4+PiBJdCBzaG91bGQgYXQgbGVhc3QgYmUg YXNzZXJ0ZWQuDQo+Pg0KPj4gSXQgY2FuIGVhc2lseSBiZSBsaW1pdGVkIGJ5IHJldHVybmlu ZyB0aGUgcmVzdWx0aW5nIGxpbWl0IGFzIHRoZQ0KPj4gbnVtYmVyIG9mIHByb2Nlc3NlZCBi eXRlcy4NCj4gDQo+IFN0cmljdGx5IHNwZWFraW5nLCBwb3NpeCBhbGxvd3MgdG8gcmV0dXJu IHNob3J0IHJlYWRzLCBidXQgdGhhdCdzDQo+IHVzdWFsbHkgb25seSBoYW5kbGVkIGJ5IGFw cGxpY2F0aW9ucyB3aGVuIHRoZXkga25vdyB0aGF0IHRoZXkgbWF5IGdldA0KPiBzaWduYWxz LiBJJ2QgdGh1cyByYXRoZXIgaGF2ZSByZWFkL3dyaXRlIGxvb3Agb3ZlciB0aGUgc2l6ZS4N Cg0KT2theS4NCg0KDQpKdWVyZ2VuDQoNCg== --------------CX9llXcnU2Kt063y0y38DmiH Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------CX9llXcnU2Kt063y0y38DmiH-- --------------ofXfWL0jC02OPXYzfjya7tIT-- --------------E0OOKWO0NiPn66yq2q0cE1v0 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPhHioFAwAAAAAACgkQsN6d1ii/Ey+7 owf/d8FYHsMx6HjK3fQ8JrLkXyYI9TyLRZIblaiBFpLVZEo0mpRJmwiNcNMSAjRR+ODYOwHe1zCy 4S1lwOoFOwkiIAC5Ss8YaeYRCuMmGlcINb3mUeidrarWGAHdX98d7Q2cK87rH3Kmy9y8twcTAtV5 HY7C1YYCGRsCs+aXTqqZNDYpLtonTGQsAHda0nejAahQRGAE1szmObVqKXejgEYKmAZofabRthtK E6qaPgE/F5amqiUxLTpDiwQBODLWGubtiN/XbSZiPNyLDQ4UBkcMUztZA1KLnKo3pxTnlu2jDbvp Fw3Twpvwvsxj4jpCgXAQIX6O0tvd055B+FBOa7kDPA== =T4vE -----END PGP SIGNATURE----- --------------E0OOKWO0NiPn66yq2q0cE1v0-- From minios-devel-bounces@lists.xenproject.org Fri Feb 10 10:46:42 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 10 Feb 2023 10:46:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493250.763087 (Exim 4.92) (envelope-from ) id 1pQQvM-0005jU-Jo; Fri, 10 Feb 2023 10:46:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493250.763087; Fri, 10 Feb 2023 10:46:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQvM-0005jN-H9; Fri, 10 Feb 2023 10:46:36 +0000 Received: by outflank-mailman (input) for mailman id 493250; Fri, 10 Feb 2023 10:46:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQvL-0005jA-0l for minios-devel@lists.xenproject.org; Fri, 10 Feb 2023 10:46:35 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2e0ba236-a930-11ed-933c-83870f6b2ba8; Fri, 10 Feb 2023 11:46:33 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 25A61204CF; Fri, 10 Feb 2023 10:46:31 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EAC411325E; Fri, 10 Feb 2023 10:46:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6hvXN4Yg5mO2UwAAMHmgww (envelope-from ); Fri, 10 Feb 2023 10:46:30 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 2e0ba236-a930-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676025991; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=PDgHDMzjJXo9wSzs1oG9zdzpDquZjD5pWP6GxGhcd4Q=; b=IIhrADpIWTxEgSUvnVokfAXrtMyY9JruXt9ebOrSqdyvfpjRScTWchz+ul03TXgTOEVYub Q4aMkSdVqbIkhyVX8hvNdlOioRuUI4tu7XuFSzXmaDRIdKDcWCWaYM5jxklOqkyzFfbScb oQ2DRiUrJxmNxQAy6XqyWuLV2Q2vutw= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH v2 0/7] Mini-OS: add minimal 9pfs support Date: Fri, 10 Feb 2023 11:46:21 +0100 Message-Id: <20230210104628.14374-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series is adding minimal support to use 9pfs in Mini-OS. It is adding a PV 9pfs frontend and the ability to open, close, read and write files. The series has been tested with qemu as 9pfs backend in a PVH Mini-OS guest (I've used a slightly modified Xenstore-stubdom for that purpose in order to reuse the build runes). This series is meant to setup the stage for adding file based logging support to Xenstore-stubdom and later to add live update support (being able to save the LU data stream in a dom0 file makes this a _lot_ easier). In order to keep Mini-OS's license I have only used the protocol docs available on the internet [1] and then verified those with the qemu 9pfs backend implementation (especially for supporting the 9P2000.u variant, as qemu doesn't support the basic 9P2000 protocol). The needed fixed values of the protocol have been taken from [2]. [1]: http://ericvh.github.io/9p-rfc/rfc9p2000.html [2]: https://github.com/0intro/libixp Changes in V2: - addressed comments by Samuel Thibault Juergen Gross (7): Mini-OS: xenbus: add support for reading node from directory Mini-OS: add concept of mount points Mini-OS: add support for runtime mounts Mini-OS: add 9pfs frontend Mini-OS: add 9pfs transport layer Mini-OS: add open and close handling to the 9pfs frontend Mini-OS: add read and write support to 9pfsfront 9pfront.c | 1291 +++++++++++++++++++++++++++++++++ Config.mk | 1 + Makefile | 1 + arch/x86/testbuild/all-no | 1 + arch/x86/testbuild/all-yes | 1 + arch/x86/testbuild/newxen-yes | 1 + include/9pfront.h | 7 + include/lib.h | 14 + include/xenbus.h | 6 + lib/sys.c | 128 +++- xenbus.c | 40 +- 11 files changed, 1469 insertions(+), 22 deletions(-) create mode 100644 9pfront.c create mode 100644 include/9pfront.h -- 2.35.3 From minios-devel-bounces@lists.xenproject.org Fri Feb 10 10:46:43 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 10 Feb 2023 10:46:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493252.763103 (Exim 4.92) (envelope-from ) id 1pQQvT-00062X-SO; Fri, 10 Feb 2023 10:46:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493252.763103; Fri, 10 Feb 2023 10:46:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQvT-00062Q-PR; Fri, 10 Feb 2023 10:46:43 +0000 Received: by outflank-mailman (input) for mailman id 493252; Fri, 10 Feb 2023 10:46:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQvR-000617-OH for minios-devel@lists.xenproject.org; Fri, 10 Feb 2023 10:46:41 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 31429bb5-a930-11ed-93b5-47a8fe42b414; Fri, 10 Feb 2023 11:46:38 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B835E5CA5F; Fri, 10 Feb 2023 10:46:36 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 892191325E; Fri, 10 Feb 2023 10:46:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6FYVIIwg5mPFUwAAMHmgww (envelope-from ); Fri, 10 Feb 2023 10:46:36 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 31429bb5-a930-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676025996; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EcyQSQ8MTpZXgX1s81+j7sy99tw1SNkYAs91wZGwPfs=; b=Q4izeK3vg+QRNfe+B27h8+Led+RcTZCktMmPvigGZDrNU4Xj1dllvMlKXG1Qnar/sdGTIV iPJC/ElqxDe3JzAxXD6BVOv6ZawW+yI0oj+q1LFSKjm3J8Xn8MnTjmftES/f6AsOFtjNWf yh+Gmy315qlOSF8ALfKeXDfBXBJihg4= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH v2 1/7] Mini-OS: xenbus: add support for reading node from directory Date: Fri, 10 Feb 2023 11:46:22 +0100 Message-Id: <20230210104628.14374-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230210104628.14374-1-jgross@suse.com> References: <20230210104628.14374-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Especially PV device drivers often need to read multiple Xenstore nodes from a common directory. Add support for reading a string or an unsigned value by specifying the directory and the node. Signed-off-by: Juergen Gross --- V2: - check sscanf() return value (Samuel Thibault) --- include/xenbus.h | 6 ++++++ xenbus.c | 40 +++++++++++++++++++++++++++++++++++++--- 2 files changed, 43 insertions(+), 3 deletions(-) diff --git a/include/xenbus.h b/include/xenbus.h index 3871f358..c0fc0ac5 100644 --- a/include/xenbus.h +++ b/include/xenbus.h @@ -108,6 +108,12 @@ int xenbus_read_integer(const char *path); * read and parsing were successful, 0 if not */ int xenbus_read_uuid(const char* path, unsigned char uuid[16]); +/* Support functions for reading values from directory/node tuple. */ +char *xenbus_read_string(xenbus_transaction_t xbt, const char *dir, + const char *node, char **value); +char *xenbus_read_unsigned(xenbus_transaction_t xbt, const char *dir, + const char *node, unsigned int *value); + /* Contraction of snprintf and xenbus_write(path/node). */ char* xenbus_printf(xenbus_transaction_t xbt, const char* node, const char* path, diff --git a/xenbus.c b/xenbus.c index 81e9b65d..923e8181 100644 --- a/xenbus.c +++ b/xenbus.c @@ -936,16 +936,21 @@ int xenbus_read_uuid(const char *path, unsigned char uuid[16]) return 1; } +#define BUFFER_SIZE 256 +static void xenbus_build_path(const char *dir, const char *node, char *res) +{ + BUG_ON(strlen(dir) + strlen(node) + 1 >= BUFFER_SIZE); + sprintf(res,"%s/%s", dir, node); +} + char *xenbus_printf(xenbus_transaction_t xbt, const char* node, const char* path, const char* fmt, ...) { -#define BUFFER_SIZE 256 char fullpath[BUFFER_SIZE]; char val[BUFFER_SIZE]; va_list args; - BUG_ON(strlen(node) + strlen(path) + 1 >= BUFFER_SIZE); - sprintf(fullpath,"%s/%s", node, path); + xenbus_build_path(node, path, fullpath); va_start(args, fmt); vsprintf(val, fmt, args); va_end(args); @@ -964,6 +969,35 @@ domid_t xenbus_get_self_id(void) return ret; } +char *xenbus_read_string(xenbus_transaction_t xbt, const char *dir, + const char *node, char **value) +{ + char path[BUFFER_SIZE]; + + xenbus_build_path(dir, node, path); + + return xenbus_read(xbt, path, value); +} + +char *xenbus_read_unsigned(xenbus_transaction_t xbt, const char *dir, + const char *node, unsigned int *value) +{ + char path[BUFFER_SIZE]; + char *msg; + char *str; + + xenbus_build_path(dir, node, path); + msg = xenbus_read(xbt, path, &str); + if ( msg ) + return msg; + + if ( sscanf(str, "%u", value) != 1 ) + msg = strdup("EINVAL"); + free(str); + + return msg; +} + /* * Local variables: * mode: C -- 2.35.3 From minios-devel-bounces@lists.xenproject.org Fri Feb 10 10:46:47 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 10 Feb 2023 10:46:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493254.763118 (Exim 4.92) (envelope-from ) id 1pQQvX-0006MT-5J; Fri, 10 Feb 2023 10:46:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493254.763118; Fri, 10 Feb 2023 10:46:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQvX-0006MM-2A; Fri, 10 Feb 2023 10:46:47 +0000 Received: by outflank-mailman (input) for mailman id 493254; Fri, 10 Feb 2023 10:46:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQvV-000617-Jl for minios-devel@lists.xenproject.org; Fri, 10 Feb 2023 10:46:45 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 34a04e52-a930-11ed-93b5-47a8fe42b414; Fri, 10 Feb 2023 11:46:42 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 615EC3FEC5; Fri, 10 Feb 2023 10:46:42 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 39D171325E; Fri, 10 Feb 2023 10:46:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 5aTuDJIg5mPXUwAAMHmgww (envelope-from ); Fri, 10 Feb 2023 10:46:42 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 34a04e52-a930-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676026002; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/AHf/75zmPALL2yeH8dnyZ0qXj5tN9xIh6TXHZM0XmI=; b=uUnrQU6OBTmGEoK5GrqQ5X1uKYO50tysm/j0qaooTSeJQ2BfFKK4egmCT4hUuwYhyS1ZEq LxH6MFeQ7hdpMDYz59hrNEqR8JXTYmxpLEpUk7LM/Qn5LZD28KoJep29gwFa0s0TS9Jbzz iE28cYUEKlTy1HyP4v909JUgLcPRPOA= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH v2 2/7] Mini-OS: add concept of mount points Date: Fri, 10 Feb 2023 11:46:23 +0100 Message-Id: <20230210104628.14374-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230210104628.14374-1-jgross@suse.com> References: <20230210104628.14374-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the concept of mount points to Mini-OS. A mount point is a path associated with a device pointer and an open() callback. A mount point can be either a file (e.g. "/dev/mem") or a directory ("/var/log"). This allows to replace the special casing in the generic open() handling with a generic mount point handling. Prepare the open() callbacks to support creating new files by adding a mode parameter. Additionally add a close() prototype to include/lib.h, as it is missing today. Signed-off-by: Juergen Gross --- V2: - pass path below mount point to open callbacks (Samuel Thibault) --- include/lib.h | 9 ++++++ lib/sys.c | 80 +++++++++++++++++++++++++++++++++++++++------------ 2 files changed, 70 insertions(+), 19 deletions(-) diff --git a/include/lib.h b/include/lib.h index bec99646..36d94ec4 100644 --- a/include/lib.h +++ b/include/lib.h @@ -187,6 +187,13 @@ struct file_ops { bool (*select_wr)(struct file *file); }; +struct mount_point { + const char *path; + int (*open)(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode); + void *dev; +}; + unsigned int alloc_file_type(const struct file_ops *ops); off_t lseek_default(struct file *file, off_t offset, int whence); @@ -198,6 +205,8 @@ int alloc_fd(unsigned int type); void close_all_files(void); extern struct thread *main_thread; void sparse(unsigned long data, size_t size); + +int close(int fd); #endif #endif /* _LIB_H_ */ diff --git a/lib/sys.c b/lib/sys.c index 8f8a3de2..2f33c937 100644 --- a/lib/sys.c +++ b/lib/sys.c @@ -263,11 +263,6 @@ char *getcwd(char *buf, size_t size) return buf; } -#define LOG_PATH "/var/log/" -#define SAVE_PATH "/var/lib/xen" -#define SAVE_CONSOLE 1 -#define RESTORE_CONSOLE 2 - int mkdir(const char *pathname, mode_t mode) { errno = EIO; @@ -286,18 +281,30 @@ int posix_openpt(int flags) return fd; } +static int open_pt(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode) +{ + return posix_openpt(flags); +} + int open_savefile(const char *path, int save) { int fd; char nodename[64]; - snprintf(nodename, sizeof(nodename), "device/console/%d", save ? SAVE_CONSOLE : RESTORE_CONSOLE); + snprintf(nodename, sizeof(nodename), "device/console/%d", save ? 1 : 2); fd = open_consfront(nodename); printk("fd(%d) = open_savefile\n", fd); return fd; } + +static int open_save(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode) +{ + return open_savefile(pathname, flags & O_WRONLY); +} #else int posix_openpt(int flags) { @@ -311,24 +318,59 @@ int open_savefile(const char *path, int save) } #endif -int open(const char *pathname, int flags, ...) +static int open_log(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode) { int fd; + /* Ugly, but fine. */ - if (!strncmp(pathname,LOG_PATH,strlen(LOG_PATH))) { - fd = alloc_fd(FTYPE_CONSOLE); - printk("open(%s) -> %d\n", pathname, fd); - return fd; + fd = alloc_fd(FTYPE_CONSOLE); + printk("open(%s%s) -> %d\n", mnt->path, pathname, fd); + return fd; +} + +static int open_mem(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode) +{ + int fd; + + fd = alloc_fd(FTYPE_MEM); + printk("open(%s%s) -> %d\n", mnt->path, pathname, fd); + return fd; +} + +static struct mount_point mount_points[] = { + { .path = "/var/log", .open = open_log, .dev = NULL }, + { .path = "/dev/mem", .open = open_mem, .dev = NULL }, +#ifdef CONFIG_CONSFRONT + { .path = "/dev/ptmx", .open = open_pt, .dev = NULL }, + { .path = "/var/lib/xen", .open = open_save, .dev = NULL }, +#endif +}; + +int open(const char *pathname, int flags, ...) +{ + unsigned int m, mlen; + struct mount_point *mnt; + mode_t mode = 0; + va_list ap; + + if ( flags & O_CREAT ) + { + va_start(ap, flags); + mode = va_arg(ap, mode_t); + va_end(ap); } - if (!strncmp(pathname, "/dev/mem", strlen("/dev/mem"))) { - fd = alloc_fd(FTYPE_MEM); - printk("open(/dev/mem) -> %d\n", fd); - return fd; + + for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) + { + mnt = mount_points + m; + mlen = strlen(mnt->path); + if ( !strncmp(pathname, mnt->path, mlen) && + (pathname[mlen] == '/' || pathname[mlen] == 0) ) + return mnt->open(mnt, pathname + mlen, flags, mode); } - if (!strncmp(pathname, "/dev/ptmx", strlen("/dev/ptmx"))) - return posix_openpt(flags); - if (!strncmp(pathname,SAVE_PATH,strlen(SAVE_PATH))) - return open_savefile(pathname, flags & O_WRONLY); + errno = EIO; return -1; } -- 2.35.3 From minios-devel-bounces@lists.xenproject.org Fri Feb 10 10:46:53 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 10 Feb 2023 10:46:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493258.763143 (Exim 4.92) (envelope-from ) id 1pQQvd-00073A-NR; Fri, 10 Feb 2023 10:46:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493258.763143; Fri, 10 Feb 2023 10:46:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQvd-00072t-KI; Fri, 10 Feb 2023 10:46:53 +0000 Received: by outflank-mailman (input) for mailman id 493258; Fri, 10 Feb 2023 10:46:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQvb-000617-RL for minios-devel@lists.xenproject.org; Fri, 10 Feb 2023 10:46:51 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 37f94573-a930-11ed-93b5-47a8fe42b414; Fri, 10 Feb 2023 11:46:48 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F1F095CA5F; Fri, 10 Feb 2023 10:46:47 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C403B1325E; Fri, 10 Feb 2023 10:46:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id B395Lpcg5mPlUwAAMHmgww (envelope-from ); Fri, 10 Feb 2023 10:46:47 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 37f94573-a930-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676026007; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r6yg48m3tvne8UEfBZnk+9j9B6sQe1QaY7lXxFABCRM=; b=Pg/wOl+X1wnAx5gv9QVCPC0Svx3QQQCb9FVnjkyyR0ckKiDByOeK9io6QiUwEU2tS+WTuZ jr0/+13du395NvWMczqy1XTIzTajelRXA3VJZmpKoJWyyQOYDXyuLwEKSb6FRNDbNi3K0h c4X9mMUISJcSo6IT1RKi1Tr0gEuQDjs= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH v2 3/7] Mini-OS: add support for runtime mounts Date: Fri, 10 Feb 2023 11:46:24 +0100 Message-Id: <20230210104628.14374-4-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230210104628.14374-1-jgross@suse.com> References: <20230210104628.14374-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the support to mount a device at runtime. The number of dynamic mounts is limited by a #define. For devices supporting multiple files struct file is modified to hold a pointer to file specific data in contrast to device specific data. Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault --- include/lib.h | 5 +++++ lib/sys.c | 50 +++++++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 54 insertions(+), 1 deletion(-) diff --git a/include/lib.h b/include/lib.h index 36d94ec4..fd8c36de 100644 --- a/include/lib.h +++ b/include/lib.h @@ -172,6 +172,7 @@ struct file { union { int fd; /* Any fd from an upper layer. */ void *dev; + void *filedata; }; }; @@ -194,6 +195,10 @@ struct mount_point { void *dev; }; +int mount(const char *path, void *dev, + int (*open)(struct mount_point *, const char *, int, mode_t)); +void umount(const char *path); + unsigned int alloc_file_type(const struct file_ops *ops); off_t lseek_default(struct file *file, off_t offset, int whence); diff --git a/lib/sys.c b/lib/sys.c index 2f33c937..dc8a8c69 100644 --- a/lib/sys.c +++ b/lib/sys.c @@ -339,7 +339,14 @@ static int open_mem(struct mount_point *mnt, const char *pathname, int flags, return fd; } -static struct mount_point mount_points[] = { +#ifdef CONFIG_CONSFRONT +#define STATIC_MNTS 4 +#else +#define STATIC_MNTS 2 +#endif +#define DYNAMIC_MNTS 8 + +static struct mount_point mount_points[STATIC_MNTS + DYNAMIC_MNTS] = { { .path = "/var/log", .open = open_log, .dev = NULL }, { .path = "/dev/mem", .open = open_mem, .dev = NULL }, #ifdef CONFIG_CONSFRONT @@ -365,6 +372,8 @@ int open(const char *pathname, int flags, ...) for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) { mnt = mount_points + m; + if ( !mnt->path ) + continue; mlen = strlen(mnt->path); if ( !strncmp(pathname, mnt->path, mlen) && (pathname[mlen] == '/' || pathname[mlen] == 0) ) @@ -375,6 +384,45 @@ int open(const char *pathname, int flags, ...) return -1; } +int mount(const char *path, void *dev, + int (*open)(struct mount_point *, const char *, int, mode_t)) +{ + unsigned int m; + struct mount_point *mnt; + + for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) + { + mnt = mount_points + m; + if ( !mnt->path ) + { + mnt->path = strdup(path); + mnt->open = open; + mnt->dev = dev; + return 0; + } + } + + errno = ENOSPC; + return -1; +} + +void umount(const char *path) +{ + unsigned int m; + struct mount_point *mnt; + + for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) + { + mnt = mount_points + m; + if ( mnt->path && !strcmp(mnt->path, path) ) + { + free((char *)mnt->path); + mnt->path = NULL; + return; + } + } +} + int isatty(int fd) { return files[fd].type == FTYPE_CONSOLE; -- 2.35.3 From minios-devel-bounces@lists.xenproject.org Fri Feb 10 10:46:59 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 10 Feb 2023 10:46:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493263.763153 (Exim 4.92) (envelope-from ) id 1pQQvj-0007RF-Df; Fri, 10 Feb 2023 10:46:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493263.763153; Fri, 10 Feb 2023 10:46:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQvj-0007Pp-8b; Fri, 10 Feb 2023 10:46:59 +0000 Received: by outflank-mailman (input) for mailman id 493263; Fri, 10 Feb 2023 10:46:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQvh-000617-PD for minios-devel@lists.xenproject.org; Fri, 10 Feb 2023 10:46:57 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3b473f65-a930-11ed-93b5-47a8fe42b414; Fri, 10 Feb 2023 11:46:53 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 875945CA5F; Fri, 10 Feb 2023 10:46:53 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5A2101325E; Fri, 10 Feb 2023 10:46:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id zWCwFJ0g5mPzUwAAMHmgww (envelope-from ); Fri, 10 Feb 2023 10:46:53 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 3b473f65-a930-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676026013; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LfzPuWES19Z6zkc6ddDA2+HHqNpphAyol7vuoCqTTog=; b=GIBT8TTNBayaUmMcymygthXHVyC152KeQDlcror7XNkR6fy91STK/zBi9jv06fw1TW0mVD NUZW4SFP7o63G6Moegu++0snEw5DKiTUwXXw20BJSTj6s7qyanIAE70qP7qj3jwvwBaMN3 FGk5rL7CQO1tvOLGFOlkAW7jPaBt9GY= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH v2 4/7] Mini-OS: add 9pfs frontend Date: Fri, 10 Feb 2023 11:46:25 +0100 Message-Id: <20230210104628.14374-5-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230210104628.14374-1-jgross@suse.com> References: <20230210104628.14374-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a frontend for the 9pfs PV device. For now add only the code needed to connect to the backend and the related disconnect functionality. The 9pfs protocol support will be added later. Due to its nature (ability to access files) the whole code is guarded by "#ifdef HAVE_LIBC". Signed-off-by: Juergen Gross --- V2: - add better error handling to version parsing (Samuel Thibault) --- 9pfront.c | 286 ++++++++++++++++++++++++++++++++++ Config.mk | 1 + Makefile | 1 + arch/x86/testbuild/all-no | 1 + arch/x86/testbuild/all-yes | 1 + arch/x86/testbuild/newxen-yes | 1 + include/9pfront.h | 7 + 7 files changed, 298 insertions(+) create mode 100644 9pfront.c create mode 100644 include/9pfront.h diff --git a/9pfront.c b/9pfront.c new file mode 100644 index 00000000..89ecb3a1 --- /dev/null +++ b/9pfront.c @@ -0,0 +1,286 @@ +/* + * Minimal 9pfs PV frontend for Mini-OS. + * Copyright (c) 2023 Juergen Gross, SUSE Software Solution GmbH + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#ifdef HAVE_LIBC +struct dev_9pfs { + int id; + char nodename[20]; + unsigned int dom; + char *backend; + + char *tag; + const char *mnt; + + struct xen_9pfs_data_intf *intf; + struct xen_9pfs_data data; + RING_IDX prod_pvt_out; + RING_IDX cons_pvt_in; + + grant_ref_t ring_ref; + evtchn_port_t evtchn; + unsigned int ring_order; + xenbus_event_queue events; +}; + +#define DEFAULT_9PFS_RING_ORDER 4 + +static unsigned int ftype_9pfs; + +static void intr_9pfs(evtchn_port_t port, struct pt_regs *regs, void *data) +{ +} + +static int open_9pfs(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode) +{ + errno = ENOSYS; + + return -1; +} + +static void free_9pfront(struct dev_9pfs *dev) +{ + unsigned int i; + + if ( dev->data.in && dev->intf ) + { + for ( i = 0; i < (1 << dev->ring_order); i++ ) + gnttab_end_access(dev->intf->ref[i]); + free_pages(dev->data.in, dev->ring_order); + } + unbind_evtchn(dev->evtchn); + gnttab_end_access(dev->ring_ref); + free_page(dev->intf); + free(dev->backend); + free(dev->tag); + free(dev); +} + +void *init_9pfront(unsigned int id, const char *mnt) +{ + struct dev_9pfs *dev; + char *msg; + char *reason = ""; + xenbus_transaction_t xbt; + int retry = 1; + char bepath[64] = { 0 }; + XenbusState state; + unsigned int i; + void *addr; + char *version; + char *v; + + printk("9pfsfront add %u, for mount at %s\n", id, mnt); + dev = malloc(sizeof(*dev)); + memset(dev, 0, sizeof(*dev)); + snprintf(dev->nodename, sizeof(dev->nodename), "device/9pfs/%u", id); + dev->id = id; + + msg = xenbus_read_unsigned(XBT_NIL, dev->nodename, "backend-id", &dev->dom); + if ( msg ) + goto err; + msg = xenbus_read_string(XBT_NIL, dev->nodename, "backend", &dev->backend); + if ( msg ) + goto err; + msg = xenbus_read_string(XBT_NIL, dev->nodename, "tag", &dev->tag); + if ( msg ) + goto err; + + snprintf(bepath, sizeof(bepath), "%s/state", dev->backend); + free(xenbus_watch_path_token(XBT_NIL, bepath, bepath, &dev->events)); + state = xenbus_read_integer(bepath); + while ( msg == NULL && state < XenbusStateInitWait ) + msg = xenbus_wait_for_state_change(bepath, &state, &dev->events); + if ( msg || state != XenbusStateInitWait ) + { + reason = "illegal backend state"; + goto err; + } + + msg = xenbus_read_unsigned(XBT_NIL, dev->backend, "max-ring-page-order", + &dev->ring_order); + if ( msg ) + goto err; + if ( dev->ring_order > DEFAULT_9PFS_RING_ORDER ) + dev->ring_order = DEFAULT_9PFS_RING_ORDER; + + msg = xenbus_read_string(XBT_NIL, dev->backend, "versions", &version); + if ( msg ) + goto err; + for ( v = version; *v; v++ ) + { + if ( strtoul(v, &v, 10) == 1 && (*v == ',' || *v == 0) ) + { + v = NULL; + break; + } + if ( *v != ',' && *v != 0 ) + { + reason = "backend published illegal version string"; + free(version); + goto err; + } + } + free(version); + if ( v ) + { + reason = "backend doesn't support version 1"; + goto err; + } + + dev->ring_ref = gnttab_alloc_and_grant((void **)&dev->intf); + memset(dev->intf, 0, PAGE_SIZE); + if ( evtchn_alloc_unbound(dev->dom, intr_9pfs, dev, &dev->evtchn) ) + { + reason = "no event channel"; + goto err; + } + dev->intf->ring_order = dev->ring_order; + dev->data.in = (void *)alloc_pages(dev->ring_order); + dev->data.out = dev->data.in + XEN_FLEX_RING_SIZE(dev->ring_order); + for ( i = 0; i < (1 << dev->ring_order); i++ ) + { + addr = dev->data.in + i * PAGE_SIZE; + dev->intf->ref[i] = gnttab_grant_access(dev->dom, virt_to_mfn(addr), 0); + } + + while ( retry ) + { + msg = xenbus_transaction_start(&xbt); + if ( msg ) + { + free(msg); + msg = NULL; + reason = "starting transaction"; + goto err; + } + + msg = xenbus_printf(xbt, dev->nodename, "version", "%u", 1); + if ( msg ) + goto err_tr; + msg = xenbus_printf(xbt, dev->nodename, "num-rings", "%u", 1); + if ( msg ) + goto err_tr; + msg = xenbus_printf(xbt, dev->nodename, "ring-ref0", "%u", + dev->ring_ref); + if ( msg ) + goto err_tr; + msg = xenbus_printf(xbt, dev->nodename, "event-channel-0", "%u", + dev->evtchn); + if ( msg ) + goto err_tr; + msg = xenbus_printf(xbt, dev->nodename, "state", "%u", + XenbusStateInitialised); + if ( msg ) + goto err_tr; + + free(xenbus_transaction_end(xbt, 0, &retry)); + } + + state = xenbus_read_integer(bepath); + while ( msg == NULL && state < XenbusStateConnected ) + msg = xenbus_wait_for_state_change(bepath, &state, &dev->events); + if ( msg || state != XenbusStateConnected ) + { + reason = "illegal backend state"; + goto err; + } + + msg = xenbus_printf(XBT_NIL, dev->nodename, "state", "%u", + XenbusStateConnected); + if ( msg ) + goto err; + + unmask_evtchn(dev->evtchn); + + dev->mnt = mnt; + if ( mount(dev->mnt, dev, open_9pfs) ) + { + reason = "mount failed"; + goto err; + } + + return dev; + + err_tr: + free(xenbus_transaction_end(xbt, 1, &retry)); + + err: + if ( bepath[0] ) + free(xenbus_unwatch_path_token(XBT_NIL, bepath, bepath)); + if ( msg ) + printk("9pfsfront add %u failed, error %s accessing Xenstore\n", + id, msg); + else + printk("9pfsfront add %u failed, %s\n", id, reason); + free_9pfront(dev); + free(msg); + return NULL; +} + +void shutdown_9pfront(void *dev) +{ + struct dev_9pfs *dev9p = dev; + char bepath[64]; + XenbusState state; + char *msg; + char *reason = ""; + + umount(dev9p->mnt); + snprintf(bepath, sizeof(bepath), "%s/state", dev9p->backend); + + msg = xenbus_printf(XBT_NIL, dev9p->nodename, "state", "%u", + XenbusStateClosing); + if ( msg ) + goto err; + + state = xenbus_read_integer(bepath); + while ( msg == NULL && state < XenbusStateClosing) + msg = xenbus_wait_for_state_change(bepath, &state, &dev9p->events); + if ( msg || state != XenbusStateClosing ) + { + reason = "illegal backend state"; + goto err; + } + + msg = xenbus_printf(XBT_NIL, dev9p->nodename, "state", "%u", + XenbusStateClosed); + if ( msg ) + goto err; + + free_9pfront(dev9p); + + return; + + err: + if ( msg ) + printk("9pfsfront shutdown %u failed, error %s accessing Xenstore\n", + dev9p->id, msg); + else + printk("9pfsfront shutdown %u failed, %s\n", dev9p->id, reason); + free(msg); +} + +static const struct file_ops ops_9pfs = { + .name = "9pfs", +}; + +__attribute__((constructor)) +static void initialize_9pfs(void) +{ + ftype_9pfs = alloc_file_type(&ops_9pfs); +} + +#endif /* HAVE_LIBC */ diff --git a/Config.mk b/Config.mk index 1a24b30e..677e93df 100644 --- a/Config.mk +++ b/Config.mk @@ -187,6 +187,7 @@ CONFIG-n += CONFIG_QEMU_XS_ARGS CONFIG-n += CONFIG_TEST CONFIG-n += CONFIG_PCIFRONT CONFIG-n += CONFIG_TPMFRONT +CONFIG-n += CONFIG_9PFRONT CONFIG-n += CONFIG_TPM_TIS CONFIG-n += CONFIG_TPMBACK CONFIG-n += CONFIG_BALLOON diff --git a/Makefile b/Makefile index 747c7c01..7ee181a2 100644 --- a/Makefile +++ b/Makefile @@ -39,6 +39,7 @@ SUBDIRS := lib src-$(CONFIG_BLKFRONT) += blkfront.c src-$(CONFIG_CONSFRONT) += consfront.c src-$(CONFIG_TPMFRONT) += tpmfront.c +src-$(CONFIG_9PFRONT) += 9pfront.c src-$(CONFIG_TPM_TIS) += tpm_tis.c src-$(CONFIG_TPMBACK) += tpmback.c src-y += console.c diff --git a/arch/x86/testbuild/all-no b/arch/x86/testbuild/all-no index f79a1012..5b3e99ed 100644 --- a/arch/x86/testbuild/all-no +++ b/arch/x86/testbuild/all-no @@ -12,6 +12,7 @@ CONFIG_NETFRONT = n CONFIG_FBFRONT = n CONFIG_KBDFRONT = n CONFIG_CONSFRONT = n +CONFIG_9PFRONT = n CONFIG_XENBUS = n CONFIG_LIBXS = n CONFIG_LWIP = n diff --git a/arch/x86/testbuild/all-yes b/arch/x86/testbuild/all-yes index faa3af32..8ae489a4 100644 --- a/arch/x86/testbuild/all-yes +++ b/arch/x86/testbuild/all-yes @@ -12,6 +12,7 @@ CONFIG_NETFRONT = y CONFIG_FBFRONT = y CONFIG_KBDFRONT = y CONFIG_CONSFRONT = y +CONFIG_9PFRONT = y CONFIG_XENBUS = y CONFIG_LIBXS = y CONFIG_BALLOON = y diff --git a/arch/x86/testbuild/newxen-yes b/arch/x86/testbuild/newxen-yes index dc83e670..ee27a328 100644 --- a/arch/x86/testbuild/newxen-yes +++ b/arch/x86/testbuild/newxen-yes @@ -12,6 +12,7 @@ CONFIG_NETFRONT = y CONFIG_FBFRONT = y CONFIG_KBDFRONT = y CONFIG_CONSFRONT = y +CONFIG_9PFRONT = y CONFIG_XENBUS = y CONFIG_LIBXS = y CONFIG_BALLOON = y diff --git a/include/9pfront.h b/include/9pfront.h new file mode 100644 index 00000000..722ec564 --- /dev/null +++ b/include/9pfront.h @@ -0,0 +1,7 @@ +#ifndef __9PFRONT_H__ +#define __9PFRONT_H__ + +void *init_9pfront(unsigned int id, const char *mnt); +void shutdown_9pfront(void *dev); + +#endif /* __9PFRONT_H__ */ -- 2.35.3 From minios-devel-bounces@lists.xenproject.org Fri Feb 10 10:47:04 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 10 Feb 2023 10:47:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493268.763163 (Exim 4.92) (envelope-from ) id 1pQQvo-0007wr-Gl; Fri, 10 Feb 2023 10:47:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493268.763163; Fri, 10 Feb 2023 10:47:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQvo-0007wk-Cr; Fri, 10 Feb 2023 10:47:04 +0000 Received: by outflank-mailman (input) for mailman id 493268; Fri, 10 Feb 2023 10:47:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQvm-000617-V3 for minios-devel@lists.xenproject.org; Fri, 10 Feb 2023 10:47:03 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3e9e5fb6-a930-11ed-93b5-47a8fe42b414; Fri, 10 Feb 2023 11:46:59 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 286413FEC5; Fri, 10 Feb 2023 10:46:59 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EC1231325E; Fri, 10 Feb 2023 10:46:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id t2tDOKIg5mMAVAAAMHmgww (envelope-from ); Fri, 10 Feb 2023 10:46:58 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 3e9e5fb6-a930-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676026019; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AjLtvshfjPJLxhGdXS+IgJVdKslWSTSlXSgC0tGAfD0=; b=NOT/uNDL/q3Nh9a1C32Rlo3B2Dyw3tSWtTow1koZyC/xfTeUU+zab4gzRWdQhPxW9MhA9h JfGEdoK2tm+/YaKjFmY6K14mBmlYXzsL0TURz4/IZFuIN9MwZKHFno9uQvLBOGAmFeIgi1 Ar1vr/wksJI1o4ekhjZl3Nyo8Kk0hYk= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH v2 5/7] Mini-OS: add 9pfs transport layer Date: Fri, 10 Feb 2023 11:46:26 +0100 Message-Id: <20230210104628.14374-6-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230210104628.14374-1-jgross@suse.com> References: <20230210104628.14374-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the transport layer of 9pfs. This is basically the infrastructure to send requests to the backend and to receive the related answers via the rings. As a first example add the version and attach requests of the 9pfs protocol when mounting a new 9pfs device. For the version use the "9P2000.u" variant, as it is the smallest subset supported by the qemu based backend. Signed-off-by: Juergen Gross --- V2: - add more comments (Samuel Thibault) - log short copy (Samuel Thibault) - send event after consuming response (Samuel Thibault) - reaturn EAGAIN in case no free request could be got (Samuel Thibault) --- 9pfront.c | 478 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 478 insertions(+) diff --git a/9pfront.c b/9pfront.c index 89ecb3a1..0b8d5461 100644 --- a/9pfront.c +++ b/9pfront.c @@ -7,6 +7,8 @@ #include #include #include +#include +#include #include #include #include @@ -14,6 +16,9 @@ #include #ifdef HAVE_LIBC + +#define N_REQS 64 + struct dev_9pfs { int id; char nodename[20]; @@ -22,6 +27,7 @@ struct dev_9pfs { char *tag; const char *mnt; + unsigned int msize_max; struct xen_9pfs_data_intf *intf; struct xen_9pfs_data data; @@ -32,14 +38,470 @@ struct dev_9pfs { evtchn_port_t evtchn; unsigned int ring_order; xenbus_event_queue events; + + unsigned int free_reqs; + struct req { + unsigned int id; + unsigned int next_free; /* N_REQS == end of list. */ + unsigned int cmd; + int result; + bool inflight; + unsigned char *data; /* Returned data. */ + } req[N_REQS]; + + struct wait_queue_head waitq; + struct semaphore ring_out_sem; + struct semaphore ring_in_sem; }; #define DEFAULT_9PFS_RING_ORDER 4 +#define P9_CMD_VERSION 100 +#define P9_CMD_ATTACH 104 +#define P9_CMD_ERROR 107 + +#define P9_QID_SIZE 13 + +struct p9_header { + uint32_t size; + uint8_t cmd; + uint16_t tag; +} __attribute__((packed)); + +#define P9_VERSION "9P2000.u" +#define P9_ROOT_FID ~0 + static unsigned int ftype_9pfs; +static struct req *get_free_req(struct dev_9pfs *dev) +{ + struct req *req; + + if ( dev->free_reqs == N_REQS ) + return NULL; + + req = dev->req + dev->free_reqs; + dev->free_reqs = req->next_free; + + return req; +} + +static void put_free_req(struct dev_9pfs *dev, struct req *req) +{ + req->next_free = dev->free_reqs; + req->inflight = false; + req->data = NULL; + dev->free_reqs = req->id; +} + +static unsigned int ring_out_free(struct dev_9pfs *dev) +{ + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); + unsigned int queued; + + queued = xen_9pfs_queued(dev->prod_pvt_out, dev->intf->out_cons, ring_size); + rmb(); + + return ring_size - queued; +} + +static unsigned int ring_in_data(struct dev_9pfs *dev) +{ + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); + unsigned int queued; + + queued = xen_9pfs_queued(dev->intf->in_prod, dev->cons_pvt_in, ring_size); + rmb(); + + return queued; +} + +static void copy_to_ring(struct dev_9pfs *dev, void *data, unsigned int len) +{ + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); + RING_IDX prod = xen_9pfs_mask(dev->prod_pvt_out, ring_size); + RING_IDX cons = xen_9pfs_mask(dev->intf->out_cons, ring_size); + + xen_9pfs_write_packet(dev->data.out, data, len, &prod, cons, ring_size); + dev->prod_pvt_out += len; +} + +static void copy_from_ring(struct dev_9pfs *dev, void *data, unsigned int len) +{ + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); + RING_IDX prod = xen_9pfs_mask(dev->intf->in_prod, ring_size); + RING_IDX cons = xen_9pfs_mask(dev->cons_pvt_in, ring_size); + + xen_9pfs_read_packet(data, dev->data.in, len, prod, &cons, ring_size); + dev->cons_pvt_in += len; +} + +/* + * send_9p() and rcv_9p() are using a special format string for specifying + * the kind of data sent/expected. Each data item is represented by a single + * character: + * U: 4 byte unsigned integer (uint32_t) + * S: String (2 byte length + characters) + * in the rcv_9p() case the data for string is allocated (length omitted, + * string terminated by a NUL character) + * Q: A 13 byte "qid", consisting of 1 byte file type, 4 byte file version + * and 8 bytes unique file id. Only valid for receiving. + */ +static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) +{ + struct p9_header hdr; + va_list ap, aq; + const char *f; + uint32_t intval; + uint16_t len; + char *strval; + + hdr.size = sizeof(hdr); + hdr.cmd = req->cmd; + hdr.tag = req->id; + + va_start(ap, fmt); + + va_copy(aq, ap); + for ( f = fmt; *f; f++ ) + { + switch ( *f ) + { + case 'U': + hdr.size += 4; + intval = va_arg(aq, unsigned int); + break; + case 'S': + hdr.size += 2; + strval = va_arg(aq, char *); + hdr.size += strlen(strval); + break; + default: + printk("send_9p: unknown format character %c\n", *f); + break; + } + } + va_end(aq); + + /* + * Waiting for free space must be done in the critical section! + * Otherwise we might get overtaken by other short requests. + */ + down(&dev->ring_out_sem); + + wait_event(dev->waitq, ring_out_free(dev) >= hdr.size); + + copy_to_ring(dev, &hdr, sizeof(hdr)); + for ( f = fmt; *f; f++ ) + { + switch ( *f ) + { + case 'U': + intval = va_arg(ap, unsigned int); + copy_to_ring(dev, &intval, sizeof(intval)); + break; + case 'S': + strval = va_arg(ap, char *); + len = strlen(strval); + copy_to_ring(dev, &len, sizeof(len)); + copy_to_ring(dev, strval, len); + break; + } + } + + wmb(); /* Data on ring must be seen before updating index. */ + dev->intf->out_prod = dev->prod_pvt_out; + req->inflight = true; + + up(&dev->ring_out_sem); + + va_end(ap); + + notify_remote_via_evtchn(dev->evtchn); +} + +/* + * Using an opportunistic approach for receiving data: in case multiple + * requests are outstanding (which is very unlikely), we nevertheless need + * to consume all data available until we reach the desired request. + * For requests other than the one we are waiting for, we link the complete + * data to the request via an intermediate buffer. For our own request we can + * omit that buffer and directly fill the caller provided variables. + * + * Helper functions: + * + * copy_bufs(): copy raw data into a target buffer. There can be 2 source + * buffers involved (in case the copy is done from the ring and it is across + * the ring end). The buffer pointers and lengths are updated according to + * the number of bytes copied. + * + * rcv_9p_copy(): copy the data (without the generic header) of a 9p response + * to the specified variables using the specified format string for + * deciphering the single item types. The decision whether to copy from the + * ring or an allocated buffer is done via the "hdr" parameter, which is + * NULL in the buffer case (in that case the header is located at the start + * of the buffer). + * + * rcv_9p_one(): Checks for an already filled buffer with the correct tag in + * it. If none is found, consumes one response. It checks the tag of the + * response in order to decide whether to allocate a buffer for putting the + * data into, or to fill the user supplied variables. Return true, if the + * tag did match. Waits if no data is ready to be consumed. + */ +static void copy_bufs(unsigned char **buf1, unsigned char **buf2, + unsigned int *len1, unsigned int *len2, + void *target, unsigned int len) +{ + if ( len <= *len1 ) + { + memcpy(target, *buf1, len); + *buf1 += len; + *len1 -= len; + } + else + { + memcpy(target, *buf1, *len1); + target = (char *)target + *len1; + len -= *len1; + *buf1 = *buf2; + *len1 = *len2; + *buf2 = NULL; + *len2 = 0; + if ( len > *len1 ) + { + printk("9pfs: short copy (dropping %u bytes)\n", len - *len1); + len = *len1; + } + memcpy(target, *buf1, *len1); + } +} + +static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, + struct p9_header *hdr, const char *fmt, va_list ap) +{ + struct p9_header *h = hdr ? hdr : (void *)req->data; + RING_IDX cons = dev->cons_pvt_in + h->size - sizeof(*h); + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); + unsigned char *buf1, *buf2; + unsigned int len1, len2; + const char *f; + char *str; + uint16_t len; + uint32_t err; + uint32_t *val; + char **strval; + uint8_t *qval; + + if ( hdr ) + { + buf1 = xen_9pfs_get_ring_ptr(dev->data.in, dev->cons_pvt_in, ring_size); + buf2 = xen_9pfs_get_ring_ptr(dev->data.in, 0, ring_size); + len1 = ring_size - xen_9pfs_mask(dev->cons_pvt_in, ring_size); + if ( len1 > h->size - sizeof(*h) ) + len1 = h->size - sizeof(*h); + len2 = h->size - sizeof(*h) - len1; + } + else + { + buf1 = req->data + sizeof(*h); + buf2 = NULL; + len1 = h->size - sizeof(*h); + len2 = 0; + } + + if ( h->cmd == P9_CMD_ERROR ) + { + copy_bufs(&buf1, &buf2, &len1, &len2, &len, sizeof(len)); + str = malloc(len + 1); + copy_bufs(&buf1, &buf2, &len1, &len2, str, len); + str[len] = 0; + printk("9pfs: request %u resulted in \"%s\"\n", req->cmd, str); + free(str); + err = EIO; + copy_bufs(&buf1, &buf2, &len1, &len2, &err, sizeof(err)); + req->result = err; + + if ( hdr ) + dev->cons_pvt_in = cons; + + return; + } + + if ( h->cmd != req->cmd + 1 ) + { + req->result = EDOM; + printk("9pfs: illegal response: wrong return type (%u instead of %u)\n", + h->cmd, req->cmd + 1); + + if ( hdr ) + dev->cons_pvt_in = cons; + + return; + } + + req->result = 0; + + for ( f = fmt; *f; f++ ) + { + switch ( *f ) + { + case 'U': + val = va_arg(ap, uint32_t *); + copy_bufs(&buf1, &buf2, &len1, &len2, val, sizeof(*val)); + break; + case 'S': + strval = va_arg(ap, char **); + copy_bufs(&buf1, &buf2, &len1, &len2, &len, sizeof(len)); + *strval = malloc(len + 1); + copy_bufs(&buf1, &buf2, &len1, &len2, *strval, len); + (*strval)[len] = 0; + break; + case 'Q': + qval = va_arg(ap, uint8_t *); + copy_bufs(&buf1, &buf2, &len1, &len2, qval, P9_QID_SIZE); + break; + default: + printk("rcv_9p: unknown format character %c\n", *f); + break; + } + } + + if ( hdr ) + dev->cons_pvt_in = cons; +} + +static bool rcv_9p_one(struct dev_9pfs *dev, struct req *req, const char *fmt, + va_list ap) +{ + struct p9_header hdr; + struct req *tmp; + + if ( req->data ) + { + rcv_9p_copy(dev, req, NULL, fmt, ap); + free(req->data); + req->data = NULL; + + return true; + } + + wait_event(dev->waitq, ring_in_data(dev) >= sizeof(hdr)); + + copy_from_ring(dev, &hdr, sizeof(hdr)); + + wait_event(dev->waitq, ring_in_data(dev) >= hdr.size - sizeof(hdr)); + + tmp = dev->req + hdr.tag; + if ( hdr.tag >= N_REQS || !tmp->inflight ) + { + printk("9pfs: illegal response: %s\n", + hdr.tag >= N_REQS ? "tag out of bounds" : "request not pending"); + dev->cons_pvt_in += hdr.size - sizeof(hdr); + + return false; + } + + tmp->inflight = false; + + if ( tmp != req ) + { + tmp->data = malloc(hdr.size); + memcpy(tmp->data, &hdr, sizeof(hdr)); + copy_from_ring(dev, tmp->data + sizeof(hdr), hdr.size - sizeof(hdr)); + + return false; + } + + rcv_9p_copy(dev, req, &hdr, fmt, ap); + + return true; +} + +static void rcv_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) +{ + va_list ap; + + va_start(ap, fmt); + + down(&dev->ring_in_sem); + + while ( !rcv_9p_one(dev, req, fmt, ap) ); + + rmb(); /* Read all data before updating ring index. */ + dev->intf->in_cons = dev->cons_pvt_in; + + notify_remote_via_evtchn(dev->evtchn); + + up(&dev->ring_in_sem); + + va_end(ap); +} + +static int p9_version(struct dev_9pfs *dev) +{ + unsigned int msize = XEN_FLEX_RING_SIZE(dev->ring_order) / 2; + struct req *req = get_free_req(dev); + char *verret; + int ret; + + if ( !req ) + return EAGAIN; + + req->cmd = P9_CMD_VERSION; + send_9p(dev, req, "US", msize, P9_VERSION); + rcv_9p(dev, req, "US", &dev->msize_max, &verret); + ret = req->result; + + put_free_req(dev, req); + + if ( ret ) + return ret; + + if ( strcmp(verret, P9_VERSION) ) + ret = ENOMSG; + free(verret); + + return ret; +} + +static int p9_attach(struct dev_9pfs *dev) +{ + uint32_t fid = P9_ROOT_FID; + uint32_t afid = 0; + uint32_t uid = 0; + uint8_t qid[P9_QID_SIZE]; + struct req *req = get_free_req(dev); + int ret; + + if ( !req ) + return EAGAIN; + + req->cmd = P9_CMD_ATTACH; + send_9p(dev, req, "UUSSU", fid, afid, "root", "root", uid); + rcv_9p(dev, req, "Q", qid); + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +static int connect_9pfs(struct dev_9pfs *dev) +{ + int ret; + + ret = p9_version(dev); + if ( ret ) + return ret; + + return p9_attach(dev); +} + static void intr_9pfs(evtchn_port_t port, struct pt_regs *regs, void *data) { + struct dev_9pfs *dev = data; + + wake_up(&dev->waitq); } static int open_9pfs(struct mount_point *mnt, const char *pathname, int flags, @@ -87,6 +549,16 @@ void *init_9pfront(unsigned int id, const char *mnt) memset(dev, 0, sizeof(*dev)); snprintf(dev->nodename, sizeof(dev->nodename), "device/9pfs/%u", id); dev->id = id; + init_waitqueue_head(&dev->waitq); + init_SEMAPHORE(&dev->ring_out_sem, 1); + init_SEMAPHORE(&dev->ring_in_sem, 1); + + for ( i = 0; i < N_REQS; i++ ) + { + dev->req[i].id = i; + dev->req[i].next_free = i + 1; + } + dev->free_reqs = 0; msg = xenbus_read_unsigned(XBT_NIL, dev->nodename, "backend-id", &dev->dom); if ( msg ) @@ -205,6 +677,12 @@ void *init_9pfront(unsigned int id, const char *mnt) unmask_evtchn(dev->evtchn); + if ( connect_9pfs(dev) ) + { + reason = "9pfs connect failed"; + goto err; + } + dev->mnt = mnt; if ( mount(dev->mnt, dev, open_9pfs) ) { -- 2.35.3 From minios-devel-bounces@lists.xenproject.org Fri Feb 10 10:47:13 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 10 Feb 2023 10:47:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493276.763178 (Exim 4.92) (envelope-from ) id 1pQQvx-0000Ft-Qu; Fri, 10 Feb 2023 10:47:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493276.763178; Fri, 10 Feb 2023 10:47:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQvx-0000Fm-My; Fri, 10 Feb 2023 10:47:13 +0000 Received: by outflank-mailman (input) for mailman id 493276; Fri, 10 Feb 2023 10:47:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQvw-0005jA-1W for minios-devel@lists.xenproject.org; Fri, 10 Feb 2023 10:47:12 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 45732faa-a930-11ed-933c-83870f6b2ba8; Fri, 10 Feb 2023 11:47:10 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9B2403FEC6; Fri, 10 Feb 2023 10:47:10 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6202C1325E; Fri, 10 Feb 2023 10:47:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ApZvFq4g5mMjVAAAMHmgww (envelope-from ); Fri, 10 Feb 2023 10:47:10 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 45732faa-a930-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676026030; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eQI5EY4iGPACMuqIgP0kKRTaNVN1WVxx1P8uV/lIB7o=; b=oV9d+cW6hqWzg0jCv6JPRO0kUaBN5Zgsf8SQZg5LpJMKDYArbtsjuJ0TJpO2HQCgPOgkcV ywousDOOm1JjkmUDLWTFlFyU7YTy38rQanmoDmjXH67uJEImxpQI7+FJgkG7yE9rXQ4gsz e1RRnbRCO6el+4skulPXuq2mZ0oSWXU= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH v2 7/7] Mini-OS: add read and write support to 9pfsfront Date: Fri, 10 Feb 2023 11:46:28 +0100 Message-Id: <20230210104628.14374-8-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230210104628.14374-1-jgross@suse.com> References: <20230210104628.14374-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add support to read from and write to a file handled by 9pfsfront. Signed-off-by: Juergen Gross --- V2: - add check for max message size - return EAGAIN in case no free request got (Samuel Thibault) - loop until all data read/written (Samuel Thibault) --- 9pfront.c | 211 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 211 insertions(+) diff --git a/9pfront.c b/9pfront.c index b4c54535..c606c437 100644 --- a/9pfront.c +++ b/9pfront.c @@ -72,7 +72,10 @@ struct file_9pfs { #define P9_CMD_WALK 110 #define P9_CMD_OPEN 112 #define P9_CMD_CREATE 114 +#define P9_CMD_READ 116 +#define P9_CMD_WRITE 118 #define P9_CMD_CLUNK 120 +#define P9_CMD_STAT 124 /* P9 protocol open flags. */ #define P9_OREAD 0 /* read */ @@ -88,11 +91,39 @@ struct p9_header { uint16_t tag; } __attribute__((packed)); +struct p9_stat { + uint16_t size; + uint16_t type; + uint32_t dev; + uint8_t qid[13]; + uint32_t mode; + uint32_t atime; + uint32_t mtime; + uint64_t length; + char *name; + char *uid; + char *gid; + char *muid; + char *extension; + uint32_t n_uid; + uint32_t n_gid; + uint32_t n_muid; +}; + #define P9_VERSION "9P2000.u" #define P9_ROOT_FID 0 static unsigned int ftype_9pfs; +static void free_stat(struct p9_stat *stat) +{ + free(stat->name); + free(stat->uid); + free(stat->gid); + free(stat->muid); + free(stat->extension); +} + static unsigned int get_fid(struct dev_9pfs *dev) { unsigned int fid; @@ -181,9 +212,12 @@ static void copy_from_ring(struct dev_9pfs *dev, void *data, unsigned int len) * Only valid for sending. * u: 2 byte unsigned integer (uint16_t) * U: 4 byte unsigned integer (uint32_t) + * L: 8 byte unsigned integer (uint64_t) * S: String (2 byte length + characters) * in the rcv_9p() case the data for string is allocated (length omitted, * string terminated by a NUL character) + * D: Binary data (4 byte length + bytes of data), requires a length + * and a buffer pointer parameter. * Q: A 13 byte "qid", consisting of 1 byte file type, 4 byte file version * and 8 bytes unique file id. Only valid for receiving. */ @@ -192,10 +226,12 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) struct p9_header hdr; va_list ap, aq; const char *f; + uint64_t longval; uint32_t intval; uint16_t shortval; uint16_t len; uint8_t byte; + uint8_t *data; char *strval; hdr.size = sizeof(hdr); @@ -221,11 +257,21 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) hdr.size += 4; intval = va_arg(aq, unsigned int); break; + case 'L': + hdr.size += 8; + longval = va_arg(aq, uint64_t); + break; case 'S': hdr.size += 2; strval = va_arg(aq, char *); hdr.size += strlen(strval); break; + case 'D': + hdr.size += 4; + intval = va_arg(aq, unsigned int); + hdr.size += intval; + data = va_arg(aq, uint8_t *); + break; default: printk("send_9p: unknown format character %c\n", *f); break; @@ -258,12 +304,22 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) intval = va_arg(ap, unsigned int); copy_to_ring(dev, &intval, sizeof(intval)); break; + case 'L': + longval = va_arg(ap, uint64_t); + copy_to_ring(dev, &longval, sizeof(longval)); + break; case 'S': strval = va_arg(ap, char *); len = strlen(strval); copy_to_ring(dev, &len, sizeof(len)); copy_to_ring(dev, strval, len); break; + case 'D': + intval = va_arg(ap, unsigned int); + copy_to_ring(dev, &intval, sizeof(intval)); + data = va_arg(ap, uint8_t *); + copy_to_ring(dev, data, intval); + break; } } @@ -348,6 +404,8 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, uint32_t err; uint16_t *shortval; uint32_t *val; + uint64_t *longval; + uint8_t *data; char **strval; uint8_t *qval; @@ -412,6 +470,10 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, val = va_arg(ap, uint32_t *); copy_bufs(&buf1, &buf2, &len1, &len2, val, sizeof(*val)); break; + case 'L': + longval = va_arg(ap, uint64_t *); + copy_bufs(&buf1, &buf2, &len1, &len2, longval, sizeof(*longval)); + break; case 'S': strval = va_arg(ap, char **); copy_bufs(&buf1, &buf2, &len1, &len2, &len, sizeof(len)); @@ -419,6 +481,12 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, copy_bufs(&buf1, &buf2, &len1, &len2, *strval, len); (*strval)[len] = 0; break; + case 'D': + val = va_arg(ap, uint32_t *); + data = va_arg(ap, uint8_t *); + copy_bufs(&buf1, &buf2, &len1, &len2, val, sizeof(*val)); + copy_bufs(&buf1, &buf2, &len1, &len2, data, *val); + break; case 'Q': qval = va_arg(ap, uint8_t *); copy_bufs(&buf1, &buf2, &len1, &len2, qval, P9_QID_SIZE); @@ -640,6 +708,110 @@ static int p9_create(struct dev_9pfs *dev, uint32_t fid, char *path, return ret; } +static int p9_stat(struct dev_9pfs *dev, uint32_t fid, struct p9_stat *stat) +{ + struct req *req = get_free_req(dev); + int ret; + + if ( !req ) + return EAGAIN; + + memset(stat, 0, sizeof(*stat)); + req->cmd = P9_CMD_STAT; + send_9p(dev, req, "U", fid); + rcv_9p(dev, req, "uuUQUUULSSSSSUUU", &stat->size, &stat->type, &stat->dev, + stat->qid, &stat->mode, &stat->atime, &stat->mtime, &stat->length, + &stat->name, &stat->uid, &stat->gid, &stat->muid, &stat->extension, + &stat->n_uid, &stat->n_gid, &stat->n_muid); + + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +static int p9_read(struct dev_9pfs *dev, uint32_t fid, uint64_t offset, + uint8_t *data, uint32_t len) +{ + struct req *req = get_free_req(dev); + int ret = 0; + uint32_t count; + + if ( !req ) + { + errno = EAGAIN; + return -1; + } + req->cmd = P9_CMD_READ; + + while ( len ) + { + count = len; + if ( count > dev->msize_max - 24 ) + count = dev->msize_max - 24; + + send_9p(dev, req, "ULU", fid, offset, count); + rcv_9p(dev, req, "D", &count, data); + + if ( !count ) + break; + if ( req->result ) + { + ret = -1; + errno = EIO; + break; + } + ret += count; + offset += count; + data += count; + len -= count; + } + + put_free_req(dev, req); + + return ret; +} + +static int p9_write(struct dev_9pfs *dev, uint32_t fid, uint64_t offset, + const uint8_t *data, uint32_t len) +{ + struct req *req = get_free_req(dev); + int ret = 0; + uint32_t count; + + if ( !req ) + { + errno = EAGAIN; + return -1; + } + req->cmd = P9_CMD_WRITE; + + while ( len ) + { + count = len; + if ( count > dev->msize_max - 24 ) + count = dev->msize_max - 24; + + send_9p(dev, req, "ULD", fid, offset, count, data); + rcv_9p(dev, req, "U", &count); + if ( req->result ) + { + ret = -1; + errno = EIO; + break; + } + ret += count; + offset += count; + data += count; + len -= count; + } + + put_free_req(dev, req); + + return ret; +} + /* * Walk from root levels with the levels listed in <*paths> as a * sequence of names. Returns the number of steps not having been able to @@ -727,6 +899,43 @@ static void intr_9pfs(evtchn_port_t port, struct pt_regs *regs, void *data) wake_up(&dev->waitq); } +static int read_9pfs(struct file *file, void *buf, size_t nbytes) +{ + struct file_9pfs *f9pfs = file->filedata; + int ret; + + ret = p9_read(f9pfs->dev, f9pfs->fid, file->offset, buf, nbytes); + if ( ret >= 0 ) + file->offset += ret; + + return ret; +} + +static int write_9pfs(struct file *file, const void *buf, size_t nbytes) +{ + struct file_9pfs *f9pfs = file->filedata; + struct p9_stat stat; + int ret; + + if ( f9pfs->append ) + { + ret = p9_stat(f9pfs->dev, f9pfs->fid, &stat); + free_stat(&stat); + if ( ret ) + { + errno = EIO; + return -1; + } + file->offset = stat.length; + } + + ret = p9_write(f9pfs->dev, f9pfs->fid, file->offset, buf, nbytes); + if ( ret >= 0 ) + file->offset += ret; + + return ret; +} + static int close_9pfs(struct file *file) { struct file_9pfs *f9pfs = file->filedata; @@ -1068,6 +1277,8 @@ void shutdown_9pfront(void *dev) static const struct file_ops ops_9pfs = { .name = "9pfs", + .read = read_9pfs, + .write = write_9pfs, .close = close_9pfs, }; -- 2.35.3 From minios-devel-bounces@lists.xenproject.org Fri Feb 10 10:55:16 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 10 Feb 2023 10:55:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493300.763198 (Exim 4.92) (envelope-from ) id 1pQR3j-0002p6-3s; Fri, 10 Feb 2023 10:55:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493300.763198; Fri, 10 Feb 2023 10:55:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQR3i-0002o5-UT; Fri, 10 Feb 2023 10:55:14 +0000 Received: by outflank-mailman (input) for mailman id 493300; Fri, 10 Feb 2023 10:55:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQvs-000617-JB for minios-devel@lists.xenproject.org; Fri, 10 Feb 2023 10:47:08 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4205029c-a930-11ed-93b5-47a8fe42b414; Fri, 10 Feb 2023 11:47:05 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D5DC85CA5F; Fri, 10 Feb 2023 10:47:04 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A94551325E; Fri, 10 Feb 2023 10:47:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id hKAUKKgg5mMOVAAAMHmgww (envelope-from ); Fri, 10 Feb 2023 10:47:04 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 4205029c-a930-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676026024; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yGjQysJi2clZT+3RgGQtfxmXBb6C9V7YM0oN6qZktqE=; b=DN7mFMD2WhwPI+vBEQysLSoQpzspVI+X7+tFvlT64t5SwokXtsCOVozaggSUNqFJohmiWa GPaIB7A+v1JqrAGshcJS5d8/taM0oth79rDulBOGh1vNWhpYdgvgQ0Ek28D3UskYv5fLEg Li1ljbnDQ5RnOI5M/YHTrljgjK10JR0= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH v2 6/7] Mini-OS: add open and close handling to the 9pfs frontend Date: Fri, 10 Feb 2023 11:46:27 +0100 Message-Id: <20230210104628.14374-7-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230210104628.14374-1-jgross@suse.com> References: <20230210104628.14374-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the open() and close() support to the 9pfs frontend. This requires to split the path name and to walk to the desired directory level. Signed-off-by: Juergen Gross --- V2: - check path to be canonical - avoid short read when walking the path - fix get_fid() (Samuel Thibault) - return EAGAIN if no free request got (Samuel Thibault) --- 9pfront.c | 320 +++++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 318 insertions(+), 2 deletions(-) diff --git a/9pfront.c b/9pfront.c index 0b8d5461..b4c54535 100644 --- a/9pfront.c +++ b/9pfront.c @@ -6,6 +6,7 @@ #include #include #include +#include #include #include #include @@ -52,13 +53,32 @@ struct dev_9pfs { struct wait_queue_head waitq; struct semaphore ring_out_sem; struct semaphore ring_in_sem; + + unsigned long long fid_mask; /* Bit mask for free fids. */ +}; + +struct file_9pfs { + uint32_t fid; + struct dev_9pfs *dev; + bool append; }; #define DEFAULT_9PFS_RING_ORDER 4 +/* P9 protocol commands (response is either cmd+1 or P9_CMD_ERROR). */ #define P9_CMD_VERSION 100 #define P9_CMD_ATTACH 104 #define P9_CMD_ERROR 107 +#define P9_CMD_WALK 110 +#define P9_CMD_OPEN 112 +#define P9_CMD_CREATE 114 +#define P9_CMD_CLUNK 120 + +/* P9 protocol open flags. */ +#define P9_OREAD 0 /* read */ +#define P9_OWRITE 1 /* write */ +#define P9_ORDWR 2 /* read and write */ +#define P9_OTRUNC 16 /* or'ed in, truncate file first */ #define P9_QID_SIZE 13 @@ -69,10 +89,27 @@ struct p9_header { } __attribute__((packed)); #define P9_VERSION "9P2000.u" -#define P9_ROOT_FID ~0 +#define P9_ROOT_FID 0 static unsigned int ftype_9pfs; +static unsigned int get_fid(struct dev_9pfs *dev) +{ + unsigned int fid; + + fid = ffs(dev->fid_mask); + if ( fid ) + dev->fid_mask &= ~(1ULL << (fid - 1)); + + return fid; +} + +static void put_fid(struct dev_9pfs *dev, unsigned int fid) +{ + if ( fid ) + dev->fid_mask |= 1ULL << (fid - 1); +} + static struct req *get_free_req(struct dev_9pfs *dev) { struct req *req; @@ -140,6 +177,9 @@ static void copy_from_ring(struct dev_9pfs *dev, void *data, unsigned int len) * send_9p() and rcv_9p() are using a special format string for specifying * the kind of data sent/expected. Each data item is represented by a single * character: + * b: 1 byte unsigned integer (uint8_t) + * Only valid for sending. + * u: 2 byte unsigned integer (uint16_t) * U: 4 byte unsigned integer (uint32_t) * S: String (2 byte length + characters) * in the rcv_9p() case the data for string is allocated (length omitted, @@ -153,7 +193,9 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) va_list ap, aq; const char *f; uint32_t intval; + uint16_t shortval; uint16_t len; + uint8_t byte; char *strval; hdr.size = sizeof(hdr); @@ -167,6 +209,14 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) { switch ( *f ) { + case 'b': + hdr.size += 1; + byte = va_arg(aq, unsigned int); + break; + case 'u': + hdr.size += 2; + shortval = va_arg(aq, unsigned int); + break; case 'U': hdr.size += 4; intval = va_arg(aq, unsigned int); @@ -196,6 +246,14 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) { switch ( *f ) { + case 'b': + byte = va_arg(ap, unsigned int); + copy_to_ring(dev, &byte, sizeof(byte)); + break; + case 'u': + shortval = va_arg(ap, unsigned int); + copy_to_ring(dev, &shortval, sizeof(shortval)); + break; case 'U': intval = va_arg(ap, unsigned int); copy_to_ring(dev, &intval, sizeof(intval)); @@ -288,6 +346,7 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, char *str; uint16_t len; uint32_t err; + uint16_t *shortval; uint32_t *val; char **strval; uint8_t *qval; @@ -345,6 +404,10 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, { switch ( *f ) { + case 'u': + shortval = va_arg(ap, uint16_t *); + copy_bufs(&buf1, &buf2, &len1, &len2, shortval, sizeof(*shortval)); + break; case 'U': val = va_arg(ap, uint32_t *); copy_bufs(&buf1, &buf2, &len1, &len2, val, sizeof(*val)); @@ -486,6 +549,166 @@ static int p9_attach(struct dev_9pfs *dev) return ret; } +static int p9_clunk(struct dev_9pfs *dev, uint32_t fid) +{ + struct req *req = get_free_req(dev); + int ret; + + if ( !req ) + return EAGAIN; + + req->cmd = P9_CMD_CLUNK; + send_9p(dev, req, "U", fid); + rcv_9p(dev, req, ""); + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +static int p9_walk(struct dev_9pfs *dev, uint32_t fid, uint32_t newfid, + char *name) +{ + struct req *req = get_free_req(dev); + int ret; + uint16_t nqid; + uint8_t qid[P9_QID_SIZE]; + + if ( !req ) + return EAGAIN; + + req->cmd = P9_CMD_WALK; + if ( name[0] ) + { + send_9p(dev, req, "UUuS", fid, newfid, 1, name); + rcv_9p(dev, req, "uQ", &nqid, qid); + } + else + { + send_9p(dev, req, "UUu", fid, newfid, 0); + rcv_9p(dev, req, "u", &nqid); + } + + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +static int p9_open(struct dev_9pfs *dev, uint32_t fid, uint8_t omode) +{ + struct req *req = get_free_req(dev); + int ret; + uint8_t qid[P9_QID_SIZE]; + uint32_t iounit; + + if ( !req ) + return EAGAIN; + + req->cmd = P9_CMD_OPEN; + send_9p(dev, req, "Ub", fid, omode); + rcv_9p(dev, req, "QU", qid, &iounit); + + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +static int p9_create(struct dev_9pfs *dev, uint32_t fid, char *path, + uint32_t mode, uint8_t omode) +{ + struct req *req = get_free_req(dev); + int ret; + uint8_t qid[P9_QID_SIZE]; + uint32_t iounit; + + if ( !req ) + return EAGAIN; + + req->cmd = P9_CMD_CREATE; + send_9p(dev, req, "USUbS", fid, path, mode, omode, ""); + rcv_9p(dev, req, "QU", qid, &iounit); + + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +/* + * Walk from root levels with the levels listed in <*paths> as a + * sequence of names. Returns the number of steps not having been able to + * walk, with <*paths> pointing at the name of the failing walk step. + * will be associated with the last successful walk step. Note that + * the first step should always succeed, as it is an empty walk in order + * to start at the root (needed for creating new files in root). + */ +static unsigned int walk_9pfs(struct dev_9pfs *dev, uint32_t fid, + unsigned int steps, char **paths) +{ + uint32_t curr_fid = P9_ROOT_FID; + int ret; + + while ( steps-- ) + { + ret = p9_walk(dev, curr_fid, fid, *paths); + if ( ret ) + return steps + 1; + curr_fid = fid; + *paths += strlen(*paths) + 1; + } + + return 0; +} + +static unsigned int split_path(const char *pathname, char **split_ptr) +{ + unsigned int parts = 1; + char *p; + + *split_ptr = strdup(pathname); + + for ( p = strchr(*split_ptr, '/'); p; p = strchr(p + 1, '/') ) + { + *p = 0; + parts++; + } + + return parts; +} + +static bool path_canonical(const char *pathname) +{ + unsigned int len = strlen(pathname); + const char *c; + + /* Empty path is allowed. */ + if ( !len ) + return true; + + /* No trailing '/'. */ + if ( pathname[len - 1] == '/' ) + return false; + + /* No self or parent references. */ + c = pathname; + while ( (c = strstr(c, "/.")) != NULL ) + { + if ( c[2] == '.' ) + c++; + if ( c[2] == 0 || c[2] == '/' ) + return false; + c += 2; + } + + return true; +} + static int connect_9pfs(struct dev_9pfs *dev) { int ret; @@ -504,10 +727,101 @@ static void intr_9pfs(evtchn_port_t port, struct pt_regs *regs, void *data) wake_up(&dev->waitq); } +static int close_9pfs(struct file *file) +{ + struct file_9pfs *f9pfs = file->filedata; + + if ( f9pfs->fid != P9_ROOT_FID ) + { + p9_clunk(f9pfs->dev, f9pfs->fid); + put_fid(f9pfs->dev, f9pfs->fid); + } + + free(f9pfs); + + return 0; +} + static int open_9pfs(struct mount_point *mnt, const char *pathname, int flags, mode_t mode) { - errno = ENOSYS; + int fd; + char *path = NULL; + char *p; + struct file *file; + struct file_9pfs *f9pfs; + uint16_t nwalk; + uint8_t omode; + int ret; + + if ( !path_canonical(pathname) ) + return EINVAL; + + f9pfs = calloc(1, sizeof(*f9pfs)); + f9pfs->dev = mnt->dev; + f9pfs->fid = P9_ROOT_FID; + + fd = alloc_fd(ftype_9pfs); + file = get_file_from_fd(fd); + file->filedata = f9pfs; + + switch ( flags & O_ACCMODE ) + { + case O_RDONLY: + omode = P9_OREAD; + break; + case O_WRONLY: + omode = P9_OWRITE; + break; + case O_RDWR: + omode = P9_ORDWR; + break; + default: + ret = EINVAL; + goto err; + } + + if ( flags & O_TRUNC ) + omode |= P9_OTRUNC; + f9pfs->append = flags & O_APPEND; + + nwalk = split_path(pathname, &path); + + f9pfs->fid = get_fid(mnt->dev); + if ( !f9pfs->fid ) + { + ret = ENFILE; + goto err; + } + p = path; + nwalk = walk_9pfs(mnt->dev, f9pfs->fid, nwalk, &p); + if ( nwalk ) + { + if ( nwalk > 1 || !(flags & O_CREAT) ) + { + ret = ENOENT; + goto err; + } + + ret = p9_create(mnt->dev, f9pfs->fid, p, mode, omode); + if ( ret ) + goto err; + goto out; + } + + ret = p9_open(mnt->dev, f9pfs->fid, omode); + if ( ret ) + goto err; + + out: + free(path); + + return fd; + + err: + free(path); + close(fd); + errno = ret; return -1; } @@ -552,6 +866,7 @@ void *init_9pfront(unsigned int id, const char *mnt) init_waitqueue_head(&dev->waitq); init_SEMAPHORE(&dev->ring_out_sem, 1); init_SEMAPHORE(&dev->ring_in_sem, 1); + dev->fid_mask = ~0ULL; for ( i = 0; i < N_REQS; i++ ) { @@ -753,6 +1068,7 @@ void shutdown_9pfront(void *dev) static const struct file_ops ops_9pfs = { .name = "9pfs", + .close = close_9pfs, }; __attribute__((constructor)) -- 2.35.3 From minios-devel-bounces@lists.xenproject.org Fri Feb 10 11:44:15 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 10 Feb 2023 11:44:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493340.763236 (Exim 4.92) (envelope-from ) id 1pQRp3-0001xp-6r; Fri, 10 Feb 2023 11:44:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493340.763236; Fri, 10 Feb 2023 11:44:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQRp3-0001xi-3z; Fri, 10 Feb 2023 11:44:09 +0000 Received: by outflank-mailman (input) for mailman id 493340; Fri, 10 Feb 2023 11:44:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQRp2-0001xX-0D for minios-devel@lists.xenproject.org; Fri, 10 Feb 2023 11:44:08 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 36b8ed52-a938-11ed-93b5-47a8fe42b414; Fri, 10 Feb 2023 12:44:04 +0100 (CET) Received: from mail-co1nam11lp2169.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 10 Feb 2023 06:43:53 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM6PR03MB5259.namprd03.prod.outlook.com (2603:10b6:5:245::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.21; Fri, 10 Feb 2023 11:43:51 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.021; Fri, 10 Feb 2023 11:43:51 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 36b8ed52-a938-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676029444; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=L8/7Mz6SoGufMxhP0MH7kRY/O+E6cfykxtojQvlf/kA=; b=THHj/vtP8c0p7Z7OaWCl1BIuDRWyd3fx9Lr+1HvMZYNQwu5vMO/XV4fX aXsSQDi5ZE2DlfahDoi8xjVhVIhJl3ziRUiXuXDZb/Y+Owf4jrdSU6eXr J0cwDGSolNNeCmEnKWQyS2gPiVH/ecW2EixfrcqonfHe/N5C1z+jGgx4X o=; X-IronPort-RemoteIP: 104.47.56.169 X-IronPort-MID: 95910277 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:4gyftqNBVdqE3QHvrR1HlsFynXyQoLVcMsEvi/4bfWQNrUol0zBTx mNMWmqOb6yNN2fxKop+YY2y9kMBvJHcmN9lGgto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9Suv3rRC9H5qyo42tC5wRmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0vl4IUhRy u4CEREud1ediOeznOnqVPY506zPLOGzVG8ekldJ6GiASN0BGNXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PRxujaCpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8eewHKiANhNS9VU8NZ3uxqC2FAXFScwD3enkfSTs2OCCv9Qf hl8Fi0G6PJaGFaQZtvyRRqju1afowURHdFXFoUS7QCLy63PpgqUGGUAZjpAc8A98t87QyQw0 V2ElM+vAiZg2JWFRHTY+rqKoDeaPSkOMXREdSICVREC4dTovMc0lB2nZs1qFbO4ipvpGTD6y i2OsAAzga5Wid8M0eO851+vqy2ojojESEgy/Aq/Y46+xgZwZYrgbIvx71HetK9ENNzAEAjHu 2UYkc+D6uxIFYuKiCGGXOQKGveu+uqBNzrfx1VoGvHN6giQxpJqRqgIiBkWGaujGpxdEdM1S Cc/YT9s2aI= IronPort-HdrOrdr: A9a23:pCmEYaOBKDoR+8BcTuejsMiBIKoaSvp037B87TEKdfVwSL3gqy nIpoV86faUskd3ZJhEo7q90ca7MBDhHPJOgbX5Xo3SODUO2lHYTr2KtrGSuwEIcheWnoVgPM xbAs1D4bPLbGRSvILT/BS/CNo4xcnvytHSuQ4c9RtQpMNRBp2IIz0XNu9TKCNLeDU= X-IronPort-AV: E=Sophos;i="5.97,286,1669093200"; d="scan'208";a="95910277" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jMz4VXTj6Sh5fQCDL5t9rpQCwsjFJIg9S3L9jd6q6ei40AUdYdqxOCTgckcuPon1JApU7T6UE7/4JOLO1TQGQPkc66RCW0NUvYrTTCdfyzEy/Nzfgz8IR8drxOM94rmAogbv4oKkSt+NM3nWw9pw8DB+FxD87bLXvvMAsnkFTi6WIujMdMD7smw0bIIdmzVpFwvyoA53k764I2nYGzVUKF/u9tZQedGNhc0Kz73ayN03bou9j2YcWYHCXZG75aAz35QTJiQWNoeo9Wk2I10L1svSfG6/XlrGMZ/5/vZelOyWFowj4pYSCTn62vYqlV3AEqjt8eH+0ABASycKRzpXMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TamF8SrNO6lCSMT/cBeMvIiv3d8WU5RPQ1qkqPNlfSs=; b=MfUvUlx4CkuvJ2w69ET8IZ+K6ffVRzM4W0iWK7QSuWQz2FpxE2TedVMewHm+toys4mA4o91foIGLHzlBuDgaBRYkKFPzjFDqUpEZDrUzulMYkKHkRKsvxJxfanjZn1BoQTasXJzE0dPXY2PKCGigTmoDGZ74YkzQZx+EKLhp3nzrB2N8482/KK9KJU4Xmywz7DWs7vigJ5CTvpqtDZL3PomQ0AKsevGMN9pA7npgvBUdr+oQH3dw0smYtsKb4Qtxd3rUKSwJQvZqps22TQAw9oNrcSb4Exk2zK7PyOD3yqNGtJOOOIrg81DyqHO7b4PRXs9U4Lfb6Um7FddMAKGuUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TamF8SrNO6lCSMT/cBeMvIiv3d8WU5RPQ1qkqPNlfSs=; b=HpNSVPuPHCrisrH6JyCsUlXNoLyM57QQZJFWtFbEFPqjhwAMPDZ5jOH22W9QhP+r3PcJVc31LqgSieMc6beQAL34mB+9nxvWJBl6W2c5Nyef8oCIiOFTKYUaUm3Bu7AV4Yc0kt9kHSmYNBtg+utxBO7+sGg8sy4q23dewkYY7X4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <9d4810c5-10f4-d9f8-5a8a-3c52db6623bf@citrix.com> Date: Fri, 10 Feb 2023 11:43:45 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 3/7] Mini-OS: add support for runtime mounts Content-Language: en-GB To: Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org References: <20230210104628.14374-1-jgross@suse.com> <20230210104628.14374-4-jgross@suse.com> From: Andrew Cooper In-Reply-To: <20230210104628.14374-4-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0220.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a6::9) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|DM6PR03MB5259:EE_ X-MS-Office365-Filtering-Correlation-Id: 299e8c9c-fc4d-4d59-394b-08db0b5c1437 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LNCPtDoP03078hM0tD0zNbMCUvoGoEPMJW29lO2dYtUANcI5TwWjgv/VS6jTexOXQ5CEcYGS72Ian56+ic6wotbznByRSN2NuSGD8eBBemM8b0Wz7Wfpchjf/NosWrU/+qLPN2+/H/p4l/TvJZ8nrvqfHkBdIBS2Qb/9ybY2Yowr+DjyyyC1+zXNF/EmGmcjjKRJYysQnRlc0/AQh5nMJM6RJMlVdbGVA6TfCxNI0ahfzerPS0sRH1NdreO5uyzyIrZRbJXZQgM6qlN8yA0MciXoSNcPqYNGsxIndgg1OJvl7oByJqtoK13KFXd6/Z95WA+Aow4QtLw5187I4F4zlOZ1vi4VYkq3BXk7GivhZJNHd2wSBAxecA8xSjqtY9yURj1nt0EW7bDme8VwwidZF4fR4h0Fg95/YnfMVU+CndkRu3SevuKnmx7CUtCwO7IAygEI67ZWqhpRfUIsWpEIFx7bGrSNEM6pPD9TPz2p+IAsajPy20UoPq+H0Ywzay5cQ0jftBghl53/Dzt8dyggwJ33vvE85CyRDJedX63PCXr+iahQ/w1k4a3rofFrGezAGjTDUMv0P58s6lLnMHASf3OXVF8WKiZ3+3pH325dT6g1hnVxqKaUY/Hp6lDK+qVOI15MtvhPfDaSoCm8zommHyOLZAxQQ3eoCp04YT0dA8y6V7e/d5ozk4/hpVfWwrLlZPILhre7m71M3LTXxJZIzavY94wlQaFYQtHEzzkt8qA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(376002)(396003)(346002)(39860400002)(136003)(451199018)(478600001)(6486002)(316002)(2906002)(4326008)(66476007)(66556008)(66946007)(8676002)(41300700001)(6666004)(31686004)(6506007)(8936002)(6512007)(186003)(5660300002)(26005)(53546011)(4744005)(38100700002)(2616005)(36756003)(82960400001)(31696002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TzdOZHBVcjJyMXNtT2xIb0dYUHQxNm10amFjOWxyQkV0ekVUdUM2MUxTSEV0?= =?utf-8?B?ZVN4dkxtVGpvYnVENkdhS01xeEVpZklXYnZycE5yZGcySU4wNjBRdnFBT2Ft?= =?utf-8?B?OWF2RDVQTllRY3JCbEZRb3orUmNtREs4T2x6SWZqdFZ5cFdVSW12SExmWlJE?= =?utf-8?B?eHhlN3Z5SVB3QmxDbklDdStzWEtZZzJpejlRTGkwMy9iTHplY3V4L1B6TWRL?= =?utf-8?B?SnVhZm5mUmZPUnZJV2QxUUhwSHRDV0tPczZXTUZGNitiTmZvZW8ya3UxSmpk?= =?utf-8?B?a0twb2RCd3RvMERKMklvM051b3p0bjN5QTFKdUttY1dCZFhBVmx4NzZnay84?= =?utf-8?B?NHNpN0V1NFVjRGFaWXprL1pnWDBET1dyZ3dYSzAwbXkvdGllKzBIZW8zNFFS?= =?utf-8?B?QlZBa3pGT0RwVjdzK3JHTkYyR2dVS2F0SjlwTHoyeUNLbnNZQThoRmh6a3Fj?= =?utf-8?B?SnlGRnJGdDVxdm5JK1QvcWxNVzA3T1dlMWNmV3lLQWpyV2hMQnQ4YlhTYk1C?= =?utf-8?B?WkM5UERvS2hJdzJ6Y2I4Qlk3YjVFK1RBQWhwamdtZ3V2amlkT0NKeDI3WFo5?= =?utf-8?B?SlQ0NUtzUWNGMkZzTmpXaVl5Q0NLa0laOHRQMXMwVWhvMWRTUVFMRGk5bFFI?= =?utf-8?B?U1dQb1pFNnh5d285N2V1N3V3b3h0UEZmd3JnN1VsYnFZZ0Z4ZFFLSkIxUmln?= =?utf-8?B?N1pLNjdwRk5jSWhUTHFVUTFsSWFtRVFVZFA4QzdEZ2JTU3prdllmR0krZU1G?= =?utf-8?B?M0dWSmNZR3hLYVQzaU1zSzJKZUNvNTQwNy9tYjR3MThEc2J1TEFOZ3VremhL?= =?utf-8?B?WTVuMnNsRE1hWVdvQmhRR0VQVkpENjFmd1Y3ZTZmSE9jK29KWDNWQlNEclBi?= =?utf-8?B?MXhiL2d6NUNIRmFNRnllVHRqZlRxMW9LVUZvQ2FRcHIrZHVmQ2N0Z2N3Ynlu?= =?utf-8?B?bmlOS3QvUHU4b05zRnZBTzhxbCtOTHpuT3Z2WTVKdkNlMkxia0gvYTA0V3ZI?= =?utf-8?B?dHYxV1BXRyt6bXBWOXlCNTV2NG90dzZWRmdPVXIweXhNcW04WThmc25mSXBQ?= =?utf-8?B?SHJ2SWdPbVNIYVhLKzRSaGhPNUU2YWg0OXpxcHFvbStWNUs0Y1hWM0R0SmtM?= =?utf-8?B?UWxJYmxMOSsraWI2TmpqZythOHdlckpWK0F5OUpQeTE0MlFUc1l6OXVWWHV3?= =?utf-8?B?YStWUEFwZmNIbU5pWE5XYnNuVzBFNFlSRWw0UktjY0h3MTY1WWxqUUtNVjhS?= =?utf-8?B?RnhvM0RwOFVpOXhuL3FTWmE2clVoc3dHU0U1cGZrMlc0RkIzVk5lU05lQndh?= =?utf-8?B?cXJFKzZjV2twbklzVnA5MERNQjFIUjJ0MkdtS0hpMUZaQ3FLL0xZQldoYjhL?= =?utf-8?B?clN2Uk5RTVo2enFZcXJkRTRxanQwNC9mZXJkT2lLRFNORWk5NHNMMU4xWFFo?= =?utf-8?B?S3d1aDZOK1BzWmdrTThMMVl4N29ncWRBaXhmUm1Fc3ljb1o4VWVtLzNQaHJz?= =?utf-8?B?UXV6RDU5UGNEcTYxbjliZVhHTGd4b3FHazBETVlra1dpM2FobExNcHpFSjU0?= =?utf-8?B?TGNETXowUmVYWkIxOTBXa2xwRHg0eSsxNUxWTTZKT0JBYUNWelhZVnBxUlo4?= =?utf-8?B?MjRkVWg4NTkwQldPSE5CTnBpNnVsbmVlS0tNVE1ZUHhUMGMvRzJZZGFZYU9P?= =?utf-8?B?R1dNblZHQTVDcjBrMy9mZURMYjk4cDdhWDZuQkNnSk14Rm52MFRPV2sxcGZk?= =?utf-8?B?Tmt0cEptY3FsR3kwSWNYSWdJMklHcWlNSThXTWp4RWJsQzBmZE9iSldGSXov?= =?utf-8?B?K3FmUmtyOUhVczlHYjI1dXptOXJkcnlEREY3V3dFRzBoS2Yyc2h2ZjVDa3pT?= =?utf-8?B?NnlhcFgwaDhKRnJUMWZkMWRzb05CR2RGa0M2RUg4cXY3TElaYWZmdFNkdDdE?= =?utf-8?B?MEtyS1BJZjBKUXRtNnEvRC9sa1dCYzcvVWNyc3prckg5R1Z1ZWZtSmlYdVhQ?= =?utf-8?B?MmMxT1J1SFlxbmJFTFZmS3NjSDN1bDQyRkxTbGFrWTczL1diTCtzbEFqSGo4?= =?utf-8?B?VmZ1WlQ3NWh1M3pSQmdFdEVMMSs2T2kxMlJxVXI4QUxUS0dKSkFuNXY4ZzBZ?= =?utf-8?B?VmlUa21zekx3eUhQdUJBaDVIaCtvcTJvMXd5by81elRweW81Nms2c3VQaUQ2?= =?utf-8?B?OWc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: F046j0uk+90fB5KZHaWe+J+YFoIdNDzRigjQtXbsbytnSb8AEksQCpbcYzJjxxBrifgy/eWR4YiHBcmWVkT4HCJX0jgGzxezIBqio46mRbXkSyrFAqpur6DBe/m0JBAGCAzWcENeHfPW8nCTSkm2LXlHI8pxDC1N319ERT3E3D2oWHtVp6pNUOHtIgCO+pYDtSJ+9Zhmlz1rATzqUgNdDLgfmfu33Y+W48B1Ujyb1lLq/fIQV6x9t99kj5DAWUsJHGxREng48v507BbT+5pMOC9vmZ60P0DXE9volg1+3hXFV0WxORDbRVxqcemG8wL6ptFmXzTnU9BeKMFyntfRdahu8gW5z25T+HctbIcjTImyzu6/SbMwQhgHQLmO90aXvSaH1gG1FmmoEi2AVG8YaVVTC9wo7PWs77cGTm1uDudTYMv6WEumCJs0lbijBxwgWVBu6RW08GgpTTkRQXYulRWbs0fdCO9ywouPI/emaMFUseM4L4KWcj9d/gvzvOCZmVMUsRyZOU5u6rnBexJWmSq0uOcHiDoRsBcbN4PDykWpJoXyib7JhVZUk0SGu3ed+4mcX6Tefr5WNFYOSyqEywLZcsM2G2wGo1lUeAOYUaSWRF0eoM7Jgwx/ePquHPFUVKJD+9fxRdaiD1JvMTr18YZrF6jzKSwmjG+7CzR65PoT97yiOzmLn+FHzWlqW2Vebu4ptPC27v4V9xrBSE+JzUDVY9HJhXjEHGzBWKC3W85go1KsPo/2AVcSmsyyFKwvwcjWTD1NFI2GUu4ECwM6wBw4Mon753blPgCvylq5LePrpTrFLB91Un/61iZttcs3k57JbDLwYexDqQacFiI6cDccRsTCmDw+/SEQvm79WX4= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 299e8c9c-fc4d-4d59-394b-08db0b5c1437 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 11:43:51.0867 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0QZMfPrzWEcCq522loYKnQklShJ2Kl5tCMJ/hhZaBiwtCAtpXQXaePP2ccEfDrs77hIkgGIYqGJi0/9dkVtCtxRWI6a2hVcMcc/97EpEO8Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5259 On 10/02/2023 10:46 am, Juergen Gross wrote: > diff --git a/lib/sys.c b/lib/sys.c > index 2f33c937..dc8a8c69 100644 > --- a/lib/sys.c > +++ b/lib/sys.c > @@ -339,7 +339,14 @@ static int open_mem(struct mount_point *mnt, const char *pathname, int flags, > return fd; > } > > -static struct mount_point mount_points[] = { > +#ifdef CONFIG_CONSFRONT > +#define STATIC_MNTS 4 > +#else > +#define STATIC_MNTS 2 > +#endif This ought to be #define STATIC_MNTS (2 + (IS_ENABLED(CONFIG_CONSFRONT) * 2)) because it shows where the parts come from, and is much cleaner to add a 3rd one to in due course. That said, it would be simpler to just have a total mounts set at 16 or so?  Does a difference of two dynamic mounts depending on CONSFRONT actually matter? ~Andrew From minios-devel-bounces@lists.xenproject.org Fri Feb 10 12:14:27 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 10 Feb 2023 12:14:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493387.763334 (Exim 4.92) (envelope-from ) id 1pQSIM-0007gO-7r; Fri, 10 Feb 2023 12:14:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493387.763334; Fri, 10 Feb 2023 12:14:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQSIM-0007gH-5A; Fri, 10 Feb 2023 12:14:26 +0000 Received: by outflank-mailman (input) for mailman id 493387; Fri, 10 Feb 2023 12:14:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQSIK-0007g6-T1 for minios-devel@lists.xenproject.org; Fri, 10 Feb 2023 12:14:24 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 734b821d-a93c-11ed-93b5-47a8fe42b414; Fri, 10 Feb 2023 13:14:21 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3129138C6F; Fri, 10 Feb 2023 12:14:21 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0643913206; Fri, 10 Feb 2023 12:14:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id u4geAB015mPzAwAAMHmgww (envelope-from ); Fri, 10 Feb 2023 12:14:21 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 734b821d-a93c-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676031261; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9/7LL8YFeevoXTCk3DqI4RZG1qm/mpzkWP4bI9bxHzc=; b=k0BQzmIHjgo4E4iqbBFAKg8OeZ8Dzipc4yMeuHlwkBpcUkgMaCFGulYyJAeyYKn1mf61gT wSX170aqyK/yVrni2ywFF2s9ZWOfSaWBVq0b5FXuI7qU+C1b1LRnffyzSfUM7u4YKUA6Z9 G8IbhP1ll7cwjMwe/B1d4BoFGywAMiQ= Message-ID: <8c007a9a-1466-f200-d7f6-27c81622ef27@suse.com> Date: Fri, 10 Feb 2023 13:14:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: Andrew Cooper , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org References: <20230210104628.14374-1-jgross@suse.com> <20230210104628.14374-4-jgross@suse.com> <9d4810c5-10f4-d9f8-5a8a-3c52db6623bf@citrix.com> From: Juergen Gross Subject: Re: [PATCH v2 3/7] Mini-OS: add support for runtime mounts In-Reply-To: <9d4810c5-10f4-d9f8-5a8a-3c52db6623bf@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------gYHr6Z1L8dY8JCyXyg5uCt7O" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------gYHr6Z1L8dY8JCyXyg5uCt7O Content-Type: multipart/mixed; boundary="------------ZaUrE1zYQss3ulHEXpjQy7bV"; protected-headers="v1" From: Juergen Gross To: Andrew Cooper , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org Message-ID: <8c007a9a-1466-f200-d7f6-27c81622ef27@suse.com> Subject: Re: [PATCH v2 3/7] Mini-OS: add support for runtime mounts References: <20230210104628.14374-1-jgross@suse.com> <20230210104628.14374-4-jgross@suse.com> <9d4810c5-10f4-d9f8-5a8a-3c52db6623bf@citrix.com> In-Reply-To: <9d4810c5-10f4-d9f8-5a8a-3c52db6623bf@citrix.com> --------------ZaUrE1zYQss3ulHEXpjQy7bV Content-Type: multipart/mixed; boundary="------------lk0kNtLJLnA1v7uhw6G0v4ci" --------------lk0kNtLJLnA1v7uhw6G0v4ci Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTAuMDIuMjMgMTI6NDMsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+IE9uIDEwLzAyLzIw MjMgMTA6NDYgYW0sIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBkaWZmIC0tZ2l0IGEvbGli L3N5cy5jIGIvbGliL3N5cy5jDQo+PiBpbmRleCAyZjMzYzkzNy4uZGM4YThjNjkgMTAwNjQ0 DQo+PiAtLS0gYS9saWIvc3lzLmMNCj4+ICsrKyBiL2xpYi9zeXMuYw0KPj4gQEAgLTMzOSw3 ICszMzksMTQgQEAgc3RhdGljIGludCBvcGVuX21lbShzdHJ1Y3QgbW91bnRfcG9pbnQgKm1u dCwgY29uc3QgY2hhciAqcGF0aG5hbWUsIGludCBmbGFncywNCj4+ICAgICAgIHJldHVybiBm ZDsNCj4+ICAgfQ0KPj4gICANCj4+IC1zdGF0aWMgc3RydWN0IG1vdW50X3BvaW50IG1vdW50 X3BvaW50c1tdID0gew0KPj4gKyNpZmRlZiBDT05GSUdfQ09OU0ZST05UDQo+PiArI2RlZmlu ZSBTVEFUSUNfTU5UUyAgIDQNCj4+ICsjZWxzZQ0KPj4gKyNkZWZpbmUgU1RBVElDX01OVFMg ICAyDQo+PiArI2VuZGlmDQo+IA0KPiBUaGlzIG91Z2h0IHRvIGJlDQo+IA0KPiAjZGVmaW5l IFNUQVRJQ19NTlRTICgyICsgKElTX0VOQUJMRUQoQ09ORklHX0NPTlNGUk9OVCkgKiAyKSkN Cj4gDQo+IGJlY2F1c2UgaXQgc2hvd3Mgd2hlcmUgdGhlIHBhcnRzIGNvbWUgZnJvbSwgYW5k IGlzIG11Y2ggY2xlYW5lciB0byBhZGQgYQ0KPiAzcmQgb25lIHRvIGluIGR1ZSBjb3Vyc2Uu DQoNCkluIHByaW5jaXBsZSBmaW5lLCBidXQgSSdtIG5vdCBzdXJlIGl0IGlzIHdvcnRoIHRo ZSBlZmZvcnQgdG8gYWRkDQpJU19FTkFCTEVEKCkgc3VwcG9ydCB0byBNaW5pLU9TLg0KDQo+ IFRoYXQgc2FpZCwgaXQgd291bGQgYmUgc2ltcGxlciB0byBqdXN0IGhhdmUgYSB0b3RhbCBt b3VudHMgc2V0IGF0IDE2IG9yDQo+IHNvP8KgIERvZXMgYSBkaWZmZXJlbmNlIG9mIHR3byBk eW5hbWljIG1vdW50cyBkZXBlbmRpbmcgb24gQ09OU0ZST05UDQo+IGFjdHVhbGx5IG1hdHRl cj8NCg0KUHJvYmFibHkgbm90LiBTYW11ZWwsIGFueSB0aG91Z2h0cyBvbiB0aGF0Pw0KDQoN Ckp1ZXJnZW4NCg0K --------------lk0kNtLJLnA1v7uhw6G0v4ci Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------lk0kNtLJLnA1v7uhw6G0v4ci-- --------------ZaUrE1zYQss3ulHEXpjQy7bV-- --------------gYHr6Z1L8dY8JCyXyg5uCt7O Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPmNRwFAwAAAAAACgkQsN6d1ii/Ey8S ngf/UNYiWsjsaAcKMRDx6fEDCyFeOm6XXBnOIj7C7XEt1lZUJFmcwcYzMmbuJquh8laOwcs0Orpi NDjLFQb20xHxlWvOHYTD0G/qldZVUUSfd3Xto03EmoTrMqH/oNh7Q/xE6EJouPns22lkNJMaHHOY vVpvjuRNIqSP2U6GGr82qmqKWQPovJ86p+TBaYbmpnTKBd22ReEmEUh+PicLxjjH6Hbf79TqrrqZ GsR0JfQPkNuzqo3Y1gn+MClsEDLS4uxmJmyoi3tQYIHACPQ7HMUqtzYE/fTnN8AvkQeXNbAqlNo5 +wt0ZtC2r8VdIfl/OY1qBHGf8cWX7ukv0nqkbmBz6A== =HSde -----END PGP SIGNATURE----- --------------gYHr6Z1L8dY8JCyXyg5uCt7O-- From minios-devel-bounces@lists.xenproject.org Fri Feb 10 12:44:58 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 10 Feb 2023 12:44:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493402.763354 (Exim 4.92) (envelope-from ) id 1pQSls-0003bs-2r; Fri, 10 Feb 2023 12:44:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493402.763354; Fri, 10 Feb 2023 12:44:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQSlr-0003ay-Un; Fri, 10 Feb 2023 12:44:55 +0000 Received: by outflank-mailman (input) for mailman id 493402; Fri, 10 Feb 2023 12:44:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQSlq-0003Vh-GH for minios-devel@lists.xenproject.org; Fri, 10 Feb 2023 12:44:54 +0000 Received: from sonata.ens-lyon.org (sonata.ens-lyon.org [140.77.166.138]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b3056868-a940-11ed-93b5-47a8fe42b414; Fri, 10 Feb 2023 13:44:47 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 462F62015B; Fri, 10 Feb 2023 13:44:46 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h12om-dWo-29; Fri, 10 Feb 2023 13:44:46 +0100 (CET) Received: from begin (p-gweduroam01.u-bordeaux.fr [147.210.179.67]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id EB59120158; Fri, 10 Feb 2023 13:44:45 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pQSlg-005qZZ-0w; Fri, 10 Feb 2023 13:44:44 +0100 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: b3056868-a940-11ed-93b5-47a8fe42b414 Date: Fri, 10 Feb 2023 13:44:44 +0100 From: Samuel Thibault To: Juergen Gross Cc: Andrew Cooper , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH v2 3/7] Mini-OS: add support for runtime mounts Message-ID: <20230210124444.bc7siuuj5dwgf3pb@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , Andrew Cooper , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230210104628.14374-1-jgross@suse.com> <20230210104628.14374-4-jgross@suse.com> <9d4810c5-10f4-d9f8-5a8a-3c52db6623bf@citrix.com> <8c007a9a-1466-f200-d7f6-27c81622ef27@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8c007a9a-1466-f200-d7f6-27c81622ef27@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le ven. 10 févr. 2023 13:14:20 +0100, a ecrit: > On 10.02.23 12:43, Andrew Cooper wrote: > > On 10/02/2023 10:46 am, Juergen Gross wrote: > > > diff --git a/lib/sys.c b/lib/sys.c > > > index 2f33c937..dc8a8c69 100644 > > > --- a/lib/sys.c > > > +++ b/lib/sys.c > > > @@ -339,7 +339,14 @@ static int open_mem(struct mount_point *mnt, const char *pathname, int flags, > > > return fd; > > > } > > > -static struct mount_point mount_points[] = { > > > +#ifdef CONFIG_CONSFRONT > > > +#define STATIC_MNTS 4 > > > +#else > > > +#define STATIC_MNTS 2 > > > +#endif > > > > This ought to be > > > > #define STATIC_MNTS (2 + (IS_ENABLED(CONFIG_CONSFRONT) * 2)) > > > > because it shows where the parts come from, and is much cleaner to add a > > 3rd one to in due course. > > In principle fine, but I'm not sure it is worth the effort to add > IS_ENABLED() support to Mini-OS. > > > That said, it would be simpler to just have a total mounts set at 16 or > > so?  Does a difference of two dynamic mounts depending on CONSFRONT > > actually matter? > > Probably not. Samuel, any thoughts on that? We can probably as well just have 16 mount entries indeed. Samuel From minios-devel-bounces@lists.xenproject.org Fri Feb 10 18:44:01 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 10 Feb 2023 18:44:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493527.763492 (Exim 4.92) (envelope-from ) id 1pQYNH-0001Wv-Pw; Fri, 10 Feb 2023 18:43:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493527.763492; Fri, 10 Feb 2023 18:43:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYNH-0001VT-MG; Fri, 10 Feb 2023 18:43:55 +0000 Received: by outflank-mailman (input) for mailman id 493527; Fri, 10 Feb 2023 18:43:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYNG-0001Te-4y for minios-devel@lists.xenproject.org; Fri, 10 Feb 2023 18:43:54 +0000 Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dbbb633f-a972-11ed-93b5-47a8fe42b414; Fri, 10 Feb 2023 19:43:50 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 6A2A62015E; Fri, 10 Feb 2023 19:43:49 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UulWY7rJiZS1; Fri, 10 Feb 2023 19:43:49 +0100 (CET) Received: from begin (lfbn-bor-1-1163-184.w92-158.abo.wanadoo.fr [92.158.138.184]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 1FD4C20152; Fri, 10 Feb 2023 19:43:49 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pQYNA-006gMI-2V; Fri, 10 Feb 2023 19:43:48 +0100 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: dbbb633f-a972-11ed-93b5-47a8fe42b414 Date: Fri, 10 Feb 2023 19:43:48 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH v2 1/7] Mini-OS: xenbus: add support for reading node from directory Message-ID: <20230210184348.mbbxhuroralr7q64@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230210104628.14374-1-jgross@suse.com> <20230210104628.14374-2-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230210104628.14374-2-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le ven. 10 févr. 2023 11:46:22 +0100, a ecrit: > Especially PV device drivers often need to read multiple Xenstore > nodes from a common directory. Add support for reading a string or an > unsigned value by specifying the directory and the node. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V2: > - check sscanf() return value (Samuel Thibault) > --- > include/xenbus.h | 6 ++++++ > xenbus.c | 40 +++++++++++++++++++++++++++++++++++++--- > 2 files changed, 43 insertions(+), 3 deletions(-) > > diff --git a/include/xenbus.h b/include/xenbus.h > index 3871f358..c0fc0ac5 100644 > --- a/include/xenbus.h > +++ b/include/xenbus.h > @@ -108,6 +108,12 @@ int xenbus_read_integer(const char *path); > * read and parsing were successful, 0 if not */ > int xenbus_read_uuid(const char* path, unsigned char uuid[16]); > > +/* Support functions for reading values from directory/node tuple. */ > +char *xenbus_read_string(xenbus_transaction_t xbt, const char *dir, > + const char *node, char **value); > +char *xenbus_read_unsigned(xenbus_transaction_t xbt, const char *dir, > + const char *node, unsigned int *value); > + > /* Contraction of snprintf and xenbus_write(path/node). */ > char* xenbus_printf(xenbus_transaction_t xbt, > const char* node, const char* path, > diff --git a/xenbus.c b/xenbus.c > index 81e9b65d..923e8181 100644 > --- a/xenbus.c > +++ b/xenbus.c > @@ -936,16 +936,21 @@ int xenbus_read_uuid(const char *path, unsigned char uuid[16]) > return 1; > } > > +#define BUFFER_SIZE 256 > +static void xenbus_build_path(const char *dir, const char *node, char *res) > +{ > + BUG_ON(strlen(dir) + strlen(node) + 1 >= BUFFER_SIZE); > + sprintf(res,"%s/%s", dir, node); > +} > + > char *xenbus_printf(xenbus_transaction_t xbt, const char* node, > const char* path, const char* fmt, ...) > { > -#define BUFFER_SIZE 256 > char fullpath[BUFFER_SIZE]; > char val[BUFFER_SIZE]; > va_list args; > > - BUG_ON(strlen(node) + strlen(path) + 1 >= BUFFER_SIZE); > - sprintf(fullpath,"%s/%s", node, path); > + xenbus_build_path(node, path, fullpath); > va_start(args, fmt); > vsprintf(val, fmt, args); > va_end(args); > @@ -964,6 +969,35 @@ domid_t xenbus_get_self_id(void) > return ret; > } > > +char *xenbus_read_string(xenbus_transaction_t xbt, const char *dir, > + const char *node, char **value) > +{ > + char path[BUFFER_SIZE]; > + > + xenbus_build_path(dir, node, path); > + > + return xenbus_read(xbt, path, value); > +} > + > +char *xenbus_read_unsigned(xenbus_transaction_t xbt, const char *dir, > + const char *node, unsigned int *value) > +{ > + char path[BUFFER_SIZE]; > + char *msg; > + char *str; > + > + xenbus_build_path(dir, node, path); > + msg = xenbus_read(xbt, path, &str); > + if ( msg ) > + return msg; > + > + if ( sscanf(str, "%u", value) != 1 ) > + msg = strdup("EINVAL"); > + free(str); > + > + return msg; > +} > + > /* > * Local variables: > * mode: C > -- > 2.35.3 > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria. From minios-devel-bounces@lists.xenproject.org Fri Feb 10 18:44:48 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 10 Feb 2023 18:44:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493535.763502 (Exim 4.92) (envelope-from ) id 1pQYO8-00023S-SZ; Fri, 10 Feb 2023 18:44:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493535.763502; Fri, 10 Feb 2023 18:44:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYO8-00023L-Q3; Fri, 10 Feb 2023 18:44:48 +0000 Received: by outflank-mailman (input) for mailman id 493535; Fri, 10 Feb 2023 18:44:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYO8-0001sh-2h for minios-devel@lists.xenproject.org; Fri, 10 Feb 2023 18:44:48 +0000 Received: from sonata.ens-lyon.org (sonata.ens-lyon.org [140.77.166.138]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fd8c19a5-a972-11ed-933c-83870f6b2ba8; Fri, 10 Feb 2023 19:44:46 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 379F62015E; Fri, 10 Feb 2023 19:44:46 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0Am5c1eVhXUX; Fri, 10 Feb 2023 19:44:46 +0100 (CET) Received: from begin (lfbn-bor-1-1163-184.w92-158.abo.wanadoo.fr [92.158.138.184]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 0F16F20152; Fri, 10 Feb 2023 19:44:46 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pQYO5-006gNA-2T; Fri, 10 Feb 2023 19:44:45 +0100 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: fd8c19a5-a972-11ed-933c-83870f6b2ba8 Date: Fri, 10 Feb 2023 19:44:45 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH v2 2/7] Mini-OS: add concept of mount points Message-ID: <20230210184445.p7aopsjlmvplfdze@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230210104628.14374-1-jgross@suse.com> <20230210104628.14374-3-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230210104628.14374-3-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le ven. 10 févr. 2023 11:46:23 +0100, a ecrit: > Add the concept of mount points to Mini-OS. A mount point is a path > associated with a device pointer and an open() callback. A mount point > can be either a file (e.g. "/dev/mem") or a directory ("/var/log"). > > This allows to replace the special casing in the generic open() > handling with a generic mount point handling. > > Prepare the open() callbacks to support creating new files by adding a > mode parameter. > > Additionally add a close() prototype to include/lib.h, as it is missing > today. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V2: > - pass path below mount point to open callbacks (Samuel Thibault) > --- > include/lib.h | 9 ++++++ > lib/sys.c | 80 +++++++++++++++++++++++++++++++++++++++------------ > 2 files changed, 70 insertions(+), 19 deletions(-) > > diff --git a/include/lib.h b/include/lib.h > index bec99646..36d94ec4 100644 > --- a/include/lib.h > +++ b/include/lib.h > @@ -187,6 +187,13 @@ struct file_ops { > bool (*select_wr)(struct file *file); > }; > > +struct mount_point { > + const char *path; > + int (*open)(struct mount_point *mnt, const char *pathname, int flags, > + mode_t mode); > + void *dev; > +}; > + > unsigned int alloc_file_type(const struct file_ops *ops); > > off_t lseek_default(struct file *file, off_t offset, int whence); > @@ -198,6 +205,8 @@ int alloc_fd(unsigned int type); > void close_all_files(void); > extern struct thread *main_thread; > void sparse(unsigned long data, size_t size); > + > +int close(int fd); > #endif > > #endif /* _LIB_H_ */ > diff --git a/lib/sys.c b/lib/sys.c > index 8f8a3de2..2f33c937 100644 > --- a/lib/sys.c > +++ b/lib/sys.c > @@ -263,11 +263,6 @@ char *getcwd(char *buf, size_t size) > return buf; > } > > -#define LOG_PATH "/var/log/" > -#define SAVE_PATH "/var/lib/xen" > -#define SAVE_CONSOLE 1 > -#define RESTORE_CONSOLE 2 > - > int mkdir(const char *pathname, mode_t mode) > { > errno = EIO; > @@ -286,18 +281,30 @@ int posix_openpt(int flags) > return fd; > } > > +static int open_pt(struct mount_point *mnt, const char *pathname, int flags, > + mode_t mode) > +{ > + return posix_openpt(flags); > +} > + > int open_savefile(const char *path, int save) > { > int fd; > char nodename[64]; > > - snprintf(nodename, sizeof(nodename), "device/console/%d", save ? SAVE_CONSOLE : RESTORE_CONSOLE); > + snprintf(nodename, sizeof(nodename), "device/console/%d", save ? 1 : 2); > > fd = open_consfront(nodename); > printk("fd(%d) = open_savefile\n", fd); > > return fd; > } > + > +static int open_save(struct mount_point *mnt, const char *pathname, int flags, > + mode_t mode) > +{ > + return open_savefile(pathname, flags & O_WRONLY); > +} > #else > int posix_openpt(int flags) > { > @@ -311,24 +318,59 @@ int open_savefile(const char *path, int save) > } > #endif > > -int open(const char *pathname, int flags, ...) > +static int open_log(struct mount_point *mnt, const char *pathname, int flags, > + mode_t mode) > { > int fd; > + > /* Ugly, but fine. */ > - if (!strncmp(pathname,LOG_PATH,strlen(LOG_PATH))) { > - fd = alloc_fd(FTYPE_CONSOLE); > - printk("open(%s) -> %d\n", pathname, fd); > - return fd; > + fd = alloc_fd(FTYPE_CONSOLE); > + printk("open(%s%s) -> %d\n", mnt->path, pathname, fd); > + return fd; > +} > + > +static int open_mem(struct mount_point *mnt, const char *pathname, int flags, > + mode_t mode) > +{ > + int fd; > + > + fd = alloc_fd(FTYPE_MEM); > + printk("open(%s%s) -> %d\n", mnt->path, pathname, fd); > + return fd; > +} > + > +static struct mount_point mount_points[] = { > + { .path = "/var/log", .open = open_log, .dev = NULL }, > + { .path = "/dev/mem", .open = open_mem, .dev = NULL }, > +#ifdef CONFIG_CONSFRONT > + { .path = "/dev/ptmx", .open = open_pt, .dev = NULL }, > + { .path = "/var/lib/xen", .open = open_save, .dev = NULL }, > +#endif > +}; > + > +int open(const char *pathname, int flags, ...) > +{ > + unsigned int m, mlen; > + struct mount_point *mnt; > + mode_t mode = 0; > + va_list ap; > + > + if ( flags & O_CREAT ) > + { > + va_start(ap, flags); > + mode = va_arg(ap, mode_t); > + va_end(ap); > } > - if (!strncmp(pathname, "/dev/mem", strlen("/dev/mem"))) { > - fd = alloc_fd(FTYPE_MEM); > - printk("open(/dev/mem) -> %d\n", fd); > - return fd; > + > + for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) > + { > + mnt = mount_points + m; > + mlen = strlen(mnt->path); > + if ( !strncmp(pathname, mnt->path, mlen) && > + (pathname[mlen] == '/' || pathname[mlen] == 0) ) > + return mnt->open(mnt, pathname + mlen, flags, mode); > } > - if (!strncmp(pathname, "/dev/ptmx", strlen("/dev/ptmx"))) > - return posix_openpt(flags); > - if (!strncmp(pathname,SAVE_PATH,strlen(SAVE_PATH))) > - return open_savefile(pathname, flags & O_WRONLY); > + > errno = EIO; > return -1; > } > -- > 2.35.3 > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria. From minios-devel-bounces@lists.xenproject.org Fri Feb 10 18:46:48 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 10 Feb 2023 18:46:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493546.763517 (Exim 4.92) (envelope-from ) id 1pQYQ3-0002us-9d; Fri, 10 Feb 2023 18:46:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493546.763517; Fri, 10 Feb 2023 18:46:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYQ3-0002ul-6x; Fri, 10 Feb 2023 18:46:47 +0000 Received: by outflank-mailman (input) for mailman id 493546; Fri, 10 Feb 2023 18:46:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYQ2-0002uf-GC for minios-devel@lists.xenproject.org; Fri, 10 Feb 2023 18:46:46 +0000 Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4303baa0-a973-11ed-93b5-47a8fe42b414; Fri, 10 Feb 2023 19:46:43 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id B74222015E; Fri, 10 Feb 2023 19:46:42 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CiSvYmAxpibe; Fri, 10 Feb 2023 19:46:42 +0100 (CET) Received: from begin (lfbn-bor-1-1163-184.w92-158.abo.wanadoo.fr [92.158.138.184]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 7736720152; Fri, 10 Feb 2023 19:46:42 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pQYPy-006gPP-0Q; Fri, 10 Feb 2023 19:46:42 +0100 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 4303baa0-a973-11ed-93b5-47a8fe42b414 Date: Fri, 10 Feb 2023 19:46:42 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH v2 4/7] Mini-OS: add 9pfs frontend Message-ID: <20230210184642.7pliosfbx7us2va7@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230210104628.14374-1-jgross@suse.com> <20230210104628.14374-5-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230210104628.14374-5-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le ven. 10 févr. 2023 11:46:25 +0100, a ecrit: > Add a frontend for the 9pfs PV device. For now add only the code needed > to connect to the backend and the related disconnect functionality. The > 9pfs protocol support will be added later. > > Due to its nature (ability to access files) the whole code is guarded > by "#ifdef HAVE_LIBC". > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V2: > - add better error handling to version parsing (Samuel Thibault) > --- > 9pfront.c | 286 ++++++++++++++++++++++++++++++++++ > Config.mk | 1 + > Makefile | 1 + > arch/x86/testbuild/all-no | 1 + > arch/x86/testbuild/all-yes | 1 + > arch/x86/testbuild/newxen-yes | 1 + > include/9pfront.h | 7 + > 7 files changed, 298 insertions(+) > create mode 100644 9pfront.c > create mode 100644 include/9pfront.h > > diff --git a/9pfront.c b/9pfront.c > new file mode 100644 > index 00000000..89ecb3a1 > --- /dev/null > +++ b/9pfront.c > @@ -0,0 +1,286 @@ > +/* > + * Minimal 9pfs PV frontend for Mini-OS. > + * Copyright (c) 2023 Juergen Gross, SUSE Software Solution GmbH > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#ifdef HAVE_LIBC > +struct dev_9pfs { > + int id; > + char nodename[20]; > + unsigned int dom; > + char *backend; > + > + char *tag; > + const char *mnt; > + > + struct xen_9pfs_data_intf *intf; > + struct xen_9pfs_data data; > + RING_IDX prod_pvt_out; > + RING_IDX cons_pvt_in; > + > + grant_ref_t ring_ref; > + evtchn_port_t evtchn; > + unsigned int ring_order; > + xenbus_event_queue events; > +}; > + > +#define DEFAULT_9PFS_RING_ORDER 4 > + > +static unsigned int ftype_9pfs; > + > +static void intr_9pfs(evtchn_port_t port, struct pt_regs *regs, void *data) > +{ > +} > + > +static int open_9pfs(struct mount_point *mnt, const char *pathname, int flags, > + mode_t mode) > +{ > + errno = ENOSYS; > + > + return -1; > +} > + > +static void free_9pfront(struct dev_9pfs *dev) > +{ > + unsigned int i; > + > + if ( dev->data.in && dev->intf ) > + { > + for ( i = 0; i < (1 << dev->ring_order); i++ ) > + gnttab_end_access(dev->intf->ref[i]); > + free_pages(dev->data.in, dev->ring_order); > + } > + unbind_evtchn(dev->evtchn); > + gnttab_end_access(dev->ring_ref); > + free_page(dev->intf); > + free(dev->backend); > + free(dev->tag); > + free(dev); > +} > + > +void *init_9pfront(unsigned int id, const char *mnt) > +{ > + struct dev_9pfs *dev; > + char *msg; > + char *reason = ""; > + xenbus_transaction_t xbt; > + int retry = 1; > + char bepath[64] = { 0 }; > + XenbusState state; > + unsigned int i; > + void *addr; > + char *version; > + char *v; > + > + printk("9pfsfront add %u, for mount at %s\n", id, mnt); > + dev = malloc(sizeof(*dev)); > + memset(dev, 0, sizeof(*dev)); > + snprintf(dev->nodename, sizeof(dev->nodename), "device/9pfs/%u", id); > + dev->id = id; > + > + msg = xenbus_read_unsigned(XBT_NIL, dev->nodename, "backend-id", &dev->dom); > + if ( msg ) > + goto err; > + msg = xenbus_read_string(XBT_NIL, dev->nodename, "backend", &dev->backend); > + if ( msg ) > + goto err; > + msg = xenbus_read_string(XBT_NIL, dev->nodename, "tag", &dev->tag); > + if ( msg ) > + goto err; > + > + snprintf(bepath, sizeof(bepath), "%s/state", dev->backend); > + free(xenbus_watch_path_token(XBT_NIL, bepath, bepath, &dev->events)); > + state = xenbus_read_integer(bepath); > + while ( msg == NULL && state < XenbusStateInitWait ) > + msg = xenbus_wait_for_state_change(bepath, &state, &dev->events); > + if ( msg || state != XenbusStateInitWait ) > + { > + reason = "illegal backend state"; > + goto err; > + } > + > + msg = xenbus_read_unsigned(XBT_NIL, dev->backend, "max-ring-page-order", > + &dev->ring_order); > + if ( msg ) > + goto err; > + if ( dev->ring_order > DEFAULT_9PFS_RING_ORDER ) > + dev->ring_order = DEFAULT_9PFS_RING_ORDER; > + > + msg = xenbus_read_string(XBT_NIL, dev->backend, "versions", &version); > + if ( msg ) > + goto err; > + for ( v = version; *v; v++ ) > + { > + if ( strtoul(v, &v, 10) == 1 && (*v == ',' || *v == 0) ) > + { > + v = NULL; > + break; > + } > + if ( *v != ',' && *v != 0 ) > + { > + reason = "backend published illegal version string"; > + free(version); > + goto err; > + } > + } > + free(version); > + if ( v ) > + { > + reason = "backend doesn't support version 1"; > + goto err; > + } > + > + dev->ring_ref = gnttab_alloc_and_grant((void **)&dev->intf); > + memset(dev->intf, 0, PAGE_SIZE); > + if ( evtchn_alloc_unbound(dev->dom, intr_9pfs, dev, &dev->evtchn) ) > + { > + reason = "no event channel"; > + goto err; > + } > + dev->intf->ring_order = dev->ring_order; > + dev->data.in = (void *)alloc_pages(dev->ring_order); > + dev->data.out = dev->data.in + XEN_FLEX_RING_SIZE(dev->ring_order); > + for ( i = 0; i < (1 << dev->ring_order); i++ ) > + { > + addr = dev->data.in + i * PAGE_SIZE; > + dev->intf->ref[i] = gnttab_grant_access(dev->dom, virt_to_mfn(addr), 0); > + } > + > + while ( retry ) > + { > + msg = xenbus_transaction_start(&xbt); > + if ( msg ) > + { > + free(msg); > + msg = NULL; > + reason = "starting transaction"; > + goto err; > + } > + > + msg = xenbus_printf(xbt, dev->nodename, "version", "%u", 1); > + if ( msg ) > + goto err_tr; > + msg = xenbus_printf(xbt, dev->nodename, "num-rings", "%u", 1); > + if ( msg ) > + goto err_tr; > + msg = xenbus_printf(xbt, dev->nodename, "ring-ref0", "%u", > + dev->ring_ref); > + if ( msg ) > + goto err_tr; > + msg = xenbus_printf(xbt, dev->nodename, "event-channel-0", "%u", > + dev->evtchn); > + if ( msg ) > + goto err_tr; > + msg = xenbus_printf(xbt, dev->nodename, "state", "%u", > + XenbusStateInitialised); > + if ( msg ) > + goto err_tr; > + > + free(xenbus_transaction_end(xbt, 0, &retry)); > + } > + > + state = xenbus_read_integer(bepath); > + while ( msg == NULL && state < XenbusStateConnected ) > + msg = xenbus_wait_for_state_change(bepath, &state, &dev->events); > + if ( msg || state != XenbusStateConnected ) > + { > + reason = "illegal backend state"; > + goto err; > + } > + > + msg = xenbus_printf(XBT_NIL, dev->nodename, "state", "%u", > + XenbusStateConnected); > + if ( msg ) > + goto err; > + > + unmask_evtchn(dev->evtchn); > + > + dev->mnt = mnt; > + if ( mount(dev->mnt, dev, open_9pfs) ) > + { > + reason = "mount failed"; > + goto err; > + } > + > + return dev; > + > + err_tr: > + free(xenbus_transaction_end(xbt, 1, &retry)); > + > + err: > + if ( bepath[0] ) > + free(xenbus_unwatch_path_token(XBT_NIL, bepath, bepath)); > + if ( msg ) > + printk("9pfsfront add %u failed, error %s accessing Xenstore\n", > + id, msg); > + else > + printk("9pfsfront add %u failed, %s\n", id, reason); > + free_9pfront(dev); > + free(msg); > + return NULL; > +} > + > +void shutdown_9pfront(void *dev) > +{ > + struct dev_9pfs *dev9p = dev; > + char bepath[64]; > + XenbusState state; > + char *msg; > + char *reason = ""; > + > + umount(dev9p->mnt); > + snprintf(bepath, sizeof(bepath), "%s/state", dev9p->backend); > + > + msg = xenbus_printf(XBT_NIL, dev9p->nodename, "state", "%u", > + XenbusStateClosing); > + if ( msg ) > + goto err; > + > + state = xenbus_read_integer(bepath); > + while ( msg == NULL && state < XenbusStateClosing) > + msg = xenbus_wait_for_state_change(bepath, &state, &dev9p->events); > + if ( msg || state != XenbusStateClosing ) > + { > + reason = "illegal backend state"; > + goto err; > + } > + > + msg = xenbus_printf(XBT_NIL, dev9p->nodename, "state", "%u", > + XenbusStateClosed); > + if ( msg ) > + goto err; > + > + free_9pfront(dev9p); > + > + return; > + > + err: > + if ( msg ) > + printk("9pfsfront shutdown %u failed, error %s accessing Xenstore\n", > + dev9p->id, msg); > + else > + printk("9pfsfront shutdown %u failed, %s\n", dev9p->id, reason); > + free(msg); > +} > + > +static const struct file_ops ops_9pfs = { > + .name = "9pfs", > +}; > + > +__attribute__((constructor)) > +static void initialize_9pfs(void) > +{ > + ftype_9pfs = alloc_file_type(&ops_9pfs); > +} > + > +#endif /* HAVE_LIBC */ > diff --git a/Config.mk b/Config.mk > index 1a24b30e..677e93df 100644 > --- a/Config.mk > +++ b/Config.mk > @@ -187,6 +187,7 @@ CONFIG-n += CONFIG_QEMU_XS_ARGS > CONFIG-n += CONFIG_TEST > CONFIG-n += CONFIG_PCIFRONT > CONFIG-n += CONFIG_TPMFRONT > +CONFIG-n += CONFIG_9PFRONT > CONFIG-n += CONFIG_TPM_TIS > CONFIG-n += CONFIG_TPMBACK > CONFIG-n += CONFIG_BALLOON > diff --git a/Makefile b/Makefile > index 747c7c01..7ee181a2 100644 > --- a/Makefile > +++ b/Makefile > @@ -39,6 +39,7 @@ SUBDIRS := lib > src-$(CONFIG_BLKFRONT) += blkfront.c > src-$(CONFIG_CONSFRONT) += consfront.c > src-$(CONFIG_TPMFRONT) += tpmfront.c > +src-$(CONFIG_9PFRONT) += 9pfront.c > src-$(CONFIG_TPM_TIS) += tpm_tis.c > src-$(CONFIG_TPMBACK) += tpmback.c > src-y += console.c > diff --git a/arch/x86/testbuild/all-no b/arch/x86/testbuild/all-no > index f79a1012..5b3e99ed 100644 > --- a/arch/x86/testbuild/all-no > +++ b/arch/x86/testbuild/all-no > @@ -12,6 +12,7 @@ CONFIG_NETFRONT = n > CONFIG_FBFRONT = n > CONFIG_KBDFRONT = n > CONFIG_CONSFRONT = n > +CONFIG_9PFRONT = n > CONFIG_XENBUS = n > CONFIG_LIBXS = n > CONFIG_LWIP = n > diff --git a/arch/x86/testbuild/all-yes b/arch/x86/testbuild/all-yes > index faa3af32..8ae489a4 100644 > --- a/arch/x86/testbuild/all-yes > +++ b/arch/x86/testbuild/all-yes > @@ -12,6 +12,7 @@ CONFIG_NETFRONT = y > CONFIG_FBFRONT = y > CONFIG_KBDFRONT = y > CONFIG_CONSFRONT = y > +CONFIG_9PFRONT = y > CONFIG_XENBUS = y > CONFIG_LIBXS = y > CONFIG_BALLOON = y > diff --git a/arch/x86/testbuild/newxen-yes b/arch/x86/testbuild/newxen-yes > index dc83e670..ee27a328 100644 > --- a/arch/x86/testbuild/newxen-yes > +++ b/arch/x86/testbuild/newxen-yes > @@ -12,6 +12,7 @@ CONFIG_NETFRONT = y > CONFIG_FBFRONT = y > CONFIG_KBDFRONT = y > CONFIG_CONSFRONT = y > +CONFIG_9PFRONT = y > CONFIG_XENBUS = y > CONFIG_LIBXS = y > CONFIG_BALLOON = y > diff --git a/include/9pfront.h b/include/9pfront.h > new file mode 100644 > index 00000000..722ec564 > --- /dev/null > +++ b/include/9pfront.h > @@ -0,0 +1,7 @@ > +#ifndef __9PFRONT_H__ > +#define __9PFRONT_H__ > + > +void *init_9pfront(unsigned int id, const char *mnt); > +void shutdown_9pfront(void *dev); > + > +#endif /* __9PFRONT_H__ */ > -- > 2.35.3 > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria. From minios-devel-bounces@lists.xenproject.org Fri Feb 10 18:48:52 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 10 Feb 2023 18:48:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493556.763533 (Exim 4.92) (envelope-from ) id 1pQYS3-0003aN-Og; Fri, 10 Feb 2023 18:48:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493556.763533; Fri, 10 Feb 2023 18:48:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYS3-0003aG-La; Fri, 10 Feb 2023 18:48:51 +0000 Received: by outflank-mailman (input) for mailman id 493556; Fri, 10 Feb 2023 18:48:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYS1-0003a2-Of for minios-devel@lists.xenproject.org; Fri, 10 Feb 2023 18:48:49 +0000 Received: from sonata.ens-lyon.org (sonata.ens-lyon.org [140.77.166.138]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8d633d36-a973-11ed-933c-83870f6b2ba8; Fri, 10 Feb 2023 19:48:47 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 7A6802015E; Fri, 10 Feb 2023 19:48:47 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZI2BQOBURiHz; Fri, 10 Feb 2023 19:48:47 +0100 (CET) Received: from begin (lfbn-bor-1-1163-184.w92-158.abo.wanadoo.fr [92.158.138.184]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 4514320152; Fri, 10 Feb 2023 19:48:46 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pQYRx-006gS9-37; Fri, 10 Feb 2023 19:48:45 +0100 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 8d633d36-a973-11ed-933c-83870f6b2ba8 Date: Fri, 10 Feb 2023 19:48:45 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH v2 5/7] Mini-OS: add 9pfs transport layer Message-ID: <20230210184845.mbxvnqdgy66el6jx@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230210104628.14374-1-jgross@suse.com> <20230210104628.14374-6-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230210104628.14374-6-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le ven. 10 févr. 2023 11:46:26 +0100, a ecrit: > Add the transport layer of 9pfs. This is basically the infrastructure > to send requests to the backend and to receive the related answers via > the rings. > > As a first example add the version and attach requests of the 9pfs > protocol when mounting a new 9pfs device. For the version use the > "9P2000.u" variant, as it is the smallest subset supported by the qemu > based backend. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V2: > - add more comments (Samuel Thibault) > - log short copy (Samuel Thibault) > - send event after consuming response (Samuel Thibault) > - reaturn EAGAIN in case no free request could be got (Samuel Thibault) > --- > 9pfront.c | 478 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 478 insertions(+) > > diff --git a/9pfront.c b/9pfront.c > index 89ecb3a1..0b8d5461 100644 > --- a/9pfront.c > +++ b/9pfront.c > @@ -7,6 +7,8 @@ > #include > #include > #include > +#include > +#include > #include > #include > #include > @@ -14,6 +16,9 @@ > #include > > #ifdef HAVE_LIBC > + > +#define N_REQS 64 > + > struct dev_9pfs { > int id; > char nodename[20]; > @@ -22,6 +27,7 @@ struct dev_9pfs { > > char *tag; > const char *mnt; > + unsigned int msize_max; > > struct xen_9pfs_data_intf *intf; > struct xen_9pfs_data data; > @@ -32,14 +38,470 @@ struct dev_9pfs { > evtchn_port_t evtchn; > unsigned int ring_order; > xenbus_event_queue events; > + > + unsigned int free_reqs; > + struct req { > + unsigned int id; > + unsigned int next_free; /* N_REQS == end of list. */ > + unsigned int cmd; > + int result; > + bool inflight; > + unsigned char *data; /* Returned data. */ > + } req[N_REQS]; > + > + struct wait_queue_head waitq; > + struct semaphore ring_out_sem; > + struct semaphore ring_in_sem; > }; > > #define DEFAULT_9PFS_RING_ORDER 4 > > +#define P9_CMD_VERSION 100 > +#define P9_CMD_ATTACH 104 > +#define P9_CMD_ERROR 107 > + > +#define P9_QID_SIZE 13 > + > +struct p9_header { > + uint32_t size; > + uint8_t cmd; > + uint16_t tag; > +} __attribute__((packed)); > + > +#define P9_VERSION "9P2000.u" > +#define P9_ROOT_FID ~0 > + > static unsigned int ftype_9pfs; > > +static struct req *get_free_req(struct dev_9pfs *dev) > +{ > + struct req *req; > + > + if ( dev->free_reqs == N_REQS ) > + return NULL; > + > + req = dev->req + dev->free_reqs; > + dev->free_reqs = req->next_free; > + > + return req; > +} > + > +static void put_free_req(struct dev_9pfs *dev, struct req *req) > +{ > + req->next_free = dev->free_reqs; > + req->inflight = false; > + req->data = NULL; > + dev->free_reqs = req->id; > +} > + > +static unsigned int ring_out_free(struct dev_9pfs *dev) > +{ > + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); > + unsigned int queued; > + > + queued = xen_9pfs_queued(dev->prod_pvt_out, dev->intf->out_cons, ring_size); > + rmb(); > + > + return ring_size - queued; > +} > + > +static unsigned int ring_in_data(struct dev_9pfs *dev) > +{ > + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); > + unsigned int queued; > + > + queued = xen_9pfs_queued(dev->intf->in_prod, dev->cons_pvt_in, ring_size); > + rmb(); > + > + return queued; > +} > + > +static void copy_to_ring(struct dev_9pfs *dev, void *data, unsigned int len) > +{ > + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); > + RING_IDX prod = xen_9pfs_mask(dev->prod_pvt_out, ring_size); > + RING_IDX cons = xen_9pfs_mask(dev->intf->out_cons, ring_size); > + > + xen_9pfs_write_packet(dev->data.out, data, len, &prod, cons, ring_size); > + dev->prod_pvt_out += len; > +} > + > +static void copy_from_ring(struct dev_9pfs *dev, void *data, unsigned int len) > +{ > + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); > + RING_IDX prod = xen_9pfs_mask(dev->intf->in_prod, ring_size); > + RING_IDX cons = xen_9pfs_mask(dev->cons_pvt_in, ring_size); > + > + xen_9pfs_read_packet(data, dev->data.in, len, prod, &cons, ring_size); > + dev->cons_pvt_in += len; > +} > + > +/* > + * send_9p() and rcv_9p() are using a special format string for specifying > + * the kind of data sent/expected. Each data item is represented by a single > + * character: > + * U: 4 byte unsigned integer (uint32_t) > + * S: String (2 byte length + characters) > + * in the rcv_9p() case the data for string is allocated (length omitted, > + * string terminated by a NUL character) > + * Q: A 13 byte "qid", consisting of 1 byte file type, 4 byte file version > + * and 8 bytes unique file id. Only valid for receiving. > + */ > +static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) > +{ > + struct p9_header hdr; > + va_list ap, aq; > + const char *f; > + uint32_t intval; > + uint16_t len; > + char *strval; > + > + hdr.size = sizeof(hdr); > + hdr.cmd = req->cmd; > + hdr.tag = req->id; > + > + va_start(ap, fmt); > + > + va_copy(aq, ap); > + for ( f = fmt; *f; f++ ) > + { > + switch ( *f ) > + { > + case 'U': > + hdr.size += 4; > + intval = va_arg(aq, unsigned int); > + break; > + case 'S': > + hdr.size += 2; > + strval = va_arg(aq, char *); > + hdr.size += strlen(strval); > + break; > + default: > + printk("send_9p: unknown format character %c\n", *f); > + break; > + } > + } > + va_end(aq); > + > + /* > + * Waiting for free space must be done in the critical section! > + * Otherwise we might get overtaken by other short requests. > + */ > + down(&dev->ring_out_sem); > + > + wait_event(dev->waitq, ring_out_free(dev) >= hdr.size); > + > + copy_to_ring(dev, &hdr, sizeof(hdr)); > + for ( f = fmt; *f; f++ ) > + { > + switch ( *f ) > + { > + case 'U': > + intval = va_arg(ap, unsigned int); > + copy_to_ring(dev, &intval, sizeof(intval)); > + break; > + case 'S': > + strval = va_arg(ap, char *); > + len = strlen(strval); > + copy_to_ring(dev, &len, sizeof(len)); > + copy_to_ring(dev, strval, len); > + break; > + } > + } > + > + wmb(); /* Data on ring must be seen before updating index. */ > + dev->intf->out_prod = dev->prod_pvt_out; > + req->inflight = true; > + > + up(&dev->ring_out_sem); > + > + va_end(ap); > + > + notify_remote_via_evtchn(dev->evtchn); > +} > + > +/* > + * Using an opportunistic approach for receiving data: in case multiple > + * requests are outstanding (which is very unlikely), we nevertheless need > + * to consume all data available until we reach the desired request. > + * For requests other than the one we are waiting for, we link the complete > + * data to the request via an intermediate buffer. For our own request we can > + * omit that buffer and directly fill the caller provided variables. > + * > + * Helper functions: > + * > + * copy_bufs(): copy raw data into a target buffer. There can be 2 source > + * buffers involved (in case the copy is done from the ring and it is across > + * the ring end). The buffer pointers and lengths are updated according to > + * the number of bytes copied. > + * > + * rcv_9p_copy(): copy the data (without the generic header) of a 9p response > + * to the specified variables using the specified format string for > + * deciphering the single item types. The decision whether to copy from the > + * ring or an allocated buffer is done via the "hdr" parameter, which is > + * NULL in the buffer case (in that case the header is located at the start > + * of the buffer). > + * > + * rcv_9p_one(): Checks for an already filled buffer with the correct tag in > + * it. If none is found, consumes one response. It checks the tag of the > + * response in order to decide whether to allocate a buffer for putting the > + * data into, or to fill the user supplied variables. Return true, if the > + * tag did match. Waits if no data is ready to be consumed. > + */ > +static void copy_bufs(unsigned char **buf1, unsigned char **buf2, > + unsigned int *len1, unsigned int *len2, > + void *target, unsigned int len) > +{ > + if ( len <= *len1 ) > + { > + memcpy(target, *buf1, len); > + *buf1 += len; > + *len1 -= len; > + } > + else > + { > + memcpy(target, *buf1, *len1); > + target = (char *)target + *len1; > + len -= *len1; > + *buf1 = *buf2; > + *len1 = *len2; > + *buf2 = NULL; > + *len2 = 0; > + if ( len > *len1 ) > + { > + printk("9pfs: short copy (dropping %u bytes)\n", len - *len1); > + len = *len1; > + } > + memcpy(target, *buf1, *len1); > + } > +} > + > +static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, > + struct p9_header *hdr, const char *fmt, va_list ap) > +{ > + struct p9_header *h = hdr ? hdr : (void *)req->data; > + RING_IDX cons = dev->cons_pvt_in + h->size - sizeof(*h); > + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); > + unsigned char *buf1, *buf2; > + unsigned int len1, len2; > + const char *f; > + char *str; > + uint16_t len; > + uint32_t err; > + uint32_t *val; > + char **strval; > + uint8_t *qval; > + > + if ( hdr ) > + { > + buf1 = xen_9pfs_get_ring_ptr(dev->data.in, dev->cons_pvt_in, ring_size); > + buf2 = xen_9pfs_get_ring_ptr(dev->data.in, 0, ring_size); > + len1 = ring_size - xen_9pfs_mask(dev->cons_pvt_in, ring_size); > + if ( len1 > h->size - sizeof(*h) ) > + len1 = h->size - sizeof(*h); > + len2 = h->size - sizeof(*h) - len1; > + } > + else > + { > + buf1 = req->data + sizeof(*h); > + buf2 = NULL; > + len1 = h->size - sizeof(*h); > + len2 = 0; > + } > + > + if ( h->cmd == P9_CMD_ERROR ) > + { > + copy_bufs(&buf1, &buf2, &len1, &len2, &len, sizeof(len)); > + str = malloc(len + 1); > + copy_bufs(&buf1, &buf2, &len1, &len2, str, len); > + str[len] = 0; > + printk("9pfs: request %u resulted in \"%s\"\n", req->cmd, str); > + free(str); > + err = EIO; > + copy_bufs(&buf1, &buf2, &len1, &len2, &err, sizeof(err)); > + req->result = err; > + > + if ( hdr ) > + dev->cons_pvt_in = cons; > + > + return; > + } > + > + if ( h->cmd != req->cmd + 1 ) > + { > + req->result = EDOM; > + printk("9pfs: illegal response: wrong return type (%u instead of %u)\n", > + h->cmd, req->cmd + 1); > + > + if ( hdr ) > + dev->cons_pvt_in = cons; > + > + return; > + } > + > + req->result = 0; > + > + for ( f = fmt; *f; f++ ) > + { > + switch ( *f ) > + { > + case 'U': > + val = va_arg(ap, uint32_t *); > + copy_bufs(&buf1, &buf2, &len1, &len2, val, sizeof(*val)); > + break; > + case 'S': > + strval = va_arg(ap, char **); > + copy_bufs(&buf1, &buf2, &len1, &len2, &len, sizeof(len)); > + *strval = malloc(len + 1); > + copy_bufs(&buf1, &buf2, &len1, &len2, *strval, len); > + (*strval)[len] = 0; > + break; > + case 'Q': > + qval = va_arg(ap, uint8_t *); > + copy_bufs(&buf1, &buf2, &len1, &len2, qval, P9_QID_SIZE); > + break; > + default: > + printk("rcv_9p: unknown format character %c\n", *f); > + break; > + } > + } > + > + if ( hdr ) > + dev->cons_pvt_in = cons; > +} > + > +static bool rcv_9p_one(struct dev_9pfs *dev, struct req *req, const char *fmt, > + va_list ap) > +{ > + struct p9_header hdr; > + struct req *tmp; > + > + if ( req->data ) > + { > + rcv_9p_copy(dev, req, NULL, fmt, ap); > + free(req->data); > + req->data = NULL; > + > + return true; > + } > + > + wait_event(dev->waitq, ring_in_data(dev) >= sizeof(hdr)); > + > + copy_from_ring(dev, &hdr, sizeof(hdr)); > + > + wait_event(dev->waitq, ring_in_data(dev) >= hdr.size - sizeof(hdr)); > + > + tmp = dev->req + hdr.tag; > + if ( hdr.tag >= N_REQS || !tmp->inflight ) > + { > + printk("9pfs: illegal response: %s\n", > + hdr.tag >= N_REQS ? "tag out of bounds" : "request not pending"); > + dev->cons_pvt_in += hdr.size - sizeof(hdr); > + > + return false; > + } > + > + tmp->inflight = false; > + > + if ( tmp != req ) > + { > + tmp->data = malloc(hdr.size); > + memcpy(tmp->data, &hdr, sizeof(hdr)); > + copy_from_ring(dev, tmp->data + sizeof(hdr), hdr.size - sizeof(hdr)); > + > + return false; > + } > + > + rcv_9p_copy(dev, req, &hdr, fmt, ap); > + > + return true; > +} > + > +static void rcv_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) > +{ > + va_list ap; > + > + va_start(ap, fmt); > + > + down(&dev->ring_in_sem); > + > + while ( !rcv_9p_one(dev, req, fmt, ap) ); > + > + rmb(); /* Read all data before updating ring index. */ > + dev->intf->in_cons = dev->cons_pvt_in; > + > + notify_remote_via_evtchn(dev->evtchn); > + > + up(&dev->ring_in_sem); > + > + va_end(ap); > +} > + > +static int p9_version(struct dev_9pfs *dev) > +{ > + unsigned int msize = XEN_FLEX_RING_SIZE(dev->ring_order) / 2; > + struct req *req = get_free_req(dev); > + char *verret; > + int ret; > + > + if ( !req ) > + return EAGAIN; > + > + req->cmd = P9_CMD_VERSION; > + send_9p(dev, req, "US", msize, P9_VERSION); > + rcv_9p(dev, req, "US", &dev->msize_max, &verret); > + ret = req->result; > + > + put_free_req(dev, req); > + > + if ( ret ) > + return ret; > + > + if ( strcmp(verret, P9_VERSION) ) > + ret = ENOMSG; > + free(verret); > + > + return ret; > +} > + > +static int p9_attach(struct dev_9pfs *dev) > +{ > + uint32_t fid = P9_ROOT_FID; > + uint32_t afid = 0; > + uint32_t uid = 0; > + uint8_t qid[P9_QID_SIZE]; > + struct req *req = get_free_req(dev); > + int ret; > + > + if ( !req ) > + return EAGAIN; > + > + req->cmd = P9_CMD_ATTACH; > + send_9p(dev, req, "UUSSU", fid, afid, "root", "root", uid); > + rcv_9p(dev, req, "Q", qid); > + ret = req->result; > + > + put_free_req(dev, req); > + > + return ret; > +} > + > +static int connect_9pfs(struct dev_9pfs *dev) > +{ > + int ret; > + > + ret = p9_version(dev); > + if ( ret ) > + return ret; > + > + return p9_attach(dev); > +} > + > static void intr_9pfs(evtchn_port_t port, struct pt_regs *regs, void *data) > { > + struct dev_9pfs *dev = data; > + > + wake_up(&dev->waitq); > } > > static int open_9pfs(struct mount_point *mnt, const char *pathname, int flags, > @@ -87,6 +549,16 @@ void *init_9pfront(unsigned int id, const char *mnt) > memset(dev, 0, sizeof(*dev)); > snprintf(dev->nodename, sizeof(dev->nodename), "device/9pfs/%u", id); > dev->id = id; > + init_waitqueue_head(&dev->waitq); > + init_SEMAPHORE(&dev->ring_out_sem, 1); > + init_SEMAPHORE(&dev->ring_in_sem, 1); > + > + for ( i = 0; i < N_REQS; i++ ) > + { > + dev->req[i].id = i; > + dev->req[i].next_free = i + 1; > + } > + dev->free_reqs = 0; > > msg = xenbus_read_unsigned(XBT_NIL, dev->nodename, "backend-id", &dev->dom); > if ( msg ) > @@ -205,6 +677,12 @@ void *init_9pfront(unsigned int id, const char *mnt) > > unmask_evtchn(dev->evtchn); > > + if ( connect_9pfs(dev) ) > + { > + reason = "9pfs connect failed"; > + goto err; > + } > + > dev->mnt = mnt; > if ( mount(dev->mnt, dev, open_9pfs) ) > { > -- > 2.35.3 > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria. From minios-devel-bounces@lists.xenproject.org Fri Feb 10 18:51:26 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 10 Feb 2023 18:51:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493574.763558 (Exim 4.92) (envelope-from ) id 1pQYUX-0005e5-Ml; Fri, 10 Feb 2023 18:51:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493574.763558; Fri, 10 Feb 2023 18:51:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYUX-0005dy-Jz; Fri, 10 Feb 2023 18:51:25 +0000 Received: by outflank-mailman (input) for mailman id 493574; Fri, 10 Feb 2023 18:51:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYUW-0005dq-P8 for minios-devel@lists.xenproject.org; Fri, 10 Feb 2023 18:51:24 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e80b016a-a973-11ed-933c-83870f6b2ba8; Fri, 10 Feb 2023 19:51:22 +0100 (CET) Received: from mail-dm6nam12lp2175.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 10 Feb 2023 13:51:18 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN9PR03MB6138.namprd03.prod.outlook.com (2603:10b6:408:11b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.21; Fri, 10 Feb 2023 18:51:14 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.021; Fri, 10 Feb 2023 18:51:14 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: e80b016a-a973-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676055082; h=message-id:date:from:subject:to:references:in-reply-to: content-transfer-encoding:mime-version; bh=uYkLE6i11nbs5+q7zuAGj51J3zDiw8XIjvKLLP1lMK0=; b=MZRMhNHMGtmnFhY+yRkQoHVWm8nwOaZx8ELtc3JAhDkd2zI9zj2RYRGh vEf20A1xu3DqjIZqMrlYJgSvTZchQWCKmxMTZHFXxBe1qr2poMuecDy0w tm6NBIV8izmCGyKk9/GZZRAvtTsUWvwqwsaO+sblPaJWTeZP8ItAbRLSq A=; X-IronPort-RemoteIP: 104.47.59.175 X-IronPort-MID: 96483984 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:+Xst4KgpTrO0z73uRLidXS3AX161gxEKZh0ujC45NGQN5FlHY01je htvDWjQbP+IYTfxf9onYdu2o0JUvcXWmtMwTgplrH0xF3wb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWt0N8klgZmP6sT5gaGzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQDczEubA6EhN6P4+3iErR+vfoYB+z0adZ3VnFIlVk1DN4AaLWaGeDmwIEd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEgluGybbI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6RePkpqU70AH7Kmo7EwwGDH6n+fKD2xCmfM9Fb FEG93Unov1nnKCsZpynN/Gim1aftxsBVt4WD+074giQzrb87gCCQ2wVSTgHb8Yp3Oc0SiYtz UShhM7yCHpkt7j9YXec8LaTtna+NDYYKUcGZDQYVk0V7t/7uoYxgxnTCNF5H8adntDzXD393 T2OhCw/nKkIy94G0b2h+lLKiC7qoYLGJiYq4i3HU2Tj6Rl2DLNJfKSt4FnfqPpFcoCQSwDbu GBewpfDqucTEZuKiSqBBv0XG62k7OqENzuahkNzG54m9HKm/HvLkZ1s3QyS7XxBaq4sEQIFq meK0e+NzPe/5EeXUJI= IronPort-HdrOrdr: A9a23:8/RnG6DFK9TNNcHlHeko55DYdb4zR+YMi2TDGXoBLCC9Ffbo6v xG+c516faaskd3ZJhNo6HiBEDEewKlyXc32/hkAV7AZnidhILXFvAF0WK4+UyUJ8SWzIc0vs 0MH8YeaOEYT2IK9voSizPId+rIruP3kpyAtKP+9lsodytOApsQkTuRcjzra3FedU1jDZo9FJ 2Tou9GvSfIQwVhUu2LQkAfWe7NvtvKk4+jTyInKnccmXWzpALt0aX9FReA2BcYTndo+pcNtU b4syGR3NTdjxmcoiWsp1M7K64m6ecJ0uEzdvBklPJlWQnRtg== X-IronPort-AV: E=Sophos;i="5.97,287,1669093200"; d="scan'208";a="96483984" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OmCvKihCI5SbN3jPyoIdzBkPvDLOk+lsadJORRbKzZSo1ct7vmNDuwwZS59JkdhjEK4JgNVtzyvpn6q3LeheYl2QAqWFLHuLdzS99nP/fyIPE6iN/OioLyWYXV8ryfGsAGiqyVZcrQO9AE8W/58FuzZs7Hy1BS9apP57Yt/Ekw1q7aXXnSTMtQcV5wL0ZNYBd2VRrc01QzEPzq4KEa0OKHEbTcmeogdzgW1Vaw2rnx7Ih7L1oZJuKo4kKpYGtMg7riHzZfD2Tm3FrtyCTTgIbJ/w0cJsVmqKJuYXYHDv6VT32/DhyfrM2SxoL2M0gI37xPgL2D9JBPrGiTmfit+bQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=10Y/pN9zzZyq5FpSK5ush7e+XYwTwTQ2g3oGNW5huOo=; b=SDtIz9hTnZA68F9N0G+Skxsboubl9QpFFNuzcC7pv28u8Q8bt+UEGHOO1TLawGIghPvEaWc2MbZKfULUzmw3tCt+caCq+B0OJZrVVHkru9j/nkggV2s8tNKHE/PVwkvrOS4jRqXqJs0vEaAUq2uoNx+8ZZc68ofLoDs+aax0zcQQoYS2FngDJQ6NJHjGRxj2CCgEz2XV1erKPzgr79Z/n5uqwNG3Gt+DADIBGsrNzuX/062cBkGtjkf9fUrq3vp8jWQkE2Wd4aaHPRKOC8grR6dc8Tce7t+vjW9fi5IKiykp+3N68rAak0ecBIrXeSFr3PaM2E8kU87EdFJESONAIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=10Y/pN9zzZyq5FpSK5ush7e+XYwTwTQ2g3oGNW5huOo=; b=vFk5aZgDzkk8eNGCPzh673oumd+0/b7rlR9qTgOwtydAQ/4YFprVmcAhJBJbG643WCKk7lqyfG+FvpLFAzEejN23a5tk0T1AUJWgof/kdztxb+gCbXWqnrU4K2W4xJckF3558ex5k88aUg4KzgK5oI7ql3h/WsTB1MLzMUoOMPw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <77aebee5-92d8-304e-5cd0-ff6442f82f76@citrix.com> Date: Fri, 10 Feb 2023 18:51:08 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v2 3/7] Mini-OS: add support for runtime mounts Content-Language: en-GB To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230210104628.14374-1-jgross@suse.com> <20230210104628.14374-4-jgross@suse.com> <9d4810c5-10f4-d9f8-5a8a-3c52db6623bf@citrix.com> <8c007a9a-1466-f200-d7f6-27c81622ef27@suse.com> <20230210124444.bc7siuuj5dwgf3pb@begin> In-Reply-To: <20230210124444.bc7siuuj5dwgf3pb@begin> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0487.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::12) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BN9PR03MB6138:EE_ X-MS-Office365-Filtering-Correlation-Id: d6004c88-bbb9-43ff-c876-08db0b97c89c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SqxdOARle0P5a+RGsIqfFCM62zY3cD7oXZ6aC6uNKkT9T6NgfIhdo3ALbB8KO9mfDHVXZGgp8rUeJyhucaNrmqL0baEgG6LFFQnmlSc5miCvV20lr95Us2Q14VMjtPhezU1c25y69Tz5edIfMICEVTcGaY4sfWl9rxoLUryJ7k0lWXRG64XcZZrVvaenI47pcr7mSSezHzF2nAq2Uxh26qhIUSxLsv9yjKbfQDSoDOluZB9suI4o8UjxYUCe8Si20gldXk14Kw/QxPQwWbkpAAnjM5/57h9b6yaTdugwGmaGAbwntPTh/sWFfQH0tnWlH9tPx/QzIkbmGkY6sQi8Ec6op5MmuHL9D/S+LcSX36xCTDu51uwE+XQOqQVvzcgngLeIxr58Zu+2HKksfsql7AADa5kMP5Qy7AF3nNTXZjS0D+yoCBRjCnscO0XHh4Cx26VvAOb8mZB7iMWBUPlkdFWnTpJxsSBc7MD/2VU4HXTLGnyXmQbhTv7D15Lv8DikmlSmNOFKRm4Rd1nNm+ifbvFRDi/iwx3C1zUFfZQFvEX7yqQr45MWrY3qsAYbH8iwRjwcM/ELMLD+HIbwLO/qOo4troFrh89BVQF0Oxz5oZ8BUWtpah42z/0LVZRJuu7NyCQaWN1fgZjOK26u7ISQpv/FCTa7rzhkky/SgvvZEdbzCo5e3BbqMmqS1ozVIS04VFv9b0zJOpOLMrhxGXF0wz9fn14MPc4lo5maRZ25baI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(366004)(39860400002)(376002)(136003)(396003)(451199018)(66946007)(38100700002)(82960400001)(316002)(41300700001)(8936002)(8676002)(66556008)(66476007)(2906002)(5660300002)(2616005)(6666004)(6506007)(6486002)(53546011)(478600001)(186003)(26005)(31696002)(86362001)(36756003)(31686004)(6512007)(110136005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MUFjZVlOQU04OExicHhQYms2UG91amFuS3RsMkY5Y3poYlpnRGJqZ3hKVXhY?= =?utf-8?B?elVCS2krN2x4YU5xcGk2b1pTdm9sdVdaT3FPcThkcS9kT0lVUFlkQzZmUXFN?= =?utf-8?B?ZXZHRHgvK2RYS3NGQnd4YzJXTU95eVg4emc1Y0RNN1NqV0tGNUU4L3Fjamdj?= =?utf-8?B?YUcycEVaNTJ6TnRuZlBwa1pDblVQc0xVY1VBSGxEQ0JOaGRsQXo0cythbjQ0?= =?utf-8?B?ckVuTnM3RGlmSXNQdEVlZ2FzOXIwNnBMYjY5TjZVREYvZGxicmZ0TldlWDFs?= =?utf-8?B?ellaRVE2UEMvQnBRQ0wxOW5RNU1vSDNkUzIxa3RScmNXVmthTm9GU3h2NGVa?= =?utf-8?B?TzlRb0E2Q01HdlhqUEZEZU1nWnExUW44NzFMK0g2NFBGbkpDeXpPeFVGdGhr?= =?utf-8?B?UmJQNWlhb01BZFpDRlRpYllLTHdxd0dKcGZ3NDRTZzlzTytZOTM5eUloaEox?= =?utf-8?B?TUR3V29vS2JyVWVIMG5EWXB1dTRLbWs4YXJ4QlFnd3Q0alNtMk1vL2dGZDFQ?= =?utf-8?B?WDJWSVFIdHdncXVPNDZxbTVqakFsbXl0b1F0ZDRNb0p6a212cHVZRHVVcmYr?= =?utf-8?B?Yk1RNjhCMWVuaDJiN2FtVGxVS2JwWSs1U0phc09wYVFXQ2o4WkhiTFUzMUFo?= =?utf-8?B?OWZmTnBRaklwN1lYaEFaKzg2K2VUNDQ2c3VWYlhSVkJkVDVLN1U4NGcxWHBi?= =?utf-8?B?YmNRYkh1dzJ3dlp3QlVrL0VwRitTVE1GT1F2VWRhSXROM3ZQZ3hCV0lBVjB2?= =?utf-8?B?K1NWTGt1ZXJ2WElSczl0WG5lck1YQTM0L2hqWDlidkx2bU9oUkpXRUZkRXBR?= =?utf-8?B?NEQxMXRhSnljREJKdWRINzNudUx4OGI3Y2QydjRzS0hheFQ4eUhvZlEvVTBv?= =?utf-8?B?WnJiRkpuVzhGQlh2dXJRbndMSi9zandKSmZPWitBb0lzbjN5WWJ0Nzl5Q1Ev?= =?utf-8?B?djhJemhDVjZSVHpCd3pkZ0QyeFVTUnNBdzQ4T29hbmE0K3dhKzlBem5idlVy?= =?utf-8?B?dEMycjRUV2I2K0RsRjFkcmVNcWIycFFJaXlYbmhPUC9CaGpiUmhtUkJTQUp3?= =?utf-8?B?RU53Qy9ka0EyVExRQXNiWlZRUWRZb0hlYkdlMlFLTDJkUmxxRVljd2lXbXZC?= =?utf-8?B?bWxSWmxIYmVMbk5QdzBUMTZRWG13WC85NnJUa2cycDh0bFpGdCtaZlhFQjN5?= =?utf-8?B?cnVhWDJ2YXNrRnlhbWtyQkJ2UThkMEZYbzBLVGR0UFY2Q3lUbEc5S3VKdWln?= =?utf-8?B?VCtHOTZpN2wvdnd0UWJFQ3VmUkxqMjc0cUFvWnNyV0FjWW5hMGhLblRjN21m?= =?utf-8?B?Vm9WU3ZVMXRRYStpQVJSQ1BndWY1S1ZSWkl6WElaUkNZeURJbXFNbFRFYU5v?= =?utf-8?B?dmpMbVZvaGljQkxMcVJTak1nUWJBMFV6cWg4R3pLUjh6VkgwcjdEc2xiNTZL?= =?utf-8?B?Y0dMUndLMnhrZ3UvS05UaVlkckhmLzhWVkR1dTZycTZxNmZzVlVhcnRId1kw?= =?utf-8?B?M0M1bU1nc2w1bDlaTmkzaGxZbjVTbG5iRjZNRldkM0ZFQU1pTDZnVzZ0N1RG?= =?utf-8?B?ZlJQb3NaUzk0SklyeUdVK3MwQVlCa3Fjcjc4UStRNTlHVXBXMGRiN1pVeEQ1?= =?utf-8?B?SUxqVVJrQmw0UVZMVUxqZkdaQVVHQ3RObjhkS1dUK2diaURhQlVlM0ZwK3Iw?= =?utf-8?B?bkxYNExoYXdkZkRoU0N4VVdsczcvYVhSRDVFajdnMGZqRUhNNzJkVXlSK3ZS?= =?utf-8?B?WWpGb2l5OWhzVzRkOUR0Z0w0WVluU2xFTGhWeTVucDRsVFJ3ZDF6VmVOcG83?= =?utf-8?B?NFBnNzlYTEZxM1BpTUhQZ212VlZaSEY5bTRmeDQrck1QTVpBa0xtWmkybFMz?= =?utf-8?B?RHFsNjM0WFo1ZTF1TU9qWDhWeDROYnNFMUhrdnRiZDdTaW5jSUVZQjhnWUw5?= =?utf-8?B?aW44djhKc29Dd3N5VVN5NWJlUGplMExXUzJzeVBPc2F3S3I5UkxQUmdWU21J?= =?utf-8?B?dCtDaVBHbjNmY2NjazhMOWtsTU9RcWFYZGxHRHpYWitmMmxHWEpFelpwckVy?= =?utf-8?B?bmF6NXJxcVRGT041OVBXUy9UaTdVaE8wR1kveEc3bmRGZEdQRks1RFU5ME5V?= =?utf-8?B?bE5OYlVnQ1RTeUE0UzIzTjRTb0tMSDlucmZ4eTRlRzdQS1RMM01zMGorOE0w?= =?utf-8?B?MUE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: a0eQV9svz8HuGG+FDncfgzHKISzcV7MdHy51cUCgrj3nMlngf6d3TKxf1ZHOxoE3sxGq/8PRQfkf8DHEqtUUChOEC25xVrVbdGW1qJFwBgqs0VzdUfsIdjciQ16vzWWwn4AVGGrBkTuJpcV/lZoyykOcKM3bwFLIrPLYAwlpnG2rkSmoaNMB6awI2dBshL+bcUURuaRjaDuEpLpBZogCcuv8aKU4pATykisj8p2EewGM6ympSNsBKlcPXs6lMgZ1ImWE4ZOvkUQunvTtws/l5gDYOH1eQLE2m3AC6q5/OLGlwEACkZHbHc9jmvWLjl04srUtOcxdTSPkMPawHlnrf92KcUtpwrLgwdo0oDbiQTLP9fVrL2VhP+Vc7Uapguhi1lJa/87teF8dM7uMDrIL9+Ps/UvndmPJDW2sXzAZ3rDv5dG9WO9f8HW25QVoui23sRk64mDlwxRQ3BxGj40JjZdMboxBJOfIy46sADch4dg44GQjvc2d1GJ8H/vTEtm/sHQHrWYOgj3MsyaOipPiIjblvIVMtPYIrmEkwZG1xcPDhOtLusG+wb4lmPgypW3tpTL87ncLhxGVlZNSTwJWVPnEkiFRmhLq4OYH2Wfx3owCaYLVZfQ6XeZMjoBcmovAAiRZaiuSI4iqTco7cqQgU6R2UeeUWJYFDwoUS3ko7ef+SbVd1WkqdpbTc2MfOIQ1lSpW32s5FNPmxxt+/EnRzV/cma1DOakvC8FAMCRbECNXkIwyc1SgbS0jK8+kAeaSPVNSSgH9nriyCO05raHQ7bemN9rTYC9psin7YCIdaWSfvQyMzsxk7KLRM/wHlvKgE3qK4GfFvNzQT0vpg7FNjZ6AWzNkjY+2fAJ2rd2DGvQ= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6004c88-bbb9-43ff-c876-08db0b97c89c X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 18:51:14.0023 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xrKiGyiIDTStX+ytGR+lWiWa5p+0eanqcd8k0EPicHAsMZHyW6bWYSOvAve7l6fJ6JnCfGPMUY53+i7tPnZXp493qUv9jqHm5e4RJCudaKc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6138 On 10/02/2023 12:44 pm, Samuel Thibault wrote: > Juergen Gross, le ven. 10 févr. 2023 13:14:20 +0100, a ecrit: >> On 10.02.23 12:43, Andrew Cooper wrote: >>> On 10/02/2023 10:46 am, Juergen Gross wrote: >>>> diff --git a/lib/sys.c b/lib/sys.c >>>> index 2f33c937..dc8a8c69 100644 >>>> --- a/lib/sys.c >>>> +++ b/lib/sys.c >>>> @@ -339,7 +339,14 @@ static int open_mem(struct mount_point *mnt, const char *pathname, int flags, >>>> return fd; >>>> } >>>> -static struct mount_point mount_points[] = { >>>> +#ifdef CONFIG_CONSFRONT >>>> +#define STATIC_MNTS 4 >>>> +#else >>>> +#define STATIC_MNTS 2 >>>> +#endif >>> This ought to be >>> >>> #define STATIC_MNTS (2 + (IS_ENABLED(CONFIG_CONSFRONT) * 2)) >>> >>> because it shows where the parts come from, and is much cleaner to add a >>> 3rd one to in due course. >> In principle fine, but I'm not sure it is worth the effort to add >> IS_ENABLED() support to Mini-OS. >> >>> That said, it would be simpler to just have a total mounts set at 16 or >>> so?  Does a difference of two dynamic mounts depending on CONSFRONT >>> actually matter? >> Probably not. Samuel, any thoughts on that? > We can probably as well just have 16 mount entries indeed. I'm happy to fix that up on commit if it's the only other issue in this patch. ~Andrew From minios-devel-bounces@lists.xenproject.org Fri Feb 10 18:53:37 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 10 Feb 2023 18:53:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493583.763573 (Exim 4.92) (envelope-from ) id 1pQYWd-0006Jj-5l; Fri, 10 Feb 2023 18:53:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493583.763573; Fri, 10 Feb 2023 18:53:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYWd-0006Jc-3J; Fri, 10 Feb 2023 18:53:35 +0000 Received: by outflank-mailman (input) for mailman id 493583; Fri, 10 Feb 2023 18:53:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYWb-0006J4-JZ for minios-devel@lists.xenproject.org; Fri, 10 Feb 2023 18:53:33 +0000 Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 355a1b2a-a974-11ed-93b5-47a8fe42b414; Fri, 10 Feb 2023 19:53:29 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 51E1320162; Fri, 10 Feb 2023 19:53:29 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5qNXIv7BGRAa; Fri, 10 Feb 2023 19:53:29 +0100 (CET) Received: from begin (lfbn-bor-1-1163-184.w92-158.abo.wanadoo.fr [92.158.138.184]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 2AD872015E; Fri, 10 Feb 2023 19:53:29 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pQYWW-006gXg-2V; Fri, 10 Feb 2023 19:53:28 +0100 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 355a1b2a-a974-11ed-93b5-47a8fe42b414 Date: Fri, 10 Feb 2023 19:53:28 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH v2 6/7] Mini-OS: add open and close handling to the 9pfs frontend Message-ID: <20230210185328.2zqo5xvklpke3ie2@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230210104628.14374-1-jgross@suse.com> <20230210104628.14374-7-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230210104628.14374-7-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le ven. 10 févr. 2023 11:46:27 +0100, a ecrit: > +static bool path_canonical(const char *pathname) > +{ > + unsigned int len = strlen(pathname); > + const char *c; > + > + /* Empty path is allowed. */ > + if ( !len ) > + return true; > + > + /* No trailing '/'. */ > + if ( pathname[len - 1] == '/' ) > + return false; > + > + /* No self or parent references. */ > + c = pathname; > + while ( (c = strstr(c, "/.")) != NULL ) > + { > + if ( c[2] == '.' ) > + c++; > + if ( c[2] == 0 || c[2] == '/' ) > + return false; > + c += 2; > + } > + > + return true; > +} This doesn't seem to be catching "//"? Samuel From minios-devel-bounces@lists.xenproject.org Fri Feb 10 18:59:22 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 10 Feb 2023 18:59:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493594.763588 (Exim 4.92) (envelope-from ) id 1pQYcC-0007C3-TW; Fri, 10 Feb 2023 18:59:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493594.763588; Fri, 10 Feb 2023 18:59:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYcC-0007Bw-R0; Fri, 10 Feb 2023 18:59:20 +0000 Received: by outflank-mailman (input) for mailman id 493594; Fri, 10 Feb 2023 18:59:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYcB-0007Bl-GM for minios-devel@lists.xenproject.org; Fri, 10 Feb 2023 18:59:19 +0000 Received: from sonata.ens-lyon.org (sonata.ens-lyon.org [140.77.166.138]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 04fc30ba-a975-11ed-933c-83870f6b2ba8; Fri, 10 Feb 2023 19:59:18 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 9912B20162; Fri, 10 Feb 2023 19:59:17 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sn_dddDhMJVD; Fri, 10 Feb 2023 19:59:17 +0100 (CET) Received: from begin (lfbn-bor-1-1163-184.w92-158.abo.wanadoo.fr [92.158.138.184]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 6B9572015E; Fri, 10 Feb 2023 19:59:17 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pQYc8-006ghi-2H; Fri, 10 Feb 2023 19:59:16 +0100 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 04fc30ba-a975-11ed-933c-83870f6b2ba8 Date: Fri, 10 Feb 2023 19:59:16 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH v2 7/7] Mini-OS: add read and write support to 9pfsfront Message-ID: <20230210185916.2qjo6yh7c3usheyp@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230210104628.14374-1-jgross@suse.com> <20230210104628.14374-8-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230210104628.14374-8-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le ven. 10 févr. 2023 11:46:28 +0100, a ecrit: > + while ( len ) > + { > + count = len; > + if ( count > dev->msize_max - 24 ) > + count = dev->msize_max - 24; 24 should be detailed, to include e.g. sizeof(p9_header) and the sum of sizes of the fields (I'm surprised that it's the same 24 for read and write, notably). > + send_9p(dev, req, "ULU", fid, offset, count); > + rcv_9p(dev, req, "D", &count, data); > + > + if ( !count ) > + break; > + if ( req->result ) > + { > + ret = -1; > + errno = EIO; I'd say log req->result? > + break; > + } > + ret += count; > + offset += count; > + data += count; > + len -= count; > + } > + > + put_free_req(dev, req); > + > + return ret; > +} > + > +static int p9_write(struct dev_9pfs *dev, uint32_t fid, uint64_t offset, > + const uint8_t *data, uint32_t len) > +{ > + struct req *req = get_free_req(dev); > + int ret = 0; > + uint32_t count; > + > + if ( !req ) > + { > + errno = EAGAIN; > + return -1; > + } > + req->cmd = P9_CMD_WRITE; > + > + while ( len ) > + { > + count = len; > + if ( count > dev->msize_max - 24 ) > + count = dev->msize_max - 24; Same here. > + send_9p(dev, req, "ULD", fid, offset, count, data); > + rcv_9p(dev, req, "U", &count); > + if ( req->result ) > + { > + ret = -1; > + errno = EIO; Same here. > + break; > + } > + ret += count; > + offset += count; > + data += count; > + len -= count; > + } > + > + put_free_req(dev, req); > + > + return ret; > +} From minios-devel-bounces@lists.xenproject.org Sat Feb 11 06:24:11 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Sat, 11 Feb 2023 06:24:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493787.763819 (Exim 4.92) (envelope-from ) id 1pQjIr-00038d-0o; Sat, 11 Feb 2023 06:24:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493787.763819; Sat, 11 Feb 2023 06:24:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQjIq-00037W-SC; Sat, 11 Feb 2023 06:24:04 +0000 Received: by outflank-mailman (input) for mailman id 493787; Sat, 11 Feb 2023 06:24:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQjIp-00035D-7k for minios-devel@lists.xenproject.org; Sat, 11 Feb 2023 06:24:03 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aa859200-a9d4-11ed-93b5-47a8fe42b414; Sat, 11 Feb 2023 07:23:58 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 630743393C; Sat, 11 Feb 2023 06:23:57 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3958D13A1F; Sat, 11 Feb 2023 06:23:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id R6MCDH0052P2WQAAMHmgww (envelope-from ); Sat, 11 Feb 2023 06:23:57 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: aa859200-a9d4-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676096637; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ehoRu52+j8qFCI7ZreeVaH5N+q71cuyzpByv070ySv0=; b=Enygx9O/MBsKiHnsvacdeEpoog/KNaGx0fXa2FhFjHslH5LbXvC02zy5z8JYMAUiLiAa8X OAZXoui9OcCi/yB5H4Np6Ut0mpnGelm6R4oRwpzzf5apx3MG/nWKzukp8yMTTRg98taTTW 2Ft5qJNsQMFlJpckS1LgrP86qejFpcw= Message-ID: <7309a521-7c8c-41c7-eae7-fa3d4c08f4f7@suse.com> Date: Sat, 11 Feb 2023 07:23:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 6/7] Mini-OS: add open and close handling to the 9pfs frontend Content-Language: en-US To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230210104628.14374-1-jgross@suse.com> <20230210104628.14374-7-jgross@suse.com> <20230210185328.2zqo5xvklpke3ie2@begin> From: Juergen Gross In-Reply-To: <20230210185328.2zqo5xvklpke3ie2@begin> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------c1aQ0FFzOSLQ01YXxZ3gM7P8" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------c1aQ0FFzOSLQ01YXxZ3gM7P8 Content-Type: multipart/mixed; boundary="------------K2w4L4SAQl3Vl94ujbCyYKK7"; protected-headers="v1" From: Juergen Gross To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Message-ID: <7309a521-7c8c-41c7-eae7-fa3d4c08f4f7@suse.com> Subject: Re: [PATCH v2 6/7] Mini-OS: add open and close handling to the 9pfs frontend References: <20230210104628.14374-1-jgross@suse.com> <20230210104628.14374-7-jgross@suse.com> <20230210185328.2zqo5xvklpke3ie2@begin> In-Reply-To: <20230210185328.2zqo5xvklpke3ie2@begin> --------------K2w4L4SAQl3Vl94ujbCyYKK7 Content-Type: multipart/mixed; boundary="------------X2SoR0QsTVz1xze8Z5c00D8n" --------------X2SoR0QsTVz1xze8Z5c00D8n Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTAuMDIuMjMgMTk6NTMsIFNhbXVlbCBUaGliYXVsdCB3cm90ZToNCj4gSnVlcmdlbiBH cm9zcywgbGUgdmVuLiAxMCBmw6l2ci4gMjAyMyAxMTo0NjoyNyArMDEwMCwgYSBlY3JpdDoN Cj4+ICtzdGF0aWMgYm9vbCBwYXRoX2Nhbm9uaWNhbChjb25zdCBjaGFyICpwYXRobmFtZSkN Cj4+ICt7DQo+PiArICAgIHVuc2lnbmVkIGludCBsZW4gPSBzdHJsZW4ocGF0aG5hbWUpOw0K Pj4gKyAgICBjb25zdCBjaGFyICpjOw0KPj4gKw0KPj4gKyAgICAvKiBFbXB0eSBwYXRoIGlz IGFsbG93ZWQuICovDQo+PiArICAgIGlmICggIWxlbiApDQo+PiArICAgICAgICByZXR1cm4g dHJ1ZTsNCj4+ICsNCj4+ICsgICAgLyogTm8gdHJhaWxpbmcgJy8nLiAqLw0KPj4gKyAgICBp ZiAoIHBhdGhuYW1lW2xlbiAtIDFdID09ICcvJyApDQo+PiArICAgICAgICByZXR1cm4gZmFs c2U7DQo+PiArDQo+PiArICAgIC8qIE5vIHNlbGYgb3IgcGFyZW50IHJlZmVyZW5jZXMuICov DQo+PiArICAgIGMgPSBwYXRobmFtZTsNCj4+ICsgICAgd2hpbGUgKCAoYyA9IHN0cnN0cihj LCAiLy4iKSkgIT0gTlVMTCApDQo+PiArICAgIHsNCj4+ICsgICAgICAgIGlmICggY1syXSA9 PSAnLicgKQ0KPj4gKyAgICAgICAgICAgIGMrKzsNCj4+ICsgICAgICAgIGlmICggY1syXSA9 PSAwIHx8IGNbMl0gPT0gJy8nICkNCj4+ICsgICAgICAgICAgICByZXR1cm4gZmFsc2U7DQo+ PiArICAgICAgICBjICs9IDI7DQo+PiArICAgIH0NCj4+ICsNCj4+ICsgICAgcmV0dXJuIHRy dWU7DQo+PiArfQ0KPiANCj4gVGhpcyBkb2Vzbid0IHNlZW0gdG8gYmUgY2F0Y2hpbmcgIi8v Ij8NCg0KT2gsIHNpbGx5IG1lIQ0KDQoNCkp1ZXJnZW4NCg0K --------------X2SoR0QsTVz1xze8Z5c00D8n Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------X2SoR0QsTVz1xze8Z5c00D8n-- --------------K2w4L4SAQl3Vl94ujbCyYKK7-- --------------c1aQ0FFzOSLQ01YXxZ3gM7P8 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPnNHwFAwAAAAAACgkQsN6d1ii/Ey8q hAf+LEyNJVeHchISPO3V/7N8ggVBC9SnwgHu/8vcF3mSNd2Xy7tUOKg94zjm3AhOc1/Vv9KeoxcY 9/1WqNx/Lyd11Y1e8W0swsBXEZOEdjHpgOBvh3CENgAC63+KB8otWtaxqrnGCTRd2c/L2c1Gc/j5 laMnYVrRG5hwbWg10CSOcjQ4oQIcikM7jPfL2LMvzLVNQtqRJwF1DZiTbWbpvUtyK1v5nTbGHVlv Gg6ki22g6NlbweyP7zDl+PQCxD0gfoM1QnwxQj5Ug3IdzKwz7+fWhWxM+uuCp6vL5tL/AgIFAKPy hFcYbEbwx0A1rtu4WVYWBV/i5cJCge2xKqWQC5Gctg== =v4pe -----END PGP SIGNATURE----- --------------c1aQ0FFzOSLQ01YXxZ3gM7P8-- From minios-devel-bounces@lists.xenproject.org Mon Feb 13 06:48:00 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 13 Feb 2023 06:48:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494134.764100 (Exim 4.92) (envelope-from ) id 1pRScz-0003kC-Uj; Mon, 13 Feb 2023 06:47:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494134.764100; Mon, 13 Feb 2023 06:47:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRScz-0003k5-Rl; Mon, 13 Feb 2023 06:47:53 +0000 Received: by outflank-mailman (input) for mailman id 494134; Mon, 13 Feb 2023 06:47:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRScy-0003Uy-8S for minios-devel@lists.xenproject.org; Mon, 13 Feb 2023 06:47:52 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5364316a-ab6a-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 07:47:48 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EDAB835354; Mon, 13 Feb 2023 06:47:46 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B64C11391B; Mon, 13 Feb 2023 06:47:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id bCkYKhLd6WOzDAAAMHmgww (envelope-from ); Mon, 13 Feb 2023 06:47:46 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 5364316a-ab6a-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676270866; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NlMwrQ+B8I/w6bXL/LW7Sau/IV5bLsON9okQ/ZmOaxI=; b=Q0vWAxLIJptSJLevPEJt2ZjLTlA+dagTglf+Fdm1Mz5itMGe95i7Uphqk7aH1qZulE9LGj E+BXB+1MvbQCxvjWrVZEr8xO868+CtiAyO52EW6ZdD/o4pzs4hgJ8PBnJNrzWe50RB3aX6 qSQ9ybD1O9VNaWBG6Ukqk6sGpdDqeR0= Message-ID: <7e4efddc-2006-5092-d025-0a431cda5957@suse.com> Date: Mon, 13 Feb 2023 07:47:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 7/7] Mini-OS: add read and write support to 9pfsfront Content-Language: en-US To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230210104628.14374-1-jgross@suse.com> <20230210104628.14374-8-jgross@suse.com> <20230210185916.2qjo6yh7c3usheyp@begin> From: Juergen Gross In-Reply-To: <20230210185916.2qjo6yh7c3usheyp@begin> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------PrFEyCxYjiP4ohKFKzj6DVV2" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------PrFEyCxYjiP4ohKFKzj6DVV2 Content-Type: multipart/mixed; boundary="------------fqimO9s0fMTKrHoCeSwrp6ZL"; protected-headers="v1" From: Juergen Gross To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Message-ID: <7e4efddc-2006-5092-d025-0a431cda5957@suse.com> Subject: Re: [PATCH v2 7/7] Mini-OS: add read and write support to 9pfsfront References: <20230210104628.14374-1-jgross@suse.com> <20230210104628.14374-8-jgross@suse.com> <20230210185916.2qjo6yh7c3usheyp@begin> In-Reply-To: <20230210185916.2qjo6yh7c3usheyp@begin> --------------fqimO9s0fMTKrHoCeSwrp6ZL Content-Type: multipart/mixed; boundary="------------Y6e47tOoLmM0IZqFj560FLQV" --------------Y6e47tOoLmM0IZqFj560FLQV Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTAuMDIuMjMgMTk6NTksIFNhbXVlbCBUaGliYXVsdCB3cm90ZToNCj4gSnVlcmdlbiBH cm9zcywgbGUgdmVuLiAxMCBmw6l2ci4gMjAyMyAxMTo0NjoyOCArMDEwMCwgYSBlY3JpdDoN Cj4+ICsgICAgd2hpbGUgKCBsZW4gKQ0KPj4gKyAgICB7DQo+PiArICAgICAgICBjb3VudCA9 IGxlbjsNCj4+ICsgICAgICAgIGlmICggY291bnQgPiBkZXYtPm1zaXplX21heCAtIDI0ICkN Cj4+ICsgICAgICAgICAgICBjb3VudCA9IGRldi0+bXNpemVfbWF4IC0gMjQ7DQo+IA0KPiAy NCBzaG91bGQgYmUgZGV0YWlsZWQsIHRvIGluY2x1ZGUgZS5nLiBzaXplb2YocDlfaGVhZGVy KSBhbmQgdGhlIHN1bSBvZg0KPiBzaXplcyBvZiB0aGUgZmllbGRzIChJJ20gc3VycHJpc2Vk IHRoYXQgaXQncyB0aGUgc2FtZSAyNCBmb3IgcmVhZCBhbmQNCj4gd3JpdGUsIG5vdGFibHkp Lg0KDQpJdCB3YXMganVzdCBhIGNvbW1vbiB2YWx1ZSBjaG9zZW4gdG8gYmUgbGFyZ2UgZW5v dWdoLiBJIGV2ZW4gY29uc2lkZXJlZA0KdG8gbGltaXQgdG8gYSBwb3dlciBvZiAyIG9yIGEg bXVsdGlwbGUgb2YgUEFHRV9TSVpFIGluc3RlYWQuDQoNCkluZGVwZW5kZW50IGZyb20gdGhl IGNob3NlbiBuZXcgdmFsdWUgb2YgY291bnQgSSBhZ3JlZSwgdGhhdCBhdCBsZWFzdCB0aGUN CnRlc3QgZm9yIGNvdW50IG5lZWRpbmcgdG8gYmUgbW9kaWZpZWQgc2hvdWxkIGJlIGRvbmUg d2l0aCBhbiBleGFjdCB2YWx1ZQ0KZm9yIHRoZSB1cHBlciBsaW1pdC4NCg0KPiANCj4+ICsg ICAgICAgIHNlbmRfOXAoZGV2LCByZXEsICJVTFUiLCBmaWQsIG9mZnNldCwgY291bnQpOw0K Pj4gKyAgICAgICAgcmN2XzlwKGRldiwgcmVxLCAiRCIsICZjb3VudCwgZGF0YSk7DQo+PiAr DQo+PiArICAgICAgICBpZiAoICFjb3VudCApDQo+PiArICAgICAgICAgICAgYnJlYWs7DQo+ PiArICAgICAgICBpZiAoIHJlcS0+cmVzdWx0ICkNCj4+ICsgICAgICAgIHsNCj4+ICsgICAg ICAgICAgICByZXQgPSAtMTsNCj4+ICsgICAgICAgICAgICBlcnJubyA9IEVJTzsNCj4gDQo+ IEknZCBzYXkgbG9nIHJlcS0+cmVzdWx0Pw0KDQpPa2F5Lg0KDQo+IA0KPj4gKyAgICAgICAg ICAgIGJyZWFrOw0KPj4gKyAgICAgICAgfQ0KPj4gKyAgICAgICAgcmV0ICs9IGNvdW50Ow0K Pj4gKyAgICAgICAgb2Zmc2V0ICs9IGNvdW50Ow0KPj4gKyAgICAgICAgZGF0YSArPSBjb3Vu dDsNCj4+ICsgICAgICAgIGxlbiAtPSBjb3VudDsNCj4+ICsgICAgfQ0KPj4gKw0KPj4gKyAg ICBwdXRfZnJlZV9yZXEoZGV2LCByZXEpOw0KPj4gKw0KPj4gKyAgICByZXR1cm4gcmV0Ow0K Pj4gK30NCj4+ICsNCj4+ICtzdGF0aWMgaW50IHA5X3dyaXRlKHN0cnVjdCBkZXZfOXBmcyAq ZGV2LCB1aW50MzJfdCBmaWQsIHVpbnQ2NF90IG9mZnNldCwNCj4+ICsgICAgICAgICAgICAg ICAgICAgIGNvbnN0IHVpbnQ4X3QgKmRhdGEsIHVpbnQzMl90IGxlbikNCj4+ICt7DQo+PiAr ICAgIHN0cnVjdCByZXEgKnJlcSA9IGdldF9mcmVlX3JlcShkZXYpOw0KPj4gKyAgICBpbnQg cmV0ID0gMDsNCj4+ICsgICAgdWludDMyX3QgY291bnQ7DQo+PiArDQo+PiArICAgIGlmICgg IXJlcSApDQo+PiArICAgIHsNCj4+ICsgICAgICAgIGVycm5vID0gRUFHQUlOOw0KPj4gKyAg ICAgICAgcmV0dXJuIC0xOw0KPj4gKyAgICB9DQo+PiArICAgIHJlcS0+Y21kID0gUDlfQ01E X1dSSVRFOw0KPj4gKw0KPj4gKyAgICB3aGlsZSAoIGxlbiApDQo+PiArICAgIHsNCj4+ICsg ICAgICAgIGNvdW50ID0gbGVuOw0KPj4gKyAgICAgICAgaWYgKCBjb3VudCA+IGRldi0+bXNp emVfbWF4IC0gMjQgKQ0KPj4gKyAgICAgICAgICAgIGNvdW50ID0gZGV2LT5tc2l6ZV9tYXgg LSAyNDsNCj4gDQo+IFNhbWUgaGVyZS4NCg0KWWVzLg0KDQo+IA0KPj4gKyAgICAgICAgc2Vu ZF85cChkZXYsIHJlcSwgIlVMRCIsIGZpZCwgb2Zmc2V0LCBjb3VudCwgZGF0YSk7DQo+PiAr ICAgICAgICByY3ZfOXAoZGV2LCByZXEsICJVIiwgJmNvdW50KTsNCj4+ICsgICAgICAgIGlm ICggcmVxLT5yZXN1bHQgKQ0KPj4gKyAgICAgICAgew0KPj4gKyAgICAgICAgICAgIHJldCA9 IC0xOw0KPj4gKyAgICAgICAgICAgIGVycm5vID0gRUlPOw0KPiANCj4gU2FtZSBoZXJlLg0K DQpZZXMuDQoNCg0KSnVlcmdlbg0K --------------Y6e47tOoLmM0IZqFj560FLQV Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------Y6e47tOoLmM0IZqFj560FLQV-- --------------fqimO9s0fMTKrHoCeSwrp6ZL-- --------------PrFEyCxYjiP4ohKFKzj6DVV2 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB4BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPp3RIFAwAAAAAACgkQsN6d1ii/Ey/1 SAf3c8XTGStAtXmFWG6YRrJNI2dReIKhzTCgnvFNY/C4vqoYWrFVf6zLeawbNRgomE285h8PjMiM LxtkiZpGqLp4pBVG+MNoJaUNO40HmjmMkjepKhgj0xw2hE/ieHFacJ0vfR8vJ32JVgzhh4Q19+d2 PxUiPp4JbQKUaoMUVeiJMALCv/df1nDAc9AN/W1h5+JLIGMxzsdbZcfeYm2+By2YZrJzeUHmYwYh roSIdX5pHzJ3gXvS5T4SKkuTjfd5o3mGtOKW3IE/c3RO3UgyKgnmQqXe0qXvvXqU87esLbrFBttQ IsoKE9j31xyJTgNIEb+E7+8qgkqNLcapfNmAU36w =XyW/ -----END PGP SIGNATURE----- --------------PrFEyCxYjiP4ohKFKzj6DVV2-- From minios-devel-bounces@lists.xenproject.org Mon Feb 13 08:44:25 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 13 Feb 2023 08:44:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494208.764219 (Exim 4.92) (envelope-from ) id 1pRURk-0005aq-A0; Mon, 13 Feb 2023 08:44:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494208.764219; Mon, 13 Feb 2023 08:44:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRURk-0005af-5Y; Mon, 13 Feb 2023 08:44:24 +0000 Received: by outflank-mailman (input) for mailman id 494208; Mon, 13 Feb 2023 08:44:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRURi-00053b-Ix for minios-devel@lists.xenproject.org; Mon, 13 Feb 2023 08:44:22 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9bda6e54-ab7a-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 09:44:20 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 95DCF67B09; Mon, 13 Feb 2023 08:44:21 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6D2A21391B; Mon, 13 Feb 2023 08:44:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id VAl9GWX46WMuRAAAMHmgww (envelope-from ); Mon, 13 Feb 2023 08:44:21 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 9bda6e54-ab7a-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676277861; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U4WUHNcXaKUs5EWJgyYOwx2UyA3oTZifWWQZCeAXA8E=; b=r91MzCy85Iz1/IfPwuNm+gVo6sS8uA04Tq51j4D7DN/0uBFeYTGxHmfLk5yiywCZbf8d6T udqXCa918VMQ+NMjKC7jCIr1fSLuylUAGZkkgITcfp8L0vXHP6QalG4N/BOyWNkewUwjCA eZVNhUqOzaW/mjJ2D+Bx2trwCwEyO4k= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH v3 1/7] Mini-OS: xenbus: add support for reading node from directory Date: Mon, 13 Feb 2023 09:44:06 +0100 Message-Id: <20230213084412.21065-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230213084412.21065-1-jgross@suse.com> References: <20230213084412.21065-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Especially PV device drivers often need to read multiple Xenstore nodes from a common directory. Add support for reading a string or an unsigned value by specifying the directory and the node. Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault --- V2: - check sscanf() return value (Samuel Thibault) --- include/xenbus.h | 6 ++++++ xenbus.c | 40 +++++++++++++++++++++++++++++++++++++--- 2 files changed, 43 insertions(+), 3 deletions(-) diff --git a/include/xenbus.h b/include/xenbus.h index 3871f358..c0fc0ac5 100644 --- a/include/xenbus.h +++ b/include/xenbus.h @@ -108,6 +108,12 @@ int xenbus_read_integer(const char *path); * read and parsing were successful, 0 if not */ int xenbus_read_uuid(const char* path, unsigned char uuid[16]); +/* Support functions for reading values from directory/node tuple. */ +char *xenbus_read_string(xenbus_transaction_t xbt, const char *dir, + const char *node, char **value); +char *xenbus_read_unsigned(xenbus_transaction_t xbt, const char *dir, + const char *node, unsigned int *value); + /* Contraction of snprintf and xenbus_write(path/node). */ char* xenbus_printf(xenbus_transaction_t xbt, const char* node, const char* path, diff --git a/xenbus.c b/xenbus.c index 81e9b65d..923e8181 100644 --- a/xenbus.c +++ b/xenbus.c @@ -936,16 +936,21 @@ int xenbus_read_uuid(const char *path, unsigned char uuid[16]) return 1; } +#define BUFFER_SIZE 256 +static void xenbus_build_path(const char *dir, const char *node, char *res) +{ + BUG_ON(strlen(dir) + strlen(node) + 1 >= BUFFER_SIZE); + sprintf(res,"%s/%s", dir, node); +} + char *xenbus_printf(xenbus_transaction_t xbt, const char* node, const char* path, const char* fmt, ...) { -#define BUFFER_SIZE 256 char fullpath[BUFFER_SIZE]; char val[BUFFER_SIZE]; va_list args; - BUG_ON(strlen(node) + strlen(path) + 1 >= BUFFER_SIZE); - sprintf(fullpath,"%s/%s", node, path); + xenbus_build_path(node, path, fullpath); va_start(args, fmt); vsprintf(val, fmt, args); va_end(args); @@ -964,6 +969,35 @@ domid_t xenbus_get_self_id(void) return ret; } +char *xenbus_read_string(xenbus_transaction_t xbt, const char *dir, + const char *node, char **value) +{ + char path[BUFFER_SIZE]; + + xenbus_build_path(dir, node, path); + + return xenbus_read(xbt, path, value); +} + +char *xenbus_read_unsigned(xenbus_transaction_t xbt, const char *dir, + const char *node, unsigned int *value) +{ + char path[BUFFER_SIZE]; + char *msg; + char *str; + + xenbus_build_path(dir, node, path); + msg = xenbus_read(xbt, path, &str); + if ( msg ) + return msg; + + if ( sscanf(str, "%u", value) != 1 ) + msg = strdup("EINVAL"); + free(str); + + return msg; +} + /* * Local variables: * mode: C -- 2.35.3 From minios-devel-bounces@lists.xenproject.org Mon Feb 13 08:44:26 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 13 Feb 2023 08:44:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494206.764198 (Exim 4.92) (envelope-from ) id 1pRURi-00056w-0X; Mon, 13 Feb 2023 08:44:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494206.764198; Mon, 13 Feb 2023 08:44:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRURh-00055y-Rp; Mon, 13 Feb 2023 08:44:21 +0000 Received: by outflank-mailman (input) for mailman id 494206; Mon, 13 Feb 2023 08:44:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRURg-00053b-HI for minios-devel@lists.xenproject.org; Mon, 13 Feb 2023 08:44:20 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 98b9f786-ab7a-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 09:44:17 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0C5A367B09; Mon, 13 Feb 2023 08:44:16 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CF8141391B; Mon, 13 Feb 2023 08:44:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id aBtHMV/46WMoRAAAMHmgww (envelope-from ); Mon, 13 Feb 2023 08:44:15 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 98b9f786-ab7a-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676277856; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=2TpvI14vjytLk+fJ6jQ6L4mTK2f8+asinqiPiJO4Cp8=; b=dF9Q7GVGtTjlVr5s7SWi6e7UVCaS3Pz8GB7geRxBSHm6ACnbQhmVy5seqA4Yu/+XSOtFuW goRiQVr8m40NdjQQ5hM/oPsJvLjCbQ1L+01XdSvYc/ub8XfNgFqedc776kPf5GV//AA5vc Dbnqt0/9PP2oO906XoBY1Z5jNZKxzXY= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH v3 0/7] Mini-OS: add minimal 9pfs support Date: Mon, 13 Feb 2023 09:44:05 +0100 Message-Id: <20230213084412.21065-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series is adding minimal support to use 9pfs in Mini-OS. It is adding a PV 9pfs frontend and the ability to open, close, read and write files. The series has been tested with qemu as 9pfs backend in a PVH Mini-OS guest (I've used a slightly modified Xenstore-stubdom for that purpose in order to reuse the build runes). This series is meant to setup the stage for adding file based logging support to Xenstore-stubdom and later to add live update support (being able to save the LU data stream in a dom0 file makes this a _lot_ easier). In order to keep Mini-OS's license I have only used the protocol docs available on the internet [1] and then verified those with the qemu 9pfs backend implementation (especially for supporting the 9P2000.u variant, as qemu doesn't support the basic 9P2000 protocol). The needed fixed values of the protocol have been taken from [2]. [1]: http://ericvh.github.io/9p-rfc/rfc9p2000.html [2]: https://github.com/0intro/libixp Changes in V2: - addressed comments by Samuel Thibault Changes in V3: - addressed comments by Samuel Thibault and Andrew Cooper Juergen Gross (7): Mini-OS: xenbus: add support for reading node from directory Mini-OS: add concept of mount points Mini-OS: add support for runtime mounts Mini-OS: add 9pfs frontend Mini-OS: add 9pfs transport layer Mini-OS: add open and close handling to the 9pfs frontend Mini-OS: add read and write support to 9pfsfront 9pfront.c | 1300 +++++++++++++++++++++++++++++++++ Config.mk | 1 + Makefile | 1 + arch/x86/testbuild/all-no | 1 + arch/x86/testbuild/all-yes | 1 + arch/x86/testbuild/newxen-yes | 1 + include/9pfront.h | 7 + include/lib.h | 14 + include/xenbus.h | 6 + lib/sys.c | 123 +++- xenbus.c | 40 +- 11 files changed, 1473 insertions(+), 22 deletions(-) create mode 100644 9pfront.c create mode 100644 include/9pfront.h -- 2.35.3 From minios-devel-bounces@lists.xenproject.org Mon Feb 13 08:44:29 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 13 Feb 2023 08:44:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494209.764222 (Exim 4.92) (envelope-from ) id 1pRURp-0005hF-B6; Mon, 13 Feb 2023 08:44:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494209.764222; Mon, 13 Feb 2023 08:44:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRURp-0005h4-7P; Mon, 13 Feb 2023 08:44:29 +0000 Received: by outflank-mailman (input) for mailman id 494209; Mon, 13 Feb 2023 08:44:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRURo-00053b-A4 for minios-devel@lists.xenproject.org; Mon, 13 Feb 2023 08:44:28 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9f3030d6-ab7a-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 09:44:26 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 30DED37870; Mon, 13 Feb 2023 08:44:27 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 03E4E1391B; Mon, 13 Feb 2023 08:44:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id yNUpO2r46WM2RAAAMHmgww (envelope-from ); Mon, 13 Feb 2023 08:44:26 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 9f3030d6-ab7a-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676277867; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=19ujpdeO6r/ntB3v/0hzqQCc5N6kEKU3yTBXBtOtbZg=; b=UxYiQRhP1uw/dAULpCCF9xOTAqeUbO9hm0aaDfQjC1i0wV90bjKIPIzKCsoIV41Aiq+/3K cV8NacSRhsjG58kxQNyVHDGZ+stNlJvON/xNpy6S2L7Q/dfUiMaRgda/eFqjmbcgYNkvLO EL5Y5HLwN8l3iKbedmbWVBMcX3x4Lxo= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH v3 2/7] Mini-OS: add concept of mount points Date: Mon, 13 Feb 2023 09:44:07 +0100 Message-Id: <20230213084412.21065-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230213084412.21065-1-jgross@suse.com> References: <20230213084412.21065-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the concept of mount points to Mini-OS. A mount point is a path associated with a device pointer and an open() callback. A mount point can be either a file (e.g. "/dev/mem") or a directory ("/var/log"). This allows to replace the special casing in the generic open() handling with a generic mount point handling. Prepare the open() callbacks to support creating new files by adding a mode parameter. Additionally add a close() prototype to include/lib.h, as it is missing today. Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault --- V2: - pass path below mount point to open callbacks (Samuel Thibault) --- include/lib.h | 9 ++++++ lib/sys.c | 80 +++++++++++++++++++++++++++++++++++++++------------ 2 files changed, 70 insertions(+), 19 deletions(-) diff --git a/include/lib.h b/include/lib.h index bec99646..36d94ec4 100644 --- a/include/lib.h +++ b/include/lib.h @@ -187,6 +187,13 @@ struct file_ops { bool (*select_wr)(struct file *file); }; +struct mount_point { + const char *path; + int (*open)(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode); + void *dev; +}; + unsigned int alloc_file_type(const struct file_ops *ops); off_t lseek_default(struct file *file, off_t offset, int whence); @@ -198,6 +205,8 @@ int alloc_fd(unsigned int type); void close_all_files(void); extern struct thread *main_thread; void sparse(unsigned long data, size_t size); + +int close(int fd); #endif #endif /* _LIB_H_ */ diff --git a/lib/sys.c b/lib/sys.c index 8f8a3de2..2f33c937 100644 --- a/lib/sys.c +++ b/lib/sys.c @@ -263,11 +263,6 @@ char *getcwd(char *buf, size_t size) return buf; } -#define LOG_PATH "/var/log/" -#define SAVE_PATH "/var/lib/xen" -#define SAVE_CONSOLE 1 -#define RESTORE_CONSOLE 2 - int mkdir(const char *pathname, mode_t mode) { errno = EIO; @@ -286,18 +281,30 @@ int posix_openpt(int flags) return fd; } +static int open_pt(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode) +{ + return posix_openpt(flags); +} + int open_savefile(const char *path, int save) { int fd; char nodename[64]; - snprintf(nodename, sizeof(nodename), "device/console/%d", save ? SAVE_CONSOLE : RESTORE_CONSOLE); + snprintf(nodename, sizeof(nodename), "device/console/%d", save ? 1 : 2); fd = open_consfront(nodename); printk("fd(%d) = open_savefile\n", fd); return fd; } + +static int open_save(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode) +{ + return open_savefile(pathname, flags & O_WRONLY); +} #else int posix_openpt(int flags) { @@ -311,24 +318,59 @@ int open_savefile(const char *path, int save) } #endif -int open(const char *pathname, int flags, ...) +static int open_log(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode) { int fd; + /* Ugly, but fine. */ - if (!strncmp(pathname,LOG_PATH,strlen(LOG_PATH))) { - fd = alloc_fd(FTYPE_CONSOLE); - printk("open(%s) -> %d\n", pathname, fd); - return fd; + fd = alloc_fd(FTYPE_CONSOLE); + printk("open(%s%s) -> %d\n", mnt->path, pathname, fd); + return fd; +} + +static int open_mem(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode) +{ + int fd; + + fd = alloc_fd(FTYPE_MEM); + printk("open(%s%s) -> %d\n", mnt->path, pathname, fd); + return fd; +} + +static struct mount_point mount_points[] = { + { .path = "/var/log", .open = open_log, .dev = NULL }, + { .path = "/dev/mem", .open = open_mem, .dev = NULL }, +#ifdef CONFIG_CONSFRONT + { .path = "/dev/ptmx", .open = open_pt, .dev = NULL }, + { .path = "/var/lib/xen", .open = open_save, .dev = NULL }, +#endif +}; + +int open(const char *pathname, int flags, ...) +{ + unsigned int m, mlen; + struct mount_point *mnt; + mode_t mode = 0; + va_list ap; + + if ( flags & O_CREAT ) + { + va_start(ap, flags); + mode = va_arg(ap, mode_t); + va_end(ap); } - if (!strncmp(pathname, "/dev/mem", strlen("/dev/mem"))) { - fd = alloc_fd(FTYPE_MEM); - printk("open(/dev/mem) -> %d\n", fd); - return fd; + + for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) + { + mnt = mount_points + m; + mlen = strlen(mnt->path); + if ( !strncmp(pathname, mnt->path, mlen) && + (pathname[mlen] == '/' || pathname[mlen] == 0) ) + return mnt->open(mnt, pathname + mlen, flags, mode); } - if (!strncmp(pathname, "/dev/ptmx", strlen("/dev/ptmx"))) - return posix_openpt(flags); - if (!strncmp(pathname,SAVE_PATH,strlen(SAVE_PATH))) - return open_savefile(pathname, flags & O_WRONLY); + errno = EIO; return -1; } -- 2.35.3 From minios-devel-bounces@lists.xenproject.org Mon Feb 13 08:44:37 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 13 Feb 2023 08:44:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494214.764236 (Exim 4.92) (envelope-from ) id 1pRURx-0006GA-Lu; Mon, 13 Feb 2023 08:44:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494214.764236; Mon, 13 Feb 2023 08:44:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRURx-0006G3-IW; Mon, 13 Feb 2023 08:44:37 +0000 Received: by outflank-mailman (input) for mailman id 494214; Mon, 13 Feb 2023 08:44:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRURw-0006An-24 for minios-devel@lists.xenproject.org; Mon, 13 Feb 2023 08:44:36 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a3098a0a-ab7a-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 09:44:33 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B5FC137870; Mon, 13 Feb 2023 08:44:32 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8D23C1391B; Mon, 13 Feb 2023 08:44:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id aHdDIXD46WNARAAAMHmgww (envelope-from ); Mon, 13 Feb 2023 08:44:32 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: a3098a0a-ab7a-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676277872; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7/tiDXbP/9+hZp0jDtSI+PwtYbXnE16R86Manl6T7bw=; b=qiR+HkdnGMmX36aZ+SoeWq7GNf4wwvzOGMdiNfYGeiA1zLvLOv6d/EiRWw5K3JRpmdJr1S 8nUOwXjEBHl7+0sNC8SUyEqCHPZOaAWUunLG4c6G56biCIP0q4goSBslMbUBZ2rS8JxS6/ MYvFRShMfQnaj/DJmzIY0bop4HB1F+M= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH v3 3/7] Mini-OS: add support for runtime mounts Date: Mon, 13 Feb 2023 09:44:08 +0100 Message-Id: <20230213084412.21065-4-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230213084412.21065-1-jgross@suse.com> References: <20230213084412.21065-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the support to mount a device at runtime. The number of dynamic mounts is limited by a #define. For devices supporting multiple files struct file is modified to hold a pointer to file specific data in contrast to device specific data. Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault --- V3: - set number of possible mountpoints to 16 (Andrew Cooper) --- include/lib.h | 5 +++++ lib/sys.c | 45 ++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 49 insertions(+), 1 deletion(-) diff --git a/include/lib.h b/include/lib.h index 36d94ec4..fd8c36de 100644 --- a/include/lib.h +++ b/include/lib.h @@ -172,6 +172,7 @@ struct file { union { int fd; /* Any fd from an upper layer. */ void *dev; + void *filedata; }; }; @@ -194,6 +195,10 @@ struct mount_point { void *dev; }; +int mount(const char *path, void *dev, + int (*open)(struct mount_point *, const char *, int, mode_t)); +void umount(const char *path); + unsigned int alloc_file_type(const struct file_ops *ops); off_t lseek_default(struct file *file, off_t offset, int whence); diff --git a/lib/sys.c b/lib/sys.c index 2f33c937..118fc441 100644 --- a/lib/sys.c +++ b/lib/sys.c @@ -85,6 +85,8 @@ } #define NOFILE 32 +#define N_MOUNTS 16 + extern void minios_evtchn_close_fd(int fd); extern void minios_gnttab_close_fd(int fd); @@ -339,7 +341,7 @@ static int open_mem(struct mount_point *mnt, const char *pathname, int flags, return fd; } -static struct mount_point mount_points[] = { +static struct mount_point mount_points[N_MOUNTS] = { { .path = "/var/log", .open = open_log, .dev = NULL }, { .path = "/dev/mem", .open = open_mem, .dev = NULL }, #ifdef CONFIG_CONSFRONT @@ -365,6 +367,8 @@ int open(const char *pathname, int flags, ...) for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) { mnt = mount_points + m; + if ( !mnt->path ) + continue; mlen = strlen(mnt->path); if ( !strncmp(pathname, mnt->path, mlen) && (pathname[mlen] == '/' || pathname[mlen] == 0) ) @@ -375,6 +379,45 @@ int open(const char *pathname, int flags, ...) return -1; } +int mount(const char *path, void *dev, + int (*open)(struct mount_point *, const char *, int, mode_t)) +{ + unsigned int m; + struct mount_point *mnt; + + for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) + { + mnt = mount_points + m; + if ( !mnt->path ) + { + mnt->path = strdup(path); + mnt->open = open; + mnt->dev = dev; + return 0; + } + } + + errno = ENOSPC; + return -1; +} + +void umount(const char *path) +{ + unsigned int m; + struct mount_point *mnt; + + for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) + { + mnt = mount_points + m; + if ( mnt->path && !strcmp(mnt->path, path) ) + { + free((char *)mnt->path); + mnt->path = NULL; + return; + } + } +} + int isatty(int fd) { return files[fd].type == FTYPE_CONSOLE; -- 2.35.3 From minios-devel-bounces@lists.xenproject.org Mon Feb 13 08:44:43 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 13 Feb 2023 08:44:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494221.764252 (Exim 4.92) (envelope-from ) id 1pRUS3-0006oD-2R; Mon, 13 Feb 2023 08:44:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494221.764252; Mon, 13 Feb 2023 08:44:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRUS2-0006o3-UR; Mon, 13 Feb 2023 08:44:42 +0000 Received: by outflank-mailman (input) for mailman id 494221; Mon, 13 Feb 2023 08:44:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRUS1-0006An-PU for minios-devel@lists.xenproject.org; Mon, 13 Feb 2023 08:44:41 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a66207d9-ab7a-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 09:44:38 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 574D037870; Mon, 13 Feb 2023 08:44:38 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 27CEC1391B; Mon, 13 Feb 2023 08:44:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id NVlaCHb46WNKRAAAMHmgww (envelope-from ); Mon, 13 Feb 2023 08:44:38 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: a66207d9-ab7a-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676277878; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4NFSUNX/XcwJ+J4tdrvx1QT/0r6zmT/B4WFWAW17s1Y=; b=ustIl96+ogoy1DaxbvOYXnW7OajUyM3EpHALnPxdTl4PQWnCUph2nuuVepesGXpkt4r8NL iGr8qspU1Bgi5Hyqp2A6plTEteeirlzrHsxeFcST/dlYnekUQQjDJeKaBRVpOpxk1wU+R1 w3byhGuWbnR4KhqqjZNbmOlSHXa9Aps= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH v3 4/7] Mini-OS: add 9pfs frontend Date: Mon, 13 Feb 2023 09:44:09 +0100 Message-Id: <20230213084412.21065-5-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230213084412.21065-1-jgross@suse.com> References: <20230213084412.21065-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a frontend for the 9pfs PV device. For now add only the code needed to connect to the backend and the related disconnect functionality. The 9pfs protocol support will be added later. Due to its nature (ability to access files) the whole code is guarded by "#ifdef HAVE_LIBC". Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault --- V2: - add better error handling to version parsing (Samuel Thibault) --- 9pfront.c | 286 ++++++++++++++++++++++++++++++++++ Config.mk | 1 + Makefile | 1 + arch/x86/testbuild/all-no | 1 + arch/x86/testbuild/all-yes | 1 + arch/x86/testbuild/newxen-yes | 1 + include/9pfront.h | 7 + 7 files changed, 298 insertions(+) create mode 100644 9pfront.c create mode 100644 include/9pfront.h diff --git a/9pfront.c b/9pfront.c new file mode 100644 index 00000000..89ecb3a1 --- /dev/null +++ b/9pfront.c @@ -0,0 +1,286 @@ +/* + * Minimal 9pfs PV frontend for Mini-OS. + * Copyright (c) 2023 Juergen Gross, SUSE Software Solution GmbH + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#ifdef HAVE_LIBC +struct dev_9pfs { + int id; + char nodename[20]; + unsigned int dom; + char *backend; + + char *tag; + const char *mnt; + + struct xen_9pfs_data_intf *intf; + struct xen_9pfs_data data; + RING_IDX prod_pvt_out; + RING_IDX cons_pvt_in; + + grant_ref_t ring_ref; + evtchn_port_t evtchn; + unsigned int ring_order; + xenbus_event_queue events; +}; + +#define DEFAULT_9PFS_RING_ORDER 4 + +static unsigned int ftype_9pfs; + +static void intr_9pfs(evtchn_port_t port, struct pt_regs *regs, void *data) +{ +} + +static int open_9pfs(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode) +{ + errno = ENOSYS; + + return -1; +} + +static void free_9pfront(struct dev_9pfs *dev) +{ + unsigned int i; + + if ( dev->data.in && dev->intf ) + { + for ( i = 0; i < (1 << dev->ring_order); i++ ) + gnttab_end_access(dev->intf->ref[i]); + free_pages(dev->data.in, dev->ring_order); + } + unbind_evtchn(dev->evtchn); + gnttab_end_access(dev->ring_ref); + free_page(dev->intf); + free(dev->backend); + free(dev->tag); + free(dev); +} + +void *init_9pfront(unsigned int id, const char *mnt) +{ + struct dev_9pfs *dev; + char *msg; + char *reason = ""; + xenbus_transaction_t xbt; + int retry = 1; + char bepath[64] = { 0 }; + XenbusState state; + unsigned int i; + void *addr; + char *version; + char *v; + + printk("9pfsfront add %u, for mount at %s\n", id, mnt); + dev = malloc(sizeof(*dev)); + memset(dev, 0, sizeof(*dev)); + snprintf(dev->nodename, sizeof(dev->nodename), "device/9pfs/%u", id); + dev->id = id; + + msg = xenbus_read_unsigned(XBT_NIL, dev->nodename, "backend-id", &dev->dom); + if ( msg ) + goto err; + msg = xenbus_read_string(XBT_NIL, dev->nodename, "backend", &dev->backend); + if ( msg ) + goto err; + msg = xenbus_read_string(XBT_NIL, dev->nodename, "tag", &dev->tag); + if ( msg ) + goto err; + + snprintf(bepath, sizeof(bepath), "%s/state", dev->backend); + free(xenbus_watch_path_token(XBT_NIL, bepath, bepath, &dev->events)); + state = xenbus_read_integer(bepath); + while ( msg == NULL && state < XenbusStateInitWait ) + msg = xenbus_wait_for_state_change(bepath, &state, &dev->events); + if ( msg || state != XenbusStateInitWait ) + { + reason = "illegal backend state"; + goto err; + } + + msg = xenbus_read_unsigned(XBT_NIL, dev->backend, "max-ring-page-order", + &dev->ring_order); + if ( msg ) + goto err; + if ( dev->ring_order > DEFAULT_9PFS_RING_ORDER ) + dev->ring_order = DEFAULT_9PFS_RING_ORDER; + + msg = xenbus_read_string(XBT_NIL, dev->backend, "versions", &version); + if ( msg ) + goto err; + for ( v = version; *v; v++ ) + { + if ( strtoul(v, &v, 10) == 1 && (*v == ',' || *v == 0) ) + { + v = NULL; + break; + } + if ( *v != ',' && *v != 0 ) + { + reason = "backend published illegal version string"; + free(version); + goto err; + } + } + free(version); + if ( v ) + { + reason = "backend doesn't support version 1"; + goto err; + } + + dev->ring_ref = gnttab_alloc_and_grant((void **)&dev->intf); + memset(dev->intf, 0, PAGE_SIZE); + if ( evtchn_alloc_unbound(dev->dom, intr_9pfs, dev, &dev->evtchn) ) + { + reason = "no event channel"; + goto err; + } + dev->intf->ring_order = dev->ring_order; + dev->data.in = (void *)alloc_pages(dev->ring_order); + dev->data.out = dev->data.in + XEN_FLEX_RING_SIZE(dev->ring_order); + for ( i = 0; i < (1 << dev->ring_order); i++ ) + { + addr = dev->data.in + i * PAGE_SIZE; + dev->intf->ref[i] = gnttab_grant_access(dev->dom, virt_to_mfn(addr), 0); + } + + while ( retry ) + { + msg = xenbus_transaction_start(&xbt); + if ( msg ) + { + free(msg); + msg = NULL; + reason = "starting transaction"; + goto err; + } + + msg = xenbus_printf(xbt, dev->nodename, "version", "%u", 1); + if ( msg ) + goto err_tr; + msg = xenbus_printf(xbt, dev->nodename, "num-rings", "%u", 1); + if ( msg ) + goto err_tr; + msg = xenbus_printf(xbt, dev->nodename, "ring-ref0", "%u", + dev->ring_ref); + if ( msg ) + goto err_tr; + msg = xenbus_printf(xbt, dev->nodename, "event-channel-0", "%u", + dev->evtchn); + if ( msg ) + goto err_tr; + msg = xenbus_printf(xbt, dev->nodename, "state", "%u", + XenbusStateInitialised); + if ( msg ) + goto err_tr; + + free(xenbus_transaction_end(xbt, 0, &retry)); + } + + state = xenbus_read_integer(bepath); + while ( msg == NULL && state < XenbusStateConnected ) + msg = xenbus_wait_for_state_change(bepath, &state, &dev->events); + if ( msg || state != XenbusStateConnected ) + { + reason = "illegal backend state"; + goto err; + } + + msg = xenbus_printf(XBT_NIL, dev->nodename, "state", "%u", + XenbusStateConnected); + if ( msg ) + goto err; + + unmask_evtchn(dev->evtchn); + + dev->mnt = mnt; + if ( mount(dev->mnt, dev, open_9pfs) ) + { + reason = "mount failed"; + goto err; + } + + return dev; + + err_tr: + free(xenbus_transaction_end(xbt, 1, &retry)); + + err: + if ( bepath[0] ) + free(xenbus_unwatch_path_token(XBT_NIL, bepath, bepath)); + if ( msg ) + printk("9pfsfront add %u failed, error %s accessing Xenstore\n", + id, msg); + else + printk("9pfsfront add %u failed, %s\n", id, reason); + free_9pfront(dev); + free(msg); + return NULL; +} + +void shutdown_9pfront(void *dev) +{ + struct dev_9pfs *dev9p = dev; + char bepath[64]; + XenbusState state; + char *msg; + char *reason = ""; + + umount(dev9p->mnt); + snprintf(bepath, sizeof(bepath), "%s/state", dev9p->backend); + + msg = xenbus_printf(XBT_NIL, dev9p->nodename, "state", "%u", + XenbusStateClosing); + if ( msg ) + goto err; + + state = xenbus_read_integer(bepath); + while ( msg == NULL && state < XenbusStateClosing) + msg = xenbus_wait_for_state_change(bepath, &state, &dev9p->events); + if ( msg || state != XenbusStateClosing ) + { + reason = "illegal backend state"; + goto err; + } + + msg = xenbus_printf(XBT_NIL, dev9p->nodename, "state", "%u", + XenbusStateClosed); + if ( msg ) + goto err; + + free_9pfront(dev9p); + + return; + + err: + if ( msg ) + printk("9pfsfront shutdown %u failed, error %s accessing Xenstore\n", + dev9p->id, msg); + else + printk("9pfsfront shutdown %u failed, %s\n", dev9p->id, reason); + free(msg); +} + +static const struct file_ops ops_9pfs = { + .name = "9pfs", +}; + +__attribute__((constructor)) +static void initialize_9pfs(void) +{ + ftype_9pfs = alloc_file_type(&ops_9pfs); +} + +#endif /* HAVE_LIBC */ diff --git a/Config.mk b/Config.mk index 1a24b30e..677e93df 100644 --- a/Config.mk +++ b/Config.mk @@ -187,6 +187,7 @@ CONFIG-n += CONFIG_QEMU_XS_ARGS CONFIG-n += CONFIG_TEST CONFIG-n += CONFIG_PCIFRONT CONFIG-n += CONFIG_TPMFRONT +CONFIG-n += CONFIG_9PFRONT CONFIG-n += CONFIG_TPM_TIS CONFIG-n += CONFIG_TPMBACK CONFIG-n += CONFIG_BALLOON diff --git a/Makefile b/Makefile index 747c7c01..7ee181a2 100644 --- a/Makefile +++ b/Makefile @@ -39,6 +39,7 @@ SUBDIRS := lib src-$(CONFIG_BLKFRONT) += blkfront.c src-$(CONFIG_CONSFRONT) += consfront.c src-$(CONFIG_TPMFRONT) += tpmfront.c +src-$(CONFIG_9PFRONT) += 9pfront.c src-$(CONFIG_TPM_TIS) += tpm_tis.c src-$(CONFIG_TPMBACK) += tpmback.c src-y += console.c diff --git a/arch/x86/testbuild/all-no b/arch/x86/testbuild/all-no index f79a1012..5b3e99ed 100644 --- a/arch/x86/testbuild/all-no +++ b/arch/x86/testbuild/all-no @@ -12,6 +12,7 @@ CONFIG_NETFRONT = n CONFIG_FBFRONT = n CONFIG_KBDFRONT = n CONFIG_CONSFRONT = n +CONFIG_9PFRONT = n CONFIG_XENBUS = n CONFIG_LIBXS = n CONFIG_LWIP = n diff --git a/arch/x86/testbuild/all-yes b/arch/x86/testbuild/all-yes index faa3af32..8ae489a4 100644 --- a/arch/x86/testbuild/all-yes +++ b/arch/x86/testbuild/all-yes @@ -12,6 +12,7 @@ CONFIG_NETFRONT = y CONFIG_FBFRONT = y CONFIG_KBDFRONT = y CONFIG_CONSFRONT = y +CONFIG_9PFRONT = y CONFIG_XENBUS = y CONFIG_LIBXS = y CONFIG_BALLOON = y diff --git a/arch/x86/testbuild/newxen-yes b/arch/x86/testbuild/newxen-yes index dc83e670..ee27a328 100644 --- a/arch/x86/testbuild/newxen-yes +++ b/arch/x86/testbuild/newxen-yes @@ -12,6 +12,7 @@ CONFIG_NETFRONT = y CONFIG_FBFRONT = y CONFIG_KBDFRONT = y CONFIG_CONSFRONT = y +CONFIG_9PFRONT = y CONFIG_XENBUS = y CONFIG_LIBXS = y CONFIG_BALLOON = y diff --git a/include/9pfront.h b/include/9pfront.h new file mode 100644 index 00000000..722ec564 --- /dev/null +++ b/include/9pfront.h @@ -0,0 +1,7 @@ +#ifndef __9PFRONT_H__ +#define __9PFRONT_H__ + +void *init_9pfront(unsigned int id, const char *mnt); +void shutdown_9pfront(void *dev); + +#endif /* __9PFRONT_H__ */ -- 2.35.3 From minios-devel-bounces@lists.xenproject.org Mon Feb 13 08:44:48 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 13 Feb 2023 08:44:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494223.764266 (Exim 4.92) (envelope-from ) id 1pRUS8-0007Ij-HH; Mon, 13 Feb 2023 08:44:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494223.764266; Mon, 13 Feb 2023 08:44:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRUS8-0007I3-DP; Mon, 13 Feb 2023 08:44:48 +0000 Received: by outflank-mailman (input) for mailman id 494223; Mon, 13 Feb 2023 08:44:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRUS7-0006An-HK for minios-devel@lists.xenproject.org; Mon, 13 Feb 2023 08:44:47 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a9b5cdd0-ab7a-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 09:44:44 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E4B5837878; Mon, 13 Feb 2023 08:44:43 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B3FCA1391B; Mon, 13 Feb 2023 08:44:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Ph6mKnv46WNXRAAAMHmgww (envelope-from ); Mon, 13 Feb 2023 08:44:43 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: a9b5cdd0-ab7a-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676277883; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vQv13aoJJoMtKTA7WtwSo7Ix8wqfh+IDZYgezsgINzs=; b=mie5sBtfJneqcDqjPNYBjOVLK5Mu3eoXFYC456ywsuTdUnYRhVJU+tTnnuOQn6g7Mxk1xS i02GShmKVUR60G+JAADQN7b2FrADG7EUKEgiRfsG2p7CCSW2qQezvOsxKl7M6+XLIjYKE6 JhILyPnLiCHWUx18K/Wy7cgOE04GYvQ= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH v3 5/7] Mini-OS: add 9pfs transport layer Date: Mon, 13 Feb 2023 09:44:10 +0100 Message-Id: <20230213084412.21065-6-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230213084412.21065-1-jgross@suse.com> References: <20230213084412.21065-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the transport layer of 9pfs. This is basically the infrastructure to send requests to the backend and to receive the related answers via the rings. As a first example add the version and attach requests of the 9pfs protocol when mounting a new 9pfs device. For the version use the "9P2000.u" variant, as it is the smallest subset supported by the qemu based backend. Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault --- V2: - add more comments (Samuel Thibault) - log short copy (Samuel Thibault) - send event after consuming response (Samuel Thibault) - reaturn EAGAIN in case no free request could be got (Samuel Thibault) --- 9pfront.c | 478 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 478 insertions(+) diff --git a/9pfront.c b/9pfront.c index 89ecb3a1..0b8d5461 100644 --- a/9pfront.c +++ b/9pfront.c @@ -7,6 +7,8 @@ #include #include #include +#include +#include #include #include #include @@ -14,6 +16,9 @@ #include #ifdef HAVE_LIBC + +#define N_REQS 64 + struct dev_9pfs { int id; char nodename[20]; @@ -22,6 +27,7 @@ struct dev_9pfs { char *tag; const char *mnt; + unsigned int msize_max; struct xen_9pfs_data_intf *intf; struct xen_9pfs_data data; @@ -32,14 +38,470 @@ struct dev_9pfs { evtchn_port_t evtchn; unsigned int ring_order; xenbus_event_queue events; + + unsigned int free_reqs; + struct req { + unsigned int id; + unsigned int next_free; /* N_REQS == end of list. */ + unsigned int cmd; + int result; + bool inflight; + unsigned char *data; /* Returned data. */ + } req[N_REQS]; + + struct wait_queue_head waitq; + struct semaphore ring_out_sem; + struct semaphore ring_in_sem; }; #define DEFAULT_9PFS_RING_ORDER 4 +#define P9_CMD_VERSION 100 +#define P9_CMD_ATTACH 104 +#define P9_CMD_ERROR 107 + +#define P9_QID_SIZE 13 + +struct p9_header { + uint32_t size; + uint8_t cmd; + uint16_t tag; +} __attribute__((packed)); + +#define P9_VERSION "9P2000.u" +#define P9_ROOT_FID ~0 + static unsigned int ftype_9pfs; +static struct req *get_free_req(struct dev_9pfs *dev) +{ + struct req *req; + + if ( dev->free_reqs == N_REQS ) + return NULL; + + req = dev->req + dev->free_reqs; + dev->free_reqs = req->next_free; + + return req; +} + +static void put_free_req(struct dev_9pfs *dev, struct req *req) +{ + req->next_free = dev->free_reqs; + req->inflight = false; + req->data = NULL; + dev->free_reqs = req->id; +} + +static unsigned int ring_out_free(struct dev_9pfs *dev) +{ + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); + unsigned int queued; + + queued = xen_9pfs_queued(dev->prod_pvt_out, dev->intf->out_cons, ring_size); + rmb(); + + return ring_size - queued; +} + +static unsigned int ring_in_data(struct dev_9pfs *dev) +{ + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); + unsigned int queued; + + queued = xen_9pfs_queued(dev->intf->in_prod, dev->cons_pvt_in, ring_size); + rmb(); + + return queued; +} + +static void copy_to_ring(struct dev_9pfs *dev, void *data, unsigned int len) +{ + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); + RING_IDX prod = xen_9pfs_mask(dev->prod_pvt_out, ring_size); + RING_IDX cons = xen_9pfs_mask(dev->intf->out_cons, ring_size); + + xen_9pfs_write_packet(dev->data.out, data, len, &prod, cons, ring_size); + dev->prod_pvt_out += len; +} + +static void copy_from_ring(struct dev_9pfs *dev, void *data, unsigned int len) +{ + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); + RING_IDX prod = xen_9pfs_mask(dev->intf->in_prod, ring_size); + RING_IDX cons = xen_9pfs_mask(dev->cons_pvt_in, ring_size); + + xen_9pfs_read_packet(data, dev->data.in, len, prod, &cons, ring_size); + dev->cons_pvt_in += len; +} + +/* + * send_9p() and rcv_9p() are using a special format string for specifying + * the kind of data sent/expected. Each data item is represented by a single + * character: + * U: 4 byte unsigned integer (uint32_t) + * S: String (2 byte length + characters) + * in the rcv_9p() case the data for string is allocated (length omitted, + * string terminated by a NUL character) + * Q: A 13 byte "qid", consisting of 1 byte file type, 4 byte file version + * and 8 bytes unique file id. Only valid for receiving. + */ +static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) +{ + struct p9_header hdr; + va_list ap, aq; + const char *f; + uint32_t intval; + uint16_t len; + char *strval; + + hdr.size = sizeof(hdr); + hdr.cmd = req->cmd; + hdr.tag = req->id; + + va_start(ap, fmt); + + va_copy(aq, ap); + for ( f = fmt; *f; f++ ) + { + switch ( *f ) + { + case 'U': + hdr.size += 4; + intval = va_arg(aq, unsigned int); + break; + case 'S': + hdr.size += 2; + strval = va_arg(aq, char *); + hdr.size += strlen(strval); + break; + default: + printk("send_9p: unknown format character %c\n", *f); + break; + } + } + va_end(aq); + + /* + * Waiting for free space must be done in the critical section! + * Otherwise we might get overtaken by other short requests. + */ + down(&dev->ring_out_sem); + + wait_event(dev->waitq, ring_out_free(dev) >= hdr.size); + + copy_to_ring(dev, &hdr, sizeof(hdr)); + for ( f = fmt; *f; f++ ) + { + switch ( *f ) + { + case 'U': + intval = va_arg(ap, unsigned int); + copy_to_ring(dev, &intval, sizeof(intval)); + break; + case 'S': + strval = va_arg(ap, char *); + len = strlen(strval); + copy_to_ring(dev, &len, sizeof(len)); + copy_to_ring(dev, strval, len); + break; + } + } + + wmb(); /* Data on ring must be seen before updating index. */ + dev->intf->out_prod = dev->prod_pvt_out; + req->inflight = true; + + up(&dev->ring_out_sem); + + va_end(ap); + + notify_remote_via_evtchn(dev->evtchn); +} + +/* + * Using an opportunistic approach for receiving data: in case multiple + * requests are outstanding (which is very unlikely), we nevertheless need + * to consume all data available until we reach the desired request. + * For requests other than the one we are waiting for, we link the complete + * data to the request via an intermediate buffer. For our own request we can + * omit that buffer and directly fill the caller provided variables. + * + * Helper functions: + * + * copy_bufs(): copy raw data into a target buffer. There can be 2 source + * buffers involved (in case the copy is done from the ring and it is across + * the ring end). The buffer pointers and lengths are updated according to + * the number of bytes copied. + * + * rcv_9p_copy(): copy the data (without the generic header) of a 9p response + * to the specified variables using the specified format string for + * deciphering the single item types. The decision whether to copy from the + * ring or an allocated buffer is done via the "hdr" parameter, which is + * NULL in the buffer case (in that case the header is located at the start + * of the buffer). + * + * rcv_9p_one(): Checks for an already filled buffer with the correct tag in + * it. If none is found, consumes one response. It checks the tag of the + * response in order to decide whether to allocate a buffer for putting the + * data into, or to fill the user supplied variables. Return true, if the + * tag did match. Waits if no data is ready to be consumed. + */ +static void copy_bufs(unsigned char **buf1, unsigned char **buf2, + unsigned int *len1, unsigned int *len2, + void *target, unsigned int len) +{ + if ( len <= *len1 ) + { + memcpy(target, *buf1, len); + *buf1 += len; + *len1 -= len; + } + else + { + memcpy(target, *buf1, *len1); + target = (char *)target + *len1; + len -= *len1; + *buf1 = *buf2; + *len1 = *len2; + *buf2 = NULL; + *len2 = 0; + if ( len > *len1 ) + { + printk("9pfs: short copy (dropping %u bytes)\n", len - *len1); + len = *len1; + } + memcpy(target, *buf1, *len1); + } +} + +static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, + struct p9_header *hdr, const char *fmt, va_list ap) +{ + struct p9_header *h = hdr ? hdr : (void *)req->data; + RING_IDX cons = dev->cons_pvt_in + h->size - sizeof(*h); + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); + unsigned char *buf1, *buf2; + unsigned int len1, len2; + const char *f; + char *str; + uint16_t len; + uint32_t err; + uint32_t *val; + char **strval; + uint8_t *qval; + + if ( hdr ) + { + buf1 = xen_9pfs_get_ring_ptr(dev->data.in, dev->cons_pvt_in, ring_size); + buf2 = xen_9pfs_get_ring_ptr(dev->data.in, 0, ring_size); + len1 = ring_size - xen_9pfs_mask(dev->cons_pvt_in, ring_size); + if ( len1 > h->size - sizeof(*h) ) + len1 = h->size - sizeof(*h); + len2 = h->size - sizeof(*h) - len1; + } + else + { + buf1 = req->data + sizeof(*h); + buf2 = NULL; + len1 = h->size - sizeof(*h); + len2 = 0; + } + + if ( h->cmd == P9_CMD_ERROR ) + { + copy_bufs(&buf1, &buf2, &len1, &len2, &len, sizeof(len)); + str = malloc(len + 1); + copy_bufs(&buf1, &buf2, &len1, &len2, str, len); + str[len] = 0; + printk("9pfs: request %u resulted in \"%s\"\n", req->cmd, str); + free(str); + err = EIO; + copy_bufs(&buf1, &buf2, &len1, &len2, &err, sizeof(err)); + req->result = err; + + if ( hdr ) + dev->cons_pvt_in = cons; + + return; + } + + if ( h->cmd != req->cmd + 1 ) + { + req->result = EDOM; + printk("9pfs: illegal response: wrong return type (%u instead of %u)\n", + h->cmd, req->cmd + 1); + + if ( hdr ) + dev->cons_pvt_in = cons; + + return; + } + + req->result = 0; + + for ( f = fmt; *f; f++ ) + { + switch ( *f ) + { + case 'U': + val = va_arg(ap, uint32_t *); + copy_bufs(&buf1, &buf2, &len1, &len2, val, sizeof(*val)); + break; + case 'S': + strval = va_arg(ap, char **); + copy_bufs(&buf1, &buf2, &len1, &len2, &len, sizeof(len)); + *strval = malloc(len + 1); + copy_bufs(&buf1, &buf2, &len1, &len2, *strval, len); + (*strval)[len] = 0; + break; + case 'Q': + qval = va_arg(ap, uint8_t *); + copy_bufs(&buf1, &buf2, &len1, &len2, qval, P9_QID_SIZE); + break; + default: + printk("rcv_9p: unknown format character %c\n", *f); + break; + } + } + + if ( hdr ) + dev->cons_pvt_in = cons; +} + +static bool rcv_9p_one(struct dev_9pfs *dev, struct req *req, const char *fmt, + va_list ap) +{ + struct p9_header hdr; + struct req *tmp; + + if ( req->data ) + { + rcv_9p_copy(dev, req, NULL, fmt, ap); + free(req->data); + req->data = NULL; + + return true; + } + + wait_event(dev->waitq, ring_in_data(dev) >= sizeof(hdr)); + + copy_from_ring(dev, &hdr, sizeof(hdr)); + + wait_event(dev->waitq, ring_in_data(dev) >= hdr.size - sizeof(hdr)); + + tmp = dev->req + hdr.tag; + if ( hdr.tag >= N_REQS || !tmp->inflight ) + { + printk("9pfs: illegal response: %s\n", + hdr.tag >= N_REQS ? "tag out of bounds" : "request not pending"); + dev->cons_pvt_in += hdr.size - sizeof(hdr); + + return false; + } + + tmp->inflight = false; + + if ( tmp != req ) + { + tmp->data = malloc(hdr.size); + memcpy(tmp->data, &hdr, sizeof(hdr)); + copy_from_ring(dev, tmp->data + sizeof(hdr), hdr.size - sizeof(hdr)); + + return false; + } + + rcv_9p_copy(dev, req, &hdr, fmt, ap); + + return true; +} + +static void rcv_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) +{ + va_list ap; + + va_start(ap, fmt); + + down(&dev->ring_in_sem); + + while ( !rcv_9p_one(dev, req, fmt, ap) ); + + rmb(); /* Read all data before updating ring index. */ + dev->intf->in_cons = dev->cons_pvt_in; + + notify_remote_via_evtchn(dev->evtchn); + + up(&dev->ring_in_sem); + + va_end(ap); +} + +static int p9_version(struct dev_9pfs *dev) +{ + unsigned int msize = XEN_FLEX_RING_SIZE(dev->ring_order) / 2; + struct req *req = get_free_req(dev); + char *verret; + int ret; + + if ( !req ) + return EAGAIN; + + req->cmd = P9_CMD_VERSION; + send_9p(dev, req, "US", msize, P9_VERSION); + rcv_9p(dev, req, "US", &dev->msize_max, &verret); + ret = req->result; + + put_free_req(dev, req); + + if ( ret ) + return ret; + + if ( strcmp(verret, P9_VERSION) ) + ret = ENOMSG; + free(verret); + + return ret; +} + +static int p9_attach(struct dev_9pfs *dev) +{ + uint32_t fid = P9_ROOT_FID; + uint32_t afid = 0; + uint32_t uid = 0; + uint8_t qid[P9_QID_SIZE]; + struct req *req = get_free_req(dev); + int ret; + + if ( !req ) + return EAGAIN; + + req->cmd = P9_CMD_ATTACH; + send_9p(dev, req, "UUSSU", fid, afid, "root", "root", uid); + rcv_9p(dev, req, "Q", qid); + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +static int connect_9pfs(struct dev_9pfs *dev) +{ + int ret; + + ret = p9_version(dev); + if ( ret ) + return ret; + + return p9_attach(dev); +} + static void intr_9pfs(evtchn_port_t port, struct pt_regs *regs, void *data) { + struct dev_9pfs *dev = data; + + wake_up(&dev->waitq); } static int open_9pfs(struct mount_point *mnt, const char *pathname, int flags, @@ -87,6 +549,16 @@ void *init_9pfront(unsigned int id, const char *mnt) memset(dev, 0, sizeof(*dev)); snprintf(dev->nodename, sizeof(dev->nodename), "device/9pfs/%u", id); dev->id = id; + init_waitqueue_head(&dev->waitq); + init_SEMAPHORE(&dev->ring_out_sem, 1); + init_SEMAPHORE(&dev->ring_in_sem, 1); + + for ( i = 0; i < N_REQS; i++ ) + { + dev->req[i].id = i; + dev->req[i].next_free = i + 1; + } + dev->free_reqs = 0; msg = xenbus_read_unsigned(XBT_NIL, dev->nodename, "backend-id", &dev->dom); if ( msg ) @@ -205,6 +677,12 @@ void *init_9pfront(unsigned int id, const char *mnt) unmask_evtchn(dev->evtchn); + if ( connect_9pfs(dev) ) + { + reason = "9pfs connect failed"; + goto err; + } + dev->mnt = mnt; if ( mount(dev->mnt, dev, open_9pfs) ) { -- 2.35.3 From minios-devel-bounces@lists.xenproject.org Mon Feb 13 08:44:53 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 13 Feb 2023 08:44:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494230.764287 (Exim 4.92) (envelope-from ) id 1pRUSD-0007sT-Gd; Mon, 13 Feb 2023 08:44:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494230.764287; Mon, 13 Feb 2023 08:44:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRUSD-0007rd-BA; Mon, 13 Feb 2023 08:44:53 +0000 Received: by outflank-mailman (input) for mailman id 494230; Mon, 13 Feb 2023 08:44:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRUSC-00053b-9H for minios-devel@lists.xenproject.org; Mon, 13 Feb 2023 08:44:52 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ac7d7eb8-ab7a-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 09:44:48 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7E49637878; Mon, 13 Feb 2023 08:44:49 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4EB861391B; Mon, 13 Feb 2023 08:44:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id jYzjEYH46WNdRAAAMHmgww (envelope-from ); Mon, 13 Feb 2023 08:44:49 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: ac7d7eb8-ab7a-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676277889; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wuLv/cVrd8nYj9ZnkPp0QX3mht4hZHquHGoCMyjlj9Y=; b=FOg9dV3cCjFNLjjcGtqOwZEN4eOnIsIPTWopUZeP4xCTUHeUT67PGlbAukAcIoUc7gl34J Y1jHcjKeWX2Yfr5RKdOo9j48QR8HReS229abwxdr3tT/jFsw0WmtlsltLteX+bYhSPRY7e +eHNiEzPz/WI6OVzvF1gAgUxMlJFznc= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH v3 6/7] Mini-OS: add open and close handling to the 9pfs frontend Date: Mon, 13 Feb 2023 09:44:11 +0100 Message-Id: <20230213084412.21065-7-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230213084412.21065-1-jgross@suse.com> References: <20230213084412.21065-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the open() and close() support to the 9pfs frontend. This requires to split the path name and to walk to the desired directory level. Signed-off-by: Juergen Gross --- V2: - check path to be canonical - avoid short read when walking the path - fix get_fid() (Samuel Thibault) - return EAGAIN if no free request got (Samuel Thibault) V3: - add check for "//" in path_canonical() (Samuel Thibault) --- 9pfront.c | 324 +++++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 322 insertions(+), 2 deletions(-) diff --git a/9pfront.c b/9pfront.c index 0b8d5461..fb2e5669 100644 --- a/9pfront.c +++ b/9pfront.c @@ -6,6 +6,7 @@ #include #include #include +#include #include #include #include @@ -52,13 +53,32 @@ struct dev_9pfs { struct wait_queue_head waitq; struct semaphore ring_out_sem; struct semaphore ring_in_sem; + + unsigned long long fid_mask; /* Bit mask for free fids. */ +}; + +struct file_9pfs { + uint32_t fid; + struct dev_9pfs *dev; + bool append; }; #define DEFAULT_9PFS_RING_ORDER 4 +/* P9 protocol commands (response is either cmd+1 or P9_CMD_ERROR). */ #define P9_CMD_VERSION 100 #define P9_CMD_ATTACH 104 #define P9_CMD_ERROR 107 +#define P9_CMD_WALK 110 +#define P9_CMD_OPEN 112 +#define P9_CMD_CREATE 114 +#define P9_CMD_CLUNK 120 + +/* P9 protocol open flags. */ +#define P9_OREAD 0 /* read */ +#define P9_OWRITE 1 /* write */ +#define P9_ORDWR 2 /* read and write */ +#define P9_OTRUNC 16 /* or'ed in, truncate file first */ #define P9_QID_SIZE 13 @@ -69,10 +89,27 @@ struct p9_header { } __attribute__((packed)); #define P9_VERSION "9P2000.u" -#define P9_ROOT_FID ~0 +#define P9_ROOT_FID 0 static unsigned int ftype_9pfs; +static unsigned int get_fid(struct dev_9pfs *dev) +{ + unsigned int fid; + + fid = ffs(dev->fid_mask); + if ( fid ) + dev->fid_mask &= ~(1ULL << (fid - 1)); + + return fid; +} + +static void put_fid(struct dev_9pfs *dev, unsigned int fid) +{ + if ( fid ) + dev->fid_mask |= 1ULL << (fid - 1); +} + static struct req *get_free_req(struct dev_9pfs *dev) { struct req *req; @@ -140,6 +177,9 @@ static void copy_from_ring(struct dev_9pfs *dev, void *data, unsigned int len) * send_9p() and rcv_9p() are using a special format string for specifying * the kind of data sent/expected. Each data item is represented by a single * character: + * b: 1 byte unsigned integer (uint8_t) + * Only valid for sending. + * u: 2 byte unsigned integer (uint16_t) * U: 4 byte unsigned integer (uint32_t) * S: String (2 byte length + characters) * in the rcv_9p() case the data for string is allocated (length omitted, @@ -153,7 +193,9 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) va_list ap, aq; const char *f; uint32_t intval; + uint16_t shortval; uint16_t len; + uint8_t byte; char *strval; hdr.size = sizeof(hdr); @@ -167,6 +209,14 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) { switch ( *f ) { + case 'b': + hdr.size += 1; + byte = va_arg(aq, unsigned int); + break; + case 'u': + hdr.size += 2; + shortval = va_arg(aq, unsigned int); + break; case 'U': hdr.size += 4; intval = va_arg(aq, unsigned int); @@ -196,6 +246,14 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) { switch ( *f ) { + case 'b': + byte = va_arg(ap, unsigned int); + copy_to_ring(dev, &byte, sizeof(byte)); + break; + case 'u': + shortval = va_arg(ap, unsigned int); + copy_to_ring(dev, &shortval, sizeof(shortval)); + break; case 'U': intval = va_arg(ap, unsigned int); copy_to_ring(dev, &intval, sizeof(intval)); @@ -288,6 +346,7 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, char *str; uint16_t len; uint32_t err; + uint16_t *shortval; uint32_t *val; char **strval; uint8_t *qval; @@ -345,6 +404,10 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, { switch ( *f ) { + case 'u': + shortval = va_arg(ap, uint16_t *); + copy_bufs(&buf1, &buf2, &len1, &len2, shortval, sizeof(*shortval)); + break; case 'U': val = va_arg(ap, uint32_t *); copy_bufs(&buf1, &buf2, &len1, &len2, val, sizeof(*val)); @@ -486,6 +549,170 @@ static int p9_attach(struct dev_9pfs *dev) return ret; } +static int p9_clunk(struct dev_9pfs *dev, uint32_t fid) +{ + struct req *req = get_free_req(dev); + int ret; + + if ( !req ) + return EAGAIN; + + req->cmd = P9_CMD_CLUNK; + send_9p(dev, req, "U", fid); + rcv_9p(dev, req, ""); + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +static int p9_walk(struct dev_9pfs *dev, uint32_t fid, uint32_t newfid, + char *name) +{ + struct req *req = get_free_req(dev); + int ret; + uint16_t nqid; + uint8_t qid[P9_QID_SIZE]; + + if ( !req ) + return EAGAIN; + + req->cmd = P9_CMD_WALK; + if ( name[0] ) + { + send_9p(dev, req, "UUuS", fid, newfid, 1, name); + rcv_9p(dev, req, "uQ", &nqid, qid); + } + else + { + send_9p(dev, req, "UUu", fid, newfid, 0); + rcv_9p(dev, req, "u", &nqid); + } + + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +static int p9_open(struct dev_9pfs *dev, uint32_t fid, uint8_t omode) +{ + struct req *req = get_free_req(dev); + int ret; + uint8_t qid[P9_QID_SIZE]; + uint32_t iounit; + + if ( !req ) + return EAGAIN; + + req->cmd = P9_CMD_OPEN; + send_9p(dev, req, "Ub", fid, omode); + rcv_9p(dev, req, "QU", qid, &iounit); + + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +static int p9_create(struct dev_9pfs *dev, uint32_t fid, char *path, + uint32_t mode, uint8_t omode) +{ + struct req *req = get_free_req(dev); + int ret; + uint8_t qid[P9_QID_SIZE]; + uint32_t iounit; + + if ( !req ) + return EAGAIN; + + req->cmd = P9_CMD_CREATE; + send_9p(dev, req, "USUbS", fid, path, mode, omode, ""); + rcv_9p(dev, req, "QU", qid, &iounit); + + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +/* + * Walk from root levels with the levels listed in <*paths> as a + * sequence of names. Returns the number of steps not having been able to + * walk, with <*paths> pointing at the name of the failing walk step. + * will be associated with the last successful walk step. Note that + * the first step should always succeed, as it is an empty walk in order + * to start at the root (needed for creating new files in root). + */ +static unsigned int walk_9pfs(struct dev_9pfs *dev, uint32_t fid, + unsigned int steps, char **paths) +{ + uint32_t curr_fid = P9_ROOT_FID; + int ret; + + while ( steps-- ) + { + ret = p9_walk(dev, curr_fid, fid, *paths); + if ( ret ) + return steps + 1; + curr_fid = fid; + *paths += strlen(*paths) + 1; + } + + return 0; +} + +static unsigned int split_path(const char *pathname, char **split_ptr) +{ + unsigned int parts = 1; + char *p; + + *split_ptr = strdup(pathname); + + for ( p = strchr(*split_ptr, '/'); p; p = strchr(p + 1, '/') ) + { + *p = 0; + parts++; + } + + return parts; +} + +static bool path_canonical(const char *pathname) +{ + unsigned int len = strlen(pathname); + const char *c; + + /* Empty path is allowed. */ + if ( !len ) + return true; + + /* No trailing '/'. */ + if ( pathname[len - 1] == '/' ) + return false; + + /* No self or parent references. */ + c = pathname; + while ( (c = strstr(c, "/.")) != NULL ) + { + if ( c[2] == '.' ) + c++; + if ( c[2] == 0 || c[2] == '/' ) + return false; + c += 2; + } + + /* No "//". */ + if ( strstr(pathname, "//") ) + return false; + + return true; +} + static int connect_9pfs(struct dev_9pfs *dev) { int ret; @@ -504,10 +731,101 @@ static void intr_9pfs(evtchn_port_t port, struct pt_regs *regs, void *data) wake_up(&dev->waitq); } +static int close_9pfs(struct file *file) +{ + struct file_9pfs *f9pfs = file->filedata; + + if ( f9pfs->fid != P9_ROOT_FID ) + { + p9_clunk(f9pfs->dev, f9pfs->fid); + put_fid(f9pfs->dev, f9pfs->fid); + } + + free(f9pfs); + + return 0; +} + static int open_9pfs(struct mount_point *mnt, const char *pathname, int flags, mode_t mode) { - errno = ENOSYS; + int fd; + char *path = NULL; + char *p; + struct file *file; + struct file_9pfs *f9pfs; + uint16_t nwalk; + uint8_t omode; + int ret; + + if ( !path_canonical(pathname) ) + return EINVAL; + + f9pfs = calloc(1, sizeof(*f9pfs)); + f9pfs->dev = mnt->dev; + f9pfs->fid = P9_ROOT_FID; + + fd = alloc_fd(ftype_9pfs); + file = get_file_from_fd(fd); + file->filedata = f9pfs; + + switch ( flags & O_ACCMODE ) + { + case O_RDONLY: + omode = P9_OREAD; + break; + case O_WRONLY: + omode = P9_OWRITE; + break; + case O_RDWR: + omode = P9_ORDWR; + break; + default: + ret = EINVAL; + goto err; + } + + if ( flags & O_TRUNC ) + omode |= P9_OTRUNC; + f9pfs->append = flags & O_APPEND; + + nwalk = split_path(pathname, &path); + + f9pfs->fid = get_fid(mnt->dev); + if ( !f9pfs->fid ) + { + ret = ENFILE; + goto err; + } + p = path; + nwalk = walk_9pfs(mnt->dev, f9pfs->fid, nwalk, &p); + if ( nwalk ) + { + if ( nwalk > 1 || !(flags & O_CREAT) ) + { + ret = ENOENT; + goto err; + } + + ret = p9_create(mnt->dev, f9pfs->fid, p, mode, omode); + if ( ret ) + goto err; + goto out; + } + + ret = p9_open(mnt->dev, f9pfs->fid, omode); + if ( ret ) + goto err; + + out: + free(path); + + return fd; + + err: + free(path); + close(fd); + errno = ret; return -1; } @@ -552,6 +870,7 @@ void *init_9pfront(unsigned int id, const char *mnt) init_waitqueue_head(&dev->waitq); init_SEMAPHORE(&dev->ring_out_sem, 1); init_SEMAPHORE(&dev->ring_in_sem, 1); + dev->fid_mask = ~0ULL; for ( i = 0; i < N_REQS; i++ ) { @@ -753,6 +1072,7 @@ void shutdown_9pfront(void *dev) static const struct file_ops ops_9pfs = { .name = "9pfs", + .close = close_9pfs, }; __attribute__((constructor)) -- 2.35.3 From minios-devel-bounces@lists.xenproject.org Mon Feb 13 08:45:17 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 13 Feb 2023 08:45:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494245.764296 (Exim 4.92) (envelope-from ) id 1pRUSb-0000pt-Hq; Mon, 13 Feb 2023 08:45:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494245.764296; Mon, 13 Feb 2023 08:45:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRUSb-0000pm-Eq; Mon, 13 Feb 2023 08:45:17 +0000 Received: by outflank-mailman (input) for mailman id 494245; Mon, 13 Feb 2023 08:45:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRUSI-0006An-Bh for minios-devel@lists.xenproject.org; Mon, 13 Feb 2023 08:44:58 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b05b9c56-ab7a-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 09:44:55 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 15D2437870; Mon, 13 Feb 2023 08:44:55 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E2B901391B; Mon, 13 Feb 2023 08:44:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id MGEsNob46WNwRAAAMHmgww (envelope-from ); Mon, 13 Feb 2023 08:44:54 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: b05b9c56-ab7a-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676277895; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nsb+k9M0ZRBDQHW/kSOuXta4SExd/WLGLnOu4GRbNW4=; b=Fcg2Q83nLC0WBcoRucEIdajqN7DsYJYPRsQPs+EnbbinXqqUVaSWq/5SZvWLrMiVUuH7OM 6RvXh3I1syHWV0+AbGaKQZEc3B5Qyxkga0cEwTzN1UWkD3UlVLAB08K6IfO2dgJZoPG94d ZQBwFac7ZekExICyEYzSUgC0BbM/mWs= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH v3 7/7] Mini-OS: add read and write support to 9pfsfront Date: Mon, 13 Feb 2023 09:44:12 +0100 Message-Id: <20230213084412.21065-8-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230213084412.21065-1-jgross@suse.com> References: <20230213084412.21065-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add support to read from and write to a file handled by 9pfsfront. Signed-off-by: Juergen Gross --- V2: - add check for max message size - return EAGAIN in case no free request got (Samuel Thibault) - loop until all data read/written (Samuel Thibault) V3: - use an exact limit for read/write (Samuel Thibault) - log read(write errors (Samuel Thibault) --- 9pfront.c | 216 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 216 insertions(+) diff --git a/9pfront.c b/9pfront.c index fb2e5669..5da8a365 100644 --- a/9pfront.c +++ b/9pfront.c @@ -72,7 +72,10 @@ struct file_9pfs { #define P9_CMD_WALK 110 #define P9_CMD_OPEN 112 #define P9_CMD_CREATE 114 +#define P9_CMD_READ 116 +#define P9_CMD_WRITE 118 #define P9_CMD_CLUNK 120 +#define P9_CMD_STAT 124 /* P9 protocol open flags. */ #define P9_OREAD 0 /* read */ @@ -88,11 +91,39 @@ struct p9_header { uint16_t tag; } __attribute__((packed)); +struct p9_stat { + uint16_t size; + uint16_t type; + uint32_t dev; + uint8_t qid[P9_QID_SIZE]; + uint32_t mode; + uint32_t atime; + uint32_t mtime; + uint64_t length; + char *name; + char *uid; + char *gid; + char *muid; + char *extension; + uint32_t n_uid; + uint32_t n_gid; + uint32_t n_muid; +}; + #define P9_VERSION "9P2000.u" #define P9_ROOT_FID 0 static unsigned int ftype_9pfs; +static void free_stat(struct p9_stat *stat) +{ + free(stat->name); + free(stat->uid); + free(stat->gid); + free(stat->muid); + free(stat->extension); +} + static unsigned int get_fid(struct dev_9pfs *dev) { unsigned int fid; @@ -181,9 +212,12 @@ static void copy_from_ring(struct dev_9pfs *dev, void *data, unsigned int len) * Only valid for sending. * u: 2 byte unsigned integer (uint16_t) * U: 4 byte unsigned integer (uint32_t) + * L: 8 byte unsigned integer (uint64_t) * S: String (2 byte length + characters) * in the rcv_9p() case the data for string is allocated (length omitted, * string terminated by a NUL character) + * D: Binary data (4 byte length + bytes of data), requires a length + * and a buffer pointer parameter. * Q: A 13 byte "qid", consisting of 1 byte file type, 4 byte file version * and 8 bytes unique file id. Only valid for receiving. */ @@ -192,10 +226,12 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) struct p9_header hdr; va_list ap, aq; const char *f; + uint64_t longval; uint32_t intval; uint16_t shortval; uint16_t len; uint8_t byte; + uint8_t *data; char *strval; hdr.size = sizeof(hdr); @@ -221,11 +257,21 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) hdr.size += 4; intval = va_arg(aq, unsigned int); break; + case 'L': + hdr.size += 8; + longval = va_arg(aq, uint64_t); + break; case 'S': hdr.size += 2; strval = va_arg(aq, char *); hdr.size += strlen(strval); break; + case 'D': + hdr.size += 4; + intval = va_arg(aq, unsigned int); + hdr.size += intval; + data = va_arg(aq, uint8_t *); + break; default: printk("send_9p: unknown format character %c\n", *f); break; @@ -258,12 +304,22 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) intval = va_arg(ap, unsigned int); copy_to_ring(dev, &intval, sizeof(intval)); break; + case 'L': + longval = va_arg(ap, uint64_t); + copy_to_ring(dev, &longval, sizeof(longval)); + break; case 'S': strval = va_arg(ap, char *); len = strlen(strval); copy_to_ring(dev, &len, sizeof(len)); copy_to_ring(dev, strval, len); break; + case 'D': + intval = va_arg(ap, unsigned int); + copy_to_ring(dev, &intval, sizeof(intval)); + data = va_arg(ap, uint8_t *); + copy_to_ring(dev, data, intval); + break; } } @@ -348,6 +404,8 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, uint32_t err; uint16_t *shortval; uint32_t *val; + uint64_t *longval; + uint8_t *data; char **strval; uint8_t *qval; @@ -412,6 +470,10 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, val = va_arg(ap, uint32_t *); copy_bufs(&buf1, &buf2, &len1, &len2, val, sizeof(*val)); break; + case 'L': + longval = va_arg(ap, uint64_t *); + copy_bufs(&buf1, &buf2, &len1, &len2, longval, sizeof(*longval)); + break; case 'S': strval = va_arg(ap, char **); copy_bufs(&buf1, &buf2, &len1, &len2, &len, sizeof(len)); @@ -419,6 +481,12 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, copy_bufs(&buf1, &buf2, &len1, &len2, *strval, len); (*strval)[len] = 0; break; + case 'D': + val = va_arg(ap, uint32_t *); + data = va_arg(ap, uint8_t *); + copy_bufs(&buf1, &buf2, &len1, &len2, val, sizeof(*val)); + copy_bufs(&buf1, &buf2, &len1, &len2, data, *val); + break; case 'Q': qval = va_arg(ap, uint8_t *); copy_bufs(&buf1, &buf2, &len1, &len2, qval, P9_QID_SIZE); @@ -640,6 +708,115 @@ static int p9_create(struct dev_9pfs *dev, uint32_t fid, char *path, return ret; } +static int p9_stat(struct dev_9pfs *dev, uint32_t fid, struct p9_stat *stat) +{ + struct req *req = get_free_req(dev); + int ret; + + if ( !req ) + return EAGAIN; + + memset(stat, 0, sizeof(*stat)); + req->cmd = P9_CMD_STAT; + send_9p(dev, req, "U", fid); + rcv_9p(dev, req, "uuUQUUULSSSSSUUU", &stat->size, &stat->type, &stat->dev, + stat->qid, &stat->mode, &stat->atime, &stat->mtime, &stat->length, + &stat->name, &stat->uid, &stat->gid, &stat->muid, &stat->extension, + &stat->n_uid, &stat->n_gid, &stat->n_muid); + + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +static int p9_read(struct dev_9pfs *dev, uint32_t fid, uint64_t offset, + uint8_t *data, uint32_t len) +{ + struct req *req = get_free_req(dev); + int ret = 0; + uint32_t count, count_max; + + if ( !req ) + { + errno = EAGAIN; + return -1; + } + req->cmd = P9_CMD_READ; + count_max = dev->msize_max - (sizeof(struct p9_header) + sizeof(uint32_t)); + + while ( len ) + { + count = len; + if ( count > count_max ) + count = count_max; + + send_9p(dev, req, "ULU", fid, offset, count); + rcv_9p(dev, req, "D", &count, data); + + if ( !count ) + break; + if ( req->result ) + { + ret = -1; + errno = EIO; + printk("9pfs: read got error %d\n", req->result); + break; + } + ret += count; + offset += count; + data += count; + len -= count; + } + + put_free_req(dev, req); + + return ret; +} + +static int p9_write(struct dev_9pfs *dev, uint32_t fid, uint64_t offset, + const uint8_t *data, uint32_t len) +{ + struct req *req = get_free_req(dev); + int ret = 0; + uint32_t count, count_max; + + if ( !req ) + { + errno = EAGAIN; + return -1; + } + req->cmd = P9_CMD_WRITE; + count_max = dev->msize_max - (sizeof(struct p9_header) + sizeof(uint32_t) + + sizeof(uint64_t) + sizeof(uint32_t)); + + while ( len ) + { + count = len; + if ( count > count_max ) + count = count_max; + + send_9p(dev, req, "ULD", fid, offset, count, data); + rcv_9p(dev, req, "U", &count); + if ( req->result ) + { + ret = -1; + errno = EIO; + printk("9pfs: write got error %d\n", req->result); + break; + } + ret += count; + offset += count; + data += count; + len -= count; + } + + put_free_req(dev, req); + + return ret; +} + /* * Walk from root levels with the levels listed in <*paths> as a * sequence of names. Returns the number of steps not having been able to @@ -731,6 +908,43 @@ static void intr_9pfs(evtchn_port_t port, struct pt_regs *regs, void *data) wake_up(&dev->waitq); } +static int read_9pfs(struct file *file, void *buf, size_t nbytes) +{ + struct file_9pfs *f9pfs = file->filedata; + int ret; + + ret = p9_read(f9pfs->dev, f9pfs->fid, file->offset, buf, nbytes); + if ( ret >= 0 ) + file->offset += ret; + + return ret; +} + +static int write_9pfs(struct file *file, const void *buf, size_t nbytes) +{ + struct file_9pfs *f9pfs = file->filedata; + struct p9_stat stat; + int ret; + + if ( f9pfs->append ) + { + ret = p9_stat(f9pfs->dev, f9pfs->fid, &stat); + free_stat(&stat); + if ( ret ) + { + errno = EIO; + return -1; + } + file->offset = stat.length; + } + + ret = p9_write(f9pfs->dev, f9pfs->fid, file->offset, buf, nbytes); + if ( ret >= 0 ) + file->offset += ret; + + return ret; +} + static int close_9pfs(struct file *file) { struct file_9pfs *f9pfs = file->filedata; @@ -1072,6 +1286,8 @@ void shutdown_9pfront(void *dev) static const struct file_ops ops_9pfs = { .name = "9pfs", + .read = read_9pfs, + .write = write_9pfs, .close = close_9pfs, }; -- 2.35.3 From minios-devel-bounces@lists.xenproject.org Mon Feb 13 23:12:00 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 13 Feb 2023 23:12:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494852.765008 (Exim 4.92) (envelope-from ) id 1pRhzH-0004GD-V4; Mon, 13 Feb 2023 23:11:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494852.765008; Mon, 13 Feb 2023 23:11:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRhzH-0004FT-Ru; Mon, 13 Feb 2023 23:11:55 +0000 Received: by outflank-mailman (input) for mailman id 494852; Mon, 13 Feb 2023 23:11:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRhzG-0004DD-75 for minios-devel@lists.xenproject.org; Mon, 13 Feb 2023 23:11:54 +0000 Received: from sonata.ens-lyon.org (sonata.ens-lyon.org [140.77.166.138]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id caf602b8-abf3-11ed-93b5-47a8fe42b414; Tue, 14 Feb 2023 00:11:49 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id B571B2015E; Tue, 14 Feb 2023 00:11:48 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fFJRHOnEtlpj; Tue, 14 Feb 2023 00:11:48 +0100 (CET) Received: from begin (lfbn-bor-1-1163-184.w92-158.abo.wanadoo.fr [92.158.138.184]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 6AD3C20119; Tue, 14 Feb 2023 00:11:48 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pRhzA-00FwGp-03; Tue, 14 Feb 2023 00:11:48 +0100 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: caf602b8-abf3-11ed-93b5-47a8fe42b414 Date: Tue, 14 Feb 2023 00:11:47 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH v3 6/7] Mini-OS: add open and close handling to the 9pfs frontend Message-ID: <20230213231147.lw4iae5z4yq4focz@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230213084412.21065-1-jgross@suse.com> <20230213084412.21065-7-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230213084412.21065-7-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le lun. 13 févr. 2023 09:44:11 +0100, a ecrit: > Add the open() and close() support to the 9pfs frontend. This requires > to split the path name and to walk to the desired directory level. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V2: > - check path to be canonical > - avoid short read when walking the path > - fix get_fid() (Samuel Thibault) > - return EAGAIN if no free request got (Samuel Thibault) > V3: > - add check for "//" in path_canonical() (Samuel Thibault) > --- > 9pfront.c | 324 +++++++++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 322 insertions(+), 2 deletions(-) > > diff --git a/9pfront.c b/9pfront.c > index 0b8d5461..fb2e5669 100644 > --- a/9pfront.c > +++ b/9pfront.c > @@ -6,6 +6,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -52,13 +53,32 @@ struct dev_9pfs { > struct wait_queue_head waitq; > struct semaphore ring_out_sem; > struct semaphore ring_in_sem; > + > + unsigned long long fid_mask; /* Bit mask for free fids. */ > +}; > + > +struct file_9pfs { > + uint32_t fid; > + struct dev_9pfs *dev; > + bool append; > }; > > #define DEFAULT_9PFS_RING_ORDER 4 > > +/* P9 protocol commands (response is either cmd+1 or P9_CMD_ERROR). */ > #define P9_CMD_VERSION 100 > #define P9_CMD_ATTACH 104 > #define P9_CMD_ERROR 107 > +#define P9_CMD_WALK 110 > +#define P9_CMD_OPEN 112 > +#define P9_CMD_CREATE 114 > +#define P9_CMD_CLUNK 120 > + > +/* P9 protocol open flags. */ > +#define P9_OREAD 0 /* read */ > +#define P9_OWRITE 1 /* write */ > +#define P9_ORDWR 2 /* read and write */ > +#define P9_OTRUNC 16 /* or'ed in, truncate file first */ > > #define P9_QID_SIZE 13 > > @@ -69,10 +89,27 @@ struct p9_header { > } __attribute__((packed)); > > #define P9_VERSION "9P2000.u" > -#define P9_ROOT_FID ~0 > +#define P9_ROOT_FID 0 > > static unsigned int ftype_9pfs; > > +static unsigned int get_fid(struct dev_9pfs *dev) > +{ > + unsigned int fid; > + > + fid = ffs(dev->fid_mask); > + if ( fid ) > + dev->fid_mask &= ~(1ULL << (fid - 1)); > + > + return fid; > +} > + > +static void put_fid(struct dev_9pfs *dev, unsigned int fid) > +{ > + if ( fid ) > + dev->fid_mask |= 1ULL << (fid - 1); > +} > + > static struct req *get_free_req(struct dev_9pfs *dev) > { > struct req *req; > @@ -140,6 +177,9 @@ static void copy_from_ring(struct dev_9pfs *dev, void *data, unsigned int len) > * send_9p() and rcv_9p() are using a special format string for specifying > * the kind of data sent/expected. Each data item is represented by a single > * character: > + * b: 1 byte unsigned integer (uint8_t) > + * Only valid for sending. > + * u: 2 byte unsigned integer (uint16_t) > * U: 4 byte unsigned integer (uint32_t) > * S: String (2 byte length + characters) > * in the rcv_9p() case the data for string is allocated (length omitted, > @@ -153,7 +193,9 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) > va_list ap, aq; > const char *f; > uint32_t intval; > + uint16_t shortval; > uint16_t len; > + uint8_t byte; > char *strval; > > hdr.size = sizeof(hdr); > @@ -167,6 +209,14 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) > { > switch ( *f ) > { > + case 'b': > + hdr.size += 1; > + byte = va_arg(aq, unsigned int); > + break; > + case 'u': > + hdr.size += 2; > + shortval = va_arg(aq, unsigned int); > + break; > case 'U': > hdr.size += 4; > intval = va_arg(aq, unsigned int); > @@ -196,6 +246,14 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) > { > switch ( *f ) > { > + case 'b': > + byte = va_arg(ap, unsigned int); > + copy_to_ring(dev, &byte, sizeof(byte)); > + break; > + case 'u': > + shortval = va_arg(ap, unsigned int); > + copy_to_ring(dev, &shortval, sizeof(shortval)); > + break; > case 'U': > intval = va_arg(ap, unsigned int); > copy_to_ring(dev, &intval, sizeof(intval)); > @@ -288,6 +346,7 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, > char *str; > uint16_t len; > uint32_t err; > + uint16_t *shortval; > uint32_t *val; > char **strval; > uint8_t *qval; > @@ -345,6 +404,10 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, > { > switch ( *f ) > { > + case 'u': > + shortval = va_arg(ap, uint16_t *); > + copy_bufs(&buf1, &buf2, &len1, &len2, shortval, sizeof(*shortval)); > + break; > case 'U': > val = va_arg(ap, uint32_t *); > copy_bufs(&buf1, &buf2, &len1, &len2, val, sizeof(*val)); > @@ -486,6 +549,170 @@ static int p9_attach(struct dev_9pfs *dev) > return ret; > } > > +static int p9_clunk(struct dev_9pfs *dev, uint32_t fid) > +{ > + struct req *req = get_free_req(dev); > + int ret; > + > + if ( !req ) > + return EAGAIN; > + > + req->cmd = P9_CMD_CLUNK; > + send_9p(dev, req, "U", fid); > + rcv_9p(dev, req, ""); > + ret = req->result; > + > + put_free_req(dev, req); > + > + return ret; > +} > + > +static int p9_walk(struct dev_9pfs *dev, uint32_t fid, uint32_t newfid, > + char *name) > +{ > + struct req *req = get_free_req(dev); > + int ret; > + uint16_t nqid; > + uint8_t qid[P9_QID_SIZE]; > + > + if ( !req ) > + return EAGAIN; > + > + req->cmd = P9_CMD_WALK; > + if ( name[0] ) > + { > + send_9p(dev, req, "UUuS", fid, newfid, 1, name); > + rcv_9p(dev, req, "uQ", &nqid, qid); > + } > + else > + { > + send_9p(dev, req, "UUu", fid, newfid, 0); > + rcv_9p(dev, req, "u", &nqid); > + } > + > + ret = req->result; > + > + put_free_req(dev, req); > + > + return ret; > +} > + > +static int p9_open(struct dev_9pfs *dev, uint32_t fid, uint8_t omode) > +{ > + struct req *req = get_free_req(dev); > + int ret; > + uint8_t qid[P9_QID_SIZE]; > + uint32_t iounit; > + > + if ( !req ) > + return EAGAIN; > + > + req->cmd = P9_CMD_OPEN; > + send_9p(dev, req, "Ub", fid, omode); > + rcv_9p(dev, req, "QU", qid, &iounit); > + > + ret = req->result; > + > + put_free_req(dev, req); > + > + return ret; > +} > + > +static int p9_create(struct dev_9pfs *dev, uint32_t fid, char *path, > + uint32_t mode, uint8_t omode) > +{ > + struct req *req = get_free_req(dev); > + int ret; > + uint8_t qid[P9_QID_SIZE]; > + uint32_t iounit; > + > + if ( !req ) > + return EAGAIN; > + > + req->cmd = P9_CMD_CREATE; > + send_9p(dev, req, "USUbS", fid, path, mode, omode, ""); > + rcv_9p(dev, req, "QU", qid, &iounit); > + > + ret = req->result; > + > + put_free_req(dev, req); > + > + return ret; > +} > + > +/* > + * Walk from root levels with the levels listed in <*paths> as a > + * sequence of names. Returns the number of steps not having been able to > + * walk, with <*paths> pointing at the name of the failing walk step. > + * will be associated with the last successful walk step. Note that > + * the first step should always succeed, as it is an empty walk in order > + * to start at the root (needed for creating new files in root). > + */ > +static unsigned int walk_9pfs(struct dev_9pfs *dev, uint32_t fid, > + unsigned int steps, char **paths) > +{ > + uint32_t curr_fid = P9_ROOT_FID; > + int ret; > + > + while ( steps-- ) > + { > + ret = p9_walk(dev, curr_fid, fid, *paths); > + if ( ret ) > + return steps + 1; > + curr_fid = fid; > + *paths += strlen(*paths) + 1; > + } > + > + return 0; > +} > + > +static unsigned int split_path(const char *pathname, char **split_ptr) > +{ > + unsigned int parts = 1; > + char *p; > + > + *split_ptr = strdup(pathname); > + > + for ( p = strchr(*split_ptr, '/'); p; p = strchr(p + 1, '/') ) > + { > + *p = 0; > + parts++; > + } > + > + return parts; > +} > + > +static bool path_canonical(const char *pathname) > +{ > + unsigned int len = strlen(pathname); > + const char *c; > + > + /* Empty path is allowed. */ > + if ( !len ) > + return true; > + > + /* No trailing '/'. */ > + if ( pathname[len - 1] == '/' ) > + return false; > + > + /* No self or parent references. */ > + c = pathname; > + while ( (c = strstr(c, "/.")) != NULL ) > + { > + if ( c[2] == '.' ) > + c++; > + if ( c[2] == 0 || c[2] == '/' ) > + return false; > + c += 2; > + } > + > + /* No "//". */ > + if ( strstr(pathname, "//") ) > + return false; > + > + return true; > +} > + > static int connect_9pfs(struct dev_9pfs *dev) > { > int ret; > @@ -504,10 +731,101 @@ static void intr_9pfs(evtchn_port_t port, struct pt_regs *regs, void *data) > wake_up(&dev->waitq); > } > > +static int close_9pfs(struct file *file) > +{ > + struct file_9pfs *f9pfs = file->filedata; > + > + if ( f9pfs->fid != P9_ROOT_FID ) > + { > + p9_clunk(f9pfs->dev, f9pfs->fid); > + put_fid(f9pfs->dev, f9pfs->fid); > + } > + > + free(f9pfs); > + > + return 0; > +} > + > static int open_9pfs(struct mount_point *mnt, const char *pathname, int flags, > mode_t mode) > { > - errno = ENOSYS; > + int fd; > + char *path = NULL; > + char *p; > + struct file *file; > + struct file_9pfs *f9pfs; > + uint16_t nwalk; > + uint8_t omode; > + int ret; > + > + if ( !path_canonical(pathname) ) > + return EINVAL; > + > + f9pfs = calloc(1, sizeof(*f9pfs)); > + f9pfs->dev = mnt->dev; > + f9pfs->fid = P9_ROOT_FID; > + > + fd = alloc_fd(ftype_9pfs); > + file = get_file_from_fd(fd); > + file->filedata = f9pfs; > + > + switch ( flags & O_ACCMODE ) > + { > + case O_RDONLY: > + omode = P9_OREAD; > + break; > + case O_WRONLY: > + omode = P9_OWRITE; > + break; > + case O_RDWR: > + omode = P9_ORDWR; > + break; > + default: > + ret = EINVAL; > + goto err; > + } > + > + if ( flags & O_TRUNC ) > + omode |= P9_OTRUNC; > + f9pfs->append = flags & O_APPEND; > + > + nwalk = split_path(pathname, &path); > + > + f9pfs->fid = get_fid(mnt->dev); > + if ( !f9pfs->fid ) > + { > + ret = ENFILE; > + goto err; > + } > + p = path; > + nwalk = walk_9pfs(mnt->dev, f9pfs->fid, nwalk, &p); > + if ( nwalk ) > + { > + if ( nwalk > 1 || !(flags & O_CREAT) ) > + { > + ret = ENOENT; > + goto err; > + } > + > + ret = p9_create(mnt->dev, f9pfs->fid, p, mode, omode); > + if ( ret ) > + goto err; > + goto out; > + } > + > + ret = p9_open(mnt->dev, f9pfs->fid, omode); > + if ( ret ) > + goto err; > + > + out: > + free(path); > + > + return fd; > + > + err: > + free(path); > + close(fd); > + errno = ret; > > return -1; > } > @@ -552,6 +870,7 @@ void *init_9pfront(unsigned int id, const char *mnt) > init_waitqueue_head(&dev->waitq); > init_SEMAPHORE(&dev->ring_out_sem, 1); > init_SEMAPHORE(&dev->ring_in_sem, 1); > + dev->fid_mask = ~0ULL; > > for ( i = 0; i < N_REQS; i++ ) > { > @@ -753,6 +1072,7 @@ void shutdown_9pfront(void *dev) > > static const struct file_ops ops_9pfs = { > .name = "9pfs", > + .close = close_9pfs, > }; > > __attribute__((constructor)) > -- > 2.35.3 > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria. From minios-devel-bounces@lists.xenproject.org Mon Feb 13 23:13:18 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 13 Feb 2023 23:13:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494863.765020 (Exim 4.92) (envelope-from ) id 1pRi0c-0004rY-7v; Mon, 13 Feb 2023 23:13:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494863.765020; Mon, 13 Feb 2023 23:13:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRi0c-0004rR-5P; Mon, 13 Feb 2023 23:13:18 +0000 Received: by outflank-mailman (input) for mailman id 494863; Mon, 13 Feb 2023 23:13:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRi0a-0004r4-Go for minios-devel@lists.xenproject.org; Mon, 13 Feb 2023 23:13:16 +0000 Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fde687da-abf3-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 00:13:15 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 3EB982015E; Tue, 14 Feb 2023 00:13:14 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o0yD5qTvQaE0; Tue, 14 Feb 2023 00:13:14 +0100 (CET) Received: from begin (lfbn-bor-1-1163-184.w92-158.abo.wanadoo.fr [92.158.138.184]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 17D792013C; Tue, 14 Feb 2023 00:13:14 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pRi0X-00FwK0-2O; Tue, 14 Feb 2023 00:13:13 +0100 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: fde687da-abf3-11ed-933c-83870f6b2ba8 Date: Tue, 14 Feb 2023 00:13:13 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH v3 7/7] Mini-OS: add read and write support to 9pfsfront Message-ID: <20230213231313.hryz7fynrpztzmf2@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230213084412.21065-1-jgross@suse.com> <20230213084412.21065-8-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230213084412.21065-8-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le lun. 13 févr. 2023 09:44:12 +0100, a ecrit: > Add support to read from and write to a file handled by 9pfsfront. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V2: > - add check for max message size > - return EAGAIN in case no free request got (Samuel Thibault) > - loop until all data read/written (Samuel Thibault) > V3: > - use an exact limit for read/write (Samuel Thibault) > - log read(write errors (Samuel Thibault) > --- > 9pfront.c | 216 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 216 insertions(+) > > diff --git a/9pfront.c b/9pfront.c > index fb2e5669..5da8a365 100644 > --- a/9pfront.c > +++ b/9pfront.c > @@ -72,7 +72,10 @@ struct file_9pfs { > #define P9_CMD_WALK 110 > #define P9_CMD_OPEN 112 > #define P9_CMD_CREATE 114 > +#define P9_CMD_READ 116 > +#define P9_CMD_WRITE 118 > #define P9_CMD_CLUNK 120 > +#define P9_CMD_STAT 124 > > /* P9 protocol open flags. */ > #define P9_OREAD 0 /* read */ > @@ -88,11 +91,39 @@ struct p9_header { > uint16_t tag; > } __attribute__((packed)); > > +struct p9_stat { > + uint16_t size; > + uint16_t type; > + uint32_t dev; > + uint8_t qid[P9_QID_SIZE]; > + uint32_t mode; > + uint32_t atime; > + uint32_t mtime; > + uint64_t length; > + char *name; > + char *uid; > + char *gid; > + char *muid; > + char *extension; > + uint32_t n_uid; > + uint32_t n_gid; > + uint32_t n_muid; > +}; > + > #define P9_VERSION "9P2000.u" > #define P9_ROOT_FID 0 > > static unsigned int ftype_9pfs; > > +static void free_stat(struct p9_stat *stat) > +{ > + free(stat->name); > + free(stat->uid); > + free(stat->gid); > + free(stat->muid); > + free(stat->extension); > +} > + > static unsigned int get_fid(struct dev_9pfs *dev) > { > unsigned int fid; > @@ -181,9 +212,12 @@ static void copy_from_ring(struct dev_9pfs *dev, void *data, unsigned int len) > * Only valid for sending. > * u: 2 byte unsigned integer (uint16_t) > * U: 4 byte unsigned integer (uint32_t) > + * L: 8 byte unsigned integer (uint64_t) > * S: String (2 byte length + characters) > * in the rcv_9p() case the data for string is allocated (length omitted, > * string terminated by a NUL character) > + * D: Binary data (4 byte length + bytes of data), requires a length > + * and a buffer pointer parameter. > * Q: A 13 byte "qid", consisting of 1 byte file type, 4 byte file version > * and 8 bytes unique file id. Only valid for receiving. > */ > @@ -192,10 +226,12 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) > struct p9_header hdr; > va_list ap, aq; > const char *f; > + uint64_t longval; > uint32_t intval; > uint16_t shortval; > uint16_t len; > uint8_t byte; > + uint8_t *data; > char *strval; > > hdr.size = sizeof(hdr); > @@ -221,11 +257,21 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) > hdr.size += 4; > intval = va_arg(aq, unsigned int); > break; > + case 'L': > + hdr.size += 8; > + longval = va_arg(aq, uint64_t); > + break; > case 'S': > hdr.size += 2; > strval = va_arg(aq, char *); > hdr.size += strlen(strval); > break; > + case 'D': > + hdr.size += 4; > + intval = va_arg(aq, unsigned int); > + hdr.size += intval; > + data = va_arg(aq, uint8_t *); > + break; > default: > printk("send_9p: unknown format character %c\n", *f); > break; > @@ -258,12 +304,22 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) > intval = va_arg(ap, unsigned int); > copy_to_ring(dev, &intval, sizeof(intval)); > break; > + case 'L': > + longval = va_arg(ap, uint64_t); > + copy_to_ring(dev, &longval, sizeof(longval)); > + break; > case 'S': > strval = va_arg(ap, char *); > len = strlen(strval); > copy_to_ring(dev, &len, sizeof(len)); > copy_to_ring(dev, strval, len); > break; > + case 'D': > + intval = va_arg(ap, unsigned int); > + copy_to_ring(dev, &intval, sizeof(intval)); > + data = va_arg(ap, uint8_t *); > + copy_to_ring(dev, data, intval); > + break; > } > } > > @@ -348,6 +404,8 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, > uint32_t err; > uint16_t *shortval; > uint32_t *val; > + uint64_t *longval; > + uint8_t *data; > char **strval; > uint8_t *qval; > > @@ -412,6 +470,10 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, > val = va_arg(ap, uint32_t *); > copy_bufs(&buf1, &buf2, &len1, &len2, val, sizeof(*val)); > break; > + case 'L': > + longval = va_arg(ap, uint64_t *); > + copy_bufs(&buf1, &buf2, &len1, &len2, longval, sizeof(*longval)); > + break; > case 'S': > strval = va_arg(ap, char **); > copy_bufs(&buf1, &buf2, &len1, &len2, &len, sizeof(len)); > @@ -419,6 +481,12 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, > copy_bufs(&buf1, &buf2, &len1, &len2, *strval, len); > (*strval)[len] = 0; > break; > + case 'D': > + val = va_arg(ap, uint32_t *); > + data = va_arg(ap, uint8_t *); > + copy_bufs(&buf1, &buf2, &len1, &len2, val, sizeof(*val)); > + copy_bufs(&buf1, &buf2, &len1, &len2, data, *val); > + break; > case 'Q': > qval = va_arg(ap, uint8_t *); > copy_bufs(&buf1, &buf2, &len1, &len2, qval, P9_QID_SIZE); > @@ -640,6 +708,115 @@ static int p9_create(struct dev_9pfs *dev, uint32_t fid, char *path, > return ret; > } > > +static int p9_stat(struct dev_9pfs *dev, uint32_t fid, struct p9_stat *stat) > +{ > + struct req *req = get_free_req(dev); > + int ret; > + > + if ( !req ) > + return EAGAIN; > + > + memset(stat, 0, sizeof(*stat)); > + req->cmd = P9_CMD_STAT; > + send_9p(dev, req, "U", fid); > + rcv_9p(dev, req, "uuUQUUULSSSSSUUU", &stat->size, &stat->type, &stat->dev, > + stat->qid, &stat->mode, &stat->atime, &stat->mtime, &stat->length, > + &stat->name, &stat->uid, &stat->gid, &stat->muid, &stat->extension, > + &stat->n_uid, &stat->n_gid, &stat->n_muid); > + > + ret = req->result; > + > + put_free_req(dev, req); > + > + return ret; > +} > + > +static int p9_read(struct dev_9pfs *dev, uint32_t fid, uint64_t offset, > + uint8_t *data, uint32_t len) > +{ > + struct req *req = get_free_req(dev); > + int ret = 0; > + uint32_t count, count_max; > + > + if ( !req ) > + { > + errno = EAGAIN; > + return -1; > + } > + req->cmd = P9_CMD_READ; > + count_max = dev->msize_max - (sizeof(struct p9_header) + sizeof(uint32_t)); > + > + while ( len ) > + { > + count = len; > + if ( count > count_max ) > + count = count_max; > + > + send_9p(dev, req, "ULU", fid, offset, count); > + rcv_9p(dev, req, "D", &count, data); > + > + if ( !count ) > + break; > + if ( req->result ) > + { > + ret = -1; > + errno = EIO; > + printk("9pfs: read got error %d\n", req->result); > + break; > + } > + ret += count; > + offset += count; > + data += count; > + len -= count; > + } > + > + put_free_req(dev, req); > + > + return ret; > +} > + > +static int p9_write(struct dev_9pfs *dev, uint32_t fid, uint64_t offset, > + const uint8_t *data, uint32_t len) > +{ > + struct req *req = get_free_req(dev); > + int ret = 0; > + uint32_t count, count_max; > + > + if ( !req ) > + { > + errno = EAGAIN; > + return -1; > + } > + req->cmd = P9_CMD_WRITE; > + count_max = dev->msize_max - (sizeof(struct p9_header) + sizeof(uint32_t) + > + sizeof(uint64_t) + sizeof(uint32_t)); > + > + while ( len ) > + { > + count = len; > + if ( count > count_max ) > + count = count_max; > + > + send_9p(dev, req, "ULD", fid, offset, count, data); > + rcv_9p(dev, req, "U", &count); > + if ( req->result ) > + { > + ret = -1; > + errno = EIO; > + printk("9pfs: write got error %d\n", req->result); > + break; > + } > + ret += count; > + offset += count; > + data += count; > + len -= count; > + } > + > + put_free_req(dev, req); > + > + return ret; > +} > + > /* > * Walk from root levels with the levels listed in <*paths> as a > * sequence of names. Returns the number of steps not having been able to > @@ -731,6 +908,43 @@ static void intr_9pfs(evtchn_port_t port, struct pt_regs *regs, void *data) > wake_up(&dev->waitq); > } > > +static int read_9pfs(struct file *file, void *buf, size_t nbytes) > +{ > + struct file_9pfs *f9pfs = file->filedata; > + int ret; > + > + ret = p9_read(f9pfs->dev, f9pfs->fid, file->offset, buf, nbytes); > + if ( ret >= 0 ) > + file->offset += ret; > + > + return ret; > +} > + > +static int write_9pfs(struct file *file, const void *buf, size_t nbytes) > +{ > + struct file_9pfs *f9pfs = file->filedata; > + struct p9_stat stat; > + int ret; > + > + if ( f9pfs->append ) > + { > + ret = p9_stat(f9pfs->dev, f9pfs->fid, &stat); > + free_stat(&stat); > + if ( ret ) > + { > + errno = EIO; > + return -1; > + } > + file->offset = stat.length; > + } > + > + ret = p9_write(f9pfs->dev, f9pfs->fid, file->offset, buf, nbytes); > + if ( ret >= 0 ) > + file->offset += ret; > + > + return ret; > +} > + > static int close_9pfs(struct file *file) > { > struct file_9pfs *f9pfs = file->filedata; > @@ -1072,6 +1286,8 @@ void shutdown_9pfront(void *dev) > > static const struct file_ops ops_9pfs = { > .name = "9pfs", > + .read = read_9pfs, > + .write = write_9pfs, > .close = close_9pfs, > }; > > -- > 2.35.3 > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria. From minios-devel-bounces@lists.xenproject.org Mon Feb 13 23:13:27 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 13 Feb 2023 23:13:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494865.765035 (Exim 4.92) (envelope-from ) id 1pRi0l-0005Bg-Hq; Mon, 13 Feb 2023 23:13:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494865.765035; Mon, 13 Feb 2023 23:13:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRi0l-0005BY-F3; Mon, 13 Feb 2023 23:13:27 +0000 Received: by outflank-mailman (input) for mailman id 494865; Mon, 13 Feb 2023 23:13:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRi0k-0004r4-9m for minios-devel@lists.xenproject.org; Mon, 13 Feb 2023 23:13:26 +0000 Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 04819dda-abf4-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 00:13:25 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 51D392015E; Tue, 14 Feb 2023 00:13:25 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I6mMgcOWUcc4; Tue, 14 Feb 2023 00:13:25 +0100 (CET) Received: from begin (lfbn-bor-1-1163-184.w92-158.abo.wanadoo.fr [92.158.138.184]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 33F742013C; Tue, 14 Feb 2023 00:13:25 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pRi0i-00FwLB-2v; Tue, 14 Feb 2023 00:13:24 +0100 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 04819dda-abf4-11ed-933c-83870f6b2ba8 Date: Tue, 14 Feb 2023 00:13:24 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH v3 0/7] Mini-OS: add minimal 9pfs support Message-ID: <20230213231324.zfax6v5elvndzky3@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230213084412.21065-1-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230213084412.21065-1-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Thanks!! Juergen Gross, le lun. 13 févr. 2023 09:44:05 +0100, a ecrit: > This series is adding minimal support to use 9pfs in Mini-OS. It is > adding a PV 9pfs frontend and the ability to open, close, read and > write files. > > The series has been tested with qemu as 9pfs backend in a PVH Mini-OS > guest (I've used a slightly modified Xenstore-stubdom for that purpose > in order to reuse the build runes). > > This series is meant to setup the stage for adding file based logging > support to Xenstore-stubdom and later to add live update support (being > able to save the LU data stream in a dom0 file makes this a _lot_ > easier). > > In order to keep Mini-OS's license I have only used the protocol docs > available on the internet [1] and then verified those with the qemu 9pfs > backend implementation (especially for supporting the 9P2000.u variant, > as qemu doesn't support the basic 9P2000 protocol). > > The needed fixed values of the protocol have been taken from [2]. > > [1]: http://ericvh.github.io/9p-rfc/rfc9p2000.html > [2]: https://github.com/0intro/libixp > > Changes in V2: > - addressed comments by Samuel Thibault > > Changes in V3: > - addressed comments by Samuel Thibault and Andrew Cooper > > Juergen Gross (7): > Mini-OS: xenbus: add support for reading node from directory > Mini-OS: add concept of mount points > Mini-OS: add support for runtime mounts > Mini-OS: add 9pfs frontend > Mini-OS: add 9pfs transport layer > Mini-OS: add open and close handling to the 9pfs frontend > Mini-OS: add read and write support to 9pfsfront > > 9pfront.c | 1300 +++++++++++++++++++++++++++++++++ > Config.mk | 1 + > Makefile | 1 + > arch/x86/testbuild/all-no | 1 + > arch/x86/testbuild/all-yes | 1 + > arch/x86/testbuild/newxen-yes | 1 + > include/9pfront.h | 7 + > include/lib.h | 14 + > include/xenbus.h | 6 + > lib/sys.c | 123 +++- > xenbus.c | 40 +- > 11 files changed, 1473 insertions(+), 22 deletions(-) > create mode 100644 9pfront.c > create mode 100644 include/9pfront.h > > -- > 2.35.3 > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria.