From minios-devel-bounces@lists.xenproject.org Tue Oct 24 10:20:59 2023
Return-path: <minios-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xenproject.org
Delivery-date: Tue, 24 Oct 2023 10:20:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.621809.968620 (Exim 4.92)
	(envelope-from <minios-devel-bounces@lists.xenproject.org>)
	id 1qvEWr-0001um-Ss; Tue, 24 Oct 2023 10:20:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 621809.968620; Tue, 24 Oct 2023 10:20:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <minios-devel-bounces@lists.xenproject.org>)
	id 1qvEWr-0001uf-Pb; Tue, 24 Oct 2023 10:20:53 +0000
Received: by outflank-mailman (input) for mailman id 621809;
 Tue, 24 Oct 2023 10:20:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=krZT=GG=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1qvEWq-0001uZ-FP
 for minios-devel@lists.xenproject.org; Tue, 24 Oct 2023 10:20:52 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on20605.outbound.protection.outlook.com
 [2a01:111:f400:7e1a::605])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ffd94df3-7256-11ee-9b0e-b553b5be7939;
 Tue, 24 Oct 2023 12:20:48 +0200 (CEST)
Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23)
 by VE1PR04MB7326.eurprd04.prod.outlook.com (2603:10a6:800:1b0::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.16; Tue, 24 Oct
 2023 10:20:43 +0000
Received: from DU2PR04MB8790.eurprd04.prod.outlook.com
 ([fe80::d924:b650:a2ad:7b25]) by DU2PR04MB8790.eurprd04.prod.outlook.com
 ([fe80::d924:b650:a2ad:7b25%3]) with mapi id 15.20.6933.011; Tue, 24 Oct 2023
 10:20:43 +0000
X-BeenThere: minios-devel@lists.xenproject.org
List-Id: Mini-os development list <minios-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/minios-devel>, 
 <mailto:minios-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:minios-devel@lists.xenproject.org>
List-Help: <mailto:minios-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/minios-devel>, 
 <mailto:minios-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: minios-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Minios-devel" <minios-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ffd94df3-7256-11ee-9b0e-b553b5be7939
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=l7oTvfw9BnzgyNhk1WwwKIENdRpNQ4zQWxPbEe4oOhE4COA1j/JPkET21zfoGcHtQOGEFNbdKUqKD7o7GVGDwWa+IFX88Ei+3QKU2uAPjAfFaw6BUXanVlrW/j5e1YleGPu66I9VI+FVw91eIkYPjdcp210wkxGpz/FyFGIJ7+/8MD7fjDxfsnYOPnCGCxYGePuGkKOkA+P6TwX8O/ybsy7dlcpZmvHT5GYrljYVp6qNgKjGr5OS0mK4e56qvwNqYxjBx7llGTifOcuHKLIgG6rTKnhCWazoh/+GNeP3shx2Esrj530moxI3M3qOc025Hf6L/979m+qm1ufewfGG+Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2+IzVlAFtYSdi/KBkFxlM3USq41aid8eoLDw79Ig6ZA=;
 b=Ujt38b1lgZTWwCtG1RTlHp+gLJztqW/Qj2/9maE1xac0icNl1742nI4uYCHtfMeBdDnIu2rJUGAlonze9NLOyl9rRK5noPUODbIy7WVQPMEtzVQu9wUMSfTRUuvfocc/SzZ0dyxR2KSHLlB1nLS1kJS8wBD2Ebjix+/yZDwl4JWi3Hc7VYeTjxjsQSSBh8ZLA1FvZKxTbyOKXBlvDt36e3yhesiqVFtyf9f6imNEY1/K2z6LxLlYjactamUvakKxPIxqjoYti75uQMdsjpXiEFdGw5NwbdZU4vTx9rR5lvP9lZC/irBowDHMoc0PPJtYOmngLLIZtfZCkodXpqc7dw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2+IzVlAFtYSdi/KBkFxlM3USq41aid8eoLDw79Ig6ZA=;
 b=AI1XdEQ+Okyh2GGo161OpPq1cmF2VcFoi8lkL+yIQ0GxF7DNjS8T746EJHKVbxu+3fMuP2nBlCg7n48BXClCFqEk5FUzXydpcyybarmzaNo2n8sD/Mhoau2N9/cZ0xNZe0gEr7KKW/dfwHPQmchp+/FlLpKuLL5GbwdwO02gHv7vs86KM6i7HhGyQ/X4Ht6GlUtUYVvWpbdVnhcNRyUy2zt9OaM6WnHQwa9h3eBIZ5CMgiek9XbuLKO9Qc7Zt9JBBwpRV47936egwH8FVRxfRkn7nwhkjPMUZ+/sZbN3wnzbe+j7J/rdWAn6xkRIcQtrTiSbJ79MN5L88Kr5+IewtQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1c2d5b1b-27f5-bd56-78e1-2321b76c71da@suse.com>
Date: Tue, 24 Oct 2023 12:20:40 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Content-Language: en-US
To: Minios-devel <minios-devel@lists.xenproject.org>
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>, Wei Liu <wl@xen.org>,
 Juergen Gross <jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] build: silence GNU ld 2.39 warning about executable stacks
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0205.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a5::17) To DU2PR04MB8790.eurprd04.prod.outlook.com
 (2603:10a6:10:2e1::23)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|VE1PR04MB7326:EE_
X-MS-Office365-Filtering-Correlation-Id: 919e24f7-95a6-406f-12fe-08dbd47ae10f
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	00Rc66QeX+echwvyoS/oATidVvqLy+z+b0M75HKR+EjMwzg/cFue8TJn3eMJNI4eA0W9P5sUmBZ0OkFWJdaOdnCPpocMnzYiu9sObJh/I0f/wRhLvwbeGND1ewlmg69w7z+vfF74cN9jA+45MCUHOFkNoC+TdW53IvqIit/JT8kpTyXyjWGvWhmX+f0BPLV1l33UdHvTU/T0pzVqxDVtA8fxL7Fi+EvHJzLjWa7vGfQ87XxQb84IQiXo9mBlDS5UMiqE2UEfIGDx+t1FrCOXXigV6POd9RxqlhV/jy75vsQJLCBGNfR/PwPgtrb8+cybsnxrCTQ8LYRmbK0f5DDw/5cjzTY0XRLz0urJoatTMj4OcYmKwP2gkX5qGNjqQZI8i8FO4n59+09O/R2M1oIchsZIkdFGqhKUjEdgH7PmZDmRq/ovJMl/Jlic5vg8BbVZfCA77/nlpc0sJIa97e8SKwBncibzq4BYeN8Mk6eAlOsngx4FsgnftnOrYGAaL0uGfl8nLkI8KEzooXd6E1HZaYgtMmAjG8nioOwfO12+ag9y8a+8wQBuey+2LGBxjWautjoW+6KgJSSy3dipuuPlU7zjOuMydkl1rL0gfo+4sV9E3jooPC24sUleRlBrKG/6dLCR/DpM+FrvU/96CdDDhA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(346002)(366004)(396003)(376002)(136003)(230922051799003)(64100799003)(451199024)(1800799009)(186009)(31686004)(6512007)(6506007)(6486002)(478600001)(38100700002)(86362001)(31696002)(36756003)(2906002)(83380400001)(107886003)(2616005)(26005)(54906003)(66556008)(66946007)(316002)(6916009)(66476007)(5660300002)(4326008)(41300700001)(8936002)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VDRZSGNRMDYwdS9uNHNmSEFhbTlJQ2JVV3duMW96L0sxTWxRZWY1dFZvNmFD?=
 =?utf-8?B?UWRtQ1BNbjY5aDdQY21sK3M3cmptYnp2dkR6R21tYkthd05BN2doeGwwQ0Y1?=
 =?utf-8?B?SnBCa3FtVjRza0JkYy9hbXJ1dU9ST1Yzclh5cG41MnZiYVMySUVmMEllMVZv?=
 =?utf-8?B?cEk4R3VqT0hXSXFVaUZndVc5QjNCZFY5Z295Z1o2bUtOWkZ6L0xSQnlpVmdj?=
 =?utf-8?B?UmduWHRkWGtQRWp3UFRkN3U2d0xiUEg5cW12QTBtRndrZkkxeDN2RzNSRVQz?=
 =?utf-8?B?L2tHV3ZyRFVmUi9MR0l6aFJRZldkdE4wTFpqOVREUkZuWmIrOXcyUEEyR3Yr?=
 =?utf-8?B?NmVGazdoTVYvQWwvVGZod2xyYk15eWZoMWNWbWdnTVB6dHI2b0tDWXVGejcr?=
 =?utf-8?B?bmdSZ0l2V202TmFzS1c0cHZ1V3NtWU9uWkd5L0xBbVFCd1JmMnIwR1lmQVNI?=
 =?utf-8?B?WnZSV2MzSS9UUEpTeTlkTUp4QXhvRmZVZkU5N3l4K3ZlYUVlWGY5VzFSOHMy?=
 =?utf-8?B?bG1XcHY0bTdvdWR5QUdUWEtQdE9uN1ZyL25sOFBwcWdjUmI1c3ppMTg2UHla?=
 =?utf-8?B?L1JYSVRCZy9Ka2JsWjRDeXMzamZaRVhyQmwvZ1BkMWN3YjNJSDRweGIvRERy?=
 =?utf-8?B?UnpWTWNWQ1hPenhUQnNsUWdSMXd5MkIvbFEvL0M4bWZ2eFZFdnJ1VXdmWGxU?=
 =?utf-8?B?a0dRV0FsczdiajBPUEhQQ0hnOFA3cXg2OWZZSjZTcVNVbXd3ckJiUjVZWitO?=
 =?utf-8?B?ZksyTDVlMWIzR0ZlTmd6OGxra256WExKcnJHNVdVMk96SWNMR0xQeUpzcm9J?=
 =?utf-8?B?dHRvckNEa0RnUGE4Y2didUp1Y2pjNDdkQ2IrTE1USHJhMllKRXRGbHJUWkJZ?=
 =?utf-8?B?Y0Q1VmtxeW1OZ1pLbWU5ZkJXME84eWgwYkpwZEtYbVdLRXFQeWhWZW5TaXBm?=
 =?utf-8?B?N1E3UStrbUw1NXNLcmppa05kSjZGakRHeXQ4YzgwQ05nOVpFbkc5WXJRVHJE?=
 =?utf-8?B?TWk5L0t6akFGMHBKYXowWjBDNDNMMHRLY0VwdDZnRGhGOVU1L3lHd1E4T3B2?=
 =?utf-8?B?a3A3R08waDlSSldkcXA5WVhBZmNreG91dE1XWkFoUkd1RVd3T2xjUnhBa1NG?=
 =?utf-8?B?ckg2WVhIYnpUNXpWRGgvWTZYditKQjNmRnI1YS84dzZzMGRvM1oxbzZSdjJF?=
 =?utf-8?B?ZHNsZS9qVXZqUDRUWWIyaUZ0L3pweGpzQUlBMGJLUGhnanh2NDNLeXNLbGVX?=
 =?utf-8?B?d29WZFJMem1xUjBndTJEcHZTdzZDejcwVy93RnFOeTZzM1FSdnVzUzhuNmEx?=
 =?utf-8?B?SzNPcUhwem9IUDR2UlpQSS9JcTJmL3J0OUdxeDE1dGhrMHlIRmRNUUdYQzBC?=
 =?utf-8?B?azJUZldBdk9ZOTVhcGxETk1yRCtXQ1lIcnlPOENGTXNTZk41b3lCL2szeHFO?=
 =?utf-8?B?aEZRZUl1YmFBR2N5UHcxYWZ0NDBsY3VZbWxHSDQ4VFZPcWZEbzVyUGxBQ3ZH?=
 =?utf-8?B?UlFoeEV6dG9jQTZFT0dReVByMW4zdHJUYmhLQUxvWWRNU093NjBHd3ZCSFpy?=
 =?utf-8?B?TGtDa2FZM0l1MEwxbDV4VEhYcFVteUxrYkVmcEhXL3NjN1ZMcDM2TzFoOW1W?=
 =?utf-8?B?SzFQUXJPWlRtcFZPbkRocmxrTkFPdXQwTXRVWkQ3ckhpWGJsM0hoZ1QrSGFx?=
 =?utf-8?B?RkVKSkJiV1dUS0E2d2VuZDlWZ3prekZSVnAxVGZNYXBlcDFXcFQxdFhEZWxx?=
 =?utf-8?B?dFU4SytSdUVuR0tSOGNaNlNBNzQ3cFlQbjU3MlJkbkNpMTk0UnVIVldSUys3?=
 =?utf-8?B?Z3IvY0R5a0oxTjhMbzAxVzVZenZkbkpwdWNqSmxMd3hzeWVCeDVyb2l0cVda?=
 =?utf-8?B?NUNONVE5c2NkbmtPZHlkalBEaWNwMTQvMFIxSW9DSEhrZWd6bTQ1a0E3ZzlF?=
 =?utf-8?B?NzVveXQxdERxTHdVb24vSWJlNUxKMk5MQndrUXdSaWZSc2x3anoxRktWbUZu?=
 =?utf-8?B?MS9oWHBucnVQKy9NRU8xWDYyU2p2SkU1MG1ZbTdJbyt3ODJkOXZSM1h4TVB4?=
 =?utf-8?B?UHY5Y1Y4dmhjdi92bnpIYzNCUis1Q0F3djhFZStFaXpVclZIQW5SWEcwMXo2?=
 =?utf-8?Q?URmqmo1FO9GPBC+P+Rb23G53j?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 919e24f7-95a6-406f-12fe-08dbd47ae10f
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2023 10:20:43.1222
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MX3y+ERI2k+WR5uNrr7L26Q35dpQpZxgg7TyqVG88oxg7mZrpUVBgzcNractQZs3fu3+ARp1LEJ6egXFmf4YGQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7326

While for C files the compiler is supposed to arrange for emitting
respective information, for assembly sources we're responsible ourselves.

For the new use of cc-option to work we cannot pass -S to the compiler
anymore. We need the compiler to actually invoke the assembler, so switch
to using -c.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/Config.mk
+++ b/Config.mk
@@ -1,4 +1,6 @@
-#
+# Convenient variables
+comma := ,
+
 # Compare $(1) and $(2) and replace $(2) with $(1) if they differ
 #
 # Typically $(1) is a newly generated file and $(2) is the target file
@@ -20,7 +22,7 @@ endef
 #
 # Usage: cflags-y += $(call cc-option,$(CC),-march=winchip-c6,-march=i586)
 cc-option = $(shell if test -z "`echo 'void*p=1;' | \
-              $(1) $(2) -S -o /dev/null -x c - 2>&1 | grep -- $(2) -`"; \
+              $(1) $(2) -c -o /dev/null -x c - 2>&1 | grep -- $(2) -`"; \
               then echo "$(2)"; else echo "$(3)"; fi ;)
 
 ifneq ($(MINIOS_CONFIG),)
--- a/minios.mk
+++ b/minios.mk
@@ -28,6 +28,10 @@ endif
 # Make the headers define our internal stuff
 DEF_CFLAGS += -D__INSIDE_MINIOS__
 
+# Arrange for assembly files to have a proper .note.GNU-stack section added,
+# to silence warnings otherwise issued by GNU ld 2.39 and newer.
+DEF_ASFLAGS += $(call cc-option,$(CC),-Wa$(comma)--noexecstack)
+
 # Build the CFLAGS and ASFLAGS for compiling and assembling.
 # DEF_... flags are the common mini-os flags,
 # ARCH_... flags may be defined in arch/$(TARGET_ARCH_FAM/rules.mk


From minios-devel-bounces@lists.xenproject.org Tue Oct 24 10:39:24 2023
Return-path: <minios-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xenproject.org
Delivery-date: Tue, 24 Oct 2023 10:39:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.621825.968664 (Exim 4.92)
	(envelope-from <minios-devel-bounces@lists.xenproject.org>)
	id 1qvEol-0007bz-35; Tue, 24 Oct 2023 10:39:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 621825.968664; Tue, 24 Oct 2023 10:39:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <minios-devel-bounces@lists.xenproject.org>)
	id 1qvEol-0007bs-0J; Tue, 24 Oct 2023 10:39:23 +0000
Received: by outflank-mailman (input) for mailman id 621825;
 Tue, 24 Oct 2023 10:39:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=MYTl=GG=ens-lyon.org=samuel.thibault@bounce.ens-lyon.org>)
 id 1qvEoj-0007bm-R3
 for minios-devel@lists.xenproject.org; Tue, 24 Oct 2023 10:39:21 +0000
Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 95b573b2-7259-11ee-9b0e-b553b5be7939;
 Tue, 24 Oct 2023 12:39:19 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
 by sonata.ens-lyon.org (Postfix) with ESMTP id 24E1B200EC;
 Tue, 24 Oct 2023 12:39:18 +0200 (CEST)
Received: from sonata.ens-lyon.org ([127.0.0.1])
 by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id Lk7cwXmflzlq; Tue, 24 Oct 2023 12:39:16 +0200 (CEST)
Received: from begin (nat-inria-interne-52-gw-01-bso.bordeaux.inria.fr
 [194.199.1.52])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest
 SHA256) (No client certificate requested)
 by sonata.ens-lyon.org (Postfix) with ESMTPSA id C4CB7200EB;
 Tue, 24 Oct 2023 12:39:16 +0200 (CEST)
Received: from samy by begin with local (Exim 4.97-RC2)
 (envelope-from <samuel.thibault@ens-lyon.org>)
 id 1qvEoe-0000000AAiD-1YiI; Tue, 24 Oct 2023 12:39:16 +0200
X-BeenThere: minios-devel@lists.xenproject.org
List-Id: Mini-os development list <minios-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/minios-devel>, 
 <mailto:minios-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:minios-devel@lists.xenproject.org>
List-Help: <mailto:minios-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/minios-devel>, 
 <mailto:minios-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: minios-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Minios-devel" <minios-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 95b573b2-7259-11ee-9b0e-b553b5be7939
Date: Tue, 24 Oct 2023 12:39:16 +0200
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Jan Beulich <jbeulich@suse.com>
Cc: Minios-devel <minios-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>,
	Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH] build: silence GNU ld 2.39 warning about executable
 stacks
Message-ID: <20231024103916.dqulronf2ieht2rn@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Jan Beulich <jbeulich@suse.com>,
	Minios-devel <minios-devel@lists.xenproject.org>,
	Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>
References: <1c2d5b1b-27f5-bd56-78e1-2321b76c71da@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1c2d5b1b-27f5-bd56-78e1-2321b76c71da@suse.com>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)

Jan Beulich, le mar. 24 oct. 2023 12:20:40 +0200, a ecrit:
> While for C files the compiler is supposed to arrange for emitting
> respective information, for assembly sources we're responsible ourselves.
> 
> For the new use of cc-option to work we cannot pass -S to the compiler
> anymore. We need the compiler to actually invoke the assembler, so switch
> to using -c.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> 
> --- a/Config.mk
> +++ b/Config.mk
> @@ -1,4 +1,6 @@
> -#
> +# Convenient variables
> +comma := ,
> +
>  # Compare $(1) and $(2) and replace $(2) with $(1) if they differ
>  #
>  # Typically $(1) is a newly generated file and $(2) is the target file
> @@ -20,7 +22,7 @@ endef
>  #
>  # Usage: cflags-y += $(call cc-option,$(CC),-march=winchip-c6,-march=i586)
>  cc-option = $(shell if test -z "`echo 'void*p=1;' | \
> -              $(1) $(2) -S -o /dev/null -x c - 2>&1 | grep -- $(2) -`"; \
> +              $(1) $(2) -c -o /dev/null -x c - 2>&1 | grep -- $(2) -`"; \
>                then echo "$(2)"; else echo "$(3)"; fi ;)
>  
>  ifneq ($(MINIOS_CONFIG),)
> --- a/minios.mk
> +++ b/minios.mk
> @@ -28,6 +28,10 @@ endif
>  # Make the headers define our internal stuff
>  DEF_CFLAGS += -D__INSIDE_MINIOS__
>  
> +# Arrange for assembly files to have a proper .note.GNU-stack section added,
> +# to silence warnings otherwise issued by GNU ld 2.39 and newer.
> +DEF_ASFLAGS += $(call cc-option,$(CC),-Wa$(comma)--noexecstack)
> +
>  # Build the CFLAGS and ASFLAGS for compiling and assembling.
>  # DEF_... flags are the common mini-os flags,
>  # ARCH_... flags may be defined in arch/$(TARGET_ARCH_FAM/rules.mk


