From minios-devel-bounces@lists.xenproject.org Thu Aug 01 05:56:44 2024 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 01 Aug 2024 05:56:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.769286.1180153 (Exim 4.92) (envelope-from ) id 1sZOno-0003x4-Ih; Thu, 01 Aug 2024 05:56:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 769286.1180153; Thu, 01 Aug 2024 05:56:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sZOno-0003wx-Fm; Thu, 01 Aug 2024 05:56:40 +0000 Received: by outflank-mailman (input) for mailman id 769286; Thu, 01 Aug 2024 05:56:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sZOnn-0003wm-8F for minios-devel@lists.xenproject.org; Thu, 01 Aug 2024 05:56:39 +0000 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [2a00:1450:4864:20::12f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d124120a-4fca-11ef-bc02-fd08da9f4363; Thu, 01 Aug 2024 07:56:38 +0200 (CEST) Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-52f01afa11cso9773270e87.0 for ; Wed, 31 Jul 2024 22:56:38 -0700 (PDT) Received: from ?IPV6:2003:e5:8729:4000:29eb:6d9d:3214:39d2? (p200300e58729400029eb6d9d321439d2.dip0.t-ipconnect.de. [2003:e5:8729:4000:29eb:6d9d:3214:39d2]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5ac631b038asm9570234a12.14.2024.07.31.22.56.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Jul 2024 22:56:37 -0700 (PDT) X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: d124120a-4fca-11ef-bc02-fd08da9f4363 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1722491798; x=1723096598; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=2tEnuP/UL4tXxHZWH01vp9h0c1uyXvZsZkgf8LziZQs=; b=DXD0Y5pmfzD/Eo7Gm+cWSUXfbJkGf3hNU99DN/2Ax6gLgokjsL2hdkfyWVnlPXSls7 QRXS2J83bY/V0nE/Iz+fR6cOwIB0ZzQgmBX/cgMwpEJCX4VCE2SLAOQMEAaVJPFZSyiY HUHuH3e2ctkz+zOy/emj4U9ozcUZnNSt1A6s+sOj/oPInYSHoLw9995lAO4VMU5FB6FF XoWrOIw9trJtBnYcfhE9dvOatMN1kd6kb9AXvV1NeRdCl4htIWPm7/g1/Rl9Gt6/lx7q HFdeb7C2gyL68w+dTm59Jd4hpjNp0cafHoNTqmuUmlcQgCGd9d3ri58XzesvRCFyfNIE xZng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722491798; x=1723096598; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2tEnuP/UL4tXxHZWH01vp9h0c1uyXvZsZkgf8LziZQs=; b=F2Upx0J2ezu82I07iAtRA9S2L4MjLkZXwVxJ9IttFh700g+t++zjX0q7tySMWzmxd2 5D4p4NVS4Vg/eTjgoX/GNMmMsZGqJJyBuq9lOK87S2AWbOTA1Cmf49t/gB8cMywfuB45 vEqwjR76mIFvdx9ScH8QF+HOw3vbqoYLVcVjkqzcgTyHjwMbXCH11fPFVa2Y9dcV+jYb MGipYasFDVx4CeX1EYUlIjUaRkH54D+CbgubpGbVoTyGeIVo3gHujIPUChof3WSAvst9 bnOyYkTGN7zu/1hJHZ0zKVgAGQLdUHvomO6MQnGYwS4njhjxbfjzWmdOSA8p38IW7b83 /LiA== X-Forwarded-Encrypted: i=1; AJvYcCWSo3NkBr0IaYe/F4QsZtStKIGfUYyKfFkTw1O4m+aQ4Q0u1vk7YQ2u1JMm1IJ/YInfJqAcMUe97ho4EnIdUzkDeEM6iof2ZX0Ylrk7LfumZMw= X-Gm-Message-State: AOJu0YxZ2hB2bF5uBJ0O2rJifkU4jd3sb3Q14bFbZAfO5mRtFYXEy8PJ 72nIiZdQOpQANZmKL4R7pOhhZAQexP0IE6upZQC7adujqc3LVrEoRYKGmCY/Mpc= X-Google-Smtp-Source: AGHT+IHCsd4f1Vqscyy4MNsvfeakSMScTCWtggjocQ8t3UXWgk6i+/pi+BdfpwDEC/vxDl6Ak6Dpag== X-Received: by 2002:a05:6512:4851:b0:52e:9b68:d2d4 with SMTP id 2adb3069b0e04-530b6211441mr534845e87.56.1722491797556; Wed, 31 Jul 2024 22:56:37 -0700 (PDT) Message-ID: <8fef9511-c5d0-49a9-a800-6087f03b3199@suse.com> Date: Thu, 1 Aug 2024 07:56:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] mini-os: mm: switch need_pgt() to use walk_pt() To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20240731130026.8467-1-jgross@suse.com> <20240731130026.8467-3-jgross@suse.com> <20240731212752.zd5njpd7kgoc433d@begin> Content-Language: en-US From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= In-Reply-To: <20240731212752.zd5njpd7kgoc433d@begin> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 31.07.24 23:27, Samuel Thibault wrote: > Hello, > > Juergen Gross, le mer. 31 juil. 2024 15:00:25 +0200, a ecrit: >> -pgentry_t *need_pgt(unsigned long va) >> +static int need_pgt_func(unsigned long va, unsigned int lvl, bool is_leaf, >> + pgentry_t *pte, void *par) >> { > [...] >> + if ( lvl == L1_FRAME || (*pte & _PAGE_PRESENT) ) > > Did you mean (*pte & _PAGE_PSE)? No. I want to bail out if the PTE does not require a page table to be added to it. This is the case if the PTE is valid or if it is at the lowest page table level already. An invalid PTE with PSE set is still invalid, so the PSE bit has no real meaning. Juergen From minios-devel-bounces@lists.xenproject.org Thu Aug 01 05:58:14 2024 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 01 Aug 2024 05:58:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.769298.1180167 (Exim 4.92) (envelope-from ) id 1sZOpK-0004cP-0N; Thu, 01 Aug 2024 05:58:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 769298.1180167; Thu, 01 Aug 2024 05:58:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sZOpJ-0004cI-U8; Thu, 01 Aug 2024 05:58:13 +0000 Received: by outflank-mailman (input) for mailman id 769298; Thu, 01 Aug 2024 05:58:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sZOpI-0004Wu-Co for minios-devel@lists.xenproject.org; Thu, 01 Aug 2024 05:58:12 +0000 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [2a00:1450:4864:20::633]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 08eef3fd-4fcb-11ef-bc02-fd08da9f4363; Thu, 01 Aug 2024 07:58:12 +0200 (CEST) Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-a7a9e25008aso877005166b.0 for ; Wed, 31 Jul 2024 22:58:12 -0700 (PDT) Received: from ?IPV6:2003:e5:8729:4000:29eb:6d9d:3214:39d2? (p200300e58729400029eb6d9d321439d2.dip0.t-ipconnect.de. [2003:e5:8729:4000:29eb:6d9d:3214:39d2]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7acad41462sm832456166b.119.2024.07.31.22.58.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Jul 2024 22:58:10 -0700 (PDT) X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 08eef3fd-4fcb-11ef-bc02-fd08da9f4363 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1722491891; x=1723096691; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=PrzXj9hBjHLBbAPVtBe7OuM7CtNeowl5zK25rnUfrqo=; b=QBf+a7ZE59iX0mqhLMbFxkZmWMqQsQCDviDjsTtYBR6XVMQJw5UV9py722Cz8vilj2 rFdmrxVj7kOaz06g1ygRZZhIM61Ya3jn98r7GznPBMBet5q0TX6N2cnG/Dqw/iQ67Suw cisbtir4WFB5bWfCZk49kEkjemt1fAGRZAq3OTe8hJL14yTbmE74MN8p4rLIkVfSnOqh 8fkKKldrh4TyvVQjPACzg9yFMKhvyyf+5bNtsAH6TNu7/ohQzqXHO7cwHi4ZabVc00iI FwbRgyCtej3fHMbPBLBO2C4pcKDxc0wpdS9uztfwHZHeyUSOMWbyaB7v5IrGpvQ/IlLT hCRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722491891; x=1723096691; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PrzXj9hBjHLBbAPVtBe7OuM7CtNeowl5zK25rnUfrqo=; b=mwc2UKw9WbLkkSG0r/8a4i9sod4RRZ4dTqd56BZRV4s/SVnJEEPc8wGwroM/BPF8u3 oQKY8xEXETApfM1+cpfteobTHtds47iHpamQ74uPuLrXEKHqNH0Ha0RX2Zadb6nFzP1I tiY1+22tQoeocyzbitehYP3KNLC9QGj+I16mR8n7pcJRss8e6oYK+y9+3NOYZTO8G+7i 87ypDQMF4PaOP1NqqQ9ze56TT3PgOiQN2lxDZknPgsJV+IjWI0fv/169A5DNfAi1dbPZ TOjLl+XylJQRwYZo2U/hGpVUdysASiGMAkEOKe0d1aiLx+3+OMgp+efNm5CKUUQGwFi7 m7Pw== X-Forwarded-Encrypted: i=1; AJvYcCVJ6xi6t2B5lG0LhH5ZcvjrI1xuOwtAuscuazUGHqWeKzp2A1K6T5PHtX04si3YTnSIR8wz9m/+6ZOG/Ck=@lists.xenproject.org X-Gm-Message-State: AOJu0Yz7ZePxSWIULqVkGH8HNAT9Eyub2I6Yql64tBbXhURVzQ2mUkxn 3pp6Oqu1z2mZK580jZazC5I9+IrC4gE+QfukbC2mHRqjLKV2/JuAeMPc84Y1C4E7Hp6/Qn2XW+S Z X-Google-Smtp-Source: AGHT+IEdxR2PF49t/h+j3Ngv/qCjOIRoXd8vL5KzVadxEPd3A7uUAOZ4ec5zEiP0fanRdbUZ2q4XXw== X-Received: by 2002:a17:907:7ba8:b0:a77:e7cb:2982 with SMTP id a640c23a62f3a-a7daf9ddda6mr86982866b.26.1722491891199; Wed, 31 Jul 2024 22:58:11 -0700 (PDT) Message-ID: <3e678546-282b-461c-9a3e-363799f24e80@suse.com> Date: Thu, 1 Aug 2024 07:58:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] mini-os: mm: introduce generic page table walk function To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20240731130026.8467-1-jgross@suse.com> <20240731130026.8467-2-jgross@suse.com> <20240731213312.7qztj2qwv7g4if5e@begin> Content-Language: en-US From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= In-Reply-To: <20240731213312.7qztj2qwv7g4if5e@begin> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 31.07.24 23:33, Samuel Thibault wrote: > Juergen Gross, le mer. 31 juil. 2024 15:00:24 +0200, a ecrit: >> + ptindex[lvl] = (va >> ptdata[lvl].shift) & >> + (ptdata[lvl].entries - 1); > > It seems that this kind of va+lvl-to-index computation happens several > times? It's probably worth making it a macro. Agreed. Juergen From minios-devel-bounces@lists.xenproject.org Thu Aug 01 06:00:49 2024 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 01 Aug 2024 06:00:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.769308.1180181 (Exim 4.92) (envelope-from ) id 1sZOrp-0006ED-Ef; Thu, 01 Aug 2024 06:00:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 769308.1180181; Thu, 01 Aug 2024 06:00:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sZOrp-0006E6-CC; Thu, 01 Aug 2024 06:00:49 +0000 Received: by outflank-mailman (input) for mailman id 769308; Thu, 01 Aug 2024 06:00:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sZOrn-0006Dt-LW for minios-devel@lists.xenproject.org; Thu, 01 Aug 2024 06:00:47 +0000 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [2a00:1450:4864:20::532]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 64a23575-4fcb-11ef-8776-851b0ebba9a2; Thu, 01 Aug 2024 08:00:45 +0200 (CEST) Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-5afa207b8bfso6805229a12.0 for ; Wed, 31 Jul 2024 23:00:45 -0700 (PDT) Received: from ?IPV6:2003:e5:8729:4000:29eb:6d9d:3214:39d2? (p200300e58729400029eb6d9d321439d2.dip0.t-ipconnect.de. [2003:e5:8729:4000:29eb:6d9d:3214:39d2]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5ac60918cb4sm9636299a12.0.2024.07.31.23.00.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Jul 2024 23:00:44 -0700 (PDT) X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 64a23575-4fcb-11ef-8776-851b0ebba9a2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1722492045; x=1723096845; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=vvTX8VhEq4feevTSvTB8g//YBud7BwtG5v2vu7g40Io=; b=GtIAbDJQKdhh0sahz9ub5ad5KX+SIfBW9G4Kpy5DMlgVyYzfMPqNZqnOpwUVdlqzQ/ NeE6namTKLnwo6CH2Q/5XjHoc5tbDo88YrrOU8zGqVWjR5L5GazCuYeIvSMRUdiksVLV cXgVPktNbNXZAHBaTbl3CmuigYjthfnUfi4rcLw9RfsZI51MFiVuUpBcj9Xuifo4Kyn9 p3SeR9q5hQgMv04bK/ql+ORnCf3YfVYI4cakXQFZklYiUTOs23PuZj3TEoLotaIEj/zg YsWBB1VgoMpanRVB9xnOOT+vM9jp4jOqYVYsKuHwnsgZ19NvvX/7LZkk0NnP39fZvP+f iiHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722492045; x=1723096845; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vvTX8VhEq4feevTSvTB8g//YBud7BwtG5v2vu7g40Io=; b=MDfqQQIx1uVC2ZzEiIpjDf1Ple+lUozQTn+MV9WeBRCG5WlpTHJCeisb1RDm324gBl YW0vGlFfa8ADFTLbPvsMaocEbI1Yd10UhzH5/rUEyFArr3cO4wFmF0Z6ghD9gHQ54TR/ WHQyxQRqNi/81ZFvJxlxxYAIC1NQCgVXo64iSYvGYFRpF0vvxvoY1SGVrCcrntpHtDq7 GxDjoAm8H61hF6h0Vgxk33DOVoMwFihtOJ32tPnITW1nvSSERzPVe7T5R6SbJHwPsY9p go5vMvBsFZG0zWYuBvvzHYWSALNjrpMSYnWS8kUCjHuDT8t+YOTuuMY5SwQkHxHEfDYV 0foQ== X-Forwarded-Encrypted: i=1; AJvYcCVmxiQdG1b4SdXkiPyWfrtLbweBPGUjDJnvo8WRInMIM+CFbO2gjBDYafajjbIpKfU+Q4wkAbxNGyXFZ8Ui3HK5n+IiB5dlDYUDaxOi3LRdOXU= X-Gm-Message-State: AOJu0YyOCRHgADbebEhnCywbQ1FMaPisObKB7OFENg2X9CncwMxGj83g ONw8sa3/bGKHIcIiV8nFYgfeDcqY7y9rH8585CeVKLon7CPfNb2hgYGmed+3pOY= X-Google-Smtp-Source: AGHT+IFBvByQIrctF48vEyZvzdM+5pDXUsKXcjTd/gZ9ux65PZ4OHAQjLcEoqN6TJswW0q+lJe47hg== X-Received: by 2002:a05:6402:5147:b0:59e:6b89:fdad with SMTP id 4fb4d7f45d1cf-5b6fe72135amr726306a12.3.1722492045054; Wed, 31 Jul 2024 23:00:45 -0700 (PDT) Message-ID: <3f353d9d-2306-4a62-9a6f-8aa787bf33aa@suse.com> Date: Thu, 1 Aug 2024 08:00:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] mini-os: mm: convert set_readonly() to use walk_pt() To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20240731130026.8467-1-jgross@suse.com> <20240731130026.8467-4-jgross@suse.com> <20240731213753.hduimhyf56bf7yr4@begin> Content-Language: en-US From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= In-Reply-To: <20240731213753.hduimhyf56bf7yr4@begin> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 31.07.24 23:37, Samuel Thibault wrote: > Juergen Gross, le mer. 31 juil. 2024 15:00:26 +0200, a ecrit: >> +static int set_readonly_func(unsigned long va, unsigned int lvl, bool is_leaf, >> + pgentry_t *pte, void *par) >> +{ >> + struct set_readonly_par *ro = par; >> >> + mmu_updates[ro->count].ptr = virt_to_mach(pte); >> + mmu_updates[ro->count].val = *pte & ~_PAGE_RW; >> + ro->count++; >> + >> + if ( (ro->count == L1_PAGETABLE_ENTRIES || >> + va + 2 * PAGE_SIZE > ro->etext) && >> + HYPERVISOR_mmu_update(mmu_updates, ro->count, NULL, DOMID_SELF) < 0 ) >> + { >> + printk("ERROR: set_readonly(): PTE could not be updated\n"); >> + do_exit(); >> + } > > Don't we also want to set ro->count to 0? Oh, indeed. Thanks for catching this. > And assert that it is 0 after calling walk_pt in set_readonly, to make > sure the va + 2 * PAGE_SIZE > ro->etext test did work properly > (personally I would have rather made set_readonly call a last > HYPERVISOR_mmu_update in case ro->count is not 0, which looks more > robust that a quite magic-looking va + 2 * PAGE_SIZE > ro->etext test) I think you are right. I'll do that. Juergen From minios-devel-bounces@lists.xenproject.org Thu Aug 01 07:39:31 2024 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 01 Aug 2024 07:39:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.769397.1180272 (Exim 4.92) (envelope-from ) id 1sZQPJ-0000Ip-B1; Thu, 01 Aug 2024 07:39:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 769397.1180272; Thu, 01 Aug 2024 07:39:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sZQPJ-0000Gy-5E; Thu, 01 Aug 2024 07:39:29 +0000 Received: by outflank-mailman (input) for mailman id 769397; Thu, 01 Aug 2024 07:39:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sZQPH-0000F7-UM for minios-devel@lists.xenproject.org; Thu, 01 Aug 2024 07:39:27 +0000 Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2c3f7a7c-4fd9-11ef-bc02-fd08da9f4363; Thu, 01 Aug 2024 09:39:26 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id DE61BA0374; Thu, 1 Aug 2024 09:39:23 +0200 (CEST) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id y4vuD59QVvSF; Thu, 1 Aug 2024 09:39:23 +0200 (CEST) Received: from begin (aamiens-653-1-111-57.w83-192.abo.wanadoo.fr [83.192.234.57]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id B59B5A0371; Thu, 1 Aug 2024 09:39:23 +0200 (CEST) Received: from samy by begin with local (Exim 4.98) (envelope-from ) id 1sZQPD-00000000XVx-1JbL; Thu, 01 Aug 2024 09:39:23 +0200 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 2c3f7a7c-4fd9-11ef-bc02-fd08da9f4363 Date: Thu, 1 Aug 2024 09:39:23 +0200 From: Samuel Thibault To: =?utf-8?B?SsO8cmdlbiBHcm/Dnw==?= Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH 2/3] mini-os: mm: switch need_pgt() to use walk_pt() Message-ID: <20240801073923.32s6i4enoq6qafa5@begin> Mail-Followup-To: Samuel Thibault , =?utf-8?B?SsO8cmdlbiBHcm/Dnw==?= , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20240731130026.8467-1-jgross@suse.com> <20240731130026.8467-3-jgross@suse.com> <20240731212752.zd5njpd7kgoc433d@begin> <8fef9511-c5d0-49a9-a800-6087f03b3199@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8fef9511-c5d0-49a9-a800-6087f03b3199@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Jürgen Groß, le jeu. 01 août 2024 07:56:36 +0200, a ecrit: > On 31.07.24 23:27, Samuel Thibault wrote: > > Hello, > > > > Juergen Gross, le mer. 31 juil. 2024 15:00:25 +0200, a ecrit: > > > -pgentry_t *need_pgt(unsigned long va) > > > +static int need_pgt_func(unsigned long va, unsigned int lvl, bool is_leaf, > > > + pgentry_t *pte, void *par) > > > { > > [...] > > > + if ( lvl == L1_FRAME || (*pte & _PAGE_PRESENT) ) > > > > Did you mean (*pte & _PAGE_PSE)? > > No. I don't understand: it doesn't map what I know of need_pgt and what the existing code is doing. AIKI, the point of need_pgt is to make sure there is a L1 page table entry for a VA, and return it, so the caller can put in it at pte for a mfn or such. In the case a PSE is met, we don't go further, and it's up to the caller to decide what it wants to do (most often it's actually unexpected and asserted out). In both cases, the PRESENT bit of the pte whose address is returned does not matter, most often it's the caller which will set it. The existing code for need_pgt thus always adds page table entries down to level1 (except if _PAGE_PSE is met, i.e. a large page was already set up): the termination was: [... walk down to level 2] - if ( tab[offset] & _PAGE_PSE ) - return &tab[offset]; [... walk down to level 1] - return &tab[offset]; i.e. we always return either a PSE L2 entry, or an L1 entry, and never above (while keeping sure that the entries above are present). > I want to bail out if the PTE does not require a page table to be > added to it. This is the case if the PTE is valid There being an entry at e.g. level 3 (without PSE) does not mean that we have an entry at level 1 for the VA, so we have to continue adding levels for the VA in the sparse page table tree. > An invalid PTE with PSE set is still invalid, so the PSE bit has no > real meaning. Mmm, I don't think we ever create entries with PSE but not PRESENT (i.e. we don't "plan" to have PSE entries), but even if we did, if we "plan" to have PSE entries, we should return that entry, and it's up to the caller to fill it (and make it PRESENT) Samuel From minios-devel-bounces@lists.xenproject.org Thu Aug 01 08:13:13 2024 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 01 Aug 2024 08:13:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.769445.1180345 (Exim 4.92) (envelope-from ) id 1sZQvw-0007iN-Ib; Thu, 01 Aug 2024 08:13:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 769445.1180345; Thu, 01 Aug 2024 08:13:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sZQvw-0007iG-GC; Thu, 01 Aug 2024 08:13:12 +0000 Received: by outflank-mailman (input) for mailman id 769445; Thu, 01 Aug 2024 08:13:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sZQvv-0007i5-8j for minios-devel@lists.xenproject.org; Thu, 01 Aug 2024 08:13:11 +0000 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [2a00:1450:4864:20::52b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e347bd23-4fdd-11ef-bc02-fd08da9f4363; Thu, 01 Aug 2024 10:13:09 +0200 (CEST) Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-5af326eddb2so3199488a12.1 for ; Thu, 01 Aug 2024 01:13:09 -0700 (PDT) Received: from ?IPV6:2003:e5:8729:4000:29eb:6d9d:3214:39d2? (p200300e58729400029eb6d9d321439d2.dip0.t-ipconnect.de. [2003:e5:8729:4000:29eb:6d9d:3214:39d2]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5ac63590d81sm9883008a12.23.2024.08.01.01.13.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Aug 2024 01:13:08 -0700 (PDT) X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: e347bd23-4fdd-11ef-bc02-fd08da9f4363 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1722499989; x=1723104789; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=M/mJS9h82p54uLSSBVmHoxv9n2rzlaKYIk+BGzaOG8U=; b=O5OiwSf6pS1HybruCvDf76slJ4FAKm+9iUv0r+wxPP9eOEL6P7yhy8ESsMfTIhcugD 7mcqPTSXu6A1/L9x0eq2GWpzSBXbe3MfQyO+qSBxNFMo8QfSHvLC2QskMBHrsTkzgtSB 8gcV9llIun1v1Ry0d+BOi+q0CQUmf4JHVTgaOC70CeTuoGpi8KqMAgeqp9bPHyBfFpPV Vh6xdonID4cRcOYqfLL5FR/e5oIaBoSo2Fi2r8JH+1aeysIkhquBX1wci0+XBQnEQSQc zXaXu6+ztYQAdml3cgDTktSdBQMy6Tvj7P9EkjhnleltyVnKg9396/NAJv+M/YnP+M6W R3eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722499989; x=1723104789; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=M/mJS9h82p54uLSSBVmHoxv9n2rzlaKYIk+BGzaOG8U=; b=VENGo1qlLGGf5eeoOR6hahxk5hxbucC8NblVM3AOOR+ctJcRlCi4kkpYAOYT+CZj69 QhhxPua/r7UOFcNPQ/9RSXXE+dsNosvIYj9m5Y4ngUdgeglK2lXKzSd71Q/RzJ6bDJpo UeptqlF8YOGciLOcisYLAGun4L14XLR+iTZEBH2eT5OCllKLfWP13cGeWUGm1U0eC1YD kCk4Z+byxLF0bBQ11q1hMzqavGcUwvQoT2Fq73Sem1BydCYQXhra/YnjhTK/oB/M1KJr tjPbabUSEiJYv5KMoTDO4I+WjGjtK2XGI0zyjhFdICt8UX9MYtDfUqRikwVZeZXcjOAx azyg== X-Forwarded-Encrypted: i=1; AJvYcCXAObVhVunVPvKsj7DrdU02kcm5OpRwgfyc447oa5PYsMIG2qqy2zWiX2UWpjX+DjLnC5ybUGSKvJhgg0mdQhGDqgzBk4fFUPnHGL/mXYRg7o4= X-Gm-Message-State: AOJu0Yz8HhEODewpmnnnkyAf+NksqCYPt9mxnrWNQuewjFicQoCy3FEZ Gi17h4JqAyesEL99W/nSEboljWwZEq46dsSZ6zy6QODfrpppGSwSE9AyMi/FIZ0= X-Google-Smtp-Source: AGHT+IHMYcpXa4CVg65aTj1rbaNI790f2Sz+h8yluHqRP/gwsIrXc/ADGOrHP0eFajzRrNOSNpLSCA== X-Received: by 2002:a05:6402:74b:b0:57d:3e48:165d with SMTP id 4fb4d7f45d1cf-5b77bd9cbf7mr472457a12.4.1722499988447; Thu, 01 Aug 2024 01:13:08 -0700 (PDT) Message-ID: <7fa3bca4-1ef4-4c95-bf92-de87c7c8fc96@suse.com> Date: Thu, 1 Aug 2024 10:13:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] mini-os: mm: switch need_pgt() to use walk_pt() To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20240731130026.8467-1-jgross@suse.com> <20240731130026.8467-3-jgross@suse.com> <20240731212752.zd5njpd7kgoc433d@begin> <8fef9511-c5d0-49a9-a800-6087f03b3199@suse.com> <20240801073923.32s6i4enoq6qafa5@begin> Content-Language: en-US From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= In-Reply-To: <20240801073923.32s6i4enoq6qafa5@begin> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 01.08.24 09:39, Samuel Thibault wrote: > Jürgen Groß, le jeu. 01 août 2024 07:56:36 +0200, a ecrit: >> On 31.07.24 23:27, Samuel Thibault wrote: >>> Hello, >>> >>> Juergen Gross, le mer. 31 juil. 2024 15:00:25 +0200, a ecrit: >>>> -pgentry_t *need_pgt(unsigned long va) >>>> +static int need_pgt_func(unsigned long va, unsigned int lvl, bool is_leaf, >>>> + pgentry_t *pte, void *par) >>>> { >>> [...] >>>> + if ( lvl == L1_FRAME || (*pte & _PAGE_PRESENT) ) >>> >>> Did you mean (*pte & _PAGE_PSE)? >> >> No. > > I don't understand: it doesn't map what I know of need_pgt and what the > existing code is doing. > > AIKI, the point of need_pgt is to make sure there is a L1 page table > entry for a VA, and return it, so the caller can put in it at pte for a > mfn or such. In the case a PSE is met, we don't go further, and it's up > to the caller to decide what it wants to do (most often it's actually > unexpected and asserted out). In both cases, the PRESENT bit of the > pte whose address is returned does not matter, most often it's the > caller which will set it. > > The existing code for need_pgt thus always adds page table entries down > to level1 (except if _PAGE_PSE is met, i.e. a large page was already set > up): the termination was: > > [... walk down to level 2] You have omitted: ASSERT(tab[offset] & _PAGE_PRESENT); > - if ( tab[offset] & _PAGE_PSE ) > - return &tab[offset]; > [... walk down to level 1] > - return &tab[offset]; Juergen From minios-devel-bounces@lists.xenproject.org Thu Aug 01 09:15:45 2024 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 01 Aug 2024 09:15:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.769475.1180369 (Exim 4.92) (envelope-from ) id 1sZRuP-0000B4-AR; Thu, 01 Aug 2024 09:15:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 769475.1180369; Thu, 01 Aug 2024 09:15:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sZRuP-0000Ax-7x; Thu, 01 Aug 2024 09:15:41 +0000 Received: by outflank-mailman (input) for mailman id 769475; Thu, 01 Aug 2024 09:15:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sZRuO-0000Al-8j for minios-devel@lists.xenproject.org; Thu, 01 Aug 2024 09:15:40 +0000 Received: from sonata.ens-lyon.org (sonata.ens-lyon.org [140.77.166.138]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9d0b7acb-4fe6-11ef-8776-851b0ebba9a2; Thu, 01 Aug 2024 11:15:37 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 83326A0374; Thu, 1 Aug 2024 11:15:36 +0200 (CEST) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pi5kvC2AKg08; Thu, 1 Aug 2024 11:15:36 +0200 (CEST) Received: from begin (nat-inria-interne-52-gw-01-bso.bordeaux.inria.fr [194.199.1.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 4AB52A0371; Thu, 1 Aug 2024 11:15:36 +0200 (CEST) Received: from samy by begin with local (Exim 4.98) (envelope-from ) id 1sZRuJ-00000000bzH-46Ly; Thu, 01 Aug 2024 11:15:35 +0200 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 9d0b7acb-4fe6-11ef-8776-851b0ebba9a2 Date: Thu, 1 Aug 2024 11:15:35 +0200 From: Samuel Thibault To: =?utf-8?B?SsO8cmdlbiBHcm/Dnw==?= Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH 2/3] mini-os: mm: switch need_pgt() to use walk_pt() Message-ID: <20240801091535.rpspqy2k73tjy6ms@begin> Mail-Followup-To: Samuel Thibault , =?utf-8?B?SsO8cmdlbiBHcm/Dnw==?= , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20240731130026.8467-1-jgross@suse.com> <20240731130026.8467-3-jgross@suse.com> <20240731212752.zd5njpd7kgoc433d@begin> <8fef9511-c5d0-49a9-a800-6087f03b3199@suse.com> <20240801073923.32s6i4enoq6qafa5@begin> <7fa3bca4-1ef4-4c95-bf92-de87c7c8fc96@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7fa3bca4-1ef4-4c95-bf92-de87c7c8fc96@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Jürgen Groß, le jeu. 01 août 2024 10:13:07 +0200, a ecrit: > On 01.08.24 09:39, Samuel Thibault wrote: > > Jürgen Groß, le jeu. 01 août 2024 07:56:36 +0200, a ecrit: > > > On 31.07.24 23:27, Samuel Thibault wrote: > > > > Hello, > > > > > > > > Juergen Gross, le mer. 31 juil. 2024 15:00:25 +0200, a ecrit: > > > > > -pgentry_t *need_pgt(unsigned long va) > > > > > +static int need_pgt_func(unsigned long va, unsigned int lvl, bool is_leaf, > > > > > + pgentry_t *pte, void *par) > > > > > { > > > > [...] > > > > > + if ( lvl == L1_FRAME || (*pte & _PAGE_PRESENT) ) > > > > > > > > Did you mean (*pte & _PAGE_PSE)? > > > > > > No. > > > > I don't understand: it doesn't map what I know of need_pgt and what the > > existing code is doing. > > > > AIKI, the point of need_pgt is to make sure there is a L1 page table > > entry for a VA, and return it, so the caller can put in it at pte for a > > mfn or such. In the case a PSE is met, we don't go further, and it's up > > to the caller to decide what it wants to do (most often it's actually > > unexpected and asserted out). In both cases, the PRESENT bit of the > > pte whose address is returned does not matter, most often it's the > > caller which will set it. > > > > The existing code for need_pgt thus always adds page table entries down > > to level1 (except if _PAGE_PSE is met, i.e. a large page was already set > > up): the termination was: > > > > [... walk down to level 2] > > You have omitted: > > ASSERT(tab[offset] & _PAGE_PRESENT); Right, that confirms that we never set PSE without PRESENT. We probably want to keep that assertion in the PSE case. But we still want to continue walking down to level1 (or pse) even when L4/L3/L2 have PRESENT. > > - if ( tab[offset] & _PAGE_PSE ) > > - return &tab[offset]; > > [... walk down to level 1] > > - return &tab[offset]; Samuel From minios-devel-bounces@lists.xenproject.org Thu Aug 01 09:25:37 2024 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 01 Aug 2024 09:25:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.769489.1180389 (Exim 4.92) (envelope-from ) id 1sZS40-000283-Dd; Thu, 01 Aug 2024 09:25:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 769489.1180389; Thu, 01 Aug 2024 09:25:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sZS40-00026W-96; Thu, 01 Aug 2024 09:25:36 +0000 Received: by outflank-mailman (input) for mailman id 769489; Thu, 01 Aug 2024 09:25:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sZS3z-00025g-Ex for minios-devel@lists.xenproject.org; Thu, 01 Aug 2024 09:25:35 +0000 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [2a00:1450:4864:20::530]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 00323e7f-4fe8-11ef-8776-851b0ebba9a2; Thu, 01 Aug 2024 11:25:32 +0200 (CEST) Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-5b214865fecso5560061a12.1 for ; Thu, 01 Aug 2024 02:25:32 -0700 (PDT) Received: from ?IPV6:2003:e5:8729:4000:29eb:6d9d:3214:39d2? (p200300e58729400029eb6d9d321439d2.dip0.t-ipconnect.de. [2003:e5:8729:4000:29eb:6d9d:3214:39d2]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5ac631b038asm9838902a12.14.2024.08.01.02.25.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Aug 2024 02:25:31 -0700 (PDT) X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 00323e7f-4fe8-11ef-8776-851b0ebba9a2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1722504332; x=1723109132; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=EcrReH1FzMPVP1OEyOxTBff3mux3+NXaWR11lyworsw=; b=SgKFhJZDEyH97t0FlMOCxoDPJmYZOlDiryYDpSoPOLeHxN8r/gjiCvinwMgthgD4MA Rp2x4Yv3O/MqPGoScmTDP5//A/QNwIsLVG21IQpnkPtAUIAOogUSwD3iXnHYvlvsRKet uMAn5kMQDLHYTLa65zbjUEybpCLOseQOLUrmG4hsVi/pPE1tPzC/FjbRnn8hGrBAXhMo 6fTdk5D13DupBEebr+Bu7u5GoqBzqA/t45frBB2NjRSLJoDT2jz05gfmwX0xtzhrh4Tn gj+jHy6CvW5y/2xPPTemJSt5g7Jggt3eY28fRGkQdtFZXi7/8kz2ndOPsRVFhVX+43w1 T8PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722504332; x=1723109132; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EcrReH1FzMPVP1OEyOxTBff3mux3+NXaWR11lyworsw=; b=Va7CFZ4Y2uX7YJY5W/1pzruMaCJwd3Ton4m0c4cqLxPuaOvnc7fYetsVmuNGBMIX9l RucxdJW1pawc7cLviP4pXw6P65st9dFBQ7B92xeV4GhpE+Xgpbs2OPd8lQ1YWKDKhWm9 uta0cVfHQcBB9dET8N0FY7rD9vLIjy7Sa8kZNn3uktWLVBgClwfjAtqbrBXtdUXBP8Vg EH17EKwxKWOsIK4dKOSyJailox8y36LFcta2kBU20o2cOVHbdNNXZ5rNi91vPUbQu83G lPKi8Hqyg44+a+tgmFSb5Gy/juXzMLdpjlkVKPyDjZdHAwsGdmEggvIMpBYhv/M85oBU kHwA== X-Forwarded-Encrypted: i=1; AJvYcCXUdCAWBjbE0T9VzV647TYU1bBsxeIjTLPkLYsXzy1U0ZgM5EE+bVUNICPawFvXbMHFs4XKb10VpY6hsstvzXzmlCVPLVQJNjVYbcnXB0vl/bY= X-Gm-Message-State: AOJu0Yx0iVFq7Uic4/0mXe8YPe6Ur36K7Pg+NNIfmjWNhziAqfKA7Ft5 bEETt02Ek+Zbo4zI9ZBCfm3pWZ3S0SL9p96GkwUISWRaonO7cAZOquS9RXyX86I= X-Google-Smtp-Source: AGHT+IG+YYfS2UmGdG+qZR+I4YRxLkbvj1Mkbz0EqVdD9uO5cbpfLBXerCcmbxy1mbvUJS4WuONJ4g== X-Received: by 2002:aa7:d44f:0:b0:5a1:61a7:56ce with SMTP id 4fb4d7f45d1cf-5b7008ac013mr949766a12.35.1722504332045; Thu, 01 Aug 2024 02:25:32 -0700 (PDT) Message-ID: <894c9552-ef2b-4255-b429-ad3df4f5c0cc@suse.com> Date: Thu, 1 Aug 2024 11:25:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] mini-os: mm: switch need_pgt() to use walk_pt() To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20240731130026.8467-1-jgross@suse.com> <20240731130026.8467-3-jgross@suse.com> <20240731212752.zd5njpd7kgoc433d@begin> <8fef9511-c5d0-49a9-a800-6087f03b3199@suse.com> <20240801073923.32s6i4enoq6qafa5@begin> <7fa3bca4-1ef4-4c95-bf92-de87c7c8fc96@suse.com> <20240801091535.rpspqy2k73tjy6ms@begin> Content-Language: en-US From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= In-Reply-To: <20240801091535.rpspqy2k73tjy6ms@begin> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 01.08.24 11:15, Samuel Thibault wrote: > Jürgen Groß, le jeu. 01 août 2024 10:13:07 +0200, a ecrit: >> On 01.08.24 09:39, Samuel Thibault wrote: >>> Jürgen Groß, le jeu. 01 août 2024 07:56:36 +0200, a ecrit: >>>> On 31.07.24 23:27, Samuel Thibault wrote: >>>>> Hello, >>>>> >>>>> Juergen Gross, le mer. 31 juil. 2024 15:00:25 +0200, a ecrit: >>>>>> -pgentry_t *need_pgt(unsigned long va) >>>>>> +static int need_pgt_func(unsigned long va, unsigned int lvl, bool is_leaf, >>>>>> + pgentry_t *pte, void *par) >>>>>> { >>>>> [...] >>>>>> + if ( lvl == L1_FRAME || (*pte & _PAGE_PRESENT) ) >>>>> >>>>> Did you mean (*pte & _PAGE_PSE)? >>>> >>>> No. >>> >>> I don't understand: it doesn't map what I know of need_pgt and what the >>> existing code is doing. >>> >>> AIKI, the point of need_pgt is to make sure there is a L1 page table >>> entry for a VA, and return it, so the caller can put in it at pte for a >>> mfn or such. In the case a PSE is met, we don't go further, and it's up >>> to the caller to decide what it wants to do (most often it's actually >>> unexpected and asserted out). In both cases, the PRESENT bit of the >>> pte whose address is returned does not matter, most often it's the >>> caller which will set it. >>> >>> The existing code for need_pgt thus always adds page table entries down >>> to level1 (except if _PAGE_PSE is met, i.e. a large page was already set >>> up): the termination was: >>> >>> [... walk down to level 2] >> >> You have omitted: >> >> ASSERT(tab[offset] & _PAGE_PRESENT); > > Right, that confirms that we never set PSE without PRESENT. We probably > want to keep that assertion in the PSE case. Hmm, I'm not sure. The hardware allows to have any bit set in the PTE when PRESENT isn't set. It will never look at any other bit in this case. Why should the software require something different here? > But we still want to continue walking down to level1 (or pse) even when > L4/L3/L2 have PRESENT. We do that. In this case the is_leaf flag won't be set and need_pgt_func() will return early with the return value 0, meaning that the walk will be continued. Juergen From minios-devel-bounces@lists.xenproject.org Thu Aug 01 10:12:35 2024 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 01 Aug 2024 10:12:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.769520.1180417 (Exim 4.92) (envelope-from ) id 1sZSnR-0002Ou-4W; Thu, 01 Aug 2024 10:12:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 769520.1180417; Thu, 01 Aug 2024 10:12:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sZSnR-0002On-1U; Thu, 01 Aug 2024 10:12:33 +0000 Received: by outflank-mailman (input) for mailman id 769520; Thu, 01 Aug 2024 10:12:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sZSnP-0002Oc-Rp for minios-devel@lists.xenproject.org; Thu, 01 Aug 2024 10:12:31 +0000 Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8f9d9f25-4fee-11ef-bc02-fd08da9f4363; Thu, 01 Aug 2024 12:12:30 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 003CBA037E; Thu, 1 Aug 2024 12:12:30 +0200 (CEST) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WJolNPPUTo0l; Thu, 1 Aug 2024 12:12:29 +0200 (CEST) Received: from begin (nat-inria-interne-52-gw-01-bso.bordeaux.inria.fr [194.199.1.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id C05F4A0379; Thu, 1 Aug 2024 12:12:29 +0200 (CEST) Received: from samy by begin with local (Exim 4.98) (envelope-from ) id 1sZSnN-00000001izo-0gSX; Thu, 01 Aug 2024 12:12:29 +0200 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 8f9d9f25-4fee-11ef-bc02-fd08da9f4363 Date: Thu, 1 Aug 2024 12:12:29 +0200 From: Samuel Thibault To: =?utf-8?B?SsO8cmdlbiBHcm/Dnw==?= Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH 2/3] mini-os: mm: switch need_pgt() to use walk_pt() Message-ID: <20240801101229.5htyrethv55xmh3x@begin> Mail-Followup-To: Samuel Thibault , =?utf-8?B?SsO8cmdlbiBHcm/Dnw==?= , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20240731130026.8467-1-jgross@suse.com> <20240731130026.8467-3-jgross@suse.com> <20240731212752.zd5njpd7kgoc433d@begin> <8fef9511-c5d0-49a9-a800-6087f03b3199@suse.com> <20240801073923.32s6i4enoq6qafa5@begin> <7fa3bca4-1ef4-4c95-bf92-de87c7c8fc96@suse.com> <20240801091535.rpspqy2k73tjy6ms@begin> <894c9552-ef2b-4255-b429-ad3df4f5c0cc@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <894c9552-ef2b-4255-b429-ad3df4f5c0cc@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Jürgen Groß, le jeu. 01 août 2024 11:25:31 +0200, a ecrit: > On 01.08.24 11:15, Samuel Thibault wrote: > > Jürgen Groß, le jeu. 01 août 2024 10:13:07 +0200, a ecrit: > > > On 01.08.24 09:39, Samuel Thibault wrote: > > > > Jürgen Groß, le jeu. 01 août 2024 07:56:36 +0200, a ecrit: > > > > > On 31.07.24 23:27, Samuel Thibault wrote: > > > > > > Hello, > > > > > > > > > > > > Juergen Gross, le mer. 31 juil. 2024 15:00:25 +0200, a ecrit: > > > > > > > -pgentry_t *need_pgt(unsigned long va) > > > > > > > +static int need_pgt_func(unsigned long va, unsigned int lvl, bool is_leaf, > > > > > > > + pgentry_t *pte, void *par) > > > > > > > { > > > > > > [...] > > > > > > > + if ( lvl == L1_FRAME || (*pte & _PAGE_PRESENT) ) > > > > > > > > > > > > Did you mean (*pte & _PAGE_PSE)? > > > > > > > > > > No. > > > > > > > > I don't understand: it doesn't map what I know of need_pgt and what the > > > > existing code is doing. > > > > > > > > AIKI, the point of need_pgt is to make sure there is a L1 page table > > > > entry for a VA, and return it, so the caller can put in it at pte for a > > > > mfn or such. In the case a PSE is met, we don't go further, and it's up > > > > to the caller to decide what it wants to do (most often it's actually > > > > unexpected and asserted out). In both cases, the PRESENT bit of the > > > > pte whose address is returned does not matter, most often it's the > > > > caller which will set it. > > > > > > > > The existing code for need_pgt thus always adds page table entries down > > > > to level1 (except if _PAGE_PSE is met, i.e. a large page was already set > > > > up): the termination was: > > > > > > > > [... walk down to level 2] > > > > > > You have omitted: > > > > > > ASSERT(tab[offset] & _PAGE_PRESENT); > > > > Right, that confirms that we never set PSE without PRESENT. We probably > > want to keep that assertion in the PSE case. > > Hmm, I'm not sure. > > The hardware allows to have any bit set in the PTE when PRESENT isn't set. > It will never look at any other bit in this case. Why should the software > require something different here? To document&check what we expect to be producing. > > But we still want to continue walking down to level1 (or pse) even when > > L4/L3/L2 have PRESENT. > > We do that. In this case the is_leaf flag won't be set and need_pgt_func() > will return early with the return value 0, meaning that the walk will be > continued. Ah, I missed that indeed, I had not integrated that is_leaf is 1 also in the case of missing level>1 page. It'd probably be useful to emphasize in patch 1: + * is_leaf: true if PTE doesn't address another page table it should explicitly say (L1 PTE, or PSE, or not present yet) The *pte & _PAGE_PRESENT test alone still looks surprising to the reader, though: we don't return because the page is present, but because we reached the last possible level that we could fill, which is either L1, or an existing PSE. It is true that when is_leaf is 1, if it's not L1 but present, it's necessarily a PSE, but it's clearer to the reader to write what we meant: L1 or PSE, so something like: if ( lvl == L1_FRAME || (*pte & _PAGE_PRESENT) ) { assert ( lvl == L1_FRAME || (*pte & _PAGE_PSE) ); // we are at last possible level [...] } Samuel From minios-devel-bounces@lists.xenproject.org Tue Aug 13 13:42:09 2024 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 13 Aug 2024 13:42:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.776265.1186392 (Exim 4.92) (envelope-from ) id 1sdrmn-0004yi-AC; Tue, 13 Aug 2024 13:42:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 776265.1186392; Tue, 13 Aug 2024 13:42:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sdrmn-0004yb-7I; Tue, 13 Aug 2024 13:42:05 +0000 Received: by outflank-mailman (input) for mailman id 776265; Tue, 13 Aug 2024 13:42:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sdrmm-0004yQ-1A for minios-devel@lists.xenproject.org; Tue, 13 Aug 2024 13:42:04 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2a07:de40:b251:101:10:150:64:2]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d1972db3-5979-11ef-a505-bb4a2ccca743; Tue, 13 Aug 2024 15:42:03 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E2046203BA; Tue, 13 Aug 2024 13:42:00 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A01B013ABD; Tue, 13 Aug 2024 13:42:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 4sCUJahiu2bCGQAAD6G6ig (envelope-from ); Tue, 13 Aug 2024 13:42:00 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: d1972db3-5979-11ef-a505-bb4a2ccca743 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1723556521; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=hF+OGWJrQJvuR+qcRSbi6yy6oljPmXgdG1p+2bNu0eg=; b=GlUkpc+SDQ8DoviphByThx8I8B2T1hO1mCT76kq7+K7bLQpoyJn4pmoEsB17n7srnT+YSB a+/0QieDUpXNfjPX4eUlZJ8Ff25buIi58r4deV52FtxV+joqmUsngnwe2s4IaOxD0S/qXe ZiOzUaC/UCStSWEnCRpNMD47y809yMA= Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.com header.s=susede1 header.b=Ub51uOEJ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1723556520; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=hF+OGWJrQJvuR+qcRSbi6yy6oljPmXgdG1p+2bNu0eg=; b=Ub51uOEJtCDkXW8U4f1enhb5aNfKJFBW7MzbiECWmBv5h+6N3mEvSKkBLkuaD05I5E1r9s +hZ3O78PTPt9/19atlxE/oYPFUGj5qt8AddaTIjCYqTfLmdfIMc6ZyILANYR2lV45NEQxT uJNZARn4E22UWDIAKtimA0sGhbiVyrA= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, Juergen Gross Subject: [PATCH v2 0/3] mini-os: mm: use a generic page table walker Date: Tue, 13 Aug 2024 15:41:55 +0200 Message-ID: <20240813134158.580-1-jgross@suse.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -3.01 X-Rspamd-Queue-Id: E2046203BA X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.com:s=susede1]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:dkim,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; DKIM_TRACE(0.00)[suse.com:+] X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Level: X-Spam-Flag: NO Instead of open coding a page table walk multiple times, use a generic page table walker instead. This new page table walker will be used later for kexec support, too. Changes in V2: - addressed comments Juergen Gross (3): mini-os: mm: introduce generic page table walk function mini-os: mm: switch need_pgt() to use walk_pt() mini-os: mm: convert set_readonly() to use walk_pt() arch/x86/mm.c | 353 +++++++++++++++++++++++++++++--------------------- 1 file changed, 204 insertions(+), 149 deletions(-) -- 2.43.0 From minios-devel-bounces@lists.xenproject.org Tue Aug 13 13:42:09 2024 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 13 Aug 2024 13:42:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.776267.1186405 (Exim 4.92) (envelope-from ) id 1sdrmq-0005Ee-HZ; Tue, 13 Aug 2024 13:42:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 776267.1186405; Tue, 13 Aug 2024 13:42:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sdrmq-0005EX-Ek; Tue, 13 Aug 2024 13:42:08 +0000 Received: by outflank-mailman (input) for mailman id 776267; Tue, 13 Aug 2024 13:42:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sdrmp-0004yQ-Gl for minios-devel@lists.xenproject.org; Tue, 13 Aug 2024 13:42:07 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2a07:de40:b251:101:10:150:64:2]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d4b803e6-5979-11ef-a505-bb4a2ccca743; Tue, 13 Aug 2024 15:42:06 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 79751203BB; Tue, 13 Aug 2024 13:42:06 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 44F0913ABD; Tue, 13 Aug 2024 13:42:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 3ThgD65iu2bHGQAAD6G6ig (envelope-from ); Tue, 13 Aug 2024 13:42:06 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: d4b803e6-5979-11ef-a505-bb4a2ccca743 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1723556526; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T2ja3qLrlfWYFIuKdqgrD+R8mxMYKKUsy9OjHCkfDZI=; b=cGK2g0PLJmOAji6VVsgOSbX82iVbZWaAwDqkYGdvguJo/BGjkNqCiyCcIIDLqG+fET3OXl vfkyuYDZWZm2BJVTBdhKDkFD5M61viF0HUaoBazvXcftWhvC5J1aSFVcj+HyqVzu8RZ8DE 4iECH6NLKtFYKVVPyaDPcZN/Fc+LHEo= Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1723556526; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T2ja3qLrlfWYFIuKdqgrD+R8mxMYKKUsy9OjHCkfDZI=; b=cGK2g0PLJmOAji6VVsgOSbX82iVbZWaAwDqkYGdvguJo/BGjkNqCiyCcIIDLqG+fET3OXl vfkyuYDZWZm2BJVTBdhKDkFD5M61viF0HUaoBazvXcftWhvC5J1aSFVcj+HyqVzu8RZ8DE 4iECH6NLKtFYKVVPyaDPcZN/Fc+LHEo= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, Juergen Gross Subject: [PATCH v2 1/3] mini-os: mm: introduce generic page table walk function Date: Tue, 13 Aug 2024 15:41:56 +0200 Message-ID: <20240813134158.580-2-jgross@suse.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240813134158.580-1-jgross@suse.com> References: <20240813134158.580-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.80 X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:mid,suse.com:email,imap1.dmz-prg2.suse.org:helo]; RCVD_TLS_ALL(0.00)[] X-Spam-Flag: NO X-Spam-Level: In x86 mm code there are multiple instances of page table walks for different purposes. Introduce a generic page table walker being able to cover the current use cases. It will be used for other cases in future, too. The page table walker needs some per-level data, so add a table for that data. Merge it with the already existing pt_prot[] array. Rewrite get_pgt() to use the new walker. Signed-off-by: Juergen Gross --- V2: - add idx_from_va_lvl() helper (Samuel Thibault) --- arch/x86/mm.c | 157 +++++++++++++++++++++++++++++++++++++------------- 1 file changed, 118 insertions(+), 39 deletions(-) diff --git a/arch/x86/mm.c b/arch/x86/mm.c index 7ddf16e4..9849b985 100644 --- a/arch/x86/mm.c +++ b/arch/x86/mm.c @@ -125,20 +125,30 @@ void arch_mm_preinit(void *p) } #endif +static const struct { + unsigned int shift; + unsigned int entries; + pgentry_t prot; +} ptdata[PAGETABLE_LEVELS + 1] = { + { 0, 0, 0 }, + { L1_PAGETABLE_SHIFT, L1_PAGETABLE_ENTRIES, L1_PROT }, + { L2_PAGETABLE_SHIFT, L2_PAGETABLE_ENTRIES, L2_PROT }, + { L3_PAGETABLE_SHIFT, L3_PAGETABLE_ENTRIES, L3_PROT }, +#if defined(__x86_64__) + { L4_PAGETABLE_SHIFT, L4_PAGETABLE_ENTRIES, L4_PROT }, +#endif +}; + +static inline unsigned int idx_from_va_lvl(unsigned long va, unsigned int lvl) +{ + return (va >> ptdata[lvl].shift) & (ptdata[lvl].entries - 1); +} + /* * Make pt_pfn a new 'level' page table frame and hook it into the page * table at offset in previous level MFN (pref_l_mfn). pt_pfn is a guest * PFN. */ -static pgentry_t pt_prot[PAGETABLE_LEVELS] = { - L1_PROT, - L2_PROT, - L3_PROT, -#if defined(__x86_64__) - L4_PROT, -#endif -}; - static void new_pt_frame(unsigned long *pt_pfn, unsigned long prev_l_mfn, unsigned long offset, unsigned long level) { @@ -170,7 +180,7 @@ static void new_pt_frame(unsigned long *pt_pfn, unsigned long prev_l_mfn, mmu_updates[0].ptr = (tab[l2_table_offset(pt_page)] & PAGE_MASK) + sizeof(pgentry_t) * l1_table_offset(pt_page); mmu_updates[0].val = (pgentry_t)pfn_to_mfn(*pt_pfn) << PAGE_SHIFT | - (pt_prot[level - 1] & ~_PAGE_RW); + (ptdata[level].prot & ~_PAGE_RW); if ( (rc = HYPERVISOR_mmu_update(mmu_updates, 1, NULL, DOMID_SELF)) < 0 ) { @@ -183,7 +193,7 @@ static void new_pt_frame(unsigned long *pt_pfn, unsigned long prev_l_mfn, mmu_updates[0].ptr = ((pgentry_t)prev_l_mfn << PAGE_SHIFT) + sizeof(pgentry_t) * offset; mmu_updates[0].val = (pgentry_t)pfn_to_mfn(*pt_pfn) << PAGE_SHIFT | - pt_prot[level]; + ptdata[level + 1].prot; if ( (rc = HYPERVISOR_mmu_update(mmu_updates, 1, NULL, DOMID_SELF)) < 0 ) { @@ -192,7 +202,7 @@ static void new_pt_frame(unsigned long *pt_pfn, unsigned long prev_l_mfn, } #else tab = mfn_to_virt(prev_l_mfn); - tab[offset] = (*pt_pfn << PAGE_SHIFT) | pt_prot[level]; + tab[offset] = (*pt_pfn << PAGE_SHIFT) | ptdata[level + 1].prot; #endif *pt_pfn += 1; @@ -202,6 +212,82 @@ static void new_pt_frame(unsigned long *pt_pfn, unsigned long prev_l_mfn, static mmu_update_t mmu_updates[L1_PAGETABLE_ENTRIES + 1]; #endif +/* + * Walk recursively through all PTEs calling a specified function. The function + * is allowed to change the PTE, the walker will follow the new value. + * The walk will cover the virtual address range [from_va .. to_va]. + * The supplied function will be called with the following parameters: + * va: base virtual address of the area covered by the current PTE + * lvl: page table level of the PTE (1 = lowest level, PAGETABLE_LEVELS = + * PTE in page table addressed by %cr3) + * is_leaf: true if PTE doesn't address another page table (it is either at + * level 1, or invalid, or has its PSE bit set) + * pte: address of the PTE + * par: parameter, passed to walk_pt() by caller + * Return value of func() being non-zero will terminate walk_pt(), walk_pt() + * will return that value in this case, zero else. + */ +static int walk_pt(unsigned long from_va, unsigned long to_va, + int (func)(unsigned long va, unsigned int lvl, + bool is_leaf, pgentry_t *pte, void *par), + void *par) +{ + unsigned int lvl = PAGETABLE_LEVELS; + unsigned int ptindex[PAGETABLE_LEVELS + 1]; + unsigned long va = round_pgdown(from_va); + unsigned long va_lvl; + pgentry_t *tab[PAGETABLE_LEVELS + 1]; + pgentry_t *pte; + bool is_leaf; + int ret; + + /* Start at top level page table. */ + tab[lvl] = pt_base; + ptindex[lvl] = idx_from_va_lvl(va, lvl); + + while ( va < (to_va | (PAGE_SIZE - 1)) ) + { + pte = tab[lvl] + ptindex[lvl]; + is_leaf = (lvl == L1_FRAME) || (*pte & _PAGE_PSE) || + !(*pte & _PAGE_PRESENT); + va_lvl = va & ~((1UL << ptdata[lvl].shift) - 1); + ret = func(va_lvl, lvl, is_leaf, pte, par); + if ( ret ) + return ret; + + /* PTE might have been modified by func(), reevaluate leaf state. */ + is_leaf = (lvl == L1_FRAME) || (*pte & _PAGE_PSE) || + !(*pte & _PAGE_PRESENT); + + if ( is_leaf ) + { + /* Reached a leaf PTE. Advance to next page. */ + va += 1UL << ptdata[lvl].shift; + ptindex[lvl]++; + + /* Check for the need to traverse up again. */ + while ( ptindex[lvl] == ptdata[lvl].entries ) + { + /* End of virtual address space? */ + if ( lvl == PAGETABLE_LEVELS ) + return 0; + /* Reached end of current page table, one level up. */ + lvl++; + ptindex[lvl]++; + } + } + else + { + /* Not a leaf, walk one level down. */ + lvl--; + tab[lvl] = mfn_to_virt(pte_to_mfn(*pte)); + ptindex[lvl] = idx_from_va_lvl(va, lvl); + } + } + + return 0; +} + /* * Build the initial pagetable. */ @@ -407,36 +493,29 @@ static void set_readonly(void *text, void *etext) /* * get the PTE for virtual address va if it exists. Otherwise NULL. */ -static pgentry_t *get_pgt(unsigned long va) +static int get_pgt_func(unsigned long va, unsigned int lvl, bool is_leaf, + pgentry_t *pte, void *par) { - unsigned long mfn; - pgentry_t *tab; - unsigned offset; + pgentry_t **result; - tab = pt_base; - mfn = virt_to_mfn(pt_base); + if ( !(*pte & _PAGE_PRESENT) && lvl > L1_FRAME ) + return -1; -#if defined(__x86_64__) - offset = l4_table_offset(va); - if ( !(tab[offset] & _PAGE_PRESENT) ) - return NULL; - mfn = pte_to_mfn(tab[offset]); - tab = mfn_to_virt(mfn); -#endif - offset = l3_table_offset(va); - if ( !(tab[offset] & _PAGE_PRESENT) ) - return NULL; - mfn = pte_to_mfn(tab[offset]); - tab = mfn_to_virt(mfn); - offset = l2_table_offset(va); - if ( !(tab[offset] & _PAGE_PRESENT) ) - return NULL; - if ( tab[offset] & _PAGE_PSE ) - return &tab[offset]; - mfn = pte_to_mfn(tab[offset]); - tab = mfn_to_virt(mfn); - offset = l1_table_offset(va); - return &tab[offset]; + if ( lvl > L1_FRAME && !(*pte & _PAGE_PSE) ) + return 0; + + result = par; + *result = pte; + + return 0; +} + +static pgentry_t *get_pgt(unsigned long va) +{ + pgentry_t *tab = NULL; + + walk_pt(va, va, get_pgt_func, &tab); + return tab; } -- 2.43.0 From minios-devel-bounces@lists.xenproject.org Tue Aug 13 13:42:17 2024 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 13 Aug 2024 13:42:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.776269.1186419 (Exim 4.92) (envelope-from ) id 1sdrmz-0005Zr-QV; Tue, 13 Aug 2024 13:42:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 776269.1186419; Tue, 13 Aug 2024 13:42:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sdrmz-0005Zk-No; Tue, 13 Aug 2024 13:42:17 +0000 Received: by outflank-mailman (input) for mailman id 776269; Tue, 13 Aug 2024 13:42:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sdrmy-0005YO-8P for minios-devel@lists.xenproject.org; Tue, 13 Aug 2024 13:42:16 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d813d5c8-5979-11ef-8776-851b0ebba9a2; Tue, 13 Aug 2024 15:42:13 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0E7B0203B9; Tue, 13 Aug 2024 13:42:12 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D699513ABD; Tue, 13 Aug 2024 13:42:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id E+DcMrNiu2bUGQAAD6G6ig (envelope-from ); Tue, 13 Aug 2024 13:42:11 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: d813d5c8-5979-11ef-8776-851b0ebba9a2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1723556532; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mSPiqOW7akL0nRnyX8VpLZ5Z1GRvi01pTr8QTeeTzVI=; b=IMcdZoJ2H/dtByOc/sPV/fLdIor8zw/ZlNS0Drsh1zShfE85oWIC3Ase3eGraVcMxTpNu1 5JW0P2J1KSzJJ2l9GI1qLTz/Y5ihm9o//Lgyk2AztbZJYdXqDpOUuaRMtOgCUe/tKpCV// zQP2bWdRQ1v8YA6VmVMO4/CDJv2gDD0= Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.com header.s=susede1 header.b=IMcdZoJ2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1723556532; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mSPiqOW7akL0nRnyX8VpLZ5Z1GRvi01pTr8QTeeTzVI=; b=IMcdZoJ2H/dtByOc/sPV/fLdIor8zw/ZlNS0Drsh1zShfE85oWIC3Ase3eGraVcMxTpNu1 5JW0P2J1KSzJJ2l9GI1qLTz/Y5ihm9o//Lgyk2AztbZJYdXqDpOUuaRMtOgCUe/tKpCV// zQP2bWdRQ1v8YA6VmVMO4/CDJv2gDD0= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, Juergen Gross Subject: [PATCH v2 2/3] mini-os: mm: switch need_pgt() to use walk_pt() Date: Tue, 13 Aug 2024 15:41:57 +0200 Message-ID: <20240813134158.580-3-jgross@suse.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240813134158.580-1-jgross@suse.com> References: <20240813134158.580-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -3.01 X-Rspamd-Queue-Id: 0E7B0203B9 X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.com:s=susede1]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:dkim,suse.com:email,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; DKIM_TRACE(0.00)[suse.com:+] X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Level: X-Spam-Flag: NO Instead of open coding a page table walk, use walk_pt() in need_pgt(). Signed-off-by: Juergen Gross --- V2: - add comment and ASSERT() (Samuel Thibault) --- arch/x86/mm.c | 72 +++++++++++++++++++++------------------------------ 1 file changed, 30 insertions(+), 42 deletions(-) diff --git a/arch/x86/mm.c b/arch/x86/mm.c index 9849b985..84a6d7f0 100644 --- a/arch/x86/mm.c +++ b/arch/x86/mm.c @@ -523,57 +523,45 @@ static pgentry_t *get_pgt(unsigned long va) * return a valid PTE for a given virtual address. If PTE does not exist, * allocate page-table pages. */ -pgentry_t *need_pgt(unsigned long va) +static int need_pgt_func(unsigned long va, unsigned int lvl, bool is_leaf, + pgentry_t *pte, void *par) { + pgentry_t **result = par; unsigned long pt_mfn; - pgentry_t *tab; unsigned long pt_pfn; - unsigned offset; + unsigned int idx; - tab = pt_base; - pt_mfn = virt_to_mfn(pt_base); + if ( !is_leaf ) + return 0; -#if defined(__x86_64__) - offset = l4_table_offset(va); - if ( !(tab[offset] & _PAGE_PRESENT) ) - { - pt_pfn = virt_to_pfn(alloc_page()); - if ( !pt_pfn ) - return NULL; - new_pt_frame(&pt_pfn, pt_mfn, offset, L3_FRAME); - } - ASSERT(tab[offset] & _PAGE_PRESENT); - pt_mfn = pte_to_mfn(tab[offset]); - tab = mfn_to_virt(pt_mfn); -#endif - offset = l3_table_offset(va); - if ( !(tab[offset] & _PAGE_PRESENT) ) - { - pt_pfn = virt_to_pfn(alloc_page()); - if ( !pt_pfn ) - return NULL; - new_pt_frame(&pt_pfn, pt_mfn, offset, L2_FRAME); - } - ASSERT(tab[offset] & _PAGE_PRESENT); - pt_mfn = pte_to_mfn(tab[offset]); - tab = mfn_to_virt(pt_mfn); - offset = l2_table_offset(va); - if ( !(tab[offset] & _PAGE_PRESENT) ) + if ( lvl == L1_FRAME || (*pte & _PAGE_PRESENT) ) { - pt_pfn = virt_to_pfn(alloc_page()); - if ( !pt_pfn ) - return NULL; - new_pt_frame(&pt_pfn, pt_mfn, offset, L1_FRAME); + /* + * The PTE is not addressing a page table (is_leaf is true). If we are + * either at the lowest level or we have a valid large page, we don't + * need to allocate a page table. + */ + ASSERT(lvl == L1_FRAME || (*pte & _PAGE_PSE)); + *result = pte; + return 1; } - ASSERT(tab[offset] & _PAGE_PRESENT); - if ( tab[offset] & _PAGE_PSE ) - return &tab[offset]; - pt_mfn = pte_to_mfn(tab[offset]); - tab = mfn_to_virt(pt_mfn); + pt_mfn = virt_to_mfn(pte); + pt_pfn = virt_to_pfn(alloc_page()); + if ( !pt_pfn ) + return -1; + idx = idx_from_va_lvl(va, lvl); + new_pt_frame(&pt_pfn, pt_mfn, idx, lvl - 1); - offset = l1_table_offset(va); - return &tab[offset]; + return 0; +} + +pgentry_t *need_pgt(unsigned long va) +{ + pgentry_t *tab = NULL; + + walk_pt(va, va, need_pgt_func, &tab); + return tab; } EXPORT_SYMBOL(need_pgt); -- 2.43.0 From minios-devel-bounces@lists.xenproject.org Tue Aug 13 13:42:21 2024 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 13 Aug 2024 13:42:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.776272.1186443 (Exim 4.92) (envelope-from ) id 1sdrn3-000686-GB; Tue, 13 Aug 2024 13:42:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 776272.1186443; Tue, 13 Aug 2024 13:42:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sdrn3-00067z-Cp; Tue, 13 Aug 2024 13:42:21 +0000 Received: by outflank-mailman (input) for mailman id 776272; Tue, 13 Aug 2024 13:42:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sdrn1-0004yQ-Sw for minios-devel@lists.xenproject.org; Tue, 13 Aug 2024 13:42:19 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id db783807-5979-11ef-a505-bb4a2ccca743; Tue, 13 Aug 2024 15:42:18 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9DF50227F2; Tue, 13 Aug 2024 13:42:17 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 71D5113ABD; Tue, 13 Aug 2024 13:42:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 4odAGrliu2bcGQAAD6G6ig (envelope-from ); Tue, 13 Aug 2024 13:42:17 +0000 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: db783807-5979-11ef-a505-bb4a2ccca743 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1723556537; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WNUXKUrwLG6oWojlY/a5gaayfmUKTp/EVDucqgND6/g=; b=RCaHpQhbdwAQB+BWDqRXK5sPErDQgbeCf5c9+8uhLu+szl9StsyrD0m9ajm7gIpZr4ROGY Wt5t7qSdSgjkXjvGUO+AYjB8owPF6rSQJNUslMpuXaF9J36IxYYKWeJ33bHf/faLMjehUf PMHfwQw/r2L28gTvaMft0OSfI3tfRM0= Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.com header.s=susede1 header.b=RCaHpQhb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1723556537; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WNUXKUrwLG6oWojlY/a5gaayfmUKTp/EVDucqgND6/g=; b=RCaHpQhbdwAQB+BWDqRXK5sPErDQgbeCf5c9+8uhLu+szl9StsyrD0m9ajm7gIpZr4ROGY Wt5t7qSdSgjkXjvGUO+AYjB8owPF6rSQJNUslMpuXaF9J36IxYYKWeJ33bHf/faLMjehUf PMHfwQw/r2L28gTvaMft0OSfI3tfRM0= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, Juergen Gross Subject: [PATCH v2 3/3] mini-os: mm: convert set_readonly() to use walk_pt() Date: Tue, 13 Aug 2024 15:41:58 +0200 Message-ID: <20240813134158.580-4-jgross@suse.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240813134158.580-1-jgross@suse.com> References: <20240813134158.580-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 9DF50227F2 X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.com:s=susede1]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.com:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCPT_COUNT_THREE(0.00)[4]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:dkim,suse.com:mid,suse.com:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns] X-Spam-Score: -3.01 X-Rspamd-Action: no action X-Spam-Flag: NO X-Spam-Level: Instead of having another copy of a page table walk in set_readonly(), just use walk_pt(). As it will be needed later anyway, split out the TLB flushing into a dedicated function. Signed-off-by: Juergen Gross --- V2: - clear count after doing an mmu_update call (Samuel Thibault) - do final mmu_update call from set_readonly() if needed (Samuel Thibault) --- arch/x86/mm.c | 124 +++++++++++++++++++++++--------------------------- 1 file changed, 56 insertions(+), 68 deletions(-) diff --git a/arch/x86/mm.c b/arch/x86/mm.c index 84a6d7f0..85827d93 100644 --- a/arch/x86/mm.c +++ b/arch/x86/mm.c @@ -402,92 +402,80 @@ static void build_pagetable(unsigned long *start_pfn, unsigned long *max_pfn) * Mark portion of the address space read only. */ extern struct shared_info shared_info; -static void set_readonly(void *text, void *etext) -{ - unsigned long start_address = - ((unsigned long) text + PAGE_SIZE - 1) & PAGE_MASK; - unsigned long end_address = (unsigned long) etext; - pgentry_t *tab = pt_base, page; - unsigned long mfn = pfn_to_mfn(virt_to_pfn(pt_base)); - unsigned long offset; - unsigned long page_size = PAGE_SIZE; + +struct set_readonly_par { + unsigned long etext; #ifdef CONFIG_PARAVIRT - int count = 0; - int rc; + unsigned int count; #endif +}; - printk("setting %p-%p readonly\n", text, etext); +static int set_readonly_func(unsigned long va, unsigned int lvl, bool is_leaf, + pgentry_t *pte, void *par) +{ + struct set_readonly_par *ro = par; - while ( start_address + page_size <= end_address ) - { - tab = pt_base; - mfn = pfn_to_mfn(virt_to_pfn(pt_base)); + if ( !is_leaf ) + return 0; -#if defined(__x86_64__) - offset = l4_table_offset(start_address); - page = tab[offset]; - mfn = pte_to_mfn(page); - tab = to_virt(mfn_to_pfn(mfn) << PAGE_SHIFT); -#endif - offset = l3_table_offset(start_address); - page = tab[offset]; - mfn = pte_to_mfn(page); - tab = to_virt(mfn_to_pfn(mfn) << PAGE_SHIFT); - offset = l2_table_offset(start_address); - if ( !(tab[offset] & _PAGE_PSE) ) - { - page = tab[offset]; - mfn = pte_to_mfn(page); - tab = to_virt(mfn_to_pfn(mfn) << PAGE_SHIFT); + if ( va + (1UL << ptdata[lvl].shift) > ro->etext ) + return 1; - offset = l1_table_offset(start_address); - } + if ( va == (unsigned long)&shared_info ) + { + printk("skipped %lx\n", va); + return 0; + } - if ( start_address != (unsigned long)&shared_info ) - { #ifdef CONFIG_PARAVIRT - mmu_updates[count].ptr = - ((pgentry_t)mfn << PAGE_SHIFT) + sizeof(pgentry_t) * offset; - mmu_updates[count].val = tab[offset] & ~_PAGE_RW; - count++; + mmu_updates[ro->count].ptr = virt_to_mach(pte); + mmu_updates[ro->count].val = *pte & ~_PAGE_RW; + ro->count++; + + if ( ro->count == L1_PAGETABLE_ENTRIES ) + { + ro->count = 0; + if ( HYPERVISOR_mmu_update(mmu_updates, ro->count, NULL, + DOMID_SELF) < 0 ) + BUG(); + } #else - tab[offset] &= ~_PAGE_RW; + *pte &= ~_PAGE_RW; #endif - } - else - printk("skipped %lx\n", start_address); - start_address += page_size; + return 0; +} #ifdef CONFIG_PARAVIRT - if ( count == L1_PAGETABLE_ENTRIES || - start_address + page_size > end_address ) - { - rc = HYPERVISOR_mmu_update(mmu_updates, count, NULL, DOMID_SELF); - if ( rc < 0 ) - { - printk("ERROR: set_readonly(): PTE could not be updated\n"); - do_exit(); - } - count = 0; - } +static void tlb_flush(void) +{ + mmuext_op_t op = { .cmd = MMUEXT_TLB_FLUSH_ALL }; + int count; + + HYPERVISOR_mmuext_op(&op, 1, &count, DOMID_SELF); +} #else - if ( start_address == (1UL << L2_PAGETABLE_SHIFT) ) - page_size = 1UL << L2_PAGETABLE_SHIFT; +static void tlb_flush(void) +{ + write_cr3((unsigned long)pt_base); +} #endif - } + +static void set_readonly(void *text, void *etext) +{ + struct set_readonly_par setro = { .etext = (unsigned long)etext }; + unsigned long start_address = PAGE_ALIGN((unsigned long)text); + + printk("setting %p-%p readonly\n", text, etext); + walk_pt(start_address, setro.etext, set_readonly_func, &setro); #ifdef CONFIG_PARAVIRT - { - mmuext_op_t op = { - .cmd = MMUEXT_TLB_FLUSH_ALL, - }; - int count; - HYPERVISOR_mmuext_op(&op, 1, &count, DOMID_SELF); - } -#else - write_cr3((unsigned long)pt_base); + if ( setro.count && + HYPERVISOR_mmu_update(mmu_updates, setro.count, NULL, DOMID_SELF) < 0) + BUG(); #endif + + tlb_flush(); } /* -- 2.43.0 From minios-devel-bounces@lists.xenproject.org Tue Aug 20 11:52:57 2024 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 20 Aug 2024 11:52:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.780317.1189938 (Exim 4.92) (envelope-from ) id 1sgNPz-0006EF-GB; Tue, 20 Aug 2024 11:52:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 780317.1189938; Tue, 20 Aug 2024 11:52:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sgNPz-0006E8-Da; Tue, 20 Aug 2024 11:52:55 +0000 Received: by outflank-mailman (input) for mailman id 780317; Tue, 20 Aug 2024 11:52:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sgNPx-0006Dx-Ul for minios-devel@lists.xenproject.org; Tue, 20 Aug 2024 11:52:53 +0000 Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b9504ca1-5eea-11ef-8776-851b0ebba9a2; Tue, 20 Aug 2024 13:52:50 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 7583CA03AE; Tue, 20 Aug 2024 13:52:49 +0200 (CEST) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UeHk8AajPhZO; Tue, 20 Aug 2024 13:52:49 +0200 (CEST) Received: from begin (nat-inria-interne-52-gw-01-bso.bordeaux.inria.fr [194.199.1.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 53747A0345; Tue, 20 Aug 2024 13:52:49 +0200 (CEST) Received: from samy by begin with local (Exim 4.98) (envelope-from ) id 1sgNPs-00000000FYr-4Bk7; Tue, 20 Aug 2024 13:52:49 +0200 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: b9504ca1-5eea-11ef-8776-851b0ebba9a2 Date: Tue, 20 Aug 2024 13:52:48 +0200 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH v2 1/3] mini-os: mm: introduce generic page table walk function Message-ID: <20240820115248.34qg23znyx5qoh37@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org References: <20240813134158.580-1-jgross@suse.com> <20240813134158.580-2-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240813134158.580-2-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le mar. 13 août 2024 15:41:56 +0200, a ecrit: > In x86 mm code there are multiple instances of page table walks for > different purposes. > > Introduce a generic page table walker being able to cover the current > use cases. It will be used for other cases in future, too. > > The page table walker needs some per-level data, so add a table for > that data. Merge it with the already existing pt_prot[] array. > > Rewrite get_pgt() to use the new walker. > > Signed-off-by: Juergen Gross Reviewed-by: SAmuel Thibault > --- > V2: > - add idx_from_va_lvl() helper (Samuel Thibault) > --- > arch/x86/mm.c | 157 +++++++++++++++++++++++++++++++++++++------------- > 1 file changed, 118 insertions(+), 39 deletions(-) > > diff --git a/arch/x86/mm.c b/arch/x86/mm.c > index 7ddf16e4..9849b985 100644 > --- a/arch/x86/mm.c > +++ b/arch/x86/mm.c > @@ -125,20 +125,30 @@ void arch_mm_preinit(void *p) > } > #endif > > +static const struct { > + unsigned int shift; > + unsigned int entries; > + pgentry_t prot; > +} ptdata[PAGETABLE_LEVELS + 1] = { > + { 0, 0, 0 }, > + { L1_PAGETABLE_SHIFT, L1_PAGETABLE_ENTRIES, L1_PROT }, > + { L2_PAGETABLE_SHIFT, L2_PAGETABLE_ENTRIES, L2_PROT }, > + { L3_PAGETABLE_SHIFT, L3_PAGETABLE_ENTRIES, L3_PROT }, > +#if defined(__x86_64__) > + { L4_PAGETABLE_SHIFT, L4_PAGETABLE_ENTRIES, L4_PROT }, > +#endif > +}; > + > +static inline unsigned int idx_from_va_lvl(unsigned long va, unsigned int lvl) > +{ > + return (va >> ptdata[lvl].shift) & (ptdata[lvl].entries - 1); > +} > + > /* > * Make pt_pfn a new 'level' page table frame and hook it into the page > * table at offset in previous level MFN (pref_l_mfn). pt_pfn is a guest > * PFN. > */ > -static pgentry_t pt_prot[PAGETABLE_LEVELS] = { > - L1_PROT, > - L2_PROT, > - L3_PROT, > -#if defined(__x86_64__) > - L4_PROT, > -#endif > -}; > - > static void new_pt_frame(unsigned long *pt_pfn, unsigned long prev_l_mfn, > unsigned long offset, unsigned long level) > { > @@ -170,7 +180,7 @@ static void new_pt_frame(unsigned long *pt_pfn, unsigned long prev_l_mfn, > mmu_updates[0].ptr = (tab[l2_table_offset(pt_page)] & PAGE_MASK) + > sizeof(pgentry_t) * l1_table_offset(pt_page); > mmu_updates[0].val = (pgentry_t)pfn_to_mfn(*pt_pfn) << PAGE_SHIFT | > - (pt_prot[level - 1] & ~_PAGE_RW); > + (ptdata[level].prot & ~_PAGE_RW); > > if ( (rc = HYPERVISOR_mmu_update(mmu_updates, 1, NULL, DOMID_SELF)) < 0 ) > { > @@ -183,7 +193,7 @@ static void new_pt_frame(unsigned long *pt_pfn, unsigned long prev_l_mfn, > mmu_updates[0].ptr = > ((pgentry_t)prev_l_mfn << PAGE_SHIFT) + sizeof(pgentry_t) * offset; > mmu_updates[0].val = (pgentry_t)pfn_to_mfn(*pt_pfn) << PAGE_SHIFT | > - pt_prot[level]; > + ptdata[level + 1].prot; > > if ( (rc = HYPERVISOR_mmu_update(mmu_updates, 1, NULL, DOMID_SELF)) < 0 ) > { > @@ -192,7 +202,7 @@ static void new_pt_frame(unsigned long *pt_pfn, unsigned long prev_l_mfn, > } > #else > tab = mfn_to_virt(prev_l_mfn); > - tab[offset] = (*pt_pfn << PAGE_SHIFT) | pt_prot[level]; > + tab[offset] = (*pt_pfn << PAGE_SHIFT) | ptdata[level + 1].prot; > #endif > > *pt_pfn += 1; > @@ -202,6 +212,82 @@ static void new_pt_frame(unsigned long *pt_pfn, unsigned long prev_l_mfn, > static mmu_update_t mmu_updates[L1_PAGETABLE_ENTRIES + 1]; > #endif > > +/* > + * Walk recursively through all PTEs calling a specified function. The function > + * is allowed to change the PTE, the walker will follow the new value. > + * The walk will cover the virtual address range [from_va .. to_va]. > + * The supplied function will be called with the following parameters: > + * va: base virtual address of the area covered by the current PTE > + * lvl: page table level of the PTE (1 = lowest level, PAGETABLE_LEVELS = > + * PTE in page table addressed by %cr3) > + * is_leaf: true if PTE doesn't address another page table (it is either at > + * level 1, or invalid, or has its PSE bit set) > + * pte: address of the PTE > + * par: parameter, passed to walk_pt() by caller > + * Return value of func() being non-zero will terminate walk_pt(), walk_pt() > + * will return that value in this case, zero else. > + */ > +static int walk_pt(unsigned long from_va, unsigned long to_va, > + int (func)(unsigned long va, unsigned int lvl, > + bool is_leaf, pgentry_t *pte, void *par), > + void *par) > +{ > + unsigned int lvl = PAGETABLE_LEVELS; > + unsigned int ptindex[PAGETABLE_LEVELS + 1]; > + unsigned long va = round_pgdown(from_va); > + unsigned long va_lvl; > + pgentry_t *tab[PAGETABLE_LEVELS + 1]; > + pgentry_t *pte; > + bool is_leaf; > + int ret; > + > + /* Start at top level page table. */ > + tab[lvl] = pt_base; > + ptindex[lvl] = idx_from_va_lvl(va, lvl); > + > + while ( va < (to_va | (PAGE_SIZE - 1)) ) > + { > + pte = tab[lvl] + ptindex[lvl]; > + is_leaf = (lvl == L1_FRAME) || (*pte & _PAGE_PSE) || > + !(*pte & _PAGE_PRESENT); > + va_lvl = va & ~((1UL << ptdata[lvl].shift) - 1); > + ret = func(va_lvl, lvl, is_leaf, pte, par); > + if ( ret ) > + return ret; > + > + /* PTE might have been modified by func(), reevaluate leaf state. */ > + is_leaf = (lvl == L1_FRAME) || (*pte & _PAGE_PSE) || > + !(*pte & _PAGE_PRESENT); > + > + if ( is_leaf ) > + { > + /* Reached a leaf PTE. Advance to next page. */ > + va += 1UL << ptdata[lvl].shift; > + ptindex[lvl]++; > + > + /* Check for the need to traverse up again. */ > + while ( ptindex[lvl] == ptdata[lvl].entries ) > + { > + /* End of virtual address space? */ > + if ( lvl == PAGETABLE_LEVELS ) > + return 0; > + /* Reached end of current page table, one level up. */ > + lvl++; > + ptindex[lvl]++; > + } > + } > + else > + { > + /* Not a leaf, walk one level down. */ > + lvl--; > + tab[lvl] = mfn_to_virt(pte_to_mfn(*pte)); > + ptindex[lvl] = idx_from_va_lvl(va, lvl); > + } > + } > + > + return 0; > +} > + > /* > * Build the initial pagetable. > */ > @@ -407,36 +493,29 @@ static void set_readonly(void *text, void *etext) > /* > * get the PTE for virtual address va if it exists. Otherwise NULL. > */ > -static pgentry_t *get_pgt(unsigned long va) > +static int get_pgt_func(unsigned long va, unsigned int lvl, bool is_leaf, > + pgentry_t *pte, void *par) > { > - unsigned long mfn; > - pgentry_t *tab; > - unsigned offset; > + pgentry_t **result; > > - tab = pt_base; > - mfn = virt_to_mfn(pt_base); > + if ( !(*pte & _PAGE_PRESENT) && lvl > L1_FRAME ) > + return -1; > > -#if defined(__x86_64__) > - offset = l4_table_offset(va); > - if ( !(tab[offset] & _PAGE_PRESENT) ) > - return NULL; > - mfn = pte_to_mfn(tab[offset]); > - tab = mfn_to_virt(mfn); > -#endif > - offset = l3_table_offset(va); > - if ( !(tab[offset] & _PAGE_PRESENT) ) > - return NULL; > - mfn = pte_to_mfn(tab[offset]); > - tab = mfn_to_virt(mfn); > - offset = l2_table_offset(va); > - if ( !(tab[offset] & _PAGE_PRESENT) ) > - return NULL; > - if ( tab[offset] & _PAGE_PSE ) > - return &tab[offset]; > - mfn = pte_to_mfn(tab[offset]); > - tab = mfn_to_virt(mfn); > - offset = l1_table_offset(va); > - return &tab[offset]; > + if ( lvl > L1_FRAME && !(*pte & _PAGE_PSE) ) > + return 0; > + > + result = par; > + *result = pte; > + > + return 0; > +} > + > +static pgentry_t *get_pgt(unsigned long va) > +{ > + pgentry_t *tab = NULL; > + > + walk_pt(va, va, get_pgt_func, &tab); > + return tab; > } > > > -- > 2.43.0 > -- Samuel je déteste import parce que lorsque tu fais du python et que tu oublies le #!/bin/env python et que tu mets le fichier exécutable import est exécuté -+- #ens-mim - pourquoi mon script python change le curseur de la souris ?! -+- From minios-devel-bounces@lists.xenproject.org Tue Aug 20 11:54:40 2024 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 20 Aug 2024 11:54:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.780328.1189951 (Exim 4.92) (envelope-from ) id 1sgNRf-0006qw-RW; Tue, 20 Aug 2024 11:54:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 780328.1189951; Tue, 20 Aug 2024 11:54:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sgNRf-0006qp-P5; Tue, 20 Aug 2024 11:54:39 +0000 Received: by outflank-mailman (input) for mailman id 780328; Tue, 20 Aug 2024 11:54:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sgNRf-0006qh-8v for minios-devel@lists.xenproject.org; Tue, 20 Aug 2024 11:54:39 +0000 Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f941f859-5eea-11ef-a507-bb4a2ccca743; Tue, 20 Aug 2024 13:54:37 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id CB27CA03AF; Tue, 20 Aug 2024 13:54:36 +0200 (CEST) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jJVVtPd4cGEY; Tue, 20 Aug 2024 13:54:36 +0200 (CEST) Received: from begin (nat-inria-interne-52-gw-01-bso.bordeaux.inria.fr [194.199.1.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id B0A72A03AE; Tue, 20 Aug 2024 13:54:36 +0200 (CEST) Received: from samy by begin with local (Exim 4.98) (envelope-from ) id 1sgNRc-00000000FaV-1YWr; Tue, 20 Aug 2024 13:54:36 +0200 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: f941f859-5eea-11ef-a507-bb4a2ccca743 Date: Tue, 20 Aug 2024 13:54:36 +0200 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH v2 2/3] mini-os: mm: switch need_pgt() to use walk_pt() Message-ID: <20240820115436.hnrh5abr66rf6hhc@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org References: <20240813134158.580-1-jgross@suse.com> <20240813134158.580-3-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240813134158.580-3-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le mar. 13 août 2024 15:41:57 +0200, a ecrit: > Instead of open coding a page table walk, use walk_pt() in need_pgt(). > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V2: > - add comment and ASSERT() (Samuel Thibault) > --- > arch/x86/mm.c | 72 +++++++++++++++++++++------------------------------ > 1 file changed, 30 insertions(+), 42 deletions(-) > > diff --git a/arch/x86/mm.c b/arch/x86/mm.c > index 9849b985..84a6d7f0 100644 > --- a/arch/x86/mm.c > +++ b/arch/x86/mm.c > @@ -523,57 +523,45 @@ static pgentry_t *get_pgt(unsigned long va) > * return a valid PTE for a given virtual address. If PTE does not exist, > * allocate page-table pages. > */ > -pgentry_t *need_pgt(unsigned long va) > +static int need_pgt_func(unsigned long va, unsigned int lvl, bool is_leaf, > + pgentry_t *pte, void *par) > { > + pgentry_t **result = par; > unsigned long pt_mfn; > - pgentry_t *tab; > unsigned long pt_pfn; > - unsigned offset; > + unsigned int idx; > > - tab = pt_base; > - pt_mfn = virt_to_mfn(pt_base); > + if ( !is_leaf ) > + return 0; > > -#if defined(__x86_64__) > - offset = l4_table_offset(va); > - if ( !(tab[offset] & _PAGE_PRESENT) ) > - { > - pt_pfn = virt_to_pfn(alloc_page()); > - if ( !pt_pfn ) > - return NULL; > - new_pt_frame(&pt_pfn, pt_mfn, offset, L3_FRAME); > - } > - ASSERT(tab[offset] & _PAGE_PRESENT); > - pt_mfn = pte_to_mfn(tab[offset]); > - tab = mfn_to_virt(pt_mfn); > -#endif > - offset = l3_table_offset(va); > - if ( !(tab[offset] & _PAGE_PRESENT) ) > - { > - pt_pfn = virt_to_pfn(alloc_page()); > - if ( !pt_pfn ) > - return NULL; > - new_pt_frame(&pt_pfn, pt_mfn, offset, L2_FRAME); > - } > - ASSERT(tab[offset] & _PAGE_PRESENT); > - pt_mfn = pte_to_mfn(tab[offset]); > - tab = mfn_to_virt(pt_mfn); > - offset = l2_table_offset(va); > - if ( !(tab[offset] & _PAGE_PRESENT) ) > + if ( lvl == L1_FRAME || (*pte & _PAGE_PRESENT) ) > { > - pt_pfn = virt_to_pfn(alloc_page()); > - if ( !pt_pfn ) > - return NULL; > - new_pt_frame(&pt_pfn, pt_mfn, offset, L1_FRAME); > + /* > + * The PTE is not addressing a page table (is_leaf is true). If we are > + * either at the lowest level or we have a valid large page, we don't > + * need to allocate a page table. > + */ > + ASSERT(lvl == L1_FRAME || (*pte & _PAGE_PSE)); > + *result = pte; > + return 1; > } > - ASSERT(tab[offset] & _PAGE_PRESENT); > - if ( tab[offset] & _PAGE_PSE ) > - return &tab[offset]; > > - pt_mfn = pte_to_mfn(tab[offset]); > - tab = mfn_to_virt(pt_mfn); > + pt_mfn = virt_to_mfn(pte); > + pt_pfn = virt_to_pfn(alloc_page()); > + if ( !pt_pfn ) > + return -1; > + idx = idx_from_va_lvl(va, lvl); > + new_pt_frame(&pt_pfn, pt_mfn, idx, lvl - 1); > > - offset = l1_table_offset(va); > - return &tab[offset]; > + return 0; > +} > + > +pgentry_t *need_pgt(unsigned long va) > +{ > + pgentry_t *tab = NULL; > + > + walk_pt(va, va, need_pgt_func, &tab); > + return tab; > } > EXPORT_SYMBOL(need_pgt); > > -- > 2.43.0 > -- Samuel je déteste import parce que lorsque tu fais du python et que tu oublies le #!/bin/env python et que tu mets le fichier exécutable import est exécuté -+- #ens-mim - pourquoi mon script python change le curseur de la souris ?! -+- From minios-devel-bounces@lists.xenproject.org Tue Aug 20 11:57:46 2024 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 20 Aug 2024 11:57:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.780345.1189967 (Exim 4.92) (envelope-from ) id 1sgNUg-00088A-EV; Tue, 20 Aug 2024 11:57:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 780345.1189967; Tue, 20 Aug 2024 11:57:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sgNUg-000883-Ak; Tue, 20 Aug 2024 11:57:46 +0000 Received: by outflank-mailman (input) for mailman id 780345; Tue, 20 Aug 2024 11:57:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sgNUe-00087s-Tj for minios-devel@lists.xenproject.org; Tue, 20 Aug 2024 11:57:44 +0000 Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 68b1128b-5eeb-11ef-a507-bb4a2ccca743; Tue, 20 Aug 2024 13:57:44 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id BF681A0242; Tue, 20 Aug 2024 13:57:43 +0200 (CEST) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tRsckY0ESDaT; Tue, 20 Aug 2024 13:57:43 +0200 (CEST) Received: from begin (nat-inria-interne-52-gw-01-bso.bordeaux.inria.fr [194.199.1.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id A71F4A023C; Tue, 20 Aug 2024 13:57:43 +0200 (CEST) Received: from samy by begin with local (Exim 4.98) (envelope-from ) id 1sgNUd-00000000Fg8-1IZG; Tue, 20 Aug 2024 13:57:43 +0200 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 68b1128b-5eeb-11ef-a507-bb4a2ccca743 Date: Tue, 20 Aug 2024 13:57:43 +0200 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH v2 3/3] mini-os: mm: convert set_readonly() to use walk_pt() Message-ID: <20240820115743.teyoiov6qx63flna@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org References: <20240813134158.580-1-jgross@suse.com> <20240813134158.580-4-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240813134158.580-4-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le mar. 13 août 2024 15:41:58 +0200, a ecrit: > + if ( ro->count == L1_PAGETABLE_ENTRIES ) > + { > + ro->count = 0; > + if ( HYPERVISOR_mmu_update(mmu_updates, ro->count, NULL, > + DOMID_SELF) < 0 ) You need to set ro->count *after* calling mmu_update. Apart from this, Reviewed-by: Samuel Thibault Samuel From minios-devel-bounces@lists.xenproject.org Tue Aug 20 12:53:42 2024 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 20 Aug 2024 12:53:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.780377.1190000 (Exim 4.92) (envelope-from ) id 1sgOMn-0001he-1w; Tue, 20 Aug 2024 12:53:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 780377.1190000; Tue, 20 Aug 2024 12:53:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sgOMm-0001hZ-V2; Tue, 20 Aug 2024 12:53:40 +0000 Received: by outflank-mailman (input) for mailman id 780377; Tue, 20 Aug 2024 12:53:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sgOMm-0001hO-1l for minios-devel@lists.xenproject.org; Tue, 20 Aug 2024 12:53:40 +0000 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [2a00:1450:4864:20::633]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 37bc6ded-5ef3-11ef-8776-851b0ebba9a2; Tue, 20 Aug 2024 14:53:37 +0200 (CEST) Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-a7d26c2297eso625988766b.2 for ; Tue, 20 Aug 2024 05:53:38 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8383934564sm755321066b.126.2024.08.20.05.53.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Aug 2024 05:53:37 -0700 (PDT) X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 37bc6ded-5ef3-11ef-8776-851b0ebba9a2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1724158418; x=1724763218; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=9tqL6KJwHijGWE8p+gVbOgEAibadQLjqxyFvRKxEk5k=; b=JrDK6mKzJopPEkYeyX07VvzJbwd+Neb8Q/ms1IsttyfYCU41ykvcNd1kncpzgj5Di0 tA8Bb1Cr26U8/7n814J1wfFjQg40AjzZKQRt7iZW8Bxyo+JewZAitwFlvZMRMPUT89HA 5qds5yn2YTByW0UZjZYSBQ+QnLxlRBzOggmRHBIoJzN5KzqBufDRECltCq9ISGeBxSmf znvb9su7/0EMzld35tpC3cCLljku5rRVSfyvKzipU+QBk2G0XiUsZiOLOdHbrLPDFPNK TpIGet4NBz1FYjVoeNkKEkkiychL5uV6syjw16/QIU1gDBBG03/8bgFn6g7x6zFppRGj 1DmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724158418; x=1724763218; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9tqL6KJwHijGWE8p+gVbOgEAibadQLjqxyFvRKxEk5k=; b=B8tM7NlcpbZSC2AML+ntAqSyPlYQQzaDil+tg6qEk+DIEW0mQHgYL3k7Zs2CrOPhbR 7kWY5CJaHK2ZXY6iBA668ek/yAyK4oN9R58sWSrfhA7ubCKJjN5B9A2nXWc4dcgQonfK Hvpbn3vP3Luw1nA23YIa7fZZaJFW1un62wVMVBFAVVMZEaoqgO5QyBNI6Z5bzPG7i5Ut l1vMhKmF5IPPSdQIA6u4QX4Vqf1ksEqRJD7w/tA1ActaFKjfQQ0rVp/p0vCrgXBj7+/D V0I6jvIfCcdjGx1DoCAE8HWmLwDzNYYTLwdF+vospAdJpt3ToqNhk6WRcCrxZBenx9mh 4e5g== X-Gm-Message-State: AOJu0YyFwLHou9/WsvaCx8kv8H28GSEKwW79oAEgFRExmv8sysrsewcz qXW+bY1NatdBTVYC+Ihu+GRX6tZ4Mj1wUa1xBNVfxDfU57X6CkkO4L2KGUcedjxkTcKAu7TjenE = X-Google-Smtp-Source: AGHT+IFi1wPUNJcNjE9Zsx5hzbitTRutX9cfgKBtyw1lubV9H01bHFGgxeV0uZMFu3JN84biB5iGvA== X-Received: by 2002:a17:907:e212:b0:a77:c199:9d01 with SMTP id a640c23a62f3a-a839292deecmr1020809466b.22.1724158417647; Tue, 20 Aug 2024 05:53:37 -0700 (PDT) Message-ID: Date: Tue, 20 Aug 2024 14:53:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] mini-os: mm: convert set_readonly() to use walk_pt() To: Samuel Thibault , Juergen Gross References: <20240813134158.580-1-jgross@suse.com> <20240813134158.580-4-jgross@suse.com> <20240820115743.teyoiov6qx63flna@begin> Content-Language: en-US Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20240820115743.teyoiov6qx63flna@begin> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 20.08.2024 13:57, Samuel Thibault wrote: > Juergen Gross, le mar. 13 août 2024 15:41:58 +0200, a ecrit: >> + if ( ro->count == L1_PAGETABLE_ENTRIES ) >> + { >> + ro->count = 0; >> + if ( HYPERVISOR_mmu_update(mmu_updates, ro->count, NULL, >> + DOMID_SELF) < 0 ) > > You need to set ro->count *after* calling mmu_update. Happy to move the line while committing, so long as Jürgen agrees. Jan > Apart from this, > > Reviewed-by: Samuel Thibault > > Samuel > From minios-devel-bounces@lists.xenproject.org Tue Aug 20 13:10:50 2024 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 20 Aug 2024 13:10:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.780408.1190034 (Exim 4.92) (envelope-from ) id 1sgOdN-0006QG-0u; Tue, 20 Aug 2024 13:10:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 780408.1190034; Tue, 20 Aug 2024 13:10:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sgOdM-0006Q9-UB; Tue, 20 Aug 2024 13:10:48 +0000 Received: by outflank-mailman (input) for mailman id 780408; Tue, 20 Aug 2024 13:10:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sgOdM-0006Aa-1a for minios-devel@lists.xenproject.org; Tue, 20 Aug 2024 13:10:48 +0000 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [2a00:1450:4864:20::629]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9cda2a1d-5ef5-11ef-8776-851b0ebba9a2; Tue, 20 Aug 2024 15:10:46 +0200 (CEST) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-a8643235f99so135915666b.3 for ; Tue, 20 Aug 2024 06:10:46 -0700 (PDT) Received: from ?IPV6:2003:e5:8741:4a00:60e5:7bee:fc48:e85c? (p200300e587414a0060e57beefc48e85c.dip0.t-ipconnect.de. [2003:e5:8741:4a00:60e5:7bee:fc48:e85c]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a83839342f6sm761653966b.137.2024.08.20.06.10.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Aug 2024 06:10:44 -0700 (PDT) X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 9cda2a1d-5ef5-11ef-8776-851b0ebba9a2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1724159446; x=1724764246; darn=lists.xenproject.org; h=in-reply-to:autocrypt:from:content-language:references:cc:to :subject:user-agent:mime-version:date:message-id:from:to:cc:subject :date:message-id:reply-to; bh=06TrBrNLciHi6+vfpuKN7ddrFMPcoea/z9MTlgnXLXw=; b=Nv5fbPqG44IVE9SnRK/6AobzKguPPPheWwMeVJOhyMF0uGUDcPRxWysCCjgIArmdSc X5izotDxXNigr335qHP0x7yoU0/O+ir6g4pCEa+tsUDG9xTY0uUtFl9JyvXdC+2iJOqK CumSiPOxbrozsdWImNgMSKZkUGOp3Pjtblq2Ein6FRwI6+iDgnJ/VZ7fu3Q8zKT3YaAm Yf7dsljyPl5y9mHKmtLEFdbNNQn5xp9EcUaqDvLr+Pt69I0ZatutGbQVM9EYJ3Qn+l4X yWZcw13heDEF+dbpSuwXccWmWtEGhGe84BJca/OHcC6pMOA7fZdeD36wWKd+ooUnY3k+ 04XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724159446; x=1724764246; h=in-reply-to:autocrypt:from:content-language:references:cc:to :subject:user-agent:mime-version:date:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=06TrBrNLciHi6+vfpuKN7ddrFMPcoea/z9MTlgnXLXw=; b=bjbvukcW+E/7ZU8SMT3L6l0QIGfDeeWYuAAotoMND4U9g7cU+iDW3d+aujV2m9+/7i kWsE55+jfVi3CtRwpIsBJUdbruUl7sHdKH987ZiE2zUQTX/5Jhhkr8yvAsChZf/rBBHI kbJCKrnEmes37FtJ+geW6bwUEI48p1g2RH5Z3FMFgBTcxG8hbQuRRK+czpO2XskzAYsV oB8RQliuD4g6mc+9yUcWfHF2GBmuLh00xQp+RzL93oxVRbEZHOxLXqIN/FpdUgW/4SVB 55u5ukF9BsZOiohJcrULXQcGFzD7FxCRYJPES2+QZNfhWenMGWJJO0pfU6Jd+P7r1T20 sSeg== X-Gm-Message-State: AOJu0YwPb6tNgKqjNjW9z2MtReIB2j0XCO9JrhCzYw8//n5I45h+26ZP pvN4fdjF9q2JKa9WR/Nw6NF7Z/I+p8gCys5JDPIYbgEtxGhxoqVgN0K6Ne7qv1c= X-Google-Smtp-Source: AGHT+IEedr4iw1LWLs4QUWehBKVbDSElzBGPOw6gdDlbK/p6vMuAAkuG0Xa91bi2rWRjb4EK3VnvWg== X-Received: by 2002:a17:907:97d5:b0:a6f:5150:b807 with SMTP id a640c23a62f3a-a8647a136e1mr134840466b.35.1724159445415; Tue, 20 Aug 2024 06:10:45 -0700 (PDT) Message-ID: <79ab432d-2551-41c0-afd0-4223764ded1e@suse.com> Date: Tue, 20 Aug 2024 15:10:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] mini-os: mm: convert set_readonly() to use walk_pt() To: Jan Beulich , Samuel Thibault Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org References: <20240813134158.580-1-jgross@suse.com> <20240813134158.580-4-jgross@suse.com> <20240820115743.teyoiov6qx63flna@begin> Content-Language: en-US From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------OQwIt5mfwX76T0mgkJFrSFDr" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------OQwIt5mfwX76T0mgkJFrSFDr Content-Type: multipart/mixed; boundary="------------hBhs6O40hIWJOFZchOs0wO11"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Jan Beulich , Samuel Thibault Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Message-ID: <79ab432d-2551-41c0-afd0-4223764ded1e@suse.com> Subject: Re: [PATCH v2 3/3] mini-os: mm: convert set_readonly() to use walk_pt() References: <20240813134158.580-1-jgross@suse.com> <20240813134158.580-4-jgross@suse.com> <20240820115743.teyoiov6qx63flna@begin> In-Reply-To: Autocrypt-Gossip: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJ3BBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AAIQkQoDSui/t3IH4WIQQ+pJkfkcoLMCa4X6CgNK6L+3cgfgn7AJ9DmMd0SMJE ePbc7/m22D2v04iu7ACffXTdZQhNl557tJuDXZSBxDmW/tLOwU0EWTecRBAIAIK5OMKMU5R2 Lk2bbjgX7vyQuCFFyKf9rC/4itNwhYWFSlKzVj3WJBDsoi2KvPm7AI+XB6NIkNAkshL5C0kd pcNd5Xo0jRR5/WE/bT7LyrJ0OJWS/qUit5eNNvsO+SxGAk28KRa1ieVLeZi9D03NL0+HIAtZ tecfqwgl3Y72UpLUyt+r7LQhcI/XR5IUUaD4C/chB4Vq2QkDKO7Q8+2HJOrFIjiVli4lU+Sf OBp64m//Y1xys++Z4ODoKh7tkh5DxiO3QBHG7bHK0CSQsJ6XUvPVYubAuy1XfSDzSeSBl//C v78Fclb+gi9GWidSTG/4hsEzd1fY5XwCZG/XJJY9M/sAAwUH/09Ar9W2U1Qm+DwZeP2ii3Ou 14Z9VlVVPhcEmR/AFykL9dw/OV2O/7cdi52+l00reUu6Nd4Dl8s4f5n8b1YFzmkVVIyhwjvU jxtPyUgDOt6DRa+RaDlXZZmxQyWcMv2anAgYWGVszeB8Myzsw8y7xhBEVV1S+1KloCzw4V8Z DSJrcsZlyMDoiTb7FyqxwQnM0f6qHxWbmOOnbzJmBqpNpFuDcz/4xNsymJylm6oXiucHQBAP Xb/cE1YNHpuaH4SRhIxwQilCYEznWowQphNAbJtEKOmcocY7EbSt8VjXTzmYENkIfkrHRyXQ dUm5AoL51XZljkCqNwrADGkTvkwsWSvCSQQYEQIACQUCWTecRAIbDAAKCRCgNK6L+3cgfuef AJ9wlZQNQUp0KwEf8Tl37RmcxCL4bQCcC5alCSMzUBJ5DBIcR4BY+CyQFAs= --------------hBhs6O40hIWJOFZchOs0wO11 Content-Type: multipart/mixed; boundary="------------OSoN7QDx5p5VoSJjpDAr9WS2" --------------OSoN7QDx5p5VoSJjpDAr9WS2 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjAuMDguMjQgMTQ6NTMsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyMC4wOC4yMDI0 IDEzOjU3LCBTYW11ZWwgVGhpYmF1bHQgd3JvdGU6DQo+PiBKdWVyZ2VuIEdyb3NzLCBsZSBt YXIuIDEzIGFvw7t0IDIwMjQgMTU6NDE6NTggKzAyMDAsIGEgZWNyaXQ6DQo+Pj4gKyAgICBp ZiAoIHJvLT5jb3VudCA9PSBMMV9QQUdFVEFCTEVfRU5UUklFUyApDQo+Pj4gKyAgICB7DQo+ Pj4gKyAgICAgICAgIHJvLT5jb3VudCA9IDA7DQo+Pj4gKyAgICAgICAgIGlmICggSFlQRVJW SVNPUl9tbXVfdXBkYXRlKG1tdV91cGRhdGVzLCByby0+Y291bnQsIE5VTEwsDQo+Pj4gKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIERPTUlEX1NFTEYpIDwgMCApDQo+ Pg0KPj4gWW91IG5lZWQgdG8gc2V0IHJvLT5jb3VudCAqYWZ0ZXIqIGNhbGxpbmcgbW11X3Vw ZGF0ZS4NCj4gDQo+IEhhcHB5IHRvIG1vdmUgdGhlIGxpbmUgd2hpbGUgY29tbWl0dGluZywg c28gbG9uZyBhcyBKw7xyZ2VuIGFncmVlcy4NCg0KT2ggeWVzLCBvZiBjb3Vyc2UgSSBkby4N Cg0KVGhhbmtzLA0KDQoNCkp1ZXJnZW4NCg== --------------OSoN7QDx5p5VoSJjpDAr9WS2 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------OSoN7QDx5p5VoSJjpDAr9WS2-- --------------hBhs6O40hIWJOFZchOs0wO11-- --------------OQwIt5mfwX76T0mgkJFrSFDr Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmbEldQFAwAAAAAACgkQsN6d1ii/Ey8p zgf/d2JuulLFw2QhJVEm18gWKtiwqOdmK0jxII/lhGdUNZvCJVn//gRk+UnYLuXJfUnWoYw8HDSO /aD6WYm3+5LEU8zIzPZrN4a3neKvTThAhc7JlJ7ue0S4mvveDAKqY8TE77J3LvxTex5AqMUfdxkM ZoFdapo0PGrEgKegVxtlmSflezunb7lepKgVX0T1794BIR3YvsckjJUpZm7VH+77QMKnEJ4LTsxu SRky5tIwt01LU/Qy+DbQ9xMpIVg3w7K4tFZk59t9gNbyRhJPSLbh1QMJscI2MlCQX5IUTSZSWnBQ ij8gkzVu1yHHF7mmPlF54yZu/ILQfC1eWekOOpcGyA== =vUTF -----END PGP SIGNATURE----- --------------OQwIt5mfwX76T0mgkJFrSFDr-- From minios-devel-bounces@lists.xenproject.org Tue Aug 20 14:17:32 2024 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 20 Aug 2024 14:17:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.780486.1190102 (Exim 4.92) (envelope-from ) id 1sgPfv-00056Y-AX; Tue, 20 Aug 2024 14:17:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 780486.1190102; Tue, 20 Aug 2024 14:17:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sgPfv-00055U-7O; Tue, 20 Aug 2024 14:17:31 +0000 Received: by outflank-mailman (input) for mailman id 780486; Tue, 20 Aug 2024 14:17:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sgPft-00052u-Ui for minios-devel@lists.xenproject.org; Tue, 20 Aug 2024 14:17:29 +0000 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [2a00:1450:4864:20::633]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ee0a8733-5efe-11ef-a507-bb4a2ccca743; Tue, 20 Aug 2024 16:17:28 +0200 (CEST) Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-a83869373b6so572565666b.2 for ; Tue, 20 Aug 2024 07:17:28 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8383935636sm765467766b.108.2024.08.20.07.17.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Aug 2024 07:17:27 -0700 (PDT) X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: ee0a8733-5efe-11ef-a507-bb4a2ccca743 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1724163447; x=1724768247; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=xIFu3eXXC6BZWMtQvTcfkJ9FTyBOmbeQdTdtEp0Sch8=; b=cHyT56E3v81oPNBEmkMiUtLE5UQrip47OIPImFRSwI7e5FSpPisRq+v3avlCjmUdNz 4R0XfgpyRKAykQpOqmubHAg0F3VkJ0bXHdNZyzxZybYEJ9WYJoXqamahJF9BM+igPxLB vHJMQ+PW/D32u6Uk8wNsuTIKKPuS+Vo/AKMDKe9QQQ6m8VKeLyULcNo7etgO/0iOiQwh 8lWnKyC/YHkkuhOGrS9Mdt5eg7KO7G0UzqR2yrGR3Vwq8RwW/smoAIThsUE9G8bMVPsn po37Z/V9ZJkxHMC3DpL4J57brJ/Rz5iq9a8r8TWKhVwzn7drznr1qTusV+lmrkWqp2Pt EmZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724163447; x=1724768247; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xIFu3eXXC6BZWMtQvTcfkJ9FTyBOmbeQdTdtEp0Sch8=; b=MDUb0OrEDUd9/BcJarAjQAJtGs4MvSRdfzziomOFafTplU6Ms2dQvfSA/bGzQOjc4i vEkjr6s3yYiLw2yetyX+gxAvMW+nFCCvS5GVanIfpGSsM/2Jz75GCksJUmSzy+CV5g0H Ptyv7qF6Z9xdwOiwYWoyjw4Wu50huvlJjMx7LgaH500Ki6Xx07MSpg5pizEajqBtzSS4 fFChR1HHaBjMEbOmJTVcR7umH53sLpB2QB7LF7dh0UMcUK7mKIxMHZK5Kp/IaYLGb3l4 2ct28IO59yb0p4Ky7O/JMdf37L+hfxyK74KcS07HWT5oZfdly2qKjaZpcNuAG+0apH9j pBuw== X-Gm-Message-State: AOJu0Ywhhtq+qVsIW/shYfhJ0gs0H5jtz8Lu3tFzmwQDgwnLwv5/bNgi r5Anl+WDcdMacfOrLPJlPADduJwMCjFmEA9/bmZ3UK1PrzV5ikuEkMhc5swGZw== X-Google-Smtp-Source: AGHT+IFU4QOgvTusAyGVO9nsb/NTDKNuuPSsoNaSykI7s319YjH2juS6on/uTmstZZRx2aczxHfupA== X-Received: by 2002:a17:907:e663:b0:a72:af8e:15af with SMTP id a640c23a62f3a-a83929f12bcmr1035284266b.49.1724163447406; Tue, 20 Aug 2024 07:17:27 -0700 (PDT) Message-ID: <6e9715ba-7c49-426e-bff4-7569638c0a4b@suse.com> Date: Tue, 20 Aug 2024 16:17:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] mini-os: mm: introduce generic page table walk function To: Samuel Thibault , Juergen Gross References: <20240813134158.580-1-jgross@suse.com> <20240813134158.580-2-jgross@suse.com> <20240820115248.34qg23znyx5qoh37@begin> Content-Language: en-US Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20240820115248.34qg23znyx5qoh37@begin> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 20.08.2024 13:52, Samuel Thibault wrote: > Juergen Gross, le mar. 13 août 2024 15:41:56 +0200, a ecrit: >> In x86 mm code there are multiple instances of page table walks for >> different purposes. >> >> Introduce a generic page table walker being able to cover the current >> use cases. It will be used for other cases in future, too. >> >> The page table walker needs some per-level data, so add a table for >> that data. Merge it with the already existing pt_prot[] array. >> >> Rewrite get_pgt() to use the new walker. >> >> Signed-off-by: Juergen Gross > > Reviewed-by: SAmuel Thibault Samuel - I've taken the liberty to convert the odd upper-case A. Jürgen - looking at the mini-os short-log is quite odd, and increasingly so. In the mini-os repo surely all commits are about mini-os; the subject prefixes are kind of pointless. To nevertheless identify such patches on xen-devel@, may I suggest to use (taking this patch as an example) "[PATCH MINI-OS] mm: introduce generic page table walk function" instead (or, of course, whatever variation thereof you may like better)? Jan From minios-devel-bounces@lists.xenproject.org Tue Aug 20 14:20:34 2024 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 20 Aug 2024 14:20:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.780497.1190122 (Exim 4.92) (envelope-from ) id 1sgPir-0006pW-Q9; Tue, 20 Aug 2024 14:20:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 780497.1190122; Tue, 20 Aug 2024 14:20:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sgPir-0006pP-NF; Tue, 20 Aug 2024 14:20:33 +0000 Received: by outflank-mailman (input) for mailman id 780497; Tue, 20 Aug 2024 14:20:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sgPiq-0006b8-Hz for minios-devel@lists.xenproject.org; Tue, 20 Aug 2024 14:20:32 +0000 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [2a00:1450:4864:20::32c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5a8deffa-5eff-11ef-8776-851b0ebba9a2; Tue, 20 Aug 2024 16:20:30 +0200 (CEST) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-428243f928fso61438205e9.0 for ; Tue, 20 Aug 2024 07:20:30 -0700 (PDT) Received: from ?IPV6:2003:e5:8741:4a00:60e5:7bee:fc48:e85c? (p200300e587414a0060e57beefc48e85c.dip0.t-ipconnect.de. [2003:e5:8741:4a00:60e5:7bee:fc48:e85c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429ed648f55sm143875765e9.3.2024.08.20.07.20.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Aug 2024 07:20:28 -0700 (PDT) X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 5a8deffa-5eff-11ef-8776-851b0ebba9a2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1724163630; x=1724768430; darn=lists.xenproject.org; h=in-reply-to:autocrypt:from:content-language:references:cc:to :subject:user-agent:mime-version:date:message-id:from:to:cc:subject :date:message-id:reply-to; bh=2Il+ux5E/V/afeeGHtzrrXgP0e38W/c5NX5j5utEmh8=; b=OMNu7KvxeS4qAuS32cTvZJ9VWpp+a3nz6z7hQS1ycJTylKxtUj2JjKD5dExTw6iyyN 8GoQdsK5B6PwQyY3IMvR+BbH/1La3LWERx3uHWs8tlSJ1YOke3ZZlAt8tKdWzQThK+QS LASGs9CVWxLXlkN3FGlw7i6r10nd9QgtfGAj1JRJ4DlCv3Twy9aNWMUNgLQ99OgpZQTg /oxbwyVtrMsx3zyAKokWh+JjY0n6i331Tt6vq3lVbeSeijbEzy/6gyb3U6zZqxfaueas zpsFwrsMfhEFXQMnztVHgCeRAZujfV0ttBnSKTVqku9hSAF6nXe79JLHZbrTTEDQ9iTR z9KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724163630; x=1724768430; h=in-reply-to:autocrypt:from:content-language:references:cc:to :subject:user-agent:mime-version:date:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=2Il+ux5E/V/afeeGHtzrrXgP0e38W/c5NX5j5utEmh8=; b=hHcPd2J5fZFn58rV0OxEPddJrylKTXcz8/Ab0PoJJuRTowzsVC3mFHTV8HrrChlRrn nSQAcHKLKd/o3xItyGUtH6BDdURtJHS8kaKl/Inpo+pz4EnWfg1TCyebwr4/RwqlkyWt r6RNo1PEWZO6yBSjsB0e7xLhnbBDAegd8a62XVp5SaAQGkmk4XPpgyIT0kI6iYy6y4dD 2oYkLv6jMCeSarwOpiKPis37tio9SVNd9UqdtmNqiUQcghQKN6+JILc0tNxf9cv3tmcH z207z2/GayKt0OxxvaY6RlsXoA39uwJk9YpFHd4mA8ep6Tb8TuN7dB2+57resTcBkQM9 0zrQ== X-Gm-Message-State: AOJu0YxpDenSKVdXQCPYzxd2B2m7uNNlqEZsRd/WdRKVEIJny0/iSmbp sdgiYBaI3dHaUF5punBDNDWyhgZxPev0e7kIkUP3uAqjzUNNrI9gKf+kuI1elFY= X-Google-Smtp-Source: AGHT+IFP1XPLJH9BZvEF0MNaTKFLkGDZMPI5hwrtY/zjkJKlEf34EaCVVbo43UTOKoImzaGPZJeSdA== X-Received: by 2002:a05:600c:6a84:b0:426:6714:5415 with SMTP id 5b1f17b1804b1-429ed7d6497mr115067685e9.30.1724163629066; Tue, 20 Aug 2024 07:20:29 -0700 (PDT) Message-ID: <89bbbc7b-4fda-4a14-a1a3-1c4b2b708691@suse.com> Date: Tue, 20 Aug 2024 16:20:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] mini-os: mm: introduce generic page table walk function To: Jan Beulich , Samuel Thibault Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org References: <20240813134158.580-1-jgross@suse.com> <20240813134158.580-2-jgross@suse.com> <20240820115248.34qg23znyx5qoh37@begin> <6e9715ba-7c49-426e-bff4-7569638c0a4b@suse.com> Content-Language: en-US From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: <6e9715ba-7c49-426e-bff4-7569638c0a4b@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------T3f1gwaTgc6mWkcrHnc884aY" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------T3f1gwaTgc6mWkcrHnc884aY Content-Type: multipart/mixed; boundary="------------OnYoWn5K2iIAfHc3Bm0JM2UH"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Jan Beulich , Samuel Thibault Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Message-ID: <89bbbc7b-4fda-4a14-a1a3-1c4b2b708691@suse.com> Subject: Re: [PATCH v2 1/3] mini-os: mm: introduce generic page table walk function References: <20240813134158.580-1-jgross@suse.com> <20240813134158.580-2-jgross@suse.com> <20240820115248.34qg23znyx5qoh37@begin> <6e9715ba-7c49-426e-bff4-7569638c0a4b@suse.com> In-Reply-To: <6e9715ba-7c49-426e-bff4-7569638c0a4b@suse.com> Autocrypt-Gossip: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJ3BBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AAIQkQoDSui/t3IH4WIQQ+pJkfkcoLMCa4X6CgNK6L+3cgfgn7AJ9DmMd0SMJE ePbc7/m22D2v04iu7ACffXTdZQhNl557tJuDXZSBxDmW/tLOwU0EWTecRBAIAIK5OMKMU5R2 Lk2bbjgX7vyQuCFFyKf9rC/4itNwhYWFSlKzVj3WJBDsoi2KvPm7AI+XB6NIkNAkshL5C0kd pcNd5Xo0jRR5/WE/bT7LyrJ0OJWS/qUit5eNNvsO+SxGAk28KRa1ieVLeZi9D03NL0+HIAtZ tecfqwgl3Y72UpLUyt+r7LQhcI/XR5IUUaD4C/chB4Vq2QkDKO7Q8+2HJOrFIjiVli4lU+Sf OBp64m//Y1xys++Z4ODoKh7tkh5DxiO3QBHG7bHK0CSQsJ6XUvPVYubAuy1XfSDzSeSBl//C v78Fclb+gi9GWidSTG/4hsEzd1fY5XwCZG/XJJY9M/sAAwUH/09Ar9W2U1Qm+DwZeP2ii3Ou 14Z9VlVVPhcEmR/AFykL9dw/OV2O/7cdi52+l00reUu6Nd4Dl8s4f5n8b1YFzmkVVIyhwjvU jxtPyUgDOt6DRa+RaDlXZZmxQyWcMv2anAgYWGVszeB8Myzsw8y7xhBEVV1S+1KloCzw4V8Z DSJrcsZlyMDoiTb7FyqxwQnM0f6qHxWbmOOnbzJmBqpNpFuDcz/4xNsymJylm6oXiucHQBAP Xb/cE1YNHpuaH4SRhIxwQilCYEznWowQphNAbJtEKOmcocY7EbSt8VjXTzmYENkIfkrHRyXQ dUm5AoL51XZljkCqNwrADGkTvkwsWSvCSQQYEQIACQUCWTecRAIbDAAKCRCgNK6L+3cgfuef AJ9wlZQNQUp0KwEf8Tl37RmcxCL4bQCcC5alCSMzUBJ5DBIcR4BY+CyQFAs= --------------OnYoWn5K2iIAfHc3Bm0JM2UH Content-Type: multipart/mixed; boundary="------------exqA0MCtwvwHdgR5Fmv0pvth" --------------exqA0MCtwvwHdgR5Fmv0pvth Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjAuMDguMjQgMTY6MTcsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyMC4wOC4yMDI0 IDEzOjUyLCBTYW11ZWwgVGhpYmF1bHQgd3JvdGU6DQo+PiBKdWVyZ2VuIEdyb3NzLCBsZSBt YXIuIDEzIGFvw7t0IDIwMjQgMTU6NDE6NTYgKzAyMDAsIGEgZWNyaXQ6DQo+Pj4gSW4geDg2 IG1tIGNvZGUgdGhlcmUgYXJlIG11bHRpcGxlIGluc3RhbmNlcyBvZiBwYWdlIHRhYmxlIHdh bGtzIGZvcg0KPj4+IGRpZmZlcmVudCBwdXJwb3Nlcy4NCj4+Pg0KPj4+IEludHJvZHVjZSBh IGdlbmVyaWMgcGFnZSB0YWJsZSB3YWxrZXIgYmVpbmcgYWJsZSB0byBjb3ZlciB0aGUgY3Vy cmVudA0KPj4+IHVzZSBjYXNlcy4gSXQgd2lsbCBiZSB1c2VkIGZvciBvdGhlciBjYXNlcyBp biBmdXR1cmUsIHRvby4NCj4+Pg0KPj4+IFRoZSBwYWdlIHRhYmxlIHdhbGtlciBuZWVkcyBz b21lIHBlci1sZXZlbCBkYXRhLCBzbyBhZGQgYSB0YWJsZSBmb3INCj4+PiB0aGF0IGRhdGEu IE1lcmdlIGl0IHdpdGggdGhlIGFscmVhZHkgZXhpc3RpbmcgcHRfcHJvdFtdIGFycmF5Lg0K Pj4+DQo+Pj4gUmV3cml0ZSBnZXRfcGd0KCkgdG8gdXNlIHRoZSBuZXcgd2Fsa2VyLg0KPj4+ DQo+Pj4gU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0K Pj4NCj4+IFJldmlld2VkLWJ5OiBTQW11ZWwgVGhpYmF1bHQgPHNhbXVlbC50aGliYXVsdEBl bnMtbHlvbi5vcmc+DQo+IA0KPiBTYW11ZWwgLSBJJ3ZlIHRha2VuIHRoZSBsaWJlcnR5IHRv IGNvbnZlcnQgdGhlIG9kZCB1cHBlci1jYXNlIEEuDQo+IA0KPiBKw7xyZ2VuIC0gbG9va2lu ZyBhdCB0aGUgbWluaS1vcyBzaG9ydC1sb2cgaXMgcXVpdGUgb2RkLCBhbmQgaW5jcmVhc2lu Z2x5DQo+IHNvLiBJbiB0aGUgbWluaS1vcyByZXBvIHN1cmVseSBhbGwgY29tbWl0cyBhcmUg YWJvdXQgbWluaS1vczsgdGhlDQo+IHN1YmplY3QgcHJlZml4ZXMgYXJlIGtpbmQgb2YgcG9p bnRsZXNzLiBUbyBuZXZlcnRoZWxlc3MgaWRlbnRpZnkgc3VjaA0KPiBwYXRjaGVzIG9uIHhl bi1kZXZlbEAsIG1heSBJIHN1Z2dlc3QgdG8gdXNlICh0YWtpbmcgdGhpcyBwYXRjaCBhcyBh bg0KPiBleGFtcGxlKSAiW1BBVENIIE1JTkktT1NdIG1tOiBpbnRyb2R1Y2UgZ2VuZXJpYyBw YWdlIHRhYmxlIHdhbGsgZnVuY3Rpb24iDQo+IGluc3RlYWQgKG9yLCBvZiBjb3Vyc2UsIHdo YXRldmVyIHZhcmlhdGlvbiB0aGVyZW9mIHlvdSBtYXkgbGlrZSBiZXR0ZXIpPw0KDQpPa2F5 LCBmaW5lIHdpdGggbWUuDQoNCg0KSnVlcmdlbg0KDQo= --------------exqA0MCtwvwHdgR5Fmv0pvth Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------exqA0MCtwvwHdgR5Fmv0pvth-- --------------OnYoWn5K2iIAfHc3Bm0JM2UH-- --------------T3f1gwaTgc6mWkcrHnc884aY Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmbEpisFAwAAAAAACgkQsN6d1ii/Ey9g FQf/cos49PwJfKBuHZAaKejlt9TYDDpsJbCEfOVuCOlPZBBIL2yi9Pw70/bZSYBJJxbX1/x/iNgm LzIcUM73yP6gT1vKS94E1O/15jKLYHPxFgJibLqldcRV47HnXi3O563EuQUzdQMs3FhHkl5WgOAn pYWnZgTW3gBaZUK7y9z4Y3+OUsk1XZtAT0bQ9eUMVJOlkt+iVmBYZOh4+XIIEFNsqQ//adgkos9u 4ojnkMCKjyZNMjZutOr7/oqcvSEiFqn3laSHRE1jBfGJt7pT84/PmjpcS5snmQUOXOcHv6Yr6zQ3 ImIML77Vkod81jVBIXHaVuEuPY8fawuOE/uJiUjobA== =adaS -----END PGP SIGNATURE----- --------------T3f1gwaTgc6mWkcrHnc884aY-- From minios-devel-bounces@lists.xenproject.org Tue Aug 20 14:20:50 2024 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 20 Aug 2024 14:20:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.780503.1190126 (Exim 4.92) (envelope-from ) id 1sgPj8-00071F-TQ; Tue, 20 Aug 2024 14:20:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 780503.1190126; Tue, 20 Aug 2024 14:20:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sgPj8-000716-QL; Tue, 20 Aug 2024 14:20:50 +0000 Received: by outflank-mailman (input) for mailman id 780503; Tue, 20 Aug 2024 14:20:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sgPj8-0006b2-7G for minios-devel@lists.xenproject.org; Tue, 20 Aug 2024 14:20:50 +0000 Received: from sonata.ens-lyon.org (sonata.ens-lyon.org [140.77.166.138]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 65e1ffad-5eff-11ef-a507-bb4a2ccca743; Tue, 20 Aug 2024 16:20:49 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id E13FDA03B3; Tue, 20 Aug 2024 16:20:48 +0200 (CEST) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dKIHqWii6n_r; Tue, 20 Aug 2024 16:20:48 +0200 (CEST) Received: from begin (nat-inria-interne-52-gw-01-bso.bordeaux.inria.fr [194.199.1.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id AF42CA03B1; Tue, 20 Aug 2024 16:20:48 +0200 (CEST) Received: from samy by begin with local (Exim 4.98) (envelope-from ) id 1sgPj6-00000000UFy-1Xn6; Tue, 20 Aug 2024 16:20:48 +0200 X-BeenThere: minios-devel@lists.xenproject.org List-Id: Mini-os development list List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: minios-devel-bounces@lists.xenproject.org Precedence: list Sender: "Minios-devel" X-Inumbo-ID: 65e1ffad-5eff-11ef-a507-bb4a2ccca743 Date: Tue, 20 Aug 2024 16:20:48 +0200 From: Samuel Thibault To: Jan Beulich Cc: Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH v2 1/3] mini-os: mm: introduce generic page table walk function Message-ID: <20240820142048.27m346n5xzj5fi43@begin> Mail-Followup-To: Samuel Thibault , Jan Beulich , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org References: <20240813134158.580-1-jgross@suse.com> <20240813134158.580-2-jgross@suse.com> <20240820115248.34qg23znyx5qoh37@begin> <6e9715ba-7c49-426e-bff4-7569638c0a4b@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6e9715ba-7c49-426e-bff4-7569638c0a4b@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Jan Beulich, le mar. 20 août 2024 16:17:26 +0200, a ecrit: > On 20.08.2024 13:52, Samuel Thibault wrote: > > Juergen Gross, le mar. 13 août 2024 15:41:56 +0200, a ecrit: > >> In x86 mm code there are multiple instances of page table walks for > >> different purposes. > >> > >> Introduce a generic page table walker being able to cover the current > >> use cases. It will be used for other cases in future, too. > >> > >> The page table walker needs some per-level data, so add a table for > >> that data. Merge it with the already existing pt_prot[] array. > >> > >> Rewrite get_pgt() to use the new walker. > >> > >> Signed-off-by: Juergen Gross > > > > Reviewed-by: SAmuel Thibault > > Samuel - I've taken the liberty to convert the odd upper-case A. Oh, sure, thanks :) Samuel