From win-pv-devel-bounces@lists.xenproject.org Thu Nov 07 15:53:48 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 07 Nov 2019 15:53:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iSk6U-0001vC-NX; Thu, 07 Nov 2019 15:53:46 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iSk6U-0001v7-8V for win-pv-devel@lists.xenproject.org; Thu, 07 Nov 2019 15:53:46 +0000 X-Inumbo-ID: c74905d6-0176-11ea-b678-bc764e2007e4 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c74905d6-0176-11ea-b678-bc764e2007e4; Thu, 07 Nov 2019 15:53:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1573142025; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=ppPPUZxEwhhLbuoAbbfHD+Qpjqg/D0hz+YW9ZEXzMSg=; b=Qh+iFQdDl8XFzJm0kvX9IUwfjTpQEVvbu3/7nbylUmRz8iNKjhbw62Kk A+lqCX0vtsHNeNGqGMOB/wEwkJ94KRi1l920lO0wAO4Q6/LUThvqE0M35 LJtFgSe2AxPjHyf24HPYJI2VV8cVv1Hnq92N4wgVmNfEfcy6xT2enD2td 8=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=owen.smith@citrix.com; spf=Pass smtp.mailfrom=owen.smith@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of owen.smith@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="owen.smith@citrix.com"; x-sender="owen.smith@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of owen.smith@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="owen.smith@citrix.com"; x-sender="owen.smith@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="owen.smith@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: /X+79eY5HpskRw/fUNHZ1up0Zvb+ACy9iTLlbGaJyHsA/Q86tauPRR6V9BW6aSV9OjXYzmEbId 6QipM2Z2ou6kqY17s/ldEPGuE5aw7dwaDuJNN/v5c+m09MBiTYay5BKhfE3+8ngZMfGjR/YZp0 EaO8NNLBCexgUioqmprbVV08Cyy0uiVUZufIXl/NlZzk2oHSggXkDqWAGY3YLef83jd8VpmUdq EFHPxnI4JvckLYDdt6QsVXLAdVQliERHy6CaSw7Qlolx+6xXAD2IMjJZ/CDuK6Qipq4BTxK3IF N0k= X-SBRS: 2.7 X-MesageID: 8001765 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.68,278,1569297600"; d="scan'208";a="8001765" From: Owen Smith To: Date: Thu, 7 Nov 2019 15:53:16 +0000 Message-ID: <20191107155318.4864-2-owen.smith@citrix.com> X-Mailer: git-send-email 2.16.2.windows.1 In-Reply-To: <20191107155318.4864-1-owen.smith@citrix.com> References: <20191107155318.4864-1-owen.smith@citrix.com> MIME-Version: 1.0 Subject: [win-pv-devel] [PATCH 2/4] Add option to elevate administrator users X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Owen Smith Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" SWYgdGhlIHVzZXIgaGFzIEFkbWluaXN0cmF0b3IgYWNjZXNzLCBhZGQgYSBwcm9tcHQgYW5kIGFi aWxpdHkgdG8KZWxldmF0ZSB0aGUgYWNjZXNzIHRvIHRoZSBBZG1pbmlzdHJhdG9yIHByaXZpbGVn ZSBsZXZlbCBpbnN0ZWFkIG9mCnJldGFpbmluZyB0aGUgdXNlciBwcml2aWxlZ2UgbGV2ZWwuCgpT aWduZWQtb2ZmLWJ5OiBPd2VuIFNtaXRoIDxvd2VuLnNtaXRoQGNpdHJpeC5jb20+Ci0tLQogc3Jj L3R0eS90dHkuYyB8IDY4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgNjggaW5zZXJ0aW9ucygrKQoKZGlm ZiAtLWdpdCBhL3NyYy90dHkvdHR5LmMgYi9zcmMvdHR5L3R0eS5jCmluZGV4IDAzNWYxOGMuLmUy OTVmMDYgMTAwNjQ0Ci0tLSBhL3NyYy90dHkvdHR5LmMKKysrIGIvc3JjL3R0eS90dHkuYwpAQCAt NTIsNiArNTIsNyBAQCB0eXBlZGVmIHN0cnVjdCBfVFRZX0NPTlRFWFQgewogICAgIFRUWV9TVFJF QU0gICAgICAgICAgRGV2aWNlOwogICAgIFRDSEFSICAgICAgICAgICAgICAgVXNlck5hbWVbTUFY SU1VTV9CVUZGRVJfU0laRV07CiAgICAgSEFORExFICAgICAgICAgICAgICBUb2tlbjsKKyAgICBI QU5ETEUgICAgICAgICAgICAgIE9yaWdpbmFsVG9rZW47CiAgICAgUFJPQ0VTU19JTkZPUk1BVElP TiBQcm9jZXNzSW5mbzsKIH0gVFRZX0NPTlRFWFQsICpQVFRZX0NPTlRFWFQ7CiAKQEAgLTM0OSw2 ICszNTAsNjkgQEAgR2V0Q3JlZGVudGlhbHMoCiAgICAgcmV0dXJuIFRSVUU7CiB9CiAKK3N0YXRp YyBCT09MCitSZXF1ZXN0RWxldmF0aW9uKAorICAgIFZPSUQKKyAgICApCit7CisgICAgUFRUWV9D T05URVhUICAgICAgICAgICAgQ29udGV4dCA9ICZUdHlDb250ZXh0OworICAgIFRPS0VOX0VMRVZB VElPTl9UWVBFICAgIEVsZXZhdGlvbjsKKyAgICBEV09SRCAgICAgICAgICAgICAgICAgICBTaXpl OworICAgIFRDSEFSICAgICAgICAgICAgICAgICAgIEJ1ZmZlcltNQVhJTVVNX0JVRkZFUl9TSVpF XTsKKyAgICBQVENIQVIgICAgICAgICAgICAgICAgICBFbmQ7CisgICAgVE9LRU5fTElOS0VEX1RP S0VOICAgICAgTGlua2VkVG9rZW47CisgICAgQk9PTCAgICAgICAgICAgICAgICAgICAgU3VjY2Vz czsKKworICAgIFN1Y2Nlc3MgPSBHZXRUb2tlbkluZm9ybWF0aW9uKENvbnRleHQtPlRva2VuLAor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFRva2VuRWxldmF0aW9uVHlwZSwKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAmRWxldmF0aW9uLAorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHNpemVvZihFbGV2YXRpb24pLAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICZTaXplKTsKKyAgICBpZiAoIVN1Y2Nlc3MpCisgICAgICAgIHJl dHVybiBUUlVFOworCisgICAgaWYgKEVsZXZhdGlvbiAhPSBUb2tlbkVsZXZhdGlvblR5cGVMaW1p dGVkKQorICAgICAgICByZXR1cm4gVFJVRTsKKworICAgIEVDSE8oJkNvbnRleHQtPkRldmljZSwg IlxyXG4iKTsKKyAgICBFQ0hPKCZDb250ZXh0LT5EZXZpY2UsICIgcnVuIGFzIEFkbWluaXN0cmF0 b3IgW3llc3xub106ICIpOworCisgICAgWmVyb01lbW9yeShCdWZmZXIsIHNpemVvZiAoQnVmZmVy KSk7CisKKyAgICBTdWNjZXNzID0gR2V0TGluZSgmQ29udGV4dC0+RGV2aWNlLAorICAgICAgICAg ICAgICAgICAgICAgIEJ1ZmZlciwKKyAgICAgICAgICAgICAgICAgICAgICBzaXplb2YgKEJ1ZmZl ciksCisgICAgICAgICAgICAgICAgICAgICAgJlNpemUsCisgICAgICAgICAgICAgICAgICAgICAg RkFMU0UpOworICAgIGlmICghU3VjY2VzcykKKyAgICAgICAgcmV0dXJuIEZBTFNFOworCisgICAg RW5kID0gX3Rjc2NocihCdWZmZXIsIFRFWFQoJ1xyJykpOworICAgIGlmIChFbmQgPT0gTlVMTCkK KyAgICAgICAgcmV0dXJuIEZBTFNFOworCisgICAgKkVuZCA9IFRFWFQoJ1wwJyk7CisKKyAgICBp ZiAoX3Rjc2xlbihCdWZmZXIpID09IDApCisgICAgICAgIHJldHVybiBGQUxTRTsKKworICAgIGlm IChfdGNzY21wKEJ1ZmZlciwgVEVYVCgieWVzIikpICE9IDApCisgICAgICAgIHJldHVybiBUUlVF OworCisgICAgU3VjY2VzcyA9IEdldFRva2VuSW5mb3JtYXRpb24oQ29udGV4dC0+VG9rZW4sCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgVG9rZW5MaW5rZWRUb2tlbiwKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAmTGlua2VkVG9rZW4sCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgc2l6ZW9mKExpbmtlZFRva2VuKSwKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAmU2l6ZSk7CisgICAgaWYgKCFTdWNjZXNzKQorICAgICAgICBy ZXR1cm4gRkFMU0U7CisKKyAgICBDb250ZXh0LT5PcmlnaW5hbFRva2VuID0gQ29udGV4dC0+VG9r ZW47CisgICAgQ29udGV4dC0+VG9rZW4gPSBMaW5rZWRUb2tlbi5MaW5rZWRUb2tlbjsKKworICAg IHJldHVybiBUUlVFOworfQorCiBzdGF0aWMgRFdPUkQgV0lOQVBJCiBUdHlJbigKICAgICBJTiAg TFBWT0lEICAgICAgQXJndW1lbnQKQEAgLTQ5OCw2ICs1NjIsMTAgQEAgX3RtYWluKAogCiAgICAg WmVyb01lbW9yeShQYXNzd29yZCwgc2l6ZW9mKFBhc3N3b3JkKSk7CiAKKyAgICBpZiAoIVN1Y2Nl c3MpCisgICAgICAgIEV4aXRQcm9jZXNzKDEpOworCisgICAgU3VjY2VzcyA9IFJlcXVlc3RFbGV2 YXRpb24oKTsKICAgICBpZiAoIVN1Y2Nlc3MpCiAgICAgICAgIEV4aXRQcm9jZXNzKDEpOwogCi0t IAoyLjE2LjIud2luZG93cy4xCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18Kd2luLXB2LWRldmVsIG1haWxpbmcgbGlzdAp3aW4tcHYtZGV2ZWxAbGlzdHMu eGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3Rp bmZvL3dpbi1wdi1kZXZlbA== From win-pv-devel-bounces@lists.xenproject.org Thu Nov 07 15:53:49 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 07 Nov 2019 15:53:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iSk6X-0001vi-Pe; Thu, 07 Nov 2019 15:53:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iSk6X-0001vX-8Q for win-pv-devel@lists.xenproject.org; Thu, 07 Nov 2019 15:53:49 +0000 X-Inumbo-ID: c7fbdb0c-0176-11ea-b678-bc764e2007e4 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c7fbdb0c-0176-11ea-b678-bc764e2007e4; Thu, 07 Nov 2019 15:53:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1573142026; h=from:to:cc:subject:date:message-id:mime-version; bh=tAYOVxR5R3empMSex6ctQB8w9f+NTS3rnzYFIuou4DA=; b=HSqb34z6zPEhRQ1X0WkSWtCtLv9l/N4zUJC5nHOwLIN1ssE1v96zcyEx uYBE1vkWIQ5wwisDefHmRYjTlL7CbPoAM655jJzZ+aTXzM6DcxZ/HvDs1 8XFRLT5y/pV6ymkw90RBxiunAkB0BK4L6/AAU2Vtjw6HOX6HOVFE47Bqt M=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=owen.smith@citrix.com; spf=Pass smtp.mailfrom=owen.smith@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of owen.smith@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="owen.smith@citrix.com"; x-sender="owen.smith@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of owen.smith@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="owen.smith@citrix.com"; x-sender="owen.smith@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="owen.smith@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: vdYkopOahcNU7Pr9k4nT17ofOlYEQ/xCAmBdQTWe5RQP+Oy0U0bymWvrZwK5fmd2J6W/Uz0DAE XtW52M+9/nQtWEkFFCLRSWP2L154NNIkhjfie0WuV5jIK8IkqZs3xHbp4IEt1j25Tb1nu7XK8T G/PIeC+g0obNHWuYFYmw51MtPyqLURC99vwJfkX3pRrosJAxQyX1NcS433cxGU3WokqIDgaaa2 ETrsrR3+eYkPy8sS0CrdKBj54kNWUodtQ1IlYv9wUHRfoUScrTPCjcJmZtsSynbGm33MPINUSe Yz8= X-SBRS: 2.7 X-MesageID: 8001767 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.68,278,1569297600"; d="scan'208";a="8001767" From: Owen Smith To: Date: Thu, 7 Nov 2019 15:53:15 +0000 Message-ID: <20191107155318.4864-1-owen.smith@citrix.com> X-Mailer: git-send-email 2.16.2.windows.1 MIME-Version: 1.0 Subject: [win-pv-devel] [PATCH 1/4] Don't store password longer than required X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Owen Smith Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" U2lnbmVkLW9mZi1ieTogT3dlbiBTbWl0aCA8b3dlbi5zbWl0aEBjaXRyaXguY29tPgotLS0KIHNy Yy90dHkvdHR5LmMgfCAyMCArKysrKysrKysrKystLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDEy IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL3R0eS90dHku YyBiL3NyYy90dHkvdHR5LmMKaW5kZXggNmUzNDBhYi4uMDM1ZjE4YyAxMDA2NDQKLS0tIGEvc3Jj L3R0eS90dHkuYworKysgYi9zcmMvdHR5L3R0eS5jCkBAIC01MSw3ICs1MSw2IEBAIHR5cGVkZWYg c3RydWN0IF9UVFlfQ09OVEVYVCB7CiAgICAgVFRZX1NUUkVBTSAgICAgICAgICBDaGlsZFN0ZE91 dDsKICAgICBUVFlfU1RSRUFNICAgICAgICAgIERldmljZTsKICAgICBUQ0hBUiAgICAgICAgICAg ICAgIFVzZXJOYW1lW01BWElNVU1fQlVGRkVSX1NJWkVdOwotICAgIFRDSEFSICAgICAgICAgICAg ICAgUGFzc3dvcmRbTUFYSU1VTV9CVUZGRVJfU0laRV07CiAgICAgSEFORExFICAgICAgICAgICAg ICBUb2tlbjsKICAgICBQUk9DRVNTX0lORk9STUFUSU9OIFByb2Nlc3NJbmZvOwogfSBUVFlfQ09O VEVYVCwgKlBUVFlfQ09OVEVYVDsKQEAgLTI4OSw3ICsyODgsOCBAQCBHZXRMaW5lKAogCiBzdGF0 aWMgQk9PTAogR2V0Q3JlZGVudGlhbHMoCi0gICAgVk9JRAorICAgIElOICBQVENIQVIgICAgICBQ YXNzd29yZCwKKyAgICBJTiAgRFdPUkQgICAgICAgUGFzc3dvcmRTaXplCiAgICAgKQogewogICAg IFBUVFlfQ09OVEVYVCAgICBDb250ZXh0ID0gJlR0eUNvbnRleHQ7CkBAIC0zMzAsMTcgKzMzMCwx NyBAQCBHZXRDcmVkZW50aWFscygKIAogICAgIEVDSE8oJkNvbnRleHQtPkRldmljZSwgIlBhc3N3 b3JkOiAiKTsKIAotICAgIFplcm9NZW1vcnkoQ29udGV4dC0+UGFzc3dvcmQsIHNpemVvZiAoQ29u dGV4dC0+UGFzc3dvcmQpKTsKKyAgICBaZXJvTWVtb3J5KFBhc3N3b3JkLCBQYXNzd29yZFNpemUp OwogCiAgICAgU3VjY2VzcyA9IEdldExpbmUoJkNvbnRleHQtPkRldmljZSwKLSAgICAgICAgICAg ICAgICAgICAgICBDb250ZXh0LT5QYXNzd29yZCwKLSAgICAgICAgICAgICAgICAgICAgICBzaXpl b2YgKENvbnRleHQtPlBhc3N3b3JkKSwKKyAgICAgICAgICAgICAgICAgICAgICBQYXNzd29yZCwK KyAgICAgICAgICAgICAgICAgICAgICBQYXNzd29yZFNpemUsCiAgICAgICAgICAgICAgICAgICAg ICAgJlNpemUsCiAgICAgICAgICAgICAgICAgICAgICAgVFJVRSk7CiAgICAgaWYgKCFTdWNjZXNz KQogICAgICAgICByZXR1cm4gRkFMU0U7CiAKLSAgICBFbmQgPSBfdGNzY2hyKENvbnRleHQtPlBh c3N3b3JkLCBURVhUKCdccicpKTsKKyAgICBFbmQgPSBfdGNzY2hyKFBhc3N3b3JkLCBURVhUKCdc cicpKTsKICAgICBpZiAoRW5kID09IE5VTEwpCiAgICAgICAgIHJldHVybiBGQUxTRTsKIApAQCAt NDQ4LDYgKzQ0OCw3IEBAIF90bWFpbigKICAgICBQVFRZX0NPTlRFWFQgICAgICAgIENvbnRleHQg PSAmVHR5Q29udGV4dDsKICAgICBTRUNVUklUWV9BVFRSSUJVVEVTIEF0dHJpYnV0ZXM7CiAgICAg SEFORExFICAgICAgICAgICAgICBIYW5kbGVbM107CisgICAgVENIQVIgICAgICAgICAgICAgICBQ YXNzd29yZFtNQVhJTVVNX0JVRkZFUl9TSVpFXTsKICAgICBEV09SRCAgICAgICAgICAgICAgIElu ZGV4OwogICAgIEJPT0wgICAgICAgICAgICAgICAgU3VjY2VzczsKIApAQCAtNDg0LDE2ICs0ODUs MTkgQEAgX3RtYWluKAogICAgIGlmIChDb250ZXh0LT5EZXZpY2UuV3JpdGUgPT0gSU5WQUxJRF9I QU5ETEVfVkFMVUUpCiAgICAgICAgIEV4aXRQcm9jZXNzKDEpOwogCi0gICAgU3VjY2VzcyA9IEdl dENyZWRlbnRpYWxzKCk7CisgICAgU3VjY2VzcyA9IEdldENyZWRlbnRpYWxzKFBhc3N3b3JkLCBz aXplb2YoUGFzc3dvcmQpKTsKICAgICBpZiAoIVN1Y2Nlc3MpCiAgICAgICAgIEV4aXRQcm9jZXNz KDEpOwogCiAgICAgU3VjY2VzcyA9IExvZ29uVXNlcihDb250ZXh0LT5Vc2VyTmFtZSwKICAgICAg ICAgICAgICAgICAgICAgICAgIE5VTEwsCi0gICAgICAgICAgICAgICAgICAgICAgICBDb250ZXh0 LT5QYXNzd29yZCwKKyAgICAgICAgICAgICAgICAgICAgICAgIFBhc3N3b3JkLAogICAgICAgICAg ICAgICAgICAgICAgICAgTE9HT04zMl9MT0dPTl9JTlRFUkFDVElWRSwKICAgICAgICAgICAgICAg ICAgICAgICAgIExPR09OMzJfUFJPVklERVJfREVGQVVMVCwKICAgICAgICAgICAgICAgICAgICAg ICAgICZDb250ZXh0LT5Ub2tlbik7CisKKyAgICBaZXJvTWVtb3J5KFBhc3N3b3JkLCBzaXplb2Yo UGFzc3dvcmQpKTsKKwogICAgIGlmICghU3VjY2VzcykKICAgICAgICAgRXhpdFByb2Nlc3MoMSk7 CiAKLS0gCjIuMTYuMi53aW5kb3dzLjEKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwp3aW4tcHYtZGV2ZWwgbWFpbGluZyBsaXN0Cndpbi1wdi1kZXZlbEBs aXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4v bGlzdGluZm8vd2luLXB2LWRldmVs From win-pv-devel-bounces@lists.xenproject.org Thu Nov 07 15:53:54 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 07 Nov 2019 15:53:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iSk6c-0001wT-Rb; Thu, 07 Nov 2019 15:53:54 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iSk6c-0001wJ-8b for win-pv-devel@lists.xenproject.org; Thu, 07 Nov 2019 15:53:54 +0000 X-Inumbo-ID: c805aa42-0176-11ea-9631-bc764e2007e4 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c805aa42-0176-11ea-9631-bc764e2007e4; Thu, 07 Nov 2019 15:53:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1573142026; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=xOYz3I+ODkQNcpfXQzZjcDNjIFJCK9YMkRu0NynJ0L0=; b=C4i78iHVEvP5XAc5m+vOA5zWzVU2vtwEezEDdFeMc9+KApCRUgCvNGKg Yg0RzGF/8C3LD4knkvBDiMgZqoS8niUjAWmKiHvJdRO8FtF80t5QBFL5D bgPswt237GlP2SAZWJHDeyI5aegyyQDWsovpEExTK3LwGWc7sdaIq57P4 E=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=owen.smith@citrix.com; spf=Pass smtp.mailfrom=owen.smith@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of owen.smith@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="owen.smith@citrix.com"; x-sender="owen.smith@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of owen.smith@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="owen.smith@citrix.com"; x-sender="owen.smith@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="owen.smith@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: cw7PuUBcx3hJEsC4T3LHxmGSUn3EadghliB8V/V/a4DLuehDHe13jgWg7eYjnSIBQWCM8j+S63 xQnJf/NdLFWeEC+hz9Ga7p66VPyCN25zUJExWXY2PprkE8Is/YN2WM8Nr8OIJcEMVu57GAMJpn GOPEAGmuPkUgG9TX04Coy1yF1yTN33OMiUIoidO4tzvLkdA6Cn81nIxgi+nd0n0VR/2wxroYIg xgSXfC+TU8cHSGJ1mnprb5Rx28tkiE84+fhKhiKEX7Yj25EKIFUxv/r5ZAW/6sUWqNyC4JHKKc H00= X-SBRS: 2.7 X-MesageID: 8001768 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.68,278,1569297600"; d="scan'208";a="8001768" From: Owen Smith To: Date: Thu, 7 Nov 2019 15:53:18 +0000 Message-ID: <20191107155318.4864-4-owen.smith@citrix.com> X-Mailer: git-send-email 2.16.2.windows.1 In-Reply-To: <20191107155318.4864-1-owen.smith@citrix.com> References: <20191107155318.4864-1-owen.smith@citrix.com> MIME-Version: 1.0 Subject: [win-pv-devel] [PATCH 4/4] Make sure input buffers are always null-terminated X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Owen Smith Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" U2lnbmVkLW9mZi1ieTogT3dlbiBTbWl0aCA8b3dlbi5zbWl0aEBjaXRyaXguY29tPgotLS0KIHNy Yy90dHkvdHR5LmMgfCA2ICsrKysrKwogMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKQoK ZGlmZiAtLWdpdCBhL3NyYy90dHkvdHR5LmMgYi9zcmMvdHR5L3R0eS5jCmluZGV4IGMzZGZjZjku LmNiMTM3OGQgMTAwNjQ0Ci0tLSBhL3NyYy90dHkvdHR5LmMKKysrIGIvc3JjL3R0eS90dHkuYwpA QCAtMzE3LDYgKzMxNyw4IEBAIEdldENyZWRlbnRpYWxzKAogICAgICAgICAgICAgICAgICAgICAg IHNpemVvZiAoQ29udGV4dC0+VXNlck5hbWUpLAogICAgICAgICAgICAgICAgICAgICAgICZTaXpl LAogICAgICAgICAgICAgICAgICAgICAgIEZBTFNFKTsKKyAgICBDb250ZXh0LT5Vc2VyTmFtZVtN QVhJTVVNX0JVRkZFUl9TSVpFIC0gMV0gPSBURVhUKCdcMCcpOworCiAgICAgaWYgKCFTdWNjZXNz KQogICAgICAgICByZXR1cm4gRkFMU0U7CiAKQEAgLTMzOCw2ICszNDAsOCBAQCBHZXRDcmVkZW50 aWFscygKICAgICAgICAgICAgICAgICAgICAgICBQYXNzd29yZFNpemUsCiAgICAgICAgICAgICAg ICAgICAgICAgJlNpemUsCiAgICAgICAgICAgICAgICAgICAgICAgVFJVRSk7CisgICAgUGFzc3dv cmRbKFBhc3N3b3JkU2l6ZSAvIHNpemVvZihUQ0hBUikpIC0gMV0gPSBURVhUKCdcMCcpOworCiAg ICAgaWYgKCFTdWNjZXNzKQogICAgICAgICByZXR1cm4gRkFMU0U7CiAKQEAgLTM4NCw2ICszODgs OCBAQCBSZXF1ZXN0RWxldmF0aW9uKAogICAgICAgICAgICAgICAgICAgICAgIHNpemVvZiAoQnVm ZmVyKSwKICAgICAgICAgICAgICAgICAgICAgICAmU2l6ZSwKICAgICAgICAgICAgICAgICAgICAg ICBGQUxTRSk7CisgICAgQnVmZmVyW01BWElNVU1fQlVGRkVSX1NJWkUgLSAxXSA9IFRFWFQoJ1ww Jyk7CisKICAgICBpZiAoIVN1Y2Nlc3MpCiAgICAgICAgIHJldHVybiBGQUxTRTsKIAotLSAKMi4x Ni4yLndpbmRvd3MuMQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCndpbi1wdi1kZXZlbCBtYWlsaW5nIGxpc3QKd2luLXB2LWRldmVsQGxpc3RzLnhlbnBy b2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby93 aW4tcHYtZGV2ZWw= From win-pv-devel-bounces@lists.xenproject.org Thu Nov 07 15:53:59 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 07 Nov 2019 15:53:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iSk6h-0001xB-TR; Thu, 07 Nov 2019 15:53:59 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iSk6h-0001x1-9Q for win-pv-devel@lists.xenproject.org; Thu, 07 Nov 2019 15:53:59 +0000 X-Inumbo-ID: c8589a90-0176-11ea-b678-bc764e2007e4 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c8589a90-0176-11ea-b678-bc764e2007e4; Thu, 07 Nov 2019 15:53:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1573142027; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=zSefeNRTCNfD9mRrhDqSTfnPUwn7vFvPWOX6z+u/Y6A=; b=a33h+NAiO23GlFFIUDkVcZ/K3p9zUAhQHa5AM3qKsMmVMHf06g/2QKR1 QSrKo6XK6vRjYYhkPfCC90MvrDR0CfQdMGKC8aoSBEicErOtai/iL/JYk EP8kEmNL8bmfv0TE8VtIxp3gnfu1Cwzmreif/oCbfOpPLHzsVest4sf1E k=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=owen.smith@citrix.com; spf=Pass smtp.mailfrom=owen.smith@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of owen.smith@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="owen.smith@citrix.com"; x-sender="owen.smith@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of owen.smith@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="owen.smith@citrix.com"; x-sender="owen.smith@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="owen.smith@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: UsVT1cpphv5BHtB9H9kNhCTzGt3N5RNleqIrp9rBdOo+1iBpcGd8GUNwYNnKPUKrrg+jct4zrj 0kVe9WOzwHE9ydpMma5PbEU2cI0a57levevI17KnJautJ+Paj2n8/8/zKQBB9lydYvlfg7UpBf o5qNBxgsj+GdiaNc5Z6/65F+lVYk7pySml+Oj8bBnOOKkDxMNlDyKEZ9ONrXOATUk2O2zt42sR iXTI8HsYGW9P50t9U26s4Wsk6byGvvqg7VeHte7MEuxThnqCoN2gyjbTtmA+NdaXijVaYCOMG+ h98= X-SBRS: 2.7 X-MesageID: 8001769 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.68,278,1569297600"; d="scan'208";a="8001769" From: Owen Smith To: Date: Thu, 7 Nov 2019 15:53:17 +0000 Message-ID: <20191107155318.4864-3-owen.smith@citrix.com> X-Mailer: git-send-email 2.16.2.windows.1 In-Reply-To: <20191107155318.4864-1-owen.smith@citrix.com> References: <20191107155318.4864-1-owen.smith@citrix.com> MIME-Version: 1.0 Subject: [win-pv-devel] [PATCH 3/4] Improve elevation prompts X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Owen Smith Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" U2lnbmVkLW9mZi1ieTogT3dlbiBTbWl0aCA8b3dlbi5zbWl0aEBjaXRyaXguY29tPgotLS0KIHNy Yy90dHkvdHR5LmMgfCA2ICsrKysrLQogMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwg MSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL3NyYy90dHkvdHR5LmMgYi9zcmMvdHR5L3R0eS5j CmluZGV4IGUyOTVmMDYuLmMzZGZjZjkgMTAwNjQ0Ci0tLSBhL3NyYy90dHkvdHR5LmMKKysrIGIv c3JjL3R0eS90dHkuYwpAQCAtMzc1LDcgKzM3NSw3IEBAIFJlcXVlc3RFbGV2YXRpb24oCiAgICAg ICAgIHJldHVybiBUUlVFOwogCiAgICAgRUNITygmQ29udGV4dC0+RGV2aWNlLCAiXHJcbiIpOwot ICAgIEVDSE8oJkNvbnRleHQtPkRldmljZSwgIiBydW4gYXMgQWRtaW5pc3RyYXRvciBbeWVzfG5v XTogIik7CisgICAgRUNITygmQ29udGV4dC0+RGV2aWNlLCAiUnVuIEVsZXZhdGVkIFt5ZXN8bm9d OiAiKTsKIAogICAgIFplcm9NZW1vcnkoQnVmZmVyLCBzaXplb2YgKEJ1ZmZlcikpOwogCkBAIC0z OTYsNiArMzk2LDggQEAgUmVxdWVzdEVsZXZhdGlvbigKICAgICBpZiAoX3Rjc2xlbihCdWZmZXIp ID09IDApCiAgICAgICAgIHJldHVybiBGQUxTRTsKIAorICAgIEVDSE8oJkNvbnRleHQtPkRldmlj ZSwgIlxyXG4iKTsKKwogICAgIGlmIChfdGNzY21wKEJ1ZmZlciwgVEVYVCgieWVzIikpICE9IDAp CiAgICAgICAgIHJldHVybiBUUlVFOwogCkBAIC00MTAsNiArNDEyLDggQEAgUmVxdWVzdEVsZXZh dGlvbigKICAgICBDb250ZXh0LT5PcmlnaW5hbFRva2VuID0gQ29udGV4dC0+VG9rZW47CiAgICAg Q29udGV4dC0+VG9rZW4gPSBMaW5rZWRUb2tlbi5MaW5rZWRUb2tlbjsKIAorICAgIEVDSE8oJkNv bnRleHQtPkRldmljZSwgIlJ1bm5pbmcgRWxldmF0ZWRcclxuXHJcbiIpOworCiAgICAgcmV0dXJu IFRSVUU7CiB9CiAKLS0gCjIuMTYuMi53aW5kb3dzLjEKCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwp3aW4tcHYtZGV2ZWwgbWFpbGluZyBsaXN0Cndpbi1w di1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3Jn L21haWxtYW4vbGlzdGluZm8vd2luLXB2LWRldmVs From win-pv-devel-bounces@lists.xenproject.org Fri Nov 08 12:57:00 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 08 Nov 2019 12:57:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iT3ox-0001aU-Fe; Fri, 08 Nov 2019 12:56:59 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iT3ow-0001aP-4B for win-pv-devel@lists.xenproject.org; Fri, 08 Nov 2019 12:56:58 +0000 X-Inumbo-ID: 3ecb5392-0227-11ea-a1d5-12813bfff9fa Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3ecb5392-0227-11ea-a1d5-12813bfff9fa; Fri, 08 Nov 2019 12:56:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1573217818; h=from:to:cc:subject:date:message-id:mime-version; bh=IYEVW9KBinjNl9vu7WlTxTgt1yRhOlCnhz5wv+TCml4=; b=C0QmTB2/+OOxMcIwH9gCkZz2iMQVvHKYqdAbQ9+8ohYfPSCh3f5/txXv Mxf57dOwFUydUU/+e6qFmDJnXB5cfjReH6sMod2rmocyHTgjrDTL6YxNl Fi/XZMxKAEERkNbbz12v86gDnn9y/40PH19HaeQijR8AJqmfQqVO2mIVm c=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=owen.smith@citrix.com; spf=Pass smtp.mailfrom=owen.smith@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of owen.smith@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="owen.smith@citrix.com"; x-sender="owen.smith@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa3.hc3370-68.iphmx.com: domain of owen.smith@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="owen.smith@citrix.com"; x-sender="owen.smith@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="owen.smith@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: sAG32kB/rGjGID450gz4DJa8qFm5mJBlQnBnayJXiGZpXRk5PPNxOw3Fiqc2HeItkRrfKaH6f0 Zc58EFvmIIY3LDweNXNeNh1AgmH5K+k8hLNEDZkF5T0S5KX5h57ddqYWM0/qn4/vFGi/2T6dCc jYh6tJk7Bv/rpN2SWl/RadDufM3+q9E+DkwC2rsDdNp26osD+JWwx4wvX8r7uXPpch4uYISTEB Uk65cmp+p/uWXTwOK+Gl8dQFRl9X9xzg8SScxi/NFCOIqtAKBOTrVSCQt3nFttnMGAcVKLoh5q mh0= X-SBRS: 2.7 X-MesageID: 8058222 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.68,281,1569297600"; d="scan'208";a="8058222" From: Owen Smith To: Date: Fri, 8 Nov 2019 12:56:32 +0000 Message-ID: <20191108125632.9012-1-owen.smith@citrix.com> X-Mailer: git-send-email 2.16.2.windows.1 MIME-Version: 1.0 Subject: [win-pv-devel] [PATCH] Use fixed size buffer for RtlStringCbPrintf X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Owen Smith Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" VXNpbmcgc2l6ZW9mKCJtYWMvWFgiKSBjYW4gcmVzdWx0IGluIGEgYnVmZmVyIG5vdCBsYXJnZSBl bm91Z2ggZm9yIHRoZQpSdGxTdHJpbmdDYlByaW50ZiBjYWxsIHRvIHN1Y2NlZWQsIGZvciBsYXJn ZSBudW1iZXJzIG9mIG11bHRpY2FzdAphZGRyZXNzZXMuCgpTaWduZWQtb2ZmLWJ5OiBPd2VuIFNt aXRoIDxvd2VuLnNtaXRoQGNpdHJpeC5jb20+Ci0tLQogc3JjL3hlbnZpZi9tYWMuYyB8IDMgKyst CiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0t Z2l0IGEvc3JjL3hlbnZpZi9tYWMuYyBiL3NyYy94ZW52aWYvbWFjLmMKaW5kZXggMGIxN2E1NC4u MzA0MWQ4NSAxMDA2NDQKLS0tIGEvc3JjL3hlbnZpZi9tYWMuYworKysgYi9zcmMveGVudmlmL21h Yy5jCkBAIC02OSw2ICs2OSw3IEBAIHN0cnVjdCBfWEVOVklGX01BQyB7CiB9OwogCiAjZGVmaW5l IFhFTlZJRl9NQUNfVEFHICAnQ0FNJworI2RlZmluZSBNQVhfQlVGRkVSX1NJWkUgNjQKIAogc3Rh dGljIEZPUkNFSU5MSU5FIFBWT0lECiBfX01hY0FsbG9jYXRlKApAQCAtMzU3LDcgKzM1OCw3IEBA IE1hY0R1bXBBZGRyZXNzVGFibGUoCiAgICAgICAgICAgICAgICAgICAgICAgICAibWFjIik7CiAK ICAgICBmb3IgKEluZGV4ID0gMDsgSW5kZXggPCBDb3VudDsgSW5kZXgrKykgewotICAgICAgICBD SEFSICAgIE5vZGVbc2l6ZW9mICgibWFjL1hYIildOworICAgICAgICBDSEFSICAgIE5vZGVbTUFY X0JVRkZFUl9TSVpFXTsKIAogICAgICAgICBzdGF0dXMgPSBSdGxTdHJpbmdDYlByaW50ZkEoTm9k ZSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNpemVvZiAoTm9kZSksCi0t IAoyLjE2LjIud2luZG93cy4xCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18Kd2luLXB2LWRldmVsIG1haWxpbmcgbGlzdAp3aW4tcHYtZGV2ZWxAbGlzdHMu eGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3Rp bmZvL3dpbi1wdi1kZXZlbA== From win-pv-devel-bounces@lists.xenproject.org Mon Nov 11 11:37:35 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 11 Nov 2019 11:37:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iU80k-0003UF-EK; Mon, 11 Nov 2019 11:37:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iU80j-0003U4-6L for win-pv-devel@lists.xenproject.org; Mon, 11 Nov 2019 11:37:33 +0000 X-Inumbo-ID: a61729f2-0477-11ea-b678-bc764e2007e4 Received: from mail-pl1-x641.google.com (unknown [2607:f8b0:4864:20::641]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a61729f2-0477-11ea-b678-bc764e2007e4; Mon, 11 Nov 2019 11:37:32 +0000 (UTC) Received: by mail-pl1-x641.google.com with SMTP id a18so7690633plm.10 for ; Mon, 11 Nov 2019 03:37:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=U7DLLBrveo8YYZyj16lfaEE7sVmNfK3FpakyJRX7X0I=; b=jfr3xB9/WVRHjLA15JC9pU7Gu+U83T0T0HE/KmAFC9w7pK8qkQScKK0nvP6k0hEChM picmcvrvKfncDF7EeOu/S7MyVKUUs3O3KwE83Rg9j5N43Z/VTyLvFM24g9ZhKt+7mTEe TzxlZGXRsWl/nvz9DmTYLA6H0kGzORsiVa3pVA4dy1sHHOFaGRz/CihmWACXBA5JTB4N QrqbNfxi6QRTMQx5g3bNmzXECQ3T0g1ofoBy/T/g8ZfFbcTnp4me7nCYg1yLBnKe6WZu sbGA80LSojbBUVELE34W7wWyxlvCAMu7KFO2867l0x/TMGm72V2mfdP+L0z7xfBb9d13 oKXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=U7DLLBrveo8YYZyj16lfaEE7sVmNfK3FpakyJRX7X0I=; b=abTq6ApvdfT2Tk0OdI9Twt+hDYHuZS6pe8z0Zg1yR6pDvaF950vfKCLk/d7U9McQvz IECQmTMrhu9LqC9+GgjR6k+1sNAIIi3xoS0BXO5nl//DOiNkgKTV+snD9AXdazwwE3Mv o8ASsG5ZDersg+FFOhRGbPv/ENctypH5vTQRTLiej972nkn2pY5AXha0pHDLgwkdzU4+ E5cy+GyoIRtU0fVOAewkw5smtrecxjhOycjDQabhadvsGYFQLt9awAWYwotnrB/iqTyd S9QMHZOcpGZwtS6p5dUYKTS+/MqGTJ0Ic+2nC+s9SF9cN0nYLClF2ID7yYwrpA+9brsu iiBQ== X-Gm-Message-State: APjAAAUe+yAjxOPWwqzTPjCPEuOmrPVdjBimaXiJLzdOx6R0Lu6zzfFa Q67Z3cDflHeUjWKg3GAdtiF5NsK3nyNLzcAZV0+i94oDFR0= X-Google-Smtp-Source: APXvYqyK0vYab4mTAl0uMppRmYPTyDhEPlNqvkjuFYU2sCz0HpqCu2XoNhJx4vpoHVusRGy43mws+YbZNWAZD6/YAN0= X-Received: by 2002:a17:902:9302:: with SMTP id bc2mr25682132plb.148.1573472251637; Mon, 11 Nov 2019 03:37:31 -0800 (PST) MIME-Version: 1.0 References: <20191108125632.9012-1-owen.smith@citrix.com> In-Reply-To: <20191108125632.9012-1-owen.smith@citrix.com> From: Paul Durrant Date: Mon, 11 Nov 2019 11:37:20 +0000 Message-ID: To: Owen Smith Subject: Re: [win-pv-devel] [PATCH] Use fixed size buffer for RtlStringCbPrintf X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: win-pv-devel@lists.xenproject.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" T24gRnJpLCA4IE5vdiAyMDE5IGF0IDEyOjU3LCBPd2VuIFNtaXRoIDxvd2VuLnNtaXRoQGNpdHJp eC5jb20+IHdyb3RlOgo+Cj4gVXNpbmcgc2l6ZW9mKCJtYWMvWFgiKSBjYW4gcmVzdWx0IGluIGEg YnVmZmVyIG5vdCBsYXJnZSBlbm91Z2ggZm9yIHRoZQo+IFJ0bFN0cmluZ0NiUHJpbnRmIGNhbGwg dG8gc3VjY2VlZCwgZm9yIGxhcmdlIG51bWJlcnMgb2YgbXVsdGljYXN0Cj4gYWRkcmVzc2VzLgoK SG93IG1hbnkgYXJlIG9ic2VydmVkPyBFdmVuIGlmIGl0IGlzID49MTAwLCBpcyByZWFsbHkgbGlr ZWx5IHRvIGV2ZXIKYmUgPj0xMDAwIHdpdGhvdXQgc29tZXRoaW5nIGJlaW5nIHF1aXRlIHdyb25n PwoKICBQYXVsCgo+Cj4gU2lnbmVkLW9mZi1ieTogT3dlbiBTbWl0aCA8b3dlbi5zbWl0aEBjaXRy aXguY29tPgo+IC0tLQo+ICBzcmMveGVudmlmL21hYy5jIHwgMyArKy0KPiAgMSBmaWxlIGNoYW5n ZWQsIDIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+Cj4gZGlmZiAtLWdpdCBhL3NyYy94 ZW52aWYvbWFjLmMgYi9zcmMveGVudmlmL21hYy5jCj4gaW5kZXggMGIxN2E1NC4uMzA0MWQ4NSAx MDA2NDQKPiAtLS0gYS9zcmMveGVudmlmL21hYy5jCj4gKysrIGIvc3JjL3hlbnZpZi9tYWMuYwo+ IEBAIC02OSw2ICs2OSw3IEBAIHN0cnVjdCBfWEVOVklGX01BQyB7Cj4gIH07Cj4KPiAgI2RlZmlu ZSBYRU5WSUZfTUFDX1RBRyAgJ0NBTScKPiArI2RlZmluZSBNQVhfQlVGRkVSX1NJWkUgNjQKPgo+ ICBzdGF0aWMgRk9SQ0VJTkxJTkUgUFZPSUQKPiAgX19NYWNBbGxvY2F0ZSgKPiBAQCAtMzU3LDcg KzM1OCw3IEBAIE1hY0R1bXBBZGRyZXNzVGFibGUoCj4gICAgICAgICAgICAgICAgICAgICAgICAg ICJtYWMiKTsKPgo+ICAgICAgZm9yIChJbmRleCA9IDA7IEluZGV4IDwgQ291bnQ7IEluZGV4Kysp IHsKPiAtICAgICAgICBDSEFSICAgIE5vZGVbc2l6ZW9mICgibWFjL1hYIildOwo+ICsgICAgICAg IENIQVIgICAgTm9kZVtNQVhfQlVGRkVSX1NJWkVdOwo+Cj4gICAgICAgICAgc3RhdHVzID0gUnRs U3RyaW5nQ2JQcmludGZBKE5vZGUsCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHNpemVvZiAoTm9kZSksCj4gLS0KPiAyLjE2LjIud2luZG93cy4xCj4KPgo+IF9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gd2luLXB2LWRldmVsIG1h aWxpbmcgbGlzdAo+IHdpbi1wdi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwo+IGh0dHBzOi8v bGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby93aW4tcHYtZGV2ZWwKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCndpbi1wdi1kZXZlbCBt YWlsaW5nIGxpc3QKd2luLXB2LWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlz dHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby93aW4tcHYtZGV2ZWw= From win-pv-devel-bounces@lists.xenproject.org Mon Nov 11 11:42:47 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 11 Nov 2019 11:42:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iU85m-0004Ci-Rs; Mon, 11 Nov 2019 11:42:46 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iU85l-0004Cd-6j for win-pv-devel@lists.xenproject.org; Mon, 11 Nov 2019 11:42:45 +0000 X-Inumbo-ID: 60038158-0478-11ea-b678-bc764e2007e4 Received: from mail-pg1-x542.google.com (unknown [2607:f8b0:4864:20::542]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 60038158-0478-11ea-b678-bc764e2007e4; Mon, 11 Nov 2019 11:42:44 +0000 (UTC) Received: by mail-pg1-x542.google.com with SMTP id w11so9296475pga.12 for ; Mon, 11 Nov 2019 03:42:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HayM4b3iksANwu2UzvCe7eFaMeUcr7fhd7+I9E1zxoo=; b=it25gkwffriVbDT9aAyE52d+7Qs1D3f9i7WLf441fkWfbgFNNYO0C1pwIQJsiIPbBa Ip25K87ASjnusIVdCeGVRjSZAEZAUp1BVQn2/za65MN/Xkc7EMMNArAJ4ewqxyuIsM0l UtDU6Ufh0UzaJ3LVMg/CxD8Ks50iWTpJxxpTjnLEWICdkS+6Wj3Kscl0VEYC9FzXFrTb RvbFu1HNqJkQDcI/ANm1arqZpNfurIn+5qtZmVokQUmoupg/YIAdLTJnkNbGmBRhKGEW SZ5iaHhNFUORyOt1aGBNTHVgruNN0afyMDdcpjFsdJWvsDTDs9hSLVQVvSc3WTeWjcN6 R3eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HayM4b3iksANwu2UzvCe7eFaMeUcr7fhd7+I9E1zxoo=; b=OdXzxHxR7NxZ6xkchcr1Oo1J59NfnmFHdnuTXiaH7Y/auLd2gGQVr8rEuCEbf/xNMN WKUt3wHfFygU7PUyUErMEzEdKj6tOfz40JM9dgJNMAE/MEZCOlAC/G0RVu+608R4g42w Towjt30pZPWwa4oXXM2ZQvuEfLSJYPlcds4/g+U7bsE94GWdzc6fakFKs9IjtHMtO1Tl 5U87bwQssaEsKJeJLHAbffXS2MXoLGl1Uec2JlXJf76/ByNFtQC36udFel31yYYd0Aft vrbIsjOZbffizixWqRmKQ2F4H41/JLoYpNnHShZrll1rnlBvQ55hDkGoUnFUisjRLPGF QZfQ== X-Gm-Message-State: APjAAAVYdoJuAzKuUD8MPc3LbXJAFnddqD5MihOpHCm4pFJXhUkeqc8d tRRYR+R37rsYIt2alYRVZu/fpwP9AW6I5HiFqMQ= X-Google-Smtp-Source: APXvYqzga+9oydo9Q+tzubkYNeCvz85E1GeI7rg60z3+NI+kM/4WXwThtyrugpvXq/DzQbelLtdDphUTVezGmjuliEI= X-Received: by 2002:a63:fe47:: with SMTP id x7mr29499436pgj.112.1573472563591; Mon, 11 Nov 2019 03:42:43 -0800 (PST) MIME-Version: 1.0 References: <20191107155318.4864-1-owen.smith@citrix.com> In-Reply-To: <20191107155318.4864-1-owen.smith@citrix.com> From: Paul Durrant Date: Mon, 11 Nov 2019 11:42:32 +0000 Message-ID: To: Owen Smith Subject: Re: [win-pv-devel] [PATCH 1/4] Don't store password longer than required X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: win-pv-devel@lists.xenproject.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" T24gVGh1LCA3IE5vdiAyMDE5IGF0IDE1OjUzLCBPd2VuIFNtaXRoIDxvd2VuLnNtaXRoQGNpdHJp eC5jb20+IHdyb3RlOgo+Cj4gU2lnbmVkLW9mZi1ieTogT3dlbiBTbWl0aCA8b3dlbi5zbWl0aEBj aXRyaXguY29tPgoKQWNrZWQtYnk6IFBhdWwgRHVycmFudCA8cGF1bEB4ZW4ub3JnPgoKPiAtLS0K PiAgc3JjL3R0eS90dHkuYyB8IDIwICsrKysrKysrKysrKy0tLS0tLS0tCj4gIDEgZmlsZSBjaGFu Z2VkLCAxMiBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL3Ny Yy90dHkvdHR5LmMgYi9zcmMvdHR5L3R0eS5jCj4gaW5kZXggNmUzNDBhYi4uMDM1ZjE4YyAxMDA2 NDQKPiAtLS0gYS9zcmMvdHR5L3R0eS5jCj4gKysrIGIvc3JjL3R0eS90dHkuYwo+IEBAIC01MSw3 ICs1MSw2IEBAIHR5cGVkZWYgc3RydWN0IF9UVFlfQ09OVEVYVCB7Cj4gICAgICBUVFlfU1RSRUFN ICAgICAgICAgIENoaWxkU3RkT3V0Owo+ICAgICAgVFRZX1NUUkVBTSAgICAgICAgICBEZXZpY2U7 Cj4gICAgICBUQ0hBUiAgICAgICAgICAgICAgIFVzZXJOYW1lW01BWElNVU1fQlVGRkVSX1NJWkVd Owo+IC0gICAgVENIQVIgICAgICAgICAgICAgICBQYXNzd29yZFtNQVhJTVVNX0JVRkZFUl9TSVpF XTsKPiAgICAgIEhBTkRMRSAgICAgICAgICAgICAgVG9rZW47Cj4gICAgICBQUk9DRVNTX0lORk9S TUFUSU9OIFByb2Nlc3NJbmZvOwo+ICB9IFRUWV9DT05URVhULCAqUFRUWV9DT05URVhUOwo+IEBA IC0yODksNyArMjg4LDggQEAgR2V0TGluZSgKPgo+ICBzdGF0aWMgQk9PTAo+ICBHZXRDcmVkZW50 aWFscygKPiAtICAgIFZPSUQKPiArICAgIElOICBQVENIQVIgICAgICBQYXNzd29yZCwKPiArICAg IElOICBEV09SRCAgICAgICBQYXNzd29yZFNpemUKPiAgICAgICkKPiAgewo+ICAgICAgUFRUWV9D T05URVhUICAgIENvbnRleHQgPSAmVHR5Q29udGV4dDsKPiBAQCAtMzMwLDE3ICszMzAsMTcgQEAg R2V0Q3JlZGVudGlhbHMoCj4KPiAgICAgIEVDSE8oJkNvbnRleHQtPkRldmljZSwgIlBhc3N3b3Jk OiAiKTsKPgo+IC0gICAgWmVyb01lbW9yeShDb250ZXh0LT5QYXNzd29yZCwgc2l6ZW9mIChDb250 ZXh0LT5QYXNzd29yZCkpOwo+ICsgICAgWmVyb01lbW9yeShQYXNzd29yZCwgUGFzc3dvcmRTaXpl KTsKPgo+ICAgICAgU3VjY2VzcyA9IEdldExpbmUoJkNvbnRleHQtPkRldmljZSwKPiAtICAgICAg ICAgICAgICAgICAgICAgIENvbnRleHQtPlBhc3N3b3JkLAo+IC0gICAgICAgICAgICAgICAgICAg ICAgc2l6ZW9mIChDb250ZXh0LT5QYXNzd29yZCksCj4gKyAgICAgICAgICAgICAgICAgICAgICBQ YXNzd29yZCwKPiArICAgICAgICAgICAgICAgICAgICAgIFBhc3N3b3JkU2l6ZSwKPiAgICAgICAg ICAgICAgICAgICAgICAgICZTaXplLAo+ICAgICAgICAgICAgICAgICAgICAgICAgVFJVRSk7Cj4g ICAgICBpZiAoIVN1Y2Nlc3MpCj4gICAgICAgICAgcmV0dXJuIEZBTFNFOwo+Cj4gLSAgICBFbmQg PSBfdGNzY2hyKENvbnRleHQtPlBhc3N3b3JkLCBURVhUKCdccicpKTsKPiArICAgIEVuZCA9IF90 Y3NjaHIoUGFzc3dvcmQsIFRFWFQoJ1xyJykpOwo+ICAgICAgaWYgKEVuZCA9PSBOVUxMKQo+ICAg ICAgICAgIHJldHVybiBGQUxTRTsKPgo+IEBAIC00NDgsNiArNDQ4LDcgQEAgX3RtYWluKAo+ICAg ICAgUFRUWV9DT05URVhUICAgICAgICBDb250ZXh0ID0gJlR0eUNvbnRleHQ7Cj4gICAgICBTRUNV UklUWV9BVFRSSUJVVEVTIEF0dHJpYnV0ZXM7Cj4gICAgICBIQU5ETEUgICAgICAgICAgICAgIEhh bmRsZVszXTsKPiArICAgIFRDSEFSICAgICAgICAgICAgICAgUGFzc3dvcmRbTUFYSU1VTV9CVUZG RVJfU0laRV07Cj4gICAgICBEV09SRCAgICAgICAgICAgICAgIEluZGV4Owo+ICAgICAgQk9PTCAg ICAgICAgICAgICAgICBTdWNjZXNzOwo+Cj4gQEAgLTQ4NCwxNiArNDg1LDE5IEBAIF90bWFpbigK PiAgICAgIGlmIChDb250ZXh0LT5EZXZpY2UuV3JpdGUgPT0gSU5WQUxJRF9IQU5ETEVfVkFMVUUp Cj4gICAgICAgICAgRXhpdFByb2Nlc3MoMSk7Cj4KPiAtICAgIFN1Y2Nlc3MgPSBHZXRDcmVkZW50 aWFscygpOwo+ICsgICAgU3VjY2VzcyA9IEdldENyZWRlbnRpYWxzKFBhc3N3b3JkLCBzaXplb2Yo UGFzc3dvcmQpKTsKPiAgICAgIGlmICghU3VjY2VzcykKPiAgICAgICAgICBFeGl0UHJvY2Vzcygx KTsKPgo+ICAgICAgU3VjY2VzcyA9IExvZ29uVXNlcihDb250ZXh0LT5Vc2VyTmFtZSwKPiAgICAg ICAgICAgICAgICAgICAgICAgICAgTlVMTCwKPiAtICAgICAgICAgICAgICAgICAgICAgICAgQ29u dGV4dC0+UGFzc3dvcmQsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgIFBhc3N3b3JkLAo+ICAg ICAgICAgICAgICAgICAgICAgICAgICBMT0dPTjMyX0xPR09OX0lOVEVSQUNUSVZFLAo+ICAgICAg ICAgICAgICAgICAgICAgICAgICBMT0dPTjMyX1BST1ZJREVSX0RFRkFVTFQsCj4gICAgICAgICAg ICAgICAgICAgICAgICAgICZDb250ZXh0LT5Ub2tlbik7Cj4gKwo+ICsgICAgWmVyb01lbW9yeShQ YXNzd29yZCwgc2l6ZW9mKFBhc3N3b3JkKSk7Cj4gKwo+ICAgICAgaWYgKCFTdWNjZXNzKQo+ICAg ICAgICAgIEV4aXRQcm9jZXNzKDEpOwo+Cj4gLS0KPiAyLjE2LjIud2luZG93cy4xCj4KPgo+IF9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gd2luLXB2LWRl dmVsIG1haWxpbmcgbGlzdAo+IHdpbi1wdi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwo+IGh0 dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby93aW4tcHYtZGV2ZWwK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCndpbi1wdi1k ZXZlbCBtYWlsaW5nIGxpc3QKd2luLXB2LWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBz Oi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby93aW4tcHYtZGV2ZWw= From win-pv-devel-bounces@lists.xenproject.org Mon Nov 11 12:21:22 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 11 Nov 2019 12:21:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iU8h8-0007e0-0P; Mon, 11 Nov 2019 12:21:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iU8h6-0007dt-So for win-pv-devel@lists.xenproject.org; Mon, 11 Nov 2019 12:21:20 +0000 X-Inumbo-ID: c452d154-047d-11ea-984a-bc764e2007e4 Received: from mail-pl1-x644.google.com (unknown [2607:f8b0:4864:20::644]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c452d154-047d-11ea-984a-bc764e2007e4; Mon, 11 Nov 2019 12:21:20 +0000 (UTC) Received: by mail-pl1-x644.google.com with SMTP id l4so7715262plt.13 for ; Mon, 11 Nov 2019 04:21:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ogm94Rr4JHEDDNBh/NxKIJSEoL9fKDNULJOrTven6e0=; b=W1+8EKIOF8qz8ZWcdVv/1uerjddqIMBITAeSP+MMswcCdWXB/oDVFoFXkTL8lVXEvV uuutQF98EOlxfY0zkjFdatJ+GHfc152PU3r4Q39GWFCzBYIud67B/NvRhxOcFFSjBeEC X9bGKdJzwAuI0hoLL/UcyrLl/Kkt4qdtD7xoveAaZfeMXrE0D9pRo1kaxx2tFxtdyABr +Wtq3OLTZJbpASFb/CWphjEXbxfVUSBZVmeMEBa7P+cT9rOBuoB4E2A1bzgEh0f6XHXz yclt8ye+De0Y56Ls0+w9hagaGq7PnD2Yt3F5GqXZ1Ga9Zy0pgQx36aLlE9ZWO0dbzyVO eq8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ogm94Rr4JHEDDNBh/NxKIJSEoL9fKDNULJOrTven6e0=; b=dVefB4sBZmnJaKefEWh3mmEzoYL0BpQi/sK6y/6PNYjpd+sh5o8p9c/DKgGo1ZkrsE 40frQ1/YLpu6cqlx1HAkzBLwl0qwtQnymCGL6Q35ju5S5BjLUah3nZL85LBJbH98k7Vq cigivqeKJRBBh+hU2/CTk4mFwfH3IkyZLHzF0KXsb4VkNTgAsjRPzWtakIDkMqzI1QhP WmtISjW8PBoP15ZwML085YRAn9rYTexe+agtN09HpYAwvw6slckKLh+GXwYVdc8LeGQH 1SVRY1vXB0qE54IMKLN8qtz6fW5usRVOAJbivRx6IiBiDgTj3zToyq2qBF0MUeEPzY4d DfhA== X-Gm-Message-State: APjAAAVoPXn7+Bd+DWEK3fZiU5l5940ezMPnZbvuP0K8bs9L02Xwloj4 oiULUGuz+WoWX3/V0dFkQdaUDaPtDTS6hRUZfLE= X-Google-Smtp-Source: APXvYqy6gRbXs5le3F5xGp+/51Fg3Z09ln8Lbnkz7T8ajTHAa8r2JO7Ug+n2iA4XpVDNHgjxOGkHnn9oZ50BNhE9xhE= X-Received: by 2002:a17:902:ac98:: with SMTP id h24mr24920506plr.227.1573474879318; Mon, 11 Nov 2019 04:21:19 -0800 (PST) MIME-Version: 1.0 References: <20191107155318.4864-1-owen.smith@citrix.com> <20191107155318.4864-2-owen.smith@citrix.com> In-Reply-To: <20191107155318.4864-2-owen.smith@citrix.com> From: Paul Durrant Date: Mon, 11 Nov 2019 12:21:08 +0000 Message-ID: To: Owen Smith Subject: Re: [win-pv-devel] [PATCH 2/4] Add option to elevate administrator users X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: win-pv-devel@lists.xenproject.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" T24gVGh1LCA3IE5vdiAyMDE5IGF0IDE1OjUzLCBPd2VuIFNtaXRoIDxvd2VuLnNtaXRoQGNpdHJp eC5jb20+IHdyb3RlOgo+Cj4gSWYgdGhlIHVzZXIgaGFzIEFkbWluaXN0cmF0b3IgYWNjZXNzLCBh ZGQgYSBwcm9tcHQgYW5kIGFiaWxpdHkgdG8KPiBlbGV2YXRlIHRoZSBhY2Nlc3MgdG8gdGhlIEFk bWluaXN0cmF0b3IgcHJpdmlsZWdlIGxldmVsIGluc3RlYWQgb2YKPiByZXRhaW5pbmcgdGhlIHVz ZXIgcHJpdmlsZWdlIGxldmVsLgo+Cj4gU2lnbmVkLW9mZi1ieTogT3dlbiBTbWl0aCA8b3dlbi5z bWl0aEBjaXRyaXguY29tPgoKQWNrZWQtYnk6IFBhdWwgRHVycmFudCA8cGF1bEB4ZW4ub3JnPgoK PiAtLS0KPiAgc3JjL3R0eS90dHkuYyB8IDY4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCA2OCBpbnNl cnRpb25zKCspCj4KPiBkaWZmIC0tZ2l0IGEvc3JjL3R0eS90dHkuYyBiL3NyYy90dHkvdHR5LmMK PiBpbmRleCAwMzVmMThjLi5lMjk1ZjA2IDEwMDY0NAo+IC0tLSBhL3NyYy90dHkvdHR5LmMKPiAr KysgYi9zcmMvdHR5L3R0eS5jCj4gQEAgLTUyLDYgKzUyLDcgQEAgdHlwZWRlZiBzdHJ1Y3QgX1RU WV9DT05URVhUIHsKPiAgICAgIFRUWV9TVFJFQU0gICAgICAgICAgRGV2aWNlOwo+ICAgICAgVENI QVIgICAgICAgICAgICAgICBVc2VyTmFtZVtNQVhJTVVNX0JVRkZFUl9TSVpFXTsKPiAgICAgIEhB TkRMRSAgICAgICAgICAgICAgVG9rZW47Cj4gKyAgICBIQU5ETEUgICAgICAgICAgICAgIE9yaWdp bmFsVG9rZW47Cj4gICAgICBQUk9DRVNTX0lORk9STUFUSU9OIFByb2Nlc3NJbmZvOwo+ICB9IFRU WV9DT05URVhULCAqUFRUWV9DT05URVhUOwo+Cj4gQEAgLTM0OSw2ICszNTAsNjkgQEAgR2V0Q3Jl ZGVudGlhbHMoCj4gICAgICByZXR1cm4gVFJVRTsKPiAgfQo+Cj4gK3N0YXRpYyBCT09MCj4gK1Jl cXVlc3RFbGV2YXRpb24oCj4gKyAgICBWT0lECj4gKyAgICApCj4gK3sKPiArICAgIFBUVFlfQ09O VEVYVCAgICAgICAgICAgIENvbnRleHQgPSAmVHR5Q29udGV4dDsKPiArICAgIFRPS0VOX0VMRVZB VElPTl9UWVBFICAgIEVsZXZhdGlvbjsKPiArICAgIERXT1JEICAgICAgICAgICAgICAgICAgIFNp emU7Cj4gKyAgICBUQ0hBUiAgICAgICAgICAgICAgICAgICBCdWZmZXJbTUFYSU1VTV9CVUZGRVJf U0laRV07Cj4gKyAgICBQVENIQVIgICAgICAgICAgICAgICAgICBFbmQ7Cj4gKyAgICBUT0tFTl9M SU5LRURfVE9LRU4gICAgICBMaW5rZWRUb2tlbjsKPiArICAgIEJPT0wgICAgICAgICAgICAgICAg ICAgIFN1Y2Nlc3M7Cj4gKwo+ICsgICAgU3VjY2VzcyA9IEdldFRva2VuSW5mb3JtYXRpb24oQ29u dGV4dC0+VG9rZW4sCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBUb2tlbkVs ZXZhdGlvblR5cGUsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAmRWxldmF0 aW9uLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc2l6ZW9mKEVsZXZhdGlv biksCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAmU2l6ZSk7Cj4gKyAgICBp ZiAoIVN1Y2Nlc3MpCj4gKyAgICAgICAgcmV0dXJuIFRSVUU7Cj4gKwo+ICsgICAgaWYgKEVsZXZh dGlvbiAhPSBUb2tlbkVsZXZhdGlvblR5cGVMaW1pdGVkKQo+ICsgICAgICAgIHJldHVybiBUUlVF Owo+ICsKPiArICAgIEVDSE8oJkNvbnRleHQtPkRldmljZSwgIlxyXG4iKTsKPiArICAgIEVDSE8o JkNvbnRleHQtPkRldmljZSwgIiBydW4gYXMgQWRtaW5pc3RyYXRvciBbeWVzfG5vXTogIik7Cj4g Kwo+ICsgICAgWmVyb01lbW9yeShCdWZmZXIsIHNpemVvZiAoQnVmZmVyKSk7Cj4gKwo+ICsgICAg U3VjY2VzcyA9IEdldExpbmUoJkNvbnRleHQtPkRldmljZSwKPiArICAgICAgICAgICAgICAgICAg ICAgIEJ1ZmZlciwKPiArICAgICAgICAgICAgICAgICAgICAgIHNpemVvZiAoQnVmZmVyKSwKPiAr ICAgICAgICAgICAgICAgICAgICAgICZTaXplLAo+ICsgICAgICAgICAgICAgICAgICAgICAgRkFM U0UpOwo+ICsgICAgaWYgKCFTdWNjZXNzKQo+ICsgICAgICAgIHJldHVybiBGQUxTRTsKPiArCj4g KyAgICBFbmQgPSBfdGNzY2hyKEJ1ZmZlciwgVEVYVCgnXHInKSk7Cj4gKyAgICBpZiAoRW5kID09 IE5VTEwpCj4gKyAgICAgICAgcmV0dXJuIEZBTFNFOwo+ICsKPiArICAgICpFbmQgPSBURVhUKCdc MCcpOwo+ICsKPiArICAgIGlmIChfdGNzbGVuKEJ1ZmZlcikgPT0gMCkKPiArICAgICAgICByZXR1 cm4gRkFMU0U7Cj4gKwo+ICsgICAgaWYgKF90Y3NjbXAoQnVmZmVyLCBURVhUKCJ5ZXMiKSkgIT0g MCkKPiArICAgICAgICByZXR1cm4gVFJVRTsKPiArCj4gKyAgICBTdWNjZXNzID0gR2V0VG9rZW5J bmZvcm1hdGlvbihDb250ZXh0LT5Ub2tlbiwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIFRva2VuTGlua2VkVG9rZW4sCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAmTGlua2VkVG9rZW4sCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBz aXplb2YoTGlua2VkVG9rZW4pLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg JlNpemUpOwo+ICsgICAgaWYgKCFTdWNjZXNzKQo+ICsgICAgICAgIHJldHVybiBGQUxTRTsKPiAr Cj4gKyAgICBDb250ZXh0LT5PcmlnaW5hbFRva2VuID0gQ29udGV4dC0+VG9rZW47Cj4gKyAgICBD b250ZXh0LT5Ub2tlbiA9IExpbmtlZFRva2VuLkxpbmtlZFRva2VuOwo+ICsKPiArICAgIHJldHVy biBUUlVFOwo+ICt9Cj4gKwo+ICBzdGF0aWMgRFdPUkQgV0lOQVBJCj4gIFR0eUluKAo+ICAgICAg SU4gIExQVk9JRCAgICAgIEFyZ3VtZW50Cj4gQEAgLTQ5OCw2ICs1NjIsMTAgQEAgX3RtYWluKAo+ Cj4gICAgICBaZXJvTWVtb3J5KFBhc3N3b3JkLCBzaXplb2YoUGFzc3dvcmQpKTsKPgo+ICsgICAg aWYgKCFTdWNjZXNzKQo+ICsgICAgICAgIEV4aXRQcm9jZXNzKDEpOwo+ICsKPiArICAgIFN1Y2Nl c3MgPSBSZXF1ZXN0RWxldmF0aW9uKCk7Cj4gICAgICBpZiAoIVN1Y2Nlc3MpCj4gICAgICAgICAg RXhpdFByb2Nlc3MoMSk7Cj4KPiAtLQo+IDIuMTYuMi53aW5kb3dzLjEKPgo+Cj4gX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiB3aW4tcHYtZGV2ZWwgbWFp bGluZyBsaXN0Cj4gd2luLXB2LWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCj4gaHR0cHM6Ly9s aXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3dpbi1wdi1kZXZlbAoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Kd2luLXB2LWRldmVsIG1h aWxpbmcgbGlzdAp3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0 cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3dpbi1wdi1kZXZlbA== From win-pv-devel-bounces@lists.xenproject.org Mon Nov 11 12:24:33 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 11 Nov 2019 12:24:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iU8kD-0007o1-HD; Mon, 11 Nov 2019 12:24:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iU8kC-0007ns-PJ for win-pv-devel@lists.xenproject.org; Mon, 11 Nov 2019 12:24:32 +0000 X-Inumbo-ID: 36be8eb8-047e-11ea-984a-bc764e2007e4 Received: from mail-pg1-x544.google.com (unknown [2607:f8b0:4864:20::544]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 36be8eb8-047e-11ea-984a-bc764e2007e4; Mon, 11 Nov 2019 12:24:32 +0000 (UTC) Received: by mail-pg1-x544.google.com with SMTP id k13so9401560pgh.3 for ; Mon, 11 Nov 2019 04:24:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4zQ8al7eSIN1oyEV+n0gS9g71nZmLyeMz8dmPdepFks=; b=EDtADX71V1u8RQ+j7tyF2CXzWy5NDMgylUC6XjECRiQ/1Lmf5O9CVOYp8PQoS5Xkeg 8tMtrEzF4KZaN/BW9Zn8gy564L6UDO3QfSVWiD0a+HoJu7WNk2XodnIE/+ez3w43VpeF O/Vs32/VDi15tvkX9e01fS3ZE6dc/H3Po//XnB95UKViMiXdx7JKagWHA2n84OS45TTx mgP2ipJzxHZH60lEksnnX+5fTCR5mttvY+an16WIz2dsmx2IWNWjTd5uMB+1vg+UODyz ZVk3+5ZEwpQUPV3qY7tWuQbqSvP/DwUtZKHk1f6V9BhxVu0MARP59I2+KtX1G/5wlCa9 UHNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4zQ8al7eSIN1oyEV+n0gS9g71nZmLyeMz8dmPdepFks=; b=EQHKJ2wbKTSrr5g+pXeFnYhdTmcx6CSnoRrPZ0VngiuRrZ7b1piwSGxS9yCrhJdOcU ykIWE9sFaa3oJ8VqK7BxZGvpKNGYvosKrWHZA+iI0347HjIBdMnH75CVXHPpVR8vssTj 8q63FPTSIZ+ha8QW5yPKEZPotkzk4kaX6SsKeT2lRxv22R4BcDnx0zr/E3K5W2+Kgbdx MGR+1ik26+LJ3vgof+UkQGWwJSzuaJhSQnLbfTE/zSpgIlHmfQm6pqfo4ka1PfRJ6pwd hwXqQ9UkrQ/fKnEuYw/88y5wTg0fuvUjezpJ8RBJMctnsNHg3gq7LSKMmafAXytJEcku grKA== X-Gm-Message-State: APjAAAVxa9/3qFDsGSkQ7MwvCE8QsYG4miay4mJPgiak5gGpWSnqGuAZ W3J22lLmNAzBY/jCxw2q12dtxjwrU/jsO2bHL8w= X-Google-Smtp-Source: APXvYqyf/bZVK/jOz+BHZavaZXBSxjlkqOC3luW1C5Yb61oUpL50PGNsvRq4V2Ym23MAEbI9yk2YM+nyV/YL+e9TPC0= X-Received: by 2002:a62:e308:: with SMTP id g8mr30064996pfh.121.1573475071443; Mon, 11 Nov 2019 04:24:31 -0800 (PST) MIME-Version: 1.0 References: <20191107155318.4864-1-owen.smith@citrix.com> <20191107155318.4864-3-owen.smith@citrix.com> In-Reply-To: <20191107155318.4864-3-owen.smith@citrix.com> From: Paul Durrant Date: Mon, 11 Nov 2019 12:24:20 +0000 Message-ID: To: Owen Smith Subject: Re: [win-pv-devel] [PATCH 3/4] Improve elevation prompts X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: win-pv-devel@lists.xenproject.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" T24gVGh1LCA3IE5vdiAyMDE5IGF0IDE1OjU0LCBPd2VuIFNtaXRoIDxvd2VuLnNtaXRoQGNpdHJp eC5jb20+IHdyb3RlOgo+Cj4gU2lnbmVkLW9mZi1ieTogT3dlbiBTbWl0aCA8b3dlbi5zbWl0aEBj aXRyaXguY29tPgoKPHNpZ2g+IFRoaXMgc2hvdWxkIGhhdmUgYmVlbiBzcXVhc2hlZCBpbnRvIHRo ZSBwcmV2aW91cyBwYXRjaC4uLiBJJ2xsIGRvIGl0LgoKICBQYXVsCgo+IC0tLQo+ICBzcmMvdHR5 L3R0eS5jIHwgNiArKysrKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgMSBk ZWxldGlvbigtKQo+Cj4gZGlmZiAtLWdpdCBhL3NyYy90dHkvdHR5LmMgYi9zcmMvdHR5L3R0eS5j Cj4gaW5kZXggZTI5NWYwNi4uYzNkZmNmOSAxMDA2NDQKPiAtLS0gYS9zcmMvdHR5L3R0eS5jCj4g KysrIGIvc3JjL3R0eS90dHkuYwo+IEBAIC0zNzUsNyArMzc1LDcgQEAgUmVxdWVzdEVsZXZhdGlv bigKPiAgICAgICAgICByZXR1cm4gVFJVRTsKPgo+ICAgICAgRUNITygmQ29udGV4dC0+RGV2aWNl LCAiXHJcbiIpOwo+IC0gICAgRUNITygmQ29udGV4dC0+RGV2aWNlLCAiIHJ1biBhcyBBZG1pbmlz dHJhdG9yIFt5ZXN8bm9dOiAiKTsKPiArICAgIEVDSE8oJkNvbnRleHQtPkRldmljZSwgIlJ1biBF bGV2YXRlZCBbeWVzfG5vXTogIik7Cj4KPiAgICAgIFplcm9NZW1vcnkoQnVmZmVyLCBzaXplb2Yg KEJ1ZmZlcikpOwo+Cj4gQEAgLTM5Niw2ICszOTYsOCBAQCBSZXF1ZXN0RWxldmF0aW9uKAo+ICAg ICAgaWYgKF90Y3NsZW4oQnVmZmVyKSA9PSAwKQo+ICAgICAgICAgIHJldHVybiBGQUxTRTsKPgo+ ICsgICAgRUNITygmQ29udGV4dC0+RGV2aWNlLCAiXHJcbiIpOwo+ICsKPiAgICAgIGlmIChfdGNz Y21wKEJ1ZmZlciwgVEVYVCgieWVzIikpICE9IDApCj4gICAgICAgICAgcmV0dXJuIFRSVUU7Cj4K PiBAQCAtNDEwLDYgKzQxMiw4IEBAIFJlcXVlc3RFbGV2YXRpb24oCj4gICAgICBDb250ZXh0LT5P cmlnaW5hbFRva2VuID0gQ29udGV4dC0+VG9rZW47Cj4gICAgICBDb250ZXh0LT5Ub2tlbiA9IExp bmtlZFRva2VuLkxpbmtlZFRva2VuOwo+Cj4gKyAgICBFQ0hPKCZDb250ZXh0LT5EZXZpY2UsICJS dW5uaW5nIEVsZXZhdGVkXHJcblxyXG4iKTsKPiArCj4gICAgICByZXR1cm4gVFJVRTsKPiAgfQo+ Cj4gLS0KPiAyLjE2LjIud2luZG93cy4xCj4KPgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCj4gd2luLXB2LWRldmVsIG1haWxpbmcgbGlzdAo+IHdpbi1w di1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwo+IGh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5v cmcvbWFpbG1hbi9saXN0aW5mby93aW4tcHYtZGV2ZWwKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCndpbi1wdi1kZXZlbCBtYWlsaW5nIGxpc3QKd2luLXB2 LWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcv bWFpbG1hbi9saXN0aW5mby93aW4tcHYtZGV2ZWw= From win-pv-devel-bounces@lists.xenproject.org Mon Nov 11 12:26:58 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 11 Nov 2019 12:26:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iU8mY-0007z8-03; Mon, 11 Nov 2019 12:26:57 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iU8mW-0007z1-N2 for win-pv-devel@lists.xenproject.org; Mon, 11 Nov 2019 12:26:56 +0000 X-Inumbo-ID: 8c8facbe-047e-11ea-b678-bc764e2007e4 Received: from mail-pf1-x444.google.com (unknown [2607:f8b0:4864:20::444]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8c8facbe-047e-11ea-b678-bc764e2007e4; Mon, 11 Nov 2019 12:26:56 +0000 (UTC) Received: by mail-pf1-x444.google.com with SMTP id p26so10604712pfq.8 for ; Mon, 11 Nov 2019 04:26:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fiLVarWYOIzU53I3DTDvArPul1VtojXvwPgY4etNPJU=; b=p0L3c+7lR8WykJWTgjBsUFvb5xN6ga1GmzqTxtic+K8tGHyzI0tSIoxzYja06wXwol HcewBeonMA7mzTBtOPdN+Q0x3PyiuFkU8U1Ia2vCQWTZSHCIw9LzOhlLgn7OlNXZaof4 qAgTsK6FGGEXeqo8laeS+XFDtMVxW+cLJsHy1SSU6RaPc1RMWDQSRuLePXiqJaPqHTXj k/ILTJZc8oGeTshurZQz+CvdOYHCgLVgKdLmmpOcYPOPw2jaaoAUM0m8qV4MNzqBhz+W 9zI6zApmmZ0EzhPAARB2GZaO7Rm5viBW4m8VVFMY3ZYGvlYDxH66dJXe1bDSJqNrYdAY HhBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fiLVarWYOIzU53I3DTDvArPul1VtojXvwPgY4etNPJU=; b=LZ6RcTu8SlLVRvUu7O0tM1whVUn7bGFsV8QXOTWMhiPCZauq82gk8eLaVChHd0v2S/ Br2zVSYip6v7+BcDolIZey1za6upbEE1NREVYn+Doktva9tKHKuVx7c0arxZGS9qMvkR 7G9A6AYhJedxaV3yduzBZtxZC/JXiGLTR41D/o55hk6r8F0qhDJQaZdThSmQB4m2aoMz ABJdSNtCHMmb7tL0hRTrydeJy7c9GfW6uIakj6I6SIdsu1+njPdUev9ciONfWraAsy3p xLw3wwBOEks74n97svnZXnteyvT0WEwUi7g1H4a8cmbOS3iQtpb5QV2ESm6lE+MVRYwA QTOA== X-Gm-Message-State: APjAAAVB96m7A6Tj0FenpkJFE8zxSx+lGxC8/ozkOj/FBcZuTNmXVIuf oP0PeDv7eDkVvePpPhvdol2IoUuCmi5uRmhoElk= X-Google-Smtp-Source: APXvYqzX7xqBW2Nyc+5+wxHXhY3Nk4hzOYHz66YyO6WNWmzH0b+rLLJrGaV8H154g4SuL/pWQYDBr4WGrYuZjDDoads= X-Received: by 2002:a17:90a:86c3:: with SMTP id y3mr34242512pjv.102.1573475215490; Mon, 11 Nov 2019 04:26:55 -0800 (PST) MIME-Version: 1.0 References: <20191107155318.4864-1-owen.smith@citrix.com> <20191107155318.4864-4-owen.smith@citrix.com> In-Reply-To: <20191107155318.4864-4-owen.smith@citrix.com> From: Paul Durrant Date: Mon, 11 Nov 2019 12:26:44 +0000 Message-ID: To: Owen Smith Subject: Re: [win-pv-devel] [PATCH 4/4] Make sure input buffers are always null-terminated X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: win-pv-devel@lists.xenproject.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" T24gVGh1LCA3IE5vdiAyMDE5IGF0IDE1OjUzLCBPd2VuIFNtaXRoIDxvd2VuLnNtaXRoQGNpdHJp eC5jb20+IHdyb3RlOgo+Cj4gU2lnbmVkLW9mZi1ieTogT3dlbiBTbWl0aCA8b3dlbi5zbWl0aEBj aXRyaXguY29tPgo+IC0tLQo+ICBzcmMvdHR5L3R0eS5jIHwgNiArKysrKysKPiAgMSBmaWxlIGNo YW5nZWQsIDYgaW5zZXJ0aW9ucygrKQo+Cj4gZGlmZiAtLWdpdCBhL3NyYy90dHkvdHR5LmMgYi9z cmMvdHR5L3R0eS5jCj4gaW5kZXggYzNkZmNmOS4uY2IxMzc4ZCAxMDA2NDQKPiAtLS0gYS9zcmMv dHR5L3R0eS5jCj4gKysrIGIvc3JjL3R0eS90dHkuYwo+IEBAIC0zMTcsNiArMzE3LDggQEAgR2V0 Q3JlZGVudGlhbHMoCj4gICAgICAgICAgICAgICAgICAgICAgICBzaXplb2YgKENvbnRleHQtPlVz ZXJOYW1lKSwKPiAgICAgICAgICAgICAgICAgICAgICAgICZTaXplLAo+ICAgICAgICAgICAgICAg ICAgICAgICAgRkFMU0UpOwo+ICsgICAgQ29udGV4dC0+VXNlck5hbWVbTUFYSU1VTV9CVUZGRVJf U0laRSAtIDFdID0gVEVYVCgnXDAnKTsKPiArCgpJJ2QgcHJlZmVyIHVzZSBvZiBzaXplb2YoKSBo ZXJlLi4uCgo+ICAgICAgaWYgKCFTdWNjZXNzKQo+ICAgICAgICAgIHJldHVybiBGQUxTRTsKPgo+ IEBAIC0zMzgsNiArMzQwLDggQEAgR2V0Q3JlZGVudGlhbHMoCj4gICAgICAgICAgICAgICAgICAg ICAgICBQYXNzd29yZFNpemUsCj4gICAgICAgICAgICAgICAgICAgICAgICAmU2l6ZSwKPiAgICAg ICAgICAgICAgICAgICAgICAgIFRSVUUpOwo+ICsgICAgUGFzc3dvcmRbKFBhc3N3b3JkU2l6ZSAv IHNpemVvZihUQ0hBUikpIC0gMV0gPSBURVhUKCdcMCcpOwo+ICsKPiAgICAgIGlmICghU3VjY2Vz cykKPiAgICAgICAgICByZXR1cm4gRkFMU0U7Cj4KPiBAQCAtMzg0LDYgKzM4OCw4IEBAIFJlcXVl c3RFbGV2YXRpb24oCj4gICAgICAgICAgICAgICAgICAgICAgICBzaXplb2YgKEJ1ZmZlciksCj4g ICAgICAgICAgICAgICAgICAgICAgICAmU2l6ZSwKPiAgICAgICAgICAgICAgICAgICAgICAgIEZB TFNFKTsKPiArICAgIEJ1ZmZlcltNQVhJTVVNX0JVRkZFUl9TSVpFIC0gMV0gPSBURVhUKCdcMCcp Owo+ICsKCi4uLmFuZCBoZXJlLgoKICBQYXVsCgo+ICAgICAgaWYgKCFTdWNjZXNzKQo+ICAgICAg ICAgIHJldHVybiBGQUxTRTsKPgo+IC0tCj4gMi4xNi4yLndpbmRvd3MuMQo+Cj4KPiBfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IHdpbi1wdi1kZXZlbCBt YWlsaW5nIGxpc3QKPiB3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKPiBodHRwczov L2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8vd2luLXB2LWRldmVsCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwp3aW4tcHYtZGV2ZWwg bWFpbGluZyBsaXN0Cndpbi1wdi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xp c3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8vd2luLXB2LWRldmVs From win-pv-devel-bounces@lists.xenproject.org Mon Nov 11 13:56:11 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 11 Nov 2019 13:56:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iUAAs-0006ws-M1; Mon, 11 Nov 2019 13:56:10 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iUAAr-0006wn-B4 for win-pv-devel@lists.xenproject.org; Mon, 11 Nov 2019 13:56:09 +0000 Date: Mon, 11 Nov 2019 13:55:50 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <31202318.1.1573480551534.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_0_3866982.1573480551128" X-Jenkins-Job: XENCONS-master X-Jenkins-Result: SUCCESS Subject: [win-pv-devel] XENCONS-master - Build #27 - Successful X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" ------=_Part_0_3866982.1573480551128 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #27. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENCONS-master/27/console to view the results. ------=_Part_0_3866982.1573480551128 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Kd2luLXB2LWRl dmVsIG1haWxpbmcgbGlzdAp3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6 Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3dpbi1wdi1kZXZlbA== ------=_Part_0_3866982.1573480551128-- From win-pv-devel-bounces@lists.xenproject.org Wed Nov 13 15:44:45 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 13 Nov 2019 15:44:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iUup1-0006vG-5H; Wed, 13 Nov 2019 15:44:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iUuoz-0006vB-NQ for win-pv-devel@lists.xenproject.org; Wed, 13 Nov 2019 15:44:41 +0000 X-Inumbo-ID: 80f7d8a4-062c-11ea-b678-bc764e2007e4 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 80f7d8a4-062c-11ea-b678-bc764e2007e4; Wed, 13 Nov 2019 15:44:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1573659881; h=from:to:cc:subject:date:message-id:mime-version; bh=aROPzjRY8yuRukXKGGPuwRuQNKqjf5MICkUUCwtrVlk=; b=Nzuwk2oMy0DALwI1ClyH/Ai8evLPPeD8uOOaWSpKXSQgWOdlwWO0meNT 5+yGf7nubiTyfcWAIRhNSheBPg5rxkjqR40wzRwZS3Bdf9vrUWc8maL5V bcOF9KoEMV6050uXHVXo6t/4Fl0tEmK5gUc4+W0sTFFqQEeVsyzKHRJow A=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=owen.smith@citrix.com; spf=Pass smtp.mailfrom=owen.smith@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of owen.smith@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="owen.smith@citrix.com"; x-sender="owen.smith@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of owen.smith@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="owen.smith@citrix.com"; x-sender="owen.smith@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="owen.smith@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: jxIV1iF3pWhjmf6EYrG2aeaz3bxDm2+CmAOJYJKThPBWSjrdfhG83DB1ybIU7E6tbYB0n8T5sm Jblqj7PAQ+tJjdvffp3bjByL4HxhXhQ78KV7PzQjAESfvh3WZn89rF6vkUbqt+R45Vjh6gETJi 6Ja+isCsLXFDpPZgpX8xuqQgscqemiLY0e3V1Jvt74Ua91UGjt7CSAzLjTh+Qtkkc6vZVyomd/ WGI4OJ8aptxoEeDp2TPhzkSaxHxGQ4quGN7hKpdMhVY4YyOIHs4iN4R/4vJkxo2/dqfxGDdz+2 MuM= X-SBRS: 2.7 X-MesageID: 8269632 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.68,300,1569297600"; d="scan'208";a="8269632" From: Owen Smith To: Date: Wed, 13 Nov 2019 15:43:54 +0000 Message-ID: <20191113154354.17192-1-owen.smith@citrix.com> X-Mailer: git-send-email 2.16.2.windows.1 MIME-Version: 1.0 Subject: [win-pv-devel] [PATCH] Reduce xenstore churn X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Owen Smith Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" T25seSB3cml0ZSB0aGUgY29tcGxldGUgY2hhbmdlcyB0byB0aGUgeGVuc3RvcmUgTUFDIGFkZHJl c3MgdGFibGUuIFRoZXJlCmlzIG5vIG5lZWQgdG8gd3JpdGUgdGhlIGNvbXBsZXRlIHRhYmxlIGZv ciBlYWNoIGFkZGl0aW9uIG9yIHJlbW92YWwsCndoZW4gYWRkaXRpb25zIGFuZCByZW1vdmFscyBh cmUgcHJvY2Vzc2VkIGluIGEgc2luZ2xlIHVwZGF0ZS4KClB1c2hlcyB0aGUgcmVzcG9uc2liaWxp dHkgZm9yIHdyaXRpbmcgdGhlIE1BQyB0YWJsZSB0bwpGcm9udGVuZFNldE11bHRpY2FzdEFkZHJl c3NlcygpIG9uY2UgYWxsIGNoYW5nZXMgYXJlIG1hZGUsIGluc3RlYWQgb2YKZm9yIGVhY2ggY2Fs bCB0byBNYWNBZGRNdWx0aWNhc3RBZGRyZXNzKCkgb3IgTWFjUmVtb3ZlTXVsdGljYXN0QWRkcmVz cygpCgpTaWduZWQtb2ZmLWJ5OiBPd2VuIFNtaXRoIDxvd2VuLnNtaXRoQGNpdHJpeC5jb20+Ci0t LQogc3JjL3hlbnZpZi9mcm9udGVuZC5jIHwgNyArKysrKysrCiBzcmMveGVudmlmL21hYy5jICAg ICAgfCA2ICstLS0tLQogc3JjL3hlbnZpZi9tYWMuaCAgICAgIHwgNSArKysrKwogMyBmaWxlcyBj aGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3Ny Yy94ZW52aWYvZnJvbnRlbmQuYyBiL3NyYy94ZW52aWYvZnJvbnRlbmQuYwppbmRleCAzZTMxNjU0 Li4wZWQ2OGRmIDEwMDY0NAotLS0gYS9zcmMveGVudmlmL2Zyb250ZW5kLmMKKysrIGIvc3JjL3hl bnZpZi9mcm9udGVuZC5jCkBAIC05ODksNiArOTg5LDcgQEAgRnJvbnRlbmRTZXRNdWx0aWNhc3RB ZGRyZXNzZXMoCiAgICAgVUxPTkcgICAgICAgICAgICAgICAgICAgTXVsdGljYXN0Q291bnQ7CiAg ICAgVUxPTkcgICAgICAgICAgICAgICAgICAgTXVsdGljYXN0SW5kZXg7CiAgICAgVUxPTkcgICAg ICAgICAgICAgICAgICAgSW5kZXg7CisgICAgQk9PTEVBTiAgICAgICAgICAgICAgICAgQ2hhbmdl OwogICAgIE5UU1RBVFVTICAgICAgICAgICAgICAgIHN0YXR1czsKIAogICAgIFRyYW5zbWl0dGVy ID0gRnJvbnRlbmRHZXRUcmFuc21pdHRlcihGcm9udGVuZCk7CkBAIC0xMDE1LDYgKzEwMTYsNyBA QCBGcm9udGVuZFNldE11bHRpY2FzdEFkZHJlc3NlcygKICAgICB9IGVsc2UKICAgICAgICAgTXVs dGljYXN0QWRkcmVzcyA9IE5VTEw7CiAKKyAgICBDaGFuZ2UgPSBGQUxTRTsKICAgICBmb3IgKElu ZGV4ID0gMDsgSW5kZXggPCBDb3VudDsgSW5kZXgrKykgewogICAgICAgICBCT09MRUFOIEZvdW5k OwogCkBAIC0xMDQyLDYgKzEwNDQsNyBAQCBGcm9udGVuZFNldE11bHRpY2FzdEFkZHJlc3NlcygK ICAgICAgICAgICAgIChWT0lEKSBUcmFuc21pdHRlclF1ZXVlTXVsdGljYXN0Q29udHJvbChUcmFu c21pdHRlciwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAmQWRkcmVzc1tJbmRleF0sCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgVFJVRSk7CisgICAgICAgICAgICBDaGFuZ2UgPSBUUlVFOwogICAg ICAgICB9CiAgICAgfQogCkBAIC0xMDU4LDExICsxMDYxLDE1IEBAIEZyb250ZW5kU2V0TXVsdGlj YXN0QWRkcmVzc2VzKAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgRkFMU0UpOwogICAgICAgICAoVk9JRCkgTWFjUmVtb3ZlTXVsdGljYXN0QWRkcmVzcyhN YWMsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZNdWx0aWNhc3RB ZGRyZXNzW011bHRpY2FzdEluZGV4XSk7CisgICAgICAgIENoYW5nZSA9IFRSVUU7CiAgICAgfQog CiAgICAgaWYgKE11bHRpY2FzdEFkZHJlc3MgIT0gTlVMTCkKICAgICAgICAgX19Gcm9udGVuZEZy ZWUoTXVsdGljYXN0QWRkcmVzcyk7CiAKKyAgICBpZiAoQ2hhbmdlKQorICAgICAgICAoVk9JRCkg TWFjRHVtcEFkZHJlc3NUYWJsZShNYWMpOworCiAgICAgS2VMb3dlcklycWwoSXJxbCk7CiAKICAg ICByZXR1cm4gU1RBVFVTX1NVQ0NFU1M7CmRpZmYgLS1naXQgYS9zcmMveGVudmlmL21hYy5jIGIv c3JjL3hlbnZpZi9tYWMuYwppbmRleCAwYjE3YTU0Li4xOTY2NmZlIDEwMDY0NAotLS0gYS9zcmMv eGVudmlmL21hYy5jCisrKyBiL3NyYy94ZW52aWYvbWFjLmMKQEAgLTI5NSw3ICsyOTUsNyBAQCBf X01hY1JlbGVhc2VMb2NrU2hhcmVkKAogICAgIEV4UmVsZWFzZVNwaW5Mb2NrU2hhcmVkRnJvbURw Y0xldmVsKCZNYWMtPkxvY2spOwogfQogCi1zdGF0aWMgTlRTVEFUVVMKK05UU1RBVFVTCiBNYWNE dW1wQWRkcmVzc1RhYmxlKAogICAgIElOICBQWEVOVklGX01BQyAgICAgTWFjCiAgICAgKQpAQCAt ODUyLDggKzg1Miw2IEBAIE1hY0FkZE11bHRpY2FzdEFkZHJlc3MoCiAgICAgX19NYWNSZWxlYXNl TG9ja0V4Y2x1c2l2ZShNYWMpOwogICAgIEtlTG93ZXJJcnFsKElycWwpOwogCi0gICAgKFZPSUQp IE1hY0R1bXBBZGRyZXNzVGFibGUoTWFjKTsKLQogICAgIFRyYWNlKCIlczogJTAyWDolMDJYOiUw Mlg6JTAyWDolMDJYOiUwMlhcbiIsCiAgICAgICAgICAgRnJvbnRlbmRHZXRQcmVmaXgoRnJvbnRl bmQpLAogICAgICAgICAgIEFkZHJlc3MtPkJ5dGVbMF0sCkBAIC05MTQsOCArOTEyLDYgQEAgZm91 bmQ6CiAgICAgX19NYWNSZWxlYXNlTG9ja0V4Y2x1c2l2ZShNYWMpOwogICAgIEtlTG93ZXJJcnFs KElycWwpOwogCi0gICAgKFZPSUQpIE1hY0R1bXBBZGRyZXNzVGFibGUoTWFjKTsKLQogICAgIFRy YWNlKCIlczogJTAyWDolMDJYOiUwMlg6JTAyWDolMDJYOiUwMlhcbiIsCiAgICAgICAgICAgRnJv bnRlbmRHZXRQcmVmaXgoRnJvbnRlbmQpLAogICAgICAgICAgIEFkZHJlc3MtPkJ5dGVbMF0sCmRp ZmYgLS1naXQgYS9zcmMveGVudmlmL21hYy5oIGIvc3JjL3hlbnZpZi9tYWMuaAppbmRleCA4M2Nl NWI4Li45MzQwZjAxIDEwMDY0NAotLS0gYS9zcmMveGVudmlmL21hYy5oCisrKyBiL3NyYy94ZW52 aWYvbWFjLmgKQEAgLTk1LDYgKzk1LDExIEBAIE1hY1F1ZXJ5QnJvYWRjYXN0QWRkcmVzcygKICAg ICBPVVQgUEVUSEVSTkVUX0FERFJFU1MgICBBZGRyZXNzICAgICAgICAgICAgICAgICAgIAogICAg ICk7CiAKK2V4dGVybiBOVFNUQVRVUworTWFjRHVtcEFkZHJlc3NUYWJsZSgKKyAgICBJTiAgUFhF TlZJRl9NQUMgICAgIE1hYworICAgICk7CisKIGV4dGVybiBOVFNUQVRVUwogTWFjQWRkTXVsdGlj YXN0QWRkcmVzcygKICAgICBJTiAgICAgIFBYRU5WSUZfTUFDICAgICAgICAgTWFjLAotLSAKMi4x Ni4yLndpbmRvd3MuMQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCndpbi1wdi1kZXZlbCBtYWlsaW5nIGxpc3QKd2luLXB2LWRldmVsQGxpc3RzLnhlbnBy b2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby93 aW4tcHYtZGV2ZWw= From win-pv-devel-bounces@lists.xenproject.org Thu Nov 14 09:48:59 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 14 Nov 2019 09:48:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVBkG-0005Hn-2N; Thu, 14 Nov 2019 09:48:56 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVBkF-0005Hh-HY for win-pv-devel@lists.xenproject.org; Thu, 14 Nov 2019 09:48:55 +0000 X-Inumbo-ID: f878770c-06c3-11ea-b678-bc764e2007e4 Received: from mail-pf1-x442.google.com (unknown [2607:f8b0:4864:20::442]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f878770c-06c3-11ea-b678-bc764e2007e4; Thu, 14 Nov 2019 09:48:54 +0000 (UTC) Received: by mail-pf1-x442.google.com with SMTP id b19so3853442pfd.3 for ; Thu, 14 Nov 2019 01:48:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ACXuI1a+sId47AqAgNrMtxyqGxyVMM98+U6tqZUCpG4=; b=C+IFr8cWYloOFP7izaAVhJ9CCErCp4Q45ia1dBE9ueEfDFSzDD8+vNJ8TL0jMrACvy tV1qC3uetuRMEtbUqAorVJ1t/OwN3BwyS01l+c0YfBv1kEOxwnonLSHIWOq5XHP3CKLY M9rmTKLan4BuBqvQQ43DRTW9Maewg6S1otngVa0o70bXBS8wlngLNKrE2NU2LsZ1hHPV iCnZgMm4iiCzCs6En3OjNFIuEMX1p7IFFsWVVyI4oZcclbJRwJlwCDVzOtdCf/iK77tc +as/jFE0BRj0F9VF3MBaPguX+tJrj1HGnUn5IKbEm0hQIKmrNQ+83136h89LHsa1CHNP vaqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ACXuI1a+sId47AqAgNrMtxyqGxyVMM98+U6tqZUCpG4=; b=q/9EQnoSzmxeYbevWb3H73Yh18GuSqQE1ZyPgp8u2MbvtXVbyUcy6fP1gNTsM+h2St v7PExOOAclYd3ykYPqpS1Fh6E2Y32UIjfIJOKpToZgiE4cM35M6pb7amnxZQuJnJEjiQ I4nQVoPnbZUqIVIs82nv6VDJ/hhOq/XXMryn9fmpQQ2efcJbEVLFDlPUjRb/i/8nT8kp Twg88qRmz8LU65CWSdw3fG3KR1JSnZ8adKdMFbjpS1s6VtWbSoanCyqNxom8/EN+DhPo HU+EwCBp9y5G4UUZMWLKXiCnC8NVfxCh0s47/+K6nRRTPL9tZha7uyMkpbfGVdWlF4PC CdmQ== X-Gm-Message-State: APjAAAVAqB/DmRRlsJl2CHqQI0GcpJrEmLtl1DYgh5DtIV+6XeW4Xe8l V3y3SWKYHvZOlmzPW/JdLECnmpLq70wL7ENBlCQ= X-Google-Smtp-Source: APXvYqx/7o0h2qNqrv/DOx7VO7oGWhIaSqL8jk1lLlqT5/mz9Fws3Bd3skFXVgire+gGH4utn2nagCTHaTIzelgwqeo= X-Received: by 2002:a63:4e5e:: with SMTP id o30mr9547529pgl.112.1573724933902; Thu, 14 Nov 2019 01:48:53 -0800 (PST) MIME-Version: 1.0 References: <20191113154354.17192-1-owen.smith@citrix.com> In-Reply-To: <20191113154354.17192-1-owen.smith@citrix.com> From: Paul Durrant Date: Thu, 14 Nov 2019 09:48:42 +0000 Message-ID: To: Owen Smith Subject: Re: [win-pv-devel] [PATCH] Reduce xenstore churn X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: win-pv-devel@lists.xenproject.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" T24gV2VkLCAxMyBOb3YgMjAxOSBhdCAxNTo0NCwgT3dlbiBTbWl0aCA8b3dlbi5zbWl0aEBjaXRy aXguY29tPiB3cm90ZToKPgo+IE9ubHkgd3JpdGUgdGhlIGNvbXBsZXRlIGNoYW5nZXMgdG8gdGhl IHhlbnN0b3JlIE1BQyBhZGRyZXNzIHRhYmxlLiBUaGVyZQo+IGlzIG5vIG5lZWQgdG8gd3JpdGUg dGhlIGNvbXBsZXRlIHRhYmxlIGZvciBlYWNoIGFkZGl0aW9uIG9yIHJlbW92YWwsCj4gd2hlbiBh ZGRpdGlvbnMgYW5kIHJlbW92YWxzIGFyZSBwcm9jZXNzZWQgaW4gYSBzaW5nbGUgdXBkYXRlLgo+ Cj4gUHVzaGVzIHRoZSByZXNwb25zaWJpbGl0eSBmb3Igd3JpdGluZyB0aGUgTUFDIHRhYmxlIHRv Cj4gRnJvbnRlbmRTZXRNdWx0aWNhc3RBZGRyZXNzZXMoKSBvbmNlIGFsbCBjaGFuZ2VzIGFyZSBt YWRlLCBpbnN0ZWFkIG9mCj4gZm9yIGVhY2ggY2FsbCB0byBNYWNBZGRNdWx0aWNhc3RBZGRyZXNz KCkgb3IgTWFjUmVtb3ZlTXVsdGljYXN0QWRkcmVzcygpCj4KPiBTaWduZWQtb2ZmLWJ5OiBPd2Vu IFNtaXRoIDxvd2VuLnNtaXRoQGNpdHJpeC5jb20+CgpBY2tlZC1ieTogUGF1bCBEdXJyYW50IDxw YXVsQHhlbi5vcmc+Cgo+IC0tLQo+ICBzcmMveGVudmlmL2Zyb250ZW5kLmMgfCA3ICsrKysrKysK PiAgc3JjL3hlbnZpZi9tYWMuYyAgICAgIHwgNiArLS0tLS0KPiAgc3JjL3hlbnZpZi9tYWMuaCAg ICAgIHwgNSArKysrKwo+ICAzIGZpbGVzIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDUgZGVs ZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvc3JjL3hlbnZpZi9mcm9udGVuZC5jIGIvc3JjL3hl bnZpZi9mcm9udGVuZC5jCj4gaW5kZXggM2UzMTY1NC4uMGVkNjhkZiAxMDA2NDQKPiAtLS0gYS9z cmMveGVudmlmL2Zyb250ZW5kLmMKPiArKysgYi9zcmMveGVudmlmL2Zyb250ZW5kLmMKPiBAQCAt OTg5LDYgKzk4OSw3IEBAIEZyb250ZW5kU2V0TXVsdGljYXN0QWRkcmVzc2VzKAo+ICAgICAgVUxP TkcgICAgICAgICAgICAgICAgICAgTXVsdGljYXN0Q291bnQ7Cj4gICAgICBVTE9ORyAgICAgICAg ICAgICAgICAgICBNdWx0aWNhc3RJbmRleDsKPiAgICAgIFVMT05HICAgICAgICAgICAgICAgICAg IEluZGV4Owo+ICsgICAgQk9PTEVBTiAgICAgICAgICAgICAgICAgQ2hhbmdlOwo+ICAgICAgTlRT VEFUVVMgICAgICAgICAgICAgICAgc3RhdHVzOwo+Cj4gICAgICBUcmFuc21pdHRlciA9IEZyb250 ZW5kR2V0VHJhbnNtaXR0ZXIoRnJvbnRlbmQpOwo+IEBAIC0xMDE1LDYgKzEwMTYsNyBAQCBGcm9u dGVuZFNldE11bHRpY2FzdEFkZHJlc3NlcygKPiAgICAgIH0gZWxzZQo+ICAgICAgICAgIE11bHRp Y2FzdEFkZHJlc3MgPSBOVUxMOwo+Cj4gKyAgICBDaGFuZ2UgPSBGQUxTRTsKPiAgICAgIGZvciAo SW5kZXggPSAwOyBJbmRleCA8IENvdW50OyBJbmRleCsrKSB7Cj4gICAgICAgICAgQk9PTEVBTiBG b3VuZDsKPgo+IEBAIC0xMDQyLDYgKzEwNDQsNyBAQCBGcm9udGVuZFNldE11bHRpY2FzdEFkZHJl c3NlcygKPiAgICAgICAgICAgICAgKFZPSUQpIFRyYW5zbWl0dGVyUXVldWVNdWx0aWNhc3RDb250 cm9sKFRyYW5zbWl0dGVyLAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgJkFkZHJlc3NbSW5kZXhdLAo+ICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgVFJVRSk7Cj4gKyAgICAgICAgICAgIENoYW5n ZSA9IFRSVUU7Cj4gICAgICAgICAgfQo+ICAgICAgfQo+Cj4gQEAgLTEwNTgsMTEgKzEwNjEsMTUg QEAgRnJvbnRlbmRTZXRNdWx0aWNhc3RBZGRyZXNzZXMoCj4gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIEZBTFNFKTsKPiAgICAgICAgICAoVk9JRCkgTWFj UmVtb3ZlTXVsdGljYXN0QWRkcmVzcyhNYWMsCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgJk11bHRpY2FzdEFkZHJlc3NbTXVsdGljYXN0SW5kZXhdKTsKPiArICAg ICAgICBDaGFuZ2UgPSBUUlVFOwo+ICAgICAgfQo+Cj4gICAgICBpZiAoTXVsdGljYXN0QWRkcmVz cyAhPSBOVUxMKQo+ICAgICAgICAgIF9fRnJvbnRlbmRGcmVlKE11bHRpY2FzdEFkZHJlc3MpOwo+ Cj4gKyAgICBpZiAoQ2hhbmdlKQo+ICsgICAgICAgIChWT0lEKSBNYWNEdW1wQWRkcmVzc1RhYmxl KE1hYyk7Cj4gKwo+ICAgICAgS2VMb3dlcklycWwoSXJxbCk7Cj4KPiAgICAgIHJldHVybiBTVEFU VVNfU1VDQ0VTUzsKPiBkaWZmIC0tZ2l0IGEvc3JjL3hlbnZpZi9tYWMuYyBiL3NyYy94ZW52aWYv bWFjLmMKPiBpbmRleCAwYjE3YTU0Li4xOTY2NmZlIDEwMDY0NAo+IC0tLSBhL3NyYy94ZW52aWYv bWFjLmMKPiArKysgYi9zcmMveGVudmlmL21hYy5jCj4gQEAgLTI5NSw3ICsyOTUsNyBAQCBfX01h Y1JlbGVhc2VMb2NrU2hhcmVkKAo+ICAgICAgRXhSZWxlYXNlU3BpbkxvY2tTaGFyZWRGcm9tRHBj TGV2ZWwoJk1hYy0+TG9jayk7Cj4gIH0KPgo+IC1zdGF0aWMgTlRTVEFUVVMKPiArTlRTVEFUVVMK PiAgTWFjRHVtcEFkZHJlc3NUYWJsZSgKPiAgICAgIElOICBQWEVOVklGX01BQyAgICAgTWFjCj4g ICAgICApCj4gQEAgLTg1Miw4ICs4NTIsNiBAQCBNYWNBZGRNdWx0aWNhc3RBZGRyZXNzKAo+ICAg ICAgX19NYWNSZWxlYXNlTG9ja0V4Y2x1c2l2ZShNYWMpOwo+ICAgICAgS2VMb3dlcklycWwoSXJx bCk7Cj4KPiAtICAgIChWT0lEKSBNYWNEdW1wQWRkcmVzc1RhYmxlKE1hYyk7Cj4gLQo+ICAgICAg VHJhY2UoIiVzOiAlMDJYOiUwMlg6JTAyWDolMDJYOiUwMlg6JTAyWFxuIiwKPiAgICAgICAgICAg IEZyb250ZW5kR2V0UHJlZml4KEZyb250ZW5kKSwKPiAgICAgICAgICAgIEFkZHJlc3MtPkJ5dGVb MF0sCj4gQEAgLTkxNCw4ICs5MTIsNiBAQCBmb3VuZDoKPiAgICAgIF9fTWFjUmVsZWFzZUxvY2tF eGNsdXNpdmUoTWFjKTsKPiAgICAgIEtlTG93ZXJJcnFsKElycWwpOwo+Cj4gLSAgICAoVk9JRCkg TWFjRHVtcEFkZHJlc3NUYWJsZShNYWMpOwo+IC0KPiAgICAgIFRyYWNlKCIlczogJTAyWDolMDJY OiUwMlg6JTAyWDolMDJYOiUwMlhcbiIsCj4gICAgICAgICAgICBGcm9udGVuZEdldFByZWZpeChG cm9udGVuZCksCj4gICAgICAgICAgICBBZGRyZXNzLT5CeXRlWzBdLAo+IGRpZmYgLS1naXQgYS9z cmMveGVudmlmL21hYy5oIGIvc3JjL3hlbnZpZi9tYWMuaAo+IGluZGV4IDgzY2U1YjguLjkzNDBm MDEgMTAwNjQ0Cj4gLS0tIGEvc3JjL3hlbnZpZi9tYWMuaAo+ICsrKyBiL3NyYy94ZW52aWYvbWFj LmgKPiBAQCAtOTUsNiArOTUsMTEgQEAgTWFjUXVlcnlCcm9hZGNhc3RBZGRyZXNzKAo+ICAgICAg T1VUIFBFVEhFUk5FVF9BRERSRVNTICAgQWRkcmVzcwo+ICAgICAgKTsKPgo+ICtleHRlcm4gTlRT VEFUVVMKPiArTWFjRHVtcEFkZHJlc3NUYWJsZSgKPiArICAgIElOICBQWEVOVklGX01BQyAgICAg TWFjCj4gKyAgICApOwo+ICsKPiAgZXh0ZXJuIE5UU1RBVFVTCj4gIE1hY0FkZE11bHRpY2FzdEFk ZHJlc3MoCj4gICAgICBJTiAgICAgIFBYRU5WSUZfTUFDICAgICAgICAgTWFjLAo+IC0tCj4gMi4x Ni4yLndpbmRvd3MuMQo+Cj4KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwo+IHdpbi1wdi1kZXZlbCBtYWlsaW5nIGxpc3QKPiB3aW4tcHYtZGV2ZWxAbGlz dHMueGVucHJvamVjdC5vcmcKPiBodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4v bGlzdGluZm8vd2luLXB2LWRldmVsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwp3aW4tcHYtZGV2ZWwgbWFpbGluZyBsaXN0Cndpbi1wdi1kZXZlbEBsaXN0 cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlz dGluZm8vd2luLXB2LWRldmVs From win-pv-devel-bounces@lists.xenproject.org Thu Nov 14 10:13:50 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 14 Nov 2019 10:13:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVC8M-00084w-43; Thu, 14 Nov 2019 10:13:50 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVC8K-00084q-U1 for win-pv-devel@lists.xenproject.org; Thu, 14 Nov 2019 10:13:48 +0000 X-Inumbo-ID: 710ba8e4-06c7-11ea-a247-12813bfff9fa Received: from smtp-fw-4101.amazon.com (unknown [72.21.198.25]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 710ba8e4-06c7-11ea-a247-12813bfff9fa; Thu, 14 Nov 2019 10:13:45 +0000 (UTC) IronPort-SDR: S9hxFuIvfXgzC3xubfVh+DPci5kLvlKtBc5+uIJc2VbtYjBGltGCo5cEqjE+f9XFInon1fr0qI 25dzoadV4rCQ== X-IronPort-AV: E=Sophos;i="5.68,304,1569283200"; d="scan'208";a="3848740" Received: from iad6-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-1d-37fd6b3d.us-east-1.amazon.com) ([10.124.125.6]) by smtp-border-fw-out-4101.iad4.amazon.com with ESMTP; 14 Nov 2019 10:13:45 +0000 Received: from EX13MTAUEA001.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan3.iad.amazon.com [10.40.159.166]) by email-inbound-relay-1d-37fd6b3d.us-east-1.amazon.com (Postfix) with ESMTPS id CD07B282047 for ; Thu, 14 Nov 2019 10:13:44 +0000 (UTC) Received: from EX13D32EUC003.ant.amazon.com (10.43.164.24) by EX13MTAUEA001.ant.amazon.com (10.43.61.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 14 Nov 2019 10:13:43 +0000 Received: from EX13MTAUEB001.ant.amazon.com (10.43.60.96) by EX13D32EUC003.ant.amazon.com (10.43.164.24) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 14 Nov 2019 10:13:42 +0000 Received: from CBG-5CG9341D0C.cbg10.amazon.com (10.55.227.12) by mail-relay.amazon.com (10.43.60.129) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Thu, 14 Nov 2019 10:13:41 +0000 From: To: Date: Thu, 14 Nov 2019 10:13:26 +0000 Message-ID: <20191114101326.2147-1-paul@xen.org> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Subject: [win-pv-devel] [PATCH] MAINTAINERS: Update my email address X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Paul Durrant Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" RnJvbTogUGF1bCBEdXJyYW50IDxwZHVycmFudEBhbWF6b24uY29tPgoKU2lnbmVkLW9mZi1ieTog UGF1bCBEdXJyYW50IDxwZHVycmFudEBhbWF6b24uY29tPgotLS0KIE1BSU5UQUlORVJTIHwgMiAr LQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0t Z2l0IGEvTUFJTlRBSU5FUlMgYi9NQUlOVEFJTkVSUwppbmRleCA1ZjFhNjcwLi5hNmJlMDI0IDEw MDY0NAotLS0gYS9NQUlOVEFJTkVSUworKysgYi9NQUlOVEFJTkVSUwpAQCAtNDMsNyArNDMsNyBA QCBXZSBhbHNvIHJlcXVlc3QgeW91IGZvbGxvdyB0aGVzZSBiYXNpYyBndWlkZWxpbmVzOgogTWFp bnRhaW5lcnMgTGlzdAogLS0tLS0tLS0tLS0tLS0tLQogCi0qIFBhdWwgRHVycmFudCA8cGF1bEB4 ZW4ub3JnPgorKiBQYXVsIER1cnJhbnQgPHBkdXJyYW50QGFtYXpvbi5jb20+CiAKICogQmVuIENo YWxtZXJzIDxiZW4uY2hhbG1lcnNAY2l0cml4LmNvbT4KIAotLSAKMi4xNy4xCgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Kd2luLXB2LWRldmVsIG1haWxp bmcgbGlzdAp3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54 ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3dpbi1wdi1kZXZlbA== From win-pv-devel-bounces@lists.xenproject.org Thu Nov 14 10:23:40 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 14 Nov 2019 10:23:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVCHq-0000Y0-SU; Thu, 14 Nov 2019 10:23:38 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVCHp-0000Xv-KH for win-pv-devel@lists.xenproject.org; Thu, 14 Nov 2019 10:23:37 +0000 X-Inumbo-ID: d0ac3416-06c8-11ea-a247-12813bfff9fa Received: from smtp-fw-33001.amazon.com (unknown [207.171.190.10]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d0ac3416-06c8-11ea-a247-12813bfff9fa; Thu, 14 Nov 2019 10:23:35 +0000 (UTC) IronPort-SDR: rCCkg0H5k237TeGLyaJkOVrYauAa4WgcO6wvsI/0gKg2uWQrZ9yNyM+6zBS9t6MfQZREqEpIOq /r4fkQPut3vw== X-IronPort-AV: E=Sophos;i="5.68,304,1569283200"; d="scan'208";a="7569389" Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-2c-1968f9fa.us-west-2.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-33001.sea14.amazon.com with ESMTP; 14 Nov 2019 10:23:35 +0000 Received: from EX13MTAUEA001.ant.amazon.com (pdx4-ws-svc-p6-lb7-vlan3.pdx.amazon.com [10.170.41.166]) by email-inbound-relay-2c-1968f9fa.us-west-2.amazon.com (Postfix) with ESMTPS id A1938A2685 for ; Thu, 14 Nov 2019 10:23:34 +0000 (UTC) Received: from EX13D32EUC004.ant.amazon.com (10.43.164.121) by EX13MTAUEA001.ant.amazon.com (10.43.61.243) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 14 Nov 2019 10:23:34 +0000 Received: from EX13MTAUWC001.ant.amazon.com (10.43.162.135) by EX13D32EUC004.ant.amazon.com (10.43.164.121) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 14 Nov 2019 10:23:32 +0000 Received: from CBG-5CG9341D0C.cbg10.amazon.com (10.55.227.12) by mail-relay.amazon.com (10.43.162.232) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Thu, 14 Nov 2019 10:23:30 +0000 From: To: Date: Thu, 14 Nov 2019 10:23:21 +0000 Message-ID: <20191114102321.2269-1-paul@xen.org> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Subject: [win-pv-devel] [PATCH xenvif] MAINTAINERS: Update my email address X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Paul Durrant Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" RnJvbTogUGF1bCBEdXJyYW50IDxwZHVycmFudEBhbWF6b24uY29tPgoKU2lnbmVkLW9mZi1ieTog UGF1bCBEdXJyYW50IDxwZHVycmFudEBhbWF6b24uY29tPgotLS0KIE1BSU5UQUlORVJTIHwgMiAr LQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0t Z2l0IGEvTUFJTlRBSU5FUlMgYi9NQUlOVEFJTkVSUwppbmRleCA1ZjFhNjcwLi5hNmJlMDI0IDEw MDY0NAotLS0gYS9NQUlOVEFJTkVSUworKysgYi9NQUlOVEFJTkVSUwpAQCAtNDMsNyArNDMsNyBA QCBXZSBhbHNvIHJlcXVlc3QgeW91IGZvbGxvdyB0aGVzZSBiYXNpYyBndWlkZWxpbmVzOgogTWFp bnRhaW5lcnMgTGlzdAogLS0tLS0tLS0tLS0tLS0tLQogCi0qIFBhdWwgRHVycmFudCA8cGF1bEB4 ZW4ub3JnPgorKiBQYXVsIER1cnJhbnQgPHBkdXJyYW50QGFtYXpvbi5jb20+CiAKICogQmVuIENo YWxtZXJzIDxiZW4uY2hhbG1lcnNAY2l0cml4LmNvbT4KIAotLSAKMi4xNy4xCgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Kd2luLXB2LWRldmVsIG1haWxp bmcgbGlzdAp3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54 ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3dpbi1wdi1kZXZlbA== From win-pv-devel-bounces@lists.xenproject.org Thu Nov 14 10:37:25 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 14 Nov 2019 10:37:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVCVA-0001iG-Fc; Thu, 14 Nov 2019 10:37:24 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVCV9-0001iB-BI for win-pv-devel@lists.xenproject.org; Thu, 14 Nov 2019 10:37:23 +0000 X-Inumbo-ID: bcebe5d2-06ca-11ea-a247-12813bfff9fa Received: from smtp-fw-33001.amazon.com (unknown [207.171.190.10]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id bcebe5d2-06ca-11ea-a247-12813bfff9fa; Thu, 14 Nov 2019 10:37:21 +0000 (UTC) IronPort-SDR: nDJFm72lD9cx3QrCJAwO2O3u70x0s8YCsr+UoMbQIS9iQcmUXamYsxMYnQGv7mQa9Df5HAy1KN LC4/kgPjOt+A== X-IronPort-AV: E=Sophos;i="5.68,304,1569283200"; d="scan'208";a="7573821" Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-1a-67b371d8.us-east-1.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-33001.sea14.amazon.com with ESMTP; 14 Nov 2019 10:37:21 +0000 Received: from EX13MTAUEA001.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan2.iad.amazon.com [10.40.159.162]) by email-inbound-relay-1a-67b371d8.us-east-1.amazon.com (Postfix) with ESMTPS id 54C74A28E9 for ; Thu, 14 Nov 2019 10:37:19 +0000 (UTC) Received: from EX13D32EUC003.ant.amazon.com (10.43.164.24) by EX13MTAUEA001.ant.amazon.com (10.43.61.243) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 14 Nov 2019 10:37:19 +0000 Received: from EX13MTAUWC001.ant.amazon.com (10.43.162.135) by EX13D32EUC003.ant.amazon.com (10.43.164.24) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 14 Nov 2019 10:37:17 +0000 Received: from CBG-5CG9341D0C.cbg10.amazon.com (10.55.227.12) by mail-relay.amazon.com (10.43.162.232) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Thu, 14 Nov 2019 10:37:15 +0000 From: To: Date: Thu, 14 Nov 2019 10:37:10 +0000 Message-ID: <20191114103710.2325-1-paul@xen.org> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Subject: [win-pv-devel] [PATCH xennet] MAINTAINERS: Update my email address X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Paul Durrant Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" RnJvbTogUGF1bCBEdXJyYW50IDxwZHVycmFudEBhbWF6b24uY29tPgoKU2lnbmVkLW9mZi1ieTog UGF1bCBEdXJyYW50IDxwZHVycmFudEBhbWF6b24uY29tPgotLS0KIE1BSU5UQUlORVJTIHwgMiAr LQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0t Z2l0IGEvTUFJTlRBSU5FUlMgYi9NQUlOVEFJTkVSUwppbmRleCA1ZjFhNjcwLi5hNmJlMDI0IDEw MDY0NAotLS0gYS9NQUlOVEFJTkVSUworKysgYi9NQUlOVEFJTkVSUwpAQCAtNDMsNyArNDMsNyBA QCBXZSBhbHNvIHJlcXVlc3QgeW91IGZvbGxvdyB0aGVzZSBiYXNpYyBndWlkZWxpbmVzOgogTWFp bnRhaW5lcnMgTGlzdAogLS0tLS0tLS0tLS0tLS0tLQogCi0qIFBhdWwgRHVycmFudCA8cGF1bEB4 ZW4ub3JnPgorKiBQYXVsIER1cnJhbnQgPHBkdXJyYW50QGFtYXpvbi5jb20+CiAKICogQmVuIENo YWxtZXJzIDxiZW4uY2hhbG1lcnNAY2l0cml4LmNvbT4KIAotLSAKMi4xNy4xCgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Kd2luLXB2LWRldmVsIG1haWxp bmcgbGlzdAp3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54 ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3dpbi1wdi1kZXZlbA== From win-pv-devel-bounces@lists.xenproject.org Thu Nov 14 10:38:30 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 14 Nov 2019 10:38:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVCWE-0001lG-Jo; Thu, 14 Nov 2019 10:38:30 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVCWD-0001lB-Ca for win-pv-devel@lists.xenproject.org; Thu, 14 Nov 2019 10:38:29 +0000 X-Inumbo-ID: e4e94c1f-06ca-11ea-a247-12813bfff9fa Received: from smtp-fw-33001.amazon.com (unknown [207.171.190.10]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e4e94c1f-06ca-11ea-a247-12813bfff9fa; Thu, 14 Nov 2019 10:38:28 +0000 (UTC) IronPort-SDR: zS/dTX3IV66z8LpTft0hFyVCKUwPmi60ybF5i3CD7pTMGJHN4AaZRWyf99Sjohf50ccXIW1tDp Kpky/cDYMnQQ== X-IronPort-AV: E=Sophos;i="5.68,304,1569283200"; d="scan'208";a="7574289" Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-2b-baacba05.us-west-2.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-33001.sea14.amazon.com with ESMTP; 14 Nov 2019 10:38:28 +0000 Received: from EX13MTAUEA001.ant.amazon.com (pdx4-ws-svc-p6-lb7-vlan2.pdx.amazon.com [10.170.41.162]) by email-inbound-relay-2b-baacba05.us-west-2.amazon.com (Postfix) with ESMTPS id BAAFAA1BC6 for ; Thu, 14 Nov 2019 10:38:27 +0000 (UTC) Received: from EX13D32EUB001.ant.amazon.com (10.43.166.125) by EX13MTAUEA001.ant.amazon.com (10.43.61.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 14 Nov 2019 10:38:27 +0000 Received: from EX13MTAUWA001.ant.amazon.com (10.43.160.58) by EX13D32EUB001.ant.amazon.com (10.43.166.125) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 14 Nov 2019 10:38:25 +0000 Received: from CBG-5CG9341D0C.cbg10.amazon.com (10.55.227.12) by mail-relay.amazon.com (10.43.160.118) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Thu, 14 Nov 2019 10:38:23 +0000 From: To: Date: Thu, 14 Nov 2019 10:38:14 +0000 Message-ID: <20191114103814.2377-1-paul@xen.org> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Subject: [win-pv-devel] [PATCH xeniface] MAINTAINERS: Update my email address X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Paul Durrant Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" RnJvbTogUGF1bCBEdXJyYW50IDxwZHVycmFudEBhbWF6b24uY29tPgoKU2lnbmVkLW9mZi1ieTog UGF1bCBEdXJyYW50IDxwZHVycmFudEBhbWF6b24uY29tPgotLS0KIE1BSU5UQUlORVJTIHwgMiAr LQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0t Z2l0IGEvTUFJTlRBSU5FUlMgYi9NQUlOVEFJTkVSUwppbmRleCA1ZjFhNjcwLi5hNmJlMDI0IDEw MDY0NAotLS0gYS9NQUlOVEFJTkVSUworKysgYi9NQUlOVEFJTkVSUwpAQCAtNDMsNyArNDMsNyBA QCBXZSBhbHNvIHJlcXVlc3QgeW91IGZvbGxvdyB0aGVzZSBiYXNpYyBndWlkZWxpbmVzOgogTWFp bnRhaW5lcnMgTGlzdAogLS0tLS0tLS0tLS0tLS0tLQogCi0qIFBhdWwgRHVycmFudCA8cGF1bEB4 ZW4ub3JnPgorKiBQYXVsIER1cnJhbnQgPHBkdXJyYW50QGFtYXpvbi5jb20+CiAKICogQmVuIENo YWxtZXJzIDxiZW4uY2hhbG1lcnNAY2l0cml4LmNvbT4KIAotLSAKMi4xNy4xCgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Kd2luLXB2LWRldmVsIG1haWxp bmcgbGlzdAp3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54 ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3dpbi1wdi1kZXZlbA== From win-pv-devel-bounces@lists.xenproject.org Thu Nov 14 10:39:07 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 14 Nov 2019 10:39:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVCWp-0001n1-Mn; Thu, 14 Nov 2019 10:39:07 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVCWn-0001mw-UT for win-pv-devel@lists.xenproject.org; Thu, 14 Nov 2019 10:39:05 +0000 X-Inumbo-ID: fa03856a-06ca-11ea-a247-12813bfff9fa Received: from smtp-fw-33001.amazon.com (unknown [207.171.190.10]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id fa03856a-06ca-11ea-a247-12813bfff9fa; Thu, 14 Nov 2019 10:39:04 +0000 (UTC) IronPort-SDR: rry+6RMYd11uxTD8Lp8MeImCXzmVhEnlZjSvU9qTBS0mhbc58jhSlSZwp+X8y4tvi+Uv0PyGAx S/2g9w/mrlQA== X-IronPort-AV: E=Sophos;i="5.68,304,1569283200"; d="scan'208";a="7574680" Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-2c-168cbb73.us-west-2.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-33001.sea14.amazon.com with ESMTP; 14 Nov 2019 10:39:04 +0000 Received: from EX13MTAUEA001.ant.amazon.com (pdx4-ws-svc-p6-lb7-vlan2.pdx.amazon.com [10.170.41.162]) by email-inbound-relay-2c-168cbb73.us-west-2.amazon.com (Postfix) with ESMTPS id 28585A1DCF for ; Thu, 14 Nov 2019 10:39:03 +0000 (UTC) Received: from EX13D32EUC004.ant.amazon.com (10.43.164.121) by EX13MTAUEA001.ant.amazon.com (10.43.61.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 14 Nov 2019 10:39:02 +0000 Received: from EX13MTAUWB001.ant.amazon.com (10.43.161.207) by EX13D32EUC004.ant.amazon.com (10.43.164.121) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 14 Nov 2019 10:39:01 +0000 Received: from CBG-5CG9341D0C.cbg10.amazon.com (10.55.227.12) by mail-relay.amazon.com (10.43.161.249) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Thu, 14 Nov 2019 10:38:58 +0000 From: To: Date: Thu, 14 Nov 2019 10:38:57 +0000 Message-ID: <20191114103857.2430-1-paul@xen.org> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Subject: [win-pv-devel] [PATCH xencons] MAINTAINERS: Update my email address X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Paul Durrant Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" RnJvbTogUGF1bCBEdXJyYW50IDxwZHVycmFudEBhbWF6b24uY29tPgoKU2lnbmVkLW9mZi1ieTog UGF1bCBEdXJyYW50IDxwZHVycmFudEBhbWF6b24uY29tPgotLS0KIE1BSU5UQUlORVJTIHwgMiAr LQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0t Z2l0IGEvTUFJTlRBSU5FUlMgYi9NQUlOVEFJTkVSUwppbmRleCBkNjY4NDMyLi4yYzlkOTg2IDEw MDY0NAotLS0gYS9NQUlOVEFJTkVSUworKysgYi9NQUlOVEFJTkVSUwpAQCAtNDMsNyArNDMsNyBA QCBXZSBhbHNvIHJlcXVlc3QgeW91IGZvbGxvdyB0aGVzZSBiYXNpYyBndWlkZWxpbmVzOgogTWFp bnRhaW5lcnMgTGlzdAogLS0tLS0tLS0tLS0tLS0tLQogCi0qIFBhdWwgRHVycmFudCA8cGF1bEB4 ZW4ub3JnPgorKiBQYXVsIER1cnJhbnQgPHBkdXJyYW50QGFtYXpvbi5jb20+CiAKICogQmVuIENo YWxtZXJzIDxiZW4uY2hhbG1lcnNAY2l0cml4LmNvbT4KIAotLSAKMi4xNy4xCgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Kd2luLXB2LWRldmVsIG1haWxp bmcgbGlzdAp3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54 ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3dpbi1wdi1kZXZlbA== From win-pv-devel-bounces@lists.xenproject.org Thu Nov 14 10:40:30 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 14 Nov 2019 10:40:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVCY9-0002QV-Rw; Thu, 14 Nov 2019 10:40:29 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVCY8-0002QQ-22 for win-pv-devel@lists.xenproject.org; Thu, 14 Nov 2019 10:40:28 +0000 X-Inumbo-ID: 2b994d80-06cb-11ea-a247-12813bfff9fa Received: from smtp-fw-6002.amazon.com (unknown [52.95.49.90]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2b994d80-06cb-11ea-a247-12813bfff9fa; Thu, 14 Nov 2019 10:40:26 +0000 (UTC) IronPort-SDR: 8bGMuKI26oaInDeTIrqd7c0UERlWmaQZmZdeCbdedhNu3bLe/DfvSx9C9xHnenEVjkn+wlbnvv o38iU/Ud0dMA== Received: from iad6-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-2b-55156cd4.us-west-2.amazon.com) ([10.124.125.6]) by smtp-border-fw-out-6002.iad6.amazon.com with ESMTP; 14 Nov 2019 10:40:26 +0000 Received: from EX13MTAUEA001.ant.amazon.com (pdx4-ws-svc-p6-lb7-vlan2.pdx.amazon.com [10.170.41.162]) by email-inbound-relay-2b-55156cd4.us-west-2.amazon.com (Postfix) with ESMTPS id A3AB1A1B7F for ; Thu, 14 Nov 2019 10:40:25 +0000 (UTC) Received: from EX13D32EUC003.ant.amazon.com (10.43.164.24) by EX13MTAUEA001.ant.amazon.com (10.43.61.243) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 14 Nov 2019 10:40:24 +0000 Received: from EX13MTAUEB001.ant.amazon.com (10.43.60.96) by EX13D32EUC003.ant.amazon.com (10.43.164.24) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 14 Nov 2019 10:40:23 +0000 Received: from CBG-5CG9341D0C.cbg10.amazon.com (10.55.227.12) by mail-relay.amazon.com (10.43.60.129) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Thu, 14 Nov 2019 10:40:22 +0000 From: To: Date: Thu, 14 Nov 2019 10:40:15 +0000 Message-ID: <20191114104015.2482-1-paul@xen.org> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Subject: [win-pv-devel] [PATCH xenhid] MAINTAINERS: Update my email address X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Paul Durrant Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" RnJvbTogUGF1bCBEdXJyYW50IDxwZHVycmFudEBhbWF6b24uY29tPgoKU2lnbmVkLW9mZi1ieTog UGF1bCBEdXJyYW50IDxwZHVycmFudEBhbWF6b24uY29tPgotLS0KIE1BSU5UQUlORVJTIHwgMiAr LQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0t Z2l0IGEvTUFJTlRBSU5FUlMgYi9NQUlOVEFJTkVSUwppbmRleCBkNjY4NDMyLi4yYzlkOTg2IDEw MDY0NAotLS0gYS9NQUlOVEFJTkVSUworKysgYi9NQUlOVEFJTkVSUwpAQCAtNDMsNyArNDMsNyBA QCBXZSBhbHNvIHJlcXVlc3QgeW91IGZvbGxvdyB0aGVzZSBiYXNpYyBndWlkZWxpbmVzOgogTWFp bnRhaW5lcnMgTGlzdAogLS0tLS0tLS0tLS0tLS0tLQogCi0qIFBhdWwgRHVycmFudCA8cGF1bEB4 ZW4ub3JnPgorKiBQYXVsIER1cnJhbnQgPHBkdXJyYW50QGFtYXpvbi5jb20+CiAKICogQmVuIENo YWxtZXJzIDxiZW4uY2hhbG1lcnNAY2l0cml4LmNvbT4KIAotLSAKMi4xNy4xCgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Kd2luLXB2LWRldmVsIG1haWxp bmcgbGlzdAp3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54 ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3dpbi1wdi1kZXZlbA== From win-pv-devel-bounces@lists.xenproject.org Thu Nov 14 10:41:16 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 14 Nov 2019 10:41:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVCYt-0002SD-VM; Thu, 14 Nov 2019 10:41:15 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVCYr-0002S8-WB for win-pv-devel@lists.xenproject.org; Thu, 14 Nov 2019 10:41:14 +0000 X-Inumbo-ID: 46fd5e54-06cb-11ea-a247-12813bfff9fa Received: from smtp-fw-9102.amazon.com (unknown [207.171.184.29]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 46fd5e54-06cb-11ea-a247-12813bfff9fa; Thu, 14 Nov 2019 10:41:13 +0000 (UTC) IronPort-SDR: nqcHJJVw89WG1XQKNKhYhXBfuh5XX0DNpJcBaQ91zxQHQOWHFGT43QnXYUP5lEwJ7FXi5COZyS 5s02QlUQd6IA== X-IronPort-AV: E=Sophos;i="5.68,304,1569283200"; d="scan'208";a="7242930" Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-2c-397e131e.us-west-2.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-9102.sea19.amazon.com with ESMTP; 14 Nov 2019 10:41:13 +0000 Received: from EX13MTAUEA001.ant.amazon.com (pdx4-ws-svc-p6-lb7-vlan3.pdx.amazon.com [10.170.41.166]) by email-inbound-relay-2c-397e131e.us-west-2.amazon.com (Postfix) with ESMTPS id 0E8BDA059E for ; Thu, 14 Nov 2019 10:41:12 +0000 (UTC) Received: from EX13D32EUB001.ant.amazon.com (10.43.166.125) by EX13MTAUEA001.ant.amazon.com (10.43.61.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 14 Nov 2019 10:41:11 +0000 Received: from EX13MTAUWA001.ant.amazon.com (10.43.160.58) by EX13D32EUB001.ant.amazon.com (10.43.166.125) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 14 Nov 2019 10:41:10 +0000 Received: from CBG-5CG9341D0C.cbg10.amazon.com (10.55.227.12) by mail-relay.amazon.com (10.43.160.118) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Thu, 14 Nov 2019 10:41:07 +0000 From: To: Date: Thu, 14 Nov 2019 10:41:06 +0000 Message-ID: <20191114104106.2537-1-paul@xen.org> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Subject: [win-pv-devel] [PATCH xenvkbd] MAINTAINERS: Update my email address X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Paul Durrant Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" RnJvbTogUGF1bCBEdXJyYW50IDxwZHVycmFudEBhbWF6b24uY29tPgoKU2lnbmVkLW9mZi1ieTog UGF1bCBEdXJyYW50IDxwZHVycmFudEBhbWF6b24uY29tPgotLS0KIE1BSU5UQUlORVJTIHwgMiAr LQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0t Z2l0IGEvTUFJTlRBSU5FUlMgYi9NQUlOVEFJTkVSUwppbmRleCA1ZjFhNjcwLi5hNmJlMDI0IDEw MDY0NAotLS0gYS9NQUlOVEFJTkVSUworKysgYi9NQUlOVEFJTkVSUwpAQCAtNDMsNyArNDMsNyBA QCBXZSBhbHNvIHJlcXVlc3QgeW91IGZvbGxvdyB0aGVzZSBiYXNpYyBndWlkZWxpbmVzOgogTWFp bnRhaW5lcnMgTGlzdAogLS0tLS0tLS0tLS0tLS0tLQogCi0qIFBhdWwgRHVycmFudCA8cGF1bEB4 ZW4ub3JnPgorKiBQYXVsIER1cnJhbnQgPHBkdXJyYW50QGFtYXpvbi5jb20+CiAKICogQmVuIENo YWxtZXJzIDxiZW4uY2hhbG1lcnNAY2l0cml4LmNvbT4KIAotLSAKMi4xNy4xCgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Kd2luLXB2LWRldmVsIG1haWxp bmcgbGlzdAp3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54 ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3dpbi1wdi1kZXZlbA== From win-pv-devel-bounces@lists.xenproject.org Thu Nov 14 15:14:45 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 14 Nov 2019 15:14:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVGpX-00042H-FO; Thu, 14 Nov 2019 15:14:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVCk8-0003KJ-2J for win-pv-devel@lists.xenproject.org; Thu, 14 Nov 2019 10:52:52 +0000 X-Inumbo-ID: e720d8ba-06cc-11ea-9631-bc764e2007e4 Received: from smtp-fw-33001.amazon.com (unknown [207.171.190.10]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e720d8ba-06cc-11ea-9631-bc764e2007e4; Thu, 14 Nov 2019 10:52:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1573728772; x=1605264772; h=from:to:cc:subject:date:message-id:mime-version; bh=J/sZVpSYpIdAoM7nwX67v7SeNcQ1EDJObKPQWRyI6lo=; b=R9TVOumE95M3xnZP1bSjWBqpZS7g/ikpgzPWhg2wK12Wt4nXBQr4hTpR qBG4o4blfdAjnt42lLzQGjxEkPNQtKlzjHe8OKGkBiHFcP2JLLvhMrOXI 4TpVTC4HHuCN/3kn7nr/KwbAc55K+tnk+xoK3Q5B72pkoeAMYcemiwC76 E=; IronPort-SDR: kbNr6M8oyZe5bZrf+m2aK/+gdtPs/LXDhlS09jVAWQqrKUeIip0Wr+44VUYsoT8rWjwBr/VW7W B066BzTcmJ0A== X-IronPort-AV: E=Sophos;i="5.68,304,1569283200"; d="scan'208";a="7578893" Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-1a-715bee71.us-east-1.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-33001.sea14.amazon.com with ESMTP; 14 Nov 2019 10:52:44 +0000 Received: from EX13MTAUEA001.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan3.iad.amazon.com [10.40.159.166]) by email-inbound-relay-1a-715bee71.us-east-1.amazon.com (Postfix) with ESMTPS id 350E4A2CA0 for ; Thu, 14 Nov 2019 10:52:42 +0000 (UTC) Received: from EX13D32EUB004.ant.amazon.com (10.43.166.212) by EX13MTAUEA001.ant.amazon.com (10.43.61.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 14 Nov 2019 10:52:42 +0000 Received: from EX13MTAUWC001.ant.amazon.com (10.43.162.135) by EX13D32EUB004.ant.amazon.com (10.43.166.212) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 14 Nov 2019 10:52:41 +0000 Received: from CBG-5CG9341D0C.cbg10.amazon.com (10.55.227.12) by mail-relay.amazon.com (10.43.162.232) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Thu, 14 Nov 2019 10:52:38 +0000 From: Paul Durrant To: Date: Thu, 14 Nov 2019 10:52:35 +0000 Message-ID: <20191114105235.2651-1-pdurrant@amazon.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Mailman-Approved-At: Thu, 14 Nov 2019 15:14:42 +0000 Subject: [win-pv-devel] [PATCH xenvbd] MAINTAINERS: Update my email address X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Paul Durrant Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" U2lnbmVkLW9mZi1ieTogUGF1bCBEdXJyYW50IDxwZHVycmFudEBhbWF6b24uY29tPgotLS0KIE1B SU5UQUlORVJTIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0 aW9uKC0pCgpkaWZmIC0tZ2l0IGEvTUFJTlRBSU5FUlMgYi9NQUlOVEFJTkVSUwppbmRleCA1ZjFh NjcwLi5hNmJlMDI0IDEwMDY0NAotLS0gYS9NQUlOVEFJTkVSUworKysgYi9NQUlOVEFJTkVSUwpA QCAtNDMsNyArNDMsNyBAQCBXZSBhbHNvIHJlcXVlc3QgeW91IGZvbGxvdyB0aGVzZSBiYXNpYyBn dWlkZWxpbmVzOgogTWFpbnRhaW5lcnMgTGlzdAogLS0tLS0tLS0tLS0tLS0tLQogCi0qIFBhdWwg RHVycmFudCA8cGF1bEB4ZW4ub3JnPgorKiBQYXVsIER1cnJhbnQgPHBkdXJyYW50QGFtYXpvbi5j b20+CiAKICogQmVuIENoYWxtZXJzIDxiZW4uY2hhbG1lcnNAY2l0cml4LmNvbT4KIAotLSAKMi4x Ny4xCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Kd2lu LXB2LWRldmVsIG1haWxpbmcgbGlzdAp3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcK aHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3dpbi1wdi1kZXZl bA== From win-pv-devel-bounces@lists.xenproject.org Thu Nov 14 15:14:45 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 14 Nov 2019 15:14:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVGpX-00042C-DY; Thu, 14 Nov 2019 15:14:43 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iNXu1-0006zu-7M for win-pv-devel@lists.xenproject.org; Thu, 24 Oct 2019 07:51:25 +0000 X-Inumbo-ID: 09f18812-f633-11e9-9497-12813bfff9fa Received: from mailer1.neclab.eu (unknown [195.37.70.40]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 09f18812-f633-11e9-9497-12813bfff9fa; Thu, 24 Oct 2019 07:51:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mailer1.neclab.eu (Postfix) with ESMTP id B6AFF10588B; Thu, 24 Oct 2019 09:51:07 +0200 (CEST) X-Virus-Scanned: Amavisd on Debian GNU/Linux (netlab.nec.de) Received: from mailer1.neclab.eu ([127.0.0.1]) by localhost (atlas-a.office.hd [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uduEosJNDrlk; Thu, 24 Oct 2019 09:51:07 +0200 (CEST) X-ENC: Last-Hop-TLS-encrypted X-ENC: Last-Hop-TLS-encrypted Received: from titania.office.hd (titania.office.hd [192.168.24.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailer1.neclab.eu (Postfix) with ESMTPS id 8F241105863; Thu, 24 Oct 2019 09:51:07 +0200 (CEST) Received: from oberon.office.hd (192.168.24.90) by titania.office.hd (192.168.24.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 24 Oct 2019 09:51:07 +0200 Received: from oberon.office.hd ([192.168.126.11]) by Oberon.office.hd ([192.168.126.11]) with mapi id 15.01.1713.009; Thu, 24 Oct 2019 09:51:07 +0200 From: Felipe Huici To: Lars Kurth , "xen-devel@lists.xenproject.org" Thread-Topic: [Xen-devel] [PATCH v2 0/6] Code of Conduct + Extra Guides and Best Practices Thread-Index: AQHVdOsomz4jG9eefUS4nCdPE8rRM6dplb2A Date: Thu, 24 Oct 2019 07:51:06 +0000 Message-ID: <9B267EDA-EC46-489E-9D05-5B9313D6F545@neclab.eu> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/10.10.e.190909 x-originating-ip: [192.168.24.96] Content-ID: <70338CA8B784834D84907486C653D825@office.hd> MIME-Version: 1.0 X-Mailman-Approved-At: Thu, 14 Nov 2019 15:14:42 +0000 Subject: Re: [win-pv-devel] [Xen-devel] [PATCH v2 0/6] Code of Conduct + Extra Guides and Best Practices X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Lars Kurth , "xen-api@lists.xenproject.org" , "minios-devel@lists.xenproject.org" , "committers@xenproject.org" , "mirageos-devel@lists.xenproject.org" , "win-pv-devel@lists.xenproject.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" SGkgTGFycywNCg0KU29ycnkgZm9yIHRoZSBsYXRlIHJlc3BvbnNlLCB0aGUgVW5pa3JhZnQgdGVh bSBpcyBjZXJ0YWlubHkgaGFwcHkgdG8gc3VwcG9ydCB0aGlzIGNvZGUgb2YgY29uZHVjdC4NCg0K VGhhbmtzLA0KDQotLSBGZWxpcGUNCg0K77u/T24gMjcuMDkuMTksIDA2OjIyLCAiWGVuLWRldmVs IG9uIGJlaGFsZiBvZiBMYXJzIEt1cnRoIiA8eGVuLWRldmVsLWJvdW5jZXNAbGlzdHMueGVucHJv amVjdC5vcmcgb24gYmVoYWxmIG9mIGxhcnMua3VydGhAeGVucHJvamVjdC5vcmc+IHdyb3RlOg0K DQogICAgRnJvbTogTGFycyBLdXJ0aCA8bGFycy5rdXJ0aEBjaXRyaXguY29tPg0KICAgIA0KICAg IFRoaXMgc2VyaWVzIHByb3Bvc2VzIGEgY29uY3JldGUgdmVyc2lvbiBvZiB0aGUgWGVuIFByb2pl Y3QNCiAgICBDb0MgYmFzZWQgb24gdjEuNCBvZiB0aGUgQ29udHJpYnV0b3IgQ292ZW5hbnQuIFNl ZSBbMV0NCiAgICANCiAgICBJdCBjb250YWlucyAqQUxMKiB0aGUgcG9ydGlvbnMgSSB3YXMgc3Rp bGwgZ29pbmcgdG8gYWRkLg0KICAgIEkgc3BlbnQgYSBiaXQgb2YgdGltZSBvbiB3b3JkLXNtaXRo aW5nLCBidXQgSSBhbSBub3QgYSBuYXRpdmUgRW5nbGlzaCBzcGVha2VyDQogICAgU28gdGhlcmUg aXMgcHJvYmFibHkgdGltZSBmb3IgaW1wcm92ZW1lbnQNCiAgICANCiAgICBUaGUgc2VyaWVzIGFs c28gcmVmbGVjdHMgdGhlIGRpc2N1c3Npb24gaW4gWzJdIGFuZCBzb21lIHByaXZhdGUNCiAgICBk aXNjdXNzaW9ucyBvbiBJUkMgdG8gaWRlbnRpZnkgaW5pdGlhbCBtZW1iZXJzIG9mIHRoZSBYZW4N CiAgICBQcm9qZWN04oCZcyBDb0MgdGVhbS4NCiAgICANCiAgICBGb3IgY29udmVuaWVuY2Ugb2Yg cmV2aWV3IGFuZCBpbiBsaW5lIHdpdGggb3RoZXIgcG9saWN5IGRvY3VtZW50cw0KICAgIEkgY3Jl YXRlZCBhIGdpdCByZXBvc2l0b3J5IGF0IFszXS4gVGhpcyBzZXJpZXMgY2FuIGJlIGZvdW5kIGF0 IFs1XS4NCiAgICANCiAgICBbMV0gaHR0cHM6Ly93d3cuY29udHJpYnV0b3ItY292ZW5hbnQub3Jn L3ZlcnNpb24vMS80L2NvZGUtb2YtY29uZHVjdC5tZA0KICAgIFsyXSBodHRwczovL3hlbi5tYXJr bWFpbC5vcmcvdGhyZWFkLzU2YW8yZ3locGx0cW1yZXcgDQogICAgWzNdIGh0dHA6Ly94ZW5iaXRz Lnhlbi5vcmcvZ2l0d2ViLz9wPXBlb3BsZS9sYXJzay9jb2RlLW9mLWNvbmR1Y3QuZ2l0O2E9c3Vt bWFyeQ0KICAgIFs0XSBodHRwczovL3d3dy5zbGlkZXNoYXJlLm5ldC94ZW5fY29tX21nci94cGRk czE5LWtleW5vdGUtcGF0Y2gtcmV2aWV3LWZvci1ub25tYWludGFpbmVycy1nZW9yZ2UtZHVubGFw LWNpdHJpeC1zeXN0ZW1zLXVrLWx0ZA0KICAgIFs1XSBodHRwOi8veGVuYml0cy54ZW4ub3JnL2dp dHdlYi8/cD1wZW9wbGUvbGFyc2svY29kZS1vZi1jb25kdWN0LmdpdDthPXNob3J0bG9nO2g9cmVm cy9oZWFkcy9Db0MtdjINCiAgICANCiAgICBDaGFuZ2VzIHNpbmNlIHYxDQogICAgKiBDb2RlIG9m IENvbmR1Y3QgDQogICAgICBPbmx5IHdoaXRlc3BhY2UgY2hhbmdlcw0KICAgIA0KICAgICogQWRk ZWQgQ29tbXVuaWNhdGlvbiBHdWlkZQ0KICAgICAgQ29udGFpbnMgdmFsdWVzIGFuZCBhIHByb2Nl c3MgYmFzZWQgb24gYWR2aWNlIGFuZCBtZWRpYXRpb24gaW4gY2FzZSBvZiBpc3N1ZXMNCiAgICAg IFRoaXMgaXMgdGhlIHByaW1hcnkgcG9ydGFsIGZvciANCiAgICANCiAgICAqIEFkZGVkIENvZGUg UmV2aWV3IEd1aWRlDQogICAgICBXaGljaCBpcyBiYXNlZCBvbiBbNF0gd2l0aCBzb21lIGFkZGl0 aW9ucyBmb3IgY29tcGxldGVuZXNzDQogICAgICBJdCBwcmltYXJpbHkgc2V0cyBleHBlY3RhdGlv bnMgYW5kIGFueXRoaW5nIGNvbW11bmljYXRpb24gcmVsYXRlZCBpcyByZW1vdmVkDQogICAgDQog ICAgKiBBZGRlZCBndWlkZSBvbiBDb21tdW5pY2F0aW9uIEJlc3QgUHJhY3RpY2UNCiAgICAgIFRh a2VzIHRoZSBjb21tdW5pY2F0aW9uIHNlY3Rpb24gZnJvbSBbNF0gYW5kIGV4cGFuZHMgb24gaXQg d2l0aCBtb3JlIGV4YW1wbGVzDQogICAgICBhbmQgY2FzZXMuIFRoaXMgaXMgcHJvYmFibHkgd2hl cmUgd2UgbWF5IG5lZWQgc29tZSBkaXNjdXNzaW9uDQogICAgDQogICAgKiBBZGRlZCBkb2N1bWVu dCBvbiBSZXNvbHZpbmcgRGlzYWdyZWVtZW50DQogICAgICBBIHRpbnkgYml0IG9mIHRoZW9yeSB0 byBzZXQgdGhlIHNjZW5lDQogICAgICBJdCBjb3ZlcnMgc29tZSBjb21tb24gY2FzZXMgb2YgZGlz YWdyZWVtZW50cyBhbmQgaG93IHdlIG1heSBhcHByb2FjaCB0aGVtDQogICAgICBBZ2FpbiwgdGhp cyBwcm9iYWJseSBuZWVkcyBzb21lIGRpc2N1c3Npb24NCiAgICANCiAgICBDYzogbWluaW9zLWRl dmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQogICAgQ2M6IHhlbi1hcGlAbGlzdHMueGVucHJvamVj dC5vcmcNCiAgICBDYzogd2luLXB2LWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQogICAgQ2M6 IG1pcmFnZW9zLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQogICAgQ2M6IGNvbW1pdHRlcnNA eGVucHJvamVjdC5vcmcNCiAgICANCiAgICBMYXJzIEt1cnRoICg2KToNCiAgICAgIEltcG9ydCB2 MS40IG9mIENvbnRyaWJ1dG9yIENvdmVuYW50IENvQw0KICAgICAgWGVuIFByb2plY3QgQ29kZSBv ZiBDb25kdWN0DQogICAgICBBZGQgQ29tbXVuaWNhdGlvbiBHdWlkZQ0KICAgICAgQWRkIENvZGUg UmV2aWV3IEd1aWRlDQogICAgICBBZGQgZ3VpZGUgb24gQ29tbXVuaWNhdGlvbiBCZXN0IFByYWN0 aWNlDQogICAgICBBZGRlZCBSZXNvbHZpbmcgRGlzYWdyZWVtZW50DQogICAgDQogICAgLS0gDQog ICAgMi4xMy4wDQogICAgDQogICAgDQogICAgX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18NCiAgICBYZW4tZGV2ZWwgbWFpbGluZyBsaXN0DQogICAgWGVuLWRl dmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQogICAgaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA0KDQpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwp3aW4tcHYtZGV2ZWwgbWFpbGluZyBsaXN0Cndpbi1wdi1k ZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21h aWxtYW4vbGlzdGluZm8vd2luLXB2LWRldmVs From win-pv-devel-bounces@lists.xenproject.org Thu Nov 14 17:47:10 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 14 Nov 2019 17:47:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVJD2-0002gN-Gd; Thu, 14 Nov 2019 17:47:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVJD1-0002gH-9z for win-pv-devel@lists.xenproject.org; Thu, 14 Nov 2019 17:47:07 +0000 X-Inumbo-ID: c65c2910-0706-11ea-b678-bc764e2007e4 Received: from smtp-fw-2101.amazon.com (unknown [72.21.196.25]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c65c2910-0706-11ea-b678-bc764e2007e4; Thu, 14 Nov 2019 17:47:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1573753627; x=1605289627; h=from:to:cc:subject:date:message-id:mime-version; bh=7GOP+IGvUGVwEMIXG2G1B6JnenvwaguQbWrwsTKrJjM=; b=TYDyOeEZ3Cskc5d7JFOGK8hb6k30mYYqst06Nf+7btyxnwsQfJkkKIED gEXWFgoRKeVsR6/PDl2tym7++zkD51qG6z7jFjgUNshsVVCTJvscC1BqR l3hUrAApBcx4ztbNGd1uBOCAjMZt6aDUgHC9nSOd9dBJKS6EawnrFA5jZ k=; IronPort-SDR: FBkXwnk8CJCvKWcfQQQzr4yX3QFk/f5ahGytqd0gfOKOpqY4q2/Z1eDUusUrVUBL9/vjtW4nBH 17zJ4G7SLh9w== X-IronPort-AV: E=Sophos;i="5.68,304,1569283200"; d="scan'208";a="3941991" Received: from iad6-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-1d-38ae4ad2.us-east-1.amazon.com) ([10.124.125.2]) by smtp-border-fw-out-2101.iad2.amazon.com with ESMTP; 14 Nov 2019 17:47:02 +0000 Received: from EX13MTAUEA001.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan2.iad.amazon.com [10.40.159.162]) by email-inbound-relay-1d-38ae4ad2.us-east-1.amazon.com (Postfix) with ESMTPS id 7AD87A310C for ; Thu, 14 Nov 2019 17:47:02 +0000 (UTC) Received: from EX13D32EUC003.ant.amazon.com (10.43.164.24) by EX13MTAUEA001.ant.amazon.com (10.43.61.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 14 Nov 2019 17:47:01 +0000 Received: from EX13MTAUEA001.ant.amazon.com (10.43.61.82) by EX13D32EUC003.ant.amazon.com (10.43.164.24) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 14 Nov 2019 17:47:00 +0000 Received: from CBG-5CG9341D0C.cbg10.amazon.com (10.55.227.12) by mail-relay.amazon.com (10.43.61.243) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Thu, 14 Nov 2019 17:46:59 +0000 From: Paul Durrant To: Date: Thu, 14 Nov 2019 17:46:54 +0000 Message-ID: <20191114174654.3709-1-pdurrant@amazon.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Subject: [win-pv-devel] [PATCH xenbus] Remove some code duplication in store.c... X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Paul Durrant Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" Li4uYnkgdXNpbmcgYSBuZXcgaW5saW5lIF9fU3RvcmVQb2xsKCkgZnVuY3Rpb24gYW5kIHJldHVy bmluZyBldmVudCBjb3VudApkaXJlY3RseSBmcm9tIFN0b3JlUG9sbExvY2tlZCgpLgoKU2lnbmVk LW9mZi1ieTogUGF1bCBEdXJyYW50IDxwZHVycmFudEBhbWF6b24uY29tPgotLS0KIHNyYy94ZW5i dXMvc3RvcmUuYyB8IDU0ICsrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0t LS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAzMSBpbnNlcnRpb25zKCspLCAyMyBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9zcmMveGVuYnVzL3N0b3JlLmMgYi9zcmMveGVuYnVzL3N0b3JlLmMKaW5k ZXggNTU2ZDA0MC4uZjA3ZTQ2OSAxMDA2NDQKLS0tIGEvc3JjL3hlbmJ1cy9zdG9yZS5jCisrKyBi L3NyYy94ZW5idXMvc3RvcmUuYwpAQCAtODI0LDExICs4MjQsMTIgQEAgU3RvcmVQcm9jZXNzUmVz cG9uc2UoCiAgICAgS2VNZW1vcnlCYXJyaWVyKCk7CiB9CiAKLXN0YXRpYyBWT0lECitzdGF0aWMg VUxPTkcKIFN0b3JlUG9sbExvY2tlZCgKICAgICBJTiAgUFhFTkJVU19TVE9SRV9DT05URVhUICAg Q29udGV4dAogICAgICkKIHsKKyAgICBVTE9ORyAgICAgICAgICAgICAgICAgICAgICAgQ291bnQ7 CiAgICAgVUxPTkcgICAgICAgICAgICAgICAgICAgICAgIFJlYWQ7CiAgICAgVUxPTkcgICAgICAg ICAgICAgICAgICAgICAgIFdyaXR0ZW47CiAgICAgTlRTVEFUVVMgICAgICAgICAgICAgICAgICAg IHN0YXR1czsKQEAgLTgzNyw2ICs4MzgsMTIgQEAgU3RvcmVQb2xsTG9ja2VkKAogCiAgICAgQ29u dGV4dC0+UG9sbHMrKzsKIAorICAgIENvdW50ID0gWEVOQlVTX0VWVENITihHZXRDb3VudCwKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgJkNvbnRleHQtPkV2dGNobkludGVyZmFjZSwKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgQ29udGV4dC0+Q2hhbm5lbCk7CisKKyAgICBLZU1lbW9yeUJh cnJpZXIoKTsKKwogICAgIGRvIHsKICAgICAgICAgUmVhZCA9IFdyaXR0ZW4gPSAwOwogCkBAIC04 NTYsNiArODYzLDE5IEBAIFN0b3JlUG9sbExvY2tlZCgKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIENvbnRleHQtPkNoYW5uZWwpOwogCiAgICAgfSB3aGlsZSAoV3JpdHRlbiAhPSAw IHx8IFJlYWQgIT0gMCk7CisKKyAgICByZXR1cm4gQ291bnQ7Cit9CisKK3N0YXRpYyBGT1JDRUlO TElORSBWT0lECitfX1N0b3JlUG9sbCgKKyAgICBJTiAgUFhFTkJVU19TVE9SRV9DT05URVhUICAg Q29udGV4dAorICAgICkKK3sKKyAgICBLZUFjcXVpcmVTcGluTG9ja0F0RHBjTGV2ZWwoJkNvbnRl eHQtPkxvY2spOworICAgIGlmIChDb250ZXh0LT5SZWZlcmVuY2VzICE9IDApCisgICAgICAgIChW T0lEKSBTdG9yZVBvbGxMb2NrZWQoQ29udGV4dCk7CisgICAgS2VSZWxlYXNlU3BpbkxvY2tGcm9t RHBjTGV2ZWwoJkNvbnRleHQtPkxvY2spOwogfQogCiBzdGF0aWMKQEAgLTg3OSwxMSArODk5LDcg QEAgU3RvcmVEcGMoCiAgICAgVU5SRUZFUkVOQ0VEX1BBUkFNRVRFUihBcmd1bWVudDIpOwogCiAg ICAgQVNTRVJUKENvbnRleHQgIT0gTlVMTCk7Ci0KLSAgICBLZUFjcXVpcmVTcGluTG9ja0F0RHBj TGV2ZWwoJkNvbnRleHQtPkxvY2spOwotICAgIGlmIChDb250ZXh0LT5SZWZlcmVuY2VzICE9IDAp Ci0gICAgICAgIFN0b3JlUG9sbExvY2tlZChDb250ZXh0KTsKLSAgICBLZVJlbGVhc2VTcGluTG9j a0Zyb21EcGNMZXZlbCgmQ29udGV4dC0+TG9jayk7CisgICAgX19TdG9yZVBvbGwoQ29udGV4dCk7 CiB9CiAKICNkZWZpbmUgVElNRV9VUyhfdXMpICAgICAgICAoKF91cykgKiAxMCkKQEAgLTkwMiw2 ICs5MTgsNyBAQCBTdG9yZVN1Ym1pdFJlcXVlc3QoCiAgICAgUFhFTkJVU19TVE9SRV9SRVNQT05T RSAgICAgIFJlc3BvbnNlOwogICAgIEtJUlFMICAgICAgICAgICAgICAgICAgICAgICBJcnFsOwog ICAgIFVMT05HICAgICAgICAgICAgICAgICAgICAgICBDb3VudDsKKyAgICBYRU5CVVNfU1RPUkVf UkVRVUVTVF9TVEFURSAgU3RhdGU7CiAgICAgTEFSR0VfSU5URUdFUiAgICAgICAgICAgICAgIFRp bWVvdXQ7CiAKICAgICBBU1NFUlQzVShSZXF1ZXN0LT5TdGF0ZSwgPT0sIFhFTkJVU19TVE9SRV9S RVFVRVNUX1BSRVBBUkVEKTsKQEAgLTkxNiwxNiArOTMzLDE0IEBAIFN0b3JlU3VibWl0UmVxdWVz dCgKIAogICAgIFJlcXVlc3QtPlN0YXRlID0gWEVOQlVTX1NUT1JFX1JFUVVFU1RfU1VCTUlUVEVE OwogCi0gICAgQ291bnQgPSBYRU5CVVNfRVZUQ0hOKEdldENvdW50LAotICAgICAgICAgICAgICAg ICAgICAgICAgICAmQ29udGV4dC0+RXZ0Y2huSW50ZXJmYWNlLAotICAgICAgICAgICAgICAgICAg ICAgICAgICBDb250ZXh0LT5DaGFubmVsKTsKKyAgICBDb3VudCA9IFN0b3JlUG9sbExvY2tlZChD b250ZXh0KTsKIAotICAgIFN0b3JlUG9sbExvY2tlZChDb250ZXh0KTsKICAgICBLZU1lbW9yeUJh cnJpZXIoKTsKKyAgICBTdGF0ZSA9IFJlcXVlc3QtPlN0YXRlOwogCiAgICAgVGltZW91dC5RdWFk UGFydCA9IFRJTUVfUkVMQVRJVkUoVElNRV9TKFhFTkJVU19TVE9SRV9QT0xMX1BFUklPRCkpOwog Ci0gICAgd2hpbGUgKFJlcXVlc3QtPlN0YXRlICE9IFhFTkJVU19TVE9SRV9SRVFVRVNUX0NPTVBM RVRFRCkgeworICAgIHdoaWxlIChTdGF0ZSAhPSBYRU5CVVNfU1RPUkVfUkVRVUVTVF9DT01QTEVU RUQpIHsKICAgICAgICAgTlRTVEFUVVMgICAgc3RhdHVzOwogCiAgICAgICAgIHN0YXR1cyA9IFhF TkJVU19FVlRDSE4oV2FpdCwKQEAgLTkzNiwxMiArOTUxLDEwIEBAIFN0b3JlU3VibWl0UmVxdWVz dCgKICAgICAgICAgaWYgKHN0YXR1cyA9PSBTVEFUVVNfVElNRU9VVCkKICAgICAgICAgICAgIFdh cm5pbmcoIlRJTUVEIE9VVFxuIik7CiAKLSAgICAgICAgQ291bnQgPSBYRU5CVVNfRVZUQ0hOKEdl dENvdW50LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJkNvbnRleHQtPkV2dGNobklu dGVyZmFjZSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIENvbnRleHQtPkNoYW5uZWwp OworICAgICAgICBDb3VudCA9IFN0b3JlUG9sbExvY2tlZChDb250ZXh0KTsKIAotICAgICAgICBT dG9yZVBvbGxMb2NrZWQoQ29udGV4dCk7CiAgICAgICAgIEtlTWVtb3J5QmFycmllcigpOworICAg ICAgICBTdGF0ZSA9IFJlcXVlc3QtPlN0YXRlOwogICAgIH0KIAogICAgIEtlUmVsZWFzZVNwaW5M b2NrRnJvbURwY0xldmVsKCZDb250ZXh0LT5Mb2NrKTsKQEAgLTE4MjMsMTIgKzE4MzYsNyBAQCBT dG9yZVBvbGwoCiAgICAgSU4gIFBJTlRFUkZBQ0UgICAgICAgICAgSW50ZXJmYWNlCiAgICAgKQog ewotICAgIFBYRU5CVVNfU1RPUkVfQ09OVEVYVCAgIENvbnRleHQgPSBJbnRlcmZhY2UtPkNvbnRl eHQ7Ci0KLSAgICBLZUFjcXVpcmVTcGluTG9ja0F0RHBjTGV2ZWwoJkNvbnRleHQtPkxvY2spOwot ICAgIGlmIChDb250ZXh0LT5SZWZlcmVuY2VzICE9IDApCi0gICAgICAgIFN0b3JlUG9sbExvY2tl ZChDb250ZXh0KTsKLSAgICBLZVJlbGVhc2VTcGluTG9ja0Zyb21EcGNMZXZlbCgmQ29udGV4dC0+ TG9jayk7CisgICAgX19TdG9yZVBvbGwoSW50ZXJmYWNlLT5Db250ZXh0KTsKIH0KIAogI2RlZmlu ZSBUSU1FX1VTKF91cykgICAgICAgICgoX3VzKSAqIDEwKQpAQCAtMTg5OCw3ICsxOTA2LDcgQEAg U3RvcmVXYXRjaGRvZygKICAgICAgICAgICAgICAgICAoVk9JRCkgWEVOQlVTX0VWVENITihTZW5k LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZDb250ZXh0LT5FdnRjaG5J bnRlcmZhY2UsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgQ29udGV4dC0+ Q2hhbm5lbCk7Ci0gICAgICAgICAgICAgICAgU3RvcmVQb2xsTG9ja2VkKENvbnRleHQpOworICAg ICAgICAgICAgICAgIChWT0lEKSBTdG9yZVBvbGxMb2NrZWQoQ29udGV4dCk7CiAgICAgICAgICAg ICB9CiAKICAgICAgICAgICAgIEtlTWVtb3J5QmFycmllcigpOwpAQCAtMjYwNCw3ICsyNjEyLDcg QEAgU3RvcmVSZWxlYXNlKAogICAgIFhFTkJVU19TVVNQRU5EKFJlbGVhc2UsICZDb250ZXh0LT5T dXNwZW5kSW50ZXJmYWNlKTsKIAogICAgIFN0b3JlRGlzYWJsZShDb250ZXh0KTsKLSAgICBTdG9y ZVBvbGxMb2NrZWQoQ29udGV4dCk7CisgICAgKFZPSUQpIFN0b3JlUG9sbExvY2tlZChDb250ZXh0 KTsKICAgICBSdGxaZXJvTWVtb3J5KCZDb250ZXh0LT5SZXNwb25zZSwgc2l6ZW9mIChYRU5CVVNf U1RPUkVfUkVTUE9OU0UpKTsKIAogICAgIFhFTkJVU19FVlRDSE4oUmVsZWFzZSwgJkNvbnRleHQt PkV2dGNobkludGVyZmFjZSk7Ci0tIAoyLjE3LjEKCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwp3aW4tcHYtZGV2ZWwgbWFpbGluZyBsaXN0Cndpbi1wdi1k ZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21h aWxtYW4vbGlzdGluZm8vd2luLXB2LWRldmVs From win-pv-devel-bounces@lists.xenproject.org Thu Nov 14 20:30:21 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 14 Nov 2019 20:30:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVLkx-0001lb-0v; Thu, 14 Nov 2019 20:30:19 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVLkv-0001lW-6b for win-pv-devel@lists.xenproject.org; Thu, 14 Nov 2019 20:30:17 +0000 Date: Thu, 14 Nov 2019 20:29:55 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <19852637.1.1573763399347.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_0_33342817.1573763398097" X-Jenkins-Job: XENVIF-master X-Jenkins-Result: SUCCESS Subject: [win-pv-devel] XENVIF-master - Build #175 - Successful X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" ------=_Part_0_33342817.1573763398097 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #175. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENVIF-master/175/console to view the results. ------=_Part_0_33342817.1573763398097 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Kd2luLXB2LWRl dmVsIG1haWxpbmcgbGlzdAp3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6 Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3dpbi1wdi1kZXZlbA== ------=_Part_0_33342817.1573763398097-- From win-pv-devel-bounces@lists.xenproject.org Thu Nov 14 22:28:52 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 14 Nov 2019 22:28:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVNbd-0003Ex-DF; Thu, 14 Nov 2019 22:28:49 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVNbb-0003Es-Tw for win-pv-devel@lists.xenproject.org; Thu, 14 Nov 2019 22:28:47 +0000 Date: Thu, 14 Nov 2019 22:28:29 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <8331968.3.1573770509975.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_2_25415240.1573770509850" X-Jenkins-Job: XENIFACE-master X-Jenkins-Result: SUCCESS Subject: [win-pv-devel] XENIFACE-master - Build #93 - Successful X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" ------=_Part_2_25415240.1573770509850 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #93. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENIFACE-master/93/console to view the results. ------=_Part_2_25415240.1573770509850 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Kd2luLXB2LWRl dmVsIG1haWxpbmcgbGlzdAp3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6 Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3dpbi1wdi1kZXZlbA== ------=_Part_2_25415240.1573770509850-- From win-pv-devel-bounces@lists.xenproject.org Fri Nov 15 00:20:13 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 15 Nov 2019 00:20:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVPLP-00069N-Hk; Fri, 15 Nov 2019 00:20:11 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVPLO-00069I-PK for win-pv-devel@lists.xenproject.org; Fri, 15 Nov 2019 00:20:10 +0000 Date: Fri, 15 Nov 2019 00:19:52 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <13708236.5.1573777192901.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_4_29506454.1573777192791" X-Jenkins-Job: XENNET-master X-Jenkins-Result: SUCCESS Subject: [win-pv-devel] XENNET-master - Build #108 - Successful X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" ------=_Part_4_29506454.1573777192791 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #108. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENNET-master/108/console to view the results. ------=_Part_4_29506454.1573777192791 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Kd2luLXB2LWRl dmVsIG1haWxpbmcgbGlzdAp3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6 Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3dpbi1wdi1kZXZlbA== ------=_Part_4_29506454.1573777192791-- From win-pv-devel-bounces@lists.xenproject.org Fri Nov 15 01:23:44 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 15 Nov 2019 01:23:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVQKr-00022g-4W; Fri, 15 Nov 2019 01:23:41 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVQKp-00022b-Nr for win-pv-devel@lists.xenproject.org; Fri, 15 Nov 2019 01:23:39 +0000 Date: Fri, 15 Nov 2019 01:23:21 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <20608784.7.1573781001871.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_6_15154314.1573781001684" X-Jenkins-Job: XENHID-master X-Jenkins-Result: SUCCESS Subject: [win-pv-devel] XENHID-master - Build #17 - Successful X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" ------=_Part_6_15154314.1573781001684 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #17. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENHID-master/17/console to view the results. ------=_Part_6_15154314.1573781001684 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Kd2luLXB2LWRl dmVsIG1haWxpbmcgbGlzdAp3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6 Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3dpbi1wdi1kZXZlbA== ------=_Part_6_15154314.1573781001684-- From win-pv-devel-bounces@lists.xenproject.org Fri Nov 15 02:16:00 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 15 Nov 2019 02:16:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVR9T-0006eF-7e; Fri, 15 Nov 2019 02:15:59 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVR9S-0006eA-5q for win-pv-devel@lists.xenproject.org; Fri, 15 Nov 2019 02:15:58 +0000 Date: Fri, 15 Nov 2019 02:15:40 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <2467952.9.1573784140342.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_8_14014553.1573784140154" X-Jenkins-Job: XENBUS-master X-Jenkins-Result: SUCCESS Subject: [win-pv-devel] XENBUS-master - Build #196 - Successful X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" ------=_Part_8_14014553.1573784140154 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #196. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENBUS-master/196/console to view the results. ------=_Part_8_14014553.1573784140154 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Kd2luLXB2LWRl dmVsIG1haWxpbmcgbGlzdAp3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6 Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3dpbi1wdi1kZXZlbA== ------=_Part_8_14014553.1573784140154-- From win-pv-devel-bounces@lists.xenproject.org Fri Nov 15 03:02:28 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 15 Nov 2019 03:02:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVRsQ-0002g1-9S; Fri, 15 Nov 2019 03:02:26 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVRsO-0002fp-Si for win-pv-devel@lists.xenproject.org; Fri, 15 Nov 2019 03:02:24 +0000 Date: Fri, 15 Nov 2019 03:02:06 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <456181.11.1573786927062.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_10_9688793.1573786926984" X-Jenkins-Job: XENCONS-master X-Jenkins-Result: SUCCESS Subject: [win-pv-devel] XENCONS-master - Build #28 - Successful X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" ------=_Part_10_9688793.1573786926984 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #28. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENCONS-master/28/console to view the results. ------=_Part_10_9688793.1573786926984 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Kd2luLXB2LWRl dmVsIG1haWxpbmcgbGlzdAp3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6 Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3dpbi1wdi1kZXZlbA== ------=_Part_10_9688793.1573786926984-- From win-pv-devel-bounces@lists.xenproject.org Fri Nov 15 04:24:52 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 15 Nov 2019 04:24:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVTAA-0001xI-9r; Fri, 15 Nov 2019 04:24:50 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVTA9-0001xD-7D for win-pv-devel@lists.xenproject.org; Fri, 15 Nov 2019 04:24:49 +0000 Date: Fri, 15 Nov 2019 04:24:31 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <17124687.13.1573791871439.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_12_26020305.1573791871158" X-Jenkins-Job: XENVKBD-master X-Jenkins-Result: SUCCESS Subject: [win-pv-devel] XENVKBD-master - Build #21 - Successful X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" ------=_Part_12_26020305.1573791871158 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #21. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENVKBD-master/21/console to view the results. ------=_Part_12_26020305.1573791871158 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Kd2luLXB2LWRl dmVsIG1haWxpbmcgbGlzdAp3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6 Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3dpbi1wdi1kZXZlbA== ------=_Part_12_26020305.1573791871158-- From win-pv-devel-bounces@lists.xenproject.org Fri Nov 15 09:16:44 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 15 Nov 2019 09:16:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVXib-0003Ac-V1; Fri, 15 Nov 2019 09:16:41 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVXib-00039s-Bp for win-pv-devel@lists.xenproject.org; Fri, 15 Nov 2019 09:16:41 +0000 Date: Fri, 15 Nov 2019 09:16:23 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <7341612.15.1573809383730.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_14_21851820.1573809383448" X-Jenkins-Job: XENVBD-master X-Jenkins-Result: SUCCESS Subject: [win-pv-devel] XENVBD-master - Build #141 - Successful X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" ------=_Part_14_21851820.1573809383448 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #141. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENVBD-master/141/console to view the results. ------=_Part_14_21851820.1573809383448 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Kd2luLXB2LWRl dmVsIG1haWxpbmcgbGlzdAp3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6 Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3dpbi1wdi1kZXZlbA== ------=_Part_14_21851820.1573809383448-- From win-pv-devel-bounces@lists.xenproject.org Fri Nov 15 11:23:13 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 15 Nov 2019 11:23:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVZh0-0008O2-Hg; Fri, 15 Nov 2019 11:23:10 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVZgz-0008Nx-8S for win-pv-devel@lists.xenproject.org; Fri, 15 Nov 2019 11:23:09 +0000 Date: Fri, 15 Nov 2019 11:22:51 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <9811081.17.1573816971687.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_16_28135885.1573816971405" X-Jenkins-Job: XENIFACE-master X-Jenkins-Result: SUCCESS Subject: [win-pv-devel] XENIFACE-master - Build #94 - Successful X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" ------=_Part_16_28135885.1573816971405 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #94. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENIFACE-master/94/console to view the results. ------=_Part_16_28135885.1573816971405 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Kd2luLXB2LWRl dmVsIG1haWxpbmcgbGlzdAp3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6 Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3dpbi1wdi1kZXZlbA== ------=_Part_16_28135885.1573816971405-- From win-pv-devel-bounces@lists.xenproject.org Fri Nov 15 14:12:42 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 15 Nov 2019 14:12:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVcL2-0003aE-55; Fri, 15 Nov 2019 14:12:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVcL0-0003a0-3w for win-pv-devel@lists.xenproject.org; Fri, 15 Nov 2019 14:12:38 +0000 X-Inumbo-ID: f7b7796e-07b1-11ea-984a-bc764e2007e4 Received: from smtp-fw-33001.amazon.com (unknown [207.171.190.10]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f7b7796e-07b1-11ea-984a-bc764e2007e4; Fri, 15 Nov 2019 14:12:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1573827154; x=1605363154; h=from:to:cc:subject:date:message-id:mime-version; bh=fdbgAqaugr1iH0F5c0Fb9RYVqV3vcUELNR9Efi09p1c=; b=TOlBKOXDKPEgHL6KuugIyB6YrdwWEocDYC06U6xgwnowlQEgyx1T1L2y DYksFWt8ckTvxA9gIVqdhe6DTjYdHz9bF0jlJVilxz3b1AgErEtztPgs+ hCPzY9UF0Py7xzzs77F9OH2FOz+xjheR1EuSdmWnfes8JqG1wlQhbgCdN 4=; IronPort-SDR: u9hHzD2OIiEEzOUGsqzgdRUj9988+oXbAAqDVyLSPKWu5J5uO0qAi/aYGSVrzOl3zNYqOVrLXy rAwNxp/au+yQ== X-IronPort-AV: E=Sophos;i="5.68,308,1569283200"; d="scan'208";a="8060586" Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-1a-16acd5e0.us-east-1.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-33001.sea14.amazon.com with ESMTP; 15 Nov 2019 14:12:31 +0000 Received: from EX13MTAUEA001.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan3.iad.amazon.com [10.40.159.166]) by email-inbound-relay-1a-16acd5e0.us-east-1.amazon.com (Postfix) with ESMTPS id 4C64BA2313 for ; Fri, 15 Nov 2019 14:12:30 +0000 (UTC) Received: from EX13D32EUC003.ant.amazon.com (10.43.164.24) by EX13MTAUEA001.ant.amazon.com (10.43.61.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 15 Nov 2019 14:12:30 +0000 Received: from EX13MTAUEA001.ant.amazon.com (10.43.61.82) by EX13D32EUC003.ant.amazon.com (10.43.164.24) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 15 Nov 2019 14:12:29 +0000 Received: from CBG-5CG9341D0C.cbg10.amazon.com (10.55.227.12) by mail-relay.amazon.com (10.43.61.243) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Fri, 15 Nov 2019 14:12:28 +0000 From: Paul Durrant To: Date: Fri, 15 Nov 2019 14:12:26 +0000 Message-ID: <20191115141226.286-1-pdurrant@amazon.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Subject: [win-pv-devel] [PATCH xenbus] Avoid a small race window that can lead to stuck EvtchnWait() calls X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Paul Durrant Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" TWFrZSBzdXJlIGFuIGV2ZW50IGlzIGFjay1lZCBiZWZvcmUgQ2hhbm5lbC0+Q291bnQgaXMgaW5j cmVtZW50ZWQKb3RoZXJ3aXNlIEV2dGNobkdldENvdW50KCkgY291bGQgc2FtcGxlIHRoZSBpbmNy ZW1lbnRlZCB2YWx1ZSB3aGlsc3QgbmV3CmV2ZW50cyB3b3VsZCBiZSBtaXNzZWQuIFRodXMgRXZ0 Y2huV2FpdCgpIGNvdWxkIGVuZCB1cCB3YWl0aW5nIGZvciBhCkNvdW50IHZhbHVlIHRoYXQgbXkg bmV2ZXIgYmUgcmVhY2hlZC4KClNpZ25lZC1vZmYtYnk6IFBhdWwgRHVycmFudCA8cGR1cnJhbnRA YW1hem9uLmNvbT4KLS0tCiBzcmMveGVuYnVzL2V2dGNobi5jIHwgMTQgKysrKysrKysrKysrLS0K IDEgZmlsZSBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL3NyYy94ZW5idXMvZXZ0Y2huLmMgYi9zcmMveGVuYnVzL2V2dGNobi5jCmluZGV4IDA3 NDhlNTAuLjhhODE5ZjMgMTAwNjQ0Ci0tLSBhL3NyYy94ZW5idXMvZXZ0Y2huLmMKKysrIGIvc3Jj L3hlbmJ1cy9ldnRjaG4uYwpAQCAtNTA3LDggKzUwNyw2IEBAIEV2dGNoblBvbGwoCiAKICAgICAg ICAgS2VNZW1vcnlCYXJyaWVyKCk7CiAgICAgICAgIGlmICghQ2hhbm5lbC0+Q2xvc2VkKSB7Ci0g ICAgICAgICAgICBDaGFubmVsLT5Db3VudCsrOwotCiAgICAgICAgICAgICBSZW1vdmVFbnRyeUxp c3QoJkNoYW5uZWwtPlBlbmRpbmdMaXN0RW50cnkpOwogICAgICAgICAgICAgSW5pdGlhbGl6ZUxp c3RIZWFkKCZDaGFubmVsLT5QZW5kaW5nTGlzdEVudHJ5KTsKIApAQCAtNTIxLDYgKzUxOSwxNiBA QCBFdnRjaG5Qb2xsKAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJkNvbnRleHQtPkV2 dGNobkFiaSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIENoYW5uZWwtPkxvY2FsUG9y dCk7CiAKKwkgICAgLyoKKwkgICAgICogTWFrZSBzdXJlIHRoZSBldmVudCBpcyBhY2stZWQgYmVm b3JlIENvdW50IGlzIGluY3JlbWVudGVkCisJICAgICAqIG90aGVyd2lzZSB0aGVyZSBpcyBhIHNt YWxsIHdpbmRvdyB3aGVyZSBFdnRjaG5XYWl0KCkgY291bGQKKwkgICAgICogZW5kIHVwIHdhaXRp bmcgb24gdGhlIGluY3JlbWVudGVkIHZhbHVlIHdoaWxzdCBuZXcgZXZlbnRzCisJICAgICAqIHdv dWxkIGJlIG1pc3NlZCAoaGVuY2UgQ291bnQgd291bGQgbm90IGJlIGZ1cnRoZXIKKwkgICAgICog aW5jcmVtZW50ZWQgdG8gd2FrZSB0aGUgd2FpdGVyKS4KKwkgICAgICovCisJICAgIEtlTWVtb3J5 QmFycmllcigpOworICAgICAgICAgICAgQ2hhbm5lbC0+Q291bnQrKzsKKwogI3ByYWdtYSB3YXJu aW5nKHN1cHByZXNzOjYzODcpICAvLyBOVUxMIGFyZ3VtZW50CiAgICAgICAgICAgICBEb25lU29t ZXRoaW5nIHw9IENoYW5uZWwtPkNhbGxiYWNrKE5VTEwsIENoYW5uZWwtPkFyZ3VtZW50KTsKICAg ICAgICAgfSBlbHNlIGlmIChMaXN0ICE9IE5VTEwpIHsKQEAgLTkyMyw2ICs5MzEsOCBAQCBFdnRj aG5HZXRDb3VudCgKIHsKICAgICBVTlJFRkVSRU5DRURfUEFSQU1FVEVSKEludGVyZmFjZSk7CiAK KyAgICBLZU1lbW9yeUJhcnJpZXIoKTsKKwogICAgIHJldHVybiBDaGFubmVsLT5Db3VudDsKIH0K IAotLSAKMi4xNy4xCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18Kd2luLXB2LWRldmVsIG1haWxpbmcgbGlzdAp3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJv amVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3dp bi1wdi1kZXZlbA== From win-pv-devel-bounces@lists.xenproject.org Fri Nov 15 15:05:28 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 15 Nov 2019 15:05:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVdA8-00021A-50; Fri, 15 Nov 2019 15:05:28 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVdA6-00020t-U8 for win-pv-devel@lists.xenproject.org; Fri, 15 Nov 2019 15:05:26 +0000 Date: Fri, 15 Nov 2019 15:05:09 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <5442661.19.1573830309475.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_18_29670696.1573830309412" X-Jenkins-Job: XENVIF-master X-Jenkins-Result: SUCCESS Subject: [win-pv-devel] XENVIF-master - Build #176 - Successful X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" ------=_Part_18_29670696.1573830309412 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #176. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENVIF-master/176/console to view the results. ------=_Part_18_29670696.1573830309412 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Kd2luLXB2LWRl dmVsIG1haWxpbmcgbGlzdAp3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6 Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3dpbi1wdi1kZXZlbA== ------=_Part_18_29670696.1573830309412-- From win-pv-devel-bounces@lists.xenproject.org Sat Nov 16 02:00:41 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Sat, 16 Nov 2019 02:00:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVnOA-00016I-W1; Sat, 16 Nov 2019 02:00:38 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iVnO9-00016D-Q7 for win-pv-devel@lists.xenproject.org; Sat, 16 Nov 2019 02:00:37 +0000 Date: Sat, 16 Nov 2019 02:00:20 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <12196715.21.1573869620683.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_20_8632967.1573869620245" X-Jenkins-Job: XENBUS-master X-Jenkins-Result: SUCCESS Subject: [win-pv-devel] XENBUS-master - Build #197 - Successful X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" ------=_Part_20_8632967.1573869620245 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #197. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENBUS-master/197/console to view the results. ------=_Part_20_8632967.1573869620245 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Kd2luLXB2LWRl dmVsIG1haWxpbmcgbGlzdAp3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6 Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3dpbi1wdi1kZXZlbA== ------=_Part_20_8632967.1573869620245-- From win-pv-devel-bounces@lists.xenproject.org Thu Nov 28 00:54:30 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 28 Nov 2019 00:54:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ia84j-0000K7-KC; Thu, 28 Nov 2019 00:54:29 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ia84i-0000Jh-Hq for win-pv-devel@lists.xenproject.org; Thu, 28 Nov 2019 00:54:28 +0000 X-Inumbo-ID: 949a776a-1179-11ea-a3c4-12813bfff9fa Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 949a776a-1179-11ea-a3c4-12813bfff9fa; Thu, 28 Nov 2019 00:54:07 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5286D20661; Thu, 28 Nov 2019 00:54:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574902446; bh=iJEb+4SPDgdNtgzcXfxN2lbRBImN9YGqE4uU8Dba+5I=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=0UHHP5NV/CnX0ZY8M0SYr5CKhlS35Ztq2TUn/947hnUpWA0i2lXOI08NSopT9MSi8 1Zyxk2x9LhZSW3NtSjRa/oPhI1YOF6O4zoDEaKBY+fh5yguXVyXQR22RvJoHw2rHf3 JSmYCdsnH5yu9dDYgfxggO+iFaKvnuGjTACP6gY0= Date: Wed, 27 Nov 2019 16:54:05 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Lars Kurth In-Reply-To: <97e3adf75cf71ba39e702d4cab23236ada8d5a6c.1569525222.git.lars.kurth@citrix.com> Message-ID: References: <97e3adf75cf71ba39e702d4cab23236ada8d5a6c.1569525222.git.lars.kurth@citrix.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-168241973-1574899840=:27669" Content-ID: Subject: Re: [win-pv-devel] [PATCH v2 4/6] Add Code Review Guide X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Lars Kurth , xen-api@lists.xenproject.org, minios-devel@lists.xenproject.org, committers@xenproject.org, mirageos-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, win-pv-devel@lists.xenproject.org Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-168241973-1574899840=:27669 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Thu, 26 Sep 2019, Lars Kurth wrote: > From: Lars Kurth > > This document highlights what reviewers such as maintainers and committers look > for when reviewing code. It sets expectations for code authors and provides > a framework for code reviewers. I think the document is missing a couple of things: - a simple one line statement that possibly the most important thing in a code review is to indentify any bugs in the code - an explanation that requests for major changes to the series should be made early on (i.e. let's not change the architecture of a feature at v9 if possible) I also made this comment in reply to patch #5. I'll let you decide where is the best place for it. > Signed-off-by: Lars Kurth > --- > Cc: minios-devel@lists.xenproject.org > Cc: xen-api@lists.xenproject.org > Cc: win-pv-devel@lists.xenproject.org > Cc: mirageos-devel@lists.xenproject.org > Cc: committers@xenproject.org > --- > code-review-guide.md | 125 +++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 125 insertions(+) > create mode 100644 code-review-guide.md > > diff --git a/code-review-guide.md b/code-review-guide.md > new file mode 100644 > index 0000000..8639431 > --- /dev/null > +++ b/code-review-guide.md > @@ -0,0 +1,125 @@ > +# Code Review Guide > + > +This document highlights what reviewers such as maintainers and committers look > +for when reviewing your code. It sets expectations for code authors and provides > +a framework for code reviewers. > + > +This document does **not cover** the following topics: > +* [Communication Best Practice](communication-practice.md) > +* [Resolving Disagreement](resolving-disagreement.md) > +* [Patch Submission Workflow](https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches) > +* [Managing Patch Submission with Git](https://wiki.xenproject.org/wiki/Managing_Xen_Patches_with_Git) > + > +## What we look for in Code Reviews > +When performing a code review, reviewers typically look for the following things > + > +### Is the change necessary to accomplish the goals? > +* Is it clear what the goals are? > +* Do we need to make a change, or can the goals be met with existing > + functionality? > + > +### Architecture / Interface > +* Is this the best way to solve the problem? > +* Is this the right part of the code to modify? > +* Is this the right level of abstraction? > +* Is the interface general enough? Too general? Forward compatible? > + > +### Functionality > +* Does it do what it’s trying to do? > +* Is it doing it in the most efficient way? > +* Does it handle all the corner / error cases correctly? > + > +### Maintainability / Robustness > +* Is the code clear? Appropriately commented? > +* Does it duplicate another piece of code? > +* Does the code make hidden assumptions? > +* Does it introduce sections which need to be kept **in sync** with other sections? > +* Are there other **traps** someone modifying this code might fall into? > + > +**Note:** Sometimes you will work in areas which have identified maintainability > +and/or robustness issues. In such cases, maintainers may ask you to make additional > +changes, such that your submitted code does not make things worse or point you > +to other patches are already being worked on. > + > +### System properties > +In some areas of the code, system properties such as > +* Code size > +* Performance > +* Scalability > +* Latency > +* Complexity > +* &c > +are also important during code reviews. > + > +### Style > +* Comments, carriage returns, **snuggly braces**, &c > +* See [CODING_STYLE](https://xenbits.xenproject.org/gitweb/?p=xen.git;a=blob;f=CODING_STYLE) > + and [tools/libxl/CODING_STYLE](https://xenbits.xenproject.org/gitweb/?p=xen.git;a=blob;f=tools/libxl/CODING_STYLE) > +* No extraneous whitespace changes > + > +### Documentation and testing > +* If there is pre-existing documentation in the tree, such as man pages, design > + documents, etc. a contributor may be asked to update the documentation alongside > + the change. Documentation is typically present in the > + [docs](https://xenbits.xen.org/gitweb/?p=xen.git;a=tree;f=docs) folder. > +* When adding new features that have an impact on the end-user, > + a contributor should include an update to the > + [SUPPORT.md](https://xenbits.xen.org/gitweb/?p=xen.git;a=tree;f=docs) file. > + Typically, more complex features require several patch series before it is ready to be > + advertised in SUPPORT.md > +* When adding new features, a contributor may be asked to provide tests or > + ensure that existing tests pass > + > +#### Testing for the Xen Project Hypervisor > +Tests are typically located in one of the following directories > +* **Unit tests**: [tools/tests](https://xenbits.xenproject.org/gitweb/?p=xen.git;a=tree;f=tools/tests) > +or [xen/test](https://xenbits.xenproject.org/gitweb/?p=xen.git;a=tree;f=xen/test)
> + Unit testing is hard for a system like Xen and typically requires building a subsystem of > + your tree. If your change can be easily unit tested, you should consider submitting tests > + with your patch. > +* **Build and smoke test**: see [Xen GitLab CI](https://gitlab.com/xen-project/xen/pipelines)
> + Runs build tests for a combination of various distros and compilers against changes > + committed to staging. Developers can join as members and test their development > + branches **before** submitting a patch. > +* **XTF tests** (microkernel-based tests): see [XTF](https://xenbits.xenproject.org/docs/xtf/)
> + XTF has been designed to test interactions between your software and hardware. > + It is a very useful tool for testing low level functionality and is executed as part of the > + project's CI system. XTF can be easily executed locally on xen.git trees. > +* **osstest**: see [README](https://xenbits.xenproject.org/gitweb/?p=osstest.git;a=blob;f=README)
> + Osstest is the Xen Projects automated test system, which tests basic Xen use cases on > + a variety of different hardware. Before changes are committed, but **after** they have > + been reviewed. A contributor’s changes **cannot be applied to master** unless the > + tests pass this test suite. Note that XTF and other tests are also executed as part of > + osstest. > + > +### Patch / Patch series information > +* Informative one-line changelog > +* Full changelog > +* Motivation described > +* All important technical changes mentioned > +* Changes since previous revision listed > +* Reviewed-by’s and Acked-by’s dropped if appropriate > + > +More information related to these items can be found in our > +[Patch submission Guide](https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches). > + > +## Reviewing for Patch Authors > + > +The following presentation by George Dunlap, provides an excellent overview on how > +we do code reviews, specifically targeting non-maintainers. > + > +As a community, we would love to have more help reviewing, including from **new > +community members**. But many people > +* do not know where to start, or > +* believe that their review would not contribute much, or > +* may feel intimidated reviewing the code of more established community members > + > +The presentation demonstrates that you do not need to worry about any of these > +concerns. In addition, reviewing other people's patches helps you > +* write better patches and experience the code review process from the other side > +* and build more influence within the community over time > + > +Thus, we recommend strongly that **patch authors** read the watch the recording or > +read the slides: > +* [Patch Review for Non-Maintainers slides](https://www.slideshare.net/xen_com_mgr/xpdds19-keynote-patch-review-for-nonmaintainers-george-dunlap-citrix-systems-uk-ltd) > +* [Patch Review for Non-Maintainers recording - 20"](https://www.youtube.com/watch?v=ehZvBmrLRwg) > -- > 2.13.0 > --8323329-168241973-1574899840=:27669 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Kd2luLXB2LWRl dmVsIG1haWxpbmcgbGlzdAp3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6 Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3dpbi1wdi1kZXZlbA== --8323329-168241973-1574899840=:27669-- From win-pv-devel-bounces@lists.xenproject.org Thu Nov 28 00:56:29 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 28 Nov 2019 00:56:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ia86f-0000aT-C1; Thu, 28 Nov 2019 00:56:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ia86d-0000Zq-QM for win-pv-devel@lists.xenproject.org; Thu, 28 Nov 2019 00:56:27 +0000 X-Inumbo-ID: d8d84f38-1179-11ea-83b8-bc764e2007e4 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d8d84f38-1179-11ea-83b8-bc764e2007e4; Thu, 28 Nov 2019 00:56:02 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DFE6F2158A; Thu, 28 Nov 2019 00:56:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574902561; bh=Bpiyg5V6eOQvT7ggDjtfQ5yuPUTc9IVhVjJBUQaER7U=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=EmHEIYNcYPd3Iv5FUQIJaYjD1dLepZmN4pOpSJNObEmwzd3A1X7nNVubKVp7rp871 G5iDESCEMqk48F+97bulaWVqr6sv3/NEiJN6YQ53ow13ApleQmPiJpuXxmYsM5IeGo xoXLxPIQQWtrHAeFgbm37gxiS0eT6xPOMslh5Udc= Date: Wed, 27 Nov 2019 16:56:00 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Lars Kurth In-Reply-To: <2e4b36afaa73277d246d7e84037db1532a136ec7.1569525222.git.lars.kurth@citrix.com> Message-ID: References: <2e4b36afaa73277d246d7e84037db1532a136ec7.1569525222.git.lars.kurth@citrix.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Subject: Re: [win-pv-devel] [PATCH v2 6/6] Added Resolving Disagreement X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Lars Kurth , xen-api@lists.xenproject.org, minios-devel@lists.xenproject.org, committers@xenproject.org, mirageos-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, win-pv-devel@lists.xenproject.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" T24gVGh1LCAyNiBTZXAgMjAxOSwgTGFycyBLdXJ0aCB3cm90ZToKPiBGcm9tOiBMYXJzIEt1cnRo IDxsYXJzLmt1cnRoQGNpdHJpeC5jb20+Cj4gCj4gVGhpcyBndWlkZSBwcm92aWRlcyBCZXN0IFBy YWN0aWNlIG9uIGlkZW50aWZ5aW5nIGFuZCByZXNvbHZpbmcKPiBjb21tb24gY2xhc3NlcyBvZiBk aXNhZ3JlZW1lbnQKPiAKPiBTaWduZWQtb2ZmLWJ5OiBMYXJzIEt1cnRoIDxsYXJzLmt1cnRoQGNp dHJpeC5jb20+Cj4gLS0KPiBDYzogbWluaW9zLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCj4g Q2M6IHhlbi1hcGlAbGlzdHMueGVucHJvamVjdC5vcmcKPiBDYzogd2luLXB2LWRldmVsQGxpc3Rz LnhlbnByb2plY3Qub3JnCj4gQ2M6IG1pcmFnZW9zLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3Jn Cj4gQ2M6IGNvbW1pdHRlcnNAeGVucHJvamVjdC5vcmcKPiAtLS0KPiAgcmVzb2x2aW5nLWRpc2Fn cmVlbWVudC5tZCB8IDE0NiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCAxNDYgaW5zZXJ0aW9ucygrKQo+ICBjcmVhdGUgbW9k ZSAxMDA2NDQgcmVzb2x2aW5nLWRpc2FncmVlbWVudC5tZAo+IAo+IGRpZmYgLS1naXQgYS9yZXNv bHZpbmctZGlzYWdyZWVtZW50Lm1kIGIvcmVzb2x2aW5nLWRpc2FncmVlbWVudC5tZAo+IG5ldyBm aWxlIG1vZGUgMTAwNjQ0Cj4gaW5kZXggMDAwMDAwMC4uMTlhZWRiZQo+IC0tLSAvZGV2L251bGwK PiArKysgYi9yZXNvbHZpbmctZGlzYWdyZWVtZW50Lm1kCj4gQEAgLTAsMCArMSwxNDYgQEAKPiAr IyBSZXNvbHZpbmcgRGlzYWdyZWVtZW50Cj4gKwo+ICtUaGlzIGd1aWRlIHByb3ZpZGVzIEJlc3Qg UHJhY3RpY2Ugb24gcmVzb2x2aW5nIGRpc2FncmVlbWVudCwgc3VjaCBhcwo+ICsqIEdyYWNlZnVs bHkgYWNjZXB0IGNvbnN0cnVjdGl2ZSBjcml0aWNpc20KPiArKiBGb2N1cyBvbiB3aGF0IGlzIGJl c3QgZm9yIHRoZSBjb21tdW5pdHkKPiArKiBSZXNvbHZlIGRpZmZlcmVuY2VzIGluIG9waW5pb24g ZWZmZWN0aXZlbHkKPiArCj4gKyMjIFRoZW9yeTogUGF1bCBHcmFoYW0ncyBoaWVyYXJjaHkgb2Yg ZGlzYWdyZWVtZW50Cj4gK1BhdWwgR3JhaGFtIHByb3Bvc2VkIGEgKipkaXNhZ3JlZW1lbnQgaGll cmFyY2h5KiogaW4gYSAyMDA4IGVzc2F5IAo+ICsqKltIb3cgdG8gRGlzYWdyZWVdKGh0dHA6Ly93 d3cucGF1bGdyYWhhbS5jb20vZGlzYWdyZWUuaHRtbCkqKiwgcHV0dGluZyB0eXBlcyBvZgo+ICth cmd1bWVudHMgaW50byBhIHNldmVuLXBvaW50IGhpZXJhcmNoeSBhbmQgb2JzZXJ2aW5nIHRoYXQg Km1vdmluZyB1cCB0aGUKPiArZGlzYWdyZWVtZW50IGhpZXJhcmNoeSBtYWtlcyBwZW9wbGUgbGVz cyBtZWFuLCBhbmQgd2lsbCBtYWtlIG1vc3Qgb2YgdGhlbSBoYXBwaWVyKi4KPiArR3JhaGFtIGFs c28gc3VnZ2VzdGVkIHRoYXQgdGhlIGhpZXJhcmNoeSBjYW4gYmUgdGhvdWdodCBvZiBhcyBhIHB5 cmFtaWQsIGFzIHRoZSAKPiAraGlnaGVzdCBmb3JtcyBvZiBkaXNhZ3JlZW1lbnQgYXJlIHJhcmVy Lgo+ICsKPiArfCAhW0dyYWhhbSdzIEhpZXJhcmNoeSBvZiBEaXNhZ3JlZW1lbl0oaHR0cHM6Ly91 cGxvYWQud2lraW1lZGlhLm9yZy93aWtpcGVkaWEvY29tbW9ucy9hL2EzL0dyYWhhbSUyN3NfSGll cmFyY2h5X29mX0Rpc2FncmVlbWVudC1lbi5zdmcpIHwKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBeIERpc2FncmVlbWVudAoKVGhpcyBpcyBhIE5JVCBidXQgaW4gYSBmZXcgcGxhY2VzIGlu IHRoaXMgc2VyaWVzIHlvdSBnbyBvdmVyIHRoZQpvcmlnaW5hbCBsaW5lIGxlbmd0aC4KCgo+ICt8 ICpBIHJlcHJlc2VudGF0aW9uIG9mIEdyYWhhbSdzIGhpZXJhcmNoeSBvZiBkaXNhZ3JlZW1lbnQg ZnJvbSBbTG91ZGFjcmlzXShodHRwOi8vd3d3LmNyZWF0ZWRlYmF0ZS5jb20vdXNlci92aWV3cHJv ZmlsZS9Mb3VkYWNyaXMpIG1vZGlmaWVkIGJ5IFtSb2NrZXQwMDBdKGh0dHBzOi8vZW4ud2lraXBl ZGlhLm9yZy93aWtpL1VzZXI6Um9ja2V0MDAwKSogfAo+ICsKPiArSW4gdGhlIGNvbnRleHQgb2Yg dGhlIFhlbiBQcm9qZWN0IHdlIHN0cml2ZSB0byAqKm9ubHkgdXNlIHRoZSB0b3AgaGFsZioqIG9m IHRoZSBoaWVyYXJjaHkuCj4gKyoqTmFtZS1jYWxsaW5nKiogYW5kICoqQWQgaG9taW5lbSoqIGFy Z3VtZW50cyBhcmUgbm90IGFjY2VwdGFibGUgd2l0aGluIHRoZSBYZW4KPiArUHJvamVjdC4KPiAr Cj4gKyMjIElzc3VlOiBTY29wZSBjcmVlcAo+ICsKPiArT25lIHRoaW5nIHdoaWNoIG9jY2FzaW9u YWxseSBoYXBwZW5zIGR1cmluZyBjb2RlIHJldmlldyBpcyB0aGF0IGEgY29kZSByZXZpZXdlcgo+ ICthc2tzIG9yIGFwcGVhcnMgdG8gYXNrIHRoZSBhdXRob3Igb2YgcGF0Y2ggdG8gaW1wbGVtZW50 IGFkZGl0aW9uYWwgZnVuY3Rpb25hbGl0eS4KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgXiBhIHBhdGNoICAgICAgICAgICAgICAgICAgICAgIF4gZnVuY3Rpb25hbGl0aWVz IAoKCj4gK1RoaXMgY291bGQgdGFrZSBmb3IgZXhhbXBsZSB0aGUgZm9ybSBvZgo+ICs+IERvIHlv dSB0aGluayBpdCB3b3VsZCBiZSB1c2VmdWwgZm9yIHRoZSBjb2RlIHRvIGRvIFhYWD8gCj4gKz4g SSBjYW4gaW1hZ2luZSBhIHVzZXIgd2FudGluZyB0byBkbyBZWVkgKGFuZCBYWFggd291bGQgZW5h YmxlIHRoaXMpCj4gKwo+ICtUaGF0IHBvdGVudGlhbGx5IGFkZHMgYWRkaXRpb25hbCB3b3JrIGZv ciB0aGUgY29kZSBhdXRob3IsIHdoaWNoIHRoZXkgbWF5IG5vdCBoYXZlCj4gK3RoZSB0aW1lIHRv IHBlcmZvcm0uIEl0IGlzIGdvb2QgcHJhY3RpY2UgZm9yIGF1dGhvcnMgdG8gY29uc2lkZXIgc3Vj aCBhIHJlcXVlc3QgaW4gdGVybXMgb2YKPiArKiBVc2VmdWxuZXNzIHRvIHRoZSB1c2VyCj4gKyog Q29kZSBjaHVybiwgY29tcGxleGl0eSBvciBpbXBhY3Qgb24gb3RoZXIgc3lzdGVtIHByb3BlcnRp ZXMKPiArKiBFeHRyYSB0aW1lIHRvIGltcGxlbWVudCBhbmQgcmVwb3J0IGJhY2sgdG8gdGhlIHJl dmlld2VyCj4gKwo+ICtJZiB5b3UgYmVsaWV2ZSB0aGF0IHRoZSBpbXBhY3QvY29zdCBpcyB0b28g aGlnaCwgcmVwb3J0IGJhY2sgdG8gdGhlIHJldmlld2VyLiBUbyByZXNvbHZlCj4gK3RoaXMsIGl0 IGlzIGFkdmlzYWJsZSB0bwo+ICsqIFJlcG9ydCB5b3VyIGZpbmRpbmdzCj4gKyogQW5kIHRoZW4g Y2hlY2sgd2hldGhlciB0aGlzIHdhcyBtZXJlbHkgYW4gaW50ZXJlc3Rpbmcgc3VnZ2VzdGlvbiwg b3Igc29tZXRoaW5nIHRoZQo+ICtyZXZpZXdlciBmZWVscyBtb3JlIHN0cm9uZ2x5IGFib3V0Cj4g Kwo+ICtJbiB0aGUgbGF0dGVyIGNhc2UsIHRoZXJlIGFyZSB0eXBpY2FsbHkgc2V2ZXJhbCBjb21t b24gb3V0Y29tZXMKPiArKiBUaGUgKiphdXRob3IgYW5kIHJldmlld2VyIGFncmVlKiogdGhhdCB0 aGUgc3VnZ2VzdGlvbiBzaG91bGQgYmUgaW1wbGVtZW50ZWQKPiArKiBUaGUgKiphdXRob3IgYW5k IHJldmlld2VyIGFncmVlKiogdGhhdCBpdCBtYXkgbWFrZSBzZW5zZSB0byBkZWZlciBpbXBsZW1l bnRhdGlvbgo+ICsqIFRoZSAqKmF1dGhvciBhbmQgcmV2aWV3ZXIgYWdyZWUqKiB0aGF0IGl0IG1h a2VzIG5vIHNlbnNlIHRvIGltcGxlbWVudCB0aGUgc3VnZ2VzdGlvbgo+ICsKPiArVGhlIGF1dGhv ciBvZiBhIHBhdGNoIHdvdWxkIHR5cGljYWxseSBzdWdnZXN0IHRoZWlyIHByZWZlcnJlZCBvdXRj b21lLCBmb3IgZXhhbXBsZQo+ICs+IEkgYW0gbm90IHN1cmUgaXQgaXMgd29ydGggdG8gaW1wbGVt ZW50IFhYWAo+ICs+IERvIHlvdSB0aGluayB0aGlzIGNvdWxkIGJlIGRvbmUgYXMgYSBzZXBhcmF0 ZSBwYXRjaCBpbiBmdXR1cmU/Cj4gKwo+ICtJbiBjYXNlcywgd2hlcmUgbm8gYWdyZWVtZW50IGNh biBiZSBmb3VuZCwgdGhlIGJlc3QgYXBwcm9hY2ggd291bGQgYmUgdG8gZ2V0IGFuCj4gK2luZGVw ZW5kZW50IG9waW5pb24gZnJvbSBhbm90aGVyIG1haW50YWluZXIgb3IgdGhlIHByb2plY3QncyBs ZWFkZXJzaGlwIHRlYW0uCgpJIHRoaW5rIHdlIHNob3VsZCBtZW50aW9uIHNvbWV3aGVyZSBoZXJl IHRoYXQgaXQgaXMgcmVjb21tZW5kZWQgZm9yCnJldmlld2VycyB0byBiZSBleHBsaWNpdCBhYm91 dCB3aGV0aGVyIGEgcmVxdWVzdCBpcyBvcHRpb25hbCBvciB3aGV0aGVyCml0IGlzIGEgcmVxdWly ZW1lbnQuCgpGb3IgaW5zdGFuY2U6ICJJIHRoaW5rIGl0IHdvdWxkIGJlIGdvb2QgaWYgWCBhbHNv IGRpZCBZIiBkb2Vzbid0IHNheSBpZgppdCBpcyBvcHRpb25hbCAoZnV0dXJlIHdvcmspIG9yIGl0 IGlzIGFjdHVhbGx5IHJlcXVpcmVkIGFzIHBhcnQgb2YgdGhpcwpzZXJpZXMuIE1vcmUgZXhwbGlj aXQgd29yZCBjaG9pY2VzIGFyZSBwcmVmZXJhYmxlLCBzdWNoIGFzOgoKIkkgdGhpbmsgaXQgd291 bGQgYmUgZ29vZCBpZiBYIGFsc28gZGlkIFksIG5vdCBhIHJlcXVpcmVtZW50IGJ1dCBnb29kIHRv CmhhdmUuIgoKIkkgdGhpbmsgaXQgd291bGQgYmUgZ29vZCBpZiBYIGFsc28gZGlkIFkgYW5kIGl0 IHNob3VsZCBiZSBwYXJ0IG9mIHRoaXMKc2VyaWVzLiIKCkl0IGhlbHBzIG1ha2UgdGhlIGNvbW11 bmljYXRpb24gd2l0aCB0aGUgYXV0aG9yIG1vcmUgZWZmZWN0aXZlLAplc3BlY2lhbGx5IGluIHRo aXMga2luZCBvZiBzaXR1YXRpb25zLgoKCj4gKyMjIElzc3VlOiBbQmlrZXNoZWRkaW5nXShodHRw czovL2VuLndpa3Rpb25hcnkub3JnL3dpa2kvYmlrZXNoZWRkaW5nKQo+ICsKPiArT2NjYXNpb25h bGx5IGRpc2N1c3Npb25zIGFib3V0IHVuaW1wb3J0YW50IGJ1dCBlYXN5LXRvLWdyYXNwIGlzc3Vl cyBjYW4gbGVhZCB0bwo+ICtwcm9sb25nZWQgYW5kIHVucHJvZHVjdGl2ZSBkaXNjdXNzaW9uLiBU aGUgYmVzdCB3YXkgdG8gYXBwcm9hY2ggdGhpcyBpcyB0bwogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBeIGRpc2N1c3Npb25zCgoKPiArdHJ5IGFuZCAqKmFudGljaXBhdGUqKiBiaWtlc2hl ZGRpbmcgYW5kIGhpZ2hsaWdodCBpdCBhcyBzdWNoIHVwZnJvbnQuIEhvd2V2ZXIsIHRoZQo+ICtm b3JtYXQgb2YgYSBjb2RlIHJldmlldyBkb2VzIG5vdCBhbHdheXMgbGVuZCBpdHNlbGYgd2VsbCB0 byB0aGlzIGFwcHJvYWNoLCBleGNlcHQKPiArZm9yIGhpZ2hsaWdodGluZyBpdCBpbiB0aGUgY292 ZXIgbGV0dGVyIG9mIGEgcGF0Y2ggc2VyaWVzLgo+ICsKPiArSG93ZXZlciwgdHlwaWNhbGx5IEJp a2VzaGVkZGluZyBpc3N1ZXMgYXJlIGZhaXJseSBlYXN5IHRvIHJlY29nbml6ZSBpbiBhIGNvZGUg cmV2aWV3LAo+ICthcyB5b3Ugd2lsbCB2ZXJ5IHF1aWNrbHkgZ2V0IGRpZmZlcmVudCByZXZpZXdl cnMgcHJvdmlkaW5nIGRpZmZlcmluZyBvcGluaW9ucy4gSW4gdGhpcyBjYXNlCj4gK2l0IGlzIGJl c3QgZm9yIHRoZSBhdXRob3Igb3IgYSByZXZpZXdlciB0byBjYWxsIG91dCB0aGUgcG90ZW50aWFs IGJpa2VzaGVkZGluZyBpc3N1ZSB1c2luZwo+ICtzb21ldGhpbmcgbGlrZQo+ICsKPiArPiBMb29r cyB3ZSBoYXZlIGEgYmlrZXNoZWRkaW5nIGlzc3VlIGhlcmUKPiArPiBJIHRoaW5rIHdlIHNob3Vs ZCBjYWxsIGEgcXVpY2sgdm90ZSB0byBzZXR0bGUgdGhlIGlzc3VlCj4gKwo+ICtPdXIgZ292ZXJu YW5jZSBwcm92aWRlcyB0aGUgbWVjaGFuaXNtcyBvZiBbaW5mb3JtYWwgdm90ZXNdKGh0dHBzOi8v eGVucHJvamVjdC5vcmcvZGV2ZWxvcGVycy9nb3Zlcm5hbmNlLyNpbmZvcm1hbC12b3Rlcy1vci1z dXJ2ZXlzKSBvcgo+ICtbbGF6eSB2b3RpbmddKGh0dHBzOi8veGVucHJvamVjdC5vcmcvZGV2ZWxv cGVycy9nb3Zlcm5hbmNlLyNsYXp5Y29uc2Vuc3VzKSB3aGljaCBsZW5kCj4gK3RoZW1zZWx2ZXMg d2VsbCB0byByZXNvbHZlIHN1Y2ggaXNzdWVzLgo+ICsKPiArIyMgSXNzdWU6IFNtYWxsIGZ1bmN0 aW9uYWwgaXNzdWVzCj4gKwo+ICtUaGUgbW9zdCBjb21tb24gYXJlYSBvZiBkaXNhZ3JlZW1lbnRz IHdoaWNoIGhhcHBlbiBpbiBjb2RlIHJldmlld3MsIGFyZSBkaWZmZXJpbmcKPiArb3BpbmlvbnMg b24gd2hldGhlciBzbWFsbCBmdW5jdGlvbmFsIGlzc3VlcyBpbiBhIHBhdGNoIHNlcmllcyBoYXZl IHRvIGJlIHJlc29sdmVkIG9yCj4gK25vdCBiZWZvcmUgdGhlIGNvZGUgaXMgcmVhZHkgdG8gYmUg c3VibWl0dGVkLiBTdWNoIGRpc2FncmVlbWVudHMgYXJlIHR5cGljYWxseSBjYXVzZWQKPiArYnkg ZGlmZmVyZW50IGV4cGVjdGF0aW9ucyByZWxhdGVkIHRvIHRoZSBsZXZlbCBvZiBwZXJmZWN0aW9u IGEgcGF0Y2ggc2VyaWVzIG5lZWRzIHRvIGZ1bGZpbAo+ICtiZWZvcmUgaXQgY2FuIGJlIGNvbnNp ZGVyZWQgcmVhZHkgdG8gYmUgY29tbWl0dGVkLgo+ICsKPiArVG8gZXhwbGFpbiB0aGlzIGJldHRl ciwgSSBhbSBnb2luZyB0byB1c2UgdGhlIGFuYWxvZ3kgb2Ygc29tZSBidWlsZGluZyB3b3JrIHRo YXQgaGFzCj4gK2JlZW4gcGVyZm9ybWVkIGF0IHlvdXIgaG91c2UuIExldCdzIHNheSB0aGF0IHlv dSBoYXZlIGEgbmV3IGJhdGhyb29tIGluc3RhbGxlZC4KPiArQmVmb3JlIHBheWluZyB5b3VyIGJ1 aWxkZXIgdGhlIGxhc3QgaW5zdGFsbWVudCwgeW91IHBlcmZvcm0gYW4gaW5zcGVjdGlvbiBhbmQg eW91IGZpbmQKPiAraXNzdWVzIHN1Y2ggYXMKPiArKiBUaGUgc2VhbHMgYXJvdW5kIHRoZSBiYXRo dHViIGFyZSBub3QgcGVyZmVjdGx5IGV2ZW50CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBeIGV2ZW4KCj4gKyogV2hlbiB5b3Ugb3BlbiB0aGUgdGFw LCB0aGUgcGx1bWJpbmcgaW5pdGlhbGx5IG1ha2VzIHNvbWUgbG91ZCBub2lzZQo+ICsqIFRoZSBz aG93ZXIgbWl4ZXIgaGFzIGJlZW4gaW5zdGFsbGVkIHRoZSB3cm9uZyB3YXkgYXJvdW5kCj4gKwo+ ICtJbiBhbGwgdGhlc2UgY2FzZXMsIHRoZSBiYXRocm9vbSBpcyBwZXJmZWN0bHkgZnVuY3Rpb25h bCwgYnV0IG5vdCBwZXJmZWN0LiBBdCB0aGlzIHBvaW50Cj4gK3lvdSBoYXZlIHRoZSBjaG9pY2Ug dG8gdHJ5IGFuZCBnZXQgYWxsIHRoZSBpc3N1ZXMgYWRkcmVzc2VkLCB3aGljaCBpbiB0aGUgZXhh bXBsZSBvZgo+ICt0aGUgc2hvd2VyIG1peGVyIG1heSByZXF1aXJlIHNpZ25pZmljYW50IHJlLXdv cmsgYW5kIHBvdGVudGlhbGx5IHB1c2gtYmFjayBmcm9tIHlvdXIKPiArYnVpbGRlci4gWW91IG1h eSBoYXZlIHRvIHJlZmVyIHRvIHRoZSBpbml0aWFsIHN0YXRlbWVudCBvZiB3b3JrLCBidXQgaXQg dHVybnMgb3V0IGl0IGRvZXMKPiArbm90IGNvbnRhaW4gc3VmZmljaWVudCBpbmZvcm1hdGlvbiB0 byBhc2NlcnRhaW4gd2hldGhlciB5b3VyIGJ1aWxkZXIgaGFkIGNvbW1pdHRlZCB0bwo+ICt0aGUg bGV2ZWwgb2YgcXVhbGl0eSB5b3Ugd2VyZSBleHBlY3RpbmcuCj4gKwo+ICtTaW1pbGFyIHNpdHVh dGlvbnMgaGFwcGVuIGluIGNvZGUgcmV2aWV3cyB2ZXJ5IGZyZXF1ZW50bHkgYW5kIGNhbiBsZWFk IHRvIGEgbG9uZwo+ICtkaXNjdXNzaW9uIGJlZm9yZSBpdCBjYW4gYmUgcmVzb2x2ZWQuIFRoZSBt b3N0IGltcG9ydGFudCB0aGluZyBpcyB0byAqKmlkZW50aWZ5KioKPiArYSBkaXNhZ3JlZW1lbnQg YXMgc3VjaCBlYXJseSBhbmQgdGhlbiBjYWxsIGl0IG91dC4gVGlwcyBvbiBob3cgdG8gZG8gdGhp cywgY2FuIGJlIGZvdW5kCj4gK1toZXJlXShjb21tdW5pY2F0aW9uLXByYWN0aWNlLm1kI01pc3Vu ZGVyc3RhbmRpbmdzKS4KPiArCj4gK0F0IHRoaXMgcG9pbnQsIHlvdSB3aWxsIHVuZGVyc3RhbmQg d2h5IHlvdSBoYXZlIHRoZSBkaXNhZ3JlZW1lbnQsIGJ1dCBub3QgbmVjZXNzYXJpbHkKPiArYWdy ZWVtZW50IG9uIGhvdyB0byBtb3ZlIGZvcndhcmQuIEFuIGVhc3kgZml4IHdvdWxkIGJlIHRvIGFn cmVlIHRvIHN1Ym1pdCB0aGUgY2hhbmdlCj4gK2FzIGl0IGlzIGFuZCBmaXggaXQgaW4gZnV0dXJl LiBJbiBhIGNvcnBvcmF0ZSBzb2Z0d2FyZSBlbmdpbmVlcmluZyBlbnZpcm9ubWVudCB0aGlzIGlz IHRoZQo+ICttb3N0IGxpa2VseSBvdXRjb21lLCBidXQgaW4gb3BlbiBzb3VyY2UgY29tbXVuaXRp ZXMgYWRkaXRpb25hbCBjb25jZXJucyBoYXZlIHRvIGJlCj4gK2NvbnNpZGVyZWQuCj4gKyogQ29k ZSByZXZpZXdlcnMgZnJlcXVlbnRseSBoYXZlIGJlZW4gaW4gdGhpcyBzaXR1YXRpb24gYmVmb3Jl IHdpdGggdGhlIG1vc3QgY29tbW9uCj4gKyAgb3V0Y29tZSB0aGF0IHRoZSBpc3N1ZSBpcyB0aGVu IG5ldmVyIGZpeGVkLiBCeSBhY2NlcHRpbmcgdGhlIGNoYW5nZSwgdGhlIHJldmlld2Vycwo+ICsg IGhhdmUgbm8gbGV2ZXJhZ2UgdG8gZml4IHRoZSBpc3N1ZSBhbmQgbWF5IGhhdmUgdG8gc3BlbmQg ZWZmb3J0IGZpeGluZyB0aGUgaXNzdWUKPiArICB0aGVtc2VsdmVzIGluIGZ1dHVyZSBhcyBpdCBt YXkgaW1wYWN0IHRoZSBwcm9kdWN0IHRoZXkgYnVpbHQgb24gdG9wIG9mIHRoZSBjb2RlLgo+ICsq IENvbnZlcnNlbHksIGEgcmV2aWV3ZXIgbWF5IGJlIGFza2luZyB0aGUgYXV0aG9yIHRvIG1ha2Ug dG9vIG1hbnkgY2hhbmdlcyBvZiB0aGlzCj4gKyAgdHlwZSB3aGljaCB1bHRpbWF0ZWx5IG1heSBs ZWFkIHRoZSBhdXRob3IgdG8gbm90IGNvbnRyaWJ1dGUgdG8gdGhlIHByb2plY3QgYWdhaW4uCj4g KyogQW4gYXV0aG9yLCB3aGljaCBjb25zaXN0ZW50bHkgZG9lcyBub3QgYWRkcmVzcyAqKmFueSoq IG9mIHRoZXNlIGlzc3VlcyBtYXkgZW5kIHVwCj4gKyAgZ2V0dGluZyBhIGJhZCByZXB1dGF0aW9u IGFuZCBtYXkgZmluZCBmdXR1cmUgY29kZSByZXZpZXdzIG1vcmUgZGlmZmljdWx0Lgo+ICsqIEFu IGF1dGhvciB3aGljaCBhbHdheXMgYWRkcmVzc2VzICoqYWxsKiogb2YgdGhlc2UgaXNzdWVzIG1h eSBlbmQgdXAgZ2V0dGluZyBpbnRvCj4gKyAgZGlmZmljdWx0aWVzIHdpdGggdGhlaXIgZW1wbG95 ZXIsIGFzIHRoZXkgYXJlIHRvbyBzbG93IGdldHRpbmcgY29kZSB1cHN0cmVhbWVkLgo+ICsKPiAr Tm9uZSBvZiB0aGVzZSBvdXRjb21lcyBhcmUgZ29vZCwgc28gdWx0aW1hdGVseSBhIGJhbGFuY2Ug aGFzIGJlZW4gZm91bmQuIEF0IHRoZSBlbmQKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXiB5b3UgbWVhbiAiaGFzIHRvIGJlIGZvdW5k PyIKCgo+ICtvZiB0aGUgZGF5LCB0aGUgc29sdXRpb24gc2hvdWxkIGZvY3VzIG9uIHdoYXQgaXMg YmVzdCBmb3IgdGhlIGNvbW11bml0eSwgd2hpY2ggbWF5Cj4gK21lYW4gYXNraW5nIGZvciBhbiBp bmRlcGVuZGVudCBvcGluaW9uIGFzIG91dGxpbmVkIGluIHRoZSBuZXh0IHNlY3Rpb24uCgpJIHRo aW5rIHRoZXJlIGlzIHNvbWV0aGluZyBlbHNlIHdlIHNob3VsZCBzYXkgb24gdGhpcyB0b3BpYy4g VGhlcmUgaXMgYQpjYXRlZ29yeSBvZiB0aGluZ3Mgd2hpY2ggY291bGQgYmUgZG9uZSBpbiBtdWx0 aXBsZSB3YXlzIGFuZCBpdCBpcyBub3QKb3ZlcnRseSBvYnZpb3VzIHdoaWNoIG9uZSBpcyBiZXN0 LiBJdCBpcyBkb25lIHRvIHRoZSBtYWludGFpbmVyIGFuZCB0aGUKYXV0aG9yIHBlcnNvbmFsIHN0 eWxlcy4gSXQgaXMgZWFzeSB0byBkaXNhZ3JlZSBvbiB0aGF0LgoKSSB0aGluayBhIGdvb2QgcmVj b21tZW5kYXRpb24gd291bGQgYmUgZm9yIHRoZSBjb250cmlidXRvciB0byB0cnkgdG8KZm9sbG93 IHRoZSBtYWludGFpbmVycyByZXF1ZXN0cywgZXZlbiBpZiB0aGV5IGNvdWxkIGJlIGNvbnNpZGVy ZWQKInN0eWxlIiwgdHJ1c3RpbmcgdGhlaXIgZXhwZXJpZW5jZSBvbiB0aGUgbWF0dGVyLiBBbmQg YSBnb29kCnJlY29tbWVuZGF0aW9uIGZvciB0aGUgbWFpbnRhaW5lciB3b3VsZCBiZSB0byB0cnkg dG8gbGV0IHRoZSBjb250cmlidXRvcgpoYXZlIGZyZWVkb20gb2YgaW1wbGVtZW50YXRpb24gY2hv aWNlIG9uIHRoaW5ncyB0aGF0IGRvbid0IG1ha2UgYQpzaWduaWZpY2FudCBkaWZmZXJlbmNlLgoK Cj4gKyMjIFJlc29sdXRpb246IEFza2luZyBmb3IgYW4gaW5kZXBlbmRlbnQgb3Bpbmlvbgo+ICsK PiArTW9zdCBkaXNhZ3JlZW1lbnRzIGNhbiBiZSBzZXR0bGVkIGJ5Cj4gKyogQXNraW5nIGFub3Ro ZXIgbWFpbnRhaW5lciBvciBjb21taXR0ZXIgdG8gcHJvdmlkZSBhbiBpbmRlcGVuZGVudCBvcGlu aW9uIG9uIHRoZQo+ICsgIHNwZWNpZmljIGlzc3VlIGluIHB1YmxpYyB0byBoZWxwIHJlc29sdmUg aXQKPiArKiBGYWlsaW5nIHRoaXMgYW4gaXNzdWUgY2FuIGJlIGVzY2FsYXRlZCB0byB0aGUgcHJv amVjdCBsZWFkZXJzaGlwIHRlYW0sIHdoaWNoIGlzCj4gKyAgZXhwZWN0ZWQgdG8gYWN0IGFzIHJl ZmVyZWUgYW5kIG1ha2UgYSBkZWNpc2lvbiBvbiBiZWhhbGYgb2YgdGhlIGNvbW11bml0eQo+ICsK PiArSWYgeW91IGZlZWwgdW5jb21mb3J0YWJsZSB3aXRoIHRoaXMgYXBwcm9hY2gsIHlvdSBtYXkg YWxzbyBjb250YWN0Cj4gK21lZGlhdGlvbkB4ZW5wcm9qZWN0Lm9yZyB0byBnZXQgYWR2aWNlLiBT ZWUgb3VyIFtDb21tdW5pY2F0aW9uIEd1aWRlXShjb21tdW5pY2F0aW9uLWd1aWRlLm1kKQo+ICtm b3IgbW9yZSBpbmZvcm1hdGlvbi4KPiArCj4gKyMjIERlY2lzaW9uIG1ha2luZyBhbmQgY29uZmxp Y3QgcmVzb2x1dGlvbiBpbiBvdXIgZ292ZXJuYW5jZQo+ICsKPiArT3VyIFtnb3Zlcm5hbmNlXSho dHRwczovL3hlbnByb2plY3Qub3JnL2RldmVsb3BlcnMvZ292ZXJuYW5jZS8jZGVjaXNpb25zKSBj b250YWlucwo+ICtzZXZlcmFsIHByb3ZlbiBtZWNoYW5pc21zIHRvIGhlbHAgd2l0aCBkZWNpc2lv biBtYWtpbmcgYW5kIGNvbmZsaWN0IHJlc29sdXRpb24uCj4gKwo+ICtTZWUKPiArKiBbRXhwcmVz c2luZyBhZ3JlZW1lbnQgYW5kIGRpc2FncmVlbWVudF0oaHR0cHM6Ly94ZW5wcm9qZWN0Lm9yZy9k ZXZlbG9wZXJzL2dvdmVybmFuY2UvI2V4cHJlc3NpbmdvcGluaW9uKQo+ICsqIFtMYXp5IGNvbnNl bnN1cyAvIExhenkgdm90aW5nXShodHRwczovL3hlbnByb2plY3Qub3JnL2RldmVsb3BlcnMvZ292 ZXJuYW5jZS8jbGF6eWNvbnNlbnN1cykKPiArKiBbSW5mb3JtYWwgdm90ZXMgb3Igc3VydmV5c10o aHR0cHM6Ly94ZW5wcm9qZWN0Lm9yZy9kZXZlbG9wZXJzL2dvdmVybmFuY2UvI2luZm9ybWFsLXZv dGVzLW9yLXN1cnZleXMpCj4gKyogW0xlYWRlcnNoaXAgdGVhbSBkZWNpc2lvbnNdKGh0dHBzOi8v eGVucHJvamVjdC5vcmcvZGV2ZWxvcGVycy9nb3Zlcm5hbmNlLyNsZWFkZXJzaGlwKQo+ICsqIFtD b25mbGljdCByZXNvbHV0aW9uXShodHRwczovL3hlbnByb2plY3Qub3JnL2RldmVsb3BlcnMvZ292 ZXJuYW5jZS8jY29uZmxpY3QpCj4gLS0gCj4gMi4xMy4wCj4gCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwp3aW4tcHYtZGV2ZWwgbWFpbGluZyBsaXN0Cndp bi1wdi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qu b3JnL21haWxtYW4vbGlzdGluZm8vd2luLXB2LWRldmVs From win-pv-devel-bounces@lists.xenproject.org Thu Nov 28 00:58:05 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 28 Nov 2019 00:58:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ia88D-0000sM-D1; Thu, 28 Nov 2019 00:58:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ia88C-0000s2-Jy for win-pv-devel@lists.xenproject.org; Thu, 28 Nov 2019 00:58:04 +0000 X-Inumbo-ID: 183b98ce-117a-11ea-9db0-bc764e2007e4 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 183b98ce-117a-11ea-9db0-bc764e2007e4; Thu, 28 Nov 2019 00:57:48 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3BB9B2158A; Thu, 28 Nov 2019 00:57:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574902667; bh=VocRQC81uijdlCIkQxZBQUXbCXlViahRm4+D/EdQkgs=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=g65YAILesA0yNGByW9W0D1IvzJyMiEy8+g1q9vMXAH8AUh/7bOdhLqThQdH7aJaLP i+PpRJ0+dDds/wMyCc7vFoNDvizvXfY6O+qsLFxC/UOnf9tRkWMjqJFmDEJjhXQJMr JrSbo1DYocM89IEEpA43ZKlOCbZpWU+lR09+RKOE= Date: Wed, 27 Nov 2019 16:57:46 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Lars Kurth In-Reply-To: <749f082bdb996ba7c7362847b22030882dc2903f.1569525222.git.lars.kurth@citrix.com> Message-ID: References: <749f082bdb996ba7c7362847b22030882dc2903f.1569525222.git.lars.kurth@citrix.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1207343631-1574899973=:27669" Content-ID: Subject: Re: [win-pv-devel] [PATCH v2 5/6] Add guide on Communication Best Practice X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Lars Kurth , xen-api@lists.xenproject.org, minios-devel@lists.xenproject.org, committers@xenproject.org, mirageos-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, win-pv-devel@lists.xenproject.org Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1207343631-1574899973=:27669 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Thu, 26 Sep 2019, Lars Kurth wrote: > From: Lars Kurth > > This guide covers the bulk on Best Practice related to code review > It primarily focusses on code review interactions > It also covers how to deal with Misunderstandings and Cultural > Differences > > Signed-off-by: Lars Kurth > --- > Cc: minios-devel@lists.xenproject.org > Cc: xen-api@lists.xenproject.org > Cc: win-pv-devel@lists.xenproject.org > Cc: mirageos-devel@lists.xenproject.org > Cc: committers@xenproject.org > --- > communication-practice.md | 410 ++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 410 insertions(+) > create mode 100644 communication-practice.md > > diff --git a/communication-practice.md b/communication-practice.md > new file mode 100644 > index 0000000..db9a5ef > --- /dev/null > +++ b/communication-practice.md > @@ -0,0 +1,410 @@ > +# Communication Best Practice > + > +This guide provides communication Best Practice that helps you in > +* Using welcoming and inclusive language > +* Keeping discussions technical and actionable > +* Being respectful of differing viewpoints and experiences > +* Being aware of your own and counterpart’s communication style and culture > +* Show empathy towards other community members > + > +## Code reviews for **reviewers** and **patch authors** > + > +Before embarking on a code review, it is important to remember that > +* A poorly executed code review can hurt the contributors feeling, even when a reviewer > + did not intend to do so. Feeling defensive is a normal reaction to a critique or feedback. > + A reviewer should be aware of how the pitch, tone, or sentiment of their comments > + could be interpreted by the contributor. The same applies to responses of an author > + to the reviewer. > +* When reviewing someone's code, you are ultimately looking for issues. A good code > + reviewer is able to mentally separate finding issues from articulating code review > + comments in a constructive and positive manner: depending on your personality this > + can be **difficult** and you may need to develop a technique that works for you. > +* As software engineers we like to be proud of the solutions we came up with. This can > + make it easy to take another people’s criticism personally. Always remember that it is > + the code that is being reviewed, not you as a person. > +* When you receive code review feedback, please be aware that we have reviewers > + from different backgrounds, communication styles and cultures. Although we all trying > + to create a productive, welcoming and agile environment, we do not always succeed. > + > +### Express appreciation > +As the nature of code review to find bugs and possible issues, it is very easy for > +reviewers to get into a mode of operation where the patch review ends up being a list > +of issues, not mentioning what is right and well done. This can lead to the code > +submitter interpreting your feedback in a negative way. > + > +The opening of a code review provides an opportunity to address this and also sets the > +tone for the rest of the code review. Starting **every** review on a positive note, helps > +set the tone for the rest of the review. > + > +For an initial patch, you can use phrases such as > +> Thanks for the patch > +> Thanks for doing this > + > +For further revisions within a review, phrases such as > +> Thank you for addressing the last set of changes > + > +If you believe the code was good, it is good practice to highlight this by using phrases > +such as > +> Looks good, just a few comments > +> The changes you have made since the last version look good > + > +If you think there were issues too many with the code to use one of the phrases, > +you can still start on a positive note, by for example saying > +> I think this is a good change > +> I think this is a good feature proposal > + > +It is also entirely fine to highlight specific changes as good. The best place to > +do this, is at top of a patch, as addressing code review comments typically requires ^ the top > +a contributor to go through the list of things to address and an in-lined positive > +comment is likely to break that workflow. > + > +You should also consider, that if you review a patch of an experienced > +contributor phrases such as *Thanks for the patch* could come across as > +patronizing, while using *Thanks for doing this* is less likely to be interpreted > +as such. > + > +Appreciation should also be expressed by patch authors when asking for clarifications > +to a review or responding to questions. A simple > +> Thank you for your feedback > +> Thank you for your reply > +> Thank you XXX! > + > +is normally sufficient. > + > +### Avoid opinion: stick to the facts > +The way how a reviewer expresses feedback, has a big impact on how the author > +perceives the feedback. Key to this is what we call **stick to the facts**. The same is > +true when a patch author is responding to a comment from a reviewer. > + > +One of our maintainers has been studying Mandarin for several years and has come > +across the most strongly-worded dictionary entry > +[he has ever seen](https://youtu.be/ehZvBmrLRwg?t=834). This example > +illustrates the problem of using opinion in code reviews vs. using facts extremely well. > + > +> 裹脚 (guo3 jiao3): foot-binding (a vile feudal practice which crippled women both > +> physically and spiritually) > + > +This is not something one is used to hearing from dictionary entries. Once you > +investigate the practice foot-binding, it is hard to disagree with the dictionart entry. > +However, the statement does not contain much information. If you read it without > +knowing what foot-binding is, it is hard to be convinced by this statement. The main > +take-away is that the author of the dictionary entry had strong opinions about this topic. > +It does not tell you, why you should have the same opinion. ^ remove , > + > +Compare this to the (Wikipedia entry)[https://en.wikipedia.org/wiki/Foot_binding] > + > +> Foot binding was the custom of applying tight binding to the feet of young girls to > +> modify the shape and size of their feet. ... foot binding was a painful practice and > +> significantly limited the mobility of women, resulting in lifelong disabilities for most of > +> its subjects. ... Binding usually started during the winter months since the feet were > +> more likely to be numb, and therefore the pain would not be as extreme. …The toes on > +> each foot were curled under, then pressed with great force downwards and squeezed > +> into the sole of the foot until the toes broke… > + > +Without going into the details of foot-binding, it is noticeable that none of what is written > +above uses opinion which could be interpreted as inflammatory language. It is a list of > +simple facts that are laid out in a way that make it obvious what the correct conclusion > +is. > + > +Because the Wikipedia entry is entirely fact based it is more powerful and persuasive > +then the dictionary entry. The same applies to code reviews. > + > +Making statements in code reviews such as > +> Your code is garbage > +> This idea is stupid > + > +besides being an opinion is rude and counter productive > +* It will make the patch author angry: instead of finding a solution to the problem the > + author will spend time and mental energy wrestling with their feelings > +* It does not contain any information > +* Facts are both more powerful and more persuasive > + > +Consider the following two pieces of feedback on a piece of code > +> This piece of code is confusing > +> It took me a long time to figure out what was going on here > + > +The first example expresses an opinion, whereas the second re-phrases the statement > +in terms of what you experienced, which is a fact. > + > +Other examples: > +> BAD: This is fragile > +> SOMEWHAT BETTER: This seems fragile to me > +> BEST: If X happens, Y will happen. > + > +A certain piece of code can be written in many different ways: this can lead to > +disagreements on the best architecture, design or coding pattern. As already pointed out > +in this section: avoid feedback that is opinion-based and thus does not add any value. > +Back your criticism (or idea on how to solve a problem) with a sensible rationale. > + > +### Review the code, not the person > +Without realizing it, it is easy to overlook the difference between insightful critique of > +code and personal criticism. Let's look at a theoretical function where there is an > +opportunity to return out of the function early. In this case, you could say > + > +> You should return from this function early, because of XXX > + > +On its own, there is nothing wrong with this statement. However, a code review is made > +up of multiple comments and using **You should** consistently can start to feel negative > +and can be mis-interpreted as a personal attack. Using something like avoids this issue: > + > +> Returning from this function early is better, because of XXX > + > +Without personal reference, a code review will communicate the problem, idea or issue > +without risking mis-interpretation. > + > +### Verbose vs. terse > +Due to the time it takes to review and compose code reviewer, reviewers often adopt a > +terse style. It is not unusual to see review comments such as > +> typo > +> s/resions/regions/ > +> coding style > +> coding style: brackets not needed > +etc. > + > +Terse code review style has its place and can be productive for both the reviewer and > +the author. However, overuse can come across as unfriendly, lacking empathy and > +can thus create a negative impression with the author of a patch. This is in particular > +true, when you do not know the author or the author is a newcomer. Terse > +communication styles can also be perceived as rude in some cultures. > + > +If you tend to use a terse commenting style and you do not know whether the author > +is OK with it, it is often a good idea to compensate for it in the code review opening > +(where you express appreciation) or when there is a need for verbose expression. > + > +It is also entirely fine to mention that you have a fairly terse communication style > +and ask whether the author is OK with it. In almost all cases, they will be: by asking > +you are showing empathy that helps counteract a negative impression. > + > +### Code Review Comments should be actionable > +Code review comments should be actionable: in other words, it needs to be clear > +what the author of the code needs to do to address the issue you identified. > + > +Statements such as > +> BAD: This is wrong > +> BAD: This does not work > +> BETTER, BUT NOT GOOD: This does not work, because of XXX > + > +do not normally provide the author of a patch with enough information to send out a > +new patch version. By doing this, you essentially force the patch author to **find** and > +**implement** an alternative, which then may also not be acceptable to you as the > +**reviewer** of the patch. > + > +A better way to approach this is to say > + > +> This does not work, because of XXX > +> You may want to investigate YYY and ZZZ as alternatives > + > +In some cases, it may not be clear whether YYY or ZZZ are the better solution. As a > +reviewer you should be as up-front and possible in such a case and say something like > + > +> I am not sure whether YYY and ZZZ are better, so you may want to outline your > +> thoughts about both solutions by e-mail first, such that we can decide what works > +> best > + > +### Identify the severity of an issue or disagreement > +By default, every comment which is made **ought to be addressed** by the author. > +However, often reviewers note issues, which would be nice if they were addressed, > +but are not mandatory. > + > +Typically, reviewers use terminology such as > +> This would be a nice-to-have > +> This is not a blocker > + > +Some maintainers use > +> NIT: XXX > + > +however, it is sometimes also used to indicate a minor issue that **must** be fixed. > > +During a code review, it can happen that reviewer and author disagree on how to move > +forward. The default position when it comes to disagreements is that **both parties > +want to argue their case**. However, frequently one or both parties do not feel that > +strongly about a specific issue. > + > +Within the Xen Project, we have [a way](https://xenproject.org/developers/governance/#expressingopinion) > +to highlight one's position on proposals, formal or informal votes using the following > +notation: > +> +2 : I am happy with this proposal, and I will argue for it > +> +1 : I am happy with this proposal, but will not argue for it > +> 0 : I have no opinion > +> -1 : I am not happy with this proposal, but will not argue against it > +> -2 : I am not happy with this proposal, and I will argue against it > + > +You can use a phrase such as > +> I am not happy with this suggestion, but will not argue against it > + > +to make clear where you stand, while recording your position. Conversely, a reviewer > +may do something similar > +> I am not happy with XYZ, but will not argue against it [anymore] > +> What we have now is good enough, but could be better It is not just about the willingness of somebody to argue a point, which is the important thing when voting. During code reviews it is perfectly fine to make suggestions which are just optional for multiple reasons, including that they might be too taxing for the contributor. So, I think we should add that it would be best to use words that make it clear whether something is optional or whether it is required, see my reply to patch #6, I wrote an example there. > +### Authors: responding to review comments > +Typically patch authors are expected to **address all** review comments in the next > +version of a patch or patch series. In a smooth-running code review where you do not > +have further questions it is not at all necessary to acknowledge the changes you are > +going to make: > +* Simply send the next version with the changes addressed and record it in the > +change-log > + > +When there is discussion, the normal practice is to remove the portion of the e-mail > +thread where there is agreement. Otherwise, the thread can become exceptionally > +long. > + > +In cases where there was discussion and maybe disagreement, it does however make > +sense to close the discussion by saying something like > + > +> ACK > +> Seems we are agreed, I am going to do this > + > +Other situations when you may want to do this are cases where the reviewer made > +optional suggestions, to make clear whether the suggestion will be followed or > +not. > + > +### Avoid uncommon words: not everyone is a native English speaker > +Avoid uncommon words both when reviewing code or responding to a review. Not > +everyone is a native English speaker. The use of such words can come across badly and > +can lead to misunderstandings. > + > +### Prioritize significant flaws > +If a patch or patch series has significant flaws, such as > +* It is built on wrong assumptions > +* There are issues with the architecture or the design > + > +it does not make sense to do a detailed code review. In such cases, it is best to > +focus on the major issues first and deal with style and minor issues in a subsequent > +review. This reduces the workload on both the reviewer and patch author. However, > +reviewers should make clear that they have omitted detailed review comments and > +that these will come later. Maybe we want to expand on this a bit. Not all series are based on flawed assumptions, but all series have different class of changes that are required for acceptance, from major code modifications to minor code style fixes. I think we should say that it is good practice to ask for any major changes early on, during the first or second iteration of the series. It would be best to avoid asking for major changes at v9 if possible. Something else which is missing in this document, and it is purely for reviewers, is to be careful doing reviews late in the cycle when another maintainer/reviewer has already provided feedback on the series multiple times previously. For instance, if reviewer R1 has been doing reviews from the first version of the series and contributor C has been addressing all comments, it would be best if reviewer R2 didn't come in providing detailed feedback months later at v5, unless their requests are actually strictly necessary (i.e. they spotted a bug). The main reason is that it is difficult not to let your own personal style (code style, the way to lay out the code) sip through review comments, and it can cause double-effort for the author if he/she already made changes according R1's personal style. However, in general, it would be best to limit "personal style" requests for changes anyway, see my comment to patch #6. > +### Welcome newcomers > +When reviewing the first few patches of a newcomer to the project, you may want > +spend additional time and effort in your code review. This contributes to a more > +**positive experience**, which ultimately helps create a positive working relationship in > +the long term. > + > +When someone does their first code submission, they will not be familiar with **all** > +conventions in the project. A good approach is to > +* Welcome the newcomer > +* Offer to help with specific questions, for example on IRC > +* Point to existing documentation: in particular if mistakes with the submission > + itself were made. In most situations, following the submission process makes > + the process more seamless for the contributor. So, you could say something like > + > +> Hi XXX. Welcome to the community and thank you for the patch > +> > +> I noticed that the submission you made seems to not follow our process. > +> Are you aware of this document at YYY? If you follow the instructions the > +> entire code submission process and dealing with review comments becomes > +> much easier. Feel free to find me on IRC if you need specific help. My IRC > +> handle is ZZZ > + > +### Review the code, then review the review > +As stated earlier it is often difficult to mentally separate finding issues from articulating > +code review comments in a constructive and positive manner. Even as an experienced > +code reviewer you can be in a bad mood, which can impact your communication style. > + > +A good trick to avoid this, is to start and complete the code review and then **not > +send it immediately**. You can then have a final go over the code review at some later > +point in time and review your comments from the other author's point of view. This > +minimizes the risk of being misunderstood. The same applies when replying to a code > +review: draft your reply and give it a final scan before pressing the send button. > + > +Generally, it is a good idea for code reviewers to do this regularly, purely from the > +viewpoint of self-improvement and self-awareness. > + > +## Common Communication Pitfalls > + > +This section contains common communication issues and provides suggestions on > +how to avoid them and resolve them. These are **general** issues which affect **all** > +online communication. As such, we can only try and do our best. > + > +### Misunderstandings > +When you meet face to face, you can read a person’s emotions. Even with a phone call, > +someone’s tone of voice can convey a lot of information. Using on-line communication > +channels you are flying blind, which often leads to misunderstandings. > +[Research](https://www.wired.com/2006/02/the-secret-cause-of-flame-wars/) shows > +that in up to 50% of email conversations, the tone of voice is misinterpreted. > + > +In code reviews and technical discussions in general we tend to see two things > +* The reviewer or author interprets an exchange as too critical, passive aggressive, or > +other: this usually comes down to different cultures and communication styles, which > +are covered in the next section > +* There is an actual misunderstanding of a subject under discussion > + > +In the latter case, the key to resolution is to **identify the misunderstanding** as quickly > +as possible and call it out and de-escalate rather than let the misunderstanding linger. > +This is inherently difficult and requires more care than normal communication. Typically > +you would start with > +* Showing appreciation > +* Highlighting the potential misunderstanding and verifying whether the other person > + also feels that maybe there was a misunderstanding > +* Proposing a way forward: for example, it may make sense to move the conversation > + from the mailing list to [IRC](https://xenproject.org/help/irc/) either in private or public, > + a community call or a private phone/video call. > + > +It is entirely acceptable to do this in a direct reply to your communication partner, rather > +than on a public e-mail list on or an otherwise public forum. > + > +A good approach is to use something like the following: > +> Hi XXX! Thank you for the insights you have given me in this code review > +> I feel that we are misunderstanding each other on the topic of YYY > +> Would you mind trying to resolve this on IRC. I am available at ZZZ > + > +Usually, technical misunderstandings come down two either > +1. Misinterpreting what the other person meant > +2. Different - usually unstated - assumptions on how something works or what is to be > +achieved > +3. Different - usually unstated - objectives and goals, which may be conflicting > +4. Real differences in opinion > + > +The goal of calling out a possible misunderstanding is to establish what caused the > +misunderstanding, such that all parties can move forward. Typically, 1 and 2 are easily > +resolved and will lead back to a constructive discussion. Whereas 3 and 4 may highlight > +an inherent disagreement, which may need to be resolved through techniques as > +outlined in [Resolving Disagreement] (resolving-disagreement.md). > + > +### Cultural differences and different communication styles > +The Xen Project is a global community with contributors from many different > +backgrounds. Typically, when we communicate with a person we know, we factor > +in past interactions. The less we know a person, the more we rely on cultural norms. > + > +However, different norms and value systems come into play when people from diverse > +cultural backgrounds interact. That can lead to misunderstandings, especially in > +sensitive situations such as conflict resolution, giving and receiving feedback, and > +consensus building. > + > +For example, giving direct feedback such as > +> [Please] replace XXX with YYY, as XXX does not do ZZZ > + > +is acceptable and normal in some cultures, whereas in cultures which value indirect > +feedback it would be considered rude. In the latter case, something like the following > +would be used > +> This looks very good to me, but I believe you should use YYY here, > +> because XXX would.... > + > +The key to working and communicating well with people from different cultural > +backgrounds is **self-awareness**, which can then be used to either > +* Adapt your own communication style depending on who you talk to > +* Or to find a middle-ground that covers most bases > + > +A number of different theories in the field of working effectively are currently popular, > +with the most well-known one being > +[Erin Meyer's Culture Map](https://en.wikipedia.org/wiki/Erin_Meyer). A short overview > +can be found > +[here](https://www.nsf.gov/attachments/134059/public/15LFW_WorkingWithMulticulturalTeams_LarsonC.pdf) > +[33 slides]. > + > +### Code reviews and discussions are not competitions > +Code reviews on our mailing lists are not competitions on who can come up with the > +smartest solution or who is the real coding genius. > + > +In a code review - as well as in general - we expect that all stake-holders > +* Gracefully accept constructive criticism > +* Focus on what is best for the community > +* Resolve differences in opinion effectively > + > +The next section provides pointers on how to do this effectively. > + > +### Resolving Disagreement Effectively > +Common scenarios are covered our guide on > +[Resolving Disagreement](resolving-disagreement.md), which lays out situations that > +can lead to dead-lock and shows common patterns on how to avoid and resolve issues. > -- > 2.13.0 > --8323329-1207343631-1574899973=:27669 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Kd2luLXB2LWRl dmVsIG1haWxpbmcgbGlzdAp3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6 Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3dpbi1wdi1kZXZlbA== --8323329-1207343631-1574899973=:27669-- From win-pv-devel-bounces@lists.xenproject.org Thu Nov 28 01:06:28 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 28 Nov 2019 01:06:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ia8GK-0000z0-3E; Thu, 28 Nov 2019 01:06:28 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ia8GJ-0000yu-Ad for win-pv-devel@lists.xenproject.org; Thu, 28 Nov 2019 01:06:27 +0000 X-Inumbo-ID: 4a46a1f0-117b-11ea-83b8-bc764e2007e4 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4a46a1f0-117b-11ea-83b8-bc764e2007e4; Thu, 28 Nov 2019 01:06:21 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8BC9D2158A; Thu, 28 Nov 2019 01:06:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574903181; bh=uaB3mtFMO5egteCoStMhSeRFBaD0p+dPCJFxQm7xsGE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=nFrSC+BOE2ldK46qk2xNPRH047vhDei6yYfbIOkwE2CgbwAt5nojJsEQ+p/zMtLDG fN62uU27Ipg7A/KPK2id66MTLAwruAuFqfLfRR6qCP1nngi9BQCGf5wfcZ6AW1lKUw VWYrvKp/YqipTxIcRabjmQ3ql2mr49vp421trTbg= Date: Wed, 27 Nov 2019 17:06:19 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Jan Beulich In-Reply-To: Message-ID: References: <749f082bdb996ba7c7362847b22030882dc2903f.1569525222.git.lars.kurth@citrix.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Subject: Re: [win-pv-devel] [PATCH v2 5/6] Add guide on Communication Best Practice X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Lars Kurth , Lars Kurth , xen-api@lists.xenproject.org, minios-devel@lists.xenproject.org, committers@xenproject.org, mirageos-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, win-pv-devel@lists.xenproject.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" T24gRnJpLCAyNyBTZXAgMjAxOSwgSmFuIEJldWxpY2ggd3JvdGU6Cj4gT24gMjYuMDkuMjAxOSAy MTozOSwgTGFycyBLdXJ0aCB3cm90ZToKPiA+ICsjIyMgVmVyYm9zZSB2cy4gdGVyc2UKPiA+ICtE dWUgdG8gdGhlIHRpbWUgaXQgdGFrZXMgdG8gcmV2aWV3IGFuZCBjb21wb3NlIGNvZGUgcmV2aWV3 ZXIsIHJldmlld2VycyBvZnRlbiBhZG9wdCBhCj4gPiArdGVyc2Ugc3R5bGUuIEl0IGlzIG5vdCB1 bnVzdWFsIHRvIHNlZSByZXZpZXcgY29tbWVudHMgc3VjaCBhcwo+ID4gKz4gdHlwbwo+ID4gKz4g cy9yZXNpb25zL3JlZ2lvbnMvCj4gPiArPiBjb2Rpbmcgc3R5bGUKPiA+ICs+IGNvZGluZyBzdHls ZTogYnJhY2tldHMgbm90IG5lZWRlZAo+ID4gK2V0Yy4KPiA+ICsKPiA+ICtUZXJzZSBjb2RlIHJl dmlldyBzdHlsZSBoYXMgaXRzIHBsYWNlIGFuZCBjYW4gYmUgcHJvZHVjdGl2ZSBmb3IgYm90aCB0 aGUgcmV2aWV3ZXIgYW5kCj4gPiArdGhlIGF1dGhvci4gSG93ZXZlciwgb3ZlcnVzZSBjYW4gY29t ZSBhY3Jvc3MgYXMgdW5mcmllbmRseSwgbGFja2luZyBlbXBhdGh5IGFuZAo+ID4gK2NhbiB0aHVz IGNyZWF0ZSBhIG5lZ2F0aXZlIGltcHJlc3Npb24gd2l0aCB0aGUgYXV0aG9yIG9mIGEgcGF0Y2gu IFRoaXMgaXMgaW4gcGFydGljdWxhcgo+ID4gK3RydWUsIHdoZW4geW91IGRvIG5vdCBrbm93IHRo ZSBhdXRob3Igb3IgdGhlIGF1dGhvciBpcyBhIG5ld2NvbWVyLiBUZXJzZQo+ID4gK2NvbW11bmlj YXRpb24gc3R5bGVzIGNhbiBhbHNvIGJlIHBlcmNlaXZlZCBhcyBydWRlIGluIHNvbWUgY3VsdHVy ZXMuCj4gCj4gQW5kIGFub3RoZXIgcmVtYXJrIGhlcmU6IE5vdCBiZWluZyB0ZXJzZSBpbiBzaXR1 YXRpb25zIGxpa2UgdGhlIG9uZXMKPiBlbnVtZXJhdGVkIGFzIGV4YW1wbGVzIGFib3ZlIGlzIGEg ZG91YmxlIHdhc3RlIG9mIHRoZSByZXZpZXdlcidzIHRpbWU6Cj4gVGhleSBzaG91bGRuJ3QgZXZl biBuZWVkIHRvIG1ha2Ugc3VjaCBjb21tZW50cywgZXNwZWNpYWxseSBub3QgbWFueQo+IHRpbWVz IGZvciBhIHNpbmdsZSBwYXRjaCAoc2VlIHlvdXIgbWVudGlvbiBvZiAib3ZlcnVzZSIpLiBJIHJl YWxpemUKPiB3ZSBzdGlsbCBoYXZlIG5vIGF1dG9tYXRlZCBtZWNoYW5pc20gdG8gY2hlY2sgc3R5 bGUgYXNwZWN0cywgYnV0Cj4gYW55Ym9keSBjYW4gZWFzaWx5IGxvb2sgb3ZlciB0aGVpciBwYXRj aGVzIGJlZm9yZSBzdWJtaXR0aW5nIHRoZW0uCj4gQW5kIGZvciBhbiBvY2Nhc2lvbmFsIGlzc3Vl IEkgdGhpbmsgYSB0ZXJzZSByZXBseSBpcyBxdWl0ZSByZWFzb25hYmxlCj4gdG8gaGF2ZS4KPiAK PiBPdmVyYWxsIEknbSBzZWVpbmcgdGhlIGdvb2QgaW50ZW50aW9ucyBvZiB0aGlzIGRvY3VtZW50 LCB5ZXQgSSdkIHN0aWxsCj4gdm90ZSBhdCBsZWFzdCAtMSBvbiBpdCBpZiBpdCBjYW1lIHRvIGEg dm90ZS4gRm9sbG93aW5nIGV2ZW4ganVzdCBhCj4gZmFpciBwYXJ0IG9mIGl0IGlzIGEgY29uc2lk ZXJhYmxlIGV4dHJhIGFtb3VudCBvZiB0aW1lIHRvIGludmVzdCBpbgo+IHJldmlld3MsIHdoZW4g d2UgYWxyZWFkeSBoYXZlIGEgc2V2ZXJlIHJldmlld2luZyBib3R0bGVuZWNrLiBJZiBJIGhhdmUK PiB0byBqdWRnZSBiZXR3ZWVuIGRvaW5nIGEgYmFkIChzdHlsaXN0aWNhbGx5IGFjY29yZGluZyB0 byB0aGlzIGRvYywgbm90Cj4gdGVjaG5pY2FsbHkpIHJldmlldyBvciBub25lIGF0IGFsbCAoYmVj YXVzZSBvZiB0aW1lIGNvbnN0cmFpbnRzKSwgSSdkCj4gZmF2b3IgdGhlIGZvcm1lci4gVW5sZXNz IG9mIGNvdXJzZSBJJ20gYXNrZWQgdG8gc3RvcCBkb2luZyBzbywgaW4KPiB3aGljaCBjYXNlIEkn ZCBleHBlY3Qgd2hvZXZlciBhc2tzIHRvIGFycmFuZ2UgZm9yIHRoZSByZXZpZXdzIHRvIGJlCj4g ZG9uZSBieSBzb21lb25lIGVsc2UgaW4gZHVlIGNvdXJzZS4KClJlYWRpbmcgdGhlIGRvY3VtZW50 LCBJIHRoaW5rIEphbiBoYXMgYSBwb2ludCB0aGF0IGl0IGdpdmVzIHRoZQppbXByZXNzaW9uIHRo YXQgZm9sbG93aW5nIHRoZSBzdWdnZXN0aW9ucyB3b3VsZCB0YWtlIHNpZ25pZmljYW50CmVmZm9y dHMsIHdoaWxlIGFjdHVhbGx5IEkgZG9uJ3QgdGhpbmsgTGFycyBtZWFudCBpdCB0aGF0IHdheSBh dCBhbGwsIGFuZApJIGRvbid0IHRoaW5rIGl0IHNob3VsZCBiZSB0aGUgY2FzZSBlaXRoZXIuCgpN YXliZSB3ZSBzaG91bGQgaGlnaGxpZ2h0IGFuZCBlbmNvdXJhZ2UgImNsYXJpdHkiIGluc3RlYWQg b2YgInZlcmJvc2l0eSIKb2YgdGhlIGNvbW11bmljYXRpb24sIGFuZCBlbmNvdXJhZ2UgImV4cHJl c3NpbmcgYXBwcmVjaWF0aW9uIiB0bwpuZXdjb21lcnMsIG5vdCBuZWNlc3NhcmlseSB0byBzZWFz b25lZCBjb250cmlidXRvcnMuCgpUaGUgdWx0aW1hdGUgZ29hbCBvZiB0aGlzIGRvY3VtZW50IGlz IGFjdHVhbGx5IHRvICpyZWR1Y2UqIG91ciBvdmVyYWxsCmVmZm9ydHMgYnkgbWFraW5nIG91ciBj b21tdW5pY2F0aW9uIG1vcmUgZWZmaWNpZW50LCBub3QgdG8gaW5jcmVhc2UKZWZmb3J0cy4gTWF5 YmUgaXQgaXMgd29ydGggc2F5aW5nIHRoaXMgdG9vLgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18Kd2luLXB2LWRldmVsIG1haWxpbmcgbGlzdAp3aW4tcHYt ZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9t YWlsbWFuL2xpc3RpbmZvL3dpbi1wdi1kZXZlbA== From win-pv-devel-bounces@lists.xenproject.org Thu Nov 28 10:09:48 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 28 Nov 2019 10:09:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaGk7-0005Ab-Lp; Thu, 28 Nov 2019 10:09:47 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaGk6-0005AW-N9 for win-pv-devel@lists.xenproject.org; Thu, 28 Nov 2019 10:09:46 +0000 X-Inumbo-ID: 30855d46-11c7-11ea-a3cd-12813bfff9fa Received: from mx1.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 30855d46-11c7-11ea-a3cd-12813bfff9fa; Thu, 28 Nov 2019 10:09:40 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 135F5B486; Thu, 28 Nov 2019 10:09:39 +0000 (UTC) To: Stefano Stabellini , Lars Kurth References: <97e3adf75cf71ba39e702d4cab23236ada8d5a6c.1569525222.git.lars.kurth@citrix.com> From: Jan Beulich Message-ID: <909826df-25c1-6d7c-75d9-470365d2ecf6@suse.com> Date: Thu, 28 Nov 2019 11:09:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Subject: Re: [win-pv-devel] [Xen-devel] [PATCH v2 4/6] Add Code Review Guide X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Lars Kurth , xen-api@lists.xenproject.org, minios-devel@lists.xenproject.org, committers@xenproject.org, mirageos-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, win-pv-devel@lists.xenproject.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" T24gMjguMTEuMjAxOSAwMTo1NCwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOgo+IE9uIFRodSwg MjYgU2VwIDIwMTksIExhcnMgS3VydGggd3JvdGU6Cj4+IEZyb206IExhcnMgS3VydGggPGxhcnMu a3VydGhAY2l0cml4LmNvbT4KPj4KPj4gVGhpcyBkb2N1bWVudCBoaWdobGlnaHRzIHdoYXQgcmV2 aWV3ZXJzIHN1Y2ggYXMgbWFpbnRhaW5lcnMgYW5kIGNvbW1pdHRlcnMgbG9vawo+PiBmb3Igd2hl biByZXZpZXdpbmcgY29kZS4gSXQgc2V0cyBleHBlY3RhdGlvbnMgZm9yIGNvZGUgYXV0aG9ycyBh bmQgcHJvdmlkZXMKPj4gYSBmcmFtZXdvcmsgZm9yIGNvZGUgcmV2aWV3ZXJzLgo+IAo+IEkgdGhp bmsgdGhlIGRvY3VtZW50IGlzIG1pc3NpbmcgYSBjb3VwbGUgb2YgdGhpbmdzOgo+IAo+IC0gYSBz aW1wbGUgb25lIGxpbmUgc3RhdGVtZW50IHRoYXQgcG9zc2libHkgdGhlIG1vc3QgaW1wb3J0YW50 IHRoaW5nIGluCj4gICBhIGNvZGUgcmV2aWV3IGlzIHRvIGluZGVudGlmeSBhbnkgYnVncyBpbiB0 aGUgY29kZQo+IAo+IC0gYW4gZXhwbGFuYXRpb24gdGhhdCByZXF1ZXN0cyBmb3IgbWFqb3IgY2hh bmdlcyB0byB0aGUgc2VyaWVzIHNob3VsZCBiZQo+ICAgbWFkZSBlYXJseSBvbiAoaS5lLiBsZXQn cyBub3QgY2hhbmdlIHRoZSBhcmNoaXRlY3R1cmUgb2YgYSBmZWF0dXJlIGF0Cj4gICB2OSBpZiBw b3NzaWJsZSkgSSBhbHNvIG1hZGUgdGhpcyBjb21tZW50IGluIHJlcGx5IHRvIHBhdGNoICM1LiBJ J2xsCj4gICBsZXQgeW91IGRlY2lkZSB3aGVyZSBpcyB0aGUgYmVzdCBwbGFjZSBmb3IgaXQuCgpU aGlzIG5lZWRzIGJhbGFuY2luZy4gUGVvcGxlIGNydWNpYWwgdG8gdGhlIGV2YWx1YXRpb24gb2Yg YSBuZXcKZmVhdHVyZSBhbmQgaXRzIGltcGxlbWVudGF0aW9uIHNpbXBseSBtYXkgbm90IGhhdmUg dGhlIHRpbWUgdG8KcmVwbHkgcHJpb3IgdG8gdjkuIFdlJ3ZlIGhhZCBzaXR1YXRpb25zIHdoZXJl IHBlb3BsZSBwb3N0ZWQgbmV3CnJldmlzaW9ucyBldmVyeSBvdGhlciBkYXksIHNvbWV0aW1lcyBl dmVuIG1vcmUgdGhhbiBvbmUgcGVyIGRheS4KCkFzIGluZGljYXRlZCBpbiBzZXZlcmFsIG90aGVy IGNvbnRleHRzIGJlZm9yZSAtIGltbyBwZW9wbGUgbm90CmhlbHBpbmcgdG8gc2hvdWxkZXIgdGhl IHJldmlldyBsb2FkIHNob3VsZCBhbHNvIG5vdCBoYXZlIHRoZQpleHBlY3RhdGlvbiB0aGF0IHRo ZWlyIChsYXJnZSkgY29udHJpYnV0aW9ucyB3aWxsIGJlIGxvb2tlZCBhdAppbiBkdWUgY291cnNl LiAKCkphbgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K d2luLXB2LWRldmVsIG1haWxpbmcgbGlzdAp3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5v cmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3dpbi1wdi1k ZXZlbA== From win-pv-devel-bounces@lists.xenproject.org Thu Nov 28 10:18:43 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 28 Nov 2019 10:18:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaGsl-0006LU-JG; Thu, 28 Nov 2019 10:18:43 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaGsk-0006LM-BL for win-pv-devel@lists.xenproject.org; Thu, 28 Nov 2019 10:18:42 +0000 X-Inumbo-ID: 6ed1679c-11c8-11ea-a3cd-12813bfff9fa Received: from mx1.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6ed1679c-11c8-11ea-a3cd-12813bfff9fa; Thu, 28 Nov 2019 10:18:34 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 29564BAD0; Thu, 28 Nov 2019 10:18:33 +0000 (UTC) To: Stefano Stabellini , Lars Kurth References: <2e4b36afaa73277d246d7e84037db1532a136ec7.1569525222.git.lars.kurth@citrix.com> From: Jan Beulich Message-ID: <22b7f67c-c3dc-5450-999f-e79168175d39@suse.com> Date: Thu, 28 Nov 2019 11:18:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Subject: Re: [win-pv-devel] [Xen-devel] [PATCH v2 6/6] Added Resolving Disagreement X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Lars Kurth , xen-api@lists.xenproject.org, minios-devel@lists.xenproject.org, committers@xenproject.org, mirageos-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, win-pv-devel@lists.xenproject.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" T24gMjguMTEuMjAxOSAwMTo1NiwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOgo+IE9uIFRodSwg MjYgU2VwIDIwMTksIExhcnMgS3VydGggd3JvdGU6Cj4+ICtUaGlzIGNvdWxkIHRha2UgZm9yIGV4 YW1wbGUgdGhlIGZvcm0gb2YKPj4gKz4gRG8geW91IHRoaW5rIGl0IHdvdWxkIGJlIHVzZWZ1bCBm b3IgdGhlIGNvZGUgdG8gZG8gWFhYPyAKPj4gKz4gSSBjYW4gaW1hZ2luZSBhIHVzZXIgd2FudGlu ZyB0byBkbyBZWVkgKGFuZCBYWFggd291bGQgZW5hYmxlIHRoaXMpCj4+ICsKPj4gK1RoYXQgcG90 ZW50aWFsbHkgYWRkcyBhZGRpdGlvbmFsIHdvcmsgZm9yIHRoZSBjb2RlIGF1dGhvciwgd2hpY2gg dGhleSBtYXkgbm90IGhhdmUKPj4gK3RoZSB0aW1lIHRvIHBlcmZvcm0uIEl0IGlzIGdvb2QgcHJh Y3RpY2UgZm9yIGF1dGhvcnMgdG8gY29uc2lkZXIgc3VjaCBhIHJlcXVlc3QgaW4gdGVybXMgb2YK Pj4gKyogVXNlZnVsbmVzcyB0byB0aGUgdXNlcgo+PiArKiBDb2RlIGNodXJuLCBjb21wbGV4aXR5 IG9yIGltcGFjdCBvbiBvdGhlciBzeXN0ZW0gcHJvcGVydGllcwo+PiArKiBFeHRyYSB0aW1lIHRv IGltcGxlbWVudCBhbmQgcmVwb3J0IGJhY2sgdG8gdGhlIHJldmlld2VyCj4+ICsKPj4gK0lmIHlv dSBiZWxpZXZlIHRoYXQgdGhlIGltcGFjdC9jb3N0IGlzIHRvbyBoaWdoLCByZXBvcnQgYmFjayB0 byB0aGUgcmV2aWV3ZXIuIFRvIHJlc29sdmUKPj4gK3RoaXMsIGl0IGlzIGFkdmlzYWJsZSB0bwo+ PiArKiBSZXBvcnQgeW91ciBmaW5kaW5ncwo+PiArKiBBbmQgdGhlbiBjaGVjayB3aGV0aGVyIHRo aXMgd2FzIG1lcmVseSBhbiBpbnRlcmVzdGluZyBzdWdnZXN0aW9uLCBvciBzb21ldGhpbmcgdGhl Cj4+ICtyZXZpZXdlciBmZWVscyBtb3JlIHN0cm9uZ2x5IGFib3V0Cj4+ICsKPj4gK0luIHRoZSBs YXR0ZXIgY2FzZSwgdGhlcmUgYXJlIHR5cGljYWxseSBzZXZlcmFsIGNvbW1vbiBvdXRjb21lcwo+ PiArKiBUaGUgKiphdXRob3IgYW5kIHJldmlld2VyIGFncmVlKiogdGhhdCB0aGUgc3VnZ2VzdGlv biBzaG91bGQgYmUgaW1wbGVtZW50ZWQKPj4gKyogVGhlICoqYXV0aG9yIGFuZCByZXZpZXdlciBh Z3JlZSoqIHRoYXQgaXQgbWF5IG1ha2Ugc2Vuc2UgdG8gZGVmZXIgaW1wbGVtZW50YXRpb24KPj4g KyogVGhlICoqYXV0aG9yIGFuZCByZXZpZXdlciBhZ3JlZSoqIHRoYXQgaXQgbWFrZXMgbm8gc2Vu c2UgdG8gaW1wbGVtZW50IHRoZSBzdWdnZXN0aW9uCj4+ICsKPj4gK1RoZSBhdXRob3Igb2YgYSBw YXRjaCB3b3VsZCB0eXBpY2FsbHkgc3VnZ2VzdCB0aGVpciBwcmVmZXJyZWQgb3V0Y29tZSwgZm9y IGV4YW1wbGUKPj4gKz4gSSBhbSBub3Qgc3VyZSBpdCBpcyB3b3J0aCB0byBpbXBsZW1lbnQgWFhY Cj4+ICs+IERvIHlvdSB0aGluayB0aGlzIGNvdWxkIGJlIGRvbmUgYXMgYSBzZXBhcmF0ZSBwYXRj aCBpbiBmdXR1cmU/Cj4+ICsKPj4gK0luIGNhc2VzLCB3aGVyZSBubyBhZ3JlZW1lbnQgY2FuIGJl IGZvdW5kLCB0aGUgYmVzdCBhcHByb2FjaCB3b3VsZCBiZSB0byBnZXQgYW4KPj4gK2luZGVwZW5k ZW50IG9waW5pb24gZnJvbSBhbm90aGVyIG1haW50YWluZXIgb3IgdGhlIHByb2plY3QncyBsZWFk ZXJzaGlwIHRlYW0uCj4gCj4gSSB0aGluayB3ZSBzaG91bGQgbWVudGlvbiBzb21ld2hlcmUgaGVy ZSB0aGF0IGl0IGlzIHJlY29tbWVuZGVkIGZvcgo+IHJldmlld2VycyB0byBiZSBleHBsaWNpdCBh Ym91dCB3aGV0aGVyIGEgcmVxdWVzdCBpcyBvcHRpb25hbCBvciB3aGV0aGVyCj4gaXQgaXMgYSBy ZXF1aXJlbWVudC4KPiAKPiBGb3IgaW5zdGFuY2U6ICJJIHRoaW5rIGl0IHdvdWxkIGJlIGdvb2Qg aWYgWCBhbHNvIGRpZCBZIiBkb2Vzbid0IHNheSBpZgo+IGl0IGlzIG9wdGlvbmFsIChmdXR1cmUg d29yaykgb3IgaXQgaXMgYWN0dWFsbHkgcmVxdWlyZWQgYXMgcGFydCBvZiB0aGlzCj4gc2VyaWVz LiBNb3JlIGV4cGxpY2l0IHdvcmQgY2hvaWNlcyBhcmUgcHJlZmVyYWJsZSwgc3VjaCBhczoKPiAK PiAiSSB0aGluayBpdCB3b3VsZCBiZSBnb29kIGlmIFggYWxzbyBkaWQgWSwgbm90IGEgcmVxdWly ZW1lbnQgYnV0IGdvb2QgdG8KPiBoYXZlLiIKPiAKPiAiSSB0aGluayBpdCB3b3VsZCBiZSBnb29k IGlmIFggYWxzbyBkaWQgWSBhbmQgaXQgc2hvdWxkIGJlIHBhcnQgb2YgdGhpcwo+IHNlcmllcy4i CgpJIHRoaW5rIHdpdGhvdXQgaXQgYmVpbmcgbWFkZSBleHBsaWNpdCB0aGF0IHNvbWV0aGluZyBp cyBvcHRpb25hbCwKdGhlIGFzc3VtcHRpb24gc2hvdWxkIGJlIHRoYXQgaXQgaXNuJ3QuIEkuZS4g aW4gdGhlIGZpcnN0IGV4YW1wbGUKSSBhZ3JlZSB3aXRoIHRoZSBpZGVhIHRvIGhhdmUgc29tZXRo aW5nIGFmdGVyIHRoZSBjb21tYSwgYnV0IGluCnRoZSBzZWNvbmQgZXhhbXBsZSBJIHRoaW5rIHRo ZSBleHRyYSB3b3JkaW5nIGlzIGEgd2FzdGUgb2YgZWZmb3J0LgoKPiBJIHRoaW5rIHRoZXJlIGlz IHNvbWV0aGluZyBlbHNlIHdlIHNob3VsZCBzYXkgb24gdGhpcyB0b3BpYy4gVGhlcmUgaXMgYQo+ IGNhdGVnb3J5IG9mIHRoaW5ncyB3aGljaCBjb3VsZCBiZSBkb25lIGluIG11bHRpcGxlIHdheXMg YW5kIGl0IGlzIG5vdAo+IG92ZXJ0bHkgb2J2aW91cyB3aGljaCBvbmUgaXMgYmVzdC4gSXQgaXMg ZG9uZSB0byB0aGUgbWFpbnRhaW5lciBhbmQgdGhlCj4gYXV0aG9yIHBlcnNvbmFsIHN0eWxlcy4g SXQgaXMgZWFzeSB0byBkaXNhZ3JlZSBvbiB0aGF0Lgo+IAo+IEkgdGhpbmsgYSBnb29kIHJlY29t bWVuZGF0aW9uIHdvdWxkIGJlIGZvciB0aGUgY29udHJpYnV0b3IgdG8gdHJ5IHRvCj4gZm9sbG93 IHRoZSBtYWludGFpbmVycyByZXF1ZXN0cywgZXZlbiBpZiB0aGV5IGNvdWxkIGJlIGNvbnNpZGVy ZWQKPiAic3R5bGUiLCB0cnVzdGluZyB0aGVpciBleHBlcmllbmNlIG9uIHRoZSBtYXR0ZXIuIEFu ZCBhIGdvb2QKPiByZWNvbW1lbmRhdGlvbiBmb3IgdGhlIG1haW50YWluZXIgd291bGQgYmUgdG8g dHJ5IHRvIGxldCB0aGUgY29udHJpYnV0b3IKPiBoYXZlIGZyZWVkb20gb2YgaW1wbGVtZW50YXRp b24gY2hvaWNlIG9uIHRoaW5ncyB0aGF0IGRvbid0IG1ha2UgYQo+IHNpZ25pZmljYW50IGRpZmZl cmVuY2UuCgpJIHRoaW5rIHdlIHRyeSB0bywgYnV0IEkgYWxzbyB0aGluayB3ZSBzdWZmZXIgZnJv bSB0b28gbGl0dGxlCmNsZWFyIGRvY3VtZW50YXRpb24gb24gZS5nLiBzdHlsZSBhc3BlY3RzLiBB dHRlbXB0cyBvbiBteSBwYXJ0CnRvIGFkZHJlc3MgdGhpcyBoYXZlIG1vc3RseSAobm90IGVudGly ZWx5KSBsZWFkIG5vLXdoZXJlIChsYWNrIG9mCmZlZWRiYWNrIG9uIHByb3Bvc2VkIHBhdGNoZXMg dG8gLi9DT0RJTkdfU1RZTEUpLiBTbyBmb3IgdGhlIHRpbWUKYmVpbmcgdGhlcmUgYXJlIChtYW55 KSBhc3BlY3RzIHdoZXJlIHdlIGhhdmUgZGUtZmFjdG8gZXhwZWN0YXRpb25zCnRoYXQgYXJlbid0 IHdyaXR0ZW4gZG93biBhbnl3aGVyZSwgd2l0aCB0aGUgcmVzdWx0IG9mIChpbiBhIHN1YnNldApv ZiBjYXNlcykgZGlzYWdyZWVtZW50IG9uIHdoYXQgdGhlIHBlcmNlaXZlZCBkZS1mYWN0byBzdGFu ZGFyZAphY3R1YWxseSBpcy4KCkphbgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18Kd2luLXB2LWRldmVsIG1haWxpbmcgbGlzdAp3aW4tcHYtZGV2ZWxAbGlz dHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xp c3RpbmZvL3dpbi1wdi1kZXZlbA== From win-pv-devel-bounces@lists.xenproject.org Thu Nov 28 13:06:48 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 28 Nov 2019 13:06:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaJVO-00063z-US; Thu, 28 Nov 2019 13:06:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaJVN-00063t-S0 for win-pv-devel@lists.xenproject.org; Thu, 28 Nov 2019 13:06:45 +0000 X-Inumbo-ID: e9523f67-11df-11ea-a3d2-12813bfff9fa Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e9523f67-11df-11ea-a3d2-12813bfff9fa; Thu, 28 Nov 2019 13:06:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1574946399; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=SLRRkcq0NsgessIStO64x11cu8dqcIdXEeovuA1RDA0=; b=H6zqWgRpjAC76IDOR8mwrKKD4BasGRWgoEl311Can3weGb5o/n4s7tWn sEvQW7aPGk8TLcUDD4Rk2ljNSOHKph8KaG1peaCEswL0/cKLe+o4JavLy 7JoI+Ip5hjloTl8drlhZCdTrD1ZkNQJEGqxZa7Pq7rbNLXZ0t2iQfy9gy Y=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=lars.kurth@citrix.com; spf=Pass smtp.mailfrom=lars.kurth@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of lars.kurth@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="lars.kurth@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa3.hc3370-68.iphmx.com: domain of lars.kurth@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="lars.kurth@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: XP56NDIBQS8bELwL2rG9J+C46g6OsrvGTd1pnaUqd8AapGyMf0aoGJoLsFzDdu5CZfNTairVta mylRfJ6pH5ydKGbbUN7JkVRtBgpNh1kZFlNeA2GqjBk0yH/+y6stMCDMyFD2rsTunLRb8gAD09 cteGN5ePDf0n1wxklLl9Wd9I5j4XjoVqwWd6GFR0eH5peyTtz8XnIR9qMurdzMe6DaJItLDO6u 0Zz/Yl0gRWQV90Jdtg/wdFvTps3nsLtbVajEtigI1cYDNAE+Xv1sZ6dkogxC1Vcm+rNsxGkfh1 X4k= X-SBRS: 2.7 X-MesageID: 8946827 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.69,253,1571716800"; d="scan'208";a="8946827" From: Lars Kurth To: Jan Beulich , Stefano Stabellini , Lars Kurth Thread-Topic: [Xen-devel] [PATCH v2 4/6] Add Code Review Guide Thread-Index: AQHVdKIj+bIBaPEUGUyD9FYiIrE4J6egEqKAgACbQgD//8zPgA== Date: Thu, 28 Nov 2019 13:06:34 +0000 Message-ID: <2200B0A8-0EDE-4843-A5D3-A84F2D01333D@citrix.com> References: <97e3adf75cf71ba39e702d4cab23236ada8d5a6c.1569525222.git.lars.kurth@citrix.com> <909826df-25c1-6d7c-75d9-470365d2ecf6@suse.com> In-Reply-To: <909826df-25c1-6d7c-75d9-470365d2ecf6@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/10.10.10.191111 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted Content-ID: MIME-Version: 1.0 Subject: Re: [win-pv-devel] [Xen-devel] [PATCH v2 4/6] Add Code Review Guide X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-api@lists.xenproject.org" , "minios-devel@lists.xenproject.org" , "committers@xenproject.org" , "mirageos-devel@lists.xenproject.org" , "xen-devel@lists.xenproject.org" , "win-pv-devel@lists.xenproject.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" DQoNCu+7v09uIDI4LzExLzIwMTksIDA0OjA5LCAiSmFuIEJldWxpY2giIDxqYmV1bGljaEBzdXNl LmNvbT4gd3JvdGU6DQoNCiAgICBPbiAyOC4xMS4yMDE5IDAxOjU0LCBTdGVmYW5vIFN0YWJlbGxp bmkgd3JvdGU6DQogICAgPiBPbiBUaHUsIDI2IFNlcCAyMDE5LCBMYXJzIEt1cnRoIHdyb3RlOg0K ICAgID4+IEZyb206IExhcnMgS3VydGggPGxhcnMua3VydGhAY2l0cml4LmNvbT4NCiAgICA+Pg0K ICAgID4+IFRoaXMgZG9jdW1lbnQgaGlnaGxpZ2h0cyB3aGF0IHJldmlld2VycyBzdWNoIGFzIG1h aW50YWluZXJzIGFuZCBjb21taXR0ZXJzIGxvb2sNCiAgICA+PiBmb3Igd2hlbiByZXZpZXdpbmcg Y29kZS4gSXQgc2V0cyBleHBlY3RhdGlvbnMgZm9yIGNvZGUgYXV0aG9ycyBhbmQgcHJvdmlkZXMN CiAgICA+PiBhIGZyYW1ld29yayBmb3IgY29kZSByZXZpZXdlcnMuDQogICAgPiANCiAgICA+IEkg dGhpbmsgdGhlIGRvY3VtZW50IGlzIG1pc3NpbmcgYSBjb3VwbGUgb2YgdGhpbmdzOg0KICAgID4g DQogICAgPiAtIGEgc2ltcGxlIG9uZSBsaW5lIHN0YXRlbWVudCB0aGF0IHBvc3NpYmx5IHRoZSBt b3N0IGltcG9ydGFudCB0aGluZyBpbg0KICAgID4gICBhIGNvZGUgcmV2aWV3IGlzIHRvIGluZGVu dGlmeSBhbnkgYnVncyBpbiB0aGUgY29kZQ0KICAgID4gDQogICAgPiAtIGFuIGV4cGxhbmF0aW9u IHRoYXQgcmVxdWVzdHMgZm9yIG1ham9yIGNoYW5nZXMgdG8gdGhlIHNlcmllcyBzaG91bGQgYmUN CiAgICA+ICAgbWFkZSBlYXJseSBvbiAoaS5lLiBsZXQncyBub3QgY2hhbmdlIHRoZSBhcmNoaXRl Y3R1cmUgb2YgYSBmZWF0dXJlIGF0DQogICAgPiAgIHY5IGlmIHBvc3NpYmxlKSBJIGFsc28gbWFk ZSB0aGlzIGNvbW1lbnQgaW4gcmVwbHkgdG8gcGF0Y2ggIzUuIEknbGwNCiAgICA+ICAgbGV0IHlv dSBkZWNpZGUgd2hlcmUgaXMgdGhlIGJlc3QgcGxhY2UgZm9yIGl0Lg0KICAgIA0KICAgIFRoaXMg bmVlZHMgYmFsYW5jaW5nLiBQZW9wbGUgY3J1Y2lhbCB0byB0aGUgZXZhbHVhdGlvbiBvZiBhIG5l dw0KICAgIGZlYXR1cmUgYW5kIGl0cyBpbXBsZW1lbnRhdGlvbiBzaW1wbHkgbWF5IG5vdCBoYXZl IHRoZSB0aW1lIHRvDQogICAgcmVwbHkgcHJpb3IgdG8gdjkuIFdlJ3ZlIGhhZCBzaXR1YXRpb25z IHdoZXJlIHBlb3BsZSBwb3N0ZWQgbmV3DQogICAgcmV2aXNpb25zIGV2ZXJ5IG90aGVyIGRheSwg c29tZXRpbWVzIGV2ZW4gbW9yZSB0aGFuIG9uZSBwZXIgZGF5Lg0KDQpJIGNhbiBjZXJ0YWlubHkg YWRkIHNvbWV0aGluZyBvbiB0aGUgdGltaW5nICwgYWxvbmcgdGhlIGxpbmVzIG9mDQoqIEZvciBj b21wbGV4IHNlcmllcywgY29uc2lkZXIgdGhlIHRpbWUgaXQgdGFrZXMgdG8gZG8gcmV2aWV3cyAo bWF5YmUgd2l0aCBhIGd1aWRlIG9mIExPQyBwZXIgaG91cikgYW5kIGdpdmUgcmV2aWV3ZXJzIGVu b3VnaCB0aW1lIHRvDQoqIEZvciBzZXJpZXMgd2l0aCBkZXNpZ24gaXNzdWVzIG9yIGxhcmdlIHF1 ZXN0aW9ucywgdHJ5IGFuZCBoaWdobGlnaHQgdGhlIGtleSBvcGVuIGlzc3VlcyBpbiBjb3ZlciBs ZXR0ZXJzIGNsZWFybHkgYW5kIHNvbGljaXQgZmVlZGJhY2sgZnJvbSBrZXkgbWFpbnRhaW5lcnMg d2hvIGNhbiBjb21tZW50IG9uIHRoZSBvcGVuIGlzc3VlLiBUaGUgaWRlYSBpcyB0byBzYXZlIGJv dGggdGhlIGNvbnRyaWJ1dG9yIGFuZCB0aGUgcmV2aWV3ZXJzIHRpbWUgYnkgZm9jdXNzaW5nIG9u IHdoYXQgbmVlZHMgdG8gYmUgcmVzb2x2ZWQgDQoqIERvbuKAmXQgcmVwb3N0IGEgc2VyaWVzLCB1 bmxlc3MgYWxsIHJldmlldyBjb21tZW50cyBhcmUgYWRkcmVzc2VkIG9yIHRoZSByZXZpZXdlcnMg YXNrZWQgeW91IHRvIGRvIHNvLiBUaGUgcHJvYmxlbSB3aXRoIHRoaXMgaXMgdGhhdCB0aGlzIGlz IHNvbWV3aGF0IGluIGNvbmZsaWN0IHdpdGggdGhlICJsZXQncyBmb2N1cyBvbiB0aGUgY29yZSBp c3N1ZXMgYW5kIG5vdCBnZXQgZGlzdHJhY3RlZCBieSBkZXRhaWxzIGVhcmx5IG9uIGluIGEgcmV2 aWV3IGN5Y2xlIi4gSW4gb3RoZXIgd29yZHMsIHRoaXMgY2FuIG9ubHkgd29yaywgaWYgcmV2aWV3 ZXJzIGZvY3VzIG9uIG1ham9yIGlzc3VlcyBpbiBlYXJseSByZXZpZXdzIG9ubHkgYW5kIGRvIG5v dCBmb2N1cyBvbiBzdHlsZSwgY29kaW5nIHN0YW5kYXJkcywgZXRjLiBBcyBzb29uIGFzIGEgcmV2 aWV3ZXIgY29tZXMgYmFjayB3aXRoIGRldGFpbGVkIGZlZWRiYWNrLCB0aGUgY29udHJpYnV0b3Ig d2lsbCBmZWVsIG9ibGlnZWQgdG8gZml4IHRoZXNlLiBUaGlzIGNyZWF0ZXMgYSBtb3RpdmF0aW9u IHRvIHdhbnQgdG8gcGxlYXNlIHRoZSByZXZpZXdlciBzZW5kIG91dCBuZXcgdmVyc2lvbnMgb2Yg c2VyaWVzIGZpeGluZyBjb3NtZXRpYyBpc3N1ZXMgd2l0aG91dCBhZGRyZXNzaW5nIHRoZSBzdWJz dGFudGlhbCBpc3N1ZXMsIGxlYWRpbmcgdG8gd2hhdCBKYW4gZGVzY3JpYmVzLiBJIGFtIGxvb2tp bmcgZm9yIG9waW5pb25zIGhlcmUuICANCiAgICANCiAgICBBcyBpbmRpY2F0ZWQgaW4gc2V2ZXJh bCBvdGhlciBjb250ZXh0cyBiZWZvcmUgLSBpbW8gcGVvcGxlIG5vdA0KICAgIGhlbHBpbmcgdG8g c2hvdWxkZXIgdGhlIHJldmlldyBsb2FkIHNob3VsZCBhbHNvIG5vdCBoYXZlIHRoZQ0KICAgIGV4 cGVjdGF0aW9uIHRoYXQgdGhlaXIgKGxhcmdlKSBjb250cmlidXRpb25zIHdpbGwgYmUgbG9va2Vk IGF0DQogICAgaW4gZHVlIGNvdXJzZS4gDQogICAgDQpJIGNhbiBhZGQgc29tZXRoaW5nIHRvIHRo aXMgZWZmZWN0LiAgDQoNCkxhcnMNCiAgICANCg0KX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18Kd2luLXB2LWRldmVsIG1haWxpbmcgbGlzdAp3aW4tcHYtZGV2 ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWls bWFuL2xpc3RpbmZvL3dpbi1wdi1kZXZlbA== From win-pv-devel-bounces@lists.xenproject.org Thu Nov 28 13:37:47 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 28 Nov 2019 13:37:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaJzP-0000PK-6Z; Thu, 28 Nov 2019 13:37:47 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaJzO-0000PF-Dl for win-pv-devel@lists.xenproject.org; Thu, 28 Nov 2019 13:37:46 +0000 X-Inumbo-ID: 413864fe-11e4-11ea-a3d2-12813bfff9fa Received: from mx1.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 413864fe-11e4-11ea-a3d2-12813bfff9fa; Thu, 28 Nov 2019 13:37:43 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id EFB12B169; Thu, 28 Nov 2019 13:37:42 +0000 (UTC) To: Lars Kurth References: <97e3adf75cf71ba39e702d4cab23236ada8d5a6c.1569525222.git.lars.kurth@citrix.com> <909826df-25c1-6d7c-75d9-470365d2ecf6@suse.com> <2200B0A8-0EDE-4843-A5D3-A84F2D01333D@citrix.com> From: Jan Beulich Message-ID: Date: Thu, 28 Nov 2019 14:37:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <2200B0A8-0EDE-4843-A5D3-A84F2D01333D@citrix.com> Content-Language: en-US Subject: Re: [win-pv-devel] [PATCH v2 4/6] Add Code Review Guide X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Lars Kurth , Stefano Stabellini , "xen-api@lists.xenproject.org" , "minios-devel@lists.xenproject.org" , "committers@xenproject.org" , "mirageos-devel@lists.xenproject.org" , "xen-devel@lists.xenproject.org" , "win-pv-devel@lists.xenproject.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" T24gMjguMTEuMjAxOSAxNDowNiwgTGFycyBLdXJ0aCB3cm90ZToKPiBJIGNhbiBjZXJ0YWlubHkg YWRkIHNvbWV0aGluZyBvbiB0aGUgdGltaW5nICwgYWxvbmcgdGhlIGxpbmVzIG9mCj4gKiBGb3Ig Y29tcGxleCBzZXJpZXMsIGNvbnNpZGVyIHRoZSB0aW1lIGl0IHRha2VzIHRvIGRvIHJldmlld3Mg KG1heWJlIHdpdGggYSBndWlkZSBvZiBMT0MgcGVyIGhvdXIpIGFuZCBnaXZlIHJldmlld2VycyBl bm91Z2ggdGltZSB0bwo+ICogRm9yIHNlcmllcyB3aXRoIGRlc2lnbiBpc3N1ZXMgb3IgbGFyZ2Ug cXVlc3Rpb25zLCB0cnkgYW5kIGhpZ2hsaWdodCB0aGUga2V5IG9wZW4gaXNzdWVzIGluIGNvdmVy IGxldHRlcnMgY2xlYXJseSBhbmQgc29saWNpdCBmZWVkYmFjayBmcm9tIGtleSBtYWludGFpbmVy cyB3aG8gY2FuIGNvbW1lbnQgb24gdGhlIG9wZW4gaXNzdWUuIFRoZSBpZGVhIGlzIHRvIHNhdmUg Ym90aCB0aGUgY29udHJpYnV0b3IgYW5kIHRoZSByZXZpZXdlcnMgdGltZSBieSBmb2N1c3Npbmcg b24gd2hhdCBuZWVkcyB0byBiZSByZXNvbHZlZCAKPiAqIERvbuKAmXQgcmVwb3N0IGEgc2VyaWVz LCB1bmxlc3MgYWxsIHJldmlldyBjb21tZW50cyBhcmUgYWRkcmVzc2VkCj4gb3IgdGhlIHJldmll d2VycyBhc2tlZCB5b3UgdG8gZG8gc28uIFRoZSBwcm9ibGVtIHdpdGggdGhpcyBpcyB0aGF0Cj4g dGhpcyBpcyBzb21ld2hhdCBpbiBjb25mbGljdCB3aXRoIHRoZSAibGV0J3MgZm9jdXMgb24gdGhl IGNvcmUKPiBpc3N1ZXMgYW5kIG5vdCBnZXQgZGlzdHJhY3RlZCBieSBkZXRhaWxzIGVhcmx5IG9u IGluIGEgcmV2aWV3IGN5Y2xlIi4KPiBJbiBvdGhlciB3b3JkcywgdGhpcyBjYW4gb25seSB3b3Jr LCBpZiByZXZpZXdlcnMgZm9jdXMgb24gbWFqb3IKPiBpc3N1ZXMgaW4gZWFybHkgcmV2aWV3cyBv bmx5IGFuZCBkbyBub3QgZm9jdXMgb24gc3R5bGUsIGNvZGluZwo+IHN0YW5kYXJkcywgZXRjLgoK QnV0IHRoaXMgZG9lc24ndCBtYWtlIG11Y2ggc2Vuc2UgZWl0aGVyLCBiZWNhdXNlIHRoZW4gZnVs bCByZS1yZXZpZXdzCm5lZWQgdG8gaGFwcGVuIGFueXdheSBvbiBsYXRlciB2ZXJzaW9ucywgdG8g YWxzbyBkZWFsIHdpdGggdGhlIG1pbm9yCmlzc3Vlcy4gRm9yIFJGQyBraW5kIG9mIHNlcmllcyBv bWl0dGluZyBzdHlsZSBhbmQgYWxpa2UgZmVlZGJhY2sKY2VydGFpbmx5IG1ha2VzIHNlbnNlLCBi dXQgYXMgc29vbiBhcyBhIHBhdGNoIGlzIG5vbi1SRkMsIGl0IHNob3VsZApiZSBjb25zaWRlcmVk IGdvb2QgdG8gZ28gaW4gYnkgdGhlIHN1Ym1pdHRlci4KCkphbgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18Kd2luLXB2LWRldmVsIG1haWxpbmcgbGlzdAp3 aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0 Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3dpbi1wdi1kZXZlbA== From win-pv-devel-bounces@lists.xenproject.org Thu Nov 28 14:02:53 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 28 Nov 2019 14:02:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaKNh-00041s-8Q; Thu, 28 Nov 2019 14:02:53 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaKNg-00041f-GP for win-pv-devel@lists.xenproject.org; Thu, 28 Nov 2019 14:02:52 +0000 X-Inumbo-ID: bb02dbd6-11e7-11ea-83b8-bc764e2007e4 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id bb02dbd6-11e7-11ea-83b8-bc764e2007e4; Thu, 28 Nov 2019 14:02:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1574949757; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=XmruZdKk8gM9fXXLnaWLAOgbE4mFRUQcYA/5rc5I3l8=; b=AlUolTDjVrna3AAxofwm7CoSZ715063RY0R6WK6dw2q2u+VYeELjMFAj UYcGmPFPscGKutFSm8pVfmZjDzHzTQPT86mrW6XMRxijyqHJg6HF8UAVl uiWdYQ1cyrar5avFV1MmQwOGPlwvMe3VeZOXIbmh1Jd3QlbTrwmYRF2Ef Q=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=lars.kurth@citrix.com; spf=Pass smtp.mailfrom=lars.kurth@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of lars.kurth@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="lars.kurth@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of lars.kurth@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="lars.kurth@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: kSLlZg7z4c7bm2KMbkJX5ouLzvxkDgxSG2LP4O0cTgsoJeC9yGoQtQI3lqY9Bs0n8Ia+z3oLz2 23IMx14+03qBaL3zt7FBiLU0Aq02CEgBiqnPh0YNqcy/9JLzFX7zWJyuzglHWuOvgtK9teVF0f P9Io+brr8xmnU9Iai44yedWvf1WKH+aP7u0MeN66dw12ym125eIFMoW/cG9EVc4+Mlg2S9lXxn PfI7NhfpzQEF5C/t2Jxrjdl58QlRx0IEAL4if2ywpKS+F1n4qqJbWntOducX1swWsyh6KxgdVN p38= X-SBRS: 2.7 X-MesageID: 8959416 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.69,253,1571716800"; d="scan'208";a="8959416" From: Lars Kurth To: Jan Beulich , Lars Kurth Thread-Topic: [PATCH v2 4/6] Add Code Review Guide Thread-Index: AQHVpfEGwl/VxYnE9Uydtksy7w4pxaegJ7iA Date: Thu, 28 Nov 2019 14:02:32 +0000 Message-ID: References: <97e3adf75cf71ba39e702d4cab23236ada8d5a6c.1569525222.git.lars.kurth@citrix.com> <909826df-25c1-6d7c-75d9-470365d2ecf6@suse.com> <2200B0A8-0EDE-4843-A5D3-A84F2D01333D@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/10.10.10.191111 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted Content-ID: MIME-Version: 1.0 Subject: Re: [win-pv-devel] [PATCH v2 4/6] Add Code Review Guide X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , "xen-api@lists.xenproject.org" , "minios-devel@lists.xenproject.org" , "committers@xenproject.org" , "mirageos-devel@lists.xenproject.org" , "xen-devel@lists.xenproject.org" , "win-pv-devel@lists.xenproject.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" DQoNCu+7v09uIDI4LzExLzIwMTksIDA3OjM3LCAiSmFuIEJldWxpY2giIDxqYmV1bGljaEBzdXNl LmNvbT4gd3JvdGU6DQoNCiAgICBPbiAyOC4xMS4yMDE5IDE0OjA2LCBMYXJzIEt1cnRoIHdyb3Rl Og0KICAgID4gSSBjYW4gY2VydGFpbmx5IGFkZCBzb21ldGhpbmcgb24gdGhlIHRpbWluZyAsIGFs b25nIHRoZSBsaW5lcyBvZg0KICAgID4gKiBGb3IgY29tcGxleCBzZXJpZXMsIGNvbnNpZGVyIHRo ZSB0aW1lIGl0IHRha2VzIHRvIGRvIHJldmlld3MgKG1heWJlIHdpdGggYSBndWlkZSBvZiBMT0Mg cGVyIGhvdXIpIGFuZCBnaXZlIHJldmlld2VycyBlbm91Z2ggdGltZSB0bw0KICAgID4gKiBGb3Ig c2VyaWVzIHdpdGggZGVzaWduIGlzc3VlcyBvciBsYXJnZSBxdWVzdGlvbnMsIHRyeSBhbmQgaGln aGxpZ2h0IHRoZSBrZXkgb3BlbiBpc3N1ZXMgaW4gY292ZXIgbGV0dGVycyBjbGVhcmx5IGFuZCBz b2xpY2l0IGZlZWRiYWNrIGZyb20ga2V5IG1haW50YWluZXJzIHdobyBjYW4gY29tbWVudCBvbiB0 aGUgb3BlbiBpc3N1ZS4gVGhlIGlkZWEgaXMgdG8gc2F2ZSBib3RoIHRoZSBjb250cmlidXRvciBh bmQgdGhlIHJldmlld2VycyB0aW1lIGJ5IGZvY3Vzc2luZyBvbiB3aGF0IG5lZWRzIHRvIGJlIHJl c29sdmVkIA0KICAgID4gKiBEb27igJl0IHJlcG9zdCBhIHNlcmllcywgdW5sZXNzIGFsbCByZXZp ZXcgY29tbWVudHMgYXJlIGFkZHJlc3NlZA0KICAgID4gb3IgdGhlIHJldmlld2VycyBhc2tlZCB5 b3UgdG8gZG8gc28uIFRoZSBwcm9ibGVtIHdpdGggdGhpcyBpcyB0aGF0DQogICAgPiB0aGlzIGlz IHNvbWV3aGF0IGluIGNvbmZsaWN0IHdpdGggdGhlICJsZXQncyBmb2N1cyBvbiB0aGUgY29yZQ0K ICAgID4gaXNzdWVzIGFuZCBub3QgZ2V0IGRpc3RyYWN0ZWQgYnkgZGV0YWlscyBlYXJseSBvbiBp biBhIHJldmlldyBjeWNsZSIuDQogICAgPiBJbiBvdGhlciB3b3JkcywgdGhpcyBjYW4gb25seSB3 b3JrLCBpZiByZXZpZXdlcnMgZm9jdXMgb24gbWFqb3INCiAgICA+IGlzc3VlcyBpbiBlYXJseSBy ZXZpZXdzIG9ubHkgYW5kIGRvIG5vdCBmb2N1cyBvbiBzdHlsZSwgY29kaW5nDQogICAgPiBzdGFu ZGFyZHMsIGV0Yy4NCiAgICANCiAgICBCdXQgdGhpcyBkb2Vzbid0IG1ha2UgbXVjaCBzZW5zZSBl aXRoZXIsIGJlY2F1c2UgdGhlbiBmdWxsIHJlLXJldmlld3MNCiAgICBuZWVkIHRvIGhhcHBlbiBh bnl3YXkgb24gbGF0ZXIgdmVyc2lvbnMsIHRvIGFsc28gZGVhbCB3aXRoIHRoZSBtaW5vcg0KICAg IGlzc3Vlcy4gRm9yIFJGQyBraW5kIG9mIHNlcmllcyBvbWl0dGluZyBzdHlsZSBhbmQgYWxpa2Ug ZmVlZGJhY2sNCiAgICBjZXJ0YWlubHkgbWFrZXMgc2Vuc2UsIGJ1dCBhcyBzb29uIGFzIGEgcGF0 Y2ggaXMgbm9uLVJGQywgaXQgc2hvdWxkDQogICAgYmUgY29uc2lkZXJlZCBnb29kIHRvIGdvIGlu IGJ5IHRoZSBzdWJtaXR0ZXIuDQogICAgDQpPSywgSSB0aGluayB3ZSBoYXZlIGEgZGlzY29ubmVj dCBiZXR3ZWVuIGlkZWFsIGFuZCByZWFsaXR5LiANCg0KSSBzZWUgdHdvIGlzc3VlcyB0b2RheQ0K KiBLZXkgbWFpbnRhaW5lcnMgZG9uJ3QgYWx3YXlzIHJldmlldyBSRkMgc2VyaWVzIFt0aGV5IGVu ZCB1cCBhdCB0aGUgYm90dG9tIG9mIHRoZSBwcmlvcml0eSBsaXN0LCBldmVuIHRob3VnaCBzcGVu ZGluZyB0aW1lIG9uIFJGQ3Mgd2lsbCBzYXZlIHRpbWUgZWxzZXdoZXJlIGxhdGVyXS4gU28gdGhl IGVmZmVjdCBpcyB0aGF0IHRoZW4gdGhlIGNvbnRyaWJ1dG9yIGFzc3VtZXMgdGhlcmUgYXJlIG5v IG1ham9yIGlzc3VlcyBhbmQgZW5kcyBpdCBhcyBhIHByb3BlciBzZXJpZXMNCiogSW4gcHJhY3Rp Y2Ugd2hhdCBoYXMgaGFwcGVuZWQgb2Z0ZW4gaW4gdGhlIHBhc3QgaXMgdGhhdCBkZXNpZ24sIGFy Y2hpdGVjdHVyZSwgYXNzdW1wdGlvbiBmbGF3cyBhcmUgZm91bmQgaW4gZWFybHkgdmVyc2lvbnMg b2YgYSBzZXJpZXMuDQogICAtIFRoaXMgdXN1YWxseSBoYXBwZW5zIGJlY2F1c2Ugb2YgYW4gb3Zl cnNpZ2h0IG9yIGJlY2F1c2UgdGhlcmUgd2FzIG5vIGRlc2lnbiBkaXNjdXNzaW9uIHByaW9yIHRv IHRoZSBzZXJpZXMgYmVpbmcgcG9zdGVkIGFuZCBhZ3JlZWQNCiAgIC0gQ29tbW9uIHNlbnNlIHdv dWxkIGRpY3RhdGUgdGhhdCB0aGUgYmlnZ2VzdCBiZW5lZml0IGZvciBib3RoIHRoZSByZXZpZXdl ciwgdGhlIGNvbnRyaWJ1dG9yIGFuZCB0aGUgY29tbXVuaXR5IGFzIGEgd2hvbGUgd291bGQgYmUg dG8gdHJ5IGFuZCBmb2N1cyBvbiBzdWNoIGZsYXdzIGFuZCBsZWF2ZSBldmVyeXRoaW5nIGFzaWRl DQogICAtIE9mIGNvdXJzZSB0aGVyZSBtYXkgYmUgdmFsdWUgaW4gZG9pbmcgYSBkZXRhaWxlZCBy ZXZpZXdzIG9mIHN1Y2ggYSBzZXJpZXMgYXMgdGhlcmUgbWF5IGJlIGJpdHMgdGhhdCBhcmUgdW5h ZmZlY3RlZCBieSBzdWNoIGEgZmxhdw0KICAgLSBCdXQgdGhlcmUgd2lsbCBsaWtlbHkgYmUgcGFy dHMgd2hpY2ggYXJlIG5vdDogZG9pbmcgYSBkZXRhaWxlZCByZXZpZXcgb2Ygc3VjaCBwb3J0aW9u cyB3YXN0ZXMgZXZlcnlvbmUncyB0aW1lDQoNClNvIGNvbWluZyBiYWNrIHRvIHlvdXIgcG9pbnQu IElkZWFsbHksIGl0IHdvdWxkIGJlIG5pY2UgaWYgd2UgaGFkIHRoZSBjYXBhYmlsaXR5IHRvIGNh bGwgb3V0IHBhcnRzIG9mIGEgc2VyaWVzIGFzICJwcm9ibGVtYXRpYyIgYW5kIHRyZWF0aW5nIHN1 Y2ggcGFydHMgZGlmZmVyZW50bHkNCg0KTGFycw0KDQpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwp3aW4tcHYtZGV2ZWwgbWFpbGluZyBsaXN0Cndpbi1wdi1k ZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21h aWxtYW4vbGlzdGluZm8vd2luLXB2LWRldmVs From win-pv-devel-bounces@lists.xenproject.org Thu Nov 28 16:12:15 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 28 Nov 2019 16:12:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaMOr-0000Lp-Gn; Thu, 28 Nov 2019 16:12:13 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaMOq-0000Lk-8v for win-pv-devel@lists.xenproject.org; Thu, 28 Nov 2019 16:12:12 +0000 X-Inumbo-ID: d5a55b78-11f9-11ea-83b8-bc764e2007e4 Received: from smtp-fw-2101.amazon.com (unknown [72.21.196.25]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d5a55b78-11f9-11ea-83b8-bc764e2007e4; Thu, 28 Nov 2019 16:12:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1574957532; x=1606493532; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=GRAc+aet5rsKCDZSlE3j9ogJr+8iLYNp4QomajcmfFc=; b=cdtfuBEXmyjYsasmLlbIlaBdl/ECt0Ru1DkG+oHK73uk1tDcH1xhhWOL gd/pZWxISrHxbR1iKFWY+rdgO/RMAmSXyi4rhyosssSnIHx9lQGpMoTfq 8nb65T/DmfBeSBeyrzEURkNq0lkm1AS9yyYyiLp5RNb6N5oHMXPGwHLr1 4=; IronPort-SDR: 8iccOMRtV0pxy+0xbNmTa2fZrrvNKPIq4ZOuI3QWBo2DqqYYcJAkqdYG5EK9KaTx9bkqYJg0WJ v/m+ec7AHYYg== X-IronPort-AV: E=Sophos;i="5.69,253,1571702400"; d="scan'208";a="6252692" Received: from iad6-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-1e-c7c08562.us-east-1.amazon.com) ([10.124.125.2]) by smtp-border-fw-out-2101.iad2.amazon.com with ESMTP; 28 Nov 2019 16:12:11 +0000 Received: from EX13MTAUEA001.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan2.iad.amazon.com [10.40.159.162]) by email-inbound-relay-1e-c7c08562.us-east-1.amazon.com (Postfix) with ESMTPS id 494EB2465EC; Thu, 28 Nov 2019 16:12:09 +0000 (UTC) Received: from EX13D32EUC003.ant.amazon.com (10.43.164.24) by EX13MTAUEA001.ant.amazon.com (10.43.61.243) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 28 Nov 2019 16:12:05 +0000 Received: from EX13D32EUC003.ant.amazon.com (10.43.164.24) by EX13D32EUC003.ant.amazon.com (10.43.164.24) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 28 Nov 2019 16:12:04 +0000 Received: from EX13D32EUC003.ant.amazon.com ([10.43.164.24]) by EX13D32EUC003.ant.amazon.com ([10.43.164.24]) with mapi id 15.00.1367.000; Thu, 28 Nov 2019 16:12:04 +0000 From: "Durrant, Paul" To: "win-pv-devel@lists.xenproject.org" Thread-Topic: 9.0.0-rc1 tagged Thread-Index: AdWmBb2SQ53hdrsxTXuplLt7/UBcBg== Date: Thu, 28 Nov 2019 16:12:04 +0000 Message-ID: <2f8ae61325144ea6b151b883a6dda00c@EX13D32EUC003.ant.amazon.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.165.244] MIME-Version: 1.0 Subject: [win-pv-devel] 9.0.0-rc1 tagged X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "owen.smith@citrix.com" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" SGksCgogIEkgaGF2ZSBjcmVhdGVkIGEgc3RhZ2luZy05LjAgYnJhbmNoIGluIGFsbCB0aGUgZHJp dmVyIHJlcG9zIGFuZCB0YWdnZWQgdGhpcyBhcyA5LjAuMC1yYzEuIEkgcGxhbiB0byBtb3ZlIHRo ZSBkZWZhdWx0IE1JTk9SX1ZFUlNJT04gb24gbWFzdGVyIGZyb20gMCB0byAxIHNob3J0bHkuCiAg UGxlYXNlIHRlc3QgdGhlIHRhZ2dlZCB2ZXJzaW9ucyAoYmluYXJpZXMgYXZhaWxhYmxlIGF0IGh0 dHA6Ly94ZW5iaXRzLnhlbnByb2plY3Qub3JnL3B2ZHJpdmVycy93aW4vOS4wLjApLiBJIGhhdmVu J3QgZm91bmQgYW55IHByb2JsZW1zIGluIHRlc3RpbmcgYW5kIEkgYmVsaWV2ZSB0aGV5IGFyZSBh bGwgZml0IGZvciBsb2dvIHRlc3RpbmcgKE93ZW4gcGxlYXNlIGNvcnJlY3QgbWUgaWYgSSdtIHdy b25nKS4gSWYgbm8gcHJvYmxlbXMgYXJlIGJyb3VnaHQgdG8gbXkgYXR0ZW50aW9uIGluIHRoZSBu ZXh0IHdlZWsgdGhlbiBJIGludGVuZCB0byBzaWduIGFuZCByZWxlYXNlIHZlcnNpb24gOS4wLjAg c2hvcnRseSB0aGVyZWFmdGVyLgoKICBDaGVlcnMsCgogICAgUGF1bAoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Kd2luLXB2LWRldmVsIG1haWxpbmcgbGlz dAp3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9q ZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3dpbi1wdi1kZXZlbA== From win-pv-devel-bounces@lists.xenproject.org Thu Nov 28 16:38:12 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 28 Nov 2019 16:38:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaMnz-000279-Pl; Thu, 28 Nov 2019 16:38:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaMny-000273-Qy for win-pv-devel@lists.xenproject.org; Thu, 28 Nov 2019 16:38:10 +0000 X-Inumbo-ID: 766e8d6a-11fd-11ea-a55d-bc764e2007e4 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 766e8d6a-11fd-11ea-a55d-bc764e2007e4; Thu, 28 Nov 2019 16:38:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1574959091; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=5Rn+t8B7r4f1mzOP2RdoZ68v1r3IEyDuWN2DD4sb7Kk=; b=fF98hYcMJQupHPMtSo4tBmlpkGQziGtji+TdPhx+0cez5Bn1jOFCVY83 IHmhCypVpewwzKrDlxldnebr/Wsn+yQu+/JDRGoNumCUUH6ARwXGrjMBI qyvm8ksGQptDVsC4/+ZbykFNfmbkowfYH5UDT3nSvBDH7uRfhwg03KC2U M=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=owen.smith@citrix.com; spf=Pass smtp.mailfrom=owen.smith@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of owen.smith@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="owen.smith@citrix.com"; x-sender="owen.smith@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa3.hc3370-68.iphmx.com: domain of owen.smith@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="owen.smith@citrix.com"; x-sender="owen.smith@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="owen.smith@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: m2YjLUi5JNl3M6DqlPB0lMEfWZNn7nO8wJ5+/kEYPuV/FUDpkUVEowY5AKW3XS6bUrHlw8yOTs US1B25fnNTONzGMx2IOoX4833Hut+50N0Ort+E5BwtzZI5YGunjuu2B/FESAreUohPi3lWk5FK FkFQ4DtAAJHEY7OL7wSLSC+UPJv7PNqyWFxEO5be5/QgQ9PK3HIdGs9kQIb1Ul+RJxkjSjeC6N GxdGh+01vW8LXNZzkockWuqcS7yAmsgv/hMckUdTKSmk8VAHSWT39Lgv8sDsbNRBHYAP0jtbU9 OXE= X-SBRS: 2.7 X-MesageID: 8953820 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.69,253,1571716800"; d="scan'208";a="8953820" From: Owen Smith To: "Durrant, Paul" , "win-pv-devel@lists.xenproject.org" Thread-Topic: 9.0.0-rc1 tagged Thread-Index: AdWmBb2SQ53hdrsxTXuplLt7/UBcBgAAosdQ Date: Thu, 28 Nov 2019 16:38:07 +0000 Message-ID: <07e909c72cdb4d508ba85be1ca578261@AMSPEX02CL02.citrite.net> References: <2f8ae61325144ea6b151b883a6dda00c@EX13D32EUC003.ant.amazon.com> In-Reply-To: <2f8ae61325144ea6b151b883a6dda00c@EX13D32EUC003.ant.amazon.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted MIME-Version: 1.0 Subject: Re: [win-pv-devel] 9.0.0-rc1 tagged X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" SSd2ZSB0ZXN0ZWQgdGhlIGZvbGxvd2luZyBjb21taXRzIHdpdGggcGF0Y2hlcyBmb3IgQ2l0cml4 IHVzZSBjYXNlcyAod2hpY2ggc2hvdWxkIG5vdCBjaGFuZ2UgdGVzdCByZXN1bHRzIHNpZ25pZmlj YW50bHkpCgpYZW5idXMgLSA4Mjk0NjAwNDBjMTYxODQ2YWQxZmY0ZTdkMDRlZDhmZjhkOTkwZWI0 ClhlbmNvbnMgLSA5ZWQ4OWE1ZmU1N2UwYmIwYWNjOGZiMGEyMDJhN2RkZTM4ZDI4YzM5IChwYXRj aHEgYnJpbmdzIHBhdGNoIGxldmVsIGluIGxpbmUgd2l0aCAwM2IzNTBhZWZhMTI1MzU0ODMwZmEw YjY2ZWQyYzFjZmJmYmFmZGY5KQpYZW5pZmFjZSAtIGUzZTNkZDU2ZGVmNGVkZmI0NTkwN2M2M2Fj NjA2YzFkM2Y4MDRiNWIKWGVubmV0IC0gZGQzNGFkZGFlYzQyODgwZjdlYmEyZjI2NzY5NDMzMDNi NTZkNTU3ZgpYZW52YmQgLSAzMTEyZTQ3MjE4YmJlMjQzY2FmZjgxZWI4NGJmNzVkNGE3NjQ1ODEx ClhlbnZpZiAtIDE4MzIyOWU4YjZkNjZkZWNhZDFjNjA4NTUwZjFiNTRjYmVlY2UxMzIgKHBhdGNo cSBicmluZ3MgcGF0Y2ggbGV2ZSBpbiBsaW5lIHdpdGggN2ViM2RmZjhiZjI5M2I0OTk3MDc3ODJk YmEyZmIxN2NkNTZmNjljYSkKCldoaWxlIHRoZXNlIGFyZSBub3QgZXhhY3RseSB0aGUgdGFnZ2Vk IHZlcnNpb25zLCB0aGVyZSBzaG91bGQgYmUgbm90aGluZyBpbiB0aGUgcGF0Y2hlcyB0aGF0IGNo YW5nZXMgd2hxbC9sb2dvIHJlc3VsdHMuCgpPd2VuCgo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0t LS0tCj4gRnJvbTogRHVycmFudCwgUGF1bCBbbWFpbHRvOnBkdXJyYW50QGFtYXpvbi5jb21dCj4g U2VudDogMjggTm92ZW1iZXIgMjAxOSAxNjoxMgo+IFRvOiB3aW4tcHYtZGV2ZWxAbGlzdHMueGVu cHJvamVjdC5vcmcKPiBDYzogT3dlbiBTbWl0aCA8b3dlbi5zbWl0aEBjaXRyaXguY29tPgo+IFN1 YmplY3Q6IDkuMC4wLXJjMSB0YWdnZWQKPiAKPiBIaSwKPiAKPiAgIEkgaGF2ZSBjcmVhdGVkIGEg c3RhZ2luZy05LjAgYnJhbmNoIGluIGFsbCB0aGUgZHJpdmVyIHJlcG9zIGFuZCB0YWdnZWQgdGhp cyBhcwo+IDkuMC4wLXJjMS4gSSBwbGFuIHRvIG1vdmUgdGhlIGRlZmF1bHQgTUlOT1JfVkVSU0lP TiBvbiBtYXN0ZXIgZnJvbSAwIHRvIDEKPiBzaG9ydGx5Lgo+ICAgUGxlYXNlIHRlc3QgdGhlIHRh Z2dlZCB2ZXJzaW9ucyAoYmluYXJpZXMgYXZhaWxhYmxlIGF0Cj4gaHR0cDovL3hlbmJpdHMueGVu cHJvamVjdC5vcmcvcHZkcml2ZXJzL3dpbi85LjAuMCkuIEkgaGF2ZW4ndCBmb3VuZCBhbnkKPiBw cm9ibGVtcyBpbiB0ZXN0aW5nIGFuZCBJIGJlbGlldmUgdGhleSBhcmUgYWxsIGZpdCBmb3IgbG9n byB0ZXN0aW5nIChPd2VuIHBsZWFzZQo+IGNvcnJlY3QgbWUgaWYgSSdtIHdyb25nKS4gSWYgbm8g cHJvYmxlbXMgYXJlIGJyb3VnaHQgdG8gbXkgYXR0ZW50aW9uIGluIHRoZQo+IG5leHQgd2VlayB0 aGVuIEkgaW50ZW5kIHRvIHNpZ24gYW5kIHJlbGVhc2UgdmVyc2lvbiA5LjAuMCBzaG9ydGx5IHRo ZXJlYWZ0ZXIuCj4gCj4gICBDaGVlcnMsCj4gCj4gICAgIFBhdWwKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCndpbi1wdi1kZXZlbCBtYWlsaW5nIGxpc3QK d2luLXB2LWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVj dC5vcmcvbWFpbG1hbi9saXN0aW5mby93aW4tcHYtZGV2ZWw= From win-pv-devel-bounces@lists.xenproject.org Thu Nov 28 18:12:55 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 28 Nov 2019 18:12:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaOHe-0002dw-FJ; Thu, 28 Nov 2019 18:12:54 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaOHd-0002dr-63 for win-pv-devel@lists.xenproject.org; Thu, 28 Nov 2019 18:12:53 +0000 X-Inumbo-ID: b18557d2-120a-11ea-a55d-bc764e2007e4 Received: from mail-io1-xd42.google.com (unknown [2607:f8b0:4864:20::d42]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b18557d2-120a-11ea-a55d-bc764e2007e4; Thu, 28 Nov 2019 18:12:52 +0000 (UTC) Received: by mail-io1-xd42.google.com with SMTP id x21so29835674ior.2; Thu, 28 Nov 2019 10:12:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=HrXAeNRavtrNwfJt1woj+FSD5vWMNwFbf70UfxaD7IY=; b=LfPcXuCmF7AJjxnlcuoqczyfyQMh1ECXE7svGvSCdxF1qy67kE2MTa1raH7kTVsjAN Q1d3TPvN9nXsc1z01mA+DgRYrW4ow+dM9XxJd+DHchMtN762OsdLt/0W5sOHvLPVKURq Hoybu1rqG9c90XVvjPjol96gtGueJVcgwrnb8YlCMUaRyMCqUeBymwb8WYcn6WotapeY aE0JzqmoYVTHVxOQVvz7bEDR+xjMJZ9Jexekf9F9EPVJBiRTo4dz6hb5j8qiHC7bFMv9 G8CLobUcXDX9y17yH20/JaWeya3Qd6ER0lmfmxxIThtiIw0iPDNQGvVAs+giDi5sauml 3hFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=HrXAeNRavtrNwfJt1woj+FSD5vWMNwFbf70UfxaD7IY=; b=NCtxyreObPYmc8I+Q+ECrqaXgISwcXi2runWzwQzlTReVVGMUVwMa4yfLMjAYOHcQt JVibxAw0wEfA/srJDuSBODvr5V0C7ZCsXXHp8LjwiCLxz13jvalGZ4ilmn5m9xzpHSEx C0fktmLgdWluKUVneuxId70XEu042NlsFFiuUK4tVNZKgdHvEhi+V4eYuBUo3Ivt3F/o R8Wt1knIhVkpcr8d9cDHUuld6m0kicX6TnlEYx8lkmSW3s0bceH2NHXo1FVneAarxF84 sHRbf7rIn0zRXFHql6P+/mKxcrsQVWnHL0lfGrutXxhAiCC7W9XM3z7z6biYNfvkxwH2 27Ug== X-Gm-Message-State: APjAAAX+98W0ECb44WhJGHKD5uwBF/g6zg9nwabC7bWlDyrYJ4PKUi6K E7zVmpWvnCAdaKk1pCNZJCldm/vo X-Google-Smtp-Source: APXvYqyHa7pV97fkp+6+5nGwFkW9jr7x0nkUy8/yTfUqhPuRYRkFL/fOgdpq+UKX5MrLiJyKerlVwQ== X-Received: by 2002:a5e:9918:: with SMTP id t24mr1706252ioj.266.1574964772037; Thu, 28 Nov 2019 10:12:52 -0800 (PST) Received: from [100.64.73.55] ([173.245.215.240]) by smtp.gmail.com with ESMTPSA id h6sm899897iom.43.2019.11.28.10.12.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Nov 2019 10:12:51 -0800 (PST) From: Rich Persaud Mime-Version: 1.0 (1.0) Date: Thu, 28 Nov 2019 13:12:50 -0500 Message-Id: <10E1B547-180B-4620-9E4A-62C5B0DB2B93@gmail.com> References: <909826df-25c1-6d7c-75d9-470365d2ecf6@suse.com> In-Reply-To: <909826df-25c1-6d7c-75d9-470365d2ecf6@suse.com> To: Jan Beulich X-Mailer: iPhone Mail (17B111) Subject: Re: [win-pv-devel] [Xen-devel] [PATCH v2 4/6] Add Code Review Guide X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Lars Kurth , Stefano Stabellini , Lars Kurth , xen-api@lists.xenproject.org, minios-devel@lists.xenproject.org, committers@xenproject.org, mirageos-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, win-pv-devel@lists.xenproject.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" T24gTm92IDI4LCAyMDE5LCBhdCAwNToxMiwgSmFuIEJldWxpY2ggPEpCZXVsaWNoQHN1c2UuY29t PiB3cm90ZToKPiAKPiDvu79PbiAyOC4xMS4yMDE5IDAxOjU0LCBTdGVmYW5vIFN0YWJlbGxpbmkg d3JvdGU6Cj4+PiBPbiBUaHUsIDI2IFNlcCAyMDE5LCBMYXJzIEt1cnRoIHdyb3RlOgo+Pj4gRnJv bTogTGFycyBLdXJ0aCA8bGFycy5rdXJ0aEBjaXRyaXguY29tPgo+Pj4gCj4+PiBUaGlzIGRvY3Vt ZW50IGhpZ2hsaWdodHMgd2hhdCByZXZpZXdlcnMgc3VjaCBhcyBtYWludGFpbmVycyBhbmQgY29t bWl0dGVycyBsb29rCj4+PiBmb3Igd2hlbiByZXZpZXdpbmcgY29kZS4gSXQgc2V0cyBleHBlY3Rh dGlvbnMgZm9yIGNvZGUgYXV0aG9ycyBhbmQgcHJvdmlkZXMKPj4+IGEgZnJhbWV3b3JrIGZvciBj b2RlIHJldmlld2Vycy4KPj4gCj4+IEkgdGhpbmsgdGhlIGRvY3VtZW50IGlzIG1pc3NpbmcgYSBj b3VwbGUgb2YgdGhpbmdzOgo+PiAKPj4gLSBhIHNpbXBsZSBvbmUgbGluZSBzdGF0ZW1lbnQgdGhh dCBwb3NzaWJseSB0aGUgbW9zdCBpbXBvcnRhbnQgdGhpbmcgaW4KPj4gIGEgY29kZSByZXZpZXcg aXMgdG8gaW5kZW50aWZ5IGFueSBidWdzIGluIHRoZSBjb2RlCj4+IAo+PiAtIGFuIGV4cGxhbmF0 aW9uIHRoYXQgcmVxdWVzdHMgZm9yIG1ham9yIGNoYW5nZXMgdG8gdGhlIHNlcmllcyBzaG91bGQg YmUKPj4gIG1hZGUgZWFybHkgb24gKGkuZS4gbGV0J3Mgbm90IGNoYW5nZSB0aGUgYXJjaGl0ZWN0 dXJlIG9mIGEgZmVhdHVyZSBhdAo+PiAgdjkgaWYgcG9zc2libGUpIEkgYWxzbyBtYWRlIHRoaXMg Y29tbWVudCBpbiByZXBseSB0byBwYXRjaCAjNS4gSSdsbAo+PiAgbGV0IHlvdSBkZWNpZGUgd2hl cmUgaXMgdGhlIGJlc3QgcGxhY2UgZm9yIGl0Lgo+IAo+IFRoaXMgbmVlZHMgYmFsYW5jaW5nLiBQ ZW9wbGUgY3J1Y2lhbCB0byB0aGUgZXZhbHVhdGlvbiBvZiBhIG5ldwo+IGZlYXR1cmUgYW5kIGl0 cyBpbXBsZW1lbnRhdGlvbiBzaW1wbHkgbWF5IG5vdCBoYXZlIHRoZSB0aW1lIHRvCj4gcmVwbHkg cHJpb3IgdG8gdjkuIFdlJ3ZlIGhhZCBzaXR1YXRpb25zIHdoZXJlIHBlb3BsZSBwb3N0ZWQgbmV3 Cj4gcmV2aXNpb25zIGV2ZXJ5IG90aGVyIGRheSwgc29tZXRpbWVzIGV2ZW4gbW9yZSB0aGFuIG9u ZSBwZXIgZGF5Lgo+IAo+IEFzIGluZGljYXRlZCBpbiBzZXZlcmFsIG90aGVyIGNvbnRleHRzIGJl Zm9yZSAtIGltbyBwZW9wbGUgbm90Cj4gaGVscGluZyB0byBzaG91bGRlciB0aGUgcmV2aWV3IGxv YWQgc2hvdWxkIGFsc28gbm90IGhhdmUgdGhlCj4gZXhwZWN0YXRpb24gdGhhdCB0aGVpciAobGFy Z2UpIGNvbnRyaWJ1dGlvbnMgd2lsbCBiZSBsb29rZWQgYXQKPiBpbiBkdWUgY291cnNlLiAKClRv IG1ha2UgdGhpcyBhY3Rpb25hYmxlLCB3ZSBjb3VsZCBoYXZlOgoKLSByZXZpZXdlciBkZW1hbmQg aW5kZXg6ICBhdXRvbWF0ZWQgaW5kZXggb2Ygb3BlbiBwYXRjaGVzIHN0aWxsIGluIG5lZWQgb2Yg cmV2aWV3LCBzb3J0ZWQgYnkgZGVjcmVhc2luZyBhZ2UKCi0gcmV2aWV3IGZsb3cgY29udHJvbDog IGVhY2ggbmV3IHBhdGNoIHN1Ym1pc3Npb24gY2l0ZXMgb25lIHJlY2VudCByZXZpZXcgYnkgdGhl IHBhdGNoIHN1Ym1pdHRlciwgZm9yIGEgcGF0Y2ggb2YgY29tcGFyYWJsZSBzaXplCgotIHJldmll d2VyIHN1cHBseSBncm93dGg6ICBhIGJvb3RzdHJhcHBpbmcgZ3VpZGUgZm9yIG5ldyByZXZpZXdl cnMgYW5kIHN1Ym1pdHRlcnMsIHdpdGggcGF0dGVybnMsIGFudGktcGF0dGVybnMsIGFuZCBleGFt cGxlcyB0byBiZSBlbXVsYXRlZAoKUmljaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwp3aW4tcHYtZGV2ZWwgbWFpbGluZyBsaXN0Cndpbi1wdi1kZXZlbEBs aXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4v bGlzdGluZm8vd2luLXB2LWRldmVs From win-pv-devel-bounces@lists.xenproject.org Thu Nov 28 18:19:06 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 28 Nov 2019 18:19:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaONd-0002wX-Em; Thu, 28 Nov 2019 18:19:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaONc-0002wS-O5 for win-pv-devel@lists.xenproject.org; Thu, 28 Nov 2019 18:19:04 +0000 X-Inumbo-ID: 8ebf5300-120b-11ea-9db0-bc764e2007e4 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8ebf5300-120b-11ea-9db0-bc764e2007e4; Thu, 28 Nov 2019 18:19:04 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F0D5421739; Thu, 28 Nov 2019 18:19:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574965143; bh=4eadUOFodiAewEVAyGu3RvP0bCStPoR/dp2TOA79cHE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=YmVc3BNYjyOQzSLZDSPZ3ftg/nRksKS/BBpgHEUB+skgw1I9qytTR8G0+0MhjvO8Q A+0iufBsqlM8n/SNv2ipJLdjyj38RvRrYHQnRDU21PF1wJ3v6Gt5iDWvbFt9eq8dgr ggleaV/4PzV7+gjV36m9XQJ72Kk7gCSytv1N2ff8= Date: Thu, 28 Nov 2019 10:19:02 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Jan Beulich In-Reply-To: <909826df-25c1-6d7c-75d9-470365d2ecf6@suse.com> Message-ID: References: <97e3adf75cf71ba39e702d4cab23236ada8d5a6c.1569525222.git.lars.kurth@citrix.com> <909826df-25c1-6d7c-75d9-470365d2ecf6@suse.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Subject: Re: [win-pv-devel] [Xen-devel] [PATCH v2 4/6] Add Code Review Guide X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Lars Kurth , Stefano Stabellini , Lars Kurth , xen-api@lists.xenproject.org, minios-devel@lists.xenproject.org, committers@xenproject.org, mirageos-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, win-pv-devel@lists.xenproject.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" T24gVGh1LCAyOCBOb3YgMjAxOSwgSmFuIEJldWxpY2ggd3JvdGU6Cj4gT24gMjguMTEuMjAxOSAw MTo1NCwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOgo+ID4gT24gVGh1LCAyNiBTZXAgMjAxOSwg TGFycyBLdXJ0aCB3cm90ZToKPiA+PiBGcm9tOiBMYXJzIEt1cnRoIDxsYXJzLmt1cnRoQGNpdHJp eC5jb20+Cj4gPj4KPiA+PiBUaGlzIGRvY3VtZW50IGhpZ2hsaWdodHMgd2hhdCByZXZpZXdlcnMg c3VjaCBhcyBtYWludGFpbmVycyBhbmQgY29tbWl0dGVycyBsb29rCj4gPj4gZm9yIHdoZW4gcmV2 aWV3aW5nIGNvZGUuIEl0IHNldHMgZXhwZWN0YXRpb25zIGZvciBjb2RlIGF1dGhvcnMgYW5kIHBy b3ZpZGVzCj4gPj4gYSBmcmFtZXdvcmsgZm9yIGNvZGUgcmV2aWV3ZXJzLgo+ID4gCj4gPiBJIHRo aW5rIHRoZSBkb2N1bWVudCBpcyBtaXNzaW5nIGEgY291cGxlIG9mIHRoaW5nczoKPiA+IAo+ID4g LSBhIHNpbXBsZSBvbmUgbGluZSBzdGF0ZW1lbnQgdGhhdCBwb3NzaWJseSB0aGUgbW9zdCBpbXBv cnRhbnQgdGhpbmcgaW4KPiA+ICAgYSBjb2RlIHJldmlldyBpcyB0byBpbmRlbnRpZnkgYW55IGJ1 Z3MgaW4gdGhlIGNvZGUKPiA+IAo+ID4gLSBhbiBleHBsYW5hdGlvbiB0aGF0IHJlcXVlc3RzIGZv ciBtYWpvciBjaGFuZ2VzIHRvIHRoZSBzZXJpZXMgc2hvdWxkIGJlCj4gPiAgIG1hZGUgZWFybHkg b24gKGkuZS4gbGV0J3Mgbm90IGNoYW5nZSB0aGUgYXJjaGl0ZWN0dXJlIG9mIGEgZmVhdHVyZSBh dAo+ID4gICB2OSBpZiBwb3NzaWJsZSkgSSBhbHNvIG1hZGUgdGhpcyBjb21tZW50IGluIHJlcGx5 IHRvIHBhdGNoICM1LiBJJ2xsCj4gPiAgIGxldCB5b3UgZGVjaWRlIHdoZXJlIGlzIHRoZSBiZXN0 IHBsYWNlIGZvciBpdC4KPiAKPiBUaGlzIG5lZWRzIGJhbGFuY2luZy4gUGVvcGxlIGNydWNpYWwg dG8gdGhlIGV2YWx1YXRpb24gb2YgYSBuZXcKPiBmZWF0dXJlIGFuZCBpdHMgaW1wbGVtZW50YXRp b24gc2ltcGx5IG1heSBub3QgaGF2ZSB0aGUgdGltZSB0bwo+IHJlcGx5IHByaW9yIHRvIHY5LiBX ZSd2ZSBoYWQgc2l0dWF0aW9ucyB3aGVyZSBwZW9wbGUgcG9zdGVkIG5ldwo+IHJldmlzaW9ucyBl dmVyeSBvdGhlciBkYXksIHNvbWV0aW1lcyBldmVuIG1vcmUgdGhhbiBvbmUgcGVyIGRheS4KClll cywgeW91IGFyZSByaWdodCwgaXQgbmVlZHMgYmFsYW5jaW5nLiBUaGlzIGlzIG5vdCBtZWFudCB0 byBlbmNvdXJhZ2UKY29udHJpYnV0b3JzIHRvIHNlbmQgOSB2ZXJzaW9ucyBvZiBhIHNlcmllcyB3 aXRoaW4gYSB3ZWVrIG9yIHR3byA6LSkKCldlIGNvdWxkIHNheSB0aGF0ICJjb250cmlidXRvcnMg c2hvdWxkIG1ha2Ugc3VyZSB0byBnaXZlIGVub3VnaCB0aW1lIHRvCmFsbCB0aGUga2V5IHN0YWtl aG9sZGVycyB0byByZXZpZXcgdGhlIHNlcmllcyIuCgoKCj4gQXMgaW5kaWNhdGVkIGluIHNldmVy YWwgb3RoZXIgY29udGV4dHMgYmVmb3JlIC0gaW1vIHBlb3BsZSBub3QKPiBoZWxwaW5nIHRvIHNo b3VsZGVyIHRoZSByZXZpZXcgbG9hZCBzaG91bGQgYWxzbyBub3QgaGF2ZSB0aGUKPiBleHBlY3Rh dGlvbiB0aGF0IHRoZWlyIChsYXJnZSkgY29udHJpYnV0aW9ucyB3aWxsIGJlIGxvb2tlZCBhdAo+ IGluIGR1ZSBjb3Vyc2UuIAoKSSB0aGluayB5b3UgYXJlIHJpZ2h0IG9uIHRoaXMgcG9pbnQsIGFu ZCBtYXliZSB3ZSBjb3VsZCBhZGQgc29tZXRoaW5nIHRvCnRoYXQgZWZmZWN0CgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwp3aW4tcHYtZGV2ZWwgbWFpbGlu ZyBsaXN0Cndpbi1wdi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhl bnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8vd2luLXB2LWRldmVs From win-pv-devel-bounces@lists.xenproject.org Thu Nov 28 18:21:11 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 28 Nov 2019 18:21:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaOPf-0003lV-MJ; Thu, 28 Nov 2019 18:21:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaOPd-0003l3-Ut for win-pv-devel@lists.xenproject.org; Thu, 28 Nov 2019 18:21:09 +0000 X-Inumbo-ID: d3c0cb14-120b-11ea-a55d-bc764e2007e4 Received: from mail-il1-x12a.google.com (unknown [2607:f8b0:4864:20::12a]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d3c0cb14-120b-11ea-a55d-bc764e2007e4; Thu, 28 Nov 2019 18:20:59 +0000 (UTC) Received: by mail-il1-x12a.google.com with SMTP id y16so17383866iln.0; Thu, 28 Nov 2019 10:20:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=0xiLckWEvZYaYgs12VkwyEzfWMBUsfYaTUG8oheFVjg=; b=GHL1+E5WHHKFmEUnhuHehEiHaxat2j53zQgYxHnKgx3nm6M5qp8Aett7k3YjDipnoC efvVpptHCcHjhzyp4PF8K0L4W4BS4VSfJ/NDaxEoqMsxhZjY08Zhv0SwwO0jHkedRurv Z65A2dqo/PJBH96loho49CpzwO9c25sdwcV9HG1P0sHdjyIfGrQZ5BFxA9aWcqNnnalX V0xT26Om1V2Sx+Tj0VC1RoaF9NOHSkBtwq7m+e+QZGHxhwMJuyuA+HO+aNr7vR5qWUu0 0rhyzLv37oQLO85LBx9uNsbUMGCiWC3M7DEI3rGEG1JQVrnS6hDbOOfyZ6PZ5INeEeUb rBxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=0xiLckWEvZYaYgs12VkwyEzfWMBUsfYaTUG8oheFVjg=; b=Nk7OXu5MQwTVVBK+WZgefSAuFsUUkOLZDqrl9N/OOj+S/wFQ9y49wXX6KVIN3QtKah Jyz0SKm0vdpr6+43jim2B9QvTn3P0K8NAGEq3WJEQJitwXk5z+6x6eLhQnzSTXceBW2C i7E/eNdPZQqkT3EWUtNyMc737+qIajWWxrTQPvcWPeFUiIBatV7+UdXh9M1+fofNmaeo 2mz/Lvc69BApq/XID+1AJi07iydFnwD0vwPe2dQ87R1j91uU+vRtAU+M4gpdk8GFOqGY zbofI0bHyW79fJtxwo4BF+2hrcf5bA8Cry9QdJP7TS4Z4bGPPTyzBtdM+Pin8kD2EIMz 59XQ== X-Gm-Message-State: APjAAAW+MgnoyoeVmdzQWUWRCQ3zZwYuzVSJXCWesCDwELQsyn8pdUGN XyqCIn1eYltyD1UUz13HXFeVyQAw X-Google-Smtp-Source: APXvYqxkIphacg14IGKuEq0t+X4WySWUVREcKzIiQtQM/2C6hv9ADij512RHfKUaW7LPtc45DtFLbw== X-Received: by 2002:a92:d351:: with SMTP id a17mr51858856ilh.231.1574965258996; Thu, 28 Nov 2019 10:20:58 -0800 (PST) Received: from [100.64.73.55] ([173.245.215.240]) by smtp.gmail.com with ESMTPSA id t88sm1925675ill.51.2019.11.28.10.20.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Nov 2019 10:20:58 -0800 (PST) From: Rich Persaud Mime-Version: 1.0 (1.0) Date: Thu, 28 Nov 2019 13:20:57 -0500 Message-Id: <6DC58DC2-5F2F-4496-A0F5-A91F11FD931B@gmail.com> References: In-Reply-To: To: Lars Kurth X-Mailer: iPhone Mail (17B111) Subject: Re: [win-pv-devel] [MirageOS-devel] [PATCH v2 4/6] Add Code Review Guide X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Lars Kurth , Stefano Stabellini , "mirageos-devel@lists.xenproject.org" , "xen-api@lists.xenproject.org" , "minios-devel@lists.xenproject.org" , "committers@xenproject.org" , Jan Beulich , "xen-devel@lists.xenproject.org" , "win-pv-devel@lists.xenproject.org" Content-Type: multipart/mixed; boundary="===============7567666043923755124==" Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" --===============7567666043923755124== Content-Type: multipart/alternative; boundary=Apple-Mail-6DF36A48-D61F-4E31-B9CE-03DC73CAF014 Content-Transfer-Encoding: 7bit --Apple-Mail-6DF36A48-D61F-4E31-B9CE-03DC73CAF014 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Nov 28, 2019, at 09:05, Lars Kurth wrote: >=20 > =EF=BB=BFOn 28/11/2019, 07:37, "Jan Beulich" wrote: >=20 >> On 28.11.2019 14:06, Lars Kurth wrote: >> I can certainly add something on the timing , along the lines of >> * For complex series, consider the time it takes to do reviews (maybe wit= h a guide of LOC per hour) and give reviewers enough time to >> * For series with design issues or large questions, try and highlight the= key open issues in cover letters clearly and solicit feedback from key main= tainers who can comment on the open issue. The idea is to save both the cont= ributor and the reviewers time by focussing on what needs to be resolved=20 >> * Don=E2=80=99t repost a series, unless all review comments are addressed= >> or the reviewers asked you to do so. The problem with this is that >> this is somewhat in conflict with the "let's focus on the core >> issues and not get distracted by details early on in a review cycle". >> In other words, this can only work, if reviewers focus on major >> issues in early reviews only and do not focus on style, coding >> standards, etc. >=20 > But this doesn't make much sense either, because then full re-reviews > need to happen anyway on later versions, to also deal with the minor > issues. For RFC kind of series omitting style and alike feedback > certainly makes sense, but as soon as a patch is non-RFC, it should > be considered good to go in by the submitter. >=20 > OK, I think we have a disconnect between ideal and reality.=20 >=20 > I see two issues today > * Key maintainers don't always review RFC series [they end up at the botto= m of the priority list, even though spending time on RFCs will save time els= ewhere later]. So the effect is that then the contributor assumes there are n= o major issues and ends it as a proper series > * In practice what has happened often in the past is that design, architec= ture, assumption flaws are found in early versions of a series. > - This usually happens because of an oversight or because there was no d= esign discussion prior to the series being posted and agreed > - Common sense would dictate that the biggest benefit for both the revie= wer, the contributor and the community as a whole would be to try and focus o= n such flaws and leave everything aside > - Of course there may be value in doing a detailed reviews of such a ser= ies as there may be bits that are unaffected by such a flaw > - But there will likely be parts which are not: doing a detailed review o= f such portions wastes everyone's time >=20 > So coming back to your point. Ideally, it would be nice if we had the capa= bility to call out parts of a series as "problematic" and treating such part= s differently. We may be able to reuse some "Shift Left" terminology, including citations o= f previous Xen code reviews to illustrate categories of design issues that c= an be shifted left: https://devopedia.org/shift-left Rich --Apple-Mail-6DF36A48-D61F-4E31-B9CE-03DC73CAF014 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
On Nov 28, 2019, at 09:05,= Lars Kurth <lars.kurth@citrix.com> wrote:

=EF=BB=BFOn 28/11/2019, 07:37, "Jan Beulich" <jbeulich@s= use.com> wrote:

   On 28= .11.2019 14:06, Lars Kurth wrote:
= I can certainly add something on the timing , along the lines of
<= /blockquote>
* For complex series, consider t= he time it takes to do reviews (maybe with a guide of LOC per hour) and give= reviewers enough time to
<= span>* For series with design issues or large questions, try and highlight t= he key open issues in cover letters clearly and solicit feedback from key ma= intainers who can comment on the open issue. The idea is to save both the co= ntributor and the reviewers time by focussing on what needs to be resolved <= /span>
* Don=E2=80=99t repos= t a series, unless all review comments are addressed
=
or the reviewers asked you to do so. The pro= blem with this is that
this is somewhat in conflict with the "let's focus on the core
<= /blockquote>
issues and not get distracted by= details early on in a review cycle".
In other words, this can only work, if reviewers focus on m= ajor
issues in early r= eviews only and do not focus on style, coding
standards, etc.

   But this doesn't make much sense either, becau= se then full re-reviews
   need to happen an= yway on later versions, to also deal with the minor
 &= nbsp; issues. For RFC kind of series omitting style and alike feedback<= /span>
   certainly makes sense, but as soon as a p= atch is non-RFC, it should
   be considered g= ood to go in by the submitter.

OK, I think w= e have a disconnect between ideal and reality.

<= span>I see two issues today
* Key maintainers don't always r= eview RFC series [they end up at the bottom of the priority list, even thoug= h spending time on RFCs will save time elsewhere later]. So the effect is th= at then the contributor assumes there are no major issues and ends it as a p= roper series
* In practice what has happened often in the pa= st is that design, architecture, assumption flaws are found in early version= s of a series.
  - This usually happens because o= f an oversight or because there was no design discussion prior to the series= being posted and agreed
  - Common sense would d= ictate that the biggest benefit for both the reviewer, the contributor and t= he community as a whole would be to try and focus on such flaws and leave ev= erything aside
  - Of course there may be value i= n doing a detailed reviews of such a series as there may be bits that are un= affected by such a flaw
  - But there will likely= be parts which are not: doing a detailed review of such portions wastes eve= ryone's time

So coming back to your point. I= deally, it would be nice if we had the capability to call out parts of a ser= ies as "problematic" and treating such parts differently.

We may be able to reuse some "Shift Left" ter= minology, including citations of previous Xen code reviews to illustrate cat= egories of design issues that can be shifted left:


Rich

<= /html>= --Apple-Mail-6DF36A48-D61F-4E31-B9CE-03DC73CAF014-- --===============7567666043923755124== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Kd2luLXB2LWRl dmVsIG1haWxpbmcgbGlzdAp3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6 Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3dpbi1wdi1kZXZlbA== --===============7567666043923755124==-- From win-pv-devel-bounces@lists.xenproject.org Thu Nov 28 18:51:04 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 28 Nov 2019 18:51:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaOsZ-0006Ia-Sp; Thu, 28 Nov 2019 18:51:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaOsY-0006IR-FF for win-pv-devel@lists.xenproject.org; Thu, 28 Nov 2019 18:51:02 +0000 X-Inumbo-ID: 00026814-1210-11ea-a55d-bc764e2007e4 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 00026814-1210-11ea-a55d-bc764e2007e4; Thu, 28 Nov 2019 18:50:52 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 120AC2176D; Thu, 28 Nov 2019 18:50:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574967051; bh=1xFCF26BlyET20S9fCGCGzPAWkKCiagit2EU6Nzh7ak=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=vSiwJsKXPW9Ol+ybTCE7F81QQjoKjyYfOZfuaNqVCsfDZg/pIbETND3kLguuSu+8r Z5o4RoQQsiSdv3m9A+8dFQlZ5WxhoduX7PtOeyMNUVZekbzNwRM4uDzZ4SR3VtB6fF 6Ht0tDHkHpQ71ZBhSEV8JoYF9ULzpPOybNplbOhs= Date: Thu, 28 Nov 2019 10:50:50 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Jan Beulich In-Reply-To: <22b7f67c-c3dc-5450-999f-e79168175d39@suse.com> Message-ID: References: <2e4b36afaa73277d246d7e84037db1532a136ec7.1569525222.git.lars.kurth@citrix.com> <22b7f67c-c3dc-5450-999f-e79168175d39@suse.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Subject: Re: [win-pv-devel] [Xen-devel] [PATCH v2 6/6] Added Resolving Disagreement X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Lars Kurth , Stefano Stabellini , Lars Kurth , xen-api@lists.xenproject.org, minios-devel@lists.xenproject.org, committers@xenproject.org, mirageos-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, win-pv-devel@lists.xenproject.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" T24gVGh1LCAyOCBOb3YgMjAxOSwgSmFuIEJldWxpY2ggd3JvdGU6Cj4gT24gMjguMTEuMjAxOSAw MTo1NiwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOgo+ID4gT24gVGh1LCAyNiBTZXAgMjAxOSwg TGFycyBLdXJ0aCB3cm90ZToKPiA+PiArVGhpcyBjb3VsZCB0YWtlIGZvciBleGFtcGxlIHRoZSBm b3JtIG9mCj4gPj4gKz4gRG8geW91IHRoaW5rIGl0IHdvdWxkIGJlIHVzZWZ1bCBmb3IgdGhlIGNv ZGUgdG8gZG8gWFhYPyAKPiA+PiArPiBJIGNhbiBpbWFnaW5lIGEgdXNlciB3YW50aW5nIHRvIGRv IFlZWSAoYW5kIFhYWCB3b3VsZCBlbmFibGUgdGhpcykKPiA+PiArCj4gPj4gK1RoYXQgcG90ZW50 aWFsbHkgYWRkcyBhZGRpdGlvbmFsIHdvcmsgZm9yIHRoZSBjb2RlIGF1dGhvciwgd2hpY2ggdGhl eSBtYXkgbm90IGhhdmUKPiA+PiArdGhlIHRpbWUgdG8gcGVyZm9ybS4gSXQgaXMgZ29vZCBwcmFj dGljZSBmb3IgYXV0aG9ycyB0byBjb25zaWRlciBzdWNoIGEgcmVxdWVzdCBpbiB0ZXJtcyBvZgo+ ID4+ICsqIFVzZWZ1bG5lc3MgdG8gdGhlIHVzZXIKPiA+PiArKiBDb2RlIGNodXJuLCBjb21wbGV4 aXR5IG9yIGltcGFjdCBvbiBvdGhlciBzeXN0ZW0gcHJvcGVydGllcwo+ID4+ICsqIEV4dHJhIHRp bWUgdG8gaW1wbGVtZW50IGFuZCByZXBvcnQgYmFjayB0byB0aGUgcmV2aWV3ZXIKPiA+PiArCj4g Pj4gK0lmIHlvdSBiZWxpZXZlIHRoYXQgdGhlIGltcGFjdC9jb3N0IGlzIHRvbyBoaWdoLCByZXBv cnQgYmFjayB0byB0aGUgcmV2aWV3ZXIuIFRvIHJlc29sdmUKPiA+PiArdGhpcywgaXQgaXMgYWR2 aXNhYmxlIHRvCj4gPj4gKyogUmVwb3J0IHlvdXIgZmluZGluZ3MKPiA+PiArKiBBbmQgdGhlbiBj aGVjayB3aGV0aGVyIHRoaXMgd2FzIG1lcmVseSBhbiBpbnRlcmVzdGluZyBzdWdnZXN0aW9uLCBv ciBzb21ldGhpbmcgdGhlCj4gPj4gK3Jldmlld2VyIGZlZWxzIG1vcmUgc3Ryb25nbHkgYWJvdXQK PiA+PiArCj4gPj4gK0luIHRoZSBsYXR0ZXIgY2FzZSwgdGhlcmUgYXJlIHR5cGljYWxseSBzZXZl cmFsIGNvbW1vbiBvdXRjb21lcwo+ID4+ICsqIFRoZSAqKmF1dGhvciBhbmQgcmV2aWV3ZXIgYWdy ZWUqKiB0aGF0IHRoZSBzdWdnZXN0aW9uIHNob3VsZCBiZSBpbXBsZW1lbnRlZAo+ID4+ICsqIFRo ZSAqKmF1dGhvciBhbmQgcmV2aWV3ZXIgYWdyZWUqKiB0aGF0IGl0IG1heSBtYWtlIHNlbnNlIHRv IGRlZmVyIGltcGxlbWVudGF0aW9uCj4gPj4gKyogVGhlICoqYXV0aG9yIGFuZCByZXZpZXdlciBh Z3JlZSoqIHRoYXQgaXQgbWFrZXMgbm8gc2Vuc2UgdG8gaW1wbGVtZW50IHRoZSBzdWdnZXN0aW9u Cj4gPj4gKwo+ID4+ICtUaGUgYXV0aG9yIG9mIGEgcGF0Y2ggd291bGQgdHlwaWNhbGx5IHN1Z2dl c3QgdGhlaXIgcHJlZmVycmVkIG91dGNvbWUsIGZvciBleGFtcGxlCj4gPj4gKz4gSSBhbSBub3Qg c3VyZSBpdCBpcyB3b3J0aCB0byBpbXBsZW1lbnQgWFhYCj4gPj4gKz4gRG8geW91IHRoaW5rIHRo aXMgY291bGQgYmUgZG9uZSBhcyBhIHNlcGFyYXRlIHBhdGNoIGluIGZ1dHVyZT8KPiA+PiArCj4g Pj4gK0luIGNhc2VzLCB3aGVyZSBubyBhZ3JlZW1lbnQgY2FuIGJlIGZvdW5kLCB0aGUgYmVzdCBh cHByb2FjaCB3b3VsZCBiZSB0byBnZXQgYW4KPiA+PiAraW5kZXBlbmRlbnQgb3BpbmlvbiBmcm9t IGFub3RoZXIgbWFpbnRhaW5lciBvciB0aGUgcHJvamVjdCdzIGxlYWRlcnNoaXAgdGVhbS4KPiA+ IAo+ID4gSSB0aGluayB3ZSBzaG91bGQgbWVudGlvbiBzb21ld2hlcmUgaGVyZSB0aGF0IGl0IGlz IHJlY29tbWVuZGVkIGZvcgo+ID4gcmV2aWV3ZXJzIHRvIGJlIGV4cGxpY2l0IGFib3V0IHdoZXRo ZXIgYSByZXF1ZXN0IGlzIG9wdGlvbmFsIG9yIHdoZXRoZXIKPiA+IGl0IGlzIGEgcmVxdWlyZW1l bnQuCj4gPiAKPiA+IEZvciBpbnN0YW5jZTogIkkgdGhpbmsgaXQgd291bGQgYmUgZ29vZCBpZiBY IGFsc28gZGlkIFkiIGRvZXNuJ3Qgc2F5IGlmCj4gPiBpdCBpcyBvcHRpb25hbCAoZnV0dXJlIHdv cmspIG9yIGl0IGlzIGFjdHVhbGx5IHJlcXVpcmVkIGFzIHBhcnQgb2YgdGhpcwo+ID4gc2VyaWVz LiBNb3JlIGV4cGxpY2l0IHdvcmQgY2hvaWNlcyBhcmUgcHJlZmVyYWJsZSwgc3VjaCBhczoKPiA+ IAo+ID4gIkkgdGhpbmsgaXQgd291bGQgYmUgZ29vZCBpZiBYIGFsc28gZGlkIFksIG5vdCBhIHJl cXVpcmVtZW50IGJ1dCBnb29kIHRvCj4gPiBoYXZlLiIKPiA+IAo+ID4gIkkgdGhpbmsgaXQgd291 bGQgYmUgZ29vZCBpZiBYIGFsc28gZGlkIFkgYW5kIGl0IHNob3VsZCBiZSBwYXJ0IG9mIHRoaXMK PiA+IHNlcmllcy4iCj4gCj4gSSB0aGluayB3aXRob3V0IGl0IGJlaW5nIG1hZGUgZXhwbGljaXQg dGhhdCBzb21ldGhpbmcgaXMgb3B0aW9uYWwsCj4gdGhlIGFzc3VtcHRpb24gc2hvdWxkIGJlIHRo YXQgaXQgaXNuJ3QuIEkuZS4gaW4gdGhlIGZpcnN0IGV4YW1wbGUKPiBJIGFncmVlIHdpdGggdGhl IGlkZWEgdG8gaGF2ZSBzb21ldGhpbmcgYWZ0ZXIgdGhlIGNvbW1hLCBidXQgaW4KPiB0aGUgc2Vj b25kIGV4YW1wbGUgSSB0aGluayB0aGUgZXh0cmEgd29yZGluZyBpcyBhIHdhc3RlIG9mIGVmZm9y dC4KCklmIHlvdSBhcmUgY29uY2VybmVkIGFib3V0IGJyZXZpdHksIHRoZW4gYSBiZXR0ZXIgZXhh bXBsZSB3b3VsZCBiZToKCiAgIlggc2hvdWxkIGFsc28gZG8gWSIgLT4gcmVxdWlyZWQKCiAgIkl0 IHdvdWxkIGJlIGdvb2QgaWYgWCBhbHNvIGRpZCBZLCBqdXN0IG9wdGlvbmFsLiIgLT4gb3B0aW9u YWwKCkkgZGlkbid0IHdhbnQgdG8gZ28gdGhhdCBmYXIgYnV0IHdlIGNvdWxkIGV2ZW4gaGF2ZSBh biBhY3R1YWxseSB0YWcsCmxpa2U6CgogICJYIHNob3VsZCBhbHNvIGRvIFkgW1JFUV0iCiAgIlgg c2hvdWxkIGFsc28gZG8gWSBbT1BUXSIKCgpPbiB0aGUgZGVmYXVsdCwgbGV0IG1lIHByZW1pc2Ug dGhhdCBhdCB0aGUgZW5kIG9mIHRoZSBkYXkgSSBhZ3JlZSB0aGF0CnRoZSBkZWZhdWx0IHNob3Vs ZCBiZSB0aGF0ICJpdCBpcyByZXF1aXJlZCIsIGJlY2F1c2UgaXQgaXMgcHJvYmFibHkgd2hhdApp dCBtYWtlcyBtb3JlIHNlbnNlLgoKVGhhdCBzYWlkLCB0aGUgaXNzdWUgaXMgdGhhdCBhcyBodW1h biBiZWluZ3Mgd2UgdGVuZCB0byBmb3JnZXQgYWJvdXQKdGhlc2UgdGhpbmdzLiBBcyBhbiBleGFt cGxlLCBJIGhhdmUgYmVlbiB0cnlpbmcgdG8gYXBwbHkgdGhpcyBzaW1wbGUKb3B0aW9uYWwvcmVw bHkgY29tbXVuaWNhdGlvbiBzdHlsZSB0byBteSBvd24gcmV2aWV3cyBpbiB0aGUgbGFzdCBmZXcK bW9udGhzIGFuZCBJIHN0aWxsIGZvcmdldCBvZnRlbiB0byBtYXJrIHRoZW0gYXBwcm9wcmlhdGVs eS4KCklmIHlvdSBmb3JnZXQgdG8gbWFyayBhbiBvcHRpb25hbCBzdWdnZXN0aW9uIGFzIHN1Y2gs IGl0IG1pZ2h0IGFubm95IHRoZQpjb250cmlidXRvciwgdGhpbmtpbmcgdGhhdCB5b3UgYXJlIHJl cXVpcmluZyBzb21ldGhpbmcgdGhhdCBzaGUgZG9lc24ndAp3YW50IHRvIGRvLiBJZiB3ZSBzd2l0 Y2hlZCB0aGUgZGVmYXVsdCB0byBvcHRpb25hbCwgdGhlbiB0aGUgcmlzayB3b3VsZApiZSB0aGF0 IHRoZSBjb250cmlidXRvciBjb3VsZCBpZ25vcmUgaXQsIHdoaWNoIGlzIHByb2JsZW1hdGljIGZv ciB0aGUKcmV2aWV3ZXIsIGFsdGhvdWdoIHdlIHJlY29tbWVuZCBpbiB0aGVzZSBkb2NzIGZvciB0 aGUgY29udHJpYnV0b3IgdG8gc2F5CndoYXQgdGhleSBpbnRlbmQgdG8gZG8gYWJvdXQgb3B0aW9u YWwgc3VnZ2VzdGlvbnMgZXhwbGljaXRseSwgYW5kIGFsc28KYXMgYSByZXZpZXdlciBJIGFsd2F5 cyBtYW51YWxseSBjaGVjayBpZiBhbGwgbXkgY29tbWVudHMgZnJvbSBhIHByZXZpb3VzCnZlcnNp b24gb2YgdGhlIHNlcmllcyB3ZXJlIGFkZHJlc3NlZCBhbnl3YXkuCgpJIGRvbid0IGhhdmUgYSBn b29kIHNvbHV0aW9uIHRvIHRoaXMsIEkgYW0ganVzdCBzaGFyaW5nIG15IGV4cGVyaWVuY2UuCgoK PiA+IEkgdGhpbmsgdGhlcmUgaXMgc29tZXRoaW5nIGVsc2Ugd2Ugc2hvdWxkIHNheSBvbiB0aGlz IHRvcGljLiBUaGVyZSBpcyBhCj4gPiBjYXRlZ29yeSBvZiB0aGluZ3Mgd2hpY2ggY291bGQgYmUg ZG9uZSBpbiBtdWx0aXBsZSB3YXlzIGFuZCBpdCBpcyBub3QKPiA+IG92ZXJ0bHkgb2J2aW91cyB3 aGljaCBvbmUgaXMgYmVzdC4gSXQgaXMgZG9uZSB0byB0aGUgbWFpbnRhaW5lciBhbmQgdGhlCj4g PiBhdXRob3IgcGVyc29uYWwgc3R5bGVzLiBJdCBpcyBlYXN5IHRvIGRpc2FncmVlIG9uIHRoYXQu Cj4gPiAKPiA+IEkgdGhpbmsgYSBnb29kIHJlY29tbWVuZGF0aW9uIHdvdWxkIGJlIGZvciB0aGUg Y29udHJpYnV0b3IgdG8gdHJ5IHRvCj4gPiBmb2xsb3cgdGhlIG1haW50YWluZXJzIHJlcXVlc3Rz LCBldmVuIGlmIHRoZXkgY291bGQgYmUgY29uc2lkZXJlZAo+ID4gInN0eWxlIiwgdHJ1c3Rpbmcg dGhlaXIgZXhwZXJpZW5jZSBvbiB0aGUgbWF0dGVyLiBBbmQgYSBnb29kCj4gPiByZWNvbW1lbmRh dGlvbiBmb3IgdGhlIG1haW50YWluZXIgd291bGQgYmUgdG8gdHJ5IHRvIGxldCB0aGUgY29udHJp YnV0b3IKPiA+IGhhdmUgZnJlZWRvbSBvZiBpbXBsZW1lbnRhdGlvbiBjaG9pY2Ugb24gdGhpbmdz IHRoYXQgZG9uJ3QgbWFrZSBhCj4gPiBzaWduaWZpY2FudCBkaWZmZXJlbmNlLgo+IAo+IEkgdGhp bmsgd2UgdHJ5IHRvLCBidXQgSSBhbHNvIHRoaW5rIHdlIHN1ZmZlciBmcm9tIHRvbyBsaXR0bGUK PiBjbGVhciBkb2N1bWVudGF0aW9uIG9uIGUuZy4gc3R5bGUgYXNwZWN0cy4gQXR0ZW1wdHMgb24g bXkgcGFydAo+IHRvIGFkZHJlc3MgdGhpcyBoYXZlIG1vc3RseSAobm90IGVudGlyZWx5KSBsZWFk IG5vLXdoZXJlIChsYWNrIG9mCj4gZmVlZGJhY2sgb24gcHJvcG9zZWQgcGF0Y2hlcyB0byAuL0NP RElOR19TVFlMRSkuIFNvIGZvciB0aGUgdGltZQo+IGJlaW5nIHRoZXJlIGFyZSAobWFueSkgYXNw ZWN0cyB3aGVyZSB3ZSBoYXZlIGRlLWZhY3RvIGV4cGVjdGF0aW9ucwo+IHRoYXQgYXJlbid0IHdy aXR0ZW4gZG93biBhbnl3aGVyZSwgd2l0aCB0aGUgcmVzdWx0IG9mIChpbiBhIHN1YnNldAo+IG9m IGNhc2VzKSBkaXNhZ3JlZW1lbnQgb24gd2hhdCB0aGUgcGVyY2VpdmVkIGRlLWZhY3RvIHN0YW5k YXJkCj4gYWN0dWFsbHkgaXMuCgpJIHJlY29nbml6ZSB0aGF0IGl0IGNvdWxkIGJlIGNoYWxsZW5n aW5nIGZpbmRpbmcgYSBjb25zZW5zdXMgdG8gdXBkYXRlCkNPRElOR19TVFlMRSBidXQgaXQgbWln aHQgYmUgd29ydGggZG9pbmcgdG8gcmVkdWNlIGZyaWN0aW9ucyB3aXRoIGJvdGgKY29udHJpYnV0 b3JzIGFuZCBvdGhlciByZXZpZXdlcnMuCgpCdXQgdG8gYmUgY2xlYXIsIEkgd2FzIGFsc28gcmVm ZXJyaW5nIHRvIHRoaW5ncyB0aGF0IG1pZ2h0IGJlIGFjdHVhbGx5CmhhcmQgdG8gYWRkIHRvIENP RElOR19TVFlMRSwgc3VjaCBhcyBtYWNybyB2cy4gc3RhdGljIGlubGluZXMsIHdoZW4gdG8Kc3Bs aXQgYSBzaW5nbGUgZnVuY3Rpb24gaW50byBtdWx0aXBsZSBzbWFsbGVyIGZ1bmN0aW9ucywgZXRj LgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Kd2luLXB2 LWRldmVsIG1haWxpbmcgbGlzdAp3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0 cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3dpbi1wdi1kZXZlbA== From win-pv-devel-bounces@lists.xenproject.org Fri Nov 29 00:00:28 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 29 Nov 2019 00:00:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaThz-0006y6-W5; Fri, 29 Nov 2019 00:00:27 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaThy-0006y1-Mq for win-pv-devel@lists.xenproject.org; Fri, 29 Nov 2019 00:00:26 +0000 X-Inumbo-ID: 3817d9ca-123b-11ea-a3da-12813bfff9fa Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3817d9ca-123b-11ea-a3da-12813bfff9fa; Fri, 29 Nov 2019 00:00:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1574985615; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=Ut1U3DFJ7ARr1RcJca9q+W7bCxJ48hIhQRyfFTlnaFA=; b=S4sZsS23tBx/fH7G0RnuD+vTRZ9SjRBgPAd0EDHAVjDx8ab25FcWgpGU +JCbYhbxQFaiEUnt9aCxbsON+sDYIBKj+B8P/Y6vMXT/JDwdAA4wBH8a3 OQHYpf44IUtb4jJe2LsXkdiOs3pcvledO1f7scDlYY7g1/DFDSZASiee6 s=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=lars.kurth@citrix.com; spf=Pass smtp.mailfrom=lars.kurth@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of lars.kurth@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="lars.kurth@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of lars.kurth@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="lars.kurth@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: Lg8Kjm/mvjdh0wQNa9UShx3olTCd9W+BaOKN+czMQDQOf3fRUWHHCarrE++XL5Xhxidq5UwCGX 7kdooUDlZSKsr4zLheqnUQsU9Blwgg9YiU6ucXWtS3p+BfoNFKqoHNiCSTorji0w8Rnsbu4FvF j0DDeuUsLfxbeLuXBz+B4S/N4YQbz4zk5mIDbIgsi5MFBjCe3iMuDAu7LXpOHhepBtVB//rq6T DfvAzNU/LrecHtKOGD/8G8fXRwKQQAPymTjtfT9wDbDBTAVw6eFFzaJjNXjMcxmG86OAk9ZkQY dJo= X-SBRS: 2.7 X-MesageID: 8971799 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.69,255,1571716800"; d="scan'208";a="8971799" From: Lars Kurth To: Stefano Stabellini , Lars Kurth Thread-Topic: [PATCH v2 5/6] Add guide on Communication Best Practice Thread-Index: AQHVdKIoBNlHjnrbLUK7o4oIKuieK6egE6kAgAEdpgA= Date: Fri, 29 Nov 2019 00:00:08 +0000 Message-ID: <8DAF896F-6BFF-4126-84C7-6C0161FBE3EF@citrix.com> References: <749f082bdb996ba7c7362847b22030882dc2903f.1569525222.git.lars.kurth@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/10.10.10.191111 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted Content-ID: MIME-Version: 1.0 Subject: Re: [win-pv-devel] [PATCH v2 5/6] Add guide on Communication Best Practice X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-api@lists.xenproject.org" , "minios-devel@lists.xenproject.org" , "committers@xenproject.org" , "mirageos-devel@lists.xenproject.org" , "xen-devel@lists.xenproject.org" , "win-pv-devel@lists.xenproject.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" DQoNCu+7v09uIDI3LzExLzIwMTksIDE4OjU3LCAiU3RlZmFubyBTdGFiZWxsaW5pIiA8c3N0YWJl bGxpbmlAa2VybmVsLm9yZz4gd3JvdGU6DQoNCiAgICBPbiBUaHUsIDI2IFNlcCAyMDE5LCBMYXJz IEt1cnRoIHdyb3RlOg0KICAgID4gRnJvbTogTGFycyBLdXJ0aCA8bGFycy5rdXJ0aEBjaXRyaXgu Y29tPg0KICAgID4gDQogICAgPiBUaGlzIGd1aWRlIGNvdmVycyB0aGUgYnVsayBvbiBCZXN0IFBy YWN0aWNlIHJlbGF0ZWQgdG8gY29kZSByZXZpZXcNCiAgICA+IEl0IHByaW1hcmlseSBmb2N1c3Nl cyBvbiBjb2RlIHJldmlldyBpbnRlcmFjdGlvbnMNCiAgICA+IEl0IGFsc28gY292ZXJzIGhvdyB0 byBkZWFsIHdpdGggTWlzdW5kZXJzdGFuZGluZ3MgYW5kIEN1bHR1cmFsDQogICAgPiBEaWZmZXJl bmNlcw0KICAgID4gDQogICAgPiBTaWduZWQtb2ZmLWJ5OiBMYXJzIEt1cnRoIDxsYXJzLmt1cnRo QGNpdHJpeC5jb20+DQogICAgPiAtLS0NCiAgICA+IENjOiBtaW5pb3MtZGV2ZWxAbGlzdHMueGVu cHJvamVjdC5vcmcNCiAgICA+IENjOiB4ZW4tYXBpQGxpc3RzLnhlbnByb2plY3Qub3JnDQogICAg PiBDYzogd2luLXB2LWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQogICAgPiBDYzogbWlyYWdl b3MtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcNCiAgICA+IENjOiBjb21taXR0ZXJzQHhlbnBy b2plY3Qub3JnDQogICAgPiAtLS0NCiAgICA+ICBjb21tdW5pY2F0aW9uLXByYWN0aWNlLm1kIHwg NDEwICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysNCiAgICA+ ICAxIGZpbGUgY2hhbmdlZCwgNDEwIGluc2VydGlvbnMoKykNCiAgICA+ICBjcmVhdGUgbW9kZSAx MDA2NDQgY29tbXVuaWNhdGlvbi1wcmFjdGljZS5tZA0KICAgID4gDQogICAgPiBkaWZmIC0tZ2l0 IGEvY29tbXVuaWNhdGlvbi1wcmFjdGljZS5tZCBiL2NvbW11bmljYXRpb24tcHJhY3RpY2UubWQN CiAgICA+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0DQogICAgPiBpbmRleCAwMDAwMDAwLi5kYjlhNWVm DQogICAgPiAtLS0gL2Rldi9udWxsDQogICAgPiArKysgYi9jb21tdW5pY2F0aW9uLXByYWN0aWNl Lm1kDQogICAgPiBAQCAtMCwwICsxLDQxMCBAQA0KICAgID4gKyMgQ29tbXVuaWNhdGlvbiBCZXN0 IFByYWN0aWNlDQogICAgPiArDQogICAgPiArVGhpcyBndWlkZSBwcm92aWRlcyBjb21tdW5pY2F0 aW9uIEJlc3QgUHJhY3RpY2UgdGhhdCBoZWxwcyB5b3UgaW4NCiAgICA+ICsqIFVzaW5nIHdlbGNv bWluZyBhbmQgaW5jbHVzaXZlIGxhbmd1YWdlDQogICAgPiArKiBLZWVwaW5nIGRpc2N1c3Npb25z IHRlY2huaWNhbCBhbmQgYWN0aW9uYWJsZQ0KICAgID4gKyogQmVpbmcgcmVzcGVjdGZ1bCBvZiBk aWZmZXJpbmcgdmlld3BvaW50cyBhbmQgZXhwZXJpZW5jZXMNCiAgICA+ICsqIEJlaW5nIGF3YXJl IG9mIHlvdXIgb3duIGFuZCBjb3VudGVycGFydOKAmXMgY29tbXVuaWNhdGlvbiBzdHlsZSBhbmQg Y3VsdHVyZQ0KICAgID4gKyogU2hvdyBlbXBhdGh5IHRvd2FyZHMgb3RoZXIgY29tbXVuaXR5IG1l bWJlcnMNCiAgICA+ICsNCiAgICA+ICsjIyBDb2RlIHJldmlld3MgZm9yICoqcmV2aWV3ZXJzKiog YW5kICoqcGF0Y2ggYXV0aG9ycyoqDQogICAgPiArDQogICAgPiArQmVmb3JlIGVtYmFya2luZyBv biBhIGNvZGUgcmV2aWV3LCBpdCBpcyBpbXBvcnRhbnQgdG8gcmVtZW1iZXIgdGhhdA0KICAgID4g KyogQSBwb29ybHkgZXhlY3V0ZWQgY29kZSByZXZpZXcgY2FuIGh1cnQgdGhlIGNvbnRyaWJ1dG9y cyBmZWVsaW5nLCBldmVuIHdoZW4gYSByZXZpZXdlcg0KICAgID4gKyAgZGlkIG5vdCBpbnRlbmQg dG8gZG8gc28uIEZlZWxpbmcgZGVmZW5zaXZlIGlzIGEgbm9ybWFsIHJlYWN0aW9uIHRvIGEgY3Jp dGlxdWUgb3IgZmVlZGJhY2suDQogICAgPiArICBBIHJldmlld2VyIHNob3VsZCBiZSBhd2FyZSBv ZiBob3cgdGhlIHBpdGNoLCB0b25lLCBvciBzZW50aW1lbnQgb2YgdGhlaXIgY29tbWVudHMNCiAg ICA+ICsgIGNvdWxkIGJlIGludGVycHJldGVkIGJ5IHRoZSBjb250cmlidXRvci4gVGhlIHNhbWUg YXBwbGllcyB0byByZXNwb25zZXMgb2YgYW4gYXV0aG9yDQogICAgPiArICB0byB0aGUgcmV2aWV3 ZXIuDQogICAgPiArKiBXaGVuIHJldmlld2luZyBzb21lb25lJ3MgY29kZSwgeW91IGFyZSB1bHRp bWF0ZWx5IGxvb2tpbmcgZm9yIGlzc3Vlcy4gQSBnb29kIGNvZGUNCiAgICA+ICsgIHJldmlld2Vy IGlzIGFibGUgdG8gbWVudGFsbHkgc2VwYXJhdGUgZmluZGluZyBpc3N1ZXMgZnJvbSBhcnRpY3Vs YXRpbmcgY29kZSByZXZpZXcNCiAgICA+ICsgIGNvbW1lbnRzIGluIGEgY29uc3RydWN0aXZlIGFu ZCBwb3NpdGl2ZSBtYW5uZXI6IGRlcGVuZGluZyBvbiB5b3VyIHBlcnNvbmFsaXR5IHRoaXMNCiAg ICA+ICsgIGNhbiBiZSAqKmRpZmZpY3VsdCoqIGFuZCB5b3UgbWF5IG5lZWQgdG8gZGV2ZWxvcCBh IHRlY2huaXF1ZSB0aGF0IHdvcmtzIGZvciB5b3UuDQogICAgPiArKiBBcyBzb2Z0d2FyZSBlbmdp bmVlcnMgd2UgbGlrZSB0byBiZSBwcm91ZCBvZiB0aGUgc29sdXRpb25zIHdlIGNhbWUgdXAgd2l0 aC4gVGhpcyBjYW4NCiAgICA+ICsgIG1ha2UgaXQgZWFzeSB0byB0YWtlIGFub3RoZXIgcGVvcGxl 4oCZcyBjcml0aWNpc20gcGVyc29uYWxseS4gQWx3YXlzIHJlbWVtYmVyIHRoYXQgaXQgaXMNCiAg ICA+ICsgIHRoZSBjb2RlIHRoYXQgaXMgYmVpbmcgcmV2aWV3ZWQsIG5vdCB5b3UgYXMgYSBwZXJz b24uDQogICAgPiArKiBXaGVuIHlvdSByZWNlaXZlIGNvZGUgcmV2aWV3IGZlZWRiYWNrLCBwbGVh c2UgYmUgYXdhcmUgdGhhdCB3ZSBoYXZlIHJldmlld2Vycw0KICAgID4gKyAgZnJvbSBkaWZmZXJl bnQgYmFja2dyb3VuZHMsIGNvbW11bmljYXRpb24gc3R5bGVzIGFuZCBjdWx0dXJlcy4gQWx0aG91 Z2ggd2UgYWxsIHRyeWluZw0KICAgID4gKyAgdG8gY3JlYXRlIGEgcHJvZHVjdGl2ZSwgd2VsY29t aW5nIGFuZCBhZ2lsZSBlbnZpcm9ubWVudCwgd2UgZG8gbm90IGFsd2F5cyBzdWNjZWVkLg0KICAg ID4gKw0KICAgID4gKyMjIyBFeHByZXNzIGFwcHJlY2lhdGlvbg0KICAgID4gK0FzIHRoZSBuYXR1 cmUgb2YgY29kZSByZXZpZXcgdG8gZmluZCBidWdzIGFuZCBwb3NzaWJsZSBpc3N1ZXMsIGl0IGlz IHZlcnkgZWFzeSBmb3INCiAgICA+ICtyZXZpZXdlcnMgdG8gZ2V0IGludG8gYSBtb2RlIG9mIG9w ZXJhdGlvbiB3aGVyZSB0aGUgcGF0Y2ggcmV2aWV3IGVuZHMgdXAgYmVpbmcgYSBsaXN0DQogICAg PiArb2YgaXNzdWVzLCBub3QgbWVudGlvbmluZyB3aGF0IGlzIHJpZ2h0IGFuZCB3ZWxsIGRvbmUu IFRoaXMgY2FuIGxlYWQgdG8gdGhlIGNvZGUNCiAgICA+ICtzdWJtaXR0ZXIgaW50ZXJwcmV0aW5n IHlvdXIgZmVlZGJhY2sgaW4gYSBuZWdhdGl2ZSB3YXkuDQogICAgPiArDQogICAgPiArVGhlIG9w ZW5pbmcgb2YgYSBjb2RlIHJldmlldyBwcm92aWRlcyBhbiBvcHBvcnR1bml0eSB0byBhZGRyZXNz IHRoaXMgYW5kIGFsc28gc2V0cyB0aGUNCiAgICA+ICt0b25lIGZvciB0aGUgcmVzdCBvZiB0aGUg Y29kZSByZXZpZXcuIFN0YXJ0aW5nICoqZXZlcnkqKiByZXZpZXcgb24gYSBwb3NpdGl2ZSBub3Rl LCBoZWxwcw0KICAgID4gK3NldCB0aGUgdG9uZSBmb3IgdGhlIHJlc3Qgb2YgdGhlIHJldmlldy4N CiAgICA+ICsNCiAgICA+ICtGb3IgYW4gaW5pdGlhbCBwYXRjaCwgeW91IGNhbiB1c2UgcGhyYXNl cyBzdWNoIGFzDQogICAgPiArPiBUaGFua3MgZm9yIHRoZSBwYXRjaA0KICAgID4gKz4gVGhhbmtz IGZvciBkb2luZyB0aGlzDQogICAgPiArDQogICAgPiArRm9yIGZ1cnRoZXIgcmV2aXNpb25zIHdp dGhpbiBhIHJldmlldywgcGhyYXNlcyBzdWNoIGFzDQogICAgPiArPiBUaGFuayB5b3UgZm9yIGFk ZHJlc3NpbmcgdGhlIGxhc3Qgc2V0IG9mIGNoYW5nZXMNCiAgICA+ICsNCiAgICA+ICtJZiB5b3Ug YmVsaWV2ZSB0aGUgY29kZSB3YXMgZ29vZCwgaXQgaXMgZ29vZCBwcmFjdGljZSB0byBoaWdobGln aHQgdGhpcyBieSB1c2luZyBwaHJhc2VzDQogICAgPiArc3VjaCBhcw0KICAgID4gKz4gTG9va3Mg Z29vZCwganVzdCBhIGZldyBjb21tZW50cw0KICAgID4gKz4gVGhlIGNoYW5nZXMgeW91IGhhdmUg bWFkZSBzaW5jZSB0aGUgbGFzdCB2ZXJzaW9uIGxvb2sgZ29vZA0KICAgID4gKw0KICAgID4gK0lm IHlvdSB0aGluayB0aGVyZSB3ZXJlIGlzc3VlcyB0b28gbWFueSB3aXRoIHRoZSBjb2RlIHRvIHVz ZSBvbmUgb2YgdGhlIHBocmFzZXMsDQogICAgPiAreW91IGNhbiBzdGlsbCBzdGFydCBvbiBhIHBv c2l0aXZlIG5vdGUsIGJ5IGZvciBleGFtcGxlIHNheWluZw0KICAgID4gKz4gSSB0aGluayB0aGlz IGlzIGEgZ29vZCBjaGFuZ2UNCiAgICA+ICs+IEkgdGhpbmsgdGhpcyBpcyBhIGdvb2QgZmVhdHVy ZSBwcm9wb3NhbA0KICAgID4gKw0KICAgID4gK0l0IGlzIGFsc28gZW50aXJlbHkgZmluZSB0byBo aWdobGlnaHQgc3BlY2lmaWMgY2hhbmdlcyBhcyBnb29kLiBUaGUgYmVzdCBwbGFjZSB0bw0KICAg ID4gK2RvIHRoaXMsIGlzIGF0IHRvcCBvZiBhIHBhdGNoLCBhcyBhZGRyZXNzaW5nIGNvZGUgcmV2 aWV3IGNvbW1lbnRzIHR5cGljYWxseSByZXF1aXJlcw0KICAgICAgICAgICAgICAgICAgICAgXiB0 aGUgdG9wDQogICAgDQogICAgDQogICAgPiArYSBjb250cmlidXRvciB0byBnbyB0aHJvdWdoIHRo ZSBsaXN0IG9mIHRoaW5ncyB0byBhZGRyZXNzIGFuZCBhbiBpbi1saW5lZCBwb3NpdGl2ZQ0KICAg ID4gK2NvbW1lbnQgaXMgbGlrZWx5IHRvIGJyZWFrIHRoYXQgd29ya2Zsb3cuDQogICAgPiArDQog ICAgPiArWW91IHNob3VsZCBhbHNvIGNvbnNpZGVyLCB0aGF0IGlmIHlvdSByZXZpZXcgYSBwYXRj aCBvZiBhbiBleHBlcmllbmNlZA0KICAgID4gK2NvbnRyaWJ1dG9yIHBocmFzZXMgc3VjaCBhcyAq VGhhbmtzIGZvciB0aGUgcGF0Y2gqIGNvdWxkIGNvbWUgYWNyb3NzIGFzDQogICAgPiArcGF0cm9u aXppbmcsIHdoaWxlIHVzaW5nICpUaGFua3MgZm9yIGRvaW5nIHRoaXMqIGlzIGxlc3MgbGlrZWx5 IHRvIGJlIGludGVycHJldGVkDQogICAgPiArYXMgc3VjaC4NCiAgICA+ICsNCiAgICA+ICtBcHBy ZWNpYXRpb24gc2hvdWxkIGFsc28gYmUgZXhwcmVzc2VkIGJ5IHBhdGNoIGF1dGhvcnMgd2hlbiBh c2tpbmcgZm9yIGNsYXJpZmljYXRpb25zDQogICAgPiArdG8gYSByZXZpZXcgb3IgcmVzcG9uZGlu ZyB0byBxdWVzdGlvbnMuIEEgc2ltcGxlDQogICAgPiArPiBUaGFuayB5b3UgZm9yIHlvdXIgZmVl ZGJhY2sNCiAgICA+ICs+IFRoYW5rIHlvdSBmb3IgeW91ciByZXBseQ0KICAgID4gKz4gVGhhbmsg eW91IFhYWCENCiAgICA+ICsNCiAgICA+ICtpcyBub3JtYWxseSBzdWZmaWNpZW50Lg0KICAgID4g Kw0KICAgID4gKyMjIyBBdm9pZCBvcGluaW9uOiBzdGljayB0byB0aGUgZmFjdHMNCiAgICA+ICtU aGUgd2F5IGhvdyBhIHJldmlld2VyIGV4cHJlc3NlcyBmZWVkYmFjaywgaGFzIGEgYmlnIGltcGFj dCBvbiBob3cgdGhlIGF1dGhvcg0KICAgID4gK3BlcmNlaXZlcyB0aGUgZmVlZGJhY2suIEtleSB0 byB0aGlzIGlzIHdoYXQgd2UgY2FsbCAqKnN0aWNrIHRvIHRoZSBmYWN0cyoqLiAgVGhlIHNhbWUg aXMNCiAgICA+ICt0cnVlIHdoZW4gYSBwYXRjaCBhdXRob3IgaXMgcmVzcG9uZGluZyB0byBhIGNv bW1lbnQgZnJvbSBhIHJldmlld2VyLg0KICAgID4gKw0KICAgID4gK09uZSBvZiBvdXIgbWFpbnRh aW5lcnMgaGFzIGJlZW4gc3R1ZHlpbmcgTWFuZGFyaW4gZm9yIHNldmVyYWwgeWVhcnMgYW5kIGhh cyBjb21lDQogICAgPiArYWNyb3NzIHRoZSBtb3N0IHN0cm9uZ2x5LXdvcmRlZCBkaWN0aW9uYXJ5 IGVudHJ5DQogICAgPiArW2hlIGhhcyBldmVyIHNlZW5dKGh0dHBzOi8veW91dHUuYmUvZWhadkJt ckxSd2c/dD04MzQpLiBUaGlzIGV4YW1wbGUNCiAgICA+ICtpbGx1c3RyYXRlcyB0aGUgcHJvYmxl bSBvZiB1c2luZyBvcGluaW9uIGluIGNvZGUgcmV2aWV3cyB2cy4gdXNpbmcgZmFjdHMgZXh0cmVt ZWx5IHdlbGwuDQogICAgPiArDQogICAgPiArPiDoo7nohJogKGd1bzMgamlhbzMpOiBmb290LWJp bmRpbmcgKGEgdmlsZSBmZXVkYWwgcHJhY3RpY2Ugd2hpY2ggY3JpcHBsZWQgd29tZW4gYm90aA0K ICAgID4gKz4gcGh5c2ljYWxseSBhbmQgc3Bpcml0dWFsbHkpDQogICAgPiArDQogICAgPiArVGhp cyBpcyBub3Qgc29tZXRoaW5nIG9uZSBpcyB1c2VkIHRvIGhlYXJpbmcgZnJvbSBkaWN0aW9uYXJ5 IGVudHJpZXMuIE9uY2UgeW91DQogICAgPiAraW52ZXN0aWdhdGUgdGhlIHByYWN0aWNlIGZvb3Qt YmluZGluZywgaXQgaXMgaGFyZCB0byBkaXNhZ3JlZSB3aXRoIHRoZSBkaWN0aW9uYXJ0IGVudHJ5 Lg0KICAgID4gK0hvd2V2ZXIsIHRoZSBzdGF0ZW1lbnQgZG9lcyBub3QgY29udGFpbiBtdWNoIGlu Zm9ybWF0aW9uLiBJZiB5b3UgcmVhZCBpdCB3aXRob3V0DQogICAgPiAra25vd2luZyB3aGF0IGZv b3QtYmluZGluZyBpcywgaXQgaXMgaGFyZCB0byBiZSBjb252aW5jZWQgYnkgdGhpcyBzdGF0ZW1l bnQuIFRoZSBtYWluDQogICAgPiArdGFrZS1hd2F5IGlzIHRoYXQgdGhlIGF1dGhvciBvZiB0aGUg ZGljdGlvbmFyeSBlbnRyeSBoYWQgc3Ryb25nIG9waW5pb25zIGFib3V0IHRoaXMgdG9waWMuDQog ICAgPiArSXQgZG9lcyBub3QgdGVsbCB5b3UsIHdoeSB5b3Ugc2hvdWxkIGhhdmUgdGhlIHNhbWUg b3Bpbmlvbi4NCiAgICAgICAgICAgICAgICAgICAgICAgICAgIF4gcmVtb3ZlICwNCiAgICANCiAg ICA+ICsNCiAgICA+ICtDb21wYXJlIHRoaXMgdG8gdGhlIChXaWtpcGVkaWEgZW50cnkpW2h0dHBz Oi8vZW4ud2lraXBlZGlhLm9yZy93aWtpL0Zvb3RfYmluZGluZ10NCiAgICA+ICsNCiAgICA+ICs+ IEZvb3QgYmluZGluZyB3YXMgdGhlIGN1c3RvbSBvZiBhcHBseWluZyB0aWdodCBiaW5kaW5nIHRv IHRoZSBmZWV0IG9mIHlvdW5nIGdpcmxzIHRvDQogICAgPiArPiBtb2RpZnkgdGhlIHNoYXBlIGFu ZCBzaXplIG9mIHRoZWlyIGZlZXQuIC4uLiBmb290IGJpbmRpbmcgd2FzIGEgcGFpbmZ1bCBwcmFj dGljZSBhbmQNCiAgICA+ICs+IHNpZ25pZmljYW50bHkgbGltaXRlZCB0aGUgbW9iaWxpdHkgb2Yg d29tZW4sIHJlc3VsdGluZyBpbiBsaWZlbG9uZyBkaXNhYmlsaXRpZXMgZm9yIG1vc3Qgb2YNCiAg ICA+ICs+IGl0cyBzdWJqZWN0cy4gLi4uIEJpbmRpbmcgdXN1YWxseSBzdGFydGVkIGR1cmluZyB0 aGUgd2ludGVyIG1vbnRocyBzaW5jZSB0aGUgZmVldCB3ZXJlDQogICAgPiArPiBtb3JlIGxpa2Vs eSB0byBiZSBudW1iLCBhbmQgdGhlcmVmb3JlIHRoZSBwYWluIHdvdWxkIG5vdCBiZSBhcyBleHRy ZW1lLiDigKZUaGUgdG9lcyBvbg0KICAgID4gKz4gZWFjaCBmb290IHdlcmUgY3VybGVkIHVuZGVy LCB0aGVuIHByZXNzZWQgd2l0aCBncmVhdCBmb3JjZSBkb3dud2FyZHMgYW5kIHNxdWVlemVkDQog ICAgPiArPiBpbnRvIHRoZSBzb2xlIG9mIHRoZSBmb290IHVudGlsIHRoZSB0b2VzIGJyb2tl4oCm DQogICAgPiArDQogICAgPiArV2l0aG91dCBnb2luZyBpbnRvIHRoZSBkZXRhaWxzIG9mIGZvb3Qt YmluZGluZywgaXQgaXMgbm90aWNlYWJsZSB0aGF0IG5vbmUgb2Ygd2hhdCBpcyB3cml0dGVuDQog ICAgPiArYWJvdmUgdXNlcyBvcGluaW9uIHdoaWNoIGNvdWxkIGJlIGludGVycHJldGVkIGFzIGlu ZmxhbW1hdG9yeSBsYW5ndWFnZS4gSXQgaXMgYSBsaXN0IG9mDQogICAgPiArc2ltcGxlIGZhY3Rz IHRoYXQgYXJlIGxhaWQgb3V0IGluIGEgd2F5IHRoYXQgbWFrZSBpdCBvYnZpb3VzIHdoYXQgdGhl IGNvcnJlY3QgY29uY2x1c2lvbg0KICAgID4gK2lzLg0KICAgID4gKw0KICAgID4gK0JlY2F1c2Ug dGhlIFdpa2lwZWRpYSBlbnRyeSBpcyBlbnRpcmVseSBmYWN0IGJhc2VkIGl0IGlzIG1vcmUgcG93 ZXJmdWwgYW5kIHBlcnN1YXNpdmUNCiAgICA+ICt0aGVuIHRoZSBkaWN0aW9uYXJ5IGVudHJ5LiBU aGUgc2FtZSBhcHBsaWVzIHRvIGNvZGUgcmV2aWV3cy4NCiAgICA+ICsNCiAgICA+ICtNYWtpbmcg c3RhdGVtZW50cyBpbiBjb2RlIHJldmlld3Mgc3VjaCBhcw0KICAgID4gKz4gWW91ciBjb2RlIGlz IGdhcmJhZ2UNCiAgICA+ICs+IFRoaXMgaWRlYSBpcyBzdHVwaWQNCiAgICA+ICsNCiAgICA+ICti ZXNpZGVzIGJlaW5nIGFuIG9waW5pb24gaXMgcnVkZSBhbmQgY291bnRlciBwcm9kdWN0aXZlDQog ICAgPiArKiBJdCB3aWxsIG1ha2UgdGhlIHBhdGNoIGF1dGhvciBhbmdyeTogaW5zdGVhZCBvZiBm aW5kaW5nIGEgc29sdXRpb24gdG8gdGhlIHByb2JsZW0gdGhlDQogICAgPiArICBhdXRob3Igd2ls bCBzcGVuZCB0aW1lIGFuZCBtZW50YWwgZW5lcmd5IHdyZXN0bGluZyB3aXRoIHRoZWlyIGZlZWxp bmdzDQogICAgPiArKiBJdCBkb2VzIG5vdCBjb250YWluIGFueSBpbmZvcm1hdGlvbg0KICAgID4g KyogRmFjdHMgYXJlIGJvdGggbW9yZSBwb3dlcmZ1bCBhbmQgbW9yZSBwZXJzdWFzaXZlDQogICAg PiArDQogICAgPiArQ29uc2lkZXIgdGhlIGZvbGxvd2luZyB0d28gcGllY2VzIG9mIGZlZWRiYWNr IG9uIGEgcGllY2Ugb2YgY29kZQ0KICAgID4gKz4gVGhpcyBwaWVjZSBvZiBjb2RlIGlzIGNvbmZ1 c2luZw0KICAgID4gKz4gSXQgdG9vayBtZSBhIGxvbmcgdGltZSB0byDvrIFndXJlIG91dCB3aGF0 IHdhcyBnb2luZyBvbiBoZXJlDQogICAgPiArDQogICAgPiArVGhlIGZpcnN0IGV4YW1wbGUgZXhw cmVzc2VzIGFuIG9waW5pb24sIHdoZXJlYXMgdGhlIHNlY29uZCByZS1waHJhc2VzIHRoZSBzdGF0 ZW1lbnQNCiAgICA+ICtpbiB0ZXJtcyBvZiB3aGF0IHlvdSBleHBlcmllbmNlZCwgd2hpY2ggaXMg YSBmYWN0Lg0KICAgID4gKw0KICAgID4gK090aGVyIGV4YW1wbGVzOg0KICAgID4gKz4gQkFEOiBU aGlzIGlzIGZyYWdpbGUNCiAgICA+ICs+IFNPTUVXSEFUIEJFVFRFUjogVGhpcyBzZWVtcyBmcmFn aWxlIHRvIG1lDQogICAgPiArPiBCRVNUOiBJZiBYIGhhcHBlbnMsIFkgd2lsbCBoYXBwZW4uDQog ICAgPiArDQogICAgPiArQSBjZXJ0YWluIHBpZWNlIG9mIGNvZGUgY2FuIGJlIHdyaXR0ZW4gaW4g bWFueSBkaWZmZXJlbnQgd2F5czogdGhpcyBjYW4gbGVhZCB0bw0KICAgID4gK2Rpc2FncmVlbWVu dHMgb24gdGhlIGJlc3QgYXJjaGl0ZWN0dXJlLCBkZXNpZ24gb3IgY29kaW5nIHBhdHRlcm4uIEFz IGFscmVhZHkgcG9pbnRlZCBvdXQNCiAgICA+ICtpbiB0aGlzIHNlY3Rpb246IGF2b2lkIGZlZWRi YWNrIHRoYXQgaXMgb3Bpbmlvbi1iYXNlZCBhbmQgdGh1cyBkb2VzIG5vdCBhZGQgYW55IHZhbHVl Lg0KICAgID4gK0JhY2sgeW91ciBjcml0aWNpc20gKG9yIGlkZWEgb24gaG93IHRvIHNvbHZlIGEg cHJvYmxlbSkgd2l0aCBhIHNlbnNpYmxlIHJhdGlvbmFsZS4NCiAgICA+ICsNCiAgICA+ICsjIyMg UmV2aWV3IHRoZSBjb2RlLCBub3QgdGhlIHBlcnNvbg0KICAgID4gK1dpdGhvdXQgcmVhbGl6aW5n IGl0LCBpdCBpcyBlYXN5IHRvIG92ZXJsb29rIHRoZSBkaWZmZXJlbmNlIGJldHdlZW4gaW5zaWdo dGZ1bCBjcml0aXF1ZSBvZg0KICAgID4gK2NvZGUgYW5kIHBlcnNvbmFsIGNyaXRpY2lzbS4gTGV0 J3MgbG9vayBhdCBhIHRoZW9yZXRpY2FsIGZ1bmN0aW9uIHdoZXJlIHRoZXJlIGlzIGFuDQogICAg PiArb3Bwb3J0dW5pdHkgdG8gcmV0dXJuIG91dCBvZiB0aGUgZnVuY3Rpb24gZWFybHkuIEluIHRo aXMgY2FzZSwgeW91IGNvdWxkIHNheQ0KICAgID4gKw0KICAgID4gKz4gWW91IHNob3VsZCByZXR1 cm4gZnJvbSB0aGlzIGZ1bmN0aW9uIGVhcmx5LCBiZWNhdXNlIG9mIFhYWA0KICAgID4gKw0KICAg ID4gK09uIGl0cyBvd24sIHRoZXJlIGlzIG5vdGhpbmcgd3Jvbmcgd2l0aCB0aGlzIHN0YXRlbWVu dC4gSG93ZXZlciwgYSBjb2RlIHJldmlldyBpcyBtYWRlDQogICAgPiArdXAgb2YgbXVsdGlwbGUg Y29tbWVudHMgYW5kIHVzaW5nICoqWW91IHNob3VsZCoqIGNvbnNpc3RlbnRseSBjYW4gc3RhcnQg dG8gZmVlbCBuZWdhdGl2ZQ0KICAgID4gK2FuZCBjYW4gYmUgbWlzLWludGVycHJldGVkIGFzIGEg cGVyc29uYWwgYXR0YWNrLiBVc2luZyBzb21ldGhpbmcgbGlrZSBhdm9pZHMgdGhpcyBpc3N1ZToN CiAgICA+ICsNCiAgICA+ICs+IFJldHVybmluZyBmcm9tIHRoaXMgZnVuY3Rpb24gZWFybHkgaXMg YmV0dGVyLCBiZWNhdXNlIG9mIFhYWA0KICAgID4gKw0KICAgID4gK1dpdGhvdXQgcGVyc29uYWwg cmVmZXJlbmNlLCBhIGNvZGUgcmV2aWV3IHdpbGwgY29tbXVuaWNhdGUgdGhlIHByb2JsZW0sIGlk ZWEgb3IgaXNzdWUNCiAgICA+ICt3aXRob3V0IHJpc2tpbmcgbWlzLWludGVycHJldGF0aW9uLg0K ICAgID4gKw0KICAgID4gKyMjIyBWZXJib3NlIHZzLiB0ZXJzZQ0KICAgID4gK0R1ZSB0byB0aGUg dGltZSBpdCB0YWtlcyB0byByZXZpZXcgYW5kIGNvbXBvc2UgY29kZSByZXZpZXdlciwgcmV2aWV3 ZXJzIG9mdGVuIGFkb3B0IGENCiAgICA+ICt0ZXJzZSBzdHlsZS4gSXQgaXMgbm90IHVudXN1YWwg dG8gc2VlIHJldmlldyBjb21tZW50cyBzdWNoIGFzDQogICAgPiArPiB0eXBvDQogICAgPiArPiBz L3Jlc2lvbnMvcmVnaW9ucy8NCiAgICA+ICs+IGNvZGluZyBzdHlsZQ0KICAgID4gKz4gY29kaW5n IHN0eWxlOiBicmFja2V0cyBub3QgbmVlZGVkDQogICAgPiArZXRjLg0KICAgID4gKw0KICAgID4g K1RlcnNlIGNvZGUgcmV2aWV3IHN0eWxlIGhhcyBpdHMgcGxhY2UgYW5kIGNhbiBiZSBwcm9kdWN0 aXZlIGZvciBib3RoIHRoZSByZXZpZXdlciBhbmQNCiAgICA+ICt0aGUgYXV0aG9yLiBIb3dldmVy LCBvdmVydXNlIGNhbiBjb21lIGFjcm9zcyBhcyB1bmZyaWVuZGx5LCBsYWNraW5nIGVtcGF0aHkg YW5kDQogICAgPiArY2FuIHRodXMgY3JlYXRlIGEgbmVnYXRpdmUgaW1wcmVzc2lvbiB3aXRoIHRo ZSBhdXRob3Igb2YgYSBwYXRjaC4gVGhpcyBpcyBpbiBwYXJ0aWN1bGFyDQogICAgPiArdHJ1ZSwg d2hlbiB5b3UgZG8gbm90IGtub3cgdGhlIGF1dGhvciBvciB0aGUgYXV0aG9yIGlzIGEgbmV3Y29t ZXIuIFRlcnNlDQogICAgPiArY29tbXVuaWNhdGlvbiBzdHlsZXMgY2FuIGFsc28gYmUgcGVyY2Vp dmVkIGFzIHJ1ZGUgaW4gc29tZSBjdWx0dXJlcy4NCiAgICA+ICsNCiAgICA+ICtJZiB5b3UgdGVu ZCB0byB1c2UgYSB0ZXJzZSBjb21tZW50aW5nIHN0eWxlIGFuZCB5b3UgZG8gbm90IGtub3cgd2hl dGhlciB0aGUgYXV0aG9yDQogICAgPiAraXMgT0sgd2l0aCBpdCwgaXQgaXMgb2Z0ZW4gYSBnb29k IGlkZWEgdG8gY29tcGVuc2F0ZSBmb3IgaXQgaW4gdGhlIGNvZGUgcmV2aWV3IG9wZW5pbmcNCiAg ICA+ICsod2hlcmUgeW91IGV4cHJlc3MgYXBwcmVjaWF0aW9uKSBvciB3aGVuIHRoZXJlIGlzIGEg bmVlZCBmb3IgdmVyYm9zZSBleHByZXNzaW9uLg0KICAgID4gKw0KICAgID4gK0l0IGlzIGFsc28g ZW50aXJlbHkgZmluZSB0byBtZW50aW9uIHRoYXQgeW91IGhhdmUgYSBmYWlybHkgdGVyc2UgY29t bXVuaWNhdGlvbiBzdHlsZQ0KICAgID4gK2FuZCBhc2sgd2hldGhlciB0aGUgYXV0aG9yIGlzIE9L IHdpdGggaXQuIEluIGFsbW9zdCBhbGwgY2FzZXMsIHRoZXkgd2lsbCBiZTogYnkgYXNraW5nDQog ICAgPiAreW91IGFyZSBzaG93aW5nIGVtcGF0aHkgdGhhdCBoZWxwcyBjb3VudGVyYWN0IGEgbmVn YXRpdmUgaW1wcmVzc2lvbi4NCiAgICA+ICsNCiAgICA+ICsjIyMgQ29kZSBSZXZpZXcgQ29tbWVu dHMgc2hvdWxkIGJlIGFjdGlvbmFibGUNCiAgICA+ICtDb2RlIHJldmlldyBjb21tZW50cyBzaG91 bGQgYmUgYWN0aW9uYWJsZTogaW4gb3RoZXIgd29yZHMsIGl0IG5lZWRzIHRvIGJlIGNsZWFyDQog ICAgPiArd2hhdCB0aGUgYXV0aG9yIG9mIHRoZSBjb2RlIG5lZWRzIHRvIGRvIHRvIGFkZHJlc3Mg dGhlIGlzc3VlIHlvdSBpZGVudGlmaWVkLg0KICAgID4gKw0KICAgID4gK1N0YXRlbWVudHMgc3Vj aCBhcw0KICAgID4gKz4gQkFEOiBUaGlzIGlzIHdyb25nDQogICAgPiArPiBCQUQ6IFRoaXMgZG9l cyBub3Qgd29yaw0KICAgID4gKz4gQkVUVEVSLCBCVVQgTk9UIEdPT0Q6IFRoaXMgZG9lcyBub3Qg d29yaywgYmVjYXVzZSBvZiBYWFgNCiAgICA+ICsNCiAgICA+ICtkbyBub3Qgbm9ybWFsbHkgcHJv dmlkZSB0aGUgYXV0aG9yIG9mIGEgcGF0Y2ggd2l0aCBlbm91Z2ggaW5mb3JtYXRpb24gdG8gc2Vu ZCBvdXQgYQ0KICAgID4gK25ldyBwYXRjaCB2ZXJzaW9uLiBCeSBkb2luZyB0aGlzLCB5b3UgZXNz ZW50aWFsbHkgZm9yY2UgdGhlIHBhdGNoIGF1dGhvciB0byAqKmZpbmQqKiBhbmQNCiAgICA+ICsq KmltcGxlbWVudCoqIGFuIGFsdGVybmF0aXZlLCB3aGljaCB0aGVuIG1heSBhbHNvIG5vdCBiZSBh Y2NlcHRhYmxlIHRvIHlvdSBhcyB0aGUNCiAgICA+ICsqKnJldmlld2VyKiogb2YgdGhlIHBhdGNo Lg0KICAgID4gKw0KICAgID4gK0EgYmV0dGVyIHdheSB0byBhcHByb2FjaCB0aGlzIGlzIHRvIHNh eQ0KICAgID4gKw0KICAgID4gKz4gVGhpcyBkb2VzIG5vdCB3b3JrLCBiZWNhdXNlIG9mIFhYWA0K ICAgID4gKz4gWW91IG1heSB3YW50IHRvIGludmVzdGlnYXRlIFlZWSBhbmQgWlpaIGFzIGFsdGVy bmF0aXZlcw0KICAgID4gKw0KICAgID4gK0luIHNvbWUgY2FzZXMsIGl0IG1heSBub3QgYmUgY2xl YXIgd2hldGhlciBZWVkgb3IgWlpaIGFyZSB0aGUgYmV0dGVyIHNvbHV0aW9uLiBBcyBhDQogICAg PiArcmV2aWV3ZXIgeW91IHNob3VsZCBiZSBhcyB1cC1mcm9udCBhbmQgcG9zc2libGUgaW4gc3Vj aCBhIGNhc2UgYW5kIHNheSBzb21ldGhpbmcgbGlrZQ0KICAgID4gKw0KICAgID4gKz4gSSBhbSBu b3Qgc3VyZSB3aGV0aGVyIFlZWSBhbmQgWlpaIGFyZSBiZXR0ZXIsIHNvIHlvdSBtYXkgd2FudCB0 byBvdXRsaW5lIHlvdXINCiAgICA+ICs+IHRob3VnaHRzIGFib3V0IGJvdGggc29sdXRpb25zIGJ5 IGUtbWFpbCBmaXJzdCwgc3VjaCB0aGF0IHdlIGNhbiBkZWNpZGUgd2hhdCB3b3Jrcw0KICAgID4g Kz4gYmVzdA0KICAgID4gKw0KICAgID4gKyMjIyBJZGVudGlmeSB0aGUgc2V2ZXJpdHkgb2YgYW4g aXNzdWUgb3IgZGlzYWdyZWVtZW50DQogICAgPiArQnkgZGVmYXVsdCwgZXZlcnkgY29tbWVudCB3 aGljaCBpcyBtYWRlICoqb3VnaHQgdG8gYmUgYWRkcmVzc2VkKiogYnkgdGhlIGF1dGhvci4NCiAg ICA+ICtIb3dldmVyLCBvZnRlbiByZXZpZXdlcnMgbm90ZSBpc3N1ZXMsIHdoaWNoIHdvdWxkIGJl IG5pY2UgaWYgdGhleSB3ZXJlIGFkZHJlc3NlZCwNCiAgICA+ICtidXQgYXJlIG5vdCBtYW5kYXRv cnkuDQogICAgPiArDQogICAgPiArVHlwaWNhbGx5LCByZXZpZXdlcnMgdXNlIHRlcm1pbm9sb2d5 IHN1Y2ggYXMNCiAgICA+ICs+IFRoaXMgd291bGQgYmUgYSBuaWNlLXRvLWhhdmUNCiAgICA+ICs+ IFRoaXMgaXMgbm90IGEgYmxvY2tlcg0KICAgID4gKw0KICAgID4gK1NvbWUgbWFpbnRhaW5lcnMg dXNlDQogICAgPiArPiBOSVQ6IFhYWA0KICAgID4gKw0KICAgID4gK2hvd2V2ZXIsIGl0IGlzIHNv bWV0aW1lcyBhbHNvIHVzZWQgdG8gaW5kaWNhdGUgYSBtaW5vciBpc3N1ZSB0aGF0ICoqbXVzdCoq IGJlIGZpeGVkLg0KICAgID4NCiAgICA+ICtEdXJpbmcgYSBjb2RlIHJldmlldywgaXQgY2FuIGhh cHBlbiB0aGF0IHJldmlld2VyIGFuZCBhdXRob3IgZGlzYWdyZWUgb24gaG93IHRvIG1vdmUNCiAg ICA+ICtmb3J3YXJkLiBUaGUgZGVmYXVsdCBwb3NpdGlvbiB3aGVuIGl0IGNvbWVzIHRvIGRpc2Fn cmVlbWVudHMgaXMgdGhhdCAqKmJvdGggcGFydGllcw0KICAgID4gK3dhbnQgdG8gYXJndWUgdGhl aXIgY2FzZSoqLiBIb3dldmVyLCBmcmVxdWVudGx5IG9uZSBvciBib3RoIHBhcnRpZXMgZG8gbm90 IGZlZWwgdGhhdA0KICAgID4gK3N0cm9uZ2x5IGFib3V0IGEgc3BlY2lmaWMgaXNzdWUuDQogICAg PiArDQogICAgPiArV2l0aGluIHRoZSBYZW4gUHJvamVjdCwgd2UgaGF2ZSBbYSB3YXldKGh0dHBz Oi8veGVucHJvamVjdC5vcmcvZGV2ZWxvcGVycy9nb3Zlcm5hbmNlLyNleHByZXNzaW5nb3Bpbmlv bikNCiAgICA+ICt0byBoaWdobGlnaHQgb25lJ3MgcG9zaXRpb24gb24gcHJvcG9zYWxzLCBmb3Jt YWwgb3IgaW5mb3JtYWwgdm90ZXMgdXNpbmcgdGhlIGZvbGxvd2luZw0KICAgID4gK25vdGF0aW9u Og0KICAgID4gKz4gKzIgOiBJIGFtIGhhcHB5IHdpdGggdGhpcyBwcm9wb3NhbCwgYW5kIEkgd2ls bCBhcmd1ZSBmb3IgaXQNCiAgICA+ICs+ICsxIDogSSBhbSBoYXBweSB3aXRoIHRoaXMgcHJvcG9z YWwsIGJ1dCB3aWxsIG5vdCBhcmd1ZSBmb3IgaXQNCiAgICA+ICs+IDAgOiBJIGhhdmUgbm8gb3Bp bmlvbg0KICAgID4gKz4gLTEgOiBJIGFtIG5vdCBoYXBweSB3aXRoIHRoaXMgcHJvcG9zYWwsIGJ1 dCB3aWxsIG5vdCBhcmd1ZSBhZ2FpbnN0IGl0DQogICAgPiArPiAtMiA6IEkgYW0gbm90IGhhcHB5 IHdpdGggdGhpcyBwcm9wb3NhbCwgYW5kIEkgd2lsbCBhcmd1ZSBhZ2FpbnN0IGl0DQogICAgPiAr DQogICAgPiArWW91IGNhbiB1c2UgYSBwaHJhc2Ugc3VjaCBhcw0KICAgID4gKz4gSSBhbSBub3Qg aGFwcHkgd2l0aCB0aGlzIHN1Z2dlc3Rpb24sIGJ1dCB3aWxsIG5vdCBhcmd1ZSBhZ2FpbnN0IGl0 DQogICAgPiArDQogICAgPiArdG8gbWFrZSBjbGVhciB3aGVyZSB5b3Ugc3RhbmQsIHdoaWxlIHJl Y29yZGluZyB5b3VyIHBvc2l0aW9uLiBDb252ZXJzZWx5LCBhIHJldmlld2VyDQogICAgPiArbWF5 IGRvIHNvbWV0aGluZyBzaW1pbGFyDQogICAgPiArPiBJIGFtIG5vdCBoYXBweSB3aXRoIFhZWiwg YnV0IHdpbGwgbm90IGFyZ3VlIGFnYWluc3QgaXQgW2FueW1vcmVdDQogICAgPiArPiBXaGF0IHdl IGhhdmUgbm93IGlzIGdvb2QgZW5vdWdoLCBidXQgY291bGQgYmUgYmV0dGVyDQogICAgDQogICAg SXQgaXMgbm90IGp1c3QgYWJvdXQgdGhlIHdpbGxpbmduZXNzIG9mIHNvbWVib2R5IHRvIGFyZ3Vl IGEgcG9pbnQsIHdoaWNoDQogICAgaXMgdGhlIGltcG9ydGFudCB0aGluZyB3aGVuIHZvdGluZy4g RHVyaW5nIGNvZGUgcmV2aWV3cyBpdCBpcyBwZXJmZWN0bHkNCiAgICBmaW5lIHRvIG1ha2Ugc3Vn Z2VzdGlvbnMgd2hpY2ggYXJlIGp1c3Qgb3B0aW9uYWwgZm9yIG11bHRpcGxlIHJlYXNvbnMsDQog ICAgaW5jbHVkaW5nIHRoYXQgdGhleSBtaWdodCBiZSB0b28gdGF4aW5nIGZvciB0aGUgY29udHJp YnV0b3IuDQogICAgDQogICAgU28sIEkgdGhpbmsgd2Ugc2hvdWxkIGFkZCB0aGF0IGl0IHdvdWxk IGJlIGJlc3QgdG8gdXNlIHdvcmRzIHRoYXQgbWFrZSBpdA0KICAgIGNsZWFyIHdoZXRoZXIgc29t ZXRoaW5nIGlzIG9wdGlvbmFsIG9yIHdoZXRoZXIgaXQgaXMgcmVxdWlyZWQsIHNlZSBteQ0KICAg IHJlcGx5IHRvIHBhdGNoICM2LCBJIHdyb3RlIGFuIGV4YW1wbGUgdGhlcmUuDQogICAgDQogICAg DQogICAgDQogICAgPiArIyMjIEF1dGhvcnM6IHJlc3BvbmRpbmcgdG8gcmV2aWV3IGNvbW1lbnRz DQogICAgPiArVHlwaWNhbGx5IHBhdGNoIGF1dGhvcnMgYXJlIGV4cGVjdGVkIHRvICoqYWRkcmVz cyBhbGwqKiByZXZpZXcgY29tbWVudHMgaW4gdGhlIG5leHQNCiAgICA+ICt2ZXJzaW9uIG9mIGEg cGF0Y2ggb3IgcGF0Y2ggc2VyaWVzLiBJbiBhIHNtb290aC1ydW5uaW5nIGNvZGUgcmV2aWV3IHdo ZXJlIHlvdSBkbyBub3QNCiAgICA+ICtoYXZlIGZ1cnRoZXIgcXVlc3Rpb25zIGl0IGlzIG5vdCBh dCBhbGwgbmVjZXNzYXJ5IHRvIGFja25vd2xlZGdlIHRoZSBjaGFuZ2VzIHlvdSBhcmUNCiAgICA+ ICtnb2luZyB0byBtYWtlOg0KICAgID4gKyogU2ltcGx5IHNlbmQgdGhlIG5leHQgdmVyc2lvbiB3 aXRoIHRoZSBjaGFuZ2VzIGFkZHJlc3NlZCBhbmQgcmVjb3JkIGl0IGluIHRoZQ0KICAgID4gK2No YW5nZS1sb2cNCiAgICA+ICsNCiAgICA+ICtXaGVuIHRoZXJlIGlzIGRpc2N1c3Npb24sIHRoZSBu b3JtYWwgcHJhY3RpY2UgaXMgdG8gcmVtb3ZlIHRoZSBwb3J0aW9uIG9mIHRoZSBlLW1haWwNCiAg ICA+ICt0aHJlYWQgd2hlcmUgdGhlcmUgaXMgYWdyZWVtZW50LiBPdGhlcndpc2UsIHRoZSB0aHJl YWQgY2FuIGJlY29tZSBleGNlcHRpb25hbGx5DQogICAgPiArbG9uZy4NCiAgICA+ICsNCiAgICA+ ICtJbiBjYXNlcyB3aGVyZSB0aGVyZSB3YXMgZGlzY3Vzc2lvbiBhbmQgbWF5YmUgZGlzYWdyZWVt ZW50LCBpdCBkb2VzIGhvd2V2ZXIgbWFrZQ0KICAgID4gK3NlbnNlIHRvIGNsb3NlIHRoZSBkaXNj dXNzaW9uIGJ5IHNheWluZyBzb21ldGhpbmcgbGlrZQ0KICAgID4gKw0KICAgID4gKz4gQUNLDQog ICAgPiArPiBTZWVtcyB3ZSBhcmUgYWdyZWVkLCBJIGFtIGdvaW5nIHRvIGRvIHRoaXMNCiAgICA+ ICsNCiAgICA+ICtPdGhlciBzaXR1YXRpb25zIHdoZW4geW91IG1heSB3YW50IHRvIGRvIHRoaXMg YXJlIGNhc2VzIHdoZXJlIHRoZSByZXZpZXdlciBtYWRlDQogICAgPiArb3B0aW9uYWwgc3VnZ2Vz dGlvbnMsIHRvIG1ha2UgY2xlYXIgd2hldGhlciB0aGUgc3VnZ2VzdGlvbiB3aWxsIGJlIGZvbGxv d2VkIG9yDQogICAgPiArbm90Lg0KICAgID4gKw0KICAgID4gKyMjIyBBdm9pZCB1bmNvbW1vbiB3 b3Jkczogbm90IGV2ZXJ5b25lIGlzIGEgbmF0aXZlIEVuZ2xpc2ggc3BlYWtlcg0KICAgID4gK0F2 b2lkIHVuY29tbW9uIHdvcmRzIGJvdGggd2hlbiByZXZpZXdpbmcgY29kZSBvciByZXNwb25kaW5n IHRvIGEgcmV2aWV3LiBOb3QNCiAgICA+ICtldmVyeW9uZSBpcyBhIG5hdGl2ZSBFbmdsaXNoIHNw ZWFrZXIuIFRoZSB1c2Ugb2Ygc3VjaCB3b3JkcyBjYW4gY29tZSBhY3Jvc3MgYmFkbHkgYW5kDQog ICAgPiArY2FuIGxlYWQgdG8gbWlzdW5kZXJzdGFuZGluZ3MuDQogICAgPiArDQogICAgPiArIyMj IFByaW9yaXRpemUgc2lnbmlmaWNhbnQgZmxhd3MNCiAgICA+ICtJZiBhIHBhdGNoIG9yIHBhdGNo IHNlcmllcyBoYXMgc2lnbmlmaWNhbnQgZmxhd3MsIHN1Y2ggYXMNCiAgICA+ICsqIEl0IGlzIGJ1 aWx0IG9uIHdyb25nIGFzc3VtcHRpb25zDQogICAgPiArKiBUaGVyZSBhcmUgaXNzdWVzIHdpdGgg dGhlIGFyY2hpdGVjdHVyZSBvciB0aGUgZGVzaWduDQogICAgPiArDQogICAgPiAraXQgZG9lcyBu b3QgbWFrZSBzZW5zZSB0byBkbyBhIGRldGFpbGVkIGNvZGUgcmV2aWV3LiBJbiBzdWNoIGNhc2Vz LCBpdCBpcyBiZXN0IHRvDQogICAgPiArZm9jdXMgb24gdGhlIG1ham9yIGlzc3VlcyBmaXJzdCBh bmQgZGVhbCB3aXRoIHN0eWxlIGFuZCBtaW5vciBpc3N1ZXMgaW4gYSBzdWJzZXF1ZW50DQogICAg PiArcmV2aWV3LiBUaGlzIHJlZHVjZXMgdGhlIHdvcmtsb2FkIG9uIGJvdGggdGhlIHJldmlld2Vy IGFuZCBwYXRjaCBhdXRob3IuIEhvd2V2ZXIsDQogICAgPiArcmV2aWV3ZXJzIHNob3VsZCBtYWtl IGNsZWFyIHRoYXQgdGhleSBoYXZlIG9taXR0ZWQgZGV0YWlsZWQgcmV2aWV3IGNvbW1lbnRzIGFu ZA0KICAgID4gK3RoYXQgdGhlc2Ugd2lsbCBjb21lIGxhdGVyLg0KICAgIA0KICAgIE1heWJlIHdl IHdhbnQgdG8gZXhwYW5kIG9uIHRoaXMgYSBiaXQuIE5vdCBhbGwgc2VyaWVzIGFyZSBiYXNlZCBv bg0KICAgIGZsYXdlZCBhc3N1bXB0aW9ucywgYnV0IGFsbCBzZXJpZXMgaGF2ZSBkaWZmZXJlbnQg Y2xhc3Mgb2YgY2hhbmdlcyB0aGF0DQogICAgYXJlIHJlcXVpcmVkIGZvciBhY2NlcHRhbmNlLCBm cm9tIG1ham9yIGNvZGUgbW9kaWZpY2F0aW9ucyB0byBtaW5vciBjb2RlDQogICAgc3R5bGUgZml4 ZXMuDQogICAgDQogICAgSSB0aGluayB3ZSBzaG91bGQgc2F5IHRoYXQgaXQgaXMgZ29vZCBwcmFj dGljZSB0byBhc2sgZm9yIGFueSBtYWpvcg0KICAgIGNoYW5nZXMgZWFybHkgb24sIGR1cmluZyB0 aGUgZmlyc3Qgb3Igc2Vjb25kIGl0ZXJhdGlvbiBvZiB0aGUgc2VyaWVzLg0KICAgIEl0IHdvdWxk IGJlIGJlc3QgdG8gYXZvaWQgYXNraW5nIGZvciBtYWpvciBjaGFuZ2VzIGF0IHY5IGlmIHBvc3Np YmxlLg0KICAgIA0KICAgIA0KICAgIFNvbWV0aGluZyBlbHNlIHdoaWNoIGlzIG1pc3NpbmcgaW4g dGhpcyBkb2N1bWVudCwgYW5kIGl0IGlzIHB1cmVseSBmb3INCiAgICByZXZpZXdlcnMsIGlzIHRv IGJlIGNhcmVmdWwgZG9pbmcgcmV2aWV3cyBsYXRlIGluIHRoZSBjeWNsZSB3aGVuIGFub3RoZXIN CiAgICBtYWludGFpbmVyL3Jldmlld2VyIGhhcyBhbHJlYWR5IHByb3ZpZGVkIGZlZWRiYWNrIG9u IHRoZSBzZXJpZXMgbXVsdGlwbGUNCiAgICB0aW1lcyBwcmV2aW91c2x5LiBGb3IgaW5zdGFuY2Us IGlmIHJldmlld2VyIFIxIGhhcyBiZWVuIGRvaW5nIHJldmlld3MNCiAgICBmcm9tIHRoZSBmaXJz dCB2ZXJzaW9uIG9mIHRoZSBzZXJpZXMgYW5kIGNvbnRyaWJ1dG9yIEMgaGFzIGJlZW4NCiAgICBh ZGRyZXNzaW5nIGFsbCBjb21tZW50cywgaXQgd291bGQgYmUgYmVzdCBpZiByZXZpZXdlciBSMiBk aWRuJ3QgY29tZSBpbg0KICAgIHByb3ZpZGluZyBkZXRhaWxlZCBmZWVkYmFjayBtb250aHMgbGF0 ZXIgYXQgdjUsIHVubGVzcyB0aGVpciByZXF1ZXN0cw0KICAgIGFyZSBhY3R1YWxseSBzdHJpY3Rs eSBuZWNlc3NhcnkgKGkuZS4gdGhleSBzcG90dGVkIGEgYnVnKS4gVGhlIG1haW4NCiAgICByZWFz b24gaXMgdGhhdCBpdCBpcyBkaWZmaWN1bHQgbm90IHRvIGxldCB5b3VyIG93biBwZXJzb25hbCBz dHlsZSAoY29kZQ0KICAgIHN0eWxlLCB0aGUgd2F5IHRvIGxheSBvdXQgdGhlIGNvZGUpIHNpcCB0 aHJvdWdoIHJldmlldyBjb21tZW50cywgYW5kIGl0DQogICAgY2FuIGNhdXNlIGRvdWJsZS1lZmZv cnQgZm9yIHRoZSBhdXRob3IgaWYgaGUvc2hlIGFscmVhZHkgbWFkZSBjaGFuZ2VzDQogICAgYWNj b3JkaW5nIFIxJ3MgcGVyc29uYWwgc3R5bGUuIEhvd2V2ZXIsIGluIGdlbmVyYWwsIGl0IHdvdWxk IGJlIGJlc3QgdG8NCiAgICBsaW1pdCAicGVyc29uYWwgc3R5bGUiIHJlcXVlc3RzIGZvciBjaGFu Z2VzIGFueXdheSwgc2VlIG15IGNvbW1lbnQgdG8NCiAgICBwYXRjaCAjNi4NCiAgICAgIA0KSSBz ZWUgd2hldGhlciBJIGNhbiBhZGQgc29tZXRoaW5nLiBJIGRvIGxpa2UgUmljaCdzIHN1Z2dlc3Rp b24gdG8gdXNlIHRoZSBTaGlmdCBMZWZ0IiB0ZXJtaW5vbG9neSAoaHR0cHM6Ly9kZXZvcGVkaWEu b3JnL3NoaWZ0LWxlZnQpIG9mIHdoaWNoIHRoaXMgaXMga2luZCBvZiBhbiBpbnN0YW5jZS4gVGhl IHNhbWUgYXBwbGllcyANCg0KSSBjYW4gcHV0IHRvZ2V0aGVyIGEgdjIsIHdpdGggdHlwb3MgYWRk cmVzc2VkIGFuZCBleHBhbmQgc29tZSBzZWN0aW9ucy4NCg0KUmVnYXJkcw0KTGFycw0KDQoNCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCndpbi1wdi1kZXZl bCBtYWlsaW5nIGxpc3QKd2luLXB2LWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8v bGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby93aW4tcHYtZGV2ZWw= From win-pv-devel-bounces@lists.xenproject.org Fri Nov 29 00:02:25 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 29 Nov 2019 00:02:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaTjt-0007Ed-2M; Fri, 29 Nov 2019 00:02:25 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaTjr-0007Dg-MH for win-pv-devel@lists.xenproject.org; Fri, 29 Nov 2019 00:02:23 +0000 X-Inumbo-ID: 83b80580-123b-11ea-a3da-12813bfff9fa Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 83b80580-123b-11ea-a3da-12813bfff9fa; Fri, 29 Nov 2019 00:02:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1574985742; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=pUoHTUkg4Xb/2R4GYepUcc7k96nRW9fdt05C1nDEB8o=; b=LMZXDsXwIuBoB54w9K+WKxV16KzU3vJGB9pNrtv7mVOxFxrQeLtWOXDl LNqukQzMxfad5IwaNPtSdIiMzGH1HGSpH7O0UK1NSrNBo1zF112cAgU0h zJh+XH4kq8kd5XmHwOWgWP2BO8Omv8BnYnOKvjEpX2mFPPJk/vhqRX7pB M=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=lars.kurth@citrix.com; spf=Pass smtp.mailfrom=lars.kurth@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of lars.kurth@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="lars.kurth@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa1.hc3370-68.iphmx.com: domain of lars.kurth@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="lars.kurth@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: bjIHBhWIMaQT+NKwUMNG71/nf6Y80WpNwaDg71kPp9pJkfWNd2fK1LP76BWAm3fEZ0XSsvXsOt aPotMn2nxGk3qpXHy3bMcYFDw7t7DXPGJDx/gWuyqpFB9TqqnyaypDPpf+0DEgyQ59udkoiP8Y 2ldST+Ab9sATXXFoJVj2gOhbEBvCV2J+drENuzwNzK340zU+xQUSQQ9sXyKlmgO02ZngtmaHY7 trKoWCII3Wc5jwtAZ0YeZmLP7R4d0or+lf5ImAtFtunvVqG48+S0ZtNKMUzgKRwZsQvgV+ZEQR S1c= X-SBRS: 2.7 X-MesageID: 9093276 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.69,255,1571716800"; d="scan'208";a="9093276" From: Lars Kurth To: Stefano Stabellini , Jan Beulich Thread-Topic: [PATCH v2 5/6] Add guide on Communication Best Practice Thread-Index: AQHVdKIoBNlHjnrbLUK7o4oIKuieK6c/HQoAgGD5A4CAARvaAA== Date: Fri, 29 Nov 2019 00:02:17 +0000 Message-ID: <4ABC1664-F80E-4A54-90A0-0F8C71FA2C4D@citrix.com> References: <749f082bdb996ba7c7362847b22030882dc2903f.1569525222.git.lars.kurth@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/10.10.10.191111 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted Content-ID: MIME-Version: 1.0 Subject: Re: [win-pv-devel] [PATCH v2 5/6] Add guide on Communication Best Practice X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Lars Kurth , "xen-api@lists.xenproject.org" , "minios-devel@lists.xenproject.org" , "committers@xenproject.org" , "mirageos-devel@lists.xenproject.org" , "xen-devel@lists.xenproject.org" , "win-pv-devel@lists.xenproject.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" DQoNCu+7v09uIDI3LzExLzIwMTksIDE5OjA2LCAiU3RlZmFubyBTdGFiZWxsaW5pIiA8c3N0YWJl bGxpbmlAa2VybmVsLm9yZz4gd3JvdGU6DQoNCiAgICBPbiBGcmksIDI3IFNlcCAyMDE5LCBKYW4g QmV1bGljaCB3cm90ZToNCiAgICA+IE9uIDI2LjA5LjIwMTkgMjE6MzksIExhcnMgS3VydGggd3Jv dGU6DQogICAgPiA+ICsjIyMgVmVyYm9zZSB2cy4gdGVyc2UNCiAgICA+ID4gK0R1ZSB0byB0aGUg dGltZSBpdCB0YWtlcyB0byByZXZpZXcgYW5kIGNvbXBvc2UgY29kZSByZXZpZXdlciwgcmV2aWV3 ZXJzIG9mdGVuIGFkb3B0IGENCiAgICA+ID4gK3RlcnNlIHN0eWxlLiBJdCBpcyBub3QgdW51c3Vh bCB0byBzZWUgcmV2aWV3IGNvbW1lbnRzIHN1Y2ggYXMNCiAgICA+ID4gKz4gdHlwbw0KICAgID4g PiArPiBzL3Jlc2lvbnMvcmVnaW9ucy8NCiAgICA+ID4gKz4gY29kaW5nIHN0eWxlDQogICAgPiA+ ICs+IGNvZGluZyBzdHlsZTogYnJhY2tldHMgbm90IG5lZWRlZA0KICAgID4gPiArZXRjLg0KICAg ID4gPiArDQogICAgPiA+ICtUZXJzZSBjb2RlIHJldmlldyBzdHlsZSBoYXMgaXRzIHBsYWNlIGFu ZCBjYW4gYmUgcHJvZHVjdGl2ZSBmb3IgYm90aCB0aGUgcmV2aWV3ZXIgYW5kDQogICAgPiA+ICt0 aGUgYXV0aG9yLiBIb3dldmVyLCBvdmVydXNlIGNhbiBjb21lIGFjcm9zcyBhcyB1bmZyaWVuZGx5 LCBsYWNraW5nIGVtcGF0aHkgYW5kDQogICAgPiA+ICtjYW4gdGh1cyBjcmVhdGUgYSBuZWdhdGl2 ZSBpbXByZXNzaW9uIHdpdGggdGhlIGF1dGhvciBvZiBhIHBhdGNoLiBUaGlzIGlzIGluIHBhcnRp Y3VsYXINCiAgICA+ID4gK3RydWUsIHdoZW4geW91IGRvIG5vdCBrbm93IHRoZSBhdXRob3Igb3Ig dGhlIGF1dGhvciBpcyBhIG5ld2NvbWVyLiBUZXJzZQ0KICAgID4gPiArY29tbXVuaWNhdGlvbiBz dHlsZXMgY2FuIGFsc28gYmUgcGVyY2VpdmVkIGFzIHJ1ZGUgaW4gc29tZSBjdWx0dXJlcy4NCiAg ICA+IA0KICAgID4gQW5kIGFub3RoZXIgcmVtYXJrIGhlcmU6IE5vdCBiZWluZyB0ZXJzZSBpbiBz aXR1YXRpb25zIGxpa2UgdGhlIG9uZXMNCiAgICA+IGVudW1lcmF0ZWQgYXMgZXhhbXBsZXMgYWJv dmUgaXMgYSBkb3VibGUgd2FzdGUgb2YgdGhlIHJldmlld2VyJ3MgdGltZToNCiAgICA+IFRoZXkg c2hvdWxkbid0IGV2ZW4gbmVlZCB0byBtYWtlIHN1Y2ggY29tbWVudHMsIGVzcGVjaWFsbHkgbm90 IG1hbnkNCiAgICA+IHRpbWVzIGZvciBhIHNpbmdsZSBwYXRjaCAoc2VlIHlvdXIgbWVudGlvbiBv ZiAib3ZlcnVzZSIpLiBJIHJlYWxpemUNCiAgICA+IHdlIHN0aWxsIGhhdmUgbm8gYXV0b21hdGVk IG1lY2hhbmlzbSB0byBjaGVjayBzdHlsZSBhc3BlY3RzLCBidXQNCiAgICA+IGFueWJvZHkgY2Fu IGVhc2lseSBsb29rIG92ZXIgdGhlaXIgcGF0Y2hlcyBiZWZvcmUgc3VibWl0dGluZyB0aGVtLg0K ICAgID4gQW5kIGZvciBhbiBvY2Nhc2lvbmFsIGlzc3VlIEkgdGhpbmsgYSB0ZXJzZSByZXBseSBp cyBxdWl0ZSByZWFzb25hYmxlDQogICAgPiB0byBoYXZlLg0KICAgID4gDQogICAgPiBPdmVyYWxs IEknbSBzZWVpbmcgdGhlIGdvb2QgaW50ZW50aW9ucyBvZiB0aGlzIGRvY3VtZW50LCB5ZXQgSSdk IHN0aWxsDQogICAgPiB2b3RlIGF0IGxlYXN0IC0xIG9uIGl0IGlmIGl0IGNhbWUgdG8gYSB2b3Rl LiBGb2xsb3dpbmcgZXZlbiBqdXN0IGENCiAgICA+IGZhaXIgcGFydCBvZiBpdCBpcyBhIGNvbnNp ZGVyYWJsZSBleHRyYSBhbW91bnQgb2YgdGltZSB0byBpbnZlc3QgaW4NCiAgICA+IHJldmlld3Ms IHdoZW4gd2UgYWxyZWFkeSBoYXZlIGEgc2V2ZXJlIHJldmlld2luZyBib3R0bGVuZWNrLiBJZiBJ IGhhdmUNCiAgICA+IHRvIGp1ZGdlIGJldHdlZW4gZG9pbmcgYSBiYWQgKHN0eWxpc3RpY2FsbHkg YWNjb3JkaW5nIHRvIHRoaXMgZG9jLCBub3QNCiAgICA+IHRlY2huaWNhbGx5KSByZXZpZXcgb3Ig bm9uZSBhdCBhbGwgKGJlY2F1c2Ugb2YgdGltZSBjb25zdHJhaW50cyksIEknZA0KICAgID4gZmF2 b3IgdGhlIGZvcm1lci4gVW5sZXNzIG9mIGNvdXJzZSBJJ20gYXNrZWQgdG8gc3RvcCBkb2luZyBz bywgaW4NCiAgICA+IHdoaWNoIGNhc2UgSSdkIGV4cGVjdCB3aG9ldmVyIGFza3MgdG8gYXJyYW5n ZSBmb3IgdGhlIHJldmlld3MgdG8gYmUNCiAgICA+IGRvbmUgYnkgc29tZW9uZSBlbHNlIGluIGR1 ZSBjb3Vyc2UuDQogICAgDQogICAgUmVhZGluZyB0aGUgZG9jdW1lbnQsIEkgdGhpbmsgSmFuIGhh cyBhIHBvaW50IHRoYXQgaXQgZ2l2ZXMgdGhlDQogICAgaW1wcmVzc2lvbiB0aGF0IGZvbGxvd2lu ZyB0aGUgc3VnZ2VzdGlvbnMgd291bGQgdGFrZSBzaWduaWZpY2FudA0KICAgIGVmZm9ydHMsIHdo aWxlIGFjdHVhbGx5IEkgZG9uJ3QgdGhpbmsgTGFycyBtZWFudCBpdCB0aGF0IHdheSBhdCBhbGws IGFuZA0KICAgIEkgZG9uJ3QgdGhpbmsgaXQgc2hvdWxkIGJlIHRoZSBjYXNlIGVpdGhlci4NCg0K WWVzLiBVbHRpbWF0ZWx5IHRoZSBlZmZlY3Qgb2YgYSBiZXR0ZXIgY29tbXVuaWNhdGlvbiBzaG91 bGQgb3ZlcmFsbCBiZSBhIG5ldC1wb3NpdGl2ZSBpbiB0ZXJtcyBvZiBlZmZvcnQuIA0KICAgIA0K ICAgIE1heWJlIHdlIHNob3VsZCBoaWdobGlnaHQgYW5kIGVuY291cmFnZSAiY2xhcml0eSIgaW5z dGVhZCBvZiAidmVyYm9zaXR5Ig0KICAgIG9mIHRoZSBjb21tdW5pY2F0aW9uLCBhbmQgZW5jb3Vy YWdlICJleHByZXNzaW5nIGFwcHJlY2lhdGlvbiIgdG8NCiAgICBuZXdjb21lcnMsIG5vdCBuZWNl c3NhcmlseSB0byBzZWFzb25lZCBjb250cmlidXRvcnMuDQoNCkdvb2QgaWRlYQ0KICAgIA0KICAg IFRoZSB1bHRpbWF0ZSBnb2FsIG9mIHRoaXMgZG9jdW1lbnQgaXMgYWN0dWFsbHkgdG8gKnJlZHVj ZSogb3VyIG92ZXJhbGwNCiAgICBlZmZvcnRzIGJ5IG1ha2luZyBvdXIgY29tbXVuaWNhdGlvbiBt b3JlIGVmZmljaWVudCwgbm90IHRvIGluY3JlYXNlDQogICAgZWZmb3J0cy4gTWF5YmUgaXQgaXMg d29ydGggc2F5aW5nIHRoaXMgdG9vLg0KICAgIA0KSXQgaXMgd29ydGggc2F5aW5nIHRoaXMuIA0K DQpSZWdhcmRzDQpMYXJzDQoNCg0KDQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwp3aW4tcHYtZGV2ZWwgbWFpbGluZyBsaXN0Cndpbi1wdi1kZXZlbEBsaXN0 cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlz dGluZm8vd2luLXB2LWRldmVs From win-pv-devel-bounces@lists.xenproject.org Fri Nov 29 01:39:30 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 29 Nov 2019 01:39:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaVFp-0005gl-Vl; Fri, 29 Nov 2019 01:39:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaVFo-0005ga-NZ for win-pv-devel@lists.xenproject.org; Fri, 29 Nov 2019 01:39:28 +0000 X-Inumbo-ID: 0849c222-1249-11ea-9db0-bc764e2007e4 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0849c222-1249-11ea-9db0-bc764e2007e4; Fri, 29 Nov 2019 01:39:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1574991548; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=sSbstC7TnwprPzEhGvuTO6d6CCe7879ZwVONkBx9OI0=; b=UpoXMlncOfE2W+C+AtMevBnAJXm3SK4FR9o83yki3CGhwOY097+LnZwQ QNP4Nikdf1kQFbzAqhacRHVcF52PNAYmJK6RCozn0U8dQNBZEfbxQcEqF 3HfDyPWHk+TD4AofHCfzHbtjywCr9r1MzwDAoQ4AgQlbhKnJ3Vu/PklXh 0=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=lars.kurth@citrix.com; spf=Pass smtp.mailfrom=lars.kurth@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of lars.kurth@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="lars.kurth@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa3.hc3370-68.iphmx.com: domain of lars.kurth@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="lars.kurth@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: nh51LfI+Lgpt1esAWWhWptu+t4U+3mZYvYZX8MVMVInCrI+JQ6AprxQGTNytqrePkY5BhW/06U RVGlY93yiKwVFBjZHYbVV3ULuFt/3fEoiKnJ7J1LUdWTaWrYF+YuV2YUNWHfy4owdRjSbAXBb4 IgP0uFHxWE1KKffBiHMOb6+FqEqION/orTH2jLVlQYsyQAvbMKKMQhaFxaYT6U16yb0HfwWkD7 R7pzvh9obX01a1RFLrR1R23mgt3L7LDBdftw3PZuxo0W7Uv36v5YqWh0r/XctCYcjm1K/VCBC9 T0s= X-SBRS: 2.7 X-MesageID: 8962518 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.69,255,1571716800"; d="scan'208,217";a="8962518" From: Lars Kurth To: Rich Persaud Thread-Topic: [MirageOS-devel] [PATCH v2 4/6] Add Code Review Guide Thread-Index: AQHVpfEGwl/VxYnE9Uydtksy7w4pxaegJ7iAgACsyoCAABXQgA== Date: Fri, 29 Nov 2019 01:39:03 +0000 Message-ID: References: <6DC58DC2-5F2F-4496-A0F5-A91F11FD931B@gmail.com> In-Reply-To: <6DC58DC2-5F2F-4496-A0F5-A91F11FD931B@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/10.10.10.191111 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted MIME-Version: 1.0 Subject: Re: [win-pv-devel] [MirageOS-devel] [PATCH v2 4/6] Add Code Review Guide X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Lars Kurth , Stefano Stabellini , "mirageos-devel@lists.xenproject.org" , "xen-api@lists.xenproject.org" , "minios-devel@lists.xenproject.org" , "committers@xenproject.org" , Jan Beulich , "xen-devel@lists.xenproject.org" , "win-pv-devel@lists.xenproject.org" Content-Type: multipart/mixed; boundary="===============0202623679310461517==" Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" --===============0202623679310461517== Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_FDC64A08D89444CB92449752D0FD17CDcitrixcom_" --_000_FDC64A08D89444CB92449752D0FD17CDcitrixcom_ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 DQoNCkZyb206IFJpY2ggUGVyc2F1ZCA8cGVyc2F1ckBnbWFpbC5jb20+DQpEYXRlOiBUaHVyc2Rh eSwgMjggTm92ZW1iZXIgMjAxOSBhdCAxMjoyMQ0KVG86IExhcnMgS3VydGggPGxhcnMua3VydGhA Y2l0cml4LmNvbT4NCkNjOiAnSmFuIEJldWxpY2gnIDxKQmV1bGljaEBzdXNlLmNvbT4sICJsYXJz Lmt1cnRoQHhlbnByb2plY3Qub3JnIiA8bGFycy5rdXJ0aEB4ZW5wcm9qZWN0Lm9yZz4sIFN0ZWZh bm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4sICJ4ZW4tYXBpQGxpc3RzLnhl bnByb2plY3Qub3JnIiA8eGVuLWFwaUBsaXN0cy54ZW5wcm9qZWN0Lm9yZz4sICJtaW5pb3MtZGV2 ZWxAbGlzdHMueGVucHJvamVjdC5vcmciIDxtaW5pb3MtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5v cmc+LCAiY29tbWl0dGVyc0B4ZW5wcm9qZWN0Lm9yZyIgPGNvbW1pdHRlcnNAeGVucHJvamVjdC5v cmc+LCAibWlyYWdlb3MtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmciIDxtaXJhZ2Vvcy1kZXZl bEBsaXN0cy54ZW5wcm9qZWN0Lm9yZz4sIHhlbi1kZXZlbCA8eGVuLWRldmVsQGxpc3RzLnhlbnBy b2plY3Qub3JnPiwgIndpbi1wdi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZyIgPHdpbi1wdi1k ZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZz4NClN1YmplY3Q6IFJlOiBbTWlyYWdlT1MtZGV2ZWxd IFtQQVRDSCB2MiA0LzZdIEFkZCBDb2RlIFJldmlldyBHdWlkZQ0KDQpPbiBOb3YgMjgsIDIwMTks IGF0IDA5OjA1LCBMYXJzIEt1cnRoIDxsYXJzLmt1cnRoQGNpdHJpeC5jb20+IHdyb3RlOg0KDQpP biAyOC8xMS8yMDE5LCAwNzozNywgIkphbiBCZXVsaWNoIiA8amJldWxpY2hAc3VzZS5jb20+IHdy b3RlOg0KDQogICBPbiAyOC4xMS4yMDE5IDE0OjA2LCBMYXJzIEt1cnRoIHdyb3RlOg0KDQpJIGNh biBjZXJ0YWlubHkgYWRkIHNvbWV0aGluZyBvbiB0aGUgdGltaW5nICwgYWxvbmcgdGhlIGxpbmVz IG9mDQoqIEZvciBjb21wbGV4IHNlcmllcywgY29uc2lkZXIgdGhlIHRpbWUgaXQgdGFrZXMgdG8g ZG8gcmV2aWV3cyAobWF5YmUgd2l0aCBhIGd1aWRlIG9mIExPQyBwZXIgaG91cikgYW5kIGdpdmUg cmV2aWV3ZXJzIGVub3VnaCB0aW1lIHRvDQoqIEZvciBzZXJpZXMgd2l0aCBkZXNpZ24gaXNzdWVz IG9yIGxhcmdlIHF1ZXN0aW9ucywgdHJ5IGFuZCBoaWdobGlnaHQgdGhlIGtleSBvcGVuIGlzc3Vl cyBpbiBjb3ZlciBsZXR0ZXJzIGNsZWFybHkgYW5kIHNvbGljaXQgZmVlZGJhY2sgZnJvbSBrZXkg bWFpbnRhaW5lcnMgd2hvIGNhbiBjb21tZW50IG9uIHRoZSBvcGVuIGlzc3VlLiBUaGUgaWRlYSBp cyB0byBzYXZlIGJvdGggdGhlIGNvbnRyaWJ1dG9yIGFuZCB0aGUgcmV2aWV3ZXJzIHRpbWUgYnkg Zm9jdXNzaW5nIG9uIHdoYXQgbmVlZHMgdG8gYmUgcmVzb2x2ZWQNCiogRG9u4oCZdCByZXBvc3Qg YSBzZXJpZXMsIHVubGVzcyBhbGwgcmV2aWV3IGNvbW1lbnRzIGFyZSBhZGRyZXNzZWQNCm9yIHRo ZSByZXZpZXdlcnMgYXNrZWQgeW91IHRvIGRvIHNvLiBUaGUgcHJvYmxlbSB3aXRoIHRoaXMgaXMg dGhhdA0KdGhpcyBpcyBzb21ld2hhdCBpbiBjb25mbGljdCB3aXRoIHRoZSAibGV0J3MgZm9jdXMg b24gdGhlIGNvcmUNCmlzc3VlcyBhbmQgbm90IGdldCBkaXN0cmFjdGVkIGJ5IGRldGFpbHMgZWFy bHkgb24gaW4gYSByZXZpZXcgY3ljbGUiLg0KSW4gb3RoZXIgd29yZHMsIHRoaXMgY2FuIG9ubHkg d29yaywgaWYgcmV2aWV3ZXJzIGZvY3VzIG9uIG1ham9yDQppc3N1ZXMgaW4gZWFybHkgcmV2aWV3 cyBvbmx5IGFuZCBkbyBub3QgZm9jdXMgb24gc3R5bGUsIGNvZGluZw0Kc3RhbmRhcmRzLCBldGMu DQoNCiAgIEJ1dCB0aGlzIGRvZXNuJ3QgbWFrZSBtdWNoIHNlbnNlIGVpdGhlciwgYmVjYXVzZSB0 aGVuIGZ1bGwgcmUtcmV2aWV3cw0KICAgbmVlZCB0byBoYXBwZW4gYW55d2F5IG9uIGxhdGVyIHZl cnNpb25zLCB0byBhbHNvIGRlYWwgd2l0aCB0aGUgbWlub3INCiAgIGlzc3Vlcy4gRm9yIFJGQyBr aW5kIG9mIHNlcmllcyBvbWl0dGluZyBzdHlsZSBhbmQgYWxpa2UgZmVlZGJhY2sNCiAgIGNlcnRh aW5seSBtYWtlcyBzZW5zZSwgYnV0IGFzIHNvb24gYXMgYSBwYXRjaCBpcyBub24tUkZDLCBpdCBz aG91bGQNCiAgIGJlIGNvbnNpZGVyZWQgZ29vZCB0byBnbyBpbiBieSB0aGUgc3VibWl0dGVyLg0K DQpPSywgSSB0aGluayB3ZSBoYXZlIGEgZGlzY29ubmVjdCBiZXR3ZWVuIGlkZWFsIGFuZCByZWFs aXR5Lg0KDQpJIHNlZSB0d28gaXNzdWVzIHRvZGF5DQoqIEtleSBtYWludGFpbmVycyBkb24ndCBh bHdheXMgcmV2aWV3IFJGQyBzZXJpZXMgW3RoZXkgZW5kIHVwIGF0IHRoZSBib3R0b20gb2YgdGhl IHByaW9yaXR5IGxpc3QsIGV2ZW4gdGhvdWdoIHNwZW5kaW5nIHRpbWUgb24gUkZDcyB3aWxsIHNh dmUgdGltZSBlbHNld2hlcmUgbGF0ZXJdLiBTbyB0aGUgZWZmZWN0IGlzIHRoYXQgdGhlbiB0aGUg Y29udHJpYnV0b3IgYXNzdW1lcyB0aGVyZSBhcmUgbm8gbWFqb3IgaXNzdWVzIGFuZCBlbmRzIGl0 IGFzIGEgcHJvcGVyIHNlcmllcw0KKiBJbiBwcmFjdGljZSB3aGF0IGhhcyBoYXBwZW5lZCBvZnRl biBpbiB0aGUgcGFzdCBpcyB0aGF0IGRlc2lnbiwgYXJjaGl0ZWN0dXJlLCBhc3N1bXB0aW9uIGZs YXdzIGFyZSBmb3VuZCBpbiBlYXJseSB2ZXJzaW9ucyBvZiBhIHNlcmllcy4NCiAgLSBUaGlzIHVz dWFsbHkgaGFwcGVucyBiZWNhdXNlIG9mIGFuIG92ZXJzaWdodCBvciBiZWNhdXNlIHRoZXJlIHdh cyBubyBkZXNpZ24gZGlzY3Vzc2lvbiBwcmlvciB0byB0aGUgc2VyaWVzIGJlaW5nIHBvc3RlZCBh bmQgYWdyZWVkDQogIC0gQ29tbW9uIHNlbnNlIHdvdWxkIGRpY3RhdGUgdGhhdCB0aGUgYmlnZ2Vz dCBiZW5lZml0IGZvciBib3RoIHRoZSByZXZpZXdlciwgdGhlIGNvbnRyaWJ1dG9yIGFuZCB0aGUg Y29tbXVuaXR5IGFzIGEgd2hvbGUgd291bGQgYmUgdG8gdHJ5IGFuZCBmb2N1cyBvbiBzdWNoIGZs YXdzIGFuZCBsZWF2ZSBldmVyeXRoaW5nIGFzaWRlDQogIC0gT2YgY291cnNlIHRoZXJlIG1heSBi ZSB2YWx1ZSBpbiBkb2luZyBhIGRldGFpbGVkIHJldmlldyBvZiBwYXJ0cyBvZiBzdWNoIGEgc2Vy aWVzIGFzIHRoZXJlIG1heSBiZSBiaXRzIHRoYXQgYXJlIHVuYWZmZWN0ZWQgYnkgc3VjaCBhIGZs YXcNCiAgLSBCdXQgdGhlcmUgd2lsbCBsaWtlbHkgYmUgcGFydHMgd2hpY2ggYXJlIG5vdDogZG9p bmcgYSBkZXRhaWxlZCByZXZpZXcgb2Ygc3VjaCBwb3J0aW9ucyB3YXN0ZXMgZXZlcnlvbmUncyB0 aW1lDQoNClNvIGNvbWluZyBiYWNrIHRvIHlvdXIgcG9pbnQuIElkZWFsbHksIGl0IHdvdWxkIGJl IG5pY2UgaWYgd2UgaGFkIHRoZSBjYXBhYmlsaXR5IHRvIGNhbGwgb3V0IHBhcnRzIG9mIGEgc2Vy aWVzIGFzICJwcm9ibGVtYXRpYyIgYW5kIHRyZWF0aW5nIHN1Y2ggcGFydHMgZGlmZmVyZW50bHku DQoNCiAgV2UgbWF5IGJlIGFibGUgdG8gcmV1c2Ugc29tZSAiU2hpZnQgTGVmdCIgdGVybWlub2xv Z3ksIGluY2x1ZGluZyBjaXRhdGlvbnMgb2YgcHJldmlvdXMgWGVuIGNvZGUgcmV2aWV3cyB0byBp bGx1c3RyYXRlIGNhdGVnb3JpZXMgb2YgZGVzaWduIGlzc3VlcyB0aGF0IGNhbiBiZSBzaGlmdGVk IGxlZnQ6DQoNCiAgICBodHRwczovL2Rldm9wZWRpYS5vcmcvc2hpZnQtbGVmdA0KDQpJIGxpa2Ug dGhhdCBpZGVhLiBXZSBzZWVtIHRvIG5vdCBoYXZlIGNvbWUgdG8gYSBjb25jbHVzaW9uIG9uIHRo aXMgc3BlY2lmaWMgdG9waWMsIGJ1dCBtYXliZSBmb3Igbm93IGl0IGlzIHN1ZmZpY2llbnQgdG8g Y2FsbCB0aGlzIG91dCBhcyBhIHBvdGVudGlhbCBpc3N1ZSBpbiB0aGUgZ3VpZGUuDQoNCkJlZm9y ZSBJIHNlbmQgb3V0IGEgbmV3IHZlcnNpb24sIGl0IHdvdWxkIGJlIGdvb2QgdG8gZ2V0IGF0IGxl YXN0IEphbuKAmXMgdmlldyBvbiB0aGUgaXNzdWUuDQoNCkxhcnMNCg0K --_000_FDC64A08D89444CB92449752D0FD17CDcitrixcom_ Content-Type: text/html; charset="utf-8" Content-ID: <56FE05D6636B0D44BFBB4381C078C0CF@citrix.com> Content-Transfer-Encoding: base64 PGh0bWwgeG1sbnM6bz0idXJuOnNjaGVtYXMtbWljcm9zb2Z0LWNvbTpvZmZpY2U6b2ZmaWNlIiB4 bWxuczp3PSJ1cm46c2NoZW1hcy1taWNyb3NvZnQtY29tOm9mZmljZTp3b3JkIiB4bWxuczptPSJo dHRwOi8vc2NoZW1hcy5taWNyb3NvZnQuY29tL29mZmljZS8yMDA0LzEyL29tbWwiIHhtbG5zPSJo dHRwOi8vd3d3LnczLm9yZy9UUi9SRUMtaHRtbDQwIj4NCjxoZWFkPg0KPG1ldGEgaHR0cC1lcXVp dj0iQ29udGVudC1UeXBlIiBjb250ZW50PSJ0ZXh0L2h0bWw7IGNoYXJzZXQ9dXRmLTgiPg0KPG1l dGEgbmFtZT0iR2VuZXJhdG9yIiBjb250ZW50PSJNaWNyb3NvZnQgV29yZCAxNSAoZmlsdGVyZWQg bWVkaXVtKSI+DQo8c3R5bGU+PCEtLQ0KLyogRm9udCBEZWZpbml0aW9ucyAqLw0KQGZvbnQtZmFj ZQ0KCXtmb250LWZhbWlseToiQ2FtYnJpYSBNYXRoIjsNCglwYW5vc2UtMToyIDQgNSAzIDUgNCA2 IDMgMiA0O30NCkBmb250LWZhY2UNCgl7Zm9udC1mYW1pbHk6Q2FsaWJyaTsNCglwYW5vc2UtMToy IDE1IDUgMiAyIDIgNCAzIDIgNDt9DQovKiBTdHlsZSBEZWZpbml0aW9ucyAqLw0KcC5Nc29Ob3Jt YWwsIGxpLk1zb05vcm1hbCwgZGl2Lk1zb05vcm1hbA0KCXttYXJnaW46MGNtOw0KCW1hcmdpbi1i b3R0b206LjAwMDFwdDsNCglmb250LXNpemU6MTEuMHB0Ow0KCWZvbnQtZmFtaWx5OiJDYWxpYnJp IixzYW5zLXNlcmlmO30NCmE6bGluaywgc3Bhbi5Nc29IeXBlcmxpbmsNCgl7bXNvLXN0eWxlLXBy aW9yaXR5Ojk5Ow0KCWNvbG9yOmJsdWU7DQoJdGV4dC1kZWNvcmF0aW9uOnVuZGVybGluZTt9DQph OnZpc2l0ZWQsIHNwYW4uTXNvSHlwZXJsaW5rRm9sbG93ZWQNCgl7bXNvLXN0eWxlLXByaW9yaXR5 Ojk5Ow0KCWNvbG9yOnB1cnBsZTsNCgl0ZXh0LWRlY29yYXRpb246dW5kZXJsaW5lO30NCnAubXNv bm9ybWFsMCwgbGkubXNvbm9ybWFsMCwgZGl2Lm1zb25vcm1hbDANCgl7bXNvLXN0eWxlLW5hbWU6 bXNvbm9ybWFsOw0KCW1zby1tYXJnaW4tdG9wLWFsdDphdXRvOw0KCW1hcmdpbi1yaWdodDowY207 DQoJbXNvLW1hcmdpbi1ib3R0b20tYWx0OmF1dG87DQoJbWFyZ2luLWxlZnQ6MGNtOw0KCWZvbnQt c2l6ZToxMS4wcHQ7DQoJZm9udC1mYW1pbHk6IkNhbGlicmkiLHNhbnMtc2VyaWY7fQ0Kc3Bhbi5F bWFpbFN0eWxlMTgNCgl7bXNvLXN0eWxlLXR5cGU6cGVyc29uYWwtcmVwbHk7DQoJZm9udC1mYW1p bHk6IkNhbGlicmkiLHNhbnMtc2VyaWY7DQoJY29sb3I6d2luZG93dGV4dDt9DQouTXNvQ2hwRGVm YXVsdA0KCXttc28tc3R5bGUtdHlwZTpleHBvcnQtb25seTsNCglmb250LXNpemU6MTAuMHB0O30N CkBwYWdlIFdvcmRTZWN0aW9uMQ0KCXtzaXplOjYxMi4wcHQgNzkyLjBwdDsNCgltYXJnaW46NzIu MHB0IDcyLjBwdCA3Mi4wcHQgNzIuMHB0O30NCmRpdi5Xb3JkU2VjdGlvbjENCgl7cGFnZTpXb3Jk U2VjdGlvbjE7fQ0KLS0+PC9zdHlsZT4NCjwvaGVhZD4NCjxib2R5IGxhbmc9IkVOLUdCIiBsaW5r PSJibHVlIiB2bGluaz0icHVycGxlIj4NCjxkaXYgY2xhc3M9IldvcmRTZWN0aW9uMSI+DQo8cCBj bGFzcz0iTXNvTm9ybWFsIj48bzpwPiZuYnNwOzwvbzpwPjwvcD4NCjxwIGNsYXNzPSJNc29Ob3Jt YWwiPjxvOnA+Jm5ic3A7PC9vOnA+PC9wPg0KPGRpdiBzdHlsZT0iYm9yZGVyOm5vbmU7Ym9yZGVy LXRvcDpzb2xpZCAjQjVDNERGIDEuMHB0O3BhZGRpbmc6My4wcHQgMGNtIDBjbSAwY20iPg0KPHAg Y2xhc3M9Ik1zb05vcm1hbCI+PGI+PHNwYW4gc3R5bGU9ImZvbnQtc2l6ZToxMi4wcHQ7Y29sb3I6 YmxhY2siPkZyb206IDwvc3Bhbj48L2I+PHNwYW4gc3R5bGU9ImZvbnQtc2l6ZToxMi4wcHQ7Y29s b3I6YmxhY2siPlJpY2ggUGVyc2F1ZCAmbHQ7cGVyc2F1ckBnbWFpbC5jb20mZ3Q7PGJyPg0KPGI+ RGF0ZTogPC9iPlRodXJzZGF5LCAyOCBOb3ZlbWJlciAyMDE5IGF0IDEyOjIxPGJyPg0KPGI+VG86 IDwvYj5MYXJzIEt1cnRoICZsdDtsYXJzLmt1cnRoQGNpdHJpeC5jb20mZ3Q7PGJyPg0KPGI+Q2M6 IDwvYj4nSmFuIEJldWxpY2gnICZsdDtKQmV1bGljaEBzdXNlLmNvbSZndDssICZxdW90O2xhcnMu a3VydGhAeGVucHJvamVjdC5vcmcmcXVvdDsgJmx0O2xhcnMua3VydGhAeGVucHJvamVjdC5vcmcm Z3Q7LCBTdGVmYW5vIFN0YWJlbGxpbmkgJmx0O3NzdGFiZWxsaW5pQGtlcm5lbC5vcmcmZ3Q7LCAm cXVvdDt4ZW4tYXBpQGxpc3RzLnhlbnByb2plY3Qub3JnJnF1b3Q7ICZsdDt4ZW4tYXBpQGxpc3Rz LnhlbnByb2plY3Qub3JnJmd0OywgJnF1b3Q7bWluaW9zLWRldmVsQGxpc3RzLnhlbnByb2plY3Qu b3JnJnF1b3Q7ICZsdDttaW5pb3MtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcmZ3Q7LA0KICZx dW90O2NvbW1pdHRlcnNAeGVucHJvamVjdC5vcmcmcXVvdDsgJmx0O2NvbW1pdHRlcnNAeGVucHJv amVjdC5vcmcmZ3Q7LCAmcXVvdDttaXJhZ2Vvcy1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZyZx dW90OyAmbHQ7bWlyYWdlb3MtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcmZ3Q7LCB4ZW4tZGV2 ZWwgJmx0O3hlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZyZndDssICZxdW90O3dpbi1wdi1k ZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZyZxdW90OyAmbHQ7d2luLXB2LWRldmVsQGxpc3RzLnhl bnByb2plY3Qub3JnJmd0Ozxicj4NCjxiPlN1YmplY3Q6IDwvYj5SZTogW01pcmFnZU9TLWRldmVs XSBbUEFUQ0ggdjIgNC82XSBBZGQgQ29kZSBSZXZpZXcgR3VpZGU8bzpwPjwvbzpwPjwvc3Bhbj48 L3A+DQo8L2Rpdj4NCjxkaXY+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIj48bzpwPiZuYnNwOzwvbzpw PjwvcD4NCjwvZGl2Pg0KPGRpdj4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiPk9uIE5vdiAyOCwgMjAx OSwgYXQgMDk6MDUsIExhcnMgS3VydGggJmx0O2xhcnMua3VydGhAY2l0cml4LmNvbSZndDsgd3Jv dGU6PG86cD48L286cD48L3A+DQo8L2Rpdj4NCjxkaXY+DQo8YmxvY2txdW90ZSBzdHlsZT0ibWFy Z2luLXRvcDo1LjBwdDttYXJnaW4tYm90dG9tOjUuMHB0Ij4NCjxwIGNsYXNzPSJNc29Ob3JtYWwi PjxvOnA+Jm5ic3A7PC9vOnA+PC9wPg0KPC9ibG9ja3F1b3RlPg0KPC9kaXY+DQo8YmxvY2txdW90 ZSBzdHlsZT0ibWFyZ2luLXRvcDo1LjBwdDttYXJnaW4tYm90dG9tOjUuMHB0Ij4NCjxkaXY+DQo8 cCBjbGFzcz0iTXNvTm9ybWFsIj5PbiAyOC8xMS8yMDE5LCAwNzozNywgJnF1b3Q7SmFuIEJldWxp Y2gmcXVvdDsgJmx0O2piZXVsaWNoQHN1c2UuY29tJmd0OyB3cm90ZTo8YnI+DQo8YnI+DQombmJz cDsmbmJzcDsmbmJzcDtPbiAyOC4xMS4yMDE5IDE0OjA2LCBMYXJzIEt1cnRoIHdyb3RlOjxicj4N Cjxicj4NCjxvOnA+PC9vOnA+PC9wPg0KPGJsb2NrcXVvdGUgc3R5bGU9Im1hcmdpbi10b3A6NS4w cHQ7bWFyZ2luLWJvdHRvbTo1LjBwdCI+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIj5JIGNhbiBjZXJ0 YWlubHkgYWRkIHNvbWV0aGluZyBvbiB0aGUgdGltaW5nICwgYWxvbmcgdGhlIGxpbmVzIG9mPG86 cD48L286cD48L3A+DQo8L2Jsb2NrcXVvdGU+DQo8YmxvY2txdW90ZSBzdHlsZT0ibWFyZ2luLXRv cDo1LjBwdDttYXJnaW4tYm90dG9tOjUuMHB0Ij4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiPiogRm9y IGNvbXBsZXggc2VyaWVzLCBjb25zaWRlciB0aGUgdGltZSBpdCB0YWtlcyB0byBkbyByZXZpZXdz IChtYXliZSB3aXRoIGEgZ3VpZGUgb2YgTE9DIHBlciBob3VyKSBhbmQgZ2l2ZSByZXZpZXdlcnMg ZW5vdWdoIHRpbWUgdG88bzpwPjwvbzpwPjwvcD4NCjwvYmxvY2txdW90ZT4NCjxibG9ja3F1b3Rl IHN0eWxlPSJtYXJnaW4tdG9wOjUuMHB0O21hcmdpbi1ib3R0b206NS4wcHQiPg0KPHAgY2xhc3M9 Ik1zb05vcm1hbCI+KiBGb3Igc2VyaWVzIHdpdGggZGVzaWduIGlzc3VlcyBvciBsYXJnZSBxdWVz dGlvbnMsIHRyeSBhbmQgaGlnaGxpZ2h0IHRoZSBrZXkgb3BlbiBpc3N1ZXMgaW4gY292ZXIgbGV0 dGVycyBjbGVhcmx5IGFuZCBzb2xpY2l0IGZlZWRiYWNrIGZyb20ga2V5IG1haW50YWluZXJzIHdo byBjYW4gY29tbWVudCBvbiB0aGUgb3BlbiBpc3N1ZS4gVGhlIGlkZWEgaXMgdG8gc2F2ZSBib3Ro IHRoZSBjb250cmlidXRvciBhbmQNCiB0aGUgcmV2aWV3ZXJzIHRpbWUgYnkgZm9jdXNzaW5nIG9u IHdoYXQgbmVlZHMgdG8gYmUgcmVzb2x2ZWQgPG86cD48L286cD48L3A+DQo8L2Jsb2NrcXVvdGU+ DQo8YmxvY2txdW90ZSBzdHlsZT0ibWFyZ2luLXRvcDo1LjBwdDttYXJnaW4tYm90dG9tOjUuMHB0 Ij4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiPiogRG9u4oCZdCByZXBvc3QgYSBzZXJpZXMsIHVubGVz cyBhbGwgcmV2aWV3IGNvbW1lbnRzIGFyZSBhZGRyZXNzZWQ8bzpwPjwvbzpwPjwvcD4NCjwvYmxv Y2txdW90ZT4NCjxibG9ja3F1b3RlIHN0eWxlPSJtYXJnaW4tdG9wOjUuMHB0O21hcmdpbi1ib3R0 b206NS4wcHQiPg0KPHAgY2xhc3M9Ik1zb05vcm1hbCI+b3IgdGhlIHJldmlld2VycyBhc2tlZCB5 b3UgdG8gZG8gc28uIFRoZSBwcm9ibGVtIHdpdGggdGhpcyBpcyB0aGF0PG86cD48L286cD48L3A+ DQo8L2Jsb2NrcXVvdGU+DQo8YmxvY2txdW90ZSBzdHlsZT0ibWFyZ2luLXRvcDo1LjBwdDttYXJn aW4tYm90dG9tOjUuMHB0Ij4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiPnRoaXMgaXMgc29tZXdoYXQg aW4gY29uZmxpY3Qgd2l0aCB0aGUgJnF1b3Q7bGV0J3MgZm9jdXMgb24gdGhlIGNvcmU8bzpwPjwv bzpwPjwvcD4NCjwvYmxvY2txdW90ZT4NCjxibG9ja3F1b3RlIHN0eWxlPSJtYXJnaW4tdG9wOjUu MHB0O21hcmdpbi1ib3R0b206NS4wcHQiPg0KPHAgY2xhc3M9Ik1zb05vcm1hbCI+aXNzdWVzIGFu ZCBub3QgZ2V0IGRpc3RyYWN0ZWQgYnkgZGV0YWlscyBlYXJseSBvbiBpbiBhIHJldmlldyBjeWNs ZSZxdW90Oy48bzpwPjwvbzpwPjwvcD4NCjwvYmxvY2txdW90ZT4NCjxibG9ja3F1b3RlIHN0eWxl PSJtYXJnaW4tdG9wOjUuMHB0O21hcmdpbi1ib3R0b206NS4wcHQiPg0KPHAgY2xhc3M9Ik1zb05v cm1hbCI+SW4gb3RoZXIgd29yZHMsIHRoaXMgY2FuIG9ubHkgd29yaywgaWYgcmV2aWV3ZXJzIGZv Y3VzIG9uIG1ham9yPG86cD48L286cD48L3A+DQo8L2Jsb2NrcXVvdGU+DQo8YmxvY2txdW90ZSBz dHlsZT0ibWFyZ2luLXRvcDo1LjBwdDttYXJnaW4tYm90dG9tOjUuMHB0Ij4NCjxwIGNsYXNzPSJN c29Ob3JtYWwiPmlzc3VlcyBpbiBlYXJseSByZXZpZXdzIG9ubHkgYW5kIGRvIG5vdCBmb2N1cyBv biBzdHlsZSwgY29kaW5nPG86cD48L286cD48L3A+DQo8L2Jsb2NrcXVvdGU+DQo8YmxvY2txdW90 ZSBzdHlsZT0ibWFyZ2luLXRvcDo1LjBwdDttYXJnaW4tYm90dG9tOjUuMHB0Ij4NCjxwIGNsYXNz PSJNc29Ob3JtYWwiPnN0YW5kYXJkcywgZXRjLjxvOnA+PC9vOnA+PC9wPg0KPC9ibG9ja3F1b3Rl Pg0KPHAgY2xhc3M9Ik1zb05vcm1hbCI+PGJyPg0KJm5ic3A7Jm5ic3A7Jm5ic3A7QnV0IHRoaXMg ZG9lc24ndCBtYWtlIG11Y2ggc2Vuc2UgZWl0aGVyLCBiZWNhdXNlIHRoZW4gZnVsbCByZS1yZXZp ZXdzPGJyPg0KJm5ic3A7Jm5ic3A7Jm5ic3A7bmVlZCB0byBoYXBwZW4gYW55d2F5IG9uIGxhdGVy IHZlcnNpb25zLCB0byBhbHNvIGRlYWwgd2l0aCB0aGUgbWlub3I8YnI+DQombmJzcDsmbmJzcDsm bmJzcDtpc3N1ZXMuIEZvciBSRkMga2luZCBvZiBzZXJpZXMgb21pdHRpbmcgc3R5bGUgYW5kIGFs aWtlIGZlZWRiYWNrPGJyPg0KJm5ic3A7Jm5ic3A7Jm5ic3A7Y2VydGFpbmx5IG1ha2VzIHNlbnNl LCBidXQgYXMgc29vbiBhcyBhIHBhdGNoIGlzIG5vbi1SRkMsIGl0IHNob3VsZDxicj4NCiZuYnNw OyZuYnNwOyZuYnNwO2JlIGNvbnNpZGVyZWQgZ29vZCB0byBnbyBpbiBieSB0aGUgc3VibWl0dGVy Ljxicj4NCjxicj4NCk9LLCBJIHRoaW5rIHdlIGhhdmUgYSBkaXNjb25uZWN0IGJldHdlZW4gaWRl YWwgYW5kIHJlYWxpdHkuIDxicj4NCjxicj4NCkkgc2VlIHR3byBpc3N1ZXMgdG9kYXk8YnI+DQoq IEtleSBtYWludGFpbmVycyBkb24ndCBhbHdheXMgcmV2aWV3IFJGQyBzZXJpZXMgW3RoZXkgZW5k IHVwIGF0IHRoZSBib3R0b20gb2YgdGhlIHByaW9yaXR5IGxpc3QsIGV2ZW4gdGhvdWdoIHNwZW5k aW5nIHRpbWUgb24gUkZDcyB3aWxsIHNhdmUgdGltZSBlbHNld2hlcmUgbGF0ZXJdLiBTbyB0aGUg ZWZmZWN0IGlzIHRoYXQgdGhlbiB0aGUgY29udHJpYnV0b3IgYXNzdW1lcyB0aGVyZSBhcmUgbm8g bWFqb3IgaXNzdWVzIGFuZCBlbmRzIGl0IGFzDQogYSBwcm9wZXIgc2VyaWVzPGJyPg0KKiBJbiBw cmFjdGljZSB3aGF0IGhhcyBoYXBwZW5lZCBvZnRlbiBpbiB0aGUgcGFzdCBpcyB0aGF0IGRlc2ln biwgYXJjaGl0ZWN0dXJlLCBhc3N1bXB0aW9uIGZsYXdzIGFyZSBmb3VuZCBpbiBlYXJseSB2ZXJz aW9ucyBvZiBhIHNlcmllcy48YnI+DQombmJzcDsmbmJzcDstIFRoaXMgdXN1YWxseSBoYXBwZW5z IGJlY2F1c2Ugb2YgYW4gb3ZlcnNpZ2h0IG9yIGJlY2F1c2UgdGhlcmUgd2FzIG5vIGRlc2lnbiBk aXNjdXNzaW9uIHByaW9yIHRvIHRoZSBzZXJpZXMgYmVpbmcgcG9zdGVkIGFuZCBhZ3JlZWQ8YnI+ DQombmJzcDsmbmJzcDstIENvbW1vbiBzZW5zZSB3b3VsZCBkaWN0YXRlIHRoYXQgdGhlIGJpZ2dl c3QgYmVuZWZpdCBmb3IgYm90aCB0aGUgcmV2aWV3ZXIsIHRoZSBjb250cmlidXRvciBhbmQgdGhl IGNvbW11bml0eSBhcyBhIHdob2xlIHdvdWxkIGJlIHRvIHRyeSBhbmQgZm9jdXMgb24gc3VjaCBm bGF3cyBhbmQgbGVhdmUgZXZlcnl0aGluZyBhc2lkZTxicj4NCiZuYnNwOyZuYnNwOy0gT2YgY291 cnNlIHRoZXJlIG1heSBiZSB2YWx1ZSBpbiBkb2luZyBhIGRldGFpbGVkIHJldmlldyBvZiBwYXJ0 cyBvZiBzdWNoIGEgc2VyaWVzIGFzIHRoZXJlIG1heSBiZSBiaXRzIHRoYXQgYXJlIHVuYWZmZWN0 ZWQgYnkgc3VjaCBhIGZsYXc8YnI+DQombmJzcDsmbmJzcDstIEJ1dCB0aGVyZSB3aWxsIGxpa2Vs eSBiZSBwYXJ0cyB3aGljaCBhcmUgbm90OiBkb2luZyBhIGRldGFpbGVkIHJldmlldyBvZiBzdWNo IHBvcnRpb25zIHdhc3RlcyBldmVyeW9uZSdzIHRpbWU8YnI+DQo8YnI+DQpTbyBjb21pbmcgYmFj ayB0byB5b3VyIHBvaW50LiBJZGVhbGx5LCBpdCB3b3VsZCBiZSBuaWNlIGlmIHdlIGhhZCB0aGUg Y2FwYWJpbGl0eSB0byBjYWxsIG91dCBwYXJ0cyBvZiBhIHNlcmllcyBhcyAmcXVvdDtwcm9ibGVt YXRpYyZxdW90OyBhbmQgdHJlYXRpbmcgc3VjaCBwYXJ0cyBkaWZmZXJlbnRseS48bzpwPjwvbzpw PjwvcD4NCjwvZGl2Pg0KPC9ibG9ja3F1b3RlPg0KPGRpdj4NCjxwIGNsYXNzPSJNc29Ob3JtYWwi PjxvOnA+Jm5ic3A7PC9vOnA+PC9wPg0KPC9kaXY+DQo8ZGl2Pg0KPHAgY2xhc3M9Ik1zb05vcm1h bCI+Jm5ic3A7IFdlIG1heSBiZSBhYmxlIHRvIHJldXNlIHNvbWUgJnF1b3Q7U2hpZnQgTGVmdCZx dW90OyB0ZXJtaW5vbG9neSwgaW5jbHVkaW5nIGNpdGF0aW9ucyBvZiBwcmV2aW91cyBYZW4gY29k ZSByZXZpZXdzIHRvIGlsbHVzdHJhdGUgY2F0ZWdvcmllcyBvZiBkZXNpZ24gaXNzdWVzIHRoYXQg Y2FuIGJlIHNoaWZ0ZWQgbGVmdDo8bzpwPjwvbzpwPjwvcD4NCjwvZGl2Pg0KPGRpdj4NCjxwIGNs YXNzPSJNc29Ob3JtYWwiPiZuYnNwOyA8bzpwPjwvbzpwPjwvcD4NCjwvZGl2Pg0KPGRpdj4NCjxw IGNsYXNzPSJNc29Ob3JtYWwiPiZuYnNwOyZuYnNwOyZuYnNwOyA8YSBocmVmPSJodHRwczovL2Rl dm9wZWRpYS5vcmcvc2hpZnQtbGVmdCI+aHR0cHM6Ly9kZXZvcGVkaWEub3JnL3NoaWZ0LWxlZnQ8 L2E+PG86cD48L286cD48L3A+DQo8L2Rpdj4NCjxkaXY+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIj4m bmJzcDsgPG86cD48L286cD48L3A+DQo8L2Rpdj4NCjxkaXY+DQo8cCBjbGFzcz0iTXNvTm9ybWFs Ij5JIGxpa2UgdGhhdCBpZGVhLiBXZSBzZWVtIHRvIG5vdCBoYXZlIGNvbWUgdG8gYSBjb25jbHVz aW9uIG9uIHRoaXMgc3BlY2lmaWMgdG9waWMsIGJ1dCBtYXliZSBmb3Igbm93IGl0IGlzIHN1ZmZp Y2llbnQgdG8gY2FsbCB0aGlzIG91dCBhcyBhIHBvdGVudGlhbCBpc3N1ZSBpbiB0aGUgZ3VpZGUu PG86cD48L286cD48L3A+DQo8L2Rpdj4NCjxkaXY+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIj48bzpw PiZuYnNwOzwvbzpwPjwvcD4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiPkJlZm9yZSBJIHNlbmQgb3V0 IGEgbmV3IHZlcnNpb24sIGl0IHdvdWxkIGJlIGdvb2QgdG8gZ2V0IGF0IGxlYXN0IEphbuKAmXMg dmlldyBvbiB0aGUgaXNzdWUuDQo8bzpwPjwvbzpwPjwvcD4NCjxwIGNsYXNzPSJNc29Ob3JtYWwi PjxvOnA+Jm5ic3A7PC9vOnA+PC9wPg0KPHAgY2xhc3M9Ik1zb05vcm1hbCI+TGFyczxvOnA+PC9v OnA+PC9wPg0KPHAgY2xhc3M9Ik1zb05vcm1hbCI+PG86cD4mbmJzcDs8L286cD48L3A+DQo8L2Rp dj4NCjwvZGl2Pg0KPC9ib2R5Pg0KPC9odG1sPg0K --_000_FDC64A08D89444CB92449752D0FD17CDcitrixcom_-- --===============0202623679310461517== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Kd2luLXB2LWRl dmVsIG1haWxpbmcgbGlzdAp3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6 Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3dpbi1wdi1kZXZlbA== --===============0202623679310461517==-- From win-pv-devel-bounces@lists.xenproject.org Fri Nov 29 01:42:28 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 29 Nov 2019 01:42:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaVIi-0006U1-DU; Fri, 29 Nov 2019 01:42:28 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaVIh-0006Tq-II for win-pv-devel@lists.xenproject.org; Fri, 29 Nov 2019 01:42:27 +0000 X-Inumbo-ID: 7646888c-1249-11ea-a3db-12813bfff9fa Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7646888c-1249-11ea-a3db-12813bfff9fa; Fri, 29 Nov 2019 01:42:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1574991733; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=2L3P7kv7QF2OMEI/Xe33AF4k24sKIzC3Ey683gXL9tc=; b=IHCRu8dbndJSoA199LrXGTWkQQWtvXDtiHvPAcUGrSBkskGuKzurWDeJ I2pzcYR/IKfVz5qJVbCqIwlw/wCbHsJRrRzpcizt8FBOu4AGJIKcCf6dk yNwokaBw4xjSYxmXfkonHHDgQV7WNDroyHLw8YyARnvnOBa7zLiXK1FMG 4=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=lars.kurth@citrix.com; spf=Pass smtp.mailfrom=lars.kurth@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of lars.kurth@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="lars.kurth@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa6.hc3370-68.iphmx.com: domain of lars.kurth@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="lars.kurth@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: ZUHlnVgZRJvyEzqWOgr0Yj5xNVuIM9XbVCZF1T9FEBylrLLwuNHl53kcWOwR2ucjsFhf3qMqWn rBZkn+yKEFsK75qcVWcPnptIG+XKTPz2LKF+CN7vIVfBcxlH3LSqjDU5QFtzty25HuJxFfyBya /mrYbi0jFJ618pA0L9xQmJpvYKFG83WsIS0r+7MzMQ+5rYdz4ur9h7BmUUGB1Eqf/iaZykAZ4U Zm7zaXWW5ng2jHpP10fVicf6o0e7Gk75NPxM/bSgQcab6WHXPEgBjSZ90rR+FOTb8c+sqXvXUZ fpU= X-SBRS: 2.7 X-MesageID: 9380681 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.69,255,1571716800"; d="scan'208";a="9380681" From: Lars Kurth To: Stefano Stabellini , Lars Kurth Thread-Topic: [PATCH v2 6/6] Added Resolving Disagreement Thread-Index: AQHVdKIlkhvO00R580a3wEu9+2XsyaegEysAgAE6oQA= Date: Fri, 29 Nov 2019 01:42:07 +0000 Message-ID: <0A996712-6F49-489E-9504-5DD4A287182D@citrix.com> References: <2e4b36afaa73277d246d7e84037db1532a136ec7.1569525222.git.lars.kurth@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/10.10.10.191111 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted Content-ID: <43B3A8C2A96A8E4A82C1C4D94E4D9B96@citrix.com> MIME-Version: 1.0 Subject: Re: [win-pv-devel] [PATCH v2 6/6] Added Resolving Disagreement X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-api@lists.xenproject.org" , "minios-devel@lists.xenproject.org" , "committers@xenproject.org" , "mirageos-devel@lists.xenproject.org" , "xen-devel@lists.xenproject.org" , "win-pv-devel@lists.xenproject.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" DQoNCu+7v09uIDI3LzExLzIwMTksIDE4OjU2LCAiU3RlZmFubyBTdGFiZWxsaW5pIiA8c3N0YWJl bGxpbmlAa2VybmVsLm9yZz4gd3JvdGU6DQoNCiAgICBPbiBUaHUsIDI2IFNlcCAyMDE5LCBMYXJz IEt1cnRoIHdyb3RlOg0KICAgID4gRnJvbTogTGFycyBLdXJ0aCA8bGFycy5rdXJ0aEBjaXRyaXgu Y29tPg0KICAgID4gDQogICAgPiBUaGlzIGd1aWRlIHByb3ZpZGVzIEJlc3QgUHJhY3RpY2Ugb24g aWRlbnRpZnlpbmcgYW5kIHJlc29sdmluZw0KICAgID4gY29tbW9uIGNsYXNzZXMgb2YgZGlzYWdy ZWVtZW50DQogICAgPiANCiAgICA+IFNpZ25lZC1vZmYtYnk6IExhcnMgS3VydGggPGxhcnMua3Vy dGhAY2l0cml4LmNvbT4NCiAgICA+IC0tDQogICAgPiBDYzogbWluaW9zLWRldmVsQGxpc3RzLnhl bnByb2plY3Qub3JnDQogICAgPiBDYzogeGVuLWFwaUBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KICAg ID4gQ2M6IHdpbi1wdi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KICAgID4gQ2M6IG1pcmFn ZW9zLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQogICAgPiBDYzogY29tbWl0dGVyc0B4ZW5w cm9qZWN0Lm9yZw0KICAgID4gLS0tDQogICAgPiAgcmVzb2x2aW5nLWRpc2FncmVlbWVudC5tZCB8 IDE0NiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrDQogICAg PiAgMSBmaWxlIGNoYW5nZWQsIDE0NiBpbnNlcnRpb25zKCspDQogICAgPiAgY3JlYXRlIG1vZGUg MTAwNjQ0IHJlc29sdmluZy1kaXNhZ3JlZW1lbnQubWQNCiAgICA+IA0KICAgID4gZGlmZiAtLWdp dCBhL3Jlc29sdmluZy1kaXNhZ3JlZW1lbnQubWQgYi9yZXNvbHZpbmctZGlzYWdyZWVtZW50Lm1k DQogICAgPiBuZXcgZmlsZSBtb2RlIDEwMDY0NA0KICAgID4gaW5kZXggMDAwMDAwMC4uMTlhZWRi ZQ0KICAgID4gLS0tIC9kZXYvbnVsbA0KICAgID4gKysrIGIvcmVzb2x2aW5nLWRpc2FncmVlbWVu dC5tZA0KICAgID4gQEAgLTAsMCArMSwxNDYgQEANCiAgICA+ICsjIFJlc29sdmluZyBEaXNhZ3Jl ZW1lbnQNCiAgICA+ICsNCiAgICA+ICtUaGlzIGd1aWRlIHByb3ZpZGVzIEJlc3QgUHJhY3RpY2Ug b24gcmVzb2x2aW5nIGRpc2FncmVlbWVudCwgc3VjaCBhcw0KICAgID4gKyogR3JhY2VmdWxseSBh Y2NlcHQgY29uc3RydWN0aXZlIGNyaXRpY2lzbQ0KICAgID4gKyogRm9jdXMgb24gd2hhdCBpcyBi ZXN0IGZvciB0aGUgY29tbXVuaXR5DQogICAgPiArKiBSZXNvbHZlIGRpZmZlcmVuY2VzIGluIG9w aW5pb24gZWZmZWN0aXZlbHkNCiAgICA+ICsNCiAgICA+ICsjIyBUaGVvcnk6IFBhdWwgR3JhaGFt J3MgaGllcmFyY2h5IG9mIGRpc2FncmVlbWVudA0KICAgID4gK1BhdWwgR3JhaGFtIHByb3Bvc2Vk IGEgKipkaXNhZ3JlZW1lbnQgaGllcmFyY2h5KiogaW4gYSAyMDA4IGVzc2F5IA0KICAgID4gKyoq W0hvdyB0byBEaXNhZ3JlZV0oaHR0cDovL3d3dy5wYXVsZ3JhaGFtLmNvbS9kaXNhZ3JlZS5odG1s KSoqLCBwdXR0aW5nIHR5cGVzIG9mDQogICAgPiArYXJndW1lbnRzIGludG8gYSBzZXZlbi1wb2lu dCBoaWVyYXJjaHkgYW5kIG9ic2VydmluZyB0aGF0ICptb3ZpbmcgdXAgdGhlDQogICAgPiArZGlz YWdyZWVtZW50IGhpZXJhcmNoeSBtYWtlcyBwZW9wbGUgbGVzcyBtZWFuLCBhbmQgd2lsbCBtYWtl IG1vc3Qgb2YgdGhlbSBoYXBwaWVyKi4NCiAgICA+ICtHcmFoYW0gYWxzbyBzdWdnZXN0ZWQgdGhh dCB0aGUgaGllcmFyY2h5IGNhbiBiZSB0aG91Z2h0IG9mIGFzIGEgcHlyYW1pZCwgYXMgdGhlIA0K ICAgID4gK2hpZ2hlc3QgZm9ybXMgb2YgZGlzYWdyZWVtZW50IGFyZSByYXJlci4NCiAgICA+ICsN CiAgICA+ICt8ICFbR3JhaGFtJ3MgSGllcmFyY2h5IG9mIERpc2FncmVlbWVuXShodHRwczovL3Vw bG9hZC53aWtpbWVkaWEub3JnL3dpa2lwZWRpYS9jb21tb25zL2EvYTMvR3JhaGFtJTI3c19IaWVy YXJjaHlfb2ZfRGlzYWdyZWVtZW50LWVuLnN2ZykgfA0KICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgXiBEaXNhZ3JlZW1lbnQNCiAgICANCiAgICBUaGlzIGlzIGEgTklUIGJ1dCBpbiBh IGZldyBwbGFjZXMgaW4gdGhpcyBzZXJpZXMgeW91IGdvIG92ZXIgdGhlDQogICAgb3JpZ2luYWwg bGluZSBsZW5ndGguDQoNClRydWU6IHR5cGljYWxseSBmb3IgVVJMcy4gUHJpbWFyaWx5IGJlY2F1 c2UgSSBkb24ndCBrbm93IHdoZXRoZXIgdGhleSBhcmUgcmVuZGVyZWQgY29ycmVjdGx5IHdoZW4g c3BsaXQNCiAgICANCiAgICA+ICt8ICpBIHJlcHJlc2VudGF0aW9uIG9mIEdyYWhhbSdzIGhpZXJh cmNoeSBvZiBkaXNhZ3JlZW1lbnQgZnJvbSBbTG91ZGFjcmlzXShodHRwOi8vd3d3LmNyZWF0ZWRl YmF0ZS5jb20vdXNlci92aWV3cHJvZmlsZS9Mb3VkYWNyaXMpIG1vZGlmaWVkIGJ5IFtSb2NrZXQw MDBdKGh0dHBzOi8vZW4ud2lraXBlZGlhLm9yZy93aWtpL1VzZXI6Um9ja2V0MDAwKSogfA0KICAg ID4gKw0KICAgID4gK0luIHRoZSBjb250ZXh0IG9mIHRoZSBYZW4gUHJvamVjdCB3ZSBzdHJpdmUg dG8gKipvbmx5IHVzZSB0aGUgdG9wIGhhbGYqKiBvZiB0aGUgaGllcmFyY2h5Lg0KICAgID4gKyoq TmFtZS1jYWxsaW5nKiogYW5kICoqQWQgaG9taW5lbSoqIGFyZ3VtZW50cyBhcmUgbm90IGFjY2Vw dGFibGUgd2l0aGluIHRoZSBYZW4NCiAgICA+ICtQcm9qZWN0Lg0KICAgID4gKw0KICAgID4gKyMj IElzc3VlOiBTY29wZSBjcmVlcA0KICAgID4gKw0KICAgID4gK09uZSB0aGluZyB3aGljaCBvY2Nh c2lvbmFsbHkgaGFwcGVucyBkdXJpbmcgY29kZSByZXZpZXcgaXMgdGhhdCBhIGNvZGUgcmV2aWV3 ZXINCiAgICA+ICthc2tzIG9yIGFwcGVhcnMgdG8gYXNrIHRoZSBhdXRob3Igb2YgcGF0Y2ggdG8g aW1wbGVtZW50IGFkZGl0aW9uYWwgZnVuY3Rpb25hbGl0eS4NCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBeIGEgcGF0Y2ggICAgICAgICAgICAgICAgICAgICAgXiBm dW5jdGlvbmFsaXRpZXMgDQogICAgDQogICAgDQogICAgPiArVGhpcyBjb3VsZCB0YWtlIGZvciBl eGFtcGxlIHRoZSBmb3JtIG9mDQogICAgPiArPiBEbyB5b3UgdGhpbmsgaXQgd291bGQgYmUgdXNl ZnVsIGZvciB0aGUgY29kZSB0byBkbyBYWFg/IA0KICAgID4gKz4gSSBjYW4gaW1hZ2luZSBhIHVz ZXIgd2FudGluZyB0byBkbyBZWVkgKGFuZCBYWFggd291bGQgZW5hYmxlIHRoaXMpDQogICAgPiAr DQogICAgPiArVGhhdCBwb3RlbnRpYWxseSBhZGRzIGFkZGl0aW9uYWwgd29yayBmb3IgdGhlIGNv ZGUgYXV0aG9yLCB3aGljaCB0aGV5IG1heSBub3QgaGF2ZQ0KICAgID4gK3RoZSB0aW1lIHRvIHBl cmZvcm0uIEl0IGlzIGdvb2QgcHJhY3RpY2UgZm9yIGF1dGhvcnMgdG8gY29uc2lkZXIgc3VjaCBh IHJlcXVlc3QgaW4gdGVybXMgb2YNCiAgICA+ICsqIFVzZWZ1bG5lc3MgdG8gdGhlIHVzZXINCiAg ICA+ICsqIENvZGUgY2h1cm4sIGNvbXBsZXhpdHkgb3IgaW1wYWN0IG9uIG90aGVyIHN5c3RlbSBw cm9wZXJ0aWVzDQogICAgPiArKiBFeHRyYSB0aW1lIHRvIGltcGxlbWVudCBhbmQgcmVwb3J0IGJh Y2sgdG8gdGhlIHJldmlld2VyDQogICAgPiArDQogICAgPiArSWYgeW91IGJlbGlldmUgdGhhdCB0 aGUgaW1wYWN0L2Nvc3QgaXMgdG9vIGhpZ2gsIHJlcG9ydCBiYWNrIHRvIHRoZSByZXZpZXdlci4g VG8gcmVzb2x2ZQ0KICAgID4gK3RoaXMsIGl0IGlzIGFkdmlzYWJsZSB0bw0KICAgID4gKyogUmVw b3J0IHlvdXIgZmluZGluZ3MNCiAgICA+ICsqIEFuZCB0aGVuIGNoZWNrIHdoZXRoZXIgdGhpcyB3 YXMgbWVyZWx5IGFuIGludGVyZXN0aW5nIHN1Z2dlc3Rpb24sIG9yIHNvbWV0aGluZyB0aGUNCiAg ICA+ICtyZXZpZXdlciBmZWVscyBtb3JlIHN0cm9uZ2x5IGFib3V0DQogICAgPiArDQogICAgPiAr SW4gdGhlIGxhdHRlciBjYXNlLCB0aGVyZSBhcmUgdHlwaWNhbGx5IHNldmVyYWwgY29tbW9uIG91 dGNvbWVzDQogICAgPiArKiBUaGUgKiphdXRob3IgYW5kIHJldmlld2VyIGFncmVlKiogdGhhdCB0 aGUgc3VnZ2VzdGlvbiBzaG91bGQgYmUgaW1wbGVtZW50ZWQNCiAgICA+ICsqIFRoZSAqKmF1dGhv ciBhbmQgcmV2aWV3ZXIgYWdyZWUqKiB0aGF0IGl0IG1heSBtYWtlIHNlbnNlIHRvIGRlZmVyIGlt cGxlbWVudGF0aW9uDQogICAgPiArKiBUaGUgKiphdXRob3IgYW5kIHJldmlld2VyIGFncmVlKiog dGhhdCBpdCBtYWtlcyBubyBzZW5zZSB0byBpbXBsZW1lbnQgdGhlIHN1Z2dlc3Rpb24NCiAgICA+ ICsNCiAgICA+ICtUaGUgYXV0aG9yIG9mIGEgcGF0Y2ggd291bGQgdHlwaWNhbGx5IHN1Z2dlc3Qg dGhlaXIgcHJlZmVycmVkIG91dGNvbWUsIGZvciBleGFtcGxlDQogICAgPiArPiBJIGFtIG5vdCBz dXJlIGl0IGlzIHdvcnRoIHRvIGltcGxlbWVudCBYWFgNCiAgICA+ICs+IERvIHlvdSB0aGluayB0 aGlzIGNvdWxkIGJlIGRvbmUgYXMgYSBzZXBhcmF0ZSBwYXRjaCBpbiBmdXR1cmU/DQogICAgPiAr DQogICAgPiArSW4gY2FzZXMsIHdoZXJlIG5vIGFncmVlbWVudCBjYW4gYmUgZm91bmQsIHRoZSBi ZXN0IGFwcHJvYWNoIHdvdWxkIGJlIHRvIGdldCBhbg0KICAgID4gK2luZGVwZW5kZW50IG9waW5p b24gZnJvbSBhbm90aGVyIG1haW50YWluZXIgb3IgdGhlIHByb2plY3QncyBsZWFkZXJzaGlwIHRl YW0uDQogICAgDQogICAgSSB0aGluayB3ZSBzaG91bGQgbWVudGlvbiBzb21ld2hlcmUgaGVyZSB0 aGF0IGl0IGlzIHJlY29tbWVuZGVkIGZvcg0KICAgIHJldmlld2VycyB0byBiZSBleHBsaWNpdCBh Ym91dCB3aGV0aGVyIGEgcmVxdWVzdCBpcyBvcHRpb25hbCBvciB3aGV0aGVyDQogICAgaXQgaXMg YSByZXF1aXJlbWVudC4NCiAgICANCiAgICBGb3IgaW5zdGFuY2U6ICJJIHRoaW5rIGl0IHdvdWxk IGJlIGdvb2QgaWYgWCBhbHNvIGRpZCBZIiBkb2Vzbid0IHNheSBpZg0KICAgIGl0IGlzIG9wdGlv bmFsIChmdXR1cmUgd29yaykgb3IgaXQgaXMgYWN0dWFsbHkgcmVxdWlyZWQgYXMgcGFydCBvZiB0 aGlzDQogICAgc2VyaWVzLiBNb3JlIGV4cGxpY2l0IHdvcmQgY2hvaWNlcyBhcmUgcHJlZmVyYWJs ZSwgc3VjaCBhczoNCiAgICANCiAgICAiSSB0aGluayBpdCB3b3VsZCBiZSBnb29kIGlmIFggYWxz byBkaWQgWSwgbm90IGEgcmVxdWlyZW1lbnQgYnV0IGdvb2QgdG8NCiAgICBoYXZlLiINCiAgICAN CiAgICAiSSB0aGluayBpdCB3b3VsZCBiZSBnb29kIGlmIFggYWxzbyBkaWQgWSBhbmQgaXQgc2hv dWxkIGJlIHBhcnQgb2YgdGhpcw0KICAgIHNlcmllcy4iDQogICAgDQogICAgSXQgaGVscHMgbWFr ZSB0aGUgY29tbXVuaWNhdGlvbiB3aXRoIHRoZSBhdXRob3IgbW9yZSBlZmZlY3RpdmUsDQogICAg ZXNwZWNpYWxseSBpbiB0aGlzIGtpbmQgb2Ygc2l0dWF0aW9ucy4NCiAgICANCkFncmVlZCAgICAN Cg0KICAgID4gKyMjIElzc3VlOiBbQmlrZXNoZWRkaW5nXShodHRwczovL2VuLndpa3Rpb25hcnku b3JnL3dpa2kvYmlrZXNoZWRkaW5nKQ0KICAgID4gKw0KICAgID4gK09jY2FzaW9uYWxseSBkaXNj dXNzaW9ucyBhYm91dCB1bmltcG9ydGFudCBidXQgZWFzeS10by1ncmFzcCBpc3N1ZXMgY2FuIGxl YWQgdG8NCiAgICA+ICtwcm9sb25nZWQgYW5kIHVucHJvZHVjdGl2ZSBkaXNjdXNzaW9uLiBUaGUg YmVzdCB3YXkgdG8gYXBwcm9hY2ggdGhpcyBpcyB0bw0KICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIF4gZGlzY3Vzc2lvbnMNCiAgICANCiAgICANCiAgICA+ICt0cnkgYW5kICoqYW50 aWNpcGF0ZSoqIGJpa2VzaGVkZGluZyBhbmQgaGlnaGxpZ2h0IGl0IGFzIHN1Y2ggdXBmcm9udC4g SG93ZXZlciwgdGhlDQogICAgPiArZm9ybWF0IG9mIGEgY29kZSByZXZpZXcgZG9lcyBub3QgYWx3 YXlzIGxlbmQgaXRzZWxmIHdlbGwgdG8gdGhpcyBhcHByb2FjaCwgZXhjZXB0DQogICAgPiArZm9y IGhpZ2hsaWdodGluZyBpdCBpbiB0aGUgY292ZXIgbGV0dGVyIG9mIGEgcGF0Y2ggc2VyaWVzLg0K ICAgID4gKw0KICAgID4gK0hvd2V2ZXIsIHR5cGljYWxseSBCaWtlc2hlZGRpbmcgaXNzdWVzIGFy ZSBmYWlybHkgZWFzeSB0byByZWNvZ25pemUgaW4gYSBjb2RlIHJldmlldywNCiAgICA+ICthcyB5 b3Ugd2lsbCB2ZXJ5IHF1aWNrbHkgZ2V0IGRpZmZlcmVudCByZXZpZXdlcnMgcHJvdmlkaW5nIGRp ZmZlcmluZyBvcGluaW9ucy4gSW4gdGhpcyBjYXNlDQogICAgPiAraXQgaXMgYmVzdCBmb3IgdGhl IGF1dGhvciBvciBhIHJldmlld2VyIHRvIGNhbGwgb3V0IHRoZSBwb3RlbnRpYWwgYmlrZXNoZWRk aW5nIGlzc3VlIHVzaW5nDQogICAgPiArc29tZXRoaW5nIGxpa2UNCiAgICA+ICsNCiAgICA+ICs+ IExvb2tzIHdlIGhhdmUgYSBiaWtlc2hlZGRpbmcgaXNzdWUgaGVyZQ0KICAgID4gKz4gSSB0aGlu ayB3ZSBzaG91bGQgY2FsbCBhIHF1aWNrIHZvdGUgdG8gc2V0dGxlIHRoZSBpc3N1ZQ0KICAgID4g Kw0KICAgID4gK091ciBnb3Zlcm5hbmNlIHByb3ZpZGVzIHRoZSBtZWNoYW5pc21zIG9mIFtpbmZv cm1hbCB2b3Rlc10oaHR0cHM6Ly94ZW5wcm9qZWN0Lm9yZy9kZXZlbG9wZXJzL2dvdmVybmFuY2Uv I2luZm9ybWFsLXZvdGVzLW9yLXN1cnZleXMpIG9yDQogICAgPiArW2xhenkgdm90aW5nXShodHRw czovL3hlbnByb2plY3Qub3JnL2RldmVsb3BlcnMvZ292ZXJuYW5jZS8jbGF6eWNvbnNlbnN1cykg d2hpY2ggbGVuZA0KICAgID4gK3RoZW1zZWx2ZXMgd2VsbCB0byByZXNvbHZlIHN1Y2ggaXNzdWVz Lg0KICAgID4gKw0KICAgID4gKyMjIElzc3VlOiBTbWFsbCBmdW5jdGlvbmFsIGlzc3Vlcw0KICAg ID4gKw0KICAgID4gK1RoZSBtb3N0IGNvbW1vbiBhcmVhIG9mIGRpc2FncmVlbWVudHMgd2hpY2gg aGFwcGVuIGluIGNvZGUgcmV2aWV3cywgYXJlIGRpZmZlcmluZw0KICAgID4gK29waW5pb25zIG9u IHdoZXRoZXIgc21hbGwgZnVuY3Rpb25hbCBpc3N1ZXMgaW4gYSBwYXRjaCBzZXJpZXMgaGF2ZSB0 byBiZSByZXNvbHZlZCBvcg0KICAgID4gK25vdCBiZWZvcmUgdGhlIGNvZGUgaXMgcmVhZHkgdG8g YmUgc3VibWl0dGVkLiBTdWNoIGRpc2FncmVlbWVudHMgYXJlIHR5cGljYWxseSBjYXVzZWQNCiAg ICA+ICtieSBkaWZmZXJlbnQgZXhwZWN0YXRpb25zIHJlbGF0ZWQgdG8gdGhlIGxldmVsIG9mIHBl cmZlY3Rpb24gYSBwYXRjaCBzZXJpZXMgbmVlZHMgdG8gZnVsZmlsDQogICAgPiArYmVmb3JlIGl0 IGNhbiBiZSBjb25zaWRlcmVkIHJlYWR5IHRvIGJlIGNvbW1pdHRlZC4NCiAgICA+ICsNCiAgICA+ ICtUbyBleHBsYWluIHRoaXMgYmV0dGVyLCBJIGFtIGdvaW5nIHRvIHVzZSB0aGUgYW5hbG9neSBv ZiBzb21lIGJ1aWxkaW5nIHdvcmsgdGhhdCBoYXMNCiAgICA+ICtiZWVuIHBlcmZvcm1lZCBhdCB5 b3VyIGhvdXNlLiBMZXQncyBzYXkgdGhhdCB5b3UgaGF2ZSBhIG5ldyBiYXRocm9vbSBpbnN0YWxs ZWQuDQogICAgPiArQmVmb3JlIHBheWluZyB5b3VyIGJ1aWxkZXIgdGhlIGxhc3QgaW5zdGFsbWVu dCwgeW91IHBlcmZvcm0gYW4gaW5zcGVjdGlvbiBhbmQgeW91IGZpbmQNCiAgICA+ICtpc3N1ZXMg c3VjaCBhcw0KICAgID4gKyogVGhlIHNlYWxzIGFyb3VuZCB0aGUgYmF0aHR1YiBhcmUgbm90IHBl cmZlY3RseSBldmVudA0KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBeIGV2ZW4NCiAgICANCiAgICA+ICsqIFdoZW4geW91IG9wZW4gdGhlIHRh cCwgdGhlIHBsdW1iaW5nIGluaXRpYWxseSBtYWtlcyBzb21lIGxvdWQgbm9pc2UNCiAgICA+ICsq IFRoZSBzaG93ZXIgbWl4ZXIgaGFzIGJlZW4gaW5zdGFsbGVkIHRoZSB3cm9uZyB3YXkgYXJvdW5k DQogICAgPiArDQogICAgPiArSW4gYWxsIHRoZXNlIGNhc2VzLCB0aGUgYmF0aHJvb20gaXMgcGVy ZmVjdGx5IGZ1bmN0aW9uYWwsIGJ1dCBub3QgcGVyZmVjdC4gQXQgdGhpcyBwb2ludA0KICAgID4g K3lvdSBoYXZlIHRoZSBjaG9pY2UgdG8gdHJ5IGFuZCBnZXQgYWxsIHRoZSBpc3N1ZXMgYWRkcmVz c2VkLCB3aGljaCBpbiB0aGUgZXhhbXBsZSBvZg0KICAgID4gK3RoZSBzaG93ZXIgbWl4ZXIgbWF5 IHJlcXVpcmUgc2lnbmlmaWNhbnQgcmUtd29yayBhbmQgcG90ZW50aWFsbHkgcHVzaC1iYWNrIGZy b20geW91cg0KICAgID4gK2J1aWxkZXIuIFlvdSBtYXkgaGF2ZSB0byByZWZlciB0byB0aGUgaW5p dGlhbCBzdGF0ZW1lbnQgb2Ygd29yaywgYnV0IGl0IHR1cm5zIG91dCBpdCBkb2VzDQogICAgPiAr bm90IGNvbnRhaW4gc3VmZmljaWVudCBpbmZvcm1hdGlvbiB0byBhc2NlcnRhaW4gd2hldGhlciB5 b3VyIGJ1aWxkZXIgaGFkIGNvbW1pdHRlZCB0bw0KICAgID4gK3RoZSBsZXZlbCBvZiBxdWFsaXR5 IHlvdSB3ZXJlIGV4cGVjdGluZy4NCiAgICA+ICsNCiAgICA+ICtTaW1pbGFyIHNpdHVhdGlvbnMg aGFwcGVuIGluIGNvZGUgcmV2aWV3cyB2ZXJ5IGZyZXF1ZW50bHkgYW5kIGNhbiBsZWFkIHRvIGEg bG9uZw0KICAgID4gK2Rpc2N1c3Npb24gYmVmb3JlIGl0IGNhbiBiZSByZXNvbHZlZC4gVGhlIG1v c3QgaW1wb3J0YW50IHRoaW5nIGlzIHRvICoqaWRlbnRpZnkqKg0KICAgID4gK2EgZGlzYWdyZWVt ZW50IGFzIHN1Y2ggZWFybHkgYW5kIHRoZW4gY2FsbCBpdCBvdXQuIFRpcHMgb24gaG93IHRvIGRv IHRoaXMsIGNhbiBiZSBmb3VuZA0KICAgID4gK1toZXJlXShjb21tdW5pY2F0aW9uLXByYWN0aWNl Lm1kI01pc3VuZGVyc3RhbmRpbmdzKS4NCiAgICA+ICsNCiAgICA+ICtBdCB0aGlzIHBvaW50LCB5 b3Ugd2lsbCB1bmRlcnN0YW5kIHdoeSB5b3UgaGF2ZSB0aGUgZGlzYWdyZWVtZW50LCBidXQgbm90 IG5lY2Vzc2FyaWx5DQogICAgPiArYWdyZWVtZW50IG9uIGhvdyB0byBtb3ZlIGZvcndhcmQuIEFu IGVhc3kgZml4IHdvdWxkIGJlIHRvIGFncmVlIHRvIHN1Ym1pdCB0aGUgY2hhbmdlDQogICAgPiAr YXMgaXQgaXMgYW5kIGZpeCBpdCBpbiBmdXR1cmUuIEluIGEgY29ycG9yYXRlIHNvZnR3YXJlIGVu Z2luZWVyaW5nIGVudmlyb25tZW50IHRoaXMgaXMgdGhlDQogICAgPiArbW9zdCBsaWtlbHkgb3V0 Y29tZSwgYnV0IGluIG9wZW4gc291cmNlIGNvbW11bml0aWVzIGFkZGl0aW9uYWwgY29uY2VybnMg aGF2ZSB0byBiZQ0KICAgID4gK2NvbnNpZGVyZWQuDQogICAgPiArKiBDb2RlIHJldmlld2VycyBm cmVxdWVudGx5IGhhdmUgYmVlbiBpbiB0aGlzIHNpdHVhdGlvbiBiZWZvcmUgd2l0aCB0aGUgbW9z dCBjb21tb24NCiAgICA+ICsgIG91dGNvbWUgdGhhdCB0aGUgaXNzdWUgaXMgdGhlbiBuZXZlciBm aXhlZC4gQnkgYWNjZXB0aW5nIHRoZSBjaGFuZ2UsIHRoZSByZXZpZXdlcnMNCiAgICA+ICsgIGhh dmUgbm8gbGV2ZXJhZ2UgdG8gZml4IHRoZSBpc3N1ZSBhbmQgbWF5IGhhdmUgdG8gc3BlbmQgZWZm b3J0IGZpeGluZyB0aGUgaXNzdWUNCiAgICA+ICsgIHRoZW1zZWx2ZXMgaW4gZnV0dXJlIGFzIGl0 IG1heSBpbXBhY3QgdGhlIHByb2R1Y3QgdGhleSBidWlsdCBvbiB0b3Agb2YgdGhlIGNvZGUuDQog ICAgPiArKiBDb252ZXJzZWx5LCBhIHJldmlld2VyIG1heSBiZSBhc2tpbmcgdGhlIGF1dGhvciB0 byBtYWtlIHRvbyBtYW55IGNoYW5nZXMgb2YgdGhpcw0KICAgID4gKyAgdHlwZSB3aGljaCB1bHRp bWF0ZWx5IG1heSBsZWFkIHRoZSBhdXRob3IgdG8gbm90IGNvbnRyaWJ1dGUgdG8gdGhlIHByb2pl Y3QgYWdhaW4uDQogICAgPiArKiBBbiBhdXRob3IsIHdoaWNoIGNvbnNpc3RlbnRseSBkb2VzIG5v dCBhZGRyZXNzICoqYW55Kiogb2YgdGhlc2UgaXNzdWVzIG1heSBlbmQgdXANCiAgICA+ICsgIGdl dHRpbmcgYSBiYWQgcmVwdXRhdGlvbiBhbmQgbWF5IGZpbmQgZnV0dXJlIGNvZGUgcmV2aWV3cyBt b3JlIGRpZmZpY3VsdC4NCiAgICA+ICsqIEFuIGF1dGhvciB3aGljaCBhbHdheXMgYWRkcmVzc2Vz ICoqYWxsKiogb2YgdGhlc2UgaXNzdWVzIG1heSBlbmQgdXAgZ2V0dGluZyBpbnRvDQogICAgPiAr ICBkaWZmaWN1bHRpZXMgd2l0aCB0aGVpciBlbXBsb3llciwgYXMgdGhleSBhcmUgdG9vIHNsb3cg Z2V0dGluZyBjb2RlIHVwc3RyZWFtZWQuDQogICAgPiArDQogICAgPiArTm9uZSBvZiB0aGVzZSBv dXRjb21lcyBhcmUgZ29vZCwgc28gdWx0aW1hdGVseSBhIGJhbGFuY2UgaGFzIGJlZW4gZm91bmQu IEF0IHRoZSBlbmQNCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBeIHlvdSBtZWFuICJoYXMgdG8gYmUgZm91bmQ/Ig0KICAgIA0K ICAgIA0KICAgID4gK29mIHRoZSBkYXksIHRoZSBzb2x1dGlvbiBzaG91bGQgZm9jdXMgb24gd2hh dCBpcyBiZXN0IGZvciB0aGUgY29tbXVuaXR5LCB3aGljaCBtYXkNCiAgICA+ICttZWFuIGFza2lu ZyBmb3IgYW4gaW5kZXBlbmRlbnQgb3BpbmlvbiBhcyBvdXRsaW5lZCBpbiB0aGUgbmV4dCBzZWN0 aW9uLg0KICAgIA0KICAgIEkgdGhpbmsgdGhlcmUgaXMgc29tZXRoaW5nIGVsc2Ugd2Ugc2hvdWxk IHNheSBvbiB0aGlzIHRvcGljLiBUaGVyZSBpcyBhDQogICAgY2F0ZWdvcnkgb2YgdGhpbmdzIHdo aWNoIGNvdWxkIGJlIGRvbmUgaW4gbXVsdGlwbGUgd2F5cyBhbmQgaXQgaXMgbm90DQogICAgb3Zl cnRseSBvYnZpb3VzIHdoaWNoIG9uZSBpcyBiZXN0LiBJdCBpcyBkb25lIHRvIHRoZSBtYWludGFp bmVyIGFuZCB0aGUNCiAgICBhdXRob3IgcGVyc29uYWwgc3R5bGVzLiBJdCBpcyBlYXN5IHRvIGRp c2FncmVlIG9uIHRoYXQuDQogICAgDQogICAgSSB0aGluayBhIGdvb2QgcmVjb21tZW5kYXRpb24g d291bGQgYmUgZm9yIHRoZSBjb250cmlidXRvciB0byB0cnkgdG8NCiAgICBmb2xsb3cgdGhlIG1h aW50YWluZXJzIHJlcXVlc3RzLCBldmVuIGlmIHRoZXkgY291bGQgYmUgY29uc2lkZXJlZA0KICAg ICJzdHlsZSIsIHRydXN0aW5nIHRoZWlyIGV4cGVyaWVuY2Ugb24gdGhlIG1hdHRlci4gQW5kIGEg Z29vZA0KICAgIHJlY29tbWVuZGF0aW9uIGZvciB0aGUgbWFpbnRhaW5lciB3b3VsZCBiZSB0byB0 cnkgdG8gbGV0IHRoZSBjb250cmlidXRvcg0KICAgIGhhdmUgZnJlZWRvbSBvZiBpbXBsZW1lbnRh dGlvbiBjaG9pY2Ugb24gdGhpbmdzIHRoYXQgZG9uJ3QgbWFrZSBhDQogICAgc2lnbmlmaWNhbnQg ZGlmZmVyZW5jZS4NCiAgICANCkFncmVlZC4NCiAgICANCiAgICA+ICsjIyBSZXNvbHV0aW9uOiBB c2tpbmcgZm9yIGFuIGluZGVwZW5kZW50IG9waW5pb24NCiAgICA+ICsNCiAgICA+ICtNb3N0IGRp c2FncmVlbWVudHMgY2FuIGJlIHNldHRsZWQgYnkNCiAgICA+ICsqIEFza2luZyBhbm90aGVyIG1h aW50YWluZXIgb3IgY29tbWl0dGVyIHRvIHByb3ZpZGUgYW4gaW5kZXBlbmRlbnQgb3BpbmlvbiBv biB0aGUNCiAgICA+ICsgIHNwZWNpZmljIGlzc3VlIGluIHB1YmxpYyB0byBoZWxwIHJlc29sdmUg aXQNCiAgICA+ICsqIEZhaWxpbmcgdGhpcyBhbiBpc3N1ZSBjYW4gYmUgZXNjYWxhdGVkIHRvIHRo ZSBwcm9qZWN0IGxlYWRlcnNoaXAgdGVhbSwgd2hpY2ggaXMNCiAgICA+ICsgIGV4cGVjdGVkIHRv IGFjdCBhcyByZWZlcmVlIGFuZCBtYWtlIGEgZGVjaXNpb24gb24gYmVoYWxmIG9mIHRoZSBjb21t dW5pdHkNCiAgICA+ICsNCiAgICA+ICtJZiB5b3UgZmVlbCB1bmNvbWZvcnRhYmxlIHdpdGggdGhp cyBhcHByb2FjaCwgeW91IG1heSBhbHNvIGNvbnRhY3QNCiAgICA+ICttZWRpYXRpb25AeGVucHJv amVjdC5vcmcgdG8gZ2V0IGFkdmljZS4gU2VlIG91ciBbQ29tbXVuaWNhdGlvbiBHdWlkZV0oY29t bXVuaWNhdGlvbi1ndWlkZS5tZCkNCiAgICA+ICtmb3IgbW9yZSBpbmZvcm1hdGlvbi4NCiAgICA+ ICsNCiAgICA+ICsjIyBEZWNpc2lvbiBtYWtpbmcgYW5kIGNvbmZsaWN0IHJlc29sdXRpb24gaW4g b3VyIGdvdmVybmFuY2UNCiAgICA+ICsNCiAgICA+ICtPdXIgW2dvdmVybmFuY2VdKGh0dHBzOi8v eGVucHJvamVjdC5vcmcvZGV2ZWxvcGVycy9nb3Zlcm5hbmNlLyNkZWNpc2lvbnMpIGNvbnRhaW5z DQogICAgPiArc2V2ZXJhbCBwcm92ZW4gbWVjaGFuaXNtcyB0byBoZWxwIHdpdGggZGVjaXNpb24g bWFraW5nIGFuZCBjb25mbGljdCByZXNvbHV0aW9uLg0KICAgID4gKw0KICAgID4gK1NlZQ0KICAg ID4gKyogW0V4cHJlc3NpbmcgYWdyZWVtZW50IGFuZCBkaXNhZ3JlZW1lbnRdKGh0dHBzOi8veGVu cHJvamVjdC5vcmcvZGV2ZWxvcGVycy9nb3Zlcm5hbmNlLyNleHByZXNzaW5nb3BpbmlvbikNCiAg ICA+ICsqIFtMYXp5IGNvbnNlbnN1cyAvIExhenkgdm90aW5nXShodHRwczovL3hlbnByb2plY3Qu b3JnL2RldmVsb3BlcnMvZ292ZXJuYW5jZS8jbGF6eWNvbnNlbnN1cykNCiAgICA+ICsqIFtJbmZv cm1hbCB2b3RlcyBvciBzdXJ2ZXlzXShodHRwczovL3hlbnByb2plY3Qub3JnL2RldmVsb3BlcnMv Z292ZXJuYW5jZS8jaW5mb3JtYWwtdm90ZXMtb3Itc3VydmV5cykNCiAgICA+ICsqIFtMZWFkZXJz aGlwIHRlYW0gZGVjaXNpb25zXShodHRwczovL3hlbnByb2plY3Qub3JnL2RldmVsb3BlcnMvZ292 ZXJuYW5jZS8jbGVhZGVyc2hpcCkNCiAgICA+ICsqIFtDb25mbGljdCByZXNvbHV0aW9uXShodHRw czovL3hlbnByb2plY3Qub3JnL2RldmVsb3BlcnMvZ292ZXJuYW5jZS8jY29uZmxpY3QpDQogICAg PiAtLSANCiAgICA+IDIuMTMuMA0KICAgID4gDQogICAgDQoNCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCndpbi1wdi1kZXZlbCBtYWlsaW5nIGxpc3QKd2lu LXB2LWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5v cmcvbWFpbG1hbi9saXN0aW5mby93aW4tcHYtZGV2ZWw= From win-pv-devel-bounces@lists.xenproject.org Fri Nov 29 01:51:25 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 29 Nov 2019 01:51:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaVRN-0007bk-8p; Fri, 29 Nov 2019 01:51:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaVRL-0007bX-Ut for win-pv-devel@lists.xenproject.org; Fri, 29 Nov 2019 01:51:23 +0000 X-Inumbo-ID: b5e963a0-124a-11ea-a55d-bc764e2007e4 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b5e963a0-124a-11ea-a55d-bc764e2007e4; Fri, 29 Nov 2019 01:51:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1574992268; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=dvXwHZySBmHOdhS+WEP9343A3DX5FkkP1OgHEKlhCNA=; b=dJ7p6o8vAmKRnG5h+uMxjvDyyNzrkZ1LJ5MRs5nbiwTGXJsXAn9a7rEx H1WVaBcH8T1pjG4vlBi6JxhjYvpQMd9uOXlusw21SvN0auiDNgid0z/r9 gkh+GVjLDzlaorHllbgTkG8FqJktaCMgZoDQBopxzl/G110CcIb5sokN+ 0=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=lars.kurth@citrix.com; spf=Pass smtp.mailfrom=lars.kurth@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of lars.kurth@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="lars.kurth@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of lars.kurth@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="lars.kurth@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: sVWnWrW6qUX1A0sc+Zb+wLrtSltH3GvRc/o1Y05/PO2HKDOYz+n6pqCqRs9wVTres0Uw3esDBZ 9LMvm07tozc8VAkxXJf+w2aCCAgO9gctDzJ0EhmVudoRq/XLm75wm5f1iUvEVjwAfMz9wXl+nQ qxaDpAn1h3GPaBEfDRYf45piYUe3IilgopOCizcQvgOX17u3BHPpawzJ2VAsrPfIwgwvIfh5vL yDygOAH3TtNSccJ+t2jFd1cYoU3riiADrwCdjhJBOVAd48WnnQL6exMZ/Odz3X8Ou4FgrE3OgH G14= X-SBRS: 2.7 X-MesageID: 8973721 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.69,255,1571716800"; d="scan'208";a="8973721" From: Lars Kurth To: Rich Persaud , Jan Beulich Thread-Topic: [Xen-devel] [PATCH v2 4/6] Add Code Review Guide Thread-Index: AQHVdKIj+bIBaPEUGUyD9FYiIrE4J6egEqKAgACbQgCAAIb3AIAAG2qA Date: Fri, 29 Nov 2019 01:50:59 +0000 Message-ID: <2DC43965-F2D4-4413-9CDB-EB52E8C218AA@citrix.com> References: <909826df-25c1-6d7c-75d9-470365d2ecf6@suse.com> <10E1B547-180B-4620-9E4A-62C5B0DB2B93@gmail.com> In-Reply-To: <10E1B547-180B-4620-9E4A-62C5B0DB2B93@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/10.10.10.191111 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted Content-ID: <817B101C0B53DE488DCF9D091D64143D@citrix.com> MIME-Version: 1.0 Subject: Re: [win-pv-devel] [Xen-devel] [PATCH v2 4/6] Add Code Review Guide X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Lars Kurth , Stefano Stabellini , "xen-api@lists.xenproject.org" , "minios-devel@lists.xenproject.org" , "committers@xenproject.org" , "mirageos-devel@lists.xenproject.org" , "xen-devel@lists.xenproject.org" , "win-pv-devel@lists.xenproject.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" DQoNCu+7v09uIDI4LzExLzIwMTksIDEyOjEyLCAiUmljaCBQZXJzYXVkIiA8cGVyc2F1ckBnbWFp bC5jb20+IHdyb3RlOg0KDQogICAgT24gTm92IDI4LCAyMDE5LCBhdCAwNToxMiwgSmFuIEJldWxp Y2ggPEpCZXVsaWNoQHN1c2UuY29tPiB3cm90ZToNCiAgICA+IA0KICAgID4gT24gMjguMTEuMjAx OSAwMTo1NCwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KICAgID4+PiBPbiBUaHUsIDI2IFNl cCAyMDE5LCBMYXJzIEt1cnRoIHdyb3RlOg0KICAgID4+PiBGcm9tOiBMYXJzIEt1cnRoIDxsYXJz Lmt1cnRoQGNpdHJpeC5jb20+DQogICAgPj4+IA0KICAgID4+PiBUaGlzIGRvY3VtZW50IGhpZ2hs aWdodHMgd2hhdCByZXZpZXdlcnMgc3VjaCBhcyBtYWludGFpbmVycyBhbmQgY29tbWl0dGVycyBs b29rDQogICAgPj4+IGZvciB3aGVuIHJldmlld2luZyBjb2RlLiBJdCBzZXRzIGV4cGVjdGF0aW9u cyBmb3IgY29kZSBhdXRob3JzIGFuZCBwcm92aWRlcw0KICAgID4+PiBhIGZyYW1ld29yayBmb3Ig Y29kZSByZXZpZXdlcnMuDQogICAgPj4gDQogICAgPj4gSSB0aGluayB0aGUgZG9jdW1lbnQgaXMg bWlzc2luZyBhIGNvdXBsZSBvZiB0aGluZ3M6DQogICAgPj4gDQogICAgPj4gLSBhIHNpbXBsZSBv bmUgbGluZSBzdGF0ZW1lbnQgdGhhdCBwb3NzaWJseSB0aGUgbW9zdCBpbXBvcnRhbnQgdGhpbmcg aW4NCiAgICA+PiAgYSBjb2RlIHJldmlldyBpcyB0byBpbmRlbnRpZnkgYW55IGJ1Z3MgaW4gdGhl IGNvZGUNCiAgICA+PiANCiAgICA+PiAtIGFuIGV4cGxhbmF0aW9uIHRoYXQgcmVxdWVzdHMgZm9y IG1ham9yIGNoYW5nZXMgdG8gdGhlIHNlcmllcyBzaG91bGQgYmUNCiAgICA+PiAgbWFkZSBlYXJs eSBvbiAoaS5lLiBsZXQncyBub3QgY2hhbmdlIHRoZSBhcmNoaXRlY3R1cmUgb2YgYSBmZWF0dXJl IGF0DQogICAgPj4gIHY5IGlmIHBvc3NpYmxlKSBJIGFsc28gbWFkZSB0aGlzIGNvbW1lbnQgaW4g cmVwbHkgdG8gcGF0Y2ggIzUuIEknbGwNCiAgICA+PiAgbGV0IHlvdSBkZWNpZGUgd2hlcmUgaXMg dGhlIGJlc3QgcGxhY2UgZm9yIGl0Lg0KICAgID4gDQogICAgPiBUaGlzIG5lZWRzIGJhbGFuY2lu Zy4gUGVvcGxlIGNydWNpYWwgdG8gdGhlIGV2YWx1YXRpb24gb2YgYSBuZXcNCiAgICA+IGZlYXR1 cmUgYW5kIGl0cyBpbXBsZW1lbnRhdGlvbiBzaW1wbHkgbWF5IG5vdCBoYXZlIHRoZSB0aW1lIHRv DQogICAgPiByZXBseSBwcmlvciB0byB2OS4gV2UndmUgaGFkIHNpdHVhdGlvbnMgd2hlcmUgcGVv cGxlIHBvc3RlZCBuZXcNCiAgICA+IHJldmlzaW9ucyBldmVyeSBvdGhlciBkYXksIHNvbWV0aW1l cyBldmVuIG1vcmUgdGhhbiBvbmUgcGVyIGRheS4NCiAgICA+IA0KICAgID4gQXMgaW5kaWNhdGVk IGluIHNldmVyYWwgb3RoZXIgY29udGV4dHMgYmVmb3JlIC0gaW1vIHBlb3BsZSBub3QNCiAgICA+ IGhlbHBpbmcgdG8gc2hvdWxkZXIgdGhlIHJldmlldyBsb2FkIHNob3VsZCBhbHNvIG5vdCBoYXZl IHRoZQ0KICAgID4gZXhwZWN0YXRpb24gdGhhdCB0aGVpciAobGFyZ2UpIGNvbnRyaWJ1dGlvbnMg d2lsbCBiZSBsb29rZWQgYXQNCiAgICA+IGluIGR1ZSBjb3Vyc2UuIA0KICAgIA0KICAgIFRvIG1h a2UgdGhpcyBhY3Rpb25hYmxlLCB3ZSBjb3VsZCBoYXZlOg0KICAgIA0KICAgIC0gcmV2aWV3ZXIg ZGVtYW5kIGluZGV4OiAgYXV0b21hdGVkIGluZGV4IG9mIG9wZW4gcGF0Y2hlcyBzdGlsbCBpbiBu ZWVkIG9mIHJldmlldywgc29ydGVkIGJ5IGRlY3JlYXNpbmcgYWdlDQogICAgDQogICAgLSByZXZp ZXcgZmxvdyBjb250cm9sOiAgZWFjaCBuZXcgcGF0Y2ggc3VibWlzc2lvbiBjaXRlcyBvbmUgcmVj ZW50IHJldmlldyBieSB0aGUgcGF0Y2ggc3VibWl0dGVyLCBmb3IgYSBwYXRjaCBvZiBjb21wYXJh YmxlIHNpemUNCiAgICANCiAgICAtIHJldmlld2VyIHN1cHBseSBncm93dGg6ICBhIGJvb3RzdHJh cHBpbmcgZ3VpZGUgZm9yIG5ldyByZXZpZXdlcnMgYW5kIHN1Ym1pdHRlcnMsIHdpdGggcGF0dGVy bnMsIGFudGktcGF0dGVybnMsIGFuZCBleGFtcGxlcyB0byBiZSBlbXVsYXRlZA0KICAgIA0KVGhh dCBpcyBhIGdyZWF0IGlkZWEuIEhvd2V2ZXIsIEkgd291bGQgbm90IHdhbnQgdG8gaG9sZCB1cCB0 aGUgcHVibGljYXRpb24gb2YgdGhlc2UgZG9jdW1lbnRzIG9uIHRoZXNlIHN1Z2dlc3Rpb25zLiBT b21lIG9mIHRoZW0gd291bGQgcmVxdWlyZSBpbXBsZW1lbnRpbmcgdG9vbHMuIEkgd2FzIGhvcGlu ZyB0aGVyZSB3b3VsZCBiZSBtb3JlIHByb2dyZXNzIG9uIGxvcmUgYW5kIG90aGVycyB0b29saW5n L3dvcmtmbG93IHJlbGF0ZWQgc3R1ZmYgYnkgbm93LiBTbyBJIHRoaW5rIGZvciBub3csIEkgdGhp bmsgaXQgaXMgc3VmZmljaWVudCB0byBzZXQgZXhwZWN0YXRpb25zIGJldHRlci4NCg0KUmVnYXJk cw0KTGFycw0KDQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Xwp3aW4tcHYtZGV2ZWwgbWFpbGluZyBsaXN0Cndpbi1wdi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0 Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8vd2luLXB2 LWRldmVs From win-pv-devel-bounces@lists.xenproject.org Fri Nov 29 02:11:12 2019 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 29 Nov 2019 02:11:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaVkW-0001Lg-9b; Fri, 29 Nov 2019 02:11:12 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaVkV-0001La-Qy for win-pv-devel@lists.xenproject.org; Fri, 29 Nov 2019 02:11:11 +0000 X-Inumbo-ID: 7b2e1d84-124d-11ea-a3db-12813bfff9fa Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7b2e1d84-124d-11ea-a3db-12813bfff9fa; Fri, 29 Nov 2019 02:10:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1574993458; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=3cPGkvjFxrnt7mArXi98hp4XtgJhHmSPh6RmhQYO+2c=; b=NAkhMxibP0gYpIfwpRpMCSJXkVIA4InTLn9qMy6Os0OLz1+szz3Q1Laj 7nIZVZyLr9mTOz/+Oe8XMEX03xsVr/4Rrx+tSl3eRyPjNJoZpIcHsO0MR JVAX5X6+Vpp3h6V0qL1ODvpAim4JPY4rbLLaYK7s8Fk4rzo4HHQqNRPX9 s=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=lars.kurth@citrix.com; spf=Pass smtp.mailfrom=lars.kurth@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa5.hc3370-68.iphmx.com: no sender authenticity information available from domain of lars.kurth@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="lars.kurth@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa5.hc3370-68.iphmx.com: domain of lars.kurth@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="lars.kurth@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa5.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: PFnbT/FyJRMEkMjEkUwxNcomifQ+KN9JIYT9y1j059/YkxX9Vmgx/TMa7nUxwujBOvmlzN3nzT s1Ng6rbdtcQWu9YsQtoCICge5/Al2ZGL7nIfTybNPumsEkWBb0sBAiGmDQoBXABfmFPmoofYSR 9TKgfZaVjiiMJDjLujgFrEiAYgvmxJNx9BNyRQOUVLZv1FqHfWA9b8pKLa/Mbx5mbAM/KlLeMj X2owAxCuTc9ZFSLi6S38N7heGncMhKqc9IDXthHhnQ7LQP9/iNE8M4PShIyN22laEgGu8Ju5wL z4A= X-SBRS: 2.7 X-MesageID: 9325828 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.69,255,1571716800"; d="scan'208";a="9325828" From: Lars Kurth To: Stefano Stabellini , Jan Beulich Thread-Topic: [Xen-devel] [PATCH v2 6/6] Added Resolving Disagreement Thread-Index: AQHVdKIlkhvO00R580a3wEu9+2XsyaegEysAgACdNQCAAI8ZAIAAFkkA Date: Fri, 29 Nov 2019 02:10:36 +0000 Message-ID: References: <2e4b36afaa73277d246d7e84037db1532a136ec7.1569525222.git.lars.kurth@citrix.com> <22b7f67c-c3dc-5450-999f-e79168175d39@suse.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/10.10.10.191111 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted Content-ID: MIME-Version: 1.0 Subject: Re: [win-pv-devel] [Xen-devel] [PATCH v2 6/6] Added Resolving Disagreement X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Lars Kurth , "xen-api@lists.xenproject.org" , "minios-devel@lists.xenproject.org" , "committers@xenproject.org" , "mirageos-devel@lists.xenproject.org" , "xen-devel@lists.xenproject.org" , "win-pv-devel@lists.xenproject.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" DQoNCu+7v09uIDI4LzExLzIwMTksIDEyOjUwLCAiU3RlZmFubyBTdGFiZWxsaW5pIiA8c3N0YWJl bGxpbmlAa2VybmVsLm9yZz4gd3JvdGU6DQoNCiAgICBPbiBUaHUsIDI4IE5vdiAyMDE5LCBKYW4g QmV1bGljaCB3cm90ZToNCiAgICA+IE9uIDI4LjExLjIwMTkgMDE6NTYsIFN0ZWZhbm8gU3RhYmVs bGluaSB3cm90ZToNCiAgICA+ID4gT24gVGh1LCAyNiBTZXAgMjAxOSwgTGFycyBLdXJ0aCB3cm90 ZToNCg0KICAgID4gPiBJIHRoaW5rIGEgZ29vZCByZWNvbW1lbmRhdGlvbiB3b3VsZCBiZSBmb3Ig dGhlIGNvbnRyaWJ1dG9yIHRvIHRyeSB0bw0KICAgID4gPiBmb2xsb3cgdGhlIG1haW50YWluZXJz IHJlcXVlc3RzLCBldmVuIGlmIHRoZXkgY291bGQgYmUgY29uc2lkZXJlZA0KICAgID4gPiAic3R5 bGUiLCB0cnVzdGluZyB0aGVpciBleHBlcmllbmNlIG9uIHRoZSBtYXR0ZXIuIEFuZCBhIGdvb2QN CiAgICA+ID4gcmVjb21tZW5kYXRpb24gZm9yIHRoZSBtYWludGFpbmVyIHdvdWxkIGJlIHRvIHRy eSB0byBsZXQgdGhlIGNvbnRyaWJ1dG9yDQogICAgPiA+IGhhdmUgZnJlZWRvbSBvZiBpbXBsZW1l bnRhdGlvbiBjaG9pY2Ugb24gdGhpbmdzIHRoYXQgZG9uJ3QgbWFrZSBhDQogICAgPiA+IHNpZ25p ZmljYW50IGRpZmZlcmVuY2UuDQogICAgPiANCiAgICA+IEkgdGhpbmsgd2UgdHJ5IHRvLCBidXQg SSBhbHNvIHRoaW5rIHdlIHN1ZmZlciBmcm9tIHRvbyBsaXR0bGUNCiAgICA+IGNsZWFyIGRvY3Vt ZW50YXRpb24gb24gZS5nLiBzdHlsZSBhc3BlY3RzLiBBdHRlbXB0cyBvbiBteSBwYXJ0DQogICAg PiB0byBhZGRyZXNzIHRoaXMgaGF2ZSBtb3N0bHkgKG5vdCBlbnRpcmVseSkgbGVhZCBuby13aGVy ZSAobGFjayBvZg0KICAgID4gZmVlZGJhY2sgb24gcHJvcG9zZWQgcGF0Y2hlcyB0byAuL0NPRElO R19TVFlMRSkuIFNvIGZvciB0aGUgdGltZQ0KICAgID4gYmVpbmcgdGhlcmUgYXJlIChtYW55KSBh c3BlY3RzIHdoZXJlIHdlIGhhdmUgZGUtZmFjdG8gZXhwZWN0YXRpb25zDQogICAgPiB0aGF0IGFy ZW4ndCB3cml0dGVuIGRvd24gYW55d2hlcmUsIHdpdGggdGhlIHJlc3VsdCBvZiAoaW4gYSBzdWJz ZXQNCiAgICA+IG9mIGNhc2VzKSBkaXNhZ3JlZW1lbnQgb24gd2hhdCB0aGUgcGVyY2VpdmVkIGRl LWZhY3RvIHN0YW5kYXJkDQogICAgPiBhY3R1YWxseSBpcy4NCiAgICANCiAgICBJIHJlY29nbml6 ZSB0aGF0IGl0IGNvdWxkIGJlIGNoYWxsZW5naW5nIGZpbmRpbmcgYSBjb25zZW5zdXMgdG8gdXBk YXRlDQogICAgQ09ESU5HX1NUWUxFIGJ1dCBpdCBtaWdodCBiZSB3b3J0aCBkb2luZyB0byByZWR1 Y2UgZnJpY3Rpb25zIHdpdGggYm90aA0KICAgIGNvbnRyaWJ1dG9ycyBhbmQgb3RoZXIgcmV2aWV3 ZXJzLg0KICAgIA0KICAgIEJ1dCB0byBiZSBjbGVhciwgSSB3YXMgYWxzbyByZWZlcnJpbmcgdG8g dGhpbmdzIHRoYXQgbWlnaHQgYmUgYWN0dWFsbHkNCiAgICBoYXJkIHRvIGFkZCB0byBDT0RJTkdf U1RZTEUsIHN1Y2ggYXMgbWFjcm8gdnMuIHN0YXRpYyBpbmxpbmVzLCB3aGVuIHRvDQogICAgc3Bs aXQgYSBzaW5nbGUgZnVuY3Rpb24gaW50byBtdWx0aXBsZSBzbWFsbGVyIGZ1bmN0aW9ucywgZXRj Lg0KICAgIA0KSSB0aGluayB0aGlzIGlzIGRlZmluaXRlbHkgc29tZXRoaW5nIHdlIG91Z2h0IHRv IGRvLiBJIGFtIHZvbHVudGVlcmluZyB0bw0KcGljayB0aGlzIHVwLCBidXQgY2hhbmdpbmcvY2xh cmlmeWluZyB0aGUgQ09ESU5HX1NUWUxFIG5lZWRzIHRvIGJlIA0KY29uc2lkZXJlZCBpbiBjb25q dW5jdGlvbiB3aXRoIGNoZWNraW5nIHRvb2xzDQoNCkkgaGF2ZSBwYXJrZWQgdGhpcyBmb3Igbm93 LCBhcw0KYSkgSSBkaWQgbm90IHdhbnQgdG8gZGlzcnVwdCA0LjEzIA0KYikgYW5kIHVudGlsIHJl Y2VudGx5IEkgYWxzbyBkaWRu4oCZdCBmdWxseSB1bmRlcnN0YW5kIHdoYXQga2luZCBvZiBjb2Rp bmcNCnN0YW5kYXJkcyB3b3VsZCBoZWxwIHdpdGggc2FmZXR5IGNlcnRpZmljYXRpb24NCg0KQW5k IG9mIGNvdXJzZSwgaGF2aW5nIGEgYm90IGRvIHRoZSBjaGVja2luZyB3b3VsZCByZW1vdmUgdGhl IGZyaWN0aW9uDQplbnRpcmVseS4gDQoNCkxhcnMNCg0KDQpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwp3aW4tcHYtZGV2ZWwgbWFpbGluZyBsaXN0Cndpbi1w di1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3Jn L21haWxtYW4vbGlzdGluZm8vd2luLXB2LWRldmVs