From win-pv-devel-bounces@lists.xenproject.org Mon Apr 06 21:15:35 2020 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 06 Apr 2020 21:15:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jLZ5h-0003AS-9e; Mon, 06 Apr 2020 21:15:33 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jLZ5g-0003AN-3U for win-pv-devel@lists.xenproject.org; Mon, 06 Apr 2020 21:15:32 +0000 X-Inumbo-ID: bea4d972-784b-11ea-802f-12813bfff9fa Received: from mail.hldns.com (unknown [199.249.188.77]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id bea4d972-784b-11ea-802f-12813bfff9fa; Mon, 06 Apr 2020 21:15:30 +0000 (UTC) Received: from [192.168.0.73] (174-17-125-32.phnx.qwest.net [174.17.125.32]) by mail.hldns.com (Postfix) with ESMTPSA id 951848F87A4 for ; Mon, 6 Apr 2020 14:15:28 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=hldns.com; s=mail-dkim; t=1586207728; bh=2LlEQAECkZBAf8lTDr/ekVnqlW3UjF91RT6IkDdPl64=; h=Date:Subject:From:To:Message-ID:Mime-version:Content-type; b=5vT5fbMXPu0LT/gvurHq6JkZ8wrvzTDcCpViB3dz3mx4Gl5xnGjgA4+FdxpGuCeIe M5S2/donM1vB5ttviGFiPCyakNT99Zj5Wqh/2TOLf0wzN2REYKL3AbFvk2tQx9m5uM KqAVa4HQrLe/6OIWCDjibshuTUrfNanXLQtcgn7dL5p7uT2K0o135d2yHkLoAFm/kl wooEvsoZ2tsDto4iTMR98PnPQttMr0JwyFD3jL5bqfBn0TLdG4c0h1UNaEp1dzZ4+g jynBTvSWMs39qErkaiR3EnzafspxhYpO2eVIEBbKJIVhiwTH2r5dStn70Y7P0qhrV+ BnIobvBBTVqvg== User-Agent: Microsoft-MacOutlook/16.37.20040202 Date: Mon, 06 Apr 2020 14:15:28 -0700 From: Steffan Cline To: "win-pv-devel@lists.xenproject.org" Message-ID: Thread-Topic: Upgrade to 9.0.0 Drivers Mime-version: 1.0 Subject: [win-pv-devel] Upgrade to 9.0.0 Drivers X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5468729732468610963==" Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" > This message is in MIME format. Since your mail reader does not understand this format, some or all of this message may not be legible. --===============5468729732468610963== Content-type: multipart/alternative; boundary="B_3669027330_841293276" > This message is in MIME format. Since your mail reader does not understand this format, some or all of this message may not be legible. --B_3669027330_841293276 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: quoted-printable I=E2=80=99ve found something recently with upgrading from 8.2 to 9.0. Every time = I try to install the 9.0 drivers into a VM that had the 8.2 version, it neve= r boots up. It doesn=E2=80=99t matter if I try to install over the top or remove, = reboot, install, reboot. I=E2=80=99m SOL. The version of Windows doesn=E2=80=99t seem to= matter. I=E2=80=99ve tried this now with 2012 and 2016 with no luck. =20 I installed them in a fresh 2012 build and it was fine so it really seems t= o upgrading. =20 Any known good way to upgrade and have a working VM?=20 =20 =20 =20 Thank you, Steffan Cline steffan@hldns.com 602-793-0014=20 =20 --B_3669027330_841293276 Content-type: text/html; charset="UTF-8" Content-transfer-encoding: quoted-printable

I=E2=80=99ve foun= d something recently with upgrading from 8.2 to 9.0. Every time I try to ins= tall the 9.0 drivers into a VM that had the 8.2 version, it never boots up. = It doesn=E2=80=99t matter if I try to install over the top or remove, reboot, inst= all, reboot. I=E2=80=99m SOL. The version of Windows doesn=E2=80=99t seem to matter. I=E2=80= =99ve tried this now with 2012 and 2016 with no luck.

 

<= p class=3DMsoNormal>I installed them in a fresh= 2012 build and it was fine so it really seems to upgrading.

 

Any known good way= to upgrade and have a working VM?

=  

 

 

Thank you,

Steffan Cline

steffan@hldns.com

602-793-0014&= nbsp;

 

--B_3669027330_841293276-- --===============5468729732468610963== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Kd2luLXB2LWRl dmVsIG1haWxpbmcgbGlzdAp3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6 Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3dpbi1wdi1kZXZlbA== --===============5468729732468610963==-- From win-pv-devel-bounces@lists.xenproject.org Tue Apr 07 10:16:24 2020 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 07 Apr 2020 10:16:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jLlHL-0004pq-7q; Tue, 07 Apr 2020 10:16:23 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jLlHJ-0004pl-NG for win-pv-devel@lists.xenproject.org; Tue, 07 Apr 2020 10:16:21 +0000 X-Inumbo-ID: d34c246c-78b8-11ea-8095-12813bfff9fa Received: from gauss.credativ.com (unknown [93.94.130.89]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d34c246c-78b8-11ea-8095-12813bfff9fa; Tue, 07 Apr 2020 10:16:20 +0000 (UTC) Received: from gauss.credativ.com (localhost [127.0.0.1]) by gauss.credativ.com (Postfix) with ESMTP id 0213CA01C2; Tue, 7 Apr 2020 12:16:20 +0200 (CEST) Received: from [10.10.10.47] (fw-front.credativ.com [62.154.226.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dbe@gauss.credativ.com) by gauss.credativ.com (Postfix) with ESMTPSA id D0838A0130 for ; Tue, 7 Apr 2020 12:16:19 +0200 (CEST) To: win-pv-devel@lists.xenproject.org From: Dominic Brekau Autocrypt: addr=dominic.brekau@credativ.de; keydata= mQINBFnSNDoBEADbPKaoy7njwOuzcAa9wQiCP5Cr7pkO5drB5Go9ST4qh9IJUThjyHJa5/7e +/ZCpi3+e9htMpCmOIZXzIJh0kGdywg4glWIKBnAivVL6B6N8wWGs0Bz5NPRO8IX3Nax70H7 TzEjaV/S9LLSjYN8xcxr03i6An8Fzs1ADmaLvJ25gSr3U7Do3YFzOWZ/ixLNQA/waHuc+oNq 9w9+TYkq7QJ43iJTklchKfBv1gkXZpKMhjkOarwF7yG9epjhvN3B8RnThBNIX4reFFd1kObI 5ypKmbVXJ4qw6W4fx6h98dfd1/iqqJF4rfRyxnWsy1R28cXZaMyFMr3jtkWsTuMejHE8lPT8 gLAtLnU15ajMjTQi4XOscm2o5vOScm6k9E2nveSv0q6OQpilbK0c7ClK/MuY/eh+moyndcmh HMoV8a34vQSvqurnZyrIawDup6c6DHywV2roEEm8aJr3sfEQ+fNnl5iyKewph1GR640fPyw4 pulJugffmQ4+yKXUEO6JFki/9uKcuT71Z0aS8i6NjBrMnqD28gjvYhXM87uJ9Vb8pXLWSTIZ UIAG7GWQ0xbm2+8dB8jjDDKR/t30DceD6SPHQ0RwbJMaEOWUG0LP7Dq+1MsG/MBR7viBq1Zf ASonrpMDFsRLpPZV8nRYLb8QC2C5UiM3iGO4/L+98QXZtmJ9ywARAQABtCtEb21pbmljIEJy ZWthdSA8ZG9taW5pYy5icmVrYXVAY3JlZGF0aXYuZGU+iQI9BBMBCAAnBQJZ0jQ6AhsjBQkJ ZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEObqC6gXhpPoe0QQAKSju6pb356Fr3A5 yNOM1R4D8am7Pq42Sm67LHCsbPkwGauuNxeRVAy/PcAq5H5p3gyBQ7VW9cyjF3AIKwfcUUE5 c1/JoDOoVWeMH90RKnzhmGjSxEwsGYUEegj+FDGM46oYKOsEq8tXQJWbCppYjv/XJ1zcpj3Q EPKhsJzc3EeOrQhYQcT7s6GvEDS0tKuglse/xx4EyzQ0xxeGjLJ44sZcsQC+DRAvh61BLVg4 NejYsPum5fsSbjTHzcy4w/b+wYyyDHvExjsO8ZSXe/G+cd1E6yeau/Uw6h1bZ+6oPzkIUsJ0 +sCUi/62BoaRql+3iMyoT4/dmJqzRyWSg/z8VZFu/QptDOFnYZYAj122rCcRs5PNa9wFVqkC FGjmgtmB1BIvSZFnFn9hkRv9Il73HSQI02QiUkNzttifOyewloGbn60N/XL3PySbG75xQ/vZ WiJSIpnQPfq37f0rOgvld2plLFJAAJ8qaO4T0CaGZYpWKz8BJpJgkvONDCKKFSwLaJSNCqOm 05U0C+dQkHxT1sw6DfG1HlSKbUAUpYtx7YQj0oRWtTeQq7kTHHP6fZnmcdT88AGBHOQ4WoA3 NYMQlJVoDFMmXagYASWQ3Ww/l44wmx/oQnCYjBQkeccnAT2VFLYdFjEXR2c8r7mMnArUr0ik bnClfAZQK8ZwjZJQeKxPuQINBFnSNDoBEADHaELu0iupCAk56bhEoluGkcrtfrzJ1u557Bsm l7BuNc/OA0t52j3vT1LOUiX12rZYFYKphaqjGN1xLkLJs2UtgAj73Dj4eZAnybDJTqNMjZqe R6UhpNayqpT2EFSGMbXjomsexDynUTCc0STu2bAFyTzSTjJxO4J/sPB3zWLjVRrx4RYnA3bP 0noWZ5MiHk99cCAKfSKyQGAJjUU33cBlDb1VE8q8D5eZpK2TmlF3PvvpJ+KVGZTenlF3dfvz eXuUB4qgpBFKtQxsrg70bMa7BlNgW+oQVk/OEIx5G/x0daKlOySZ6vB6NZ0V8upOBmyZkDyl tOtK4kvLBXJeVEXi4LeQdnPAwaZ8qzKDMfd9gXUQ9UkpEZmgo8E6x7kiedO3/1q6r3tqo945 UpiisOQLsxM8H3kPsROBdk0hGx5pvIXsbuj/yGxTF+3GFsU4QPNRMaQ/vrzPL1YKmYqC5ttt tpG50gHWqYqbBctEl0v9qHV70xzKu8I1V1EnHiWmGY+dk0/KsHJEE39zBa4z5i7pKIqqGyQB Mo3x5gZBVRgq3Q2H6niLh6fhJOeUnpb+rEHyGvXPUYYqGaIMw3+y3YKqGKA3+fup8wEyA/Wo YUZMmOBUgrMqtzb1xcfM0k0WIoAOt8PXp288chWzz90biQYv/AmHsaY3OfNo7AdNQga+LQAR AQABiQIlBBgBCAAPBQJZ0jQ6AhsMBQkJZgGAAAoJEObqC6gXhpPom/oQAI5VqTLd4xpiI9S6 DZ6VhuMrLXek+hofoFPLUS8KsAxkS93ARo0yD9mQoGERnlmVDQDoKSMfU12HWJ6BH7unlU4p vP4dchPcekTSX36bJ3NH0boPS/AqBRzI8L5/IPHi01dlFiCkeVjV/VwuVD7ugTfppVBZQZ+q MYYz4KIZseOBjGLT8mYYVAttNIu9QcxSu1w0IwlSLvKxJ4e51P0Tg5Hm1i+Ef3jU1H64aubc NugV1L3kXQmUaLASqVcSfhjYgRyKDyBrdNLVEC+uQC08di7/qf1xGp5sp+Vl/1Y78SBR51/0 rKS/IdXBDINeBQDAPLNykCA2UtgNznIWVBwyjzFyyFtTwcZ38c4Avf8ZPhARc9ZfC9EvOsgj J5dQTLBvXuI+Au1HHlzmSvGpL4WMp+p9qY5JZmWMOvniQts7xKIuLmOfBrYQv7rfREm3xUMF bcWMipjw3TT8q1qhAec74wkn7WT95vPiegzvNbH5WxL+lx1dMFd2JFDmxeKfVkUAvJH1+mye CGri3jKeaw2bifAPg1tLxvnaySLyZJYfQUA1F0N5vSRtwoQhajfPR7UfVnHXLs4H3w7ENvfJ M8j0Q4uXn3j2w0z7GcHXOGhzrE+9Z09tBVWBvgi/fE9H0SUvTiWW65ryeAj1UwlS1XQ1plh+ rRI/hThnx5yXGLSMtMoL Message-ID: <44ee944c-161b-754e-387e-84a2db7c5a70@credativ.de> Date: Tue, 7 Apr 2020 12:16:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 Content-Language: en-US Subject: [win-pv-devel] Important: There will be no subject prefix anymore on this mailing list X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" SGVsbG8gZXZlcnlvbmUgb24gd2luLXB2LWRldmVsCgpmb3Igbm90IGJyZWFraW5nIERLSU0gYW55 bW9yZSwgZnJvbSBub3cgb24gdGhlcmUgd2lsbCBiZSBubyBzdWJqZWN0CnByZWZpeCBhbmQgbm8g ZW1haWwgZm9vdGVyIGxpa2UgaW4gdGhlIHBhc3QuCgpJZiB5b3Ugd291bGQgbGlrZSB0byBmaWx0 ZXIgZW1haWxzIGZyb20gdGhpcyBtYWlsaW5nIGxpc3QgeW91IGNhbiB1c2UKc29tZXRoaW5nIGxp a2UgY2hlY2tpbmcgaWYgdGhlIGhlYWRlciAnTGlzdC1JZCcgY29udGFpbnMKIndpbi1wdi1kZXZl bC5saXN0cy54ZW5wcm9qZWN0Lm9yZyIuCkFuIGV4YW1wbGUgZm9yIHNpZXZlIGNvdWxkIGJlOgoK PiBpZiBoZWFkZXIgOmNvbnRhaW5zICJMaXN0LUlkIiAid2luLXB2LWRldmVsLmxpc3RzLnhlbnBy b2plY3Qub3JnIiB7Cj7CoMKgwqDCoCBmaWxlaW50byAiSU5CT1gvd2luLXB2LWRldmVsIiA7Cj4g fQoKUmVnYXJkcwoKRG9taW5pYyBCcmVrYXUKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCndpbi1wdi1kZXZlbCBtYWlsaW5nIGxpc3QKd2luLXB2LWRldmVs QGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1h bi9saXN0aW5mby93aW4tcHYtZGV2ZWw= From win-pv-devel-bounces@lists.xenproject.org Wed Apr 08 08:24:40 2020 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 08 Apr 2020 08:24:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jM60k-0005K0-LF; Wed, 08 Apr 2020 08:24:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jM60j-0005Jv-MZ for win-pv-devel@lists.xenproject.org; Wed, 08 Apr 2020 08:24:37 +0000 X-Inumbo-ID: 61a8f244-7972-11ea-b58d-bc764e2007e4 Received: from mail-wr1-x430.google.com (unknown [2a00:1450:4864:20::430]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 61a8f244-7972-11ea-b58d-bc764e2007e4; Wed, 08 Apr 2020 08:24:36 +0000 (UTC) Received: by mail-wr1-x430.google.com with SMTP id c15so6714854wro.11 for ; Wed, 08 Apr 2020 01:24:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-language:thread-index; bh=BgiD9LfrNpRIIxUif/oiDOspNs/QyjCe57375YXxlpg=; b=i2HmmV0bw7zPtbTItYIo97eFUyasD32UfPc1MeoCxv9+H2fxjs/UqSG9/84S/3S+qS AAdbqEY5+kZYTa1BJq2dOxGEA998FhM0Gextc6YdUN7gdpT3FEcvKf4jsbNxUPxOCzhu 4sSB+Csg+lUarx+Rlt3JdmbHgvCbb7bBkgJb/SBbtHBfxJuaqIQjDFQyN7iTaK3vEaen 5zzvbqBrv/xe7NlJOUTK8+W+8V5kbt4qvBHDsSS58US0K0aXai5ntVMjFuZZTme3kSRX YrKYJxxPn57YrLCs1PWqb+h9wEZekZtszXy4LTG+UiXAheQbspIWI1YO3leY+xGyTVoh muxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:to:cc:references:in-reply-to :subject:date:message-id:mime-version:content-language:thread-index; bh=BgiD9LfrNpRIIxUif/oiDOspNs/QyjCe57375YXxlpg=; b=G5f+8lxisaZQSiGyTWCT+/BIx5RDemJi7wK5P18xBNxyDiZiAOWwV+06825aaIPvDs wrhVPgaMTA8CD2ImHZspSpP95ixNr2J5gT+o/b5bdNnUJacs5sWwEjqnbwm5ow7P/Usg n66dM+BryxFpCvVrY/PpCRxKQl08Rn0J6e8lnM9emK68BzvMEPUlA7i8wUS2UuK76/XJ IORwfCMKVPzmYpfpHOOaAmoO9Dkn65MNEXQvdL8CjUS946pHAg1bKCQKAo/l42ctijBQ GgyGeQxvrmyoQz4jsOJteDk5T1fzrto5vU4k5UbDI81ft0X+0+Ayfqa77TCruTdSRY1p 4s8Q== X-Gm-Message-State: AGi0PuZPWbKcHP7Q0Q0AN/cjSNeJbaTR9yhMaL8tYTC/1U4OtKGx+fYz PU1EmaEn/zX1RiQl4+oM7O+bQ8h2BrY= X-Google-Smtp-Source: APiQypIGF8kPEzrS/dxJzWlMNb8KuSZsFgPWMd6+sXaX8LcMMwgxesoHc/4UO5AYQ9bh8/6asnHMBg== X-Received: by 2002:adf:a2d8:: with SMTP id t24mr7015180wra.366.1586334275606; Wed, 08 Apr 2020 01:24:35 -0700 (PDT) Received: from CBGR90WXYV0 ([54.239.6.188]) by smtp.gmail.com with ESMTPSA id 89sm5803750wri.11.2020.04.08.01.24.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Apr 2020 01:24:35 -0700 (PDT) From: Paul Durrant X-Google-Original-From: "Paul Durrant" To: "'Steffan Cline'" , References: In-Reply-To: Subject: RE: [win-pv-devel] Upgrade to 9.0.0 Drivers Date: Wed, 8 Apr 2020 09:24:33 +0100 Message-ID: <003d01d60d7f$22b6eeb0$6824cc10$@xen.org> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_NextPart_000_003E_01D60D87.847CB640" X-Mailer: Microsoft Outlook 16.0 Content-Language: en-gb Thread-Index: AQFmLvp3LRx15keeWsEXydJ63HN+Y6lOn0aA X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: paul@xen.org Cc: 'Owen Smith' Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" This is a multipart message in MIME format. ------=_NextPart_000_003E_01D60D87.847CB640 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Steffan, =20 [Cc-ing Owen as he=E2=80=99s probably got more experience dealing with = upgrade than I have] =20 By =E2=80=98never boots up=E2=80=99, do you mean spinning forever at = the splash screen or a BSOD? I=E2=80=99ve used the = remove-reboot-install-reboot cycle in the past and it worked for me but = maybe some change in 9.0 has broken something since I last did it. Do = you have the qemu log? =20 Paul =20 =20 From: win-pv-devel On Behalf = Of Steffan Cline Sent: 06 April 2020 22:15 To: win-pv-devel@lists.xenproject.org Subject: [win-pv-devel] Upgrade to 9.0.0 Drivers =20 I=E2=80=99ve found something recently with upgrading from 8.2 to 9.0. = Every time I try to install the 9.0 drivers into a VM that had the 8.2 = version, it never boots up. It doesn=E2=80=99t matter if I try to = install over the top or remove, reboot, install, reboot. I=E2=80=99m = SOL. The version of Windows doesn=E2=80=99t seem to matter. I=E2=80=99ve = tried this now with 2012 and 2016 with no luck. =20 I installed them in a fresh 2012 build and it was fine so it really = seems to upgrading. =20 Any known good way to upgrade and have a working VM?=20 =20 =20 =20 Thank you, Steffan Cline steffan@hldns.com =20 602-793-0014=20 =20 ------=_NextPart_000_003E_01D60D87.847CB640 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable

Hi = Steffan,

 =

=C2=A0 [Cc-ing Owen as he=E2=80=99s probably got more = experience dealing with upgrade than I have]

 =

=C2=A0 By =E2=80=98never boots = up=E2=80=99, do you mean spinning forever at the splash screen or a = BSOD? I=E2=80=99ve used the remove-reboot-install-reboot cycle in the = past and it worked for me but maybe some change in 9.0 has broken = something since I last did it. Do you have the qemu log?

 =

=C2=A0 Paul

 =

 =

From: win-pv-devel = <win-pv-devel-bounces@lists.xenproject.org> On Behalf Of = Steffan Cline
Sent: 06 April 2020 22:15
To: = win-pv-devel@lists.xenproject.org
Subject: [win-pv-devel] = Upgrade to 9.0.0 Drivers

 

I=E2=80=99ve found = something recently with upgrading from 8.2 to 9.0. Every time I try to = install the 9.0 drivers into a VM that had the 8.2 version, it never = boots up. It doesn=E2=80=99t matter if I try to install over the top or = remove, reboot, install, reboot. I=E2=80=99m SOL. The version of Windows = doesn=E2=80=99t seem to matter. I=E2=80=99ve tried this now with 2012 = and 2016 with no luck.

 

I installed them in a = fresh 2012 build and it was fine so it really seems to = upgrading.

 

Any known good way to = upgrade and have a working VM?

 

 

 

Thank = you,

Steffan = Cline

steffan@hldns.com=

602-793-0014 

 

------=_NextPart_000_003E_01D60D87.847CB640-- From win-pv-devel-bounces@lists.xenproject.org Wed Apr 08 09:15:05 2020 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 08 Apr 2020 09:15:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jM6nY-00013d-0M; Wed, 08 Apr 2020 09:15:04 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jM6nX-00013Y-07 for win-pv-devel@lists.xenproject.org; Wed, 08 Apr 2020 09:15:03 +0000 X-Inumbo-ID: 6a83d582-7979-11ea-81c8-12813bfff9fa Received: from mail.hldns.com (unknown [199.249.188.77]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6a83d582-7979-11ea-81c8-12813bfff9fa; Wed, 08 Apr 2020 09:14:59 +0000 (UTC) Received: from [192.168.0.36] (174-17-125-32.phnx.qwest.net [174.17.125.32]) by mail.hldns.com (Postfix) with ESMTPSA id C26338F87A4; Wed, 8 Apr 2020 02:14:57 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=hldns.com; s=mail-dkim; t=1586337297; bh=No7yKtCcBUfsCLpomkehLWfga4QoL8Hd4YY46tcsUY0=; h=Content-Type:Content-Transfer-Encoding:From:Mime-Version:Subject: Date:Message-Id:References:Cc:In-Reply-To:To; b=nMygEaeGXLJvzAllG+pTf2O6nbCwS8TfH7JBLBOanJIGqIR0Tbl1Cn0xygjQZAQ8z 1j2Iypkt4h5Jsm90gdCGg+bf81fNbywDBM/nBJah5rFDdVkjquZY6JCHSgdl5ujW5h qGzWcPfsnAQwbNkMJD/uaWkagYYFgEu4vQmYhNMQtdFMx6GMXRMdAE5CU881bDx3dB sYWJ2IJbDxgTaNg6ZGy++aWmpfwo2daqG7aTdMV6QxDiyhhy29Mme3AebKAGUh2vqV l1mPf6XpE4i8IyqUCgMHzHsvWKF/Q57cMmSpRPF/akQeGictky2k/k6dOD3C4kcgOl RuLFydI6FQOWQ== Content-Type: multipart/alternative; boundary=Apple-Mail-EE3B8326-5E84-4803-856B-11576873A6C5 Content-Transfer-Encoding: 7bit From: Steffan Cline Mime-Version: 1.0 (1.0) Subject: Re: [win-pv-devel] Upgrade to 9.0.0 Drivers Date: Wed, 8 Apr 2020 02:14:57 -0700 Message-Id: References: <003d01d60d7f$22b6eeb0$6824cc10$@xen.org> In-Reply-To: <003d01d60d7f$22b6eeb0$6824cc10$@xen.org> To: paul@xen.org X-Mailer: iPhone Mail (17D50) X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: win-pv-devel@lists.xenproject.org, Owen Smith Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" --Apple-Mail-EE3B8326-5E84-4803-856B-11576873A6C5 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Paul, By never boots up, I mean spinning forever at the boot screen. It=E2=80=99s d= one it to me on 2012R2 and 2016 a few times. I moved a bunch of my VMs aroun= d and have to go back and check the servers where I tried that. I did it the= way you did. Remove-reboot-install-reboot-stuck at boot. I ended up either r= estoring the VM to an archive or using the last known good config in Windows= then removing 9 and reinstalling 8.2.2 again. The reinstall of the older dr= ivers only works sometimes, not always. It=E2=80=99s about a 50/50 chance I=E2= =80=99ll have to restore from a backup so before I even try, I back up the V= M first. I did a fresh 2012R2 install with the 9.0.0 drivers and it=E2=80=99= s solid. It=E2=80=99s only on reinstall/upgrade. If you go back to my first e= mail on the topic of 9.0.0, this was the cause of that issue back then, I ju= st didn=E2=80=99t have all the steps to recreate the issue yet.=20 Thanks, Steffan Cline steffan@hldns.com 602-793-0014 > On Apr 8, 2020, at 1:24 AM, Paul Durrant wrote: >=20 > =EF=BB=BF > Hi Steffan, > =20 > [Cc-ing Owen as he=E2=80=99s probably got more experience dealing with u= pgrade than I have] > =20 > By =E2=80=98never boots up=E2=80=99, do you mean spinning forever at the= splash screen or a BSOD? I=E2=80=99ve used the remove-reboot-install-reboot= cycle in the past and it worked for me but maybe some change in 9.0 has bro= ken something since I last did it. Do you have the qemu log? > =20 > Paul > =20 > =20 > From: win-pv-devel On Behalf O= f Steffan Cline > Sent: 06 April 2020 22:15 > To: win-pv-devel@lists.xenproject.org > Subject: [win-pv-devel] Upgrade to 9.0.0 Drivers > =20 > I=E2=80=99ve found something recently with upgrading from 8.2 to 9.0. Ever= y time I try to install the 9.0 drivers into a VM that had the 8.2 version, i= t never boots up. It doesn=E2=80=99t matter if I try to install over the top= or remove, reboot, install, reboot. I=E2=80=99m SOL. The version of Windows= doesn=E2=80=99t seem to matter. I=E2=80=99ve tried this now with 2012 and 2= 016 with no luck. > =20 > I installed them in a fresh 2012 build and it was fine so it really seems t= o upgrading. > =20 > Any known good way to upgrade and have a working VM? > =20 > =20 > =20 > Thank you, > Steffan Cline > steffan@hldns.com > 602-793-0014=20 > =20 --Apple-Mail-EE3B8326-5E84-4803-856B-11576873A6C5 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable Paul,

By never boots up,= I mean spinning forever at the boot screen. It=E2=80=99s done it to me on 2= 012R2 and 2016 a few times. I moved a bunch of my VMs around and have to go b= ack and check the servers where I tried that. I did it the way you did. Remo= ve-reboot-install-reboot-stuck at boot. I ended up either restoring the VM t= o an archive or using the last known good config in Windows then removing 9 a= nd reinstalling 8.2.2 again. The reinstall of the older drivers only works s= ometimes, not always. It=E2=80=99s about a 50/50 chance I=E2=80=99ll have to= restore from a backup so before I even try, I back up the VM first. I did a= fresh 2012R2 install with the 9.0.0 drivers and it=E2=80=99s solid. It=E2=80= =99s only on reinstall/upgrade. If you go back to my first email on the topi= c of 9.0.0, this was the cause of that issue back then, I just didn=E2=80=99= t have all the steps to recreate the issue yet. 


Thank= s,
Stef= fan Cline
steffan@hldns.com
602-793-0014
On Apr 8, 2020, at 1:24 AM, Paul Durrant <xad= imgnik@gmail.com> wrote:

=EF=BB=BF<= meta name=3D"Generator" content=3D"Microsoft Word 15">

Hi Steffan,

<= p class=3D"MsoNormal"> 

  [Cc-ing Owen a= s he=E2=80=99s probably got more experience dealing with upgrade than I have= ]

 

  By =E2=80=98never b= oots up=E2=80=99, do you mean spinning forever at the splash screen or a BSO= D? I=E2=80=99ve used the remove-reboot-install-reboot cycle in the past and i= t worked for me but maybe some change in 9.0 has broken something since I la= st did it. Do you have the qemu log?

&nb= sp;

=   Paul

 =

 

From: win-pv-devel <win-pv-devel-bounces@lists.xenproject.org= > On Behalf Of Steffan Cline
Sent: 06 April 2020 22:15To: win-pv-devel@lists.xenproject.org
Subject: [win-pv-de= vel] Upgrade to 9.0.0 Drivers

 

I=E2=80=99ve found somethi= ng recently with upgrading from 8.2 to 9.0. Every time I try to install the 9= .0 drivers into a VM that had the 8.2 version, it never boots up. It doesn=E2= =80=99t matter if I try to install over the top or remove, reboot, install, r= eboot. I=E2=80=99m SOL. The version of Windows doesn=E2=80=99t seem to matte= r. I=E2=80=99ve tried this now with 2012 and 2016 with no luck.

 

I= installed them in a fresh 2012 build and it was fine so it really seems to u= pgrading.

 

Any known good way to upgrade and have a working VM?

 

 

 

Thank you,

Steffan Cline

steffan@hldns.com

602-793-0014 

 

=
= --Apple-Mail-EE3B8326-5E84-4803-856B-11576873A6C5-- From win-pv-devel-bounces@lists.xenproject.org Mon Apr 13 17:32:31 2020 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 13 Apr 2020 17:32:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jO2we-0001ZS-Ud; Mon, 13 Apr 2020 17:32:28 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jO2wd-0001ZN-LT for win-pv-devel@lists.xenproject.org; Mon, 13 Apr 2020 17:32:27 +0000 X-Inumbo-ID: bdb4106c-7dac-11ea-8880-12813bfff9fa Received: from mail.hldns.com (unknown [199.249.188.77]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id bdb4106c-7dac-11ea-8880-12813bfff9fa; Mon, 13 Apr 2020 17:32:26 +0000 (UTC) Received: from [192.168.0.73] (174-17-125-32.phnx.qwest.net [174.17.125.32]) by mail.hldns.com (Postfix) with ESMTPSA id E75078F87A4; Mon, 13 Apr 2020 10:32:23 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=hldns.com; s=mail-dkim; t=1586799144; bh=LL2M6Fc659OxXsRL0NFeaWQyKgMg6Q863+XjNHyAZu8=; h=Date:Subject:From:To:CC:Message-ID:References:In-Reply-To: Mime-version:Content-type; b=PkLzYZOfVBxm5q4VgdjL3beL1y4of8ELs+fcH1uYi89I8Yxqi9tfBFmgmlwh1iTFu zJnNzTev2J1EF1OMA2uigfpGO4rqtkI+iPJFr3japK/WLEeajtpClhugwZ8FBdZpJt D6HqjrWM4zQHUTIedDMZdaC5cbWYe6gpxtGiSKeKRQhI6UNxE/MU4J1+Ah3pFBFSce lSN1TxgTNe+OXkZaCRQJScbH5dO0UOVkJ63J0llDdeUQ/A9fiXFFv5aMckyxNkP44T lzB/crYYZxHI8ZVBb/T9z1RKy20hrtW1CH7bReD3JSpSBozPPRsvWp58rfOk+cQqRc KN9ADFAzrYIAA== User-Agent: Microsoft-MacOutlook/16.37.20040801 Date: Mon, 13 Apr 2020 10:32:23 -0700 Subject: Re: [win-pv-devel] Upgrade to 9.0.0 Drivers From: Steffan Cline To: , Owen Smith Message-ID: Thread-Topic: [win-pv-devel] Upgrade to 9.0.0 Drivers References: <003d01d60d7f$22b6eeb0$6824cc10$@xen.org> In-Reply-To: Mime-version: 1.0 Content-type: multipart/alternative; boundary="B_3669618745_1862506610" X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: paul@xen.org Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" > This message is in MIME format. Since your mail reader does not understand this format, some or all of this message may not be legible. --B_3669618745_1862506610 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: quoted-printable Owen, =20 Any feedback on this? =20 =20 Thank you, Steffan Cline steffan@hldns.com 602-793-0014=20 =20 =20 On 4/8/20, 2:15 AM, "win-pv-devel on behalf of Steffan Cline" wrote: =20 Paul, =20 By never boots up, I mean spinning forever at the boot screen. It=E2=80=99s done = it to me on 2012R2 and 2016 a few times. I moved a bunch of my VMs around an= d have to go back and check the servers where I tried that. I did it the way= you did. Remove-reboot-install-reboot-stuck at boot. I ended up either rest= oring the VM to an archive or using the last known good config in Windows th= en removing 9 and reinstalling 8.2.2 again. The reinstall of the older drive= rs only works sometimes, not always. It=E2=80=99s about a 50/50 chance I=E2=80=99ll have= to restore from a backup so before I even try, I back up the VM first. I di= d a fresh 2012R2 install with the 9.0.0 drivers and it=E2=80=99s solid. It=E2=80=99s onl= y on reinstall/upgrade. If you go back to my first email on the topic of 9.0= .0, this was the cause of that issue back then, I just didn=E2=80=99t have all the= steps to recreate the issue yet.=20 =20 Thanks, Steffan Cline steffan@hldns.com 602-793-0014 On Apr 8, 2020, at 1:24 AM, Paul Durrant wrote: =EF=BB=BF Hi Steffan, =20 =C2=A0 [Cc-ing Owen as he=E2=80=99s probably got more experience dealing with upgrade= than I have] =20 =C2=A0 By =E2=80=98never boots up=E2=80=99, do you mean spinning forever at the splash scre= en or a BSOD? I=E2=80=99ve used the remove-reboot-install-reboot cycle in the past= and it worked for me but maybe some change in 9.0 has broken something sinc= e I last did it. Do you have the qemu log? =20 =C2=A0 Paul =20 =20 From: win-pv-devel On Behalf Of= Steffan Cline Sent: 06 April 2020 22:15 To: win-pv-devel@lists.xenproject.org Subject: [win-pv-devel] Upgrade to 9.0.0 Drivers =20 I=E2=80=99ve found something recently with upgrading from 8.2 to 9.0. Every time = I try to install the 9.0 drivers into a VM that had the 8.2 version, it neve= r boots up. It doesn=E2=80=99t matter if I try to install over the top or remove, = reboot, install, reboot. I=E2=80=99m SOL. The version of Windows doesn=E2=80=99t seem to= matter. I=E2=80=99ve tried this now with 2012 and 2016 with no luck. =20 I installed them in a fresh 2012 build and it was fine so it really seems t= o upgrading. =20 Any known good way to upgrade and have a working VM?=20 =20 =20 =20 Thank you, Steffan Cline steffan@hldns.com 602-793-0014=20 =20 --B_3669618745_1862506610 Content-type: text/html; charset="UTF-8" Content-transfer-encoding: quoted-printable

Owen,<= /o:p>

 = ;

Any feed= back on this?

 

 

Thank you,

Steffan Cline

steffan@= hldns.com

602-793-0014 

 

=  

On 4/8/20, 2:15 AM, "win-pv-devel on behalf of Steffan Clin= e" <win-p= v-devel-bounces@lists.xenproject.org on behalf of steffan@hldns.com> wrote:=

 <= /p>

Paul,

 

By never boots up, I mean spi= nning forever at the boot screen. It=E2=80=99s done it to me on 2012R2 and 2016 a = few times. I moved a bunch of my VMs around and have to go back and check th= e servers where I tried that. I did it the way you did. Remove-reboot-instal= l-reboot-stuck at boot. I ended up either restoring the VM to an archive or = using the last known good config in Windows then removing 9 and reinstalling= 8.2.2 again. The reinstall of the older drivers only works sometimes, not a= lways. It=E2=80=99s about a 50/50 chance I=E2=80=99ll have to restore from a backup so b= efore I even try, I back up the VM first. I did a fresh 2012R2 install with = the 9.0.0 drivers and it=E2=80=99s solid. It=E2=80=99s only on reinstall/upgrade. If you= go back to my first email on the topic of 9.0.0, this was the cause of that= issue back then, I just didn=E2=80=99t have all the steps to recreate the issue y= et. 

 

Thanks,

Steffan Cline

steffan@hldns.com

602-793-00= 14



=

On Apr 8, 2020, at 1:24 AM, Paul Durrant <xa= dimgnik@gmail.com> wrote:

=EF=BB=BF

Hi Steffan,

 

=C2=A0 [Cc-ing Owen as he=E2=80=99s probably got more experience dealing with upgra= de than I have]

=C2=A0 By= =E2=80=98never boots up=E2=80=99, do you mean spinning forever at the splash screen or = a BSOD? I=E2=80=99ve used the remove-reboot-install-reboot cycle in the past and i= t worked for me but maybe some change in 9.0 has broken something since I la= st did it. Do you have the qemu log?

 

=C2=A0 Paul

 

 

From: win-p= v-devel <win-pv-devel-bounces@lists.xenproject.org> On Behalf Of Steffan Cline
Sent: 06 April 2020 22:15
To: win-pv-dev= el@lists.xenproject.org
Subject: [win-pv-devel] Upgrade to 9.0.0 D= rivers

 =

I=E2=80=99ve found something= recently with upgrading from 8.2 to 9.0. Every time I try to install the 9.= 0 drivers into a VM that had the 8.2 version, it never boots up. It doesn=E2=80=99= t matter if I try to install over the top or remove, reboot, install, reboot= . I=E2=80=99m SOL. The version of Windows doesn=E2=80=99t seem to matter. I=E2=80=99ve tried t= his now with 2012 and 2016 with no luck.

 

I installed them in a fresh 2012 build= and it was fine so it really seems to upgrading.

 

Any known good way to upgrade= and have a working VM?

 

 

 

Thank you,

Steffan Cline

= steffan@hldns.com

602-793-0014 

=  

--B_3669618745_1862506610-- From win-pv-devel-bounces@lists.xenproject.org Mon Apr 27 10:57:38 2020 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 27 Apr 2020 10:57:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jT1SC-0003oN-VN; Mon, 27 Apr 2020 10:57:36 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jT1SB-0003oI-Cm for win-pv-devel@lists.xenproject.org; Mon, 27 Apr 2020 10:57:35 +0000 X-Inumbo-ID: e64276d0-8875-11ea-b07b-bc764e2007e4 Received: from eddie3.eng.citrite.net (unknown [185.25.67.249]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id e64276d0-8875-11ea-b07b-bc764e2007e4; Mon, 27 Apr 2020 10:57:34 +0000 (UTC) Received: by eddie3.eng.citrite.net (Postfix, from userid 2105) id 9DCC014A43C; Mon, 27 Apr 2020 11:38:49 +0100 (BST) From: Owen Smith To: win-pv-devel@lists.xenproject.org Subject: [PATCH] Make sure fixed size CHAR arrays can fit MAX_ULONGs Date: Mon, 27 Apr 2020 11:38:47 +0100 Message-Id: <1587983927-76500-1-git-send-email-owen.smith@citrix.com> X-Mailer: git-send-email 1.8.3.1 X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Owen Smith Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" When formatting strings with %u, make sure the target buffer is large enough to contain MAX_ULONG. Signed-off-by: Owen Smith --- src/xenvif/fdo.c | 4 +++- src/xenvif/frontend.c | 8 ++++++-- src/xenvif/mac.c | 4 +++- 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/src/xenvif/fdo.c b/src/xenvif/fdo.c index 00e0c8a..896107c 100644 --- a/src/xenvif/fdo.c +++ b/src/xenvif/fdo.c @@ -801,7 +801,7 @@ __FdoEnumerate( if (Device->Length != 0) { ULONG Number; - CHAR Prefix[sizeof ("device/vif/XX")]; + CHAR Prefix[sizeof ("device/vif/XXXXXXXXXX")]; PCHAR Address; Number = strtol(Device->Buffer, NULL, 10); @@ -811,6 +811,8 @@ __FdoEnumerate( "device/vif/%u", Number); ASSERT(NT_SUCCESS(status)); + if (!NT_SUCCESS(status)) + continue; status = XENBUS_STORE(Read, &Fdo->StoreInterface, diff --git a/src/xenvif/frontend.c b/src/xenvif/frontend.c index 0ed68df..ffd6111 100644 --- a/src/xenvif/frontend.c +++ b/src/xenvif/frontend.c @@ -706,7 +706,7 @@ FrontendDumpAddressTable( switch (Frontend->AddressTable[Index].si_family) { case AF_INET: { IPV4_ADDRESS Address; - CHAR Node[sizeof ("ipv4/XXXXXXXX")]; + CHAR Node[sizeof ("ipv4/XXXXXXXXXX")]; RtlCopyMemory(Address.Byte, &Frontend->AddressTable[Index].Ipv4.sin_addr.s_addr, @@ -717,6 +717,8 @@ FrontendDumpAddressTable( "ipv4/%u", IpVersion4Count); ASSERT(NT_SUCCESS(status)); + if (!NT_SUCCESS(status)) + continue; status = XENBUS_STORE(Printf, &Frontend->StoreInterface, @@ -736,7 +738,7 @@ FrontendDumpAddressTable( } case AF_INET6: { IPV6_ADDRESS Address; - CHAR Node[sizeof ("ipv6/XXXXXXXX")]; + CHAR Node[sizeof ("ipv6/XXXXXXXXXX")]; RtlCopyMemory(Address.Byte, &Frontend->AddressTable[Index].Ipv6.sin6_addr.s6_addr, @@ -747,6 +749,8 @@ FrontendDumpAddressTable( "ipv6/%u", IpVersion6Count); ASSERT(NT_SUCCESS(status)); + if (!NT_SUCCESS(status)) + continue; status = XENBUS_STORE(Printf, &Frontend->StoreInterface, diff --git a/src/xenvif/mac.c b/src/xenvif/mac.c index 19666fe..3301ef9 100644 --- a/src/xenvif/mac.c +++ b/src/xenvif/mac.c @@ -357,13 +357,15 @@ MacDumpAddressTable( "mac"); for (Index = 0; Index < Count; Index++) { - CHAR Node[sizeof ("mac/XX")]; + CHAR Node[sizeof ("mac/XXXXXXXXXX")]; status = RtlStringCbPrintfA(Node, sizeof (Node), "mac/%u", Index); ASSERT(NT_SUCCESS(status)); + if (!NT_SUCCESS(status)) + continue; (VOID) XENBUS_STORE(Printf, &Mac->StoreInterface, -- 2.16.2.windows.1 From win-pv-devel-bounces@lists.xenproject.org Mon Apr 27 11:33:03 2020 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 27 Apr 2020 11:33:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jT20U-0008U7-N9; Mon, 27 Apr 2020 11:33:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jT20T-0008U2-Hv for win-pv-devel@lists.xenproject.org; Mon, 27 Apr 2020 11:33:01 +0000 X-Inumbo-ID: d941154a-887a-11ea-9887-bc764e2007e4 Received: from mail-wr1-x436.google.com (unknown [2a00:1450:4864:20::436]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d941154a-887a-11ea-9887-bc764e2007e4; Mon, 27 Apr 2020 11:33:00 +0000 (UTC) Received: by mail-wr1-x436.google.com with SMTP id t14so20087404wrw.12 for ; Mon, 27 Apr 2020 04:33:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:to:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:content-language :thread-index; bh=+U8yeGn5xTF68ZEaJgCP8ns2Xmq46lDKPpQE5vpdFQ4=; b=d1i1hJoOo8LhzbXJf3YhMiq8XiFUHYionuQnK6WxlTrGnA/RVqfC1WJv8HJV+xC96s 2qkqjgLaQ6gN32KZm6zTztHqlEpvA5n889/xnv7eylUgiUZcIo1t0sj/zk1N2co7PLBe 2sf3sz45OZTHJc7DRDEOXREM5O5KOGT6VWtEQz1fmr5HJ3kOIuPW8YNQTYxY4MH4JWM3 FlquT8gBZMQ+KFftYifY32h2R1qSZINvpTMzKXhN7pfI6Cf7WK2FmVfsZ8+f39yn6pqR T76hmYbVeG5aNtltBsTpwPaXDZK+PEhvMFj8FpVChDlwmcZIbIDveMidrZaHo2uWoWx2 9MxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:to:references:in-reply-to:subject :date:message-id:mime-version:content-transfer-encoding :content-language:thread-index; bh=+U8yeGn5xTF68ZEaJgCP8ns2Xmq46lDKPpQE5vpdFQ4=; b=iODQSVIg3HPEgS88bpHGz94PIZqBJhH/S1XcFVgENJIT138xQz7/m4G9WzX7KWkoXZ IEVNPXeaJuf0sPq6V6H+Yx7WwVvzDy9IiLefWtE63qwZqbxcsLWRqX1YzwFUfSzGG6PX +uTzXc64kWuLFD53DBXAW0bwmtPnA4hcUm25rV3OkzrPkmUy/JWS1IhmSLKyrXlvHlJq hL/uGSOPyeGT9kNluWaYrExT+f8oS99T2+RVBkrb4n5NAGSjGxP4g/pdsperNtQQfC78 BPTdEZIMDkK6GvZh/ICQJFnn097D1dontcZEZHPIewkW7UReZaWKhjMX0V5LyRexKY0g XZiA== X-Gm-Message-State: AGi0Puafs7YhWst/2YZp/eM/xC1xru7FouTyauErL59C9+pUzZF5m6uI 8yLaOHrEFA4EF0IqMJkW4Bg= X-Google-Smtp-Source: APiQypJriMz/yvea8AQPWtd5OXCaDBZl5rSlF+cC67dmYpYXc/NaNvAN5OCeV+FfVeCdbuFZEj35bA== X-Received: by 2002:a5d:45cf:: with SMTP id b15mr26248279wrs.78.1587987179737; Mon, 27 Apr 2020 04:32:59 -0700 (PDT) Received: from CBGR90WXYV0 ([54.239.6.186]) by smtp.gmail.com with ESMTPSA id l15sm14804709wmi.48.2020.04.27.04.32.58 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Apr 2020 04:32:58 -0700 (PDT) From: Paul Durrant X-Google-Original-From: "Paul Durrant" To: "'Owen Smith'" , References: <1587983927-76500-1-git-send-email-owen.smith@citrix.com> In-Reply-To: <1587983927-76500-1-git-send-email-owen.smith@citrix.com> Subject: RE: [PATCH] Make sure fixed size CHAR arrays can fit MAX_ULONGs Date: Mon, 27 Apr 2020 12:32:57 +0100 Message-ID: <000d01d61c87$9a4f76b0$ceee6410$@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: en-gb Thread-Index: AQE5GYsHNCU240Ad2zr4GegWD/rREqnG2+WA X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: paul@xen.org Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" > -----Original Message----- > From: win-pv-devel On Behalf Of Owen Smith > Sent: 27 April 2020 11:39 > To: win-pv-devel@lists.xenproject.org > Cc: Owen Smith > Subject: [PATCH] Make sure fixed size CHAR arrays can fit MAX_ULONGs > > When formatting strings with %u, make sure the target buffer is large > enough to contain MAX_ULONG. > > Signed-off-by: Owen Smith Acked-by: Paul Durrant > --- > src/xenvif/fdo.c | 4 +++- > src/xenvif/frontend.c | 8 ++++++-- > src/xenvif/mac.c | 4 +++- > 3 files changed, 12 insertions(+), 4 deletions(-) > > diff --git a/src/xenvif/fdo.c b/src/xenvif/fdo.c > index 00e0c8a..896107c 100644 > --- a/src/xenvif/fdo.c > +++ b/src/xenvif/fdo.c > @@ -801,7 +801,7 @@ __FdoEnumerate( > > if (Device->Length != 0) { > ULONG Number; > - CHAR Prefix[sizeof ("device/vif/XX")]; > + CHAR Prefix[sizeof ("device/vif/XXXXXXXXXX")]; > PCHAR Address; > > Number = strtol(Device->Buffer, NULL, 10); > @@ -811,6 +811,8 @@ __FdoEnumerate( > "device/vif/%u", > Number); > ASSERT(NT_SUCCESS(status)); > + if (!NT_SUCCESS(status)) > + continue; > > status = XENBUS_STORE(Read, > &Fdo->StoreInterface, > diff --git a/src/xenvif/frontend.c b/src/xenvif/frontend.c > index 0ed68df..ffd6111 100644 > --- a/src/xenvif/frontend.c > +++ b/src/xenvif/frontend.c > @@ -706,7 +706,7 @@ FrontendDumpAddressTable( > switch (Frontend->AddressTable[Index].si_family) { > case AF_INET: { > IPV4_ADDRESS Address; > - CHAR Node[sizeof ("ipv4/XXXXXXXX")]; > + CHAR Node[sizeof ("ipv4/XXXXXXXXXX")]; > > RtlCopyMemory(Address.Byte, > &Frontend->AddressTable[Index].Ipv4.sin_addr.s_addr, > @@ -717,6 +717,8 @@ FrontendDumpAddressTable( > "ipv4/%u", > IpVersion4Count); > ASSERT(NT_SUCCESS(status)); > + if (!NT_SUCCESS(status)) > + continue; > > status = XENBUS_STORE(Printf, > &Frontend->StoreInterface, > @@ -736,7 +738,7 @@ FrontendDumpAddressTable( > } > case AF_INET6: { > IPV6_ADDRESS Address; > - CHAR Node[sizeof ("ipv6/XXXXXXXX")]; > + CHAR Node[sizeof ("ipv6/XXXXXXXXXX")]; > > RtlCopyMemory(Address.Byte, > &Frontend->AddressTable[Index].Ipv6.sin6_addr.s6_addr, > @@ -747,6 +749,8 @@ FrontendDumpAddressTable( > "ipv6/%u", > IpVersion6Count); > ASSERT(NT_SUCCESS(status)); > + if (!NT_SUCCESS(status)) > + continue; > > status = XENBUS_STORE(Printf, > &Frontend->StoreInterface, > diff --git a/src/xenvif/mac.c b/src/xenvif/mac.c > index 19666fe..3301ef9 100644 > --- a/src/xenvif/mac.c > +++ b/src/xenvif/mac.c > @@ -357,13 +357,15 @@ MacDumpAddressTable( > "mac"); > > for (Index = 0; Index < Count; Index++) { > - CHAR Node[sizeof ("mac/XX")]; > + CHAR Node[sizeof ("mac/XXXXXXXXXX")]; > > status = RtlStringCbPrintfA(Node, > sizeof (Node), > "mac/%u", > Index); > ASSERT(NT_SUCCESS(status)); > + if (!NT_SUCCESS(status)) > + continue; > > (VOID) XENBUS_STORE(Printf, > &Mac->StoreInterface, > -- > 2.16.2.windows.1 > From win-pv-devel-bounces@lists.xenproject.org Mon Apr 27 21:02:53 2020 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 27 Apr 2020 21:02:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jTAtu-00057G-UP; Mon, 27 Apr 2020 21:02:50 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jTAtu-00057B-3I for win-pv-devel@lists.xenproject.org; Mon, 27 Apr 2020 21:02:50 +0000 Date: Mon, 27 Apr 2020 21:02:49 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <14417827.1.1588021372220.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> Subject: XENVIF-master - Build #179 - Successful MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_0_9441676.1588021371314" X-Jenkins-Job: XENVIF-master X-Jenkins-Result: SUCCESS X-BeenThere: win-pv-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Sender: "win-pv-devel" ------=_Part_0_9441676.1588021371314 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #179. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENVIF-master/179/console to view the results. ------=_Part_0_9441676.1588021371314--