From win-pv-devel-bounces@lists.xenproject.org Mon Jul 05 13:00:04 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 05 Jul 2021 13:00:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.150198.277751 (Exim 4.92) (envelope-from ) id 1m0OCh-0006tM-AL; Mon, 05 Jul 2021 13:00:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 150198.277751; Mon, 05 Jul 2021 13:00:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0OCh-0006tF-6z; Mon, 05 Jul 2021 13:00:03 +0000 Received: by outflank-mailman (input) for mailman id 150198; Mon, 05 Jul 2021 13:00:01 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0OCf-0006ax-Nn for win-pv-devel@lists.xenproject.org; Mon, 05 Jul 2021 13:00:01 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e691831c-dd90-11eb-8446-12813bfff9fa; Mon, 05 Jul 2021 12:59:58 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: e691831c-dd90-11eb-8446-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625489998; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=grsbWfJzqFC5jbduydLjVW3Eroq2rFn9YEz+H0qj4WQ=; b=IgsXMhguBm11aVqbCt5RRmXdiTCUw+4ctrqr1/DNzaLdq+TRlI5tNaiE HHIXFfwLO10ae9LXuAskEPp5IZaIOyMljbxBcisU3j7TNSVM3kHR40k/V a4Lo/QuQ1jLituMY4iq/qmX1kfN3mNrtE80pYp2x/MuuKVS9QrhoBwSo2 g=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: deABC9fdQbxw+seHIRRvxS9aVe31ZHV69OPA8KAAWBlqURMLiPpJtSN4h8pSGnkWTXUkdoT5im 5Zb39VtQNKA5OjU30VpEjhgxeGNztnY82T0hUBbbGONE31TesRGyPYrnNiHV883DE4y0fRTn8Y UqLFj3PrCAf6GWfpPOOTN4rVpLVgloRKVhgxTyiuAZV+zXCBGzSzow4xyAeD/Edbj3Lr5+1p5t DGxtiRrCHp/Iv/nvnTkKEyebumv1vCXTSpNAujp7FdE28IOjZ7AS486rG+woIk+KDMJkR/a1ug od4= X-SBRS: 5.1 X-MesageID: 49206188 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:GfeJoqldaUKLTB6qz+zUNhOHcr/pDfIf3DAbv31ZSRFFG/Fwz/ re/sjzpiWE7Qr5OUtQ4OxoV5PvfZqxz/VICMwqTNSftWrdyROVxeNZjLcKqgeIcxEWtNQ86U 4KScVD4ajLYmSS+vyX3ODXKbwdKZK8gcSVbK/lvhBQpC9RGsdd0zs= X-IronPort-AV: E=Sophos;i="5.83,325,1616472000"; d="scan'208";a="49206188" From: Owen Smith To: CC: Owen Smith Subject: [PATCH 1/2] Refactor XenAgent Date: Mon, 5 Jul 2021 13:59:50 +0100 Message-ID: <20210705125951.2031-1-owen.smith@citrix.com> X-Mailer: git-send-email 2.31.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain - Merge IDeviceCreator interface into CDeviceList base class - Add CXenIfaceDeviceList and CConvDeviceList, derived from CDeviceList - Moves IFace functionality to CXenIfaceDeviceList - Moves Conv device functionality to CConvDeviceList - Seperate RegisterDeviceNotification from SetupApi enumeration, so that static devices do not need to hold the handle open (i.e. Conv device) - CConvDeviceList only opens the handle when neccessary, as the MS driver for the ACPI device only allows 1 open handle at a time. Signed-off-by: Owen Smith --- src/xenagent/convdevice.cpp | 59 +++- src/xenagent/convdevice.h | 22 ++ src/xenagent/devicelist.cpp | 166 ++++++----- src/xenagent/devicelist.h | 57 ++-- src/xenagent/service.cpp | 486 +------------------------------- src/xenagent/service.h | 86 +----- src/xenagent/xenifacedevice.cpp | 348 +++++++++++++++++++++++ src/xenagent/xenifacedevice.h | 43 +++ 8 files changed, 619 insertions(+), 648 deletions(-) diff --git a/src/xenagent/convdevice.cpp b/src/xenagent/convdevice.cpp index 5ac40ff..5a25be1 100644 --- a/src/xenagent/convdevice.cpp +++ b/src/xenagent/convdevice.cpp @@ -29,6 +29,7 @@ * SUCH DAMAGE. */ +#define INITGUID #include #include #include @@ -37,6 +38,11 @@ #include "service.h" #include "convdevice.h" #include "devicelist.h" +#include "messages.h" + +/* 317fc439-3f77-41c8-b09e-08ad63272aa3 */ +DEFINE_GUID(GUID_GPIOBUTTONS_LAPTOPSLATE_INTERFACE, \ + 0x317fc439, 0x3f77, 0x41c8, 0xb0, 0x9e, 0x08, 0xad, 0x63, 0x27, 0x2a, 0xa3); CConvDevice::CConvDevice(const wchar_t* path) : CDevice(path) { @@ -65,7 +71,11 @@ void CConvDevice::SetMode(DWORD new_mode) if (current_mode == new_mode) break; - Write(&buffer, sizeof(buffer)); + if (Open()) { + Write(&buffer, sizeof(buffer)); + Close(); + } + Sleep(1000); // yield } } @@ -135,3 +145,50 @@ fail2: fail1: return false; } + +CConvDeviceList::CConvDeviceList(CXenAgent* agent) : CDeviceList(GUID_GPIOBUTTONS_LAPTOPSLATE_INTERFACE), m_agent(agent) +{} + +/*virtual*/ CConvDeviceList::~CConvDeviceList() +{} + +/*virtual*/ CDevice* CConvDeviceList::Create(const wchar_t* path) +{ + return new CConvDevice(path); +} + +/*virtual*/ void CConvDeviceList::OnDeviceAdded(CDevice* dev) +{ + UNREFERENCED_PARAMETER(dev); +} + +/*virtual*/ void CConvDeviceList::OnDeviceRemoved(CDevice* dev) +{ + UNREFERENCED_PARAMETER(dev); +} + +/*virtual*/ void CConvDeviceList::OnDeviceSuspend(CDevice* dev) +{ + UNREFERENCED_PARAMETER(dev); +} + +/*virtual*/ void CConvDeviceList::OnDeviceResume(CDevice* dev) +{ + UNREFERENCED_PARAMETER(dev); +} + +void CConvDeviceList::SetSlateMode(std::string& mode) +{ + CCritSec crit(&m_crit); + CConvDevice* device = (CConvDevice*)GetFirstDevice(); + + if (device == NULL) + return; + + m_agent->EventLog(EVENT_XENUSER_MODE_SWITCH); + + if (mode == "laptop") + device->SetMode(CCONV_DEVICE_LAPTOP_MODE); + else if (mode == "slate") + device->SetMode(CCONV_DEVICE_SLATE_MODE); +} diff --git a/src/xenagent/convdevice.h b/src/xenagent/convdevice.h index 90f8035..088ff15 100644 --- a/src/xenagent/convdevice.h +++ b/src/xenagent/convdevice.h @@ -56,4 +56,26 @@ private: bool GetMode(DWORD *mode); }; +class CXenAgent; + +class CConvDeviceList : public CDeviceList +{ +public: + CConvDeviceList(CXenAgent* agent); + virtual ~CConvDeviceList(); + +protected: // CDeviceList + virtual CDevice* Create(const wchar_t* path); + virtual void OnDeviceAdded(CDevice* dev); + virtual void OnDeviceRemoved(CDevice* dev); + virtual void OnDeviceSuspend(CDevice* dev); + virtual void OnDeviceResume(CDevice* dev); + +public: + void SetSlateMode(std::string& mode); + +private: + CXenAgent* m_agent; +}; + #endif diff --git a/src/xenagent/devicelist.cpp b/src/xenagent/devicelist.cpp index 4acf532..d6af5d4 100644 --- a/src/xenagent/devicelist.cpp +++ b/src/xenagent/devicelist.cpp @@ -65,6 +65,15 @@ static void DebugPrint(const wchar_t* fmt, ...) OutputDebugStringW(buffer); } +CCritSec::CCritSec(LPCRITICAL_SECTION crit) : m_crit(crit) +{ + EnterCriticalSection(m_crit); +} +CCritSec::~CCritSec() +{ + LeaveCriticalSection(m_crit); +} + CDevice::CDevice(const wchar_t* path) : m_handle(INVALID_HANDLE_VALUE), m_path(path), m_notify(NULL) { @@ -81,6 +90,11 @@ const wchar_t* CDevice::Path() const return m_path.c_str(); } +HDEVNOTIFY CDevice::Notify() const +{ + return m_notify; +} + bool CDevice::Open() { Close(); @@ -104,7 +118,7 @@ void CDevice::Close() m_handle = INVALID_HANDLE_VALUE; } -HDEVNOTIFY CDevice::Register(HANDLE svc) +bool CDevice::Register(HANDLE svc) { Unregister(); @@ -114,7 +128,7 @@ HDEVNOTIFY CDevice::Register(HANDLE svc) devhdl.dbch_handle = m_handle; m_notify = RegisterDeviceNotification(svc, &devhdl, DEVICE_NOTIFY_SERVICE_HANDLE); - return m_notify; + return (m_notify != NULL); } void CDevice::Unregister() @@ -162,24 +176,32 @@ bool CDevice::Ioctl(DWORD ioctl, void* in, DWORD insz, void* out, DWORD outsz, D } CDeviceList::CDeviceList(const GUID& itf) : - m_guid(itf), m_notify(NULL), m_handle(NULL), m_impl(NULL) + m_guid(itf), m_notify(NULL), m_handle(NULL) { + InitializeCriticalSection(&m_crit); } CDeviceList::~CDeviceList() { - Stop(); + UnregisterForDeviceChange(); + CleanupDeviceList(); + + DeleteCriticalSection(&m_crit); } -#pragma warning(push) -#pragma warning(disable:6102) // Using value from failed function call +CDevice* CDeviceList::GetFirstDevice() +{ + DeviceMap::iterator it = m_devs.begin(); + if (it == m_devs.end()) + return NULL; + return *it; +} -bool CDeviceList::Start(HANDLE handle, IDeviceCreator* impl) +bool CDeviceList::RegisterForDeviceChange(HANDLE handle) { - Stop(); + UnregisterForDeviceChange(); m_handle = handle; - m_impl = impl; DEV_BROADCAST_DEVICEINTERFACE dev = { 0 }; dev.dbcc_size = sizeof(dev); @@ -187,9 +209,21 @@ bool CDeviceList::Start(HANDLE handle, IDeviceCreator* impl) dev.dbcc_classguid = m_guid; m_notify = RegisterDeviceNotificationA(handle, &dev, DEVICE_NOTIFY_SERVICE_HANDLE); - if (m_notify == NULL) - return false; + return m_notify != NULL; +} + +void CDeviceList::UnregisterForDeviceChange() +{ + if (m_notify != NULL) + UnregisterDeviceNotification(m_notify); + m_notify = NULL; +} +#pragma warning(push) +#pragma warning(disable:6102) // Using value from failed function call + +void CDeviceList::EnumerateDevices() +{ HDEVINFO info; SP_DEVICE_INTERFACE_DATA itf; PSP_DEVICE_INTERFACE_DETAIL_DATA detail; @@ -201,7 +235,7 @@ bool CDeviceList::Start(HANDLE handle, IDeviceCreator* impl) NULL, DIGCF_PRESENT | DIGCF_DEVICEINTERFACE); if (info == INVALID_HANDLE_VALUE) - return true; // non fatal, just missing already present device(s) + return; // non fatal, just missing already present device(s) itf.cbSize = sizeof(SP_DEVICE_INTERFACE_DATA); for (idx = 0; @@ -229,23 +263,17 @@ bool CDeviceList::Start(HANDLE handle, IDeviceCreator* impl) itf.cbSize = sizeof(SP_DEVICE_INTERFACE_DATA); } SetupDiDestroyDeviceInfoList(info); - return true; } #pragma warning(pop) -void CDeviceList::Stop() +void CDeviceList::CleanupDeviceList() { - if (m_notify != NULL) - UnregisterDeviceNotification(m_notify); - m_notify = NULL; - for (DeviceMap::iterator it = m_devs.begin(); it != m_devs.end(); ++it) { - if (m_impl) - m_impl->OnDeviceRemoved(it->second); - delete it->second; + OnDeviceRemoved(*it); + delete *it; } m_devs.clear(); } @@ -302,14 +330,14 @@ void CDeviceList::OnPowerEvent(DWORD evt, LPVOID data) for (DeviceMap::iterator it = m_devs.begin(); it != m_devs.end(); ++it) - m_impl->OnDeviceResume(it->second); + OnDeviceResume(*it); break; case PBT_APMSUSPEND: for (DeviceMap::iterator it = m_devs.begin(); it != m_devs.end(); ++it) - m_impl->OnDeviceSuspend(it->second); + OnDeviceSuspend(*it); break; default: @@ -317,37 +345,25 @@ void CDeviceList::OnPowerEvent(DWORD evt, LPVOID data) } } -CDevice* CDeviceList::GetFirstDevice() -{ - DeviceMap::iterator it = m_devs.begin(); - if (it == m_devs.end()) - return NULL; - return it->second; -} - void CDeviceList::DeviceArrival(const std::wstring& path) { DebugPrint(L"DeviceArrival(%ws)\n", path.c_str()); - CDevice* dev; - if (m_impl) - dev = m_impl->Create(path.c_str()); - else - dev = new CDevice(path.c_str()); + CDevice* dev = Create(path.c_str()); if (dev == NULL) goto fail1; + if (m_handle == NULL) + goto done; + if (!dev->Open()) goto fail2; - HDEVNOTIFY nfy = dev->Register(m_handle); - if (nfy == NULL) + if (!dev->Register(m_handle)) goto fail3; - m_devs[nfy] = dev; - - if (m_impl) - m_impl->OnDeviceAdded(dev); - +done: + OnDeviceAdded(dev); + m_devs.push_back(dev); return; fail3: @@ -362,44 +378,60 @@ fail1: void CDeviceList::DeviceRemoved(HDEVNOTIFY nfy) { - DeviceMap::iterator it = m_devs.find(nfy); - if (it == m_devs.end()) - return; // spurious event? + for (DeviceMap::iterator it = m_devs.begin(); + it != m_devs.end(); + ++it) { + CDevice* dev = *it; + + if (dev->Notify() != nfy) + continue; - CDevice* dev = it->second; - DebugPrint(L"DeviceRemoved(%ws)\n", dev->Path()); + DebugPrint(L"DeviceRemoved(%ws)\n", dev->Path()); - delete dev; // handles unregister() - m_devs.erase(it); + delete dev; // handles unregister() + m_devs.erase(it); + return; + } + // Spurious event? } void CDeviceList::DeviceRemovePending(HDEVNOTIFY nfy) { - DeviceMap::iterator it = m_devs.find(nfy); - if (it == m_devs.end()) - return; // spurious event? + for (DeviceMap::iterator it = m_devs.begin(); + it != m_devs.end(); + ++it) { + CDevice* dev = *it; - CDevice* dev = it->second; - DebugPrint(L"DeviceRemovePending(%ws)\n", dev->Path()); + if (dev->Notify() != nfy) + continue; + + DebugPrint(L"DeviceRemovePending(%ws)\n", dev->Path()); - if (m_impl) - m_impl->OnDeviceRemoved(dev); + OnDeviceRemoved(dev); - dev->Close(); + dev->Close(); + return; + } + // Spurious event? } void CDeviceList::DeviceRemoveFailed(HDEVNOTIFY nfy) { - DeviceMap::iterator it = m_devs.find(nfy); - if (it == m_devs.end()) - return; // spurious event? + for (DeviceMap::iterator it = m_devs.begin(); + it != m_devs.end(); + ++it) { + CDevice* dev = *it; - CDevice* dev = it->second; - DebugPrint(L"DeviceRemoveFailed(%ws)\n", dev->Path()); + if (dev->Notify() != nfy) + continue; - if (!dev->Open()) - DeviceRemoved(nfy); + DebugPrint(L"DeviceRemoveFailed(%ws)\n", dev->Path()); + + if (!dev->Open()) + DeviceRemoved(nfy); - if (m_impl) - m_impl->OnDeviceAdded(dev); + OnDeviceAdded(dev); + return; + } + // Spurious event? } diff --git a/src/xenagent/devicelist.h b/src/xenagent/devicelist.h index e96df56..3e260f8 100644 --- a/src/xenagent/devicelist.h +++ b/src/xenagent/devicelist.h @@ -34,9 +34,18 @@ #include #include -#include +#include #include +class CCritSec +{ +public: + CCritSec(LPCRITICAL_SECTION crit); + ~CCritSec(); +private: + LPCRITICAL_SECTION m_crit; +}; + class CDevice { public: @@ -44,10 +53,11 @@ public: virtual ~CDevice(); const wchar_t* Path() const; + HDEVNOTIFY Notify() const; bool Open(); void Close(); - HDEVNOTIFY Register(HANDLE svc); + bool Register(HANDLE svc); void Unregister(); protected: @@ -60,27 +70,31 @@ private: HDEVNOTIFY m_notify; }; -class IDeviceCreator +class CDeviceList { -public: +protected: + CDeviceList(const GUID& itf); + virtual CDevice* Create(const wchar_t* path) = 0; - virtual void OnDeviceAdded(CDevice* dev) = 0; - virtual void OnDeviceRemoved(CDevice* dev) = 0; - virtual void OnDeviceSuspend(CDevice* dev) = 0; - virtual void OnDeviceResume(CDevice* dev) = 0; -}; + virtual void OnDeviceAdded(CDevice* dev) = 0; + virtual void OnDeviceRemoved(CDevice* dev) = 0; + virtual void OnDeviceSuspend(CDevice* dev) = 0; + virtual void OnDeviceResume(CDevice* dev) = 0; + + CRITICAL_SECTION m_crit; -class CDeviceList -{ public: - CDeviceList(const GUID& itf); - ~CDeviceList(); + virtual ~CDeviceList(); + + CDevice* GetFirstDevice(); + + bool RegisterForDeviceChange(HANDLE svc); + void UnregisterForDeviceChange(); + void EnumerateDevices(); + void CleanupDeviceList(); - bool Start(HANDLE svc, IDeviceCreator* impl); - void Stop(); void OnDeviceEvent(DWORD evt, LPVOID data); void OnPowerEvent(DWORD evt, LPVOID data); - CDevice* GetFirstDevice(); private: void DeviceArrival(const std::wstring& path); @@ -88,13 +102,12 @@ private: void DeviceRemovePending(HDEVNOTIFY nfy); void DeviceRemoveFailed(HDEVNOTIFY nfy); - typedef std::map< HDEVNOTIFY, CDevice* > DeviceMap; + typedef std::vector< CDevice* > DeviceMap; - GUID m_guid; - DeviceMap m_devs; - HDEVNOTIFY m_notify; - HANDLE m_handle; - IDeviceCreator* m_impl; + GUID m_guid; + DeviceMap m_devs; + HDEVNOTIFY m_notify; + HANDLE m_handle; }; #endif diff --git a/src/xenagent/service.cpp b/src/xenagent/service.cpp index 85fac63..535d761 100644 --- a/src/xenagent/service.cpp +++ b/src/xenagent/service.cpp @@ -29,478 +29,14 @@ * SUCH DAMAGE. */ -#define INITGUID #include #include #include #include -#include - #include "service.h" #include "messages.h" - -class CCritSec -{ -public: - CCritSec(LPCRITICAL_SECTION crit); - ~CCritSec(); -private: - LPCRITICAL_SECTION m_crit; -}; - -CCritSec::CCritSec(LPCRITICAL_SECTION crit) : m_crit(crit) -{ - EnterCriticalSection(m_crit); -} -CCritSec::~CCritSec() -{ - LeaveCriticalSection(m_crit); -} - -CXenIfaceCreator::CXenIfaceCreator(CXenAgent& agent) : - m_devlist(GUID_INTERFACE_XENIFACE), m_device(NULL), - m_ctxt_shutdown(NULL), m_ctxt_suspend(NULL), - m_ctxt_slate_mode(NULL), m_agent(agent) -{ - m_evt_shutdown = CreateEvent(NULL, TRUE, FALSE, NULL); - m_evt_suspend = CreateEvent(NULL, TRUE, FALSE, NULL); - m_evt_slate_mode = CreateEvent(NULL, TRUE, FALSE, NULL); - m_count = 0; - - InitializeCriticalSection(&m_crit); -} - -CXenIfaceCreator::~CXenIfaceCreator() -{ - CloseHandle(m_evt_slate_mode); - CloseHandle(m_evt_suspend); - CloseHandle(m_evt_shutdown); - - DeleteCriticalSection(&m_crit); -} - -bool CXenIfaceCreator::Start(HANDLE svc) -{ - return m_devlist.Start(svc, this); -} - -void CXenIfaceCreator::Stop() -{ - // Check if registry key is present, implies Windows Update - // require a reboot, which may spend time installing updates - LogIfRebootPending(); - - m_devlist.Stop(); -} - -void CXenIfaceCreator::OnDeviceEvent(DWORD evt, LPVOID data) -{ - m_devlist.OnDeviceEvent(evt, data); -} - -void CXenIfaceCreator::OnPowerEvent(DWORD evt, LPVOID data) -{ - m_devlist.OnPowerEvent(evt, data); -} - -void CXenIfaceCreator::Log(const char* message) -{ - // if possible, send to xeniface to forward to logs - if (m_device && TryEnterCriticalSection(&m_crit)) { - m_device->Log(message); - LeaveCriticalSection(&m_crit); - } -} - -/*virtual*/ CDevice* CXenIfaceCreator::Create(const wchar_t* path) -{ - return new CXenIfaceDevice(path); -} - -/*virtual*/ void CXenIfaceCreator::OnDeviceAdded(CDevice* dev) -{ - CXenAgent::Log("OnDeviceAdded(%ws)\n", dev->Path()); - - CCritSec crit(&m_crit); - if (m_device == NULL) { - m_device = (CXenIfaceDevice*)dev; - - m_device->SuspendRegister(m_evt_suspend, &m_ctxt_suspend); - - StartShutdownWatch(); - - if (m_agent.ConvDevicePresent()) - StartSlateModeWatch(); - - SetXenTime(); - } -} - -/*virtual*/ void CXenIfaceCreator::OnDeviceRemoved(CDevice* dev) -{ - CXenAgent::Log("OnDeviceRemoved(%ws)\n", dev->Path()); - - CCritSec crit(&m_crit); - if (m_device == dev) { - if (m_ctxt_suspend) { - m_device->SuspendDeregister(m_ctxt_suspend); - m_ctxt_suspend = NULL; - } - - if (m_agent.ConvDevicePresent()) - StopSlateModeWatch(); - - StopShutdownWatch(); - - m_device = NULL; - } -} - -/*virtual*/ void CXenIfaceCreator::OnDeviceSuspend(CDevice* dev) -{ - CXenAgent::Log("OnDeviceSuspend(%ws)\n", dev->Path()); - - if (m_agent.ConvDevicePresent()) - StopSlateModeWatch(); - - StopShutdownWatch(); -} - -/*virtual*/ void CXenIfaceCreator::OnDeviceResume(CDevice* dev) -{ - CXenAgent::Log("OnDeviceResume(%ws)\n", dev->Path()); - - StartShutdownWatch(); - - if (m_agent.ConvDevicePresent()) - StartSlateModeWatch(); -} - -bool CXenIfaceCreator::CheckShutdown() -{ - CCritSec crit(&m_crit); - if (m_device == NULL) - return false; - - std::string type; - if (!m_device->StoreRead("control/shutdown", type)) - return false; - - if (type != "") - CXenAgent::Log("Shutdown(%ws) = '%s'\n", m_device->Path(), type.c_str()); - - if (type == "poweroff") { - m_device->StoreWrite("control/shutdown", ""); - m_agent.EventLog(EVENT_XENUSER_POWEROFF); - - AcquireShutdownPrivilege(); -#pragma warning(suppress:28159) /* Consider using a design alternative... Rearchitect to avoid Reboot */ - if (!InitiateSystemShutdownEx(NULL, NULL, 0, TRUE, FALSE, - SHTDN_REASON_MAJOR_OTHER | - SHTDN_REASON_MINOR_ENVIRONMENT | - SHTDN_REASON_FLAG_PLANNED)) { - CXenAgent::Log("InitiateSystemShutdownEx failed %08x\n", GetLastError()); - } - return true; - } else if (type == "reboot") { - m_device->StoreWrite("control/shutdown", ""); - m_agent.EventLog(EVENT_XENUSER_REBOOT); - - AcquireShutdownPrivilege(); -#pragma warning(suppress:28159) /* Consider using a design alternative... Rearchitect to avoid Reboot */ - if (!InitiateSystemShutdownEx(NULL, NULL, 0, TRUE, TRUE, - SHTDN_REASON_MAJOR_OTHER | - SHTDN_REASON_MINOR_ENVIRONMENT | - SHTDN_REASON_FLAG_PLANNED)) { - CXenAgent::Log("InitiateSystemShutdownEx failed %08x\n", GetLastError()); - } - return true; - } else if (type == "s4") { - m_device->StoreWrite("control/shutdown", ""); - m_agent.EventLog(EVENT_XENUSER_S4); - - AcquireShutdownPrivilege(); - if (!SetSystemPowerState(FALSE, FALSE)) { - CXenAgent::Log("SetSystemPowerState failed %08x\n", GetLastError()); - } - return false; - } else if (type == "s3") { - m_device->StoreWrite("control/shutdown", ""); - m_agent.EventLog(EVENT_XENUSER_S3); - - AcquireShutdownPrivilege(); - if (!SetSuspendState(FALSE, TRUE, FALSE)) { - CXenAgent::Log("SetSuspendState failed %08x\n", GetLastError()); - } - return false; - } - - return false; -} - -void CXenIfaceCreator::CheckXenTime() -{ - CCritSec crit(&m_crit); - if (m_device == NULL) - return; - - SetXenTime(); -} - -void CXenIfaceCreator::CheckSuspend() -{ - CCritSec crit(&m_crit); - if (m_device == NULL) - return; - - DWORD count = 0; - - if (!m_device->SuspendGetCount(&count)) - return; - - if (m_count == count) - return; - - CXenAgent::Log("Suspend(%ws)\n", m_device->Path()); - - m_agent.EventLog(EVENT_XENUSER_UNSUSPENDED); - - // recreate watches, as suspending deactivated the watch - if (m_agent.ConvDevicePresent()) - StopSlateModeWatch(); - - StopShutdownWatch(); - - StartShutdownWatch(); - - if (m_agent.ConvDevicePresent()) - StartSlateModeWatch(); - - m_count = count; -} - -bool CXenIfaceCreator::CheckSlateMode(std::string *mode) -{ - CCritSec crit(&m_crit); - if (m_device == NULL) - return false; - - if (!m_device->StoreRead("control/laptop-slate-mode", *mode)) - return false; - - if (*mode != "") - m_device->StoreWrite("control/laptop-slate-mode", ""); - - return true; -} - -void CXenIfaceCreator::LogIfRebootPending() -{ - HKEY Key; - LONG lResult; - - lResult = RegOpenKeyEx(HKEY_LOCAL_MACHINE, - "SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\WindowsUpdate\\Auto Update\\RebootRequired", - 0, - KEY_READ, - &Key); - if (lResult != ERROR_SUCCESS) - return; // key doesnt exist, dont log anything - - RegCloseKey(Key); - - CXenAgent::Log("RebootRequired detected\n"); -} - -void CXenIfaceCreator::StartShutdownWatch() -{ - if (m_ctxt_shutdown) - return; - - m_device->StoreAddWatch("control/shutdown", m_evt_shutdown, &m_ctxt_shutdown); - - m_device->StoreWrite("control/feature-poweroff", "1"); - m_device->StoreWrite("control/feature-reboot", "1"); - m_device->StoreWrite("control/feature-s3", "1"); - m_device->StoreWrite("control/feature-s4", "1"); -} - -void CXenIfaceCreator::StopShutdownWatch() -{ - if (!m_ctxt_shutdown) - return; - - m_device->StoreWrite("control/feature-poweroff", ""); - m_device->StoreWrite("control/feature-reboot", ""); - m_device->StoreWrite("control/feature-s3", ""); - m_device->StoreWrite("control/feature-s4", ""); - - m_device->StoreRemoveWatch(m_ctxt_shutdown); - m_ctxt_shutdown = NULL; -} - -void CXenIfaceCreator::StartSlateModeWatch() -{ - if (m_ctxt_slate_mode) - return; - - m_device->StoreAddWatch("control/laptop-slate-mode", m_evt_slate_mode, &m_ctxt_slate_mode); - m_device->StoreWrite("control/feature-laptop-slate-mode", "1"); -} - -void CXenIfaceCreator::StopSlateModeWatch() -{ - if (!m_ctxt_slate_mode) - return; - - m_device->StoreRemove("control/feature-laptop-slate-mode"); - - m_device->StoreRemoveWatch(m_ctxt_slate_mode); - m_ctxt_slate_mode = NULL; -} - -void CXenIfaceCreator::AcquireShutdownPrivilege() -{ - HANDLE token; - TOKEN_PRIVILEGES tp; - - LookupPrivilegeValue(NULL, SE_SHUTDOWN_NAME, &tp.Privileges[0].Luid); - tp.Privileges[0].Attributes = SE_PRIVILEGE_ENABLED; - - tp.PrivilegeCount = 1; - - if (!OpenProcessToken(GetCurrentProcess(), - TOKEN_ADJUST_PRIVILEGES | TOKEN_QUERY, - &token)) - return; - - AdjustTokenPrivileges(token, FALSE, &tp, NULL, 0, NULL); - CloseHandle(token); -} - -void CXenIfaceCreator::SetXenTime() -{ - bool local; - - FILETIME now = { 0 }; - if (!m_device->SharedInfoGetTime(&now, &local)) - return; - - SYSTEMTIME cur = { 0 }; - if (local) - GetLocalTime(&cur); - else - GetSystemTime(&cur); - - SYSTEMTIME sys = { 0 }; - if (!FileTimeToSystemTime(&now, &sys)) - return; - - if (memcmp(&cur, &sys, sizeof(SYSTEMTIME)) == 0) - return; - - CXenAgent::Log("RTC is in %s\n", local ? "local time" : "UTC"); - CXenAgent::Log("Time Now = %d/%d/%d %d:%02d:%02d.%d\n", - cur.wYear, cur.wMonth, cur.wDay, - cur.wHour, cur.wMinute, cur.wSecond, cur.wMilliseconds); - CXenAgent::Log("New Time = %d/%d/%d %d:%02d:%02d.%d\n", - sys.wYear, sys.wMonth, sys.wDay, - sys.wHour, sys.wMinute, sys.wSecond, sys.wMilliseconds); - - if (local) - SetLocalTime(&sys); - else - SetSystemTime(&sys); -} - -/* 317fc439-3f77-41c8-b09e-08ad63272aa3 */ -DEFINE_GUID(GUID_GPIOBUTTONS_LAPTOPSLATE_INTERFACE, \ - 0x317fc439, 0x3f77, 0x41c8, 0xb0, 0x9e, 0x08, 0xad, 0x63, 0x27, 0x2a, 0xa3); - -CConvCreator::CConvCreator(CXenAgent& agent) : - m_devlist(GUID_GPIOBUTTONS_LAPTOPSLATE_INTERFACE), m_device(NULL), - m_agent(agent) -{ - InitializeCriticalSection(&m_crit); -} - -CConvCreator::~CConvCreator() -{ - DeleteCriticalSection(&m_crit); -} - -bool CConvCreator::Start(HANDLE svc) -{ - return m_devlist.Start(svc, this); -} - -void CConvCreator::Stop() -{ - m_devlist.Stop(); -} - -void CConvCreator::OnDeviceEvent(DWORD evt, LPVOID data) -{ - m_devlist.OnDeviceEvent(evt, data); -} - -void CConvCreator::OnPowerEvent(DWORD evt, LPVOID data) -{ - m_devlist.OnPowerEvent(evt, data); -} - -void CConvCreator::SetSlateMode(std::string mode) -{ - CCritSec crit(&m_crit); - if (m_device == NULL) - return; - - m_agent.EventLog(EVENT_XENUSER_MODE_SWITCH); - - if (mode == "laptop") - m_device->SetMode(CCONV_DEVICE_LAPTOP_MODE); - else if (mode == "slate") - m_device->SetMode(CCONV_DEVICE_SLATE_MODE); -} - -bool CConvCreator::DevicePresent() -{ - return m_device != NULL; -} - -/*virtual*/ CDevice* CConvCreator::Create(const wchar_t* path) -{ - return new CConvDevice(path); -} - -/*virtual*/ void CConvCreator::OnDeviceAdded(CDevice* dev) -{ - CXenAgent::Log("OnDeviceAdded(%ws)\n", dev->Path()); - - CCritSec crit(&m_crit); - if (m_device == NULL) - m_device = (CConvDevice*)dev; -} - -/*virtual*/ void CConvCreator::OnDeviceRemoved(CDevice* dev) -{ - CXenAgent::Log("OnDeviceRemoved(%ws)\n", dev->Path()); - - CCritSec crit(&m_crit); - if (m_device == dev) - m_device = NULL; -} - -/*virtual*/ void CConvCreator::OnDeviceSuspend(CDevice* dev) -{ - CXenAgent::Log("OnDeviceSuspend(%ws)\n", dev->Path()); -} - -/*virtual*/ void CConvCreator::OnDeviceResume(CDevice* dev) -{ - CXenAgent::Log("OnDeviceResume(%ws)\n", dev->Path()); -} +#include "xeniface_ioctls.h" static CXenAgent s_service; @@ -609,8 +145,8 @@ static CXenAgent s_service; #pragma warning(push) #pragma warning(disable:4355) -CXenAgent::CXenAgent() noexcept : m_handle(NULL), m_evtlog(NULL), m_xeniface(*this), - m_conv(*this) +CXenAgent::CXenAgent() noexcept : m_handle(NULL), m_evtlog(NULL), + m_xeniface(this), m_conv(this) { m_status.dwServiceType = SERVICE_WIN32; m_status.dwCurrentState = SERVICE_START_PENDING; @@ -635,20 +171,22 @@ CXenAgent::~CXenAgent() void CXenAgent::OnServiceStart() { CXenAgent::Log("OnServiceStart()\n"); - m_conv.Start(m_handle); - m_xeniface.Start(m_handle); + m_xeniface.RegisterForDeviceChange(m_handle); + m_xeniface.EnumerateDevices(); + m_conv.EnumerateDevices(); } void CXenAgent::OnServiceStop() { CXenAgent::Log("OnServiceStop()\n"); - m_xeniface.Stop(); - m_conv.Stop(); + m_xeniface.LogIfRebootPending(); + m_xeniface.UnregisterForDeviceChange(); + m_xeniface.CleanupDeviceList(); + m_conv.CleanupDeviceList(); } void CXenAgent::OnDeviceEvent(DWORD evt, LPVOID data) { - m_conv.OnDeviceEvent(evt, data); m_xeniface.OnDeviceEvent(evt, data); } @@ -686,7 +224,7 @@ bool CXenAgent::ServiceMainLoop() std::string mode; ResetEvent(m_xeniface.m_evt_slate_mode); - if (m_xeniface.CheckSlateMode(&mode)) + if (m_xeniface.CheckSlateMode(mode)) m_conv.SetSlateMode(mode); return true; // continue loop @@ -722,7 +260,7 @@ void CXenAgent::EventLog(DWORD evt) bool CXenAgent::ConvDevicePresent() { - return m_conv.DevicePresent(); + return m_conv.GetFirstDevice() != NULL; } void CXenAgent::SetServiceStatus(DWORD state, DWORD exit /*= 0*/, DWORD hint /*= 0*/) diff --git a/src/xenagent/service.h b/src/xenagent/service.h index e886de6..32a6b8d 100644 --- a/src/xenagent/service.h +++ b/src/xenagent/service.h @@ -45,88 +45,6 @@ #include "xenifacedevice.h" #include "convdevice.h" -class CXenAgent; - -class CXenIfaceCreator : public IDeviceCreator -{ -public: - CXenIfaceCreator(CXenAgent&); - virtual ~CXenIfaceCreator(); - CXenIfaceCreator& operator=(const CXenIfaceCreator&); - - bool Start(HANDLE svc); - void Stop(); - void OnDeviceEvent(DWORD evt, LPVOID data); - void OnPowerEvent(DWORD evt, LPVOID data); - void Log(const char *message); - -public: // IDeviceCreator - virtual CDevice* Create(const wchar_t* path); - virtual void OnDeviceAdded(CDevice* dev); - virtual void OnDeviceRemoved(CDevice* dev); - virtual void OnDeviceSuspend(CDevice* dev); - virtual void OnDeviceResume(CDevice* dev); - -public: - bool CheckShutdown(); - void CheckXenTime(); - void CheckSuspend(); - bool CheckSlateMode(std::string *mode); - -public: - HANDLE m_evt_shutdown; - HANDLE m_evt_suspend; - HANDLE m_evt_slate_mode; - -private: - void LogIfRebootPending(); - void StartShutdownWatch(); - void StopShutdownWatch(); - void StartSlateModeWatch(); - void StopSlateModeWatch(); - void AcquireShutdownPrivilege(); - bool IsRTCInUTC(); - void SetXenTime(); - -private: - CXenAgent& m_agent; - CDeviceList m_devlist; - CXenIfaceDevice* m_device; - CRITICAL_SECTION m_crit; - void* m_ctxt_shutdown; - void* m_ctxt_suspend; - void* m_ctxt_slate_mode; - DWORD m_count; -}; - -class CConvCreator : public IDeviceCreator -{ -public: - CConvCreator(CXenAgent&); - virtual ~CConvCreator(); - CConvCreator& operator=(const CConvCreator&); - - bool Start(HANDLE svc); - void Stop(); - void OnDeviceEvent(DWORD evt, LPVOID data); - void OnPowerEvent(DWORD evt, LPVOID data); - void SetSlateMode(std::string mode); - bool DevicePresent(); - -public: - virtual CDevice* Create(const wchar_t* path); - virtual void OnDeviceAdded(CDevice* dev); - virtual void OnDeviceRemoved(CDevice* dev); - virtual void OnDeviceSuspend(CDevice* dev); - virtual void OnDeviceResume(CDevice* dev); - -private: - CXenAgent& m_agent; - CDeviceList m_devlist; - CConvDevice* m_device; - CRITICAL_SECTION m_crit; -}; - class CXenAgent { public: // statics @@ -165,8 +83,8 @@ private: // service support SERVICE_STATUS_HANDLE m_handle; HANDLE m_evtlog; HANDLE m_svc_stop; - CXenIfaceCreator m_xeniface; - CConvCreator m_conv; + CXenIfaceDeviceList m_xeniface; + CConvDeviceList m_conv; }; #endif diff --git a/src/xenagent/xenifacedevice.cpp b/src/xenagent/xenifacedevice.cpp index 6ebf163..eea63e4 100644 --- a/src/xenagent/xenifacedevice.cpp +++ b/src/xenagent/xenifacedevice.cpp @@ -29,12 +29,16 @@ * SUCH DAMAGE. */ +#define INITGUID #include #include +#include +#include "service.h" #include "xenifacedevice.h" #include "devicelist.h" #include "xeniface_ioctls.h" +#include "messages.h" CXenIfaceDevice::CXenIfaceDevice(const wchar_t* path) : CDevice(path) {} @@ -169,3 +173,347 @@ bool CXenIfaceDevice::Log(const std::string& msg) (void*)msg.c_str(), (DWORD)msg.length() + 1, NULL, 0); } + +CXenIfaceDeviceList::CXenIfaceDeviceList(CXenAgent* agent) : CDeviceList(GUID_INTERFACE_XENIFACE), + m_agent(agent), + m_ctxt_suspend(NULL), + m_ctxt_shutdown(NULL), + m_ctxt_slate_mode(NULL) +{ + m_evt_shutdown = CreateEvent(NULL, TRUE, FALSE, NULL); + m_evt_suspend = CreateEvent(NULL, TRUE, FALSE, NULL); + m_evt_slate_mode = CreateEvent(NULL, TRUE, FALSE, NULL); + m_count = 0; +} + +/*virtual*/ CXenIfaceDeviceList::~CXenIfaceDeviceList() +{ + CloseHandle(m_evt_slate_mode); + CloseHandle(m_evt_suspend); + CloseHandle(m_evt_shutdown); +} + +/*virtual*/ CDevice* CXenIfaceDeviceList::Create(const wchar_t* path) +{ + return new CXenIfaceDevice(path); +} + +/*virtual*/ void CXenIfaceDeviceList::OnDeviceAdded(CDevice* dev) +{ + CCritSec crit(&m_crit); + + if (GetFirstDevice() != NULL) + return; + + CXenIfaceDevice* device = (CXenIfaceDevice*)dev; + + device->SuspendRegister(m_evt_suspend, &m_ctxt_suspend); + StartShutdownWatch(device); + + if (m_agent->ConvDevicePresent()) + StartSlateModeWatch(device); + + SetXenTime(device); +} + +/*virtual*/ void CXenIfaceDeviceList::OnDeviceRemoved(CDevice* dev) +{ + CCritSec crit(&m_crit); + CXenIfaceDevice* device = (CXenIfaceDevice*)dev; + + if (dev != GetFirstDevice()) + return; + + if (m_ctxt_suspend) + device->SuspendDeregister(m_ctxt_suspend); + m_ctxt_suspend = NULL; + + if (m_agent->ConvDevicePresent()) + StopSlateModeWatch(device); + + StopShutdownWatch(device); +} + +/*virtual*/ void CXenIfaceDeviceList::OnDeviceSuspend(CDevice* dev) +{ + CCritSec crit(&m_crit); + CXenIfaceDevice* device = (CXenIfaceDevice*)dev; + + if (dev != GetFirstDevice()) + return; + + if (m_agent->ConvDevicePresent()) + StopSlateModeWatch(device); + + StopShutdownWatch(device); +} + +/*virtual*/ void CXenIfaceDeviceList::OnDeviceResume(CDevice* dev) +{ + CCritSec crit(&m_crit); + CXenIfaceDevice* device = (CXenIfaceDevice*)dev; + + if (dev != GetFirstDevice()) + return; + + StartShutdownWatch(device); + + if (m_agent->ConvDevicePresent()) + StartSlateModeWatch(device); +} + +void CXenIfaceDeviceList::Log(const char* message) +{ + // if possible, send to xeniface to forward to logs + if (TryEnterCriticalSection(&m_crit)) { + CXenIfaceDevice* device = (CXenIfaceDevice*)GetFirstDevice(); + if (device != NULL) + device->Log(message); + LeaveCriticalSection(&m_crit); + } +} + +bool CXenIfaceDeviceList::CheckShutdown() +{ + CCritSec crit(&m_crit); + CXenIfaceDevice* device = (CXenIfaceDevice*)GetFirstDevice(); + + if (device == NULL) + return false; + + std::string type; + if (!device->StoreRead("control/shutdown", type)) + return false; + + if (type != "") + CXenAgent::Log("Shutdown(%ws) = '%s'\n", device->Path(), type.c_str()); + + if (type == "poweroff") { + device->StoreWrite("control/shutdown", ""); + m_agent->EventLog(EVENT_XENUSER_POWEROFF); + + AcquireShutdownPrivilege(); +#pragma warning(suppress:28159) /* Consider using a design alternative... Rearchitect to avoid Reboot */ + if (!InitiateSystemShutdownEx(NULL, NULL, 0, TRUE, FALSE, + SHTDN_REASON_MAJOR_OTHER | + SHTDN_REASON_MINOR_ENVIRONMENT | + SHTDN_REASON_FLAG_PLANNED)) { + CXenAgent::Log("InitiateSystemShutdownEx failed %08x\n", GetLastError()); + } + return true; + } else if (type == "reboot") { + device->StoreWrite("control/shutdown", ""); + m_agent->EventLog(EVENT_XENUSER_REBOOT); + + AcquireShutdownPrivilege(); +#pragma warning(suppress:28159) /* Consider using a design alternative... Rearchitect to avoid Reboot */ + if (!InitiateSystemShutdownEx(NULL, NULL, 0, TRUE, TRUE, + SHTDN_REASON_MAJOR_OTHER | + SHTDN_REASON_MINOR_ENVIRONMENT | + SHTDN_REASON_FLAG_PLANNED)) { + CXenAgent::Log("InitiateSystemShutdownEx failed %08x\n", GetLastError()); + } + return true; + } else if (type == "s4") { + device->StoreWrite("control/shutdown", ""); + m_agent->EventLog(EVENT_XENUSER_S4); + + AcquireShutdownPrivilege(); + if (!SetSystemPowerState(FALSE, FALSE)) { + CXenAgent::Log("SetSystemPowerState failed %08x\n", GetLastError()); + } + return false; + } else if (type == "s3") { + device->StoreWrite("control/shutdown", ""); + m_agent->EventLog(EVENT_XENUSER_S3); + + AcquireShutdownPrivilege(); + if (!SetSuspendState(FALSE, TRUE, FALSE)) { + CXenAgent::Log("SetSuspendState failed %08x\n", GetLastError()); + } + return false; + } + + return false; +} + +void CXenIfaceDeviceList::CheckXenTime() +{ + CCritSec crit(&m_crit); + CXenIfaceDevice* device = (CXenIfaceDevice*)GetFirstDevice(); + + if (device == NULL) + return; + + SetXenTime(device); +} + +void CXenIfaceDeviceList::CheckSuspend() +{ + CCritSec crit(&m_crit); + CXenIfaceDevice* device = (CXenIfaceDevice*)GetFirstDevice(); + + if (device == NULL) + return; + + DWORD count = 0; + + if (!device->SuspendGetCount(&count)) + return; + + if (m_count == count) + return; + + CXenAgent::Log("Suspend(%ws)\n", device->Path()); + + m_agent->EventLog(EVENT_XENUSER_UNSUSPENDED); + + // recreate watches, as suspending deactivated the watch + if (m_agent->ConvDevicePresent()) + StopSlateModeWatch(device); + + StopShutdownWatch(device); + + StartShutdownWatch(device); + + if (m_agent->ConvDevicePresent()) + StartSlateModeWatch(device); + + m_count = count; +} + +bool CXenIfaceDeviceList::CheckSlateMode(std::string& mode) +{ + CCritSec crit(&m_crit); + CXenIfaceDevice* device = (CXenIfaceDevice*)GetFirstDevice(); + + if (device == NULL) + return false; + + if (!device->StoreRead("control/laptop-slate-mode", mode)) + return false; + + if (mode != "") + device->StoreWrite("control/laptop-slate-mode", ""); + + return true; +} + +void CXenIfaceDeviceList::LogIfRebootPending() +{ + HKEY Key; + LONG lResult; + + lResult = RegOpenKeyEx(HKEY_LOCAL_MACHINE, + "SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\WindowsUpdate\\Auto Update\\RebootRequired", + 0, + KEY_READ, + &Key); + if (lResult != ERROR_SUCCESS) + return; // key doesnt exist, dont log anything + + RegCloseKey(Key); + + CXenAgent::Log("RebootRequired detected\n"); +} + +void CXenIfaceDeviceList::StartShutdownWatch(CXenIfaceDevice* device) +{ + if (m_ctxt_shutdown) + return; + + device->StoreAddWatch("control/shutdown", m_evt_shutdown, &m_ctxt_shutdown); + + device->StoreWrite("control/feature-poweroff", "1"); + device->StoreWrite("control/feature-reboot", "1"); + device->StoreWrite("control/feature-s3", "1"); + device->StoreWrite("control/feature-s4", "1"); +} + +void CXenIfaceDeviceList::StopShutdownWatch(CXenIfaceDevice* device) +{ + if (!m_ctxt_shutdown) + return; + + device->StoreWrite("control/feature-poweroff", ""); + device->StoreWrite("control/feature-reboot", ""); + device->StoreWrite("control/feature-s3", ""); + device->StoreWrite("control/feature-s4", ""); + + device->StoreRemoveWatch(m_ctxt_shutdown); + m_ctxt_shutdown = NULL; +} + +void CXenIfaceDeviceList::StartSlateModeWatch(CXenIfaceDevice* device) +{ + if (m_ctxt_slate_mode) + return; + + device->StoreAddWatch("control/laptop-slate-mode", m_evt_slate_mode, &m_ctxt_slate_mode); + device->StoreWrite("control/feature-laptop-slate-mode", "1"); +} + +void CXenIfaceDeviceList::StopSlateModeWatch(CXenIfaceDevice* device) +{ + if (!m_ctxt_slate_mode) + return; + + device->StoreRemove("control/feature-laptop-slate-mode"); + + device->StoreRemoveWatch(m_ctxt_slate_mode); + m_ctxt_slate_mode = NULL; +} + +void CXenIfaceDeviceList::AcquireShutdownPrivilege() +{ + HANDLE token; + TOKEN_PRIVILEGES tp; + + LookupPrivilegeValue(NULL, SE_SHUTDOWN_NAME, &tp.Privileges[0].Luid); + tp.Privileges[0].Attributes = SE_PRIVILEGE_ENABLED; + + tp.PrivilegeCount = 1; + + if (!OpenProcessToken(GetCurrentProcess(), + TOKEN_ADJUST_PRIVILEGES | TOKEN_QUERY, + &token)) + return; + + AdjustTokenPrivileges(token, FALSE, &tp, NULL, 0, NULL); + CloseHandle(token); +} + +void CXenIfaceDeviceList::SetXenTime(CXenIfaceDevice* device) +{ + bool local; + + FILETIME now = { 0 }; + if (!device->SharedInfoGetTime(&now, &local)) + return; + + SYSTEMTIME cur = { 0 }; + if (local) + GetLocalTime(&cur); + else + GetSystemTime(&cur); + + SYSTEMTIME sys = { 0 }; + if (!FileTimeToSystemTime(&now, &sys)) + return; + + if (memcmp(&cur, &sys, sizeof(SYSTEMTIME)) == 0) + return; + + CXenAgent::Log("RTC is in %s\n", local ? "local time" : "UTC"); + CXenAgent::Log("Time Now = %d/%d/%d %d:%02d:%02d.%d\n", + cur.wYear, cur.wMonth, cur.wDay, + cur.wHour, cur.wMinute, cur.wSecond, cur.wMilliseconds); + CXenAgent::Log("New Time = %d/%d/%d %d:%02d:%02d.%d\n", + sys.wYear, sys.wMonth, sys.wDay, + sys.wHour, sys.wMinute, sys.wSecond, sys.wMilliseconds); + + if (local) + SetLocalTime(&sys); + else + SetSystemTime(&sys); +} diff --git a/src/xenagent/xenifacedevice.h b/src/xenagent/xenifacedevice.h index b89b8b1..dcac685 100644 --- a/src/xenagent/xenifacedevice.h +++ b/src/xenagent/xenifacedevice.h @@ -61,4 +61,47 @@ public: // logging bool Log(const std::string& msg); }; +class CXenAgent; + +class CXenIfaceDeviceList : public CDeviceList +{ +public: + CXenIfaceDeviceList(CXenAgent* agent); + virtual ~CXenIfaceDeviceList(); + +protected: // CDeviceList + virtual CDevice* Create(const wchar_t* path); + virtual void OnDeviceAdded(CDevice* dev); + virtual void OnDeviceRemoved(CDevice* dev); + virtual void OnDeviceSuspend(CDevice* dev); + virtual void OnDeviceResume(CDevice* dev); + +public: + HANDLE m_evt_shutdown; + HANDLE m_evt_suspend; + HANDLE m_evt_slate_mode; + + void Log(const char* message); + bool CheckShutdown(); + void CheckXenTime(); + void CheckSuspend(); + bool CheckSlateMode(std::string& mode); + +private: + void LogIfRebootPending(); + void StartShutdownWatch(CXenIfaceDevice* device); + void StopShutdownWatch(CXenIfaceDevice* device); + void StartSlateModeWatch(CXenIfaceDevice* device); + void StopSlateModeWatch(CXenIfaceDevice* device); + void AcquireShutdownPrivilege(); + void SetXenTime(CXenIfaceDevice* device); + +private: + CXenAgent* m_agent; + DWORD m_count; + void* m_ctxt_suspend; + void* m_ctxt_shutdown; + void* m_ctxt_slate_mode; +}; + #endif -- 2.31.1.windows.1 From win-pv-devel-bounces@lists.xenproject.org Mon Jul 05 13:00:04 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 05 Jul 2021 13:00:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.150197.277747 (Exim 4.92) (envelope-from ) id 1m0OCg-0006iE-8l; Mon, 05 Jul 2021 13:00:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 150197.277747; Mon, 05 Jul 2021 13:00:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0OCg-0006hu-5W; Mon, 05 Jul 2021 13:00:02 +0000 Received: by outflank-mailman (input) for mailman id 150197; Mon, 05 Jul 2021 13:00:01 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0OCe-0006ar-Q9 for win-pv-devel@lists.xenproject.org; Mon, 05 Jul 2021 13:00:01 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 42716723-27e3-4f47-b2e7-9773ac8c51da; Mon, 05 Jul 2021 12:59:59 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 42716723-27e3-4f47-b2e7-9773ac8c51da DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625489999; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=aaTtH5ih+5u+jBluWS23NzSyz9Rztz/Kr4L5AManX1M=; b=FQva61Zz5pqjX2iSC8tLq3FHZXvlNdH+7TuLtRJkUdlWXS710ANVguQl gYBEZ9CkhKm0dqNy18g2vcwJBtJm84Hu2fkbOlzkUAijGfHEHc24HJCmp TZz1obLulFlmZP0q/DxwmczPdtdGXmTXTRhlvoOB9bEz1oA5gRHbSh9/o M=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: G3OH1l16Lkrp9NMT6HEGD0jM3VHK7OdOaRyfbFoukWR7uqU+ct7WvUta0uijG3fhwq9IF8HDLx VPeHmfE/6H9rL1U7aJsvtVlNV05QLhlhM0CEUZxeGJ27uzsyo09+gMKaDDgmwkqKvHCgPk+DZp FgQU7RzbB5+RCtV3ATK3l/soXlhz3QLVIKyDpm7mW5QYPw2/EGtAL8rSUIanHXvVJwZlkrvmuH BAb/p4scYe+JQLD0dzQ1t8JjThQvhDBKBZMle9UmgoUckDecvZKja65bkPPFd4/aqfDKYCkOGB t9Q= X-SBRS: 5.1 X-MesageID: 47286176 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:6hzZ6azqSYO8oMmeEs9rKrPwFL1zdoMgy1knxilNoRw8SKKlfq eV7ZImPH7P+U4ssR4b+exoVJPtfZqYz+8R3WBzB8bEYOCFghrKEGgK1+KLqFeMJ8S9zJ846U 4JSdkGNDSaNzlHZKjBjzVQa+xQouW6zA== X-IronPort-AV: E=Sophos;i="5.83,325,1616472000"; d="scan'208";a="47286176" From: Owen Smith To: CC: Owen Smith Subject: [PATCH 2/2] Log if Windows Update requires a reboot Date: Mon, 5 Jul 2021 13:59:51 +0100 Message-ID: <20210705125951.2031-2-owen.smith@citrix.com> X-Mailer: git-send-email 2.31.1.windows.1 In-Reply-To: <20210705125951.2031-1-owen.smith@citrix.com> References: <20210705125951.2031-1-owen.smith@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Output log line if Windows Update requires a reboot, as soon as a shutdown or reboot has been requested, in addition to when the service shuts down. The service shutdown will output its log line *after* the "Installing Windows Updates" screen has completed during shutdown. Signed-off-by: Owen Smith --- src/xenagent/xenifacedevice.cpp | 2 ++ src/xenagent/xenifacedevice.h | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/xenagent/xenifacedevice.cpp b/src/xenagent/xenifacedevice.cpp index eea63e4..46b4b6f 100644 --- a/src/xenagent/xenifacedevice.cpp +++ b/src/xenagent/xenifacedevice.cpp @@ -291,6 +291,7 @@ bool CXenIfaceDeviceList::CheckShutdown() if (type == "poweroff") { device->StoreWrite("control/shutdown", ""); m_agent->EventLog(EVENT_XENUSER_POWEROFF); + LogIfRebootPending(); AcquireShutdownPrivilege(); #pragma warning(suppress:28159) /* Consider using a design alternative... Rearchitect to avoid Reboot */ @@ -304,6 +305,7 @@ bool CXenIfaceDeviceList::CheckShutdown() } else if (type == "reboot") { device->StoreWrite("control/shutdown", ""); m_agent->EventLog(EVENT_XENUSER_REBOOT); + LogIfRebootPending(); AcquireShutdownPrivilege(); #pragma warning(suppress:28159) /* Consider using a design alternative... Rearchitect to avoid Reboot */ diff --git a/src/xenagent/xenifacedevice.h b/src/xenagent/xenifacedevice.h index dcac685..3b5e473 100644 --- a/src/xenagent/xenifacedevice.h +++ b/src/xenagent/xenifacedevice.h @@ -86,9 +86,9 @@ public: void CheckXenTime(); void CheckSuspend(); bool CheckSlateMode(std::string& mode); + void LogIfRebootPending(); private: - void LogIfRebootPending(); void StartShutdownWatch(CXenIfaceDevice* device); void StopShutdownWatch(CXenIfaceDevice* device); void StartSlateModeWatch(CXenIfaceDevice* device); -- 2.31.1.windows.1 From win-pv-devel-bounces@lists.xenproject.org Wed Jul 07 08:55:20 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 07 Jul 2021 08:55:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.152035.280917 (Exim 4.92) (envelope-from ) id 1m13Kw-0004lh-1Y; Wed, 07 Jul 2021 08:55:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 152035.280917; Wed, 07 Jul 2021 08:55:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m13Kv-0004la-Ux; Wed, 07 Jul 2021 08:55:17 +0000 Received: by outflank-mailman (input) for mailman id 152035; Wed, 07 Jul 2021 08:55:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m13Ku-0004lO-3t for win-pv-devel@lists.xenproject.org; Wed, 07 Jul 2021 08:55:16 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e99f06c2-139a-454a-80f8-e28bf6134efe; Wed, 07 Jul 2021 08:55:15 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: e99f06c2-139a-454a-80f8-e28bf6134efe DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625648115; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=oR7NPGH7vTM2271Mz7MVl1JlV6HdMxcN52RCt5R4j0U=; b=OWJXPtbeBxkquswlTX6JogpZhmjGO0QeZtKwNpy/r9Iz9U6FXUG/j/VV hu4LA9AjLNHrIzqfds2hTQKtPnCHde8hDT/sfdKxtkaiHPwi+Ba6IyCdm NdHltqMKVrqxwX1kaGRiMpA79yTRmSPDvcVTJqca+JkO1HHLZW9UgpyDT E=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: FvFKi+3BaPoHlsFOPXBrcppYop4Xn6O8yXrT96dyf0ZosaGoAzrjEzj5+EaAlBX9+hiX2/P1Jk oq5x3q/qiXsYwrCDMQCZHncvl9lMNhTty25pQi2XIq5jQz/l7BNNHQfsWSp3iMja7rAhoefxO1 +ZV1RP0lOs4cQ6XFl6hZnq861Y9ED3HUHSK3nHbS3q2C6jHOfxTncfhe1crmiVHwjnJxm9jEIP PhRxEqjGD8reJwuuKHNEU1LFIFDyC9BPn0TdhdnYXHBMexCjuus3cRaV9923oJ9cj5JiKWUtcZ vUA= X-SBRS: 5.1 X-MesageID: 47424834 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:EcSZDq34bbMrZYGNLHxewgqjBIokLtp133Aq2lEZdPRUGvb3qy nIpoV86faUskdoZJhOo7C90cW7LU80sKQFhLX5Xo3SOzUO2lHYT72KhLGKq1aLdhEWtNQtsZ uIG5IOceEYZmIasS+V2maF+q4bsbu6zJw= X-IronPort-AV: E=Sophos;i="5.83,331,1616472000"; d="scan'208";a="47424834" From: Martin Harvey To: CC: Owen Smith Subject: [PATCH] Disable CONS debug logging Date: Wed, 7 Jul 2021 09:54:54 +0100 Message-ID: <20210707085456.1826-3-Martin.Harvey@citrix.com> X-Mailer: git-send-email 2.25.0.windows.1 In-Reply-To: <20210707085456.1826-1-Martin.Harvey@citrix.com> References: <20210707085456.1826-1-Martin.Harvey@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain From: Owen Smith Signed-off-by: Owen Smith --- src/xenbus/driver.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/xenbus/driver.c b/src/xenbus/driver.c index 1b621fa..f353a61 100644 --- a/src/xenbus/driver.c +++ b/src/xenbus/driver.c @@ -58,10 +58,10 @@ typedef struct _XENBUS_DRIVER { static XENBUS_DRIVER Driver; #define XENBUS_DRIVER_TAG 'VIRD' -#define DEFAULT_CONSOLE_LOG_LEVEL (LOG_LEVEL_INFO | \ - LOG_LEVEL_WARNING | \ - LOG_LEVEL_ERROR | \ - LOG_LEVEL_CRITICAL) +#define DEFAULT_CONSOLE_LOG_LEVEL 0 // (LOG_LEVEL_INFO | \ + // LOG_LEVEL_WARNING | \ + // LOG_LEVEL_ERROR | \ + // LOG_LEVEL_CRITICAL) static FORCEINLINE PVOID __DriverAllocate( -- 2.16.2.windows.1 From win-pv-devel-bounces@lists.xenproject.org Wed Jul 07 08:55:20 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 07 Jul 2021 08:55:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.152036.280921 (Exim 4.92) (envelope-from ) id 1m13Kx-0004nI-33; Wed, 07 Jul 2021 08:55:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 152036.280921; Wed, 07 Jul 2021 08:55:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m13Kx-0004nA-09; Wed, 07 Jul 2021 08:55:19 +0000 Received: by outflank-mailman (input) for mailman id 152036; Wed, 07 Jul 2021 08:55:17 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m13Kv-0004lU-Es for win-pv-devel@lists.xenproject.org; Wed, 07 Jul 2021 08:55:17 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0c5c5ede-df01-11eb-84de-12813bfff9fa; Wed, 07 Jul 2021 08:55:16 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 0c5c5ede-df01-11eb-84de-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625648116; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Pnlgswt2vFyMNmW9mnrEe0mXIdf6cYYbdrAZBvTwx1M=; b=QOf10dSPxVM8iqUrQko/zwBglsAufT53p8+IiWp2g8RcGufn0wioQvG+ TXBHALP7E+65p8Erj+VxlL0gm8xYaN7LZq48lkrDZz7xw/qdVUcaHZDf0 /7lESGFEpuWWoma2TvRbjBgDCJi+wMKIhonbEcoGUR2V9XtLt9Q/7vhmI I=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: cQDHH54hIR+mONzay0zf2eLcHaEFs4DVZ670TIiyygitFn4sNyFr+lB9bldrgRHUmqxTUefGp7 1+VkBkR5y/3UzyV3dnV1l8GciVO4GbIRfe3ZVH+LqPaAGp9bC0pTrx7+tiXjeILFof0gDuOuuW e7iZNWtuX/RM4vxtRIvN4iA/a9Y3vpOYsRpNce1xxAZtD2l2R+cLDZO4e5YhAh2PF61/66ivuI 1qceNB7is7y0k/0uvh4T5HFi0ef5IvWgqb7mfzkjYKdD8d+eZeMgIDIjO/x3Bu9hEpBIkwchCb gww= X-SBRS: 5.1 X-MesageID: 47424837 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:zPFGI6oT1HmJ8rOkoe4GVMoaV5oReYIsimQD101hICG8cqSj9v xG+85rrCMc6QxhI03I9urwW5VoLUmyyXcx2/h0AV7AZniBhILLFvAB0WKK+VSJcEeSmtK1l5 0QFJSWYOeAdWSS5vyb3ODXKbgdKaG8gcWVuds= X-IronPort-AV: E=Sophos;i="5.83,331,1616472000"; d="scan'208";a="47424837" From: Martin Harvey To: CC: Owen Smith Subject: [PATCH] Add log to Xenfilt DriverAddDevice Date: Wed, 7 Jul 2021 09:54:53 +0100 Message-ID: <20210707085456.1826-2-Martin.Harvey@citrix.com> X-Mailer: git-send-email 2.25.0.windows.1 In-Reply-To: <20210707085456.1826-1-Martin.Harvey@citrix.com> References: <20210707085456.1826-1-Martin.Harvey@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain From: Owen Smith Log all calls to DriverAddDevice, and the type of the device if possible Signed-off-by: Owen Smith --- src/xenfilt/driver.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/src/xenfilt/driver.c b/src/xenfilt/driver.c index 8f14ec8..2c9b54e 100644 --- a/src/xenfilt/driver.c +++ b/src/xenfilt/driver.c @@ -724,6 +724,19 @@ fail1: return status; } +static FORCEINLINE PCHAR +__EmulatedTypeName( + IN XENFILT_EMULATED_OBJECT_TYPE Type + ) +{ + switch (Type) { + case XENFILT_EMULATED_OBJECT_TYPE_UNKNOWN: return "UNKNOWN"; + case XENFILT_EMULATED_OBJECT_TYPE_PCI: return "PCI"; + case XENFILT_EMULATED_OBJECT_TYPE_IDE: return "IDE"; + default: return "InvalidType"; + } +} + static XENFILT_EMULATED_OBJECT_TYPE DriverGetEmulatedType( IN PCHAR Id @@ -805,6 +818,10 @@ DriverAddDevice( } } + Info("%p %s\n", + PhysicalDeviceObject, + __EmulatedTypeName(Type)); + status = STATUS_SUCCESS; if (Type == XENFILT_EMULATED_OBJECT_TYPE_UNKNOWN) goto done; -- 2.28.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Wed Jul 07 08:55:23 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 07 Jul 2021 08:55:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.152037.280926 (Exim 4.92) (envelope-from ) id 1m13L1-0004q2-52; Wed, 07 Jul 2021 08:55:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 152037.280926; Wed, 07 Jul 2021 08:55:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m13L1-0004pv-1q; Wed, 07 Jul 2021 08:55:23 +0000 Received: by outflank-mailman (input) for mailman id 152037; Wed, 07 Jul 2021 08:55:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m13Ky-0004lO-Uo for win-pv-devel@lists.xenproject.org; Wed, 07 Jul 2021 08:55:20 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7da07d0b-62f6-4fd5-847f-51797d4e17c8; Wed, 07 Jul 2021 08:55:15 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 7da07d0b-62f6-4fd5-847f-51797d4e17c8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625648115; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=QCSmbZ7SFlEb/DVDNgIFKj5KRqGdflyRIo+/Kiy8n2k=; b=cmzYQa9NK1leEIUfvC/x6R9uoWwvje4uYoPVuquJTgRb661FdoY4iNJk X9GQ2brY0EildLXTQdCVovtHI9xrwwObFgMLi6RWyrXSCMt1VxjKU7hco 1UiotdsdTRXHYb//OB8DIupYm8OWa88D75+0fx75LQZTM298Y2z1vAZCr o=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: ViTT0G9FKTwr2Cf9X4WUj4a53d5wNJBBqj9hets2/rrrGRkaY2iHycxg6Q4jTIswnqTHhqMW9T /H+dD6VW4k9lMrEjy/b5uo9LQQTPV2GbkVNoCdLghjo4u1cVCLXR+hSQ0owmOQ6RFSPxCW9FyF BtVfmijF5DOqxIvKWEPyYNmatytFEwbiMAxSwK07Y9w3Lp7+VTsnNCrU5dbYkG2/uqgZsqRjRi /gcDNFaDBckawJ47wKs4zZjfkoKoXaZv7q4VNU7lrA/S9LQ81Ha8XAQWvyO7VoZL36UPenBCmp 8hE= X-SBRS: 5.1 X-MesageID: 47721675 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:lc0AoKpQlpEB3p8EwfwRDr0aV5oReYIsimQD101hICG8cqSj9v xG+85rrCMc6QxhI03I9urwW5VoLUmyyXcx2/h0AV7AZniBhILLFvAB0WKK+VSJcEeSmtK1l5 0QFJSWYOeAdWSS5vyb3ODXKbgdKaG8gcWVuds= X-IronPort-AV: E=Sophos;i="5.83,331,1616472000"; d="scan'208";a="47721675" From: Martin Harvey To: CC: Owen Smith Subject: [PATCH] Reduce logging of Fdo->NotDisableable Date: Wed, 7 Jul 2021 09:54:56 +0100 Message-ID: <20210707085456.1826-5-Martin.Harvey@citrix.com> X-Mailer: git-send-email 2.25.0.windows.1 In-Reply-To: <20210707085456.1826-1-Martin.Harvey@citrix.com> References: <20210707085456.1826-1-Martin.Harvey@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain From: Owen Smith Signed-off-by: Owen Smith --- src/xenbus/fdo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/xenbus/fdo.c b/src/xenbus/fdo.c index 03a71c0..b8f9c1a 100644 --- a/src/xenbus/fdo.c +++ b/src/xenbus/fdo.c @@ -4530,7 +4530,7 @@ FdoQueryPnpDeviceState( goto done; if (Fdo->NotDisableable) { - Info("%s: not disableable\n", __FdoGetName(Fdo)); + Trace("%s: not disableable\n", __FdoGetName(Fdo)); State |= PNP_DEVICE_NOT_DISABLEABLE; } -- 2.30.2.windows.1 From win-pv-devel-bounces@lists.xenproject.org Wed Jul 07 08:55:28 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 07 Jul 2021 08:55:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.152038.280930 (Exim 4.92) (envelope-from ) id 1m13L6-0004tF-6o; Wed, 07 Jul 2021 08:55:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 152038.280930; Wed, 07 Jul 2021 08:55:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m13L6-0004t8-3Y; Wed, 07 Jul 2021 08:55:28 +0000 Received: by outflank-mailman (input) for mailman id 152038; Wed, 07 Jul 2021 08:55:26 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m13L3-0004lO-Us for win-pv-devel@lists.xenproject.org; Wed, 07 Jul 2021 08:55:25 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cbcf5b4f-6f87-400d-9cd5-e40863e2277d; Wed, 07 Jul 2021 08:55:16 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: cbcf5b4f-6f87-400d-9cd5-e40863e2277d DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625648116; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=viWYysuiENmD6k2qb2Tf00dXOVy7+AEMmyEJZo1w/pg=; b=RWn0kdWwpuA1jOZmOM50faVVdYEgFOAWp1OBjm2O7FFn08pwCtpfu5Oa 3g2ckDAVO4LiT+gA1QLfy6rI3lk2g1voBvR4oxY2YkN3wEp2DUpzQiq1l kqMEtUS+kOp/pneH66XGa+3aBSY6fqrK4s4m1q//f0mYDJDQPzUGSaxbP g=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: RTW3aDdEer3NL5zGT8D7XdOnMA5KVkIo6qKwVGx2CCSF7zIgNVbiD9yaDKR6sPr+ZbjH34Ds55 pefgQ3hPkZaTGm+oXdIGy8F4Q2OVN/mytuyUtNdxAqc9Am+mHHWTVTIcNXhwntaSVDSX24QHPu 6M2KKFHxFw/zH04EJOVcUBZiCWGFeB8UTZQOoUU4CT4NLHBi/PjwtCNo/JLOy74ii9CR81iiUi 6YpsRqKjydnxpEaaOP5wL1nlKxftT4XIBihtzdEBE6MXRJ6M9fIA7beljAL3SVUgV3qmv5IhIS 14o= X-SBRS: 5.1 X-MesageID: 47424835 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:WW9J8aFG4iRc1obwpLqE5seALOsnbusQ8zAXP0AYc31om6uj5q eTdZUgpGbJYVkqKRIdcLy7V5VoIkmskaKdg7NhX4tKNTOO0ADDQe1fBOPZslvd8kbFltK1u5 0PT0EHMqyUMWRH X-IronPort-AV: E=Sophos;i="5.83,331,1616472000"; d="scan'208";a="47424835" From: Martin Harvey To: CC: Paul Durrant Subject: [PATCH] Log module loading Date: Wed, 7 Jul 2021 09:54:52 +0100 Message-ID: <20210707085456.1826-1-Martin.Harvey@citrix.com> X-Mailer: git-send-email 2.25.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain From: Paul Durrant Signed-off-by: Paul Durrant --- src/xen/module.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/xen/module.c b/src/xen/module.c index 584a63d..9c4a5ea 100644 --- a/src/xen/module.c +++ b/src/xen/module.c @@ -145,6 +145,11 @@ ModuleAdd( BOOLEAN After; NTSTATUS status; + Info("%p - %p [%s]\n", + Start, + Start + Size - 1, + Name); + New = __ModuleAllocate(sizeof (MODULE)); status = STATUS_NO_MEMORY; -- 2.5.3 From win-pv-devel-bounces@lists.xenproject.org Wed Jul 07 08:55:32 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 07 Jul 2021 08:55:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.152041.280934 (Exim 4.92) (envelope-from ) id 1m13LA-0004xa-8Q; Wed, 07 Jul 2021 08:55:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 152041.280934; Wed, 07 Jul 2021 08:55:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m13LA-0004xT-5D; Wed, 07 Jul 2021 08:55:32 +0000 Received: by outflank-mailman (input) for mailman id 152041; Wed, 07 Jul 2021 08:55:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m13L8-0004lO-Uz for win-pv-devel@lists.xenproject.org; Wed, 07 Jul 2021 08:55:30 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7b3f36bc-9312-4309-b598-c1af4e935672; Wed, 07 Jul 2021 08:55:16 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 7b3f36bc-9312-4309-b598-c1af4e935672 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625648116; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=T4zVuDrW9JDULnUIHRwNDrLsB51igzS9ySTcbrCTmd0=; b=gbSul/FjtDVET9oLegNMcurTWu9UsqzjAtDcMgwsTWwxP25B9CoTAOKc yyL0t1uGAFRfsUmTYom6EQFjTxlgFKg4+lUDpL1yMFWqdp9AnGbRYWikP lVFqjZe7SUx/+qK2rAVsIxE+qiwTB1X9AK/u0YsJSJZvTA6MdsDSo4c2E 8=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: N0sW1GfFYZ5c+k9sqJZgosAR1pLNy8Kh09lVhNTZn4nQkW12okwS9PZ21uiA4tKzUPdU2OMqGG nDVpDoWjNbKS9jvw3Kf7bLcp4ccGd/EGfQGrMk3vz+j7mUldYC2LmxpGe298VhB0wZcus/75VH q6nrcA0tEoYjQnLcLdd9bvxdEh2RA5f8+rGrswwNNk0TkqJmALt1bn9/2VjTf4RnRM8TClZi30 fcwt7MX9hbPBXCRgm9lMsMBKHL9yKCJNiV6kbySqAxbdxjEbh0aCNpWmzIpTxpC0HDcNowCs4o FSo= X-SBRS: 5.1 X-MesageID: 47424838 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:yDtlZqFmQQg/E6LCpLqE0seALOsnbusQ8zAXP0AYc31om6uj5r mTdZUgpGTJYVkqKRIdcLy7V5VoBEmskaKdgrNhW4tKPjOW2ldARbsKheCJrlHd8m/Fh4lgPM 9bAtBD4bbLbWSS4/yV3ODBKadE/OW6 X-IronPort-AV: E=Sophos;i="5.83,331,1616472000"; d="scan'208";a="47424838" From: Martin Harvey To: CC: Owen Smith , "Ben . Chalmers" , Martin Harvey Subject: [PATCH] Change AllocatePage to use ExAllocatePoolWithTag Date: Wed, 7 Jul 2021 09:54:55 +0100 Message-ID: <20210707085456.1826-4-Martin.Harvey@citrix.com> X-Mailer: git-send-email 2.25.0.windows.1 In-Reply-To: <20210707085456.1826-1-Martin.Harvey@citrix.com> References: <20210707085456.1826-1-Martin.Harvey@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain From: Owen Smith Windows appears to have an edge case bug in which zeroing memory using MmAllocatePAgesForMdlEx (which in Win 10 1803 happens even if you specify MM_DONT_ZERO_ALLOCATION) can cause a BSOD 139 1e. __AllocatePages is left unchanged (as we don't want to allocate multiple contiguous pages). This issue has not been seen outside of xenvif calls to __AllocatePage and we expect a fix to the underlying Windows problem in the near future Signed-off-by: Ben.Chalmers Signed-Off-By: Martin Harvey Ported-off-by: Owen Smith --- src/common/util.h | 72 +++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 70 insertions(+), 2 deletions(-) diff --git a/src/common/util.h b/src/common/util.h index eddad4a..93875b3 100644 --- a/src/common/util.h +++ b/src/common/util.h @@ -39,6 +39,8 @@ #define P2ROUNDUP(_x, _a) \ (-(-(_x) & -(_a))) +#define XENBUS_SINGLEPAGE_TAG 'PSUB' + static FORCEINLINE LONG __ffs( IN unsigned long long mask @@ -236,7 +238,57 @@ fail1: return NULL; } -#define __AllocatePage() __AllocatePages(1) +static FORCEINLINE PMDL +__AllocatePage() +{ + PMDL Mdl; + PUCHAR MdlMappedSystemVa; + NTSTATUS status; + + ASSERT3U(KeGetCurrentIrql(), <=, DISPATCH_LEVEL); + + MdlMappedSystemVa = __AllocatePoolWithTag(NonPagedPool, + PAGE_SIZE, + XENBUS_SINGLEPAGE_TAG); + + status = STATUS_NO_MEMORY; + if (MdlMappedSystemVa == NULL) + goto fail1; + + status = STATUS_INTERNAL_ERROR; + if (((ULONG_PTR)MdlMappedSystemVa) & (PAGE_SIZE - 1)) + goto fail2; + + Mdl = IoAllocateMdl(MdlMappedSystemVa, + (ULONG)PAGE_SIZE, + FALSE, + FALSE, + NULL); + if (Mdl == NULL) + goto fail3; + + MmBuildMdlForNonPagedPool(Mdl); + + ASSERT3U(Mdl->ByteOffset, ==, 0); + ASSERT3P(Mdl->StartVa, ==, MdlMappedSystemVa); + ASSERT3P(Mdl->MappedSystemVa, ==, MdlMappedSystemVa); + + RtlZeroMemory(MdlMappedSystemVa, Mdl->ByteCount); + + return Mdl; + +fail3: + Error("fail3\n"); + +fail2: + Error("fail2\n"); + + __FreePoolWithTag(MdlMappedSystemVa, XENBUS_SINGLEPAGE_TAG); +fail1: + Error("fail1 (%08x)\n", status); + + return NULL; +} static FORCEINLINE VOID __FreePages( @@ -254,7 +306,23 @@ __FreePages( ExFreePool(Mdl); } -#define __FreePage(_Mdl) __FreePages(_Mdl) +static FORCEINLINE VOID +__FreePage( + IN PMDL Mdl + ) +{ + PUCHAR MdlMappedSystemVa; + + ASSERT(Mdl->MdlFlags & + (MDL_MAPPED_TO_SYSTEM_VA | + MDL_SOURCE_IS_NONPAGED_POOL)); + + MdlMappedSystemVa = Mdl->MappedSystemVa; + + IoFreeMdl(Mdl); + + __FreePoolWithTag(MdlMappedSystemVa, XENBUS_SINGLEPAGE_TAG); +} static FORCEINLINE PCHAR __strtok_r( -- 2.30.1.windows.1 From win-pv-devel-bounces@lists.xenproject.org Mon Jul 12 16:07:20 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 12 Jul 2021 16:07:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.154619.285679 (Exim 4.92) (envelope-from ) id 1m2ySk-0002YZ-Am; Mon, 12 Jul 2021 16:07:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 154619.285679; Mon, 12 Jul 2021 16:07:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m2ySk-0002YS-7z; Mon, 12 Jul 2021 16:07:18 +0000 Received: by outflank-mailman (input) for mailman id 154619; Mon, 12 Jul 2021 16:07:16 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m2ySi-0002YL-OR for win-pv-devel@lists.xenproject.org; Mon, 12 Jul 2021 16:07:16 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 39474ac0-e32b-11eb-86f0-12813bfff9fa; Mon, 12 Jul 2021 16:07:15 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 39474ac0-e32b-11eb-86f0-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626106035; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=43KBP4vgPtN25lm1185kA1h/nRaes+6EWsTD4Q8ftcM=; b=OPCFs7oWywz7+LGXTy4XLPGuRLJr2KTwbH4B415zeMgGtTU4Oz5vEx/h ppsfo70tYno0igzDhH23t4tPjGpi8WkXQi9hLjPwCOb+i3v9OzwqzOM4z tvNDHvbY5g7tDyQiM5/oZ9XOiiMXJsXFkZs4MEYQd2LI9bvTtCYnZ/B0D A=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: uvb5QPAk/v3bAmQFYipy8vqTrsKa9x4GbhlXwX203LLRdSaoKgRDt/FGmG3y7fM7+WKzQ6rK3i xMVl5ehEnenooldKT3N/PnXO8b9cssSFdb2tOTvi1vpKasV3UAfyn4qqvftavsKbN2B9jSBVcb 2xwGIjLDEOFKq7i1IZJPOG9QTgJAyFC7T1fUNPUkjf870PTMbS/XYrpjHHRE8s3ztLpV5xdRiL 9+QnqdxhFBDSuprxAlSE0GljE29lLU4W+4Ar60AMZejjnd/bkIoSdFiDXEvhPB41nCb5HhFPqa TnU= X-SBRS: 5.1 X-MesageID: 48078691 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:1wg8yqlTQKACWMCpWHLhqlP+q7bpDfIg3DAbv31ZSRFFG/Fxl6 iV8sjzsiWE7Ar5OUtQ/+xoV5PhfZqxz/JICOoqTNKftWvdyQiVxehZhOOIqVDd8kXFh4lgPM xbEpSWZueeMbEDt7eZ3DWF X-IronPort-AV: E=Sophos;i="5.84,234,1620705600"; d="scan'208";a="48078691" From: Owen Smith To: CC: Owen Smith Subject: [PATCH] Make sure Frontend->NumQueues is not zero Date: Mon, 12 Jul 2021 17:07:01 +0100 Message-ID: <20210712160701.839-1-owen.smith@citrix.com> X-Mailer: git-send-email 2.31.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain - Checks multi-queue-max-queues is non-zero - ASSERTs Frontend->NumQueues is non-zero in the accessor Signed-off-by: Owen Smith --- src/xenvif/frontend.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/xenvif/frontend.c b/src/xenvif/frontend.c index 30de494..f5cb382 100644 --- a/src/xenvif/frontend.c +++ b/src/xenvif/frontend.c @@ -1785,6 +1785,9 @@ FrontendSetNumQueues( XENBUS_STORE(Free, &Frontend->StoreInterface, Buffer); + + if (BackendMaxQueues == 0) + BackendMaxQueues = 1; } else { BackendMaxQueues = 1; } @@ -1800,6 +1803,7 @@ __FrontendGetNumQueues( IN PXENVIF_FRONTEND Frontend ) { + ASSERT(Frontend->NumQueues != 0); return Frontend->NumQueues; } @@ -1953,7 +1957,6 @@ FrontendSetHashAlgorithm( case XENVIF_PACKET_HASH_ALGORITHM_TOEPLITZ: // Don't allow toeplitz hashing to be configured for a single // queue, or if it has been explicitly disabled - ASSERT(__FrontendGetNumQueues(Frontend) != 0); status = (__FrontendGetNumQueues(Frontend) == 1 || Frontend->DisableToeplitz != 0) ? STATUS_NOT_SUPPORTED : @@ -2358,7 +2361,7 @@ fail4: MacDisconnect(__FrontendGetMac(Frontend)); Frontend->Split = FALSE; - Frontend->NumQueues = 0; + Frontend->NumQueues = 1; fail3: Error("fail3\n"); @@ -2395,7 +2398,7 @@ FrontendDisconnect( MacDisconnect(__FrontendGetMac(Frontend)); Frontend->Split = FALSE; - Frontend->NumQueues = 0; + Frontend->NumQueues = 1; XENBUS_DEBUG(Deregister, &Frontend->DebugInterface, @@ -3063,6 +3066,7 @@ FrontendTeardown( RtlZeroMemory(&Frontend->Lock, sizeof (KSPIN_LOCK)); Frontend->BackendDomain = 0; + Frontend->NumQueues = 0; __FrontendFree(Frontend->Prefix); Frontend->Prefix = NULL; -- 2.31.1.windows.1 From win-pv-devel-bounces@lists.xenproject.org Mon Jul 12 18:47:23 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 12 Jul 2021 18:47:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.154687.285793 (Exim 4.92) (envelope-from ) id 1m30xe-0005Br-QC; Mon, 12 Jul 2021 18:47:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 154687.285793; Mon, 12 Jul 2021 18:47:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m30xe-0005Bj-NA; Mon, 12 Jul 2021 18:47:22 +0000 Received: by outflank-mailman (input) for mailman id 154687; Mon, 12 Jul 2021 18:47:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m30xe-0005Ba-1p for win-pv-devel@lists.xenproject.org; Mon, 12 Jul 2021 18:47:22 +0000 Received: from mail-wr1-x436.google.com (unknown [2a00:1450:4864:20::436]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 56957682-f900-47da-b678-e846e247bf42; Mon, 12 Jul 2021 18:47:21 +0000 (UTC) Received: by mail-wr1-x436.google.com with SMTP id f9so21321954wrq.11 for ; Mon, 12 Jul 2021 11:47:21 -0700 (PDT) Received: from [192.168.1.186] (host86-143-223-59.range86-143.btcentralplus.com. [86.143.223.59]) by smtp.gmail.com with ESMTPSA id r4sm15548719wre.84.2021.07.12.11.47.20 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jul 2021 11:47:20 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 56957682-f900-47da-b678-e846e247bf42 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=18HqK5i+sKhwjEvB6rJ+EKSc3KgWHL21znbhI+QOL4k=; b=FeK9ILl1gzCDiObg57cCXzx+uqHDaLoOkyqpoV0n5PyZz9gJK9fNaiEdagW8N5omJs nQYIA3bP+Fhpbk9sxh5wkY2DNFufNIGX1fxUUWEwC0/vZ0HuGIPVbs63vKL2cSqN+dBd 50QjDC9cqjvDc8xsgKEoIcgFtLqBxJXG1OC0l9zPtyuFopCw8FHzO+IcAHUDLekeo8w+ 4iQydN0Hq+ehwe88URSNWbpRVqyVDBKl14hHBUfAnWx6KqxJpgzRhsRBkpNhaK6TsVvA t0Tg3cyqmF2xzDdzwF1qN+EaEnaoEM1JQaop9wpcPerymYfHp9/qFwYV82XROPSGCTx+ A/Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=18HqK5i+sKhwjEvB6rJ+EKSc3KgWHL21znbhI+QOL4k=; b=Rl2utzx1x5hG6HPEocZzUjxZ3gq0uOvl/jov2vkA0327Gdf/Y2STQrb4XclaTNKgtD R34SpfIQ1tr3P+ewSCz3FPoMnuDB8JzOsfurOUlXOn7McYlSeIsJM+Echb40fI38FulF 2CZUYjYAcP3DhLb+Ll56qwG61N3FxfzfMmFb0AkWz32V0ZydulnQviCboD9YYJPbi3Z9 JLFNofIFlzdZM6ackHU+67QfNTf85Bsm7RpjIoDwVL4RrMoSPBdBHBC4+qicRZsP+RTB 67VuVji+1WdIPO9mqCtDbDi8pV0LSGLX9sIxcPjO1gDBnvxykilOicXUpCAhHkUGF8dj qllA== X-Gm-Message-State: AOAM5316ViGtXYINnAqmL+HdK+C8mNWEbiQtXVZATGH6RWOPFPzX0gAe yR1xby01e17tzm+t0X4VSODBoaHTYdE= X-Google-Smtp-Source: ABdhPJyGAUQon3l4DlU6093DKEuQQuryZZd2ypiCp+gzlELSlF8C1cB+K4Subm1sQk+Bug7h4fjtJw== X-Received: by 2002:a5d:6dd1:: with SMTP id d17mr495366wrz.344.1626115640572; Mon, 12 Jul 2021 11:47:20 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 1/2] Refactor XenAgent To: win-pv-devel@lists.xenproject.org References: <20210705125951.2031-1-owen.smith@citrix.com> Message-ID: <15a17d29-02a2-6423-6e77-0f5c8167fe43@xen.org> Date: Mon, 12 Jul 2021 19:47:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210705125951.2031-1-owen.smith@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 05/07/2021 13:59, Owen Smith wrote: > - Merge IDeviceCreator interface into CDeviceList base class > - Add CXenIfaceDeviceList and CConvDeviceList, derived from CDeviceList > - Moves IFace functionality to CXenIfaceDeviceList > - Moves Conv device functionality to CConvDeviceList > - Seperate RegisterDeviceNotification from SetupApi enumeration, so that static > devices do not need to hold the handle open (i.e. Conv device) > - CConvDeviceList only opens the handle when neccessary, as the MS driver for > the ACPI device only allows 1 open handle at a time. > > Signed-off-by: Owen Smith Acked-by: Paul Durrant From win-pv-devel-bounces@lists.xenproject.org Mon Jul 12 19:00:11 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 12 Jul 2021 19:00:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.154701.285808 (Exim 4.92) (envelope-from ) id 1m31A2-0007Zn-2h; Mon, 12 Jul 2021 19:00:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 154701.285808; Mon, 12 Jul 2021 19:00:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m31A1-0007Zg-Vs; Mon, 12 Jul 2021 19:00:09 +0000 Received: by outflank-mailman (input) for mailman id 154701; Mon, 12 Jul 2021 19:00:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m31A0-0007Za-GD for win-pv-devel@lists.xenproject.org; Mon, 12 Jul 2021 19:00:08 +0000 Received: from mail-wm1-x333.google.com (unknown [2a00:1450:4864:20::333]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c9af7776-1e67-4894-8708-6cd6d58382ea; Mon, 12 Jul 2021 19:00:07 +0000 (UTC) Received: by mail-wm1-x333.google.com with SMTP id j25-20020a05600c1c19b02902269686f585so1870277wms.0 for ; Mon, 12 Jul 2021 12:00:07 -0700 (PDT) Received: from [192.168.1.186] (host86-143-223-59.range86-143.btcentralplus.com. [86.143.223.59]) by smtp.gmail.com with ESMTPSA id f12sm243625wmg.16.2021.07.12.12.00.06 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jul 2021 12:00:06 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: c9af7776-1e67-4894-8708-6cd6d58382ea DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=W1mrX4/9BpDPpVniE/XtULCfeLxdNA0mUplzId5IGgE=; b=AA7JJqQb2ieC+fb0bw93KDcXnFh6bo/YfXP1DxdeIly4/xoqf1dtKxLXsMoWLOXNYR Wyn/EBaDobx3dKsNiewk2i6OTe3Zn3eJ9a/raDPVAPQesYVFvPGfXIkQvAPyt88H6UYL kswu+huf/sdR8e7gXrYBbygdQCVbuNjZUu/5/9W6o9gosTwV9RVKZbyzcbY4/GCZnxcx mZ0fzr29RGTb6FOHTDM6chmy8LBarvq7sVtow4dzhzlKouKxpeJVJUWfXiaJpCgobYJY /F7RX4Ly8E0kODOwe8QxvTCxHUtPLg+BwLBFOIb3S1AApDj3RFh9sIXG10ODz4+pqTKV jm3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=W1mrX4/9BpDPpVniE/XtULCfeLxdNA0mUplzId5IGgE=; b=KHTd+JXRCc8ydnk7qLO+AUR9DviGvKIbfEmZDmhgom2OJ0GXsUQUG5xQz+7e9zehon MW7YcRcuA8DWJnbjao+jl5gxsQq1dgdjNuFOkIui1dZNOLzlFHBMRH01Y3n+8/JZU4x5 CcUGbB7RzbRM3p70m9aCKzeL/8gczHUlYirgeqn0l2Lp4QhPZ9FPfNaTJ9+WnUnUCszU F7ONIJ2Vx4+xeVHPLSJ8Ce96sq6F14/yZ1J/02sqfMeraiZaf3UuIzg942hbW/O3bWoV ACIwtUZtIrFapNqQ1URcs6eJ+uZULF8Ub/fUd6GQHrJobx/5JghTWYM3y7ok5A7GRfTv monA== X-Gm-Message-State: AOAM533AEvxdCGt0WfPtsFcglR5DjNqO/VW8bafkI4uHzw525npORa1/ WnplmMkq1jg4PXACEGonls+ixSjB7uk= X-Google-Smtp-Source: ABdhPJxqbHK2p6+2Si6dcQB2fg7ub6JkzL1+uM7ZStJlOmvVnrx+R5gQdwCiyU+TgOXi5QsfgnslYw== X-Received: by 2002:a05:600c:2319:: with SMTP id 25mr15923449wmo.91.1626116406929; Mon, 12 Jul 2021 12:00:06 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH] Log module loading To: win-pv-devel@lists.xenproject.org References: <20210707085456.1826-1-Martin.Harvey@citrix.com> Message-ID: Date: Mon, 12 Jul 2021 20:00:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210707085456.1826-1-Martin.Harvey@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/07/2021 09:54, Martin Harvey wrote: > From: Paul Durrant > > Signed-off-by: Paul Durrant > --- > src/xen/module.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/src/xen/module.c b/src/xen/module.c > index 584a63d..9c4a5ea 100644 > --- a/src/xen/module.c > +++ b/src/xen/module.c > @@ -145,6 +145,11 @@ ModuleAdd( > BOOLEAN After; > NTSTATUS status; > > + Info("%p - %p [%s]\n", Not necessarily sure we want to log at this level in the general case. I think it would be reasonable for this to be a debug log line. Paul > + Start, > + Start + Size - 1, > + Name); > + > New = __ModuleAllocate(sizeof (MODULE)); > > status = STATUS_NO_MEMORY; > From win-pv-devel-bounces@lists.xenproject.org Mon Jul 12 19:06:02 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 12 Jul 2021 19:06:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.154712.285823 (Exim 4.92) (envelope-from ) id 1m31Fh-0008Lt-Qh; Mon, 12 Jul 2021 19:06:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 154712.285823; Mon, 12 Jul 2021 19:06:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m31Fh-0008Lk-NU; Mon, 12 Jul 2021 19:06:01 +0000 Received: by outflank-mailman (input) for mailman id 154712; Mon, 12 Jul 2021 19:05:59 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m31Ff-0008Le-Gv for win-pv-devel@lists.xenproject.org; Mon, 12 Jul 2021 19:05:59 +0000 Received: from mail-wm1-x331.google.com (unknown [2a00:1450:4864:20::331]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 72291934-02c5-4e5b-969e-492457096868; Mon, 12 Jul 2021 19:05:58 +0000 (UTC) Received: by mail-wm1-x331.google.com with SMTP id l6so3804446wmq.0 for ; Mon, 12 Jul 2021 12:05:58 -0700 (PDT) Received: from [192.168.1.186] (host86-143-223-59.range86-143.btcentralplus.com. [86.143.223.59]) by smtp.gmail.com with ESMTPSA id o3sm15227936wrw.56.2021.07.12.12.05.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jul 2021 12:05:57 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 72291934-02c5-4e5b-969e-492457096868 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+GZxbMDHqEklw2K7ZyDQfPxnvEx+BonkCKGtf9sm/oE=; b=dj+99oG14f924IAjOuuH1WIdO116ksAgPBBJWDib11wmQ6gEvIz7Z6BG11EEvxaZ+u IMXrYBKzpKUqSB+PfPOHDKclvXl7QuUpebHxhi8sdFP7fSZggSrR6fvht71qrJmiR4Ra ZEy9J6M803QjKiliDxb1ZfyUaGBlkAnhW/C/lMVB8pWfH01yj58a8V6SWw5IHnXyEP7T 3uKsxcaDUUGcl1L/C/TJgLlF1MDWzNsGocNGrZ1nay7v6CvxOcfnOj4mzQkOHHgi3Ro5 AhgJrnNw1Y2D259YrBOu56fdbmhF2y5dxCU2tYtKSztLj1GAnl0cslHJFeXJu5++s6fL 422A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+GZxbMDHqEklw2K7ZyDQfPxnvEx+BonkCKGtf9sm/oE=; b=afJMOCp8OYgyGHxFamcsM3u+gJV57Dymvwu0sWcd0lsNx2eYq418IFNSH8pIQddT5p 1XQUcAmtGyvkfeGSzpYfTyNgV1z3cWrqsL/wSJSWLKQc5a4jDLv39PbwtMMbNZ5Bfp9c rfoVvlEvmpErTNGemuNOF4XRJzPjE87ayvH7fDU/o1l91q3H3clwvPlwyf3/YGvCyTkF 4BLoE4K/iv2BXcXCFeq5Gwi2CAbWLNKaAVF9RMUs98ccXCW+tONkKmIHtCv1/eU8wYXH gUmbxWyVqqwVm4/vyoIAEANlo1QjWkwjpjxVxXehJzF5mgX6DOOlhte2QuA67HED8rtv PKAw== X-Gm-Message-State: AOAM532SmiXafSsmNTK6M4whUAGPelql3giYAxa1meRdWzOYCoReopiJ q4pdC4U8EBH8ykidBco8cYSNqTkGUWk= X-Google-Smtp-Source: ABdhPJzt4hfB48UWqpTF/I0wxbWpuii9aF61hkZvje3zsyTDx/CMkYIT99ONjIoIoV62zfK2w/adbA== X-Received: by 2002:a05:600c:2ca4:: with SMTP id h4mr720954wmc.37.1626116757783; Mon, 12 Jul 2021 12:05:57 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH] Add log to Xenfilt DriverAddDevice To: win-pv-devel@lists.xenproject.org References: <20210707085456.1826-1-Martin.Harvey@citrix.com> <20210707085456.1826-2-Martin.Harvey@citrix.com> Message-ID: <60fcc419-10ee-e02a-b235-1d6c8c5d1d25@xen.org> Date: Mon, 12 Jul 2021 20:05:56 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210707085456.1826-2-Martin.Harvey@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/07/2021 09:54, Martin Harvey wrote: > From: Owen Smith > > Log all calls to DriverAddDevice, and the type of the device if possible Any particular reason existent logging is insufficient? I think we need more justification here. Paul > > Signed-off-by: Owen Smith > --- > src/xenfilt/driver.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/src/xenfilt/driver.c b/src/xenfilt/driver.c > index 8f14ec8..2c9b54e 100644 > --- a/src/xenfilt/driver.c > +++ b/src/xenfilt/driver.c > @@ -724,6 +724,19 @@ fail1: > return status; > } > > +static FORCEINLINE PCHAR > +__EmulatedTypeName( > + IN XENFILT_EMULATED_OBJECT_TYPE Type > + ) > +{ > + switch (Type) { > + case XENFILT_EMULATED_OBJECT_TYPE_UNKNOWN: return "UNKNOWN"; > + case XENFILT_EMULATED_OBJECT_TYPE_PCI: return "PCI"; > + case XENFILT_EMULATED_OBJECT_TYPE_IDE: return "IDE"; > + default: return "InvalidType"; > + } > +} > + > static XENFILT_EMULATED_OBJECT_TYPE > DriverGetEmulatedType( > IN PCHAR Id > @@ -805,6 +818,10 @@ DriverAddDevice( > } > } > > + Info("%p %s\n", > + PhysicalDeviceObject, > + __EmulatedTypeName(Type)); > + > status = STATUS_SUCCESS; > if (Type == XENFILT_EMULATED_OBJECT_TYPE_UNKNOWN) > goto done; > From win-pv-devel-bounces@lists.xenproject.org Mon Jul 12 19:08:38 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 12 Jul 2021 19:08:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.154720.285830 (Exim 4.92) (envelope-from ) id 1m31IE-0008Tu-3E; Mon, 12 Jul 2021 19:08:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 154720.285830; Mon, 12 Jul 2021 19:08:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m31IE-0008Tn-04; Mon, 12 Jul 2021 19:08:38 +0000 Received: by outflank-mailman (input) for mailman id 154720; Mon, 12 Jul 2021 19:08:37 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m31ID-0008Th-MV for win-pv-devel@lists.xenproject.org; Mon, 12 Jul 2021 19:08:37 +0000 Received: from mail-wr1-x433.google.com (unknown [2a00:1450:4864:20::433]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 04451d50-3521-4be8-9ec9-6004ca68af12; Mon, 12 Jul 2021 19:08:37 +0000 (UTC) Received: by mail-wr1-x433.google.com with SMTP id p8so27073029wrr.1 for ; Mon, 12 Jul 2021 12:08:36 -0700 (PDT) Received: from [192.168.1.186] (host86-143-223-59.range86-143.btcentralplus.com. [86.143.223.59]) by smtp.gmail.com with ESMTPSA id o17sm266167wmh.19.2021.07.12.12.08.35 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jul 2021 12:08:35 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 04451d50-3521-4be8-9ec9-6004ca68af12 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=T/EZxrTBhvxnc1Sem2rUU81C9f+1W4kzPUmTPlQpCQs=; b=kPCOg7lD8RM1cIZzGIyfGIdbe+/mu1ahfkPX/LGvtfzdYNo3poV2p5vkVx2n16BE/5 THva4zAMs+JNEKxbIU4ZNA8SrVdYZKBP5gavyXOCgySo6dytBrTGgYFnJNszJGYxRsYi OKfxyQIuPtXxq/PPQz02eRMW3+TyPcGb+Rwl8J/g7VDTqhHzVHS4BJUWKg/9yYVVjuo3 uX/wj8rb90IBFHhDEA4tuvop9wzCvZPBA0Znc6zNc/PfBX6VlCUIGVK7H4tPioCN7VaC 8+wDkG0b6sZr11Qpz7iRML690F2mjVngem7iTrDv6GuX3zTHY3aIyUwrZ2Yq5i83iFZD G/8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=T/EZxrTBhvxnc1Sem2rUU81C9f+1W4kzPUmTPlQpCQs=; b=gRN//VPLsSXQb5QyAUUrB2lCaBgd5qHIoTrllI6pZSk5z2aVL23cdI8g8q9Ov691l7 DlrDYglbFWS9NKqlMbKSv6Uq8FX1BHR31CHXAAks5/OCfFguV4SkRBGrHS6T1LHbP9vo TJ1s07nY7J7x6gOWrO/Hv5Y62fcAsYOpyPYR/e6oSTZIKLLit2OeMalyiwlnn9o6nhXW +jyLFtEwbwhAZFwzASCTl+e0W8TDro2ZrJDzGB3EPhpjCr8cNCSi/MI6WMFLRY4pSUQz zDoBOqDQIImL0dV9q0ugFMx7KeeuhB66RS1g1A74wvOXS53sRjarvEllNWORFTRfIX9v 3NsA== X-Gm-Message-State: AOAM531GGOoi8wT9hgfWUzxPjTppszIMfbG3hq/+LEK0zTiViQt3lCae GBNaUm9gVCQXkhq9TIKAJJ5cke/tsuE= X-Google-Smtp-Source: ABdhPJzliaG5kIYHhzD/IxIqggmLxSaY+EDWEbBFqcejo74+G0hQ1OBCseU5+Dr+0N59l+/EdbeZSA== X-Received: by 2002:adf:ce8d:: with SMTP id r13mr602024wrn.304.1626116916279; Mon, 12 Jul 2021 12:08:36 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH] Disable CONS debug logging To: win-pv-devel@lists.xenproject.org References: <20210707085456.1826-1-Martin.Harvey@citrix.com> <20210707085456.1826-3-Martin.Harvey@citrix.com> Message-ID: <7074bcda-ec68-01eb-a519-88c3447efa47@xen.org> Date: Mon, 12 Jul 2021 20:08:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210707085456.1826-3-Martin.Harvey@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/07/2021 09:54, Martin Harvey wrote: > From: Owen Smith > a) Why? > Signed-off-by: Owen Smith > --- > src/xenbus/driver.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/xenbus/driver.c b/src/xenbus/driver.c > index 1b621fa..f353a61 100644 > --- a/src/xenbus/driver.c > +++ b/src/xenbus/driver.c > @@ -58,10 +58,10 @@ typedef struct _XENBUS_DRIVER { > static XENBUS_DRIVER Driver; > > #define XENBUS_DRIVER_TAG 'VIRD' > -#define DEFAULT_CONSOLE_LOG_LEVEL (LOG_LEVEL_INFO | \ > - LOG_LEVEL_WARNING | \ > - LOG_LEVEL_ERROR | \ > - LOG_LEVEL_CRITICAL) > +#define DEFAULT_CONSOLE_LOG_LEVEL 0 // (LOG_LEVEL_INFO | \ > + // LOG_LEVEL_WARNING | \ > + // LOG_LEVEL_ERROR | \ > + // LOG_LEVEL_CRITICAL) b) Leaving code in comments like this is not something we want If there is a reasonable justification for why we want no logging through the console then ditch the comments. Paul > > static FORCEINLINE PVOID > __DriverAllocate( > From win-pv-devel-bounces@lists.xenproject.org Mon Jul 12 19:10:08 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 12 Jul 2021 19:10:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.154726.285833 (Exim 4.92) (envelope-from ) id 1m31Jg-0000rC-7p; Mon, 12 Jul 2021 19:10:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 154726.285833; Mon, 12 Jul 2021 19:10:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m31Jg-0000r5-52; Mon, 12 Jul 2021 19:10:08 +0000 Received: by outflank-mailman (input) for mailman id 154726; Mon, 12 Jul 2021 19:10:07 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m31Jf-0000qz-IL for win-pv-devel@lists.xenproject.org; Mon, 12 Jul 2021 19:10:07 +0000 Received: from mail-wr1-x433.google.com (unknown [2a00:1450:4864:20::433]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8c4442fd-d855-4c3a-b95f-3acf2348aff3; Mon, 12 Jul 2021 19:10:07 +0000 (UTC) Received: by mail-wr1-x433.google.com with SMTP id d12so26441600wre.13 for ; Mon, 12 Jul 2021 12:10:06 -0700 (PDT) Received: from [192.168.1.186] (host86-143-223-59.range86-143.btcentralplus.com. [86.143.223.59]) by smtp.gmail.com with ESMTPSA id e6sm6380358wrg.18.2021.07.12.12.10.05 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jul 2021 12:10:06 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 8c4442fd-d855-4c3a-b95f-3acf2348aff3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LUPw5W/GdNiRTN9KIQMxWLDwD4wCyWXV3TWFI2rSvuk=; b=blS7dH9zv//jXYQ+mzJYdAfmhVn7fLGQkCl3fVDNOi874TQRTfVCFY+GK8t80EmjFo 4GaAYjSNlUzVsOgBJOfS4TmQkUjqHCNYehHEg42Q6zRB86yVtQoMwdnpkzAs4+73tYaT NSg5PzC3icIpTBk1EJABsageLIIAsuROAn5nnyJBHtCkjZkbEZ0Chd2++y4gy2DZUrRx rsNMTcj4NqDdTYbSFws+Ajv5n9sVCPaKiiEpf2EDJoP3H1Z5tBjyfdcglEu7J58XoVKM HLkF3oScTt2pDzX1DdnYx6xpFRGO4CWxnpwGYpPDthrKOFxZSFcroujfEUhXQ2Qzro2R qk8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LUPw5W/GdNiRTN9KIQMxWLDwD4wCyWXV3TWFI2rSvuk=; b=YX7sfV3R/GgclzLevrHTTrHoI4g0BOtFEW9Y0l5kRekaqeI0dzF0ayeUA6nFKRxiPS XV0F45vqi9sUauettgpeQrIROP9nK0ASvofNf+yRzMrbVm3BKuJFM3dcrAMnypUW3yWN 0f9gz0kV9crNu0iTulWJO9pwIDByxhsM68q9XGXPpzQDDPopfXsHvGQ7xct+OMSUuUFo sTqD/P7T0UbnVIi6vAGriQj0wD9oQQW9cQwPpwbxnV/a+0Pz4UueBvGAlXh1vbfyLGJv GPJzlmwUGW1gqanxAskwSAVhzUl60dtmFRwgp1CTG5iqbYF+5gqDRAEj6euEFSdQ3+wJ PyJQ== X-Gm-Message-State: AOAM530Oi4xILtge7aP9LaozXb0EiYm10fR2khEPyUbt9uIAY6RygKpt p52suCan/BPq2i16+DhhbrpHIYbDErA= X-Google-Smtp-Source: ABdhPJydK6vwTJPrnvUlhypDrODT/Fpk5NIPsmIDu1CB4SzWnn+98ce6WFJ3OmGJLCHMNYTUxklxgw== X-Received: by 2002:a5d:55c8:: with SMTP id i8mr610943wrw.208.1626117006291; Mon, 12 Jul 2021 12:10:06 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH] Change AllocatePage to use ExAllocatePoolWithTag To: win-pv-devel@lists.xenproject.org References: <20210707085456.1826-1-Martin.Harvey@citrix.com> <20210707085456.1826-4-Martin.Harvey@citrix.com> Message-ID: <1d843f4b-5e9c-903e-e0d3-bbf92cf9b57e@xen.org> Date: Mon, 12 Jul 2021 20:10:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210707085456.1826-4-Martin.Harvey@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/07/2021 09:54, Martin Harvey wrote: > From: Owen Smith > > Windows appears to have an edge case bug in which zeroing > memory using MmAllocatePAgesForMdlEx (which in Win 10 1803 > happens even if you specify MM_DONT_ZERO_ALLOCATION) can cause > a BSOD 139 1e. It is my understanding that this bug was fixed. Is this not the case? Paul From win-pv-devel-bounces@lists.xenproject.org Mon Jul 12 19:11:36 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 12 Jul 2021 19:11:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.154732.285837 (Exim 4.92) (envelope-from ) id 1m31L5-0000vy-Cd; Mon, 12 Jul 2021 19:11:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 154732.285837; Mon, 12 Jul 2021 19:11:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m31L5-0000vr-9t; Mon, 12 Jul 2021 19:11:35 +0000 Received: by outflank-mailman (input) for mailman id 154732; Mon, 12 Jul 2021 19:11:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m31L4-0000vl-4K for win-pv-devel@lists.xenproject.org; Mon, 12 Jul 2021 19:11:34 +0000 Received: from mail-wr1-x42d.google.com (unknown [2a00:1450:4864:20::42d]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a90bc798-bc5a-4236-89e7-36be36a75404; Mon, 12 Jul 2021 19:11:33 +0000 (UTC) Received: by mail-wr1-x42d.google.com with SMTP id l7so26157188wrv.7 for ; Mon, 12 Jul 2021 12:11:33 -0700 (PDT) Received: from [192.168.1.186] (host86-143-223-59.range86-143.btcentralplus.com. [86.143.223.59]) by smtp.gmail.com with ESMTPSA id a10sm15291729wrm.12.2021.07.12.12.11.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jul 2021 12:11:32 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: a90bc798-bc5a-4236-89e7-36be36a75404 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wskMFyG74z5CqM7wZyWTBRjQMR6wK/H2NrD+BJvtsT8=; b=Mo4BPN/CDyPRPvAn0z3aZGOR5C60+2kmuXs2wQAQTCtQvzxt4fMPHme7d0cBmbEyBT Idrxd3qveEs4VnJXbqH+42mNCcm/cfXouRvwdiqI8MYTqYX7xcuiPImAkeV8CfDGZdmb tLavgd3nspm6FiLfZHaSGtA3TtVLjXy1Cqgy3aitIXbsLDXbHrH5230ATfOr888BKsew hrAZVrSmvLK1sYfV/YnSvmmOTKpn9BYzapGL2+gZKUs6xJEOb2fWYJMnf+E+xJW59Xc3 IA7+6gKJ4BGvk09G3/NBURc8BZnT9pbsxdI51ruerR7BALZLMs0DouJzUP2dU46+meGQ BS9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wskMFyG74z5CqM7wZyWTBRjQMR6wK/H2NrD+BJvtsT8=; b=oaYqIawaL+ERtcE+yACLY0TjH4dTWpXL0o2oYToGGRUXjpNe4D2Y/EQ5+XSSHrs4hY jQwdQJiC0STitepy8hHNIFVcwvxxBCGf19/W4oHRxNzboaMFxXB84FoCtIYtb0+A5mZ9 2v+uLvMbZLpERHtHHSHGzJExH912cr+1POBtm7dhAAHa62htO6tOyYZymUzmDIrxw0cI Mua61+nz4qUf4rm4g20Bcfch/VQPbUadehSzudbfDvmPgJClLL9Yj7McctYFXEVUEmVR GdfSYlXDBMKDI8kQF3Rgxa7zeDB2XcVXV7c0nil1OgYVfYkg27dNohxYRyxQLQPoAA1D Spjw== X-Gm-Message-State: AOAM53084W9Xq5R7p8o6zEKhUNTPzIs5ckxTX5bEKi/2wYYZcloz9YSb /zme2G3uGNDPvzU03VzSz2zMhhyYI5o= X-Google-Smtp-Source: ABdhPJzETgW60OybvjlFJRWh91qguxkVh+TrGoNqjQceW/ZEEkmjTcrxKq9L2h7cXw3B/3lJ2P6H9Q== X-Received: by 2002:adf:ffcf:: with SMTP id x15mr655410wrs.76.1626117092597; Mon, 12 Jul 2021 12:11:32 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH] Reduce logging of Fdo->NotDisableable To: win-pv-devel@lists.xenproject.org References: <20210707085456.1826-1-Martin.Harvey@citrix.com> <20210707085456.1826-5-Martin.Harvey@citrix.com> Message-ID: Date: Mon, 12 Jul 2021 20:11:31 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210707085456.1826-5-Martin.Harvey@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/07/2021 09:54, Martin Harvey wrote: > From: Owen Smith > > Signed-off-by: Owen Smith Yes, it is probably unnecessary to log this at INFO level. Acked-by: Paul Durrant > --- > src/xenbus/fdo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/xenbus/fdo.c b/src/xenbus/fdo.c > index 03a71c0..b8f9c1a 100644 > --- a/src/xenbus/fdo.c > +++ b/src/xenbus/fdo.c > @@ -4530,7 +4530,7 @@ FdoQueryPnpDeviceState( > goto done; > > if (Fdo->NotDisableable) { > - Info("%s: not disableable\n", __FdoGetName(Fdo)); > + Trace("%s: not disableable\n", __FdoGetName(Fdo)); > State |= PNP_DEVICE_NOT_DISABLEABLE; > } > > From win-pv-devel-bounces@lists.xenproject.org Mon Jul 12 19:29:46 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 12 Jul 2021 19:29:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.154741.285844 (Exim 4.92) (envelope-from ) id 1m31ce-00022f-PC; Mon, 12 Jul 2021 19:29:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 154741.285844; Mon, 12 Jul 2021 19:29:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m31ce-00022Y-MN; Mon, 12 Jul 2021 19:29:44 +0000 Received: by outflank-mailman (input) for mailman id 154741; Mon, 12 Jul 2021 19:29:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m31cd-00022S-SI for win-pv-devel@lists.xenproject.org; Mon, 12 Jul 2021 19:29:43 +0000 Received: from mail-wr1-x435.google.com (unknown [2a00:1450:4864:20::435]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id abc6137c-4d96-4dd4-9753-34a95d95fe3f; Mon, 12 Jul 2021 19:29:43 +0000 (UTC) Received: by mail-wr1-x435.google.com with SMTP id v5so27153295wrt.3 for ; Mon, 12 Jul 2021 12:29:42 -0700 (PDT) Received: from [192.168.1.186] (host86-143-223-59.range86-143.btcentralplus.com. [86.143.223.59]) by smtp.gmail.com with ESMTPSA id o3sm14345995wrm.5.2021.07.12.12.29.41 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jul 2021 12:29:41 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: abc6137c-4d96-4dd4-9753-34a95d95fe3f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fKVdY/rRGfhMJGgwKGfGLjZZhQjDtlNf6MaxeUzBxEM=; b=DQCiqMY9rjRsN4a65dZcO/tuQ/wmI7wnmTUIC0k1/ZZ+WJuRKr8xe8Ctiz5vG8Y00Q N0htAt0OWIJ7UOi/CSXbeuCAfvkRZ0Zdh2gA6oHMcNu8PSxIBY2cKO8uame4jGWE9Pvp rBEwq8StQuKlvrUSWAmT3FDo9p73KV+9yCtCHelZMey98DEYnVXf5bAJgGCHH0CbHlFT jrWhWM6mHxiKdHtux4t8GpPfdbXXnCNH9yinz+s3h8u4O1NNbGv+nAKn1PD/m9rU5M46 N6wm179/ceov0bdxpnEgvtXX0E38Z6HjlhnxG5G+dXe/PIe2iOxLvz76jhsYOM3nUgnD 1wmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fKVdY/rRGfhMJGgwKGfGLjZZhQjDtlNf6MaxeUzBxEM=; b=tketivk1offHrt2spEI8jD7f1D94BlcGs9SdEaGaByTzQr2rE41Bg+toaz09Qq9+mQ FwjrmSgV5mCKmyWA6Y9V/ahgtUYzM6H0C2jQTnbCMhdbVQ6vuN1/YlNCdRa+/bOEGbR1 OXeMFt1YxTozdy6v9SYBWT+9O7gTvefTW52ypGlOSg4Zt7eGpUbKLf7NrqvXSVdochEe hWQhgR15XDq8k0/bdwE7jvPqjPwvtdyAPVly6Y9bM4pHah94I6lENvglWMe7NTEKNr9t UqgMj9xOLbxoJqpQeEBJJz+5zcz7JvZxex915P72WVYyXsIYj3i3MygETEzd07ktqqu7 /WWw== X-Gm-Message-State: AOAM530QtfeyNw1/IlDkpb3atKO/9ZIta9cJ3i8RPrCUm8+MQIJd6Yu+ HlFiYsPtMj8Su7I/stPnM59YovLlnQY= X-Google-Smtp-Source: ABdhPJxOrj/jwArj2m6FyqBCPNv/hV5TqiDpqV6qhDrZML5K0KDsRM5+d6rEHngkg0VgQolkApDFrw== X-Received: by 2002:a05:6000:1c4:: with SMTP id t4mr682855wrx.181.1626118182195; Mon, 12 Jul 2021 12:29:42 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH] Make sure Frontend->NumQueues is not zero To: win-pv-devel@lists.xenproject.org References: <20210712160701.839-1-owen.smith@citrix.com> Message-ID: <30616fbe-df94-65fc-f56d-e0ce2051334e@xen.org> Date: Mon, 12 Jul 2021 20:29:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210712160701.839-1-owen.smith@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/07/2021 17:07, Owen Smith wrote: > - Checks multi-queue-max-queues is non-zero > - ASSERTs Frontend->NumQueues is non-zero in the accessor > > Signed-off-by: Owen Smith > --- > src/xenvif/frontend.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/src/xenvif/frontend.c b/src/xenvif/frontend.c > index 30de494..f5cb382 100644 > --- a/src/xenvif/frontend.c > +++ b/src/xenvif/frontend.c > @@ -1785,6 +1785,9 @@ FrontendSetNumQueues( > XENBUS_STORE(Free, > &Frontend->StoreInterface, > Buffer); > + > + if (BackendMaxQueues == 0) > + BackendMaxQueues = 1; This means that the backend has deliberately set the node in xenstore to zero. Why do we need to tolerate that? I would have thought refusing to connect would be the better option in the face of such a blatant bug. > } else { > BackendMaxQueues = 1; > } > @@ -1800,6 +1803,7 @@ __FrontendGetNumQueues( > IN PXENVIF_FRONTEND Frontend > ) > { > + ASSERT(Frontend->NumQueues != 0); > return Frontend->NumQueues; > } > > @@ -1953,7 +1957,6 @@ FrontendSetHashAlgorithm( > case XENVIF_PACKET_HASH_ALGORITHM_TOEPLITZ: > // Don't allow toeplitz hashing to be configured for a single > // queue, or if it has been explicitly disabled > - ASSERT(__FrontendGetNumQueues(Frontend) != 0); > status = (__FrontendGetNumQueues(Frontend) == 1 || > Frontend->DisableToeplitz != 0) ? > STATUS_NOT_SUPPORTED : > @@ -2358,7 +2361,7 @@ fail4: > MacDisconnect(__FrontendGetMac(Frontend)); > > Frontend->Split = FALSE; > - Frontend->NumQueues = 0; > + Frontend->NumQueues = 1; > > fail3: > Error("fail3\n"); > @@ -2395,7 +2398,7 @@ FrontendDisconnect( > MacDisconnect(__FrontendGetMac(Frontend)); > > Frontend->Split = FALSE; > - Frontend->NumQueues = 0; > + Frontend->NumQueues = 1; This seems wrong. We're disconnecting, which means there are - by definition - no queues. Paul > > XENBUS_DEBUG(Deregister, > &Frontend->DebugInterface, > @@ -3063,6 +3066,7 @@ FrontendTeardown( > RtlZeroMemory(&Frontend->Lock, sizeof (KSPIN_LOCK)); > > Frontend->BackendDomain = 0; > + Frontend->NumQueues = 0; > > __FrontendFree(Frontend->Prefix); > Frontend->Prefix = NULL; > From win-pv-devel-bounces@lists.xenproject.org Mon Jul 12 20:04:22 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 12 Jul 2021 20:04:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.154747.285849 (Exim 4.92) (envelope-from ) id 1m32A7-0005Z7-R1; Mon, 12 Jul 2021 20:04:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 154747.285849; Mon, 12 Jul 2021 20:04:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m32A7-0005Yz-O0; Mon, 12 Jul 2021 20:04:19 +0000 Received: by outflank-mailman (input) for mailman id 154747; Mon, 12 Jul 2021 20:04:19 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m32A7-0005Yt-1n for win-pv-devel@lists.xenproject.org; Mon, 12 Jul 2021 20:04:19 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" Date: Mon, 12 Jul 2021 20:04:01 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <1570051.1.1626120244562.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> Subject: XENIFACE-master - Build #105 - Successful MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_0_19801768.1626120242406" X-Jenkins-Job: XENIFACE-master X-Jenkins-Result: SUCCESS ------=_Part_0_19801768.1626120242406 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #105. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENIFACE-master/105/console to view the results. ------=_Part_0_19801768.1626120242406-- From win-pv-devel-bounces@lists.xenproject.org Mon Jul 12 20:09:44 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 12 Jul 2021 20:09:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.154753.285853 (Exim 4.92) (envelope-from ) id 1m32FL-0005k5-8L; Mon, 12 Jul 2021 20:09:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 154753.285853; Mon, 12 Jul 2021 20:09:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m32FL-0005jw-5A; Mon, 12 Jul 2021 20:09:43 +0000 Received: by outflank-mailman (input) for mailman id 154753; Mon, 12 Jul 2021 20:09:42 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m32FK-0005jq-Mo for win-pv-devel@lists.xenproject.org; Mon, 12 Jul 2021 20:09:42 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" Date: Mon, 12 Jul 2021 20:09:27 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <20309910.3.1626120568047.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> Subject: XENBUS-master - Build #222 - Successful MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_2_8292281.1626120567890" X-Jenkins-Job: XENBUS-master X-Jenkins-Result: SUCCESS ------=_Part_2_8292281.1626120567890 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #222. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENBUS-master/222/console to view the results. ------=_Part_2_8292281.1626120567890-- From win-pv-devel-bounces@lists.xenproject.org Tue Jul 13 08:05:28 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 13 Jul 2021 08:05:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.155093.286433 (Exim 4.92) (envelope-from ) id 1m3DPx-0006Ae-VV; Tue, 13 Jul 2021 08:05:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 155093.286433; Tue, 13 Jul 2021 08:05:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3DPx-0006AX-Sa; Tue, 13 Jul 2021 08:05:25 +0000 Received: by outflank-mailman (input) for mailman id 155093; Tue, 13 Jul 2021 08:05:24 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3DPw-0006AR-Fd for win-pv-devel@lists.xenproject.org; Tue, 13 Jul 2021 08:05:24 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 12af1723-e3b1-11eb-8729-12813bfff9fa; Tue, 13 Jul 2021 08:05:23 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 12af1723-e3b1-11eb-8729-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626163523; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=sFCjoQsrlM5s4MSM1hoiVUZtH//HSrPJpcDFrB43i1A=; b=Culyrt6AHcpE7naF6kA2XMImAoU2rVHAE3d/KiRaCFlifOI+DgGy/WGY G9DmkWFIiFqFd0hfQcqt1JJg9pyFko/BxAbrFaaciTjTiHpPiJYXwhYw3 GVPrNOVH9SNjn4PLGXoLrJGdc2ckh1NtNReatfnzLYB6yz0j8s839nlfb c=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: YvD8CUds+Zl6tflrVnXx0NADU23hUPG1AlU/bw4j3csTAp3Ym6/AZ5q/jjqH3HezPo3zVhYRZv tErWZBksncM85cAH/cIq6snsYtWPlDaG7Dcp+BsGgNnLZW0jm0otJBT645f+l9ThUeqpT7Ue72 FRQ2j8pwiHuuZB/vFXNtVSmXZwQnaZXxHA/7tvBIzW6WNtPxhUIS9Kd10IxHL9nv1rPY79HSfo 2jsCNjxSOhbtauEHh68g1AF5g5ekdDp3OVT1/Z3EcDcVoFmlXg+A0E5s3Py15oXR7y5aBOXEoX IFU= X-SBRS: 5.1 X-MesageID: 47831809 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:fAG6HKq2DfHPojLQh+TAlGcaV5uxL9V00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssSkb6Ku90KnpewK+yXcH2/hqAV7CZnithILMFu1fBOTZslrd8kHFl9K1kJ 0QC5SWa+eAQGSS7/yKhjVQeuxIqLbozEnrv5am854Hd3AJV0gU1XYcNu/tKDwSeOApP/oEPa vZwvACiyureHwRYMj+LGICRfL/q9rCk4+jSQIaBjY8gTP+wg+A2frfKVy1zx0eWzRAzfMJ6m 7eiTH04a2lrrWS1gLc7WnO9J5b8eGRhOerRfb8y/T9GA+cyTpAV74RGYFqewpF5d1H3Wxa0O UkZS1Qe/ibpUmhOV1d6iGdpjUImAxel0MKj2XozUcL6PaJOw4SGo5Pg5lUfQDe7FdltNZg0L hT12bcrJZPCwjc9R6NkeQgeisa4nZcm0BS5tL7TkYvIrc2eftUt8gS7UlVGJAPEGbz750mCv BnCIXZ6OxNeV2XYnjFti03qebcFkgbD1ODWAwPq8aV2z9ZkDRwyFYZ3tUWmjMF+IgmQ5dJ6u zYOuBjla1ITMURcaVhbd1xCPdfyla9NC4kFVjiamgPOJt3Sk4lmqSHkondvtvaBqDg5KFC6K j8bA== X-IronPort-AV: E=Sophos;i="5.84,236,1620705600"; d="scan'208";a="47831809" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lc3/iXHvMgaFqWYaFbC5nq4rdAtq9vQFVEXP9symQ4WeL9P8iFST+IXMwSq/S0yCzYKg2r/4e+NVY806wyHUHjSrkQJ1VlwTI+F2N7BGsNM6Z2gF+wlKJvVUEJb22pYrWa7vXWOb49maHJHRJqILrGlls5/G5NT3NCHlnufnxAyyqLTDXqqLy3STsMs6m28pHJmaldY2vyw37iGdZyGTebfzcjEkyJ0tbJfb/YhZ3uzJGR3MoDB4KRbSTd8SI7D6EFHWCrO/fV8TjVA6DdSnBmB5TM17FlNn3NwMMfjlJBltvivilEt/TTWv6X1YF6Clz54ID0jzeCoIg6i2WPCNqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sFCjoQsrlM5s4MSM1hoiVUZtH//HSrPJpcDFrB43i1A=; b=BfUmfhhDtFQrAPmc+s2EhwOxLiu0aDnSC7b0XVlGvmfJv4zmqNziGFUCJWJOwYxg4JuBwrfNf+jSqm+nFYXzhsI0dJ1+v3IXmdmycFp+rL47dtCUqvLopyJDPK3FFAHgWzCdmO87HWcm4tiYlxByBh/VsubmpLB5+auXI7NoiS/nvQAGfBXSvQP47NOY4lus76IFnwMcKYS8kNExBeQA3oIo6TkEr/r020tCU+26XBOJC+HOuPidKyKYJJI60QenPS3tjW6dPO7kHJMk5j4Cqol0cW1HMV2/rVyH6aqrHaIQHuW+iCGTdhsna6dbmJUrtFz+zZJ/zeh9PUWIjNPw9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sFCjoQsrlM5s4MSM1hoiVUZtH//HSrPJpcDFrB43i1A=; b=rEXs/lVCOjeHBUtJSFeEU5a3u+BAg3bp0tfnVQIzCCHga2hVAmXxjXPjhmRt7lFDwUGNV1WM0Y/zuiMg8XGS3kf7FIGRixopuU/Sj9Zy0tZIlPQLbPDUclEmcMh5C5eXV0bCLX+cFit0vINXdU8Ll6+XRiFzYiFyVbvPZw5Kdo0= From: Owen Smith To: "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Subject: RE: [PATCH] Add log to Xenfilt DriverAddDevice Thread-Topic: [PATCH] Add log to Xenfilt DriverAddDevice Thread-Index: AQHXcw8lOLHUL2Af8Ue44xu2WMFJtqs/u8QAgADYwSA= Date: Tue, 13 Jul 2021 08:05:12 +0000 Message-ID: References: <20210707085456.1826-1-Martin.Harvey@citrix.com> <20210707085456.1826-2-Martin.Harvey@citrix.com> <60fcc419-10ee-e02a-b235-1d6c8c5d1d25@xen.org> In-Reply-To: <60fcc419-10ee-e02a-b235-1d6c8c5d1d25@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5acab4ce-9b07-4296-0a23-08d945d4f0b6 x-ms-traffictypediagnostic: DM6PR03MB3660: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XJDSh3g/19UlMqJLk75N4M6vqtBF+IO2vZkQw71bejUea6bAhIKYU6FyMzpDh9AsSf7SQgofFSFN/NQHAbBNYhzCRE1w9hb8au7VsIGyVedhSDqFCoxClOiCJfTQMcqzpOfURzTo7S3xVpcrGDOKwur1m29hrMXnZXMEmkSQnczQuGJBxV40vvUMw+tl6CxvvW89fmk2loN8+ZCNLnN6+0mlxMM8a/FnJt56M24An7Zs/wCkk4N3z8vfnu5wOS7qE8sOlGphf91koYh7ASdXXe0pnuZcqPruVvpr5Nj+Nl/37oBrx4sdUTlKYEqBabm25oz0GNx+aJMESVyat3WmluTaKgTCV00JxvYfqAgGW00Dd0fT+jASEV2K7VoZTK3Zb5+Y/lc9JmCjzKqtyzSxym/4LsAzZj1ULYbfY0iyfByuqNZQ0dgaFiDaVx9dReU8GnaakTpReqLy/MWboXU9ljoHIjdc6PIJxSnnWmiinsIUizpj9dpA8dol6XsHMPEJ1tpgG3wj9easpXtzgFYPPAfZRYXj5z4gpOd51I+OeEcJIpVi/akLFm71haoutFYLCv9Tebs865oHGfnF8qG2IOo7W3ACaDDE7sl4JNmuOgxdQD7ZAeHN1FvYAjrlXU4eDR5ViRyWcJ+7J1yUa1sB9Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5477.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(39850400004)(136003)(366004)(396003)(376002)(55016002)(8676002)(44832011)(66556008)(9686003)(66476007)(5660300002)(478600001)(8936002)(83380400001)(64756008)(186003)(76116006)(110136005)(66946007)(52536014)(66446008)(53546011)(33656002)(316002)(122000001)(7696005)(71200400001)(6506007)(86362001)(38100700002)(26005)(2906002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cTZRSFlZa1g5Umkxcis3c1VlSjREQkJ5R2R5UHJibzNvUG8xeG5DY2lGNHpi?= =?utf-8?B?cm9kVTNjdTRuUE8xenNvbld5TWJHL3lSaVVHdU9ZcXlpLzlTWjAxOU1WSTRM?= =?utf-8?B?RE1nUFV0UEFNVkZIdDZQb2ROKzBadnZ4aVgyT1FrSm52bnphLzlNWkZ3T3p4?= =?utf-8?B?RW9XUTI2UGxuSlc4YiszalV0YjFrdTZwNDBBTjdnYWVCSURSVSt6RUF6MFBo?= =?utf-8?B?WUJhTDQwR2h0YlpzVUNsZzdESVE3WHE1Z2EvOG54aXBJeW9vN1MvaUQ5TVk5?= =?utf-8?B?Z0ZlWWNJbTduUmR0cHBZQXE5eThOVWYxREFMU2RYdmNEeTJSQ1pBeUVWK1R1?= =?utf-8?B?SjlRU0dMTFkzNnR4aUxodFVyeWo3SjdhSzlOdTlWeSt3U09JakMxR2pKbGkz?= =?utf-8?B?ckFQWTAzcm5LTXNzajRZdGFQUEoyMS9GblVSN1NJVlNudkExNEpKdXM4alFx?= =?utf-8?B?aEdLVjJacit5OWlENnZPUzd4Q3AwdEYrci9VbWs4Y1ZWNDNvUTBOdENXTnJl?= =?utf-8?B?VEQya3VXYnJNeGlRUmo2ZHZGeUVYRnF3cDA2T3N5amhwRHdlaTZXZkI3c1Qr?= =?utf-8?B?aW1TZW9ONVExUWVTOEJRU1JZdUhpUkZMOWZMak9SSkRoSm1hYzNTMHpqWCtW?= =?utf-8?B?SUIzUWxOdFZNWUdGTUR4Y1Z3Z1BQcXRqdCtiU1lmRWlPenk3V0VVWnhNcjhy?= =?utf-8?B?cDNMaW00cGNHWjBWRFNpa0FyTnE0YUNzUzVlVFlXK2NtQUxuM3JVc0RtUzNm?= =?utf-8?B?NXIvSzI2clozQWpaaTZuTFdnci9YMGEyazA1WW9mcmkvQTEzQnlLa3pCRzFt?= =?utf-8?B?a3R4eDJlV000c1RMbmRQZGxjYnlkd2tEMzVSVkY2WVM3VU1CQXpXMkNRNDVi?= =?utf-8?B?LzJPVFluR1BYNlBOaDJ2dGgxdmxKVjJMakswU2NnZmxIQ0d2VjJQZG8wc2ZZ?= =?utf-8?B?N1BFQ1JMUVMzc29RNnpNcnlEcHRLUERhL1dzRFJPL3FFY1ArbCtNQm9WQmpM?= =?utf-8?B?akdtQzNMRXRBSllGN1BKb29PZlFKbW9wWmhqNGZ2QmNKWUF1YlEvVUdYM0pG?= =?utf-8?B?SEt2b0cwN2FMeVNuMFVHbXVKZThCaUhaWXd4dmsvV1FFSTltM0VSQmFmbWVV?= =?utf-8?B?eC9BSUhVdFZMS2JPa2xydHdyOWRUckdVcEtIM2ZYQnZienZEaExSVklHeEVR?= =?utf-8?B?bXczSWNvOGFwNENFTnR6VnVVZXIxUFRsNFpabElUTHh5b2twaHI0YThGZms0?= =?utf-8?B?bmdmb1Z6Y2ZDNEtqNUpJRkxUeE82aWFPbmdSZ3ZmK2RGZy9TZWR1MjhWSzNa?= =?utf-8?B?bXNwcGRmNUlETnZFYXBOODBzQmJSd09Ha2tzMnpMcDhmK2ZuUG16TGFVT3Nx?= =?utf-8?B?a3N5UVlVbXI2WDNuVU80MDVlVXdOK1RkNXdpZnA1dU9XS3RPTm5lbDM0Z3Vy?= =?utf-8?B?Uy81d1dWK2t6ekExWTcrcEJnaU1YN0NCM21abUVHN01hUVl6V1VQeXVlY2Rl?= =?utf-8?B?VXl6K3B6NzR4OElRZzRxTnJQdVBRNzR2aDlhL1hsaDZ6eVZWcjZQMmtRNFpt?= =?utf-8?B?OE5FSTNPcnpJYVVPdHFFQ1ZpMlNEZUFSajh5a0twRUxFTXM4Qy9LQXFxaDhl?= =?utf-8?B?MTVsMjl6TUJpRGhIa0lyNVV6bWJ1dWljQXZycmo0ajlJSUFYR2NWQWp5KytV?= =?utf-8?B?clMzcnFGRExudFBtNSs0dm5yRkJLSVBBVlVUTUdvV0VqQlV3SWorVVB3b1dU?= =?utf-8?Q?bWbdp1+82nBJFecEhyLpo/iwJVZLIAbqitqmZTm?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5477.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5acab4ce-9b07-4296-0a23-08d945d4f0b6 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2021 08:05:12.2067 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ofND5chSpw/ajVJ+vJ1bPswtiv1zuNhp6dp5WX9lvWZcxqZBmLDvpVuY7ivdKLMOQMV0yK5sdiA0M4R6sVlhwA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3660 X-OriginatorOrg: citrix.com DQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiB3aW4tcHYtZGV2ZWwgPHdpbi1w di1kZXZlbC1ib3VuY2VzQGxpc3RzLnhlbnByb2plY3Qub3JnPiBPbiBCZWhhbGYgT2YgUGF1bCBE dXJyYW50DQpTZW50OiBNb25kYXksIEp1bHkgMTIsIDIwMjEgODowNiBQTQ0KVG86IHdpbi1wdi1k ZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KU3ViamVjdDogUmU6IFtQQVRDSF0gQWRkIGxvZyB0 byBYZW5maWx0IERyaXZlckFkZERldmljZQ0KDQpbQ0FVVElPTiAtIEVYVEVSTkFMIEVNQUlMXSBE TyBOT1QgcmVwbHksIGNsaWNrIGxpbmtzLCBvciBvcGVuIGF0dGFjaG1lbnRzIHVubGVzcyB5b3Ug aGF2ZSB2ZXJpZmllZCB0aGUgc2VuZGVyIGFuZCBrbm93IHRoZSBjb250ZW50IGlzIHNhZmUuDQoN Ck9uIDA3LzA3LzIwMjEgMDk6NTQsIE1hcnRpbiBIYXJ2ZXkgd3JvdGU6DQo+IEZyb206IE93ZW4g U21pdGggPG93ZW4uc21pdGhAY2l0cml4LmNvbT4NCj4gDQo+IExvZyBhbGwgY2FsbHMgdG8gRHJp dmVyQWRkRGV2aWNlLCBhbmQgdGhlIHR5cGUgb2YgdGhlIGRldmljZSBpZiANCj4gcG9zc2libGUN Cg0KQW55IHBhcnRpY3VsYXIgcmVhc29uIGV4aXN0ZW50IGxvZ2dpbmcgaXMgaW5zdWZmaWNpZW50 PyBJIHRoaW5rIHdlIG5lZWQgbW9yZSBqdXN0aWZpY2F0aW9uIGhlcmUuDQoNCiAgIFBhdWwNCg0K DQpUaGVyZSBoYXZlIGJlZW4gY2FzZXMgd2hlcmUgWGVuRmlsdCBsb2FkcyBvbiBhIGRldmljZSBu b2RlIHRoYXQgZG9lc27igJl0IG1hdGNoIGEgWEVORklMVF9FTVVMQVRFRF9PQkpFQ1RfVFlQRSBv ciBEcml2ZXJRdWVyeUlkIGZhaWxzLCBhbmQgKG9uIGEgcmVsZWFzZSBidWlsZCkgbm90aGluZyBn ZXRzIGRpc3BsYXllZC4gVGhpcyBpcyBtb3N0bHkgZGVidWcgb3V0cHV0IGFuZCBtYXkgYmUgZXhj ZXNzaXZlIGZvciBzdGFuZGFyZCB1c2UNCg0KT3dlbg0KDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBP d2VuIFNtaXRoIDxvd2VuLnNtaXRoQGNpdHJpeC5jb20+DQo+IC0tLQ0KPiAgIHNyYy94ZW5maWx0 L2RyaXZlci5jIHwgMTcgKysrKysrKysrKysrKysrKysNCj4gICAxIGZpbGUgY2hhbmdlZCwgMTcg aW5zZXJ0aW9ucygrKQ0KPiANCj4gZGlmZiAtLWdpdCBhL3NyYy94ZW5maWx0L2RyaXZlci5jIGIv c3JjL3hlbmZpbHQvZHJpdmVyLmMgaW5kZXggDQo+IDhmMTRlYzguLjJjOWI1NGUgMTAwNjQ0DQo+ IC0tLSBhL3NyYy94ZW5maWx0L2RyaXZlci5jDQo+ICsrKyBiL3NyYy94ZW5maWx0L2RyaXZlci5j DQo+IEBAIC03MjQsNiArNzI0LDE5IEBAIGZhaWwxOg0KPiAgICAgICByZXR1cm4gc3RhdHVzOw0K PiAgIH0NCj4gICANCj4gK3N0YXRpYyBGT1JDRUlOTElORSBQQ0hBUg0KPiArX19FbXVsYXRlZFR5 cGVOYW1lKA0KPiArICAgIElOICBYRU5GSUxUX0VNVUxBVEVEX09CSkVDVF9UWVBFICAgIFR5cGUN Cj4gKyAgICApDQo+ICt7DQo+ICsgICAgc3dpdGNoIChUeXBlKSB7DQo+ICsgICAgY2FzZSBYRU5G SUxUX0VNVUxBVEVEX09CSkVDVF9UWVBFX1VOS05PV046ICByZXR1cm4gIlVOS05PV04iOw0KPiAr ICAgIGNhc2UgWEVORklMVF9FTVVMQVRFRF9PQkpFQ1RfVFlQRV9QQ0k6ICAgICAgcmV0dXJuICJQ Q0kiOw0KPiArICAgIGNhc2UgWEVORklMVF9FTVVMQVRFRF9PQkpFQ1RfVFlQRV9JREU6ICAgICAg cmV0dXJuICJJREUiOw0KPiArICAgIGRlZmF1bHQ6ICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgcmV0dXJuICJJbnZhbGlkVHlwZSI7DQo+ICsgICAgfQ0KPiArfQ0KPiArDQo+ICAg c3RhdGljIFhFTkZJTFRfRU1VTEFURURfT0JKRUNUX1RZUEUNCj4gICBEcml2ZXJHZXRFbXVsYXRl ZFR5cGUoDQo+ICAgICAgIElOICBQQ0hBUiAgICAgICAgICAgICAgICAgICAgICAgSWQNCj4gQEAg LTgwNSw2ICs4MTgsMTAgQEAgRHJpdmVyQWRkRGV2aWNlKA0KPiAgICAgICAgICAgfQ0KPiAgICAg ICB9DQo+ICAgDQo+ICsgICAgSW5mbygiJXAgJXNcbiIsDQo+ICsgICAgICAgICBQaHlzaWNhbERl dmljZU9iamVjdCwNCj4gKyAgICAgICAgIF9fRW11bGF0ZWRUeXBlTmFtZShUeXBlKSk7DQo+ICsN Cj4gICAgICAgc3RhdHVzID0gU1RBVFVTX1NVQ0NFU1M7DQo+ICAgICAgIGlmIChUeXBlID09IFhF TkZJTFRfRU1VTEFURURfT0JKRUNUX1RZUEVfVU5LTk9XTikNCj4gICAgICAgICAgIGdvdG8gZG9u ZTsNCj4gDQoNCg0K From win-pv-devel-bounces@lists.xenproject.org Tue Jul 13 08:11:06 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 13 Jul 2021 08:11:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.155103.286448 (Exim 4.92) (envelope-from ) id 1m3DVR-0007gd-Kz; Tue, 13 Jul 2021 08:11:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 155103.286448; Tue, 13 Jul 2021 08:11:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3DVR-0007gW-Hm; Tue, 13 Jul 2021 08:11:05 +0000 Received: by outflank-mailman (input) for mailman id 155103; Tue, 13 Jul 2021 08:11:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3DVP-0007gQ-Q3 for win-pv-devel@lists.xenproject.org; Tue, 13 Jul 2021 08:11:03 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8ce87d6a-401f-4070-bb34-9f4051a22aef; Tue, 13 Jul 2021 08:11:01 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 8ce87d6a-401f-4070-bb34-9f4051a22aef DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626163861; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=kLycbmEpnavQnyOHNCg7PtUGnwOl8JrUrr+DuJZLhnQ=; b=BKZCM2PgpSgWXc76AoAss9KDFgaD3l827Z+nyQ4r86JWPF7DwX1fnMec KOJTzD9+35r5cNkV9d/bTBtAJ2p7DPT8hPcBIkdpN3gObh5Ela9T5ORIQ mnL4ZuwDSW3XRwXQ0KCCpQH3kOQDHb+dEVfoONYdDVVYv9wmVscUN8iPD s=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: rt//dAaF0VRxbm3+uZiY7Gdgm23oFlGIo1jCA+1CZWUWDoT6MV24IKO0nIRGqDl7CLFAcvfhWx vmO89lMRY1ZJ5pDoDqYv8c6MougYskmtKo8H262Jxb98scu4+0rsGJmcXlp4RVP6fbbUSS5WBW hXV9TATCKu3U30tKK8GYpMHZRXnUjZAg0AvGzPuf9x0+SqMcq3Vm7dp+I2RInjVSGT+rdaw7Se qzDaJHiZGZ9pv3M/uHmJOrFq7HxhusUCbNTnvOiUcG+wg0l3Zrzb25yc2I5ap7iIbGOBFQ+CY3 UV0= X-SBRS: 5.1 X-MesageID: 48131981 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:W7AwOK+vWI0T/xZlnSpuk+FUdb1zdoMgy1knxilNoENuHPBwxv rAoB1E73PJYW4qKQ0dcdDpAtjlfZquz+8L3WB3B8btYOCGghrmEGgG1+rfKlLbalXDH4JmpM Vdmu1FeaDN5DtB/IfHCWuDYq0dKbC8mcjC74q/vhRQpENRGttdBm9Ce12m+yZNNW577O8CZe OhD7181lydkBosH6GGL0hAe9KGi8zAlZrgbxJDLQUg8hOygTSh76O/OwSE3z8FOgk/gYsKwC zgqUjU96+ju/a0xlv3zGnI9albn9Pn159qGNGMsM4IMT/h4zzYJ7iJGofy/gzdktvfrGrCo+ O85CvI+P4DrU85S1vF5CcFHTOQiQrGpUWSkWNwykGT3/ARDAhKevapw7gpKCcxonBQzO1Uwe ZF2XmUuIFQCg6FlCPh58LQXxUvjUasp2E++NRjxUC3fLFuIIO5l7Zvt3+90a1wax7S+cQiCq 1jHcvc7PFZfReTaG3YpHBmxJipUm4oFhmLT0AesojNugIm0ExR3g8d3ogSj30A/JUyR91N4P nFKL1hkPVLQtUNZaxwCe8dSY+8C3DLQxjLLGWOSG6XWZ3v+0i94qIfxY9FkN1CVKZ4vqfaqa 6xJm+w71RCCH4GIff+qaF2zg== X-IronPort-AV: E=Sophos;i="5.84,236,1620705600"; d="scan'208";a="48131981" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dcWFS/JMokOa1qODlpRA9Z5N0PpnAykZ9e3ThmqruZL2YeL1pBOygI3wITct91CH0yPd5YspZFI20yI/+Oow1w99SnHOiEJ2CkW358AW2uF13TfYf0/IvsEyFIlSXUjFao2JMsXbIRzUH82+AoL+YRYfYdnjmooZdfYq2JAutcxas6juhHBfJ+fbMUofmg64OQ3BWTP6MzeZygv8Hv/LAjy8bpf2zSeWQRFAB6yQUsq6446pm/HTFIp/qcBtVhotJu0IImndFZpywedknyef691GNY/lJCDTPjaY4736qBAxmWkjdE1vdnbr1Ef45HC4f4gEGcyDBnBi+olcnfJM5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kLycbmEpnavQnyOHNCg7PtUGnwOl8JrUrr+DuJZLhnQ=; b=f99oCEl1eeh/YdLVK3TlCZ16pD/+WkicYb98In42ojpQ1bnkaUrxS2n5EYBHb0CQAyrxO5cJdZ+R3YYNOoCd6VVXa3f2TqjYsuFC2ZkU+q6RHcZP9nH87gVWFYe+q8ViK1mxnCmKrgEqhN1ru0YllkE9gm9CHxnLP24AzgUrG8GCtjPTnOUwTrA8Iwo12tsuhXXFqfYcI3GSRjibFAGOIWOOO1pgDc0elbsrlVVbGTkqrSr4j6OetkntH8bopTwBkDuWKVqfy93ys7NNPdB3/ewn9jxwXW033maYXqDmKST83UP1IHNL/Or6TbaE2VY35eM9dFmKzx0/4d0TuDYFVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kLycbmEpnavQnyOHNCg7PtUGnwOl8JrUrr+DuJZLhnQ=; b=K3BJpGDV0WPZMrmo1DC34ZRHBDoLY/NYFe0JSt1UfXxjCHkFYZIKessuTD7rRCTElj8+9QySWE46MGAjkobtFjdStvr1giCk1V80l3mQDO6GVshsZ4/ruLuNs0SCJP9tbEDyCG5zYsES7oHW2W8qbnqHXnIvb/aWja2b6QkjYTY= From: Owen Smith To: "paul@xen.org" , "win-pv-devel@lists.xenproject.org" CC: Martin Harvey Subject: RE: [PATCH] Disable CONS debug logging Thread-Topic: [PATCH] Disable CONS debug logging Thread-Index: AQHXcw9B8JOCMi7pNkCxw1Gex+9yXqs/vIGAgADZPpA= Date: Tue, 13 Jul 2021 08:10:54 +0000 Message-ID: References: <20210707085456.1826-1-Martin.Harvey@citrix.com> <20210707085456.1826-3-Martin.Harvey@citrix.com> <7074bcda-ec68-01eb-a519-88c3447efa47@xen.org> In-Reply-To: <7074bcda-ec68-01eb-a519-88c3447efa47@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 08fddf3a-abf9-413a-74ab-08d945d5bcce x-ms-traffictypediagnostic: DM6PR03MB4796: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2/yddqIBjaHSEENAtZxc8a+CDUXhNM4J+rXgnEuP77iZ3ik+iTd1DVrdNUOqSSHhGSmWbt8EBCDYNwhPwxV16tRhdWaZb7XisP/cSw6nPcr74EltZJTCap+Lt/hxdReKw7HRQWloe2VWgOQMkkZ7VnB3kAf1XsM8jXphlr0PeGRXYqDCyaCbBrUZxvXOEPG/1PaNwuVRbx5DFB3ZAryfxKzfzErFPfcCGxJpONAjOre7ejef1PvL0Saeegy9Jiqstxpx2VqngJPrrfTVRnt7DphA+05wOHbtZweik1Po1aykS4nO9LxftheSjlkGEn0hp6tJPAgcNBD1hKhccDI1vYzQ315DgCA15heZRZZD0unjUQlCX5Ovi0mGi8QvfKYmILCbf/IK6KAy57toIqE4/BmRnZB/l6SIXXV8mJqEl6QQAaQqb8e/nWlsD2XDPC3PyUQLdjyid5XremcEzM8zHym2/qmTcju/gX75WJ1vcSxni4coQcAEqVG53EPUXu7xxHp30CMrLXwszzUfV4Q8oFZxiVQaTmdfNh10KVVQQRVbZk1n1xEKwcsX1mwywvLHUe3XeP1Yi3Cd71Ox9fD1LQVCoWwrcW0LOkR81jkV9+bzn4+z6V+ll8OwtMqW2iNrjl4MUYjPCwZJvuMM9g9CzA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5477.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(346002)(376002)(136003)(39850400004)(396003)(5660300002)(6506007)(83380400001)(71200400001)(110136005)(33656002)(26005)(8936002)(186003)(38100700002)(4326008)(7696005)(107886003)(76116006)(2906002)(316002)(122000001)(9686003)(44832011)(8676002)(66556008)(66946007)(66446008)(66476007)(55016002)(53546011)(86362001)(52536014)(64756008)(478600001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?c21nRkJJZUt3d250eE1aTWNTendrdlR2V2h6dnh6VkhwbER2N2NUeG44ckdh?= =?utf-8?B?WWh6N1ZhYkV5dU1EcUowMVJ1YWVHZUJkWlVjVTR5SWN4WEZHNHhGU0VXZFJ6?= =?utf-8?B?NW5FQmR2VklpUnhpeS9NcUUwbDh5cFRkL25kaXIxOTB6aG40WGdvWnVRUjh3?= =?utf-8?B?MTR1N1VrVWQ2L2ZTdzR4SkNUZG5nMmNlL0F2NjVzNkZPYXNMTUpvVFJaUFdr?= =?utf-8?B?QTFLZGEyZWErcG1UbEJLb3VDMjNFaWY4SmJoZER3OEk0T0EzVXRzaWcvVkxL?= =?utf-8?B?V2RabW5ZckcvaC96NGUxVWVYR0ZOMExEN1NFclBaS0FJYWlKWC9uMFAwbThh?= =?utf-8?B?UXA1c25ieDhGOEpmK3FRNzkybTEvZWcwcVhzNUJNckF6cTE0NlM5RUxEc2Zw?= =?utf-8?B?by8wTGZYOEJpRkxnSmtqM01lWVNaSG5pclRFTWNZWS9PNU1GbkEzUURWVytU?= =?utf-8?B?cGt2Y3FIRFF1OXpadWtXMnRCd2tOVUJCVUgza25WbGU2WkhzQmUxZEp0bUNl?= =?utf-8?B?NHpGUEp6Y3l1dHNTZGpqNXZteU0vQmRQTkpPOVpieDRMZ0VjZjM1dW16OTRS?= =?utf-8?B?VjRFUWR4WVZQc3IvcjJpc2JCcUlrNGd5Yng3REtkVjBKdjNHdks4Nm9KNVRt?= =?utf-8?B?aXF3RThvSmdBR0pDR3hZckdDbU16OVF6RWE5cHY4RHlYUHR0TWxNczBEdk11?= =?utf-8?B?SVNsSDVkZmlPUFE4dGlqUUNITFpkQVVkak5mNjloeWZjYVJheUFrRjR5clRG?= =?utf-8?B?SklLbFl2cXMrL3ZLNWVwTW0xSkJWV3JWM0NjOGJZdTVNakh0OGc3QmZHVGRL?= =?utf-8?B?ZzNMVityQzVOSHVXM0RRazRWdGhLWlZXSmxnNzAwcG1sQXA5VmJwODQrdFRm?= =?utf-8?B?ajlPbkpCZllDZFNVdWd6cDV0SEpOY2VEdHYvdk5GTnpsMVlNNEVFYWJmNHZ2?= =?utf-8?B?Z01nMEczMW1KN1k2eXhYd200REw5VW1kTGE1TVRMSE9IaWNVZENITE02NmV2?= =?utf-8?B?cXc4b1hHdXlGcWFwNHp0cXFadm1RUTdlWFJHQVY0ZWRMRU4rbFZ5UjdTV0lr?= =?utf-8?B?N2hrMU5OZ3dCTitLd1d2aDZzY05sOUI1Q0VTVzUrcjZ5MTZ3R2NwNytsMHpR?= =?utf-8?B?Q2w4cGtXQzlsek1mM1pFSzZKVHd0TGNkbFMwWHJEQUh4Tis0ekFSZ1dpNjZU?= =?utf-8?B?eDhrcVFQNDRyKzBvWGNlVm1MeDdmbG5vMVhhZEZwR3NuUm5adlJmVDdwUm05?= =?utf-8?B?Zm5aZjV1QlQ1eVNmMlFPRTZJT3FCNFBzd05pS3FTbDI3ZlA1M2ZBMzJjVExK?= =?utf-8?B?L2t4cjc3UGd3TzFoaWRqbkJ2UXg2Q2duUlhFMzVyRXpqUGVTeGs4dFpBUmdG?= =?utf-8?B?NnBHbjJWb0N4cWc2UXpKRWNSb1lNMmRXWmVrbXgvZmxEVGNhS0wzelB0akIw?= =?utf-8?B?QlYralA1eGR4bzI5bDdMdmNSU1htZTMzUHpBUWdoK2RlTmQ5K01BUnNxeFJK?= =?utf-8?B?MjZ2ZzdUbVJCZ2RWRVBPd0FGRmkvVGQ0VE1kVjZ4UGYxcjhucEtBQVhCMDl4?= =?utf-8?B?TTRqYjhVNkNWWlM3TThXeWJZaUU2OUw4bTFnbDR5M1RMZkNSVEdzSXA4UCta?= =?utf-8?B?TjJOamVUek54dWFRcnNDR0NjUitIcFZ6N3VVN2k1NGJYRmI3TXJTWEV3em03?= =?utf-8?B?a0pDUU9MYW0ycUxYaHdOU09WeEJIZnhONGJDOGdva1ZkbVZEQVE0WWRZWVVj?= =?utf-8?Q?pBeI+FWIGQiD8hswIU2SYqMYO8IRxC83+JgSKFs?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5477.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08fddf3a-abf9-413a-74ab-08d945d5bcce X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2021 08:10:54.6348 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sKhtjfUFO56PIYBdFrdzAdIiquX/nxDeOViSfhgDYSCCQ22h6iSgx0UVRJkUdeF8/WYp432s+OsKbRTiEnMJYw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4796 X-OriginatorOrg: citrix.com DQotLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KRnJvbTogd2luLXB2LWRldmVsIDx3aW4tcHYt ZGV2ZWwtYm91bmNlc0BsaXN0cy54ZW5wcm9qZWN0Lm9yZz4gT24gQmVoYWxmIE9mIFBhdWwgRHVy cmFudA0KU2VudDogTW9uZGF5LCBKdWx5IDEyLCAyMDIxIDg6MDkgUE0NClRvOiB3aW4tcHYtZGV2 ZWxAbGlzdHMueGVucHJvamVjdC5vcmcNClN1YmplY3Q6IFJlOiBbUEFUQ0hdIERpc2FibGUgQ09O UyBkZWJ1ZyBsb2dnaW5nDQoNCltDQVVUSU9OIC0gRVhURVJOQUwgRU1BSUxdIERPIE5PVCByZXBs eSwgY2xpY2sgbGlua3MsIG9yIG9wZW4gYXR0YWNobWVudHMgdW5sZXNzIHlvdSBoYXZlIHZlcmlm aWVkIHRoZSBzZW5kZXIgYW5kIGtub3cgdGhlIGNvbnRlbnQgaXMgc2FmZS4NCg0KT24gMDcvMDcv MjAyMSAwOTo1NCwgTWFydGluIEhhcnZleSB3cm90ZToNCj4gRnJvbTogT3dlbiBTbWl0aCA8b3dl bi5zbWl0aEBjaXRyaXguY29tPg0KPiANCg0KYSkgV2h5Pw0KDQoNCkxvZ2dpbmcgdmlhIHRoZSBj b25zb2xlIHJpbmcgZG9lcyBtYWtlIHRoZSBzdGFuZGFyZCBjb25zb2xlIGFjY2VzcyBtZXNzaWVy LiBZb3UgY2FuIGdldCBpbnRlcmxlYXZlZCBvdXRwdXQgZnJvbSBsb2dnaW5nIGFuZCBYZW5Db25z J3MgVFRZIGVuZHBvaW50LiBUaGUgY3VycmVudCBUVFkgZW5kcG9pbnQgc2hvdWxkIHByb2JhYmx5 IG1vdmUgdG8gYSBzZWNvbmRhcnkgY29uc29sZSByaW5nLg0KDQo+IFNpZ25lZC1vZmYtYnk6IE93 ZW4gU21pdGggPG93ZW4uc21pdGhAY2l0cml4LmNvbT4NCj4gLS0tDQo+ICAgc3JjL3hlbmJ1cy9k cml2ZXIuYyB8IDggKysrKy0tLS0NCj4gICAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCsp LCA0IGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL3NyYy94ZW5idXMvZHJpdmVyLmMg Yi9zcmMveGVuYnVzL2RyaXZlci5jIGluZGV4IA0KPiAxYjYyMWZhLi5mMzUzYTYxIDEwMDY0NA0K PiAtLS0gYS9zcmMveGVuYnVzL2RyaXZlci5jDQo+ICsrKyBiL3NyYy94ZW5idXMvZHJpdmVyLmMN Cj4gQEAgLTU4LDEwICs1OCwxMCBAQCB0eXBlZGVmIHN0cnVjdCBfWEVOQlVTX0RSSVZFUiB7DQo+ ICAgc3RhdGljIFhFTkJVU19EUklWRVIgICAgRHJpdmVyOw0KPiAgIA0KPiAgICNkZWZpbmUgWEVO QlVTX0RSSVZFUl9UQUcgICAnVklSRCcNCj4gLSNkZWZpbmUgREVGQVVMVF9DT05TT0xFX0xPR19M RVZFTCAgIChMT0dfTEVWRUxfSU5GTyB8ICAgICAgIFwNCj4gLSAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBMT0dfTEVWRUxfV0FSTklORyB8ICAgIFwNCj4gLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBMT0dfTEVWRUxfRVJST1IgfCAgICAgIFwNCj4gLSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBMT0dfTEVWRUxfQ1JJVElDQUwpDQo+ ICsjZGVmaW5lIERFRkFVTFRfQ09OU09MRV9MT0dfTEVWRUwgICAwIC8vIChMT0dfTEVWRUxfSU5G TyB8ICAgICAgIFwNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLy8g IExPR19MRVZFTF9XQVJOSU5HIHwgICAgXA0KPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAvLyAgTE9HX0xFVkVMX0VSUk9SIHwgICAgICBcDQo+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIC8vICBMT0dfTEVWRUxfQ1JJVElDQUwpDQoNCmIpIExl YXZpbmcgY29kZSBpbiBjb21tZW50cyBsaWtlIHRoaXMgaXMgbm90IHNvbWV0aGluZyB3ZSB3YW50 DQoNCklmIHRoZXJlIGlzIGEgcmVhc29uYWJsZSBqdXN0aWZpY2F0aW9uIGZvciB3aHkgd2Ugd2Fu dCBubyBsb2dnaW5nIHRocm91Z2ggdGhlIGNvbnNvbGUgdGhlbiBkaXRjaCB0aGUgY29tbWVudHMu DQoNCiAgIFBhdWwNCg0KVGhlIHBhdGNoIHdhcyBvcmlnaW5hbGx5IHdyaXR0ZW4gbGlrZSB0aGlz IHRvIGF2b2lkIGNoYW5naW5nIGxpbmUgbnVtYmVycyBmb3Igc3Vic2VxdWVudCBwYXRjaGVzIGlu IHRoZSBDaXRyaXggcGF0Y2ggcXVldWUuDQpQYXRjaCBzaG91bGQgYmUgcmV3b3JrZWQgdG8gcmVt b3ZlIHRoZSBjb21tZW50cw0KDQpPd2VuDQoNCj4gICANCj4gICBzdGF0aWMgRk9SQ0VJTkxJTkUg UFZPSUQNCj4gICBfX0RyaXZlckFsbG9jYXRlKA0KPiANCg0KDQo= From win-pv-devel-bounces@lists.xenproject.org Tue Jul 13 08:13:53 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 13 Jul 2021 08:13:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.155117.286467 (Exim 4.92) (envelope-from ) id 1m3DY9-0008S9-DF; Tue, 13 Jul 2021 08:13:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 155117.286467; Tue, 13 Jul 2021 08:13:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3DY9-0008S2-9g; Tue, 13 Jul 2021 08:13:53 +0000 Received: by outflank-mailman (input) for mailman id 155117; Tue, 13 Jul 2021 08:13:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3DY8-0008Rs-Kk for win-pv-devel@lists.xenproject.org; Tue, 13 Jul 2021 08:13:52 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4191ada6-e3b2-11eb-872a-12813bfff9fa; Tue, 13 Jul 2021 08:13:51 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 4191ada6-e3b2-11eb-872a-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626164031; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=NoJ97vnXZ6HGj10QNdzFANlI8pTBATvULnZ5Rv/UKvg=; b=Ro8+SmlRyBPPf+1CtV0oXN4FqQmf5Z//TIPboIcZzQNyGQdJtemYNgSl 580qcNbIgSXYa6Oor3m17UczgxrUISDQXwr45OJ4uqDVAY2BwGJJK7PxE WCUW3A0LX1Mu2+cJpIuSwiAUL8QBfBsUKvE110MBxsCfvt980Pg2tLD2r w=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: i1sdk/wsu4shVUlMZUvYHNPg/JUrEzjqnl0VSck8q08XtFHiGpRCQUEag1l7H4051PF7KRbOQ5 GHFN17mGiiMNd3ZcpUvHpZTPpDYPEMIU7EFvgAdBOvyVVR6y7D97ZcNxonhNz0HXbm6RpP3imI vAb54zKdsMakLj//H1UlVjrhS6T6VVU6ShQaepYU8pOc4/O8chLeNxZSI2vmoGEKnwQtLUDX4j gH7njHuDbZfhBUjKrQhgiXcc3rOQMR3LM/z5W9WBpufyow8mzJ095aK0jlDPAVc1qGISBpIHek bqc= X-SBRS: 5.1 X-MesageID: 48132105 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:eaN2WK1OhhF9QUUouDVQuAqjBSFyeYIsimQD101hICG9Lfb2qy n+ppgmPEHP5Qr5AEtQ4+xoS5PwPE80kqQFrbX5XI3SETUO3VHHEGgM1/qF/9SNIVycygcZ79 YaT0EcMqy+MbEZt7eC3ODQKb9Jq7PnkJxAx92ut0uFJTsaMp2IhD0JbzpzZ3cGIzWucqBJcK Z0iPA3xQaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnX4j4uFxd0hZsy+2 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlVFtyssHfpWG1SYczBgNkHmpDr1L/sqq iJn/4UBbUx15oWRBDznfKi4Xin7N9k0Q6f9bbRuwqdnSW+fkNjNyMJv/MmTjLJr0Unp91yy6 RNwiaQsIdWFwrJmGDn68HPTAwCrDv8nZMOq59ls5Vka/ppVFaRl/1swGpFVJMbWC7q4oEuF+ djSMna+fZNaFufK3TUpHNmztCgVmk6Wk7ueDlIhuWFlzxN2HxpxUoRw8IS2n8G6ZImUpFBo+ DJKL5hmr1CRtIfKah9GOACS82qDXGle2OFDItTGyWSKEgjAQOGl3fa2sRE2AiaQu188HJpou WxbLpxjx9AR37T X-IronPort-AV: E=Sophos;i="5.84,236,1620705600"; d="scan'208";a="48132105" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RUa7xR5RL+jFPwGB/dk2X32cELftDfgvhVAqdSsZGEo4yipxCOEW8X7oMcUdUhoQUGg1xMukz5eTyu8JSer6XJ1GE35Od62GvWeajNJyRb6JkPgrbJ1jDDAFcfxMtxz9KF2ErotUPbZsaDzeuWiqy+WvUUckXiTZW8mgXvd2SdnPRWVGchpImJhZR0kjkyb0XFcXYC8xPJUGztPakJz0R5jT35g9tfsMNLhuO7eRlW1LWAjLdYChsgTJbxE3y8y7RkwP43pNqOf/NAX1jwiauOAEtJMkl2jwK/2rFXTsMjn1p/5Z6fPyYCzlySZV7ZJQx+FFIV2H4sbSTXZHyvutCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NoJ97vnXZ6HGj10QNdzFANlI8pTBATvULnZ5Rv/UKvg=; b=PC0Qp4JNJztpT8FcfO7BQMwSC93r5VHq1k1WKSpIrZWqlVyIjgkJzD6tJ2Wzov4Tnltzg0BsMgOtLTkmt9AufxHZG94x8BiYqqNDov2McRB7xN4BhfDyGHR5Qkyp+gW880YXeabRgBcEO2RrpFzNaWuic8cE0HwzwLsfG7rNMxeay1ZDkT2rJAtbFxgTgjlbgOk3350I1YoYYDUeTIxNSSvH2KY2KLNaFBfTHb7KQkDmeIliQietnU2NbaUSxH9I9Dk6fo0BeftaMAE30Sbj6anM3eXraTzc5eR7LX93zKFhaHmatZ6sfgg6S9BrqpuPTSQD3aJOyL2e8mupBX3B2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NoJ97vnXZ6HGj10QNdzFANlI8pTBATvULnZ5Rv/UKvg=; b=A5CGOsSoJN72k0R1yg/aKza7fbfXaLKfsBFjcLeNi+b1DiDwrYR6YsmA2H7/lY6vpBmx3xWxW5YVrWJpshDPbBcGEw9ULPjwZjRC5geqgjS4GtRKJ7uxS9EQ6wHqNY3sg9MqNEZSCTQw7NxgLdB/hTQJGj7NTzAO3R6X6tPW1CU= From: Owen Smith To: "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Subject: RE: [PATCH] Reduce logging of Fdo->NotDisableable Thread-Topic: [PATCH] Reduce logging of Fdo->NotDisableable Thread-Index: AQHXcw9ByxyQqunqYkSsOfMPiyPxWKs/vVOAgADZ6oA= Date: Tue, 13 Jul 2021 08:13:42 +0000 Message-ID: References: <20210707085456.1826-1-Martin.Harvey@citrix.com> <20210707085456.1826-5-Martin.Harvey@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8223fb98-6a08-4804-b622-08d945d620f2 x-ms-traffictypediagnostic: DM6PR03MB4796: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FPN6YdcRXZ0MtFUesvp7wrKSo78RLANWyuWyc3l3KCtid3K3loszljChAkJkjxehmZ/4EYAGOIzKQuoqN1GeMKXGh5l/F9kN49LowQx/DpohuIFolJqpDcMlSr34iwVbkx4/tOgVvqBbE9RG7YhjXu+Mw5Ou0gJJNExZADHXZIx3FzUo/z2UEO1z9160LavXNXwRgOhASIDcp4CosdSsLxUKWlN52TKeM3zOMeBXoy+tECGQojdh4Xw942DZn6SKdH2KEscabbTIN4pPXBYzesNLZ+VWzc2tCP8POYldwWTrs7lTOQ+udefOpDEo0FA9VEqZBT045m31fqMrvYPOIXV1Hi4LZEnXrdme6d+1twoVyOqRww5WaWFx1ExgRXKSlZy/4ZDXKatod3oweFgVbaU7ZsroN3PS2RtiVcq/XGBXc6jnTPK6O02Zka/v+ITaW3JrTbfzR4/fgMkxbbF9vUxYCCUZPhoUIjW96+tvMP1BAXe0QibL8vJ4APOz9v+iR6IFqCB7dhmXoLbM1NHScqbvn1YiTTfC2ktgoJmQVNKeMAkzGrqgChy7gm7a9jPOhWSo5sfs3ObEJFkIigHZBYVT8baDRXfQJNLwYVY4Jrqzvr2Lr6ZDDInoovyTarwQtSjPYMGlLiyYNIxj3iExrQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5477.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(346002)(376002)(136003)(39850400004)(396003)(5660300002)(6506007)(83380400001)(71200400001)(110136005)(33656002)(26005)(8936002)(186003)(38100700002)(7696005)(76116006)(2906002)(316002)(122000001)(9686003)(44832011)(8676002)(66556008)(66946007)(66446008)(66476007)(55016002)(53546011)(86362001)(52536014)(64756008)(478600001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZVI4V0ZVaXpDd2NGYTVwMVlxQ0xRQ1RDakdJbG0wNTNzaStrcTlya3h5QXRl?= =?utf-8?B?TFArZk1VQy9VSnBLWG1xcWZHZ0txckNGMDlQQXJBa0J5UUVvc1cxSEFuTE9m?= =?utf-8?B?ajJrV0UwUlRnYkYxSzBWZ1dCR2d4Q0pVM25PVTczOWlEUitQZFlLRWlacGVn?= =?utf-8?B?L3FMOXdrQmtoYUpzY040cGxuODZwY1BReis1dUlmeVd4c09mOUloWU5oc2lp?= =?utf-8?B?N1VERWlnV0hjMGJWb0xNb0lsT0l3bXpTSXNEWWxicTZ4WVlkb09tclJSMlVH?= =?utf-8?B?aWRGbkQ5c0djVmcycFVndGZndzdYeUZTc1dxdWsxM3FYVkZxSE1iMExKcGdh?= =?utf-8?B?MDRKZlVWQnluUUR0a2ZURHhEd3JISDVYekZCOUtKSG9hVVdQS0pGQ0RZK1R1?= =?utf-8?B?bS95eTNTVENLbk0xOC8vS01meTE4VDU4eXhFTmRDVkZrRUdFa0F3MVF6STFQ?= =?utf-8?B?WjVJTkFwZkJiRGJaaXZFNmFiVU9MNU1udlgxd29QbDlsSVd2MnB6SWlzRWht?= =?utf-8?B?dENrMXJid1FNcDJwMW1scGUxQW1JT2RHVkRUSURXd0FjRXVrLzE0aXVNdGZ4?= =?utf-8?B?Yks4SXpxRU5jRUVpbFR2TnltNGRWQTgxb2Z2SU9OWHllZmlmbmpTS1F3bGlB?= =?utf-8?B?QXNvQmlVTDk2bU9ScTQ2aGNCekErWmQ3TERSOXNCUk5zWlhUb0JVSDhrdVJq?= =?utf-8?B?Zk9BTnNoRmpIZjFHMERMUG9OWURSNzhZN1NkTy85aU9lTWx0NzVZbFF4ZTlC?= =?utf-8?B?bnpJMDNvTjladXRGSkNZMUlsVGcrNVRJb1BHMUJ3MjFQRVA1Y05yU1FWSWhv?= =?utf-8?B?NVpkRjNjYVFkSlNhbi9rQmtvWjNRNnI2WHAvbTdxV3pNM3ZaSFdjQkRWQTQ0?= =?utf-8?B?WG9XemNZWjl3UXhWL2x5Q2V4cVZvUXlJcXd0M1pXamdGVXNhMFc2dmxMZlJI?= =?utf-8?B?UDQrWDRQcHZQSmdySmNhWDdreDBvTlkrK094TDBLYk9Xa0JuYjFiQkM3ZUhU?= =?utf-8?B?VEtGck8rTEUxemdpNDMxYUFzb2g2VFpyb29Xd21ZYnhpQjl5V25vRlF2dVdK?= =?utf-8?B?ZzcxRGtEcExNMmRXNDFWeGdlTzRzUHhtRjBYbVpBVzJVQSthRTVnR0duYVdq?= =?utf-8?B?MHdYUU1Va2lIMDJpQjRIc3pIdXBBUTJZclFyUlRkWGhjRmhscVJ2Uml1NXFs?= =?utf-8?B?ZEFTaklSMTNaR002RGZsdTZFcC92QURkWkxVRjZjdkVra2NVaTUxN1pOTGtQ?= =?utf-8?B?b2NOeWVwV0hPcGYwWFFldUV6QS9TS2lEbUNPM04rdWh4aEhzZWFMcXBiZ1BK?= =?utf-8?B?aXpUR2JlTytDdEVJVC84U1kvclZwRmU1NWorT3JpR0JMT3FaZ1NXSEtVc2sw?= =?utf-8?B?bTU0N1dYdzVWWXVsemRFMEFYNWJjYlhjSzhlMU5YeWdpVGd0K2FuMi83dFhL?= =?utf-8?B?R0FxbW9VNS91Q3JacmR5UGNxWlBBRFprd0JVWkY4K1dBMGtqZXNCS0FzZ0Vt?= =?utf-8?B?dFlBellPcEhVckFKckt2UlRXRTE0UVlWOUJ3cTZKL1c5SldpTmUzTTRUSmRO?= =?utf-8?B?NGpwTVV2QnJGL0dTY1pWcHZkQnlDdjJjbDltVTN0WEVZSEtBUVdpN24xazhB?= =?utf-8?B?QnNDUWE2ZVRxVXg0NWdVcS81bTYyMnovUi96THJMRVNIR0NmMmY4bzM3cUdE?= =?utf-8?B?SU5hMUFkOU5GQVpJQXFFQ2tMZjZOV1BMREFKdjk1U2c2VTJFOFd5dXJjWWZr?= =?utf-8?Q?IljErqXfV/eLbW/6dTK4jTHXPtcXj74v3j2pwBl?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5477.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8223fb98-6a08-4804-b622-08d945d620f2 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2021 08:13:42.6446 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8P2nOwK5W2tlPREAMzSW+2iHPrPpET9C64o8zt87rhJc4arVA+qLAoSoPYari31yhEmjviZ34I7a42TD3j1bsQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4796 X-OriginatorOrg: citrix.com DQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiB3aW4tcHYtZGV2ZWwgPHdpbi1w di1kZXZlbC1ib3VuY2VzQGxpc3RzLnhlbnByb2plY3Qub3JnPiBPbiBCZWhhbGYgT2YgUGF1bCBE dXJyYW50DQpTZW50OiBNb25kYXksIEp1bHkgMTIsIDIwMjEgODoxMiBQTQ0KVG86IHdpbi1wdi1k ZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KU3ViamVjdDogUmU6IFtQQVRDSF0gUmVkdWNlIGxv Z2dpbmcgb2YgRmRvLT5Ob3REaXNhYmxlYWJsZQ0KDQpbQ0FVVElPTiAtIEVYVEVSTkFMIEVNQUlM XSBETyBOT1QgcmVwbHksIGNsaWNrIGxpbmtzLCBvciBvcGVuIGF0dGFjaG1lbnRzIHVubGVzcyB5 b3UgaGF2ZSB2ZXJpZmllZCB0aGUgc2VuZGVyIGFuZCBrbm93IHRoZSBjb250ZW50IGlzIHNhZmUu DQoNCk9uIDA3LzA3LzIwMjEgMDk6NTQsIE1hcnRpbiBIYXJ2ZXkgd3JvdGU6DQo+IEZyb206IE93 ZW4gU21pdGggPG93ZW4uc21pdGhAY2l0cml4LmNvbT4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IE93 ZW4gU21pdGggPG93ZW4uc21pdGhAY2l0cml4LmNvbT4NCg0KWWVzLCBpdCBpcyBwcm9iYWJseSB1 bm5lY2Vzc2FyeSB0byBsb2cgdGhpcyBhdCBJTkZPIGxldmVsLg0KDQpBY2tlZC1ieTogUGF1bCBE dXJyYW50IDxwYXVsQHhlbi5vcmc+DQoNCg0KRllJLCBzb21lIDNyZCBwYXJ0eSBkcml2ZXJzIGNh biB0cmlnZ2VyIFF1ZXJ5IFBuUCBEZXZpY2UgU3RhdGUgZmFyIG1vcmUgb2Z0ZW4gdGhhbiByZXF1 aXJlZCwgbGVhZGluZyB0byBjb25zaWRlcmFibGUgbG9nZ2luZyBhbmQgcG9zc2libHkgZmlsbGlu ZyB1cCBnaWdhYnl0ZXMgb2YgbG9nIGZpbGVzIHJhcGlkbHkuDQoNCk93ZW4NCg0KPiAtLS0NCj4g ICBzcmMveGVuYnVzL2Zkby5jIHwgMiArLQ0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlv bigrKSwgMSBkZWxldGlvbigtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL3NyYy94ZW5idXMvZmRvLmMg Yi9zcmMveGVuYnVzL2Zkby5jIGluZGV4IA0KPiAwM2E3MWMwLi5iOGY5YzFhIDEwMDY0NA0KPiAt LS0gYS9zcmMveGVuYnVzL2Zkby5jDQo+ICsrKyBiL3NyYy94ZW5idXMvZmRvLmMNCj4gQEAgLTQ1 MzAsNyArNDUzMCw3IEBAIEZkb1F1ZXJ5UG5wRGV2aWNlU3RhdGUoDQo+ICAgICAgICAgICBnb3Rv IGRvbmU7DQo+ICAgDQo+ICAgICAgIGlmIChGZG8tPk5vdERpc2FibGVhYmxlKSB7DQo+IC0gICAg ICAgIEluZm8oIiVzOiBub3QgZGlzYWJsZWFibGVcbiIsIF9fRmRvR2V0TmFtZShGZG8pKTsNCj4g KyAgICAgICAgVHJhY2UoIiVzOiBub3QgZGlzYWJsZWFibGVcbiIsIF9fRmRvR2V0TmFtZShGZG8p KTsNCj4gICAgICAgICAgIFN0YXRlIHw9IFBOUF9ERVZJQ0VfTk9UX0RJU0FCTEVBQkxFOw0KPiAg ICAgICB9DQo+ICAgDQo+IA0KDQoNCg== From win-pv-devel-bounces@lists.xenproject.org Tue Jul 13 08:25:13 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 13 Jul 2021 08:25:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.155135.286495 (Exim 4.92) (envelope-from ) id 1m3Dj6-0001mD-Ji; Tue, 13 Jul 2021 08:25:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 155135.286495; Tue, 13 Jul 2021 08:25:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3Dj6-0001m6-Gi; Tue, 13 Jul 2021 08:25:12 +0000 Received: by outflank-mailman (input) for mailman id 155135; Tue, 13 Jul 2021 08:25:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3Dj4-0001m0-HT for win-pv-devel@lists.xenproject.org; Tue, 13 Jul 2021 08:25:10 +0000 Received: from smtp-fw-9103.amazon.com (unknown [207.171.188.200]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 10da8943-b838-48e5-b49f-afd6dbea33f2; Tue, 13 Jul 2021 08:25:09 +0000 (UTC) Received: from pdx4-co-svc-p1-lb2-vlan2.amazon.com (HELO email-inbound-relay-2b-4e24fd92.us-west-2.amazon.com) ([10.25.36.210]) by smtp-border-fw-9103.sea19.amazon.com with ESMTP; 13 Jul 2021 08:24:50 +0000 Received: from EX13D32EUC002.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-2b-4e24fd92.us-west-2.amazon.com (Postfix) with ESMTPS id BC6C4A1DCD; Tue, 13 Jul 2021 08:24:49 +0000 (UTC) Received: from EX13D32EUC003.ant.amazon.com (10.43.164.24) by EX13D32EUC002.ant.amazon.com (10.43.164.94) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 13 Jul 2021 08:24:48 +0000 Received: from EX13D32EUC003.ant.amazon.com ([10.43.164.24]) by EX13D32EUC003.ant.amazon.com ([10.43.164.24]) with mapi id 15.00.1497.018; Tue, 13 Jul 2021 08:24:48 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 10da8943-b838-48e5-b49f-afd6dbea33f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.co.uk; i=@amazon.co.uk; q=dns/txt; s=amazon201209; t=1626164709; x=1657700709; h=from:to:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version:subject; bh=UsK98ohsJo2cqDFD4AEmQWbWrxYLKR6+xaqiwt6Wrok=; b=VzG7PN5Iuoy+CCfQzE/dh+8mSmRazxQsThmaw4ocQYVtIYwnhjzxl2g5 Kh52zE2sxf73p4FG5Z0nNSV5DNyiqLVyYX3+lXd2aKdjV3LssSfr7ZumO vnWousPJE9O9wg2Dx1Lik4i/Cfyct1/HCODZW2T2vsAtDzzmQovcZwOGV Q=; X-IronPort-AV: E=Sophos;i="5.84,236,1620691200"; d="scan'208";a="943249238" Subject: RE: [PATCH] Add log to Xenfilt DriverAddDevice Thread-Topic: [PATCH] Add log to Xenfilt DriverAddDevice From: "Durrant, Paul" To: Owen Smith , "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Thread-Index: AQHXcw3mK8mWRvA240W5ZIKUfvNi9as/u8YAgADZugCAAAUaQA== Date: Tue, 13 Jul 2021 08:24:48 +0000 Message-ID: <1e4d1657ba1847fcbe1d488cece12bb0@EX13D32EUC003.ant.amazon.com> References: <20210707085456.1826-1-Martin.Harvey@citrix.com> <20210707085456.1826-2-Martin.Harvey@citrix.com> <60fcc419-10ee-e02a-b235-1d6c8c5d1d25@xen.org> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.165.145] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiB3aW4tcHYtZGV2ZWwgPHdpbi1w di1kZXZlbC1ib3VuY2VzQGxpc3RzLnhlbnByb2plY3Qub3JnPiBPbiBCZWhhbGYgT2YgT3dlbiBT bWl0aA0KPiBTZW50OiAxMyBKdWx5IDIwMjEgMDk6MDUNCj4gVG86IHBhdWxAeGVuLm9yZzsgd2lu LXB2LWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IFN1YmplY3Q6IFJFOiBbRVhURVJOQUxd IFtQQVRDSF0gQWRkIGxvZyB0byBYZW5maWx0IERyaXZlckFkZERldmljZQ0KPiANCj4gQ0FVVElP TjogVGhpcyBlbWFpbCBvcmlnaW5hdGVkIGZyb20gb3V0c2lkZSBvZiB0aGUgb3JnYW5pemF0aW9u LiBEbyBub3QgY2xpY2sgbGlua3Mgb3Igb3Blbg0KPiBhdHRhY2htZW50cyB1bmxlc3MgeW91IGNh biBjb25maXJtIHRoZSBzZW5kZXIgYW5kIGtub3cgdGhlIGNvbnRlbnQgaXMgc2FmZS4NCj4gDQo+ IA0KPiANCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogd2luLXB2LWRldmVs IDx3aW4tcHYtZGV2ZWwtYm91bmNlc0BsaXN0cy54ZW5wcm9qZWN0Lm9yZz4gT24gQmVoYWxmIE9m IFBhdWwgRHVycmFudA0KPiBTZW50OiBNb25kYXksIEp1bHkgMTIsIDIwMjEgODowNiBQTQ0KPiBU bzogd2luLXB2LWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFU Q0hdIEFkZCBsb2cgdG8gWGVuZmlsdCBEcml2ZXJBZGREZXZpY2UNCj4gDQo+IFtDQVVUSU9OIC0g RVhURVJOQUwgRU1BSUxdIERPIE5PVCByZXBseSwgY2xpY2sgbGlua3MsIG9yIG9wZW4gYXR0YWNo bWVudHMgdW5sZXNzIHlvdSBoYXZlIHZlcmlmaWVkIHRoZQ0KPiBzZW5kZXIgYW5kIGtub3cgdGhl IGNvbnRlbnQgaXMgc2FmZS4NCj4gDQo+IE9uIDA3LzA3LzIwMjEgMDk6NTQsIE1hcnRpbiBIYXJ2 ZXkgd3JvdGU6DQo+ID4gRnJvbTogT3dlbiBTbWl0aCA8b3dlbi5zbWl0aEBjaXRyaXguY29tPg0K PiA+DQo+ID4gTG9nIGFsbCBjYWxscyB0byBEcml2ZXJBZGREZXZpY2UsIGFuZCB0aGUgdHlwZSBv ZiB0aGUgZGV2aWNlIGlmDQo+ID4gcG9zc2libGUNCj4gDQo+IEFueSBwYXJ0aWN1bGFyIHJlYXNv biBleGlzdGVudCBsb2dnaW5nIGlzIGluc3VmZmljaWVudD8gSSB0aGluayB3ZSBuZWVkIG1vcmUg anVzdGlmaWNhdGlvbiBoZXJlLg0KPiANCj4gICAgUGF1bA0KPiANCj4gDQo+IFRoZXJlIGhhdmUg YmVlbiBjYXNlcyB3aGVyZSBYZW5GaWx0IGxvYWRzIG9uIGEgZGV2aWNlIG5vZGUgdGhhdCBkb2Vz buKAmXQgbWF0Y2ggYQ0KPiBYRU5GSUxUX0VNVUxBVEVEX09CSkVDVF9UWVBFIG9yIERyaXZlclF1 ZXJ5SWQgZmFpbHMsIGFuZCAob24gYSByZWxlYXNlIGJ1aWxkKSBub3RoaW5nIGdldHMgZGlzcGxh eWVkLg0KPiBUaGlzIGlzIG1vc3RseSBkZWJ1ZyBvdXRwdXQgYW5kIG1heSBiZSBleGNlc3NpdmUg Zm9yIHN0YW5kYXJkIHVzZQ0KPiANCg0KQSBEcml2ZXJRdWVyeUlkIGZhaWx1cmUgbWF5IHdlbGwg YmUgd29ydGggYSBtZXNzYWdlIGlmIGl0IGlzIG5vdCBhIHJvdXRpbmUgZmFpbHVyZS4gRG8geW91 IGtub3cgaG93IG9mdGVuIGl0IGlzIHNlZW4gaW4gcHJhY3RpY2U/DQoNCiAgUGF1bA0KDQoNCj4g T3dlbg0KPiANCj4gPg0KPiA+IFNpZ25lZC1vZmYtYnk6IE93ZW4gU21pdGggPG93ZW4uc21pdGhA Y2l0cml4LmNvbT4NCj4gPiAtLS0NCj4gPiAgIHNyYy94ZW5maWx0L2RyaXZlci5jIHwgMTcgKysr KysrKysrKysrKysrKysNCj4gPiAgIDEgZmlsZSBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspDQo+ ID4NCj4gPiBkaWZmIC0tZ2l0IGEvc3JjL3hlbmZpbHQvZHJpdmVyLmMgYi9zcmMveGVuZmlsdC9k cml2ZXIuYyBpbmRleA0KPiA+IDhmMTRlYzguLjJjOWI1NGUgMTAwNjQ0DQo+ID4gLS0tIGEvc3Jj L3hlbmZpbHQvZHJpdmVyLmMNCj4gPiArKysgYi9zcmMveGVuZmlsdC9kcml2ZXIuYw0KPiA+IEBA IC03MjQsNiArNzI0LDE5IEBAIGZhaWwxOg0KPiA+ICAgICAgIHJldHVybiBzdGF0dXM7DQo+ID4g ICB9DQo+ID4NCj4gPiArc3RhdGljIEZPUkNFSU5MSU5FIFBDSEFSDQo+ID4gK19fRW11bGF0ZWRU eXBlTmFtZSgNCj4gPiArICAgIElOICBYRU5GSUxUX0VNVUxBVEVEX09CSkVDVF9UWVBFICAgIFR5 cGUNCj4gPiArICAgICkNCj4gPiArew0KPiA+ICsgICAgc3dpdGNoIChUeXBlKSB7DQo+ID4gKyAg ICBjYXNlIFhFTkZJTFRfRU1VTEFURURfT0JKRUNUX1RZUEVfVU5LTk9XTjogIHJldHVybiAiVU5L Tk9XTiI7DQo+ID4gKyAgICBjYXNlIFhFTkZJTFRfRU1VTEFURURfT0JKRUNUX1RZUEVfUENJOiAg ICAgIHJldHVybiAiUENJIjsNCj4gPiArICAgIGNhc2UgWEVORklMVF9FTVVMQVRFRF9PQkpFQ1Rf VFlQRV9JREU6ICAgICAgcmV0dXJuICJJREUiOw0KPiA+ICsgICAgZGVmYXVsdDogICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gIkludmFsaWRUeXBlIjsNCj4gPiArICAg IH0NCj4gPiArfQ0KPiA+ICsNCj4gPiAgIHN0YXRpYyBYRU5GSUxUX0VNVUxBVEVEX09CSkVDVF9U WVBFDQo+ID4gICBEcml2ZXJHZXRFbXVsYXRlZFR5cGUoDQo+ID4gICAgICAgSU4gIFBDSEFSICAg ICAgICAgICAgICAgICAgICAgICBJZA0KPiA+IEBAIC04MDUsNiArODE4LDEwIEBAIERyaXZlckFk ZERldmljZSgNCj4gPiAgICAgICAgICAgfQ0KPiA+ICAgICAgIH0NCj4gPg0KPiA+ICsgICAgSW5m bygiJXAgJXNcbiIsDQo+ID4gKyAgICAgICAgIFBoeXNpY2FsRGV2aWNlT2JqZWN0LA0KPiA+ICsg ICAgICAgICBfX0VtdWxhdGVkVHlwZU5hbWUoVHlwZSkpOw0KPiA+ICsNCj4gPiAgICAgICBzdGF0 dXMgPSBTVEFUVVNfU1VDQ0VTUzsNCj4gPiAgICAgICBpZiAoVHlwZSA9PSBYRU5GSUxUX0VNVUxB VEVEX09CSkVDVF9UWVBFX1VOS05PV04pDQo+ID4gICAgICAgICAgIGdvdG8gZG9uZTsNCj4gPg0K PiANCg0K From win-pv-devel-bounces@lists.xenproject.org Tue Jul 13 08:25:55 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 13 Jul 2021 08:25:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.155139.286500 (Exim 4.92) (envelope-from ) id 1m3Djn-0001vN-Ne; Tue, 13 Jul 2021 08:25:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 155139.286500; Tue, 13 Jul 2021 08:25:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3Djn-0001vF-K3; Tue, 13 Jul 2021 08:25:55 +0000 Received: by outflank-mailman (input) for mailman id 155139; Tue, 13 Jul 2021 08:25:54 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3Djm-0001v9-9r for win-pv-devel@lists.xenproject.org; Tue, 13 Jul 2021 08:25:54 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ef9ea2e0-e3b3-11eb-872a-12813bfff9fa; Tue, 13 Jul 2021 08:25:53 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: ef9ea2e0-e3b3-11eb-872a-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626164753; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=+Z3ehxAg8/Va5uCBkwHVEaxkKhsmQNDeQkqDiCp4b8g=; b=Gsf4GpvVIUz59zPEpBCyuOWiKqZxe86wNt+h5aOCuIsU27tii8fRoBiB 7eRk8tbMTQ0TWvDbr3uSFXhv89mHOUysYJfDqmGLni6wrcaZ65BcTuxZ0 UgTj6x/tkJSwa3sOn41R70642MKs/fPVNAwjX9uoW4WgaWZfruMnq8/sk M=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 1egGcXfEZ22MdCvAu2b5u1Stuyau5STfJ6m6NEwwNkkombvE4dF0k3Pl2ZoagA9Timbnz3Yiem BaxwLsCm5zaZa/cAn/Gqby7dp+0f72MN9sEajUQGja0HeY3UrxcO2dd3ePRkdhB//mXZSaWzNj PLL409s5nqRX41QSbA4x4mE0c5ZxcbO3lkcBT66XTisje4kNwk5QQ32ZMRZxUPiOaiHCJQ4pCW nVBZRBH9vBq+E9E+tbnh7BqhEEKAWJPLi5JzLaEu8dTO0hj3HPjK9C+Nh+jXAe8CeB01mSHFMu bn4= X-SBRS: 5.1 X-MesageID: 47832992 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:ml26UaDs7qvpyP7lHeg5sceALOsnbusQ8zAXPh9KJyC9I/b2qy nxppgmPEfP+UsssQIb6Ky90c67MDzhHP9OkMUs1NKZPTUO11HYVb2KgbGSoQEIXheOjNK1tp 0QPZSWaueAdWSS5PySiGLTfrZQo+VvsprY/ts2p00dFT2CAJsQizuRfzzrdHGeMzM2YqbReq Dsg/Zvln6FQzA6f867Dn4KU6zovNvQjq/rZhYAGloO9BSOpSnA0s+6LzGomjMlFx9fy7Yr9m bI1ybj4L+4jv29whjAk0fO8pVtnsf7wNcrPr3NtiFVEESutu+bXvUlZ1SwhkFwnAhp0idsrD D4mWZjAy200QKWQoj6m2q15+Cq6kdQ15ar8y7nvZKkm72jeNtyMbsxuatJNhTe8EYup9d6ze ZC2H+YrYNeCVfakD36/MWgbWAjqqOYmwtVrQcotQ0XbWLeUs4lkaUPuEdOVJsQFiPz744qVO FoEcHH/f5TNVeXdWrQsGVjyMGlGi1bJGbNfmES/siOlzRGlnFwyEUVgMQZg3cb7Zo4D51J/f 7NPKhknKxHCsUWcaV+DuEcRtbfMB2HffsNChPkHb3DLtBLB5vgke+F3FwF3pDfRHVT9upDpH 3oaiIriVIP X-IronPort-AV: E=Sophos;i="5.84,236,1620705600"; d="scan'208";a="47832992" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EeBNBCJGiyiWmzZubc+dt47EtRYKDT5O0MJl2LzzV95MDfeXslQG5BlKrLnTQbocEzKiT/41fIQXdElVVCZo/u7Umt2NiBJGVAUC1rey/rvF0BSVcEVMBAfMmT3zbRLYQ/l7EcP57teiuEDXUxsP9+JQ1jxikJIPLMFe30nXotcMC+2tKjgh0OdhS0bfOvUZdb4JmVUfnSkPqj/lIFWS0/HvrgrnW5DaOE5qS6plqMqSC37fBbuctilM52ajSBJk0NdA+FDzfyeIa6UakjkdEvEqH+zgD/wvZ5T28robFYB2zo+iPxnsY+OA7Zxnk6g1VZ82jS/KRZaottFZ1CNdRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+Z3ehxAg8/Va5uCBkwHVEaxkKhsmQNDeQkqDiCp4b8g=; b=bytBKxPB+gqB+OHB+G21H7ypHIZhoJ3G1ookgm0z3d0wBOCez+z0gqqrsJfQjZlmzd5WpcaE+6VwYOYfrk7ZHm52Nk96ZWZTvQqJaZYQ1SC4ZXoZ3bn1ozHPg99VRD776xbSI+A5BfaXh+woZutYycP/Q9MudBpZykd1ZQHCh1qmrx0c5VBofEBCmAnCLzdNp9KgND0w+wFmC8F6aoj3TejNJAMNEwrUuO++JXBrAz5EH6tKQzL/o+VhBTfrZQjK/gXkQ9W3rhevnv6KQkUTM6v0DwVnVDQElqK7pRzynUai0fFfVw19x8jxqI+l32k6kgV8Xdk1jIi60klnCpplhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+Z3ehxAg8/Va5uCBkwHVEaxkKhsmQNDeQkqDiCp4b8g=; b=mLZ2nQ32/589mfHw5qzkacvj7YLMeRVrcSoS3IMNSkroh3/TnkRnrGwt2IyKKxll+wexb0cDrahUmjYDuzJCL6q2TMm0059m3nzZ+D5f3EOD87HcBN6kcINPHLPAm8YrTjM3Wg4BKFduci9H5FN9KSJK0uWSNkI1+Ch0tnmHYwQ= From: Martin Harvey To: "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Subject: RE: [PATCH] Add log to Xenfilt DriverAddDevice Thread-Topic: [PATCH] Add log to Xenfilt DriverAddDevice Thread-Index: AQHXcw8lO0GbhNNyjkas71fAJtHqXKs/u8QAgADdFTA= Date: Tue, 13 Jul 2021 08:25:47 +0000 Message-ID: References: <20210707085456.1826-1-Martin.Harvey@citrix.com> <20210707085456.1826-2-Martin.Harvey@citrix.com> <60fcc419-10ee-e02a-b235-1d6c8c5d1d25@xen.org> In-Reply-To: <60fcc419-10ee-e02a-b235-1d6c8c5d1d25@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bbca1506-1aed-48f1-a6e4-08d945d7d0d5 x-ms-traffictypediagnostic: CO2PR03MB2149: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cy8WBWVAqTW0Bwb4AjtVoPegNlt8oLCUhNZYjyU4QsYrICHTwdFmTXApjO8LtmJii9MBEFS5mXlIg7ielyYcynVQ3q53pco/jYqzVgs6RUjG0fYF6+pZbmeApAiHhAhAdsBtSrQZ/7qZjeq42ABjcD01E8DZDwZzoQUwNg3iZ/aLReJOQWbWNXF+u7oP4GYVLHY2de4K8lr8vRviE2+QihU3YcAJoXUAiCT7nugaTKkayv5/J7bukuH12tEfcPoSJqBcxH/Upv9joURWWn3XeBBs3O0XEVmMgx7awxxgz6xTUHXpGRgKHTjV+koz8CVNtVQutZlU4Zz8FYPzJRCLcYrEhNueUTeLktiCg5pbHW6Viz7Ecu+d4THNdb+LTvWmc1EmuJLKfe5SnWDGu9j6xBZDkG4/hPfuRDilt2idWAf8KY7IIaLx6aLMloQZ6zTWcG5lNv42UgDsJnixuO+ZZH4A6rPgQFkAtW00jGZy5iP4qTbBCQRHo1t3Lh7tfrGsAxDgieAimGCc9Ay6EoQ/9GX6DjBjdJ0WJcffBOomxlqPRk6W4i62F8Bg4X4qyCX2je9Adhwj8o3eTiaboGy21oUt+Fu8jHkuSw+EJSq+MX9Osa+j1+vZLC2VbQfFRrlbZUefRxf6u3ODoGQKziNf6g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6347.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(346002)(136003)(396003)(376002)(39850400004)(5660300002)(186003)(110136005)(55016002)(7696005)(8676002)(6506007)(66946007)(52536014)(64756008)(44832011)(66476007)(316002)(53546011)(26005)(66446008)(478600001)(76116006)(8936002)(66556008)(33656002)(122000001)(83380400001)(2906002)(9686003)(86362001)(71200400001)(38100700002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MjJvQ010RTlmZnBjd3VqK2ZRc3NoaTkxbWx2TDVpT2VmRXo2UGl5OGhONks0?= =?utf-8?B?VTB4alhkb0QrMlNucWd0L3VldTVabWZRemhvck9aVy9IWVNOK1VTeDdyK1hi?= =?utf-8?B?UzBxWlZZc21HYXR5a2pUU0ozUllMR2s2bGY1c2dsUmVqb0h2MlIrakRwN2R0?= =?utf-8?B?NnJrbGdDY2IxZW9hc0pleUZjcEs1M2ZoTnFjOGUwK1BVbUp1cHdCaVBaVXpS?= =?utf-8?B?TUFvd1RzWDBEdHRDNm5DZVZOVlRPTDJRWmw4a2JuOXpjYzhtNDZiVUxLMm1i?= =?utf-8?B?Q2tPM00vTEJNQ3FlT29tbG56WTZOVERLS3o4bjBrcVl1TWdnM2h0Zk5LYjdW?= =?utf-8?B?d2Uxa2p1TXZPazN6WGlXSmRBWXNjbGo3aG1KZTJObEc4MEtvb1ZINlFteVNH?= =?utf-8?B?Q2FLUVcreEo1R25YM0t6b1c3L01oUGVOajFiMU85R01vRktHL1Z5MVVpWEYv?= =?utf-8?B?dTY2d1lBdVRHME42S284SU5QbDZ0SVl2SlNMeklsalc3Skd5aDNQMDVNakRH?= =?utf-8?B?dG1WVWxuMENJeS9MV2tjTGJ6VGowR1RSRlMvRXlpQ3dwQzcyWitjNW0zb3lY?= =?utf-8?B?Yk1GbWlXS2VoQnl3R2hrNFlRZDZrb0JKSS85MkNTSDlYQjR0SXdEU3ZySHIz?= =?utf-8?B?dzRPdkp2L1psMmwrWjI3dmdZWitEWDlLd3B5d3FPWDdkRGZVVUJXdFF6c3NN?= =?utf-8?B?eEJLRjJ3c2VoMi9aNEZjbkJaQ1hCS2ZNUEVBSkRhc3FZSkJ4bDRKeDhhYjhS?= =?utf-8?B?UG1wWWJnWGR6dVUvd3dXUjRDZVJQbXlFLzBxTSsyRDdIVEdXUnZGcXFrMy9F?= =?utf-8?B?SVNwVUFlM204YkdVYlQwb1NtZmdmT3ZNYk4xRERuMHRPYmZOd00way9kN1pu?= =?utf-8?B?ZCtkQXl6Y1J3TzhXRFg5MTlmU2FVQzNoL0dqUTNnU1R4cnAwaUJncXJoQWhj?= =?utf-8?B?Z1hscHZQeGNPNDl3N3BQUHpiNHA4VjZRWC9vTVVGeUhkNkNaTGV5TnptNHJy?= =?utf-8?B?N0ZxMUpMUEdiVjVrSTJSN09RRFF3VU9FYlhwRzNiaFdqTGlCbnNWUHBlMmg0?= =?utf-8?B?c2JBUWVuYVFFRVFQWU15TVJXNTRzbEQrbnJZS1AvOExJT3FQcnhPU01NRnBu?= =?utf-8?B?YUZxcEZCbkxUTVcrcTNvZDVORy96djRqZWtQRERjK0R4NWdLR0tHeEs3c2px?= =?utf-8?B?d3pGWStFMWl2SUQxbkZpeTRKSkRmblpBaElvZWJkTk9adHFINFo2TmlGRVlL?= =?utf-8?B?dmVQQVVQeUpkazFPSGNPUm03elQvZ09kUlUwSWgwYmZZbUpORmFZYk41OWJL?= =?utf-8?B?L3pHRWJYd0R3UXFTb2g4M1JyV25LNlZsRTlONlNKTVkxejZoUXMyZWRhQTZt?= =?utf-8?B?cTFpYmd3MnFuelV4eVU0OW9yUXNEd2NwQ1RwdXFzWkg2dEc2TnhnMWZCYll4?= =?utf-8?B?MVMzZlE4d3ZCMzMvNEpabkJCM3NlV2IwR1JueFpyM1hxTGZ2TXNMQzUyOHIy?= =?utf-8?B?dDZnczFoU0dhVDZaYkYxdVZPNXdsWXVHeGlhYmNZd0oxM010VTZRNjhnR1gy?= =?utf-8?B?cjkvUXNjdWxua3FNaUQ2NGdMZ0UzdWZGa1ZaMzVlMnhQWmJuc0lOVXlVR20x?= =?utf-8?B?MHRGczRuQlBYS0tlcEowUXhoc1NIYU9zZ2V4ZVJmVWV3RFIzR2N1YXpXU3hT?= =?utf-8?B?ajdNcEQxc0Myb1pnZUhTRks4U1BONk1RSTdSRnJ2czY1STlRbThZVTd2SGtI?= =?utf-8?Q?bdaf8CQrn9trAaYeIDKA2RF5Zmg8dRw23M3RMiW?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6347.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bbca1506-1aed-48f1-a6e4-08d945d7d0d5 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2021 08:25:47.2638 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: im0GzHTV5QvtlThTsxE7GPV5iTKXeOdjh3QhO1Osr5wn+XK7msMPijuKkpI2pKPNj40VWsPrkJB+cvqBwjUcObjcFpLpLXknboF92cov3is= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR03MB2149 X-OriginatorOrg: citrix.com WWVzLCB3ZSBkZWZpbml0ZWx5IG5lZWQgdG8gbG9nIGFsbCBmaWx0ZXIgQWRkRGV2aWNlIGNhbGxz LiBIZXJlJ3Mgd2h5Og0KDQpDdXQgYSBsb25nIHN0b3J5IHNob3J0LCB0aGUgY3VzdG9tZXIgbGlr ZXMgdG8gZG8gYWxsIHRoZSB0aGluZ3MgdG8gYSBWTSB3aGljaCB0aGV5IG5vcm1hbGx5IGxpa2Ug dG8gZG8gdG8gd2luZG93cyBtYWNoaW5lcy4gVGhpcyBpbmNsdWRlcyB1cGdyYWRpbmcgd2luZG93 cyBlZGl0aW9ucyB2aWEgd2luZG93cyB1cGRhdGUgb24gV2luMTAsIGFuZCBhbHNvIGluIHNvbWUg Y2FzZXMsIG1vdW50aW5nIHRoZSBJU08gZm9yIGEgbmV3ZXIgd2luZG93cyBzZXJ2ZXIgdmVyc2lv biwgYW5kIHVwZ3JhZGluZyB0aGUgdmVyc2lvbiBvZiB3aW5kb3dzIHNlcnZlci4NCg0KVGhlc2Ug dXBncmFkZSBjYXNlcyBkbyBzb21lIGRyaXZlciBtaWdyYXRpb24gc3RlcHMsIHdoaWNoIG9mdGVu IChidXQgbm90IGFsd2F5cykgd29yayBwZXJmZWN0bHkuIFVuZm9ydHVuYXRlbHksIHdlJ3ZlIHNl ZW4gY2FzZXMgd2hlcmUgY2xhc3MgVXBwZXJGaWx0ZXIgcmVnaXN0cnkga2V5cyBnbyBtaXNzaW5n IC8gZG9uJ3Qgd29yaywgc3VjaCB0aGF0IFhlbkZpbHQgbm8gbG9uZ2VyIGJpbmRzIHRvIEFDUEkv UE5QMEEwMyAoUENJQnVzIGlmIG1lbW9yeSBzZXJ2ZXMpLg0KDQpJZiBYZW5GaWx0IGNhbid0IGZp bHRlciB0aGUgYXBwcm9wcmlhdGUgZGV2aWNlcywgKipFdmVyeXRoaW5nKiogYnJlYWtzIC0gcGFy dGljdWxhcmx5LCBQbHVnL1VucGx1ZyBkb2Vzbid0IHdvcmsgcmlnaHQsIGFuZCB0aGUgbWFjaGlu ZSBjb250aW51YWxseSBwcm9tcHRzIGZvciByZWJvb3QuIEkgY2FuIGdvIGJhY2sgdGhydSBjYXNl IHJlcG9ydHMgYW5kIGdpdmUgbW9yZSBkZXRhaWxzIGlmIHJlcXVpcmVkLiANCg0KVHJhY2tpbmcg dGhpcyBkb3duIGFzIHRoZSBuZXdiaWUgYmFjayBpbiBlYXJseSAyMDIwIHRvb2sgKip3ZWVrcyoq LCB3aGVyZSBpdCBjb3VsZCBoYXZlIHRha2VuIGEgZGF5IG9yIHNvLiBUaGF0IGRlYnVnIHByaW50 IHdvdWxkIG1ha2UgZGVidWdnaW5nIHNpbWlsYXIgY2FzZXMgdmVyeSBtdWNoIGVhc2llciwgYW5k IGl0J3MgYSBwcm9ibGVtIHdlJ3JlIGxpa2VseSB0byBydW4gaW50byBhZ2Fpbi4NCg0KUGxlYXNl IGluY2x1ZGUgdGhlIGRlYnVnIHByaW50IGZvciBkZXZlbG9wZXJzIHNhbml0eS4NCg0KTUguDQoN Cg0KLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCkZyb206IHdpbi1wdi1kZXZlbCA8d2luLXB2 LWRldmVsLWJvdW5jZXNAbGlzdHMueGVucHJvamVjdC5vcmc+IE9uIEJlaGFsZiBPZiBQYXVsIER1 cnJhbnQNClNlbnQ6IDEyIEp1bHkgMjAyMSAyMDowNg0KVG86IHdpbi1wdi1kZXZlbEBsaXN0cy54 ZW5wcm9qZWN0Lm9yZw0KU3ViamVjdDogUmU6IFtQQVRDSF0gQWRkIGxvZyB0byBYZW5maWx0IERy aXZlckFkZERldmljZQ0KDQo+IExvZyBhbGwgY2FsbHMgdG8gRHJpdmVyQWRkRGV2aWNlLCBhbmQg dGhlIHR5cGUgb2YgdGhlIGRldmljZSBpZiANCj4gcG9zc2libGUNCg0KQW55IHBhcnRpY3VsYXIg cmVhc29uIGV4aXN0ZW50IGxvZ2dpbmcgaXMgaW5zdWZmaWNpZW50PyBJIHRoaW5rIHdlIG5lZWQg bW9yZSBqdXN0aWZpY2F0aW9uIGhlcmUuDQoNCg0K From win-pv-devel-bounces@lists.xenproject.org Tue Jul 13 08:35:26 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 13 Jul 2021 08:35:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.155149.286503 (Exim 4.92) (envelope-from ) id 1m3Dsz-0002p7-F8; Tue, 13 Jul 2021 08:35:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 155149.286503; Tue, 13 Jul 2021 08:35:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3Dsz-0002p0-CC; Tue, 13 Jul 2021 08:35:25 +0000 Received: by outflank-mailman (input) for mailman id 155149; Tue, 13 Jul 2021 08:35:24 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3Dsy-0002ou-06 for win-pv-devel@lists.xenproject.org; Tue, 13 Jul 2021 08:35:24 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6883d69d-4a3f-4d78-848d-19a79d810b0f; Tue, 13 Jul 2021 08:35:22 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 6883d69d-4a3f-4d78-848d-19a79d810b0f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626165322; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=RNIJ+0Db1xGLHpm1+QoH/TuDVjKU3CmC68cTZQhhAD0=; b=Z9yzyxCymwr2a3NF3z0l5pjDYi7e2iNGba3aV7qlR2YW8dlS+LWqtgat 9UFOPiNbNGK4FNRbAJ9Tmr68yWQX5FiV9EAHmwmhIwv2CVn4K0rkZOhvp WE1JYGW1unrYlXif14KuXlreTbmyMxEW84iegmGBd4s1xHXTDj6v8moJe g=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: aaHfQtMhU4hsiNmoe6FZd8PI7k+N+zpfksjYAmL9FgtHzp4feUJT0fEWeSLmnq4hbe2PT009iK p9S79guwTFn2tj3EyD0IvPMx3iuaxNCb32R5QhHHpPN7cS2cWE0yskEJ1JoUUOommozQyLs620 lD4HjfVgpMC2g1sqB8Minkqt4O2ndoUCtWZF+oGUIV9yxFQy6KfiB6lpHO7usqBlhntFn22IFe Cze/0AYMgOmnXJ29ZLMczJZGQ3bvpN835weCN6ZiQKeQFaRP7E9O0I2ZW+/A3HghAKIGJK8qng 8Wc= X-SBRS: 5.1 X-MesageID: 48516276 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:IcqF56rMyYCjoLBOYy+SqroaV5rReYIsimQD101hICG9Evb0qy lhppQmPH7P+VIssRQb8+xoV5PufZqxz/BICOoqTNKftWvdyQiVxehZhOOP/9SJIUbDH4VmpM VdmsZFaeEZDTJB/LvHCAvTKadd/DFQmprY+ts3zB1WPH9Xg7kL1XYfNu4CeHcGPzWvA/ACZf yhz/sCnRWMU1INYP+2A3EUNtKz3eEixPrdEGc77wdM0nj3sQ+V X-IronPort-AV: E=Sophos;i="5.84,236,1620705600"; d="scan'208";a="48516276" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AtIhwrHx9Z4skQGwnsYt5Vh2FcnprQeUtiwLRsSb+Cxv7B4QVHkOPCQ4s9Qwzz8v8DBzcxsUkvJt6eoZFjrksIe9uoRQMGqd5JzlzURCwMJ215yZJsdaQ3cp3OeivIYba+Fg1ElJvQedf+MdPJPfoQYe7mRJLRID2UieffYk25ILJdWoRV9/wEfkMtnG/qC6XdU1TXQVNL/OQGBQgix8BcodaEpiZs2kKHV00ho+CzXb6U4/MNRaMf8JMYE8y2YOCRP8vJvOlH5JEyGgbTprTwrz7p8MqUfZ/PHXYXerqeOMY17mAwni9qg5an+Llmh8pcqtIcvSb8l9F6X+zQcrUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RNIJ+0Db1xGLHpm1+QoH/TuDVjKU3CmC68cTZQhhAD0=; b=dC1IEsojrjkUocrN/aqPdKPn6xntlWy9dVsq6TpaJygu3uhTkna9wFRgX3PrFsTXEYy+hCmqe0Spu629I4rz7DS2LTUdb9QqVqOKE2VnBmEoi/o6wiu62UqM3tqkrzB2TzY23X9r6MrYckJfskZQgCeAL11uPeyfpZvOefw/5p5KCWcAWWVQ2sH1L130R1ek1WbM7dShAFCUjqToUBp2rAxiOqBh+LkwmMDrXJR5gixQtUm8W7F0u8zYLW4lf+wQBr0H7f6jCMjA+oU38tYzIa/5Ve34/NSrb/oLnyEJ2OyWvbmZsEhG+k2Fm7dXDN5EsZC8ebdlaJAaamefr/7Qjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RNIJ+0Db1xGLHpm1+QoH/TuDVjKU3CmC68cTZQhhAD0=; b=BiH/bPnEhlDEZ5lI3Ygl2QBCEjQ7tYBB5yd/oK6t9zBHb1kMrpi7bZckAawFFO/lJcQSvaRYpaDhaN4rd5LKeau1GHOtwB5vxYMCKeDRH9ELUO55hi3+XtBUby9wKpVgpiP0yL3oiOxACEMSlVLfZ1ugO8r+RyN+jbxX3pwQq3s= From: Martin Harvey To: "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Subject: RE: [PATCH] Log module loading Thread-Topic: [PATCH] Log module loading Thread-Index: AQHXcw2/Knojojq7r0i0Tdd3ept0D6s/uiSAgADjCiA= Date: Tue, 13 Jul 2021 08:35:15 +0000 Message-ID: References: <20210707085456.1826-1-Martin.Harvey@citrix.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3ff81e89-edca-447b-9139-08d945d92547 x-ms-traffictypediagnostic: MW4PR03MB6329: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LmKJkNlUrgAv3YZ4ZePpNf5ffeFkMvamv35tvssO4lOPY9kcH408n77tJ/Cq4M164CuB5utXefsocTERJMD2NdBEI5mWNQXqnanYcOcw8JGUaGx/Givwb9TgcFj8UUJ4G1si2NizsC+1MZiUDgSw2TFV8Lucj1vHnJqpGTzDb3bLbfTjnpBeHwq/EUhkN782CyOwgbzaZm0UJYOgOErLO6gSurG3ywmLLq9ogtjae/Fe5zPbNCALUDXefTShXuk9DObU3L9FxFJ2KtatAlt2qLbrRiib0kDJBY0UYUY4WGwxSwejBOZ1chvPTv8Vc+5XnykCJJeZ5p3/7TrhxEEn2nerUUVIV4eAs0+79kWEnZJEw5FTzYv0tV2q81x9dXeY5lnFK0Ss3Teg0lXMpCeCBgpkKaSWvV7njCwq7lvQ0gCEq/Khc2SCe+tJhVQn9OGRzD0gcDxIVyW4rIh7NrK8X69dpMbUpR2WMOieJZBN8Piuju/33w22DAcc/2ziBAs7w/KuKDoMi5RUm/J46MJJmWl1GS3xQawcsMOBMsj4DUlcjYC4DPfZUqqZAKEFPMeo3U/q/cfsIAIRXgPXeEwQaZBi918VAux0pTS2DCbrSUtwmPXsnVR+AvXSaKGS02IFXQrRABnhnokUmR5yh+FKZA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6347.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(39860400002)(136003)(376002)(396003)(346002)(110136005)(186003)(5660300002)(9686003)(53546011)(7696005)(52536014)(26005)(316002)(83380400001)(478600001)(4744005)(8676002)(122000001)(6666004)(6506007)(71200400001)(8936002)(44832011)(86362001)(33656002)(2906002)(66476007)(66556008)(55016002)(76116006)(66946007)(38100700002)(66446008)(64756008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?QlBmN3FsK2RmVWNxeXNURkc3T0wyd0J2cmFmVm1nOG9veU1XZFlva1dQdm9G?= =?utf-8?B?QmVLWWRyMUlHdEpIMmJuVXA4cElxdTNXSldWWExFbE1PajB1bHE1VXg0VEcz?= =?utf-8?B?QTRRMnFCRTgvRzVhNzRJVTNEUHBsQTBCUWlxRzMvZXUxRjRyTWtiSG1SakxL?= =?utf-8?B?Z2hHVXJtMFlwUTM5eVJjMWJuVXE5TllEQm82TlJKZm9WdUJMOERlWmFHazBZ?= =?utf-8?B?R2M1TCszMDFWS0RYdzFUTlhSNXdURE83ZjFsWUU4YTg5Z1ZHYkx5blJMdXBt?= =?utf-8?B?QTRsVUhEOGpLOWdHMVk5endlMjJtQ0dFdkRTTC9OMTltWnNJVEpIWmE3M1FT?= =?utf-8?B?UHJHMnZSL05ENDd4RjRjVkRnaWZDZC9hK0kycWtXb1ZqMmNHNysxZkFXYXRG?= =?utf-8?B?RWUzdHUwRFdMMkdrdjA5bFREMHFsZERvZjBOeWI5clZVbUhSMTVrQWhmSkFD?= =?utf-8?B?TnJQL01YcDZ3aGh3NVBDaHpMMHVsN0VxVWF1K1NVeTMzUzRIbWJVa1ZxU2ZG?= =?utf-8?B?K1Y3L2NpWGJLZXB6UzVMV25SdTBJUkk0dCtmQWhvRHJzRW0vcFdGbmFPalRo?= =?utf-8?B?Mm50V2U4UlI5N1AzcUhOOEN5TTkzSDZ5RUFOMWFvczhML1FhUWh6SkdKcGNT?= =?utf-8?B?NzhoWkZsNkZhMSt6c2FUd0xqbFpMSVBCc3FnVkVBMHp5UEx0cGxrQ05nZ2dS?= =?utf-8?B?NVdiRlZaOUxkZVZWNnNmaUtEV3E2UVRSTTBxSnp5VmVheUJXSDk2QkVUSUl6?= =?utf-8?B?V2pQQ2w0MzVhZW4xTTl4RDg0T0VZL0ViNE1SMFNjZkpzTGxlcXlWMnBKYWF6?= =?utf-8?B?VWF4SnhrV1ZBdDEwRHFIdnl1RnpPNEEyeFNrS08yczNRUysyd2ZTbC92a0Fx?= =?utf-8?B?ckFJZ0Z1SGJBZE5Jdm5aMzl2Z29jMXkvZ2R2ejg2a251a3VTVGxxUFNwNjJC?= =?utf-8?B?VDhXRDdPL0dNcEtYV0x4T2RBOWJpaFhPRjB1RUtHUzJncUI5SXVRbGdTL1F6?= =?utf-8?B?aks5TnRDMkprb0sxU3IvQjJLc21TVDE3WnUzTTFVancxTUN4Tk5BR1djRlF3?= =?utf-8?B?Vml1SCtyS1dRbzFMUkFYREo5ZXNYN2RzTW45Z1B4UWdaVVVVOXdVZm9rV1Zp?= =?utf-8?B?azMvaTJUOVBnVmZiTEdlZnJ2bjQ3Y0NvTk5ZUlFhcHRxSTlHMzBtOEdRYjFR?= =?utf-8?B?VWdxemtSYVFkVkV3ZTlleW5yS1g3NU1jWDlVWWpScUFXS1JyU2pKL3V1Rmhi?= =?utf-8?B?bUNCblRkLzFEZzJWZGJzSE4wcVViVjNrTEdIaHorRlJOalJkVWlvOUI1ZzM5?= =?utf-8?B?djAyT0dDV0drUUlSQys4dzZIU2xDaXRlRE1sVE13NDJxZ2w3Z0cvMnF5dUUx?= =?utf-8?B?eThBSGd4eHFtNHZGYWpvVmx3ZzJTbDRZZUVNREV3TFRQZC9ZMmN3Z09MenFy?= =?utf-8?B?LzB5ZGh3VVdEeUhNd1VqcVdVdWozMkV1bnZ2MExjQVpDcVJhalhNbTJvc0N5?= =?utf-8?B?SE1PUHVuNWVHSFhMVHlPUkc5RjhKanZ5Ykh3MXBtQkVLVXp0bjFNNW1seENM?= =?utf-8?B?cEk2VFVvcDhhMFRUcGZocFAzRGlxUnJoZzJHZ08zc0cwRThsalBtUnhCVHhM?= =?utf-8?B?eERkV2lkUTdJTGl0aURubVJFK0dndXI3aDV1UmVCMlAxb2hsOFFBYmdCSWNI?= =?utf-8?B?S3hqakUvR3FOS2JwT2pPNUx4ckN6Y05vU1JhNHFLOWNMZEZicW02eHN3aGVp?= =?utf-8?Q?Qlt+m8kYebMhmM+lxbBJlL0KdHnaY+Uqly3p2vk?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6347.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3ff81e89-edca-447b-9139-08d945d92547 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2021 08:35:18.4078 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hzUpCFsOSdYcd6nxkpxMK7HieSYY/wkWjkDsrg7KJ73Z69I2ux6LQDO0H/WnQGWp6tQOpvQFv4UCny+j3UdZEXxwjytr0zcqgypBYeBZ9q4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6329 X-OriginatorOrg: citrix.com DQpPbiBhIHNpbWlsYXIgdmVpbiB0byBteSBwcmV2aW91cyBlLW1haWwsIHdoaWxzdCB0aGlzIHdv dWxkIHNlZW0gdG8gYmUgYSB0b3RhbGx5IG9idmlvdXMgdGhpbmcgdGhhdCBkb2Vzbid0IG5lZWQg bXVjaCBsb2dnaW5nLCB3aGVuIGl0IGNvbWVzIHRvIE9TIG1pZ3JhdGlvbiAvIHVwZ3JhZGUgc2Nl bmFyaW9zLCBhbmQgdGhlIHN5c3RlbSBib290aW5nIGluIFNBRkVCT09UIG1vZGUgZHVyaW5nIGFu IHVwZ3JhZGUsIEknZCBsb3ZlIHRvIGhhdmUgdGhpcyBsb2dnaW5nIGluIGJ5IGRlZmF1bHQgdG8g c2F2ZSBkZXZlbG9wZXJzIHNhbml0eS4NCg0KTUguDQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0t LS0tDQpGcm9tOiB3aW4tcHYtZGV2ZWwgPHdpbi1wdi1kZXZlbC1ib3VuY2VzQGxpc3RzLnhlbnBy b2plY3Qub3JnPiBPbiBCZWhhbGYgT2YgUGF1bCBEdXJyYW50DQpTZW50OiAxMiBKdWx5IDIwMjEg MjA6MDANClRvOiB3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcNClN1YmplY3Q6IFJl OiBbUEFUQ0hdIExvZyBtb2R1bGUgbG9hZGluZw0KDQpOb3QgbmVjZXNzYXJpbHkgc3VyZSB3ZSB3 YW50IHRvIGxvZyBhdCB0aGlzIGxldmVsIGluIHRoZSBnZW5lcmFsIGNhc2UuIEkgdGhpbmsgaXQg d291bGQgYmUgcmVhc29uYWJsZSBmb3IgdGhpcyB0byBiZSBhIGRlYnVnIGxvZyBsaW5lLg0KDQog ICBQYXVsDQoNCg== From win-pv-devel-bounces@lists.xenproject.org Tue Jul 13 08:39:15 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 13 Jul 2021 08:39:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.155160.286518 (Exim 4.92) (envelope-from ) id 1m3Dwh-0003bx-1H; Tue, 13 Jul 2021 08:39:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 155160.286518; Tue, 13 Jul 2021 08:39:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3Dwg-0003bq-UZ; Tue, 13 Jul 2021 08:39:14 +0000 Received: by outflank-mailman (input) for mailman id 155160; Tue, 13 Jul 2021 08:39:13 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3Dwf-0003be-72 for win-pv-devel@lists.xenproject.org; Tue, 13 Jul 2021 08:39:13 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id cbf0b0ac-e3b5-11eb-872d-12813bfff9fa; Tue, 13 Jul 2021 08:39:12 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: cbf0b0ac-e3b5-11eb-872d-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626165551; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=x8OuwpgkQgwL7qS3Nl+FPFUnymj6QsYs0vkAM6DZiCg=; b=TQjCXyjhykUFhIc82fx2D3Xv3JMuLA+7/Fg8Dkq2VTMH4DCQ/IUA//ZR cMvH6thrz4d8i5RUgq+AQ48Og+hP3NrZoX7ywpbZsJ+XbjWvUWEbqx4za JpQlwSMTB4UK6+i138sYcbmSJJdyWueTchMAlP4/qNj2j4I7pTnPIJ5IJ w=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: X2+nQmJ1tH5mhV3oDPMmtzusDNMt8b11XfAjnw2J28jiRcq06Wdub6GVQH8UBLWYm8ForiGaGn jNUs4VlEPKjixCcneaA+XpEbx4EYZjKV9q0vDF3Fl68C/40PhmdnJRuZYa3JnOc576eURHhLCF 6SgySuRdALzUo0LJtr4i4WekZPIZ6aNQksVUmdgMM8SM5ovP15Hg3Nw/UT6CxtkAuHqCOawyNT 484kDeT2ucjXfNv45Xo/32I/PnFpYBZcQIo0EexNBj/jLZ746YiOBH1OzKg87/A0rZ3EIECzDL NeI= X-SBRS: 5.1 X-MesageID: 49778418 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:x6/saaGVeTDEIXJfpLqFfZHXdLJyesId70hD6qkvc3Jom52j+P xGws526fatskdtZJhSo6H9BEDmewKSyXcV2/hcAV7GZmjbUQSTXfhfBOfZsl/d8mjFh5RgPM RbAuZD4b/LfCBHZK/BiWHSebtBsbq6GeKT9JzjJh9WPFlXgspbnmNE43OgYytLrX59dP0E/f Snl696jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUiSw71M7aXdi0L0i+W /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yvT9aw+cyTpAVr4RHoFqjwpF5N1HL2xa1+ Ukli1QffibLUmhOF1d7yGdgjUImwxelEMKgWXo/0cL5/aJHw7SQvAx9L5xY1/X7VEts8p717 8O12WFt4BPBReFhyjl4cPUPisa3nZcjEBS59L7tUYvGLf2qYUh2LA37QdQCtMNDSj64IcoHK 1nC9zd/u9fdRefY2rCtmdizdSwVjBrdy32CHQqq4iQyXxbjXp5x0wXyIgWmWoB7os0T91B6/ 7fOqplmblSRosdbL57Bu0GXcyrY1a9Ci4k8FjiVmgPMZt3dk4lh6SHk4nd1dvaDKDglqFC6K gpeGkox1IPRw== X-IronPort-AV: E=Sophos;i="5.84,236,1620705600"; d="scan'208";a="49778418" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fZA37plO2DpceCbBvsx4NM2TJUPPQ9k2oyCdx1Oy9HEmNu2CR/edjlto6w5PEWhz9RYJGEiECHjEEAH12xLuvYFai7YCzEqqgVONyf7i0gVe1FqtSe5rIKs8RZfWq9hYEyhNh2LOc5937lMbJ4Egw4FvJ9JUEkcy5Tlu4Kx/PeXW0RwqfUNVahJmS9N87S5oQFnf1524eTKPrBXjT3kWZsS+fXXnuh3J3J/3WDafe7dkVRcyTzgprPWTvWWGYzhwdHyEexgVuD1afNSmf7jPAW2OmVzJL1PzgqCMuqLuzLkf3FTT6r6t3t3pK3GmssLkJviyQ8lsWSsPoGiW7Vvm0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x8OuwpgkQgwL7qS3Nl+FPFUnymj6QsYs0vkAM6DZiCg=; b=iwY0A9VJ/32GGGJi5Irfr02pTP378KXIlMTNoMjj9NY5WGDGTZTVwYEN7qwKV40fcEyZ88ahTpEvZvhEue/jYYYW61oz4Fnc1eYFcWgBsLm7GfMFNXH94rVJS1tqOFXZCBoFBBJHgvFZjSgrOd1Qld9M7lgB7IlbWATrIeDiRqnv1rer6PGseKuyoma2v+jXIKjDLDLyp6c2i4zfyzWHdEqyMztKAcExdIlLvmJ6wR0V6ENHi9bMZvU0etIQfhMdjfiF1bHmGTON12EUMdam+CHJ6H2Kzz7YBW2ToIOuzBn+wgpLemsy/k4gNXMN6K/RZclKwStwFHJ7WhqyZ/p5OA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x8OuwpgkQgwL7qS3Nl+FPFUnymj6QsYs0vkAM6DZiCg=; b=tFbXeZBpqKSncDiV5RUNVR+Mjzq3r5sBoJjH+fLXeznq+WspbOTzhVgoCX+AwG66sZ7ykbvpv0hS2tFzxEmNu/rmMpgZj4tWjdZBS7b8kImcBbC5aZ1XJWf3N0fdOtk/ur4hIx8ae1HpEjVR3aB5+4StzHYOnrCb30o/6kQeSjU= From: Martin Harvey To: "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Subject: RE: [PATCH] Log module loading Thread-Topic: [PATCH] Log module loading Thread-Index: AQHXcw2/Knojojq7r0i0Tdd3ept0D6s/uiSAgADkXnA= Date: Tue, 13 Jul 2021 08:39:07 +0000 Message-ID: References: <20210707085456.1826-1-Martin.Harvey@citrix.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e9fac565-8702-4c4d-a244-08d945d9ae0e x-ms-traffictypediagnostic: MWHPR03MB2511: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xN9hfgL984Tmh8LFwFNByN+PoNiY4H3UWsciLivOgpzHRp7eGR8Z7xQ/DtirnrqmKAfIaLjyrN9Iqq/jWVehcc57t77V9bHG/tHDK0f849dJY9LW9nBytv3EjrBqYjdh4KpcSGDro7PMfyjC7v/JSPEP9qpR3Zvgd8eAfcUGWTbO6jikR9c3Lld7BplbuAZEVulJaEq0USB6ygjn3rqD4oDmo+6vCLdPqMN4T8cbAzs29kLW1ZSjthWDed575ENHZV3C4qOZ+gNBJn45Zd/yeWV6ee66rb+Xyu5y96AJWm278ixuqdH1QYA3WhvKoK1Gbl30wHNoyrnmLDPLjsXRGi/La2Vp9BLLiTXDu9ZsmdD23oAFMcl44hF+EZ6Mp7TTcrvkYUx7DAM+Z8aCWwEjC3VIhxung/dil2FKLFz38pMPnQadrn8zRzppZAO/z4BOHjjAo/Iwxu1Qv0qv9GvSfWfsmu6N28WlD861oBh1VD29gF8ionpxI5OSh5dPkJnDljadp50BY1/ABv84mAQEtU1Ayuh6wKaSxVKCReN10O0qpouIfA58Obz4Akd2v/P7NeBgW02Vcgx0spE/mQxCFHYi5d/ZfDLZBfuf185kmcM27mOD6NvMF7i3GMljYEw/v8sU2sWlVRRwIB+fujhvHQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6347.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(376002)(396003)(39860400002)(136003)(366004)(64756008)(316002)(52536014)(7696005)(66556008)(44832011)(66946007)(66476007)(110136005)(26005)(5660300002)(2906002)(186003)(76116006)(71200400001)(55016002)(33656002)(9686003)(66446008)(6506007)(86362001)(53546011)(122000001)(478600001)(8936002)(38100700002)(8676002)(83380400001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?c2p2MTAzNjdOQUR2dXFDd3BtTHJDZmtWUGRyUEpOUWJacG5sYkFQZkdSMUFU?= =?utf-8?B?NnRkSzduQ3lvOHNGNlU4b0ROWVB4Q2kzV1U2cWJBZTVaNjNBSzlycjVmMlFD?= =?utf-8?B?Z0hXR1o0OWtnR1pRbUJ2U29PTS9nUDRZYXdYRUpuWHVpR0Z3bVZKT3dLR0kx?= =?utf-8?B?cFFTbzArQU9HOTZZOXEyMUVtdlJEMFE3MGtFZXB2aXdQanloZE45ZlNvYmgv?= =?utf-8?B?Z0NlWmdEN203R1RIem5WWFdZVFZpNndxNUxRY1dsaE5TZlN4VndRSG0yZDhM?= =?utf-8?B?N3ZaSjA1eDhNZmhVT2JVdSt5Rm1EMllJU1B1bzhYeitlWVFpaFdYOGgwd2xz?= =?utf-8?B?NDJqeG11SnV3RUVEQjVGaXByRVRqS1h1VlF3dzVwTklFTjNWbHV1SVY0OTkr?= =?utf-8?B?bVJFZStDSnduYU9RQW5OMkNialZNNVJ4UHFaZkR6bUFkOVY3bXFJaVcwZWFO?= =?utf-8?B?ZUk0QUpqRzFLV1gvaU1qVHpNRUF2OURxeXdFVlVYWThzRFBuQlRia0QvQUZi?= =?utf-8?B?U1JHdjNUbFZzRndHekRWS2YxSDRaTlVQYWcvdmJ5V0tNNDBlVUxYU3VEd2hm?= =?utf-8?B?K1Bpa0ZWNmNiWXdPK1p4UEZ6SmxpL25JeDNJV1ZCRHZyZnFEaDFrNTBmWktX?= =?utf-8?B?a3grWWtnY3V6T28wNTVRUUIxeGt3bG11UjlJYlNLYTVSdkFLRnpiVk84Szh1?= =?utf-8?B?YjVYV0JveDhWcjdTaEhBZmMxR09KcXpWc0VybHhqMnJIT2VyNzJicTRKV0Zz?= =?utf-8?B?SktGNEg2WkZ6SXJBQm9jTS8wazV1elZKU3o3b3ZacjRUNzBFMlpvMmxyS05B?= =?utf-8?B?Q2RSbGhmUXhnVVZoY3l0d0lTZ1IyeFUrUjhCR1hDcXRvNk5JaVcxaG5qSGNN?= =?utf-8?B?M3BVcW5IbXdEZFJhNEh5aHd3cDVWV1hYdlJRczFrTjl5bytLbkJ4amYweHZx?= =?utf-8?B?R3RpT0cxVngwZytrMWZEamxEL3h0VWJXVUY1YlhHYTBHVGFuemlBUUxlTXdq?= =?utf-8?B?Q3JkM29BMldJV3lnYktsNVR3UmptK2FzelR4dzl6a25wOU5UWkk3YTFXdlR5?= =?utf-8?B?MDdYZVpvK1ZkTk0rMTNhZVZZd01nVStEYXpQcU9NT3JESFd6NUxXbHNhOHp1?= =?utf-8?B?UG10U1ViSnJHRHhQVy9USGhYOUhJVm5aVER4RndTWWdVOWlVMlFtQWFqVzZ2?= =?utf-8?B?MHhJaTlzdEtWaTlCSDIydndNU1ZvbERpRE9ScUFiQ1MwZlh0ZU02L29EWVpM?= =?utf-8?B?Qy9OWWNwbHVEOEdVWld5VnhvZitBMHNWR3ArY2YxWUxKQTdreHhmS3ZkSEc1?= =?utf-8?B?VUNzclVRNDltSWRpMWtoVGcxOXhQU0FLd0hWdzhGSkU5NDRWZnp6OE5NbWdi?= =?utf-8?B?aklYU0dKYjFMT1BKOGFiV3RpRFJKQ2ZxVXBBWkt6bXk0M1U0cnlId29VODhM?= =?utf-8?B?cnlqVHdXWjNoeVdwVzVrY0lkelc1VWZSL3g3WkZMb3dZNWE5TThZdks3cGNo?= =?utf-8?B?VXhJUEd4ZGpWaUtZSFFLVzRsdmE1dWpNSCtvZ0x6RkJyL20wdUYwdFFaSTdX?= =?utf-8?B?ZzJtRjBiVFhaTTY2bnRyNXh2Q0RtbVZDWnZNV3FDb1AwQkhNa2ZaNkxCL0xq?= =?utf-8?B?c2xoYS80WlpTVEk0U20wUlVoRm9KeFVxTHlZbUFEeUpLODh3K3BDcHZYRXlR?= =?utf-8?B?Y1QrUVc4UmRDWE15LzcrVFMrWElVRzN5RHdQaExNOG9ZdTh0WFdMM0dBM0ZP?= =?utf-8?Q?6QX5ne92D8w3DZEJwm4duFRCm0+YNKOKsb1oJCi?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6347.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e9fac565-8702-4c4d-a244-08d945d9ae0e X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2021 08:39:07.5301 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GXac7IxhH7z9rJP+9xCcdb2xCCdnnFiMzV9InEGFxgqtR9sxWc+oEbyLLRzfx7enVYHiAzcYai5BGSY3tmgUwkQo4TMHjN9PRupKccK7s2w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2511 X-OriginatorOrg: citrix.com DQpJIG5vdGUgdGhhdCB2ZXJ5IGNsb3NlIHRvIHRoZSBkZWJ1ZyBwcmludCB0aGF0IHdhcyBjaGFu Z2VkLCB3ZSBoYXZlIElOU0VSVF9CRUZPUkUgYW5kIElOU0VSVF9BRlRFUiBtYWNyb3MuIFRoZSBw b3NpdGlvbmluZyBhbmQgZXhpc3RlbmNlIG9mIHRoZW0gdGhlcmUgc2VlbXMgYSBiaXQgY3Jhenkg LSBkb3VibGUgbGlua2VkIGxpc3QgaGFuZGxpbmcgc2VlbXMgdG8gYmUgYSBnZW5lcmFsIHRoaW5n IHRoYXQgc2hvdWxkIGVpdGhlciBiZSBoYW5kbGVkIGJ5IG50IVJ0bF9fXywgbnQhRXhfX18sIG9y IHB1dCBpbiBhIGNvbW1vbiBmaWxlLg0KDQpNSC4NCg0KLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0t LS0NCkZyb206IHdpbi1wdi1kZXZlbCA8d2luLXB2LWRldmVsLWJvdW5jZXNAbGlzdHMueGVucHJv amVjdC5vcmc+IE9uIEJlaGFsZiBPZiBQYXVsIER1cnJhbnQNClNlbnQ6IDEyIEp1bHkgMjAyMSAy MDowMA0KVG86IHdpbi1wdi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KU3ViamVjdDogUmU6 IFtQQVRDSF0gTG9nIG1vZHVsZSBsb2FkaW5nDQoNCltDQVVUSU9OIC0gRVhURVJOQUwgRU1BSUxd IERPIE5PVCByZXBseSwgY2xpY2sgbGlua3MsIG9yIG9wZW4gYXR0YWNobWVudHMgdW5sZXNzIHlv dSBoYXZlIHZlcmlmaWVkIHRoZSBzZW5kZXIgYW5kIGtub3cgdGhlIGNvbnRlbnQgaXMgc2FmZS4N Cg0KT24gMDcvMDcvMjAyMSAwOTo1NCwgTWFydGluIEhhcnZleSB3cm90ZToNCj4gRnJvbTogUGF1 bCBEdXJyYW50IDxwYXVsLmR1cnJhbnRAY2l0cml4LmNvbT4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6 IFBhdWwgRHVycmFudCA8cGF1bC5kdXJyYW50QGNpdHJpeC5jb20+DQo+IC0tLQ0KPiAgIHNyYy94 ZW4vbW9kdWxlLmMgfCA1ICsrKysrDQo+ICAgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygr KQ0KPiANCj4gZGlmZiAtLWdpdCBhL3NyYy94ZW4vbW9kdWxlLmMgYi9zcmMveGVuL21vZHVsZS5j IGluZGV4IA0KPiA1ODRhNjNkLi45YzRhNWVhIDEwMDY0NA0KPiAtLS0gYS9zcmMveGVuL21vZHVs ZS5jDQo+ICsrKyBiL3NyYy94ZW4vbW9kdWxlLmMNCj4gQEAgLTE0NSw2ICsxNDUsMTEgQEAgTW9k dWxlQWRkKA0KPiAgICAgICBCT09MRUFOICAgICAgICAgICAgIEFmdGVyOw0KPiAgICAgICBOVFNU QVRVUyAgICAgICAgICAgIHN0YXR1czsNCj4gICANCj4gKyAgICBJbmZvKCIlcCAtICVwIFslc11c biIsDQoNCk5vdCBuZWNlc3NhcmlseSBzdXJlIHdlIHdhbnQgdG8gbG9nIGF0IHRoaXMgbGV2ZWwg aW4gdGhlIGdlbmVyYWwgY2FzZS4gSSB0aGluayBpdCB3b3VsZCBiZSByZWFzb25hYmxlIGZvciB0 aGlzIHRvIGJlIGEgZGVidWcgbG9nIGxpbmUuDQoNCiAgIFBhdWwNCg0KPiArICAgICAgICAgU3Rh cnQsDQo+ICsgICAgICAgICBTdGFydCArIFNpemUgLSAxLA0KPiArICAgICAgICAgTmFtZSk7DQo+ ICsNCj4gICAgICAgTmV3ID0gX19Nb2R1bGVBbGxvY2F0ZShzaXplb2YgKE1PRFVMRSkpOw0KPiAg IA0KPiAgICAgICBzdGF0dXMgPSBTVEFUVVNfTk9fTUVNT1JZOw0KPiANCg0KDQo= From win-pv-devel-bounces@lists.xenproject.org Tue Jul 13 08:53:07 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 13 Jul 2021 08:53:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.155172.286537 (Exim 4.92) (envelope-from ) id 1m3EA6-0005yS-HJ; Tue, 13 Jul 2021 08:53:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 155172.286537; Tue, 13 Jul 2021 08:53:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3EA6-0005yL-E5; Tue, 13 Jul 2021 08:53:06 +0000 Received: by outflank-mailman (input) for mailman id 155172; Tue, 13 Jul 2021 08:53:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3EA5-0005yD-Nr for win-pv-devel@lists.xenproject.org; Tue, 13 Jul 2021 08:53:05 +0000 Received: from mail-wr1-x42f.google.com (unknown [2a00:1450:4864:20::42f]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 85385d56-0aaa-4282-b65f-9fb1d776026a; Tue, 13 Jul 2021 08:53:04 +0000 (UTC) Received: by mail-wr1-x42f.google.com with SMTP id a13so29408190wrf.10 for ; Tue, 13 Jul 2021 01:53:04 -0700 (PDT) Received: from [192.168.1.186] (host86-143-223-59.range86-143.btcentralplus.com. [86.143.223.59]) by smtp.gmail.com with ESMTPSA id o19sm1624356wmc.12.2021.07.13.01.53.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jul 2021 01:53:03 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 85385d56-0aaa-4282-b65f-9fb1d776026a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FSwl0FVDSumqeSsdFT5lT6rIRhJqCfRy10Zbr4YwePg=; b=peDWaIrWQck44QnpzHw72tEwTaNvqcuSLtC4yiDP5/fu/wx1e5VanyOuJX/ZsMApLl owUUsLgbayY9xln5D2vbynh2+UVFPF3VM1qN/8OfSFUxttX/z5LuHcm7eHpHzdTX1hqr f0wZJt7JJRJHwvtFMbCsyvdv3aCtEngnHmkP7EF8EYqiHXTI2ycQVNA7x/VFCDG0JQqz NRGaKixOI78CZcj+Y+FfEhKwzdyQma0I2Dqqw9WSVlUDi/+jBDYBGbaUi0rvbhsIQDnY XPEonYB7IBHYevmJ+nJXSwTGluhTDUjP13lhrXkaZZYXf46U09HikIEuxeoy7ryD/GtP XabA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FSwl0FVDSumqeSsdFT5lT6rIRhJqCfRy10Zbr4YwePg=; b=luyAVPaCTZw+XZelAcBKzVS8sxo7XMydwAFfuNeq8k8FCa0riasHxngcYUtxhHxsbx BRLFJ6abeSu40N7/4JU3riA9pAnzz8RM0cLFcebylcksvPCoTyqhipxvC+ZItDboI4PJ wkWzxIKyRCQ9vJrp+7oTOIgF/Bo4ck2+tCGlO+F4FrUoaHKw6NoYssPAQWVcLaxxPvWy SMANZkKGh60vCtdr4XIh/fJ44e1g/WK7eTCQceaN6gQO9YyV54dryrLlF9XzdFeewcBM 4nag/bphUlI8nLBQldP9/ouiYuNugTWt3HeNMQh1UpeLZOB4bCy9vTF5nOlCa3vwPZQA GXWQ== X-Gm-Message-State: AOAM533EK9in02xoLFY0opMy4noVQkuIeTSNOuyJ6fcftf+vtJraIEWH TQz9EcDHJkJjASbDdvcGXQae+QQJbPs= X-Google-Smtp-Source: ABdhPJz8itOzllXwHDc73sUve482GM5ffi/aK5n+WaT/UU0My6KVwLgEaGaYsPE4q7bRORw7QFwpyw== X-Received: by 2002:adf:a287:: with SMTP id s7mr4216073wra.120.1626166384141; Tue, 13 Jul 2021 01:53:04 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH] Add log to Xenfilt DriverAddDevice To: Martin Harvey , "win-pv-devel@lists.xenproject.org" References: <20210707085456.1826-1-Martin.Harvey@citrix.com> <20210707085456.1826-2-Martin.Harvey@citrix.com> <60fcc419-10ee-e02a-b235-1d6c8c5d1d25@xen.org> Message-ID: Date: Tue, 13 Jul 2021 09:53:03 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 13/07/2021 09:25, Martin Harvey wrote: > Yes, we definitely need to log all filter AddDevice calls. Here's why: > > Cut a long story short, the customer likes to do all the things to a VM which they normally like to do to windows machines. This includes upgrading windows editions via windows update on Win10, and also in some cases, mounting the ISO for a newer windows server version, and upgrading the version of windows server. > > These upgrade cases do some driver migration steps, which often (but not always) work perfectly. Unfortunately, we've seen cases where class UpperFilter registry keys go missing / don't work, such that XenFilt no longer binds to ACPI/PNP0A03 (PCIBus if memory serves). > > If XenFilt can't filter the appropriate devices, **Everything** breaks - particularly, Plug/Unplug doesn't work right, and the machine continually prompts for reboot. I can go back thru case reports and give more details if required. > > Tracking this down as the newbie back in early 2020 took **weeks**, where it could have taken a day or so. That debug print would make debugging similar cases very much easier, and it's a problem we're likely to run into again. > > Please include the debug print for developers sanity. > That sounds like a justification :-) Care to send a v2 of the patch with (at least some of) this in the commit message? Cheers, Paul > MH. > > > -----Original Message----- > From: win-pv-devel On Behalf Of Paul Durrant > Sent: 12 July 2021 20:06 > To: win-pv-devel@lists.xenproject.org > Subject: Re: [PATCH] Add log to Xenfilt DriverAddDevice > >> Log all calls to DriverAddDevice, and the type of the device if >> possible > > Any particular reason existent logging is insufficient? I think we need more justification here. > > From win-pv-devel-bounces@lists.xenproject.org Tue Jul 13 08:55:14 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 13 Jul 2021 08:55:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.155182.286552 (Exim 4.92) (envelope-from ) id 1m3EC9-0006iy-W9; Tue, 13 Jul 2021 08:55:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 155182.286552; Tue, 13 Jul 2021 08:55:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3EC9-0006ir-T9; Tue, 13 Jul 2021 08:55:13 +0000 Received: by outflank-mailman (input) for mailman id 155182; Tue, 13 Jul 2021 08:55:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3EC8-0006ik-DN for win-pv-devel@lists.xenproject.org; Tue, 13 Jul 2021 08:55:12 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 77436401-3e78-4e0f-b858-6d1661acb673; Tue, 13 Jul 2021 08:55:11 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 77436401-3e78-4e0f-b858-6d1661acb673 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626166511; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=DDXu1Czbqi/duF6/8ouBdPTwxCLbZIZL5tklMgm9LzE=; b=ZL0OAi+OPgd1RQUPEqNmog2J/srRgX3+E68tfNdV8XCgQb2LUXXXGBp5 wiFgW5adZT/haFlJWMUKV4Q7Bkqc5beH4TN3xj1hSkhZXPABjl8lvWlXL ARynALPk20tTeJxcvPKIeomUDybyGGbCGkvDedTYkXw7iKEg1CeTxnsCL g=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: B8e9EOIbFqZI5khzF5wmASwa/wVHQ2GCMwFrSHQIOrb8SP7AM6kjHPVS179Oe0jUkCaP87ViIN VkAS2R1UkFiva2gAgia6zxrpOfZcqM1Zr7886trRwq2hbtN2r7cU2oK8OUxgkKYT72eZFrAU+/ mJCX/LFqlW4nK9ZQWG6nck8t4AAxagu5iJUkhwUwDhZQ7s0Yd1YhAmDypR7CExbgSlieuTZ4lt KIKQZbujGlPqnuCG702QtCPWa9OLKF/zzmngxFyTcNAf/J7NCXNSkHHPo+doFScygvvPljXBvQ 9DA= X-SBRS: 5.1 X-MesageID: 48195813 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:GrJEB6nhrKwu1Dx96DqTmTNd8OnpDfLo3DAbv31ZSRFFG/Fw9/ rCoB17726QtN91YhsdcL+7V5VoLUmzyXcX2/hyAV7BZmnbUQKTRekP0WKL+Vbd8kbFh41gPM lbEpSXCLfLfCJHZcSR2njELz73quP3jJxBho3lvghQpRkBUdAF0+/gYDzranGfQmN9dP0EPa vZ3OVrjRy6d08aa8yqb0N1JNQq97Xw5fTbiQdtPW9f1DWz X-IronPort-AV: E=Sophos;i="5.84,236,1620705600"; d="scan'208";a="48195813" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kBr9IHFZ8rMg02P1tBc/wHzuaLosBTOngHiDm5wVej6Nzpqebu+6enLPpMRiXu9K4srzBVxXRJuQLOcyCQtRXWd18C4rE+jaTIpVZs8nTkXp62ACDxcJ7+sJc6KrZKnIVG73Fr5p9oBOIDQaHtNBQ00wveqnDi+VSXzufkc0wRxErgcoGZFUOI4C8++EDvNjQVM0ie8jL1dZOtlc6+EsvfE7nZnN5fVJQLf1NshuTU+ERJosHLHQCvVi2ggEKoN4uIwB53MAAJ2m/z52rhqSw1hwqvrkt5z9UAeRGxDiMSHBydeiCuKfE1adJosSebtNFUu6ZnkzdQ5aCh3FkkwZNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DDXu1Czbqi/duF6/8ouBdPTwxCLbZIZL5tklMgm9LzE=; b=CHR0EpvL+Z3gBopmkfO87HCSBil2nEJLVm9/y5tAMzJjfPEh+G4XNeqQyk+mA6D5Q0cd8VfRapgBKDQkGCQ3IbPXsEPafLijnK7xcGNZc1uGZE1JJQabhheWNeIZoqkM+uKRvZczHMpxQlBjfMf5y+/ufvr090CWzigYi5uaaq96Eq+zS2UMgLsKun1nyI0G+kGO5i7ckdFswmWjP7Lky8bwZsWK3OCPlCb2o7ijNqMslyjk8zbwIzV998z9LO3jckNjOpba1mg0I6zIzXxAnF0+GqRQkXf4/zZJzRmFNiHSUVqdbcHo777nfR0vD1+PVS2jDSaUTM2XFGtCpSli7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DDXu1Czbqi/duF6/8ouBdPTwxCLbZIZL5tklMgm9LzE=; b=kOMeM+tPZKn0AZcKz4naEk41PqmwiLZP+hsGKBChc+BQ1UG+7nTIiegVmd9PvXbPsJ1ZGaSE6KRLOmA7O6dTe3may8jaDQaH3kM2MKYPl594PshSfqvOumm14Ae0TdmXk8WMVhoJHCZRSWRWZeP2Q+ojaQzPg4PRGftzXcfpedU= From: Martin Harvey To: "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Subject: RE: [PATCH] Disable CONS debug logging Thread-Topic: [PATCH] Disable CONS debug logging Thread-Index: AQHXcxGeIfXNO0rCZEWN6VpzK7eW7Ks/vHyAgADiqHA= Date: Tue, 13 Jul 2021 08:55:05 +0000 Message-ID: References: <20210707085456.1826-1-Martin.Harvey@citrix.com> <20210707085456.1826-3-Martin.Harvey@citrix.com> <7074bcda-ec68-01eb-a519-88c3447efa47@xen.org> In-Reply-To: <7074bcda-ec68-01eb-a519-88c3447efa47@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b39661f1-82f3-4a95-88e7-08d945dbe911 x-ms-traffictypediagnostic: MWHPR03MB3360: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0PqjMh9jXTUeU3RNyrYDSxDjzWzOZYH0RPRXtzZsjjsyLyUsBKQXBhjNYijzBwRqG3Q/Uqf57pIK20s4lfs/cd8ZC6yqQWkdWVJhrPTg90r0EKaJg+2oAYmbsqGJn80Zqb/W9a0vd8gT9r+7pNQVxRBmoFDDlsCbenZ/3gjOPkmRJhrr8F8Iel2vmmMepyeu52eZqHbxFqA6MxeAbNPdc/yxl8jjcTtYaZcq8iIlTzJV9WgqauZqaIYIRH57Z2PNGZMKTXzkNo4PZpGTyXrbzqchHhdD52kl4gdFBqPU5azhzhNwhqbTJLx3kIj4BKfq2arW3Ir5sp/+CkpO3dTigWbobeiBhFTh4qAHPTYPLW0ueO/BQydDonceYPQjsBnGkVVRBtI1d9IyuGiTWHGx9IJuLZXLbn0Yz0eKqNyd9GI41TFI3S0fOjDF4xZ/pJ6HrL3Q7eZSpsaLc3aLmK58XPU2eAAMyyzmCRv4xijdmliGwVjvgE+FgSr8mtbNgn9DzaZh9UKIo1PQ632rgJtjwE3keIoZ6/yUKCDnZm1fq5jk5dgnGmiZnx23Jn+Vo/T0+E8R3JYze4CBR3XPMjbeNbNdiXSFv4Adr7qm6tXEUKv5oQAcJZWPp5fVoDAP5Vf0HtEupuiE6fboddDAdcFGMg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6347.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(39850400004)(136003)(396003)(366004)(316002)(52536014)(83380400001)(86362001)(44832011)(33656002)(8676002)(8936002)(7696005)(122000001)(110136005)(38100700002)(2906002)(66556008)(26005)(64756008)(66446008)(66476007)(76116006)(186003)(55016002)(53546011)(66946007)(9686003)(478600001)(71200400001)(6506007)(5660300002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ajgyQU9GY2duY1BtdXVJbXo0RGh5YS9GQiszRCtuQ0d6QzhEQTFUQVJiUXZ3?= =?utf-8?B?V3dzYTBvRjhkWU45L3ZHNDl5UXdzU3YraUV6a2dMSEdVZDVhVnF0YmQ3U0Zi?= =?utf-8?B?SVVjelFmcFRiMzRhVDdWWkpmd3NKamQvL2RoRytiSXRPdml2U2xXdHpLV21V?= =?utf-8?B?MTVIMVJHU2tqMysvVko5QkZ5SGlhQ2hkV3hUeEZBS2ZiaFF4Q1ZBOVdObHU4?= =?utf-8?B?WnA1NDhWU1Zud25qbWRTc2F1STFFM0x5UEtXQUlXeWc0N2E3RzlNWnoxS1Br?= =?utf-8?B?NHo5YWxUVW81NFFxSHU0OTNHUFYrSk4rNmY0eVBuMGNTVUU4Snd3ZDZGRStN?= =?utf-8?B?Q1AwYkhweExCdzRCZVFSbm4rSnZCd1VjQ2xlYmZISVRFRW9wdWZ5TzE3dnVt?= =?utf-8?B?aXRSdGY1WWJLMGgrVmR2RlBmVzdvWmdVWWZFZ2ppRk13TzVlQ1hsNC92RnZn?= =?utf-8?B?VHpLMit3RTQ5V3BFWmE2T0QzeFdwY09MaG5wemhVTkdXT1VyaGtGMnUvdnlh?= =?utf-8?B?UUVCd2E3cldnZTFVTEpGemVaVFNSMEk3UzN6dUZSOEs3R0Z0S09DREVNVy9S?= =?utf-8?B?a2JENHAyTHI4c3ZsU01nL01seElmeFVXejNvRy8wRUlJSHlvSFdaUW5aeFNt?= =?utf-8?B?dkMvM1lkbDhjandHTTVrVzZYamw4RE9rdDM5bUNOMThndDFBamlVZVhVeUtM?= =?utf-8?B?U1Fwem9MaHMweUhKeWtyeW56RjlFQS9jV2l5NWo4c0p6eHkzRHhrSE5yRFVY?= =?utf-8?B?L2d2dDlPcDYrV1RISHE0R0ZxN0V5cTBKMVdYMzVpVWhtVU13NXdtcU50K1M1?= =?utf-8?B?b2ZDVXhyakxYcDg2cXpoaThQeVl1NjhadFVXaENtRis0TzlaU2ZEV2VWMHV1?= =?utf-8?B?KzIrL3BOZXFSeXc5RTV1ZURyRWExNjBEQ0JaUFZhQ2pqY1FIZ2w1cUZpTDFk?= =?utf-8?B?U2VYSy9lOFZMVWxBdHVaUVZlZVBLNzhiaGtOM3g4R3NQbzVtdmw3RklzZVpu?= =?utf-8?B?MWV4TmxRNE1FSnllNjluQTIwaXdMV2lXWDQvSU9zdWZpL3FDS2twU2VKVXFN?= =?utf-8?B?Wm9Yc2xQUEFzdFBWTHNDZVp6WU9DSVdodEV0V0dEcjdFcWRGMjRhbE9UYlE2?= =?utf-8?B?Ly9yU0FrWUx0VHNFd2gvYnhSenlYdGlKQW1IbTdIVmNpZ2JqSk9hNTNpeWx2?= =?utf-8?B?WkdiM0lJdnlHUFFyM21rd0pkWkxPUmhpZXRiVFlYSnhlMnZPdXNMOWlnTHJR?= =?utf-8?B?YjlTVnl2NVFYbTd4ckpVWHRDdHc0UGdITUFOckZ4Y3cwRFhFSG1GazA5dklz?= =?utf-8?B?SjliVVZIell4M2QzUXE3ZE5pZng2bGVPNi9BK0YzVDVCSUV2OFJXRHcya0dh?= =?utf-8?B?Lzg2cytmZVArdE5rd1loWXI0VzN6TVVCbm9nT0ticmk0VzZBWkxvU0F2dWd0?= =?utf-8?B?RjVLdXIwRnU0NmJJN2pyK001b0dYYWtLa2pvaTBndmNOZndmZlJldExud3A4?= =?utf-8?B?R2o2QjkvZFdFaFFyZnFTbWtYYVZKSUNrcTR5cHpRTUVRejZncThMMU53RitM?= =?utf-8?B?OWM4djJ1NnNrUTBac0QxRWZ3OGFwblptNHV2ay9menY3R3FPamF3OVB3bm51?= =?utf-8?B?RVNtK0FBZXB4WlhqcnQvWE9FYUc4eE5Zclh5akUxaENDY1RKTlcwYy9IK3BE?= =?utf-8?B?Q01wSjRGRERobnFKYnVWUkt1TVVHNHo1Zy9scVZjeGROcVc3YXNCN2IrUlhJ?= =?utf-8?Q?3GHq7oGyWJs06kYFM89HE/PRAyLNXFj/nFSWxDK?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6347.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b39661f1-82f3-4a95-88e7-08d945dbe911 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2021 08:55:05.9194 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eMUSHn6xxJZZO+SQE/G+BIDf0guG9aOuJuaPD6YCLD2YbfA34ZMebrR3JBvauRy9R0/9QoMV22bTYF3nNV1pqaqcFhVlMJn6K7jH5Hrg9+A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB3360 X-OriginatorOrg: citrix.com DQpJIGJlbGlldmUgdGhpcyB3YXMgb3JpZ2luYWxseSB0byBwcmV2ZW50IHNvbWUgc3BhbSBmaWxs aW5nIHVwIHRoZSBsb2cuIFNvbWUgYW50aXZpcnVzIHByb2R1Y3QgLyBmaWx0ZXIgZHJpdmVyIHdh cyBzZW5kaW5nIHNvbWUgUG5QIHF1ZXJ5IElSUCBkb3duIHRoZSBzdGFjaywgd2hpY2ggZmlsbGVk IHVwIHRoZSBsb2dzLiBPd2VuIHNob3VsZCBiZSBhYmxlIHRvIHByb3ZpZGUgbW9yZSBpbmZvLg0K DQpBZ3JlZSB3aXRoIGNvZGUgaW4gY29tbWVudHMuIFdvdWxkIHNvbWV0aGluZyBsaWtlIHRoaXMg YmUgYmV0dGVyPw0KDQovL1dhcyBJTkZPLCBXQVJOSU5HLCBFUlJPUiwgQ1JJVElDQUwgdW50aWwg cmVkdWNlZCANCg0KTUguDQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiB3aW4t cHYtZGV2ZWwgPHdpbi1wdi1kZXZlbC1ib3VuY2VzQGxpc3RzLnhlbnByb2plY3Qub3JnPiBPbiBC ZWhhbGYgT2YgUGF1bCBEdXJyYW50DQpTZW50OiAxMiBKdWx5IDIwMjEgMjA6MDkNClRvOiB3aW4t cHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcNClN1YmplY3Q6IFJlOiBbUEFUQ0hdIERpc2Fi bGUgQ09OUyBkZWJ1ZyBsb2dnaW5nDQoNCmEpIFdoeT8NCg0KPiBTaWduZWQtb2ZmLWJ5OiBPd2Vu IFNtaXRoIDxvd2VuLnNtaXRoQGNpdHJpeC5jb20+DQo+IC0tLQ0KPiAgIHNyYy94ZW5idXMvZHJp dmVyLmMgfCA4ICsrKystLS0tDQo+ICAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwg NCBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS9zcmMveGVuYnVzL2RyaXZlci5jIGIv c3JjL3hlbmJ1cy9kcml2ZXIuYyBpbmRleCANCj4gMWI2MjFmYS4uZjM1M2E2MSAxMDA2NDQNCj4g LS0tIGEvc3JjL3hlbmJ1cy9kcml2ZXIuYw0KPiArKysgYi9zcmMveGVuYnVzL2RyaXZlci5jDQo+ IEBAIC01OCwxMCArNTgsMTAgQEAgdHlwZWRlZiBzdHJ1Y3QgX1hFTkJVU19EUklWRVIgew0KPiAg IHN0YXRpYyBYRU5CVVNfRFJJVkVSICAgIERyaXZlcjsNCj4gICANCj4gICAjZGVmaW5lIFhFTkJV U19EUklWRVJfVEFHICAgJ1ZJUkQnDQo+IC0jZGVmaW5lIERFRkFVTFRfQ09OU09MRV9MT0dfTEVW RUwgICAoTE9HX0xFVkVMX0lORk8gfCAgICAgICBcDQo+IC0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgTE9HX0xFVkVMX1dBUk5JTkcgfCAgICBcDQo+IC0gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgTE9HX0xFVkVMX0VSUk9SIHwgICAgICBcDQo+IC0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgTE9HX0xFVkVMX0NSSVRJQ0FMKQ0KPiAr I2RlZmluZSBERUZBVUxUX0NPTlNPTEVfTE9HX0xFVkVMICAgMCAvLyAoTE9HX0xFVkVMX0lORk8g fCAgICAgICBcDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC8vICBM T0dfTEVWRUxfV0FSTklORyB8ICAgIFwNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgLy8gIExPR19MRVZFTF9FUlJPUiB8ICAgICAgXA0KPiArICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAvLyAgTE9HX0xFVkVMX0NSSVRJQ0FMKQ0KDQpiKSBMZWF2 aW5nIGNvZGUgaW4gY29tbWVudHMgbGlrZSB0aGlzIGlzIG5vdCBzb21ldGhpbmcgd2Ugd2FudA0K DQpJZiB0aGVyZSBpcyBhIHJlYXNvbmFibGUganVzdGlmaWNhdGlvbiBmb3Igd2h5IHdlIHdhbnQg bm8gbG9nZ2luZyB0aHJvdWdoIHRoZSBjb25zb2xlIHRoZW4gZGl0Y2ggdGhlIGNvbW1lbnRzLg0K DQogICBQYXVsDQoNCj4gICANCj4gICBzdGF0aWMgRk9SQ0VJTkxJTkUgUFZPSUQNCj4gICBfX0Ry aXZlckFsbG9jYXRlKA0KPiANCg0KDQo= From win-pv-devel-bounces@lists.xenproject.org Tue Jul 13 08:55:26 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 13 Jul 2021 08:55:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.155185.286556 (Exim 4.92) (envelope-from ) id 1m3ECM-0006ml-2o; Tue, 13 Jul 2021 08:55:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 155185.286556; Tue, 13 Jul 2021 08:55:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3ECL-0006md-Vy; Tue, 13 Jul 2021 08:55:25 +0000 Received: by outflank-mailman (input) for mailman id 155185; Tue, 13 Jul 2021 08:55:24 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3ECK-0006mC-KX for win-pv-devel@lists.xenproject.org; Tue, 13 Jul 2021 08:55:24 +0000 Received: from mail-wr1-x435.google.com (unknown [2a00:1450:4864:20::435]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2937ac24-9db0-4dd0-b245-f8a01a5a8976; Tue, 13 Jul 2021 08:55:23 +0000 (UTC) Received: by mail-wr1-x435.google.com with SMTP id f17so29449850wrt.6 for ; Tue, 13 Jul 2021 01:55:23 -0700 (PDT) Received: from [192.168.1.186] (host86-143-223-59.range86-143.btcentralplus.com. [86.143.223.59]) by smtp.gmail.com with ESMTPSA id s24sm17873535wra.33.2021.07.13.01.55.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jul 2021 01:55:22 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 2937ac24-9db0-4dd0-b245-f8a01a5a8976 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=KMayfFDiaCqkaNLYHIWAMAQlsY04qi/IOB74zHfxMU8=; b=rqpftS2f7IJAvWZo8u96lruAfjFHNSZaIEnjIgOz2l1i/+X0gOZLYhKw88zg0Hd+qo Zx5xX+00gyjzTkjubm05/ADUGM35yTFBsD7L7wKmoFhbmsiX7I5LQ7pvYS2jcXYXMkqH 1C66Bt7L6RHuIufsrb10ntxF3NIcL/A3X65+ecqgEQPGTw6PMW5RZqHuGLGNbMdiSjqi cN0qaD1+qDOAacNx+6AFt/6OBjf76VPgbXDAh6yqP99WHa8ljN3bqxoqr79QVlhtQxzJ zShhY0QD/f/9e2na7p6VcP386gPqWbzrIZrxypRohg5Oo41K8WCcclBu11q/PWj/D3VD WsmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KMayfFDiaCqkaNLYHIWAMAQlsY04qi/IOB74zHfxMU8=; b=bbAS3h3scI7LD1b01XQRqmX7BopSDuKnBtKeF+SXkMZUFHEHRlUPHs34xQOmGaaqIG h7OeJQLjSUEwZ8dGcyT3fkZHtV7psc8PAXnGHvWQd9K+30DAI1Xu1tErRmu6sio/JskJ eYt6/EVr80KSKgBT4hKtH9RjyGlmKYM4xHr9LCIT5g0sRdaGXVVzocu5f9oAOMKxAldi m3XZfQR17YlWb68gBzORFZYG2qi2d0NtWi9BPPq+IDF4JX68wQg6l3RLC/OhS7hUo8pE 8h2nHwypy+b8Pf640bEUGZLzkAXivR+aWPKiOGUrYMTlKgAOiBFaBiLKqIJMTnUE6DrJ wWAQ== X-Gm-Message-State: AOAM531Ug28pDIuK7YHV6ghEaiO4+C8NoTO/hDAzPowATWT7kBU6+vig cLLExbh1zoNwS8IMQ5BzUly9HFcaUoI= X-Google-Smtp-Source: ABdhPJxsI1AXKLCoVH0zhHyJqzBbVWsWnQcg3bL2ZjJahs+JbsSLKhC9mv07IfUSwZAA+ktKLMP7rg== X-Received: by 2002:a5d:410b:: with SMTP id l11mr4251105wrp.173.1626166523213; Tue, 13 Jul 2021 01:55:23 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH] Log module loading To: Martin Harvey , "win-pv-devel@lists.xenproject.org" References: <20210707085456.1826-1-Martin.Harvey@citrix.com> Message-ID: <897a8f97-2fe1-4b0d-49cc-91fc83e2121e@xen.org> Date: Tue, 13 Jul 2021 09:55:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 13/07/2021 09:39, Martin Harvey wrote: > > I note that very close to the debug print that was changed, we have INSERT_BEFORE and INSERT_AFTER macros. The positioning and existence of them there seems a bit crazy - double linked list handling seems to be a general thing that should either be handled by nt!Rtl___, nt!Ex___, or put in a common file. > That sounds sensible. Please feel free to make this common code. Paul > MH. > > -----Original Message----- > From: win-pv-devel On Behalf Of Paul Durrant > Sent: 12 July 2021 20:00 > To: win-pv-devel@lists.xenproject.org > Subject: Re: [PATCH] Log module loading > > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments unless you have verified the sender and know the content is safe. > > On 07/07/2021 09:54, Martin Harvey wrote: >> From: Paul Durrant >> >> Signed-off-by: Paul Durrant >> --- >> src/xen/module.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/src/xen/module.c b/src/xen/module.c index >> 584a63d..9c4a5ea 100644 >> --- a/src/xen/module.c >> +++ b/src/xen/module.c >> @@ -145,6 +145,11 @@ ModuleAdd( >> BOOLEAN After; >> NTSTATUS status; >> >> + Info("%p - %p [%s]\n", > > Not necessarily sure we want to log at this level in the general case. I think it would be reasonable for this to be a debug log line. > > Paul > >> + Start, >> + Start + Size - 1, >> + Name); >> + >> New = __ModuleAllocate(sizeof (MODULE)); >> >> status = STATUS_NO_MEMORY; >> > > From win-pv-devel-bounces@lists.xenproject.org Tue Jul 13 08:56:54 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 13 Jul 2021 08:56:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.155197.286560 (Exim 4.92) (envelope-from ) id 1m3EDm-0006zF-7w; Tue, 13 Jul 2021 08:56:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 155197.286560; Tue, 13 Jul 2021 08:56:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3EDm-0006z8-4n; Tue, 13 Jul 2021 08:56:54 +0000 Received: by outflank-mailman (input) for mailman id 155197; Tue, 13 Jul 2021 08:56:53 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3EDk-0006z2-Us for win-pv-devel@lists.xenproject.org; Tue, 13 Jul 2021 08:56:52 +0000 Received: from mail-wm1-x335.google.com (unknown [2a00:1450:4864:20::335]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a35b62f1-d93b-4b08-9fb3-cd8833c0887f; Tue, 13 Jul 2021 08:56:52 +0000 (UTC) Received: by mail-wm1-x335.google.com with SMTP id a5-20020a7bc1c50000b02901e3bbe0939bso1812188wmj.0 for ; Tue, 13 Jul 2021 01:56:52 -0700 (PDT) Received: from [192.168.1.186] (host86-143-223-59.range86-143.btcentralplus.com. [86.143.223.59]) by smtp.gmail.com with ESMTPSA id z11sm17290013wru.65.2021.07.13.01.56.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jul 2021 01:56:51 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: a35b62f1-d93b-4b08-9fb3-cd8833c0887f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ndJQZFiGG6d2I7+6snqt+w4x+D3HuzCdcSIpZRbl7r0=; b=jrL1OpbtvBUyUlFoRsAY3ml8fasHKzwsquOyU6XeYZ4Rcj3oHFt/lJ959t1/krHuc1 548tQhqIb/gcxyCgFV0ULzPlrCqcqIPY93BcMWp1V7Jz5C3d6zEx9yC3OU4Y6yKGCict /PAW0ZpnXJfcc/IRfr72ubM/nm9mwH0v8Qq8Jl6kbbv9qcmho/sqkEh+w0mizRQtJf6T X3lbhSpy58EuNps7CRCnU1tZPf5dDvaQ/7RAG2ezslBw0d+UwMoYxAoF4Ai6PUXB0eAJ FFWL4eXPNGWOjoVoDaKILOYe05d2oMWFSh2kmFLfAOp54tblu65hKkFqiAUIzlGsDz1v t2nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ndJQZFiGG6d2I7+6snqt+w4x+D3HuzCdcSIpZRbl7r0=; b=XPxQnmA/oacJDGwObb6ta0CUubkYUQV9SjKL9tf6g9FH43/eu2QySTvvfhiBZasREa VZw42qVDMI98SPmd6P71CEsJ8TUZaaYHCSsJaSvhyKq1Mzd8xtRgjbyaCOpwEZmrOLx+ Mh9f1mEXvHfwKsTk6fF4bYfHjpKqe1iaicZuYqiaTxklsxrLVihxxICEMhPMKkQzr+DL xp8G46Pp8J+NrWpsvaMiBuHnzXuTH1TDNXXiHp9oJ59s5ksBztNH4NAG+jf3FSvd5SMh Yb988yk7DbJa4Ym1QXS0KRJK7CooxagmXHhIZV375YJHUT6T6mI3vpR0rZnfFn5jtZJ4 PvWg== X-Gm-Message-State: AOAM533TRKZg7jC2jT0/pHJMh28rSGCH45uV38gyS/tidDBEBvG4emeY JaLfb+j57MmV1lZmpgeTRPg/87BdO2w= X-Google-Smtp-Source: ABdhPJzsO+DVV/He1oTaHpv8vRUBCCnj4vJqR9NfGzGU93tb/M/LTZlKjY2xfDIcjJBam5/SJ0rwIQ== X-Received: by 2002:a05:600c:4896:: with SMTP id j22mr3724084wmp.43.1626166611342; Tue, 13 Jul 2021 01:56:51 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH] Disable CONS debug logging To: Martin Harvey , "win-pv-devel@lists.xenproject.org" References: <20210707085456.1826-1-Martin.Harvey@citrix.com> <20210707085456.1826-3-Martin.Harvey@citrix.com> <7074bcda-ec68-01eb-a519-88c3447efa47@xen.org> Message-ID: Date: Tue, 13 Jul 2021 09:56:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 13/07/2021 09:55, Martin Harvey wrote: > > I believe this was originally to prevent some spam filling up the log. Some antivirus product / filter driver was sending some PnP query IRP down the stack, which filled up the logs. Owen should be able to provide more info. > > Agree with code in comments. Would something like this be better? > > //Was INFO, WARNING, ERROR, CRITICAL until reduced > I don't think we actually need any comment in the code, as long as we have an explanation in the commit comment (since git blame can be used to discover that fairly easily). Paul > MH. > > -----Original Message----- > From: win-pv-devel On Behalf Of Paul Durrant > Sent: 12 July 2021 20:09 > To: win-pv-devel@lists.xenproject.org > Subject: Re: [PATCH] Disable CONS debug logging > > a) Why? > >> Signed-off-by: Owen Smith >> --- >> src/xenbus/driver.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/src/xenbus/driver.c b/src/xenbus/driver.c index >> 1b621fa..f353a61 100644 >> --- a/src/xenbus/driver.c >> +++ b/src/xenbus/driver.c >> @@ -58,10 +58,10 @@ typedef struct _XENBUS_DRIVER { >> static XENBUS_DRIVER Driver; >> >> #define XENBUS_DRIVER_TAG 'VIRD' >> -#define DEFAULT_CONSOLE_LOG_LEVEL (LOG_LEVEL_INFO | \ >> - LOG_LEVEL_WARNING | \ >> - LOG_LEVEL_ERROR | \ >> - LOG_LEVEL_CRITICAL) >> +#define DEFAULT_CONSOLE_LOG_LEVEL 0 // (LOG_LEVEL_INFO | \ >> + // LOG_LEVEL_WARNING | \ >> + // LOG_LEVEL_ERROR | \ >> + // LOG_LEVEL_CRITICAL) > > b) Leaving code in comments like this is not something we want > > If there is a reasonable justification for why we want no logging through the console then ditch the comments. > > Paul > >> >> static FORCEINLINE PVOID >> __DriverAllocate( >> > > From win-pv-devel-bounces@lists.xenproject.org Tue Jul 13 08:58:00 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 13 Jul 2021 08:58:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.155204.286564 (Exim 4.92) (envelope-from ) id 1m3EEq-000740-Bw; Tue, 13 Jul 2021 08:58:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 155204.286564; Tue, 13 Jul 2021 08:58:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3EEq-00073t-8s; Tue, 13 Jul 2021 08:58:00 +0000 Received: by outflank-mailman (input) for mailman id 155204; Tue, 13 Jul 2021 08:57:58 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3EEo-00073n-9J for win-pv-devel@lists.xenproject.org; Tue, 13 Jul 2021 08:57:58 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6a7fb4e7-e3b8-11eb-872e-12813bfff9fa; Tue, 13 Jul 2021 08:57:57 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 6a7fb4e7-e3b8-11eb-872e-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626166677; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=ey6tWUBf3l93WNk/2F5KHi8EFE43LFEznlgnjuhQJR8=; b=BjaSUh6Q5FpoWopmNd0gYhzdnV2iMxCNvDQeyVJXsYhHujg8a808+1EJ V9s5Ra5aRspVyqvy7iToZSdbOldwev9ntKM4SinhXvmmj2TaKbV/oIvYs HWTFjWVILajQwWnJCXPRCQMmv99eW4gOKv1R42dw8LWnWJH91Wx/5uMof 4=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: mRiYIgr1bfwAaw0v9E0tKUmb9N/kHQWh10Ei0ogq99Ke4r6u9pDNZmKHfotr/pchaoh2Y5J3OD cUQwxrdSz2veKA0zO1sBhAZTqhjn4MkvzVYNCoPLvXukdw1JK1J9OiuQY3XbFR/QKFQePtFq6P kYvFOw4g2RedvvtK3PgHZn0SHU0WR6s8mzAhZjV2GacAcgBkAS3YwSmzyyM7XPLLL7OS55xNOO xeInfiQ/SBbDofDq7MiwzSjHXgt5BMnl3iUqy3PfYl+hayImNWmaEBp2UEjGhtdml7XHQtpj8r KDo= X-SBRS: 5.1 X-MesageID: 48142470 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:abyBQauhp/z5Id7qhpgUr5C07skDjNV00zEX/kB9WHVpm6yj+v xGUs566faUskd0ZJhEo7q90ca7Lk80maQa3WBzB8bGYOCFghrKEGgK1+KLrwEIcxeUygc379 YDT0ERMrzN5VgRt7eG3OG7eexQvOVuJsqT9JjjJ3QGd3AVV0l5hT0JbTpyiidNNXJ77ZxSLu v72uN34wCOVF4wdcqBCnwMT4H41qf2fMKPW29+O/Y/gjP+9Q+V1A== X-IronPort-AV: E=Sophos;i="5.84,236,1620705600"; d="scan'208";a="48142470" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n66JIi+9aV5262FvQ0sU9zLeDlgWyL3JvZIHrZNZyUCltxmlXmvwMneRpcS6n6UhEm04JiciKlqN7tfGjLLFkckhIFvAkkCbsOsM8KWLsyfSdGdgTENpysrKBhZLbgoAkoo+xor+b/qwK6jQh1MFoZQxE482cyeurHOnGU+fpmVbKI4ew6zsTrMgTmFmx/MK76zR1W4+qONS6v11gszjv5u6K1gdmmZ9Jrj88e3Bi9zo8UyXqjhJo3a15SthkxrD4OWEcPY2AA7CzeYz5ipN/cXzR2TDBBe9xYUFYtyaLhPcb8iqyB4WfjTgWoTwqLak1gUDwA2ujte/RyOub8c7Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ey6tWUBf3l93WNk/2F5KHi8EFE43LFEznlgnjuhQJR8=; b=Y+3C8D1gd3QZOtZRVKoKjPA9akDGtk9ztF7hmi6F+QM1pMiyAzuZSwLhFASoVc5wQuwPfQXcageLWN7J2mEo1X5+vK+zz86vXQ19Dtm3aAK2rzac0QoHt25qE5kUrk/q4xMHmIlma4lUbxoxC1x+HBmtNDkv3W3pLMyhfEnq0hulz7qBZ9idhtF7KYdGCYFLdXera5muxWcWlmaQ2k7fJjup/uwWx5yIDeV0cCBnVAG0b8EAxjlwdMYSAku5AyMdXz5pCm5uSIyVSu5XCe0Cq8kFUmsIBdh252RnwZ+pECysKqwgC3txGqpzqWhrb5AvvcERjVwlaVpuG7J/NhPWVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ey6tWUBf3l93WNk/2F5KHi8EFE43LFEznlgnjuhQJR8=; b=RK1cu2IFWbhgYc1esisdD0nzJODWhGrzkrcGlSdpIPcNsoNoWCfa4CNCZk7KoiwXT1ajLuH9k5fSaRJXVXCWnNEidUblKzkrjiZXb25lcvLWX2HQ6e3jOa675w+RrJ3dsxoh2UdMWh/3yM1Hq5Qi0R/HfHy+6y4AlMke7LMkZl4= From: Martin Harvey To: "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Subject: RE: [PATCH] Change AllocatePage to use ExAllocatePoolWithTag Thread-Topic: [PATCH] Change AllocatePage to use ExAllocatePoolWithTag Thread-Index: AQHXcw87fHf7Qwb5uU2wdCPUfVSNNKs/vOyAgADmxIA= Date: Tue, 13 Jul 2021 08:57:53 +0000 Message-ID: References: <20210707085456.1826-1-Martin.Harvey@citrix.com> <20210707085456.1826-4-Martin.Harvey@citrix.com> <1d843f4b-5e9c-903e-e0d3-bbf92cf9b57e@xen.org> In-Reply-To: <1d843f4b-5e9c-903e-e0d3-bbf92cf9b57e@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bdf650e6-b316-454b-a457-08d945dc4cba x-ms-traffictypediagnostic: MWHPR03MB3006: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eseJB1P5WMmMLpe6e6+l6Kptf+gu1awPRyPR5aAAwjSFZcDmE4A3qZPjI31IgQZEaFyKBOywvQgtpC/KJi12i9vcxtnPVBmHKka3ou3F951TSA308lYG6hZEHx8qlrCrrhc9L8eL1bDfvMIZ1biuA21Gw33QU4kH1MA/SRyQM+nml/8NkjJAMXTFXBjelt0aa8vhwz6/SGen5srnPcRzYkNg3r3Wq4M/+albVRUQKjKKdPzAlAoJIjBTVBS20xmVWwVhwBThJQQjo/10+PJu81hW5oxHaDUR7vScIe1I+LRLcMnVM2lTRXhUackpp3hlxH4A6l3SdYknxCRbDtC8eDSLRnf3LrZbyQyTWjqQ/2oE6w/Y7pq7HoVN1sUvz6SLRtvBC3nxBNHp4pHT135Uxld8W2l0EYreBYFGsHOBSiqvctynMtZ5HVyPEmouXgao68b2FcEFO54we1SH2p5MV8HbGHGQGlI9wsloN4/GXLJCeeAV5d7IojHaH8RBxHzQS94Aa6OEb/DfrKpa7qG3FDMST7rOld6lKMwi95iJ0B1sYSPUJS/CSAbWov5EOHmSFTcNjwG0RHjp9xAsYol1aOxMkYRPKZyS2iNQz4oEbUzeKM3hWxL+wPEorYr+GgzCtM4vRDyWJA9CKSQIg7gS+Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6347.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(366004)(396003)(136003)(39860400002)(346002)(376002)(64756008)(66476007)(76116006)(186003)(5660300002)(66556008)(66446008)(478600001)(83380400001)(71200400001)(38100700002)(66946007)(26005)(6506007)(55016002)(53546011)(7696005)(9686003)(86362001)(33656002)(52536014)(110136005)(316002)(8676002)(122000001)(44832011)(8936002)(2906002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NEY3Rm5IMUU0VFpIamFobklKVmdZbHV4NWRyS0Y2TGpYdFNBNWlRTWlHejJD?= =?utf-8?B?aHc3SmsvVy9JY1AwLzIvMHJWWVVTT3VYTkx3aE01VTEzK1lnUGRSTFhkZWhD?= =?utf-8?B?TzV0YWk0L1V4c0cxM2xZTFd4VW1uS0JhWW5TQndrTi9pdFVNNS9rRit3N2Ni?= =?utf-8?B?LzczcHZ6UDRzMngwZC9LUE9Oc0s3WGFFVy91TWVJRTBjbnRzVGhieTFaZTQv?= =?utf-8?B?NzNncnI0eFd1UXJJNTZCRndnNDRubWVZMTBhT1VnSHMydk0vL3JNUG9GOXNh?= =?utf-8?B?SEJ5STg4OExVZVFaZTdFS3l3U29NWWZsSEJzMUVTa2p6M2l4eVBVb2F3RUhj?= =?utf-8?B?cEs1Z0VkSEVENGRCd0hlV0htUDlreVplN25uY1F4YUhUVHB1TTloODRqV2dV?= =?utf-8?B?NUplTnMwMUhnOTdORDRPN2F1UlVWZ29iNUFWYXI3ZitjZGM1YzJYZmJzQXFH?= =?utf-8?B?L3NkT3k5Z2lJQkl4ZVRDTktPcjRCb0xlb2NpZW9LQmNpK1ViYlArY0N2UkVy?= =?utf-8?B?cFpzTCsrUHdEZTF3WVZkOFArVnRiRjMzb1h2b0xSK2s0WGQ2R0F6dEhsbmdw?= =?utf-8?B?RjA4VkwxazZHT1d4aXFsdFRFTzY0KzNUeVRKQzBaWWJnSFhpaVNxZ0g5K05F?= =?utf-8?B?Vk9wdEJiZjhWQlp1KzFVbHNRZ1NBNGhzN3VhTnFFN1VrOCs1cUVLNXh1VTJ0?= =?utf-8?B?M1JYYTBhU2pXZlVnblFpbXlpdGNrVGVrS01qN1lFaGp5VHlaNjZ0UXZEYnhn?= =?utf-8?B?bEpsUVBjQ1A0eHRqOUZDbkZOZWNnOHNIVEJ0dFkyTlg5cytRMTZVQWtDUFAx?= =?utf-8?B?VmVRZlZ3RUJaeGN2NnpOSnlsN3BJanRRNGVzaUJuVTZZc1phNUxGbXNWdU1q?= =?utf-8?B?SVhiVmc3OHdRSlpWZFB3S0tnR2hOMThXeHZqOWJscjFqdld4S3R6ZXhnb0Fs?= =?utf-8?B?YTEwZGpET0RSOFRRL3pxTmUzZXZlWm1NdGVpMkpVd3ZPSFNQcS9lY28yZEs4?= =?utf-8?B?MC9WOTRkZTZnKzlsdUdaZzZCdytEZ0h1Q2lDM1lWMm4vaWtUYzFQdjkwQTBl?= =?utf-8?B?QkNzYUE4Y1ZUeEpSOHVJYXFRRjJYdnNtTUYwWFhTclVnZiszaFdlK0M1cVdh?= =?utf-8?B?ZTVWd3YwUFROZkZ4UDhHKzhtQ3hWS0hPcDBaeGRTbkg0cDZOc2NMNzB5S2xM?= =?utf-8?B?cDN0R0p6M2czQlh5NG4zUjE4aTl2RU5qV3owRElYckhFUy9kcDArVG5XbE1W?= =?utf-8?B?S0xURVI3akVpTUtNa1c1RzdvdXdsTWE2eEYrRDNRV2NoaHM4em8wbGxDZ29w?= =?utf-8?B?SW96em1EM0JXem5DUnJNNGNvU0RKYk5Ub3QxSDQzV2wxNlcyK1pJZTFxcmhN?= =?utf-8?B?U201WHFjMjN6MVlCdklGSHFWU0pNYklONnBNNExoZlhOWXo4YXpaZ291VU5q?= =?utf-8?B?L01TMnNtdnc2SkQyTTZFL2RIdHI1TGoxYjZyU1puT3VHMGxZWTU5TDVIRy9L?= =?utf-8?B?WkxHMGd5S1pvdlVYUmdXRGk0RC81NTk2RU4rQVJJWG1BVENQc0ZTd0tETXFO?= =?utf-8?B?OW4wU1hGRHlqdkVRd3I3cFQ4Z2Ixblc0alZNWUFEWmU5NjRjN3B4R2QyNTV4?= =?utf-8?B?L0xDVTFFZnphSU9FWmI5ZUg0dUdXWWFROUlKc0VneDRDMXA0Y2dNRDJQMlZS?= =?utf-8?B?UEpER0ZsTVZJZ3F4cE5kbTd4RXdualZCNWtZeW1xSVk5U2FqMm9say9kaXhP?= =?utf-8?Q?Yu4EfQvWSaAIXyrvJjMtayq/LHNSRkAHpmFq9H0?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6347.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bdf650e6-b316-454b-a457-08d945dc4cba X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2021 08:57:53.0843 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: M3CSw72ZcLMpJkDhlbO94E4KJ+T+ICSuQFwPBjSszI9H3sNzxUulye8798lBZWnmxFUnj9j04KmSPgVFUG8MX62WcxEgB1e65MrSlON3zy8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB3006 X-OriginatorOrg: citrix.com DQpBcyBJIHVuZGVyc3RhbmQgaXQsIGl0IGlzIGZpeGVkLiBXZSd2ZSBoYWQgc29tZSBoZWxwZnVs IHNpZGUtZWZmZWN0cyB3aXRoIHJlc3BlY3QgdG8gdGhlIGNoYW5nZSBpbiB0aGF0IGl0J3MgZWFz aWVyIHRvIGtlZXAgdHJhY2sgb2YgeGVuYnVzIGNhY2hlIG1lbW9yeSBhbGxvY2F0aW9uIGFuZCBz dWNoIGxpa2UuIFVuZGVyIHZlcnkgaGlnaCBsb2FkLCB0aGUgaGF2ZSBiZWVuIHNvbWUgYml6emFy ZSBsb2NrdXBzIHdoZXJlIHRoZSBNbSBjYWxsIHRha2VzIGFnZXMgdG8gY29tcGxldGUuIEFsbG9j YXRpbmcgZnJvbSBwb29sIGhhcyBzbGlnaHRseSBhbWVsaW9yYXRlZCB0aGlzIChwb29sIGNhbGxz IGp1c3QgZmFpbCksIGJ1dCBvbiB0aGUgb3RoZXIgaGFuZCwgcnVubmluZyB0aGUgbWFjaGluZSBs b3cgb24gcG9vbCBleHBvc2VzIGJ1Z3MgaW4gdGhpcmQgcGFydHkgZHJpdmVycy4NCg0KTUguDQoN Ci0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiB3aW4tcHYtZGV2ZWwgPHdpbi1wdi1k ZXZlbC1ib3VuY2VzQGxpc3RzLnhlbnByb2plY3Qub3JnPiBPbiBCZWhhbGYgT2YgUGF1bCBEdXJy YW50DQpTZW50OiAxMiBKdWx5IDIwMjEgMjA6MTANClRvOiB3aW4tcHYtZGV2ZWxAbGlzdHMueGVu cHJvamVjdC5vcmcNClN1YmplY3Q6IFJlOiBbUEFUQ0hdIENoYW5nZSBBbGxvY2F0ZVBhZ2UgdG8g dXNlIEV4QWxsb2NhdGVQb29sV2l0aFRhZw0KDQpbQ0FVVElPTiAtIEVYVEVSTkFMIEVNQUlMXSBE TyBOT1QgcmVwbHksIGNsaWNrIGxpbmtzLCBvciBvcGVuIGF0dGFjaG1lbnRzIHVubGVzcyB5b3Ug aGF2ZSB2ZXJpZmllZCB0aGUgc2VuZGVyIGFuZCBrbm93IHRoZSBjb250ZW50IGlzIHNhZmUuDQoN Ck9uIDA3LzA3LzIwMjEgMDk6NTQsIE1hcnRpbiBIYXJ2ZXkgd3JvdGU6DQo+IEZyb206IE93ZW4g U21pdGggPG93ZW4uc21pdGhAY2l0cml4LmNvbT4NCj4gDQo+IFdpbmRvd3MgYXBwZWFycyB0byBo YXZlIGFuIGVkZ2UgY2FzZSBidWcgaW4gd2hpY2ggemVyb2luZyBtZW1vcnkgdXNpbmcgDQo+IE1t QWxsb2NhdGVQQWdlc0Zvck1kbEV4ICh3aGljaCBpbiBXaW4gMTAgMTgwMyBoYXBwZW5zIGV2ZW4g aWYgeW91IA0KPiBzcGVjaWZ5IE1NX0RPTlRfWkVST19BTExPQ0FUSU9OKSBjYW4gY2F1c2UgYSBC U09EIDEzOSAxZS4NCg0KSXQgaXMgbXkgdW5kZXJzdGFuZGluZyB0aGF0IHRoaXMgYnVnIHdhcyBm aXhlZC4gSXMgdGhpcyBub3QgdGhlIGNhc2U/DQoNCiAgIFBhdWwNCg0K From win-pv-devel-bounces@lists.xenproject.org Tue Jul 13 08:58:43 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 13 Jul 2021 08:58:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.155209.286567 (Exim 4.92) (envelope-from ) id 1m3EFX-0007AG-Et; Tue, 13 Jul 2021 08:58:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 155209.286567; Tue, 13 Jul 2021 08:58:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3EFX-0007A9-Bn; Tue, 13 Jul 2021 08:58:43 +0000 Received: by outflank-mailman (input) for mailman id 155209; Tue, 13 Jul 2021 08:58:41 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3EFV-0007A3-PU for win-pv-devel@lists.xenproject.org; Tue, 13 Jul 2021 08:58:41 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3e2fabb6-c111-45a7-88fa-af702f884518; Tue, 13 Jul 2021 08:58:41 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 3e2fabb6-c111-45a7-88fa-af702f884518 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626166721; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=s7oCNTLbsS30N2k4Mae28Z3IuMeR4VY0scnQhHTfr/0=; b=Hw78ud+BRpXqmJUru9Uz7E2ApiNHXxdSKHImt8HjOQRMMWsPRra0CIaI wfhGRT1vjzmC7S3A0X5ISUfQfFYBl7kAePZNq4CcZbKzadeMf71CWLjbA hYS5igkNV66AuKw+TRMuQ1Gp6X8IPVpnq1ckR+gJrfHhrhgZ5DGQSAMT+ I=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: jR5PO8MEQ4ptLw/hmuvYNm5UODO32s3tzN1gWvndsvvgv5Z2C0U7COG0Emfv1nMdXCDWESdBfu CB/vhmtfzvnNNng9ly6WCv/aQv+l/NqAgUug/JbtlFPi3q9kXh6QKWsrjo8ZiZrSZLNLUGFOvi 57t4jlgqij9msvnnW92Lp0YJl9kHXdgb1gs7j3ITxOA9BDyaihoDI/Z5l9XR8THUywVJYBxGla ALgKaOrogM1HuP3y3nQinBDqsv2ppVe2OO9jUcri5Y+RehqiJT9m+CkaYq7kJ4WKZENzc9fgDq q/Y= X-SBRS: 5.1 X-MesageID: 47834650 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:hfRQm6gpwaHoreZzec/SOlg/yHBQX0913DAbv31ZSRFFG/FwyP rBoB1L73DJYWgqNE3IwerwRZVoMkmsiaKdhrNhcotKPTOW9FdASbsC0WKM+UyYJ8STzJ8+6U 4kSdkFNDSSNyk1sS+Z2njBLz9I+rDum8rE5Za8854ud3AQV0gJ1XYgNu/xKDwTeOAyP+teKH Pq3Lshm9PPQwVzUu2LQl0+G8TTrdzCk5zrJTQcAQQ81QWIhTS0rJbnDhmxxH4lInJy6IZn1V KAvx3y562lvf3+4ATbzXXv45Nfn8ak4sdfBfaLltMeJlzX+0aVjcVaKv6/VQIO0aSSAWUR4Z 3xStAbToNOAkbqDyOISN3Wqk/dOXgVmibfIBSj8ATeSITCNUwH4ox69Nlkm1LimjsdlcA536 RR022DsZ1LSRvGgSTm/tDNEwpnj0yuvBMZ4KYuZlFkIP0jgYVq3MUiFYJuYeI9NTO/7JpiHP hlDcna6voTeVSGb2rBtm0qxNC3RHw8EhqPX0BH46WuonJrtWE8y1FdyN0Un38G+p54Q55Y5/ 7cOqAtkL1VVMcZYa90Ge9ES8qqDW7GRw7KLQupUB/a/WE8SgXwQrvMkfgIDc2RCe81JaoJ6e D8uQljxB4PkmrVeL+z4KE= X-IronPort-AV: E=Sophos;i="5.84,236,1620705600"; d="scan'208";a="47834650" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eR8pdy4nSZ2B6ZPqYbMtcvm4ON/oudTI/8DBZCPTt+oL1G0yoYn+os4fBB63Yp5O4Kg8FBgdDaY1Yo1x+KMkLhuM1GYgCWyXq++yimjrH1+P64uTBhNUS3cJAzQQ40eZOtXhk1ERLeWFcJnpskIzY85GVCXBSIrB7adfECDsHGKgtfcdDJYpUDgpZ/zwD0TyqebBGOthJ98s7fsA+EHb9CK+KG/hSyBHoFtMclOIbd5BbhAWMfvnYl2EvSj7kFMU5hwuqrm40Pyz+zEQYY7Khx+2XiC0i0Cnvhsqxnzuq4+mMuUwzx4HnlUihikQesdF2as7FIZUHdxDN0o+/3uoMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s7oCNTLbsS30N2k4Mae28Z3IuMeR4VY0scnQhHTfr/0=; b=iQEOGpGsWFlY33IwzE39xQzsll38vyKSp4ST0fEQzp79M7fZGpPd10q90ODSklq5vRcqG5cMcl1MVVHzMNawhGu9BKckyerjM+JfNb/cscNiBWu9bvVdaOEvYuNs0110cFNAEjC7Zd+X+rcaXQtRZY0ayqeF/PiUbBdAC8pH0pf98ZUC0uggyLHiJWkyrooJVf3aZ301xv8hsc8b+wvHs18wJ4JBzTHA9p1Dhg/n2m6oCpl0bIrluGddYVyjvDKg1ix3rhaWS0LYRWjySRIyqBUJ6xBpbZRZjfiUyJAiC0n5oIVElv7j1KrG4fArJQ+/O7QcxWpk8hP5f0veU9KI2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s7oCNTLbsS30N2k4Mae28Z3IuMeR4VY0scnQhHTfr/0=; b=u0mr64fHfa7fCUCydhXXRCva/D5pHZ6MscYa9sK8ultLgUqIr2jQZmdOKNuDPWgbOVR6XXn/Ue48Fs3QI493PVJnNg18efw78iy6ovCylFpWc5iwhbmw8mFV2HhvHb0rGAHxcb47QLkHQpzsnfDXn7BfGGFXhfQylCQZjjzGSwo= From: Martin Harvey To: "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Subject: RE: [PATCH] Change AllocatePage to use ExAllocatePoolWithTag Thread-Topic: [PATCH] Change AllocatePage to use ExAllocatePoolWithTag Thread-Index: AQHXcw87fHf7Qwb5uU2wdCPUfVSNNKs/vOyAgADnUNA= Date: Tue, 13 Jul 2021 08:58:32 +0000 Message-ID: References: <20210707085456.1826-1-Martin.Harvey@citrix.com> <20210707085456.1826-4-Martin.Harvey@citrix.com> <1d843f4b-5e9c-903e-e0d3-bbf92cf9b57e@xen.org> In-Reply-To: <1d843f4b-5e9c-903e-e0d3-bbf92cf9b57e@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 851da260-d285-4a5c-0d01-08d945dc63f1 x-ms-traffictypediagnostic: MWHPR03MB3006: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0cGHg60WVvneD0lJxtUnonrhWGEYLiLEncbPfJDVItB8Rh6RY/Gb0gqeaUaFOtNqXWaAQiYYCgE5wTK1iYQhZ8ZoGUZ4nA/ZHk1TeLD89hG6fS7HocDiU0JexFvv9XpAiBrovk27FDofVU7/oo952Um0+yH+oZAxpTOoUKkj4ZLyJakYRvmnSYMXSrV57ulrSJLJyu7O7QChLycDbtCKAMTj/vBHE+s0a6qSJV486Cd0dBVFS1ldecm+l9mLpXa/Spk7CVCI55L5QF522UGwkXRTSeg15ISmGsX8JKT+KELpixzLn9WcTCF8BtBS22kXfjuLoLzTwmXHFsFQllhvBzyJvdcswq7QwEGpybZ1RjOt55sxkl/nksmzNG1trCih+MbwMNjz1qU8QIR2cdIBwC/RSid8Y2pKS+7nTZtYURO+cqU0+pPyefGrjmS4UeszDaeHur/NDAlFjOWpNf69fMA1XWk8r2tnklquxc9vyHukl625jrl7tSd7B8Hq+2Qxv5IjqnxDiktpRDHh5pSZxLyIvrvHch8i+t3uQVeuogHRIHy9cXlJfeE/6K+I7bZvVnh+a00ccbOQ/u7SUv3dQwlDbhy03uIEbzrKR/WMhGth0WQyV7GS4it5/SPzqBG3+424lKDtI/ia2sW0TbRe7g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6347.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(366004)(396003)(136003)(39860400002)(346002)(376002)(64756008)(66476007)(76116006)(186003)(5660300002)(66556008)(66446008)(478600001)(83380400001)(71200400001)(38100700002)(66946007)(26005)(6506007)(55016002)(53546011)(7696005)(9686003)(86362001)(33656002)(4744005)(52536014)(110136005)(316002)(8676002)(122000001)(44832011)(8936002)(2906002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZjBTOE9JcHg4NkllSWxydExFMDd4NlVJTWlBRHpadG91WXNOUm5PdnBRZTh4?= =?utf-8?B?MzdqZUQwbkhCTG1wNDNhcnpVaWxTSlhGMTJJbysxZjBsc3ptMEtyYWtGcGx3?= =?utf-8?B?ZHlvejBqc1lOMTcyQ0wyV1BDd00ySnJCMUZCWWxSMFRqcWFtN05uTDh5MCsr?= =?utf-8?B?VVlsajhvL05kZnk5QU9SSW9vT3dybFBQRHN5NmZhTG1GaExrc0tBKzFxTVZz?= =?utf-8?B?c3JJQ0FBSzNWNVVkaVp6SGdoUmU5WHZGbG5wZkdKT09sbVllTyt3RnN6TFlP?= =?utf-8?B?NFdWSW1TejNVbXNtSUVDRnZDRkNWWWNvRXN3cmoxbjhHMjFVNG5iUmtoL0gr?= =?utf-8?B?UFdYUXRpL2c1WkJkSUFkWnI5MjRxTDB3QVZnbzkvQ3RwQXBsVjBIU1QrOGdV?= =?utf-8?B?Uml5YTFoU2tXUHZZQnB1NUhiaDVvTnVqbXVBNmhDNHlYVkhrcHV3b0NiRDh2?= =?utf-8?B?TnVUVTlNMmczdVZ0dnlIcWVRblZwemVSY09jNTJvc0NyOVRFMG9kYllVcXEr?= =?utf-8?B?c28xNGdNdHVUNCtteDZwWGUzWWtzTkNlbDB5Ym5BT3BIaVFob1IwclFRL1Rp?= =?utf-8?B?K2xqdjdBL3pOOExVaXVRWXUwOWhwUkhTVnFqa21TM2RKbHhnTjE3SXJYOTNW?= =?utf-8?B?MEdYWWd0Rm95V1pRdWNiSG0vaGpDZjlSOXFyM01ySTRXNWh5RHAzYjAySGFa?= =?utf-8?B?dER0dk16dTlIcnVHektjZDgzQWxjMnBDSlNXR2JaOE85VnZHS1BUcW5DUWJE?= =?utf-8?B?MzlmOXhtWEZYeVdXWEpvRFd6Vk9jTHptNEx0b3lWT2tkclFTbEpCa0pFR1pz?= =?utf-8?B?SHhiYkJaS3U1VzVZY294RFRPN0RURjcvTnNLWFJnVlRreXVHaDl1aHBNeWJh?= =?utf-8?B?MUJKZVZLNFVLMGxmcFMwOVFCWk1IQ2pQSWVIQmFLbmkzdFpWdEhkYXgvNXhz?= =?utf-8?B?dmoxWnNBRXRBK1lRcHFVUHliSzVJRVpHWDE3NjViL2Jrbi90TkVkbUtSR1Rr?= =?utf-8?B?ZXRETzMzV1JzU0dEaVo2LzVsZlRqTkk5Nk1MZ0k2N3pCL1FmSE5RSnR3eDlk?= =?utf-8?B?MUMrUncrcTE5TVNtUjAzQVVIZ29kK0Qxc0Nkdk5WRUM1b3pyTm5ULzErQjhz?= =?utf-8?B?VGI1alZUd2hGUEN4U1BiOWg3MzhiNEFNb3M0d29RTzBtTzNqbTJtS09lWTZ6?= =?utf-8?B?WHFxc2VWcDQ5V0dFRmhsMDAvVTcvcVZObCtUS0FvQ0h6TnZLTHhOcWllY1g2?= =?utf-8?B?RXlidS9HbDV4eHNHMmMwdGp4d2UwMFpsaTh0blVCZy9STnl2ZExxdnF3TitF?= =?utf-8?B?dHhjSlhLWWdqRzFRTnFEZ0lvY2xocTJrWkhEOWF2MmV6U2pvVlYxaTJEVkFi?= =?utf-8?B?YkE5TGhPQ3ZlNHZ4Tmora3kwUzVBeDFXWXhVb250b1MwRytlTGRPRTNUYlpY?= =?utf-8?B?K05LSDd1UVlYTjJUT1VCRnAxQmJlL25ZakpFR0hMdnRtMTVUSU55MlhENWx5?= =?utf-8?B?cDhjR3pyTE5HdXJaRS9zMHVNamR1b0JjdzVUSDFiRlMrWEs5aFBFa2FWdFha?= =?utf-8?B?WVZ4THI2aDdiTE5NNkJEQnE4UjJKdncrZllNSG9RNXN1eHRuWkRhMS9CejJ6?= =?utf-8?B?S2FZSDdYWVhTTmlYSk9GbGVsRlJzV24vU1c1ZFhUaUVUWDc1czBQMG1WZmxP?= =?utf-8?B?R3BBS1NOV0VTVnRVdnFoSi9tZlU1VUFnWVJXV0pHOUxjWlN4RXUyYm5kMWta?= =?utf-8?Q?xuraQecw9qzWYoSFRVE/5MFgVtBzYa+TSDCGRl/?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6347.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 851da260-d285-4a5c-0d01-08d945dc63f1 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2021 08:58:32.1001 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nFpHfPULp2Ic84VwJKDghNqTZBwlRf91ah8iJPoE2oQbrVI8HYRn2aLXF4cOkEi83IODTMEEXWQhJ7JFzG0mYoLDh9Dpnl9r6YrGKPeqANA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB3006 X-OriginatorOrg: citrix.com DQpOQi4gV2UgYWxzbyBoYXZlIGEgeGVudmlmIHBhdGNoIHdpdGggYSBjb3JyZXNwb25kaW5nIGNo YW5nZSB0aGF0IHdlIHdlcmUgZ29pbmcgdG8gcHVzaCB1cCwgc28gdGhpcyBpcyBhbGwgb3Igbm90 aGluZyBmb3IgYm90aCB4ZW5idXMgb3IgeGVudmlmLg0KDQpNSC4NCg0KLS0tLS1PcmlnaW5hbCBN ZXNzYWdlLS0tLS0NCkZyb206IHdpbi1wdi1kZXZlbCA8d2luLXB2LWRldmVsLWJvdW5jZXNAbGlz dHMueGVucHJvamVjdC5vcmc+IE9uIEJlaGFsZiBPZiBQYXVsIER1cnJhbnQNClNlbnQ6IDEyIEp1 bHkgMjAyMSAyMDoxMA0KVG86IHdpbi1wdi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KU3Vi amVjdDogUmU6IFtQQVRDSF0gQ2hhbmdlIEFsbG9jYXRlUGFnZSB0byB1c2UgRXhBbGxvY2F0ZVBv b2xXaXRoVGFnDQoNCltDQVVUSU9OIC0gRVhURVJOQUwgRU1BSUxdIERPIE5PVCByZXBseSwgY2xp Y2sgbGlua3MsIG9yIG9wZW4gYXR0YWNobWVudHMgdW5sZXNzIHlvdSBoYXZlIHZlcmlmaWVkIHRo ZSBzZW5kZXIgYW5kIGtub3cgdGhlIGNvbnRlbnQgaXMgc2FmZS4NCg0KT24gMDcvMDcvMjAyMSAw OTo1NCwgTWFydGluIEhhcnZleSB3cm90ZToNCj4gRnJvbTogT3dlbiBTbWl0aCA8b3dlbi5zbWl0 aEBjaXRyaXguY29tPg0KPiANCj4gV2luZG93cyBhcHBlYXJzIHRvIGhhdmUgYW4gZWRnZSBjYXNl IGJ1ZyBpbiB3aGljaCB6ZXJvaW5nIG1lbW9yeSB1c2luZyANCj4gTW1BbGxvY2F0ZVBBZ2VzRm9y TWRsRXggKHdoaWNoIGluIFdpbiAxMCAxODAzIGhhcHBlbnMgZXZlbiBpZiB5b3UgDQo+IHNwZWNp ZnkgTU1fRE9OVF9aRVJPX0FMTE9DQVRJT04pIGNhbiBjYXVzZSBhIEJTT0QgMTM5IDFlLg0KDQpJ dCBpcyBteSB1bmRlcnN0YW5kaW5nIHRoYXQgdGhpcyBidWcgd2FzIGZpeGVkLiBJcyB0aGlzIG5v dCB0aGUgY2FzZT8NCg0KICAgUGF1bA0KDQo= From win-pv-devel-bounces@lists.xenproject.org Tue Jul 13 10:23:59 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 13 Jul 2021 10:23:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.155280.286683 (Exim 4.92) (envelope-from ) id 1m3Fa1-0004Gw-EY; Tue, 13 Jul 2021 10:23:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 155280.286683; Tue, 13 Jul 2021 10:23:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3Fa1-0004Go-B6; Tue, 13 Jul 2021 10:23:57 +0000 Received: by outflank-mailman (input) for mailman id 155280; Tue, 13 Jul 2021 10:23:56 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3Fa0-0004Gi-K3 for win-pv-devel@lists.xenproject.org; Tue, 13 Jul 2021 10:23:56 +0000 Received: from mail-wr1-x42b.google.com (unknown [2a00:1450:4864:20::42b]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1f83076a-066e-4f61-852d-37380183ac35; Tue, 13 Jul 2021 10:23:56 +0000 (UTC) Received: by mail-wr1-x42b.google.com with SMTP id a13so29752378wrf.10 for ; Tue, 13 Jul 2021 03:23:55 -0700 (PDT) Received: from [192.168.1.186] (host86-143-223-59.range86-143.btcentralplus.com. [86.143.223.59]) by smtp.gmail.com with ESMTPSA id c10sm14895426wmb.40.2021.07.13.03.23.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jul 2021 03:23:54 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 1f83076a-066e-4f61-852d-37380183ac35 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=n2yujT3jczMSOlSPF2nBFzv6EErhLVXlhJ3euddlwbs=; b=hp9NsIM5+htcAKpVYMQMvSPH0y+mCPb5qmXzqM7sWSUubuQfSXXUbHVCxWVFud/WlV aK1vy9HY6JpJmX7AUEr1Ut2ff+eoe5xqD9I+TFpg+x6/785c4PdoEOh/8/L6neJjAiM0 uzNjShSd8L7ftYuFn5YUsFd/46sQdu46DC86F0G8C+2Fnzo42EZNOBjh0OgXih8Htpta 1jYREtaxzT8Dn89Bq9gR/6gfdfEplH/ptYcDXaNS7UttzDG2yZ/aGmZZO0RQCfv4b+nD +/v9V9LJjgUyO/BgwCfUBulGL4la7AYPhW6m65+wbzq4LdLAS9sFY7GMSGdno2RDEDA8 NQww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=n2yujT3jczMSOlSPF2nBFzv6EErhLVXlhJ3euddlwbs=; b=WrKb2UGCQeu+BLL0J6bYVndbms3wgYxOyXTkrAhADLYm+UNVHvsh5nI+9AioehDGzo IwX9qlXlrcQwqfeA6R9tF5dcTqwAb6YgGfYxp96oeB0VM74F7Bz5T4Vl9jmvkwn42LUc 78CsYmGpL2Lfg1/+6XoxUddY7gRIT1OwzGgC0s9LT//YywjWUzot9wyCmbvQgFgkwqld hYzVlUu1FIhuYV0TsxdpznvUJW2/URXdmVG3qy2KfH8nkB/c3QogJHPWTJOR9rdi3PNw vnHbcwrBw7fYhytExupzZdgmsFAZJtxIbw9HpazMuqaK6IuAszi3QZdophgNAB6vlzF/ TK5Q== X-Gm-Message-State: AOAM533X9nAwXoOQqAY5i/DIELmSbpD2KyAnL+ymZ4l3JickR801rbhH fz3Xxiueiz6P+1d19OmwdeeE1Eh6Rdc= X-Google-Smtp-Source: ABdhPJyYStHfPGvYzhsO2D9GSV2efGvxyK823k2k3JXSthm3fR/hqRBVg3OgD5JdJmep/m8fcjw8Rw== X-Received: by 2002:a5d:5913:: with SMTP id v19mr4881689wrd.14.1626171835279; Tue, 13 Jul 2021 03:23:55 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH] Change AllocatePage to use ExAllocatePoolWithTag To: Martin Harvey , "win-pv-devel@lists.xenproject.org" References: <20210707085456.1826-1-Martin.Harvey@citrix.com> <20210707085456.1826-4-Martin.Harvey@citrix.com> <1d843f4b-5e9c-903e-e0d3-bbf92cf9b57e@xen.org> Message-ID: Date: Tue, 13 Jul 2021 11:23:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 13/07/2021 09:58, Martin Harvey wrote: > > NB. We also have a xenvif patch with a corresponding change that we were going to push up, so this is all or nothing for both xenbus or xenvif. > > MH. I know. Ben implemented the change in multiple places. I'd rather not use pool memory for whole pages if we don't have to. Paul From win-pv-devel-bounces@lists.xenproject.org Wed Jul 14 10:42:48 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 14 Jul 2021 10:42:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.156024.287957 (Exim 4.92) (envelope-from ) id 1m3cLl-0003UG-8l; Wed, 14 Jul 2021 10:42:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 156024.287957; Wed, 14 Jul 2021 10:42:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3cLl-0003U8-5b; Wed, 14 Jul 2021 10:42:45 +0000 Received: by outflank-mailman (input) for mailman id 156024; Wed, 14 Jul 2021 10:42:44 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3cLk-0003U2-61 for win-pv-devel@lists.xenproject.org; Wed, 14 Jul 2021 10:42:44 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a6ed79eb-27d8-4d02-b803-ead5e6263cc1; Wed, 14 Jul 2021 10:42:42 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: a6ed79eb-27d8-4d02-b803-ead5e6263cc1 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626259362; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=xrKwu7yW7DyPi3pzansNvV0cNIHfoSr8Sz6QR3ZM53I=; b=KiWyzo1yjF5keCGwK6clD7ShluTRYgX5I5+hU5aQOIoz67We/LPN2qZm fmLB2KI1yTdFCRbxJNIdZ2CRVY1DRI2QNNGFeth8aZObCAIYr3pm50TV9 l3m/+r7pTEmB77cI2/cwREJuy0A81WUR6k8oMrvBmjUVe9AvTVd282tJ5 A=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: gBuXQ9Tfgo0J7aeZ3lZFuAggeVmoG7cC5Zjkst+Vhp/U1Q2Y8fRtPI4BRPKY4u1IFf1m3eeUhz bkyyybz/dLWVW7NfhNSHWradzKbkMhsim2Zjkml6Dakl6eHDvm7R+t+MX8LgDSfic/F7FsADQ/ rVjGFTnGyucnh4cPe49gIAVMtygSBcMN4vAdj7hyKJGHEAwQs/7OblJ88gwFi9yajwIqbu0pEr Vm+zXTurssUofcv+s49nQF9R4Jj4RRBpoa3UZ7ktakcaQplkGab8D1EZqoNaI9VMVENEW7HPHx 42o= X-SBRS: 5.1 X-MesageID: 48296924 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:fozPO6k0ot/McUD8IjhpbcbmM8TpDfIm3DAbv31ZSRFFG/Fxl6 iV88jzsiWE7Qr5OUtQ/uxoV5PgfZqxz/NICOoqTNWftWvd2FdARbsKheCJ/9SJIVybygc378 ldmsZFZOEYdWIK7vrH3A== X-IronPort-AV: E=Sophos;i="5.84,238,1620705600"; d="scan'208";a="48296924" From: Owen Smith To: CC: Owen Smith Subject: [PATCH] Fail if multi-queue-max-queues is 0 Date: Wed, 14 Jul 2021 11:39:43 +0100 Message-ID: <20210714103943.1931-1-owen.smith@citrix.com> X-Mailer: git-send-email 2.31.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Validate backend has correctly set multi-queue-max-queues, and add ASSERTions to NumQueues and MaxQueues accessors to validate they are not 0 Signed-off-by: Owen Smith --- src/xenvif/frontend.c | 40 ++++++++++++++++++++++++++++------------ 1 file changed, 28 insertions(+), 12 deletions(-) diff --git a/src/xenvif/frontend.c b/src/xenvif/frontend.c index 30de494..5940e16 100644 --- a/src/xenvif/frontend.c +++ b/src/xenvif/frontend.c @@ -261,6 +261,7 @@ __FrontendGetMaxQueues( IN PXENVIF_FRONTEND Frontend ) { + ASSERT(Frontend->MaxQueues != 0); return Frontend->MaxQueues; } @@ -1764,7 +1765,7 @@ FrontendDebugCallback( } } -static VOID +static NTSTATUS FrontendSetNumQueues( IN PXENVIF_FRONTEND Frontend ) @@ -1789,10 +1790,19 @@ FrontendSetNumQueues( BackendMaxQueues = 1; } + status = STATUS_INVALID_PARAMETER; + if (BackendMaxQueues == 0) + goto fail1; + Frontend->NumQueues = __min(__FrontendGetMaxQueues(Frontend), BackendMaxQueues); Info("%s: %u\n", __FrontendGetPath(Frontend), Frontend->NumQueues); + return STATUS_SUCCESS; + +fail1: + Error("fail1 %08x\n", status); + return status; } static FORCEINLINE ULONG @@ -1800,6 +1810,7 @@ __FrontendGetNumQueues( IN PXENVIF_FRONTEND Frontend ) { + ASSERT(Frontend->NumQueues != 0); return Frontend->NumQueues; } @@ -1953,7 +1964,6 @@ FrontendSetHashAlgorithm( case XENVIF_PACKET_HASH_ALGORITHM_TOEPLITZ: // Don't allow toeplitz hashing to be configured for a single // queue, or if it has been explicitly disabled - ASSERT(__FrontendGetNumQueues(Frontend) != 0); status = (__FrontendGetNumQueues(Frontend) == 1 || Frontend->DisableToeplitz != 0) ? STATUS_NOT_SUPPORTED : @@ -2218,20 +2228,23 @@ FrontendConnect( if (!NT_SUCCESS(status)) goto fail3; - FrontendSetNumQueues(Frontend); + status = FrontendSetNumQueues(Frontend); + if (!NT_SUCCESS(status)) + goto fail4; + FrontendSetSplit(Frontend); status = ReceiverConnect(__FrontendGetReceiver(Frontend)); if (!NT_SUCCESS(status)) - goto fail4; + goto fail5; status = TransmitterConnect(__FrontendGetTransmitter(Frontend)); if (!NT_SUCCESS(status)) - goto fail5; + goto fail6; status = ControllerConnect(__FrontendGetController(Frontend)); if (!NT_SUCCESS(status)) - goto fail6; + goto fail7; Attempt = 0; do { @@ -2286,7 +2299,7 @@ abort: } while (status == STATUS_RETRY); if (!NT_SUCCESS(status)) - goto fail7; + goto fail8; State = XenbusStateUnknown; while (State != XenbusStateConnected) { @@ -2325,7 +2338,7 @@ abort: status = STATUS_UNSUCCESSFUL; if (State != XenbusStateConnected) - goto fail8; + goto fail9; ControllerEnable(__FrontendGetController(Frontend)); @@ -2334,24 +2347,27 @@ abort: Trace("<====\n"); return STATUS_SUCCESS; +fail9: + Error("fail9\n"); + fail8: Error("fail8\n"); + ControllerDisconnect(__FrontendGetController(Frontend)); + fail7: Error("fail7\n"); - ControllerDisconnect(__FrontendGetController(Frontend)); + TransmitterDisconnect(__FrontendGetTransmitter(Frontend)); fail6: Error("fail6\n"); - TransmitterDisconnect(__FrontendGetTransmitter(Frontend)); + ReceiverDisconnect(__FrontendGetReceiver(Frontend)); fail5: Error("fail5\n"); - ReceiverDisconnect(__FrontendGetReceiver(Frontend)); - fail4: Error("fail4\n"); -- 2.31.1.windows.1 From win-pv-devel-bounces@lists.xenproject.org Wed Jul 14 10:48:04 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 14 Jul 2021 10:48:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.156031.287960 (Exim 4.92) (envelope-from ) id 1m3cQt-0003ov-MG; Wed, 14 Jul 2021 10:48:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 156031.287960; Wed, 14 Jul 2021 10:48:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3cQt-0003oo-JT; Wed, 14 Jul 2021 10:48:03 +0000 Received: by outflank-mailman (input) for mailman id 156031; Wed, 14 Jul 2021 10:48:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3cQs-0003oi-61 for win-pv-devel@lists.xenproject.org; Wed, 14 Jul 2021 10:48:02 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 09602aaf-cefc-4533-b3bc-8a5c2399585b; Wed, 14 Jul 2021 10:48:01 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 09602aaf-cefc-4533-b3bc-8a5c2399585b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626259680; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=xrKwu7yW7DyPi3pzansNvV0cNIHfoSr8Sz6QR3ZM53I=; b=QR/EbbJsbqtmVa+xA5peaemWJ4SrWHmK7Za8axu0biquS75rr/R5ohgs ov1YKyNVvimDv+UfdXto9vEWJrI+ABmDBjl/wwXFqKn1D7tKUMnvt/abK yuFWOIUFzczSm30rh0DLyNPr5ppfERGAG1mG0+sXXpP/6SdUgOJSTKHkk Y=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: tOpLxVnl2yqBLp9KlHFMP29R4q38uA8/prFekEBUX9Ez+D21sTsawlUmuf2hsa6MJrukj981jo +mbN/yONi7KWF7inAJuzKLGEmJ8QkAKpvXYFRojYLKeEBTpRQwWxF1t4GDAoQVoB4bfAqnZqTR +AVYjY4qxEpeOxgTcy2Om04CWDhI+XJg/2KZ3eLyyxjJbIMmQjbrnAi+yN08f4p/zW6at08G7d tP1viOYTsPM25VrYgBsEk9B6HmRNt+fG9LeBPVPu3FxnoFki+DSQdacKDmaovy+TlNCyEI/onm fdo= X-SBRS: 5.1 X-MesageID: 48617464 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:8VtdYaCfzzHSIVXlHelo55DYdb4zR+YMi2TDt3oddfU1SL38qy nKpp4mPHDP5wr5NEtPpTniAtjjfZq/z/5ICOAqVN/PYOCPggCVxepZnOjfKlPbehEX9oRmpN 1dm6oVMqyMMbCt5/yKnDVRELwbsaa6GLjDv5a785/0JzsaE52J6W1Ce2GmO3wzfiZqL7wjGq GR48JWzgDQAkj+PqyAdx84t/GonayzqK7b X-IronPort-AV: E=Sophos;i="5.84,238,1620705600"; d="scan'208";a="48617464" From: Owen Smith To: CC: Owen Smith Subject: [PATCH] Fail if multi-queue-max-queues is 0 Date: Wed, 14 Jul 2021 11:47:55 +0100 Message-ID: <20210714104755.1063-1-owen.smith@citrix.com> X-Mailer: git-send-email 2.31.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Validate backend has correctly set multi-queue-max-queues, and add ASSERTions to NumQueues and MaxQueues accessors to validate they are not 0 Signed-off-by: Owen Smith --- src/xenvif/frontend.c | 40 ++++++++++++++++++++++++++++------------ 1 file changed, 28 insertions(+), 12 deletions(-) diff --git a/src/xenvif/frontend.c b/src/xenvif/frontend.c index 30de494..5940e16 100644 --- a/src/xenvif/frontend.c +++ b/src/xenvif/frontend.c @@ -261,6 +261,7 @@ __FrontendGetMaxQueues( IN PXENVIF_FRONTEND Frontend ) { + ASSERT(Frontend->MaxQueues != 0); return Frontend->MaxQueues; } @@ -1764,7 +1765,7 @@ FrontendDebugCallback( } } -static VOID +static NTSTATUS FrontendSetNumQueues( IN PXENVIF_FRONTEND Frontend ) @@ -1789,10 +1790,19 @@ FrontendSetNumQueues( BackendMaxQueues = 1; } + status = STATUS_INVALID_PARAMETER; + if (BackendMaxQueues == 0) + goto fail1; + Frontend->NumQueues = __min(__FrontendGetMaxQueues(Frontend), BackendMaxQueues); Info("%s: %u\n", __FrontendGetPath(Frontend), Frontend->NumQueues); + return STATUS_SUCCESS; + +fail1: + Error("fail1 %08x\n", status); + return status; } static FORCEINLINE ULONG @@ -1800,6 +1810,7 @@ __FrontendGetNumQueues( IN PXENVIF_FRONTEND Frontend ) { + ASSERT(Frontend->NumQueues != 0); return Frontend->NumQueues; } @@ -1953,7 +1964,6 @@ FrontendSetHashAlgorithm( case XENVIF_PACKET_HASH_ALGORITHM_TOEPLITZ: // Don't allow toeplitz hashing to be configured for a single // queue, or if it has been explicitly disabled - ASSERT(__FrontendGetNumQueues(Frontend) != 0); status = (__FrontendGetNumQueues(Frontend) == 1 || Frontend->DisableToeplitz != 0) ? STATUS_NOT_SUPPORTED : @@ -2218,20 +2228,23 @@ FrontendConnect( if (!NT_SUCCESS(status)) goto fail3; - FrontendSetNumQueues(Frontend); + status = FrontendSetNumQueues(Frontend); + if (!NT_SUCCESS(status)) + goto fail4; + FrontendSetSplit(Frontend); status = ReceiverConnect(__FrontendGetReceiver(Frontend)); if (!NT_SUCCESS(status)) - goto fail4; + goto fail5; status = TransmitterConnect(__FrontendGetTransmitter(Frontend)); if (!NT_SUCCESS(status)) - goto fail5; + goto fail6; status = ControllerConnect(__FrontendGetController(Frontend)); if (!NT_SUCCESS(status)) - goto fail6; + goto fail7; Attempt = 0; do { @@ -2286,7 +2299,7 @@ abort: } while (status == STATUS_RETRY); if (!NT_SUCCESS(status)) - goto fail7; + goto fail8; State = XenbusStateUnknown; while (State != XenbusStateConnected) { @@ -2325,7 +2338,7 @@ abort: status = STATUS_UNSUCCESSFUL; if (State != XenbusStateConnected) - goto fail8; + goto fail9; ControllerEnable(__FrontendGetController(Frontend)); @@ -2334,24 +2347,27 @@ abort: Trace("<====\n"); return STATUS_SUCCESS; +fail9: + Error("fail9\n"); + fail8: Error("fail8\n"); + ControllerDisconnect(__FrontendGetController(Frontend)); + fail7: Error("fail7\n"); - ControllerDisconnect(__FrontendGetController(Frontend)); + TransmitterDisconnect(__FrontendGetTransmitter(Frontend)); fail6: Error("fail6\n"); - TransmitterDisconnect(__FrontendGetTransmitter(Frontend)); + ReceiverDisconnect(__FrontendGetReceiver(Frontend)); fail5: Error("fail5\n"); - ReceiverDisconnect(__FrontendGetReceiver(Frontend)); - fail4: Error("fail4\n"); -- 2.31.1.windows.1 From win-pv-devel-bounces@lists.xenproject.org Wed Jul 14 12:31:02 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 14 Jul 2021 12:31:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.156051.287984 (Exim 4.92) (envelope-from ) id 1m3e2W-0007LN-QT; Wed, 14 Jul 2021 12:31:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 156051.287984; Wed, 14 Jul 2021 12:31:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3e2W-0007LG-Nd; Wed, 14 Jul 2021 12:31:00 +0000 Received: by outflank-mailman (input) for mailman id 156051; Wed, 14 Jul 2021 12:30:59 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3e2V-0007L9-JQ for win-pv-devel@lists.xenproject.org; Wed, 14 Jul 2021 12:30:59 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 572ca402-e49f-11eb-87f3-12813bfff9fa; Wed, 14 Jul 2021 12:30:58 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 572ca402-e49f-11eb-87f3-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626265858; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=eZAEMGHGPI1oPCx6I3d2+PvZ/4ui8AtjBDcrxpAiXbE=; b=eTwac18/mZ9i5XKnRcwW+ZH3c+i+YNb5iJAYb3y13Z+oYEP3amkGbPM0 uz8meOUXYt0A3Tj6F+tz1bts1l5z+4wl550KBPYRC/l8CapSa2pcRC/7U gVQ59Ajm3eJ6CXmHIL/2QPY7W9pOd9cfjtyhnfTNn+U91N6+nyD/Kpigk A=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: NAwvLFSxQr0XCafJpAhuojhwzOHKaKCK8dJk8kbFxyykmDz0WIaNxNEtvnVetxjbKCh/6lZVKe BHx5wI0BO3aSE7TPSutRJelCRQCa9Fw8wKuaHIgZpecHiTHZK3BQmk/Mb9WWBAcszHVx2rjaZo 5/bY8bbggkim2T4CgojWVASWAayiSp+d8ZPZuDR2NtUDX1w1MjiNSvMVKfvnY57eMSM6Z694At 3A4fN236mPcpsBfn0XkJg7g3TMmxACuSyCic5HyKCsjhkm2MAqov/i1YnX2H1D0C8WW9RoUAWo Oko= X-SBRS: 5.1 X-MesageID: 49892507 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Ga7avqEO0KQYoYC8pLqFfZHXdLJyesId70hD6qkvc3Jom52j+P xGws526fatskdtZJhSo6H9BEDmewKSyXcV2/hcAV7GZmjbUQSTXfhfBOfZsl/d8mjFh5RgPM RbAuZD4b/LfCBHZK/BiWHSebtBsbq6GeKT9JzjJh9WPFlXgspbnmNE43OgYytLrX59dP0E/f Snl696jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUiSw71M7aXdi0L0i+W /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yvT9aw+cyTpAVr4RHoFqjwpF5N1HL2xa1+ Ukli1QffibLUmhOF1d7yGdgjUImwxelEMKgWXo/0cL5/aJHw7SQvAx9L5xY1/X7VEts8p717 8O12WFt4BPBReFhyjl4cPUPisa3nZcjEBS59L7tUYvGLf2qYUh2LA37QdQCtMNDSj64IcoHK 1nC9zd/u9fdRefY2rCtmdizdSwVjBrdy32CHQqq4iQyXxbjXp5x0wXyIgWmWoB7os0T91B6/ 7fOqplmblSRosdbL57Bu0GXcyrY1a9Ci4k8FjiVmgPMZt3dk4lh6SHk4nd1dvaDKDglqFC6K gpeGkox1IPRw== X-IronPort-AV: E=Sophos;i="5.84,239,1620705600"; d="scan'208";a="49892507" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n2dtR6IOGfUbQboCc9BN0cx8/kaKDBm/xXfahtevRaVBDyN4PRJ707KbgJF1duub/5lcICeK+loI14FODJLlKFKbJZBG0DKzd96kZYNfpHm/pUAU2PB3AQyOC6/NSabkbw3eC2b6d3FuEgi9IOB7pZS+LBKCMOLA7taPrCbo8b/rwJZWG/4zIVRp+A+0MWuv40zSeS6Viq03UqBQLmgJ/4C3D1a8XMC4pQLkVz8FIKMn+75aA+2ZW1/XpMAc0BCceWm5YK2L1QQ8qsCt0HXmRQlmDgTjCtA4spJdj4LC80KNui0EeR+r27NcYIY9xoDGBxbToUvrD0E+xQBuoy8ztw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eZAEMGHGPI1oPCx6I3d2+PvZ/4ui8AtjBDcrxpAiXbE=; b=UzqwYAEatsg0HziR1iMKcPb+zrD00CJNkjCpMVt02sZdDkQRNMH/CTfI1xRR0lFGVRJbH23ug9U5nuyHmvO9pZH6Xkdo6DPIbna2ZIB7Jm/iveYFhC6rvNM12StrzideNEVMh9rDcN+YwZ2P0sFbVX7doErdDV5Z/yo0v6xuWGWEu1zldzzMpxtAImxYqRg1dv7TPl+VMNv/IT3fj3cspED0f0uttOiPmVSSf45xM6JaLmmxqas1fJdNKdZf9CPu8SEIy8VsOqQN3uwYfyBsW1gV4PrWwY344wm+OIxFgiaYnUhsImoZ2YVeAD03Ibh/4cRd2Tcx04gDZu8ue+9SHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eZAEMGHGPI1oPCx6I3d2+PvZ/4ui8AtjBDcrxpAiXbE=; b=I0McwauXJRy1sqBaMYOSPb20VJl3gc3kyqECOG3FMKRewd4gK236i3JB1oxDIruewUMRV55EsmvfLumh3QDB0GwtUyWVRjO1/t5SiYRqXODYleovhffCY+zkQPKGg5/a2JN++flgeNpuNYnUCnN9CSjaZcGATzQRIbYbAtlA1Io= From: Martin Harvey To: "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Subject: RE: [PATCH] Change AllocatePage to use ExAllocatePoolWithTag Thread-Topic: [PATCH] Change AllocatePage to use ExAllocatePoolWithTag Thread-Index: AQHXcw87fHf7Qwb5uU2wdCPUfVSNNKs/vOyAgADnUNCAABgCAIABtUvw Date: Wed, 14 Jul 2021 12:30:53 +0000 Message-ID: References: <20210707085456.1826-1-Martin.Harvey@citrix.com> <20210707085456.1826-4-Martin.Harvey@citrix.com> <1d843f4b-5e9c-903e-e0d3-bbf92cf9b57e@xen.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1f71445e-71d3-46dc-1fa3-08d946c338d4 x-ms-traffictypediagnostic: MWHPR03MB2701: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: itLiTEdlcFin2M70T9MJ9PmvFAbItSWBYP7D/GvYXbTgntd3N1MgIenTPd91PvEVFhRNwgGCzrf4OlNHt3hMnWcJI3tALvI2DfCJ14RHj+yk590QNVKkDZqJqTw7Rm/0yLPN99MkRWs8eqQZmaF4CLQOxdvZf2mFx65pFF/W14JV3ly5mws+bGJw+BG3vV84sLQBpsmH4gt5QoaOd0/v5263uuB40+M0g5j7iNEdWZI/lgim9Prn/UyXspo8STXloF1h5cHRfCZPRvGSMncMLCL5pQ0lveJNLgKmVFin7eW8W8rsmdY/fyJg/8CatwqpS2o6ySM3PRHdxYFHm336/mI3UjRW9Yff6KnnHF7/HtItdqP49lkQM00jR0rJywHmYIWEwx6nGbE6Ntxut/h1ycvFv1AKr6dEFvSRqL8T1khZ2W0IoX7M7X4ji+wZ2tWrR1xSaDT99AAk4AH3FaB3XTNT8yBNAt6fR5sSpoyYK+Rbyx0KHYXeq7cG/2mif0slrWXVw0geNaFX7ut7V8H9cEMg32WDjZpu978IjiqgrWTXOMsi4NLoM/+Q5vYug9G5rCnEz70tPJvRUXiahyhifZkyYJS/Ykts18OfULWDKYTc7s7/7ohHlnKcwrYgC8mPCC8t9TY5Hw3IdBcDYqliBedUtRZ6NWtjmuV8bgoDthcFxH+x85Nwtg+d3ge6yd6PwPgCsPxrWgRKtD8RDN6dRA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6347.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(346002)(396003)(376002)(136003)(39860400002)(366004)(9686003)(66476007)(66446008)(55016002)(64756008)(5660300002)(110136005)(52536014)(76116006)(83380400001)(53546011)(71200400001)(66556008)(2906002)(478600001)(122000001)(66946007)(7696005)(33656002)(38100700002)(8936002)(86362001)(44832011)(8676002)(316002)(26005)(186003)(6506007)(38070700004);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NlhBTTViN1ZNTVlrQUg4MXAva3hLM3NtdTlxSGNOb2xSN2dFSkl4RUVKaVJI?= =?utf-8?B?a09XY1JiM2hmODV3WHh0Q2ZXTFhGaGROWjdzd2RTeHpCcTZBMFRaVW02ajhl?= =?utf-8?B?Mlp2L0JVY0hhdUY1SXVjRnV2Wk0raXFKb3JmMlNRUWR6WGVUZ25YTEl2eUJF?= =?utf-8?B?TUhRVXdva1NwTW8rTURaN0V3cFFQc2JBZ1AxNkxrVUJTdlRRWENSQkFYcmJ1?= =?utf-8?B?VXg0RDY2NHNFM3U2MTUwS3MvdFErM0dmSk0vcnZNNUpFWUo5Rld5dExZWUlV?= =?utf-8?B?ZE1PdkFsNEdCS1N0WThoTFJ6dXlxbVhZNXFXNVBsZGpYeVB0b3R1Wk5PWmt5?= =?utf-8?B?ZjZOcWhVUGZLSHZJaDZjWFdWL3lWOWE2N09XSWh5QXMzUmJZZHBxckY2eDcr?= =?utf-8?B?NnJ2Z2QzUWFPZk1JUXBzanl5Ym5QS2hMeVF0b2VGOWkydjFiRlAzMUQ0QWFX?= =?utf-8?B?Ti9WYi91QUZpanYyVmdkdlVrb0tCYTBGQzIzeThrSElvaENzVjNlZ1c5czRJ?= =?utf-8?B?ajBXemNKMFNwV2ZlT01EUUM2Sksxclh3RVRDK2Z2ZFFvWTBHbGREQ2ZYdmQ1?= =?utf-8?B?VEpnQzZpc2J1UkJzYWZCSjV4WkNVbk9lMlBmSUg2cnZkOHBBZmdxc05KUWds?= =?utf-8?B?QXZJdklKeXdXb1c0ZjRiM0dFRzVzZEo5cEdvL3pkU1ZKblBTeXFQSFdSaDlL?= =?utf-8?B?Y1JiYXRva1NHWGJqdDR3ZEszdE56VlhmNk41cnpJYkVNRXlIUW1ncDBrQWsr?= =?utf-8?B?UDRvckd0Z0l4SWgxQmE1TWd5RWVwNnI5YU43TjFzUXhiU3lBSlJXTFhUTnAw?= =?utf-8?B?L3I3bk93SWtlL0RoL3hnclRzdzRqRmQxdm92QWJGRTJ4TG4yL2RSelBjS2d1?= =?utf-8?B?OTBiVkluY2ErMENVYjhyN3dHVndncHZBTDJGandvcmlhZ3hGNEw3SmFSbVdC?= =?utf-8?B?RnJSSERGaG5ucWl3SURLc0R1RS96eDJQVHVINmlvZjg5RXpnQjVCQi9NeWFj?= =?utf-8?B?bHhFdHZJUS9RZmJsSnVHNTZDZ3ZBUUdrUlgvVHZyZjFFZ0F3SHZhTnRsZlUv?= =?utf-8?B?ZVZhamJKOEl5dHp3b2NYaWF3eXh6WTR3RG0zNjZVYXk3TVdXWWZPM3dMcHNy?= =?utf-8?B?UnJnYWJxcVhUNnZrc0kzSmdWSzAxdUVobzZBT0pYclI1SmdCekszUDhPOVU2?= =?utf-8?B?M08wSDB1K3p1dTJjSTlZWHZNNU83dS9hSE5vSWhJejd0Q2hneDliSFdNZ2Vk?= =?utf-8?B?YktWWTEyMm5WMGZ2aW5LNndYOW1tU0M5cy9jUGRhWW5XUzlCNWRxL1NRZ1pR?= =?utf-8?B?MFNhWS9Cb0RieEdNZDM4TmhodVg2ajlDay9NRzlsUmhxaXhYVmQrTTczc2Q1?= =?utf-8?B?LzRzbjNqQWVIZElUNUg2bENwOFFsSEQrdHdrVXpRdUdpTG9JZnFFRzZPbU5L?= =?utf-8?B?RXVDY1FmRnlGLzlmMytsajh0bEJyVUo2RGducnl5Q0RRbllIN3lSanNNOGFM?= =?utf-8?B?eHZtaHVtbzRSQi9iMkxtdy9peFV1dC9VaUJiaDFEc0VDL0tlU2hhNXZ4OVZW?= =?utf-8?B?VnlHOUpLRExtYUlwczFtNlhLN3BrekQwNkk3UDZ6dnQ0SWdOWWVOODFxNTNo?= =?utf-8?B?VWVFRWY2MHFKMXZaUVFPUlB4bm5zQjUrZGpFc1A2MUlweCtwK00vQmdaUTU1?= =?utf-8?B?V2RHSm85MG0zOGJNazF3Um1RYjU5ZGg2ZHd5cW0zYmphYVNzNCtoVlNYT25a?= =?utf-8?Q?u+BqKTO069FozVPYk0ZZ1diTtAwL8V6t5Aca3QL?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6347.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1f71445e-71d3-46dc-1fa3-08d946c338d4 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2021 12:30:53.4862 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: D1XJmirT1/LRRffF8htMMUD7frVG/v+TU8jz/+hEQaePW2+gNrsabBkW10GOJxngS/eg82ZvVJ096fg6+qdoedyJPW5XWnObf6bVzd0JUrA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2701 X-OriginatorOrg: citrix.com DQpPSy4gTGV0J3Mgbm90IHVwc3RyZWFtIHRoaXMuIE93ZW4gYW5kIEkgKm1heSogYmUgYWJsZSB0 byBmaW5kIHNvbWUgdGltZSBpbiB0aGUgZnV0dXJlIGZvciBzdHJlc3MgdGVzdGluZyBvZiB0aGUg dmFyaW91cyBhbGxvY2F0aW9uIGNhbGxzIG9uZSBtaWdodCB1c2UgaW4gdGhlc2UgcGxhY2VzLCBh bmQgdGhlaXIgZWZmZWN0IG9uIHJlbGlhYmlsaXR5IGFuZCBwZXJmb3JtYW5jZS4gQW5lY2RvdGFs bHksIHdlJ3ZlIHNlZW4gc2l0dWF0aW9ucyB3aGVuIE1tIGNhbGxzIGRvIG5hc3R5IHRoaW5ncywg YW5kIGFsc28gc2VlbiBzaXR1YXRpb25zIHdoZXJlIHVzaW5nIGxvdHMgb2YgcG9vbCBkb2VzIG5h c3R5IHRoaW5ncywgYnV0IHdlIGhhdmVuJ3Qgc2VlbiB0aGUgdHdvIGNhc2VzIGludGVyc2VjdC4g TWF5YmUgcmV2aXNpdCBpbiBhIGZldyB3ZWVrcyAvIG1vbnRocyB3aGVuIEkgaGF2ZSBoYXJkIGRh dGEuDQoNCk1ILg0KDQotLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KRnJvbTogUGF1bCBEdXJy YW50IDx4YWRpbWduaWtAZ21haWwuY29tPiANClNlbnQ6IDEzIEp1bHkgMjAyMSAxMToyNA0KVG86 IE1hcnRpbiBIYXJ2ZXkgPG1hcnRpbi5oYXJ2ZXlAY2l0cml4LmNvbT47IHdpbi1wdi1kZXZlbEBs aXN0cy54ZW5wcm9qZWN0Lm9yZw0KU3ViamVjdDogUmU6IFtQQVRDSF0gQ2hhbmdlIEFsbG9jYXRl UGFnZSB0byB1c2UgRXhBbGxvY2F0ZVBvb2xXaXRoVGFnDQoNCltDQVVUSU9OIC0gRVhURVJOQUwg RU1BSUxdIERPIE5PVCByZXBseSwgY2xpY2sgbGlua3MsIG9yIG9wZW4gYXR0YWNobWVudHMgdW5s ZXNzIHlvdSBoYXZlIHZlcmlmaWVkIHRoZSBzZW5kZXIgYW5kIGtub3cgdGhlIGNvbnRlbnQgaXMg c2FmZS4NCg0KT24gMTMvMDcvMjAyMSAwOTo1OCwgTWFydGluIEhhcnZleSB3cm90ZToNCj4gDQo+ IE5CLiBXZSBhbHNvIGhhdmUgYSB4ZW52aWYgcGF0Y2ggd2l0aCBhIGNvcnJlc3BvbmRpbmcgY2hh bmdlIHRoYXQgd2Ugd2VyZSBnb2luZyB0byBwdXNoIHVwLCBzbyB0aGlzIGlzIGFsbCBvciBub3Ro aW5nIGZvciBib3RoIHhlbmJ1cyBvciB4ZW52aWYuDQo+IA0KPiBNSC4NCg0KSSBrbm93LiBCZW4g aW1wbGVtZW50ZWQgdGhlIGNoYW5nZSBpbiBtdWx0aXBsZSBwbGFjZXMuIEknZCByYXRoZXIgbm90 IHVzZSBwb29sIG1lbW9yeSBmb3Igd2hvbGUgcGFnZXMgaWYgd2UgZG9uJ3QgaGF2ZSB0by4NCg0K ICAgUGF1bA0KDQo= From win-pv-devel-bounces@lists.xenproject.org Wed Jul 14 12:31:48 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 14 Jul 2021 12:31:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.156056.287988 (Exim 4.92) (envelope-from ) id 1m3e3H-0007Pe-UE; Wed, 14 Jul 2021 12:31:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 156056.287988; Wed, 14 Jul 2021 12:31:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3e3H-0007PX-R4; Wed, 14 Jul 2021 12:31:47 +0000 Received: by outflank-mailman (input) for mailman id 156056; Wed, 14 Jul 2021 12:31:46 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3e3G-0007PR-6H for win-pv-devel@lists.xenproject.org; Wed, 14 Jul 2021 12:31:46 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 591db189-afd3-4f6f-9913-7e0719ea1eb8; Wed, 14 Jul 2021 12:31:45 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 591db189-afd3-4f6f-9913-7e0719ea1eb8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626265905; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=zWG5KKfOm1zPUNgtJhu2Q9Chtewc4Ou2AZM3OpDkaA4=; b=g9QXbKO67lRSJeaLmvu6C0mYgbXxcZ9NVXo7bej1/Y5POdidcyKNumm1 nPoaNBNE0NuZ3pKDcVs6g/cETP4gINllByFq29pdbWjdwMvFRiui5OOH2 AVTfHEULVwZh7KpLxoODrmlU0nR8NIm3bIMGBasp13xhxMCNigigwhmSW Q=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 4Vwq8cDOD96O5tcJKPH9ofWyGO1wuH/qFSCoC3nxXMuYhPnuzekufqfqgSew/cPsrgr0MyNpu4 LV7odXiuiq8BqXiuy662kXkeu08beEH4+Pk9Lg6TeYVlxiLh9D5SWnvi2lIyYcXsOB0E/gg9cP PEfLFBl6heAq0DNSfc5+xHB+tf/LPXPlEhSxFjhbeqKjsDBXsJnu5s1QSGMg5kjkYmPg5zfQL3 UA7d5w6kph4fnNM6/mFwwf4JVviOEsqHbLdMJkBKJDgeyA3JJ6Z3NwRtlDFnv9HmNq/oFyfIDs mlE= X-SBRS: 5.1 X-MesageID: 48303636 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:5K/ka6PQ5MPyTcBcT1L155DYdb4zR+YMi2TDiHofdfUFSKClfp 6V8cjzjSWE8gr5K0tQ5OxoX5PwDU80lKQFrLX5WI3NYOCIghrPEGgP1/qA/9SkIVyEygc/79 YuT0EdMqyIMbESt6+Ti2PYc+rIguP3iJxA7d2ulkuFJjsaDp2Imj0JbTpzZXcGIDWua6BJdq a0145inX6NaH4XZsO0Cj0uRO7YveDGk5rgfFovGwMnwBPmt0Ln1JfKVzyjmjsOWTJGxrkvtU LflRbi26mlu/anjjfBym7o6YhMkteJ8KoDOCXMsLlUFtzfsHfrWG1TYczGgNnzmpDq1L8eqq iOn/7nBbU115qeRBDynfKn4Xid7N9n0Q6c9bbfuwq6nSWxfkNFN+NRwY1eaRfX8EwmoZV117 9KxXuQs95NAQrHhzmV3amAa/hGrDvCnZMZq59ks5Wfa/ptVJZB6YgEuE9FGpYJGyz3rIghDe l1FcnZoPJba0mTYXzVtnRmhIXEZAV5Ij6WBkwZ/sCF2Tlfm350i0Me2cwEh38FsJYwUYNN6e jIOrlh0LtOUsgVZ6RgA/ppe7r+NoUMe2O5DIu2GyWsKEgqAQO8l3fH2sRB2AjxQu148HIbou WzbG9l X-IronPort-AV: E=Sophos;i="5.84,239,1620705600"; d="scan'208";a="48303636" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Her/1tqzvW+9GN5R/LOAcoMZ5JlN2ztF4TL1caQm0F6wUB4nDjb+FjQJd+sMb7L80UFKLgT14KDdoAAXIo3SRSYpxtBs3vbhuQJkWojrb7Qnh/7No+3dXZywRAIkbd+VwUpGKJ7IPiwZ5dFW+lh5VtSc6T4oGCJMQz/wY0vKlRdr951K1gOrT1VjInE2YYoS4/ZybRy3wZ9FHDQitkNu7AH13y46cWHZFvAB110kCJH2zJF6Y2+X0OIk4IJEu0HojloJlfbYNKaq1g4rRBD29q+thFcn63gyfBnSpq0vVFRjRNDPo9lGKc8WQxngkq13Xa76OEqC9LrDLMladWOfPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zWG5KKfOm1zPUNgtJhu2Q9Chtewc4Ou2AZM3OpDkaA4=; b=C6U4eja4FZX/0UW32+gOEpWz4+QN7YHxukqycVxEqromBWiH/Y2xBkmfGykqPeKzJDMkbGcyse5Vtgh7X/RsgYFHFIfSpaDIPuh4Ia4fyS2Y3ju1L/Jf6j7Ff3ODu38QhgD70TMIH3K8GG3pM2bspFZgchcTpDveLdjC67rYFMnYHqeLdz/k4sb11ElLVuxLQuIZs/fndksX8DGsxhYaxTvmqqfKMmcEDGpcftyVdGfSY//KsvA8yB+y2dozFYut6AKJ427teutuGNj9JvhL8X7NmFAuezUgfNZnoKD4CW40VcoB3mD6aX6+S3scvSeJ4fNGm3Yq0KnDdzOl9f1sRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zWG5KKfOm1zPUNgtJhu2Q9Chtewc4Ou2AZM3OpDkaA4=; b=WGw4qgicl13rUntVEPzgA57Udw12XyCHzXfbip43dJp9kTwhUVFVrfk2oZY1KRfSqPH4zM8JC8JTckbCQbF+ihVapqRKw5GnfHGm57gOix9PvGUBRCbTip1llYypDgC3iLF13T8hJWKFEQ/C2FNQg7U5rQrWxi4JMZhrfG3PYb0= From: Martin Harvey To: "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Subject: RE: [PATCH] Disable CONS debug logging Thread-Topic: [PATCH] Disable CONS debug logging Thread-Index: AQHXcxGeIfXNO0rCZEWN6VpzK7eW7Ks/vHyAgADiqHCAAATBAIABzjog Date: Wed, 14 Jul 2021 12:31:33 +0000 Message-ID: References: <20210707085456.1826-1-Martin.Harvey@citrix.com> <20210707085456.1826-3-Martin.Harvey@citrix.com> <7074bcda-ec68-01eb-a519-88c3447efa47@xen.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 01652d7b-1ad8-41f0-1dcb-08d946c350bc x-ms-traffictypediagnostic: MWHPR03MB2557: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6Yt5stnFAlD7jCqB8Kd/f37KN2dsWJrP9cOIJTh8/h+OAuU5yOgW/13wZat3ev8mhRyKq+u9IaGv27/l9cEU37sZWk2DJEylMzC8xtdWBrtiZDS+BvFcrzY6O5HdTrXnfumsutFSd9HtZohYc5tkpCLtnPUNaLG8TW+RltKinGFZeCWOsft0iK14P+fpouaWj9W7zZalWyyu5Y3fkiUm2Z4iKCP/JM+Gza7qJXbDGpTtqJ2vO8JTiwRJCy8298Qd9Up73OI0Fr56i9bZoIRDNgrHCmIvtsWpFN2wUjCAb+tZv3ZB9y2be/nwZKItwPQ+UuTBj5aldKbh1S1SVgZjQDL901vQcMU3jkBXt8nHIYXGmFWiW7ll8pOv0CpKPIi/oj87oAUJD6OgL8Svj4CPR1aopuOwV3Qx4rkRLmb3dXwfbwi5UTQZJAylgHxFhgM9NnnE5guLFawdTlsGlb1sEh7ZvGgFtVzDT6fFATYNJ8Tjv2jH4XGr3NQhN861kqq/b6uTpoB1ENbyirC3TLoCRErIXytY32+075MiP2On333LGGV9Yo8dlTFpInRLPC/+V6fxU4uhsYBieimafeY8dSMQlqJQ+3Y5HTDimK3oZnvD4zDmcMVOpa77P77VTcZ/+obRH8gbGSFTAKiO2NkX55YhyiwFzDi6+6R3JOSGX+VcmPB4hA0l7K8zf8diJJxYhJhVBdlR30JU7oIjuYO7dA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6347.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39860400002)(346002)(366004)(136003)(376002)(5660300002)(55016002)(71200400001)(53546011)(86362001)(8936002)(38100700002)(8676002)(186003)(26005)(9686003)(83380400001)(66446008)(44832011)(33656002)(7696005)(66946007)(76116006)(66476007)(64756008)(66556008)(110136005)(122000001)(52536014)(316002)(478600001)(2906002)(6506007)(38070700004);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dlQzQ3l2ZDVBeW1aK05ZQjBjMnNMeWVrNzlkNXN4c2U2QnBCSmZoaTZiRFJO?= =?utf-8?B?ZUNhUmhEc2pNVm9RVTlXclFIREprMnVMdmNKMXRrOFh4c05BMGdpYzViOGhQ?= =?utf-8?B?MUpYSHdtOWMzSHloODlKek9SVjhzU2VILzNOYTl3Nkt0Zzg4Nnk0bU5PV2FZ?= =?utf-8?B?cjM0Wkp4QkRVVTFJZVc4Y3VBVlJhcXBHMVNWd0g2Sk9zdjV3dTkxWEhubEMr?= =?utf-8?B?ejhnVmg4ekZDS3BmeVgxTkhQT1NIa1NUOUNsN0QwOXBlOHREMG5QYlQ0VlU4?= =?utf-8?B?L3dobGlhUHlXZFNQUHFxeHJYUVBWa3JNQm96QXdZakNQT0lTM1dJOUZxcHFX?= =?utf-8?B?MGxzeENLUWo1ODRGTXRyUHVNWDhkekNBdDJWY0o4djA3OHM3YnM4Z0dlTjdX?= =?utf-8?B?VklHSDVwQnQzVGxFKzRoUkY5bW9sREFLbGVJTFljeVQvdDFYb3BjV3BDNmRy?= =?utf-8?B?NDg1WTFZbDQ5Q3k4NHJVSUMrT0JhOTAvTUdSaWNPWlhlOFhaVnhTUWl5ZEVW?= =?utf-8?B?MUxnZC9DZXQ3MU5ydHVsYUMvWlVxUU1FeWkvekowS1dsMDZiQTJJUlg0aEJU?= =?utf-8?B?S0I5ZytqQ3dHRGF2Q21MVDJzRXRYVVNvQ2NzNUdvdXJVQkFaZXBWMERNa1dV?= =?utf-8?B?RTJVWDNnckcxRmFab2c3U3pSaHRNZTd6MWxmV3k0d256ZjVxZlYyS2E1VnlK?= =?utf-8?B?VkdrdVJyeGMrMG5Ed2JoSGE1eSt4Z0tGT3h3L0Q0VzRYbWFwYndaUjhYMnNR?= =?utf-8?B?SWJGYVZPemtvOVozRDhSbVlaME1RMXFGZi9jZXh3TWhYZlVjUUJBOXM5Z0Vo?= =?utf-8?B?RXJkanJ2a0ZwbndXOWRDeDA0TmROeFJ2Tk9zampEVThWUW5zWk1HSjY4aGgz?= =?utf-8?B?dS9CU1NQZDk1L0N4OVQvVGhDVW5Ebi9KNm5HbXMzeDNFQmlmVXBRSU44cE9S?= =?utf-8?B?WFdFRFlwWjlMalpoUmFrUnVObGRiZWkzZW0wVUxxS3k0NEZzNVcxM2FwTkh4?= =?utf-8?B?MWwwME1HdUdnSjNHQkFpSTBnZTFONXdqSVNUNTV6bDV6R2NYbWEvbytyc3F6?= =?utf-8?B?VnpnNTg0bVdESmdjZU9VUzVKS051R2NQVjM5YzZlbmV0SFMzdkFVTkdNbmw1?= =?utf-8?B?aGVCZk5KSFc2TjlqNjN0SVlPeG1YNmZCVTQzcTY4ZnZpcGVWV2paeExuVHQ4?= =?utf-8?B?cHRkN1dXRjRkYUVFV2xzWXVJNGlqQzNCOU5zVUpjVyt6eDI4NEJ2d2p4Smds?= =?utf-8?B?ZjlvcFc1dHpiZnpOVVNxVE02U3pRY1JOcFREZ2VaRWN0V0pxV0M0cnozdWdQ?= =?utf-8?B?S0JLbGo5TDdKNjdkVkVBWkNqckJkWUtHL2pIWmhCbmVIREs1R2hiMGtqVGF0?= =?utf-8?B?WmpaWTVwRVkxaUFrMTBheHVDS2ozZVJsWWpNTTFMUjFlRE5ocDVqYUNUTWtY?= =?utf-8?B?S2FtQklpSHZVNzlGOWVvL1BYcmRUSzdWdUplVUIyRXdpZjlaRUlsajhjMm9a?= =?utf-8?B?dndDYXA0VitWdW04RTdjZ2ZIR0FkeHg2cXhjV2M0RUkvWUQvbFI4emY5T2FF?= =?utf-8?B?cXVFbEJseUkzVWlJM3hMTG81Uy9OZUdYekMvYjJPdVpxVU1sMFppMWxFZTlw?= =?utf-8?B?MnBybnpRQUxBcXZTNkpZdjZvRHhuQk9PSUZsRXNQdTExcnVTS05NZ2FhN1kw?= =?utf-8?B?WW40SUw4eDRZVXJhWXdtRnJQR2ZNRU9GNVQ0TkpQMjRZK1JyVXM1SW5Jb2VR?= =?utf-8?Q?MIfEbZkf+oZx/Nvlux7xVLWA2lgyYO0KZZRC/iv?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6347.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 01652d7b-1ad8-41f0-1dcb-08d946c350bc X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2021 12:31:33.5922 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: z+CsUO3qWhTH+hFQsJ21MVbzLWojMs8CshuEwcLOH/YlwOmlz4EtE60Evrn4L8IA9qhzZtsBFj0UtbYK561PN1RXaDcKovHPO6KIULq2YqA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2557 X-OriginatorOrg: citrix.com DQpWZXJ5IHdlbGwsIHBhdGNoIHdpbGwgYmUgcmUtd29ya2VkIGFuZCByZXN1Ym1pdHRlZC4NCg0K TUguDQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBQYXVsIER1cnJhbnQgPHhh ZGltZ25pa0BnbWFpbC5jb20+IA0KU2VudDogMTMgSnVseSAyMDIxIDA5OjU3DQpUbzogTWFydGlu IEhhcnZleSA8bWFydGluLmhhcnZleUBjaXRyaXguY29tPjsgd2luLXB2LWRldmVsQGxpc3RzLnhl bnByb2plY3Qub3JnDQpTdWJqZWN0OiBSZTogW1BBVENIXSBEaXNhYmxlIENPTlMgZGVidWcgbG9n Z2luZw0KDQpbQ0FVVElPTiAtIEVYVEVSTkFMIEVNQUlMXSBETyBOT1QgcmVwbHksIGNsaWNrIGxp bmtzLCBvciBvcGVuIGF0dGFjaG1lbnRzIHVubGVzcyB5b3UgaGF2ZSB2ZXJpZmllZCB0aGUgc2Vu ZGVyIGFuZCBrbm93IHRoZSBjb250ZW50IGlzIHNhZmUuDQoNCk9uIDEzLzA3LzIwMjEgMDk6NTUs IE1hcnRpbiBIYXJ2ZXkgd3JvdGU6DQo+IA0KPiBJIGJlbGlldmUgdGhpcyB3YXMgb3JpZ2luYWxs eSB0byBwcmV2ZW50IHNvbWUgc3BhbSBmaWxsaW5nIHVwIHRoZSBsb2cuIFNvbWUgYW50aXZpcnVz IHByb2R1Y3QgLyBmaWx0ZXIgZHJpdmVyIHdhcyBzZW5kaW5nIHNvbWUgUG5QIHF1ZXJ5IElSUCBk b3duIHRoZSBzdGFjaywgd2hpY2ggZmlsbGVkIHVwIHRoZSBsb2dzLiBPd2VuIHNob3VsZCBiZSBh YmxlIHRvIHByb3ZpZGUgbW9yZSBpbmZvLg0KPiANCj4gQWdyZWUgd2l0aCBjb2RlIGluIGNvbW1l bnRzLiBXb3VsZCBzb21ldGhpbmcgbGlrZSB0aGlzIGJlIGJldHRlcj8NCj4gDQo+IC8vV2FzIElO Rk8sIFdBUk5JTkcsIEVSUk9SLCBDUklUSUNBTCB1bnRpbCByZWR1Y2VkDQo+IA0KDQpJIGRvbid0 IHRoaW5rIHdlIGFjdHVhbGx5IG5lZWQgYW55IGNvbW1lbnQgaW4gdGhlIGNvZGUsIGFzIGxvbmcg YXMgd2UgaGF2ZSBhbiBleHBsYW5hdGlvbiBpbiB0aGUgY29tbWl0IGNvbW1lbnQgKHNpbmNlIGdp dCBibGFtZSBjYW4gYmUgdXNlZCB0byBkaXNjb3ZlciB0aGF0IGZhaXJseSBlYXNpbHkpLg0KDQog ICBQYXVsDQoNCj4gTUguDQo+IA0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9t OiB3aW4tcHYtZGV2ZWwgPHdpbi1wdi1kZXZlbC1ib3VuY2VzQGxpc3RzLnhlbnByb2plY3Qub3Jn PiBPbiANCj4gQmVoYWxmIE9mIFBhdWwgRHVycmFudA0KPiBTZW50OiAxMiBKdWx5IDIwMjEgMjA6 MDkNCj4gVG86IHdpbi1wdi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KPiBTdWJqZWN0OiBS ZTogW1BBVENIXSBEaXNhYmxlIENPTlMgZGVidWcgbG9nZ2luZw0KPiANCj4gYSkgV2h5Pw0KPiAN Cj4+IFNpZ25lZC1vZmYtYnk6IE93ZW4gU21pdGggPG93ZW4uc21pdGhAY2l0cml4LmNvbT4NCj4+ IC0tLQ0KPj4gICAgc3JjL3hlbmJ1cy9kcml2ZXIuYyB8IDggKysrKy0tLS0NCj4+ICAgIDEgZmls ZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pDQo+Pg0KPj4gZGlmZiAt LWdpdCBhL3NyYy94ZW5idXMvZHJpdmVyLmMgYi9zcmMveGVuYnVzL2RyaXZlci5jIGluZGV4DQo+ PiAxYjYyMWZhLi5mMzUzYTYxIDEwMDY0NA0KPj4gLS0tIGEvc3JjL3hlbmJ1cy9kcml2ZXIuYw0K Pj4gKysrIGIvc3JjL3hlbmJ1cy9kcml2ZXIuYw0KPj4gQEAgLTU4LDEwICs1OCwxMCBAQCB0eXBl ZGVmIHN0cnVjdCBfWEVOQlVTX0RSSVZFUiB7DQo+PiAgICBzdGF0aWMgWEVOQlVTX0RSSVZFUiAg ICBEcml2ZXI7DQo+PiAgICANCj4+ICAgICNkZWZpbmUgWEVOQlVTX0RSSVZFUl9UQUcgICAnVklS RCcNCj4+IC0jZGVmaW5lIERFRkFVTFRfQ09OU09MRV9MT0dfTEVWRUwgICAoTE9HX0xFVkVMX0lO Rk8gfCAgICAgICBcDQo+PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIExP R19MRVZFTF9XQVJOSU5HIHwgICAgXA0KPj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBMT0dfTEVWRUxfRVJST1IgfCAgICAgIFwNCj4+IC0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgTE9HX0xFVkVMX0NSSVRJQ0FMKQ0KPj4gKyNkZWZpbmUgREVGQVVM VF9DT05TT0xFX0xPR19MRVZFTCAgIDAgLy8gKExPR19MRVZFTF9JTkZPIHwgICAgICAgXA0KPj4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLy8gIExPR19MRVZFTF9XQVJO SU5HIHwgICAgXA0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLy8g IExPR19MRVZFTF9FUlJPUiB8ICAgICAgXA0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgLy8gIExPR19MRVZFTF9DUklUSUNBTCkNCj4gDQo+IGIpIExlYXZpbmcgY29k ZSBpbiBjb21tZW50cyBsaWtlIHRoaXMgaXMgbm90IHNvbWV0aGluZyB3ZSB3YW50DQo+IA0KPiBJ ZiB0aGVyZSBpcyBhIHJlYXNvbmFibGUganVzdGlmaWNhdGlvbiBmb3Igd2h5IHdlIHdhbnQgbm8g bG9nZ2luZyB0aHJvdWdoIHRoZSBjb25zb2xlIHRoZW4gZGl0Y2ggdGhlIGNvbW1lbnRzLg0KPiAN Cj4gICAgIFBhdWwNCj4gDQo+PiAgICANCj4+ICAgIHN0YXRpYyBGT1JDRUlOTElORSBQVk9JRA0K Pj4gICAgX19Ecml2ZXJBbGxvY2F0ZSgNCj4+DQo+IA0KPiANCg0K From win-pv-devel-bounces@lists.xenproject.org Wed Jul 14 12:31:57 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 14 Jul 2021 12:31:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.156057.287992 (Exim 4.92) (envelope-from ) id 1m3e3Q-0007Sd-WA; Wed, 14 Jul 2021 12:31:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 156057.287992; Wed, 14 Jul 2021 12:31:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3e3Q-0007SW-T5; Wed, 14 Jul 2021 12:31:56 +0000 Received: by outflank-mailman (input) for mailman id 156057; Wed, 14 Jul 2021 12:31:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3e3P-0007SK-R2 for win-pv-devel@lists.xenproject.org; Wed, 14 Jul 2021 12:31:55 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6925e068-472e-4a00-8789-381a1c9e2ba2; Wed, 14 Jul 2021 12:31:54 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 6925e068-472e-4a00-8789-381a1c9e2ba2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626265914; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=eiASBGgUGS5yTL8THSMHIwjvdPOuybHg8mxJ8cDNLx0=; b=AHyUKakzEcMHwd5nwWOVDxZZBBjy6kl2XEV/2Y6Hg1oawJM7HHXCv3Ma goqbcNX83IZ/ljuYDIPCC5MgncwlV/DHYL+k6/tmWURYNSSHlu9CpRxjd JgLLU1ASNb63f+vCpk1Y9Ss0JAcy6tPba3vUc9K7VMPitIK8eapmAnpUM s=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: +Y63e0c6TfAc5ZEQVwn+w1B+ge861C63jdMeiDNLdwmCsJku1G/f1nX9bw25uoTe5dC28bqvvS RF+1DY0kUHur8dXfchHVQuTMRtaFrkCe3dQ/2fixsbxJBlt0RHKvJZLkTNHvuOefphDLlBYByw uSSSWjQWUS0DmcIriEJv2vJU22jedvgTSehuv7An/9uQWKdBTVktj3Y+4e+vXZBDSdrkes3ux2 zqCT90kdo2QhtGFGU2abzq6iG1Z74eWGauZKd7vyRbG9BBimZjm/VC0af2DXAtJ4hbYu6ez0bN Urg= X-SBRS: 5.1 X-MesageID: 48249296 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:/wb9p6ztI7EhDvhTM0EGKrPw2r1zdoMgy1knxilNoHxuH/BwWf rPoB17726TtN91YhsdcL+7V5VoLUmzyXcx2/hyAV7AZniAhILLFvAA0WKK+VSJdxEWtNQtsJ uIG5IUNDSaNykfsS+V2miF+9ZL+qj5zEir792usUuEm2tRGtBdBwQSMHfqLqVvLjM2fKbQjP Cnl7d6TzzLQwVuUu2LQkMrcsLkvNPxmJfvcXc9dmIaAFnnt0LS1FbieSLopCsjbw== X-IronPort-AV: E=Sophos;i="5.84,239,1620705600"; d="scan'208";a="48249296" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dwgB9l8GpEDTowJV/jY64rZbnoIBa/fFtNaC76+lLxJec+0zzQHO9kdtsxABwZXFd1tKD8cU7djqR+WanjS/iZ6UoFXhKYekHRfSTHX8TNCv/fGEfxHCZ1pL92MudJSfj4c8RB9knGF2Cqfi4g/RjKH9eG0N5YaTsOzc38sdy0AeaDp2IojGZYsW709J8pC7FRiLbUS8HTSrSfPeRq+r1TglyuIVgPMJMOltbkWZQP1fGX/WUcuiI6gvG6UoJ2jx+3WHRuQE4cV5I+iL0jXTpRAa8A3S1Efl9ZCyCwqyqd87h81o8qyKOK0B7YyOnc/BEXAujVsY1ADEb9reDQhjBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eiASBGgUGS5yTL8THSMHIwjvdPOuybHg8mxJ8cDNLx0=; b=dhz0HlpnVjLngp1XyAVY13erTNTOx5izAur0Am15ZxMk2nQtrvTxmA7vFzMOnLF+BeHnZl8HyZwkZaK3DKrV1aaQHAbNsDKmeazwxPKDqqZ7UH2WsS6Q1Ps5oQhnPz7HM76+OakgEA6lp6Sv3Lmc24qAY+bJ/gDqam480svWdxKqXNGLXbdzOE3YgGDpkL0sJlvgh5pECJ+A8/KzwwkRYX1DmpAjCCMq2gDQGFdo965DopzMXJqO6qTlD+7tIDzaYxkrlwBYmceoPQmucj4VEWY3l9/M/CbG8kaSWi0nhDAJVEZCNkzwIJ1lljkgjBnbMBhuF2Eky4L4/kniRJ46KQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eiASBGgUGS5yTL8THSMHIwjvdPOuybHg8mxJ8cDNLx0=; b=l3Y6T51b2MOwJ3xOW31ArChnudUt1iAUTs6336wgte7CDckmL7UjXAZw8lfwDeU1vIOwHMTzZPDvEhjdvQ4ZDTBTMGwhpOOVCQihcT5/+et2Oz4zhMMiW8gtUkOLxPHAPC+BRtmFVQnyzxA/0t+IDc6IO2OJ/IkyKjHoqlN0Bpc= From: Martin Harvey To: "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Subject: RE: [PATCH] Add log to Xenfilt DriverAddDevice Thread-Topic: [PATCH] Add log to Xenfilt DriverAddDevice Thread-Index: AQHXcw8lO0GbhNNyjkas71fAJtHqXKs/u8QAgADdFTCAAAoDgIABz24w Date: Wed, 14 Jul 2021 12:31:51 +0000 Message-ID: References: <20210707085456.1826-1-Martin.Harvey@citrix.com> <20210707085456.1826-2-Martin.Harvey@citrix.com> <60fcc419-10ee-e02a-b235-1d6c8c5d1d25@xen.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 794a10fc-8bf3-46cd-2475-08d946c35b72 x-ms-traffictypediagnostic: MWHPR03MB2701: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HlEYBb7NpwaETzn2d0d6ii5nQZYjajQ0aaHe1mXLHSL/0Z3VXbswNm7P/wMyn8/MuglfSwBxoyfnUCa9oPYc5YWchK7TeytkagC9fKxXrSrogslaFG8Ja+QIqMZNGjuweNmjOKRUZxGh+vNVVJrH+HJKBY2qKsVFzmD9kSP6TWZvHS30SsQI/ADXwDzgdzfQ5/bfvr83WbYeucdPUP7oZdw0kedM/hQisqxrk4IQc33Vb4a93OnHq2YckYxXKuTij7zKDdsMDJ3J7hsOSvRIo61idjU8xDjkzjxdB+gKfNhQ8snc13g6v88gkX2gfciAr5kA9Al9O2yI2ak2X22Lq8C+F8cHfMW797yDstNyhoXv5/xiAR4eryvGd3dk+jKwrGFSjj2NC2J9FYlA/LdjUe/WutCno8e5HgC3W1Zm45k7/PPhvc7JXBlcyspx/hAxKEkyNx21eRVHzqCdQgU1qMk/2J1OXgVkffuwAWQPH77uE6EfxJcuWUYDA50sADvjQ9b9kpHhSfm4QB0GSAyZ9056ltELQVeLa5/TN5JoiQZcKNQ9Ar/yaW4pULmPALRYl++NrvLJLpCEvzrPZFi4F0OdoPdg+Q5vzseqhlqawfXusgdhXAxjknochJJHsSbtX7gQFh1E+4KK2pwRgW0p0WM57I2z8iSRACk7Ga6BmwoOPCAWr+1GwrbnFObAKO7K5FKiEzLp4vG7PF91SmNq0A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6347.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(396003)(376002)(136003)(39860400002)(366004)(9686003)(66476007)(66446008)(55016002)(64756008)(5660300002)(110136005)(52536014)(76116006)(83380400001)(53546011)(71200400001)(66556008)(2906002)(478600001)(122000001)(66946007)(7696005)(33656002)(38100700002)(8936002)(86362001)(44832011)(8676002)(316002)(26005)(186003)(6506007)(38070700004);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Q1ZmSG9ocXdzQ2ZuenpEanM4MkRpNXF5MGR0eXFoOUlsRWM0VU1ka1FMZmNU?= =?utf-8?B?WU5udnNxc1NiTWdQamFyUHJlZngzVExLTXhoWWgxcWtIRUdQczNGVlNHWnNu?= =?utf-8?B?Tnh0TUNzdHcrQ3QxckRzNkYyTFFBeGlEZmk4ZG9ibUMwNDMrT1BEQ1FiNHZm?= =?utf-8?B?WVlXVzV0RGMvUWI2YU5wemhHZlhzS0h4cWJva3dLRzBzcEVDQVlRa1E2VERM?= =?utf-8?B?cU1HOUFGSE9XRlZPM3VvcjdraElTdC9tMFBOOFNiUldHekxka25LenhUcmhk?= =?utf-8?B?d29KbWZlTUNUaUNMZjJXYzAwWWtqRGxvNVI0OFhsKzkrSVZiTGlIM2dmQmVu?= =?utf-8?B?WGVvb3VGT203bzVSMWc1aEhENDZ3MGFwbU9OVE44Um10RWlwUVVHWXFsNEd3?= =?utf-8?B?a21kUHdUMEJSeHJlelJzTUYxSE9KeXpDbUU4K3drMVQ2UEV5dnh3REh1Ni9M?= =?utf-8?B?Q2VYQVBEL2JEQzcwd3Y2WXQrTDFneWRNRHdKTUdhczBWOFhIZG02V2FSWDNF?= =?utf-8?B?dHV5R0NLSkdlQ2szQUJMRkNESTNPZ3VJM3V2SmJEeWZLSWpBMXRnZFhqRzJB?= =?utf-8?B?U3E2U2ZXWGtKNFltbnNBWlpFM1Y4eTBORytSQzJZdjlZSGdwZm8vdnR1dDlV?= =?utf-8?B?L2ljdVZJaWZ3ZmRTLytvV0p2eHV6b2hvcys4WlRRaEVnSUZxZTMyaE1GYnJq?= =?utf-8?B?UC8yQnNjcXFiblJEUGZwSXUvK1Jxc2dLaWR5bHNTc3Q5YkVLdTlJbnlTSDAv?= =?utf-8?B?c3VSaHVLT2VWcjdnelFjUit4cTV4OUM5M2tQRVMvbENESTMxUUF5QitCUWU4?= =?utf-8?B?R3hteXExQ2tLLzZ3NTM5WXFnVHZFY0QxbmxZUjhzSlZuK01ERDZQVnRuUWFE?= =?utf-8?B?amcyYUwxQnNoUWw1YTY0SENZTXk0TUI2MUhhZUlManZYVnV2ZWxuYVdEUzQ0?= =?utf-8?B?ZFM5YnllRGdldmNxUVJidXV4K2F1MGVnU1F2UVlyeGZGMGR5K24zMXBRZ2Fa?= =?utf-8?B?MTE4YndiT04ydStrN0lkMVp5M2J4em1LR1pJc1Jjb0s0T3JqYy8wV2RvdHRp?= =?utf-8?B?dFB3RCtRbW5uNndpU2VhaUlmdnVJTnppSEVheklBVUdzditxVTgyQzRqYnpN?= =?utf-8?B?VU00WTNDMWErUkhXSXg0c0x2SE15cmFmOVFsWXZuUmo2NlBKeFhNNm5lOUNp?= =?utf-8?B?c0o0VHZJTlJBYXVwMURVRXNYWkg3NDExOXg5dW5FcE5FSklVTEE1eXVqeVJv?= =?utf-8?B?RTd3ZmJjRlpudTVkazhLL2NOVm10aitEdlVKVWRSeEc3QzdvM1ZwcEZHeGg2?= =?utf-8?B?NzYzUkk5ZVc5SWFPZFpSRTZqWUY4MGF3OVFNbWw0ajVNNTlSb210RHJnN3Rm?= =?utf-8?B?YzlNaEVpMGxWSHBFYUhjOW9TdzRxMm1TYnpBeDNJVFk0VVNJQlZneG5iVlk3?= =?utf-8?B?OUh5cU5sM0M4UkV4cE9UckRybU1SY0tvT2IwSEFhVzYrZGxCV2RlQVdGV2d4?= =?utf-8?B?bVFiMzFSRHR2Z2RRU2diTU45OTJrYjhka00rU1BYeFVXcTVKcVhRMFd5TTZI?= =?utf-8?B?c2NWK002ZExFUkJqZ2w4a1VYK1IybzhycGthbGpBVG9oR1RBbmFzTHMrL2t4?= =?utf-8?B?ZUR2V25sdGVQN3VuRU9YM1IxQVlGSGtMMjh5bE1qSDlDVi8ydWpsN0ZDZDRZ?= =?utf-8?B?cHRIOGl4Q1BOeWR1MEV2aTQ1QXVWc3Arbi9MSVJWK2x0bStYRDk4aGhHQU55?= =?utf-8?Q?RIRuaBm6cznS9r32yU6QYqnr1ZBBcXG1qvBRC6U?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6347.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 794a10fc-8bf3-46cd-2475-08d946c35b72 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2021 12:31:51.5404 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kOoz5idVaKMbR1VHM0DhdgyESNjPj7QJ993Cwz12n5l50MA6j88xk79FIxTAyEq5wHknOa+XcwR35TxiEijyUuqLkOXkMjTm1j7NfYjmOzM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2701 X-OriginatorOrg: citrix.com DQpWZXJ5IHdlbGwsIHBhdGNoIHdpbGwgYmUgcmUtd29ya2VkIGFuZCByZXN1Ym1pdHRlZC4NCg0K TUguDQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBQYXVsIER1cnJhbnQgPHhh ZGltZ25pa0BnbWFpbC5jb20+IA0KU2VudDogMTMgSnVseSAyMDIxIDA5OjUzDQpUbzogTWFydGlu IEhhcnZleSA8bWFydGluLmhhcnZleUBjaXRyaXguY29tPjsgd2luLXB2LWRldmVsQGxpc3RzLnhl bnByb2plY3Qub3JnDQpTdWJqZWN0OiBSZTogW1BBVENIXSBBZGQgbG9nIHRvIFhlbmZpbHQgRHJp dmVyQWRkRGV2aWNlDQoNCltDQVVUSU9OIC0gRVhURVJOQUwgRU1BSUxdIERPIE5PVCByZXBseSwg Y2xpY2sgbGlua3MsIG9yIG9wZW4gYXR0YWNobWVudHMgdW5sZXNzIHlvdSBoYXZlIHZlcmlmaWVk IHRoZSBzZW5kZXIgYW5kIGtub3cgdGhlIGNvbnRlbnQgaXMgc2FmZS4NCg0KT24gMTMvMDcvMjAy MSAwOToyNSwgTWFydGluIEhhcnZleSB3cm90ZToNCj4gWWVzLCB3ZSBkZWZpbml0ZWx5IG5lZWQg dG8gbG9nIGFsbCBmaWx0ZXIgQWRkRGV2aWNlIGNhbGxzLiBIZXJlJ3Mgd2h5Og0KPiANCj4gQ3V0 IGEgbG9uZyBzdG9yeSBzaG9ydCwgdGhlIGN1c3RvbWVyIGxpa2VzIHRvIGRvIGFsbCB0aGUgdGhp bmdzIHRvIGEgVk0gd2hpY2ggdGhleSBub3JtYWxseSBsaWtlIHRvIGRvIHRvIHdpbmRvd3MgbWFj aGluZXMuIFRoaXMgaW5jbHVkZXMgdXBncmFkaW5nIHdpbmRvd3MgZWRpdGlvbnMgdmlhIHdpbmRv d3MgdXBkYXRlIG9uIFdpbjEwLCBhbmQgYWxzbyBpbiBzb21lIGNhc2VzLCBtb3VudGluZyB0aGUg SVNPIGZvciBhIG5ld2VyIHdpbmRvd3Mgc2VydmVyIHZlcnNpb24sIGFuZCB1cGdyYWRpbmcgdGhl IHZlcnNpb24gb2Ygd2luZG93cyBzZXJ2ZXIuDQo+IA0KPiBUaGVzZSB1cGdyYWRlIGNhc2VzIGRv IHNvbWUgZHJpdmVyIG1pZ3JhdGlvbiBzdGVwcywgd2hpY2ggb2Z0ZW4gKGJ1dCBub3QgYWx3YXlz KSB3b3JrIHBlcmZlY3RseS4gVW5mb3J0dW5hdGVseSwgd2UndmUgc2VlbiBjYXNlcyB3aGVyZSBj bGFzcyBVcHBlckZpbHRlciByZWdpc3RyeSBrZXlzIGdvIG1pc3NpbmcgLyBkb24ndCB3b3JrLCBz dWNoIHRoYXQgWGVuRmlsdCBubyBsb25nZXIgYmluZHMgdG8gQUNQSS9QTlAwQTAzIChQQ0lCdXMg aWYgbWVtb3J5IHNlcnZlcykuDQo+IA0KPiBJZiBYZW5GaWx0IGNhbid0IGZpbHRlciB0aGUgYXBw cm9wcmlhdGUgZGV2aWNlcywgKipFdmVyeXRoaW5nKiogYnJlYWtzIC0gcGFydGljdWxhcmx5LCBQ bHVnL1VucGx1ZyBkb2Vzbid0IHdvcmsgcmlnaHQsIGFuZCB0aGUgbWFjaGluZSBjb250aW51YWxs eSBwcm9tcHRzIGZvciByZWJvb3QuIEkgY2FuIGdvIGJhY2sgdGhydSBjYXNlIHJlcG9ydHMgYW5k IGdpdmUgbW9yZSBkZXRhaWxzIGlmIHJlcXVpcmVkLg0KPiANCj4gVHJhY2tpbmcgdGhpcyBkb3du IGFzIHRoZSBuZXdiaWUgYmFjayBpbiBlYXJseSAyMDIwIHRvb2sgKip3ZWVrcyoqLCB3aGVyZSBp dCBjb3VsZCBoYXZlIHRha2VuIGEgZGF5IG9yIHNvLiBUaGF0IGRlYnVnIHByaW50IHdvdWxkIG1h a2UgZGVidWdnaW5nIHNpbWlsYXIgY2FzZXMgdmVyeSBtdWNoIGVhc2llciwgYW5kIGl0J3MgYSBw cm9ibGVtIHdlJ3JlIGxpa2VseSB0byBydW4gaW50byBhZ2Fpbi4NCj4gDQo+IFBsZWFzZSBpbmNs dWRlIHRoZSBkZWJ1ZyBwcmludCBmb3IgZGV2ZWxvcGVycyBzYW5pdHkuDQo+IA0KDQpUaGF0IHNv dW5kcyBsaWtlIGEganVzdGlmaWNhdGlvbiA6LSkgQ2FyZSB0byBzZW5kIGEgdjIgb2YgdGhlIHBh dGNoIHdpdGggKGF0IGxlYXN0IHNvbWUgb2YpIHRoaXMgaW4gdGhlIGNvbW1pdCBtZXNzYWdlPw0K DQogICBDaGVlcnMsDQoNCiAgICAgUGF1bA0KDQo+IE1ILg0KPiANCj4gDQo+IC0tLS0tT3JpZ2lu YWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IHdpbi1wdi1kZXZlbCA8d2luLXB2LWRldmVsLWJvdW5j ZXNAbGlzdHMueGVucHJvamVjdC5vcmc+IE9uIA0KPiBCZWhhbGYgT2YgUGF1bCBEdXJyYW50DQo+ IFNlbnQ6IDEyIEp1bHkgMjAyMSAyMDowNg0KPiBUbzogd2luLXB2LWRldmVsQGxpc3RzLnhlbnBy b2plY3Qub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0hdIEFkZCBsb2cgdG8gWGVuZmlsdCBEcml2 ZXJBZGREZXZpY2UNCj4gDQo+PiBMb2cgYWxsIGNhbGxzIHRvIERyaXZlckFkZERldmljZSwgYW5k IHRoZSB0eXBlIG9mIHRoZSBkZXZpY2UgaWYgDQo+PiBwb3NzaWJsZQ0KPiANCj4gQW55IHBhcnRp Y3VsYXIgcmVhc29uIGV4aXN0ZW50IGxvZ2dpbmcgaXMgaW5zdWZmaWNpZW50PyBJIHRoaW5rIHdl IG5lZWQgbW9yZSBqdXN0aWZpY2F0aW9uIGhlcmUuDQo+IA0KPiANCg0K From win-pv-devel-bounces@lists.xenproject.org Thu Jul 15 13:02:20 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 15 Jul 2021 13:02:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.156588.289009 (Exim 4.92) (envelope-from ) id 1m410M-0007QZ-AX; Thu, 15 Jul 2021 13:02:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 156588.289009; Thu, 15 Jul 2021 13:02:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m410M-0007QS-7V; Thu, 15 Jul 2021 13:02:18 +0000 Received: by outflank-mailman (input) for mailman id 156588; Thu, 15 Jul 2021 13:02:17 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m410K-0007QL-Mp for win-pv-devel@lists.xenproject.org; Thu, 15 Jul 2021 13:02:17 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id aafd8460-c37f-494d-a830-b027d9bb7438; Thu, 15 Jul 2021 13:02:15 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: aafd8460-c37f-494d-a830-b027d9bb7438 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626354135; h=from:to:subject:date:message-id:mime-version; bh=iKGS5uQ7LCbJv0TeUs1WFYPBD0DJdvZAnR0RgbXfRU0=; b=e/QbO4mgtc7KpL6YCmnRCtxPeRDavN2Ft2FH4lOeZU4+mwVRcgENXn2+ YlluRm4Hn6opXmaK66exFmnRTVnlucuXg/aODayPYi3zoAJ2CUaU9kTt/ 3p8q0cqqhXMdxXZKAd4EdElblR1sgNId1QkeH5Zk20+OEuRyn2PI4vLuz I=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 0mdiPrmPA/ECR6ef7Pe5Ivd3wVebqxJrRoXv8iWGcU/NniZt1swWyM4d7nBEbTk2zqX5ifKK9B 3e3en3PmXa51Ap2W4OQG1KSv0dUwb8RLvTyy4UbwlIEe1ck5DfiwLFrN8MTBM6maWm8gfREojS emfJyqecLeOBgVx10SGcS+UwvvzecTownk5XK2RsXGzTmXIY7noCY+zbmSaEFMwSHth2zw27mE 9tf0foiAk2FW3zKZDnBn7yFF5IN+LqA75dhC/ilkFFH33oCfRPRBTR8/CWcquNjaa99p0GniZp uaw= X-SBRS: 5.1 X-MesageID: 48398744 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:c4ReIqsYmW3zp+UKl4I/u3Fy7skDjNV00zEX/kB9WHVpm6yj+v xGUs566faUskd0ZJhEo7q90ca7Lk80maQa3WBzB8bGYOCFghrKEGgK1+KLrwEIcxeUygc379 YDT0ERMrzN5VgRt7eG3OG7eexQvOVuJsqT9JjjJ3QGd3AVV0l5hT0JbTpyiidNNXJ77ZxSLu v72uN34wCOVF4wdcqBCnwMT4H41qf2fMKPW29+O/Y/gjP+9Q+V1A== X-IronPort-AV: E=Sophos;i="5.84,242,1620705600"; d="scan'208,223";a="48398744" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YowDU3Bv4bzG/wHtbcDMPObMYeq4swxyBC4wR6UpjXLwg7dC9wbX15cV3OF5WqomCHm/VmAwtWwbMvJ9kDha2maSkD2PY0A19hRMr79sWwHh79shxrYT6Dhb5M5y9azq/UV5zwdIMdqAYkXCT/ow3abMXsATeEt8IXv41Rd6eaWWDFNKegi9rh2VCa3XP2+o3qp5OTGZV5Rhw78kbr43VEAO3uQDJ2xkhEHsRZqTisCpK7kdrhojGdMXLoCqfExfPLeMaOHTs4K/aQVrpRE5Vu2nIaqTLx6FJQX36Qo4qMhau3qLb9J3DrLHW5QEHAHF63TdhLL4g/UD2iJW2lXjGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zDE0Zv8Ft4VycI9OjlTJ/z8K4fR8Txo/XsoeGwISmKk=; b=Nuds+WOMKUxI9EShbeRFBXtZHyg4+vlX6+FAEwbX2VIa85oyoldvLosdep+5GRSQcxLl38BNY1jV0Iad6OC4Ut0AXcbHHsKjBHi7J4nqiaKzXr9EYGdX5oRwSWMF6SVxvmRAo+CMkWO1NU3muh2PKwp+iGf1h1tCGS+jLZl/EsX30HHeNZg1cDv8xBFVuVIl2m5QFLurnV59nMpFk+7UFDDdMUU09AZhkCqAbN0VMQ5aVT9GVpXnBF34hzKzrAsLY0PzhCCyM+sZISMO4cZXqzfFXlaEm9m1RCmVutS5r9lzCGZpgllH7C86g0+LzD4bhjZv74pmFU3mkc8MtRHgTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zDE0Zv8Ft4VycI9OjlTJ/z8K4fR8Txo/XsoeGwISmKk=; b=v6Y/AGZ0oqLzDiCpMi6VVumCvBLKlfGZ/NtAZjt/VK4rx4AV449F73a5zPbZFGkBq0ypV5Ra++ViPCH0GQ9Btj59+2MD+1PxCWNmixQfw8N6xpDGPzc1jL+o2GKHzcm4r2hadWRScR6qwrhSOdc2OVxjbCoscbvHaE3r76CLFWI= From: Martin Harvey To: "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Subject: [PATCH] Reformatted logging patches. Thread-Topic: [PATCH] Reformatted logging patches. Thread-Index: Add5eVvoWYS5xRZxQn6Btq/6GsOrrg== Date: Thu, 15 Jul 2021 13:02:06 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d1088228-9695-4603-e06f-08d94790bfd2 x-ms-traffictypediagnostic: MWHPR03MB3152: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:576; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bV/0nleGFfhjZRKYlFJT3aFlc0FOp+NTU0Uo0lLM7t4ylu6fMULD1HoVnDHDlTIVnJs05vVjgcd0IijvewaIfih75vou3eBgWx/nJpTpBSlT1TY0eFyFzfJlvAZwS7OPvOLKaFlEnkTOhdgFBpQGaLpZxFUPU93N9qJmj21mLRvCV0msQXCyrvq7UfgzsCY1CGzwPrx687fInNgam6komYDzn3gT+X0B6Ck+1hmqEXIrQJ4e840B4H8YCSAEr/PFFeGWY+nr/A62EsUAFRNG5p+oguQlO+4u/4zQYNubyruzvI68OYNbBrAsaFy6MhYVv3GL1yKgAIOW1h4Uw8YhVpXJXUFpU7ImG++c7Nr2PUvbmMfRSkqukmMD8l4o9rQDvrq/6snF7Rtl1/HtrwhE6sodB4TlChco1SkCG3EiVUy/ooFIUNlXxvHJFF+nUaBZQA3lHAKnruev+eJUGWnHlft9cxxLTRgtHP3b55TNW/IijPis3hiLP2iomWhv+O2kaqcq/BQC+934bHZ2fp2xOvITYUuwkI2Ghes1n/qFZAFzezeDGayw1Q9oKNqfy3EgurV/Z8/NZTKoH2w6Hu2OhVpX5ieR4iLq+MxtK2BAXw1dL4TJ+5sj2zfv57Xwbz7hLbhE27y1/OP4ybXJJrlKbCvXEU9x8OM5LbRG/a2kNhw3SUI61gKfLIqbwdR+H5tHDdJPpAu9g8IRcq2YPSSe6w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6347.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(376002)(396003)(346002)(366004)(39860400002)(86362001)(99936003)(83380400001)(55016002)(186003)(66556008)(38100700002)(26005)(2906002)(7696005)(52536014)(45080400002)(5660300002)(8676002)(44832011)(33656002)(6506007)(71200400001)(122000001)(9686003)(66576008)(316002)(8936002)(66446008)(66946007)(66476007)(76116006)(110136005)(478600001)(64756008)(558084003)(38070700004);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?aElacmlYeHZkaktuRGwvTjhqeWRoY1k4T2R1TlJBZktieGJubnFwbXhDTVlP?= =?utf-8?B?aWpOOVQyVjZNZTdvdzNiRHlaUTA3YzdTekFDUmtmTU5ub04wYkwrMC84Z0xa?= =?utf-8?B?SFBkZFJqWlUyWWVFUjlsRTF0bGVKdVFwTWRGemc3TmNFQkdnaDJqOWJKSWpx?= =?utf-8?B?QzRsdjVSaDljKzNNMmRHeFBSYUZqekFKN01sYndTcEVqbWFsZE96M1N2eEtB?= =?utf-8?B?dVZDT0ZaSU5Sb2VvKzhRbkFDQ0pZMkRxaXNNSS94c1lZU2VaNnhlM0J6dGkw?= =?utf-8?B?bHRZVXdkN29LdXQwbSt4MW1NS1JOSk0yditUWVU3NHI2ZzRtTnRtcFcvY2RZ?= =?utf-8?B?VXFzOXR2UWUzZnlPeUE3d29hY1pUeGc3QWQvb3ViK0dsU3ppTkJnNWZZeEFM?= =?utf-8?B?OFBwd1QwUXNPWGh5QUlzYnYwOGxaQmJzVW9wWmxpODhjZE9PcG80cnlOTTlO?= =?utf-8?B?TEtuWnc4NDM5RGVaSVpXZkZ6WG0wb2hxTWJJd1NoTXJ1Wll3cUUrRVpMcXor?= =?utf-8?B?WnVQV05ON1UwUVIyVmlXS2dJazZ5UVFQTGpES2VzbnBYaHNaTmE0UW8rZ1Ax?= =?utf-8?B?azRXN2R2a3dqYU8zUTJvZWUyVXRWa0xFS015OSs1YWk3L2x5eEVaZVNBMWtG?= =?utf-8?B?UFFEdTN5RUg1OWJ1N0NWYi9XNkJIQXN4Y3hneTIyZTZEUUFnVVBJOHRxalFN?= =?utf-8?B?TjBTRVFxeGN2TnFoNHl4WVFBaFp5M2JLOTNNK2VHK2pneWhGNVdNb3UyeDA1?= =?utf-8?B?VzN3UzkyM3FxS0hreUVweElscURYYWFkV2pXTi9qOGtIZVhJNDJ5NzJrTXlT?= =?utf-8?B?amNNNmJsRzZvYXoyY3J1cDh2ZWo5MGV6d25DUzBFQXYvdmlia09hUTRXUnBN?= =?utf-8?B?NXRIeWZRWW9tTGIvNGRhYjg4MHdRNkpvWTFoTVh2b3MvdU1iR1VKNzUwMmw1?= =?utf-8?B?cmtCdWZFL3RrT2diV0srNGorTHRwUXpGVkVhelQrMWJSdkQ4WDNRRnYxaGh1?= =?utf-8?B?Q01sOGpidCsxSkE0MVJiQXBSWDczdDNYbE1OMDJiYVlGTVZPdkVZYmlJNzlD?= =?utf-8?B?cXdwTlU2THRpVlp3ZWlqSVVPbzNaQ3dWRjZLckNmbEpobm9mTTYvWmJ1ZFd4?= =?utf-8?B?d0d1b2tIRmVRSkRxMnZxdDdhZUdGdFNmcHpxQ3drS0FyNEJLM3poZCttUmhR?= =?utf-8?B?NURjN01FR1oyVkFkbnozSEZvRm1EZnhrY2JkTWdUdUtlQkM0V0dVd0Nmc09h?= =?utf-8?B?WHFBQ3BHNHdMVW9Gb1VUOEdxZ0tjTjVMYWU3NTc3Q25TSnQ5dzBtTGQ5THdx?= =?utf-8?B?OXpPalpna0RGVi9JYVJpY0dJV0JIQWlINzBPOUFUZ0VuRmtlMHhkRHliTHNr?= =?utf-8?B?ZnJyS2IzYk1Ja1kzd1ZmelZsemdkRmF0bTI0Nk9NUFZwMzEwaXlYTnZxeWpT?= =?utf-8?B?Zk1EbjlGVFJIdTJLbU1oeEE0WnUveHoxVk5BdEU2bDY0dThicWYzdTFQRU1y?= =?utf-8?B?UFgxQ1ZPRk0xNHZFNUUrZno2WmpjVnV3QU91WVloSEkrbUdISDJib0dCZ0Q1?= =?utf-8?B?b3NHL0RtMWdtOGdTeG1pWnMwdU80TmpFeW1MZ1VTbDdBbmNzMjhwaXJIcHF1?= =?utf-8?B?Z0tZQmgrRllLemxvR3V6RmQxSkJPRmNNV1NYTGc0RlBFOHVJS0tnbzBMdGxF?= =?utf-8?B?eGoyVEFwS0NjVHRMOFNjM3lPeElXcEMrQWNmaGpPR0lOQkNHMWVPR2FZbDNH?= =?utf-8?Q?ML2eKqqJEFruyyw2csH0SCNYjoyS/QQ5q82/UMK?= x-ms-exchange-transport-forked: True Content-Type: multipart/mixed; boundary="_004_MW4PR03MB63479F210E41DB70F1C11C679A129MW4PR03MB6347namp_" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6347.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1088228-9695-4603-e06f-08d94790bfd2 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jul 2021 13:02:06.7631 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: w0cBYHaS3Un/RTe6Zx4mcJ5obHm28FopcyW5YwjQbsB4/W+yH4h7B+cyeXF1rVDsgBUbQo96oEp0XMv1zMmX5zAFegOIgmjIoWZIiPnm1cg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB3152 X-OriginatorOrg: citrix.com --_004_MW4PR03MB63479F210E41DB70F1C11C679A129MW4PR03MB6347namp_ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 DQpBbGwgdGhyZWUgbG9nZ2luZyBwYXRjaGVzIG5vdyByZWZvcm1hdHRlZCwgYW5kIGNvbW1pdCBt ZXNzYWdlcyB0aWRpZWQgdXAuIFRoZXNlIGhhdmUgYmVlbiBhdHRhY2hlZC4gUGxlYXNlIGxldCBt ZSBrbm93IGlmIHlvdSByZXF1aXJlIHRoZSBleGFjdCBtYWlsIGZvcm1hdCBwcm92aWRlZCBieSAi Z2l0IHNlbmQtZW1haWwiIG9yIHdoZXRoZXIgdGhlIGN1cnJlbnQgTVMgT3V0bG9vayBhdHRhY2ht ZW50cyBhcmUgc3VmZmljaWVudC4NCg0KTUguDQoNCg== --_004_MW4PR03MB63479F210E41DB70F1C11C679A129MW4PR03MB6347namp_ Content-Type: application/octet-stream; name="0001-Additional-logging-for-module-loading.patch" Content-Description: 0001-Additional-logging-for-module-loading.patch Content-Disposition: attachment; filename="0001-Additional-logging-for-module-loading.patch"; size=1037; creation-date="Thu, 15 Jul 2021 12:52:40 GMT"; modification-date="Thu, 15 Jul 2021 12:59:39 GMT" Content-Transfer-Encoding: base64 RnJvbSBlZjRiZWMzNTZiYzdlNTgwYjg5MzQ0ZTA1MTE5NzY3ZjE1MzIzMzQyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gSGFydmV5IDxNYXJ0aW4uSGFydmV5QGNpdHJpeC5j b20+CkRhdGU6IFRodSwgMTUgSnVsIDIwMjEgMTM6NDk6MjUgKzAxMDAKU3ViamVjdDogW1BBVENI IDEvM10gQWRkaXRpb25hbCBsb2dnaW5nIGZvciBtb2R1bGUgbG9hZGluZy4KClJlY2VudCByZWxl YXNlcyBvZiBXaW5kb3dzICgxMCBhbmQgMTEgaW4gcGFydGljdWxhcikgYWxsb3cKb25saW5lIGVk aXRpb24gdXBkYXRlcyB3aGljaCBpbnZvbHZlIGEgZHJpdmVyIG1pZ3JhdGlvbiBzdGVwLAp3aGlj aCBvY2N1cnMgaW4gU0FGRUJPT1QgbW9kZS4KCkluIHNvbWUgcmFyZSBjYXNlcywgdGhpcyBzdGVw IG1heSBmYWlsIChmb3IgYSB2YXJpZXR5IG9mIHJlYXNvbnMpLgpUaGlzIGFkZGl0aW9uYWwgbG9n Z2luZyBhZGRlZCB0byBkZWJ1ZyBzdWNoIHVwZ3JhZGUgY2FzZXMuCgpTaWduZWQtT2ZmLUJ5OiBN YXJ0aW4gSGFydmV5IDxtYXJ0aW4uaGFydmV5QGNpdHJpeC5jb20+Ci0tLQogc3JjL3hlbi9tb2R1 bGUuYyB8IDUgKysrKysKIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKykKCmRpZmYgLS1n aXQgYS9zcmMveGVuL21vZHVsZS5jIGIvc3JjL3hlbi9tb2R1bGUuYwppbmRleCBkYTdmMTEzLi4x ODEzZTNiIDEwMDY0NAotLS0gYS9zcmMveGVuL21vZHVsZS5jCisrKyBiL3NyYy94ZW4vbW9kdWxl LmMKQEAgLTE0NSw2ICsxNDUsMTEgQEAgTW9kdWxlQWRkKAogICAgIEJPT0xFQU4gICAgICAgICAg ICAgQWZ0ZXI7CiAgICAgTlRTVEFUVVMgICAgICAgICAgICBzdGF0dXM7CiAKKyAgICBJbmZvKCIl cCAtICVwIFslc11cbiIsCisgICAgICAgICBTdGFydCwKKyAgICAgICAgIFN0YXJ0ICsgU2l6ZSAt IDEsCisgICAgICAgICBOYW1lKTsKKwogICAgIE5ldyA9IF9fTW9kdWxlQWxsb2NhdGUoc2l6ZW9m IChNT0RVTEUpKTsKIAogICAgIHN0YXR1cyA9IFNUQVRVU19OT19NRU1PUlk7Ci0tIAoyLjI1LjAu d2luZG93cy4xCgo= --_004_MW4PR03MB63479F210E41DB70F1C11C679A129MW4PR03MB6347namp_ Content-Type: application/octet-stream; name="0002-Add-logging-for-XenFilt-AddDevice.patch" Content-Description: 0002-Add-logging-for-XenFilt-AddDevice.patch Content-Disposition: attachment; filename="0002-Add-logging-for-XenFilt-AddDevice.patch"; size=1605; creation-date="Thu, 15 Jul 2021 12:52:40 GMT"; modification-date="Thu, 15 Jul 2021 12:59:39 GMT" Content-Transfer-Encoding: base64 RnJvbSA5Zjk2OTcwMDIzZDZiMTE3YTZlOGU4YWIwODQ4ZmI5MWQwODRmY2Q1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gSGFydmV5IDxNYXJ0aW4uSGFydmV5QGNpdHJpeC5j b20+CkRhdGU6IFRodSwgMTUgSnVsIDIwMjEgMTM6NTA6NDMgKzAxMDAKU3ViamVjdDogW1BBVENI IDIvM10gQWRkIGxvZ2dpbmcgZm9yIFhlbkZpbHQgQWRkRGV2aWNlLgoKUmVjZW50IHJlbGVhc2Vz IG9mIFdpbmRvd3MgKDEwIGFuZCAxMSBpbiBwYXJ0aWN1bGFyKSBhbGxvdwpvbmxpbmUgZWRpdGlv biB1cGRhdGVzIHdoaWNoIGludm9sdmUgYSBkcml2ZXIgbWlncmF0aW9uIHN0ZXAsCndoaWNoIG9j Y3VycyBpbiBTQUZFQk9PVCBtb2RlLgoKSW4gc29tZSByYXJlIGNhc2VzLCB0aGlzIHN0ZXAgbWF5 IGZhaWwgKGZvciBhIHZhcmlldHkgb2YgcmVhc29ucykuClRoaXMgYWRkaXRpb25hbCBsb2dnaW5n IGFkZGVkIHRvIGRlYnVnIHN1Y2ggdXBncmFkZSBjYXNlcy4KClNpZ25lZC1PZmYtQnk6IE1hcnRp biBIYXJ2ZXkgPG1hcnRpbi5oYXJ2ZXlAY2l0cml4LmNvbT4KLS0tCiBzcmMveGVuZmlsdC9kcml2 ZXIuYyB8IDE3ICsrKysrKysrKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgMTcgaW5zZXJ0aW9u cygrKQoKZGlmZiAtLWdpdCBhL3NyYy94ZW5maWx0L2RyaXZlci5jIGIvc3JjL3hlbmZpbHQvZHJp dmVyLmMKaW5kZXggZTllNjY3My4uZjEzMTI4MiAxMDA2NDQKLS0tIGEvc3JjL3hlbmZpbHQvZHJp dmVyLmMKKysrIGIvc3JjL3hlbmZpbHQvZHJpdmVyLmMKQEAgLTcyMyw2ICs3MjMsMTkgQEAgZmFp bDE6CiAgICAgcmV0dXJuIHN0YXR1czsKIH0KIAorc3RhdGljIEZPUkNFSU5MSU5FIFBDSEFSCitf X0VtdWxhdGVkVHlwZU5hbWUoCisgICAgSU4gIFhFTkZJTFRfRU1VTEFURURfT0JKRUNUX1RZUEUg ICAgVHlwZQorICAgICkKK3sKKyAgICBzd2l0Y2ggKFR5cGUpIHsKKyAgICBjYXNlIFhFTkZJTFRf RU1VTEFURURfT0JKRUNUX1RZUEVfVU5LTk9XTjogIHJldHVybiAiVU5LTk9XTiI7CisgICAgY2Fz ZSBYRU5GSUxUX0VNVUxBVEVEX09CSkVDVF9UWVBFX1BDSTogICAgICByZXR1cm4gIlBDSSI7Cisg ICAgY2FzZSBYRU5GSUxUX0VNVUxBVEVEX09CSkVDVF9UWVBFX0lERTogICAgICByZXR1cm4gIklE RSI7CisgICAgZGVmYXVsdDogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZXR1 cm4gIkludmFsaWRUeXBlIjsKKyAgICB9Cit9CisKIHN0YXRpYyBYRU5GSUxUX0VNVUxBVEVEX09C SkVDVF9UWVBFCiBEcml2ZXJHZXRFbXVsYXRlZFR5cGUoCiAgICAgSU4gIFBDSEFSICAgICAgICAg ICAgICAgICAgICAgICBJZApAQCAtODA0LDYgKzgxNywxMCBAQCBEcml2ZXJBZGREZXZpY2UoCiAg ICAgICAgIH0KICAgICB9CiAKKyAgICBJbmZvKCIlcCAlc1xuIiwKKyAgICAgICAgIFBoeXNpY2Fs RGV2aWNlT2JqZWN0LAorICAgICAgICAgX19FbXVsYXRlZFR5cGVOYW1lKFR5cGUpKTsKKwogICAg IHN0YXR1cyA9IFNUQVRVU19TVUNDRVNTOwogICAgIGlmIChUeXBlID09IFhFTkZJTFRfRU1VTEFU RURfT0JKRUNUX1RZUEVfVU5LTk9XTikKICAgICAgICAgZ290byBkb25lOwotLSAKMi4yNS4wLndp bmRvd3MuMQoK --_004_MW4PR03MB63479F210E41DB70F1C11C679A129MW4PR03MB6347namp_ Content-Type: application/octet-stream; name="0003-Disable-CONS-debug-logging.patch" Content-Description: 0003-Disable-CONS-debug-logging.patch Content-Disposition: attachment; filename="0003-Disable-CONS-debug-logging.patch"; size=1219; creation-date="Thu, 15 Jul 2021 12:52:40 GMT"; modification-date="Thu, 15 Jul 2021 12:59:39 GMT" Content-Transfer-Encoding: base64 RnJvbSA3YTcyYTA1N2QzMjM5MmI4NjViNTQ2NWM4YThiZjdhYTM4NWY3Y2MzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gSGFydmV5IDxNYXJ0aW4uSGFydmV5QGNpdHJpeC5j b20+CkRhdGU6IFRodSwgMTUgSnVsIDIwMjEgMTM6NTY6NTEgKzAxMDAKU3ViamVjdDogW1BBVENI IDMvM10gRGlzYWJsZSBDT05TIGRlYnVnIGxvZ2dpbmcKCkluIHNvbWUgY2FzZXMsIHRoaXJkIHBh cnR5IGFudGl2aXJ1cyBwcm9kdWN0cyBtYXkgc2VuZCBtYW55ClBuUCBxdWVyeSBJUlAncyBkb3du IHRoZSBzdGFjay4gVGhpcyB0ZW5kcyB0byBmaWxsIHRoZSBsb2dmaWxlcyB1cAp3aXRoIHVubmVj ZXNzYXJ5IHJlcGVhdGVkIGxpbmVzLCBtYWtpbmcgZGVidWdnaW5nIG9mIG90aGVyCmZhaWx1cmVz IGRpZmZpY3VsdC4KClByZXZpb3VzIGxvZ2xldmVsIHdhcyAoSU5GT3xXQVJOSU5HfEVSUk9SfENS SVRJQ0FMKQoKU2lnbmVkLU9mZi1CeTogTWFydGluIEhhcnZleSA8bWFydGluLmhhcnZleUBjaXRy aXguY29tPgotLS0KIHNyYy94ZW5idXMvZHJpdmVyLmMgfCA1ICstLS0tCiAxIGZpbGUgY2hhbmdl ZCwgMSBpbnNlcnRpb24oKyksIDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL3hlbmJ1 cy9kcml2ZXIuYyBiL3NyYy94ZW5idXMvZHJpdmVyLmMKaW5kZXggMDY3YmI2OC4uZTA3ZGU1NSAx MDA2NDQKLS0tIGEvc3JjL3hlbmJ1cy9kcml2ZXIuYworKysgYi9zcmMveGVuYnVzL2RyaXZlci5j CkBAIC01OCwxMCArNTgsNyBAQCB0eXBlZGVmIHN0cnVjdCBfWEVOQlVTX0RSSVZFUiB7CiBzdGF0 aWMgWEVOQlVTX0RSSVZFUiAgICBEcml2ZXI7CiAKICNkZWZpbmUgWEVOQlVTX0RSSVZFUl9UQUcg ICAnVklSRCcKLSNkZWZpbmUgREVGQVVMVF9DT05TT0xFX0xPR19MRVZFTCAgIChMT0dfTEVWRUxf SU5GTyB8ICAgICAgIFwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBMT0df TEVWRUxfV0FSTklORyB8ICAgIFwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBMT0dfTEVWRUxfRVJST1IgfCAgICAgIFwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBMT0dfTEVWRUxfQ1JJVElDQUwpCisjZGVmaW5lIERFRkFVTFRfQ09OU09MRV9MT0df TEVWRUwgICAwCiAKIHN0YXRpYyBGT1JDRUlOTElORSBQVk9JRAogX19Ecml2ZXJBbGxvY2F0ZSgK LS0gCjIuMjUuMC53aW5kb3dzLjEKCg== --_004_MW4PR03MB63479F210E41DB70F1C11C679A129MW4PR03MB6347namp_-- From win-pv-devel-bounces@lists.xenproject.org Thu Jul 15 13:09:13 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 15 Jul 2021 13:09:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.156595.289013 (Exim 4.92) (envelope-from ) id 1m4172-0007t0-Rq; Thu, 15 Jul 2021 13:09:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 156595.289013; Thu, 15 Jul 2021 13:09:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m4172-0007st-Oz; Thu, 15 Jul 2021 13:09:12 +0000 Received: by outflank-mailman (input) for mailman id 156595; Thu, 15 Jul 2021 13:09:11 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m4170-0007sm-SK for win-pv-devel@lists.xenproject.org; Thu, 15 Jul 2021 13:09:11 +0000 Received: from smtp-fw-9102.amazon.com (unknown [207.171.184.29]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d705b212-e56d-11eb-88d0-12813bfff9fa; Thu, 15 Jul 2021 13:09:09 +0000 (UTC) Received: from pdx4-co-svc-p1-lb2-vlan3.amazon.com (HELO email-inbound-relay-1e-a70de69e.us-east-1.amazon.com) ([10.25.36.214]) by smtp-border-fw-9102.sea19.amazon.com with ESMTP; 15 Jul 2021 13:08:37 +0000 Received: from EX13D32EUC003.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan3.iad.amazon.com [10.40.159.166]) by email-inbound-relay-1e-a70de69e.us-east-1.amazon.com (Postfix) with ESMTPS id 357CFA189B; Thu, 15 Jul 2021 13:08:34 +0000 (UTC) Received: from EX13D32EUC003.ant.amazon.com (10.43.164.24) by EX13D32EUC003.ant.amazon.com (10.43.164.24) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Thu, 15 Jul 2021 13:08:34 +0000 Received: from EX13D32EUC003.ant.amazon.com ([10.43.164.24]) by EX13D32EUC003.ant.amazon.com ([10.43.164.24]) with mapi id 15.00.1497.023; Thu, 15 Jul 2021 13:08:34 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: d705b212-e56d-11eb-88d0-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.co.uk; i=@amazon.co.uk; q=dns/txt; s=amazon201209; t=1626354550; x=1657890550; h=from:to:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version:subject; bh=untQwYbJkKsvkFCf4vC4NHS1GoLQkIE6JB1ZBKxGe9k=; b=XBHc7fXt6h6eT+0SXF9EQXHMZd1IWXbRwUnUI469UbKcg57Tv8JPBqdE VcH9gIE38Yj0WwfCcd7cRRqoy7fEuDfYaaUvy//wULGSX0+rV/sE6kwHd Twc8QicMSPMDCNVzJqlSz8bAFF3wGnGqCxUrMXW8KCGI1KGzs/k2k4RVY Q=; X-IronPort-AV: E=Sophos;i="5.84,242,1620691200"; d="scan'208";a="145670172" Subject: RE: [PATCH] Reformatted logging patches. Thread-Topic: [PATCH] Reformatted logging patches. From: "Durrant, Paul" To: Martin Harvey , "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Thread-Index: Add5eVvoWYS5xRZxQn6Btq/6GsOrrgAARAQg Date: Thu, 15 Jul 2021 13:08:34 +0000 Message-ID: <6313da17e2814f52ad0f850e93771176@EX13D32EUC003.ant.amazon.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.165.145] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiB3aW4tcHYtZGV2ZWwgPHdpbi1w di1kZXZlbC1ib3VuY2VzQGxpc3RzLnhlbnByb2plY3Qub3JnPiBPbiBCZWhhbGYgT2YgTWFydGlu IEhhcnZleQ0KPiBTZW50OiAxNSBKdWx5IDIwMjEgMTQ6MDINCj4gVG86IHBhdWxAeGVuLm9yZzsg d2luLXB2LWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IFN1YmplY3Q6IFtFWFRFUk5BTF0g W1BBVENIXSBSZWZvcm1hdHRlZCBsb2dnaW5nIHBhdGNoZXMuDQo+IA0KPiBDQVVUSU9OOiBUaGlz IGVtYWlsIG9yaWdpbmF0ZWQgZnJvbSBvdXRzaWRlIG9mIHRoZSBvcmdhbml6YXRpb24uIERvIG5v dCBjbGljayBsaW5rcyBvciBvcGVuDQo+IGF0dGFjaG1lbnRzIHVubGVzcyB5b3UgY2FuIGNvbmZp cm0gdGhlIHNlbmRlciBhbmQga25vdyB0aGUgY29udGVudCBpcyBzYWZlLg0KPiANCj4gDQo+IA0K PiBBbGwgdGhyZWUgbG9nZ2luZyBwYXRjaGVzIG5vdyByZWZvcm1hdHRlZCwgYW5kIGNvbW1pdCBt ZXNzYWdlcyB0aWRpZWQgdXAuIFRoZXNlIGhhdmUgYmVlbiBhdHRhY2hlZC4NCj4gUGxlYXNlIGxl dCBtZSBrbm93IGlmIHlvdSByZXF1aXJlIHRoZSBleGFjdCBtYWlsIGZvcm1hdCBwcm92aWRlZCBi eSAiZ2l0IHNlbmQtZW1haWwiIG9yIHdoZXRoZXIgdGhlDQo+IGN1cnJlbnQgTVMgT3V0bG9vayBh dHRhY2htZW50cyBhcmUgc3VmZmljaWVudC4NCg0KUGxlYXNlIHVzZSBnaXQgc2VuZC1lbWFpbC4g V2UgdXNlIHRoZSBzYW1lIHBhdGNoIHN1Ym1pc3Npb24gcHJvY2VzcyBhcyBYZW4uDQoNCiAgVGhh bmtzLA0KDQogICAgUGF1bA0KDQo+IA0KPiBNSC4NCg0K From win-pv-devel-bounces@lists.xenproject.org Thu Jul 15 13:15:36 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 15 Jul 2021 13:15:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.156602.289018 (Exim 4.92) (envelope-from ) id 1m41DD-0000Oi-CZ; Thu, 15 Jul 2021 13:15:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 156602.289018; Thu, 15 Jul 2021 13:15:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m41DD-0000OZ-8r; Thu, 15 Jul 2021 13:15:35 +0000 Received: by outflank-mailman (input) for mailman id 156602; Thu, 15 Jul 2021 13:15:34 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m41DC-0000OO-0C for win-pv-devel@lists.xenproject.org; Thu, 15 Jul 2021 13:15:34 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id bb8621bb-e56e-11eb-88d0-12813bfff9fa; Thu, 15 Jul 2021 13:15:32 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: bb8621bb-e56e-11eb-88d0-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626354932; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=n3B3+O6N6x7SgdbNXNzjT0zonKx5LPipLk4/xLbZi4E=; b=UwKNSSGhTW7NTX5D4GxTdq0JpR+QDHT6XNuBWRSmUBP9ZVId41OGOd1I Qhb2AEV2etYbDCaF2xNifHPEqpxqNDaz9eVeDFzTrUsX1UdeyeTv3Bde6 /Fm22G20KvZYla4/ZMtFhjIX83qSN933ZyxyaoNXGMo8mSEY/Rm9Zh1Js 8=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: UMWck0lca3cOwKGf2eaQnLyTKPvxr+BlnBO+0rlF5p82zmUud2Ro5m8VEXA5fLW0DxHZN4FvLf 9kRxYw7FfHaKjYHDZf9ywewtU5eu+t8wXGkGHpnlsmuxi4lPfcL3M8Cko1Zx+1FfNQyGBwp0HI qGSg5Lj6YK9kwk1Bh29G3dNfIf87ivpb502zqzlLr8GNp+pRAZoBOohzFzG5CkjY7L3cMLJ7bw +mGYg2rcgBBM8kMJtrwwspHl/KMG07ioEBBoXCJ1LCVvjuPTspdRAttmH799u0qdrnGeKnna/I ihs= X-SBRS: 5.1 X-MesageID: 48403463 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:19tku6+ssXdVBH2Fb9tuk+DiI+orL9Y04lQ7vn2YSXRuE/Bw8P re5cjztCWE8wr5N0tQ+uxoVJPufZqYz+8Q3WBzB8bFYOCFghrLEGgK1+KLqFeMdxEWtNQtsp uIG5IOcOEYZmIbsS+V2meF+q4bsby6zJw= X-IronPort-AV: E=Sophos;i="5.84,242,1620705600"; d="scan'208";a="48403463" From: Martin Harvey To: CC: Martin Harvey , Martin Harvey Subject: [PATCH 2/3] Add logging for XenFilt AddDevice. Date: Thu, 15 Jul 2021 14:15:01 +0100 Message-ID: <20210715131502.176-2-Martin.Harvey@citrix.com> X-Mailer: git-send-email 2.25.0.windows.1 In-Reply-To: <20210715131502.176-1-Martin.Harvey@citrix.com> References: <20210715131502.176-1-Martin.Harvey@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Recent releases of Windows (10 and 11 in particular) allow online edition updates which involve a driver migration step, which occurs in SAFEBOOT mode. In some rare cases, this step may fail (for a variety of reasons). This additional logging added to debug such upgrade cases. Signed-Off-By: Martin Harvey --- src/xenfilt/driver.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/src/xenfilt/driver.c b/src/xenfilt/driver.c index e9e6673..f131282 100644 --- a/src/xenfilt/driver.c +++ b/src/xenfilt/driver.c @@ -723,6 +723,19 @@ fail1: return status; } +static FORCEINLINE PCHAR +__EmulatedTypeName( + IN XENFILT_EMULATED_OBJECT_TYPE Type + ) +{ + switch (Type) { + case XENFILT_EMULATED_OBJECT_TYPE_UNKNOWN: return "UNKNOWN"; + case XENFILT_EMULATED_OBJECT_TYPE_PCI: return "PCI"; + case XENFILT_EMULATED_OBJECT_TYPE_IDE: return "IDE"; + default: return "InvalidType"; + } +} + static XENFILT_EMULATED_OBJECT_TYPE DriverGetEmulatedType( IN PCHAR Id @@ -804,6 +817,10 @@ DriverAddDevice( } } + Info("%p %s\n", + PhysicalDeviceObject, + __EmulatedTypeName(Type)); + status = STATUS_SUCCESS; if (Type == XENFILT_EMULATED_OBJECT_TYPE_UNKNOWN) goto done; -- 2.25.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Thu Jul 15 13:15:36 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 15 Jul 2021 13:15:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.156603.289022 (Exim 4.92) (envelope-from ) id 1m41DE-0000QJ-DT; Thu, 15 Jul 2021 13:15:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 156603.289022; Thu, 15 Jul 2021 13:15:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m41DE-0000QB-AG; Thu, 15 Jul 2021 13:15:36 +0000 Received: by outflank-mailman (input) for mailman id 156603; Thu, 15 Jul 2021 13:15:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m41DD-0000OU-4b for win-pv-devel@lists.xenproject.org; Thu, 15 Jul 2021 13:15:35 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id dd46fdd5-8a2c-4cb1-aec0-8958f79c2305; Thu, 15 Jul 2021 13:15:34 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: dd46fdd5-8a2c-4cb1-aec0-8958f79c2305 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626354934; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=IT3OePtO/MGmhd99mzaZGLVBTbF9fJj20tHs8vac2Iw=; b=IzmxG2YcWohN3ia5T8rHqLC3YmZyymkuE7nAUxxYgAQ5IwYVrurKXyEK MvGNApINLSx0/VDJyfPpn9eElJHeaXzwtN2XjEqUEEIiLyNqMVEsUggQ3 RxrvYVokfZByb1K9QCu1ThGI5z8onmdGhd/NKZ8J7M8Aaq/tQzdVnvn/W w=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: UOaEHPspsx+BaxFzH0v82KJ/Xnw8jdt3KoJnHUhQ+2be5coT7HSLnFWb4i+fT85EQwKnb5iNyj WXXGwgiGXQxR3x0m8+LSqq3fzodJ+Edfozq8EewvT0DE2jLQMTABsduUp2Ry5Ws22ieKdu+ZWt BOTeQf2QH3tiRqXxGG9o+4HF/TAepGzdNJD1J5oRavfwnu9S2f1IvZi58DcAW01D96Iq+kYOQM DbvXX1ajbKt55SaGLmju1y9z9Gz5W+BdfGuZ1V03McPoZ6ndzHd0Vq+AlVbwHUGld7rGpYKhl4 4kQ= X-SBRS: 5.1 X-MesageID: 48403466 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:HMi4t6u6EZ+udWY7EZwcpktt7skDTNV00zEX/kB9WHVpmszxra GTdZMgpGbJYVcqKQodcL+7Scq9qB/nmqKdpLNhWYtKPzOW3ldATrsSj7cKqgeIc0aVm4JgPO VbAs9D4bXLfCBHZK3BgDVQfexP/DD+ytHMudvj X-IronPort-AV: E=Sophos;i="5.84,242,1620705600"; d="scan'208";a="48403466" From: Martin Harvey To: CC: Martin Harvey , Martin Harvey Subject: [PATCH 3/3] Disable CONS debug logging Date: Thu, 15 Jul 2021 14:15:02 +0100 Message-ID: <20210715131502.176-3-Martin.Harvey@citrix.com> X-Mailer: git-send-email 2.25.0.windows.1 In-Reply-To: <20210715131502.176-1-Martin.Harvey@citrix.com> References: <20210715131502.176-1-Martin.Harvey@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain In some cases, third party antivirus products may send many PnP query IRP's down the stack. This tends to fill the logfiles up with unnecessary repeated lines, making debugging of other failures difficult. Previous loglevel was (INFO|WARNING|ERROR|CRITICAL) Signed-Off-By: Martin Harvey --- src/xenbus/driver.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/xenbus/driver.c b/src/xenbus/driver.c index 067bb68..e07de55 100644 --- a/src/xenbus/driver.c +++ b/src/xenbus/driver.c @@ -58,10 +58,7 @@ typedef struct _XENBUS_DRIVER { static XENBUS_DRIVER Driver; #define XENBUS_DRIVER_TAG 'VIRD' -#define DEFAULT_CONSOLE_LOG_LEVEL (LOG_LEVEL_INFO | \ - LOG_LEVEL_WARNING | \ - LOG_LEVEL_ERROR | \ - LOG_LEVEL_CRITICAL) +#define DEFAULT_CONSOLE_LOG_LEVEL 0 static FORCEINLINE PVOID __DriverAllocate( -- 2.25.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Thu Jul 15 13:15:40 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 15 Jul 2021 13:15:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.156604.289025 (Exim 4.92) (envelope-from ) id 1m41DI-0000TP-El; Thu, 15 Jul 2021 13:15:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 156604.289025; Thu, 15 Jul 2021 13:15:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m41DI-0000TI-Bq; Thu, 15 Jul 2021 13:15:40 +0000 Received: by outflank-mailman (input) for mailman id 156604; Thu, 15 Jul 2021 13:15:39 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m41DG-0000OO-UJ for win-pv-devel@lists.xenproject.org; Thu, 15 Jul 2021 13:15:38 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id bb8621bc-e56e-11eb-88d0-12813bfff9fa; Thu, 15 Jul 2021 13:15:33 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: bb8621bc-e56e-11eb-88d0-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626354933; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=kZ/0a+XHcdhKXgosTV/6YAzQiIA/tptzBDShIPUMzYE=; b=Xn8K1bnXAGwJa1e5mb6KnfRWK776k8/dSg/uPoZAFTzRp/6p9BJS4jeY w33PHGvHX+1cpr2cznBlxHKPCr4Hes17s7uQVu81xFiWi6ZftNTkl9UPQ Fdqv7xsULK8LDZa5LaeCR44BpHl78u4OEP7aVD/9Wfw4QGrZHsSdru+tH w=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: N9AnQQb9yasQOOYMkg1m2qUsN3fv0FOUoJTy7QtWyjU6iIib7T2HmCY78g1DwvAfTkqOLo0F1v Sb5xdTRJXYcVAYwYeQq1TyOhlNqFPalDZ6qrCeqXyNuYX6XDOUyebyx33nU7gmdpOSAbnD0xdg Uiov4OecKud/ZTYW3tUKH9FYb179xeOO76L2ToVF/rluYK5yzby58zB5bDld4jdkIjoFbcnQVZ f/wnd06EPZx6SmcEkf9zDBrCkxuTcVo3F/Wg79+AvKvniepYMEzf82k15DwjBBOr/2dh6zwlVk BEU= X-SBRS: 5.1 X-MesageID: 48403464 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:95DWN6/E/9PMLmt7qu1uk+DWI+orL9Y04lQ7vn2YSXRuE/Bw8P re+8jztCWE8Qr5N0tQ+uxoVJPufZq+z+8Q3WByB8bBYOCOggLBR+sOgbcKqweQfREWndQ86U 4PScZD4aXLfD1Hsfo= X-IronPort-AV: E=Sophos;i="5.84,242,1620705600"; d="scan'208";a="48403464" From: Martin Harvey To: CC: Martin Harvey , Martin Harvey Subject: [PATCH 1/3] Additional logging for module loading. Date: Thu, 15 Jul 2021 14:15:00 +0100 Message-ID: <20210715131502.176-1-Martin.Harvey@citrix.com> X-Mailer: git-send-email 2.25.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Recent releases of Windows (10 and 11 in particular) allow online edition updates which involve a driver migration step, which occurs in SAFEBOOT mode. In some rare cases, this step may fail (for a variety of reasons). This additional logging added to debug such upgrade cases. Signed-Off-By: Martin Harvey --- src/xen/module.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/xen/module.c b/src/xen/module.c index da7f113..1813e3b 100644 --- a/src/xen/module.c +++ b/src/xen/module.c @@ -145,6 +145,11 @@ ModuleAdd( BOOLEAN After; NTSTATUS status; + Info("%p - %p [%s]\n", + Start, + Start + Size - 1, + Name); + New = __ModuleAllocate(sizeof (MODULE)); status = STATUS_NO_MEMORY; -- 2.25.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Mon Jul 19 07:13:23 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 19 Jul 2021 07:13:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.157942.291252 (Exim 4.92) (envelope-from ) id 1m5NSr-0000yG-Nu; Mon, 19 Jul 2021 07:13:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 157942.291252; Mon, 19 Jul 2021 07:13:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5NSr-0000y8-Kt; Mon, 19 Jul 2021 07:13:21 +0000 Received: by outflank-mailman (input) for mailman id 157942; Sun, 18 Jul 2021 04:51:18 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m4ylq-0000Ds-97 for win-pv-devel@lists.xenproject.org; Sun, 18 Jul 2021 04:51:18 +0000 Received: from mailexchange.msibureautique.ca (unknown [24.37.251.214]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c928aace-e783-11eb-8aa7-12813bfff9fa; Sun, 18 Jul 2021 04:51:16 +0000 (UTC) Received: from xen-Srv-2012-Ex.domaine.msibureautique.ca (2001:470:1d:5dd:8c37:3770:c748:871e) by xen-Srv-2012-Ex.domaine.msibureautique.ca (2001:470:1d:5dd:8c37:3770:c748:871e) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 18 Jul 2021 00:51:09 -0400 Received: from xen-Srv-2012-Ex.domaine.msibureautique.ca ([fe80::8c37:3770:c748:871e]) by xen-Srv-2012-Ex.domaine.msibureautique.ca ([fe80::8c37:3770:c748:871e%15]) with mapi id 15.00.1497.012; Sun, 18 Jul 2021 00:51:09 -0400 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: c928aace-e783-11eb-8aa7-12813bfff9fa Content-Language: fr-FR Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 DKIM-Signature: v=1; a=rsa-sha256; d=compu-sol.com; s=clef; c=relaxed/relaxed; t=1626583869; h=from:subject:to:date:message-id; bh=CmcxdFTpeJaPm17fV4pPxIxmusSXYWovqJftS2bqtxU=; b=rwYgKRi77+hp824KieB4K5LHdkxEFEctht27x15rmuoZRt0D6xGuKxLDQr8gF/Wrsnw2syiccgu D10Pb161EVwjhT0MTsqKM0vgNYG93osTzziM93XP09EmhkiNnzbJkvo1h6uFU549zwhoL6vrRTAsZ joxpQ5d73Uky4gGes3R1XdGBAD/YfCDy4R6q6bnhFyjb19DDPzl8SvJDPbDTEtB7jRpTKhGxt250D 6p8ubXg612yx3fTOWJLcZ01qzuqeNh66FdTP2FMlQOAt9yzUZf3ALnryhqEKyAKSB67hoeqsKRz3u Tfh4/7ZiElhHzvl/CdA5H6PyWVoXbhpM+70Q== From: Dominic Russell To: Paul Durrant , "win-pv-devel@lists.xenproject.org" Subject: RE: Windows PV 8.2.2 upgrading to 9.0.0 Thread-Topic: Windows PV 8.2.2 upgrading to 9.0.0 Thread-Index: Add7jjLmsQ5AoFJMTNu7nuPymLJuUQ== Date: Sun, 18 Jul 2021 04:51:08 +0000 Message-ID: <7ef694b2657c4ed3857b0031053e13f9@xen-Srv-2012-Ex.domaine.msibureautique.ca> Accept-Language: fr-CA, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [2001:470:1d:5dd:543f:ce32:455d:4078] MIME-Version: 1.0 SGVsbG8sDQoNCkkga25vdyBpdCdzIGJlZW4gYXdoaWxlIHdpdGggdGhvc2UgaXNzdWVzLCBzb21l IG9mIHRoZW0gSSB3YXMgdXNpbmcgYSB3b3JrIGFyb3VuZCBhbmQgbGV0IGl0IGJlLg0KDQpGb3Ig dGhlIFdpbmRvd3MgNyBuZXR3b3JrIGNhcmQgbm90IGNvbm5lY3Rpbmcgb24gYm9vdCwgYW5vdGhl ciBzdHJhbmdlIGlzc3VlIHdpdGggaXQgaXMgdGhhdCBpdCB3YXMgQlNPRCBhbG1vc3QgZXZlcnkg ZXZlbmluZyBhdCBhcm91bmQgMTA6MzAgcG0uICBJIG5vdGljZWQgdG9kYXkgdGhhdCBvbmUgb2Yg dGhlIHZpcnR1YWwgY29tcHV0ZXJzIG9uIHRoYXQgaG9zdCB3YXMgc3RpbGwgdXNpbmcgdGhlIEdQ TFBWIGRyaXZlcnMsIHNvIHRoaW5raW5nIHRoYXQgbWF5YmUgdGhleSBjb3VsZCBjb25mbGljdCwg SSBjbGVhbmVkIGl0IG1hbnVhbGx5ICh0aGUgdW5pbnN0YWxsIHdhcyBub3Qgd29ya2luZykgYW5k IGluc3RhbGxlZCBkcml2ZXJzIHZlcnNpb24gOS4wLjAgYW5kLCB0b25pZ2h0LCB0aGUgV2luZG93 cyA3IGRpZCBub3QgY3Jhc2ghICBJIHdpbGwgc2VlIGluIHRoZSBmb2xsb3dpbmcgZXZlbmluZ3Ms IHNvbWV0aW1lcyBpdCBob2xkcyBmb3IgYSBkYXkgb3IgdHdvIGJlZm9yZSBjcmFzaGluZyBhZ2Fp bi4gIEkgd291bGQgYmUgY3VyaW91cyB0byBmaW5kIG91dCB3aHkgYXQgdGhhdCBzcGVjaWZpYyBo b3VyLCBidXQgc3RpbGwgZGlkIG5vdCBmaW5kIGFueXRoaW5nIHNwZWNpYWwgcnVubmluZyBvbiB0 aGUgc2VydmVyIGF0IHRoYXQgdGltZS4NCg0KVG9kYXkgSSB3YW50ZWQgdG8gdXBkYXRlIGFsbCBX aW5kb3dzIDEwIGFuZCAyMDE2IFhlbiBQViBkcml2ZXJzIHRvIHRoZSBsYXRlc3QgOS4wLjAgYW5k IGVuY291bnRlcmVkIHR3byBpc3N1ZXMgOg0KCTEuIFRoZSBWTkMga2V5Ym9hcmQgbm90IGJlaW5n IHJlc3BvbnNpdmUgaXMgc3RpbGwgaGFwcGVuaW5nISAgVGhlIFhlbiB2ZXJzaW9uIGlzIDQuOC41 LCB3aGljaCBpcyBkYXRlZCAyMDE5LzEyIGFuZCB0aGUgZHJpdmVycyBhcmUgMjAxOS82LCBzbyBp dCBzaG91bGQgd29yayB0b2dldGhlciBJIHRoaW5rLg0KDQoJMi4gVGhlIG90aGVyIGlzc3VlIGlz IG1vcmUgY3JpdGljYWwsIGV2ZW4gaWYgZHBpbnN0IG1lbnRpb25zIHRoYXQgaXQgdXBkYXRlZCB0 aGUgZHJpdmVyLCBmb3IgbWFueSBvZiB0aGVtLCBpdCBkaWQgbm90LCBJIGRpZCBub3Qgbm90aWNl IGF0IGZpcnN0LCByZXN0YXJ0ZWQgdGhlIGNvbXB1dGVyIGFuZC4uLiBqdXN0IGEgdHVybmluZyB3 aGVlbCBhdCBzdGFydHVwIGFuZCBpdCBzdGF5cyB0aGVyZSBmb3JldmVyLiAgSXMgdGhlcmUgYW4g ZWFzeSBmaXggZm9yIHRoYXQgb3IgdGhlIG9ubHkgd2F5IGlzIHRvIGNsZWFyIHJlZ2lzdHJ5IHdp dGggdGhlIGhlbHAgb2YgSGlyZW4ncyBib290IENEPw0KV2hhdCBpcyB0aGUgY29ycmVjdCBwcm9j ZWR1cmUgdG8gdXBkYXRlIFdpbmRvd3MgWGVuIFBWIGRyaXZlcnM/DQoNCkJlc3QgcmVnYXJkcywN CkRvbWluaWMgUnVzc2VsbA0KTVNJIEJ1cmVhdXRpcXVlIEluYy4NCg0KDQotLS0tLU1lc3NhZ2Ug ZCdvcmlnaW5lLS0tLS0NCkRlwqA6IFBhdWwgRHVycmFudCA8UGF1bC5EdXJyYW50QGNpdHJpeC5j b20+IA0KRW52b3nDqcKgOiAyNCBzZXB0ZW1icmUgMjAxOCAwNDo1MQ0Kw4DCoDogRG9taW5pYyBS dXNzZWxsIDxkb21pbmljQGNvbXB1LXNvbC5jb20+OyB3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJv amVjdC5vcmcNCk9iamV0wqA6IFJFOiBXaW5kb3dzIFBWIDguMi4yIGFuZCBkZXZlbG9wbWVudCBi dWlsZA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IHdpbi1wdi1kZXZl bCBbbWFpbHRvOndpbi1wdi1kZXZlbC1ib3VuY2VzQGxpc3RzLnhlbnByb2plY3Qub3JnXSANCj4g T24gQmVoYWxmIE9mIERvbWluaWMgUnVzc2VsbA0KPiBTZW50OiAyMSBTZXB0ZW1iZXIgMjAxOCAy MDozOQ0KPiBUbzogd2luLXB2LWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IFN1YmplY3Q6 IFt3aW4tcHYtZGV2ZWxdIFdpbmRvd3MgUFYgOC4yLjIgYW5kIGRldmVsb3BtZW50IGJ1aWxkDQo+ IA0KPiBIZWxsbywNCj4gDQo+IEkndmUgdHJpZWQgdGhlIFdpbmRvd3MgUFYgOC4yLjIgb24gZmV3 IHZpcnR1YWwgY29tcHV0ZXJzIGFuZCB0aGUgDQo+IGxhdGVzdCBkZXZlbG9wbWVudCBidWlsZCBv biBhIHZpcnR1YWwgV2luZG93cyAxMCAxODAzLg0KPiANCj4gRm9yIDguMi4yLCBvbiBvbmUgV2lu ZG93cyA3LCB0aGUgbmV0d29yayBjYXJkIGRvZXMgbm90IHN0YXJ0IG9uIGEgDQo+IHJlYm9vdCwg YnV0IGlmIEkgc2ltcGx5IGRlYWN0aXZhdGUgYW5kIHJlYWN0aXZlIGl0IChieSBjb25uZWN0aW5n IA0KPiB0aHJvdWdoIFZOQyksIGl0IGluaXRpYXRlcyBwcm9wZXJseSBhbmQgc3RhcnRzIHdvcmtp bmcgYWdhaW4uICBBbnkgd2F5IHRvIGZpeCB0aGlzPw0KDQpIaSBEb21pbmljLA0KDQogIENvdWxk IHlvdSBwcm92aWRlIHRoZSBRRU1VIGxvZyBmb3IgeW91ciBWTT8gVGhlIFBWIGRyaXZlcnMgZW1p dCBsb2cgbWVzc2FnZXMgdmlhIGFuIEkvTyBwb3J0IHRoYXQgaXMgZW11bGF0ZWQgYnkgUUVNVS4g VGhlc2UgbWVzc2FnZXMgd2lsbCBwcm9iYWJseSBzaGVkIGxpZ2h0IG9uIHRoZSBmYWlsdXJlIHlv dSdyZSBzZWVpbmcuDQogIFdpdGhvdXQgYW55IHN1Y2ggaW5mby4gbXkgZ3Vlc3Mgd291bGQgYmUg dGhhdCB5b3VyIFZNIGlzIGJlaW5nIHN0YXJ2ZWQgb2YgZ3JhbnQgcmVmZXJlbmNlcyBieSB0aGUg c3RvcmFnZSBzdGFjayAod2hpY2ggc3RhcnRzIGVhcmxpZXIgdGhhbiB0aGUgbmV0d29yayBzdGFj aykuIEFmdGVyIGJvb3QsIHdoZW4gdGhlIHN0b3JhZ2Ugc3RhY2sgYmVjb21lcyBsZXNzIGNoYXR0 eSwgaXQgZnJlZXMgc29tZSByZWZlcmVuY2VzIHVwIGFuZCBoZW5jZSB0aGUgbmV0d29yayBkcml2 ZXIgaGFzIGVub3VnaCB0byBzdGFydCB1cC4gWW91IG1heSBzdGlsbCBzZWUgcHJvYmxlbXMgYWZ0 ZXIgdGhpcyB0aG91Z2guIFRyeSBpbmNyZWFzaW5nIHRoZSBudW1iZXIgb2YgZ3JhbnQgZnJhbWVz IGZyb20gdGhlIGRlZmF1bHQgMzIuLi4gSSB0eXBpY2FsbHkgcnVuIHdpdGggMTI4Lg0KDQo+IA0K PiBPbiB0aGUgbGF0ZXN0IGRldmVsb3BtZW50IGJ1aWxkLCB0aGVyZSBpcyBvbmUgcGVyaXBoZXJh bCB3aXRoIG5vIA0KPiBkcml2ZXJzLCBJJ3ZlIGluc3RhbGxlZCBhbGwgZHJpdmVycyBmb3VuZCBv biB0aGUgRlRQIHNpdGUuDQoNCldoaWNoIFVSTD8gSXQgYXBwZWFycyB0aGF0IGh0dHBzOi8veGVu cHJvamVjdC5vcmcvZG93bmxvYWRzL3dpbmRvd3MtcHYtZHJpdmVycy9kZXZlbG9wbWVudC1idWls ZHMuaHRtbCBpcyBpbmRlZWQgb3V0LW9mLWRhdGUgYXMgaXQgb25seSBsaXN0cyB0aGUgb3JpZ2lu YWwgNSBkcml2ZXJzLiBJZiB5b3UgZ28gZGlyZWN0bHkgdG8gaHR0cDovL3hlbmJpdHMueGVuLm9y Zy9wdmRyaXZlcnMvd2luIHRob3VnaCwgeW91IHNob3VsZCBzZWUgYWxsIDguDQoNCj4gQWxzbyB0 aGUga2V5Ym9hcmQgaXMgbm90IHJlc3BvbnNpdmUgaW4gVk5DIHdpdGggdGhvc2UgZHJpdmVycy4N Cg0KWW91IG1heSBuZWVkIGEgbmV3ZXIgdmVyc2lvbiBvZiBRRU1VLiBTdXBwb3J0IGZvciBQViBI SUQgaW4gV2luZG93cyBpcyByZWxpYW50IG9uIHNvbWUgZmFpcmx5IHJlY2VudCBmaXhlcy4gV2hp Y2ggdmVyc2lvbiBvZiBRRU1VIGFyZSB5b3UgdXNpbmc/DQoNCj4gSSBpbnN0YWxsZWQgOC4yLjIg b24gdGhhdA0KPiB2aXJ0dWFsIFdpbmRvd3MgMTAsIGl0IHdvcmtzIHdlbGwgZXhjZXB0IHdoZW4g SSBzdGFydCBCaXRUb3JyZW50LCBpdCANCj4gbWFrZXMgV2luZG93cyBjcmFzaCBhZnRlciBmZXcg bWludXRlcy4gIElmIEkgcmVtb3ZlIHRoZSBuZXR3b3JrIGNhcmQgDQo+IGRyaXZlciwgYW5kIGNv bmZpZ3VyZSB0aGUgdmlydHVhbCBjb21wdXRlciB0byB1c2UgaW9lbXUsIEJpdFRvcnJlbnQgd29y a3MgZmxhd2xlc3NseS4NCj4gQW55IHdheSB0byBmaXggdGhpcyBhbHNvPw0KPiANCg0KQ291bGQg eW91IGdpdmUgbWUgZGV0YWlsIG9mIHRoZSBleGFjdCB0ZXN0IHlvdSByYW4gYW5kIHdoYXQgdGhl IEJTT0QgY29kZSB3YXM/IEFnYWluLCBpdCBjb3VsZCBiZSBhIHByb2JsZW0gb2YgZ3JhbnQgcmVm ZXJlbmNlIHN0YXJ2YXRpb24gc28gcGxlYXNlIGluY3JlYXNlIHRoZSBudW1iZXIgb2YgZ3JhbnQg ZnJhbWVzIGFuZCB0ZXN0IGFnYWluIGZpcnN0Lg0KDQogIENoZWVycywNCg0KICAgIFBhdWwNCg== From win-pv-devel-bounces@lists.xenproject.org Mon Jul 19 07:22:37 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 19 Jul 2021 07:22:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.158101.291256 (Exim 4.92) (envelope-from ) id 1m5Nbo-00021C-E5; Mon, 19 Jul 2021 07:22:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 158101.291256; Mon, 19 Jul 2021 07:22:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5Nbo-000215-Am; Mon, 19 Jul 2021 07:22:36 +0000 Received: by outflank-mailman (input) for mailman id 158101; Mon, 19 Jul 2021 07:22:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5Nbn-00020x-9d for win-pv-devel@lists.xenproject.org; Mon, 19 Jul 2021 07:22:35 +0000 Received: from mail-wm1-x32f.google.com (unknown [2a00:1450:4864:20::32f]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3f3d1046-9970-4307-9ab8-12a36760d77d; Mon, 19 Jul 2021 07:22:34 +0000 (UTC) Received: by mail-wm1-x32f.google.com with SMTP id u8-20020a7bcb080000b02901e44e9caa2aso9818079wmj.4 for ; Mon, 19 Jul 2021 00:22:34 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:d6b:d269:ddc4:bf91? ([2a00:23c5:5785:9a01:d6b:d269:ddc4:bf91]) by smtp.gmail.com with ESMTPSA id d29sm23426472wrb.63.2021.07.19.00.22.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jul 2021 00:22:33 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 3f3d1046-9970-4307-9ab8-12a36760d77d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YBpmgSyCQY2+Vf1hOCqm0qsKcUztircvwQhf4m/c8w0=; b=k4uWh+WNUdGCk2FIzkJADo7Uy1PIOQ9LBXVKLFi+kLJ0EFlh8B8i8s9m+QR3UCF5tX HwewHF8bqLFrDdLqBD8q1MNftUFAj6bu2k+zAxyfsGeNIVkJnk0IASCoT8BZLcGSgWCJ vh4itmSx49+ZBT+zobc0MFNX7nR1/oYVcgIWNP99RVJ2HyqLfHXbyPebnj7ytle50CDB 0hSz7ZKFpp32q/c4SpA0WordBTLgOUjvkxbNWjvyEssP2a7uSmDylD0//ZVoTzb1c/oh QUQi8eyzPG9xkuPdBW/4y0Wnkt+P0mJLmnfQpqZL8COLMSG+DGxcSPAHjwZSXrhuVHlt CVcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YBpmgSyCQY2+Vf1hOCqm0qsKcUztircvwQhf4m/c8w0=; b=nFDzLsICM2/pcUcPyANBp/cZEq9iSJjSQD0oQwsTDnhAdPpsECPszMR8hzc3gBav6r VMjd2smaleeAf5PMdvayEjbiWV3PqLu2JsWPnqkREavyUdcf9rR9a2HrhhisEWIzVuM1 D7lIFF5X3wfxFXTJ1CswC1Yy4amQ0aYjFteRmuqDPB21kgCXTe/FhSS6tV3b+1cxhN00 aWiDEwmnJvE9oofrWlqbIrqO+nwYTlSBnuFCVE8gadRN8lj86+a3aiLjqtW5GKtxiVoA 7N9Gupwvo5ykds36hg8l5xrhnHTld3BdNcXutd0JpkVPWBapgiL2gFIIvYNV3oF6olcS owww== X-Gm-Message-State: AOAM5330wo/tgYLnb+EYJfexEC75EorAv69KbppD4/ZkaHmRMLR4Q7s0 XI5OrpY0MnbKR82DxB3i1Td3EOaejZ8= X-Google-Smtp-Source: ABdhPJyhT9C8L3o6i7lZTXf+ECNG72PkVq22JbWODDLdSLjJ8porokygBHl8rXpkHyglYHHoTEjAmA== X-Received: by 2002:a05:600c:4c96:: with SMTP id g22mr29809106wmp.70.1626679353640; Mon, 19 Jul 2021 00:22:33 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 1/3] Additional logging for module loading. To: win-pv-devel@lists.xenproject.org References: <20210715131502.176-1-Martin.Harvey@citrix.com> Message-ID: <06db6e8a-45d9-a47c-5495-4deb546702b4@xen.org> Date: Mon, 19 Jul 2021 08:22:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210715131502.176-1-Martin.Harvey@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 15/07/2021 14:15, Martin Harvey wrote: > Recent releases of Windows (10 and 11 in particular) allow > online edition updates which involve a driver migration step, > which occurs in SAFEBOOT mode. > > In some rare cases, this step may fail (for a variety of reasons). > This additional logging added to debug such upgrade cases. Just to be clear here. Is the intention to have this logging enabled all the time or only in safe mode? The comment above suggests the latter but there is no such guard on the call to Info() below. Paul > > Signed-Off-By: Martin Harvey > --- > src/xen/module.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/src/xen/module.c b/src/xen/module.c > index da7f113..1813e3b 100644 > --- a/src/xen/module.c > +++ b/src/xen/module.c > @@ -145,6 +145,11 @@ ModuleAdd( > BOOLEAN After; > NTSTATUS status; > > + Info("%p - %p [%s]\n", > + Start, > + Start + Size - 1, > + Name); > + > New = __ModuleAllocate(sizeof (MODULE)); > > status = STATUS_NO_MEMORY; > From win-pv-devel-bounces@lists.xenproject.org Mon Jul 19 07:26:52 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 19 Jul 2021 07:26:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.158108.291259 (Exim 4.92) (envelope-from ) id 1m5Nfv-0002I1-Oh; Mon, 19 Jul 2021 07:26:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 158108.291259; Mon, 19 Jul 2021 07:26:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5Nfv-0002Hu-Lw; Mon, 19 Jul 2021 07:26:51 +0000 Received: by outflank-mailman (input) for mailman id 158108; Mon, 19 Jul 2021 07:26:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5Nfv-0002Ho-0S for win-pv-devel@lists.xenproject.org; Mon, 19 Jul 2021 07:26:51 +0000 Received: from mail-wm1-x335.google.com (unknown [2a00:1450:4864:20::335]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0b0fab9d-ab4c-4133-960e-b95e0e4b4128; Mon, 19 Jul 2021 07:26:50 +0000 (UTC) Received: by mail-wm1-x335.google.com with SMTP id f190so8127818wmf.4 for ; Mon, 19 Jul 2021 00:26:50 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:d6b:d269:ddc4:bf91? ([2a00:23c5:5785:9a01:d6b:d269:ddc4:bf91]) by smtp.gmail.com with ESMTPSA id e15sm18786548wrp.29.2021.07.19.00.26.49 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jul 2021 00:26:49 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 0b0fab9d-ab4c-4133-960e-b95e0e4b4128 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=J0kQKFAxxlDtQ2mHhRNRiocwmDhdgJdlDt1y9mhWr7E=; b=SwBrPAuHwpTx0RbnBMlyMdf8t0SSnSiw6Pi+FdQqxpI2LLNIhjJVxSTz5mf17Itm1q /1aB8N5qf+DP2391xljO7dyRHOe/0MXWrCE/kliONsEz8YhmfVhHZ0is3VDKGoZI7uhF QhR9kLeGPYZa8dQztSNVSd0eeZMqLTx8sl+iaOAh0C+A7Z/dgJ2EIMgyw9EKkgqQAKE+ 6XBhZZcUJ29vgt3FIdkFRFtIBUdniERY8q8LikCiH3rhrSOs67dyGLNYvBg6B5K6loWy UmUfah8FhyaoyUk30KE+buSxnwQeIB+ZGzXr5tbgY2LQUAOwDTjyJUlC8tpTed69M3Ob 02fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=J0kQKFAxxlDtQ2mHhRNRiocwmDhdgJdlDt1y9mhWr7E=; b=KAiOJ9FA2iZb4EemDmrwaSMgun1f4ks4hFt3hJAqvsOccfGS45tj9kpMklKnk2lM4u dJoEP4FlZclWWz+rBwXmlGRaJTOpj0ogI6vwS/5CkZ4Pd31AMZ4GA9zts5zgQfGpytbf 0MXozUTPSiEJuTTnHyTWoTEpJoQwqLalv70l7C9c/llsadXogfyA/2b5UxvEA8uKAnuY BNH4ES/lws/935z3Lc+6s7ExnDRVCyrFkpJq7MKWM/uf/ItCT9eiS5XnOe7p99sXsJIf 1Zg+Jco6DmLpXiGgYVqMezzWvqcRqO8xdsAu6zJLIRgfriQoS7mmvwy08TUH3tsMXwnH uXMQ== X-Gm-Message-State: AOAM530Bu7VKWWMWoLztn2Ci7yvRhu1t9xxv8SIkDNZjuydr/yp76a8O 1LdjulDB7U6gGGYaokjznXBWigJipb8= X-Google-Smtp-Source: ABdhPJxFoOu6XbLZtw8Y3nhKEYi9y7c23bcHngToSWnyMUhMM988eAfTRynAFr1Utb3mfNGL5eJc1w== X-Received: by 2002:a1c:a992:: with SMTP id s140mr18304026wme.113.1626679609571; Mon, 19 Jul 2021 00:26:49 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 3/3] Disable CONS debug logging To: win-pv-devel@lists.xenproject.org References: <20210715131502.176-1-Martin.Harvey@citrix.com> <20210715131502.176-3-Martin.Harvey@citrix.com> Message-ID: <236e660e-d179-4d1b-c394-2e076bc39b21@xen.org> Date: Mon, 19 Jul 2021 08:26:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210715131502.176-3-Martin.Harvey@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 15/07/2021 14:15, Martin Harvey wrote: > In some cases, third party antivirus products may send many > PnP query IRP's down the stack. This tends to fill the logfiles up > with unnecessary repeated lines, making debugging of other > failures difficult. > > Previous loglevel was (INFO|WARNING|ERROR|CRITICAL) > > Signed-Off-By: Martin Harvey Acked-by: Paul Durrant > --- > src/xenbus/driver.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/src/xenbus/driver.c b/src/xenbus/driver.c > index 067bb68..e07de55 100644 > --- a/src/xenbus/driver.c > +++ b/src/xenbus/driver.c > @@ -58,10 +58,7 @@ typedef struct _XENBUS_DRIVER { > static XENBUS_DRIVER Driver; > > #define XENBUS_DRIVER_TAG 'VIRD' > -#define DEFAULT_CONSOLE_LOG_LEVEL (LOG_LEVEL_INFO | \ > - LOG_LEVEL_WARNING | \ > - LOG_LEVEL_ERROR | \ > - LOG_LEVEL_CRITICAL) > +#define DEFAULT_CONSOLE_LOG_LEVEL 0 > > static FORCEINLINE PVOID > __DriverAllocate( > From win-pv-devel-bounces@lists.xenproject.org Mon Jul 19 07:28:17 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 19 Jul 2021 07:28:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.158115.291263 (Exim 4.92) (envelope-from ) id 1m5NhI-0002Oq-TJ; Mon, 19 Jul 2021 07:28:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 158115.291263; Mon, 19 Jul 2021 07:28:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5NhI-0002Oj-QU; Mon, 19 Jul 2021 07:28:16 +0000 Received: by outflank-mailman (input) for mailman id 158115; Mon, 19 Jul 2021 07:28:15 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5NhH-0002Od-Rb for win-pv-devel@lists.xenproject.org; Mon, 19 Jul 2021 07:28:15 +0000 Received: from mail-wm1-x32f.google.com (unknown [2a00:1450:4864:20::32f]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8d156920-cb34-4b88-a912-c9fb89b90c83; Mon, 19 Jul 2021 07:28:15 +0000 (UTC) Received: by mail-wm1-x32f.google.com with SMTP id a23-20020a05600c2257b0290236ec98bebaso7388402wmm.1 for ; Mon, 19 Jul 2021 00:28:14 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:d6b:d269:ddc4:bf91? ([2a00:23c5:5785:9a01:d6b:d269:ddc4:bf91]) by smtp.gmail.com with ESMTPSA id w3sm19116433wrt.55.2021.07.19.00.28.13 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jul 2021 00:28:13 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 8d156920-cb34-4b88-a912-c9fb89b90c83 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8ACcwk/uPDvbS1XYUICHQ22mXq9bT6sQ/PF4LgzH7tY=; b=LX1RqZswn6FWGQGsa+KpK7N/SYgxoMsrb0KiUOYxhnI3ATIka5nntHdW0OalLLctE7 I/Ut3VDDZbPVDts/mIO5imdrRNBCn1ETX2iG+MWh/JbF/a+vTYRjlg4hp812dwkdd51/ SbFXHZa4B6iuCuOm+q8N4iEcDF1R98KEyOnbDJJXSn6+vDIjMWMB+Wbh60uA0zCk29/Y RLFoCb7vt6tr8P8KM9OVNmoSdCxh6c/AaVT59wIuAb89oZxLzl9DOBZDDOJF8yjeiTD9 dtnYnsu+BPxdebvoX3ghADM2Pd5nxSYICX6Aw+UUdX8K2FQeRPR4ywt60oqjrfZJohUC c0kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8ACcwk/uPDvbS1XYUICHQ22mXq9bT6sQ/PF4LgzH7tY=; b=HKvpkQqY78oIYI3A3QBPVaEc32gMYMNwudZgTKxG4+z31/x+E5xeVjGCJOTTBfnh4l 7UbIWbn96/N8RZ2hZYNI5F0U40AwFMAoPmtjqgmJdliVW/pcPQywFxXJzv+Mz1q6WZlN VCFKc2mUoBD0jY0XdGhDClTU+TK/WXiZLG/tFfATJnk0ipXvzJl3s5xTnu/TJIK+JkNg MfKVANYMlxf6DKQlLYywJ9weGZPdGQ9dFhsKzX0zUfdsfro3pCgekPY+W7MI6sJWsfcW mkGNPQ2L4Fy73vtoHPWaFoIdGk6nP5YGdnt3pO1VYm1IYqSuYJllS7TqUHY2J+4qbOuF KOtQ== X-Gm-Message-State: AOAM533j/PjrQR0uX85Ae0qGF0k50BXw4la/eq562J80oZUy2+yw+tCV nzT77R1YT6fMLAULvfQjM5bpVJqgiGM= X-Google-Smtp-Source: ABdhPJwlYVYu8EftKptPsjmqMrIKj+beXjs79ZbNcRUtEuBfmi5kUwLhPahxcb1hjpg1vXKYLgxbWA== X-Received: by 2002:a1c:790e:: with SMTP id l14mr29659963wme.119.1626679694168; Mon, 19 Jul 2021 00:28:14 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH] Fail if multi-queue-max-queues is 0 To: win-pv-devel@lists.xenproject.org References: <20210714104755.1063-1-owen.smith@citrix.com> Message-ID: Date: Mon, 19 Jul 2021 08:28:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210714104755.1063-1-owen.smith@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 14/07/2021 11:47, Owen Smith wrote: > Validate backend has correctly set multi-queue-max-queues, and add ASSERTions > to NumQueues and MaxQueues accessors to validate they are not 0 > > Signed-off-by: Owen Smith Acked-by: Paul Durrant > --- > src/xenvif/frontend.c | 40 ++++++++++++++++++++++++++++------------ > 1 file changed, 28 insertions(+), 12 deletions(-) > > diff --git a/src/xenvif/frontend.c b/src/xenvif/frontend.c > index 30de494..5940e16 100644 > --- a/src/xenvif/frontend.c > +++ b/src/xenvif/frontend.c > @@ -261,6 +261,7 @@ __FrontendGetMaxQueues( > IN PXENVIF_FRONTEND Frontend > ) > { > + ASSERT(Frontend->MaxQueues != 0); > return Frontend->MaxQueues; > } > > @@ -1764,7 +1765,7 @@ FrontendDebugCallback( > } > } > > -static VOID > +static NTSTATUS > FrontendSetNumQueues( > IN PXENVIF_FRONTEND Frontend > ) > @@ -1789,10 +1790,19 @@ FrontendSetNumQueues( > BackendMaxQueues = 1; > } > > + status = STATUS_INVALID_PARAMETER; > + if (BackendMaxQueues == 0) > + goto fail1; > + > Frontend->NumQueues = __min(__FrontendGetMaxQueues(Frontend), > BackendMaxQueues); > > Info("%s: %u\n", __FrontendGetPath(Frontend), Frontend->NumQueues); > + return STATUS_SUCCESS; > + > +fail1: > + Error("fail1 %08x\n", status); > + return status; > } > > static FORCEINLINE ULONG > @@ -1800,6 +1810,7 @@ __FrontendGetNumQueues( > IN PXENVIF_FRONTEND Frontend > ) > { > + ASSERT(Frontend->NumQueues != 0); > return Frontend->NumQueues; > } > > @@ -1953,7 +1964,6 @@ FrontendSetHashAlgorithm( > case XENVIF_PACKET_HASH_ALGORITHM_TOEPLITZ: > // Don't allow toeplitz hashing to be configured for a single > // queue, or if it has been explicitly disabled > - ASSERT(__FrontendGetNumQueues(Frontend) != 0); > status = (__FrontendGetNumQueues(Frontend) == 1 || > Frontend->DisableToeplitz != 0) ? > STATUS_NOT_SUPPORTED : > @@ -2218,20 +2228,23 @@ FrontendConnect( > if (!NT_SUCCESS(status)) > goto fail3; > > - FrontendSetNumQueues(Frontend); > + status = FrontendSetNumQueues(Frontend); > + if (!NT_SUCCESS(status)) > + goto fail4; > + > FrontendSetSplit(Frontend); > > status = ReceiverConnect(__FrontendGetReceiver(Frontend)); > if (!NT_SUCCESS(status)) > - goto fail4; > + goto fail5; > > status = TransmitterConnect(__FrontendGetTransmitter(Frontend)); > if (!NT_SUCCESS(status)) > - goto fail5; > + goto fail6; > > status = ControllerConnect(__FrontendGetController(Frontend)); > if (!NT_SUCCESS(status)) > - goto fail6; > + goto fail7; > > Attempt = 0; > do { > @@ -2286,7 +2299,7 @@ abort: > } while (status == STATUS_RETRY); > > if (!NT_SUCCESS(status)) > - goto fail7; > + goto fail8; > > State = XenbusStateUnknown; > while (State != XenbusStateConnected) { > @@ -2325,7 +2338,7 @@ abort: > > status = STATUS_UNSUCCESSFUL; > if (State != XenbusStateConnected) > - goto fail8; > + goto fail9; > > ControllerEnable(__FrontendGetController(Frontend)); > > @@ -2334,24 +2347,27 @@ abort: > Trace("<====\n"); > return STATUS_SUCCESS; > > +fail9: > + Error("fail9\n"); > + > fail8: > Error("fail8\n"); > > + ControllerDisconnect(__FrontendGetController(Frontend)); > + > fail7: > Error("fail7\n"); > > - ControllerDisconnect(__FrontendGetController(Frontend)); > + TransmitterDisconnect(__FrontendGetTransmitter(Frontend)); > > fail6: > Error("fail6\n"); > > - TransmitterDisconnect(__FrontendGetTransmitter(Frontend)); > + ReceiverDisconnect(__FrontendGetReceiver(Frontend)); > > fail5: > Error("fail5\n"); > > - ReceiverDisconnect(__FrontendGetReceiver(Frontend)); > - > fail4: > Error("fail4\n"); > > From win-pv-devel-bounces@lists.xenproject.org Mon Jul 19 10:05:45 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 19 Jul 2021 10:05:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.158270.291478 (Exim 4.92) (envelope-from ) id 1m5Q9g-00034U-6b; Mon, 19 Jul 2021 10:05:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 158270.291478; Mon, 19 Jul 2021 10:05:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5Q9f-00034C-W3; Mon, 19 Jul 2021 10:05:43 +0000 Received: by outflank-mailman (input) for mailman id 158270; Mon, 19 Jul 2021 10:05:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5Q9e-00033v-Iq for win-pv-devel@lists.xenproject.org; Mon, 19 Jul 2021 10:05:42 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2274cd33-f3d3-44c4-bc7a-adb42b7685f1; Mon, 19 Jul 2021 10:05:41 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 2274cd33-f3d3-44c4-bc7a-adb42b7685f1 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626689141; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=92Th2ce9I0T77OWH9Qm64dly3JI0batWS4YP9i6fHKk=; b=E1A/UzMzUbP0ijy1Z3wP209QkXH6/A5mW3KZ2ip2uGu8qDcQMsV7y9x1 8DE+2IUHpZS+dW2w1Ecu2HhjslQsqQxHOoofGbYDQrscTRLLFooKX15BF 4hcfabEcLNOEtCnxIOM3woYoi7TWa44nCYmLGLxesTbetjAROWFhVTtda 0=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: jN0umM1CyN7jrD51/v0e8nbYmSrjRhADJExAHVsoyDGKg9DX5+ulffRX5qEPX8do/+O85w5eCg dxow2nrovQZP3YEYWjw8Ol+k4rEQpRgyRB1wSgVRhUOd+VY10F/g5totaxwWByLl/MA2qziZ5b 2NO50MKrNn0cLpXBeeE6B9eSRfNgFnR4SxSgR8/FsHguYvnZjyPyfCdvML6SY1p9u/4CCZQgwM Ej8PTD2qVVF3Mi+ju6Uk5yjZIlN9TyX9SSbgIc1xTVoMnvd4Uwr/a+8i8h2IzypmYWJBDG+TBv p6W31vHruA+I8lJBqgYOwSmF X-SBRS: 5.1 X-MesageID: 48603190 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:XI9twKqAForZBHexI0Tn1RAaV5oTeYIsimQD101hICG8cqSj+f xG+85rsyMc6QxhIE3I9urhBEDtex/hHNtOkOws1NSZLW7bUQmTXeJfBOLZqlWKcUDDH6xmpM NdmsBFeaTN5DNB7PoSjjPWLz9Z+qjkzJyV X-IronPort-AV: E=Sophos;i="5.84,251,1620705600"; d="scan'208";a="48603190" From: Owen Smith To: CC: Owen Smith Subject: [PATCH 2/3] Add Lazy slab initialization Date: Mon, 19 Jul 2021 11:03:33 +0100 Message-ID: <20210719100334.1831-2-owen.smith@citrix.com> X-Mailer: git-send-email 2.31.1.windows.1 In-Reply-To: <20210719100334.1831-1-owen.smith@citrix.com> References: <20210719100334.1831-1-owen.smith@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Only initialize 1/4 of a slab initially, unless a reservation is defined. Allocate and initialize each slab object once this initial allocation has been exceeded. This is to decrease the overall resource usage when each cache object's constructor allocates additional memory. Signed-off-by: Owen Smith --- src/xenbus/cache.c | 27 +++++++++++++++++++++++++-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/src/xenbus/cache.c b/src/xenbus/cache.c index 247f244..d695ee3 100644 --- a/src/xenbus/cache.c +++ b/src/xenbus/cache.c @@ -61,6 +61,7 @@ typedef struct _XENBUS_CACHE_SLAB { LIST_ENTRY ListEntry; USHORT MaximumOccupancy; USHORT CurrentOccupancy; + USHORT CurrentAllocated; ULONG *Mask; UCHAR Buffer[1]; } XENBUS_CACHE_SLAB, *PXENBUS_CACHE_SLAB; @@ -301,6 +302,7 @@ CacheCreateSlab( ULONG Size; LONG Index; LONG SlabCount; + LONG ObjectsToAllocate; NTSTATUS status; NumberOfBytes = P2ROUNDUP(FIELD_OFFSET(XENBUS_CACHE_SLAB, Buffer) + @@ -326,6 +328,7 @@ CacheCreateSlab( Slab->Magic = XENBUS_CACHE_SLAB_MAGIC; Slab->Cache = Cache; Slab->MaximumOccupancy = (USHORT)Count; + Slab->CurrentAllocated = 0; Size = P2ROUNDUP(Count, BITS_PER_ULONG); Size /= 8; @@ -334,12 +337,18 @@ CacheCreateSlab( if (Slab->Mask == NULL) goto fail3; - for (Index = 0; Index < (LONG)Slab->MaximumOccupancy; Index++) { + ObjectsToAllocate = (Cache->Reservation == 0) ? + (LONG)Count / 4 : + min((LONG)Cache->Reservation, (LONG)Count); + + for (Index = 0; Index < ObjectsToAllocate; Index++) { PVOID Object = (PVOID)&Slab->Buffer[Index * Cache->Size]; status = __CacheCtor(Cache, Object); if (!NT_SUCCESS(status)) goto fail4; + + Slab->CurrentAllocated++; } CacheInsertSlab(Cache, Slab); @@ -402,7 +411,7 @@ CacheDestroySlab( ASSERT(Cache->Cursor != &Cache->SlabList || IsListEmpty(&Cache->SlabList)); - Index = Slab->MaximumOccupancy; + Index = Slab->CurrentAllocated; while (--Index >= 0) { PVOID Object = (PVOID)&Slab->Buffer[Index * Cache->Size]; @@ -493,6 +502,20 @@ CacheGetObjectFromSlab( if (Slab->CurrentOccupancy == Slab->MaximumOccupancy) return NULL; + ASSERT3U(Slab->CurrentOccupancy, <=, Slab->CurrentAllocated); + ASSERT3U(Slab->CurrentAllocated, <=, Slab->MaximumOccupancy); + if (Slab->CurrentOccupancy == Slab->CurrentAllocated) { + NTSTATUS status; + + Object = (PVOID)&Slab->Buffer[Slab->CurrentAllocated * Cache->Size]; + + status = __CacheCtor(Cache, Object); + if (!NT_SUCCESS(status)) + return NULL; + + Slab->CurrentAllocated++; + } + Index = __CacheMaskScan(Slab->Mask, Slab->MaximumOccupancy); BUG_ON(Index >= Slab->MaximumOccupancy); -- 2.31.1.windows.1 From win-pv-devel-bounces@lists.xenproject.org Mon Jul 19 10:05:45 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 19 Jul 2021 10:05:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.158269.291471 (Exim 4.92) (envelope-from ) id 1m5Q9g-000348-1X; Mon, 19 Jul 2021 10:05:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 158269.291471; Mon, 19 Jul 2021 10:05:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5Q9f-000341-Ub; Mon, 19 Jul 2021 10:05:43 +0000 Received: by outflank-mailman (input) for mailman id 158269; Mon, 19 Jul 2021 10:05:42 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5Q9e-00033p-3u for win-pv-devel@lists.xenproject.org; Mon, 19 Jul 2021 10:05:42 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id df0099a6-e878-11eb-8afa-12813bfff9fa; Mon, 19 Jul 2021 10:05:40 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: df0099a6-e878-11eb-8afa-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626689140; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=PIeZy51ye8WpAb+cXBmlyfC+n/RkPzvbcamUwacdUDM=; b=M1fzTrk2D+R0eJq57XOtLx57ltahUkW8BlgwY2aAv73B0vMMUDknf9Pa 4+zujW/gauDgkAXRNYCqlQwKl/P7ZyfKAiVfJy4oi0A0Xu7TXF8QFTTMO pRPtOeCbYWLjDKQGalajK4NGWLa4T8NTZSY05vAc9I9RQd2/PkuhHC97Z g=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: Uw74dEL9knS/K3icl7gt37yrtrIN6wA9tEk0PzyBYnG2SlkFMphZ5Mpkp9xC97GLDdQB3gOiOk bZv4PFwHW9VPalp6CzSzpEuGAAX2ZeleXATx6rF0ulCBDoO9jRzEemDt2uH85RCNdPpYklOVaL 0CKf/GIxcNXNEQEK9Xqek5kfbnKwscAEunvDENR0ptBHxFL+kSrqMJ09MqCFFlQ3PVHSRkXvTh 8kXIcHX7Veo7TCPaJxyb1jrT13zonR8xpQKojAw6zK0+CuCncFSbgcyTT9MOUWXqTAXe+WKfM1 R7/iRO2LJZMoZ7Ii7uyVO4jP X-SBRS: 5.1 X-MesageID: 48603188 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Iju5Da36Hqy2mWkPgg/ygwqjBLgkLtp133Aq2lEZdPRUGvb2qy nIpoV/6faUskd3ZJhOo7G90cW7LE80lqQFg7X5X43DYOCOggLBR+tfBOPZslnd8kbFmNK1u5 0NT0EHMqySMWRH X-IronPort-AV: E=Sophos;i="5.84,251,1620705600"; d="scan'208";a="48603188" From: Owen Smith To: CC: Owen Smith Subject: [PATCH 1/3] Track additional Cache stats Date: Mon, 19 Jul 2021 11:03:32 +0100 Message-ID: <20210719100334.1831-1-owen.smith@citrix.com> X-Mailer: git-send-email 2.31.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Track Current/Maximum number of slabs, and Current/Maximum number of objects in use. Signed-off-by: Owen Smith --- src/xenbus/cache.c | 36 ++++++++++++++++++++++++++++++++++-- 1 file changed, 34 insertions(+), 2 deletions(-) diff --git a/src/xenbus/cache.c b/src/xenbus/cache.c index 48772d4..247f244 100644 --- a/src/xenbus/cache.c +++ b/src/xenbus/cache.c @@ -88,6 +88,10 @@ struct _XENBUS_CACHE { ULONG Count; PXENBUS_CACHE_MAGAZINE Magazine; ULONG MagazineCount; + LONG CurrentSlabs; + LONG MaximumSlabs; + LONG CurrentObjects; + LONG MaximumObjects; }; struct _XENBUS_CACHE_CONTEXT { @@ -296,6 +300,7 @@ CacheCreateSlab( ULONG Count; ULONG Size; LONG Index; + LONG SlabCount; NTSTATUS status; NumberOfBytes = P2ROUNDUP(FIELD_OFFSET(XENBUS_CACHE_SLAB, Buffer) + @@ -340,6 +345,10 @@ CacheCreateSlab( CacheInsertSlab(Cache, Slab); Cache->Count += Count; + SlabCount = InterlockedIncrement(&Cache->CurrentSlabs); + if (SlabCount > Cache->MaximumSlabs) + Cache->MaximumSlabs = SlabCount; + return STATUS_SUCCESS; fail4: @@ -400,6 +409,9 @@ CacheDestroySlab( __CacheDtor(Cache, Object); } + ASSERT(Cache->CurrentSlabs != 0); + InterlockedDecrement(&Cache->CurrentSlabs); + __CacheFree(Slab->Mask); __CacheFree(Slab); } @@ -527,6 +539,7 @@ CacheGet( ULONG Index; PXENBUS_CACHE_MAGAZINE Magazine; PVOID Object; + LONG ObjectCount; UNREFERENCED_PARAMETER(Interface); @@ -575,6 +588,12 @@ again: __CacheReleaseLock(Cache); done: + if (Object != NULL) { + ObjectCount = InterlockedIncrement(&Cache->CurrentObjects); + if (ObjectCount > Cache->MaximumObjects) + Cache->MaximumObjects = ObjectCount; + } + KeLowerIrql(Irql); return Object; @@ -625,6 +644,9 @@ CachePut( __CacheReleaseLock(Cache); done: + ASSERT(Cache->CurrentObjects != 0); + InterlockedDecrement(&Cache->CurrentObjects); + KeLowerIrql(Irql); } @@ -895,6 +917,12 @@ CacheDestroy( CacheSpill(Cache, 0); + ASSERT(Cache->CurrentObjects == 0); + Cache->MaximumObjects = 0; + + ASSERT(Cache->CurrentSlabs == 0); + Cache->MaximumSlabs = 0; + Cache->Cursor = NULL; ASSERT(IsListEmpty(&Cache->SlabList)); RtlZeroMemory(&Cache->SlabList, sizeof (LIST_ENTRY)); @@ -942,10 +970,14 @@ CacheDebugCallback( XENBUS_DEBUG(Printf, &Context->DebugInterface, - "- %s: Count = %d (Reservation = %d)\n", + "- %s: Count = %d, Reservation = %d, Objects = %d / %d, Slabs = %d / %d\n", Cache->Name, Cache->Count, - Cache->Reservation); + Cache->Reservation, + Cache->CurrentObjects, + Cache->MaximumObjects, + Cache->CurrentSlabs, + Cache->MaximumSlabs); } } } -- 2.31.1.windows.1 From win-pv-devel-bounces@lists.xenproject.org Mon Jul 19 10:05:48 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 19 Jul 2021 10:05:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.158271.291481 (Exim 4.92) (envelope-from ) id 1m5Q9k-00038c-5P; Mon, 19 Jul 2021 10:05:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 158271.291481; Mon, 19 Jul 2021 10:05:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5Q9k-00038T-1w; Mon, 19 Jul 2021 10:05:48 +0000 Received: by outflank-mailman (input) for mailman id 158271; Mon, 19 Jul 2021 10:05:47 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5Q9j-00033p-2M for win-pv-devel@lists.xenproject.org; Mon, 19 Jul 2021 10:05:47 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id dfde1e02-e878-11eb-8afa-12813bfff9fa; Mon, 19 Jul 2021 10:05:41 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: dfde1e02-e878-11eb-8afa-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626689141; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=/bkYMZgQtfOP66iwNTBjyrFM3dP9+9LRd0tfqIx0iHE=; b=WFw4oMhqejHrn340ys7suiht6M56y0wbJfdvm7IRn/Ic9YxYLAPBDaAI 8yGG5VdtVEWdun1vx/0EkH3JCEyyu1gCcH4e+Cg8jBJcwhzxyk/kbKIYa SylPnouFUy9/nWfnvkk699yiCwGeQUdigOUBbBu/cRy/h6E+2FUdH5RL2 0=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: dmqKzypxW/0kPTvkFJgyeTYPns+7S6QcM1x4y6VDrLgwd06z4t59rVnAFa1y+xju45UYFX4p8v hA92rJWOzMIFEsUSsXpPpM+q9jSZ0j5H93bAFajnhxTHRTXYuDD9oV1Fh5Jza0LJk7XNzHm46X 51R+1tC3JspJ7Kuq9JKWPu/0NH1LkunWxx8xSYWKFsbZVYUK6bphG1HPkby6isC7Ro/INg+oOn mLPXs9blSn1bNcpyHgYwg3h263txsEz8J0A5rcJoGLrbMcv3+Dv0B4ambfqYCjSdVC4J+BLkEu +KfpXEdlTmu7Q+upExDnIB+6 X-SBRS: 5.1 X-MesageID: 48239042 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:zOeir6N/+MYGWMBcTlejsMiBIKoaSvp037By7TEJdfUnSL3hqy nOpoVu6faaskd1ZJhNo7690ey7MBXhHP1OkP4s1NWZLW3bUQKTRekIh+aPrAEIWReOkdK1vp 0BT0EKMqyTMbEMt7eY3ODXKbcdKZK8gduVbK/lvg1QpNZRGtddBilCe3um+hcafng7OXIbea Dsmfau51ebCAUqhorXPAh0YwCMzee74a4P03M9dmAawRjLkDeh8rK/CBSDwhICOgk/sosK4C zZlwTi6uG9v+qgyhnavlWjnahrpA== X-IronPort-AV: E=Sophos;i="5.84,251,1620705600"; d="scan'208";a="48239042" From: Owen Smith To: CC: Owen Smith Subject: [PATCH 3/3] Remove MINIMUM_OBJECT_SIZE Date: Mon, 19 Jul 2021 11:03:34 +0100 Message-ID: <20210719100334.1831-3-owen.smith@citrix.com> X-Mailer: git-send-email 2.31.1.windows.1 In-Reply-To: <20210719100334.1831-1-owen.smith@citrix.com> References: <20210719100334.1831-1-owen.smith@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain MINIMUM_OBJECT_SIZE would make all cached objects at least 0x80 bytes, which would limit the number of objects in each slab to 31 objects. This limitation is not needed, as the slab's mask is dynamically allocated to cope with the correct number of objects that can fit into a single slab. Cache object's sizes are rounded up to the nearest pointer boundary to maintain object alignment. Removing the minimum size allows more objects per cache slab, reducing the memory overhead of caches. Signed-off-by: Owen Smith --- src/xenbus/cache.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/xenbus/cache.c b/src/xenbus/cache.c index d695ee3..a24c4e5 100644 --- a/src/xenbus/cache.c +++ b/src/xenbus/cache.c @@ -66,12 +66,8 @@ typedef struct _XENBUS_CACHE_SLAB { UCHAR Buffer[1]; } XENBUS_CACHE_SLAB, *PXENBUS_CACHE_SLAB; -#define BITS_PER_ULONG (sizeof (ULONG) * 8) -#define MINIMUM_OBJECT_SIZE (PAGE_SIZE / BITS_PER_ULONG) - -C_ASSERT(sizeof (XENBUS_CACHE_SLAB) <= MINIMUM_OBJECT_SIZE); - -#define MAXNAMELEN 128 +#define BITS_PER_ULONG (sizeof (ULONG) * 8) +#define MAXNAMELEN 128 struct _XENBUS_CACHE { LIST_ENTRY ListEntry; @@ -806,7 +802,6 @@ CacheCreate( if (!NT_SUCCESS(status)) goto fail2; - Size = __max(Size, MINIMUM_OBJECT_SIZE); Size = P2ROUNDUP(Size, sizeof (ULONG_PTR)); if (Cap == 0) -- 2.31.1.windows.1 From win-pv-devel-bounces@lists.xenproject.org Mon Jul 19 10:48:57 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 19 Jul 2021 10:48:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.158312.291528 (Exim 4.92) (envelope-from ) id 1m5QpV-0000n6-6t; Mon, 19 Jul 2021 10:48:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 158312.291528; Mon, 19 Jul 2021 10:48:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5QpV-0000mz-3j; Mon, 19 Jul 2021 10:48:57 +0000 Received: by outflank-mailman (input) for mailman id 158312; Mon, 19 Jul 2021 10:48:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5QpT-0000mt-LZ for win-pv-devel@lists.xenproject.org; Mon, 19 Jul 2021 10:48:55 +0000 Received: from mail-wr1-x42c.google.com (unknown [2a00:1450:4864:20::42c]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 79678189-d0c5-410e-ad9a-150c99b60a44; Mon, 19 Jul 2021 10:48:54 +0000 (UTC) Received: by mail-wr1-x42c.google.com with SMTP id f9so21426595wrq.11 for ; Mon, 19 Jul 2021 03:48:54 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:d6b:d269:ddc4:bf91? ([2a00:23c5:5785:9a01:d6b:d269:ddc4:bf91]) by smtp.gmail.com with ESMTPSA id p4sm20237835wrt.23.2021.07.19.03.48.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jul 2021 03:48:53 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 79678189-d0c5-410e-ad9a-150c99b60a44 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=uQMWJlKI0ZWPDMp5YMad66gGG0Ea09WoKkaatVnw3dE=; b=VVhh+8rZqYgHrZ/dsFCBvxBvb3Vb4k9FHv5crjRzoIRWfPAfC562FDNIIkopvKtVQH aNNQx6XjAbjYW5kUQ0+XmidkA8GXqVfCyQmO0jtcym4tfFMxOehnwvZnJ1pa9DGNQkb+ 1g90SlCDCh7deOfDh3nskh60Y1sya8Xfd8GUzkK75QLqcRZT/KI53WB2F83BYQDU9cGg eb2P0t3hUhUfQi/qAhSQpSNDTJ5idmf624PATq3XedFrRKGTzN6mI5wqALzxWnTDWA8q 7p/HiFm/9W6KE/9vVs/XcP741KiX/W2yCGRr98PjxlW7ivpNDH7l0Zg/mLLU+4k1hh2M lO6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uQMWJlKI0ZWPDMp5YMad66gGG0Ea09WoKkaatVnw3dE=; b=k7eGZ7tayO/fpH+RRuzZiO3gZxfdKlzk6ewlzPWTG7sKUwRhIJHq1hT+Yi3OHKSeSH 1mLvC1kJd9SCHeHVhWhotLdIbx6hrBdfkqHshY5KO0OnRN/WZpcrMd2ewV/X8snhqcEz vgJR4E3/5vPopOR0vALUgd3H6L2rTWRXf44DEgCJiPl6bXgl8NwynFw0VFausDIS1med dq/ovVFXZOEjtKWRQK9hlllO7gBjdnGrOqVvC+YoIfzEFI1XQYFX3XyUFxqrtEADv3B4 QF9cJ2FUnfDCvlvwNFnrr/dZiqE92TRGmnJSuyos7izX4cRpR73pDxpWCUI5g6YN2BlY ITjQ== X-Gm-Message-State: AOAM531M8EsVyp3mQ/MQKJV4ifOgu6KK1aN43hE36bpVSf4nAILtHR4O AbgW1i7qRcUOIHFM/+ByNpmZU9KzgEk= X-Google-Smtp-Source: ABdhPJyqdZiVcN5OxBxlXnZIzrXk2ZE65DV5yEQIq56xQZtScY8Wz8ODHY0O9E+UrXfGJ8UkeobSWw== X-Received: by 2002:adf:e586:: with SMTP id l6mr29634170wrm.26.1626691734156; Mon, 19 Jul 2021 03:48:54 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: Windows PV 8.2.2 upgrading to 9.0.0 To: win-pv-devel@lists.xenproject.org References: <7ef694b2657c4ed3857b0031053e13f9@xen-Srv-2012-Ex.domaine.msibureautique.ca> Message-ID: Date: Mon, 19 Jul 2021 11:48:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <7ef694b2657c4ed3857b0031053e13f9@xen-Srv-2012-Ex.domaine.msibureautique.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 18/07/2021 05:51, Dominic Russell wrote: [snip] > > Today I wanted to update all Windows 10 and 2016 Xen PV drivers to the latest 9.0.0 and encountered two issues : > 1. The VNC keyboard not being responsive is still happening! The Xen version is 4.8.5, which is dated 2019/12 and the drivers are 2019/6, so it should work together I think. > The version of Xen is not the crucial part here; it's the version of QEMU that you're using. Still, that's a very old version of Xen and well out of security support. > 2. The other issue is more critical, even if dpinst mentions that it updated the driver, for many of them, it did not, I did not notice at first, restarted the computer and... just a turning wheel at startup and it stays there forever. Is there an easy fix for that or the only way is to clear registry with the help of Hiren's boot CD? If you can get into the console quickly enough at boot time then you should be able to boot in 'safe mode' which should disable PV drivers and use emulated devices instead. > What is the correct procedure to update Windows Xen PV drivers? > That's a very tricky question because it largely depends on what is there currently. You *should* be able to simply install 9.0 drivers over the top of 8.x drivers but, if that is not working, then it is probably best to actively remove any previous drivers, then reboot and bring up the system using emulated devices before then installing newer drivers. Cheers, Paul From win-pv-devel-bounces@lists.xenproject.org Mon Jul 19 10:50:03 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 19 Jul 2021 10:50:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.158319.291532 (Exim 4.92) (envelope-from ) id 1m5QqZ-00017N-B3; Mon, 19 Jul 2021 10:50:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 158319.291532; Mon, 19 Jul 2021 10:50:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5QqZ-00017F-7n; Mon, 19 Jul 2021 10:50:03 +0000 Received: by outflank-mailman (input) for mailman id 158319; Mon, 19 Jul 2021 10:50:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5QqY-0000y4-Cg for win-pv-devel@lists.xenproject.org; Mon, 19 Jul 2021 10:50:02 +0000 Received: from mail-wm1-x330.google.com (unknown [2a00:1450:4864:20::330]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a34abe73-a247-4b2c-8c63-1356d0fde71b; Mon, 19 Jul 2021 10:50:01 +0000 (UTC) Received: by mail-wm1-x330.google.com with SMTP id m11-20020a05600c3b0bb0290228f19cb433so12555574wms.0 for ; Mon, 19 Jul 2021 03:50:01 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:d6b:d269:ddc4:bf91? ([2a00:23c5:5785:9a01:d6b:d269:ddc4:bf91]) by smtp.gmail.com with ESMTPSA id p9sm19108441wrx.59.2021.07.19.03.50.00 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jul 2021 03:50:00 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: a34abe73-a247-4b2c-8c63-1356d0fde71b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ezGcPtSZss3I7qZIpzr72I4ovXZ+Z/wrmoUlAM6lFyg=; b=CM7J29SDSHyOwvqmpAh81Z++LyTqxfMvmPYqAckeTDAQF9CyBq+LkRDBbG/64lglcm dUaG3/a3X8bC2NScl73d5U/Xir2VXvpQHORT0IYT6zVbhNmrA2HTbf5VTkQuxtF5z20p UDwWEHyCKjhFAagFug+RlNroUJ5XjpHBiUvRFm9ZHyF9vmSO8LKV8woOCxXdU8PGwIi4 wyPkIQMOM3dK1TaUZPjg4gNhmqXlKCTOIOjvYw8IPkqy9PUrZNu6FIIa8Ej3cOh/CSIV 5q3FPtHeV7vRRBJEVcQBcJGB+LKn7JapNvvF2qW2RI3/TQktwGsdjAPv9a5w1hD8Q718 jMeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ezGcPtSZss3I7qZIpzr72I4ovXZ+Z/wrmoUlAM6lFyg=; b=PM+zzPAbZ8l1ogGw2JgEMMNSW3dWClckHpmfy52lQmxV3orIBeFhzgkgb2M2jNhSlS +TKaKT7DhYDVVkFkXRREuVHdf/7jMrIPgbR6bv87JSw2GHCV3+CjZ9uUGPdxfz7fm5CB N27SerXp5NsiB0/AKXWwe3XJCwC+byYlPLv5GRXvHGaB2y8qRyeYf0y8tkq8vGyByvg8 nBbCQyl3dh5CTAPkZ4WdeeOOJPiIAbW9qIBi50vU1WDU4WM5pAyXs7De+ls++p5zAGtW BXZjx8OybznuiKHkPExdGT/20PhddTmfLNy20heGcvgU4x5vpQ26BiXkeU3PCDY2YTtJ cBiw== X-Gm-Message-State: AOAM532vVOW4a3I2Y4FWSbYTmEDEp5Cj+C+u4tVv8rt+XoxfMnZOalmV F0zx3aZ5c+sW8MrU5uhNOvFCCrB43R4= X-Google-Smtp-Source: ABdhPJyEeurjLrdS2JP0DrBAylVbezxtVJPpRsIQavvwxctmxeFcWkz8jZy7T4JxvEDRdQ49012C6w== X-Received: by 2002:a7b:c2a2:: with SMTP id c2mr25762991wmk.89.1626691800819; Mon, 19 Jul 2021 03:50:00 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 1/3] Track additional Cache stats To: win-pv-devel@lists.xenproject.org References: <20210719100334.1831-1-owen.smith@citrix.com> Message-ID: Date: Mon, 19 Jul 2021 11:49:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210719100334.1831-1-owen.smith@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 19/07/2021 11:03, Owen Smith wrote: > Track Current/Maximum number of slabs, and Current/Maximum number of objects in > use. > > Signed-off-by: Owen Smith Acked-by: Paul Durrant > --- > src/xenbus/cache.c | 36 ++++++++++++++++++++++++++++++++++-- > 1 file changed, 34 insertions(+), 2 deletions(-) > > diff --git a/src/xenbus/cache.c b/src/xenbus/cache.c > index 48772d4..247f244 100644 > --- a/src/xenbus/cache.c > +++ b/src/xenbus/cache.c > @@ -88,6 +88,10 @@ struct _XENBUS_CACHE { > ULONG Count; > PXENBUS_CACHE_MAGAZINE Magazine; > ULONG MagazineCount; > + LONG CurrentSlabs; > + LONG MaximumSlabs; > + LONG CurrentObjects; > + LONG MaximumObjects; > }; > > struct _XENBUS_CACHE_CONTEXT { > @@ -296,6 +300,7 @@ CacheCreateSlab( > ULONG Count; > ULONG Size; > LONG Index; > + LONG SlabCount; > NTSTATUS status; > > NumberOfBytes = P2ROUNDUP(FIELD_OFFSET(XENBUS_CACHE_SLAB, Buffer) + > @@ -340,6 +345,10 @@ CacheCreateSlab( > CacheInsertSlab(Cache, Slab); > Cache->Count += Count; > > + SlabCount = InterlockedIncrement(&Cache->CurrentSlabs); > + if (SlabCount > Cache->MaximumSlabs) > + Cache->MaximumSlabs = SlabCount; > + > return STATUS_SUCCESS; > > fail4: > @@ -400,6 +409,9 @@ CacheDestroySlab( > __CacheDtor(Cache, Object); > } > > + ASSERT(Cache->CurrentSlabs != 0); > + InterlockedDecrement(&Cache->CurrentSlabs); > + > __CacheFree(Slab->Mask); > __CacheFree(Slab); > } > @@ -527,6 +539,7 @@ CacheGet( > ULONG Index; > PXENBUS_CACHE_MAGAZINE Magazine; > PVOID Object; > + LONG ObjectCount; > > UNREFERENCED_PARAMETER(Interface); > > @@ -575,6 +588,12 @@ again: > __CacheReleaseLock(Cache); > > done: > + if (Object != NULL) { > + ObjectCount = InterlockedIncrement(&Cache->CurrentObjects); > + if (ObjectCount > Cache->MaximumObjects) > + Cache->MaximumObjects = ObjectCount; > + } > + > KeLowerIrql(Irql); > > return Object; > @@ -625,6 +644,9 @@ CachePut( > __CacheReleaseLock(Cache); > > done: > + ASSERT(Cache->CurrentObjects != 0); > + InterlockedDecrement(&Cache->CurrentObjects); > + > KeLowerIrql(Irql); > } > > @@ -895,6 +917,12 @@ CacheDestroy( > > CacheSpill(Cache, 0); > > + ASSERT(Cache->CurrentObjects == 0); > + Cache->MaximumObjects = 0; > + > + ASSERT(Cache->CurrentSlabs == 0); > + Cache->MaximumSlabs = 0; > + > Cache->Cursor = NULL; > ASSERT(IsListEmpty(&Cache->SlabList)); > RtlZeroMemory(&Cache->SlabList, sizeof (LIST_ENTRY)); > @@ -942,10 +970,14 @@ CacheDebugCallback( > > XENBUS_DEBUG(Printf, > &Context->DebugInterface, > - "- %s: Count = %d (Reservation = %d)\n", > + "- %s: Count = %d, Reservation = %d, Objects = %d / %d, Slabs = %d / %d\n", > Cache->Name, > Cache->Count, > - Cache->Reservation); > + Cache->Reservation, > + Cache->CurrentObjects, > + Cache->MaximumObjects, > + Cache->CurrentSlabs, > + Cache->MaximumSlabs); > } > } > } > From win-pv-devel-bounces@lists.xenproject.org Mon Jul 19 10:54:09 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 19 Jul 2021 10:54:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.158327.291536 (Exim 4.92) (envelope-from ) id 1m5QuW-0001iP-Lv; Mon, 19 Jul 2021 10:54:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 158327.291536; Mon, 19 Jul 2021 10:54:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5QuW-0001iH-Ig; Mon, 19 Jul 2021 10:54:08 +0000 Received: by outflank-mailman (input) for mailman id 158327; Mon, 19 Jul 2021 10:54:07 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5QuV-0001iB-JS for win-pv-devel@lists.xenproject.org; Mon, 19 Jul 2021 10:54:07 +0000 Received: from mail-wm1-x329.google.com (unknown [2a00:1450:4864:20::329]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fb9257c0-ea3b-4c17-b2a7-756baf2b65e2; Mon, 19 Jul 2021 10:54:06 +0000 (UTC) Received: by mail-wm1-x329.google.com with SMTP id p15-20020a05600c358fb0290245467f26a4so1974978wmq.0 for ; Mon, 19 Jul 2021 03:54:06 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:d6b:d269:ddc4:bf91? ([2a00:23c5:5785:9a01:d6b:d269:ddc4:bf91]) by smtp.gmail.com with ESMTPSA id y6sm16240725wma.48.2021.07.19.03.54.04 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jul 2021 03:54:05 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: fb9257c0-ea3b-4c17-b2a7-756baf2b65e2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wy9o+/0uuVnm0XJBCNmYxwAA4nDuyWiDjWa8e6TaLK8=; b=YyCGwhgIPV/M0PnwUO5QxiocnireY7ivLUJAWTNfNQM48zFdsCN/QkA0XLrZUsbIrO SY4saled+a4cbgME668D25IIMv9OGGZPWorjgtnwOFgfavlSmsRq7VdThU8HhamayTj5 j7igQWvTIpxvuU2Z5v0bbbk531H2Pm7lxBqT4/x30Mkqj8vms+bHfv2co+Zk9p04E4JC ddUwsFVwuY3zXHJPUP0plH2g9Xokxfpz/ffM3nhjwi/7SdPy50WxV8czMISgWhxCiXwM yJHG7HItxND0IEkVAibslYeNknxenY7nZATbfxP0mRlvgN4qAfrbszG6pvLW/OBBBTQO r6zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wy9o+/0uuVnm0XJBCNmYxwAA4nDuyWiDjWa8e6TaLK8=; b=tiRXBZnfXnjALu6Jl27T2cDtOAKV+ewkr9YQsKGmKPyTHTjyrVlqvcJugatF8g52Mb RgOHG7RVqz0DAeK0o50G6VrQiI/3sHfJhIAeNKi/c9MdNw72uSPrX60lvRjqMbnQ32HB /kHsfjRzJeFKqqiC3qBpRYy6rSHrkWq0nn5osrDAHD0S9tud6hu1wq6evqAzx2ANpngy eXZreb8cQdETzAvWs19Owe7fyu/kKcrVN5QNjfy4g8/lm0Cgv+U6/CFZV3q7uriIqTA2 QPUNhYymXbJ5MNCpWyN+/ivPiKpJAGIxXSYkVnIduoN0HwseZ8gviZL3KR642flLmrFB YDCg== X-Gm-Message-State: AOAM533Md8KR9e9PrO7ObCRU6/GvvakBgxHXMY5dslBmLJcSxCR3btuz 6yV+lYZDlODWO8Nn286rwsaxfdd7m3c= X-Google-Smtp-Source: ABdhPJz5E2cnBl2Rvk6wSTTx6aWMRnOpwDVbLucT8+/YUCNXzXJwHzQDCtHl/gyErG6zDkn7PipL1Q== X-Received: by 2002:a1c:7407:: with SMTP id p7mr24677508wmc.111.1626692045745; Mon, 19 Jul 2021 03:54:05 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 2/3] Add Lazy slab initialization To: win-pv-devel@lists.xenproject.org References: <20210719100334.1831-1-owen.smith@citrix.com> <20210719100334.1831-2-owen.smith@citrix.com> Message-ID: <972008b2-45e9-7cb8-fdb7-67fb311018a9@xen.org> Date: Mon, 19 Jul 2021 11:54:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210719100334.1831-2-owen.smith@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 19/07/2021 11:03, Owen Smith wrote: > Only initialize 1/4 of a slab initially, unless a reservation is defined. > Allocate and initialize each slab object once this initial allocation has been > exceeded. > > This is to decrease the overall resource usage when each cache object's > constructor allocates additional memory. > Whilst I understand the motivation, I don't think this is the right solution. If the resource consumption is too great to justify the performance benefit of using the slab constructor to allocate additional memory then the owner of the cache should simply refrain from doing so and defer that work until the point it actually allocates the object from the cache. There should be no need for a global change such as this. Paul > Signed-off-by: Owen Smith > --- > src/xenbus/cache.c | 27 +++++++++++++++++++++++++-- > 1 file changed, 25 insertions(+), 2 deletions(-) > > diff --git a/src/xenbus/cache.c b/src/xenbus/cache.c > index 247f244..d695ee3 100644 > --- a/src/xenbus/cache.c > +++ b/src/xenbus/cache.c > @@ -61,6 +61,7 @@ typedef struct _XENBUS_CACHE_SLAB { > LIST_ENTRY ListEntry; > USHORT MaximumOccupancy; > USHORT CurrentOccupancy; > + USHORT CurrentAllocated; > ULONG *Mask; > UCHAR Buffer[1]; > } XENBUS_CACHE_SLAB, *PXENBUS_CACHE_SLAB; > @@ -301,6 +302,7 @@ CacheCreateSlab( > ULONG Size; > LONG Index; > LONG SlabCount; > + LONG ObjectsToAllocate; > NTSTATUS status; > > NumberOfBytes = P2ROUNDUP(FIELD_OFFSET(XENBUS_CACHE_SLAB, Buffer) + > @@ -326,6 +328,7 @@ CacheCreateSlab( > Slab->Magic = XENBUS_CACHE_SLAB_MAGIC; > Slab->Cache = Cache; > Slab->MaximumOccupancy = (USHORT)Count; > + Slab->CurrentAllocated = 0; > > Size = P2ROUNDUP(Count, BITS_PER_ULONG); > Size /= 8; > @@ -334,12 +337,18 @@ CacheCreateSlab( > if (Slab->Mask == NULL) > goto fail3; > > - for (Index = 0; Index < (LONG)Slab->MaximumOccupancy; Index++) { > + ObjectsToAllocate = (Cache->Reservation == 0) ? > + (LONG)Count / 4 : > + min((LONG)Cache->Reservation, (LONG)Count); > + > + for (Index = 0; Index < ObjectsToAllocate; Index++) { > PVOID Object = (PVOID)&Slab->Buffer[Index * Cache->Size]; > > status = __CacheCtor(Cache, Object); > if (!NT_SUCCESS(status)) > goto fail4; > + > + Slab->CurrentAllocated++; > } > > CacheInsertSlab(Cache, Slab); > @@ -402,7 +411,7 @@ CacheDestroySlab( > ASSERT(Cache->Cursor != &Cache->SlabList || > IsListEmpty(&Cache->SlabList)); > > - Index = Slab->MaximumOccupancy; > + Index = Slab->CurrentAllocated; > while (--Index >= 0) { > PVOID Object = (PVOID)&Slab->Buffer[Index * Cache->Size]; > > @@ -493,6 +502,20 @@ CacheGetObjectFromSlab( > if (Slab->CurrentOccupancy == Slab->MaximumOccupancy) > return NULL; > > + ASSERT3U(Slab->CurrentOccupancy, <=, Slab->CurrentAllocated); > + ASSERT3U(Slab->CurrentAllocated, <=, Slab->MaximumOccupancy); > + if (Slab->CurrentOccupancy == Slab->CurrentAllocated) { > + NTSTATUS status; > + > + Object = (PVOID)&Slab->Buffer[Slab->CurrentAllocated * Cache->Size]; > + > + status = __CacheCtor(Cache, Object); > + if (!NT_SUCCESS(status)) > + return NULL; > + > + Slab->CurrentAllocated++; > + } > + > Index = __CacheMaskScan(Slab->Mask, Slab->MaximumOccupancy); > BUG_ON(Index >= Slab->MaximumOccupancy); > > From win-pv-devel-bounces@lists.xenproject.org Mon Jul 19 10:57:04 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 19 Jul 2021 10:57:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.158336.291539 (Exim 4.92) (envelope-from ) id 1m5QxL-0001wI-UM; Mon, 19 Jul 2021 10:57:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 158336.291539; Mon, 19 Jul 2021 10:57:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5QxL-0001wB-RX; Mon, 19 Jul 2021 10:57:03 +0000 Received: by outflank-mailman (input) for mailman id 158336; Mon, 19 Jul 2021 10:57:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5QxK-0001w4-Ps for win-pv-devel@lists.xenproject.org; Mon, 19 Jul 2021 10:57:02 +0000 Received: from mail-wm1-x335.google.com (unknown [2a00:1450:4864:20::335]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b9680aed-4adf-4a25-ac8c-2eea09a684e4; Mon, 19 Jul 2021 10:57:02 +0000 (UTC) Received: by mail-wm1-x335.google.com with SMTP id c17so3039929wmb.5 for ; Mon, 19 Jul 2021 03:57:02 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:d6b:d269:ddc4:bf91? ([2a00:23c5:5785:9a01:d6b:d269:ddc4:bf91]) by smtp.gmail.com with ESMTPSA id r17sm19085248wmq.13.2021.07.19.03.57.00 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jul 2021 03:57:00 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: b9680aed-4adf-4a25-ac8c-2eea09a684e4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=j5g22eikjFrpqju5Fh5srM6+ag+gkFR//kG8DIKIho0=; b=i1tvcNg59rSLhZSqi2Q05SfimdSY6y/UpY2okeQ8T7YHb6c1mnkvultqRZ8KyNmAUo U810LuA6LZuK1lgrVpHWI55K5ow5QuCcdpNnfVQEO5BjEu4xAxPGPh2/tNGkl6EjFHxu CtBbWmcfnYx0rdeEc2A9h8fmH3Mgnt4eEXIACKy+GmpABWEBaEjgr0OqDVR7fAwlPv9L pjmBk11oR+DLaVPPC0z8q5PrIOgZ+pEnZ7nveaYR0mZmtljLFt/5uUSycF+x6Xb/mT7e SG9lahqUnTlr6DEuhB5BCrdr1CSoDqRbk047F9cvprCdnJaaLqYw2QJyTVzMj1cVQFk+ LvIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=j5g22eikjFrpqju5Fh5srM6+ag+gkFR//kG8DIKIho0=; b=j1VieSddUuI1fRGRtieo5HEnJWTQ9v8sKM1Td6zXpBKUhV+NmekdDGS7vV6M7tjLMU iRkuBke6rb4tccWPQK2yLFMAWPHZ1FG6xdesqXOS5tRpfJ2eUb875SERbOHy5GrKssLZ NrysnaJFvtmQlKYZMXKQSxtAtWrUYn6LBskvQuCFxhgm1IlTVUlwQ47j7cQX5pdKR1V4 pbPT+i6zLtsbOAh7zzJq0KNw1+qXE3vJ5k6P+bGP0ImKdiOmM5aQAx0JHSml8sdH82se StUeWC689WJCrxolLIWaM7CqG5S4FrfC7A69aFhuiagpvS7rESjqShmhwEkEv8rbb1kV 4ijg== X-Gm-Message-State: AOAM5317mlXJ3pxaZSOVy4FZHb0ge4iN5C6990WbOwfWahxNWB7ibMwB IzrFSqmW8+djJZ/2elymjsuWDkw6RA0= X-Google-Smtp-Source: ABdhPJw0Ud/FTJ+jXETH5Sy9B7qZa6qpp5SYMaBA0YX1685ylkMMobsdQCNgN8EbK4w35XWQhgl8Iw== X-Received: by 2002:a05:600c:4982:: with SMTP id h2mr12000906wmp.184.1626692221328; Mon, 19 Jul 2021 03:57:01 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 3/3] Remove MINIMUM_OBJECT_SIZE To: win-pv-devel@lists.xenproject.org References: <20210719100334.1831-1-owen.smith@citrix.com> <20210719100334.1831-3-owen.smith@citrix.com> Message-ID: <6b52528a-3066-a375-ec7c-51cfcc5c8201@xen.org> Date: Mon, 19 Jul 2021 11:57:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210719100334.1831-3-owen.smith@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 19/07/2021 11:03, Owen Smith wrote: > MINIMUM_OBJECT_SIZE would make all cached objects at least 0x80 bytes, which > would limit the number of objects in each slab to 31 objects. > > This limitation is not needed, as the slab's mask is dynamically allocated to > cope with the correct number of objects that can fit into a single slab. > Cache object's sizes are rounded up to the nearest pointer boundary to maintain > object alignment. Removing the minimum size allows more objects per cache slab, > reducing the memory overhead of caches. > Yes, that restriction dates from a time when the slab mask was inline. > Signed-off-by: Owen Smith Acked-by: Paul Durrant > --- > src/xenbus/cache.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/src/xenbus/cache.c b/src/xenbus/cache.c > index d695ee3..a24c4e5 100644 > --- a/src/xenbus/cache.c > +++ b/src/xenbus/cache.c > @@ -66,12 +66,8 @@ typedef struct _XENBUS_CACHE_SLAB { > UCHAR Buffer[1]; > } XENBUS_CACHE_SLAB, *PXENBUS_CACHE_SLAB; > > -#define BITS_PER_ULONG (sizeof (ULONG) * 8) > -#define MINIMUM_OBJECT_SIZE (PAGE_SIZE / BITS_PER_ULONG) > - > -C_ASSERT(sizeof (XENBUS_CACHE_SLAB) <= MINIMUM_OBJECT_SIZE); > - > -#define MAXNAMELEN 128 > +#define BITS_PER_ULONG (sizeof (ULONG) * 8) > +#define MAXNAMELEN 128 > > struct _XENBUS_CACHE { > LIST_ENTRY ListEntry; > @@ -806,7 +802,6 @@ CacheCreate( > if (!NT_SUCCESS(status)) > goto fail2; > > - Size = __max(Size, MINIMUM_OBJECT_SIZE); > Size = P2ROUNDUP(Size, sizeof (ULONG_PTR)); > > if (Cap == 0) > From win-pv-devel-bounces@lists.xenproject.org Mon Jul 19 11:09:08 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 19 Jul 2021 11:09:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.158349.291556 (Exim 4.92) (envelope-from ) id 1m5R91-0003dW-4W; Mon, 19 Jul 2021 11:09:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 158349.291556; Mon, 19 Jul 2021 11:09:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5R91-0003dP-0v; Mon, 19 Jul 2021 11:09:07 +0000 Received: by outflank-mailman (input) for mailman id 158349; Mon, 19 Jul 2021 11:09:05 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5R8z-0003dJ-CD for win-pv-devel@lists.xenproject.org; Mon, 19 Jul 2021 11:09:05 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ba18f666-e881-11eb-8afc-12813bfff9fa; Mon, 19 Jul 2021 11:09:04 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: ba18f666-e881-11eb-8afc-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626692943; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=3Aq+eLMzBqsCQjS9AAVCIVi4COLRUZcVX4XS52AyWFc=; b=cBtgcHyXKZno3IeL5nTEL9Kktskmk/awwSvA0rlWIbpum/Y/gmfrQvLh PY3Jjw3hjm4WBQtoH/zjnVq2NwW4Gg4y7M14sShq4ukpgPYkB+kB1Vw34 b0BljtGPh7ykFtvU+xWJBzIhw6mvNmBVRltlVMiU3fuOBuKrTgSqwGHT/ A=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 7b7jTGe2J+Y4TV9z61iryAT5R57BlN2+j9r6os7rgLltmz7Qm+LgjnvbhFdZd8iB8GKJiKwQ/m VoScyowk8NGBabT1+eMpAqUlRYbVnyftZI0iaGMo6RoD3f8A0goUBCvvjG1n8sIyN45pud52i4 72k7W+9IkimGNDLdlm1qLspJ57tOaSClwF4Lf65HDxepDfu3cZAOJAPSMDRAV50hjaLVrow4zy a57Ys5tKukeLPOQmTX8Pf09eHnb48IN6NlZbyVMn8XzX6nOgIeQub6f5zqz3J4iPkNJzoW2Wjs 79UVYtiWFZuH6+zM71Z55xQr X-SBRS: 5.1 X-MesageID: 48242511 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:hvMt6q4Q3gE3S+vYygPXwX+BI+orL9Y04lQ7vn2ZFiY6TiXIra +TdaoguSMc0AxhJU3I6urwRJVoJkmsu6KdgLNhcotKOTOGhILGFvAa0WKP+UyDJ8S6zJ8m6U 4CSdk+NDSTNykDsS+S2mDReLxMoKjlzEnrv5ak854Ed3AwV0gK1XYcNu/vKDwReOAwP+tfKH Pz3LsjmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlil9yZbdwkK7aYp8G DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4sow3TX+0SVjbZaKvm/VQMO0aaSAZER4Z /xSiIbToFOArXqDziISFXWqlHdOX0VmgDfIBej8AXeSIrCNWgH4oN69PNkWwqc5Ew6sN5m1q VXm2qfqppMFBvF2D/w/t7SSnhR5wGJSFcZ4KcuZkZkIMMjgX5q3Pki1VIQFI1FEDPx6YghHu UrBMbA5OxOeVffa3zCpGFgzNGlQ3x2R369MwU/k93Q1yITkGFyzkMeysBalnAc9IglQ50B4+ jfKKxnmLxHU8dTZ6NgA+UKR9exFwX2MFjxGXPXJU6iGLAMOnrLpZKy6LIp5PuycJhN15c2kI SpaiIviYfzQTOYNSSq5uwGzvngehTPYd3d8LAr23EigMyNeFPCC1zwdGwT X-IronPort-AV: E=Sophos;i="5.84,252,1620705600"; d="scan'208";a="48242511" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JtZNojqGfYQa6p8hgWCRyMvF8aEqE+1+ZUWs+vo1v4Fo2NkPeu0EI+oDLskDacpq2OuUJjDPKelT5NwPy9DqFpDqCYyAOsNK/Aq6wxzX62EIRKj7JMKCe4kOinkdbbxjjTMst8EFo81/sEGW1j6568xt4YoIFMdOdF25jni3F61XNNIhVDxPPD1FoLcQWky6EQ5QjqSMI97+FIaVxpMV86s3ni56amjCQcPyvLCvtsyGuKbimX9BvfffZDLNZClzsfO0Ei9lKeT3jX9FIQN2sq4QyWjr5Jc3MIxbNiifIYUKBjeDcTa55hKblZZkT41ugs1bZTTsO4JMP4HCMgmzYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Aq+eLMzBqsCQjS9AAVCIVi4COLRUZcVX4XS52AyWFc=; b=bomNg0yBcxK2LiKMk437Qgp7Kdh3IuF62YUY4Tx0AG5YE82oxWuWDIgv4oTe67yFI4PzlXxF2IUGM91m7awFgcgZBGOMUKo2PimxdarbNFMDkVotPau2VhEmWt4qSfKs7z5yGMYyDvJk3wa+7yu0ugI8Ro81xOfz8ccMugPlRByiI8NWDMormXsXjyCUa91179D6HC0ByypVPD4drw23mAb7XaZI5YarYoGkvLSnXGByVczAhYnczAT79OlssmpbHO+alDbAoLt1iWUxOOQzj24lR0yENmaTh77eTwRckO0LnWqgAUAVpPN2gFaFgrUQmiqeOjK5ggPnWZc5mGOnSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Aq+eLMzBqsCQjS9AAVCIVi4COLRUZcVX4XS52AyWFc=; b=JIn1EAdC6oVn93H75W3MjRJgqSviR8X8Wmzo3ne6cvR2zd8nqPfEp2GI+AWfUvMkWB0M91guEt3AJrMpQS1hxqlPpoZhAYHZKs5ApNsVK6mfDrzu4zmd6AIJ3sQqzPP+aoOklbxHhzF1esYaLSaxEqeF3Yluj90NhbIYYO68vkI= From: Owen Smith To: "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Subject: RE: [PATCH 2/3] Add Lazy slab initialization Thread-Topic: [PATCH 2/3] Add Lazy slab initialization Thread-Index: AQHXfIWhE2XS4Xt9zUuvyhBx6dMF3KtKH7wAgAABq9A= Date: Mon, 19 Jul 2021 11:09:00 +0000 Message-ID: References: <20210719100334.1831-1-owen.smith@citrix.com> <20210719100334.1831-2-owen.smith@citrix.com> <972008b2-45e9-7cb8-fdb7-67fb311018a9@xen.org> In-Reply-To: <972008b2-45e9-7cb8-fdb7-67fb311018a9@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 85a0f1f3-20c3-4635-3ded-08d94aa59c99 x-ms-traffictypediagnostic: DM6PR03MB3513: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +HGBmj+nzCKwwjx6tPamtdLArtjrf3Rl/DzmN7B7GPUuFnpAGnZyYUovw0obcNW5cFedeCBNuCsIpA+C+63EVpkqqRmvLNxvuXmG4gmu11cNsOv3m4ju16FVJuGPb3/O8o6inaaJte33DZBmdrjd34GxLcIMJn7/z3RnX/AlTH1SDk7Vfmv3DlIy9rNVPensE03jcyIMHg8+RJ7QHQeuqrYWaSjXgkn838j+YKKf4sme+lKSc2cFhC7e+Wr5wgMwJtTVzIBoJ/Nkl1qj/5dGIx8nO1jGhrfonDpzs4owjiQaVqvrdQyGDxHhRvFBralGazb71WX6/4AD98/CejpSWad+azsVCFriV3CobRhCvH3mLrNgw5JCSCjsaveVcUZyz161UsymmZsEIn9Y1BfV5hR+pOiPspNF5+TpOOTPcVVgRFOYjfUP7ZQgybUXQkMYi7lvhMF6H7Ru1mxBldpqFQN9+AGeDSYeIjxf/L6dNVWZdwVUtOU5sfRqR2mwGenuNKEU+mN2t0NOMulj1WVpK9zOMGdiItKVzdSQIonK2J1p8Hwlh9+TZYBa27VdBftS/7WPiKEOu9rcZTiuUzuw2LFCqTjyTDTtKZMzh5DrkunDyA4hrceO4+mP5fdSE48a2jlWBMO9tugB7a6ftgwfkauxJkyxYCNp7oXKjGmFm9IAf2zw3xi1SiMb5yKADpE542FnquFpEp1uiejppGU2Rw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5477.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(366004)(39860400002)(376002)(396003)(136003)(33656002)(110136005)(66946007)(76116006)(64756008)(66556008)(66476007)(186003)(86362001)(9686003)(53546011)(55016002)(71200400001)(6506007)(7696005)(26005)(478600001)(5660300002)(66446008)(8676002)(44832011)(8936002)(38100700002)(316002)(122000001)(2906002)(52536014)(83380400001)(38070700004);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?S0lRQUV5U3IySFNQRnc1QXFxL3A3anpyTHJEMGJZVC9ldVBtUWxGWjRTb2d6?= =?utf-8?B?a2NlUXhOeExCckFQQnRmSXlmdndDQW9FSzAxNWVpaUMyUmFZcVExTnlNMDhi?= =?utf-8?B?RW9WR2pXdjVxb2hsMFlvWUdpMkVrVFlyY2hLNy9xQUpZUC8ybjRHNno1cXRo?= =?utf-8?B?VTZaKytDYXJxSFZ0VmoyNTdFSktBc0JpQm54OUc5NXZ3cG5sOCs1MFRYYzJl?= =?utf-8?B?cWRUMEhlTXA5WFNYdTRRMW1rYi8wN25EYk9wSk5CQnVTcDhqTGlibDdhNndx?= =?utf-8?B?bGF1TFNKYjRpSi93cUJPL1JBTERaRUFtRkJTaUFPMWNUaVdWTE45d0dyRTV0?= =?utf-8?B?L0JNYUl6ZHY0YnB3S2RtamVQbERWbml3QkhDTFM0SFM5b3prZDN5dW9KNklT?= =?utf-8?B?OVo4eThUR2RISGUreDBXSk1uMnJvVHhWaDR1TXBFc0ZMUkhGRlFzK01PaXZU?= =?utf-8?B?aVU4YkZSZHdUemJSb2VYTCtXdzhkTjdGR3gxRlVIM0JsTEZxWjlhWXFONlpr?= =?utf-8?B?cTNpdTIvR3BlL1JIMW12YmlhQ0JjM29aZytzbGNEb292S255TjYxdVFkUSsx?= =?utf-8?B?UHVLcXVPSEhSQ2NhSnpYbUVCZE9BdXpqTXA4bXdrRmE5NGJuSmhqeFcydWc2?= =?utf-8?B?b1BsQVRZdzhoU0h1am5wakFtekI3akt5N0JpRE5IbnNONUdkNEM4ejNVbE13?= =?utf-8?B?QmJrZnNHa1laS3ozL0EwUEVMTGU2M0l3YlVrUnp5WUcydEYvYnh1bVh1U1NG?= =?utf-8?B?T2YvWXVTVE1sZk5ndjJsWUg2M240b0hRUFRydFR1U1pIQ2tyVmFnbUZkUmVM?= =?utf-8?B?VmU5RVBoMFZJS2tTc3I5SDFnQW1VcnlXTnZmUG5GMUlSNE10QWc3czkwc3Rv?= =?utf-8?B?TEZSZk1hR0wzMlRQRDRrMUMwNzZoQmZZaDMyZW16Nmk0WmpvR2Z2cDd5bS91?= =?utf-8?B?dHV4dlBsbXgySlZ1RHhScVJSbTBBWHBUUERIaEdGSzFnUXM2M0VHc0hkZXZT?= =?utf-8?B?L2YvbnJJTWZMWlc0RzhyUUg0VVNrcms5TTZwRGxnd3JpN0liRk96NXI4YXRx?= =?utf-8?B?WTc4UGVLWlZnMllvZ3N2ZWlQbmt3dzczcm5TNVBCMmRYc1VON0twWnFrKy9B?= =?utf-8?B?VE9LYno0aW9qVjJrMk1tVHI2Q1p5RG9kcUl0MkY3SUxTa0loTTBuMnRUSDVO?= =?utf-8?B?RTBVejFSVlQ0c210WjRCT1oxSkpPWUpIVUFSOGY3S3lrY3k0WkRIbHBnUzlR?= =?utf-8?B?TkJVT29EOGpVc1hEdE94SVJlY1RWSG55MzB3cjRoK09raUltenhqOVNNbkU3?= =?utf-8?B?WlB1L2NlTE5YMHRiaXR3TTVvN0h6d24xRjNtZFNsUlU2TjhhSWljOHg0YlNB?= =?utf-8?B?NjVrVUhQMFB2NXBIVVBFZlhUb1pIOVdVbm5pRFpUQmp5YnRHWE50czhhMHZa?= =?utf-8?B?ZnYweW1NVU5ac0VFYnE3Z3Juc3pqcFdKQTJucWtnTG5Pa2hTdko2Tk9LNURT?= =?utf-8?B?UlZ1T0xWU0JMZzRoYkxEMlJRS2VuVS9TTTEyZndrVjVFYytFY0pucklMNXlt?= =?utf-8?B?WW90QlBxVDBPdHZIUjdoNGNGNHI1TnNpcGhybUh5MW9EUGhTUWJ5SXR2bkda?= =?utf-8?B?dWZ1SEgvRzhQNFdvWnhLdU9CR0hQS0Z5VWhtNjRiaTB1aEpBbndYb2JHa3lv?= =?utf-8?B?dFN3ckdObXozb2Npc2V5cTkydVc1SEdacDAycGRFY3FrU2xXTWt5VWZ6eFZp?= =?utf-8?Q?Dp+gNhM4KgAEKMfiOU=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5477.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 85a0f1f3-20c3-4635-3ded-08d94aa59c99 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2021 11:09:00.6296 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BBdQ8c2wEsC7ivU8ObPFcJXuSB9HKmcpWnwCigfS6adlrdM4N5v0ZaZ5ZhPKobYB0dSXcREHc6dgZKEd51HuGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3513 X-OriginatorOrg: citrix.com LS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCkZyb206IHdpbi1wdi1kZXZlbCA8d2luLXB2LWRl dmVsLWJvdW5jZXNAbGlzdHMueGVucHJvamVjdC5vcmc+IE9uIEJlaGFsZiBPZiBQYXVsIER1cnJh bnQNClNlbnQ6IE1vbmRheSwgSnVseSAxOSwgMjAyMSAxMTo1NCBBTQ0KVG86IHdpbi1wdi1kZXZl bEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KU3ViamVjdDogUmU6IFtQQVRDSCAyLzNdIEFkZCBMYXp5 IHNsYWIgaW5pdGlhbGl6YXRpb24NCg0KW0NBVVRJT04gLSBFWFRFUk5BTCBFTUFJTF0gRE8gTk9U IHJlcGx5LCBjbGljayBsaW5rcywgb3Igb3BlbiBhdHRhY2htZW50cyB1bmxlc3MgeW91IGhhdmUg dmVyaWZpZWQgdGhlIHNlbmRlciBhbmQga25vdyB0aGUgY29udGVudCBpcyBzYWZlLg0KDQpPbiAx OS8wNy8yMDIxIDExOjAzLCBPd2VuIFNtaXRoIHdyb3RlOg0KPiBPbmx5IGluaXRpYWxpemUgMS80 IG9mIGEgc2xhYiBpbml0aWFsbHksIHVubGVzcyBhIHJlc2VydmF0aW9uIGlzIGRlZmluZWQuDQo+ IEFsbG9jYXRlIGFuZCBpbml0aWFsaXplIGVhY2ggc2xhYiBvYmplY3Qgb25jZSB0aGlzIGluaXRp YWwgYWxsb2NhdGlvbiANCj4gaGFzIGJlZW4gZXhjZWVkZWQuDQo+IA0KPiBUaGlzIGlzIHRvIGRl Y3JlYXNlIHRoZSBvdmVyYWxsIHJlc291cmNlIHVzYWdlIHdoZW4gZWFjaCBjYWNoZSANCj4gb2Jq ZWN0J3MgY29uc3RydWN0b3IgYWxsb2NhdGVzIGFkZGl0aW9uYWwgbWVtb3J5Lg0KPiANCg0KV2hp bHN0IEkgdW5kZXJzdGFuZCB0aGUgbW90aXZhdGlvbiwgSSBkb24ndCB0aGluayB0aGlzIGlzIHRo ZSByaWdodCBzb2x1dGlvbi4gSWYgdGhlIHJlc291cmNlIGNvbnN1bXB0aW9uIGlzIHRvbyBncmVh dCB0byBqdXN0aWZ5IHRoZSBwZXJmb3JtYW5jZSBiZW5lZml0IG9mIHVzaW5nIHRoZSBzbGFiIGNv bnN0cnVjdG9yIHRvIGFsbG9jYXRlIGFkZGl0aW9uYWwgbWVtb3J5IHRoZW4gdGhlIG93bmVyIG9m IHRoZSBjYWNoZSBzaG91bGQgc2ltcGx5IHJlZnJhaW4gZnJvbSBkb2luZyBzbyBhbmQgZGVmZXIg dGhhdCB3b3JrIHVudGlsIHRoZSBwb2ludCBpdCBhY3R1YWxseSBhbGxvY2F0ZXMgdGhlIG9iamVj dCBmcm9tIHRoZSBjYWNoZS4gVGhlcmUgc2hvdWxkIGJlIG5vIG5lZWQgZm9yIGEgZ2xvYmFsIGNo YW5nZSBzdWNoIGFzIHRoaXMuDQoNCiAgIFBhdWwNCg0KDQpJdHMgcG9zc2libGUgdGhhdCB0aGlz IGlzIG5vdCBuZWVkIHdoZW4gdGhlIDNyZCBwYXRjaCAoUmVtb3ZlIE1JTklNVU1fT0JKRUNUX1NJ WkUpIGlzIHVzZWQuIA0KSW4gWGVuVmJkLCB0aGUgYm91bmNlIGJ1ZmZlcnMgaGFkIGEgcmVzZXJ2 YXRpb24gb2YgMzIgb2JqZWN0cyAoZWFjaCBvYmplY3Qgd2lsbCBhbGxvY2F0ZSBhIHBhZ2Ugb2Yg bWVtb3J5KS4gVGhpcyB1bmZvcnR1bmF0ZWx5IGN1cnJlbnRseSByZXN1bHRzIGluIDIgc2xhYnMg b2YgMzEgb2JqZWN0cywgd2hpY2ggaXMgZmFyIG1vcmUgdGhhbiB1c2VkIGluIGEgcmVsYXRpdmVs eSB1bnVzZWQgVk0gKGV4cGVyaW1lbnRhbGx5LCAxNiBib3VuY2UgYnVmZmVycyBhcmUgdXNlZCBh dCBhbnkgb25lIHRpbWUpLg0KVGhpcyBkb2VzIGxlYXZlIHRoZSBwb3NzaWJpbGl0eSBvZiBjb25z dW1pbmcgc2lnbmlmaWNhbnQgbWVtb3J5IHdoZW4gYSBuZXcgc2xhYiBpcyByZXF1aXJlZC4gQXQg d29yc2UgdGhpcyBjYW4gYmUgKFBBR0VfU0laRSAtIHNpemVvZihYRU5CVVNfQ0FDSEVfU0xBQikp IC8gc2l6ZW9mKFBWT0lEKSBvYmplY3RzIGFsbG9jYXRpbmcgYSBzaW5nbGUgcGFnZSwgb3IgbGVz cyBvYmplY3RzIGFsbG9jYXRpbmcgbXVsdGlwbGUgcGFnZXMuDQoNCkkgd2lsbCBsb29rIGF0IG1h a2luZyB1c2VycyBvZiB0aGUgY2FjaGUgaW50ZXJmYWNlIGF0dGVtcHQgdG8gYXZvaWQgcHJlYWxs b2NhdGlvbiBvZiBwYWdlcyBkdXJpbmcgdGhlIGNvbnN0cnVjdG9yIGNhbGwuDQoNCk93ZW4NCg0K PiBTaWduZWQtb2ZmLWJ5OiBPd2VuIFNtaXRoIDxvd2VuLnNtaXRoQGNpdHJpeC5jb20+DQo+IC0t LQ0KPiAgIHNyYy94ZW5idXMvY2FjaGUuYyB8IDI3ICsrKysrKysrKysrKysrKysrKysrKysrKyst LQ0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQ0K PiANCj4gZGlmZiAtLWdpdCBhL3NyYy94ZW5idXMvY2FjaGUuYyBiL3NyYy94ZW5idXMvY2FjaGUu YyBpbmRleCANCj4gMjQ3ZjI0NC4uZDY5NWVlMyAxMDA2NDQNCj4gLS0tIGEvc3JjL3hlbmJ1cy9j YWNoZS5jDQo+ICsrKyBiL3NyYy94ZW5idXMvY2FjaGUuYw0KPiBAQCAtNjEsNiArNjEsNyBAQCB0 eXBlZGVmIHN0cnVjdCBfWEVOQlVTX0NBQ0hFX1NMQUIgew0KPiAgICAgICBMSVNUX0VOVFJZICAg ICAgTGlzdEVudHJ5Ow0KPiAgICAgICBVU0hPUlQgICAgICAgICAgTWF4aW11bU9jY3VwYW5jeTsN Cj4gICAgICAgVVNIT1JUICAgICAgICAgIEN1cnJlbnRPY2N1cGFuY3k7DQo+ICsgICAgVVNIT1JU ICAgICAgICAgIEN1cnJlbnRBbGxvY2F0ZWQ7DQo+ICAgICAgIFVMT05HICAgICAgICAgICAqTWFz azsNCj4gICAgICAgVUNIQVIgICAgICAgICAgIEJ1ZmZlclsxXTsNCj4gICB9IFhFTkJVU19DQUNI RV9TTEFCLCAqUFhFTkJVU19DQUNIRV9TTEFCOyBAQCAtMzAxLDYgKzMwMiw3IEBAIA0KPiBDYWNo ZUNyZWF0ZVNsYWIoDQo+ICAgICAgIFVMT05HICAgICAgICAgICAgICAgU2l6ZTsNCj4gICAgICAg TE9ORyAgICAgICAgICAgICAgICBJbmRleDsNCj4gICAgICAgTE9ORyAgICAgICAgICAgICAgICBT bGFiQ291bnQ7DQo+ICsgICAgTE9ORyAgICAgICAgICAgICAgICBPYmplY3RzVG9BbGxvY2F0ZTsN Cj4gICAgICAgTlRTVEFUVVMgICAgICAgICAgICBzdGF0dXM7DQo+ICAgDQo+ICAgICAgIE51bWJl ck9mQnl0ZXMgPSBQMlJPVU5EVVAoRklFTERfT0ZGU0VUKFhFTkJVU19DQUNIRV9TTEFCLCANCj4g QnVmZmVyKSArIEBAIC0zMjYsNiArMzI4LDcgQEAgQ2FjaGVDcmVhdGVTbGFiKA0KPiAgICAgICBT bGFiLT5NYWdpYyA9IFhFTkJVU19DQUNIRV9TTEFCX01BR0lDOw0KPiAgICAgICBTbGFiLT5DYWNo ZSA9IENhY2hlOw0KPiAgICAgICBTbGFiLT5NYXhpbXVtT2NjdXBhbmN5ID0gKFVTSE9SVClDb3Vu dDsNCj4gKyAgICBTbGFiLT5DdXJyZW50QWxsb2NhdGVkID0gMDsNCj4gICANCj4gICAgICAgU2l6 ZSA9IFAyUk9VTkRVUChDb3VudCwgQklUU19QRVJfVUxPTkcpOw0KPiAgICAgICBTaXplIC89IDg7 DQo+IEBAIC0zMzQsMTIgKzMzNywxOCBAQCBDYWNoZUNyZWF0ZVNsYWIoDQo+ICAgICAgIGlmIChT bGFiLT5NYXNrID09IE5VTEwpDQo+ICAgICAgICAgICBnb3RvIGZhaWwzOw0KPiAgIA0KPiAtICAg IGZvciAoSW5kZXggPSAwOyBJbmRleCA8IChMT05HKVNsYWItPk1heGltdW1PY2N1cGFuY3k7IElu ZGV4KyspIHsNCj4gKyAgICBPYmplY3RzVG9BbGxvY2F0ZSA9IChDYWNoZS0+UmVzZXJ2YXRpb24g PT0gMCkgPw0KPiArICAgICAgICAgICAgICAgIChMT05HKUNvdW50IC8gNCA6DQo+ICsgICAgICAg ICAgICAgICAgbWluKChMT05HKUNhY2hlLT5SZXNlcnZhdGlvbiwgKExPTkcpQ291bnQpOw0KPiAr DQo+ICsgICAgZm9yIChJbmRleCA9IDA7IEluZGV4IDwgT2JqZWN0c1RvQWxsb2NhdGU7IEluZGV4 KyspIHsNCj4gICAgICAgICAgIFBWT0lEIE9iamVjdCA9IChQVk9JRCkmU2xhYi0+QnVmZmVyW0lu ZGV4ICogQ2FjaGUtPlNpemVdOw0KPiAgIA0KPiAgICAgICAgICAgc3RhdHVzID0gX19DYWNoZUN0 b3IoQ2FjaGUsIE9iamVjdCk7DQo+ICAgICAgICAgICBpZiAoIU5UX1NVQ0NFU1Moc3RhdHVzKSkN Cj4gICAgICAgICAgICAgICBnb3RvIGZhaWw0Ow0KPiArDQo+ICsgICAgICAgIFNsYWItPkN1cnJl bnRBbGxvY2F0ZWQrKzsNCj4gICAgICAgfQ0KPiAgIA0KPiAgICAgICBDYWNoZUluc2VydFNsYWIo Q2FjaGUsIFNsYWIpOw0KPiBAQCAtNDAyLDcgKzQxMSw3IEBAIENhY2hlRGVzdHJveVNsYWIoDQo+ ICAgICAgIEFTU0VSVChDYWNoZS0+Q3Vyc29yICE9ICZDYWNoZS0+U2xhYkxpc3QgfHwNCj4gICAg ICAgICAgICAgIElzTGlzdEVtcHR5KCZDYWNoZS0+U2xhYkxpc3QpKTsNCj4gICANCj4gLSAgICBJ bmRleCA9IFNsYWItPk1heGltdW1PY2N1cGFuY3k7DQo+ICsgICAgSW5kZXggPSBTbGFiLT5DdXJy ZW50QWxsb2NhdGVkOw0KPiAgICAgICB3aGlsZSAoLS1JbmRleCA+PSAwKSB7DQo+ICAgICAgICAg ICBQVk9JRCBPYmplY3QgPSAoUFZPSUQpJlNsYWItPkJ1ZmZlcltJbmRleCAqIENhY2hlLT5TaXpl XTsNCj4gICANCj4gQEAgLTQ5Myw2ICs1MDIsMjAgQEAgQ2FjaGVHZXRPYmplY3RGcm9tU2xhYigN Cj4gICAgICAgaWYgKFNsYWItPkN1cnJlbnRPY2N1cGFuY3kgPT0gU2xhYi0+TWF4aW11bU9jY3Vw YW5jeSkNCj4gICAgICAgICAgIHJldHVybiBOVUxMOw0KPiAgIA0KPiArICAgIEFTU0VSVDNVKFNs YWItPkN1cnJlbnRPY2N1cGFuY3ksIDw9LCBTbGFiLT5DdXJyZW50QWxsb2NhdGVkKTsNCj4gKyAg ICBBU1NFUlQzVShTbGFiLT5DdXJyZW50QWxsb2NhdGVkLCA8PSwgU2xhYi0+TWF4aW11bU9jY3Vw YW5jeSk7DQo+ICsgICAgaWYgKFNsYWItPkN1cnJlbnRPY2N1cGFuY3kgPT0gU2xhYi0+Q3VycmVu dEFsbG9jYXRlZCkgew0KPiArICAgICAgICBOVFNUQVRVUyAgICAgICAgICAgIHN0YXR1czsNCj4g Kw0KPiArICAgICAgICBPYmplY3QgPSAoUFZPSUQpJlNsYWItPkJ1ZmZlcltTbGFiLT5DdXJyZW50 QWxsb2NhdGVkICogDQo+ICsgQ2FjaGUtPlNpemVdOw0KPiArDQo+ICsgICAgICAgIHN0YXR1cyA9 IF9fQ2FjaGVDdG9yKENhY2hlLCBPYmplY3QpOw0KPiArICAgICAgICBpZiAoIU5UX1NVQ0NFU1Mo c3RhdHVzKSkNCj4gKyAgICAgICAgICAgIHJldHVybiBOVUxMOw0KPiArDQo+ICsgICAgICAgIFNs YWItPkN1cnJlbnRBbGxvY2F0ZWQrKzsNCj4gKyAgICB9DQo+ICsNCj4gICAgICAgSW5kZXggPSBf X0NhY2hlTWFza1NjYW4oU2xhYi0+TWFzaywgU2xhYi0+TWF4aW11bU9jY3VwYW5jeSk7DQo+ICAg ICAgIEJVR19PTihJbmRleCA+PSBTbGFiLT5NYXhpbXVtT2NjdXBhbmN5KTsNCj4gICANCj4gDQoN Cg0K From win-pv-devel-bounces@lists.xenproject.org Mon Jul 19 12:25:19 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 19 Jul 2021 12:25:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.158376.291578 (Exim 4.92) (envelope-from ) id 1m5SKj-0003TG-1N; Mon, 19 Jul 2021 12:25:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 158376.291578; Mon, 19 Jul 2021 12:25:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5SKi-0003T9-UL; Mon, 19 Jul 2021 12:25:16 +0000 Received: by outflank-mailman (input) for mailman id 158376; Mon, 19 Jul 2021 12:25:15 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5SKh-0003T3-J2 for win-pv-devel@lists.xenproject.org; Mon, 19 Jul 2021 12:25:15 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5e141f16-e88c-11eb-8b04-12813bfff9fa; Mon, 19 Jul 2021 12:25:14 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 5e141f16-e88c-11eb-8b04-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626697514; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=gHGu7wM9ObDFykbWqoF8HnXiKuRED81kIFPfHksC2GM=; b=d0PcxwExL6vMm9CIoMF7Mtddjo44kpHJ9caz4tlQhUh81IuvR0Bk/ptH 4K5D8yapwC+NS5lU8p69poaIq0FO97Ri+fkqWVIiQMQ50bAV+8dJPTxGI MoogOfXhCGvQpzzbT5Ibjj9Ti5jhPSQd6gI+hawmgpHN5UvvnlhM+lnPG A=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: j1Lo82NPnAAEnV6Le2zPDkxa2hQ/2YaNXYm+T3AmPreXupOMCT0otOmAmpAOz5s10uF3Dtc2+o 7u0Omku65drUU6LGHfTBUZjEdI6m8+KUJAQsE5Ue6u9LQDw3lSKm9P4oaz3p7kFyEj4ZzlQAuI StyZS2mWZEdba+DUjv9vRKMtllhdetO1o+vZyPdvSCxM1OAd4h9sHtGfa6hr2el46b8M7Yd7Z3 7o620tEyfR73GG2JIefO7yiPNPvv2orKjrtMLzMEnXQcdy1NBRjALaFj3DH+IFYCa74LgmJMJ1 bXMYeC+asn1oDvxw5uKF/UGt X-SBRS: 5.1 X-MesageID: 50214944 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:gc1pcaizmRGoPjmSqzJIsvkh/3BQX2113DAbv31ZSRFFG/FwyP rBoB1L73DJYWgqNE3IwerwRZVoMkmsiaKdhrNhc4tKPTOW91dASbsC0WKM+UyYJ8STzJ8+6U 4kSdkFNDSSNyk6sS+Z2njBLz9I+rDum8rE5Za8854ud3AQV0gJ1XYjNu/xKDwTeOAyP+teKH Pq3Lshm9PPQwVzUu2LQl0+G8TTrdzCk5zrJTQcAQQ81QWIhTS0rJbnDhmxxH4lInNy6IZn1V KAvx3y562lvf3+4ATbzXXv45Nfn8ak4sdfBfaLltMeJlzX+0WVjcVaKv+/VQIO0aWSAWUR4Z 7xStAbToJOAkbqDySISN3WqlDdOXgVmiffIBSj8ATeSITCNUwH4ox69Nhkm1LimjsdlcA536 RR022DsZ1LSRvGgSTm/tDNEwpnj0yuvBMZ4KUuZlFkIMIjgYVq3MQiFYJuYeI9NTO/7JpiHP hlDcna6voTeVSGb2rBtm0qxNC3RHw8EhqPX0BH46WuonVrtWE8y1FdyN0Un38G+p54Q55Y5/ 7cOqAtkL1VVMcZYa90Ge9ES8qqDW7GRw7KLQupUB7aPbBCP2iIp4/84b0z6u3vcJsUzIEqkJ CES19cvX5aQTOZNSRP5uw9zvnpehTwYd3A8LAs23FJgMyJeFOwC1zydLkHqbrTn8ki X-IronPort-AV: E=Sophos;i="5.84,252,1620705600"; d="scan'208";a="50214944" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XGLynhqZLH86cIM77DL9Kf677UoeqgHwjfIcRuN8CA/SoW02zOu02mjEuH7qfvVY6d5PkbZ8h3IqsxbwOgTcw9iuk1vNY99Nye63NuRCnyJEbGu84eA7i8KGVLtxFm6nCaohLdEhs+m0Lei3xKnKoPYZ3sLIHf/Ut7QC4O2VSdtw5vLY71sfE5xDZxUEScfivlRUGUGhgB8SdUVTU7hrJA8qK4JtLA/t0iSYU2S8MRhD4YP46PEKpSUPg7ORJpBp/0DeZnHMgJ2xSJCrBTtrhzjHGEBAf2oyMIY+kRdwd8ClWwIYJSGbzNZaaRsl/ttEx2/l8XLyBkmIoB9nA9bbsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gHGu7wM9ObDFykbWqoF8HnXiKuRED81kIFPfHksC2GM=; b=mNKjdpnQsnYljngD73Iur9P+cuRXtnxkvNr0Wx6o9EzRAIbWeS1FXo+ktKdsco8fjoZ7kxll4B2Ity1ZO0ajv+seDSbUnvVopwNztHPYEwerf3u1A35x/3y0bJbC6xpbpZ7dndkT6MZWPzwTNqB1UqpbjK5q2fON4U/B2nodwRGwBoMYYBREdQjOeXkEmwtRNejADGYJVHYYT+04mX73dVZ3HyARghoro01EWsje6oXal3IY+E+xJ3odCLZNn5yWryzOO1jgDq6ML5GC0IhKAvMr3xaONt7xxI1SAAbWflfW4p2Vjz4HQtfyPsG4Y8JIzq6Xcert3khX2R7mxYNAUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gHGu7wM9ObDFykbWqoF8HnXiKuRED81kIFPfHksC2GM=; b=rM8uSzEb8LSfhFTE3R8y4izQxlzoe3PSLbgEkTwjfOsiKr8jEanm3eYYWBaW8xrtOYaGSPFkWXvIZTPvSV63lAtVQaabK1QFFFnrRvuRTTRG5KIMfoFxI3wnzIwwWV38nZmapJn/T3SmPqi7Hxm2B34iKgfNtauttRKgSU6Rtis= From: Martin Harvey To: "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Subject: RE: [PATCH 1/3] Additional logging for module loading. Thread-Topic: [PATCH 1/3] Additional logging for module loading. Thread-Index: AQHXeXt+rl5hdj5rGkmU03P8lXlZwqtJ6rYAgABURLA= Date: Mon, 19 Jul 2021 12:25:05 +0000 Message-ID: References: <20210715131502.176-1-Martin.Harvey@citrix.com> <06db6e8a-45d9-a47c-5495-4deb546702b4@xen.org> In-Reply-To: <06db6e8a-45d9-a47c-5495-4deb546702b4@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fc21b4e2-03e6-4592-651c-08d94ab03d56 x-ms-traffictypediagnostic: MWHPR03MB2816: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2449; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: d+YkAfNxRzBALMqlIjijziKqJNkprrAhvJpkpNR8dEaNZk9CRd4pPXV1wcew0ZkIzvsdD/0P8LZVlbgM26Hl7zptGpyqnX4QpwgWWZ0lQQ2SVEi/ATrgY4aqR+VzPVOksE3TGFSwU2OKHF1jDwzqNsFFiW6N+fyR2YFOSirE7uIJpmfVtwwInpBUvHeMQpnrN32n1rRpz3eNrnE15F0DPRnwm+ZGMNkMs7+nUH1mO4dvCUC2jPlZaWXhOdVlKglq1Zd115KQsOjEQ1HMargTjtuBhmd41hdDW11a+xMIQecZmv0z3A/CKFzsSIbVdbeymhyZuxvqWIj6qb9Ljn4Np0hHJ5fvqnxC0BVsLNMSkWi9eXoOo9KNKfCyIV5EiD9q2Jv7iWOyB4MdtAG1tsyoObSuNpVeVV32fJ9NrChdmqDrfdI0rxrfqgbda/4PCaq1LF65KCOYwA8tUHORqy6HfO5MIBlSFwkoE5Ks2UfDRNfd9Pqx1fWNERcOkQN6+pcAhP/SCz2PAdyS5v/jHjIoR2aNQm4yG5tdSG13DshA3udTOx7wZgSEj4mJ+UtVCBrVnu+uoTJpEB9IA9A+bf6FWF8VKeAyZXd1SBfyF/38W8oaQccIDJlISGsu9zETbeHKjlvpi4mJhXCQ462UAuZvsaoHvXty31Ga2r+FhiKEEE0tR49v+ABZgMdyd6f4zVuZZVXV0CQpZZlyo6b9j4hH+Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6347.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(396003)(136003)(376002)(366004)(346002)(53546011)(122000001)(110136005)(478600001)(8676002)(2906002)(55016002)(6506007)(9686003)(44832011)(38100700002)(26005)(316002)(186003)(5660300002)(76116006)(66946007)(83380400001)(7696005)(66446008)(64756008)(66556008)(66476007)(86362001)(33656002)(8936002)(71200400001)(52536014)(38070700004);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NVFEb0tOd2F6RkUzSytLY0pYOWdTVkd4V2FGMTQ2UDJPZjl1dEVISW84QXFF?= =?utf-8?B?d3pWZGtQOWJxQzlVQTc3MWNrMmNpNVBwU1dKZGJHODcwUVRRcWZtbGprZ1lG?= =?utf-8?B?bk5mZUlTQzl6M0NOY21PSXJKcEFCU3VCWHJlQWpBVHQ4cW1RK1BFT3ZYaFlO?= =?utf-8?B?eU4wcWZvNEdHUCt2OVJZR3h0d2tIbkdmdVNyMU5RQ2k4ZllrVmpRZStUcDVF?= =?utf-8?B?a0ZuOTNOQ0FVUW42cm8vcENxZjRENTYvbzQzN3BsckVoMjNHWHcrejBBOTQy?= =?utf-8?B?OGVjSEhGcXpKR1VSelV4NWFQcFdvZXFmd0dkTjR5VmY2YXRaMjN3cEJndTJH?= =?utf-8?B?TEpGeW9nOFh2WW9aZDFsU0g2QkM0Tk13aGtpcGJCZzh3QThuY3BRUk5vaThE?= =?utf-8?B?dkRtamNVOXJjODdpN0tDSlFSRmtWMlZiUWlZZVA4N3Z4UklqSWY3Ry9SV3Y4?= =?utf-8?B?UzdudEZYZzY1dlZobnQ3ci9zYzJjL3dleHNyNWVvdVUvZkg1TGU5Z3dEdmFU?= =?utf-8?B?Qi91VnVDUkFCZDh3dUVtbXRzQW1VWUt1ejVrSEs1SEtSVC9IY3dzUFBPbDFF?= =?utf-8?B?QnZzbXFWNHVCcTJ6dEZ2L2g4S0RFcW0zT3R1M0V4WDBiQ2hzMUg0RVVYM2Jr?= =?utf-8?B?MVFlRUpaRWVRcUc2SlJ6UXhBS2FpMitrNkVab21ONzd4Z2ZvTGNCQy9JWWlU?= =?utf-8?B?T2NRZ1BvSDBMT0I4TmpZYWlGTWRWNVRxVVRWL1phL3I3MVNaUEZEdytBMld3?= =?utf-8?B?VHUzc0h0Z01nWk1zWDdyMFJTQWdWSWNyYWg5cUlQY2tNUTVRakNkcGxic1Rv?= =?utf-8?B?dkRTaHFiUmx0OE1keVNkMEV1dzNrd1MrSXZIUks0eGg3czBhV0pmaS95RmF4?= =?utf-8?B?UmRYc0pXR1U4Nnp3djNFayt4RDd6RlBJV09KYVVHWTIyUVVFMkk3ZW9zV3RS?= =?utf-8?B?Z2tzbXNDS0tzdUMzUnBCQ0pCQzZnd0VrRG5XNTR3cUtXSkVrL0JlSkJOcHp1?= =?utf-8?B?N1pTcFVDOFpOeE9tNC9WSUdqcVV3Tk5LU1pvU05LMlduRk4yWFFXSGYzdDBr?= =?utf-8?B?WU5DQXBrZjNwR1JtYXBaaGVKcHRab2d5b1M3NVhVVFRkdS96bTNXNk5TbU5w?= =?utf-8?B?U1p5VGx0a1FPenpiM0RUTXp6clU5KzdUb0VUNnN3eFVXakgrZHRFR1BQR1k1?= =?utf-8?B?ME1uMXlrQkNraU9BL0dITXFWY0FYWU1LYVk3VWpvaEN4RjY5VnNHczNnN3Mx?= =?utf-8?B?cVFBblZnbWFXZ01OejRONzVrS2ZZNHF2d04yYytjYllXVHhLQWRyc1BzYXR5?= =?utf-8?B?OE5nWmdlTlRPRktpbDExMzlUajVLQkdkbyt0MTk3ZDRIcDNHaDNZZGFWTjha?= =?utf-8?B?MERQc3kyZkcrNnpUSkt2TTlYcXg3c1ZOdlA0OUY4Y002eEdIaU5FM0RrY09M?= =?utf-8?B?OEREdldDUVloUlJQNnlpQ2hlbzVLaXBXekR1TmZXb09peDUvM0QvVFFtWmFY?= =?utf-8?B?cG9NVDlvSTNBWmR3WTFKcUsraE8wanBxb2FySEM2b1JJT2p0dEg5d2JRZDhM?= =?utf-8?B?RjZicDQ1MXduV1lEWEduc1l2QXp2T3BlYzU1aXVPZHRtK2JpK0VwOFFSVGth?= =?utf-8?B?bTZZUDI2djJSYnNvR1FRL0d5V1E3alJKQ0Y3dTdtTmlYaEYwS0pZNGJPWXF6?= =?utf-8?B?dGJUWXJQVXFaRGlZMHFJTXhsek9va1M2cW9qdEtLd2F0c2hqczdsYkQ3aWdr?= =?utf-8?Q?fVnGJmuuZBxLGRK78zLDrexuunWob3pi7XIpJNo?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6347.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc21b4e2-03e6-4592-651c-08d94ab03d56 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2021 12:25:05.2979 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 66UCYqTtww5JOFl2in8gI6ipWE77/VI4oI1TGL5qwSXpNuYPWf0YrizoSspuUtsEuf+is0TEeAUvjkQbLj4BA4P4N7q3J8YrOsYu+bqmIgQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2816 X-OriginatorOrg: citrix.com SSB3b3VsZCBsaWtlIHRvIGhhdmUgdGhlIGxvZ2dpbmcgZW5hYmxlZCBhbGwgdGhlIHRpbWUuIFdo aWxzdCB0aGUgY2FzZSBJIG1lbnRpb25lZCBpcyBzYWZlIG1vZGUgYm9vdCwgSSB3b3VsZCBiZSBh IGxpYXIgaWYgSSBzYWlkIHRoYXQgdGhhdCB3YXMgdGhlIG9ubHkgd2F5IHRvIGJyZWFrIHRoZSBm aWx0ZXJpbmcuDQoNCk1ILg0KDQotLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KRnJvbTogd2lu LXB2LWRldmVsIDx3aW4tcHYtZGV2ZWwtYm91bmNlc0BsaXN0cy54ZW5wcm9qZWN0Lm9yZz4gT24g QmVoYWxmIE9mIFBhdWwgRHVycmFudA0KU2VudDogMTkgSnVseSAyMDIxIDA4OjIzDQpUbzogd2lu LXB2LWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQpTdWJqZWN0OiBSZTogW1BBVENIIDEvM10g QWRkaXRpb25hbCBsb2dnaW5nIGZvciBtb2R1bGUgbG9hZGluZy4NCg0KW0NBVVRJT04gLSBFWFRF Uk5BTCBFTUFJTF0gRE8gTk9UIHJlcGx5LCBjbGljayBsaW5rcywgb3Igb3BlbiBhdHRhY2htZW50 cyB1bmxlc3MgeW91IGhhdmUgdmVyaWZpZWQgdGhlIHNlbmRlciBhbmQga25vdyB0aGUgY29udGVu dCBpcyBzYWZlLg0KDQpPbiAxNS8wNy8yMDIxIDE0OjE1LCBNYXJ0aW4gSGFydmV5IHdyb3RlOg0K PiBSZWNlbnQgcmVsZWFzZXMgb2YgV2luZG93cyAoMTAgYW5kIDExIGluIHBhcnRpY3VsYXIpIGFs bG93IG9ubGluZSANCj4gZWRpdGlvbiB1cGRhdGVzIHdoaWNoIGludm9sdmUgYSBkcml2ZXIgbWln cmF0aW9uIHN0ZXAsIHdoaWNoIG9jY3VycyBpbiANCj4gU0FGRUJPT1QgbW9kZS4NCj4gDQo+IElu IHNvbWUgcmFyZSBjYXNlcywgdGhpcyBzdGVwIG1heSBmYWlsIChmb3IgYSB2YXJpZXR5IG9mIHJl YXNvbnMpLg0KPiBUaGlzIGFkZGl0aW9uYWwgbG9nZ2luZyBhZGRlZCB0byBkZWJ1ZyBzdWNoIHVw Z3JhZGUgY2FzZXMuDQoNCkp1c3QgdG8gYmUgY2xlYXIgaGVyZS4gSXMgdGhlIGludGVudGlvbiB0 byBoYXZlIHRoaXMgbG9nZ2luZyBlbmFibGVkIGFsbCB0aGUgdGltZSBvciBvbmx5IGluIHNhZmUg bW9kZT8gVGhlIGNvbW1lbnQgYWJvdmUgc3VnZ2VzdHMgdGhlIGxhdHRlciBidXQgdGhlcmUgaXMg bm8gc3VjaCBndWFyZCBvbiB0aGUgY2FsbCB0byBJbmZvKCkgYmVsb3cuDQoNCiAgIFBhdWwNCg0K PiANCj4gU2lnbmVkLU9mZi1CeTogTWFydGluIEhhcnZleSA8bWFydGluLmhhcnZleUBjaXRyaXgu Y29tPg0KPiAtLS0NCj4gICBzcmMveGVuL21vZHVsZS5jIHwgNSArKysrKw0KPiAgIDEgZmlsZSBj aGFuZ2VkLCA1IGluc2VydGlvbnMoKykNCj4gDQo+IGRpZmYgLS1naXQgYS9zcmMveGVuL21vZHVs ZS5jIGIvc3JjL3hlbi9tb2R1bGUuYyBpbmRleCANCj4gZGE3ZjExMy4uMTgxM2UzYiAxMDA2NDQN Cj4gLS0tIGEvc3JjL3hlbi9tb2R1bGUuYw0KPiArKysgYi9zcmMveGVuL21vZHVsZS5jDQo+IEBA IC0xNDUsNiArMTQ1LDExIEBAIE1vZHVsZUFkZCgNCj4gICAgICAgQk9PTEVBTiAgICAgICAgICAg ICBBZnRlcjsNCj4gICAgICAgTlRTVEFUVVMgICAgICAgICAgICBzdGF0dXM7DQo+ICAgDQo+ICsg ICAgSW5mbygiJXAgLSAlcCBbJXNdXG4iLA0KPiArICAgICAgICAgU3RhcnQsDQo+ICsgICAgICAg ICBTdGFydCArIFNpemUgLSAxLA0KPiArICAgICAgICAgTmFtZSk7DQo+ICsNCj4gICAgICAgTmV3 ID0gX19Nb2R1bGVBbGxvY2F0ZShzaXplb2YgKE1PRFVMRSkpOw0KPiAgIA0KPiAgICAgICBzdGF0 dXMgPSBTVEFUVVNfTk9fTUVNT1JZOw0KPiANCg0KDQo= From win-pv-devel-bounces@lists.xenproject.org Mon Jul 19 13:13:24 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 19 Jul 2021 13:13:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.158406.291645 (Exim 4.92) (envelope-from ) id 1m5T5H-0002Iy-RE; Mon, 19 Jul 2021 13:13:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 158406.291645; Mon, 19 Jul 2021 13:13:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5T5H-0002Ip-OG; Mon, 19 Jul 2021 13:13:23 +0000 Received: by outflank-mailman (input) for mailman id 158406; Mon, 19 Jul 2021 13:13:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5T5G-0002IH-6d for win-pv-devel@lists.xenproject.org; Mon, 19 Jul 2021 13:13:22 +0000 Received: from mail-wr1-x435.google.com (unknown [2a00:1450:4864:20::435]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 01a5a5e9-a9bc-4c3a-a0f6-3f652e923956; Mon, 19 Jul 2021 13:13:21 +0000 (UTC) Received: by mail-wr1-x435.google.com with SMTP id d2so22038606wrn.0 for ; Mon, 19 Jul 2021 06:13:20 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:d6b:d269:ddc4:bf91? ([2a00:23c5:5785:9a01:d6b:d269:ddc4:bf91]) by smtp.gmail.com with ESMTPSA id 6sm20142972wmi.3.2021.07.19.06.13.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jul 2021 06:13:19 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 01a5a5e9-a9bc-4c3a-a0f6-3f652e923956 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hsetuAZo0RgzUzV1a6NrY6wXfwtvrtp4sV5Eo0rZpn8=; b=p24bsUndQJDODjYO8KjLTTxwRrn7tYcZ54dZpOtDuroGKumEt7wMbBLIhGkp8X3ti2 Wvu0JQTLfqMmgTEimlASdEXzeAHWMlFbOs9Zl05BRJatQSwSxaQDYiN+01uyZa+ywUn2 XdHt9KGUn6M5Q5FogyilipD9HwwFQuDxgUkCnTieKtOXvwxuY2oy6HHy0r4O5btelQVQ XX4AaapsmhEJgyJK1CSQE4xnbwELxXNGs3XLvdLOFk41JGdIphMnC2ye7CMJpvIj/+tN 6cniR7e//e6+BIAT3kz2GM1g53vLhw25zSp92YyGfqUqeVKhAosonYaD+V2mvRDYeRp+ eLag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hsetuAZo0RgzUzV1a6NrY6wXfwtvrtp4sV5Eo0rZpn8=; b=BvW9gsSnG/8BQSyXNqsQz3ureyBgMeg1I0vLvLdGq6wuIyJIbKY05wkLKtaIrfmU/E My8qcP4HO/EBDvKPEAU4kJDz1PZMVSWoJ+mRmLmR5qdxZ44z7UpH0tu9DQ+uC9m7gzs9 xWFFqlACj4pTDuuMSn4QoSWqgqtgyIBUVvFhWgpCAjbYRBOoRNKb70mYcMmIfLNZzDUL 7+984ny7NhMZQxcl4CybDcAlTmlFo4VWfD5CMa3qZwKPyQ4GxWlrUA2o4hLKCDxr5uwB q/RIgOGsjs1Yb9fUak4tumFK/372GfyuRn++1V+uXTsxKDIAMjoadydIW+A/wyGz+WgP V4yQ== X-Gm-Message-State: AOAM531RHsFk1OdisXFUx+a2o5i0JuW3ZlMEuqBeuKPnYMo6kSRiZAXQ G6rHhDelNN1GrkAskzYAOnk3Ajyu0x4= X-Google-Smtp-Source: ABdhPJzF8s7zoZBww8+cYLX0NQ6QZgygkjOaZ7HSUTjrSzlXmhYQv+zGovxx2dZi8LxxZB7XSrJX1A== X-Received: by 2002:adf:f885:: with SMTP id u5mr29474861wrp.84.1626700400222; Mon, 19 Jul 2021 06:13:20 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 1/3] Additional logging for module loading. To: Martin Harvey , "win-pv-devel@lists.xenproject.org" References: <20210715131502.176-1-Martin.Harvey@citrix.com> <06db6e8a-45d9-a47c-5495-4deb546702b4@xen.org> Message-ID: <8759c68b-3e6d-5deb-c172-6e4ff8463aa8@xen.org> Date: Mon, 19 Jul 2021 14:13:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 19/07/2021 13:25, Martin Harvey wrote: > I would like to have the logging enabled all the time. Whilst the case I mentioned is safe mode boot, I would be a liar if I said that that was the only way to break the filtering. > Ok. Acked-by: Paul Durrant > MH. > > -----Original Message----- > From: win-pv-devel On Behalf Of Paul Durrant > Sent: 19 July 2021 08:23 > To: win-pv-devel@lists.xenproject.org > Subject: Re: [PATCH 1/3] Additional logging for module loading. > > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments unless you have verified the sender and know the content is safe. > > On 15/07/2021 14:15, Martin Harvey wrote: >> Recent releases of Windows (10 and 11 in particular) allow online >> edition updates which involve a driver migration step, which occurs in >> SAFEBOOT mode. >> >> In some rare cases, this step may fail (for a variety of reasons). >> This additional logging added to debug such upgrade cases. > > Just to be clear here. Is the intention to have this logging enabled all the time or only in safe mode? The comment above suggests the latter but there is no such guard on the call to Info() below. > > Paul > >> >> Signed-Off-By: Martin Harvey >> --- >> src/xen/module.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/src/xen/module.c b/src/xen/module.c index >> da7f113..1813e3b 100644 >> --- a/src/xen/module.c >> +++ b/src/xen/module.c >> @@ -145,6 +145,11 @@ ModuleAdd( >> BOOLEAN After; >> NTSTATUS status; >> >> + Info("%p - %p [%s]\n", >> + Start, >> + Start + Size - 1, >> + Name); >> + >> New = __ModuleAllocate(sizeof (MODULE)); >> >> status = STATUS_NO_MEMORY; >> > > From win-pv-devel-bounces@lists.xenproject.org Mon Jul 19 13:19:41 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 19 Jul 2021 13:19:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.158426.291648 (Exim 4.92) (envelope-from ) id 1m5TBM-0003Di-Al; Mon, 19 Jul 2021 13:19:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 158426.291648; Mon, 19 Jul 2021 13:19:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5TBM-0003Db-7s; Mon, 19 Jul 2021 13:19:40 +0000 Received: by outflank-mailman (input) for mailman id 158426; Mon, 19 Jul 2021 13:19:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5TBL-0003DV-5n for win-pv-devel@lists.xenproject.org; Mon, 19 Jul 2021 13:19:39 +0000 Received: from mail-wr1-x42f.google.com (unknown [2a00:1450:4864:20::42f]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 46ca747d-d4e3-4542-a73b-a3b245c3808b; Mon, 19 Jul 2021 13:19:38 +0000 (UTC) Received: by mail-wr1-x42f.google.com with SMTP id d12so21968967wre.13 for ; Mon, 19 Jul 2021 06:19:38 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:d6b:d269:ddc4:bf91? ([2a00:23c5:5785:9a01:d6b:d269:ddc4:bf91]) by smtp.gmail.com with ESMTPSA id n18sm19442272wrt.89.2021.07.19.06.19.37 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jul 2021 06:19:37 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 46ca747d-d4e3-4542-a73b-a3b245c3808b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=dwiiyUcKNIlouCKtupiRPLqaYJA0sO9yVUZUAs5hHB0=; b=O6fQhMr3ueqbdwirwLHyavQEFS4R/GckBJ0u7ViU1tvuN3R/wi6CcHqnw3+4EdJ1ds 8R9TolI8yLhqa5IZjszzbTiPsHZhiTxOGMg8ItpaljPANpZviIzWvNsE48hNxULYMgb5 pDWx+FrPOCP6g7xDCbmx8403xIriXxbkbt4fI4pucn14E6BtZqoq6794Cqd0EgQdYay5 TGbREHtq4tlee0oR0VtoCIO/OiD3Yl2LFXw+6mOXfgjWiDwrmFk/yPBhxBN+9IYyALlp 41CloKyA2eEGqnKPgGW+bo+lQ3dDGRB9bXsIErDo0SQd17/DelUbe/Fp5w2515iXod/o l6JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dwiiyUcKNIlouCKtupiRPLqaYJA0sO9yVUZUAs5hHB0=; b=LaxO3vw/OReJB3prgR4VKdvrCpili68zscA2FOf7rK05lDG06QJaZdOswZtsKZ7hh+ 8ii3bCXKC7wigiuZSCmqDJBU7y5IBS/okfcOQJ+1UDuNiYuXa60Kctbvl3J9U1UTPuna 0c6qalzYRDRDnCvfRESsQDZ/dt7CcWgpmkNmbtCy4gA/mk3agsC5U0cvX/npLzS/zLXj FTf8yfDegdlh69uu1NNXRfx+Y1Ci66piuO+4C1sFzAzomXSrNBIu0CPUZjUHnsv7Y0M0 zOyNMXOG5hmw1FXYqlsZvRtZw9QbPS0KFY3rGgJs25WeXUgZJ6kLOLnpNeTqOEGm0yjz MvHA== X-Gm-Message-State: AOAM531WZ4taVKZnTGrGli9htdNGFTc7x2Ep+5DUewlwMaE3zdmw3HQ/ 6S7X2nnDrCaG+qxu+oE+akX43nphxJE= X-Google-Smtp-Source: ABdhPJwQ6GsQOSTCnFJms9rPa7s3a4GtffH4cvZGgrHgYAN5RrWOMShlCZpDtOvH4Y8y6Fwj/yQ3MA== X-Received: by 2002:adf:edc6:: with SMTP id v6mr8919098wro.340.1626700777600; Mon, 19 Jul 2021 06:19:37 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 2/3] Add logging for XenFilt AddDevice. To: win-pv-devel@lists.xenproject.org References: <20210715131502.176-1-Martin.Harvey@citrix.com> <20210715131502.176-2-Martin.Harvey@citrix.com> Message-ID: <76e0ab25-fec2-bf47-c94b-78513388288c@xen.org> Date: Mon, 19 Jul 2021 14:19:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210715131502.176-2-Martin.Harvey@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 15/07/2021 14:15, Martin Harvey wrote: > Recent releases of Windows (10 and 11 in particular) allow > online edition updates which involve a driver migration step, > which occurs in SAFEBOOT mode. > > In some rare cases, this step may fail (for a variety of reasons). > This additional logging added to debug such upgrade cases. > > Signed-Off-By: Martin Harvey Acked-by: Paul Durrant > --- > src/xenfilt/driver.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/src/xenfilt/driver.c b/src/xenfilt/driver.c > index e9e6673..f131282 100644 > --- a/src/xenfilt/driver.c > +++ b/src/xenfilt/driver.c > @@ -723,6 +723,19 @@ fail1: > return status; > } > > +static FORCEINLINE PCHAR > +__EmulatedTypeName( > + IN XENFILT_EMULATED_OBJECT_TYPE Type > + ) > +{ > + switch (Type) { > + case XENFILT_EMULATED_OBJECT_TYPE_UNKNOWN: return "UNKNOWN"; > + case XENFILT_EMULATED_OBJECT_TYPE_PCI: return "PCI"; > + case XENFILT_EMULATED_OBJECT_TYPE_IDE: return "IDE"; > + default: return "InvalidType"; > + } > +} > + > static XENFILT_EMULATED_OBJECT_TYPE > DriverGetEmulatedType( > IN PCHAR Id > @@ -804,6 +817,10 @@ DriverAddDevice( > } > } > > + Info("%p %s\n", > + PhysicalDeviceObject, > + __EmulatedTypeName(Type)); > + > status = STATUS_SUCCESS; > if (Type == XENFILT_EMULATED_OBJECT_TYPE_UNKNOWN) > goto done; > From win-pv-devel-bounces@lists.xenproject.org Mon Jul 19 14:51:11 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 19 Jul 2021 14:51:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.158464.291714 (Exim 4.92) (envelope-from ) id 1m5Ubt-00072K-79; Mon, 19 Jul 2021 14:51:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 158464.291714; Mon, 19 Jul 2021 14:51:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5Ubt-00072D-4N; Mon, 19 Jul 2021 14:51:09 +0000 Received: by outflank-mailman (input) for mailman id 158464; Mon, 19 Jul 2021 14:51:07 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5Ubr-000725-8O for win-pv-devel@lists.xenproject.org; Mon, 19 Jul 2021 14:51:07 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" Date: Mon, 19 Jul 2021 14:50:55 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <2261477.1.1626706257627.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> Subject: XENBUS-master - Build #223 - Successful MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_0_32498830.1626706256408" X-Jenkins-Job: XENBUS-master X-Jenkins-Result: SUCCESS ------=_Part_0_32498830.1626706256408 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #223. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENBUS-master/223/console to view the results. ------=_Part_0_32498830.1626706256408-- From win-pv-devel-bounces@lists.xenproject.org Mon Jul 19 15:41:35 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 19 Jul 2021 15:41:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.158487.291753 (Exim 4.92) (envelope-from ) id 1m5VOg-0004ms-IP; Mon, 19 Jul 2021 15:41:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 158487.291753; Mon, 19 Jul 2021 15:41:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5VOg-0004ml-FR; Mon, 19 Jul 2021 15:41:34 +0000 Received: by outflank-mailman (input) for mailman id 158487; Mon, 19 Jul 2021 15:41:33 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5VOf-0004mf-6B for win-pv-devel@lists.xenproject.org; Mon, 19 Jul 2021 15:41:33 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" Date: Mon, 19 Jul 2021 15:41:23 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <22914853.3.1626709283457.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> Subject: XENBUS-master - Build #224 - Successful MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_2_9154921.1626709283347" X-Jenkins-Job: XENBUS-master X-Jenkins-Result: SUCCESS ------=_Part_2_9154921.1626709283347 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #224. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENBUS-master/224/console to view the results. ------=_Part_2_9154921.1626709283347-- From win-pv-devel-bounces@lists.xenproject.org Tue Jul 20 01:02:24 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 20 Jul 2021 01:02:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.158601.291887 (Exim 4.92) (envelope-from ) id 1m5e9O-00041H-28; Tue, 20 Jul 2021 01:02:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 158601.291887; Tue, 20 Jul 2021 01:02:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5e9N-000418-Ux; Tue, 20 Jul 2021 01:02:21 +0000 Received: by outflank-mailman (input) for mailman id 158601; Tue, 20 Jul 2021 01:02:21 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5e9N-000412-7z for win-pv-devel@lists.xenproject.org; Tue, 20 Jul 2021 01:02:21 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" Date: Tue, 20 Jul 2021 01:02:11 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <3412881.5.1626742931802.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> Subject: XENVIF-master - Build #187 - Successful MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_4_17699585.1626742931474" X-Jenkins-Job: XENVIF-master X-Jenkins-Result: SUCCESS ------=_Part_4_17699585.1626742931474 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #187. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENVIF-master/187/console to view the results. ------=_Part_4_17699585.1626742931474-- From win-pv-devel-bounces@lists.xenproject.org Tue Jul 20 13:30:22 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 20 Jul 2021 13:30:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.158735.292073 (Exim 4.92) (envelope-from ) id 1m5ppD-0000Ac-Mw; Tue, 20 Jul 2021 13:30:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 158735.292073; Tue, 20 Jul 2021 13:30:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5ppD-0000AU-K7; Tue, 20 Jul 2021 13:30:19 +0000 Received: by outflank-mailman (input) for mailman id 158735; Tue, 20 Jul 2021 13:30:17 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5ppB-0000AM-Kz for win-pv-devel@lists.xenproject.org; Tue, 20 Jul 2021 13:30:17 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 897ff370-55f6-4d2a-8641-b903e4ac642e; Tue, 20 Jul 2021 13:30:16 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 897ff370-55f6-4d2a-8641-b903e4ac642e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626787816; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=+DvwpmAYJN1JAvsYypZG9q2258tDJII6NDseFw3X7g4=; b=B+cN4/dib78ihn/izEX84toy58utlDccXnc+b0Ek92D07TIzwest0HUW Y5rZ9XOD+i0ICdJHXiuDf8OCR6mb7yK8+2K3etrdbuYrnB4UYbp4l0Rmy 31L1e+As9D21eoLAbtEyfXGcyAxJ+GlLz7zAqQ+D4sdIFBSD9Ef6LENr5 w=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: oMD+L+eFDVdJ7rXf+1kT56WcyG9PA8ZeqK6/wtWWu4vKO3dQ0RURKD2utODv7jVHLme4XotkTn za2vClWCSduZcBp4KIXL7bNZKuRXrWrVniSsr7shxTbM0iICLefxx+5louCws1JS67GnKgSfF6 zzeBycefEZdGLDApLzBmexNVgUiRlE0VZ1Q1kAbkTvibikRB1oDDRaZOYlLOufJgBmZKNDBC+/ amcTWZ/DUQconMe5ZucIE0sGkdm2bFXN+4WdhUS5UaNNmDkNyV/r0T0TLtQgG8WNJv1Z+xqPtC PeJ1UzCFumNz0hENBJXi1GCO X-SBRS: 5.1 X-MesageID: 48706373 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:aTQHEa4qNex2ciUHIgPXwPDXdLJyesId70hD6qhwISY6TiX+rb HJoB17726NtN9/YhEdcLy7VJVoBEmskKKdgrNhWotKPjOW21dARbsKheCJrgEIWReOktK1vZ 0QCpSWY+eQMbEVt6nHCXGDYrQd/OU= X-IronPort-AV: E=Sophos;i="5.84,254,1620705600"; d="scan'208";a="48706373" From: Martin Harvey To: CC: Martin Harvey Subject: [PATCH 6/6] Under conditions of high load, it was possible for xenvif to queue up very large numbers of packets before pushing them all upstream in one go. This was partially ameliorated by use of the NDIS_RECEIVE_FLAGS_RESOURCES flag. Date: Tue, 20 Jul 2021 14:29:51 +0100 Message-ID: <20210720132951.1776-6-Martin.Harvey@citrix.com> X-Mailer: git-send-email 2.25.0.windows.1 In-Reply-To: <20210720132951.1776-1-Martin.Harvey@citrix.com> References: <20210720132951.1776-1-Martin.Harvey@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Unfortunately, this was not always a sufficient fix, and in some low memory cases, NDIS and higher level drivers could bugcheck attempting to copy MDL's and packet contents (NETIO!RtlCopyMdlToMdlIndirect). This patch adds backpressure to the Rx path, such that it is only possible to indicate a certain number of receive buffers in any one DPC. In such cases, another DPC is immediately scheduled, on the understanding that DPC's for higher level drivers are likely to consume those packets and free up resources in the interim. In such a backpressure state, the RX ring is not drained until all packets in the intermediate queue have been indicated up the stack. Signed off by: Martin Harvey --- src/xenvif/receiver.c | 93 +++++++++++++++++++++++++++++++++---------- 1 file changed, 73 insertions(+), 20 deletions(-) diff --git a/src/xenvif/receiver.c b/src/xenvif/receiver.c index 7295646..964207b 100644 --- a/src/xenvif/receiver.c +++ b/src/xenvif/receiver.c @@ -99,11 +99,14 @@ typedef struct _XENVIF_RECEIVER_RING { BOOLEAN Connected; BOOLEAN Enabled; BOOLEAN Stopped; + BOOLEAN Backpressured; + BOOLEAN FinalFlush; XENVIF_VIF_OFFLOAD_OPTIONS OffloadOptions; ULONG BackfillSize; PXENBUS_DEBUG_CALLBACK DebugCallback; PXENVIF_THREAD WatchdogThread; PLIST_ENTRY PacketQueue; + LONG PacketQueueEstSize; //Conservative estimate. KDPC QueueDpc; ULONG QueueDpcs; LIST_ENTRY PacketComplete; @@ -147,6 +150,8 @@ struct _XENVIF_RECEIVER { #define XENVIF_RECEIVER_TAG 'ECER' +#define RX_BUFFERING_MAX 2048 //X-ref XenNet IN_NDIS_MAX (half in NDIS half elsewhere) + static FORCEINLINE PVOID __ReceiverAllocate( IN ULONG Length @@ -1337,43 +1342,56 @@ __ReceiverRingSwizzle( PXENVIF_VIF_CONTEXT Context; LIST_ENTRY List; PLIST_ENTRY ListEntry; + BOOLEAN AllFlushed; + ULONG PushedUpstream; Receiver = Ring->Receiver; Frontend = Receiver->Frontend; Context = PdoGetVifContext(FrontendGetPdo(Frontend)); + AllFlushed = TRUE; + PushedUpstream = 0; InitializeListHead(&List); - ListEntry = InterlockedExchangePointer(&Ring->PacketQueue, NULL); + if (IsListEmpty(&Ring->PacketComplete) || Ring->FinalFlush) + { + Ring->PacketQueueEstSize = 0; + ListEntry = InterlockedExchangePointer(&Ring->PacketQueue, NULL); - // Packets are held in the queue in reverse order so that the most - // recent is always head of the list. This is necessary to allow - // addition to the list to be done atomically. + // Packets are held in the queue in reverse order so that the most + // recent is always head of the list. This is necessary to allow + // addition to the list to be done atomically. - while (ListEntry != NULL) { - PLIST_ENTRY NextEntry; + while (ListEntry != NULL) { + PLIST_ENTRY NextEntry; - NextEntry = ListEntry->Blink; - ListEntry->Flink = ListEntry->Blink = ListEntry; + NextEntry = ListEntry->Blink; + ListEntry->Flink = ListEntry->Blink = ListEntry; - InsertHeadList(&List, ListEntry); + InsertHeadList(&List, ListEntry); - ListEntry = NextEntry; - } + ListEntry = NextEntry; + } - while (!IsListEmpty(&List)) { - PXENVIF_RECEIVER_PACKET Packet; + while (!IsListEmpty(&List)) { + PXENVIF_RECEIVER_PACKET Packet; - ListEntry = RemoveHeadList(&List); - ASSERT3P(ListEntry, !=, &List); + ListEntry = RemoveHeadList(&List); + ASSERT3P(ListEntry, !=, &List); - RtlZeroMemory(ListEntry, sizeof (LIST_ENTRY)); + RtlZeroMemory(ListEntry, sizeof (LIST_ENTRY)); - Packet = CONTAINING_RECORD(ListEntry, XENVIF_RECEIVER_PACKET, ListEntry); - ReceiverRingProcessPacket(Ring, Packet); + Packet = CONTAINING_RECORD(ListEntry, XENVIF_RECEIVER_PACKET, ListEntry); + ReceiverRingProcessPacket(Ring, Packet); + } + } + else + { + AllFlushed = FALSE; } - while (!IsListEmpty(&Ring->PacketComplete)) { + while ((!IsListEmpty(&Ring->PacketComplete)) + && ((PushedUpstream < RX_BUFFERING_MAX) || Ring->FinalFlush)) { PXENVIF_RECEIVER_PACKET Packet; PXENVIF_PACKET_INFO Info; PUCHAR BaseVa; @@ -1381,6 +1399,8 @@ __ReceiverRingSwizzle( PETHERNET_ADDRESS DestinationAddress; ETHERNET_ADDRESS_TYPE Type; + PushedUpstream++; + ListEntry = RemoveHeadList(&Ring->PacketComplete); ASSERT3P(ListEntry, !=, &Ring->PacketComplete); @@ -1536,9 +1556,33 @@ __ReceiverRingSwizzle( Packet->TagControlInformation, &Packet->Info, &Packet->Hash, - !IsListEmpty(&Ring->PacketComplete) ? TRUE : FALSE, + ((!IsListEmpty(&Ring->PacketComplete)) + && ((PushedUpstream < RX_BUFFERING_MAX) || Ring->FinalFlush)) ? TRUE : FALSE, Packet); } + + if (!IsListEmpty(&Ring->PacketComplete)) + AllFlushed = FALSE; + + if (!AllFlushed) + { + //Re-run remainder from back of DPC queue. + Ring->Backpressured = TRUE; + if (KeInsertQueueDpc(&Ring->QueueDpc, NULL, NULL)) + Ring->QueueDpcs++; + } + else + { + if ((Ring->Backpressured) && !Ring->FinalFlush) + { + //Not any more - restart dataflow from initial ring poll. + Ring->Backpressured = FALSE; + + //PollDpc zeroed before final flush, don't queue it here. + if (KeInsertQueueDpc(&Ring->PollDpc, NULL, NULL)) + Ring->PollDpcs++; + } + } } static FORCEINLINE VOID @@ -1973,6 +2017,8 @@ __ReceiverRingQueuePacket( ListEntry->Blink = Ring->PacketQueue; New = ListEntry; } while (InterlockedCompareExchangePointer(&Ring->PacketQueue, (PVOID)New, (PVOID)Old) != Old); + + InterlockedIncrement(&Ring->PacketQueueEstSize); } static DECLSPEC_NOINLINE ULONG @@ -1992,6 +2038,9 @@ ReceiverRingPoll( if (!Ring->Enabled) goto done; + if ((Ring->PacketQueueEstSize >= RX_BUFFERING_MAX) && !Ring->FinalFlush) + goto done; + for (;;) { BOOLEAN Error; BOOLEAN Extra; @@ -2949,8 +2998,12 @@ __ReceiverRingTeardown( Ring->BackfillSize = 0; Ring->OffloadOptions.Value = 0; + Ring->FinalFlush = TRUE; + KeInsertQueueDpc(&Ring->QueueDpc, NULL, NULL); KeFlushQueuedDpcs(); RtlZeroMemory(&Ring->QueueDpc, sizeof (KDPC)); + Ring->Backpressured = FALSE; + Ring->FinalFlush = FALSE; ThreadAlert(Ring->WatchdogThread); ThreadJoin(Ring->WatchdogThread); -- 2.25.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Tue Jul 20 13:30:23 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 20 Jul 2021 13:30:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.158737.292083 (Exim 4.92) (envelope-from ) id 1m5ppH-0000D0-TE; Tue, 20 Jul 2021 13:30:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 158737.292083; Tue, 20 Jul 2021 13:30:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5ppH-0000Cn-NC; Tue, 20 Jul 2021 13:30:23 +0000 Received: by outflank-mailman (input) for mailman id 158737; Tue, 20 Jul 2021 13:30:23 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5ppG-0000CM-Tv for win-pv-devel@lists.xenproject.org; Tue, 20 Jul 2021 13:30:22 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a1731262-e95e-11eb-8b78-12813bfff9fa; Tue, 20 Jul 2021 13:30:21 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: a1731262-e95e-11eb-8b78-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626787821; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=TG3TdxNJvp+x4VbG+4HfplQrK5BUb2YDQyqQGFvoyN8=; b=b4srfbrSw7sY73EZqN3ZjvWOSpW2LDRgpWVlTaVwjmbphq1j6b+SBov5 MYzT+PooY3GfSWbPGIJzfTVwwbXbYdzFryqX0JmEtCgCrjUNlBholpKhj P9OpL8+EVW4fZXH/EKSZnK1ceCF0wjOA4e3om0UpKQBeSpuYjyZC5krPX Q=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: SJV2nI6sjDcm4MUGlp+dN+qCRuFQh3jksHNIYTUVBKpWcVZnpscgGu4Yh2Zhjvz0dg3+DtmvER u43ys9N67kFJrtZSA/6SL1etJmh0pDgIvY4tfQYJMnt/CZazzspi5CrFFvvrBg/lY2l7soLwGO P01WoKtt+D8rS+9diJbfb3Df8E86ASbPuTppvVM827GNzVZc3DlKQU+OQyIfPXbssHDjvoVr3d WaIW/Hc84JZCE2H/4soPc/2+spzVLM+aY2EWTeoBqgZDAgQSNGFvSCtC2RgV3e0yK0XIdv8NC6 aA0h5c4/wmDpikcOUYzQrmxm X-SBRS: 5.1 X-MesageID: 49037438 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:td8a2KobmXLiYENtNSKcwzkaV5taL9V00zEX/kB9WHVpm5Sj5q eTdPRy73DJYUUqKRcdcLG7Sdi9qBznhP1ICOUqUItKGTOW3FdAT7sSnbcKoQeQeREWn9Q1vc wLT0E9MqyUMbEQt6jHCXyDc+rIt+PnzEnHv4vjJjxWPHhXgulbnn9EIxfeEFd7AAFAGJonFI GB/I5GoDWnEE5nEfiTFz0GReSGr9rXlI3negIdQx4h9QWUhz+w9bjgVxie0RF2aUIy/Z4ytW ren0jw+7iqufC+xhjA2G/X8phMmNzujttFGcCWgMQNNzP2zgaua4IJYcz+gBkl5OO05BIgjN zPpxs7Jcx852nffmSprQDs3Aelyjwn7Dv4xUWFhGaLm72GeBsqT8haicZCfgDH51Ehu957uZ g7pV5xmaAndi/9oA== X-IronPort-AV: E=Sophos;i="5.84,254,1620705600"; d="scan'208";a="49037438" From: Martin Harvey To: CC: Martin Harvey , Martin Harvey Subject: [PATCH 5/6] Reduce logging of Fdo->NotDisableable, in a similar manner to changes already made to xenbus. Date: Tue, 20 Jul 2021 14:29:50 +0100 Message-ID: <20210720132951.1776-5-Martin.Harvey@citrix.com> X-Mailer: git-send-email 2.25.0.windows.1 In-Reply-To: <20210720132951.1776-1-Martin.Harvey@citrix.com> References: <20210720132951.1776-1-Martin.Harvey@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Signed-off-by: Martin Harvey --- src/xenvif/fdo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/xenvif/fdo.c b/src/xenvif/fdo.c index 896107c..745f948 100644 --- a/src/xenvif/fdo.c +++ b/src/xenvif/fdo.c @@ -2075,7 +2075,7 @@ FdoQueryPnpDeviceState( goto done; if (Fdo->NotDisableable) { - Info("%s: not disableable\n", __FdoGetName(Fdo)); + Trace("%s: not disableable\n", __FdoGetName(Fdo)); State |= PNP_DEVICE_NOT_DISABLEABLE; } -- 2.25.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Tue Jul 20 13:30:23 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 20 Jul 2021 13:30:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.158736.292081 (Exim 4.92) (envelope-from ) id 1m5ppH-0000Ci-SQ; Tue, 20 Jul 2021 13:30:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 158736.292081; Tue, 20 Jul 2021 13:30:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5ppH-0000CZ-Le; Tue, 20 Jul 2021 13:30:23 +0000 Received: by outflank-mailman (input) for mailman id 158736; Tue, 20 Jul 2021 13:30:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5ppG-0000AM-HD for win-pv-devel@lists.xenproject.org; Tue, 20 Jul 2021 13:30:22 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 11da4d26-348a-4f6c-a113-4726b641b3e8; Tue, 20 Jul 2021 13:30:17 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 11da4d26-348a-4f6c-a113-4726b641b3e8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626787817; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=rdQjrfmWWeAHgOnXPnYB/+rCmDMWEDVH/HG7Dw/pZZY=; b=JhStDP17L8uSxN0qmkXjl7Zbck5uASaOLeEdKHDEYxWV35QJynJFlBsd SHSNFidkdJCNj6ijD92BMeuQVIvWBboll123Jhzj6J4heVzw7iEBgD92o RdyULA4Sin0iauo31bqJnM6uRd+g+js9ur37c4RQd4nBaXBS+oBlZLmjT Y=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: QDE78McfnyDYOyicMA+36fhg5w1Ui6nxX33fung57zdB4/GRNjPeFkZD+TF91wbmp8aRY7Aa/R H2VjAx1Q6DVxXPWab1b9sxtV39twa8rJ9OaAUPCl+1T5+k6mWDJ6fxf8jYIH9pgH5J54A5mKWJ LVWWuMZa3y4cVdjhmLYjVnXYeDQT2a8D9JLGXjhyB0I2FP6e3B69MN2CESzRS711mjv8FxbAAr L6Kp/cs4idYAbM51xabDqmyQ+FfDwRYFOqVYqsDqtS7udLThhAMJOSMQjx8GLGgt8VcobMENoK 5gnBULwPevSVdZvw0EpjauOO X-SBRS: 5.1 X-MesageID: 48706375 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:QAf6jqBzJ0FX70jlHejVsseALOsnbusQ8zAXPh9KJyC9I/b2qy nxppgmPEfP+UwssQIb6K290ci7MD/hHPtOi7X5Uo3SOjUO1FHYT72KqLGSuAEIeBeOudK1t5 0QCpSWYeeYZTMW7KbHCUuDYq4dKbK8gcWVbJLlvhBQpHZRGsVdBmlCe2SmO3wzYDMDKYsyFZ Ka6MYCjSGnY24rYsOyAWRAd/TfpvXQ/aiWICIuNloC0k2jnDmo4Ln1H1yzxREFSQ5Cxr8k7C zsjxH53KO+qPu2oyWsl1M7rq4m2+cJ+OEzQfBkufJlbgkETTzYI7iJbofy/gzdZtvfrmrC3u O8+ivIdP4Dl085NlvF3icFnTOQngoG2jva0lmfjmLkocvlABwHK+cpv/MDTjLpr3M6utdyya RK2H/ckaF2I1fvoATRjuK4Dy2DsCKP0CcfeCoo/iZiuMIlGcFshJ1a80VPHJgaGiXmrIghDe l1FcnZoO1baFWAchnizyFSKfGXLwIO9y29MwE/Uw2uokprtWE8y1FdyN0Un38G+p54Q55Y5/ 7cOqAtkL1VVMcZYa90Ge9EGKKMeybwaAOJNHjXLUXsFakBNX6Io5nr4K8t7OXvfJAT1pM9lJ nITVsdv28vfEDlD9GIwfRwg1vwaXT4WS6oxtBV5pB/tLG5TL33MTebQFRriMekq+V3OLytZx 9yAuMjPxbHFxqiJW9k5XyPZ3BiEwhqbCROgKdLZ7unmLO5FrHX X-IronPort-AV: E=Sophos;i="5.84,254,1620705600"; d="scan'208";a="48706375" From: Martin Harvey To: CC: Martin Harvey , Martin Harvey Subject: [PATCH 4/6] Under conditions of high load and low resources, it was possible for NDIS (in combination with overlying drivers) to send NET_BUFFER_LIST structures containing NULL MDL's for transmission. This resulted in an immediate bugcheck. Date: Tue, 20 Jul 2021 14:29:49 +0100 Message-ID: <20210720132951.1776-4-Martin.Harvey@citrix.com> X-Mailer: git-send-email 2.25.0.windows.1 In-Reply-To: <20210720132951.1776-1-Martin.Harvey@citrix.com> References: <20210720132951.1776-1-Martin.Harvey@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain This patch contains the immediate proximate fix for this particular issue, instead failing the send with STATUS_INVALID_PARAMETER. Signed-off-by: Martin Harvey --- src/xenvif/transmitter.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/xenvif/transmitter.c b/src/xenvif/transmitter.c index 724615d..ea1282c 100644 --- a/src/xenvif/transmitter.c +++ b/src/xenvif/transmitter.c @@ -5148,13 +5148,17 @@ TransmitterQueuePacket( PXENVIF_TRANSMITTER_RING Ring; NTSTATUS status; + status = STATUS_INVALID_PARAMETER; + if (Mdl == NULL) + goto fail1; + Frontend = Transmitter->Frontend; Packet = __TransmitterGetPacket(Transmitter); status = STATUS_NO_MEMORY; if (Packet == NULL) - goto fail1; + goto fail2; Packet->Mdl = Mdl; Packet->Offset = Offset; @@ -5206,6 +5210,9 @@ TransmitterQueuePacket( return STATUS_SUCCESS; +fail2: + Error("fail2\n"); + fail1: Error("fail1 (%08x)\n", status); -- 2.25.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Tue Jul 20 13:30:28 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 20 Jul 2021 13:30:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.158738.292086 (Exim 4.92) (envelope-from ) id 1m5ppM-0000Hy-Sk; Tue, 20 Jul 2021 13:30:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 158738.292086; Tue, 20 Jul 2021 13:30:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5ppM-0000Ho-Of; Tue, 20 Jul 2021 13:30:28 +0000 Received: by outflank-mailman (input) for mailman id 158738; Tue, 20 Jul 2021 13:30:27 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5ppL-0000AM-HQ for win-pv-devel@lists.xenproject.org; Tue, 20 Jul 2021 13:30:27 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 29e80f9c-303e-4bcd-97a9-f491547b8c0e; Tue, 20 Jul 2021 13:30:18 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 29e80f9c-303e-4bcd-97a9-f491547b8c0e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626787818; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=CKcEAqv4DRrCDWslUF0cs26cchU3IE6X0b99d8TbCgA=; b=KIi6E5o2RbaZFK1RJEwxsnBdqqg0/WeTjjbvG/c3HTmBVQGZK/ATjwl2 ht8BKq47+flI4dgO+RZEYScXmJQTDC0vsZOaHySEjYD4xGOZWzKDxw7RX kg3QVfYYzErDmrKgg1dWzwke1tjyVPZJsmiD6j8UGOqwopDvy+STvaYM6 4=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: Kq2BaNtQe68iKhpUeZf9PLjSSYgBDVlhfbP4F8sA2z9+r2X3SlY8pYNkJuppOs1CQ+YqMbn8IR KWX+FlqFVR3KuosuSNP7iaNHGfmc8mMBGlaRwoEznHiIyvtAdOy6WjnmizMJf5dJh+QQUYwjRp FZk+O8a57LIkQLRp5bd+BTvE6WvysqnZNbGGnvqt1fBjZGeKuqQhfPmfj+T7xD9589+KIMKTkl F7jbG3IZTN7WYQgsRxAO64eNuru8/r35gCZ+z7GH+hShjwOqz5APOT31dGBVJUtbsKlxqVD7KZ XJyGl0KY+ua63aUjdBIvgBSC X-SBRS: 5.1 X-MesageID: 48706380 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:3AOg1K2V/7Fyv6aLERBePQqjBLwkLtp133Aq2lEZdPRUGvb4qy nIpoV96faUskdpZJhOo6HiBEDtexzhHP1OkO0s1NWZLWvbUQKTRekIh+aP/9SJIVyZygc378 ddmsZFZuEYdWIK6PrH3A== X-IronPort-AV: E=Sophos;i="5.84,254,1620705600"; d="scan'208";a="48706380" From: Martin Harvey To: CC: Martin Harvey , Martin Harvey Subject: [PATCH 1/6] In some cases, the frontend may stop processing Tx ring requests in a timely manner. If this happens at the same time as ring disable, then the Tx code could spin forever at dispatch IRQL. Date: Tue, 20 Jul 2021 14:29:46 +0100 Message-ID: <20210720132951.1776-1-Martin.Harvey@citrix.com> X-Mailer: git-send-email 2.25.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain This patch introduces a hard limit on how long the code will spin, allowing a device disable or power transition to complete, albeit at the cost of Tx requests being dropped or the ring being in an indeterminate state. This has normally been seen at guest shutdown where final ring state is of little consequence. Signed-off-by: Martin Harvey --- src/xenvif/transmitter.c | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/src/xenvif/transmitter.c b/src/xenvif/transmitter.c index f6935a6..e114061 100644 --- a/src/xenvif/transmitter.c +++ b/src/xenvif/transmitter.c @@ -3933,6 +3933,8 @@ __TransmitterRingDisable( XenbusState State; ULONG Attempt; NTSTATUS status; + BOOLEAN ToProcess; + BOOLEAN Abort; Transmitter = Ring->Transmitter; Frontend = Transmitter->Frontend; @@ -3985,24 +3987,31 @@ __TransmitterRingDisable( } Attempt = 0; + ToProcess = Ring->ResponsesProcessed != Ring->RequestsPushed; + Abort = ((Attempt >= 100) || (State != XenbusStateConnected)); + ASSERT3U(Ring->RequestsPushed, ==, Ring->RequestsPosted); - while (Ring->ResponsesProcessed != Ring->RequestsPushed) { + while (ToProcess && !Abort) { Attempt++; - ASSERT(Attempt < 100); + + KeStallExecutionProcessor(1000); // 1ms // Try to move things along __TransmitterRingSend(Ring); (VOID) TransmitterRingPoll(Ring); - if (State != XenbusStateConnected) - __TransmitterRingFakeResponses(Ring); - // We are waiting for a watch event at DISPATCH_LEVEL so // it is our responsibility to poll the store ring. XENBUS_STORE(Poll, &Transmitter->StoreInterface); - KeStallExecutionProcessor(1000); // 1ms + ToProcess = Ring->ResponsesProcessed != Ring->RequestsPushed; + Abort = ((Attempt >= 100) || (State != XenbusStateConnected)); + } + if (Abort) + { + __TransmitterRingFakeResponses(Ring); + (VOID) TransmitterRingPoll(Ring); } Ring->Enabled = FALSE; -- 2.25.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Tue Jul 20 13:30:28 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 20 Jul 2021 13:30:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.158739.292090 (Exim 4.92) (envelope-from ) id 1m5ppM-0000Ia-VA; Tue, 20 Jul 2021 13:30:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 158739.292090; Tue, 20 Jul 2021 13:30:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5ppM-0000IH-Q2; Tue, 20 Jul 2021 13:30:28 +0000 Received: by outflank-mailman (input) for mailman id 158739; Tue, 20 Jul 2021 13:30:27 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5ppL-0000CM-OC for win-pv-devel@lists.xenproject.org; Tue, 20 Jul 2021 13:30:27 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a2739c68-e95e-11eb-8b78-12813bfff9fa; Tue, 20 Jul 2021 13:30:22 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: a2739c68-e95e-11eb-8b78-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626787822; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=JroqkGuBaI5GhF3f5j7NdLyRNHU105NG89Gyr9uz0Ug=; b=MaCgebFox8lTeJl9DIX+TB3LAChLlr8UJ3Vs3vOY6xgavEAkxT67S1mq dP/i/btuRo4V0yF0bJ9hkOG+zBTSsa/fqeVvF/N5sXEPf7OBRmhEYXt8h PTK3ceWRBzAnXfCsnLOOu2VI13K+Lqmi2S5qsIeW31mlf2vlE6dhhnIX/ M=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: mm8JjpVwDYtz9rUbr6JvKiLGX8HWUTDhr33TMSYdJUfR6uLqSMsSY2U5oqpgGmHYtbpMoNGBSJ iv867KOYIpVEWy1y4mmAeDqeh+VR1c5yIG3HBbo9wqkS+k6OBa8hGOIBf14bIi9xguVTNXxAsa 0I1fwkGkA6Ud7qJRXCtf/+V7wxWfO5K/O6bf91HHLPaIIeLYjXWr86cPir40skUyaIIV5PQ68O S9j3RgSj9i4owR0iWCYEdFjMOSI9rgOvBJmWleF8hfb/s2xd7jItL7Mx0Wq80XGXhxwdm7VOO4 1wEiwZ9Mc+Y+MFnu0RJsYoO9 X-SBRS: 5.1 X-MesageID: 49037439 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:giGdhqxOOLY1VxNo2CmgKrPxXeskLtp133Aq2lEZdPUMSL3+qy iv9M516faGskd2ZJhAo6HwBEDuewK+yXcY2+Qs1PKZLW3bUQiTXfFfBOnZsl/d8kTFn4Y3v5 uIMZIObeEYZmIVsS+O2mmF+qEboeVvnprFuQ6U9QYVcegjUdAZ0y5pTgSAHgl/QxRHGpojCI DZ5s1JoVObCAsqR9X+BGMIG+DFut3VlIn7e1oHAAMq8wODlC6v8/r7FBefty1uLw9n0PMh62 SAmxHl7q+jt/291xDd0nLe9JRQlp/gzcZOH8aBk9USMXHtjQmvDb4RJoGqrXQ2uu3q40oukt 3BuQ0pMcho5HPVY22voRzinxPr2DFr8HP51VqE6EGT3/DRVXY5EcYEn45DbRfD600uurhHod h2NkyixuFqMS8= X-IronPort-AV: E=Sophos;i="5.84,254,1620705600"; d="scan'208";a="49037439" From: Martin Harvey To: CC: Martin Harvey , Martin Harvey Subject: [PATCH 2/6] Since Rx/Tx ring disconnects now no longer wait forever, we add some logging to catch those cases where the disconnect has timed out, indicating how many requests are still in the ring. This aids greatly with customer debugging. Date: Tue, 20 Jul 2021 14:29:47 +0100 Message-ID: <20210720132951.1776-2-Martin.Harvey@citrix.com> X-Mailer: git-send-email 2.25.0.windows.1 In-Reply-To: <20210720132951.1776-1-Martin.Harvey@citrix.com> References: <20210720132951.1776-1-Martin.Harvey@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Signed-Off-By: Martin Harvey --- src/xenvif/receiver.c | 16 ++++++++++++++++ src/xenvif/transmitter.c | 6 ++++++ 2 files changed, 22 insertions(+) diff --git a/src/xenvif/receiver.c b/src/xenvif/receiver.c index c70d938..7295646 100644 --- a/src/xenvif/receiver.c +++ b/src/xenvif/receiver.c @@ -2887,6 +2887,22 @@ __ReceiverRingDisconnect( ASSERT3U(Ring->ResponsesProcessed, ==, Ring->RequestsPushed); ASSERT3U(Ring->RequestsPushed, ==, Ring->RequestsPosted); + //Debug logs as well as assertion, else customer debugging difficult. + if ((Ring->ResponsesProcessed != Ring->RequestsPushed) || + (Ring->RequestsPushed != Ring->RequestsPosted)) + { + Info("%s[%u]: Ring disconnect, counts do not match.\n", + FrontendGetPath(Frontend), + Ring->Index); + + Info("%s[%u]: Processed: %u Pushed: %u Posted: %u\n", + FrontendGetPath(Frontend), + Ring->Index, + Ring->ResponsesProcessed, + Ring->RequestsPushed, + Ring->RequestsPosted); + } + Ring->ResponsesProcessed = 0; Ring->RequestsPushed = 0; Ring->RequestsPosted = 0; diff --git a/src/xenvif/transmitter.c b/src/xenvif/transmitter.c index e114061..724615d 100644 --- a/src/xenvif/transmitter.c +++ b/src/xenvif/transmitter.c @@ -4010,6 +4010,12 @@ __TransmitterRingDisable( } if (Abort) { + Info("%s[%u]: Timed out disable: Requests pushed: %u, Responses processed: %u.\n", + FrontendGetPath(Frontend), + Ring->Index, + Ring->RequestsPushed, + Ring->ResponsesProcessed); + __TransmitterRingFakeResponses(Ring); (VOID) TransmitterRingPoll(Ring); } -- 2.25.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Tue Jul 20 14:53:35 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 20 Jul 2021 14:53:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.158805.292160 (Exim 4.92) (envelope-from ) id 1m5r7l-0003Cn-E3; Tue, 20 Jul 2021 14:53:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 158805.292160; Tue, 20 Jul 2021 14:53:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5r7l-0003Cf-Ay; Tue, 20 Jul 2021 14:53:33 +0000 Received: by outflank-mailman (input) for mailman id 158805; Tue, 20 Jul 2021 14:53:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5r7j-0003CZ-TE for win-pv-devel@lists.xenproject.org; Tue, 20 Jul 2021 14:53:31 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 660e7691-f5ba-4083-82f0-86626da72488; Tue, 20 Jul 2021 14:53:31 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 660e7691-f5ba-4083-82f0-86626da72488 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626792810; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=z17eMqNLgtcFELkqHb60ZjCVCnbOSWo1W4eMFqgPf6Q=; b=gIAd+T3c8X0aMF7vheOioqq5/O/zBUfKb0O7DIbY8ZKoBtBpuHF6x5/Q gVmNssBYYeHNzyYGKQA8EGj5npdYnLIkSj13/q7DjeUJzflIDLse5uxVZ 27/KqxfycLghbJDlBdIwK1zZ93bR6WzxbQ/7joJNkU6YUkc5Vl2UrnbOW Q=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: PvxUPjLtU72CH6KoI+5NI1GXxGp+PQWjUjsNVUB5MHroFkmKTeaBVLTjVdH3WdMz9gH3A3gsSU yECh1HvKqY/W6eGS7GQfpnoIJKpuTtCDG7j5lODaMaF/ZJvEii6vzPk0ygZFaRhhpAj3sq/8uz asYs9eiUOSfP14wtGUNXlOuFpQagpKT6c2w4EQ3TQFxBwhvjaxyt9Bgch8OIIGPGGRxWlZjjYr xm50RQoR1CAe+l3Wy0e0eyQO82TwFRM46gtKaQ+4INacE/g1q8Q9OzX6nk0pYb6Zk6qi5xHm+B PZwnlZzO/U1kkJaUdeiaxCkl X-SBRS: 5.1 X-MesageID: 48355145 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:lUMF4K/ptNc03VqSyDxuk+DHI+orL9Y04lQ7vn2ZKCY6TiX2ra CTdZggviMc6wx/ZJhDo7290cC7KBvhHPVOjbX5U43JYCDW/EGvK5xr55an4zCIIUzDytI= X-IronPort-AV: E=Sophos;i="5.84,255,1620705600"; d="scan'208";a="48355145" From: Martin Harvey To: CC: Martin Harvey , Martin Harvey Subject: [PATCH 3/6] In addition to preceding changes to ring disconnects, and associated logging, we also add some logging to check whether state change notifications are being sent in a timely manner between frontend and backend. Also a great assistance to customer debugging. Date: Tue, 20 Jul 2021 14:29:48 +0100 Message-ID: <20210720132951.1776-3-Martin.Harvey@citrix.com> X-Mailer: git-send-email 2.25.0.windows.1 In-Reply-To: <20210720132951.1776-1-Martin.Harvey@citrix.com> References: <20210720132951.1776-1-Martin.Harvey@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Signed-off-by: Martin Harvey --- src/xenvif/frontend.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/xenvif/frontend.c b/src/xenvif/frontend.c index 5940e16..c27b2cd 100644 --- a/src/xenvif/frontend.c +++ b/src/xenvif/frontend.c @@ -1346,6 +1346,7 @@ FrontendWaitForBackendXenbusStateChange( LARGE_INTEGER Timeout; XenbusState Old = *State; NTSTATUS status; + const ULONGLONG TimeoutDelta = 120000; Trace("%s: ====> %s\n", __FrontendGetBackendPath(Frontend), @@ -1369,7 +1370,7 @@ FrontendWaitForBackendXenbusStateChange( Timeout.QuadPart = 0; - while (*State == Old && TimeDelta < 120000) { + while (*State == Old && TimeDelta < TimeoutDelta) { PCHAR Buffer; LARGE_INTEGER Now; @@ -1417,6 +1418,10 @@ FrontendWaitForBackendXenbusStateChange( TimeDelta = (Now.QuadPart - Start.QuadPart) / 10000ull; } + if (TimeDelta >= TimeoutDelta) { + Error("%s timed out.\n", __FrontendGetBackendPath(Frontend)); + } + if (Watch != NULL) (VOID) XENBUS_STORE(WatchRemove, &Frontend->StoreInterface, -- 2.25.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Wed Jul 21 17:08:44 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 21 Jul 2021 17:08:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.159463.293334 (Exim 4.92) (envelope-from ) id 1m6Fi5-00067a-OJ; Wed, 21 Jul 2021 17:08:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 159463.293334; Wed, 21 Jul 2021 17:08:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6Fi5-00067T-LF; Wed, 21 Jul 2021 17:08:41 +0000 Received: by outflank-mailman (input) for mailman id 159463; Wed, 21 Jul 2021 17:08:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6Fi4-00067N-Kk for win-pv-devel@lists.xenproject.org; Wed, 21 Jul 2021 17:08:40 +0000 Received: from mail-wm1-x330.google.com (unknown [2a00:1450:4864:20::330]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1d1f0842-548d-4377-9c71-c810eba695ec; Wed, 21 Jul 2021 17:08:39 +0000 (UTC) Received: by mail-wm1-x330.google.com with SMTP id g12so1755081wme.2 for ; Wed, 21 Jul 2021 10:08:39 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:d056:9219:797d:dc70? ([2a00:23c5:5785:9a01:d056:9219:797d:dc70]) by smtp.gmail.com with ESMTPSA id q17sm21449768wrv.47.2021.07.21.10.08.38 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jul 2021 10:08:38 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 1d1f0842-548d-4377-9c71-c810eba695ec DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5q+mtrrUyft7XCNvVDvbnDmkFXx2UFa13+5dOm+LstM=; b=IByGskFcBah0dc7Q7sGXnRLX4EpD5dvwrRbcvkdX3fY0rnqzsFjOeqHP/jCvK88CB7 5vUgtdtxi7AIS6njMbCq7p+VIgP+m7mOosC0CDb7tmoXKLkQXuGVbCpb857bLwd5IBLg HkdKAjBw4KnbLpUoO5KlImABuuJIBMiTNEUIKdvZ/MKFl3hzLsH5Iz+esypPz9Oxq0a5 oLmX4bENEpmz2zf7nLan2oGxEfESxCZ077YCypNBOgu2fU/TTjVkeGkL4PKv8h0vxenH Z4pkkB7XTX86xyEGXxCHf/NV2lIHl0UYVnNZ50RBxbPm7GDnUAgcJJOpobN4k7Idv6nr 0Uyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5q+mtrrUyft7XCNvVDvbnDmkFXx2UFa13+5dOm+LstM=; b=AaKOQ5amW62Xkd9B2fjh8kqaedBigYB6JbqLmG7RM3sp0ei0h6ELJXfgQ7pS3pfarW 1aUsPDqq7J5/pAF+zYrkC7bNc84ASF0cNhpOEiVtuQzIX2ZOme/lEOw/bvaqMHrzLngk 3EpTvYJZQiaHzM6424G4ADlfVYdvo4NHfagMMeqyqQGrbymqvplc36baqAdD3uDh4j6W DVLBFgJKQ/QVu/n34yhkDjfTQ5rkScCSh/kjA0erLo2sJulLu6mrLVZZGVvwDfeyH5BP yIDtLabNtX7RldRSLhmWZhu+4HbfL1xiu5kHeBhTWCVQYEhE1M98qhLeUhdwkadZHGLl 6pkw== X-Gm-Message-State: AOAM531NpyH9SvsXe4CZFnyEloMt9IJPOyDNKE6zieQus/rXIuQfg6YJ rLxie1ClatRTPBB1k7BNwGdgyBFfB8M= X-Google-Smtp-Source: ABdhPJyzuXhpFrXx7FeRXVNqYmpeijgF7mPnA4Ef2OJ8WiFiRFV2gVZuvL1iJVLMSLcvChmxTqp+Sw== X-Received: by 2002:a1c:a9c6:: with SMTP id s189mr33851979wme.143.1626887318675; Wed, 21 Jul 2021 10:08:38 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 1/6] In some cases, the frontend may stop processing Tx ring requests in a timely manner. If this happens at the same time as ring disable, then the Tx code could spin forever at dispatch IRQL. To: win-pv-devel@lists.xenproject.org References: <20210720132951.1776-1-Martin.Harvey@citrix.com> Message-ID: Date: Wed, 21 Jul 2021 18:08:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210720132951.1776-1-Martin.Harvey@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit I assume you mean 'backend' rather than 'frontend' here? On 20/07/2021 14:29, Martin Harvey wrote: > This patch introduces a hard limit on how long the code will spin, > allowing a device disable or power transition to complete, albeit > at the cost of Tx requests being dropped or the ring being in > an indeterminate state. This has normally been seen at guest shutdown > where final ring state is of little consequence. > > Signed-off-by: Martin Harvey > --- > src/xenvif/transmitter.c | 21 +++++++++++++++------ > 1 file changed, 15 insertions(+), 6 deletions(-) > > diff --git a/src/xenvif/transmitter.c b/src/xenvif/transmitter.c > index f6935a6..e114061 100644 > --- a/src/xenvif/transmitter.c > +++ b/src/xenvif/transmitter.c > @@ -3933,6 +3933,8 @@ __TransmitterRingDisable( > XenbusState State; > ULONG Attempt; > NTSTATUS status; > + BOOLEAN ToProcess; > + BOOLEAN Abort; > > Transmitter = Ring->Transmitter; > Frontend = Transmitter->Frontend; > @@ -3985,24 +3987,31 @@ __TransmitterRingDisable( > } > > Attempt = 0; > + ToProcess = Ring->ResponsesProcessed != Ring->RequestsPushed; > + Abort = ((Attempt >= 100) || (State != XenbusStateConnected)); > + > ASSERT3U(Ring->RequestsPushed, ==, Ring->RequestsPosted); > - while (Ring->ResponsesProcessed != Ring->RequestsPushed) { Why not leave this clause alone, and simply add '&& !Abort' after having set it FALSE above? I.e. why do we need the 'ToProcess' boolean? > + while (ToProcess && !Abort) { > Attempt++; > - ASSERT(Attempt < 100); > + > + KeStallExecutionProcessor(1000); // 1ms > > // Try to move things along > __TransmitterRingSend(Ring); > (VOID) TransmitterRingPoll(Ring); > > - if (State != XenbusStateConnected) > - __TransmitterRingFakeResponses(Ring); Actually, do we even need 'Abort'? Could you not just break here... > - > // We are waiting for a watch event at DISPATCH_LEVEL so > // it is our responsibility to poll the store ring. > XENBUS_STORE(Poll, > &Transmitter->StoreInterface); > > - KeStallExecutionProcessor(1000); // 1ms > + ToProcess = Ring->ResponsesProcessed != Ring->RequestsPushed; > + Abort = ((Attempt >= 100) || (State != XenbusStateConnected)); > + } > + if (Abort) ... and then check if Ring->ResponsesProcessed != Ring->RequestsPushed here (and fake responses accordingly if need be)? > + { > + __TransmitterRingFakeResponses(Ring); > + (VOID) TransmitterRingPoll(Ring); > } > > Ring->Enabled = FALSE; > From win-pv-devel-bounces@lists.xenproject.org Wed Jul 21 17:08:49 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 21 Jul 2021 17:08:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.159464.293338 (Exim 4.92) (envelope-from ) id 1m6FiD-00069k-QE; Wed, 21 Jul 2021 17:08:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 159464.293338; Wed, 21 Jul 2021 17:08:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6FiD-00069c-Mv; Wed, 21 Jul 2021 17:08:49 +0000 Received: by outflank-mailman (input) for mailman id 159464; Wed, 21 Jul 2021 17:08:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6FiC-00069W-Uc for win-pv-devel@lists.xenproject.org; Wed, 21 Jul 2021 17:08:48 +0000 Received: from mail-wm1-x331.google.com (unknown [2a00:1450:4864:20::331]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7930c54a-f9d7-44d9-8cab-2568d034d9ff; Wed, 21 Jul 2021 17:08:48 +0000 (UTC) Received: by mail-wm1-x331.google.com with SMTP id m11-20020a05600c3b0bb0290228f19cb433so3871082wms.0 for ; Wed, 21 Jul 2021 10:08:48 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:d056:9219:797d:dc70? ([2a00:23c5:5785:9a01:d056:9219:797d:dc70]) by smtp.gmail.com with ESMTPSA id d10sm27175680wro.43.2021.07.21.10.08.46 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jul 2021 10:08:47 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 7930c54a-f9d7-44d9-8cab-2568d034d9ff DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5q+mtrrUyft7XCNvVDvbnDmkFXx2UFa13+5dOm+LstM=; b=auVuZs/dA/WR5nv+K7xKtAENylk3ISgezN1wdQc7yt4fMaVDbdLCUsPc78uIsHMFSE nCLlUk/qP6AOeCJV1pz/IRE/ll+OhyfbJCBYb0oPW7Kyv/xcijFtdK9tyKBYVCru8Mnx +3rt94NuGWTfHg0bwsXW8ckc5zUoCu7gsc8DLlbx7lEbxHv3toqBJhRixJEJd83KO1EF 3JqotO5UKTANL5g6+P5qkCFBlUhi6HSeU5LLB5XTGavNosbsQF7b5W7wIfNhDUPqMD5Z 8HihRLrazyqTmOaoiSbom2klVzj/N/j0jqFRTI7NMseCzNSsItU8E8/YGD/ZX/qmRGck kOJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5q+mtrrUyft7XCNvVDvbnDmkFXx2UFa13+5dOm+LstM=; b=o5t7URyDVHJp7vLr/S42icXtopocNxZ0OGfgLaIryoc1rAkniT3eRKe6VQ/me/pHMQ 12TD5ceAvapKg8zNzyYYxIGVwPKyIx8NM7TOcZSFCsDc2Cz78D0+xfjCa9MxewEnuQr3 Fdd16acCbKNpfxiGmp8Bg9MBm4sO+t12Krg32BUETxqsJqCm4jKKafEEv+5Tm1vAZdoP wcUcozubfNntv/EOk+1+mOjiESOVvzS3+3n4fO4ZAEpy233r2hkhMyO/Nu10bbHcJ06t 1hh0UrbQBP0MJjL6Wzupz3Nkrk8K1Sq7dvNbta0EeikA7arml6MfLt7nRZI+DVXAAZSn d/lA== X-Gm-Message-State: AOAM532DoSiwozx2Y9Qq6kirg41xKssF3pwpyeDjrq23BcfYTC31nOna OLRkWguiSkDPOBkLmPuDEhFkC/CjALQ= X-Google-Smtp-Source: ABdhPJzRmvazqIxkrGAecJMgoJm0pR98ckHV98cF1h0PjnlBp2lm4lT48myFBLnvrr13GfLx1Zdyow== X-Received: by 2002:a1c:5985:: with SMTP id n127mr37804521wmb.75.1626887327318; Wed, 21 Jul 2021 10:08:47 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 1/6] In some cases, the frontend may stop processing Tx ring requests in a timely manner. If this happens at the same time as ring disable, then the Tx code could spin forever at dispatch IRQL. To: win-pv-devel@lists.xenproject.org References: <20210720132951.1776-1-Martin.Harvey@citrix.com> Message-ID: <2163a8f7-d0d9-648b-261c-14dd48bc86d7@xen.org> Date: Wed, 21 Jul 2021 18:08:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210720132951.1776-1-Martin.Harvey@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit I assume you mean 'backend' rather than 'frontend' here? On 20/07/2021 14:29, Martin Harvey wrote: > This patch introduces a hard limit on how long the code will spin, > allowing a device disable or power transition to complete, albeit > at the cost of Tx requests being dropped or the ring being in > an indeterminate state. This has normally been seen at guest shutdown > where final ring state is of little consequence. > > Signed-off-by: Martin Harvey > --- > src/xenvif/transmitter.c | 21 +++++++++++++++------ > 1 file changed, 15 insertions(+), 6 deletions(-) > > diff --git a/src/xenvif/transmitter.c b/src/xenvif/transmitter.c > index f6935a6..e114061 100644 > --- a/src/xenvif/transmitter.c > +++ b/src/xenvif/transmitter.c > @@ -3933,6 +3933,8 @@ __TransmitterRingDisable( > XenbusState State; > ULONG Attempt; > NTSTATUS status; > + BOOLEAN ToProcess; > + BOOLEAN Abort; > > Transmitter = Ring->Transmitter; > Frontend = Transmitter->Frontend; > @@ -3985,24 +3987,31 @@ __TransmitterRingDisable( > } > > Attempt = 0; > + ToProcess = Ring->ResponsesProcessed != Ring->RequestsPushed; > + Abort = ((Attempt >= 100) || (State != XenbusStateConnected)); > + > ASSERT3U(Ring->RequestsPushed, ==, Ring->RequestsPosted); > - while (Ring->ResponsesProcessed != Ring->RequestsPushed) { Why not leave this clause alone, and simply add '&& !Abort' after having set it FALSE above? I.e. why do we need the 'ToProcess' boolean? > + while (ToProcess && !Abort) { > Attempt++; > - ASSERT(Attempt < 100); > + > + KeStallExecutionProcessor(1000); // 1ms > > // Try to move things along > __TransmitterRingSend(Ring); > (VOID) TransmitterRingPoll(Ring); > > - if (State != XenbusStateConnected) > - __TransmitterRingFakeResponses(Ring); Actually, do we even need 'Abort'? Could you not just break here... > - > // We are waiting for a watch event at DISPATCH_LEVEL so > // it is our responsibility to poll the store ring. > XENBUS_STORE(Poll, > &Transmitter->StoreInterface); > > - KeStallExecutionProcessor(1000); // 1ms > + ToProcess = Ring->ResponsesProcessed != Ring->RequestsPushed; > + Abort = ((Attempt >= 100) || (State != XenbusStateConnected)); > + } > + if (Abort) ... and then check if Ring->ResponsesProcessed != Ring->RequestsPushed here (and fake responses accordingly if need be)? > + { > + __TransmitterRingFakeResponses(Ring); > + (VOID) TransmitterRingPoll(Ring); > } > > Ring->Enabled = FALSE; > From win-pv-devel-bounces@lists.xenproject.org Wed Jul 21 17:11:41 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 21 Jul 2021 17:11:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.159477.293341 (Exim 4.92) (envelope-from ) id 1m6Fkz-0006zF-1Y; Wed, 21 Jul 2021 17:11:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 159477.293341; Wed, 21 Jul 2021 17:11:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6Fky-0006z8-V0; Wed, 21 Jul 2021 17:11:40 +0000 Received: by outflank-mailman (input) for mailman id 159477; Wed, 21 Jul 2021 17:11:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6Fkx-0006z2-GU for win-pv-devel@lists.xenproject.org; Wed, 21 Jul 2021 17:11:39 +0000 Received: from mail-wr1-x431.google.com (unknown [2a00:1450:4864:20::431]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f3696d35-c146-4bce-920c-1741057ad613; Wed, 21 Jul 2021 17:11:38 +0000 (UTC) Received: by mail-wr1-x431.google.com with SMTP id k4so2970934wrc.8 for ; Wed, 21 Jul 2021 10:11:38 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:d056:9219:797d:dc70? ([2a00:23c5:5785:9a01:d056:9219:797d:dc70]) by smtp.gmail.com with ESMTPSA id c2sm27255466wrs.60.2021.07.21.10.11.37 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jul 2021 10:11:37 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: f3696d35-c146-4bce-920c-1741057ad613 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=D46oGW4yWnds86DJaYevGSorAT6eoMMflfqWU+Im5Es=; b=e0UeIGqObH9rrqIk5UvJTmSvSElNbq5tYleKpdJ4xusiQ5npTPOOaNyboiwXVKSCwt aiRTvkVtBA317irwWJBdqkfn14O5WcMzBAHVZW247cUUhlUcJU8NAdid10fEUeDVrd3R YKn0s5IpZxiKvFs2SqxQtn13/li67DGwHKl/uhNuVdY5fFkmU0XaYxudOl+OWQPtIMfe zHNOxm/BMqAdkv9wfRXqo+JZ8q4DRYqxMjsClODgClW/9cUZoJ5a/lMBu0+rAqHf5EzC lHioKEtrrw/PEXLPstbJzSrWxPM2s4Fa3vdW2nf2emzLu1zcztnd7YWBvywNCO42ES0z 6jbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=D46oGW4yWnds86DJaYevGSorAT6eoMMflfqWU+Im5Es=; b=m60nkndOoTimppl17S9L9KI4VsUeoultENFdnDchUHO7PEXPTujPmsjTI8rNgtsXoA kbqFPCHv3ho5oWaM2NBRRzv6kQa/sBzecu6LZikOL9TmowHY75/Fio6Ccj0PGC+PEQFm O4MYAoztmn7aBNPxuDA4/Q5jT8SbMCU0EGvY7TF5BqfBeRqaxN7VaR5UC8p+wLvFQ9q9 lMagR1+/P3QKegU2iqkuUYjNCVBGHQx6Jxo8ic0lOApiTXh3daqCHiKcsMe9YoGPy8gP wXzuXzzsz7a+XEaJWMNEGi9/2KVjNT1s6mQuO1VWTV94bGR2KqFKBOm0qqZsQqxOWd5q Oz+g== X-Gm-Message-State: AOAM530mxjMPaH6f+gTGhvXljgqnKWhFWC366YIMs28960pr8I08jIZH noqnjaFa+hnKfkqdPs1pQU1RblFsApk= X-Google-Smtp-Source: ABdhPJxP1umbG7V5WRbSQ7PvP2Kxbqo6OJ3tGH9drn2imdfyCuGxOMC8Q9qtKBQ1lJLzm+k5OLchGA== X-Received: by 2002:adf:f4ca:: with SMTP id h10mr24714192wrp.3.1626887497851; Wed, 21 Jul 2021 10:11:37 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 2/6] Since Rx/Tx ring disconnects now no longer wait forever, we add some logging to catch those cases where the disconnect has timed out, indicating how many requests are still in the ring. This aids greatly with customer debugging. To: win-pv-devel@lists.xenproject.org References: <20210720132951.1776-1-Martin.Harvey@citrix.com> <20210720132951.1776-2-Martin.Harvey@citrix.com> Message-ID: <11b1c340-6460-7c17-bf42-6ea624f1bd3f@xen.org> Date: Wed, 21 Jul 2021 18:11:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210720132951.1776-2-Martin.Harvey@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 20/07/2021 14:29, Martin Harvey wrote: > Signed-Off-By: Martin Harvey > --- > src/xenvif/receiver.c | 16 ++++++++++++++++ > src/xenvif/transmitter.c | 6 ++++++ > 2 files changed, 22 insertions(+) > > diff --git a/src/xenvif/receiver.c b/src/xenvif/receiver.c > index c70d938..7295646 100644 > --- a/src/xenvif/receiver.c > +++ b/src/xenvif/receiver.c > @@ -2887,6 +2887,22 @@ __ReceiverRingDisconnect( > ASSERT3U(Ring->ResponsesProcessed, ==, Ring->RequestsPushed); > ASSERT3U(Ring->RequestsPushed, ==, Ring->RequestsPosted); > > + //Debug logs as well as assertion, else customer debugging difficult. > + if ((Ring->ResponsesProcessed != Ring->RequestsPushed) || > + (Ring->RequestsPushed != Ring->RequestsPosted)) > + { > + Info("%s[%u]: Ring disconnect, counts do not match.\n", > + FrontendGetPath(Frontend), > + Ring->Index); > + > + Info("%s[%u]: Processed: %u Pushed: %u Posted: %u\n", > + FrontendGetPath(Frontend), > + Ring->Index, > + Ring->ResponsesProcessed, > + Ring->RequestsPushed, > + Ring->RequestsPosted); > + } > + > Ring->ResponsesProcessed = 0; > Ring->RequestsPushed = 0; > Ring->RequestsPosted = 0; > diff --git a/src/xenvif/transmitter.c b/src/xenvif/transmitter.c > index e114061..724615d 100644 > --- a/src/xenvif/transmitter.c > +++ b/src/xenvif/transmitter.c > @@ -4010,6 +4010,12 @@ __TransmitterRingDisable( > } > if (Abort) > { > + Info("%s[%u]: Timed out disable: Requests pushed: %u, Responses processed: %u.\n", > + FrontendGetPath(Frontend), > + Ring->Index, > + Ring->RequestsPushed, > + Ring->ResponsesProcessed); > + Did you consider triggering a debug dump (at least of the transmitter) rather than adding more ad-hoc logging? Paul > __TransmitterRingFakeResponses(Ring); > (VOID) TransmitterRingPoll(Ring); > } > From win-pv-devel-bounces@lists.xenproject.org Wed Jul 21 17:17:38 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 21 Jul 2021 17:17:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.159484.293346 (Exim 4.92) (envelope-from ) id 1m6Fqj-0007Me-HN; Wed, 21 Jul 2021 17:17:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 159484.293346; Wed, 21 Jul 2021 17:17:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6Fqj-0007MW-EC; Wed, 21 Jul 2021 17:17:37 +0000 Received: by outflank-mailman (input) for mailman id 159484; Wed, 21 Jul 2021 17:17:36 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6Fqi-0007MQ-BM for win-pv-devel@lists.xenproject.org; Wed, 21 Jul 2021 17:17:36 +0000 Received: from mail-wm1-x32c.google.com (unknown [2a00:1450:4864:20::32c]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b61e3fb0-d9c1-4145-b38c-5f82bf85d1a8; Wed, 21 Jul 2021 17:17:35 +0000 (UTC) Received: by mail-wm1-x32c.google.com with SMTP id q18-20020a1ce9120000b02901f259f3a250so1402857wmc.2 for ; Wed, 21 Jul 2021 10:17:35 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:d056:9219:797d:dc70? ([2a00:23c5:5785:9a01:d056:9219:797d:dc70]) by smtp.gmail.com with ESMTPSA id p12sm474426wma.19.2021.07.21.10.17.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jul 2021 10:17:34 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: b61e3fb0-d9c1-4145-b38c-5f82bf85d1a8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=23aGT5Gmhf8M/VT9MiRjTnO7QCsvV9qON6kyAAfLKOY=; b=CnD/2ypg0IYMFMQ/VN69wOdDhp0Zh3Cvud3r+3HFea5d79DyVhOBMe3YHW1qq6s9iz P2VyXoONrts6h/sd0IQb9JFKweuF8exK7SyrUPRkQ5SlizAV95oQPqror/tsK8hlSQSB zw2AHcFKUbQaOQhFSOYot3fimSgAaj8uLRnwAMMO/UcDxw0iZ5aCUxa1R/ZlaNeAa7e/ VVIuvogEQdRTAtKEwpp2zYVJi1HUCEykYPI03ML99ujCaB3sFaNdurML0+STm8vmq28F BJWTveIutX5xP9Wt5x6sZpxKDOg2Ka3dOGW9MgCbTeyC6CQtZQDEkvv2G/BnxTJytw6W slgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=23aGT5Gmhf8M/VT9MiRjTnO7QCsvV9qON6kyAAfLKOY=; b=VF9cAeAfs3DK7vt/uW3x5jCCURaQ7tEzaSPao4ZEz31YNGaxXB/SRnNw8JB4c4yPpo i1A+CVv8bBss+uqXuv2pZpiu7ayjJv6KK51X/6T93v0jDme0hCg2+jbHH5ylAL3ZhXEX 68pPvBPL3vlEkkPZIPWIkJraJ28JXqF+PZCPQvJZu2NroUwx/9q6FQmPuvA6VQkXWImM dtMcK6vvHuLS6JC9+d2relHSwVdrzyWGST3mpA13K+hIFuNdaPGLxveQaq9aT6rtxioE sHuMWVkv7BX7YSJui/NiRiHlbHaR8dktPqf7NeJA6WybDpp3gNE6oK37Z9q5xbH+/r7S KAOQ== X-Gm-Message-State: AOAM531seGBzuoWHimnhOBHCpORPQUMbQVSJ7wyioGxYJM7Ws/hf95uj x0xTNcmsn2101i1QSiVM47UdMbX61BA= X-Google-Smtp-Source: ABdhPJw7wpPeL+uZEhvgYOsc19eVkXY5C3MMvH/0qtG5xhNvrcpbFK/3furjOwYUjR2eRJ2lA3YkhQ== X-Received: by 2002:a05:600c:1c93:: with SMTP id k19mr38981956wms.125.1626887854544; Wed, 21 Jul 2021 10:17:34 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 3/6] In addition to preceding changes to ring disconnects, and associated logging, we also add some logging to check whether state change notifications are being sent in a timely manner between frontend and backend. Also a great assistance to customer debugging. To: win-pv-devel@lists.xenproject.org References: <20210720132951.1776-1-Martin.Harvey@citrix.com> <20210720132951.1776-3-Martin.Harvey@citrix.com> Message-ID: <1a20d9c4-af43-f4eb-74ad-18277d991d76@xen.org> Date: Wed, 21 Jul 2021 18:17:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210720132951.1776-3-Martin.Harvey@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 20/07/2021 14:29, Martin Harvey wrote: > Signed-off-by: Martin Harvey > --- > src/xenvif/frontend.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/src/xenvif/frontend.c b/src/xenvif/frontend.c > index 5940e16..c27b2cd 100644 > --- a/src/xenvif/frontend.c > +++ b/src/xenvif/frontend.c > @@ -1346,6 +1346,7 @@ FrontendWaitForBackendXenbusStateChange( > LARGE_INTEGER Timeout; > XenbusState Old = *State; > NTSTATUS status; > + const ULONGLONG TimeoutDelta = 120000; NIT: I don't think you really need 'Delta' in the name, just 'Timeout' would suffice (and I think it would be more consistent with other code). > > Trace("%s: ====> %s\n", > __FrontendGetBackendPath(Frontend), > @@ -1369,7 +1370,7 @@ FrontendWaitForBackendXenbusStateChange( > > Timeout.QuadPart = 0; > > - while (*State == Old && TimeDelta < 120000) { > + while (*State == Old && TimeDelta < TimeoutDelta) { > PCHAR Buffer; > LARGE_INTEGER Now; > > @@ -1417,6 +1418,10 @@ FrontendWaitForBackendXenbusStateChange( > TimeDelta = (Now.QuadPart - Start.QuadPart) / 10000ull; > } > > + if (TimeDelta >= TimeoutDelta) { > + Error("%s timed out.\n", __FrontendGetBackendPath(Frontend)); > + } No need for braces on single-line ifs and no full stop needed in the log message. Since it's not in context and I can't remember... does the path include the actual 'state' key name? It's a lack of change in that particular key we're triggering on here. Paul > + > if (Watch != NULL) > (VOID) XENBUS_STORE(WatchRemove, > &Frontend->StoreInterface, > From win-pv-devel-bounces@lists.xenproject.org Wed Jul 21 17:20:20 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 21 Jul 2021 17:20:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.159491.293350 (Exim 4.92) (envelope-from ) id 1m6FtM-0008CR-PF; Wed, 21 Jul 2021 17:20:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 159491.293350; Wed, 21 Jul 2021 17:20:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6FtM-0008CI-Ly; Wed, 21 Jul 2021 17:20:20 +0000 Received: by outflank-mailman (input) for mailman id 159491; Wed, 21 Jul 2021 17:20:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6FtL-0008CC-Vp for win-pv-devel@lists.xenproject.org; Wed, 21 Jul 2021 17:20:20 +0000 Received: from mail-wm1-x32d.google.com (unknown [2a00:1450:4864:20::32d]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 198f4a5c-0a87-44fd-8f30-310b9154060b; Wed, 21 Jul 2021 17:20:19 +0000 (UTC) Received: by mail-wm1-x32d.google.com with SMTP id w13so1767465wmc.3 for ; Wed, 21 Jul 2021 10:20:19 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:d056:9219:797d:dc70? ([2a00:23c5:5785:9a01:d056:9219:797d:dc70]) by smtp.gmail.com with ESMTPSA id f82sm462350wmf.25.2021.07.21.10.20.17 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jul 2021 10:20:18 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 198f4a5c-0a87-44fd-8f30-310b9154060b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fJeC9QNcgfkYuUrrkMFuspg7HLQ8NnmGkNWzn2xgSx0=; b=MVMetYX6HXZdiT0EAq0u/H5yJFn0OW+qDhUOrLaDXd3Lu/vJo2BbDNLCEK343deeUw G1xWEz/O1wDm1Ko9u5T76reRNantrA9vAozUwvzIQrdw+ThOgfN7Mnp205vKAIxLedA9 F5L6v1muylXg1DzB/9oRXYWiDSTUT/bHmgJqY86waQ9kfCdahrtQiPH8uuWiQgr1G9BL hmi/4xN4yuX3qB4Ze0ZFkruIo5eCsgni6Gha4MeXW/5E5oAlSK8mYkJjyOS8mVEP9ia9 YnNy9Rg3ymNxg6jdndQT+qFsyD4JiWhM7TfDl72I2MIjlhRkALYEYkI2WgZEm3mYlRxf jHyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fJeC9QNcgfkYuUrrkMFuspg7HLQ8NnmGkNWzn2xgSx0=; b=BcedD7iiTU5ojcoXxe7TmdXzHgbmXopzGKG2Ux94yt4d7ZbwVadtNmsSBI2ujW5yHk ERtn5zCN2fE3HuI5uGKhAhImMjZQn3aTymSyYBTv1RaD3YWYbq4FhFDveoZ/9+ZTYEeg q2YxrfK+sVf6KV1zTyLee49HpuF6/BEksKy6XR2rYoSY2EbgWfPeD3EjDU//vH6MbAPG Z/osxq6/GgcHqTgGXdfh1hD15qjH3Ik4pe/DeKE1rMk7PZTwNHJI6rWKrle7JRVlFcw/ 37dSEWGEl+dlL7aVgTL4GrZH6pEQsAuZscRNdJaq3ux+w7p9bkuZcs7ydx+QCU9RLdH1 E63w== X-Gm-Message-State: AOAM530YNYjBihhd2ktX9/AMQHV/bzHC493WMMoo2OvjsjvLP/lX7NvM GV/nmlPahAL5WnUDbH2D+j/J1u5xfCs= X-Google-Smtp-Source: ABdhPJx9V0XrafjBO24Lm9ygg1l7VpEgMS+0wdBASBXK0xx/TDgo2bGJGAkEFgcFYawq5kABjtlWMw== X-Received: by 2002:a1c:4b0b:: with SMTP id y11mr3572757wma.109.1626888018467; Wed, 21 Jul 2021 10:20:18 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 4/6] Under conditions of high load and low resources, it was possible for NDIS (in combination with overlying drivers) to send NET_BUFFER_LIST structures containing NULL MDL's for transmission. This resulted in an immediate bugcheck. To: win-pv-devel@lists.xenproject.org References: <20210720132951.1776-1-Martin.Harvey@citrix.com> <20210720132951.1776-4-Martin.Harvey@citrix.com> Message-ID: <8ebbb971-ca94-fd97-5530-76cfd54d6a25@xen.org> Date: Wed, 21 Jul 2021 18:20:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210720132951.1776-4-Martin.Harvey@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Coping with NDIS is XENNET's responsibility. Any remedial action should be taken there, not here. Paul On 20/07/2021 14:29, Martin Harvey wrote: > This patch contains the immediate proximate fix for this particular > issue, instead failing the send with STATUS_INVALID_PARAMETER. > > Signed-off-by: Martin Harvey > --- > src/xenvif/transmitter.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/src/xenvif/transmitter.c b/src/xenvif/transmitter.c > index 724615d..ea1282c 100644 > --- a/src/xenvif/transmitter.c > +++ b/src/xenvif/transmitter.c > @@ -5148,13 +5148,17 @@ TransmitterQueuePacket( > PXENVIF_TRANSMITTER_RING Ring; > NTSTATUS status; > > + status = STATUS_INVALID_PARAMETER; > + if (Mdl == NULL) > + goto fail1; > + > Frontend = Transmitter->Frontend; > > Packet = __TransmitterGetPacket(Transmitter); > > status = STATUS_NO_MEMORY; > if (Packet == NULL) > - goto fail1; > + goto fail2; > > Packet->Mdl = Mdl; > Packet->Offset = Offset; > @@ -5206,6 +5210,9 @@ TransmitterQueuePacket( > > return STATUS_SUCCESS; > > +fail2: > + Error("fail2\n"); > + > fail1: > Error("fail1 (%08x)\n", status); > > From win-pv-devel-bounces@lists.xenproject.org Wed Jul 21 17:20:59 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 21 Jul 2021 17:20:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.159496.293354 (Exim 4.92) (envelope-from ) id 1m6Ftz-0008Gy-ST; Wed, 21 Jul 2021 17:20:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 159496.293354; Wed, 21 Jul 2021 17:20:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6Ftz-0008Gq-PP; Wed, 21 Jul 2021 17:20:59 +0000 Received: by outflank-mailman (input) for mailman id 159496; Wed, 21 Jul 2021 17:20:58 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6Fty-0008Gk-8F for win-pv-devel@lists.xenproject.org; Wed, 21 Jul 2021 17:20:58 +0000 Received: from mail-wr1-x430.google.com (unknown [2a00:1450:4864:20::430]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b091b9e9-fccb-48dc-880b-67220e4859d6; Wed, 21 Jul 2021 17:20:57 +0000 (UTC) Received: by mail-wr1-x430.google.com with SMTP id l7so2990987wrv.7 for ; Wed, 21 Jul 2021 10:20:57 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:d056:9219:797d:dc70? ([2a00:23c5:5785:9a01:d056:9219:797d:dc70]) by smtp.gmail.com with ESMTPSA id t6sm27863782wru.75.2021.07.21.10.20.55 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jul 2021 10:20:56 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: b091b9e9-fccb-48dc-880b-67220e4859d6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=81V7utjef/961jfL/9UG1ckP6iuOAtPqafzXFsbNlQU=; b=jHf6lKf9hJWaO02zr09TSI9Qc/sTXRavRNVrv96OUZ5rt1CGN/X8a6rCGX6+ywP/A0 ukna5w3InkBOKWFmrikPq53sPsU3wvcChB9k4Tj0vimB/8VFDmJGkEGeoV/cMBfUnGh+ Lk5hCGffxSRy2WdeArueshJonalYbbcpPL7ZuFBFi87P3diVV+HvFbzEIBoaq7B0aC2r udrFp5cRwJzvzv+E6i3XJlUUEhyG/tkrASKhplyaaxI0/YTWyb93g1fHgmlXWEZ1wu/l RY9obizPmDK2VSUi7lQXziKfngNfl/7vyTW7utVCTGirpOSWQ4bIqnbR8o33/e5SJQB/ xO3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=81V7utjef/961jfL/9UG1ckP6iuOAtPqafzXFsbNlQU=; b=IQtgnoHq/BRUyjAF7MvsWIBijvlbKk+VZa1i815YLqxweeiioW1UZgCAOWyCjdVcrI DGTRlwtLg2BT9ztFDUmURy0z3vs6z3pfZvLrCjgRI41qMFuKHbMALU6e+zOTqlWdFgTA McLx2N2FXwMddKTVFcn3/zxm7l5d8kihdH0BxVvGwPxH984/My3zMfhiU2ho4JHaDLaf t5X6nsuxhfO+d4HqxXyZjuaH/EIRYRPvJnkMemNw2EfjSOB0lAdQNiCKF8pGiTTFzqxR R0dUqYcsYyAKswMPp/D79+jDREjZycKdzFkBzi/eXMgLTDq4nd2JO5ev4XH3MOXac8/f CDeQ== X-Gm-Message-State: AOAM533eoNJ7onjJ13O3bDkNVA+Si4vC4p9fAE0Vm1xEILyqkzZvAs4P 48+CzmSnntlPNhcS681ysS8efywtZsM= X-Google-Smtp-Source: ABdhPJwV8reAHAFbCUMVj1vJyLRi72oE3OfRzNkmyQthUXODjLIJ55lTqsZFSdVx9hEseDcCtmnezA== X-Received: by 2002:adf:e0c4:: with SMTP id m4mr44003451wri.312.1626888056669; Wed, 21 Jul 2021 10:20:56 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 5/6] Reduce logging of Fdo->NotDisableable, in a similar manner to changes already made to xenbus. To: win-pv-devel@lists.xenproject.org References: <20210720132951.1776-1-Martin.Harvey@citrix.com> <20210720132951.1776-5-Martin.Harvey@citrix.com> Message-ID: <984f01eb-5b29-c929-d661-af49e7696d85@xen.org> Date: Wed, 21 Jul 2021 18:20:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210720132951.1776-5-Martin.Harvey@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 20/07/2021 14:29, Martin Harvey wrote: > Signed-off-by: Martin Harvey Acked-by: Paul Durrant > --- > src/xenvif/fdo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/xenvif/fdo.c b/src/xenvif/fdo.c > index 896107c..745f948 100644 > --- a/src/xenvif/fdo.c > +++ b/src/xenvif/fdo.c > @@ -2075,7 +2075,7 @@ FdoQueryPnpDeviceState( > goto done; > > if (Fdo->NotDisableable) { > - Info("%s: not disableable\n", __FdoGetName(Fdo)); > + Trace("%s: not disableable\n", __FdoGetName(Fdo)); > State |= PNP_DEVICE_NOT_DISABLEABLE; > } > > From win-pv-devel-bounces@lists.xenproject.org Wed Jul 21 18:12:56 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 21 Jul 2021 18:12:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.159526.293390 (Exim 4.92) (envelope-from ) id 1m6GiD-0006mA-EW; Wed, 21 Jul 2021 18:12:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 159526.293390; Wed, 21 Jul 2021 18:12:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6GiD-0006m3-Bi; Wed, 21 Jul 2021 18:12:53 +0000 Received: by outflank-mailman (input) for mailman id 159526; Wed, 21 Jul 2021 18:12:52 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6GiC-0006lx-Dn for win-pv-devel@lists.xenproject.org; Wed, 21 Jul 2021 18:12:52 +0000 Received: from mail-wr1-x42b.google.com (unknown [2a00:1450:4864:20::42b]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ce726ad1-a8ae-49f1-a9d0-e538a90f415b; Wed, 21 Jul 2021 18:12:51 +0000 (UTC) Received: by mail-wr1-x42b.google.com with SMTP id t5so3127731wrw.12 for ; Wed, 21 Jul 2021 11:12:51 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:d056:9219:797d:dc70? ([2a00:23c5:5785:9a01:d056:9219:797d:dc70]) by smtp.gmail.com with ESMTPSA id l23sm13400968wme.22.2021.07.21.11.12.50 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jul 2021 11:12:50 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: ce726ad1-a8ae-49f1-a9d0-e538a90f415b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:reply-to:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5q+mtrrUyft7XCNvVDvbnDmkFXx2UFa13+5dOm+LstM=; b=HzKKu6at+QstunOXoWkJdcUV1izvgIO8E1av9mNTdvJbma82DALEQH07PAZ8mKsXuZ mTHyEKI55xANv323uYKTctAj0rK2HR0yyUpgtN5iSFj26meZnoYl9b19HEvTsPAFOpWW CH1O1Lf/zGfw0+N+j6wkOfQutYqluKxJIGmpDxp6jREe9hbE5O2rwL4Fimjk7Wfzx5wM dYZHw/6lEevvfXb7JfBwVQ0BEQ4TwDdn6CGDgHJiq0FcuX6rdh+B4TQMs4Y29l5zGffr 4JPbKBQoi3xyJbjk7MFhFOlV2iSV7CQEZxfeM6xxNaj8giDWJXOmjVxqrqUzWh+6bN2b TeMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:reply-to:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5q+mtrrUyft7XCNvVDvbnDmkFXx2UFa13+5dOm+LstM=; b=glob9zx52+54UM9c/snM7a8VSBIdj0LSRSc7eEH6VUax/ihUB3TrAEQmm/dPELVnV6 GNWVVt5d0o0B+9v1PQKiZIOeyrBuTN+5469qOxLKd+dUSFMdvzV/2Sz/qn3uotmfjVFS mJmIhqCOYkbnBFiBDMG9KADbg+6mPT885DO2+4/2l49ckg8sD/8Oh5ykogVzq22yryMW GXHT1YIZg/HlRm+UJ95wruatb8Yxz/6d8ywdFuW34NPx6YfuCzFqqEJw3yX04Z7qkIAq OxpwWXA9vbTQL92vVuwi1E72iY8oCvKzGvKtFM0VKdMFz2YteaBUBBg9XTVAUO67xwCj 0SzA== X-Gm-Message-State: AOAM532zxhqd/2JfN/U8yBMe3HMl+p77WeY1IhxMZQITC0Vt/+oHsoc3 cCrnapsFOg6sZDtYxzbCzxwhxzjPqO0= X-Google-Smtp-Source: ABdhPJx69+MdpEnVOD47rqa8sWG/tUcRTufclAox5Wt86Iddx8JidfR2O2RfxVTRcXOCKrWX+6ytYw== X-Received: by 2002:a5d:60c1:: with SMTP id x1mr22915672wrt.123.1626891170825; Wed, 21 Jul 2021 11:12:50 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Subject: Re: [PATCH 1/6] In some cases, the frontend may stop processing Tx ring requests in a timely manner. If this happens at the same time as ring disable, then the Tx code could spin forever at dispatch IRQL. Reply-To: paul@xen.org To: win-pv-devel@lists.xenproject.org References: <20210720132951.1776-1-Martin.Harvey@citrix.com> Message-ID: <86dc9d1c-93db-44d5-8c45-2ad7c57365d7@xen.org> Date: Wed, 21 Jul 2021 19:12:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210720132951.1776-1-Martin.Harvey@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit I assume you mean 'backend' rather than 'frontend' here? On 20/07/2021 14:29, Martin Harvey wrote: > This patch introduces a hard limit on how long the code will spin, > allowing a device disable or power transition to complete, albeit > at the cost of Tx requests being dropped or the ring being in > an indeterminate state. This has normally been seen at guest shutdown > where final ring state is of little consequence. > > Signed-off-by: Martin Harvey > --- > src/xenvif/transmitter.c | 21 +++++++++++++++------ > 1 file changed, 15 insertions(+), 6 deletions(-) > > diff --git a/src/xenvif/transmitter.c b/src/xenvif/transmitter.c > index f6935a6..e114061 100644 > --- a/src/xenvif/transmitter.c > +++ b/src/xenvif/transmitter.c > @@ -3933,6 +3933,8 @@ __TransmitterRingDisable( > XenbusState State; > ULONG Attempt; > NTSTATUS status; > + BOOLEAN ToProcess; > + BOOLEAN Abort; > > Transmitter = Ring->Transmitter; > Frontend = Transmitter->Frontend; > @@ -3985,24 +3987,31 @@ __TransmitterRingDisable( > } > > Attempt = 0; > + ToProcess = Ring->ResponsesProcessed != Ring->RequestsPushed; > + Abort = ((Attempt >= 100) || (State != XenbusStateConnected)); > + > ASSERT3U(Ring->RequestsPushed, ==, Ring->RequestsPosted); > - while (Ring->ResponsesProcessed != Ring->RequestsPushed) { Why not leave this clause alone, and simply add '&& !Abort' after having set it FALSE above? I.e. why do we need the 'ToProcess' boolean? > + while (ToProcess && !Abort) { > Attempt++; > - ASSERT(Attempt < 100); > + > + KeStallExecutionProcessor(1000); // 1ms > > // Try to move things along > __TransmitterRingSend(Ring); > (VOID) TransmitterRingPoll(Ring); > > - if (State != XenbusStateConnected) > - __TransmitterRingFakeResponses(Ring); Actually, do we even need 'Abort'? Could you not just break here... > - > // We are waiting for a watch event at DISPATCH_LEVEL so > // it is our responsibility to poll the store ring. > XENBUS_STORE(Poll, > &Transmitter->StoreInterface); > > - KeStallExecutionProcessor(1000); // 1ms > + ToProcess = Ring->ResponsesProcessed != Ring->RequestsPushed; > + Abort = ((Attempt >= 100) || (State != XenbusStateConnected)); > + } > + if (Abort) ... and then check if Ring->ResponsesProcessed != Ring->RequestsPushed here (and fake responses accordingly if need be)? > + { > + __TransmitterRingFakeResponses(Ring); > + (VOID) TransmitterRingPoll(Ring); > } > > Ring->Enabled = FALSE; > From win-pv-devel-bounces@lists.xenproject.org Thu Jul 22 12:04:34 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 22 Jul 2021 12:04:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.159696.293715 (Exim 4.92) (envelope-from ) id 1m6XRH-0002QB-Fh; Thu, 22 Jul 2021 12:04:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 159696.293715; Thu, 22 Jul 2021 12:04:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6XRH-0002Q4-Cj; Thu, 22 Jul 2021 12:04:31 +0000 Received: by outflank-mailman (input) for mailman id 159696; Thu, 22 Jul 2021 12:04:30 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6XRF-0002Py-W5 for win-pv-devel@lists.xenproject.org; Thu, 22 Jul 2021 12:04:30 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e50ad0a9-454f-44c1-9ac0-b5663668ffcc; Thu, 22 Jul 2021 12:04:28 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: e50ad0a9-454f-44c1-9ac0-b5663668ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626955468; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=pcyw9Cua59URBZ7mQVTaDSzYWM0ZmT5zgAICi+JUVDc=; b=gdX68JhqmD+xlSKvnHtosrV1zHsICdeHFAOnIbca2duAhJrd7dh9ishH tEE1MQxl2zMNOLU/8UxQM4txdtrnId8OT3rebGbK+im46EGeu8XpA6dNr WwazYkJ9m26G0M/MgAzl5bcxCGBzNP1MA9DmIVdQ5tWFkihiVBUOIP75o A=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: XzrlbB2nLpWWWceQU7jqBcZvVoqY8lCe5w6igkHE4GM9aj21KTOrOAL/Saht5v3P9ZkdqKVAW7 CmIVeX+AS7vcB5ZZq4ooYlpZtWcrkR6+MwNFaXmyEF5/5bSXzllh94mrYSngtdrXuNhbGAhaH0 WTW4vwmXaJEYVDkhnw12FegeZoSVSIK7RT6lGEE3tWq9XCNq4Xk3Lkc32clE9Hx6H//hmSU9/0 W5Ji8P7DYbuIOUjVEG8CWne2yl6HUtkp+cn7Hq5t3kAtXUL1jtMcVEra1fPPYlVGL/5TIkycMg hSRKrpqi6lzfKe5+WlHp7Oae X-SBRS: 5.1 X-MesageID: 48525212 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:AQKzMquVDuuV5AScxJS0xzjT7skCw4Mji2hC6mlwRA09TyXGra +TdaUguSMc1gx9ZJh5o6H7BEDyewKgyXcT2/hfAV7CZnirhILMFu9fBOTZslvd8kHFh41gPO JbAtND4b7LfBZHZKTBkXCF+r8bqbHtmsHJuQ6d9QYUcegDUdA50+4TMHf/LqQCfnggOXNPLu v52iMonUvDRV0nKuCAQlUVVenKoNPG0Lj8ZwQdOhIh4A6SyRu19b/TCXGjr1YjegIK5Y1n3X nOkgT/6Knmmeq80AXg22ja6IkTsMf9y+FEGNeHhqEuW3XRY0eTFcdcso+5zXUISdKUmRIXeR 730lAd1vFImjHsl6eO0F3QMkfboW8TAjTZuCOlaDPY0LPErXQBepF8bMtiA2Xkwltls9dm3K 1R2WWF85JREBPbhSz4o8PFThdwiyOP0DIfeMMo/gpiuLElGfZsRE0kjTFoOYZFGDi/5JEsEe FoAs2Z7PFKcUmCZ3ScumV02tSjUnk6Ax/DGyE5y4ao+ikTmGo8w1oTxcQZkHtF/JUhS4Nc7+ CBNqhzjrlBQsIfcKo4DuYcRsm8DHDLXHv3QSmvCEWiELtCN2PGqpbx7rlw7Oa2eIYQxJ93g5 jFWEMwjx9ER6svM7z74HRvyGGBfIyQZ0Wc9ihu3ekNhlSnfsubDcSqciFcr/ed X-IronPort-AV: E=Sophos;i="5.84,261,1620705600"; d="scan'208";a="48525212" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ivfm+HKbl0TabK8lDLyd3nzjPYhNmq6bIsVcfdgIyQ+MFtqTLPlFFThqF378frsVpxh9zvVo2yxZo7LpfbQmn4d9hGsx3Hr5vcQr9Wh6xo09lJyuv7IsnSjDIrGmu/LfGNSodoknIjF+72wYuSUM2l9DO2YcYeZ9MYdt6RGnuBg8NjxGCwfU3miNyPbY9OHZ2A6/81uyCDkq6svkVOdxHHnXIoUyimqTBH+58p/kwyREyJY14TG4ZM3kh0Jk+TE6HYuSwxG5CImoXJ27rtief8b2zmcSjzH3PxoC3pykPHiLcQEtfL8/k3T77sZtQpED5zRiL4gfBfvWOz9f6ouZ4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pcyw9Cua59URBZ7mQVTaDSzYWM0ZmT5zgAICi+JUVDc=; b=kW/HAxRod/0kPgGTZ8shmj9wWDAOGy4Wo6j2cV1ME69h8h5qfHUQmxwP5r/1pLzFiLGq1hKOBQFOMOgvx9iI7detCiHwv/4P5X0FeS0WCVj0Y4Wx26yUoordc7RwY+BSVurMmxQU/s9G1Y22KqBPflMr9zwkmm6R+CqE7aJmevLW2FfZ2UF7/3/Ne4hV+oJaYWPshrKdrwUVmVMuJsQf+xqTlf1anehVr3YH1ZYLq2FP6ExGR53NyPNgcu5i5PihZ+dfThvo0a5da5d7CaNly6C3fYjotl22squg9QC8urqJKx9DEbNwS0AxWoDqisxN/58JrlnK77kalgeUaNwMAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pcyw9Cua59URBZ7mQVTaDSzYWM0ZmT5zgAICi+JUVDc=; b=O7I+ryNTyO2cnMRgVdcRudUmt3Dauu6fL82/XoahF/EGuSeQhS7yDipQ/3Zh+dC8m1DneXVE7yES/j7YvZPGtDLejdU6yWy/iIj3t4/mC8ppvHWBWLL5L4pq+NCaltOfZ4HM8bRgO9PCk/oiVGNJ4ac6FZ1ezXHiK4DHNGiDlGg= From: Martin Harvey To: "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Subject: RE: [PATCH 1/6] In some cases, the frontend may stop processing Tx ring requests in a timely manner. If this happens at the same time as ring disable, then the Tx code could spin forever at dispatch IRQL. Thread-Topic: [PATCH 1/6] In some cases, the frontend may stop processing Tx ring requests in a timely manner. If this happens at the same time as ring disable, then the Tx code could spin forever at dispatch IRQL. Thread-Index: AQHXfWtiqmcHMbOXDk6oO+NPAzwNeqtNq0CAgAE8/gA= Date: Thu, 22 Jul 2021 12:04:24 +0000 Message-ID: References: <20210720132951.1776-1-Martin.Harvey@citrix.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b39e2d27-7de6-478e-29f0-08d94d08d953 x-ms-traffictypediagnostic: MWHPR03MB2558: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Dfhk9EUDhy7ILQMbs4FRyG2J49L3QsR85NSZAZwLwicEJd7TDsA4suTMmDA5ET4f2nEaILUuFMD51y23SHRi2KtgtLHwDD9qkFwxZfx0QPPjSPaaQcmw7HFiw5to7kxEY2nj7qkUSOEmVngJd9swSCPlhAn/N3tOtchP6GDpQwYiwCkjdk9dsXS1mVGcmU89mo9pWlYzfDZAqOKvvdPpDgddXXCYX8xn/tg7zeKb7G0hxymwSbgLIE5cjOMymcPDlwlSRk2yuNy9UPbYqGsfGO01X2U9uE1iVgJGWpEGEoBpSKB/tYgGZO/K57qBRSomr5AWl6yTMFv+2cKf5IVI4UtD/eJyf+jr10IB2SxMsHV7S/1mtWNhjK8/AfzlaTJY0ESRzII1qeDDAUHkgoyKYz+0reKIt8qrdI/EH5mBpMFE4qfpsdtsQ8YfStywKCJZ3yKMIurRLunZNZk1t+XT1a3/veid/WYXc9JkR91VlB72GAKIDXN9gPA5QF15BHj/2cWZI895VQT6xWjBfwqQiUhVEffBAmOADpWZtd9W22dA6AWFmYLkShzxXl9FeUvaiqB+bX4SnbwAJljCgINYK5xEV/XTYG7LJ6nipmeMfBMdMDi81E9lGPf6pZnw79XWYJJLWNnPQ5ER8Zy0M2I6couJR8/PmUsISj3xY4MY2U3vN8mXE3tp4p6PN5sucQt7yaHsCcM4CVNIlkCScU1Bog== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6347.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(366004)(39860400002)(136003)(376002)(396003)(52536014)(64756008)(66476007)(9686003)(55016002)(66446008)(33656002)(76116006)(66556008)(186003)(83380400001)(66946007)(26005)(110136005)(122000001)(86362001)(7696005)(5660300002)(71200400001)(4744005)(2906002)(8676002)(38100700002)(316002)(478600001)(44832011)(6506007)(53546011)(8936002)(38070700004);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?S21odTBqNlhXckUyY3RaZTBFc2UwNW9oK2gyRDNoQ2VSNVE2SzI5UVpCZytk?= =?utf-8?B?K3NOdGZ0UVJRWVVKRHdmZ1dqSEhCcFE1dXUwMWpOVVdOcWFkd2wyV01FRloz?= =?utf-8?B?QTd5bHVnVGRRd1hIYzZBUXZxcHhqQTFaZFBPaU0rdVVoVXJGRkdOOUFibU0v?= =?utf-8?B?Vlc2QWFKQUg4Qk5zWWFmVUpNSTZFMUdudE5SU0JJaEp3VnVRUktyM1czd0th?= =?utf-8?B?ODNwWGQxSEY5Qm01TWwrQkVZQlg5TEwrMTNXbzlMOFJBeFlzTFhndzRwUUMz?= =?utf-8?B?TGNyNWJzdnBVUG9Hc0pJOEExcys2OGxRRXZjekRIaVdXbm84Z3RuQlpaL2Vw?= =?utf-8?B?R3UzWDB2NzVmRWE1SjhxUmRVV3ZrVThZSG9WUU5jc0xvd1oyVk5KOVNPZC9D?= =?utf-8?B?MW4zL0twdi9PT3JOT0ZISklNM05jWTZSbUpMbklxT2UzV0RjOGxiTFdwcDI0?= =?utf-8?B?L2s2bGdhcnBqaDZabmtWdjIxRFc4NW1QUXlwa1N3dzlIWEx3c3huY0xjL3JD?= =?utf-8?B?N24rUGQ4OTRUYzlEYkdoVzcxQ1ZPL1htT05rd2RRM1ZPMGRLZ25TaWg2ejFS?= =?utf-8?B?cWVqeEpMZEVHN3Zrc1FYMEFPN3RFOUt3TFdFR1kwY1h3OHptVEFxQWlUTGFp?= =?utf-8?B?K1VBWEtFTU9LaERabERnajR1L0dCMm16dHFGcXFGNmVpSmxBRWFucElocUJ4?= =?utf-8?B?TmUxQkt2TVJ5RTB1V3F1Sk91TXBFYk52T2ZEaWpqTXBrSG1OUE9sbHY2Z0xx?= =?utf-8?B?aVRhbDZMSndGdjA2WEprQnduamptNnBJeUpzb0FyZVdheGlucFZoYy8vODRi?= =?utf-8?B?cGZjN0ovWXhwZWtJM3NPc0EwMm1iVTUwQklXd0pxRlROOThhcG1NSlg0S05G?= =?utf-8?B?aWVaQlVwTTJoYWVxK1VwTnRKK2gyT3dFdmxsNjU1aFk5cnduaGpPZFp3NHBW?= =?utf-8?B?MUNRS2xCK3FqN0xna2E4eEkyc3dvSUxDR2pPa2xab2l6a3BQWU10U2pYV0lQ?= =?utf-8?B?c0JVSlV6UG9VSHg4aW13RjVFaEduS1hPbUNZYnlOTGtTdUdyWWRic3BhUi96?= =?utf-8?B?R24yNVVGbWs5WlNJWFVmK2ZmOFB6UEtsZ01IK2JIRjNVUk90OGNzM3FJSG9W?= =?utf-8?B?TWt5WGk3NS9HczZCOGVWZkg2SytsRXdFY2dzYjlXRkJoOHB3N05sQXVPRGhB?= =?utf-8?B?U0I5MFh2MWFQcHBHMTNCQjlGV1paODYxL1g4azRGaDFlM1VDTVJMTmVHcWpC?= =?utf-8?B?M2V2cUNqa2dyWW9Rc3JSclRNUHNjMzJSdmpQT0poWDJRRGFiOVhTVVZvenEy?= =?utf-8?B?WTdTN3RPZWE2WVpmdHVPRUpVOHpEZEo4YjhxRTdOcDllRFUvcG5tZk5pZ2th?= =?utf-8?B?Q0gxMTdMUmhwbEV2TiszSkRRVjBHWW5NT0Z2TXFkdDhRN3JkOUhJOUl2UkMw?= =?utf-8?B?cXZYRDdnTm9WcUNacDM3aXVsVE1kUDE5S29uUnk4OGRmMUZvakRjNUF0Vk9I?= =?utf-8?B?QUQvYW9aVkFNdnZQQmtXU0lwUUlTdktNS0s1a0RXTlJVQ3huSmtvNFBSMllx?= =?utf-8?B?aUM1OGI3dDJlR3pJR1lrK3JoaURlWUVhOTE4eWV5cit0YkxsTkRkdHlaWkJo?= =?utf-8?B?Q0NNWTFQMTkvTDJabjA0VVY4dTdjZjc0dFc1R0ZVNExaNDlXUEhia2ppR1Na?= =?utf-8?B?ZldwUVlsWTlUcGdOSk9haENQc244YkFibVMyM1VXSk5VdnNtdUFBMzVGTWp2?= =?utf-8?Q?1HV+909aYDJNoxumoehb2N0bD7bqP6OAt9BLpL1?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6347.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b39e2d27-7de6-478e-29f0-08d94d08d953 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2021 12:04:24.9763 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Mtj0WNzCRdlRzyNkwWTHugIaVOMO1A7vh/AqFwpXzgifHHscM3IYw8R6A7ryGTqmsObsYAXq1A8O70tJtvTRhZ77HEZ5U7mKA6p/oz0k5BI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2558 X-OriginatorOrg: citrix.com LS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCkZyb206IHdpbi1wdi1kZXZlbCA8d2luLXB2LWRl dmVsLWJvdW5jZXNAbGlzdHMueGVucHJvamVjdC5vcmc+IE9uIEJlaGFsZiBPZiBQYXVsIER1cnJh bnQNClNlbnQ6IDIxIEp1bHkgMjAyMSAxODowOQ0KVG86IHdpbi1wdi1kZXZlbEBsaXN0cy54ZW5w cm9qZWN0Lm9yZw0KU3ViamVjdDogUmU6IFtQQVRDSCAxLzZdIEluIHNvbWUgY2FzZXMsIHRoZSBm cm9udGVuZCBtYXkgc3RvcCBwcm9jZXNzaW5nIFR4IHJpbmcgcmVxdWVzdHMgaW4gYSB0aW1lbHkg bWFubmVyLiBJZiB0aGlzIGhhcHBlbnMgYXQgdGhlIHNhbWUgdGltZSBhcyByaW5nIGRpc2FibGUs IHRoZW4gdGhlIFR4IGNvZGUgY291bGQgc3BpbiBmb3JldmVyIGF0IGRpc3BhdGNoIElSUUwuDQoN CltDQVVUSU9OIC0gRVhURVJOQUwgRU1BSUxdIERPIE5PVCByZXBseSwgY2xpY2sgbGlua3MsIG9y IG9wZW4gYXR0YWNobWVudHMgdW5sZXNzIHlvdSBoYXZlIHZlcmlmaWVkIHRoZSBzZW5kZXIgYW5k IGtub3cgdGhlIGNvbnRlbnQgaXMgc2FmZS4NCg0KPiBJIGFzc3VtZSB5b3UgbWVhbiAnYmFja2Vu ZCcgcmF0aGVyIHRoYW4gJ2Zyb250ZW5kJyBoZXJlPw0KDQpJIGRvIG1lYW4gYmFja2VuZCByYXRo ZXIgdGhhbiBmcm9udGVuZC4gUGF0Y2ggYmVpbmcgcmV3b3JrZWQgdG8gcmVtb3ZlIHJlZHVuZGFu dCB2YXJpYWJsZXMuIEkgd2lsbCByZS1zdWJtaXQgYWxsIDYgcGF0Y2hlcyBhZnRlciByZXdvcmsu DQoNCk1ILg0K From win-pv-devel-bounces@lists.xenproject.org Thu Jul 22 12:25:26 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 22 Jul 2021 12:25:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.159704.293722 (Exim 4.92) (envelope-from ) id 1m6XlW-0004ia-1x; Thu, 22 Jul 2021 12:25:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 159704.293722; Thu, 22 Jul 2021 12:25:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6XlV-0004iT-VM; Thu, 22 Jul 2021 12:25:25 +0000 Received: by outflank-mailman (input) for mailman id 159704; Thu, 22 Jul 2021 12:25:24 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6XlU-0004iM-Is for win-pv-devel@lists.xenproject.org; Thu, 22 Jul 2021 12:25:24 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e28bc318-eae7-11eb-8fa3-12813bfff9fa; Thu, 22 Jul 2021 12:25:23 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: e28bc318-eae7-11eb-8fa3-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626956723; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=1y5SUEpiJcK8jaCbzCwMLwu628UWzISVPMgeIIn6jgg=; b=RdMObUIrmdKVl1rrmoinz7cuudequ9KRtibBU/zgZOUFyek2IlYg+4YN v+BmgCmOrJAFsUzl8dXn/0fUAfgOyOifBWjzseDsfOh5wqOpEJLcRhH37 B3xU8FSzF7sdHaTpN8Uy4lXMcniiXsxGVJQ9bk4UCT5DqGZLGzPGqWkAq Y=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: /ZPl10czxTPyL3l8+dlLj3ms+QOlhwkXhpzmwNM2xoMFBN68KkfzFTcR+uwQWfzMEqOe7rt+YW FgxCBA3So4Z+DnZIo1XRzj5LOlwywLe6amFHee7xnS3AxL3GiTcCI/PVvMkzSRNRb0ZJeEs1En w97A4PsBMgtY7sM5vFv6grLNlPKhKVGjdTJ/c2t2EsQyPnPE5Rrnv0Gg59O8PWs4micK9kUPYe EiSy6jCJ76rZgQOBhZA70zdNZoGJe2uB+yDU4HwIUk6lK6qgtHwyOEYzuZckPzARMUW5CeQduf Fc0hTbdg2nFcQNq0+VRFF+HV X-SBRS: 5.1 X-MesageID: 48851383 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:82Xe7a/D0Dzs/H+FOABuk+AiI+orL9Y04lQ7vn2ZKSY5TiVXra CTdZUgpHvJYVMqMk3I9uruBEDtex3hHP1OkOws1NWZLWrbUQKTRekP0WKL+Vbd8kbFh4xgPM lbEpSXCLfLfCVHZcSR2njFLz73quP3j5xBho3lvglQpRkBUdAG0+/gYDzraXGfQmN9dPwEPa vZ3OVrjRy6d08aa8yqb0N1JdQq97Xw5evbiQdtPW9e1DWz X-IronPort-AV: E=Sophos;i="5.84,261,1620705600"; d="scan'208";a="48851383" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EpMauztoRiZoMd6789ng0FLEy5N39fiyQwuIniYc2ZH+YF/XyE00dj3i+EFgko0XYoDyWxnO8BR5yKjiVdp+2Dc3JQKyOL4/C9b/bRNWO8cw28uxe+laSvDi2JIZUqYG2FXrxpY2WlYQL64ja+Dh32C1Kd2LRcZNwXLJxo4Hj17V/6vqxDpI4eaJ2SwdJlLdbjgRllUGtfeZvTshN5F2s7Old8xz2nPA40qOqzBZYieLls4dDdv8Y82s/f/QvonfsKONDFbl59BoY/rsourgRJ0X25zWUE4ywHcK8Fgq1E1yCocw0RbecqGTIHgSAi60u7xQGoX1TTbmaKTy4SLubA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1y5SUEpiJcK8jaCbzCwMLwu628UWzISVPMgeIIn6jgg=; b=JDZYQuTFgTPaAJo41TXBbONpZaI7+pvOVSfU/8haSW6U11r5gwgeoXC4KiwHuM9+jTsDht6x/fPHVzdH54oxXRSEUuRd0xgZRu9avI8hHCzU0JDYpuTwNhMz2xhLA1h0ry5Yxc/KaiFluFcfeyLmBtNt5v7c5XClryAI88O3ZsN2O5TB/laVcuGNvGH6FFQ/Dh8uXKczRcA7NgW6tH3zjq1jRNgIHbKiJ99iY0qlNTrC0UkOXTB6gZRhvhzvx4szkUgVJ0foz8d9rZiq5kzF6WzfB8QKIjL5sUPHJ6Q+cdv0H3AWWEKLHiBx3zaMX2aMjKFRptvpxvWckWlvNLw9pw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1y5SUEpiJcK8jaCbzCwMLwu628UWzISVPMgeIIn6jgg=; b=rcsKboxGN0MPxyh87+YZw+ln22W6DJ+8VCjaGyhXNU0oCSYtrCszZnXEKgTRVYP8pJVwoY9KkyuhSP1VkflU9aOjTYTR7EIaLdULoapd7eIBUNYN0aj9lY6BOTL/UZ5o/XsMXRlyqc1ka2gSKI1xz2Z1qa4baVEUzDx2TLXq55A= From: Martin Harvey To: "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Subject: RE: [PATCH 2/6] Since Rx/Tx ring disconnects now no longer wait forever, we add some logging to catch those cases where the disconnect has timed out, indicating how many requests are still in the ring. This aids greatly with customer debugging. Thread-Topic: [PATCH 2/6] Since Rx/Tx ring disconnects now no longer wait forever, we add some logging to catch those cases where the disconnect has timed out, indicating how many requests are still in the ring. This aids greatly with customer debugging. Thread-Index: AQHXfWtkGU/pmVsFfkKcNK0c677mQKtNrBUAgAFCDBA= Date: Thu, 22 Jul 2021 12:25:18 +0000 Message-ID: References: <20210720132951.1776-1-Martin.Harvey@citrix.com> <20210720132951.1776-2-Martin.Harvey@citrix.com> <11b1c340-6460-7c17-bf42-6ea624f1bd3f@xen.org> In-Reply-To: <11b1c340-6460-7c17-bf42-6ea624f1bd3f@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5cc6ed24-bba2-410e-a4d2-08d94d0bc4b4 x-ms-traffictypediagnostic: MWHPR03MB3055: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:619; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HruyhjiavEtYwBaBRuuph+45HCJjuenGZGVQNcl9TNtg9ebJtimdwjh2LHWnIj8GahS1xqCcBJ+1DyFKuezdO039Oui5n3WpposesFt8LBDPFF5cTPFVNNlZ1sbS+itJJlfUFgFUK/xPf0bwgGI6hua1URxKeM9jbsIBhA/FOJ+KtueYZ39m9wvh+FYCT96BT8++Usp9EHS3/NpOokD0LsHlQm+AglewwLoCTbA7Ourke1Sawf4bHGqSqESoSx8BlcbnkD7sMDZXKHP8WFj/SVMdjDtaiNoKxD984NzFo7JHesvb5fh8PnhmiPYHIAXeLD6L6rTrLoQH48SS5QhxwIK68v/6Y5AmtKGE16+du9I5iirZTpKw/Q/achxArHJrZJp9XR6GOaJmkmGuYz6Cv9n+Q4LVUXXGGosqsZN7irAdh3LOkh9BPV4PFH1dg9NZqc6dZzO0J/4cqHcWTbMnBCYAFPpb/aJHx6UTUEcrSeqypeuhv/7nw0WIRsUm0vGqigr8CHfKHYuSvVohBIl+9UQdDWY6mGQxG1ew/mZ45JvKlysCZHzbepE8XKqC6WgKANwcghoWgRYhvgX4647xtLBf5YLzeQCvO54semr6Eanz9S5rU0n97B+CyYVg4zeb7Kj7tPgWOZq4xCpYyrNZkLQpxTqVRP8P0uFGFXOTyGU9WKPDJKo/3p5jgS5kxrAJFgzmnozgMvRloQ8/gEkL1k8SNJ4wDLQdPGM304JDwvI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6347.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(52536014)(55016002)(4744005)(5660300002)(86362001)(6506007)(76116006)(66556008)(66476007)(53546011)(66946007)(8936002)(33656002)(508600001)(44832011)(64756008)(316002)(7696005)(66446008)(8676002)(71200400001)(83380400001)(26005)(9686003)(110136005)(38100700002)(2906002)(122000001)(186003)(219693003)(38070700004);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MllLRjNCQ21OL2dHNEZxZGN5K1MwS0RTNXMzYVdKRHlCYmxqTHF0M1FvTC8y?= =?utf-8?B?ZnI3S0pFZTR0QzV5UWtabnN4N3VBQ25mNU1XcGZsR3FTYlEzQ0p1OW03N3FF?= =?utf-8?B?QWp0c3ZOWXl5RmVuYStHQmVKRlROemxNR2hxc2ZuRWdibmtCc0xjZkQ2aHVS?= =?utf-8?B?ZkovZ0hyQnZnblJ4SXM5MStPS2lpU0p5Q3E4Wjl5OUtKZnYwWmw2em9VQUhN?= =?utf-8?B?bWZDMjZHNWVybUwxc3FzUEZhU3cwNDZNdVBTb1FQYkZXbmx5bTdhbno4VW50?= =?utf-8?B?QzlhQzJSZGdESjkwMDhkeGcvdHRieUUrRjV2WGFOZTgyaTFBNks1VEd4YnV4?= =?utf-8?B?eFRsUE82TEw3L3dzS3pEYmt4Z0FoeEJCTjZSWnlsbHg4bUlqYnhBZ0V6ZnUw?= =?utf-8?B?OTBWbWR6elVENE1yZWxYaEhpQ1BVcElwNXcxajMrMUtuUkw1RTF1NVY4YmE1?= =?utf-8?B?dE9LcXhFUlNWdzdLQzZXWnlKT2E3MnNheEYyZmEwZkcybExwYmpmQjQ5ZEt1?= =?utf-8?B?dEJNRkRhR3l3Q0h6UjBab24rK0tNcWxmV3JVUHpRRVkzR0J0aFZFUXhrWlFu?= =?utf-8?B?Z2tCZlF0ZG5ZRU0rSlhtcUV3cDRzN05GWVdqRUkya0xwM05ldnRNQWt5aDZa?= =?utf-8?B?SUtqS0l4ejFubHhnM0ZwbGxDWndHeGFBUTVrY2JHbWR3Q3FKTmcxR3NQczAx?= =?utf-8?B?VWhIQTZOR3hYRkcrT1VpYURiamxXOEV1enRaOWZ5RkhydURZbmE2VjRCZVBZ?= =?utf-8?B?SkFLZGMzYThDbUV3VlUvbk02bXNIRmQ4ZkJmVFFUc1I2MnZxZnRxVjBMSW5p?= =?utf-8?B?R09Wd0JmbC9LRit2TFlJRjhPYi9xZTVFWFg3OVpneHhEeUhMTHZ4bk1iNUV1?= =?utf-8?B?UzFTdHR2ejl3UUp3RHBza0E4MndQSzdENFFJdEY3a2pTVTljeEpSZWxXWmJt?= =?utf-8?B?Rm8vbllmUVZuTzRCZlBRVVpwek9IWU9uendnVEtoOERGeXhTSjJ3dnFTKzQ0?= =?utf-8?B?VmFYQVNxeVdFSzNyU00rMTBCbUJ1ZkRHYlk0eG9wc09TcER3SzBBYjNNN3Bm?= =?utf-8?B?UFc5SEN5SVpSYTRadVptUWw1ZytRK2YzK0FnVnNmNG5haXlhd2xUaG5NMHZa?= =?utf-8?B?SGxzdmJ0L3kvelNmMjdvS0h5d2YwNkd6U0tKeEpobk5PQ2d6Y1Roc0ZyeHE1?= =?utf-8?B?TDd0MHpDTXYyRldCaTRvcGl0SWIwc3JGZjZ1d2wwbEtaaXZ5cXRGb3llOVM2?= =?utf-8?B?eGJ4UkV5M1c1Y0ZMRUx0RlVxSG11WnVJRXRJbGx5VnQ5anl0MG03c3hhVUNh?= =?utf-8?B?VWxyQnptZFBUSm1URFVxQkFFbHE5VVlha0tZamNLczRNeWtsK0hHZ1VRYStm?= =?utf-8?B?MVBDMkJrYXh2MTRKQzFiNDAzYkt6ZEZKckVqRFRJVG1sV2NLS29ia29LWXBH?= =?utf-8?B?SzlLU29WdHc0bEdNaTBRaXoyT05qejRTeWFLanE2aHVuektmTTdadko5OGVY?= =?utf-8?B?ZmhQUGtKQm1nL2hXSXZnUXJaYWpKM2FtVXdFbjFHenhudTd4dExnc3B5YWxp?= =?utf-8?B?SG9tYk55b0RvVS84SVdLRUhsdUs2aWF6M3JHZUoyU2RTem1YZGF2YlhzZzd6?= =?utf-8?B?Qm5McUR2bWZ3WmxXQVQwMFMwMjZKYURaZzQ2T3pPMnRBMk5VUlgyWG1EQ3Vr?= =?utf-8?B?S0NJQ1M5cVlFVFRLVXJrV2JNeU9SenJ0WnpzTURCOEh1QWFhQ3VRMTlueE5M?= =?utf-8?Q?j7ZejTjicTcuy5+Y1TcVjJC+SDl9wnj3077PjQb?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6347.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5cc6ed24-bba2-410e-a4d2-08d94d0bc4b4 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2021 12:25:18.8871 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HYWPUIsTrW7Y49auz2K/P/qGPdqxhJfxyYqbgyaVZQJdqb1Em1EhyKICWBXSAG9RGx26dIU2M1jKnTSczin56p9wWlNtawSprlCuM5nLaGs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB3055 X-OriginatorOrg: citrix.com DQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiB3aW4tcHYtZGV2ZWwgPHdpbi1w di1kZXZlbC1ib3VuY2VzQGxpc3RzLnhlbnByb2plY3Qub3JnPiBPbiBCZWhhbGYgT2YgUGF1bCBE dXJyYW50DQpTZW50OiAyMSBKdWx5IDIwMjEgMTg6MTINClRvOiB3aW4tcHYtZGV2ZWxAbGlzdHMu eGVucHJvamVjdC5vcmcNClN1YmplY3Q6IFJlOiBbUEFUQ0ggMi82XSBTaW5jZSBSeC9UeCByaW5n IGRpc2Nvbm5lY3RzIG5vdyBubyBsb25nZXIgd2FpdCBmb3JldmVyLCB3ZSBhZGQgc29tZSBsb2dn aW5nIHRvIGNhdGNoIHRob3NlIGNhc2VzIHdoZXJlIHRoZSBkaXNjb25uZWN0IGhhcyB0aW1lZCBv dXQsIGluZGljYXRpbmcgaG93IG1hbnkgcmVxdWVzdHMgYXJlIHN0aWxsIGluIHRoZSByaW5nLiBU aGlzIGFpZHMgZ3JlYXRseSB3aXRoIGN1c3RvbWVyIGRlYnVnZ2luZy4NCg0KDQo+IERpZCB5b3Ug Y29uc2lkZXIgdHJpZ2dlcmluZyBhIGRlYnVnIGR1bXAgKGF0IGxlYXN0IG9mIHRoZSB0cmFuc21p dHRlcikgcmF0aGVyIHRoYW4gYWRkaW5nIG1vcmUgYWQtaG9jIGxvZ2dpbmc/DQoNCldlIGRpZCB0 aGF0IGFzIHdlbGwsIGJ1dCB2aWEgdmFyaW91cyBtYW51YWwgbWV0aG9kcy4gSSB3b3VsZCBub3Qg Y29uc2lkZXIgdXBzdHJlYW1pbmcgY29kZSB0aGF0IGludm9rZXMgYSBkZWJ1ZyBkdW1wIGhlcmUg Z2l2ZW4gdGhlIGNoYW5nZXMgaW4gdGltZW91dC4NCg0KTUguDQo= From win-pv-devel-bounces@lists.xenproject.org Thu Jul 22 12:33:45 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 22 Jul 2021 12:33:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.159713.293729 (Exim 4.92) (envelope-from ) id 1m6XtY-0005u0-OF; Thu, 22 Jul 2021 12:33:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 159713.293729; Thu, 22 Jul 2021 12:33:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6XtY-0005tt-LO; Thu, 22 Jul 2021 12:33:44 +0000 Received: by outflank-mailman (input) for mailman id 159713; Thu, 22 Jul 2021 12:33:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6XtW-0005tn-OL for win-pv-devel@lists.xenproject.org; Thu, 22 Jul 2021 12:33:42 +0000 Received: from mail-wm1-x334.google.com (unknown [2a00:1450:4864:20::334]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3929aabf-9a8f-4536-8b13-0553d93a2465; Thu, 22 Jul 2021 12:33:41 +0000 (UTC) Received: by mail-wm1-x334.google.com with SMTP id x14-20020a7bc20e0000b0290249f2904453so2433466wmi.1 for ; Thu, 22 Jul 2021 05:33:41 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:74ec:44e9:46bb:8933? ([2a00:23c5:5785:9a01:74ec:44e9:46bb:8933]) by smtp.gmail.com with ESMTPSA id n16sm30089498wrr.73.2021.07.22.05.33.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Jul 2021 05:33:40 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 3929aabf-9a8f-4536-8b13-0553d93a2465 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=EjFk12v1JdJxax1ydHC2AybnSYTGW0QG3GvsfLfSdSk=; b=n2SDIDLf09JUt/AA6R6GYJk5Jbs35uv5/vhnQCS4LiAGlWqY/wrwNqbL2Ev6pMPspp T1yEF2ckq2AxWoA0BIfkfzbKtQUMPhQ5TYCLzRDi6HbBjGrmEpwfmRrc5STQuHTu6pft P0RsPzf4v/U/hjRPNLcRtLZ/a4RLRxCtge2XMTWzPFK2DcDG7S5jai3j7xsThZ2308qe rRfFCsv5ys1ySeQcozhpo/xhxiKmSXEg133jbx7M6rXOmKo5AodYBTptLkz0EmwJLycp tVzYCPY7ZG9ZsQ0m/SkG/sorwNz6serr3cr7HmlW/zBFv03AIGFCk48umsOcevwO2qMs Aoxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EjFk12v1JdJxax1ydHC2AybnSYTGW0QG3GvsfLfSdSk=; b=h6bFSnJaS3+EQ6nfN3seV+facc0cLgZ/5fqXwAcKs0wMm4Pw9gSis/OQVI6uEIJcpL 6DKPr16BHIQS4Vt6ARMonsNLaeAfQLJywlU4w1NU0MmN3GMJWUrBXeYPqUDTDMCXR+nd f93aXeAthlfGDvSt9RCWgZT8I9KFiUl26p9/7qz8RKRX88a5s7/I9SOuCHyZvS7Qkx3/ R81jSoRlXOPJqId69kuX7s43eoJw/QWMPlfbfMQ8gQo0PcvNmJlA0cGmN8UP6Po5rv3z 6Tel8OyT3xt+NwTFtHbCnyiM8l++YX0m9tQvtsRXQ0SoaSuddSaVd9H0FQCr6DNsYmyK gC0g== X-Gm-Message-State: AOAM532g8RkbGCxnyKt1FDB0ZOGD0P2EbX7olIRZu8GehDa0HCgmZSyA SWC7B5hIlvbEmJd8WFiDg4rEbi5XuAs= X-Google-Smtp-Source: ABdhPJwRhTkm1XWmzuKYZMmWCtzP9Px0BeVSNeJ90WIUhO17f7IdCNRsepllxMVMHJoIrKD6ZYFWfA== X-Received: by 2002:a05:600c:2197:: with SMTP id e23mr42562269wme.101.1626957221114; Thu, 22 Jul 2021 05:33:41 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 2/6] Since Rx/Tx ring disconnects now no longer wait forever, we add some logging to catch those cases where the disconnect has timed out, indicating how many requests are still in the ring. This aids greatly with customer debugging. To: Martin Harvey , "win-pv-devel@lists.xenproject.org" References: <20210720132951.1776-1-Martin.Harvey@citrix.com> <20210720132951.1776-2-Martin.Harvey@citrix.com> <11b1c340-6460-7c17-bf42-6ea624f1bd3f@xen.org> Message-ID: Date: Thu, 22 Jul 2021 13:33:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 22/07/2021 13:25, Martin Harvey wrote: > > > -----Original Message----- > From: win-pv-devel On Behalf Of Paul Durrant > Sent: 21 July 2021 18:12 > To: win-pv-devel@lists.xenproject.org > Subject: Re: [PATCH 2/6] Since Rx/Tx ring disconnects now no longer wait forever, we add some logging to catch those cases where the disconnect has timed out, indicating how many requests are still in the ring. This aids greatly with customer debugging. > > >> Did you consider triggering a debug dump (at least of the transmitter) rather than adding more ad-hoc logging? > > We did that as well, but via various manual methods. I would not consider upstreaming code that invokes a debug dump here given the changes in timeout. > Why not. You can basically copy what TransmitterRingWatchdog() does, can't you? I.e. just call XENBUS_DEBUG(Trigger, &Transmitter->DebugInterface, Ring->DebugCallback); That should get you the logging you want, shouldn't it? Paul > MH. > From win-pv-devel-bounces@lists.xenproject.org Thu Jul 22 12:44:07 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 22 Jul 2021 12:44:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.159720.293734 (Exim 4.92) (envelope-from ) id 1m6Y3a-00075v-Hs; Thu, 22 Jul 2021 12:44:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 159720.293734; Thu, 22 Jul 2021 12:44:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6Y3a-00075n-EG; Thu, 22 Jul 2021 12:44:06 +0000 Received: by outflank-mailman (input) for mailman id 159720; Thu, 22 Jul 2021 12:44:04 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6Y3Y-00075h-CN for win-pv-devel@lists.xenproject.org; Thu, 22 Jul 2021 12:44:04 +0000 Received: from mail-wm1-x329.google.com (unknown [2a00:1450:4864:20::329]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3401ff26-5de8-48bb-a40e-c80be4a78a37; Thu, 22 Jul 2021 12:44:03 +0000 (UTC) Received: by mail-wm1-x329.google.com with SMTP id w13so3252298wmc.3 for ; Thu, 22 Jul 2021 05:44:03 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:74ec:44e9:46bb:8933? ([2a00:23c5:5785:9a01:74ec:44e9:46bb:8933]) by smtp.gmail.com with ESMTPSA id i15sm32153353wro.3.2021.07.22.05.44.01 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Jul 2021 05:44:01 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 3401ff26-5de8-48bb-a40e-c80be4a78a37 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8hCVEHDKuqhlhZifPtONF0LFwN8U76ZcQ10LuPfjtdI=; b=dztRqjPQo1TSOTrnQiL0AqOQLVF0Qk5kCnckvDSMgn6ZKb4tGvT7WSC1blwx+Z9EdS QE+ehm/x87vADfcf3BWm49LB+kR+DqMqi4S5et4342K3S66jQ4m7veuwT61fATMiUkIm Q8w77hKNm3vQT/mYN8WmXRV3ZPBDdeMgUb+dlTC66xXhSfuTQTIJer0zcGQ4c2pEawBG LG5qdqNiig1KsFp4b41bX8300g7tmmF2xWFxEx9OBg4Pj1HNGuamRs4qLq8eHRyeTXeH osIAo56ufYiTnRhXRJeU2LbvjJHVyQ1mdWsJWUBDB2/rWjyQHjlEmP5aCqo8dBJR+OUx 9zug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8hCVEHDKuqhlhZifPtONF0LFwN8U76ZcQ10LuPfjtdI=; b=uCVWkn53sT3HOSQsa0gB7lGNyHdtttkYoEJH+z30siTjfyTR43fMqMPZG75ys3Uy0E ybYtnanYl7J1S+XGd0gku/sYLuqi/zXfkiOmjB486YIsh55c9dK8Pk9IquO7YOBnVwHo jZCMBClRz8C+RjGRYOgJC49mT4Vg+6JUy1XpfaEEw0qdROkorbBR+nVY3LpW9mUv1WTH 9ZDCt7mXcNWL3cIDPl39cNa4h1KFG5Mx86/xhUXrmTRn/u2hu5A1o4Z9eNFeg/1frD01 Loop92NH3NB3AH7MKf0XicXkF+A/DcgfdR/nedmU57AC906tSeiK9U1seWw1O0n5+0sG JM/w== X-Gm-Message-State: AOAM530+bO/M8Ww0gNIp1VRTlVO8Fi7SbExfBhDW8vI8tP/1+nWg9Pmx 4BWl52EksT7lLbc32rTb9uTLE/447Io= X-Google-Smtp-Source: ABdhPJxBszohhi5Abp4siiMAnMD5P2PbxWjpevi9J/FEJynpYKBodvJVLdpFY70S9JxIX5f+Sjx5cw== X-Received: by 2002:a05:600c:4148:: with SMTP id h8mr42719100wmm.6.1626957842169; Thu, 22 Jul 2021 05:44:02 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 6/6] Under conditions of high load, it was possible for xenvif to queue up very large numbers of packets before pushing them all upstream in one go. This was partially ameliorated by use of the NDIS_RECEIVE_FLAGS_RESOURCES flag. To: win-pv-devel@lists.xenproject.org References: <20210720132951.1776-1-Martin.Harvey@citrix.com> <20210720132951.1776-6-Martin.Harvey@citrix.com> Message-ID: Date: Thu, 22 Jul 2021 13:44:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210720132951.1776-6-Martin.Harvey@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 20/07/2021 14:29, Martin Harvey wrote: > Unfortunately, this was not always a sufficient fix, and in some > low memory cases, NDIS and higher level drivers could bugcheck > attempting to copy MDL's and packet contents > (NETIO!RtlCopyMdlToMdlIndirect). > > This patch adds backpressure to the Rx path, such that it is only > possible to indicate a certain number of receive buffers in any one DPC. I think you first ought to make a new version of VifReceiverQueuePacket() that can return a boolean value to say whether you should queue more or not. Then XENNET can be the one to apply the backpressure (as it should be). > In such cases, another DPC is immediately scheduled, on the > understanding that DPC's for higher level drivers are likely to consume > those packets and free up resources in the interim. > > In such a backpressure state, the RX ring is not drained until all > packets in the intermediate queue have been indicated up the stack. > > Signed off by: Martin Harvey > --- > src/xenvif/receiver.c | 93 +++++++++++++++++++++++++++++++++---------- > 1 file changed, 73 insertions(+), 20 deletions(-) > > diff --git a/src/xenvif/receiver.c b/src/xenvif/receiver.c > index 7295646..964207b 100644 > --- a/src/xenvif/receiver.c > +++ b/src/xenvif/receiver.c > @@ -99,11 +99,14 @@ typedef struct _XENVIF_RECEIVER_RING { > BOOLEAN Connected; > BOOLEAN Enabled; > BOOLEAN Stopped; > + BOOLEAN Backpressured; > + BOOLEAN FinalFlush; > XENVIF_VIF_OFFLOAD_OPTIONS OffloadOptions; > ULONG BackfillSize; > PXENBUS_DEBUG_CALLBACK DebugCallback; > PXENVIF_THREAD WatchdogThread; > PLIST_ENTRY PacketQueue; > + LONG PacketQueueEstSize; //Conservative estimate. > KDPC QueueDpc; > ULONG QueueDpcs; > LIST_ENTRY PacketComplete; > @@ -147,6 +150,8 @@ struct _XENVIF_RECEIVER { > > #define XENVIF_RECEIVER_TAG 'ECER' > > +#define RX_BUFFERING_MAX 2048 //X-ref XenNet IN_NDIS_MAX (half in NDIS half elsewhere) > + > static FORCEINLINE PVOID > __ReceiverAllocate( > IN ULONG Length > @@ -1337,43 +1342,56 @@ __ReceiverRingSwizzle( > PXENVIF_VIF_CONTEXT Context; > LIST_ENTRY List; > PLIST_ENTRY ListEntry; > + BOOLEAN AllFlushed; > + ULONG PushedUpstream; > > Receiver = Ring->Receiver; > Frontend = Receiver->Frontend; > Context = PdoGetVifContext(FrontendGetPdo(Frontend)); > + AllFlushed = TRUE; > + PushedUpstream = 0; > > InitializeListHead(&List); > > - ListEntry = InterlockedExchangePointer(&Ring->PacketQueue, NULL); > + if (IsListEmpty(&Ring->PacketComplete) || Ring->FinalFlush) > + { > + Ring->PacketQueueEstSize = 0; > + ListEntry = InterlockedExchangePointer(&Ring->PacketQueue, NULL); > > - // Packets are held in the queue in reverse order so that the most > - // recent is always head of the list. This is necessary to allow > - // addition to the list to be done atomically. > + // Packets are held in the queue in reverse order so that the most > + // recent is always head of the list. This is necessary to allow > + // addition to the list to be done atomically. > > - while (ListEntry != NULL) { > - PLIST_ENTRY NextEntry; > + while (ListEntry != NULL) { > + PLIST_ENTRY NextEntry; > > - NextEntry = ListEntry->Blink; > - ListEntry->Flink = ListEntry->Blink = ListEntry; > + NextEntry = ListEntry->Blink; > + ListEntry->Flink = ListEntry->Blink = ListEntry; > > - InsertHeadList(&List, ListEntry); > + InsertHeadList(&List, ListEntry); > > - ListEntry = NextEntry; > - } > + ListEntry = NextEntry; > + } > > - while (!IsListEmpty(&List)) { > - PXENVIF_RECEIVER_PACKET Packet; > + while (!IsListEmpty(&List)) { > + PXENVIF_RECEIVER_PACKET Packet; > > - ListEntry = RemoveHeadList(&List); > - ASSERT3P(ListEntry, !=, &List); > + ListEntry = RemoveHeadList(&List); > + ASSERT3P(ListEntry, !=, &List); > > - RtlZeroMemory(ListEntry, sizeof (LIST_ENTRY)); > + RtlZeroMemory(ListEntry, sizeof (LIST_ENTRY)); > > - Packet = CONTAINING_RECORD(ListEntry, XENVIF_RECEIVER_PACKET, ListEntry); > - ReceiverRingProcessPacket(Ring, Packet); > + Packet = CONTAINING_RECORD(ListEntry, XENVIF_RECEIVER_PACKET, ListEntry); > + ReceiverRingProcessPacket(Ring, Packet); > + } > + } > + else > + { > + AllFlushed = FALSE; > } > I think the part below should now be split out into a separate function now; it's all getting a bit long to be inline. You might also consider a separate DPC that just does this second part so you can just use that in the case you need to defer. Paul > - while (!IsListEmpty(&Ring->PacketComplete)) { > + while ((!IsListEmpty(&Ring->PacketComplete)) > + && ((PushedUpstream < RX_BUFFERING_MAX) || Ring->FinalFlush)) { > PXENVIF_RECEIVER_PACKET Packet; > PXENVIF_PACKET_INFO Info; > PUCHAR BaseVa; > @@ -1381,6 +1399,8 @@ __ReceiverRingSwizzle( > PETHERNET_ADDRESS DestinationAddress; > ETHERNET_ADDRESS_TYPE Type; > > + PushedUpstream++; > + > ListEntry = RemoveHeadList(&Ring->PacketComplete); > ASSERT3P(ListEntry, !=, &Ring->PacketComplete); > > @@ -1536,9 +1556,33 @@ __ReceiverRingSwizzle( > Packet->TagControlInformation, > &Packet->Info, > &Packet->Hash, > - !IsListEmpty(&Ring->PacketComplete) ? TRUE : FALSE, > + ((!IsListEmpty(&Ring->PacketComplete)) > + && ((PushedUpstream < RX_BUFFERING_MAX) || Ring->FinalFlush)) ? TRUE : FALSE, > Packet); > } > + > + if (!IsListEmpty(&Ring->PacketComplete)) > + AllFlushed = FALSE; > + > + if (!AllFlushed) > + { > + //Re-run remainder from back of DPC queue. > + Ring->Backpressured = TRUE; > + if (KeInsertQueueDpc(&Ring->QueueDpc, NULL, NULL)) > + Ring->QueueDpcs++; > + } > + else > + { > + if ((Ring->Backpressured) && !Ring->FinalFlush) > + { > + //Not any more - restart dataflow from initial ring poll. > + Ring->Backpressured = FALSE; > + > + //PollDpc zeroed before final flush, don't queue it here. > + if (KeInsertQueueDpc(&Ring->PollDpc, NULL, NULL)) > + Ring->PollDpcs++; > + } > + } > } > > static FORCEINLINE VOID > @@ -1973,6 +2017,8 @@ __ReceiverRingQueuePacket( > ListEntry->Blink = Ring->PacketQueue; > New = ListEntry; > } while (InterlockedCompareExchangePointer(&Ring->PacketQueue, (PVOID)New, (PVOID)Old) != Old); > + > + InterlockedIncrement(&Ring->PacketQueueEstSize); > } > > static DECLSPEC_NOINLINE ULONG > @@ -1992,6 +2038,9 @@ ReceiverRingPoll( > if (!Ring->Enabled) > goto done; > > + if ((Ring->PacketQueueEstSize >= RX_BUFFERING_MAX) && !Ring->FinalFlush) > + goto done; > + > for (;;) { > BOOLEAN Error; > BOOLEAN Extra; > @@ -2949,8 +2998,12 @@ __ReceiverRingTeardown( > Ring->BackfillSize = 0; > Ring->OffloadOptions.Value = 0; > > + Ring->FinalFlush = TRUE; > + KeInsertQueueDpc(&Ring->QueueDpc, NULL, NULL); > KeFlushQueuedDpcs(); > RtlZeroMemory(&Ring->QueueDpc, sizeof (KDPC)); > + Ring->Backpressured = FALSE; > + Ring->FinalFlush = FALSE; > > ThreadAlert(Ring->WatchdogThread); > ThreadJoin(Ring->WatchdogThread); > From win-pv-devel-bounces@lists.xenproject.org Thu Jul 22 12:46:03 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 22 Jul 2021 12:46:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.159729.293738 (Exim 4.92) (envelope-from ) id 1m6Y5S-0007UW-Nm; Thu, 22 Jul 2021 12:46:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 159729.293738; Thu, 22 Jul 2021 12:46:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6Y5S-0007UP-Kp; Thu, 22 Jul 2021 12:46:02 +0000 Received: by outflank-mailman (input) for mailman id 159729; Thu, 22 Jul 2021 12:46:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6Y5Q-0007UJ-Rh for win-pv-devel@lists.xenproject.org; Thu, 22 Jul 2021 12:46:00 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7053e87e-21da-4d0f-bc98-7a866b1a740d; Thu, 22 Jul 2021 12:45:59 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 7053e87e-21da-4d0f-bc98-7a866b1a740d DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626957959; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=DjoK/L30UoPE0hVLgb6qiqK644nOH4nlpb8QRZGgk6E=; b=FjK62PZRKMdbHriz3h0CWlq8LOa7fUKkHPjeER8eWf1je2mRGdm9vUTF iHEIRRrpoIG5/PDCUTwelEaVcvao4pDXpLe+T6DpEC660d1n+hA5qU+N0 zA8Gzbtc7hjQ8nVuodQYn4hKtTCtOnwLI0SrN2kmBo58QSiqxIekDX3Fg A=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 0HuBP2cP6hXkPK0xkZIHUmBOGbVbdvyQR7U8wQXEkOyu9zHpIR9CVlAiJL8aZc7t4m9ASpajDd ydvCO9ig7+jnsasjRLoesiFELgGGmCM9K35S2ZdWL6RftRQZ16lprXz9idc+UBAQ+hkOJ5aAPq V8Noe76t7EYWUrXmLwrJliqenKjJlYZgfg2fjQtijTEofEKjby/BVketJ3YbGpWYzbnKVzwyVv EL4h7tpcTnZQwQr1dJ/odyT88NeFRbyak44l/023SdnW6VsAOyUWUIlUlRkGk9M+GX8yxIFOel e62/taiOGcEpCAEcNJUHj1ho X-SBRS: 5.1 X-MesageID: 48527896 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:c6T77q3Uy9WoBF03j9B58wqjBQdyeYIsimQD101hICG9Lfb2qy n+ppgmPEHP5Qr5AEtQ4+xoS5PwPE80kqQFrrX5XI3SEDUO3VHHEGgM1/qF/9SNIVycygcZ79 YaT0EcMqy/MbEZt7eC3ODQKb9Jq7PnkJxAx92ut0uFJTsaM52IhD0JbzpzZ3cGIzWucqBJcK Z0iPA3xQaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnY4j4uFxd0hZsy+2 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlUFtyssHfqWG1SYczGgNkHmpDq1L/sqq iKn/4UBbUw15oWRBDynfKi4Xi47N9k0Q6f9bbRuwqdnSW+fkNgNyMJv/MmTjLJr0Unp91yy6 RNwiaQsIdWFwrJmGDn68HPTAwCrDv9nZMOq59ks5Vka/pWVFaRl/1swGpFVJMbWC7q4oEuF+ djSMna+fZNaFufK3TUpHNmztCgVmk6Wk7ueDlJhuWFlzxN2HxpxUoRw8IS2n8G6ZImUpFBo+ DJKL5hmr1CRtIfKah9GOACS82qDXGle2OGDEuCZVD8UK0XMXPErJD6pL0z+eGxYZQNiIA/nZ zQOWkowlLau3ieffFm+ac7vywlbF/NLQgF+/sukqSR4IeMNYYDGRfzO2wTrw== X-IronPort-AV: E=Sophos;i="5.84,261,1620705600"; d="scan'208";a="48527896" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NPoFW1rODXFA2FhK7SH7uNuVpnfXSRhe2nupy4UUu9q2JgvuXMlQ5DVCHRTDPWwffyEEDyl+/h5SfzcnrNSt2CiaAOpKMnlOkYNBxJBOO7wm2p/9eYmnDGauhjrT6CWh6rQhLBr+ThjGJn7OIxejW1QUSCKu2XyeBUtmRNoIBnD4TSTnpjdbWbd3TBGpPl0L+WUujh86kSjwcRU9YKoz3d6VDYt6SEe1BsJeDsg77rMMYM7da9O5aetDoZNct9Za6dPVohP/AwTsu/L+Fm/73RcTrqVOZJNnX1ZVTILd3mbqpiIrKfVGZOpQPrVLR2OgZogsChmWdhaFSIbGrIo2kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DjoK/L30UoPE0hVLgb6qiqK644nOH4nlpb8QRZGgk6E=; b=W4rlA2L9B0ZjT+bZwDSQG/AmX8/p+8fGCp9Fl3jfddZ3RGWvX5PEKadY2r5pTS+JuH4Q7bpMpbgeIAwnNubD1p0G5udeEd77eRDQHOWa0cxrFIP4pNYDbWjwIOhmjHLvrWEaM8MPGjfnjK1X+khIIzR1Tct8aPrn5Ugua1swMyPNEiVYdPQOu7jRiNO/OnR1KBPf8C5rdUjQfqPEJw863RmPYO5C/eM+MmfEr4JgNQPu8rU95conpu0PrQ1fPw33/jD87K/zWKlummdpixNtLga0HSAkMqVbb8cmfbXTKBmdxfQx1hXwTlaLKka0ywe6ovLTVhxi4Adm9FjExZXIzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DjoK/L30UoPE0hVLgb6qiqK644nOH4nlpb8QRZGgk6E=; b=laPmHFq+4lwNAUfQpq4II1Yzgo9WFfu/HGUntNnH36nhtAbyI3L0nGBwLxulJpI1aDZPIXk6dSevnRqSbM3BtQ3RPi+ETEU2oD1rIzxp3HyXXiJmTcIVLvocPcKdeS1y6QJjKzOaPyJsD9EbQIzKJeibMgJLnKx87Ee85TOXWJA= From: Martin Harvey To: "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Subject: RE: [PATCH 3/6] In addition to preceding changes to ring disconnects, and associated logging, we also add some logging to check whether state change notifications are being sent in a timely manner between frontend and backend. Also a great assistance t... Thread-Topic: [PATCH 3/6] In addition to preceding changes to ring disconnects, and associated logging, we also add some logging to check whether state change notifications are being sent in a timely manner between frontend and backend. Also a great assistance t... Thread-Index: AQHXflRreFB6RLm0+kG5EG3PLp2CPatO7wxw Date: Thu, 22 Jul 2021 12:45:56 +0000 Message-ID: References: <20210720132951.1776-1-Martin.Harvey@citrix.com> <20210720132951.1776-3-Martin.Harvey@citrix.com> <1a20d9c4-af43-f4eb-74ad-18277d991d76@xen.org> In-Reply-To: <1a20d9c4-af43-f4eb-74ad-18277d991d76@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 46d2aba5-e7ce-4edb-ab96-08d94d0ea642 x-ms-traffictypediagnostic: CO1PR03MB5761: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: B8zb5OpQcsUNu5DVpdyyj0mqCR5MWTRtIf3psoOo5j+UFIYHu+KS/eUt797pfYqeluQdFv/XBSno6whAWZaucaGgpQxy61GKCWBYJwLo4+Mgw6Ruwk5c97rqWv1/I87xVxSSYB9OKijLbSXZUXmfmzUzxG84Geo3OE0xMvXTcPMyGLGURudKdPkx5/HtE9od6q3iSQBhDumCthz6bxMzav4hiv7Lc7Rz89kY7/I+H8pteIXO9RKJJSmZ2Wzfqwltxy/C0CuyQvab+Kli5xl+NLIKtldoWHZ7x33DNaYgVwTDaTLTu61q4cIbe+AHXfd6Fd1gb4XOA6BUiwrWny5o8OaABhxD/Fpy8RZXPXCekUdJHgxnhVkYCDWnIyMxIY0Bq8dq8istqQspMyGRH3FI2plvobKXZxD+djqRwPv7onY6+LI0Y0lXNT0TugEbw8ua5O4SBnB1etPyBSqCsmYclRC/CDpNBzlUavxsx/9bFnYUvoFttIvi8TGJeoR2gz27Czaoa/H/9sG5fHQ3WFheDLRXXcUb0/EPTwad8zfFDFP2rBrnTEvoAzmoouORZmKi6HHCsrtdd3HxDJroOYUkGroYqbvv68wlnVC/i78QGR0KK6arApLnz747I3O+MYIOYi1W4J5Ynv1uyttJ46Y9aNRJ5zqZqNND0XmJmbb+sxTutcY8CISKTxOwik9QO0sSz/n27N/AjwHaGn2/mZetyWYSb+cxz4ryOMRFniWR44A= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6347.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(396003)(376002)(136003)(346002)(39860400002)(26005)(186003)(316002)(5660300002)(86362001)(53546011)(38100700002)(110136005)(33656002)(52536014)(83380400001)(6506007)(2906002)(7696005)(122000001)(66556008)(66476007)(478600001)(76116006)(66446008)(71200400001)(64756008)(9686003)(55016002)(66946007)(44832011)(15650500001)(8676002)(8936002)(219693003)(38070700004);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RXU3b1l1Y200bWlBdGJ0M1E5VGszek9PQjRuNEYxMEtmMkRCS3NvNTRyNnky?= =?utf-8?B?aEpPS2xhWDh6Q29MMHB0SVk4VTcxYTQyR3NMSStwVDgwUGFnV2VPRlY1K0pN?= =?utf-8?B?dDVLektINTh6RHFiclVsNXlGdDYvL0hzcVh5MXJjV01ycXV3bEFvd0xOUDVP?= =?utf-8?B?UzFqamFJdWJlZUw1ZHRSWFNhUGhZTHZhbjY4SStWcVhueWpzSVY1RjdqMFlE?= =?utf-8?B?eXZtd09MMythQ0lDOG9uYWFUbGNDSTZDREpHdWlVWDZBeXl3M0lRNWVRTnhB?= =?utf-8?B?c0ZLZVFocHl1eXhVcGhxV1JDNktOR3p1emMrK3pFaUNNYjdsMDR6WmN0cC83?= =?utf-8?B?b0docDhKR280NjVpbVdUdW42L0xueHgzdXBPRmVBMjJTMEU3VFoyaysyWnV6?= =?utf-8?B?aENXTEYxTG1XR2gweGZHc1FKQnYzR2QxQWpSVWhEWVJjUmhOMUt2Rk1LNjMv?= =?utf-8?B?QW1VdkpEd0RBZlNWOTRCbXdCcnlUVEJuSm9BWjNrR1dOQ0UzOC9tSGRqa3RJ?= =?utf-8?B?alBlT1NxWmJqNVpxa0IzQWNVYUJXT045d1RaUUxpc2ZXdlZWSllCWU9rNnlu?= =?utf-8?B?NHBub3loWGxhbkRUdUhXVC85ZmtzZnJkSzZydkRHZGV0UEgycUNGWDNMa3Mv?= =?utf-8?B?K2dPcFAvTy9CV25DeVI4T1VocHlWOHpvU2pta1Jsa0pQc1JKVVZJbDlZY0F4?= =?utf-8?B?VzVNZENZOVQ3WkxXaVh6eURlUWZEL2ttZ0krTVJSdytVU3NKRk1BVitrZWdr?= =?utf-8?B?aGxuRDhuWnhlQmFkekk2NFREVnlFV2xnWTAvVGJGUVV4Nk11ZThuQWtqS2Va?= =?utf-8?B?NEhxVzhxbmtRZWI2czdwRVNXMVJIQU1RNHFVRXorV3dwS3h3Y2QxeWdGazZ0?= =?utf-8?B?SkZ2ZXBVUC92bjZjYWl3Y3g4aTN6a0pML2IrRzN0Q3JLNU94V1N2eVFPc1dI?= =?utf-8?B?bGF3VDAwUEJ4Uk1NSnFFcW41RWNwdTludmIwcGxoS09GQVVFUkRERjl5ZDFB?= =?utf-8?B?U2FraHovYzhKZW02dmgxb1hodEpBdERDVHlOWlplc1dWMmZiRDJQd3pzY3FL?= =?utf-8?B?azh0bnpCWlVnS2ZzRjNFbjVBeWJqUU52V2VoT3J1bWFIaStMZ25Tb3JKM2dL?= =?utf-8?B?Sm5BSEFxZ29ta3VjOFJVd29PcXdoZlFsTHU1dVdVLzFkbXRQQVI4NFZweC9q?= =?utf-8?B?MThvd3JEaGtodEZTbmZCdlJiczFmazdaa1NuOU43alpSRUNpQ09TLzVLMVd4?= =?utf-8?B?a3JhZVVONVUyWEh1ejN6REh1YnZRVXBBZHpqUk9kcWNzaTFlNW00QnJIYUJv?= =?utf-8?B?SCtyMnZrWWRZTlhSWjdXTkQ2bWpoUFpBYytEc2xwbHJuZ3dkYllKS21ON0ts?= =?utf-8?B?TE5FUWdLNlh3YmhqRGwzSVpZblFtc3dXK1JLQmQ0a3llRFhmS3pLYzRqaWgr?= =?utf-8?B?UUNQVEU5eDc3YjhmQmdYUnNQUHRxbVplY3RpWDB6cEI3V3BxUUg3NS9MOTE3?= =?utf-8?B?c0RhS1FxVUNVWG5YdmNDdzRaaDhvT2VINExVN0RWemlvdzZIdm9TNWVGT2pH?= =?utf-8?B?VDNDV3lzTmxxV1VXa2tRUllqV05CQ0IvNmFjampGcTRVQlFnT1BBQUQyS1pK?= =?utf-8?B?RUtPWG9KSndOaHdKaWxQUGJaL2x1dysxYWJCN2NMVjRVNFNqcDJTWWRMNjEv?= =?utf-8?B?azlBUGFRRk13c1lkemYvK2k1WFQyUVRVdnZIM1Yxb05KKzQrNlZEdUVlS3R2?= =?utf-8?Q?HwAaVY9rIvrxLQECT9r6lnL4VcdFD2I7UWYSvEX?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6347.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 46d2aba5-e7ce-4edb-ab96-08d94d0ea642 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2021 12:45:56.2390 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tswh277F0fE728ta5o5+ujMxUyp8mjo9z/eot/GrlxNrc3bS9J+sGrSnr77IaY16F30g/zf6Ir24plG1Sfh8GxbM1A0jN4ep7/wXJjuye/0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5761 X-OriginatorOrg: citrix.com DQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiB3aW4tcHYtZGV2ZWwgPHdpbi1w di1kZXZlbC1ib3VuY2VzQGxpc3RzLnhlbnByb2plY3Qub3JnPiBPbiBCZWhhbGYgT2YgUGF1bCBE dXJyYW50DQpTZW50OiAyMSBKdWx5IDIwMjEgMTg6MTgNClRvOiB3aW4tcHYtZGV2ZWxAbGlzdHMu eGVucHJvamVjdC5vcmcNClN1YmplY3Q6IFJlOiBbUEFUQ0ggMy82XSBJbiBhZGRpdGlvbiB0byBw cmVjZWRpbmcgY2hhbmdlcyB0byByaW5nIGRpc2Nvbm5lY3RzLCBhbmQgYXNzb2NpYXRlZCBsb2dn aW5nLCB3ZSBhbHNvIGFkZCBzb21lIGxvZ2dpbmcgdG8gY2hlY2sgd2hldGhlciBzdGF0ZSBjaGFu Z2Ugbm90aWZpY2F0aW9ucyBhcmUgYmVpbmcgc2VudCBpbiBhIHRpbWVseSBtYW5uZXIgYmV0d2Vl biBmcm9udGVuZCBhbmQgYmFja2VuZC4gQWxzbyBhIGdyZWF0IGFzc2lzdGFuY2UgdC4uLg0KDQo+ IE9uIDIwLzA3LzIwMjEgMTQ6MjksIE1hcnRpbiBIYXJ2ZXkgd3JvdGU6DQo+ID4gU2lnbmVkLW9m Zi1ieTogTWFydGluIEhhcnZleSA8bWFydGluLmhhcnZleUBjaXRyaXguY29tPg0KPiA+ICsgICAg Y29uc3QgVUxPTkdMT05HICAgICAgICAgICAgIFRpbWVvdXREZWx0YSA9IDEyMDAwMDsNCj4NCj4g TklUOiBJIGRvbid0IHRoaW5rIHlvdSByZWFsbHkgbmVlZCAnRGVsdGEnIGluIHRoZSBuYW1lLCBq dXN0ICdUaW1lb3V0JyANCj4gd291bGQgc3VmZmljZSAoYW5kIEkgdGhpbmsgaXQgd291bGQgYmUg bW9yZSBjb25zaXN0ZW50IHdpdGggb3RoZXIgY29kZSkuDQoNClllcywgYnV0IHVuZm9ydHVuYXRl bHkgdGhhdCBjb25mbGljdHMgd2l0aCB0aGUgdGltZW91dCB1c2VkIGluIHRoZSBLZVdhaXRGb3Ig Li4uDQoNClBlcmhhcHMgbW9yZSBsb2dpY2FsIGFuZCBsZXNzIGNvbmZ1c2luZyB3b3VsZCBiZSAi VG90YWxUaW1lb3V0Ii4NCg0KPiA+ICsgICAgaWYgKFRpbWVEZWx0YSA+PSBUaW1lb3V0RGVsdGEp IHsNCj4gPiArICAgICAgICBFcnJvcigiJXMgdGltZWQgb3V0LlxuIiwgX19Gcm9udGVuZEdldEJh Y2tlbmRQYXRoKEZyb250ZW5kKSk7DQo+ID4gKyAgICB9DQoNCj4gTm8gbmVlZCBmb3IgYnJhY2Vz IG9uIHNpbmdsZS1saW5lIGlmcyBhbmQgbm8gZnVsbCBzdG9wIG5lZWRlZCBpbiB0aGUgbG9nIG1l c3NhZ2UuIFNpbmNlIGl0J3Mgbm90IGluIGNvbnRleHQgYW5kIEkgY2FuJ3QgcmVtZW1iZXIuLi4g ZG9lcyA+IHRoZSBwYXRoIGluY2x1ZGUgdGhlIGFjdHVhbCAnc3RhdGUnIGtleSBuYW1lPyBJdCdz IGEgbGFjayBvZiBjaGFuZ2UgaW4gdGhhdCBwYXJ0aWN1bGFyIGtleSB3ZSdyZSB0cmlnZ2VyaW5n IG9uIGhlcmUuDQoNCkFoLiBJdCdzIHB1bGxlZCBvdXQgb2YgeGVuYnVzIHN0b3JlLCBzbyBJIHRo aW5rIG5vdC4gQ2hlY2tpbmcgaGUgcHJlY2VkaW5nIGNvZGUsIHRoZSBzdG9yZSB3YXRjaCBpcyBh ZGRlZCB0byAic3RhdGUiLCB3aGljaCBpcyBhIGxldmVsIGJlbG93IHRoZSBiYWNrZW5kIHBhdGgs IHdoaWNoIGFsc28gc2VlbXMgdG8gaW5kaWNhdGUgbm90Lg0KDQpDb3VsZCBhZGQgc29tZXRoaW5n IGV4dHJhIGluIHRoZSBkYmcgbWVzc2FnZSBhYm91dCAic3RhdGUgY2hhbmdlIHRpbWVkIG91dCI/ DQoNCk1ILg0K From win-pv-devel-bounces@lists.xenproject.org Thu Jul 22 12:54:46 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 22 Jul 2021 12:54:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.159736.293742 (Exim 4.92) (envelope-from ) id 1m6YDt-0008M9-Db; Thu, 22 Jul 2021 12:54:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 159736.293742; Thu, 22 Jul 2021 12:54:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6YDt-0008M2-Ac; Thu, 22 Jul 2021 12:54:45 +0000 Received: by outflank-mailman (input) for mailman id 159736; Thu, 22 Jul 2021 12:54:44 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6YDr-0008Lw-Vp for win-pv-devel@lists.xenproject.org; Thu, 22 Jul 2021 12:54:44 +0000 Received: from smtp-fw-2101.amazon.com (unknown [72.21.196.25]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 74d1eff9-d361-45f6-9d99-7692e6367737; Thu, 22 Jul 2021 12:54:43 +0000 (UTC) Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-2a-41350382.us-west-2.amazon.com) ([10.43.8.2]) by smtp-border-fw-2101.iad2.amazon.com with ESMTP; 22 Jul 2021 12:54:36 +0000 Received: from EX13D32EUC004.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan3.pdx.amazon.com [10.236.137.198]) by email-inbound-relay-2a-41350382.us-west-2.amazon.com (Postfix) with ESMTPS id B9F1DC0B40; Thu, 22 Jul 2021 12:54:34 +0000 (UTC) Received: from EX13D32EUC003.ant.amazon.com (10.43.164.24) by EX13D32EUC004.ant.amazon.com (10.43.164.121) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Thu, 22 Jul 2021 12:54:32 +0000 Received: from EX13D32EUC003.ant.amazon.com ([10.43.164.24]) by EX13D32EUC003.ant.amazon.com ([10.43.164.24]) with mapi id 15.00.1497.023; Thu, 22 Jul 2021 12:54:32 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 74d1eff9-d361-45f6-9d99-7692e6367737 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.co.uk; i=@amazon.co.uk; q=dns/txt; s=amazon201209; t=1626958483; x=1658494483; h=from:to:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version:subject; bh=uV1etv2xQXxjIxMAMS6FMHCqjKfV6B0IoKmcjijSZJw=; b=XZBXZoOWihnD5MJHM8OaPMEhJzbYR25lw5+ebLnyT617Il9zmq5Uf+Bf wQQ1fW3t4yLFl/NAjXP1yhbtkNqfa5TLpFKL9l2lDJyqFc6gNOphj46SX py0TF/9oOY12bMPQ5IdEm46Sukls65lg9lTfOhy+ggRD3/QkFSMvDli69 I=; X-IronPort-AV: E=Sophos;i="5.84,261,1620691200"; d="scan'208";a="124173269" Subject: RE: [PATCH 3/6] In addition to preceding changes to ring disconnects, and associated logging, we also add some logging to check whether state change notifications are being sent in a timely manner between frontend and backend. Also a great a... Thread-Topic: [PATCH 3/6] In addition to preceding changes to ring disconnects, and associated logging, we also add some logging to check whether state change notifications are being sent in a timely manner between frontend and backend. Also a great a... From: "Durrant, Paul" To: Martin Harvey , "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Thread-Index: AQHXflSHfMeLwuvkTkacx8RkoBZTSatO8l4AgAACItA= Date: Thu, 22 Jul 2021 12:54:32 +0000 Message-ID: References: <20210720132951.1776-1-Martin.Harvey@citrix.com> <20210720132951.1776-3-Martin.Harvey@citrix.com> <1a20d9c4-af43-f4eb-74ad-18277d991d76@xen.org> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.166.209] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiB3aW4tcHYtZGV2ZWwgPHdpbi1w di1kZXZlbC1ib3VuY2VzQGxpc3RzLnhlbnByb2plY3Qub3JnPiBPbiBCZWhhbGYgT2YgTWFydGlu IEhhcnZleQ0KPiBTZW50OiAyMiBKdWx5IDIwMjEgMTM6NDYNCj4gVG86IHBhdWxAeGVuLm9yZzsg d2luLXB2LWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IFN1YmplY3Q6IFJFOiBbRVhURVJO QUxdIFtQQVRDSCAzLzZdIEluIGFkZGl0aW9uIHRvIHByZWNlZGluZyBjaGFuZ2VzIHRvIHJpbmcg ZGlzY29ubmVjdHMsIGFuZA0KPiBhc3NvY2lhdGVkIGxvZ2dpbmcsIHdlIGFsc28gYWRkIHNvbWUg bG9nZ2luZyB0byBjaGVjayB3aGV0aGVyIHN0YXRlIGNoYW5nZSBub3RpZmljYXRpb25zIGFyZSBi ZWluZw0KPiBzZW50IGluIGEgdGltZWx5IG1hbm5lciBiZXR3ZWVuIGZyb250ZW5kIGFuZCBiYWNr ZW5kLiBBbHNvIGEgZ3JlYXQgYS4uLg0KPiANCj4gQ0FVVElPTjogVGhpcyBlbWFpbCBvcmlnaW5h dGVkIGZyb20gb3V0c2lkZSBvZiB0aGUgb3JnYW5pemF0aW9uLiBEbyBub3QgY2xpY2sgbGlua3Mg b3Igb3Blbg0KPiBhdHRhY2htZW50cyB1bmxlc3MgeW91IGNhbiBjb25maXJtIHRoZSBzZW5kZXIg YW5kIGtub3cgdGhlIGNvbnRlbnQgaXMgc2FmZS4NCj4gDQo+IA0KPiANCj4gLS0tLS1PcmlnaW5h bCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogd2luLXB2LWRldmVsIDx3aW4tcHYtZGV2ZWwtYm91bmNl c0BsaXN0cy54ZW5wcm9qZWN0Lm9yZz4gT24gQmVoYWxmIE9mIFBhdWwgRHVycmFudA0KPiBTZW50 OiAyMSBKdWx5IDIwMjEgMTg6MTgNCj4gVG86IHdpbi1wdi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0 Lm9yZw0KPiBTdWJqZWN0OiBSZTogW1BBVENIIDMvNl0gSW4gYWRkaXRpb24gdG8gcHJlY2VkaW5n IGNoYW5nZXMgdG8gcmluZyBkaXNjb25uZWN0cywgYW5kIGFzc29jaWF0ZWQgbG9nZ2luZywNCj4g d2UgYWxzbyBhZGQgc29tZSBsb2dnaW5nIHRvIGNoZWNrIHdoZXRoZXIgc3RhdGUgY2hhbmdlIG5v dGlmaWNhdGlvbnMgYXJlIGJlaW5nIHNlbnQgaW4gYSB0aW1lbHkgbWFubmVyDQo+IGJldHdlZW4g ZnJvbnRlbmQgYW5kIGJhY2tlbmQuIEFsc28gYSBncmVhdCBhc3Npc3RhbmNlIHQuLi4NCj4gDQo+ ID4gT24gMjAvMDcvMjAyMSAxNDoyOSwgTWFydGluIEhhcnZleSB3cm90ZToNCj4gPiA+IFNpZ25l ZC1vZmYtYnk6IE1hcnRpbiBIYXJ2ZXkgPG1hcnRpbi5oYXJ2ZXlAY2l0cml4LmNvbT4NCj4gPiA+ ICsgICAgY29uc3QgVUxPTkdMT05HICAgICAgICAgICAgIFRpbWVvdXREZWx0YSA9IDEyMDAwMDsN Cj4gPg0KPiA+IE5JVDogSSBkb24ndCB0aGluayB5b3UgcmVhbGx5IG5lZWQgJ0RlbHRhJyBpbiB0 aGUgbmFtZSwganVzdCAnVGltZW91dCcNCj4gPiB3b3VsZCBzdWZmaWNlIChhbmQgSSB0aGluayBp dCB3b3VsZCBiZSBtb3JlIGNvbnNpc3RlbnQgd2l0aCBvdGhlciBjb2RlKS4NCj4gDQo+IFllcywg YnV0IHVuZm9ydHVuYXRlbHkgdGhhdCBjb25mbGljdHMgd2l0aCB0aGUgdGltZW91dCB1c2VkIGlu IHRoZSBLZVdhaXRGb3IgLi4uDQo+IA0KPiBQZXJoYXBzIG1vcmUgbG9naWNhbCBhbmQgbGVzcyBj b25mdXNpbmcgd291bGQgYmUgIlRvdGFsVGltZW91dCIuDQoNClllcywgdGhhdCBsb29rcyBiZXR0 ZXIuDQoNCj4gDQo+ID4gPiArICAgIGlmIChUaW1lRGVsdGEgPj0gVGltZW91dERlbHRhKSB7DQo+ ID4gPiArICAgICAgICBFcnJvcigiJXMgdGltZWQgb3V0LlxuIiwgX19Gcm9udGVuZEdldEJhY2tl bmRQYXRoKEZyb250ZW5kKSk7DQo+ID4gPiArICAgIH0NCj4gDQo+ID4gTm8gbmVlZCBmb3IgYnJh Y2VzIG9uIHNpbmdsZS1saW5lIGlmcyBhbmQgbm8gZnVsbCBzdG9wIG5lZWRlZCBpbiB0aGUgbG9n IG1lc3NhZ2UuIFNpbmNlIGl0J3Mgbm90IGluDQo+IGNvbnRleHQgYW5kIEkgY2FuJ3QgcmVtZW1i ZXIuLi4gZG9lcyA+IHRoZSBwYXRoIGluY2x1ZGUgdGhlIGFjdHVhbCAnc3RhdGUnIGtleSBuYW1l PyBJdCdzIGEgbGFjayBvZg0KPiBjaGFuZ2UgaW4gdGhhdCBwYXJ0aWN1bGFyIGtleSB3ZSdyZSB0 cmlnZ2VyaW5nIG9uIGhlcmUuDQo+IA0KPiBBaC4gSXQncyBwdWxsZWQgb3V0IG9mIHhlbmJ1cyBz dG9yZSwgc28gSSB0aGluayBub3QuIENoZWNraW5nIGhlIHByZWNlZGluZyBjb2RlLCB0aGUgc3Rv cmUgd2F0Y2ggaXMNCj4gYWRkZWQgdG8gInN0YXRlIiwgd2hpY2ggaXMgYSBsZXZlbCBiZWxvdyB0 aGUgYmFja2VuZCBwYXRoLCB3aGljaCBhbHNvIHNlZW1zIHRvIGluZGljYXRlIG5vdC4NCj4gDQo+ IENvdWxkIGFkZCBzb21ldGhpbmcgZXh0cmEgaW4gdGhlIGRiZyBtZXNzYWdlIGFib3V0ICJzdGF0 ZSBjaGFuZ2UgdGltZWQgb3V0Ij8NCj4gDQoNClllcywgdGhhdCdzIGNsZWFyZXIuDQoNCiAgUGF1 bA0KDQo+IE1ILg0K From win-pv-devel-bounces@lists.xenproject.org Thu Jul 22 18:21:54 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 22 Jul 2021 18:21:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.159824.293911 (Exim 4.92) (envelope-from ) id 1m6dKR-0002On-I0; Thu, 22 Jul 2021 18:21:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 159824.293911; Thu, 22 Jul 2021 18:21:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6dKR-0002Og-Ew; Thu, 22 Jul 2021 18:21:51 +0000 Received: by outflank-mailman (input) for mailman id 159824; Thu, 22 Jul 2021 18:21:49 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6dKP-0002Oa-DB for win-pv-devel@lists.xenproject.org; Thu, 22 Jul 2021 18:21:49 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id aba17e4d-eb19-11eb-909d-12813bfff9fa; Thu, 22 Jul 2021 18:21:47 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: aba17e4d-eb19-11eb-909d-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626978107; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=a9d4mK/2+mVks8kVrGb199Oxi0R1apeQFkuFEDDvBuQ=; b=IQ6d0ENrCgy2Z0+h2OUvDz6yrqfyqGlMsoaDLZA9Tx/YZ/4E/VVKif7F aghuG/cgqpfA6Vtpz1XIdeoylTIxdWyLWAubgEK0j/328fsiEetx/ZSbp qnnNfv9jg/Pr+LJWFOKlBGbOxZEosrCzagmcf9Det6DJzdezDtVqjLs0U k=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: ZMNWoSKORf9+stY2nzS8EaA0frWwf/30F6UGvBkC7N+cDVZ1u3Rnn0Izo2dumpyyk7KigArjpy 4a8mF1K6fW8j/nrKy3djLb5R4I9kI9bDPL/Mti0KAMSl4WBaQ0ctKsgeDn6sKYzzpeMlD4Ym1W LeJ6tOfSva+/t+mCReoSB2IBENS9dhsoia1G/nLa8p577+3qOYXI+/SZw5lijw7apbgswWyx1Q 3lasxKLAZT8hqhtz9HnpdTK65SAmstxtsos7Z5Fi1hXhKahkztPbSv8S/qgMWfy0rCFZXWolAx l77gbvMNaIfugyfVeTPQFX5C X-SBRS: 5.1 X-MesageID: 50552304 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:yyWC0qiIH6LGYKHN13tZRsp093BQX2913DAbv31ZSRFFG/FwyP rAoB1L73PJYWgqNU3IwerwQpVoMkmsiKKdhrNhcotKPTOW9FdASbsN0WKM+UyHJ8STzJ8/6U 4kSdkENDSSNyk1sS+Z2njALz9I+rDum8rI5ds2jU0dNT2CA5sQtzuRYTzrd3GeMTM2YqbRY6 DsgvavyQDQG0g/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZebxp/hZMZtU TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESttu/oXvUjZ1SxhkFxnAid0idvrD AKmWZmAy1H0QKSQohym2qq5+Cv6kd215ao8y7lvZKqm72HeNt9MbsbuWsRSGqm12Mw+N57y6 5FxGSfqt5eCg7Bhj3045zSWwhtjVfcmwtrrQc/tQ0obWIlUs4ZkWXfxjImLL4QWCbhrIw3Gu hnC8/RoP5QbFOBdnjc+m1i2salUHg/FgqPBhFqgL3e7xFG2HRii0cIzs0WmXkNsJo7Vplf/u zBdqBljqtHQMMaZb90QO0BXcy0AGrQRg+kChPYHX33UKUcf37doZ/+57s4oOmsZZwT1ZM33I /MVVtJ3FRCDH4Gyff+qKGj1yq9DVlVcQ6duv221qIJz4EUHoCbQBFrYGpe4Pednw== X-IronPort-AV: E=Sophos;i="5.84,261,1620705600"; d="scan'208";a="50552304" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AbQ4KQ9aCad7DHDWf2/b1/6hdAWTzmXgQjL7+TwkVS2vyExXawHqcZehOTyPwIGbnKDyTlmZl/Nuu+jUjPZI9bR+cbvqaGuiC+gHq/oNqyax5Mcbm4C0tpQ9QeoXbjpW6dv5gX+O2QDCYapeuo5UFApl03JACS273UA9VvoHkho+m0HOzNK0brwf68AKL6a8RV1f9D3rG+V8GwS0Oh/PqwrMDM19G90ajdaw7aw/KQci7TH9AB7AVKFINXrktUEVJoqg4afh0SOJ+g6Us61WW/BHWOn3lemG9yFiQdlLC2ewinXuP/Up4vY1q1O9JTxdjeLjDyYEFhspVuptDDXbCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a9d4mK/2+mVks8kVrGb199Oxi0R1apeQFkuFEDDvBuQ=; b=cVv364dUDdf+y/0fRnKWv60o7zaXOqtElNx6aejUtCmD4Zv3PSgEWhkfidctDK+6n4cqdcCzLWIo0HrtL8+/MjY8SqmcJDlsp8ZAkDCuhFpv+xspeeykS6U8VaGsuz36iAl5uJfoS4+leK7zZEIVYczDQ2bgbcOCTzqYwfdSKXxQPn+8O92v5Ayrcji1arpmWUH1nQKJWdaYC40glDzoc9Zbi5f/TNJRr4l9QFQ9RDg6bHq5dBdmFbfwh0YfkGNNYDQxBu2fu3snLFTFU5OCXbHJhRULSZyK6kmYTi+6BTBbPJ8F535kjTmeiLpRshmBZiczManCkhb+/ebNMXtKWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a9d4mK/2+mVks8kVrGb199Oxi0R1apeQFkuFEDDvBuQ=; b=ttEXTs9eWc+EweiBj7+7EnL/lVUN+f+pP5JvQNfoFsrAS+n9JRysmqQ33uPN0MxjyaYyBfRrAkMPEDoNMjRLISEmixuc7UM63kXGDxK9acpnFpjyJU/dsRzFEqz16oR9MN+qt8hn4mxSTIMNJ1rHgTXGMd3t0iNjEB7i0QDkwiw= From: Martin Harvey To: "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Subject: RE: [PATCH 2/6] Since Rx/Tx ring disconnects now no longer wait forever, we add some logging to catch those cases where the disconnect has timed out, indicating how many requests are still in the ring. This aids greatly with customer debugging. Thread-Topic: [PATCH 2/6] Since Rx/Tx ring disconnects now no longer wait forever, we add some logging to catch those cases where the disconnect has timed out, indicating how many requests are still in the ring. This aids greatly with customer debugging. Thread-Index: AQHXfWtkGU/pmVsFfkKcNK0c677mQKtNrBUAgAFCDBCAAAKggIAAYPew Date: Thu, 22 Jul 2021 18:21:37 +0000 Message-ID: References: <20210720132951.1776-1-Martin.Harvey@citrix.com> <20210720132951.1776-2-Martin.Harvey@citrix.com> <11b1c340-6460-7c17-bf42-6ea624f1bd3f@xen.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4fe9c69a-0efa-45e0-db50-08d94d3d8b9d x-ms-traffictypediagnostic: MWHPR03MB3215: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:175; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WFHSbNdwkslpIyaa7x3ki9/ZbKiepO6sv40oyfFQHvSX4YVd+sTEpNcnCQ0oemw35DLun5x1a5videU4vTwVdcmAR0tw9lxu6jGyR6qk2uLfuf62oIWLPHKjma4ZZvAlvcg0c1CbHFz85u0UVLrJ8DBoNm5lj0EArWe6JHG+Z2gNCx8lkjvuijopILn4Bf83S5cflzIxrbTQ7OIS/NpYV9oIAHcEdK+SBqP7NfHoDrkmsun3tmE92xezQYQSXFw+KXMiQ0JkzafL5bUqoxgxNbpoJtd4JckW/xYMOoe2KdvyoWdC6A7XYMKqiUK/8SifTDLVjAB1QEFXvEmEdXf72PYQZGWhO8ivO+0V58NRFse9fBcaqBz0H1hjz52iQ7hSCuJv1f90lX2zlPi6hIsETYA3QVYfzECfYGGyViiZf7TCMEtCwhA6HQ7M4zfWObxGPcOtQdm0I2x7LFF3KayedQ5mR54HB3IIRihIfXd58W3Eo6/ATCcHvOYhZ06TDbbc7al5hTghZS5iozdAXxNacUstyFXtViVx4vn0tQsNvjt3NDxRg43JV7Cq1vQ+7u3vSrbxwR3ulZ6/b6N5qwvAr/dQtDCxLTQ+cnuLzeW83WdZaM6SECPFCVY5PzgSKK9tg2HoPorxIzFpmz3hwRLQuf1WxTKGEM6n1t6liFSJ1s94joWnsjb6wbp99auQEKI/qJycZYfr5BW9cuT/lDa0Y1HjluAGsIrUHj6FA7Gw1Ac= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6347.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(376002)(366004)(346002)(396003)(39860400002)(55016002)(26005)(71200400001)(8936002)(122000001)(33656002)(478600001)(66476007)(53546011)(316002)(66446008)(44832011)(38100700002)(4744005)(66556008)(66946007)(110136005)(64756008)(186003)(83380400001)(86362001)(76116006)(52536014)(2906002)(7696005)(5660300002)(6506007)(9686003)(8676002)(219693003)(38070700004);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SzRqUzU2cWFxb3luUitiYUF3RldKcktYS0ErWXlnMGl3aHJXV1hsRTMwQlFL?= =?utf-8?B?RW1qRXowUGU1djczRFQ5TXFLUXk1WWd6ajh0TVEvUkZLUGNwTDhIcExNR1Nk?= =?utf-8?B?cWtZVHNidGswODVmdHh0T244Vys4K2pDNFJ1eExJNnZubEFNNDJwUCtCT1hU?= =?utf-8?B?RTNQd3hYN1M1SExXbDVmVGFzQWc2MzRFbFlNMVp4anFoL3NVTm80aldJNUtZ?= =?utf-8?B?emc2amxrclZBRmlzS3NxN2R3V1ZDRlBtWkpCWWdzTTVHNWNFTzBNOThOVTI3?= =?utf-8?B?c3RtWW1sWElXZGh0dVVHV0FhQkNPZGtuOTBZNk9HYWtqdzJsT2F1R3NVNnJy?= =?utf-8?B?TUhWQWRZSFE1Y2hGNEttVjJaRllmS1VkSGY5cEZqdVVwaE1iQWJYeUNxRnNs?= =?utf-8?B?SE1hSk5FMllsejA1RURJS2ZiT1hzdldUY09JMXBaSFY2c3ZueC9lZVBRUzlr?= =?utf-8?B?aUlkMVVnWVZuMkRndCt6SlRWVnJodk5yL1pjU1JJeHlUNFh4VWs0a2p3SS9K?= =?utf-8?B?RVQvZnozQ2FYYnNocUtYbEYyUERleVlxMWZ4TWNPOFo1MWxlN3ZVbHc4RE9P?= =?utf-8?B?cUJKY0pGNlM5blJBZ2Z1aXB4cWIrdkkwdUZMSXVWRUczQng3VmVQdlhKWnNp?= =?utf-8?B?OWFZTUVOTGZVTHBNeEZtd1AzNmowM0d4MzVZNm51VFNSYVo3U1A3MkZVR0Ra?= =?utf-8?B?WWpub2pxenhBTW5GUkFRY01LaktTSzRLc2J6aTJVcG1ia1JQY0krTzBPYTV3?= =?utf-8?B?NHlmMEQza0poR25xYU1yNjNFc2lXTFdoVzhNQk1FblFRWFJZZm41ajdOcnVq?= =?utf-8?B?VUFQQVNYYnFJTnR2dS9qc0ZURWxZMnJOMCttVFNnSmtMSDVNYW43MWtBWE1m?= =?utf-8?B?bHM2RXRYNmhXT3RFSlBlaXE3TVZCVmNLeU5ZZ3F3ZS9mTisvanhIcW80TkpV?= =?utf-8?B?ZmJKZjkyRTUrK0lpNEE5NzJuR1d3T01zVnk4U1dTbUJZN3ZYOE8wUWdESWdo?= =?utf-8?B?YkhFV0dTTEROTFBua1dQb2JaQUxHbStsUE84dzI1aDgwWEVhNnRJdU41eFFl?= =?utf-8?B?aXBNUU5LYlIwOXV0TEIzczNQVXV0UWg5Q0s2aTVKR3NnSVhyYTZCbGJTSTNQ?= =?utf-8?B?UkdSUnhIRmlhSzUxQnI0bGNVWmVidTdKZVdPTUc5bjFlNzduNk94L3pJVHFw?= =?utf-8?B?aVVoUzNEQkpKandReWZXdjRYNFE5MzYwalFCUXQzN2ZQZUE4OHNGVTdudkhJ?= =?utf-8?B?Y09MOFh3NWdIZ3VDNFhvSmNVS1NCWG4vRDNiTjR4RmRTZTl1Sm1qYzk4MTBk?= =?utf-8?B?clZLWUs0bmptVW84TU9sc2YzM0tvL2U5VGdsSlR3UlZxM0JETVRRV2RBQ3hu?= =?utf-8?B?bzBmRUJGazlXWmJKM0tiRlpoYWZJaXkrVDFhRTk1QlBvSTJLR1pTenJnSDVl?= =?utf-8?B?VTNTV2I4T3lNdUFrZXJBWFFVQVV0aTdhMUQvOFBicVlrWThXN2RCeWRPUmhL?= =?utf-8?B?U2QzWXk4dzFuTEphUHJ6S29qUmN2enkvM3FlZEl2RUlOYUk5dFVYUEZENFdG?= =?utf-8?B?RXZ1QWhSNW9OZmswZ212eUthN2RUOTV0eTl4aXZ5a3NQeU04ZklkR1V5ek1T?= =?utf-8?B?UFBnczZKeFRUYkxBRDUxc2N6MVZLMHM1V0VvSUQ0ZFJHMmNIT1FLVythbm5J?= =?utf-8?B?NktwYWVIVG5ldlJ6U0EwT3oxa0FjU2NGQmxzWGNZSEpmbEc1OTg2N1pMUGhr?= =?utf-8?Q?nfiSNYrDKoIq9sYATw=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6347.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4fe9c69a-0efa-45e0-db50-08d94d3d8b9d X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2021 18:21:37.8754 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7FhTXasg0PZnEwDXlTR7SVgF6dfWfdseW3BI5UF2MuvhvTwJD0knr4pkdUJVf6HNXtA0AzzwmIHQp+jv2pyIY+tGAWA9bVFJdYVSPYZGRkY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB3215 X-OriginatorOrg: citrix.com DQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBQYXVsIER1cnJhbnQgPHhhZGlt Z25pa0BnbWFpbC5jb20+IA0KU2VudDogMjIgSnVseSAyMDIxIDEzOjM0DQpUbzogTWFydGluIEhh cnZleSA8bWFydGluLmhhcnZleUBjaXRyaXguY29tPjsgd2luLXB2LWRldmVsQGxpc3RzLnhlbnBy b2plY3Qub3JnDQpTdWJqZWN0OiBSZTogW1BBVENIIDIvNl0gU2luY2UgUngvVHggcmluZyBkaXNj b25uZWN0cyBub3cgbm8gbG9uZ2VyIHdhaXQgZm9yZXZlciwgd2UgYWRkIHNvbWUgbG9nZ2luZyB0 byBjYXRjaCB0aG9zZSBjYXNlcyB3aGVyZSB0aGUgZGlzY29ubmVjdCBoYXMgdGltZWQgb3V0LCBp bmRpY2F0aW5nIGhvdyBtYW55IHJlcXVlc3RzIGFyZSBzdGlsbCBpbiB0aGUgcmluZy4gVGhpcyBh aWRzIGdyZWF0bHkgd2l0aCBjdXN0b21lciBkZWJ1Z2dpbmcuDQoNCg0KPiBXaHkgbm90LiBZb3Ug Y2FuIGJhc2ljYWxseSBjb3B5IHdoYXQgVHJhbnNtaXR0ZXJSaW5nV2F0Y2hkb2coKSBkb2VzLCBj YW4ndCB5b3U/IEkuZS4ganVzdCBjYWxsDQo+IA0KPiBYRU5CVVNfREVCVUcoVHJpZ2dlciwNCj4g ICAgICAgICAgICAgICZUcmFuc21pdHRlci0+RGVidWdJbnRlcmZhY2UsDQo+ICAgICAgICAgICAg ICBSaW5nLT5EZWJ1Z0NhbGxiYWNrKTsNCg0KPiBUaGF0IHNob3VsZCBnZXQgeW91IHRoZSBsb2dn aW5nIHlvdSB3YW50LCBzaG91bGRuJ3QgaXQ/DQoNClRCSCwgZ2l2ZW4gdGhhdCBpdCB3YXMgc2V2 ZXJhbCBtb250aHMgYWdvLCBJIGNhbid0IHJlbWVtYmVyISEhIDxjcnk+IQ0KDQpNSC4NCg== From win-pv-devel-bounces@lists.xenproject.org Fri Jul 23 11:00:23 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 23 Jul 2021 11:00:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.160071.294359 (Exim 4.92) (envelope-from ) id 1m6suk-000876-7t; Fri, 23 Jul 2021 11:00:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 160071.294359; Fri, 23 Jul 2021 11:00:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6suk-00086z-4f; Fri, 23 Jul 2021 11:00:22 +0000 Received: by outflank-mailman (input) for mailman id 160071; Fri, 23 Jul 2021 11:00:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6sui-00086p-9G for win-pv-devel@lists.xenproject.org; Fri, 23 Jul 2021 11:00:20 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 37f41816-5d21-4fce-a19d-4643cccf555b; Fri, 23 Jul 2021 11:00:18 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 37f41816-5d21-4fce-a19d-4643cccf555b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1627038018; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=1WlqjpSEg3CzCUWbZ6/KMfWzMfpAN9JmhrjoFwGGgs0=; b=FZYWAK7z5jLA4Sz/X5lHukvmAlFF9dhCDbEx72NAsogOjOxjq66zAeCU /qeUkWVm7KelbznDq8cIjV3aVlUO6KNJ4FAIcj11XtoA7RugfqS/kmvyf 6b26UJD3m24jqD3vrpBSBJF84JjEdsTFdz2BpDV5wr1FQu9KRnY+yd4YK Y=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 6kZgdVKq9H5znN3Y1iS9gOpGqagVfuC3eZx5gmkPaOPtDzjFKAhktPsZzjv8brwe9c87cmn14g IHZ30bLBc0KpfawJlGzo1ExDNoLMKllkRMIoGl2D7WPwrsJpyn/L3f2/otYzpJsUN1FKNx9QbI I004210MRkWAsePGQIGP4VMXFzX7uixQpLlRlqHm5dgll1xHMpgU5bcqTywj++3aBdGVS4wdtA mbOoL5oADlBQ2t2x7oy4EoQSEI5mwotTs2qGNdzVoO3m6sftE65YLfhM6bMYRu09QNg7doEuWl nsyJbfQHOb7CzgjH2kZFPsAp X-SBRS: 5.1 X-MesageID: 48924050 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:ZyVZmanPV/iep5Lv1UlduOVOWpbpDfOCimdD5ihNYBxZY6Wkfp +V8sjzhCWatN9OYh0dcIi7SdW9qXO1z+8Q3WBjB8bcYOCAghroEGgC1/qt/9SEIUzDH4FmpN 9dmsRFeb/N5B1B/LvHCWqDYpYdKbu8gduVbI7lph8HJ2wLGsJdBkVCe3ym+yVNNVN77PECZf 2hD7981kOdkAMsH6KG7xc+Lo3+juyOsKijTQ8NBhYh5gXLpyiv8qTGHx+R2Qpbey9TwJ85mF K10DDR1+GGibWW2xXc32jc49B9g9360OZOA8SKl4w8NijssAC1f45sMofy/gzd4dvfrWrCou O85CvIDP4DrU85uVvF+CcF7jOQlArGLUWSkWNwz0GT+vARDwhKdfapzbgpAycxrXBQ4e2UmZ g7r16xpt5ZCwjNkz/64MWNXxZ2llCsqX5niuILiWdDOLFuJYO5gLZvt3+9Kq1wVh4SKbpXZ9 VGHYXZ/rJbYFmaZ3fWsi1mx8GtRG06GlODTlIZssKY3jBKlDQhpnFoi/A3jzMF7tYwWpNE7+ PLPuBhk6xPVNYfaeZ4CP0aScW6B2TRSVbHMX6UI17gCKYbUki956Lf8fEw/qWnaZYIxJw9lN DIV05Zr3c7fwb0BciHzPRwg1jwqaWGLH3QI+RlluxEU5HHNcjW2By4OSYTepGb0oYi6+XgKo OOBK4= X-IronPort-AV: E=Sophos;i="5.84,263,1620705600"; d="scan'208";a="48924050" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QAvWztk4sPXhduVs07YYkKUixluyE5DC+0isdWtGkl0uFQmmdvcnSLHFBq90YR9xuSelo2xLFeNRIWBSKqb7/aj+nIRYl5hwlomArRODYgf/8VuqD9Vshn0/hRMer59D5dCoFNcH9AZ1138KoqT2pml43WY1WEj+qL9/jJ4kvkYc40Qi9VI/gWfINdR7dmaFcI7w9VUpTDdyJlrT2ifwbTiLg/9KURXhCh/LwwoJb1GBee69RJl2/jeUZHfS1gmBQo3V3slkZJTFooY9j8nm/G0iaj1+I0Ex97n9SDxAzL3kDQeJ6hQt13IxVi0LqVdJhibBkhvwvFDlrjvDiS4xiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1WlqjpSEg3CzCUWbZ6/KMfWzMfpAN9JmhrjoFwGGgs0=; b=MEAYRfLXsAUrgN/rEJJIRK3EZuoJzh1q9J9nZbeoZxksRpUswbQhV4QOYgnRlQSCItuAI/UtEtXqt+3daRHFMBpCwadAU4fvMsRerW2fzy78GEXQfRMTBvDZS63bxwQHZJxQLsCKYRIfkMCoJ2GK3H6BaF8wA0c3JoRXwmb4mJD6okMj+pwSjaO5+ObZeE9JF1o71tYsBh/eXRI1cKAX4qteKJ1xHMot5XG3oSMA6P0n9xy148n/AuCLebjWYveYmnJQ4VFmRpNglKTyEGyWxgZkPH79qGFeIIarapy16+JDSlk94/UqWJhIF9Q9TU/WjTwS8BeYhTFbN0KPsxGWBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1WlqjpSEg3CzCUWbZ6/KMfWzMfpAN9JmhrjoFwGGgs0=; b=ILSqJMxVgU8Edlmm04TV8Owtuc0Eetnomhsy6FR1wVHsH4nxk8qIKwmESn41/oa5SuoomFi8IcMFgmeWmibBairc7mEPEUhZ8oedNmn/0ifAxpcJuD2QgCjgNDWjrR5EBRkKasKSSEdtW4Fpo/w+eZTWSCxuBGJ8XAEuyEWrew8= From: Martin Harvey To: "paul@xen.org" , "win-pv-devel@lists.xenproject.org" CC: Owen Smith Subject: RE: [PATCH 4/6] Under conditions of high load and low resources, it was possible for NDIS (in combination with overlying drivers) to send NET_BUFFER_LIST structures containing NULL MDL's for transmission. This resulted in an immediate bugcheck. Thread-Topic: [PATCH 4/6] Under conditions of high load and low resources, it was possible for NDIS (in combination with overlying drivers) to send NET_BUFFER_LIST structures containing NULL MDL's for transmission. This resulted in an immediate bugcheck. Thread-Index: AQHXfWtkJcXh9gs7HUKjGDdaCegN2atNroKAgAK591A= Date: Fri, 23 Jul 2021 11:00:08 +0000 Message-ID: References: <20210720132951.1776-1-Martin.Harvey@citrix.com> <20210720132951.1776-4-Martin.Harvey@citrix.com> <8ebbb971-ca94-fd97-5530-76cfd54d6a25@xen.org> In-Reply-To: <8ebbb971-ca94-fd97-5530-76cfd54d6a25@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f355e55a-aa70-4cc7-9231-08d94dc90961 x-ms-traffictypediagnostic: MWHPR03MB2861: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PpEK0DaUtqLuH5dRxoCtN+CIEMwmURnRE8KFxWOEOVdx02VpfFIsAX7SmZR31fD7Cwxko/ib2s9VZ2cl6ahzJagUrN9eJ+lTBaMXhSDgg976Rih+IrLutbJDuMPYdPYORRIesk4hW7oWx7E++sSCQqifVW+vziLKdpnHOGX4F+OeKjHOobhdQeu2qdCWXHyxQufduBJKjYH8GVC6/in+N4i6+31zi9FRAPWizfagYavtrNA59rNTAq6JKc4xiMXctHKSictSNALzfWX7N+oAhASu4WQg75g2Oe6wtf0JMcl/9eTjmSFqjTNi5e9a0yTQMUSwWZDobj0Q1+m7Xf7f7s4nfw//srdXGs7nTflDeuE3kGfkF99adQ6PaevsNtCWcYN9PXY+pECIRfQHkiXVT6qDW7WjNkZtbsIe6Yo7skB44ZL6eBXd9pFvXiQiqXL5IqpFF0jxjKXS1PPhc6O47RHOb2NncyNTfwR6vphbnSqZHqjriN+4079O7efYlRK+5LUZvjcwTJCqKrt6kjUorL5ikWYJHnbFdffchm9LXpNUEsAzBadDcJkBgzuOH2vNyq9y0TVbWYdQnDHS7MqhIRx/uSrfKTnX3KDvmMn45WC4W5DNg/4HnDLxON0VfDrDDeQbj2OSyP9dAX8nG7sfSJfpOapo2IfNTAMlYxcN2L01/0xLXuDncIOwQ+CAhy91BwaVJX5omgKYhTLMvcQoXHR+mVoxfpJ9QTbwSjOGg4MpiTAB3A2O71F5pe2su71wl2/DGePOssaWJcp0WZT3jQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6347.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(366004)(39860400002)(376002)(136003)(396003)(83380400001)(8936002)(66446008)(66476007)(9686003)(107886003)(64756008)(66946007)(8676002)(38100700002)(66556008)(316002)(52536014)(86362001)(44832011)(71200400001)(110136005)(7696005)(122000001)(76116006)(186003)(26005)(6506007)(53546011)(478600001)(4326008)(55016002)(5660300002)(33656002)(2906002)(14773001)(219693003)(38070700004);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TThMVGtTSDVaZVNTL2JyeFpVajFpTXJqcUcvRVRsSnNPci9EbVJYMVNDRHo5?= =?utf-8?B?Y0htUUN3SlI4RHFQSzF0ajVaMGYwYU1zUWZCOWZvWm8vZm0vTHA5bXFjYU1t?= =?utf-8?B?NFhqRzBVOHdybFV6TWdDd1pGdkRZV2ZaejlYaXpreEIvS0Y1a3E2UGlWUnVa?= =?utf-8?B?MW9RT3MzUlpTbmk5aXc5endmYzZLY21kdzdObHhsSlZwaW1vR0YvZ2o4T0dz?= =?utf-8?B?Qno5RXZhYUhXZkE3QjZ5S05MK0ZHUFBCbm1ZY2pzRDhldU40bUhNdlNvTEJa?= =?utf-8?B?UGY2NkxtczRmSzhEdlowdEswNGdzcXJUUnF3NkZsM0RhSThMSkhoclB2bWUy?= =?utf-8?B?dWJJcUpzMTJ0aVRFQkVQMnJYRU5lZDNiWitSMU50RzNUU0t6SVlJTGRnTGVs?= =?utf-8?B?aFpGaEh2cStYbjJ6d2xIN0RSdlZrQTZ4bmM1NGRXeXduTkcrUGd1MmVkMWRT?= =?utf-8?B?a0RWM1h0VHlJY2VpbG83UmtoVGNYSDNRSlFtcklMVVhEMHFxaVVIRVhpOU1O?= =?utf-8?B?akltZXBKL2JGVjZxMUdkMXZWK25NdEtZMmk0QVVNdW80VHJlTWhMMDNTWDFH?= =?utf-8?B?UUJTTFVveTdMQVZCd05KVExORTIyci96L0VwaEFIR2k0ZUI5QXN5aDJoelVp?= =?utf-8?B?c051RlJrdTdSajVPaUVJZzg1RUpSL1Nwblg2K1RnVktDZVMwVmw4TmU3c0RV?= =?utf-8?B?QUlRZWkzVDM3U012MFQ5S3hqWDUwZkdmMytDVUEyOFNJUE91bGR1UHVsaUVu?= =?utf-8?B?alk1cFdaVUFHSDQycHNWS1VsNHV6aFFaeHFCUnNlRFpHMCtUemZUclo2UHpL?= =?utf-8?B?d1g4OXJZTFJpb2tKVCtYVnVYVnpUbndZLzBWM0p6Y0pqUGRCY1VEdC81cXBm?= =?utf-8?B?cUc0anhVcVpWMUsrdENSTFdmNHJIcDdkVVpJQ0RIaGoxVnN4a1ZBbmVCYzV6?= =?utf-8?B?U2g5dGhocE9EZjlYMmtNWGtnblVrV1FvQm5UQXB4dnA2Sy9Hb2gzY0lwU1o3?= =?utf-8?B?aXhQS1M0bC9veThhRStXVWcxUHZ0QTEvUDhEY0FTS2lScHhOWUE0WHRGUHor?= =?utf-8?B?dEJoOEkxWDk4bGR4bG5tU0wrTThhZU5rYW02OTZHYkFOQVd4UG5UM0ZZZGIr?= =?utf-8?B?aDVGRk1aS2U0WUtDZjdhTSs1T3IraVJ4WFVxejZ1ald5SVBDdzAydmVOa1JY?= =?utf-8?B?OG15bis3ekRRem9vZ0hTaDZlcHpJNmdnMmQxQTc1QjNkcllGZDNMQlFkY0V5?= =?utf-8?B?akFKeTg4Vnp3c3FjWC9MR1hRUDk1QlpGYm5tTWcycVFPa2tPR0oxbXgwTEtP?= =?utf-8?B?TmVLakt0M0hGWkV3UmhCeC9hZWc5UXpGYmlkMjZoM0ZpdmhGZGlvdkhuMGhp?= =?utf-8?B?YVI5enN6WnhwQk42MGZGSUV0UlBGQTNEbHV2djlaOXpXV1FVSHBLWUloZzZE?= =?utf-8?B?cmdXMzVGMUR5RGlZK0YyTThWYWVHM0x3M3I4QnVDZHptbGd5Z1ZKY0d1Umg1?= =?utf-8?B?a1BrUGY4V3pTYnArc09mbE5leUgwRUNHejR6UStYbFRwaE0vTGZ0anhXc3Bw?= =?utf-8?B?cHZMRFc5SzFFckpoekJjdW9yMHpzeUl3MzJZeFdIUEZ3a1dWS2dyWGgzaU8y?= =?utf-8?B?em9saTMyWEwybVlwVlk4VjFLd1JjaEVxcXVvaDdVNEhaSE9kN2ZONXNFSTNj?= =?utf-8?B?U0hwQ0RBZjJGQ054UFBrN3YwcUhXUHFyWHhiTmU2R2hCKzZCTG54U0hVcmU4?= =?utf-8?Q?SFETFNjrBQ5jt9vJy4=3D?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6347.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f355e55a-aa70-4cc7-9231-08d94dc90961 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2021 11:00:09.0113 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XqDxRQMGq7VYId0oPimOz8lX916lVtyCoeQ+p9R0bBKGiRQ0YatxTFnC2/kCK+X9JB7FgTCjVDJeZe5T73hr1kXJ+XpB3cyu3e7zQprJfko= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2861 X-OriginatorOrg: citrix.com DQpIaSBQYXVsLA0KDQpPa2F5LCBzbyBpbiB0aGF0IGNhc2UsIHlvdSB3YW50IHRvIG1vdmUgdGhl IGZpeCB1cCB0aGUgc3RhY2sgZnJvbSB4ZW52aWYgdG8geGVubmV0LCBpbiB3aGljaCBjYXNlLCBt eSBub3RlcyB0ZWxsIG1lIHRoYXQgdGhlIGNhbGwgc3RhY2sgaXMgYXMgZm9sbG93czoNCg0KVHJh bnNtaXR0ZXJRdWV1ZVBhY2tldCAtIE1ETCBwYXJhbWV0ZXIgaXMgTlVMTC4NClZpZlRyYW5zbWl0 dGVyUXVldWVQYWNrZXQgKE1ETCBhcmd1bWVudCkuDQoNCkNhbGxlZCB2aWEgVklGX0lOVEVSRkFD RToNCnhlbm5ldCFfX1RyYW5zbWl0dGVyU2VuZE5ldEJ1ZmZlckxpc3QNClhFTlZJRl9WSUYoVHJh bnNtaXR0ZXJRdWV1ZVBhY2tldCggLi4uLiAsIE5FVF9CVUZGRVJfQ1VSUkVOVF9NREwoTmV0QnVm ZmVyKQ0KDQpTbywgeW91IHRoaW5rIHRoYXQgdGhlIGZpeCB3b3VsZCBiZXN0IGJlIHBsYWNlZCBp biB4ZW5uZXQhIF9fVHJhbnNtaXR0ZXJTZW5kTmV0QnVmZmVyTGlzdCwgd2l0aCBhbiBleHRyYSBj aGVjayB0aGF0IE5FVF9CVUZGRVJfQ1VSUkVOVF9NREwoTmV0QnVmZmVyKSBpcyBub3QgTlVMTC4N Cg0KTUguDQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiB3aW4tcHYtZGV2ZWwg PHdpbi1wdi1kZXZlbC1ib3VuY2VzQGxpc3RzLnhlbnByb2plY3Qub3JnPiBPbiBCZWhhbGYgT2Yg UGF1bCBEdXJyYW50DQpTZW50OiAyMSBKdWx5IDIwMjEgMTg6MjANClRvOiB3aW4tcHYtZGV2ZWxA bGlzdHMueGVucHJvamVjdC5vcmcNClN1YmplY3Q6IFJlOiBbUEFUQ0ggNC82XSBVbmRlciBjb25k aXRpb25zIG9mIGhpZ2ggbG9hZCBhbmQgbG93IHJlc291cmNlcywgaXQgd2FzIHBvc3NpYmxlIGZv ciBORElTIChpbiBjb21iaW5hdGlvbiB3aXRoIG92ZXJseWluZyBkcml2ZXJzKSB0byBzZW5kIE5F VF9CVUZGRVJfTElTVCBzdHJ1Y3R1cmVzIGNvbnRhaW5pbmcgTlVMTCBNREwncyBmb3IgdHJhbnNt aXNzaW9uLiBUaGlzIHJlc3VsdGVkIGluIGFuIGltbWVkaWF0ZSBidWdjaGVjay4NCg0KW0NBVVRJ T04gLSBFWFRFUk5BTCBFTUFJTF0gRE8gTk9UIHJlcGx5LCBjbGljayBsaW5rcywgb3Igb3BlbiBh dHRhY2htZW50cyB1bmxlc3MgeW91IGhhdmUgdmVyaWZpZWQgdGhlIHNlbmRlciBhbmQga25vdyB0 aGUgY29udGVudCBpcyBzYWZlLg0KDQpDb3Bpbmcgd2l0aCBORElTIGlzIFhFTk5FVCdzIHJlc3Bv bnNpYmlsaXR5LiBBbnkgcmVtZWRpYWwgYWN0aW9uIHNob3VsZCBiZSB0YWtlbiB0aGVyZSwgbm90 IGhlcmUuDQoNCiAgIFBhdWwNCg0KT24gMjAvMDcvMjAyMSAxNDoyOSwgTWFydGluIEhhcnZleSB3 cm90ZToNCj4gVGhpcyBwYXRjaCBjb250YWlucyB0aGUgaW1tZWRpYXRlIHByb3hpbWF0ZSBmaXgg Zm9yIHRoaXMgcGFydGljdWxhciANCj4gaXNzdWUsIGluc3RlYWQgZmFpbGluZyB0aGUgc2VuZCB3 aXRoIFNUQVRVU19JTlZBTElEX1BBUkFNRVRFUi4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IE1hcnRp biBIYXJ2ZXkgPG1hcnRpbi5oYXJ2ZXlAY2l0cml4LmNvbT4NCj4gLS0tDQo+ICAgc3JjL3hlbnZp Zi90cmFuc21pdHRlci5jIHwgOSArKysrKysrKy0NCj4gICAxIGZpbGUgY2hhbmdlZCwgOCBpbnNl cnRpb25zKCspLCAxIGRlbGV0aW9uKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvc3JjL3hlbnZpZi90 cmFuc21pdHRlci5jIGIvc3JjL3hlbnZpZi90cmFuc21pdHRlci5jIGluZGV4IA0KPiA3MjQ2MTVk Li5lYTEyODJjIDEwMDY0NA0KPiAtLS0gYS9zcmMveGVudmlmL3RyYW5zbWl0dGVyLmMNCj4gKysr IGIvc3JjL3hlbnZpZi90cmFuc21pdHRlci5jDQo+IEBAIC01MTQ4LDEzICs1MTQ4LDE3IEBAIFRy YW5zbWl0dGVyUXVldWVQYWNrZXQoDQo+ICAgICAgIFBYRU5WSUZfVFJBTlNNSVRURVJfUklORyAg ICAgICAgUmluZzsNCj4gICAgICAgTlRTVEFUVVMgICAgICAgICAgICAgICAgICAgICAgICBzdGF0 dXM7DQo+ICAgDQo+ICsgICAgc3RhdHVzID0gU1RBVFVTX0lOVkFMSURfUEFSQU1FVEVSOw0KPiAr ICAgIGlmIChNZGwgPT0gTlVMTCkNCj4gKyAgICAgICAgZ290byBmYWlsMTsNCj4gKw0KPiAgICAg ICBGcm9udGVuZCA9IFRyYW5zbWl0dGVyLT5Gcm9udGVuZDsNCj4gICANCj4gICAgICAgUGFja2V0 ID0gX19UcmFuc21pdHRlckdldFBhY2tldChUcmFuc21pdHRlcik7DQo+ICAgDQo+ICAgICAgIHN0 YXR1cyA9IFNUQVRVU19OT19NRU1PUlk7DQo+ICAgICAgIGlmIChQYWNrZXQgPT0gTlVMTCkNCj4g LSAgICAgICAgZ290byBmYWlsMTsNCj4gKyAgICAgICAgZ290byBmYWlsMjsNCj4gICANCj4gICAg ICAgUGFja2V0LT5NZGwgPSBNZGw7DQo+ICAgICAgIFBhY2tldC0+T2Zmc2V0ID0gT2Zmc2V0Ow0K PiBAQCAtNTIwNiw2ICs1MjEwLDkgQEAgVHJhbnNtaXR0ZXJRdWV1ZVBhY2tldCgNCj4gICANCj4g ICAgICAgcmV0dXJuIFNUQVRVU19TVUNDRVNTOw0KPiAgIA0KPiArZmFpbDI6DQo+ICsgICAgRXJy b3IoImZhaWwyXG4iKTsNCj4gKw0KPiAgIGZhaWwxOg0KPiAgICAgICBFcnJvcigiZmFpbDEgKCUw OHgpXG4iLCBzdGF0dXMpOw0KPiAgIA0KPiANCg0KDQo= From win-pv-devel-bounces@lists.xenproject.org Fri Jul 23 11:44:24 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 23 Jul 2021 11:44:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.160090.294383 (Exim 4.92) (envelope-from ) id 1m6tbK-0005GE-Rr; Fri, 23 Jul 2021 11:44:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 160090.294383; Fri, 23 Jul 2021 11:44:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6tbK-0005G7-P3; Fri, 23 Jul 2021 11:44:22 +0000 Received: by outflank-mailman (input) for mailman id 160090; Fri, 23 Jul 2021 11:44:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6tbJ-0005G1-9Z for win-pv-devel@lists.xenproject.org; Fri, 23 Jul 2021 11:44:21 +0000 Received: from smtp-fw-33001.amazon.com (unknown [207.171.190.10]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a5b844d6-f72f-4bc3-9b6d-a429b2840e08; Fri, 23 Jul 2021 11:44:19 +0000 (UTC) Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-1e-a70de69e.us-east-1.amazon.com) ([10.43.8.2]) by smtp-border-fw-33001.sea14.amazon.com with ESMTP; 23 Jul 2021 11:44:11 +0000 Received: from EX13D32EUC004.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan3.iad.amazon.com [10.40.159.166]) by email-inbound-relay-1e-a70de69e.us-east-1.amazon.com (Postfix) with ESMTPS id 33169A1C16; Fri, 23 Jul 2021 11:44:09 +0000 (UTC) Received: from EX13D32EUC003.ant.amazon.com (10.43.164.24) by EX13D32EUC004.ant.amazon.com (10.43.164.121) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Fri, 23 Jul 2021 11:44:09 +0000 Received: from EX13D32EUC003.ant.amazon.com ([10.43.164.24]) by EX13D32EUC003.ant.amazon.com ([10.43.164.24]) with mapi id 15.00.1497.023; Fri, 23 Jul 2021 11:44:08 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: a5b844d6-f72f-4bc3-9b6d-a429b2840e08 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.co.uk; i=@amazon.co.uk; q=dns/txt; s=amazon201209; t=1627040660; x=1658576660; h=from:to:cc:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version:subject; bh=qsNPL7VNTZU7vzAvsmWgQ46qiEVGVdATtWthA22Pi4E=; b=qKgq51WY+VkUd9LSrxJCrthZB1WN0trpmLr87D4LuJ5AmjsYGreTnu5e yjFhOI1XP7ggfEYmmtcSztnvbs93bAHyYzzN/U6O+nMXJAuF38GuldeiD KEJ1hbbIPbbJq5P3bYuifuSXrMtm1ttig7nW9mMqxoIiRfb1qj3uOZkL2 c=; X-IronPort-AV: E=Sophos;i="5.84,263,1620691200"; d="scan'208";a="137806609" Subject: RE: [PATCH 4/6] Under conditions of high load and low resources, it was possible for NDIS (in combination with overlying drivers) to send NET_BUFFER_LIST structures containing NULL MDL's for transmission. This resulted in an immediate bugcheck. Thread-Topic: [PATCH 4/6] Under conditions of high load and low resources, it was possible for NDIS (in combination with overlying drivers) to send NET_BUFFER_LIST structures containing NULL MDL's for transmission. This resulted in an immediate bugcheck. From: "Durrant, Paul" To: Martin Harvey , "paul@xen.org" , "win-pv-devel@lists.xenproject.org" CC: Owen Smith Thread-Index: AQHXfWuTuosBxZovBkWKiLZIukCsjqtNroKAgAK6cwCAAAvuMA== Date: Fri, 23 Jul 2021 11:44:08 +0000 Message-ID: <6fe7b1a28945468ea6b174574225b979@EX13D32EUC003.ant.amazon.com> References: <20210720132951.1776-1-Martin.Harvey@citrix.com> <20210720132951.1776-4-Martin.Harvey@citrix.com> <8ebbb971-ca94-fd97-5530-76cfd54d6a25@xen.org> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.166.209] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiB3aW4tcHYtZGV2ZWwgPHdpbi1w di1kZXZlbC1ib3VuY2VzQGxpc3RzLnhlbnByb2plY3Qub3JnPiBPbiBCZWhhbGYgT2YgTWFydGlu IEhhcnZleQ0KPiBTZW50OiAyMyBKdWx5IDIwMjEgMTI6MDANCj4gVG86IHBhdWxAeGVuLm9yZzsg d2luLXB2LWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IENjOiBPd2VuIFNtaXRoIDxvd2Vu LnNtaXRoQGNpdHJpeC5jb20+DQo+IFN1YmplY3Q6IFJFOiBbRVhURVJOQUxdIFtQQVRDSCA0LzZd IFVuZGVyIGNvbmRpdGlvbnMgb2YgaGlnaCBsb2FkIGFuZCBsb3cgcmVzb3VyY2VzLCBpdCB3YXMg cG9zc2libGUNCj4gZm9yIE5ESVMgKGluIGNvbWJpbmF0aW9uIHdpdGggb3Zlcmx5aW5nIGRyaXZl cnMpIHRvIHNlbmQgTkVUX0JVRkZFUl9MSVNUIHN0cnVjdHVyZXMgY29udGFpbmluZyBOVUxMDQo+ IE1ETCdzIGZvciB0cmFuc21pc3Npb24uIFRoaXMgcmVzdWx0ZWQgaW4gYW4gaW1tZWRpYXRlIGJ1 Z2NoZWNrLg0KPiANCj4gQ0FVVElPTjogVGhpcyBlbWFpbCBvcmlnaW5hdGVkIGZyb20gb3V0c2lk ZSBvZiB0aGUgb3JnYW5pemF0aW9uLiBEbyBub3QgY2xpY2sgbGlua3Mgb3Igb3Blbg0KPiBhdHRh Y2htZW50cyB1bmxlc3MgeW91IGNhbiBjb25maXJtIHRoZSBzZW5kZXIgYW5kIGtub3cgdGhlIGNv bnRlbnQgaXMgc2FmZS4NCj4gDQo+IA0KPiANCj4gSGkgUGF1bCwNCj4gDQo+IE9rYXksIHNvIGlu IHRoYXQgY2FzZSwgeW91IHdhbnQgdG8gbW92ZSB0aGUgZml4IHVwIHRoZSBzdGFjayBmcm9tIHhl bnZpZiB0byB4ZW5uZXQsIGluIHdoaWNoIGNhc2UsIG15DQo+IG5vdGVzIHRlbGwgbWUgdGhhdCB0 aGUgY2FsbCBzdGFjayBpcyBhcyBmb2xsb3dzOg0KPiANCj4gVHJhbnNtaXR0ZXJRdWV1ZVBhY2tl dCAtIE1ETCBwYXJhbWV0ZXIgaXMgTlVMTC4NCj4gVmlmVHJhbnNtaXR0ZXJRdWV1ZVBhY2tldCAo TURMIGFyZ3VtZW50KS4NCj4gDQo+IENhbGxlZCB2aWEgVklGX0lOVEVSRkFDRToNCj4geGVubmV0 IV9fVHJhbnNtaXR0ZXJTZW5kTmV0QnVmZmVyTGlzdA0KPiBYRU5WSUZfVklGKFRyYW5zbWl0dGVy UXVldWVQYWNrZXQoIC4uLi4gLCBORVRfQlVGRkVSX0NVUlJFTlRfTURMKE5ldEJ1ZmZlcikNCj4g DQo+IFNvLCB5b3UgdGhpbmsgdGhhdCB0aGUgZml4IHdvdWxkIGJlc3QgYmUgcGxhY2VkIGluIHhl bm5ldCEgX19UcmFuc21pdHRlclNlbmROZXRCdWZmZXJMaXN0LCB3aXRoIGFuDQo+IGV4dHJhIGNo ZWNrIHRoYXQgTkVUX0JVRkZFUl9DVVJSRU5UX01ETChOZXRCdWZmZXIpIGlzIG5vdCBOVUxMLg0K DQpZZXMsIGV4YWN0bHkuIE5ESVMgd2VpcmRuZXNzIGxpa2UgdGhpcyBzaG91bGQgYmUgZGVhbHQg d2l0aCBhdCB0aGF0IGxldmVsLg0KDQogIFBhdWwNCg0KPiANCj4gTUguDQo+IA0KPiAtLS0tLU9y aWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiB3aW4tcHYtZGV2ZWwgPHdpbi1wdi1kZXZlbC1i b3VuY2VzQGxpc3RzLnhlbnByb2plY3Qub3JnPiBPbiBCZWhhbGYgT2YgUGF1bCBEdXJyYW50DQo+ IFNlbnQ6IDIxIEp1bHkgMjAyMSAxODoyMA0KPiBUbzogd2luLXB2LWRldmVsQGxpc3RzLnhlbnBy b2plY3Qub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggNC82XSBVbmRlciBjb25kaXRpb25zIG9m IGhpZ2ggbG9hZCBhbmQgbG93IHJlc291cmNlcywgaXQgd2FzIHBvc3NpYmxlIGZvciBORElTIChp bg0KPiBjb21iaW5hdGlvbiB3aXRoIG92ZXJseWluZyBkcml2ZXJzKSB0byBzZW5kIE5FVF9CVUZG RVJfTElTVCBzdHJ1Y3R1cmVzIGNvbnRhaW5pbmcgTlVMTCBNREwncyBmb3INCj4gdHJhbnNtaXNz aW9uLiBUaGlzIHJlc3VsdGVkIGluIGFuIGltbWVkaWF0ZSBidWdjaGVjay4NCj4gDQo+IFtDQVVU SU9OIC0gRVhURVJOQUwgRU1BSUxdIERPIE5PVCByZXBseSwgY2xpY2sgbGlua3MsIG9yIG9wZW4g YXR0YWNobWVudHMgdW5sZXNzIHlvdSBoYXZlIHZlcmlmaWVkIHRoZQ0KPiBzZW5kZXIgYW5kIGtu b3cgdGhlIGNvbnRlbnQgaXMgc2FmZS4NCj4gDQo+IENvcGluZyB3aXRoIE5ESVMgaXMgWEVOTkVU J3MgcmVzcG9uc2liaWxpdHkuIEFueSByZW1lZGlhbCBhY3Rpb24gc2hvdWxkIGJlIHRha2VuIHRo ZXJlLCBub3QgaGVyZS4NCj4gDQo+ICAgIFBhdWwNCj4gDQo+IE9uIDIwLzA3LzIwMjEgMTQ6Mjks IE1hcnRpbiBIYXJ2ZXkgd3JvdGU6DQo+ID4gVGhpcyBwYXRjaCBjb250YWlucyB0aGUgaW1tZWRp YXRlIHByb3hpbWF0ZSBmaXggZm9yIHRoaXMgcGFydGljdWxhcg0KPiA+IGlzc3VlLCBpbnN0ZWFk IGZhaWxpbmcgdGhlIHNlbmQgd2l0aCBTVEFUVVNfSU5WQUxJRF9QQVJBTUVURVIuDQo+ID4NCj4g PiBTaWduZWQtb2ZmLWJ5OiBNYXJ0aW4gSGFydmV5IDxtYXJ0aW4uaGFydmV5QGNpdHJpeC5jb20+ DQo+ID4gLS0tDQo+ID4gICBzcmMveGVudmlmL3RyYW5zbWl0dGVyLmMgfCA5ICsrKysrKysrLQ0K PiA+ICAgMSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQ0KPiA+ DQo+ID4gZGlmZiAtLWdpdCBhL3NyYy94ZW52aWYvdHJhbnNtaXR0ZXIuYyBiL3NyYy94ZW52aWYv dHJhbnNtaXR0ZXIuYyBpbmRleA0KPiA+IDcyNDYxNWQuLmVhMTI4MmMgMTAwNjQ0DQo+ID4gLS0t IGEvc3JjL3hlbnZpZi90cmFuc21pdHRlci5jDQo+ID4gKysrIGIvc3JjL3hlbnZpZi90cmFuc21p dHRlci5jDQo+ID4gQEAgLTUxNDgsMTMgKzUxNDgsMTcgQEAgVHJhbnNtaXR0ZXJRdWV1ZVBhY2tl dCgNCj4gPiAgICAgICBQWEVOVklGX1RSQU5TTUlUVEVSX1JJTkcgICAgICAgIFJpbmc7DQo+ID4g ICAgICAgTlRTVEFUVVMgICAgICAgICAgICAgICAgICAgICAgICBzdGF0dXM7DQo+ID4NCj4gPiAr ICAgIHN0YXR1cyA9IFNUQVRVU19JTlZBTElEX1BBUkFNRVRFUjsNCj4gPiArICAgIGlmIChNZGwg PT0gTlVMTCkNCj4gPiArICAgICAgICBnb3RvIGZhaWwxOw0KPiA+ICsNCj4gPiAgICAgICBGcm9u dGVuZCA9IFRyYW5zbWl0dGVyLT5Gcm9udGVuZDsNCj4gPg0KPiA+ICAgICAgIFBhY2tldCA9IF9f VHJhbnNtaXR0ZXJHZXRQYWNrZXQoVHJhbnNtaXR0ZXIpOw0KPiA+DQo+ID4gICAgICAgc3RhdHVz ID0gU1RBVFVTX05PX01FTU9SWTsNCj4gPiAgICAgICBpZiAoUGFja2V0ID09IE5VTEwpDQo+ID4g LSAgICAgICAgZ290byBmYWlsMTsNCj4gPiArICAgICAgICBnb3RvIGZhaWwyOw0KPiA+DQo+ID4g ICAgICAgUGFja2V0LT5NZGwgPSBNZGw7DQo+ID4gICAgICAgUGFja2V0LT5PZmZzZXQgPSBPZmZz ZXQ7DQo+ID4gQEAgLTUyMDYsNiArNTIxMCw5IEBAIFRyYW5zbWl0dGVyUXVldWVQYWNrZXQoDQo+ ID4NCj4gPiAgICAgICByZXR1cm4gU1RBVFVTX1NVQ0NFU1M7DQo+ID4NCj4gPiArZmFpbDI6DQo+ ID4gKyAgICBFcnJvcigiZmFpbDJcbiIpOw0KPiA+ICsNCj4gPiAgIGZhaWwxOg0KPiA+ICAgICAg IEVycm9yKCJmYWlsMSAoJTA4eClcbiIsIHN0YXR1cyk7DQo+ID4NCj4gPg0KPiANCg0K From win-pv-devel-bounces@lists.xenproject.org Fri Jul 23 14:08:53 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 23 Jul 2021 14:08:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.160133.294438 (Exim 4.92) (envelope-from ) id 1m6vrA-0007Fu-Es; Fri, 23 Jul 2021 14:08:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 160133.294438; Fri, 23 Jul 2021 14:08:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6vrA-0007Fn-Bv; Fri, 23 Jul 2021 14:08:52 +0000 Received: by outflank-mailman (input) for mailman id 160133; Fri, 23 Jul 2021 14:08:50 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6vr8-0007FO-2z for win-pv-devel@lists.xenproject.org; Fri, 23 Jul 2021 14:08:50 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7fb7d686-ebbf-11eb-93c5-12813bfff9fa; Fri, 23 Jul 2021 14:08:48 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 7fb7d686-ebbf-11eb-93c5-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1627049328; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=4vBL3D+oKy5Gxs6FX3HN6m1f87FwXJYWHXAd5wwlmTI=; b=NsY8UdeuqaS4MR2+nHngzjboqyzeNXDGhbPu9bpsFL2MyUO6hrfBZHnU QxYqmXJtDfm/B4Q9nSzUZxP1x3oSn7iF4otpWQ8VCzkZ30nynR9ZUu7Gv 5t7WmINpcyHxbXkkBOcE5Xam2oNc1NCjMDJoxdukgMgfXhse0cSA5s3tF s=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: KFcnpPNvTQ2IUtj2BXaXlUZLRcnR/3pU2EMqNRCIQNLRHBMT9dUJHVMYroYpqQaHD2IYEbxlvr uMsdgNLd969D8qRnAyEesWQ+9MD12CAFgFIcHZN5/359TvcHcAmjdPnsKIocZYDPttemhTI9fE c0X+e6xJaxn820pO0DpFjeVDGx5HlDwvj52+919N4ntMbsKzo95EEAPFSSH1k/qRRcJguhW9Of IGr/lKpBptjSyrPgXud+41LQBecvDTBlacnsSHqlDF+GyYRBCn24W3teOOkKB8RRDdWzIxuz/9 wmogQbyHtMuAL+5++jBTRmXC X-SBRS: 5.1 X-MesageID: 48938746 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:MRAFzqs7H+RYkGprYRahVQbW7skCZ4Aji2hC6mlwRA09TyXGra GTdaUguyMc1gx/ZJh5o6H+BEGBKUmskqKdkrNhQ4tKPTOW+VdASbsDnNrfKlLbalbDH4JmpM Jdmu1FeaHN5DtB/IbHCWuDYqwdKbC8mcjC74qzvhQdLz2CKZsQkjuRYTzrdHGeMTM2fabRY6 Dsn/avyQDQHUg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZdbxp/hZMZtU TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESotu/oXvUkZ1SxhkFynAid0idyrD AKmWZ5Ay1H0QKXQohym2q35+Cv6kd115ao8y7ovZKqm72IeBsKT+5IhYdydBzF8Ewk+PdhzY JN0GTxjesKMTrw2AD0593jURZ2jUywjFgDtcQTg3ZcOLFuNYN5nMg69ENRGpEGATn97cQdHO ZjF9uZ2fA+SyLFU5mehBgt/DTBM05DQStuC3JyyfC9wnxYmmt0wFAfw9FalnAc9IglQ50B/O jcNL90/Ys+A/P+QJgNT9vpe/HHQFAlgCi8R166MBDiDuUKKnjNo5n47PE84/yrYoUByN83lI 7aWF1VuGYucwa2YPf+k6Fj41TIWiGwTD7twsZR69xwvaD9XqPiNWmGREo1m8Wtrv0DConQWu q1OphRH/j/RFGeVbphzkn7Qd1fOHMeWMoatpIyXE+PuNvCLsnwuunSYJ/oVfLQ+PYfKyrC61 44LXbOzel7nzWWs07D8W7ssinWCz7CFLpLYdznw9Q= X-IronPort-AV: E=Sophos;i="5.84,264,1620705600"; d="scan'208";a="48938746" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eqIFXgTG8+m+vRn9ZzFDJpUqkJ7VPP0Xw2Bp8Vkfmk9c4Xukj3TEwL/KlFateRjDgtd30qWxadY1x4WA7c/bIeCiprPZTvf3Yy9bBKjMi3Qm+geKg46x9CtAsIeah2LaOWP3DYeXVfY7eNz/Pwp0gdpkWmWf9dhW1FD6IkfRoxciElklDW8owmrh3gpYIDwxtDIHCzGH0mjiZYwFw/r2j5xY6WiUMcaaWI0trJPwlHIRto7A21kVqvVibOqvNmOT5+hN9Mjl6sLsJHdHiCaXeVhHdf0qi8OhayN6KKJRtfFKjUERYNOYXotH/uSpxYkjJa6078myWjYzsabzhr7GXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4vBL3D+oKy5Gxs6FX3HN6m1f87FwXJYWHXAd5wwlmTI=; b=UouL/LWu4Xk5OLhyZPCUESHoOfZs0rv4YCpyJLOCbvcgL35E5zIBR28voSzUDpgKp0swoD6bV57r341kIczoSdLpsmcQEb5POut/jfG5KTuO1Y8fdqI1K2XbMXRPZDcHejxidLu9EEB/6igLXhT2+OnY1qJo8mqiywj7Pb0zCL+R4Q24aOgR0Vg3KRACsEY4SpuESzqXSLEAWtsRiwiXhqkk8y5lAOReG6ant5nZgQ+E1olJmgf9/vRMFxWOl53DZWBZADn7nldfv+1hJ/JRoMgzRJHaEASfN91mFaJPbJ9wg9qV3vNw509i5EUSXFHrgWcnJV96VUqQylBynvAU6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4vBL3D+oKy5Gxs6FX3HN6m1f87FwXJYWHXAd5wwlmTI=; b=RTmHyLeZru2qaX7GyuD9Gmz1GwsS0i+XgOApYcMtjFuGujgKiDNmaIFqyK3poEJHEekxoH/sFmK+qElnUJqrnxGI27ktAWC6gWxdya+OktwIyKPrge/57jkSaXqTk/FWz5Z5rp/6AIdZ8YsjNY/IJN8ACmkzquo/VpWsCUKSwok= From: Martin Harvey To: "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Subject: RE: [PATCH 6/6] Under conditions of high load, it was possible for xenvif to queue up very large numbers of packets before pushing them all upstream in one go. This was partially ameliorated by use of the NDIS_RECEIVE_FLAGS_RESOURCES flag. Thread-Topic: [PATCH 6/6] Under conditions of high load, it was possible for xenvif to queue up very large numbers of packets before pushing them all upstream in one go. This was partially ameliorated by use of the NDIS_RECEIVE_FLAGS_RESOURCES flag. Thread-Index: AQHXfWtk+tASUJTSVEWzWgTW/lHzzqtO86eAgAF5OeA= Date: Fri, 23 Jul 2021 14:08:42 +0000 Message-ID: References: <20210720132951.1776-1-Martin.Harvey@citrix.com> <20210720132951.1776-6-Martin.Harvey@citrix.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 50e9c3d0-22b1-4019-1412-08d94de360e7 x-ms-traffictypediagnostic: MWHPR03MB2464: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kbPxbcMoL5JUha6znLZ68jdku0hgos4CgMPZpkWWD21D+2lR2y7dz20rgETNWMOUSxEy1whU5S2i5H6flBSIaAJ7f/eTARylfulL3Weao4XLFaosXZZg42L8+ZuDagVy5NaWrtYRNatZtKQ5X1EF2v0AyxF9VuborHA6Er5UjRvWKu8+UXrrLVVHnTdeWEMOLqm4oCZu6Zz4okQtH65BwOr0EVeMqw2qkxom4VPP1igALe0J/Lxgt+5ytmTaorK536jPdG+RsTXx8buDFUBrNj6XeW5uuQnVABdNl3cF/BTQWMn0xi1Ggje/4jHsWhIsDxJVvM7Ly8AHO8wYxdvZZGc65pkTUrCm10bar8JiRa15TLmkwyj2n4mtaV529IV2TEr5h7Ko5Z9g37sZhcungPjZzcf3wWvT9v0B4tqneCk/DMHvY2NuZlhhoC0VL/s21b2dFFU++fDQ+VY+CAW8NJYey380UOigcVHNf6lU/cdkdw4bcJvTOawyjrNXBWyXRFNC8697EVdaXvSvK2VEEMd+PneRWqED+uwY7ABGgHes/iwTqL9aBnpTtRz3hGShC24bpwr08zF+FP4pCrBWJbXVDtUc5DTQ6g9gJBvzqZTO+0vBwD0E7o4QSxMv4KB3sgC3ejhcuWFEGtpwn+RlSTSHKh1rE1CSqEciMZIrHdYnJeAxcElUmLLt3YAx2aIXl6DzZaiND9Qze1CfhGUWCICSK1bvzSopXr9vbteXkIF4jdkIgtzgsdGxJ89/Lu02qTe3pKmxmNjuE3XIupr8WQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6347.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8676002)(508600001)(6506007)(53546011)(9686003)(7696005)(55016002)(86362001)(33656002)(83380400001)(26005)(71200400001)(186003)(52536014)(110136005)(66556008)(66446008)(66946007)(2906002)(8936002)(316002)(38100700002)(64756008)(44832011)(5660300002)(66476007)(122000001)(76116006)(522954003)(219693003)(38070700004);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Zm04MElKVE5GWFdqRE9IYllFM3R5ZEQrRFBPWHZOb2REaUJzQ1RHUThwZ1dY?= =?utf-8?B?a1VUYjRsdWNTSjByQjhOVS9FNjFKLy96RHcrVWJMYlBzSDBxaUNCRHo4VUVU?= =?utf-8?B?OWJYaFo1dHcveWZpOGZxWkxHVE44R0NLNTAzS1JNalRybGdTNDVkeEZnRFVk?= =?utf-8?B?cTd3SWREYnN3eXUwb2Q1dHN5RjUvQ2hyN09TOUJJK05NQXFTT1lCZnozYjhv?= =?utf-8?B?L2RjeTJFSEFRTkxxQW52ZEZMOWNuSmFCUUxOVGZHRGthQTJ3NG5ZbFYxOHoz?= =?utf-8?B?SXdzRDE2dlUrVTVpa0Q5azFlRkpCYnhrL3pCQmxhK3dVTjlrOWRENmhhbmQ0?= =?utf-8?B?dlNVU21vWHZ1QW93UWcrdWdiL0h2MDdMbWxOK0pvZFZXU29Ob1VhQXNrMUp1?= =?utf-8?B?WnU3SDZzMlpSakw1dkdpTS9tck5JVEZaOXJJOE9zTS9STUIxeVJIRlRjemxn?= =?utf-8?B?eGNPa2FqN2I3eThVeXlacU9UbDhOZnBqcG1tSHVSOU9wQjI3NGt4QWFGSm8y?= =?utf-8?B?WkNuZDRRVWNkalpvdkxtQVFrL0lLWTVuL3BxZ0M2aG5RNHlodTFYQ1lJMHNI?= =?utf-8?B?bUlXU0xXMU9ORncwZFZ4c2RBTTA3enJLQ2pUVzdDbWdBbFVYYkRyRG1PZWgv?= =?utf-8?B?cE1WQ3ZmMmYwWjlNbUdBbWR6aTFCNUNCWmg4NzNhNGtyVmtTUUpVQWFmNll2?= =?utf-8?B?S2NJT1Zsb2Y3WDZJWWo3eEJXQ3dwQS8yK0FsU2tQTU43anE3eWV5amVwWWJ0?= =?utf-8?B?M0dpL2hLRXRoaThBbFRwYktycUkySzRrSkZWMStEcnEvVjVlejRmb0ZkWEgy?= =?utf-8?B?QUlqcnJJTk1BWm13WlZhb1ppRW1YeXZmdjZSM3pVZmVwdk1aMFgzQTcza2lE?= =?utf-8?B?MjF1R0JGZDE3ajRMazJpRW9nbjE0VU50R2JmQUJmcWJYY09kazFkUTV0NXJp?= =?utf-8?B?Y0Q0WS9NTE43cS92OHBmVmM2MnIzTHZhd09JUjBPYU0zRDFaKzZrTkt5RlNv?= =?utf-8?B?ZkNXMitVKyt1U09IMHJQR1BXUXBZbUFLZmlNRXZUZXRUTURFcUJNSmcyRnY3?= =?utf-8?B?QklqM0JYNUFKejZZK1RZdWc4K01VMVVwc01rL2UwZUNiNzJVQW5hU3cyQXYv?= =?utf-8?B?YjdSVnp4NXREbi94cW1oNHhIWG5tbWdMQVcvVzlKVmpDR21tbG03UHhEZmVX?= =?utf-8?B?V2N6Vm5lYlpCcmtSNEtZZDFIUk9sdEVRS1ljU3lPVDVnR2pUdy9vYVJWaEpM?= =?utf-8?B?ejdDQ0lreEFpT1JwNUNkUy8wNGZWYStSZXdUUU85NjlsRGQzK1hTODBvV2Zi?= =?utf-8?B?TERGOFNYbmtrOWJIeW5WODdBSTRaM2VETE5jMndUU2gwV1QzalZoNUM2WFJ5?= =?utf-8?B?UDJJY0svVXhhdXpNOHY2WUdlNkdjQlB4elZFVjhTSHRhZ1BiY2tWOFVyTzRm?= =?utf-8?B?cGNwUEVRRnN5N1hvTlZPK08ydzNFbmdpSjltNlQrYm52NlJteTJ4THgreThN?= =?utf-8?B?WExjV1VpdGlRZythUitpUXVwTTN2c0JmRE1Mc3lFcXFBL242STVyYlJBZHhL?= =?utf-8?B?ZitMcVVxMEZBRGh1SWp1MFBKZWwxVXRQTVhZSXNjMmlBRkZ0dnU3aklHejA0?= =?utf-8?B?TFJVV29GQTFUVytQRFdKZXJjNVRnRUo4WG5BOUpFWjlSTTRvTFlpdG5qUmxI?= =?utf-8?B?MGNKUXMxSEJIUDY0VkZ6WEJMNVR6ZVBqcWRZUGFmZlVOY3NmYnJ5RG1ZVzJV?= =?utf-8?Q?vuohcNcZst1Wzu3YMs=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6347.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 50e9c3d0-22b1-4019-1412-08d94de360e7 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2021 14:08:42.6624 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cn2kCloGa1o2bqtHKehWgQsafTxzuoI6fSD94HwuJAFmxVCDaw08KFYS3L7E7PCRdYeIeE2WT7VPn0Pa+poNYe23JcqEnaELG35gqkMF00Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2464 X-OriginatorOrg: citrix.com DQotLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KRnJvbTogd2luLXB2LWRldmVsIDx3aW4tcHYt ZGV2ZWwtYm91bmNlc0BsaXN0cy54ZW5wcm9qZWN0Lm9yZz4gT24gQmVoYWxmIE9mIFBhdWwgRHVy cmFudA0KU2VudDogMjIgSnVseSAyMDIxIDEzOjQ0DQpUbzogd2luLXB2LWRldmVsQGxpc3RzLnhl bnByb2plY3Qub3JnDQpTdWJqZWN0OiBSZTogW1BBVENIIDYvNl0gVW5kZXIgY29uZGl0aW9ucyBv ZiBoaWdoIGxvYWQsIGl0IHdhcyBwb3NzaWJsZSBmb3IgeGVudmlmIHRvIHF1ZXVlIHVwIHZlcnkg bGFyZ2UgbnVtYmVycyBvZiBwYWNrZXRzIGJlZm9yZSBwdXNoaW5nIHRoZW0gYWxsIHVwc3RyZWFt IGluIG9uZSBnby4gVGhpcyB3YXMgcGFydGlhbGx5IGFtZWxpb3JhdGVkIGJ5IHVzZSBvZiB0aGUg TkRJU19SRUNFSVZFX0ZMQUdTX1JFU09VUkNFUyBmbGFnLg0KDQo+IEkgdGhpbmsgeW91IGZpcnN0 IG91Z2h0IHRvIG1ha2UgYSBuZXcgdmVyc2lvbiBvZg0KPiBWaWZSZWNlaXZlclF1ZXVlUGFja2V0 KCkgdGhhdCBjYW4gcmV0dXJuIGEgYm9vbGVhbiB2YWx1ZSB0byBzYXkgd2hldGhlciB5b3Ugc2hv dWxkIHF1ZXVlIG1vcmUgb3Igbm90LiBUaGVuIFhFTk5FVCBjYW4gYmUgdGhlIG9uZSA+IHRvIGFw cGx5IHRoZSBiYWNrcHJlc3N1cmUgKGFzIGl0IHNob3VsZCBiZSkuDQoNCkFoLiBPa2F5LCAgdGhp bmsgdGhpcyBpcyBwb3NzaWJseSBkdWUgdG8gYSBtaXNub21lci4gSSBuZWVkIHRvIGV4cGxhaW4g d2h5IEkgZG9uJ3QgdGhpbmsgdGhhdCB3aWxsIHdvcms6IEFzIEkgdW5kZXJzdGFuZCBpdCwgdGhl IHByb2JsZW0gaXMgdGhhdCB0aGVyZSBhcmVuJ3QgYWN0dWFsbHkgYW55IGV4cGxpY2l0IGZsb3cg Y29udHJvbCBzaWduYWxzIGZyb20gYWJvdmUuIFBlcmhhcHMgSSBzaG91bGQgaGF2ZSBjYWxsZWQg aXQgIlRocm90dGxpbmciIGluc3RlYWQgb2YgYmFja3ByZXNzdXJlLCBhbmQgYXQgdGhlIG1vbWVu dCwgdGhhdCB0aHJvdHRsaW5nIGlzIGludGVybmFsIHRvIFhlblZpZiwgYmVjYXVzZSB0aGVyZSdz IG5vIHdheSBvZiBrbm93aW5nIGV4YWN0bHkgaG93IG11Y2ggc3RyZXNzL3Jlc291cmNlIHNjYXJj aXR5IGhpZ2hlciBsZXZlbHMgb2YgdGhlIHN0YWNrIGFyZSB1bmRlci4NCg0KIFRoZSB3YXkgaXQn cyBjdXJyZW50bHkgaW1wbGVtZW50ZWQgaXM6DQoNCi0gRnJvbSBSaW5nLT5QYWNrZXRDb21wbGV0 ZSwgd2UgYWxsb3cgUlhfQlVGRkVSSU5HX01BWCB0byBiZSBwdXNoZWQgdXBzdGVhbSBwZXIgRFBD Lg0KLSBJZiB0aGF0IGZhaWxzIHRvIGVtcHR5IFJpbmctPlBhY2tldENvbXBsZXRlLCB3ZSBpbW1l ZGlhdGVseSBzY2hlZHVsZSBhbm90aGVyIERQQywgdGhpcyBhbGxvd2luZyBvdGhlciBEUEMncyB0 byBydW4gZmlyc3QsIHdoaWNoIGlzIGFzc3VtZWQgdG8gZ2l2ZSBoaWdoZXIgbGF5ZXJzIGEgY2hh bmNlIHRvIGRpZ2VzdCB0aGUgcGFja2V0cyBwdXNoZWQgdXAsIGFuZC9vciBmcmVlIHVwIHJlc291 cmNlcyB3aGVuIHRob3NlIHBhY2tldHMgaGF2ZSBiZWVuIGNvbXBsZXRlZC4NCi0gVXBzdHJlYW0g b2YgdGhhdCwgd2UgYXJlIGhvbGRpbmcgUmluZy0+UGFja2V0UXVldWUsIHdoaWNoIGdldHMgY2xl YXJlZCBhbmQgbW92ZWQgdG8gUmluZy0+UGFja2V0Q29tcGxldGUgdmlhIFJlY2VpdmVyUmluZ1By b2Nlc3NQYWNrZXQuDQotIFRoaXMgdHJhbnNmZXIgb2YgUmluZy0+UGFja2V0UXVldWUgdG8gUmlu Zy0+UGFja2V0Q29tcGxldGUgd2lsbCBvbmx5IGhhcHBlbiB3aGVuIFJpbmctPlBhY2tldENvbXBs ZXRlIGhhcyBiZWVuIGVtcHRpZWQsIHRoYXQgc3ViamVjdCB0byBSWF9CVUZGRVJJTkdfTUFYIGNv bnN0cmFpbnRzIHBlciBEUEMuDQotIFdlIGtlZXAgYSBjb25zZXJ2YXRpdmUgZXN0aW1hdGUgb2Yg aG93IGxhcmdlIFJpbmctPlBhY2tldFF1ZXVlIGlzIGdyb3dpbmcuDQotIFdlIGV4cGVjdCB0aGF0 IFJpbmctPlBhY2tldFF1ZXVlIHNob3VsZCBiZSBsYXJnZSBlbm91Z2ggYXMgYW4gaW10ZXJtZWRp YXRlIGJ1ZmZlciB0byBlbXB0eSB0aGUgZW50aXJlIHJpbmcsIGFuZCB0aGF0IGluIGNhc2VzIHdo ZXRoZXIgdGhyb3R0bGluZyBpcyB1bmRlcndheSwgdGhlIHBhY2tldCBxdWV1ZSB3aWxsIGdyb3cg d2hpbHN0IHdhaXRpbmcgZm9yIFBhY2tldENvbXBsZXRlIHRvIGVtcHR5Lg0KLSBXZSBhbGxvdyBQ YWNrZXRRdWV1ZSB0byBncm93IHVwIHRvIGEgY2VydGFpbiBzaXplOiBhbHNvIFJYX0JVRkZFUklO R19NQVgsIHNvIGl0IGlzIHBvc3NpYmxlIHRvIGVtcHR5IHRoZSBlbnRpcmUgcXVldWUgdG8gUGFj a2V0Q29tcGxldGUgYW5kIGluZGljYXRlIGFsbCBvZiBQYWNrZXRDb21wbGV0ZSB1cCB0byBORElT IGluIG9uZSBnby4NCi0gSWYgUGFja2V0UXVldWUgaXMgYWJvdXQgdG8gZ3JvdyBsYXJnZXIgdGhh biB0aGF0LCB0aGVuIHdlIGxlYXZlIHRoZSBQb2xsRFBDIGVhcmx5LCBzbyBpdCBkb2VzIG5vdCBm aWxsIHVwIHRoZSBwYWNrZXQgcXVldWUsIGFuZCB3ZSBhbGxvdyB0aGUgcmluZyBpdHNlbGYgdG8g YmFjayB1cC4NCg0KTm93LCBvZiBjb3Vyc2UsIHRoZSByZWFzb24gdGhpcyB3b3JrcyBhdCBhbGwg aXMgYmVjYXVzZSB3ZSBoYXZlIHR3byBEUEMnczogUG9sbERQQyBhbmQgUXVldWVEUEMuIFRoZSBk cmFpbmluZyBmcm9tIHRoZSBwYWNrZXQgcXVldWUgdG8gcGFja2V0IGNvbXBsZXRlLCBhbmQgaW5k aWNhdGUgdXAgdG8gTkRJUyBpcyBpbiB0aGUgIFF1ZXVlRHBjLCBhbmQgdGhlIGZpbGxpbmcgb2Yg dGhlIHBhY2tldCBxdWV1ZSBpcyBpbiB0aGUgUG9sbERQQy4gSXQgaXMgdGhlIGRpZmZlcmVudCBy YXRlcyBvZiB0aGVzZSB0d28gRFBDJ3MgdGhhdCBpbmRpY2F0ZXMgd2hldGhlciB0aGUgUGFja2V0 UXVldWUgd2lsbCBmaWxsIG9yIGVtcHR5Lg0KDQo+IEkgdGhpbmsgdGhlIHBhcnQgYmVsb3cgc2hv dWxkIG5vdyBiZSBzcGxpdCBvdXQgaW50byBhIHNlcGFyYXRlIGZ1bmN0aW9uIG5vdzsgaXQncyBh bGwgZ2V0dGluZyBhIGJpdCBsb25nIHRvIGJlIGlubGluZS4gWW91IG1pZ2h0IGFsc28NCj4gY29u c2lkZXIgYSBzZXBhcmF0ZSBEUEMgdGhhdCBqdXN0IGRvZXMgdGhpcyBzZWNvbmQgcGFydCBzbyB5 b3UgY2FuIGp1c3QgdXNlIHRoYXQgaW4gdGhlIGNhc2UgeW91IG5lZWQgdG8gZGVmZXIuDQoNCj4g LSAgICB3aGlsZSAoIUlzTGlzdEVtcHR5KCZSaW5nLT5QYWNrZXRDb21wbGV0ZSkpIHsNCj4gKyAg ICB3aGlsZSAoKCFJc0xpc3RFbXB0eSgmUmluZy0+UGFja2V0Q29tcGxldGUpKQ0KPiArICAgICAg ICAmJiAoKFB1c2hlZFVwc3RyZWFtIDwgUlhfQlVGRkVSSU5HX01BWCkgfHwgUmluZy0+RmluYWxG bHVzaCkpIA0KPiArIHsNCg0KSSBhbSBsb2F0aCB0byBjcmVhdGUgYW5vdGhlciBEUEMuIFJlZmFj dG9yaW5nIGlzIGFsbCBmaW5lLCBidXQgY3JlYXRpbmcgYW5vdGhlciBEUEMgY2hhbmdlcyB0aGUg cnVudGltZSBiZWhhdmlvdXIuDQoNCkkgaGF2ZSBvbWl0dGVkIHRvIHVwc3RyZWFtIGEgcGF0Y2gg d2hpY2ggd2UgaGF2ZSBsb2NhbGx5IHdoaWNoIGhhcyBhIGxhcmdlIGFtb3VudCBvZiBzdGF0cyBv biByZWxhdGl2ZSBEUEMgcmF0ZXMsIGFuZCBhbHNvIGhvdyBtdWNoIHRoZSB0d28gRFBDJ3Mgb3Zl cmxhcCBlYWNoIG90aGVyICh0aGF0IGlzLCBleGVjdXRlIGNvbmN1cnJlbnRseSkuDQoNCkFncmVl IHRoYXQgd2UgbmVlZCB0byBicmVhayBSZWNlaXZlclJpbmdTd2l6emxlIGludG8gYSBjb3VwbGUg b2Ygc2VwYXJhdGUgZnVuY3Rpb25zLCBvbmUgZGVhbGluZyB3aXRoIHRyYW5zZmVycmluZyBQYWNr ZXRRdWV1ZSAtPiBQYWNrZXRDb21wbGV0ZSwgYW5kIG9uZSBkZWFsaW5nIHdpdGggUGFja2V0Q29t cGxldGUgLT4gSW5kaWNhdGUgdXAgdG8gTkRJUy4gQWRkaW5nIGFub3RoZXIgRFBDIHRvdGFsbHkg aW52YWxpZGF0ZXMgYWxsIHRoZSBwcm9maWxpbmcgZXRjIEkgaGF2ZSBkb25lLg0KDQpHaXZlbiB0 aGUgcHJveGltaXR5IG9mIHRoZSBxdWV1aW5nIC8gZHBjIGxvZ2ljIHRvIFhlblZpZiwgYW5kIHRo ZSBsYWNrIG9mIHVwc3RyZWFtIHNpZ25hbHMgZnJvbSBOZGlzIHRvIFhlbk5ldCAoY29ycmVjdCBt ZSBpZiBJIGFtIHdyb25nKSwgSSBjYW4ndCBzZWUgYSB3YXkgdG8gZWFzaWx5IHB1c2ggdGhpcyBs b2dpYyB1cCB0byBYZW5OZXQuDQoNCkxldCBtZSBrbm93IGlmIHlvdSdyZSBoYXBweSB3aXRoIHRo aXMgYXBwcm9hY2guDQoNCk1ILg0KDQo= From win-pv-devel-bounces@lists.xenproject.org Fri Jul 23 15:05:38 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 23 Jul 2021 15:05:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.160145.294455 (Exim 4.92) (envelope-from ) id 1m6wk4-0005Xa-JP; Fri, 23 Jul 2021 15:05:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 160145.294455; Fri, 23 Jul 2021 15:05:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6wk4-0005XO-Fq; Fri, 23 Jul 2021 15:05:36 +0000 Received: by outflank-mailman (input) for mailman id 160145; Fri, 23 Jul 2021 15:05:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6wk3-0005XE-Hm for win-pv-devel@lists.xenproject.org; Fri, 23 Jul 2021 15:05:35 +0000 Received: from mail-wm1-x32b.google.com (unknown [2a00:1450:4864:20::32b]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id bbab69d7-c8b7-4e9e-abf5-15d90f294dcd; Fri, 23 Jul 2021 15:05:34 +0000 (UTC) Received: by mail-wm1-x32b.google.com with SMTP id j34-20020a05600c1c22b029024e75084404so854458wms.1 for ; Fri, 23 Jul 2021 08:05:33 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:e99c:5cd6:403a:690b? ([2a00:23c5:5785:9a01:e99c:5cd6:403a:690b]) by smtp.gmail.com with ESMTPSA id y12sm15576730wmc.12.2021.07.23.08.05.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jul 2021 08:05:32 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: bbab69d7-c8b7-4e9e-abf5-15d90f294dcd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=O/p4SXsBC+aON+GulDWeIp5fg+d4FZUjRnnZrpqB03Q=; b=FxcdJj977t9LhJdY9OyQAiIicBII4UDmUcbNtPGQeiivls0UMDLPe8QQaTrdMnb1dp ANUDJvvqz02Uk2h0G1jnMUQxlxxlmQ8GZx4zj3CFl6U232HWsxRd7qt7ArtFVAuEAL6V jWWt1gXt54DBuQQ9mX2IwuMSYHILM4RRX0Qo4COjXzkbX01HYXRUlr3r4JZG2AiDxHgK xf3GoQMGeuWG6L6dckKmtlpru30OsouDiqCupWZbK6iFm77aXJxfRhXzYRO12j6yUfFE SO5PPdWIlUjcXigqGiWMdm3FTGDTY/TBwytD7Q/iWsMzSsNuwjnqCHEl2SsJdVMkvuPv JWMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=O/p4SXsBC+aON+GulDWeIp5fg+d4FZUjRnnZrpqB03Q=; b=BLJDy05PMupxvdWXlb4KOKeqGH7K1+tKPydl63643ZG3K0kqVmQa2faAU2Fh0VcrKy ksLtd/c4lKi1owLKGi8KnfJGhKNmEenKaAed2eFEmzpSeYu7G8vHwIbwU9K1MuDAB8RL 2TXxdAg9Ab1leudhL5IkQJAamvmEowh/1jvZ+U0yutdraa9V+qpAczXcTUD8eaenz1Te bdKEE7RD4j9xHx80mdn1NUjqjrTbXcTb3SVCE5RfwDUXROuC583G3jVidm3njlcFcDfr oRkiNR1Gyc1lY/dWg+8Vt8Cz7LfumbLGuGOqp+2HRuApNGJZDOirVmhaMw1YyJe4Gh3C 1NlA== X-Gm-Message-State: AOAM533Hyk+6INL5oIDLTVGcReTv9ciEooRwHDN2YKei5GbkDoMeb48T uuPyJItjzwCMIRcP9H5DteU32KNjHf8= X-Google-Smtp-Source: ABdhPJzcNDvYlCgOLQfOgAMAUnj0hV7xlcvPJBorCtY+vm6urbRaRNZcfoilSYGO1hKzfP9fYYcn6Q== X-Received: by 2002:a1c:ed0a:: with SMTP id l10mr4966163wmh.151.1627052733205; Fri, 23 Jul 2021 08:05:33 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 6/6] Under conditions of high load, it was possible for xenvif to queue up very large numbers of packets before pushing them all upstream in one go. This was partially ameliorated by use of the NDIS_RECEIVE_FLAGS_RESOURCES flag. To: Martin Harvey , "win-pv-devel@lists.xenproject.org" References: <20210720132951.1776-1-Martin.Harvey@citrix.com> <20210720132951.1776-6-Martin.Harvey@citrix.com> Message-ID: Date: Fri, 23 Jul 2021 16:05:31 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 23/07/2021 15:08, Martin Harvey wrote: > > -----Original Message----- > From: win-pv-devel On Behalf Of Paul Durrant > Sent: 22 July 2021 13:44 > To: win-pv-devel@lists.xenproject.org > Subject: Re: [PATCH 6/6] Under conditions of high load, it was possible for xenvif to queue up very large numbers of packets before pushing them all upstream in one go. This was partially ameliorated by use of the NDIS_RECEIVE_FLAGS_RESOURCES flag. > >> I think you first ought to make a new version of >> VifReceiverQueuePacket() that can return a boolean value to say whether you should queue more or not. Then XENNET can be the one > to apply the backpressure (as it should be). > > Ah. Okay, think this is possibly due to a misnomer. I need to explain why I don't think that will work: As I understand it, the problem is that there aren't actually any explicit flow control signals from above. Perhaps I should have called it "Throttling" instead of backpressure, and at the moment, that throttling is internal to XenVif, because there's no way of knowing exactly how much stress/resource scarcity higher levels of the stack are under. > I guess the issue is I don't see why it is a problem for xenvif to accumulate a large quantity of data before pushing. As for flow control signals, yes, all we essentially have is the discrepancy between buffers pushed up to XENNET and those returned. This should be capped at 2048 because XENNET asserts 'low resources' at that point. > The way it's currently implemented is: > > - From Ring->PacketComplete, we allow RX_BUFFERING_MAX to be pushed upsteam per DPC. Why do we want to limit here? Is the concern that we end up pushing so much we tip XENNET into the low resource condition? If so then that's exactly where a return value from VifReceiverQueuePacket() could help. XENNET essentially says 'stop giving me packets, I'm waiting for buffers back from the stack'. > - If that fails to empty Ring->PacketComplete, we immediately schedule another DPC, this allowing other DPC's to run first, which is assumed to give higher layers a chance to digest the packets pushed up, and/or free up resources when those packets have been completed. Why is it assumed higher layers process in that fashion; they may well process in context of NdisMIndicateReceiveNetBufferLists(). More efficiency could potentially be had there by indicating more than one at once. (We used to do that but had to stop due to a bug in Server 2008 IIRC... so it may now be possible again). > - Upstream of that, we are holding Ring->PacketQueue, which gets cleared and moved to Ring->PacketComplete via ReceiverRingProcessPacket. > - This transfer of Ring->PacketQueue to Ring->PacketComplete will only happen when Ring->PacketComplete has been emptied, that subject to RX_BUFFERING_MAX constraints per DPC. > - We keep a conservative estimate of how large Ring->PacketQueue is growing. > - We expect that Ring->PacketQueue should be large enough as an imtermediate buffer to empty the entire ring, and that in cases whether throttling is underway, the packet queue will grow whilst waiting for PacketComplete to empty. > - We allow PacketQueue to grow up to a certain size: also RX_BUFFERING_MAX, so it is possible to empty the entire queue to PacketComplete and indicate all of PacketComplete up to NDIS in one go. > - If PacketQueue is about to grow larger than that, then we leave the PollDPC early, so it does not fill up the packet queue, and we allow the ring itself to back up. > > Now, of course, the reason this works at all is because we have two DPC's: PollDPC and QueueDPC. The draining from the packet queue to packet complete, and indicate up to NDIS is in the QueueDpc, and the filling of the packet queue is in the PollDPC. It is the different rates of these two DPC's that indicates whether the PacketQueue will fill or empty. The motivation for the two was so that we could use a threaded DPC for the 'heavier' work but still clear the ring quickly so TBH you could more easily apply back-pressure on the ring by dropping to a single threaded DPC to do both jobs. > >> I think the part below should now be split out into a separate function now; it's all getting a bit long to be inline. You might also >> consider a separate DPC that just does this second part so you can just use that in the case you need to defer. > >> - while (!IsListEmpty(&Ring->PacketComplete)) { >> + while ((!IsListEmpty(&Ring->PacketComplete)) >> + && ((PushedUpstream < RX_BUFFERING_MAX) || Ring->FinalFlush)) >> + { > > I am loath to create another DPC. Refactoring is all fine, but creating another DPC changes the runtime behaviour. > > I have omitted to upstream a patch which we have locally which has a large amount of stats on relative DPC rates, and also how much the two DPC's overlap each other (that is, execute concurrently). > > Agree that we need to break ReceiverRingSwizzle into a couple of separate functions, one dealing with transferring PacketQueue -> PacketComplete, and one dealing with PacketComplete -> Indicate up to NDIS. Adding another DPC totally invalidates all the profiling etc I have done. > > Given the proximity of the queuing / dpc logic to XenVif, and the lack of upstream signals from Ndis to XenNet (correct me if I am wrong), I can't see a way to easily push this logic up to XenNet. > > Let me know if you're happy with this approach. > Not really. How about the single DPC idea? Paul > MH. > From win-pv-devel-bounces@lists.xenproject.org Fri Jul 23 16:59:43 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 23 Jul 2021 16:59:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.160184.294518 (Exim 4.92) (envelope-from ) id 1m6yWS-00053y-PF; Fri, 23 Jul 2021 16:59:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 160184.294518; Fri, 23 Jul 2021 16:59:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6yWS-00053r-MM; Fri, 23 Jul 2021 16:59:40 +0000 Received: by outflank-mailman (input) for mailman id 160184; Fri, 23 Jul 2021 16:59:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6yWR-00053l-Ih for win-pv-devel@lists.xenproject.org; Fri, 23 Jul 2021 16:59:39 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 131bdd3f-e64e-4fcd-a9be-2bb3c976048a; Fri, 23 Jul 2021 16:59:37 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 131bdd3f-e64e-4fcd-a9be-2bb3c976048a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1627059577; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=Y7Rarc8wFBYc1NYByPPXZWPnTjyGAmPfFzTyiJTqdO0=; b=WseuWPq1Bue4eDCxdz3jI/GBFo6Kic6105D9rHDGeIuWV92NoxIMNnFK TTUjDKZvspB8lhuQ+d4SJpNpqGYmL0sUSvbJ30i+gEsIHdB0k/d+lD3wK KfOIH1BMaucFwqvMrnRoBLeOUooCE+mqhcFBn9RcmjNO2fCeoIkmvycXS k=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: cwJ61Y7cyFW3QCwWdUW6e2nFYeqq9qLRcUBiHY8/smsNkBlHyFDjcaOHW/GXqbUlSoxDdYF9eD EggyvzZnJRn20DTpxYZtAumtLhfGmjVAtNzLiKD/jI8BwjukN4T7fDGfuVceu4An+Ol5oP4HpV hra6zJitgEVVMdjGHuFPApllPJ/JF3virJoNnWqFXaokD6HEs6X258th5VOrzm5S3RpVyvKr4p DK9dGGfSsuLsGJgmCiLuVcWxrLmadEwKsH+kog9X9LEc528LcVOf/l/lc4zusJ/mE9en2S5mh3 Eb68AOkNEAYfhjo2QnapzGP2 X-SBRS: 5.1 X-MesageID: 48966112 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:qr0VOaOLs5UcGMBcT+X155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE9gr5K0tQ6OxoX5PwNE80lKQFk7X5WI3PYOCIghrTEGgP1/qE/9SkIVyAygc/79 YVT0EdMqyMMbESt6+Tj2fIcKdDsbz3lJxEnd2/854ud3AXV0gJ1XYPNu/xKDwOeOAyP+tDKH Pq3Ls+m9PPQwVwUi2OPAhyYwGPnayKqLvWJTo9QzI34giHij2lrJb8Dhijxx8bFwhCxL8zmF K13DAQss+Y0s2T+1v57Sv+/p5WkNzuxp9oH8qXkPUYLT3ql0KBeJlhc6fqhkFtnMifrHIR1P XcqRYpOMp+r1nLeHuunBfr0w78lB4z9n7Zz0OCi3eLm72+eNsDMbsYuWtlSGqc16NghqA47E tz5RPai3ODN2KGoMz/j+K4Gy2C2HDE+kbK2tRj/0C3arFuIIO5m7ZvsX+9IK1wVR4SoLpXY9 WGM/usr8q+UWnqIUwx7VMfgeBFYBwIb127qw45y4+o7wQ= X-IronPort-AV: E=Sophos;i="5.84,264,1620705600"; d="scan'208";a="48966112" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bp3MM1OfCY2LYAXp4ag9FlUJTaeAEgt/E7mN0M9WFd0Bvx2ewx3arHZPMesJNPYhBdtK75bwFZ7U8Edl9OEr1CH6uaMCxs10Y5xxb64wgMnrprSGbItlG7aFg30nU6/hezrrTXh0f9oXBfyN8JRLNGoOTX/MMYup3wCqfgrHxboPpunZWw+1rHFYe7TBfnbnl83b/Xws1KyMTPbbYCI/vknmRIDFFsE54muigWKnHd8r0YvOqch+qgy+9cFJAOc2psNst9LSKVkmSosxoojE5Ii2kbwRT0Ze0bVUg5PvJ0ktNaErE5HTeBKFxn9NqYp/m063uQhJwGds0fLvHl87dA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y7Rarc8wFBYc1NYByPPXZWPnTjyGAmPfFzTyiJTqdO0=; b=bff3IBksrpS15qO9mo42YQJkloE3hhmtZv0DzS1aEbbJxPV2DOFT2t+oJq9SkOenCPQZt241+YQPlbDhFepsNhdYblaWfrfvZ82nnOEXYEjE7bsLYRMYMtaOhJsUfIPv4Pkzs/jaup4PuGnSGGjgHsvA3UGRG6KFVO8Wi6bhjadEteWRLHbgJiAbiBn4ymxzSi41TeymS67QSaeW1uZGFmA45pGy4ve0CXFw7/2ijBuIlKOHqEYUTZYog5RNE82TmRH5RbJyTQ3mpAVgl0i2STMYyMyLjTjUntIliAOv/+XUVnu66HRseAJ/J3yTa68ADD76U+jvDN4MT71lFz+qIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y7Rarc8wFBYc1NYByPPXZWPnTjyGAmPfFzTyiJTqdO0=; b=kpa++ZoeLJP3RyjPfdJraYFviDofzPHP9lA71Eq3zy35PV2EIVpTcKBg1jEDg3CU5K20p20Z/zaVevYii4o0Vba0gJae3ORqFLCwo5a8ByAUvfqxYe4MBPkNPaI5dpOYMXVzad2J3HNJylU9GuD05Qj0CJgzeGhy+YL4rnWVUfU= From: Martin Harvey To: "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Subject: RE: [PATCH 6/6] Under conditions of high load, it was possible for xenvif to queue up very large numbers of packets before pushing them all upstream in one go. This was partially ameliorated by use of the NDIS_RECEIVE_FLAGS_RESOURCES flag. Thread-Topic: [PATCH 6/6] Under conditions of high load, it was possible for xenvif to queue up very large numbers of packets before pushing them all upstream in one go. This was partially ameliorated by use of the NDIS_RECEIVE_FLAGS_RESOURCES flag. Thread-Index: AQHXfWtk+tASUJTSVEWzWgTW/lHzzqtO86eAgAF5OeCAAECkgIAAFxbw Date: Fri, 23 Jul 2021 16:59:30 +0000 Message-ID: References: <20210720132951.1776-1-Martin.Harvey@citrix.com> <20210720132951.1776-6-Martin.Harvey@citrix.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a1ae2aaa-797c-4212-b02a-08d94dfb3d53 x-ms-traffictypediagnostic: MWHPR03MB2959: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: I9RZrDTT3EnQ8gRYVxUSr+lQ6epuTaiAsjuqjDN7mwuR+3m/6hOUSMy1FV4Kp4og+DsqP5kGSZgIjzoRNLvW9VJ/JU7EtO4I/HphNzVLT/r5R8hFBwAZHfua8lpyrc4H4MkYdvXVdneRp4BM5Ia/ZXJ/OWVUTI4DgbUp8KHzCqEMIyryFdrXeGJoUYaizjpGiXMQjnHWum2zUN/GaC//gh9nM4CLGPzEpZii+t36Yn8UOEanI3IOqbokaMSh5M5ktQLm7et1dqKkD9j4ORtku6eT71Qjq8s7MJNNyrEb8Q5efjRwJtp+nxgYD9cdk24Kcstr07AR+4Vy2odNVB7A4LrZJnsAfZ1eagz97JRtHkayNMoeZ4zy0+wvc5RGCW5thqIWK0nA5Wa4JIfwmW7kaYsRVa4yWUbU3dqDgfTQw0uxt9kpYvbSEXak0yPery/0hTxx0M/gr2pKN+3W7pXYwmGNxwOZ6KjjQc9iXty/A6VxW5wfZE9eWmP41z5mARHNn31Q2L0IKZaBXw6LLpVpFUtx6dwQKAvE8NQDQ7EEQKzxpPVX/9EuCxzRsmOSYg/h5RsLLRykvpzskgH71ev2QQtStD4HcL+n7NOTu7fktF44fAkSkZ76aJmwyptAQXvaihx8cxPzsK6Xd85x5tzeU8hCCtEGIm9fSRNVad8fpDxCuWQxvYgKv6Ct3MqQq67sdh+Gc2X9rs6uuu5fpBuKNf2dYpeXlB1xfCDGzv6sRnw= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6347.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(7696005)(66446008)(66476007)(8936002)(66946007)(76116006)(508600001)(26005)(71200400001)(66556008)(186003)(6506007)(8676002)(64756008)(83380400001)(53546011)(44832011)(52536014)(2906002)(86362001)(9686003)(55016002)(316002)(33656002)(5660300002)(110136005)(122000001)(38100700002)(219693003)(38070700004);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SXJjMkJKS0NlOGpUQk1TMjg2MDEvTFlVKzR3dkx5R1lvbUdjYmFoWk4wTEpr?= =?utf-8?B?eldoaGhyMW55ZGx1RmRaZ3FCZHpTWXhnejVDWnlidE9teDAwVTZMdWtFcXc2?= =?utf-8?B?T2hyVVhjMkd0ZTFUUERwK2dYajZjS2xSazUwY01tZndNL3hUVUkvajZuN2ls?= =?utf-8?B?WkdCOEdETGNFdkd5OEdpMzkwNDc4WmtxYjVMVksvMTdYU0lkbGlqTTNSYzZC?= =?utf-8?B?dXpBN3BtVkhvNlNhL3FwUWt5UUZ2OXMxUnZnWkRQSzlUZnRmamtpL3dUMEwx?= =?utf-8?B?S1RXL3N1N0kzM3ZBU1A0andqVjJnZkM3WFJzZlZZWlp3TEQrYm1jNmUvR0V4?= =?utf-8?B?NGhHdm9TdmtKZDhKL3ZRWThGbnY0VmFLWGhlRkxMdFRPVmxXYnZJNy9zUis3?= =?utf-8?B?cDFTYituQjlhM3hobGlIUzZyQ1hDR2dVNmNvU20wVkQwYVZnRHl4eitENHBp?= =?utf-8?B?MmVQakxpbXp3TlhCWFZTYlB5dVpxRGkyUFRKZmR2eFJYNSsvT2FybXozbW9F?= =?utf-8?B?eHI5WUJMQUVFRW9JOFZSR09RRURiSi9QdWQ1ZXFNK0VqakRTaHMrK2NhVURt?= =?utf-8?B?Ti9uTEJWblY5eFhPK2ZGd1d1cXhkYjBoV0FWczRQSlFNZ1BuMzJzNGR4OU1D?= =?utf-8?B?endEUEJ5U1RDU09GdWVnYzNFMnhObjdNN0kxV25QUnQ0TDhEWG04RFFXdkdY?= =?utf-8?B?YlRIVGtaTy9GMk1jZzJrTC9mdTNHelNWQmpUV3lsdWFUWDNNTzJWMmlLN1B1?= =?utf-8?B?MmppSElBb1hOcHF1TG80OFJiMWFoQ1dpVWxFVExrL2RUNHdmY29CS29jZGtK?= =?utf-8?B?NUNLQk9CVGttTkpYT3VETFRDUUMzRmh0Rjg1NnhtcjU1K04vZ0NYdzhZK216?= =?utf-8?B?bVF4MURoTUM2eEJmbmg1dlF6aWZvTWJ5cGFkQnVCdi9VU1VCUjB0T1IvM005?= =?utf-8?B?RlVqTjZ0d2VBUFJwN2dxWTlmek5TRkhPanpaaVA2aGdiaFlaR1ZsakJhQ2t4?= =?utf-8?B?blJWKzc2d2dlaDBuMk5HSWhyTmxuNWpXWU5LNE42NUk3WjBxTnNHRnJiMDJw?= =?utf-8?B?eTBwcjZYME1KZm5XMGRwWGlhKzRsa1dmN2JyQkdhVGc4RGEvTUVCaEhoUkhn?= =?utf-8?B?NkRDTDZhQjFibDNXMmh4NTNBZG8rS0hpc3BJVnQ0RCtRenlYbWVGS0JmNHR6?= =?utf-8?B?ZDUxWnBPekdnOGlnNXNqRFJGNGxmMlVSTnhtWXg4ckxLOFBGZlhNSFg3c2Iw?= =?utf-8?B?QjFiNmtTTDJFNjl6R0pVaVRqU1hCV3RvdmovRCs1WXl5dURhbXZXN2dveE1Y?= =?utf-8?B?aGF1U1NLczBIRlZEcEdTcThlZ2Y5VXU4Uzg2TXA3QWhKN1A4YThOTjNhc1Ni?= =?utf-8?B?V3RnTnRyOVVtakVBelRzWEVORTY0bVd4R0JXUzU4cWs4Y3FMS0VsVFZSKytn?= =?utf-8?B?OEVqaVZSNVRoMGpZd2VPNHpwS0pEWVJzUUFxUFUxOHkxNUE5b0J6cWVqVTdY?= =?utf-8?B?ano1VElNZG1tbTd1ajJEN2Rmbm5YQlRIY1hXTC9LSVUwZ2d2bWdmSlZWa1JY?= =?utf-8?B?Mjl6c1R2ZFpnNzFocUd1cnN0Ymhxc3d1OE9FdlM2eUZKZjdwcC9qWFd0YmlT?= =?utf-8?B?b21wUlk0YnJxRlRIMWMyUGtIalRETWNpRnZoUnlCOFBqYTcyT0VUN3U0bGJB?= =?utf-8?B?MkR0YkF1Zk05aDVTYzhSditvb05rSHRFSlljUkhmSEJsMUd4eU5sa3VyaUww?= =?utf-8?Q?yppfYF+/8D632jA8B8=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6347.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a1ae2aaa-797c-4212-b02a-08d94dfb3d53 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2021 16:59:30.9903 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: x3ixAYxg2Nwc2qftSEuLCRtusRWUfayB2IEJaLbogxJF9qXRwbiI79Ex7wKorriUpkG12FncslzX9Ao99/Y2tVhE2OjgKuKpecFGjC18GM0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2959 X-OriginatorOrg: citrix.com DQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBQYXVsIER1cnJhbnQgPHhhZGlt Z25pa0BnbWFpbC5jb20+IA0KU2VudDogMjMgSnVseSAyMDIxIDE2OjA2DQpUbzogTWFydGluIEhh cnZleSA8bWFydGluLmhhcnZleUBjaXRyaXguY29tPjsgd2luLXB2LWRldmVsQGxpc3RzLnhlbnBy b2plY3Qub3JnDQpTdWJqZWN0OiBSZTogW1BBVENIIDYvNl0gVW5kZXIgY29uZGl0aW9ucyBvZiBo aWdoIGxvYWQsIGl0IHdhcyBwb3NzaWJsZSBmb3IgeGVudmlmIHRvIHF1ZXVlIHVwIHZlcnkgbGFy Z2UgbnVtYmVycyBvZiBwYWNrZXRzIGJlZm9yZSBwdXNoaW5nIHRoZW0gYWxsIHVwc3RyZWFtIGlu IG9uZSBnby4gVGhpcyB3YXMgcGFydGlhbGx5IGFtZWxpb3JhdGVkIGJ5IHVzZSBvZiB0aGUgTkRJ U19SRUNFSVZFX0ZMQUdTX1JFU09VUkNFUyBmbGFnLg0KDQoNCj4gSSBndWVzcyB0aGUgaXNzdWUg aXMgSSBkb24ndCBzZWUgd2h5IGl0IGlzIGEgcHJvYmxlbSBmb3IgeGVudmlmIHRvIGFjY3VtdWxh dGUgYSBsYXJnZSBxdWFudGl0eSBvZiBkYXRhIGJlZm9yZSBwdXNoaW5nLiBBcyBmb3IgZmxvdyBj b250cm9sIA0Kc2lnbmFscywgeWVzLCBhbGwgd2UgZXNzZW50aWFsbHkgaGF2ZSBpcyB0aGUgZGlz Y3JlcGFuY3kgYmV0d2VlbiBidWZmZXJzIHB1c2hlZCB1cCB0byBYRU5ORVQgYW5kIHRob3NlIHJl dHVybmVkLiBUaGlzIHNob3VsZCBiZSBjYXBwZWQgYXQgMjA0OCBiZWNhdXNlIFhFTk5FVCBhc3Nl cnRzICdsb3cgcmVzb3VyY2VzJyBhdCB0aGF0IHBvaW50Lg0KDQpJIGFncmVlIHdpdGggeW91LCBp dCBpc24ndCBuZWNlc3NhcmlseSBhIHByb2JsZW0gZm9yIHhlbnZpZiB0byBhY2N1bXVsYXRlIGEg bGFyZ2UgcXVhbnRpdHkgb2YgZGF0YSBhdCB0aGF0IGxldmVsIGluIHRoZSBzdGFjay4gR2l2ZW4g dGhhdCB3ZSBwcm9iYWJseSBob2xkIGxlc3MgbWV0YWRhdGEgdGhhbiBoaWdoZXIgbGV2ZWxzL2xh eWVycyBpbiB0aGUgc3RhY2ssIGhvbGRpbmcgcGFja2V0cyB0aGVyZSBpcyBwcm9iYWJseSBiZXR0 ZXIgdGhhbiBob2xkaW5nIHRoZW0gYXQgbWFueSBvdGhlciBwbGFjZXMgaW4gdGhlIHN0YWNrLg0K DQpZZXMsIEkgYWdyZWUgdGhhdCBhbGwgd2UgaGF2ZSBpcyB0aGUgZGlzY3JlcGFuY3kgYmV0d2Vl biBidWZmZXJzIHB1c2hlZCB1cCB0byB4ZW5uZXQsIGFuZCB0aG9zZSByZXR1cm5lZC4gQWJvdmUg dGhlIHhlbm5ldCAibG93IHJlc291cmNlcyIgbGltaXQsIHllcyB3ZSBpbmNsdWRlIHRoZSBORElT X1JFU09VUkNFUyBmbGFnIHdoZW4gaW5kaWNhdGluZyBOQkwncywgYXQgd2hpY2ggcG9pbnQgZGF0 YSBpcyBjb3BpZWQgaGlnaGVyIHVwIHRoZSBzdGFjayBhbmQgdGhlIGNhbGxzIHJldHVybiBzeW5j aHJvbm91c2x5Lg0KDQpIZXJlaW4gbGllcyB0aGUgcHJvYmxlbTogVGhhdCBORElTX1JFU09VUkNF UyBmbGFnIGlzIGFjdHVhbGx5IG1ha2luZyB0aGluZ3Mgd29yc2UsIG5vdCBiZXR0ZXI6IEluIG9y ZGVyIHRvIHJldHVybiBzeW5jaHJvbm91c2x5LCB0aGVyZSBpcyBzb21lIGFsbG9jYXRpb24gYW5k IGNvcHlpbmcgZ29pbmcgb24gaGlnaGVyIHVwLg0KDQotIFRoYXQncyBhIGdvb2QgaWRlYSBpZiB0 aGUgbG93IG5kaXMgcmVzb3VyY2VzIGFyZSBhIGxvY2FsIHNob3J0YWdlIG9mIG5ldCBidWZmZXIg bGlzdHMgLyBuZXQgYnVmZmVycyAvIHN1Y2ggbGlrZSwgd2hpY2ggbmVlZCB0byBiZSBjb25zZXJ2 ZWQsIHdoaWNoIG1heSBoYXZlIGJlZW4gdGhlIGNhc2UgYmFjayBpbiB0aGUgZGF5cyBvZiBORElT MC4zDQotIEhvd2V2ZXIsIGl0J3MgYSB2ZXJ5IGJhZCBpZGVhIGlmIHRoZSBzaG9ydGFnZSBpcyBz b21lIGdsb2JhbCBzaG9ydGFnZSBvZiBQb29sIC8gTW0gc3RydWN0dXJlcyAvIHNvbWV0aGluZyBl bHNlLCBhbmQgdGhlIGJ1ZyB3ZSBzZWUgaXMgd2hlbiBoaWdoZXIgbGV2ZWwgY29weWluZyB1cCB0 aGUgc3RhY2ssIHdpdGggYSB2ZXJ5IGxhcmdlIGJhdGNoIG9mIHBhY2tldHMgYmVpbmcgaW5kaWNh dGVkIGluIG9uZSBnbywgc29tZSBvZiB0aGUgY29kZSB0aGVyZSBhc3N1bWVzIHRoYXQgYWxsb2Mg d2lsbCBzdWNjZWVkLCBhbmQgd2hvbGUgdGhpbmcgYmxvd3MgdXAuDQoNCi0gVGhlIHBvdGVudGlh bCBmaXggeW91J3JlIHRoaW5raW5nIG9mIG9mIChJIGFzc3VtZSkgaXMgdG8ga2VlcCB0cmFjayBv ZiB0aGUgIyBvZiBOQkwncyBpbmRpY2F0ZWQgdXAsIGFuZCBub3QgaW5kaWNhdGUgdXAgYW55IG1v cmUgd2hlbiB0aGF0IHJlYWNoZXMgYSBmaXhlZCBzaXplLiBUaGUgaWRlYSBiZWluZywgSSBndWVz cywgdGhhdCB3ZSBkb24ndCB1c2UgdGhlIE5ESVNfUkVTT1VSQ0VTIGZsYWcsIGJ1dCBpbnN0ZWFk IHRlbGwgWGVuVmlmIG5vdCB0byBpbmRpY2F0ZSBhbnkgbW9yZSB1cCB0aGUgc3RhY2sNCg0KSSBh bHNvIGRvbid0IHdhbnQgdG8gZG8gdGhhdCBmaXgsIGJlY2F1c2UgaXQgZG9lc24ndCBzY2FsZSB3 ZWxsLCBhbmQgaXQncyBub3Qgc29sdmluZyB0aGUgcHJvYmxlbSB3ZSBoYXZlLiBJJ20gYWxzbyBj b25jZXJuZWQgdGhhdCB3aGVuIDEwRyBiZWNvbWVzIDQwRywgYmVjb21lcyAxMDBHLiBMZXQgbWUg ZXhwbGFpbjoNCg0KVGhlIGlzc3VlIGlzIG5vdCB0aGUgdG90YWwgbnVtYmVyIG9mIHBhY2tldHMg aW5kaWNhdGVkIHVwLCBhdCBvbmUgdGltZSAod2hpY2ggbWlnaHQgdmFyeSBxdWl0ZSB3aWRlbHkp LCBidXQgdGhlIGZhY3QgdGhhdCB3ZSdyZSBwdXNoaW5nIHNvIG1hbnkgdXAgaW4gb25lIERQQyB0 aGF0IHNvbWUgTW0gcmVzb3VyY2VzIChwb29sIGV0YyBldGMpIHdoaWNoIGNhbiBiZSBncm93biBh dCBwYXNzaXZlLCBjYW4ndCBiZSBncm93biBhdCBEUEMgKGZhc3QgZW5vdWdoKSB0byBzYXRpc2Z5 IHNlY29uZGFyeSBjb3B5aW5nIHJlcXVpcmVtZW50cy4NCg0KU28gd2hhdCBJJ3ZlIHN1Ym1pdHRl ZCwgaXMgcmVhbGx5IGFuIGF0dGVtcHQgdG8gKioqcmF0ZSBsaW1pdCBwZXIgRFBDKiosIHdoaWNo IHNlZW1zIHRvIGJlIG1vcmUgc2NhbGFibGUgdGhhbiBhIGNvbnZlbnRpb25hbCBiYWNrcHJlc3N1 cmUgYWxnb3JpdGhtLiBUaGF0IGlzLCBpbiBlZmZlY3Qgd2hhdCBpdCdzIGRvaW5nIGFueXdheS4g VGhhdCB3YXksIHdlIGRvbid0IG5lZWQgdG8gbWFrZSBhbnkgYXNzdW1wdGlvbnMgYWJvdXQgb3Zl cmFsbCBidWZmZXJpbmcgYXZhaWxhYmxlLCB3ZSBvbmx5IG1ha2UgYXNzdW1wdGlvbnMgYWJvdXQg aG93IG1hbnkgcGFja2V0cyB3ZSBjYW4gcHVzaCB1cCB0aGUgc3RhY2sgZXZlcnkgdGltZSBlYWNo IENQVSBnZXRzIHRocm91Z2ggaXRzIERQQyBxdWV1ZS4NCg0KPiA+ICAgVGhlIHdheSBpdCdzIGN1 cnJlbnRseSBpbXBsZW1lbnRlZCBpczoNCj4gPiANCj4gPiAtIEZyb20gUmluZy0+UGFja2V0Q29t cGxldGUsIHdlIGFsbG93IFJYX0JVRkZFUklOR19NQVggdG8gYmUgcHVzaGVkIHVwc3RlYW0gcGVy IERQQy4NCj4gDQo+IFdoeSBkbyB3ZSB3YW50IHRvIGxpbWl0IGhlcmU/IElzIHRoZSBjb25jZXJu IHRoYXQgd2UgZW5kIHVwIHB1c2hpbmcgc28gbXVjaCB3ZSB0aXAgWEVOTkVUIGludG8gdGhlIGxv dyByZXNvdXJjZSBjb25kaXRpb24/IElmIHNvIHRoZW4gdGhhdCdzIGV4YWN0bHkgd2hlcmUgYSBy ZXR1cm4gdmFsdWUgZnJvbSBWaWZSZWNlaXZlclF1ZXVlUGFja2V0KCkgY291bGQgaGVscC4gDQpY RU5ORVQgZXNzZW50aWFsbHkgc2F5cyAnc3RvcCBnaXZpbmcgbWUgcGFja2V0cywgSSdtIHdhaXRp bmcgZm9yIGJ1ZmZlcnMgYmFjayBmcm9tIHRoZSBzdGFjaycuDQoNCldlbGwsIE9LLCBidXQgdGhl IFhlbk5ldCBudW1iZXJzIGFyZSBhbHNvIGludmVudGVkIGJ5IHVzIGFuZCBmaXhlZCwgbm90IGRl dGVybWluZWQgYXQgcnVudGltZSwgYW5kIG5vdCBiZWluZyBwYXNzZWQgZG93biBmcm9tIGhnaWVo ciBsZXZlbHMgaW4gdGhlIHN0YWNrLCBzbyBpdCdzIGp1c3QgYSBjYXNlIG9mIHdoZXJlIHdlIGlu dmVudCB0aGUgYXJiaXRyYXJ5IG51bWJlcnMuIElmIHdlJ3JlIGdvaW5nIHRvIGludmVudCBzb21l IGxpbWl0LCBJIHdvdWxkIHByZWZlciBpdCB0byBiZSBhIHJhdGUgcGVyIERQQyBsaW1pdCwgdGhh biBhIGZpeGVkIG51bWJlciBvZiBidWZmZXJzIG91dHN0YW5kaW5nLiBYZW5WaWYgaXMgcmlnaHQg cGxhY2UgdG8gY2hhbmdlIERQQyBzY2hlZHVsaW5nIGJlaGF2aW91ci4NCg0KQWxzbywgZm9yIFhl bk5ldCB0byBzYXkgeWVzL25vIGJhc2VkIG9uIGhvdyBtYW55IHBhY2tldHMgcGVyIGJhdGNoICh3 aGljaCBJIGd1ZXNzIGlzIG5vdCB3cm9uZyksIGl0J3MgaGF2aW5nIHRvIHdvcmsgb3V0IHdoZXJl IHRoZSBiYXRjaGVzIGJlZ2luIGFuZCBlbmQgYmFzZWQgb24gdGhlICJsYXN0IiBmbGFnIHBhc3Nl ZCB1cCBmcm9tIFhlblZpZiwgd2hpY2ggaXMgT0ssIGJ1dCBmZWVscyBtb3JlIGtsdWRneSB0aGFu IGEgbGltaXQgb24gYSB3aGlsZSBsb29wLg0KDQo+IC0gSWYgdGhhdCBmYWlscyB0byBlbXB0eSBS aW5nLT5QYWNrZXRDb21wbGV0ZSwgd2UgaW1tZWRpYXRlbHkgc2NoZWR1bGUgYW5vdGhlciBEUEMs IHRoaXMgYWxsb3dpbmcgb3RoZXIgRFBDJ3MgdG8gcnVuIGZpcnN0LCB3aGljaCBpcyBhc3N1bWVk IHRvIGdpdmUgaGlnaGVyIGxheWVycyBhIGNoYW5jZSB0byBkaWdlc3QgdGhlIHBhY2tldHMgcHVz aGVkIHVwLCBhbmQvb3IgZnJlZSB1cCByZXNvdXJjZXMgd2hlbiB0aG9zZSBwYWNrZXRzIGhhdmUg YmVlbiBjb21wbGV0ZWQuDQoNCj5XaHkgaXMgaXQgYXNzdW1lZCBoaWdoZXIgbGF5ZXJzIHByb2Nl c3MgaW4gdGhhdCBmYXNoaW9uOyB0aGV5IG1heSB3ZWxsIHByb2Nlc3MgaW4gY29udGV4dCBvZiBO ZGlzTUluZGljYXRlUmVjZWl2ZU5ldEJ1ZmZlckxpc3RzKCkuDQoNCkJlY2F1c2UgdGhlIE5ESVMg ZG9jdW1lbnRhdGlvbiBzYXlzLCBvciBhdCBsZWFzdCBpbXBsaWVzLCB0aGF0IHdpdGhvdXQgdGhl IE5ESVNfUkVTT1VSQ0VTIGZsYWcsIHBhY2tldHMgYXJlIGxpa2VseSB0byBiZSBoYW5kbGVkIGFz eW5jLCBhbmQgd2l0aCB0aGF0IGZsYWcsIHRoZXkncmUgbGlrZWx5IHRvIGJlIGhhbmRsZWQgc3lu Y2hyb25vdXNseS4NCg0KPiBOb3csIG9mIGNvdXJzZSwgdGhlIHJlYXNvbiB0aGlzIHdvcmtzIGF0 IGFsbCBpcyBiZWNhdXNlIHdlIGhhdmUgdHdvIERQQydzOiBQb2xsRFBDIGFuZCBRdWV1ZURQQy4g VGhlIGRyYWluaW5nIGZyb20gdGhlIHBhY2tldCBxdWV1ZSB0byBwYWNrZXQgY29tcGxldGUsIGFu ZCBpbmRpY2F0ZSB1cCB0byBORElTIGlzIGluIHRoZSAgUXVldWVEcGMsIGFuZCB0aGUgZmlsbGlu ZyBvZiB0aGUgcGFja2V0IHF1ZXVlIGlzIGluIHRoZSBQb2xsRFBDLiBJdCBpcyB0aGUgZGlmZmVy ZW50IHJhdGVzIG9mIHRoZXNlIHR3byBEUEMncyB0aGF0IGluZGljYXRlcyB3aGV0aGVyIHRoZSBQ YWNrZXRRdWV1ZSB3aWxsIGZpbGwgb3IgZW1wdHkuDQoNCj4gVGhlIG1vdGl2YXRpb24gZm9yIHRo ZSB0d28gd2FzIHNvIHRoYXQgd2UgY291bGQgdXNlIGEgdGhyZWFkZWQgRFBDIGZvciB0aGUgJ2hl YXZpZXInIHdvcmsgYnV0IHN0aWxsIGNsZWFyIHRoZSByaW5nIHF1aWNrbHkgc28gVEJIIHlvdSBj b3VsZCBtb3JlIGVhc2lseSBhcHBseSBiYWNrLXByZXNzdXJlIG9uIHRoZSByaW5nIGJ5IGRyb3Bw aW5nIHRvIGEgc2luZ2xlIHRocmVhZGVkIERQQyB0byBkbyBib3RoIGpvYnMuDQoNCldlbGwgaGVy ZSdzIHRoZSB0aGluZyBhYm91dCBidWZmZXJpbmcuIEhpZ2hlciBsZXZlbCBwcm90b3MgbGlrZSBU Q1AgaGF2ZSBvbmx5IHRoZSBiYW5kd2lkdGgtZGVsYXkgcHJvZHVjdCB0byB3b3JrIG91dCB0aGUg YnVmZmVyaW5nLCBhbmQgdGhlIGxvc3MgcmF0ZSB0byBkZXRlcm1pbmUgY29uZ2VzdGlvbiBvciBy ZXNvdXJjZSBzdGFydmF0aW9uLiBTbyBvZiBjb3Vyc2UsIHRoZSBuZXdiaWUgYXBwcm9hY2ggaXMg dG8gYnVmZmVyIGF0IGFsbCBjb3N0cywgYnV0IHRoYXQgdGVuZHMgdG8gbWFrZSBjYWNoZSBiZWhh dmlvdXIgd29yc2UsIGFuZCBzbG93IGV2ZXJ5dGhpbmcgZG93biwgd2hlbiB0aGUgcmlnaHQgdGhp bmcgdG8gZG8gaXMgdG8gb3ZlcmZsb3cgZml4ZWQgc2l6ZSBidWZmZXJzIHRvIGdpdmUgdGhlIHJp Z2h0IHNpZ25hbHMgdG8gaGlnaGVyIGxldmVsIHByb3RvcyB0aGF0IHRoZXkgbWlnaHQgd2FudCB0 byBiYWNrIG9mZi4NCg0KU28gSSdtIG5vdCBvdmVybHkgY29uY2VybmVkIGFib3V0IG5vdCBjbGVh cmluZyB0aGUgcmluZzogSSB3b3VsZCBwcmVmZXIgdG8gZHJvcCB0aGUgb2RkIHBhY2tldCB0aGFu IHRvIGZyYW50aWNhbGx5IGNsZWFyIHRoZSByaW5nIGFuZCBidWZmZXIgc28gbXVjaCB0aGF0IGNh Y2hlIGJlaGF2aW91ciBnZXRzIHdvcnNlIGFuZCBpdCBzbG93cyB0aGluZ3MgZG93biAod2hpY2gg dGhlbiBpbmNyZWFzZXMgYi93IGRlbGF5IHByb2R1Y3QsIHdoaWNoIHRoZW4gbGVhZHMgdG8gbW9y ZSBidWZmZXJpbmcuLi4pDQoNCj4gPiANCj4gPiBMZXQgbWUga25vdyBpZiB5b3UncmUgaGFwcHkg d2l0aCB0aGlzIGFwcHJvYWNoLg0KPiA+IA0KPg0KPiBOb3QgcmVhbGx5LiBIb3cgYWJvdXQgdGhl IHNpbmdsZSBEUEMgaWRlYT8NCg0KSHVtbS4gU28gaW4gYSBzaW5nbGUgRFBDLCB3ZSdkIGdvIGZy b20gdG9wIHRvIGJvdHRvbToNCg0KLSBJbmRpY2F0ZSBhcyBtdWNoIG91dCBvZiBwYWNrZXQgY29t cGxldGUgYXMgd2UgY291bGQgdG8gTkRJUyAoYnV0IHdlJ3JlIGludmVudGluZyBhIGZpeGVkIGxp bWl0IGhlcmUpDQotIE1vdmUgYXMgbXVjaCBmcm9tIHBhY2tldHF1ZXVlIHRvIHBhY2tldGNvbXBs ZXRlIGFzIHdlIGNvdWxkIChpbnZlbnRpbmcgYW5vdGhlciBmaXhlZCBsaW1pdCkNCi0gTW92ZSBm cm9tIHJpbmcgdG8gcGFja2V0cXVldWUgKHNhbWUgbGltaXQgYXMgcGFja2V0Y29tcGxldGUgYWJv dmUpDQotIEFuZCBpZiByaW5nIG92ZXJmbG93cywgdG91Z2ggY29va2llcy4NCg0KSSBqdXN0IHRo aW5rIHRoYXQgSSdkIGZhciBwcmVmZXIgdG8gcmF0ZSBsaW1pdCBwZXIgRFBDIHVubGVzcy91bnRp bCBORElTIHByb3ZpZGVkIHNvbWUgdXNlZnVsIG1lY2hhbmlzbSBmb3IgdGVsbGluZyB1cyBob3cg dG8gc2l6ZSByaW5ncyAvIGJ1ZmZlcnMgLyBhbW91bnQgb2Ygc3R1ZmYgeW91IGNhbiByZWFzb25h Ymx5IGhhdmUgb3V0c3RhbmRpbmcgdXAgdGhlIHN0YWNrIChtb3N0IG9mIHdoaWNoIGdldHMgcHJv Y2Vzc2VkIGF0IGRpc3BhdGNoIGFueXdheSkuDQoNClRoZSBhYm92ZSBub3R3aXRoc3RhbmRpbmcu IFdlIGhhdmUgNiBtb250aHMgb2YgdGVzdGluZyB3aXRoIHRoaXMgYXBwcm9hY2gsIGFuZCBpdCBz ZWVtcyB0byB3b3JrIHF1aXRlIG5pY2VseS4NCkkgY2FuIGRvIHNvbWUgZGVncmVlIG9mIHJld29y aywgYnV0IHRoaXMgdGhlbiBpbnZhbGlkYXRlcyBhbGwgb3VyIHBlcmZvcm1hbmNlIHJlc3VsdHMs IGFuZCBJJ2xsIGhhdmUgdG8gcmVzdWJtaXQgeW91IGEgcmF0aGVyIGRpZmZlcmVudCBwYXRjaCBp biAzLTYgbW9udGhzIHRpbWUuDQoNCk1ILg0KDQoNCiANCg0K From win-pv-devel-bounces@lists.xenproject.org Wed Jul 28 07:46:23 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 28 Jul 2021 07:46:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.161384.296329 (Exim 4.92) (envelope-from ) id 1m8eGj-00052l-4s; Wed, 28 Jul 2021 07:46:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 161384.296329; Wed, 28 Jul 2021 07:46:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m8eGj-00052e-29; Wed, 28 Jul 2021 07:46:21 +0000 Received: by outflank-mailman (input) for mailman id 161384; Wed, 28 Jul 2021 07:46:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m8eGh-00052Y-Su for win-pv-devel@lists.xenproject.org; Wed, 28 Jul 2021 07:46:19 +0000 Received: from mail-wm1-x333.google.com (unknown [2a00:1450:4864:20::333]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9d172a9a-7151-4cd6-95b3-d6176bd849b5; Wed, 28 Jul 2021 07:46:19 +0000 (UTC) Received: by mail-wm1-x333.google.com with SMTP id h24-20020a1ccc180000b029022e0571d1a0so1006791wmb.5 for ; Wed, 28 Jul 2021 00:46:18 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:3c1b:f253:3ecb:e18d? ([2a00:23c5:5785:9a01:3c1b:f253:3ecb:e18d]) by smtp.gmail.com with ESMTPSA id h12sm3227029wrm.62.2021.07.28.00.46.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jul 2021 00:46:17 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 9d172a9a-7151-4cd6-95b3-d6176bd849b5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Uv1S+QBZXiDVAMBGtMj7dCZgYHuWhfnI1r6HOsHtxk4=; b=k6vpP1H04YD6jpAnBOG1wZSpI5tFa2cS9C6hwI0N9mViOsEH3/CNHn5+9JZb2QX+k8 aHz5buO4FCYB6LfXFSQdNqre3YKjfkborH6iHvEHjsiNjQGNR2WFIIceJMQkhSQTH409 2iFzNVwY8zxw25wE8BmTvPxppMSvK3ic5XOzCspCG7XKumTcftiIl4qCTgJ2vhq0XJHs lJ7TXl9M+7JDtIibiDLkD2OkzEDLmrUDWEcAuoefsRsdZOd65viWcTsXmO8qwX/hWZdd 5KY/dpGmpUWO5u6EUv+lT2hTwVXLIH8ggba9cEfiROVL0nOAh4vUg4tSsReHuefutAA/ Hr5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Uv1S+QBZXiDVAMBGtMj7dCZgYHuWhfnI1r6HOsHtxk4=; b=EsluXjBStMtHcPGP9O4wgKcdprazQVRynNRRRa7S8fMX25n2/XhNCt6tK0xoBIHez7 2q9eXdoDI89/zTXI9hofCLMhDgQk1z0PoDEkjjRjpqi97MP+DZgH7kJJnvJ3EmrYAb0z 25AdXXGZH44T4QwMWACoorCo5mDPbaIGgsesEXv1cXPpjHoceVx8IvshpOzKWqICJojS KlgYr3ZEWF2rh0PSBEctIyoiVkivfGpWzVv/D4rvwkI1pXnF1I68qTnJhDkeNMwO0G41 dDyRHxdfrJFdT4xA+4Pc0qWBMINCRELPeeKd0U8924rAS11RUugoCsRrcv6T/XM7z6dO XdGg== X-Gm-Message-State: AOAM5312plMwGj9pjIpzvpkiNqyiJordC9gwn5A67u5hXCDLUbD4nTcb IG/fMkWeh9QnTh23XCtoZVqIVOI4aww= X-Google-Smtp-Source: ABdhPJxljhZ0I5M1V1Br4Ctjb+rS+jVgEatbaAuTbCXotBt0RfmucSenmE9FhNAr5b4QUHq0TPjB6A== X-Received: by 2002:a05:600c:3b26:: with SMTP id m38mr7984100wms.80.1627458378129; Wed, 28 Jul 2021 00:46:18 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 6/6] Under conditions of high load, it was possible for xenvif to queue up very large numbers of packets before pushing them all upstream in one go. This was partially ameliorated by use of the NDIS_RECEIVE_FLAGS_RESOURCES flag. To: Martin Harvey , "win-pv-devel@lists.xenproject.org" References: <20210720132951.1776-1-Martin.Harvey@citrix.com> <20210720132951.1776-6-Martin.Harvey@citrix.com> Message-ID: <9c224f21-2e9c-6160-1eb6-b5c4ca94b71f@xen.org> Date: Wed, 28 Jul 2021 08:46:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 23/07/2021 17:59, Martin Harvey wrote: [snip] >>> >>> Let me know if you're happy with this approach. >>> >> >> Not really. How about the single DPC idea? > > Humm. So in a single DPC, we'd go from top to bottom: > > - Indicate as much out of packet complete as we could to NDIS (but we're inventing a fixed limit here) Well, we could do away with low resources and have NDIS take everything we can throw at it, but some upper bound seems reasonable and it's an upper bound in one place. > - Move as much from packetqueue to packetcomplete as we could (inventing another fixed limit) > - Move from ring to packetqueue (same limit as packetcomplete above) No, with a single DPC we don't have separate packet queue and packet complete; that's the point. > - And if ring overflows, tough cookies. > How does a ring overflow? If there's no space in the ring then netback has nowhere to put stuff so it puts back-pressure on its queuing discipline; which is pfifo by default but could be something that doesn't tail drop. > I just think that I'd far prefer to rate limit per DPC unless/until NDIS provided some useful mechanism for telling us how to size rings / buffers / amount of stuff you can reasonably have outstanding up the stack (most of which gets processed at dispatch anyway). > > The above notwithstanding. We have 6 months of testing with this approach, and it seems to work quite nicely. > I can do some degree of rework, but this then invalidates all our performance results, and I'll have to resubmit you a rather different patch in 3-6 months time. > I would very much prefer that we don't band-aid the two-DPC approach if it is not doing the right thing. Paul From win-pv-devel-bounces@lists.xenproject.org Wed Jul 28 12:48:22 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 28 Jul 2021 12:48:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.161531.296546 (Exim 4.92) (envelope-from ) id 1m8iyy-0007v0-2K; Wed, 28 Jul 2021 12:48:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 161531.296546; Wed, 28 Jul 2021 12:48:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m8iyx-0007us-VU; Wed, 28 Jul 2021 12:48:19 +0000 Received: by outflank-mailman (input) for mailman id 161531; Wed, 28 Jul 2021 12:48:19 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m8iyw-0007uj-Ry for win-pv-devel@lists.xenproject.org; Wed, 28 Jul 2021 12:48:19 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9a13dad2-e114-40cc-807f-8247cca2558b; Wed, 28 Jul 2021 12:48:17 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 9a13dad2-e114-40cc-807f-8247cca2558b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1627476497; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=XhSSzWhvv6P5f4R2KfuROCDOwtVUnzhb/Txy4HtXqjU=; b=PX2KbdEiaG2kHxf2yry65Nj/n0+2FD6hLcXdLzI45yMuHGfiLa+kD40Z 77ah1IAy15a0WmNO8gNJi5oH4YrvyjlXyPWDjXGAgiI5CRVfLrHMwkUBf UUSxK27Qt2PML6MEcewAxTtmms3yMBOIMEum3RtFOLmqeuqfyZ0ctj9vD 4=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: TFzah+GWOgfoFrDtjTRqYbf1Trdn7o0MMwa4R5Ze/3QoiJjRUh99xpU/P8NanyYbZfcIdZlNPE iX8FN/7PYvNkAfNY3bFDNnhshLkjGTqsF3PqGJFEnrl0jGLXWkNn4yPjrRYWmM438NT07Zub4N s4s1yfCQhfKvnjOMRmIEmZJAL7+SFhz7i3AagfkOjy6AYANBT8WzY24KWwWWRXnGpSx1fD2C/M f4ixfKwOtXtY6LBz5doRcmAlc1PWBZWCbSx5yUjC1oecNmwwv7fyQk6zvEsqudsWntS4HY6luU 2vhiO2KCjEFtCzZ7KweprQUo X-SBRS: 5.1 X-MesageID: 49650020 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:uRrHvqol7MNjVcqrdD/v9xEaV5o4eYIsimQD101hICG9E/bo9P xG885w6faZslsssRIb+exoWpPvfZq0z/ccirX5W43PYOCMggqVxe9ZgrcLB1bbakjDHik379 YDT5RD X-IronPort-AV: E=Sophos;i="5.84,276,1620705600"; d="scan'208";a="49650020" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cj+NAygMvM0HjdkWjik8NWOExSnOFmS0Sb0Breu2UOhEthjgU9GaG3pDOCJg/qCaDNhdc4LWBdrEEBAS7kAL3t4KOsOkFnjV25nq86ONlZJExoavSviGQZ8zSVknhY0Nf9ZoWNVuR9y3xSk9fOkQ6FeODPn19Nn+DlJGj/mazl0pXXSmLwcDt3ugRAchv2hTOnHwyMWYlV/PmLgjfB7tQWOX7CvScclsmVoN/yl8/IqoNsY4GQsI1fHIGN8bH9dXKOA1+J8bgNXIVTNZRnrr3sO1RAyGawaRzjWbNQRCAkZ60qJFlMsFvJXKCbRQOQFD3V0GUrD6k15VybkH/+VK1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XhSSzWhvv6P5f4R2KfuROCDOwtVUnzhb/Txy4HtXqjU=; b=Jfeg7W/yZJlWh2qJlcgAESpaLId3EYs8Do4UkbRfr8XKQDhcPD2M9GJ9/8/5L4TcHSXn2BNr3Sk3ZanKP4wYCTY3uI2GHZbOrWZPRJPPGHBhjrDkro7PJTo8iw1XC5fta4BJ76JGlv80d5LBQxSou2473buMZC203kfhzkdiGLHidFWVQtBadxM5vKs9roUDnPddV1L+9MHWXN/8DFApLbnEYf0E19EZBtp2LuhZ4zuQcibHY9rOLCpEFPT0TWl47rLqgHw5rh0DJVjHzgB3HeDkOW3uryAr0PYWlrLQnGhKL9/CVQJ4dMW3+A3nET0+ef6OsQjhwvWmCeNws1cADw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XhSSzWhvv6P5f4R2KfuROCDOwtVUnzhb/Txy4HtXqjU=; b=gq7ya+44rur1moZFxT4h2p6UarmKsyCpNM/U5NVxngGSmV+J+bnc4ZncnIXF0JU0GoevhMQooO4E5GxAlRvLl1BX1BvQbk4dYP2G4Es/NZb7Udy5h5w4a6yHVu/wmQZPnjGQ3jd6IzRPIy7ImP2Y14L5Pl/ur4HH+KU2HyqIiMY= From: Martin Harvey To: "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Subject: RE: [PATCH 6/6] Under conditions of high load, it was possible for xenvif to queue up very large numbers of packets before pushing them all upstream in one go. This was partially ameliorated by use of the NDIS_RECEIVE_FLAGS_RESOURCES flag. Thread-Topic: [PATCH 6/6] Under conditions of high load, it was possible for xenvif to queue up very large numbers of packets before pushing them all upstream in one go. This was partially ameliorated by use of the NDIS_RECEIVE_FLAGS_RESOURCES flag. Thread-Index: AQHXfWtk+tASUJTSVEWzWgTW/lHzzqtO86eAgAF5OeCAAECkgIAAFxbwgAdJ2QCAAFJ2MA== Date: Wed, 28 Jul 2021 12:48:08 +0000 Message-ID: References: <20210720132951.1776-1-Martin.Harvey@citrix.com> <20210720132951.1776-6-Martin.Harvey@citrix.com> <9c224f21-2e9c-6160-1eb6-b5c4ca94b71f@xen.org> In-Reply-To: <9c224f21-2e9c-6160-1eb6-b5c4ca94b71f@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 66c585c0-c0a3-42d0-17a6-08d951c5f392 x-ms-traffictypediagnostic: MWHPR03MB3102: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FYdv5i1xZXaaTxprJw38K0WPb6dqhtimhdqgplEXPiHHLwYihBm4OEcZzA8TSlKfa0qtWn31YfQpChqUPjGP7SIIHtGmDgKII7GV62M73UUFsoCxcdM1rS25XNP7l3CNQat3k8NOmzxHgKiy1pQwgpilxd9g7PR8NGA1/3PgAC7sb3Kd2gYAse+oJ4OVRQerUdZ4ZmJF53Yz1l4WB1KOLckEVfV0D17SUry8DT4RaqhJxngOmp6IpfJhXCDORTev6LwVbmFOOmG53/S9Q/mDPoNvYgpUHwGi3RES965HvV4j/2lokw5e510Mg2hPQ6r71TFMJQ6Pt7P9i7/+IP6s5wGzuiC46jehVOppLPwICCKLhVU3WKYHZxbFErNkwq7dfoCgVsydYftk4fT7G1Qa5wbyQMOGpRGCh2bU64VuwExtZCD5CiNPLN4u1zaTy/aPTRv9rCQOL2haXMPQfV8G+tOivzzRa0LSpBEOHwe0bbgZw/zr6TQWmYjjmEwM77WIE8piU/W+L6PmCr9rsoe4RoBdIM6tFcIAR5GLsB1KOcZh+Pdrd13ULHMtk1eHgyJmLmRPFnwH6jXqv+rlTjsc75vlbHjITk47yn6h2d+GYn0rnmyYifouF3x6b76OumZgktIV7POBGEuq4OWrLn99z6Yd2VuImWitJ/ZSQ0hSz+4Wq4bORxv4b2JVMnuHK8KxNP3rvKGuYmVjBgC/EMFON3vIMzA2lj9Nz5Y2vp+/xto= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6347.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(346002)(376002)(136003)(396003)(366004)(44832011)(52536014)(5660300002)(38070700005)(86362001)(8936002)(8676002)(26005)(316002)(478600001)(33656002)(55016002)(9686003)(71200400001)(2906002)(53546011)(6506007)(76116006)(64756008)(66446008)(38100700002)(83380400001)(122000001)(66946007)(7696005)(110136005)(66556008)(66476007)(186003)(219693003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?YmhKdHVtOGtSWkVFV1A3aXRHd2NTTmRGVkJsUDhnV21LNnYxVnJZcWQ0SDR5?= =?utf-8?B?a2R4YmkvNG1vaFVGV0E1SkJtTy84M2lVZnlGaGlTNGZCU0lEU0lSU1JXTkZH?= =?utf-8?B?cng2VkhlaG44YlR1VCtYdGlGT1hvYXdQWjFVWnZ0MFM0RXRVYjVQVkM4b1Rt?= =?utf-8?B?SWVkeXAzM00xdENtUVVGTHo5WVZ6L05zbEMzU2RjMW1BUSt5dkZncG5PWnRE?= =?utf-8?B?angvZDBaQ1dMTHZCc1l5dzRFM1RXRXoydXNFSkhoNTVYeStlQ3hXZ2lud2NC?= =?utf-8?B?TUZuVitDRnN0bytYZERWc3V1M3JxU2Jwd3hqVWtJM05yT0ZCbG1QZVNUc3Vh?= =?utf-8?B?MVB6c0ViTk5nWHl3dkNsczMwV0JTZ3VJUG1qTjE1VmlFWFBjbzl3N2txNCtJ?= =?utf-8?B?eWpTa0k4NC9nbU5RdXhBSldKaDVWQkJsa3Nrcm9tOG81b2llVVUxZS9WdWJL?= =?utf-8?B?cU50L2FqTFZReHl4Yzk3TlhVRVMza1BSa3NlUDZLdGVNQ3JxdHZvREVQRkJn?= =?utf-8?B?TXNheWhObTFFTFNNMVdqcmR6Qmp3b3ltU24wTmhWSDgwRnVOaXNiSUE0RVJ0?= =?utf-8?B?dWN1M0U4b1JhT2JzRWpNOGZvR3hFQ0dWaHhVN3haUEtFR2V3K3NOVk0rOU5V?= =?utf-8?B?T1JncGpCUDI0c205end0NHd5dTA1MEJOcE9IMmpVN2dNV2JNM25BeHY3T2FI?= =?utf-8?B?a28yWHV4UUZlb0xWOThxQUNsMndrUnB6eVVNcVJlT21VQjFraUhzeFhHelk1?= =?utf-8?B?Um1KQ3ZWTGR0K012OXFWZm4zKytUOHVkSzg5WEpleUdOdFg1bVdTK0ZlTWsv?= =?utf-8?B?QVNLT0F4Z25xeG5abDc2WGxlZWZiZjdwWmtIZkNTR0RMa0R1VkVzdW9pTVBK?= =?utf-8?B?VUZveVBhcFB4U0w4NlBZT3FmSk5wVWpPbUM5YkM3ZXJwZnErWlJjNFNlNU1z?= =?utf-8?B?V0hzcjh1SjVjcDdnRVpONHY2WlVxWUhmN1o2Si9WTHVqZjVJWTI3TEFDdXps?= =?utf-8?B?aGtzZ2l2U1JPYUtjRDVaamZHcVFvWDlCa0VHdkVlT2NqVjJuSlRFVmVReHhF?= =?utf-8?B?TjllWDBrWmdlU29obXo1dE5kbXBHT2J2VjFRcFVFSlVYNzRwRUsrcWJXL0xw?= =?utf-8?B?TXFrbHpHK2lvbm1JSUpNY3JXSS9TeS9iVnVFSTcxZW1adVFnNGRtczNENlho?= =?utf-8?B?SXlZS2o5dTdyOVNieGNuMmxGcnhGeFpNbThyZFB0S0hOZUdpZXVSVEY5bkFp?= =?utf-8?B?SVhwaU84L05INFU1cXJMVTZmMVovZFBkcmZMOUV4dThBRUxhQ2RSUmNYeXVP?= =?utf-8?B?dHBRQTBjRWpmdUMzSDJiVW9EQTJBcXY2THF1ajF2Y2Z3OVROQnVCdGFlSG1M?= =?utf-8?B?S2V3dnlWT2R0MXBnaXh2azJUVHpUUExQeEF3WE1IV2p1RDlid2JtU2IvRmw3?= =?utf-8?B?cEhhY2pvUzVLYWVSeElwL0xHYTR3SWlmK2hJT0F6cGRSelcxNXZPZU1iV2pu?= =?utf-8?B?NlZ5cDc2aHZnMVFvaWo4U2lDSkpRMHgwK1dBUVh0LzFyV2lnbU05U0E4Vk9K?= =?utf-8?B?RllRWWVuV1J5N2hyd0hCcmdaUFViYVBLc0xsNCtGOWpTajZJQndXL2xYcmlo?= =?utf-8?B?MFNFUFJ3N3EvMUptSDczc0s5bmU3QnIrUlZ5MEsrS0Jkblg5OGdLaVhQLzcv?= =?utf-8?B?YjdJeXlpS1EzdUtaVTh5WXArOFBDbThYOTRTR29hQ3U1aVVia1Y3dUtReStP?= =?utf-8?Q?zmVejK7GVkJul1m+odGNH0IXXQe0nGfadkD7z97?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6347.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 66c585c0-c0a3-42d0-17a6-08d951c5f392 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2021 12:48:08.5873 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4v4Uf0GL9aznP9Q55kS06nQQGxTk6It2p8oebMCVmp8HAar+W7ibrKiGC2Yc74yTvbeSdFOHpfPaN4+a/Svzp3YUfOuwP5yklPEZMtrUHt4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB3102 X-OriginatorOrg: citrix.com DQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBQYXVsIER1cnJhbnQgPHhhZGlt Z25pa0BnbWFpbC5jb20+IA0KU2VudDogMjggSnVseSAyMDIxIDA4OjQ2DQpUbzogTWFydGluIEhh cnZleSA8bWFydGluLmhhcnZleUBjaXRyaXguY29tPjsgd2luLXB2LWRldmVsQGxpc3RzLnhlbnBy b2plY3Qub3JnDQpTdWJqZWN0OiBSZTogW1BBVENIIDYvNl0gVW5kZXIgY29uZGl0aW9ucyBvZiBo aWdoIGxvYWQsIGl0IHdhcyBwb3NzaWJsZSBmb3IgeGVudmlmIHRvIHF1ZXVlIHVwIHZlcnkgbGFy Z2UgbnVtYmVycyBvZiBwYWNrZXRzIGJlZm9yZSBwdXNoaW5nIHRoZW0gYWxsIHVwc3RyZWFtIGlu IG9uZSBnby4gVGhpcyB3YXMgcGFydGlhbGx5IGFtZWxpb3JhdGVkIGJ5IHVzZSBvZiB0aGUgTkRJ U19SRUNFSVZFX0ZMQUdTX1JFU09VUkNFUyBmbGFnLg0KDQo+IFdlbGwsIHdlIGNvdWxkIGRvIGF3 YXkgd2l0aCBsb3cgcmVzb3VyY2VzIGFuZCBoYXZlIE5ESVMgdGFrZSBldmVyeXRoaW5nIHdlIGNh biB0aHJvdyBhdCBpdCwgYnV0IHNvbWUgdXBwZXIgYm91bmQgc2VlbXMgcmVhc29uYWJsZSBhbmQg aXQncyBhbiB1cHBlciBib3VuZCBpbiBvbmUgcGxhY2UuDQoNClllcywgSSBhZ3JlZSB0aGF0J3Mg dGhlIHJpZ2h0IHRoaW5nIHRvIGRvLg0KDQo+IE5vLCB3aXRoIGEgc2luZ2xlIERQQyB3ZSBkb24n dCBoYXZlIHNlcGFyYXRlIHBhY2tldCBxdWV1ZSBhbmQgcGFja2V0IGNvbXBsZXRlOyB0aGF0J3Mg dGhlIHBvaW50Lg0KDQpPSywgSSBzZWUgd2hhdCB5b3UgbWVhbiAtIHlvdSdkIGp1c3QgZ28gZnJv bSByaW5nIHRvIGNvbXBsZXRlIGluIG9uZSB0aHJvdWdoIHN0ZXAuDQoNCj4gLSBBbmQgaWYgcmlu ZyBvdmVyZmxvd3MsIHRvdWdoIGNvb2tpZXMuDQoNCj4gSG93IGRvZXMgYSByaW5nIG92ZXJmbG93 PyBJZiB0aGVyZSdzIG5vIHNwYWNlIGluIHRoZSByaW5nIHRoZW4gbmV0YmFjayBoYXMgbm93aGVy ZSB0byBwdXQgc3R1ZmYgc28gaXQgcHV0cyBiYWNrLXByZXNzdXJlIG9uIGl0cyBxdWV1aW5nIGRp c2NpcGxpbmU7IHdoaWNoIGlzIHBmaWZvIGJ5IGRlZmF1bHQgYnV0IGNvdWxkIGJlIHNvbWV0aGlu ZyB0aGF0IGRvZXNuJ3QgdGFpbCBkcm9wLg0KDQpJIHNob3VsZCBjbGFyaWZ5IEkgd2FzIGFzc3Vt aW5nIHRoZSB0aGluZyB1cHN0cmVhbSB3YXMgZHVtYi4gQmV0dGVyIHRvIHNheSwgaWYgdGhpbmdz IGJhY2sgdXAgdXBzdHJlYW0sIHRoZW4gdG91Z2ggY29va2llcy4gVGhhdCBtaWdodCBpbnZvbHZl IHRhaWwgZHJvcHMgb3IgaC93IHRocm93YXdheXMgc29tZXdoZXJlLg0KDQo+IEkgd291bGQgdmVy eSBtdWNoIHByZWZlciB0aGF0IHdlIGRvbid0IGJhbmQtYWlkIHRoZSB0d28tRFBDIGFwcHJvYWNo IGlmIGl0IGlzIG5vdCBkb2luZyB0aGUgcmlnaHQgdGhpbmcuDQoNCk9LLiBXZWxsIEkgd2lsbCBo YXZlIHRvIGdvIGJhY2sgYW5kIGhlYWQtc2NyYXRjaCBmb3IgYSBiaXQuIFBlcmhhcHMgdGhlIGJl c3Qgd2F5IHRvIHByb2NlZWQgaXM6DQoNCi0gSSByZXN1Ym1pdCB0aGVzZSBwYXRjaGVzIHdpdGgg eW91ciBzdWdnZXN0ZWQgY2hhbmdlcyBleGNlcHQgdGhlIGxhc3Qgb25lLCBzbyBJIGNhbiBnZXQg bW9zdCBvZiBteSB1cHN0cmVhbWluZyBkb25lLg0KLSBDb25zaWRlciBob3cgdG8gcmV3b3JrIHRo ZSBsYXN0IG9uZS4gR2VuZXJhbCBhcHByb2FjaCBiZWluZyB0byBub3QgdXNlIE5ESVNfRkxBR1Nf UkVTT1VSQ0VTIGJ1dCBhbGxvdyBzb21lIGZpeGVkIG51bWJlciBvZiBwYWNrZXRzIGluZGljYXRl ZCB1cCB0byBORElTIChtYXliZSBjb25maWd1cmFibGUpLCBhcyBjaGVja2VkIGFuZCBlbmZvcmNl ZCBieSBYZW5OZXQuIFRoZW4gY29uc2lkZXIgZnVydGhlciByZS13b3JrIGluIFhlblZpZiBlbGlt aW5hdGluZyB0aGUgZXh0cmEgcXVldWUgYW5kIERQQyBpZiBwb3NzaWJsZSwgYWxvbmcgd2l0aCBz b21lIGludGVyZmFjZSBjaGFuZ2VzIHRvIGFsbG93IFhlbk5ldCB0byBpbmRpY2F0ZSB0byBYZW5W aWYgd2hlbiBpdCBpcyBubyBsb25nZXIgcG9zc2libGUgdG8gcHVzaCBwYWNrZXRzIHVwIHRoZSBz dGFjay4gSSB3aWxsIG5lZWQgdG8gZG8gYSBmYWlyIGJpdCBvZiBpbnRlcm5hbCB0ZXN0aW5nLg0K DQpNSC4NCg== From win-pv-devel-bounces@lists.xenproject.org Wed Jul 28 14:03:03 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 28 Jul 2021 14:03:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.161538.296550 (Exim 4.92) (envelope-from ) id 1m8k9F-0006Gp-9G; Wed, 28 Jul 2021 14:03:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 161538.296550; Wed, 28 Jul 2021 14:03:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m8k9F-0006Gh-6B; Wed, 28 Jul 2021 14:03:01 +0000 Received: by outflank-mailman (input) for mailman id 161538; Wed, 28 Jul 2021 14:02:59 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m8k9D-0006GV-MM for win-pv-devel@lists.xenproject.org; Wed, 28 Jul 2021 14:02:59 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 01ac6cb7-2fd2-4068-b18d-7e3f4545b3fd; Wed, 28 Jul 2021 14:02:54 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 01ac6cb7-2fd2-4068-b18d-7e3f4545b3fd DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1627480974; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=iTjy6NdpJyeQZHuio926TRhieJO+sBI8rhF6tumkYVM=; b=dMO0Ewhyz4+SWhB3/husRqw35z5EFcbeIpOxuvGMBQ6W7mVPeFS2klEN yVF8HA/5rQJNKZ6Bt1z7q50ywuHYM+OnrqrXZLBhdqBZLm2SoJl2CF/Ht x5icZhH3h0D5Ub8/I7pbuKk1nqITNr9w4r2kQ6xNAw7T+v7iLx/SwrdHK 8=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: j7Ah2phuGK4DUc/yli4h2AQVg0/70VPPub36MpznOKp7H9RGUgvdM8Md/nTcWV1fV7AIczQLIi mmv3yZmchMnPpcI3a3w/rSKskoes9gN6gK8RM4u+shUi6CkJq/wQZIv/n/GHAHG/20j17JIVmV MM5VY+LT0fymbVkc9J6NQNxZ+iOR9lbg8dWiFDOCnX+Dag6UT51uaVvqBTx/zkjCL7/ijLTE0v F/pdHyYKv+v4ZQntfzce80/zCwuFkAxMtymcyWQ4K9NunJBZ6eKgBOfBQTHBD4atu+mAV9+dAm rxTEHOcBXKHNIJY7PEsUTyp0 X-SBRS: 5.1 X-MesageID: 49657523 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:J0Bhl69EXVB0VDsO4mxuk+DWI+orL9Y04lQ7vn2YSXRuE/Bw8P re+8jztCWE8Qr5N0tQ+uxoVJPufZq+z+8Q3WByB8bBYOCOggLBR+sOgbcKqweQfREWndQ86U 4PScZD4aXLfD1Hsfo= X-IronPort-AV: E=Sophos;i="5.84,276,1620705600"; d="scan'208";a="49657523" From: Martin Harvey To: CC: Martin Harvey , Martin Harvey Subject: [PATCH] Prevent NULL MDL's from being queued for transmission. Date: Wed, 28 Jul 2021 15:02:04 +0100 Message-ID: <20210728140204.1228-1-Martin.Harvey@citrix.com> X-Mailer: git-send-email 2.25.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Under conditions of high load and low resources, it was possible for NDIS (in combination with overlying drivers) to send NET_BUFFER_LIST structures containing NULL MDL's for transmission. This resulted in an immediate bugcheck. This patch prevents NULL MDL's from being sent to XenVif. Signed-off-by: Martin Harvey --- src/xennet/transmitter.c | 26 +++++++++++++++----------- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/src/xennet/transmitter.c b/src/xennet/transmitter.c index 0e184fd..334bbb9 100644 --- a/src/xennet/transmitter.c +++ b/src/xennet/transmitter.c @@ -323,17 +323,21 @@ __TransmitterSendNetBufferList( __TransmitterGetNetBufferList(Transmitter, NetBufferList); - status = XENVIF_VIF(TransmitterQueuePacket, - AdapterGetVifInterface(Transmitter->Adapter), - NET_BUFFER_CURRENT_MDL(NetBuffer), - NET_BUFFER_CURRENT_MDL_OFFSET(NetBuffer), - NET_BUFFER_DATA_LENGTH(NetBuffer), - OffloadOptions, - MaximumSegmentSize, - TagControlInformation, - &Hash, - (NetBufferListNext != NULL) ? TRUE : FALSE, - Cookie); + if (NET_BUFFER_CURRENT_MDL(NetBuffer) != NULL) { + status = XENVIF_VIF(TransmitterQueuePacket, + AdapterGetVifInterface(Transmitter->Adapter), + NET_BUFFER_CURRENT_MDL(NetBuffer), + NET_BUFFER_CURRENT_MDL_OFFSET(NetBuffer), + NET_BUFFER_DATA_LENGTH(NetBuffer), + OffloadOptions, + MaximumSegmentSize, + TagControlInformation, + &Hash, + (NetBufferListNext != NULL) ? TRUE : FALSE, + Cookie); + } + else + status = STATUS_INVALID_PARAMETER; if (!NT_SUCCESS(status)) { __TransmitterReturnPacket(Transmitter, Cookie, NDIS_STATUS_NOT_ACCEPTED); -- 2.25.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Wed Jul 28 14:03:20 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 28 Jul 2021 14:03:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.161540.296553 (Exim 4.92) (envelope-from ) id 1m8k9Y-0006Kt-At; Wed, 28 Jul 2021 14:03:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 161540.296553; Wed, 28 Jul 2021 14:03:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m8k9Y-0006Kl-86; Wed, 28 Jul 2021 14:03:20 +0000 Received: by outflank-mailman (input) for mailman id 161540; Wed, 28 Jul 2021 14:03:18 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m8k9W-0006K7-A1 for win-pv-devel@lists.xenproject.org; Wed, 28 Jul 2021 14:03:18 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1ba2f68d-9775-4494-83da-5909b87ad4d3; Wed, 28 Jul 2021 14:03:14 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 1ba2f68d-9775-4494-83da-5909b87ad4d3 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1627480994; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=eB4lX9vAxENO7UIdmRlZzMlin4IxJa94Lu7U3ZasdrM=; b=Z9HIx9cm72+4pYWr3j2LGLp9JrMZ9+FZzw8FOV1j9G9P/kRDc+yEjNgq x8lBJH3RGPCZI0TXm1oYAKiEKKcYG233P36U4AALr3mJuiOY33jyywipn jcycVvMhSamsqMnxtsgw/WpmNxTAdfqgqACmQg0KlBZRukNI8QVE+3bhF I=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 7D2IJZn9OYr3T0fPTzrTmRKLKHOj7t8PgtF/BXjunDh1AlDz1bD+svL/+TbxUx946sqi/Wc6EU drsfzTSiWhrpC4CDbjyOZy3VEdOhpWJBJCgVvQNgi3TiTt/jbRKG66StHTyay4Dc9mmGWeI8t+ IVIDtkhWX0yZ6LtGWYrG8c0cvMWtZ5huPW4VwcS1ydOJLWtKXB7eqEcFweC9ixHmSLK3qFs2G3 PnbCD2//uXRRr5DhZRd3woLpKh4+PEepcDYXzlXY5v6iHMda7sJP4uu7QvK5CE/gYCudRqrCIE HNKy/BkYTE5GTnR9uy76yhSk X-SBRS: 5.1 X-MesageID: 49286360 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:lKC+wageIYXw5EF64aYEiwiJ1HBQXioji2hC6mlwRA09TyX5ra 2TdZUgpHjJYVMqMk3I9uruBEDtex3hHNtOkOos1NSZLW3bUQmTTL2KhLGKq1Hd8m/Fh4xgPM 9bGJSWY+eAaGSS4/ya3OG5eexQvOVu8sqT9JjjJ6EGd3AVV0lihT0JezpyCidNNW977QJSLu vn2iJAzQDQAEg/X4CAKVQuefPMnNHPnIKOW296O/Z2gDP+9Q9B8dTBYmOl4is= X-IronPort-AV: E=Sophos;i="5.84,276,1620705600"; d="scan'208";a="49286360" From: Martin Harvey To: CC: Martin Harvey , Martin Harvey Subject: [PATCH 2/5] Log ring disable. Date: Wed, 28 Jul 2021 15:02:44 +0100 Message-ID: <20210728140247.1912-2-Martin.Harvey@citrix.com> X-Mailer: git-send-email 2.25.0.windows.1 In-Reply-To: <20210728140247.1912-1-Martin.Harvey@citrix.com> References: <20210728140247.1912-1-Martin.Harvey@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Since Rx/Tx ring disconnects now no longer wait forever, we add some logging to catch those cases where the disconnect has timed out, indicating how many requests are still in the ring. This aids greatly with customer debugging. Signed-off-by: Martin Harvey --- src/xenvif/receiver.c | 16 ++++++++++++++++ src/xenvif/transmitter.c | 6 ++++++ 2 files changed, 22 insertions(+) diff --git a/src/xenvif/receiver.c b/src/xenvif/receiver.c index c70d938..7295646 100644 --- a/src/xenvif/receiver.c +++ b/src/xenvif/receiver.c @@ -2887,6 +2887,22 @@ __ReceiverRingDisconnect( ASSERT3U(Ring->ResponsesProcessed, ==, Ring->RequestsPushed); ASSERT3U(Ring->RequestsPushed, ==, Ring->RequestsPosted); + //Debug logs as well as assertion, else customer debugging difficult. + if ((Ring->ResponsesProcessed != Ring->RequestsPushed) || + (Ring->RequestsPushed != Ring->RequestsPosted)) + { + Info("%s[%u]: Ring disconnect, counts do not match.\n", + FrontendGetPath(Frontend), + Ring->Index); + + Info("%s[%u]: Processed: %u Pushed: %u Posted: %u\n", + FrontendGetPath(Frontend), + Ring->Index, + Ring->ResponsesProcessed, + Ring->RequestsPushed, + Ring->RequestsPosted); + } + Ring->ResponsesProcessed = 0; Ring->RequestsPushed = 0; Ring->RequestsPosted = 0; diff --git a/src/xenvif/transmitter.c b/src/xenvif/transmitter.c index fddeb0c..47f2fc2 100644 --- a/src/xenvif/transmitter.c +++ b/src/xenvif/transmitter.c @@ -4005,6 +4005,12 @@ __TransmitterRingDisable( } if (Ring->ResponsesProcessed != Ring->RequestsPushed) { + Info("%s[%u]: Timed out disable: Requests pushed: %u, Responses processed: %u.\n", + FrontendGetPath(Frontend), + Ring->Index, + Ring->RequestsPushed, + Ring->ResponsesProcessed); + __TransmitterRingFakeResponses(Ring); (VOID) TransmitterRingPoll(Ring); } -- 2.25.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Wed Jul 28 14:03:41 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 28 Jul 2021 14:03:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.161546.296558 (Exim 4.92) (envelope-from ) id 1m8k9t-0006Q3-DY; Wed, 28 Jul 2021 14:03:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 161546.296558; Wed, 28 Jul 2021 14:03:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m8k9t-0006Pu-AN; Wed, 28 Jul 2021 14:03:41 +0000 Received: by outflank-mailman (input) for mailman id 161546; Wed, 28 Jul 2021 14:03:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m8k9r-0006Pk-Hn for win-pv-devel@lists.xenproject.org; Wed, 28 Jul 2021 14:03:39 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b29986e8-5efe-418b-9918-55fbaaa98c21; Wed, 28 Jul 2021 14:03:38 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: b29986e8-5efe-418b-9918-55fbaaa98c21 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1627481018; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=TG3TdxNJvp+x4VbG+4HfplQrK5BUb2YDQyqQGFvoyN8=; b=EL5PvlEEe/NaxdN7u8RFCWIRCHOO91WG6ELvhZbFaKq+NLYM5j5UcF7a Hc0mwbVX53XgRO9gJN0xxVe2htHI0McOUwWR5wrHVb8rA1ziigZtdj5Tr ISuR0eWFZp2BgUNJTRKP8MxEMa65W6FVID9iO1YFkovFNJcAv7suwBJKf k=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: hjVPrVqaXqBhmG/TtEziiyuX74gnsRYnMypC7sMqTsu7Wie0SPnTmPrM1WioAfcMutl5zOw8eM XJZc/e1u97G4H8xj7wPpl8xIKsm7q/CfqMAx8HFFslnIQSj9p+nqaQCcsJe95S9dcYQ+Dikywf PVYA+n3wUafudC3YVKLXw2xUZHN1+O2GXYAF1AAbaj5rpgpxjhhANtajyupjoZWzV1iwZ7htvs KxCriKUlJzlkVEcx3DsRhIA7cAoXdNV6DqQcfXhpRwGxmYS1W3eJqLMBvXJnS0xVdHPh0yyuNn zya73Y9kE3KLG1oet31QtTLR X-SBRS: 5.1 X-MesageID: 50954183 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:ZAI80aCDosKxPfflHemW55DYdb4zR+YMi2TC1yhKKCC9Ffbo7v xG/c5rriMc5wxhO03I9eruBEDEewK5yXcX2/h2AV7BZniFhILAFugLhuGOrwEIWReOkdK1vZ 0QC5SWY+eRMbEVt6jHCXGDYrMd/OU= X-IronPort-AV: E=Sophos;i="5.84,276,1620705600"; d="scan'208";a="50954183" From: Martin Harvey To: CC: Martin Harvey , Martin Harvey Subject: [PATCH 5/5] Reduce logging of Fdo->NotDisableable Date: Wed, 28 Jul 2021 15:02:47 +0100 Message-ID: <20210728140247.1912-5-Martin.Harvey@citrix.com> X-Mailer: git-send-email 2.25.0.windows.1 In-Reply-To: <20210728140247.1912-1-Martin.Harvey@citrix.com> References: <20210728140247.1912-1-Martin.Harvey@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Signed-off-by: Martin Harvey --- src/xenvif/fdo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/xenvif/fdo.c b/src/xenvif/fdo.c index 896107c..745f948 100644 --- a/src/xenvif/fdo.c +++ b/src/xenvif/fdo.c @@ -2075,7 +2075,7 @@ FdoQueryPnpDeviceState( goto done; if (Fdo->NotDisableable) { - Info("%s: not disableable\n", __FdoGetName(Fdo)); + Trace("%s: not disableable\n", __FdoGetName(Fdo)); State |= PNP_DEVICE_NOT_DISABLEABLE; } -- 2.25.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Wed Jul 28 14:03:46 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 28 Jul 2021 14:03:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.161547.296561 (Exim 4.92) (envelope-from ) id 1m8k9y-0006Sf-Eh; Wed, 28 Jul 2021 14:03:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 161547.296561; Wed, 28 Jul 2021 14:03:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m8k9y-0006Sa-Bp; Wed, 28 Jul 2021 14:03:46 +0000 Received: by outflank-mailman (input) for mailman id 161547; Wed, 28 Jul 2021 14:03:44 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m8k9w-0006Pk-GU for win-pv-devel@lists.xenproject.org; Wed, 28 Jul 2021 14:03:44 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5b5df46f-6fea-4d2b-97d6-593e855492c3; Wed, 28 Jul 2021 14:03:39 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 5b5df46f-6fea-4d2b-97d6-593e855492c3 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1627481019; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=wkuhkUSO6EH1H8GRQqoL36XD21kn1L5Ne7Bt2Dt31X4=; b=DquZqjTpC/510iyUdy7fVNFSRB8oSJIckmhmt33mo9IKOe4SMVkLkhf5 vjhPmihVvgrSDl4mGqIxuQFtNjIrYjmD4Uk5wrK5WwtwUff9Er2MPHEwQ 1bfFJ4e6C/VqVbBAQ1gqY98cclwiKNRNiYch1Z+ZmEfD6DLIn40ATiWyD I=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 63PkpP2YA/4vNEob6KdBXpJngzsSkMHVX3YE8/qdk5EJ3P6s4n8en1zI5bNk/b0dvZSPZ8twFr AXiWdbaLkBvsAPhqUtMKwACKaTrDElkRNJHD5HK/WODVxOtpt0GmxCTSCbSQophSwvCzju9lub wwYnGwJnJpaFRd6ixDZ4IARUoM5tm6r6tSPw4GLoXvZf3imBCMu3ydsSi8mwvZDGkC+srCNsHx 0NXwkpJAfhYvKAvOyc6Kgatg5gytYp9fs11vHILJJtaBRfAbF8+JQ3msb0QYqnaFf1cGWpyZ+3 oqOoE7VxoV55w5sOsKO+I3hJ X-SBRS: 5.1 X-MesageID: 49286386 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:jDEU/KNenR9woMBcTvijsMiBIKoaSvp037BL7TEJdfUxSKalfq +V7ZEmPHPP+VQssTQb6LO90cq7IE80l6QFhbX5VI3KNGLbUSmTTL2KhrGSpAEIdReOkNK1Fp 0NT0G9MrDN5JRB4voSKTPXL+od X-IronPort-AV: E=Sophos;i="5.84,276,1620705600"; d="scan'208";a="49286386" From: Martin Harvey To: CC: Martin Harvey , Martin Harvey Subject: [PATCH 4/5] Assert that transmitter not being sent NULL MDL's Date: Wed, 28 Jul 2021 15:02:46 +0100 Message-ID: <20210728140247.1912-4-Martin.Harvey@citrix.com> X-Mailer: git-send-email 2.25.0.windows.1 In-Reply-To: <20210728140247.1912-1-Martin.Harvey@citrix.com> References: <20210728140247.1912-1-Martin.Harvey@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain An assertion to check that a corresponding fix in XenNet is preventing NULL MDL's from being queued for transmission. Signed-off-by: Martin Harvey --- src/xenvif/transmitter.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/xenvif/transmitter.c b/src/xenvif/transmitter.c index 47f2fc2..b5fb9a8 100644 --- a/src/xenvif/transmitter.c +++ b/src/xenvif/transmitter.c @@ -5143,6 +5143,8 @@ TransmitterQueuePacket( PXENVIF_TRANSMITTER_RING Ring; NTSTATUS status; + ASSERT(Mdl != NULL); + Frontend = Transmitter->Frontend; Packet = __TransmitterGetPacket(Transmitter); -- 2.25.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Wed Jul 28 14:03:51 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 28 Jul 2021 14:03:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.161549.296565 (Exim 4.92) (envelope-from ) id 1m8kA3-0006Vn-Gs; Wed, 28 Jul 2021 14:03:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 161549.296565; Wed, 28 Jul 2021 14:03:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m8kA3-0006Vg-E5; Wed, 28 Jul 2021 14:03:51 +0000 Received: by outflank-mailman (input) for mailman id 161549; Wed, 28 Jul 2021 14:03:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m8kA1-0006Pk-Gg for win-pv-devel@lists.xenproject.org; Wed, 28 Jul 2021 14:03:49 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 342c1106-a1a9-43ce-8c10-a96875b91f64; Wed, 28 Jul 2021 14:03:40 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 342c1106-a1a9-43ce-8c10-a96875b91f64 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1627481021; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0hJL79MKVxJligFIjvTpiUoEvb7Qbz/1Ka8wgQudT1I=; b=EUdbeyRxWPc3AqAyvYGQe5lQ7NyS8iS0TdNhoL7XvEIJDCWHgnIoT/83 LKxZwMD7r36/sMR95TkvPak2Hgn5UGbSVnuD3TtOZD3uWm10YvO27VVES b9YiwYCmEu87Xe+GgSojyC4e2/iGudzz1cKI+hLFC54Rmtj8mMWIsxyVx k=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: Vt8yzApjK18EFPwrfKX+5jPCqkAKCHIrXQKW1eBWK5IPW/omWYBt+H2LbjqYJN6X5jBEeM/nwF 2caxDsYCjsbsb4AgOlveWKJlr2qr5Qrgvqr8T/luhnxoDvB3/m96s0oOFbCJJtITrP/PvUPJMI GlpAQ+FnzU4DZX5GkKCrk8nBT4RL4doKegF3jKpH+aJBojiqD8LTUUaXMvSSThFRgkL4YmtD/C JShtmmzV00OOgR8Hr0B1yOe8VIgFEqRcuI1S71+605xiLovDc5sKA7IAbvg61Ad6G18POl7BD/ RCVSBeef4UXBRD1F7UjrDVGs X-SBRS: 5.1 X-MesageID: 49286392 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:4Shadq9s1duhT89P6/Vuk+C2I+orL9Y04lQ7vn2ZLiY1TiX4ra 6TdZsguSMc5Ax6ZJhCo7u90cC7KBvhHPVOjrX5U43OYDXb X-IronPort-AV: E=Sophos;i="5.84,276,1620705600"; d="scan'208";a="49286392" From: Martin Harvey To: CC: Martin Harvey , Martin Harvey Subject: [PATCH 3/5] Log waits for backend state changes. Date: Wed, 28 Jul 2021 15:02:45 +0100 Message-ID: <20210728140247.1912-3-Martin.Harvey@citrix.com> X-Mailer: git-send-email 2.25.0.windows.1 In-Reply-To: <20210728140247.1912-1-Martin.Harvey@citrix.com> References: <20210728140247.1912-1-Martin.Harvey@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain In addition to preceding changes to ring disconnects, and associated logging, we also add some logging to check whether state change notifications are being sent in a timely manner between frontend and backend. Also a great assistance to customer debugging. Signed-off-by: Martin Harvey --- src/xenvif/frontend.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/xenvif/frontend.c b/src/xenvif/frontend.c index 5940e16..72f448d 100644 --- a/src/xenvif/frontend.c +++ b/src/xenvif/frontend.c @@ -1346,6 +1346,7 @@ FrontendWaitForBackendXenbusStateChange( LARGE_INTEGER Timeout; XenbusState Old = *State; NTSTATUS status; + const ULONGLONG TotalTimeout = 120000; Trace("%s: ====> %s\n", __FrontendGetBackendPath(Frontend), @@ -1369,7 +1370,7 @@ FrontendWaitForBackendXenbusStateChange( Timeout.QuadPart = 0; - while (*State == Old && TimeDelta < 120000) { + while (*State == Old && TimeDelta < TotalTimeout) { PCHAR Buffer; LARGE_INTEGER Now; @@ -1417,6 +1418,9 @@ FrontendWaitForBackendXenbusStateChange( TimeDelta = (Now.QuadPart - Start.QuadPart) / 10000ull; } + if (TimeDelta >= TotalTimeout) + Error("%s timed out waiting for backend state change\n", __FrontendGetBackendPath(Frontend)); + if (Watch != NULL) (VOID) XENBUS_STORE(WatchRemove, &Frontend->StoreInterface, -- 2.25.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Wed Jul 28 14:03:55 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 28 Jul 2021 14:03:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.161550.296570 (Exim 4.92) (envelope-from ) id 1m8kA7-0006Yv-Ia; Wed, 28 Jul 2021 14:03:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 161550.296570; Wed, 28 Jul 2021 14:03:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m8kA7-0006Yo-Fa; Wed, 28 Jul 2021 14:03:55 +0000 Received: by outflank-mailman (input) for mailman id 161550; Wed, 28 Jul 2021 14:03:54 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m8kA6-0006Uw-1S for win-pv-devel@lists.xenproject.org; Wed, 28 Jul 2021 14:03:54 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a02e89f1-efac-11eb-97b3-12813bfff9fa; Wed, 28 Jul 2021 14:03:49 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: a02e89f1-efac-11eb-97b3-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1627481029; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=at55/ezhWogv5jVhFCtnGWPMjW22rNZFkUvlTfimDug=; b=KvsKOPT9VK5XH30inNh2//o72rLywrYi5DYkevPHP0jkU+gFu4MWnuWJ CAXGndX0P4Y76t78WpxITG2Eh2q+s066t92jDZt9rmSQSRqGg85sVRMWr 3bhhgSQHN1gQMzyjeZOCNwrixIBdnhF6EFH0EPyVzR1m8XyQkpBk0nQmG E=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: WvAllFXzd+B1MrjVG1zHRsbZa5H/rlXsanYJpXkWkJC1hck/m74YMAT71mJ6ivYqUp5Xxi6TTS +L99yY2rck5SWtrQiYozdD5/3B6FldrGxegRbrceFuFIzHR/qKcAnMFwC7s2GTh//6tlINyJZO p8s2mAdy0kDJ+GYq+hDhx7ViPIOdWu/lGhtFzADbmYEb+VeGUsi+qPMND1ZhCdr2tzIoosvoc5 f/1UFrMa8h/7rYg0i8WOtof8x5Kacegae1ywSUsyA/9aGqdBWpX18t5j3mnqmDVJ41bGok/RW3 Y8bv2p56K+5jBSgHTtQVz/7V X-SBRS: 5.1 X-MesageID: 50954200 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:0H0dsawUQPTzPbgB2bh1KrPwIr1zdoMgy1knxilNoRw8SK2lfq eV7ZMmPH7P+U8ssR4b6LO90cW7Lk80lqQFhbX5X43SPjUO0VHAROoJgOffKlXbakvDH4VmtZ uIHZIRNDSJNykesfrH X-IronPort-AV: E=Sophos;i="5.84,276,1620705600"; d="scan'208";a="50954200" From: Martin Harvey To: CC: Martin Harvey , Martin Harvey Subject: [PATCH 1/5] Improve transmitter disable. Date: Wed, 28 Jul 2021 15:02:43 +0100 Message-ID: <20210728140247.1912-1-Martin.Harvey@citrix.com> X-Mailer: git-send-email 2.25.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain In some cases, the backend may stop processing Tx ring requests in a timely manner. If this happens at the same time as ring disable, then the Tx code could spin forever at dispatch IRQL. This patch introduces a hard limit on how long the code will spin, allowing a device disable or power transition to complete, albeit at the cost of Tx requests being dropped or the ring being in an indeterminate state. This has normally been seen at guest shutdown where final ring state is of little consequence. Signed-off-by: Martin Harvey --- src/xenvif/transmitter.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/xenvif/transmitter.c b/src/xenvif/transmitter.c index f6935a6..fddeb0c 100644 --- a/src/xenvif/transmitter.c +++ b/src/xenvif/transmitter.c @@ -3988,21 +3988,25 @@ __TransmitterRingDisable( ASSERT3U(Ring->RequestsPushed, ==, Ring->RequestsPosted); while (Ring->ResponsesProcessed != Ring->RequestsPushed) { Attempt++; - ASSERT(Attempt < 100); + + KeStallExecutionProcessor(1000); // 1ms // Try to move things along __TransmitterRingSend(Ring); (VOID) TransmitterRingPoll(Ring); - if (State != XenbusStateConnected) - __TransmitterRingFakeResponses(Ring); + if ((Attempt >= 100) || (State != XenbusStateConnected)) + break; // We are waiting for a watch event at DISPATCH_LEVEL so // it is our responsibility to poll the store ring. XENBUS_STORE(Poll, &Transmitter->StoreInterface); - - KeStallExecutionProcessor(1000); // 1ms + } + if (Ring->ResponsesProcessed != Ring->RequestsPushed) + { + __TransmitterRingFakeResponses(Ring); + (VOID) TransmitterRingPoll(Ring); } Ring->Enabled = FALSE; -- 2.25.0.windows.1