From win-pv-devel-bounces@lists.xenproject.org Mon Sep 06 08:13:40 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 06 Sep 2021 08:13:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179449.325719 (Exim 4.92) (envelope-from ) id 1mN9l4-0000WV-41; Mon, 06 Sep 2021 08:13:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179449.325719; Mon, 06 Sep 2021 08:13:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN9l4-0000WO-1A; Mon, 06 Sep 2021 08:13:38 +0000 Received: by outflank-mailman (input) for mailman id 179449; Mon, 06 Sep 2021 08:13:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN9l3-0000WI-5L for win-pv-devel@lists.xenproject.org; Mon, 06 Sep 2021 08:13:37 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN9l2-0007XG-NL; Mon, 06 Sep 2021 08:13:36 +0000 Received: from host86-143-223-59.range86-143.btcentralplus.com ([86.143.223.59] helo=CBG-R90WXYV0.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mN9l2-0006SS-FG; Mon, 06 Sep 2021 08:13:36 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=J61NHWtGqFt55VucLYVMuLe3t36V2xoiK6CyH93+jws=; b=OmqcpPoLAuCXnd2vmEuxDUMLHU QURSWhW6FzCZAHtZK0mQt1bF7KoKIWWtWvWF4hDnjOEfvhgZUTw6fOllAGSvfx9fAS84lnnGo95QE zf1x3XoIgSwT5gEd9RYysA9xjz6RSm8jvp/h+ZqIwNI+D0hUhuoo8W38SsnmFJuTEJOo=; From: Paul Durrant To: win-pv-devel@lists.xenproject.org Cc: Paul Durrant , Owen Smith Subject: [PATCH xenbus] Fix build with later WDKs: Date: Mon, 6 Sep 2021 09:13:33 +0100 Message-Id: <20210906081333.1065-1-paul@xen.org> X-Mailer: git-send-email 2.17.1 From: Paul Durrant - Adds alias for GetProjectInfoForReference target to version.vcxproj Later kits seemed to have renamed the build target, and will fail without this alias target. - Adds "/fd sha256" to signtool command line WDK 20344 and later require binaries signed with a SHA256 file digest, or the build outputs are deleted. Signed-off-by: Owen Smith Re-worked from Owen's original patch: - Squashes warnings 4061 and 26052. - Casts XENBUS_STORE_PERMISSION_MASK to ULONG in switch statement to avoid complaint about case using '|'. Signed-off-by: Paul Durrant --- src/xenbus/store.c | 2 +- vs2019/package/package.vcxproj | 5 +++++ vs2019/version/version.vcxproj | 6 ++++++ vs2019/xen/xen.vcxproj | 5 ++++- vs2019/xenbus/xenbus.vcxproj | 5 ++++- vs2019/xenbus_coinst/xenbus_coinst.vcxproj | 5 ++++- vs2019/xenbus_monitor/xenbus_monitor.vcxproj | 5 ++++- vs2019/xenfilt/xenfilt.vcxproj | 5 ++++- 8 files changed, 32 insertions(+), 6 deletions(-) diff --git a/src/xenbus/store.c b/src/xenbus/store.c index ce4c755f1d58..5ffea1fe4859 100644 --- a/src/xenbus/store.c +++ b/src/xenbus/store.c @@ -1945,7 +1945,7 @@ StorePermissionToString( ASSERT(BufferSize > 1); - switch (Permission->Mask) { + switch ((ULONG)Permission->Mask) { case XENBUS_STORE_PERM_NONE: *Buffer = 'n'; break; diff --git a/vs2019/package/package.vcxproj b/vs2019/package/package.vcxproj index 2a83c90335f8..e10717a61efe 100644 --- a/vs2019/package/package.vcxproj +++ b/vs2019/package/package.vcxproj @@ -32,6 +32,11 @@ ..\$(ProjectName)\$(ConfigurationName)\$(Platform)\ ..\$(ConfigurationName)\$(Platform)\ + + + sha256 + + ..\..\$(SolutionName)\x86 diff --git a/vs2019/version/version.vcxproj b/vs2019/version/version.vcxproj index 9d149d0f10dd..b6ec6f3ecb0c 100644 --- a/vs2019/version/version.vcxproj +++ b/vs2019/version/version.vcxproj @@ -13,4 +13,10 @@ + + + + + diff --git a/vs2019/xen/xen.vcxproj b/vs2019/xen/xen.vcxproj index 39b5bda87eb6..bccef34d2b0a 100644 --- a/vs2019/xen/xen.vcxproj +++ b/vs2019/xen/xen.vcxproj @@ -24,7 +24,7 @@ PROJECT=$(ProjectName);POOL_NX_OPTIN=1;NT_PROCESSOR_GROUPS;%(PreprocessorDefinitions) true EnableAllWarnings - 4146;4464;4711;4770;4548;4820;4668;4255;5045;6001;6054;26451;28196;30030;30029;%(DisableSpecificWarnings) + 4061;4146;4464;4711;4770;4548;4820;4668;4255;5045;6001;6054;26451;28196;30030;30029;%(DisableSpecificWarnings) true true @@ -37,6 +37,9 @@ UseLinkTimeCodeGeneration ../../src/xen/xen.def + + sha256 + diff --git a/vs2019/xenbus/xenbus.vcxproj b/vs2019/xenbus/xenbus.vcxproj index ff40c43c45cc..eac2f7eb4767 100644 --- a/vs2019/xenbus/xenbus.vcxproj +++ b/vs2019/xenbus/xenbus.vcxproj @@ -24,7 +24,7 @@ true $(WindowsSdkDir)\include\km;..\..\include;..\..\include\xen;..\..\src\common; EnableAllWarnings - 4146;4464;4711;4770;4548;4820;4668;4255;5045;6001;6054;26451;28196;30030;30029;%(DisableSpecificWarnings) + 4061;4146;4464;4711;4770;4548;4820;4668;4255;5045;6001;6054;26451;28196;30030;30029;%(DisableSpecificWarnings) true true @@ -36,6 +36,9 @@ $(ProjectDir)..\$(ConfigurationName)\$(Platform)\xen.lib;$(DDK_LIB_PATH)/libcntpr.lib;$(DDK_LIB_PATH)/procgrp.lib;$(DDK_LIB_PATH)/rtlver.lib;%(AdditionalDependencies) UseLinkTimeCodeGeneration + + sha256 + diff --git a/vs2019/xenbus_coinst/xenbus_coinst.vcxproj b/vs2019/xenbus_coinst/xenbus_coinst.vcxproj index df3cc0405fb3..2e7a6e74cc62 100644 --- a/vs2019/xenbus_coinst/xenbus_coinst.vcxproj +++ b/vs2019/xenbus_coinst/xenbus_coinst.vcxproj @@ -21,7 +21,7 @@ $(SolutionDir)..\include;%(AdditionalIncludeDirectories) PROJECT=$(ProjectName);%(PreprocessorDefinitions) EnableAllWarnings - 4127;4711;4548;4820;4668;4255;5045;6001;6054;28196;%(DisableSpecificWarnings) + 4127;4711;4548;4820;4668;4255;5045;6001;6054;26052;28196;%(DisableSpecificWarnings) true true MultiThreadedDebug @@ -35,6 +35,9 @@ $(SolutionDir)..\include;%(AdditionalIncludeDirectories) + + sha256 + diff --git a/vs2019/xenbus_monitor/xenbus_monitor.vcxproj b/vs2019/xenbus_monitor/xenbus_monitor.vcxproj index 8703bb5c57b0..8652ac439a9e 100644 --- a/vs2019/xenbus_monitor/xenbus_monitor.vcxproj +++ b/vs2019/xenbus_monitor/xenbus_monitor.vcxproj @@ -25,7 +25,7 @@ $(SolutionDir)..\include;%(AdditionalIncludeDirectories) PROJECT=$(ProjectName);WIN32;_WINDOWS;_CRT_SECURE_NO_WARNINGS;%(PreprocessorDefinitions) EnableAllWarnings - 4127;4711;4548;4820;4668;4255;5045;6001;6054;28196;%(DisableSpecificWarnings) + 4127;4711;4548;4820;4668;4255;5045;6001;6054;26052;28196;%(DisableSpecificWarnings) true true MultiThreadedDebug @@ -37,6 +37,9 @@ $(SolutionDir)..\include;%(AdditionalIncludeDirectories) + + sha256 + diff --git a/vs2019/xenfilt/xenfilt.vcxproj b/vs2019/xenfilt/xenfilt.vcxproj index b3ce00f3fc67..620e3a6aaa79 100644 --- a/vs2019/xenfilt/xenfilt.vcxproj +++ b/vs2019/xenfilt/xenfilt.vcxproj @@ -24,7 +24,7 @@ true $(WindowsSdkDir)\include\km;..\..\include;..\..\include\xen;..\..\src\common; EnableAllWarnings - 4464;4711;4770;4548;4820;4668;4255;5045;6001;6054;26451;28196;30030;30029;%(DisableSpecificWarnings) + 4061;4464;4711;4770;4548;4820;4668;4255;5045;6001;6054;26451;28196;30030;30029;%(DisableSpecificWarnings) true true @@ -36,6 +36,9 @@ $(ProjectDir)..\$(ConfigurationName)\$(Platform)\xen.lib;$(DDK_LIB_PATH)/libcntpr.lib;$(DDK_LIB_PATH)/procgrp.lib;%(AdditionalDependencies) UseLinkTimeCodeGeneration + + sha256 + -- 2.17.1 From win-pv-devel-bounces@lists.xenproject.org Mon Sep 06 12:01:01 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 06 Sep 2021 12:01:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179692.326097 (Exim 4.92) (envelope-from ) id 1mNDJ6-0002xu-C5; Mon, 06 Sep 2021 12:01:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179692.326097; Mon, 06 Sep 2021 12:01:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNDJ6-0002xn-9E; Mon, 06 Sep 2021 12:01:00 +0000 Received: by outflank-mailman (input) for mailman id 179692; Mon, 06 Sep 2021 12:00:59 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNDJ4-0002xh-TU for win-pv-devel@lists.xenproject.org; Mon, 06 Sep 2021 12:00:59 +0000 Received: from mail-wr1-x435.google.com (unknown [2a00:1450:4864:20::435]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c98b6a45-6a10-4086-88fd-9bb6cc9e7434; Mon, 06 Sep 2021 12:00:58 +0000 (UTC) Received: by mail-wr1-x435.google.com with SMTP id q14so9512939wrp.3 for ; Mon, 06 Sep 2021 05:00:58 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:f581:5504:73aa:6d39? ([2a00:23c5:5785:9a01:f581:5504:73aa:6d39]) by smtp.gmail.com with ESMTPSA id c9sm7694063wrf.77.2021.09.06.05.00.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Sep 2021 05:00:57 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: c98b6a45-6a10-4086-88fd-9bb6cc9e7434 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=O5oJUf7ZepP3t7m95rDq3aWQVipou1NPgejuBsdfhe0=; b=k0daQpkGvlPdD3HCWNa2+yS0lzY9UxIds+Y3duSKplOb7RSYcldgcaD1DaAF4pnb82 AOyRr54X2w03wGW4hcm+kiNWD7Kloy0bMgrEo/bcrE5I8nVUQag4zlMygeGsw3I3mnB9 4fqeDisxKSRrpSX26rbxTXHmjl7czp7z97AIl2B0Aj6Yo7P2h3JXaNKvFs735WGIlDlj zx7/5LyUZ5xEE86VxR719b61l38Sbzvc3V+Kd3Uye71xgWBilvMxaxp6Z339Y6jtEHyl 8KkakhvjvPRGG1cEtE6B2RRx81NXEXB58Q/YjYuYdwHf5r2eR/BhjJ85k0TTmX61MwhE l3hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=O5oJUf7ZepP3t7m95rDq3aWQVipou1NPgejuBsdfhe0=; b=XdQCjK6b4TsHxplxe31oXliuhTwxmIKk3Ib1XsfmSdpfHZRFMst0vytLX9iiu2D/iQ M5dO9uHOZBRFSz/y6/37HiA3H6UkOUm0+I5UbuD5wX60xoplbe/8KppmshuXRzh0BPOF 23lZbfoFcFZEl6tAphGfQ6dFf/+V3D+yCY9TFStEV5D/7mz9SrALGW4CvQxSsBmT3C0U WUQv54r/kXdv3FNnUKNiR3hGB+LXFzZbJUbwHriMmCUJlTK20TbkOaTPlVvZTfEaOf9H rowDQrvIr5pcW00tnaC8irutVOiQ7rQIS8UxMyn80shenajbtGWgY+U4uBkBbk2W9XW9 e/Mg== X-Gm-Message-State: AOAM533wF5qccwXntXQoykIUZ+JuucE0dhvnEYxnyXbzq2x51YTs3Spk yGhmWEOJ8mtxJvpvjpYqcatUsl5K/KI= X-Google-Smtp-Source: ABdhPJy6WjcKRLaWuxULjLeoKrxhy4TeeaMC/gXlq66c31EPlKz96fEpVXnlUYrQBGSCXvMVBPP5Hw== X-Received: by 2002:a5d:6cc9:: with SMTP id c9mr12708754wrc.158.1630929657397; Mon, 06 Sep 2021 05:00:57 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 1/3] Fix build with later WDKs To: win-pv-devel@lists.xenproject.org References: <20210812124427.1736-1-owen.smith@citrix.com> Message-ID: <18a1d262-4afd-705e-56ad-32c5740d336c@xen.org> Date: Mon, 6 Sep 2021 13:00:56 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210812124427.1736-1-owen.smith@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/08/2021 13:44, Owen Smith wrote: > - Adds alias for GetProjectInfoForReference target to version.vcxproj > Later kits seemed to have renamed the build target, and will fail without > this alias target. > - Adds "/fd sha256" to signtool command line > WDK 20344 and later require binaries signed with a SHA256 file digest, or > the build outputs are deleted > - Disables warning 4061 - switch statement on enum types need to have a case > for all values of the enumeration > > Signed-off-by: Owen Smith This doesn't fully fix the build for me (with EWDK_co_release_22000_210604-1628). There's a couple more things needed. I'll post an amended patch shortly. Paul From win-pv-devel-bounces@lists.xenproject.org Mon Sep 06 12:10:56 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 06 Sep 2021 12:10:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179725.326134 (Exim 4.92) (envelope-from ) id 1mNDSh-00060q-RT; Mon, 06 Sep 2021 12:10:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179725.326134; Mon, 06 Sep 2021 12:10:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNDSh-00060j-OY; Mon, 06 Sep 2021 12:10:55 +0000 Received: by outflank-mailman (input) for mailman id 179725; Mon, 06 Sep 2021 12:10:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNDSf-00060c-QP for win-pv-devel@lists.xenproject.org; Mon, 06 Sep 2021 12:10:53 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNDSf-0003LO-Cr; Mon, 06 Sep 2021 12:10:53 +0000 Received: from host86-143-223-59.range86-143.btcentralplus.com ([86.143.223.59] helo=CBG-R90WXYV0.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mNDSf-00060x-3k; Mon, 06 Sep 2021 12:10:53 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=9ass2jZsK7WYLobha3KFs5E1VQreJunwlKxiOY3Q8eg=; b=cMnFpxnQAQ4PMzJ8+v2wbKxJPv 2oGJfs7/tPYZ7+E3OsKU4l0jznxIfVo+Ji6I1sXHdkOGuX2XSc+j7vN7fgWMG7WF9GqZftwB+N4fU CGqOzVmqXXxQJBCFb4RW1zo3Rshgvjk5jmXVUFeJEg5bWxMzW+TfJ2iWtcaKM/ebgVFA=; From: Paul Durrant To: win-pv-devel@lists.xenproject.org Cc: Paul Durrant Subject: [PATCH xenvif 1/2] Fix semantics of ASSERT3[P|S|U] Date: Mon, 6 Sep 2021 13:10:47 +0100 Message-Id: <20210906121048.2170-1-paul@xen.org> X-Mailer: git-send-email 2.17.1 From: Paul Durrant These ASSERTions are supposed to cast their arguments to pointer, signed or unsigned values (respectively) before applying the operator. This is not done correctly; the test and __analysis_assume() directive in the underlying ASSERT() macro are applied to the un-cast values. This patch rectifies the situation. Signed-off-by: Paul Durrant --- src/xenvif/assert.h | 56 +++++++++++++++++++++++++++++---------------- 1 file changed, 36 insertions(+), 20 deletions(-) diff --git a/src/xenvif/assert.h b/src/xenvif/assert.h index 110f4ef726f5..dade311c23ea 100644 --- a/src/xenvif/assert.h +++ b/src/xenvif/assert.h @@ -76,19 +76,17 @@ __Bug( #if DBG -#define __NT_ASSERT(_EXP) \ - ((!(_EXP)) ? \ +#define __ASSERT_FAIL(_EXP) \ (Error("ASSERTION FAILED: " #_EXP "\n"), \ __annotation(L"Debug", L"AssertFail", L#_EXP), \ - DbgRaiseAssertionFailure(), FALSE) : \ - TRUE) - -#define __ASSERT(_EXP) __NT_ASSERT(_EXP) - -#define ASSERT(_EXP) \ - do { \ - __ASSERT(_EXP); \ - __analysis_assume(_EXP); \ + DbgRaiseAssertionFailure()) + +#define ASSERT(_EXP) \ + do { \ + if (!(_EXP)) { \ + __ASSERT_FAIL(_EXP); \ + __analysis_assume(_EXP); \ + } \ } while (FALSE) #define ASSERT3U(_X, _OP, _Y) \ @@ -98,7 +96,8 @@ __Bug( if (!(_Lval _OP _Rval)) { \ Error("%s = %llu\n", #_X, _Lval); \ Error("%s = %llu\n", #_Y, _Rval); \ - ASSERT((_X) _OP (_Y)); \ + __ASSERT_FAIL(_X _OP _Y); \ + __analysis_assume(_Lval _OP _Rval); \ } \ } while (FALSE) @@ -109,7 +108,8 @@ __Bug( if (!(_Lval _OP _Rval)) { \ Error("%s = %lld\n", #_X, _Lval); \ Error("%s = %lld\n", #_Y, _Rval); \ - ASSERT((_X) _OP (_Y)); \ + __ASSERT_FAIL(_X _OP _Y); \ + __analysis_assume(_Lval _OP _Rval); \ } \ } while (FALSE) @@ -120,7 +120,8 @@ __Bug( if (!(_Lval _OP _Rval)) { \ Error("%s = %p\n", #_X, _Lval); \ Error("%s = %p\n", #_Y, _Rval); \ - ASSERT((_X) _OP (_Y)); \ + __ASSERT_FAIL(_X _OP _Y); \ + __analysis_assume(_Lval _OP _Rval); \ } \ } while (FALSE) @@ -134,14 +135,29 @@ __Bug( __analysis_assume(_EXP); \ } while (FALSE) -#define ASSERT3U(_X, _OP, _Y) \ - ASSERT((_X) _OP (_Y)) +#define ASSERT3U(_X, _OP, _Y) \ + do { \ + ULONGLONG _Lval = (ULONGLONG)(_X); \ + ULONGLONG _Rval = (ULONGLONG)(_Y); \ + \ + __analysis_assume(_Lval _OP _Rval); \ + } while (FALSE) -#define ASSERT3S(_X, _OP, _Y) \ - ASSERT((_X) _OP (_Y)) +#define ASSERT3S(_X, _OP, _Y) \ + do { \ + LONGLONG _Lval = (LONGLONG)(_X); \ + LONGLONG _Rval = (LONGLONG)(_Y); \ + \ + __analysis_assume(_Lval _OP _Rval); \ + } while (FALSE) -#define ASSERT3P(_X, _OP, _Y) \ - ASSERT((_X) _OP (_Y)) +#define ASSERT3P(_X, _OP, _Y) \ + do { \ + PVOID _Lval = (PVOID)(_X); \ + PVOID _Rval = (PVOID)(_Y); \ + \ + __analysis_assume(_Lval _OP _Rval); \ + } while (FALSE) #endif // DBG -- 2.17.1 From win-pv-devel-bounces@lists.xenproject.org Mon Sep 06 12:11:04 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 06 Sep 2021 12:11:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179726.326139 (Exim 4.92) (envelope-from ) id 1mNDSp-000673-TF; Mon, 06 Sep 2021 12:11:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179726.326139; Mon, 06 Sep 2021 12:11:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNDSp-00066u-QJ; Mon, 06 Sep 2021 12:11:03 +0000 Received: by outflank-mailman (input) for mailman id 179726; Mon, 06 Sep 2021 12:11:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNDSo-000638-Gq for win-pv-devel@lists.xenproject.org; Mon, 06 Sep 2021 12:11:02 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNDSo-0003Ll-FF; Mon, 06 Sep 2021 12:11:02 +0000 Received: from host86-143-223-59.range86-143.btcentralplus.com ([86.143.223.59] helo=CBG-R90WXYV0.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mNDSo-00060x-6c; Mon, 06 Sep 2021 12:11:02 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=rmNHm3NZvuG6VcdzyDqF/3ozM8fX+ksGVqzQYU+CGw8=; b=VSQqpUlKYlLipyw/+owx9z8bM 9kaFUE73TiUWWIzyqwxH7ua3B1YNTSO0stqa5Mg5Vz46CiMfskDm7idFqALzONkluvG3SM4OJHxtz QPtvDCcaI2kQLIrbSIIlB3ctRqbh4OEQyqhHihKVqx04NgbzDhgjygrZubiHibeNuULfI=; From: Paul Durrant To: win-pv-devel@lists.xenproject.org Cc: Owen Smith , Paul Durrant Subject: [PATCH xenvif 2/2] Fix build with later WDKs Date: Mon, 6 Sep 2021 13:10:48 +0100 Message-Id: <20210906121048.2170-2-paul@xen.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210906121048.2170-1-paul@xen.org> References: <20210906121048.2170-1-paul@xen.org> From: Owen Smith - Adds alias for GetProjectInfoForReference target to version.vcxproj Later kits seemed to have renamed the build target, and will fail without this alias target. - Adds "/fd sha256" to signtool command line WDK 20344 and later require binaries signed with a SHA256 file digest, or the build outputs are deleted - Disables warning 4061 - switch statement on enum types need to have a case for all values of the enumeration Signed-off-by: Owen Smith - Cast enum types used as array indices to avoid bounds check complaint Signed-off-by: Paul Durrant --- src/xenvif/frontend.c | 8 ++++---- src/xenvif/mac.c | 8 ++++---- vs2019/package/package.vcxproj | 5 +++++ vs2019/version/version.vcxproj | 6 ++++++ vs2019/xenvif/xenvif.vcxproj | 5 ++++- vs2019/xenvif_coinst/xenvif_coinst.vcxproj | 5 ++++- 6 files changed, 27 insertions(+), 10 deletions(-) diff --git a/src/xenvif/frontend.c b/src/xenvif/frontend.c index 72f448db0c05..e38d2bfcd432 100644 --- a/src/xenvif/frontend.c +++ b/src/xenvif/frontend.c @@ -1618,14 +1618,14 @@ __FrontendQueryStatistic( { ULONG Index; - ASSERT(Name < XENVIF_VIF_STATISTIC_COUNT); + ASSERT3U(Name, <, XENVIF_VIF_STATISTIC_COUNT); *Value = 0; for (Index = 0; Index < Frontend->StatisticsCount; Index++) { PXENVIF_FRONTEND_STATISTICS Statistics; Statistics = &Frontend->Statistics[Index]; - *Value += Statistics->Value[Name]; + *Value += Statistics->Value[(ULONG)Name]; } } @@ -1650,7 +1650,7 @@ FrontendIncrementStatistic( PXENVIF_FRONTEND_STATISTICS Statistics; KIRQL Irql; - ASSERT(Name < XENVIF_VIF_STATISTIC_COUNT); + ASSERT3U(Name, <, XENVIF_VIF_STATISTIC_COUNT); KeRaiseIrql(DISPATCH_LEVEL, &Irql); @@ -1659,7 +1659,7 @@ FrontendIncrementStatistic( ASSERT3U(Index, <, Frontend->StatisticsCount); Statistics = &Frontend->Statistics[Index]; - Statistics->Value[Name] += Delta; + Statistics->Value[(ULONG)Name] += Delta; KeLowerIrql(Irql); } diff --git a/src/xenvif/mac.c b/src/xenvif/mac.c index a89904b0f72a..82632714e549 100644 --- a/src/xenvif/mac.c +++ b/src/xenvif/mac.c @@ -1000,7 +1000,7 @@ MacSetFilterLevel( NTSTATUS status; status = STATUS_INVALID_PARAMETER; - if (Type >= ETHERNET_ADDRESS_TYPE_COUNT) + if ((ULONG)Type >= ETHERNET_ADDRESS_TYPE_COUNT) goto fail1; KeRaiseIrql(DISPATCH_LEVEL, &Irql); @@ -1010,7 +1010,7 @@ MacSetFilterLevel( if (Level > XENVIF_MAC_FILTER_ALL || Level < XENVIF_MAC_FILTER_NONE) goto fail2; - Mac->FilterLevel[Type] = Level; + Mac->FilterLevel[(ULONG)Type] = Level; __MacReleaseLockExclusive(Mac); KeLowerIrql(Irql); @@ -1040,13 +1040,13 @@ MacQueryFilterLevel( NTSTATUS status; status = STATUS_INVALID_PARAMETER; - if (Type >= ETHERNET_ADDRESS_TYPE_COUNT) + if ((ULONG)Type >= ETHERNET_ADDRESS_TYPE_COUNT) goto fail1; KeRaiseIrql(DISPATCH_LEVEL, &Irql); __MacAcquireLockShared(Mac); - *Level = Mac->FilterLevel[Type]; + *Level = Mac->FilterLevel[(ULONG)Type]; __MacReleaseLockShared(Mac); KeLowerIrql(Irql); diff --git a/vs2019/package/package.vcxproj b/vs2019/package/package.vcxproj index 3aec237e9ec4..76f940c69608 100644 --- a/vs2019/package/package.vcxproj +++ b/vs2019/package/package.vcxproj @@ -31,6 +31,11 @@ ..\$(ProjectName)\$(ConfigurationName)\$(Platform)\ ..\$(ConfigurationName)\$(Platform)\ + + + sha256 + + ..\..\$(SolutionName)\x86 diff --git a/vs2019/version/version.vcxproj b/vs2019/version/version.vcxproj index 9d149d0f10dd..b6ec6f3ecb0c 100644 --- a/vs2019/version/version.vcxproj +++ b/vs2019/version/version.vcxproj @@ -13,4 +13,10 @@ + + + + + diff --git a/vs2019/xenvif/xenvif.vcxproj b/vs2019/xenvif/xenvif.vcxproj index 9aa14b2339fc..c28271407ded 100644 --- a/vs2019/xenvif/xenvif.vcxproj +++ b/vs2019/xenvif/xenvif.vcxproj @@ -24,7 +24,7 @@ PROJECT=$(ProjectName);POOL_NX_OPTIN=1;NT_PROCESSOR_GROUPS;%(PreprocessorDefinitions) true EnableAllWarnings - 4464;4711;4770;4548;4820;4668;4255;5045;6001;6054;26451;28196;30030;30029;%(DisableSpecificWarnings) + 4061;4464;4711;4770;4548;4820;4668;4255;5045;6001;6054;26451;28196;30030;30029;%(DisableSpecificWarnings) true true @@ -36,6 +36,9 @@ $(DDK_LIB_PATH)/Rtlver.lib;$(DDK_LIB_PATH)/libcntpr.lib;$(DDK_LIB_PATH)/aux_klib.lib;$(DDK_LIB_PATH)/ksecdd.lib;$(DDK_LIB_PATH)/procgrp.lib;%(AdditionalDependencies) UseLinkTimeCodeGeneration + + sha256 + diff --git a/vs2019/xenvif_coinst/xenvif_coinst.vcxproj b/vs2019/xenvif_coinst/xenvif_coinst.vcxproj index 6957ad88c3a9..ccf41359316d 100644 --- a/vs2019/xenvif_coinst/xenvif_coinst.vcxproj +++ b/vs2019/xenvif_coinst/xenvif_coinst.vcxproj @@ -24,7 +24,7 @@ PROJECT=$(ProjectName);%(PreprocessorDefinitions) EnableAllWarnings - 4127;4548;4711;4820;4668;4255;5045;6001;6054;28196;%(DisableSpecificWarnings) + 4127;4548;4711;4820;4668;4255;5045;6001;6054;26052;28196;%(DisableSpecificWarnings) true true MultiThreadedDebug @@ -34,6 +34,9 @@ ../../src/coinst/xenvif_coinst.def setupapi.lib;%(AdditionalDependencies) + + sha256 + -- 2.17.1 From win-pv-devel-bounces@lists.xenproject.org Mon Sep 06 12:18:12 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 06 Sep 2021 12:18:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179741.326142 (Exim 4.92) (envelope-from ) id 1mNDZj-0006Tb-FR; Mon, 06 Sep 2021 12:18:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179741.326142; Mon, 06 Sep 2021 12:18:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNDZj-0006TU-Cg; Mon, 06 Sep 2021 12:18:11 +0000 Received: by outflank-mailman (input) for mailman id 179741; Mon, 06 Sep 2021 12:18:09 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNDZh-0006TO-F1 for win-pv-devel@lists.xenproject.org; Mon, 06 Sep 2021 12:18:09 +0000 Received: from mail-wr1-x430.google.com (unknown [2a00:1450:4864:20::430]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1307feab-81ce-48e7-b73c-365690c49a45; Mon, 06 Sep 2021 12:18:08 +0000 (UTC) Received: by mail-wr1-x430.google.com with SMTP id n5so9547645wro.12 for ; Mon, 06 Sep 2021 05:18:08 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:f581:5504:73aa:6d39? ([2a00:23c5:5785:9a01:f581:5504:73aa:6d39]) by smtp.gmail.com with ESMTPSA id t17sm4687021wra.95.2021.09.06.05.18.07 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Sep 2021 05:18:07 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 1307feab-81ce-48e7-b73c-365690c49a45 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Nsy48xX1FfgiYOKj+cLwBv9x5pFIXuijiV40Reu5cmk=; b=LbxOFnz6jXzSuvKsa7ws6alxVsvIf1rQ17BxuyKSSY1//AvdXRhtNSEQHN5ZkGA89Q UzxuS3e0BrHR662tXX/sblx5f9Qfvr9nulLoJ/OHLCP/zs0j+rjpv2lF7lEhpwUO7EMH tesn2gm5HK4yGtPncMMHbXgoKyE5E4iVV1NDZLu6E9Sn8m8f6/vkcCeybID50UTE/j9a YnSKlefUZoy/X0MDBQUzea/jU+C849Ub0OIwc3zMcqIG9C4Wz4ALTSgfF+eGe5REGeSD 39w2f61N6mMlYbxqNObj8oamFrqjkPZpVM0Xl3CRhXNF9B+BaLcznkFAwuGZJRkpzNms 2kYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Nsy48xX1FfgiYOKj+cLwBv9x5pFIXuijiV40Reu5cmk=; b=PYE4rFNN1+u4KKoSm6XmfeQaTYoSIig13pmHfciosghkaDfnP+bi1q0aTXRXtLL5Zk 2IgBPorH/uDi/gYij0n/b8xsJMX69Chsg0WZGYNsH7JKRCDLsoB/nzjLDiLRqMMIV4q/ hlDhO30TORP1CdR+K9dBkkDLXhoio2LMDpjMkb7A0ltkdeGM3o3eZYvlZH1PAXcs/z4u wFLGk1gIA2CVvuMFMNsbsUiA2YXHHboe+alt7SG1YiKBH+xR2qk24yxcW5ICKALl7gHr VUs3sRtsSahKq/9TKPp2MVSHL6ku9X82VtRzZeYKkUhqnRscpRXN33Zc8GoiyfhhlEiP wdVA== X-Gm-Message-State: AOAM533Xbf7ORxPO8Mh0PUliX0juEEJst7FoDaspalnVBFuomQJ/+g9z 4AKpRz/FgprwJ71HEDPe4kR36cKYpI4= X-Google-Smtp-Source: ABdhPJwpt5MLkGCPLPtv0quqMJ/WRnA7XRMb8jAI1uhiuxs0UkBOQzVAS4EItD6+ZgDz7Id+TfS98g== X-Received: by 2002:adf:ed06:: with SMTP id a6mr13078501wro.3.1630930687897; Mon, 06 Sep 2021 05:18:07 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 1/4] Fix build with later WDKs To: win-pv-devel@lists.xenproject.org References: <20210812124138.1533-1-owen.smith@citrix.com> Message-ID: Date: Mon, 6 Sep 2021 13:18:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210812124138.1533-1-owen.smith@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/08/2021 13:41, Owen Smith wrote: > - Adds alias for GetProjectInfoForReference target to version.vcxproj > Later kits seemed to have renamed the build target, and will fail without > this alias target. > - Adds "/fd sha256" to signtool command line > WDK 20344 and later require binaries signed with a SHA256 file digest, or > the build outputs are deleted > - Disables warning 4061 - switch statement on enum types need to have a case for > all values of the enumeration > > Signed-off-by: Owen Smith This didn't quite fix it for me. I'll send an amended patch. Paul From win-pv-devel-bounces@lists.xenproject.org Mon Sep 06 12:21:18 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 06 Sep 2021 12:21:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179756.326160 (Exim 4.92) (envelope-from ) id 1mNDck-000857-0Z; Mon, 06 Sep 2021 12:21:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179756.326160; Mon, 06 Sep 2021 12:21:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNDcj-000850-Tq; Mon, 06 Sep 2021 12:21:17 +0000 Received: by outflank-mailman (input) for mailman id 179756; Mon, 06 Sep 2021 12:21:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNDcj-00084u-3y for win-pv-devel@lists.xenproject.org; Mon, 06 Sep 2021 12:21:17 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNDci-0003Wf-UI; Mon, 06 Sep 2021 12:21:16 +0000 Received: from host86-143-223-59.range86-143.btcentralplus.com ([86.143.223.59] helo=CBG-R90WXYV0.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mNDci-0006xK-La; Mon, 06 Sep 2021 12:21:16 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=qvw5WngNrifrtYgQ7ej4j6zmoAA7f7p0cdQQRb0auZk=; b=thy17T0x8uvblBRDqwJYfnGuxG 2dmMFOZUdT0Mya6Y7uf9GzSaub/Zd1eVwd1rukKZ4j3+HVJIPibMv5un6XZrOzWc3JuN42qdXPnaC 2UFUINHYUmAcs/UkIYz8vig9sB4wLbp15fBjt4N8OcDPUS3c8ja1/XdAaiS3x9BJvxzE=; From: Paul Durrant To: win-pv-devel@lists.xenproject.org Cc: Owen Smith , Paul Durrant Subject: [PATCH xenvbd] Fix build with later WDKs Date: Mon, 6 Sep 2021 13:21:14 +0100 Message-Id: <20210906122114.2260-1-paul@xen.org> X-Mailer: git-send-email 2.17.1 From: Owen Smith - Adds alias for GetProjectInfoForReference target to version.vcxproj Later kits seemed to have renamed the build target, and will fail without this alias target. - Adds "/fd sha256" to signtool command line WDK 20344 and later require binaries signed with a SHA256 file digest, or the build outputs are deleted - Disables warning 4061 - switch statement on enum types need to have a case for all values of the enumeration Signed-off-by: Owen Smith - Cast enum types used as array indices to avoid bounds check complaint Signed-off-by: Paul Durrant --- src/xenvbd/driver.c | 4 ++-- vs2019/package/package.vcxproj | 5 +++++ vs2019/version/version.vcxproj | 6 ++++++ vs2019/xencrsh/xencrsh.vcxproj | 5 ++++- vs2019/xendisk/xendisk.vcxproj | 5 ++++- vs2019/xenvbd/xenvbd.vcxproj | 5 ++++- vs2019/xenvbd_coinst/xenvbd_coinst.vcxproj | 3 +++ 7 files changed, 28 insertions(+), 5 deletions(-) diff --git a/src/xenvbd/driver.c b/src/xenvbd/driver.c index fc1c16940ec3..1084c30fed78 100644 --- a/src/xenvbd/driver.c +++ b/src/xenvbd/driver.c @@ -301,7 +301,7 @@ DriverGetFeatureOverride( { BOOLEAN Present = FALSE; - if (Feature < ARRAYSIZE(Driver.FeatureOverride)) { + if ((ULONG)Feature < ARRAYSIZE(Driver.FeatureOverride)) { Present = Driver.FeatureOverride[Feature].Present; *Value = Driver.FeatureOverride[Feature].Value; } @@ -315,7 +315,7 @@ DriverGetFeatureName( IN XENVBD_FEATURE Feature ) { - return (Feature < ARRAYSIZE(Driver.FeatureOverride)) ? + return ((ULONG)Feature < ARRAYSIZE(Driver.FeatureOverride)) ? Driver.FeatureOverride[Feature].Name : NULL; } diff --git a/vs2019/package/package.vcxproj b/vs2019/package/package.vcxproj index 51c57a1036cc..cc39738e13f9 100644 --- a/vs2019/package/package.vcxproj +++ b/vs2019/package/package.vcxproj @@ -31,6 +31,11 @@ ..\$(ProjectName)\$(ConfigurationName)\$(Platform)\ ..\$(ConfigurationName)\$(Platform)\ + + + sha256 + + ..\..\$(SolutionName)\x86 diff --git a/vs2019/version/version.vcxproj b/vs2019/version/version.vcxproj index 9d149d0f10dd..b6ec6f3ecb0c 100644 --- a/vs2019/version/version.vcxproj +++ b/vs2019/version/version.vcxproj @@ -13,4 +13,10 @@ + + + + + diff --git a/vs2019/xencrsh/xencrsh.vcxproj b/vs2019/xencrsh/xencrsh.vcxproj index 6db3e1ffb12d..7aae718b5206 100644 --- a/vs2019/xencrsh/xencrsh.vcxproj +++ b/vs2019/xencrsh/xencrsh.vcxproj @@ -24,7 +24,7 @@ PROJECT=$(ProjectName);POOL_NX_OPTIN=1;%(PreprocessorDefinitions) true EnableAllWarnings - 4464;4548;4770;4711;4820;4668;4255;5045;6001;6054;26451;28196;30030;30029;%(DisableSpecificWarnings) + 4061;4464;4548;4770;4711;4820;4668;4255;5045;6001;6054;26451;28196;30030;30029;%(DisableSpecificWarnings) true true @@ -37,6 +37,9 @@ $(DDK_LIB_PATH)/storport.lib;$(DDK_LIB_PATH)/libcntpr.lib;%(AdditionalDependencies) UseLinkTimeCodeGeneration + + sha256 + diff --git a/vs2019/xendisk/xendisk.vcxproj b/vs2019/xendisk/xendisk.vcxproj index ce4b6d304b60..799b86a07eae 100644 --- a/vs2019/xendisk/xendisk.vcxproj +++ b/vs2019/xendisk/xendisk.vcxproj @@ -25,7 +25,7 @@ PROJECT=$(ProjectName);POOL_NX_OPTIN=1;%(PreprocessorDefinitions) true EnableAllWarnings - 4464;4548;4770;4711;4820;4668;4255;5045;6001;6054;26451;28196;30030;30029;%(DisableSpecificWarnings) + 4061;4464;4548;4770;4711;4820;4668;4255;5045;6001;6054;26451;28196;30030;30029;%(DisableSpecificWarnings) true true @@ -37,6 +37,9 @@ %(AdditionalDependencies) UseLinkTimeCodeGeneration + + sha256 + diff --git a/vs2019/xenvbd/xenvbd.vcxproj b/vs2019/xenvbd/xenvbd.vcxproj index 7e25d60b929b..dcdd6d8405e1 100644 --- a/vs2019/xenvbd/xenvbd.vcxproj +++ b/vs2019/xenvbd/xenvbd.vcxproj @@ -24,7 +24,7 @@ PROJECT=$(ProjectName);POOL_NX_OPTIN=1;%(PreprocessorDefinitions) true EnableAllWarnings - 4464;4548;4770;4711;4820;4668;4255;5045;6001;6054;26451;28160;28196;30030;30029;%(DisableSpecificWarnings) + 4061;4464;4548;4770;4711;4820;4668;4255;5045;6001;6054;26451;28160;28196;30030;30029;%(DisableSpecificWarnings) true true @@ -36,6 +36,9 @@ $(ProjectDir)..\$(ConfigurationName)\$(Platform)\xencrsh.lib;$(DDK_LIB_PATH)/storport.lib;$(DDK_LIB_PATH)/libcntpr.lib;%(AdditionalDependencies) UseLinkTimeCodeGeneration + + sha256 + diff --git a/vs2019/xenvbd_coinst/xenvbd_coinst.vcxproj b/vs2019/xenvbd_coinst/xenvbd_coinst.vcxproj index d8223146b72c..9a66f45bb358 100644 --- a/vs2019/xenvbd_coinst/xenvbd_coinst.vcxproj +++ b/vs2019/xenvbd_coinst/xenvbd_coinst.vcxproj @@ -34,6 +34,9 @@ $(SolutionDir)..\include;%(AdditionalIncludeDirectories) + + sha256 + -- 2.17.1 From win-pv-devel-bounces@lists.xenproject.org Mon Sep 06 12:37:45 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 06 Sep 2021 12:37:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179767.326166 (Exim 4.92) (envelope-from ) id 1mNDse-0000uY-7g; Mon, 06 Sep 2021 12:37:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179767.326166; Mon, 06 Sep 2021 12:37:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNDse-0000uO-45; Mon, 06 Sep 2021 12:37:44 +0000 Received: by outflank-mailman (input) for mailman id 179767; Mon, 06 Sep 2021 12:37:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNDsc-0000uI-U5 for win-pv-devel@lists.xenproject.org; Mon, 06 Sep 2021 12:37:43 +0000 Received: from mail-wr1-x42f.google.com (unknown [2a00:1450:4864:20::42f]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fe9323c9-68bc-422a-8626-673fd8d7898a; Mon, 06 Sep 2021 12:37:42 +0000 (UTC) Received: by mail-wr1-x42f.google.com with SMTP id b6so9658772wrh.10 for ; Mon, 06 Sep 2021 05:37:42 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:f581:5504:73aa:6d39? ([2a00:23c5:5785:9a01:f581:5504:73aa:6d39]) by smtp.gmail.com with ESMTPSA id d145sm7246794wmd.3.2021.09.06.05.37.40 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Sep 2021 05:37:41 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: fe9323c9-68bc-422a-8626-673fd8d7898a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=h89C+lSb+19P8UsCW6qrhVrMZTy7CyWfSj4p29R4f/Q=; b=EWg2XZKhh6CZoSS3pkUWIvgO4b6ddA4GuApP9kZvU3GCb9vRKb/v6iKUEXg+cxNXvL YL0FnNgaaFpWTrTGaJtZNZ8oYrgzvPYV7KiZOSFctkeUkExG57+FpvPYj9oV0xALuBXd QXEj8O5aV+pPQg9Y3O3ASTzDeC7seKk0r/NLmTduHzn8bcajn+G89V6VydIfA5IJwiQV Ziw7Bg8GuqPvT4dIbsP5LBerdQ7r/RRpWvwRWZJ3D2tL6i9x+DQG2IKZeaqFUH8szVNg v/wgkM7t4FPRbyKt9qmI63WaP/IJEUYgwFTUpje5h61FUTwpe8ma4pDCEkAXED4IKryE pgIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=h89C+lSb+19P8UsCW6qrhVrMZTy7CyWfSj4p29R4f/Q=; b=asDVObGfEx6mqjhWHcCdrHZDdLW2aSmrFKtsbsT2QdlFPdwxioFrhYzY+nCAyCaeE4 tXpr/7rVe3M1H9bUd0sc2XnnlG1KWC0WwjwqX6d7Cur0B/hs0jo30o+E+TdNpaEQGbh6 sYwgeLXJkEftHcAsnGrSVsB2dDzh1ShxUQ2vpAS+fhSa3T7Y4QOSdCLR/wdDtDH0rHF2 16kIwf0v7Si73jvdEBMu7pHb8TgDWB9tNKSBqR8DFheX45faRf6o/iBLM1Fo7U/Fo1Et Z6xnwS5aS/yDij0FeKiUWavL2GNfhr9cH8p8OGd/5UigKPwxTYA7xtTtmKH018gNm6OZ PO+A== X-Gm-Message-State: AOAM532HGbO/CUSBPOv440JxiGoAwSHjMNsT0lHRCOaw5NsNIjrk8GCD CattyfN7CSK0B5pYbzdC4vxS9zJWMLg= X-Google-Smtp-Source: ABdhPJwfKC2BNNV3iRxeFPtLBs368rsmTjVBqbsBYhoFUr25XZNhz2njNmtHtYntOxGEkwOOwUgOiw== X-Received: by 2002:adf:ce85:: with SMTP id r5mr13230933wrn.323.1630931861346; Mon, 06 Sep 2021 05:37:41 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 1/3] Fix build with later WDKs To: win-pv-devel@lists.xenproject.org References: <20210812123907.2005-1-owen.smith@citrix.com> Message-ID: <102dd38c-eadb-3ac5-405a-3fc43a9e25e7@xen.org> Date: Mon, 6 Sep 2021 13:37:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210812123907.2005-1-owen.smith@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/08/2021 13:39, Owen Smith wrote: > - Adds alias for GetProjectInfoForReference target to version.vcxproj > Later kits seemed to have renamed the build target, and will fail without > this alias target. > - Adds "/fd sha256" to signtool command line > WDK 20344 and later require binaries signed with a SHA256 file digest, or > the build outputs are deleted > - Fixes warning 4061 - switch statement on enum types need to have a case for > all values of the enumeration > I prefer squashing this warning, as discussed elsewhere. I'll submit an amended patch shortly. Paul From win-pv-devel-bounces@lists.xenproject.org Mon Sep 06 12:41:16 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 06 Sep 2021 12:41:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179774.326169 (Exim 4.92) (envelope-from ) id 1mNDw4-0001im-GK; Mon, 06 Sep 2021 12:41:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179774.326169; Mon, 06 Sep 2021 12:41:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNDw4-0001ie-DL; Mon, 06 Sep 2021 12:41:16 +0000 Received: by outflank-mailman (input) for mailman id 179774; Mon, 06 Sep 2021 12:41:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNDw2-0001iY-SA for win-pv-devel@lists.xenproject.org; Mon, 06 Sep 2021 12:41:14 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNDw2-0003qu-O7; Mon, 06 Sep 2021 12:41:14 +0000 Received: from host86-143-223-59.range86-143.btcentralplus.com ([86.143.223.59] helo=CBG-R90WXYV0.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mNDw2-0000JM-IW; Mon, 06 Sep 2021 12:41:14 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=HbBdGbM03LtlBYKF1LxSTNsuSh6NBZj9ePuygSNIyYU=; b=PFJ1Jc+WnOPwYp3RcIvxIR7iru pzxaJzPNZNw90y60fza30oXrGALXw9VEbtNH6ce1m4wN6xnqwhqADrrO+AwHcG2/ncrMVxNn9/+Yp OqheZqoRggDodiD3UdIbyz12brLDu5KMe376fJSbJ0/3yvx2qbsJHAmpUcFRouQ2vGV8=; From: Paul Durrant To: win-pv-devel@lists.xenproject.org Cc: Owen Smith , Paul Durrant Subject: [PATCH xennet] Fix build with later WDKs Date: Mon, 6 Sep 2021 13:41:09 +0100 Message-Id: <20210906124109.2379-1-paul@xen.org> X-Mailer: git-send-email 2.17.1 From: Owen Smith - Adds alias for GetProjectInfoForReference target to version.vcxproj Later kits seemed to have renamed the build target, and will fail without this alias target. - Adds "/fd sha256" to signtool command line WDK 20344 and later require binaries signed with a SHA256 file digest, or the build outputs are deleted Signed-off-by: Owen Smith - Squash warnings 4061 and 4062 as they lead to a lot of bogus noise. - Add a somewhat pointless ASSERT for a condition that has already been tested to stop the compiler complaining. Signed-off-by: Paul Durrant --- src/xennet/transmitter.c | 1 + vs2019/package/package.vcxproj | 5 +++++ vs2019/version/version.vcxproj | 6 ++++++ vs2019/xennet/xennet.vcxproj | 5 ++++- vs2019/xennet_coinst/xennet_coinst.vcxproj | 3 +++ 5 files changed, 19 insertions(+), 1 deletion(-) diff --git a/src/xennet/transmitter.c b/src/xennet/transmitter.c index 334bbb947de3..17d312aff89d 100644 --- a/src/xennet/transmitter.c +++ b/src/xennet/transmitter.c @@ -324,6 +324,7 @@ __TransmitterSendNetBufferList( __TransmitterGetNetBufferList(Transmitter, NetBufferList); if (NET_BUFFER_CURRENT_MDL(NetBuffer) != NULL) { + ASSERT(NetBuffer != NULL); status = XENVIF_VIF(TransmitterQueuePacket, AdapterGetVifInterface(Transmitter->Adapter), NET_BUFFER_CURRENT_MDL(NetBuffer), diff --git a/vs2019/package/package.vcxproj b/vs2019/package/package.vcxproj index dd794b5fef41..1a439ee6288d 100644 --- a/vs2019/package/package.vcxproj +++ b/vs2019/package/package.vcxproj @@ -31,6 +31,11 @@ ..\$(ProjectName)\$(ConfigurationName)\$(Platform)\ ..\$(ConfigurationName)\$(Platform)\ + + + sha256 + + ..\..\$(SolutionName)\x86 diff --git a/vs2019/version/version.vcxproj b/vs2019/version/version.vcxproj index 9d149d0f10dd..b6ec6f3ecb0c 100644 --- a/vs2019/version/version.vcxproj +++ b/vs2019/version/version.vcxproj @@ -13,4 +13,10 @@ + + + + + diff --git a/vs2019/xennet/xennet.vcxproj b/vs2019/xennet/xennet.vcxproj index 027dc4a0b709..abe9853fd2f5 100644 --- a/vs2019/xennet/xennet.vcxproj +++ b/vs2019/xennet/xennet.vcxproj @@ -26,7 +26,7 @@ true $(WindowsSdkDir)\include\km;..\..\include;..\..\include\xen; EnableAllWarnings - 4464;4711;4770;4548;4820;4668;4255;5045;6001;6054;26451;28160;28196;30030;30029;%(DisableSpecificWarnings) + 4061;4062;4464;4711;4770;4548;4820;4668;4255;5045;6001;6054;26451;28160;28196;30030;30029;%(DisableSpecificWarnings) true true @@ -38,6 +38,9 @@ $(DDK_LIB_PATH)\ndis.lib;$(DDK_LIB_PATH)/libcntpr.lib;$(DDK_LIB_PATH)/aux_klib.lib;$(DDK_LIB_PATH)/procgrp.lib;%(AdditionalDependencies) UseLinkTimeCodeGeneration + + sha256 + diff --git a/vs2019/xennet_coinst/xennet_coinst.vcxproj b/vs2019/xennet_coinst/xennet_coinst.vcxproj index a159abdf178e..d2c5d07ac53a 100644 --- a/vs2019/xennet_coinst/xennet_coinst.vcxproj +++ b/vs2019/xennet_coinst/xennet_coinst.vcxproj @@ -32,6 +32,9 @@ ../../src/coinst/xennet_coinst.def setupapi.lib;iphlpapi.lib;%(AdditionalDependencies) + + sha256 + -- 2.17.1 From win-pv-devel-bounces@lists.xenproject.org Mon Sep 06 12:44:48 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 06 Sep 2021 12:44:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179784.326172 (Exim 4.92) (envelope-from ) id 1mNDzT-00023l-PQ; Mon, 06 Sep 2021 12:44:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179784.326172; Mon, 06 Sep 2021 12:44:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNDzT-00023e-Ma; Mon, 06 Sep 2021 12:44:47 +0000 Received: by outflank-mailman (input) for mailman id 179784; Mon, 06 Sep 2021 12:44:46 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNDzS-00023Y-Mo for win-pv-devel@lists.xenproject.org; Mon, 06 Sep 2021 12:44:46 +0000 Received: from mail-wr1-x432.google.com (unknown [2a00:1450:4864:20::432]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7110a86b-433e-42e7-9eba-c1fbb898da82; Mon, 06 Sep 2021 12:44:45 +0000 (UTC) Received: by mail-wr1-x432.google.com with SMTP id q26so8745465wrc.7 for ; Mon, 06 Sep 2021 05:44:45 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:f581:5504:73aa:6d39? ([2a00:23c5:5785:9a01:f581:5504:73aa:6d39]) by smtp.gmail.com with ESMTPSA id f18sm7098265wmc.6.2021.09.06.05.44.44 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Sep 2021 05:44:44 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 7110a86b-433e-42e7-9eba-c1fbb898da82 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=KCh4mrKiSf3MYMFlu/sQJAI5ZNJ1wG1ysTQOiqht70k=; b=VU+spxu8gdQlmwKiihiACFcEPfW8NZIl0waW+Ab87zot2llerSN0GZqoJlsWpmzXu4 uaTw4GMqU2lqUYKHbA3Gij9tJlTUdekfFI7Yb3NVnprWSEQFoyE9C/+mD6wG5ttwD/YG kprW5FRsoLPCannVBkWDQkfh/YeUJl91oaLTmf5k3zUGFICnr+Ug6SPrlQRckd9KEfZ2 oAbAP8P870q5vGL3TuUfrXLlhEKMftaetn9/PYgijDaEBRdCSuxHdIHEQXuHx+Jhiyga 9rRwxE5WKqPmo1SJpZ6FucWv+KSLPp1QbLF6UDEjO6TRb10K5pDSvFV4cXwEiDsTjK+Y 2VJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KCh4mrKiSf3MYMFlu/sQJAI5ZNJ1wG1ysTQOiqht70k=; b=UenW6q+TvP0JXUIT+ESXevkp7vHzRnkLVNj1UOLvmpaIgNSjyA0kXNuLOgLSDAL5fC xLZK3Cq6oaeekBfHu7+lffFsu1nCkimn4BImEXnQSsHejnqW+svHb/H57EZH7zXt8Dbo 8vm1VKeT2rW4SyeXEdtdG4+KZ2ZiWhqqQUneu4VNetorRzN8po6PY3BVr2PJp+nbK6qB gLw5ntjfZnlFdPWmzqQgSHWTGgsvtgHEXJYepz/IHKH/kSjk+3s4NvkmUQaX5jEv7mT8 xC4S/4fwAAcuLkFj4UhoxvXEfN7QWmgv5yrERRyrTJxw5oB/dix6sezERSW58O9fEErc to1Q== X-Gm-Message-State: AOAM530w2WnI3bk8dA2nntUBAomVJlGvAHxZGJsHBR9K+DKNMMtVdxU2 OJdKsIXNnMQTKPGCCLnSJss4aTG22Y8= X-Google-Smtp-Source: ABdhPJwVwtuH+Rigwe7oYmHGxlq4fPH/Ta1JpbLnD3SIEM1/iSylshMyv6CP0QYRat6HyH+6DOLzig== X-Received: by 2002:adf:c54a:: with SMTP id s10mr13225498wrf.125.1630932285128; Mon, 06 Sep 2021 05:44:45 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 2/3] Fix SDV/CodeQL log generation To: win-pv-devel@lists.xenproject.org References: <20210810154048.1006-1-owen.smith@citrix.com> <20210810154048.1006-2-owen.smith@citrix.com> Message-ID: Date: Mon, 6 Sep 2021 13:44:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 20/08/2021 09:08, Paul Durrant wrote: > On 10/08/2021 16:40, Owen Smith wrote: >> - sarif files need to be stored with SDV logs when generating the DVL >> file >> - Disable PREFast and CodeAnalysis by default >> - Run a seperate CodeAnalysis build after SDV, but before generating >> DVL file >>      DVL file should contain multiple summary lines for SDV, at least >> 1 line >>      for CodeAnalysis and at least 1 line for Semmle (CodeQL) >> >> Signed-off-by: Owen Smith > > Acked-by: Paul Durrant Actually I withdraw my ack because CodeQL tool doesn't appear to be in the EWDK toolchain as yet. This at least needs some explanation in BUILD.md as to how to set it up... or perhaps we wait for a revised EWDK? Paul From win-pv-devel-bounces@lists.xenproject.org Mon Sep 06 12:55:33 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 06 Sep 2021 12:55:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179799.326188 (Exim 4.92) (envelope-from ) id 1mNE9r-0003nZ-S6; Mon, 06 Sep 2021 12:55:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179799.326188; Mon, 06 Sep 2021 12:55:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNE9r-0003nR-PA; Mon, 06 Sep 2021 12:55:31 +0000 Received: by outflank-mailman (input) for mailman id 179799; Mon, 06 Sep 2021 12:55:30 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNE9q-0003nL-JI for win-pv-devel@lists.xenproject.org; Mon, 06 Sep 2021 12:55:30 +0000 Received: from mail-wr1-x42d.google.com (unknown [2a00:1450:4864:20::42d]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e5eacd86-a789-4c7f-871b-cef0277982e5; Mon, 06 Sep 2021 12:55:28 +0000 (UTC) Received: by mail-wr1-x42d.google.com with SMTP id q14so9742290wrp.3 for ; Mon, 06 Sep 2021 05:55:28 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:f581:5504:73aa:6d39? ([2a00:23c5:5785:9a01:f581:5504:73aa:6d39]) by smtp.gmail.com with ESMTPSA id v62sm7237770wme.21.2021.09.06.05.55.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Sep 2021 05:55:27 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: e5eacd86-a789-4c7f-871b-cef0277982e5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/zmew1Sj/kI3vNmZd75/Y6e0jHrEDkwZhYMWRKArVcA=; b=R/2tJRLt/AQBB5cgz4L73a+2OmrzN37Sfh4W7CFIGw+6ZSKalCrcJegMIrmnPubDpI Z5Xh0thL32ks+mzbckkjmuJ1oc7Huvk0VQghqTTJiWz0/i9GZOuZLSa3QMYGILQaWOU9 4dzaB2kb1shs29qiXBF5X8OHkpdSkxnMUmFSfn4LlGYlcLepCFMi932QI+DUzFyy4Js+ WH4/deRusD+XIYyJkfiZwB1Dpy6fZom+P9t7ggv+/mCJWw24run1ksqIt1PBqc9mfCmT YxhnX+6uLQS/2XFGUkGh6hXpz6Mx0vkIRkXN9v5eCRY+GF3X7y6sfHSC4GlEk2AKIDB0 JyoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/zmew1Sj/kI3vNmZd75/Y6e0jHrEDkwZhYMWRKArVcA=; b=rd3GpYaYDcq2RB7dOQH5B8dos7DFC84xFL80TlSfkOelfguVz6lefoF2oG1Te3ThFM ZHwUqJmrQf0urSx5UzXlAg6PC9MO95JBxRYVE7PbyLYtn7rkZUOjXTzvOgEjkgqcCYfw qrnihXVoa3sVrJQA9MsVTH78hdA7taNZOBA+gceydRw0mQ76vz02uAYHRjumJN2ie66+ hwyT2aby933m6ZRS0iz4uEDVkAQRZ7Q5FCV0pdqUEmn3we3PQEfwxYWPAqNfiwTuKCAH dGQyAziOXUJg+ywIXdglwRckoUmVJhgNH7USTRnVQkLx3idaIIwtRhavae74GlwVfS6q odpA== X-Gm-Message-State: AOAM533cO2ZqrI6ESBiokwLm9PWulJTITRWli5kNoCoiPrPr3grZ7gUh QgVX1piWdQo38xhUpBobEYgoIfev24Q= X-Google-Smtp-Source: ABdhPJxneVmckI2O72lkvrnxkT1ESQKugHqjuICUM/hcMKKayJRI8GTW7kZBuXOLOxjaukw2URlj3Q== X-Received: by 2002:a5d:6485:: with SMTP id o5mr13092691wri.91.1630932928087; Mon, 06 Sep 2021 05:55:28 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 1/3] Fix build with later WDKs To: win-pv-devel@lists.xenproject.org References: <20210812123612.1826-1-owen.smith@citrix.com> Message-ID: <0cb19514-f82d-60b3-ac19-3f9530709f99@xen.org> Date: Mon, 6 Sep 2021 13:55:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210812123612.1826-1-owen.smith@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/08/2021 13:36, Owen Smith wrote: > - Adds alias for GetProjectInfoForReference target to version.vcxproj > Later kits seemed to have renamed the build target, and will fail without > this alias target. > - Adds "/fd sha256" to signtool command line > WDK 20344 and later require binaries signed with a SHA256 file digest, or > the build outputs are deleted > - Fixes warning 4061 - switch statement on enum types need to have a case for > all values of the enumeration > As discussed elsewhere, I prefer squashing the warning. I'll post an amended patch shortly. Paul From win-pv-devel-bounces@lists.xenproject.org Mon Sep 06 13:02:36 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 06 Sep 2021 13:02:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179847.326272 (Exim 4.92) (envelope-from ) id 1mNEGh-0000XM-Fe; Mon, 06 Sep 2021 13:02:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179847.326272; Mon, 06 Sep 2021 13:02:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEGh-0000XC-Bz; Mon, 06 Sep 2021 13:02:35 +0000 Received: by outflank-mailman (input) for mailman id 179847; Mon, 06 Sep 2021 13:02:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEGf-0000WE-Qf for win-pv-devel@lists.xenproject.org; Mon, 06 Sep 2021 13:02:33 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEGf-0004Fd-PX; Mon, 06 Sep 2021 13:02:33 +0000 Received: from host86-143-223-59.range86-143.btcentralplus.com ([86.143.223.59] helo=CBG-R90WXYV0.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mNEGf-0002HV-HI; Mon, 06 Sep 2021 13:02:33 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=wzWG1q13WLgUDYT5GlfEf6zGBIfePBIdjyagDB0bzSg=; b=xokfU2bPV/R+QI2aZCwSLLfn8V lSY9j9I+/UwdNIuv0F0d9wNPRqY8oRmarapo5iXsUJ5mmRJMHDwU4W++L23ODusgT3LUYQVrTO2aJ v19ARULM9GDRLgxFGwzAX8Ge57GUHl7VozbuXSQ5ha90d3PgW351b3UBSQUh4Yzsu6vE=; From: Paul Durrant To: win-pv-devel@lists.xenproject.org Cc: Owen Smith , Paul Durrant Subject: [PATCH xeniface] Fix build with later WDKs Date: Mon, 6 Sep 2021 14:02:28 +0100 Message-Id: <20210906130228.2482-1-paul@xen.org> X-Mailer: git-send-email 2.17.1 From: Owen Smith - Adds alias for GetProjectInfoForReference target to version.vcxproj Later kits seemed to have renamed the build target, and will fail without this alias target. - Adds "/fd sha256" to signtool command line WDK 20344 and later require binaries signed with a SHA256 file digest, or the build outputs are deleted Signed-off-by: Owen Smith - Squash warning 4061. Signed-off-by: Paul Durrant --- vs2019/package/package.vcxproj | 5 +++++ vs2019/version/version.vcxproj | 6 ++++++ vs2019/xenagent/xenagent.vcxproj | 3 +++ vs2019/xencontrol/xencontrol.vcxproj | 3 +++ vs2019/xeniface/xeniface.vcxproj | 5 ++++- vs2019/xeniface_coinst/xeniface_coinst.vcxproj | 3 +++ 6 files changed, 24 insertions(+), 1 deletion(-) diff --git a/vs2019/package/package.vcxproj b/vs2019/package/package.vcxproj index 31dacd34ef6f..2fe12049f3f4 100644 --- a/vs2019/package/package.vcxproj +++ b/vs2019/package/package.vcxproj @@ -32,6 +32,11 @@ ..\$(ProjectName)\$(ConfigurationName)\$(Platform)\ ..\$(ConfigurationName)\$(Platform)\ + + + sha256 + + ..\..\$(SolutionName)\x86 diff --git a/vs2019/version/version.vcxproj b/vs2019/version/version.vcxproj index 9d149d0f10dd..b6ec6f3ecb0c 100644 --- a/vs2019/version/version.vcxproj +++ b/vs2019/version/version.vcxproj @@ -13,4 +13,10 @@ + + + + + diff --git a/vs2019/xenagent/xenagent.vcxproj b/vs2019/xenagent/xenagent.vcxproj index eff385bb4720..1076c81c2785 100644 --- a/vs2019/xenagent/xenagent.vcxproj +++ b/vs2019/xenagent/xenagent.vcxproj @@ -37,6 +37,9 @@ $(SolutionDir)..\include;%(AdditionalIncludeDirectories) + + sha256 + diff --git a/vs2019/xencontrol/xencontrol.vcxproj b/vs2019/xencontrol/xencontrol.vcxproj index f54d6b569eb5..36383d867892 100644 --- a/vs2019/xencontrol/xencontrol.vcxproj +++ b/vs2019/xencontrol/xencontrol.vcxproj @@ -36,6 +36,9 @@ $(SolutionDir)..\include;%(AdditionalIncludeDirectories) + + sha256 + diff --git a/vs2019/xeniface/xeniface.vcxproj b/vs2019/xeniface/xeniface.vcxproj index b2588151ec76..ebc1b024f652 100644 --- a/vs2019/xeniface/xeniface.vcxproj +++ b/vs2019/xeniface/xeniface.vcxproj @@ -24,7 +24,7 @@ PROJECT=$(ProjectName);POOL_NX_OPTIN=1;NT_PROCESSOR_GROUPS;%(PreprocessorDefinitions) true EnableAllWarnings - 4464;4711;4548;4770;4820;4668;4255;5045;6001;6054;26451;28160;30030;30029;%(DisableSpecificWarnings) + 4061;4464;4711;4548;4770;4820;4668;4255;5045;6001;6054;26451;28160;30030;30029;%(DisableSpecificWarnings) true true @@ -36,6 +36,9 @@ $(DDK_LIB_PATH)\ntstrsafe.lib;$(DDK_LIB_PATH)\procgrp.lib;%(AdditionalDependencies) UseLinkTimeCodeGeneration + + sha256 + diff --git a/vs2019/xeniface_coinst/xeniface_coinst.vcxproj b/vs2019/xeniface_coinst/xeniface_coinst.vcxproj index b011416a1bd5..77e6836f6b67 100644 --- a/vs2019/xeniface_coinst/xeniface_coinst.vcxproj +++ b/vs2019/xeniface_coinst/xeniface_coinst.vcxproj @@ -34,6 +34,9 @@ $(SolutionDir)..\include;%(AdditionalIncludeDirectories) + + sha256 + -- 2.17.1 From win-pv-devel-bounces@lists.xenproject.org Mon Sep 06 13:13:50 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 06 Sep 2021 13:13:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179862.326287 (Exim 4.92) (envelope-from ) id 1mNERZ-0002Sz-Mv; Mon, 06 Sep 2021 13:13:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179862.326287; Mon, 06 Sep 2021 13:13:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNERZ-0002Sr-JU; Mon, 06 Sep 2021 13:13:49 +0000 Received: by outflank-mailman (input) for mailman id 179862; Mon, 06 Sep 2021 13:13:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNERX-0002SC-V2 for win-pv-devel@lists.xenproject.org; Mon, 06 Sep 2021 13:13:47 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNERX-0004RW-Ls; Mon, 06 Sep 2021 13:13:47 +0000 Received: from host86-143-223-59.range86-143.btcentralplus.com ([86.143.223.59] helo=CBG-R90WXYV0.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mNERX-0003OO-Dm; Mon, 06 Sep 2021 13:13:47 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=zW3jhiChTm+gCEK/ibQv6c6rJglLRAmM+o+afLLf12E=; b=t6w5Bc5s+gRADVK6CNMLOrsS/r ptB8h5husYgwO2JcOXkSb4JCOBqiReE0gCEM9nGPd2/FmpczmYC649Bv9mx6bOrWNlgi8R/CYYlK2 4+1g65785JBKUk/PDbFnetnoJTXRvcEUqNYen16kJm0G0PDIyvmFyX+upWCHdmM0Vy9U=; From: Paul Durrant To: win-pv-devel@lists.xenproject.org Cc: Owen Smith , Paul Durrant Subject: [PATCH xencons] Fix build with later WDKs Date: Mon, 6 Sep 2021 14:13:44 +0100 Message-Id: <20210906131344.2629-1-paul@xen.org> X-Mailer: git-send-email 2.17.1 From: Owen Smith - Adds alias for GetProjectInfoForReference target to version.vcxproj Later kits seemed to have renamed the build target, and will fail without this alias target. - Adds "/fd sha256" to signtool command line WDK 20344 and later require binaries signed with a SHA256 file digest, or the build outputs are deleted Signed-off-by: Owen Smith - Squash warnings 4061 (in xencons.vcxproj) and 26052 (in xencons_monitor.vcxproj) to avoid bogus noise. Signed-off-by: Paul Durrant --- vs2019/package/package.vcxproj | 5 +++++ vs2019/version/version.vcxproj | 6 ++++++ vs2019/xencons/xencons.vcxproj | 5 ++++- vs2019/xencons_coinst/xencons_coinst.vcxproj | 3 +++ vs2019/xencons_monitor/xencons_monitor.vcxproj | 5 ++++- vs2019/xencons_tty/xencons_tty.vcxproj | 3 +++ 6 files changed, 25 insertions(+), 2 deletions(-) diff --git a/vs2019/package/package.vcxproj b/vs2019/package/package.vcxproj index 2248fe0228bc..0e8612672ab0 100644 --- a/vs2019/package/package.vcxproj +++ b/vs2019/package/package.vcxproj @@ -32,6 +32,11 @@ ..\$(ProjectName)\$(ConfigurationName)\$(Platform)\ ..\$(ConfigurationName)\$(Platform)\ + + + sha256 + + ..\..\$(SolutionName)\x86 diff --git a/vs2019/version/version.vcxproj b/vs2019/version/version.vcxproj index 9d149d0f10dd..b6ec6f3ecb0c 100644 --- a/vs2019/version/version.vcxproj +++ b/vs2019/version/version.vcxproj @@ -13,4 +13,10 @@ + + + + + diff --git a/vs2019/xencons/xencons.vcxproj b/vs2019/xencons/xencons.vcxproj index 6cabdcf72aa7..3e6ffecda582 100644 --- a/vs2019/xencons/xencons.vcxproj +++ b/vs2019/xencons/xencons.vcxproj @@ -24,7 +24,7 @@ PROJECT=$(ProjectName);POOL_NX_OPTIN=1;NT_PROCESSOR_GROUPS;%(PreprocessorDefinitions) true EnableAllWarnings - 4464;4711;4770;4548;4820;4668;4255;5045;6001;6054;26451;28196;30030;30029;%(DisableSpecificWarnings) + 4061;4464;4711;4770;4548;4820;4668;4255;5045;6001;6054;26451;28196;30030;30029;%(DisableSpecificWarnings) true true @@ -36,6 +36,9 @@ $(DDK_LIB_PATH)/Rtlver.lib;$(DDK_LIB_PATH)/libcntpr.lib;$(DDK_LIB_PATH)/aux_klib.lib;$(DDK_LIB_PATH)/ksecdd.lib;$(DDK_LIB_PATH)/procgrp.lib;$(DDK_LIB_PATH)/wdmsec.lib;%(AdditionalDependencies) UseLinkTimeCodeGeneration + + sha256 + diff --git a/vs2019/xencons_coinst/xencons_coinst.vcxproj b/vs2019/xencons_coinst/xencons_coinst.vcxproj index 27f54c5ed42a..b10a8cab75e1 100644 --- a/vs2019/xencons_coinst/xencons_coinst.vcxproj +++ b/vs2019/xencons_coinst/xencons_coinst.vcxproj @@ -34,6 +34,9 @@ ../../src/coinst/xencons_coinst.def setupapi.lib;%(AdditionalDependencies) + + sha256 + diff --git a/vs2019/xencons_monitor/xencons_monitor.vcxproj b/vs2019/xencons_monitor/xencons_monitor.vcxproj index c867fa833ced..f94d26d42ce5 100644 --- a/vs2019/xencons_monitor/xencons_monitor.vcxproj +++ b/vs2019/xencons_monitor/xencons_monitor.vcxproj @@ -25,7 +25,7 @@ $(SolutionDir)..\include;%(AdditionalIncludeDirectories) PROJECT=$(ProjectName);WIN32;_WINDOWS;_CRT_SECURE_NO_WARNINGS;%(PreprocessorDefinitions) EnableAllWarnings - 4127;4711;4548;4820;4668;4255;5032;5045;6001;6054;28196;%(DisableSpecificWarnings) + 4127;4711;4548;4820;4668;4255;5032;5045;6001;6054;26052;28196;%(DisableSpecificWarnings) true true MultiThreadedDebug @@ -37,6 +37,9 @@ $(SolutionDir)..\include;%(AdditionalIncludeDirectories) + + sha256 + diff --git a/vs2019/xencons_tty/xencons_tty.vcxproj b/vs2019/xencons_tty/xencons_tty.vcxproj index 16a04ff5c0db..303f15897a95 100644 --- a/vs2019/xencons_tty/xencons_tty.vcxproj +++ b/vs2019/xencons_tty/xencons_tty.vcxproj @@ -34,6 +34,9 @@ $(SolutionDir)..\include;%(AdditionalIncludeDirectories) + + sha256 + -- 2.17.1 From win-pv-devel-bounces@lists.xenproject.org Mon Sep 06 13:44:03 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 06 Sep 2021 13:44:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179938.326396 (Exim 4.92) (envelope-from ) id 1mNEuo-00034d-JE; Mon, 06 Sep 2021 13:44:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179938.326396; Mon, 06 Sep 2021 13:44:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEuo-00034V-GL; Mon, 06 Sep 2021 13:44:02 +0000 Received: by outflank-mailman (input) for mailman id 179938; Mon, 06 Sep 2021 13:44:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEun-00034P-Pt for win-pv-devel@lists.xenproject.org; Mon, 06 Sep 2021 13:44:01 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEun-0004zt-IM; Mon, 06 Sep 2021 13:44:01 +0000 Received: from host86-143-223-59.range86-143.btcentralplus.com ([86.143.223.59] helo=CBG-R90WXYV0.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mNEun-0006Ak-AK; Mon, 06 Sep 2021 13:44:01 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=o5MS/RiFYlrt5vQtB0UAMiuXR3O+6wP+kR/xW3xO5Po=; b=kZS5TnyWqhg22d4p8/W/9qX1Tt nnrz3WgDJan9WMx/K7lQEBikd4tQTUF/0RCqNhZGjYT4bXpTcGzqqfnK3qxGMNwmpjcBHOS+MTXzP K8JeaBf26RkD5wUxr+X8MDS/NlYao9vUCrvS0kT81MdYFNj8jWf9uckH8i4siUEAPGY0=; From: Paul Durrant To: win-pv-devel@lists.xenproject.org Cc: Paul Durrant Subject: [PATCH xenvkbd] Fix build with later WDKs Date: Mon, 6 Sep 2021 14:43:54 +0100 Message-Id: <20210906134354.2951-1-paul@xen.org> X-Mailer: git-send-email 2.17.1 From: Paul Durrant - Adds alias for GetProjectInfoForReference target to version.vcxproj Later kits seemed to have renamed the build target, and will fail without this alias target. - Adds "/fd sha256" to signtool command line WDK 20344 and later require binaries signed with a SHA256 file digest, or the build outputs are deleted - Squash warnings 4061 and 26052 to avoid bogus noise. Signed-off-by: Paul Durrant --- vs2019/package/package.vcxproj | 5 +++++ vs2019/version/version.vcxproj | 6 ++++++ vs2019/xenvkbd/xenvkbd.vcxproj | 5 ++++- vs2019/xenvkbd_coinst/xenvkbd_coinst.vcxproj | 5 ++++- 4 files changed, 19 insertions(+), 2 deletions(-) diff --git a/vs2019/package/package.vcxproj b/vs2019/package/package.vcxproj index 6d2ea8014822..31c078808320 100644 --- a/vs2019/package/package.vcxproj +++ b/vs2019/package/package.vcxproj @@ -31,6 +31,11 @@ ..\$(ProjectName)\$(ConfigurationName)\$(Platform)\ ..\$(ConfigurationName)\$(Platform)\ + + + sha256 + + ..\..\$(SolutionName)\x86 diff --git a/vs2019/version/version.vcxproj b/vs2019/version/version.vcxproj index 9d149d0f10dd..b6ec6f3ecb0c 100644 --- a/vs2019/version/version.vcxproj +++ b/vs2019/version/version.vcxproj @@ -13,4 +13,10 @@ + + + + + diff --git a/vs2019/xenvkbd/xenvkbd.vcxproj b/vs2019/xenvkbd/xenvkbd.vcxproj index d069ccd756f8..e8f13ab71b1e 100644 --- a/vs2019/xenvkbd/xenvkbd.vcxproj +++ b/vs2019/xenvkbd/xenvkbd.vcxproj @@ -24,7 +24,7 @@ PROJECT=$(ProjectName);POOL_NX_OPTIN=1;NT_PROCESSOR_GROUPS;%(PreprocessorDefinitions) true EnableAllWarnings - 4464;4711;4548;4770;4820;4668;4255;5045;6001;6054;26451;28196;30030;30029;%(DisableSpecificWarnings) + 4061;4464;4711;4548;4770;4820;4668;4255;5045;6001;6054;26451;28196;30030;30029;%(DisableSpecificWarnings) true true @@ -36,6 +36,9 @@ $(DDK_LIB_PATH)/Rtlver.lib;$(DDK_LIB_PATH)/libcntpr.lib;$(DDK_LIB_PATH)/aux_klib.lib;$(DDK_LIB_PATH)/ksecdd.lib;$(DDK_LIB_PATH)/procgrp.lib;%(AdditionalDependencies) UseLinkTimeCodeGeneration + + sha256 + diff --git a/vs2019/xenvkbd_coinst/xenvkbd_coinst.vcxproj b/vs2019/xenvkbd_coinst/xenvkbd_coinst.vcxproj index fdcc07b94261..46b63bbcf963 100644 --- a/vs2019/xenvkbd_coinst/xenvkbd_coinst.vcxproj +++ b/vs2019/xenvkbd_coinst/xenvkbd_coinst.vcxproj @@ -24,7 +24,7 @@ PROJECT=$(ProjectName);%(PreprocessorDefinitions) EnableAllWarnings - 4127;4548;4711;4820;4668;4255;5045;6001;6054;28196;%(DisableSpecificWarnings) + 4127;4548;4711;4820;4668;4255;5045;6001;6054;26052;28196;%(DisableSpecificWarnings) true true MultiThreadedDebug @@ -34,6 +34,9 @@ ../../src/coinst/xenvkbd_coinst.def setupapi.lib;%(AdditionalDependencies) + + sha256 + -- 2.17.1 From win-pv-devel-bounces@lists.xenproject.org Mon Sep 06 13:53:38 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 06 Sep 2021 13:53:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179948.326411 (Exim 4.92) (envelope-from ) id 1mNF45-0004hM-Jv; Mon, 06 Sep 2021 13:53:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179948.326411; Mon, 06 Sep 2021 13:53:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNF45-0004h6-GF; Mon, 06 Sep 2021 13:53:37 +0000 Received: by outflank-mailman (input) for mailman id 179948; Mon, 06 Sep 2021 13:53:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNF43-0004gn-Tu for win-pv-devel@lists.xenproject.org; Mon, 06 Sep 2021 13:53:35 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNF43-00059q-Ne; Mon, 06 Sep 2021 13:53:35 +0000 Received: from host86-143-223-59.range86-143.btcentralplus.com ([86.143.223.59] helo=CBG-R90WXYV0.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mNF43-00072o-Dx; Mon, 06 Sep 2021 13:53:35 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=axcBreoJXBcCYS78SzpkHT47+5tfhWNj8UW0hh/DFO0=; b=bR+gFt68c/iYNsB/vovwqmwg6b dv/7ZxtR5OzXIJuTse18Fye7Luc/KVU69ij2NBJYgwfZlFzBx4qsxZNXsa9E7wXbiCfN79K33RqIm uBnKO5HfbFr7EHS/jB8RMktaesMVDzsum1R+88HSLqV3b+a+GNxB8JGZW2PjDdFHdzgc=; From: Paul Durrant To: win-pv-devel@lists.xenproject.org Cc: Paul Durrant Subject: [PATCH xenhid] Fix build with later WDKs Date: Mon, 6 Sep 2021 14:53:29 +0100 Message-Id: <20210906135329.3083-1-paul@xen.org> X-Mailer: git-send-email 2.17.1 From: Paul Durrant - Adds alias for GetProjectInfoForReference target to version.vcxproj Later kits seemed to have renamed the build target, and will fail without this alias target. - Adds "/fd sha256" to signtool command line WDK 20344 and later require binaries signed with a SHA256 file digest, or the build outputs are deleted - Squashes warning 4061 to avoid bogus noise. Signed-off-by: Paul Durrant --- vs2019/package/package.vcxproj | 5 +++++ vs2019/version/version.vcxproj | 6 ++++++ vs2019/xenhid/xenhid.vcxproj | 5 ++++- vs2019/xenhid_coinst/xenhid_coinst.vcxproj | 3 +++ 4 files changed, 18 insertions(+), 1 deletion(-) diff --git a/vs2019/package/package.vcxproj b/vs2019/package/package.vcxproj index 3235f4066558..ed76fe379da8 100644 --- a/vs2019/package/package.vcxproj +++ b/vs2019/package/package.vcxproj @@ -31,6 +31,11 @@ ..\$(ProjectName)\$(ConfigurationName)\$(Platform)\ ..\$(ConfigurationName)\$(Platform)\ + + + sha256 + + ..\..\$(SolutionName)\x86 diff --git a/vs2019/version/version.vcxproj b/vs2019/version/version.vcxproj index 9d149d0f10dd..b6ec6f3ecb0c 100644 --- a/vs2019/version/version.vcxproj +++ b/vs2019/version/version.vcxproj @@ -13,4 +13,10 @@ + + + + + diff --git a/vs2019/xenhid/xenhid.vcxproj b/vs2019/xenhid/xenhid.vcxproj index 4573a59fef5b..b2f48c0725cf 100644 --- a/vs2019/xenhid/xenhid.vcxproj +++ b/vs2019/xenhid/xenhid.vcxproj @@ -24,7 +24,7 @@ PROJECT=$(ProjectName);POOL_NX_OPTIN=1;NT_PROCESSOR_GROUPS;%(PreprocessorDefinitions) true EnableAllWarnings - 4464;4711;4548;4770;4820;4668;4255;5045;6001;6054;26451;28196;30030;30029;%(DisableSpecificWarnings) + 4061;4464;4711;4548;4770;4820;4668;4255;5045;6001;6054;26451;28196;30030;30029;%(DisableSpecificWarnings) true true @@ -36,6 +36,9 @@ $(DDK_LIB_PATH)/hidclass.lib;$(DDK_LIB_PATH)/Rtlver.lib;$(DDK_LIB_PATH)/libcntpr.lib;$(DDK_LIB_PATH)/aux_klib.lib;$(DDK_LIB_PATH)/ksecdd.lib;$(DDK_LIB_PATH)/procgrp.lib;%(AdditionalDependencies) UseLinkTimeCodeGeneration + + sha256 + diff --git a/vs2019/xenhid_coinst/xenhid_coinst.vcxproj b/vs2019/xenhid_coinst/xenhid_coinst.vcxproj index 652d51183cde..f88f409ab40c 100644 --- a/vs2019/xenhid_coinst/xenhid_coinst.vcxproj +++ b/vs2019/xenhid_coinst/xenhid_coinst.vcxproj @@ -34,6 +34,9 @@ ../../src/coinst/xenhid_coinst.def setupapi.lib;%(AdditionalDependencies) + + sha256 + -- 2.17.1 From win-pv-devel-bounces@lists.xenproject.org Tue Sep 07 07:21:13 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 07 Sep 2021 07:21:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180459.327128 (Exim 4.92) (envelope-from ) id 1mNVPr-0007CN-7l; Tue, 07 Sep 2021 07:21:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180459.327128; Tue, 07 Sep 2021 07:21:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNVPr-0007CG-4e; Tue, 07 Sep 2021 07:21:11 +0000 Received: by outflank-mailman (input) for mailman id 180459; Tue, 07 Sep 2021 07:21:09 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNVPp-0007CA-7F for win-pv-devel@lists.xenproject.org; Tue, 07 Sep 2021 07:21:09 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2a00dedf-0fac-11ec-b0d8-12813bfff9fa; Tue, 07 Sep 2021 07:21:06 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 2a00dedf-0fac-11ec-b0d8-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630999266; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=TKurUCZUbU3gw+ky79n9IO3LeT0DaNi6QjI4hzloE8k=; b=duYsu9Q6hueSz25x4PFwsul2fr6rbA8O2porNCBIWxHbfHt+GpjeBXFi 3v0pdHL/pU+1Q0OzOhk6PBXbsE5Cc35WmFEDTOHGdXp1OLis9z2TJ/gKS BvqFAGDOCvURn5UPMmFQL/nKl0ZeFt++Jz5GY91gEBmgw/O7DZyQlQoky I=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: /xVmQK6s1C/SWIQvIGuzPY2Xm7h67xDgUlbAc8Pa1mwFHPF3PoF6GDITGhW8rTGyBStFC4kQrA OSJNUgsJiv3xmsOEaroIgG7kd4XH1We1EDBb6La6pJBM9bpCn8VC0Vwg9XvbwUkJn1ZfYyyzFG ewK9a0wUnGcjlY4cXydtqy3SwX0tk4JcReGH1miT/8p3Zrrr8y45DB+4R0yLIdoYZWCNEUwLOP wFM9TV5B2yQr6uX6PYu7zlmqqGIxJIJc0Nk6TIs8CSJPnCbDBA5V4ZIhNdvIpwkHmy6lzMp6Yt dsXWtZRIw4KFkXHY38f3Tw7j X-SBRS: 5.1 X-MesageID: 52532362 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:bIB6zq3ZrRPUi1GxKlIHbwqjBQdyeYIsimQD101hICG9Lfb2qy n+ppgmPEHP5Qr5AEtQ4+xoS5PwPE80kqQFrrX5XI3SEDUO3VHHEGgM1/qF/9SNIVycygcZ79 YaT0EcMqy/MbEZt7eC3ODQKb9Jq7PnkJxAx92ut0uFJTsaM52IhD0JbzpzZ3cGIzWucqBJcK Z0iPA3xQaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnY4j4uFxd0hZsy+2 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlUFtyssHfqWG1SYczGgNkHmpDq1L/sqq iKn/4UBbUw15oWRBDynfKi4Xi47N9k0Q6f9bbRuwqdnSW+fkNgNyMJv/MmTjLJr0Unp91yy6 RNwiaQsIdWFwrJmGDn68HPTAwCrDv9nZMOq59ks5Vka/pWVFaRl/1swGpFVJMbWC7q4oEuF+ djSMna+fZNaFufK3TUpHNmztCgVmk6Wk7ueDlJhuWFlzxN2HxpxUoRw8IS2n8G6ZImUpFBo+ DJKL5hmr1CRtIfKah9GOACS82qDXGle2OGDEuCZVD8UK0XMXPErJD6pL0z+eGxYZQNiIA/nZ zQOWkowlLau3ieffFm+ac7vywlbF/NLQgF+/sukqSR4IeMNYYDGRfzO2wTrw== X-IronPort-AV: E=Sophos;i="5.85,274,1624334400"; d="scan'208";a="52532362" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GqobCuS4WoupJkz43DM//Qs9SEXmtGLlj7xJdzq3UIn2+ZKhYqai3c5YdNv/iVgM5ctyGgarGR5FFlj+e498thOgwVKT65VZQzbH3gK4riF6gXUaywnP/WqZPb76AxRd7oACdgu1QX+l9ZeIf04MShgm+u8HeWkq+AKkhAUCFTp41pb+DfHwBi8emlSFj+0Mf/lGUOJcC2rMToRF6uDeILuCwrsBoSCfqoS1EP0XguEamCoo+lGHxr5iakQXGzY5MJyBhCS7CHeBYx6meK3wUtVDzz/Llx3INWmhWibPsoTUUeO8+aulmyBPpv/p4vW+XhjCca5eFbA3p/InAGqkYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=TKurUCZUbU3gw+ky79n9IO3LeT0DaNi6QjI4hzloE8k=; b=Qu5z2c98SZuY0GqPBF1Ki/A0Ol5S4ppL4O5l7lvrRmu2yOvUF5FyqtFWRFZ5T5CErAGTYkdfTnl84eM8B9AMa6Zo2CQYEZ7Jmg1Ko/f+Gqtn8W3YUgchTN/BWiSx42isOL5rgH78oHJHNp6DTwjV0azcM91LfcQ1JhsCdClqSUv1oVwxGFbcOtGbBwLmJqfs6fbBUrxi7wBbc6y+uzi1oBUkVp8NtY0uZ+H1MoEs8TfK2EJ2Dx0LBBbW8bgH+LvdEWMSHWKOuckkl+r8rnNLtjmCIWg8gwvR1uCoHVNoLfpIszjb97YnB7Svg7xiWW+WaXhFiDoVWSsDIjTiP9RMIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TKurUCZUbU3gw+ky79n9IO3LeT0DaNi6QjI4hzloE8k=; b=jMi728iv0UyrrGxNOGCRb//suN3qYWwXvNhqGho2WpIC/uX2/BlC71GruFPxxe5oc2dpa8i/iZ8WyMg3AQfG7fjtu8KyyJMdzDLWwE+XONtoQVq09iuctFGnPsJ+vfyZbZCTWsYw+dLbp5OjweBQv5MlAXLSiWakbFMWh6ni5ss= From: Owen Smith To: "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Subject: RE: [PATCH 2/3] Fix SDV/CodeQL log generation Thread-Topic: [PATCH 2/3] Fix SDV/CodeQL log generation Thread-Index: AQHXjf4dSbK6zPqx/U6rlVdURJ9VkKt8GTEAgBsEwgCAATRSoA== Date: Tue, 7 Sep 2021 07:21:02 +0000 Message-ID: References: <20210810154048.1006-1-owen.smith@citrix.com> <20210810154048.1006-2-owen.smith@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 309b29c5-dd0e-4dcd-088d-08d971d00cca x-ms-traffictypediagnostic: DS7PR03MB5478: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VwECHKkb8nxtFZ2WEDtpcT5F/RtooeUmtg/rFqdZqkzZ939Mk/UoSHR/rpKPEHrvFTcJkE3cg1WhFeUAykFd4zDWdyhUdhD0B0iZV8/YNbPxnVQPchFGvZuDZDWZyVPP+TgC/6NofRm8MzUiwLt34/KrLPpKjoOy8ObE9q+Jam24ztw5H9hEdUNBZmq5Y+skw7leClQWW1d7MeWg3xdRop3kz87eUUDYtD1+Ull4cT9OlXXkjjGs+xEu2S/tQeh4ezl0I8r49y1v6fx4mRqrIp3BpJCM5vOhnOaOvh1xtm3Z3DdlJv5bNYA6/ITm0ipqLcc82i35CxzUrerU7AYyb5GnxzcO+HuKs+ME6T70rdJtBCWLPt4YdXlmjJ2in5UsVEiXTW2RYaeiGrXEPFUrXSLPhHqxgvOOzIKllxodzqbtKtwmuQubibgZXNFL4SDbIthtzFurcEQhUe2aKB4uZjHbRhobTyLv/oNYATm2Q4UbqElsdirqBFg50TbQjl90/aEN0LSOdvHfdZG0/vZT9s0m6YAl8+U8EsCF3/yhHh1e1GnXseQyw5Z3ruXZ0wBbZW70xs9C1KGC4iNPy2rTnmkR2+cgoFQ54mLn8PAPQO8UWhxAKmrpMBrLR2lXixxZypNWT2uOu+qXj6yPMnc0QWoIiyaMc/o0mpKb4XXGxLBWW2obcGiHjHnRWjVmuiHv8yoetq2XXns1SpuszhciM01wswAfLinjODs6Nnap+/8KdWeRzdhXsLub3Ska65kiqE4Qzrvd7cUVfBxq1xYIMucKq4n9SOqKJuT9wQuhPW+1x3gc4Ok1WK1QBE4ginxlRciKadrUnejdXgbW0k0g3g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5477.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(2906002)(44832011)(8936002)(7696005)(71200400001)(8676002)(38100700002)(52536014)(38070700005)(5660300002)(86362001)(122000001)(6506007)(508600001)(45080400002)(66556008)(66946007)(53546011)(83380400001)(76116006)(64756008)(186003)(66446008)(66476007)(55016002)(33656002)(26005)(9686003)(110136005)(966005)(316002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VTVYVDFEWGRMeEtwRE5PeFovL25HRitBUnFFY0doSmUwSDh1ZDhkU3JQdkF0?= =?utf-8?B?QjMrSmVYQUY1Y0gzSEVVUVp5SHpMWlBqa0IwdEJkMnJTLzBFQ21VQWFQSmM0?= =?utf-8?B?a3JEcGtvVHF2ZU1XNmRiUktwZzlKcXNCSG5XWUU4d1kyRnM5TVQ2anV2ZHZR?= =?utf-8?B?Z3czNE5Pd3Y4bmk1ajRweEoveEx0VzVzZ1d4TXJZNUVUY0ZQeGhDVmZsK1Ix?= =?utf-8?B?SjI5bE5CRnZvMWZZdk1hSzlOWUtleFdQTjR0L3ViZjhoeDlIQWJNZ29QR0dY?= =?utf-8?B?MVJDT3FMUE1zbC9aUXUwWEg0b1ZFTlJmSHA0NHNXMmZQYXNyZWY0Mmd6R0hN?= =?utf-8?B?UkdZZEdKYnE3TE9aSmtrZmcvY015SGxhSjR3dDAvZ2ZuNVBsYzhYYXp6QXVr?= =?utf-8?B?UWZmRlRqYnJ2YkdqeWc1WkZWYktaNmYyN2ZBRmpIOTduOS8yOWFVd1JySU81?= =?utf-8?B?a2VWVDBndkZTUk12MG5RamNWZHU4Z1BrTnl4SngzR3hraW5HaTVWWDlPa2cy?= =?utf-8?B?czdMNFhCS3hRUVNlc25WblpPdmtjbW40NDlwNmN6RTg2b2hYVHRNaEpXbUpR?= =?utf-8?B?QlpGYTdTNVh3WDVXeGhUKy9pNFdtR0pyc1BUR0xaZUR6c3dIaFc1QW1iTWxL?= =?utf-8?B?emNxRldYM1hVRHpuR3pSV2NNL1oyREo4WDU0UXp1cHE4b1JrcEVZZTNBNDZy?= =?utf-8?B?ZkJkbGNucjlvVU5sWlRxWHZod2ZzZkxDMXJMSU9idjJRSHhsZVRJTWw0bHZ5?= =?utf-8?B?VS9lMzF5Rjd1Rk43T2c4S1VqbUJhRkRoWDhQUUVqWEpWN3U4ODRBMjFCUU05?= =?utf-8?B?WjZ3dFcrZW9DcWgvRlZvWkVlMEgxTlhIcW9kQ0dIRkZ3VkEvUGRYMTRhYnh4?= =?utf-8?B?OHk0OTEwbG9LajZyM3FVZXIvMUdzK1BWUWpBS1Z6Q0tLbkJ3NXk5MytRMEE4?= =?utf-8?B?VXRCelBMLzFFcU9NV1JHRmFQcG1RK0ZqeVdTaWNyNGxVKzI5U2dxVHZTeGVQ?= =?utf-8?B?Tzc3ZHk3TjhBcS9lQVZDL1c1MnlGVmVVcm9Kc1RqbFpoK3Awck5zbHQvYTRt?= =?utf-8?B?RnZNQUt5YkZxMlZtdE84K0JPcGYzdEdYVDVmczUvK3h6Y1p6b0UwWjNvVUw2?= =?utf-8?B?NzZEMGNDQ1p5b0VFOWtvNXNaa1ZGMXplN1BLL0lHWnI4Wk9xT0t6ODZyWGdT?= =?utf-8?B?Z0RVZmdUWWdaMk1uemk2K3hBMUp0QzlWQ2paQ3cwVHpNSk9MZVFadkFoUDd4?= =?utf-8?B?RHN3RFhQKy9uQnpRQ0RJS2hJRGxNdzJ0Rmx0TE9aV3M3ekhmS0dQMURQOVZl?= =?utf-8?B?NFRzK0NoSm9TeUM2d0JNeEU5WWs2SU8rNjdaWWthb2JLYkNTTTNQc0xFcWEx?= =?utf-8?B?WmFPUlZwcmVmaTdZR2RqbHRRVWlEVGQrTFBqdUNGT2NQZDZSOFd3WUlYMW04?= =?utf-8?B?YndONTJVZ3MzZDBxMVV1UzhVUUNpRHhldW53cVFselBZVGFCTG5Fbm5pRTlS?= =?utf-8?B?S2tjbDBYdEZrd1lCb3FGYXZyTFNXd2REYzliS2ZHL25VR3o2eXR2STV4aUEx?= =?utf-8?B?VXE0TmtqRFNuSmdZaVNic29sbmVqYWJFb3V3QW1WT3Z0UlFBOFpMK1JWMU44?= =?utf-8?B?NXZEV3gzeFZaWFpwcnZpOWpIN3FiSWN1YU9mdm81dTlKWTV2TzQ0eVU4c3ln?= =?utf-8?B?YjVPbmxuRjVGRS9GUTdPTG5RNE94M3MrcHdWNzgvSWhVcFRxMmVRU0xlYjlx?= =?utf-8?Q?pABAuTZfBFtzvZXgcnzm41pfYFXsAYDMEPme9lr?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5477.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 309b29c5-dd0e-4dcd-088d-08d971d00cca X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2021 07:21:03.0094 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AJIP+YEgRBwuxKnEJIcR4WbFzrm6FYCoLszacc28CUBXATKG9B0j8OgjPujk0NBx0F4UpbFfEXm83JVGzRXh5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5478 X-OriginatorOrg: citrix.com LS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCkZyb206IHdpbi1wdi1kZXZlbCA8d2luLXB2LWRl dmVsLWJvdW5jZXNAbGlzdHMueGVucHJvamVjdC5vcmc+IE9uIEJlaGFsZiBPZiBQYXVsIER1cnJh bnQNClNlbnQ6IE1vbmRheSwgU2VwdGVtYmVyIDYsIDIwMjEgMTo0NSBQTQ0KVG86IHdpbi1wdi1k ZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KU3ViamVjdDogUmU6IFtQQVRDSCAyLzNdIEZpeCBT RFYvQ29kZVFMIGxvZyBnZW5lcmF0aW9uDQoNCltDQVVUSU9OIC0gRVhURVJOQUwgRU1BSUxdIERP IE5PVCByZXBseSwgY2xpY2sgbGlua3MsIG9yIG9wZW4gYXR0YWNobWVudHMgdW5sZXNzIHlvdSBo YXZlIHZlcmlmaWVkIHRoZSBzZW5kZXIgYW5kIGtub3cgdGhlIGNvbnRlbnQgaXMgc2FmZS4NCg0K T24gMjAvMDgvMjAyMSAwOTowOCwgUGF1bCBEdXJyYW50IHdyb3RlOg0KPiBPbiAxMC8wOC8yMDIx IDE2OjQwLCBPd2VuIFNtaXRoIHdyb3RlOg0KPj4gLSBzYXJpZiBmaWxlcyBuZWVkIHRvIGJlIHN0 b3JlZCB3aXRoIFNEViBsb2dzIHdoZW4gZ2VuZXJhdGluZyB0aGUgRFZMIA0KPj4gZmlsZQ0KPj4g LSBEaXNhYmxlIFBSRUZhc3QgYW5kIENvZGVBbmFseXNpcyBieSBkZWZhdWx0DQo+PiAtIFJ1biBh IHNlcGVyYXRlIENvZGVBbmFseXNpcyBidWlsZCBhZnRlciBTRFYsIGJ1dCBiZWZvcmUgZ2VuZXJh dGluZyANCj4+IERWTCBmaWxlDQo+PiDCoMKgwqDCoCBEVkwgZmlsZSBzaG91bGQgY29udGFpbiBt dWx0aXBsZSBzdW1tYXJ5IGxpbmVzIGZvciBTRFYsIGF0IGxlYXN0DQo+PiAxIGxpbmUNCj4+IMKg wqDCoMKgIGZvciBDb2RlQW5hbHlzaXMgYW5kIGF0IGxlYXN0IDEgbGluZSBmb3IgU2VtbWxlIChD b2RlUUwpDQo+Pg0KPj4gU2lnbmVkLW9mZi1ieTogT3dlbiBTbWl0aCA8b3dlbi5zbWl0aEBjaXRy aXguY29tPg0KPiANCj4gQWNrZWQtYnk6IFBhdWwgRHVycmFudCA8cGF1bEB4ZW4ub3JnPg0KDQpB Y3R1YWxseSBJIHdpdGhkcmF3IG15IGFjayBiZWNhdXNlIENvZGVRTCB0b29sIGRvZXNuJ3QgYXBw ZWFyIHRvIGJlIGluIHRoZSBFV0RLIHRvb2xjaGFpbiBhcyB5ZXQuIFRoaXMgYXQgbGVhc3QgbmVl ZHMgc29tZSBleHBsYW5hdGlvbiBpbiBCVUlMRC5tZCBhcyB0byBob3cgdG8gc2V0IGl0IHVwLi4u IG9yIHBlcmhhcHMgd2Ugd2FpdCBmb3IgYSByZXZpc2VkIEVXREs/DQoNCiAgIFBhdWwNCg0KDQpU aGVyZSBhcmUgYWRkaXRpb25hbCBzZXR1cCB0YXNrcyBuZWVkZWQgb24gdGhlIGJ1aWxkIHN5c3Rl bSB0byBydW4gQ29kZVFMLg0KDQoqIGRvd25sb2FkIENvZGVRTCBlbmdpbmUgZnJvbSBnaXRodWIg KGZyb20gaHR0cHM6Ly9naXRodWIuY29tL2dpdGh1Yi9jb2RlcWwtY2xpLWJpbmFyaWVzL3JlbGVh c2VzLCBsYXRlc3QgdGFnKQ0KKiBhZGQgQ29kZVFMIHRvIFBBVEgNCiogdXNlIGdpdCB0byBjbG9u ZSB0aGUgTVMgZHJpdmVyIHJ1bGVzIHJlcG8gKGh0dHBzOi8vZ2l0aHViLmNvbS9taWNyb3NvZnQv V2luZG93cy1Ecml2ZXItRGV2ZWxvcGVyLVN1cHBsZW1lbnRhbC1Ub29scykNCk5vdGU6IGxheW91 dCBzaG91bGQgYmUgbGlrZToNCjxzb21lLXJvb3Q+XA0KCUNvZGVxbFwNCglXaW5kb3dzLURyaXZl ci1EZXZlbG9wZXItU3VwcGxlbWVudGFsLVRvb2xzXA0KCQ0KDQpGcm9tIGh0dHBzOi8vZG9jcy5t aWNyb3NvZnQuY29tL2VuLXVzL3dpbmRvd3MtaGFyZHdhcmUvZHJpdmVycy9kZXZ0ZXN0L3N0YXRp Yy10b29scy1hbmQtY29kZXFsDQoNCkNvZGVRTCBsb2dzICgqLnNhcmlmKSBtdXN0IGJlIHByZXNl bnQgYW5kIGNsZWFuIHdoZW4gZ2VuZXJhdGluZyB0aGUgKi5EVkwuWE1MIGxvZ3MgZm9yIHRoZSAi U3RhdGljIFRvb2xzIExvZ28gVGVzdCIgdG8gc3VjY2VlZCBmb3IgU2VydmVyIDIwMjIuDQpUaGUg RFZMIGxvZ3Mgc2hvdWxkIGNvbnRhaW4gYSBzdW1tYXJ5IGxpbmUgZm9yIENvZGVRTCBhbmQgQ29k ZSBBbmFseXNpcyBhcyB3ZWxsIGFzIHRoZSBTRFYgcmVzdWx0cy4NCg0KT3dlbg0KDQo= From win-pv-devel-bounces@lists.xenproject.org Tue Sep 07 07:27:00 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 07 Sep 2021 07:27:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180467.327132 (Exim 4.92) (envelope-from ) id 1mNVVS-0007MJ-Mi; Tue, 07 Sep 2021 07:26:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180467.327132; Tue, 07 Sep 2021 07:26:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNVVS-0007MB-JN; Tue, 07 Sep 2021 07:26:58 +0000 Received: by outflank-mailman (input) for mailman id 180467; Tue, 07 Sep 2021 07:26:57 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNVVR-0007M5-0I for win-pv-devel@lists.xenproject.org; Tue, 07 Sep 2021 07:26:57 +0000 Received: from smtp-fw-80006.amazon.com (unknown [99.78.197.217]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f0c5b77c-fcf3-45e4-b914-c1ca4062b20b; Tue, 07 Sep 2021 07:26:55 +0000 (UTC) Received: from pdx4-co-svc-p1-lb2-vlan3.amazon.com (HELO email-inbound-relay-2a-53356bf6.us-west-2.amazon.com) ([10.25.36.214]) by smtp-border-fw-80006.pdx80.corp.amazon.com with ESMTP; 07 Sep 2021 07:26:47 +0000 Received: from EX13D32EUC004.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-2a-53356bf6.us-west-2.amazon.com (Postfix) with ESMTPS id 53E46A1883; Tue, 7 Sep 2021 07:26:46 +0000 (UTC) Received: from EX13D32EUC003.ant.amazon.com (10.43.164.24) by EX13D32EUC004.ant.amazon.com (10.43.164.121) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Tue, 7 Sep 2021 07:26:44 +0000 Received: from EX13D32EUC003.ant.amazon.com ([10.43.164.24]) by EX13D32EUC003.ant.amazon.com ([10.43.164.24]) with mapi id 15.00.1497.023; Tue, 7 Sep 2021 07:26:44 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: f0c5b77c-fcf3-45e4-b914-c1ca4062b20b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.co.uk; i=@amazon.co.uk; q=dns/txt; s=amazon201209; t=1630999616; x=1662535616; h=from:to:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version:subject; bh=4Ml8ElaExWBXNTMz1OLsdxizFv5DbIZdz3R86gNgM9w=; b=v6bqrZTzT1cbOpurTVSZGya7r1Iesm5JajB+BDliZHMWW67wDnLLlLxp OFq1XgvMmj9jFx+tc9awLV5tJdAHeNqFLFjjesGfeKWQrCVzhGAFRVkTm 3TxYBvY2yn5ioF4GvC2FIBsy+eoPHrNO/+DF4s058p773nEGvLa626j6F E=; X-IronPort-AV: E=Sophos;i="5.85,274,1624320000"; d="scan'208";a="24909016" Subject: RE: [PATCH 2/3] Fix SDV/CodeQL log generation Thread-Topic: [PATCH 2/3] Fix SDV/CodeQL log generation From: "Durrant, Paul" To: Owen Smith , "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Thread-Index: AQHXjf6Gh2C3EIdvM0iqN7tq5I+K66t8GTAAgBsEwgCAATfkAIAAAOLA Date: Tue, 7 Sep 2021 07:26:44 +0000 Message-ID: <4423c67e89e444cabcd14c911574d3e4@EX13D32EUC003.ant.amazon.com> References: <20210810154048.1006-1-owen.smith@citrix.com> <20210810154048.1006-2-owen.smith@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.164.90] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiB3aW4tcHYtZGV2ZWwgPHdpbi1w di1kZXZlbC1ib3VuY2VzQGxpc3RzLnhlbnByb2plY3Qub3JnPiBPbiBCZWhhbGYgT2YgT3dlbiBT bWl0aA0KPiBTZW50OiAwNyBTZXB0ZW1iZXIgMjAyMSAwODoyMQ0KPiBUbzogcGF1bEB4ZW4ub3Jn OyB3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcNCj4gU3ViamVjdDogUkU6IFtFWFRF Uk5BTF0gW1BBVENIIDIvM10gRml4IFNEVi9Db2RlUUwgbG9nIGdlbmVyYXRpb24NCj4gDQo+IENB VVRJT046IFRoaXMgZW1haWwgb3JpZ2luYXRlZCBmcm9tIG91dHNpZGUgb2YgdGhlIG9yZ2FuaXph dGlvbi4gRG8gbm90IGNsaWNrIGxpbmtzIG9yIG9wZW4NCj4gYXR0YWNobWVudHMgdW5sZXNzIHlv dSBjYW4gY29uZmlybSB0aGUgc2VuZGVyIGFuZCBrbm93IHRoZSBjb250ZW50IGlzIHNhZmUuDQo+ IA0KPiANCj4gDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IHdpbi1wdi1k ZXZlbCA8d2luLXB2LWRldmVsLWJvdW5jZXNAbGlzdHMueGVucHJvamVjdC5vcmc+IE9uIEJlaGFs ZiBPZiBQYXVsIER1cnJhbnQNCj4gU2VudDogTW9uZGF5LCBTZXB0ZW1iZXIgNiwgMjAyMSAxOjQ1 IFBNDQo+IFRvOiB3aW4tcHYtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcNCj4gU3ViamVjdDog UmU6IFtQQVRDSCAyLzNdIEZpeCBTRFYvQ29kZVFMIGxvZyBnZW5lcmF0aW9uDQo+IA0KPiBbQ0FV VElPTiAtIEVYVEVSTkFMIEVNQUlMXSBETyBOT1QgcmVwbHksIGNsaWNrIGxpbmtzLCBvciBvcGVu IGF0dGFjaG1lbnRzIHVubGVzcyB5b3UgaGF2ZSB2ZXJpZmllZCB0aGUNCj4gc2VuZGVyIGFuZCBr bm93IHRoZSBjb250ZW50IGlzIHNhZmUuDQo+IA0KPiBPbiAyMC8wOC8yMDIxIDA5OjA4LCBQYXVs IER1cnJhbnQgd3JvdGU6DQo+ID4gT24gMTAvMDgvMjAyMSAxNjo0MCwgT3dlbiBTbWl0aCB3cm90 ZToNCj4gPj4gLSBzYXJpZiBmaWxlcyBuZWVkIHRvIGJlIHN0b3JlZCB3aXRoIFNEViBsb2dzIHdo ZW4gZ2VuZXJhdGluZyB0aGUgRFZMDQo+ID4+IGZpbGUNCj4gPj4gLSBEaXNhYmxlIFBSRUZhc3Qg YW5kIENvZGVBbmFseXNpcyBieSBkZWZhdWx0DQo+ID4+IC0gUnVuIGEgc2VwZXJhdGUgQ29kZUFu YWx5c2lzIGJ1aWxkIGFmdGVyIFNEViwgYnV0IGJlZm9yZSBnZW5lcmF0aW5nDQo+ID4+IERWTCBm aWxlDQo+ID4+ICAgICAgRFZMIGZpbGUgc2hvdWxkIGNvbnRhaW4gbXVsdGlwbGUgc3VtbWFyeSBs aW5lcyBmb3IgU0RWLCBhdCBsZWFzdA0KPiA+PiAxIGxpbmUNCj4gPj4gICAgICBmb3IgQ29kZUFu YWx5c2lzIGFuZCBhdCBsZWFzdCAxIGxpbmUgZm9yIFNlbW1sZSAoQ29kZVFMKQ0KPiA+Pg0KPiA+ PiBTaWduZWQtb2ZmLWJ5OiBPd2VuIFNtaXRoIDxvd2VuLnNtaXRoQGNpdHJpeC5jb20+DQo+ID4N Cj4gPiBBY2tlZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsQHhlbi5vcmc+DQo+IA0KPiBBY3R1YWxs eSBJIHdpdGhkcmF3IG15IGFjayBiZWNhdXNlIENvZGVRTCB0b29sIGRvZXNuJ3QgYXBwZWFyIHRv IGJlIGluIHRoZSBFV0RLIHRvb2xjaGFpbiBhcyB5ZXQuIFRoaXMNCj4gYXQgbGVhc3QgbmVlZHMg c29tZSBleHBsYW5hdGlvbiBpbiBCVUlMRC5tZCBhcyB0byBob3cgdG8gc2V0IGl0IHVwLi4uIG9y IHBlcmhhcHMgd2Ugd2FpdCBmb3IgYSByZXZpc2VkDQo+IEVXREs/DQo+IA0KPiAgICBQYXVsDQo+ IA0KPiANCj4gVGhlcmUgYXJlIGFkZGl0aW9uYWwgc2V0dXAgdGFza3MgbmVlZGVkIG9uIHRoZSBi dWlsZCBzeXN0ZW0gdG8gcnVuIENvZGVRTC4NCj4gDQo+ICogZG93bmxvYWQgQ29kZVFMIGVuZ2lu ZSBmcm9tIGdpdGh1YiAoZnJvbSBodHRwczovL2dpdGh1Yi5jb20vZ2l0aHViL2NvZGVxbC1jbGkt YmluYXJpZXMvcmVsZWFzZXMsDQo+IGxhdGVzdCB0YWcpDQo+ICogYWRkIENvZGVRTCB0byBQQVRI DQo+ICogdXNlIGdpdCB0byBjbG9uZSB0aGUgTVMgZHJpdmVyIHJ1bGVzIHJlcG8gKGh0dHBzOi8v Z2l0aHViLmNvbS9taWNyb3NvZnQvV2luZG93cy1Ecml2ZXItRGV2ZWxvcGVyLQ0KPiBTdXBwbGVt ZW50YWwtVG9vbHMpDQo+IE5vdGU6IGxheW91dCBzaG91bGQgYmUgbGlrZToNCj4gPHNvbWUtcm9v dD5cDQo+ICAgICAgICAgQ29kZXFsXA0KPiAgICAgICAgIFdpbmRvd3MtRHJpdmVyLURldmVsb3Bl ci1TdXBwbGVtZW50YWwtVG9vbHNcDQo+IA0KPiANCj4gRnJvbSBodHRwczovL2RvY3MubWljcm9z b2Z0LmNvbS9lbi11cy93aW5kb3dzLWhhcmR3YXJlL2RyaXZlcnMvZGV2dGVzdC9zdGF0aWMtdG9v bHMtYW5kLWNvZGVxbA0KPiANCj4gQ29kZVFMIGxvZ3MgKCouc2FyaWYpIG11c3QgYmUgcHJlc2Vu dCBhbmQgY2xlYW4gd2hlbiBnZW5lcmF0aW5nIHRoZSAqLkRWTC5YTUwgbG9ncyBmb3IgdGhlICJT dGF0aWMNCj4gVG9vbHMgTG9nbyBUZXN0IiB0byBzdWNjZWVkIGZvciBTZXJ2ZXIgMjAyMi4NCj4g VGhlIERWTCBsb2dzIHNob3VsZCBjb250YWluIGEgc3VtbWFyeSBsaW5lIGZvciBDb2RlUUwgYW5k IENvZGUgQW5hbHlzaXMgYXMgd2VsbCBhcyB0aGUgU0RWIHJlc3VsdHMuDQo+IA0KDQpPSy4gQ291 bGQgd2UgaGF2ZSBhIHBhdGNoIHdpdGggdGhvc2Ugd29yZHMgaW4gQlVJTEQubWQgKHBsdXMgbWVu dGlvbiBvZiB0aGUgbmV3ZXIgRVdESykgZm9yIGVhY2ggb2YgdGhlIGRyaXZlcnM/IFRoZW4gSSBj YW4gc3RhcnQgdGFraW5nIHRoZSByZWxhdGVkIHBhdGNoZXMgaW4gc28gdGhhdCBmb2xrcyBjYW4g YWN0dWFsbHkgdXNlIHRoZSBuZXcgdG9vbC4NCg0KICBUaGFua3MsDQoNCiAgICBQYXVsDQoNCj4g T3dlbg0KDQo= From win-pv-devel-bounces@lists.xenproject.org Tue Sep 07 08:16:42 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 07 Sep 2021 08:16:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180578.327303 (Exim 4.92) (envelope-from ) id 1mNWHZ-00037N-Q9; Tue, 07 Sep 2021 08:16:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180578.327303; Tue, 07 Sep 2021 08:16:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNWHZ-00037G-Mk; Tue, 07 Sep 2021 08:16:41 +0000 Received: by outflank-mailman (input) for mailman id 180578; Tue, 07 Sep 2021 08:16:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNWHY-000376-6w for win-pv-devel@lists.xenproject.org; Tue, 07 Sep 2021 08:16:40 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 50842aeb-2788-4ce1-a97d-52b56dfb9bf8; Tue, 07 Sep 2021 08:16:37 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 50842aeb-2788-4ce1-a97d-52b56dfb9bf8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1631002597; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=zMotJP2iGhD7y4ImxI4OgpFxTnRhuIIfkRhg/zCOSr8=; b=UzFHJ+xyRt4mba60ryQUPWAOh5j/Ec/VVCdjg1h6FxJSgvBf1Q/+Hs23 Gq39ETNPx/OKHRbLlQ3LGTevbbUpqLvfSspkYms8VPqOBkuAnMWeQLyyT 9Afb4qHElrzuK0KrOvVS9h8LjCGrK4bc9xDZ/083I9jrpXZerdGMoHluR E=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: GD9rStSB7h4dUGmRERh62Wc0+1iT0mn8E+zaFQJYXA9NYK9ENCOaJaXc7mu5A6oPtbIC6fGo6M HLdqlZS0TZzDo/dZ6aRG/KZLVC34n9W1GVS4QoKa4gMFfqWvoU+NG3egftj8CO+WoUDOkg7s9w oIIfJNgH7unIToGI3I75HEtS1KaWT751RSxOoO+sI6Gn8EuXeMGtNbqabftf8Vc673jtGHo7qB N4p3i8hY1P0QCl/yovX1c6stNNaQT6PyyQrrVtPtbPOsoFB94oAAXISGxNGoDYYTeVCK3R4Mrx PZp/LlidoqdCRWNAeCdq4MiS X-SBRS: 5.1 X-MesageID: 52119736 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:2xY01KqTfFVlDjWP5cj2ny8aV5rveYIsimQD101hICG9Evb0qy nOpoV/6faQslwssR4b9uxoVJPvfZq+z+8W3WByB9eftWDd0QPFEGgL1+DfKlbbak7DH4BmtJ uJc8JFeafN5VoRt7eG3OFveexQvOVu88qT9JjjJ28Gd3APV0n5hT0JcjpyFCdNNW57LKt8Lr WwzOxdqQGtfHwGB/7LfUXsD4D41rv2fIuNW29+OyIa X-IronPort-AV: E=Sophos;i="5.85,274,1624334400"; d="scan'208";a="52119736" From: Owen Smith To: CC: Owen Smith Subject: [PATCH] Document CodeQL build requirements Date: Tue, 7 Sep 2021 09:10:46 +0100 Message-ID: <20210907081046.2021-1-owen.smith@citrix.com> X-Mailer: git-send-email 2.31.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain CodeQL requires an additional tool and rule set which are seperate from the EWDK ISOs, and require manual installation and configuration Signed-off-by: Owen Smith --- BUILD.md | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/BUILD.md b/BUILD.md index 574ff98..aeca39e 100644 --- a/BUILD.md +++ b/BUILD.md @@ -7,6 +7,7 @@ ISO containing all the build environment you need. The package should support building with the following EWDKs: +- EWDK for Server 2022, version 22000 with Visual Studio Build Tools 16.9 - EWDK for Windows 10, version 1903 with Visual Studio Build Tools 16.0 - EWDK for Windows 10, version 1809 with Visual Studio Build Tools 15.8.9 @@ -29,3 +30,14 @@ by default. However, if you set the environment variable DPINST_REDIST to point to a directory with x86 and x64 sub-directories containing 32- and 64-bit dpinst.exe binaries (respectively) then these will be copied into the built packages, making installation more convenient. + +NOTE: In order to use the '-CodeQL' parameter to generate *.sarif log files, +an additional tool and set of rules will need installing. The CodeQL engine +can be downloaded from https://github.com/github/codeql-cli-binaries/releases +and the driver specific rules can be cloned from +https://github.com/microsoft/Windows-Driver-Developer-Supplemental-Tools. +Once acquired, the rules need to be in a sibling folder of the engine (e.g. +C:\Tools\CodeQL and C:\Tools\Windows-Driver-Developer-Supplemental-Tools) and +the CodeQL engine (e.g. C:\Tools\CodeQL) must be added to the PATH environment +variable. Further information available at +https://docs.microsoft.com/en-us/windows-hardware/drivers/devtest/static-tools-and-codeql -- 2.31.1.windows.1 From win-pv-devel-bounces@lists.xenproject.org Tue Sep 07 08:23:53 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 07 Sep 2021 08:23:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180600.327329 (Exim 4.92) (envelope-from ) id 1mNWOV-0005cA-VG; Tue, 07 Sep 2021 08:23:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180600.327329; Tue, 07 Sep 2021 08:23:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNWOV-0005c3-SD; Tue, 07 Sep 2021 08:23:51 +0000 Received: by outflank-mailman (input) for mailman id 180600; Tue, 07 Sep 2021 08:23:50 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNWOU-0005bx-JU for win-pv-devel@lists.xenproject.org; Tue, 07 Sep 2021 08:23:50 +0000 Received: from mail-wr1-x436.google.com (unknown [2a00:1450:4864:20::436]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 48f44935-a38c-4bfe-99b8-465f4ddf18fd; Tue, 07 Sep 2021 08:23:49 +0000 (UTC) Received: by mail-wr1-x436.google.com with SMTP id x6so13110456wrv.13 for ; Tue, 07 Sep 2021 01:23:49 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:9c3c:c4ef:ed35:a2e1? ([2a00:23c5:5785:9a01:9c3c:c4ef:ed35:a2e1]) by smtp.gmail.com with ESMTPSA id n4sm10523470wra.37.2021.09.07.01.23.48 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Sep 2021 01:23:48 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 48f44935-a38c-4bfe-99b8-465f4ddf18fd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=V9z6RfL3iHIfdwcuVQYzevcMtAdn3u+H3GvQgweb4j0=; b=imCVEHSleOP67FmxLtSPZJMzfOK9PO8A6gouXxOk/Du89yHdqr7JNyA0BNNG8d9x1p TIl/8B5TPvJmFUFcJFQQN69sfmxSghMGRwqDUZ0RE+vO2PhjhoFqsL++kKoT6BYMghvG H/OTkMja+jnBqTLY7I7l7amuD2g24F7jD7Mu3cjoLIyiFdpFsBrbJV57+c2aAM7wYOJt gMEo9kcMFuCpuj40B0NFyLZQ5QOQdQdxAayray+dQivwsblkfCSzfsjgq4n2tpqxvYh4 2RF+K8GXNm5HFVforBw19no5LJmCy1ECM25qTj3dvRrQJOejp8Aax0jLAE5vAsMCPPQM LyGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=V9z6RfL3iHIfdwcuVQYzevcMtAdn3u+H3GvQgweb4j0=; b=VKDoFATXX9r8o5O4MapA4657XnNW8g9jcJITPm6awb07cK9TRngwwzX4V7+xwqdonN jGp1AmaPS+mfUjG0wIqxLtiBuleWQcAQA3Cs+rs/yE+2nfDWPPWk2dOW2y+GRPP7WJZ5 bWkEI2WEnu508HC/aC7QDFd38DYcHhVEBe8CCSc8aXJqqBfWk48TJAnAY2RbXWsrq8PU K9rl+7to17NiNbMfteUj6LWM4qJmGFnRee5rbZ8t3cKLwQbh9Ht5vNTscXD0tw34jOgT MoHbNvDsRB60epWFgJXgca/S/KHp8Tu+1O8+wy0JAoeg3dPnzRWcT0Tc5BmrfC8EcPnC Ejsg== X-Gm-Message-State: AOAM5328YsDUmwy4FDBJ3nltYX01hCULAT8eZmSWEryEC6A2dJcn3tOe GLccyWF67Jl6EtQfAMhE6ooIADqHUEs= X-Google-Smtp-Source: ABdhPJw3Dh0fzdImpd/1dVlG/bXETchxKllr/4nc4teFdeDBxo8iE9Z0v+Eemvl+JyVYkwe3sZvNkA== X-Received: by 2002:adf:ea0c:: with SMTP id q12mr17819391wrm.392.1631003028700; Tue, 07 Sep 2021 01:23:48 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH] Document CodeQL build requirements To: win-pv-devel@lists.xenproject.org References: <20210907081046.2021-1-owen.smith@citrix.com> Message-ID: <3e6c1e40-017e-0be5-6b43-85ce037d6efd@xen.org> Date: Tue, 7 Sep 2021 09:23:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210907081046.2021-1-owen.smith@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/09/2021 09:10, Owen Smith wrote: > CodeQL requires an additional tool and rule set which are seperate from the > EWDK ISOs, and require manual installation and configuration > > Signed-off-by: Owen Smith Thanks. Acked-by: Paul Durrant I'll apply this to all drivers. > --- > BUILD.md | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/BUILD.md b/BUILD.md > index 574ff98..aeca39e 100644 > --- a/BUILD.md > +++ b/BUILD.md > @@ -7,6 +7,7 @@ ISO containing all the build environment you need. > > The package should support building with the following EWDKs: > > +- EWDK for Server 2022, version 22000 with Visual Studio Build Tools 16.9 > - EWDK for Windows 10, version 1903 with Visual Studio Build Tools 16.0 > - EWDK for Windows 10, version 1809 with Visual Studio Build Tools 15.8.9 > > @@ -29,3 +30,14 @@ by default. However, if you set the environment variable DPINST_REDIST to > point to a directory with x86 and x64 sub-directories containing 32- and > 64-bit dpinst.exe binaries (respectively) then these will be copied into > the built packages, making installation more convenient. > + > +NOTE: In order to use the '-CodeQL' parameter to generate *.sarif log files, > +an additional tool and set of rules will need installing. The CodeQL engine > +can be downloaded from https://github.com/github/codeql-cli-binaries/releases > +and the driver specific rules can be cloned from > +https://github.com/microsoft/Windows-Driver-Developer-Supplemental-Tools. > +Once acquired, the rules need to be in a sibling folder of the engine (e.g. > +C:\Tools\CodeQL and C:\Tools\Windows-Driver-Developer-Supplemental-Tools) and > +the CodeQL engine (e.g. C:\Tools\CodeQL) must be added to the PATH environment > +variable. Further information available at > +https://docs.microsoft.com/en-us/windows-hardware/drivers/devtest/static-tools-and-codeql > From win-pv-devel-bounces@lists.xenproject.org Mon Sep 20 08:26:00 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 20 Sep 2021 08:26:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.190324.340169 (Exim 4.92) (envelope-from ) id 1mSEcg-00061M-Je; Mon, 20 Sep 2021 08:25:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 190324.340169; Mon, 20 Sep 2021 08:25:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSEcg-00061E-Gf; Mon, 20 Sep 2021 08:25:58 +0000 Received: by outflank-mailman (input) for mailman id 190324; Mon, 20 Sep 2021 08:25:57 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSEcf-000612-86 for win-pv-devel@lists.xenproject.org; Mon, 20 Sep 2021 08:25:57 +0000 Received: from mail-wm1-x332.google.com (unknown [2a00:1450:4864:20::332]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1afcb0a4-db10-475e-a5e3-a100bdf74569; Mon, 20 Sep 2021 08:25:56 +0000 (UTC) Received: by mail-wm1-x332.google.com with SMTP id 140so12503680wma.0 for ; Mon, 20 Sep 2021 01:25:56 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:8054:8246:c929:2240? ([2a00:23c5:5785:9a01:8054:8246:c929:2240]) by smtp.gmail.com with ESMTPSA id f7sm18515849wmh.20.2021.09.20.01.25.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Sep 2021 01:25:55 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 1afcb0a4-db10-475e-a5e3-a100bdf74569 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=o6+p71lLGAfHLiH3BNTS356lbKTYbenjZ3aadbCXMII=; b=R9q8l2U/4faga5IXNdkCGC14tsDMSxFvHWjODyYiysuBsEyTy8hA4Bv2ztKuayZvbJ NbyffP30FShtTaYgqHbL3ulxJkUDVJ2GX5Le4/uyTFqL9H8cywqrLhVkP4k5m5McM3Yp Cll0O34wxNTx3GECr7avg4BoPcZDyqZOAHkZ8qFrxQ6gMx11WVX4/GaKzKN8iVS531rY p97dG6sG/AUe+j1zmd7ur6w91MUsLwiDQ3ouHf4Lt6/09vFUVWqMn9VB7UjVolBvAweq PDmiK9edZeSHskcq+OEoGKwDrD5ZDnaSe/cLSWyUuug2CQHlBwAUjTTpNqDcF3XNxgsQ SxYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=o6+p71lLGAfHLiH3BNTS356lbKTYbenjZ3aadbCXMII=; b=d0+IV61csuUHxSbAIXQ1bThiTNl9XMiqP/evOKGpYlLLib6t06roEg8A3RoLI03YHH /xIJLjd6IMmG5/jRy40kxghoPpHHE33aWohsxZumlP5YA6ejKVx4qWtGGqTfmsUEBW52 ZVSrXfV5ehPuFhJU0kqAoN2ZgXx8bPjaNf0K+7Po7wOWWKYbqCI+D3S9sDF2H97nFRBy P0JOLsYE8RcI7j8nXT0PEtoxP5kqxz+nrppsT8Ad5hqEPFlM7mB4lurXqqbMTd7TUYSS QzENJqNzOHFhDs9wWCA4jvv3pKcy23nlZlWho9A0Zr9vg3KnWYFeBy9SeodHr55OnEph Uptg== X-Gm-Message-State: AOAM532EjwQxetOO15/XK/GItDQNqqVAUGCPhXu44wqUznH6MD8JUqJ3 r4iGIZFBITeNuL7lVs5Gr+aq3vN+tP0= X-Google-Smtp-Source: ABdhPJxRDlJuXjr1QQZNtATTWXrw7na5FGeWK9cmPmXBZwYNB+ESpcegNYwTvrzzVu3yPuq1D88dBQ== X-Received: by 2002:a05:600c:4106:: with SMTP id j6mr15422033wmi.99.1632126355587; Mon, 20 Sep 2021 01:25:55 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 3/3] Fix issues raised by CodeQL To: Owen Smith , "win-pv-devel@lists.xenproject.org" References: <20210810154048.1006-1-owen.smith@citrix.com> <20210810154048.1006-3-owen.smith@citrix.com> <5d06ae38-28c4-9501-4c55-c0cd9dffb8e3@xen.org> Message-ID: Date: Mon, 20 Sep 2021 09:25:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 31/08/2021 08:23, Owen Smith wrote: > > > -----Original Message----- > From: win-pv-devel On Behalf Of Paul Durrant > Sent: Friday, August 20, 2021 9:15 AM > To: win-pv-devel@lists.xenproject.org > Subject: Re: [PATCH 3/3] Fix issues raised by CodeQL > > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments unless you have verified the sender and know the content is safe. > > On 10/08/2021 16:40, Owen Smith wrote: >> - ExAllocatePoolWithTag is deprecated in Windows 10 2004 and replaced with >> ExAllocatePool2. Use ExAllocatePoolUninitialized to maintain support for >> earlier versions of Windows. >> - strtol can fail, check for LONG_MIN or LONG_MAX as indicators of an >> error > > I think these probably ought to be separate patches. As for the strtol() change... There also uses of strtoul() (and _strtoui64()) elsewhere. If we're going to catch overflow here then ought we not have similar checking there? > > Paul > > Only strtol() was flagged as a warning by the newer compiler, not strtoul() or _strtoui64(). I only fixed the minimum to get the compile to stop raising warnings > Ok, I see why now. I've re-worked that part of the patch as follows: ----- diff --git a/src/xenfilt/emulated.c b/src/xenfilt/emulated.c index 0c2c08761875..83b20704a642 100644 --- a/src/xenfilt/emulated.c +++ b/src/xenfilt/emulated.c @@ -171,30 +171,30 @@ EmulatedSetObjectDiskData( if (Type != XENFILT_EMULATED_OBJECT_TYPE_IDE) goto fail1; - Controller = strtol(InstanceID, &End, 10); + Controller = strtoul(InstanceID, &End, 10); status = STATUS_INVALID_PARAMETER; - if (*End != '.' || Controller > 1) + if (Controller > 1 || *End != '.') goto fail2; End++; - Target = strtol(End, &End, 10); + Target = strtoul(End, &End, 10); status = STATUS_INVALID_PARAMETER; - if (*End != '.' || Target > 1) + if (Target > 1 || *End != '.') goto fail3; End++; - Lun = strtol(End, &End, 10); - - status = STATUS_INVALID_PARAMETER; - if (*End != '\0') - goto fail4; + Lun = strtoul(End, &End, 10); status = STATUS_NOT_SUPPORTED; if (Lun != 0) + goto fail4; + + status = STATUS_INVALID_PARAMETER; + if (*End != '\0') goto fail5; EmulatedObject->Data.Disk.Index = Controller << 1 | Target; ----- This is somewhat less invasive. Paul From win-pv-devel-bounces@lists.xenproject.org Mon Sep 20 08:37:04 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 20 Sep 2021 08:37:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.190345.340197 (Exim 4.92) (envelope-from ) id 1mSEnP-0007s9-QK; Mon, 20 Sep 2021 08:37:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 190345.340197; Mon, 20 Sep 2021 08:37:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSEnP-0007s1-Mm; Mon, 20 Sep 2021 08:37:03 +0000 Received: by outflank-mailman (input) for mailman id 190345; Mon, 20 Sep 2021 08:37:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSEnO-0007rs-Bo for win-pv-devel@lists.xenproject.org; Mon, 20 Sep 2021 08:37:02 +0000 Received: from mail-wm1-x329.google.com (unknown [2a00:1450:4864:20::329]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id dbf56fb9-cd46-4fe6-bd09-751b3eedb03d; Mon, 20 Sep 2021 08:37:01 +0000 (UTC) Received: by mail-wm1-x329.google.com with SMTP id 192-20020a1c04c9000000b002f7a4ab0a49so10930278wme.0 for ; Mon, 20 Sep 2021 01:37:01 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:8054:8246:c929:2240? ([2a00:23c5:5785:9a01:8054:8246:c929:2240]) by smtp.gmail.com with ESMTPSA id u6sm17961500wrp.0.2021.09.20.01.37.00 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Sep 2021 01:37:00 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: dbf56fb9-cd46-4fe6-bd09-751b3eedb03d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=BIb3TL9TO3L7qDKCJvKgWPkkglXGop/JtWTRwWdK9QY=; b=N+RNVDvHv/goEoS6SVxE1MRshyEk+gOGgkyiNEk4T0tnSwQqQyFYHyiDui6bQmUa78 2BdIPlkGtBr6HCXBWzioLekIzaGKHq3mK3Dznt0BAVhdciU2j48A73V4UmzXxUzmWFgU QYp8RHo6FmFcgFHeIQpCVTdxB0h36wEk7cONa4nDxDh88QTzpPfXFjtGNv1GkeVt81uD GtZWjAP+zGRnAtHN6R4e9CXuWMi8edJQ97ThT6evDXkR5uOc81dS5ejDWVFbN+VGBjSN LrukRCz18ZsI6pXuC00kZBZM8n14SLx5YT3B5KqIc7ZrnIVx8kv1JtE+ZCa4QaXpu5H2 F8fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BIb3TL9TO3L7qDKCJvKgWPkkglXGop/JtWTRwWdK9QY=; b=ZINUO6cnoGI8S+L+ktcgTzNVgiwjjXq74tH7ueDxftGphurzhSbq0k1CB+mPLru0Q+ kNonbl3xPItyZhjxPBXXgfOtz45p+prY6OqDhiIIQvrO6khLx+70E7PZFBezrDbbanIm DhSog59eUJWx6faQrtyhxfm5N6nSxf9yGUrGZW/aImpBQS+30DVv/gJDbCX1/BjipVdN dG8R+iASW5qfWMXyk5zZ8hQRtJgfOzJ0/WKYLvMU/H6GUEdFtuxpao9Hv//8jTXIEZTO IpXTgOmzgNrpgLCNt4QS80kiIVRn/ealXCNVmr+LQgR8deYcYSSOpaQzP1tJ2kTlZMZr igSw== X-Gm-Message-State: AOAM530uBKDMrYAzqJ25KV+RECbrpcG+BFi/8D2o0J+GyPWQVxWc+26q bvowq+f/XQ40cA8+Jrh4wc579gipNpQ= X-Google-Smtp-Source: ABdhPJzlEExuSjtphBNCrQCn/Cz0KZQHCaFtM3noqqYYhhU75PtqZkxX2nEz6tAQaeruMYteBHTBBA== X-Received: by 2002:a1c:7f89:: with SMTP id a131mr27250811wmd.31.1632127020802; Mon, 20 Sep 2021 01:37:00 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 2/3] Fix SDV/CodeQL log generation To: win-pv-devel@lists.xenproject.org References: <20210812123612.1826-1-owen.smith@citrix.com> <20210812123612.1826-2-owen.smith@citrix.com> Message-ID: <083f2cbc-d201-25f9-223b-0f6d065da2c4@xen.org> Date: Mon, 20 Sep 2021 09:36:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210812123612.1826-2-owen.smith@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/08/2021 13:36, Owen Smith wrote: > - sarif files need to be stored with SDV logs when generating the DVL file > - Disable PREFast and CodeAnalysis by default > - Run a seperate CodeAnalysis build after SDV, but before generating DVL file > DVL file should contain multiple summary lines for SDV, at least 1 line > for CodeAnalysis and at least 1 line for Semmle (CodeQL) > > Signed-off-by: Owen Smith Acked-by: Paul Durrant From win-pv-devel-bounces@lists.xenproject.org Mon Sep 20 08:38:01 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 20 Sep 2021 08:38:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.190353.340201 (Exim 4.92) (envelope-from ) id 1mSEoK-00081b-T8; Mon, 20 Sep 2021 08:38:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 190353.340201; Mon, 20 Sep 2021 08:38:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSEoK-00081U-QG; Mon, 20 Sep 2021 08:38:00 +0000 Received: by outflank-mailman (input) for mailman id 190353; Mon, 20 Sep 2021 08:37:59 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSEoJ-00081N-S1 for win-pv-devel@lists.xenproject.org; Mon, 20 Sep 2021 08:37:59 +0000 Received: from mail-wm1-x32e.google.com (unknown [2a00:1450:4864:20::32e]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ddc370f4-5162-4f36-9121-1e9aee48ac55; Mon, 20 Sep 2021 08:37:59 +0000 (UTC) Received: by mail-wm1-x32e.google.com with SMTP id b21-20020a1c8015000000b003049690d882so14899815wmd.5 for ; Mon, 20 Sep 2021 01:37:59 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:8054:8246:c929:2240? ([2a00:23c5:5785:9a01:8054:8246:c929:2240]) by smtp.gmail.com with ESMTPSA id b16sm15276092wrp.82.2021.09.20.01.37.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Sep 2021 01:37:58 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: ddc370f4-5162-4f36-9121-1e9aee48ac55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XBrXmG1Hy9LoluaKePmntqJn1b5KwdBI9VPM7RYRPJU=; b=nuTj6xi32l4IM4FgGDT3kz9aYq8+iHEFCUnPHVtQFtmDDoJCHjcCS+Fx6MakChPEbS ufJ9VxueF5yM+YFNnH2n1RBsBQrwSPS5gDgOvfom7gMHiqy94vpQEa6gS8EhIYIWuq7D Ai3lhDKa5Fuo4Kjpoc9d5xMGpBuhm316uHmXA9KE679pVYLpDscOLGY8PVn3t1cTvDzE kB1npylbhLLVu6x84et0vDzIqYXhie7sYzIjlE4Fd8YbJ4o7/VzyiKTyY+JG8EO37P9z VIXvYmK6tyqUGT4IEj6JghCDHApVHuW7VY+UzhTIfnjS2FEyGk5iHTcSn3Pw1PlyLi9s KwfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XBrXmG1Hy9LoluaKePmntqJn1b5KwdBI9VPM7RYRPJU=; b=T2XGVcRNJ1JiaZGv8ahZpDYVWIDS8wX8TPJMnfCLueUlHYmnRkVCDAK7lwGKVB8whf rHlNnPY82dYQBX3p8nQMhjs2t0szjqSzly11o9qs8BgvIUfhUsWjPauzLTCaQzWFDdoM ia28AexUTmz9BhswD4NFAsyrdUyab9INuJys93zMJ4E4SjHAf77jdBCAMLflbKFjlrGu 05A5XwsDvmbkc4R8reQOfoTHVUJc8xt/t2gjv8XSG/vKiSSD+URBVUbYIlr18Kg2lbXS aqOtTYWR9O1ahdd5FwR6NiKVGOm2AJ1YdjKuJZO2Rcq2Y8nlChlISLKeG15Q08rwB76H 8Vsg== X-Gm-Message-State: AOAM532ozEGJxkX2Rfu6N7dl2gPHb2X2/VNIEi1jJy4M1JVMFdpJ2jfe t/jx680OUv6HOyde3ZCWqQduJFxwFLk= X-Google-Smtp-Source: ABdhPJzRUVqPzz+DZ/ZdhVac1vtbWXdN7rtBZnDMOwF+9p2HzFSzp0vWgvEeccy+XayfcXUPOjUWPw== X-Received: by 2002:a1c:23cb:: with SMTP id j194mr27825402wmj.1.1632127078403; Mon, 20 Sep 2021 01:37:58 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 3/3] Fix CodeQL warnings To: win-pv-devel@lists.xenproject.org References: <20210812123612.1826-1-owen.smith@citrix.com> <20210812123612.1826-3-owen.smith@citrix.com> Message-ID: Date: Mon, 20 Sep 2021 09:37:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210812123612.1826-3-owen.smith@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/08/2021 13:36, Owen Smith wrote: > - ExAllocatePoolWithTag is deprecated for Win10 2004, use > ExAllocatePoolUninitialized instead > - Add "(VOID)" before AccessWmiBuffer, where the return value is not needed > > Signed-off-by: Owen Smith Acked-by: Paul Durrant From win-pv-devel-bounces@lists.xenproject.org Mon Sep 20 08:52:21 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 20 Sep 2021 08:52:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.190363.340205 (Exim 4.92) (envelope-from ) id 1mSF2C-0001Qq-Vf; Mon, 20 Sep 2021 08:52:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 190363.340205; Mon, 20 Sep 2021 08:52:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSF2C-0001Qj-Sa; Mon, 20 Sep 2021 08:52:20 +0000 Received: by outflank-mailman (input) for mailman id 190363; Mon, 20 Sep 2021 08:52:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSF2C-0001Qd-6e for win-pv-devel@lists.xenproject.org; Mon, 20 Sep 2021 08:52:20 +0000 Received: from mail-wr1-x436.google.com (unknown [2a00:1450:4864:20::436]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cb390468-08d8-4c50-9dff-00560fff83c9; Mon, 20 Sep 2021 08:52:19 +0000 (UTC) Received: by mail-wr1-x436.google.com with SMTP id t8so20482323wri.1 for ; Mon, 20 Sep 2021 01:52:19 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:8054:8246:c929:2240? ([2a00:23c5:5785:9a01:8054:8246:c929:2240]) by smtp.gmail.com with ESMTPSA id 4sm13536005wmv.42.2021.09.20.01.52.17 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Sep 2021 01:52:18 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: cb390468-08d8-4c50-9dff-00560fff83c9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LNt9eObihrUMhxQ6dvd0uN5gWnc5TVj3Y16ymu51+h8=; b=RtlQVdeWSDrlYZKwWLDQPOfv40YDMndawXz+u5tdcpT8y8EqnASBYNDa9kQLWvf8Zq 8AqAF5Cc8UN8Xady/TBpaqSDS3v3W7rdB323KM7xPf6hBk1ccg6T8M5FMtZh6u8e3mYm bQOW1Rc3NL3iC8AL5DkFrJC9puzMbTESPnZPqRInTmiOTrWfgI9KiOPOyxciRdFtoGq9 QyoS0zmpwUMQ2Ju/n8Ij8sU3z0SwNuOPmF47RZm31+ZfveuQkhdq62Gajkr5Hj3/Ezmt nMuQl7ieaQZbxUINg4CA7kzSSziQjHneZ88fM/RLo7SpoWlCBUJgFuz8bbvRQeZcjqvX bUDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LNt9eObihrUMhxQ6dvd0uN5gWnc5TVj3Y16ymu51+h8=; b=jAzE5/nykLARfCEoxAQ5Qn5Dxe0ohlJ0S66fqcIPyDBEUJGm8z8OC8Tu3fZmrz7PXR nptrM7mMbS25e055IoQVivLyBJ+Bk8ipbuBXPXQ0/+EgruuGXzDxxvPdwSVvjur40FNU ql9d3xqbx3JXzXI1Pk07f5JdSn6cBZbb16yvSvI1dueVDS7BwVGG6ho0B38b0pS+R/XZ ywYLryz7iXpLHeBJIuwu9fM/Wm+wwm/+OdvPzFM/ofNnXZsjy3yLhGkCA5HrSNCVGaDZ BPPzcBxdHUNyuOH81U2ZdTVOyMzuXBf8acOHk8EjRWKi1yc4kpSkKct3xAZh5AN7brgW a2pg== X-Gm-Message-State: AOAM5315oSfkDLImuHpciYOXrF2dvhjTxnKL322hPKSKAt8NNmFPpToM fg8oUsvdWN06+p6t4qmv22D7RTJSqH4= X-Google-Smtp-Source: ABdhPJzcnFn8JxyZRxuFb4VvDb7SLr1hvl/8J2bKJq5mJLuVOEWF0KQnHywXcR0GE3WjhPmpHrlaeQ== X-Received: by 2002:adf:e390:: with SMTP id e16mr26793120wrm.217.1632127938628; Mon, 20 Sep 2021 01:52:18 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 3/3] Fix CodeQL warnings To: win-pv-devel@lists.xenproject.org References: <20210812123612.1826-1-owen.smith@citrix.com> <20210812123612.1826-3-owen.smith@citrix.com> Message-ID: Date: Mon, 20 Sep 2021 09:52:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 20/09/2021 09:37, Paul Durrant wrote: > On 12/08/2021 13:36, Owen Smith wrote: >> - ExAllocatePoolWithTag is deprecated for Win10 2004, use >>      ExAllocatePoolUninitialized instead >> - Add "(VOID)" before AccessWmiBuffer, where the return value is not >> needed >> >> Signed-off-by: Owen Smith > > Acked-by: Paul Durrant It appears a further patch is required to fix similar ExAllocatePoolWithTag warnings in ioctl_gnttab.c, ioctl_store.c and ioctl_suspend.c. I may just amend this patch instead. Paul From win-pv-devel-bounces@lists.xenproject.org Mon Sep 20 09:06:28 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 20 Sep 2021 09:06:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.190381.340219 (Exim 4.92) (envelope-from ) id 1mSFFs-00032C-8c; Mon, 20 Sep 2021 09:06:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 190381.340219; Mon, 20 Sep 2021 09:06:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSFFs-000325-5o; Mon, 20 Sep 2021 09:06:28 +0000 Received: by outflank-mailman (input) for mailman id 190381; Mon, 20 Sep 2021 09:06:26 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSFFq-00031w-MV for win-pv-devel@lists.xenproject.org; Mon, 20 Sep 2021 09:06:26 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" Date: Mon, 20 Sep 2021 09:06:15 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <27308595.1.1632128776157.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> Subject: XENBUS-master - Build #225 - Successful MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_0_25145132.1632128775766" X-Jenkins-Job: XENBUS-master X-Jenkins-Result: SUCCESS ------=_Part_0_25145132.1632128775766 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #225. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENBUS-master/225/console to view the results. ------=_Part_0_25145132.1632128775766-- From win-pv-devel-bounces@lists.xenproject.org Mon Sep 20 09:07:25 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 20 Sep 2021 09:07:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.190389.340224 (Exim 4.92) (envelope-from ) id 1mSFGn-0003I7-CS; Mon, 20 Sep 2021 09:07:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 190389.340224; Mon, 20 Sep 2021 09:07:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSFGn-0003Hz-9B; Mon, 20 Sep 2021 09:07:25 +0000 Received: by outflank-mailman (input) for mailman id 190389; Mon, 20 Sep 2021 09:07:24 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSFGm-0003Ht-6v for win-pv-devel@lists.xenproject.org; Mon, 20 Sep 2021 09:07:24 +0000 Received: from mail-wm1-x32a.google.com (unknown [2a00:1450:4864:20::32a]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4991b4f0-d65b-4c78-88fb-646bf56c26ad; Mon, 20 Sep 2021 09:07:23 +0000 (UTC) Received: by mail-wm1-x32a.google.com with SMTP id f62-20020a1c1f41000000b0030b42643f72so6532291wmf.3 for ; Mon, 20 Sep 2021 02:07:23 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:d1c6:92a1:8813:7c4f? ([2a00:23c5:5785:9a01:d1c6:92a1:8813:7c4f]) by smtp.gmail.com with ESMTPSA id m2sm18420353wmm.3.2021.09.20.02.07.22 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Sep 2021 02:07:22 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 4991b4f0-d65b-4c78-88fb-646bf56c26ad DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YRDnom0RbzQKydS7V8PtZPN/AQrZUMeDQicEd3g4TSA=; b=TK6BmGZocKOlZPYKPlo0bT4kJBcNKfn6wg0WjKoxiGR+geVo4HpiHS8CHrjwzl328s EKlKHcMeH3HghChdIWw22sBNltlcWkpuRtjmeVtpUYU0u4AlxUkWqf+xFPf/q7i2Tt2f h5F6UMx3CF1Zp9y1pJh0GUD5B+jaQInXCJg9aZryvZguJt8NcIYD4JhPWBULTLNKNCGJ Qksl6QcvLtKfufH1Lkv9ndOYmlVb2MRU0JLuRinAofpczee2padFDmxE77aibaS25xbe FH2XY+QlEcxXR+0uL6kwMlcdhEdMrEPukpz+goiV6Xk9ZeYk/qvAAsoPpdxCr8MXNznO u+5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YRDnom0RbzQKydS7V8PtZPN/AQrZUMeDQicEd3g4TSA=; b=1o70yrWn2UzSk/B3AtSKvYHfVPopJYIKCnrg38FiJFByltS/CMAuV4uQqHD/zgLXSW REe5HH1IWssk/CoaGdACLwyS/ARNmgaojTF5iOPx0taQXuSV6VJwmkpadNSxEm+lYdcY IPUsLNVsfQOUDc18QidzmVpame62LsLNRGLMf0CPt7+HTtkTo0GhusITfu0iJulUWMna JPV3BmQIyXu24fpI/dQisvEi9h5ahgEXUdUosUSPUfeaIZ5bWiV33dNTgzs2l7i3ZDYS fnj1aA4sXvdCqGe2lrzC5MAHVjohYzvyKyj281nd/DAq/AL+usMh8evJK1mWxYaJhE7o mlrw== X-Gm-Message-State: AOAM5305A/Oa5GAbJExYBxcBW8qpj/itsfqwYQRXEmTnK/uEhbaHGSAX uBoMce3O8fd5gxulPcBPbRySy6AOwlQ= X-Google-Smtp-Source: ABdhPJw70KQKODSk4R23xIJ2BuXrVzSSY1uFcJyilU1Ta1bPKy0NdFNv6a0aTFOuXZqmmq0Acm8ovw== X-Received: by 2002:a05:600c:201:: with SMTP id 1mr1625379wmi.5.1632128842709; Mon, 20 Sep 2021 02:07:22 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 2/3] Fix SDV/CodeQL log generation To: win-pv-devel@lists.xenproject.org References: <20210812123349.1698-1-owen.smith@citrix.com> <20210812123349.1698-2-owen.smith@citrix.com> Message-ID: Date: Mon, 20 Sep 2021 10:07:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210812123349.1698-2-owen.smith@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/08/2021 13:33, Owen Smith wrote: > - sarif files need to be stored with SDV logs when generating the DVL file > - Disable PREFast and CodeAnalysis by default > - Run a seperate CodeAnalysis build after SDV, but before generating DVL file > DVL file should contain multiple summary lines for SDV, at least 1 line > for CodeAnalysis and at least 1 line for Semmle (CodeQL) > > Signed-off-by: Owen Smith Acked-by: Paul Durrant From win-pv-devel-bounces@lists.xenproject.org Mon Sep 20 09:07:49 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 20 Sep 2021 09:07:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.190394.340228 (Exim 4.92) (envelope-from ) id 1mSFHB-0003Mk-Ej; Mon, 20 Sep 2021 09:07:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 190394.340228; Mon, 20 Sep 2021 09:07:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSFHB-0003Mc-BO; Mon, 20 Sep 2021 09:07:49 +0000 Received: by outflank-mailman (input) for mailman id 190394; Mon, 20 Sep 2021 09:07:47 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSFH9-0003ME-IM for win-pv-devel@lists.xenproject.org; Mon, 20 Sep 2021 09:07:47 +0000 Received: from mail-wr1-x42f.google.com (unknown [2a00:1450:4864:20::42f]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 138bc740-1189-478a-8bcf-4fa20df92860; Mon, 20 Sep 2021 09:07:46 +0000 (UTC) Received: by mail-wr1-x42f.google.com with SMTP id d21so27527184wra.12 for ; Mon, 20 Sep 2021 02:07:46 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:d1c6:92a1:8813:7c4f? ([2a00:23c5:5785:9a01:d1c6:92a1:8813:7c4f]) by smtp.gmail.com with ESMTPSA id 14sm3181898wmb.29.2021.09.20.02.07.45 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Sep 2021 02:07:45 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 138bc740-1189-478a-8bcf-4fa20df92860 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=O8+Ge5qRTo/SyAkEF6mVArzSe3tB13TRpVTIhA3+mP0=; b=JhFgk42PdWJft7DUUyNWYLH1CPBapnty8Imsf0brTCpQihlzVki+HD0GsWT3KkO7j7 R/BkVxI2nF4suv4InlrLyCaFat8A6UV3cdhr7IES9+rjqgaPNvpXDE59+gS/0BND2eVR 1h1rzuTzrM9+FekYOadwVLcojCkR+5ARwrIu4Bz9NCdcuDfUE9T2FqYotrDjscyYKCpe vGE5MaXEGFaeCpPcY58QdQ7za0Rm8vDP0PU9NGIXdhqHwbBqNIjn1Z5cEu4fOOSSHlRv 2SquXZ3R0/g83S2r0Ma8YR0pyzwlwUlv0KLIYXVs3J+xiqATTzKx4pG20JL0t2YBEQv7 DzCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=O8+Ge5qRTo/SyAkEF6mVArzSe3tB13TRpVTIhA3+mP0=; b=1Watx0hWG0MqhDp4Kg3HJIVxseUFTZh9fADxpqv6f7gTDLMoBcMmISE+6PsxVeCOOX kZ4PwUVCwx+1ofGoUBa9FXM2mt5oSmU8wGjmWuLFKmd3b/59zmMMCgKxSTeG1ZGghLcM uq3xRCn0k8seW5wPqdBcBBKI3uSi3alGNEn3+Ry6xiZpsDOZW6alyKXikR8TSz4Mvq0o QOLaJsh8klhZ6Ob4juhIG464Wa5JgkqM4MX+Rc6biiunymxvOzDOzNUjVwzwC7vQ/FrI 31e+cVrx13UIsQgTYLiurb3PHvyAIt0L3cn2i9y1vmgl33Bo1EghxRj5Y2jmh3chrBEE IrFA== X-Gm-Message-State: AOAM533lX/jNi4I03VkzVo3/e3Gsegs7BLHAzpRU3YA5h3al5Ol0JgRG eRIF/63dIeaCqMgvc3g89rFdrfZndU0= X-Google-Smtp-Source: ABdhPJydz3oq9cs+WeOl+RNqxo39A789sgALDN8huWxEdygtweug3x9OauTQBDye7JhNk+LLErnVQg== X-Received: by 2002:a05:6000:181:: with SMTP id p1mr27866681wrx.247.1632128865814; Mon, 20 Sep 2021 02:07:45 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 3/3] Fix CodeQL warnings To: win-pv-devel@lists.xenproject.org References: <20210812123349.1698-1-owen.smith@citrix.com> <20210812123349.1698-3-owen.smith@citrix.com> Message-ID: Date: Mon, 20 Sep 2021 10:07:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210812123349.1698-3-owen.smith@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/08/2021 13:33, Owen Smith wrote: > - ExAllocatePoolWithTag is deprecated in Win10 2004, use > ExAllocatePoolUninitialized instead > > Signed-off-by: Owen Smith Acked-by: Paul Durrant From win-pv-devel-bounces@lists.xenproject.org Mon Sep 20 09:14:15 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 20 Sep 2021 09:14:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.190420.340242 (Exim 4.92) (envelope-from ) id 1mSFNO-0004wq-CV; Mon, 20 Sep 2021 09:14:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 190420.340242; Mon, 20 Sep 2021 09:14:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSFNO-0004wj-9g; Mon, 20 Sep 2021 09:14:14 +0000 Received: by outflank-mailman (input) for mailman id 190420; Mon, 20 Sep 2021 09:14:13 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSFNN-0004wb-Ir for win-pv-devel@lists.xenproject.org; Mon, 20 Sep 2021 09:14:13 +0000 Received: from mail-wr1-x42f.google.com (unknown [2a00:1450:4864:20::42f]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 07954ebe-a18c-4f1c-9090-1768a877ec29; Mon, 20 Sep 2021 09:14:12 +0000 (UTC) Received: by mail-wr1-x42f.google.com with SMTP id u18so25857134wrg.5 for ; Mon, 20 Sep 2021 02:14:12 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:d1c6:92a1:8813:7c4f? ([2a00:23c5:5785:9a01:d1c6:92a1:8813:7c4f]) by smtp.gmail.com with ESMTPSA id o7sm18966658wro.45.2021.09.20.02.14.11 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Sep 2021 02:14:11 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 07954ebe-a18c-4f1c-9090-1768a877ec29 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8s4NvUkpdgtZc61DwzjSpSm8W31+VW3xdQXqtO9mUXc=; b=KbnbRwsrEUPkI0eBc9sDcrOBg7JIyyzJuxEdw7aYuPeu4RfnY6NUAOqUPOM9eCBd28 uWG1fqni4e4qgyqjpRNLyk4F/JUCkn6yk8x2uebname2NeL5zSXTuyq/r+70P4PMVh3a WkJXLl43ZQvMyjlM1mBjrvKDJc7jtibXQuO4UMyb1lGLFekV5N3kgvMW9Q6sbJefGKl+ 7r6BLq6RB7KdePJ0weXttv3n9PKffM+FzfAaqijI/rdBGKb6ZN525dxMG7yxy44ve4eA i0lNM85aKpEhYeiIcJIcvfCUwAawipLTKZbYB1q2lVIcoXqVXBdI2vte01BzJoIbyI6y IFHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8s4NvUkpdgtZc61DwzjSpSm8W31+VW3xdQXqtO9mUXc=; b=d1uNbJlmOyLsi3kTUXop2pnw4sFUrHjgkjYaeM72Inq8p8sBh/6ngdLAxsnScJ8wTp +t2kvWveFOxdEF3KNoFTuomAAQvTgOYC/DJ1KXRL4PeylqhtBu80VAqWCpb1b304Paxj AkUaH9CsnrVzknwsUfRCB87mIwYYnpxgt/5rrxfLwImJdUDEAd1SxI3qg1EhPtuT3v1X hWFQF32t3s2owIXgc/Uvg6n8VfQ8d9/wM9X9KNZUgJsOoZaMxmEW0ZOndqf4wyPeS43I FcpTUOKa/cNOoOKJvL6WC6FiwcSiCMIWB0yYnzWNAZcG3Oj2fJ2qIhdyzO1U69NBY9kf nJfw== X-Gm-Message-State: AOAM531fSni8HbBFdcqqy1jBML0jeacFue+srZ4gwr6/r1cnp9BrWina zK90Q2derUoJo37wLTj7dKbwn8LZb9Y= X-Google-Smtp-Source: ABdhPJzXHUjyvEFY4r4T8UHG55su+AKcZaH8YSNIyctnEsbKd8DEQKL1VMbaz3JPNfvsC0ggnGdErw== X-Received: by 2002:adf:f612:: with SMTP id t18mr27360207wrp.16.1632129252180; Mon, 20 Sep 2021 02:14:12 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 2/3] Fix SDV/CodeQL log generation To: win-pv-devel@lists.xenproject.org References: <20210812123907.2005-1-owen.smith@citrix.com> <20210812123907.2005-2-owen.smith@citrix.com> Message-ID: Date: Mon, 20 Sep 2021 10:14:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210812123907.2005-2-owen.smith@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/08/2021 13:39, Owen Smith wrote: > - sarif files need to be stored with SDV logs when generating the DVL file > - Disable PREFast and CodeAnalysis by default > - Run a seperate CodeAnalysis build after SDV, but before generating DVL file > DVL file should contain multiple summary lines for SDV, at least 1 line > for CodeAnalysis and at least 1 line for Semmle (CodeQL) > > Signed-off-by: Owen Smith Acked-by: Paul Durrant From win-pv-devel-bounces@lists.xenproject.org Mon Sep 20 09:14:42 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 20 Sep 2021 09:14:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.190425.340246 (Exim 4.92) (envelope-from ) id 1mSFNq-000515-Ev; Mon, 20 Sep 2021 09:14:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 190425.340246; Mon, 20 Sep 2021 09:14:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSFNq-00050y-C9; Mon, 20 Sep 2021 09:14:42 +0000 Received: by outflank-mailman (input) for mailman id 190425; Mon, 20 Sep 2021 09:14:41 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSFNp-00050q-2k for win-pv-devel@lists.xenproject.org; Mon, 20 Sep 2021 09:14:41 +0000 Received: from mail-wr1-x42e.google.com (unknown [2a00:1450:4864:20::42e]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d0d88346-3857-4d7c-8e6b-76666b91c70e; Mon, 20 Sep 2021 09:14:40 +0000 (UTC) Received: by mail-wr1-x42e.google.com with SMTP id t8so27593642wrq.4 for ; Mon, 20 Sep 2021 02:14:40 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:d1c6:92a1:8813:7c4f? ([2a00:23c5:5785:9a01:d1c6:92a1:8813:7c4f]) by smtp.gmail.com with ESMTPSA id z12sm15126599wro.75.2021.09.20.02.14.38 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Sep 2021 02:14:39 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: d0d88346-3857-4d7c-8e6b-76666b91c70e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YC5Jp4qEmymXy3jMqDPLEgWASlyHmBD6ZhJ248vuQFw=; b=lVdmyKOrgkKEG6NA+ZIKxt4Zx7+XFLLnaRtYV+OnvozmwwRwrHOujq+quW6uWbOlGV l1QCIbnijAPdUf4G8gwicmdwx/Zi6Slf/KSc2M5ThS294UEFv0jCj1ODUg4xj8OvxHZm 3Q2EodPoH8tlHvYeJguVrdq7Fzall6QLnTwEyT/j7vagGq2zJuB3SqVHL7KjLRzTfETP rZTFYbLTNtpJDARSy5C0zUAFNXrzJZClqws6rpsjy+FUi3PmwkC6zPTb5PhM9v6H6fZG OTtcF/WE1wqHmjjoJ6D/ttzfvpLnWAPu58c16NF1P5mnkl0ojxsaixX23ZEYofXhuh6U 7IOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YC5Jp4qEmymXy3jMqDPLEgWASlyHmBD6ZhJ248vuQFw=; b=rifuGG3Kc0j+dX+PANRRpL8WYMGKsKsX4SdTZLPeYS3RLMlicTeClSu1widapq61AH KzS0yTq5O+GlfntY6EYVhMj4z6CTIWS1ROkc7Fz/Fhni+NvuEJh4qqXcE9ZIRk+hoj1S leltpn6Kgzmjfd2n8z4XN2QUZge4rEKaKy91Sf2yWkV8cNrXCjQAAC8wM1m1E1a0FKYc 3TkPx920ILlaUPg9T8LHso+0TNLx6gpCzq1z1ppjkxzKvLR1I6XqVTau99mHEfOJ9HJW f/c/TV34fJYzGA9Of4aq+fce5EznvTGQcQzMNdK7i785awg7d5p96jiEauq+66jKyBlP fySw== X-Gm-Message-State: AOAM532ZM7ZfQVbHN8DiWxED+U2wxYEFknZbJoqsl3hua/rmtMRO5eSU z5nwEuZvjZjEMrR6mHgrUbuXc67jp5I= X-Google-Smtp-Source: ABdhPJyMVfrN+AbLm3ywKLV58ODPk6qUsB7SCS+7ucq90VzdvLupkkFjy3YIET+SFli1Jlfpds+XBw== X-Received: by 2002:a5d:49ce:: with SMTP id t14mr26828202wrs.183.1632129279456; Mon, 20 Sep 2021 02:14:39 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 3/3] Fix CodeQL warnings To: win-pv-devel@lists.xenproject.org References: <20210812123907.2005-1-owen.smith@citrix.com> <20210812123907.2005-3-owen.smith@citrix.com> Message-ID: <2c2d9cf8-e9b6-e9ed-fa04-12921a1e514f@xen.org> Date: Mon, 20 Sep 2021 10:14:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210812123907.2005-3-owen.smith@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/08/2021 13:39, Owen Smith wrote: > - ExAllocatePoolWithTag is deprecated in Win10 2004, use > ExAllocatePoolUninitialized instead > - QueryCapabilities structure contains padding bytes, using > __AllocatePoolWithTag zeros this memory > > Signed-off-by: Owen Smith Acked-by: Paul Durrant From win-pv-devel-bounces@lists.xenproject.org Mon Sep 20 09:33:42 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 20 Sep 2021 09:33:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.190466.340297 (Exim 4.92) (envelope-from ) id 1mSFgC-0000zv-TS; Mon, 20 Sep 2021 09:33:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 190466.340297; Mon, 20 Sep 2021 09:33:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSFgC-0000zo-Qa; Mon, 20 Sep 2021 09:33:40 +0000 Received: by outflank-mailman (input) for mailman id 190466; Mon, 20 Sep 2021 09:33:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSFgC-0000zi-HB for win-pv-devel@lists.xenproject.org; Mon, 20 Sep 2021 09:33:40 +0000 Received: from mail-wm1-x329.google.com (unknown [2a00:1450:4864:20::329]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ee3e6841-a3c4-4e63-9de0-1c3a2c13e044; Mon, 20 Sep 2021 09:33:39 +0000 (UTC) Received: by mail-wm1-x329.google.com with SMTP id g19-20020a1c9d13000000b003075062d4daso11617217wme.0 for ; Mon, 20 Sep 2021 02:33:39 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:d1c6:92a1:8813:7c4f? ([2a00:23c5:5785:9a01:d1c6:92a1:8813:7c4f]) by smtp.gmail.com with ESMTPSA id q201sm20792811wme.2.2021.09.20.02.33.38 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Sep 2021 02:33:38 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: ee3e6841-a3c4-4e63-9de0-1c3a2c13e044 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=e5dcdtGxNIMtfQHn9DQ9hBCwgEJhHfMateDkjHeXbDw=; b=F54teZ6OsDMCH25BECv7tYOrsaqhdPjLIf0K6S4s2U6ACkZG8CfTzGzEUgYVWDk3LG jKrDtpkWm4PvznSUOEb42oUsZC3TrzD6CxoC2wiWolyLJeOlEBdNQm2bN6D3D72iK9oR Pf7aDGl3PzIjjNjZVg9xfFgiYmdS4zgvmv05K/buDihp/kEkvm6r0dvycgGUs9IgDVCg wtPASIwm3XOx8VAoGAZcIL9EhW8OaEYb0Nw/AY5XHWhmWq71+I/24anY+5AEwPLEwO6e epo2Juhhj05FvjWO5+75dpVPLPLNM3XOiNGtfxywKqyVJG9CMPPwOET23sQ+sTc8ljp3 RDYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=e5dcdtGxNIMtfQHn9DQ9hBCwgEJhHfMateDkjHeXbDw=; b=u1vHONHBHFo1s24gzHbwWVGsIUfZSUh5/vv/IXP8ItJejTAmht3UL7Vx8FJEAYTPs0 SXJhMfvkLKZnFw4mhOMBthRqzLB2Zt4fiB5d9mw1Du63Bapqd5BXSZfkBhMmdCWdzneX HvnE9YOZVbM0fGFRY1VMwlgzWQdH62iXjZVg1qW/Roca2uw428Q8sq+TnPWCQ2bydyvX 3luq2uYzz1K3w587XwZFIQIyntdT18YePJthWrEWVP9xCi8upJATbF182XTZ5+2t1oPo 40YM/oPDDGzbfDJ05DSIUV4oSB5xDLdTIjSlNCavtXS/W8lQ+vogDSkRa6BVrL98nB05 MzEw== X-Gm-Message-State: AOAM531EYrAehW5y9Hq2zAz/zIdIkYoSQoCDZi4w3+CR2xj7XiQzlKTa Dov8cHbLGYxAlqEhLg27NwAW1B2x/lc= X-Google-Smtp-Source: ABdhPJwLAbWCUon8ssZNFTnAZw5RvWY2VEtrgQFh4SAsOqGGaBZjxTcLYiELSLhTkRhU7e72ic8r3w== X-Received: by 2002:a1c:488:: with SMTP id 130mr23088785wme.156.1632130418981; Mon, 20 Sep 2021 02:33:38 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 2/4] Fix SDV/CodeQL log generation To: win-pv-devel@lists.xenproject.org References: <20210812124138.1533-1-owen.smith@citrix.com> <20210812124138.1533-2-owen.smith@citrix.com> Message-ID: <7ed52fab-106f-1857-de8b-cfeb3d9a3352@xen.org> Date: Mon, 20 Sep 2021 10:33:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210812124138.1533-2-owen.smith@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/08/2021 13:41, Owen Smith wrote: > - sarif files need to be stored with SDV logs when generating the DVL file > - Disable PREFast and CodeAnalysis by default > - Run a seperate CodeAnalysis build after SDV, but before generating DVL file > DVL file should contain multiple summary lines for SDV, at least 1 line > for CodeAnalysis and at least 1 line for Semmle (CodeQL) > > Signed-off-by: Owen Smith Acked-by: Paul Durrant From win-pv-devel-bounces@lists.xenproject.org Mon Sep 20 09:34:51 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 20 Sep 2021 09:34:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.190473.340302 (Exim 4.92) (envelope-from ) id 1mSFhL-000175-1A; Mon, 20 Sep 2021 09:34:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 190473.340302; Mon, 20 Sep 2021 09:34:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSFhK-00016y-Ub; Mon, 20 Sep 2021 09:34:50 +0000 Received: by outflank-mailman (input) for mailman id 190473; Mon, 20 Sep 2021 09:34:50 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSFhK-00016q-84 for win-pv-devel@lists.xenproject.org; Mon, 20 Sep 2021 09:34:50 +0000 Received: from mail-wr1-x42a.google.com (unknown [2a00:1450:4864:20::42a]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 92b4941d-66e3-4730-97f0-a971cbb73649; Mon, 20 Sep 2021 09:34:49 +0000 (UTC) Received: by mail-wr1-x42a.google.com with SMTP id q26so27696152wrc.7 for ; Mon, 20 Sep 2021 02:34:49 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:d1c6:92a1:8813:7c4f? ([2a00:23c5:5785:9a01:d1c6:92a1:8813:7c4f]) by smtp.gmail.com with ESMTPSA id o3sm2164652wra.52.2021.09.20.02.34.48 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Sep 2021 02:34:48 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 92b4941d-66e3-4730-97f0-a971cbb73649 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=JPrXufa5XI5JiXhehIW36VmQ6lIor3XZa4XqB2f0rto=; b=BAphrAN8BCYrKHb1BUUqXUJErTqwkNWsTdohyoDhstEeZYh2L/qRSN/QiUEirn/Xol tzrX2ho6T50IGHpYKFYNJU2rGDQIW2uApoK7dZFDQEr+Bbo2K6JlnbJCqsiTI6noQGcO qqOpMthzhUxFLmG6k1pCBwfLIS2Ca6hZ/wHCPXiTQHkNPzHIHvJpTlGGZKIXcdJExt63 v6/SAP4xpv+AmLSVCK13GvH1/54nrq2ThWXJvtaiv/bc/V7YP+7Xjw6J18sNOZ5r7ZRo RAe8TO/DhgTpEf8QHOEbCF7wcANfFSCTVduZuDB864lkmBxVQddTR5yuh+mQ1W0R2tIf eNpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JPrXufa5XI5JiXhehIW36VmQ6lIor3XZa4XqB2f0rto=; b=iKfSPyx/WfLcYSCc6kVa1z2CZ+uuTCtEqDD8IHYMMIOg1bPt8q8ndTM4LgjBLK9nQO mfmpVblaQnqJU2ie/8tCjgNCobRAAOqGPZ84k/tfDyLUUau16EehoSIPG91AIz4uB9cs BW8HlIoNREiBgnAQWuwqR8ggGjE8Ke/smyKgN6zwEtVxt5OIl92R3FCUVDi+ZjAqQXcj bLcxVrnlKbaCJHwioMikQ8tlOF7Iwa9mH4/H+OxMcFgAhnn2B1q6+FqiBcu07WJw7VLu 3PTWp93iKlbXrj5ndv4EQsw+oeK+wr6hYWGvOfoDCaSIsd4c2Dps3QCVr5q6nEOQlUr9 r9Gg== X-Gm-Message-State: AOAM533QUtug3+D4AFhHUuwPkQwBuWYGTWDAqUiGosB5JZlSACUrzdRn CLqlFbCo1VvcexdDaC4AgepBIT6O6sU= X-Google-Smtp-Source: ABdhPJxwUe+aItZUcUdHl0ThaoyfMHNicsxT7YNBqzLw5EY1vqC4jbuwxJNF4cEtFBfWYUMMpWxVhA== X-Received: by 2002:a5d:56cf:: with SMTP id m15mr27235045wrw.240.1632130488572; Mon, 20 Sep 2021 02:34:48 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 3/4] Fix CodeQL warnings To: win-pv-devel@lists.xenproject.org References: <20210812124138.1533-1-owen.smith@citrix.com> <20210812124138.1533-3-owen.smith@citrix.com> Message-ID: <024cf0d3-1ffd-3693-8764-9ff8d6c43a3d@xen.org> Date: Mon, 20 Sep 2021 10:34:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210812124138.1533-3-owen.smith@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/08/2021 13:41, Owen Smith wrote: > - ExAllocatePoolWithTag is deprecated in Win10 2004, use > ExAllocatePoolUninitialized instead > > Signed-off-by: Owen Smith > --- > src/common/util.h | 4 ++++ > src/xenvbd/adapter.c | 12 ++++-------- > src/xenvbd/base64.c | 15 ++++----------- > 3 files changed, 12 insertions(+), 19 deletions(-) > > diff --git a/src/common/util.h b/src/common/util.h > index eddad4a..36a36dd 100644 > --- a/src/common/util.h > +++ b/src/common/util.h > @@ -151,8 +151,12 @@ __AllocatePoolWithTag( > __analysis_assume(PoolType == NonPagedPool || > PoolType == PagedPool); > > +#if (_MSC_VER >= 1928) // VS 16.9 (EWDK 20344 or later) > + Buffer = ExAllocatePoolUninitialized(PoolType, NumberOfBytes, Tag); > +#else > #pragma warning(suppress:28160) // annotation error > Buffer = ExAllocatePoolWithTag(PoolType, NumberOfBytes, Tag); > +#endif > if (Buffer == NULL) > return NULL; > > diff --git a/src/xenvbd/adapter.c b/src/xenvbd/adapter.c > index 9fd2abc..5b17a6b 100644 > --- a/src/xenvbd/adapter.c > +++ b/src/xenvbd/adapter.c > @@ -102,13 +102,9 @@ __AdapterAllocate( > IN ULONG Size > ) > { > - PVOID Buffer; > - Buffer = ExAllocatePoolWithTag(NonPagedPool, > - Size, > - ADAPTER_POOL_TAG); > - if (Buffer) > - RtlZeroMemory(Buffer, Size); We'll still need to zero the memory to maintain the semantics, right? I'll amend the patch accordingly. Paul > - return Buffer; > + return __AllocatePoolWithTag(NonPagedPool, > + Size, > + ADAPTER_POOL_TAG); > } > > static FORCEINLINE VOID > @@ -116,7 +112,7 @@ __AdapterFree( > IN PVOID Buffer > ) > { > - ExFreePoolWithTag(Buffer, ADAPTER_POOL_TAG); > + __FreePoolWithTag(Buffer, ADAPTER_POOL_TAG); > } > > static FORCEINLINE PANSI_STRING > diff --git a/src/xenvbd/base64.c b/src/xenvbd/base64.c > index 0e62784..223579a 100644 > --- a/src/xenvbd/base64.c > +++ b/src/xenvbd/base64.c > @@ -44,15 +44,9 @@ Base64Allocate( > IN ULONG Size > ) > { > - PVOID Buffer; > - > - Buffer = ExAllocatePoolWithTag(NonPagedPool, > - Size, > - BASE64_POOL_TAG); > - if (Buffer) > - RtlZeroMemory(Buffer, Size); > - > - return Buffer; > + return __AllocatePoolWithTag(NonPagedPool, > + Size, > + BASE64_POOL_TAG); > } > > VOID > @@ -60,8 +54,7 @@ Base64Free( > IN PVOID Buffer > ) > { > - if (Buffer) > - ExFreePoolWithTag(Buffer, BASE64_POOL_TAG); > + __FreePoolWithTag(Buffer, BASE64_POOL_TAG); > } > > static FORCEINLINE UCHAR > From win-pv-devel-bounces@lists.xenproject.org Mon Sep 20 09:37:04 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 20 Sep 2021 09:37:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.190480.340305 (Exim 4.92) (envelope-from ) id 1mSFjU-0001Df-7h; Mon, 20 Sep 2021 09:37:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 190480.340305; Mon, 20 Sep 2021 09:37:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSFjU-0001DY-4q; Mon, 20 Sep 2021 09:37:04 +0000 Received: by outflank-mailman (input) for mailman id 190480; Mon, 20 Sep 2021 09:37:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSFjT-0001DS-Ot for win-pv-devel@lists.xenproject.org; Mon, 20 Sep 2021 09:37:03 +0000 Received: from mail-wr1-x434.google.com (unknown [2a00:1450:4864:20::434]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1d07e80b-c750-4b46-9e21-07041be77133; Mon, 20 Sep 2021 09:37:02 +0000 (UTC) Received: by mail-wr1-x434.google.com with SMTP id i23so27761987wrb.2 for ; Mon, 20 Sep 2021 02:37:02 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:d1c6:92a1:8813:7c4f? ([2a00:23c5:5785:9a01:d1c6:92a1:8813:7c4f]) by smtp.gmail.com with ESMTPSA id t126sm18420177wma.4.2021.09.20.02.37.01 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Sep 2021 02:37:01 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 1d07e80b-c750-4b46-9e21-07041be77133 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+vK30QHBFFQ7zdmEer5RywO74zUEOmgJ/DFTZ68z8vs=; b=IKmaNrqWKd1ajEmU1LiBd0/WLPqXWCYMPnPp4g7uETlFp3+J1xDOp6Br1DZq0KWmzg J8pB3/bTDn3ZqKtcgzC6uqBhr8JdXmSAbI/W3osCudzdMrIXG5diEbd+1J4nMXMC/e28 WvVKY2Su8NlEv9Fc77MnU8HsBLn6KlRJqoQObOl7aNds9zLeu+x/PGT0h8Cm1ysHeLvv 6jp07IW8BltFv9Xalc6eNVFWS4Rg37OxihjxvQp6TG6VaHpuiTN0S+YZWcoJHqK+oiKo jF8pB+nZwHmI5bAcr91UYdcikX2wv4ODin7pr1cST3NeSYuGw+Q1Jopbs88AIAsRng/a l7gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+vK30QHBFFQ7zdmEer5RywO74zUEOmgJ/DFTZ68z8vs=; b=o3emD5CiQDE1F5wBdyCyrPBOmNdVdpHNA37SNiESO1vpyL3p5GEX4/e8bUxCLN+br+ e23i3/kjbiLKMKNA9AWhYd4MkOP9nRmh7Zdmg5Dd936JMYiQXuCRxskTygO7Vwx8vJJj ph3u4hD3tpjhrWdSsv/oEFTdVfmiLYyZOtlRqwtdMJFrHB3HTBE6TuP/EDKfVVEfdw4v NYHJFQRtuhH3ozMvxN6Rt/PYElHGN5cjP6IwlpRiJgqWzsfgWqecK2kAcrgJO52+eKsA wLE9jmtZtKwyoLCA/5IFUIl/Z04uzmYvqeIr5zr0AGt+0Z9KtzkHoGpM4qpotjROmIFQ g1Rg== X-Gm-Message-State: AOAM531ajHivcyzuY2rqZGTpv9Ii5GFB4LPJgKiOBgecfmQZfwYMwRDb m+g8JW6QRiYbwS1s2X71axe0A9lgPqk= X-Google-Smtp-Source: ABdhPJz6j69to8sw1E5L+HM59+QZlto9U55atfSoo0Fdvppc/UhJAZNm72e69vmkvr+msK0wKBAKDg== X-Received: by 2002:a1c:4645:: with SMTP id t66mr23534044wma.130.1632130622126; Mon, 20 Sep 2021 02:37:02 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 3/4] Fix CodeQL warnings To: win-pv-devel@lists.xenproject.org References: <20210812124138.1533-1-owen.smith@citrix.com> <20210812124138.1533-3-owen.smith@citrix.com> <024cf0d3-1ffd-3693-8764-9ff8d6c43a3d@xen.org> Message-ID: Date: Mon, 20 Sep 2021 10:37:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <024cf0d3-1ffd-3693-8764-9ff8d6c43a3d@xen.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 20/09/2021 10:34, Paul Durrant wrote: > On 12/08/2021 13:41, Owen Smith wrote: >> - ExAllocatePoolWithTag is deprecated in Win10 2004, use >>      ExAllocatePoolUninitialized instead >> >> Signed-off-by: Owen Smith >> --- >>   src/common/util.h    |  4 ++++ >>   src/xenvbd/adapter.c | 12 ++++-------- >>   src/xenvbd/base64.c  | 15 ++++----------- >>   3 files changed, 12 insertions(+), 19 deletions(-) >> >> diff --git a/src/common/util.h b/src/common/util.h >> index eddad4a..36a36dd 100644 >> --- a/src/common/util.h >> +++ b/src/common/util.h >> @@ -151,8 +151,12 @@ __AllocatePoolWithTag( >>       __analysis_assume(PoolType == NonPagedPool || >>                         PoolType == PagedPool); >> +#if (_MSC_VER >= 1928) // VS 16.9 (EWDK 20344 or later) >> +    Buffer = ExAllocatePoolUninitialized(PoolType, NumberOfBytes, Tag); >> +#else >>   #pragma warning(suppress:28160) // annotation error >>       Buffer = ExAllocatePoolWithTag(PoolType, NumberOfBytes, Tag); >> +#endif >>       if (Buffer == NULL) >>           return NULL; >> diff --git a/src/xenvbd/adapter.c b/src/xenvbd/adapter.c >> index 9fd2abc..5b17a6b 100644 >> --- a/src/xenvbd/adapter.c >> +++ b/src/xenvbd/adapter.c >> @@ -102,13 +102,9 @@ __AdapterAllocate( >>       IN  ULONG   Size >>       ) >>   { >> -    PVOID       Buffer; >> -    Buffer = ExAllocatePoolWithTag(NonPagedPool, >> -                                   Size, >> -                                   ADAPTER_POOL_TAG); >> -    if (Buffer) >> -        RtlZeroMemory(Buffer, Size); > > We'll still need to zero the memory to maintain the semantics, right? > Oh, my mistake... it's already done. Acked-by: Paul Durrant From win-pv-devel-bounces@lists.xenproject.org Mon Sep 20 09:49:33 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 20 Sep 2021 09:49:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.190502.340321 (Exim 4.92) (envelope-from ) id 1mSFvZ-0002zL-7Z; Mon, 20 Sep 2021 09:49:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 190502.340321; Mon, 20 Sep 2021 09:49:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSFvZ-0002zD-4L; Mon, 20 Sep 2021 09:49:33 +0000 Received: by outflank-mailman (input) for mailman id 190502; Mon, 20 Sep 2021 09:49:32 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSFvY-0002z7-IT for win-pv-devel@lists.xenproject.org; Mon, 20 Sep 2021 09:49:32 +0000 Received: from mail-wr1-x42a.google.com (unknown [2a00:1450:4864:20::42a]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2dafc9f6-0d4f-4d17-b1bd-f6f11bda85bd; Mon, 20 Sep 2021 09:49:31 +0000 (UTC) Received: by mail-wr1-x42a.google.com with SMTP id w17so19645658wrv.10 for ; Mon, 20 Sep 2021 02:49:31 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:d1c6:92a1:8813:7c4f? ([2a00:23c5:5785:9a01:d1c6:92a1:8813:7c4f]) by smtp.gmail.com with ESMTPSA id j7sm19037205wrr.27.2021.09.20.02.49.30 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Sep 2021 02:49:30 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 2dafc9f6-0d4f-4d17-b1bd-f6f11bda85bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=iKBou8aErK915BchaZdYzvHDzp7/D/nkdLfMYWuR9vY=; b=MIMALOQa/2/y0PulQs/EI6RVtqHRFiLGoreLyk0p+vg8YyYhGZY5008DZIUoPajwyW gSNC61PRUKff06qK4WUdWBu0XoQIuPSTLygyeL3PH5oNwCWq6bXso83R5YD+OGCyvuPx cKFG8tePqPDT/ZfVeW9qglzPrB69IGfZJm9KGNSezmhuXUEjHzppKqWox22szRkR+TTB bMzX6SEi8ZvVAkOqwGZRkkpKXkRQG0bVaYMSzA78hkkfU3i3lLXhBjFJlO1JD6cvTJIs qFrn2KtLP5L8Oc4B+ZieqPUu8IAH2xVAvXVx8SB4njuYx9lbGdzxhFZ6MGPeOVBYdCP2 ohOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=iKBou8aErK915BchaZdYzvHDzp7/D/nkdLfMYWuR9vY=; b=cFPLRfHxkkxIJcotzEPy7+1gJjlaS8l6OijRWM6F9nEidKv8Le8mX27KzBCm5pcAF/ h6NFEqz/wz3pzvnmdzLA5CaEgM55H7QrMifVBRpkW0FZ0b6ER2I53C9ebyxnHj25NF0X sO6lH8062lA2vUVELfF/xjl+xp/w5JEq+O1O7RXG02X6WEE2se/+7EQTLzor2V46xGXj fqHzHN2/ZfiTEIoG1ZRmAMb3rJmTEAkLiF5SRvobolJVtMnxiP1XeZKHy7GSICIqH+Iy TBRLG1zpd7GQl9/LveXIGDwDXSn7o/nPEeVHGkBPAYCI8iXgsUl7SzyMwefu+OokRIAk Xc8A== X-Gm-Message-State: AOAM531oyHwEH6UCrmShPvKWnvTAPwJ6bGUUtc4jQLw/VeM/cIba0BPA 8xNpfT4/NdbdH5YGb4p5NyLAzWULNns= X-Google-Smtp-Source: ABdhPJwimkXLxLFrya4nxiqnJZuUTzJ+weO90SY3N7SClpdtvVorWHLECeERp4CZwER8LyLt8oZDsg== X-Received: by 2002:a7b:c74b:: with SMTP id w11mr8867441wmk.21.1632131371045; Mon, 20 Sep 2021 02:49:31 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 4/4] Page80/83 data is optional To: win-pv-devel@lists.xenproject.org References: <20210812124138.1533-1-owen.smith@citrix.com> <20210812124138.1533-4-owen.smith@citrix.com> Message-ID: Date: Mon, 20 Sep 2021 10:49:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210812124138.1533-4-owen.smith@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/08/2021 13:41, Owen Smith wrote: > Check for non-NULL before attempting to free SCSI override data. > > Signed-off-by: Owen Smith Acked-by: Paul Durrant From win-pv-devel-bounces@lists.xenproject.org Mon Sep 20 09:57:35 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 20 Sep 2021 09:57:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.190513.340325 (Exim 4.92) (envelope-from ) id 1mSG3J-0003y3-SI; Mon, 20 Sep 2021 09:57:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 190513.340325; Mon, 20 Sep 2021 09:57:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSG3J-0003xw-P8; Mon, 20 Sep 2021 09:57:33 +0000 Received: by outflank-mailman (input) for mailman id 190513; Mon, 20 Sep 2021 09:57:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSG3I-0003xq-Te for win-pv-devel@lists.xenproject.org; Mon, 20 Sep 2021 09:57:32 +0000 Received: from mail-wr1-x42c.google.com (unknown [2a00:1450:4864:20::42c]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ab51c0d8-3874-4f68-9419-f901293abec3; Mon, 20 Sep 2021 09:57:32 +0000 (UTC) Received: by mail-wr1-x42c.google.com with SMTP id t8so27870996wrq.4 for ; Mon, 20 Sep 2021 02:57:31 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:d1c6:92a1:8813:7c4f? ([2a00:23c5:5785:9a01:d1c6:92a1:8813:7c4f]) by smtp.gmail.com with ESMTPSA id n68sm19266845wmn.13.2021.09.20.02.57.30 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Sep 2021 02:57:30 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: ab51c0d8-3874-4f68-9419-f901293abec3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=NoabkSiFtodLs454Tn1GV1pM+PzFBV4qu08+k/czydE=; b=lfNSD55O0/UYNGxom3aV4WUfbrcgf5SCt85EYyPsWzirQp5d3Ck0GkVUbm/nxinQ6y MEmCMuUqe9GvkgirgltzOupIPQeEOCk5nc9GWXuSAGyFKexRaicDF4a/A1o5xrQrw8Ae N84o8E9vtKmpDEiKl1ZUTmvi6D+xcNK7fNr7jRfm0VLDWnrjqZqlgnkNu47vEDqUlmNK 26xDZwdeSvA6syM5MBlA+JghIo2VuuRRpqCAi3J4js+WD4HLOSgTS04odDwOdc0vQMx+ bnCYeOhnJP9xLDCOjfMZ2nTV+LLVSgzCdnBVO31e1YBUr8W9G84H6tnkJvAxzBBEnoVS +Yfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NoabkSiFtodLs454Tn1GV1pM+PzFBV4qu08+k/czydE=; b=8CdElsaoF7Z/jznhlAkC4ypVLW3pdWfmbvTOUocOwmqsY/yNC6gOh82Y99JlX2ZKKk acjN2j1WM522ST7X6uR4ntZAcVPDVyAoYFeyYZMetzrm6YARj13jrwfG+sbCmfp9lMu7 6dkWMe0Xn92sxHLZ0LSVTVyxJtJS1K3Tlf+9TR+rlnl6E/uPUKsxKuwsunuKeINr3HqS gY0mbGfU9WpS8VLhQerCMo3e5ifIv4ZPHvfQX4FqKDaIf2RnFf0YCOTsU/4MYepI3GwJ ILYmnHJhLMWnELSyip6K2JjN3bNLwF/9+BJgAAgSnjSG38NVwO0aI20htkCNzxcJHMqy KqGQ== X-Gm-Message-State: AOAM531ZncPD8nXbZFYA/bgW1Zw/eKWEakhHI8ZlaTcVSlKYeJWfY5vY MLDq8XFG9PHjDggF+MylJ5axi3pacWM= X-Google-Smtp-Source: ABdhPJw5njSalpRh8/ldguTuDT78vWwP3k+lfO13AN0vLljarnZRsgji1i1BZbUEFrZMz1jnp1aeyQ== X-Received: by 2002:a05:6000:1569:: with SMTP id 9mr25443255wrz.337.1632131851206; Mon, 20 Sep 2021 02:57:31 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 2/3] Fix SDV/CodeQL log generation To: win-pv-devel@lists.xenproject.org References: <20210812124427.1736-1-owen.smith@citrix.com> <20210812124427.1736-2-owen.smith@citrix.com> Message-ID: <5d8b4ac8-6bb7-4e23-ded7-7cce1b3b3956@xen.org> Date: Mon, 20 Sep 2021 10:57:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210812124427.1736-2-owen.smith@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/08/2021 13:44, Owen Smith wrote: > - sarif files need to be stored with SDV logs when generating the DVL file > - Disable PREFast and CodeAnalysis by default > - Run a seperate CodeAnalysis build after SDV, but before generating DVL file > DVL file should contain multiple summary lines for SDV, at least 1 line > for CodeAnalysis and at least 1 line for Semmle (CodeQL) > > Signed-off-by: Owen Smith Acked-by: Paul Durrant From win-pv-devel-bounces@lists.xenproject.org Mon Sep 20 09:58:09 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 20 Sep 2021 09:58:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.190518.340329 (Exim 4.92) (envelope-from ) id 1mSG3s-00042R-Uf; Mon, 20 Sep 2021 09:58:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 190518.340329; Mon, 20 Sep 2021 09:58:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSG3s-00042K-Rn; Mon, 20 Sep 2021 09:58:08 +0000 Received: by outflank-mailman (input) for mailman id 190518; Mon, 20 Sep 2021 09:58:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSG3s-00042E-2W for win-pv-devel@lists.xenproject.org; Mon, 20 Sep 2021 09:58:08 +0000 Received: from mail-wr1-x42e.google.com (unknown [2a00:1450:4864:20::42e]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2927df2d-d6ca-4251-a8b2-2b45f6e9c02f; Mon, 20 Sep 2021 09:58:07 +0000 (UTC) Received: by mail-wr1-x42e.google.com with SMTP id x6so27829677wrv.13 for ; Mon, 20 Sep 2021 02:58:07 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:d1c6:92a1:8813:7c4f? ([2a00:23c5:5785:9a01:d1c6:92a1:8813:7c4f]) by smtp.gmail.com with ESMTPSA id f1sm15582062wri.43.2021.09.20.02.58.06 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Sep 2021 02:58:06 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 2927df2d-d6ca-4251-a8b2-2b45f6e9c02f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Z79I2EV8RCITTypNSV5YxfqtbeNoME3E80qksMyDeIM=; b=Pixn2s96/i0BZ5bW1nDF1Ax/FCcUmYH0xxfMq95BnYJ672io7pQlhr5gCvwxFzvoaI Ot1mPwebY7u/vthSGtAyCBb1cq7p6WBaLWhiuK0/Bq0W7TEDW3MPoy7nbuda5r85Axbn /5rweiMW4Oyy4w36Dc3Cz9JX/sa5sdqJqhMu+L4iVtFl9l9Cm02X6XptPXw6dN8pR8pJ aYbRV5v+PrJMPqM/wKErAYAbfuQVW2svKWZnMG5/II64o/A5WY6sS9xfeyeKus7WKPBn FbxmZuXIwYA1Hb/KzzHlX40JPrwsGi/hrUtdcq/KAdX8bqP4E6YAVzOOYFxSdrpglrdI QabA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Z79I2EV8RCITTypNSV5YxfqtbeNoME3E80qksMyDeIM=; b=5+NxuCVQKYPTc+ghoX6reNQX+u67vzqyscqQk93SHbvBvyIpc+hbxHQqNj+XTMoG8d gwRID2oqTaCcsGwnN97JLZML7lxj/UD49IDj4cpGt1JHBFe0HyQjKRHZKZzLCdPp4bQo 2Uy4R3ryPVumcWXzdws1van6NYXWRTyXFzZshN2TVG8Ipbfx4NLPHXMqinQwYKjDGYav C1/G2AbYipyKQEW3cHk5c4MwawpCTO690C8uEI1Cmtf3V8kNKW2LyNriBNxpyIytQmz2 h8UvarIYTDZvQT3ltmIPhpzP7gprWSgpXUY9SswvAb0XLRQbFoRIWOpWinxQtkMJSZPI vo1w== X-Gm-Message-State: AOAM531VNkpvoHao9Stvmwe2Gs86fv4JWK8nTowBkb4NjOs8DJCDl2Sw ZB/zllj2y5vfNsZX74tBU7AuDWIKqH4= X-Google-Smtp-Source: ABdhPJwC1JMbzlMXhnpl74qMOTKmOFdN1E2EOshWqOGfnpwo8AWXRz3wQIGz9wn3MIYxSok4HvRyHQ== X-Received: by 2002:adf:fcca:: with SMTP id f10mr27506350wrs.304.1632131886532; Mon, 20 Sep 2021 02:58:06 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 3/3] Fix CodeQL warnings To: win-pv-devel@lists.xenproject.org References: <20210812124427.1736-1-owen.smith@citrix.com> <20210812124427.1736-3-owen.smith@citrix.com> Message-ID: Date: Mon, 20 Sep 2021 10:58:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210812124427.1736-3-owen.smith@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/08/2021 13:44, Owen Smith wrote: > - ExAllocatePoolWithTag has been deprecated with Win10 2004, use > ExAllocatePoolUninitialized instead > - Check return value of _strtoui64 for error condition as indicated by > _UI64_MAX > > Signed-off-by: Owen Smith Acked-by: Paul Durrant From win-pv-devel-bounces@lists.xenproject.org Mon Sep 20 10:18:42 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 20 Sep 2021 10:18:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.190538.340344 (Exim 4.92) (envelope-from ) id 1mSGNk-0006hf-Mp; Mon, 20 Sep 2021 10:18:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 190538.340344; Mon, 20 Sep 2021 10:18:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSGNk-0006hY-K9; Mon, 20 Sep 2021 10:18:40 +0000 Received: by outflank-mailman (input) for mailman id 190538; Mon, 20 Sep 2021 10:18:39 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSGNj-0006hS-Ed for win-pv-devel@lists.xenproject.org; Mon, 20 Sep 2021 10:18:39 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" Date: Mon, 20 Sep 2021 10:18:28 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <24507892.3.1632133108878.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> Subject: XENIFACE-master - Build #106 - Successful MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_2_17804171.1632133108815" X-Jenkins-Job: XENIFACE-master X-Jenkins-Result: SUCCESS ------=_Part_2_17804171.1632133108815 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #106. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENIFACE-master/106/console to view the results. ------=_Part_2_17804171.1632133108815-- From win-pv-devel-bounces@lists.xenproject.org Mon Sep 20 10:45:42 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 20 Sep 2021 10:45:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.190729.340505 (Exim 4.92) (envelope-from ) id 1mSGnr-0002ON-Fj; Mon, 20 Sep 2021 10:45:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 190729.340505; Mon, 20 Sep 2021 10:45:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSGnr-0002OF-Cy; Mon, 20 Sep 2021 10:45:39 +0000 Received: by outflank-mailman (input) for mailman id 190729; Mon, 20 Sep 2021 10:45:38 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSGnq-0002O9-4x for win-pv-devel@lists.xenproject.org; Mon, 20 Sep 2021 10:45:38 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" Date: Mon, 20 Sep 2021 10:45:27 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <14173043.5.1632134727598.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> Subject: XENCONS-master - Build #35 - Successful MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_4_17942680.1632134727488" X-Jenkins-Job: XENCONS-master X-Jenkins-Result: SUCCESS ------=_Part_4_17942680.1632134727488 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #35. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENCONS-master/35/console to view the results. ------=_Part_4_17942680.1632134727488-- From win-pv-devel-bounces@lists.xenproject.org Mon Sep 20 11:33:05 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 20 Sep 2021 11:33:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.190792.340587 (Exim 4.92) (envelope-from ) id 1mSHXk-0003D8-S9; Mon, 20 Sep 2021 11:33:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 190792.340587; Mon, 20 Sep 2021 11:33:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSHXk-0003D1-Ot; Mon, 20 Sep 2021 11:33:04 +0000 Received: by outflank-mailman (input) for mailman id 190792; Mon, 20 Sep 2021 11:33:03 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSHXj-0003Ct-Qp for win-pv-devel@lists.xenproject.org; Mon, 20 Sep 2021 11:33:03 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" Date: Mon, 20 Sep 2021 11:32:53 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <14413935.7.1632137573302.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> Subject: XENNET-master - Build #116 - Successful MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_6_15996439.1632137573240" X-Jenkins-Job: XENNET-master X-Jenkins-Result: SUCCESS ------=_Part_6_15996439.1632137573240 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #116. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENNET-master/116/console to view the results. ------=_Part_6_15996439.1632137573240-- From win-pv-devel-bounces@lists.xenproject.org Mon Sep 20 12:00:33 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 20 Sep 2021 12:00:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.190819.340612 (Exim 4.92) (envelope-from ) id 1mSHyJ-0007Um-Hl; Mon, 20 Sep 2021 12:00:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 190819.340612; Mon, 20 Sep 2021 12:00:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSHyJ-0007Uf-F6; Mon, 20 Sep 2021 12:00:31 +0000 Received: by outflank-mailman (input) for mailman id 190819; Mon, 20 Sep 2021 12:00:29 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSHyH-0007UZ-M5 for win-pv-devel@lists.xenproject.org; Mon, 20 Sep 2021 12:00:29 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" Date: Mon, 20 Sep 2021 12:00:18 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <5527624.9.1632139219162.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> Subject: XENVBD-master - Build #155 - Successful MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_8_3562250.1632139218990" X-Jenkins-Job: XENVBD-master X-Jenkins-Result: SUCCESS ------=_Part_8_3562250.1632139218990 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #155. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENVBD-master/155/console to view the results. ------=_Part_8_3562250.1632139218990-- From win-pv-devel-bounces@lists.xenproject.org Mon Sep 20 14:04:03 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 20 Sep 2021 14:04:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.190929.340764 (Exim 4.92) (envelope-from ) id 1mSJto-0001lt-J3; Mon, 20 Sep 2021 14:04:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 190929.340764; Mon, 20 Sep 2021 14:04:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSJto-0001lm-GA; Mon, 20 Sep 2021 14:04:00 +0000 Received: by outflank-mailman (input) for mailman id 190929; Mon, 20 Sep 2021 14:03:58 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSJtm-0001lg-J7 for win-pv-devel@lists.xenproject.org; Mon, 20 Sep 2021 14:03:58 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" Date: Mon, 20 Sep 2021 14:03:47 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <14517447.11.1632146628150.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> Subject: XENHID-master - Build #28 - Successful MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_10_21344880.1632146627838" X-Jenkins-Job: XENHID-master X-Jenkins-Result: SUCCESS ------=_Part_10_21344880.1632146627838 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #28. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENHID-master/28/console to view the results. ------=_Part_10_21344880.1632146627838-- From win-pv-devel-bounces@lists.xenproject.org Mon Sep 20 16:16:55 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 20 Sep 2021 16:16:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.191022.340878 (Exim 4.92) (envelope-from ) id 1mSLyP-0004Xh-QC; Mon, 20 Sep 2021 16:16:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 191022.340878; Mon, 20 Sep 2021 16:16:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSLyP-0004Xa-NQ; Mon, 20 Sep 2021 16:16:53 +0000 Received: by outflank-mailman (input) for mailman id 191022; Mon, 20 Sep 2021 16:16:53 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSLyP-0004XQ-0b for win-pv-devel@lists.xenproject.org; Mon, 20 Sep 2021 16:16:53 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" Date: Mon, 20 Sep 2021 16:16:42 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <23632599.13.1632154602639.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> Subject: XENVKBD-master - Build #30 - Successful MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_12_5994734.1632154602530" X-Jenkins-Job: XENVKBD-master X-Jenkins-Result: SUCCESS ------=_Part_12_5994734.1632154602530 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #30. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENVKBD-master/30/console to view the results. ------=_Part_12_5994734.1632154602530-- From win-pv-devel-bounces@lists.xenproject.org Mon Sep 20 22:07:30 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 20 Sep 2021 22:07:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.191213.341153 (Exim 4.92) (envelope-from ) id 1mSRRh-0003TJ-HZ; Mon, 20 Sep 2021 22:07:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 191213.341153; Mon, 20 Sep 2021 22:07:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSRRh-0003TB-Ei; Mon, 20 Sep 2021 22:07:29 +0000 Received: by outflank-mailman (input) for mailman id 191213; Mon, 20 Sep 2021 22:07:28 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSRRg-0003T3-Cj for win-pv-devel@lists.xenproject.org; Mon, 20 Sep 2021 22:07:28 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" Date: Mon, 20 Sep 2021 22:07:17 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <23286090.15.1632175638212.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> Subject: XENVIF-master - Build #190 - Successful MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_14_14944668.1632175637915" X-Jenkins-Job: XENVIF-master X-Jenkins-Result: SUCCESS ------=_Part_14_14944668.1632175637915 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #190. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENVIF-master/190/console to view the results. ------=_Part_14_14944668.1632175637915-- From win-pv-devel-bounces@lists.xenproject.org Tue Sep 21 08:26:12 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 21 Sep 2021 08:26:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.191556.341636 (Exim 4.92) (envelope-from ) id 1mSb6Q-0006fM-Po; Tue, 21 Sep 2021 08:26:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 191556.341636; Tue, 21 Sep 2021 08:26:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSb6Q-0006fE-MX; Tue, 21 Sep 2021 08:26:10 +0000 Received: by outflank-mailman (input) for mailman id 191556; Tue, 21 Sep 2021 08:26:09 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSb6P-0006ez-Qn for win-pv-devel@lists.xenproject.org; Tue, 21 Sep 2021 08:26:09 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" Date: Tue, 21 Sep 2021 08:25:59 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <10156014.17.1632212759981.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> Subject: XENVIF-master - Build #191 - Successful MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_16_23708880.1632212759247" X-Jenkins-Job: XENVIF-master X-Jenkins-Result: SUCCESS ------=_Part_16_23708880.1632212759247 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #191. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENVIF-master/191/console to view the results. ------=_Part_16_23708880.1632212759247-- From win-pv-devel-bounces@lists.xenproject.org Tue Sep 21 10:46:03 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 21 Sep 2021 10:46:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.191650.341753 (Exim 4.92) (envelope-from ) id 1mSdHm-0001J1-1i; Tue, 21 Sep 2021 10:46:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 191650.341753; Tue, 21 Sep 2021 10:46:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSdHl-0001Iu-UF; Tue, 21 Sep 2021 10:46:01 +0000 Received: by outflank-mailman (input) for mailman id 191650; Tue, 21 Sep 2021 10:46:01 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSdHl-0001Cy-5m for win-pv-devel@lists.xenproject.org; Tue, 21 Sep 2021 10:46:01 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1a3c24ea-1ac9-11ec-b8bb-12813bfff9fa; Tue, 21 Sep 2021 10:45:57 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 1a3c24ea-1ac9-11ec-b8bb-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1632221157; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=tyrptaukFhxvqlhvbRy56Fi9MQ1MNalracDSZRJYJng=; b=JD34z0EBJSwXzI9VJpKzkfrJyJwODYAQIPXm4QbC7mzzRY8Y7F3FFYft IyiZEF4Cg0Ar0FPCJx9dulo76VLcVg4bsK/93WJhFbWrZylagoQZsTbeT pxjgcw82COcaAxze3ruAoNM2aGnVlzTstBSeb1snrk2cpJbI101leQj/H Q=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: ZPYelIWibt7q5k3VREnyku5W9sDiaWxgE6vClsVeemVO1V8fhTUoA4cQzbdtLbGpA/xq2UwSKV 9Cuc437blkgsowvkGpqvzEbKkl9Kp5aM6Qb3w1BLTyQpUfkRE6CqIdihesbxUwIchAPZ4ahXAi 76mw021cgXLlwvdQC9YNr5YE+tlggCztfmn2cz/Rs0H49jlleKaVGc/aRzsu2IzZea6NaiOgmO ff0ch5d1/n9P6t5nGbuwm8D47eojsr24qQ+osQ/dgYx67uh4bk/tCKfEgh6FCbKaWe5EmZCtKo uka5hfAS1vWSG9IyiK5fKd22 X-SBRS: 5.1 X-MesageID: 53199089 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:eX9d3aCgGZwwzRVW/1Hkw5YqxClBgxIJ4kV8jS/XYbTApDx21DJVy 2sYD27Taf+LZ2umf49/aN/j90hT78fTnNVnQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLOs1hxZH1c+EX9w00s7wYbVv6Yz6TSHK1LV0 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/oBypu45Jy ch2p42bWDZ5NIiQh8kdakwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr KFGbmBWBvyAr7veLLaTTfZhgII4Kcj3PKsUu216zCGfBvEjKXzGa/iRvI4JhGdh7ixINafne PBFawpLUCT/RAYMFnYIVNUPzPj90xETdBUH8QnI9MLb+VP70w13laDzddbYZNGObcFUhVqD4 HLL+XzjBRMXP8DZziCKmk9AnceWw3m9AthLUuTlqLg62zV/21D/FjU9fHuf/8G4l3WsSvlOG hwe33YxgKgLoRnDosbGY/GonJKVlkdCAIMASLxrsFvlJrn8uFnCVzNdJtJVQJl/7pZnG2Zyv rOct46xXVRSXKuppWVxH1t+hQi7PzQcZUQGbDUNJefuy4i++Nxv5v4jo9AKLUJUsjEXMWqrq 9xphHJn71n2sSLs///glW0rexr2+vD0ovcdv207pF5JCz+Vg6b+PeSVBaXzt64cfO51sHHY5 CVsdzeiABAmUsjWyX3lrBQlN7C1/feVWAAwcnY2RMJJythZwFb6Jdo4yGgnfC9Ba59YERe0M B67kV4Av/d7YSr1BZKblqrsUqzGO4C7To+7Ph0VB/ITCqVMmPivpnA2ORHIgDCzzyDBU8gXY P+mTCplNl5CYYwP8dZ8b711PWYDyn9syGXNa4r8yhj7g7OSaGTMEeUOMUeUb/B/56SB+V2H/ 9FaPsqM6hNeTOyhPXWHrd9NdQgHfSohGJT7i81LberfcABoL34sVq3KyrQ7do07w6kMzrXU/ muwU1NzwUbkgSGVMh2Db31uMeu9XZt2oX8hEzYrOFKkhyoqbYq1tf9NfJorZ7g3sudkyKcsH fUCfsyBBNVJSyjGpGtBPcWs8tQ6eU3y1wyUPiejbDwuRLJaRlTEqo3+Yw/i1CgSFS7r58Ewl KKti1HASp0ZSgU8UMuPMKCzz0m8tGQ2kf5pWxeaOcFafUjh/dQ4KyH1ifNrccgAJQ+am2mf3 geSRxwZufPMs8k+99yQ3fKIqIKgEu1fGEtGHjaEsebqZHeCpmfzk5VdVOuofCzGUDKm8aqvU uxZ0vXgPaBVh11NqYd9T+5mwK9WCwEDfFOGItCIxEn2Umk= IronPort-HdrOrdr: A9a23:TyvNwajw7jukUHbWHsjasWb44HBQXt4ji2hC6mlwRA09TyXPrb HLoB1773/JYVkqM03I9errBEDiexLhHPxOjrX5Zo3SOTUO0VHARL2Ki7GO/9SKIUPDH4BmuZ uJ3MJFebrN5fQRt7eY3OEYeexQouW6zA== X-IronPort-AV: E=Sophos;i="5.85,311,1624334400"; d="scan'208";a="53199089" From: Owen Smith To: CC: Owen Smith Subject: [PATCH 1/2] Refactor string conversion in wmi.c Date: Tue, 21 Sep 2021 11:45:51 +0100 Message-ID: <20210921104552.76-1-owen.smith@citrix.com> X-Mailer: git-send-email 2.31.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Colocates related string functions, removes unused functions, adjusts whitespace and reformats functions into a consistant code style. There are no functional changes Signed-off-by: Owen Smith --- src/xeniface/wmi.c | 642 ++++++++++++++++++++++++--------------------- 1 file changed, 347 insertions(+), 295 deletions(-) diff --git a/src/xeniface/wmi.c b/src/xeniface/wmi.c index 3ee68d5..aedd2f1 100644 --- a/src/xeniface/wmi.c +++ b/src/xeniface/wmi.c @@ -49,6 +49,17 @@ #define WMI_POOL_TAG 'XenP' +#define UTF8MASK2 0x1FFF80 +#define UTF8MASK3 0x1FF800 +#define UTF8MASK4 0x1F0000 + +#if (_MSC_VER <= 1922) +typedef struct { + USHORT Length; + CHAR Buffer[1]; +} UTF8_STRING; +#endif + static FORCEINLINE PVOID WmiAllocate( IN ULONG Length @@ -79,119 +90,102 @@ void UnlockSessions( ReleaseMutex(&fdoData->SessionLock); } -void GetUnicodeString(UNICODE_STRING *unicode, USHORT maxlength, LPWSTR location) -{ - int i; - USHORT length=0; - unicode->MaximumLength=maxlength; - unicode->Buffer=location; - // No appropriate fucntion to determine the length of a possibly null - // terminated string withing a fixed sized buffer exists. - for (i=0; (i*sizeof(WCHAR))Length = (USHORT)length; -} - -NTSTATUS GetAnsiString(ANSI_STRING *ansi, USHORT maxlength, LPWSTR location) { - UNICODE_STRING unicode; - NTSTATUS status; - GetUnicodeString(&unicode, maxlength, location); - status = RtlUnicodeStringToAnsiString(ansi, &unicode, TRUE); - return status; -} - // Rather inconveniently, xenstore needs UTF8 data, WMI works in UTF16 // and windows doesn't provide conversion functions in any version // prior to Windows 7. - -USHORT Utf32FromUtf16(ULONG *utf32, const WCHAR* utf16) { - ULONG w; - ULONG u; - ULONG xa; - ULONG xb; - ULONG x; +static USHORT +Utf32FromUtf16( + OUT PULONG utf32, + IN const WCHAR* utf16 + ) +{ + ULONG w; + ULONG u; + ULONG xa; + ULONG xb; + ULONG x; if (((utf16[0]) & 0xFC00) == 0xD800) { - w = ((utf16[0]) & 0X03FF) >>6; - u = w+1; + w = ((utf16[0]) & 0X03FF) >> 6; + u = w + 1; xa = utf16[0] & 0x3F; xb = utf16[1] & 0x03FF; - x = (xa<<10) | xb; - *utf32 = (u<<16) + x; + x = (xa << 10) | xb; + *utf32 = (u << 16) + x; return 2; - } - else { + } else { *utf32 = *utf16; return 1; } } -USHORT Utf32FromUtf8(ULONG *utf32, const CHAR *utf8) { - ULONG y; - ULONG x; - ULONG z; - ULONG ua; - ULONG ub; - ULONG u; +static USHORT +Utf32FromUtf8( + OUT PULONG utf32, + IN const CHAR* utf8 + ) +{ + ULONG y; + ULONG x; + ULONG z; + ULONG ua; + ULONG ub; + ULONG u; if ((utf8[0] & 0x80) == 0) { *utf32 = utf8[0]; return 1; - } - else if ((utf8[0] & 0xE0) == 0xC0) { + } else if ((utf8[0] & 0xE0) == 0xC0) { y = utf8[0] & 0x1F; x = utf8[1] & 0x3F; - *utf32 = (y<<6) | x; + *utf32 = (y << 6) | x; return 2; - } - else if ((utf8[0] & 0xF0) == 0xE0) { + } else if ((utf8[0] & 0xF0) == 0xE0) { z = utf8[0] & 0x0F; y = utf8[1] & 0x3F; x = utf8[2] & 0x3F; - *utf32 = (z <<12) | (y<<6) | x; + *utf32 = (z << 12) | (y << 6) | x; return 3; - } - else { + } else { ua = utf8[0] & 0x7; ub = (utf8[1] & 0x30) >> 4; u = (ua << 2) | ub; z = utf8[1] & 0x0f; y = utf8[2] & 0x3f; x = utf8[3] & 0x3f; - *utf32 = (u<<16) | (z <<12) | (y <<6) | x; + *utf32 = (u << 16) | (z << 12) | (y << 6) | x; return 4; } - } -USHORT Utf16FromUtf32(WCHAR *utf16, const ULONG utf32) { - WCHAR u; - WCHAR w; - WCHAR x; +static USHORT +Utf16FromUtf32( + OUT PWCHAR utf16, + IN ULONG utf32 + ) +{ + WCHAR u; + WCHAR w; + WCHAR x; + if ((utf32 > 0xFFFF)) { u = (utf32 & 0x1F0000) >> 16; - w = u-1; + w = u - 1; x = utf32 & 0xFFFF; - utf16[0] = 0xD800 | (w<<6) | (x>>10); + utf16[0] = 0xD800 | (w << 6) | (x >> 10); utf16[1] = 0xDC00 | (x & 0x3F); return 2; - } - else { + } else { utf16[0] = utf32 & 0xFFFF; return 1; } } - -#define UTF8MASK2 0x1FFF80 -#define UTF8MASK3 0x1FF800 -#define UTF8MASK4 0x1F0000 - -USHORT CountUtf8FromUtf32(ULONG utf32) { +static USHORT +CountUtf8FromUtf32( + IN ULONG utf32 + ) +{ if (utf32 & UTF8MASK4) return 4; if (utf32 & UTF8MASK3) @@ -201,31 +195,38 @@ USHORT CountUtf8FromUtf32(ULONG utf32) { return 1; } -USHORT CountUtf16FromUtf32(ULONG utf32) { - if ((utf32 & 0xFF0000) > 0) { +static USHORT +CountUtf16FromUtf32( + IN ULONG utf32 + ) +{ + if (utf32 & 0xFF0000) return 2; - } return 1; } -USHORT Utf8FromUtf32(CHAR *dest, ULONG utf32) { - CHAR u; - CHAR y; - CHAR x; - CHAR z; +static USHORT +Utf8FromUtf32( + OUT PCHAR dest, + IN ULONG utf32 + ) +{ + CHAR u; + CHAR y; + CHAR x; + CHAR z; if (utf32 & UTF8MASK4) { x = utf32 & 0x3f; y = (utf32 >> 6) & 0x3f; z = (utf32 >> 12) & 0xf; u = (utf32 >> 16) & 0x1f; - dest[0] = 0xf0 | u>>2; + dest[0] = 0xf0 | u >> 2; dest[1] = 0x80 | (u & 0x3) << 4 | z; dest[2] = 0x80 | y; dest[3] = 0x80 | x; return 4; - } - else if (utf32 & UTF8MASK3) { + } else if (utf32 & UTF8MASK3) { x = utf32 & 0x3f; y = (utf32 >> 6) & 0x3f; z = (utf32 >> 12) & 0xf; @@ -233,55 +234,101 @@ USHORT Utf8FromUtf32(CHAR *dest, ULONG utf32) { dest[1] = 0x80 | y; dest[2] = 0x80 | x; return 3; - } - else if (utf32 & UTF8MASK2) { + } else if (utf32 & UTF8MASK2) { x = utf32 & 0x3f; y = (utf32 >> 6) & 0x3f; dest[0] = 0xc0 | y; dest[1] = 0x80 | x; return 2; - } - else { + } else { x = utf32 & 0x7f; dest[0] = x; return 1; } } -#if (_MSC_VER <= 1922) -typedef struct { - USHORT Length; - CHAR Buffer[1]; -} UTF8_STRING; -#endif +static USHORT +CountBytesUtf16FromUtf8String( + IN const UTF8_STRING* utf8 + ) +{ + ULONG utf32; + int i = 0; + USHORT bytecount = 0; -USHORT CountBytesUtf16FromUtf8String(const UTF8_STRING *utf8) { - ULONG utf32; - int i = 0; - USHORT bytecount = 0; - while (iLength && utf8->Buffer[i] !=0) { + while (i < utf8->Length && utf8->Buffer[i] != 0) { i += Utf32FromUtf8(&utf32, &utf8->Buffer[i]); bytecount += CountUtf16FromUtf32(utf32); } + return bytecount * sizeof(WCHAR); } -USHORT CountBytesUtf16FromUtf8(const UCHAR *utf8) { - ULONG utf32; - int i = 0; - USHORT bytecount = 0; + +static USHORT +CountBytesUtf16FromUtf8( + IN const CHAR* utf8 + ) +{ + ULONG utf32; + int i = 0; + USHORT bytecount = 0; + while (utf8[i] !=0) { i += Utf32FromUtf8(&utf32, &utf8[i]); bytecount += CountUtf16FromUtf32(utf32); } + return bytecount * sizeof(WCHAR); } -NTSTATUS GetUTF8String(UTF8_STRING** utf8, USHORT bufsize, LPWSTR ustring) + +static VOID +GetUnicodeString( + OUT PUNICODE_STRING unicode, + IN USHORT maxlength, + IN LPWSTR location + ) { - USHORT bytecount = 0; - USHORT i; - ULONG utf32; - i = 0; - while (i < (bufsize/sizeof(WCHAR))) { + USHORT i; + USHORT length = 0; + + unicode->MaximumLength = maxlength; + unicode->Buffer = location; + // No appropriate function to determine the length of a possibly null + // terminated string within a fixed sized buffer exists. + for (i = 0; (i * sizeof(WCHAR)) < maxlength; i++) { + if (location[i] != L'\0') + length += sizeof(WCHAR); + else + break; + } + unicode->Length = length; +} + +static NTSTATUS +GetAnsiString( + OUT PANSI_STRING ansi, + IN USHORT maxlength, + IN LPWSTR location + ) +{ + UNICODE_STRING unicode; + + GetUnicodeString(&unicode, maxlength, location); + return RtlUnicodeStringToAnsiString(ansi, &unicode, TRUE); +} + +static NTSTATUS +GetUTF8String( + OUT UTF8_STRING** utf8, + IN USHORT bufsize, + IN LPWSTR ustring + ) +{ + ULONG utf32; + USHORT bytecount = 0; + USHORT i = 0; + + while (i < bufsize / sizeof(WCHAR)) { i += Utf32FromUtf16(&utf32, &ustring[i]); bytecount += CountUtf8FromUtf32(utf32); } @@ -291,10 +338,9 @@ NTSTATUS GetUTF8String(UTF8_STRING** utf8, USHORT bufsize, LPWSTR ustring) return STATUS_INSUFFICIENT_RESOURCES; (*utf8)->Length = bytecount; - (*utf8)->Buffer[bytecount]=0; bytecount = 0; - i=0; + i = 0; while (i < bufsize/sizeof(WCHAR)) { i += Utf32FromUtf16(&utf32, &ustring[i]); bytecount += Utf8FromUtf32(&((*utf8)->Buffer[bytecount]), utf32); @@ -303,32 +349,218 @@ NTSTATUS GetUTF8String(UTF8_STRING** utf8, USHORT bufsize, LPWSTR ustring) return STATUS_SUCCESS; } -void FreeUTF8String(UTF8_STRING *utf8) { +static FORCEINLINE VOID +FreeUTF8String( + IN UTF8_STRING* utf8 + ) +{ WmiFree(utf8); } -NTSTATUS GetCountedUTF8String(UTF8_STRING **utf8, UCHAR *location) +static NTSTATUS +GetCountedUTF8String( + OUT UTF8_STRING** utf8, + IN PUCHAR location + ) { USHORT bufsize = *(USHORT*)location; - LPWSTR ustring = (LPWSTR)(location+sizeof(USHORT)); + LPWSTR ustring = (LPWSTR)(location + sizeof(USHORT)); return GetUTF8String(utf8, bufsize, ustring); - } -void GetCountedUnicodeString(UNICODE_STRING *unicode, UCHAR *location) +static VOID +GetCountedUnicodeString( + OUT PUNICODE_STRING unicode, + IN PUCHAR location + ) { USHORT bufsize = *(USHORT*)location; - LPWSTR ustring = (LPWSTR)(location+sizeof(USHORT)); + LPWSTR ustring = (LPWSTR)(location + sizeof(USHORT)); GetUnicodeString(unicode, bufsize, ustring); } -NTSTATUS GetCountedAnsiString(ANSI_STRING *ansi, UCHAR *location) +static NTSTATUS +GetCountedAnsiString( + OUT PANSI_STRING ansi, + IN PUCHAR location + ) { USHORT bufsize = *(USHORT*)location; - LPWSTR ustring = (LPWSTR)(location+sizeof(USHORT)); + LPWSTR ustring = (LPWSTR)(location + sizeof(USHORT)); return GetAnsiString(ansi, bufsize, ustring); } +static FORCEINLINE size_t +GetCountedUtf8Size( + IN const CHAR* utf8 + ) +{ + return sizeof(USHORT) + CountBytesUtf16FromUtf8(utf8); +} + +static FORCEINLINE size_t +GetCountedUnicodeStringSize( + IN PCUNICODE_STRING string + ) +{ + return sizeof(USHORT) + string->Length; +} + +static VOID +WriteCountedUnicodeString( + IN PCUNICODE_STRING ustr, + IN PUCHAR location + ) +{ + *((USHORT*)location) = ustr->Length; + RtlCopyMemory(location + sizeof(USHORT), + ustr->Buffer, + ustr->Length); +} + +static NTSTATUS +WriteCountedUTF8String( + IN const CHAR* string, + IN PUCHAR location + ) +{ + UNICODE_STRING unicode; + USHORT i; + USHORT b; + USHORT bytesize; + ULONG utf32; + PWCHAR buffer; + + bytesize = CountBytesUtf16FromUtf8(string); + buffer = WmiAllocate(bytesize + sizeof(WCHAR)); + if (buffer == NULL) + return STATUS_INSUFFICIENT_RESOURCES; + + i = 0; + b = 0; + while (string[i] != 0) { + i += Utf32FromUtf8(&utf32, &string[i]); + b += Utf16FromUtf32(&buffer[b], utf32); + } + + RtlInitUnicodeString(&unicode, buffer); + WriteCountedUnicodeString(&unicode, location); + WmiFree(buffer); + + return STATUS_SUCCESS; +} + +static VOID +AllocUnicodeStringBuffer( + OUT PUNICODE_STRING string, + IN USHORT buffersize + ) +{ + string->Length = 0; + string->MaximumLength = 0; + string->Buffer = WmiAllocate(buffersize); + if (string->Buffer == NULL) + return; + + string->MaximumLength = buffersize; +} + +static FORCEINLINE VOID +FreeUnicodeStringBuffer( + IN PUNICODE_STRING string + ) +{ + if (string->Buffer) + WmiFree(string->Buffer); + string->Length = 0; + string->MaximumLength = 0; + string->Buffer = NULL; +} + +static NTSTATUS +CloneUnicodeString( + OUT PUNICODE_STRING dest, + IN PCUNICODE_STRING src + ) +{ + NTSTATUS status; + + AllocUnicodeStringBuffer(dest, src->Length); + if (dest->Buffer == NULL) + return STATUS_INSUFFICIENT_RESOURCES; + + status = RtlUnicodeStringCopy(dest, src); + if (!NT_SUCCESS(status)) + FreeUnicodeStringBuffer(dest); + + return status; +} + +static NTSTATUS +GetInstanceName( + OUT PUNICODE_STRING dest, + IN PXENIFACE_FDO FdoData, + IN const CHAR* string + ) +{ + ANSI_STRING ansi; + UNICODE_STRING unicode; + NTSTATUS status; + size_t destsz; + + RtlInitAnsiString(&ansi, string); + status = RtlAnsiStringToUnicodeString(&unicode, &ansi, TRUE); + if (!NT_SUCCESS(status)) + goto fail1; + + destsz = FdoData->SuggestedInstanceName.Length + + sizeof(WCHAR) + + unicode.Length; + + status = STATUS_INSUFFICIENT_RESOURCES; + AllocUnicodeStringBuffer(dest, (USHORT)destsz); + if (dest->Buffer == NULL) + goto fail2; + + status = RtlUnicodeStringPrintf(dest, + L"%s\\%s", + FdoData->SuggestedInstanceName.Buffer, + unicode.Buffer); + if (!NT_SUCCESS(status)) + goto fail3; + + RtlFreeUnicodeString(&unicode); + return STATUS_SUCCESS; + +fail3: + FreeUnicodeStringBuffer(dest); + +fail2: + RtlFreeUnicodeString(&unicode); + +fail1: + return status; +} + +static NTSTATUS +WriteInstanceName( + IN PXENIFACE_FDO FdoData, + IN const CHAR* string, + IN PUCHAR location + ) +{ + UNICODE_STRING destination; + NTSTATUS status; + + status = GetInstanceName(&destination, FdoData, string); + if (!NT_SUCCESS(status)) + return status; + + WriteCountedUnicodeString(&destination, location); + FreeUnicodeStringBuffer(&destination); + return STATUS_SUCCESS; +} + typedef enum { WMI_DONE, WMI_STRING, @@ -499,186 +731,6 @@ int AccessWmiBuffer(PUCHAR Buffer, int readbuffer, ULONG * RequiredSize, return TRUE; } - -NTSTATUS -WriteCountedUnicodeString( - const UNICODE_STRING *ustr, - UCHAR *location - ) -{ - *((USHORT*)location) = ustr->Length; - RtlCopyMemory(location+sizeof(USHORT), ustr->Buffer, - ustr->Length); - - return STATUS_SUCCESS; -} - -NTSTATUS -WriteCountedUTF8String(const char * string, UCHAR *location) { - UNICODE_STRING unicode; - - int i=0; - USHORT b; - USHORT bytesize=0; - ULONG utf32; - NTSTATUS status = STATUS_SUCCESS; - WCHAR *buffer; - bytesize = CountBytesUtf16FromUtf8(string); - buffer = WmiAllocate(bytesize + sizeof(WCHAR)); - if (buffer == NULL) - return STATUS_INSUFFICIENT_RESOURCES; - - buffer[bytesize/sizeof(WCHAR)] = 0; - - i=0; - b=0; - while (string[i] != 0) { - i += Utf32FromUtf8(&utf32, &string[i]); - b += Utf16FromUtf32(&buffer[b], utf32); - } - RtlInitUnicodeString(&unicode, buffer); - status = WriteCountedUnicodeString(&unicode, location); - WmiFree(buffer); - - return status; -} - -NTSTATUS -WriteCountedString( - const char * string, - UCHAR * location - ) -{ - ANSI_STRING ansi; - UNICODE_STRING unicode; - NTSTATUS status; - - RtlInitAnsiString(&ansi, string); - - status = RtlAnsiStringToUnicodeString(&unicode, &ansi, TRUE); - if (NT_SUCCESS(status)) { - - status = WriteCountedUnicodeString(&unicode, location); - RtlFreeUnicodeString(&unicode); - } - - return status; -} - -void AllocUnicodeStringBuffer(UNICODE_STRING *string, USHORT buffersize) { - string->Buffer = WmiAllocate(buffersize); - string->Length = 0; - if (string->Buffer == NULL) { - string->MaximumLength=0; - return; - } - string->MaximumLength=(USHORT)buffersize; - string->Buffer[0]=0; - return; -} -void FreeUnicodeStringBuffer(UNICODE_STRING *string) { - if (string->Buffer) - WmiFree(string->Buffer); - string->Length=0; - string->MaximumLength=0; - string->Buffer = NULL; -} - -NTSTATUS -CloneUnicodeString(UNICODE_STRING *dest, UNICODE_STRING *src) { - NTSTATUS status; - AllocUnicodeStringBuffer(dest, src->Length); - if (dest->Buffer == NULL) - return STATUS_INSUFFICIENT_RESOURCES; - status = RtlUnicodeStringCopy(dest, src); - if (!NT_SUCCESS(status)) { - FreeUnicodeStringBuffer(dest); - } - return status; -} - -NTSTATUS -StringToUnicode(UNICODE_STRING *ustr, const char * str) { - ANSI_STRING ansi; - RtlInitAnsiString(&ansi, str); - return RtlAnsiStringToUnicodeString(ustr, &ansi, TRUE); -} - -size_t -GetCountedSize(const char * string) { - ANSI_STRING ansi; - RtlInitAnsiString(&ansi, string); - return sizeof(USHORT)+sizeof(WCHAR)*ansi.Length; -} - -size_t -GetCountedUtf8Size(const char *utf8) { - return sizeof(USHORT) + CountBytesUtf16FromUtf8(utf8); -} - -size_t -GetCountedUnicodeStringSize(UNICODE_STRING *string) { - return sizeof(USHORT)+string->Length; -} - -size_t -GetInstanceNameSize(XENIFACE_FDO* FdoData, const char *string) { - ANSI_STRING ansi; - RtlInitAnsiString(&ansi, string); - return sizeof(USHORT) + - FdoData->SuggestedInstanceName.Length + - sizeof(WCHAR) + - sizeof(WCHAR)*ansi.Length; - -} - - -NTSTATUS -GetInstanceName(UNICODE_STRING *dest, XENIFACE_FDO* FdoData, const char *string) { - ANSI_STRING ansi; - UNICODE_STRING unicode; - NTSTATUS status; - size_t destsz; - - RtlInitAnsiString(&ansi, string); - status = RtlAnsiStringToUnicodeString(&unicode, &ansi, TRUE); - if (!NT_SUCCESS(status)) { - return status; - } - destsz = FdoData->SuggestedInstanceName.Length + - sizeof(WCHAR) + - unicode.Length; - - AllocUnicodeStringBuffer(dest, (USHORT)destsz); - if (dest->Buffer == NULL ) { - RtlFreeUnicodeString(&unicode); - return STATUS_INSUFFICIENT_RESOURCES; - } - status = RtlUnicodeStringPrintf(dest, L"%s\\%s", - FdoData->SuggestedInstanceName.Buffer, - unicode.Buffer); - if (!NT_SUCCESS(status)) { - RtlFreeUnicodeString(&unicode); - FreeUnicodeStringBuffer(dest); - return status; - } - RtlFreeUnicodeString(&unicode); - return STATUS_SUCCESS; -} - -NTSTATUS -WriteInstanceName(XENIFACE_FDO* FdoData, const char *string, UCHAR *location) -{ - UNICODE_STRING destination; - NTSTATUS status; - status = GetInstanceName(&destination, FdoData, string); - if (!NT_SUCCESS(status)) - return status; - status = WriteCountedUnicodeString(&destination, location); - FreeUnicodeStringBuffer(&destination); - return status; -} - #define MAX_WATCH_COUNT (MAXIMUM_WAIT_OBJECTS -1) typedef struct _XenStoreSession { -- 2.31.1.windows.1 From win-pv-devel-bounces@lists.xenproject.org Tue Sep 21 10:46:07 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 21 Sep 2021 10:46:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.191651.341757 (Exim 4.92) (envelope-from ) id 1mSdHr-0001Ow-3q; Tue, 21 Sep 2021 10:46:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 191651.341757; Tue, 21 Sep 2021 10:46:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSdHr-0001Oo-0q; Tue, 21 Sep 2021 10:46:07 +0000 Received: by outflank-mailman (input) for mailman id 191651; Tue, 21 Sep 2021 10:46:06 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSdHq-0001Cy-5l for win-pv-devel@lists.xenproject.org; Tue, 21 Sep 2021 10:46:06 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1b2db53b-1ac9-11ec-b8bb-12813bfff9fa; Tue, 21 Sep 2021 10:45:59 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 1b2db53b-1ac9-11ec-b8bb-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1632221159; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=UVGkBijFREc8VDu4rUCeUQk4Pa1gd91qhkhn+tVPwTw=; b=Jnns6D5037yH/o+wX8Uow6koakBNC4zAQxSwOZl4Czp5180tyS1un1m3 Ys2jn52Z5/ZQUBqJn83BYN1WiKakh4SQa0+Rp0Q/cMdNm3XcF4WJSXKp1 wWqII2xIf1z2lm8E0Nb3cvgCsHknbD5viLIpBmcE1EmwpvvOXtWbDfFgy Y=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: UTOXEwl3flheL8yNMebiCIz+wqXyaEF1dhIg8wcQiirOLKmN3eVAKCtcsf5J4D+6C1FbFNJ2hI 1WT7KNlheBv/fvQK9qLGy9swmIl1VK1eHXCSZstRSVIiJyNc+7D6V6pj0NyvtWT7yPnr+SPQ88 +7gN/cB2HGYyEFAUd/ZX3IVnT66ELHuulVH90eBZJ4N6ZowK/f01AcfZV5aazx00RjPU9pwe41 DZ6As2lfu4RIhelrEdupJ2wVPzw1Bn47URUSNnRjp9Zh2ru2uAJOZekXwd93TQOwm2J9hm0vM2 VQOYTGyJk8+aOkxxtOT5wu1u X-SBRS: 5.1 X-MesageID: 54999651 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:39y/GqrQAmqNAhpl+GmevQsUao9eBmJgYhIvgKrLsJaIsI4StFCzt garIBnTOayKMGakf9slb4mz/U1S7J6Hn9M3GwVpry8yFH4Uo5uZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dnd84f5fs7Rh2Ncw0ILgW1nlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnZOVbhctDp3poekMSQd0OSwkMqgf96CSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFIQAt3cm1jTYEfYOSpHfWaTao9Rf2V/cg+gTQaePN pREMFKDajzdPyQfYgc4F6kBv6SkvHTvbDt2sWOs8P9fD2/7k1UqjemF3MDuUsOLQ4BNgAOUq 3zL+0z9AwoGL5qPxDyd6HWui+TT2yThV+ov+KaQr6AwxgfJnypKVUNQBQDTTeSFZlCWVPd4O 0gkyg8XoLko6mCBQ4PyWkS3vyvR1vIDYOa8A9HW+SnUlPGNs13IVzBeJtJSQId5755tHFTGw nfMxomwVGI16NV5XFrAru/8kN+kBcQCwYbujwc/RA0Z6pHIpIgph3ojpf4yTfbo0rUZ9dz2q g1mTRTSZZ1I1qbnNI3hpDgrZg5AQbCTFWYICv3/BD7N0++ATNfNi3aUBb3nARFod9zxc7V8l CJcx5j2AB4mVMnQ/MByfAn9NO7wvKvUWNEtqXVuA4Mg51yQF42LJNsLiAyS0HxBa55eERewO Re7kVoIuPd7YSv7BYcqMtnZI5l7ksDd+SHNC6m8gixmOcMqKmdqPUhGOCat4owauBJ9yf1gY cjLL5nE4LRzIf0P8Qdajtw1idcDrh3SD0uKLXwi5xj4g7eYelCPTrIJbAmHYuwjtfvWqwTJ6 ddPccCNzkwHAuH5ZyDW968VLEwLcidnVcyn9ZQPe77ROBdiFUEgF+TVneErdbt6kvkHjezP5 Hy8BBNVkQKtmX3dJAyWQXl/c7ezD41npHc2MHV0b1al0nQue6i166Ibe8dldLUr7rU7n/V1U +MEa4OLBfEWEmbL/DEUbJ/cqo1+dUv02VLSbnT9ODVmJsxuXQ3E/NPgbzDDzihWA3rlr9Y6r p2hyhjfHcgJSTN9AZuEc/mo1V6w4yQQwbogQ0vSL9BPU0zw64w2eTfph/o6LsxQexXOwjyWi 1SfDRsC/LSfpoY09J/ChLyerpfvGOx7RxIIE27e5LewFC/b4mv8ntMQDLfWJWjQBDHu5aGvR eRJ1PWtYvQIkWFDv5d4D7s2n7k14MHipuMCwwlpdJkRg49H1l+0zqG64PRy IronPort-HdrOrdr: A9a23:rNn7m6vrEcAEcVDg8DYSMzqr7skDctV00zEX/kB9WHVpm5qj5q STdZUgtSMc5wx7ZJhNo7q90cq7IE80l6Qb3WBLB8bGYOCOggLBEGgF1+bfKlbbdREWmNQw6U /OGZIOb+EZoTJB/KXHCKjTKadD/OW6 X-IronPort-AV: E=Sophos;i="5.85,311,1624334400"; d="scan'208";a="54999651" From: Owen Smith To: CC: Owen Smith Subject: [PATCH 2/2] Replace UTF8_STRING with OEM_STRING Date: Tue, 21 Sep 2021 11:45:52 +0100 Message-ID: <20210921104552.76-2-owen.smith@citrix.com> X-Mailer: git-send-email 2.31.1.windows.1 In-Reply-To: <20210921104552.76-1-owen.smith@citrix.com> References: <20210921104552.76-1-owen.smith@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain The UTF8 conversion functions treat UTF8_STRING as: struct { USHORT Length; CHAR Buffer[ANYSIZE_ARRAY]; } UTF8_STRING; But UTF8_STRING is defined by later WDKs as: struct { USHORT Length; USHORT MaximumLength; PCHAR Buffer; } UTF8_STRING; This difference leads to an 0x3B BSOD when anything attempts to use any WMI method that deals with strings. Replace UTF8_STRING with OEM_STRING which is available in all WDKs, and has the same definition as UTF8_STRING from later WDKs, simplifying the usage of retrieving strings from, or putting strings into, WMI buffers. Signed-off-by: Owen Smith --- src/xeniface/wmi.c | 199 +++++++++++++++++++++------------------------ 1 file changed, 94 insertions(+), 105 deletions(-) diff --git a/src/xeniface/wmi.c b/src/xeniface/wmi.c index aedd2f1..1b4c6c6 100644 --- a/src/xeniface/wmi.c +++ b/src/xeniface/wmi.c @@ -53,13 +53,6 @@ #define UTF8MASK3 0x1FF800 #define UTF8MASK4 0x1F0000 -#if (_MSC_VER <= 1922) -typedef struct { - USHORT Length; - CHAR Buffer[1]; -} UTF8_STRING; -#endif - static FORCEINLINE PVOID WmiAllocate( IN ULONG Length @@ -249,7 +242,7 @@ Utf8FromUtf32( static USHORT CountBytesUtf16FromUtf8String( - IN const UTF8_STRING* utf8 + IN PCOEM_STRING utf8 ) { ULONG utf32; @@ -319,7 +312,7 @@ GetAnsiString( static NTSTATUS GetUTF8String( - OUT UTF8_STRING** utf8, + OUT POEM_STRING utf8, IN USHORT bufsize, IN LPWSTR ustring ) @@ -333,17 +326,20 @@ GetUTF8String( bytecount += CountUtf8FromUtf32(utf32); } - *utf8 = WmiAllocate(sizeof(UTF8_STRING) + bytecount); - if ((*utf8) == NULL) + utf8->Length = 0; + utf8->MaximumLength = 0; + utf8->Buffer = WmiAllocate(bytecount + sizeof(WCHAR)); + if (utf8->Buffer == NULL) return STATUS_INSUFFICIENT_RESOURCES; - (*utf8)->Length = bytecount; + utf8->Length = bytecount; + utf8->MaximumLength = bytecount + sizeof(WCHAR); bytecount = 0; i = 0; - while (i < bufsize/sizeof(WCHAR)) { + while (i < bufsize / sizeof(WCHAR)) { i += Utf32FromUtf16(&utf32, &ustring[i]); - bytecount += Utf8FromUtf32(&((*utf8)->Buffer[bytecount]), utf32); + bytecount += Utf8FromUtf32(&(utf8->Buffer[bytecount]), utf32); } return STATUS_SUCCESS; @@ -351,15 +347,19 @@ GetUTF8String( static FORCEINLINE VOID FreeUTF8String( - IN UTF8_STRING* utf8 + IN POEM_STRING utf8 ) { - WmiFree(utf8); + if (utf8->Buffer) + WmiFree(utf8->Buffer); + utf8->Buffer = NULL; + utf8->Length = 0; + utf8->MaximumLength = 0; } static NTSTATUS GetCountedUTF8String( - OUT UTF8_STRING** utf8, + OUT POEM_STRING utf8, IN PUCHAR location ) { @@ -1523,7 +1523,7 @@ SessionExecuteRemoveValue(UCHAR *InBuffer, ULONG RequiredSize; NTSTATUS status; UCHAR* upathname; - UTF8_STRING *pathname; + OEM_STRING pathname; XenStoreSession *session; char *tmpbuffer; @@ -1541,12 +1541,12 @@ SessionExecuteRemoveValue(UCHAR *InBuffer, return status; status = STATUS_INSUFFICIENT_RESOURCES; - tmpbuffer = WmiAllocate(pathname->Length + 1); + tmpbuffer = WmiAllocate(pathname.Length + 1); if (!tmpbuffer) { goto fail1; } - RtlCopyBytes(tmpbuffer,pathname->Buffer, pathname->Length); + RtlCopyBytes(tmpbuffer, pathname.Buffer, pathname.Length); status = STATUS_WMI_INSTANCE_NOT_FOUND; if ((session = FindSessionByInstanceAndLock(fdoData, instance)) == @@ -1560,7 +1560,7 @@ fail2: WmiFree(tmpbuffer); fail1: - FreeUTF8String(pathname); + FreeUTF8String(&pathname); return status; } @@ -1696,8 +1696,8 @@ SessionExecuteSetValue(UCHAR *InBuffer, NTSTATUS status; UCHAR* upathname; UCHAR* uvalue; - UTF8_STRING* pathname; - UTF8_STRING* value; + OEM_STRING pathname; + OEM_STRING value; XenStoreSession *session; char *tmppath; char* tmpvalue; @@ -1716,23 +1716,24 @@ SessionExecuteSetValue(UCHAR *InBuffer, return status; status = STATUS_INSUFFICIENT_RESOURCES; - tmppath = WmiAllocate(pathname->Length + 1); + tmppath = WmiAllocate(pathname.Length + 1); if (!tmppath) { goto fail1; } - RtlCopyBytes(tmppath,pathname->Buffer, pathname->Length); + RtlCopyBytes(tmppath, pathname.Buffer, pathname.Length); + status = GetCountedUTF8String(&value, uvalue); if (!NT_SUCCESS(status)){ goto fail2; } status = STATUS_INSUFFICIENT_RESOURCES; - tmpvalue = WmiAllocate(value->Length + 1); + tmpvalue = WmiAllocate(value.Length + 1); if (!tmpvalue) { goto fail3; } - RtlCopyBytes(tmpvalue,value->Buffer, value->Length); + RtlCopyBytes(tmpvalue, value.Buffer, value.Length); status = STATUS_WMI_INSTANCE_NOT_FOUND; if ((session = FindSessionByInstanceAndLock(fdoData, instance)) == @@ -1747,13 +1748,13 @@ fail4: WmiFree(tmpvalue); fail3: - FreeUTF8String(value); + FreeUTF8String(&value); fail2: WmiFree(tmppath); fail1: - FreeUTF8String(pathname); + FreeUTF8String(&pathname); *byteswritten = 0; return status; @@ -1770,7 +1771,7 @@ SessionExecuteGetFirstChild(UCHAR *InBuffer, ULONG RequiredSize; UCHAR *uloc; NTSTATUS status; - UTF8_STRING* path; + OEM_STRING path; PCHAR listresults; size_t stringarraysize; UCHAR *valuepos; @@ -1792,12 +1793,12 @@ SessionExecuteGetFirstChild(UCHAR *InBuffer, } status = STATUS_INSUFFICIENT_RESOURCES; - tmppath = WmiAllocate(path->Length + 1); + tmppath = WmiAllocate(path.Length + 1); if (!tmppath) { goto fail1; } - RtlCopyBytes(tmppath,path->Buffer, path->Length); + RtlCopyBytes(tmppath, path.Buffer, path.Length); status = STATUS_WMI_INSTANCE_NOT_FOUND; if ((session = FindSessionByInstanceAndLock(fdoData, instance)) == @@ -1812,16 +1813,15 @@ SessionExecuteGetFirstChild(UCHAR *InBuffer, } stringarraysize = 0; - if ((listresults != NULL ) && (listresults[0]!=0)) { - stringarraysize+=CountBytesUtf16FromUtf8String(path); - if ((path->Length!=1)||(path->Buffer[0]!='/')) { + if ((listresults != NULL) && (listresults[0] != 0)) { + stringarraysize += CountBytesUtf16FromUtf8String(&path); + if ((path.Length != 1) || (path.Buffer[0] != '/')) { // If the path isn't '/', we need to insert a // '/' between pathname and nodename; - stringarraysize+=sizeof(WCHAR); + stringarraysize += sizeof(WCHAR); } - stringarraysize+=GetCountedUtf8Size(listresults); - } - else { + stringarraysize += GetCountedUtf8Size(listresults); + } else { stringarraysize+=GetCountedUtf8Size(""); } @@ -1835,12 +1835,10 @@ SessionExecuteGetFirstChild(UCHAR *InBuffer, status = STATUS_SUCCESS; if ((listresults != NULL) && (listresults[0] != 0)) { PSTR fullpath; - if ((path->Length==1) && (path->Buffer[0]=='/')) { + if ((path.Length == 1) && (path.Buffer[0] == '/')) { fullpath = Xmasprintf("/%s", listresults); - } - else { - fullpath = Xmasprintf("%s/%s", - path->Buffer, listresults); + } else { + fullpath = Xmasprintf("%s/%s", path.Buffer, listresults); } if (fullpath == NULL) { @@ -1866,7 +1864,7 @@ fail2: WmiFree(tmppath); fail1: - FreeUTF8String(path); + FreeUTF8String(&path); return status; @@ -1883,7 +1881,7 @@ SessionExecuteGetNextSibling(UCHAR *InBuffer, ULONG RequiredSize; UCHAR *uloc; NTSTATUS status; - UTF8_STRING* path; + OEM_STRING path; ANSI_STRING checkleaf; PCHAR listresults; PCHAR nextresult; @@ -1910,13 +1908,13 @@ SessionExecuteGetNextSibling(UCHAR *InBuffer, } status = STATUS_INSUFFICIENT_RESOURCES; - tmppath = WmiAllocate(path->Length + 1); + tmppath = WmiAllocate(path.Length + 1); if (!tmppath) { goto fail1; } - tmpleaf = WmiAllocate(path->Length + 1); + tmpleaf = WmiAllocate(path.Length + 1); if (!tmpleaf) { goto fail2; } @@ -1928,28 +1926,22 @@ SessionExecuteGetNextSibling(UCHAR *InBuffer, } leafoffset = 0; - if (path->Length>1) { - leafoffset = path->Length; - while ((leafoffset!=0) && (path->Buffer[leafoffset] != '/')) + if (path.Length > 1) { + leafoffset = path.Length; + while ((leafoffset != 0) && (path.Buffer[leafoffset] != '/')) leafoffset--; } - if (leafoffset != 0){ + if (leafoffset != 0) { #pragma warning(suppress:6386) // buffer overrun - RtlCopyBytes(tmppath,path->Buffer, leafoffset); - RtlCopyBytes(tmpleaf, path->Buffer+leafoffset+1, path->Length-leafoffset-1); - } - else { - - if (path->Buffer[0] == '/') { - if (path->Length>1) - RtlCopyBytes(tmpleaf, path->Buffer+1, path->Length-1); - tmppath[0]='/'; - } - else { + RtlCopyBytes(tmppath, path.Buffer, leafoffset); + RtlCopyBytes(tmpleaf, path.Buffer + leafoffset + 1, path.Length - leafoffset - 1); + } else if (path.Buffer[0] == '/') { + if (path.Length>1) + RtlCopyBytes(tmpleaf, path.Buffer + 1, path.Length - 1); + tmppath[0] = '/'; + } else { #pragma warning(suppress:6386) // buffer overrun - RtlCopyBytes(tmpleaf, path->Buffer, path->Length); - } - + RtlCopyBytes(tmpleaf, path.Buffer, path.Length); } status = XENBUS_STORE(Directory,&fdoData->StoreInterface, session->transaction, NULL, tmppath, &listresults); @@ -1986,17 +1978,16 @@ SessionExecuteGetNextSibling(UCHAR *InBuffer, attemptstring = nextresult; } - if (attemptstring!=NULL) { - stringarraysize+=CountBytesUtf16FromUtf8(tmppath); //sizeof(WCHAR)*leafoffset; - if ((path->Length!=1)||(path->Buffer[0]!='/')) { + if (attemptstring != NULL) { + stringarraysize += CountBytesUtf16FromUtf8(tmppath); //sizeof(WCHAR)*leafoffset; + if ((path.Length != 1) || (path.Buffer[0] != '/')) { // If the path isn't '/', we need to insert a // '/' between pathname and nodename; - stringarraysize+=sizeof(WCHAR); + stringarraysize += sizeof(WCHAR); } - stringarraysize+=GetCountedUtf8Size(attemptstring); - } - else { - stringarraysize+=GetCountedUtf8Size(""); + stringarraysize += GetCountedUtf8Size(attemptstring); + } else { + stringarraysize += GetCountedUtf8Size(""); } status = STATUS_BUFFER_TOO_SMALL; @@ -2009,12 +2000,10 @@ SessionExecuteGetNextSibling(UCHAR *InBuffer, status = STATUS_SUCCESS; if (attemptstring != NULL) { PSTR fullpath; - if ((leafoffset==1) && (path->Buffer[0]=='/')) { + if ((leafoffset == 1) && (path.Buffer[0] == '/')) { fullpath = Xmasprintf("/%s", attemptstring); - } - else { - fullpath = Xmasprintf("%s/%s", - tmppath, attemptstring); + } else { + fullpath = Xmasprintf("%s/%s", tmppath, attemptstring); } if (fullpath == NULL) { @@ -2042,7 +2031,7 @@ fail2: WmiFree(tmppath); fail1: - FreeUTF8String(path); + FreeUTF8String(&path); *byteswritten = RequiredSize; return status; @@ -2060,7 +2049,7 @@ SessionExecuteGetChildren(UCHAR *InBuffer, ULONG RequiredSize; UCHAR *uloc; NTSTATUS status; - UTF8_STRING* path; + OEM_STRING path; PCHAR listresults; PCHAR nextresults; ULONG *noofnodes; @@ -2084,12 +2073,12 @@ SessionExecuteGetChildren(UCHAR *InBuffer, } status = STATUS_INSUFFICIENT_RESOURCES; - tmppath = WmiAllocate(path->Length + 1); + tmppath = WmiAllocate(path.Length + 1); if (!tmppath) { goto fail1; } - RtlCopyBytes(tmppath,path->Buffer, path->Length); + RtlCopyBytes(tmppath, path.Buffer, path.Length); status = STATUS_WMI_INSTANCE_NOT_FOUND; if ((session = FindSessionByInstanceAndLock(fdoData, instance)) == @@ -2105,16 +2094,18 @@ SessionExecuteGetChildren(UCHAR *InBuffer, stringarraysize = 0; - nextresults=listresults; + nextresults = listresults; while (*nextresults != 0) { - stringarraysize+=sizeof(WCHAR)*path->Length; - if ((path->Length!=1)||(path->Buffer[0]!='/')) { + stringarraysize += sizeof(WCHAR) * path.Length; + if ((path.Length != 1) || (path.Buffer[0] != '/')) { // If the path isn't '/', we need to insert a // '/' between pathname and nodename; - stringarraysize+=sizeof(WCHAR); + stringarraysize += sizeof(WCHAR); } - stringarraysize+=GetCountedUtf8Size(nextresults); - for (;*nextresults!=0;nextresults++); + stringarraysize += GetCountedUtf8Size(nextresults); + + while (*nextresults != 0) + nextresults++; nextresults++; } @@ -2128,15 +2119,13 @@ SessionExecuteGetChildren(UCHAR *InBuffer, status = STATUS_SUCCESS; nextresults = listresults; - i=0; - while(*nextresults!=0) { + i = 0; + while (*nextresults != 0) { PSTR fullpath; - if ((path->Length==1) && (path->Buffer[0]=='/')) { + if ((path.Length == 1) && (path.Buffer[0] == '/')) { fullpath = Xmasprintf("/%s", nextresults); - } - else { - fullpath = Xmasprintf("%s/%s", - path->Buffer, nextresults); + } else { + fullpath = Xmasprintf("%s/%s", path.Buffer, nextresults); } if (fullpath == NULL) { @@ -2145,13 +2134,13 @@ SessionExecuteGetChildren(UCHAR *InBuffer, } WriteCountedUTF8String(fullpath, valuepos); - valuepos+=GetCountedUtf8Size(fullpath); + valuepos += GetCountedUtf8Size(fullpath); WmiFree(fullpath); - for (;*nextresults!=0;nextresults++); + + while (*nextresults != 0) + nextresults++; nextresults++; i++; - - } *noofnodes = i; @@ -2163,7 +2152,7 @@ fail2: WmiFree(tmppath); fail1: - FreeUTF8String(path); + FreeUTF8String(&path); *byteswritten = RequiredSize; return status; } @@ -2329,7 +2318,7 @@ SessionExecuteGetValue(UCHAR *InBuffer, UNICODE_STRING *instance, OUT ULONG_PTR *byteswritten) { NTSTATUS status; - UTF8_STRING* path; + OEM_STRING path; UCHAR *uloc; char *value; UCHAR *valuepos; @@ -2352,12 +2341,12 @@ SessionExecuteGetValue(UCHAR *InBuffer, return status;; status = STATUS_INSUFFICIENT_RESOURCES; - tmppath = WmiAllocate(path->Length + 1); + tmppath = WmiAllocate(path.Length + 1); if (!tmppath) { goto fail1; } - RtlCopyBytes(tmppath,path->Buffer, path->Length); + RtlCopyBytes(tmppath, path.Buffer, path.Length); status = STATUS_WMI_INSTANCE_NOT_FOUND; if ((session = FindSessionByInstanceAndLock(fdoData, instance)) == @@ -2387,7 +2376,7 @@ fail2: WmiFree(tmppath); fail1: - FreeUTF8String(path); + FreeUTF8String(&path); return status; } NTSTATUS -- 2.31.1.windows.1 From win-pv-devel-bounces@lists.xenproject.org Tue Sep 21 21:40:08 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 21 Sep 2021 21:40:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.191930.342097 (Exim 4.92) (envelope-from ) id 1mSnUj-00085o-Rj; Tue, 21 Sep 2021 21:40:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 191930.342097; Tue, 21 Sep 2021 21:40:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSnUj-00085e-OI; Tue, 21 Sep 2021 21:40:05 +0000 Received: by outflank-mailman (input) for mailman id 191930; Tue, 21 Sep 2021 21:40:04 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSnUi-0007sd-AU for win-pv-devel@lists.xenproject.org; Tue, 21 Sep 2021 21:40:04 +0000 Received: from mail.hldns.com (unknown [199.249.188.77]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7a3b4d52-1b24-11ec-b936-12813bfff9fa; Tue, 21 Sep 2021 21:40:02 +0000 (UTC) Received: from [192.168.0.73] (unknown [184.4.13.11]) by mail.hldns.com (Postfix) with ESMTPSA id B6D69104822; Tue, 21 Sep 2021 14:24:16 -0700 (MST) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 7a3b4d52-1b24-11ec-b936-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=hldns.com; s=mail-dkim; t=1632259456; bh=rjcGy/z4C1NFTPEvwVIl4ngakQuQkrmOjRE0ZAm3Ea8=; h=Date:Subject:From:To:Message-ID:References:In-Reply-To: Mime-version:Content-type; b=Ee/0795mScGPfpupCoWKQ47Wib0g7LJfihEb+dsqpqZRly66NFhLgW2SB0EFLjuft nUPLhmVZarTyXncCfyxra66Wsimb8UeXx3WhPFrgsvtiztj72GZ9IKSH9noMjMT3nt rt7dvksdNdZYfjfnTjlluKskMnMyp2pmTFyXjzg7UJluvESgAr1OJv3JeKZw2duxdZ YbZMlGQnScLt18PHJk/isk0xZcCdx0UqQdiZ9P/Y9uMcMEcw0MYBi+ygkzru1g3dxX RWmzmERp8D4BZ5TIX5foJ4d+6C4U2OQZ26xCL3dTMjkIfZxLTg02txaSyxqhbnZeCp ybLzqflEJkY9Q== User-Agent: Microsoft-MacOutlook/16.54.21091405 Date: Tue, 21 Sep 2021 14:24:15 -0700 Subject: Re: [win-pv-devel] v9.0.0 released From: Steffan Cline To: "Durrant, Paul" , "win-pv-devel@lists.xenproject.org" Message-ID: <65A03167-085F-4739-A657-97FA916D5DBF@hldns.com> Thread-Topic: [win-pv-devel] v9.0.0 released References: <127D8E68-6DE1-4A07-86FA-DACBAA848D64@hldns.com> <8538447a-b865-d439-04d1-70e8d9e127bc@alstadheim.priv.no> <994FF307-1541-4643-8607-657EDFEE297A@hldns.com> <6585eecaeb534b5eaabda44d5a841605@EX13D32EUC003.ant.amazon.com> In-Reply-To: <6585eecaeb534b5eaabda44d5a841605@EX13D32EUC003.ant.amazon.com> Mime-version: 1.0 Content-type: multipart/mixed; boundary="B_3715079056_725016615" > This message is in MIME format. Since your mail reader does not understand this format, some or all of this message may not be legible. --B_3715079056_725016615 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: quoted-printable Paul, Back in 2019 you provided the attached sample .cfg file taking advantage of= the latest drivers. At that time I was on 4.8 and I think you were on 4.13.= =20 I am now using 4.15 on Oracle Linux 8 and am wondering if you can share you= r latest .cfg file again so I can advantage of the latest and greatest of ev= erything which I may have missed in the docs. Odd request but I=E2=80=99d really appreciate it! =20 Thank you, Steffan Cline steffan@hldns.com 602-793-0014=20 =20 =EF=BB=BFOn 12/11/19, 1:30 AM, "win-pv-devel on behalf of Durrant, Paul" wrote: Can someone post a log of the qemu output (with xen_platform_log in the= events file) so we can see what the PV drivers are doing? I generally do most of my testing against the latest Xen (i.e. 4.13). 4= .8 should be fine though; the main differences from a Windoows PoV would be = in the viridian enlightenment code, but that's orthogonal to the PV driver i= nterfaces. I've trimmed out the cruft from the config I normally used and attached= it. (I also normally boot Xen with a grant frame limit of 128, i.e. 4x the = default). Paul > -----Original Message----- > From: win-pv-devel On Beh= alf > Of Steffan Cline > Sent: 10 December 2019 21:42 > To: win-pv-devel@lists.xenproject.org > Subject: Re: [win-pv-devel] v9.0.0 released >=20 > H=C3=A5kon, this is what prompted me to ask everyone what cfg is being us= ed > with these new drivers in case it's a conflict caused by a flag/optio= n I'm > using. >=20 > Paul, since these work for you, can you please share what you're usin= g to > ensure we're not using something in conflict? > > On another note, is there a specific xen version we should be using? >=20 > # rpm -qa | grep xen > xen-libs-4.8.5.75.g4c666a7e15-1.el7.x86_64 > xen-ovmf-20160905-1.gitbc54e50e0.el7.x86_64 > xen-hypervisor-4.8.5.75.g4c666a7e15-1.el7.x86_64 > centos-release-xen-common-8-7.el7.centos.x86_64 > xen-licenses-4.8.5.75.g4c666a7e15-1.el7.x86_64 > xen-runtime-4.8.5.75.g4c666a7e15-1.el7.x86_64 > centos-release-xen-8-7.el7.centos.x86_64 > xen-4.8.5.75.g4c666a7e15-1.el7.x86_64 >=20 >=20 > Thank you, > Steffan Cline > steffan@hldns.com > 602-793-0014 >=20 >=20 > =EF=BB=BFOn 12/10/19, 2:12 PM, "win-pv-devel on behalf of H=C3=A5kon Alstadheim= " pv-devel-bounces@lists.xenproject.org on behalf of > hakon@alstadheim.priv.no> wrote: >=20 >=20 > Den 09.12.2019 22:20, skrev Steffan Cline: > > Does anyone have a specific config file they'd like to share th= at > performs well with these newest drivers? > > > > On my Win 2016 Server, I removed the 8.2 drivers, rebooted, > installed these and rebooted. It's been loading for about 30 minutes = with > the spinning dots non-stop. > > > Same here. Restored disk image from backup and tried again, and g= ot > same > second time. Left it for a day, still spinning. After destroying = it, > at > some point I got "Can not access boot device" in the middle of t= hat > pale blue screen. Trying to roll back using recovery point fails. > (That > is the extent of the error message, just restore failed) . It /do= es/ > show me the possible points I can revert to though, so it looks l= ike > it > is working until it doesen't. For the record I also uninstalled o= ld > drivers first. First time around I also removed the Spice-thingy, > leaving only Qemu. Second time around I left both the Qemu and Sp= ice > stuff in. >=20 > Going back to that image is rather painful, as the disk image tak= es > forever to copy to a new partition, and the backup I have is seve= ral > windows-updates old, and insist on running a backup first thing w= hen > it > gets moving :-/ . >=20 > Did a chkdsk from the installation-iso (which boots nicely with t= he > same > config, except for "boot=3D'dc'"). Found some minor nits w\chkdsk. = Am > now > trying to boot into safemode minimal. Not even a spinner showing, > "Times" column in the "xl list" display increases by about 0.4 ev= ery > second, so it is doing /something/ ... >=20 >=20 >=20 > _______________________________________________ > win-pv-devel mailing list > win-pv-devel@lists.xenproject.org > https://lists.xenproject.org/mailman/listinfo/win-pv-devel >=20 >=20 >=20 > _______________________________________________ > win-pv-devel mailing list > win-pv-devel@lists.xenproject.org > https://lists.xenproject.org/mailman/listinfo/win-pv-devel _______________________________________________ win-pv-devel mailing list win-pv-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/win-pv-devel --B_3715079056_725016615 Content-type: application/octet-stream; name="win10-1809-1[2].cfg"; x-mac-creator="4F50494D" Content-disposition: attachment; filename="win10-1809-1[2].cfg" Content-transfer-encoding: base64 IyBUaGlzIGNvbmZpZ3VyZXMgYW4gSFZNIHJhdGhlciB0aGFuIFBWIGd1ZXN0CmJ1aWxkZXIg PSAiaHZtIgojYmlvcz0ib3ZtZiIKCiMgR3Vlc3QgbmFtZQpuYW1lID0gIndpbjEwLTE4MDkt MS5odm0iCgojIDEyOC1iaXQgVVVJRCBmb3IgdGhlIGRvbWFpbiBhcyBhIGhleGFkZWNpbWFs IG51bWJlci4KIyBVc2UgInV1aWRnZW4iIHRvIGdlbmVyYXRlIG9uZSBpZiByZXF1aXJlZC4K IyBUaGUgZGVmYXVsdCBiZWhhdmlvciBpcyB0byBnZW5lcmF0ZSBhIG5ldyBVVUlEIGVhY2gg dGltZSB0aGUgZ3Vlc3QgaXMgc3RhcnRlZC4KI3V1aWQgPSAiWFhYWFhYWFgtWFhYWC1YWFhY LVhYWFgtWFhYWFhYWFhYWFhYIgoKIyBFbmFibGUgTWljcm9zb2Z0IEh5cGVyLVYgY29tcGF0 aWJpbGUgcGFyYXZpcnR1YWxpc2F0aW9uIC8KIyBlbmxpZ2h0ZW5tZW50IGludGVyZmFjZXMu IFR1cm5pbmcgdGhpcyBvbiBjYW4gaW1wcm92ZSBXaW5kb3dzIGd1ZXN0CiMgcGVyZm9ybWFu Y2UgYW5kIGlzIHRoZXJlZm9yZSByZWNvbW1lbmRlZAp2aXJpZGlhbiA9IFsgJ2Jhc2UnLCAn ZnJlcScsICd0aW1lX3JlZl9jb3VudCcsICdyZWZlcmVuY2VfdHNjJywgJ2hjYWxsX3JlbW90 ZV90bGJfZmx1c2gnLCAnYXBpY19hc3Npc3QnLCAnY3Jhc2hfY3RsJywgJ3N0aW1lcicsICdo Y2FsbF9pcGknIF0gCiN2aXJpZGlhbj0wCgojaGFwID0gMAoKIyBJbml0aWFsIG1lbW9yeSBh bGxvY2F0aW9uIChNQikKbWVtb3J5ID0gNDA5NgoKIyBNYXhpbXVtIG1lbW9yeSAoTUIpCiMg SWYgdGhpcyBpcyBncmVhdGVyIHRoYW4gYG1lbW9yeScgdGhlbiB0aGUgc2xhY2sgd2lsbCBz dGFydCBiYWxsb29uZWQKIyAodGhpcyBhc3N1bWVzIGd1ZXN0IGtlcm5lbCBzdXBwb3J0IGZv ciBiYWxsb29uaW5nKQptYXhtZW0gPSA0MDk2Cm1taW9faG9sZSA9IDIwNDgKCiMgTnVtYmVy IG9mIFZDUFVTCnZjcHVzID0gNAoKIyBOZXR3b3JrIGRldmljZXMKIyBBIGxpc3Qgb2YgJ3Zp ZnNwZWMnIGVudHJpZXMgYXMgZGVzY3JpYmVkIGluCiMgZG9jcy9taXNjL3hsLW5ldHdvcmst Y29uZmlndXJhdGlvbi5tYXJrZG93bgp2aWYgPSBbICd0eXBlPWlvZW11LG1vZGVsPWUxMDAw LGJyaWRnZT14ZW5icjAnLCAndHlwZT1pb2VtdSxtb2RlbD1lMTAwMCxicmlkZ2U9eGVuYnIx JyBdCgojIERpc2sgRGV2aWNlcwojIEEgbGlzdCBvZiBgZGlza3NwZWMnIGVudHJpZXMgYXMg ZGVzY3JpYmVkIGluCiMgZG9jcy9taXNjL3hsLWRpc2stY29uZmlndXJhdGlvbi50eHQKZGlz ayA9IFsgJ2Zvcm1hdD1yYXcsdmRldj1oZGEsYWNjZXNzPXJ3LHRhcmdldD0vcm9vdC93aW4x MC0xODA5LXB2MS5pbWcnIF0KCiMgR3Vlc3QgVkdBIGNvbnNvbGUgY29uZmlndXJhdGlvbiwg ZWl0aGVyIFNETCBvciBWTkMKI3NkbCA9IDEKdm5jID0gMQp2bmNsaXN0ZW49IjAuMC4wLjAi CnZuY3VudXNlZD0xCgojdmdhPSJub25lIgp2Z2E9InN0ZHZnYSIKdmlkZW9yYW09MTYKI3Zn YT0iY2lycnVzIgoKcGFlPTEKbng9MQoKeGVuX3BsYXRmb3JtX3BjaT0xCgp1c2I9MQp1c2Jk ZXZpY2U9Wyd0YWJsZXQnXQoKZGV2aWNlX21vZGVsX2FyZ3M9WyAiLXRyYWNlIiwgImV2ZW50 cz0vcm9vdC9ldmVudHMiIF0KCmFjcGk9MQphY3BpX3MzPTAKYWNwaV9zND0wCmFjcGlfbGFw dG9wX3NsYXRlPTEKCiNzZXJpYWw9InRjcDo6NDAwMCxzZXJ2ZXIsbm9kZWxheSxub3dhaXQi Cgo= --B_3715079056_725016615-- From win-pv-devel-bounces@lists.xenproject.org Wed Sep 22 09:50:23 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 22 Sep 2021 09:50:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.192361.342776 (Exim 4.92) (envelope-from ) id 1mSytR-0007fH-Jm; Wed, 22 Sep 2021 09:50:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 192361.342776; Wed, 22 Sep 2021 09:50:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSytR-0007f9-Gg; Wed, 22 Sep 2021 09:50:21 +0000 Received: by outflank-mailman (input) for mailman id 192361; Wed, 22 Sep 2021 09:50:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSytQ-0007f3-Jr for win-pv-devel@lists.xenproject.org; Wed, 22 Sep 2021 09:50:20 +0000 Received: from mail-wr1-x429.google.com (unknown [2a00:1450:4864:20::429]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 429003c4-05d6-41a1-b5c6-fbb0d5374d7b; Wed, 22 Sep 2021 09:50:19 +0000 (UTC) Received: by mail-wr1-x429.google.com with SMTP id t7so4835776wrw.13 for ; Wed, 22 Sep 2021 02:50:19 -0700 (PDT) Received: from [10.55.227.139] (54-240-197-238.amazon.com. [54.240.197.238]) by smtp.gmail.com with ESMTPSA id d2sm1658271wrc.32.2021.09.22.02.50.18 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Sep 2021 02:50:18 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 429003c4-05d6-41a1-b5c6-fbb0d5374d7b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=Kwzblfm95Mro/Fi+Sfmk7l+JyGLiaRJVbDIjOXLSWJo=; b=EuGiDiQvtTgE86BkELt4HRrgAMi4jKrBMRJyfe1JbYlCjYM2M0UJPvF9kY60A/FFL/ +6jtIHiiQz1eY5o9zg0153khINOlrlrDuJvthetzW9pBzeFJbw2XAFNak0uEwquYWnwh bQihVaJ7X6enh9T7g6b8Fdz6XhePYCVYtzQVKroAuyiIj6DQvSD7ZIGWt3li8OP33M9X l6d0aVStZh3/vmiZ2bz8ePpRMkpycO8Ztn2XuoXcpAgRFtC4hueXyFrpHX5HlPC0rfbz ardmHsNDNQQIBUmh0LWk6H61nIYm80sfrZCndJkIwPRLZdkJgKOD5Vcdn/Ede/DQwm7a 0ekQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=Kwzblfm95Mro/Fi+Sfmk7l+JyGLiaRJVbDIjOXLSWJo=; b=uompKx0KEJTmC1OTE3nNOt4D4jWpfgx4BwGcVXfiBHNYttyJVZ6Q7W/zNMlH40YDXN z/KdgvqoZh1pCJt5OoEuUXSdT/J9CdaQTDcVHcezAYblrleHf0BNUati5p/M0Pif0j+q ByJc4w40oMLC1HkiSa4q/EIhoDr8OorlhT4YRY8jbli39VxmqgLn5v6qV1lLnjRm/fa9 cHrl5mhVOwTUVmESNBndfJO5p09KeelzyEH6QpyPZbmKIdNgPdGWn8A4YjIrPWS4JpAh 2wsamGf0sopafexqk7KCG/BwkwtYUnkVmRIq8cf0fNkruQmLVwA4kNH/hwqukQK/SR9G U5Hg== X-Gm-Message-State: AOAM5331Q/l7Pu7jxe3euyGPIzSF4GQ7c9TVx1Ovj5UtZt+UXBHu0hck o/shssKSRNzJX4yZNEMJ9EMP3+uYSIMfUA== X-Google-Smtp-Source: ABdhPJx/KnKh0UwOJKZu6a7fAY5uWN5691jMHxYlr9dvXtRTFRVXEKjtfuo3K/A70skWsmIF78vYhA== X-Received: by 2002:a05:600c:a08:: with SMTP id z8mr9543411wmp.52.1632304218955; Wed, 22 Sep 2021 02:50:18 -0700 (PDT) Message-ID: <99ca75da-d906-9e4c-b0d3-7bbadb805501@gmail.com> Date: Wed, 22 Sep 2021 10:50:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.1.1 Reply-To: paul@xen.org Subject: Re: [win-pv-devel] v9.0.0 released Content-Language: en-US To: win-pv-devel@lists.xenproject.org References: <127D8E68-6DE1-4A07-86FA-DACBAA848D64@hldns.com> <8538447a-b865-d439-04d1-70e8d9e127bc@alstadheim.priv.no> <994FF307-1541-4643-8607-657EDFEE297A@hldns.com> <6585eecaeb534b5eaabda44d5a841605@EX13D32EUC003.ant.amazon.com> <65A03167-085F-4739-A657-97FA916D5DBF@hldns.com> From: "Durrant, Paul" In-Reply-To: <65A03167-085F-4739-A657-97FA916D5DBF@hldns.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 21/09/2021 22:24, Steffan Cline wrote: > Paul, > > Back in 2019 you provided the attached sample .cfg file taking advantage of the latest drivers. At that time I was on 4.8 and I think you were on 4.13. > > I am now using 4.15 on Oracle Linux 8 and am wondering if you can share your latest .cfg file again so I can advantage of the latest and greatest of everything which I may have missed in the docs. > > Odd request but I’d really appreciate it! > Hi Steffan, If you want all enlightenments that you should just be able to amend your .cfg to use: viridian = [ 'all' ] That way you always get everything that is there. I haven't really done much with Xen for a while so I don't have a .cfg to hand unfortunately. Cheers, Paul From win-pv-devel-bounces@lists.xenproject.org Wed Sep 22 09:51:57 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 22 Sep 2021 09:51:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.192369.342779 (Exim 4.92) (envelope-from ) id 1mSyuz-0007k7-OX; Wed, 22 Sep 2021 09:51:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 192369.342779; Wed, 22 Sep 2021 09:51:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSyuz-0007k0-La; Wed, 22 Sep 2021 09:51:57 +0000 Received: by outflank-mailman (input) for mailman id 192369; Wed, 22 Sep 2021 09:51:57 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSyuz-0007jp-AS for win-pv-devel@lists.xenproject.org; Wed, 22 Sep 2021 09:51:57 +0000 Received: from mail-wr1-x432.google.com (unknown [2a00:1450:4864:20::432]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 08a54dd1-dc20-4f7b-9060-f3acf3ce24c5; Wed, 22 Sep 2021 09:51:53 +0000 (UTC) Received: by mail-wr1-x432.google.com with SMTP id t18so5187942wrb.0 for ; Wed, 22 Sep 2021 02:51:53 -0700 (PDT) Received: from [10.55.227.139] (54-240-197-238.amazon.com. [54.240.197.238]) by smtp.gmail.com with ESMTPSA id y9sm6331628wmj.36.2021.09.22.02.51.51 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Sep 2021 02:51:52 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 08a54dd1-dc20-4f7b-9060-f3acf3ce24c5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=TFXvMFxUvbqWwemOPCpgYsL3D58zuK23O1mXXCn9orw=; b=IE3al4xfxMH4B7pntjI+aKF60qH9NNHVXQzzxVM962tmFWRL46A7u1x6g628qgWKmG WKF4m7Q0Abw3OzW9vvQDzL2zD4ynnOHQHwXSAyAjOZyfZfqUkbWisJRvFv5PO/9i6TmF nXdZKSI8yrzX2nwoE1sqV4rgq3ZVUXw2vmD+EDTPYsrXbcDUAzXH+WNJQHvzhGDLQ5W1 y864S7y4sgWWwFoeholu4QpZ5IxkTdnX8OiuC6+G+JCKmxJlYzDgnbU0t+fL62/qKASF ARybqkf30+b1HnntvqTZRZ1yw3zNCFy7gCtC1NL23nFNlJxOIgEnbV/UByw3Jw6u7nh8 BzZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=TFXvMFxUvbqWwemOPCpgYsL3D58zuK23O1mXXCn9orw=; b=3Sgo+J6f+ZMr6SfQMxwTzA0qweA76dzT0I/TLm0STFQek012K6O94f+xFO5vB63yFK bJaxULOrcOFCjeIjwpgJ06TmTQZ5+DZO+2yeiTa3fGmvqipA0Dbr3SDdNW6luwzYAc17 eAH10ajHcxALDznPiSmEQyTXlWQTl4HNwbiUUcktnGfMtLvfWNwVntpe0YAg6yOlNbgg M0deBLZxB6O8kIRNiiKf3xbh+TWI4wI4jfzZU02HEIhK2+PPLwdeUy684O75i4xB5WP9 2BL6LyuyrMnRiIB7cZU3JfCTEa42Tk1VSV/7PPSyjP8NCLRV3g1CzHFv567QT9VgrpEC B+ww== X-Gm-Message-State: AOAM530LqVExG6DZR6AhsF4noqVQEjyuLOngpP6i8CFiPizAhvrqKqDK wavTv4P0XUMYqtbu5++SzzpZHWwwXzttmA== X-Google-Smtp-Source: ABdhPJxddH0kJAd7zHdM8lUkx0fQo4s76NQIL8wDxH/0B9OIfIEx0kT843r1A1GjQXvRs0untP9sZw== X-Received: by 2002:a1c:1fd3:: with SMTP id f202mr9583389wmf.44.1632304312474; Wed, 22 Sep 2021 02:51:52 -0700 (PDT) Message-ID: <9075b31d-91af-a3c5-53fc-afdba07b66c1@gmail.com> Date: Wed, 22 Sep 2021 10:51:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.1.1 Reply-To: paul@xen.org Subject: Re: [PATCH 1/2] Refactor string conversion in wmi.c Content-Language: en-US To: win-pv-devel@lists.xenproject.org References: <20210921104552.76-1-owen.smith@citrix.com> From: "Durrant, Paul" In-Reply-To: <20210921104552.76-1-owen.smith@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 21/09/2021 11:45, Owen Smith wrote: > Colocates related string functions, removes unused functions, adjusts > whitespace and reformats functions into a consistant code style. > There are no functional changes > > Signed-off-by: Owen Smith Acked-by: Paul Durrant From win-pv-devel-bounces@lists.xenproject.org Wed Sep 22 09:55:50 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 22 Sep 2021 09:55:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.192377.342783 (Exim 4.92) (envelope-from ) id 1mSyyj-0007rk-2V; Wed, 22 Sep 2021 09:55:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 192377.342783; Wed, 22 Sep 2021 09:55:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSyyi-0007rd-Vw; Wed, 22 Sep 2021 09:55:48 +0000 Received: by outflank-mailman (input) for mailman id 192377; Wed, 22 Sep 2021 09:55:47 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSyyh-0007rX-Ps for win-pv-devel@lists.xenproject.org; Wed, 22 Sep 2021 09:55:47 +0000 Received: from mail-wr1-x42e.google.com (unknown [2a00:1450:4864:20::42e]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8670346f-00e8-4559-a61c-d53edde02f3d; Wed, 22 Sep 2021 09:55:46 +0000 (UTC) Received: by mail-wr1-x42e.google.com with SMTP id q26so4994283wrc.7 for ; Wed, 22 Sep 2021 02:55:46 -0700 (PDT) Received: from [10.55.227.139] (54-240-197-238.amazon.com. [54.240.197.238]) by smtp.gmail.com with ESMTPSA id g143sm5610450wme.16.2021.09.22.02.55.45 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Sep 2021 02:55:45 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 8670346f-00e8-4559-a61c-d53edde02f3d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=WqQazfJMhlCgiqawXSDuTRtBzh4CkNDzbiKPyqMA1S8=; b=CxKyGdujGCgGLQ5B2YhVHeGilhy1r9zGWO6ZeDkbiZeU642kZh0D1HSsn27Wz3XBVA BGd+joADn4qtWT0MdikfuJ6AnbVIoH/3j8n6l97XhXJYQbVRcSO1TbmAKuI6KZIcQ+H/ vlY7FGJ5MCxkOE6Iia8Zw8VJv68E/jtSEGViVI9Q1M7kJVl2SdllPtcJjyzmSy8kOwZc srgPWo9PXq/Cgjp4thVf1MSag9t05z1wBA77JjI/EpcC+P8d0nDXbBlmL2fM7tCPXT1b 4d6O3dw+3lnwIMCi4cEh4S9Q/MFtnFWqDS5ikIM7Ex2zYPPme60eqV7fra9JLfY81QO9 3O4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=WqQazfJMhlCgiqawXSDuTRtBzh4CkNDzbiKPyqMA1S8=; b=xc961DrRi2aYTcvpRILwS8xYWsP+HPcjeOIHmePAavqRaZZYnnNewAn99Lz5LNJ0cL V2FcJL+DzUrDG/k7D1KzPC273yBPIhXBbiZQVHcCssiwhn1SazO7qdDRLw7VNf+AcoQh aoWsdFA7sgls7XaDtv0zzL9sATtklHRZLvxpfnYELagv9Vsx9+zUV87ymB5BclKGHV4G YyKSt4X4OfFMPv6j41MquvVveSmGmXZ6sDhZ/jL4r+gs9i0kGxi3GzY8QCYpyvmcTZgC It4oVVQm9lqVSkmTD96rJYvH7FjmlavRL85gE9Y1IgsqNXSNpyVS7fWnr+mgDdLiXgyT eayg== X-Gm-Message-State: AOAM531qCvzJxtsKLtAlabHpckcJU31vfbC+6Nr4KfPRqGgs/9bshqOg xAsN+PgRIkFlFxsVpeQCm3Bx85bycpBRLA== X-Google-Smtp-Source: ABdhPJwmcxhNfnzh2FpmUVgIQrqIQAMIblGLk1NQGlcmwSmuI4UF5wj1TeZvwzc8aGZWddCKQDCZUg== X-Received: by 2002:adf:fcca:: with SMTP id f10mr40797722wrs.304.1632304546109; Wed, 22 Sep 2021 02:55:46 -0700 (PDT) Message-ID: Date: Wed, 22 Sep 2021 10:55:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.1.1 Reply-To: paul@xen.org Subject: Re: [PATCH 2/2] Replace UTF8_STRING with OEM_STRING Content-Language: en-US To: win-pv-devel@lists.xenproject.org References: <20210921104552.76-1-owen.smith@citrix.com> <20210921104552.76-2-owen.smith@citrix.com> From: "Durrant, Paul" In-Reply-To: <20210921104552.76-2-owen.smith@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 21/09/2021 11:45, Owen Smith wrote: > The UTF8 conversion functions treat UTF8_STRING as: > struct { > USHORT Length; > CHAR Buffer[ANYSIZE_ARRAY]; > } UTF8_STRING; > > But UTF8_STRING is defined by later WDKs as: > struct { > USHORT Length; > USHORT MaximumLength; > PCHAR Buffer; > } UTF8_STRING; > > This difference leads to an 0x3B BSOD when anything attempts to use any WMI > method that deals with strings. > > Replace UTF8_STRING with OEM_STRING which is available in all WDKs, and has > the same definition as UTF8_STRING from later WDKs, simplifying the usage > of retrieving strings from, or putting strings into, WMI buffers. > > Signed-off-by: Owen Smith Acked-by: Paul Durrant From win-pv-devel-bounces@lists.xenproject.org Wed Sep 22 11:13:15 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 22 Sep 2021 11:13:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.192501.342978 (Exim 4.92) (envelope-from ) id 1mT0Bd-0001CJ-Jv; Wed, 22 Sep 2021 11:13:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 192501.342978; Wed, 22 Sep 2021 11:13:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mT0Bd-0001CC-Gy; Wed, 22 Sep 2021 11:13:13 +0000 Received: by outflank-mailman (input) for mailman id 192501; Wed, 22 Sep 2021 11:13:12 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mT0Bc-0001C6-0n for win-pv-devel@lists.xenproject.org; Wed, 22 Sep 2021 11:13:12 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" Date: Wed, 22 Sep 2021 11:13:02 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <16077058.19.1632309183046.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> Subject: XENIFACE-master - Build #107 - Successful MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_18_31735040.1632309182562" X-Jenkins-Job: XENIFACE-master X-Jenkins-Result: SUCCESS ------=_Part_18_31735040.1632309182562 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #107. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENIFACE-master/107/console to view the results. ------=_Part_18_31735040.1632309182562-- From win-pv-devel-bounces@lists.xenproject.org Thu Sep 23 14:54:20 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 23 Sep 2021 14:54:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.194360.346242 (Exim 4.92) (envelope-from ) id 1mTQ78-0003zg-Kb; Thu, 23 Sep 2021 14:54:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 194360.346242; Thu, 23 Sep 2021 14:54:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mTQ78-0003zY-HZ; Thu, 23 Sep 2021 14:54:18 +0000 Received: by outflank-mailman (input) for mailman id 194360; Thu, 23 Sep 2021 14:54:17 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mTQ77-0003z9-RC for win-pv-devel@lists.xenproject.org; Thu, 23 Sep 2021 14:54:17 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1b6080bb-7a82-407d-bfab-17f5e96765c9; Thu, 23 Sep 2021 14:54:17 +0000 (UTC) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 1b6080bb-7a82-407d-bfab-17f5e96765c9 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1632408856; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=BLPzq513JZeq4A6fnGekx0W48s2ZgEeP17se/TeepTs=; b=N/gVLEqu5ZL/s1r9Lw5yz8a5Ys1YisBizy0l/6Bd8dJLvo8+DisJTA3C y4iVkC9aBg+q5jpVCwqowrixzwKh+YLygPymvD9Vgcfa2gVUvVedeX7Vc S9Lhan0nFoIRWHL11warIjMiHlnvNW2InvXlB/mnWfmAGWR0VpG1W0ahj Y=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 2utJiWpZOaW7r6AjTjXzxq2S5L4xdcx1qOnlsN0HTIn9xXtiQr2cOyu0H2gP1YtGJqFndDDLmY WcMLswEN/cIv3hH+zQHSVtA8dpuq3cbrXqKCacyT48kuSetEJwrsvk6grvn1xAyFcoNZGZk2wd C/B9GyuF6Qr6U/fwKrtBScqXl/963P5vgghomJbIQQTxggM+nzXSuy8qYMqBMuUfm2jbciYoQl /mS6MupnoJwV/ROdx69n4lYHIP7vMr8nC02vGJHK/4m3HPd4uRZFsZ7N+/Inqf1QKNztMqv2Bw r0m2vIbRryAcmPz6wtBlCry5 X-SBRS: 5.1 X-MesageID: 53446698 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:ND5ruqiXttqgpG/20MLvfgf/X161TBcKZh0ujC45NGQN5FlHY01je htvXG6GMv+ON2X8LYh3bNi/8ElSsZ/dyNBhGlY6rHg2HiIb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0FU/NtTo5w7Rg2t8y2oDga++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1tlr29SRwJYJHexvwQS0R+LH4kAbRJreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr KJCbmpXN1ba2rzwkOnTpupE36zPKOHsI44Z/GplzC3ZJf0nXYrCU+PB4towMDIY25sSQaiAN ppxhTxHZgTgTTFSFg0rN7EEjOqxjHf0QmFhgQfAzUYwyzeKl1EguFT3C/LKe9rPXdsQkkuGq 2bu+2XiHgpcJNGZ0SCC8H+nmqnIhyyTZW4JPOTmrLgw2gTVnzFNTk1NPbemnRWnom6det9fM GxKxjhwtaUqqWqUEYPBRhLt9RZooSUgc9ZXFuQ77iSExazV/xuVCwA4c9JRVDA1nJRpHmFwi Ddli/usXGY24eDJEBpx45/J9WvaBMQDEYMVicbopyM+6t//qckYihvVR76P+4bk04WoQVkcL 92MxRXSZon/b+ZXjM1XHnid2lpAQ6QlqCZvvW07uUr/smtEiHaNPdDA1LQixa8owHylZleAp mMYvMOV8foDC5qA/ATUHr5XR+rxv63bamyN6bKKI3XH3272k5JEVdoMiAyS2W8zappUEdMXS BW7VfxtCG97YyLxMP4fj3OZAMU216nwfekJpdiOBueilqNZLVfdlAk3PBb49zm0zCAEzPFuU b/GIJ3EJStLVsxaIM+eGr51PUkDnXtlmws+hPnTknya7FZpTCTOFOhZYAfQNLBRAWHtiFy9z uuz/vCik313ONASqAGNmWLKBVxVf3U9G77srMlbKryKLgZ8QTlzAP7N27IxPYdimv0NxOvP+ 3i8XG5eyUb+2iKbeVnbNCg7ZeO9R4t7oFI6ITcoYQSi1U88bNv996wYbZY2I+UqrbQx0f5uQ vAZUMycGfATGC/f8jEQYMCl/oxvfRimnyyUOC+hbGRtdpJsXVWRqNTlYhHu5G8FCS/u7Zkyp Lip1wX6R5sfRls9UJaKOaz3l17o5CoTguN/WUfMM+J/QkS0/dg4MTH1g982P9oIdUfJyAyF2 lvEGhwfv+TM/dM4qYGbmaCeoo61OOJiBU4GTXLD5LO7OCSGrGquxYhMDLSBcTzHDT6m/ayjY aNezu3mMe1Bl1FP6tIuH7FuxKM4xt3uu74FkVg0QCSVNwymWuF6P32L/chTrakclLZWtDy/V l+L5tQHa66CP9noEQJJKQcoBghZOSr4RtUGASwJHXjH IronPort-HdrOrdr: A9a23:RGF4bqqmT1DhKC3IApMtbgkaV5oCeYIsimQD101hICG9JPbo7/ xG+85rsSMc6QxhPU3J+7i7UpVoJEmwyXcb2+Us1NuZMzUO21HYTr2Kj7GD/9S6IVyGygc178 4JGJSWbuefMbEQt7eY3ODXKbcdKHbsytHSuQ9zpU0dKj2DystbnmFENjo= X-IronPort-AV: E=Sophos;i="5.85,316,1624334400"; d="scan'208";a="53446698" From: Owen Smith To: CC: Owen Smith Subject: [PATCH] Use vs2019 projects for VS 16.0 Date: Thu, 23 Sep 2021 15:53:47 +0100 Message-ID: <20210923145347.145-1-owen.smith@citrix.com> X-Mailer: git-send-email 2.31.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Fixes SDV build with EWDK22000, which fails with warning 4061 Signed-off-by: Owen Smith --- build.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.ps1 b/build.ps1 index 02a39ba..346d187 100644 --- a/build.ps1 +++ b/build.ps1 @@ -39,7 +39,7 @@ Function Build { Function SdvBuild { $visualstudioversion = $Env:VisualStudioVersion - $solutiondir = @{ "14.0" = "vs2015"; "15.0" = "vs2017"; "16.0" = "vs2017"; } + $solutiondir = @{ "14.0" = "vs2015"; "15.0" = "vs2017"; "16.0" = "vs2019"; } $configurationbase = @{ "14.0" = "Windows 10"; "15.0" = "Windows 10"; "16.0" = "Windows 10"; } $arch = "x64" -- 2.31.1.windows.1 From win-pv-devel-bounces@lists.xenproject.org Wed Sep 29 08:14:21 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 29 Sep 2021 08:14:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.198794.352478 (Exim 4.92) (envelope-from ) id 1mVUjM-0006bI-5r; Wed, 29 Sep 2021 08:14:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 198794.352478; Wed, 29 Sep 2021 08:14:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mVUjM-0006bB-2r; Wed, 29 Sep 2021 08:14:20 +0000 Received: by outflank-mailman (input) for mailman id 198794; Wed, 29 Sep 2021 08:14:19 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mVUjL-0006az-8a for win-pv-devel@lists.xenproject.org; Wed, 29 Sep 2021 08:14:19 +0000 Received: from mail-wr1-x435.google.com (unknown [2a00:1450:4864:20::435]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id bc73cc18-ded9-4bcf-b887-9b37a9d1a07d; Wed, 29 Sep 2021 08:14:18 +0000 (UTC) Received: by mail-wr1-x435.google.com with SMTP id h15so1163942wrc.3 for ; Wed, 29 Sep 2021 01:14:18 -0700 (PDT) Received: from [10.55.227.129] (54-240-197-234.amazon.com. [54.240.197.234]) by smtp.gmail.com with ESMTPSA id r2sm825409wmq.28.2021.09.29.01.14.16 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Sep 2021 01:14:17 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: bc73cc18-ded9-4bcf-b887-9b37a9d1a07d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=04cB5Nto/WUXy+OG9oSiuxgKgATBIuqWlZZakRWAM3o=; b=a0m7OQpghu5UvrONTsTuoG6eFk+aDkTBOJUGZM8NEKuUd9lxLerQw7FIror/tL3XYX KsiFpZOOxw7L4osQIHnfyd23n5ujL0Na7hdUQOx+UlF+9Xv/cQlOHtQ7O/G2cCNM4pCk w9qB/nmsVk/K+uurqcntSSmp7qKm3CLbnWIg+qUhQydObEX1RTr5mQ67slTWWy7DWioS A/OqU0zu9WuvusSX7NaiYNXiOlSstcmKudq8Vj1C2kPMnU/a0Oy/Rwz99cQr9hzBpRfZ fJksBcl4v34F+FnsXpq2kq09xu/BMZqYrVt7iXtxSQeOJKu/jJpL1SxkbBMnUBJjWSv6 5b4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=04cB5Nto/WUXy+OG9oSiuxgKgATBIuqWlZZakRWAM3o=; b=d1OzquTWz4snYh1C3E6qtWEwDJbEOhmc8DAwxrXpNv+pxqZDXeI0/hYb2q3weUEN+t egwoKwcac3jLBxU8brslenKevGdLoXO9knhvrISc8shPCkWicAEwpMaDU/KDlH1YhtI1 ZKQamlznUVNoYBo5vi9xexrkeg5nwbZwk6k8Vp6pDvHNH2wE87qgnwz+eSAqOAM3tlhQ lkC/s188YqlWejVZeLTroU+WONY431i8yZXdltVtbkDaBVicDWSLwPbo+8OSApCOtAOO ZxLlZKWPZ7yGxN5gb3NVo8QmG9v0xXOy3Ng38Lz0Uqm3IVoLXjklwqzpFj+gdOVOy6WX xGug== X-Gm-Message-State: AOAM532coFedNFHLZ/nWx6AIZroewxomtmVmOzGW0Rk7N3lcLjNAul60 PYaxnWYtMPhSAfasvtJxpyNoGKepuwSFnw== X-Google-Smtp-Source: ABdhPJzBAMeEhufGTa21HjBivPOEX4GtsB2p1xIGl+Mj1Ws+CKLadtFC6Tv3edrwKJYh75ovn2qLbw== X-Received: by 2002:adf:f48b:: with SMTP id l11mr5183111wro.254.1632903257651; Wed, 29 Sep 2021 01:14:17 -0700 (PDT) Message-ID: Date: Wed, 29 Sep 2021 09:14:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.1.1 Reply-To: paul@xen.org Subject: Re: [PATCH] Use vs2019 projects for VS 16.0 Content-Language: en-US To: win-pv-devel@lists.xenproject.org References: <20210923145347.145-1-owen.smith@citrix.com> From: "Durrant, Paul" In-Reply-To: <20210923145347.145-1-owen.smith@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 23/09/2021 15:53, Owen Smith wrote: > Fixes SDV build with EWDK22000, which fails with warning 4061 > > Signed-off-by: Owen Smith Acked-by: Paul Durrant > --- > build.ps1 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/build.ps1 b/build.ps1 > index 02a39ba..346d187 100644 > --- a/build.ps1 > +++ b/build.ps1 > @@ -39,7 +39,7 @@ Function Build { > > Function SdvBuild { > $visualstudioversion = $Env:VisualStudioVersion > - $solutiondir = @{ "14.0" = "vs2015"; "15.0" = "vs2017"; "16.0" = "vs2017"; } > + $solutiondir = @{ "14.0" = "vs2015"; "15.0" = "vs2017"; "16.0" = "vs2019"; } > $configurationbase = @{ "14.0" = "Windows 10"; "15.0" = "Windows 10"; "16.0" = "Windows 10"; } > $arch = "x64" > > From win-pv-devel-bounces@lists.xenproject.org Wed Sep 29 09:28:14 2021 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 29 Sep 2021 09:28:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.198926.352680 (Exim 4.92) (envelope-from ) id 1mVVsq-0007sq-Ps; Wed, 29 Sep 2021 09:28:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 198926.352680; Wed, 29 Sep 2021 09:28:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mVVsq-0007sh-MY; Wed, 29 Sep 2021 09:28:12 +0000 Received: by outflank-mailman (input) for mailman id 198926; Wed, 29 Sep 2021 09:28:11 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mVVso-0007qL-W1 for win-pv-devel@lists.xenproject.org; Wed, 29 Sep 2021 09:28:10 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" Date: Wed, 29 Sep 2021 09:28:13 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <998594.21.1632907694183.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> Subject: XENNET-master - Build #117 - Successful MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_20_4765577.1632907693652" X-Jenkins-Job: XENNET-master X-Jenkins-Result: SUCCESS ------=_Part_20_4765577.1632907693652 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #117. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENNET-master/117/console to view the results. ------=_Part_20_4765577.1632907693652--