From win-pv-devel-bounces@lists.xenproject.org Tue Apr 12 07:14:05 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 12 Apr 2022 07:14:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.303459.517733 (Exim 4.92) (envelope-from ) id 1neAiy-0007rr-4c; Tue, 12 Apr 2022 07:14:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 303459.517733; Tue, 12 Apr 2022 07:14:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1neAiy-0007rk-1H; Tue, 12 Apr 2022 07:14:04 +0000 Received: by outflank-mailman (input) for mailman id 303459; Tue, 12 Apr 2022 07:14:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1neAiw-0007rc-W2 for win-pv-devel@lists.xenproject.org; Tue, 12 Apr 2022 07:14:03 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1ec51527-ba30-11ec-a405-831a346695d4; Tue, 12 Apr 2022 09:14:00 +0200 (CEST) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 1ec51527-ba30-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1649747640; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=OLyaMYlz0iKc7FpTnx0suM9O5I01yMZEhWO2IaIt5q4=; b=AbCVLlWAhDfCVsfhNuB8H4mtGkRJVy1oYBtnc2eitvMelkusI+08oCOW qyv34QolgbVRZtpFwkW6LerkcrSLd/8oHCYuk6MmZHriHqZbqiVOTemwH hROr2SGIsFWdXk8VN7xTMArvp3YaflZfUFI3OY32gsmKsaJeRCmr+bfPw s=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 68663349 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:E52D6aLVijA+h4g1FE+Ro5UlxSXFcZb7ZxGr2PjKsXjdYENS3mMAz 2YeUWnQb6mNNGKnKosgbNi1oBsGsJXSz94yGQZlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh3tcy2YHR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 I1xrYzzeDswB5/dubkHUglZLnx8NIQTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq 6ZecmpUKEne2aTmm9pXScE17ignBM70MYVZoXRh0THxBvc6W5HTBa7N4Le02R9u1p4QRq2CN qL1bxJgVTmbaBF+Z20NUpE1neOPtCT5QThh/Qf9Sa0fvDGIkV0ZPKLWGMXUfJmSW4BZk1iVo krC/n/lGVcKOdqH0z2H/3mwwOjVkkvGtJk6TePisKQw2RvKmzJVWEZ+uUaHTeeR0nKmS5FuF 1UtyDsP8LIz5E2WE9v0dkjtyJKbhSI0V91VGuw8zQiCzKvI/gqUblQ5oi59hM8O75FvG2Fzv rOdt5awXGE07uXJIZ6I3u3MxQ5eLxT5OoPricUsaQIeq+fur4go5v4kZoYySfXl5jEZ9NyZ/ txrkMTcr+hL5SLo///ilbwiv95KjsKXJuLSzl+KNl9JFisjOOaYi3WAsDA3F8poIoeDVUWmt 3MZgcWY5+1mJcjTyH3SGLRdTOj0vavt3NjgbbhHRcZJG9OFoSDLQGytyGsmeBcB3jgsJFcFn 3M/SSsOvcQObRNGnId8Yp6rCtRC8EQTPY+NaxwgVfIXOsIZXFbepElGPBfMt0iwwBlEufxuY v+zLJfzZUv2/Iw6lVJasc9GiuR1rs3/rEuOLa3GI+OPjeLFNCHIE+9cWLZMB8hghJ65TMzu2 483H+OByglFUf24ZS/S8IUJKksNI2R9Dpfzw/G7vMbZeGKKxElJ5yft/I4c IronPort-HdrOrdr: A9a23:FOTom6FflDTU7CDbpLqFU5HXdLJyesId70hD6qkvc3Jom52j+P xGws526fatskdtZJhSo6H9BEDmewKRyXcV2/hdAV7GZmjbUQSTXfhfBOfZsl/d8mjFh5RgPM RbAudD4b/LfCBHZK/BiWHSebtBsbq6GeKT9JzjJh9WPFhXgspbnmNE43OgYytLrX59dP0E/f Snl696jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKXSSw71M7aXdi0L0i+W /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8y/T9aw+cyjpAVr4RGYFqjwpF5d1HL2xa1O Ukli1QfPibLUmhOV1d7yGdnTUImwxelEMKgWXo/0cL5/aJHA7SQvAx9L5xY1/X7VEts8p717 8O12WFt4BPBReFhyjl4cPUPisa3nZcjEBS59L7tUYvGLf2qYUh2LA37QdQCtMNDSj64IcoHK 1nC9zd/u9fdRefY2rCtmdizdSwVjBrdy32CHQqq4iQyXxbjXp5x0wXyIgWmWoB7os0T91B6/ 7fOqplmblSRosdbL57Bu0GXcyrY1a9Ci7kISaXOxDqBasHM3XCp9r+56g0/vijfNgSwJ47iP 36ISRlXK4JCjbT4OG1re52G0r2MRWAtBzWu7Nj26Q= X-IronPort-AV: E=Sophos;i="5.90,253,1643691600"; d="scan'208";a="68663349" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EaUReirPHmHQt20oqJN4gVPMHS6jwV2KCiFBOpeSE6OB2sbHRrbc9hgPXc9QVH3g/niwvaoMz4GWgWHKba/2Rgqd6kx2qIvHLY0XwLzk6EFIkyLVaAzmukoZObiXswOJ8dTs/CwPj7Z0nPYvlHJfJI/PjizIFLeH7Ph7erYUfSxCamp4yylm8QDx9sXwOpLDXXXa2VQMxqWmVNOZZSXkPNW5C/h9+ikU1wB0VMiyJwkjeiVum4TPFtW/cB4l/gB5RCrGcl16hJTQsYWkHa0715ykcCzXXxEgg0xXRI932QpciX9RdGBA2MpAAkmCFmo2MtTA7FuMTPb6YCnz1mt3Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tcV1tTyk7aKvhzrSqJ9pOEClXf2LjuQsfbyMKx6iWVg=; b=PQ0q9seIHS7kDFLfFdBnGDzdp+Ep64zmuFTi1QptL3BJZ6HePUj4wu41f8bQwMqqJU+hK/YFfF3Y84L0UNBiRzld8YzyMxViHbpUOchhaLHcv7ekQkP0Fol7VsorO71qsvhzmoG2CU5MdQoFwC6Ikg+hAdKSO6U/NGUV87BORni2ktwL1R/byoDRmHdPqUidxZ2GOEHE7aefs83sVHU+Gga4xZ1I3bQOw9Wo+e+JMNnz38KrD2+lCRIoL74FaWEOnnJaX59k8I/bdkMkVONzHBKaHm/rpEj3/V2uTh/Q3xkjbM20RBrZlQEtke1MrI0OlLYnNk3bPLFhE1B1GFRERA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tcV1tTyk7aKvhzrSqJ9pOEClXf2LjuQsfbyMKx6iWVg=; b=fwWxKtHKkgoP+/k0sMiZuwXPAGDT0Xu1Dgx04hVbBRL1U2w6Ia1sqmnEHL70CcWShl3oG0tJ/MAoD4bm8GWqRJY/jbdl7SBFYAXSPjYgakF+X34s/42wiyhoRNex6FORpANlS7s/WjFqAvT4IUHDqd8gAKxDUFRCmnsedv8muXA= From: Owen Smith To: Owen Smith , "win-pv-devel@lists.xenproject.org" Subject: RE: [PATCH] Use STATUS_PNP_REBOOT_REQUIRED in IRP_MN_START_DEVICE when a reboot is required Thread-Topic: [PATCH] Use STATUS_PNP_REBOOT_REQUIRED in IRP_MN_START_DEVICE when a reboot is required Thread-Index: AQHYPS83dn50NOlgFEW8U3SgHt6yKazr/0kQ Date: Tue, 12 Apr 2022 07:13:50 +0000 Message-ID: References: <20220321142307.114-1-owen.smith@citrix.com> In-Reply-To: <20220321142307.114-1-owen.smith@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 99290556-baf8-45c5-412d-08da1c53fee2 x-ms-traffictypediagnostic: SN6PR03MB3536:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kAgpkD/S3u7A83kjd2d869v3ZlbSli1ROp2diSQOBB2cGaRPteFsCgTIl/OI06rE6kGpwg7RSDi83f2v6Lx5YSGPE3W7nf19Dw7/VrycMnl+h1gX3oCR9vxovv4zmbExJvgaXHp2VJwI5y4lz3kUd56e+orZvgOBUwMejZ9g6c1LFTPtaY6xJB05EDRXQ+88HACQndhfoZQEnEXjLSTeJnNbwEaoD6N7P1cu230jRh7yJnU2VKyaO4elppm19c0Azn5+JyiYIFtb86f3e19uDhrnHRQL0bXdRTYQ9UagCc7VomhyQrjOQqZxtPmBeU2g8FwVBm3lea/k9P2H7T1czaBzWzyuN+FUh+EC2VtsHXw/oztLhjVTUav5XkV2Q2xfTb2n86+fZDxDCl5zITevZQ/I1psjS6CzAK4r9qHRV/ggZvHmdJE7XpvgzaY+Tcwe3J/ZWPApy8R+BPWxZ9PmufYhinYufURuY0difsg/U3jFMKDWCsanIReDZOY1q4hzoDav0SLlclORf6Web0bb79/wi7n+i+VAOr03U8Wzhi8N51Tv9lMvdUsEkY1AHkZ0sUS2PtiB70cWdtOHakg1kdJlmilExH2CYilaTC0Bc0EbublZ/XYpgN8YEfb9RuD+7873cMJUWMYvgajVVYLTaC6R2/E3zfgG3Or8EVr91xqBTv2Mp2UExc5+Od8u+hCeaMF6sPC1cWoygyk99lx4hg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5477.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66556008)(64756008)(66446008)(66476007)(86362001)(66946007)(55016003)(76116006)(38070700005)(8936002)(52536014)(33656002)(122000001)(82960400001)(44832011)(8676002)(5660300002)(71200400001)(508600001)(2906002)(316002)(110136005)(6506007)(53546011)(7696005)(38100700002)(9686003)(26005)(186003)(83380400001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ePrt9en1SDwFZUMZEJXMJWVBNqjqeajZYFaEM0OAqvRRg/3tUZQ4lXzlDvD/?= =?us-ascii?Q?3rtv7lopqyvngLj5aZHMQLLQSvBXgL3yyu+SvhJiLe5wKRs38NGGXUVofDYa?= =?us-ascii?Q?F5NF08WzYXI3T51BOqSpOVtDSdYqZ3CALQrTuj2xEBBl3Txyuvgu2goELGHm?= =?us-ascii?Q?xwfrzex+uvoaxQ4rjlY9wC8v9l69Rs0VfkwjJ6tXOxLqr247q5WphF+BTrgv?= =?us-ascii?Q?pcGSI8IfP3715/9LWqtIQ56om33hrDACeGB8ryd3A+wp/b8RaXWTFbJm3QJ6?= =?us-ascii?Q?Gb4kawAB9IdX3K4IKTXRfPsMWb29sed0zPUpYaBJHtZvRKJGK1qPeAstz60/?= =?us-ascii?Q?jDP00y+0tuemgltWAXFDUOe104EGaBtwOHztNVNBTvHwHInYkhL9a5a/3A8I?= =?us-ascii?Q?f7TyUFXB9tIQvtc68vxG6G5OwSVt9CnSHJ5E/h7+nbaELJoh0d6MjrYq+93D?= =?us-ascii?Q?mcjoxWSxr7hfyZxwUX6SNDCLMaS2lLG0YSYEGSa9sHEf55WSTAqLN7OvQquE?= =?us-ascii?Q?x4qTY6YOoP/aLhWfUjf5deK7OMvllhcL8xOvfGss2PjMjBNxgiV4p2EOIpfH?= =?us-ascii?Q?pHErYEVJKrpqKLodT49Ix/t5/B8utP6MThSJuf/YWyZcaed6FZVPG51DZmp2?= =?us-ascii?Q?bRnZpsV5wR/6ofQekb3AUACcV5cUkcW0hI7LtP/06qpim7oX0oHKPjHKwpy5?= =?us-ascii?Q?kBqRvbuFhpNFAF2Q7hyqjWduJUrGXVp1VP1GTwf6f1frpz9jzwkoEraqlGWE?= =?us-ascii?Q?mWCawWxjDOlrPc+hN4Gw3Ot7WURMeaKsf/JQfM/+Y4VITdemZ8oxaQEOdcPB?= =?us-ascii?Q?u6dxYYd/HIIFAFxKVHdKRePWo1finBvloQMxoSoS6OWYhzajwn6gR1nYP23X?= =?us-ascii?Q?+iD5T0sxzMh6A/t0clqfePdGGI3jutzuUmbHtGemCGVw7sZBpxMteIPONNUQ?= =?us-ascii?Q?jp/L0mV/jH8YJRxPNeft8oN7asOoPrKaC4eiKUIMYkAngSzA9ByQRM8ZCYDc?= =?us-ascii?Q?6amg6qljzQlx11xRnupWmQ5BrFmHkBB7CQ/jZrH0yvHtZBFHf/U5+fFgE/x+?= =?us-ascii?Q?N7naVuXSw7enD1LPBxv6lFgXx+oTTU1bdhPngBt/eJUT8JGfOMipfOGMxTOQ?= =?us-ascii?Q?/SnXkNmOedFpOOr9LK9pbopHYXOxKUkebAuV5xwM15Widsn8f7HhElT4LPms?= =?us-ascii?Q?ddt5F7BT46KvPZziV3MLgkv40bR7oWg7pE6JBocQ0hSbYfSPfugo5kxjKb1/?= =?us-ascii?Q?cc2PzkzqCi5ZHFQOYJ4UCsi5rTTFippURZMm75O3/Z6ycLWxwG75xUax4Vmn?= =?us-ascii?Q?avHttoYLE2Ye7CHEyCO1WhfMBpICm7ZKOWyLCsOIrm6eOAoGFjuO5M0SHWAc?= =?us-ascii?Q?jNxCEoNivgGKyDXUFClsTWsbWqaPk1/JV5ybzwIlUcQUQm3tA+uwAc1GeLHW?= =?us-ascii?Q?mVl5qOSFBKn4wAEkAQNDdwxW1Usnv6YYOOsOa0bytnDaB1hlorIBM4roP84G?= =?us-ascii?Q?rsrwoR0lzUZz/v8JUSDuHCRSao0CXKKaEuhvfJ7mrrO7z5rVZO9yIXIDQle2?= =?us-ascii?Q?NfzH5MT8wjfUxZwa6xuBW2MaIG4Ufoh7ECUp0D6n2q80PETo3/G75cLiJAB0?= =?us-ascii?Q?WH7FVxFkiN2lsqy4gbJKGtIVvA9fa1N7k8nK2G8jOvTZWK+E6ykRqmjoaIG3?= =?us-ascii?Q?5F7u8JpgbwNF+I4h5JUIqbyh002WVIF8FQ7RmTMZVCayWMD913RKidfqESiz?= =?us-ascii?Q?HoqAm7Ey+g=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5477.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 99290556-baf8-45c5-412d-08da1c53fee2 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2022 07:13:50.9200 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lnQGuLvxF8e0FZMv7X3NRJbkN4kZnE4w5AFK7JZ/YoXwGApf8IH3QkwgkXW4XA5JjspvDYnaIcF9LY9qEgE8tg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB3536 X-OriginatorOrg: citrix.com -----Original Message----- From: Owen Smith =20 Sent: 21 March 2022 14:23 To: win-pv-devel@lists.xenproject.org Cc: Owen Smith Subject: [PATCH] Use STATUS_PNP_REBOOT_REQUIRED in IRP_MN_START_DEVICE when= a reboot is required Failing IRP_MN_START_DEVICE can lead to WHQL distribution of drivers to be = rejected by MS, as too many VMs in the gradual rollout phase will report th= is error on update. Using STATUS_PNP_REBOOT_REQUIRED will indicate that the= VM requires a reboot, and should not be treated as a gating factor (it sho= uld also trigger the Windows Update process to report the reboot to users a= nd/or trigger an automatic reboot) Signed-off-by: Owen Smith --- src/xenvif/pdo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/xenvif/pdo.c b/src/xenvif/pdo.c index bc9b9ed..b3a4aae 100= 644 --- a/src/xenvif/pdo.c +++ b/src/xenvif/pdo.c @@ -1303,7 +1303,7 @@ PdoStartDevice( if (Pdo->HasAlias) { PdoUnplugRequest(Pdo, TRUE); =20 - status =3D STATUS_UNSUCCESSFUL; + status =3D STATUS_PNP_REBOOT_REQUIRED; goto fail9; } =20 -- 2.33.0.windows.2 From win-pv-devel-bounces@lists.xenproject.org Tue Apr 12 15:38:37 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 12 Apr 2022 15:38:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.303689.518129 (Exim 4.92) (envelope-from ) id 1neIbD-0008BN-Ez; Tue, 12 Apr 2022 15:38:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 303689.518129; Tue, 12 Apr 2022 15:38:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1neIbD-0008BG-CG; Tue, 12 Apr 2022 15:38:35 +0000 Received: by outflank-mailman (input) for mailman id 303689; Tue, 12 Apr 2022 15:38:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1neIbB-0008B7-8Q for win-pv-devel@lists.xenproject.org; Tue, 12 Apr 2022 15:38:33 +0000 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [2a00:1450:4864:20::432]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9b6046e6-ba76-11ec-a405-831a346695d4; Tue, 12 Apr 2022 17:38:32 +0200 (CEST) Received: by mail-wr1-x432.google.com with SMTP id t1so10582288wra.4 for ; Tue, 12 Apr 2022 08:38:31 -0700 (PDT) Received: from [10.7.237.11] (54-240-197-227.amazon.com. [54.240.197.227]) by smtp.gmail.com with ESMTPSA id bg20-20020a05600c3c9400b0037fa5c422c8sm2921678wmb.48.2022.04.12.08.38.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Apr 2022 08:38:29 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 9b6046e6-ba76-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=E1/uYT+LGNEJzsgjCIKUjsYEF+KVlm773/y1A3bpDZg=; b=OyesCr3NRARdzGVlvKTspy2IwjEynzUYeaa8uPk9KAzfzqotcTPCTmPA8eWRZxxCGX jjIFi6CdlKAT0WLC4utWimtxpcWDQhNEJuJ7RrpOGJXiwJtcHJS8j4vurBxLckmA8Q/P GyG/W2ogFgQ1mB09+Dbyuc4szC99yJrrjL44WCxUfkoHeLMoPHmV7TXs1N6L/+fNB0as DXE7zb5ZWnsWWazK7Nf/ukClpzerBg5hvbF9qb0fHmzZauoLXhMPNQICceVLR0z/Rgd0 kmEUqUH/Gu9Y7fbBm9vFkowbacpfMW7Pj77gXKIWDPuZKc/UEZZpoYMqBZl0WrFB2rKE Y9dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=E1/uYT+LGNEJzsgjCIKUjsYEF+KVlm773/y1A3bpDZg=; b=yiSSDe+50tcX12eFPjB5fGoWLnqNiAZrRtb4J79c6QlVu98rtvb1i+OoUti1DBenML 0R/ViG/rY+lKHNAge4U3S9PVOHa2ygfJcCFtTACxiNSYdzAeh5dzwNmEUBxtH3bgBgVl Vkn2uHGCn4iaZKt7p7I7FCoQlPZRT3uLGdPZ9l6nMogJUbdbQD/2BQm3jVTQ7Qwzk5Zm dhTa5B4BiCiJQmN1znS+5ajLotCfdx1rZK+Jl7iEULLGkpY5Tn5r/c6etQWm0QGuoHSZ 2EstqVBcEWk6lwCMI/cMb4xZw76BcPsuTAKOy4czZ3i4jlaFO6kIbYeaEnz4dWJeNZa1 mipA== X-Gm-Message-State: AOAM531YNKD58BWUpjvPB712ORmPgqybOPfPzFdAC/QoH3Y+QiNXJtxy 9Dr3316NnKME+wamta5Xcjc= X-Google-Smtp-Source: ABdhPJzC1VgQj1KhE0rrR/EQkA5bbYOgBHrgxvOk1MT0D7bsBLuhvkDlE1IoSY+LiE2wgOYwnRZaZA== X-Received: by 2002:adf:f1d1:0:b0:206:1303:ee49 with SMTP id z17-20020adff1d1000000b002061303ee49mr28898024wro.533.1649777910448; Tue, 12 Apr 2022 08:38:30 -0700 (PDT) Message-ID: Date: Tue, 12 Apr 2022 16:38:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Reply-To: paul@xen.org Subject: Re: [PATCH] Refactor Wmi.c Content-Language: en-US To: Owen Smith , "paul@xen.org" , "win-pv-devel@lists.xenproject.org" References: <20220330093223.659-1-owen.smith@citrix.com> <6b30173884a24369a061a9d9ba6bb595@EX13D32EUC003.ant.amazon.com> <28abd23c-3e72-4a6a-37aa-594a9a130334@gmail.com> From: "Durrant, Paul" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 31/03/2022 08:12, Owen Smith wrote: > -----Original Message----- > From: win-pv-devel On Behalf Of Durrant, Paul > Sent: Wednesday, March 30, 2022 11:11 AM > To: win-pv-devel@lists.xenproject.org > Subject: Re: [PATCH] Refactor Wmi.c > > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments unless you have verified the sender and know the content is safe. > > On 30/03/2022 11:07, Owen Smith wrote: >> -----Original Message----- >> From: Durrant, Paul >> Sent: 30 March 2022 10:40 >> To: Owen Smith ; >> win-pv-devel@lists.xenproject.org >> Subject: RE: [PATCH] Refactor Wmi.c >> >> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments unless you have verified the sender and know the content is safe. >> >>> -----Original Message----- >>> From: win-pv-devel On >>> Behalf Of Owen Smith >>> Sent: 30 March 2022 10:32 >>> To: win-pv-devel@lists.xenproject.org >>> Cc: Owen Smith >>> Subject: [EXTERNAL] [PATCH] Refactor Wmi.c >>> >>> CAUTION: This email originated from outside of the organization. Do >>> not click links or open attachments unless you can confirm the sender and know the content is safe. >>> >>> >>> >>> * Moves functions to be in related locations in file >>> * Formats code to appropriate code style >>> * Inlines some functions that are only called from 1 location >>> * Uses LIST_ENTRY macros to access linked lists >>> >>> Signed-off-by: Owen Smith >>> --- >>> src/xeniface/wmi.c | 3794 >>> ++++++++++++++++++++++---------------------- >>> 1 file changed, 1907 insertions(+), 1887 deletions(-) >> >> Eek. 3794 lines of change! That's almost impossible to review. Is there any chance you can break this down? >> >> Paul >> >> >> Its not easy to break down a refactor like this, 1 small change has many knock on changes throughout the file. >> Its probably easier to apply locally and compare side by side, but I'm >> not expecting this to be an easy or quick review - I probably should >> have posted 1st with RFC >> > > Can you assert that there is no functional change? I will consider taking it on trust if so. > > Paul > > > I've not made any functional changes, except for changes to how the LIST_ENTRY members are accessed - using the > standard LIST_ENTRY macros/functions rather than casting (this should not affect functionality, as the LIST_ENTRY > items are the 1st entry in their respective structures). > > I have run these changes, as part of the Citrix driver package (we don’t patch this file, but do rename/re-GUID the WMI > objects), through automated testing which validates the WMI interfaces. > > This patch was originally to clean up the code with the intent to track down a 0x139 (KERNEL_SECURITY_CHECK_FAILURE) > bugcheck, that indicated there was occasional LIST_ENTRY corruption. After these changes, I have not yet reproduced > the bugcheck > Ok. I'll take it as-is. Acked-by: Paul Durrant > Owen From win-pv-devel-bounces@lists.xenproject.org Tue Apr 12 15:45:30 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 12 Apr 2022 15:45:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.303697.518133 (Exim 4.92) (envelope-from ) id 1neIhu-0000gW-05; Tue, 12 Apr 2022 15:45:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 303697.518133; Tue, 12 Apr 2022 15:45:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1neIht-0000gP-Td; Tue, 12 Apr 2022 15:45:29 +0000 Received: by outflank-mailman (input) for mailman id 303697; Tue, 12 Apr 2022 15:45:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1neIhs-0000gI-8k for win-pv-devel@lists.xenproject.org; Tue, 12 Apr 2022 15:45:28 +0000 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [2a00:1450:4864:20::42b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 92efbe9b-ba77-11ec-a405-831a346695d4; Tue, 12 Apr 2022 17:45:27 +0200 (CEST) Received: by mail-wr1-x42b.google.com with SMTP id r13so28286946wrr.9 for ; Tue, 12 Apr 2022 08:45:27 -0700 (PDT) Received: from [10.7.237.11] (54-240-197-227.amazon.com. [54.240.197.227]) by smtp.gmail.com with ESMTPSA id p7-20020a5d4e07000000b002079a418430sm10893425wrt.85.2022.04.12.08.45.26 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Apr 2022 08:45:26 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 92efbe9b-ba77-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=hzb0gpJm27SZ5Gex4sslDbc2RZHpqac84gm8kERl1zc=; b=b4hme2VhIMiPEVwsiBtKZAO07KuXUbNSfwYXX6lTV+woF3zMyAgyVy/SwPfwONYiJX ml8ctIlmUpCPEEy2uTQfuo3X4a/5DaKlNTKs9sb2VsmAXchqyd4MY+730+yXTdNVnenp /4HPT6cjT96evigWEU1NdR0GY2aytKA2hehrMILNbOR6oLp0Uwi9rCq3Iun55AZqFggn dN8oCmpydT32yILg0Kmo5UHPGsuzYlGgBCBr9FJ80bFxgS1ABsagOjpbxeNJnT5np1Ki sMlFDHk2HqnIlAgiV+3tdr2KDeJfHy3DFQgsiwMOT/JFFF/KSh9LLDaPJYClWEf6fLuK GEbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=hzb0gpJm27SZ5Gex4sslDbc2RZHpqac84gm8kERl1zc=; b=gHsf/ZrcghXZ8fv6r/54qEg35TUP1DUOd096MUgZAlV7Y0iXULMDpO/eLDiMLwfCH6 LS+O2n2TlYJ0DmLkxUiOO9cV+9uoh3lREH6KJ9TggD1mIaoBSH2zqMr5YBoUo0ExmF2a 27l89z6aKe8b3Fmr5mMxqkcnHeSWSWPfjgpzFD2euTErU5poZGXBloxABE+nEYiQabp7 kaikot411tl5UJyNTtCw4vROc1kKn3p8FoIPdwz6AU8XDhG90mYAIn0mEhwiK3RBVXwb XqDuIOzEJIHU41p2WjFMOwdKbnWRzpmNz0QrdLaVAUj6hRBqPzMozsxBfzs+j3LhNf8y AiOg== X-Gm-Message-State: AOAM532VRGwgrYgPG8y5vg+TEu1J7ljo+OthKhEilWV/zN8LoOqd9nib G4xFlqzrDABkEzjjS0wAPJpKtQSHXnlprw== X-Google-Smtp-Source: ABdhPJzGNxIT1cSK/EbxgJLjlh/x5ZSg1AJ5LAdpTeXv5+iVXkyqu3GqMSVYuBIUzs63xz0jdNJPdA== X-Received: by 2002:adf:82c1:0:b0:207:9d8b:dd6c with SMTP id 59-20020adf82c1000000b002079d8bdd6cmr13575303wrc.4.1649778326788; Tue, 12 Apr 2022 08:45:26 -0700 (PDT) Message-ID: Date: Tue, 12 Apr 2022 16:45:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Reply-To: paul@xen.org Subject: Re: [PATCH 1/2] Move BlkifRing CacheCreate/Destroy to inline functions Content-Language: en-US To: win-pv-devel@lists.xenproject.org References: <20220330140211.909-1-owen.smith@citrix.com> From: "Durrant, Paul" In-Reply-To: <20220330140211.909-1-owen.smith@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 30/03/2022 15:02, Owen Smith wrote: > Signed-off-by: Owen Smith Acked-by: Paul Durrant From win-pv-devel-bounces@lists.xenproject.org Tue Apr 12 15:47:31 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 12 Apr 2022 15:47:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.303704.518137 (Exim 4.92) (envelope-from ) id 1neIjr-0000nH-66; Tue, 12 Apr 2022 15:47:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 303704.518137; Tue, 12 Apr 2022 15:47:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1neIjr-0000nA-3N; Tue, 12 Apr 2022 15:47:31 +0000 Received: by outflank-mailman (input) for mailman id 303704; Tue, 12 Apr 2022 15:47:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1neIjp-0000n4-Q5 for win-pv-devel@lists.xenproject.org; Tue, 12 Apr 2022 15:47:29 +0000 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [2a00:1450:4864:20::42f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id db6b95a1-ba77-11ec-a405-831a346695d4; Tue, 12 Apr 2022 17:47:28 +0200 (CEST) Received: by mail-wr1-x42f.google.com with SMTP id e8so11925286wra.7 for ; Tue, 12 Apr 2022 08:47:28 -0700 (PDT) Received: from [10.7.237.11] (54-240-197-227.amazon.com. [54.240.197.227]) by smtp.gmail.com with ESMTPSA id u7-20020a5d6da7000000b00203d9d1875bsm33450886wrs.73.2022.04.12.08.47.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Apr 2022 08:47:27 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: db6b95a1-ba77-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=Jof/UoFxSiHctTZbfzLDn3N+GG9Rt09eF8ksnmvAu3o=; b=Zn6pOo62kxSliTRuoFC7CqQ/p3542PHoZO2eqwlkheB8zDCJhDXSvZ3L4e862fwn5z RQCDQIQGFCv1tINOFuY8PNGThncpTq/0QQ87qJxnzCSLpYIpHUpKW205KC0nfwNNxPBV tTFnjaAW+8Srf4i88hGN6iYXqKmAGg/cCK4imG8oodnaflPj04skGp6DwqesnPf2sh2d dQtmQSLCWBXnx/yYw6OUG/fEjhG+4LsBVVzimTlijGMgjqndfHH76Nogjz2H/PCeccJt Sr9Inn5N292ORK4n+nmmZDYaImmkR9rknyk+bSVblQ1eyxDLkY1D78ySl+wIj6MJ3Zm+ E9Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=Jof/UoFxSiHctTZbfzLDn3N+GG9Rt09eF8ksnmvAu3o=; b=Akj9lfLLFNRWw2pVGtoBGUeooOAqgp5lw0jsEqOmd0RZStetXwB1ul4MYpyrKZq//O 0v6A3xruzmmphrbXZ1rQjFpMV6ogc1uh3k0CdVK9+vu1d6tpi/TZ2/j2H3XcrW4bwmox DuEOdmPzP64d6BQezGO362Ywe0gEmLSWd2FQ+7CiGMmm4iRxJ/zOO9Z6DPv6/5VDhksV AbwdZConbzdQmNMB7BPbcxUeCIEYl6f3JzZAV+IlnQMaUlyXiSPXcCSQOy3ugzW8hApc WPbzZqbd+TTy7sanKUJ50JxYP0L0rsSlMWrhenn2NcGWYkuOmGgtAJow8GfRdh9FAq1P Ylog== X-Gm-Message-State: AOAM530+BinTIIXAvQMzOPo6NxXCzeRcgu+s3c6j4tEIEY4HFOJKehqQ gyxgNMqe+jchHRGJJkiYL+XjU6uIKc9feg== X-Google-Smtp-Source: ABdhPJwU+61nhNCuZamNfXT0mT3J4rnFnjmv+V+XBOl/mNOh9PLioCmgNnNc+kTNqGXUM8WDnGj14Q== X-Received: by 2002:a5d:6b0f:0:b0:1e7:9432:ee8c with SMTP id v15-20020a5d6b0f000000b001e79432ee8cmr28782327wrw.216.1649778448410; Tue, 12 Apr 2022 08:47:28 -0700 (PDT) Message-ID: <0f3bed62-db7b-fc7f-ee28-7f63d3cd4804@gmail.com> Date: Tue, 12 Apr 2022 16:47:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Reply-To: paul@xen.org Subject: Re: [PATCH 2/2] Create/Destroy BlkifRing caches on Connect/Disconnect Content-Language: en-US To: win-pv-devel@lists.xenproject.org References: <20220330140211.909-1-owen.smith@citrix.com> <20220330140211.909-2-owen.smith@citrix.com> From: "Durrant, Paul" In-Reply-To: <20220330140211.909-2-owen.smith@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 30/03/2022 15:02, Owen Smith wrote: > Move cache creation to Connect after XENBUS_CACHE(Acquire) and cache > destruction to Disconnect before XENBUS_CACHE(Release) > > Signed-off-by: Owen Smith Acked-by: Paul Durrant From win-pv-devel-bounces@lists.xenproject.org Tue Apr 12 15:56:18 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 12 Apr 2022 15:56:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.303716.518152 (Exim 4.92) (envelope-from ) id 1neIsL-0002MJ-3N; Tue, 12 Apr 2022 15:56:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 303716.518152; Tue, 12 Apr 2022 15:56:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1neIsL-0002MC-0g; Tue, 12 Apr 2022 15:56:17 +0000 Received: by outflank-mailman (input) for mailman id 303716; Tue, 12 Apr 2022 15:56:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1neIsK-0002M6-8m for win-pv-devel@lists.xenproject.org; Tue, 12 Apr 2022 15:56:16 +0000 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [2a00:1450:4864:20::332]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1509748c-ba79-11ec-a405-831a346695d4; Tue, 12 Apr 2022 17:56:15 +0200 (CEST) Received: by mail-wm1-x332.google.com with SMTP id l9-20020a05600c4f0900b0038ccd1b8642so1789664wmq.0 for ; Tue, 12 Apr 2022 08:56:15 -0700 (PDT) Received: from [10.7.237.11] (54-240-197-227.amazon.com. [54.240.197.227]) by smtp.gmail.com with ESMTPSA id i5-20020adfb645000000b002060e559f24sm22975878wre.92.2022.04.12.08.56.13 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Apr 2022 08:56:14 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 1509748c-ba79-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=9yVEIZZLVKNAH/9Ho7gbKyw0NHjjZJgt1fnGLXf7BaE=; b=b1x+XFO1pWff5kOjjtRBmhh61Ow0t2rY0LxbjK7VuSFiD+gHe6ZHyZ5hG/rbpUGvhF e3a2gzFOp6Fn95T8digkoPZ9p3O3AjYxxztXKqQud5S+En5fAGpkTaii8KOX7gSHigIL ScPs1xNfqGRoyiXxqn0nIV3I/xM+jvm23En4ZaSV3YCTsZH3Q0yAz/ArUnwOeFzr1q6/ woQ7iujQwHIHY+aPjTxzJ8qhzGtECH6stUNpR/gM1GgTtqhUUF4HRPd/zyLbwwnahwCy GUQuLrErObeOGlHC4IWM9vPlGLOiBblv0DB6Wr3JpcWu+eyd1HOFEZQFG/EkhjwqVacx IwIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=9yVEIZZLVKNAH/9Ho7gbKyw0NHjjZJgt1fnGLXf7BaE=; b=g6ge5+U6pxzQKjYAoEHjMlamqiJaPm3D58MsYdwq40IkTe/aQBLrm7MAXCO8GVzv7c ZekCBdmVbo5xREcGt8dbg0scwYn2yrQZuXWVfK039yn8GzaLH98Xvw0AVImZVFysokLu Nsl4EaoEsMJtqBfc5jzmE5F9YQylrPxvcIXapUJyPezV2qyWcZSilEIGX6U5hiaUQE1u Jur3PkeH7nkAUVUExwL6fIKG6810LyVJW5N6CPX5a6LETlcxWoPpkc2gAeV1YFZgtJex 2bpobfuSBOsHKb2L+TuLEozvoUzvyu6EWzyc6IBw0A5s0P9pvFHdnAL1Sx6L+mazi6ya uAPQ== X-Gm-Message-State: AOAM533yzRNmZAL6KcrXsV3LdIsSmvLbxeisGYhLAtdSlxeDgyQ9ivra 4jPzdVPj4OESygQa+SQsJtGpiEGxRtzBEQ== X-Google-Smtp-Source: ABdhPJzzDliurssMMuzYqqBFLqCo1K2b6i134qd9hU8LIEdzsOwQ3ubGn8DCaGbkEoON6am4+UYMAw== X-Received: by 2002:a1c:ac85:0:b0:38e:b488:64 with SMTP id v127-20020a1cac85000000b0038eb4880064mr4714750wme.67.1649778974422; Tue, 12 Apr 2022 08:56:14 -0700 (PDT) Message-ID: <6f280392-c3ea-543c-c725-88f49d9ac2ec@gmail.com> Date: Tue, 12 Apr 2022 16:56:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Reply-To: paul@xen.org Subject: Re: [PATCH] Use STATUS_PNP_REBOOT_REQUIRED in IRP_MN_START_DEVICE when a reboot is required Content-Language: en-US To: win-pv-devel@lists.xenproject.org References: <20220321142307.114-1-owen.smith@citrix.com> From: "Durrant, Paul" In-Reply-To: <20220321142307.114-1-owen.smith@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 21/03/2022 14:23, Owen Smith wrote: > Failing IRP_MN_START_DEVICE can lead to WHQL distribution of drivers to be > rejected by MS, as too many VMs in the gradual rollout phase will report this > error on update. Using STATUS_PNP_REBOOT_REQUIRED will indicate that the VM > requires a reboot, and should not be treated as a gating factor (it should also > trigger the Windows Update process to report the reboot to users and/or trigger > an automatic reboot) > > Signed-off-by: Owen Smith Acked-by: Paul Durrant > --- > src/xenvif/pdo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/xenvif/pdo.c b/src/xenvif/pdo.c > index bc9b9ed..b3a4aae 100644 > --- a/src/xenvif/pdo.c > +++ b/src/xenvif/pdo.c > @@ -1303,7 +1303,7 @@ PdoStartDevice( > if (Pdo->HasAlias) { > PdoUnplugRequest(Pdo, TRUE); > > - status = STATUS_UNSUCCESSFUL; > + status = STATUS_PNP_REBOOT_REQUIRED; > goto fail9; > } > From win-pv-devel-bounces@lists.xenproject.org Tue Apr 12 16:55:45 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 12 Apr 2022 16:55:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.303741.518189 (Exim 4.92) (envelope-from ) id 1neJns-0001is-8F; Tue, 12 Apr 2022 16:55:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 303741.518189; Tue, 12 Apr 2022 16:55:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1neJns-0001il-5R; Tue, 12 Apr 2022 16:55:44 +0000 Received: by outflank-mailman (input) for mailman id 303741; Tue, 12 Apr 2022 16:55:43 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1neJnq-0001if-Vg for win-pv-devel@lists.xenproject.org; Tue, 12 Apr 2022 16:55:43 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" Date: Tue, 12 Apr 2022 16:55:21 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <11597546.1.1649782524182.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> Subject: XENIFACE-master - Build #109 - Successful MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_0_10211490.1649782523323" X-Jenkins-Job: XENIFACE-master X-Jenkins-Result: SUCCESS ------=_Part_0_10211490.1649782523323 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #109. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENIFACE-master/109/console to view the results. ------=_Part_0_10211490.1649782523323-- From win-pv-devel-bounces@lists.xenproject.org Tue Apr 12 17:10:30 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 12 Apr 2022 17:10:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.303748.518194 (Exim 4.92) (envelope-from ) id 1neK29-0003YE-C1; Tue, 12 Apr 2022 17:10:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 303748.518194; Tue, 12 Apr 2022 17:10:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1neK29-0003Y6-8u; Tue, 12 Apr 2022 17:10:29 +0000 Received: by outflank-mailman (input) for mailman id 303748; Tue, 12 Apr 2022 17:10:28 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1neK28-0003Y0-Px for win-pv-devel@lists.xenproject.org; Tue, 12 Apr 2022 17:10:28 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" Date: Tue, 12 Apr 2022 17:10:09 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <21187343.3.1649783409870.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> Subject: XENVBD-master - Build #157 - Successful MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_2_28884791.1649783409776" X-Jenkins-Job: XENVBD-master X-Jenkins-Result: SUCCESS ------=_Part_2_28884791.1649783409776 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #157. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENVBD-master/157/console to view the results. ------=_Part_2_28884791.1649783409776-- From win-pv-devel-bounces@lists.xenproject.org Wed Apr 13 03:20:55 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 13 Apr 2022 03:20:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.303901.518378 (Exim 4.92) (envelope-from ) id 1neTYs-0008Nj-F6; Wed, 13 Apr 2022 03:20:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 303901.518378; Wed, 13 Apr 2022 03:20:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1neTYs-0008Nb-Bd; Wed, 13 Apr 2022 03:20:54 +0000 Received: by outflank-mailman (input) for mailman id 303901; Wed, 13 Apr 2022 03:20:53 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1neTYq-0008Mo-W2 for win-pv-devel@lists.xenproject.org; Wed, 13 Apr 2022 03:20:52 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" Date: Wed, 13 Apr 2022 03:20:34 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <21044387.5.1649820034389.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> Subject: XENVIF-master - Build #194 - Successful MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_4_3971480.1649820034139" X-Jenkins-Job: XENVIF-master X-Jenkins-Result: SUCCESS ------=_Part_4_3971480.1649820034139 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #194. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENVIF-master/194/console to view the results. ------=_Part_4_3971480.1649820034139-- From win-pv-devel-bounces@lists.xenproject.org Thu Apr 14 10:27:47 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 14 Apr 2022 10:27:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.304597.519266 (Exim 4.92) (envelope-from ) id 1newhV-0007kd-7N; Thu, 14 Apr 2022 10:27:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 304597.519266; Thu, 14 Apr 2022 10:27:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1newhV-0007kV-3z; Thu, 14 Apr 2022 10:27:45 +0000 Received: by outflank-mailman (input) for mailman id 304597; Thu, 14 Apr 2022 10:27:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1newhT-0007kP-NZ for win-pv-devel@lists.xenproject.org; Thu, 14 Apr 2022 10:27:44 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8244b3a0-bbdd-11ec-8fbd-03012f2f19d4; Thu, 14 Apr 2022 12:27:41 +0200 (CEST) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 8244b3a0-bbdd-11ec-8fbd-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1649932061; h=from:to:subject:date:message-id: content-transfer-encoding:mime-version; bh=aI/O+Uoq3IkbWhZP+wKfvPvj2h5i/EU7dDfSVEbKumE=; b=HNm2x2wzK3mYJ1w0TeiA62BOl3OkvbEnX1Dg3m0b7Ie9+VulEF7VQWFT VqYHVX5jxQ4gDe3/FsX4STEvns/UwDDSJLFyLeMAuLqNhlZihPvqFtQ9Z 8iMZpMw8ZICIQLN1sAQcmClHE5Vnycm1681qhI3dE4yA15op7O+R0tokF A=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 68348155 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:eugJda8C3j8glLeRyylbDrUD/36TJUtcMsCJ2f8bNWPcYEJGY0x3n GYWC26AOvjfYjPxedB/aYvg8k0EvcfUxtU3HVY4/Cg8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ54f5fs7Rh2NQw3YHlW1rlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnZK3TzswM7LdochHCgh+NHtCL/Ucv7CSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFIYWoG1hy3fZBOw4TIHrSKTW/95Imjw3g6iiGN6AN 5FFOWMyMXwsZTV/BWcVLcw9oNu3rWfcfD1h+FSyiJY4tj27IAtZj+G2bYu9lsaxbdpUmAOAu CfK8nr0BjkeNceD0nyV/3S0nOjNkCjnHoUIG9WFGuVC2QPJgDZJUVtPCAX98aLRZlOCt8x3J UsSxjMjsrkL2BbyX//aBSGq+CTDsUtJMzZPKNES5AaIw6vSxg+WAGkYUzJMAOAbWN8KqS8Cj QHQwY6wbdB7mPjMEC/GqO/Ixd+nEXJNRVLucxPoWufsDzPLhIgoxizCQd94eEJepo2kQGqgq 9xmQcVXulnysSLp//jjlbwkq2j1znQscuLTzl+GNo5CxlknDLNJn6TytTDmAQ9ode51tGWps nkegNS55+sTF5yLnyHlaLxTQOD5va7cbmGH2gMH83wdG9KFoS/LkWd4um8WGauUGpxcJW+Bj LH75Gu9G6O/zFP1NPQqMupd+uwhzLT6FMSNaxwnRoEmX3SFTyfepHsGTRfJhwjFyRFw+Ylia cbzWZv9Vh4yVPU4pAdass9AiNfHMAhlnjiNLX06pjz6uYejiIm9EO5bawrfMrpktMtpYmz9q r5iCidD8D0GOMXWaSjL648Da1cMKHkwH5ftrMJLMOWEJ2Jb9KsJUpc9HZtJl1RZoplo IronPort-HdrOrdr: A9a23:xZeeEq9qM/uCP2tA365uk+FVdb1zdoMgy1knxilNoENuHfBwxv rDoB1E73LJYW4qKQkdcKO7SdK9qBTnhNVICOgqTP+ftWzd1ldAQ7sSi7cKrweQeBEWldQtn5 uIEZIOceEYZGIS5a2RgWmF+r4bsZ26GcuT9ILjJgJWPGZXgtZbnmNE42igYy9LbTgDIaB8OI uX58JBqTblU28QdN6HCn4MWPWGj8HXlbr9CCR2SiIP2U2rt3eF+bT6Gx+X0lM1SDVU24ov9m DDjkjQ+rijifem0RXRvlWjo6i+2eGRheerNvb8y/T9GQ+cyjpAo74RGIFqiQpF7t1HLmxa0u Uk7S1QeviboEmhBF1d6SGdpjUIlgxerEMKgGXo/UfLsIj3Qik3BNFGgp8cehzF61A4tNU5y6 5T2XmF3qAnei8osR6NkuQgbSsa4nZcYEBS4dI7njhaS88TebVRpYsQ8AdcF4oBBjvz7MQiHP N1BM/R6f5KeRfCBkqp91VH0ZipRDA+Dx2GSk8Ntoic1CVXhmlwyw8dyNYElnkN+ZohQ91P5v jCMK5viLZSJ/VmG55VFaMEW4+6G2bNSRXDPCabJknmDrgOPzbXp5v+8NwOlZOXkVwzvegPcb j6IS1lXDQJCj3T4OW1rex2ziw= X-IronPort-AV: E=Sophos;i="5.90,259,1643691600"; d="scan'208";a="68348155" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FHM3VlSuKT/ohBu1TC+xPLFKxD78yGtkhCdD870/Wm8JwXBtxdVd5NxM2q4o+NQLU7o1vXauXcjMlkV0ZwFwIDXQOTZQNM707erxU+cuzRR6C/6E8p/8BiOAF96YjAemsLdGpztlez5oqQkD+ozNAQ0Nb2nd8yKjf9X1VKEXKTS/VuFizDQFN/G9R+Ucth5MKW2Tzh34b6twOy/JPnjNmV4YEYATlhjdhMg7de/gadI235DbN7js0pb4fUH3pvj7bg1bvHIJM+NE8WW560P0zARn+HoARG2DbKFIFJ1slyMYkqc9G9ae2AvXr2F5InOYOOoiP93eO7eq1UfDDs/sSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f4xeonW5s/lAaAuo+MvN7yikNOPnGbc8yU5crcS3FfI=; b=mgGIKVAgHRrBbCcANcfPh5GDeJl/YjYcNIX+cQv8AlJGy8ePq4gw+A8jU5RBb3j2zxb6INPQza2irgHfo1d1z0qC9ZfJvsyAF4PcH8irhvKFvawbxNmmdw/Kxx7twxtt1Ljcl74JOD5EAOFG0Xr9JZsooIYbld591OkWNf3O2XQiGGykEmmtr4iwyRDmbdPCL5C5q9ydZ6izdlVJLqnE3V0leLJeiLaPjUK7TPqGIVzH33YVg0ABjm6zF/1jEIIxnj/8CXjodYkfW6X3twxuswH+9GXKPgXT+LDD376EkTGGBUFH+ioyzPHY7ialwn42bAUTGyXCMAfl53lPAXiiQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f4xeonW5s/lAaAuo+MvN7yikNOPnGbc8yU5crcS3FfI=; b=t2k782PrPvnVFjtIo0C8F78HS7dhlDl7+9dwim1OYPlmSi9HL0rjvaWbrC8tHJAO9TSWrrNCPWt9pGKjVRJZw+hbqMVzgtN/niQtH2PvItDpB2HbI9Ay5wvFvM6tFyu4PpCOqqc0g2ehxUSvKKoHq0kywugtIIG0Y3GNA7MP8HM= From: Martin Harvey To: Martin Harvey , "win-pv-devel@lists.xenproject.org" Subject: XenVif div by zero on Tx path after resume. Thread-Topic: XenVif div by zero on Tx path after resume. Thread-Index: AdhP6kAbDA19BbYtRECv6F4UUU/GxA== Date: Thu, 14 Apr 2022 10:27:35 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7fdfedf9-4225-4ed8-f327-08da1e0164b8 x-ms-traffictypediagnostic: DM6PR03MB3754:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nKwzXHgXWxIRBke97gF3elgx+5Z42TT6lZBz+ShmlVpjFaJEdBBDShsYC0KhSGPM6NaeDsiQHGhouHuIYvAA38j4/KLGVqLPpFYKvCRGOlXC3rTCLNvLvBkZp6YjJSHfvi9HZxnM8dKBg3dXFMiX5hhOKdAvyKxenHZ8REFd3DSKdQ5nDW8/WgoXd6O8oAWfqWLwHSqoPj8x7icbQN9nCee4SZn5mfJ93/+P+DYk9gqirByHuhN8Nmi+oW5e+3q365tvEDGUiaC9vShSOX/GStPCmgjQzjIpgENNTH4JZ0vc99zSoUdLV3JV7d+Y/WAmSxe7tMiZV4y30a/V34XYUUiyfL6TqS2SCc+0sm8UimYATLKic1YehP9YboCboEZbAZIc7xL5Ct0VukY7QxZtoCfhJuw0fcan4nUuzISTdOTDSDxfuAoo9aaUc1CWZyCl/xSzKAxxo/rRo3S1RikJlZVhOPvh5WanUzMTggoavmF1YnaYJNYZvbYgRe7a2ReBHpFGVolZyGIHLYzQqyW0lu/O8L8TjFHlVwVpC5MCztQZ2p9dET3FNe4hCVmw4vMe3Zwg1P5gmYXjdZWC+uNsYZr+wQvYF7LqU0mag5bkPsFoUpQtbt2wuVrQsAJOMYlS19yBJJs9RYnZvvhSdTq3pl0gDXQ4vZZSTVukaU4ZBs7GmT+i8kv8CIQIV4SZSVoV0kITNnfaBhciX2htthCcLw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6347.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(110136005)(8936002)(5660300002)(86362001)(316002)(9686003)(7696005)(82960400001)(122000001)(64756008)(76116006)(66556008)(38070700005)(66946007)(66446008)(8676002)(71200400001)(66476007)(186003)(44832011)(6506007)(33656002)(508600001)(2906002)(52536014)(55016003)(26005)(83380400001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?h0iQWFOGfse+LavcQGjCatfK3rhfn+Y4TPhMTRBrmm+c1sTuwJvxNs9JjTo3?= =?us-ascii?Q?C2rE17PlQ0KTwXVGO33Sduw8vS0LwQYbkRmEMJF54PPZwF0bMAyXEncKlI07?= =?us-ascii?Q?nghP6sx/lbGxTLqUFVt3i/nYdH1xC1w46Qe9L48xpgqyu47hDXX1+MxpBJr0?= =?us-ascii?Q?iUIpN/gKBTug0wPHPIGO+uqMw8Xfj/45X5juSENiaqvqvm811UELO56+suPF?= =?us-ascii?Q?9ZtR99e6k/9pSSQy0lKi7adlV6Xy69Rx5tSBYrjTBY69szuBmraBEEQV3lQI?= =?us-ascii?Q?rluan8WokSPbdQc+lDWdEezSqCn3zaMOyw2cCEP1BWu7cRfi1Pi+GcgJHx6x?= =?us-ascii?Q?LK44eAmt8qCF7RNl70Q0E3f6W0d3RaSVh65u6Puhi6jTkQkqlEuB5FeefNKG?= =?us-ascii?Q?I4LTLtfN1UYtcGQ+f3Y7RxIvoYvjHAkmQYaisbIBPqra4LC2CA5BtcO4qQ66?= =?us-ascii?Q?PZF1RSotdO9QQ8wVk0ifKbA/3G+42igORucpfgYbdDluKDGZ5dVdHrf2t/rN?= =?us-ascii?Q?4zx80Yowkkq89TS9HsD5X++6svkjFUTxLZCHrkTJRR0V2kDbZSpft3ecRwSr?= =?us-ascii?Q?dNSAHevQSFo7TfuYv9CC1c3RPuNr5ZEXRs4eMe+O0n3/NxBmHBdYSurhW2mw?= =?us-ascii?Q?Pj/NE5QuPH85lir406Cuxw60uHGqNU6zUMocIm36+4GUjzZGnrU4emv+IB1b?= =?us-ascii?Q?iFu7N2BO9ILc6g5E9OAxBlQ5f1XRevhOXnIzXitdsnpg3tS1W33Ltx/gvHVI?= =?us-ascii?Q?4pF5Pdpzfs1iuYWm1a438viL+mdFHPzYw39eiQz4w9jxIfW1gN8yGjQaZeun?= =?us-ascii?Q?W9Dz/2igoyH+8KgZjfMW5MAAHPNpYDHPJykSRkEPKT8vsPrAOWcmYDYAt7aG?= =?us-ascii?Q?0k+A/yEls+6LGaINfZjFyqGjM++3K/55E+U2qqoWmB9GIDOsQ9Jyh6CV5QIb?= =?us-ascii?Q?cKSFpn7/TNEIYx4SdqiolLuhuTVf/3R/9XOvVW9gtgqPE8xgSbEYDQ8Wrzm0?= =?us-ascii?Q?HLBaWhReCHv/MdW2MTroDj8vTFxdnUrB7ehKmj77GtAyrn9LyoAJh2T7IEcd?= =?us-ascii?Q?FewEMipcZmBJH4WWfBrGZPp8IGgIp6NXduRCa9/Ia3ipZB++8c4sLsNjer0A?= =?us-ascii?Q?mObTtBWT9d58o8wJ3FqrMykPyJqVDVJLxN6tvmxjWyVT0CE83H32zcpZme62?= =?us-ascii?Q?EuouiJYEiLmJigpvYLb/rBJIaNl5qiWBPVubxV1UUpmsJ02DMtRDxPm5teUj?= =?us-ascii?Q?4Hf5wVPae6VIbH6P3cxIaJUpfwOvUOBcNgqKRxvGaDRhVPosvf320KCJwYky?= =?us-ascii?Q?hP3LZGZC5NwP56nwAHWJt+bz0XHtQTe/TPx9FJbBidbb7sLDEArW4M5vyyiy?= =?us-ascii?Q?ONSXItJo/dQVee6WebsgTi/FLNZsFMcSCQyAgoYsLkxXZTEuz4/TSxjTIeqD?= =?us-ascii?Q?yXq9eC4wU+/4Qa7R5jK6W59HZWj+8T7PTQs7jbPMo1nwnUhYpgjOHmRoiL1D?= =?us-ascii?Q?ns2+F0GHcb8X/UicAWgBezy7DB9lxYZjPNWjvRVP3jIwtfmg/60L6Ri1Najf?= =?us-ascii?Q?RFZYAZL2a0aUhEuQy0iy02apLj+PjMtJVGWwSJVfMqNVqTanWX5dSph5od8I?= =?us-ascii?Q?/+jgkQ6HYrjiHY4xO2lmm9deDqXa3C5qkC83K1my/i/Njp8ZxtDpKtLjWWP+?= =?us-ascii?Q?CKvn509OVIHHaFMIKWaGImqnuJmlPaslNJzbHIEKzBXUtlFK6tDsGenNFCfJ?= =?us-ascii?Q?h/7xosuh2/StVJEX0FyfHrhAyFaBP/o=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6347.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7fdfedf9-4225-4ed8-f327-08da1e0164b8 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2022 10:27:35.9052 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /f054sPLJ0fjM7YnlMCjEBBaL54x6QfulpEJoXGxkv9wOM4B82NAWcT8HCRGT+BgZ1i4bdoMv9xXXPQuUXVZdfwoII8aQmIi5L8ByzHrJH4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3754 X-OriginatorOrg: citrix.com Hi Paul (and others!) I have done a bit of digging on this, and it looks like it's due to changes= made in the suspend/resume path. See log at the bottom for the failure cas= e. In summary: - Originally I suspect suspend callbacks were early (which actually lowered= frontend state)... - and late, which is after the resume when devices and the system are power= ing back up. - ... and there was some (more) synchronization between suspend callbacks a= nd PDO power state changes. For reasons which are not obvious, the frontend and pdo power states are le= ft as up and running, and the Late callback cycles the frontend state down and back up again, leaving the= VifSuspendCallbackLate to actually take the frontend back to the final CON= NECTED state. This raises a whole bunch of questions, not least: - Initial suspend does not lower PDO power state because it's on boot path = / or some other reason? - Why frontend suspend callback early just sets "online" to false, instead = of actually lowering the state properly. - Where we actually use some suspend callbacks to request a change in syste= m power, or is the suspend / resume / migrate supposed to be totally transp= arent? - How we're supposed to synchronise the Tx path with suspend / resume if th= e latter does not command some system or power state change visible to the = OS when we request the guest suspends. As it is, the suspend late callbacks happen in a deferred manner, and there= 's nothing to stop the Tx path from making a request to send a packet if th= e OS cannot / has not seen a PDO power state change for the PV network devi= ce. As such, the current DIV by zero fix of dropping the packet seems to be to = be an acceptable workaround. The alternative would be perhaps to explicitly= synchronize the VIF suspend callbacks with PDO power state changes for the= PV network device. How? Thoughts? XEN|DEBUG: =3D=3D=3D=3D> (xenvif.sys + 0000000000008A40) xenvif|FRONTEND: PATH: device/vif/0 xenvif|FRONTEND: DEBUG CALLERS NEXT PUT PTR: 15 xenvif|FRONTEND: CALLER (0): __FrontendResume to state (PdoResume, FdoAddP= hysicalDeviceObject) xenvif|FRONTEND: CALLER (1): __PdoD3ToD0 to state 3 (PdoStartDevice) xenvif|FRONTEND: CALLER (2): VifEnable to state 4 xenvif|FRONTEND: CALLER (3): __FrontendSuspend to state 0 (FrontendSuspendC= allbackLate) xenvif|FRONTEND: CALLER (4): __FrontendResume to state 1 (FrontendSuspendCa= llbackLate) xenvif|FRONTEND: CALLER (5): __PdoD0ToD3 to state 1 (PdoSuspendCallbackLate= ) xenvif|FRONTEND: CALLER (6): __PdoD3ToD0 to state 3 (PdoSuspendCallbackLate= ) xenvif|FRONTEND: CALLER (7): VifSuspendCallbackLate to state 4 xenvif|FRONTEND: CALLER (8): __FrontendSuspend to state 0 (FrontendSuspendC= allbackLate) xenvif|FRONTEND: CALLER (9): __FrontendResume to state 1 (FrontendSuspendCa= llbackLate) xenvif|FRONTEND: CALLER (10): __PdoD0ToD3 to state 1 (PdoSuspendCallbackLat= e) xenvif|FRONTEND: CALLER (11): __PdoD3ToD0 to state 3 (PdoSuspendCallbackLat= e) xenvif|FRONTEND: CALLER (12): VifSuspendCallbackLate to state 4 xenvif|FRONTEND: CALLER (13): __FrontendSuspend to state 0 (FrontendSuspend= CallbackLate) xenvif|FRONTEND: CALLER (14): __FrontendResume to state 1 (FrontendSuspendC= allbackLate) xenvif|FRONTEND: CALLER (15): (none) to state 0 xen|BUGCHECK: =3D=3D=3D=3D> xen|BUGCHECK: ASSERTION_FAILURE: FFFFF80113373A40 FFFFF80113373A60 00000000= 0000144E 0000000000000000 xen|BUGCHECK: FILE: E:\jenkins\workspace\nvif_private_martinhar_CA-355670\l= ocal\src\xenvif\transmitter.c LINE: 5198 xen|BUGCHECK: TEXT: !NT_SUCCESS(status) From win-pv-devel-bounces@lists.xenproject.org Thu Apr 14 10:37:49 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 14 Apr 2022 10:37:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.304613.519281 (Exim 4.92) (envelope-from ) id 1newrE-0000tj-8f; Thu, 14 Apr 2022 10:37:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 304613.519281; Thu, 14 Apr 2022 10:37:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1newrE-0000tc-5S; Thu, 14 Apr 2022 10:37:48 +0000 Received: by outflank-mailman (input) for mailman id 304613; Thu, 14 Apr 2022 10:37:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1newrC-0000tW-Hx for win-pv-devel@lists.xenproject.org; Thu, 14 Apr 2022 10:37:46 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ea3ce0c8-bbde-11ec-a405-831a346695d4; Thu, 14 Apr 2022 12:37:45 +0200 (CEST) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: ea3ce0c8-bbde-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1649932665; h=from:to:subject:date:message-id: content-transfer-encoding:mime-version; bh=5i3pQmOQvDL0Tp7Z6DJyDh2EYd5W0HxEiptwcfIhVC0=; b=BMAThP3aLKpG7lMjMPfgx8mY3ih8zTtagewIT7QfWwhVKXWt0+hVPEeX 2B9EJaPPeyNgn/DR0FNsnzdoEHAXQx5dX2qmvgTUC5tV3iO+IjGS/xlXf VkitMNMFq8ssqzI27HygRTcAvTBCAwgVLtv9djI4RJN6gob4YR2XxWa+Y c=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 68943503 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:QCrxvqzr+nn8mO/o6dd6t+dIxirEfRIJ4+MujC+fZmUNrF6WrkVRn WpMX2iGafaIM2Kkfd0kOozjp09SvJTdzYNnHVQ5qSAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NY02IThWmthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ NplkIK0YgYJOL/wwLofCiQbKDl9H4pWweqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DOYoFpnBmizHQF+grULjIQrnQ5M8e1zA17ixLNaiON pZCNGI0BPjGSy9wA1gHCI09oOGPhnLUQidItgOtt5NitgA/yyQuieOwYbI5YOeiWsRT216G4 27L4Wn9KhUbL8CEjyqI9Gq2ge3Clj+9X5gdfIBU7dYz3gfVnDZKTkRLCx3r+pFVl3JSRfp6N Ug/+woov5Rqqk7yc5rGRx6ah26960t0t8VrL8U27wSEy6zx6gmfB3QZQjMpVOHKpPPaVhRxi AbXwoqB6ShH9eTMFCnDruv8QSaaY3B9EIMUWcMToeLpCfHHqZp7sB/AR80L/EWd3oysQmGYL 9xnQUEDa1QvYSwjiv3TEbPv2WvESn31ougdvFS/soWNtF0RWWJdT9b0gWU3FN4ZRGpjcnGPv WIfh++V5/0UAJeGmUSlGbtRTeHzv6/bbGaH3DaD+qXNERz3qhZPmqgKvllDyLpBaJ5YKVcFn meO0e+u2HOjFCTzNvImC25AI88r0bLhBbzYugP8NbJzjmxKXFbfpklGPBfIt0i0yRREufxva P+zLJf3ZV5HWPsP8dZDb7pEuVPd7ntlnj27qFGS50nP7Idyk1bMEOleYQrSNL1hhE5GyS2Mm +ti2wKx40w3eMX1YzXN8J5VKlYPLHMhAovxpdARfemGSjeK0kl4YxMN6dvNo7BYopk= IronPort-HdrOrdr: A9a23:c1CxMqx6HdKnvpt5Ed/CKrPxoeskLtp133Aq2lEZdPULSKOlfp GV8MjziyWYtN9IYgBZpTnyAtj6fZq6z+8/3WBxB8brYOCCggWVxe5ZnO3fKlHbak7DH41mpO 1dmspFeaTN5DFB5K6QimjZLz9J+qjCzEnCv5a6854Zd3AMV0gW1XYcNu/0KDwVeCB2Qb4CUL aM7MtOoDStPV4NaN6gO3UDV+/f4/XWiZPPe3c9dlMawTjLqQntxK/xEhCe0BtbeShI260e/W /MlBG8zrm/ssu81gTX2wbonthrcZrau5R+7f63+4kowwbX+0aVjUNaKv6/VQUO0a+SAZAR4Z vxSlkbToFOAjjqDxuISFPWqnTdOXAVmjjfIBaj8AfeiN28SzQgB8Vbg4VFNhPf9ko7pdl5lL lGxmSDqvNsfGT9dQnGlq31vitR5z6JSLsZ4J4upm0aVZFbZK5arIQZ8k8QGJAcHDji4IRiFO V1FsnT6PtfbFvfNhnizyBS6c3pWm52EgaNQ0AEtMDQ2z9KnGphx09dwMAEhH8P+J80VpEB7e XZNaZjkq1IU6YtHNRALfZERdHyBn3GQBrKPm7XKVP7FLsfM3aIsJLz6KVd3pDZRHXJ9upApH 3saiIniYdpQTOQNSSn5uw7zizw X-IronPort-AV: E=Sophos;i="5.90,259,1643691600"; d="scan'208";a="68943503" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eL5rKz0mkTiCGm6+zYu7sL7FZU4SKCzmoJD1EYv8GNQlzQmbSYU/4+7TwC8wxKcDHOeObcytuMU8g/0235yelHH4hpON0ei4TY0+72KxVCTwTBXd6BGiePK9InNZzrLAaqhP53WIgqnuDwlvYotkUfC3UtkIinOHEaS14r/d03fetNl1Wy3xp4JG7XywAtwik3tbAcpZSoqHZ00KTp3Vp0rFZfHD8VcrWLiBAwJwSLF3/D74PUggkGocpvZ4O9P9Oip1c0A5yeISKnRieRHnKNaalVbse6Z9bonAoO41jsq++/yjfcBSH9k+FoHDKpLhKyaKBNhyA8ri/aebuoqD6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5i3pQmOQvDL0Tp7Z6DJyDh2EYd5W0HxEiptwcfIhVC0=; b=Eu0Zgap5maMaMZj8cHjXr+84BHX3KqOekgwrc6XnUZd2Z4/u4TDZGSmWWBCDI2cPu7Egqae4in1taXRwrNriG2M5Q07WCloHZPvJGayPUC8NsFiZccG8rEh114bTyS6HYmgrXeUdRZpoKjJFf6TeAUouj4oKEiChlWGKeexTQfa7Y+uNyKeyuEgTmav2KJGs2y5HbmvgGTHhOke8guagHRSwab5mXwiGTKh6hTyCARfSu6j9P5u0LQwBEZUnz3VIVq61IPct9FNlBwBhhRoxRajQAGqpcUNuWaiPMNVg1XrzzAOODSawzCpLZSCP0KmQ4i7tlOBLmgLdewQpt+MhGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5i3pQmOQvDL0Tp7Z6DJyDh2EYd5W0HxEiptwcfIhVC0=; b=fGBCXH/0wMX0zD+nde2iWhqxRpCDdI5mPwWWoa7sf9oqqh1K70KqNXjjtGJ2gPu7cEJCiNIt5HfNtx/Z4FTAcSxmdiAd4Onq6yFCDGoFQX0RMIaScHKY81f2irUg4tUvHxod2NI2s8MYm3mKBxMHyoftqKTos6QuAStrQtK80Po= From: Martin Harvey To: "win-pv-devel@lists.xenproject.org" Subject: (Summary) XenVif div by zero on Tx path after resume. Thread-Topic: (Summary) XenVif div by zero on Tx path after resume. Thread-Index: AdhP66ceRYjwZtebQgqNbU2FYZICJg== Date: Thu, 14 Apr 2022 10:37:38 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5a2bbafd-52d9-45b0-7bd9-08da1e02cbcb x-ms-traffictypediagnostic: MN2PR03MB4688:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CofPTtjV2XYiBth6rb6jOwfPkViraaF1NA/FTDazrP8HZXVJhGMnSd9oKWmd092OKGHsaDIEfL5dzYU+5RNcOgaDUsYdkHrJ0sZNuNXSIrW5DuAbZ2sSeOB9pRVnf2L1Od2SUiHdFzvxSyAwoB0AJ9HFn+EFkHq1yzo4U6lbcmfYC7HLSZRkWQCsyMGGnfj7x0I7lKva1XOcsfw7Zq68y3zBBOgDeNkntmoY2Z9Oep4Sm7sxVcWNuMAmg+FcQE3y5KeRC/dJ1uPeLRl0BTTBlS+mxzXj6OgZmnumlhfy1ReX70d9vtU0sjWoQTpSZS2v3/DFi4BKOJuAnX3ebIRLm1NMeaoBEl0ghQPWGJw9lKtk68wvKDGyaiiVTEWlc+sdnTZEvBwCTlTGBgc46Zp7yxGj/UbPQlJOSM5wdla9fxo/ljrcArOzMhDPF0NnUjnOVUKl6Y9FTjYW/ct25Vo0sknBSo34noyZsUPGEyR8eBw98ar+s118CMV7cedNDOP8/ep/3ao6enp8GC2vgBRfNSLyABJEqovpSCTuz2pM+NSYiaDAonYaD7kcRfeJndYzBWZCqBXQon7ujMoD39vkOjVtMU/kL2hTpdoAadpN3jGrjVSJMVLxxtJgfzYtiJs9DtwIxykMPX9nMkLXBE2g67q54w4fdlL73n0Ka0O6E/CjLdNQH2bCMu5T3aIKUK4AimMOPVMheQ1B6FZ5qm+Z/w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6347.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(76116006)(66446008)(508600001)(122000001)(66476007)(66556008)(8936002)(55016003)(2906002)(38100700002)(86362001)(82960400001)(33656002)(38070700005)(4744005)(186003)(52536014)(83380400001)(316002)(26005)(66946007)(8676002)(6916009)(7696005)(64756008)(6506007)(9686003)(5660300002)(71200400001)(44832011);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NnqDAiN/Lozar9F465tOQjXk2IxN+7jgir6dujaTcLrMhCXym2gcGY0r/zyQ?= =?us-ascii?Q?sSbqiIzZnQRkzI5g0T4Q+8s0luSQHcJvXqErf9AdQi9CjDY+7E3piC/kAJ5a?= =?us-ascii?Q?2G/6YGIOOrF0ZJrjLHHO3GDcd5uUHrWM9CVFyWyx76nLT6IGrk4oHD3buOGN?= =?us-ascii?Q?hnKaIR8hSvtlsYxOri1/Eznw6dtWDNVnWCugy7bmKrYz6Jgwzh8aRIWX676t?= =?us-ascii?Q?5lpWQHou8HbvyEQjFVbz524O44tTddcb9CFxwIUsBTpQmztKV+cK06uMvTjh?= =?us-ascii?Q?9Jvsjmc5/13IMyc1plH43x4kRnku39IIzgK3DMEhKRmiWvfG/vOPYO6PgAxF?= =?us-ascii?Q?BqjlSgmVP7erwpESRk9poKOI62FTwHFqWTIC86s+EfaWVl/eKsUfa8WDKMIQ?= =?us-ascii?Q?bO5xsylphkSsnE3aXZ/scyqsYnTih9MOQppH26BkDoNA5SmF2P6Xlyez56cu?= =?us-ascii?Q?M+/EEQkayLIq9IliOZe9GszD8n5mvR5JpbqjCGjTkzc819XE53xQigVzY8Mk?= =?us-ascii?Q?cyp1zVXr0AVVzEddfZ1ndXEEYPBK4VLj207AUVOL3KxIXA5MqIfmENOEWD5k?= =?us-ascii?Q?OCmMgQmYwbid/m4RV5ERfdxwueEQclRs4InJyVbmBaqBSeqbJoCxVKtwG2sX?= =?us-ascii?Q?YiWH/YHcEQ7Fk85bZ4CYPLgnU6maHx1tJGuOG0PiohPhBXemXiCp68rg3AJD?= =?us-ascii?Q?2AVWKuziJG7S7FdekQxcLY7VrqD23OSbAkEqOpEOcjzO0FpdXaRrFH/0mH0M?= =?us-ascii?Q?eUcesMsxqW0PXp7QLjjp5zy2WST8m60t3aKI7/x0zMwSuWM4XsrBENYfR9is?= =?us-ascii?Q?JluqmSLVig93ztsQp8A0Y7iCGw6LL5EgDjwGpaXDkIxoGiH5qBJLl6tAeKoB?= =?us-ascii?Q?BJrpqZqi/Kmd4MGLM1os2UaNztnFUYsEb6F/tOQAIWeB+NTLeSbaTpVxBBu3?= =?us-ascii?Q?gwY5XMVOlAbUaF6uPh+pL3dT6ln8+w5ZuaMZWeM73gzw25sNxiMOcJCS6OIh?= =?us-ascii?Q?EFPwkzhPCgsyp8kYfyEc5iKX3k4/UHS1i1sUEU7bN6QGetckrjkaWe6qr1m4?= =?us-ascii?Q?gfUYD3TGlCnm6q/70F2nKrajNbOjjjOouDtccvk33c3VFWJg+1l4aX0P1Az2?= =?us-ascii?Q?V1Jq9obvZlCygb9WUWVWxo9L0ZFrk8kEl9+hhUO2i+R406+0KslY7wBCVsfl?= =?us-ascii?Q?+Ltb8xzvAsHMVAwhLp2ncl5uFBGnZW+zhEHWlaRFV3E3OjSRmea0bbXuzAvs?= =?us-ascii?Q?xU+yJZ/uLc+SgOWPtvTECwAn79JsB1uLZbfQAcJQ0Uk0PbzdD/eHLwHi96y9?= =?us-ascii?Q?8vzzpe8AANIoiWrD8UTHNNFoARlVOsEGeoMH/rG4j9XzYPWZ1nHvD7Hm2gyP?= =?us-ascii?Q?G7nes3Xd2CEoE8RtW1kP3DxKgbvYMhubIWAXeI5NXngHTGMufX1TJSx5ex6+?= =?us-ascii?Q?IakEmz+Pd1tooIq6XMK07Ph65dUKp2dnzOln2t0xf//pjUNIGMRZ2Jymz4u1?= =?us-ascii?Q?w3voquMaj/twqR+/toMgyccfA/lgvXvpnHl6Nbuh3E1XQdMuDDMNkmDhI1Qz?= =?us-ascii?Q?TV2plUrim6j8UK2lA8oCNokuLqanxkMrWJTMuyNea0A0lA3iLDhS4r4RHyUx?= =?us-ascii?Q?EcjlgiVi2f7VMmHVZP+0Z2S1FImPBGjrnaE+G4pGUJ3cBervIqINPiCtrLmc?= =?us-ascii?Q?Q/yEdA4WvB8tKhOQ0OaGpc7t1oUANQEFCZOnt34xeypA8it65MQAVbIGXfu6?= =?us-ascii?Q?HkOzXBNREkK8jKzjNv4aPz8MpAQHvTE=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6347.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5a2bbafd-52d9-45b0-7bd9-08da1e02cbcb X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2022 10:37:38.3443 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: T0WDQAk4qoTlCplZ67SC+PLFRU4+YGp2QQjylbHV/zUXtqvG6lKdqbx9LRzbNjaWa5UOdoBqaq1C83m04BUDG/kerkslptQLYxrQOG6/eE0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4688 X-OriginatorOrg: citrix.com In summary: - After reviewing the various suspend callbacks and the amount of rewrite t= hat would be required to change the suspend / resume model, I think it's st= rongly preferable that we simply fix the case where xenvif gets a Tx packet= request when frontend not initialized by just dropping the packet. MH. From win-pv-devel-bounces@lists.xenproject.org Tue Apr 19 10:38:56 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 19 Apr 2022 10:38:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.308002.523471 (Exim 4.92) (envelope-from ) id 1nglG3-0003Lv-J2; Tue, 19 Apr 2022 10:38:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 308002.523471; Tue, 19 Apr 2022 10:38:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nglG3-0003Ln-Fx; Tue, 19 Apr 2022 10:38:55 +0000 Received: by outflank-mailman (input) for mailman id 308002; Tue, 19 Apr 2022 10:38:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nglG2-0003Lh-Le for win-pv-devel@lists.xenproject.org; Tue, 19 Apr 2022 10:38:54 +0000 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [2a00:1450:4864:20::32f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e726c397-bfcc-11ec-a405-831a346695d4; Tue, 19 Apr 2022 12:38:53 +0200 (CEST) Received: by mail-wm1-x32f.google.com with SMTP id v64-20020a1cac43000000b0038cfd1b3a6dso1249844wme.5 for ; Tue, 19 Apr 2022 03:38:51 -0700 (PDT) Received: from [10.7.237.14] (54-240-197-231.amazon.com. [54.240.197.231]) by smtp.gmail.com with ESMTPSA id o6-20020a05600c378600b0038eca3cdbb3sm15593542wmr.13.2022.04.19.03.38.50 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Apr 2022 03:38:50 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: e726c397-bfcc-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=N6vY23JpIF3sZObGOBJWoVPyXgdLRQkBrPTJTi3t1kQ=; b=J7Fe2esNRsQ3JFkUP+RLzIRfQvtAjaiNkm/LUOm9kCKEH0v4JsbDTf0dn3VJ33wiD3 mC2bNvxoUP2EWSoiGRBNB8f94LnpGWVTok9LnlIh296X6iWiT3Y+E2s4gI69lIljMDBd ceL1GBoGJf4aMdz/Omp8LIvEZCm+3d5FHYqEJUr0sT1mUzan6/oK1WT0X5UhlWiFsH+C TJe5qPeFpSgSJ94yqmz2/IXyt6lJllZZwxVZ5TdadMdSkr4eLCqRh/tu8ofJkccWX6JW s1oq4Q7vI9Bgluw8KSixRELKfZqq7JzePNDxyvdAa+2a3+GjjohkFJZ4eCqO+nJMP18m LljQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=N6vY23JpIF3sZObGOBJWoVPyXgdLRQkBrPTJTi3t1kQ=; b=1D1MlPfwZWg8+gFJf16+4nCMhAs8fdTJagsoO9JulCKeObt619LCL8U5rlhXcVI3q7 4N9cGbZHhMH0hGqFYbpcE9EN5CI8VZpfwyO0R0T8qo2USfzCn5ieCcCOoTVRStsjz8a6 cpuc4H/p10E3wBJw6hT+okbGchjP6BGGOoWNMcl4DYaZeP51NKS9aUvQvVJlIG//+s7h VrsxA1SwGeIbO7lw+gG7yLZc7t9zmFaIWeoy1i99de0T0sq2Vc6PVra5hfOs/gJdPLdR yZIxi06gs2IHAHYy40SSp0bgORIoEDFzXmBeKbuw0p6k8iItS5eJYrI5S2Z8z17qEmtK fdrg== X-Gm-Message-State: AOAM533Am6aYgmBg8w/gCRtdCE8WbTA6lbLMixq64iSflU8VAGYFqDX7 QTR5v8XQmQ4V4fA8LRRdv7l57HAnBphbQg== X-Google-Smtp-Source: ABdhPJw0UBxHHpXe5/7hOaJj85Ji6ClbeeFZaVPyVe1/NVRja7gyNdJiE3G1bkghXtPcXa11R/nltA== X-Received: by 2002:a1c:2947:0:b0:391:8d5a:69b7 with SMTP id p68-20020a1c2947000000b003918d5a69b7mr15466233wmp.113.1650364730990; Tue, 19 Apr 2022 03:38:50 -0700 (PDT) Message-ID: Date: Tue, 19 Apr 2022 11:38:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Reply-To: paul@xen.org Subject: Re: XenVif div by zero on Tx path after resume. Content-Language: en-US To: win-pv-devel@lists.xenproject.org References: From: "Durrant, Paul" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 14/04/2022 11:27, Martin Harvey wrote: > Hi Paul (and others!) > > I have done a bit of digging on this, and it looks like it's due to changes made in the suspend/resume path. See log at the bottom for the failure case. > > In summary: > > - Originally I suspect suspend callbacks were early (which actually lowered frontend state)... > - and late, which is after the resume when devices and the system are powering back up. > - ... and there was some (more) synchronization between suspend callbacks and PDO power state changes. > > For reasons which are not obvious, the frontend and pdo power states are left as up and running, and the > Late callback cycles the frontend state down and back up again, leaving the VifSuspendCallbackLate to actually take the frontend back to the final CONNECTED state. > That's the idea, yes. > This raises a whole bunch of questions, not least: > > - Initial suspend does not lower PDO power state because it's on boot path / or some other reason? > - Why frontend suspend callback early just sets "online" to false, instead of actually lowering the state properly. The early callbacks are run with interrupts disabled with all other vCPUs spinning, so we try to avoid doing very much there. > - Where we actually use some suspend callbacks to request a change in system power, or is the suspend / resume / migrate supposed to be totally transparent? The whole suspend/resume cycle with or without migrate is supposed to be transparent to the rest of the system; it's not any sort of known power transition, it's very much Xen-specific and so needs to be handled entirely within the PV drivers. > - How we're supposed to synchronise the Tx path with suspend / resume if the latter does not command some system or power state change visible to the OS when we request the guest suspends. Even the late suspend callback runs on a single vCPU at DISPATCH, with all other vCPUs spinning at DISPATCH. Thus the only thing that should be able to pre-empt it is an interrupt. Hence there *should* be no scope for the the network stack to send any packets until the callback has completed its work. > > As it is, the suspend late callbacks happen in a deferred manner, and there's nothing to stop the Tx path from making a request to send a packet if the OS cannot / has not seen a PDO power state change for the PV network device. > > As such, the current DIV by zero fix of dropping the packet seems to be to be an acceptable workaround. The alternative would be perhaps to explicitly synchronize the VIF suspend callbacks with PDO power state changes for the PV network device. How? With all the power state management done in thread context, it is automatically blocked by any suspend/resume because of the vCPU corralling and the fact that the active vCPU runs the entire cycle at DISPATCH or higher. Hence no need for any further synchronization. > > Thoughts? > > XEN|DEBUG: ====> (xenvif.sys + 0000000000008A40) > xenvif|FRONTEND: PATH: device/vif/0 > xenvif|FRONTEND: DEBUG CALLERS NEXT PUT PTR: 15 > xenvif|FRONTEND: CALLER (0): __FrontendResume to state (PdoResume, FdoAddPhysicalDeviceObject) > xenvif|FRONTEND: CALLER (1): __PdoD3ToD0 to state 3 (PdoStartDevice) > xenvif|FRONTEND: CALLER (2): VifEnable to state 4 > xenvif|FRONTEND: CALLER (3): __FrontendSuspend to state 0 (FrontendSuspendCallbackLate) > xenvif|FRONTEND: CALLER (4): __FrontendResume to state 1 (FrontendSuspendCallbackLate) > xenvif|FRONTEND: CALLER (5): __PdoD0ToD3 to state 1 (PdoSuspendCallbackLate) > xenvif|FRONTEND: CALLER (6): __PdoD3ToD0 to state 3 (PdoSuspendCallbackLate) > xenvif|FRONTEND: CALLER (7): VifSuspendCallbackLate to state 4 > xenvif|FRONTEND: CALLER (8): __FrontendSuspend to state 0 (FrontendSuspendCallbackLate) > xenvif|FRONTEND: CALLER (9): __FrontendResume to state 1 (FrontendSuspendCallbackLate) > xenvif|FRONTEND: CALLER (10): __PdoD0ToD3 to state 1 (PdoSuspendCallbackLate) > xenvif|FRONTEND: CALLER (11): __PdoD3ToD0 to state 3 (PdoSuspendCallbackLate) > xenvif|FRONTEND: CALLER (12): VifSuspendCallbackLate to state 4 > xenvif|FRONTEND: CALLER (13): __FrontendSuspend to state 0 (FrontendSuspendCallbackLate) > xenvif|FRONTEND: CALLER (14): __FrontendResume to state 1 (FrontendSuspendCallbackLate) > xenvif|FRONTEND: CALLER (15): (none) to state 0 > > xen|BUGCHECK: ====> > xen|BUGCHECK: ASSERTION_FAILURE: FFFFF80113373A40 FFFFF80113373A60 000000000000144E 0000000000000000 > xen|BUGCHECK: FILE: E:\jenkins\workspace\nvif_private_martinhar_CA-355670\local\src\xenvif\transmitter.c LINE: 5198 > xen|BUGCHECK: TEXT: !NT_SUCCESS(status) > So the question remains, how are we hitting the failure? Your source lines and mine clearly don't match. Exactly which assertion is failing? Paul > > > > From win-pv-devel-bounces@lists.xenproject.org Thu Apr 21 12:30:11 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 21 Apr 2022 12:30:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.310092.526728 (Exim 4.92) (envelope-from ) id 1nhVwo-0001wn-4p; Thu, 21 Apr 2022 12:30:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 310092.526728; Thu, 21 Apr 2022 12:30:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nhVwo-0001wf-1p; Thu, 21 Apr 2022 12:30:10 +0000 Received: by outflank-mailman (input) for mailman id 310092; Thu, 21 Apr 2022 12:30:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nhVwm-0001wZ-Gn for win-pv-devel@lists.xenproject.org; Thu, 21 Apr 2022 12:30:08 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c4d18d9a-c16e-11ec-a405-831a346695d4; Thu, 21 Apr 2022 14:30:06 +0200 (CEST) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: c4d18d9a-c16e-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1650544206; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=iuaTEJR5rePCH18bNySt8pNpwAbtUse54W6AgEHPfqY=; b=YGND2UwIyq5ux2qNPEh5zKBV6TXxWl7QliNzpGPjnR6J0pkAIAn1Dv7k aay1Hldy3DQXL4DmlccaEAbuwFNlye+BxfA3PfyolKaeKj+xfwzL2ptzv 5yB2mE4o/SY8SGc3v2im+Hr4YBsfHqhvbszC2b6zHPXdJHW8ynXsDwxos c=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 69478760 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:4OWTKK7pZiVmQzTnx8TnYQxRtGTHchMFZxGqfqrLsTDasY5as4F+v mtOXW2EMvvcMTT3c4wiYdngoUMHupaDz9BnGQNt/ihjHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YTjWlvU0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurS2SjUkF6rugN8lSiZ2SxBuBYd0+qLIdC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKsYpXxmiyrcDOomaZvCX7/L9ZlT2zJYasVmQ6eCO JpGN2IHgBLoYzNdJHA8EpICusinj0amWjBxogmnnP9ii4TU5FMoi+W8WDbPQfSVRMMQhljdq m/Y8mDRBhABKMfZ2TeD6mirhOLEgWX8Qo16KVGj3qc02hvJnDVVUUBIEwvgyRWktqKgc9RcG UE9/Qg2lpAry2Lzf8nFdS+6vXHR63bwROFsO+E97QiMzI/d7ACYGnUIQ1Z9VTA2iCMlbWd0j wHUxrsFERQq6eTIEizFqt94uBvoYUAowXk+iTjopOfvy/3qu8kNgx3GVb6P+4bl34SuSVkcL 91nxRXSZon/b+ZWj81XHnid2lpAQ6QlqSZvuG3qspqNtF8RWWJcT9XABaLnxfhBNp2FaVKKo WIJncOThMhXU8zVyHTXHLpSRuH1jxpgDNE6qQc+d3XG327zk0NPgKgKuG0uTKuXGppslcDVj L/75loKuc470IqCZq5reYOhY/nGPoC7fekJosv8N4IUCrAoLVfv1Hg3OSa4gjC8+GBxwPpXE crKLq6R4YMyVP0PIMyeHLxGj9fGB0kWmAvueHwM50n5gefGOC7JGN/o8jKmN4gE0U9Nmy2Nm /43CidA40w3vDHWCsUPzbMuEA== IronPort-HdrOrdr: A9a23:sTid2aMSW+UlY8BcTs2jsMiBIKoaSvp037Eqv3oedfUzSL39qy nOpoV86faaslYssR0b9exoW5PwJE80l6QFgrX5VI3KNGKN1VdARLsSircKqAeAJ8SRzIFgPN 9bAspDNOE= X-IronPort-AV: E=Sophos;i="5.90,278,1643691600"; d="scan'208";a="69478760" From: Owen Smith To: CC: Owen Smith Subject: [PATCH] Reduce log spam Date: Thu, 21 Apr 2022 13:29:45 +0100 Message-ID: <20220421122945.371-1-owen.smith@citrix.com> X-Mailer: git-send-email 2.32.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Squash errors generated by IoctlDirectory returning no sub-paths Reduce logging level in ThreadCreate Signed-off-by: Owen Smith --- src/xeniface/ioctl_store.c | 25 +++++++++++++++++-------- src/xeniface/thread.c | 2 +- 2 files changed, 18 insertions(+), 9 deletions(-) diff --git a/src/xeniface/ioctl_store.c b/src/xeniface/ioctl_store.c index 9116e82..97062df 100644 --- a/src/xeniface/ioctl_store.c +++ b/src/xeniface/ioctl_store.c @@ -218,6 +218,7 @@ IoctlStoreDirectory( PCHAR Value; ULONG Length; ULONG Count; + BOOLEAN SquashError = FALSE; status = STATUS_INVALID_BUFFER_SIZE; if (InLen == 0) @@ -228,14 +229,17 @@ IoctlStoreDirectory( goto fail2; status = XENBUS_STORE(Directory, &Fdo->StoreInterface, NULL, NULL, Buffer, &Value); - if (!NT_SUCCESS(status)) + if (!NT_SUCCESS(status)) { + if (status == STATUS_OBJECT_NAME_NOT_FOUND) + SquashError = TRUE; goto fail3; + } Length = __MultiSzLen(Value, &Count) + 1; status = STATUS_BUFFER_OVERFLOW; if (OutLen == 0) { - Trace("(\"%s\")=(%d)(%d)\n", Buffer, Length, Count); + Trace("(\"%s\")=(%d bytes)(%d items)\n", Buffer, Length, Count); goto done; } @@ -243,7 +247,7 @@ IoctlStoreDirectory( if (OutLen < Length) goto fail4; - Info("(\"%s\")=(%d)(%d)\n", Buffer, Length, Count); + Trace("(\"%s\")=(%d bytes)(%d items)\n", Buffer, Length, Count); #if DBG __DisplayMultiSz(Value); #endif @@ -262,11 +266,14 @@ fail4: Error("Fail4 (\"%s\")=(%d < %d)\n", Buffer, OutLen, Length); XENBUS_STORE(Free, &Fdo->StoreInterface, Value); fail3: - Error("Fail3 (\"%s\")\n", Buffer); + if (!SquashError) + Error("Fail3 (\"%s\")\n", Buffer); fail2: - Error("Fail2\n"); + if (!SquashError) + Error("Fail2\n"); fail1: - Error("Fail1 (%08x)\n", status); + if (!SquashError) + Error("Fail1 (%08x)\n", status); return status; } @@ -310,7 +317,7 @@ PXENBUS_STORE_PERMISSION __ConvertPermissions( __in ULONG NumberPermissions, __in PXENIFACE_STORE_PERMISSION XenifacePermissions -) + ) { PXENBUS_STORE_PERMISSION XenbusPermissions; ULONG Index; @@ -411,7 +418,9 @@ IoctlStoreSetPermissions( for (Index = 0; Index < In->NumberPermissions; Index++) { Trace("> %lu: Domain %d, Mask 0x%x\n", - Index, Permissions[Index].Domain, Permissions[Index].Mask); + Index, + Permissions[Index].Domain, + Permissions[Index].Mask); } status = XENBUS_STORE(PermissionsSet, diff --git a/src/xeniface/thread.c b/src/xeniface/thread.c index 4a5d425..4d767a0 100644 --- a/src/xeniface/thread.c +++ b/src/xeniface/thread.c @@ -130,7 +130,7 @@ ThreadCreate( (*Thread) = __ThreadAllocate(sizeof (XENIFACE_THREAD)); - Warning("Create thread %p %p\n", Function, Thread); + Trace("Create thread %p %p\n", Function, Thread); status = STATUS_NO_MEMORY; if (*Thread == NULL) -- 2.32.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Thu Apr 21 13:09:26 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 21 Apr 2022 13:09:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.310138.526809 (Exim 4.92) (envelope-from ) id 1nhWYo-0001Wz-0V; Thu, 21 Apr 2022 13:09:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 310138.526809; Thu, 21 Apr 2022 13:09:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nhWYn-0001Ws-Tg; Thu, 21 Apr 2022 13:09:25 +0000 Received: by outflank-mailman (input) for mailman id 310138; Thu, 21 Apr 2022 13:09:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nhWYm-0001KW-W8 for win-pv-devel@lists.xenproject.org; Thu, 21 Apr 2022 13:09:25 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 42da2916-c174-11ec-a405-831a346695d4; Thu, 21 Apr 2022 15:09:23 +0200 (CEST) Received: from mail-co1nam11lp2173.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Apr 2022 09:09:21 -0400 Received: from MW4PR03MB6347.namprd03.prod.outlook.com (2603:10b6:303:11e::22) by CO3PR03MB6741.namprd03.prod.outlook.com (2603:10b6:303:17c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18; Thu, 21 Apr 2022 13:09:15 +0000 Received: from MW4PR03MB6347.namprd03.prod.outlook.com ([fe80::e9f0:3774:1ce9:6059]) by MW4PR03MB6347.namprd03.prod.outlook.com ([fe80::e9f0:3774:1ce9:6059%9]) with mapi id 15.20.5186.013; Thu, 21 Apr 2022 13:09:14 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 42da2916-c174-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1650546563; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=0BM5G7OC0dotFH1QRYgXbWqJ0EuXhr7h+08B+xfzgek=; b=ZjqIXPf/aP2X55YGFpMIHDmfy8TCUIxBDebUHAFChf1hzlTRaV60XMD2 iQM9+n8rEYjF3c2fwyspT+v86fNLPWlx8hvyBBP7zKmcXUd5Lu8H9AxGZ gE/lb2J+KfEelzVC1WAFHx09JbxCCpW3JJ/R+ORwRcWePonZVGzWN+tvh E=; X-IronPort-RemoteIP: 104.47.56.173 X-IronPort-MID: 69483900 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:rr3Keam144BjQKskGG63bSXo5gzjJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIZWW2Gb/jbZmPwLYh1btux9hsP757Vy9JnSgZlpHxhQyMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DlWVrV4 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYd1gzBJf1uv0hXlpaHB5dB4t3/IeZGC3q2SCT5xWun3rE5dxLVRhzFqpBv+F9DCdJ6 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOXu5kBg2xYasNmRJ4yY +IcYCBzbRKGYxRVJFoGIJk/gP2plj/0dDgwRFe9+/trszOClFQZPL7FMfjHYfiqH+FpuX3Hh Xvj2ULnPR8lO4nKodaC2jf27gPVpgvjUZ8WPK218LhtmlL77nMSDlgOSx63rOe0jma6WslDM AoE9yw2t68w+Ue3CN7nUHWFTGWsuxcdX59bFLQ84QTUk67MuV/GXS4DUyJLb8EguIkuXzs22 1SVntTvQztyrLmSTnHb/bCRxd+vBRUowaY5TXdsZWM4DxPL/+nfUjqnog5fLZOI IronPort-HdrOrdr: A9a23:eRFpsa+Ek7mk7VjqeORuk+Fsdb1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQkdcKO7SdK9qBTnhNRICOgqTPyftWzd1FdAQ7sSibcKrweAJ8S6zJ8l6U 4CSdkyNDSTNykcsS+S2mDRfLgdKZu8gcaVbIzlvhRQpHRRGsRdBnBCe2Sm+yNNJDVuNN4cLt 6x98BHrz2vdTA8dcKgHEQIWODFupniiI/mSQRuPW9p1CC+yReTrJLqGRmR2RkTFxlVx605zG TDmwvloo2+rvCAzAPG3WO71eUZpDKh8KoDOCW/sLlXFtzesHfrWG2nYczGgNkBmpDu1L/tqq iJn/5vBbU115qbRBDOnfKk4Xic7N9p0Q6v9bbQuwqeneXpAD09EMZPnoRfb1/Q7Fchpsh11O ZR03uerIc/N2K3oM3R3am9a/hRrDvCnZPiq59is1VPFY8FLLNBp40W+01YVJ8GASLh8YgiVO 1jFtvV6vpaeU6TKymxhBgm/PW8GnAoWhuWSEkLvcKYlzBQgXBi1kMdgMgShG0J+p4xQ4RNo+ 7ELqNrnrdTSdJ+V9M1OM4RBc+sTmDdSxPFN2yfZVzhCaEcInrI74X65b0kjdvaDaDgDKFC6q gpfGkoy1LaIXiedvFm9Kc7gyzlUSG6QSnnzN1Y6txwpqD8LYCbQhG+dA== X-IronPort-AV: E=Sophos;i="5.90,278,1643691600"; d="scan'208";a="69483900" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WjSUe4U6Oh0nn8CGXmKvcDXVsmJ/xm7bfEXt4iDW/++Q2GyKMbVuU8VNqJb9xrNF4KglQmwwbYHKtz/GlOWfH937kcvcwRGcaTMChWjzkOjAYWBZ+aF69b5AldKgvmNYvXioQt4AUxJRl4C/kH5/H1nUFRhElL7v3bkCgow4eMgY/NfwNsZ4lHK2aw2abPuZfhQIPg0+UnLl5plZ6Rhe3vtgzYW1EXXHLVrvOFX9+scESlZnV0ANYkbYv9GaHbVrQnlXtFxPmRFybeAXoFqadsGwJv1GJkdHbBGTIgScDbgC2cNqN0LnCwXMGAAFXek/ARnRsKD5+cp1wTlh2Lgizw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0BM5G7OC0dotFH1QRYgXbWqJ0EuXhr7h+08B+xfzgek=; b=Y/4boezwi9i7kjbKKXyjHi672g/X8x9W1lF/Y/WQg8/pgLXcVjMpBPpGoD0qsJ8wnIkkE0CP956xmrAqAau/3DpRPBv5qN+3Ub0g8T+0/8mI5BHcyHP5/CYG8ZOdXkb2ZG05B4Cvorw3y0m/r2/nBuLP7xgnP0BW7wPJO13TzXwBmyeM3m9uwzLS1shok0P0aSehG5QsZteL/thjwK4SveadB/IhvYslbniU3msqpmZ1Ua1cGWv3zR9LS/7bN1bl5+JbFCVz1TWyDy8vaYCqksSOxUp6rVGef7u7DsPv6FMFvW9cpE9ww/ln89klyZ70hQSkxGV1HPJVBbd2XnAQpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0BM5G7OC0dotFH1QRYgXbWqJ0EuXhr7h+08B+xfzgek=; b=SZDDfS/ekVztgsQDXehv7fKkg+57XjqKymrsOYtZV3P22SILP2yOw5I/n4z7dpur+SmTSwC5znyhUpGkCvMKKx2cSafd5X4dp7lC9wtEcdkuietXIQpS6uP0yY3p5SAV2dzpc58//ncPNJ3CiFoImFR9Qr3myWkhWDeiuwheVMw= From: Martin Harvey To: "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Subject: RE: XenVif div by zero on Tx path after resume. Thread-Topic: XenVif div by zero on Tx path after resume. Thread-Index: AdhP6kAbDA19BbYtRECv6F4UUU/GxAD72daAAGmnvwA= Date: Thu, 21 Apr 2022 13:09:14 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fc10c36d-3297-4f77-2128-08da2398227f x-ms-traffictypediagnostic: CO3PR03MB6741:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3obK1XouuQzojZZGWERifNf9olSak7AmZX4H3ysb74Zn10h++bk0qZgmYKTNF3jgJVCEys3QMNClSAaB60gx7s27YhlOsBMklJEh/d9dXwhUEuFe1OVtY61rLJd34G1sJBUvkKNt0PNUrk2sCWT00675gLx5Tbepd/EuQroJSgzZbHUFYyyL9LB7+sXHWbVOjuINGPtK0SkJxmm0Tet6mdoj50Ta6vO003sBx35HD6xzko5orTRYs3lNdoIc60aONSOgyBqD0myvYZlofieNnmMDcdi/GtUNgaJDqM2R95KR9WfOsY5sdw7Hfnl5nbgE7Tvn/WxdkdteMXuyOCcd7uaAvHKzI6POdvZd9k+naKZ4V/nfkWVh4VHMcLaNAqX7yK/jPbuWZV8tZbnFMpdX32emcq809O8swC2jKFUJeXH17fUoxJN6e2GcPzgV5oAqpDAQYGl04NZSkaTyTi0dtSX01Bqob2dEKR016hlM1P9cuDVJseJeuWY52Xcbn1pu/YhWPfN0crxMz1Wa4VDjasbEXwXsYgSP2TqX1J6gxsVUeekpIH5vsgPhcVWMpJfpSY9F6nWAkh/Z0yGNZDagFoVR37DyoWmseA6nOg5MVZMPdjvV/qvLhWm22NtYsJQ3jwDGGIhk4UHgeK2/kMoHIAKTUw1axT1j77SLMB9FU4igT7pKNTOxnHAz48GHW+/YiAb31bpRqmkgmcZLwHyNIw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6347.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66446008)(6506007)(316002)(186003)(122000001)(33656002)(110136005)(7696005)(26005)(508600001)(55016003)(9686003)(53546011)(38100700002)(38070700005)(83380400001)(66476007)(64756008)(71200400001)(86362001)(66556008)(44832011)(8936002)(52536014)(5660300002)(66946007)(82960400001)(2906002)(76116006)(8676002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bVEwdmMwVFBtWUJ3MkZuaXR2U0RiNG95cEpIUFZkMmQrZHNaUkR2c3VDT3pB?= =?utf-8?B?VkcrMW1PVkZKdVVjdXRJdFhtOUZMb294Tmw5SUc1QzladzRkbDR1QnFwWFdH?= =?utf-8?B?d2R0cHEvbWtodDZxRnlTL21HSmJVK2RkR2drTjJuVWZTZGZWUy8zcVhucUhm?= =?utf-8?B?R1VrV0ZRSWxXTjBGMEdGWUtXYkt2bldzZG5uR0hTemg1LzJyWSs3WFo5RzVP?= =?utf-8?B?R1NvcW1JNU1mS0laNEpBMSs1V1l4Y0ZZWmdWNFhZREltRWkyeXAvalNMTXBF?= =?utf-8?B?bHQ2clpudy9vTTFKS3dmT3kyeEFDd0w0dGRUNkpNeWI0U3N4aFAyRDdFR0ZP?= =?utf-8?B?dEE2aHhDaFZidnkrdytiUHQxL3l2bG5LcVpmbHFJRmZKQTU2NzdFMVE1dnNh?= =?utf-8?B?OHJGc3VwRmRsak5vTytjOFNJMzh2MnY1NmZpM0FxanB3dUNyNWFLZFphUStE?= =?utf-8?B?R1pDQ3h5ZWYxVFVUV2xmSDF5czdBaFNBZXgrS0VaYStmeG40N0JkRkVLRlBy?= =?utf-8?B?Sk1uR1l1bDVXcFI2RFNhWG4zMUFYVUdzekNvd0VlOXlRYXJpTEwramRyTCts?= =?utf-8?B?cE1FWFA5M00vRmE3MHArbFF0cFpSY0ZwYVdOcTZCS0dxVE1MYTd0RnJpQjlH?= =?utf-8?B?dmpoNmRXV29HdklBOU85MStUelRKZVgyR0JGTC9YSFd2VG04V21CUWVMUmdu?= =?utf-8?B?akhYYmJ2ZnlBOG5PRTNLbXc4Yk4zYTdwTnZMdnZ2T1lBckZIRXgwWFVwdDAv?= =?utf-8?B?SHp3NldIVHh0TElzZCtBQWhjYzVtcDBETVp5Z1JlZWk0NzlYdHFNUlB4S3Vy?= =?utf-8?B?M3JYczRPeXJNSXluS3Yrcjd1R0NmSm56Tk1RbzQ3NGIrOTdPbVlseU9IRita?= =?utf-8?B?R1RPdDUzcnJ1U05rU25YbHU5RDNCeG42WXlZa0ZzUi9mWWsybXB4amNHMXlY?= =?utf-8?B?RHZDbVZoZS9LN091ZzRXNVd1NTZtR25DcDNUck9kVDcvaHlPQy8wQk9lVXlS?= =?utf-8?B?OWxkUVFBSjJYbmFQUjBVbmorZmNBMHdDTUNFNXFOWDhzN3ZNUWNOYmZCbWMz?= =?utf-8?B?c0JrQXN4MGVsRkZHcjVQd2wyQVB6M0YrenZpc0xNL0NmTVVpenBjQ0xWY0JV?= =?utf-8?B?c09OYm5PdXAySGFTMWdzTm1uSXZINnE5V2pQS2hzbVJRTXpIcVdhQTROWGsx?= =?utf-8?B?VEtaWDBWTng5dkdaNmtvaEYzNDdpQlpoYkRnWlExZjVvanVxcGtmdjQvTG1x?= =?utf-8?B?WlJVc1U4S3ljSW1DNm1CMXBLMjRmK0hna21zYm9aZ3BKMzBDVzcyZTV0NFJa?= =?utf-8?B?bGxzSUx0TkxCRFFPRFg5dndhNllUa2VvcEw0SzliREFNT1JNN2xTUkMvZDZM?= =?utf-8?B?eGVwNGpJN084ZTFnaHNFN3dmWjl0cklhb2ZjZjdIdGtJMWJkK3JlL29OOU1a?= =?utf-8?B?WWZlVmZrY21QS3Rib1ZaeEMwK1FEbjBFRTJTSUtyM2VhdWpIM3ZaemN0Z1Np?= =?utf-8?B?dEZLY2xCTkpXalByTU1EK3VoMjFWT21ZLzQ0bW54c2NiQUc4WG5JSm04K3cr?= =?utf-8?B?VGs4cE0vcFVEMEZNZ09KZmhyZFdCWldBZk93UEdRMVpDMHJTT21FWGVwN05a?= =?utf-8?B?aVRMQ1FZdUVjTXQzK20rQlB5NWU3bFpxaXVRMGxOdGE3b3FlTDNnL1B2aG5M?= =?utf-8?B?a1NSV1hqaWxWSXVzR0QyQXROQzhIWkc4M3BUekxOS2FGSmkrVElUZWo2YVph?= =?utf-8?B?VU5qZ1NRRzluV0ZlRHc1Nmg0dXpQMlU5V2xVMDYySFYwYkVWc1lJVXV3OU9p?= =?utf-8?B?Q2plclJZc3hKVXoyRFRLWXlTckI4MFE3dytETXNLazJpaXIrSkgvZXZmQnUx?= =?utf-8?B?Mk1vTndXV0FXdW9QQXE3VVNoVjRNTTJkV1dNR2g5ckp3eFlQUlNXeC9pdDVC?= =?utf-8?B?RmRwcTNKTEYzNkgwNEhveDB1QVJ4b1NtVk1nL3NqTkcwaXpQaWpFaXdBVnNB?= =?utf-8?B?djdMUWtxTE5TV3BPbEtFblk2ZXVKdDlnZ1dFZEZsbVhsWnJyMVhxMnJzU0F6?= =?utf-8?B?ckZUUy9JUTFHNmRBWlpRY2w5UVkwa3YvKzZOWHVKM09rbU42QStxSFI0bSth?= =?utf-8?B?b01ZYTdDdWltbkRGSnZSR01pcHR4R09vbXVYb2tCc1JhV3RIbXFOMEcvTEtE?= =?utf-8?B?RHAwSkpxYTY1N3VzRDAwZFVEcyt1UlJQSmkyb0wvck90MWZpS1VvUkRTMm01?= =?utf-8?B?S2x1dmE4RFVqN3dNNnA3ajdxaWNyQ1dzLy83ZW5aUkI3TExhTHY3dFNZeFlr?= =?utf-8?B?R094aHlFZXlnKzV1WEtGbm53UllpWVNWeTJhWE55OGlpYlIxVld5bFBwRFpk?= =?utf-8?Q?whceT0KwHysYvvVE=3D?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6347.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc10c36d-3297-4f77-2128-08da2398227f X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2022 13:09:14.6635 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5gUdUF3G9hTG/pBFlcvAiaCULg3r9722raBzkLvrhLmOar+de6X0w7Vckw3sUkkegfov/fvyiKn7NIClJvgvZS1MoyYhcKpLw7aa3hVcpnU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR03MB6741 DQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiB3aW4tcHYtZGV2ZWwgPHdpbi1w di1kZXZlbC1ib3VuY2VzQGxpc3RzLnhlbnByb2plY3Qub3JnPiBPbiBCZWhhbGYgT2YgRHVycmFu dCwgUGF1bA0KU2VudDogMTkgQXByaWwgMjAyMiAxMTozOQ0KVG86IHdpbi1wdi1kZXZlbEBsaXN0 cy54ZW5wcm9qZWN0Lm9yZw0KU3ViamVjdDogUmU6IFhlblZpZiBkaXYgYnkgemVybyBvbiBUeCBw YXRoIGFmdGVyIHJlc3VtZS4NCg0KPiBFdmVuIHRoZSBsYXRlIHN1c3BlbmQgY2FsbGJhY2sgcnVu cyBvbiBhIHNpbmdsZSB2Q1BVIGF0IERJU1BBVENILCB3aXRoIGFsbCBvdGhlciB2Q1BVcyBzcGlu bmluZyBhdCBESVNQQVRDSC4gVGh1cyB0aGUgb25seSB0aGluZyB0aGF0IHNob3VsZCBiZSBhYmxl IHRvIHByZS1lbXB0IGl0IGlzIGFuIGludGVycnVwdC4gSGVuY2UgdGhlcmUgKnNob3VsZCogYmUg bm8gc2NvcGUgZm9yIHRoZSB0aGUgbmV0d29yayBzdGFjayB0byBzZW5kIGFueSBwYWNrZXRzIHVu dGlsIHRoZSBjYWxsYmFjayBoYXMgY29tcGxldGVkIGl0cyB3b3JrLg0KDQo+IFdpdGggYWxsIHRo ZSBwb3dlciBzdGF0ZSBtYW5hZ2VtZW50IGRvbmUgaW4gdGhyZWFkIGNvbnRleHQsIGl0IGlzIGF1 dG9tYXRpY2FsbHkgYmxvY2tlZCBieSBhbnkgc3VzcGVuZC9yZXN1bWUgYmVjYXVzZSBvZiB0aGUg dkNQVSBjb3JyYWxsaW5nIGFuZCB0aGUgZmFjdCB0aGF0IHRoZSBhY3RpdmUgdkNQVSBydW5zIHRo ZSBlbnRpcmUgY3ljbGUgYXQgRElTUEFUQ0ggb3IgaGlnaGVyLiBIZW5jZSBubyBuZWVkIGZvciBh bnkgZnVydGhlciBzeW5jaHJvbml6YXRpb24uDQoNCiANCj4geGVufEJVR0NIRUNLOiA9PT09Pg0K PiB4ZW58QlVHQ0hFQ0s6IEFTU0VSVElPTl9GQUlMVVJFOiBGRkZGRjgwMTEzMzczQTQwIEZGRkZG ODAxMTMzNzNBNjAgMDAwMDAwMDAwMDAwMTQ0RSAwMDAwMDAwMDAwMDAwMDAwDQo+IHhlbnxCVUdD SEVDSzogRklMRTogRTpcamVua2luc1x3b3Jrc3BhY2VcbnZpZl9wcml2YXRlX21hcnRpbmhhcl9D QS0zNTU2NzBcbG9jYWxcc3JjXHhlbnZpZlx0cmFuc21pdHRlci5jIExJTkU6IDUxOTgNCj4geGVu fEJVR0NIRUNLOiBURVhUOiAhTlRfU1VDQ0VTUyhzdGF0dXMpDQo+IA0KDQo+IFNvIHRoZSBxdWVz dGlvbiByZW1haW5zLCBob3cgYXJlIHdlIGhpdHRpbmcgdGhlIGZhaWx1cmU/IFlvdXIgc291cmNl IA0KbGluZXMgYW5kIG1pbmUgY2xlYXJseSBkb24ndCBtYXRjaC4gRXhhY3RseSB3aGljaCBhc3Nl cnRpb24gaXMgZmFpbGluZz8NCg0KQWhoYS4gSSBzaW1wbHkgaW5jbHVkZWQgYW4gYXNzZXJ0aW9u IGluIFRyYW5zbWl0dGVyUXVldWVQYWNrZXQgaWYgRnJvbnRlbmQtPk51bVF1ZXVlcyA9IDANCihh Y3R1YWxseSBhIG4gYXNzZXJ0aW9uIG9mICFOVF9TVUNDRVNTKHN0YXR1cykgb2Ygc29tZSBsb2Nh bCB3b3JrYXJvdW5kIHRoYXQgY2hlY2tzICMgcXVldWVzKS4NCg0KU28sIHRoaXMgaXMgc2ltcGxl Og0KDQotIFdlcmUgYXJlIGZhaWxpbmcgYmVjYXVzZSBUcmFuc21pdHRlclF1ZXVlUGFja2V0IGdl dHMgY2FsbGVkIGJlZm9yZSBWaWZTdXNwZW5kQ2FsbGJhY2tMYXRlLCBzb21ldGhpbmcgd2hpY2gg ImluIHRoZW9yeSIgc2hvdWxkIGJlIGltcG9zc2libGUuDQoNClNvLCBwZXJoYXBzLCBhbHRob3Vn aCB0aGUgcHJvY2Vzc29yIGNvcnJhbCBvbmNlIHdvcmtlZCwgaXQgbm8gbG9uZ2VyIGRvZXM/DQoN Ck1ILg0K From win-pv-devel-bounces@lists.xenproject.org Thu Apr 21 13:15:31 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 21 Apr 2022 13:15:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.310159.526834 (Exim 4.92) (envelope-from ) id 1nhWeg-00043f-Tm; Thu, 21 Apr 2022 13:15:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 310159.526834; Thu, 21 Apr 2022 13:15:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nhWeg-00043Y-Qm; Thu, 21 Apr 2022 13:15:30 +0000 Received: by outflank-mailman (input) for mailman id 310159; Thu, 21 Apr 2022 13:15:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nhWef-00043S-7v for win-pv-devel@lists.xenproject.org; Thu, 21 Apr 2022 13:15:29 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1b361d58-c175-11ec-8fc2-03012f2f19d4; Thu, 21 Apr 2022 15:15:27 +0200 (CEST) Received: from mail-dm6nam12lp2174.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Apr 2022 09:15:24 -0400 Received: from MW4PR03MB6347.namprd03.prod.outlook.com (2603:10b6:303:11e::22) by SN6PR03MB4237.namprd03.prod.outlook.com (2603:10b6:805:ba::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Thu, 21 Apr 2022 13:15:23 +0000 Received: from MW4PR03MB6347.namprd03.prod.outlook.com ([fe80::e9f0:3774:1ce9:6059]) by MW4PR03MB6347.namprd03.prod.outlook.com ([fe80::e9f0:3774:1ce9:6059%9]) with mapi id 15.20.5186.013; Thu, 21 Apr 2022 13:15:22 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 1b361d58-c175-11ec-8fc2-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1650546927; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=wHP4EOeDbYd3zVW12HcOjAHOQYjwt+2rNJN2DeK3XrU=; b=hI1eoZgMfythEHxGPSixLs1flzhM5XwDlCFeswYu6kLQdYe0IbQ2QGbP AGhZehiyCB4Tsr7Jgkf1mTrIJEPGYerYCXJP3N12pV2fwlmVeoNpfX+0Q HzIkGIhSZnJbpVozWqrbpXCkzJHVMI779cLkb4sVaOjO1NUEdHrmlAGhQ E=; X-IronPort-RemoteIP: 104.47.59.174 X-IronPort-MID: 69484645 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:hSJAMKyQaXk+28fW6Eh6t+dVxyrEfRIJ4+MujC+fZmUNrF6WrkVRy TQeCmyHPqvbN2OhL9skPYi08EwD7J6DyoNnHgtp/iAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NY024HhWmthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ Npl5ZmpQgM2YKL1p88jdBBzOntfDYRg5+qSSZS/mZT7I0zuVVLJmq8rIGRoeIoS96BwHH1E8 uEeJHYVdBefiumqwbW9DO5xmsAkK8qtN4Qa0p1i5WiBUbB6HtaeEuOTuoMwMDQY36iiGd7bb tAFaDwpbB3afRBeElwWFIg/jKGjgXyXnzhw9gPJ9fZpvzW7IApZ7J+wItmFeMezV/oEowWY/ 0Dh+nbGDURPXDCY4X/fmp62vcfXlD7/cJIfEvu/7PECqEKSwCkLFlgaWEW2pdG9i1WiQJRPJ koM4C0soKMuskuxQbHAswaQpXeFulsQXoRWGuhjsgWVkPOLv0CeG3QOSSNHZJo+rsgqSDc21 1iP2dT0GThot77TQnWYnluJkQ6P1eEuBTdqTUc5ocEtuLEPfKlbYsrzc+te IronPort-HdrOrdr: A9a23:yVzvpKsro5Agg6E3jDRzbY0c7skCwoMji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJh5o6H5BEDyewKmyXcT2/haAV7CZnishILMFu1fBOTZslnd8kHFl9K1kJ 0QCpSWa+eAQGSS7/yKhzVQeuxIqLbozEnrv5a5854Hd3AIV0gU1XYdNu/tKDwVeOApP/oEPa vZwvACiyureHwRYMj+LGICRfL/q9rCk4+jSQIaBjY8gTP+wg+A2frfKVy1zx0eWzRAzfMJ6m 7eiTH04a2lrrWS1gLc7WnO9J5b8eGRhOerRfb8y/T9GA+cyTpAV74RGYFqewpF5d1H3Wxa0O UkZS1Qe/ibpUmhOV1d6iGdoTUImAxelkMKj2XozUcL6PaJOA4SGo5Pg5lUfQDe7FdltNZg0L hT12bcrJZPCwjc9R6NkeQgeisa4nZcm0BS5tL7TkYvIbc2eftUt8gS7UlVGJAPEGbz750mCv BnCIXZ6OxNeV2XYnjFti03qebcFkgbD1ODWAwPq8aV2z9ZkDRwyFYZ3tUWmjMF+IgmQ5dJ6u zYOuBjla1ITMURcaVhbd1xCPefGyjIW1bBIWiSKVPoGOUOPG/MsYf+5PEv6OSjaPUzve4PcV T6ISFlXEIJCjzT4Je1reJ2Gzj2MRSAdCWozN1C7J5kvbC5TKb3MES4OSMTr/c= X-IronPort-AV: E=Sophos;i="5.90,278,1643691600"; d="scan'208";a="69484645" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gof6bh15FkSgOCTo1yNodgF1NqE7I+qgJkNeYFOjaftkh8aPEXE1Cz2xYnjSf1sNa56DmmpmJQ831Xdi2wRUXOY4yDzAqDxoqTDjK+swntxge5ZRx9xLXrATanXvzyr3hLY8GEbgLL/Vc/6wW2qavnhMy7aTN4H1CG6JVC6k2eUq4WM+82N2CHEuyTCXMBBvLQxph0pi37U8jV5o2Lxr3s5QnbLkOnbrEPOqHecQ3HU55f5OOd5ZuIcMAFbFv9UHsi4cmpYzKAtFCEj3eFh7kMAF8zebWT5tR68+J5eBHQZ5NBmQZxWuH+htHDFjiF+xq+ik1EJyqmxoBgiGVFsZhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wHP4EOeDbYd3zVW12HcOjAHOQYjwt+2rNJN2DeK3XrU=; b=c8dclURdM++cbJImRMqhUdbGRfwQ38tQLI1mpudqc4velsFuzNu2hxNepOYm7lAHpI1y2SM2DVshTh+F1LK1VoYRS/2TdhfnOHw+f9ZlhvLewCRl0c8hn1paWCNwJzDB2iquv6x+vCMS7idcyBH1Q++tlzWeypD7mgWZbNR4vh+kUlkUkHzGybWXHUqXNdDgjedbCVGLpe9LbVyHbQ/mhC99T9sBIn4poU2E1fgvpE3sh40Y8f5dJF3eeuLmqdPw1np00furam+oaKvaEcO06EKTocdnPPotqvdpwrU1RI/vQWpMDWSt1407K3eIjZ0obwtY+vnuowxeaqoiGpCH+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wHP4EOeDbYd3zVW12HcOjAHOQYjwt+2rNJN2DeK3XrU=; b=Dv31yn8LSgcmOHQiogcqQ6deInzc/tWN7VnfEreG76w4DxIGlB8HolK84u68BiTBK2BKIcfk+TD7N+5E0j/dQhAG6/FnpI7Mttk4koZzaHxcqpauotFpIzJ8a2lCyglxtq2MZVvXPucXJH3hMp8Y5twswpEWcGtcME+EwIu4HeA= From: Martin Harvey To: Martin Harvey , "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Subject: RE: XenVif div by zero on Tx path after resume. Thread-Topic: XenVif div by zero on Tx path after resume. Thread-Index: AdhP6kAbDA19BbYtRECv6F4UUU/GxAD72daAAGmnvwAAAFp2cA== Date: Thu, 21 Apr 2022 13:15:22 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ab9bddb4-9aa0-41de-76e7-08da2398fdeb x-ms-traffictypediagnostic: SN6PR03MB4237:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hCSxpvAmksKB/EEcAQnjG2W8tYS5lgLQSPYIGZ1HDi2eCyQvdsm+U7VNpJIJ0eBMmjyH4c8pT1TQKx6zx31YtMRvyycr/isnuohyPglaObCL4/OJwxUBdsiGPaUqt0PjdVPHFvVbh+uwACvXHpaqQQgEgoeNMIDUBSmq0uWZ+jIPAJiSK88WgnbOgltHPJsK+VbdL+U/omZVqPpc2xfk0nQqWFIx7LgUgBL7fUMNZpOltpoD5YGLUamB+r6as9H0xHHQokTfcZ592Dx8xTVTjYno/6wlnOTopEUpbwNXj2u7+dwzj3W+BSGj9H1HRsYh/uQdxgGYdeLGyJMggJ+fHrZ/5Jgeo/M/xoh/DgjSlTTI2Tk+xJi6KntEjVvwfWTkKVT/nmV9fKOk5lny84mPxK2Du2ihhzjUzpaXKWf7gLVZb0PnzZx2Uz5U8zNVrJtSkAtFqEVGyAkNhYmOZwq7l1/pw0Ec9mtiETJeTuN2btu+i0N5KPdHqv8vkLoMxxKnVjbbAcZOpVhNomfPRNY9nnRoZIPHGp3qLI2oIROPKdLjiAmIrWmmEFNlMiXRB2NWvLkHKMkYoUjsJF6411uA65t4vuGh5qtxk0DJ+Tew0c6CRmPiSok/4lMTLIo3BTr3JhTfI+hm7ZHi6GDqBQ4a1XgMl6XcJ3XDDJoGOyobCmMrqsdIsxKA6jRKcHsebUwauJg0e/eVQPEJfQU4jx/gGg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6347.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(33656002)(38070700005)(186003)(66946007)(110136005)(122000001)(86362001)(8936002)(44832011)(82960400001)(2906002)(316002)(52536014)(4744005)(53546011)(71200400001)(2940100002)(38100700002)(7696005)(83380400001)(9686003)(5660300002)(6506007)(76116006)(8676002)(55016003)(508600001)(66446008)(26005)(66476007)(66556008)(64756008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bUo3THFzQ1VIL2k3TVpPcW1Kdk9zVG1lSzhRQ3FhT3JxTW95NzBVOXRwVW1I?= =?utf-8?B?YTQ1KzlSYjZWeG9HckFGYnN1R2dwRTF6VktINko4Mnl6U2dLbDR4d3pVVW5P?= =?utf-8?B?TTJ2TCt0ZE1ibXFPcEFwTmZRNlk0MEVETXBta0JvejF6K2xML1JKaVdpOHd2?= =?utf-8?B?YXc5cSs2REZYZDBEaERXTThrN0o3cExiWFBObVlReW45YnlVdDR3RktuOGdK?= =?utf-8?B?QVVmWDFqcVRqUEptRHR4eUZoLzFtV2psZk8rMUhTV0l1a2NnNUZNaHdtVjE4?= =?utf-8?B?NlpleS9HaVVhWUlYNHIyZjFNVnNLOXlyQ2NWV1h4VVVKYjFMRUV1c29jR1dv?= =?utf-8?B?dXhlbXBzSTFqTHc3YVFvZkhNZW5FcG1udmtna1NyRU5hYUozdkN6eXB6ek1q?= =?utf-8?B?L0xOUTNHTmppbzJ0VGsrS3NHaHNlTG84RWFVMTRFQ2pBMDQ0WEZZS2dqNFRr?= =?utf-8?B?VWFnSkZQbkxveUw0NzllYXRPdmMzbkhKcS95Wk9yb3hmSkpBY1RucEVtTldV?= =?utf-8?B?RUttN0gweEkrdGxHMTdxZWJDM20zWXNKWGE2eGFNSmE1dnZsdUd3bmlIM05C?= =?utf-8?B?Wll2ZG81b291YjJSWTlEYzNiR1ZIWDRQRkVOTXZOWHhBKzBZY05tZ0JnaG92?= =?utf-8?B?YzRUZ2xkOWVjZUVucldodHlnZ0FFREhzQ2NpTHA0UDVJelY4UWZUU3ZFN0J2?= =?utf-8?B?UFpDYUZ0d01mKzJ2WitlbElIL21aOXJ2V1QybHFxRWJXOEp6dEhOWWUzRGFx?= =?utf-8?B?ak5vRTFBaFFWQjlsWW8ySExaMFNlL1RWbEpTMUtxZWg1RHRsQXY3blJKMmVp?= =?utf-8?B?Z3ovSE5kelJ4cVZ4cE4zekdHdHE3OVQ2RmhpaXR3bzk0clJLeUdFeW8yd094?= =?utf-8?B?R2VtMlpQVERXd2lWWnRBS2FwM1dKWGlpOE54YU14bkNHSkJEOEVENnM0TExx?= =?utf-8?B?T3hQdkxNVW9FelMzZDIrWjR4bmdjc2NrY3gzbmFQbW94V0gyQ2YranJKa2ZU?= =?utf-8?B?aEwrMFBoYlNaYU52WG8ydTRDZ0dYUHlSNmxLZVkrcVExQTFiNkJFM3h5Mlkv?= =?utf-8?B?dE15eE9nMlhkbzE3N2thT0JXUWpZSnNERkcrdFllb2luYVdpWG9KQTMxcG5T?= =?utf-8?B?djlvMlhtNEFtNXluekpYNjRsc01IdEkyeElLUHptenZSV0dOcXBBOGVJRnJy?= =?utf-8?B?Qnl6Y1Z6WFJXMWNIWktkYmhRd2lPYkZpWUpidjhjdmNFZFlkSXlVc1Z2MEp0?= =?utf-8?B?QzN5R1NsR2pNYmFZcHVhQW9SM1FBWXRuYnlLTnNsazNhMTN4S0g4RUhFdXdt?= =?utf-8?B?SURnYXpUQTh3Uk1WTDB4cUhhNEpNU1dKZmdPditzUklwbGZFYU55dFVycnlT?= =?utf-8?B?NmI2ZndtK0pTb3hWMlhlaTY2RUs5NU5lSXJMU2VHTm9ZaUtsUHRyMmp6dnR4?= =?utf-8?B?MXhQNHN4aFdLT055RXh2K0tMY3IzY25hZEtOMEVOR2FpZE9SYldqWDhFRUZq?= =?utf-8?B?emdQQzRWdEFiWE1kVUtHNFFCRG1mRkk0R3hJS2k4bk92MGdMWlZ6Nmp4ZGFV?= =?utf-8?B?blhqRDZoalRzdGJnYTRvMnRIeTlOU0dLL2JnVTFwbUlLSGprU1YrUitiNmpB?= =?utf-8?B?Slg1S2VUUlZzVlRMaWtnYVIrcFJmd21ySE14ZmgrWnNTblZMRDkwT2lYcVF4?= =?utf-8?B?UGRSeFp1d2pLT05mTjdIS2UxUXBaZ3Z1cWY0YllVRXlCNnlHZUp4OG83VWlm?= =?utf-8?B?N0U4WkpQMVlIV0k5NW13REJxZWs3QVQ4UWlNYkI4bFdzdlBVQnNOUnhJUVgx?= =?utf-8?B?YkJtK0U3UUtyRUtnaldxYmxqdVBuOTR3S2xqejFmWGx1NXFPNUpINC96eG0z?= =?utf-8?B?amxBTmI2WGc3eW5wZGhlVE1GSi9nMml1bXhjUm1Yd01VNVFDNVV2NVg1QUpk?= =?utf-8?B?NE00ZFVTSUlVSlVEdnlmODRwUnZIVTd6Z0JsVzBVb1IwMHRlZHdpOVRXMmZS?= =?utf-8?B?cDFYbjd5RU9zbTdRaUJ6aUZXRzA3TVBCTnFoVmFvUzJEcUpyR0lHNHphdmJj?= =?utf-8?B?bVNlTW5TWnpyQ1NOR1FVUHp0ZmdLWGNJMjhsK3hlTUVRNUpsZmVQTGd6cE9t?= =?utf-8?B?L3JNZUN3UENSK0dnbDhsaEpmMFFWUkZ6cFhIaXplbG5lbVJHcGYwbWgxNGVi?= =?utf-8?B?YWViRVpZOXVHS0lBSTNBODdUK0RuZDJZb0ZDOVFIb0J4VkQzQnVxZUprM24r?= =?utf-8?B?eDdQSXdOK1lFQlMzU3BYSFV2UlBGU2JVQkY2emk2S01ZSUVaWGtvV0ZEN0NO?= =?utf-8?B?WGlBYThEbUNaL20zZ0R5cUgwY3hVZjJRSFJXOWRvRFM5YTkrakJqemRxRUpE?= =?utf-8?Q?Y7Im+ByNgqpVkSqk=3D?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6347.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab9bddb4-9aa0-41de-76e7-08da2398fdeb X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2022 13:15:22.8258 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fTqcdofGDdtCj4scFzkxd8li3KOhdLIIafJqjj6JzGwS/t8anbUpG35GqPvQGScddUy+s8VkgU1NsabsCKMsD+Y0Q4hGe+ZxZw+0cr+kZr4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB4237 DQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiB3aW4tcHYtZGV2ZWwgPHdpbi1w di1kZXZlbC1ib3VuY2VzQGxpc3RzLnhlbnByb2plY3Qub3JnPiBPbiBCZWhhbGYgT2YgTWFydGlu IEhhcnZleQ0KU2VudDogMjEgQXByaWwgMjAyMiAxNDowOQ0KVG86IHBhdWxAeGVuLm9yZzsgd2lu LXB2LWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQpTdWJqZWN0OiBSRTogWGVuVmlmIGRpdiBi eSB6ZXJvIG9uIFR4IHBhdGggYWZ0ZXIgcmVzdW1lLg0KDQo+IFNvLCB0aGlzIGlzIHNpbXBsZToN Cg0KPiAtIFdlcmUgYXJlIGZhaWxpbmcgYmVjYXVzZSBUcmFuc21pdHRlclF1ZXVlUGFja2V0IGdl dHMgY2FsbGVkIGJlZm9yZSBWaWZTdXNwZW5kQ2FsbGJhY2tMYXRlLCBzb21ldGhpbmcgd2hpY2gg ImluIHRoZW9yeSIgc2hvdWxkIGJlIGltcG9zc2libGUuDQoNCj4gU28sIHBlcmhhcHMsIGFsdGhv dWdoIHRoZSBwcm9jZXNzb3IgY29ycmFsIG9uY2Ugd29ya2VkLCBpdCBubyBsb25nZXIgZG9lcz8N Cg0KQW4gYWx0ZXJuYXRpdmUgZXhwbGFuYXRpb24sIHdoaWNoIEkgZm9yZ290IHRvIG1lbnRpb24g aXMgdGhhdCB0aGUgc3VzcGVuZCBjYWxsYmFja3MgYXJlIGJlaW5nIHJlZ2lzdGVyZWQgdG9vIGxh dGUsIHNvIHRoZXJlJ3MgYSB3aW5kb3cgYmV0d2VlbiB0aGUgZGV2aWNlIGFwcGVhcmluZyB0byBi ZSBzZXQtdXAgYW5kIGZ1bmN0aW9uYWwgdG8gd2luZG93cywgYW5kIHRoZSBzdXNwZW5kIGNhbGxi YWNrIGJlaW5nIHByb3Blcmx5IHJlZ2lzdGVyZWQuDQoNCk1ILg0K From win-pv-devel-bounces@lists.xenproject.org Thu Apr 21 13:32:18 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 21 Apr 2022 13:32:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.310209.526927 (Exim 4.92) (envelope-from ) id 1nhWuv-0002eV-3h; Thu, 21 Apr 2022 13:32:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 310209.526927; Thu, 21 Apr 2022 13:32:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nhWuv-0002eO-0b; Thu, 21 Apr 2022 13:32:17 +0000 Received: by outflank-mailman (input) for mailman id 310209; Thu, 21 Apr 2022 13:32:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nhWmL-0006Vx-D2 for win-pv-devel@lists.xenproject.org; Thu, 21 Apr 2022 13:23:25 +0000 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [2a00:1450:4864:20::42f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 38713f9e-c176-11ec-a405-831a346695d4; Thu, 21 Apr 2022 15:23:24 +0200 (CEST) Received: by mail-wr1-x42f.google.com with SMTP id s25so1804228wrb.8 for ; Thu, 21 Apr 2022 06:23:24 -0700 (PDT) Received: from [10.7.237.9] (54-240-197-225.amazon.com. [54.240.197.225]) by smtp.gmail.com with ESMTPSA id l22-20020a05600c4f1600b00392889d04c4sm2270345wmq.23.2022.04.21.06.23.22 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Apr 2022 06:23:22 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 38713f9e-c176-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=m3X0MRKS/FagaQFnj6UacajxwUUvtWcS4jufN+DXQqo=; b=OnouMO/Zx8KvUNPAr2cRfi5jp9NljMV9DA12PwKhtzQ1wrppzNAd/dSeZq0lmc174I iZQalMUI1GwC0p+mABYaUBi3+l20xpkDg5MZQCJL8gdvivbHSlVWo/RyUSkntGTVqudO Bo2z7tfGEK/ZsOOhGv1CjNBCz4845gs1usMzOheMJB3M6EOnuQOOlzM5TO0FckQOd/Wc RTuRAOpThYOjmWkzcSB3lTQkY3jFDmLHktOdRsGggoJTzlJLJMJYZow/6uoWxYjHipJ3 51CU/YhrgOvo3ivYDNh8d/ELppVYH5TbYKUna4gCuMDa0PtY3IWwc5yWl16Bs8l7HUYX hoTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=m3X0MRKS/FagaQFnj6UacajxwUUvtWcS4jufN+DXQqo=; b=t0f9NEqNuTiMk2TJ96uB3sQfdmYRbQcmteeqgUEkwjPtivBtfhEVJ8sB2trG0aTQjT Wzo4HDLNPG9hs9WvRPSLx0hujOK7F5itbJcNMeNVoQJS4FvdyKV64TlKBA+GdAOuEZPK Itk5zix2poVM5ht1cLr+xjjKWzO4VI77B+t8vAV1kH0UrjzsWGJJpS7R17bWmxYJSaMH VuCoK8u9ee3u3cJGmbOco76ahHVTBu80h0UGxPxPtnhpkE6BLSQw62Mmw2W3Uh6uZUwK u/Pgd21wFKQtlQme5G+nTjGR93q+a8qHsW1g85Dsbo2Prb+1RzdEwJpmCIJ9rJLFwagP Eu4g== X-Gm-Message-State: AOAM531i9yilfroM0mK5X8f07bD2tzWkJUlW1/ZtZABPOy6gAQ3LwXUU VpfWLaOoD9bjK9NZzgdEfXbA2ltPGlJ17w== X-Google-Smtp-Source: ABdhPJzZFw4pYCIZRtm8Sc/6qins+FzSZ2wfO5WtFcPCR+BTJx7z1hprhhCnISZSgosOPi262MJKwg== X-Received: by 2002:adf:dc41:0:b0:205:8df5:464c with SMTP id m1-20020adfdc41000000b002058df5464cmr18689445wrj.445.1650547403608; Thu, 21 Apr 2022 06:23:23 -0700 (PDT) Message-ID: Date: Thu, 21 Apr 2022 14:23:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Reply-To: paul@xen.org Subject: Re: XenVif div by zero on Tx path after resume. Content-Language: en-US To: win-pv-devel@lists.xenproject.org References: From: "Durrant, Paul" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 21/04/2022 14:15, Martin Harvey wrote: > > > -----Original Message----- > From: win-pv-devel On Behalf Of Martin Harvey > Sent: 21 April 2022 14:09 > To: paul@xen.org; win-pv-devel@lists.xenproject.org > Subject: RE: XenVif div by zero on Tx path after resume. > >> So, this is simple: > >> - Were are failing because TransmitterQueuePacket gets called before VifSuspendCallbackLate, something which "in theory" should be impossible. > >> So, perhaps, although the processor corral once worked, it no longer does? > Looking in xenbus's sync.c and suspend.c, I can't see any issue... but there could be something subtle going on (like Windows deciding all DPCs will be threaded under the hood). > An alternative explanation, which I forgot to mention is that the suspend callbacks are being registered too late, so there's a window between the device appearing to be set-up and functional to windows, and the suspend callback being properly registered. > It should not be possible to suspend if anything is running at DISPATCH because the CPU corralling will be deferred whilst that is the case (since the capture requires a DPC to run) so as long as all the init is being done at DISPATCH there should be no race. Paul From win-pv-devel-bounces@lists.xenproject.org Fri Apr 22 12:21:44 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 22 Apr 2022 12:21:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.310871.527841 (Exim 4.92) (envelope-from ) id 1nhsIA-0002mv-T9; Fri, 22 Apr 2022 12:21:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 310871.527841; Fri, 22 Apr 2022 12:21:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nhsIA-0002mo-QF; Fri, 22 Apr 2022 12:21:42 +0000 Received: by outflank-mailman (input) for mailman id 310871; Fri, 22 Apr 2022 12:21:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nhsI9-0002mS-7S for win-pv-devel@lists.xenproject.org; Fri, 22 Apr 2022 12:21:41 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c19c968b-c236-11ec-8fc2-03012f2f19d4; Fri, 22 Apr 2022 14:21:39 +0200 (CEST) Received: from mail-dm6nam12lp2177.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 22 Apr 2022 08:21:36 -0400 Received: from MW4PR03MB6347.namprd03.prod.outlook.com (2603:10b6:303:11e::22) by CO2PR03MB2165.namprd03.prod.outlook.com (2603:10b6:102:6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Fri, 22 Apr 2022 12:21:34 +0000 Received: from MW4PR03MB6347.namprd03.prod.outlook.com ([fe80::e9f0:3774:1ce9:6059]) by MW4PR03MB6347.namprd03.prod.outlook.com ([fe80::e9f0:3774:1ce9:6059%9]) with mapi id 15.20.5186.015; Fri, 22 Apr 2022 12:21:34 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: c19c968b-c236-11ec-8fc2-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1650630098; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=5vy7+jVBdz7OecmHMucgTG93VvKxR98sP46IVrSqxdk=; b=N+dfjGRxhNS6LaTfct+LPufo8gkvgCD+Rqr9CGiedBDN30IPr6jLmN2d OtZ08uGbsx/E1p2HZJcU0jZOvHcBKMCyReuZc8iqZ0os7DawDOWODfXx4 Zq1YvsEoKxAsrIn177ehOm7v2lMQhWcaSP1juCMYEqS9+SL+pITn4PrFj U=; X-IronPort-RemoteIP: 104.47.59.177 X-IronPort-MID: 70101482 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:9iSXga2W/NoRz8HlevbD5bFwkn2cJEfYwER7XKvMYLTBsI5bpzEFy TMXWG6EPf3ZamrwKYojOYXk/EgAscLSm9NjQVFrpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tIy24Dga++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1jsZHtESEMM5HowqcCdgYISSEgBap/reqvzXiX6aR/zmXgWl61mbBCKR9zOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82SBfyVure03x9p7ixKNfPXf dYYb3xvZQ7ebgxnMVYLEpMu2uyvgxETdhUH8AvN/PZnuQA/yiQg0ITXH53oVuW6QOlumF7Gj 3Di83jQV0Ry2Nu3jGDtHmiXrvfGgCfTSI8UUrqi+ZZCn1yVg3QNTREbS1a/if24kVKlHcJSL VQO/SgjprR081akJuQRRDW9qX+A+xIZBdxZFrRg7BnXk/WLpQGEGmIDUzhNLsQ8s9M7TiAr0 VnPmM71ATtos/ueTnf1GqqokA5e8BM9dQcqDRLohyNcizU/iOnfVi7yc+s= IronPort-HdrOrdr: A9a23:y1edz68L6nrzYm7PDDVuk+Fsdb1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQkdcKO7SdK9qBTnhNRICOgqTPyftWzd1FdAQ7sSibcKrweAJ8S6zJ8l6U 4CSdkyNDSTNykcsS+S2mDRfLgdKZu8gcaVbIzlvhRQpHRRGsRdBnBCe2Sm+yNNJDVuNN4cLt 6x98BHrz2vdTA8dcKgHEQIWODFupniiI/mSQRuPW9p1CC+yReTrJLqGRmR2RkTFxlVx605zG TDmwvloo2+rvCAzAPG3WO71eUZpDKh8KoDOCW/sLlXFtzesHfrWG2nYczGgNkBmpDu1L/tqq iJn/5vBbU115qbRBDOnfKk4Xic7N9p0Q6v9bbQuwqeneXpAD09EMZPnoRfb1/Q7Fchpsh11O ZR03uerIc/N2K3oM3R3am9a/hRrDvCnZPiq59is1VPFY8FLLNBp40W+01YVJ8GASLh8YgiVO 1jFtvV6vpaeU6TKymxhBgm/PW8GnAoWhuWSEkLvcKYlzBQgXBi1kMdgMgShG0J+p4xQ4RNo+ 7ELqNrnrdTSdJ+V9M1OM4RBc+sTmDdSxPFN2yfZVzhCaEcInrI74X65b0kjdvaDaDgDKFC6q gpfGkoy1LaIXiedvFm9Kc7gyzlUSG6QSnnzN1Y6txwpqD8LYCbQhG+dA== X-IronPort-AV: E=Sophos;i="5.90,281,1643691600"; d="scan'208";a="70101482" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rnko5fugpIAjosBZL/bjmPSG2WuZjwrlKvZ8VHA+ZIoDwQzvP4jcZhE4SgzQ1ZDiAMAUf3Kgwfjh/9WXaVUZy5Vm2k8w9naEy2NEUyUjwzmoG10ynB9lYJZgCr14KRJapwmpaDidJCJEeJGwFs1nbZB2GYCyk889498h29mIxEuyGOxUCMmkAvlnAODc6lmOr4qFoE73hv5uDg+9SJzOHD/xulOr9SsLLbTcYPMoc92Kqcex2xU5lWylYU50N1qmvaqKh26Z3R7OtPZSD4klDnsCChF/yBao/8k5MeqJFEhjYFIIpm9zhIsj4BR7GriNrTr+d2tP/QAGuvqA7/psLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5vy7+jVBdz7OecmHMucgTG93VvKxR98sP46IVrSqxdk=; b=UKep2BoWs3NgcFODZUhQQU/B1AxwsfFOxaQf/6de75NUgCHq1QqTbw+l70dbrfU6oSDVTcxh4VMbpnymuoTk7WFk20BHYB27TdHqjZNaLIQpZarbWWOJ15gTdl/QwJOr+v4ThxDBIL0lWy2PLMGfvqifXU4sySQsAxqe7ozJcdRy/xPkNGYD8gRaI6jo7WPHCBa8Rz8yXxErWaTnjxe1hsVZyK1zsRaZX8IlwNaMj0GKGQeZj6F2+MvwdgE5P+fHrOmBmcoPAjcTgu30GnWno9575PxFxxqeLVBhrqpqXiu8rOCe9Tn7awDKrzJ48kpt35oPz5QHRUVNFDePN/BTDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5vy7+jVBdz7OecmHMucgTG93VvKxR98sP46IVrSqxdk=; b=oOUcme2aT6zEzM0wJXoQB6OMAC9EUmsAaLbb8jKsd/nnu8zBOrqCbO8SiHHtX2lW0EWL4INiK5+yujLcA+WNC3ZAXsPhKcPMl3KxzK2jqScy1y3FLsSFx8oS8VUJAOFEwe6HTf7B4w7kIyC2UwKPDpSk4KU1oMSjg8nQOBufHu4= From: Martin Harvey To: "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Subject: RE: XenVif div by zero on Tx path after resume. Thread-Topic: XenVif div by zero on Tx path after resume. Thread-Index: AdhP6kAbDA19BbYtRECv6F4UUU/GxAD72daAAGmnvwAAAFp2cAAAUguAAC/5hJA= Date: Fri, 22 Apr 2022 12:21:33 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ebace079-28a4-4d2c-3180-08da245aa3cd x-ms-traffictypediagnostic: CO2PR03MB2165:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AUG8mle0uL1/OydL4QDXyQK9K4m0hG9W+keetsON9y8+BnetXrq7DGXzqjMqXr5cteB8rc1uZQDdpxTubpftKoASc0yzv3UgYmiC0uIBOBCySbj2GMn+wik/SLQwFeK9bZzKqYQtWrhZ6lfPPAFF3QJd/qfCN7JnoIwZW8lJTsKPYvixH9JEOdDbwzrqUsf6v1Q1ytouWYNqn6dDgS7elO7CseT1vTn39Ve2YgMGYO4N2UhpMZUz7ZEJ25SuOXxi+jlFsmfaiUP3oiJfcU50HrF0gCr4d8gddE73wN7ORdwAl9NUMzQk95N7ognCYdZ8tEsFQLnr8gHjgdY7BBn5vCzNZqB+rqtds4xc8yp1iWSNd++Uf+YbMEPFe2LU4V6LhKN2zKpzQR4RzFRAZEzUmRJV2ep8yDJTrFqk3bB4cqfAr8q4qHHj3b53mYaORj8yXcGObMfwwwZ7WPdkZlkSimwTT+AnqcBmx+8sA9pwLr0L6WC6sKQS33c9vpDYASOXqmHQ/nMoQTqRrOYW8WTyDnaCaM9+sWP60QdlwRAPGfzfmNzNLB93i4e52aa+Xqljb9PoVpvTTf2sw3UQUHOQbF4GcYJoHwi+S5uWaIScqvxAzs6WCvM1Tuj8JrxO+8Z/dZh8yYUiTo5a4JPqZcn1gI8+pjpPnubX2mKZ6f9nkzjfKf71mBxkCW2tBveu2c8YblfshZJ+5BJBpltIwOSqUA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6347.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(8676002)(44832011)(5660300002)(38100700002)(9686003)(316002)(2906002)(122000001)(26005)(82960400001)(66946007)(66446008)(66476007)(76116006)(6506007)(66556008)(64756008)(7696005)(86362001)(71200400001)(508600001)(52536014)(8936002)(55016003)(33656002)(186003)(83380400001)(110136005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TGQzWWZFMXdMSDEyRFI1bFBUbkhUTUtiTkEzTENkay95aEpDdVlPQ295QjNk?= =?utf-8?B?NXFzZTNhTVJ6bEM5b2tPeHFvM0RBVXVwQmpHSDdQMUhUWEtXK1dUdHpHQjEr?= =?utf-8?B?d0ZQTnVtTGoybXdwVmRBRVBKaFRMYWZFbVJ0Z1dFb0VwSGQreUdOMVUwTTlS?= =?utf-8?B?VGxveUs3YXJPU2ZCY2U2c0QyUHlOU3VHQ1RrTTFZa1RuVTMyUGpCSkpCbHhy?= =?utf-8?B?Y2x2T29ZNzE2ODAyVEMyYXp0WkEvbGlDUERVd0RybWdiZ1JMSXBwRDVGRVBv?= =?utf-8?B?MDFHTzNmRkFQSTlXSjRYd0NjV3piQnIyNDh6MG1sT0Q5Vk1uNkVjYUk4MmFX?= =?utf-8?B?eXpkQVRXZ0VVYjl1V0dTcjZJUE9QaXVVeC9sMmg3aXVUNWpNbFVTcktmdElN?= =?utf-8?B?bHRINVNKOFBFVWlUME4vNExpY0MrVDFlUFU0RzcrOUthdEJ5QzlmNFF3ZGhX?= =?utf-8?B?TUhjUVd0TzJDS1N1SHdVRFJ5MlNnUnN5UGthY3RMUnU4Y2pic0xRMjlZZjRh?= =?utf-8?B?QUkvMHRacG16c1ZzWncxZnZvUFRlNW12eEM5WUw2cWx0dXgxMXhmRkxPNlAw?= =?utf-8?B?dld4dWRPTnV2RXNmaVBGNUQyaVBaUE1Kc2N4cnhBVURJdTRVc0RZV3NSNTF0?= =?utf-8?B?blRxYjVrRHBRWjh6VmZ1bnc0dmhxRlJQaHkzcTErbVNRdFJ0clZPdngxUUZG?= =?utf-8?B?K1ozNlZMN1lMalFIS29oSXJPbGlGYVZjVVh3QjZiL2ZOTzU0eDJKUnQ2Nk5G?= =?utf-8?B?aTBXZEVkakREak11YzZrWVNIcU1GRHpZZ244VnFPVTJGa3BkU1pOUVBreSsr?= =?utf-8?B?OGRZYWtkejA4dHhvelpwdGEwc0M3TjcrbGYzTUhKc25RcDRVaXNtMHo1TmFu?= =?utf-8?B?RzNZbkJqVzhhTTlQdGdlN1ZWVUp3MElCU2JwK1VBNzRaZVp2d3hJQ041V1ky?= =?utf-8?B?eEc3VnBENjd3NVRrYkRTV2h1MksrZGQwOFZCRWZReHhTa28wSUZTYk5LZVVL?= =?utf-8?B?UHZHK2t1TWNxZEkvTzlsSVlkUmMxdlU3cXJUUXdTUGF2YTB6NGhydmNCRHEy?= =?utf-8?B?T2tpbitPSnRQZ3IvOGh5Ui9lWUR1NWNHRE1DOVgzS0FDVXFpRnhhUlU0a0hp?= =?utf-8?B?VGVzak93WGRBdDFjS1dtTXJMVUJiSXNFK0pCL1dZczludXpPSkpTUjM2Qm9x?= =?utf-8?B?cTIxNzFuN0Z3MkhTUjR3cVVyTGIwQS9yM3puRFZPeCtDbU42eUdLdWhGb0V3?= =?utf-8?B?REg3Q2lFUFp5cHgyZlEvc3B4dDVCSmZpc01EYzM2VzFXTC9ISE9IOHlpTitL?= =?utf-8?B?aWlxK2plTFo0azRYV3ZXdlpWUVpiaGlGOVJnbXhZOS9tMDE5cDJjbFcwdlVU?= =?utf-8?B?a04xb1JvOXVrY1p1WDZFTE5VbG9nSGFxNk52T0pDNUxrY2Z3VkxxUEk0K0gy?= =?utf-8?B?QVF5c1VxVWRHY25pYXhNOStTL0ZWSnIzZWVJa0Q2S29PRi9FbmdTSGk4TEZI?= =?utf-8?B?MFc1R1VXclFhUHJnMkpZNDEvMy9ZZUpFZEFYcjN1RHRQNDYvZ2tTL29CNVJm?= =?utf-8?B?YzdlcCtpVFhPNUE5RjQ2SEhiS05xS0tPUVJSQ1J1RTh2N3gwb2NYeXJjV1hV?= =?utf-8?B?VnoxRnN5ZDlUc21IeTVybWplcWFvWVMvdFFyQlpDckVGejFaVUpYVjlwdytk?= =?utf-8?B?M3pVbStueHlEcUtqUWxIRXRBd0FSRWtyVVdCeUcyc1ZLaGpQTjdYbE5Na09u?= =?utf-8?B?dlk5WkU2TnpNN3UrSExWSytDS1B5NFExeFpyUDYrM0pTL1A0SWdmbGlUU0JP?= =?utf-8?B?bmIvbUREd04ya1J1QVduM0hHeUlySnBXR2w2Qnc0VXBLbGd6NThjeVlHRkhT?= =?utf-8?B?VWxpSXhPWDVMU2RpaGZSd2N3RkpjdnIxTyttclBiVUlsNEs3ejZYR1FTazNo?= =?utf-8?B?aSs1YXBxOWN2QlExdUNIRCtpdEhxampEcDRYOThib0xiZVZabVFHUUVzUWQ0?= =?utf-8?B?Tzl4Ylh1QVJaMElQNnloL2NIQUtQdURkZmF0T3YxTTk0UFdNZysxUmpicUpB?= =?utf-8?B?VVVPSHJRaG12WjRaYXdoK08zRjQzdkJjSjRUM0VTaURHaFljSUxlclgzbE9R?= =?utf-8?B?T1hLL2VyOURvUmZ4YWZKRHZLV09BdFBOMDNSVisyRkxjRXBrODlqZjh1ZnUx?= =?utf-8?B?UnZEOTg0SFlkclZKQ3A2WUwvSWkxZVIxT2RSaEJGYmh5LzZVdjJaait1WHBt?= =?utf-8?B?Sktya2pvd25vL1QxZUN4L2VNV0lVbEVzQXViNmhJSVJaTHVHYVk5eTdROGpY?= =?utf-8?B?NjhaMExSVWJhSkQydVZ6QWlRc25RL0JJbjdKZGl4RGZPdjZ5bnhCRk1vR1pn?= =?utf-8?Q?wReLkn29Djsx3Y1w=3D?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6347.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ebace079-28a4-4d2c-3180-08da245aa3cd X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2022 12:21:33.9980 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vreHS9h1K+OdUM2KZt2vuaArHF90xRMK5KqTa/Y0vTltRAJAh582wp/SDRpANbHvI5mgICj6HzfR2bQ9IUc1e9K6kg95QtDR+lxeT/F82Q8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR03MB2165 PiBMb29raW5nIGluIHhlbmJ1cydzIHN5bmMuYyBhbmQgc3VzcGVuZC5jLCBJIGNhbid0IHNlZSBh bnkgaXNzdWUuLi4gYnV0IHRoZXJlIGNvdWxkIGJlIHNvbWV0aGluZyBzdWJ0bGUgZ29pbmcgb24g KGxpa2UgV2luZG93cyBkZWNpZGluZyBhbGwgRFBDcyB3aWxsIGJlIHRocmVhZGVkIHVuZGVyIHRo ZSBob29kKS4NCg0KWWVhaCwgT0suIEVpdGhlciB0aGF0LCBvciBzb21lIGNvZGUgbG93ZXJzIHRo ZSBJUlFMIHNvbWV3aGVyZS4gV291bGRuJ3QgYmUgc3VycHJpc2VkIGlmIHNvbWUgY29kZSBoYXMg YmVlbiBhZGRlZCB0byBvbmUgb2YgdGhlIHJlc3VtZSBjYWxsYmFja3Mgd2hpY2ggdHJpZXMgdG8g YmxvY2ssIGxvd2VycyB0aGUgSVJRTCAod2hpY2ggaXMgbm90IGNhdWdodCBiZWNhdXNlIGFubm90 YXRpb25zIC8gc3lzdGVtIGRvZXNuJ3Qga25vdyB3ZSdyZSBhbHdheXMgbWVhbnQgdG8gYmUgYXQg ZGlzcGF0Y2gpLCBhbmQgdGhlbiBpdCBhbGwgZmFsbHMgYXBhcnQuDQoNCkkgZG8gaGF2ZSBhdXRv bWF0ZWQgYnVnY2hlY2sgYW5hbHlzaXMgb24gb3VyIHRlc3QgY29kZSwgc28gaWYgY29kZSBleGFt aW5hdGlvbiBkb2Vzbid0IHdvcmssIEkgY2FuIGNoYW5nZSB0aGUgYXV0b21hdGVkIFdpbkRiZyBj b21tYW5kcyB0byBnaXZlIHVzIHNvbWUgaWRlYSBvZiB3aGF0J3MgZ29pbmcgb24uDQoNCg0KRG8g ZmVlbCBmcmVlIHRvIGhhdmUgYSBidXRjaGVycyBhdCBteSB3b3JraW5nIG5vdGVzIChpbmNsdWRl ZCksIHdoaWNoIGluZGljYXRlIHF1aXRlIGNsZWFybHkgdGhhdCB0aGUgcmVxdWlyZWQgYXRvbWlj aXR5IGlzIG5vdCB0aGVyZToNCg0KLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KDQpQYXVsIHNheXM6DQoNClRoZSB3aG9sZSBzdXNwZW5k L3Jlc3VtZSBjeWNsZSB3aXRoIG9yIHdpdGhvdXQgbWlncmF0ZSBpcyBzdXBwb3NlZCB0byBiZSB0 cmFuc3BhcmVudCB0byB0aGUgcmVzdCBvZiB0aGUgc3lzdGVtOyBpdCdzIG5vdCBhbnkgc29ydCBv ZiBrbm93biBwb3dlciB0cmFuc2l0aW9uLCBpdCdzIHZlcnkgbXVjaCBYZW4tc3BlY2lmaWMgYW5k IHNvIG5lZWRzIHRvIGJlIGhhbmRsZWQgZW50aXJlbHkgd2l0aGluIHRoZSBQViBkcml2ZXJzLg0K DQpFdmVuIHRoZSBsYXRlIHN1c3BlbmQgY2FsbGJhY2sgcnVucyBvbiBhIHNpbmdsZSB2Q1BVIGF0 IERJU1BBVENILCB3aXRoIGFsbCBvdGhlciB2Q1BVcyBzcGlubmluZyBhdCBESVNQQVRDSC4gVGh1 cyB0aGUgb25seSB0aGluZyB0aGF0IHNob3VsZCBiZSBhYmxlIHRvIHByZS1lbXB0IGl0IGlzIGFu IGludGVycnVwdC4gSGVuY2UgdGhlcmUgKnNob3VsZCogYmUgbm8gc2NvcGUgZm9yIHRoZSB0aGUg bmV0d29yayBzdGFjayB0byBzZW5kIGFueSBwYWNrZXRzIHVudGlsIHRoZSBjYWxsYmFjayBoYXMg Y29tcGxldGVkIGl0cyB3b3JrLg0KDQoNCkhvd2V2ZXIsIHdlIG5lZWQgdG8gY2hlY2sgdGhydSBs b2dzLCBiZWNhdXNlIHdoYXQgaXMgaGFwcGVuaW5nIGFwcGVhcnMgdG8gYmUgYXQgc29tZSB2YXJp YW5jZSB3aXRoIHRoaXMuDQoNClN1aXRlIHJ1bnMgMTY3OTEyIC0gMTY3OTE5Lg0KDQoxNjc5MTIs IE5vIGZhaWxzLg0KMTY3OTEzLCBPUy9JbnN0YWxsIGZhaWxlZCAtIHVucmVsYXRlZC4NCjE2Nzkx NCwgTm8gd2luIGZhaWxzLCBzb21lIHNraXBwZWQuDQoxNjc5MTYsIEpvYiAzNDk3MTU2LiBPeERF QUQgaW4gWGVuVmlmLnN5cyAtIGRhZW1vbi5sb2cgdG8gYmUgZG93bmxvYWRlZC4NCjE2NzkxNywg Tm8gZmFpbHMuDQoxNjc5MTgsIEpvYiAzNDk3MTY4LiBPeERFQUQgaW4gWGVuVmlmLnN5cyAtIGRh ZW1vbi5sb2cgdG8gYmUgZG93bmxvYWRlZC4NCjE2NzkxOSwgTm8gZmFpbHMuDQoNCk9LLiAzNDk3 MTU2LiBHb29kIGNhbmRpZGF0ZSBmb3IgdGhlIGJ1Zy4gRmlsdGVyZWQgc3R1ZmYuDQoNClBkb1N1 c3BlbmRDYWxsYmFja0xhdGU6DQoNCnJ1bnMgMTY3OTEyIC0gMTY3OTE5XDE2NzkxNl8zNDk3MTU2 X2RhZW1vbi5sb2c6DQoNCiAgNDUzMzg6IEFwciAyMCAxMzozNDoyNCB4cnRtaWEtMTMtMDYgcWVt dS1kbS00NlsyOTU3NF06IDI5NTc0QDE2NTA0NjE2NjQuNTM5MDM3Onhlbl9wbGF0Zm9ybV9sb2cg eGVuIHBsYXRmb3JtOiB4ZW52aWZ8UGRvU3VzcGVuZENhbGxiYWNrTGF0ZTogKFBkb1N1c3BlbmRD YWxsYmFja0xhdGUpIE1DSFRSQUNFID09PT0+DQogIDQ1MzM5OiBBcHIgMjAgMTM6MzQ6MjQgeHJ0 bWlhLTEzLTA2IHFlbXUtZG0tNDZbMjk1NzRdOiAyOTU3NEAxNjUwNDYxNjY0LjUzOTE0MTp4ZW5f cGxhdGZvcm1fbG9nIHhlbiBwbGF0Zm9ybTogeGVudmlmfF9fUGRvRDBUb0QzOiAoX19QZG9EMFRv RDMpIE1DSFRSQUNFID09PT0+DQogIDQ1MzQwOiBBcHIgMjAgMTM6MzQ6MjQgeHJ0bWlhLTEzLTA2 IHFlbXUtZG0tNDZbMjk1NzRdOiAyOTU3NEAxNjUwNDYxNjY0LjUzOTI2Nzp4ZW5fcGxhdGZvcm1f bG9nIHhlbiBwbGF0Zm9ybTogeGVudmlmfEZyb250ZW5kU2V0U3RhdGU6IEZyb250ZW5kU2V0U3Rh dGU6ZGV2aWNlL3ZpZi8wOiBNQ0hUUkFDRSA9PT09PiAnQ0xPU0VEJyAtPiAnQ0xPU0VEJw0KICA0 NTM0MTogQXByIDIwIDEzOjM0OjI0IHhydG1pYS0xMy0wNiBxZW11LWRtLTQ2WzI5NTc0XTogMjk1 NzRAMTY1MDQ2MTY2NC41MzkzODM6eGVuX3BsYXRmb3JtX2xvZyB4ZW4gcGxhdGZvcm06IHhlbnZp ZnxGcm9udGVuZFNldFN0YXRlOiBGcm9udGVuZFNldFN0YXRlOmRldmljZS92aWYvMDogTUNIVFJB Q0UgPD09PT09DQogIDQ1MzQyOiBBcHIgMjAgMTM6MzQ6MjQgeHJ0bWlhLTEzLTA2IHFlbXUtZG0t NDZbMjk1NzRdOiAyOTU3NEAxNjUwNDYxNjY0LjUzOTQ4Njp4ZW5fcGxhdGZvcm1fbG9nIHhlbiBw bGF0Zm9ybTogeGVudmlmfF9fUGRvRDBUb0QzOiAoX19QZG9EMFRvRDMpIE1DSFRSQUNFIDw9PT09 DQogIDQ1MzQzOiBBcHIgMjAgMTM6MzQ6MjQgeHJ0bWlhLTEzLTA2IHFlbXUtZG0tNDZbMjk1NzRd OiAyOTU3NEAxNjUwNDYxNjY0LjUzOTU5MTp4ZW5fcGxhdGZvcm1fbG9nIHhlbiBwbGF0Zm9ybTog eGVudmlmfF9fUGRvRDNUb0QwOiAoX19QZG9EM1RvRDApIE1DSFRSQUNFID09PT0+DQogIDQ1MzQ0 OiBBcHIgMjAgMTM6MzQ6MjQgeHJ0bWlhLTEzLTA2IHFlbXUtZG0tNDZbMjk1NzRdOiAyOTU3NEAx NjUwNDYxNjY0LjUzOTcxNzp4ZW5fcGxhdGZvcm1fbG9nIHhlbiBwbGF0Zm9ybTogeGVudmlmfEZy b250ZW5kU2V0U3RhdGU6IEZyb250ZW5kU2V0U3RhdGU6ZGV2aWNlL3ZpZi8wOiBNQ0hUUkFDRSA9 PT09PiAnQ0xPU0VEJyAtPiAnQ09OTkVDVEVEJw0KICA0NTgyMDogQXByIDIwIDEzOjM0OjI0IHhy dG1pYS0xMy0wNiBxZW11LWRtLTQ2WzI5NTc0XTogMjk1NzRAMTY1MDQ2MTY2NC42MTA0NjI6eGVu X3BsYXRmb3JtX2xvZyB4ZW4gcGxhdGZvcm06IHhlbnxCVUdDSEVDSzogPT09PT4NCiAgNDU4MjE6 IEFwciAyMCAxMzozNDoyNCB4cnRtaWEtMTMtMDYgcWVtdS1kbS00NlsyOTU3NF06IDI5NTc0QDE2 NTA0NjE2NjQuNjEwNjYyOnhlbl9wbGF0Zm9ybV9sb2cgeGVuIHBsYXRmb3JtOiB4ZW58QlVHQ0hF Q0s6IEFTU0VSVElPTl9GQUlMVVJFOiBGRkZGRjgwNjE5RkE3QzUwIEZGRkZGODA2MTlGQTdDNzAg MDAwMDAwMDAwMDAwMTQ0RSAwMDAwMDAwMDAwMDAwMDAwDQogIDQ1ODIyOiBBcHIgMjAgMTM6MzQ6 MjQgeHJ0bWlhLTEzLTA2IHFlbXUtZG0tNDZbMjk1NzRdOiAyOTU3NEAxNjUwNDYxNjY0LjYxMDg2 ODp4ZW5fcGxhdGZvcm1fbG9nIHhlbiBwbGF0Zm9ybTogeGVufEJVR0NIRUNLOiBGSUxFOiBFOlxq ZW5raW5zXHdvcmtzcGFjZVxudmlmX3ByaXZhdGVfbWFydGluaGFyX0NBLTM1NTY3MFxsb2NhbFxz cmNceGVudmlmXHRyYW5zbWl0dGVyLmMgTElORTogNTE5OA0KICA0NTgyMzogQXByIDIwIDEzOjM0 OjI0IHhydG1pYS0xMy0wNiBxZW11LWRtLTQ2WzI5NTc0XTogMjk1NzRAMTY1MDQ2MTY2NC42MTA5 ODg6eGVuX3BsYXRmb3JtX2xvZyB4ZW4gcGxhdGZvcm06IHhlbnxCVUdDSEVDSzogVEVYVDogIU5U X1NVQ0NFU1Moc3RhdHVzKQ0KICA0NTgyNDogQXByIDIwIDEzOjM0OjI0IHhydG1pYS0xMy0wNiBx ZW11LWRtLTQ2WzI5NTc0XTogMjk1NzRAMTY1MDQ2MTY2NC42MTEwOTQ6eGVuX3BsYXRmb3JtX2xv ZyB4ZW4gcGxhdGZvcm06IHhlbnxCVUdDSEVDSzogQ09OVEVYVCAoRkZGRjk1ODgxN0NBMEEzMCk6 DQogIDQ1ODI1OiBBcHIgMjAgMTM6MzQ6MjQgeHJ0bWlhLTEzLTA2IHFlbXUtZG0tNDZbMjk1NzRd OiAyOTU3NEAxNjUwNDYxNjY0LjYxMTE4NTp4ZW5fcGxhdGZvcm1fbG9nIHhlbiBwbGF0Zm9ybTog eGVufEJVR0NIRUNLOiAtIEdTID0gMDAyQg0KICA0NTgyNjogQXByIDIwIDEzOjM0OjI0IHhydG1p YS0xMy0wNiBxZW11LWRtLTQ2WzI5NTc0XTogMjk1NzRAMTY1MDQ2MTY2NC42MTEyODc6eGVuX3Bs YXRmb3JtX2xvZyB4ZW4gcGxhdGZvcm06IHhlbnxCVUdDSEVDSzogLSBGUyA9IDAwNTMNCg0KU28g d2UgYXJlIGRlZmluaXRlbHkgaW4gUGRvU3VzcGVuZENhbGxiYWNrTGF0ZSwgYW5kIHdlIGRvbid0 IGV4aXQgaXQsIGFuZCB3ZSBkb24ndCBnZXQgcm91bmQgdG8gdGhlIFZpZkNhbGxiYWNrTGF0ZS4N Cg0KRXZlbiBhIGN1cnNvcnkgZXhhbWluYXRpb24gb2YgdGhlIGxvZ3Mgc2hvd3MgdGhhdCB4ZW5p ZmFjZSBpcyBleGVjdXRpbmcgYXQgYSBsb3dlciBJcnFsLCBhbW9uZ3N0IG90aGVyIHRoaW5ncy4N Cg0KQXByIDIwIDEzOjM0OjI0IHhydG1pYS0xMy0wNiBxZW11LWRtLTQ2WzI5NTc0XTogMjk1NzRA MTY1MDQ2MTY2NC41MzkwMzc6eGVuX3BsYXRmb3JtX2xvZyB4ZW4gcGxhdGZvcm06IHhlbnZpZnxQ ZG9TdXNwZW5kQ2FsbGJhY2tMYXRlOiAoUGRvU3VzcGVuZENhbGxiYWNrTGF0ZSkgTUNIVFJBQ0Ug PT09PT4NCkFwciAyMCAxMzozNDoyNCB4cnRtaWEtMTMtMDYgcWVtdS1kbS00NlsyOTU3NF06IDI5 NTc0QDE2NTA0NjE2NjQuNTM5MTQxOnhlbl9wbGF0Zm9ybV9sb2cgeGVuIHBsYXRmb3JtOiB4ZW52 aWZ8X19QZG9EMFRvRDM6IChfX1Bkb0QwVG9EMykgTUNIVFJBQ0UgPT09PT4NCkFwciAyMCAxMzoz NDoyNCB4cnRtaWEtMTMtMDYgcWVtdS1kbS00NlsyOTU3NF06IDI5NTc0QDE2NTA0NjE2NjQuNTM5 MjY3Onhlbl9wbGF0Zm9ybV9sb2cgeGVuIHBsYXRmb3JtOiB4ZW52aWZ8RnJvbnRlbmRTZXRTdGF0 ZTogRnJvbnRlbmRTZXRTdGF0ZTpkZXZpY2UvdmlmLzA6IE1DSFRSQUNFID09PT0+ICdDTE9TRUQn IC0+ICdDTE9TRUQnDQpBcHIgMjAgMTM6MzQ6MjQgeHJ0bWlhLTEzLTA2IHFlbXUtZG0tNDZbMjk1 NzRdOiAyOTU3NEAxNjUwNDYxNjY0LjUzOTM4Mzp4ZW5fcGxhdGZvcm1fbG9nIHhlbiBwbGF0Zm9y bTogeGVudmlmfEZyb250ZW5kU2V0U3RhdGU6IEZyb250ZW5kU2V0U3RhdGU6ZGV2aWNlL3ZpZi8w OiBNQ0hUUkFDRSA8PT09PT0NCkFwciAyMCAxMzozNDoyNCB4cnRtaWEtMTMtMDYgcWVtdS1kbS00 NlsyOTU3NF06IDI5NTc0QDE2NTA0NjE2NjQuNTM5NDg2Onhlbl9wbGF0Zm9ybV9sb2cgeGVuIHBs YXRmb3JtOiB4ZW52aWZ8X19QZG9EMFRvRDM6IChfX1Bkb0QwVG9EMykgTUNIVFJBQ0UgPD09PT0N CkFwciAyMCAxMzozNDoyNCB4cnRtaWEtMTMtMDYgcWVtdS1kbS00NlsyOTU3NF06IDI5NTc0QDE2 NTA0NjE2NjQuNTM5NTkxOnhlbl9wbGF0Zm9ybV9sb2cgeGVuIHBsYXRmb3JtOiB4ZW52aWZ8X19Q ZG9EM1RvRDA6IChfX1Bkb0QzVG9EMCkgTUNIVFJBQ0UgPT09PT4NCkFwciAyMCAxMzozNDoyNCB4 cnRtaWEtMTMtMDYgcWVtdS1kbS00NlsyOTU3NF06IDI5NTc0QDE2NTA0NjE2NjQuNTM5NzE3Onhl bl9wbGF0Zm9ybV9sb2cgeGVuIHBsYXRmb3JtOiB4ZW52aWZ8RnJvbnRlbmRTZXRTdGF0ZTogRnJv bnRlbmRTZXRTdGF0ZTpkZXZpY2UvdmlmLzA6IE1DSFRSQUNFID09PT0+ICdDTE9TRUQnIC0+ICdD T05ORUNURUQnDQpBcHIgMjAgMTM6MzQ6MjQgeHJ0bWlhLTEzLTA2IHFlbXUtZG0tNDZbMjk1NzRd OiAyOTU3NEAxNjUwNDYxNjY0LjUzOTgxNzp4ZW5fcGxhdGZvcm1fbG9nIHhlbiBwbGF0Zm9ybTog eGVuaWZhY2V8SW9jdGxMb2c6IFVTRVI6IFJUQyBpcyBpbiBsb2NhbCB0aW1lDQpBcHIgMjAgMTM6 MzQ6MjQgeHJ0bWlhLTEzLTA2IHFlbXUtZG0tNDZbMjk1NzRdOiAyOTU3NEAxNjUwNDYxNjY0LjUz OTkzMzp4ZW5fcGxhdGZvcm1fbG9nIHhlbiBwbGF0Zm9ybTogeGVuaWZhY2V8RmRvSW5pdGlhbGlz ZVhTUmVnaXN0cnlFbnRyaWVzOiBBYm91dCB0byBjb252ZXJ0IHVuaWNvZGUgc3RyaW5nDQpBcHIg MjAgMTM6MzQ6MjQgeHJ0bWlhLTEzLTA2IHFlbXUtZG0tNDZbMjk1NzRdOiAyOTU3NEAxNjUwNDYx NjY0LjU0MDEyNTp4ZW5fcGxhdGZvcm1fbG9nIHhlbiBwbGF0Zm9ybTogeGVuaWZhY2V8RmRvSW5p dGlhbGlzZVhTUmVnaXN0cnlFbnRyaWVzOiBBYm91dCB0byB3cml0ZSB1bmljb2RlIHN0cmluZw0K QXByIDIwIDEzOjM0OjI0IHhydG1pYS0xMy0wNiBxZW11LWRtLTQ2WzI5NTc0XTogMjk1NzRAMTY1 MDQ2MTY2NC41NDAyNDE6eGVuX3BsYXRmb3JtX2xvZyB4ZW4gcGxhdGZvcm06IHhlbmlmYWNlfElv Y3RsTG9nOiBVU0VSOiBUaW1lIE5vdyA9IDIwMjIvNC8yMCAxMzoyNjowNy40ODMNCkFwciAyMCAx MzozNDoyNCB4cnRtaWEtMTMtMDYgcWVtdS1kbS00NlsyOTU3NF06IDI5NTc0QDE2NTA0NjE2NjQu NTQwMzQ1Onhlbl9wbGF0Zm9ybV9sb2cgeGVuIHBsYXRmb3JtOiB4ZW5pZmFjZXxJb2N0bExvZzog VVNFUjogTmV3IFRpbWUgPSAyMDIyLzQvMjAgMTM6MzE6MzkuMTQNCkFwciAyMCAxMzozNDoyNCB4 cnRtaWEtMTMtMDYgcWVtdS1kbS00NlsyOTU3NF06IDI5NTc0QDE2NTA0NjE2NjQuNTQwNDQ5Onhl bl9wbGF0Zm9ybV9sb2cgeGVuIHBsYXRmb3JtOiB4ZW52aWZ8VHJhbnNtaXR0ZXJRdWV1ZVBhY2tl dDogQlVHOiAhTlRfU1VDQ0VTUyhzdGF0dXMpDQoNCkknbGwgc3RhcnQgbG9va2luZyBhdCBJUlFM IHZpb2xhdGlvbnMgKGJsb2NraW5nIGZyb20gRElTUEFUQ0gpLCBhcyB3ZWxsIGFzIGhvdyBvbiBl YXJ0aCB0aGUgY29ycmFsIGlzIHN1cHBvc2VkIHRvIHdvcmsuDQo= From win-pv-devel-bounces@lists.xenproject.org Fri Apr 22 12:26:46 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 22 Apr 2022 12:26:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.310879.527845 (Exim 4.92) (envelope-from ) id 1nhsN3-0003Br-AU; Fri, 22 Apr 2022 12:26:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 310879.527845; Fri, 22 Apr 2022 12:26:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nhsN3-0003Bh-7E; Fri, 22 Apr 2022 12:26:45 +0000 Received: by outflank-mailman (input) for mailman id 310879; Fri, 22 Apr 2022 12:26:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nhsN1-0003BZ-8b for win-pv-devel@lists.xenproject.org; Fri, 22 Apr 2022 12:26:43 +0000 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [2a00:1450:4864:20::42f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7722052a-c237-11ec-a405-831a346695d4; Fri, 22 Apr 2022 14:26:42 +0200 (CEST) Received: by mail-wr1-x42f.google.com with SMTP id c10so10853931wrb.1 for ; Fri, 22 Apr 2022 05:26:42 -0700 (PDT) Received: from [10.7.237.9] (54-240-197-225.amazon.com. [54.240.197.225]) by smtp.gmail.com with ESMTPSA id r184-20020a1c2bc1000000b00392af6f0ab0sm1605471wmr.18.2022.04.22.05.26.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Apr 2022 05:26:41 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 7722052a-c237-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=aGA3pkixzMTHgnm1+Z3F2Rx9rGN7wdUuztFzRLeEyqY=; b=GUWb0rQ6ZE6cHrDQB8Q4wAhNmqDvPlXFd1i6vpT0XBwfJ4BVAY2jNcBQskhv2C7tMT 0WJ/3frbl8MEeIJtyEfAVPV5v8eo5hTTNMrzb5frVCBkffDW1/lWSedbaQcFcjoC4n+T +9Qm4jvOCzTineAkAjtb89GZkyeV9AD1UcoAgzQvLHpQdiebDcTLAf+eD6SHaXL09BL0 q+fhEdAfqiC+ARNIV/WYuzIpvVLCaEKJkzvpAB//5awhElzX8FGBVNaHyzYws/HRZ6Sq OhtQ9tStcvfJ3t+341rcq+q9MnXO25r5c+EArI3y6tmoqBT4n+nJH4sTBaPpqAOGURhK t/kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=aGA3pkixzMTHgnm1+Z3F2Rx9rGN7wdUuztFzRLeEyqY=; b=OaD5jQbS89n91lQ2FKs5/RRWMfAPybDcwQCbgFIel9OkF5+wMrceya/dJl0Ig1ILqd HbX1kZc+kE2aA3Rg7vp7W/TjADQzzAg/otJDYlcXAClEaHJj5Jx/1lnDLhjwsOTioRko zbsV3HERr8pXg3OKnhZxVcJdpQpC8rZ0TD8/+MrJayjxcuR/sCMQYfTz3FbOBMNt5YI6 ujxtRk8fjwohytx5brSfXexFMZhxlSTf3R6VOIrWXIDlgGtV7oBmr95JQQkBID1xR2rB 3/nwA1jtpxTb5GNngMf5feKCP/EOjJjf3u17fPs/TckMimX2Pr73OpCmkuy1NfgEzL7q FImg== X-Gm-Message-State: AOAM533CLfW3lZgde+KK+KVGRVm2/kt7XOmEodBfVOufkwEngjlPrg00 NUPJY0sE/E3GtdIcitKoENg= X-Google-Smtp-Source: ABdhPJwFGEQPLrAxuR4tVO0Mef0C7HuDi2RMW5FL7MmDCHLf81edRC72ytENT129ACvMLzGKV/5XpQ== X-Received: by 2002:adf:fa86:0:b0:207:aadd:bff5 with SMTP id h6-20020adffa86000000b00207aaddbff5mr3487582wrr.469.1650630401697; Fri, 22 Apr 2022 05:26:41 -0700 (PDT) Message-ID: Date: Fri, 22 Apr 2022 13:26:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Reply-To: paul@xen.org Subject: Re: XenVif div by zero on Tx path after resume. Content-Language: en-US To: Martin Harvey , "paul@xen.org" , "win-pv-devel@lists.xenproject.org" References: From: "Durrant, Paul" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 22/04/2022 13:21, Martin Harvey wrote: [snip] > > So we are definitely in PdoSuspendCallbackLate, and we don't exit it, and we don't get round to the VifCallbackLate. > > Even a cursory examination of the logs shows that xeniface is executing at a lower Irql, amongst other things. > > Apr 20 13:34:24 xrtmia-13-06 qemu-dm-46[29574]: 29574@1650461664.539037:xen_platform_log xen platform: xenvif|PdoSuspendCallbackLate: (PdoSuspendCallbackLate) MCHTRACE ====> > Apr 20 13:34:24 xrtmia-13-06 qemu-dm-46[29574]: 29574@1650461664.539141:xen_platform_log xen platform: xenvif|__PdoD0ToD3: (__PdoD0ToD3) MCHTRACE ====> > Apr 20 13:34:24 xrtmia-13-06 qemu-dm-46[29574]: 29574@1650461664.539267:xen_platform_log xen platform: xenvif|FrontendSetState: FrontendSetState:device/vif/0: MCHTRACE ====> 'CLOSED' -> 'CLOSED' > Apr 20 13:34:24 xrtmia-13-06 qemu-dm-46[29574]: 29574@1650461664.539383:xen_platform_log xen platform: xenvif|FrontendSetState: FrontendSetState:device/vif/0: MCHTRACE <===== > Apr 20 13:34:24 xrtmia-13-06 qemu-dm-46[29574]: 29574@1650461664.539486:xen_platform_log xen platform: xenvif|__PdoD0ToD3: (__PdoD0ToD3) MCHTRACE <==== > Apr 20 13:34:24 xrtmia-13-06 qemu-dm-46[29574]: 29574@1650461664.539591:xen_platform_log xen platform: xenvif|__PdoD3ToD0: (__PdoD3ToD0) MCHTRACE ====> > Apr 20 13:34:24 xrtmia-13-06 qemu-dm-46[29574]: 29574@1650461664.539717:xen_platform_log xen platform: xenvif|FrontendSetState: FrontendSetState:device/vif/0: MCHTRACE ====> 'CLOSED' -> 'CONNECTED' > Apr 20 13:34:24 xrtmia-13-06 qemu-dm-46[29574]: 29574@1650461664.539817:xen_platform_log xen platform: xeniface|IoctlLog: USER: RTC is in local time > Apr 20 13:34:24 xrtmia-13-06 qemu-dm-46[29574]: 29574@1650461664.539933:xen_platform_log xen platform: xeniface|FdoInitialiseXSRegistryEntries: About to convert unicode string > Apr 20 13:34:24 xrtmia-13-06 qemu-dm-46[29574]: 29574@1650461664.540125:xen_platform_log xen platform: xeniface|FdoInitialiseXSRegistryEntries: About to write unicode string > Apr 20 13:34:24 xrtmia-13-06 qemu-dm-46[29574]: 29574@1650461664.540241:xen_platform_log xen platform: xeniface|IoctlLog: USER: Time Now = 2022/4/20 13:26:07.483 > Apr 20 13:34:24 xrtmia-13-06 qemu-dm-46[29574]: 29574@1650461664.540345:xen_platform_log xen platform: xeniface|IoctlLog: USER: New Time = 2022/4/20 13:31:39.14 > Apr 20 13:34:24 xrtmia-13-06 qemu-dm-46[29574]: 29574@1650461664.540449:xen_platform_log xen platform: xenvif|TransmitterQueuePacket: BUG: !NT_SUCCESS(status) > > I'll start looking at IRQL violations (blocking from DISPATCH), as well as how on earth the corral is supposed to work. Yeah, something is screwed up there. It would be useful to annotate the log lines with which CPU they happen on. There's no way user-space should be running before all the suspend callbacks have completed. Paul From win-pv-devel-bounces@lists.xenproject.org Fri Apr 22 12:32:24 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 22 Apr 2022 12:32:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.310895.527848 (Exim 4.92) (envelope-from ) id 1nhsSV-0004Mf-Kf; Fri, 22 Apr 2022 12:32:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 310895.527848; Fri, 22 Apr 2022 12:32:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nhsSV-0004MY-Hr; Fri, 22 Apr 2022 12:32:23 +0000 Received: by outflank-mailman (input) for mailman id 310895; Fri, 22 Apr 2022 12:32:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nhsST-0004MS-LP for win-pv-devel@lists.xenproject.org; Fri, 22 Apr 2022 12:32:21 +0000 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [2a00:1450:4864:20::333]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 40cc654a-c238-11ec-8fc2-03012f2f19d4; Fri, 22 Apr 2022 14:32:20 +0200 (CEST) Received: by mail-wm1-x333.google.com with SMTP id n126-20020a1c2784000000b0038e8af3e788so5294119wmn.1 for ; Fri, 22 Apr 2022 05:32:20 -0700 (PDT) Received: from [10.7.237.9] (54-240-197-225.amazon.com. [54.240.197.225]) by smtp.gmail.com with ESMTPSA id r14-20020a5d6c6e000000b0020a9f757708sm1993593wrz.33.2022.04.22.05.32.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Apr 2022 05:32:18 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 40cc654a-c238-11ec-8fc2-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:from:to:references:in-reply-to :content-transfer-encoding; bh=W2hxPzVoFEB/1MjQovOz2sIJfPIfEejVe3iVkjFTdLY=; b=grBDKVA+2e6MJFCGqj3UkFzwQvZO3cmEgLbGTnDjbk3UhGbOMSu4c5fINfjwzlj3pV uGZvO2PvPleSzcs7U7F/L6PQBoBxa01OIg9v8NQWUntozm2r3pqbqiT+xDZCOBFPHY0c vlXWNyoYYVvZe4pnerjRO139KCkTStQPTyjGYlbAX57ynUoYdlNjJXVgOBtGUiH4oXYq q/RifkY9IIs8pnBYq9D9YSDZYgZOOd63s2II5yjniLoJEN4zV0VWH1gh1SwxrhHHHw21 26T94LDtRIrkstjCxyRG404Qx7pR92g35OiS704ax6pahiMyMRWXvGT4b78b6Dh7uHMy 052A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:from:to:references:in-reply-to :content-transfer-encoding; bh=W2hxPzVoFEB/1MjQovOz2sIJfPIfEejVe3iVkjFTdLY=; b=YJfLbFnFoCouq5k//xU9td40wTZ1W4VHKhQL5unjHKGQucWHJtZFBIw+1LQw7pgIbs elyPFSFG/j71eIrgXYPRbJn4Y+jYBG9vij3nygI402l9l7vPDCDW5qqQkTMuO3jCFdNY ps8+1tjBDmBZAgE6+ULdB9CIYKHxQY88qcVuYK37raFrV7NsbXYElwXjTqmwuYq7UUqw nZtmIRIeHBDIuvRELx6EqDtY6ik7XytUdifJgqGSlV2XQtX9csMtaPQQy3NGuu5NNURR fNUGL4u6uLF+g9KA3pANfM07zolpN0ya8zmeQ9x3+WGZ2Cr7soeWaK1HdBbtJS5GYLIC aacw== X-Gm-Message-State: AOAM530iHfhg/MU9n8nWexh/7XcEF8MA9mGY4mhbSLqrbFfNWLgK/WcD B2kw/gvTQQAtQ4HxDW3sZas= X-Google-Smtp-Source: ABdhPJywKQYOl97BZY9aJ3KjoZsFfVoVm/txAP6bGtSuRRWnyVaY3no7s86kBoSsII2W/qH5UknZUg== X-Received: by 2002:a7b:ce8d:0:b0:392:ad99:edbd with SMTP id q13-20020a7bce8d000000b00392ad99edbdmr11271546wmj.167.1650630739886; Fri, 22 Apr 2022 05:32:19 -0700 (PDT) Message-ID: <55d61956-1a0c-c4e9-cb79-ff24c3433ad1@gmail.com> Date: Fri, 22 Apr 2022 13:32:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Reply-To: Martin Harvey Subject: Re: XenVif div by zero on Tx path after resume. Content-Language: en-US From: "Durrant, Paul" To: "paul@xen.org" , "win-pv-devel@lists.xenproject.org" References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 22/04/2022 13:26, Durrant, Paul wrote: > On 22/04/2022 13:21, Martin Harvey wrote: > [snip] >> >> So we are definitely in PdoSuspendCallbackLate, and we don't exit it, >> and we don't get round to the VifCallbackLate. >> >> Even a cursory examination of the logs shows that xeniface is >> executing at a lower Irql, amongst other things. >> >> Apr 20 13:34:24 xrtmia-13-06 qemu-dm-46[29574]: >> 29574@1650461664.539037:xen_platform_log xen platform: >> xenvif|PdoSuspendCallbackLate: (PdoSuspendCallbackLate) MCHTRACE ====> >> Apr 20 13:34:24 xrtmia-13-06 qemu-dm-46[29574]: >> 29574@1650461664.539141:xen_platform_log xen platform: >> xenvif|__PdoD0ToD3: (__PdoD0ToD3) MCHTRACE ====> >> Apr 20 13:34:24 xrtmia-13-06 qemu-dm-46[29574]: >> 29574@1650461664.539267:xen_platform_log xen platform: >> xenvif|FrontendSetState: FrontendSetState:device/vif/0: MCHTRACE ====> >> 'CLOSED' -> 'CLOSED' >> Apr 20 13:34:24 xrtmia-13-06 qemu-dm-46[29574]: >> 29574@1650461664.539383:xen_platform_log xen platform: >> xenvif|FrontendSetState: FrontendSetState:device/vif/0: MCHTRACE <===== >> Apr 20 13:34:24 xrtmia-13-06 qemu-dm-46[29574]: >> 29574@1650461664.539486:xen_platform_log xen platform: >> xenvif|__PdoD0ToD3: (__PdoD0ToD3) MCHTRACE <==== >> Apr 20 13:34:24 xrtmia-13-06 qemu-dm-46[29574]: >> 29574@1650461664.539591:xen_platform_log xen platform: >> xenvif|__PdoD3ToD0: (__PdoD3ToD0) MCHTRACE ====> >> Apr 20 13:34:24 xrtmia-13-06 qemu-dm-46[29574]: >> 29574@1650461664.539717:xen_platform_log xen platform: >> xenvif|FrontendSetState: FrontendSetState:device/vif/0: MCHTRACE ====> >> 'CLOSED' -> 'CONNECTED' >> Apr 20 13:34:24 xrtmia-13-06 qemu-dm-46[29574]: >> 29574@1650461664.539817:xen_platform_log xen platform: >> xeniface|IoctlLog: USER: RTC is in local time >> Apr 20 13:34:24 xrtmia-13-06 qemu-dm-46[29574]: >> 29574@1650461664.539933:xen_platform_log xen platform: >> xeniface|FdoInitialiseXSRegistryEntries: About to convert unicode string >> Apr 20 13:34:24 xrtmia-13-06 qemu-dm-46[29574]: >> 29574@1650461664.540125:xen_platform_log xen platform: >> xeniface|FdoInitialiseXSRegistryEntries: About to write unicode string >> Apr 20 13:34:24 xrtmia-13-06 qemu-dm-46[29574]: >> 29574@1650461664.540241:xen_platform_log xen platform: >> xeniface|IoctlLog: USER: Time Now = 2022/4/20 13:26:07.483 >> Apr 20 13:34:24 xrtmia-13-06 qemu-dm-46[29574]: >> 29574@1650461664.540345:xen_platform_log xen platform: >> xeniface|IoctlLog: USER: New Time = 2022/4/20 13:31:39.14 >> Apr 20 13:34:24 xrtmia-13-06 qemu-dm-46[29574]: >> 29574@1650461664.540449:xen_platform_log xen platform: >> xenvif|TransmitterQueuePacket: BUG: !NT_SUCCESS(status) >> >> I'll start looking at IRQL violations (blocking from DISPATCH), as >> well as how on earth the corral is supposed to work. > > Yeah, something is screwed up there. It would be useful to annotate the > log lines with which CPU they happen on. There's no way user-space > should be running before all the suspend callbacks have completed. > Oh ffs... the call to KeLowerIrql(DISPATCH_LEVEL) is being done at the end of SyncEnableInterrupts() rather than after the late callbacks at the beginning of SyncRelease(). That will be the problem... and now I need to dig for why it is like that. Paul >   Paul > From win-pv-devel-bounces@lists.xenproject.org Fri Apr 22 14:10:02 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 22 Apr 2022 14:10:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.310968.527959 (Exim 4.92) (envelope-from ) id 1nhtyy-0002XP-VJ; Fri, 22 Apr 2022 14:10:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 310968.527959; Fri, 22 Apr 2022 14:10:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nhtyy-0002XI-Rw; Fri, 22 Apr 2022 14:10:00 +0000 Received: by outflank-mailman (input) for mailman id 310968; Fri, 22 Apr 2022 14:09:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nhtyw-0001y5-Hc for win-pv-devel@lists.xenproject.org; Fri, 22 Apr 2022 14:09:59 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e1f4a850-c245-11ec-8fc2-03012f2f19d4; Fri, 22 Apr 2022 16:09:56 +0200 (CEST) Received: from mail-mw2nam10lp2106.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.106]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 22 Apr 2022 10:09:53 -0400 Received: from MW4PR03MB6347.namprd03.prod.outlook.com (2603:10b6:303:11e::22) by DM5PR03MB3161.namprd03.prod.outlook.com (2603:10b6:4:3d::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Fri, 22 Apr 2022 14:09:51 +0000 Received: from MW4PR03MB6347.namprd03.prod.outlook.com ([fe80::e9f0:3774:1ce9:6059]) by MW4PR03MB6347.namprd03.prod.outlook.com ([fe80::e9f0:3774:1ce9:6059%9]) with mapi id 15.20.5186.015; Fri, 22 Apr 2022 14:09:51 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: e1f4a850-c245-11ec-8fc2-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1650636596; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=bM3CyK4VaAA0IgvwsaZcFswjVL7XDE5uP7TLiMHcKM0=; b=JKKw7aq7h1PWoQsk8YggWsCFq+whfVgENX2oAzBuT+3FdJ5GZ5qzu7HD NciewlulV9rqTfgkhxbnLXBWuzNxBvhXOEBqr8w7wVrjq7J5NN7IP6Bhx +UT8lG6PSDH3XeLW3NDPWPatDwW9BaZykuy5oWw2NTOdwAi1lDCEWZzG5 8=; X-IronPort-RemoteIP: 104.47.55.106 X-IronPort-MID: 69106718 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:l9N4UqyIDBhYDl8Lp1Z6t+dVxyrEfRIJ4+MujC+fZmUNrF6WrkUPy GMfUDuPa/2LNmr8eNwkO4zgp0sAupGAyYI1GwZrpSAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NY024LhWmthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ NplloOpCgcOfa31xPVCQQAIPBpvZ7VP0eqSSZS/mZT7I0zuVVLJmq0rKX5seIoS96BwHH1E8 uEeJHYVdBefiumqwbW9DO5xmsAkK8qtN4Qa0p1i5WiBUbB6HtaeHuOTvYEwMDQY36iiGd7bb tAFaDwpbB3afRBeElwWFIg/jKGjgXyXnzhw9gPM/fRouji7IApZgLjWaeTLeNazTJtwjlSVi X30007TO0RPXDCY4X/fmp62vcfXlD7/cJIfEvu/7PECqEKSwCkLFlgaWEW2pdG9i1WiQJRPJ koM4C0soKMuskuxQbHAswaQpXeFulsZRIBWGuhjsAWVkPOMvUCeG3QOSSNHZJo+rsgqSDc21 1iP2dT0GThot77TQnWYnluJkQ6P1eEuBTdqTUc5ocEturEPfKlbYsrzc+te IronPort-HdrOrdr: A9a23:oeFcXq1USVtRHv/WCSdahwqjBQZyeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5AEtQ4exoS5PwOk80kqQFq7X5XI3SFzUO3VHFEGgM1/qH/9SNIUzDH6tmpN 5dmstFeZDN5DpB/KHHCWCDer5OruVvsprY49s2pE0dLj2CHpsQijuRfTzrcHGeKjMnObMJUL 6nouZXrTupfnoaKu6hAGMeYuTFr9rX0Lr7fB8vHXccmUazpALtzIS/PwmT3x8YXT8K66wl63 L5nwvw4bjmm+2nyyXby3TY4/1t6ZXcI5p4dY2xY/ouW3bRYzWTFcZcsnq5zXUISdSUmRYXeR /30lMd1opImjTslyqO0GHQMkHboUsTAjnZuBOlaDLY0LDEbSN/BMxbiY1DdBzFr0ImodFnya pOm3mUrpxNEHr77VLADvXzJmVXf3CP0A0feC8o/gxieJpbbKUUoZ0U/UtTHptFFCXm6Jo/GO 0rCM3H/v5ZfV6Tcnic5wBUsZSRd2V2Gg3DTlkJu8ST3TQTlHdlz1EAzMhamnsb7poyR5RN+u yBOKV1k7NFSNMQcMtGda48aNryDnaITQPHMWqUL1iiHKYbO2jVo5qy+7kx7PHCQu188HLzou WybLp1jx9NR6u1M7zw4HRiyGG9fEytGTLw18pZ+591/rXhWbuDC1zxdGwT X-IronPort-AV: E=Sophos;i="5.90,281,1643691600"; d="scan'208";a="69106718" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YnUtHrKtgrrOsjG8Vuk7UiGTU2PGEATc0QIxiOPfqZFaLRUamoPnWAqTd123RofsMCyalbz7V8sn1zaE4l91mYgyTntk+DSiMBIUrr9mplAB7I8Qb+Ibym6ehPicZqr50jJ8wjA+Gm7BElWv2JFFk4Rfvz5ToW6YB7TIn/hRckQJFlJrzEMVeHmeLCG0GDYkJ3a3BaZZbBQN0oQ7fiI36WluogAzJ8LVUE1xeTZ02kZ37/Ryx4FRd8OHRauTATNaMwn/cu/1IXi+lNyXo8YwvHeHX7Hx0/hb0nft6chjR+P6b46ROLJWwJEkSNNjvLAdvZ2eymkc7mxTutsoYNAGiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bM3CyK4VaAA0IgvwsaZcFswjVL7XDE5uP7TLiMHcKM0=; b=Y67bJ2o2EGXSteg03hhD4nQJiJYE+5Vh4ie7Kmoq8oT6gsTbdPgk23aMtUGW6330cLAts4F6xOk147fXVWt9LZ+PvnNk/A1SdrXBsUsp2N5h0Zbe3h+aQBTlFAUJ9esVyaVEy2HBw0pxDkkuqOIQG7hx5DiYpGTyXu1OS3IzBpWB3XhCOFUYsn3/gUh4KkRTyUTfz3pHf2uJnxYi2vBGpF49qS+TgDKMCuoeJXIlHYOtDEFINkHedphxePmRuME4Vxz7QFw3jZcLB7JkjGfOB6IAuym1RNcVojDZS+FC9uPNfTcnmJtCrUAAzOmjcvuAYvQ3POGDBOXmQw/l37bKdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bM3CyK4VaAA0IgvwsaZcFswjVL7XDE5uP7TLiMHcKM0=; b=Re2zctFnTOSnmJiHXCjA6/3qRZojXu4QSprPhiLB/SWvGkXN3+uDFNMxJZRSvhA3mj9T/8vdoKI3rWgPgAF4RaesoarG7TtaeBoECHofuz+8wywexLyTFS7u7vE6noQFcvAbH3I6+zQ1jqrntPNeGwwdW9LU+rx4bxsSIpiN31g= From: Martin Harvey To: Martin Harvey , "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Subject: RE: XenVif div by zero on Tx path after resume. Thread-Topic: XenVif div by zero on Tx path after resume. Thread-Index: AdhP6kAbDA19BbYtRECv6F4UUU/GxAD72daAAGmnvwAAAFp2cAAAUguAAC/5hJAAAFZNAAAAMhEAAANPABA= Date: Fri, 22 Apr 2022 14:09:50 +0000 Message-ID: References: <55d61956-1a0c-c4e9-cb79-ff24c3433ad1@gmail.com> In-Reply-To: <55d61956-1a0c-c4e9-cb79-ff24c3433ad1@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 08e7e083-0e3c-41d1-12c2-08da2469c452 x-ms-traffictypediagnostic: DM5PR03MB3161:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9K+fNvBzHQ8x2+X3B2MeSsq+tCKPB3X/wlF7cwpL0Oq9ZCvPl4SvtvHI2OuoxynEfCR4xupIf1pSDUCjph8+9YifYrRBhnVyCSGr76cCQH2FOchezfyM1wLefEiWCamJy8sGCVSYwR2iFIRwNz6+1nx7DLKaSwXrgzpFvGSCPxPaHUaocoXT/eRMzMi9rr/LKGdfW+n2KDaguWl6cctJE8HKGV/1oPptmQYN3dv0RSFCX6RLPXqSInCUhlIkyHm7RaFMvsKEUc3A2h9f9Ah4nRZigQ2mpm2DDom7sF0RRt5SUTp23r0AdGRtKlaU3hKnxVDyAcXBYx0RZ9miNOCYvfYKIstY+uBFJDweLprIb5XUycw3BxAAItMskd8/qgTucUM7YbtJwZSYHIUeGJDc+qrSEWkUZw1gxxb/3bcpmEsGTnteTcbWOxWB0uwbgw4nODwEoee3sSUuNHrRcUAGeWx481Bq0Awn2OMNUtkGWN0edWpTWLCzdEwb+3riCiELfBgYqRnutj4QKmpa54eZGQoQnbA5AX42cOGdUTiFWiiTDXNG7+AfPmSniZO1j3nY4beQKDseIz37K06WHwE+RAo3V2M1a8KEMTskOiJG6jRfk+lPDlgTGFi3uqpBDWAOD+tg8B5RpEu0Ggj47CgyoeUPULVso7az4gGlG+w2xqe6478a7KWbs9kwxrv71Vm0TCP8F6BjBGFzK/KiTI+WMzTjnUqlPoe3gEfJN3T0yDA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6347.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(6506007)(8936002)(33656002)(38070700005)(86362001)(9686003)(508600001)(7696005)(30864003)(38100700002)(44832011)(122000001)(82960400001)(52536014)(53546011)(5660300002)(26005)(110136005)(76116006)(316002)(8676002)(83380400001)(55016003)(71200400001)(64756008)(66476007)(186003)(66446008)(66556008)(66946007)(460985005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dnUrQkJmRzNQM2NZRzltNksxNmpTMHVveDFLNlVNd0NYd1Npd0l2ODdNNWd6?= =?utf-8?B?dU9ZR3piSklXWk5STEovQ2N0WGM5MzM0bzBSYWJ6QVBmeUNIdGlUWDY4Rjly?= =?utf-8?B?THZoMXdEUnhtaDRkTGJsU3NGZWlIam53WWNyZXozZHkyYXNaSFc4TlZQelVM?= =?utf-8?B?RWVqVE1SQnJieGZOQXV1T3N1RnJsdjY1UURRNnVTcGJxVmYwWFc3SHMvbU03?= =?utf-8?B?aGVCdzBMbmZRRklqSlFxWlJ2T1Y2a0lXOGJBRWU5N2ZMR0VLcVFvajN3cVc1?= =?utf-8?B?VDhuQzQ1cnJXN2RiWmRIT1lLQzhiZE9Tb2R1TEpmUS95K3BuQUttakZoYks2?= =?utf-8?B?QldXOEpuRG5uVGlZckZibFVPN2JGc1dEZ3AzcTdaZUMyQ25VeWhIMGFqMnlY?= =?utf-8?B?VTlUMzRxN3UzOW1lL2NrUFBwQmYzWG9kcjExYzRVRjI0eHdxM3cvQUhmakd1?= =?utf-8?B?dDEvbTUwWERDck5PUlg5Q1h4S0VzU3hMZnZPMHIvVHpZMTF0Z0tjRkEwanVQ?= =?utf-8?B?MVZLeElCYXorYVJ0MjFOSlVtUER5SGZ1N3BTc3EvTTBOaGUrQ1FJMUMwdUQ5?= =?utf-8?B?ZTZMNE9PUjhOL0dOMXJoem1rMms5Qi9qNjdza2tFTkhuMkxCdHNZRGphcVVn?= =?utf-8?B?eVJqRTN2Y2x1M0RudjdvemNqRXV5MFNIYmxYUUQyVkFMSEUxSWpiSVROWElE?= =?utf-8?B?elA3dHFyUk55UE9CRi9KSWh0SGhONjlVTHBtYkZzT1kvbTQ3UlRWVENBOFEv?= =?utf-8?B?SVNFUGlQOUNiSVJaR0JwT21NQnFOQzcyYVFMTmdhS2UwOHg2TlNPWFhoeENS?= =?utf-8?B?VkhRSnNTcFZ6ZTdrWWVVZmR5cFpsT1lWVTE5bGNtUjdqMEpuSFFMWHRFdXVv?= =?utf-8?B?V1pPRWE1RlhHUzYyQmpWc0xvcVJRQVhZNWRObWQxVFhmd1NzdjN4NmFycmUv?= =?utf-8?B?eC9iNXp4S2NjR09CZG93V3BQenJNTVJvUE93aEM3Zm5TNmRUMmFtTTJmQ2sy?= =?utf-8?B?KzRtOUh1K21kaFpnQ2ljSVFmQ21YRDBkRlp1eVZweUJrSmREUmc4R0dXRElS?= =?utf-8?B?Y3pFZUdwWDdyeVRVWEYzdnpONk9BWkJEbWt4VHpJazEvNENYOXZmSlJLejRa?= =?utf-8?B?d3VHc1ZFdzlGSFpKY2hGRU4vM3pUU0dxL1hGTHdCNzA4MTdaUjU4QTgvTjk1?= =?utf-8?B?M05JbjZSTTY2dEdQUUtmdkJjcjg3VVB3V0dlL1RWdnZDNXh2a21CL3hHd1hk?= =?utf-8?B?MmQvK3dTZXZ1S0ZiTnZ0K05nUHQxSlNzZFAzaysrQjJ1N3pIRGx1VFdkSWt0?= =?utf-8?B?NjRvNmpUU3NwSWtkNVBTbGNzRElMZmIrOU1KYUNoRGxDZHBwM2VyQ2x5WlFw?= =?utf-8?B?cTA5OXJ0d3NPaTdRNEx4RFFGaDV5STVtcFpQZ0ZHeWd4TmV6STdxYUg4N2s0?= =?utf-8?B?RTA3VUZlYTdvaXRhRVdDTTBldUNheWU1bFdYL1VqWGxrbTJCTnJLeElZdnV3?= =?utf-8?B?eStwdVVyM0NaU2cwcnh6Tzd4dTREand2NzlIT0pVbWc3bGVvMEhDdjdDa3Jw?= =?utf-8?B?a0JaNDNvT0FCcEhTcXlhbUtoMFBVYnBwNkhabUFkU1RDckYrMjJvQnJZV3RC?= =?utf-8?B?T2NVeXFZRFlFWnJBdU0rRSsvaFhlbHF1a3RIb3I0Zkd3eVcvT3FaZ2xXVnIx?= =?utf-8?B?N3l0QkloQkgrdEZROGVMTkh3Yk5SY1dKa1JGZTdkTDVmZ2hUVWxzQTRSczky?= =?utf-8?B?Y29LeUdLeWcvUG81OSs1cElYVkZ5c0VMcTBKbmZEckwrKy9LOGpFMXl2SlBh?= =?utf-8?B?QjVDSkVuOEFlTTZYaWc3QnAvMVVzTFp5NlBDaWo0ZjJXSTJEemF5V0s1MTZa?= =?utf-8?B?VnNNSG04a2pOMWpKL0lBeXhUMUpjbGszdTlIeHFZRGo2aDRXc21rZk5QMG83?= =?utf-8?B?eWVEQnQ2RytXbU5zaWZZWDRXMmZvbXhFNlAwR1FvMFB1bFJLUGpEOEc4RGIz?= =?utf-8?B?TUdKLzhKaFF5U1VkL0NSSzhWMkRBR1l3MXd1c3RHTnoxckQwU1VVeVNXRTZa?= =?utf-8?B?K3BUQ2pHcXB0WWtyb0hodDdtbWg4akRSMkFudG9UWlVZb1hIcHd2U3h0Z2tn?= =?utf-8?B?eGFKbFlZa3dWSDY2TERHend0b3kzT3JuTHFXbkd4TkNYakcxR1FpbTB1Q2Y4?= =?utf-8?B?dnBReTZtZWREZVVYZUN2b0lXakswZng4NDVMMmZ6V3Zta1ZEQU9hQVBGZ1Zq?= =?utf-8?B?d2xtSEt4RkF0dEEwODE2M2dBUVBOMU1SdzFOT2pqa3EzQlpWUytCZHZ5bWRR?= =?utf-8?B?elpwODBQK0Z2Z1ZoaDk2Y3ZPVjlZbmhmQk5VZmw2ZzRhZWtFWmNBQ1VIUktB?= =?utf-8?Q?0bPVK/rIbPktvO2I=3D?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6347.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08e7e083-0e3c-41d1-12c2-08da2469c452 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2022 14:09:50.9913 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kgZ6Tq8nd+DLzx6Op5Cq5AVfeiY+UX3Ro0aEhihGhFMBIS1pNbIu+95U+kG2K33l4kq+7QH8KJq1sXkY97d+DHiKZPf0LHBV4jVtnnYDKno= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3161 DQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiB3aW4tcHYtZGV2ZWwgPHdpbi1w di1kZXZlbC1ib3VuY2VzQGxpc3RzLnhlbnByb2plY3Qub3JnPiBPbiBCZWhhbGYgT2YgRHVycmFu dCwgUGF1bA0KU2VudDogMjIgQXByaWwgMjAyMiAxMzozMg0KVG86IHBhdWxAeGVuLm9yZzsgd2lu LXB2LWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQpTdWJqZWN0OiBSZTogWGVuVmlmIGRpdiBi eSB6ZXJvIG9uIFR4IHBhdGggYWZ0ZXIgcmVzdW1lLg0KDQoNCj4gT2ggZmZzLi4uIHRoZSBjYWxs IHRvIEtlTG93ZXJJcnFsKERJU1BBVENIX0xFVkVMKSBpcyBiZWluZyBkb25lIGF0IHRoZSBlbmQg b2YgU3luY0VuYWJsZUludGVycnVwdHMoKSByYXRoZXIgdGhhbiBhZnRlciB0aGUgbGF0ZSBjYWxs YmFja3MgYXQgdGhlIGJlZ2lubmluZyBvZiBTeW5jUmVsZWFzZSgpLiBUaGF0IHdpbGwgYmUgdGhl IHByb2JsZW0uLi4gYW5kIG5vdyBJIG5lZWQgdG8gZGlnIGZvciB3aHkgaXQgaXMgbGlrZSB0aGF0 Lg0KDQpZZXMsIEkgdGhvdWdodCBzb21ldGhpbmcgd2FzIGEgYml0IHdyb25nLg0KDQpPbiB0aGUg cnVubmluZyBtYWNoaW5lLCBJIG5vdGljZSBhbGwgdGhlIENQVSdzIGFyZSBhdCBJUlFMIHplcm8g KHNtYWxsIHNhbXBsZSBoZXJlIG9mIGEgZmV3IENQVSdzIG9mIDMyKSwgYW5kIGEgZHVtcCBvZiB0 aGUgcnVubmluZyB0aHJlYWRzIG9uIHRoZSBzeXN0ZW0sIG9uZSBvZiB3aGljaCBwb2ludHMgZmFp cmx5IGNvbmNsdXNpdmVseSB0byBTeW5jUmVsZWFzZToNCg0KDQozMToga2Q+ICFwY3IgMA0KS1BD UiBmb3IgUHJvY2Vzc29yIDAgYXQgZmZmZmY4MDYxMjA1YTAwMDoNCiAgICBNYWpvciAxIE1pbm9y IDENCglOdFRpYi5FeGNlcHRpb25MaXN0OiBmZmZmZjgwNjEyMTY5ZmIwDQoJICAgIE50VGliLlN0 YWNrQmFzZTogZmZmZmY4MDYxMjE2ODAwMA0KCSAgIE50VGliLlN0YWNrTGltaXQ6IDAwMDAwMDAw MDAwMDAwMDANCgkgTnRUaWIuU3ViU3lzdGVtVGliOiBmZmZmZjgwNjEyMDVhMDAwDQoJICAgICAg TnRUaWIuVmVyc2lvbjogMDAwMDAwMDAxMjA1YTE4MA0KCSAgTnRUaWIuVXNlclBvaW50ZXI6IGZm ZmZmODA2MTIwNWE4NzANCgkgICAgICBOdFRpYi5TZWxmVGliOiAwMDAwMDBjZjI4Y2YzMDAwDQoN CgkgICAgICAgICAgICBTZWxmUGNyOiAwMDAwMDAwMDAwMDAwMDAwDQoJICAgICAgICAgICAgICAg UHJjYjogZmZmZmY4MDYxMjA1YTE4MA0KCSAgICAgICAgICAgICAgIElycWw6IDAwMDAwMDAwMDAw MDAwMDANCgkgICAgICAgICAgICAgICAgSVJSOiAwMDAwMDAwMDAwMDAwMDAwDQoJICAgICAgICAg ICAgICAgIElEUjogMDAwMDAwMDAwMDAwMDAwMA0KCSAgICAgIEludGVycnVwdE1vZGU6IDAwMDAw MDAwMDAwMDAwMDANCgkgICAgICAgICAgICAgICAgSURUOiAwMDAwMDAwMDAwMDAwMDAwDQoJICAg ICAgICAgICAgICAgIEdEVDogMDAwMDAwMDAwMDAwMDAwMA0KCSAgICAgICAgICAgICAgICBUU1M6 IDAwMDAwMDAwMDAwMDAwMDANCg0KCSAgICAgIEN1cnJlbnRUaHJlYWQ6IGZmZmZmODA2MTc1M2Zi ODANCgkgICAgICAgICBOZXh0VGhyZWFkOiBmZmZmZTA4NGQwMmQ5MDgwDQoJICAgICAgICAgSWRs ZVRocmVhZDogZmZmZmY4MDYxNzUzZmI4MA0KDQoJICAgICAgICAgIERwY1F1ZXVlOiBVbmFibGUg dG8gcmVhZCBudCFfS0RQQ19EQVRBLkRwY0xpc3RIZWFkLkZsaW5rIEAgZmZmZmY4MDYxMjA1ZDRj MA0KDQozMToga2Q+ICFwY3IgMQ0KS1BDUiBmb3IgUHJvY2Vzc29yIDEgYXQgZmZmZjk3ODFmMmJl YjAwMDoNCiAgICBNYWpvciAxIE1pbm9yIDENCglOdFRpYi5FeGNlcHRpb25MaXN0OiBmZmZmOTc4 MWYyYmZjZmIwDQoJICAgIE50VGliLlN0YWNrQmFzZTogZmZmZjk3ODFmMmJmYjAwMA0KCSAgIE50 VGliLlN0YWNrTGltaXQ6IDAwMDAwMDAwMDAwMDAwMDANCgkgTnRUaWIuU3ViU3lzdGVtVGliOiBm ZmZmOTc4MWYyYmViMDAwDQoJICAgICAgTnRUaWIuVmVyc2lvbjogMDAwMDAwMDBmMmJlYjE4MA0K CSAgTnRUaWIuVXNlclBvaW50ZXI6IGZmZmY5NzgxZjJiZWI4NzANCgkgICAgICBOdFRpYi5TZWxm VGliOiAwMDAwMDBlNzYxMzQyMDAwDQoNCgkgICAgICAgICAgICBTZWxmUGNyOiAwMDAwMDAwMDAw MDAwMDAwDQoJICAgICAgICAgICAgICAgUHJjYjogZmZmZjk3ODFmMmJlYjE4MA0KCSAgICAgICAg ICAgICAgIElycWw6IDAwMDAwMDAwMDAwMDAwMDANCgkgICAgICAgICAgICAgICAgSVJSOiAwMDAw MDAwMDAwMDAwMDAwDQoJICAgICAgICAgICAgICAgIElEUjogMDAwMDAwMDAwMDAwMDAwMA0KCSAg ICAgIEludGVycnVwdE1vZGU6IDAwMDAwMDAwMDAwMDAwMDANCgkgICAgICAgICAgICAgICAgSURU OiAwMDAwMDAwMDAwMDAwMDAwDQoJICAgICAgICAgICAgICAgIEdEVDogMDAwMDAwMDAwMDAwMDAw MA0KCSAgICAgICAgICAgICAgICBUU1M6IDAwMDAwMDAwMDAwMDAwMDANCg0KCSAgICAgIEN1cnJl bnRUaHJlYWQ6IGZmZmZlMDg0ZDExNjQwODANCgkgICAgICAgICBOZXh0VGhyZWFkOiAwMDAwMDAw MDAwMDAwMDAwDQoJICAgICAgICAgSWRsZVRocmVhZDogZmZmZjk3ODFmMmJmODA0MA0KDQoJICAg ICAgICAgIERwY1F1ZXVlOiBVbmFibGUgdG8gcmVhZCBudCFfS0RQQ19EQVRBLkRwY0xpc3RIZWFk LkZsaW5rIEAgZmZmZjk3ODFmMmJlZTRjMA0KDQozMToga2Q+ICFwY3IgMg0KS1BDUiBmb3IgUHJv Y2Vzc29yIDIgYXQgZmZmZjk3ODFmMmU4NzAwMDoNCiAgICBNYWpvciAxIE1pbm9yIDENCglOdFRp Yi5FeGNlcHRpb25MaXN0OiBmZmZmOTc4MWYyZTk4ZmIwDQoJICAgIE50VGliLlN0YWNrQmFzZTog ZmZmZjk3ODFmMmU5NzAwMA0KCSAgIE50VGliLlN0YWNrTGltaXQ6IDAwMDAwMDAwMDAwMDAwMDAN CgkgTnRUaWIuU3ViU3lzdGVtVGliOiBmZmZmOTc4MWYyZTg3MDAwDQoJICAgICAgTnRUaWIuVmVy c2lvbjogMDAwMDAwMDBmMmU4NzE4MA0KCSAgTnRUaWIuVXNlclBvaW50ZXI6IGZmZmY5NzgxZjJl ODc4NzANCgkgICAgICBOdFRpYi5TZWxmVGliOiAwMDAwMDA4NTVmNGE0MDAwDQoNCgkgICAgICAg ICAgICBTZWxmUGNyOiAwMDAwMDAwMDAwMDAwMDAwDQoJICAgICAgICAgICAgICAgUHJjYjogZmZm Zjk3ODFmMmU4NzE4MA0KCSAgICAgICAgICAgICAgIElycWw6IDAwMDAwMDAwMDAwMDAwMDANCgkg ICAgICAgICAgICAgICAgSVJSOiAwMDAwMDAwMDAwMDAwMDAwDQoJICAgICAgICAgICAgICAgIElE UjogMDAwMDAwMDAwMDAwMDAwMA0KCSAgICAgIEludGVycnVwdE1vZGU6IDAwMDAwMDAwMDAwMDAw MDANCgkgICAgICAgICAgICAgICAgSURUOiAwMDAwMDAwMDAwMDAwMDAwDQoJICAgICAgICAgICAg ICAgIEdEVDogMDAwMDAwMDAwMDAwMDAwMA0KCSAgICAgICAgICAgICAgICBUU1M6IDAwMDAwMDAw MDAwMDAwMDANCg0KCSAgICAgIEN1cnJlbnRUaHJlYWQ6IGZmZmY5NzgxZjJlOTQwNDANCgkgICAg ICAgICBOZXh0VGhyZWFkOiAwMDAwMDAwMDAwMDAwMDAwDQoJICAgICAgICAgSWRsZVRocmVhZDog ZmZmZjk3ODFmMmU5NDA0MA0KDQoJICAgICAgICAgIERwY1F1ZXVlOiBVbmFibGUgdG8gcmVhZCBu dCFfS0RQQ19EQVRBLkRwY0xpc3RIZWFkLkZsaW5rIEAgZmZmZjk3ODFmMmU4YTRjMA0KDQoNCg0K MzE6IGtkPiAJICAgICAgIXRocmVhZCBmZmZmZTA4NGQxMTY0MDgwDQpUSFJFQUQgZmZmZmUwODRk MTE2NDA4MCAgQ2lkIDBlZjguMWJlYyAgVGViOiAwMDAwMDBlNzYxMzQyMDAwIFdpbjMyVGhyZWFk OiAwMDAwMDAwMDAwMDAwMDAwIFJVTk5JTkcgb24gcHJvY2Vzc29yIDENCkltcGVyc29uYXRpb24g dG9rZW46ICBmZmZmYzAwOWZiNzEwMGYwIChMZXZlbCBJbXBlcnNvbmF0aW9uKQ0KT3duaW5nIFBy b2Nlc3MgICAgICAgICAgICBmZmZmZTA4NGQwMGIwMjQwICAgICAgIEltYWdlOiAgICAgICAgIHN2 Y2hvc3QuZXhlDQpBdHRhY2hlZCBQcm9jZXNzICAgICAgICAgIE4vQSAgICAgICAgICAgIEltYWdl OiAgICAgICAgIE4vQQ0KV2FpdCBTdGFydCBUaWNrQ291bnQgICAgICA2Mzg0ICAgICAgICAgICBU aWNrczogMA0KQ29udGV4dCBTd2l0Y2ggQ291bnQgICAgICAyMDcgICAgICAgICAgICBJZGVhbFBy b2Nlc3NvcjogMCAgICAgICAgICAgICANClVzZXJUaW1lICAgICAgICAgICAgICAgICAgMDA6MDA6 MDAuMDMxDQpLZXJuZWxUaW1lICAgICAgICAgICAgICAgIDAwOjAwOjAwLjAxNQ0KV2luMzIgU3Rh cnQgQWRkcmVzcyAweDAwMDA3ZmY5ZWI5M2JmYzANClN0YWNrIEluaXQgZmZmZjk1ODgxOGM2N2Jm MCBDdXJyZW50IGZmZmY5NTg4MThjNjcyZjANCkJhc2UgZmZmZjk1ODgxOGM2ODAwMCBMaW1pdCBm ZmZmOTU4ODE4YzYxMDAwIENhbGwgMDAwMDAwMDAwMDAwMDAwMA0KUHJpb3JpdHkgOCBCYXNlUHJp b3JpdHkgOCBQcmlvcml0eURlY3JlbWVudCAwIElvUHJpb3JpdHkgMiBQYWdlUHJpb3JpdHkgNQ0K Q2hpbGQtU1AgICAgICAgICAgUmV0QWRkciAgICAgICAgICAgOiBBcmdzIHRvIENoaWxkICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6IENh bGwgU2l0ZQ0KZmZmZjk1ODhgMThjNjc1MjAgZmZmZmY4MDZgMTZiMGI0MTkgOiBmZmZmYzAwOWBm YjcxMDAwMCBmZmZmZTA4NGBjOTZjMmIwMSBmZmZmOTU4OGAwMDAwMDAwMSBmZmZmZTA4NGBkMTI3 YmVhMCA6IG50IVNlQ2FwdHVyZVNlY3VyaXR5RGVzY3JpcHRvcisweDRkZA0KZmZmZjk1ODhgMThj Njc2MjAgZmZmZmY4MDZgMTZiMGFmMzMgOiAwMDAwMDAwMGAwMDAwMDAwMiBmZmZmYzAwOWBmYjg3 NjA2MCAwMDAwMDAwMGAwMDAwMDAwMSBmZmZmZjgwNmAxNmY4NTFkOSA6IG50IVNlQWNjZXNzQ2hl Y2tCeVR5cGVXaXRoQWRtaW5sZXNzQ2hlY2tzKzB4NGM5DQpmZmZmOTU4OGAxOGM2NzhlMCBmZmZm ZjgwNmAxNmIwZDE3NyA6IDAwMDAwMjBiYDZhZWYyM2QwIDAwMDAwMDAwYDAwMDAwMDAwIDAwMDAw MDAwYDAwMDAwY2I0IDAwMDAwMDAwYDAwMDAwMDAxIDogbnQhU2VBY2Nlc3NDaGVja0J5VHlwZSsw eDExMw0KZmZmZjk1ODhgMThjNjc5ODAgZmZmZmY4MDZgMTZjMjhjMzUgOiAwMDAwMDAwMGAwMDAw MDAwMCAwMDAwMDAwMGAwMDAwMDAwMCAwMDAwMDIwYmA2YWVmMjNkMCAwMDAwMDAwMGAwMDAwMDAw MCA6IG50IU50QWNjZXNzQ2hlY2srMHg1Nw0KZmZmZjk1ODhgMThjNjc5ZjAgMDAwMDdmZjlgZWI5 Y2VlZjQgOiAwMDAwMDAwMGAwMDAwMDAwMCAwMDAwMDAwMGAwMDAwMDAwMCAwMDAwMDAwMGAwMDAw MDAwMCAwMDAwMDAwMGAwMDAwMDAwMCA6IG50IUtpU3lzdGVtU2VydmljZUNvcHlFbmQrMHgyNSAo VHJhcEZyYW1lIEAgZmZmZjk1ODhgMThjNjdhNjApDQowMDAwMDBlN2A2MWJmZGQ0OCAwMDAwMDAw MGAwMDAwMDAwMCA6IDAwMDAwMDAwYDAwMDAwMDAwIDAwMDAwMDAwYDAwMDAwMDAwIDAwMDAwMDAw YDAwMDAwMDAwIDAwMDAwMDAwYDAwMDAwMDAwIDogMHgwMDAwN2ZmOWBlYjljZWVmNA0KDQozMTog a2Q+IAkgICAgICAhdGhyZWFkIGZmZmZlMDg0Y2JiNWUwNDANClRIUkVBRCBmZmZmZTA4NGNiYjVl MDQwICBDaWQgMDAwNC4wMmNjICBUZWI6IDAwMDAwMDAwMDAwMDAwMDAgV2luMzJUaHJlYWQ6IDAw MDAwMDAwMDAwMDAwMDAgUlVOTklORyBvbiBwcm9jZXNzb3IgMTMNCk5vdCBpbXBlcnNvbmF0aW5n DQpEZXZpY2VNYXAgICAgICAgICAgICAgICAgIGZmZmZjMDA5ZjVhMzY2YmYNCk93bmluZyBQcm9j ZXNzICAgICAgICAgICAgZmZmZmUwODRjOTZiNDA0MCAgICAgICBJbWFnZTogICAgICAgICBTeXN0 ZW0NCkF0dGFjaGVkIFByb2Nlc3MgICAgICAgICAgTi9BICAgICAgICAgICAgSW1hZ2U6ICAgICAg ICAgTi9BDQpXYWl0IFN0YXJ0IFRpY2tDb3VudCAgICAgIDUxODAgICAgICAgICAgIFRpY2tzOiAx MjA0ICgwOjAwOjAwOjE4LjgxMikNCkNvbnRleHQgU3dpdGNoIENvdW50ICAgICAgMyAgICAgICAg ICAgICAgSWRlYWxQcm9jZXNzb3I6IDE5ICAgICAgICAgICAgIA0KVXNlclRpbWUgICAgICAgICAg ICAgICAgICAwMDowMDowMC4wMDANCktlcm5lbFRpbWUgICAgICAgICAgICAgICAgMDA6MDA6MTgu ODEyDQpXaW4zMiBTdGFydCBBZGRyZXNzIHhlbmJ1cyFUaHJlYWRGdW5jdGlvbiAoMHhmZmZmZjgw NjE4N2ZhODUwKQ0KU3RhY2sgSW5pdCBmZmZmOTU4ODE1MjY3YmYwIEN1cnJlbnQgZmZmZjk1ODgx NTI2NzZmMA0KQmFzZSBmZmZmOTU4ODE1MjY4MDAwIExpbWl0IGZmZmY5NTg4MTUyNjEwMDAgQ2Fs bCAwMDAwMDAwMDAwMDAwMDAwDQpQcmlvcml0eSA4IEJhc2VQcmlvcml0eSA4IFByaW9yaXR5RGVj cmVtZW50IDAgSW9Qcmlvcml0eSAyIFBhZ2VQcmlvcml0eSA1DQpDaGlsZC1TUCAgICAgICAgICBS ZXRBZGRyICAgICAgICAgICA6IEFyZ3MgdG8gQ2hpbGQgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDogQ2FsbCBTaXRlDQooSW5saW5lIEZ1 bmN0aW9uKSAtLS0tLS0tLWAtLS0tLS0tLSA6IC0tLS0tLS0tYC0tLS0tLS0tIC0tLS0tLS0tYC0t LS0tLS0tIC0tLS0tLS0tYC0tLS0tLS0tIC0tLS0tLS0tYC0tLS0tLS0tIDogeGVuYnVzIVN5bmNS ZWxlYXNlKzB4YzQgKElubGluZSBGdW5jdGlvbiBAIGZmZmZmODA2YDE4N2ZhMmUxKSBbRTpcamVu a2luc1x3b3Jrc3BhY2Vcd2luLXhlbmJ1c19tYXN0ZXJcbG9jYWxcc3JjXHhlbmJ1c1xzeW5jLmMg QCA0NjBdIA0KZmZmZjk1ODhgMTUyNjc5ZjAgZmZmZmY4MDZgMTg3ZWIyMDYgOiBmZmZmZTA4NGBj YmIwOWEwMCBmZmZmZTA4NGAwMDFmMDAwMCAwMDAwMDAwMGAwMDk4OTY4MCAwMDAwMDAwMGAwMDk4 OTY4MCA6IHhlbmJ1cyFTdXNwZW5kVHJpZ2dlcisweDVkMSBbRTpcamVua2luc1x3b3Jrc3BhY2Vc d2luLXhlbmJ1c19tYXN0ZXJcbG9jYWxcc3JjXHhlbmJ1c1xzdXNwZW5kLmMgQCAyODhdIA0KZmZm Zjk1ODhgMTUyNjdhYTAgZmZmZmY4MDZgMTg3ZmE4NmEgOiA1ZDE1OGQ0OGAwMDY0MjQ2NCA0ODI0 NDQ4OWA0OGZmYTc3OCBmZmZmZTA4NGBjYmEzOGNlMCAyNDRjODkwMGAwMDAwODgyNCA6IHhlbmJ1 cyFGZG9TdXNwZW5kKzB4MWE2IFtFOlxqZW5raW5zXHdvcmtzcGFjZVx3aW4teGVuYnVzX21hc3Rl clxsb2NhbFxzcmNceGVuYnVzXGZkby5jIEAgMTY1OF0gDQpmZmZmOTU4OGAxNTI2N2I0MCBmZmZm ZjgwNmAxNmFlODNmNSA6IGZmZmZlMDg0YGNiYjVlMDQwIGZmZmZmODA2YDE4N2ZhODUwIGZmZmZl MDg0YGNiYTM4Y2UwIDIwMjQ2NDgzYDQ4MDAyODI0IDogeGVuYnVzIVRocmVhZEZ1bmN0aW9uKzB4 MWEgW0U6XGplbmtpbnNcd29ya3NwYWNlXHdpbi14ZW5idXNfbWFzdGVyXGxvY2FsXHNyY1x4ZW5i dXNcdGhyZWFkLmMgQCAxMDldIA0KZmZmZjk1ODhgMTUyNjdiNzAgZmZmZmY4MDZgMTZjMWE4Njgg OiBmZmZmOTc4MWBmM2RlYTE4MCBmZmZmZTA4NGBjYmI1ZTA0MCBmZmZmZjgwNmAxNmFlODNhMCAz ZDgwMzc0NWA4OTQ4YzQzMyA6IG50IVBzcFN5c3RlbVRocmVhZFN0YXJ0dXArMHg1NQ0KZmZmZjk1 ODhgMTUyNjdiYzAgMDAwMDAwMDBgMDAwMDAwMDAgOiBmZmZmOTU4OGAxNTI2ODAwMCBmZmZmOTU4 OGAxNTI2MTAwMCAwMDAwMDAwMGAwMDAwMDAwMCAwMDAwMDAwMGAwMDAwMDAwMCA6IG50IUtpU3Rh cnRTeXN0ZW1UaHJlYWQrMHgyOA0KDQozMToga2Q+IAkgICAgICAhdGhyZWFkIGZmZmZlMDg0ZDEy YzQwODANClRIUkVBRCBmZmZmZTA4NGQxMmM0MDgwICBDaWQgMTEwYy4wODdjICBUZWI6IDAwMDAw MDAwMDBkNjQwMDAgV2luMzJUaHJlYWQ6IGZmZmZlMDg0ZDFhNWZiZDAgUlVOTklORyBvbiBwcm9j ZXNzb3IgMTUNCk5vdCBpbXBlcnNvbmF0aW5nDQpEZXZpY2VNYXAgICAgICAgICAgICAgICAgIGZm ZmZjMDA5ZjVhMzY2YmYNCk93bmluZyBQcm9jZXNzICAgICAgICAgICAgZmZmZmUwODRkMDE4MjBj MCAgICAgICBJbWFnZTogICAgICAgICB4ZW5ndWVzdGFnZW50LmV4ZQ0KQXR0YWNoZWQgUHJvY2Vz cyAgICAgICAgICBOL0EgICAgICAgICAgICBJbWFnZTogICAgICAgICBOL0ENCldhaXQgU3RhcnQg VGlja0NvdW50ICAgICAgNjM4MyAgICAgICAgICAgVGlja3M6IDEgKDA6MDA6MDA6MDAuMDE1KQ0K Q29udGV4dCBTd2l0Y2ggQ291bnQgICAgICA3ICAgICAgICAgICAgICBJZGVhbFByb2Nlc3Nvcjog MjcgICAgICAgICAgICAgDQpVc2VyVGltZSAgICAgICAgICAgICAgICAgIDAwOjAwOjAwLjAwMA0K S2VybmVsVGltZSAgICAgICAgICAgICAgICAwMDowMDowMC4wMDANCldpbjMyIFN0YXJ0IEFkZHJl c3MgMHgwMDAwN2ZmOWViOTNiZmMwDQpTdGFjayBJbml0IGZmZmY5NTg4MTZlMmZiZjAgQ3VycmVu dCBmZmZmOTU4ODE2ZTJmMzUwDQpCYXNlIGZmZmY5NTg4MTZlMzAwMDAgTGltaXQgZmZmZjk1ODgx NmUyOTAwMCBDYWxsIDAwMDAwMDAwMDAwMDAwMDANClByaW9yaXR5IDggQmFzZVByaW9yaXR5IDgg UHJpb3JpdHlEZWNyZW1lbnQgMCBJb1ByaW9yaXR5IDIgUGFnZVByaW9yaXR5IDUNCkNoaWxkLVNQ ICAgICAgICAgIFJldEFkZHIgICAgICAgICAgIDogQXJncyB0byBDaGlsZCAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOiBDYWxsIFNpdGUN CmZmZmY5NTg4YDE2ZTJmNjcwIGZmZmZmODA2YDE3MjQyMjM5IDogMDAwMDAwMDBgMDAwMDAwMDAg MDEwMDAwMDBgMDAxMDAwMDAgMDAwMDAwMDBgMDAwMDAwMDAgMDAwMDAwMDBgMDAwMDAwMDAgOiBu dCFFeEZyZWVIZWFwUG9vbCsweDFjOA0KZmZmZjk1ODhgMTZlMmY3NzAgZmZmZmY4MDZgMTZmMTIx YjcgOiAwMDAwMDAwMGAxZTFiNTE4MCBmZmZmZTA4NGBjOTgxOGM2MCAwMDAwMDAwMGAxZWQyYzBl OCBmZmZmYzAwOWBmYjg3NGJlMCA6IG50IUV4RnJlZVBvb2wrMHg5DQpmZmZmOTU4OGAxNmUyZjdh MCBmZmZmZjgwNmAxNmY3MDFlMiA6IGZmZmZjMDA5YDAwMDAwMDAwIDAwMDAwMDAwYDAwMDAwMDAw IGZmZmZjMDA5YGZiODc0YmUwIDAwMDAwMDAwYDFlZDJjMGU4IDogbnQhQWxwY01lc3NhZ2VEZXN0 cm95UHJvY2VkdXJlKzB4NDcNCmZmZmY5NTg4YDE2ZTJmN2QwIGZmZmZmODA2YDE2ZjZmZGMyIDog MDAwMDAwMDBgMWUxYjUxODAgMDAwMDAwMDBgZmUwMDAwMDAgZmZmZmMwMDlgZmI4NzRiZTAgMDAw MDAwMDBgZmUwMDAwMDAgOiBudCFBbHBjcFVubG9ja0Jsb2IrMHhjMg0KZmZmZjk1ODhgMTZlMmY4 MTAgZmZmZmY4MDZgMTZmNmRjNDYgOiBmZmZmZTA4NGBjOTgxOGM2MCBmZmZmOTU4OGAwMDAyMDAw MCAwMDAwMDAwMGAxZTFiNTE4MCAwMDAwMDAwMGAxYzYxNGMyOCA6IG50IUFscGNwUHJvY2Vzc1N5 bmNocm9ub3VzUmVxdWVzdCsweDU2Mg0KZmZmZjk1ODhgMTZlMmY5MzAgZmZmZmY4MDZgMTZjMjhj MzUgOiBmZmZmZTA4NGBkMTJjNDA4MCBmZmZmOTU4OGAxNmUyZmFlMCAwMDAwMDAwMGAxZWQyYzBi OCBmZmZmOTU4OGAxNmUyZmEwOCA6IG50IU50QWxwY1NlbmRXYWl0UmVjZWl2ZVBvcnQrMHgxZDYN CmZmZmY5NTg4YDE2ZTJmOWYwIDAwMDA3ZmY5YGViOWQwMDY0IDogMDAwMDAwMDBgMDAwMDAwMDAg MDAwMDAwMDBgMDAwMDAwMDAgMDAwMDAwMDBgMDAwMDAwMDAgMDAwMDAwMDBgMDAwMDAwMDAgOiBu dCFLaVN5c3RlbVNlcnZpY2VDb3B5RW5kKzB4MjUgKFRyYXBGcmFtZSBAIGZmZmY5NTg4YDE2ZTJm YTYwKQ0KMDAwMDAwMDBgMWVkMmMwOTggMDAwMDAwMDBgMDAwMDAwMDAgOiAwMDAwMDAwMGAwMDAw MDAwMCAwMDAwMDAwMGAwMDAwMDAwMCAwMDAwMDAwMGAwMDAwMDAwMCAwMDAwMDAwMGAwMDAwMDAw MCA6IDB4MDAwMDdmZjlgZWI5ZDAwNjQNCg0KMzE6IGtkPiAJICAgICAgIXRocmVhZCBmZmZmZTA4 NGQwODQzMDQwDQpUSFJFQUQgZmZmZmUwODRkMDg0MzA0MCAgQ2lkIDE1YjguMTVlOCAgVGViOiAw MDAwMDBmOWY1NjA0MDAwIFdpbjMyVGhyZWFkOiAwMDAwMDAwMDAwMDAwMDAwIFJVTk5JTkcgb24g cHJvY2Vzc29yIDE2DQpOb3QgaW1wZXJzb25hdGluZw0KRGV2aWNlTWFwICAgICAgICAgICAgICAg ICBmZmZmYzAwOWY1YTM2NmJmDQpPd25pbmcgUHJvY2VzcyAgICAgICAgICAgIGZmZmZlMDg0ZDA4 M2UyODAgICAgICAgSW1hZ2U6ICAgICAgICAgV21pUHJ2U0UuZXhlDQpBdHRhY2hlZCBQcm9jZXNz ICAgICAgICAgIE4vQSAgICAgICAgICAgIEltYWdlOiAgICAgICAgIE4vQQ0KV2FpdCBTdGFydCBU aWNrQ291bnQgICAgICA2Mzg0ICAgICAgICAgICBUaWNrczogMA0KQ29udGV4dCBTd2l0Y2ggQ291 bnQgICAgICAxODM2ICAgICAgICAgICBJZGVhbFByb2Nlc3NvcjogMjIgICAgICAgICAgICAgDQpV c2VyVGltZSAgICAgICAgICAgICAgICAgIDAwOjAwOjAwLjA5Mw0KS2VybmVsVGltZSAgICAgICAg ICAgICAgICAwMDowMDowMC4wMzENCldpbjMyIFN0YXJ0IEFkZHJlc3MgMHgwMDAwN2ZmOWViOTNi ZmMwDQpTdGFjayBJbml0IGZmZmY5NTg4MTgyYjdiZjAgQ3VycmVudCBmZmZmOTU4ODE4MmI3MzUw DQpCYXNlIGZmZmY5NTg4MTgyYjgwMDAgTGltaXQgZmZmZjk1ODgxODJiMTAwMCBDYWxsIDAwMDAw MDAwMDAwMDAwMDANClByaW9yaXR5IDggQmFzZVByaW9yaXR5IDggUHJpb3JpdHlEZWNyZW1lbnQg MCBJb1ByaW9yaXR5IDIgUGFnZVByaW9yaXR5IDUNCkNoaWxkLVNQICAgICAgICAgIFJldEFkZHIg ICAgICAgICAgIDogQXJncyB0byBDaGlsZCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgOiBDYWxsIFNpdGUNCjAwMDAwMGY5YGY1YTdjYTM4 IDAwMDAwMDAwYDAwMDAwMDAwIDogMDAwMDAwMDBgMDAwMDAwMDAgMDAwMDAwMDBgMDAwMDAwMDAg MDAwMDAwMDBgMDAwMDAwMDAgMDAwMDAwMDBgMDAwMDAwMDAgOiAweDAwMDA3ZmY5YGViOWJlMmUy DQoNCjMxOiBrZD4gCSAgICAgICF0aHJlYWQgZmZmZmUwODRkMDJlMTA4MA0KVEhSRUFEIGZmZmZl MDg0ZDAyZTEwODAgIENpZCAwZWY4LjFkMGMgIFRlYjogMDAwMDAwZTc2MTM0ZTAwMCBXaW4zMlRo cmVhZDogMDAwMDAwMDAwMDAwMDAwMCBSVU5OSU5HIG9uIHByb2Nlc3NvciAxOQ0KTm90IGltcGVy c29uYXRpbmcNCkRldmljZU1hcCAgICAgICAgICAgICAgICAgZmZmZmMwMDlmNWEzNjZiZg0KT3du aW5nIFByb2Nlc3MgICAgICAgICAgICBmZmZmZTA4NGQwMGIwMjQwICAgICAgIEltYWdlOiAgICAg ICAgIHN2Y2hvc3QuZXhlDQpBdHRhY2hlZCBQcm9jZXNzICAgICAgICAgIE4vQSAgICAgICAgICAg IEltYWdlOiAgICAgICAgIE4vQQ0KV2FpdCBTdGFydCBUaWNrQ291bnQgICAgICA2MzgzICAgICAg ICAgICBUaWNrczogMSAoMDowMDowMDowMC4wMTUpDQpDb250ZXh0IFN3aXRjaCBDb3VudCAgICAg IDQ1ICAgICAgICAgICAgIElkZWFsUHJvY2Vzc29yOiAxNyAgICAgICAgICAgICANClVzZXJUaW1l ICAgICAgICAgICAgICAgICAgMDA6MDA6MDAuMDAwDQpLZXJuZWxUaW1lICAgICAgICAgICAgICAg IDAwOjAwOjAwLjAwMA0KV2luMzIgU3RhcnQgQWRkcmVzcyAweDAwMDA3ZmY5ZDczMTBlOTANClN0 YWNrIEluaXQgZmZmZjk1ODgxODk1ZmJmMCBDdXJyZW50IGZmZmY5NTg4MTg5NWYzNTANCkJhc2Ug ZmZmZjk1ODgxODk2MDAwMCBMaW1pdCBmZmZmOTU4ODE4OTU5MDAwIENhbGwgMDAwMDAwMDAwMDAw MDAwMA0KUHJpb3JpdHkgOCBCYXNlUHJpb3JpdHkgOCBQcmlvcml0eURlY3JlbWVudCAwIElvUHJp b3JpdHkgMiBQYWdlUHJpb3JpdHkgNQ0KQ2hpbGQtU1AgICAgICAgICAgUmV0QWRkciAgICAgICAg ICAgOiBBcmdzIHRvIENoaWxkICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICA6IENhbGwgU2l0ZQ0KMDAwMDAwZTdgNjI0ZmY3NzggMDAwMDAw MDBgMDAwMDAwMDAgOiAwMDAwMDAwMGAwMDAwMDAwMCAwMDAwMDAwMGAwMDAwMDAwMCAwMDAwMDAw MGAwMDAwMDAwMCAwMDAwMDAwMGAwMDAwMDAwMCA6IDB4MDAwMDdmZjlgZWI5YmUyZTINCg0KMzE6 IGtkPiAJICAgICAgIXRocmVhZCBmZmZmZTA4NGQwNDExMDgwDQpUSFJFQUQgZmZmZmUwODRkMDQx MTA4MCAgQ2lkIDEwMDQuMTI5YyAgVGViOiAwMDAwMDA4NTVmNGE2MDAwIFdpbjMyVGhyZWFkOiAw MDAwMDAwMDAwMDAwMDAwIFJVTk5JTkcgb24gcHJvY2Vzc29yIDFmDQpOb3QgaW1wZXJzb25hdGlu Zw0KRGV2aWNlTWFwICAgICAgICAgICAgICAgICBmZmZmYzAwOWY1YTM2NmJmDQpPd25pbmcgUHJv Y2VzcyAgICAgICAgICAgIGZmZmZlMDg0ZDAxOTMwYzAgICAgICAgSW1hZ2U6ICAgICAgICAgd2lu ZG93c2NsYXRzZGFlbW9uLXg2NC5leGUNCkF0dGFjaGVkIFByb2Nlc3MgICAgICAgICAgTi9BICAg ICAgICAgICAgSW1hZ2U6ICAgICAgICAgTi9BDQpXYWl0IFN0YXJ0IFRpY2tDb3VudCAgICAgIDEy NDYgICAgICAgICAgIFRpY2tzOiA1MTM4ICgwOjAwOjAxOjIwLjI4MSkNCkNvbnRleHQgU3dpdGNo IENvdW50ICAgICAgMzUzICAgICAgICAgICAgSWRlYWxQcm9jZXNzb3I6IDMxICAgICAgICAgICAg IA0KVXNlclRpbWUgICAgICAgICAgICAgICAgICAwMDowMDowMC4wMTUNCktlcm5lbFRpbWUgICAg ICAgICAgICAgICAgMDA6MDA6MDAuMDMxDQpXaW4zMiBTdGFydCBBZGRyZXNzIDB4MDAwMDAwMDAw MGM2NTRhMA0KU3RhY2sgSW5pdCBmZmZmOTU4ODE3Y2EyYmYwIEN1cnJlbnQgZmZmZjk1ODgxN2Nh MjQwMA0KQmFzZSBmZmZmOTU4ODE3Y2EzMDAwIExpbWl0IGZmZmY5NTg4MTdjOWMwMDAgQ2FsbCAw MDAwMDAwMDAwMDAwMDAwDQpQcmlvcml0eSA4IEJhc2VQcmlvcml0eSA4IFByaW9yaXR5RGVjcmVt ZW50IDAgSW9Qcmlvcml0eSAyIFBhZ2VQcmlvcml0eSA1DQpDaGlsZC1TUCAgICAgICAgICBSZXRB ZGRyICAgICAgICAgICA6IEFyZ3MgdG8gQ2hpbGQgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDogQ2FsbCBTaXRlDQpmZmZmOTU4OGAxN2Nh MTc0OCBmZmZmZjgwNmAxOWY5MDg0YSA6IDAwMDAwMDAwYDAwMDBkZWFkIGZmZmZmODA2YDE5ZmE3 YzUwIGZmZmZmODA2YDE5ZmE3YzcwIDAwMDAwMDAwYDAwMDAxNDRlIDogbnQhS2VCdWdDaGVja0V4 DQooSW5saW5lIEZ1bmN0aW9uKSAtLS0tLS0tLWAtLS0tLS0tLSA6IC0tLS0tLS0tYC0tLS0tLS0t IC0tLS0tLS0tYC0tLS0tLS0tIC0tLS0tLS0tYC0tLS0tLS0tIC0tLS0tLS0tYC0tLS0tLS0tIDog eGVudmlmIV9fQnVnKzB4MjQgKElubGluZSBGdW5jdGlvbiBAIGZmZmZmODA2YDE5ZjkwODRhKSBb RTpcamVua2luc1x3b3Jrc3BhY2VcbnZpZl9wcml2YXRlX21hcnRpbmhhcl9DQS0zNTU2NzBcbG9j YWxcc3JjXHhlbnZpZlxhc3NlcnQuaCBAIDQ5XSANCmZmZmY5NTg4YDE3Y2ExNzUwIGZmZmZmODA2 YDE5Zjk5MDNhIDogZmZmZmUwODRgY2Q2ZTE5ZjAgMDAwMDAwMDBgYzAwMDAwMDEgMDAwMDAwMDBg MDAwMDAwY2EgMDAwMDAwMDBgMDAwMDAwMDAgOiB4ZW52aWYhVHJhbnNtaXR0ZXJRdWV1ZVBhY2tl dCsweDE0YSBbRTpcamVua2luc1x3b3Jrc3BhY2VcbnZpZl9wcml2YXRlX21hcnRpbmhhcl9DQS0z NTU2NzBcbG9jYWxcc3JjXHhlbnZpZlx0cmFuc21pdHRlci5jIEAgNTE5OF0gDQpmZmZmOTU4OGAx N2NhMTdjMCBmZmZmZjgwNmAxYWIyNzAyYiA6IGZmZmZmZmZmYGZmZmZmZmZlIDAwMDAwMDAwYDAw MDAwMDBjIDAwMDAwMDAwYDAwMDAwMDAwIDAwMDAwMDAwYDAwMDAwMDAwIDogeGVudmlmIVZpZlRy YW5zbWl0dGVyUXVldWVQYWNrZXQrMHgzZWEgW0U6XGplbmtpbnNcd29ya3NwYWNlXG52aWZfcHJp dmF0ZV9tYXJ0aW5oYXJfQ0EtMzU1NjcwXGxvY2FsXHNyY1x4ZW52aWZcdmlmLmMgQCA0MzldIA0K KElubGluZSBGdW5jdGlvbikgLS0tLS0tLS1gLS0tLS0tLS0gOiAtLS0tLS0tLWAtLS0tLS0tLSAt LS0tLS0tLWAtLS0tLS0tLSAtLS0tLS0tLWAtLS0tLS0tLSAtLS0tLS0tLWAtLS0tLS0tLSA6IHhl bm5ldCFfX1RyYW5zbWl0dGVyU2VuZE5ldEJ1ZmZlckxpc3QrMHgxZDggKElubGluZSBGdW5jdGlv biBAIGZmZmZmODA2YDFhYjI3MDJiKSBbRTpcamVua2luc1x3b3Jrc3BhY2Vcd2luLXhlbm5ldF9t YXN0ZXJcbG9jYWxcc3JjXHhlbm5ldFx0cmFuc21pdHRlci5jIEAgMzI5XSANCmZmZmY5NTg4YDE3 Y2ExODMwIGZmZmZmODA2YDE4NWE1ZTdmIDogZmZmZmUwODRgZDAxMzIwMTAgZmZmZmUwODRgZDIy OTc2NDQgMDAwMDAwMDBgMDAwMDAwMDAgMDAwMDAwMDBgMDAwMDAwMTggOiB4ZW5uZXQhVHJhbnNt aXR0ZXJTZW5kTmV0QnVmZmVyTGlzdHMrMHgyN2IgW0U6XGplbmtpbnNcd29ya3NwYWNlXHdpbi14 ZW5uZXRfbWFzdGVyXGxvY2FsXHNyY1x4ZW5uZXRcdHJhbnNtaXR0ZXIuYyBAIDM4NF0gDQpmZmZm OTU4OGAxN2NhMTkwMCBmZmZmZjgwNmAxODVhNWQ2ZSA6IDAwMDAwMDAwYDAwMDAwMDAwIGZmZmZl MDg0YGQyMjk3MmMwIDAwMDAwMDAwYDAwMDAwMDAwIDAwMDAwMDAwYDAwMDAwMDAyIDogTkRJUyFu ZGlzTVNlbmROQkxUb01pbmlwb3J0SW50ZXJuYWwrMHhmZg0KZmZmZjk1ODhgMTdjYTE5ZDAgZmZm ZmY4MDZgMTg1YTgwNjIgOiBmZmZmZjgwNmAxNzQ1ZWUwMCAwMDAwMDAwMGAwMDEyYTAwZiAwMDAw MDAwMGAwMDAwMTA4MCBmZmZmZjgwNmAxNmIzZjAxYyA6IE5ESVMhbmRpc01TZW5kTkJMVG9NaW5p cG9ydCsweGUNCmZmZmY5NTg4YDE3Y2ExYTEwIGZmZmZmODA2YDE4NWEyMjkwIDogMDAwMDAwMDBg MDAwMDAwMDIgZmZmZjk1ODhgMTdjYTFhZTkgZmZmZmUwODRgY2Q1YWU4MDAgZmZmZmZiODBgMDAw MDAwMDAgOiBORElTIW5kaXNJbnZva2VOZXh0U2VuZEhhbmRsZXIrMHg0Mg0KZmZmZjk1ODhgMTdj YTFhNjAgZmZmZmY4MDZgMTkxMDY0NzEgOiBmZmZmZTA4NGBkMjI5NzJjMCBmZmZmZTA4NGBkMjI5 NzJjMCAwMDAwMDAxNGAwMDAwMDAwMCBmZmZmOTU4OGAwMDAwMDAwMSA6IE5ESVMhTmRpc1NlbmRO ZXRCdWZmZXJMaXN0cysweDVmMA0KZmZmZjk1ODhgMTdjYTFiNTAgZmZmZmY4MDZgMTkxMDVkNGIg OiBmZmZmZTA4NGBjZDE2MjBjMCAwMDAwMDAwMGAwMDAwMDAxNCBmZmZmZTA4NGBjYmY2ZDhhMCBm ZmZmZjgwNmAwMDAwMDAwNiA6IHRjcGlwIUlwTmxwRmFzdENvbnRpbnVlU2VuZERhdGFncmFtcysw eDU1MQ0KZmZmZjk1ODhgMTdjYTFjYTAgZmZmZmY4MDZgMTkxMDM2MGEgOiBmZmZmZTA4NGBkMDNh NTdlMCAxYTAwMDAwMWAwMDAwMDAxNCAwMDAwMDAwMGAwMDAwMDAwMCBmZmZmZTA4NGBjZjg4Njcy MCA6IHRjcGlwIUlwTmxwRmFzdFNlbmREYXRhZ3JhbSsweDIzYg0KZmZmZjk1ODhgMTdjYTFkNjAg ZmZmZmY4MDZgMTkxMDFiY2IgOiAwMDAwMDAwMGAzYjc1OTllYyAwMDAwMDAwMGAwMDk4OTY4MCBm ZmZmZTA4NGBjZDEzZTE2OCAwMDAwMDAwMGAwMDAwMDAwMCA6IHRjcGlwIVRjcFRjYlNlbmQrMHgx NDFhDQpmZmZmOTU4OGAxN2NhMjBiMCBmZmZmZjgwNmAxOTEwMTg2NSA6IDAwMDAwMDAwYDAwMDAw MDAwIDAwMDAwMDAwYDAwMDAwMDAwIDAwMDAwMDAwYDAwMDAwMDAwIGZmZmY5NTg4YDE3Y2EyNmQw IDogdGNwaXAhVGNwRW5xdWV1ZVRjYlNlbmQrMHgzNGINCmZmZmY5NTg4YDE3Y2EyMWQwIGZmZmZm ODA2YDE2YjEzNWQ4IDogMDAwMDAwMDBgMDAwMDAwMDAgMDAwMDAwMDBgMDAwMDAwMDAgMDAwMDAw MDBgMDAwMDAwMDAgZmZmZmUwODRgY2JkNmI4ZjAgOiB0Y3BpcCFUY3BUbENvbm5lY3Rpb25TZW5k Q2FsbG91dFJvdXRpbmUrMHgyNQ0KZmZmZjk1ODhgMTdjYTIyMTAgZmZmZmY4MDZgMTZiMTM1NGQg OiBmZmZmZjgwNmAxOTEwMTg0MCBmZmZmOTU4OGAxN2NhMjJmMCBmZmZmZTA4NGBkMDY5Zjg3OCAw MDAwMDAwMGAwMDAwMDAwMCA6IG50IUtlRXhwYW5kS2VybmVsU3RhY2tBbmRDYWxsb3V0SW50ZXJu YWwrMHg3OA0KZmZmZjk1ODhgMTdjYTIyODAgZmZmZmY4MDZgMTkxNWRlMGQgOiAwMDAwMDAwMGAw MDAwMDAwMCAwMDAwMDAwMGAwMDAwMDAwMCAwMDAwMDAwMGAwMDAwMDE4YiAwMDAwMDAwMGAwMDAw MDAwMCA6IG50IUtlRXhwYW5kS2VybmVsU3RhY2tBbmRDYWxsb3V0RXgrMHgxZA0KZmZmZjk1ODhg MTdjYTIyYzAgZmZmZmY4MDZgMTlhMmIyNjYgOiBmZmZmZTA4NGBkMDY5Zjg3OCBmZmZmZTA4NGBk MDU2NDVhMCAwMDAwMDAwMGAwMDAwMDAxOCBmZmZmZTA4NGBkMDY5Zjg3OCA6IHRjcGlwIVRjcFRs Q29ubmVjdGlvblNlbmQrMHg4ZA0KZmZmZjk1ODhgMTdjYTIzMzAgZmZmZmY4MDZgMTlhMmFlN2Ig OiBmZmZmZTA4NGBkMDU2NDVhMCBmZmZmOTU4OGAxN2NhMmFlMCBmZmZmZTA4NGBkMDY5ZjY3MCBm ZmZmZTA4NGBkMDYzMzZlMCA6IGFmZCFBZmRUTFN0YXJ0QnVmZmVyZWRWY1NlbmQrMHhiMg0KZmZm Zjk1ODhgMTdjYTIzZjAgZmZmZmY4MDZgMTlhMjdkODcgOiBmZmZmZTA4NGBkMDY5Zjg3OCBmZmZm ZTA4NGBkMDU2NDVhMCBmZmZmOTU4OGAwMDAwMDAxOCBmZmZmOTU4OGAxN2NhMjhjOCA6IGFmZCFB ZmRGYXN0Q29ubmVjdGlvblNlbmQrMHgyOTMNCmZmZmY5NTg4YDE3Y2EyNGMwIGZmZmZmODA2YDE2 ZjkzNmRiIDogMDAwMDAwMDBgMDAwMDAyODQgMDAwMDAwMDBgMDAwMDAwMDAgMDAwMDAwMDBgMDAw MDAwMDAgZmZmZmUwODRgZDA0YzlkOTAgOiBhZmQhQWZkRmFzdElvRGV2aWNlQ29udHJvbCsweGYy Nw0KZmZmZjk1ODhgMTdjYTI4NTAgZmZmZmY4MDZgMTZmOTNjZTYgOiAwMDAwMDAwMGAwMDAwMDAw MCAwMDAwMDAwMGAwMDAwMDAwMCAwMDAwMDAwMGAwMDAwMDAwMCAwMDAwMDBjMGAwMDEzNDM2OCA6 IG50IUlvcFh4eENvbnRyb2xGaWxlKzB4NmZiDQpmZmZmOTU4OGAxN2NhMjk4MCBmZmZmZjgwNmAx NmMyOGMzNSA6IGZmZmZlMDg0YGQwMzI0ZjYwIDAwMDAwMDAwYDAwMDAwMDAwIDAwMDAwMDg1YDAw MDAwMDAwIGZmZmZlMDg0YGQwNDEwMWMwIDogbnQhTnREZXZpY2VJb0NvbnRyb2xGaWxlKzB4NTYN CmZmZmY5NTg4YDE3Y2EyOWYwIDAwMDA3ZmY5YGViOWNlZmQ0IDogMDAwMDAwMDBgMDAwMDAwMDAg MDAwMDAwMDBgMDAwMDAwMDAgMDAwMDAwMDBgMDAwMDAwMDAgMDAwMDAwMDBgMDAwMDAwMDAgOiBu dCFLaVN5c3RlbVNlcnZpY2VDb3B5RW5kKzB4MjUgKFRyYXBGcmFtZSBAIGZmZmY5NTg4YDE3Y2Ey YTYwKQ0KMDAwMDAwODVgNjAxZmZiNjggMDAwMDAwMDBgMDAwMDAwMDAgOiAwMDAwMDAwMGAwMDAw MDAwMCAwMDAwMDAwMGAwMDAwMDAwMCAwMDAwMDAwMGAwMDAwMDAwMCAwMDAwMDAwMGAwMDAwMDAw MCA6IDB4MDAwMDdmZjlgZWI5Y2VmZDQNCg0KMzE6IGtkPiAJICAgICANCg0KDQoNCg== From win-pv-devel-bounces@lists.xenproject.org Fri Apr 22 14:13:02 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 22 Apr 2022 14:13:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.310981.527962 (Exim 4.92) (envelope-from ) id 1nhu1u-0003l2-7n; Fri, 22 Apr 2022 14:13:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 310981.527962; Fri, 22 Apr 2022 14:13:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nhu1u-0003kv-4r; Fri, 22 Apr 2022 14:13:02 +0000 Received: by outflank-mailman (input) for mailman id 310981; Fri, 22 Apr 2022 14:13:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nhu1s-0003kn-CV for win-pv-devel@lists.xenproject.org; Fri, 22 Apr 2022 14:13:00 +0000 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [2a00:1450:4864:20::334]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 50516365-c246-11ec-8fc2-03012f2f19d4; Fri, 22 Apr 2022 16:12:59 +0200 (CEST) Received: by mail-wm1-x334.google.com with SMTP id l62-20020a1c2541000000b0038e4570af2fso5438074wml.5 for ; Fri, 22 Apr 2022 07:12:59 -0700 (PDT) Received: from [10.7.237.9] (54-240-197-225.amazon.com. [54.240.197.225]) by smtp.gmail.com with ESMTPSA id y6-20020a05600015c600b0020a8f950471sm2269158wry.115.2022.04.22.07.12.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Apr 2022 07:12:58 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 50516365-c246-11ec-8fc2-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=k+LTNwvhtFJU0qz1Kdjhr/6gESicLKr3wi4zxvXzk7E=; b=bimpTTL4Vj7z7iXrcnS9Aa5Ordf5zWW3uU69AV2h07m6K32KScQs8PltSKZ1RomweV W/M5raTNbn43AXdpdD+IJqfDzpTwh66Hl0ZCEAeG1LikXg3RFOTb87KnI65+3rpp+mTw CaOnXkec9LgFpOyU9rcjguXaNVTOAX43OA7us8fNyJwyxW90oNeFiUyIXjYuu4UMcs15 DwyzhTfFY4QWznRjHmeBhEZLykEnz4r0XfvQimeHpv8pBPn5jRHQq3bK3T5ViP5Vvhhv OJiT3dxhfcWbZxNslxAbX358Q8KCB5sj4y8QZCRb5UoyOOKMSeqNjJSMHNI3JpbCyiZy Q9ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=k+LTNwvhtFJU0qz1Kdjhr/6gESicLKr3wi4zxvXzk7E=; b=5OjQ50o4eVUWdxV5pTwaqZ5NF+SS4jSYHyE3xvE/cpEdoaaniu72MYNBS9+4Thbu+Z jdxInvA8oL/dFl1lkR8/BKgWhVbAc7B2DVDz2588ZAgsI+wmh7db9pxTxk0eOwfDYCZq VtUAQNQurv54eR0wR/IMOuvQPktHI0P9efFcc7vVDCS4sURHjUkntHtvOaPEEQMhd8zE fOzobNZGH1bzAvQOta5OwAD8s01rTWvr5DIuHbhUOFNDvBMGt4b0wwkUuMLsRYYxjSkI Zb7nz2SPJ27nXO26cfe2Vfn2j22Yv8/0nIwM6NtYOVkV3+Y17e3pIiz4Qr7mEBn77fNH 6dbg== X-Gm-Message-State: AOAM532uKymQmTrrh+aqdUaX8URfsA6/2zMYHkMuNIOA0SjClkLApMCZ 3RxuZuI4nOInGaR5bJkw1DU= X-Google-Smtp-Source: ABdhPJzJ5BHuSFUQ39KW6Ou2ChbnDEpvb7OQc+c/hDpUzqF6euZvCiRAZ7Lbtpjy4Q6hwCQeeiOsQA== X-Received: by 2002:a05:600c:19c9:b0:391:d98d:2cf3 with SMTP id u9-20020a05600c19c900b00391d98d2cf3mr4393073wmq.136.1650636778895; Fri, 22 Apr 2022 07:12:58 -0700 (PDT) Message-ID: Date: Fri, 22 Apr 2022 15:12:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Reply-To: paul@xen.org Subject: Re: XenVif div by zero on Tx path after resume. Content-Language: en-US To: Martin Harvey , "paul@xen.org" , "win-pv-devel@lists.xenproject.org" References: <55d61956-1a0c-c4e9-cb79-ff24c3433ad1@gmail.com> From: "Durrant, Paul" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 22/04/2022 15:09, Martin Harvey wrote: > > > -----Original Message----- > From: win-pv-devel On Behalf Of Durrant, Paul > Sent: 22 April 2022 13:32 > To: paul@xen.org; win-pv-devel@lists.xenproject.org > Subject: Re: XenVif div by zero on Tx path after resume. > > >> Oh ffs... the call to KeLowerIrql(DISPATCH_LEVEL) is being done at the end of SyncEnableInterrupts() rather than after the late callbacks at the beginning of SyncRelease(). That will be the problem... and now I need to dig for why it is like that. > > Yes, I thought something was a bit wrong. > > On the running machine, I notice all the CPU's are at IRQL zero (small sample here of a few CPU's of 32), and a dump of the running threads on the system, one of which points fairly conclusively to SyncRelease: > ... and unfortunately it seems to have been broken for so long my git history won't tell me when :-( Paul From win-pv-devel-bounces@lists.xenproject.org Fri Apr 22 14:17:57 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 22 Apr 2022 14:17:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.310989.527967 (Exim 4.92) (envelope-from ) id 1nhu6e-0003tp-Kc; Fri, 22 Apr 2022 14:17:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 310989.527967; Fri, 22 Apr 2022 14:17:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nhu6e-0003ti-Hh; Fri, 22 Apr 2022 14:17:56 +0000 Received: by outflank-mailman (input) for mailman id 310989; Fri, 22 Apr 2022 14:17:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nhu6d-0003tc-2C for win-pv-devel@lists.xenproject.org; Fri, 22 Apr 2022 14:17:55 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fe7c26c4-c246-11ec-8fc2-03012f2f19d4; Fri, 22 Apr 2022 16:17:53 +0200 (CEST) Received: from mail-bn1nam07lp2046.outbound.protection.outlook.com (HELO NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.46]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 22 Apr 2022 10:17:50 -0400 Received: from MW4PR03MB6347.namprd03.prod.outlook.com (2603:10b6:303:11e::22) by DM6PR03MB3802.namprd03.prod.outlook.com (2603:10b6:5:50::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 22 Apr 2022 14:17:46 +0000 Received: from MW4PR03MB6347.namprd03.prod.outlook.com ([fe80::e9f0:3774:1ce9:6059]) by MW4PR03MB6347.namprd03.prod.outlook.com ([fe80::e9f0:3774:1ce9:6059%9]) with mapi id 15.20.5186.015; Fri, 22 Apr 2022 14:17:46 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: fe7c26c4-c246-11ec-8fc2-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1650637073; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=ZArF+yyRBctzeGHws8CCjbZTmrhtAjJ4yjD3wY1d5Uw=; b=CN7kxXIv6yXP7ZDJNKWhidQJV8eLOGECioNoCgDuLmSBZbTAxQ9frF21 tQP24tM/4y8kQ2v4UggaZQzMI6g0pqc3EJTi85TLNbyHnvWGNU8140MzH Qvj0SA22g9umzZ//Aos/SSETV9gE5s0pON/ktCbqUXYkxNOQkSNZSE7Cz s=; X-IronPort-RemoteIP: 104.47.51.46 X-IronPort-MID: 69706825 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:aObeGaCNmOKVnRVW/0riw5YqxClBgxIJ4kV8jS/XYbTApD8j1DYOx 2QbWD2FOPuKYWanc4okOYm0oxsBu5DVyoQwQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Jj2NYy6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhQ1 s1LkNvgVj0CJ7zjp/swECV1PDphaPguFL/veRBTsOS15mieKT7G5awrC0s7e4oF5uxwHGdCs +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6t/B8ydK0nJzYYwMDMYg8lUAffYI coQcyRifTzLYgFVO0dRA5U79AutrieuLGUG+AjIzUYxy2jR7hVs/LjJCdz2ZvnRaJt4nVy9+ EuTqgwVBTlfbrRz0wGt6nuxgsffkCW9X5gdfJWn9/gvmEPWymENBRk+UVqgveL/mkO4Q8hYK UEf5mwpt6dayaCwZtz0Xhn9qnjduBcZA4VUC7ditF/LzbfI6QGEAGRCViRGdNEtqM4xQ3oty 0ONmNTqQzdotdV5VE6gy1tdlhvqUQB9EIPITXZsodctizU7nLwOsw== IronPort-HdrOrdr: A9a23:6EHDOK8JHbZ/TlC2uVtuk+Fsdb1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQkdcKO7SdK9qBTnhNRICOgqTPyftWzd1FdAQ7sSibcKrweAJ8S6zJ8l6U 4CSdkyNDSTNykcsS+S2mDRfLgdKZu8gcaVbIzlvhRQpHRRGsRdBnBCe2Sm+yNNJDVuNN4cLt 6x98BHrz2vdTA8dcKgHEQIWODFupniiI/mSQRuPW9p1CC+yReTrJLqGRmR2RkTFxlVx605zG TDmwvloo2+rvCAzAPG3WO71eUZpDKh8KoDOCW/sLlXFtzesHfrWG2nYczGgNkBmpDu1L/tqq iJn/5vBbU115qbRBDOnfKk4Xic7N9p0Q6v9bbQuwqeneXpAD09EMZPnoRfb1/Q7Fchpsh11O ZR03uerIc/N2K3oM3R3am9a/hRrDvCnZPiq59is1VPFY8FLLNBp40W+01YVJ8GASLh8YgiVO 1jFtvV6vpaeU6TKymxhBgm/PW8GnAoWhuWSEkLvcKYlzBQgXBi1kMdgMgShG0J+p4xQ4RNo+ 7ELqNrnrdTSdJ+V9M1OM4RBc+sTmDdSxPFN2yfZVzhCaEcInrI74X65b0kjdvaDaDgDKFC6q gpfGkoy1LaIXiedvFm9Kc7gyzlUSG6QSnnzN1Y6txwpqD8LYCbQhG+dA== X-IronPort-AV: E=Sophos;i="5.90,282,1643691600"; d="scan'208";a="69706825" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VjPE8LH2bMgF/kawVcc56VG0egRa0Yj6pzwnNr57ZRKriAW+IE1JBpdHdsoHWT99i1e8pwmMkQG6Q1R0qKis1pualJdA7wRoo3BEpUWbWG9IxICC+8x6WM1RqnTKrqLOgQlPLmHc6LNcbvOHGDvDzwZX6NdqwQfDk9UMhLGlMTvqXz7FZnfUOYQ2NKiv5wTHCbUFg5lwSCwvhA82FYqduKLR/7OuQJxQ0tDnfct09lpis5eB52CHdm1LyFfA8J4Jz3oLTHoO3Iixg3x23uJIUcOmk8rqWGQOSnsFlbONHWP+f3iunoHXySAd1iEkfoO0SMrTohIe0udEcQQ3Ag88tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZArF+yyRBctzeGHws8CCjbZTmrhtAjJ4yjD3wY1d5Uw=; b=A1vpUCPlqBvieZTaNPKWUYd0qHl5qsNXsoh2SfiCf8J/UH4QMDTfxWEQmQnrfUE7Yo29k2xIPgvGOBEijbcJu/Xc7ncp1VdU1zv/Cc3JYFuZ2s/CBAx35aaHJChZ8jsGvMt7H3nbYu9mDoqJZpkLzsXbc+gZdVvdGeWzHrzYA9VYMQKU8dyp4EVnkjYCUzsQgTLy3ib5WG8WXea52b8k8vQOZsRdWim2yI2UmvTA0vMAmGcWkfe9cLeuJNEtxCLdYgYAbVHi8Kzij01B5SDKkQyrDboShR43rcLm6J0zy71gHfi/4mGxW9UcYGRDU9IRn6s5rcvX/r1pdwm9pE3Ajg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZArF+yyRBctzeGHws8CCjbZTmrhtAjJ4yjD3wY1d5Uw=; b=ftR/ZjuUIe3dPQUd5PIy8lDlwQUkvIAncFN02F8RlY31FZh1DYUz/W141JsZC0ng2c7jCzJo2WjG6yQGrKFRGTgPSVwqsg8U5erERRVC0tfggzadTeQ37VwGIFenoRNGoXTeUVBbOViWZ5SmimvIpGhGhETrvIQTy/Oq32U4Aw8= From: Martin Harvey To: "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Subject: RE: XenVif div by zero on Tx path after resume. Thread-Topic: XenVif div by zero on Tx path after resume. Thread-Index: AdhP6kAbDA19BbYtRECv6F4UUU/GxAD72daAAGmnvwAAAFp2cAAAUguAAC/5hJAAAFZNAAAAMhEAAANPABAAADUugAAAE7WQ Date: Fri, 22 Apr 2022 14:17:46 +0000 Message-ID: References: <55d61956-1a0c-c4e9-cb79-ff24c3433ad1@gmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1d6960e1-3a55-459f-9f4b-08da246adfb9 x-ms-traffictypediagnostic: DM6PR03MB3802:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Qsd8b3pwdJpn24DzRQSUzhvOzHnhcc3M7R8WRo3WAKsdtzFAzvuwGvQAwhrOy6EKY32JdNcv722cKsJ/47dKQy1TcM965VXyfcOOHkYavmlcNO1M5xjUZLfUYxH868kSUMMx2enpnmz3yG3WIewtIM4cVy9M9MajOkLa8R/DOsOqjsRP7ryoV/muJV32iqWqcg3oMP5h8rKn6YpC257nJBTp3DZI57AWJ5GYG99qIJnQRlnCrya3EGDcfFjbkU/Q5ArrMERLpHtuBtF2WHCQQIGt5ODG1FqJOKlMwHKBXvaSJWndCJt7hGktxIt1tyD4D+IRmrjchVJH8Pw8u36+htBhfYnRKcS8wWjYOwXSh6RKbqZeQ6f/SKbRurgTDs6eP2srSDuC6dpmI8xefrDGb6zerRiE3RxM4FsRTm8AnxswSyPhLZS1iyAOj/E583bqFHWo/Gt3C+GLXtr991rUKW1NOc8X1+nBf0BmJn8WnqUWcOKQHI7gPQmgHseoJDSvUZvrucJP3NOFEcB9ex1m0yjvnhbB3pE3eNWZMSW7ZpK2AHrXM/QWw3a054d496R8Ll22yy/eMfkiafTRMiTaDnkWitFZ+vGU+L3H2Z2BXCC43UpbCLAc8jtgZ88EzAMP+KPKHgUATm3I1QY3W/7/prBZAglLXJ3Vfd8Lax93y2sh82wjbDt7ZLn1RTqw5MeDf4/qA2VHXfrsIp86E5uE2Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6347.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(71200400001)(55016003)(26005)(83380400001)(33656002)(2906002)(8676002)(5660300002)(9686003)(7696005)(53546011)(38070700005)(38100700002)(110136005)(82960400001)(6506007)(316002)(64756008)(66556008)(186003)(66476007)(66446008)(52536014)(66946007)(44832011)(86362001)(508600001)(76116006)(4744005)(8936002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?L3ZOWUJCdzQxVStVSmd2RmFxdVhMTGk3dlRWYTB2bFNFL04rQlIva1liSDhF?= =?utf-8?B?Qnl6ZXlqdjJibTk3bHlmSldnWGJ4Qm00SzlobisxWVl0S05QWFhaU3BxRXRn?= =?utf-8?B?MU9qTmx1YUtHeWFmOWJLdkxKQ1REdWJXRjJzTWFpT3d3aXVOL2RESENpMTJX?= =?utf-8?B?QXJHYjM4MUNiOHpxcFNlc0JZcVhmbDJYcXlWWmNIYVJKU2tod3Z4K0dRNndh?= =?utf-8?B?M2ZUeXVoRDRTSEgyaDA2YlcxbG5wTGpCM3BhQytzS29Od1N4ekdhcENRY2J6?= =?utf-8?B?cnkrT2RoN2FOTHg0ZFZhcVJXVEVPWmROZ2ZyT0orLzdyd2dVSzZXd3pRNlFD?= =?utf-8?B?bGswWkJYR2FhRDUrZEYxZWVTNG9ySmtZbzRpVkJJSEQrME1BTDZ2VzU1N2dD?= =?utf-8?B?MVllVll4YWovbGMvdE1raVFaemNFQjdSSXJydmc2YTJ0UTFhT2NkaGtYWHpm?= =?utf-8?B?dngvSjF5eS9XcVJuakhWcjNNSVhlOUJZZlFrVldkQTF5NjZEeWlycVN0amxu?= =?utf-8?B?VVJqYi81NjUzSVFpcjFKM0h2NWoyRDNZayttY25WVzdDNlVqVk8wbC9DQkxZ?= =?utf-8?B?aWZ1c3A2Z0hHUVhxZ2IyT3RoR3FQTlFrQmlXS0t2a28zN2k2OG9vdUJaU094?= =?utf-8?B?eFo0cXArUkRBV3RuaFdVdzhYQm90MUxoQnpNQytBd0JuaG5aa2g2cjFjQU5k?= =?utf-8?B?WEdHaTI0T1dWOFFobnA4ZnA4N3hlalBlVEw5MHBzczQ1OHlxRlIrMWpJdzdw?= =?utf-8?B?Y1RJaU56R3JqUHg3Tmo5aGVJcm4yVzQrV2ZGVktLTEZjV3NibzdXTGNnUDRX?= =?utf-8?B?V25oM2xsQmk5L05QdzhUUUdVRG4zdHphVjllWDZJV05sZXl3S25PZDdYODAx?= =?utf-8?B?NHRBN3F5dWcxM29sWFUrZUlLTjU3VmxQRWtHcjRYTHhHZHFzaUhNeUxNdm85?= =?utf-8?B?ZjQ0NnpDZzVqRnFQNFZ3UEtjM1ZVcTF0dkpQelFXc1czZ3BnK252QXAyUzdF?= =?utf-8?B?R1hXVkZSRFJ2TTQwc3lQSnVnRXhEU0RSL0FWelArU0RGZi83VnFlSlFEb2Y5?= =?utf-8?B?UVJmT3kyL1p2eEU0c1V2RTFGRktBWkRBaGF1VDBKMmoxVzRiU1FTbVZnMnFE?= =?utf-8?B?NUx4blY1SGZESTJhVC8yU3NjR3NBUUdudUNMMWFjK3liNHhFU0NyS1ZmbDcz?= =?utf-8?B?STFUNXJyQ0JENjRSOThROGdQeHE4cExmbVBpejdlVXRBcGJOVDJTeVdoQ0Jl?= =?utf-8?B?V21ZbUY2TnhzcTRZMGt2ODFROGhWNjdYNXVBQzk4cXE4djMvVCt6VmZIK2RP?= =?utf-8?B?T1VTQ01MdXArbFBUTzJIeUg3QWdibElsUmxldlMxWmdTNFdvdTFLQkJtNGxR?= =?utf-8?B?K0YvdzJtVU16aXlJNFp3T2krWGgxSmpGRld0Q3ZOcVlrWHFKVFZVMTV4R2t0?= =?utf-8?B?K2xlbXpGMmtmTHZLNGpkdFVIbkJ1ay8zb2hOZHdzU2RDUEI3Lys5UTFrUzZW?= =?utf-8?B?Vm0xcUw3K0R4U2U2a2wrck9UQ1dBSGluVE5IYlRIdDVuQ1RxK1RQUXRKT0Uv?= =?utf-8?B?T3BXTXBNaGV4UjZjTTNialhKTzdFRzVHcEErUGJ5SmEvSVRYblUrL2FmUDBs?= =?utf-8?B?cGFnYS9DUmpYWmJpLzJxSmRkSjFFazE5TFJwMWRNdUpNK2pVcEk0dy9OaUw1?= =?utf-8?B?REh2WlRua05wS2ludWlvZ1BibmFoQnVXV2pSaDQyajNibS8xRVNLVmFHUjZP?= =?utf-8?B?MDZ1V0Nmb2pYeDVtR0dGQlJGWHNsR2ltbTA2UTZrSmhBUGlzY1o2Smt6TDRz?= =?utf-8?B?L3RjRE9hS2czeEhjdm13N0xTWTlvS09nbCsvVXlMTFliQ3AxMXRUc0lhbTFE?= =?utf-8?B?UDRkVTlNSE9UZDJvUCtBaTNDaUM2Z1ZNSS9PTlM0MUhpbFBFNFFiL1Z5cEth?= =?utf-8?B?eVhrNXZvRlc3aFRuWGFiWHVXUkZ5RFlkQ25aeTFCNnlQWTdkRXlxUEtQZGJZ?= =?utf-8?B?MFo2YkYwYUNtaVBPZUsrTndVZXlQOU9La3dNdUo2cDV0N05VSWZpR2lJUFJU?= =?utf-8?B?RCsrdnNyQkc3eitCWS9kek5YdjkxRkpZT3pvcVYwRVk5Rmd3WVMrOFRxcHZv?= =?utf-8?B?dmNtcnladDA1enlHOVZwOTFxMVoxYy9uK29HblVlWW1Nd2dERzV0eE9OaEds?= =?utf-8?B?VWRnaFlmNGdPbjdVU2NieGlFdXNIdjlCRlZNMFE0TWFoNnJnV3krZy8xeXZZ?= =?utf-8?B?bjdma0JQSVNtWmE2WnRNUFNPcVU3dldWSnJFbUhPbXB1SjFMaVlVVUo3VmVC?= =?utf-8?B?WTBkZy9kdVU2RDlray9XaU9tazgyU01yN1JFRW50bzN4Zi82ZEN3bWV5SjJr?= =?utf-8?Q?r7jkoikEIIDa6eUk=3D?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6347.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1d6960e1-3a55-459f-9f4b-08da246adfb9 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2022 14:17:46.4807 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: m/GxgPo4i9dfSNUm4aLTzq6KAlrFPIcGeAyQJVgIFVXnUdDa+j3vPAIhmD1v5LrMxz2ZhPfvHgn9JBwFZtb4pgpSrimudE35ddHd5x9ArAg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3802 DQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBEdXJyYW50LCBQYXVsIDx4YWRp bWduaWtAZ21haWwuY29tPiANClNlbnQ6IDIyIEFwcmlsIDIwMjIgMTU6MTMNClRvOiBNYXJ0aW4g SGFydmV5IDxtYXJ0aW4uaGFydmV5QGNpdHJpeC5jb20+OyBwYXVsQHhlbi5vcmc7IHdpbi1wdi1k ZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KU3ViamVjdDogUmU6IFhlblZpZiBkaXYgYnkgemVy byBvbiBUeCBwYXRoIGFmdGVyIHJlc3VtZS4NCg0KDQo+IC4uLiBhbmQgdW5mb3J0dW5hdGVseSBp dCBzZWVtcyB0byBoYXZlIGJlZW4gYnJva2VuIGZvciBzbyBsb25nIG15IGdpdCBoaXN0b3J5IHdv bid0IHRlbGwgbWUgd2hlbiA6LSgNCg0KT2ggZGVhci4gUG9zc2libHkgb25lIG9mIHRob3NlICJo b3cgZGlkIGl0IGV2ZXIgd29yaz8iIGJ1Z3MuDQoNCklmIHlvdSBuZWVkIHRlc3RpbmcgcmVzb3Vy Y2UgLyB2YWxpZGF0aW9uIGZvciBhbnkgcGF0Y2hlcyB5b3UnZCBsaWtlIHRvIHRocm93IG15IHdh eSwgSSBkbyBoYXZlIGEgdi4gZ29vZCBzZXQgb2YgYXV0b21hdGVzIHRlc3QgY2FzZXMgd2hpY2gg d2lsbCByZXBybyB0aGUgYnVnIChhZnRlciBhYm91dCAxMiBob3VycyBvZiBDUFUgZ3JpbmRpbmcp LCBhbmQgY2hlY2sgdGhhdCBtb3N0IG9idmlvdXMgdGhpbmdzIGFyZW4ndCBicm9rZW4uDQoNCklS UUwgaXMgc3VjaCBhIG5pZ2h0bWFyZTogWW91IGNhbiBnZXQgaXQgd3JvbmcgaW4gb25lIHBsYWNl IGFuZCB0aGUgc3VidGx5IGJyb2tlbiBDUFUgc3RhdGUgdGhlbiBkaWVzIGluIHRoZSBuZXh0IHBp ZWNlIG9mIGNvZGUgdGhhdCBuZWVkcyBzb21lIGxldmVsIG9mIGF0b21pY2l0eS4NCg0KTUguDQo= From win-pv-devel-bounces@lists.xenproject.org Fri Apr 22 14:20:38 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 22 Apr 2022 14:20:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.310997.527971 (Exim 4.92) (envelope-from ) id 1nhu9F-0004jk-TY; Fri, 22 Apr 2022 14:20:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 310997.527971; Fri, 22 Apr 2022 14:20:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nhu9F-0004jc-PY; Fri, 22 Apr 2022 14:20:37 +0000 Received: by outflank-mailman (input) for mailman id 310997; Fri, 22 Apr 2022 14:20:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nhu9D-0004jW-Ru for win-pv-devel@lists.xenproject.org; Fri, 22 Apr 2022 14:20:35 +0000 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [2a00:1450:4864:20::436]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5fdb62ad-c247-11ec-8fc2-03012f2f19d4; Fri, 22 Apr 2022 16:20:35 +0200 (CEST) Received: by mail-wr1-x436.google.com with SMTP id c10so11303631wrb.1 for ; Fri, 22 Apr 2022 07:20:35 -0700 (PDT) Received: from [10.7.237.9] (54-240-197-225.amazon.com. [54.240.197.225]) by smtp.gmail.com with ESMTPSA id e16-20020a05600c2dd000b0038ed449cbdbsm4797770wmh.3.2022.04.22.07.20.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Apr 2022 07:20:34 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 5fdb62ad-c247-11ec-8fc2-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=A/5uHHMV3Nxa1gHYaQavSPtOYbqH+N+cJC47h3jGM3w=; b=phR4HF3xQ8IWOE0hn2lo9zSnsxQBBzSQA7lY1yyDEyWBFpXyiR1xP520CPatxlxfhm Vr/wQZdG3yXPRBxzTZ9DUfm6epxQ7X14n2HxnbNtx6X9Kiy5DI/uHZovbIwHH6aqcNCt cj56y037NoBPeSnRfQkW+v7Qei+ISgvWqnYC34c3bvhFgn2QYY3YCkrEuZ02JqbbK9ie h+IWBqJWh7Qn4FFF3Fh6Uwni0XnPQHjNrP+X6Kt0fVo9krmItRs/Iz+1ZNU12aHn4odV a0tutrmx+Hl5zOy9aSv5ABJwaceHzByJww9mxQBlxaMLO3/ieCPz4rg4ZfYVK0gc2E4A priQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=A/5uHHMV3Nxa1gHYaQavSPtOYbqH+N+cJC47h3jGM3w=; b=wxLJfLhSRHavOZZMQoIrnm0zZCW4JlmvvQ0P3jNG39nUVNKr6M4x0/AlOX2XgoSuLS dlWIJ+vpnNTNm97QEFmWQzfgnoV5SoukDKM0rWg/jAwv9P83W3PJF5LzTIDi2b++FV6+ d5mqBZrBJ7F4L4LkYrFEqZa5ILWNVe3EkgeIouywATUs35y0tH7UUe4xryfYLpitGwOD gHp896huvZ47f+tqFyKqQoWMpDbcnlQCk3P70iohD365VohmEhKf31XXkj+4Qw1NwKNe 3PJh7IpX5ItR6RWTW9MnFKkKLa6ki4hrPskInRvkzVFmkbJsIohug3h2mX4nWvPlZtap FqKQ== X-Gm-Message-State: AOAM533zGWEN8IvANMX/1wTFWnelG5Y3jmZ1B2knsxzkZlVsWDkol13D gFxno7IoZZEKSaNQv/xep/I= X-Google-Smtp-Source: ABdhPJx2hjyVGyoOB8tzNjKzd9CFbQEKBCXH+1H59SafjcDvmqdSimFkWPxVWA4LVBFWE2FXrD4tiQ== X-Received: by 2002:a5d:49c1:0:b0:20a:a65b:4648 with SMTP id t1-20020a5d49c1000000b0020aa65b4648mr3986036wrs.707.1650637234499; Fri, 22 Apr 2022 07:20:34 -0700 (PDT) Message-ID: <2dcc9b89-1deb-5ab4-6c13-05e72ccf89f3@gmail.com> Date: Fri, 22 Apr 2022 15:20:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Reply-To: paul@xen.org Subject: Re: XenVif div by zero on Tx path after resume. Content-Language: en-US To: Martin Harvey , "paul@xen.org" , "win-pv-devel@lists.xenproject.org" References: <55d61956-1a0c-c4e9-cb79-ff24c3433ad1@gmail.com> From: "Durrant, Paul" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 22/04/2022 15:17, Martin Harvey wrote: > > > -----Original Message----- > From: Durrant, Paul > Sent: 22 April 2022 15:13 > To: Martin Harvey ; paul@xen.org; win-pv-devel@lists.xenproject.org > Subject: Re: XenVif div by zero on Tx path after resume. > > >> ... and unfortunately it seems to have been broken for so long my git history won't tell me when :-( > > Oh dear. Possibly one of those "how did it ever work?" bugs. > > If you need testing resource / validation for any patches you'd like to throw my way, I do have a v. good set of automates test cases which will repro the bug (after about 12 hours of CPU grinding), and check that most obvious things aren't broken. > > IRQL is such a nightmare: You can get it wrong in one place and the subtly broken CPU state then dies in the next piece of code that needs some level of atomicity. > Probably won't get time to try a patch myself this week. I can take a stab next week though. Paul From win-pv-devel-bounces@lists.xenproject.org Fri Apr 22 14:41:35 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 22 Apr 2022 14:41:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.311005.527975 (Exim 4.92) (envelope-from ) id 1nhuTW-00077F-FP; Fri, 22 Apr 2022 14:41:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 311005.527975; Fri, 22 Apr 2022 14:41:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nhuTW-000778-Bc; Fri, 22 Apr 2022 14:41:34 +0000 Received: by outflank-mailman (input) for mailman id 311005; Fri, 22 Apr 2022 14:41:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nhuTV-000770-5g for win-pv-devel@lists.xenproject.org; Fri, 22 Apr 2022 14:41:33 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4adf8629-c24a-11ec-a405-831a346695d4; Fri, 22 Apr 2022 16:41:31 +0200 (CEST) Received: from mail-bn1nam07lp2041.outbound.protection.outlook.com (HELO NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 22 Apr 2022 10:41:26 -0400 Received: from MW4PR03MB6347.namprd03.prod.outlook.com (2603:10b6:303:11e::22) by MN2PR03MB4621.namprd03.prod.outlook.com (2603:10b6:208:a9::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Fri, 22 Apr 2022 14:41:25 +0000 Received: from MW4PR03MB6347.namprd03.prod.outlook.com ([fe80::e9f0:3774:1ce9:6059]) by MW4PR03MB6347.namprd03.prod.outlook.com ([fe80::e9f0:3774:1ce9:6059%9]) with mapi id 15.20.5186.015; Fri, 22 Apr 2022 14:41:25 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 4adf8629-c24a-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1650638491; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=NZTAGk03t+3S5A/YiWD/nWlT3Zck3tEATC3NsSzNkF8=; b=COBmPfI9lTLAhZfP/4u2CkI/QZHMlx/a07P9cREzQiphB+6VZNmGdNMB VqMEdRM9cI/ugEMKp8KFY9rQnMFP4UpUMyGtE/4Hu12uAGnvBX67bmbHF pFK4AeGglV8Ije1qj7YklJRD1/AYOfPYTZ53nuu12Rq4x5FE+tsq3SR2b g=; X-IronPort-RemoteIP: 104.47.51.41 X-IronPort-MID: 69727914 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:AMh4yqtOd9hBOBzVR79QDYcYO+fnVDVfMUV32f8akzHdYApBsoF/q tZmKW/VOvyNajP2eNEnad608RtUsJPRzdJlGQFl/HtjRXlE+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQyw4bVvqYy2YLjW1/X4 4uoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi95G4/CuuNMAyJZSS1fZfJ+37nFDEqG5Jn7I03uKxMAwt1IJWRuZ8gy3L8yBmtDs /sFNDoKcxaPwfqsx662QfVtgcJlK9T3OIQYuTdryjSx4fQOGMifBfmVo4IBmmtp7ixNNa+2i 84xbDN1cBXGJR1GIEkaGbo1nfuyh2m5eDpdwL6QjfRmvDKMnVUtuFTrGNv1dMWkZt4Fp2mdu U3Kz3TQHBpFM+XKnFJp9Vrp3IcjhxjTQIsPEJWo+/gsh0ecrkQMCRtTTUX+rfSnh0qWX9NEN 1dS6icotbI19kGgUp/6RRLQnZKflhsVWt4VGetj7giIkvXQ+1zBWjFCSSNdYts7ssNwXSYty lKCg9LuA3poraGRTnWesLyTqFteJBQoEIPLXgdcJSNt3jUpiNhbYs7nJjq7LJOIsw== IronPort-HdrOrdr: A9a23:k6JIFqxsBlawPWU0uS6aKrPxmOskLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBZpTnyAtj6fZq6z+8+3WBxB8boYOCCggeVxe5ZnO/fKlHbehEWs9QtrJ uIEJIOReEYb2IK6voSiTPQe7lP/DDEytHPuQ609QYPcegeUdAE0+4PMHf4LqQZfml7LKt8MK DZyttMpjKmd3hSRN+8HGM5U+/KoMCOvI76YDYdbiRXpzWmvHeN0vrXAhKY1hARX3dk2rE561 XIlAT/++GKr+y78BnBzGXehq4m1ucJi+EzRfBkuPJlaQkEuTzYJriJnIfy+QzdldvfqGrCVu O85yvIcf4DrE85NVvF2ycFkzOQrQrGrUWShWNwyEGT3fDRVXY0DdFMipledQac4008vMtk2K YOxG6BsYFLZCmw6hgVyuK4Iy2CrHDE1kbKUNRj/0B3QM8bcvtcvIYf9ERaHNMJGz/78pkuFK 1rANvH7PhbfFuGZzSB11MfiOCETzA2BFOLU0ICssua33xfm2141VIRwIgakm0b/JwwRpFY76 DPM7hulrtJUsgKBJgNTdspUI+yECjAUBjMOGWdLRDuE7wGIWvEr9rt7LA89IiRCek1JVsJ6e b8uX9jxBAPkhjVeLKzNbVwg2HwaXT4WyjxwcdD4JU8sqHgRdPQQF6+dGw= X-IronPort-AV: E=Sophos;i="5.90,282,1643691600"; d="scan'208";a="69727914" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=elv4AXpFKUHLu+b/5CVfvz3W7bb6HPMAa2/jvx5pOpDD01eRTZi0lJs3rs0dLue0dce++juXAmyeNv5rLj2ePE2Lgo3cstpul7+8X2cz+KGFkFSQZzEQBt28TP7YVVINVacqr2kLfPgLm+rHfZuOow+myGbk1WhncJBfYGnjRKhZihvdObz7qXczO774IPTojTLsjbFJDuWqSNMnvKmB8oWWXQgTQgC0sy7XprDa3ssCt4nTvYQVoA3Y2kBdYtBqIHFDqqx/nmquxlt4mOMsss70ehGKhbWpLrZlLn4kgxYxL175Mdn/b/A+7if9DZGdZJKMaOatu7YBDFwo7FPl1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NZTAGk03t+3S5A/YiWD/nWlT3Zck3tEATC3NsSzNkF8=; b=LEDU+hI9p/3mnqNMgpEl581Wd2ttCGcqulD28Bj7vV8BUGRUQn1iBdgLWa1AKl8caUn2m4zYjCZQGUV6FOB4GCRbl0vl/CdzvvsDyOLZGxO6HymqRJ9sczv2Z4ZFCASYx4IK0kNtu1EStBgWhR6+blJb3SVhwDVPtpIks/AsDpkBmaPs/84a/HiSI5+89dNBjavAD3x/9xhZhONEHnv67seLpm78O6kr8WUDzVsNb0a2rl6T5yScwPckmjs0BpeU/G8e9Zl36oWo6I7D40XQnaRtUROUz2MqY1PcnyageAnAUbGhxFLIQlOa6E0ep/eNMUl0d7OtMtyBIP92+nfjqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NZTAGk03t+3S5A/YiWD/nWlT3Zck3tEATC3NsSzNkF8=; b=gjf27YX1jPrP+98q0K3wqYufZZNildd+21ywPs5OgLyq3OWxK/y/0NXQbOnc7mIrTbc5B2YgV2ljSdUNG38G3C6nv1SF4bBCvOT38BHpschEl+ZyB4gTyQxLAqiGNSFwWViMHnZQk1+/GAMXd0Wg81Ci1ybIizR9Mcpd6VPXg4U= From: Martin Harvey To: "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Subject: RE: XenVif div by zero on Tx path after resume. Thread-Topic: XenVif div by zero on Tx path after resume. Thread-Index: AdhP6kAbDA19BbYtRECv6F4UUU/GxAD72daAAGmnvwAAAFp2cAAAUguAAC/5hJAAAFZNAAAAMhEAAANPABAAADUugAAAE7WQAAAwGAAAALYUkA== Date: Fri, 22 Apr 2022 14:41:25 +0000 Message-ID: References: <55d61956-1a0c-c4e9-cb79-ff24c3433ad1@gmail.com> <2dcc9b89-1deb-5ab4-6c13-05e72ccf89f3@gmail.com> In-Reply-To: <2dcc9b89-1deb-5ab4-6c13-05e72ccf89f3@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4464aabf-64fb-4059-d5b1-08da246e2d4d x-ms-traffictypediagnostic: MN2PR03MB4621:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: U0S1wUTPQL7Yksw06o9jEtx3Q4yPWGG3rYXffR16+YeIzDH3/iQDJBRD2A9FSZmhvaDUdhqzqrrHYqQcglBGUNU773UgQxhp5HA0nSfDUiqXv1n4Lizl7gI+OuVmHiMVZCwfL489Bdkw8jA2seWkAFIc+NThsT+xFqiY7vHGz/N6VDbxCELspZ/9obHdQ3PTMRTP8s539BXfbN974DSD0CM3DS6aXOh/2CNOsWygRchKwfgHVwwTxyXzlHXV8AlfdWXEAQB1eZbTOmKBSl98Uc4uroW7dtRTNnsP+lu8PYrSYtQPJUhVhJQwhnNC17UXouDVxKt4q884Eg7QDBRc7u0I+5H2sf35luran7sOjKmPV5jm6Tq33UdShbkmAkKLMqMWWQMw94DzL9OEFNj8SqJDGtZD9lRHk2BQvPzLreH9zIxG0PAbj8ZkqiNCtW8EDRuHkglX1GfuGvDh2NVgG+PXIEer7OKM3O79GXVQHIZ96ZZ9Ga1zvipzl9G6xzblx3pnNBWUkMxiLuBYDof1BYdSWSpA1SgOriq0LZ+dBKM3H65foP/xIlcc4h0glMvtCXWBd0hTJuL+E/OPbxpnXh5lBpT3FqXhEb6j2jPEtRCmVdqjo2/IfcvenkTCGs3TfmyHqFSdgr1/lVzpLY+6Xm/KoYAN4T5RfgGEGUgqyIcmL2hli/EQsEVaLGPyZQxXBHIzeSh3sZLcv91mWQKl5A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6347.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(52536014)(6506007)(9686003)(66556008)(76116006)(33656002)(38070700005)(316002)(66476007)(71200400001)(66946007)(26005)(66446008)(8936002)(86362001)(5660300002)(4744005)(44832011)(55016003)(508600001)(64756008)(8676002)(7696005)(2906002)(53546011)(110136005)(186003)(83380400001)(82960400001)(38100700002)(122000001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?anhuZUNUcUFsMkp6KzFEeGNHZ1pSUVhiU3RoM1h2SUNpdWd0cTY0eDBjZHcw?= =?utf-8?B?c1RzY0Y0c1RnaEtjL1FNTmlXRnVSSTBGTXRhZXhteXBIQ1ZaZk1XRUUvT01Q?= =?utf-8?B?bFJFQWVQSHB4OGtDWU5nOW1uakRBZXhaYmNCcy9KTVFiVytTRk9JMWw2Qi9y?= =?utf-8?B?Vnl6b1JSaGlZUGZndFZlZXJ1MHJTb2hKcFBPeDgxS2M1QUxrRzNZRlVOd3Aw?= =?utf-8?B?dG5lNG4ySmhvalBhTjRNR29LOVNEbDEzMXVNbEZ1OHFhTys5TW05WkU5ektI?= =?utf-8?B?azIrQlF4ZnF4MUxaYmZzNEpVb3EzMS9USkZyUDFvNkJ2cWhTOW9DMmI4RWNz?= =?utf-8?B?NXpEL3Y3d0c3UzErV3RPczcxaUVIVkhxWi9tbXppRzduK2VKVmJJUUx0WGZt?= =?utf-8?B?d2xPVk5JSzFFUFp3ckNwOTRGc1hURWk1SUtDM21ySWRPdkUraFBFZEVyeDF3?= =?utf-8?B?ZkZQMlZSbVdaNUhQak8xUEloR1oreXpLajRUdlNSQ3ZWSWRHbW9vSi9VSGw0?= =?utf-8?B?VldPZkpSQ2hObEhMbnJteEZDWC9YaVN6QW9qOTJ4NDVURzF4WGlSQU0yY0NW?= =?utf-8?B?WW03ZnQyQm5hZnZUYWc0QWpWb2lTaHllL0JOSEtNTEFDQitHYzFSUk9JZlZK?= =?utf-8?B?NXFLYlllRkRQQWxOWitiZmxiS256MWcyL2RYSHVYUDhrNFdlYmp4UWJVWHU1?= =?utf-8?B?dzNCTS9UVnZaUmtQTDZqQm44YlN2aEdvUnRYdEMyOGV0cHhHOHVsYTljSUti?= =?utf-8?B?Tml4bGpNNzJuZGQ4TXZ1ejZtNm9HdUpGd0JUMUR6VlU5dlR1c1BCUjdsRWxB?= =?utf-8?B?Ulkvc0lOaUtnR3JDcC9oVUlMSFNzODZ0NlJtcnFCbzFpK2doUWtUTW9vTFFM?= =?utf-8?B?V3lPajgrK3RWMmwyTncrM3czL3dGUGVpMDJ6UEdBdXc2NU04VCtWM0VnZWFM?= =?utf-8?B?WTdkSU03Z2xsQ1JIaktuYjFYdmgyRkw4QWNNY1JwdVArRXU3TTgyb3lXNlZx?= =?utf-8?B?SWk0bm9uTEN5dW4zTkYvWS9tNWtQZWE3MEIwNjkxY3lRQ0pRcDl2d1liM25s?= =?utf-8?B?b3hHWU9xRHFyUm5pRjVOTEM2YzlZK1ZQRmxGdFdJRDU5Rzh5YnU2VWF4TzBy?= =?utf-8?B?Q1JzbkNjOUJOUEJzd3k3MGxOT1R3dE9MdXJCM2pTejVEZ1V3MEtVSEQ4dWQx?= =?utf-8?B?VG1YUXdPcHZtR2Y1L3lCVXRJT2hUWmVCcDZkamdlVlVManJxVllsSm9xYU1a?= =?utf-8?B?eFUveWREZ2M1TUZBa3o3dTgwYktxZ3AzZ3h2eU0rZk16aVVBV2JnbUNSb3l0?= =?utf-8?B?anpSTUNPNW9xVzY0RmlReUZOSWJOUmd0d1BVRitGTG9RTFp5bm8vaXZBTEdL?= =?utf-8?B?ZEVlZmpmUjF2NERnVkErenhkdHJLV2dxZS9jTXFvTURaOTZYYVI3V0Z2Z0FJ?= =?utf-8?B?TnRoR1V3YlpCK3lST2RsSU42dFpTOVl2UjJsN3BoWFh3TnA4ck80SGd5eGJk?= =?utf-8?B?b3ZRWkhZKzNlWkl2aXAzUitNd1Q4NGNNRnRpNCs0ZVlxSnlMcWw3NkFDejU0?= =?utf-8?B?MFd0YkE0UzA4OCtxNzFMeW5Vem1UeStGa1RwbWI5eGE3L1ZZbWJPM2JTSlFn?= =?utf-8?B?R2ZsNGNQb2UwUmFKSCtpajF0TG5zRHNyWjZPd0pEU0paYzd0NW5hZ0NSSzUx?= =?utf-8?B?RnBNWm1sWkFYKzVHdnRaUVBnSkczOWErQ1k0MGY4UEpWWGNsVzVNbHhFcG5H?= =?utf-8?B?a0tQb09EWnFGTWdmZ2FwMkZJRW9NWndyMS81SThHRWJ5eXkwanlPcWg1VCs1?= =?utf-8?B?Rks3T3FKSkdncFVac0Jmc2N0VFM4bGdWVWRTYjRQdDlrUlpNRUdSU1hBbytE?= =?utf-8?B?TytHOUQyQTNuZVdZSDFpSWNJajVGRnhQUE9CbW9SWGZaVWY5N3VVYUNRMW5P?= =?utf-8?B?N0RhZWtwcHlLNzVaR0NGL2ptTVpMRzYrNFRrSzVkSHNKN2Z2dEo5Q1p5akgy?= =?utf-8?B?NmtUUjkrRlBwR2dETUEwUFJORlRPcVV1dDlFdThFb0hHSXBzdWY2aDQzZ2Mz?= =?utf-8?B?Qyt3dStPTnZ3SWZBQmJGTTFySktQSXVwQThtRkdlUFFudG5DNHFGQ2VuNW0y?= =?utf-8?B?bUtoTlBTZld1a2pYTHhyWkZFSTg4SnhydTRzNy82S2VmR3poV2pmWVFybzh1?= =?utf-8?B?UlZtVXVWMllvbHZlMFVFVjdvNW12MkFyMGJ6QXdja0ExSGZDNXZiQ2Vna0Y0?= =?utf-8?B?cGx6aUs4WTBEbVUzbzlQaG9XM1d4TGpxdUd1b3dJNDl6bEFRU1pHc1JQV3FY?= =?utf-8?B?SWxHcmdNVnI2Q0duUlplSHpiZW55Y3NJNzBPak81ZDVLMlZTQlowOFU5Wktw?= =?utf-8?Q?k+19kU6F5BMI69RU=3D?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6347.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4464aabf-64fb-4059-d5b1-08da246e2d4d X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2022 14:41:25.1268 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rpV0Y55fvEHzidNvVRaXHTAhpb5JN3GsrnnLoGiSnUVxisQboN0mcu+Op9AHiEyHl8zg8jZrdo75amxze1lNMYtIrz/hEREaMZ6/Gv3m5GM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4621 DQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBEdXJyYW50LCBQYXVsIDx4YWRp bWduaWtAZ21haWwuY29tPiANClNlbnQ6IDIyIEFwcmlsIDIwMjIgMTU6MjENClRvOiBNYXJ0aW4g SGFydmV5IDxtYXJ0aW4uaGFydmV5QGNpdHJpeC5jb20+OyBwYXVsQHhlbi5vcmc7IHdpbi1wdi1k ZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KU3ViamVjdDogUmU6IFhlblZpZiBkaXYgYnkgemVy byBvbiBUeCBwYXRoIGFmdGVyIHJlc3VtZS4NCg0KDQo+IFByb2JhYmx5IHdvbid0IGdldCB0aW1l IHRvIHRyeSBhIHBhdGNoIG15c2VsZiB0aGlzIHdlZWsuIEkgY2FuIHRha2UgYSBzdGFiIG5leHQg d2VlayB0aG91Z2guDQoNCkZpbmUuIEknbGwgdGFrZSB0aGUgdGltZSB0byBhY3F1YWludCBteXNl bGYgd2l0aCB0aGUgc3luYyBjb2RlLg0KDQpNSC4NCg== From win-pv-devel-bounces@lists.xenproject.org Mon Apr 25 08:31:02 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 25 Apr 2022 08:31:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.312482.529738 (Exim 4.92) (envelope-from ) id 1niu7Z-0004xH-Cn; Mon, 25 Apr 2022 08:31:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 312482.529738; Mon, 25 Apr 2022 08:31:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1niu7Z-0004xA-9X; Mon, 25 Apr 2022 08:31:01 +0000 Received: by outflank-mailman (input) for mailman id 312482; Mon, 25 Apr 2022 08:30:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1niu7X-0004of-Gc for win-pv-devel@lists.xenproject.org; Mon, 25 Apr 2022 08:30:59 +0000 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [2a00:1450:4864:20::32c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 07dc03e5-c472-11ec-8fc2-03012f2f19d4; Mon, 25 Apr 2022 10:30:58 +0200 (CEST) Received: by mail-wm1-x32c.google.com with SMTP id m22-20020a05600c3b1600b00393ed50777aso759555wms.3 for ; Mon, 25 Apr 2022 01:30:58 -0700 (PDT) Received: from [10.7.237.11] (54-240-197-227.amazon.com. [54.240.197.227]) by smtp.gmail.com with ESMTPSA id f14-20020a0560001a8e00b0020aaf034e59sm10231971wry.90.2022.04.25.01.30.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Apr 2022 01:30:56 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 07dc03e5-c472-11ec-8fc2-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=NTzKyPx7VZtalHTbjSb1zoFmu+xxSgzKTBo7uXBA80Q=; b=XQhehgJzkLB9c+uc2371/ZaTTUzbOyKthDD2QbhRK3QLV5SdRSVi48Fv/2KDFWa5GC g8aqrvlYhL+95TDk6kJ0MYU+tQJyhMxwH2UindUzaDlqOyxI/zy/tTVx8T1kLYyh2fsj FRoxgEpuOYhQ2/FJL3AxhSJ02X0gxF83p3zhm9zcTv31TPLN13oxU7Ans0nUgVUVuXy1 xPDM6JrjaKExFo9PRHsh+AnjJgNa1PW6PumxenbtV60JGyt20MW7pPopJFxyM0//19Qi +chQsO74h+kzX+ZJo0n7oe0Ad44srvBT4cckrmK8KFLmvirjzRDujv8dzGAhtArD+Vtr 0H/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=NTzKyPx7VZtalHTbjSb1zoFmu+xxSgzKTBo7uXBA80Q=; b=lFzy95KXCIzUbETl88mDVWhsOlK0hIZKfoC7H4y8yb9gPJRWWhigAzDnKkc1KaeKFx EtFDNwYf86DXSAyO7Jzu3i++xSknPHVtV6RhPdNw57+LOtw4cSW40dhyK7iPXfgiu0PW rtYpQeUVvSye7CPQ/yxe7AEaYRUQEklea8najS57qLxU5VKMDLObcHjlkL9Gwq7MhMi4 XDdkV+njvv1HAH87yEM2uz+ebP7eXDnoNUtQmVKrmOJBwVtZHkrOfC6pPOanDgQ613Zl SNOrPJFZM2zdEw+K6YbXryO5mBIIlUC1UsuC5J2Q0uLa+Ye0h4yG6HpXJ5wn8UYwR0aQ ICJw== X-Gm-Message-State: AOAM531O/rHq7Jaj4LujW2jaVQc3DTkwOHHjAQGgOkx5f50V+K6xo30P Q36v02GYPYt//fzu1I3/VgwXYhNcUgQ= X-Google-Smtp-Source: ABdhPJwg50xE3XwWClqK+ZVRyk9os+C21Y5m1D29if75LxqMWJOyYPvfph/1hdMunalpgk2Z3PprXg== X-Received: by 2002:a05:600c:4e11:b0:38f:fbc7:2bc4 with SMTP id b17-20020a05600c4e1100b0038ffbc72bc4mr15640073wmq.141.1650875457580; Mon, 25 Apr 2022 01:30:57 -0700 (PDT) Message-ID: <99acbca5-be7e-9ae3-514c-62d8d492861a@gmail.com> Date: Mon, 25 Apr 2022 09:30:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Reply-To: paul@xen.org Subject: Re: [PATCH] Reduce log spam Content-Language: en-US To: win-pv-devel@lists.xenproject.org References: <20220421122945.371-1-owen.smith@citrix.com> From: "Durrant, Paul" In-Reply-To: <20220421122945.371-1-owen.smith@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 21/04/2022 13:29, Owen Smith wrote: > Squash errors generated by IoctlDirectory returning no sub-paths > Reduce logging level in ThreadCreate > > Signed-off-by: Owen Smith Acked-by: Paul Durrant > --- > src/xeniface/ioctl_store.c | 25 +++++++++++++++++-------- > src/xeniface/thread.c | 2 +- > 2 files changed, 18 insertions(+), 9 deletions(-) > > diff --git a/src/xeniface/ioctl_store.c b/src/xeniface/ioctl_store.c > index 9116e82..97062df 100644 > --- a/src/xeniface/ioctl_store.c > +++ b/src/xeniface/ioctl_store.c > @@ -218,6 +218,7 @@ IoctlStoreDirectory( > PCHAR Value; > ULONG Length; > ULONG Count; > + BOOLEAN SquashError = FALSE; > > status = STATUS_INVALID_BUFFER_SIZE; > if (InLen == 0) > @@ -228,14 +229,17 @@ IoctlStoreDirectory( > goto fail2; > > status = XENBUS_STORE(Directory, &Fdo->StoreInterface, NULL, NULL, Buffer, &Value); > - if (!NT_SUCCESS(status)) > + if (!NT_SUCCESS(status)) { > + if (status == STATUS_OBJECT_NAME_NOT_FOUND) > + SquashError = TRUE; > goto fail3; > + } > > Length = __MultiSzLen(Value, &Count) + 1; > > status = STATUS_BUFFER_OVERFLOW; > if (OutLen == 0) { > - Trace("(\"%s\")=(%d)(%d)\n", Buffer, Length, Count); > + Trace("(\"%s\")=(%d bytes)(%d items)\n", Buffer, Length, Count); > goto done; > } > > @@ -243,7 +247,7 @@ IoctlStoreDirectory( > if (OutLen < Length) > goto fail4; > > - Info("(\"%s\")=(%d)(%d)\n", Buffer, Length, Count); > + Trace("(\"%s\")=(%d bytes)(%d items)\n", Buffer, Length, Count); > #if DBG > __DisplayMultiSz(Value); > #endif > @@ -262,11 +266,14 @@ fail4: > Error("Fail4 (\"%s\")=(%d < %d)\n", Buffer, OutLen, Length); > XENBUS_STORE(Free, &Fdo->StoreInterface, Value); > fail3: > - Error("Fail3 (\"%s\")\n", Buffer); > + if (!SquashError) > + Error("Fail3 (\"%s\")\n", Buffer); > fail2: > - Error("Fail2\n"); > + if (!SquashError) > + Error("Fail2\n"); > fail1: > - Error("Fail1 (%08x)\n", status); > + if (!SquashError) > + Error("Fail1 (%08x)\n", status); > return status; > } > > @@ -310,7 +317,7 @@ PXENBUS_STORE_PERMISSION > __ConvertPermissions( > __in ULONG NumberPermissions, > __in PXENIFACE_STORE_PERMISSION XenifacePermissions > -) > + ) > { > PXENBUS_STORE_PERMISSION XenbusPermissions; > ULONG Index; > @@ -411,7 +418,9 @@ IoctlStoreSetPermissions( > > for (Index = 0; Index < In->NumberPermissions; Index++) { > Trace("> %lu: Domain %d, Mask 0x%x\n", > - Index, Permissions[Index].Domain, Permissions[Index].Mask); > + Index, > + Permissions[Index].Domain, > + Permissions[Index].Mask); > } > > status = XENBUS_STORE(PermissionsSet, > diff --git a/src/xeniface/thread.c b/src/xeniface/thread.c > index 4a5d425..4d767a0 100644 > --- a/src/xeniface/thread.c > +++ b/src/xeniface/thread.c > @@ -130,7 +130,7 @@ ThreadCreate( > > (*Thread) = __ThreadAllocate(sizeof (XENIFACE_THREAD)); > > - Warning("Create thread %p %p\n", Function, Thread); > + Trace("Create thread %p %p\n", Function, Thread); > > status = STATUS_NO_MEMORY; > if (*Thread == NULL) From win-pv-devel-bounces@lists.xenproject.org Mon Apr 25 09:15:11 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 25 Apr 2022 09:15:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.312642.529995 (Exim 4.92) (envelope-from ) id 1niuoJ-0006Om-IT; Mon, 25 Apr 2022 09:15:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 312642.529995; Mon, 25 Apr 2022 09:15:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1niuoJ-0006Of-FC; Mon, 25 Apr 2022 09:15:11 +0000 Received: by outflank-mailman (input) for mailman id 312642; Mon, 25 Apr 2022 09:15:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1niuoH-00062O-TJ for win-pv-devel@lists.xenproject.org; Mon, 25 Apr 2022 09:15:10 +0000 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [2a00:1450:4864:20::331]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 33a780bd-c478-11ec-a405-831a346695d4; Mon, 25 Apr 2022 11:15:09 +0200 (CEST) Received: by mail-wm1-x331.google.com with SMTP id x3so8842484wmj.5 for ; Mon, 25 Apr 2022 02:15:08 -0700 (PDT) Received: from [10.7.237.11] (54-240-197-227.amazon.com. [54.240.197.227]) by smtp.gmail.com with ESMTPSA id w5-20020a7bc105000000b0038eb9932dacsm8065881wmi.48.2022.04.25.02.15.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Apr 2022 02:15:07 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 33a780bd-c478-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=gcr5N971CxRU83WQuNmFFPOTdQuvXK/71jvebRI8Jis=; b=LuPdn1T5pBIxU0u2vJGsnxtlY2BWJGMZ8LVubM5OCCl5tJtkUu2HWd7xCV5fl90czf n4RLnsHSPCy+hMJZIehhPAPyCo18HuLmVlLnSDkDNnTssgD+iUxi/86vktOHXox4mpNo 3fv/AffiD0zMKAO+ksgN/t77JSID+1L/1Zoj2sbpSaa/FKh7niC9bGohilycf0M6Wyi7 I530kfcH2lgiAdha54CveoFHQtw6dEaM512e88ueNS08IHQfxNcpm3U/efbPmUG+Mu6H k+2zVE65J7ZJPvGIiEQRU88AU5GK329m8Z4w3VXatm1ebneXi6QcWqiYYc1upPi/tnka GZFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=gcr5N971CxRU83WQuNmFFPOTdQuvXK/71jvebRI8Jis=; b=KaVKKxKJJB2ni0Nvho5YFviYHsEppL2PkUaiMYmgFhE/ooA1obEEaQq8qH8GvHGKFo hdRRRJd1ixBtDr5/J69+msVFlTJ9nYr6GoZ12kI8OS/n5sOUeLsa3n9ih7jv4DnRRUjZ WFIMB+bfWVG3PbOKbJbXZW3MOpqfv2EpRo7kFYrbkJ2tB9+a3jjd1TW6neLhfP0gOAF/ FA3TedVteoq3Anu8RdeCoV7CX/mk7RTgOcxfAUayg1Ei7/43fRWyLroAKGPPejHyrJYI X6sOZCgZ4Ngz6/KHQcs15KHLxPugcVYuyHQZZXva+WBa0q5QVn73CPvuNNnI4NeRgP+e ZoNA== X-Gm-Message-State: AOAM5304qMIwjhg8or6QQPbX00pMPwaMbkm4FMwmc09wVgM8aHxf3R05 9MSmYwj3oe1r1feYEiPQ7BE= X-Google-Smtp-Source: ABdhPJyHHsV/uecQkotRzI5bCQ4eh9dc7HbQzzQP3Vml1U4ifaoX2jHpcSoRqK5QHnO+VGm6Qiwz5Q== X-Received: by 2002:a7b:c384:0:b0:38e:6b47:58c4 with SMTP id s4-20020a7bc384000000b0038e6b4758c4mr24810486wmj.134.1650878108080; Mon, 25 Apr 2022 02:15:08 -0700 (PDT) Message-ID: Date: Mon, 25 Apr 2022 10:15:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Reply-To: paul@xen.org Subject: Re: XenVif div by zero on Tx path after resume. Content-Language: en-US To: Martin Harvey , "paul@xen.org" , "win-pv-devel@lists.xenproject.org" References: <55d61956-1a0c-c4e9-cb79-ff24c3433ad1@gmail.com> From: "Durrant, Paul" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 22/04/2022 15:17, Martin Harvey wrote: > > > -----Original Message----- > From: Durrant, Paul > Sent: 22 April 2022 15:13 > To: Martin Harvey ; paul@xen.org; win-pv-devel@lists.xenproject.org > Subject: Re: XenVif div by zero on Tx path after resume. > > >> ... and unfortunately it seems to have been broken for so long my git history won't tell me when :-( > > Oh dear. Possibly one of those "how did it ever work?" bugs. > > If you need testing resource / validation for any patches you'd like to throw my way, I do have a v. good set of automates test cases which will repro the bug (after about 12 hours of CPU grinding), and check that most obvious things aren't broken. > > IRQL is such a nightmare: You can get it wrong in one place and the subtly broken CPU state then dies in the next piece of code that needs some level of atomicity. > OK, it was my misremembering of KeLowerIrql() semantics. The code looks to be doing the right thing. SuspendTrigger() raises to DISPATCH. It then calls SyncCapture() which schedules a DPC on all other processors which spins. It then calls SyncDisableInterrupts() which instructs the worker DPCs to raise to HIGH, and then raises the current CPU to HIGH. There is a slightly subtle loop with a back-off to DISPATCH that waits for all CPUs to get to HIGH. The back-off is needed in case of mutual IPI. Once every CPU is at HIGH, they all disable interrupts. Now the SCHEDOP is done to either suspend or migrate. When this returns we are resuming. There is a slight subtlety here. The SCHEDOP may 'fail', which means we are doing a 'fast resume'. A fast resume is done on the source host. This means all backends are still there and thus we do not need to run the suspend callbacks. SuspendTrigger() now calls SyncEnableInterrupts(). This runs the 'early' suspend callbacks on each CPU and drops all the CPUs back to DISPATCH. Hence interrupts are now possible, but normal threads are still prevented from being scheduled. It then calls SyncRelease(). This runs the 'late' suspend callbacks and terminates the DPCs on other CPUs, thus allowing threads to be scheduled. It then lowers IRQL on the current CPU, which should mean a fall back to PASSIVE as SuspendTrigger() is only ever called from the dedicated thread (running FdoSuspend()). So, there should be no way a thread can run before all 'late' callbacks have run unless there is a kernel call being made at the wrong IRQL or we need extra barriering. Hopefully the former could be caught in verifier. Paul From win-pv-devel-bounces@lists.xenproject.org Mon Apr 25 09:20:51 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 25 Apr 2022 09:20:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.312654.529999 (Exim 4.92) (envelope-from ) id 1niutm-0007W8-Vs; Mon, 25 Apr 2022 09:20:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 312654.529999; Mon, 25 Apr 2022 09:20:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1niutm-0007W1-Si; Mon, 25 Apr 2022 09:20:50 +0000 Received: by outflank-mailman (input) for mailman id 312654; Mon, 25 Apr 2022 09:20:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1niutl-0007Vv-JI for win-pv-devel@lists.xenproject.org; Mon, 25 Apr 2022 09:20:49 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fc75b18a-c478-11ec-a405-831a346695d4; Mon, 25 Apr 2022 11:20:47 +0200 (CEST) Received: from mail-mw2nam08lp2172.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 25 Apr 2022 05:20:44 -0400 Received: from MW4PR03MB6347.namprd03.prod.outlook.com (2603:10b6:303:11e::22) by CO1PR03MB5748.namprd03.prod.outlook.com (2603:10b6:303:6d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Mon, 25 Apr 2022 09:20:43 +0000 Received: from MW4PR03MB6347.namprd03.prod.outlook.com ([fe80::e9f0:3774:1ce9:6059]) by MW4PR03MB6347.namprd03.prod.outlook.com ([fe80::e9f0:3774:1ce9:6059%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022 09:20:43 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: fc75b18a-c478-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1650878447; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=TK5kC0ei9wDaXYgCrow8G841V7Mru+/gWz4bMu/RTo4=; b=UX9Kmb1Igdke/+DyhJwqGWiRQ4a6G8B+8ZFCytyVPCth1L61f5W42P72 oTQKLfhqSweKdafjK01qp5kNmr9xwjXimIJbmiuV0SSHhnjhxsNvG7AOg kvPb1QzIWGTnAziTvCdlzPOwl++kARcJNJ3RUdlgk7LM4728CX+JpA9sT M=; X-IronPort-RemoteIP: 104.47.73.172 X-IronPort-MID: 69859657 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ybCh86g+uqn0RrXtPSUHAtKxX161AhEKZh0ujC45NGQN5FlHY01je htvWj2ObveOZmX2eIsjYdi/8UtVsZKDmtBnG1RqriEwESsb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1nR4 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YQsSE7SSnKdBaj97KjtPDY5J+Y/kA3fq5KR/z2WeG5ft69NHKRlqeKgnoKNwC2wI8 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuoQehWhq7ixNNa+2i 84xbDN1cBXGJR1GIEkaGbo1nfuyh2m5eDpdwL6QjfRmszWCklEuuFTrGPzvS86AesBrpBfCl lv0+lTUXgM6HsPKnFJp9Vrp3IcjhxjTQIsPEJWo+/gsh0ecrkQMCRtTTUX+rfSnh0qWX9NEN 1dS6icotbI19kGgUp/6RRLQnZKflhsVWt4VFvJg7giIkvrQ+1zAWTJCSSNdYts7ssNwXSYty lKCg9LuA3poraGRTnWesLyTqFteJBQoEIPLXgdcJSNt3jUpiN1bYs7nJjq7LJOIsw== IronPort-HdrOrdr: A9a23:0QNCGqmnFaI1e87jKpuQ0YpucxvpDfOYimdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIi7SdG9qADnhOVICO4qTP2ftWjdySCVxeRZgbcKrAeQfxEWmtQ96U 4kSdkGNDSSNyk2sS+Z2njeLz9I+rDun86VbKXlvhFQpGpRGsJdBnJCe2Om+zpNNWt77PQCdK a0145inX6NaH4XZsO0Cj0uRO7YveDGk5rgfFovGwMnwBPmt0Lm1JfKVzyjmjsOWTJGxrkvtU LflRbi26mlu/anjjfBym7o6YhMkteJ8KoMOCXMsLlVFtzfsHfqWG1TYczBgNnzmpDr1L8eqq iNn/7nBbU215qeRBDznfKn4Xib7N9n0Q6e9bbfuwqunSWxfkNHN+NRwY1eaRfX8EwmoZV117 9KxXuQs95NAQrHhzmV3am/a/hGrDvBnZMZq59ls5Wfa/pvVJZB6YgEuE9FGpYJGyz3rIghDe l1FcnZoPJba0mTYXzVtnRmhIXEZAV6Ij6WBkwZ/sCF2Tlfm350i0Me2cwEh38FsJYwUYNN6e jIOrlh0LtOUsgVZ6RgA/ppe7r/NkXdBRbXdG6CK1XuE68Kf3rLtp7s+b0woPqnfZQZpaFC7a gpkGkox1LaV3ied/Fmhqc7jSwlaF/NLAjF24VZ+4VzvKH6Sf7iLTCDIWpe4Pednw== X-IronPort-AV: E=Sophos;i="5.90,287,1643691600"; d="scan'208";a="69859657" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WoRttRwrlcXXis9nEcqG8tbwKSTMU7mIg2Fq9gPVpFCTMCAuTLhVcB2767WUTRqIv0qbzCy6bYyPECNHl2sKMgPpTUr6c5j+9l3Yb314znxgXCJw1UufHtcoXeaKe2e3DnG55D6XFCy281LL+H+fNWY9oWd6JeynBKVMeli5Cb6AVoFR8tl1q0iA0Gy3lE84MVw37E3tozn5vCYfprvNlmJ5471GwhSTcXkJcWM6/XSSTbp5VF5OnR96qXMo5fE6mLoZF/hSCw4gL6GDWUpYJn9ZTdaxkrTTHz7ZpO5f+jEvBbhlgVEpT/Sjd2f2nUPIIxKVXdUEjpTK8qoj/ji6bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TK5kC0ei9wDaXYgCrow8G841V7Mru+/gWz4bMu/RTo4=; b=cTSeaRvq5BnzGyzAW2dpHxUFnJlMXJDNwrBSTuWCzcVgrWzycup31H+gzvZPmHhxdLAncqdXLcyPOjnGhtrdWFagQvcji9HDy9Wj/770OqAB8pSzBAWfOz6IjzKD/MMUTikhQRImpNvSgBjirR+fAWnXH6wId5vN1LdPO6jq+2sih5x8WjU+AOhg4jHGd2xiJUSJMVV4qVSA9cUng0hQYXEdVfiZhOBkvHeyossHRQmpikX4rzCWTk+JXFq0dNYWmSPirPT1XUzBZa0u7ryb0vhoefYFmoWY/t0APnc5QzmUCVQ3QWwbssf2m9IWZ3CiGtcm0i+VrePdYrm0QbPmfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TK5kC0ei9wDaXYgCrow8G841V7Mru+/gWz4bMu/RTo4=; b=m77NamXLybIeJdUUsWQOnsLeD/2gsI5tWzUEI9Llm58JeSjfqHV4qsU0jEDM6b/HnAt0SF9hIGqSeoetENZVauY91CuxaDZkALAEgpo7LVYVMTxIRIGi7VsvkCXQ/43T3ppCfBXf5QNKJTWiiVfimRvuZLNFlL0BBOyOgiFQfIY= From: Martin Harvey To: "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Subject: RE: XenVif div by zero on Tx path after resume. Thread-Topic: XenVif div by zero on Tx path after resume. Thread-Index: AdhP6kAbDA19BbYtRECv6F4UUU/GxAD72daAAGmnvwAAAFp2cAAAUguAAC/5hJAAAFZNAAAAMhEAAANPABAAADUugAAAE7WQAIxlHgAAAC0xkA== Date: Mon, 25 Apr 2022 09:20:43 +0000 Message-ID: References: <55d61956-1a0c-c4e9-cb79-ff24c3433ad1@gmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9eaf493c-337a-461d-63e8-08da269cdf7d x-ms-traffictypediagnostic: CO1PR03MB5748:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DKXuB55U+Aqf992RNIA6jKamSytGooa9s4PtoGHhWXqLtJji+BmB1XsDdfeBgye51mslBY6DBOB1SO+gBJJ0dSEEY5+qu0i7pvTffqPIBh5l/0TAA7NdcdBDo6g+tbBhnxqCqBYNbLJs86b5bWCLF2M0VrJZ4I7VbuUk7w+kCriOtiMjdeyS2HCV1VWsrvNdyjz2v9W6rM6Ip4/cUP8FqwB8hmRHwHqgoowttIY668fLfx1qLvkoRFVhHLbdWQDK3M66/3xjnd9bJlpbecYtTAPsbxrlq/VQk7BMkxyONb3bTtp2xIxJKOQ1en648/zDmQjA6O7i6x1etbK20eP782oW14YlB+iMYGWPje2Q10cKFC153KJ1ZiA9U5fFNlO4aNUUSwnHi4md6QWMQI0Ny/AlhWlMdLCle6oaXtEjVC/FoeN2VETw49kYbvJCa5tdJNn7S3L7m9cySL3FioOjbEQVOkHEfjrgmllKHYL3k5furHVq22VGEJ5LsbzS8N1nGoX3EgATm4ZJpkeZPUC1aCpITK0OW0AoySBrAuiUT4CqTBaCdMuS9YCRpQYB5ccIXVIn23AuNNeCyFl3lzspboXZmqtKIo5ZZ/7H8/cJ1yr/3MzIXX2gdiCKWJVJU2dqyacGvl5NyZrfJfU8iZ3m64h6rqDyCGE7U6N7994uWkjdovO4JIV9y4PL2XycdJaYMOwMeJ4Bk3LlMS1huxfQwA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6347.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(53546011)(26005)(7696005)(508600001)(6506007)(66556008)(2906002)(4744005)(5660300002)(44832011)(55016003)(52536014)(33656002)(8936002)(38070700005)(38100700002)(66946007)(66476007)(66446008)(82960400001)(8676002)(76116006)(64756008)(83380400001)(122000001)(71200400001)(186003)(9686003)(110136005)(86362001)(316002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?elAwMnlkdU9SRUxWNE1rSE51cEJ2aitpQVp4c0pJc0g0eEFQbERXb25LOStk?= =?utf-8?B?eWRZRW4vNGFwd1JsdWlRak4xcWw5a2Z1UGFpZ1ZoM1d0K1ppMTJ5UWc5UUd6?= =?utf-8?B?QTVYWmg0L0MvWDI5QmY3aWZWeUlOYWdIV3c1ZnJFMjJVZzFQNUFCSUhuMTVl?= =?utf-8?B?ZFpyUFM1UzlIZWVLYW9OWHQ4SVhxWTZwTFA1YW94N0srWGNsOTVFOFhBU25x?= =?utf-8?B?Q1VOZjhVQm5NZGZqUzk1clFRODU0a3RMMmtyQUd1MHBvMUp2OTdEVitqRWZ6?= =?utf-8?B?eStOcTMzRzFaTXJvaC9OMmtJSXI1TWFDUWVGMWZDeUhPUVB2Vy9XWHdPZDYr?= =?utf-8?B?ZkJZbnpERy80b3FFcVRvalBtRDlJNmpNNGNocTlVNjc4WkFqNDNzWk5nWVRK?= =?utf-8?B?QU1iQ3JXYXFoL25STWNNL2hKMXRpZ01NT0tVZkhCbnRtQmNlZUo3OTRXZUhy?= =?utf-8?B?SmNOVlJ0UkZQazBuWFVVMWszUW8xTng2UkFoeFZENmJQK0ZsTzNFQjduS0pj?= =?utf-8?B?RXo3TldjL0wyeE5CRVpGVmRMSmQrTU52eXlZRnVqT2VNb3lOTTI2VUovMVBm?= =?utf-8?B?L09Jc0ZTUlphTW10YzNOek5LcHdNSVA1RDhNMml0bHRpWDdtTzgzRWllZ2xt?= =?utf-8?B?dEpZTFJSTDZkVnNLQWdWRmJmUzlpSHNSWHd4bjFLSW45NFFtd1VzS0tWTmN4?= =?utf-8?B?YXphb2llcVpsVElmK1dQT0ovWUthTm9BUlBPN0ZPSW9IazY1RVBWZ0lkUnB1?= =?utf-8?B?RnVJYU9pM0htZDlNQXYwZ29ReEpCSmMrekNCbVBEalVmU2VkMFlob21HQWdS?= =?utf-8?B?LzBCSFMyS3g4TjdOUGdTTU9rbU5QYVV0VTVxMWthdzAwM2pWRzdUY0MvNVFq?= =?utf-8?B?SS9uRHJtOGRkREhhem1odlBPRWdWS0ZHemRydUhxUUV2SlVmOXY2Z3FiQ09I?= =?utf-8?B?MDVCWGlYN1hpWFVRajNNM0RVMjd6S0Q1OWFqeGpmOG9uamNBckJkalNtbWlX?= =?utf-8?B?ZFAzNm5zT0doZGZkSkVHUkVMWWdrOXFUUjd1L0FCRy9aTm9RdHNpMHdXWUtq?= =?utf-8?B?Y0pRNnFTbjVXT1RuVU5PSlVEVXJIdkhtM1haYnk4SjdSYWF4TE11aUpNcUZ4?= =?utf-8?B?Z3RPTCtUdjQzQ1hDYU1LZGd3eDZrTzNCcEVVTHl1TXNHL3d5UGwwUk5FL0xr?= =?utf-8?B?VHJmak1wSlFUWEZyQnNYa3RaVzVXUVFiaENsamg1K3NGRjN6dEJBYW44M1lP?= =?utf-8?B?RFV1RnZSRGQ3WWZsQ0IwVlNhUjRwVWQveTRYVHVsdEQxYnpFRGhySjkxaSts?= =?utf-8?B?MHMveVI0VXRTdjVDeUx6WVpKRVNLb3pUSi81QnBtc1FOUjRBaWNoc3lxbWkr?= =?utf-8?B?cXNhVThzZ2NHVm5VOEhQTFVhS0NnYmtYTjJDbHJmaXR0TzJQdjhoUW1mZnRU?= =?utf-8?B?UUQzMVgxa09zanhTb2thWWZLVys2eUZwN3pMNlU0YTgyWldsUEZuRENUVVI0?= =?utf-8?B?cVl4SEpheHJYb3Z3aVVOT3VsZGVJcFBraGE5MmZOSlgxNzh1VytwOG5FOFZZ?= =?utf-8?B?Zy9sem5wMGg4ZXQ1SWdUcGVuTnlKNzUzK3VOWjR1THJhZ3R3T3lVLzJ2a2lY?= =?utf-8?B?OThldm9zZVVUSjFGM3VCUW5iSDN5M0tMeEVQSUtPQ3crVS8zSzVyYnJKYnpO?= =?utf-8?B?WXVscUNUSHkyTDNSaGxOamM1L1E3bnhJVlV4VUNPdTFYOEF1RzFDVGVTQllp?= =?utf-8?B?UXJ4MXBBcVJHVmZhN09uU0oxZFJ2VDlkY1RHaUdXUitNaXg0a1A5MWRIbkVR?= =?utf-8?B?dnZXVkEwMGE0Zkhqa2lSS3hXRnZoS1lDMGJqaHA3aHkzdDBVcC9FUTg5blpR?= =?utf-8?B?blI5cW9CZnk5MjRPeGY0ZTlBQUpuSGt1bnBtY1FBVE02OHp6VjhGZGVZZHp1?= =?utf-8?B?QTdTbmtWNXhFUXVDZ2NHdlVGbkQ4Y2QwN044WkY2SWpxbEZoc3VxWnJqVWNk?= =?utf-8?B?MGV5MytVUXdzMEFFK3laQTlqWUJ5SzZ6ZEdWVFhBUjhrcXRINTRCQm4vaUNp?= =?utf-8?B?MlV6ZVhuSnFLUFVncitjblJWSlRiME5jVXdMNFdTd3lucUQzSisxTk5NVUpJ?= =?utf-8?B?MDJLWDBlN2lJSmt6WjBTS1V3S0o0THl1OWJiNTkxTS9CTlc4MHl6VGQzUGFi?= =?utf-8?B?MVI5Q216Z0FMSDhwL3k3N29Rd2pqQ3ByUzNPS3p6ZUc1ZEhMb3BVbXI5RE50?= =?utf-8?B?NXhkQ21pRjc5TTVhNERWbmtJb3BWZ3RFZ0ZVc2xaUVAzRVBwb2kraWpVVWJq?= =?utf-8?B?cGFDK215REtUbWp3NUw1K2xKUGRWMHdLVnVXU2toMnk5MUZhdUYzdz09?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6347.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9eaf493c-337a-461d-63e8-08da269cdf7d X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Apr 2022 09:20:43.2324 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xHLWs872+YwcJ2dhR+l4ecglfjNY1HClSSS8O9oMrwVPNOKnBKMBIvHNlASdz07n9fl8yXcTp01D07c51Dban9Z2aRsu8YwUm+YcRaEe64Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5748 DQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBEdXJyYW50LCBQYXVsIDx4YWRp bWduaWtAZ21haWwuY29tPiANClNlbnQ6IDI1IEFwcmlsIDIwMjIgMTA6MTUNClRvOiBNYXJ0aW4g SGFydmV5IDxtYXJ0aW4uaGFydmV5QGNpdHJpeC5jb20+OyBwYXVsQHhlbi5vcmc7IHdpbi1wdi1k ZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KU3ViamVjdDogUmU6IFhlblZpZiBkaXYgYnkgemVy byBvbiBUeCBwYXRoIGFmdGVyIHJlc3VtZS4NCg0KDQo+IFNvLCB0aGVyZSBzaG91bGQgYmUgbm8g d2F5IGEgdGhyZWFkIGNhbiBydW4gYmVmb3JlIGFsbCAnbGF0ZScgY2FsbGJhY2tzIGhhdmUgcnVu IHVubGVzcyB0aGVyZSBpcyBhIGtlcm5lbCBjYWxsIGJlaW5nIG1hZGUgYXQgdGhlIHdyb25nIElS UUwgb3Igd2UgbmVlZCBleHRyYSBiYXJyaWVyaW5nLiBIb3BlZnVsbHkgdGhlIGZvcm1lciBjb3Vs ZCBiZSBjYXVnaHQgaW4gdmVyaWZpZXIuDQoNCkRvbid0IHBhbmljLiBJIHRoaW5rIEkndmUgZm91 bmQgdGhlIGJ1ZyAtIGp1c3QgcnVubmluZyBzb21lIGV4dHJhIHRlc3RzIHRvIG1ha2Ugc3VyZS4N Cg0KTUguDQo= From win-pv-devel-bounces@lists.xenproject.org Mon Apr 25 09:55:02 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 25 Apr 2022 09:55:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.312687.530025 (Exim 4.92) (envelope-from ) id 1nivQs-0003jU-54; Mon, 25 Apr 2022 09:55:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 312687.530025; Mon, 25 Apr 2022 09:55:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nivQs-0003jN-1u; Mon, 25 Apr 2022 09:55:02 +0000 Received: by outflank-mailman (input) for mailman id 312687; Mon, 25 Apr 2022 09:55:00 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nivQq-0003jH-AS for win-pv-devel@lists.xenproject.org; Mon, 25 Apr 2022 09:55:00 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" Date: Mon, 25 Apr 2022 09:54:59 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <14360878.1.1650880502247.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> Subject: XENIFACE-master - Build #110 - Successful MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_0_8222357.1650880501341" X-Jenkins-Job: XENIFACE-master X-Jenkins-Result: SUCCESS ------=_Part_0_8222357.1650880501341 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #110. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENIFACE-master/110/console to view the results. ------=_Part_0_8222357.1650880501341-- From win-pv-devel-bounces@lists.xenproject.org Mon Apr 25 12:14:17 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 25 Apr 2022 12:14:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.312848.530241 (Exim 4.92) (envelope-from ) id 1nixbc-00051T-Q2; Mon, 25 Apr 2022 12:14:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 312848.530241; Mon, 25 Apr 2022 12:14:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nixbc-000516-Mw; Mon, 25 Apr 2022 12:14:16 +0000 Received: by outflank-mailman (input) for mailman id 312848; Mon, 25 Apr 2022 12:14:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nixbb-00050p-Ay for win-pv-devel@lists.xenproject.org; Mon, 25 Apr 2022 12:14:15 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 37950284-c491-11ec-a405-831a346695d4; Mon, 25 Apr 2022 14:14:13 +0200 (CEST) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 37950284-c491-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1650888853; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=6SqF4k4kvNFd0fIdU+i3HbDiRBQU981MN9gsfHaPVuE=; b=CL6ZTTtKR1O6nGkcd6kMmnln3Rfw30NwWXrm7g+IuNW9iwfxUekb5JWC zFP4QAn6agZWi4jS+dczsuQGVrF6SclmwgSTEZk09QB8DwyCxcYVQuALY Mr5GU2ZNbGDLvwswLedofoYRKugnBy4efv58/gZQ0HrYDpFm/5nCUlFFC E=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 70256055 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:XofM361vfYBL2jiK9PbD5Y9xkn2cJEfYwER7XKvMYLTBsI5bpzYDz GEYDG6APv/cM2Wkft4lPt+2pxkPuJCBx9JgHVc6pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tIy3IDga++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1IipaebxkvBpSSv7RMYyVfSy9zZupvreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr KJCbmpXN1ba2rzwkOnTpupE36zPKOHsI44Z/GplzC3ZJf0nXYrCU+PB4towMDIY2ZgUQKiGO pdxhTxHRjP+b0FMFFEsMIM/prqvhiXOT35/twfAzUYwyzeKl1EguFT3C/LKe9rPXdsQkkuGq 2bu+2XiHgpcJNGZ0SCC8H+nmqnIhyyTZW4JPOTmrLgw2gTVnzFNTk1NPbemnRWnokuBUfx5N Uosw3QJ/fkCyEvzQNSmGDTt9RZooSUgc9ZXFuQ77iSExazV/xuVCwA4c9JRVDA1nJRoHGJ3j zdli/usXGUy6+PNFRpx45/O9VuP1T4pwXjujMPuZS8M+JHdrY46lXojpf4zQffu3rUZ9dwdq g1mTRTSZZ1O16bnNI3hpDgrZg5AQbCTE2YICv3/BD7N0++ATNfNi3aUwVba9+1cC42SU0OMu nMJ8+DHsr1WUszUzHbcHb9TdF1M2xpjGGeF6bKIN8N/nwlBBlb5JdwAiN2ADBoB3jk4lc/BP xaI5FI5CG57N3q2d65nC79d+OxxpZUM4e/ND6iOBvIXO8AZXFberElGOB7Bt0iwwRNEufxuZ v+mnTOEUC9y5VJPl2HtGY/wENYDm0gD+I8kbc2ln0n/jerCNRZ4i94taTOzUwzw14vcyC29z jqVH5HiJ8l3OAEmXhTqzA== IronPort-HdrOrdr: A9a23:4htiA6vR/MSj1wYcEbin50Si7skDfNV00zEX/kB9WHVpmszxra +TdZMgpHrJYVcqKRYdcL+7WZVoLUmwyXcX2/hyAV7BZmnbUQKTRekIh7cKqweQfxEWndQy6U 4PScRD4aXLfDtHsfo= X-IronPort-AV: E=Sophos;i="5.90,288,1643691600"; d="scan'208";a="70256055" From: Owen Smith To: CC: Owen Smith Subject: [PATCH] More IOCTL parameter checks Date: Mon, 25 Apr 2022 13:14:01 +0100 Message-ID: <20220425121401.101-1-owen.smith@citrix.com> X-Mailer: git-send-email 2.32.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Also expands ASSERT(NT_SUCCESS(function)) calls in cleanup paths Signed-off-by: Owen Smith --- src/xeniface/ioctl_evtchn.c | 15 ++++++++++----- src/xeniface/ioctl_gnttab.c | 26 ++++++++++++++++---------- src/xeniface/ioctl_sharedinfo.c | 5 +++++ src/xeniface/ioctl_store.c | 17 ++++++++++------- src/xeniface/ioctl_suspend.c | 11 +++++++++-- src/xeniface/ioctls.c | 4 ++-- 6 files changed, 52 insertions(+), 26 deletions(-) diff --git a/src/xeniface/ioctl_evtchn.c b/src/xeniface/ioctl_evtchn.c index f528485..90e9468 100644 --- a/src/xeniface/ioctl_evtchn.c +++ b/src/xeniface/ioctl_evtchn.c @@ -166,7 +166,8 @@ IoctlEvtchnBindUnbound( status = STATUS_INVALID_BUFFER_SIZE; if (InLen != sizeof(XENIFACE_EVTCHN_BIND_UNBOUND_IN) || - OutLen != sizeof(XENIFACE_EVTCHN_BIND_UNBOUND_OUT)) { + OutLen != sizeof(XENIFACE_EVTCHN_BIND_UNBOUND_OUT) || + Buffer == NULL) { goto fail1; } @@ -259,7 +260,8 @@ IoctlEvtchnBindInterdomain( status = STATUS_INVALID_BUFFER_SIZE; if (InLen != sizeof(XENIFACE_EVTCHN_BIND_INTERDOMAIN_IN) || - OutLen != sizeof(XENIFACE_EVTCHN_BIND_INTERDOMAIN_OUT)) { + OutLen != sizeof(XENIFACE_EVTCHN_BIND_INTERDOMAIN_OUT) || + Buffer == NULL) { goto fail1; } @@ -353,7 +355,8 @@ IoctlEvtchnClose( status = STATUS_INVALID_BUFFER_SIZE; if (InLen != sizeof(XENIFACE_EVTCHN_CLOSE_IN) || - OutLen != 0) { + OutLen != 0 || + Buffer == NULL) { goto fail1; } @@ -430,7 +433,8 @@ IoctlEvtchnNotify( status = STATUS_INVALID_BUFFER_SIZE; if (InLen != sizeof(XENIFACE_EVTCHN_NOTIFY_IN) || - OutLen != 0) { + OutLen != 0 || + Buffer == NULL) { goto fail1; } @@ -462,7 +466,8 @@ IoctlEvtchnUnmask( status = STATUS_INVALID_BUFFER_SIZE; if (InLen != sizeof(XENIFACE_EVTCHN_UNMASK_IN) || - OutLen != 0) { + OutLen != 0 || + Buffer == NULL) { goto fail1; } diff --git a/src/xeniface/ioctl_gnttab.c b/src/xeniface/ioctl_gnttab.c index c3cf129..5777ac8 100644 --- a/src/xeniface/ioctl_gnttab.c +++ b/src/xeniface/ioctl_gnttab.c @@ -174,7 +174,8 @@ IoctlGnttabPermitForeignAccess( } status = STATUS_INVALID_BUFFER_SIZE; - if (OutLen != (ULONG)FIELD_OFFSET(XENIFACE_GNTTAB_PERMIT_FOREIGN_ACCESS_OUT, References[In->NumberPages])) + if (OutLen != (ULONG)FIELD_OFFSET(XENIFACE_GNTTAB_PERMIT_FOREIGN_ACCESS_OUT, References[In->NumberPages]) || + Out == NULL) goto fail5; status = STATUS_NO_MEMORY; @@ -310,11 +311,12 @@ fail11: Error("Fail11: Page = %lu\n", Page); while (Page > 0) { - ASSERT(NT_SUCCESS(XENBUS_GNTTAB(RevokeForeignAccess, + NTSTATUS status2 = XENBUS_GNTTAB(RevokeForeignAccess, &Fdo->GnttabInterface, Fdo->GnttabCache, FALSE, - Context->Grants[Page - 1]))); + Context->Grants[Page - 1]); + ASSERT(NT_SUCCESS(status2)); --Page; } @@ -425,7 +427,7 @@ IoctlGnttabRevokeForeignAccess( PXENIFACE_CONTEXT_ID ContextId; status = STATUS_INVALID_BUFFER_SIZE; - if (InLen != sizeof(XENIFACE_GNTTAB_REVOKE_FOREIGN_ACCESS_IN)) + if (InLen != sizeof(XENIFACE_GNTTAB_REVOKE_FOREIGN_ACCESS_IN) || Buffer == NULL) goto fail1; Id.Type = XENIFACE_CONTEXT_GRANT; @@ -476,7 +478,8 @@ IoctlGnttabMapForeignPages( status = STATUS_INVALID_BUFFER_SIZE; if (InLen < sizeof(XENIFACE_GNTTAB_MAP_FOREIGN_PAGES_IN) || - OutLen != sizeof(XENIFACE_GNTTAB_MAP_FOREIGN_PAGES_OUT)) { + OutLen != sizeof(XENIFACE_GNTTAB_MAP_FOREIGN_PAGES_OUT) || + Buffer == NULL) { goto fail1; } @@ -618,10 +621,12 @@ fail10: fail9: Error("Fail9\n"); - ASSERT(NT_SUCCESS(XENBUS_GNTTAB(UnmapForeignPages, - &Fdo->GnttabInterface, - Context->Address - ))); + { + NTSTATUS status2 = XENBUS_GNTTAB(UnmapForeignPages, + &Fdo->GnttabInterface, + Context->Address); + ASSERT(NT_SUCCESS(status2)); + } fail8: Error("Fail8\n"); @@ -714,7 +719,8 @@ IoctlGnttabUnmapForeignPages( status = STATUS_INVALID_BUFFER_SIZE; if (InLen != sizeof(XENIFACE_GNTTAB_UNMAP_FOREIGN_PAGES_IN) || - OutLen != 0) { + OutLen != 0 || + Buffer == NULL) { goto fail1; } diff --git a/src/xeniface/ioctl_sharedinfo.c b/src/xeniface/ioctl_sharedinfo.c index 7870732..eab35a5 100644 --- a/src/xeniface/ioctl_sharedinfo.c +++ b/src/xeniface/ioctl_sharedinfo.c @@ -56,6 +56,9 @@ IoctlSharedInfoGetTime( if (OutLen != sizeof(XENIFACE_SHAREDINFO_GET_TIME_OUT)) goto fail2; + if (Buffer == NULL) + goto fail3; + Out = (PXENIFACE_SHAREDINFO_GET_TIME_OUT)Buffer; XENBUS_SHARED_INFO(GetTime, &Fdo->SharedInfoInterface, &Time, &Local); @@ -66,6 +69,8 @@ IoctlSharedInfoGetTime( return STATUS_SUCCESS; +fail3: + Error("fail3\n"); fail2: Error("Fail2\n"); fail1: diff --git a/src/xeniface/ioctl_store.c b/src/xeniface/ioctl_store.c index 97062df..3964662 100644 --- a/src/xeniface/ioctl_store.c +++ b/src/xeniface/ioctl_store.c @@ -105,7 +105,7 @@ IoctlStoreRead( BOOLEAN SquashError = FALSE; status = STATUS_INVALID_BUFFER_SIZE; - if (InLen == 0) + if (InLen == 0 || Buffer == NULL) goto fail1; status = STATUS_INVALID_PARAMETER; @@ -173,7 +173,7 @@ IoctlStoreWrite( ULONG Length; status = STATUS_INVALID_BUFFER_SIZE; - if (InLen == 0 || OutLen != 0) + if (InLen == 0 || OutLen != 0 || Buffer == NULL) goto fail1; status = STATUS_INVALID_PARAMETER; @@ -221,7 +221,7 @@ IoctlStoreDirectory( BOOLEAN SquashError = FALSE; status = STATUS_INVALID_BUFFER_SIZE; - if (InLen == 0) + if (InLen == 0 || Buffer == NULL) goto fail1; status = STATUS_INVALID_PARAMETER; @@ -289,7 +289,7 @@ IoctlStoreRemove( NTSTATUS status; status = STATUS_INVALID_BUFFER_SIZE; - if (InLen == 0 || OutLen != 0) + if (InLen == 0 || OutLen != 0 || Buffer == NULL) goto fail1; status = STATUS_INVALID_PARAMETER; @@ -392,7 +392,8 @@ IoctlStoreSetPermissions( status = STATUS_INVALID_BUFFER_SIZE; if (InLen < sizeof(XENIFACE_STORE_SET_PERMISSIONS_IN) || - OutLen != 0) { + OutLen != 0 || + Buffer == NULL) { goto fail1; } @@ -508,7 +509,8 @@ IoctlStoreAddWatch( status = STATUS_INVALID_BUFFER_SIZE; if (InLen != sizeof(XENIFACE_STORE_ADD_WATCH_IN) || - OutLen != sizeof(XENIFACE_STORE_ADD_WATCH_OUT)) { + OutLen != sizeof(XENIFACE_STORE_ADD_WATCH_OUT) || + Buffer == NULL) { goto fail1; } @@ -648,7 +650,8 @@ IoctlStoreRemoveWatch( status = STATUS_INVALID_BUFFER_SIZE; if (InLen != sizeof(XENIFACE_STORE_REMOVE_WATCH_IN) || - OutLen != 0) { + OutLen != 0 || + Buffer == NULL) { goto fail1; } diff --git a/src/xeniface/ioctl_suspend.c b/src/xeniface/ioctl_suspend.c index 6289a94..e7e8437 100644 --- a/src/xeniface/ioctl_suspend.c +++ b/src/xeniface/ioctl_suspend.c @@ -55,6 +55,9 @@ IoctlSuspendGetCount( if (OutLen != sizeof(ULONG)) goto fail2; + if (Buffer == NULL) + goto fail3; + Value = (PULONG)Buffer; *Value = XENBUS_SUSPEND(GetCount, &Fdo->SuspendInterface); *Info = (ULONG_PTR)sizeof(ULONG); @@ -62,6 +65,8 @@ IoctlSuspendGetCount( return status; +fail3: + Error("Fail3\n"); fail2: Error("Fail2\n"); fail1: @@ -87,7 +92,8 @@ IoctlSuspendRegister( status = STATUS_INVALID_BUFFER_SIZE; if (InLen != sizeof(XENIFACE_SUSPEND_REGISTER_IN) || - OutLen != sizeof(XENIFACE_SUSPEND_REGISTER_OUT)) { + OutLen != sizeof(XENIFACE_SUSPEND_REGISTER_OUT) || + Buffer == NULL) { goto fail1; } @@ -163,7 +169,8 @@ IoctlSuspendDeregister( status = STATUS_INVALID_BUFFER_SIZE; if (InLen != sizeof(XENIFACE_SUSPEND_REGISTER_OUT) || - OutLen != 0) { + OutLen != 0 || + Buffer == NULL) { goto fail1; } diff --git a/src/xeniface/ioctls.c b/src/xeniface/ioctls.c index a624bd1..20a7669 100644 --- a/src/xeniface/ioctls.c +++ b/src/xeniface/ioctls.c @@ -48,9 +48,9 @@ __CaptureUserBuffer( NTSTATUS Status; PVOID TempBuffer = NULL; - if (Length == 0) { + if (Length == 0 || Buffer == NULL) { *CapturedBuffer = NULL; - return STATUS_SUCCESS; + return STATUS_INVALID_PARAMETER; } Status = STATUS_NO_MEMORY; -- 2.32.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Thu Apr 28 10:44:29 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 28 Apr 2022 10:44:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.316426.535351 (Exim 4.92) (envelope-from ) id 1nk1dM-0006jn-1O; Thu, 28 Apr 2022 10:44:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 316426.535351; Thu, 28 Apr 2022 10:44:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nk1dL-0006jf-UP; Thu, 28 Apr 2022 10:44:27 +0000 Received: by outflank-mailman (input) for mailman id 316426; Thu, 28 Apr 2022 10:44:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nk1dK-0006jZ-Dn for win-pv-devel@lists.xenproject.org; Thu, 28 Apr 2022 10:44:26 +0000 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [2a00:1450:4864:20::32b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2adaf60b-c6e0-11ec-a405-831a346695d4; Thu, 28 Apr 2022 12:44:25 +0200 (CEST) Received: by mail-wm1-x32b.google.com with SMTP id p7-20020a05600c358700b00393e80c59daso3804492wmq.0 for ; Thu, 28 Apr 2022 03:44:23 -0700 (PDT) Received: from [10.7.237.11] (54-240-197-227.amazon.com. [54.240.197.227]) by smtp.gmail.com with ESMTPSA id b11-20020adfc74b000000b0020ad84d3fa3sm11669087wrh.44.2022.04.28.03.44.21 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Apr 2022 03:44:22 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 2adaf60b-c6e0-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=KYuimSKGz9l/2c2Cn0iFoa8PxzbXBh4L50UcxYIU8Ks=; b=df0t5o4s9iW540yEZ+kyDC0R0uUdpF+3QWK2c8gxlKXWo4/vXvRCuSOz9SjTqnbAOW Bm5XpYwgw59jNqCBQgdjOwwPXjCz9rhhppJV3bnR1isLfrsKat6LU1ELVhKro2KoVBqD nJYdNbQrrKCjr++Hk90DRuLK6AGQIo4bTR/yOYITPIWaJny/QeKX+9CeTUmLyb1YpAIZ 3ivjzWK+H1W6iHrgzpnOTGGeRDi9UfY8jDscrB6vg1riArk9M5V1zcLJMd5QANunjazo FIBiMWiI5sOTjDim7ajGXv8d2JBy43HN9kzsFR0ghdffcpzzh5MLkuQLtBu/wVkryFpt w2jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=KYuimSKGz9l/2c2Cn0iFoa8PxzbXBh4L50UcxYIU8Ks=; b=CWj08N7HMNjIjAQqCSj5dDU5xdQFzvivKODswf8YOPXdwu84PwT2/vS4eLvhhVu9CM D4YEFRrUgnSvP/9MWSy2Le87XmyHeUE4lo6XzeXPO/b0L8vIjuA60wC8o/x5LjkU7zqA sNm7vrRkYIL6o6eKXuk45P0U9NbxIcinmxFuI87tS+gLbX1a5BwYyILktcwG08dkr6KZ Qu46iDKZMsFXJ7XtFaicLHfWD0RqIYNoZlXfS/gB4scoWPHvUq9rvbwMEMQWrZ+/0GF8 4EYnyqMO09XZyvZRAvZCcau9gZ4avyY28xZTAGEz+X/7I6vLKnd1PRKX5eAlaU5iWjcd GJfw== X-Gm-Message-State: AOAM532ox0GEbT8+9gS97qaUlb8UBX5LVtCtxYoxg0bpnfrTLkAj66/v 9jR08llkNLWtbYqT6gNyczRTI8oVOdR1vg== X-Google-Smtp-Source: ABdhPJzYSNGfdqYCIdyxX+aV0dIZfdyXOro71BUPDF+tnDqvQNerEmskBveY8qis91VItyGTcWgaLg== X-Received: by 2002:a1c:f604:0:b0:38c:8ffd:dbb6 with SMTP id w4-20020a1cf604000000b0038c8ffddbb6mr39627930wmc.43.1651142663195; Thu, 28 Apr 2022 03:44:23 -0700 (PDT) Message-ID: <5db038cf-67e2-ae6b-a951-1526e0e876b5@gmail.com> Date: Thu, 28 Apr 2022 11:44:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Reply-To: paul@xen.org Subject: Re: [PATCH] More IOCTL parameter checks Content-Language: en-US To: win-pv-devel@lists.xenproject.org References: <20220425121401.101-1-owen.smith@citrix.com> From: "Durrant, Paul" In-Reply-To: <20220425121401.101-1-owen.smith@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 25/04/2022 13:14, Owen Smith wrote: > Also expands ASSERT(NT_SUCCESS(function)) calls in cleanup paths > > Signed-off-by: Owen Smith > --- > src/xeniface/ioctl_evtchn.c | 15 ++++++++++----- > src/xeniface/ioctl_gnttab.c | 26 ++++++++++++++++---------- > src/xeniface/ioctl_sharedinfo.c | 5 +++++ > src/xeniface/ioctl_store.c | 17 ++++++++++------- > src/xeniface/ioctl_suspend.c | 11 +++++++++-- > src/xeniface/ioctls.c | 4 ++-- > 6 files changed, 52 insertions(+), 26 deletions(-) > > diff --git a/src/xeniface/ioctl_evtchn.c b/src/xeniface/ioctl_evtchn.c > index f528485..90e9468 100644 > --- a/src/xeniface/ioctl_evtchn.c > +++ b/src/xeniface/ioctl_evtchn.c > @@ -166,7 +166,8 @@ IoctlEvtchnBindUnbound( > > status = STATUS_INVALID_BUFFER_SIZE; > if (InLen != sizeof(XENIFACE_EVTCHN_BIND_UNBOUND_IN) || > - OutLen != sizeof(XENIFACE_EVTCHN_BIND_UNBOUND_OUT)) { > + OutLen != sizeof(XENIFACE_EVTCHN_BIND_UNBOUND_OUT) || > + Buffer == NULL) { > goto fail1; > } > > @@ -259,7 +260,8 @@ IoctlEvtchnBindInterdomain( > > status = STATUS_INVALID_BUFFER_SIZE; > if (InLen != sizeof(XENIFACE_EVTCHN_BIND_INTERDOMAIN_IN) || > - OutLen != sizeof(XENIFACE_EVTCHN_BIND_INTERDOMAIN_OUT)) { > + OutLen != sizeof(XENIFACE_EVTCHN_BIND_INTERDOMAIN_OUT) || > + Buffer == NULL) { > goto fail1; > } > > @@ -353,7 +355,8 @@ IoctlEvtchnClose( > > status = STATUS_INVALID_BUFFER_SIZE; > if (InLen != sizeof(XENIFACE_EVTCHN_CLOSE_IN) || > - OutLen != 0) { > + OutLen != 0 || > + Buffer == NULL) { > goto fail1; > } > > @@ -430,7 +433,8 @@ IoctlEvtchnNotify( > > status = STATUS_INVALID_BUFFER_SIZE; > if (InLen != sizeof(XENIFACE_EVTCHN_NOTIFY_IN) || > - OutLen != 0) { > + OutLen != 0 || > + Buffer == NULL) { > goto fail1; > } > > @@ -462,7 +466,8 @@ IoctlEvtchnUnmask( > > status = STATUS_INVALID_BUFFER_SIZE; > if (InLen != sizeof(XENIFACE_EVTCHN_UNMASK_IN) || > - OutLen != 0) { > + OutLen != 0 || > + Buffer == NULL) { > goto fail1; > } > > diff --git a/src/xeniface/ioctl_gnttab.c b/src/xeniface/ioctl_gnttab.c > index c3cf129..5777ac8 100644 > --- a/src/xeniface/ioctl_gnttab.c > +++ b/src/xeniface/ioctl_gnttab.c > @@ -174,7 +174,8 @@ IoctlGnttabPermitForeignAccess( > } > > status = STATUS_INVALID_BUFFER_SIZE; > - if (OutLen != (ULONG)FIELD_OFFSET(XENIFACE_GNTTAB_PERMIT_FOREIGN_ACCESS_OUT, References[In->NumberPages])) > + if (OutLen != (ULONG)FIELD_OFFSET(XENIFACE_GNTTAB_PERMIT_FOREIGN_ACCESS_OUT, References[In->NumberPages]) || > + Out == NULL) > goto fail5; > > status = STATUS_NO_MEMORY; > @@ -310,11 +311,12 @@ fail11: > Error("Fail11: Page = %lu\n", Page); > > while (Page > 0) { > - ASSERT(NT_SUCCESS(XENBUS_GNTTAB(RevokeForeignAccess, > + NTSTATUS status2 = XENBUS_GNTTAB(RevokeForeignAccess, > &Fdo->GnttabInterface, > Fdo->GnttabCache, > FALSE, > - Context->Grants[Page - 1]))); > + Context->Grants[Page - 1]); > + ASSERT(NT_SUCCESS(status2)); > > --Page; > } > @@ -425,7 +427,7 @@ IoctlGnttabRevokeForeignAccess( > PXENIFACE_CONTEXT_ID ContextId; > > status = STATUS_INVALID_BUFFER_SIZE; > - if (InLen != sizeof(XENIFACE_GNTTAB_REVOKE_FOREIGN_ACCESS_IN)) > + if (InLen != sizeof(XENIFACE_GNTTAB_REVOKE_FOREIGN_ACCESS_IN) || Buffer == NULL) > goto fail1; > > Id.Type = XENIFACE_CONTEXT_GRANT; > @@ -476,7 +478,8 @@ IoctlGnttabMapForeignPages( > > status = STATUS_INVALID_BUFFER_SIZE; > if (InLen < sizeof(XENIFACE_GNTTAB_MAP_FOREIGN_PAGES_IN) || > - OutLen != sizeof(XENIFACE_GNTTAB_MAP_FOREIGN_PAGES_OUT)) { > + OutLen != sizeof(XENIFACE_GNTTAB_MAP_FOREIGN_PAGES_OUT) || > + Buffer == NULL) { > goto fail1; > } > > @@ -618,10 +621,12 @@ fail10: > > fail9: > Error("Fail9\n"); > - ASSERT(NT_SUCCESS(XENBUS_GNTTAB(UnmapForeignPages, > - &Fdo->GnttabInterface, > - Context->Address > - ))); > + { > + NTSTATUS status2 = XENBUS_GNTTAB(UnmapForeignPages, > + &Fdo->GnttabInterface, > + Context->Address); > + ASSERT(NT_SUCCESS(status2)); Why? > + } > > fail8: > Error("Fail8\n"); > @@ -714,7 +719,8 @@ IoctlGnttabUnmapForeignPages( > > status = STATUS_INVALID_BUFFER_SIZE; > if (InLen != sizeof(XENIFACE_GNTTAB_UNMAP_FOREIGN_PAGES_IN) || > - OutLen != 0) { > + OutLen != 0 || > + Buffer == NULL) { > goto fail1; > } > > diff --git a/src/xeniface/ioctl_sharedinfo.c b/src/xeniface/ioctl_sharedinfo.c > index 7870732..eab35a5 100644 > --- a/src/xeniface/ioctl_sharedinfo.c > +++ b/src/xeniface/ioctl_sharedinfo.c > @@ -56,6 +56,9 @@ IoctlSharedInfoGetTime( > if (OutLen != sizeof(XENIFACE_SHAREDINFO_GET_TIME_OUT)) > goto fail2; > > + if (Buffer == NULL) > + goto fail3; > + > Out = (PXENIFACE_SHAREDINFO_GET_TIME_OUT)Buffer; > XENBUS_SHARED_INFO(GetTime, &Fdo->SharedInfoInterface, &Time, > &Local); > @@ -66,6 +69,8 @@ IoctlSharedInfoGetTime( > > return STATUS_SUCCESS; > > +fail3: > + Error("fail3\n"); > fail2: > Error("Fail2\n"); > fail1: > diff --git a/src/xeniface/ioctl_store.c b/src/xeniface/ioctl_store.c > index 97062df..3964662 100644 > --- a/src/xeniface/ioctl_store.c > +++ b/src/xeniface/ioctl_store.c > @@ -105,7 +105,7 @@ IoctlStoreRead( > BOOLEAN SquashError = FALSE; > > status = STATUS_INVALID_BUFFER_SIZE; > - if (InLen == 0) > + if (InLen == 0 || Buffer == NULL) > goto fail1; > > status = STATUS_INVALID_PARAMETER; > @@ -173,7 +173,7 @@ IoctlStoreWrite( > ULONG Length; > > status = STATUS_INVALID_BUFFER_SIZE; > - if (InLen == 0 || OutLen != 0) > + if (InLen == 0 || OutLen != 0 || Buffer == NULL) > goto fail1; > > status = STATUS_INVALID_PARAMETER; > @@ -221,7 +221,7 @@ IoctlStoreDirectory( > BOOLEAN SquashError = FALSE; > > status = STATUS_INVALID_BUFFER_SIZE; > - if (InLen == 0) > + if (InLen == 0 || Buffer == NULL) > goto fail1; > > status = STATUS_INVALID_PARAMETER; > @@ -289,7 +289,7 @@ IoctlStoreRemove( > NTSTATUS status; > > status = STATUS_INVALID_BUFFER_SIZE; > - if (InLen == 0 || OutLen != 0) > + if (InLen == 0 || OutLen != 0 || Buffer == NULL) > goto fail1; > > status = STATUS_INVALID_PARAMETER; > @@ -392,7 +392,8 @@ IoctlStoreSetPermissions( > > status = STATUS_INVALID_BUFFER_SIZE; > if (InLen < sizeof(XENIFACE_STORE_SET_PERMISSIONS_IN) || > - OutLen != 0) { > + OutLen != 0 || > + Buffer == NULL) { > goto fail1; > } > > @@ -508,7 +509,8 @@ IoctlStoreAddWatch( > > status = STATUS_INVALID_BUFFER_SIZE; > if (InLen != sizeof(XENIFACE_STORE_ADD_WATCH_IN) || > - OutLen != sizeof(XENIFACE_STORE_ADD_WATCH_OUT)) { > + OutLen != sizeof(XENIFACE_STORE_ADD_WATCH_OUT) || > + Buffer == NULL) { > goto fail1; > } > > @@ -648,7 +650,8 @@ IoctlStoreRemoveWatch( > > status = STATUS_INVALID_BUFFER_SIZE; > if (InLen != sizeof(XENIFACE_STORE_REMOVE_WATCH_IN) || > - OutLen != 0) { > + OutLen != 0 || > + Buffer == NULL) { > goto fail1; > } > > diff --git a/src/xeniface/ioctl_suspend.c b/src/xeniface/ioctl_suspend.c > index 6289a94..e7e8437 100644 > --- a/src/xeniface/ioctl_suspend.c > +++ b/src/xeniface/ioctl_suspend.c > @@ -55,6 +55,9 @@ IoctlSuspendGetCount( > if (OutLen != sizeof(ULONG)) > goto fail2; > > + if (Buffer == NULL) > + goto fail3; > + > Value = (PULONG)Buffer; > *Value = XENBUS_SUSPEND(GetCount, &Fdo->SuspendInterface); > *Info = (ULONG_PTR)sizeof(ULONG); > @@ -62,6 +65,8 @@ IoctlSuspendGetCount( > > return status; > > +fail3: > + Error("Fail3\n"); > fail2: > Error("Fail2\n"); > fail1: > @@ -87,7 +92,8 @@ IoctlSuspendRegister( > > status = STATUS_INVALID_BUFFER_SIZE; > if (InLen != sizeof(XENIFACE_SUSPEND_REGISTER_IN) || > - OutLen != sizeof(XENIFACE_SUSPEND_REGISTER_OUT)) { > + OutLen != sizeof(XENIFACE_SUSPEND_REGISTER_OUT) || > + Buffer == NULL) { > goto fail1; > } > > @@ -163,7 +169,8 @@ IoctlSuspendDeregister( > > status = STATUS_INVALID_BUFFER_SIZE; > if (InLen != sizeof(XENIFACE_SUSPEND_REGISTER_OUT) || > - OutLen != 0) { > + OutLen != 0 || > + Buffer == NULL) { > goto fail1; > } > > diff --git a/src/xeniface/ioctls.c b/src/xeniface/ioctls.c > index a624bd1..20a7669 100644 > --- a/src/xeniface/ioctls.c > +++ b/src/xeniface/ioctls.c > @@ -48,9 +48,9 @@ __CaptureUserBuffer( > NTSTATUS Status; > PVOID TempBuffer = NULL; > > - if (Length == 0) { > + if (Length == 0 || Buffer == NULL) { > *CapturedBuffer = NULL; > - return STATUS_SUCCESS; > + return STATUS_INVALID_PARAMETER; That's a semantic change. Do we want that? Paul > } > > Status = STATUS_NO_MEMORY; From win-pv-devel-bounces@lists.xenproject.org Thu Apr 28 12:11:17 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 28 Apr 2022 12:11:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.316494.535421 (Exim 4.92) (envelope-from ) id 1nk2zM-0001oK-9t; Thu, 28 Apr 2022 12:11:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 316494.535421; Thu, 28 Apr 2022 12:11:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nk2zM-0001oD-6l; Thu, 28 Apr 2022 12:11:16 +0000 Received: by outflank-mailman (input) for mailman id 316494; Thu, 28 Apr 2022 12:11:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nk2zK-0001o7-C8 for win-pv-devel@lists.xenproject.org; Thu, 28 Apr 2022 12:11:14 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 48734d9a-c6ec-11ec-a405-831a346695d4; Thu, 28 Apr 2022 14:11:08 +0200 (CEST) Received: from mail-co1nam11lp2169.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 28 Apr 2022 08:10:48 -0400 Received: from DS7PR03MB5477.namprd03.prod.outlook.com (2603:10b6:5:2c4::17) by PH0PR03MB6219.namprd03.prod.outlook.com (2603:10b6:510:e8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 28 Apr 2022 12:10:46 +0000 Received: from DS7PR03MB5477.namprd03.prod.outlook.com ([fe80::2440:e9f9:6f5b:ef39]) by DS7PR03MB5477.namprd03.prod.outlook.com ([fe80::2440:e9f9:6f5b:ef39%3]) with mapi id 15.20.5186.023; Thu, 28 Apr 2022 12:10:46 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 48734d9a-c6ec-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651147868; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=pqn6OkpSGwJQo6WtWdKWmM4++l1FB7WXyGSC2TgdKw8=; b=SjDEQpPMMbLlCGOIVhrbHBpgEU2XD9RlSp95yyp58Xa8vScwdc1b7eAb I39cFUp8tSDppzZw+D5YLakj8UcumkXSHDeFfc+RPqbUOKBSdGW2lUfzR OeZ8QlLvssI4pBEkkLxZv2r05FZ/S1sBod9dWq0Q36rLoMbSG48v96Nqc A=; X-IronPort-RemoteIP: 104.47.56.169 X-IronPort-MID: 70130492 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:G27/+q6NhiX9WGGSUHs7cAxRtFjGchMFZxGqfqrLsTDasY5as4F+v mMZUGmOM63fMGH8e9AlPNvl/R4B75fSm9E3S1doqn9mHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YTjU1vU0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurTva1YZY6bXw9gXdD9mDih7IZIc+LvYdC3XXcy7lyUqclPK6tA3VQQdGtRd/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfiUo4YGjV/chegXdRraT 80GZDwpdxHBfx1nMVYLEpMu2uyvgxETdhUH8AvO/fZmuQA/yiRXyJu2OvvuKuCYWPRJwWiFg l+X0UnAV0Ry2Nu3jGDtHmiXrvfGgCfTSI8UUrqi+ZZCn1yVg3QNTREbS1a/if24kVKlHcJSL VQO/SgjprR081akJuQRRDW9qX+A+xUbAtxZFrRj7BnXk/SFpQGEGmIDUzhNLsQ8s9M7TiAr0 VnPmM71ATtos/ueTnf1GqqokA5e8BM9dQcqDRLohyNfu7EPfKlbYsrzc+te IronPort-HdrOrdr: A9a23:CwfFBaMpAp6p/cBcT3X155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8Ar5K0tQ4uxoX5PwC080lKQFqrX5WI3PYOCIghrNEGgP1+rfKnjbalTDH41mpO pdmspFebrN5DFB5K6UjjVQUexQpuVvm5rY5ts2uk0dKD2CHJsQjTuRZDz6LmRGAC19QbYpHp uV4cRK4xC6f24MU8i9Dn4ZG8DeutzijvvdEFE7Li9izDPLoSKj6bb8HRTd9AwZSSlzzbAr9n WAuxDl55+kr+qwxnbnpiHuBtVt6ZrcI+l4dY+xY/suW3fRY8GTFcFcsoi5zXAISSeUmRIXeZ f30lAd1o9ImgnslymO0GbQMk/boXoTAjbZuCOlqGqmrsrjSD0gDc1dwYpfbxvC8kIl+Mpxya RRwguixuxq5D777VDADuLzJmZXf4uP0AofuP9Wi2YaXZoVabdXo4Ba9ERJEI0YFCa/7Iw8Cu FhAMzV+f4TKDqhHjjkl3gqxMbpUmU4Hx+ATERHssuJ0yJOlHQ8y0cD3sQQknoJ6Zp4QZhZ4O bPNLhuidh1P4YrRLM4AP1ETdq8C2TLTx6JOGWOIU7/HKVCIH7Jo46f2sRB2AhrQu178HIfou W+bLoDjx9MR6vHM7z+4LRbthbQXW66QTPhjslD+pkRgMyOeIbW X-IronPort-AV: E=Sophos;i="5.90,295,1643691600"; d="scan'208";a="70130492" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nZ0AWmlcHpfV2T1278gVetzE5yxjyq1G5WMbYObg7KRpA5X6wy6rOyaFRZkLfvD4bX7fv4CvP/AjErX77d31IiIKpSPrYHCRqa0BK7L7AZyQf64sH/CSciRf2F381ef2W2oHDQjaAwZ6FeEEflF9q6Aw7uA4Wr/VFjp05+VgI5Y0sA1gKhOAwEEdESrIzlmgsWUhacSoz9gAZN9TgZVPP7osbWEELgiU8x/doYXwsL53K56yFU5GuwlblviRztj1NnNc723MwESouImCq6eMr0jh/oR5W4anh4+93ISeIiKzsB3hYgKPHYqfTU0pNzzW1wzs8DislHBLHjMrqCIrIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pqn6OkpSGwJQo6WtWdKWmM4++l1FB7WXyGSC2TgdKw8=; b=RxdcRx8GCLu8gcEoz4iZXaVQkudsNeI5aFRR8pVJzZdKnpobxbcBt+ptJSKAVDagM1s7ofhflSTgqA2/S1AlkitVljLBQMr9A9xv0oUJprDEcT/D1dsNyuYZgKlkq5y2NjEa893KO2clXN9KwqKr6CK4w+HSfFQBbU74v6fKXenrCxIVAfmJIl1hMKoPYdx1ewvdVXyDaJS9fsUVhFOYGW1vVYOT+3Pxhh6gRalJzutWlHauUpDlpUdV7Xz0kAOoWJwv8xX/0Nn0BW0LihItvQaEuC4ZwPb6fXjSCntVDOcl5qq0s5dnuyuzzRvqk6FDkc2DwLUbB5vjFALPNDlKtg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pqn6OkpSGwJQo6WtWdKWmM4++l1FB7WXyGSC2TgdKw8=; b=NjansTOC3bcxlJCb/4RvVHbsjxvfhsY40KaarUtDSUBU1J8MZ+b06exYpORpOR9GAdSaCABbg5Oy7ByAg4ZDgUqH09ypcm/UFcO5MmlHl/4xf1bWv5I32WXeeuDEagP5XMSrqfhgU5AE7kCw+zT3TGkxxQj0zCgMXYMtRCwu/+o= From: Owen Smith To: "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Subject: RE: [PATCH] More IOCTL parameter checks Thread-Topic: [PATCH] More IOCTL parameter checks Thread-Index: AQHYWJ3764WTrsCpXUWjeMiMz++ClK0FKJqAgAATr+A= Date: Thu, 28 Apr 2022 12:10:46 +0000 Message-ID: References: <20220425121401.101-1-owen.smith@citrix.com> <5db038cf-67e2-ae6b-a951-1526e0e876b5@gmail.com> In-Reply-To: <5db038cf-67e2-ae6b-a951-1526e0e876b5@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a6745fb9-7320-479b-3eee-08da2910208d x-ms-traffictypediagnostic: PH0PR03MB6219:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qrbkeG/yWUVdtHe40ootytbILnfTYnVIJmFrS/AojiYHLLSeVh69/WFrflB96rEPhlQtKD5mvvChZYbNX/uqmHjMGauCSzK3zQm4u3MYAtjGYjvFKA5WE3HH8IROiSvF6Oq4JYUtCu0thdjTNr25SbkckYuqrrQA6ZUWztm7Tk7+cmQD3o3ioCLl1gQUa0GTtz5dlZRnhiNNbtZWUAT/N4Wr1Ifc3JfCTfk6jtM3/dnRGlGuX13+TgJFcyyGVMwIXzHaTwVMxd8Jx+cvCzbu/HZvKYRXsyV8UOxKn4JSrynEqucxrdoVRGRLtXQOsR9HkbrSqaZfKZVYiZezIXiR/mbjT7sKXLhtlWOIgWZUiRGLEWuWL9TFXN/W5ZaCyUd4AOzpTtavyrqPK3eWPWaHoRBWPrcPPs9ayV4SUUNjGqwZIzSa+jG1skeO1nTdf4t5EWX4Oi4NASfBCIefg5ueQBJ5/dds+kIaB63QjUDcjoKWss2PIvX+BJ+INRs3N9PNcEYmlijF1kU7OV0EYKi909R0g4AFijvkLJUb82/9z0OE7U5HrUTBpPwaAzV+Jo80F0J/plglmOa4vX2YlK83V7FK3h+UezfS2zlf1BiTx6E5Q47IpqFXHaO7uZGsNu/My6FMRkUopH2ESGqaaghEXf4BfpVahy0npXF1vyCGD6mH4GKiVdDzqen5glfe5wr5/n7XdGYT1sb/LsrQLw3LZg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5477.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(64756008)(66946007)(66556008)(82960400001)(8676002)(76116006)(9686003)(71200400001)(66476007)(66446008)(26005)(316002)(122000001)(186003)(6506007)(110136005)(508600001)(53546011)(86362001)(38070700005)(38100700002)(83380400001)(33656002)(2906002)(55016003)(44832011)(8936002)(52536014)(5660300002)(7696005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VWtiN1BBR3UyVnEvaHBDVjBvSlZGZnpQYllVNzdveENHZ1JvV0lKT3JmbjFN?= =?utf-8?B?SVZiVlQrYTBoM05ZOUdYdW5TYXJ3ZkthaWdTYUhWZXo4T2xnc3EzRDhuc3VY?= =?utf-8?B?L1Q1VnQvclVyTDh6dFpCL3k3UjZUWXpHUHRhak8xTHFQQkZONnl0VUNBR0pM?= =?utf-8?B?S1VDdmYyK1AwVDVzM3pydjRvdXhnZ0ZKRFArbDdNU0pEL0tyeEp1Y3lrSmJv?= =?utf-8?B?TlZnNURvZng2dGIrUVBWbUF4ZnBvRFF3bnNjeXl0L2V1UEtiUk1jcWRFWXNZ?= =?utf-8?B?MUM1TGp0ci84dGFhek52ZThCMWVKckdBMXh6dTFlMGl1K0cxYVJDZmg2bnNr?= =?utf-8?B?T215dllORHVyK0dta3RmK1FWc1dhZ3Q2ZkRMM2pFS2poUmp3aVQxeXozMFpM?= =?utf-8?B?QmEvVEdZTjJiQ3VjdmZodHgvYlZHS2xaWFVtS2pacVhJRDR0WVhCZUprUHM2?= =?utf-8?B?aHNoQmZyL2FicXJyTngrcXFwWXhvTGlvUStFdk94OHZDUEF3ajZrWWZ6K1BC?= =?utf-8?B?N2M0SDVNcTV0cVJ1U2FVam03RzB6aThpZzBLNnpOUGRSRlUzVGdtQ2Y3VnF0?= =?utf-8?B?T2hsT0RhalJKeEtkUEI2ZFpWUlljb0JXSWxzS0l4c3grZkYxOUlBSy9sZDA5?= =?utf-8?B?WDNnemtVYjdMeHVPTXFSZkZ1YnVZRGd4RHQrcWFzb041Tzdxb0Q2NmJUMm1N?= =?utf-8?B?UmNmcEdWYmR3aCtEUElkUTNJVmQvVVpTb2tYN1l5L3FEOS9XTGJjdlJYY3Av?= =?utf-8?B?S2w5ZjB1T0VBTzN5R1I0TENZSVVQYS84SFFMOWt0dk5wQmluVm5hcDJES01k?= =?utf-8?B?UjMwT2prZ1dEV2N3NHh5ZjlzQXpFYTFWQUExUTA3NHhGQnl6SVl2Tjc0S3kw?= =?utf-8?B?OUdwRGQ5bzljMGJGVEp3RFQ0bitrQzBRMHBFQmVIbTkydkVYbWsyUGlQdE1n?= =?utf-8?B?N0pmZzRKMGhJZG1ZRldmUFlQaVlQSDBPSHB2QXZ1YWFXaHhFcEVPMGs0azVj?= =?utf-8?B?MFJUSU4wMmhwKzEzMVlwWEtRenlKY2VzZFkzNmNSVDZtMGsrV1k5L2lXZW5T?= =?utf-8?B?djB1R2JKeFJ4MlgzMG4xU2N3N2dVWTFkSlFqS0I3YU5paEpBVWx6Y3pmZFMr?= =?utf-8?B?aVVlL01aSlo5cWpyRjQ1ZGpVVXZaK0lDbWdyWDlEQy9OM1NSTVIzMklxQ3Vk?= =?utf-8?B?MmN4ZEU5S3BxOEJ1THFqZ1IxT0MwNlVwb0lKTWZnOXJiMS9iUm9ZcHZVTXZT?= =?utf-8?B?dG1mM01FRTZmQkdjNEJ0emVkS2hwR25wUGZ3YmpEajZIQTM2ZUZCaU42dWk1?= =?utf-8?B?cmVWazRVRlR5SFVYbllhQUdRQjE5czRjNXFiWDlkdVpyU3E4UjR5dHkzVkwz?= =?utf-8?B?eHFRVWJLaHhkQzZMQ2RjR3ZmOVJUREZWeWlQMlRjNjhjaWVqcnNsVDlHeldT?= =?utf-8?B?KzR3SjZybjdEOUFXVU5wM2o2WlJPWkhBSnMwOHA2TXpiR1NBeHlwZDdiSEtS?= =?utf-8?B?b3BnZTZrYUNwdFBxSDg5b1o5ZEJ4a3VDZEpMeTB5bzJvb2VjWUxoeUYrU0JY?= =?utf-8?B?N2RuREJob0NFMUVDc1Noc2hnbW9HQ3ZKN0RNa3FCVEtLRFdOR1REVWZUcVNB?= =?utf-8?B?aUdJQnYxQzZtZUVYODNNb2pFb0VwKzljYUFHVFFFYk01djUvVU13UE1uT1dL?= =?utf-8?B?V1RHN3lCN3ViRFlBbWRDRnpaeEdncFp3VldiTjU4SUZxNjBYbEQ2bGhwWDho?= =?utf-8?B?YVJUMlFSYUZ6NTBUWWdCb3h2UjBOVzlWWi9tWHU4bGlGSlYwMWtqTkdNR1M3?= =?utf-8?B?a0NDYm43QzU4MTU2SVROYnVKZWdEY056aDRXaTdoLzdNb2FKQjAwdnVMRjcz?= =?utf-8?B?aEdrSVZEeWU0Y3pYVUh0cGMwcnJ3N0tjSlY4bzc0cmNIS3ZWMnJoNWxrUWc2?= =?utf-8?B?a3ZlVTJJeUxYWXBkRCtaSDZQdG9QTjdkNk1ZUm1sVlVBQ1RiWFV6N2IxUjdz?= =?utf-8?B?Um1UUGVlekFZU3BFUGJPOTRGWndoT3R2bFVPUVFWVlBXTU9UQ0ZOZlZJa1dG?= =?utf-8?B?T3JBKzJnYzBhaEdNejlUblBTWXJ2RkQ2cXRSUjg3SS9rWDJUSngrZzdNT0l4?= =?utf-8?B?WDRsTnZjRWE1RC9IQjBzb2lveTZCbko5YXdjTS91czNoQzJVLzVyQlloMlUw?= =?utf-8?B?SGN2bGR3MERqTURyUnZObzBmWjB6YkI4Q2FibTRqelBDT3RuenF5djRuZGY4?= =?utf-8?B?OTVZSEpCQVZpZ2ErWmYzWlU1cHdhb1pNQkVzMmhYSDFrUFVTQU8xYmM5amt5?= =?utf-8?B?aDVwenlLWmlub1VFRi9tNGFNa1ZuREkrSVNGTC9jMkFkNG1yWGtUQT09?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5477.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a6745fb9-7320-479b-3eee-08da2910208d X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2022 12:10:46.8533 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: efk3iKe7bn9V4opElbI6lcN94OBZVzSNIRyu6ourW11NMKIurNoLMZrNmSt0vI8XNC0t3unWzJu083PO0fJWtw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6219 LS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCkZyb206IHdpbi1wdi1kZXZlbCA8d2luLXB2LWRl dmVsLWJvdW5jZXNAbGlzdHMueGVucHJvamVjdC5vcmc+IE9uIEJlaGFsZiBPZiBEdXJyYW50LCBQ YXVsDQpTZW50OiAyOCBBcHJpbCAyMDIyIDExOjQ0DQpUbzogd2luLXB2LWRldmVsQGxpc3RzLnhl bnByb2plY3Qub3JnDQpTdWJqZWN0OiBSZTogW1BBVENIXSBNb3JlIElPQ1RMIHBhcmFtZXRlciBj aGVja3MNCj4gQEAgLTYxOCwxMCArNjIxLDEyIEBAIGZhaWwxMDoNCj4gICANCj4gICBmYWlsOToN Cj4gICAgICAgRXJyb3IoIkZhaWw5XG4iKTsNCj4gLSAgICBBU1NFUlQoTlRfU1VDQ0VTUyhYRU5C VVNfR05UVEFCKFVubWFwRm9yZWlnblBhZ2VzLA0KPiAtICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgJkZkby0+R250dGFiSW50ZXJmYWNlLA0KPiAtICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgQ29udGV4dC0+QWRkcmVzcw0KPiAtICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgKSkpOw0KPiArICAgIHsNCj4gKyAgICAgICAgTlRTVEFUVVMgc3Rh dHVzMiA9IFhFTkJVU19HTlRUQUIoVW5tYXBGb3JlaWduUGFnZXMsDQo+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICZGZG8tPkdudHRhYkludGVyZmFjZSwNCj4gKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgQ29udGV4dC0+QWRkcmVzcyk7 DQo+ICsgICAgICAgIEFTU0VSVChOVF9TVUNDRVNTKHN0YXR1czIpKTsNCg0KV2h5Pw0KDQoNCklm IHRoZSBkZWZpbml0aW9uIG9mIEFTU0VSVCBpcyBjaGFuZ2VkLCBpdHMgcG9zc2libGUgdGhhdCBw YWdlcyB3b3VsZCBub3QgZ2V0IHVubWFwcGVkIGluIHRoaXMgZmFpbHVyZSBjYXNlLg0KSXQgZmVl bHMgY2xlYW5lciB0byBtZSB0byBzZXBhcmF0ZSB0aGUgY2xlYW51cCBvcGVyYXRpb24gYW5kIHRo ZSBBU1NFUlRpb24gdGhlIGNsZWFudXAgc3VjY2VlZGVkLg0KDQo+ICsgICAgfQ0KPiAgIA0KPiAg IGZhaWw4Og0KPiAgICAgICBFcnJvcigiRmFpbDhcbiIpOw0KPHNuaXA+DQogDQo+IGRpZmYgLS1n aXQgYS9zcmMveGVuaWZhY2UvaW9jdGxzLmMgYi9zcmMveGVuaWZhY2UvaW9jdGxzLmMgaW5kZXgg DQo+IGE2MjRiZDEuLjIwYTc2NjkgMTAwNjQ0DQo+IC0tLSBhL3NyYy94ZW5pZmFjZS9pb2N0bHMu Yw0KPiArKysgYi9zcmMveGVuaWZhY2UvaW9jdGxzLmMNCj4gQEAgLTQ4LDkgKzQ4LDkgQEAgX19D YXB0dXJlVXNlckJ1ZmZlcigNCj4gICAgICAgTlRTVEFUVVMgU3RhdHVzOw0KPiAgICAgICBQVk9J RCBUZW1wQnVmZmVyID0gTlVMTDsNCj4gICANCj4gLSAgICBpZiAoTGVuZ3RoID09IDApIHsNCj4g KyAgICBpZiAoTGVuZ3RoID09IDAgfHwgQnVmZmVyID09IE5VTEwpIHsNCj4gICAgICAgICAgICpD YXB0dXJlZEJ1ZmZlciA9IE5VTEw7DQo+IC0gICAgICAgIHJldHVybiBTVEFUVVNfU1VDQ0VTUzsN Cj4gKyAgICAgICAgcmV0dXJuIFNUQVRVU19JTlZBTElEX1BBUkFNRVRFUjsNCg0KVGhhdCdzIGEg c2VtYW50aWMgY2hhbmdlLiBEbyB3ZSB3YW50IHRoYXQ/DQoNCiAgIFBhdWwNCg0KQ3VycmVudGx5 LCBwYXNzaW5nIExlbmd0aD0wIHdpbGwgcmVzdWx0IGluIGEgc3VjY2VzcyBhbmQgQ2FwdHVyZWRC dWZmZXI9TlVMTC4gVGhlIG5leHQgb3BlcmF0aW9ucyBhZnRlciBhbGwgY2FsbHMgdG8gX19DYXB0 dXJlVXNlckJ1ZmZlciBpcyBkZXJlZmVyZW5jaW5nIENhcHR1cmVkQnVmZmVyLg0KDQpDdXJyZW50 bHksIHBhc3NpbmcgTGVuZ3RoIT0wIGFuZCBCdWZmZXI9TlVMTCBzaG91bGQgY2F1c2UgUHJvYmVG b3JSZWFkIHRvIHRocm93IGFuIGV4Y2VwdGlvbiwgd2hpY2ggcmVzdWx0cyBpbiBDYXB0dXJlZEJ1 ZmZlcj1OVUxMLCBidXQgX19DYXB0dXJlVXNlckJ1ZmZlciByZXR1cm5pbmcgYSBmYWlsIGNvZGUu DQoNClRoaXMgY2hhbmdlIHdpbGwgZW5zdXJlIHRoYXQgTGVuZ3RoPTAgb3IgQnVmZmVyPU5VTEwg d2lsbCBib3RoIGZhaWwsIGFuZCBhdm9pZCBhbnkgcG90ZW50aWFsIGZvciBkZXJlZmVyZW5jaW5n IGEgTlVMTCBwb2ludGVyIGluIHRoZSBvcGVyYXRpb25zIGFmdGVyIGFsbCBjYWxscyB0byBfX0Nh cHR1cmVVc2VyQnVmZmVyDQoNCg0KT3dlbg0KDQo+ICAgICAgIH0NCj4gICANCj4gICAgICAgU3Rh dHVzID0gU1RBVFVTX05PX01FTU9SWTsNCg0KDQo= From win-pv-devel-bounces@lists.xenproject.org Thu Apr 28 13:02:15 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 28 Apr 2022 13:02:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.316516.535447 (Exim 4.92) (envelope-from ) id 1nk3mh-0007XC-AP; Thu, 28 Apr 2022 13:02:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 316516.535447; Thu, 28 Apr 2022 13:02:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nk3mh-0007X5-7B; Thu, 28 Apr 2022 13:02:15 +0000 Received: by outflank-mailman (input) for mailman id 316516; Thu, 28 Apr 2022 13:02:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nk3mg-0007Wz-LW for win-pv-devel@lists.xenproject.org; Thu, 28 Apr 2022 13:02:14 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6ad15abe-c6f3-11ec-a405-831a346695d4; Thu, 28 Apr 2022 15:02:13 +0200 (CEST) Received: from mail-bn1nam07lp2042.outbound.protection.outlook.com (HELO NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.42]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 28 Apr 2022 09:01:48 -0400 Received: from MW4PR03MB6347.namprd03.prod.outlook.com (2603:10b6:303:11e::22) by DM6PR03MB4028.namprd03.prod.outlook.com (2603:10b6:5:5e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Thu, 28 Apr 2022 13:01:44 +0000 Received: from MW4PR03MB6347.namprd03.prod.outlook.com ([fe80::1c1a:4522:6f0a:df7d]) by MW4PR03MB6347.namprd03.prod.outlook.com ([fe80::1c1a:4522:6f0a:df7d%6]) with mapi id 15.20.5206.013; Thu, 28 Apr 2022 13:01:44 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 6ad15abe-c6f3-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651150933; h=from:to:subject:date:message-id:mime-version; bh=dHdKxTaOcUTfLg4vBv/YVCyX/xj7ovgnL9gbVae9t28=; b=ZaIkhVkVA0jqFWE+QEx1FnOgFavAOZ57JQHobxqhwhWpbI8DB/MocL3e NMD2mBemsaXcxiCSqnrMCBvCGnNct4/b37/pLneTiW/rRsp+OfK5nWkLk 94BD4DkKPthMQegxLN7L77GGKE/wx7YPuy+eu3BtYmcAABhjrvg8cQeh3 M=; X-IronPort-RemoteIP: 104.47.51.42 X-IronPort-MID: 70015920 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:gy9WiqAfwFu/GRVW/3Xiw5YqxClBgxIJ4kV8jS/XYbTApDJ33jNTz GdMUWiEPK2Lajf2e952Ptjk8hwDsZDTn95hQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Jj0tYx6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhPm dVmkYSAezsAHYDXxcM+ViF7ITBxaPguFL/veRBTsOS15mieKT7G5awrC0s7e4oF5uxwHGdCs +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6t/B8yZK0nJzYYwMDMYg8lUAffYI coQcyRifTzLYgFVO0dRA5U79AutrianK2QF+QjNzUYxy1Lf6Bx0/+P/CYfEW/eQGMJX2UXC+ 32TqgwVBTlfbrRz0wGt7XOqw/fR2C/2Ro8WPLm57eJxxk2ewHQJDx8bXkf9puO24nNSQPpaI k0QvyAo9K478RT0SsGnB0Hi5nmZohQbRtxcVfUg7x2AwbbV5ADfAXUYSjlGa5ots8peqSEW6 2JlVujBXVRH2IB5g1rDrd94cRva1fApEFI/ IronPort-HdrOrdr: A9a23:PDTilqG2Mcx8b/bJpLqFapHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskd2ZJhSo6H4BEDgewKUyXcR2+Us1NiZLW3bUQeTTb2KjrGSiwEIeReOkdK1vJ 0IG8cRNDSaNykYsS+O2njcLz9W+qjkzEnHv4fj5kYoaTsvR7Br7g9/BAreOFZxXhN6CZ0wE4 fZztZbphK7EE5nJPiTNz0gZazuttfLnJXpbVotHBg88jSDijuu9frTDwWY5BEDSDlCqI1SvF Qt0jaJqplLgcvLhCM05FWjrqi+X+GRiuerMfb8xfT97A+cyTpAKr4RGYFq9wpF2N1HoGxa6+ Uk5S1QdPibokmhBF2dsF/j3RLt3y0p7GKnwViEgWH7qci8Xz4iDdFd7LgpBicxxnBQzu2U6p g7ql5xdqAncy/ojWD4/ZzFRhtqnk27rT4rlvMSlWVWVc8bZKVKpYIS8UtJGNNYdRiKnrwPAa 1rFoXR9fxWeVSVYzTQuXRu2sWlWjA2Eg2dSkYPt8SJ23xdnWx/zUEf2MsD901wg64VWt1B/a DJI65onLZBQosfar98Hv4IRY+tBmnEUXv3QRGvyJTcZdE60l722uLKCe8OlZyXkbQzveQPsY WEVk9EvmgvfE+rAdGS3fRwg2HwfFk= X-IronPort-AV: E=Sophos;i="5.91,295,1647316800"; d="scan'208,217";a="70015920" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OAmj2yX5ocvgMGaOQEYmlphqxmfrE7sZN5HlMOwyGLMjE9TxPlLJDs2nMc8jq5fjMRc91thoWFNnwV54yv/A7ep6IkR1HBDYI0O3WZf24qcYh8Z7bMl1aWMhRTlpn15E36xqyx/CqKCuM02RJCvAxTm+OFthPxruL/2hEmsquwEDP6I2WMt1LyaUO8T98ILt8C39fD3tQP3ahaAnXUiw9qfRmERE+AVzy78CFd5NGkUXMzc3uoOu2uTgN72SkmyPjT3hWyc+CtfESGEr6FAXJpXiTDOUZMjy19Nd9XZCjWRSQPLgvMZRYvj2N4cyfARKW4Erx8zxX4gKrXhZPGCkYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AWWXzX/R6I0opYthwpkI+scx7T1MZ8nYEbXUywsUqpE=; b=ncURvc97N4pZ7xoAKzNaA26SknO+dQ3w0SI3mrJMfk4vnWkqNa0fqA4NW4TC49zmYgmj5YoiLJ510pfDeuAyhwp/mLmhr3j4HomHJevdLqn1aYwclLtbkPj9MTpzCS39uOHtqMAk9sOmTrOA12oPMhC6+CfwUKxOlOtSmCsFe3TxWWC3C8lBeNClKsQ0liU2h41O40l2aaNMvHtgBMIuB9UzpbIT1UV4Ny1es2ByQmRmnWIXwJvsnCAxpWC8OQiLsbrKZEn1UNdXstuYNeFsRNx7GvURA2LBeszChEFAFnIKOmY/9ZOX/YUJwxq6T53BgxDbiGm3WyRO4UYQhdknKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AWWXzX/R6I0opYthwpkI+scx7T1MZ8nYEbXUywsUqpE=; b=wl87PfOUiLc9LuQd+j7CM7fyc+H8WJjRqjvafhoxnE0jJ5jTBDbTLu5O1MgF2JBQQMj7msi0gAV88QAKS7og2UNDP4Si/KaI8vSHJEnVIdruLyV4ah8TokrqvNt13AoS2zVhuBOHo0t7y9e+oVSHeneJ1TemggFyvTPOTH6EBg0= From: Martin Harvey To: "win-pv-devel@lists.xenproject.org" Subject: RFC Add extra sync release step for late callbacks. Thread-Topic: RFC Add extra sync release step for late callbacks. Thread-Index: AdhbABZj/QTUWYFgSjmTyVfnJrSFdw== Date: Thu, 28 Apr 2022 13:01:43 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a2d9cb22-8c2c-46da-3edf-08da29173eb5 x-ms-traffictypediagnostic: DM6PR03MB4028:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TqESXUMh7VFabLJk7Os/BqE07XRE827TlU2RDNF+QZIeoRO5d4VkXSBy1AkPl5UDFfw4LjaN1TLphb2qZLROmOVERR131QIjehPmVZf39uYuW99lPUbFhBJwMcPhh2NT+jtfNGoreRdmpbAyBUo6TKEozYrXJE6Otr1ceJMgEBQe4yQpp/LdKTTEd8Pp26YrXaUC4E5/VYjtDX8mGxLMwr4jHqHs9iO0kD3KBS0Qx8MdYQ7agB0vZYm5nf9dTO5ws0pI4JaGXV+FPyszbrdUOqpA3WVi5Kaj95o1bqRq1soF1j2pVWipdy/95eSI9FWgA2MHBjqv6XzdWWun7PpOcVB35wVDaRQBYs0/Ph529VI1LQNG0lO5TL3r5kRqnlFXxhPvAc5HLOSHDgHq0V9Zl/LeOJ7Rp4SUjvh3Yr5oWoian58Q2UYWokGoxMenO+m2yMGLQ3kLPiCXhz6JUrAftM9ZuMQ3wl6Oqqa3511dSeWMbJWZqFOO3Ka32cj44K2jNGhj6yuXI5NB4q26yT1xhUw+dZAeXinZMAKNumLzjU6Q0SOP8E1tYU5zoLPTSY4nfDLyMYM9P7+jiUX5JTlnzYlv8x9qW7jAJJEv/CFP4QrUvlavp3KcQfwVhoq60sUSb8xLePs4VKNIWUX6bntqumZAYfgU/5zi2ixsFJcIUePe2LXB/at2dYBxMmnM7sH+jE9NIRGPsskkzvYZQP8HgQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6347.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66476007)(64756008)(8676002)(186003)(83380400001)(6916009)(33656002)(66446008)(6506007)(53546011)(55016003)(26005)(66556008)(5660300002)(8936002)(76116006)(66946007)(316002)(82960400001)(122000001)(508600001)(7696005)(71200400001)(44832011)(2906002)(86362001)(38070700005)(38100700002)(52536014)(9686003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hBcMdkgMlKZjlKt7ZfhSTkWCgAuKgC32YbNpzQf6wy+GN8dO4Wbp8Ba0q/ET?= =?us-ascii?Q?eez19pJlESaEnYC0ukf+fWkv2JvFkPtkvBQR+tfvJ7RnPP+qP9jAE1OXstiW?= =?us-ascii?Q?fH8eRS8ZEd0W/M3elejYXgl4eDzPXO3Z0bl/PGrk43mal33+jkUK+AAKFj1K?= =?us-ascii?Q?9yIYTviYSueUGC/bBhVl7yqxzNHrqE0wZPSZTX9kNvitoV6gKMJnPp/XJeWk?= =?us-ascii?Q?9/jxuckw665KycwpLpq/8Z+e/Mg7EqLHesZkc9pr+4anuHGuv78qQehWUbhK?= =?us-ascii?Q?9zcNdqcvxwhAkm+lqKMuM/Fx885vgSw1KfKu5LbwjOWJfJ8TSzQbSinjD78L?= =?us-ascii?Q?lohUpO8Xj8lOJF+gXxErs4EztZ5EQIrSEp9K1QNQywFIB2zkvE1uKHIpLDb9?= =?us-ascii?Q?VJ1y+tmC5cQRWEuLUstchq88OOFiPQti8e5qU2D91x7k4nUifmd0NzaJ8I9a?= =?us-ascii?Q?Dw0099r32s6lqrfXrJ7eVDn24DMWb4NT284woW7Khy3PdXMSeoOM5D8N1Ysr?= =?us-ascii?Q?ubZYwS1lduZ9bQfNQIhFxi9LSl5a7UIz9zeWwd3tJ2ZJJ0KeWfqXTyIP4lXW?= =?us-ascii?Q?z3ZN84llkU2pLJWNIZWewchZXapLcCumbRVN4m+tJU0bvq5p53pGoeJJRLt6?= =?us-ascii?Q?9ZxXWh1kMzT5rNdF0bWJCeVLorOj22FVR8KI8TMQX3Ubci83n7BwJ5KXuvhs?= =?us-ascii?Q?zZvpoHOd53S3kl54vNEX3IUZz1mZu8dSbZVqeoIyXcaJkqbgOZaZKxxMDuiW?= =?us-ascii?Q?6O3KcASW4yQhtUKIp5dIO1gLTtTY1fg9fEwr90s+FKhQVIDGL/O1bET45UmC?= =?us-ascii?Q?lluBv1TuLqtGDu4e87uMRNE6cnRqfkNAevEEc2rZ0LJ3lebFXSQ/PR9Np9OB?= =?us-ascii?Q?W9aVc5xZEhpVlqyRQZhc36YMGAshrLWxKuge8PZ0EgQZxHVULf+gGRMSi3eN?= =?us-ascii?Q?7wKczGp9AvhljE6gM93gjbkkvOXCjK/hE8YCACi7UfI5GnpGFniJEkQ3/gIk?= =?us-ascii?Q?NQ6jnF/Pted5trZjneXJYIS1mF+G58k9guv4AFy9iy50NbKhTfpdzO63cJ/B?= =?us-ascii?Q?rN8+lPvLc6Jk/EJGZb3k+UK3n8Fc8AJHouqMHndwrGLnvkf+gLZQLDammxN7?= =?us-ascii?Q?a4qP2EI8AvHYp2gVCvcgCoyy9NMwuXD7H+gCjefEvT+u3S6R6JEkIMFA720x?= =?us-ascii?Q?fs/0FnYr1iEvVnV1mrKBbae49xlcmYrvhJcaFzTrd0IOWJ0nm0OzK9YPyQeH?= =?us-ascii?Q?e936kus2CHib/Mov6T8RsiVjuhunVSZyM0duM9vvAwzGdVyR5SWDAMg2lOg0?= =?us-ascii?Q?3EFq479/9PxuaA4v//PbZya4nuAga4Ymnw6QIlzBlcrF69QfB9v7p0WaDO6d?= =?us-ascii?Q?J/J22dCNYeKMlUdIl4+J4LmRQV9FB2azXHa8R7ityowFagqpdD2U/PeVLNb7?= =?us-ascii?Q?REoGoxt7aUJBdmQBB3/FDiErsiYmGR4ax3PBdqTV9ZNhkUA6sfr0ziL5UFqT?= =?us-ascii?Q?BIdGR5H876R3KSjHqGvapc1qDmGibJd/+sPcLgDpbj7/jKNp+B9tze6GIVZv?= =?us-ascii?Q?OMIXde7vz4mZiUgX6SwsecyB6RKcgwfayN6Vdzm7Isxs6YEny5Dgulpr0DO0?= =?us-ascii?Q?t6PJfBKcmR4GfBEIYnyY8GiaV26HIuimkUEt/UlpJ73Y84XpY7wWhOh2luTN?= =?us-ascii?Q?pKMB2qFSwAKezCJLW+uJvH/5JWAK3ojDcZKzkH+dIoRuvXZUSqeVKTXsP7Lr?= =?us-ascii?Q?UK5cOvYAwaMOruYFM+IZGP6afUDE10k=3D?= Content-Type: multipart/alternative; boundary="_000_MW4PR03MB63479B3BA6D20A280C1C3C099AFD9MW4PR03MB6347namp_" MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6347.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a2d9cb22-8c2c-46da-3edf-08da29173eb5 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2022 13:01:43.9242 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: av4AmxgSfz1A+wE55t5kMTTBoWrBmpJLOtUgMrhUK+wb6djoOxQUaVxe8HM5b2417Ffi/qfwvSsFiBEb7Jq36yhCnzDDEFpuHKoUyfWf1Cc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4028 --_000_MW4PR03MB63479B3BA6D20A280C1C3C099AFD9MW4PR03MB6347namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable This patch for RFC. I think it solves some longstanding suspend/resume issu= es we have had. MH. >From 5b4cff54f026917d234718976e791717ece474c4 Mon Sep 17 00:00:00 2001 From: Martin Harvey Date: Thu, 28 Apr 2022 13:52:40 +0100 Subject: [PATCH] Add extra sync release step for late callbacks. Signed-off-by: Martin Harvey --- src/xenbus/sync.c | 42 ++++++++++++++++++++++++++++++++++++------ 1 file changed, 36 insertions(+), 6 deletions(-) diff --git a/src/xenbus/sync.c b/src/xenbus/sync.c index 615eca8..8f25ea4 100644 --- a/src/xenbus/sync.c +++ b/src/xenbus/sync.c @@ -82,7 +82,8 @@ static UCHAR __Section[PAGE_SIZE]; typedef struct _SYNC_PROCESSOR { KDPC Dpc; BOOLEAN DisableInterrupts; - BOOLEAN Exit; + BOOLEAN ExitLate; + BOOLEAN ExitFinal; } SYNC_PROCESSOR, *PSYNC_PROCESSOR; typedef struct _SYNC_CONTEXT { @@ -143,6 +144,7 @@ SyncWorker( ULONG Index; PSYNC_PROCESSOR Processor; PROCESSOR_NUMBER ProcNumber; + ULONG Sequence; UNREFERENCED_PARAMETER(Dpc); UNREFERENCED_PARAMETER(_Context); @@ -160,9 +162,7 @@ SyncWorker( InterlockedIncrement(&Context->CompletionCount); for (;;) { - ULONG Sequence; - - if (Processor->Exit) { + if (Processor->ExitLate) { if (Context->Late !=3D NULL) Context->Late(Context->Argument, Index); @@ -242,10 +242,18 @@ SyncWorker( } } - Trace("<=3D=3D=3D=3D (%u:%u)\n", ProcNumber.Group, ProcNumber.Number); + InterlockedIncrement(&Context->CompletionCount); + + while(!Processor->ExitFinal) { + _mm_pause(); + KeMemoryBarrier(); + } + InterlockedIncrement(&Context->CompletionCount); ASSERT(!InterruptsDisabled); + + Trace("<=3D=3D=3D=3D (%u:%u)\n", ProcNumber.Group, ProcNumber.Number); } __drv_maxIRQL(DISPATCH_LEVEL) @@ -443,13 +451,35 @@ SyncRelease( if (Context->Late !=3D NULL) Context->Late(Context->Argument, SyncOwner); + /* First wait to make sure all late completion callbacks are done befo= re spinning released. */ + Context->Sequence++; + Context->CompletionCount =3D 0; + + KeMemoryBarrier(); + + for (Index =3D 0; Index < Context->ProcessorCount; Index++) { + PSYNC_PROCESSOR Processor =3D &Context->Processor[Index]; + + Processor->ExitLate =3D TRUE; + } + + InterlockedIncrement(&Context->CompletionCount); + + while (Context->CompletionCount < Context->ProcessorCount) { + _mm_pause(); + KeMemoryBarrier(); + } + + /* Second wait to make sure all spinning DPCs release before proceed. = */ Context->Sequence++; Context->CompletionCount =3D 0; + KeMemoryBarrier(); + for (Index =3D 0; Index < Context->ProcessorCount; Index++) { PSYNC_PROCESSOR Processor =3D &Context->Processor[Index]; - Processor->Exit =3D TRUE; + Processor->ExitFinal =3D TRUE; } KeMemoryBarrier(); -- 2.25.0.windows.1 --_000_MW4PR03MB63479B3BA6D20A280C1C3C099AFD9MW4PR03MB6347namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

This patch for RFC. I think it solves some longstand= ing suspend/resume issues we have had.

 

MH.

 

From 5b4cff54f026917d234718976e791717ece474c4 Mon Se= p 17 00:00:00 2001

From: Martin Harvey <Martin.Harvey@citrix.com>=

Date: Thu, 28 Apr 2022 13:52:40 +0100

Subject: [PATCH] Add extra sync release step for lat= e callbacks.

 

Signed-off-by: Martin Harvey <martin.harvey@citri= x.com>

---

src/xenbus/sync.c | 42 +++++++++++++++++++++++++++++= +++++++------

1 file changed, 36 insertions(+), 6 deletions(-)

 

diff --git a/src/xenbus/sync.c b/src/xenbus/sync.c

index 615eca8..8f25ea4 100644

--- a/src/xenbus/sync.c

+++ b/src/xenbus/sync.c

@@ -82,7 +82,8 @@ static UCHAR   &nbs= p;    __Section[PAGE_SIZE];

typedef struct  _SYNC_PROCESSOR {

     KDPC    = ;            Dpc;

     BOOLEAN    &= nbsp;        DisableInterrupts;

-    BOOLEAN    &= nbsp;        Exit;

+    BOOLEAN    &= nbsp;        ExitLate;

+    BOOLEAN    &= nbsp;        ExitFinal;

} SYNC_PROCESSOR, *PSYNC_PROCESSOR;

 typedef struct  _SYNC_CONTEXT {

@@ -143,6 +144,7 @@ SyncWorker(

     ULONG   &nbs= p;           Index;<= /o:p>

     PSYNC_PROCESSOR  =    Processor;

     PROCESSOR_NUMBER  = ;  ProcNumber;

+    ULONG    &nb= sp;          Sequence;

     UNREFERENCED_PARAMETER= (Dpc);

     UNREFERENCED_PARAMETER(_Con= text);

@@ -160,9 +162,7 @@ SyncWorker(

     InterlockedIncrement(&C= ontext->CompletionCount);

     for (;;) {<= /p>

-        ULONG&nb= sp;  Sequence;

-

-        if (Proc= essor->Exit) {

+        if (Proc= essor->ExitLate) {

        &nbs= p;    if (Context->Late !=3D NULL)

        &nbs= p;        Context->Late(Context->A= rgument, Index);

@@ -242,10 +242,18 @@ SyncWorker(

         }

     }

-    Trace("<=3D=3D=3D=3D (%u= :%u)\n", ProcNumber.Group, ProcNumber.Number);

+    InterlockedIncrement(&Contex= t->CompletionCount);

+

+    while(!Processor->ExitFinal) = {

+        _mm_paus= e();

+        KeMemory= Barrier();

+    }

+

     InterlockedIncrement(&C= ontext->CompletionCount);

     ASSERT(!InterruptsDisa= bled);

+

+    Trace("<=3D=3D=3D=3D (%u= :%u)\n", ProcNumber.Group, ProcNumber.Number);

}

 __drv_maxIRQL(DISPATCH_LEVEL)

@@ -443,13 +451,35 @@ SyncRelease(

     if (Context->Late !=3D N= ULL)

         Con= text->Late(Context->Argument, SyncOwner);

+    /* First wait to make sure all l= ate completion callbacks are done before spinning released. */

+    Context->Sequence++;

+    Context->CompletionCount =3D = 0;

+

+    KeMemoryBarrier();

+

+    for (Index =3D 0; Index < Con= text->ProcessorCount; Index++) {

+        PSYNC_PR= OCESSOR Processor =3D &Context->Processor[Index];

+

+        Processo= r->ExitLate =3D TRUE;

+    }

+

+    InterlockedIncrement(&Contex= t->CompletionCount);

+

+    while (Context->CompletionCou= nt < Context->ProcessorCount) {

+        _mm_paus= e();

+        KeMemory= Barrier();

+    }

+

+    /* Second wait to make sure all = spinning DPCs release before proceed. */

     Context->Sequence++;

     Context->CompletionCount= =3D 0;

+    KeMemoryBarrier();

+

     for (Index =3D 0; Index <= ; Context->ProcessorCount; Index++) {

         PSY= NC_PROCESSOR Processor =3D &Context->Processor[Index];

-        Processo= r->Exit =3D TRUE;

+        Processo= r->ExitFinal =3D TRUE;

     }

     KeMemoryBarrier();

--

2.25.0.windows.1

 

--_000_MW4PR03MB63479B3BA6D20A280C1C3C099AFD9MW4PR03MB6347namp_-- From win-pv-devel-bounces@lists.xenproject.org Thu Apr 28 15:24:12 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 28 Apr 2022 15:24:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.316628.535602 (Exim 4.92) (envelope-from ) id 1nk602-0002j5-0f; Thu, 28 Apr 2022 15:24:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 316628.535602; Thu, 28 Apr 2022 15:24:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nk601-0002iy-TQ; Thu, 28 Apr 2022 15:24:09 +0000 Received: by outflank-mailman (input) for mailman id 316628; Thu, 28 Apr 2022 15:24:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nk600-0002im-I8 for win-pv-devel@lists.xenproject.org; Thu, 28 Apr 2022 15:24:08 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3c0c6ac9-c707-11ec-8fc3-03012f2f19d4; Thu, 28 Apr 2022 17:24:07 +0200 (CEST) Received: from mail-bn8nam12lp2173.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 28 Apr 2022 11:24:01 -0400 Received: from MW4PR03MB6347.namprd03.prod.outlook.com (2603:10b6:303:11e::22) by DM6PR03MB3596.namprd03.prod.outlook.com (2603:10b6:5:b2::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Thu, 28 Apr 2022 15:23:59 +0000 Received: from MW4PR03MB6347.namprd03.prod.outlook.com ([fe80::1c1a:4522:6f0a:df7d]) by MW4PR03MB6347.namprd03.prod.outlook.com ([fe80::1c1a:4522:6f0a:df7d%6]) with mapi id 15.20.5206.013; Thu, 28 Apr 2022 15:23:59 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 3c0c6ac9-c707-11ec-8fc3-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651159447; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=0Xfsgf1FYJzszPh4vYOp1eD1thLljKz7d9DGqogpRPI=; b=Dzr2z4uNTJ1beKtftHjjt3K0Co6yWXbPrL8I3eWfcazMK8j0QK7SnW0o 4TRBRk9R4DHE5cifPBMk6U/iIJ/FcoT80zTtzjWNZIclRJ1gKydGbxejz Bz6sX8GE3zoETSeSCflzM1lr8Hf5bzBHG+3xzKp5zc5L0v/DnObj/lQ99 w=; X-IronPort-RemoteIP: 104.47.55.173 X-IronPort-MID: 70173219 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:aChtda6ziwZGuGdXqZjCAAxRtFrGchMFZxGqfqrLsTDasY5as4F+v mEYCG6Obv6Oa2SkctFxaYXjpxhSuZCDztcwHgo4q3w2Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YTjU1vU0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurT3bQcLJJePtt1abDd9AihhE6Nq2LL+dC3XXcy7lyUqclPK6tA3VgQcG91d/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfiXo4YHh1/chegXdRraT 88QcyZualLAagdRN0Y/A5Mihua4wHL4dlW0rXrK/fNouDKKnWSd1pD0KvnNSsCRaf9xk1qdl kjF51TEDwgFYYn3JT2ttyjEavX0tTvyRYY6BLC+sPlwjzW72W0VTQUIEFe2v/S9okq/QM5Eb VwZ/DI0qqo//1DtScPyNyBUu1aBtx8YHtBWQ+sz7VjXzrKOulnCQG8ZUjRGddoq8tcsQiAn3 UOImNWvAiFztLqSSjSW8bL8QS6OBBX55FQqPUcsJTbpKfG4yG3vpnojlupeLZM= IronPort-HdrOrdr: A9a23:teDnSajavAaV6e0A73VJL8U6enBQX2513DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQJVoMkmsjqKdhrNhd4tKPTOW81dASbsP0WKM+UyFJ8STzI9gPO JbAtFD4b7LfBVHZKTBkW6F+r8bqbHpnpxAx92uqUuFJjsaCJ2Imj0JbzpzZXcGJjWua6BYKL Osou584xawc3Ueacq2QlMfWfLYmtHNnJX6JTYbGh8O8mC1/HyVwY+/NyLd8gYVUjtJz7tn23 PCiRbF6qKqtOz+4gPA1lXU849dlLLau5V+7Y23+4kowwfX+0WVjbdaKv+/VfcO0aSSAWMR4Z nxStEbToBOAj3qDyaISFDWqnPdOX4VmgLfIBmj8DfeSIXCNU4HItsEioRDfhTD7U08+Nl6za JQxmqc84FaFBXagU3Glq71vjxR5z6JSEAZ4JkuZr1kIPsjQa4UqZZa8FJeEZ8GEi6/4Ic7EP N2BMWZ4PpNa1uVY33Qo2EqmbWXLzwONwbDRlJHtt2e0jBQknw8x0wExNYHlnNF8J4mUZFL6+ nNL6wtnrBTSc0da757GY46MIKKI32IRQiJPHOZIFzhGq1CM3XRq4Tv6LFw/+2ucIxg9upGpH 0AaiIriYcfQTORNSTV5uw1zvnkehTNYR39jsdD+pN+prrwALL2LCzrciFcr/ed X-IronPort-AV: E=Sophos;i="5.91,295,1647316800"; d="scan'208";a="70173219" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QMn2XE0c9lHNaVjp9ddEsDOUGMutbwalXNDJTQVUKtbzdJ4QFFxaaTnk7i4AwaRLa/WWtqYBkUDQHDaGlzK0Gz8jp7cmQj/g5jji2JqTg9KW1jCM7yUeKSzk1+ZwO8qQDhdrz0CqPT57pbk8WP+5aNhTt+PnRSgpipYvBvyULRCqKb9aFRErRbJ8kJGzy4wKzuLSbxcFJ9xs8DTws+a/zqc2jK+FfbmfZCYim/Sd31+GdZTXIeFLxwGRDti113qTdGZxohIeD6FKhjsZo2sc2J/BDmpwfyhuV8OCX7uvHV95J2JT1FJQl6zD+4Za+18v6r6+dXJQF1CLCracffMUwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0Xfsgf1FYJzszPh4vYOp1eD1thLljKz7d9DGqogpRPI=; b=NfNHBAKcFTzR/jjLXGjaXaGlF9izgIQGceuBiqj04Ge3jmW+mYasOEDyzHzSdu20G8aujr1DCYp7xC4OmXSxy0nh3FNglthdXEVHNxp4YIUD2wHRqqqvR31YvXzlCBk0o+owdivdotn/v7GzVTdFPRMG1D0JHajSs65or9upFlAj2g1lp1fE2MEmUFCYQAItE36G5qGOZbQKC1zWmCs3q+0OzQvNLMxqJfC5gNoGUvIW7XGZzbKYv3PBTBKCflfTq1p5D6clthhdaqApNqby9pgiHPCrjHZp5uNysnCp0DQLlA+8YI0rHA56UKodT3V27Ub61K6FO9Frb2YvotV4vQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0Xfsgf1FYJzszPh4vYOp1eD1thLljKz7d9DGqogpRPI=; b=EMw9roGVLOdB4XeyBLutIsn5vLv8+ES6dFX6szBkCBMZSCWsdod5bEXB5ai+LcUWvG4XgCNgxw1ShuUrAgAmKDrfZojZWlcOOecxPkzbse5PQQS+SKo1mB+f2g1HzY3GRnAdgLjLkMVL8qs8Vsi5KprV3hVCRkQy13MyeVKAd/k= From: Martin Harvey To: "paul@xen.org" , "win-pv-devel@lists.xenproject.org" Subject: RE: XenVif div by zero on Tx path after resume. Thread-Topic: XenVif div by zero on Tx path after resume. Thread-Index: AdhP6kAbDA19BbYtRECv6F4UUU/GxAD72daAAGmnvwAAAFp2cAAAUguAAC/5hJAAAFZNAAAAMhEAAANPABAAADUugAAAE7WQAIxlHgAAo7ANAA== Date: Thu, 28 Apr 2022 15:23:59 +0000 Message-ID: References: <55d61956-1a0c-c4e9-cb79-ff24c3433ad1@gmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 01ee6ff3-49e4-4fa7-a723-08da292b1e13 x-ms-traffictypediagnostic: DM6PR03MB3596:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eHEe8D3PeIriMHpnfPskf1AUyQJ55ngsFFUuyCS1XUYDCvNnwEOO6Yj8sGYsJ51+0FBNFjh64UUmgU6SL14q+KHMZcoVYfor7IPc7mJkF9UHQ8SUKyzFTXn6DshD2ZzV07uzysF8FlDT16nFvSqJ4cc0HjSsAfP31SJ6UwF7pLIBMrPK9UIEXJrkJ9gagFNyGscolRLZacS62ouVJeEPuRn7W50wF/eOv+qFdZwyS+vIclTIgDLEDbR75yszmTFaFEIO5lTW93GooBa6BuemmjusbtHDFH6qq5QyyRml5mVA6sTaP6HwfgPO51Ki3Tr8k9/E6rDUqeH4IBRP1qy3OuG0PXq01+TBKL2uwGauwwXDIcdon8lihVX+ZfS9K0aApG7qXP7jaQN5yLjkRart2TLpPTa05O4inrqJIA4HrlFtBuVvRx11L914KOtFhYIMOtXPAIGrUU2HIO844TdFqDFO1XxUUZ/ZwwN/wD+xtbaU0cbjC6BrIrOo7MiImpaMKsE8oMaXuHiIHN3ZYgdXvt2q3sCBBX6t6sl3pnj+MGxTMhUL8Xtp2FWyN0aeV7BW7O/YkpIh2NKekjKHwXhdG8/jBQnmzQCaN8BvmwyVr8WDu90qboLj2+QZnkhuaVuBEYFU26DHMVyyi3F5lYe80pel4TvEkAKvdL9cCekXUG/4Y4RrYHiGlABGIm6KcwkSUVUT0UpiVaMNJRauXPNsbA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6347.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(44832011)(33656002)(55016003)(5660300002)(66946007)(76116006)(4744005)(66476007)(316002)(66556008)(7696005)(186003)(52536014)(83380400001)(8676002)(66446008)(64756008)(8936002)(110136005)(86362001)(71200400001)(508600001)(82960400001)(38070700005)(38100700002)(26005)(122000001)(9686003)(53546011)(6506007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NDFINWllZVkvMTZkWW5HZ0hrQmNnTitmSkVCclJEbmZaalh6YmFKVDFqR0JS?= =?utf-8?B?ZTRiQldxNExhY3UvSlJEb2lPdzVkTW9TbEt6QlY3b2dQUFJsN2U3RHFzN2gv?= =?utf-8?B?T3YxVnJuZVdKd1djVmJ5R21lZ2VsSVVmTCt5UlhHOFk5NUE3MkU3b2JXSW13?= =?utf-8?B?VEpOa2o0Z3BvUlZSSzkycVJEdG8wZnRLckg0dGlpQVNlVjBlTCtPMERRVE1C?= =?utf-8?B?bmxlZ1g0TTNEcHJKV3RLa2tOcGR0MFlxWUZlR3N5emc3ajhMcjMzRDkrYVVz?= =?utf-8?B?QVNabE80ZEk0dWRYVXVrSmhmU0E2YlJOVThTaFU4ZzVKZmdLd2V5ZE52ZFln?= =?utf-8?B?bTIzZ3R5NTAyRDd5aWdkOTRyVWZNZWwwVTQyeWZpRXFtT3hiK0tYM1cwS1dN?= =?utf-8?B?TDAySlhJWWJiNjJZcCtjWjFoTkRQVDV0bHh5NG9TUzVtMGVDNmJxeHd1Y3JV?= =?utf-8?B?dUdIZERTYTQ3U3JTL3JVSE51TTNrTkdjMjBoS1pjQklLOVBiSHZXaGNmMnZP?= =?utf-8?B?UjI3YjhWOVRlUndDQlF1K3UyUTNIcnljcW9CdWF2R3ZMalNyUnQ0dG5tL01N?= =?utf-8?B?QnppWW52bklERkVLc1R6ZWZ0OFIyQVNNQmNKTUhuTVd1dDdTTXA2QjVlcmg0?= =?utf-8?B?SlNTYXkzT3lsMXYrMVJlVHlzY2hPY2x3S0VQYWR4WVJVTDYvYWJ3anlXanJo?= =?utf-8?B?YWRjLzQySlJsOTFWRURBejNyNS8xdUo5R3NpYko2ZDR1RCsrYXFYVmNHWEpQ?= =?utf-8?B?R3RPTEttamZVRjlVS1M0eHE1d29qdzRuNlVQQWk4aW9PT2QvZG5MeG9tbFAz?= =?utf-8?B?ck5nVVBSdkgzRWhsakxaUmRwbXR5S09NdlFkU0I3WnpQYnE1RlFWdjY2eVdr?= =?utf-8?B?YnFoUXlaTUlLSjFRbVZ4Njlva0YvWmMxTkU5ekR0Skw1ZDYyM0UwZWNwOTNw?= =?utf-8?B?b3ZjV01TaHZPY1oxcGh1T2pOWjRidnlkL2pZYmUxU2pKQnVTeGEzT2FKZDUx?= =?utf-8?B?TGFTT1pmUDgzQ2ROWXdVUTFqWml2Zm5KeVY2MExMMGVrT1IxMkdkYmNMWFBu?= =?utf-8?B?SGsxK0Q5RW00NGpsNkQ2dnlsMXNQTmJ3ajhDOStVUFdVU1ovdW1QZzVQa01Z?= =?utf-8?B?NUI1elRITnV5WktsQjB6dWQ0ZnFlQ2IrejVwOXFTQWxVdWYvUHV2aWdRSDQ0?= =?utf-8?B?Zmx5Qk5Pb1FjUGRFaHlIaDVCUVVxbVRoTWNocHNVcVR0QnpGQXp6TGd2TUVj?= =?utf-8?B?bzZ0R3lQN2ttc2JnbVN3RzZycVpQTnQxSFlxaTVSVm4wOHcrQmN5M0xMYkRw?= =?utf-8?B?NDdLZCtyNTJ6RjhXY1ZRc213V3ZkNi9DV0VDSHlBMXowQU85ZjFIQU5zK3Uz?= =?utf-8?B?QVRPOFgyL0pIaEd0ZGlNRGN1RnlpS1pBMjVpWDVVZk1rUnJvMlBkUWt0bjdL?= =?utf-8?B?Ylp0Qmcxd0xDOXQzTlNQUWw3Z2Q4QWJKNnhvTSt2NEV1azhYN0pnS1ZKVkdi?= =?utf-8?B?c2cwL2FGOWE5MGlzUVlIU3ZhcnRsa29HWG9zWEFqVlhTZndzNHBWRmErNGdl?= =?utf-8?B?THRFK0s2WE92YVdCdjdYOFAyR1JvNlVkTXVOUHFEbjhmSDR5cUtZWmVvWC9m?= =?utf-8?B?bENmOU9ldTN6ZmZObnRydjlHM1hXRm5GVm9xaExVOGxjdlF6U1U3a2FHeGlG?= =?utf-8?B?M3ZTbHNoZjIzemFKUThTVXprcWUrNkduOW5tZ0FCeTI2ZjFCWmVIaDJKbGgy?= =?utf-8?B?Z2Nud1B5WFFCUjdGSXFwTUZ1N3BDVjUydDhkanJQdkY2cUJyaWJmK0lsWEdq?= =?utf-8?B?WEhZeWhGR200aXVoRExicE9XdFgzRnBDbzdaTmN4ZXlleEp2cFV5ZWJ3cC9m?= =?utf-8?B?MGM3TmZKSUowcisvcVgzY2lrYVhZRlJDNGw2eFR3dG9wWXBTbXJHaXowZ3Zk?= =?utf-8?B?d0hsWWtncmE1c3hhTXJBUkJpd2lxTEs4ZEo2N2N0T21OUm5NQUFFZU5hQklB?= =?utf-8?B?SzRaQ1dxY0h3TG9rdDNyL1haK3pCWWVDc3V2Y1h4Vm1HN0NsbVVRVUJkTGJC?= =?utf-8?B?TmJpRmt6NDBlSWVyZ2dZNjBKQ0RtM2J5YjEzU3duV2hDOFFtTHJyTmtWS3Ja?= =?utf-8?B?d0lYQjZUK0VnUXE0OVFSM1M1REhxOGhWL1BuajN6R0lRc2ZnanJ2ZnpRYXV6?= =?utf-8?B?UnpuRUlXYmt4RThOR3NWSUk4aGtDbnNrWUpYMGtSS3VLK28vaWJMUXBvUE5y?= =?utf-8?B?c1JjUjkrMGt6WHRiMDZ5TE9EaUdyTk54U2IvZTBYaUZ1ODh1Z1ZHWk16RUY1?= =?utf-8?B?dzdSK0Izc3loWFNmbXlqN0ZMR0UyRUZQV3Nha2k3anBUbnIyMG9EQjZjb1Rz?= =?utf-8?Q?bObBYOlZD5FpukBw=3D?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6347.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 01ee6ff3-49e4-4fa7-a723-08da292b1e13 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2022 15:23:59.0971 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Bn7Gp7B+0yg7mnJ1UWQ3Pg6dWg1LKdF5tBsZ3i/PCQtq7rcbINox0vMMFCRuc8YOo1BCRmml2eyPyerHbNekKM0zaIiRABSgVhRztGDLRNo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3596 DQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBEdXJyYW50LCBQYXVsIDx4YWRp bWduaWtAZ21haWwuY29tPiANClNlbnQ6IDI1IEFwcmlsIDIwMjIgMTA6MTUNClRvOiBNYXJ0aW4g SGFydmV5IDxtYXJ0aW4uaGFydmV5QGNpdHJpeC5jb20+OyBwYXVsQHhlbi5vcmc7IHdpbi1wdi1k ZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KU3ViamVjdDogUmU6IFhlblZpZiBkaXYgYnkgemVy byBvbiBUeCBwYXRoIGFmdGVyIHJlc3VtZS4NCg0KPiBJdCB0aGVuIGNhbGxzIFN5bmNSZWxlYXNl KCkuIFRoaXMgcnVucyB0aGUgJ2xhdGUnIHN1c3BlbmQgY2FsbGJhY2tzIGFuZCB0ZXJtaW5hdGVz IHRoZSBEUENzIG9uIG90aGVyIENQVXMsIHRodXMgYWxsb3dpbmcgdGhyZWFkcyB0byBiZSBzY2hl ZHVsZWQuIEl0IHRoZW4gbG93ZXJzIElSUUwgb24gdGhlIGN1cnJlbnQgQ1BVLCB3aGljaCBzaG91 bGQgbWVhbiBhIGZhbGwgYmFjayB0byBQQVNTSVZFIGFzIFN1c3BlbmRUcmlnZ2VyKCkgaXMgb25s eSBldmVyIGNhbGxlZCBmcm9tIHRoZSBkZWRpY2F0ZWQgdGhyZWFkIChydW5uaW5nIEZkb1N1c3Bl bmQoKSkuDQoNCk5pY2UgdHJ5LiBUaGUgbXV0dWFsIGV4Y2x1c2lvbiBmb3IgdGhlIGxhdGUgY2Fs bGJhY2tzIGRlcGVuZHMgb24gdGhlIG90aGVyIENQVSdzIHN0aWxsIHNwaW5uaW5nIGF0IGRpc3Bh dGNoIC0gc2luY2UgcGxlbnR5IG9mIG90aGVyIG5ldHdvcmsgcHJvY2Vzc2luZyBhbHNvIGhhcHBl bnMgYXQgZGlzcGF0Y2guIFlvdSBuZWVkIHRvIGNvbXBsZXRlICphbGwqIHRoZSBsYXRlIGNhbGxi YWNrcyBiZWZvcmUgcmVsZWFzaW5nICphbnkqIG9mIHRoZSBDUFUncyBmcm9tIG91ciBEUEMuIE9u ZSBtb3JlIHN0ZXAgZHVseSBhZGRlZCBpbiBSRkMgcGF0Y2guDQoNCk1ILg0K From win-pv-devel-bounces@lists.xenproject.org Thu Apr 28 15:54:02 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 28 Apr 2022 15:54:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.316667.535657 (Exim 4.92) (envelope-from ) id 1nk6Sw-0007rM-AU; Thu, 28 Apr 2022 15:54:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 316667.535657; Thu, 28 Apr 2022 15:54:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nk6Sw-0007rF-7A; Thu, 28 Apr 2022 15:54:02 +0000 Received: by outflank-mailman (input) for mailman id 316667; Thu, 28 Apr 2022 15:54:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nk6Su-0007o9-Ib for win-pv-devel@lists.xenproject.org; Thu, 28 Apr 2022 15:54:00 +0000 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [2a00:1450:4864:20::432]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6b14e6b2-c70b-11ec-8fc3-03012f2f19d4; Thu, 28 Apr 2022 17:53:59 +0200 (CEST) Received: by mail-wr1-x432.google.com with SMTP id s21so7335954wrb.8 for ; Thu, 28 Apr 2022 08:53:59 -0700 (PDT) Received: from [10.7.237.11] (54-240-197-227.amazon.com. [54.240.197.227]) by smtp.gmail.com with ESMTPSA id n38-20020a05600c502600b00393d946aef4sm4282933wmr.10.2022.04.28.08.53.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Apr 2022 08:53:58 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 6b14e6b2-c70b-11ec-8fc3-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=qBitOw0HNJiVJDTO9CmkL2ysr5NH1PjiQQQIJzuyEh4=; b=DFiUGxWkfh/QkB1O8/ilFmTVyDFV3RNxr13ePGFg8jrYx4E1rH9UnyHcv3CXNPgIUy 2/TkLtbPxh28UBjYL2JzVbwJc3QDgvYai7mh0vM/rhgN+iwDXUlVj55FkWgvS45J7bCB L1DRf9sL0C+KXX39iBzp8IV+6E8eWP357aQ1GtKud6vIOoWEx1q8PPNbvxjOx/r1D4BS 338vAJkSeETFNnWxBP/DFInYYE6pH37NrjNJ1/Jk35oLAZZ6II0xmn/Cm8923omOs0DO akRVZMlZVZvLDhA8hNzyjSOLz+LKcrUO/g6N/GKH/MNlx4K06p8fF6ZFk8DST2pNDIc1 0INg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=qBitOw0HNJiVJDTO9CmkL2ysr5NH1PjiQQQIJzuyEh4=; b=lY/BG9DSg595gTpG9EduchTYXI+S3Xg10vEAPtQ0wUNZsO24vCoDSswJY+Y0LN6w79 vaWEQDGwtj2fXIyW67UdVdqUkebw/g7q6giRiWk9PaYa+zigu8wB0yc7m66IxQ01e6eB eUvUMUK7OQXrUq7CLjiibzn7PF1+Kd1Xh/elNJS4fF4f1/QLn+fzJfPv7BARV8Apurnr Vkj4Ys1ffA4I60IbcVfUQe+MJwLrKE121SId20TJCzHVnpuo5Xq8ObpTtsRixLFShubr hChQ4OIf9LyZTkOuZCOTx5+6kc3fNtM3vjgtrQjVRcBfWrca+324vx9ay/XRGNlsvLTY Hryw== X-Gm-Message-State: AOAM531r3VEeoGISX32vSjrapOWA+lN8o1O90kCaWtB1KlFDptrwUyBu Noe96Jzm2Rh/NGtkQcorx4g= X-Google-Smtp-Source: ABdhPJzf+XjyNHyal6IMrPNBrnuUq513k44H2UzD7RoS8ZGGoWiioqGAt2Mg1ynyIJppiL27JWudpQ== X-Received: by 2002:a5d:6da5:0:b0:20a:8805:6988 with SMTP id u5-20020a5d6da5000000b0020a88056988mr25849439wrs.317.1651161239317; Thu, 28 Apr 2022 08:53:59 -0700 (PDT) Message-ID: <6cbe192a-22bc-f56b-17f0-db7c2af7bcd3@gmail.com> Date: Thu, 28 Apr 2022 16:53:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Reply-To: paul@xen.org Subject: Re: XenVif div by zero on Tx path after resume. Content-Language: en-US To: Martin Harvey , "paul@xen.org" , "win-pv-devel@lists.xenproject.org" References: <55d61956-1a0c-c4e9-cb79-ff24c3433ad1@gmail.com> From: "Durrant, Paul" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 28/04/2022 16:23, Martin Harvey wrote: > > > -----Original Message----- > From: Durrant, Paul > Sent: 25 April 2022 10:15 > To: Martin Harvey ; paul@xen.org; win-pv-devel@lists.xenproject.org > Subject: Re: XenVif div by zero on Tx path after resume. > >> It then calls SyncRelease(). This runs the 'late' suspend callbacks and terminates the DPCs on other CPUs, thus allowing threads to be scheduled. It then lowers IRQL on the current CPU, which should mean a fall back to PASSIVE as SuspendTrigger() is only ever called from the dedicated thread (running FdoSuspend()). > > Nice try. The mutual exclusion for the late callbacks depends on the other CPU's still spinning at dispatch - since plenty of other network processing also happens at dispatch. You need to complete *all* the late callbacks before releasing *any* of the CPU's from our DPC. One more step duly added in RFC patch. > Ok, right... I broke it in: ----- commit 9b7a47317031ddf5fab74311b24756c05bac72ae Author: Paul Durrant Date: Mon Nov 30 13:52:09 2020 +0000 Re-work the code in sync.c to provide per-CPU 'early' and 'late' callbacks... ... and then use these to drive the XENBUS_SUSPEND callbacks, rather than them being called directly from SuspendTrigger(). Since the clients of the XENBUS_SUSPEND interface only expect one invocation of each callback, rather then one per-CPU, they are only invoked from the sync.c callback for CPU 0. A subsequent patch will introduce a function that must be called from the 'early' callback for each CPU. NOTE: The call to KeGetCurrentProcessorNumberEx() made in SyncRelease() is relocated to __SyncRelease(), as that is the place where the CPU index is actually used. Signed-off-by: Paul Durrant ----- I'll take a look at the RFC patch. Thanks for figuring this out. Paul > MH. From win-pv-devel-bounces@lists.xenproject.org Thu Apr 28 15:57:20 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 28 Apr 2022 15:57:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.316679.535663 (Exim 4.92) (envelope-from ) id 1nk6W7-00083T-KM; Thu, 28 Apr 2022 15:57:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 316679.535663; Thu, 28 Apr 2022 15:57:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nk6W7-00083M-Ha; Thu, 28 Apr 2022 15:57:19 +0000 Received: by outflank-mailman (input) for mailman id 316679; Thu, 28 Apr 2022 15:57:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nk6W5-00083G-TP for win-pv-devel@lists.xenproject.org; Thu, 28 Apr 2022 15:57:17 +0000 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [2a00:1450:4864:20::429]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e080aeef-c70b-11ec-8fc3-03012f2f19d4; Thu, 28 Apr 2022 17:57:16 +0200 (CEST) Received: by mail-wr1-x429.google.com with SMTP id s21so7347717wrb.8 for ; Thu, 28 Apr 2022 08:57:16 -0700 (PDT) Received: from [10.7.237.11] (54-240-197-227.amazon.com. [54.240.197.227]) by smtp.gmail.com with ESMTPSA id e30-20020adf9bde000000b0020aeafa418dsm202790wrc.14.2022.04.28.08.57.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Apr 2022 08:57:15 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: e080aeef-c70b-11ec-8fc3-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=Z2V0J87rMYctEUuYsg/0RE3Rlfj2bftRZmOocjYDA2A=; b=CNNjfsaGwhwJ6mUqi2PdGGPn+D+6lOU7Qf2FNm2/oW/zUUo5woSStnut+YYO+Epnl5 RiOTE+6WdRu+WncW6K5bKVYVjt2RvEEMVEhzjnGbgN7DeVE6x3JNM/jRBDrp7k4fQ890 u9ObG48RuY9tyW43R9dEVxe2IsJTayAobn1LfmTp+ZFSMvga6NKDj3At6a5RTILsUyk7 VvCRa614CTiesIbBowrkglcu0CfZZujwPdUAiuX/MM0BGDj6THzXor5WSKxcRj7SGHbp 4HpQ4tSrWMArf4r5kMbWC2iDnZYgh7J1Lwbf8oi+yqDlg4dlnuAOvWvUwG3QpOUscPxd r2Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=Z2V0J87rMYctEUuYsg/0RE3Rlfj2bftRZmOocjYDA2A=; b=CiD2XglJuebjl82vJd+2r4Fe4AqiCkVITB0yfmYesevzYBSuR/jsq0GWViMgOeegWK TnL3Ojrx/IZR+C8Lhxd+oHx2fG+2Thy81PgVwB/kT+Tx7bMQv92ckvIgCgLf41Z0nwLA VJ3HNTfwcs4FmHRDJkH5rhkyRL1ME1tlqtygNzHxE/NovICc5t0GHefTOh2HtKrNAzsP 6JKoMHb9it4ABg4srGqw4Swdo5LqrK++3Dx53wkDzMJoRR3G6vwdfFveq5MB2tGxzLY/ W5+Vt733pBGz2eb+MGTVmkaKUkiQ87QCKanO9f1XRPE8SwOoyGGofqbXFsf8v72qWrHd /bnw== X-Gm-Message-State: AOAM531V//9dKQ1pcADqoQsMAM31MmpSUGtDv511z4RhYYfMdcP0+c3s RWAOvAtcpRasJvgx7PvbheQ= X-Google-Smtp-Source: ABdhPJwVoxqGG1bXRgqu2MKv4sKU1Kfll+mSJEcZjaAgM4b7fYX/OEPUgIT5OgcTjz0GfYGgqUZunw== X-Received: by 2002:a5d:6f11:0:b0:20a:de36:bb13 with SMTP id ay17-20020a5d6f11000000b0020ade36bb13mr16132554wrb.154.1651161436242; Thu, 28 Apr 2022 08:57:16 -0700 (PDT) Message-ID: Date: Thu, 28 Apr 2022 16:57:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Reply-To: paul@xen.org Subject: Re: [PATCH] More IOCTL parameter checks Content-Language: en-US To: Owen Smith , "paul@xen.org" , "win-pv-devel@lists.xenproject.org" References: <20220425121401.101-1-owen.smith@citrix.com> <5db038cf-67e2-ae6b-a951-1526e0e876b5@gmail.com> From: "Durrant, Paul" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 28/04/2022 13:10, Owen Smith wrote: > -----Original Message----- > From: win-pv-devel On Behalf Of Durrant, Paul > Sent: 28 April 2022 11:44 > To: win-pv-devel@lists.xenproject.org > Subject: Re: [PATCH] More IOCTL parameter checks >> @@ -618,10 +621,12 @@ fail10: >> >> fail9: >> Error("Fail9\n"); >> - ASSERT(NT_SUCCESS(XENBUS_GNTTAB(UnmapForeignPages, >> - &Fdo->GnttabInterface, >> - Context->Address >> - ))); >> + { >> + NTSTATUS status2 = XENBUS_GNTTAB(UnmapForeignPages, >> + &Fdo->GnttabInterface, >> + Context->Address); >> + ASSERT(NT_SUCCESS(status2)); > > Why? > > > If the definition of ASSERT is changed, its possible that pages would not get unmapped in this failure case. > It feels cleaner to me to separate the cleanup operation and the ASSERTion the cleanup succeeded. > Ok. Fair enough. >> + } >> >> fail8: >> Error("Fail8\n"); > > >> diff --git a/src/xeniface/ioctls.c b/src/xeniface/ioctls.c index >> a624bd1..20a7669 100644 >> --- a/src/xeniface/ioctls.c >> +++ b/src/xeniface/ioctls.c >> @@ -48,9 +48,9 @@ __CaptureUserBuffer( >> NTSTATUS Status; >> PVOID TempBuffer = NULL; >> >> - if (Length == 0) { >> + if (Length == 0 || Buffer == NULL) { >> *CapturedBuffer = NULL; >> - return STATUS_SUCCESS; >> + return STATUS_INVALID_PARAMETER; > > That's a semantic change. Do we want that? > > Paul > > Currently, passing Length=0 will result in a success and CapturedBuffer=NULL. The next operations after all calls to __CaptureUserBuffer is dereferencing CapturedBuffer. > > Currently, passing Length!=0 and Buffer=NULL should cause ProbeForRead to throw an exception, which results in CapturedBuffer=NULL, but __CaptureUserBuffer returning a fail code. > > This change will ensure that Length=0 or Buffer=NULL will both fail, and avoid any potential for dereferencing a NULL pointer in the operations after all calls to __CaptureUserBuffer > Thanks for the explanation; it would be nice to see that in the commit message :-) Paul > > Owen > >> } >> >> Status = STATUS_NO_MEMORY; > > From win-pv-devel-bounces@lists.xenproject.org Fri Apr 29 08:21:12 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 29 Apr 2022 08:21:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.317023.536158 (Exim 4.92) (envelope-from ) id 1nkLsE-0004ZD-GK; Fri, 29 Apr 2022 08:21:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 317023.536158; Fri, 29 Apr 2022 08:21:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nkLsE-0004Z5-DB; Fri, 29 Apr 2022 08:21:10 +0000 Received: by outflank-mailman (input) for mailman id 317023; Fri, 29 Apr 2022 08:21:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nkLsD-0004Yz-Dn for win-pv-devel@lists.xenproject.org; Fri, 29 Apr 2022 08:21:09 +0000 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [2a00:1450:4864:20::329]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4d954960-c795-11ec-8fc4-03012f2f19d4; Fri, 29 Apr 2022 10:21:01 +0200 (CEST) Received: by mail-wm1-x329.google.com with SMTP id p7-20020a05600c358700b00393e80c59daso4952907wmq.0 for ; Fri, 29 Apr 2022 01:21:08 -0700 (PDT) Received: from [10.7.237.11] (54-240-197-227.amazon.com. [54.240.197.227]) by smtp.gmail.com with ESMTPSA id s26-20020adfa29a000000b0020ad8b99d5dsm1824334wra.109.2022.04.29.01.21.06 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Apr 2022 01:21:07 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 4d954960-c795-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=pHebXX8wUGyqT6Q3dciXLbglrtBcsEDKbZsF1r8lupk=; b=JrTKOgJ7g+X3KVslu3wrX7SXETPbkH53aDMLeEHjLKsjgWlNHdkXnEPhQaa7wqdItx RYJpk3RAguUCEVy13dfGMqIZZWnzvf5B18klAmvyn+2J8uo4G3durnPTIcyGq6WAjyEx 8r5Y35uErrPRbierb8+0MclwRkT8IqpQm78uW1xmEJHf3jCHXARkMhMXEIzSwgkAAQPf 0vnPP3COOqO9FEkc3rXkoi9DsSQjla5HK4+3zhZGixqClD0UTGEHxBj3ofY2h7LiRMeW hNpuR+cmWqHGs18btMqnBfAwQoTu1qQvUvU5PrmoQ5hTAIeaU99SAePJsM4KWYL/9Ckz fzkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=pHebXX8wUGyqT6Q3dciXLbglrtBcsEDKbZsF1r8lupk=; b=p6AtC5u80wkZuOsDy8Er4Y/T2AxLBwNhlZaChMTTjVZqboUa7+miP4o9Ch5pqFWxSM GjAjBSC03mi6Ih6qYjTUvNZcyqVZnwSUhNSMlnPkTZsK1K0dVbQbPDu7jbIImgslmsNj oO83N2Krly3KQtVCRCpK58hYUfaUSBgd8bZujg7nGjLnIKru+4RSqUKqTf8B58xmnwdZ +4XxX96jIy4ZmzxHTYMDX8EVxAY7svX6S1A0ZZt7n+UyAI55Nbn9TocXb0Vm8K9CcJ5V sGU8KIurIP1Hs8lzTSgPS1KCVUmZvhH5LmsR5AJBwrexMhtRd4zDA/u5ngMKCjMGTH1X bdaw== X-Gm-Message-State: AOAM531OBiArtMsr6GkZKEgFrX4i6a+GRHLD5ADsPGG59Lw3EL+KJwo3 LzPGIuNuHsAsaBoPbfhw9bWEmNNluvL5Tw== X-Google-Smtp-Source: ABdhPJweramhxiRZ47v59Scr5OrwqxYt7GL0GeO3OJEvD9+FdBoAESeB34MPQolNDefhpZdnjHuWEQ== X-Received: by 2002:a05:600c:4f93:b0:393:f08d:a048 with SMTP id n19-20020a05600c4f9300b00393f08da048mr2112257wmq.158.1651220467776; Fri, 29 Apr 2022 01:21:07 -0700 (PDT) Message-ID: <356386bb-cb26-a1bf-57aa-dd0820b4275c@gmail.com> Date: Fri, 29 Apr 2022 09:21:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Reply-To: paul@xen.org Subject: Re: RFC Add extra sync release step for late callbacks. Content-Language: en-US To: win-pv-devel@lists.xenproject.org References: From: "Durrant, Paul" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 28/04/2022 14:01, Martin Harvey wrote: > This patch for RFC. I think it solves some longstanding suspend/resume > issues we have had. > Yes, this fixes the breakage introduced by commit 9b7a47317031 ("Re-work the code in sync.c to provide per-CPU 'early' and 'late' callbacks...") but things are getting a bit messy now. At this point I think it best we have a state model with helper functions to transition between the states. It should be possible to call these from SyncWorker() as well as the main entry points and hence avoid some of the code duplication that already exists. Since it's my idea, I won't ask you to do the re-work :-) I'll get a patch together today and post it to the list. Paul From win-pv-devel-bounces@lists.xenproject.org Fri Apr 29 13:41:01 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 29 Apr 2022 13:41:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.317335.536621 (Exim 4.92) (envelope-from ) id 1nkQrk-0007VH-UD; Fri, 29 Apr 2022 13:41:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 317335.536621; Fri, 29 Apr 2022 13:41:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nkQrk-0007VA-R5; Fri, 29 Apr 2022 13:41:00 +0000 Received: by outflank-mailman (input) for mailman id 317335; Fri, 29 Apr 2022 13:40:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nkQrj-0007V4-H9 for win-pv-devel@lists.xenproject.org; Fri, 29 Apr 2022 13:40:59 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id feeb7a9d-c7c1-11ec-a405-831a346695d4; Fri, 29 Apr 2022 15:40:58 +0200 (CEST) Received: from mail-bn8nam11lp2175.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Apr 2022 09:40:55 -0400 Received: from MW4PR03MB6347.namprd03.prod.outlook.com (2603:10b6:303:11e::22) by BLAPR03MB5441.namprd03.prod.outlook.com (2603:10b6:208:29d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.23; Fri, 29 Apr 2022 13:40:51 +0000 Received: from MW4PR03MB6347.namprd03.prod.outlook.com ([fe80::1c1a:4522:6f0a:df7d]) by MW4PR03MB6347.namprd03.prod.outlook.com ([fe80::1c1a:4522:6f0a:df7d%6]) with mapi id 15.20.5206.013; Fri, 29 Apr 2022 13:40:51 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: feeb7a9d-c7c1-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651239658; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=M/Mxpl1Zo3tN+Nd54SxY6xsx+yJtp4AygYB53sP9yeU=; b=Swhq/lOgJTmZczOLLe398VixusKR6GEyMVfnLWSYQzCCjdnkcNtIZL+Z UKfMqJNhBf0Hnwt+gv1v/bB9Gov+6sl6GtbSDORsA70oh6bs8WgpwGR8T WewWs4ieTd2KxADw3LDS9xVGFlhEpCPRBxd1KHmoPrfb+FuGPsS9F8xZr M=; X-IronPort-RemoteIP: 104.47.58.175 X-IronPort-MID: 72698696 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:5mJkdKkmuJUPcYlzmcuqeZHo5gzjJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xJKWmjSaP2JYTf0e9B1b4izoxgOuMDcnddjHFQ/ry0wFSMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EsLd9IR2NYy24DlWVLV4 rsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYZVsSLKjAsegmWRwfVAVfHf1b5e7BLi3q2SCT5xWun3rE5dxLVRhzF6tIv+F9DCdJ6 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOXtZkBg2pYasNmRJ4yY +IcYCBzbRKGYxRVJFoGIJk/gP2plj/0dDgwRFe9+vBpsjiNnVIZPL7FEv7QdtDRYMFuummUp EnA4z/rKxIFK4nKodaC2jf27gPVpgvjUZ8WPK218LhtmlL77nMSDlgOSx63rOe0jma6WslDM AoE9yw2t68w+Ue3CN7nUHWFTGWsuxcdX59aFb084QTUk67MuV/GWy4DUyJLb8EguIkuXzs22 1SVntTvQztyrLmSTnHb/bCRxd+vBRUowaY5TXdsZWM4DxPL+unfUjqnog5fLZOI IronPort-HdrOrdr: A9a23:AReg3qFuQiOFa7X7pLqFSpHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5VoMkmsj6KdhrNhcYtKPTOW9VdASbsP0WKM+UyGJ8STzI9gPO JbAtBD4b7LfBdHZKTBkW+F+r8bqbHpnpxAx92utkuFJjsaCZ2Imj0JbjpzZXcGITWua6BYKL Osou584xawc3Ueacq2QlMfWfLYmtHNnJX6JTYbGh8O8mC1/HKVwY+/NyLd8gYVUjtJz7tn23 PCiRbF6qKqtOz+4gPA1lXU849dlLLau5t+7Y23+4sowwfX+0OVjbdaKvm/VfcO0aaSAWMR4Z vxStEbToJOAj3qDziISFDWqnTdOX4VmgPfIBmj8DXeSIXCNU0HItsEioRDfhTD7U08+Nl6za JQxmqc84FaFBXagU3GlpD1vjxR5zyJSEAZ4KcuZr1kIPkjQa4UqZZa8FJeEZ8GEi6/4Ic7EP N2BMWZ4PpNa1uVY33Qo2EqmbWXLz4ONwbDRlJHtt2e0jBQknw8x0wExNYHlnNF8J4mUZFL6+ nNL6wtnrBTSc0da757GY46MICKI32IRQiJPHOZIFzhGq1CM3XRq4Tv6LFw/+2ucIxg9upEpH yMO2koxlLau3ieffFm8Kc7gywlGl/NIwgF4vsul6RRq/n7WKfhNzGFRRQnj9agys9vd/HmZw == X-IronPort-AV: E=Sophos;i="5.91,185,1647316800"; d="scan'208";a="72698696" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nZqF13u2lbZDGGcf3p076v2TV1/hLsQOI7rMm5t3hy6QW8nDYrsDWxirDMReElbgPkOfbunVh3GDB5tR39qqehM54dxFuXB3LBTpdwSUNRLr+wXXuLQHRkh7eFCWlLATr7GQ48x7c5rjrvI2rp57m8R18cZwTlbquRhqlkunQloZo+vwSJko6x33E+2V/Vd7X/xoQduwGhIEKLDEdujBkn7kXL4l8KQJ8IKpO74q0JuyLj9MTi7yAbiIN59SV0hbd7Iv18SZ0E7tZrINzAp5FPlzZhhVQWlQaSnHS5E9Q+Yh1z7OKkl2hFASO8NJf5X8pzOntFWldUAS4TaQ41IMSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M/Mxpl1Zo3tN+Nd54SxY6xsx+yJtp4AygYB53sP9yeU=; b=Cxu045LGXIUCUcxLX+fD+XZ3EIMYve0hTKjThfgIF4Z/203gcgkAnx6LeqsAXfypCdZ7M5PruQGskIrFMgr3UJ3Odw0qjWAUyxomAI+UhXFSmBIytHsoN8GBU5xFMx8KcBa8IW8JeLwYn0BbiGUHDsF+8gwMEz5qeWiAn5ZKhzPPDqahCJtlVY5+QfA3F1udjCA/6gvfzVm2OsUpL7ndbQixwVBwX1mHDLyseMBicNnlBtiECPkIQKR/WUcU92NeCWLhw3Ex6GaEKEncEHGspKI+mzBbUb0EsccuyTmMGFvldvRbcDDTaihpgJfRJVQKpV4PXEvBIzNehAXC7b6FRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M/Mxpl1Zo3tN+Nd54SxY6xsx+yJtp4AygYB53sP9yeU=; b=FUCl4htomJzULVMMd/wIN/vTQZ+Voyi9iKGMeUfLzoCdtGHUSI+pdRyvcwouxqxar9Y7j7qgSepYKq2QSQRMWan/seJdFQUjVXCDRectLTUJyCEIZN0Ct7QpD4iD1RyOwir+QfyahaZo1RtCp1yfFhNNC4s6z6WdbpUKSfkn50U= From: Martin Harvey To: "paul@xen.org" , "win-pv-devel@lists.xenproject.org" CC: Owen Smith Subject: RE: RFC Add extra sync release step for late callbacks. Thread-Topic: RFC Add extra sync release step for late callbacks. Thread-Index: AdhbABZj/QTUWYFgSjmTyVfnJrSFdwAofwQAAArqpOA= Date: Fri, 29 Apr 2022 13:40:51 +0000 Message-ID: References: <356386bb-cb26-a1bf-57aa-dd0820b4275c@gmail.com> In-Reply-To: <356386bb-cb26-a1bf-57aa-dd0820b4275c@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6380cf13-a6d7-441a-5a96-08da29e5e04f x-ms-traffictypediagnostic: BLAPR03MB5441:EE_ x-ms-exchange-atpmessageproperties: SA|SL x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: k8XqOFiU15c9ZVDutjuKJdTWIpksZiZ/ttuZLDi03+88vednmNDbW6QC0rtjAY8s3TPjKqSzareYMYEgzkmdS13wstoscxOArH72AJpkZ8WKeXcMxL2peCtLfmQOpOBPaBPAxKCVm6uOpFOQzX/i6kC87PRbwCvrkNy4zpp4Ti7kjew9HI5nliEWWM5unAtlS0aO+c9tzJ+DuAUGwcdhynMc6DCGppHdN7rjYPtTWvo/Y84Pv4KIdErAMrvUc7Ko8eAGUQkw7jy219WFy0zXUC/hVGGuF54BTJMOZEMmFCvWAaV1EsBybVV6qCW1V81CTMopbFsVHQUTnqE16jxtfftYDF7ZmCy38bWOJZfKoGo9s76feEfWPk4SQKf3Zk5jYJRX1vbynQyeg05+bO2/PjT+zAEwKpyC4iRIu/H65vIGxpquW4iiQqU50m8/sLCe4p1Fa5xkAQnF8ju1p2NiqoKUU1tVdAjve9bvgnKKGO66lEyxOKfSGABQjyyUHlgAvVeuwXqo4sY7lo/Ge8jSWITwF7om8txO6e8I/FbtxsNE4lSFzYFpw/KKRo/N5wLaVvF1Fx5NRGuPllRkA6iiEHzxYlrBswVCNxiSssKRGKn/CPFUQFvvNgTqtjZuoAoo815DfNzRa6Mz+6ok1Iu6x7RKMeT4jP7w7fx0jn95BaIEiKVHWTS4yt8/zXOgJycOyEKVt4++INOL8gZfO8+Ltg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6347.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(66476007)(66446008)(64756008)(52536014)(4326008)(66556008)(76116006)(66946007)(8676002)(83380400001)(5660300002)(33656002)(508600001)(110136005)(8936002)(71200400001)(55016003)(2906002)(44832011)(38070700005)(38100700002)(122000001)(9686003)(53546011)(6506007)(86362001)(26005)(7696005)(107886003)(82960400001)(186003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZllHNFR2RVlaamdsQXE1VkN3MWxEaGgyeUFtRExUOGJaV1hSUmgzWG5HWGs0?= =?utf-8?B?SnZVQWZNMnlJMWhpMGJIc29uVGx3MldHcVVIdGdkL20vNkNmc3QzSVR5SlN2?= =?utf-8?B?cmRoNjNHZi93c211QTA5TVVSQ2pRRkVpSTBBeTM4aGZNSjMycGE1VDNMU1J4?= =?utf-8?B?ZzV3VVVQQmNmSXY0LzExN0N5b3Jha3Z2VVgyYkh2L0UxRzFwclBZaC9QdHdS?= =?utf-8?B?emlvVmNoYkxrL2ZHSCsrdWZZeEVlWWI5cnFVbVc3SFlZU2x5SnNnaEtDTVZs?= =?utf-8?B?QzJaMHpITWlrTjlLb2pYRGV1cktuZjNLaGdJRUlWN0ZvS0pLdlRoZ3k4ZTlC?= =?utf-8?B?Nzk2ZUtoWXNjSXVFN3JCMWtrR05BSUd1UGs0SFFKWU1pb0x2VHdSL3VJM05I?= =?utf-8?B?eHdZYUYzUm1nUFRVUzl5eVJManlCZU5qRlpKSEV4NkhDNTBVZm4xQ0taY3R5?= =?utf-8?B?clFDTy9BcWVMSWNsWHBkNHdLS1FiZlRXM3dRV0szelk2NmNRalY4WlJpS0w2?= =?utf-8?B?TFpScElwS0ZtNGF0cit0bmJnc25MdEhjL2ZMYU5nVWQycXEyR05QeVVXcm1H?= =?utf-8?B?dXdycThFR21aWW9LMURWRUlJQXVaNmdreCs5TWtpTjVweGtYUXVjVWVSWDlD?= =?utf-8?B?dlYxMCtESVNTWU1xb2VjeWJEUk83anlzTHo3QnRXUHdPT3pPQU9IVW9veGJE?= =?utf-8?B?YlNwZlBMNlBoeGlkZTNNM1FtZ1Y4dkhNcFEyMys3KzAyKytsR2lCVUN2Skpk?= =?utf-8?B?REE5TDVnSjJ2cEdTQjRxd1ZQWmN1Mk9QNFNEa0I0bDNwaFJidW9TTnlWS3pt?= =?utf-8?B?WGxjVWhPRmF4Qk9OTUpFdmhFVXBJcWozZHpvYTNzTks0ZG93b2VVR2x1T1g1?= =?utf-8?B?b1M2MW00NEs0NnhJSG0yTGtHN1BJa3FTWFc2bXNkOGdVSWtqR0xjQWE0V0p3?= =?utf-8?B?R2dnVEtxM1AwdHF3TmtUd3k0MDV0YURyWW1tVkg0N0ZwaEZCTzBaUVBTR29W?= =?utf-8?B?KzJxd1RVcngzVkZSUUlhbWxGSkorV0tMSUhyT0VrclhjTW5JK0FKUWVwUk8z?= =?utf-8?B?RzR3WE9OdVFReDIvengrV0NYWXBCWjdxWlN6d2tOL25oMC9YSDBxQy94Qi9Z?= =?utf-8?B?dWY5eCt0VENMbFYwdGtYZHFKaGQ5ZEgrdVVwcHBoZXEybVozVTlkaWJjcStt?= =?utf-8?B?TDNiWmVGdUQyRUpPL094ME9ibTJ2R2doblYyNEFJeGZUNHR3cnhvbExUa2hk?= =?utf-8?B?OXVSRmpnNXFkTEcveklZN3BaYjZ0ZHpDYjcwR2MzZGhnQ093Uy8vdkJTNjhw?= =?utf-8?B?V3M4a1FwYU0wZFd0WktZUFJGdVZUY0l0RnN3VTE2VExxQndjcitiQ25nbHZR?= =?utf-8?B?WW9STGlGK3FHdGhCZFk3ZUZBbS9mZkhIRnNoTDZmeEhOM1FpWkFwUE40akZ4?= =?utf-8?B?Y1o5ZlhPTXVId2RwMlZwWFBGTzB6T09BaHU4dWxscUZXNXFYMzlWak1JTytJ?= =?utf-8?B?S0JXNExiL1g5ZzZEWlhDV1QvL0lwbHluamUxWUtTUmEvYmUvd2I5MUsrd3JN?= =?utf-8?B?bDVlVjArT2V0UXFIbVArRzUzMlBmSW1yQWphQzd0YmtSTnZ4cDcvN3h0dzdp?= =?utf-8?B?UzEyek0xdjNBRnFjYXI1aWZmaXA2Q2VZdURHK0pRM3J1NTdTK1ZoeHFDME9L?= =?utf-8?B?ZWw3LzE4K0lXQ3EwSytCSUcrMkU2ejZKOTV1bldXOVNpVWYreG1zYk56V0xS?= =?utf-8?B?Y1YyMEFwWjVSTkROVEJQZ0ZtWGROSVg3Snh6WjlCYjJJN2xJVVlHWlVDNEhU?= =?utf-8?B?dkdUeEJ0RTJyaityZ1pMYk5TZktvcDJMZWRGMlR1TERqazZNa1FWanJJWU55?= =?utf-8?B?VWJyWXRxSi9pMDBTa3k4a3pHVnBEOXREMmVYVUN5K0hpdUZCWldnUzZsYitw?= =?utf-8?B?aHZGMEFUUEg0ZmQ0ZElxMEhOaTFzdW5NOVZSVlJTUFRtdnFZTEFQcHNRdy95?= =?utf-8?B?dVBmR1lTWHVvMnRjSGcvSFlONzVoZmZwK3YwMmt3S1dtME5uQjRNMERJVDA5?= =?utf-8?B?RG9FVktxSzJjdE5kMUdPMWNDVVdvYWFwcGp1YnJsdHFLeGpKZURKUit6NWF4?= =?utf-8?B?ZUpMamV5a3h6Wm1MUXZFZkJrSXd3eWJjL1IwT2cvK051bXpPUjJ2WEc1ZVJF?= =?utf-8?B?ODJFaDJkcnBUazBMclVqOUtobE01QmdjSlJVdzZjVUdwRm9TUVk3blhTYmY4?= =?utf-8?B?UWNPSk5WWkU5cUdrRnJRUXdnNUF5VXFZdmMwa2ptbEFLUTZjRUZsZlo2NVJy?= =?utf-8?B?M0ZldTRxNENlcVA0RkFlVW5BQ0s5aHBNRW9GYXNBbXpMWlZlSFNFZz09?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6347.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6380cf13-a6d7-441a-5a96-08da29e5e04f X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2022 13:40:51.3736 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /+btaBIC7IGdWHT0zOrLrRvLc8ssp3R51apzk/bO2WlZ2n3shjhTa0Psqf88pzgubEfR8tp7Mk0gpnimQ3M4PnKOkeWTFaMIpoMAC86eGZ8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5441 DQpIaSwNCg0KU291bmRzIGdvb2QuIFNvbWUgdGhvdWdodCBuZWVkZWQgYXMgdG8gd2hldGhlciAg dG8gdHJhbnNpdGlvbiBmcm9tIGEgImNvbXBsZXRpb24gY291bnQiIG1vZGVsIHRvIGEgImluZGl2 aWR1YWwgc3RhdGUgcGVyIENQVSIuLg0KDQpBbHRlcm5hdGl2ZWx5LCBwZXJoYXBzIGhhdmUgbmFt ZWQgc3RhdGVzIGluc3RlYWQgb2YgdGhlIHNlcXVlbmNlICMsIGFuZCB0aGVuIHRoZSBjb21wbGV0 aW9uIGNvdW50IGlzIGhvdyBtYW55IENQVSdzIGhhdmUgcmVhY2hlZCB0aGF0IHN0YXRlIChhcyBv cHBvc2VkIHRvIGluIHRoZSBwcmV2aW91cyBzdGF0ZSkuIFRoZSBzdGF0ZSBtb2RlbCBpcyBuaWNl IGFuZCBsaW5lYXIsIGFuZCBoYXZpbmcgYSBjb21wbGV0aW9uIGNvdW50IHJlbW92ZXMgdGhlIG5l ZWQgZm9yIGxvb3BzIHRvIHNjYW4gdGhydSBzdGF0ZXMuDQoNCkFsc28sIGlmIHlvdSB3YW50ZWQg dG8gcmVtb3ZlIHRoZSBuZWVkIHRvIHNldCBib29sZWFuIGZsYWdzIHRvIGluIGVhY2ggb2YgdGhl IHByb2Nlc3NvciBzdHJ1Y3R1cmVzIChtb3JlIG5lZWRsZXNzIGxvb3BzKSwgeW91IGNhbiBwcm9i YWJseSBjaGFuZ2UgdGhhdCB3aXRoIGEgc2luZ2xlIHN0YXRlIGluIHRoZSBjb250ZXh0IGFzIHdl bGwuDQoNClBlcmhhcHMgYSAiY3VycmVudCBzdGF0ZSIsICJ0YXJnZXQgbmV4dCBzdGF0ZSIsICJy ZWFjaGVkIHRhcmdldCBuZXh0IGNvdW50Ii4NCg0KLSBEcGNzIHdhaXQgZm9yICJ0YXJnZXQgbmV4 dCIgPD4gImN1cnJlbnQgc3RhdGUiLA0KLSAibWFpbiIgdGhyZWFkIHdhaXRzIGZvciAicmVhY2hl ZCBjb3VudCA9IGNwdSBjb3VudCIsIGFuZCB0aGVuIHNldHMgInRhcmdldCBuZXh0IHN0YXRlID0g Y3VycmVudCBzdGF0ZSINCg0KV2lsbCBsZWF2ZSB0byB5b3VyIGRpc2NyZXRpb24uIA0KDQpNSC4N Cg0KDQotLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KRnJvbTogd2luLXB2LWRldmVsIDx3aW4t cHYtZGV2ZWwtYm91bmNlc0BsaXN0cy54ZW5wcm9qZWN0Lm9yZz4gT24gQmVoYWxmIE9mIER1cnJh bnQsIFBhdWwNClNlbnQ6IDI5IEFwcmlsIDIwMjIgMDk6MjENClRvOiB3aW4tcHYtZGV2ZWxAbGlz dHMueGVucHJvamVjdC5vcmcNClN1YmplY3Q6IFJlOiBSRkMgQWRkIGV4dHJhIHN5bmMgcmVsZWFz ZSBzdGVwIGZvciBsYXRlIGNhbGxiYWNrcy4NCg0KW0NBVVRJT04gLSBFWFRFUk5BTCBFTUFJTF0g RE8gTk9UIHJlcGx5LCBjbGljayBsaW5rcywgb3Igb3BlbiBhdHRhY2htZW50cyB1bmxlc3MgeW91 IGhhdmUgdmVyaWZpZWQgdGhlIHNlbmRlciBhbmQga25vdyB0aGUgY29udGVudCBpcyBzYWZlLg0K DQpPbiAyOC8wNC8yMDIyIDE0OjAxLCBNYXJ0aW4gSGFydmV5IHdyb3RlOg0KPiBUaGlzIHBhdGNo IGZvciBSRkMuIEkgdGhpbmsgaXQgc29sdmVzIHNvbWUgbG9uZ3N0YW5kaW5nIHN1c3BlbmQvcmVz dW1lIA0KPiBpc3N1ZXMgd2UgaGF2ZSBoYWQuDQo+IA0KDQpZZXMsIHRoaXMgZml4ZXMgdGhlIGJy ZWFrYWdlIGludHJvZHVjZWQgYnkgY29tbWl0IDliN2E0NzMxNzAzMSAoIlJlLXdvcmsgdGhlIGNv ZGUgaW4gc3luYy5jIHRvIHByb3ZpZGUgcGVyLUNQVSAnZWFybHknIGFuZCAnbGF0ZScgY2FsbGJh Y2tzLi4uIikgYnV0IHRoaW5ncyBhcmUgZ2V0dGluZyBhIGJpdCBtZXNzeSBub3cuIEF0IHRoaXMg cG9pbnQgSSB0aGluayBpdCBiZXN0IHdlIGhhdmUgYSBzdGF0ZSBtb2RlbCB3aXRoIGhlbHBlciBm dW5jdGlvbnMgdG8gdHJhbnNpdGlvbiBiZXR3ZWVuIHRoZSBzdGF0ZXMuIEl0IHNob3VsZCBiZSBw b3NzaWJsZSB0byBjYWxsIHRoZXNlIGZyb20gU3luY1dvcmtlcigpIGFzIHdlbGwgYXMgdGhlIG1h aW4gZW50cnkgcG9pbnRzIGFuZCBoZW5jZSBhdm9pZCBzb21lIG9mIHRoZSBjb2RlIGR1cGxpY2F0 aW9uIHRoYXQgYWxyZWFkeSBleGlzdHMuDQoNClNpbmNlIGl0J3MgbXkgaWRlYSwgSSB3b24ndCBh c2sgeW91IHRvIGRvIHRoZSByZS13b3JrIDotKSBJJ2xsIGdldCBhIHBhdGNoIHRvZ2V0aGVyIHRv ZGF5IGFuZCBwb3N0IGl0IHRvIHRoZSBsaXN0Lg0KDQogICBQYXVsDQoNCg== From win-pv-devel-bounces@lists.xenproject.org Fri Apr 29 13:42:52 2022 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 29 Apr 2022 13:42:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.317342.536628 (Exim 4.92) (envelope-from ) id 1nkQtY-0007cp-4L; Fri, 29 Apr 2022 13:42:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 317342.536628; Fri, 29 Apr 2022 13:42:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nkQtY-0007ci-1O; Fri, 29 Apr 2022 13:42:52 +0000 Received: by outflank-mailman (input) for mailman id 317342; Fri, 29 Apr 2022 13:42:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nkQtW-0007cZ-K4 for win-pv-devel@lists.xenproject.org; Fri, 29 Apr 2022 13:42:50 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 413454a4-c7c2-11ec-8fc4-03012f2f19d4; Fri, 29 Apr 2022 15:42:49 +0200 (CEST) Received: from mail-dm6nam10lp2108.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.108]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Apr 2022 09:42:46 -0400 Received: from MW4PR03MB6347.namprd03.prod.outlook.com (2603:10b6:303:11e::22) by DM6PR03MB4428.namprd03.prod.outlook.com (2603:10b6:5:101::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 29 Apr 2022 13:42:44 +0000 Received: from MW4PR03MB6347.namprd03.prod.outlook.com ([fe80::1c1a:4522:6f0a:df7d]) by MW4PR03MB6347.namprd03.prod.outlook.com ([fe80::1c1a:4522:6f0a:df7d%6]) with mapi id 15.20.5206.013; Fri, 29 Apr 2022 13:42:44 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 413454a4-c7c2-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651239768; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=8AJ8wW+R6M+jStqKMjyt8fNpcGx4He8e8Woo4lqSxIY=; b=GoUBfkKsAtLdqJU92WwNj/c2JiAZ3ZzqopzFsZcm/R6KxdTvDmcCLKIY /RS7mh3mO4rqm8BSuEWJ/6cmnYCpuQY+S47A0Oz+Rvhn9DpLuYYtypUTJ lLsjYBw+32pmmY5VXE5wR9NimaK5H2GzWEyTfPlRalLRKV9C0sQxtvpLW Q=; X-IronPort-RemoteIP: 104.47.58.108 X-IronPort-MID: 70255855 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ZZgfCa9uXnPY/7lxTaX6DrUD4n+TJUtcMsCJ2f8bNWPcYEJGY0x3z 2AfXWuFM6rca2H3f94jaIW19U5UvsfVmN9gTwo6pSk8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ44f5fs7Rh2NQw3YLoW1jlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnZqxGCwNJKuLovRHWj1IKBxPYalv6qCSdBBTseTLp6HHW13F5qw2SW0TY8gf8OsxBnxS/ /sFLjxLdgqEm++93LO8TK9rm9gnK87oeogYvxmMzxmAVapgHc+FHvWMvIcItNszrpkm8fL2Y sMDdTtpKhTJeQNCK38cCY4knffujX76G9FdgA3N//dqszWOpOB3+KHAGvfUI4CLf+NYxHSbv DL95DXDEDhPYbRzzhLAqBpAnNTnhSrmXKoCGbv+8eRl6HWMx2pWEANTWValrP2Rjk+lR8kZO 0ES4jApr6U56AqsVNaVYvGjiHuNvxpZV98OFeQ/sVmJ0vCNu1bfAXUYRDlcbtBgrNUxWTEhy l6OmZXuGCBrt7qWD3ma8994sA+PBMTcFkdaDQdscOfPy4CLTF0b5v4XcuteLQ== IronPort-HdrOrdr: A9a23:Z2Sesawxm1gfCr4S/p36KrPxjuskLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBapTiBUJPwIk80hqQFm7X5Wo3SEDUO2VHYYb2KiLGP/9SOIVyYygcw78 Zdmu1FeaXN5DtB/InHCWuDYrAdKbC8mcjG69s2jU0dND2CAJsQjTuRfzzrdnGeMzM2YKbReq D92uN34x6bPVgHZMWyAXcIG8LZocfQqZ7gaRkaQzY69Qinl1qTmf/HOind+i1bfyJEwL8k/2 SAuRf+/L+fv/ayzQKZ/3PP7q5RhMDqxrJ4dYyxY4kuW3bRYzSTFcFcso65zXQISSaUmREXee z30lUd1gJImjXsly+O0ELQMkLboUsTAjfZuCOlaD3Y0ILErXsBerV8rJMcfR3D50U6utZglK pNwmKCrpJSSQjNhSLn+rHzJllXf2eP0AwfeNQo/jViuEolGc1shJ1a+FkQHIYLHSr85oxiGO 5yDNvE7PITdV+BdXjWsmRm3dTpBx0Ib127a1lHvtbQ3yldnXh/wUddzMsDnm0Y/JZ4T5Vf/e zLPqlhibkLRM4LaqB2AvsHXKKMeyfwaAOJNHjXLUXsFakBNX6Io5nr4K8t7OXvY5AMxItaou W3bLsV3lRCCH4Gyff+qKGj3iq9MVlVBw6dtP22z6IJyoHUVf7sLTCJTkwono+pv+gfa/erLs qOBA== X-IronPort-AV: E=Sophos;i="5.91,185,1647316800"; d="scan'208";a="70255855" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LmJUfmwbSZzTphLOwpQYpGlymGGeCouVRG14F+eyE13Jx5t6kceHIunHEGK/HFoIAfNqt1OThri+ArWxE2hyS+Uprb3vCt9ApCXONn9LjoeXcfiiW8PzZdVzxyGga0Bi+QjZZ8Jqt+wRVkEJPcjM4BXdmrtvHqPp0F+BuMkwuO056y+oeBXXBCZmcDPiMVqdvGQD6agXt4audC8CyFjWNqJY9imb7k2LvQUPPPiJ4KymNWD9AUune/NEV52zKpK78Sd5ckMebYHogN2leK24bgaLbHSMXokQeq7AJn0USwhjWbax7z4CvM4w3Y1lSFlfmnxQ8e5tCnCf/ccjX2+kCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8AJ8wW+R6M+jStqKMjyt8fNpcGx4He8e8Woo4lqSxIY=; b=eT6CKk9CYWk76xf/MyPH+v+upoELtpbO6pUmWay/zVrTtJegRZv3e2hYv+CpAmXJPeMUnsegk7cVAF99ydnYxyEu1R537lJgBzu3xnMc0vHJAr+LoZKGPepDVz0WKvaKYtECt2wC+TARj7r+Eezf7bEe6nyXn6aLePe1lYLWPjAAo/jTqXkJ6zfPk1CbK3VfLWJD7qW8vnXdmYsyRK3Q5IcAmanFOsxdq8FRdB7RaUQnpj6eGHGM2SYubzDuEk6bauwPZhyqxE4Wj9PYTUSjG0uFm2mirvUnM8bAL0R2nLRI7QbCdWXzrudN8mhJll7+An6zUerZRn8eosbul7W8cw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8AJ8wW+R6M+jStqKMjyt8fNpcGx4He8e8Woo4lqSxIY=; b=MzAmYu00Q/3Fm43vtELt9MzVAFpZcqw0LLL3nAY9rbiyzLuSgDkGxA2YRvFhRNKFWJymeXgt0ZXoJuHDLFY4J4aHQ5J99PfsmoR3gUoWjM9Ocs4ijvwEOR1UhrDSUPvdHeqEPbqnZ6tKikEAR0BQ+v47aejAoIWHUeeJFN29g58= From: Martin Harvey To: Martin Harvey , "paul@xen.org" , "win-pv-devel@lists.xenproject.org" CC: Owen Smith Subject: RE: RFC Add extra sync release step for late callbacks. Thread-Topic: RFC Add extra sync release step for late callbacks. Thread-Index: AdhbABZj/QTUWYFgSjmTyVfnJrSFdwAofwQAAArqpOAAAEu2AA== Date: Fri, 29 Apr 2022 13:42:43 +0000 Message-ID: References: <356386bb-cb26-a1bf-57aa-dd0820b4275c@gmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d3d6c163-c2cf-4618-1f2b-08da29e62373 x-ms-traffictypediagnostic: DM6PR03MB4428:EE_ x-ms-exchange-atpmessageproperties: SA|SL x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gQ8XlS4gf/VNrkiTtEbfPwW6RdfO6vMFjXRAfAtuGFnA6PTS0Hhty1ncfD0sWTpKqhBPe8UTDQ4Amz/z7eXO7lxuHlR5CB70N0UUaJ8ISwmVoWeq5dpwKrDsKi91pSBtFBu0Jk4RM8iAH6J7jXVaC2eye75NyRMPSgjvdkKl1yO8YxthtrWlg1MdkY15IniZ9JB3GfbN56Z0E5VMzzO+QC0MHgXAR/Tx63C4dvSBUVMtcFT2sZWbqrGuKrYmJIAN2IRqccPNeRGc7Cytrnt0e3uCiPGXeTtt1K0vruBYk4ef1pVspgvsAevnkbEcfMYAtwaxtFBJAg3A93v5zNEeDgXxnpmzFC1JEYXJjtQwHVbBB3m/vc7C3um2nSdssZA1pVlOOnA26pAX1PNBgDXKYGSaWsZgjxbT1e/6myhfdK2AiyekVP+BwIp5ygf1Z9dcYWQbxGpA1vFXd7dzWWiv1+yQIcaCqI56UnlkPt7Y0KXKB3xFBxTa0UhxqY8nvK8f0+FsZUJzYzEYXGcIEXhsCphh43R54VHxM7892bpxukvuW7u+pbGAL8BGP9JeqGFGskia3Kc8jf9CT8c5DKJjwAT7KZp+kuI6M7SB7EtZCyJNXKGDXhv86G7GlO+15iFJBXMKyDV7KNhuX03xAtn1bEFabP5NDGFhWC9ofjq0k5TKdF3qatNqSz6wLOkDHIcikreuTAHffH1xZ38/55/gbA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6347.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7696005)(44832011)(82960400001)(8676002)(122000001)(52536014)(26005)(8936002)(9686003)(4326008)(6506007)(66476007)(64756008)(76116006)(66446008)(110136005)(66556008)(558084003)(316002)(66946007)(107886003)(38070700005)(38100700002)(71200400001)(5660300002)(55016003)(86362001)(2940100002)(2906002)(508600001)(186003)(33656002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ODJURTR6Vlk5dDJSWU5OTStUbG5Yb0RSR1I2RlJxR0dGWk5rcU5nQzIzYW5U?= =?utf-8?B?Z29DejZpcG90a2xMNXh0SkZlQUFpVTRIUklRUTZmdGNOalJmWFd4eUlKd0dV?= =?utf-8?B?NVhtVGR0WUdCZ2huUktWSU02TUovdGNTa2U3bjdZYW50VHR0S1FxYW51UWJn?= =?utf-8?B?aldzeXRYbVBjcDRLcFhUdWRwVGVZUS92SUhCSFpWVzFDNnViTXVkdEFNVTJD?= =?utf-8?B?ZCtEOHJzd3lJRWxoRlNyZ3ExNmF2UjZTTEsvNUN4a3IxWGMvRTR4YXA2K1lR?= =?utf-8?B?a1VJNk9zMnQ5aGZSQ3NYOC9YZVlPVlh5WU5OQ0VXOGQ5cEc0czAzSHJGamty?= =?utf-8?B?OFFLejFKRFc3Wm1yTmNOYUpiWFloT1NXTTA4V0ZBM2VqaWg2L1dNaXNpUHpD?= =?utf-8?B?NGV0NzJyRlpHYlMwU0F6M1BZdWpQL1VYYjdJWG1pR1hpbjhXUFBhZWFJQ0JR?= =?utf-8?B?RmlLSitGampzOGY5ZmxuUWFxVVVLVlJlbFdIZWw1OUdoTWxDU3U5dFBKZVk0?= =?utf-8?B?UHI5UStFdENlaURYTDRoek03VTFIRUxIZlhJMHQvQjdTRGRZUEt1Rno0cnpv?= =?utf-8?B?SmR4dWVoNGxXTDFZVFRTTUZ5M1FIQWpaWUJNSldUYkl6Qzg3YTlEK2RaL2xE?= =?utf-8?B?RitibnEzV0JvREVsWDdZY3UzSk5NRnlhOXg3bDlpTVJJVlRJTjVqdWVZdUI4?= =?utf-8?B?WVlZdW1MOGZ5Yk1ITS9wVFZYUzE3bzdjZXpSSXMvYWpjcjBFVUFSR3k0ZFBo?= =?utf-8?B?QzYyY2x0Z2dIaTJmdzJ4VE9sV0VtL0N4VjlwRnVFVzBEQnRKUlhrTlhQSWU4?= =?utf-8?B?QmwvOHdyQnpiUFgwUVpNbThwRzZpUVdScjd0TnBSelBlcktSTkpXTFNFY2R4?= =?utf-8?B?V1AvTmNvQkZBbUU0R3o5Q1BDYkthamQ0eFdTQ01UaXpUbUlIV2VOOUdKeE5P?= =?utf-8?B?dThlNFhiZWpibW9MUXk0b2ZZU0JDMWZxUnpWcm94a3MrZklpajdRTWI3elZk?= =?utf-8?B?aGphMXJOWXBpSjhvd3dVQzdURHRvTTRkR2tkTDAvVDFPTVR5cFNsVnA3N0p5?= =?utf-8?B?SGV5VU1TSHJLMlUzb3UyODhwQUtqdVJqdndTVkVJdlRnS0laa1dvSTV2VjBG?= =?utf-8?B?d0o0UkJROEQrVVZxcTFvTXQxRG5ORFZUUHhCbExlR1gvemwyNFEvanBIWVdN?= =?utf-8?B?NVpFNVBEMnVaSmg4UVZlRytpRjkyR0M0K0Z5UGdOMm1TWjRIWnA1NFJYSVd6?= =?utf-8?B?eS9ZVUxHMkJmVUhyM3Vnb0cwNGhYZWNNUDNjbEFPZ1pCL2dXUCs0eVN0VmFv?= =?utf-8?B?ZVMreDBOV3R6UjViN1A5d0RqMDVBaEhrRzMzVVRKS2szT3B1RmFReUQrRDZ5?= =?utf-8?B?alZWQzRKZGpDcDltOFUrV215SXJCazY0MnVyNnZ0ajFDYkxSOGVjS3FXWmVI?= =?utf-8?B?RW41Wks1RGRBalV0UTZOcFBVdFJweTBKd2hpdWkyTitRYjg2K0x0LzZpZHhC?= =?utf-8?B?WmllY3kwSDc2VU1YNEdIRkhCQjhHQ2ladjVPbGpRS1ZYQXBxc1N6M2gwODdF?= =?utf-8?B?WExzWUUzN1p6OXY2bmRjTmYyd1NaMElsYldQN2dkSFRxNjc1SXVjSWN2Ymw1?= =?utf-8?B?a0JENk5jeWZ0VmdCNEJLaHlZcXNQM2orV2JhS3dtOTZobm1mS0xRYTRYRm8x?= =?utf-8?B?b2FWWkF0Q3NoaTAvTDJiTENFQkFXRFcvVEF4UDdJTWxrWTFvMS9pc0hwMCtn?= =?utf-8?B?UVdxREpvSnJ0RGJzRUZDOUZFWmc3MjhrSkRmdGhvcFNyUmpScmN5dWk1aGYr?= =?utf-8?B?VENhMjJ1a3BXKzVXNHRIdW9KeENyZGRReXBReS9tMG9LVTEzbXh3VEpUMW51?= =?utf-8?B?M2VOYkpnZk1mU2lUT25aQ2V6VWJSaGdWRzJlQkVRL0t6SHZNL0JRUW1pc0xK?= =?utf-8?B?MmVhUVloMkp4RXptMDV2ZXArTUFvM0JwYVoveWxDamFDOTNKKzFFUWIzUXJx?= =?utf-8?B?MSt4K3o1a0I3b1g2b1RhTUw0cHlsT05RS1hHeFVsSEFSbHNtTmJnS2xsZU84?= =?utf-8?B?Y2ZDM0V0aGVQcjR3MVhnUDVHTno5Sm9WdlpaNTNCRHErOW1uSkxTVFdUV3Zx?= =?utf-8?B?QkMyUVpjTThBSVJJVXErWDg0M3BpeUVjaXE3S1VzOWZhcWlrVDl2RkJadkZy?= =?utf-8?B?cnpUR3BycWdLVkpmTU1NZVF2V2JXR2hZRUg4QkJRZDdtSHFhSjdNRXYyT2VO?= =?utf-8?B?cXdsVi9DLzg3eXRkUGN2b0t5U0lRa2dMSFhBNFd5REVZeFZCUHlnVHJMTm85?= =?utf-8?B?RkFLaGJlbDJuU2NUZW1mbWF6TENmeFVlcmJzT3FJWGZGSTJmUm93QT09?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6347.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3d6c163-c2cf-4618-1f2b-08da29e62373 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2022 13:42:43.9998 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YMMMD6+4ZBsSse+b5bu7nhie/GttSyB8dhYDzKtV3eP+5RwSKqU1I98MHHajagsjGYixiSi8fyNjPsnLCjtDCI8ZRt4vUYzFWuft/jvoqYM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4428 LSAibWFpbiIgdGhyZWFkIHdhaXRzIGZvciAicmVhY2hlZCBjb3VudCA9IGNwdSBjb3VudCIsIGFu ZCB0aGVuIHNldHMgInRhcmdldCBuZXh0IHN0YXRlID0gY3VycmVudCBzdGF0ZSINCg0KT29wcw0K DQotICJtYWluIiB0aHJlYWQgd2FpdHMgZm9yICJyZWFjaGVkIGNvdW50ID0gY3B1IGNvdW50Iiwg YW5kIHRoZW4gc2V0cyAiY3VycmVudCBzdGF0ZSA9IHRhcmdldCBuZXh0IHN0YXRlIg0K