From win-pv-devel-bounces@lists.xenproject.org Wed Jan 18 18:49:14 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Wed, 18 Jan 2023 18:49:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.480754.745306 (Exim 4.92) (envelope-from ) id 1pIDUm-0003If-Dq; Wed, 18 Jan 2023 18:49:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 480754.745306; Wed, 18 Jan 2023 18:49:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pIDUm-0003IY-Ax; Wed, 18 Jan 2023 18:49:12 +0000 Received: by outflank-mailman (input) for mailman id 480754; Wed, 18 Jan 2023 18:49:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pIDUk-0003IS-GG for win-pv-devel@lists.xenproject.org; Wed, 18 Jan 2023 18:49:10 +0000 Received: from mx0a-00699901.pphosted.com (mx0a-00699901.pphosted.com [205.220.167.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c777fc1e-9760-11ed-b8d1-410ff93cb8f0; Wed, 18 Jan 2023 19:49:05 +0100 (CET) Received: from pps.filterd (m0276393.ppops.net [127.0.0.1]) by mx0a-00699901.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30IIf5bu011914 for ; Wed, 18 Jan 2023 18:49:03 GMT Received: from usg02-cy1-obe.outbound.protection.office365.us (mail-cy1usg02lp0176.outbound.protection.office365.us [23.103.199.176]) by mx0a-00699901.pphosted.com (PPS) with ESMTPS id 3n3m0v9g55-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 18 Jan 2023 18:49:03 +0000 Received: from PH1P110MB0971.NAMP110.PROD.OUTLOOK.COM (2001:489a:200:177::12) by PH1P110MB1411.NAMP110.PROD.OUTLOOK.COM (2001:489a:200:18f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Wed, 18 Jan 2023 18:48:59 +0000 Received: from PH1P110MB0971.NAMP110.PROD.OUTLOOK.COM ([fe80::7fed:b8bb:3268:feac]) by PH1P110MB0971.NAMP110.PROD.OUTLOOK.COM ([fe80::7fed:b8bb:3268:feac%6]) with mapi id 15.20.5944.019; Wed, 18 Jan 2023 18:48:59 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: c777fc1e-9760-11ed-b8d1-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector5401; d=microsoft.com; cv=none; b=icp/SwTWBRPnikSF4MkoLkV40RjwI3+PvyZpMRb9HxBHlwL5INPmsbS7uoH4lQ6gBO80LSVVyMFOJsgJTgoef137qrHSKzeAPZJqZlIh1LE+jPHZiSlKLmM6zctNlqn7pkEgqsqd9kuUT5SKJek+DC339y2gJsL0zwnFMlBwg8i024jokydI0tv3nNK+35ssEGF+pFfBCzcNBrELQjmJbksTbrFJai+89dPKDi9J4akTNwLuyjVbenGrGymKCf2TCK42TW8R+9TNzFJJA5nboB0Lk+5QmFWislwrChL55YL2SmHWjCZfwS7pvEtco86ewRCHO4Lo9PNdkcjRoyAdEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector5401; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Pi9cZMSIDJS518LL0r9Ue5cVB0/fMxENJhr6z+k5+IY=; b=hQ10PJjJ+64nADusI+uigaN8qsVrzNX1xTuqZDZBGrKJ6yuhGTujiW1+esrx9KmVW3YxRa3kgqoUVTWL2acwC1b/nv2Fl8iLqSWGtOQJ173Owc4k3JvNhygq7L486T+nRBT2WB5RIMDsyRGy1x4qiVD38CdS7dtJ3ULGwqr8FqgUy/3ZzAay9WWGcxbT5Dmqw7hyXvv2gNgyUh1ewVVrPg2vc5qQmBrY+NZvWIpbvf9bapo/wHRB20XSQUmYX/+tkSoaijQ/03p+YVuY1cRw3eKRVb11D+kD5xOlciRHBkdm96pPSwnKEElTHFiJ+nIV8Nf65pkMA/dyk5NfY2m81A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ainfosec.com; dmarc=pass action=none header.from=ainfosec.com; dkim=pass header.d=ainfosec.com; arc=none From: Joel Upham To: "win-pv-devel@lists.xenproject.org" Subject: Lazily construct slab commit causes BSOD/freeze on xen 4.16 Thread-Topic: Lazily construct slab commit causes BSOD/freeze on xen 4.16 Thread-Index: AQHZK20C375p4jUD802sUWH5S2b6dg== Date: Wed, 18 Jan 2023 18:48:59 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH1P110MB0971:EE_|PH1P110MB1411:EE_ x-ms-office365-filtering-correlation-id: 4a354a6b-29d9-47c4-2da3-08daf984a8f6 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2GlEH2AG9z7kRxn70ZigaY++eH/rrB+QgLCOFvomaUoL+Jpqsx04VVWcDGScQ+x59wpneidbBFmp2s/a5F0yTH9kwes56rYGW8MqBkB2Ttg3qfsI9LoJmdxAW2hsK3p5ZHjzXN8psZAcdrMJ3bfj1o1ljKjnBmmgMW+msMxS4f4WF76IGyd1jDJHMVlAd0rJ97tzyI1oVu6mHPYq6xrVZCgEJt4tr8k/n1pP30USemV16BF5vfezkf/CNG7IpHlTUixOAEgXFC9NOSMMK+S+Opom0iP7iMtMU1JqYjsENb0vpmw0CkQU3PQBQ7LKe9IwaipUuwaF7HBR8NLviUgbcjIUifAeLgzfpqisjjUWtLvN4mKQ5Z7WDlEpyDpF71C57R4GB04aFdyaSldkxdT5QlMl2C3pcvGXrMYVNVaMzptSAc3rmouepXXSzWwletKQMgM772ktt88YTGK/K6+lRCsxLf1EMORJp5hoBXY3yPWI40Vv7+b0YV2Xp3V5lCxgQs7UgGIWRHKvP0GePGN+ekqtqqmu9e3EyohqXiI5IzGASc9mRzjnCbHaOMKyPRHp7RSrED59eOgxY8bWTf52R8sVlPmIjXcVGTt8B4iJsBk0lkUOIjPxmGqQkgAy5tzE x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH1P110MB0971.NAMP110.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39830400003)(366004)(136003)(451199015)(26005)(66446008)(8676002)(8936002)(64756008)(76116006)(66476007)(5660300002)(9686003)(66946007)(52536014)(66556008)(4744005)(41300700001)(19627405001)(66899015)(186003)(2906002)(33656002)(38070700005)(71200400001)(7696005)(508600001)(86362001)(6916009)(6506007)(55016003)(122000001)(41320700001)(38100700002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: Z0Lohqmc5wRRSNrJYJC1iNegw05f7kpWaQsSQ3GI5gnz3Yzv4wtFZUdY8wwz0Tr0a2x0ntgdu1oMcdLPUImDgXqcVyh5IUTwWFEaYEfY7hWB3sfrwwfqYHsIo9L4XFo9jj73/fPy37Dda3nVLCNEpMFovu1wDH/ZgaYEWOVkxF9tE9Y6gS55T6z0uDRprGCrFh/ppipkao+hI15Bu8Qt0mARetvHyj1cB1Vx1+hmkyf1AmJFqTSItj64oVbSu/Rkb9HkJyalHtWzsPEfHPW+RfL2C06tMXieZOq59MjDRY1Mg7ATaaR/cIxjiepSyxkzcF4jRyrIBPYUChVX2hNv+FNOdGadJRavTgy4S3dsqzKTWWk0Hdkx1iaoAQf4EG88cRlzVwnJ+AkPkaBA4J6Z3J2J6HPqpZ6+W+gSsOyEcBw= Content-Type: multipart/alternative; boundary="_000_PH1P110MB097150771C31DEC83DD634CCA4C79PH1P110MB0971NAMP_" MIME-Version: 1.0 X-OriginatorOrg: ainfosec.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH1P110MB0971.NAMP110.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 4a354a6b-29d9-47c4-2da3-08daf984a8f6 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2023 18:48:59.1895 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 82614573-95ee-4948-be35-3c0a8fc6ff9c X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH1P110MB1411 X-Proofpoint-GUID: cN4dIm1qJkEbqdl3FBP0qHzsyyacIZJ5 X-Proofpoint-ORIG-GUID: cN4dIm1qJkEbqdl3FBP0qHzsyyacIZJ5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-18_05,2023-01-18_01,2022-06-22_01 --_000_PH1P110MB097150771C31DEC83DD634CCA4C79PH1P110MB0971NAMP_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Our project pulled in the newest master commits and have been experiencing = guest freezes/BSODs on our Xen 4.16 host systems. I rolled back commit e5d= b0e07f7d2de37bb8740cdaa63caecfe4fe3e1 and was able to mitigate the issue, b= ut I was wondering if anyone else has experienced this side effect. If not= what version of xen have you been working on this development in hopes of = finding the offending xen code? Any information would be greatly appreciat= ed. -Joel --_000_PH1P110MB097150771C31DEC83DD634CCA4C79PH1P110MB0971NAMP_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable
Our project pulled in the = newest master commits and have been experiencing guest freezes/BSODs on our Xen 4.16 host systems.  I rolled back comm= it e5db0e07f7d2de37bb8740cdaa63caecfe4fe3e1 and was able to mitigate t= he issue, but I was wondering if anyone else has experienced this side effe= ct.  If not what version of xen have you been working on this development in hopes of finding the offending xen code?&nb= sp; Any information would be greatly appreciated.

-Joel
--_000_PH1P110MB097150771C31DEC83DD634CCA4C79PH1P110MB0971NAMP_-- From win-pv-devel-bounces@lists.xenproject.org Thu Jan 19 10:44:06 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 19 Jan 2023 10:44:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.480907.745593 (Exim 4.92) (envelope-from ) id 1pISOp-0005HA-FX; Thu, 19 Jan 2023 10:44:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 480907.745593; Thu, 19 Jan 2023 10:44:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pISOp-0005H3-Bl; Thu, 19 Jan 2023 10:44:03 +0000 Received: by outflank-mailman (input) for mailman id 480907; Thu, 19 Jan 2023 10:02:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pIRku-0006VB-7u for win-pv-devel@lists.xenproject.org; Thu, 19 Jan 2023 10:02:48 +0000 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [2a00:1450:4864:20::136]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6c059698-97e0-11ed-b8d1-410ff93cb8f0; Thu, 19 Jan 2023 11:02:46 +0100 (CET) Received: by mail-lf1-x136.google.com with SMTP id m6so2436877lfj.11 for ; Thu, 19 Jan 2023 02:02:46 -0800 (PST) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 6c059698-97e0-11ed-b8d1-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Z3SRq1Gj48JjFu321FBdnbppXNEUmvHGBT880QYmc2w=; b=MJ+VcPr40aDnUaGWYXZxh+p6gcgR8GNxXYlvGax9kvSapMLqFJXPp32lOLIdRSjAUu XnWFk+j5yStCuti6/g/n2Uk3On5B5VlXkM7HnY6G+pqDlbqG/iHY7HfVmiOk9zxa1DMf b+zXeBp1Hji/akILKoh7domtjVfIppY+ceevo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Z3SRq1Gj48JjFu321FBdnbppXNEUmvHGBT880QYmc2w=; b=v/Mypq7DRu8l8RAXVYSaaUPNG8YlDfabUgSPDkRyYPTrfY4YwvHZ5JVja100jqY5Oa O7kWdrmxXQkgp8pMTR+piCLDVLFiwSpGtc7c0v5jcgrBlbF9JdMWF+ZMoOGX1y7m54Lf 2GZXrnbBgazB3nWpBkM9BL71SCEk0Af5KPHcNf9rFLfxacqTB2YZAy++2u7ui7cTHRHe MeGQpJcTLtpWo52/89ZA6ccRplp+VGrPthl2iIOyUOwpYy93y74QI4HMgqOEzT4HHAWF qoW6TK756ufbaRD9q/bsX6KpTbHA05e8t7HpiHIs1nGutXaSvwi3Qs7He2Xxu6JiRiDC xvjA== X-Gm-Message-State: AFqh2kqyvYNrEvQBLAHUYIo4LfZ42L40ukNIV6DeYsUiycb4zIcATE0P 8bLDaNHA1aqJiQXo8f/liSdXXksS3KthdRcbZTL70QMzONG8 X-Google-Smtp-Source: AMrXdXvvGvpbE5cz3s0A0kDZy4X/ef32lOoZYP0Ol6AZUGoDPayyOqOfxzcIydnAUh8soKFC87YyB46EWb0OdhVGtDc= X-Received: by 2002:ac2:4e95:0:b0:4b5:9845:1578 with SMTP id o21-20020ac24e95000000b004b598451578mr465818lfr.301.1674122565517; Thu, 19 Jan 2023 02:02:45 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Owen Smith Date: Thu, 19 Jan 2023 10:02:34 +0000 Message-ID: Subject: Re: Lazily construct slab commit causes BSOD/freeze on xen 4.16 To: Joel Upham Cc: "win-pv-devel@lists.xenproject.org" Content-Type: multipart/mixed; boundary="000000000000d447fa05f29b08c4" --000000000000d447fa05f29b08c4 Content-Type: multipart/alternative; boundary="000000000000d447f705f29b08c2" --000000000000d447f705f29b08c2 Content-Type: text/plain; charset="UTF-8" I've not seen BSODs in this area with XenServer drivers which are based on the same commit, though we are carrying a patch to this area. Do you have any details about the crash (crashdumps, bugcheck IDs, etc) that could help pinpoint the problem? Attached is the patch XenServer's tools are currently carrying. Owen On Wed, Jan 18, 2023 at 6:49 PM Joel Upham wrote: > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > unless you have verified the sender and know the content is safe. > Our project pulled in the newest master commits and have been experiencing > guest freezes/BSODs on our Xen 4.16 host systems. I rolled back > commit e5db0e07f7d2de37bb8740cdaa63caecfe4fe3e1 and was able to mitigate > the issue, but I was wondering if anyone else has experienced this side > effect. If not what version of xen have you been working on this > development in hopes of finding the offending xen code? Any information > would be greatly appreciated. > > -Joel > --000000000000d447f705f29b08c2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I've not seen BSODs in this area with XenServer driver= s which are based on the same commit, though we are carrying a patch to thi= s area.
Do you have any details about the crash (crashdumps, bugcheck I= Ds, etc) that could help pinpoint the problem?

Att= ached is the patch XenServer's=C2=A0tools are currently carrying.
=


Owen

On Wed, Jan 18, 2023 at 6:49 P= M Joel Upham <uphamj@ainfosec.com= > wrote:
=
[CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachment= s unless you have verified the sender and know the content is safe.<= /td>
Our project pull= ed in the newest master commits and have been experiencing guest freezes/BSODs on our Xen 4.16 host systems.=C2=A0 I rolled back comm= it=C2=A0e5db0e07f7d2de37bb8740cdaa63caecfe4fe3e1 and was able to mitigate t= he issue, but I was wondering if anyone else has experienced this side effe= ct.=C2=A0 If not what version of xen have you been working on this development in hopes of finding the offending xen code?=C2= =A0 Any information would be greatly appreciated.

-Joel
--000000000000d447f705f29b08c2-- --000000000000d447fa05f29b08c4 Content-Type: application/octet-stream; name="0001-Allow-removal-of-current-Slab.patch" Content-Disposition: attachment; filename="0001-Allow-removal-of-current-Slab.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_ld2xaq360 RnJvbSA0Y2UwZTY5Yzg5NjRlMDcxZTY4ZDQ4NDcwMTlhMTRjYTBmYThjMmVjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQ0KRnJvbTogT3dlbiBTbWl0aCA8b3dlbi5zbWl0aEBjaXRyaXguY29tPg0K RGF0ZTogVHVlLCAyMiBOb3YgMjAyMiAxNDozNDoyNCArMDAwMA0KU3ViamVjdDogW1BBVENIXSBB bGxvdyByZW1vdmFsIG9mIGN1cnJlbnQgU2xhYg0KDQpTaWduZWQtb2ZmLWJ5OiBPd2VuIFNtaXRo IDxvd2VuLnNtaXRoQGNpdHJpeC5jb20+DQotLS0NCiBzcmMveGVuYnVzL2NhY2hlLmMgfCAxNyAr KysrKysrLS0tLS0tLS0tLQ0KIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDEwIGRl bGV0aW9ucygtKQ0KDQpkaWZmIC0tZ2l0IGEvc3JjL3hlbmJ1cy9jYWNoZS5jIGIvc3JjL3hlbmJ1 cy9jYWNoZS5jDQppbmRleCBiMWQzZmU1Li41NjhkYmQ1IDEwMDY0NA0KLS0tIGEvc3JjL3hlbmJ1 cy9jYWNoZS5jDQorKysgYi9zcmMveGVuYnVzL2NhY2hlLmMNCkBAIC00NzAsMTQgKzQ3MCwxMSBA QCBDYWNoZURlc3Ryb3lTbGFiKA0KICAgICBBU1NFUlQzVShDYWNoZS0+Q291bnQsID49LCBDYWNo ZU1hc2tTaXplKFNsYWItPkFsbG9jYXRlZCkpOw0KICAgICBDYWNoZS0+Q291bnQgLT0gQ2FjaGVN YXNrU2l6ZShTbGFiLT5BbGxvY2F0ZWQpOw0KIA0KLSAgICAvLw0KLSAgICAvLyBUaGUgb25seSBy ZWFzb24gdGhlIGN1cnNvciBzaG91bGQgYmUgcG9pbnRpbmcgYXQgdGhpcyBzbGFiIGlzDQotICAg IC8vIGlmIGl0IGlzIHRoZSBvbmx5IG9uZSBpbiB0aGUgbGlzdC4NCi0gICAgLy8NCiAgICAgaWYg KENhY2hlLT5DdXJzb3IgPT0gJlNsYWItPkxpc3RFbnRyeSkNCi0gICAgICAgIENhY2hlLT5DdXJz b3IgPSAmQ2FjaGUtPlNsYWJMaXN0Ow0KKyAgICAgICAgQ2FjaGUtPkN1cnNvciA9IFNsYWItPkxp c3RFbnRyeS5CbGluazsNCiANCi0gICAgUmVtb3ZlRW50cnlMaXN0KCZTbGFiLT5MaXN0RW50cnkp Ow0KKyAgICBpZiAoUmVtb3ZlRW50cnlMaXN0KCZTbGFiLT5MaXN0RW50cnkpKQ0KKyAgICAgICAg Q2FjaGUtPkN1cnNvciA9ICZDYWNoZS0+U2xhYkxpc3Q7DQogDQogICAgIEFTU0VSVChDYWNoZS0+ Q3Vyc29yICE9ICZDYWNoZS0+U2xhYkxpc3QgfHwNCiAgICAgICAgICAgIElzTGlzdEVtcHR5KCZD YWNoZS0+U2xhYkxpc3QpKTsNCkBAIC02MTMsMTcgKzYxMCwxNyBAQCBhZ2FpbjoNCiAgICAgICAg IFNsYWIgPSBDT05UQUlOSU5HX1JFQ09SRChMaXN0RW50cnksIFhFTkJVU19DQUNIRV9TTEFCLCBM aXN0RW50cnkpOw0KIA0KICAgICAgICAgT2JqZWN0ID0gQ2FjaGVHZXRPYmplY3RGcm9tU2xhYihT bGFiKTsNCi0gICAgICAgIEFTU0VSVChPYmplY3QgIT0gTlVMTCk7DQogDQotICAgICAgICBpZiAo Q2FjaGVNYXNrQ291bnQoU2xhYi0+QWxsb2NhdGVkKSA9PSBDYWNoZU1hc2tTaXplKFNsYWItPkFs bG9jYXRlZCkpDQorICAgICAgICBpZiAoQ2FjaGVNYXNrQ291bnQoU2xhYi0+QWxsb2NhdGVkKSA9 PSBDYWNoZU1hc2tTaXplKFNsYWItPkFsbG9jYXRlZCkpIHsNCiAgICAgICAgICAgICBDYWNoZS0+ Q3Vyc29yID0gU2xhYi0+TGlzdEVudHJ5LkZsaW5rOw0KKyAgICAgICAgICAgIGlmIChPYmplY3Qg PT0gTlVMTCkNCisgICAgICAgICAgICAgICAgZ290byBhZ2FpbjsNCisgICAgICAgIH0NCiAgICAg fQ0KIA0KICAgICBpZiAoT2JqZWN0ID09IE5VTEwpIHsNCiAgICAgICAgIE5UU1RBVFVTIHN0YXR1 czsNCiANCi0gICAgICAgIEFTU0VSVDNQKENhY2hlLT5DdXJzb3IsID09LCAmQ2FjaGUtPlNsYWJM aXN0KTsNCi0NCiAgICAgICAgIHN0YXR1cyA9IENhY2hlQ3JlYXRlU2xhYihDYWNoZSk7DQogICAg ICAgICBpZiAoTlRfU1VDQ0VTUyhzdGF0dXMpKSB7DQogICAgICAgICAgICAgQVNTRVJUKENhY2hl LT5DdXJzb3IgIT0gJkNhY2hlLT5TbGFiTGlzdCk7DQotLSANCjIuMzIuMC53aW5kb3dzLjENCg0K --000000000000d447fa05f29b08c4-- From win-pv-devel-bounces@lists.xenproject.org Thu Jan 19 17:56:08 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 19 Jan 2023 17:56:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.481244.746011 (Exim 4.92) (envelope-from ) id 1pIZ8v-0002D4-4k; Thu, 19 Jan 2023 17:56:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 481244.746011; Thu, 19 Jan 2023 17:56:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pIZ8v-0002Cx-1E; Thu, 19 Jan 2023 17:56:05 +0000 Received: by outflank-mailman (input) for mailman id 481244; Thu, 19 Jan 2023 17:56:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pIZ8t-0002Cr-KN for win-pv-devel@lists.xenproject.org; Thu, 19 Jan 2023 17:56:03 +0000 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [2a00:1450:4864:20::335]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8879e87e-9822-11ed-91b6-6bf2151ebd3b; Thu, 19 Jan 2023 18:56:02 +0100 (CET) Received: by mail-wm1-x335.google.com with SMTP id l8so2170066wms.3 for ; Thu, 19 Jan 2023 09:56:00 -0800 (PST) Received: from [10.95.100.115] (54-240-197-225.amazon.com. [54.240.197.225]) by smtp.gmail.com with ESMTPSA id p13-20020a05600c1d8d00b003daf7721bb3sm5524134wms.12.2023.01.19.09.55.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Jan 2023 09:55:58 -0800 (PST) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 8879e87e-9822-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:organization:reply-to :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:from:to:cc:subject:date:message-id:reply-to; bh=X5/7DnDE4++BBVOgDR5wCGe8QFUmu3vVGJtlBOWYxZ4=; b=JlaEPoiFodeE1OnvfV5H3lnMEgtRnxLFgql+AVctKQPZqVKxFyeG7syq7+aPUArOFL M8KKm82441b/JmT7NU3N0clMYIg2eQTrnCP00tSPlBCNIRdSK5YFO7vAeQs8e5vR48Ce lNw1Jgn76/2/q/te1SrXdoV0kGI9kLtiLinYgfVyJo/8IbZ9f1bTkQPgKOc90KrSBN3r 5BWkz6Y89cymTeB5o5hEcANhDbW53LUqg1/N0z08UuOMpGg+Pk7YhRC4ygH52wH3GRvZ KXVRXkV9MV/TyfmHDlPbYkmnuZLdcSlxHyL4dE6ha8aB8+JUXVITzdlIMIOTQJbTR8H+ NpJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:reply-to :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=X5/7DnDE4++BBVOgDR5wCGe8QFUmu3vVGJtlBOWYxZ4=; b=LyB/N71Gagi62zPHT3056PYjkfcjUXFT2FuBLDfYCjnAORETlBbsqMlDwcxcre4G5s 2OgngiAG5+2haGyEbWD1tfBvYYRiaDcfcZ5H/B7uWZ8KKcOR0Tr314pI3rZKuA01nzKC BC6NLdNPZf6R14hQcjgyIACodoML72n0/HhMN0ejiGbtTfp//RQCIS2FhuuKT51/SgHY M8o4l99H+LTWvFA3R97qWKnVEgUOhCE8vKpntWcFmykeToG/jlBCqtoxjDN7lHAEwKI8 zSuI9lqIv/C1kjGxtOc/lKI+esA02Xq5C1Oph74KbTsyCeSbIjpgpiMktLATroor/LjE QRNw== X-Gm-Message-State: AFqh2krjSLgsnKOwz6ogLL0WtvL/4rqLU55UMJ3MEpwudyr/V04k7hx+ Hq7w9LDaiv7ZjuwhXRtP0MbM3rcC7HfkVw== X-Google-Smtp-Source: AMrXdXsXFmf8j84c7Ma4snYnwL+ZGw9UulodJYMVtaixAXke1lznC2zmR8Ja7HcbHmbqPeGjGr/6Vg== X-Received: by 2002:a05:600c:4f45:b0:3cf:68d3:3047 with SMTP id m5-20020a05600c4f4500b003cf68d33047mr11104609wmq.41.1674150960198; Thu, 19 Jan 2023 09:56:00 -0800 (PST) From: Paul Durrant X-Google-Original-From: Paul Durrant Message-ID: <1097bc9b-9fd0-7ded-b42e-279f42894cbb@xen.org> Date: Thu, 19 Jan 2023 17:55:57 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: Lazily construct slab commit causes BSOD/freeze on xen 4.16 To: win-pv-devel@lists.xenproject.org References: Content-Language: en-US Reply-To: paul@xen.org Organization: Xen Project In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 19/01/2023 10:02, Owen Smith wrote: > I've not seen BSODs in this area with XenServer drivers which are based > on the same commit, though we are carrying a patch to this area. > Do you have any details about the crash (crashdumps, bugcheck IDs, etc) > that could help pinpoint the problem? > > Attached is the patch XenServer's tools are currently carrying. > Owen, why did/do you need this patch? Did you try running with CacheAudit() turned on (as it is by default in a debug build)? Paul From win-pv-devel-bounces@lists.xenproject.org Mon Jan 30 14:42:48 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 30 Jan 2023 14:42:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.487017.754497 (Exim 4.92) (envelope-from ) id 1pMVMr-0004C0-0B; Mon, 30 Jan 2023 14:42:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 487017.754497; Mon, 30 Jan 2023 14:42:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pMVMq-0004Bt-Td; Mon, 30 Jan 2023 14:42:44 +0000 Received: by outflank-mailman (input) for mailman id 487017; Mon, 30 Jan 2023 14:42:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pMVMq-0004Bn-8i for win-pv-devel@lists.xenproject.org; Mon, 30 Jan 2023 14:42:44 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 57082682-a0ac-11ed-b8d1-410ff93cb8f0; Mon, 30 Jan 2023 15:42:41 +0100 (CET) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 57082682-a0ac-11ed-b8d1-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675089761; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=oUhICHQtKdpBqJXcPyQYo6Sw4qmKurmbzM4Tzq7Kydc=; b=aASSQ0YhwSGRJ4fUCZevrYpvCRucd5ELAjcqFrMesfaIcWBqfHCgztvj 7IEVBkbzs0woEWPicq6O1101+UHPNPxe04B2limWVGCH2l96cvTL928jV cWflyEaKzG2Nie8GQo7QF36nbljm+jgFDI68XEAa4yXUkFWec2wD+qXaX A=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 93712796 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:wSRwIqi7k7fuP9IaB1Xae3XiX161FxAKZh0ujC45NGQN5FlHY01je htvC22AM62KYTb0Kd8iOdu2oU5S7JDTx9VmG1BupS80FC4b9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWt0N8klgZmP6sT5QSGzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQzF2EELVOkxNju55u7ELA2iPoSHOzCadZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJYw1MYH49tL7Aan3XdCJVrhSOoKsr40DYzRBr0airO93QEjCPbZQOwR/C+ TOYl4j/KhcgDv2O5iu1yymDltXewyPdd9sDKYTto5aGh3XMnzdOWXX6T2CTvvi/z1agHt5SN UEQ0i4vtrQpslymSMHnWB+1q2LCuQQTM+e8CMVjtlvLkPCNpV/EWC5dFGUphMEaWNEebgN73 xzKuJDTXRtGsOfME3yjx4exhGbnUcQKFlMqaSgBRAoDxtDspoAvkx7CJupe/L6JYs7dQm+pn W3TxMQqr/BK1JNQif3nlbzSq2j0zqUlWDLZ8ek+soiNygpiLLCoaIWzgbQwxaYRdd3JJrVtU ZVtpiR/0AzsJcvW/MBuaL9XdF1M2xpiGGC0vLKXN8N9nwlBAlb6FWyq3BlwJV1yLuEPciLzb UnYtGt5vcEMYSPzMvYnP9rgVKzGKJQM8vy8BpjpgidmOMAtJGdrAgkxDaJv44wduBd1yvxuU XtqWc2tEWwbGcxaIMmeHo8gPUsQ7nlmnwv7HMmrpylLJJLCPBZ5v59ZagrRBg34hYvYyDjoH yF3bJXWlEQPDL2nMkE6M+c7dDg3EJTyPriuw+Q/SwJJClMO9L0JYxMJ/Y4cRg== IronPort-HdrOrdr: A9a23:4anEwKvzmoQrNQSZKCuMIF3A7skDstV00zEX/kB9WHVpm6yj+v xG/c5rsCMc7Qx6ZJhOo7+90cW7L080lqQFg7X5X43DYOCOggLBQL2KhbGI/9SKIVycygcy78 Zdm6gVMqyLMbB55/yKnTVRxbwbsaW6GKPDv5ag8590JzsaD52Jd21Ce36m+ksdfnggObMJUK Cyy+BgvDSadXEefq2AdwI4t7iqnaysqHr+CyR2fiIa1A== X-IronPort-AV: E=Sophos;i="5.97,258,1669093200"; d="scan'208";a="93712796" From: Owen Smith To: CC: Owen Smith Subject: [PATCH] Fix ASSERT failures in error paths Date: Mon, 30 Jan 2023 14:42:19 +0000 Message-ID: <20230130144219.4056593-1-owen.smith@citrix.com> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain * StorePrepareRequest can fail if a non-NULL transaction is passed. Check the return value where a transaction is passed to StorePrepareRequest * StoreSubmitRequest should zero the request if it fails. Signed-off-by: Owen Smith --- src/xenbus/store.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/xenbus/store.c b/src/xenbus/store.c index 5ffea1f..778414c 100644 --- a/src/xenbus/store.c +++ b/src/xenbus/store.c @@ -966,6 +966,8 @@ StoreSubmitRequest( fail1: Error("fail1 (%08x)\n", status); + RtlZeroMemory(Request, sizeof (XENBUS_STORE_REQUEST)); + return NULL; } @@ -1571,17 +1573,18 @@ StoreTransactionEnd( XS_TRANSACTION_END, (Commit) ? "T" : "F", 2, NULL, 0); - ASSERT(NT_SUCCESS(status)); + if (!NT_SUCCESS(status)) + goto fail1; Response = StoreSubmitRequest(Context, &Request); status = STATUS_NO_MEMORY; if (Response == NULL) - goto fail1; + goto fail2; status = StoreCheckResponse(Response); if (!NT_SUCCESS(status) && status != STATUS_RETRY) - goto fail2; + goto fail3; StoreFreeResponse(Response); ASSERT(IsZeroMemory(&Request, sizeof (XENBUS_STORE_REQUEST))); @@ -1605,11 +1608,13 @@ done: return status; -fail2: +fail3: ASSERT3U(status, !=, STATUS_RETRY); StoreFreeResponse(Response); +fail2: + fail1: ASSERT(IsZeroMemory(&Request, sizeof (XENBUS_STORE_REQUEST))); -- 2.39.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Mon Jan 30 14:54:54 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 30 Jan 2023 14:54:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.487030.754511 (Exim 4.92) (envelope-from ) id 1pMVYc-0005yC-2i; Mon, 30 Jan 2023 14:54:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 487030.754511; Mon, 30 Jan 2023 14:54:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pMVYb-0005y5-W0; Mon, 30 Jan 2023 14:54:53 +0000 Received: by outflank-mailman (input) for mailman id 487030; Mon, 30 Jan 2023 14:54:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pMVYb-0005xx-0P for win-pv-devel@lists.xenproject.org; Mon, 30 Jan 2023 14:54:53 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0ac8f5ae-a0ae-11ed-9ec0-891035b88211; Mon, 30 Jan 2023 15:54:51 +0100 (CET) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 0ac8f5ae-a0ae-11ed-9ec0-891035b88211 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675090491; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=IzvF47+SoeeHxgWUYLxS78nhEDvmaQi2eTDOJ9b6oAM=; b=XLkwUX1lJubMjEkZW5EZxzR+CJ6WXB51pYcZNuWropYYKVGoTFonnNNe a7nZW9D/WSschrWo772DPkXlpjObYrkRaOeJPBkPHF8u009LUoulNNhee xUXAkCGa3/hiN1zfdBg/4JikOxBM+F9SUkXbbprH6WK4mZi3Ff/63GMwv c=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 95246998 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:wVhifq2TJ4Neb+ma8vbD5aRxkn2cJEfYwER7XKvMYLTBsI5bpzIAz 2QZDGyHb/7YYWWgfI13bo/j/RsPv5Tdz4djHlZtpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS93uDgNyo4GlD5gVlPagR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfIktqq tw7KSg3TS+jreWLkOOdZdY3r5F2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP ZNfMGcxKk2aOHWjOX9OYH46tOC3i3+5aDhZtFK9rqsr+WnDigd21dABNfKEJ4bWG5QEzi50o ErU71j5PzUhc+azkxyM+XfwpeWIjDvkDdd6+LqQqacx3Qz7KnYoIAIXUx6jv7y1h1CzX/pbK lcI4Ww+oK4q7kupQ9LhGRqirxa5UgU0AoQKVbdgsUfUl/SSulzCboQZctJfQP8MkJAWZj0y7 Hy2v/nuOGw+lpKqElvIo994sgiOESQSKGYDYwoNQg0E/8TvrekPs/7fcjpwOPXr14OoQFkc1 xjP9XFj3OtL0abnwo3hpTj6bySQSo8lp+LfziHeRSqb4wxwf+ZJjKT4uAGAvZ6swGt0J2RtX UToeeDEt4ji7rnXzkRhpdnh+5n0j8tpyBWG3TZS82AJrlxBAUKLc4FK+y1ZL0x0KMsCcjKBS BaN5l4JvcAKbCfyPPAfj2eN5yMClPiIKDgYfqqMMoomjmZZK2drAx2ClWbPhjuwwSDAYIk0O IuBcNbEMJrpIf0P8dZCfM9EieVD7nlnlQvuqWXTk0zPPUy2OCTEFt/o8TKmMogE0U9ziF6Lr 4kOZ5fakkU3vS+XSnC/zLP/5GsidRATba0aYeQOHgJfCmKKwF0cNsI= IronPort-HdrOrdr: A9a23:1fGmSatLYqzHtxI/WOGFIDWE7skDstV00zEX/kB9WHVpm6yj+v xG/c5rsCMc7Qx6ZJhOo7+90cW7L080lqQFg7X5X43DYOCOggLBQL2KhbGI/9SKIVycygcy78 Zdm6gVMqyLMbB55/yKnTVRxbwbsaW6GKPDv5ag8590JzsaD52Jd21Ce36m+ksdfnggObMJUK Cyy+BgvDSadXEefq2AdwI4t7iqnaysqHr+CyR2fiIa1A== X-IronPort-AV: E=Sophos;i="5.97,258,1669093200"; d="scan'208";a="95246998" From: Owen Smith To: CC: Owen Smith , Matthew Sykes Subject: [PATCH] Free memory in correct fail path Date: Mon, 30 Jan 2023 14:54:38 +0000 Message-ID: <20230130145438.4069060-1-owen.smith@citrix.com> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain SDV identifies this as an error. Only attempt to free the buffer after the allocation succeeds. Signed-off-by: Matthew Sykes Signed-off-by: Owen Smith --- src/xenvbd/base64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/xenvbd/base64.c b/src/xenvbd/base64.c index 223579a..427a98a 100644 --- a/src/xenvbd/base64.c +++ b/src/xenvbd/base64.c @@ -157,9 +157,9 @@ fail4: Error("fail4\n"); fail3: Error("fail3\n"); + Base64Free(Buffer); fail2: Error("fail2\n"); - Base64Free(Buffer); fail1: Error("fail1 %08x\n", status); *Binary = NULL; -- 2.39.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Mon Jan 30 15:05:41 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 30 Jan 2023 15:05:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.487043.754522 (Exim 4.92) (envelope-from ) id 1pMVj2-0007Tt-05; Mon, 30 Jan 2023 15:05:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 487043.754522; Mon, 30 Jan 2023 15:05:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pMVj1-0007Tm-Te; Mon, 30 Jan 2023 15:05:39 +0000 Received: by outflank-mailman (input) for mailman id 487043; Mon, 30 Jan 2023 15:05:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pMVj1-0007Tg-0c for win-pv-devel@lists.xenproject.org; Mon, 30 Jan 2023 15:05:39 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8bfacbe4-a0af-11ed-b8d1-410ff93cb8f0; Mon, 30 Jan 2023 16:05:36 +0100 (CET) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 8bfacbe4-a0af-11ed-b8d1-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675091136; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=KuwDyLV87JsVbM0qvT+/UN6CpeRtBGWdiDNylO0UJtk=; b=ebLcApqwVcqJASTxriUOgl8ikFEMqOkWmfJkfbe0d2kqjsdtnkJFDMk8 ox2z2lxh6vtcu0c5/rUSnKHFYgahQVEcuG0ajiIdfeZaURICQuGm0dnDl zKqNDQ5kmqXNux6WH/ghbLxVaq7Px4Ptt+LFJ36lEojtwLsAJFNWfg4kF I=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 93717705 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:QUnvDKMbDcnuRFXvrR3Ul8FynXyQoLVcMsEvi/4bfWQNrUoq1mZRy DcXD2uEOvfYYWPxfNonbIm2ph9Uv57dyoUyTwto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9Suv3rRC9H5qyo42tB5QRmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0txMDnFqq 6UUETsiR1ParcSszICwF9A506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI ZNEN3w2Nk+ojx5nYz/7DLo5g+quwGL6ciFYgFmUubA28y7YywkZPL3FYYGKI4PVHZg9ckCwg HOdpknhCBEgO+fPxjmIqV6jn7LoknauMG4VPOLhraM76LGJ/UQMCRtTTUX+rfSnh0qWX9NEN 1dS6icotbI19kGgUp/6RRLQnZKflkdCAZwKSbR8sVzTjPOOuG51G1ToUBZ7U9M2kJFvSQUh+ XbKxvnPHzBdu+CsHCf1GqivkRu+Pi0cLGknbCACTBcY79SLnLzfni4jXf44Tvfr04Sd9SXYh mnT8XNg3+l7Ydsjjf3TwLzRv967SnElpCYR7x6fYG+q5xgRiGWNN93xsgizARqtwe+kori9U JoswZP2AAMmV8vleMmxrAIlQdmUCw6tamG0vLKWN8BJG86R03CiZ5tMxzp1OV1kNM0JERewP hCO4VoOvc8PZCr1BUOSX25WI516pZUM6Py/DqyEBjawSscZmPC7ENFGOhfLgjGFfLkEmqAjI 5aLGftA/l5DYZmLOAGeHr9HuZdyn3BW+I8mbcyjp/hR+ebENSH9pHZsGAfmU93VG4vf/lmKo oYDZ5Lao/idOcWnChTqHUcoBQhiBRAG6Vre95YOHgJfCmKKwF0cNsI= IronPort-HdrOrdr: A9a23:2m727a/rNLamxffz9GVuk+DiI+orL9Y04lQ7vn2ZKCY4TiX8ra uTdZsguiMc5Ax+ZJhYo6HnBEDjexPhHO9OgLX5VI3KNGOKhILCFvAA0WKN+UyFJwTOssJbyK d8Y+xfJbTLfD9HZB/BkWuF+gAbsby6zJw= X-IronPort-AV: E=Sophos;i="5.97,258,1669093200"; d="scan'208";a="93717705" From: Owen Smith To: CC: Owen Smith , Alex Burke Subject: [PATCH] Add annotation to fix SDV failure Date: Mon, 30 Jan 2023 15:03:58 +0000 Message-ID: <20230130150358.4076674-1-owen.smith@citrix.com> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain SDV can detect the BytesNeeded value may be 0, as it cannot determine the value of some constants. Signed-off-by: Alex Burke Signed-off-by: Owen Smith --- src/xennet/adapter.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/xennet/adapter.c b/src/xennet/adapter.c index 7a083e9..4b449f3 100644 --- a/src/xennet/adapter.c +++ b/src/xennet/adapter.c @@ -2130,6 +2130,7 @@ AdapterSetInformation( break; case OID_OFFLOAD_ENCAPSULATION: + __analysis_assume(BytesNeeded > 0); BytesNeeded = NDIS_SIZEOF_OFFLOAD_ENCAPSULATION_REVISION_1; if (BufferLength >= BytesNeeded) { ndisStatus = AdapterGetOffloadEncapsulation(Adapter, -- 2.39.0.windows.1