From win-pv-devel-bounces@lists.xenproject.org Mon Apr 17 12:29:39 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 17 Apr 2023 12:29:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.522054.811205 (Exim 4.92) (envelope-from ) id 1poNzF-0004jk-NE; Mon, 17 Apr 2023 12:29:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 522054.811205; Mon, 17 Apr 2023 12:29:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1poNzF-0004jY-KI; Mon, 17 Apr 2023 12:29:37 +0000 Received: by outflank-mailman (input) for mailman id 522054; Mon, 17 Apr 2023 12:29:36 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1poNzE-0004jE-0r for win-pv-devel@lists.xenproject.org; Mon, 17 Apr 2023 12:29:36 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" Date: Mon, 17 Apr 2023 12:29:48 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <27869876.1.1681734593410.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> Subject: XENHID-master - Build #34 - Successful MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_0_8617291.1681734591551" X-Jenkins-Job: XENHID-master X-Jenkins-Result: SUCCESS ------=_Part_0_8617291.1681734591551 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #34. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENHID-master/34/console to view the results. ------=_Part_0_8617291.1681734591551-- From win-pv-devel-bounces@lists.xenproject.org Mon Apr 17 13:13:03 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 17 Apr 2023 13:13:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.522094.811279 (Exim 4.92) (envelope-from ) id 1poOfF-00058A-Hw; Mon, 17 Apr 2023 13:13:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 522094.811279; Mon, 17 Apr 2023 13:13:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1poOfF-000582-Ej; Mon, 17 Apr 2023 13:13:01 +0000 Received: by outflank-mailman (input) for mailman id 522094; Mon, 17 Apr 2023 13:13:01 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1poOfF-00057w-5b for win-pv-devel@lists.xenproject.org; Mon, 17 Apr 2023 13:13:01 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" Date: Mon, 17 Apr 2023 13:13:17 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <14503416.3.1681737197989.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> Subject: XENVKBD-master - Build #36 - Successful MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_2_12488680.1681737197739" X-Jenkins-Job: XENVKBD-master X-Jenkins-Result: SUCCESS ------=_Part_2_12488680.1681737197739 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #36. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENVKBD-master/36/console to view the results. ------=_Part_2_12488680.1681737197739-- From win-pv-devel-bounces@lists.xenproject.org Mon Apr 17 13:25:04 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 17 Apr 2023 13:25:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.522103.811287 (Exim 4.92) (envelope-from ) id 1poOqt-0006Bz-Dg; Mon, 17 Apr 2023 13:25:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 522103.811287; Mon, 17 Apr 2023 13:25:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1poOqt-0006Bs-As; Mon, 17 Apr 2023 13:25:03 +0000 Received: by outflank-mailman (input) for mailman id 522103; Mon, 17 Apr 2023 13:25:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1poOqs-0006A8-Ji for win-pv-devel@lists.xenproject.org; Mon, 17 Apr 2023 13:25:02 +0000 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [2a00:1450:4864:20::32e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3fabe32c-dd23-11ed-8611-37d641c3527e; Mon, 17 Apr 2023 15:24:58 +0200 (CEST) Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-3f0aabd1040so40936865e9.1 for ; Mon, 17 Apr 2023 06:24:58 -0700 (PDT) Received: from localhost.localdomain ([185.25.65.68]) by smtp.gmail.com with ESMTPSA id y12-20020a5d470c000000b002c70ce264bfsm10559491wrq.76.2023.04.17.06.24.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Apr 2023 06:24:57 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 3fabe32c-dd23-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1681737897; x=1684329897; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bYDIK4w5/FjFn9CjH/IyFW1pXbSCAJIDMuN9Ui16/lM=; b=gaPfY2RfYjHAlqkciwVHha51uI7khty3OgRHQYFulD71nxXDKT7lGHhybLIyMDGjZa 83djOZFk80i/OwPsc4EqqSMH+UyX3OB0/+cc1J03gTr0bg/zzdjDEe8FDJDG/OAG2X1B vFbd6tiueyD2MCU/NRJFcLgAGfKq9AjBd0reE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681737897; x=1684329897; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bYDIK4w5/FjFn9CjH/IyFW1pXbSCAJIDMuN9Ui16/lM=; b=W+PGRhAqoslgIuoCC7nqEGY7Zo2anYQaQJS3kty5N4Wy9gVF2i9SznFVjZj7qBLvlW JkHyZQ7MeQPWARpDnbVXNdJVuEudlf2V5IzxBIAtgLaFaztNgju5d0mMV37D70K+Jn9d +crAXQikb7AHlwNbsYd9LAkS+OYWoMnsI3LfcuwcVI7D7/WrMYk7YyJmL+wBlvz3ubcP AGjVPhN3y6A1Z3Ipk6mfsmMFwbalAoEYMtBX4YqGPoRqrABsW5col9Uq0g6Ojt0cw0jS 42jfG1oKaUpnYvzrYsIZpj1pk9eKi682jOd/HjBrlGiR+j1J6YiSqK4ntiGbqO7fFNK7 FPxw== X-Gm-Message-State: AAQBX9dyvuNEhFQ8Xsa+neCezg+UkFipWxeeaHITAv0fFCS7l82i45DL OgoC1BlS/p6vCFpTgwtvWGWEP4jng4Zl7egeiw== X-Google-Smtp-Source: AKy350ZEwCo8GJk3093L4Xtnxxa2dQY5F+czi3w92zd9XXpsXMa9NzU4xOiOnIgb91GrfGUSO958lQ== X-Received: by 2002:adf:eb0d:0:b0:2f8:1305:dce1 with SMTP id s13-20020adfeb0d000000b002f81305dce1mr5393553wrn.19.1681737897405; Mon, 17 Apr 2023 06:24:57 -0700 (PDT) From: Owen Smith To: win-pv-devel@lists.xenproject.org Cc: Owen Smith Subject: [PATCH 2/2] Rebuild CodeQL builds Date: Mon, 17 Apr 2023 14:24:40 +0100 Message-Id: <20230417132440.765-2-owen.smith@cloud.com> X-Mailer: git-send-email 2.39.0.windows.1 In-Reply-To: <20230417132440.765-1-owen.smith@cloud.com> References: <20230417132440.765-1-owen.smith@cloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Occasionally, CodeQL builds will fail stating that no code was discovered. Force CodeQL builds to rebuild to avoid this issue. Signed-off-by: Owen Smith --- msbuild.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/msbuild.ps1 b/msbuild.ps1 index c6fb48a..7696795 100644 --- a/msbuild.ps1 +++ b/msbuild.ps1 @@ -98,7 +98,7 @@ Function Run-CodeQL { } $a = "msbuild.exe" $a += " /m:4" - $a += " /t:Build" + $a += " /t:Rebuild" $a += [string]::Format(" /p:Configuration=""{0}""", $Configuration) $a += [string]::Format(" /p:Platform=""{0}""", $Platform) $a += [string]::Format(" /p:SignMode=""{0}""", $SignMode) -- 2.39.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Mon Apr 17 13:25:07 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 17 Apr 2023 13:25:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.522102.811282 (Exim 4.92) (envelope-from ) id 1poOqs-0006AL-Bz; Mon, 17 Apr 2023 13:25:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 522102.811282; Mon, 17 Apr 2023 13:25:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1poOqs-0006AE-9B; Mon, 17 Apr 2023 13:25:02 +0000 Received: by outflank-mailman (input) for mailman id 522102; Mon, 17 Apr 2023 13:25:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1poOqr-0006A8-Tu for win-pv-devel@lists.xenproject.org; Mon, 17 Apr 2023 13:25:02 +0000 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [2a00:1450:4864:20::32e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3f3ee5e3-dd23-11ed-8611-37d641c3527e; Mon, 17 Apr 2023 15:24:58 +0200 (CEST) Received: by mail-wm1-x32e.google.com with SMTP id gw13so13774839wmb.3 for ; Mon, 17 Apr 2023 06:24:57 -0700 (PDT) Received: from localhost.localdomain ([185.25.65.68]) by smtp.gmail.com with ESMTPSA id y12-20020a5d470c000000b002c70ce264bfsm10559491wrq.76.2023.04.17.06.24.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Apr 2023 06:24:56 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 3f3ee5e3-dd23-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1681737896; x=1684329896; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=mA8KO1/NknLWTcjRm8kW5nCT3nU9++AT9KZFN7Ow7wU=; b=kwP/16Ee/+XBJmnrEeD8tvHQPgQKgrBz/mCyT/PcOtNRw7q7gGv64vLq+LLNFxM/u0 20/E7KCwGPJ6mG7xAjQp7Vo2/ae4sPOmPDbdHMZ61+2n57zDqtMf/cdJy1zj4w43ZnnL 0ssWro+eBn8+G4FQO9k4Nc/60WCJK3RqVPKBA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681737896; x=1684329896; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mA8KO1/NknLWTcjRm8kW5nCT3nU9++AT9KZFN7Ow7wU=; b=YudECTqifM/l2hCN1gGC+uUZfCh7G5+ff3SRZds/UDt8TUOdR1hMjI1v0sqk5mgCKL N4UNmt7MylrLS1fzFuxIrXvkyzMM4gVge6Q7kxwLYFsDjFF7bbIvtAKTY1FPfvvnYh/e oKSOVcS0velAyUNgBlCQKSwyhTHKivd3uJrnlJeJRvmGAmxMzjI64Hkce4PSw5S7qYj/ XsxEeiKVgrjOjgFkxbMtWLPgjg9zAt3hlby+C5V+/eKfyCwalI5OJVrm02WUmjFEgE62 UYCe06fpkxWzhuNHXln0Np31XDIjohmUfg+aB/IOnEgWdrxqmzmtcHNpv0VC041Nt/xi ZPJw== X-Gm-Message-State: AAQBX9dk20DVOr9xquBNeetq0Apwu8ra9byDTxTtZsr6UV3HTJC7ciss TN/1ZcH2FJs/6Ii8oGuBt22w5k73gK2CV7a2ug== X-Google-Smtp-Source: AKy350awm4bIuUJHdAReUYs9bk1XDGwrkJfJXi0qnJPJfKG76C+lIoTwBP2psxfQox0zRPwpAaVcUQ== X-Received: by 2002:a7b:c8cc:0:b0:3f1:35a0:4a7b with SMTP id f12-20020a7bc8cc000000b003f135a04a7bmr8554452wml.21.1681737896565; Mon, 17 Apr 2023 06:24:56 -0700 (PDT) From: Owen Smith To: win-pv-devel@lists.xenproject.org Cc: Owen Smith , Matthew Sykes Subject: [PATCH 1/2] Check for zero byte allocations Date: Mon, 17 Apr 2023 14:24:39 +0100 Message-Id: <20230417132440.765-1-owen.smith@cloud.com> X-Mailer: git-send-email 2.39.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Avoid attempting to allocate zero byte buffers, which can lead to inefficiencies in pool memory usage. Suggested-by: Matthew Sykes Signed-off-by: Owen Smith --- src/xennet/util.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/xennet/util.h b/src/xennet/util.h index bd980b1..d236c94 100644 --- a/src/xennet/util.h +++ b/src/xennet/util.h @@ -153,6 +153,9 @@ __AllocatePoolWithTag( __analysis_assume(PoolType == NonPagedPool || PoolType == PagedPool); + if (NumberOfBytes == 0) + return NULL; + #if (_MSC_VER >= 1928) // VS 16.9 (EWDK 20344 or later) Buffer = ExAllocatePoolUninitialized(PoolType, NumberOfBytes, Tag); #else -- 2.39.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Mon Apr 17 14:06:13 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 17 Apr 2023 14:06:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.522174.811391 (Exim 4.92) (envelope-from ) id 1poPUh-0007Vd-V0; Mon, 17 Apr 2023 14:06:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 522174.811391; Mon, 17 Apr 2023 14:06:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1poPUh-0007VW-SS; Mon, 17 Apr 2023 14:06:11 +0000 Received: by outflank-mailman (input) for mailman id 522174; Mon, 17 Apr 2023 14:06:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1poPUh-0007VQ-Aw for win-pv-devel@lists.xenproject.org; Mon, 17 Apr 2023 14:06:11 +0000 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [2a00:1450:4864:20::32e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fe2138a5-dd28-11ed-8611-37d641c3527e; Mon, 17 Apr 2023 16:06:05 +0200 (CEST) Received: by mail-wm1-x32e.google.com with SMTP id q5so13833239wmo.4 for ; Mon, 17 Apr 2023 07:06:05 -0700 (PDT) Received: from localhost.localdomain ([185.25.65.68]) by smtp.gmail.com with ESMTPSA id iz19-20020a05600c555300b003f1733feb3dsm3740600wmb.0.2023.04.17.07.06.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Apr 2023 07:06:04 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: fe2138a5-dd28-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1681740364; x=1684332364; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HTGL9Xp6pvgZTXSpic4NYK5qQjhkzn1Oh6RS7YpHn7s=; b=SWvmUo30yTR3DXU5PMlJR/2r//NfLaacYnIXuP8R3BIsKd+t1GChtkk3lBOVpPqaa6 LHDm9r1XzMT0WbiR7Q2gu22/IELTLsx0SisCLIFnvT6uvR0xvsg3PoW8iXFH9pV2o2u+ b7IohBm4/YDIgigwbm4cf+lrgAhbc84Salvaw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681740364; x=1684332364; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HTGL9Xp6pvgZTXSpic4NYK5qQjhkzn1Oh6RS7YpHn7s=; b=LOm3/NlNC8zQ+R5uA1FeD6/a9gIST4MfYEOWW+zb3ka5jF7Hi8sbgsuJOIrPDSb/yD VwmKyS8UYWccBV1Ej6kKTRPPrnqXTsu86gJYru+b7UIv2LDaBQnHE0vTOKCpSU3lUmDR nF7cmUr5ytIVvSyUwrxbrFOTaRtCVBrsryCgnpGE+3vU7Q8yc3Lb+kf2O3wee4XWpk0x vc9ScTRpmE1A2pGIAcuYh7kJJxuQFEkziEn6ZpjDskQ9oiLyUXIfM8pmgXzdQcHkqXyq JPQTySb/HPyTveDD9ozEsgoT7r97msP2KeLi6CFxSqHS6tX0t6h6iDsxfrmskNeyZHbo Q60g== X-Gm-Message-State: AAQBX9dgabEwUzSO7abGnRgajkzyKnIDosPFftBV870J68uvaPFk/k9f HtntldpKxG004xP47mHWhaBaSj309+oomC7zfQ== X-Google-Smtp-Source: AKy350YjJ/DfRGdAiEciVeyrBTJi4kWoyHXBySY8a2KqXaGPWEYcdDxctYGjOvmC51xnIV7PeX3Abw== X-Received: by 2002:a1c:7913:0:b0:3f1:758e:40eb with SMTP id l19-20020a1c7913000000b003f1758e40ebmr1259830wme.17.1681740364523; Mon, 17 Apr 2023 07:06:04 -0700 (PDT) From: Owen Smith To: win-pv-devel@lists.xenproject.org Cc: Owen Smith Subject: [PATCH 2/2] Rebuild CodeQL builds Date: Mon, 17 Apr 2023 15:05:46 +0100 Message-Id: <20230417140546.1394-2-owen.smith@cloud.com> X-Mailer: git-send-email 2.39.0.windows.1 In-Reply-To: <20230417140546.1394-1-owen.smith@cloud.com> References: <20230417140546.1394-1-owen.smith@cloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Occasionally, CodeQL builds will fail stating that no code was discovered. Force CodeQL builds to rebuild to avoid this issue. Signed-off-by: Owen Smith --- msbuild.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/msbuild.ps1 b/msbuild.ps1 index 73a5e10..8dcbafe 100644 --- a/msbuild.ps1 +++ b/msbuild.ps1 @@ -98,7 +98,7 @@ Function Run-CodeQL { } $a = "msbuild.exe" $a += " /m:4" - $a += " /t:Build" + $a += " /t:Rebuild" $a += [string]::Format(" /p:Configuration=""{0}""", $Configuration) $a += [string]::Format(" /p:Platform=""{0}""", $Platform) $a += [string]::Format(" /p:SignMode=""{0}""", $SignMode) -- 2.39.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Mon Apr 17 14:06:14 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 17 Apr 2023 14:06:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.522175.811395 (Exim 4.92) (envelope-from ) id 1poPUk-0007XU-0M; Mon, 17 Apr 2023 14:06:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 522175.811395; Mon, 17 Apr 2023 14:06:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1poPUj-0007XL-Ts; Mon, 17 Apr 2023 14:06:13 +0000 Received: by outflank-mailman (input) for mailman id 522175; Mon, 17 Apr 2023 14:06:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1poPUi-0007X4-Tf for win-pv-devel@lists.xenproject.org; Mon, 17 Apr 2023 14:06:12 +0000 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [2a00:1450:4864:20::336]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fdb52090-dd28-11ed-b21e-6b7b168915f2; Mon, 17 Apr 2023 16:06:06 +0200 (CEST) Received: by mail-wm1-x336.google.com with SMTP id v10so7222393wmn.5 for ; Mon, 17 Apr 2023 07:06:04 -0700 (PDT) Received: from localhost.localdomain ([185.25.65.68]) by smtp.gmail.com with ESMTPSA id iz19-20020a05600c555300b003f1733feb3dsm3740600wmb.0.2023.04.17.07.06.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Apr 2023 07:06:03 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: fdb52090-dd28-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1681740363; x=1684332363; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=OdmgCajrakxU/7Z5r0nv/cArrlVkOSN99GpBVtJD8/o=; b=GQi0QFm+bvhjJ7/Of5n6DbEVcUz5GiT1GTyXd6jfQtqjE0kqQAEikrgizofkipHWeG n5AeDObnjUaQva4tyGPtjV5kuY7QGS+2E3dcH07IJ6y4VXYOkAJv0b+DGyYHLZHMLc8k j6B86TYqcbo+IO5ogkNthfK1yjREPqmj6qMkU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681740363; x=1684332363; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OdmgCajrakxU/7Z5r0nv/cArrlVkOSN99GpBVtJD8/o=; b=aceoeQS2/L5OGusvjEF4W2O3wDLbQu8WS6Zi0z17DAoU5cdKw+BbP9cwei0eh6PHvf K9oQwgdib4Z/KrhWER1tEmLA8Upfr6zkGfY150zwTcHe5maDSJxUJdZppnM6ljMo/n8W SugF/5GtAlyJZ2S8Hr85SiOOVHIZ4p3bSoewyV5MH1w/EyTQwsEAUDF3+cCzVbSgITpP 8/Vp+NeNLdh2RpSintOw1IW47DDo8YwWvf4oDUypCYjO8/MEk6QxICy8zqPQ56q5m5gc Xb/05G2VYwkMhTtYPVexSrsRpVmYg9q6tQ1wyjM5eoHqePIX7iwRKUsZVJmGcBn7VURg e+Dg== X-Gm-Message-State: AAQBX9dXEgjKPrV6QCbpsZ1l0nr2W2j6/erkhXD9vNfmHn2NwpLsq/hM lTmouWErBQVwTex5UK8BDh/fblQeCHYlrJYi3A== X-Google-Smtp-Source: AKy350bav/4PYh0RzrF5XSB6KtIFd9nKAnmmIwvXfA3LaM7Hl/fTm4Ch5Bv/LAD3AkPgT+Yw02HTKw== X-Received: by 2002:a05:600c:2251:b0:3ed:316d:668d with SMTP id a17-20020a05600c225100b003ed316d668dmr10476562wmm.5.1681740363667; Mon, 17 Apr 2023 07:06:03 -0700 (PDT) From: Owen Smith To: win-pv-devel@lists.xenproject.org Cc: Owen Smith , Matthew Sykes Subject: [PATCH 1/2] Check for zero byte allocations Date: Mon, 17 Apr 2023 15:05:45 +0100 Message-Id: <20230417140546.1394-1-owen.smith@cloud.com> X-Mailer: git-send-email 2.39.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Avoid attempting to allocate zero byte buffers, which can lead to inefficiencies in pool memory usage. Suggested-by: Matthew Sykes Signed-off-by: Owen Smith --- src/common/util.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/common/util.h b/src/common/util.h index 867f1bb..e60ebbf 100644 --- a/src/common/util.h +++ b/src/common/util.h @@ -153,6 +153,9 @@ __AllocatePoolWithTag( __analysis_assume(PoolType == NonPagedPool || PoolType == PagedPool); + if (NumberOfBytes == 0) + return NULL; + #if (_MSC_VER >= 1928) // VS 16.9 (EWDK 20344 or later) Buffer = ExAllocatePoolUninitialized(PoolType, NumberOfBytes, Tag); #else -- 2.39.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Mon Apr 17 14:33:08 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 17 Apr 2023 14:33:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.522200.811423 (Exim 4.92) (envelope-from ) id 1poPul-0003F8-JS; Mon, 17 Apr 2023 14:33:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 522200.811423; Mon, 17 Apr 2023 14:33:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1poPul-0003F0-GH; Mon, 17 Apr 2023 14:33:07 +0000 Received: by outflank-mailman (input) for mailman id 522200; Mon, 17 Apr 2023 14:33:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1poPuj-0003DG-JB for win-pv-devel@lists.xenproject.org; Mon, 17 Apr 2023 14:33:05 +0000 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [2a00:1450:4864:20::329]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c33b44fe-dd2c-11ed-b21e-6b7b168915f2; Mon, 17 Apr 2023 16:33:04 +0200 (CEST) Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-3f09b9ac51dso42806295e9.0 for ; Mon, 17 Apr 2023 07:33:04 -0700 (PDT) Received: from localhost.localdomain ([185.25.65.68]) by smtp.gmail.com with ESMTPSA id x12-20020adff0cc000000b002d64fcb362dsm10640552wro.111.2023.04.17.07.33.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Apr 2023 07:33:03 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: c33b44fe-dd2c-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1681741983; x=1684333983; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=R2IoD/nJvmJTTMPfvq381mPG6qB0uRzvYdl8zkttwAI=; b=KBzbbmdQ6/6zI4RRGBWjf3put/neJTH/A9a872ntS/Fs9s+yidSjt6NLJ9Sgp4/nNl 3PcqcDn+dGVAq2KZ5H1X5TtpdrHMQn9cczZ3b76Ve9kqh1miW3DcMdEEtmDcUID2IALt 1YbDwH2biiEH690Bee6fxYZLHc25rTm48pQjo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681741983; x=1684333983; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R2IoD/nJvmJTTMPfvq381mPG6qB0uRzvYdl8zkttwAI=; b=ZlFHOAGwpGSpu6yfJjI0fKgVJDmepMlpYPTGH2RYWGt4TcqBIA/q8gCx9HYLf5ffMn LC5ohV45eQ8LzXibN3aAxssb9+0z+pxsNysBqwIUBJvpw+5k2O8wpRTUYfvpQv8DjDDq h7XvRWlRpvxTx++u7OAz7wox8EItcF6ZqhKalx0s6wBRdeW8XBM+L3NYWg46ger0CKDq vx01wqsgHkpa1h7LFRob5KZKIOgq4we1D0HkS/RPAQoTVzl0jGuwhf2jYjr8f7LsX8J5 vE+MmfoxlPVreY7feoCqwQJhvDlQxMHiO2OlltRr3RBuyuk9XvtsGmds1opCVcZOp2gE RxMg== X-Gm-Message-State: AAQBX9cILlrB3pHVQb4vm5AQ47A83Ldp4ZxD0dLccMh8ENLfaXzlSPBt Fc4S7jtjh2hmw3+3+03a4Rcdb7UP6PfeRlLAZw== X-Google-Smtp-Source: AKy350YgTb/AN3UcFdQVTIBFGhYP1QpHookRd+hNGr7pXs9YzV37CsFV7B6hyNj34fn4SylJ8UutSw== X-Received: by 2002:a5d:6dc6:0:b0:2f0:244c:277b with SMTP id d6-20020a5d6dc6000000b002f0244c277bmr5735167wrz.27.1681741983662; Mon, 17 Apr 2023 07:33:03 -0700 (PDT) From: Owen Smith To: win-pv-devel@lists.xenproject.org Cc: Owen Smith Subject: [PATCH 2/2] Rebuild CodeQL builds Date: Mon, 17 Apr 2023 15:32:47 +0100 Message-Id: <20230417143247.1298-2-owen.smith@cloud.com> X-Mailer: git-send-email 2.39.0.windows.1 In-Reply-To: <20230417143247.1298-1-owen.smith@cloud.com> References: <20230417143247.1298-1-owen.smith@cloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Occasionally, CodeQL builds will fail stating that no code was discovered. Force CodeQL builds to rebuild to avoid this issue. Signed-off-by: Owen Smith --- msbuild.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/msbuild.ps1 b/msbuild.ps1 index 867cbe3..4cc00c6 100644 --- a/msbuild.ps1 +++ b/msbuild.ps1 @@ -98,7 +98,7 @@ Function Run-CodeQL { } $a = "msbuild.exe" $a += " /m:4" - $a += " /t:Build" + $a += " /t:Rebuild" $a += [string]::Format(" /p:Configuration=""{0}""", $Configuration) $a += [string]::Format(" /p:Platform=""{0}""", $Platform) $a += [string]::Format(" /p:SignMode=""{0}""", $SignMode) -- 2.39.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Mon Apr 17 14:33:08 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 17 Apr 2023 14:33:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.522199.811420 (Exim 4.92) (envelope-from ) id 1poPuk-0003Db-IT; Mon, 17 Apr 2023 14:33:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 522199.811420; Mon, 17 Apr 2023 14:33:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1poPuk-0003DR-Ev; Mon, 17 Apr 2023 14:33:06 +0000 Received: by outflank-mailman (input) for mailman id 522199; Mon, 17 Apr 2023 14:33:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1poPui-0003DG-UE for win-pv-devel@lists.xenproject.org; Mon, 17 Apr 2023 14:33:04 +0000 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [2a00:1450:4864:20::32f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c2dcf8bd-dd2c-11ed-b21e-6b7b168915f2; Mon, 17 Apr 2023 16:33:03 +0200 (CEST) Received: by mail-wm1-x32f.google.com with SMTP id n43-20020a05600c502b00b003f17466a9c1so1310317wmr.2 for ; Mon, 17 Apr 2023 07:33:03 -0700 (PDT) Received: from localhost.localdomain ([185.25.65.68]) by smtp.gmail.com with ESMTPSA id x12-20020adff0cc000000b002d64fcb362dsm10640552wro.111.2023.04.17.07.33.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Apr 2023 07:33:02 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: c2dcf8bd-dd2c-11ed-b21e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1681741983; x=1684333983; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5a26X8ronvkku7gE1PHA4RHId84TqslY3InwWz0MFVs=; b=ONRaPWESgH08Rz8LlCmK1KNUTgU/ncQk0n40BUsE9Ozg8zerXYU1gzFCqgH1eHu9AR j41FhrJL8PnjpdphS5UBGzJwnxqEHq/+20LiwEiC1h0ZR5MtYnB/oQOWYqWrzgP+ZY+/ qs8kDKclqOFhJJmH2PjvXUxHnEOc0SFTzXPw8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681741983; x=1684333983; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5a26X8ronvkku7gE1PHA4RHId84TqslY3InwWz0MFVs=; b=D3UNTiKL8Cv+V381VddBQRPWYB9xKGNavXkMO4O295t0I4xq4EKUNpnpDwBJTyWi4w 9SxoxoO/AogwS/lj+R2Q2+yYPN3+VbWA1yPcFxNMFLaUmjwwd3i+BefZzRR9CPxpoj8/ Dvi0O2dFwwJu/UsIV1vrQ2GrXxZ2Oxt2rSBi/fYevTHFzpbtxwGLrbY/OhBeUilnwY1g sLYRqUNd5DZX8STWAcCtVovpPhk2lBLmPJhb70LVpqORUVlSv4E4EsmVdoMi3I90FC9x swAAn4uIOnKYDmQPUnlqD7synl1iInK4BQ7HeMoEnI6LJ9tnxuOWfFfARHgsK0MI88sq EJMQ== X-Gm-Message-State: AAQBX9eXG6klW1ozQidBnbVUcQ+28PmYCflMiALxmpgoz3NqEZRuFLEn pk/M1wKt1Rl+vdKPsvIMmiWPP4eeUH9Q138TwQ== X-Google-Smtp-Source: AKy350aCQOevz5vFuyl84u96vOtTaUv69CP4Ul2gPla/jsJuRrFcMJzmxbUCz9u5onUsNxnabAcA4g== X-Received: by 2002:a1c:7718:0:b0:3f1:73ce:e1e2 with SMTP id t24-20020a1c7718000000b003f173cee1e2mr2187798wmi.33.1681741983001; Mon, 17 Apr 2023 07:33:03 -0700 (PDT) From: Owen Smith To: win-pv-devel@lists.xenproject.org Cc: Owen Smith , Matthew Sykes Subject: [PATCH 1/2] Check for zero byte allocations Date: Mon, 17 Apr 2023 15:32:46 +0100 Message-Id: <20230417143247.1298-1-owen.smith@cloud.com> X-Mailer: git-send-email 2.39.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Avoid attempting to allocate zero byte buffers, which can lead to inefficiencies in pool memory usage. Suggested-by: Matthew Sykes Signed-off-by: Owen Smith --- src/xenvif/util.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/xenvif/util.h b/src/xenvif/util.h index 370d45a..b085842 100644 --- a/src/xenvif/util.h +++ b/src/xenvif/util.h @@ -153,6 +153,9 @@ __AllocatePoolWithTag( __analysis_assume(PoolType == NonPagedPool || PoolType == PagedPool); + if (NumberOfBytes == 0) + return NULL; + #if (_MSC_VER >= 1928) // VS 16.9 (EWDK 20344 or later) Buffer = ExAllocatePoolUninitialized(PoolType, NumberOfBytes, Tag); #else -- 2.39.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Mon Apr 17 14:44:12 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 17 Apr 2023 14:44:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.522219.811437 (Exim 4.92) (envelope-from ) id 1poQ5T-0004rG-Ly; Mon, 17 Apr 2023 14:44:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 522219.811437; Mon, 17 Apr 2023 14:44:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1poQ5T-0004r9-Ic; Mon, 17 Apr 2023 14:44:11 +0000 Received: by outflank-mailman (input) for mailman id 522219; Mon, 17 Apr 2023 14:44:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1poQ5S-0004qy-9P for win-pv-devel@lists.xenproject.org; Mon, 17 Apr 2023 14:44:10 +0000 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [2a00:1450:4864:20::32b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4e9f2666-dd2e-11ed-8611-37d641c3527e; Mon, 17 Apr 2023 16:44:07 +0200 (CEST) Received: by mail-wm1-x32b.google.com with SMTP id hg25-20020a05600c539900b003f05a99a841so21158074wmb.3 for ; Mon, 17 Apr 2023 07:44:07 -0700 (PDT) Received: from localhost.localdomain ([185.25.65.68]) by smtp.gmail.com with ESMTPSA id l7-20020a05600c1d0700b003ee443bf0c7sm15905290wms.16.2023.04.17.07.44.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Apr 2023 07:44:06 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 4e9f2666-dd2e-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1681742647; x=1684334647; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uNrzVQILcvQ+d2O9Ghzjet4qal6kggS9fRVTUcecT5c=; b=Ws6X0c6bgMmRVhgQJ1cBKQKHxH9oUMBhYTbNHvt6Xks+3m4qcmFH6g6eg8GPe1WPEm 9po+MDYUHl0LVpKyYN+smQw1HfCkbwY1VLrM1DenpgjWTyVMRSqNP+t/uIZMnDf2vVI8 sKeP3IeyRhVLBFsJvoWGLBzxxzEcrAHtYyjP4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681742647; x=1684334647; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uNrzVQILcvQ+d2O9Ghzjet4qal6kggS9fRVTUcecT5c=; b=YidcDp+rU92PzxYu3B5SIr7WdCPqS1BK/qkVH8g1MxRhHZlYTn58XvZ9FE73ya+syj Z1hwInjNy4tjKtROr5RzbD9deRC5wJ0hfOHJrmjFefcTZ7c0m6TqNqheCvvnMFJMIQ2m MZirMxc+nkd4ULWhbmNMifLQBMug2tcLfQquInWo4y4XeAQ2ujfGthz+/xqYnW/WP556 XUV4kx4IrinLf+KjRs3EyPu4xi72hUFWpNvQ66YM1WQvLr2vT2J64Btj+7t8KmRgehUC v1h0YEN+O31ukenCUS10qe+9DKMT/6fWZlBeeyUXmSapbbfQVbrdfjWwyWVu3Tx5/C70 Etuw== X-Gm-Message-State: AAQBX9enIsP4nKh9xgLM5aFph3TSTEEcdc0X+L7G+9M4/j3pOCBG1Mfc smkriuv0enqxYTwKLY32Fo7HzbRGehT1C/gmvg== X-Google-Smtp-Source: AKy350Z9/ztM6iJ43CnRO8q7OTfGf0WhvPfACEl0qjD5g8M5A6Mh0zn3sS8UAB9mStwKXFqBPh34Pg== X-Received: by 2002:a7b:c003:0:b0:3f1:6b26:68b6 with SMTP id c3-20020a7bc003000000b003f16b2668b6mr4364426wmb.16.1681742646983; Mon, 17 Apr 2023 07:44:06 -0700 (PDT) From: Owen Smith To: win-pv-devel@lists.xenproject.org Cc: Owen Smith Subject: [PATCH 2/2] Rebuild CodeQL builds Date: Mon, 17 Apr 2023 15:43:50 +0100 Message-Id: <20230417144350.1104-2-owen.smith@cloud.com> X-Mailer: git-send-email 2.39.0.windows.1 In-Reply-To: <20230417144350.1104-1-owen.smith@cloud.com> References: <20230417144350.1104-1-owen.smith@cloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Occasionally, CodeQL builds will fail stating that no code was discovered. Force CodeQL builds to rebuild to avoid this issue. Signed-off-by: Owen Smith --- msbuild.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/msbuild.ps1 b/msbuild.ps1 index 1ec8508..58053e2 100644 --- a/msbuild.ps1 +++ b/msbuild.ps1 @@ -98,7 +98,7 @@ Function Run-CodeQL { } $a = "msbuild.exe" $a += " /m:4" - $a += " /t:Build" + $a += " /t:Rebuild" $a += [string]::Format(" /p:Configuration=""{0}""", $Configuration) $a += [string]::Format(" /p:Platform=""{0}""", $Platform) $a += [string]::Format(" /p:SignMode=""{0}""", $SignMode) -- 2.39.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Mon Apr 17 14:44:12 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 17 Apr 2023 14:44:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.522220.811440 (Exim 4.92) (envelope-from ) id 1poQ5T-0004ra-Nq; Mon, 17 Apr 2023 14:44:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 522220.811440; Mon, 17 Apr 2023 14:44:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1poQ5T-0004rK-K7; Mon, 17 Apr 2023 14:44:11 +0000 Received: by outflank-mailman (input) for mailman id 522220; Mon, 17 Apr 2023 14:44:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1poQ5S-0004qy-VM for win-pv-devel@lists.xenproject.org; Mon, 17 Apr 2023 14:44:10 +0000 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [2a00:1450:4864:20::32c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4e201d4f-dd2e-11ed-8611-37d641c3527e; Mon, 17 Apr 2023 16:44:06 +0200 (CEST) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-3f1763ee915so2835475e9.1 for ; Mon, 17 Apr 2023 07:44:06 -0700 (PDT) Received: from localhost.localdomain ([185.25.65.68]) by smtp.gmail.com with ESMTPSA id l7-20020a05600c1d0700b003ee443bf0c7sm15905290wms.16.2023.04.17.07.44.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Apr 2023 07:44:05 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 4e201d4f-dd2e-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1681742646; x=1684334646; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=C02PpYotmCrfrqeHf79A+nUEOq4eZuNJ/Ud7R5seAe4=; b=XhS3Kn4hSnxDFwkz8b8CB9V+4s/FY+ab8d85XXfIctjMJ0S0IWVlGcXyPQm71z7Zkp HkNLQTIgsfGEnEuzOrGzPajfx4TbXp3BFU6Ed5Jo6i0NQbsJ241e51z4+IZ+GnSOWTqI Mz0bmz2dJUTcjpMJMzvc0UJeJ89YHxxvRtWzY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681742646; x=1684334646; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=C02PpYotmCrfrqeHf79A+nUEOq4eZuNJ/Ud7R5seAe4=; b=JV5th/ubLHv3mTy13ifTKPmwubVi9Cc/CcDoaIfedgyC/YRqSZG1HNL/DRj+q+9X8i g+fHcK3jINsxEBGBUCI/hu4U0JVt4DrvNm9+9ZH2j3mm+WkXRtD1xMrOLnd/VPxA+rGT zfoCwZm/753VHJBrNF3WkNi2eKgf7zr7BxgIxwj4CWh7gazeG0h8t/6xHkftEWCaMMR7 P2tlb+W4AUy59v/klVUvKFkkNiN20MtitTOLvD59TGONbNSG/+VjMbe/Csa3vNCT2mrd ylY0vfgJKfOLYilEnITZSi5jRxgvsbxrp4wt5mfsQ/YlTrQ6KfQwG5Rh36wYE7lfJEhJ fdqw== X-Gm-Message-State: AAQBX9dgVtKOqRZqUlJzQVPTUTqEdFc6IRyfcD8IXVypxId4zgDAl+PA H/EFPTS5OSXgGJI5HZ56TPm9N00Erm9nVK3Wrg== X-Google-Smtp-Source: AKy350ZvuD0+u18jWwZkw5QRU/JImdQOinqiBt3I44dl+VDGuDlnvqAMU9X8YzjB9xo2wQdko/b/xw== X-Received: by 2002:adf:f486:0:b0:2f4:6a97:c27b with SMTP id l6-20020adff486000000b002f46a97c27bmr5696982wro.5.1681742646089; Mon, 17 Apr 2023 07:44:06 -0700 (PDT) From: Owen Smith To: win-pv-devel@lists.xenproject.org Cc: Owen Smith , Matthew Sykes Subject: [PATCH 1/2] Check for zero byte allocations Date: Mon, 17 Apr 2023 15:43:49 +0100 Message-Id: <20230417144350.1104-1-owen.smith@cloud.com> X-Mailer: git-send-email 2.39.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Avoid attempting to allocate zero byte buffers, which can lead to inefficiencies in pool memory usage. Suggested-by: Matthew Sykes Signed-off-by: Owen Smith --- src/common/util.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/common/util.h b/src/common/util.h index e68e463..326ff0b 100644 --- a/src/common/util.h +++ b/src/common/util.h @@ -153,6 +153,9 @@ __AllocatePoolWithTag( __analysis_assume(PoolType == NonPagedPool || PoolType == PagedPool); + if (NumberOfBytes == 0) + return NULL; + #if (_MSC_VER >= 1928) // VS 16.9 (EWDK 20344 or later) Buffer = ExAllocatePoolUninitialized(PoolType, NumberOfBytes, Tag); #else -- 2.39.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Tue Apr 18 08:51:05 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 18 Apr 2023 08:51:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.522643.812141 (Exim 4.92) (envelope-from ) id 1poh3H-00045K-J4; Tue, 18 Apr 2023 08:51:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 522643.812141; Tue, 18 Apr 2023 08:51:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1poh3H-00045D-Fy; Tue, 18 Apr 2023 08:51:03 +0000 Received: by outflank-mailman (input) for mailman id 522643; Tue, 18 Apr 2023 08:51:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1poh3G-000457-HP for win-pv-devel@lists.xenproject.org; Tue, 18 Apr 2023 08:51:02 +0000 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [2a00:1450:4864:20::32f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2509d08f-ddc6-11ed-b21f-6b7b168915f2; Tue, 18 Apr 2023 10:51:01 +0200 (CEST) Received: by mail-wm1-x32f.google.com with SMTP id o29-20020a05600c511d00b003f1739de43cso2691940wms.4 for ; Tue, 18 Apr 2023 01:51:01 -0700 (PDT) Received: from localhost.localdomain ([185.25.65.68]) by smtp.gmail.com with ESMTPSA id z19-20020a1c4c13000000b003f171234a08sm7071671wmf.20.2023.04.18.01.50.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Apr 2023 01:51:00 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 2509d08f-ddc6-11ed-b21f-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1681807860; x=1684399860; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=mX2PvZ009RIDaGM1UNYnbx+yKUBN5CEKOxRLIh8NHpE=; b=UWOTfgt8O2PfF6DexWVBGwxY21y6KQ81vCOfBTK403xj4kJ2ful2h9uEkq9VhZC3Mr R9Mfq+lD5gb6VgmBnU/futBEJKsFrmsbSvDpb7gxbJhlm/H6pUt2npn9ap73c25DdXhg fu/tEYvVkUTNsLbWN983AnGPuMlWjNHU3+bZI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681807860; x=1684399860; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mX2PvZ009RIDaGM1UNYnbx+yKUBN5CEKOxRLIh8NHpE=; b=kYKP7bNBPpSordsQ3YShRWmLPRJixbjQIWmNv2oRLe6lVCEyRBkTU/3Ou8rylxpeBA p2airNg+cp2CUZrfMasXaVF+tyokPx55JhRf9rEZMnQZEPrWomZ1VDSLbNz56K9Prpeo hh97Mi+N+bCJM36wd0lFuxv68MsAryh9cztR/gqTDpmKLPNkAr6XYD4d5xcNLiTLokCm i5meLkX8SYA/TLCYit6e5G38VL20QIuVEmyMmWY2tkrCqSsCQ/E1iZYhUrls8WtMJRzE WCNW9r5oDmsxcAzFoGnPJ02BNFe/Y1FrEObzMjHePdfQiNDetMbniJbbBL+8a98X7FKU byVA== X-Gm-Message-State: AAQBX9expQkY9cIvk3UYeoMaa0Jo5fHDKoCtONhq/Q5e2i+XJ7S93DI4 +M6xD3OP+Vp7TU7ZZcO++03crNsZYbAgFVB/RQ== X-Google-Smtp-Source: AKy350Z0lfISEOfgINNExlWWH3wLOSiY7xFMxdtsicEBiOzbUCedTCYX8eAPXS8ezUQ5ncqYSb2i4Q== X-Received: by 2002:a7b:cd10:0:b0:3ef:7584:9896 with SMTP id f16-20020a7bcd10000000b003ef75849896mr13318478wmj.26.1681807860462; Tue, 18 Apr 2023 01:51:00 -0700 (PDT) From: Owen Smith To: win-pv-devel@lists.xenproject.org Cc: Matthew Sykes , Owen Smith Subject: [PATCH 1/3] Dont disable warning 4100 Date: Tue, 18 Apr 2023 09:50:43 +0100 Message-Id: <20230418085045.1790-1-owen.smith@cloud.com> X-Mailer: git-send-email 2.39.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Matthew Sykes Adds UNREFERENCED_PARAMETER macros instead of suppressing the warning. Suggested-by: Matthew Sykes Signed-off-by: Owen Smith --- src/xeniface/driver.h | 2 +- src/xeniface/ioctl_gnttab.c | 2 ++ src/xeniface/ioctl_suspend.c | 2 ++ src/xeniface/ioctls.c | 2 ++ src/xeniface/wmi.c | 49 ++++++++++++++++++++++++++++++++++++ 5 files changed, 56 insertions(+), 1 deletion(-) diff --git a/src/xeniface/driver.h b/src/xeniface/driver.h index 4fb6308..27cd453 100644 --- a/src/xeniface/driver.h +++ b/src/xeniface/driver.h @@ -42,7 +42,7 @@ #define NTSTRSAFE_LIB #include -#pragma warning(disable:4100 4057) +#pragma warning(disable: 4057) #include #include diff --git a/src/xeniface/ioctl_gnttab.c b/src/xeniface/ioctl_gnttab.c index c3cf129..b6b7327 100644 --- a/src/xeniface/ioctl_gnttab.c +++ b/src/xeniface/ioctl_gnttab.c @@ -424,6 +424,8 @@ IoctlGnttabRevokeForeignAccess( PIRP PendingIrp; PXENIFACE_CONTEXT_ID ContextId; + UNREFERENCED_PARAMETER(OutLen); + status = STATUS_INVALID_BUFFER_SIZE; if (InLen != sizeof(XENIFACE_GNTTAB_REVOKE_FOREIGN_ACCESS_IN)) goto fail1; diff --git a/src/xeniface/ioctl_suspend.c b/src/xeniface/ioctl_suspend.c index daa6dfb..1607e5a 100644 --- a/src/xeniface/ioctl_suspend.c +++ b/src/xeniface/ioctl_suspend.c @@ -141,6 +141,8 @@ SuspendFreeEvent( Trace("Context %p, FO %p\n", Context, Context->FileObject); + UNREFERENCED_PARAMETER(Fdo); + ObDereferenceObject(Context->Event); RtlZeroMemory(Context, sizeof(XENIFACE_SUSPEND_CONTEXT)); __FreePoolWithTag(Context, XENIFACE_POOL_TAG); diff --git a/src/xeniface/ioctls.c b/src/xeniface/ioctls.c index e8199ea..9808adc 100644 --- a/src/xeniface/ioctls.c +++ b/src/xeniface/ioctls.c @@ -117,6 +117,8 @@ IoctlLog( NTSTATUS status; PCHAR ptr; + UNREFERENCED_PARAMETER(Fdo); + status = STATUS_INVALID_BUFFER_SIZE; if (InLen == 0 || InLen > XENIFACE_LOG_MAX_LENGTH || OutLen != 0) goto fail1; diff --git a/src/xeniface/wmi.c b/src/xeniface/wmi.c index 5bbf123..97ef2c3 100644 --- a/src/xeniface/wmi.c +++ b/src/xeniface/wmi.c @@ -1398,6 +1398,9 @@ SessionExecuteRemoveValue( PXENSTORE_SESSION session; char* tmpbuffer; + UNREFERENCED_PARAMETER(OutBuffer); + UNREFERENCED_PARAMETER(OutBufferSize); + *BytesWritten = 0; status = STATUS_INVALID_DEVICE_REQUEST; if (!AccessWmiBuffer(InBuffer, TRUE, &RequiredSize, InBufferSize, @@ -1465,6 +1468,10 @@ SessionExecuteRemoveWatch( UNICODE_STRING unicpath_notbacked; PXENSTORE_SESSION session; + UNREFERENCED_PARAMETER(OutBuffer); + UNREFERENCED_PARAMETER(OutBufferSize); + + *BytesWritten = 0; status = STATUS_INVALID_DEVICE_REQUEST; if (!AccessWmiBuffer(InBuffer, TRUE, &RequiredSize, InBufferSize, @@ -1515,6 +1522,10 @@ SessionExecuteSetWatch( UNICODE_STRING unicpath_notbacked; UNICODE_STRING unicpath_backed; + UNREFERENCED_PARAMETER(OutBuffer); + UNREFERENCED_PARAMETER(OutBufferSize); + + *BytesWritten = 0; status = STATUS_INVALID_DEVICE_REQUEST; if (!AccessWmiBuffer(InBuffer, TRUE, &RequiredSize, InBufferSize, @@ -1567,6 +1578,12 @@ SessionExecuteEndSession( PXENSTORE_SESSION Session; NTSTATUS status; + UNREFERENCED_PARAMETER(OutBuffer); + UNREFERENCED_PARAMETER(OutBufferSize); + UNREFERENCED_PARAMETER(InBuffer); + UNREFERENCED_PARAMETER(InBufferSize); + + *BytesWritten = 0; status = STATUS_WMI_INSTANCE_NOT_FOUND; Session = FindSessionByInstanceAndLock(Fdo, instance); @@ -1603,6 +1620,9 @@ SessionExecuteSetValue( char* tmppath; char* tmpvalue; + UNREFERENCED_PARAMETER(OutBuffer); + UNREFERENCED_PARAMETER(OutBufferSize); + *BytesWritten = 0; status = STATUS_INVALID_DEVICE_REQUEST; if (!AccessWmiBuffer(InBuffer, TRUE, &RequiredSize, InBufferSize, @@ -1691,6 +1711,8 @@ SessionExecuteGetFirstChild( PXENSTORE_SESSION session; char* tmppath; + UNREFERENCED_PARAMETER(OutBuffer); + *BytesWritten = 0; status = STATUS_INVALID_DEVICE_REQUEST; if (!AccessWmiBuffer(InBuffer, TRUE, &RequiredSize, InBufferSize, @@ -1810,6 +1832,8 @@ SessionExecuteGetNextSibling( int leafoffset; char* attemptstring; + UNREFERENCED_PARAMETER(OutBuffer); + *BytesWritten = 0; status = STATUS_INVALID_DEVICE_REQUEST; if (!AccessWmiBuffer(InBuffer, TRUE, &RequiredSize, InBufferSize, @@ -1973,6 +1997,8 @@ SessionExecuteGetChildren( PXENSTORE_SESSION session; char* tmppath; + UNREFERENCED_PARAMETER(OutBuffer); + status = STATUS_INVALID_DEVICE_REQUEST; if (!AccessWmiBuffer(InBuffer, TRUE, &RequiredSize, InBufferSize, WMI_STRING, &uloc, @@ -2091,6 +2117,12 @@ SessionExecuteLog( NTSTATUS status; ANSI_STRING message; + + UNREFERENCED_PARAMETER(Fdo); + UNREFERENCED_PARAMETER(instance); + UNREFERENCED_PARAMETER(OutBuffer); + UNREFERENCED_PARAMETER(OutBufferSize); + *BytesWritten = 0; status = STATUS_INVALID_DEVICE_REQUEST; if (!AccessWmiBuffer(InBuffer, TRUE, &RequiredSize, InBufferSize, @@ -2127,6 +2159,11 @@ SessionExecuteStartTransaction( NTSTATUS status; PXENSTORE_SESSION session; + UNREFERENCED_PARAMETER(InBuffer); + UNREFERENCED_PARAMETER(InBufferSize); + UNREFERENCED_PARAMETER(OutBuffer); + UNREFERENCED_PARAMETER(OutBufferSize); + *BytesWritten = 0; status = STATUS_INSUFFICIENT_RESOURCES; if (!Fdo->InterfacesAcquired) @@ -2168,6 +2205,12 @@ SessionExecuteCommitTransaction( NTSTATUS status; PXENSTORE_SESSION session; + UNREFERENCED_PARAMETER(InBuffer); + UNREFERENCED_PARAMETER(InBufferSize); + UNREFERENCED_PARAMETER(OutBuffer); + UNREFERENCED_PARAMETER(OutBufferSize); + + *BytesWritten = 0; status = STATUS_INSUFFICIENT_RESOURCES; if (!Fdo->InterfacesAcquired) @@ -2214,6 +2257,12 @@ SessionExecuteAbortTransaction( NTSTATUS status; PXENSTORE_SESSION session; + + UNREFERENCED_PARAMETER(InBuffer); + UNREFERENCED_PARAMETER(InBufferSize); + UNREFERENCED_PARAMETER(OutBuffer); + UNREFERENCED_PARAMETER(OutBufferSize); + *BytesWritten = 0; status = STATUS_INSUFFICIENT_RESOURCES; if (!Fdo->InterfacesAcquired) -- 2.39.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Tue Apr 18 08:51:08 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 18 Apr 2023 08:51:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.522644.812144 (Exim 4.92) (envelope-from ) id 1poh3M-00047O-Ke; Tue, 18 Apr 2023 08:51:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 522644.812144; Tue, 18 Apr 2023 08:51:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1poh3M-00047H-IC; Tue, 18 Apr 2023 08:51:08 +0000 Received: by outflank-mailman (input) for mailman id 522644; Tue, 18 Apr 2023 08:51:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1poh3L-00046z-37 for win-pv-devel@lists.xenproject.org; Tue, 18 Apr 2023 08:51:07 +0000 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [2a00:1450:4864:20::330]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 25eb8dee-ddc6-11ed-8611-37d641c3527e; Tue, 18 Apr 2023 10:51:02 +0200 (CEST) Received: by mail-wm1-x330.google.com with SMTP id o6-20020a05600c4fc600b003ef6e6754c5so13107110wmq.5 for ; Tue, 18 Apr 2023 01:51:02 -0700 (PDT) Received: from localhost.localdomain ([185.25.65.68]) by smtp.gmail.com with ESMTPSA id z19-20020a1c4c13000000b003f171234a08sm7071671wmf.20.2023.04.18.01.51.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Apr 2023 01:51:01 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 25eb8dee-ddc6-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1681807862; x=1684399862; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7GzWGdyTbK/1UYZsrAUc7CFpT1Sn1uvaF0MQfJa1wEc=; b=O7q9tOm7WAt8yI1DflNGZUzUWnDXgBb2SR/j1CgSa7vyq6sR1gFDhHzVgpcue3AoXO 6ZW6gCWlx6/Iq/sIADXV2zDahlG6IAcGlXBfIXXiWKFVQKafFNN4YnPC+PGXdzQSpGI3 rqQtomG3MCr78nPKNgWknZpBpFLGvHmjiQwaw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681807862; x=1684399862; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7GzWGdyTbK/1UYZsrAUc7CFpT1Sn1uvaF0MQfJa1wEc=; b=dFbF5r6+urjPPb3cfH64PTziOFbfQCDaoZR5YgyA3enA8WezZNN+zO7fUuU43kGjC8 sUsKnyVtbIvVLdcl7LaCPcv8dN+Vt1QdbE9XS2BquC6C6zVgVZnsYiVGIFXwxY+GeUGP upHZo9v8TIAO9svuOUSjADKFHYGxcd84AOcT3OrHGEGk2KCnIp1vv9HMmy6Auzz+XKND KNXBOMdllN/dolnwj4azgKvh7St3DbJZK9pRhTXOSRGh9nK3XyyzK6ndS9YsFK6uPjwc 11yrjmyefhGGnFMH+jHue4WJy62jXphkaHnHwXKu2u1EeVfbnwCSu1xh+5jh66ycYfxn sYwg== X-Gm-Message-State: AAQBX9fbJ3rK1aHVmC/+kbN3OUkP2lvsFHCDDuKnC0DKYqBK/E9biol4 jlap1I4u3Z2NBdJAfXmueycI3CnblYBLltZ8TQ== X-Google-Smtp-Source: AKy350aMxzcNT0R1vLbXdZgVBVy9uxVVqr2lvtQiTbF2S5s6YSfKAwSuIJqsd0mb/PDdtUy7qP21hw== X-Received: by 2002:a05:600c:ac6:b0:3f1:75d0:6151 with SMTP id c6-20020a05600c0ac600b003f175d06151mr2984707wmr.1.1681807862120; Tue, 18 Apr 2023 01:51:02 -0700 (PDT) From: Owen Smith To: win-pv-devel@lists.xenproject.org Cc: Owen Smith Subject: [PATCH 3/3] Rebuild CodeQL builds Date: Tue, 18 Apr 2023 09:50:45 +0100 Message-Id: <20230418085045.1790-3-owen.smith@cloud.com> X-Mailer: git-send-email 2.39.0.windows.1 In-Reply-To: <20230418085045.1790-1-owen.smith@cloud.com> References: <20230418085045.1790-1-owen.smith@cloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit CodeQL can sometimes fail to detect any source code if the codebase is not rebuilt. Use the Rebuild target to force all intermediate build artifacts to be cleaned beforehand. Signed-off-by: Owen Smith --- msbuild.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/msbuild.ps1 b/msbuild.ps1 index 5d479cb..8deda6a 100644 --- a/msbuild.ps1 +++ b/msbuild.ps1 @@ -98,7 +98,7 @@ Function Run-CodeQL { } $a = "msbuild.exe" $a += " /m:4" - $a += " /t:Build" + $a += " /t:Rebuild" $a += [string]::Format(" /p:Configuration=""{0}""", $Configuration) $a += [string]::Format(" /p:Platform=""{0}""", $Platform) $a += [string]::Format(" /p:SignMode=""{0}""", $SignMode) -- 2.39.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Tue Apr 18 08:51:09 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 18 Apr 2023 08:51:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.522645.812149 (Exim 4.92) (envelope-from ) id 1poh3N-00049A-N8; Tue, 18 Apr 2023 08:51:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 522645.812149; Tue, 18 Apr 2023 08:51:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1poh3N-000492-JV; Tue, 18 Apr 2023 08:51:09 +0000 Received: by outflank-mailman (input) for mailman id 522645; Tue, 18 Apr 2023 08:51:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1poh3L-00046z-OR for win-pv-devel@lists.xenproject.org; Tue, 18 Apr 2023 08:51:07 +0000 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [2a00:1450:4864:20::331]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2571aa03-ddc6-11ed-8611-37d641c3527e; Tue, 18 Apr 2023 10:51:02 +0200 (CEST) Received: by mail-wm1-x331.google.com with SMTP id q5so15120018wmo.4 for ; Tue, 18 Apr 2023 01:51:02 -0700 (PDT) Received: from localhost.localdomain ([185.25.65.68]) by smtp.gmail.com with ESMTPSA id z19-20020a1c4c13000000b003f171234a08sm7071671wmf.20.2023.04.18.01.51.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Apr 2023 01:51:00 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 2571aa03-ddc6-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1681807861; x=1684399861; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UVoj9/OemyAuIB/e4PB+5hFZKuNPDyTxYLNBzD+gI4c=; b=MqhzuKgVz0Tj9CmAYDFmDRazDylfW1Rnfleocjeu3fNVug6+imnapgns34q0hiYvCd R05bQQUIMoDlw5i/FyzfUTlOXPJRHw5ncI+GBlWYbmLv1n/4l9D9RLHinxj4MwimQYNy GRXaoZGObhSNoOqiBw94nXW4o5dW+ejDqyeXk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681807861; x=1684399861; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UVoj9/OemyAuIB/e4PB+5hFZKuNPDyTxYLNBzD+gI4c=; b=QvDGE2jbwzCNIoijqxbg8XocXu/ER2/XN6LnIZ9ZpnfjN9toimrPMluFwJPh2JMAT7 ZGt12NYCctJHVCfoJUbenOFbJmuw1C1c2+8g6MUjWmwHPjYHK7mXLmFljJN4S6eNOAy2 tjnbOlmMI2sTdXBVqCX0C0eVeSrI8MkTumkbUckgqHYI2dyYlt1y6N+a5/2KdPMs5p8h dugs9nicNrk4pvZfiD0CigP0/+9mjg6DTikxIX9tyZetElL+M1ORkf0Mrn5IpIw3+5iv XE+nJte14f1cm5TfsXvlDaBwoles+hWgEMnJ43tPQSq83Du5HluH1yimXDPAb4Tki4q/ GxzQ== X-Gm-Message-State: AAQBX9dubgf1Uq02pOlBUoNKfdHhNk1CrbdHuPSti2QMwZlCcwpUpnhX C01f02xzteggdwMo4/RM9Ya9LPX0aQh5PHDljA== X-Google-Smtp-Source: AKy350a3sSt2aUbQaXKYgmMhuybJXaKDgdroDrU3Na8lfjt3dPEBuCqS3+KvF3isWkDomj2xqTT9Mg== X-Received: by 2002:a1c:7503:0:b0:3f0:683d:224d with SMTP id o3-20020a1c7503000000b003f0683d224dmr12880499wmc.9.1681807861354; Tue, 18 Apr 2023 01:51:01 -0700 (PDT) From: Owen Smith To: win-pv-devel@lists.xenproject.org Cc: Owen Smith , Matthew Sykes Subject: [PATCH 2/3] Check for zero byte allocations Date: Tue, 18 Apr 2023 09:50:44 +0100 Message-Id: <20230418085045.1790-2-owen.smith@cloud.com> X-Mailer: git-send-email 2.39.0.windows.1 In-Reply-To: <20230418085045.1790-1-owen.smith@cloud.com> References: <20230418085045.1790-1-owen.smith@cloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Dont attempt to allocate zero byte buffers, as it can pollute the pool headers without benefit. Suggested-by: Matthew Sykes Signed-off-by: Owen Smith --- src/xeniface/util.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/xeniface/util.h b/src/xeniface/util.h index 71c887d..a278d72 100644 --- a/src/xeniface/util.h +++ b/src/xeniface/util.h @@ -153,6 +153,9 @@ __AllocatePoolWithTag( __analysis_assume(PoolType == NonPagedPool || PoolType == PagedPool); + if (NumberOfBytes == 0) + return NULL; + #if (_MSC_VER >= 1928) // VS 16.9 (EWDK 20344 or later) Buffer = ExAllocatePoolUninitialized(PoolType, NumberOfBytes, Tag); #else -- 2.39.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Thu Apr 27 10:46:54 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 27 Apr 2023 10:46:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.526930.819014 (Exim 4.92) (envelope-from ) id 1prz9H-0007so-Vp; Thu, 27 Apr 2023 10:46:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 526930.819014; Thu, 27 Apr 2023 10:46:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1prz9H-0007sh-Sr; Thu, 27 Apr 2023 10:46:51 +0000 Received: by outflank-mailman (input) for mailman id 526930; Thu, 27 Apr 2023 10:46:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1prz9G-0007sb-O6 for win-pv-devel@lists.xenproject.org; Thu, 27 Apr 2023 10:46:50 +0000 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [2a00:1450:4864:20::32f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cfeb13e2-e4e8-11ed-b224-6b7b168915f2; Thu, 27 Apr 2023 12:46:49 +0200 (CEST) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-3f173af665fso55111135e9.3 for ; Thu, 27 Apr 2023 03:46:49 -0700 (PDT) Received: from [192.168.25.161] (54-240-197-238.amazon.com. [54.240.197.238]) by smtp.gmail.com with ESMTPSA id y26-20020a1c4b1a000000b003f318be9442sm1337596wma.40.2023.04.27.03.46.47 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Apr 2023 03:46:48 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: cfeb13e2-e4e8-11ed-b224-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682592408; x=1685184408; h=content-transfer-encoding:in-reply-to:organization:reply-to :references:to:content-language:subject:user-agent:mime-version:date :message-id:from:from:to:cc:subject:date:message-id:reply-to; bh=i9zV5PLJHPz6fyq+sBqBVesyS/CecVpC4BYYCOPe6Wk=; b=qdaIvqhDJJelZAllroq29H66qQjz5JqG63yertF94uJNhtVj2+YDm86hDWz2ifVeq9 jamPY8bgpGtxpwsPA+ZAyWezCjY7bIVE/dHZPnSx4jwZmrsw/RGEFGPMwuEqOlmNKriq QirwxSkYBf5bJ3spnLxSVZPpQHYrvdZZOlXMDQt4eEDuXGwjmSdbC8Th9LCD6TTYVrbC AxL8OBtQakL2jHef9SBIFF8G1A6DpUgiOf90TkmPfG8gPneWKzJKkxDi2KomFGJPs5W1 hALXa2XC8oWNaMYINx8qwVgwcii43imnTRSCNeIFzwvb6XZOCRjKcka5BZEY16mdM+x7 H+yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682592408; x=1685184408; h=content-transfer-encoding:in-reply-to:organization:reply-to :references:to:content-language:subject:user-agent:mime-version:date :message-id:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=i9zV5PLJHPz6fyq+sBqBVesyS/CecVpC4BYYCOPe6Wk=; b=OjM29DXxFCy3/XEr8N1+kLrsDcK3AJg79M//hA4l1RnI9nXYYI69gP2NQJTptEXLY1 hFgmRVTUBDxNJuMfuQuBTOYlMo1kvC1edUvk7zuE2QYwOUD8oaOOHmsimxo9RhzCHb5m O34zC4ckE9IiDHi+a7UfxKnFhC3OrNr1FJ7PITOIfLGq8vAGT9tvfJg1599QRtU4EIxy 9B89Aqa/q+CocC+yim6jbu3YRC2M2CQ5oVEyOEubRA0cRRZ3daOrYw3R5tgAzQZz3ZKX AOh1QYMUebBHfgHoJlZ9NR4Q3t2gOEGmPsRBnzU3+tTTVP+jXHjL7/0Yh7wAKtQrGX8M A7Tw== X-Gm-Message-State: AC+VfDwBDYSbVAisufHCUWr8wMa4SlmfourujSEUWPmo2bnQWMUvX0ji ZQZKSqgsMR/tr907/geSQLht1FSFO/o5dw== X-Google-Smtp-Source: ACHHUZ5VJyrTYf8NL0YfOEosxfuo3Pfm99AuBqglFxMrvr9otIvOCxDkX6tU5ZF2f5j/IR9WsyW7HA== X-Received: by 2002:a1c:4b1a:0:b0:3f3:195b:d17c with SMTP id y26-20020a1c4b1a000000b003f3195bd17cmr1091411wma.24.1682592408606; Thu, 27 Apr 2023 03:46:48 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Message-ID: Date: Thu, 27 Apr 2023 11:46:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 1/3] Dont disable warning 4100 Content-Language: en-US To: win-pv-devel@lists.xenproject.org References: <20230418085045.1790-1-owen.smith@cloud.com> Reply-To: paul@xen.org Organization: Xen Project In-Reply-To: <20230418085045.1790-1-owen.smith@cloud.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 18/04/2023 09:50, Owen Smith wrote: > From: Matthew Sykes > > Adds UNREFERENCED_PARAMETER macros instead of suppressing the warning. > > Suggested-by: Matthew Sykes > Signed-off-by: Owen Smith Series... Acked-by: Paul Durrant From win-pv-devel-bounces@lists.xenproject.org Thu Apr 27 10:51:50 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 27 Apr 2023 10:51:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.526938.819018 (Exim 4.92) (envelope-from ) id 1przE6-0000P3-C9; Thu, 27 Apr 2023 10:51:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 526938.819018; Thu, 27 Apr 2023 10:51:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1przE6-0000Ow-9U; Thu, 27 Apr 2023 10:51:50 +0000 Received: by outflank-mailman (input) for mailman id 526938; Thu, 27 Apr 2023 10:51:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1przE5-0000Oq-4s for win-pv-devel@lists.xenproject.org; Thu, 27 Apr 2023 10:51:49 +0000 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [2a00:1450:4864:20::329]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 80ff39cc-e4e9-11ed-8611-37d641c3527e; Thu, 27 Apr 2023 12:51:47 +0200 (CEST) Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-3f1763ee8f8so57335385e9.1 for ; Thu, 27 Apr 2023 03:51:46 -0700 (PDT) Received: from [192.168.25.161] (54-240-197-238.amazon.com. [54.240.197.238]) by smtp.gmail.com with ESMTPSA id p10-20020a5d48ca000000b003047dc162f7sm8919033wrs.67.2023.04.27.03.51.44 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Apr 2023 03:51:45 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 80ff39cc-e4e9-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682592706; x=1685184706; h=content-transfer-encoding:in-reply-to:organization:reply-to :references:to:content-language:subject:user-agent:mime-version:date :message-id:from:from:to:cc:subject:date:message-id:reply-to; bh=iyx5/X293m9YHrx1Y4Xy6GuUGoqjSZw4H/VwZTndorE=; b=SwVjKzrBsYlgnGm3mJi8u3vV/qGnN7aWBJfqdZ6wK65a/niEtiYTS6cL+2ssxjKNhV LWzwes7Ty9q4PUDiyTE+KXalYpvm0kR27TA/pOPY2exSkbtC8SlFsa8WJ2m6LPAnSP/+ VG4epa6Onzs3501UN2tEEEYrxKc6Fakn2so4X96goCwLKMWYdsQNHrxgMJ0Uw6Sa2nVT mbF3SgvNyrvKrPiUnG8nfk8osjZdUWt2KMGc26ly0q/p1OviVtrWV8zbdHb8hcT0G6OH 13TLWygqaHxZYDovHxgUsOftTN4J2V8UT8GoYuwIo/sneWo0G3Oywj7RXN/0L/nFdHaY uh6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682592706; x=1685184706; h=content-transfer-encoding:in-reply-to:organization:reply-to :references:to:content-language:subject:user-agent:mime-version:date :message-id:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iyx5/X293m9YHrx1Y4Xy6GuUGoqjSZw4H/VwZTndorE=; b=bX92J9V9geMs7eFk80LzoAYrMDrvRne7ccRpIZJ+YvICkkBAPFKwqaSGYu0q1nmunK 7D6xTmUoerkqb+/OCQi5Zsdfo8QU/4186b4vygWKvZ4wQYrlDnKNvffRkBDF3VaTtoJ+ ok7/htKwPesYBgjPc65h17PKeoiDcuGB474wyk3ZTIbYU8HQeAKf0bDkvKVmLPn3dgPB FAeVdJAGnaixsm6dwh8BL1yD1L+Quwhnjzjvc6T+1ARpeFOGQgL/mvGcKipiZ0EFovOE bHTSc6j3mpIAEbLslFQ/DTrxSZDzI2iSyKj4+NhyJYQN7Hhps5aK0Kug8JT523BJhTES Iy/A== X-Gm-Message-State: AC+VfDw/DSAsnIj/hn0Q4tmDFjaTiS4Le86jOHpSuVk2PDq8BqubpyVs sWxZ//vY1c3TcAJijeZN8mDMy0z97b9o/A== X-Google-Smtp-Source: ACHHUZ7wmQluOBdRdKoIZFkAInGisPFJpl/jXy5E6kg4kdprI/p6DiOe4HVKqNO5W7nvnBwSXeq7cg== X-Received: by 2002:a5d:4250:0:b0:2f7:8faf:f993 with SMTP id s16-20020a5d4250000000b002f78faff993mr919317wrr.50.1682592705779; Thu, 27 Apr 2023 03:51:45 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Message-ID: <6e9ceaa0-9037-64f5-7782-09241d36e7b9@xen.org> Date: Thu, 27 Apr 2023 11:51:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 1/2] Check for zero byte allocations Content-Language: en-US To: win-pv-devel@lists.xenproject.org References: <20230417144350.1104-1-owen.smith@cloud.com> Reply-To: paul@xen.org Organization: Xen Project In-Reply-To: <20230417144350.1104-1-owen.smith@cloud.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 17/04/2023 15:43, Owen Smith wrote: > Avoid attempting to allocate zero byte buffers, which can lead to > inefficiencies in pool memory usage. > > Suggested-by: Matthew Sykes > Signed-off-by: Owen Smith Series... Acked-by: Paul Durrant From win-pv-devel-bounces@lists.xenproject.org Thu Apr 27 10:54:13 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 27 Apr 2023 10:54:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.526946.819021 (Exim 4.92) (envelope-from ) id 1przGO-0000Ud-Iw; Thu, 27 Apr 2023 10:54:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 526946.819021; Thu, 27 Apr 2023 10:54:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1przGO-0000UW-GK; Thu, 27 Apr 2023 10:54:12 +0000 Received: by outflank-mailman (input) for mailman id 526946; Thu, 27 Apr 2023 10:54:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1przGN-0000UQ-8c for win-pv-devel@lists.xenproject.org; Thu, 27 Apr 2023 10:54:11 +0000 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [2a00:1450:4864:20::32d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d6e86206-e4e9-11ed-b224-6b7b168915f2; Thu, 27 Apr 2023 12:54:10 +0200 (CEST) Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-3f19ab99540so59508115e9.2 for ; Thu, 27 Apr 2023 03:54:10 -0700 (PDT) Received: from [192.168.25.161] (54-240-197-238.amazon.com. [54.240.197.238]) by smtp.gmail.com with ESMTPSA id 16-20020a05600c021000b003f17a00c214sm20706483wmi.16.2023.04.27.03.54.09 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Apr 2023 03:54:09 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: d6e86206-e4e9-11ed-b224-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682592850; x=1685184850; h=content-transfer-encoding:in-reply-to:organization:reply-to :references:to:content-language:subject:user-agent:mime-version:date :message-id:from:from:to:cc:subject:date:message-id:reply-to; bh=ETIzLH2Ao6L1r/Wk/RXczxTQ2IGBk2t4SeLD3WXKhnA=; b=dV3FQP62rDRrpqmDeKqPgK3UKQCzptGQyx+xcTV42t7RjKqhX6y0jj+gLWXcG1VtBD 3KDpg9p7+za7kFadN/uP+JxEIibMQZOMCSsBU9qRCt2zmzQcWKc0lUKPkDEtsLpMs6v8 kbTUfflP9DLlWvMEtd1fvboEvq1+0ssKNM2hAwjwg8sVyPSjnHTfT9aTTZANC/bcbyz4 AFMoS1GtqKysAMLxF3vki0HHUuKcpY/ovdoQ8QPpUgEcPRbkAaPJMAEZL3ZMdJfVGJdF jJ3ZnNNfcGiuF5hLh6UCF3wcXSkbXlH/Rq+hpo6eYCmR6LamRdyIhUXTfmQEzw4lVR6f 5sdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682592850; x=1685184850; h=content-transfer-encoding:in-reply-to:organization:reply-to :references:to:content-language:subject:user-agent:mime-version:date :message-id:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ETIzLH2Ao6L1r/Wk/RXczxTQ2IGBk2t4SeLD3WXKhnA=; b=Txs4J9pqMQrCpLTLNaMXDGuHtziHk2TW5aqzLR/HILS6OMSIFS05nKOOLSLgBnu7Ng hv8mOlgCHexBy8UmT5E8d8nMzp7EBnE2RbBLdOOi/QA3vaMa5NUzSpyGvfb+thBwCWNq RLbjHbpWjjr2HQ1Mz5mza6RCqn31WNWC1cNX7CsebcPgcOPlJMIgabfUeRW6oJcQvb5Q 4jaoS3zxTjMi8CFaM8K60oj8BxcIVaHVjE0t0Ug6oqUBe2tG1UXCKqhst+VUHCz7/Lcp M3lgeiXUkFhQmRaXSyBkr0Mjvc3e48XJsbq9ON0V5pJZL4Y52o197tR5XDG303H/KfB7 2iEQ== X-Gm-Message-State: AC+VfDwbYNJT6gEO7xK7rLMSWfFvkYCT2+z1QtuYMnmwzd5peH23aCEu ghaNhMYEfLPjYd0SgEm1dCK5ZNlPb56L/g== X-Google-Smtp-Source: ACHHUZ5yA9U4Qz5Q7UdvhzTxBmHr/w8Iz7y30HC+qiDf85do0AzkCABYhuatAfe0uWvjWA6SSowZOA== X-Received: by 2002:a05:600c:378e:b0:3f0:a9b1:81e0 with SMTP id o14-20020a05600c378e00b003f0a9b181e0mr1182787wmr.19.1682592849763; Thu, 27 Apr 2023 03:54:09 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Message-ID: Date: Thu, 27 Apr 2023 11:54:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 1/3] Dont disable warning 4100 Content-Language: en-US To: win-pv-devel@lists.xenproject.org References: <20230418085045.1790-1-owen.smith@cloud.com> Reply-To: paul@xen.org Organization: Xen Project In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 27/04/2023 11:46, Paul Durrant wrote: > On 18/04/2023 09:50, Owen Smith wrote: >> From: Matthew Sykes >> >> Adds UNREFERENCED_PARAMETER macros instead of suppressing the warning. >> >> Suggested-by: Matthew Sykes >> Signed-off-by: Owen Smith > > Series... > > Acked-by: Paul Durrant > ...as are all the other similar series. I'll apply the changes to all drivers. Paul