From win-pv-devel-bounces@lists.xenproject.org Fri May 12 13:57:13 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 12 May 2023 13:57:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.533828.830780 (Exim 4.92) (envelope-from ) id 1pxTGh-0003D5-4H; Fri, 12 May 2023 13:57:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 533828.830780; Fri, 12 May 2023 13:57:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pxTGh-0003Cy-1e; Fri, 12 May 2023 13:57:11 +0000 Received: by outflank-mailman (input) for mailman id 533828; Fri, 12 May 2023 13:57:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pxTGf-0003Cs-Qc for win-pv-devel@lists.xenproject.org; Fri, 12 May 2023 13:57:09 +0000 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [2a00:1450:4864:20::331]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dfce22ff-f0cc-11ed-8611-37d641c3527e; Fri, 12 May 2023 15:57:04 +0200 (CEST) Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-3f42b984405so31813475e9.3 for ; Fri, 12 May 2023 06:57:03 -0700 (PDT) Received: from localhost.localdomain ([185.25.65.68]) by smtp.gmail.com with ESMTPSA id p5-20020a7bcc85000000b003f4dde07956sm7027634wma.42.2023.05.12.06.57.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 May 2023 06:57:02 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: dfce22ff-f0cc-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1683899823; x=1686491823; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=zjPunehKxqyZU/QyC91QpLi8ufpMwS7a5s98lrpkQ78=; b=bYEtuZYqObs09TTe0dU60CBxU0BvYUWHJhyebjFB6LOX0T4BC0bPzszIS3X25ZQDCq SxniNa1ceUFwUqCMhTfVANXOiLHZZRmxXwPzxMabol+QEt/DsCHcuxTgCtZgpPYtGtIT CSAefdTNZZouKeoXXgv8tyEnehA5UamwaXkPI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683899823; x=1686491823; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zjPunehKxqyZU/QyC91QpLi8ufpMwS7a5s98lrpkQ78=; b=LLGKSOUdcjfFw88W3s1gT25daaVNpkHTtI0yIolML5rm1u6dgh2qZ4HWkDyQCsKygF Z8FLEF+z4BdZfK63C+0gHJoVhOAtSO+xTszfbE5608HJWVILA+A5pfG4DmoEUw82BvTm fx6iNu8ARAyphRObApBqtbbJVudYNXedJFOm+cTJVS/d2qeCfamw/OafXaXcNYKgCpqm XTvR+Tp7vhmt/cnVQSoMhfxzfMpAan59DO9YSrEK5zXP0kgaAwNg9TVEAnl/eBLInBLj rFpdhkdGWPeZANG6pH4HuRdRLjQj8Cx8Oj2PPEldgxAQDn+grCd34PTTAk9fNQyu4K9K lL0w== X-Gm-Message-State: AC+VfDxaXXO37dSkHAj8VH3EENMpGkMl7KjABlTlfcryj0Q8GQ5iZ5Jq SSe9Kdzk5nRbQxB1WX6+xfKGKq+xlvILeECn7Q== X-Google-Smtp-Source: ACHHUZ6d6Mfpn/gBBdTaWiSSaZb/Gm2a+kRMaigydZYoM5u1MMuNbWIJKYW/vODv6oJtG35SfLmPbg== X-Received: by 2002:a1c:7703:0:b0:3f4:2c8f:d2d3 with SMTP id t3-20020a1c7703000000b003f42c8fd2d3mr8401671wmi.20.1683899823088; Fri, 12 May 2023 06:57:03 -0700 (PDT) From: Owen Smith To: win-pv-devel@lists.xenproject.org Cc: Owen Smith Subject: [PATCH] Always log during SettingsRestore Date: Fri, 12 May 2023 14:56:45 +0100 Message-Id: <20230512135645.43-1-owen.smith@cloud.com> X-Mailer: git-send-email 2.39.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit - removes the logging skip if the Settings key is not present - logs if the interface guid doesnt change Signed-off-by: Owen Smith --- src/xenvif/settings.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/xenvif/settings.c b/src/xenvif/settings.c index dd3c991..4dd4ec4 100644 --- a/src/xenvif/settings.c +++ b/src/xenvif/settings.c @@ -622,12 +622,8 @@ SettingsRestore( SubKeyName, KEY_READ, &SubKey); - if (!NT_SUCCESS(status)) { - if (status == STATUS_OBJECT_NAME_NOT_FOUND) - goto done; - + if (!NT_SUCCESS(status)) goto fail1; - } status = RegistryQuerySzValue(SubKey, "NetCfgInstanceId", @@ -658,6 +654,10 @@ SettingsRestore( NetLuid, &Ansi, InterfaceLuid); + } else { + Info("%s: SettingsCopy not required for %ws\n", + SubKeyName, + Description); } RtlFreeAnsiString(&Ansi); @@ -669,7 +669,6 @@ SettingsRestore( RegistryCloseKey(SubKey); -done: return STATUS_SUCCESS; fail4: -- 2.39.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Mon May 22 12:58:06 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 22 May 2023 12:58:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.537926.837572 (Exim 4.92) (envelope-from ) id 1q156x-0001oa-DS; Mon, 22 May 2023 12:58:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 537926.837572; Mon, 22 May 2023 12:58:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q156x-0001oT-AY; Mon, 22 May 2023 12:58:03 +0000 Received: by outflank-mailman (input) for mailman id 537926; Mon, 22 May 2023 12:58:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q156v-0001oN-JI for win-pv-devel@lists.xenproject.org; Mon, 22 May 2023 12:58:01 +0000 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [2a00:1450:4864:20::42e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 46bffe53-f8a0-11ed-8611-37d641c3527e; Mon, 22 May 2023 14:57:59 +0200 (CEST) Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-3093a778089so3909203f8f.1 for ; Mon, 22 May 2023 05:57:58 -0700 (PDT) Received: from [10.95.142.159] (54-240-197-235.amazon.com. [54.240.197.235]) by smtp.gmail.com with ESMTPSA id 15-20020a05600c028f00b003f435652aaesm8323918wmk.11.2023.05.22.05.57.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 May 2023 05:57:57 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: 46bffe53-f8a0-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684760278; x=1687352278; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:reply-to:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=0yg3CqltW7GOyrCuVr98kyUvBDd4qqqL1LH09If3PSA=; b=p7mMw5+xNeCX1Hvok3g44IozoPhVU0dJWMbuRUTsLGdZw8ILa686cRVKmPOmmewbT7 FhJDp2rea0BaOAFFcuiK2/Vld0Nu+KOhjIg5JPhpDSak3uYeky0oQ00rfv9uGB7Da+PK MyzmC5F833KuhUUmq6/aDAOlCi3fneSRX4XwxijOEA/e8yPWZ8MJbRy9AYblHxV/t6VE bPMn93F6bGaYtILMdlrA7Ga2TQR5WgGsDSiUD1xdsG6ZXJzPqm/D3S/R0UpWLfPX2Bw4 9BDT63ELA3FhtAlbJ+CTbUdL4U+1yfrPYF77T+bT013W+qUcaT+/oPe4SClIg5+akqTg gSBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684760278; x=1687352278; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:reply-to:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0yg3CqltW7GOyrCuVr98kyUvBDd4qqqL1LH09If3PSA=; b=EaUF1UlsFXT2Wh7TcRMl2M3Qh+HMZpxOGzNWS2MR43P8d2kaueQlS7T8Gv83WrxXaO xlshXgzMKCsRuUCR6rSCh6L/5ucWJpqU/czeMVR9mQ8bJs9kgSrlICENjm12YhbK01Zj GkQhAR7D5rzTcRfF1o/fbCl8AvKsb0N5apzQeNHtKY9zih4Sntcwx7YAZVEKc+re/xxN cSBGTNg/yc552rCj52O/DHgLfioYMLNIskyhZLeQ4YYvBiiW/yZmKGc840ruUltbcA// HFqu8EO6FfnV21lXTQxf1tXeqjGkcWvRXwJNfk0xSexBdb0zubMQczODJaN7U1MJpr1f kAUA== X-Gm-Message-State: AC+VfDxipfXlFVwFb3CKvMMlOgIGXZPUo+0zpbARmfsgPcIouw57I1tA 2HYJtPWnW9gAWWoy3ipkSrbhc5O8zyQMQBIY X-Google-Smtp-Source: ACHHUZ5Un/aaGRUM8sWWW5vpj62F3YK9pJasuJj2fZgZCQvho4+Ky4ozvPBZXxz5WyKo3+MLAvUjMw== X-Received: by 2002:adf:ee8b:0:b0:309:32e5:b47a with SMTP id b11-20020adfee8b000000b0030932e5b47amr8441811wro.63.1684760277893; Mon, 22 May 2023 05:57:57 -0700 (PDT) Message-ID: <790aeb66-f514-7ab3-d024-d00314a21447@gmail.com> Date: Mon, 22 May 2023 13:57:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Reply-To: paul@xen.org Subject: Re: [PATCH] Always log during SettingsRestore To: win-pv-devel@lists.xenproject.org References: <20230512135645.43-1-owen.smith@cloud.com> Content-Language: en-US From: "Durrant, Paul" In-Reply-To: <20230512135645.43-1-owen.smith@cloud.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/05/2023 14:56, Owen Smith wrote: > - removes the logging skip if the Settings key is not present ... which should not happen because it is created when the driver is loaded. > - logs if the interface guid doesnt change > > Signed-off-by: Owen Smith Acked-by: Paul Durrant From win-pv-devel-bounces@lists.xenproject.org Mon May 22 14:20:08 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 22 May 2023 14:20:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.537968.837651 (Exim 4.92) (envelope-from ) id 1q16OM-0006XI-Re; Mon, 22 May 2023 14:20:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 537968.837651; Mon, 22 May 2023 14:20:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q16OM-0006XA-Ny; Mon, 22 May 2023 14:20:06 +0000 Received: by outflank-mailman (input) for mailman id 537968; Mon, 22 May 2023 14:20:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q16OL-0006X4-OC for win-pv-devel@lists.xenproject.org; Mon, 22 May 2023 14:20:05 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q16OL-0007r2-JH; Mon, 22 May 2023 14:20:05 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=CBG-R90WXYV0.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q16OL-0002od-AJ; Mon, 22 May 2023 14:20:05 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=dnaeHxowMlzG9pz7y/JB1kefOJDoYuYGsY8+RNT/LH4=; b=ZNYx1aUJFd8+7Nc9UC8wUVghqu JjqkF/9Dchc1oDym/xhanAGsNicfijIQPcPpKkPg5oqZn6reWd8eZzyzJ80V1MehzDTLHdsMOGmdg /c5uYOaj8nLlpyVL2mqkjPnpgZxclPv8E8/cQ4jW57NgZBKImqEEeWiplZM2EsKNSLSA=; From: Paul Durrant To: win-pv-devel@lists.xenproject.org Cc: Paul Durrant Subject: [PATCH xenvif] Don't allow a frontend to go from Closed to Initialising... Date: Mon, 22 May 2023 15:20:01 +0100 Message-Id: <20230522142001.1045-1-paul@xen.org> X-Mailer: git-send-email 2.17.1 From: Paul Durrant ... if the backend is offline. It's possible for the enumeration thread to spot a device that is in the process of being removed. In this case the 'online' node in the backend XenStore area will be 0 and devices in this state should remain Closed. Signed-off-by: Paul Durrant --- src/xenvif/frontend.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/xenvif/frontend.c b/src/xenvif/frontend.c index 7ea66cf73610..dab0ebbec0e4 100644 --- a/src/xenvif/frontend.c +++ b/src/xenvif/frontend.c @@ -1548,8 +1548,12 @@ FrontendPrepare( break; case XenbusStateClosed: - FrontendSetXenbusState(Frontend, - XenbusStateInitialising); + if (FrontendIsBackendOnline(Frontend)) + FrontendSetXenbusState(Frontend, + XenbusStateInitialising); + else + FrontendSetOffline(Frontend); + break; case XenbusStateConnected: -- 2.17.1 From win-pv-devel-bounces@lists.xenproject.org Mon May 22 15:03:38 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 22 May 2023 15:03:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.538008.837726 (Exim 4.92) (envelope-from ) id 1q174S-00065J-NZ; Mon, 22 May 2023 15:03:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 538008.837726; Mon, 22 May 2023 15:03:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q174S-00065B-Kh; Mon, 22 May 2023 15:03:36 +0000 Received: by outflank-mailman (input) for mailman id 538008; Mon, 22 May 2023 15:03:35 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q174R-000655-5B for win-pv-devel@lists.xenproject.org; Mon, 22 May 2023 15:03:35 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" Date: Mon, 22 May 2023 15:03:26 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <22836693.1.1684767810762.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> Subject: XENBUS-master - Build #243 - Successful MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_0_12439421.1684767809669" X-Jenkins-Job: XENBUS-master X-Jenkins-Result: SUCCESS ------=_Part_0_12439421.1684767809669 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #243. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENBUS-master/243/console to view the results. ------=_Part_0_12439421.1684767809669-- From win-pv-devel-bounces@lists.xenproject.org Mon May 22 17:09:12 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 22 May 2023 17:09:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.538047.837795 (Exim 4.92) (envelope-from ) id 1q191x-0004qM-TD; Mon, 22 May 2023 17:09:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 538047.837795; Mon, 22 May 2023 17:09:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q191x-0004qF-Qe; Mon, 22 May 2023 17:09:09 +0000 Received: by outflank-mailman (input) for mailman id 538047; Mon, 22 May 2023 17:09:08 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q191w-0004q3-8T for win-pv-devel@lists.xenproject.org; Mon, 22 May 2023 17:09:08 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" Date: Mon, 22 May 2023 17:09:03 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <23051234.3.1684775343360.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> Subject: XENNET-master - Build #127 - Successful MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_2_8461655.1684775343094" X-Jenkins-Job: XENNET-master X-Jenkins-Result: SUCCESS ------=_Part_2_8461655.1684775343094 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #127. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENNET-master/127/console to view the results. ------=_Part_2_8461655.1684775343094-- From win-pv-devel-bounces@lists.xenproject.org Mon May 22 19:10:06 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 22 May 2023 19:10:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.538064.837812 (Exim 4.92) (envelope-from ) id 1q1Aux-0000Zq-M0; Mon, 22 May 2023 19:10:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 538064.837812; Mon, 22 May 2023 19:10:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q1Aux-0000ZB-Ha; Mon, 22 May 2023 19:10:03 +0000 Received: by outflank-mailman (input) for mailman id 538064; Mon, 22 May 2023 19:10:02 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q1Auw-0000K8-GY for win-pv-devel@lists.xenproject.org; Mon, 22 May 2023 19:10:02 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" Date: Mon, 22 May 2023 19:09:56 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <1380905.5.1684782597489.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> Subject: XENIFACE-master - Build #119 - Successful MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_4_14082945.1684782596973" X-Jenkins-Job: XENIFACE-master X-Jenkins-Result: SUCCESS ------=_Part_4_14082945.1684782596973 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #119. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENIFACE-master/119/console to view the results. ------=_Part_4_14082945.1684782596973-- From win-pv-devel-bounces@lists.xenproject.org Mon May 22 21:37:21 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 22 May 2023 21:37:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.538114.837896 (Exim 4.92) (envelope-from ) id 1q1DDT-0001sq-M6; Mon, 22 May 2023 21:37:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 538114.837896; Mon, 22 May 2023 21:37:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q1DDT-0001sj-Ik; Mon, 22 May 2023 21:37:19 +0000 Received: by outflank-mailman (input) for mailman id 538114; Mon, 22 May 2023 21:37:18 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q1DDS-0001sc-Hn for win-pv-devel@lists.xenproject.org; Mon, 22 May 2023 21:37:18 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" Date: Mon, 22 May 2023 21:37:12 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <30148649.7.1684791433337.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> Subject: XENCONS-master - Build #43 - Successful MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_6_7746719.1684791432900" X-Jenkins-Job: XENCONS-master X-Jenkins-Result: SUCCESS ------=_Part_6_7746719.1684791432900 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #43. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENCONS-master/43/console to view the results. ------=_Part_6_7746719.1684791432900-- From win-pv-devel-bounces@lists.xenproject.org Mon May 22 23:27:50 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Mon, 22 May 2023 23:27:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.538140.837935 (Exim 4.92) (envelope-from ) id 1q1EwN-0005rI-Vb; Mon, 22 May 2023 23:27:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 538140.837935; Mon, 22 May 2023 23:27:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q1EwN-0005rB-St; Mon, 22 May 2023 23:27:47 +0000 Received: by outflank-mailman (input) for mailman id 538140; Mon, 22 May 2023 23:27:46 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q1EwM-0005r5-LP for win-pv-devel@lists.xenproject.org; Mon, 22 May 2023 23:27:46 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" Date: Mon, 22 May 2023 23:27:40 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <15661035.9.1684798061247.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> Subject: XENVBD-master - Build #166 - Successful MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_8_25841057.1684798060700" X-Jenkins-Job: XENVBD-master X-Jenkins-Result: SUCCESS ------=_Part_8_25841057.1684798060700 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #166. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENVBD-master/166/console to view the results. ------=_Part_8_25841057.1684798060700-- From win-pv-devel-bounces@lists.xenproject.org Tue May 23 00:12:11 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 23 May 2023 00:12:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.538148.837941 (Exim 4.92) (envelope-from ) id 1q1FdJ-0002mQ-Uq; Tue, 23 May 2023 00:12:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 538148.837941; Tue, 23 May 2023 00:12:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q1FdJ-0002mI-RY; Tue, 23 May 2023 00:12:09 +0000 Received: by outflank-mailman (input) for mailman id 538148; Tue, 23 May 2023 00:12:07 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q1FdH-0002mC-Tg for win-pv-devel@lists.xenproject.org; Tue, 23 May 2023 00:12:07 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" Date: Tue, 23 May 2023 00:12:02 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <28903235.11.1684800722436.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> Subject: XENHID-master - Build #35 - Successful MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_10_16410442.1684800722217" X-Jenkins-Job: XENHID-master X-Jenkins-Result: SUCCESS ------=_Part_10_16410442.1684800722217 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #35. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENHID-master/35/console to view the results. ------=_Part_10_16410442.1684800722217-- From win-pv-devel-bounces@lists.xenproject.org Tue May 23 00:32:02 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 23 May 2023 00:32:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.538156.837943 (Exim 4.92) (envelope-from ) id 1q1FwW-0004lg-A2; Tue, 23 May 2023 00:32:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 538156.837943; Tue, 23 May 2023 00:32:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q1FwW-0004lZ-7d; Tue, 23 May 2023 00:32:00 +0000 Received: by outflank-mailman (input) for mailman id 538156; Tue, 23 May 2023 00:31:59 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q1FwV-0004lT-Fe for win-pv-devel@lists.xenproject.org; Tue, 23 May 2023 00:31:59 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" Date: Tue, 23 May 2023 00:31:53 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <32920462.13.1684801913983.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> Subject: XENVIF-master - Build #207 - Successful MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_12_8376777.1684801913655" X-Jenkins-Job: XENVIF-master X-Jenkins-Result: SUCCESS ------=_Part_12_8376777.1684801913655 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #207. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENVIF-master/207/console to view the results. ------=_Part_12_8376777.1684801913655-- From win-pv-devel-bounces@lists.xenproject.org Tue May 23 01:31:18 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 23 May 2023 01:31:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.538185.837977 (Exim 4.92) (envelope-from ) id 1q1Grs-00027W-9l; Tue, 23 May 2023 01:31:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 538185.837977; Tue, 23 May 2023 01:31:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q1Grs-00027P-79; Tue, 23 May 2023 01:31:16 +0000 Received: by outflank-mailman (input) for mailman id 538185; Tue, 23 May 2023 01:31:15 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q1Grr-00027J-Ci for win-pv-devel@lists.xenproject.org; Tue, 23 May 2023 01:31:15 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" Date: Tue, 23 May 2023 01:31:09 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <10991094.15.1684805469813.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> Subject: XENVKBD-master - Build #37 - Successful MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_14_27627188.1684805469641" X-Jenkins-Job: XENVKBD-master X-Jenkins-Result: SUCCESS ------=_Part_14_27627188.1684805469641 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #37. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENVKBD-master/37/console to view the results. ------=_Part_14_27627188.1684805469641-- From win-pv-devel-bounces@lists.xenproject.org Tue May 23 01:43:29 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Tue, 23 May 2023 01:43:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.538193.837982 (Exim 4.92) (envelope-from ) id 1q1H3f-00039h-6D; Tue, 23 May 2023 01:43:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 538193.837982; Tue, 23 May 2023 01:43:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q1H3f-00039Z-3A; Tue, 23 May 2023 01:43:27 +0000 Received: by outflank-mailman (input) for mailman id 538193; Tue, 23 May 2023 01:43:25 +0000 Received: from winpvdrvbuild.xenproject.org ([162.242.160.44]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q1H3d-00039S-8V for win-pv-devel@lists.xenproject.org; Tue, 23 May 2023 01:43:25 +0000 X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" Date: Tue, 23 May 2023 01:43:19 +0000 (UTC) From: paul.durrant@xenproject.org To: win-pv-devel@lists.xenproject.org Message-ID: <32567295.17.1684806199657.JavaMail.WINPVDRVBUILD$@winpvdrvbuild> Subject: XENIFACE-master - Build #120 - Successful MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_16_23896873.1684806199407" X-Jenkins-Job: XENIFACE-master X-Jenkins-Result: SUCCESS ------=_Part_16_23896873.1684806199407 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The build system has completed build #120. Check console output at https://winpvdrvbuild.xenproject.org:8080/job/XENIFACE-master/120/console to view the results. ------=_Part_16_23896873.1684806199407-- From win-pv-devel-bounces@lists.xenproject.org Thu May 25 15:14:38 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 25 May 2023 15:14:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.539672.840802 (Exim 4.92) (envelope-from ) id 1q2Cfl-0003x5-O5; Thu, 25 May 2023 15:14:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 539672.840802; Thu, 25 May 2023 15:14:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q2Cfl-0003wy-LC; Thu, 25 May 2023 15:14:37 +0000 Received: by outflank-mailman (input) for mailman id 539672; Thu, 25 May 2023 15:14:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q2Cfk-0003vA-JU for win-pv-devel@lists.xenproject.org; Thu, 25 May 2023 15:14:36 +0000 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [2a00:1450:4864:20::335]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id da6064a4-fb0e-11ed-8611-37d641c3527e; Thu, 25 May 2023 17:14:33 +0200 (CEST) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-3f6e1394060so3526485e9.3 for ; Thu, 25 May 2023 08:14:33 -0700 (PDT) Received: from localhost.localdomain ([185.25.65.68]) by smtp.gmail.com with ESMTPSA id a13-20020adffacd000000b003064600cff9sm2132089wrs.38.2023.05.25.08.14.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 May 2023 08:14:31 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: da6064a4-fb0e-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1685027672; x=1687619672; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yPvOH1QCdNTFBY0nhEvozT1fu/2Oo9X2Xvg0pzGwkhI=; b=TICx14UA84ypdrj0ky1mkct3g7xDHm4hSeT+vGZjTZ4BzKaawBizmsoVrGWWHdJGg9 k999487H/MZ2xt/+b+PVZ3eKoQAgUS6Dpj1tblgt+IOWPYxUWDL4r0WkP14WcQXm8xUu sGcDOoEzOjvNDeEyNFSbFtvU1fLTs0hUdTmW0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685027672; x=1687619672; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yPvOH1QCdNTFBY0nhEvozT1fu/2Oo9X2Xvg0pzGwkhI=; b=YrGIAz8ZA7WY9PXj89Rk0camBNGehhrBDAlkBsQKHLx8ylEupXCalFuILW23BHdvBD dRWjY2/mpOreJjfi7iiHEhnQLSg8i89+Ayeu1y8fOgKM/5ZalCobwX/r9Y6/ZA0+JQgd JwxfdkDbv+zAwqlWQ9I/UsNjS5jA6W/0BGPvrhYmeh7DKMxg4d4JbBMSEGzh99RjW4I8 QfHkDYJYya58lzACXA72C7fQ7hdxi9rIW9jbW99PzvMQMoMbHJ0iY+v64D6us4h/REhf ek7OmqvIrUSgNzR61sl4LX6I1dLWAqVKO/CSJdPYxb8eYpYHVuOW6x4ZQROchnMceBeC HJ2A== X-Gm-Message-State: AC+VfDyo38pJBUEz2CfpInVZjbNBmqeXjIEChjCjl9+5SkChyUmtcJW9 l9I8KmtIF2/fI1W+cWDNj/RQKLbtTvWnxQTJpg== X-Google-Smtp-Source: ACHHUZ4Oo/ZPciMlmv5cyF2zm/Uoyf/YaLLq8du6iiiLtXE5kHY+HG8uIkpA2EcOAC0hVa4DwM4x5g== X-Received: by 2002:a5d:6d41:0:b0:30a:b0e7:34b with SMTP id k1-20020a5d6d41000000b0030ab0e7034bmr2858438wri.66.1685027672338; Thu, 25 May 2023 08:14:32 -0700 (PDT) From: Owen Smith To: win-pv-devel@lists.xenproject.org Cc: Owen Smith Subject: [PATCH 3/3] Allow removal of current Slab Date: Thu, 25 May 2023 16:14:11 +0100 Message-Id: <20230525151411.826-3-owen.smith@cloud.com> X-Mailer: git-send-email 2.39.0.windows.1 In-Reply-To: <20230525151411.826-1-owen.smith@cloud.com> References: <20230525151411.826-1-owen.smith@cloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Owen Smith When all Objects in the current Slab have been freed, its possible that the current Slab will be destroyed. Its not guaranteed that the current Slab is the only Slab in the SlabList, as objects can be returned in a different order than allocated, especially after objects have been reused. Walk the Cursor back to the previous Slab (or SlabList header) and allow for the possibility that the current Slab may be full during the CacheGet call (which will require creation of another Slab) Signed-off-by: Owen Smith --- src/xenbus/cache.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/src/xenbus/cache.c b/src/xenbus/cache.c index 07dcd56..e2aa137 100644 --- a/src/xenbus/cache.c +++ b/src/xenbus/cache.c @@ -471,14 +471,11 @@ CacheDestroySlab( ASSERT3U(Cache->Count, >=, CacheMaskSize(Slab->Allocated)); Cache->Count -= CacheMaskSize(Slab->Allocated); - // - // The only reason the cursor should be pointing at this slab is - // if it is the only one in the list. - // if (Cache->Cursor == &Slab->ListEntry) - Cache->Cursor = &Cache->SlabList; + Cache->Cursor = Slab->ListEntry.Blink; - RemoveEntryList(&Slab->ListEntry); + if (RemoveEntryList(&Slab->ListEntry)) + Cache->Cursor = &Cache->SlabList; ASSERT(Cache->Cursor != &Cache->SlabList || IsListEmpty(&Cache->SlabList)); @@ -614,17 +611,17 @@ again: Slab = CONTAINING_RECORD(ListEntry, XENBUS_CACHE_SLAB, ListEntry); Object = CacheGetObjectFromSlab(Slab); - ASSERT(Object != NULL); - if (CacheMaskCount(Slab->Allocated) == CacheMaskSize(Slab->Allocated)) + if (CacheMaskCount(Slab->Allocated) == CacheMaskSize(Slab->Allocated)) { Cache->Cursor = Slab->ListEntry.Flink; + if (Object == NULL) + goto again; + } } if (Object == NULL) { NTSTATUS status; - ASSERT3P(Cache->Cursor, ==, &Cache->SlabList); - status = CacheCreateSlab(Cache); if (NT_SUCCESS(status)) { ASSERT(Cache->Cursor != &Cache->SlabList); -- 2.39.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Thu May 25 15:14:38 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 25 May 2023 15:14:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.539671.840798 (Exim 4.92) (envelope-from ) id 1q2Cfk-0003vS-NH; Thu, 25 May 2023 15:14:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 539671.840798; Thu, 25 May 2023 15:14:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q2Cfk-0003vG-Jq; Thu, 25 May 2023 15:14:36 +0000 Received: by outflank-mailman (input) for mailman id 539671; Thu, 25 May 2023 15:14:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q2Cfj-0003vA-Td for win-pv-devel@lists.xenproject.org; Thu, 25 May 2023 15:14:35 +0000 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [2a00:1450:4864:20::334]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d9c0a592-fb0e-11ed-8611-37d641c3527e; Thu, 25 May 2023 17:14:32 +0200 (CEST) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-3f6d01d390bso7756905e9.2 for ; Thu, 25 May 2023 08:14:32 -0700 (PDT) Received: from localhost.localdomain ([185.25.65.68]) by smtp.gmail.com with ESMTPSA id a13-20020adffacd000000b003064600cff9sm2132089wrs.38.2023.05.25.08.14.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 May 2023 08:14:30 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: d9c0a592-fb0e-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1685027671; x=1687619671; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xhN/nRUMwwV/JwfKlrxVD7bRFr8a5fP25+lWz0CauhA=; b=ZHgzEIQQPk2wTxmwxrO/utF93cWD71Vesf5NhWUanOsWMpMSsTPBlEuA5ONRFVXGUE jsRcWCIiN1NHn0Ele0+YZatuQzeRaejrKtGFC/7eFMLOek6rHut/GewrLitJqWXaiVHi OOlVlhNlel5LFGcNxQb5JdJBVYjssZ3bGzWsk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685027671; x=1687619671; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xhN/nRUMwwV/JwfKlrxVD7bRFr8a5fP25+lWz0CauhA=; b=JZDPH9lBXCqQfE+5rMnWgzz/gIqd5MIv3ggivuZby/58ef+ZzwMyOAemoSpe8/HEFB KHDTUHRkMUKDfyPaSm3/X5zrkmyAyxDaAT20ftokyKajEBmO8JfzvCHo0XvJ99zAKtOQ i7xhZxhbeNxIdkLaQfHSs70UCbSrDvW7iHK8xk7j4OzKO/mZf79CfyHcrcME30xRPgdz tXzp+iYRXKhwWuEoBZSzDeuwMRRwA4xhrI23baaP9k8GeP31g6HY9z7GLXf9Vhc4+SFn rpEI4no5uSRYKjV49/phmqzbDCRsL3QHIiNbQBMPrINvW780mpr6Zj5E0NUgpJ7ZRb9q VSHA== X-Gm-Message-State: AC+VfDwtVVHxs7/uWhjN5jhetxD1CFBzcuddcot6N4yj0wd6waJrH0la YBBT0Tiw7oUtNv1NYMLHPYxi+sK92bCSfH1ayA== X-Google-Smtp-Source: ACHHUZ7B1X5X04vcHAmg8cpQdmieSMwD5YZrPyMyx0j8T834V2aJZ4c6UpRlHTdZPJuhKGW67eBysA== X-Received: by 2002:a05:6000:1807:b0:307:bbbe:cd13 with SMTP id m7-20020a056000180700b00307bbbecd13mr2780902wrh.59.1685027671125; Thu, 25 May 2023 08:14:31 -0700 (PDT) From: Owen Smith To: win-pv-devel@lists.xenproject.org Cc: Owen Smith Subject: [PATCH 2/3] Add logging for Active/Maximum Processors Date: Thu, 25 May 2023 16:14:10 +0100 Message-Id: <20230525151411.826-2-owen.smith@cloud.com> X-Mailer: git-send-email 2.39.0.windows.1 In-Reply-To: <20230525151411.826-1-owen.smith@cloud.com> References: <20230525151411.826-1-owen.smith@cloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Server 2022 can report Active = 32, Maximum = 64 Signed-off-by: Owen Smith --- src/xen/system.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/xen/system.c b/src/xen/system.c index 3c01397..844deea 100644 --- a/src/xen/system.c +++ b/src/xen/system.c @@ -1263,6 +1263,7 @@ SystemInitialize( LONG References; HANDLE ParametersKey; ULONG RegisterVcpuInfo; + ULONG ActiveProcessors; NTSTATUS status; References = InterlockedIncrement(&Context->References); @@ -1271,9 +1272,12 @@ SystemInitialize( if (References != 1) goto fail1; + ActiveProcessors = KeQueryActiveProcessorCountEx(ALL_PROCESSOR_GROUPS); Context->ProcessorCount = KeQueryMaximumProcessorCountEx(ALL_PROCESSOR_GROUPS); Context->Processor = __SystemAllocate(sizeof (SYSTEM_PROCESSOR) * Context->ProcessorCount); + Info("CPUs %u / %u\n", ActiveProcessors, Context->ProcessorCount); + status = STATUS_NO_MEMORY; if (Context->Processor == NULL) goto fail2; -- 2.39.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Thu May 25 15:14:38 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Thu, 25 May 2023 15:14:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.539673.840806 (Exim 4.92) (envelope-from ) id 1q2Cfm-0003z0-PR; Thu, 25 May 2023 15:14:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 539673.840806; Thu, 25 May 2023 15:14:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q2Cfm-0003yt-Mh; Thu, 25 May 2023 15:14:38 +0000 Received: by outflank-mailman (input) for mailman id 539673; Thu, 25 May 2023 15:14:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q2Cfl-0003vA-Jj for win-pv-devel@lists.xenproject.org; Thu, 25 May 2023 15:14:37 +0000 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [2a00:1450:4864:20::431]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d93b73e5-fb0e-11ed-8611-37d641c3527e; Thu, 25 May 2023 17:14:32 +0200 (CEST) Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-309382efe13so1579517f8f.2 for ; Thu, 25 May 2023 08:14:31 -0700 (PDT) Received: from localhost.localdomain ([185.25.65.68]) by smtp.gmail.com with ESMTPSA id a13-20020adffacd000000b003064600cff9sm2132089wrs.38.2023.05.25.08.14.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 May 2023 08:14:29 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: d93b73e5-fb0e-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1685027670; x=1687619670; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Fd5dOJv8l0hZy205tzRBbjotCEr5+OkXfYE8v0vAJX4=; b=F49DFrIQQWzGNf/Ps96l8B4R8d3aSGhgLMdBFNSS8tMvT+wmNXsj/eksyemndww9r7 HjUcIQQfmHCP5x9lNXVeO7u6pmTn1KAf3dm0mpwlv1ORlUFYTFa9mDf9gOegy7pqIqX/ KZNTG3xml/wFiJZEtPSFeVs5pMhPZEyE9YpvA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685027670; x=1687619670; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Fd5dOJv8l0hZy205tzRBbjotCEr5+OkXfYE8v0vAJX4=; b=fWSlZjd2i2vQru1WxA/9J1RGqZ0KtuWV0iUsX/AP2Zq+ixcgNciB1VWRsbZJl4G7Al rCXMQvZJoafwyLkY58raW0UiNY45lxYyFHSHquf1T7toHDZfwEOJC6lwu1nrQpLVqc81 lJn2XURAI7wN4TXAE6r/n6oPMRMTdxUocSTAHGUPYrOUb1Ugjhw2WgUBqQOJWdYOoO9T MFzjIsTO8qphtuxxwcmzUJEOXmDvajAEraowacSEKc1YvTFFkI8CkNi/FfThx/UMfZcd zYgvlS152FJh2cibv5BgI0czptjBwuW97rm6BtNa9u/L77KA2q12ZVyocwzqpIOuKdAZ NM8g== X-Gm-Message-State: AC+VfDxhqOhyMI2iNt6RsELOc20sig7czaEJVz+1Cuf5hIP11TH/b89I y1Lq80eEujzx1+qezSFXqyp1PftuQnD4mO0v2A== X-Google-Smtp-Source: ACHHUZ7KKEL/H1L5vbb0hKZWLFx2/BpciiC8x7WoqHjaAuHJg6BsaatAAwHmFgRgG4u4L0clMZOhSg== X-Received: by 2002:adf:f6c9:0:b0:306:31e0:964 with SMTP id y9-20020adff6c9000000b0030631e00964mr2503161wrp.55.1685027669725; Thu, 25 May 2023 08:14:29 -0700 (PDT) From: Owen Smith To: win-pv-devel@lists.xenproject.org Cc: Owen Smith Subject: [PATCH 1/3] Fix buffer overrun when suspending VMs with many vCPUs Date: Thu, 25 May 2023 16:14:09 +0100 Message-Id: <20230525151411.826-1-owen.smith@cloud.com> X-Mailer: git-send-email 2.39.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Dynamically allocate the KDPC array when there are more active vCPUs that would fit into the single PAGE_SIZE region that is pre-allocated. __Section is defined as a PAGE_SIZE region, which can only contain a limited number of KDPC objects in addition to the SYNC_CONTEXT header. When there is insufficient space for a KDPC object per vCPU, dynamically allocate space for the KDPC array. This prevents a buffer overrun when accessing indexes with 64 vCPUs. Dynamic allocation will allow this to expand to many vCPUs beyond 64. Signed-off-by: Owen Smith --- src/xenbus/sync.c | 50 ++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 47 insertions(+), 3 deletions(-) diff --git a/src/xenbus/sync.c b/src/xenbus/sync.c index fdfaf2d..4418c8e 100644 --- a/src/xenbus/sync.c +++ b/src/xenbus/sync.c @@ -96,12 +96,43 @@ typedef struct _SYNC_CONTEXT { LONG ProcessorCount; SYNC_REQUEST Request; LONG CompletionCount; + PKDPC Dpcs; KDPC Dpc[1]; } SYNC_CONTEXT, *PSYNC_CONTEXT; static PSYNC_CONTEXT SyncContext = (PVOID)__Section; static LONG SyncOwner = -1; +#define MAX_DPCS_PER_PAGE ((PAGE_SIZE - sizeof(SYNC_CONTEXT)) / sizeof(KDPC)) +#define SYNC_POOL_TAG 'CNYS' + +static FORCEINLINE PVOID +__SyncAllocate( + IN ULONG Size + ) +{ + PVOID Buffer; + + if (Size == 0) + return NULL; + + Buffer = ExAllocatePoolWithTag(NonPagedPool, + Size, + SYNC_POOL_TAG); + if (Buffer != NULL) + RtlZeroMemory(Buffer, Size); + + return Buffer; +} + +static FORCEINLINE VOID +__SyncFree( + IN PVOID Buffer + ) +{ + ExFreePoolWithTag(Buffer, SYNC_POOL_TAG); +} + static FORCEINLINE VOID __SyncAcquire( IN LONG Index @@ -343,15 +374,23 @@ SyncCapture( Context->Late = Late; Context->CompletionCount = 0; - KeMemoryBarrier(); + + Context->Dpcs = &Context->Dpc[0]; Context->ProcessorCount = KeQueryActiveProcessorCountEx(ALL_PROCESSOR_GROUPS); + if (Context->ProcessorCount >= MAX_DPCS_PER_PAGE) { + Context->Dpcs = __SyncAllocate(Context->ProcessorCount * sizeof(KDPC)); + ASSERT(Context->Dpcs != NULL); + } + + KeMemoryBarrier(); for (Index = 0; Index < Context->ProcessorCount; Index++) { - PKDPC Dpc = &Context->Dpc[Index]; + PKDPC Dpc = &Context->Dpcs[Index]; NTSTATUS status; - ASSERT3U((ULONG_PTR)(Dpc + 1), <, (ULONG_PTR)__Section + PAGE_SIZE); + // Imply Context->Dpcs == &Context->Dpc[0] -> + // ASSERT3U((ULONG_PTR)(Dpc + 1), <, (ULONG_PTR)__Section + PAGE_SIZE); status = KeGetProcessorNumberFromIndex(Index, &ProcNumber); ASSERT(NT_SUCCESS(status)); @@ -489,6 +528,11 @@ SyncRelease( __SyncWait(); + if (Context->ProcessorCount >= MAX_DPCS_PER_PAGE) { + ASSERT3P(Context->Dpcs, !=, &Context->Dpc[0]); + __SyncFree(Context->Dpcs); + } + RtlZeroMemory(Context, PAGE_SIZE); __SyncRelease(); -- 2.39.0.windows.1 From win-pv-devel-bounces@lists.xenproject.org Fri May 26 08:17:35 2023 Return-path: Envelope-to: archives@lists.xenproject.org Delivery-date: Fri, 26 May 2023 08:17:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.540012.841426 (Exim 4.92) (envelope-from ) id 1q2Sdh-0002y5-21; Fri, 26 May 2023 08:17:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 540012.841426; Fri, 26 May 2023 08:17:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q2Sdg-0002xx-VM; Fri, 26 May 2023 08:17:32 +0000 Received: by outflank-mailman (input) for mailman id 540012; Fri, 26 May 2023 08:17:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q2Sdf-0002xK-Rp for win-pv-devel@lists.xenproject.org; Fri, 26 May 2023 08:17:31 +0000 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [2a00:1450:4864:20::32d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c1b68fea-fb9d-11ed-b230-6b7b168915f2; Fri, 26 May 2023 10:17:30 +0200 (CEST) Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-3f6ef9a928fso447365e9.3 for ; Fri, 26 May 2023 01:17:29 -0700 (PDT) Received: from localhost.localdomain ([185.25.65.68]) by smtp.gmail.com with ESMTPSA id q10-20020adfdfca000000b003078681a1e8sm4293820wrn.54.2023.05.26.01.17.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 May 2023 01:17:28 -0700 (PDT) X-BeenThere: win-pv-devel@lists.xenproject.org List-Id: Developer list for the Windows PV Drivers subproject List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: win-pv-devel-bounces@lists.xenproject.org Precedence: list Sender: "win-pv-devel" X-Inumbo-ID: c1b68fea-fb9d-11ed-b230-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1685089049; x=1687681049; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=AHhF17OLHCsNcdPh9Ndy+txSBd0GnfDqpc03RrY2WZs=; b=h+i+6C/ybz/QHiPNNWGEJD1Cc4nVHJxUyIErFhZGhPz4p8G+kafF+S9oC0JpJcgdwj WzsaSHbixONaCdJnTMQC71ZzSmq1PAj0ExgCgTTsJ+os4qGmbtuDHvDE7pT8V/mQB2mu Qcf11U2ETCud0AjaGoNz7f1wnvpWsR9qCJu2E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685089049; x=1687681049; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AHhF17OLHCsNcdPh9Ndy+txSBd0GnfDqpc03RrY2WZs=; b=eAKtf+W/jZWjchAKWnDReEjGEgGXXkZxTCDRjDHDpPEyQ78ikzCxlYLAH/TqOiYq6s xqgk5g/VhDzqfvv/mYN+APhrebniIokSb06T7rUDWLoNzl89kjJty1qRl7WMUJCvTuA1 QFEaLx+F/5fGrPzCtU66YrZgVKTpMpNDYfLW77GRyUQMXA2SCUaP2WDAMiMTNiDZBLIP VBmGI+0XbFtW8/1d+ynLAgCoWy9DpjCtC9TtHQNrDwKXtTzRh0XoJtPq04iiD6FWsN+m fMc7h5JONz5E5zQAG64blaZ09W2aRnLxj1Fdd80UoQRlwcwIwGjQUn4DzqoDgiNmtsSj BHKA== X-Gm-Message-State: AC+VfDzkijZXkB51S5Y/VyAb3jRzw8nBxFf382oBmbXxhK09dFDw1qAV nmh0fNP6YydxQNwUjTjENt5PVthy3/4q5nuV/g== X-Google-Smtp-Source: ACHHUZ5ptWuhTFnmN+ZnEHo/tdLjKKU6tFhCvMY7eZjuJX45wq/4Sj0lx3HTG8aNaITR592YvnAp3g== X-Received: by 2002:adf:dd4b:0:b0:30a:9927:efe3 with SMTP id u11-20020adfdd4b000000b0030a9927efe3mr721735wrm.10.1685089048947; Fri, 26 May 2023 01:17:28 -0700 (PDT) From: Owen Smith To: win-pv-devel@lists.xenproject.org Cc: Owen Smith Subject: [PATCH] Set FrontendMaxQueues by default Date: Fri, 26 May 2023 09:17:10 +0100 Message-Id: <20230526081710.1222-1-owen.smith@cloud.com> X-Mailer: git-send-email 2.39.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Limiting the number of queues to the same value defined in xennet's INF file prevents xenvif from allocating many more resources than required. Currently, xenvif will allocate a queue for each active CPU, but xennet only reports a maximum of 8 RSS queues to Windows. When vCPU count is greather than 8, additional queues are not used and just consume resources. Signed-off-by: Owen Smith --- src/xenvif.inf | 1 + 1 file changed, 1 insertion(+) diff --git a/src/xenvif.inf b/src/xenvif.inf index d81fe52..4b5c9f7 100644 --- a/src/xenvif.inf +++ b/src/xenvif.inf @@ -88,6 +88,7 @@ HKR,,"BootFlags",0x00010003,0x81 [XenVif_Parameters] HKR,"Parameters",,0x00000010 HKR,"Parameters","RequestKey",0x00000000,%RequestKey% +HKR,"Parameters","FrontendMaxQueues",0x00010001,0x00000008 [XenVif_Inst.CoInstallers] CopyFiles=CoInst_CopyFiles -- 2.39.0.windows.1