From xen-api-bounces@lists.xenproject.org Thu Nov 28 00:54:20 2019 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Nov 2019 00:54:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ia84Q-0000HS-2K; Thu, 28 Nov 2019 00:54:10 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ia84O-0000Gf-Jh for xen-api@lists.xenproject.org; Thu, 28 Nov 2019 00:54:08 +0000 X-Inumbo-ID: 949a776a-1179-11ea-a3c4-12813bfff9fa Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 949a776a-1179-11ea-a3c4-12813bfff9fa; Thu, 28 Nov 2019 00:54:07 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5286D20661; Thu, 28 Nov 2019 00:54:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574902446; bh=iJEb+4SPDgdNtgzcXfxN2lbRBImN9YGqE4uU8Dba+5I=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=0UHHP5NV/CnX0ZY8M0SYr5CKhlS35Ztq2TUn/947hnUpWA0i2lXOI08NSopT9MSi8 1Zyxk2x9LhZSW3NtSjRa/oPhI1YOF6O4zoDEaKBY+fh5yguXVyXQR22RvJoHw2rHf3 JSmYCdsnH5yu9dDYgfxggO+iFaKvnuGjTACP6gY0= Date: Wed, 27 Nov 2019 16:54:05 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Lars Kurth In-Reply-To: <97e3adf75cf71ba39e702d4cab23236ada8d5a6c.1569525222.git.lars.kurth@citrix.com> Message-ID: References: <97e3adf75cf71ba39e702d4cab23236ada8d5a6c.1569525222.git.lars.kurth@citrix.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-168241973-1574899840=:27669" Content-ID: Subject: Re: [Xen-API] [PATCH v2 4/6] Add Code Review Guide X-BeenThere: xen-api@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: User and development list for XCP and XAPI List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Lars Kurth , xen-api@lists.xenproject.org, minios-devel@lists.xenproject.org, committers@xenproject.org, mirageos-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, win-pv-devel@lists.xenproject.org Errors-To: xen-api-bounces@lists.xenproject.org Sender: "Xen-api" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-168241973-1574899840=:27669 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Thu, 26 Sep 2019, Lars Kurth wrote: > From: Lars Kurth > > This document highlights what reviewers such as maintainers and committers look > for when reviewing code. It sets expectations for code authors and provides > a framework for code reviewers. I think the document is missing a couple of things: - a simple one line statement that possibly the most important thing in a code review is to indentify any bugs in the code - an explanation that requests for major changes to the series should be made early on (i.e. let's not change the architecture of a feature at v9 if possible) I also made this comment in reply to patch #5. I'll let you decide where is the best place for it. > Signed-off-by: Lars Kurth > --- > Cc: minios-devel@lists.xenproject.org > Cc: xen-api@lists.xenproject.org > Cc: win-pv-devel@lists.xenproject.org > Cc: mirageos-devel@lists.xenproject.org > Cc: committers@xenproject.org > --- > code-review-guide.md | 125 +++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 125 insertions(+) > create mode 100644 code-review-guide.md > > diff --git a/code-review-guide.md b/code-review-guide.md > new file mode 100644 > index 0000000..8639431 > --- /dev/null > +++ b/code-review-guide.md > @@ -0,0 +1,125 @@ > +# Code Review Guide > + > +This document highlights what reviewers such as maintainers and committers look > +for when reviewing your code. It sets expectations for code authors and provides > +a framework for code reviewers. > + > +This document does **not cover** the following topics: > +* [Communication Best Practice](communication-practice.md) > +* [Resolving Disagreement](resolving-disagreement.md) > +* [Patch Submission Workflow](https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches) > +* [Managing Patch Submission with Git](https://wiki.xenproject.org/wiki/Managing_Xen_Patches_with_Git) > + > +## What we look for in Code Reviews > +When performing a code review, reviewers typically look for the following things > + > +### Is the change necessary to accomplish the goals? > +* Is it clear what the goals are? > +* Do we need to make a change, or can the goals be met with existing > + functionality? > + > +### Architecture / Interface > +* Is this the best way to solve the problem? > +* Is this the right part of the code to modify? > +* Is this the right level of abstraction? > +* Is the interface general enough? Too general? Forward compatible? > + > +### Functionality > +* Does it do what it’s trying to do? > +* Is it doing it in the most efficient way? > +* Does it handle all the corner / error cases correctly? > + > +### Maintainability / Robustness > +* Is the code clear? Appropriately commented? > +* Does it duplicate another piece of code? > +* Does the code make hidden assumptions? > +* Does it introduce sections which need to be kept **in sync** with other sections? > +* Are there other **traps** someone modifying this code might fall into? > + > +**Note:** Sometimes you will work in areas which have identified maintainability > +and/or robustness issues. In such cases, maintainers may ask you to make additional > +changes, such that your submitted code does not make things worse or point you > +to other patches are already being worked on. > + > +### System properties > +In some areas of the code, system properties such as > +* Code size > +* Performance > +* Scalability > +* Latency > +* Complexity > +* &c > +are also important during code reviews. > + > +### Style > +* Comments, carriage returns, **snuggly braces**, &c > +* See [CODING_STYLE](https://xenbits.xenproject.org/gitweb/?p=xen.git;a=blob;f=CODING_STYLE) > + and [tools/libxl/CODING_STYLE](https://xenbits.xenproject.org/gitweb/?p=xen.git;a=blob;f=tools/libxl/CODING_STYLE) > +* No extraneous whitespace changes > + > +### Documentation and testing > +* If there is pre-existing documentation in the tree, such as man pages, design > + documents, etc. a contributor may be asked to update the documentation alongside > + the change. Documentation is typically present in the > + [docs](https://xenbits.xen.org/gitweb/?p=xen.git;a=tree;f=docs) folder. > +* When adding new features that have an impact on the end-user, > + a contributor should include an update to the > + [SUPPORT.md](https://xenbits.xen.org/gitweb/?p=xen.git;a=tree;f=docs) file. > + Typically, more complex features require several patch series before it is ready to be > + advertised in SUPPORT.md > +* When adding new features, a contributor may be asked to provide tests or > + ensure that existing tests pass > + > +#### Testing for the Xen Project Hypervisor > +Tests are typically located in one of the following directories > +* **Unit tests**: [tools/tests](https://xenbits.xenproject.org/gitweb/?p=xen.git;a=tree;f=tools/tests) > +or [xen/test](https://xenbits.xenproject.org/gitweb/?p=xen.git;a=tree;f=xen/test)
> + Unit testing is hard for a system like Xen and typically requires building a subsystem of > + your tree. If your change can be easily unit tested, you should consider submitting tests > + with your patch. > +* **Build and smoke test**: see [Xen GitLab CI](https://gitlab.com/xen-project/xen/pipelines)
> + Runs build tests for a combination of various distros and compilers against changes > + committed to staging. Developers can join as members and test their development > + branches **before** submitting a patch. > +* **XTF tests** (microkernel-based tests): see [XTF](https://xenbits.xenproject.org/docs/xtf/)
> + XTF has been designed to test interactions between your software and hardware. > + It is a very useful tool for testing low level functionality and is executed as part of the > + project's CI system. XTF can be easily executed locally on xen.git trees. > +* **osstest**: see [README](https://xenbits.xenproject.org/gitweb/?p=osstest.git;a=blob;f=README)
> + Osstest is the Xen Projects automated test system, which tests basic Xen use cases on > + a variety of different hardware. Before changes are committed, but **after** they have > + been reviewed. A contributor’s changes **cannot be applied to master** unless the > + tests pass this test suite. Note that XTF and other tests are also executed as part of > + osstest. > + > +### Patch / Patch series information > +* Informative one-line changelog > +* Full changelog > +* Motivation described > +* All important technical changes mentioned > +* Changes since previous revision listed > +* Reviewed-by’s and Acked-by’s dropped if appropriate > + > +More information related to these items can be found in our > +[Patch submission Guide](https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches). > + > +## Reviewing for Patch Authors > + > +The following presentation by George Dunlap, provides an excellent overview on how > +we do code reviews, specifically targeting non-maintainers. > + > +As a community, we would love to have more help reviewing, including from **new > +community members**. But many people > +* do not know where to start, or > +* believe that their review would not contribute much, or > +* may feel intimidated reviewing the code of more established community members > + > +The presentation demonstrates that you do not need to worry about any of these > +concerns. In addition, reviewing other people's patches helps you > +* write better patches and experience the code review process from the other side > +* and build more influence within the community over time > + > +Thus, we recommend strongly that **patch authors** read the watch the recording or > +read the slides: > +* [Patch Review for Non-Maintainers slides](https://www.slideshare.net/xen_com_mgr/xpdds19-keynote-patch-review-for-nonmaintainers-george-dunlap-citrix-systems-uk-ltd) > +* [Patch Review for Non-Maintainers recording - 20"](https://www.youtube.com/watch?v=ehZvBmrLRwg) > -- > 2.13.0 > --8323329-168241973-1574899840=:27669 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWFwaSBt YWlsaW5nIGxpc3QKWGVuLWFwaUBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhl bnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWFwaQo= --8323329-168241973-1574899840=:27669-- From xen-api-bounces@lists.xenproject.org Thu Nov 28 00:56:10 2019 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Nov 2019 00:56:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ia86K-0000VC-Qu; Thu, 28 Nov 2019 00:56:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ia86J-0000V3-P7 for xen-api@lists.xenproject.org; Thu, 28 Nov 2019 00:56:07 +0000 X-Inumbo-ID: d8d84f38-1179-11ea-83b8-bc764e2007e4 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d8d84f38-1179-11ea-83b8-bc764e2007e4; Thu, 28 Nov 2019 00:56:02 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DFE6F2158A; Thu, 28 Nov 2019 00:56:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574902561; bh=Bpiyg5V6eOQvT7ggDjtfQ5yuPUTc9IVhVjJBUQaER7U=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=EmHEIYNcYPd3Iv5FUQIJaYjD1dLepZmN4pOpSJNObEmwzd3A1X7nNVubKVp7rp871 G5iDESCEMqk48F+97bulaWVqr6sv3/NEiJN6YQ53ow13ApleQmPiJpuXxmYsM5IeGo xoXLxPIQQWtrHAeFgbm37gxiS0eT6xPOMslh5Udc= Date: Wed, 27 Nov 2019 16:56:00 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Lars Kurth In-Reply-To: <2e4b36afaa73277d246d7e84037db1532a136ec7.1569525222.git.lars.kurth@citrix.com> Message-ID: References: <2e4b36afaa73277d246d7e84037db1532a136ec7.1569525222.git.lars.kurth@citrix.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Subject: Re: [Xen-API] [PATCH v2 6/6] Added Resolving Disagreement X-BeenThere: xen-api@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: User and development list for XCP and XAPI List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Lars Kurth , xen-api@lists.xenproject.org, minios-devel@lists.xenproject.org, committers@xenproject.org, mirageos-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, win-pv-devel@lists.xenproject.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-api-bounces@lists.xenproject.org Sender: "Xen-api" T24gVGh1LCAyNiBTZXAgMjAxOSwgTGFycyBLdXJ0aCB3cm90ZToKPiBGcm9tOiBMYXJzIEt1cnRo IDxsYXJzLmt1cnRoQGNpdHJpeC5jb20+Cj4gCj4gVGhpcyBndWlkZSBwcm92aWRlcyBCZXN0IFBy YWN0aWNlIG9uIGlkZW50aWZ5aW5nIGFuZCByZXNvbHZpbmcKPiBjb21tb24gY2xhc3NlcyBvZiBk aXNhZ3JlZW1lbnQKPiAKPiBTaWduZWQtb2ZmLWJ5OiBMYXJzIEt1cnRoIDxsYXJzLmt1cnRoQGNp dHJpeC5jb20+Cj4gLS0KPiBDYzogbWluaW9zLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCj4g Q2M6IHhlbi1hcGlAbGlzdHMueGVucHJvamVjdC5vcmcKPiBDYzogd2luLXB2LWRldmVsQGxpc3Rz LnhlbnByb2plY3Qub3JnCj4gQ2M6IG1pcmFnZW9zLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3Jn Cj4gQ2M6IGNvbW1pdHRlcnNAeGVucHJvamVjdC5vcmcKPiAtLS0KPiAgcmVzb2x2aW5nLWRpc2Fn cmVlbWVudC5tZCB8IDE0NiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCAxNDYgaW5zZXJ0aW9ucygrKQo+ICBjcmVhdGUgbW9k ZSAxMDA2NDQgcmVzb2x2aW5nLWRpc2FncmVlbWVudC5tZAo+IAo+IGRpZmYgLS1naXQgYS9yZXNv bHZpbmctZGlzYWdyZWVtZW50Lm1kIGIvcmVzb2x2aW5nLWRpc2FncmVlbWVudC5tZAo+IG5ldyBm aWxlIG1vZGUgMTAwNjQ0Cj4gaW5kZXggMDAwMDAwMC4uMTlhZWRiZQo+IC0tLSAvZGV2L251bGwK PiArKysgYi9yZXNvbHZpbmctZGlzYWdyZWVtZW50Lm1kCj4gQEAgLTAsMCArMSwxNDYgQEAKPiAr IyBSZXNvbHZpbmcgRGlzYWdyZWVtZW50Cj4gKwo+ICtUaGlzIGd1aWRlIHByb3ZpZGVzIEJlc3Qg UHJhY3RpY2Ugb24gcmVzb2x2aW5nIGRpc2FncmVlbWVudCwgc3VjaCBhcwo+ICsqIEdyYWNlZnVs bHkgYWNjZXB0IGNvbnN0cnVjdGl2ZSBjcml0aWNpc20KPiArKiBGb2N1cyBvbiB3aGF0IGlzIGJl c3QgZm9yIHRoZSBjb21tdW5pdHkKPiArKiBSZXNvbHZlIGRpZmZlcmVuY2VzIGluIG9waW5pb24g ZWZmZWN0aXZlbHkKPiArCj4gKyMjIFRoZW9yeTogUGF1bCBHcmFoYW0ncyBoaWVyYXJjaHkgb2Yg ZGlzYWdyZWVtZW50Cj4gK1BhdWwgR3JhaGFtIHByb3Bvc2VkIGEgKipkaXNhZ3JlZW1lbnQgaGll cmFyY2h5KiogaW4gYSAyMDA4IGVzc2F5IAo+ICsqKltIb3cgdG8gRGlzYWdyZWVdKGh0dHA6Ly93 d3cucGF1bGdyYWhhbS5jb20vZGlzYWdyZWUuaHRtbCkqKiwgcHV0dGluZyB0eXBlcyBvZgo+ICth cmd1bWVudHMgaW50byBhIHNldmVuLXBvaW50IGhpZXJhcmNoeSBhbmQgb2JzZXJ2aW5nIHRoYXQg Km1vdmluZyB1cCB0aGUKPiArZGlzYWdyZWVtZW50IGhpZXJhcmNoeSBtYWtlcyBwZW9wbGUgbGVz cyBtZWFuLCBhbmQgd2lsbCBtYWtlIG1vc3Qgb2YgdGhlbSBoYXBwaWVyKi4KPiArR3JhaGFtIGFs c28gc3VnZ2VzdGVkIHRoYXQgdGhlIGhpZXJhcmNoeSBjYW4gYmUgdGhvdWdodCBvZiBhcyBhIHB5 cmFtaWQsIGFzIHRoZSAKPiAraGlnaGVzdCBmb3JtcyBvZiBkaXNhZ3JlZW1lbnQgYXJlIHJhcmVy Lgo+ICsKPiArfCAhW0dyYWhhbSdzIEhpZXJhcmNoeSBvZiBEaXNhZ3JlZW1lbl0oaHR0cHM6Ly91 cGxvYWQud2lraW1lZGlhLm9yZy93aWtpcGVkaWEvY29tbW9ucy9hL2EzL0dyYWhhbSUyN3NfSGll cmFyY2h5X29mX0Rpc2FncmVlbWVudC1lbi5zdmcpIHwKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBeIERpc2FncmVlbWVudAoKVGhpcyBpcyBhIE5JVCBidXQgaW4gYSBmZXcgcGxhY2VzIGlu IHRoaXMgc2VyaWVzIHlvdSBnbyBvdmVyIHRoZQpvcmlnaW5hbCBsaW5lIGxlbmd0aC4KCgo+ICt8 ICpBIHJlcHJlc2VudGF0aW9uIG9mIEdyYWhhbSdzIGhpZXJhcmNoeSBvZiBkaXNhZ3JlZW1lbnQg ZnJvbSBbTG91ZGFjcmlzXShodHRwOi8vd3d3LmNyZWF0ZWRlYmF0ZS5jb20vdXNlci92aWV3cHJv ZmlsZS9Mb3VkYWNyaXMpIG1vZGlmaWVkIGJ5IFtSb2NrZXQwMDBdKGh0dHBzOi8vZW4ud2lraXBl ZGlhLm9yZy93aWtpL1VzZXI6Um9ja2V0MDAwKSogfAo+ICsKPiArSW4gdGhlIGNvbnRleHQgb2Yg dGhlIFhlbiBQcm9qZWN0IHdlIHN0cml2ZSB0byAqKm9ubHkgdXNlIHRoZSB0b3AgaGFsZioqIG9m IHRoZSBoaWVyYXJjaHkuCj4gKyoqTmFtZS1jYWxsaW5nKiogYW5kICoqQWQgaG9taW5lbSoqIGFy Z3VtZW50cyBhcmUgbm90IGFjY2VwdGFibGUgd2l0aGluIHRoZSBYZW4KPiArUHJvamVjdC4KPiAr Cj4gKyMjIElzc3VlOiBTY29wZSBjcmVlcAo+ICsKPiArT25lIHRoaW5nIHdoaWNoIG9jY2FzaW9u YWxseSBoYXBwZW5zIGR1cmluZyBjb2RlIHJldmlldyBpcyB0aGF0IGEgY29kZSByZXZpZXdlcgo+ ICthc2tzIG9yIGFwcGVhcnMgdG8gYXNrIHRoZSBhdXRob3Igb2YgcGF0Y2ggdG8gaW1wbGVtZW50 IGFkZGl0aW9uYWwgZnVuY3Rpb25hbGl0eS4KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgXiBhIHBhdGNoICAgICAgICAgICAgICAgICAgICAgIF4gZnVuY3Rpb25hbGl0aWVz IAoKCj4gK1RoaXMgY291bGQgdGFrZSBmb3IgZXhhbXBsZSB0aGUgZm9ybSBvZgo+ICs+IERvIHlv dSB0aGluayBpdCB3b3VsZCBiZSB1c2VmdWwgZm9yIHRoZSBjb2RlIHRvIGRvIFhYWD8gCj4gKz4g SSBjYW4gaW1hZ2luZSBhIHVzZXIgd2FudGluZyB0byBkbyBZWVkgKGFuZCBYWFggd291bGQgZW5h YmxlIHRoaXMpCj4gKwo+ICtUaGF0IHBvdGVudGlhbGx5IGFkZHMgYWRkaXRpb25hbCB3b3JrIGZv ciB0aGUgY29kZSBhdXRob3IsIHdoaWNoIHRoZXkgbWF5IG5vdCBoYXZlCj4gK3RoZSB0aW1lIHRv IHBlcmZvcm0uIEl0IGlzIGdvb2QgcHJhY3RpY2UgZm9yIGF1dGhvcnMgdG8gY29uc2lkZXIgc3Vj aCBhIHJlcXVlc3QgaW4gdGVybXMgb2YKPiArKiBVc2VmdWxuZXNzIHRvIHRoZSB1c2VyCj4gKyog Q29kZSBjaHVybiwgY29tcGxleGl0eSBvciBpbXBhY3Qgb24gb3RoZXIgc3lzdGVtIHByb3BlcnRp ZXMKPiArKiBFeHRyYSB0aW1lIHRvIGltcGxlbWVudCBhbmQgcmVwb3J0IGJhY2sgdG8gdGhlIHJl dmlld2VyCj4gKwo+ICtJZiB5b3UgYmVsaWV2ZSB0aGF0IHRoZSBpbXBhY3QvY29zdCBpcyB0b28g aGlnaCwgcmVwb3J0IGJhY2sgdG8gdGhlIHJldmlld2VyLiBUbyByZXNvbHZlCj4gK3RoaXMsIGl0 IGlzIGFkdmlzYWJsZSB0bwo+ICsqIFJlcG9ydCB5b3VyIGZpbmRpbmdzCj4gKyogQW5kIHRoZW4g Y2hlY2sgd2hldGhlciB0aGlzIHdhcyBtZXJlbHkgYW4gaW50ZXJlc3Rpbmcgc3VnZ2VzdGlvbiwg b3Igc29tZXRoaW5nIHRoZQo+ICtyZXZpZXdlciBmZWVscyBtb3JlIHN0cm9uZ2x5IGFib3V0Cj4g Kwo+ICtJbiB0aGUgbGF0dGVyIGNhc2UsIHRoZXJlIGFyZSB0eXBpY2FsbHkgc2V2ZXJhbCBjb21t b24gb3V0Y29tZXMKPiArKiBUaGUgKiphdXRob3IgYW5kIHJldmlld2VyIGFncmVlKiogdGhhdCB0 aGUgc3VnZ2VzdGlvbiBzaG91bGQgYmUgaW1wbGVtZW50ZWQKPiArKiBUaGUgKiphdXRob3IgYW5k IHJldmlld2VyIGFncmVlKiogdGhhdCBpdCBtYXkgbWFrZSBzZW5zZSB0byBkZWZlciBpbXBsZW1l bnRhdGlvbgo+ICsqIFRoZSAqKmF1dGhvciBhbmQgcmV2aWV3ZXIgYWdyZWUqKiB0aGF0IGl0IG1h a2VzIG5vIHNlbnNlIHRvIGltcGxlbWVudCB0aGUgc3VnZ2VzdGlvbgo+ICsKPiArVGhlIGF1dGhv ciBvZiBhIHBhdGNoIHdvdWxkIHR5cGljYWxseSBzdWdnZXN0IHRoZWlyIHByZWZlcnJlZCBvdXRj b21lLCBmb3IgZXhhbXBsZQo+ICs+IEkgYW0gbm90IHN1cmUgaXQgaXMgd29ydGggdG8gaW1wbGVt ZW50IFhYWAo+ICs+IERvIHlvdSB0aGluayB0aGlzIGNvdWxkIGJlIGRvbmUgYXMgYSBzZXBhcmF0 ZSBwYXRjaCBpbiBmdXR1cmU/Cj4gKwo+ICtJbiBjYXNlcywgd2hlcmUgbm8gYWdyZWVtZW50IGNh biBiZSBmb3VuZCwgdGhlIGJlc3QgYXBwcm9hY2ggd291bGQgYmUgdG8gZ2V0IGFuCj4gK2luZGVw ZW5kZW50IG9waW5pb24gZnJvbSBhbm90aGVyIG1haW50YWluZXIgb3IgdGhlIHByb2plY3QncyBs ZWFkZXJzaGlwIHRlYW0uCgpJIHRoaW5rIHdlIHNob3VsZCBtZW50aW9uIHNvbWV3aGVyZSBoZXJl IHRoYXQgaXQgaXMgcmVjb21tZW5kZWQgZm9yCnJldmlld2VycyB0byBiZSBleHBsaWNpdCBhYm91 dCB3aGV0aGVyIGEgcmVxdWVzdCBpcyBvcHRpb25hbCBvciB3aGV0aGVyCml0IGlzIGEgcmVxdWly ZW1lbnQuCgpGb3IgaW5zdGFuY2U6ICJJIHRoaW5rIGl0IHdvdWxkIGJlIGdvb2QgaWYgWCBhbHNv IGRpZCBZIiBkb2Vzbid0IHNheSBpZgppdCBpcyBvcHRpb25hbCAoZnV0dXJlIHdvcmspIG9yIGl0 IGlzIGFjdHVhbGx5IHJlcXVpcmVkIGFzIHBhcnQgb2YgdGhpcwpzZXJpZXMuIE1vcmUgZXhwbGlj aXQgd29yZCBjaG9pY2VzIGFyZSBwcmVmZXJhYmxlLCBzdWNoIGFzOgoKIkkgdGhpbmsgaXQgd291 bGQgYmUgZ29vZCBpZiBYIGFsc28gZGlkIFksIG5vdCBhIHJlcXVpcmVtZW50IGJ1dCBnb29kIHRv CmhhdmUuIgoKIkkgdGhpbmsgaXQgd291bGQgYmUgZ29vZCBpZiBYIGFsc28gZGlkIFkgYW5kIGl0 IHNob3VsZCBiZSBwYXJ0IG9mIHRoaXMKc2VyaWVzLiIKCkl0IGhlbHBzIG1ha2UgdGhlIGNvbW11 bmljYXRpb24gd2l0aCB0aGUgYXV0aG9yIG1vcmUgZWZmZWN0aXZlLAplc3BlY2lhbGx5IGluIHRo aXMga2luZCBvZiBzaXR1YXRpb25zLgoKCj4gKyMjIElzc3VlOiBbQmlrZXNoZWRkaW5nXShodHRw czovL2VuLndpa3Rpb25hcnkub3JnL3dpa2kvYmlrZXNoZWRkaW5nKQo+ICsKPiArT2NjYXNpb25h bGx5IGRpc2N1c3Npb25zIGFib3V0IHVuaW1wb3J0YW50IGJ1dCBlYXN5LXRvLWdyYXNwIGlzc3Vl cyBjYW4gbGVhZCB0bwo+ICtwcm9sb25nZWQgYW5kIHVucHJvZHVjdGl2ZSBkaXNjdXNzaW9uLiBU aGUgYmVzdCB3YXkgdG8gYXBwcm9hY2ggdGhpcyBpcyB0bwogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBeIGRpc2N1c3Npb25zCgoKPiArdHJ5IGFuZCAqKmFudGljaXBhdGUqKiBiaWtlc2hl ZGRpbmcgYW5kIGhpZ2hsaWdodCBpdCBhcyBzdWNoIHVwZnJvbnQuIEhvd2V2ZXIsIHRoZQo+ICtm b3JtYXQgb2YgYSBjb2RlIHJldmlldyBkb2VzIG5vdCBhbHdheXMgbGVuZCBpdHNlbGYgd2VsbCB0 byB0aGlzIGFwcHJvYWNoLCBleGNlcHQKPiArZm9yIGhpZ2hsaWdodGluZyBpdCBpbiB0aGUgY292 ZXIgbGV0dGVyIG9mIGEgcGF0Y2ggc2VyaWVzLgo+ICsKPiArSG93ZXZlciwgdHlwaWNhbGx5IEJp a2VzaGVkZGluZyBpc3N1ZXMgYXJlIGZhaXJseSBlYXN5IHRvIHJlY29nbml6ZSBpbiBhIGNvZGUg cmV2aWV3LAo+ICthcyB5b3Ugd2lsbCB2ZXJ5IHF1aWNrbHkgZ2V0IGRpZmZlcmVudCByZXZpZXdl cnMgcHJvdmlkaW5nIGRpZmZlcmluZyBvcGluaW9ucy4gSW4gdGhpcyBjYXNlCj4gK2l0IGlzIGJl c3QgZm9yIHRoZSBhdXRob3Igb3IgYSByZXZpZXdlciB0byBjYWxsIG91dCB0aGUgcG90ZW50aWFs IGJpa2VzaGVkZGluZyBpc3N1ZSB1c2luZwo+ICtzb21ldGhpbmcgbGlrZQo+ICsKPiArPiBMb29r cyB3ZSBoYXZlIGEgYmlrZXNoZWRkaW5nIGlzc3VlIGhlcmUKPiArPiBJIHRoaW5rIHdlIHNob3Vs ZCBjYWxsIGEgcXVpY2sgdm90ZSB0byBzZXR0bGUgdGhlIGlzc3VlCj4gKwo+ICtPdXIgZ292ZXJu YW5jZSBwcm92aWRlcyB0aGUgbWVjaGFuaXNtcyBvZiBbaW5mb3JtYWwgdm90ZXNdKGh0dHBzOi8v eGVucHJvamVjdC5vcmcvZGV2ZWxvcGVycy9nb3Zlcm5hbmNlLyNpbmZvcm1hbC12b3Rlcy1vci1z dXJ2ZXlzKSBvcgo+ICtbbGF6eSB2b3RpbmddKGh0dHBzOi8veGVucHJvamVjdC5vcmcvZGV2ZWxv cGVycy9nb3Zlcm5hbmNlLyNsYXp5Y29uc2Vuc3VzKSB3aGljaCBsZW5kCj4gK3RoZW1zZWx2ZXMg d2VsbCB0byByZXNvbHZlIHN1Y2ggaXNzdWVzLgo+ICsKPiArIyMgSXNzdWU6IFNtYWxsIGZ1bmN0 aW9uYWwgaXNzdWVzCj4gKwo+ICtUaGUgbW9zdCBjb21tb24gYXJlYSBvZiBkaXNhZ3JlZW1lbnRz IHdoaWNoIGhhcHBlbiBpbiBjb2RlIHJldmlld3MsIGFyZSBkaWZmZXJpbmcKPiArb3BpbmlvbnMg b24gd2hldGhlciBzbWFsbCBmdW5jdGlvbmFsIGlzc3VlcyBpbiBhIHBhdGNoIHNlcmllcyBoYXZl IHRvIGJlIHJlc29sdmVkIG9yCj4gK25vdCBiZWZvcmUgdGhlIGNvZGUgaXMgcmVhZHkgdG8gYmUg c3VibWl0dGVkLiBTdWNoIGRpc2FncmVlbWVudHMgYXJlIHR5cGljYWxseSBjYXVzZWQKPiArYnkg ZGlmZmVyZW50IGV4cGVjdGF0aW9ucyByZWxhdGVkIHRvIHRoZSBsZXZlbCBvZiBwZXJmZWN0aW9u IGEgcGF0Y2ggc2VyaWVzIG5lZWRzIHRvIGZ1bGZpbAo+ICtiZWZvcmUgaXQgY2FuIGJlIGNvbnNp ZGVyZWQgcmVhZHkgdG8gYmUgY29tbWl0dGVkLgo+ICsKPiArVG8gZXhwbGFpbiB0aGlzIGJldHRl ciwgSSBhbSBnb2luZyB0byB1c2UgdGhlIGFuYWxvZ3kgb2Ygc29tZSBidWlsZGluZyB3b3JrIHRo YXQgaGFzCj4gK2JlZW4gcGVyZm9ybWVkIGF0IHlvdXIgaG91c2UuIExldCdzIHNheSB0aGF0IHlv dSBoYXZlIGEgbmV3IGJhdGhyb29tIGluc3RhbGxlZC4KPiArQmVmb3JlIHBheWluZyB5b3VyIGJ1 aWxkZXIgdGhlIGxhc3QgaW5zdGFsbWVudCwgeW91IHBlcmZvcm0gYW4gaW5zcGVjdGlvbiBhbmQg eW91IGZpbmQKPiAraXNzdWVzIHN1Y2ggYXMKPiArKiBUaGUgc2VhbHMgYXJvdW5kIHRoZSBiYXRo dHViIGFyZSBub3QgcGVyZmVjdGx5IGV2ZW50CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBeIGV2ZW4KCj4gKyogV2hlbiB5b3Ugb3BlbiB0aGUgdGFw LCB0aGUgcGx1bWJpbmcgaW5pdGlhbGx5IG1ha2VzIHNvbWUgbG91ZCBub2lzZQo+ICsqIFRoZSBz aG93ZXIgbWl4ZXIgaGFzIGJlZW4gaW5zdGFsbGVkIHRoZSB3cm9uZyB3YXkgYXJvdW5kCj4gKwo+ ICtJbiBhbGwgdGhlc2UgY2FzZXMsIHRoZSBiYXRocm9vbSBpcyBwZXJmZWN0bHkgZnVuY3Rpb25h bCwgYnV0IG5vdCBwZXJmZWN0LiBBdCB0aGlzIHBvaW50Cj4gK3lvdSBoYXZlIHRoZSBjaG9pY2Ug dG8gdHJ5IGFuZCBnZXQgYWxsIHRoZSBpc3N1ZXMgYWRkcmVzc2VkLCB3aGljaCBpbiB0aGUgZXhh bXBsZSBvZgo+ICt0aGUgc2hvd2VyIG1peGVyIG1heSByZXF1aXJlIHNpZ25pZmljYW50IHJlLXdv cmsgYW5kIHBvdGVudGlhbGx5IHB1c2gtYmFjayBmcm9tIHlvdXIKPiArYnVpbGRlci4gWW91IG1h eSBoYXZlIHRvIHJlZmVyIHRvIHRoZSBpbml0aWFsIHN0YXRlbWVudCBvZiB3b3JrLCBidXQgaXQg dHVybnMgb3V0IGl0IGRvZXMKPiArbm90IGNvbnRhaW4gc3VmZmljaWVudCBpbmZvcm1hdGlvbiB0 byBhc2NlcnRhaW4gd2hldGhlciB5b3VyIGJ1aWxkZXIgaGFkIGNvbW1pdHRlZCB0bwo+ICt0aGUg bGV2ZWwgb2YgcXVhbGl0eSB5b3Ugd2VyZSBleHBlY3RpbmcuCj4gKwo+ICtTaW1pbGFyIHNpdHVh dGlvbnMgaGFwcGVuIGluIGNvZGUgcmV2aWV3cyB2ZXJ5IGZyZXF1ZW50bHkgYW5kIGNhbiBsZWFk IHRvIGEgbG9uZwo+ICtkaXNjdXNzaW9uIGJlZm9yZSBpdCBjYW4gYmUgcmVzb2x2ZWQuIFRoZSBt b3N0IGltcG9ydGFudCB0aGluZyBpcyB0byAqKmlkZW50aWZ5KioKPiArYSBkaXNhZ3JlZW1lbnQg YXMgc3VjaCBlYXJseSBhbmQgdGhlbiBjYWxsIGl0IG91dC4gVGlwcyBvbiBob3cgdG8gZG8gdGhp cywgY2FuIGJlIGZvdW5kCj4gK1toZXJlXShjb21tdW5pY2F0aW9uLXByYWN0aWNlLm1kI01pc3Vu ZGVyc3RhbmRpbmdzKS4KPiArCj4gK0F0IHRoaXMgcG9pbnQsIHlvdSB3aWxsIHVuZGVyc3RhbmQg d2h5IHlvdSBoYXZlIHRoZSBkaXNhZ3JlZW1lbnQsIGJ1dCBub3QgbmVjZXNzYXJpbHkKPiArYWdy ZWVtZW50IG9uIGhvdyB0byBtb3ZlIGZvcndhcmQuIEFuIGVhc3kgZml4IHdvdWxkIGJlIHRvIGFn cmVlIHRvIHN1Ym1pdCB0aGUgY2hhbmdlCj4gK2FzIGl0IGlzIGFuZCBmaXggaXQgaW4gZnV0dXJl LiBJbiBhIGNvcnBvcmF0ZSBzb2Z0d2FyZSBlbmdpbmVlcmluZyBlbnZpcm9ubWVudCB0aGlzIGlz IHRoZQo+ICttb3N0IGxpa2VseSBvdXRjb21lLCBidXQgaW4gb3BlbiBzb3VyY2UgY29tbXVuaXRp ZXMgYWRkaXRpb25hbCBjb25jZXJucyBoYXZlIHRvIGJlCj4gK2NvbnNpZGVyZWQuCj4gKyogQ29k ZSByZXZpZXdlcnMgZnJlcXVlbnRseSBoYXZlIGJlZW4gaW4gdGhpcyBzaXR1YXRpb24gYmVmb3Jl IHdpdGggdGhlIG1vc3QgY29tbW9uCj4gKyAgb3V0Y29tZSB0aGF0IHRoZSBpc3N1ZSBpcyB0aGVu IG5ldmVyIGZpeGVkLiBCeSBhY2NlcHRpbmcgdGhlIGNoYW5nZSwgdGhlIHJldmlld2Vycwo+ICsg IGhhdmUgbm8gbGV2ZXJhZ2UgdG8gZml4IHRoZSBpc3N1ZSBhbmQgbWF5IGhhdmUgdG8gc3BlbmQg ZWZmb3J0IGZpeGluZyB0aGUgaXNzdWUKPiArICB0aGVtc2VsdmVzIGluIGZ1dHVyZSBhcyBpdCBt YXkgaW1wYWN0IHRoZSBwcm9kdWN0IHRoZXkgYnVpbHQgb24gdG9wIG9mIHRoZSBjb2RlLgo+ICsq IENvbnZlcnNlbHksIGEgcmV2aWV3ZXIgbWF5IGJlIGFza2luZyB0aGUgYXV0aG9yIHRvIG1ha2Ug dG9vIG1hbnkgY2hhbmdlcyBvZiB0aGlzCj4gKyAgdHlwZSB3aGljaCB1bHRpbWF0ZWx5IG1heSBs ZWFkIHRoZSBhdXRob3IgdG8gbm90IGNvbnRyaWJ1dGUgdG8gdGhlIHByb2plY3QgYWdhaW4uCj4g KyogQW4gYXV0aG9yLCB3aGljaCBjb25zaXN0ZW50bHkgZG9lcyBub3QgYWRkcmVzcyAqKmFueSoq IG9mIHRoZXNlIGlzc3VlcyBtYXkgZW5kIHVwCj4gKyAgZ2V0dGluZyBhIGJhZCByZXB1dGF0aW9u IGFuZCBtYXkgZmluZCBmdXR1cmUgY29kZSByZXZpZXdzIG1vcmUgZGlmZmljdWx0Lgo+ICsqIEFu IGF1dGhvciB3aGljaCBhbHdheXMgYWRkcmVzc2VzICoqYWxsKiogb2YgdGhlc2UgaXNzdWVzIG1h eSBlbmQgdXAgZ2V0dGluZyBpbnRvCj4gKyAgZGlmZmljdWx0aWVzIHdpdGggdGhlaXIgZW1wbG95 ZXIsIGFzIHRoZXkgYXJlIHRvbyBzbG93IGdldHRpbmcgY29kZSB1cHN0cmVhbWVkLgo+ICsKPiAr Tm9uZSBvZiB0aGVzZSBvdXRjb21lcyBhcmUgZ29vZCwgc28gdWx0aW1hdGVseSBhIGJhbGFuY2Ug aGFzIGJlZW4gZm91bmQuIEF0IHRoZSBlbmQKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXiB5b3UgbWVhbiAiaGFzIHRvIGJlIGZvdW5k PyIKCgo+ICtvZiB0aGUgZGF5LCB0aGUgc29sdXRpb24gc2hvdWxkIGZvY3VzIG9uIHdoYXQgaXMg YmVzdCBmb3IgdGhlIGNvbW11bml0eSwgd2hpY2ggbWF5Cj4gK21lYW4gYXNraW5nIGZvciBhbiBp bmRlcGVuZGVudCBvcGluaW9uIGFzIG91dGxpbmVkIGluIHRoZSBuZXh0IHNlY3Rpb24uCgpJIHRo aW5rIHRoZXJlIGlzIHNvbWV0aGluZyBlbHNlIHdlIHNob3VsZCBzYXkgb24gdGhpcyB0b3BpYy4g VGhlcmUgaXMgYQpjYXRlZ29yeSBvZiB0aGluZ3Mgd2hpY2ggY291bGQgYmUgZG9uZSBpbiBtdWx0 aXBsZSB3YXlzIGFuZCBpdCBpcyBub3QKb3ZlcnRseSBvYnZpb3VzIHdoaWNoIG9uZSBpcyBiZXN0 LiBJdCBpcyBkb25lIHRvIHRoZSBtYWludGFpbmVyIGFuZCB0aGUKYXV0aG9yIHBlcnNvbmFsIHN0 eWxlcy4gSXQgaXMgZWFzeSB0byBkaXNhZ3JlZSBvbiB0aGF0LgoKSSB0aGluayBhIGdvb2QgcmVj b21tZW5kYXRpb24gd291bGQgYmUgZm9yIHRoZSBjb250cmlidXRvciB0byB0cnkgdG8KZm9sbG93 IHRoZSBtYWludGFpbmVycyByZXF1ZXN0cywgZXZlbiBpZiB0aGV5IGNvdWxkIGJlIGNvbnNpZGVy ZWQKInN0eWxlIiwgdHJ1c3RpbmcgdGhlaXIgZXhwZXJpZW5jZSBvbiB0aGUgbWF0dGVyLiBBbmQg YSBnb29kCnJlY29tbWVuZGF0aW9uIGZvciB0aGUgbWFpbnRhaW5lciB3b3VsZCBiZSB0byB0cnkg dG8gbGV0IHRoZSBjb250cmlidXRvcgpoYXZlIGZyZWVkb20gb2YgaW1wbGVtZW50YXRpb24gY2hv aWNlIG9uIHRoaW5ncyB0aGF0IGRvbid0IG1ha2UgYQpzaWduaWZpY2FudCBkaWZmZXJlbmNlLgoK Cj4gKyMjIFJlc29sdXRpb246IEFza2luZyBmb3IgYW4gaW5kZXBlbmRlbnQgb3Bpbmlvbgo+ICsK PiArTW9zdCBkaXNhZ3JlZW1lbnRzIGNhbiBiZSBzZXR0bGVkIGJ5Cj4gKyogQXNraW5nIGFub3Ro ZXIgbWFpbnRhaW5lciBvciBjb21taXR0ZXIgdG8gcHJvdmlkZSBhbiBpbmRlcGVuZGVudCBvcGlu aW9uIG9uIHRoZQo+ICsgIHNwZWNpZmljIGlzc3VlIGluIHB1YmxpYyB0byBoZWxwIHJlc29sdmUg aXQKPiArKiBGYWlsaW5nIHRoaXMgYW4gaXNzdWUgY2FuIGJlIGVzY2FsYXRlZCB0byB0aGUgcHJv amVjdCBsZWFkZXJzaGlwIHRlYW0sIHdoaWNoIGlzCj4gKyAgZXhwZWN0ZWQgdG8gYWN0IGFzIHJl ZmVyZWUgYW5kIG1ha2UgYSBkZWNpc2lvbiBvbiBiZWhhbGYgb2YgdGhlIGNvbW11bml0eQo+ICsK PiArSWYgeW91IGZlZWwgdW5jb21mb3J0YWJsZSB3aXRoIHRoaXMgYXBwcm9hY2gsIHlvdSBtYXkg YWxzbyBjb250YWN0Cj4gK21lZGlhdGlvbkB4ZW5wcm9qZWN0Lm9yZyB0byBnZXQgYWR2aWNlLiBT ZWUgb3VyIFtDb21tdW5pY2F0aW9uIEd1aWRlXShjb21tdW5pY2F0aW9uLWd1aWRlLm1kKQo+ICtm b3IgbW9yZSBpbmZvcm1hdGlvbi4KPiArCj4gKyMjIERlY2lzaW9uIG1ha2luZyBhbmQgY29uZmxp Y3QgcmVzb2x1dGlvbiBpbiBvdXIgZ292ZXJuYW5jZQo+ICsKPiArT3VyIFtnb3Zlcm5hbmNlXSho dHRwczovL3hlbnByb2plY3Qub3JnL2RldmVsb3BlcnMvZ292ZXJuYW5jZS8jZGVjaXNpb25zKSBj b250YWlucwo+ICtzZXZlcmFsIHByb3ZlbiBtZWNoYW5pc21zIHRvIGhlbHAgd2l0aCBkZWNpc2lv biBtYWtpbmcgYW5kIGNvbmZsaWN0IHJlc29sdXRpb24uCj4gKwo+ICtTZWUKPiArKiBbRXhwcmVz c2luZyBhZ3JlZW1lbnQgYW5kIGRpc2FncmVlbWVudF0oaHR0cHM6Ly94ZW5wcm9qZWN0Lm9yZy9k ZXZlbG9wZXJzL2dvdmVybmFuY2UvI2V4cHJlc3NpbmdvcGluaW9uKQo+ICsqIFtMYXp5IGNvbnNl bnN1cyAvIExhenkgdm90aW5nXShodHRwczovL3hlbnByb2plY3Qub3JnL2RldmVsb3BlcnMvZ292 ZXJuYW5jZS8jbGF6eWNvbnNlbnN1cykKPiArKiBbSW5mb3JtYWwgdm90ZXMgb3Igc3VydmV5c10o aHR0cHM6Ly94ZW5wcm9qZWN0Lm9yZy9kZXZlbG9wZXJzL2dvdmVybmFuY2UvI2luZm9ybWFsLXZv dGVzLW9yLXN1cnZleXMpCj4gKyogW0xlYWRlcnNoaXAgdGVhbSBkZWNpc2lvbnNdKGh0dHBzOi8v eGVucHJvamVjdC5vcmcvZGV2ZWxvcGVycy9nb3Zlcm5hbmNlLyNsZWFkZXJzaGlwKQo+ICsqIFtD b25mbGljdCByZXNvbHV0aW9uXShodHRwczovL3hlbnByb2plY3Qub3JnL2RldmVsb3BlcnMvZ292 ZXJuYW5jZS8jY29uZmxpY3QpCj4gLS0gCj4gMi4xMy4wCj4gCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tYXBpIG1haWxpbmcgbGlzdApYZW4tYXBp QGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1h bi9saXN0aW5mby94ZW4tYXBpCg== From xen-api-bounces@lists.xenproject.org Thu Nov 28 00:58:00 2019 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Nov 2019 00:58:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ia888-0000qQ-5S; Thu, 28 Nov 2019 00:58:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ia887-0000qE-Je for xen-api@lists.xenproject.org; Thu, 28 Nov 2019 00:57:59 +0000 X-Inumbo-ID: 183b98ce-117a-11ea-9db0-bc764e2007e4 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 183b98ce-117a-11ea-9db0-bc764e2007e4; Thu, 28 Nov 2019 00:57:48 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3BB9B2158A; Thu, 28 Nov 2019 00:57:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574902667; bh=VocRQC81uijdlCIkQxZBQUXbCXlViahRm4+D/EdQkgs=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=g65YAILesA0yNGByW9W0D1IvzJyMiEy8+g1q9vMXAH8AUh/7bOdhLqThQdH7aJaLP i+PpRJ0+dDds/wMyCc7vFoNDvizvXfY6O+qsLFxC/UOnf9tRkWMjqJFmDEJjhXQJMr JrSbo1DYocM89IEEpA43ZKlOCbZpWU+lR09+RKOE= Date: Wed, 27 Nov 2019 16:57:46 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Lars Kurth In-Reply-To: <749f082bdb996ba7c7362847b22030882dc2903f.1569525222.git.lars.kurth@citrix.com> Message-ID: References: <749f082bdb996ba7c7362847b22030882dc2903f.1569525222.git.lars.kurth@citrix.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1207343631-1574899973=:27669" Content-ID: Subject: Re: [Xen-API] [PATCH v2 5/6] Add guide on Communication Best Practice X-BeenThere: xen-api@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: User and development list for XCP and XAPI List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Lars Kurth , xen-api@lists.xenproject.org, minios-devel@lists.xenproject.org, committers@xenproject.org, mirageos-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, win-pv-devel@lists.xenproject.org Errors-To: xen-api-bounces@lists.xenproject.org Sender: "Xen-api" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1207343631-1574899973=:27669 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Thu, 26 Sep 2019, Lars Kurth wrote: > From: Lars Kurth > > This guide covers the bulk on Best Practice related to code review > It primarily focusses on code review interactions > It also covers how to deal with Misunderstandings and Cultural > Differences > > Signed-off-by: Lars Kurth > --- > Cc: minios-devel@lists.xenproject.org > Cc: xen-api@lists.xenproject.org > Cc: win-pv-devel@lists.xenproject.org > Cc: mirageos-devel@lists.xenproject.org > Cc: committers@xenproject.org > --- > communication-practice.md | 410 ++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 410 insertions(+) > create mode 100644 communication-practice.md > > diff --git a/communication-practice.md b/communication-practice.md > new file mode 100644 > index 0000000..db9a5ef > --- /dev/null > +++ b/communication-practice.md > @@ -0,0 +1,410 @@ > +# Communication Best Practice > + > +This guide provides communication Best Practice that helps you in > +* Using welcoming and inclusive language > +* Keeping discussions technical and actionable > +* Being respectful of differing viewpoints and experiences > +* Being aware of your own and counterpart’s communication style and culture > +* Show empathy towards other community members > + > +## Code reviews for **reviewers** and **patch authors** > + > +Before embarking on a code review, it is important to remember that > +* A poorly executed code review can hurt the contributors feeling, even when a reviewer > + did not intend to do so. Feeling defensive is a normal reaction to a critique or feedback. > + A reviewer should be aware of how the pitch, tone, or sentiment of their comments > + could be interpreted by the contributor. The same applies to responses of an author > + to the reviewer. > +* When reviewing someone's code, you are ultimately looking for issues. A good code > + reviewer is able to mentally separate finding issues from articulating code review > + comments in a constructive and positive manner: depending on your personality this > + can be **difficult** and you may need to develop a technique that works for you. > +* As software engineers we like to be proud of the solutions we came up with. This can > + make it easy to take another people’s criticism personally. Always remember that it is > + the code that is being reviewed, not you as a person. > +* When you receive code review feedback, please be aware that we have reviewers > + from different backgrounds, communication styles and cultures. Although we all trying > + to create a productive, welcoming and agile environment, we do not always succeed. > + > +### Express appreciation > +As the nature of code review to find bugs and possible issues, it is very easy for > +reviewers to get into a mode of operation where the patch review ends up being a list > +of issues, not mentioning what is right and well done. This can lead to the code > +submitter interpreting your feedback in a negative way. > + > +The opening of a code review provides an opportunity to address this and also sets the > +tone for the rest of the code review. Starting **every** review on a positive note, helps > +set the tone for the rest of the review. > + > +For an initial patch, you can use phrases such as > +> Thanks for the patch > +> Thanks for doing this > + > +For further revisions within a review, phrases such as > +> Thank you for addressing the last set of changes > + > +If you believe the code was good, it is good practice to highlight this by using phrases > +such as > +> Looks good, just a few comments > +> The changes you have made since the last version look good > + > +If you think there were issues too many with the code to use one of the phrases, > +you can still start on a positive note, by for example saying > +> I think this is a good change > +> I think this is a good feature proposal > + > +It is also entirely fine to highlight specific changes as good. The best place to > +do this, is at top of a patch, as addressing code review comments typically requires ^ the top > +a contributor to go through the list of things to address and an in-lined positive > +comment is likely to break that workflow. > + > +You should also consider, that if you review a patch of an experienced > +contributor phrases such as *Thanks for the patch* could come across as > +patronizing, while using *Thanks for doing this* is less likely to be interpreted > +as such. > + > +Appreciation should also be expressed by patch authors when asking for clarifications > +to a review or responding to questions. A simple > +> Thank you for your feedback > +> Thank you for your reply > +> Thank you XXX! > + > +is normally sufficient. > + > +### Avoid opinion: stick to the facts > +The way how a reviewer expresses feedback, has a big impact on how the author > +perceives the feedback. Key to this is what we call **stick to the facts**. The same is > +true when a patch author is responding to a comment from a reviewer. > + > +One of our maintainers has been studying Mandarin for several years and has come > +across the most strongly-worded dictionary entry > +[he has ever seen](https://youtu.be/ehZvBmrLRwg?t=834). This example > +illustrates the problem of using opinion in code reviews vs. using facts extremely well. > + > +> 裹脚 (guo3 jiao3): foot-binding (a vile feudal practice which crippled women both > +> physically and spiritually) > + > +This is not something one is used to hearing from dictionary entries. Once you > +investigate the practice foot-binding, it is hard to disagree with the dictionart entry. > +However, the statement does not contain much information. If you read it without > +knowing what foot-binding is, it is hard to be convinced by this statement. The main > +take-away is that the author of the dictionary entry had strong opinions about this topic. > +It does not tell you, why you should have the same opinion. ^ remove , > + > +Compare this to the (Wikipedia entry)[https://en.wikipedia.org/wiki/Foot_binding] > + > +> Foot binding was the custom of applying tight binding to the feet of young girls to > +> modify the shape and size of their feet. ... foot binding was a painful practice and > +> significantly limited the mobility of women, resulting in lifelong disabilities for most of > +> its subjects. ... Binding usually started during the winter months since the feet were > +> more likely to be numb, and therefore the pain would not be as extreme. …The toes on > +> each foot were curled under, then pressed with great force downwards and squeezed > +> into the sole of the foot until the toes broke… > + > +Without going into the details of foot-binding, it is noticeable that none of what is written > +above uses opinion which could be interpreted as inflammatory language. It is a list of > +simple facts that are laid out in a way that make it obvious what the correct conclusion > +is. > + > +Because the Wikipedia entry is entirely fact based it is more powerful and persuasive > +then the dictionary entry. The same applies to code reviews. > + > +Making statements in code reviews such as > +> Your code is garbage > +> This idea is stupid > + > +besides being an opinion is rude and counter productive > +* It will make the patch author angry: instead of finding a solution to the problem the > + author will spend time and mental energy wrestling with their feelings > +* It does not contain any information > +* Facts are both more powerful and more persuasive > + > +Consider the following two pieces of feedback on a piece of code > +> This piece of code is confusing > +> It took me a long time to figure out what was going on here > + > +The first example expresses an opinion, whereas the second re-phrases the statement > +in terms of what you experienced, which is a fact. > + > +Other examples: > +> BAD: This is fragile > +> SOMEWHAT BETTER: This seems fragile to me > +> BEST: If X happens, Y will happen. > + > +A certain piece of code can be written in many different ways: this can lead to > +disagreements on the best architecture, design or coding pattern. As already pointed out > +in this section: avoid feedback that is opinion-based and thus does not add any value. > +Back your criticism (or idea on how to solve a problem) with a sensible rationale. > + > +### Review the code, not the person > +Without realizing it, it is easy to overlook the difference between insightful critique of > +code and personal criticism. Let's look at a theoretical function where there is an > +opportunity to return out of the function early. In this case, you could say > + > +> You should return from this function early, because of XXX > + > +On its own, there is nothing wrong with this statement. However, a code review is made > +up of multiple comments and using **You should** consistently can start to feel negative > +and can be mis-interpreted as a personal attack. Using something like avoids this issue: > + > +> Returning from this function early is better, because of XXX > + > +Without personal reference, a code review will communicate the problem, idea or issue > +without risking mis-interpretation. > + > +### Verbose vs. terse > +Due to the time it takes to review and compose code reviewer, reviewers often adopt a > +terse style. It is not unusual to see review comments such as > +> typo > +> s/resions/regions/ > +> coding style > +> coding style: brackets not needed > +etc. > + > +Terse code review style has its place and can be productive for both the reviewer and > +the author. However, overuse can come across as unfriendly, lacking empathy and > +can thus create a negative impression with the author of a patch. This is in particular > +true, when you do not know the author or the author is a newcomer. Terse > +communication styles can also be perceived as rude in some cultures. > + > +If you tend to use a terse commenting style and you do not know whether the author > +is OK with it, it is often a good idea to compensate for it in the code review opening > +(where you express appreciation) or when there is a need for verbose expression. > + > +It is also entirely fine to mention that you have a fairly terse communication style > +and ask whether the author is OK with it. In almost all cases, they will be: by asking > +you are showing empathy that helps counteract a negative impression. > + > +### Code Review Comments should be actionable > +Code review comments should be actionable: in other words, it needs to be clear > +what the author of the code needs to do to address the issue you identified. > + > +Statements such as > +> BAD: This is wrong > +> BAD: This does not work > +> BETTER, BUT NOT GOOD: This does not work, because of XXX > + > +do not normally provide the author of a patch with enough information to send out a > +new patch version. By doing this, you essentially force the patch author to **find** and > +**implement** an alternative, which then may also not be acceptable to you as the > +**reviewer** of the patch. > + > +A better way to approach this is to say > + > +> This does not work, because of XXX > +> You may want to investigate YYY and ZZZ as alternatives > + > +In some cases, it may not be clear whether YYY or ZZZ are the better solution. As a > +reviewer you should be as up-front and possible in such a case and say something like > + > +> I am not sure whether YYY and ZZZ are better, so you may want to outline your > +> thoughts about both solutions by e-mail first, such that we can decide what works > +> best > + > +### Identify the severity of an issue or disagreement > +By default, every comment which is made **ought to be addressed** by the author. > +However, often reviewers note issues, which would be nice if they were addressed, > +but are not mandatory. > + > +Typically, reviewers use terminology such as > +> This would be a nice-to-have > +> This is not a blocker > + > +Some maintainers use > +> NIT: XXX > + > +however, it is sometimes also used to indicate a minor issue that **must** be fixed. > > +During a code review, it can happen that reviewer and author disagree on how to move > +forward. The default position when it comes to disagreements is that **both parties > +want to argue their case**. However, frequently one or both parties do not feel that > +strongly about a specific issue. > + > +Within the Xen Project, we have [a way](https://xenproject.org/developers/governance/#expressingopinion) > +to highlight one's position on proposals, formal or informal votes using the following > +notation: > +> +2 : I am happy with this proposal, and I will argue for it > +> +1 : I am happy with this proposal, but will not argue for it > +> 0 : I have no opinion > +> -1 : I am not happy with this proposal, but will not argue against it > +> -2 : I am not happy with this proposal, and I will argue against it > + > +You can use a phrase such as > +> I am not happy with this suggestion, but will not argue against it > + > +to make clear where you stand, while recording your position. Conversely, a reviewer > +may do something similar > +> I am not happy with XYZ, but will not argue against it [anymore] > +> What we have now is good enough, but could be better It is not just about the willingness of somebody to argue a point, which is the important thing when voting. During code reviews it is perfectly fine to make suggestions which are just optional for multiple reasons, including that they might be too taxing for the contributor. So, I think we should add that it would be best to use words that make it clear whether something is optional or whether it is required, see my reply to patch #6, I wrote an example there. > +### Authors: responding to review comments > +Typically patch authors are expected to **address all** review comments in the next > +version of a patch or patch series. In a smooth-running code review where you do not > +have further questions it is not at all necessary to acknowledge the changes you are > +going to make: > +* Simply send the next version with the changes addressed and record it in the > +change-log > + > +When there is discussion, the normal practice is to remove the portion of the e-mail > +thread where there is agreement. Otherwise, the thread can become exceptionally > +long. > + > +In cases where there was discussion and maybe disagreement, it does however make > +sense to close the discussion by saying something like > + > +> ACK > +> Seems we are agreed, I am going to do this > + > +Other situations when you may want to do this are cases where the reviewer made > +optional suggestions, to make clear whether the suggestion will be followed or > +not. > + > +### Avoid uncommon words: not everyone is a native English speaker > +Avoid uncommon words both when reviewing code or responding to a review. Not > +everyone is a native English speaker. The use of such words can come across badly and > +can lead to misunderstandings. > + > +### Prioritize significant flaws > +If a patch or patch series has significant flaws, such as > +* It is built on wrong assumptions > +* There are issues with the architecture or the design > + > +it does not make sense to do a detailed code review. In such cases, it is best to > +focus on the major issues first and deal with style and minor issues in a subsequent > +review. This reduces the workload on both the reviewer and patch author. However, > +reviewers should make clear that they have omitted detailed review comments and > +that these will come later. Maybe we want to expand on this a bit. Not all series are based on flawed assumptions, but all series have different class of changes that are required for acceptance, from major code modifications to minor code style fixes. I think we should say that it is good practice to ask for any major changes early on, during the first or second iteration of the series. It would be best to avoid asking for major changes at v9 if possible. Something else which is missing in this document, and it is purely for reviewers, is to be careful doing reviews late in the cycle when another maintainer/reviewer has already provided feedback on the series multiple times previously. For instance, if reviewer R1 has been doing reviews from the first version of the series and contributor C has been addressing all comments, it would be best if reviewer R2 didn't come in providing detailed feedback months later at v5, unless their requests are actually strictly necessary (i.e. they spotted a bug). The main reason is that it is difficult not to let your own personal style (code style, the way to lay out the code) sip through review comments, and it can cause double-effort for the author if he/she already made changes according R1's personal style. However, in general, it would be best to limit "personal style" requests for changes anyway, see my comment to patch #6. > +### Welcome newcomers > +When reviewing the first few patches of a newcomer to the project, you may want > +spend additional time and effort in your code review. This contributes to a more > +**positive experience**, which ultimately helps create a positive working relationship in > +the long term. > + > +When someone does their first code submission, they will not be familiar with **all** > +conventions in the project. A good approach is to > +* Welcome the newcomer > +* Offer to help with specific questions, for example on IRC > +* Point to existing documentation: in particular if mistakes with the submission > + itself were made. In most situations, following the submission process makes > + the process more seamless for the contributor. So, you could say something like > + > +> Hi XXX. Welcome to the community and thank you for the patch > +> > +> I noticed that the submission you made seems to not follow our process. > +> Are you aware of this document at YYY? If you follow the instructions the > +> entire code submission process and dealing with review comments becomes > +> much easier. Feel free to find me on IRC if you need specific help. My IRC > +> handle is ZZZ > + > +### Review the code, then review the review > +As stated earlier it is often difficult to mentally separate finding issues from articulating > +code review comments in a constructive and positive manner. Even as an experienced > +code reviewer you can be in a bad mood, which can impact your communication style. > + > +A good trick to avoid this, is to start and complete the code review and then **not > +send it immediately**. You can then have a final go over the code review at some later > +point in time and review your comments from the other author's point of view. This > +minimizes the risk of being misunderstood. The same applies when replying to a code > +review: draft your reply and give it a final scan before pressing the send button. > + > +Generally, it is a good idea for code reviewers to do this regularly, purely from the > +viewpoint of self-improvement and self-awareness. > + > +## Common Communication Pitfalls > + > +This section contains common communication issues and provides suggestions on > +how to avoid them and resolve them. These are **general** issues which affect **all** > +online communication. As such, we can only try and do our best. > + > +### Misunderstandings > +When you meet face to face, you can read a person’s emotions. Even with a phone call, > +someone’s tone of voice can convey a lot of information. Using on-line communication > +channels you are flying blind, which often leads to misunderstandings. > +[Research](https://www.wired.com/2006/02/the-secret-cause-of-flame-wars/) shows > +that in up to 50% of email conversations, the tone of voice is misinterpreted. > + > +In code reviews and technical discussions in general we tend to see two things > +* The reviewer or author interprets an exchange as too critical, passive aggressive, or > +other: this usually comes down to different cultures and communication styles, which > +are covered in the next section > +* There is an actual misunderstanding of a subject under discussion > + > +In the latter case, the key to resolution is to **identify the misunderstanding** as quickly > +as possible and call it out and de-escalate rather than let the misunderstanding linger. > +This is inherently difficult and requires more care than normal communication. Typically > +you would start with > +* Showing appreciation > +* Highlighting the potential misunderstanding and verifying whether the other person > + also feels that maybe there was a misunderstanding > +* Proposing a way forward: for example, it may make sense to move the conversation > + from the mailing list to [IRC](https://xenproject.org/help/irc/) either in private or public, > + a community call or a private phone/video call. > + > +It is entirely acceptable to do this in a direct reply to your communication partner, rather > +than on a public e-mail list on or an otherwise public forum. > + > +A good approach is to use something like the following: > +> Hi XXX! Thank you for the insights you have given me in this code review > +> I feel that we are misunderstanding each other on the topic of YYY > +> Would you mind trying to resolve this on IRC. I am available at ZZZ > + > +Usually, technical misunderstandings come down two either > +1. Misinterpreting what the other person meant > +2. Different - usually unstated - assumptions on how something works or what is to be > +achieved > +3. Different - usually unstated - objectives and goals, which may be conflicting > +4. Real differences in opinion > + > +The goal of calling out a possible misunderstanding is to establish what caused the > +misunderstanding, such that all parties can move forward. Typically, 1 and 2 are easily > +resolved and will lead back to a constructive discussion. Whereas 3 and 4 may highlight > +an inherent disagreement, which may need to be resolved through techniques as > +outlined in [Resolving Disagreement] (resolving-disagreement.md). > + > +### Cultural differences and different communication styles > +The Xen Project is a global community with contributors from many different > +backgrounds. Typically, when we communicate with a person we know, we factor > +in past interactions. The less we know a person, the more we rely on cultural norms. > + > +However, different norms and value systems come into play when people from diverse > +cultural backgrounds interact. That can lead to misunderstandings, especially in > +sensitive situations such as conflict resolution, giving and receiving feedback, and > +consensus building. > + > +For example, giving direct feedback such as > +> [Please] replace XXX with YYY, as XXX does not do ZZZ > + > +is acceptable and normal in some cultures, whereas in cultures which value indirect > +feedback it would be considered rude. In the latter case, something like the following > +would be used > +> This looks very good to me, but I believe you should use YYY here, > +> because XXX would.... > + > +The key to working and communicating well with people from different cultural > +backgrounds is **self-awareness**, which can then be used to either > +* Adapt your own communication style depending on who you talk to > +* Or to find a middle-ground that covers most bases > + > +A number of different theories in the field of working effectively are currently popular, > +with the most well-known one being > +[Erin Meyer's Culture Map](https://en.wikipedia.org/wiki/Erin_Meyer). A short overview > +can be found > +[here](https://www.nsf.gov/attachments/134059/public/15LFW_WorkingWithMulticulturalTeams_LarsonC.pdf) > +[33 slides]. > + > +### Code reviews and discussions are not competitions > +Code reviews on our mailing lists are not competitions on who can come up with the > +smartest solution or who is the real coding genius. > + > +In a code review - as well as in general - we expect that all stake-holders > +* Gracefully accept constructive criticism > +* Focus on what is best for the community > +* Resolve differences in opinion effectively > + > +The next section provides pointers on how to do this effectively. > + > +### Resolving Disagreement Effectively > +Common scenarios are covered our guide on > +[Resolving Disagreement](resolving-disagreement.md), which lays out situations that > +can lead to dead-lock and shows common patterns on how to avoid and resolve issues. > -- > 2.13.0 > --8323329-1207343631-1574899973=:27669 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWFwaSBt YWlsaW5nIGxpc3QKWGVuLWFwaUBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhl bnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWFwaQo= --8323329-1207343631-1574899973=:27669-- From xen-api-bounces@lists.xenproject.org Thu Nov 28 01:06:44 2019 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Nov 2019 01:06:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ia8GZ-00011q-Gz; Thu, 28 Nov 2019 01:06:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ia8GY-00011V-B5 for xen-api@lists.xenproject.org; Thu, 28 Nov 2019 01:06:42 +0000 X-Inumbo-ID: 4a46a1f0-117b-11ea-83b8-bc764e2007e4 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4a46a1f0-117b-11ea-83b8-bc764e2007e4; Thu, 28 Nov 2019 01:06:21 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8BC9D2158A; Thu, 28 Nov 2019 01:06:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574903181; bh=uaB3mtFMO5egteCoStMhSeRFBaD0p+dPCJFxQm7xsGE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=nFrSC+BOE2ldK46qk2xNPRH047vhDei6yYfbIOkwE2CgbwAt5nojJsEQ+p/zMtLDG fN62uU27Ipg7A/KPK2id66MTLAwruAuFqfLfRR6qCP1nngi9BQCGf5wfcZ6AW1lKUw VWYrvKp/YqipTxIcRabjmQ3ql2mr49vp421trTbg= Date: Wed, 27 Nov 2019 17:06:19 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Jan Beulich In-Reply-To: Message-ID: References: <749f082bdb996ba7c7362847b22030882dc2903f.1569525222.git.lars.kurth@citrix.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Subject: Re: [Xen-API] [PATCH v2 5/6] Add guide on Communication Best Practice X-BeenThere: xen-api@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: User and development list for XCP and XAPI List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Lars Kurth , Lars Kurth , xen-api@lists.xenproject.org, minios-devel@lists.xenproject.org, committers@xenproject.org, mirageos-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, win-pv-devel@lists.xenproject.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-api-bounces@lists.xenproject.org Sender: "Xen-api" T24gRnJpLCAyNyBTZXAgMjAxOSwgSmFuIEJldWxpY2ggd3JvdGU6Cj4gT24gMjYuMDkuMjAxOSAy MTozOSwgTGFycyBLdXJ0aCB3cm90ZToKPiA+ICsjIyMgVmVyYm9zZSB2cy4gdGVyc2UKPiA+ICtE dWUgdG8gdGhlIHRpbWUgaXQgdGFrZXMgdG8gcmV2aWV3IGFuZCBjb21wb3NlIGNvZGUgcmV2aWV3 ZXIsIHJldmlld2VycyBvZnRlbiBhZG9wdCBhCj4gPiArdGVyc2Ugc3R5bGUuIEl0IGlzIG5vdCB1 bnVzdWFsIHRvIHNlZSByZXZpZXcgY29tbWVudHMgc3VjaCBhcwo+ID4gKz4gdHlwbwo+ID4gKz4g cy9yZXNpb25zL3JlZ2lvbnMvCj4gPiArPiBjb2Rpbmcgc3R5bGUKPiA+ICs+IGNvZGluZyBzdHls ZTogYnJhY2tldHMgbm90IG5lZWRlZAo+ID4gK2V0Yy4KPiA+ICsKPiA+ICtUZXJzZSBjb2RlIHJl dmlldyBzdHlsZSBoYXMgaXRzIHBsYWNlIGFuZCBjYW4gYmUgcHJvZHVjdGl2ZSBmb3IgYm90aCB0 aGUgcmV2aWV3ZXIgYW5kCj4gPiArdGhlIGF1dGhvci4gSG93ZXZlciwgb3ZlcnVzZSBjYW4gY29t ZSBhY3Jvc3MgYXMgdW5mcmllbmRseSwgbGFja2luZyBlbXBhdGh5IGFuZAo+ID4gK2NhbiB0aHVz IGNyZWF0ZSBhIG5lZ2F0aXZlIGltcHJlc3Npb24gd2l0aCB0aGUgYXV0aG9yIG9mIGEgcGF0Y2gu IFRoaXMgaXMgaW4gcGFydGljdWxhcgo+ID4gK3RydWUsIHdoZW4geW91IGRvIG5vdCBrbm93IHRo ZSBhdXRob3Igb3IgdGhlIGF1dGhvciBpcyBhIG5ld2NvbWVyLiBUZXJzZQo+ID4gK2NvbW11bmlj YXRpb24gc3R5bGVzIGNhbiBhbHNvIGJlIHBlcmNlaXZlZCBhcyBydWRlIGluIHNvbWUgY3VsdHVy ZXMuCj4gCj4gQW5kIGFub3RoZXIgcmVtYXJrIGhlcmU6IE5vdCBiZWluZyB0ZXJzZSBpbiBzaXR1 YXRpb25zIGxpa2UgdGhlIG9uZXMKPiBlbnVtZXJhdGVkIGFzIGV4YW1wbGVzIGFib3ZlIGlzIGEg ZG91YmxlIHdhc3RlIG9mIHRoZSByZXZpZXdlcidzIHRpbWU6Cj4gVGhleSBzaG91bGRuJ3QgZXZl biBuZWVkIHRvIG1ha2Ugc3VjaCBjb21tZW50cywgZXNwZWNpYWxseSBub3QgbWFueQo+IHRpbWVz IGZvciBhIHNpbmdsZSBwYXRjaCAoc2VlIHlvdXIgbWVudGlvbiBvZiAib3ZlcnVzZSIpLiBJIHJl YWxpemUKPiB3ZSBzdGlsbCBoYXZlIG5vIGF1dG9tYXRlZCBtZWNoYW5pc20gdG8gY2hlY2sgc3R5 bGUgYXNwZWN0cywgYnV0Cj4gYW55Ym9keSBjYW4gZWFzaWx5IGxvb2sgb3ZlciB0aGVpciBwYXRj aGVzIGJlZm9yZSBzdWJtaXR0aW5nIHRoZW0uCj4gQW5kIGZvciBhbiBvY2Nhc2lvbmFsIGlzc3Vl IEkgdGhpbmsgYSB0ZXJzZSByZXBseSBpcyBxdWl0ZSByZWFzb25hYmxlCj4gdG8gaGF2ZS4KPiAK PiBPdmVyYWxsIEknbSBzZWVpbmcgdGhlIGdvb2QgaW50ZW50aW9ucyBvZiB0aGlzIGRvY3VtZW50 LCB5ZXQgSSdkIHN0aWxsCj4gdm90ZSBhdCBsZWFzdCAtMSBvbiBpdCBpZiBpdCBjYW1lIHRvIGEg dm90ZS4gRm9sbG93aW5nIGV2ZW4ganVzdCBhCj4gZmFpciBwYXJ0IG9mIGl0IGlzIGEgY29uc2lk ZXJhYmxlIGV4dHJhIGFtb3VudCBvZiB0aW1lIHRvIGludmVzdCBpbgo+IHJldmlld3MsIHdoZW4g d2UgYWxyZWFkeSBoYXZlIGEgc2V2ZXJlIHJldmlld2luZyBib3R0bGVuZWNrLiBJZiBJIGhhdmUK PiB0byBqdWRnZSBiZXR3ZWVuIGRvaW5nIGEgYmFkIChzdHlsaXN0aWNhbGx5IGFjY29yZGluZyB0 byB0aGlzIGRvYywgbm90Cj4gdGVjaG5pY2FsbHkpIHJldmlldyBvciBub25lIGF0IGFsbCAoYmVj YXVzZSBvZiB0aW1lIGNvbnN0cmFpbnRzKSwgSSdkCj4gZmF2b3IgdGhlIGZvcm1lci4gVW5sZXNz IG9mIGNvdXJzZSBJJ20gYXNrZWQgdG8gc3RvcCBkb2luZyBzbywgaW4KPiB3aGljaCBjYXNlIEkn ZCBleHBlY3Qgd2hvZXZlciBhc2tzIHRvIGFycmFuZ2UgZm9yIHRoZSByZXZpZXdzIHRvIGJlCj4g ZG9uZSBieSBzb21lb25lIGVsc2UgaW4gZHVlIGNvdXJzZS4KClJlYWRpbmcgdGhlIGRvY3VtZW50 LCBJIHRoaW5rIEphbiBoYXMgYSBwb2ludCB0aGF0IGl0IGdpdmVzIHRoZQppbXByZXNzaW9uIHRo YXQgZm9sbG93aW5nIHRoZSBzdWdnZXN0aW9ucyB3b3VsZCB0YWtlIHNpZ25pZmljYW50CmVmZm9y dHMsIHdoaWxlIGFjdHVhbGx5IEkgZG9uJ3QgdGhpbmsgTGFycyBtZWFudCBpdCB0aGF0IHdheSBh dCBhbGwsIGFuZApJIGRvbid0IHRoaW5rIGl0IHNob3VsZCBiZSB0aGUgY2FzZSBlaXRoZXIuCgpN YXliZSB3ZSBzaG91bGQgaGlnaGxpZ2h0IGFuZCBlbmNvdXJhZ2UgImNsYXJpdHkiIGluc3RlYWQg b2YgInZlcmJvc2l0eSIKb2YgdGhlIGNvbW11bmljYXRpb24sIGFuZCBlbmNvdXJhZ2UgImV4cHJl c3NpbmcgYXBwcmVjaWF0aW9uIiB0bwpuZXdjb21lcnMsIG5vdCBuZWNlc3NhcmlseSB0byBzZWFz b25lZCBjb250cmlidXRvcnMuCgpUaGUgdWx0aW1hdGUgZ29hbCBvZiB0aGlzIGRvY3VtZW50IGlz IGFjdHVhbGx5IHRvICpyZWR1Y2UqIG91ciBvdmVyYWxsCmVmZm9ydHMgYnkgbWFraW5nIG91ciBj b21tdW5pY2F0aW9uIG1vcmUgZWZmaWNpZW50LCBub3QgdG8gaW5jcmVhc2UKZWZmb3J0cy4gTWF5 YmUgaXQgaXMgd29ydGggc2F5aW5nIHRoaXMgdG9vLgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KWGVuLWFwaSBtYWlsaW5nIGxpc3QKWGVuLWFwaUBsaXN0 cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlz dGluZm8veGVuLWFwaQo= From xen-api-bounces@lists.xenproject.org Thu Nov 28 10:09:49 2019 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Nov 2019 10:09:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaGk2-0005AJ-Hl; Thu, 28 Nov 2019 10:09:42 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaGk1-0005AE-N7 for xen-api@lists.xenproject.org; Thu, 28 Nov 2019 10:09:41 +0000 X-Inumbo-ID: 30855d46-11c7-11ea-a3cd-12813bfff9fa Received: from mx1.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 30855d46-11c7-11ea-a3cd-12813bfff9fa; Thu, 28 Nov 2019 10:09:40 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 135F5B486; Thu, 28 Nov 2019 10:09:39 +0000 (UTC) To: Stefano Stabellini , Lars Kurth References: <97e3adf75cf71ba39e702d4cab23236ada8d5a6c.1569525222.git.lars.kurth@citrix.com> From: Jan Beulich Message-ID: <909826df-25c1-6d7c-75d9-470365d2ecf6@suse.com> Date: Thu, 28 Nov 2019 11:09:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Subject: Re: [Xen-API] [Xen-devel] [PATCH v2 4/6] Add Code Review Guide X-BeenThere: xen-api@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: User and development list for XCP and XAPI List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Lars Kurth , xen-api@lists.xenproject.org, minios-devel@lists.xenproject.org, committers@xenproject.org, mirageos-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, win-pv-devel@lists.xenproject.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-api-bounces@lists.xenproject.org Sender: "Xen-api" T24gMjguMTEuMjAxOSAwMTo1NCwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOgo+IE9uIFRodSwg MjYgU2VwIDIwMTksIExhcnMgS3VydGggd3JvdGU6Cj4+IEZyb206IExhcnMgS3VydGggPGxhcnMu a3VydGhAY2l0cml4LmNvbT4KPj4KPj4gVGhpcyBkb2N1bWVudCBoaWdobGlnaHRzIHdoYXQgcmV2 aWV3ZXJzIHN1Y2ggYXMgbWFpbnRhaW5lcnMgYW5kIGNvbW1pdHRlcnMgbG9vawo+PiBmb3Igd2hl biByZXZpZXdpbmcgY29kZS4gSXQgc2V0cyBleHBlY3RhdGlvbnMgZm9yIGNvZGUgYXV0aG9ycyBh bmQgcHJvdmlkZXMKPj4gYSBmcmFtZXdvcmsgZm9yIGNvZGUgcmV2aWV3ZXJzLgo+IAo+IEkgdGhp bmsgdGhlIGRvY3VtZW50IGlzIG1pc3NpbmcgYSBjb3VwbGUgb2YgdGhpbmdzOgo+IAo+IC0gYSBz aW1wbGUgb25lIGxpbmUgc3RhdGVtZW50IHRoYXQgcG9zc2libHkgdGhlIG1vc3QgaW1wb3J0YW50 IHRoaW5nIGluCj4gICBhIGNvZGUgcmV2aWV3IGlzIHRvIGluZGVudGlmeSBhbnkgYnVncyBpbiB0 aGUgY29kZQo+IAo+IC0gYW4gZXhwbGFuYXRpb24gdGhhdCByZXF1ZXN0cyBmb3IgbWFqb3IgY2hh bmdlcyB0byB0aGUgc2VyaWVzIHNob3VsZCBiZQo+ICAgbWFkZSBlYXJseSBvbiAoaS5lLiBsZXQn cyBub3QgY2hhbmdlIHRoZSBhcmNoaXRlY3R1cmUgb2YgYSBmZWF0dXJlIGF0Cj4gICB2OSBpZiBw b3NzaWJsZSkgSSBhbHNvIG1hZGUgdGhpcyBjb21tZW50IGluIHJlcGx5IHRvIHBhdGNoICM1LiBJ J2xsCj4gICBsZXQgeW91IGRlY2lkZSB3aGVyZSBpcyB0aGUgYmVzdCBwbGFjZSBmb3IgaXQuCgpU aGlzIG5lZWRzIGJhbGFuY2luZy4gUGVvcGxlIGNydWNpYWwgdG8gdGhlIGV2YWx1YXRpb24gb2Yg YSBuZXcKZmVhdHVyZSBhbmQgaXRzIGltcGxlbWVudGF0aW9uIHNpbXBseSBtYXkgbm90IGhhdmUg dGhlIHRpbWUgdG8KcmVwbHkgcHJpb3IgdG8gdjkuIFdlJ3ZlIGhhZCBzaXR1YXRpb25zIHdoZXJl IHBlb3BsZSBwb3N0ZWQgbmV3CnJldmlzaW9ucyBldmVyeSBvdGhlciBkYXksIHNvbWV0aW1lcyBl dmVuIG1vcmUgdGhhbiBvbmUgcGVyIGRheS4KCkFzIGluZGljYXRlZCBpbiBzZXZlcmFsIG90aGVy IGNvbnRleHRzIGJlZm9yZSAtIGltbyBwZW9wbGUgbm90CmhlbHBpbmcgdG8gc2hvdWxkZXIgdGhl IHJldmlldyBsb2FkIHNob3VsZCBhbHNvIG5vdCBoYXZlIHRoZQpleHBlY3RhdGlvbiB0aGF0IHRo ZWlyIChsYXJnZSkgY29udHJpYnV0aW9ucyB3aWxsIGJlIGxvb2tlZCBhdAppbiBkdWUgY291cnNl LiAKCkphbgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K WGVuLWFwaSBtYWlsaW5nIGxpc3QKWGVuLWFwaUBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczov L2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWFwaQo= From xen-api-bounces@lists.xenproject.org Thu Nov 28 10:18:39 2019 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Nov 2019 10:18:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaGsg-0006Kv-Ep; Thu, 28 Nov 2019 10:18:38 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaGsf-0006Kp-BE for xen-api@lists.xenproject.org; Thu, 28 Nov 2019 10:18:37 +0000 X-Inumbo-ID: 6ed1679c-11c8-11ea-a3cd-12813bfff9fa Received: from mx1.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6ed1679c-11c8-11ea-a3cd-12813bfff9fa; Thu, 28 Nov 2019 10:18:34 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 29564BAD0; Thu, 28 Nov 2019 10:18:33 +0000 (UTC) To: Stefano Stabellini , Lars Kurth References: <2e4b36afaa73277d246d7e84037db1532a136ec7.1569525222.git.lars.kurth@citrix.com> From: Jan Beulich Message-ID: <22b7f67c-c3dc-5450-999f-e79168175d39@suse.com> Date: Thu, 28 Nov 2019 11:18:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Subject: Re: [Xen-API] [Xen-devel] [PATCH v2 6/6] Added Resolving Disagreement X-BeenThere: xen-api@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: User and development list for XCP and XAPI List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Lars Kurth , xen-api@lists.xenproject.org, minios-devel@lists.xenproject.org, committers@xenproject.org, mirageos-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, win-pv-devel@lists.xenproject.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-api-bounces@lists.xenproject.org Sender: "Xen-api" T24gMjguMTEuMjAxOSAwMTo1NiwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOgo+IE9uIFRodSwg MjYgU2VwIDIwMTksIExhcnMgS3VydGggd3JvdGU6Cj4+ICtUaGlzIGNvdWxkIHRha2UgZm9yIGV4 YW1wbGUgdGhlIGZvcm0gb2YKPj4gKz4gRG8geW91IHRoaW5rIGl0IHdvdWxkIGJlIHVzZWZ1bCBm b3IgdGhlIGNvZGUgdG8gZG8gWFhYPyAKPj4gKz4gSSBjYW4gaW1hZ2luZSBhIHVzZXIgd2FudGlu ZyB0byBkbyBZWVkgKGFuZCBYWFggd291bGQgZW5hYmxlIHRoaXMpCj4+ICsKPj4gK1RoYXQgcG90 ZW50aWFsbHkgYWRkcyBhZGRpdGlvbmFsIHdvcmsgZm9yIHRoZSBjb2RlIGF1dGhvciwgd2hpY2gg dGhleSBtYXkgbm90IGhhdmUKPj4gK3RoZSB0aW1lIHRvIHBlcmZvcm0uIEl0IGlzIGdvb2QgcHJh Y3RpY2UgZm9yIGF1dGhvcnMgdG8gY29uc2lkZXIgc3VjaCBhIHJlcXVlc3QgaW4gdGVybXMgb2YK Pj4gKyogVXNlZnVsbmVzcyB0byB0aGUgdXNlcgo+PiArKiBDb2RlIGNodXJuLCBjb21wbGV4aXR5 IG9yIGltcGFjdCBvbiBvdGhlciBzeXN0ZW0gcHJvcGVydGllcwo+PiArKiBFeHRyYSB0aW1lIHRv IGltcGxlbWVudCBhbmQgcmVwb3J0IGJhY2sgdG8gdGhlIHJldmlld2VyCj4+ICsKPj4gK0lmIHlv dSBiZWxpZXZlIHRoYXQgdGhlIGltcGFjdC9jb3N0IGlzIHRvbyBoaWdoLCByZXBvcnQgYmFjayB0 byB0aGUgcmV2aWV3ZXIuIFRvIHJlc29sdmUKPj4gK3RoaXMsIGl0IGlzIGFkdmlzYWJsZSB0bwo+ PiArKiBSZXBvcnQgeW91ciBmaW5kaW5ncwo+PiArKiBBbmQgdGhlbiBjaGVjayB3aGV0aGVyIHRo aXMgd2FzIG1lcmVseSBhbiBpbnRlcmVzdGluZyBzdWdnZXN0aW9uLCBvciBzb21ldGhpbmcgdGhl Cj4+ICtyZXZpZXdlciBmZWVscyBtb3JlIHN0cm9uZ2x5IGFib3V0Cj4+ICsKPj4gK0luIHRoZSBs YXR0ZXIgY2FzZSwgdGhlcmUgYXJlIHR5cGljYWxseSBzZXZlcmFsIGNvbW1vbiBvdXRjb21lcwo+ PiArKiBUaGUgKiphdXRob3IgYW5kIHJldmlld2VyIGFncmVlKiogdGhhdCB0aGUgc3VnZ2VzdGlv biBzaG91bGQgYmUgaW1wbGVtZW50ZWQKPj4gKyogVGhlICoqYXV0aG9yIGFuZCByZXZpZXdlciBh Z3JlZSoqIHRoYXQgaXQgbWF5IG1ha2Ugc2Vuc2UgdG8gZGVmZXIgaW1wbGVtZW50YXRpb24KPj4g KyogVGhlICoqYXV0aG9yIGFuZCByZXZpZXdlciBhZ3JlZSoqIHRoYXQgaXQgbWFrZXMgbm8gc2Vu c2UgdG8gaW1wbGVtZW50IHRoZSBzdWdnZXN0aW9uCj4+ICsKPj4gK1RoZSBhdXRob3Igb2YgYSBw YXRjaCB3b3VsZCB0eXBpY2FsbHkgc3VnZ2VzdCB0aGVpciBwcmVmZXJyZWQgb3V0Y29tZSwgZm9y IGV4YW1wbGUKPj4gKz4gSSBhbSBub3Qgc3VyZSBpdCBpcyB3b3J0aCB0byBpbXBsZW1lbnQgWFhY Cj4+ICs+IERvIHlvdSB0aGluayB0aGlzIGNvdWxkIGJlIGRvbmUgYXMgYSBzZXBhcmF0ZSBwYXRj aCBpbiBmdXR1cmU/Cj4+ICsKPj4gK0luIGNhc2VzLCB3aGVyZSBubyBhZ3JlZW1lbnQgY2FuIGJl IGZvdW5kLCB0aGUgYmVzdCBhcHByb2FjaCB3b3VsZCBiZSB0byBnZXQgYW4KPj4gK2luZGVwZW5k ZW50IG9waW5pb24gZnJvbSBhbm90aGVyIG1haW50YWluZXIgb3IgdGhlIHByb2plY3QncyBsZWFk ZXJzaGlwIHRlYW0uCj4gCj4gSSB0aGluayB3ZSBzaG91bGQgbWVudGlvbiBzb21ld2hlcmUgaGVy ZSB0aGF0IGl0IGlzIHJlY29tbWVuZGVkIGZvcgo+IHJldmlld2VycyB0byBiZSBleHBsaWNpdCBh Ym91dCB3aGV0aGVyIGEgcmVxdWVzdCBpcyBvcHRpb25hbCBvciB3aGV0aGVyCj4gaXQgaXMgYSBy ZXF1aXJlbWVudC4KPiAKPiBGb3IgaW5zdGFuY2U6ICJJIHRoaW5rIGl0IHdvdWxkIGJlIGdvb2Qg aWYgWCBhbHNvIGRpZCBZIiBkb2Vzbid0IHNheSBpZgo+IGl0IGlzIG9wdGlvbmFsIChmdXR1cmUg d29yaykgb3IgaXQgaXMgYWN0dWFsbHkgcmVxdWlyZWQgYXMgcGFydCBvZiB0aGlzCj4gc2VyaWVz LiBNb3JlIGV4cGxpY2l0IHdvcmQgY2hvaWNlcyBhcmUgcHJlZmVyYWJsZSwgc3VjaCBhczoKPiAK PiAiSSB0aGluayBpdCB3b3VsZCBiZSBnb29kIGlmIFggYWxzbyBkaWQgWSwgbm90IGEgcmVxdWly ZW1lbnQgYnV0IGdvb2QgdG8KPiBoYXZlLiIKPiAKPiAiSSB0aGluayBpdCB3b3VsZCBiZSBnb29k IGlmIFggYWxzbyBkaWQgWSBhbmQgaXQgc2hvdWxkIGJlIHBhcnQgb2YgdGhpcwo+IHNlcmllcy4i CgpJIHRoaW5rIHdpdGhvdXQgaXQgYmVpbmcgbWFkZSBleHBsaWNpdCB0aGF0IHNvbWV0aGluZyBp cyBvcHRpb25hbCwKdGhlIGFzc3VtcHRpb24gc2hvdWxkIGJlIHRoYXQgaXQgaXNuJ3QuIEkuZS4g aW4gdGhlIGZpcnN0IGV4YW1wbGUKSSBhZ3JlZSB3aXRoIHRoZSBpZGVhIHRvIGhhdmUgc29tZXRo aW5nIGFmdGVyIHRoZSBjb21tYSwgYnV0IGluCnRoZSBzZWNvbmQgZXhhbXBsZSBJIHRoaW5rIHRo ZSBleHRyYSB3b3JkaW5nIGlzIGEgd2FzdGUgb2YgZWZmb3J0LgoKPiBJIHRoaW5rIHRoZXJlIGlz IHNvbWV0aGluZyBlbHNlIHdlIHNob3VsZCBzYXkgb24gdGhpcyB0b3BpYy4gVGhlcmUgaXMgYQo+ IGNhdGVnb3J5IG9mIHRoaW5ncyB3aGljaCBjb3VsZCBiZSBkb25lIGluIG11bHRpcGxlIHdheXMg YW5kIGl0IGlzIG5vdAo+IG92ZXJ0bHkgb2J2aW91cyB3aGljaCBvbmUgaXMgYmVzdC4gSXQgaXMg ZG9uZSB0byB0aGUgbWFpbnRhaW5lciBhbmQgdGhlCj4gYXV0aG9yIHBlcnNvbmFsIHN0eWxlcy4g SXQgaXMgZWFzeSB0byBkaXNhZ3JlZSBvbiB0aGF0Lgo+IAo+IEkgdGhpbmsgYSBnb29kIHJlY29t bWVuZGF0aW9uIHdvdWxkIGJlIGZvciB0aGUgY29udHJpYnV0b3IgdG8gdHJ5IHRvCj4gZm9sbG93 IHRoZSBtYWludGFpbmVycyByZXF1ZXN0cywgZXZlbiBpZiB0aGV5IGNvdWxkIGJlIGNvbnNpZGVy ZWQKPiAic3R5bGUiLCB0cnVzdGluZyB0aGVpciBleHBlcmllbmNlIG9uIHRoZSBtYXR0ZXIuIEFu ZCBhIGdvb2QKPiByZWNvbW1lbmRhdGlvbiBmb3IgdGhlIG1haW50YWluZXIgd291bGQgYmUgdG8g dHJ5IHRvIGxldCB0aGUgY29udHJpYnV0b3IKPiBoYXZlIGZyZWVkb20gb2YgaW1wbGVtZW50YXRp b24gY2hvaWNlIG9uIHRoaW5ncyB0aGF0IGRvbid0IG1ha2UgYQo+IHNpZ25pZmljYW50IGRpZmZl cmVuY2UuCgpJIHRoaW5rIHdlIHRyeSB0bywgYnV0IEkgYWxzbyB0aGluayB3ZSBzdWZmZXIgZnJv bSB0b28gbGl0dGxlCmNsZWFyIGRvY3VtZW50YXRpb24gb24gZS5nLiBzdHlsZSBhc3BlY3RzLiBB dHRlbXB0cyBvbiBteSBwYXJ0CnRvIGFkZHJlc3MgdGhpcyBoYXZlIG1vc3RseSAobm90IGVudGly ZWx5KSBsZWFkIG5vLXdoZXJlIChsYWNrIG9mCmZlZWRiYWNrIG9uIHByb3Bvc2VkIHBhdGNoZXMg dG8gLi9DT0RJTkdfU1RZTEUpLiBTbyBmb3IgdGhlIHRpbWUKYmVpbmcgdGhlcmUgYXJlIChtYW55 KSBhc3BlY3RzIHdoZXJlIHdlIGhhdmUgZGUtZmFjdG8gZXhwZWN0YXRpb25zCnRoYXQgYXJlbid0 IHdyaXR0ZW4gZG93biBhbnl3aGVyZSwgd2l0aCB0aGUgcmVzdWx0IG9mIChpbiBhIHN1YnNldApv ZiBjYXNlcykgZGlzYWdyZWVtZW50IG9uIHdoYXQgdGhlIHBlcmNlaXZlZCBkZS1mYWN0byBzdGFu ZGFyZAphY3R1YWxseSBpcy4KCkphbgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KWGVuLWFwaSBtYWlsaW5nIGxpc3QKWGVuLWFwaUBsaXN0cy54ZW5wcm9q ZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVu LWFwaQo= From xen-api-bounces@lists.xenproject.org Thu Nov 28 13:06:59 2019 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Nov 2019 13:06:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaJVU-00064U-0N; Thu, 28 Nov 2019 13:06:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaJVS-00064M-S7 for xen-api@lists.xenproject.org; Thu, 28 Nov 2019 13:06:50 +0000 X-Inumbo-ID: e9523f67-11df-11ea-a3d2-12813bfff9fa Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e9523f67-11df-11ea-a3d2-12813bfff9fa; Thu, 28 Nov 2019 13:06:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1574946399; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=SLRRkcq0NsgessIStO64x11cu8dqcIdXEeovuA1RDA0=; b=H6zqWgRpjAC76IDOR8mwrKKD4BasGRWgoEl311Can3weGb5o/n4s7tWn sEvQW7aPGk8TLcUDD4Rk2ljNSOHKph8KaG1peaCEswL0/cKLe+o4JavLy 7JoI+Ip5hjloTl8drlhZCdTrD1ZkNQJEGqxZa7Pq7rbNLXZ0t2iQfy9gy Y=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=lars.kurth@citrix.com; spf=Pass smtp.mailfrom=lars.kurth@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of lars.kurth@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="lars.kurth@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa3.hc3370-68.iphmx.com: domain of lars.kurth@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="lars.kurth@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: XP56NDIBQS8bELwL2rG9J+C46g6OsrvGTd1pnaUqd8AapGyMf0aoGJoLsFzDdu5CZfNTairVta mylRfJ6pH5ydKGbbUN7JkVRtBgpNh1kZFlNeA2GqjBk0yH/+y6stMCDMyFD2rsTunLRb8gAD09 cteGN5ePDf0n1wxklLl9Wd9I5j4XjoVqwWd6GFR0eH5peyTtz8XnIR9qMurdzMe6DaJItLDO6u 0Zz/Yl0gRWQV90Jdtg/wdFvTps3nsLtbVajEtigI1cYDNAE+Xv1sZ6dkogxC1Vcm+rNsxGkfh1 X4k= X-SBRS: 2.7 X-MesageID: 8946827 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.69,253,1571716800"; d="scan'208";a="8946827" From: Lars Kurth To: Jan Beulich , Stefano Stabellini , Lars Kurth Thread-Topic: [Xen-devel] [PATCH v2 4/6] Add Code Review Guide Thread-Index: AQHVdKIj+bIBaPEUGUyD9FYiIrE4J6egEqKAgACbQgD//8zPgA== Date: Thu, 28 Nov 2019 13:06:34 +0000 Message-ID: <2200B0A8-0EDE-4843-A5D3-A84F2D01333D@citrix.com> References: <97e3adf75cf71ba39e702d4cab23236ada8d5a6c.1569525222.git.lars.kurth@citrix.com> <909826df-25c1-6d7c-75d9-470365d2ecf6@suse.com> In-Reply-To: <909826df-25c1-6d7c-75d9-470365d2ecf6@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/10.10.10.191111 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted Content-ID: MIME-Version: 1.0 Subject: Re: [Xen-API] [Xen-devel] [PATCH v2 4/6] Add Code Review Guide X-BeenThere: xen-api@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: User and development list for XCP and XAPI List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-api@lists.xenproject.org" , "minios-devel@lists.xenproject.org" , "committers@xenproject.org" , "mirageos-devel@lists.xenproject.org" , "xen-devel@lists.xenproject.org" , "win-pv-devel@lists.xenproject.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-api-bounces@lists.xenproject.org Sender: "Xen-api" DQoNCu+7v09uIDI4LzExLzIwMTksIDA0OjA5LCAiSmFuIEJldWxpY2giIDxqYmV1bGljaEBzdXNl LmNvbT4gd3JvdGU6DQoNCiAgICBPbiAyOC4xMS4yMDE5IDAxOjU0LCBTdGVmYW5vIFN0YWJlbGxp bmkgd3JvdGU6DQogICAgPiBPbiBUaHUsIDI2IFNlcCAyMDE5LCBMYXJzIEt1cnRoIHdyb3RlOg0K ICAgID4+IEZyb206IExhcnMgS3VydGggPGxhcnMua3VydGhAY2l0cml4LmNvbT4NCiAgICA+Pg0K ICAgID4+IFRoaXMgZG9jdW1lbnQgaGlnaGxpZ2h0cyB3aGF0IHJldmlld2VycyBzdWNoIGFzIG1h aW50YWluZXJzIGFuZCBjb21taXR0ZXJzIGxvb2sNCiAgICA+PiBmb3Igd2hlbiByZXZpZXdpbmcg Y29kZS4gSXQgc2V0cyBleHBlY3RhdGlvbnMgZm9yIGNvZGUgYXV0aG9ycyBhbmQgcHJvdmlkZXMN CiAgICA+PiBhIGZyYW1ld29yayBmb3IgY29kZSByZXZpZXdlcnMuDQogICAgPiANCiAgICA+IEkg dGhpbmsgdGhlIGRvY3VtZW50IGlzIG1pc3NpbmcgYSBjb3VwbGUgb2YgdGhpbmdzOg0KICAgID4g DQogICAgPiAtIGEgc2ltcGxlIG9uZSBsaW5lIHN0YXRlbWVudCB0aGF0IHBvc3NpYmx5IHRoZSBt b3N0IGltcG9ydGFudCB0aGluZyBpbg0KICAgID4gICBhIGNvZGUgcmV2aWV3IGlzIHRvIGluZGVu dGlmeSBhbnkgYnVncyBpbiB0aGUgY29kZQ0KICAgID4gDQogICAgPiAtIGFuIGV4cGxhbmF0aW9u IHRoYXQgcmVxdWVzdHMgZm9yIG1ham9yIGNoYW5nZXMgdG8gdGhlIHNlcmllcyBzaG91bGQgYmUN CiAgICA+ICAgbWFkZSBlYXJseSBvbiAoaS5lLiBsZXQncyBub3QgY2hhbmdlIHRoZSBhcmNoaXRl Y3R1cmUgb2YgYSBmZWF0dXJlIGF0DQogICAgPiAgIHY5IGlmIHBvc3NpYmxlKSBJIGFsc28gbWFk ZSB0aGlzIGNvbW1lbnQgaW4gcmVwbHkgdG8gcGF0Y2ggIzUuIEknbGwNCiAgICA+ICAgbGV0IHlv dSBkZWNpZGUgd2hlcmUgaXMgdGhlIGJlc3QgcGxhY2UgZm9yIGl0Lg0KICAgIA0KICAgIFRoaXMg bmVlZHMgYmFsYW5jaW5nLiBQZW9wbGUgY3J1Y2lhbCB0byB0aGUgZXZhbHVhdGlvbiBvZiBhIG5l dw0KICAgIGZlYXR1cmUgYW5kIGl0cyBpbXBsZW1lbnRhdGlvbiBzaW1wbHkgbWF5IG5vdCBoYXZl IHRoZSB0aW1lIHRvDQogICAgcmVwbHkgcHJpb3IgdG8gdjkuIFdlJ3ZlIGhhZCBzaXR1YXRpb25z IHdoZXJlIHBlb3BsZSBwb3N0ZWQgbmV3DQogICAgcmV2aXNpb25zIGV2ZXJ5IG90aGVyIGRheSwg c29tZXRpbWVzIGV2ZW4gbW9yZSB0aGFuIG9uZSBwZXIgZGF5Lg0KDQpJIGNhbiBjZXJ0YWlubHkg YWRkIHNvbWV0aGluZyBvbiB0aGUgdGltaW5nICwgYWxvbmcgdGhlIGxpbmVzIG9mDQoqIEZvciBj b21wbGV4IHNlcmllcywgY29uc2lkZXIgdGhlIHRpbWUgaXQgdGFrZXMgdG8gZG8gcmV2aWV3cyAo bWF5YmUgd2l0aCBhIGd1aWRlIG9mIExPQyBwZXIgaG91cikgYW5kIGdpdmUgcmV2aWV3ZXJzIGVu b3VnaCB0aW1lIHRvDQoqIEZvciBzZXJpZXMgd2l0aCBkZXNpZ24gaXNzdWVzIG9yIGxhcmdlIHF1 ZXN0aW9ucywgdHJ5IGFuZCBoaWdobGlnaHQgdGhlIGtleSBvcGVuIGlzc3VlcyBpbiBjb3ZlciBs ZXR0ZXJzIGNsZWFybHkgYW5kIHNvbGljaXQgZmVlZGJhY2sgZnJvbSBrZXkgbWFpbnRhaW5lcnMg d2hvIGNhbiBjb21tZW50IG9uIHRoZSBvcGVuIGlzc3VlLiBUaGUgaWRlYSBpcyB0byBzYXZlIGJv dGggdGhlIGNvbnRyaWJ1dG9yIGFuZCB0aGUgcmV2aWV3ZXJzIHRpbWUgYnkgZm9jdXNzaW5nIG9u IHdoYXQgbmVlZHMgdG8gYmUgcmVzb2x2ZWQgDQoqIERvbuKAmXQgcmVwb3N0IGEgc2VyaWVzLCB1 bmxlc3MgYWxsIHJldmlldyBjb21tZW50cyBhcmUgYWRkcmVzc2VkIG9yIHRoZSByZXZpZXdlcnMg YXNrZWQgeW91IHRvIGRvIHNvLiBUaGUgcHJvYmxlbSB3aXRoIHRoaXMgaXMgdGhhdCB0aGlzIGlz IHNvbWV3aGF0IGluIGNvbmZsaWN0IHdpdGggdGhlICJsZXQncyBmb2N1cyBvbiB0aGUgY29yZSBp c3N1ZXMgYW5kIG5vdCBnZXQgZGlzdHJhY3RlZCBieSBkZXRhaWxzIGVhcmx5IG9uIGluIGEgcmV2 aWV3IGN5Y2xlIi4gSW4gb3RoZXIgd29yZHMsIHRoaXMgY2FuIG9ubHkgd29yaywgaWYgcmV2aWV3 ZXJzIGZvY3VzIG9uIG1ham9yIGlzc3VlcyBpbiBlYXJseSByZXZpZXdzIG9ubHkgYW5kIGRvIG5v dCBmb2N1cyBvbiBzdHlsZSwgY29kaW5nIHN0YW5kYXJkcywgZXRjLiBBcyBzb29uIGFzIGEgcmV2 aWV3ZXIgY29tZXMgYmFjayB3aXRoIGRldGFpbGVkIGZlZWRiYWNrLCB0aGUgY29udHJpYnV0b3Ig d2lsbCBmZWVsIG9ibGlnZWQgdG8gZml4IHRoZXNlLiBUaGlzIGNyZWF0ZXMgYSBtb3RpdmF0aW9u IHRvIHdhbnQgdG8gcGxlYXNlIHRoZSByZXZpZXdlciBzZW5kIG91dCBuZXcgdmVyc2lvbnMgb2Yg c2VyaWVzIGZpeGluZyBjb3NtZXRpYyBpc3N1ZXMgd2l0aG91dCBhZGRyZXNzaW5nIHRoZSBzdWJz dGFudGlhbCBpc3N1ZXMsIGxlYWRpbmcgdG8gd2hhdCBKYW4gZGVzY3JpYmVzLiBJIGFtIGxvb2tp bmcgZm9yIG9waW5pb25zIGhlcmUuICANCiAgICANCiAgICBBcyBpbmRpY2F0ZWQgaW4gc2V2ZXJh bCBvdGhlciBjb250ZXh0cyBiZWZvcmUgLSBpbW8gcGVvcGxlIG5vdA0KICAgIGhlbHBpbmcgdG8g c2hvdWxkZXIgdGhlIHJldmlldyBsb2FkIHNob3VsZCBhbHNvIG5vdCBoYXZlIHRoZQ0KICAgIGV4 cGVjdGF0aW9uIHRoYXQgdGhlaXIgKGxhcmdlKSBjb250cmlidXRpb25zIHdpbGwgYmUgbG9va2Vk IGF0DQogICAgaW4gZHVlIGNvdXJzZS4gDQogICAgDQpJIGNhbiBhZGQgc29tZXRoaW5nIHRvIHRo aXMgZWZmZWN0LiAgDQoNCkxhcnMNCiAgICANCg0KX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KWGVuLWFwaSBtYWlsaW5nIGxpc3QKWGVuLWFwaUBsaXN0cy54 ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGlu Zm8veGVuLWFwaQo= From xen-api-bounces@lists.xenproject.org Thu Nov 28 13:38:09 2019 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Nov 2019 13:38:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaJzj-0000Sv-Mr; Thu, 28 Nov 2019 13:38:07 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaJzi-0000Sb-Et for xen-api@lists.xenproject.org; Thu, 28 Nov 2019 13:38:06 +0000 X-Inumbo-ID: 413864fe-11e4-11ea-a3d2-12813bfff9fa Received: from mx1.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 413864fe-11e4-11ea-a3d2-12813bfff9fa; Thu, 28 Nov 2019 13:37:43 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id EFB12B169; Thu, 28 Nov 2019 13:37:42 +0000 (UTC) To: Lars Kurth References: <97e3adf75cf71ba39e702d4cab23236ada8d5a6c.1569525222.git.lars.kurth@citrix.com> <909826df-25c1-6d7c-75d9-470365d2ecf6@suse.com> <2200B0A8-0EDE-4843-A5D3-A84F2D01333D@citrix.com> From: Jan Beulich Message-ID: Date: Thu, 28 Nov 2019 14:37:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <2200B0A8-0EDE-4843-A5D3-A84F2D01333D@citrix.com> Content-Language: en-US Subject: Re: [Xen-API] [PATCH v2 4/6] Add Code Review Guide X-BeenThere: xen-api@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: User and development list for XCP and XAPI List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Lars Kurth , Stefano Stabellini , "xen-api@lists.xenproject.org" , "minios-devel@lists.xenproject.org" , "committers@xenproject.org" , "mirageos-devel@lists.xenproject.org" , "xen-devel@lists.xenproject.org" , "win-pv-devel@lists.xenproject.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-api-bounces@lists.xenproject.org Sender: "Xen-api" T24gMjguMTEuMjAxOSAxNDowNiwgTGFycyBLdXJ0aCB3cm90ZToKPiBJIGNhbiBjZXJ0YWlubHkg YWRkIHNvbWV0aGluZyBvbiB0aGUgdGltaW5nICwgYWxvbmcgdGhlIGxpbmVzIG9mCj4gKiBGb3Ig Y29tcGxleCBzZXJpZXMsIGNvbnNpZGVyIHRoZSB0aW1lIGl0IHRha2VzIHRvIGRvIHJldmlld3Mg KG1heWJlIHdpdGggYSBndWlkZSBvZiBMT0MgcGVyIGhvdXIpIGFuZCBnaXZlIHJldmlld2VycyBl bm91Z2ggdGltZSB0bwo+ICogRm9yIHNlcmllcyB3aXRoIGRlc2lnbiBpc3N1ZXMgb3IgbGFyZ2Ug cXVlc3Rpb25zLCB0cnkgYW5kIGhpZ2hsaWdodCB0aGUga2V5IG9wZW4gaXNzdWVzIGluIGNvdmVy IGxldHRlcnMgY2xlYXJseSBhbmQgc29saWNpdCBmZWVkYmFjayBmcm9tIGtleSBtYWludGFpbmVy cyB3aG8gY2FuIGNvbW1lbnQgb24gdGhlIG9wZW4gaXNzdWUuIFRoZSBpZGVhIGlzIHRvIHNhdmUg Ym90aCB0aGUgY29udHJpYnV0b3IgYW5kIHRoZSByZXZpZXdlcnMgdGltZSBieSBmb2N1c3Npbmcg b24gd2hhdCBuZWVkcyB0byBiZSByZXNvbHZlZCAKPiAqIERvbuKAmXQgcmVwb3N0IGEgc2VyaWVz LCB1bmxlc3MgYWxsIHJldmlldyBjb21tZW50cyBhcmUgYWRkcmVzc2VkCj4gb3IgdGhlIHJldmll d2VycyBhc2tlZCB5b3UgdG8gZG8gc28uIFRoZSBwcm9ibGVtIHdpdGggdGhpcyBpcyB0aGF0Cj4g dGhpcyBpcyBzb21ld2hhdCBpbiBjb25mbGljdCB3aXRoIHRoZSAibGV0J3MgZm9jdXMgb24gdGhl IGNvcmUKPiBpc3N1ZXMgYW5kIG5vdCBnZXQgZGlzdHJhY3RlZCBieSBkZXRhaWxzIGVhcmx5IG9u IGluIGEgcmV2aWV3IGN5Y2xlIi4KPiBJbiBvdGhlciB3b3JkcywgdGhpcyBjYW4gb25seSB3b3Jr LCBpZiByZXZpZXdlcnMgZm9jdXMgb24gbWFqb3IKPiBpc3N1ZXMgaW4gZWFybHkgcmV2aWV3cyBv bmx5IGFuZCBkbyBub3QgZm9jdXMgb24gc3R5bGUsIGNvZGluZwo+IHN0YW5kYXJkcywgZXRjLgoK QnV0IHRoaXMgZG9lc24ndCBtYWtlIG11Y2ggc2Vuc2UgZWl0aGVyLCBiZWNhdXNlIHRoZW4gZnVs bCByZS1yZXZpZXdzCm5lZWQgdG8gaGFwcGVuIGFueXdheSBvbiBsYXRlciB2ZXJzaW9ucywgdG8g YWxzbyBkZWFsIHdpdGggdGhlIG1pbm9yCmlzc3Vlcy4gRm9yIFJGQyBraW5kIG9mIHNlcmllcyBv bWl0dGluZyBzdHlsZSBhbmQgYWxpa2UgZmVlZGJhY2sKY2VydGFpbmx5IG1ha2VzIHNlbnNlLCBi dXQgYXMgc29vbiBhcyBhIHBhdGNoIGlzIG5vbi1SRkMsIGl0IHNob3VsZApiZSBjb25zaWRlcmVk IGdvb2QgdG8gZ28gaW4gYnkgdGhlIHN1Ym1pdHRlci4KCkphbgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWFwaSBtYWlsaW5nIGxpc3QKWGVuLWFw aUBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxt YW4vbGlzdGluZm8veGVuLWFwaQo= From xen-api-bounces@lists.xenproject.org Thu Nov 28 14:02:41 2019 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Nov 2019 14:02:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaKNS-0003zE-Op; Thu, 28 Nov 2019 14:02:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaKNR-0003z9-Es for xen-api@lists.xenproject.org; Thu, 28 Nov 2019 14:02:37 +0000 X-Inumbo-ID: bb02dbd6-11e7-11ea-83b8-bc764e2007e4 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id bb02dbd6-11e7-11ea-83b8-bc764e2007e4; Thu, 28 Nov 2019 14:02:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1574949757; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=XmruZdKk8gM9fXXLnaWLAOgbE4mFRUQcYA/5rc5I3l8=; b=AlUolTDjVrna3AAxofwm7CoSZ715063RY0R6WK6dw2q2u+VYeELjMFAj UYcGmPFPscGKutFSm8pVfmZjDzHzTQPT86mrW6XMRxijyqHJg6HF8UAVl uiWdYQ1cyrar5avFV1MmQwOGPlwvMe3VeZOXIbmh1Jd3QlbTrwmYRF2Ef Q=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=lars.kurth@citrix.com; spf=Pass smtp.mailfrom=lars.kurth@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of lars.kurth@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="lars.kurth@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of lars.kurth@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="lars.kurth@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: kSLlZg7z4c7bm2KMbkJX5ouLzvxkDgxSG2LP4O0cTgsoJeC9yGoQtQI3lqY9Bs0n8Ia+z3oLz2 23IMx14+03qBaL3zt7FBiLU0Aq02CEgBiqnPh0YNqcy/9JLzFX7zWJyuzglHWuOvgtK9teVF0f P9Io+brr8xmnU9Iai44yedWvf1WKH+aP7u0MeN66dw12ym125eIFMoW/cG9EVc4+Mlg2S9lXxn PfI7NhfpzQEF5C/t2Jxrjdl58QlRx0IEAL4if2ywpKS+F1n4qqJbWntOducX1swWsyh6KxgdVN p38= X-SBRS: 2.7 X-MesageID: 8959416 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.69,253,1571716800"; d="scan'208";a="8959416" From: Lars Kurth To: Jan Beulich , Lars Kurth Thread-Topic: [PATCH v2 4/6] Add Code Review Guide Thread-Index: AQHVpfEGwl/VxYnE9Uydtksy7w4pxaegJ7iA Date: Thu, 28 Nov 2019 14:02:32 +0000 Message-ID: References: <97e3adf75cf71ba39e702d4cab23236ada8d5a6c.1569525222.git.lars.kurth@citrix.com> <909826df-25c1-6d7c-75d9-470365d2ecf6@suse.com> <2200B0A8-0EDE-4843-A5D3-A84F2D01333D@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/10.10.10.191111 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted Content-ID: MIME-Version: 1.0 Subject: Re: [Xen-API] [PATCH v2 4/6] Add Code Review Guide X-BeenThere: xen-api@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: User and development list for XCP and XAPI List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , "xen-api@lists.xenproject.org" , "minios-devel@lists.xenproject.org" , "committers@xenproject.org" , "mirageos-devel@lists.xenproject.org" , "xen-devel@lists.xenproject.org" , "win-pv-devel@lists.xenproject.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-api-bounces@lists.xenproject.org Sender: "Xen-api" DQoNCu+7v09uIDI4LzExLzIwMTksIDA3OjM3LCAiSmFuIEJldWxpY2giIDxqYmV1bGljaEBzdXNl LmNvbT4gd3JvdGU6DQoNCiAgICBPbiAyOC4xMS4yMDE5IDE0OjA2LCBMYXJzIEt1cnRoIHdyb3Rl Og0KICAgID4gSSBjYW4gY2VydGFpbmx5IGFkZCBzb21ldGhpbmcgb24gdGhlIHRpbWluZyAsIGFs b25nIHRoZSBsaW5lcyBvZg0KICAgID4gKiBGb3IgY29tcGxleCBzZXJpZXMsIGNvbnNpZGVyIHRo ZSB0aW1lIGl0IHRha2VzIHRvIGRvIHJldmlld3MgKG1heWJlIHdpdGggYSBndWlkZSBvZiBMT0Mg cGVyIGhvdXIpIGFuZCBnaXZlIHJldmlld2VycyBlbm91Z2ggdGltZSB0bw0KICAgID4gKiBGb3Ig c2VyaWVzIHdpdGggZGVzaWduIGlzc3VlcyBvciBsYXJnZSBxdWVzdGlvbnMsIHRyeSBhbmQgaGln aGxpZ2h0IHRoZSBrZXkgb3BlbiBpc3N1ZXMgaW4gY292ZXIgbGV0dGVycyBjbGVhcmx5IGFuZCBz b2xpY2l0IGZlZWRiYWNrIGZyb20ga2V5IG1haW50YWluZXJzIHdobyBjYW4gY29tbWVudCBvbiB0 aGUgb3BlbiBpc3N1ZS4gVGhlIGlkZWEgaXMgdG8gc2F2ZSBib3RoIHRoZSBjb250cmlidXRvciBh bmQgdGhlIHJldmlld2VycyB0aW1lIGJ5IGZvY3Vzc2luZyBvbiB3aGF0IG5lZWRzIHRvIGJlIHJl c29sdmVkIA0KICAgID4gKiBEb27igJl0IHJlcG9zdCBhIHNlcmllcywgdW5sZXNzIGFsbCByZXZp ZXcgY29tbWVudHMgYXJlIGFkZHJlc3NlZA0KICAgID4gb3IgdGhlIHJldmlld2VycyBhc2tlZCB5 b3UgdG8gZG8gc28uIFRoZSBwcm9ibGVtIHdpdGggdGhpcyBpcyB0aGF0DQogICAgPiB0aGlzIGlz IHNvbWV3aGF0IGluIGNvbmZsaWN0IHdpdGggdGhlICJsZXQncyBmb2N1cyBvbiB0aGUgY29yZQ0K ICAgID4gaXNzdWVzIGFuZCBub3QgZ2V0IGRpc3RyYWN0ZWQgYnkgZGV0YWlscyBlYXJseSBvbiBp biBhIHJldmlldyBjeWNsZSIuDQogICAgPiBJbiBvdGhlciB3b3JkcywgdGhpcyBjYW4gb25seSB3 b3JrLCBpZiByZXZpZXdlcnMgZm9jdXMgb24gbWFqb3INCiAgICA+IGlzc3VlcyBpbiBlYXJseSBy ZXZpZXdzIG9ubHkgYW5kIGRvIG5vdCBmb2N1cyBvbiBzdHlsZSwgY29kaW5nDQogICAgPiBzdGFu ZGFyZHMsIGV0Yy4NCiAgICANCiAgICBCdXQgdGhpcyBkb2Vzbid0IG1ha2UgbXVjaCBzZW5zZSBl aXRoZXIsIGJlY2F1c2UgdGhlbiBmdWxsIHJlLXJldmlld3MNCiAgICBuZWVkIHRvIGhhcHBlbiBh bnl3YXkgb24gbGF0ZXIgdmVyc2lvbnMsIHRvIGFsc28gZGVhbCB3aXRoIHRoZSBtaW5vcg0KICAg IGlzc3Vlcy4gRm9yIFJGQyBraW5kIG9mIHNlcmllcyBvbWl0dGluZyBzdHlsZSBhbmQgYWxpa2Ug ZmVlZGJhY2sNCiAgICBjZXJ0YWlubHkgbWFrZXMgc2Vuc2UsIGJ1dCBhcyBzb29uIGFzIGEgcGF0 Y2ggaXMgbm9uLVJGQywgaXQgc2hvdWxkDQogICAgYmUgY29uc2lkZXJlZCBnb29kIHRvIGdvIGlu IGJ5IHRoZSBzdWJtaXR0ZXIuDQogICAgDQpPSywgSSB0aGluayB3ZSBoYXZlIGEgZGlzY29ubmVj dCBiZXR3ZWVuIGlkZWFsIGFuZCByZWFsaXR5LiANCg0KSSBzZWUgdHdvIGlzc3VlcyB0b2RheQ0K KiBLZXkgbWFpbnRhaW5lcnMgZG9uJ3QgYWx3YXlzIHJldmlldyBSRkMgc2VyaWVzIFt0aGV5IGVu ZCB1cCBhdCB0aGUgYm90dG9tIG9mIHRoZSBwcmlvcml0eSBsaXN0LCBldmVuIHRob3VnaCBzcGVu ZGluZyB0aW1lIG9uIFJGQ3Mgd2lsbCBzYXZlIHRpbWUgZWxzZXdoZXJlIGxhdGVyXS4gU28gdGhl IGVmZmVjdCBpcyB0aGF0IHRoZW4gdGhlIGNvbnRyaWJ1dG9yIGFzc3VtZXMgdGhlcmUgYXJlIG5v IG1ham9yIGlzc3VlcyBhbmQgZW5kcyBpdCBhcyBhIHByb3BlciBzZXJpZXMNCiogSW4gcHJhY3Rp Y2Ugd2hhdCBoYXMgaGFwcGVuZWQgb2Z0ZW4gaW4gdGhlIHBhc3QgaXMgdGhhdCBkZXNpZ24sIGFy Y2hpdGVjdHVyZSwgYXNzdW1wdGlvbiBmbGF3cyBhcmUgZm91bmQgaW4gZWFybHkgdmVyc2lvbnMg b2YgYSBzZXJpZXMuDQogICAtIFRoaXMgdXN1YWxseSBoYXBwZW5zIGJlY2F1c2Ugb2YgYW4gb3Zl cnNpZ2h0IG9yIGJlY2F1c2UgdGhlcmUgd2FzIG5vIGRlc2lnbiBkaXNjdXNzaW9uIHByaW9yIHRv IHRoZSBzZXJpZXMgYmVpbmcgcG9zdGVkIGFuZCBhZ3JlZWQNCiAgIC0gQ29tbW9uIHNlbnNlIHdv dWxkIGRpY3RhdGUgdGhhdCB0aGUgYmlnZ2VzdCBiZW5lZml0IGZvciBib3RoIHRoZSByZXZpZXdl ciwgdGhlIGNvbnRyaWJ1dG9yIGFuZCB0aGUgY29tbXVuaXR5IGFzIGEgd2hvbGUgd291bGQgYmUg dG8gdHJ5IGFuZCBmb2N1cyBvbiBzdWNoIGZsYXdzIGFuZCBsZWF2ZSBldmVyeXRoaW5nIGFzaWRl DQogICAtIE9mIGNvdXJzZSB0aGVyZSBtYXkgYmUgdmFsdWUgaW4gZG9pbmcgYSBkZXRhaWxlZCBy ZXZpZXdzIG9mIHN1Y2ggYSBzZXJpZXMgYXMgdGhlcmUgbWF5IGJlIGJpdHMgdGhhdCBhcmUgdW5h ZmZlY3RlZCBieSBzdWNoIGEgZmxhdw0KICAgLSBCdXQgdGhlcmUgd2lsbCBsaWtlbHkgYmUgcGFy dHMgd2hpY2ggYXJlIG5vdDogZG9pbmcgYSBkZXRhaWxlZCByZXZpZXcgb2Ygc3VjaCBwb3J0aW9u cyB3YXN0ZXMgZXZlcnlvbmUncyB0aW1lDQoNClNvIGNvbWluZyBiYWNrIHRvIHlvdXIgcG9pbnQu IElkZWFsbHksIGl0IHdvdWxkIGJlIG5pY2UgaWYgd2UgaGFkIHRoZSBjYXBhYmlsaXR5IHRvIGNh bGwgb3V0IHBhcnRzIG9mIGEgc2VyaWVzIGFzICJwcm9ibGVtYXRpYyIgYW5kIHRyZWF0aW5nIHN1 Y2ggcGFydHMgZGlmZmVyZW50bHkNCg0KTGFycw0KDQpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpYZW4tYXBpIG1haWxpbmcgbGlzdApYZW4tYXBpQGxpc3Rz LnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0 aW5mby94ZW4tYXBpCg== From xen-api-bounces@lists.xenproject.org Fri Nov 29 00:00:44 2019 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Nov 2019 00:00:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaTi9-0006zn-I4; Fri, 29 Nov 2019 00:00:37 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaTi8-0006zg-N0 for xen-api@lists.xenproject.org; Fri, 29 Nov 2019 00:00:36 +0000 X-Inumbo-ID: 3817d9ca-123b-11ea-a3da-12813bfff9fa Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3817d9ca-123b-11ea-a3da-12813bfff9fa; Fri, 29 Nov 2019 00:00:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1574985615; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=Ut1U3DFJ7ARr1RcJca9q+W7bCxJ48hIhQRyfFTlnaFA=; b=S4sZsS23tBx/fH7G0RnuD+vTRZ9SjRBgPAd0EDHAVjDx8ab25FcWgpGU +JCbYhbxQFaiEUnt9aCxbsON+sDYIBKj+B8P/Y6vMXT/JDwdAA4wBH8a3 OQHYpf44IUtb4jJe2LsXkdiOs3pcvledO1f7scDlYY7g1/DFDSZASiee6 s=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=lars.kurth@citrix.com; spf=Pass smtp.mailfrom=lars.kurth@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of lars.kurth@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="lars.kurth@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of lars.kurth@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="lars.kurth@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: Lg8Kjm/mvjdh0wQNa9UShx3olTCd9W+BaOKN+czMQDQOf3fRUWHHCarrE++XL5Xhxidq5UwCGX 7kdooUDlZSKsr4zLheqnUQsU9Blwgg9YiU6ucXWtS3p+BfoNFKqoHNiCSTorji0w8Rnsbu4FvF j0DDeuUsLfxbeLuXBz+B4S/N4YQbz4zk5mIDbIgsi5MFBjCe3iMuDAu7LXpOHhepBtVB//rq6T DfvAzNU/LrecHtKOGD/8G8fXRwKQQAPymTjtfT9wDbDBTAVw6eFFzaJjNXjMcxmG86OAk9ZkQY dJo= X-SBRS: 2.7 X-MesageID: 8971799 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.69,255,1571716800"; d="scan'208";a="8971799" From: Lars Kurth To: Stefano Stabellini , Lars Kurth Thread-Topic: [PATCH v2 5/6] Add guide on Communication Best Practice Thread-Index: AQHVdKIoBNlHjnrbLUK7o4oIKuieK6egE6kAgAEdpgA= Date: Fri, 29 Nov 2019 00:00:08 +0000 Message-ID: <8DAF896F-6BFF-4126-84C7-6C0161FBE3EF@citrix.com> References: <749f082bdb996ba7c7362847b22030882dc2903f.1569525222.git.lars.kurth@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/10.10.10.191111 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted Content-ID: MIME-Version: 1.0 Subject: Re: [Xen-API] [PATCH v2 5/6] Add guide on Communication Best Practice X-BeenThere: xen-api@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: User and development list for XCP and XAPI List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-api@lists.xenproject.org" , "minios-devel@lists.xenproject.org" , "committers@xenproject.org" , "mirageos-devel@lists.xenproject.org" , "xen-devel@lists.xenproject.org" , "win-pv-devel@lists.xenproject.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-api-bounces@lists.xenproject.org Sender: "Xen-api" DQoNCu+7v09uIDI3LzExLzIwMTksIDE4OjU3LCAiU3RlZmFubyBTdGFiZWxsaW5pIiA8c3N0YWJl bGxpbmlAa2VybmVsLm9yZz4gd3JvdGU6DQoNCiAgICBPbiBUaHUsIDI2IFNlcCAyMDE5LCBMYXJz IEt1cnRoIHdyb3RlOg0KICAgID4gRnJvbTogTGFycyBLdXJ0aCA8bGFycy5rdXJ0aEBjaXRyaXgu Y29tPg0KICAgID4gDQogICAgPiBUaGlzIGd1aWRlIGNvdmVycyB0aGUgYnVsayBvbiBCZXN0IFBy YWN0aWNlIHJlbGF0ZWQgdG8gY29kZSByZXZpZXcNCiAgICA+IEl0IHByaW1hcmlseSBmb2N1c3Nl cyBvbiBjb2RlIHJldmlldyBpbnRlcmFjdGlvbnMNCiAgICA+IEl0IGFsc28gY292ZXJzIGhvdyB0 byBkZWFsIHdpdGggTWlzdW5kZXJzdGFuZGluZ3MgYW5kIEN1bHR1cmFsDQogICAgPiBEaWZmZXJl bmNlcw0KICAgID4gDQogICAgPiBTaWduZWQtb2ZmLWJ5OiBMYXJzIEt1cnRoIDxsYXJzLmt1cnRo QGNpdHJpeC5jb20+DQogICAgPiAtLS0NCiAgICA+IENjOiBtaW5pb3MtZGV2ZWxAbGlzdHMueGVu cHJvamVjdC5vcmcNCiAgICA+IENjOiB4ZW4tYXBpQGxpc3RzLnhlbnByb2plY3Qub3JnDQogICAg PiBDYzogd2luLXB2LWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQogICAgPiBDYzogbWlyYWdl b3MtZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcNCiAgICA+IENjOiBjb21taXR0ZXJzQHhlbnBy b2plY3Qub3JnDQogICAgPiAtLS0NCiAgICA+ICBjb21tdW5pY2F0aW9uLXByYWN0aWNlLm1kIHwg NDEwICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysNCiAgICA+ ICAxIGZpbGUgY2hhbmdlZCwgNDEwIGluc2VydGlvbnMoKykNCiAgICA+ICBjcmVhdGUgbW9kZSAx MDA2NDQgY29tbXVuaWNhdGlvbi1wcmFjdGljZS5tZA0KICAgID4gDQogICAgPiBkaWZmIC0tZ2l0 IGEvY29tbXVuaWNhdGlvbi1wcmFjdGljZS5tZCBiL2NvbW11bmljYXRpb24tcHJhY3RpY2UubWQN CiAgICA+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0DQogICAgPiBpbmRleCAwMDAwMDAwLi5kYjlhNWVm DQogICAgPiAtLS0gL2Rldi9udWxsDQogICAgPiArKysgYi9jb21tdW5pY2F0aW9uLXByYWN0aWNl Lm1kDQogICAgPiBAQCAtMCwwICsxLDQxMCBAQA0KICAgID4gKyMgQ29tbXVuaWNhdGlvbiBCZXN0 IFByYWN0aWNlDQogICAgPiArDQogICAgPiArVGhpcyBndWlkZSBwcm92aWRlcyBjb21tdW5pY2F0 aW9uIEJlc3QgUHJhY3RpY2UgdGhhdCBoZWxwcyB5b3UgaW4NCiAgICA+ICsqIFVzaW5nIHdlbGNv bWluZyBhbmQgaW5jbHVzaXZlIGxhbmd1YWdlDQogICAgPiArKiBLZWVwaW5nIGRpc2N1c3Npb25z IHRlY2huaWNhbCBhbmQgYWN0aW9uYWJsZQ0KICAgID4gKyogQmVpbmcgcmVzcGVjdGZ1bCBvZiBk aWZmZXJpbmcgdmlld3BvaW50cyBhbmQgZXhwZXJpZW5jZXMNCiAgICA+ICsqIEJlaW5nIGF3YXJl IG9mIHlvdXIgb3duIGFuZCBjb3VudGVycGFydOKAmXMgY29tbXVuaWNhdGlvbiBzdHlsZSBhbmQg Y3VsdHVyZQ0KICAgID4gKyogU2hvdyBlbXBhdGh5IHRvd2FyZHMgb3RoZXIgY29tbXVuaXR5IG1l bWJlcnMNCiAgICA+ICsNCiAgICA+ICsjIyBDb2RlIHJldmlld3MgZm9yICoqcmV2aWV3ZXJzKiog YW5kICoqcGF0Y2ggYXV0aG9ycyoqDQogICAgPiArDQogICAgPiArQmVmb3JlIGVtYmFya2luZyBv biBhIGNvZGUgcmV2aWV3LCBpdCBpcyBpbXBvcnRhbnQgdG8gcmVtZW1iZXIgdGhhdA0KICAgID4g KyogQSBwb29ybHkgZXhlY3V0ZWQgY29kZSByZXZpZXcgY2FuIGh1cnQgdGhlIGNvbnRyaWJ1dG9y cyBmZWVsaW5nLCBldmVuIHdoZW4gYSByZXZpZXdlcg0KICAgID4gKyAgZGlkIG5vdCBpbnRlbmQg dG8gZG8gc28uIEZlZWxpbmcgZGVmZW5zaXZlIGlzIGEgbm9ybWFsIHJlYWN0aW9uIHRvIGEgY3Jp dGlxdWUgb3IgZmVlZGJhY2suDQogICAgPiArICBBIHJldmlld2VyIHNob3VsZCBiZSBhd2FyZSBv ZiBob3cgdGhlIHBpdGNoLCB0b25lLCBvciBzZW50aW1lbnQgb2YgdGhlaXIgY29tbWVudHMNCiAg ICA+ICsgIGNvdWxkIGJlIGludGVycHJldGVkIGJ5IHRoZSBjb250cmlidXRvci4gVGhlIHNhbWUg YXBwbGllcyB0byByZXNwb25zZXMgb2YgYW4gYXV0aG9yDQogICAgPiArICB0byB0aGUgcmV2aWV3 ZXIuDQogICAgPiArKiBXaGVuIHJldmlld2luZyBzb21lb25lJ3MgY29kZSwgeW91IGFyZSB1bHRp bWF0ZWx5IGxvb2tpbmcgZm9yIGlzc3Vlcy4gQSBnb29kIGNvZGUNCiAgICA+ICsgIHJldmlld2Vy IGlzIGFibGUgdG8gbWVudGFsbHkgc2VwYXJhdGUgZmluZGluZyBpc3N1ZXMgZnJvbSBhcnRpY3Vs YXRpbmcgY29kZSByZXZpZXcNCiAgICA+ICsgIGNvbW1lbnRzIGluIGEgY29uc3RydWN0aXZlIGFu ZCBwb3NpdGl2ZSBtYW5uZXI6IGRlcGVuZGluZyBvbiB5b3VyIHBlcnNvbmFsaXR5IHRoaXMNCiAg ICA+ICsgIGNhbiBiZSAqKmRpZmZpY3VsdCoqIGFuZCB5b3UgbWF5IG5lZWQgdG8gZGV2ZWxvcCBh IHRlY2huaXF1ZSB0aGF0IHdvcmtzIGZvciB5b3UuDQogICAgPiArKiBBcyBzb2Z0d2FyZSBlbmdp bmVlcnMgd2UgbGlrZSB0byBiZSBwcm91ZCBvZiB0aGUgc29sdXRpb25zIHdlIGNhbWUgdXAgd2l0 aC4gVGhpcyBjYW4NCiAgICA+ICsgIG1ha2UgaXQgZWFzeSB0byB0YWtlIGFub3RoZXIgcGVvcGxl 4oCZcyBjcml0aWNpc20gcGVyc29uYWxseS4gQWx3YXlzIHJlbWVtYmVyIHRoYXQgaXQgaXMNCiAg ICA+ICsgIHRoZSBjb2RlIHRoYXQgaXMgYmVpbmcgcmV2aWV3ZWQsIG5vdCB5b3UgYXMgYSBwZXJz b24uDQogICAgPiArKiBXaGVuIHlvdSByZWNlaXZlIGNvZGUgcmV2aWV3IGZlZWRiYWNrLCBwbGVh c2UgYmUgYXdhcmUgdGhhdCB3ZSBoYXZlIHJldmlld2Vycw0KICAgID4gKyAgZnJvbSBkaWZmZXJl bnQgYmFja2dyb3VuZHMsIGNvbW11bmljYXRpb24gc3R5bGVzIGFuZCBjdWx0dXJlcy4gQWx0aG91 Z2ggd2UgYWxsIHRyeWluZw0KICAgID4gKyAgdG8gY3JlYXRlIGEgcHJvZHVjdGl2ZSwgd2VsY29t aW5nIGFuZCBhZ2lsZSBlbnZpcm9ubWVudCwgd2UgZG8gbm90IGFsd2F5cyBzdWNjZWVkLg0KICAg ID4gKw0KICAgID4gKyMjIyBFeHByZXNzIGFwcHJlY2lhdGlvbg0KICAgID4gK0FzIHRoZSBuYXR1 cmUgb2YgY29kZSByZXZpZXcgdG8gZmluZCBidWdzIGFuZCBwb3NzaWJsZSBpc3N1ZXMsIGl0IGlz IHZlcnkgZWFzeSBmb3INCiAgICA+ICtyZXZpZXdlcnMgdG8gZ2V0IGludG8gYSBtb2RlIG9mIG9w ZXJhdGlvbiB3aGVyZSB0aGUgcGF0Y2ggcmV2aWV3IGVuZHMgdXAgYmVpbmcgYSBsaXN0DQogICAg PiArb2YgaXNzdWVzLCBub3QgbWVudGlvbmluZyB3aGF0IGlzIHJpZ2h0IGFuZCB3ZWxsIGRvbmUu IFRoaXMgY2FuIGxlYWQgdG8gdGhlIGNvZGUNCiAgICA+ICtzdWJtaXR0ZXIgaW50ZXJwcmV0aW5n IHlvdXIgZmVlZGJhY2sgaW4gYSBuZWdhdGl2ZSB3YXkuDQogICAgPiArDQogICAgPiArVGhlIG9w ZW5pbmcgb2YgYSBjb2RlIHJldmlldyBwcm92aWRlcyBhbiBvcHBvcnR1bml0eSB0byBhZGRyZXNz IHRoaXMgYW5kIGFsc28gc2V0cyB0aGUNCiAgICA+ICt0b25lIGZvciB0aGUgcmVzdCBvZiB0aGUg Y29kZSByZXZpZXcuIFN0YXJ0aW5nICoqZXZlcnkqKiByZXZpZXcgb24gYSBwb3NpdGl2ZSBub3Rl LCBoZWxwcw0KICAgID4gK3NldCB0aGUgdG9uZSBmb3IgdGhlIHJlc3Qgb2YgdGhlIHJldmlldy4N CiAgICA+ICsNCiAgICA+ICtGb3IgYW4gaW5pdGlhbCBwYXRjaCwgeW91IGNhbiB1c2UgcGhyYXNl cyBzdWNoIGFzDQogICAgPiArPiBUaGFua3MgZm9yIHRoZSBwYXRjaA0KICAgID4gKz4gVGhhbmtz IGZvciBkb2luZyB0aGlzDQogICAgPiArDQogICAgPiArRm9yIGZ1cnRoZXIgcmV2aXNpb25zIHdp dGhpbiBhIHJldmlldywgcGhyYXNlcyBzdWNoIGFzDQogICAgPiArPiBUaGFuayB5b3UgZm9yIGFk ZHJlc3NpbmcgdGhlIGxhc3Qgc2V0IG9mIGNoYW5nZXMNCiAgICA+ICsNCiAgICA+ICtJZiB5b3Ug YmVsaWV2ZSB0aGUgY29kZSB3YXMgZ29vZCwgaXQgaXMgZ29vZCBwcmFjdGljZSB0byBoaWdobGln aHQgdGhpcyBieSB1c2luZyBwaHJhc2VzDQogICAgPiArc3VjaCBhcw0KICAgID4gKz4gTG9va3Mg Z29vZCwganVzdCBhIGZldyBjb21tZW50cw0KICAgID4gKz4gVGhlIGNoYW5nZXMgeW91IGhhdmUg bWFkZSBzaW5jZSB0aGUgbGFzdCB2ZXJzaW9uIGxvb2sgZ29vZA0KICAgID4gKw0KICAgID4gK0lm IHlvdSB0aGluayB0aGVyZSB3ZXJlIGlzc3VlcyB0b28gbWFueSB3aXRoIHRoZSBjb2RlIHRvIHVz ZSBvbmUgb2YgdGhlIHBocmFzZXMsDQogICAgPiAreW91IGNhbiBzdGlsbCBzdGFydCBvbiBhIHBv c2l0aXZlIG5vdGUsIGJ5IGZvciBleGFtcGxlIHNheWluZw0KICAgID4gKz4gSSB0aGluayB0aGlz IGlzIGEgZ29vZCBjaGFuZ2UNCiAgICA+ICs+IEkgdGhpbmsgdGhpcyBpcyBhIGdvb2QgZmVhdHVy ZSBwcm9wb3NhbA0KICAgID4gKw0KICAgID4gK0l0IGlzIGFsc28gZW50aXJlbHkgZmluZSB0byBo aWdobGlnaHQgc3BlY2lmaWMgY2hhbmdlcyBhcyBnb29kLiBUaGUgYmVzdCBwbGFjZSB0bw0KICAg ID4gK2RvIHRoaXMsIGlzIGF0IHRvcCBvZiBhIHBhdGNoLCBhcyBhZGRyZXNzaW5nIGNvZGUgcmV2 aWV3IGNvbW1lbnRzIHR5cGljYWxseSByZXF1aXJlcw0KICAgICAgICAgICAgICAgICAgICAgXiB0 aGUgdG9wDQogICAgDQogICAgDQogICAgPiArYSBjb250cmlidXRvciB0byBnbyB0aHJvdWdoIHRo ZSBsaXN0IG9mIHRoaW5ncyB0byBhZGRyZXNzIGFuZCBhbiBpbi1saW5lZCBwb3NpdGl2ZQ0KICAg ID4gK2NvbW1lbnQgaXMgbGlrZWx5IHRvIGJyZWFrIHRoYXQgd29ya2Zsb3cuDQogICAgPiArDQog ICAgPiArWW91IHNob3VsZCBhbHNvIGNvbnNpZGVyLCB0aGF0IGlmIHlvdSByZXZpZXcgYSBwYXRj aCBvZiBhbiBleHBlcmllbmNlZA0KICAgID4gK2NvbnRyaWJ1dG9yIHBocmFzZXMgc3VjaCBhcyAq VGhhbmtzIGZvciB0aGUgcGF0Y2gqIGNvdWxkIGNvbWUgYWNyb3NzIGFzDQogICAgPiArcGF0cm9u aXppbmcsIHdoaWxlIHVzaW5nICpUaGFua3MgZm9yIGRvaW5nIHRoaXMqIGlzIGxlc3MgbGlrZWx5 IHRvIGJlIGludGVycHJldGVkDQogICAgPiArYXMgc3VjaC4NCiAgICA+ICsNCiAgICA+ICtBcHBy ZWNpYXRpb24gc2hvdWxkIGFsc28gYmUgZXhwcmVzc2VkIGJ5IHBhdGNoIGF1dGhvcnMgd2hlbiBh c2tpbmcgZm9yIGNsYXJpZmljYXRpb25zDQogICAgPiArdG8gYSByZXZpZXcgb3IgcmVzcG9uZGlu ZyB0byBxdWVzdGlvbnMuIEEgc2ltcGxlDQogICAgPiArPiBUaGFuayB5b3UgZm9yIHlvdXIgZmVl ZGJhY2sNCiAgICA+ICs+IFRoYW5rIHlvdSBmb3IgeW91ciByZXBseQ0KICAgID4gKz4gVGhhbmsg eW91IFhYWCENCiAgICA+ICsNCiAgICA+ICtpcyBub3JtYWxseSBzdWZmaWNpZW50Lg0KICAgID4g Kw0KICAgID4gKyMjIyBBdm9pZCBvcGluaW9uOiBzdGljayB0byB0aGUgZmFjdHMNCiAgICA+ICtU aGUgd2F5IGhvdyBhIHJldmlld2VyIGV4cHJlc3NlcyBmZWVkYmFjaywgaGFzIGEgYmlnIGltcGFj dCBvbiBob3cgdGhlIGF1dGhvcg0KICAgID4gK3BlcmNlaXZlcyB0aGUgZmVlZGJhY2suIEtleSB0 byB0aGlzIGlzIHdoYXQgd2UgY2FsbCAqKnN0aWNrIHRvIHRoZSBmYWN0cyoqLiAgVGhlIHNhbWUg aXMNCiAgICA+ICt0cnVlIHdoZW4gYSBwYXRjaCBhdXRob3IgaXMgcmVzcG9uZGluZyB0byBhIGNv bW1lbnQgZnJvbSBhIHJldmlld2VyLg0KICAgID4gKw0KICAgID4gK09uZSBvZiBvdXIgbWFpbnRh aW5lcnMgaGFzIGJlZW4gc3R1ZHlpbmcgTWFuZGFyaW4gZm9yIHNldmVyYWwgeWVhcnMgYW5kIGhh cyBjb21lDQogICAgPiArYWNyb3NzIHRoZSBtb3N0IHN0cm9uZ2x5LXdvcmRlZCBkaWN0aW9uYXJ5 IGVudHJ5DQogICAgPiArW2hlIGhhcyBldmVyIHNlZW5dKGh0dHBzOi8veW91dHUuYmUvZWhadkJt ckxSd2c/dD04MzQpLiBUaGlzIGV4YW1wbGUNCiAgICA+ICtpbGx1c3RyYXRlcyB0aGUgcHJvYmxl bSBvZiB1c2luZyBvcGluaW9uIGluIGNvZGUgcmV2aWV3cyB2cy4gdXNpbmcgZmFjdHMgZXh0cmVt ZWx5IHdlbGwuDQogICAgPiArDQogICAgPiArPiDoo7nohJogKGd1bzMgamlhbzMpOiBmb290LWJp bmRpbmcgKGEgdmlsZSBmZXVkYWwgcHJhY3RpY2Ugd2hpY2ggY3JpcHBsZWQgd29tZW4gYm90aA0K ICAgID4gKz4gcGh5c2ljYWxseSBhbmQgc3Bpcml0dWFsbHkpDQogICAgPiArDQogICAgPiArVGhp cyBpcyBub3Qgc29tZXRoaW5nIG9uZSBpcyB1c2VkIHRvIGhlYXJpbmcgZnJvbSBkaWN0aW9uYXJ5 IGVudHJpZXMuIE9uY2UgeW91DQogICAgPiAraW52ZXN0aWdhdGUgdGhlIHByYWN0aWNlIGZvb3Qt YmluZGluZywgaXQgaXMgaGFyZCB0byBkaXNhZ3JlZSB3aXRoIHRoZSBkaWN0aW9uYXJ0IGVudHJ5 Lg0KICAgID4gK0hvd2V2ZXIsIHRoZSBzdGF0ZW1lbnQgZG9lcyBub3QgY29udGFpbiBtdWNoIGlu Zm9ybWF0aW9uLiBJZiB5b3UgcmVhZCBpdCB3aXRob3V0DQogICAgPiAra25vd2luZyB3aGF0IGZv b3QtYmluZGluZyBpcywgaXQgaXMgaGFyZCB0byBiZSBjb252aW5jZWQgYnkgdGhpcyBzdGF0ZW1l bnQuIFRoZSBtYWluDQogICAgPiArdGFrZS1hd2F5IGlzIHRoYXQgdGhlIGF1dGhvciBvZiB0aGUg ZGljdGlvbmFyeSBlbnRyeSBoYWQgc3Ryb25nIG9waW5pb25zIGFib3V0IHRoaXMgdG9waWMuDQog ICAgPiArSXQgZG9lcyBub3QgdGVsbCB5b3UsIHdoeSB5b3Ugc2hvdWxkIGhhdmUgdGhlIHNhbWUg b3Bpbmlvbi4NCiAgICAgICAgICAgICAgICAgICAgICAgICAgIF4gcmVtb3ZlICwNCiAgICANCiAg ICA+ICsNCiAgICA+ICtDb21wYXJlIHRoaXMgdG8gdGhlIChXaWtpcGVkaWEgZW50cnkpW2h0dHBz Oi8vZW4ud2lraXBlZGlhLm9yZy93aWtpL0Zvb3RfYmluZGluZ10NCiAgICA+ICsNCiAgICA+ICs+ IEZvb3QgYmluZGluZyB3YXMgdGhlIGN1c3RvbSBvZiBhcHBseWluZyB0aWdodCBiaW5kaW5nIHRv IHRoZSBmZWV0IG9mIHlvdW5nIGdpcmxzIHRvDQogICAgPiArPiBtb2RpZnkgdGhlIHNoYXBlIGFu ZCBzaXplIG9mIHRoZWlyIGZlZXQuIC4uLiBmb290IGJpbmRpbmcgd2FzIGEgcGFpbmZ1bCBwcmFj dGljZSBhbmQNCiAgICA+ICs+IHNpZ25pZmljYW50bHkgbGltaXRlZCB0aGUgbW9iaWxpdHkgb2Yg d29tZW4sIHJlc3VsdGluZyBpbiBsaWZlbG9uZyBkaXNhYmlsaXRpZXMgZm9yIG1vc3Qgb2YNCiAg ICA+ICs+IGl0cyBzdWJqZWN0cy4gLi4uIEJpbmRpbmcgdXN1YWxseSBzdGFydGVkIGR1cmluZyB0 aGUgd2ludGVyIG1vbnRocyBzaW5jZSB0aGUgZmVldCB3ZXJlDQogICAgPiArPiBtb3JlIGxpa2Vs eSB0byBiZSBudW1iLCBhbmQgdGhlcmVmb3JlIHRoZSBwYWluIHdvdWxkIG5vdCBiZSBhcyBleHRy ZW1lLiDigKZUaGUgdG9lcyBvbg0KICAgID4gKz4gZWFjaCBmb290IHdlcmUgY3VybGVkIHVuZGVy LCB0aGVuIHByZXNzZWQgd2l0aCBncmVhdCBmb3JjZSBkb3dud2FyZHMgYW5kIHNxdWVlemVkDQog ICAgPiArPiBpbnRvIHRoZSBzb2xlIG9mIHRoZSBmb290IHVudGlsIHRoZSB0b2VzIGJyb2tl4oCm DQogICAgPiArDQogICAgPiArV2l0aG91dCBnb2luZyBpbnRvIHRoZSBkZXRhaWxzIG9mIGZvb3Qt YmluZGluZywgaXQgaXMgbm90aWNlYWJsZSB0aGF0IG5vbmUgb2Ygd2hhdCBpcyB3cml0dGVuDQog ICAgPiArYWJvdmUgdXNlcyBvcGluaW9uIHdoaWNoIGNvdWxkIGJlIGludGVycHJldGVkIGFzIGlu ZmxhbW1hdG9yeSBsYW5ndWFnZS4gSXQgaXMgYSBsaXN0IG9mDQogICAgPiArc2ltcGxlIGZhY3Rz IHRoYXQgYXJlIGxhaWQgb3V0IGluIGEgd2F5IHRoYXQgbWFrZSBpdCBvYnZpb3VzIHdoYXQgdGhl IGNvcnJlY3QgY29uY2x1c2lvbg0KICAgID4gK2lzLg0KICAgID4gKw0KICAgID4gK0JlY2F1c2Ug dGhlIFdpa2lwZWRpYSBlbnRyeSBpcyBlbnRpcmVseSBmYWN0IGJhc2VkIGl0IGlzIG1vcmUgcG93 ZXJmdWwgYW5kIHBlcnN1YXNpdmUNCiAgICA+ICt0aGVuIHRoZSBkaWN0aW9uYXJ5IGVudHJ5LiBU aGUgc2FtZSBhcHBsaWVzIHRvIGNvZGUgcmV2aWV3cy4NCiAgICA+ICsNCiAgICA+ICtNYWtpbmcg c3RhdGVtZW50cyBpbiBjb2RlIHJldmlld3Mgc3VjaCBhcw0KICAgID4gKz4gWW91ciBjb2RlIGlz IGdhcmJhZ2UNCiAgICA+ICs+IFRoaXMgaWRlYSBpcyBzdHVwaWQNCiAgICA+ICsNCiAgICA+ICti ZXNpZGVzIGJlaW5nIGFuIG9waW5pb24gaXMgcnVkZSBhbmQgY291bnRlciBwcm9kdWN0aXZlDQog ICAgPiArKiBJdCB3aWxsIG1ha2UgdGhlIHBhdGNoIGF1dGhvciBhbmdyeTogaW5zdGVhZCBvZiBm aW5kaW5nIGEgc29sdXRpb24gdG8gdGhlIHByb2JsZW0gdGhlDQogICAgPiArICBhdXRob3Igd2ls bCBzcGVuZCB0aW1lIGFuZCBtZW50YWwgZW5lcmd5IHdyZXN0bGluZyB3aXRoIHRoZWlyIGZlZWxp bmdzDQogICAgPiArKiBJdCBkb2VzIG5vdCBjb250YWluIGFueSBpbmZvcm1hdGlvbg0KICAgID4g KyogRmFjdHMgYXJlIGJvdGggbW9yZSBwb3dlcmZ1bCBhbmQgbW9yZSBwZXJzdWFzaXZlDQogICAg PiArDQogICAgPiArQ29uc2lkZXIgdGhlIGZvbGxvd2luZyB0d28gcGllY2VzIG9mIGZlZWRiYWNr IG9uIGEgcGllY2Ugb2YgY29kZQ0KICAgID4gKz4gVGhpcyBwaWVjZSBvZiBjb2RlIGlzIGNvbmZ1 c2luZw0KICAgID4gKz4gSXQgdG9vayBtZSBhIGxvbmcgdGltZSB0byDvrIFndXJlIG91dCB3aGF0 IHdhcyBnb2luZyBvbiBoZXJlDQogICAgPiArDQogICAgPiArVGhlIGZpcnN0IGV4YW1wbGUgZXhw cmVzc2VzIGFuIG9waW5pb24sIHdoZXJlYXMgdGhlIHNlY29uZCByZS1waHJhc2VzIHRoZSBzdGF0 ZW1lbnQNCiAgICA+ICtpbiB0ZXJtcyBvZiB3aGF0IHlvdSBleHBlcmllbmNlZCwgd2hpY2ggaXMg YSBmYWN0Lg0KICAgID4gKw0KICAgID4gK090aGVyIGV4YW1wbGVzOg0KICAgID4gKz4gQkFEOiBU aGlzIGlzIGZyYWdpbGUNCiAgICA+ICs+IFNPTUVXSEFUIEJFVFRFUjogVGhpcyBzZWVtcyBmcmFn aWxlIHRvIG1lDQogICAgPiArPiBCRVNUOiBJZiBYIGhhcHBlbnMsIFkgd2lsbCBoYXBwZW4uDQog ICAgPiArDQogICAgPiArQSBjZXJ0YWluIHBpZWNlIG9mIGNvZGUgY2FuIGJlIHdyaXR0ZW4gaW4g bWFueSBkaWZmZXJlbnQgd2F5czogdGhpcyBjYW4gbGVhZCB0bw0KICAgID4gK2Rpc2FncmVlbWVu dHMgb24gdGhlIGJlc3QgYXJjaGl0ZWN0dXJlLCBkZXNpZ24gb3IgY29kaW5nIHBhdHRlcm4uIEFz IGFscmVhZHkgcG9pbnRlZCBvdXQNCiAgICA+ICtpbiB0aGlzIHNlY3Rpb246IGF2b2lkIGZlZWRi YWNrIHRoYXQgaXMgb3Bpbmlvbi1iYXNlZCBhbmQgdGh1cyBkb2VzIG5vdCBhZGQgYW55IHZhbHVl Lg0KICAgID4gK0JhY2sgeW91ciBjcml0aWNpc20gKG9yIGlkZWEgb24gaG93IHRvIHNvbHZlIGEg cHJvYmxlbSkgd2l0aCBhIHNlbnNpYmxlIHJhdGlvbmFsZS4NCiAgICA+ICsNCiAgICA+ICsjIyMg UmV2aWV3IHRoZSBjb2RlLCBub3QgdGhlIHBlcnNvbg0KICAgID4gK1dpdGhvdXQgcmVhbGl6aW5n IGl0LCBpdCBpcyBlYXN5IHRvIG92ZXJsb29rIHRoZSBkaWZmZXJlbmNlIGJldHdlZW4gaW5zaWdo dGZ1bCBjcml0aXF1ZSBvZg0KICAgID4gK2NvZGUgYW5kIHBlcnNvbmFsIGNyaXRpY2lzbS4gTGV0 J3MgbG9vayBhdCBhIHRoZW9yZXRpY2FsIGZ1bmN0aW9uIHdoZXJlIHRoZXJlIGlzIGFuDQogICAg PiArb3Bwb3J0dW5pdHkgdG8gcmV0dXJuIG91dCBvZiB0aGUgZnVuY3Rpb24gZWFybHkuIEluIHRo aXMgY2FzZSwgeW91IGNvdWxkIHNheQ0KICAgID4gKw0KICAgID4gKz4gWW91IHNob3VsZCByZXR1 cm4gZnJvbSB0aGlzIGZ1bmN0aW9uIGVhcmx5LCBiZWNhdXNlIG9mIFhYWA0KICAgID4gKw0KICAg ID4gK09uIGl0cyBvd24sIHRoZXJlIGlzIG5vdGhpbmcgd3Jvbmcgd2l0aCB0aGlzIHN0YXRlbWVu dC4gSG93ZXZlciwgYSBjb2RlIHJldmlldyBpcyBtYWRlDQogICAgPiArdXAgb2YgbXVsdGlwbGUg Y29tbWVudHMgYW5kIHVzaW5nICoqWW91IHNob3VsZCoqIGNvbnNpc3RlbnRseSBjYW4gc3RhcnQg dG8gZmVlbCBuZWdhdGl2ZQ0KICAgID4gK2FuZCBjYW4gYmUgbWlzLWludGVycHJldGVkIGFzIGEg cGVyc29uYWwgYXR0YWNrLiBVc2luZyBzb21ldGhpbmcgbGlrZSBhdm9pZHMgdGhpcyBpc3N1ZToN CiAgICA+ICsNCiAgICA+ICs+IFJldHVybmluZyBmcm9tIHRoaXMgZnVuY3Rpb24gZWFybHkgaXMg YmV0dGVyLCBiZWNhdXNlIG9mIFhYWA0KICAgID4gKw0KICAgID4gK1dpdGhvdXQgcGVyc29uYWwg cmVmZXJlbmNlLCBhIGNvZGUgcmV2aWV3IHdpbGwgY29tbXVuaWNhdGUgdGhlIHByb2JsZW0sIGlk ZWEgb3IgaXNzdWUNCiAgICA+ICt3aXRob3V0IHJpc2tpbmcgbWlzLWludGVycHJldGF0aW9uLg0K ICAgID4gKw0KICAgID4gKyMjIyBWZXJib3NlIHZzLiB0ZXJzZQ0KICAgID4gK0R1ZSB0byB0aGUg dGltZSBpdCB0YWtlcyB0byByZXZpZXcgYW5kIGNvbXBvc2UgY29kZSByZXZpZXdlciwgcmV2aWV3 ZXJzIG9mdGVuIGFkb3B0IGENCiAgICA+ICt0ZXJzZSBzdHlsZS4gSXQgaXMgbm90IHVudXN1YWwg dG8gc2VlIHJldmlldyBjb21tZW50cyBzdWNoIGFzDQogICAgPiArPiB0eXBvDQogICAgPiArPiBz L3Jlc2lvbnMvcmVnaW9ucy8NCiAgICA+ICs+IGNvZGluZyBzdHlsZQ0KICAgID4gKz4gY29kaW5n IHN0eWxlOiBicmFja2V0cyBub3QgbmVlZGVkDQogICAgPiArZXRjLg0KICAgID4gKw0KICAgID4g K1RlcnNlIGNvZGUgcmV2aWV3IHN0eWxlIGhhcyBpdHMgcGxhY2UgYW5kIGNhbiBiZSBwcm9kdWN0 aXZlIGZvciBib3RoIHRoZSByZXZpZXdlciBhbmQNCiAgICA+ICt0aGUgYXV0aG9yLiBIb3dldmVy LCBvdmVydXNlIGNhbiBjb21lIGFjcm9zcyBhcyB1bmZyaWVuZGx5LCBsYWNraW5nIGVtcGF0aHkg YW5kDQogICAgPiArY2FuIHRodXMgY3JlYXRlIGEgbmVnYXRpdmUgaW1wcmVzc2lvbiB3aXRoIHRo ZSBhdXRob3Igb2YgYSBwYXRjaC4gVGhpcyBpcyBpbiBwYXJ0aWN1bGFyDQogICAgPiArdHJ1ZSwg d2hlbiB5b3UgZG8gbm90IGtub3cgdGhlIGF1dGhvciBvciB0aGUgYXV0aG9yIGlzIGEgbmV3Y29t ZXIuIFRlcnNlDQogICAgPiArY29tbXVuaWNhdGlvbiBzdHlsZXMgY2FuIGFsc28gYmUgcGVyY2Vp dmVkIGFzIHJ1ZGUgaW4gc29tZSBjdWx0dXJlcy4NCiAgICA+ICsNCiAgICA+ICtJZiB5b3UgdGVu ZCB0byB1c2UgYSB0ZXJzZSBjb21tZW50aW5nIHN0eWxlIGFuZCB5b3UgZG8gbm90IGtub3cgd2hl dGhlciB0aGUgYXV0aG9yDQogICAgPiAraXMgT0sgd2l0aCBpdCwgaXQgaXMgb2Z0ZW4gYSBnb29k IGlkZWEgdG8gY29tcGVuc2F0ZSBmb3IgaXQgaW4gdGhlIGNvZGUgcmV2aWV3IG9wZW5pbmcNCiAg ICA+ICsod2hlcmUgeW91IGV4cHJlc3MgYXBwcmVjaWF0aW9uKSBvciB3aGVuIHRoZXJlIGlzIGEg bmVlZCBmb3IgdmVyYm9zZSBleHByZXNzaW9uLg0KICAgID4gKw0KICAgID4gK0l0IGlzIGFsc28g ZW50aXJlbHkgZmluZSB0byBtZW50aW9uIHRoYXQgeW91IGhhdmUgYSBmYWlybHkgdGVyc2UgY29t bXVuaWNhdGlvbiBzdHlsZQ0KICAgID4gK2FuZCBhc2sgd2hldGhlciB0aGUgYXV0aG9yIGlzIE9L IHdpdGggaXQuIEluIGFsbW9zdCBhbGwgY2FzZXMsIHRoZXkgd2lsbCBiZTogYnkgYXNraW5nDQog ICAgPiAreW91IGFyZSBzaG93aW5nIGVtcGF0aHkgdGhhdCBoZWxwcyBjb3VudGVyYWN0IGEgbmVn YXRpdmUgaW1wcmVzc2lvbi4NCiAgICA+ICsNCiAgICA+ICsjIyMgQ29kZSBSZXZpZXcgQ29tbWVu dHMgc2hvdWxkIGJlIGFjdGlvbmFibGUNCiAgICA+ICtDb2RlIHJldmlldyBjb21tZW50cyBzaG91 bGQgYmUgYWN0aW9uYWJsZTogaW4gb3RoZXIgd29yZHMsIGl0IG5lZWRzIHRvIGJlIGNsZWFyDQog ICAgPiArd2hhdCB0aGUgYXV0aG9yIG9mIHRoZSBjb2RlIG5lZWRzIHRvIGRvIHRvIGFkZHJlc3Mg dGhlIGlzc3VlIHlvdSBpZGVudGlmaWVkLg0KICAgID4gKw0KICAgID4gK1N0YXRlbWVudHMgc3Vj aCBhcw0KICAgID4gKz4gQkFEOiBUaGlzIGlzIHdyb25nDQogICAgPiArPiBCQUQ6IFRoaXMgZG9l cyBub3Qgd29yaw0KICAgID4gKz4gQkVUVEVSLCBCVVQgTk9UIEdPT0Q6IFRoaXMgZG9lcyBub3Qg d29yaywgYmVjYXVzZSBvZiBYWFgNCiAgICA+ICsNCiAgICA+ICtkbyBub3Qgbm9ybWFsbHkgcHJv dmlkZSB0aGUgYXV0aG9yIG9mIGEgcGF0Y2ggd2l0aCBlbm91Z2ggaW5mb3JtYXRpb24gdG8gc2Vu ZCBvdXQgYQ0KICAgID4gK25ldyBwYXRjaCB2ZXJzaW9uLiBCeSBkb2luZyB0aGlzLCB5b3UgZXNz ZW50aWFsbHkgZm9yY2UgdGhlIHBhdGNoIGF1dGhvciB0byAqKmZpbmQqKiBhbmQNCiAgICA+ICsq KmltcGxlbWVudCoqIGFuIGFsdGVybmF0aXZlLCB3aGljaCB0aGVuIG1heSBhbHNvIG5vdCBiZSBh Y2NlcHRhYmxlIHRvIHlvdSBhcyB0aGUNCiAgICA+ICsqKnJldmlld2VyKiogb2YgdGhlIHBhdGNo Lg0KICAgID4gKw0KICAgID4gK0EgYmV0dGVyIHdheSB0byBhcHByb2FjaCB0aGlzIGlzIHRvIHNh eQ0KICAgID4gKw0KICAgID4gKz4gVGhpcyBkb2VzIG5vdCB3b3JrLCBiZWNhdXNlIG9mIFhYWA0K ICAgID4gKz4gWW91IG1heSB3YW50IHRvIGludmVzdGlnYXRlIFlZWSBhbmQgWlpaIGFzIGFsdGVy bmF0aXZlcw0KICAgID4gKw0KICAgID4gK0luIHNvbWUgY2FzZXMsIGl0IG1heSBub3QgYmUgY2xl YXIgd2hldGhlciBZWVkgb3IgWlpaIGFyZSB0aGUgYmV0dGVyIHNvbHV0aW9uLiBBcyBhDQogICAg PiArcmV2aWV3ZXIgeW91IHNob3VsZCBiZSBhcyB1cC1mcm9udCBhbmQgcG9zc2libGUgaW4gc3Vj aCBhIGNhc2UgYW5kIHNheSBzb21ldGhpbmcgbGlrZQ0KICAgID4gKw0KICAgID4gKz4gSSBhbSBu b3Qgc3VyZSB3aGV0aGVyIFlZWSBhbmQgWlpaIGFyZSBiZXR0ZXIsIHNvIHlvdSBtYXkgd2FudCB0 byBvdXRsaW5lIHlvdXINCiAgICA+ICs+IHRob3VnaHRzIGFib3V0IGJvdGggc29sdXRpb25zIGJ5 IGUtbWFpbCBmaXJzdCwgc3VjaCB0aGF0IHdlIGNhbiBkZWNpZGUgd2hhdCB3b3Jrcw0KICAgID4g Kz4gYmVzdA0KICAgID4gKw0KICAgID4gKyMjIyBJZGVudGlmeSB0aGUgc2V2ZXJpdHkgb2YgYW4g aXNzdWUgb3IgZGlzYWdyZWVtZW50DQogICAgPiArQnkgZGVmYXVsdCwgZXZlcnkgY29tbWVudCB3 aGljaCBpcyBtYWRlICoqb3VnaHQgdG8gYmUgYWRkcmVzc2VkKiogYnkgdGhlIGF1dGhvci4NCiAg ICA+ICtIb3dldmVyLCBvZnRlbiByZXZpZXdlcnMgbm90ZSBpc3N1ZXMsIHdoaWNoIHdvdWxkIGJl IG5pY2UgaWYgdGhleSB3ZXJlIGFkZHJlc3NlZCwNCiAgICA+ICtidXQgYXJlIG5vdCBtYW5kYXRv cnkuDQogICAgPiArDQogICAgPiArVHlwaWNhbGx5LCByZXZpZXdlcnMgdXNlIHRlcm1pbm9sb2d5 IHN1Y2ggYXMNCiAgICA+ICs+IFRoaXMgd291bGQgYmUgYSBuaWNlLXRvLWhhdmUNCiAgICA+ICs+ IFRoaXMgaXMgbm90IGEgYmxvY2tlcg0KICAgID4gKw0KICAgID4gK1NvbWUgbWFpbnRhaW5lcnMg dXNlDQogICAgPiArPiBOSVQ6IFhYWA0KICAgID4gKw0KICAgID4gK2hvd2V2ZXIsIGl0IGlzIHNv bWV0aW1lcyBhbHNvIHVzZWQgdG8gaW5kaWNhdGUgYSBtaW5vciBpc3N1ZSB0aGF0ICoqbXVzdCoq IGJlIGZpeGVkLg0KICAgID4NCiAgICA+ICtEdXJpbmcgYSBjb2RlIHJldmlldywgaXQgY2FuIGhh cHBlbiB0aGF0IHJldmlld2VyIGFuZCBhdXRob3IgZGlzYWdyZWUgb24gaG93IHRvIG1vdmUNCiAg ICA+ICtmb3J3YXJkLiBUaGUgZGVmYXVsdCBwb3NpdGlvbiB3aGVuIGl0IGNvbWVzIHRvIGRpc2Fn cmVlbWVudHMgaXMgdGhhdCAqKmJvdGggcGFydGllcw0KICAgID4gK3dhbnQgdG8gYXJndWUgdGhl aXIgY2FzZSoqLiBIb3dldmVyLCBmcmVxdWVudGx5IG9uZSBvciBib3RoIHBhcnRpZXMgZG8gbm90 IGZlZWwgdGhhdA0KICAgID4gK3N0cm9uZ2x5IGFib3V0IGEgc3BlY2lmaWMgaXNzdWUuDQogICAg PiArDQogICAgPiArV2l0aGluIHRoZSBYZW4gUHJvamVjdCwgd2UgaGF2ZSBbYSB3YXldKGh0dHBz Oi8veGVucHJvamVjdC5vcmcvZGV2ZWxvcGVycy9nb3Zlcm5hbmNlLyNleHByZXNzaW5nb3Bpbmlv bikNCiAgICA+ICt0byBoaWdobGlnaHQgb25lJ3MgcG9zaXRpb24gb24gcHJvcG9zYWxzLCBmb3Jt YWwgb3IgaW5mb3JtYWwgdm90ZXMgdXNpbmcgdGhlIGZvbGxvd2luZw0KICAgID4gK25vdGF0aW9u Og0KICAgID4gKz4gKzIgOiBJIGFtIGhhcHB5IHdpdGggdGhpcyBwcm9wb3NhbCwgYW5kIEkgd2ls bCBhcmd1ZSBmb3IgaXQNCiAgICA+ICs+ICsxIDogSSBhbSBoYXBweSB3aXRoIHRoaXMgcHJvcG9z YWwsIGJ1dCB3aWxsIG5vdCBhcmd1ZSBmb3IgaXQNCiAgICA+ICs+IDAgOiBJIGhhdmUgbm8gb3Bp bmlvbg0KICAgID4gKz4gLTEgOiBJIGFtIG5vdCBoYXBweSB3aXRoIHRoaXMgcHJvcG9zYWwsIGJ1 dCB3aWxsIG5vdCBhcmd1ZSBhZ2FpbnN0IGl0DQogICAgPiArPiAtMiA6IEkgYW0gbm90IGhhcHB5 IHdpdGggdGhpcyBwcm9wb3NhbCwgYW5kIEkgd2lsbCBhcmd1ZSBhZ2FpbnN0IGl0DQogICAgPiAr DQogICAgPiArWW91IGNhbiB1c2UgYSBwaHJhc2Ugc3VjaCBhcw0KICAgID4gKz4gSSBhbSBub3Qg aGFwcHkgd2l0aCB0aGlzIHN1Z2dlc3Rpb24sIGJ1dCB3aWxsIG5vdCBhcmd1ZSBhZ2FpbnN0IGl0 DQogICAgPiArDQogICAgPiArdG8gbWFrZSBjbGVhciB3aGVyZSB5b3Ugc3RhbmQsIHdoaWxlIHJl Y29yZGluZyB5b3VyIHBvc2l0aW9uLiBDb252ZXJzZWx5LCBhIHJldmlld2VyDQogICAgPiArbWF5 IGRvIHNvbWV0aGluZyBzaW1pbGFyDQogICAgPiArPiBJIGFtIG5vdCBoYXBweSB3aXRoIFhZWiwg YnV0IHdpbGwgbm90IGFyZ3VlIGFnYWluc3QgaXQgW2FueW1vcmVdDQogICAgPiArPiBXaGF0IHdl IGhhdmUgbm93IGlzIGdvb2QgZW5vdWdoLCBidXQgY291bGQgYmUgYmV0dGVyDQogICAgDQogICAg SXQgaXMgbm90IGp1c3QgYWJvdXQgdGhlIHdpbGxpbmduZXNzIG9mIHNvbWVib2R5IHRvIGFyZ3Vl IGEgcG9pbnQsIHdoaWNoDQogICAgaXMgdGhlIGltcG9ydGFudCB0aGluZyB3aGVuIHZvdGluZy4g RHVyaW5nIGNvZGUgcmV2aWV3cyBpdCBpcyBwZXJmZWN0bHkNCiAgICBmaW5lIHRvIG1ha2Ugc3Vn Z2VzdGlvbnMgd2hpY2ggYXJlIGp1c3Qgb3B0aW9uYWwgZm9yIG11bHRpcGxlIHJlYXNvbnMsDQog ICAgaW5jbHVkaW5nIHRoYXQgdGhleSBtaWdodCBiZSB0b28gdGF4aW5nIGZvciB0aGUgY29udHJp YnV0b3IuDQogICAgDQogICAgU28sIEkgdGhpbmsgd2Ugc2hvdWxkIGFkZCB0aGF0IGl0IHdvdWxk IGJlIGJlc3QgdG8gdXNlIHdvcmRzIHRoYXQgbWFrZSBpdA0KICAgIGNsZWFyIHdoZXRoZXIgc29t ZXRoaW5nIGlzIG9wdGlvbmFsIG9yIHdoZXRoZXIgaXQgaXMgcmVxdWlyZWQsIHNlZSBteQ0KICAg IHJlcGx5IHRvIHBhdGNoICM2LCBJIHdyb3RlIGFuIGV4YW1wbGUgdGhlcmUuDQogICAgDQogICAg DQogICAgDQogICAgPiArIyMjIEF1dGhvcnM6IHJlc3BvbmRpbmcgdG8gcmV2aWV3IGNvbW1lbnRz DQogICAgPiArVHlwaWNhbGx5IHBhdGNoIGF1dGhvcnMgYXJlIGV4cGVjdGVkIHRvICoqYWRkcmVz cyBhbGwqKiByZXZpZXcgY29tbWVudHMgaW4gdGhlIG5leHQNCiAgICA+ICt2ZXJzaW9uIG9mIGEg cGF0Y2ggb3IgcGF0Y2ggc2VyaWVzLiBJbiBhIHNtb290aC1ydW5uaW5nIGNvZGUgcmV2aWV3IHdo ZXJlIHlvdSBkbyBub3QNCiAgICA+ICtoYXZlIGZ1cnRoZXIgcXVlc3Rpb25zIGl0IGlzIG5vdCBh dCBhbGwgbmVjZXNzYXJ5IHRvIGFja25vd2xlZGdlIHRoZSBjaGFuZ2VzIHlvdSBhcmUNCiAgICA+ ICtnb2luZyB0byBtYWtlOg0KICAgID4gKyogU2ltcGx5IHNlbmQgdGhlIG5leHQgdmVyc2lvbiB3 aXRoIHRoZSBjaGFuZ2VzIGFkZHJlc3NlZCBhbmQgcmVjb3JkIGl0IGluIHRoZQ0KICAgID4gK2No YW5nZS1sb2cNCiAgICA+ICsNCiAgICA+ICtXaGVuIHRoZXJlIGlzIGRpc2N1c3Npb24sIHRoZSBu b3JtYWwgcHJhY3RpY2UgaXMgdG8gcmVtb3ZlIHRoZSBwb3J0aW9uIG9mIHRoZSBlLW1haWwNCiAg ICA+ICt0aHJlYWQgd2hlcmUgdGhlcmUgaXMgYWdyZWVtZW50LiBPdGhlcndpc2UsIHRoZSB0aHJl YWQgY2FuIGJlY29tZSBleGNlcHRpb25hbGx5DQogICAgPiArbG9uZy4NCiAgICA+ICsNCiAgICA+ ICtJbiBjYXNlcyB3aGVyZSB0aGVyZSB3YXMgZGlzY3Vzc2lvbiBhbmQgbWF5YmUgZGlzYWdyZWVt ZW50LCBpdCBkb2VzIGhvd2V2ZXIgbWFrZQ0KICAgID4gK3NlbnNlIHRvIGNsb3NlIHRoZSBkaXNj dXNzaW9uIGJ5IHNheWluZyBzb21ldGhpbmcgbGlrZQ0KICAgID4gKw0KICAgID4gKz4gQUNLDQog ICAgPiArPiBTZWVtcyB3ZSBhcmUgYWdyZWVkLCBJIGFtIGdvaW5nIHRvIGRvIHRoaXMNCiAgICA+ ICsNCiAgICA+ICtPdGhlciBzaXR1YXRpb25zIHdoZW4geW91IG1heSB3YW50IHRvIGRvIHRoaXMg YXJlIGNhc2VzIHdoZXJlIHRoZSByZXZpZXdlciBtYWRlDQogICAgPiArb3B0aW9uYWwgc3VnZ2Vz dGlvbnMsIHRvIG1ha2UgY2xlYXIgd2hldGhlciB0aGUgc3VnZ2VzdGlvbiB3aWxsIGJlIGZvbGxv d2VkIG9yDQogICAgPiArbm90Lg0KICAgID4gKw0KICAgID4gKyMjIyBBdm9pZCB1bmNvbW1vbiB3 b3Jkczogbm90IGV2ZXJ5b25lIGlzIGEgbmF0aXZlIEVuZ2xpc2ggc3BlYWtlcg0KICAgID4gK0F2 b2lkIHVuY29tbW9uIHdvcmRzIGJvdGggd2hlbiByZXZpZXdpbmcgY29kZSBvciByZXNwb25kaW5n IHRvIGEgcmV2aWV3LiBOb3QNCiAgICA+ICtldmVyeW9uZSBpcyBhIG5hdGl2ZSBFbmdsaXNoIHNw ZWFrZXIuIFRoZSB1c2Ugb2Ygc3VjaCB3b3JkcyBjYW4gY29tZSBhY3Jvc3MgYmFkbHkgYW5kDQog ICAgPiArY2FuIGxlYWQgdG8gbWlzdW5kZXJzdGFuZGluZ3MuDQogICAgPiArDQogICAgPiArIyMj IFByaW9yaXRpemUgc2lnbmlmaWNhbnQgZmxhd3MNCiAgICA+ICtJZiBhIHBhdGNoIG9yIHBhdGNo IHNlcmllcyBoYXMgc2lnbmlmaWNhbnQgZmxhd3MsIHN1Y2ggYXMNCiAgICA+ICsqIEl0IGlzIGJ1 aWx0IG9uIHdyb25nIGFzc3VtcHRpb25zDQogICAgPiArKiBUaGVyZSBhcmUgaXNzdWVzIHdpdGgg dGhlIGFyY2hpdGVjdHVyZSBvciB0aGUgZGVzaWduDQogICAgPiArDQogICAgPiAraXQgZG9lcyBu b3QgbWFrZSBzZW5zZSB0byBkbyBhIGRldGFpbGVkIGNvZGUgcmV2aWV3LiBJbiBzdWNoIGNhc2Vz LCBpdCBpcyBiZXN0IHRvDQogICAgPiArZm9jdXMgb24gdGhlIG1ham9yIGlzc3VlcyBmaXJzdCBh bmQgZGVhbCB3aXRoIHN0eWxlIGFuZCBtaW5vciBpc3N1ZXMgaW4gYSBzdWJzZXF1ZW50DQogICAg PiArcmV2aWV3LiBUaGlzIHJlZHVjZXMgdGhlIHdvcmtsb2FkIG9uIGJvdGggdGhlIHJldmlld2Vy IGFuZCBwYXRjaCBhdXRob3IuIEhvd2V2ZXIsDQogICAgPiArcmV2aWV3ZXJzIHNob3VsZCBtYWtl IGNsZWFyIHRoYXQgdGhleSBoYXZlIG9taXR0ZWQgZGV0YWlsZWQgcmV2aWV3IGNvbW1lbnRzIGFu ZA0KICAgID4gK3RoYXQgdGhlc2Ugd2lsbCBjb21lIGxhdGVyLg0KICAgIA0KICAgIE1heWJlIHdl IHdhbnQgdG8gZXhwYW5kIG9uIHRoaXMgYSBiaXQuIE5vdCBhbGwgc2VyaWVzIGFyZSBiYXNlZCBv bg0KICAgIGZsYXdlZCBhc3N1bXB0aW9ucywgYnV0IGFsbCBzZXJpZXMgaGF2ZSBkaWZmZXJlbnQg Y2xhc3Mgb2YgY2hhbmdlcyB0aGF0DQogICAgYXJlIHJlcXVpcmVkIGZvciBhY2NlcHRhbmNlLCBm cm9tIG1ham9yIGNvZGUgbW9kaWZpY2F0aW9ucyB0byBtaW5vciBjb2RlDQogICAgc3R5bGUgZml4 ZXMuDQogICAgDQogICAgSSB0aGluayB3ZSBzaG91bGQgc2F5IHRoYXQgaXQgaXMgZ29vZCBwcmFj dGljZSB0byBhc2sgZm9yIGFueSBtYWpvcg0KICAgIGNoYW5nZXMgZWFybHkgb24sIGR1cmluZyB0 aGUgZmlyc3Qgb3Igc2Vjb25kIGl0ZXJhdGlvbiBvZiB0aGUgc2VyaWVzLg0KICAgIEl0IHdvdWxk IGJlIGJlc3QgdG8gYXZvaWQgYXNraW5nIGZvciBtYWpvciBjaGFuZ2VzIGF0IHY5IGlmIHBvc3Np YmxlLg0KICAgIA0KICAgIA0KICAgIFNvbWV0aGluZyBlbHNlIHdoaWNoIGlzIG1pc3NpbmcgaW4g dGhpcyBkb2N1bWVudCwgYW5kIGl0IGlzIHB1cmVseSBmb3INCiAgICByZXZpZXdlcnMsIGlzIHRv IGJlIGNhcmVmdWwgZG9pbmcgcmV2aWV3cyBsYXRlIGluIHRoZSBjeWNsZSB3aGVuIGFub3RoZXIN CiAgICBtYWludGFpbmVyL3Jldmlld2VyIGhhcyBhbHJlYWR5IHByb3ZpZGVkIGZlZWRiYWNrIG9u IHRoZSBzZXJpZXMgbXVsdGlwbGUNCiAgICB0aW1lcyBwcmV2aW91c2x5LiBGb3IgaW5zdGFuY2Us IGlmIHJldmlld2VyIFIxIGhhcyBiZWVuIGRvaW5nIHJldmlld3MNCiAgICBmcm9tIHRoZSBmaXJz dCB2ZXJzaW9uIG9mIHRoZSBzZXJpZXMgYW5kIGNvbnRyaWJ1dG9yIEMgaGFzIGJlZW4NCiAgICBh ZGRyZXNzaW5nIGFsbCBjb21tZW50cywgaXQgd291bGQgYmUgYmVzdCBpZiByZXZpZXdlciBSMiBk aWRuJ3QgY29tZSBpbg0KICAgIHByb3ZpZGluZyBkZXRhaWxlZCBmZWVkYmFjayBtb250aHMgbGF0 ZXIgYXQgdjUsIHVubGVzcyB0aGVpciByZXF1ZXN0cw0KICAgIGFyZSBhY3R1YWxseSBzdHJpY3Rs eSBuZWNlc3NhcnkgKGkuZS4gdGhleSBzcG90dGVkIGEgYnVnKS4gVGhlIG1haW4NCiAgICByZWFz b24gaXMgdGhhdCBpdCBpcyBkaWZmaWN1bHQgbm90IHRvIGxldCB5b3VyIG93biBwZXJzb25hbCBz dHlsZSAoY29kZQ0KICAgIHN0eWxlLCB0aGUgd2F5IHRvIGxheSBvdXQgdGhlIGNvZGUpIHNpcCB0 aHJvdWdoIHJldmlldyBjb21tZW50cywgYW5kIGl0DQogICAgY2FuIGNhdXNlIGRvdWJsZS1lZmZv cnQgZm9yIHRoZSBhdXRob3IgaWYgaGUvc2hlIGFscmVhZHkgbWFkZSBjaGFuZ2VzDQogICAgYWNj b3JkaW5nIFIxJ3MgcGVyc29uYWwgc3R5bGUuIEhvd2V2ZXIsIGluIGdlbmVyYWwsIGl0IHdvdWxk IGJlIGJlc3QgdG8NCiAgICBsaW1pdCAicGVyc29uYWwgc3R5bGUiIHJlcXVlc3RzIGZvciBjaGFu Z2VzIGFueXdheSwgc2VlIG15IGNvbW1lbnQgdG8NCiAgICBwYXRjaCAjNi4NCiAgICAgIA0KSSBz ZWUgd2hldGhlciBJIGNhbiBhZGQgc29tZXRoaW5nLiBJIGRvIGxpa2UgUmljaCdzIHN1Z2dlc3Rp b24gdG8gdXNlIHRoZSBTaGlmdCBMZWZ0IiB0ZXJtaW5vbG9neSAoaHR0cHM6Ly9kZXZvcGVkaWEu b3JnL3NoaWZ0LWxlZnQpIG9mIHdoaWNoIHRoaXMgaXMga2luZCBvZiBhbiBpbnN0YW5jZS4gVGhl IHNhbWUgYXBwbGllcyANCg0KSSBjYW4gcHV0IHRvZ2V0aGVyIGEgdjIsIHdpdGggdHlwb3MgYWRk cmVzc2VkIGFuZCBleHBhbmQgc29tZSBzZWN0aW9ucy4NCg0KUmVnYXJkcw0KTGFycw0KDQoNCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1hcGkgbWFp bGluZyBsaXN0Clhlbi1hcGlAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5w cm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1hcGkK From xen-api-bounces@lists.xenproject.org Fri Nov 29 00:02:31 2019 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Nov 2019 00:02:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaTjy-0007Fi-4b; Fri, 29 Nov 2019 00:02:30 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaTjw-0007FT-MD for xen-api@lists.xenproject.org; Fri, 29 Nov 2019 00:02:28 +0000 X-Inumbo-ID: 83b80580-123b-11ea-a3da-12813bfff9fa Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 83b80580-123b-11ea-a3da-12813bfff9fa; Fri, 29 Nov 2019 00:02:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1574985742; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=pUoHTUkg4Xb/2R4GYepUcc7k96nRW9fdt05C1nDEB8o=; b=LMZXDsXwIuBoB54w9K+WKxV16KzU3vJGB9pNrtv7mVOxFxrQeLtWOXDl LNqukQzMxfad5IwaNPtSdIiMzGH1HGSpH7O0UK1NSrNBo1zF112cAgU0h zJh+XH4kq8kd5XmHwOWgWP2BO8Omv8BnYnOKvjEpX2mFPPJk/vhqRX7pB M=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=lars.kurth@citrix.com; spf=Pass smtp.mailfrom=lars.kurth@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of lars.kurth@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="lars.kurth@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa1.hc3370-68.iphmx.com: domain of lars.kurth@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="lars.kurth@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: bjIHBhWIMaQT+NKwUMNG71/nf6Y80WpNwaDg71kPp9pJkfWNd2fK1LP76BWAm3fEZ0XSsvXsOt aPotMn2nxGk3qpXHy3bMcYFDw7t7DXPGJDx/gWuyqpFB9TqqnyaypDPpf+0DEgyQ59udkoiP8Y 2ldST+Ab9sATXXFoJVj2gOhbEBvCV2J+drENuzwNzK340zU+xQUSQQ9sXyKlmgO02ZngtmaHY7 trKoWCII3Wc5jwtAZ0YeZmLP7R4d0or+lf5ImAtFtunvVqG48+S0ZtNKMUzgKRwZsQvgV+ZEQR S1c= X-SBRS: 2.7 X-MesageID: 9093276 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.69,255,1571716800"; d="scan'208";a="9093276" From: Lars Kurth To: Stefano Stabellini , Jan Beulich Thread-Topic: [PATCH v2 5/6] Add guide on Communication Best Practice Thread-Index: AQHVdKIoBNlHjnrbLUK7o4oIKuieK6c/HQoAgGD5A4CAARvaAA== Date: Fri, 29 Nov 2019 00:02:17 +0000 Message-ID: <4ABC1664-F80E-4A54-90A0-0F8C71FA2C4D@citrix.com> References: <749f082bdb996ba7c7362847b22030882dc2903f.1569525222.git.lars.kurth@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/10.10.10.191111 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted Content-ID: MIME-Version: 1.0 Subject: Re: [Xen-API] [PATCH v2 5/6] Add guide on Communication Best Practice X-BeenThere: xen-api@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: User and development list for XCP and XAPI List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Lars Kurth , "xen-api@lists.xenproject.org" , "minios-devel@lists.xenproject.org" , "committers@xenproject.org" , "mirageos-devel@lists.xenproject.org" , "xen-devel@lists.xenproject.org" , "win-pv-devel@lists.xenproject.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-api-bounces@lists.xenproject.org Sender: "Xen-api" DQoNCu+7v09uIDI3LzExLzIwMTksIDE5OjA2LCAiU3RlZmFubyBTdGFiZWxsaW5pIiA8c3N0YWJl bGxpbmlAa2VybmVsLm9yZz4gd3JvdGU6DQoNCiAgICBPbiBGcmksIDI3IFNlcCAyMDE5LCBKYW4g QmV1bGljaCB3cm90ZToNCiAgICA+IE9uIDI2LjA5LjIwMTkgMjE6MzksIExhcnMgS3VydGggd3Jv dGU6DQogICAgPiA+ICsjIyMgVmVyYm9zZSB2cy4gdGVyc2UNCiAgICA+ID4gK0R1ZSB0byB0aGUg dGltZSBpdCB0YWtlcyB0byByZXZpZXcgYW5kIGNvbXBvc2UgY29kZSByZXZpZXdlciwgcmV2aWV3 ZXJzIG9mdGVuIGFkb3B0IGENCiAgICA+ID4gK3RlcnNlIHN0eWxlLiBJdCBpcyBub3QgdW51c3Vh bCB0byBzZWUgcmV2aWV3IGNvbW1lbnRzIHN1Y2ggYXMNCiAgICA+ID4gKz4gdHlwbw0KICAgID4g PiArPiBzL3Jlc2lvbnMvcmVnaW9ucy8NCiAgICA+ID4gKz4gY29kaW5nIHN0eWxlDQogICAgPiA+ ICs+IGNvZGluZyBzdHlsZTogYnJhY2tldHMgbm90IG5lZWRlZA0KICAgID4gPiArZXRjLg0KICAg ID4gPiArDQogICAgPiA+ICtUZXJzZSBjb2RlIHJldmlldyBzdHlsZSBoYXMgaXRzIHBsYWNlIGFu ZCBjYW4gYmUgcHJvZHVjdGl2ZSBmb3IgYm90aCB0aGUgcmV2aWV3ZXIgYW5kDQogICAgPiA+ICt0 aGUgYXV0aG9yLiBIb3dldmVyLCBvdmVydXNlIGNhbiBjb21lIGFjcm9zcyBhcyB1bmZyaWVuZGx5 LCBsYWNraW5nIGVtcGF0aHkgYW5kDQogICAgPiA+ICtjYW4gdGh1cyBjcmVhdGUgYSBuZWdhdGl2 ZSBpbXByZXNzaW9uIHdpdGggdGhlIGF1dGhvciBvZiBhIHBhdGNoLiBUaGlzIGlzIGluIHBhcnRp Y3VsYXINCiAgICA+ID4gK3RydWUsIHdoZW4geW91IGRvIG5vdCBrbm93IHRoZSBhdXRob3Igb3Ig dGhlIGF1dGhvciBpcyBhIG5ld2NvbWVyLiBUZXJzZQ0KICAgID4gPiArY29tbXVuaWNhdGlvbiBz dHlsZXMgY2FuIGFsc28gYmUgcGVyY2VpdmVkIGFzIHJ1ZGUgaW4gc29tZSBjdWx0dXJlcy4NCiAg ICA+IA0KICAgID4gQW5kIGFub3RoZXIgcmVtYXJrIGhlcmU6IE5vdCBiZWluZyB0ZXJzZSBpbiBz aXR1YXRpb25zIGxpa2UgdGhlIG9uZXMNCiAgICA+IGVudW1lcmF0ZWQgYXMgZXhhbXBsZXMgYWJv dmUgaXMgYSBkb3VibGUgd2FzdGUgb2YgdGhlIHJldmlld2VyJ3MgdGltZToNCiAgICA+IFRoZXkg c2hvdWxkbid0IGV2ZW4gbmVlZCB0byBtYWtlIHN1Y2ggY29tbWVudHMsIGVzcGVjaWFsbHkgbm90 IG1hbnkNCiAgICA+IHRpbWVzIGZvciBhIHNpbmdsZSBwYXRjaCAoc2VlIHlvdXIgbWVudGlvbiBv ZiAib3ZlcnVzZSIpLiBJIHJlYWxpemUNCiAgICA+IHdlIHN0aWxsIGhhdmUgbm8gYXV0b21hdGVk IG1lY2hhbmlzbSB0byBjaGVjayBzdHlsZSBhc3BlY3RzLCBidXQNCiAgICA+IGFueWJvZHkgY2Fu IGVhc2lseSBsb29rIG92ZXIgdGhlaXIgcGF0Y2hlcyBiZWZvcmUgc3VibWl0dGluZyB0aGVtLg0K ICAgID4gQW5kIGZvciBhbiBvY2Nhc2lvbmFsIGlzc3VlIEkgdGhpbmsgYSB0ZXJzZSByZXBseSBp cyBxdWl0ZSByZWFzb25hYmxlDQogICAgPiB0byBoYXZlLg0KICAgID4gDQogICAgPiBPdmVyYWxs IEknbSBzZWVpbmcgdGhlIGdvb2QgaW50ZW50aW9ucyBvZiB0aGlzIGRvY3VtZW50LCB5ZXQgSSdk IHN0aWxsDQogICAgPiB2b3RlIGF0IGxlYXN0IC0xIG9uIGl0IGlmIGl0IGNhbWUgdG8gYSB2b3Rl LiBGb2xsb3dpbmcgZXZlbiBqdXN0IGENCiAgICA+IGZhaXIgcGFydCBvZiBpdCBpcyBhIGNvbnNp ZGVyYWJsZSBleHRyYSBhbW91bnQgb2YgdGltZSB0byBpbnZlc3QgaW4NCiAgICA+IHJldmlld3Ms IHdoZW4gd2UgYWxyZWFkeSBoYXZlIGEgc2V2ZXJlIHJldmlld2luZyBib3R0bGVuZWNrLiBJZiBJ IGhhdmUNCiAgICA+IHRvIGp1ZGdlIGJldHdlZW4gZG9pbmcgYSBiYWQgKHN0eWxpc3RpY2FsbHkg YWNjb3JkaW5nIHRvIHRoaXMgZG9jLCBub3QNCiAgICA+IHRlY2huaWNhbGx5KSByZXZpZXcgb3Ig bm9uZSBhdCBhbGwgKGJlY2F1c2Ugb2YgdGltZSBjb25zdHJhaW50cyksIEknZA0KICAgID4gZmF2 b3IgdGhlIGZvcm1lci4gVW5sZXNzIG9mIGNvdXJzZSBJJ20gYXNrZWQgdG8gc3RvcCBkb2luZyBz bywgaW4NCiAgICA+IHdoaWNoIGNhc2UgSSdkIGV4cGVjdCB3aG9ldmVyIGFza3MgdG8gYXJyYW5n ZSBmb3IgdGhlIHJldmlld3MgdG8gYmUNCiAgICA+IGRvbmUgYnkgc29tZW9uZSBlbHNlIGluIGR1 ZSBjb3Vyc2UuDQogICAgDQogICAgUmVhZGluZyB0aGUgZG9jdW1lbnQsIEkgdGhpbmsgSmFuIGhh cyBhIHBvaW50IHRoYXQgaXQgZ2l2ZXMgdGhlDQogICAgaW1wcmVzc2lvbiB0aGF0IGZvbGxvd2lu ZyB0aGUgc3VnZ2VzdGlvbnMgd291bGQgdGFrZSBzaWduaWZpY2FudA0KICAgIGVmZm9ydHMsIHdo aWxlIGFjdHVhbGx5IEkgZG9uJ3QgdGhpbmsgTGFycyBtZWFudCBpdCB0aGF0IHdheSBhdCBhbGws IGFuZA0KICAgIEkgZG9uJ3QgdGhpbmsgaXQgc2hvdWxkIGJlIHRoZSBjYXNlIGVpdGhlci4NCg0K WWVzLiBVbHRpbWF0ZWx5IHRoZSBlZmZlY3Qgb2YgYSBiZXR0ZXIgY29tbXVuaWNhdGlvbiBzaG91 bGQgb3ZlcmFsbCBiZSBhIG5ldC1wb3NpdGl2ZSBpbiB0ZXJtcyBvZiBlZmZvcnQuIA0KICAgIA0K ICAgIE1heWJlIHdlIHNob3VsZCBoaWdobGlnaHQgYW5kIGVuY291cmFnZSAiY2xhcml0eSIgaW5z dGVhZCBvZiAidmVyYm9zaXR5Ig0KICAgIG9mIHRoZSBjb21tdW5pY2F0aW9uLCBhbmQgZW5jb3Vy YWdlICJleHByZXNzaW5nIGFwcHJlY2lhdGlvbiIgdG8NCiAgICBuZXdjb21lcnMsIG5vdCBuZWNl c3NhcmlseSB0byBzZWFzb25lZCBjb250cmlidXRvcnMuDQoNCkdvb2QgaWRlYQ0KICAgIA0KICAg IFRoZSB1bHRpbWF0ZSBnb2FsIG9mIHRoaXMgZG9jdW1lbnQgaXMgYWN0dWFsbHkgdG8gKnJlZHVj ZSogb3VyIG92ZXJhbGwNCiAgICBlZmZvcnRzIGJ5IG1ha2luZyBvdXIgY29tbXVuaWNhdGlvbiBt b3JlIGVmZmljaWVudCwgbm90IHRvIGluY3JlYXNlDQogICAgZWZmb3J0cy4gTWF5YmUgaXQgaXMg d29ydGggc2F5aW5nIHRoaXMgdG9vLg0KICAgIA0KSXQgaXMgd29ydGggc2F5aW5nIHRoaXMuIA0K DQpSZWdhcmRzDQpMYXJzDQoNCg0KDQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpYZW4tYXBpIG1haWxpbmcgbGlzdApYZW4tYXBpQGxpc3RzLnhlbnByb2pl Y3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4t YXBpCg== From xen-api-bounces@lists.xenproject.org Fri Nov 29 01:42:38 2019 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Nov 2019 01:42:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaVIn-0006VE-G9; Fri, 29 Nov 2019 01:42:33 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaVIm-0006V2-If for xen-api@lists.xenproject.org; Fri, 29 Nov 2019 01:42:32 +0000 X-Inumbo-ID: 7646888c-1249-11ea-a3db-12813bfff9fa Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7646888c-1249-11ea-a3db-12813bfff9fa; Fri, 29 Nov 2019 01:42:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1574991733; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=2L3P7kv7QF2OMEI/Xe33AF4k24sKIzC3Ey683gXL9tc=; b=IHCRu8dbndJSoA199LrXGTWkQQWtvXDtiHvPAcUGrSBkskGuKzurWDeJ I2pzcYR/IKfVz5qJVbCqIwlw/wCbHsJRrRzpcizt8FBOu4AGJIKcCf6dk yNwokaBw4xjSYxmXfkonHHDgQV7WNDroyHLw8YyARnvnOBa7zLiXK1FMG 4=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=lars.kurth@citrix.com; spf=Pass smtp.mailfrom=lars.kurth@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of lars.kurth@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="lars.kurth@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa6.hc3370-68.iphmx.com: domain of lars.kurth@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="lars.kurth@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: ZUHlnVgZRJvyEzqWOgr0Yj5xNVuIM9XbVCZF1T9FEBylrLLwuNHl53kcWOwR2ucjsFhf3qMqWn rBZkn+yKEFsK75qcVWcPnptIG+XKTPz2LKF+CN7vIVfBcxlH3LSqjDU5QFtzty25HuJxFfyBya /mrYbi0jFJ618pA0L9xQmJpvYKFG83WsIS0r+7MzMQ+5rYdz4ur9h7BmUUGB1Eqf/iaZykAZ4U Zm7zaXWW5ng2jHpP10fVicf6o0e7Gk75NPxM/bSgQcab6WHXPEgBjSZ90rR+FOTb8c+sqXvXUZ fpU= X-SBRS: 2.7 X-MesageID: 9380681 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.69,255,1571716800"; d="scan'208";a="9380681" From: Lars Kurth To: Stefano Stabellini , Lars Kurth Thread-Topic: [PATCH v2 6/6] Added Resolving Disagreement Thread-Index: AQHVdKIlkhvO00R580a3wEu9+2XsyaegEysAgAE6oQA= Date: Fri, 29 Nov 2019 01:42:07 +0000 Message-ID: <0A996712-6F49-489E-9504-5DD4A287182D@citrix.com> References: <2e4b36afaa73277d246d7e84037db1532a136ec7.1569525222.git.lars.kurth@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/10.10.10.191111 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted Content-ID: <43B3A8C2A96A8E4A82C1C4D94E4D9B96@citrix.com> MIME-Version: 1.0 Subject: Re: [Xen-API] [PATCH v2 6/6] Added Resolving Disagreement X-BeenThere: xen-api@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: User and development list for XCP and XAPI List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-api@lists.xenproject.org" , "minios-devel@lists.xenproject.org" , "committers@xenproject.org" , "mirageos-devel@lists.xenproject.org" , "xen-devel@lists.xenproject.org" , "win-pv-devel@lists.xenproject.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-api-bounces@lists.xenproject.org Sender: "Xen-api" DQoNCu+7v09uIDI3LzExLzIwMTksIDE4OjU2LCAiU3RlZmFubyBTdGFiZWxsaW5pIiA8c3N0YWJl bGxpbmlAa2VybmVsLm9yZz4gd3JvdGU6DQoNCiAgICBPbiBUaHUsIDI2IFNlcCAyMDE5LCBMYXJz IEt1cnRoIHdyb3RlOg0KICAgID4gRnJvbTogTGFycyBLdXJ0aCA8bGFycy5rdXJ0aEBjaXRyaXgu Y29tPg0KICAgID4gDQogICAgPiBUaGlzIGd1aWRlIHByb3ZpZGVzIEJlc3QgUHJhY3RpY2Ugb24g aWRlbnRpZnlpbmcgYW5kIHJlc29sdmluZw0KICAgID4gY29tbW9uIGNsYXNzZXMgb2YgZGlzYWdy ZWVtZW50DQogICAgPiANCiAgICA+IFNpZ25lZC1vZmYtYnk6IExhcnMgS3VydGggPGxhcnMua3Vy dGhAY2l0cml4LmNvbT4NCiAgICA+IC0tDQogICAgPiBDYzogbWluaW9zLWRldmVsQGxpc3RzLnhl bnByb2plY3Qub3JnDQogICAgPiBDYzogeGVuLWFwaUBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KICAg ID4gQ2M6IHdpbi1wdi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KICAgID4gQ2M6IG1pcmFn ZW9zLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQogICAgPiBDYzogY29tbWl0dGVyc0B4ZW5w cm9qZWN0Lm9yZw0KICAgID4gLS0tDQogICAgPiAgcmVzb2x2aW5nLWRpc2FncmVlbWVudC5tZCB8 IDE0NiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrDQogICAg PiAgMSBmaWxlIGNoYW5nZWQsIDE0NiBpbnNlcnRpb25zKCspDQogICAgPiAgY3JlYXRlIG1vZGUg MTAwNjQ0IHJlc29sdmluZy1kaXNhZ3JlZW1lbnQubWQNCiAgICA+IA0KICAgID4gZGlmZiAtLWdp dCBhL3Jlc29sdmluZy1kaXNhZ3JlZW1lbnQubWQgYi9yZXNvbHZpbmctZGlzYWdyZWVtZW50Lm1k DQogICAgPiBuZXcgZmlsZSBtb2RlIDEwMDY0NA0KICAgID4gaW5kZXggMDAwMDAwMC4uMTlhZWRi ZQ0KICAgID4gLS0tIC9kZXYvbnVsbA0KICAgID4gKysrIGIvcmVzb2x2aW5nLWRpc2FncmVlbWVu dC5tZA0KICAgID4gQEAgLTAsMCArMSwxNDYgQEANCiAgICA+ICsjIFJlc29sdmluZyBEaXNhZ3Jl ZW1lbnQNCiAgICA+ICsNCiAgICA+ICtUaGlzIGd1aWRlIHByb3ZpZGVzIEJlc3QgUHJhY3RpY2Ug b24gcmVzb2x2aW5nIGRpc2FncmVlbWVudCwgc3VjaCBhcw0KICAgID4gKyogR3JhY2VmdWxseSBh Y2NlcHQgY29uc3RydWN0aXZlIGNyaXRpY2lzbQ0KICAgID4gKyogRm9jdXMgb24gd2hhdCBpcyBi ZXN0IGZvciB0aGUgY29tbXVuaXR5DQogICAgPiArKiBSZXNvbHZlIGRpZmZlcmVuY2VzIGluIG9w aW5pb24gZWZmZWN0aXZlbHkNCiAgICA+ICsNCiAgICA+ICsjIyBUaGVvcnk6IFBhdWwgR3JhaGFt J3MgaGllcmFyY2h5IG9mIGRpc2FncmVlbWVudA0KICAgID4gK1BhdWwgR3JhaGFtIHByb3Bvc2Vk IGEgKipkaXNhZ3JlZW1lbnQgaGllcmFyY2h5KiogaW4gYSAyMDA4IGVzc2F5IA0KICAgID4gKyoq W0hvdyB0byBEaXNhZ3JlZV0oaHR0cDovL3d3dy5wYXVsZ3JhaGFtLmNvbS9kaXNhZ3JlZS5odG1s KSoqLCBwdXR0aW5nIHR5cGVzIG9mDQogICAgPiArYXJndW1lbnRzIGludG8gYSBzZXZlbi1wb2lu dCBoaWVyYXJjaHkgYW5kIG9ic2VydmluZyB0aGF0ICptb3ZpbmcgdXAgdGhlDQogICAgPiArZGlz YWdyZWVtZW50IGhpZXJhcmNoeSBtYWtlcyBwZW9wbGUgbGVzcyBtZWFuLCBhbmQgd2lsbCBtYWtl IG1vc3Qgb2YgdGhlbSBoYXBwaWVyKi4NCiAgICA+ICtHcmFoYW0gYWxzbyBzdWdnZXN0ZWQgdGhh dCB0aGUgaGllcmFyY2h5IGNhbiBiZSB0aG91Z2h0IG9mIGFzIGEgcHlyYW1pZCwgYXMgdGhlIA0K ICAgID4gK2hpZ2hlc3QgZm9ybXMgb2YgZGlzYWdyZWVtZW50IGFyZSByYXJlci4NCiAgICA+ICsN CiAgICA+ICt8ICFbR3JhaGFtJ3MgSGllcmFyY2h5IG9mIERpc2FncmVlbWVuXShodHRwczovL3Vw bG9hZC53aWtpbWVkaWEub3JnL3dpa2lwZWRpYS9jb21tb25zL2EvYTMvR3JhaGFtJTI3c19IaWVy YXJjaHlfb2ZfRGlzYWdyZWVtZW50LWVuLnN2ZykgfA0KICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgXiBEaXNhZ3JlZW1lbnQNCiAgICANCiAgICBUaGlzIGlzIGEgTklUIGJ1dCBpbiBh IGZldyBwbGFjZXMgaW4gdGhpcyBzZXJpZXMgeW91IGdvIG92ZXIgdGhlDQogICAgb3JpZ2luYWwg bGluZSBsZW5ndGguDQoNClRydWU6IHR5cGljYWxseSBmb3IgVVJMcy4gUHJpbWFyaWx5IGJlY2F1 c2UgSSBkb24ndCBrbm93IHdoZXRoZXIgdGhleSBhcmUgcmVuZGVyZWQgY29ycmVjdGx5IHdoZW4g c3BsaXQNCiAgICANCiAgICA+ICt8ICpBIHJlcHJlc2VudGF0aW9uIG9mIEdyYWhhbSdzIGhpZXJh cmNoeSBvZiBkaXNhZ3JlZW1lbnQgZnJvbSBbTG91ZGFjcmlzXShodHRwOi8vd3d3LmNyZWF0ZWRl YmF0ZS5jb20vdXNlci92aWV3cHJvZmlsZS9Mb3VkYWNyaXMpIG1vZGlmaWVkIGJ5IFtSb2NrZXQw MDBdKGh0dHBzOi8vZW4ud2lraXBlZGlhLm9yZy93aWtpL1VzZXI6Um9ja2V0MDAwKSogfA0KICAg ID4gKw0KICAgID4gK0luIHRoZSBjb250ZXh0IG9mIHRoZSBYZW4gUHJvamVjdCB3ZSBzdHJpdmUg dG8gKipvbmx5IHVzZSB0aGUgdG9wIGhhbGYqKiBvZiB0aGUgaGllcmFyY2h5Lg0KICAgID4gKyoq TmFtZS1jYWxsaW5nKiogYW5kICoqQWQgaG9taW5lbSoqIGFyZ3VtZW50cyBhcmUgbm90IGFjY2Vw dGFibGUgd2l0aGluIHRoZSBYZW4NCiAgICA+ICtQcm9qZWN0Lg0KICAgID4gKw0KICAgID4gKyMj IElzc3VlOiBTY29wZSBjcmVlcA0KICAgID4gKw0KICAgID4gK09uZSB0aGluZyB3aGljaCBvY2Nh c2lvbmFsbHkgaGFwcGVucyBkdXJpbmcgY29kZSByZXZpZXcgaXMgdGhhdCBhIGNvZGUgcmV2aWV3 ZXINCiAgICA+ICthc2tzIG9yIGFwcGVhcnMgdG8gYXNrIHRoZSBhdXRob3Igb2YgcGF0Y2ggdG8g aW1wbGVtZW50IGFkZGl0aW9uYWwgZnVuY3Rpb25hbGl0eS4NCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBeIGEgcGF0Y2ggICAgICAgICAgICAgICAgICAgICAgXiBm dW5jdGlvbmFsaXRpZXMgDQogICAgDQogICAgDQogICAgPiArVGhpcyBjb3VsZCB0YWtlIGZvciBl eGFtcGxlIHRoZSBmb3JtIG9mDQogICAgPiArPiBEbyB5b3UgdGhpbmsgaXQgd291bGQgYmUgdXNl ZnVsIGZvciB0aGUgY29kZSB0byBkbyBYWFg/IA0KICAgID4gKz4gSSBjYW4gaW1hZ2luZSBhIHVz ZXIgd2FudGluZyB0byBkbyBZWVkgKGFuZCBYWFggd291bGQgZW5hYmxlIHRoaXMpDQogICAgPiAr DQogICAgPiArVGhhdCBwb3RlbnRpYWxseSBhZGRzIGFkZGl0aW9uYWwgd29yayBmb3IgdGhlIGNv ZGUgYXV0aG9yLCB3aGljaCB0aGV5IG1heSBub3QgaGF2ZQ0KICAgID4gK3RoZSB0aW1lIHRvIHBl cmZvcm0uIEl0IGlzIGdvb2QgcHJhY3RpY2UgZm9yIGF1dGhvcnMgdG8gY29uc2lkZXIgc3VjaCBh IHJlcXVlc3QgaW4gdGVybXMgb2YNCiAgICA+ICsqIFVzZWZ1bG5lc3MgdG8gdGhlIHVzZXINCiAg ICA+ICsqIENvZGUgY2h1cm4sIGNvbXBsZXhpdHkgb3IgaW1wYWN0IG9uIG90aGVyIHN5c3RlbSBw cm9wZXJ0aWVzDQogICAgPiArKiBFeHRyYSB0aW1lIHRvIGltcGxlbWVudCBhbmQgcmVwb3J0IGJh Y2sgdG8gdGhlIHJldmlld2VyDQogICAgPiArDQogICAgPiArSWYgeW91IGJlbGlldmUgdGhhdCB0 aGUgaW1wYWN0L2Nvc3QgaXMgdG9vIGhpZ2gsIHJlcG9ydCBiYWNrIHRvIHRoZSByZXZpZXdlci4g VG8gcmVzb2x2ZQ0KICAgID4gK3RoaXMsIGl0IGlzIGFkdmlzYWJsZSB0bw0KICAgID4gKyogUmVw b3J0IHlvdXIgZmluZGluZ3MNCiAgICA+ICsqIEFuZCB0aGVuIGNoZWNrIHdoZXRoZXIgdGhpcyB3 YXMgbWVyZWx5IGFuIGludGVyZXN0aW5nIHN1Z2dlc3Rpb24sIG9yIHNvbWV0aGluZyB0aGUNCiAg ICA+ICtyZXZpZXdlciBmZWVscyBtb3JlIHN0cm9uZ2x5IGFib3V0DQogICAgPiArDQogICAgPiAr SW4gdGhlIGxhdHRlciBjYXNlLCB0aGVyZSBhcmUgdHlwaWNhbGx5IHNldmVyYWwgY29tbW9uIG91 dGNvbWVzDQogICAgPiArKiBUaGUgKiphdXRob3IgYW5kIHJldmlld2VyIGFncmVlKiogdGhhdCB0 aGUgc3VnZ2VzdGlvbiBzaG91bGQgYmUgaW1wbGVtZW50ZWQNCiAgICA+ICsqIFRoZSAqKmF1dGhv ciBhbmQgcmV2aWV3ZXIgYWdyZWUqKiB0aGF0IGl0IG1heSBtYWtlIHNlbnNlIHRvIGRlZmVyIGlt cGxlbWVudGF0aW9uDQogICAgPiArKiBUaGUgKiphdXRob3IgYW5kIHJldmlld2VyIGFncmVlKiog dGhhdCBpdCBtYWtlcyBubyBzZW5zZSB0byBpbXBsZW1lbnQgdGhlIHN1Z2dlc3Rpb24NCiAgICA+ ICsNCiAgICA+ICtUaGUgYXV0aG9yIG9mIGEgcGF0Y2ggd291bGQgdHlwaWNhbGx5IHN1Z2dlc3Qg dGhlaXIgcHJlZmVycmVkIG91dGNvbWUsIGZvciBleGFtcGxlDQogICAgPiArPiBJIGFtIG5vdCBz dXJlIGl0IGlzIHdvcnRoIHRvIGltcGxlbWVudCBYWFgNCiAgICA+ICs+IERvIHlvdSB0aGluayB0 aGlzIGNvdWxkIGJlIGRvbmUgYXMgYSBzZXBhcmF0ZSBwYXRjaCBpbiBmdXR1cmU/DQogICAgPiAr DQogICAgPiArSW4gY2FzZXMsIHdoZXJlIG5vIGFncmVlbWVudCBjYW4gYmUgZm91bmQsIHRoZSBi ZXN0IGFwcHJvYWNoIHdvdWxkIGJlIHRvIGdldCBhbg0KICAgID4gK2luZGVwZW5kZW50IG9waW5p b24gZnJvbSBhbm90aGVyIG1haW50YWluZXIgb3IgdGhlIHByb2plY3QncyBsZWFkZXJzaGlwIHRl YW0uDQogICAgDQogICAgSSB0aGluayB3ZSBzaG91bGQgbWVudGlvbiBzb21ld2hlcmUgaGVyZSB0 aGF0IGl0IGlzIHJlY29tbWVuZGVkIGZvcg0KICAgIHJldmlld2VycyB0byBiZSBleHBsaWNpdCBh Ym91dCB3aGV0aGVyIGEgcmVxdWVzdCBpcyBvcHRpb25hbCBvciB3aGV0aGVyDQogICAgaXQgaXMg YSByZXF1aXJlbWVudC4NCiAgICANCiAgICBGb3IgaW5zdGFuY2U6ICJJIHRoaW5rIGl0IHdvdWxk IGJlIGdvb2QgaWYgWCBhbHNvIGRpZCBZIiBkb2Vzbid0IHNheSBpZg0KICAgIGl0IGlzIG9wdGlv bmFsIChmdXR1cmUgd29yaykgb3IgaXQgaXMgYWN0dWFsbHkgcmVxdWlyZWQgYXMgcGFydCBvZiB0 aGlzDQogICAgc2VyaWVzLiBNb3JlIGV4cGxpY2l0IHdvcmQgY2hvaWNlcyBhcmUgcHJlZmVyYWJs ZSwgc3VjaCBhczoNCiAgICANCiAgICAiSSB0aGluayBpdCB3b3VsZCBiZSBnb29kIGlmIFggYWxz byBkaWQgWSwgbm90IGEgcmVxdWlyZW1lbnQgYnV0IGdvb2QgdG8NCiAgICBoYXZlLiINCiAgICAN CiAgICAiSSB0aGluayBpdCB3b3VsZCBiZSBnb29kIGlmIFggYWxzbyBkaWQgWSBhbmQgaXQgc2hv dWxkIGJlIHBhcnQgb2YgdGhpcw0KICAgIHNlcmllcy4iDQogICAgDQogICAgSXQgaGVscHMgbWFr ZSB0aGUgY29tbXVuaWNhdGlvbiB3aXRoIHRoZSBhdXRob3IgbW9yZSBlZmZlY3RpdmUsDQogICAg ZXNwZWNpYWxseSBpbiB0aGlzIGtpbmQgb2Ygc2l0dWF0aW9ucy4NCiAgICANCkFncmVlZCAgICAN Cg0KICAgID4gKyMjIElzc3VlOiBbQmlrZXNoZWRkaW5nXShodHRwczovL2VuLndpa3Rpb25hcnku b3JnL3dpa2kvYmlrZXNoZWRkaW5nKQ0KICAgID4gKw0KICAgID4gK09jY2FzaW9uYWxseSBkaXNj dXNzaW9ucyBhYm91dCB1bmltcG9ydGFudCBidXQgZWFzeS10by1ncmFzcCBpc3N1ZXMgY2FuIGxl YWQgdG8NCiAgICA+ICtwcm9sb25nZWQgYW5kIHVucHJvZHVjdGl2ZSBkaXNjdXNzaW9uLiBUaGUg YmVzdCB3YXkgdG8gYXBwcm9hY2ggdGhpcyBpcyB0bw0KICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIF4gZGlzY3Vzc2lvbnMNCiAgICANCiAgICANCiAgICA+ICt0cnkgYW5kICoqYW50 aWNpcGF0ZSoqIGJpa2VzaGVkZGluZyBhbmQgaGlnaGxpZ2h0IGl0IGFzIHN1Y2ggdXBmcm9udC4g SG93ZXZlciwgdGhlDQogICAgPiArZm9ybWF0IG9mIGEgY29kZSByZXZpZXcgZG9lcyBub3QgYWx3 YXlzIGxlbmQgaXRzZWxmIHdlbGwgdG8gdGhpcyBhcHByb2FjaCwgZXhjZXB0DQogICAgPiArZm9y IGhpZ2hsaWdodGluZyBpdCBpbiB0aGUgY292ZXIgbGV0dGVyIG9mIGEgcGF0Y2ggc2VyaWVzLg0K ICAgID4gKw0KICAgID4gK0hvd2V2ZXIsIHR5cGljYWxseSBCaWtlc2hlZGRpbmcgaXNzdWVzIGFy ZSBmYWlybHkgZWFzeSB0byByZWNvZ25pemUgaW4gYSBjb2RlIHJldmlldywNCiAgICA+ICthcyB5 b3Ugd2lsbCB2ZXJ5IHF1aWNrbHkgZ2V0IGRpZmZlcmVudCByZXZpZXdlcnMgcHJvdmlkaW5nIGRp ZmZlcmluZyBvcGluaW9ucy4gSW4gdGhpcyBjYXNlDQogICAgPiAraXQgaXMgYmVzdCBmb3IgdGhl IGF1dGhvciBvciBhIHJldmlld2VyIHRvIGNhbGwgb3V0IHRoZSBwb3RlbnRpYWwgYmlrZXNoZWRk aW5nIGlzc3VlIHVzaW5nDQogICAgPiArc29tZXRoaW5nIGxpa2UNCiAgICA+ICsNCiAgICA+ICs+ IExvb2tzIHdlIGhhdmUgYSBiaWtlc2hlZGRpbmcgaXNzdWUgaGVyZQ0KICAgID4gKz4gSSB0aGlu ayB3ZSBzaG91bGQgY2FsbCBhIHF1aWNrIHZvdGUgdG8gc2V0dGxlIHRoZSBpc3N1ZQ0KICAgID4g Kw0KICAgID4gK091ciBnb3Zlcm5hbmNlIHByb3ZpZGVzIHRoZSBtZWNoYW5pc21zIG9mIFtpbmZv cm1hbCB2b3Rlc10oaHR0cHM6Ly94ZW5wcm9qZWN0Lm9yZy9kZXZlbG9wZXJzL2dvdmVybmFuY2Uv I2luZm9ybWFsLXZvdGVzLW9yLXN1cnZleXMpIG9yDQogICAgPiArW2xhenkgdm90aW5nXShodHRw czovL3hlbnByb2plY3Qub3JnL2RldmVsb3BlcnMvZ292ZXJuYW5jZS8jbGF6eWNvbnNlbnN1cykg d2hpY2ggbGVuZA0KICAgID4gK3RoZW1zZWx2ZXMgd2VsbCB0byByZXNvbHZlIHN1Y2ggaXNzdWVz Lg0KICAgID4gKw0KICAgID4gKyMjIElzc3VlOiBTbWFsbCBmdW5jdGlvbmFsIGlzc3Vlcw0KICAg ID4gKw0KICAgID4gK1RoZSBtb3N0IGNvbW1vbiBhcmVhIG9mIGRpc2FncmVlbWVudHMgd2hpY2gg aGFwcGVuIGluIGNvZGUgcmV2aWV3cywgYXJlIGRpZmZlcmluZw0KICAgID4gK29waW5pb25zIG9u IHdoZXRoZXIgc21hbGwgZnVuY3Rpb25hbCBpc3N1ZXMgaW4gYSBwYXRjaCBzZXJpZXMgaGF2ZSB0 byBiZSByZXNvbHZlZCBvcg0KICAgID4gK25vdCBiZWZvcmUgdGhlIGNvZGUgaXMgcmVhZHkgdG8g YmUgc3VibWl0dGVkLiBTdWNoIGRpc2FncmVlbWVudHMgYXJlIHR5cGljYWxseSBjYXVzZWQNCiAg ICA+ICtieSBkaWZmZXJlbnQgZXhwZWN0YXRpb25zIHJlbGF0ZWQgdG8gdGhlIGxldmVsIG9mIHBl cmZlY3Rpb24gYSBwYXRjaCBzZXJpZXMgbmVlZHMgdG8gZnVsZmlsDQogICAgPiArYmVmb3JlIGl0 IGNhbiBiZSBjb25zaWRlcmVkIHJlYWR5IHRvIGJlIGNvbW1pdHRlZC4NCiAgICA+ICsNCiAgICA+ ICtUbyBleHBsYWluIHRoaXMgYmV0dGVyLCBJIGFtIGdvaW5nIHRvIHVzZSB0aGUgYW5hbG9neSBv ZiBzb21lIGJ1aWxkaW5nIHdvcmsgdGhhdCBoYXMNCiAgICA+ICtiZWVuIHBlcmZvcm1lZCBhdCB5 b3VyIGhvdXNlLiBMZXQncyBzYXkgdGhhdCB5b3UgaGF2ZSBhIG5ldyBiYXRocm9vbSBpbnN0YWxs ZWQuDQogICAgPiArQmVmb3JlIHBheWluZyB5b3VyIGJ1aWxkZXIgdGhlIGxhc3QgaW5zdGFsbWVu dCwgeW91IHBlcmZvcm0gYW4gaW5zcGVjdGlvbiBhbmQgeW91IGZpbmQNCiAgICA+ICtpc3N1ZXMg c3VjaCBhcw0KICAgID4gKyogVGhlIHNlYWxzIGFyb3VuZCB0aGUgYmF0aHR1YiBhcmUgbm90IHBl cmZlY3RseSBldmVudA0KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBeIGV2ZW4NCiAgICANCiAgICA+ICsqIFdoZW4geW91IG9wZW4gdGhlIHRh cCwgdGhlIHBsdW1iaW5nIGluaXRpYWxseSBtYWtlcyBzb21lIGxvdWQgbm9pc2UNCiAgICA+ICsq IFRoZSBzaG93ZXIgbWl4ZXIgaGFzIGJlZW4gaW5zdGFsbGVkIHRoZSB3cm9uZyB3YXkgYXJvdW5k DQogICAgPiArDQogICAgPiArSW4gYWxsIHRoZXNlIGNhc2VzLCB0aGUgYmF0aHJvb20gaXMgcGVy ZmVjdGx5IGZ1bmN0aW9uYWwsIGJ1dCBub3QgcGVyZmVjdC4gQXQgdGhpcyBwb2ludA0KICAgID4g K3lvdSBoYXZlIHRoZSBjaG9pY2UgdG8gdHJ5IGFuZCBnZXQgYWxsIHRoZSBpc3N1ZXMgYWRkcmVz c2VkLCB3aGljaCBpbiB0aGUgZXhhbXBsZSBvZg0KICAgID4gK3RoZSBzaG93ZXIgbWl4ZXIgbWF5 IHJlcXVpcmUgc2lnbmlmaWNhbnQgcmUtd29yayBhbmQgcG90ZW50aWFsbHkgcHVzaC1iYWNrIGZy b20geW91cg0KICAgID4gK2J1aWxkZXIuIFlvdSBtYXkgaGF2ZSB0byByZWZlciB0byB0aGUgaW5p dGlhbCBzdGF0ZW1lbnQgb2Ygd29yaywgYnV0IGl0IHR1cm5zIG91dCBpdCBkb2VzDQogICAgPiAr bm90IGNvbnRhaW4gc3VmZmljaWVudCBpbmZvcm1hdGlvbiB0byBhc2NlcnRhaW4gd2hldGhlciB5 b3VyIGJ1aWxkZXIgaGFkIGNvbW1pdHRlZCB0bw0KICAgID4gK3RoZSBsZXZlbCBvZiBxdWFsaXR5 IHlvdSB3ZXJlIGV4cGVjdGluZy4NCiAgICA+ICsNCiAgICA+ICtTaW1pbGFyIHNpdHVhdGlvbnMg aGFwcGVuIGluIGNvZGUgcmV2aWV3cyB2ZXJ5IGZyZXF1ZW50bHkgYW5kIGNhbiBsZWFkIHRvIGEg bG9uZw0KICAgID4gK2Rpc2N1c3Npb24gYmVmb3JlIGl0IGNhbiBiZSByZXNvbHZlZC4gVGhlIG1v c3QgaW1wb3J0YW50IHRoaW5nIGlzIHRvICoqaWRlbnRpZnkqKg0KICAgID4gK2EgZGlzYWdyZWVt ZW50IGFzIHN1Y2ggZWFybHkgYW5kIHRoZW4gY2FsbCBpdCBvdXQuIFRpcHMgb24gaG93IHRvIGRv IHRoaXMsIGNhbiBiZSBmb3VuZA0KICAgID4gK1toZXJlXShjb21tdW5pY2F0aW9uLXByYWN0aWNl Lm1kI01pc3VuZGVyc3RhbmRpbmdzKS4NCiAgICA+ICsNCiAgICA+ICtBdCB0aGlzIHBvaW50LCB5 b3Ugd2lsbCB1bmRlcnN0YW5kIHdoeSB5b3UgaGF2ZSB0aGUgZGlzYWdyZWVtZW50LCBidXQgbm90 IG5lY2Vzc2FyaWx5DQogICAgPiArYWdyZWVtZW50IG9uIGhvdyB0byBtb3ZlIGZvcndhcmQuIEFu IGVhc3kgZml4IHdvdWxkIGJlIHRvIGFncmVlIHRvIHN1Ym1pdCB0aGUgY2hhbmdlDQogICAgPiAr YXMgaXQgaXMgYW5kIGZpeCBpdCBpbiBmdXR1cmUuIEluIGEgY29ycG9yYXRlIHNvZnR3YXJlIGVu Z2luZWVyaW5nIGVudmlyb25tZW50IHRoaXMgaXMgdGhlDQogICAgPiArbW9zdCBsaWtlbHkgb3V0 Y29tZSwgYnV0IGluIG9wZW4gc291cmNlIGNvbW11bml0aWVzIGFkZGl0aW9uYWwgY29uY2VybnMg aGF2ZSB0byBiZQ0KICAgID4gK2NvbnNpZGVyZWQuDQogICAgPiArKiBDb2RlIHJldmlld2VycyBm cmVxdWVudGx5IGhhdmUgYmVlbiBpbiB0aGlzIHNpdHVhdGlvbiBiZWZvcmUgd2l0aCB0aGUgbW9z dCBjb21tb24NCiAgICA+ICsgIG91dGNvbWUgdGhhdCB0aGUgaXNzdWUgaXMgdGhlbiBuZXZlciBm aXhlZC4gQnkgYWNjZXB0aW5nIHRoZSBjaGFuZ2UsIHRoZSByZXZpZXdlcnMNCiAgICA+ICsgIGhh dmUgbm8gbGV2ZXJhZ2UgdG8gZml4IHRoZSBpc3N1ZSBhbmQgbWF5IGhhdmUgdG8gc3BlbmQgZWZm b3J0IGZpeGluZyB0aGUgaXNzdWUNCiAgICA+ICsgIHRoZW1zZWx2ZXMgaW4gZnV0dXJlIGFzIGl0 IG1heSBpbXBhY3QgdGhlIHByb2R1Y3QgdGhleSBidWlsdCBvbiB0b3Agb2YgdGhlIGNvZGUuDQog ICAgPiArKiBDb252ZXJzZWx5LCBhIHJldmlld2VyIG1heSBiZSBhc2tpbmcgdGhlIGF1dGhvciB0 byBtYWtlIHRvbyBtYW55IGNoYW5nZXMgb2YgdGhpcw0KICAgID4gKyAgdHlwZSB3aGljaCB1bHRp bWF0ZWx5IG1heSBsZWFkIHRoZSBhdXRob3IgdG8gbm90IGNvbnRyaWJ1dGUgdG8gdGhlIHByb2pl Y3QgYWdhaW4uDQogICAgPiArKiBBbiBhdXRob3IsIHdoaWNoIGNvbnNpc3RlbnRseSBkb2VzIG5v dCBhZGRyZXNzICoqYW55Kiogb2YgdGhlc2UgaXNzdWVzIG1heSBlbmQgdXANCiAgICA+ICsgIGdl dHRpbmcgYSBiYWQgcmVwdXRhdGlvbiBhbmQgbWF5IGZpbmQgZnV0dXJlIGNvZGUgcmV2aWV3cyBt b3JlIGRpZmZpY3VsdC4NCiAgICA+ICsqIEFuIGF1dGhvciB3aGljaCBhbHdheXMgYWRkcmVzc2Vz ICoqYWxsKiogb2YgdGhlc2UgaXNzdWVzIG1heSBlbmQgdXAgZ2V0dGluZyBpbnRvDQogICAgPiAr ICBkaWZmaWN1bHRpZXMgd2l0aCB0aGVpciBlbXBsb3llciwgYXMgdGhleSBhcmUgdG9vIHNsb3cg Z2V0dGluZyBjb2RlIHVwc3RyZWFtZWQuDQogICAgPiArDQogICAgPiArTm9uZSBvZiB0aGVzZSBv dXRjb21lcyBhcmUgZ29vZCwgc28gdWx0aW1hdGVseSBhIGJhbGFuY2UgaGFzIGJlZW4gZm91bmQu IEF0IHRoZSBlbmQNCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBeIHlvdSBtZWFuICJoYXMgdG8gYmUgZm91bmQ/Ig0KICAgIA0K ICAgIA0KICAgID4gK29mIHRoZSBkYXksIHRoZSBzb2x1dGlvbiBzaG91bGQgZm9jdXMgb24gd2hh dCBpcyBiZXN0IGZvciB0aGUgY29tbXVuaXR5LCB3aGljaCBtYXkNCiAgICA+ICttZWFuIGFza2lu ZyBmb3IgYW4gaW5kZXBlbmRlbnQgb3BpbmlvbiBhcyBvdXRsaW5lZCBpbiB0aGUgbmV4dCBzZWN0 aW9uLg0KICAgIA0KICAgIEkgdGhpbmsgdGhlcmUgaXMgc29tZXRoaW5nIGVsc2Ugd2Ugc2hvdWxk IHNheSBvbiB0aGlzIHRvcGljLiBUaGVyZSBpcyBhDQogICAgY2F0ZWdvcnkgb2YgdGhpbmdzIHdo aWNoIGNvdWxkIGJlIGRvbmUgaW4gbXVsdGlwbGUgd2F5cyBhbmQgaXQgaXMgbm90DQogICAgb3Zl cnRseSBvYnZpb3VzIHdoaWNoIG9uZSBpcyBiZXN0LiBJdCBpcyBkb25lIHRvIHRoZSBtYWludGFp bmVyIGFuZCB0aGUNCiAgICBhdXRob3IgcGVyc29uYWwgc3R5bGVzLiBJdCBpcyBlYXN5IHRvIGRp c2FncmVlIG9uIHRoYXQuDQogICAgDQogICAgSSB0aGluayBhIGdvb2QgcmVjb21tZW5kYXRpb24g d291bGQgYmUgZm9yIHRoZSBjb250cmlidXRvciB0byB0cnkgdG8NCiAgICBmb2xsb3cgdGhlIG1h aW50YWluZXJzIHJlcXVlc3RzLCBldmVuIGlmIHRoZXkgY291bGQgYmUgY29uc2lkZXJlZA0KICAg ICJzdHlsZSIsIHRydXN0aW5nIHRoZWlyIGV4cGVyaWVuY2Ugb24gdGhlIG1hdHRlci4gQW5kIGEg Z29vZA0KICAgIHJlY29tbWVuZGF0aW9uIGZvciB0aGUgbWFpbnRhaW5lciB3b3VsZCBiZSB0byB0 cnkgdG8gbGV0IHRoZSBjb250cmlidXRvcg0KICAgIGhhdmUgZnJlZWRvbSBvZiBpbXBsZW1lbnRh dGlvbiBjaG9pY2Ugb24gdGhpbmdzIHRoYXQgZG9uJ3QgbWFrZSBhDQogICAgc2lnbmlmaWNhbnQg ZGlmZmVyZW5jZS4NCiAgICANCkFncmVlZC4NCiAgICANCiAgICA+ICsjIyBSZXNvbHV0aW9uOiBB c2tpbmcgZm9yIGFuIGluZGVwZW5kZW50IG9waW5pb24NCiAgICA+ICsNCiAgICA+ICtNb3N0IGRp c2FncmVlbWVudHMgY2FuIGJlIHNldHRsZWQgYnkNCiAgICA+ICsqIEFza2luZyBhbm90aGVyIG1h aW50YWluZXIgb3IgY29tbWl0dGVyIHRvIHByb3ZpZGUgYW4gaW5kZXBlbmRlbnQgb3BpbmlvbiBv biB0aGUNCiAgICA+ICsgIHNwZWNpZmljIGlzc3VlIGluIHB1YmxpYyB0byBoZWxwIHJlc29sdmUg aXQNCiAgICA+ICsqIEZhaWxpbmcgdGhpcyBhbiBpc3N1ZSBjYW4gYmUgZXNjYWxhdGVkIHRvIHRo ZSBwcm9qZWN0IGxlYWRlcnNoaXAgdGVhbSwgd2hpY2ggaXMNCiAgICA+ICsgIGV4cGVjdGVkIHRv IGFjdCBhcyByZWZlcmVlIGFuZCBtYWtlIGEgZGVjaXNpb24gb24gYmVoYWxmIG9mIHRoZSBjb21t dW5pdHkNCiAgICA+ICsNCiAgICA+ICtJZiB5b3UgZmVlbCB1bmNvbWZvcnRhYmxlIHdpdGggdGhp cyBhcHByb2FjaCwgeW91IG1heSBhbHNvIGNvbnRhY3QNCiAgICA+ICttZWRpYXRpb25AeGVucHJv amVjdC5vcmcgdG8gZ2V0IGFkdmljZS4gU2VlIG91ciBbQ29tbXVuaWNhdGlvbiBHdWlkZV0oY29t bXVuaWNhdGlvbi1ndWlkZS5tZCkNCiAgICA+ICtmb3IgbW9yZSBpbmZvcm1hdGlvbi4NCiAgICA+ ICsNCiAgICA+ICsjIyBEZWNpc2lvbiBtYWtpbmcgYW5kIGNvbmZsaWN0IHJlc29sdXRpb24gaW4g b3VyIGdvdmVybmFuY2UNCiAgICA+ICsNCiAgICA+ICtPdXIgW2dvdmVybmFuY2VdKGh0dHBzOi8v eGVucHJvamVjdC5vcmcvZGV2ZWxvcGVycy9nb3Zlcm5hbmNlLyNkZWNpc2lvbnMpIGNvbnRhaW5z DQogICAgPiArc2V2ZXJhbCBwcm92ZW4gbWVjaGFuaXNtcyB0byBoZWxwIHdpdGggZGVjaXNpb24g bWFraW5nIGFuZCBjb25mbGljdCByZXNvbHV0aW9uLg0KICAgID4gKw0KICAgID4gK1NlZQ0KICAg ID4gKyogW0V4cHJlc3NpbmcgYWdyZWVtZW50IGFuZCBkaXNhZ3JlZW1lbnRdKGh0dHBzOi8veGVu cHJvamVjdC5vcmcvZGV2ZWxvcGVycy9nb3Zlcm5hbmNlLyNleHByZXNzaW5nb3BpbmlvbikNCiAg ICA+ICsqIFtMYXp5IGNvbnNlbnN1cyAvIExhenkgdm90aW5nXShodHRwczovL3hlbnByb2plY3Qu b3JnL2RldmVsb3BlcnMvZ292ZXJuYW5jZS8jbGF6eWNvbnNlbnN1cykNCiAgICA+ICsqIFtJbmZv cm1hbCB2b3RlcyBvciBzdXJ2ZXlzXShodHRwczovL3hlbnByb2plY3Qub3JnL2RldmVsb3BlcnMv Z292ZXJuYW5jZS8jaW5mb3JtYWwtdm90ZXMtb3Itc3VydmV5cykNCiAgICA+ICsqIFtMZWFkZXJz aGlwIHRlYW0gZGVjaXNpb25zXShodHRwczovL3hlbnByb2plY3Qub3JnL2RldmVsb3BlcnMvZ292 ZXJuYW5jZS8jbGVhZGVyc2hpcCkNCiAgICA+ICsqIFtDb25mbGljdCByZXNvbHV0aW9uXShodHRw czovL3hlbnByb2plY3Qub3JnL2RldmVsb3BlcnMvZ292ZXJuYW5jZS8jY29uZmxpY3QpDQogICAg PiAtLSANCiAgICA+IDIuMTMuMA0KICAgID4gDQogICAgDQoNCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1hcGkgbWFpbGluZyBsaXN0Clhlbi1hcGlA bGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFu L2xpc3RpbmZvL3hlbi1hcGkK From xen-api-bounces@lists.xenproject.org Fri Nov 29 02:11:07 2019 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Nov 2019 02:11:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaVkN-0001K7-2o; Fri, 29 Nov 2019 02:11:03 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaVkL-0001K2-Sf for xen-api@lists.xenproject.org; Fri, 29 Nov 2019 02:11:01 +0000 X-Inumbo-ID: 7b2e1d84-124d-11ea-a3db-12813bfff9fa Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7b2e1d84-124d-11ea-a3db-12813bfff9fa; Fri, 29 Nov 2019 02:10:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1574993458; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=3cPGkvjFxrnt7mArXi98hp4XtgJhHmSPh6RmhQYO+2c=; b=NAkhMxibP0gYpIfwpRpMCSJXkVIA4InTLn9qMy6Os0OLz1+szz3Q1Laj 7nIZVZyLr9mTOz/+Oe8XMEX03xsVr/4Rrx+tSl3eRyPjNJoZpIcHsO0MR JVAX5X6+Vpp3h6V0qL1ODvpAim4JPY4rbLLaYK7s8Fk4rzo4HHQqNRPX9 s=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=lars.kurth@citrix.com; spf=Pass smtp.mailfrom=lars.kurth@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa5.hc3370-68.iphmx.com: no sender authenticity information available from domain of lars.kurth@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="lars.kurth@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa5.hc3370-68.iphmx.com: domain of lars.kurth@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="lars.kurth@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa5.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: PFnbT/FyJRMEkMjEkUwxNcomifQ+KN9JIYT9y1j059/YkxX9Vmgx/TMa7nUxwujBOvmlzN3nzT s1Ng6rbdtcQWu9YsQtoCICge5/Al2ZGL7nIfTybNPumsEkWBb0sBAiGmDQoBXABfmFPmoofYSR 9TKgfZaVjiiMJDjLujgFrEiAYgvmxJNx9BNyRQOUVLZv1FqHfWA9b8pKLa/Mbx5mbAM/KlLeMj X2owAxCuTc9ZFSLi6S38N7heGncMhKqc9IDXthHhnQ7LQP9/iNE8M4PShIyN22laEgGu8Ju5wL z4A= X-SBRS: 2.7 X-MesageID: 9325828 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.69,255,1571716800"; d="scan'208";a="9325828" From: Lars Kurth To: Stefano Stabellini , Jan Beulich Thread-Topic: [Xen-devel] [PATCH v2 6/6] Added Resolving Disagreement Thread-Index: AQHVdKIlkhvO00R580a3wEu9+2XsyaegEysAgACdNQCAAI8ZAIAAFkkA Date: Fri, 29 Nov 2019 02:10:36 +0000 Message-ID: References: <2e4b36afaa73277d246d7e84037db1532a136ec7.1569525222.git.lars.kurth@citrix.com> <22b7f67c-c3dc-5450-999f-e79168175d39@suse.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/10.10.10.191111 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted Content-ID: MIME-Version: 1.0 Subject: Re: [Xen-API] [Xen-devel] [PATCH v2 6/6] Added Resolving Disagreement X-BeenThere: xen-api@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: User and development list for XCP and XAPI List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Lars Kurth , "xen-api@lists.xenproject.org" , "minios-devel@lists.xenproject.org" , "committers@xenproject.org" , "mirageos-devel@lists.xenproject.org" , "xen-devel@lists.xenproject.org" , "win-pv-devel@lists.xenproject.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-api-bounces@lists.xenproject.org Sender: "Xen-api" DQoNCu+7v09uIDI4LzExLzIwMTksIDEyOjUwLCAiU3RlZmFubyBTdGFiZWxsaW5pIiA8c3N0YWJl bGxpbmlAa2VybmVsLm9yZz4gd3JvdGU6DQoNCiAgICBPbiBUaHUsIDI4IE5vdiAyMDE5LCBKYW4g QmV1bGljaCB3cm90ZToNCiAgICA+IE9uIDI4LjExLjIwMTkgMDE6NTYsIFN0ZWZhbm8gU3RhYmVs bGluaSB3cm90ZToNCiAgICA+ID4gT24gVGh1LCAyNiBTZXAgMjAxOSwgTGFycyBLdXJ0aCB3cm90 ZToNCg0KICAgID4gPiBJIHRoaW5rIGEgZ29vZCByZWNvbW1lbmRhdGlvbiB3b3VsZCBiZSBmb3Ig dGhlIGNvbnRyaWJ1dG9yIHRvIHRyeSB0bw0KICAgID4gPiBmb2xsb3cgdGhlIG1haW50YWluZXJz IHJlcXVlc3RzLCBldmVuIGlmIHRoZXkgY291bGQgYmUgY29uc2lkZXJlZA0KICAgID4gPiAic3R5 bGUiLCB0cnVzdGluZyB0aGVpciBleHBlcmllbmNlIG9uIHRoZSBtYXR0ZXIuIEFuZCBhIGdvb2QN CiAgICA+ID4gcmVjb21tZW5kYXRpb24gZm9yIHRoZSBtYWludGFpbmVyIHdvdWxkIGJlIHRvIHRy eSB0byBsZXQgdGhlIGNvbnRyaWJ1dG9yDQogICAgPiA+IGhhdmUgZnJlZWRvbSBvZiBpbXBsZW1l bnRhdGlvbiBjaG9pY2Ugb24gdGhpbmdzIHRoYXQgZG9uJ3QgbWFrZSBhDQogICAgPiA+IHNpZ25p ZmljYW50IGRpZmZlcmVuY2UuDQogICAgPiANCiAgICA+IEkgdGhpbmsgd2UgdHJ5IHRvLCBidXQg SSBhbHNvIHRoaW5rIHdlIHN1ZmZlciBmcm9tIHRvbyBsaXR0bGUNCiAgICA+IGNsZWFyIGRvY3Vt ZW50YXRpb24gb24gZS5nLiBzdHlsZSBhc3BlY3RzLiBBdHRlbXB0cyBvbiBteSBwYXJ0DQogICAg PiB0byBhZGRyZXNzIHRoaXMgaGF2ZSBtb3N0bHkgKG5vdCBlbnRpcmVseSkgbGVhZCBuby13aGVy ZSAobGFjayBvZg0KICAgID4gZmVlZGJhY2sgb24gcHJvcG9zZWQgcGF0Y2hlcyB0byAuL0NPRElO R19TVFlMRSkuIFNvIGZvciB0aGUgdGltZQ0KICAgID4gYmVpbmcgdGhlcmUgYXJlIChtYW55KSBh c3BlY3RzIHdoZXJlIHdlIGhhdmUgZGUtZmFjdG8gZXhwZWN0YXRpb25zDQogICAgPiB0aGF0IGFy ZW4ndCB3cml0dGVuIGRvd24gYW55d2hlcmUsIHdpdGggdGhlIHJlc3VsdCBvZiAoaW4gYSBzdWJz ZXQNCiAgICA+IG9mIGNhc2VzKSBkaXNhZ3JlZW1lbnQgb24gd2hhdCB0aGUgcGVyY2VpdmVkIGRl LWZhY3RvIHN0YW5kYXJkDQogICAgPiBhY3R1YWxseSBpcy4NCiAgICANCiAgICBJIHJlY29nbml6 ZSB0aGF0IGl0IGNvdWxkIGJlIGNoYWxsZW5naW5nIGZpbmRpbmcgYSBjb25zZW5zdXMgdG8gdXBk YXRlDQogICAgQ09ESU5HX1NUWUxFIGJ1dCBpdCBtaWdodCBiZSB3b3J0aCBkb2luZyB0byByZWR1 Y2UgZnJpY3Rpb25zIHdpdGggYm90aA0KICAgIGNvbnRyaWJ1dG9ycyBhbmQgb3RoZXIgcmV2aWV3 ZXJzLg0KICAgIA0KICAgIEJ1dCB0byBiZSBjbGVhciwgSSB3YXMgYWxzbyByZWZlcnJpbmcgdG8g dGhpbmdzIHRoYXQgbWlnaHQgYmUgYWN0dWFsbHkNCiAgICBoYXJkIHRvIGFkZCB0byBDT0RJTkdf U1RZTEUsIHN1Y2ggYXMgbWFjcm8gdnMuIHN0YXRpYyBpbmxpbmVzLCB3aGVuIHRvDQogICAgc3Bs aXQgYSBzaW5nbGUgZnVuY3Rpb24gaW50byBtdWx0aXBsZSBzbWFsbGVyIGZ1bmN0aW9ucywgZXRj Lg0KICAgIA0KSSB0aGluayB0aGlzIGlzIGRlZmluaXRlbHkgc29tZXRoaW5nIHdlIG91Z2h0IHRv IGRvLiBJIGFtIHZvbHVudGVlcmluZyB0bw0KcGljayB0aGlzIHVwLCBidXQgY2hhbmdpbmcvY2xh cmlmeWluZyB0aGUgQ09ESU5HX1NUWUxFIG5lZWRzIHRvIGJlIA0KY29uc2lkZXJlZCBpbiBjb25q dW5jdGlvbiB3aXRoIGNoZWNraW5nIHRvb2xzDQoNCkkgaGF2ZSBwYXJrZWQgdGhpcyBmb3Igbm93 LCBhcw0KYSkgSSBkaWQgbm90IHdhbnQgdG8gZGlzcnVwdCA0LjEzIA0KYikgYW5kIHVudGlsIHJl Y2VudGx5IEkgYWxzbyBkaWRu4oCZdCBmdWxseSB1bmRlcnN0YW5kIHdoYXQga2luZCBvZiBjb2Rp bmcNCnN0YW5kYXJkcyB3b3VsZCBoZWxwIHdpdGggc2FmZXR5IGNlcnRpZmljYXRpb24NCg0KQW5k IG9mIGNvdXJzZSwgaGF2aW5nIGEgYm90IGRvIHRoZSBjaGVja2luZyB3b3VsZCByZW1vdmUgdGhl IGZyaWN0aW9uDQplbnRpcmVseS4gDQoNCkxhcnMNCg0KDQpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tYXBpIG1haWxpbmcgbGlzdApYZW4tYXBpQGxp c3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9s aXN0aW5mby94ZW4tYXBpCg==