From xen-api-bounces@lists.xenproject.org Wed Dec 18 17:09:50 2019 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 Dec 2019 17:09:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ihcpT-0001wj-I2; Wed, 18 Dec 2019 17:09:43 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ihcpS-0001wY-Hf for xen-api@lists.xenproject.org; Wed, 18 Dec 2019 17:09:42 +0000 X-Inumbo-ID: 27033462-21b9-11ea-90ce-12813bfff9fa Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 27033462-21b9-11ea-90ce-12813bfff9fa; Wed, 18 Dec 2019 17:09:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1576688971; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=jNIhcddd0bO+CkEmQ6ulaol2vyUiU1n94IYXvS0vGEA=; b=Y6LEnMtaPNVgHt2wHw8C7N2ssbHxYzVGTjVaRHIbUH/RBbqtTBJmqh99 aOLlVsKquJfHlwyStGK9U50UFmoWOwUy8TTDuu6JZhrtGLEO39xnwQnZn FCSVQYfluX7WqHnRqPE+97/X9G/LB6HtbZPqyuP54YQyowt/8dU7O3Nc1 Y=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=lars.kurth@citrix.com; spf=Pass smtp.mailfrom=lars.kurth@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of lars.kurth@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="lars.kurth@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa1.hc3370-68.iphmx.com: domain of lars.kurth@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="lars.kurth@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="lars.kurth@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: VsBcbBGGXCbAcN2P6qWVIJ3tssSaSQxWYfS2rGPd3+6nXdTMKzl72JL+BwHeBfpWRmU4Iq6VAQ e+xyMcNtP4677dVMvGNhV7ItJ2FllUAzFO5rn5duovyfuRoFeBlPVDhU5MJds/4w4+5hgRxi68 SjWwNAS06b8pkGsdiwx3DJRFqHZssEayecxtuhtJhKTvyMUtiIBSgBIoGHRj/LhOx7NiBWR1e2 m/WuEpQur9ANBZdRMUg/HYBijNIU7+S6yI67gSAfhWTZt2LOKeRYEDTRxI6t/TOvZL7sXEA9Ei htM= X-SBRS: 2.7 X-MesageID: 10034170 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.69,330,1571716800"; d="scan'208";a="10034170" From: Lars Kurth To: Julien Grall , Lars Kurth , "xen-devel@lists.xenproject.org" Thread-Topic: [PATCH v3 5/7] Add Code Review Guide Thread-Index: AQHVsTE52Xd4Fx4F50OKdcHmKTc7r6e/7A8AgAAseIA= Date: Wed, 18 Dec 2019 17:09:00 +0000 Message-ID: <0DE885E1-C4C3-447A-8408-88D43B9FE355@citrix.com> References: <98ab54c95a9541c918dfec529bcfc5867fd3ed33.1576184325.git.lars.kurth@citrix.com> <7a043307-f23f-c537-012b-393f59617c1c@xen.org> In-Reply-To: <7a043307-f23f-c537-012b-393f59617c1c@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/10.10.11.191208 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted Content-ID: MIME-Version: 1.0 Subject: Re: [Xen-API] [PATCH v3 5/7] Add Code Review Guide X-BeenThere: xen-api@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: User and development list for XCP and XAPI List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "minios-devel@lists.xenproject.org" , "xen-api@lists.xenproject.org" , "win-pv-devel@lists.xenproject.org" , "committers@xenproject.org" , "mirageos-devel@lists.xenproject.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-api-bounces@lists.xenproject.org Sender: "Xen-api" DQoNCu+7v09uIDE4LzEyLzIwMTksIDE0OjI5LCAiSnVsaWVuIEdyYWxsIiA8anVsaWVuQHhlbi5v cmc+IHdyb3RlOg0KDQogICAgSGkgTGFycywNCiAgICANCiAgICBPbiAxMi8xMi8yMDE5IDIxOjE0 LCBMYXJzIEt1cnRoIHdyb3RlOg0KICAgID4gKyMjIyBXb3JrZmxvdyBmcm9tIGFuIEF1dGhvcidz IFBlcnNwZWN0aXZlDQogICAgPiArDQogICAgPiArV2hlbiBjb2RlIGF1dGhvcnMgcmVjZWl2ZSBm ZWVkYmFjayBvbiB0aGVpciBwYXRjaGVzLCB0aGV5IHR5cGljYWxseSBmaXJzdCB0cnkNCiAgICA+ ICt0byBjbGFyaWZ5IGZlZWRiYWNrIHRoZXkgZG8gbm90IHVuZGVyc3RhbmQuIEZvciBzbWFsbGVy IHBhdGNoZXMgb3IgcGF0Y2ggc2VyaWVzDQogICAgPiAraXQgbWFrZXMgc2Vuc2UgdG8gd2FpdCB1 bnRpbCByZWNlaXZpbmcgZmVlZGJhY2sgb24gdGhlIGVudGlyZSBzZXJpZXMgYmVmb3JlDQogICAg PiArc2VuZGluZyBvdXQgYSBuZXcgdmVyc2lvbiBhZGRyZXNzaW5nIHRoZSBjaGFuZ2VzLiBGb3Ig bGFyZ2VyIHNlcmllcywgaXQgbWF5DQogICAgPiArbWFrZSBzZW5zZSB0byBzZW5kIG91dCBhIG5l dyByZXZpc2lvbiBlYXJsaWVyLg0KICAgID4gKw0KICAgID4gK0FzIGEgcmV2aWV3ZXIsIHlvdSBu ZWVkIHNvbWUgc3lzdGVtIHRoYXQgaGU7cHMgZW5zdXJlIHRoYXQgeW91IGFkZHJlc3MgYWxsDQog ICAgDQogICAgSnVzdCBhIHNtYWxsIHR5cG86IEkgdGhpbmsgeW91IG1lYW50ICJoZWxwcyIgcmF0 aGVyIHRoYW4gImhlO3BzIi4NCiAgICANCiAgICBDaGVlcnMsDQogICAgDQpUaGFuayB5b3U6IGZp eGVkIGluIG15IHdvcmtpbmcgY29weS4NCg0KT25lIHRoaW5nIHdoaWNoIG9jY3VycmVkIHRvIG1l IGZvciByZXZpZXdzIGxpa2UgdGhlc2UsIHdoZXJlIHRoZXJlIGlzIG5vIEFDSydzIG9yIFJldmll d2VkLWJ5J3MgaXMgdGhhdCBJIGRvbid0IGFjdHVhbGx5IGtub3cgd2hldGhlciB5b3UgYXMgcmV2 aWV3ZXIgaXMgb3RoZXJ3aXNlIGhhcHB5IHdpdGggdGhlIHJlbWFpbmRlciBvZiBwYXRjaC4NCk5v cm1hbGx5IHRoZSBBQ0tlZC1ieSBvciBSZXZpZXdlZC1ieSBpcyBhIHNpZ25hbCB0aGF0IGl0IGlz DQoNCkkgYW0gYXNzdW1pbmcgaXQgaXMsIGJ1dCBJIHRoaW5rIGl0IG1heSBiZSB3b3J0aHdoaWxl IHBvaW50aW5nIHRoaXMgb3V0IGluIHRoZSBkb2N1bWVudCwgdGhhdCB1bmxlc3Mgc3RhdGVkIG90 aGVyd2lzZSwgdGhlIHJldmlld2VyIGlzIGhhcHB5IHdpdGggdGhlIHBhdGNoDQoNClJlZ2FyZHMN CkxhcnMgDQoNCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Clhlbi1hcGkgbWFpbGluZyBsaXN0Clhlbi1hcGlAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6 Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1hcGkK From xen-api-bounces@lists.xenproject.org Thu Dec 19 09:56:55 2019 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 Dec 2019 09:56:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ihsY5-00058x-Kt; Thu, 19 Dec 2019 09:56:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ihsY4-00058k-63 for xen-api@lists.xenproject.org; Thu, 19 Dec 2019 09:56:48 +0000 X-Inumbo-ID: c4ef7992-2245-11ea-a1e1-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c4ef7992-2245-11ea-a1e1-bc764e2007e4; Thu, 19 Dec 2019 09:56:04 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 405D6AF41; Thu, 19 Dec 2019 09:56:03 +0000 (UTC) To: Lars Kurth , Lars Kurth References: <98ab54c95a9541c918dfec529bcfc5867fd3ed33.1576184325.git.lars.kurth@citrix.com> <7a043307-f23f-c537-012b-393f59617c1c@xen.org> <0DE885E1-C4C3-447A-8408-88D43B9FE355@citrix.com> From: Jan Beulich Message-ID: <1ed2d421-7dfe-1d92-5edc-7f11e8409ff7@suse.com> Date: Thu, 19 Dec 2019 10:56:31 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <0DE885E1-C4C3-447A-8408-88D43B9FE355@citrix.com> Content-Language: en-US Subject: Re: [Xen-API] [PATCH v3 5/7] Add Code Review Guide X-BeenThere: xen-api@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: User and development list for XCP and XAPI List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Julien Grall , "xen-api@lists.xenproject.org" , "minios-devel@lists.xenproject.org" , "committers@xenproject.org" , "mirageos-devel@lists.xenproject.org" , "xen-devel@lists.xenproject.org" , "win-pv-devel@lists.xenproject.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-api-bounces@lists.xenproject.org Sender: "Xen-api" T24gMTguMTIuMjAxOSAxODowOSwgTGFycyBLdXJ0aCB3cm90ZToKPiAKPiAKPiDvu79PbiAxOC8x Mi8yMDE5LCAxNDoyOSwgIkp1bGllbiBHcmFsbCIgPGp1bGllbkB4ZW4ub3JnPiB3cm90ZToKPiAK PiAgICAgSGkgTGFycywKPiAgICAgCj4gICAgIE9uIDEyLzEyLzIwMTkgMjE6MTQsIExhcnMgS3Vy dGggd3JvdGU6Cj4gICAgID4gKyMjIyBXb3JrZmxvdyBmcm9tIGFuIEF1dGhvcidzIFBlcnNwZWN0 aXZlCj4gICAgID4gKwo+ICAgICA+ICtXaGVuIGNvZGUgYXV0aG9ycyByZWNlaXZlIGZlZWRiYWNr IG9uIHRoZWlyIHBhdGNoZXMsIHRoZXkgdHlwaWNhbGx5IGZpcnN0IHRyeQo+ICAgICA+ICt0byBj bGFyaWZ5IGZlZWRiYWNrIHRoZXkgZG8gbm90IHVuZGVyc3RhbmQuIEZvciBzbWFsbGVyIHBhdGNo ZXMgb3IgcGF0Y2ggc2VyaWVzCj4gICAgID4gK2l0IG1ha2VzIHNlbnNlIHRvIHdhaXQgdW50aWwg cmVjZWl2aW5nIGZlZWRiYWNrIG9uIHRoZSBlbnRpcmUgc2VyaWVzIGJlZm9yZQo+ICAgICA+ICtz ZW5kaW5nIG91dCBhIG5ldyB2ZXJzaW9uIGFkZHJlc3NpbmcgdGhlIGNoYW5nZXMuIEZvciBsYXJn ZXIgc2VyaWVzLCBpdCBtYXkKPiAgICAgPiArbWFrZSBzZW5zZSB0byBzZW5kIG91dCBhIG5ldyBy ZXZpc2lvbiBlYXJsaWVyLgo+ICAgICA+ICsKPiAgICAgPiArQXMgYSByZXZpZXdlciwgeW91IG5l ZWQgc29tZSBzeXN0ZW0gdGhhdCBoZTtwcyBlbnN1cmUgdGhhdCB5b3UgYWRkcmVzcyBhbGwKPiAg ICAgCj4gICAgIEp1c3QgYSBzbWFsbCB0eXBvOiBJIHRoaW5rIHlvdSBtZWFudCAiaGVscHMiIHJh dGhlciB0aGFuICJoZTtwcyIuCj4gICAgIAo+ICAgICBDaGVlcnMsCj4gICAgIAo+IFRoYW5rIHlv dTogZml4ZWQgaW4gbXkgd29ya2luZyBjb3B5Lgo+IAo+IE9uZSB0aGluZyB3aGljaCBvY2N1cnJl ZCB0byBtZSBmb3IgcmV2aWV3cyBsaWtlIHRoZXNlLCB3aGVyZSB0aGVyZSBpcyBubyBBQ0sncyBv ciBSZXZpZXdlZC1ieSdzIGlzIHRoYXQgSSBkb24ndCBhY3R1YWxseSBrbm93IHdoZXRoZXIgeW91 IGFzIHJldmlld2VyIGlzIG90aGVyd2lzZSBoYXBweSB3aXRoIHRoZSByZW1haW5kZXIgb2YgcGF0 Y2guCj4gTm9ybWFsbHkgdGhlIEFDS2VkLWJ5IG9yIFJldmlld2VkLWJ5IGlzIGEgc2lnbmFsIHRo YXQgaXQgaXMKPiAKPiBJIGFtIGFzc3VtaW5nIGl0IGlzLCBidXQgSSB0aGluayBpdCBtYXkgYmUg d29ydGh3aGlsZSBwb2ludGluZyB0aGlzIG91dCBpbiB0aGUgZG9jdW1lbnQsIHRoYXQgdW5sZXNz IHN0YXRlZCBvdGhlcndpc2UsIHRoZSByZXZpZXdlciBpcyBoYXBweSB3aXRoIHRoZSBwYXRjaAoK SSBkb24ndCB0aGluayB0aGVyZSBzaG91bGQgZXZlciBiZSBzdWNoIGFuIGltcGxpY2F0aW9uLiBB ZmFpYyB0aGVyZQphcmUgcGF0Y2hlcyBJIGNvbW1lbnQgdXBvbiwgYnV0IHRoYXQgSSBlaXRoZXIg ZG9uJ3QgZmVlbCBxdWFsaWZpZWQKdG8gZ2l2ZSBhbiBhY2svUi1iIG9uLCBvciB0aGF0IEkgc2lt cGx5IGRvbid0IHdhbnQgdG8gZm9yIHdoYXRldmVyCnJlYXNvbi4gQXQgYmVzdCwgbm8gb3RoZXIg Y29tbWVudCAoYXMgaW4gdGhlIGFib3ZlIGV4YW1wbGUpIG1heSBiZQp0YWtlbiBhcyAiSSBkb24n dCBvYmplY3QiLgoKSmFuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpYZW4tYXBpIG1haWxpbmcgbGlzdApYZW4tYXBpQGxpc3RzLnhlbnByb2plY3Qub3Jn Cmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4tYXBpCg== From xen-api-bounces@lists.xenproject.org Thu Dec 19 10:03:24 2019 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 Dec 2019 10:03:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ihseQ-0006HE-Qn; Thu, 19 Dec 2019 10:03:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ihseO-0006Gt-Pd for xen-api@lists.xenproject.org; Thu, 19 Dec 2019 10:03:20 +0000 X-Inumbo-ID: c1e054dc-2246-11ea-a914-bc764e2007e4 Received: from mail-wm1-x342.google.com (unknown [2a00:1450:4864:20::342]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c1e054dc-2246-11ea-a914-bc764e2007e4; Thu, 19 Dec 2019 10:03:08 +0000 (UTC) Received: by mail-wm1-x342.google.com with SMTP id 20so4828732wmj.4; Thu, 19 Dec 2019 02:03:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:mime-version:subject:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=hlmutj29Mv+oNv5ld2Or2ujG/4pVcFrZodzfldMf1oQ=; b=FtAsu6AQ+X/QB7TD9tgObM1SEqgIw8QB5P+4fkAM/s4SuYfC0mIKmEAmZV+fsvNASA ykhN2rJ7DD2b5/89/f8GAgqZQTG9Z210ZwgOyq6KTt7nKY3CvgdqGlUq/AUARuk9VZAM C8U8qf7kKI8s2WPGLvxlzDOkA5FnhQITJri7OCxP1rRnuMxiGCrZHQ92nfUecaIFXayx 8mA2mCPX4dewu87DmiAv0F/XGRxOQJowo4fcLPVG9zvPP5txU8RiPfmeySs09gXAAHJh F/+uYrek+NJvcZqOeA8SHtaA/WhU8T7seE7zMHhf/tuN3oJ6u+qtH3r8hr4EcFPADv4k G56A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:subject:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=hlmutj29Mv+oNv5ld2Or2ujG/4pVcFrZodzfldMf1oQ=; b=TV635rsr/Omd+HCa/61WkFW4lTFYYb7Mk3SxDUSr9zQus9YRpG/0/c8bfeIq18eRV2 rm0qoxb499d9PDKLuubCydIMaE9BMiditI3W0yKGj4yT1kjPune+X6cgmM5RhYl2wGdZ j/Ef8taOy55KkyHvThARLiWIjiHBVV8nmZN5VTcupU3wtyedfq9Y4KYvP2PQ8eFVxW5z rITnmp4XhMCFAF33lwXfwD92FWiJq2V6HbZ9cf+GDGYedYCeJsydhY5dJyeGlwzwq3k0 bwDK+iqpsYgLii1wzMZ5q03+FAPB/jcubSMjUi678z03EwExVxeIP6GJvM+85BOeYAOh z+wQ== X-Gm-Message-State: APjAAAUQkKruSykzvB0HANUkZblN3rV7dVU8sRa855jeBueQRUI1Ulks h/S8sIx7WbEewEbEWusO5uwBEoDA X-Google-Smtp-Source: APXvYqx44/U9WE8B4+fooFTBnqb6tsRL7SH4SVAZmmrqswvjxSsAaTauIxlTjsgIHDZU18QU5SLs1Q== X-Received: by 2002:a05:600c:2207:: with SMTP id z7mr8693903wml.138.1576749787471; Thu, 19 Dec 2019 02:03:07 -0800 (PST) Received: from ?IPv6:2a01:4c8:1038:6f39:cd58:18e8:a347:8ea6? ([2a01:4c8:1038:6f39:cd58:18e8:a347:8ea6]) by smtp.gmail.com with ESMTPSA id u13sm5636149wmd.36.2019.12.19.02.03.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Dec 2019 02:03:06 -0800 (PST) From: Lars Kurth X-Google-Original-From: Lars Kurth Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) In-Reply-To: <1ed2d421-7dfe-1d92-5edc-7f11e8409ff7@suse.com> Date: Thu, 19 Dec 2019 10:03:04 +0000 Message-Id: <3A37215A-9402-4611-B5EE-1CA4D1218F87@xenproject.org> References: <98ab54c95a9541c918dfec529bcfc5867fd3ed33.1576184325.git.lars.kurth@citrix.com> <7a043307-f23f-c537-012b-393f59617c1c@xen.org> <0DE885E1-C4C3-447A-8408-88D43B9FE355@citrix.com> <1ed2d421-7dfe-1d92-5edc-7f11e8409ff7@suse.com> To: 'Jan Beulich' X-Mailer: Apple Mail (2.3445.104.11) Subject: Re: [Xen-API] [PATCH v3 5/7] Add Code Review Guide X-BeenThere: xen-api@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: User and development list for XCP and XAPI List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Lars Kurth , Julien Grall , "xen-api@lists.xenproject.org" , "minios-devel@lists.xenproject.org" , "committers@xenproject.org" , "mirageos-devel@lists.xenproject.org" , xen-devel , "win-pv-devel@lists.xenproject.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-api-bounces@lists.xenproject.org Sender: "Xen-api" Cgo+IE9uIDE5IERlYyAyMDE5LCBhdCAwOTo1NiwgSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2Uu Y29tPiB3cm90ZToKPiAKPiBPbiAxOC4xMi4yMDE5IDE4OjA5LCBMYXJzIEt1cnRoIHdyb3RlOgo+ PiAKPj4gCj4+IO+7v09uIDE4LzEyLzIwMTksIDE0OjI5LCAiSnVsaWVuIEdyYWxsIiA8anVsaWVu QHhlbi5vcmc+IHdyb3RlOgo+PiAKPj4gICAgSGkgTGFycywKPj4gCj4+ICAgIE9uIDEyLzEyLzIw MTkgMjE6MTQsIExhcnMgS3VydGggd3JvdGU6Cj4+PiArIyMjIFdvcmtmbG93IGZyb20gYW4gQXV0 aG9yJ3MgUGVyc3BlY3RpdmUKPj4+ICsKPj4+ICtXaGVuIGNvZGUgYXV0aG9ycyByZWNlaXZlIGZl ZWRiYWNrIG9uIHRoZWlyIHBhdGNoZXMsIHRoZXkgdHlwaWNhbGx5IGZpcnN0IHRyeQo+Pj4gK3Rv IGNsYXJpZnkgZmVlZGJhY2sgdGhleSBkbyBub3QgdW5kZXJzdGFuZC4gRm9yIHNtYWxsZXIgcGF0 Y2hlcyBvciBwYXRjaCBzZXJpZXMKPj4+ICtpdCBtYWtlcyBzZW5zZSB0byB3YWl0IHVudGlsIHJl Y2VpdmluZyBmZWVkYmFjayBvbiB0aGUgZW50aXJlIHNlcmllcyBiZWZvcmUKPj4+ICtzZW5kaW5n IG91dCBhIG5ldyB2ZXJzaW9uIGFkZHJlc3NpbmcgdGhlIGNoYW5nZXMuIEZvciBsYXJnZXIgc2Vy aWVzLCBpdCBtYXkKPj4+ICttYWtlIHNlbnNlIHRvIHNlbmQgb3V0IGEgbmV3IHJldmlzaW9uIGVh cmxpZXIuCj4+PiArCj4+PiArQXMgYSByZXZpZXdlciwgeW91IG5lZWQgc29tZSBzeXN0ZW0gdGhh dCBoZTtwcyBlbnN1cmUgdGhhdCB5b3UgYWRkcmVzcyBhbGwKPj4gCj4+ICAgIEp1c3QgYSBzbWFs bCB0eXBvOiBJIHRoaW5rIHlvdSBtZWFudCAiaGVscHMiIHJhdGhlciB0aGFuICJoZTtwcyIuCj4+ IAo+PiAgICBDaGVlcnMsCj4+IAo+PiBUaGFuayB5b3U6IGZpeGVkIGluIG15IHdvcmtpbmcgY29w eS4KPj4gCj4+IE9uZSB0aGluZyB3aGljaCBvY2N1cnJlZCB0byBtZSBmb3IgcmV2aWV3cyBsaWtl IHRoZXNlLCB3aGVyZSB0aGVyZSBpcyBubyBBQ0sncyBvciBSZXZpZXdlZC1ieSdzIGlzIHRoYXQg SSBkb24ndCBhY3R1YWxseSBrbm93IHdoZXRoZXIgeW91IGFzIHJldmlld2VyIGlzIG90aGVyd2lz ZSBoYXBweSB3aXRoIHRoZSByZW1haW5kZXIgb2YgdGhlIHBhdGNoLgo+PiBOb3JtYWxseSB0aGUg QUNLZWQtYnkgb3IgUmV2aWV3ZWQtYnkgaXMgYSBzaWduYWwgdGhhdCBpdCBpcwo+PiAKPj4gSSBh bSBhc3N1bWluZyBpdCBpcywgYnV0IEkgdGhpbmsgaXQgbWF5IGJlIHdvcnRod2hpbGUgcG9pbnRp bmcgdGhpcyBvdXQgaW4gdGhlIGRvY3VtZW50LCB0aGF0IHVubGVzcyBzdGF0ZWQgb3RoZXJ3aXNl LCB0aGUgcmV2aWV3ZXIgaXMgaGFwcHkgd2l0aCB0aGUgcGF0Y2gKPiAKPiBJIGRvbid0IHRoaW5r IHRoZXJlIHNob3VsZCBldmVyIGJlIHN1Y2ggYW4gaW1wbGljYXRpb24uIEFmYWljIHRoZXJlCj4g YXJlIHBhdGNoZXMgSSBjb21tZW50IHVwb24sIGJ1dCB0aGF0IEkgZWl0aGVyIGRvbid0IGZlZWwg cXVhbGlmaWVkCj4gdG8gZ2l2ZSBhbiBhY2svUi1iIG9uLCBvciB0aGF0IEkgc2ltcGx5IGRvbid0 IHdhbnQgdG8gZm9yIHdoYXRldmVyCj4gcmVhc29uLiBBdCBiZXN0LCBubyBvdGhlciBjb21tZW50 IChhcyBpbiB0aGUgYWJvdmUgZXhhbXBsZSkgbWF5IGJlCj4gdGFrZW4gYXMgIkkgZG9uJ3Qgb2Jq ZWN0Ii4KCgpJZiB0aGF0IGlzIHRoZSBjYXNlLCB3b3VsZCB0aGVyZSBiZSBhIHJlYXNvbmFibGUg Y29udmVudGlvbiB0byBtYWtlIHRoaXMgY2xlYXI/IAoKSW4gYSBudXRzaGVsbCwgaW4gc3VjaCBh IHJldmlldyB0aGUgcG9zc2libGUgaW50ZXJwcmV0YXRpb25zIGFyZQoqIEkgcmV2aWV3ZWQsIGJ1 dCBkaWRuJ3QgZmVlbCBxdWFsaWZpZWQgdG8gZG8gdGhlIHJlc3QKKiBJIHJldmlld2VkLCBidXQg ZGlkIG5vdCBnZXQgcm91bmQgdG8gZ2l2ZSBpdCBmdWxsIGF0dGVudGlvbgoqIEkgcmV2aWV3ZWQs IGJ1dCBiZWZvcmUgSSBtYWtlIGEgZmluYWwgZGVjaXNpb24gd2FudCB0byBsb29rIGF0IHRoZSBu ZXh0IHZlcnNpb24KLi4uCiogSSByZXZpZXdlZCBhbmQgZG9uJ3Qgb2JqZWN0IHRoZSByZXN0Ciog SSByZXZpZXdlZCBhbmQgYWdyZWVkIHdpdGggdGhlIHJlc3QgClRoZSBsYXR0ZXIgdHdvIGFyZSBl cXVpdmFsZW50IHRvIEFjay9SLWIKClRoYXQgaXMgcXVpdGUgYSBsYXJnZSByYW5nZSBvZiBwb3Nz aWJpbGl0aWVzIGFuZCBraW5kIG9mIGxlYXZlcyB0aGUgYXV0aG9yIGd1ZXNzaW5nIHdoYXQgc3Rh dGUgdGhlIHJldmlldyBpcyBpbgoKUmVnYXJkcwpMYXJzCgoKCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tYXBpIG1haWxpbmcgbGlzdApYZW4tYXBp QGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1h bi9saXN0aW5mby94ZW4tYXBpCg== From xen-api-bounces@lists.xenproject.org Thu Dec 19 11:09:46 2019 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 Dec 2019 11:09:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ihtga-0003w3-R1; Thu, 19 Dec 2019 11:09:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ihtgZ-0003vm-Ll for xen-api@lists.xenproject.org; Thu, 19 Dec 2019 11:09:39 +0000 X-Inumbo-ID: e5a761cc-224f-11ea-88e7-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e5a761cc-224f-11ea-88e7-bc764e2007e4; Thu, 19 Dec 2019 11:08:34 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 8B006B15F; Thu, 19 Dec 2019 11:08:33 +0000 (UTC) To: Lars Kurth References: <98ab54c95a9541c918dfec529bcfc5867fd3ed33.1576184325.git.lars.kurth@citrix.com> <7a043307-f23f-c537-012b-393f59617c1c@xen.org> <0DE885E1-C4C3-447A-8408-88D43B9FE355@citrix.com> <1ed2d421-7dfe-1d92-5edc-7f11e8409ff7@suse.com> <3A37215A-9402-4611-B5EE-1CA4D1218F87@xenproject.org> From: Jan Beulich Message-ID: <64e30946-8c36-3728-b894-441c0bf6c970@suse.com> Date: Thu, 19 Dec 2019 12:09:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <3A37215A-9402-4611-B5EE-1CA4D1218F87@xenproject.org> Content-Language: en-US Subject: Re: [Xen-API] [PATCH v3 5/7] Add Code Review Guide X-BeenThere: xen-api@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: User and development list for XCP and XAPI List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Lars Kurth , Julien Grall , "xen-api@lists.xenproject.org" , "minios-devel@lists.xenproject.org" , "committers@xenproject.org" , "mirageos-devel@lists.xenproject.org" , xen-devel , "win-pv-devel@lists.xenproject.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-api-bounces@lists.xenproject.org Sender: "Xen-api" T24gMTkuMTIuMjAxOSAxMTowMywgTGFycyBLdXJ0aCB3cm90ZToKPiAKPiAKPj4gT24gMTkgRGVj IDIwMTksIGF0IDA5OjU2LCBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+IHdyb3RlOgo+ Pgo+PiBPbiAxOC4xMi4yMDE5IDE4OjA5LCBMYXJzIEt1cnRoIHdyb3RlOgo+Pj4KPj4+Cj4+PiDv u79PbiAxOC8xMi8yMDE5LCAxNDoyOSwgIkp1bGllbiBHcmFsbCIgPGp1bGllbkB4ZW4ub3JnPiB3 cm90ZToKPj4+Cj4+PiAgICBIaSBMYXJzLAo+Pj4KPj4+ICAgIE9uIDEyLzEyLzIwMTkgMjE6MTQs IExhcnMgS3VydGggd3JvdGU6Cj4+Pj4gKyMjIyBXb3JrZmxvdyBmcm9tIGFuIEF1dGhvcidzIFBl cnNwZWN0aXZlCj4+Pj4gKwo+Pj4+ICtXaGVuIGNvZGUgYXV0aG9ycyByZWNlaXZlIGZlZWRiYWNr IG9uIHRoZWlyIHBhdGNoZXMsIHRoZXkgdHlwaWNhbGx5IGZpcnN0IHRyeQo+Pj4+ICt0byBjbGFy aWZ5IGZlZWRiYWNrIHRoZXkgZG8gbm90IHVuZGVyc3RhbmQuIEZvciBzbWFsbGVyIHBhdGNoZXMg b3IgcGF0Y2ggc2VyaWVzCj4+Pj4gK2l0IG1ha2VzIHNlbnNlIHRvIHdhaXQgdW50aWwgcmVjZWl2 aW5nIGZlZWRiYWNrIG9uIHRoZSBlbnRpcmUgc2VyaWVzIGJlZm9yZQo+Pj4+ICtzZW5kaW5nIG91 dCBhIG5ldyB2ZXJzaW9uIGFkZHJlc3NpbmcgdGhlIGNoYW5nZXMuIEZvciBsYXJnZXIgc2VyaWVz LCBpdCBtYXkKPj4+PiArbWFrZSBzZW5zZSB0byBzZW5kIG91dCBhIG5ldyByZXZpc2lvbiBlYXJs aWVyLgo+Pj4+ICsKPj4+PiArQXMgYSByZXZpZXdlciwgeW91IG5lZWQgc29tZSBzeXN0ZW0gdGhh dCBoZTtwcyBlbnN1cmUgdGhhdCB5b3UgYWRkcmVzcyBhbGwKPj4+Cj4+PiAgICBKdXN0IGEgc21h bGwgdHlwbzogSSB0aGluayB5b3UgbWVhbnQgImhlbHBzIiByYXRoZXIgdGhhbiAiaGU7cHMiLgo+ Pj4KPj4+ICAgIENoZWVycywKPj4+Cj4+PiBUaGFuayB5b3U6IGZpeGVkIGluIG15IHdvcmtpbmcg Y29weS4KPj4+Cj4+PiBPbmUgdGhpbmcgd2hpY2ggb2NjdXJyZWQgdG8gbWUgZm9yIHJldmlld3Mg bGlrZSB0aGVzZSwgd2hlcmUgdGhlcmUgaXMgbm8gQUNLJ3Mgb3IgUmV2aWV3ZWQtYnkncyBpcyB0 aGF0IEkgZG9uJ3QgYWN0dWFsbHkga25vdyB3aGV0aGVyIHlvdSBhcyByZXZpZXdlciBpcyBvdGhl cndpc2UgaGFwcHkgd2l0aCB0aGUgcmVtYWluZGVyIG9mIHRoZSBwYXRjaC4KPj4+IE5vcm1hbGx5 IHRoZSBBQ0tlZC1ieSBvciBSZXZpZXdlZC1ieSBpcyBhIHNpZ25hbCB0aGF0IGl0IGlzCj4+Pgo+ Pj4gSSBhbSBhc3N1bWluZyBpdCBpcywgYnV0IEkgdGhpbmsgaXQgbWF5IGJlIHdvcnRod2hpbGUg cG9pbnRpbmcgdGhpcyBvdXQgaW4gdGhlIGRvY3VtZW50LCB0aGF0IHVubGVzcyBzdGF0ZWQgb3Ro ZXJ3aXNlLCB0aGUgcmV2aWV3ZXIgaXMgaGFwcHkgd2l0aCB0aGUgcGF0Y2gKPj4KPj4gSSBkb24n dCB0aGluayB0aGVyZSBzaG91bGQgZXZlciBiZSBzdWNoIGFuIGltcGxpY2F0aW9uLiBBZmFpYyB0 aGVyZQo+PiBhcmUgcGF0Y2hlcyBJIGNvbW1lbnQgdXBvbiwgYnV0IHRoYXQgSSBlaXRoZXIgZG9u J3QgZmVlbCBxdWFsaWZpZWQKPj4gdG8gZ2l2ZSBhbiBhY2svUi1iIG9uLCBvciB0aGF0IEkgc2lt cGx5IGRvbid0IHdhbnQgdG8gZm9yIHdoYXRldmVyCj4+IHJlYXNvbi4gQXQgYmVzdCwgbm8gb3Ro ZXIgY29tbWVudCAoYXMgaW4gdGhlIGFib3ZlIGV4YW1wbGUpIG1heSBiZQo+PiB0YWtlbiBhcyAi SSBkb24ndCBvYmplY3QiLgo+IAo+IAo+IElmIHRoYXQgaXMgdGhlIGNhc2UsIHdvdWxkIHRoZXJl IGJlIGEgcmVhc29uYWJsZSBjb252ZW50aW9uIHRvIG1ha2UgdGhpcyBjbGVhcj8gCj4gCj4gSW4g YSBudXRzaGVsbCwgaW4gc3VjaCBhIHJldmlldyB0aGUgcG9zc2libGUgaW50ZXJwcmV0YXRpb25z IGFyZQo+ICogSSByZXZpZXdlZCwgYnV0IGRpZG4ndCBmZWVsIHF1YWxpZmllZCB0byBkbyB0aGUg cmVzdAo+ICogSSByZXZpZXdlZCwgYnV0IGRpZCBub3QgZ2V0IHJvdW5kIHRvIGdpdmUgaXQgZnVs bCBhdHRlbnRpb24KPiAqIEkgcmV2aWV3ZWQsIGJ1dCBiZWZvcmUgSSBtYWtlIGEgZmluYWwgZGVj aXNpb24gd2FudCB0byBsb29rIGF0IHRoZSBuZXh0IHZlcnNpb24KPiAuLi4KPiAqIEkgcmV2aWV3 ZWQgYW5kIGRvbid0IG9iamVjdCB0aGUgcmVzdAo+ICogSSByZXZpZXdlZCBhbmQgYWdyZWVkIHdp dGggdGhlIHJlc3QgCj4gVGhlIGxhdHRlciB0d28gYXJlIGVxdWl2YWxlbnQgdG8gQWNrL1ItYgo+ IAo+IFRoYXQgaXMgcXVpdGUgYSBsYXJnZSByYW5nZSBvZiBwb3NzaWJpbGl0aWVzIGFuZCBraW5k IG9mIGxlYXZlcyB0aGUgYXV0aG9yIGd1ZXNzaW5nIHdoYXQgc3RhdGUgdGhlIHJldmlldyBpcyBp bgoKV2VsbCwgSSB0aG91Z2ggdGhlIGNvbnZlbnRpb24gaXMgdG8gZ2l2ZSBBLWIgLyBSLWIgZXhw bGljaXRseS4gSW4KYSBmZXcgb3Zlcmx5IGFtYmlndW91cyBjYXNlcyB3ZSB0ZW5kIHRvIHNpbXBs eSBhc2sgYmFjayB3aGV0aGVyIGEKZ2l2ZW4gcmVwbHkgY2FuIGJlIHRyYW5zZm9ybWVkIGludG8g YSB0YWcuIEkgZG9uJ3Qgc2VlIGFueSBuZWVkCmZvciBmdXJ0aGVyIGZvcm1hbGl6YXRpb24gaGVy ZS4KCkphbgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K WGVuLWFwaSBtYWlsaW5nIGxpc3QKWGVuLWFwaUBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczov L2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWFwaQo=