From xen-devel-bounces@lists.xenproject.org Sat Aug 01 00:45:55 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Aug 2020 00:45:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k1feY-0000Gw-8l; Sat, 01 Aug 2020 00:45:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k1feX-0000GU-3j for xen-devel@lists.xenproject.org; Sat, 01 Aug 2020 00:45:33 +0000 X-Inumbo-ID: 4940b6d8-d390-11ea-8ec9-bc764e2007e4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4940b6d8-d390-11ea-8ec9-bc764e2007e4; Sat, 01 Aug 2020 00:45:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=eOrUMQ2Sf1amnXcotaFLdkSirBFoOnXwo4hKH297uWc=; b=tAWmc6y39wZhc60fDoLybmzZp TEpdmHCfztu0/CzhjmE7uAs30RcUVNt0meZ0Xx9kI2lSr+ygbeDXsREy4KisfVBrtD9S7mFHSXwSZ zeu9Y73IDICzpzegAJFm6dgeFZCMz9cEuH89xJ21NxJS8LAfwBmMfXRJMzpa6DFLcPRyk=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k1feN-0000kS-Pn; Sat, 01 Aug 2020 00:45:23 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k1feN-0005Hw-G9; Sat, 01 Aug 2020 00:45:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k1feN-0006bh-FH; Sat, 01 Aug 2020 00:45:23 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 152324: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-qemuu-nested-intel:xen-boot/l1:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-amd:xen-boot/l1:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:windows-install:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:windows-install:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:windows-install:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:windows-install:fail:regression qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=1448629751871c4924c234c2faaa968fc26890e1 X-Osstest-Versions-That: qemuu=9e3903136d9acde2fb2dd9e967ba928050a6cb4a From: osstest service owner Date: Sat, 01 Aug 2020 00:45:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152324 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/152324/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 14 xen-boot/l1 fail REGR. vs. 151065 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 10 debian-hvm-install fail REGR. vs. 151065 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 10 debian-hvm-install fail REGR. vs. 151065 test-amd64-amd64-qemuu-nested-amd 14 xen-boot/l1 fail REGR. vs. 151065 test-amd64-amd64-xl-qemuu-win7-amd64 10 windows-install fail REGR. vs. 151065 test-amd64-amd64-xl-qemuu-ws16-amd64 10 windows-install fail REGR. vs. 151065 test-amd64-i386-xl-qemuu-ws16-amd64 10 windows-install fail REGR. vs. 151065 test-amd64-i386-xl-qemuu-win7-amd64 10 windows-install fail REGR. vs. 151065 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 14 saverestore-support-check fail like 151065 test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail like 151065 test-amd64-i386-xl-pvshim 12 guest-start fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass version targeted for testing: qemuu 1448629751871c4924c234c2faaa968fc26890e1 baseline version: qemuu 9e3903136d9acde2fb2dd9e967ba928050a6cb4a Last test of basis 151065 2020-06-12 22:27:51 Z 49 days Failing since 151101 2020-06-14 08:32:51 Z 47 days 67 attempts Testing same since 152309 2020-07-30 21:40:33 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Aaron Lindsay Ahmed Karaman Alberto Garcia Aleksandar Markovic Aleksandar Markovic Alex Bennée Alex Richardson Alex Williamson Alexander Boettcher Alexander Bulekov Alexander Duyck Alexandre Mergnat Alexey Kardashevskiy Alexey Krasikov Alistair Francis Allan Peramaki Andreas Schwab Andrew Andrew Jones Andrew Melnychenko Andrey Shinkevich Ani Sinha Anthony PERARD Antoine Damhet Ard Biesheuvel Artyom Tarasenko Atish Patra Aurelien Jarno Babu Moger BALATON Zoltan Basil Salman Basil Salman Beata Michalska Bin Meng Bin Meng Bruce Rogers Cameron Esfahani Catherine A. Frederick Cathy Zhang Chen Gang Chenyi Qiang Christian Borntraeger Christian Ehrhardt Christophe de Dinechin Chuan Zheng Cindy Lu Claudio Fontana Cleber Rosa Colin Xu Corey Minyard Cornelia Huck Cédric Le Goater Daniel P. Berrange Daniel P. Berrangé Daniele Buono David Carlier David Edmondson David Gibson David Hildenbrand Denis V. Lunev Derek Su Dongjiu Geng Dr. David Alan Gilbert Ed Robbins Edgar E. Iglesias Eduardo Habkost Emilio G. Cota Eric Auger Eric Blake Eric Farman Erik Smit erik-smit Evgeny Yakovlev fangying Farhan Ali Filip Bozuta Finn Thain Frank Chang Geoffrey McRae Gerd Hoffmann Giuseppe Musacchio Greg Kurz Guenter Roeck Gustavo Romero Halil Pasic Havard Skinnemoen Helge Deller Hogan Wang Hogan Wang Howard Spoelstra Huacai Chen Huacai Chen Ian Jiang Igor Mammedov Jan Kiszka Jan Kiszka Janne Grunau Janosch Frank Jason Andryuk Jason Wang Jay Zhou Jean-Christophe Dubois Jessica Clarke Jiaxun Yang Jingqi Liu John Paul Adrian Glaubitz John Snow Jon Doron Joseph Myers Josh DuBois Josh DuBois Josh Kunz Juan Quintela Julio Faracco Keqian Zhu Kevin Wolf Klaus Jensen Klaus Jensen KONRAD Frederic Laszlo Ersek Laurent Vivier Laurent Vivier Leif Lindholm Leonid Bloch Leonid Bloch Li Feng Li Qiang Li Qiang Liao Pingfang lichun Lijun Pan Like Xu Lingfeng Yang Lingshan zhu Liran Alon Liu Yi L LIU Zhiwei Luc Michel Lukas Straub Luwei Kang Maciej S. Szmigiero Magnus Damm Mao Zhongyi Marc-André Lureau Marcelo Tosatti Marek Marczykowski-Górecki Mario Smarduch Mark Cave-Ayland Markus Armbruster Masahiro Yamada Matus Kysel Mauro Matteo Cascella Max Filippov Max Reitz Maxim Levitsky Maxime Coquelin Menno Lageman Michael Rolnik Michael Roth Michael S. Tsirkin Michael Tokarev Michal Privoznik Michele Denber Niek Linnenbank Nir Soffer Nir Soffer Olaf Hering Pan Nengyuan Paolo Bonzini Paul Durrant Paul Zimmerman Pavel Dovgalyuk Pavel Dovgalyuk Peter Maydell Peter Turschmid Peter Xu Philippe Mathieu-Daude Philippe Mathieu-Daudé Philippe Mathieu-Daudé Prasad J Pandit Radoslaw Biernacki Raphael Norwitz Reza Arbab Richard Henderson Richard W.M. Jones Riku Voipio Robert Foley Roman Bolshakov Roman Kagan Roman Kagan Sai Pavan Boddu Sarah Harris Sebastian Rasmussen Sergio Lopez Shameer Kolothum Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Weil Sven Schnelle Tao Xu Thomas Huth Thomas Huth Tiwei Bie Tong Ho Viktor Mihajlovski Vitaly Kuznetsov Vivek Goyal Vladimir Sementsov-Ogievskiy Volker Rümelin WangBowen Wei Huang Wei Wang Wentong Wu Xiaoyao Li Xie Yongji Yi Wang Ying Fang Yoshinori Sato Yuri Benditovich Zhang Chen Zheng Chuan Zong Li jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 34358 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Aug 01 05:53:12 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Aug 2020 05:53:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k1kRy-0001sr-2l; Sat, 01 Aug 2020 05:52:54 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k1kRx-0001s8-FE for xen-devel@lists.xenproject.org; Sat, 01 Aug 2020 05:52:53 +0000 X-Inumbo-ID: 3cba847c-d3bb-11ea-8ed9-bc764e2007e4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3cba847c-d3bb-11ea-8ed9-bc764e2007e4; Sat, 01 Aug 2020 05:52:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=X8zoxdh2O0JiBDWzseYObT+ngWa6395zHgld/a+2etI=; b=UGuHbqbF55Qd2UAym5l6MmZ9q xP4V9i36u7cgIP+LrhOUhrjTCUgw+3h988KRwb4yHCHH4DNWApAntAaqgTVJFYkczmXqoeEUkSGrn x1rLin3vGG5RJWzHwtr5MmJS8qFgb2BvyvRDgQq8ZUnYdpQjrVe479zTy0U2kHjB81guo=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k1kRu-0005e2-UE; Sat, 01 Aug 2020 05:52:50 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k1kRu-0002jY-HP; Sat, 01 Aug 2020 05:52:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k1kRu-0000gC-Gp; Sat, 01 Aug 2020 05:52:50 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 152329: all pass - PUSHED X-Osstest-Versions-This: ovmf=9001b750df64b25b14ec45a2efa1361a7b96c00a X-Osstest-Versions-That: ovmf=7f79b736b0a57da71d87c987357db0227cd16ac6 From: osstest service owner Date: Sat, 01 Aug 2020 05:52:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152329 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/152329/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 9001b750df64b25b14ec45a2efa1361a7b96c00a baseline version: ovmf 7f79b736b0a57da71d87c987357db0227cd16ac6 Last test of basis 152315 2020-07-31 03:12:00 Z 1 days Testing same since 152329 2020-07-31 15:40:08 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Laszlo Ersek Leif Lindholm Rebecca Cran jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 7f79b736b0..9001b750df 9001b750df64b25b14ec45a2efa1361a7b96c00a -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Aug 01 07:00:52 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Aug 2020 07:00:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k1lVR-0007nd-1Y; Sat, 01 Aug 2020 07:00:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k1lVP-0007nY-K0 for xen-devel@lists.xenproject.org; Sat, 01 Aug 2020 07:00:31 +0000 X-Inumbo-ID: af033d04-d3c4-11ea-8edc-bc764e2007e4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id af033d04-d3c4-11ea-8edc-bc764e2007e4; Sat, 01 Aug 2020 07:00:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=qmukv0Ipg1K7hJ94mKzsgIv24ERgw8gmcLqGxNLHJEs=; b=tD/htRYP/cHqxYkD02PNp6d5Y tkdekfs2d+4y6mzNLoW6ke+62whGLOSNd95RCn+IGfDFdsNfoNASHjXObeV1IdcFMLta9C/ZN5AeT Kf4TYSoP7ERFgOrmUUg5UO/CTaXJ4aQbtuoC8/eRPEoR8dKb2Wq3iZgUG3i71j6XmLGFc=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k1lVM-000755-Lg; Sat, 01 Aug 2020 07:00:28 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k1lVM-00061e-9j; Sat, 01 Aug 2020 07:00:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k1lVM-0000v7-90; Sat, 01 Aug 2020 07:00:28 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 152326: tolerable FAIL X-Osstest-Failures: xen-unstable:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking X-Osstest-Versions-This: xen=98bed5de1de3352c63cfe29a00f17e8d9ce72689 X-Osstest-Versions-That: xen=98bed5de1de3352c63cfe29a00f17e8d9ce72689 From: osstest service owner Date: Sat, 01 Aug 2020 07:00:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152326 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/152326/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-rtds 12 guest-start fail pass in 152311 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 16 guest-start/debianhvm.repeat fail pass in 152311 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 10 debian-hvm-install fail pass in 152311 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 13 migrate-support-check fail in 152311 never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail in 152311 never pass test-armhf-armhf-libvirt 14 saverestore-support-check fail like 152311 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail like 152311 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail like 152311 test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail like 152311 test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail like 152311 test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 152311 test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail like 152311 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail like 152311 test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail like 152311 test-amd64-i386-xl-pvshim 12 guest-start fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass version targeted for testing: xen 98bed5de1de3352c63cfe29a00f17e8d9ce72689 baseline version: xen 98bed5de1de3352c63cfe29a00f17e8d9ce72689 Last test of basis 152326 2020-07-31 12:08:56 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sat Aug 01 12:32:44 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Aug 2020 12:32:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k1qgX-00027I-5U; Sat, 01 Aug 2020 12:32:21 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k1qgW-00026s-GP for xen-devel@lists.xenproject.org; Sat, 01 Aug 2020 12:32:20 +0000 X-Inumbo-ID: 059571fe-d3f3-11ea-acfd-12813bfff9fa Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 059571fe-d3f3-11ea-acfd-12813bfff9fa; Sat, 01 Aug 2020 12:32:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=WoiWSMyNSC0Igg46wRMl3/bQIo8z11YixDxzjdVIoCo=; b=Nd2LWbJVdDlktjRoITv71TvsM 0XsGlUAz7IEHHVjdpymaryZL9TwSrBcJREHR6fSMWDYNWyMEMItpvGnpv35r9tDPLp+ve8xbU+3CS PfOejVVrMij6sg+2NNmANiGVF31mj7BUFAnGZ4PE9H6r3oEMp4MA5jt81hB+otmH58ROo=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k1qgM-0005um-E1; Sat, 01 Aug 2020 12:32:10 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k1qgM-0005TF-5X; Sat, 01 Aug 2020 12:32:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k1qgM-00085H-4w; Sat, 01 Aug 2020 12:32:10 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 152331: tolerable FAIL - PUSHED X-Osstest-Failures: linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking X-Osstest-Versions-This: linux=169b93899c7dfb93a2b57da8e3505da9b2afcf5c X-Osstest-Versions-That: linux=58a12e3368dbcadc57c6b3f5fcbecce757426f02 From: osstest service owner Date: Sat, 01 Aug 2020 12:32:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152331 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/152331/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-pvshim 12 guest-start fail never pass test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail never pass test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail never pass test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass version targeted for testing: linux 169b93899c7dfb93a2b57da8e3505da9b2afcf5c baseline version: linux 58a12e3368dbcadc57c6b3f5fcbecce757426f02 Last test of basis 152282 2020-07-29 08:44:57 Z 3 days Testing same since 152331 2020-07-31 17:11:00 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Cong Wang Dan Carpenter David Howells David S. Miller Eric Dumazet Florian Fainelli Greg Kroah-Hartman Kuniyuki Iwashima Mark Brown Miaohe Lin Neal Cardwell Peilin Ye Peng Fan Rafael J. Wysocki Subash Abhinov Kasiviswanathan Vladimir Oltean Wei Yongjun Weilong Chen Willem de Bruijn Xie He Xin Long Xiongfeng Wang Yuchung Cheng zhuguangqing jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 58a12e3368db..169b93899c7d 169b93899c7dfb93a2b57da8e3505da9b2afcf5c -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Sat Aug 01 20:41:49 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Aug 2020 20:41:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k1yK2-0002ED-RX; Sat, 01 Aug 2020 20:41:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k1yK0-0002Ds-OR for xen-devel@lists.xenproject.org; Sat, 01 Aug 2020 20:41:36 +0000 X-Inumbo-ID: 604088de-d437-11ea-8f8b-bc764e2007e4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 604088de-d437-11ea-8f8b-bc764e2007e4; Sat, 01 Aug 2020 20:41:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=qj76FEZNuaQkt3hxf02SbHEHYS8OWVvsHfshRxlkuLM=; b=CVYorCz7fwBVRhy8OS2it+559 cf2zI7N6x0ZRZuFFGv7oI9OPdQSp27myn/y8FcLXKg5wODxoZc2wKhqGDcRgMKaYaJZKsCC8RyoLU 0HHKocFyuOj445uyvuvIHBgQrsfirwEck0nxbL2HsuHGDDFVJwyo8S/AuauK2BOEmBWRw=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k1yJs-00086N-Mm; Sat, 01 Aug 2020 20:41:28 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k1yJs-0005LA-At; Sat, 01 Aug 2020 20:41:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k1yJs-0003jh-AD; Sat, 01 Aug 2020 20:41:28 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 152332: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking X-Osstest-Versions-This: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 X-Osstest-Versions-That: linux=6ba1b005ffc388c2aeaddae20da29e4810dea298 From: osstest service owner Date: Sat, 01 Aug 2020 20:41:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152332 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/152332/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail like 152287 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail like 152287 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail like 152287 test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 152287 test-armhf-armhf-xl-rtds 16 guest-start/debian.repeat fail like 152287 test-armhf-armhf-libvirt 14 saverestore-support-check fail like 152287 test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail like 152287 test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail like 152287 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail like 152287 test-amd64-i386-xl-pvshim 12 guest-start fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass version targeted for testing: linux deacdb3e3979979016fcd0ffd518c320a62ad166 baseline version: linux 6ba1b005ffc388c2aeaddae20da29e4810dea298 Last test of basis 152287 2020-07-29 17:11:28 Z 3 days Failing since 152303 2020-07-30 11:09:02 Z 2 days 3 attempts Testing same since 152332 2020-07-31 19:41:23 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alain Michaud Alex Deucher Alex Deucher Alexander Duyck Ard Biesheuvel Armas Spann Ben Skeggs Ben Skeggs Biju Das Bjorn Helgaas Catalin Marinas Christoph Hellwig Daniel Vetter Dave Airlie David Hildenbrand Dominique Martinet Douglas Anderson Grygorii Strashko Guido Günther Honggang Li Ingo Brunberg Jaedon Shin James Jones Jason Gunthorpe Jason Wang Jens Axboe Jitao Shi John Garry Kai-Heng Feng Kailang Yang Laurence Tratt Laurentiu Palcu Leon Romanovsky Linus Torvalds Linus Walleij Luis Machado Marc Zyngier Marcel Holtmann Mark Cave-Ayland Mazin Rezk Michael Ellerman Michael S. Tsirkin Mike Marciniszyn Nicholas Piggin Paul Cercueil Paul Moore Pavel Begunkov Peilin Ye PeiSen Hou Qiushi Wu Randy Dunlap # build-tested Ranjani Sridharan Robert Hancock Robin Murphy Robin Murphy Russell King Sagi Grimberg Sam Ravnborg Sami Tolvanen Sonny Sasaka Stephan Gerhold Steve Cohen Takashi Iwai Thomas Zimmermann Vinod Koul # tested on DragonBoard 410c Wang Hai Weilong Chen Will Deacon Willy Tarreau jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 6ba1b005ffc3..deacdb3e3979 deacdb3e3979979016fcd0ffd518c320a62ad166 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sat Aug 01 20:43:48 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Aug 2020 20:43:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k1yM8-0002MR-Ca; Sat, 01 Aug 2020 20:43:48 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k1yM7-0002MK-Fa for xen-devel@lists.xenproject.org; Sat, 01 Aug 2020 20:43:47 +0000 X-Inumbo-ID: b07f6040-d437-11ea-ad9c-12813bfff9fa Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b07f6040-d437-11ea-ad9c-12813bfff9fa; Sat, 01 Aug 2020 20:43:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=2/uxymeiUr/83bEDmWc1wweNFTTdGFj8uztlfTZjYMk=; b=OZo+tK0jFhNhQ5lYWGBFCJctJ pdfFC2SlyOtYbrZlDnc2s07xIGD8bhBvJQpFQKAk68J77XsaPWiIZGzX5j+equ0CALZvJlt8XYJpB M78p3WkJ4kWC1FKi7w+w5t7NrCB8U7jZBFkSENIsJ1kOAG++pfn+yTg8nNv7f4odGiAWE=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k1yM3-00088J-2N; Sat, 01 Aug 2020 20:43:43 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k1yM2-0005TG-Lh; Sat, 01 Aug 2020 20:43:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k1yM2-0004j9-Kw; Sat, 01 Aug 2020 20:43:42 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 152339: regressions - FAIL X-Osstest-Failures: libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=3c76ee42e7405b3426b4456828fe8dc39f33f005 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sat, 01 Aug 2020 20:43:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152339 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/152339/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a version targeted for testing: libvirt 3c76ee42e7405b3426b4456828fe8dc39f33f005 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 22 days Failing since 151818 2020-07-11 04:18:52 Z 21 days 22 attempts Testing same since 152339 2020-08-01 04:18:56 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrea Bolognani Balázs Meskó Bastien Orivel Bihong Yu Boris Fiuczynski Côme Borsoi Daniel Henrique Barboza Daniel P. Berrange Daniel P. Berrangé Fedora Weblate Translation Han Han Hao Wang Jean-Baptiste Holcroft Jianan Gao Jin Yan Jiri Denemark Ján Tomko Laine Stump Liao Pingfang Michal Privoznik Nikolay Shirokovskiy Paulo de Rezende Pinatti Pavel Hrdina Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Roman Bogorodskiy Ryan Schmidt Stefan Berger Szymon Scholz Weblate Yi Wang Yuri Chornoivan Zheng Chuan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 3174 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Aug 02 05:21:23 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2020 05:21:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k26Qg-0001Il-7k; Sun, 02 Aug 2020 05:21:02 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k26Qe-0001Ic-Jq for xen-devel@lists.xenproject.org; Sun, 02 Aug 2020 05:21:00 +0000 X-Inumbo-ID: f11e1914-d47f-11ea-ae16-12813bfff9fa Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f11e1914-d47f-11ea-ae16-12813bfff9fa; Sun, 02 Aug 2020 05:20:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=+Z6rrb/wGC0qrauQ2fTu1ZZ63FCM+BS5uMusxvRlwNA=; b=A5VGREFzHcaSug6Pq+fMwz4fH hvjF6EJO9u7FPsFdhDRRalSrcnp0Dquhzp+8qiEz37K/RHx3PqO0ZIHu8b6LIxPxUx952QOFr7QgP wk/+UjpQ7Bl4wVz5kWTngWD2KSA5PaZszl1leswYsdNyQOp1mownswv18/Ln3nJx20Z/c=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k26QZ-0000Qq-9n; Sun, 02 Aug 2020 05:20:55 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k26QV-00031O-GN; Sun, 02 Aug 2020 05:20:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k26QV-00008m-FL; Sun, 02 Aug 2020 05:20:51 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 152337: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-qemuu-nested-intel:xen-boot/l1:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-amd:xen-boot/l1:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:windows-install:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:windows-install:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:windows-install:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:windows-install:fail:regression qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=d74824cf7c8b352f9045e949dc636c7207a41eee X-Osstest-Versions-That: qemuu=9e3903136d9acde2fb2dd9e967ba928050a6cb4a From: osstest service owner Date: Sun, 02 Aug 2020 05:20:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152337 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/152337/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 14 xen-boot/l1 fail REGR. vs. 151065 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 10 debian-hvm-install fail REGR. vs. 151065 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 10 debian-hvm-install fail REGR. vs. 151065 test-amd64-amd64-qemuu-nested-amd 14 xen-boot/l1 fail REGR. vs. 151065 test-amd64-amd64-xl-qemuu-win7-amd64 10 windows-install fail REGR. vs. 151065 test-amd64-amd64-xl-qemuu-ws16-amd64 10 windows-install fail REGR. vs. 151065 test-amd64-i386-xl-qemuu-ws16-amd64 10 windows-install fail REGR. vs. 151065 test-amd64-i386-xl-qemuu-win7-amd64 10 windows-install fail REGR. vs. 151065 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 14 saverestore-support-check fail like 151065 test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail like 151065 test-amd64-i386-xl-pvshim 12 guest-start fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass version targeted for testing: qemuu d74824cf7c8b352f9045e949dc636c7207a41eee baseline version: qemuu 9e3903136d9acde2fb2dd9e967ba928050a6cb4a Last test of basis 151065 2020-06-12 22:27:51 Z 50 days Failing since 151101 2020-06-14 08:32:51 Z 48 days 68 attempts Testing same since 152337 2020-08-01 01:13:57 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Aaron Lindsay Ahmed Karaman Alberto Garcia Aleksandar Markovic Aleksandar Markovic Alex Bennée Alex Richardson Alex Williamson Alexander Boettcher Alexander Bulekov Alexander Duyck Alexandre Mergnat Alexey Kardashevskiy Alexey Krasikov Alistair Francis Allan Peramaki Andreas Schwab Andrew Andrew Jones Andrew Melnychenko Andrey Shinkevich Ani Sinha Anthony PERARD Antoine Damhet Ard Biesheuvel Artyom Tarasenko Atish Patra Aurelien Jarno Babu Moger BALATON Zoltan Basil Salman Basil Salman Beata Michalska Bin Meng Bin Meng Bruce Rogers Cameron Esfahani Catherine A. Frederick Cathy Zhang Chen Gang Chenyi Qiang Christian Borntraeger Christian Ehrhardt Christophe de Dinechin Chuan Zheng Cindy Lu Claudio Fontana Cleber Rosa Colin Xu Corey Minyard Cornelia Huck Cédric Le Goater Daniel P. Berrange Daniel P. Berrangé Daniele Buono David Carlier David Edmondson David Gibson David Hildenbrand Denis V. Lunev Derek Su Dongjiu Geng Dr. David Alan Gilbert Ed Robbins Edgar E. Iglesias Eduardo Habkost Emilio G. Cota Eric Auger Eric Blake Eric Farman Erik Smit erik-smit Evgeny Yakovlev fangying Farhan Ali Filip Bozuta Finn Thain Frank Chang Geoffrey McRae Gerd Hoffmann Giuseppe Musacchio Greg Kurz Guenter Roeck Gustavo Romero Halil Pasic Havard Skinnemoen Helge Deller Hogan Wang Hogan Wang Howard Spoelstra Huacai Chen Huacai Chen Ian Jiang Igor Mammedov Jan Kiszka Jan Kiszka Janne Grunau Janosch Frank Jason Andryuk Jason Wang Jay Zhou Jean-Christophe Dubois Jessica Clarke Jiaxun Yang Jingqi Liu John Paul Adrian Glaubitz John Snow Jon Doron Joseph Myers Josh DuBois Josh DuBois Josh Kunz Juan Quintela Julio Faracco Keqian Zhu Kevin Wolf Klaus Jensen Klaus Jensen KONRAD Frederic Laszlo Ersek Laurent Vivier Laurent Vivier Leif Lindholm Leonid Bloch Leonid Bloch Li Feng Li Qiang Li Qiang Liao Pingfang lichun Lijun Pan Like Xu Lingfeng Yang Lingshan zhu Liran Alon Liu Yi L LIU Zhiwei Luc Michel Lukas Straub Luwei Kang Maciej S. Szmigiero Magnus Damm Mao Zhongyi Marc-André Lureau Marcelo Tosatti Marek Marczykowski-Górecki Mario Smarduch Mark Cave-Ayland Markus Armbruster Masahiro Yamada Matus Kysel Mauro Matteo Cascella Max Filippov Max Reitz Maxim Levitsky Maxime Coquelin Menno Lageman Michael Rolnik Michael Roth Michael S. Tsirkin Michael Tokarev Michal Privoznik Michele Denber Niek Linnenbank Nir Soffer Nir Soffer Olaf Hering Pan Nengyuan Paolo Bonzini Paul Durrant Paul Zimmerman Pavel Dovgalyuk Pavel Dovgalyuk Peter Maydell Peter Turschmid Peter Xu Philippe Mathieu-Daude Philippe Mathieu-Daudé Philippe Mathieu-Daudé Prasad J Pandit Radoslaw Biernacki Raphael Norwitz Reza Arbab Richard Henderson Richard W.M. Jones Riku Voipio Robert Foley Roman Bolshakov Roman Kagan Roman Kagan Sai Pavan Boddu Sarah Harris Sebastian Rasmussen Sergio Lopez Shameer Kolothum Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Weil Sven Schnelle Tao Xu Thomas Huth Thomas Huth Tiwei Bie Tong Ho Viktor Mihajlovski Vitaly Kuznetsov Vivek Goyal Vladimir Sementsov-Ogievskiy Volker Rümelin WangBowen Wei Huang Wei Wang Wentong Wu Xiaoyao Li Xie Yongji Yi Wang Ying Fang Yoshinori Sato Yuri Benditovich Zhang Chen Zheng Chuan Zong Li jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 34403 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Aug 02 10:15:10 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2020 10:15:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2B0q-0001DF-Mb; Sun, 02 Aug 2020 10:14:40 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2B0p-0001CT-MW for xen-devel@lists.xenproject.org; Sun, 02 Aug 2020 10:14:39 +0000 X-Inumbo-ID: f6068000-d4a8-11ea-ae32-12813bfff9fa Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f6068000-d4a8-11ea-ae32-12813bfff9fa; Sun, 02 Aug 2020 10:14:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Gf6Us3KipevdDm86FSPRGY9Qo9E5mk4z1aCh7o1pgEU=; b=y577Xx5CbLpn81S9yCdFtO4ki Fvu7eydZn8uTIsdTerpQ1jesEgJiE94/++SAUAUaxnmgGH5qW4FcRjaUdZ0i2ZMrZ58c4puDooVX/ kxnySkjbkSxn2ejMSHz7Y4al9heVFD8DelcB9cyLztqwwvij6IJmQ1D9e/IgFKmmRe7lk=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2B0i-0007hq-VU; Sun, 02 Aug 2020 10:14:33 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k2B0i-0002Ir-Fp; Sun, 02 Aug 2020 10:14:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k2B0i-00080B-FF; Sun, 02 Aug 2020 10:14:32 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-coverity test] 152385: all pass - PUSHED X-Osstest-Versions-This: xen=81fd0d3ca4b2cd309403c6e8da662c325dd35750 X-Osstest-Versions-That: xen=b071ec25e85c4aacf3da59e5258cda0b1c4df45d From: osstest service owner Date: Sun, 02 Aug 2020 10:14:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152385 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/152385/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 81fd0d3ca4b2cd309403c6e8da662c325dd35750 baseline version: xen b071ec25e85c4aacf3da59e5258cda0b1c4df45d Last test of basis 152283 2020-07-29 09:19:04 Z 4 days Testing same since 152385 2020-08-02 09:18:50 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Fam Zheng Ian Jackson Jan Beulich Olaf Hering Paul Durrant Roger Pau Monne Roger Pau Monné Tim Deegan jobs: coverity-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git b071ec25e8..81fd0d3ca4 81fd0d3ca4b2cd309403c6e8da662c325dd35750 -> coverity-tested/smoke From xen-devel-bounces@lists.xenproject.org Sun Aug 02 10:43:49 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2020 10:43:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2BSu-0003nL-Vt; Sun, 02 Aug 2020 10:43:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2BSt-0003mN-OW for xen-devel@lists.xenproject.org; Sun, 02 Aug 2020 10:43:39 +0000 X-Inumbo-ID: 0264e40a-d4ad-11ea-8fe4-bc764e2007e4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0264e40a-d4ad-11ea-8fe4-bc764e2007e4; Sun, 02 Aug 2020 10:43:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=s1QXMebCxaytc8S4h+F91lwU//6b99NOCIIX6vAchVs=; b=37MTEMYR6ZhrvfX0QNnilYI63 NAskK3Y0tA6XKfd2ZEaBj7ZzlpuEvzEfBT5pwb9EJD9cB+Z0kKfFKiqxympgyQHPe3v4wFtPcFhtG 23Qjd5jiuaYVJDJpgLwVHJqsMwmkMbHoLo3sODmdNB6Y1AZ4uGj0sgnrxh9fCjMz8dX84=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2BSl-0008MC-7d; Sun, 02 Aug 2020 10:43:31 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k2BSk-0003Mq-RG; Sun, 02 Aug 2020 10:43:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k2BSk-0006yv-Qh; Sun, 02 Aug 2020 10:43:30 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 152342: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking X-Osstest-Versions-This: xen=81fd0d3ca4b2cd309403c6e8da662c325dd35750 X-Osstest-Versions-That: xen=98bed5de1de3352c63cfe29a00f17e8d9ce72689 From: osstest service owner Date: Sun, 02 Aug 2020 10:43:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152342 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/152342/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 14 saverestore-support-check fail like 152326 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail like 152326 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail like 152326 test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail like 152326 test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail like 152326 test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 152326 test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail like 152326 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail like 152326 test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail like 152326 test-amd64-i386-xl-pvshim 12 guest-start fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass version targeted for testing: xen 81fd0d3ca4b2cd309403c6e8da662c325dd35750 baseline version: xen 98bed5de1de3352c63cfe29a00f17e8d9ce72689 Last test of basis 152326 2020-07-31 12:08:56 Z 1 days Testing same since 152342 2020-08-01 07:08:38 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Ian Jackson Jan Beulich Olaf Hering Paul Durrant Tim Deegan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 98bed5de1d..81fd0d3ca4 81fd0d3ca4b2cd309403c6e8da662c325dd35750 -> master From xen-devel-bounces@lists.xenproject.org Sun Aug 02 12:02:41 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2020 12:02:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Ch7-0002Wr-1f; Sun, 02 Aug 2020 12:02:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Ch5-0002Wm-KX for xen-devel@lists.xenproject.org; Sun, 02 Aug 2020 12:02:23 +0000 X-Inumbo-ID: 059ee4bc-d4b8-11ea-8fe4-bc764e2007e4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 059ee4bc-d4b8-11ea-8fe4-bc764e2007e4; Sun, 02 Aug 2020 12:02:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=OoFMNMUi/SynnJ9Z8DNtdmthQrg43cpdK/fV30PMlQQ=; b=zYyly2afBWQDlGbaQk2ynq6h7 WJih3bKfbFickIkhR6OZKvrCcz5GAgdWvyk+vqDfofKzRmhctp6eM8pucegkcdaXxICcrOZ1Hg0qD Sft1RZUSxjEk+XDSv485PFfrjpVtSQv+yEWdRK4c148ekUW9uHEyr22xQ2XfPi0nwz0x0=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Ch4-0001kT-01; Sun, 02 Aug 2020 12:02:22 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k2Ch3-0007Vx-HG; Sun, 02 Aug 2020 12:02:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k2Ch3-0000Kv-GZ; Sun, 02 Aug 2020 12:02:21 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 152367: all pass - PUSHED X-Osstest-Versions-This: ovmf=e557442e3f7ec7bee2d886978bbd259c6d68c75a X-Osstest-Versions-That: ovmf=9001b750df64b25b14ec45a2efa1361a7b96c00a From: osstest service owner Date: Sun, 02 Aug 2020 12:02:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152367 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/152367/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf e557442e3f7ec7bee2d886978bbd259c6d68c75a baseline version: ovmf 9001b750df64b25b14ec45a2efa1361a7b96c00a Last test of basis 152329 2020-07-31 15:40:08 Z 1 days Testing same since 152367 2020-08-01 20:49:35 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Laszlo Ersek jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 9001b750df..e557442e3f e557442e3f7ec7bee2d886978bbd259c6d68c75a -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sun Aug 02 13:20:29 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2020 13:20:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2DuI-0000nl-TQ; Sun, 02 Aug 2020 13:20:06 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2DuI-0000ng-4E for xen-devel@lists.xenproject.org; Sun, 02 Aug 2020 13:20:06 +0000 X-Inumbo-ID: e061f3a0-d4c2-11ea-8fec-bc764e2007e4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e061f3a0-d4c2-11ea-8fec-bc764e2007e4; Sun, 02 Aug 2020 13:20:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=drCPeXa2qvLop9T36BRJsknOtMsyY1Lr1Rgx5XIcjOU=; b=NqLQjinTOmQka3EExVoIWwTzS sjtBAU/QeTya9welPDp60PEE/3dKDjyIrXlQ8iHLAjOoRBa4SxXUfXc2juojOwnJy+04kXAH5uyQd kpXDln8XCtz83PBsl1FSCsClaZSqtnTyGRih1ijhPBW5yaQvjh+ImG3dmWSMKYRUlVvXQ=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2DuF-0003Rr-JE; Sun, 02 Aug 2020 13:20:03 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k2DuF-0002iL-75; Sun, 02 Aug 2020 13:20:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k2DuF-0005Bi-6J; Sun, 02 Aug 2020 13:20:03 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 152377: regressions - FAIL X-Osstest-Failures: libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=3c76ee42e7405b3426b4456828fe8dc39f33f005 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sun, 02 Aug 2020 13:20:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152377 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/152377/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a version targeted for testing: libvirt 3c76ee42e7405b3426b4456828fe8dc39f33f005 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 23 days Failing since 151818 2020-07-11 04:18:52 Z 22 days 23 attempts Testing same since 152339 2020-08-01 04:18:56 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Andrea Bolognani Balázs Meskó Bastien Orivel Bihong Yu Boris Fiuczynski Côme Borsoi Daniel Henrique Barboza Daniel P. Berrange Daniel P. Berrangé Fedora Weblate Translation Han Han Hao Wang Jean-Baptiste Holcroft Jianan Gao Jin Yan Jiri Denemark Ján Tomko Laine Stump Liao Pingfang Michal Privoznik Nikolay Shirokovskiy Paulo de Rezende Pinatti Pavel Hrdina Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Roman Bogorodskiy Ryan Schmidt Stefan Berger Szymon Scholz Weblate Yi Wang Yuri Chornoivan Zheng Chuan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 3174 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Aug 02 18:16:45 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2020 18:16:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2IX3-0000VN-IJ; Sun, 02 Aug 2020 18:16:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2IX2-0000VI-Is for xen-devel@lists.xenproject.org; Sun, 02 Aug 2020 18:16:24 +0000 X-Inumbo-ID: 449939ae-d4ec-11ea-9025-bc764e2007e4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 449939ae-d4ec-11ea-9025-bc764e2007e4; Sun, 02 Aug 2020 18:16:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=OdVdrcY/FbzPfx1cTglKL1QIb+NPDm6gPvrmJkq/jV8=; b=qS6zRjigGHhsT9EAkYMmhLSZ/ 44uGCeRDnUh7NUE5djGyEUPV9aGB/hS7ua0QPH9aD6CT/yl0lBQ9oIrnvimjdNXpbrBt43wpSQO3f X5AHdKQUhhoWnJbABk4o9c3SlSh7ZGr9I5vdgg4EtJxWDhbgGSMzXXxfsu53KV3x/RarA=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2IWz-0002Kx-1F; Sun, 02 Aug 2020 18:16:21 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k2IWy-0000mr-G0; Sun, 02 Aug 2020 18:16:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k2IWy-0008Ju-Eq; Sun, 02 Aug 2020 18:16:20 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 152366: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-libvirt-xsm:guest-start/debian.repeat:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking X-Osstest-Versions-This: linux=d52daa8620c65960e1ef882adc1f92061326bd7a X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Sun, 02 Aug 2020 18:16:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152366 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/152366/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-libvirt-xsm 16 guest-start/debian.repeat fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail like 152332 test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 152332 test-armhf-armhf-libvirt 14 saverestore-support-check fail like 152332 test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail like 152332 test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail like 152332 test-amd64-i386-xl-pvshim 12 guest-start fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass version targeted for testing: linux d52daa8620c65960e1ef882adc1f92061326bd7a baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 1 days Testing same since 152366 2020-08-01 20:49:34 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Akash Asthana Douglas Anderson Linus Torvalds Linus Walleij Wolfram Sang Wolfram Sang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit d52daa8620c65960e1ef882adc1f92061326bd7a Merge: 7dc6fd0f3b84 c3c0c2e18d94 Author: Linus Torvalds Date: Sat Aug 1 10:11:42 2020 -0700 Merge tag 'pinctrl-v5.8-4' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl Pull pin control fix from Linus Walleij: "A single last minute pin control fix to the Qualcomm driver fixing missing dual edge PCH interrupts" * tag 'pinctrl-v5.8-4' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl: pinctrl: qcom: Handle broken/missing PDC dual edge IRQs on sc7180 commit 7dc6fd0f3b8404542718039f5de19fe56e474578 Merge: deacdb3e3979 8808981baf96 Author: Linus Torvalds Date: Fri Jul 31 12:50:54 2020 -0700 Merge branch 'i2c/for-current' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux Pull i2c fixes from Wolfram Sang: "Some I2C core improvements to prevent NULL pointer usage and a MAINTAINERS update" * 'i2c/for-current' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux: i2c: slave: add sanity check when unregistering i2c: slave: improve sanity check when registering MAINTAINERS: Update GENI I2C maintainers list i2c: also convert placeholder function to return errno commit 8808981baf96e1b3dea1f08461e4d958aa0dbde1 Author: Wolfram Sang Date: Sat Jul 25 21:50:53 2020 +0200 i2c: slave: add sanity check when unregistering Signed-off-by: Wolfram Sang Reviewed-by: Alain Volmat Signed-off-by: Wolfram Sang commit 1b1be3bf27b62f5abcf85c6f3214bdb9c7526685 Author: Wolfram Sang Date: Sat Jul 25 21:50:52 2020 +0200 i2c: slave: improve sanity check when registering Add check for ERR_PTR and simplify code while here. Signed-off-by: Wolfram Sang Reviewed-by: Alain Volmat Signed-off-by: Wolfram Sang commit d076947912696efc1e223b25799a025cd73d6a22 Author: Akash Asthana Date: Mon Jul 27 13:56:00 2020 +0530 MAINTAINERS: Update GENI I2C maintainers list Alok Chauhan has moved out of GENI team, he no longer supports GENI I2C driver, remove him from maintainer list. Add Akash Asthana & Mukesh Savaliya as maintainers for GENI I2C drivers. Signed-off-by: Akash Asthana Signed-off-by: Wolfram Sang commit 8be23aec0ee151de731626d5578973fde25b2285 Author: Wolfram Sang Date: Sat Jul 25 16:07:36 2020 +0200 i2c: also convert placeholder function to return errno All i2c_new_device-alike functions return ERR_PTR these days, but this fallback function was missed. Fixes: 2dea645ffc21 ("i2c: acpi: Return error pointers from i2c_acpi_new_device()") Signed-off-by: Wolfram Sang Reviewed-by: Andy Shevchenko [wsa: changed from 'ENOSYS' to 'ENODEV'] Signed-off-by: Wolfram Sang commit c3c0c2e18d943ec4a84162ac679970b592555a4a Author: Douglas Anderson Date: Tue Jul 14 08:04:17 2020 -0700 pinctrl: qcom: Handle broken/missing PDC dual edge IRQs on sc7180 Depending on how you look at it, you can either say that: a) There is a PDC hardware issue (with the specific IP rev that exists on sc7180) that causes the PDC not to work properly when configured to handle dual edges. b) The dual edge feature of the PDC hardware was only added in later HW revisions and thus isn't in all hardware. Regardless of how you look at it, let's work around the lack of dual edge support by only ever letting our parent see requests for single edge interrupts on affected hardware. NOTE: it's possible that a driver requesting a dual edge interrupt might get several edges coalesced into a single IRQ. For instance if a line starts low and then goes high and low again, the driver that requested the IRQ is not guaranteed to be called twice. However, it is guaranteed that once the driver's interrupt handler starts running its first instruction that any new edges coming in will cause the interrupt to fire again. This is relatively commonplace for dual-edge gpio interrupts (many gpio controllers require software to emulate dual edge with single edge) so client drivers should be setup to handle it. Fixes: e35a6ae0eb3a ("pinctrl/msm: Setup GPIO chip in hierarchy") Signed-off-by: Douglas Anderson Reviewed-by: Marc Zyngier Link: https://lore.kernel.org/r/20200714080254.v3.1.Ie0d730120b232a86a4eac1e2909bcbec844d1766@changeid Signed-off-by: Linus Walleij From xen-devel-bounces@lists.xenproject.org Mon Aug 03 05:09:26 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 05:09:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Sia-0002Er-AQ; Mon, 03 Aug 2020 05:09:00 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2SiY-0002Em-TB for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 05:08:58 +0000 X-Inumbo-ID: 6f2d98f8-d547-11ea-aef0-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6f2d98f8-d547-11ea-aef0-12813bfff9fa; Mon, 03 Aug 2020 05:08:57 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D054BAB8B; Mon, 3 Aug 2020 05:09:11 +0000 (UTC) Subject: Re: [PATCH 3/4] public/io/netif: specify MTU override node To: Paul Durrant , xen-devel@lists.xenproject.org References: <20200730194858.28523-1-paul@xen.org> <20200730194858.28523-4-paul@xen.org> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <9ef89ad4-c48e-ee42-cdcf-8118b2621c16@suse.com> Date: Mon, 3 Aug 2020 07:08:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200730194858.28523-4-paul@xen.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Paul Durrant Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 30.07.20 21:48, Paul Durrant wrote: > From: Paul Durrant > > There is currently no documentation to state what MTU a frontend should > adertise to its network stack. It has however long been assumed that the > default value of 1500 is correct. > > This patch specifies a mechanism to allow the tools to set the MTU via a > xenstore node in the frontend area and states that the absence of that node > means the frontend should assume an MTU of 1500 octets. > > NOTE: The Windows PV frontend has used an MTU sampled from the xenstore > node specified in this patch. > > Signed-off-by: Paul Durrant Can you please update docs/misc/xenstore-paths.pandoc accordingly? With that you can have my: Reviewed-by: Juergen Gross Juergen From xen-devel-bounces@lists.xenproject.org Mon Aug 03 05:44:50 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 05:44:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2TH4-0005YB-7M; Mon, 03 Aug 2020 05:44:38 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2TH2-0005Y6-W8 for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 05:44:37 +0000 X-Inumbo-ID: 69a95854-d54c-11ea-aef4-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 69a95854-d54c-11ea-aef4-12813bfff9fa; Mon, 03 Aug 2020 05:44:36 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2B2BAAC20; Mon, 3 Aug 2020 05:44:50 +0000 (UTC) Subject: Re: [PATCH v3 0/3] Few bug fixes and Convert to pin_user_pages*() To: Souptick Joarder , boris.ostrovsky@oracle.com, sstabellini@kernel.org References: <1594525195-28345-1-git-send-email-jrdr.linux@gmail.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Mon, 3 Aug 2020 07:44:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1594525195-28345-1-git-send-email-jrdr.linux@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Paul Durrant , John Hubbard Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 12.07.20 05:39, Souptick Joarder wrote: > This series contains few clean up, minor bug fixes and > Convert get_user_pages() to pin_user_pages(). > > I'm compile tested this, but unable to run-time test, > so any testing help is much appriciated. > > v2: > Addressed few review comments and compile issue. > Patch[1/2] from v1 split into 2 in v2. > v3: > Address review comment. Add review tag. > > Cc: John Hubbard > Cc: Boris Ostrovsky > Cc: Paul Durrant > > Souptick Joarder (3): > xen/privcmd: Corrected error handling path > xen/privcmd: Mark pages as dirty > xen/privcmd: Convert get_user_pages*() to pin_user_pages*() > > drivers/xen/privcmd.c | 32 ++++++++++++++------------------ > 1 file changed, 14 insertions(+), 18 deletions(-) > Series pushed to xen/tip.git for-linus-5.9 Juergen From xen-devel-bounces@lists.xenproject.org Mon Aug 03 05:49:26 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 05:49:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2TLh-0005j1-PI; Mon, 03 Aug 2020 05:49:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2TLg-0005iw-SL for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 05:49:24 +0000 X-Inumbo-ID: 1568bc0c-d54d-11ea-906f-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1568bc0c-d54d-11ea-906f-bc764e2007e4; Mon, 03 Aug 2020 05:49:24 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5E998B1CA; Mon, 3 Aug 2020 05:49:38 +0000 (UTC) Subject: Re: [PATCH] xen/gntdev: gntdev.h: drop a duplicated word To: Randy Dunlap , linux-kernel@vger.kernel.org References: <20200719003317.21454-1-rdunlap@infradead.org> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Mon, 3 Aug 2020 07:49:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200719003317.21454-1-rdunlap@infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Boris Ostrovsky Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 19.07.20 02:33, Randy Dunlap wrote: > Drop the repeated word "of" in a comment. > > Signed-off-by: Randy Dunlap > Cc: Boris Ostrovsky > Cc: Juergen Gross > Cc: xen-devel@lists.xenproject.org Pushed to xen/tip.git for-linus-5.9 Juergen From xen-devel-bounces@lists.xenproject.org Mon Aug 03 05:50:00 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 05:50:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2TMD-0005lM-1Y; Mon, 03 Aug 2020 05:49:57 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2TMB-0005lE-VS for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 05:49:56 +0000 X-Inumbo-ID: 2808d9c8-d54d-11ea-aef4-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2808d9c8-d54d-11ea-aef4-12813bfff9fa; Mon, 03 Aug 2020 05:49:55 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 917A9AC20; Mon, 3 Aug 2020 05:50:09 +0000 (UTC) Subject: Re: [PATCH] xen: hypercall.h: fix duplicated word To: Randy Dunlap , linux-kernel@vger.kernel.org References: <20200726001731.19540-1-rdunlap@infradead.org> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <2f324614-3fbd-2e66-9ac4-30ed26c07519@suse.com> Date: Mon, 3 Aug 2020 07:49:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200726001731.19540-1-rdunlap@infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Boris Ostrovsky Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 26.07.20 02:17, Randy Dunlap wrote: > Change the repeated word "as" to "as a". > > Signed-off-by: Randy Dunlap > Cc: Boris Ostrovsky > Cc: Juergen Gross > Cc: xen-devel@lists.xenproject.org Pushed to: xen/tip.git for-linus-5.9 Juergen From xen-devel-bounces@lists.xenproject.org Mon Aug 03 06:18:43 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 06:18:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Tnh-0008RO-92; Mon, 03 Aug 2020 06:18:21 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Tng-0008RJ-Ug for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 06:18:20 +0000 X-Inumbo-ID: 1ffda818-d551-11ea-aef8-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1ffda818-d551-11ea-aef8-12813bfff9fa; Mon, 03 Aug 2020 06:18:20 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 16439AF38; Mon, 3 Aug 2020 06:18:34 +0000 (UTC) Subject: Re: [PATCH v3 1/4] xen/balloon: fix accounting in alloc_xenballooned_pages error path To: Roger Pau Monne , linux-kernel@vger.kernel.org References: <20200727091342.52325-1-roger.pau@citrix.com> <20200727091342.52325-2-roger.pau@citrix.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <11ba709b-6b9f-ff87-708f-60dd5200dcde@suse.com> Date: Mon, 3 Aug 2020 08:18:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200727091342.52325-2-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Boris Ostrovsky , Stefano Stabellini , stable@vger.kernel.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 27.07.20 11:13, Roger Pau Monne wrote: > target_unpopulated is incremented with nr_pages at the start of the > function, but the call to free_xenballooned_pages will only subtract > pgno number of pages, and thus the rest need to be subtracted before > returning or else accounting will be skewed. > > Signed-off-by: Roger Pau Monné > Reviewed-by: Juergen Gross > Cc: stable@vger.kernel.org Pushed to xen/tip.git for-linus-5.9 Juergen From xen-devel-bounces@lists.xenproject.org Mon Aug 03 06:18:47 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 06:18:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2To7-0008SN-IB; Mon, 03 Aug 2020 06:18:47 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2To6-0008SE-DR for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 06:18:46 +0000 X-Inumbo-ID: 2f47bf20-d551-11ea-9075-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2f47bf20-d551-11ea-9075-bc764e2007e4; Mon, 03 Aug 2020 06:18:45 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C0078AF38; Mon, 3 Aug 2020 06:18:59 +0000 (UTC) Subject: Re: [PATCH v3 2/4] xen/balloon: make the balloon wait interruptible To: Roger Pau Monne , linux-kernel@vger.kernel.org References: <20200727091342.52325-1-roger.pau@citrix.com> <20200727091342.52325-3-roger.pau@citrix.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <65a4575a-d3ed-3aca-3f30-60eab3792346@suse.com> Date: Mon, 3 Aug 2020 08:18:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200727091342.52325-3-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Boris Ostrovsky , Stefano Stabellini , stable@vger.kernel.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 27.07.20 11:13, Roger Pau Monne wrote: > So it can be killed, or else processes can get hung indefinitely > waiting for balloon pages. > > Signed-off-by: Roger Pau Monné > Reviewed-by: Juergen Gross > Cc: stable@vger.kernel.org Pushed to: xen/tip.git for-linus-5.9 Juergen From xen-devel-bounces@lists.xenproject.org Mon Aug 03 06:19:17 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 06:19:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Tob-0008WV-RF; Mon, 03 Aug 2020 06:19:17 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Toa-0008WJ-Hj for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 06:19:16 +0000 X-Inumbo-ID: 41768c26-d551-11ea-aef8-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 41768c26-d551-11ea-aef8-12813bfff9fa; Mon, 03 Aug 2020 06:19:16 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4A084AF38; Mon, 3 Aug 2020 06:19:30 +0000 (UTC) Subject: Re: [PATCH v3 3/4] Revert "xen/balloon: Fix crash when ballooning on x86 32 bit PAE" To: Roger Pau Monne , linux-kernel@vger.kernel.org References: <20200727091342.52325-1-roger.pau@citrix.com> <20200727091342.52325-4-roger.pau@citrix.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Mon, 3 Aug 2020 08:19:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200727091342.52325-4-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Boris Ostrovsky , Stefano Stabellini Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 27.07.20 11:13, Roger Pau Monne wrote: > This reverts commit dfd74a1edfaba5864276a2859190a8d242d18952. > > This has been fixed by commit dca4436d1cf9e0d237c which added the out > of bounds check to __add_memory, so that trying to add blocks past > MAX_PHYSMEM_BITS will fail. > > Note the check in the Xen balloon driver was bogus anyway, as it > checked the start address of the resource, but it should instead test > the end address to assert the whole resource falls below > MAX_PHYSMEM_BITS. > > Signed-off-by: Roger Pau Monné > Reviewed-by: Juergen Gross Pushed to: xen/tip.git for-linus-5.9 Juergen From xen-devel-bounces@lists.xenproject.org Mon Aug 03 06:24:51 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 06:24:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Ttv-00012j-HA; Mon, 03 Aug 2020 06:24:47 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Ttu-00012M-1K for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 06:24:46 +0000 X-Inumbo-ID: 01893680-d552-11ea-9075-bc764e2007e4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 01893680-d552-11ea-9075-bc764e2007e4; Mon, 03 Aug 2020 06:24:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=hGst5q/pl6ik6rLdpBndCFqaqSvd0sQMAHIt91PMd24=; b=4AjoaX9e6Uwb9Kgi2GdixEj8R ofkHIiTPkkUxruGWby9J72v4oTOBYhsl/ZaHnQUfplY/MBFyvZ1LiCiH5XQVBzfBfscHm0ZKO6Xvp WtEBy7a/g3iGFsYEvu4UDJ6s/XMvcCQgnzmqqvH3CnRrT1uGsmLx9G3v3/0lkCNlVzKkk=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Ttl-0000O4-At; Mon, 03 Aug 2020 06:24:37 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k2Ttk-0007Vf-UB; Mon, 03 Aug 2020 06:24:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k2Ttk-0005EE-T2; Mon, 03 Aug 2020 06:24:36 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 152380: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-qemuu-nested-intel:xen-boot/l1:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-amd:xen-boot/l1:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:windows-install:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:windows-install:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:windows-install:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:windows-install:fail:regression qemu-mainline:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=d74824cf7c8b352f9045e949dc636c7207a41eee X-Osstest-Versions-That: qemuu=9e3903136d9acde2fb2dd9e967ba928050a6cb4a From: osstest service owner Date: Mon, 03 Aug 2020 06:24:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152380 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/152380/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 14 xen-boot/l1 fail REGR. vs. 151065 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 10 debian-hvm-install fail REGR. vs. 151065 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 10 debian-hvm-install fail REGR. vs. 151065 test-amd64-amd64-qemuu-nested-amd 14 xen-boot/l1 fail REGR. vs. 151065 test-amd64-amd64-xl-qemuu-win7-amd64 10 windows-install fail REGR. vs. 151065 test-amd64-amd64-xl-qemuu-ws16-amd64 10 windows-install fail REGR. vs. 151065 test-amd64-i386-xl-qemuu-ws16-amd64 10 windows-install fail REGR. vs. 151065 test-amd64-i386-xl-qemuu-win7-amd64 10 windows-install fail REGR. vs. 151065 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-rtds 18 guest-localmigrate/x10 fail pass in 152337 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 14 saverestore-support-check fail like 151065 test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail like 151065 test-amd64-i386-xl-pvshim 12 guest-start fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass version targeted for testing: qemuu d74824cf7c8b352f9045e949dc636c7207a41eee baseline version: qemuu 9e3903136d9acde2fb2dd9e967ba928050a6cb4a Last test of basis 151065 2020-06-12 22:27:51 Z 51 days Failing since 151101 2020-06-14 08:32:51 Z 49 days 69 attempts Testing same since 152337 2020-08-01 01:13:57 Z 2 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Aaron Lindsay Ahmed Karaman Alberto Garcia Aleksandar Markovic Aleksandar Markovic Alex Bennée Alex Richardson Alex Williamson Alexander Boettcher Alexander Bulekov Alexander Duyck Alexandre Mergnat Alexey Kardashevskiy Alexey Krasikov Alistair Francis Allan Peramaki Andreas Schwab Andrew Andrew Jones Andrew Melnychenko Andrey Shinkevich Ani Sinha Anthony PERARD Antoine Damhet Ard Biesheuvel Artyom Tarasenko Atish Patra Aurelien Jarno Babu Moger BALATON Zoltan Basil Salman Basil Salman Beata Michalska Bin Meng Bin Meng Bruce Rogers Cameron Esfahani Catherine A. Frederick Cathy Zhang Chen Gang Chenyi Qiang Christian Borntraeger Christian Ehrhardt Christophe de Dinechin Chuan Zheng Cindy Lu Claudio Fontana Cleber Rosa Colin Xu Corey Minyard Cornelia Huck Cédric Le Goater Daniel P. Berrange Daniel P. Berrangé Daniele Buono David Carlier David Edmondson David Gibson David Hildenbrand Denis V. Lunev Derek Su Dongjiu Geng Dr. David Alan Gilbert Ed Robbins Edgar E. Iglesias Eduardo Habkost Emilio G. Cota Eric Auger Eric Blake Eric Farman Erik Smit erik-smit Evgeny Yakovlev fangying Farhan Ali Filip Bozuta Finn Thain Frank Chang Geoffrey McRae Gerd Hoffmann Giuseppe Musacchio Greg Kurz Guenter Roeck Gustavo Romero Halil Pasic Havard Skinnemoen Helge Deller Hogan Wang Hogan Wang Howard Spoelstra Huacai Chen Huacai Chen Ian Jiang Igor Mammedov Jan Kiszka Jan Kiszka Janne Grunau Janosch Frank Jason Andryuk Jason Wang Jay Zhou Jean-Christophe Dubois Jessica Clarke Jiaxun Yang Jingqi Liu John Paul Adrian Glaubitz John Snow Jon Doron Joseph Myers Josh DuBois Josh DuBois Josh Kunz Juan Quintela Julio Faracco Keqian Zhu Kevin Wolf Klaus Jensen Klaus Jensen KONRAD Frederic Laszlo Ersek Laurent Vivier Laurent Vivier Leif Lindholm Leonid Bloch Leonid Bloch Li Feng Li Qiang Li Qiang Liao Pingfang lichun Lijun Pan Like Xu Lingfeng Yang Lingshan zhu Liran Alon Liu Yi L LIU Zhiwei Luc Michel Lukas Straub Luwei Kang Maciej S. Szmigiero Magnus Damm Mao Zhongyi Marc-André Lureau Marcelo Tosatti Marek Marczykowski-Górecki Mario Smarduch Mark Cave-Ayland Markus Armbruster Masahiro Yamada Matus Kysel Mauro Matteo Cascella Max Filippov Max Reitz Maxim Levitsky Maxime Coquelin Menno Lageman Michael Rolnik Michael Roth Michael S. Tsirkin Michael Tokarev Michal Privoznik Michele Denber Niek Linnenbank Nir Soffer Nir Soffer Olaf Hering Pan Nengyuan Paolo Bonzini Paul Durrant Paul Zimmerman Pavel Dovgalyuk Pavel Dovgalyuk Peter Maydell Peter Turschmid Peter Xu Philippe Mathieu-Daude Philippe Mathieu-Daudé Philippe Mathieu-Daudé Prasad J Pandit Radoslaw Biernacki Raphael Norwitz Reza Arbab Richard Henderson Richard W.M. Jones Riku Voipio Robert Foley Roman Bolshakov Roman Kagan Roman Kagan Sai Pavan Boddu Sarah Harris Sebastian Rasmussen Sergio Lopez Shameer Kolothum Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Weil Sven Schnelle Tao Xu Thomas Huth Thomas Huth Tiwei Bie Tong Ho Viktor Mihajlovski Vitaly Kuznetsov Vivek Goyal Vladimir Sementsov-Ogievskiy Volker Rümelin WangBowen Wei Huang Wei Wang Wentong Wu Xiaoyao Li Xie Yongji Yi Wang Ying Fang Yoshinori Sato Yuri Benditovich Zhang Chen Zheng Chuan Zong Li jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 34403 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Aug 03 08:06:51 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 08:06:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2VUS-00022x-Uy; Mon, 03 Aug 2020 08:06:36 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2VUR-00022s-O4 for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 08:06:35 +0000 X-Inumbo-ID: 3f0b2488-d560-11ea-af03-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3f0b2488-d560-11ea-af03-12813bfff9fa; Mon, 03 Aug 2020 08:06:34 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id ADDD0ABA2; Mon, 3 Aug 2020 08:06:48 +0000 (UTC) To: "xen-devel@lists.xenproject.org" From: Jan Beulich Subject: [PATCH] libxl: avoid golang building without CONFIG_GOLANG=y Message-ID: Date: Mon, 3 Aug 2020 10:06:32 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony Perard , Ian Jackson , George Dunlap , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" While this doesn't address the real problem I've run into (attempting to update r/o source files), not recursing into tools/golang/xenlight/ is enough to fix the build for me for the moment. I don't currently see why 60db5da62ac0 ("libxl: Generate golang bindings in libxl Makefile") found it necessary to invoke this build step unconditionally. Signed-off-by: Jan Beulich --- I'm also having trouble to see why, besides the idl-gen target in tools/golang/xenlight/Makefile, the commit also adds such a target to (and mentions it in [only] a comment in) tools/libxl/Makefile. --- a/tools/libxl/Makefile +++ b/tools/libxl/Makefile @@ -282,7 +282,9 @@ _libxl_type%.h _libxl_type%_json.h _libx # about races with tools/golang/xenlight/Makefile:all .PHONY: idl-external idl-external: +ifeq ($(CONFIG_GOLANG),y) $(MAKE) -C $(XEN_ROOT)/tools/golang/xenlight idl-gen +endif LIBXL_IDLGEN_FILES = _libxl_types.h _libxl_types_json.h _libxl_types_private.h _libxl_types.c \ _libxl_types_internal.h _libxl_types_internal_json.h _libxl_types_internal_private.h _libxl_types_internal.c From xen-devel-bounces@lists.xenproject.org Mon Aug 03 08:14:23 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 08:14:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Vbu-0002wE-OS; Mon, 03 Aug 2020 08:14:18 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Vbs-0002w9-RH for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 08:14:17 +0000 X-Inumbo-ID: 527c212e-d561-11ea-907c-bc764e2007e4 Received: from smtp-fw-6002.amazon.com (unknown [52.95.49.90]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 527c212e-d561-11ea-907c-bc764e2007e4; Mon, 03 Aug 2020 08:14:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.co.uk; i=@amazon.co.uk; q=dns/txt; s=amazon201209; t=1596442457; x=1627978457; h=from:to:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version:subject; bh=Rj3T9psIG4tq+0rH6xOV3Fol7V8ankyfiZvQrhdJ1wc=; b=tH6Yets2MV3AR8lemjO9L02TgODVsftfIdXCO+1BylYEi+U0JudG3KKi JFHLedldVUis7eJRLevNjjEsaHoz/3ZMqEmP6L1OJKzp8dfHGi6Z14jb+ gXtq5uwrh+s/F8WK/6NHrHfBDNhhS/YcMQtqgJx44AjDXw2sMp9LMecDN Y=; IronPort-SDR: Z6v44PorqimR+rHyqlmiktqyAKBKak0guLvXpQyvv5CfxNZMJY0L7JVjn72Cj5FDrprnyJZsYk +0+6IrMCCpHw== X-IronPort-AV: E=Sophos;i="5.75,429,1589241600"; d="scan'208";a="45583303" Subject: RE: [PATCH 3/4] public/io/netif: specify MTU override node Thread-Topic: [PATCH 3/4] public/io/netif: specify MTU override node Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-1a-7d76a15f.us-east-1.amazon.com) ([10.43.8.6]) by smtp-border-fw-out-6002.iad6.amazon.com with ESMTP; 03 Aug 2020 08:14:16 +0000 Received: from EX13MTAUEA002.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan3.iad.amazon.com [10.40.159.166]) by email-inbound-relay-1a-7d76a15f.us-east-1.amazon.com (Postfix) with ESMTPS id 62392A0439; Mon, 3 Aug 2020 08:14:15 +0000 (UTC) Received: from EX13D32EUC002.ant.amazon.com (10.43.164.94) by EX13MTAUEA002.ant.amazon.com (10.43.61.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 3 Aug 2020 08:14:14 +0000 Received: from EX13D32EUC003.ant.amazon.com (10.43.164.24) by EX13D32EUC002.ant.amazon.com (10.43.164.94) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 3 Aug 2020 08:14:14 +0000 Received: from EX13D32EUC003.ant.amazon.com ([10.43.164.24]) by EX13D32EUC003.ant.amazon.com ([10.43.164.24]) with mapi id 15.00.1497.006; Mon, 3 Aug 2020 08:14:13 +0000 From: "Durrant, Paul" To: =?utf-8?B?SsO8cmdlbiBHcm/Dnw==?= , Paul Durrant , "xen-devel@lists.xenproject.org" Thread-Index: AQHWaVQ8mFueWE86Tk2qq4H/3yFmCqkmCQzg Date: Mon, 3 Aug 2020 08:14:13 +0000 Message-ID: References: <20200730194858.28523-1-paul@xen.org> <20200730194858.28523-4-paul@xen.org> <9ef89ad4-c48e-ee42-cdcf-8118b2621c16@suse.com> In-Reply-To: <9ef89ad4-c48e-ee42-cdcf-8118b2621c16@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.165.145] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 Precedence: Bulk X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBKw7xyZ2VuIEdyb8OfIDxqZ3Jv c3NAc3VzZS5jb20+DQo+IFNlbnQ6IDAzIEF1Z3VzdCAyMDIwIDA2OjA5DQo+IFRvOiBQYXVsIER1 cnJhbnQgPHBhdWxAeGVuLm9yZz47IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KPiBD YzogRHVycmFudCwgUGF1bCA8cGR1cnJhbnRAYW1hem9uLmNvLnVrPg0KPiBTdWJqZWN0OiBSRTog W0VYVEVSTkFMXSBbUEFUQ0ggMy80XSBwdWJsaWMvaW8vbmV0aWY6IHNwZWNpZnkgTVRVIG92ZXJy aWRlIG5vZGUNCj4gDQo+IE9uIDMwLjA3LjIwIDIxOjQ4LCBQYXVsIER1cnJhbnQgd3JvdGU6DQo+ ID4gRnJvbTogUGF1bCBEdXJyYW50IDxwZHVycmFudEBhbWF6b24uY29tPg0KPiA+DQo+ID4gVGhl cmUgaXMgY3VycmVudGx5IG5vIGRvY3VtZW50YXRpb24gdG8gc3RhdGUgd2hhdCBNVFUgYSBmcm9u dGVuZCBzaG91bGQNCj4gPiBhZGVydGlzZSB0byBpdHMgbmV0d29yayBzdGFjay4gSXQgaGFzIGhv d2V2ZXIgbG9uZyBiZWVuIGFzc3VtZWQgdGhhdCB0aGUNCj4gPiBkZWZhdWx0IHZhbHVlIG9mIDE1 MDAgaXMgY29ycmVjdC4NCj4gPg0KPiA+IFRoaXMgcGF0Y2ggc3BlY2lmaWVzIGEgbWVjaGFuaXNt IHRvIGFsbG93IHRoZSB0b29scyB0byBzZXQgdGhlIE1UVSB2aWEgYQ0KPiA+IHhlbnN0b3JlIG5v ZGUgaW4gdGhlIGZyb250ZW5kIGFyZWEgYW5kIHN0YXRlcyB0aGF0IHRoZSBhYnNlbmNlIG9mIHRo YXQgbm9kZQ0KPiA+IG1lYW5zIHRoZSBmcm9udGVuZCBzaG91bGQgYXNzdW1lIGFuIE1UVSBvZiAx NTAwIG9jdGV0cy4NCj4gPg0KPiA+IE5PVEU6IFRoZSBXaW5kb3dzIFBWIGZyb250ZW5kIGhhcyB1 c2VkIGFuIE1UVSBzYW1wbGVkIGZyb20gdGhlIHhlbnN0b3JlDQo+ID4gICAgICAgIG5vZGUgc3Bl Y2lmaWVkIGluIHRoaXMgcGF0Y2guDQo+ID4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBQYXVsIER1cnJh bnQgPHBkdXJyYW50QGFtYXpvbi5jb20+DQo+IA0KPiBDYW4geW91IHBsZWFzZSB1cGRhdGUgZG9j cy9taXNjL3hlbnN0b3JlLXBhdGhzLnBhbmRvYyBhY2NvcmRpbmdseT8NCg0KU3VyZS4gR2l2ZW4g dGhlIHBhdGggaXMgZm9yIHVzZSBieSB0b29scyB0aGVuIGl0IHNob3VsZCBpbmRlZWQgYmUgZG9j dW1lbnRlZCB0aGVyZSBhcyB3ZWxsLg0KDQo+IFdpdGggdGhhdCB5b3UgY2FuIGhhdmUgbXk6DQo+ IA0KPiBSZXZpZXdlZC1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPiANCg0K VGhhbmtzLA0KDQogIFBhdWwNCg0KPiANCj4gSnVlcmdlbg0K From xen-devel-bounces@lists.xenproject.org Mon Aug 03 11:08:34 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 11:08:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2YKK-0000dw-0K; Mon, 03 Aug 2020 11:08:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2YKI-0000cs-Ua for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 11:08:18 +0000 X-Inumbo-ID: 9ea4888a-d579-11ea-9085-bc764e2007e4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9ea4888a-d579-11ea-9085-bc764e2007e4; Mon, 03 Aug 2020 11:08:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Rhs1Psz6ogAA8zMfyTBFkF2g2lyQ1FAM2xrAXUxCC/0=; b=yZ938jNCEteCU9Npe/X7RzImg I4UG/sMrou7yjbRbpbI+hfk+aQsZND9uyQ5ohut+fR/NAjA8P5e+T0t9qfYTJKq/TNi64Wx+E36w3 suFsfPNmWmA14TrUPQnzlBF9GmsRa0lR1MHQgDwAwd2iW3zUlm1YObFuYqv2ka2kl/ctM=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2YKB-00079H-Bm; Mon, 03 Aug 2020 11:08:11 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k2YKA-000686-To; Mon, 03 Aug 2020 11:08:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k2YKA-0004fe-T4; Mon, 03 Aug 2020 11:08:10 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 152389: tolerable FAIL X-Osstest-Failures: xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking X-Osstest-Versions-This: xen=81fd0d3ca4b2cd309403c6e8da662c325dd35750 X-Osstest-Versions-That: xen=81fd0d3ca4b2cd309403c6e8da662c325dd35750 From: osstest service owner Date: Mon, 03 Aug 2020 11:08:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152389 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/152389/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-rtds 16 guest-start/debian.repeat fail pass in 152342 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 10 debian-hvm-install fail pass in 152342 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail like 152342 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail like 152342 test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail like 152342 test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail like 152342 test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 152342 test-armhf-armhf-libvirt 14 saverestore-support-check fail like 152342 test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail like 152342 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail like 152342 test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail like 152342 test-amd64-i386-xl-pvshim 12 guest-start fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass version targeted for testing: xen 81fd0d3ca4b2cd309403c6e8da662c325dd35750 baseline version: xen 81fd0d3ca4b2cd309403c6e8da662c325dd35750 Last test of basis 152389 2020-08-02 10:56:02 Z 1 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon Aug 03 12:29:36 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 12:29:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zar-0007OK-0I; Mon, 03 Aug 2020 12:29:29 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zaq-0007NV-0p for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 12:29:28 +0000 X-Inumbo-ID: f5855de0-d584-11ea-af26-12813bfff9fa Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f5855de0-d584-11ea-af26-12813bfff9fa; Mon, 03 Aug 2020 12:29:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gp6KEn5GkdD039Rg54pQRN4h4pTnAudvyLFE5D9IDcA=; b=q0ZeG5rXc1cTe6YOJ6RpE7Q9+p YKTIe5GlwNZyVXie+vRQ1/Twik7JBjY766K1ngLqVdOP7IySRMCDk0JjHt4zRppRQpyL7bCltvP4W loKrRirEwKHW7CTIobxOCSyq41Ae2M+4n4MzpeD1tg1UKQwRhcNcNqbApbldQ6cs7zkM=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zah-0000SI-Dv; Mon, 03 Aug 2020 12:29:19 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2Zah-0000zk-5d; Mon, 03 Aug 2020 12:29:19 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v3 01/11] x86/iommu: re-arrange arch_iommu to separate common fields... Date: Mon, 3 Aug 2020 13:29:04 +0100 Message-Id: <20200803122914.2259-2-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200803122914.2259-1-paul@xen.org> References: <20200803122914.2259-1-paul@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Tian , Wei Liu , Andrew Cooper , Paul Durrant , Lukasz Hawrylko , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant ... from those specific to VT-d or AMD IOMMU, and put the latter in a union. There is no functional change in this patch, although the initialization of the 'mapped_rmrrs' list occurs slightly later in iommu_domain_init() since it is now done (correctly) in VT-d specific code rather than in general x86 code. NOTE: I have not combined the AMD IOMMU 'root_table' and VT-d 'pgd_maddr' fields even though they perform essentially the same function. The concept of 'root table' in the VT-d code is different from that in the AMD code so attempting to use a common name will probably only serve to confuse the reader. Signed-off-by: Paul Durrant --- Cc: Lukasz Hawrylko Cc: Jan Beulich Cc: Andrew Cooper Cc: Wei Liu Cc: "Roger Pau Monné" Cc: Kevin Tian v2: - s/amd_iommu/amd - Definitions still left inline as re-arrangement into implementation headers is non-trivial - Also s/u64/uint64_t and s/int/unsigned int --- xen/arch/x86/tboot.c | 4 +- xen/drivers/passthrough/amd/iommu_guest.c | 8 ++-- xen/drivers/passthrough/amd/iommu_map.c | 14 +++--- xen/drivers/passthrough/amd/pci_amd_iommu.c | 35 +++++++------- xen/drivers/passthrough/vtd/iommu.c | 53 +++++++++++---------- xen/drivers/passthrough/x86/iommu.c | 1 - xen/include/asm-x86/iommu.h | 27 +++++++---- 7 files changed, 78 insertions(+), 64 deletions(-) diff --git a/xen/arch/x86/tboot.c b/xen/arch/x86/tboot.c index 320e06f129..e66b0940c4 100644 --- a/xen/arch/x86/tboot.c +++ b/xen/arch/x86/tboot.c @@ -230,8 +230,8 @@ static void tboot_gen_domain_integrity(const uint8_t key[TB_KEY_SIZE], { const struct domain_iommu *dio = dom_iommu(d); - update_iommu_mac(&ctx, dio->arch.pgd_maddr, - agaw_to_level(dio->arch.agaw)); + update_iommu_mac(&ctx, dio->arch.vtd.pgd_maddr, + agaw_to_level(dio->arch.vtd.agaw)); } } diff --git a/xen/drivers/passthrough/amd/iommu_guest.c b/xen/drivers/passthrough/amd/iommu_guest.c index 014a72a54b..30b7353cd6 100644 --- a/xen/drivers/passthrough/amd/iommu_guest.c +++ b/xen/drivers/passthrough/amd/iommu_guest.c @@ -50,12 +50,12 @@ static uint16_t guest_bdf(struct domain *d, uint16_t machine_bdf) static inline struct guest_iommu *domain_iommu(struct domain *d) { - return dom_iommu(d)->arch.g_iommu; + return dom_iommu(d)->arch.amd.g_iommu; } static inline struct guest_iommu *vcpu_iommu(struct vcpu *v) { - return dom_iommu(v->domain)->arch.g_iommu; + return dom_iommu(v->domain)->arch.amd.g_iommu; } static void guest_iommu_enable(struct guest_iommu *iommu) @@ -823,7 +823,7 @@ int guest_iommu_init(struct domain* d) guest_iommu_reg_init(iommu); iommu->mmio_base = ~0ULL; iommu->domain = d; - hd->arch.g_iommu = iommu; + hd->arch.amd.g_iommu = iommu; tasklet_init(&iommu->cmd_buffer_tasklet, guest_iommu_process_command, d); @@ -845,5 +845,5 @@ void guest_iommu_destroy(struct domain *d) tasklet_kill(&iommu->cmd_buffer_tasklet); xfree(iommu); - dom_iommu(d)->arch.g_iommu = NULL; + dom_iommu(d)->arch.amd.g_iommu = NULL; } diff --git a/xen/drivers/passthrough/amd/iommu_map.c b/xen/drivers/passthrough/amd/iommu_map.c index 93e96cd69c..47b4472e8a 100644 --- a/xen/drivers/passthrough/amd/iommu_map.c +++ b/xen/drivers/passthrough/amd/iommu_map.c @@ -180,8 +180,8 @@ static int iommu_pde_from_dfn(struct domain *d, unsigned long dfn, struct page_info *table; const struct domain_iommu *hd = dom_iommu(d); - table = hd->arch.root_table; - level = hd->arch.paging_mode; + table = hd->arch.amd.root_table; + level = hd->arch.amd.paging_mode; BUG_ON( table == NULL || level < 1 || level > 6 ); @@ -325,7 +325,7 @@ int amd_iommu_unmap_page(struct domain *d, dfn_t dfn, spin_lock(&hd->arch.mapping_lock); - if ( !hd->arch.root_table ) + if ( !hd->arch.amd.root_table ) { spin_unlock(&hd->arch.mapping_lock); return 0; @@ -450,7 +450,7 @@ int __init amd_iommu_quarantine_init(struct domain *d) unsigned int level = amd_iommu_get_paging_mode(end_gfn); struct amd_iommu_pte *table; - if ( hd->arch.root_table ) + if ( hd->arch.amd.root_table ) { ASSERT_UNREACHABLE(); return 0; @@ -458,11 +458,11 @@ int __init amd_iommu_quarantine_init(struct domain *d) spin_lock(&hd->arch.mapping_lock); - hd->arch.root_table = alloc_amd_iommu_pgtable(); - if ( !hd->arch.root_table ) + hd->arch.amd.root_table = alloc_amd_iommu_pgtable(); + if ( !hd->arch.amd.root_table ) goto out; - table = __map_domain_page(hd->arch.root_table); + table = __map_domain_page(hd->arch.amd.root_table); while ( level ) { struct page_info *pg; diff --git a/xen/drivers/passthrough/amd/pci_amd_iommu.c b/xen/drivers/passthrough/amd/pci_amd_iommu.c index 5f5f4a2eac..c27bfbd48e 100644 --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c @@ -91,7 +91,8 @@ static void amd_iommu_setup_domain_device( u8 bus = pdev->bus; const struct domain_iommu *hd = dom_iommu(domain); - BUG_ON( !hd->arch.root_table || !hd->arch.paging_mode || + BUG_ON( !hd->arch.amd.root_table || + !hd->arch.amd.paging_mode || !iommu->dev_table.buffer ); if ( iommu_hwdom_passthrough && is_hardware_domain(domain) ) @@ -110,8 +111,8 @@ static void amd_iommu_setup_domain_device( /* bind DTE to domain page-tables */ amd_iommu_set_root_page_table( - dte, page_to_maddr(hd->arch.root_table), domain->domain_id, - hd->arch.paging_mode, valid); + dte, page_to_maddr(hd->arch.amd.root_table), + domain->domain_id, hd->arch.amd.paging_mode, valid); /* Undo what amd_iommu_disable_domain_device() may have done. */ ivrs_dev = &get_ivrs_mappings(iommu->seg)[req_id]; @@ -131,8 +132,8 @@ static void amd_iommu_setup_domain_device( "root table = %#"PRIx64", " "domain = %d, paging mode = %d\n", req_id, pdev->type, - page_to_maddr(hd->arch.root_table), - domain->domain_id, hd->arch.paging_mode); + page_to_maddr(hd->arch.amd.root_table), + domain->domain_id, hd->arch.amd.paging_mode); } spin_unlock_irqrestore(&iommu->lock, flags); @@ -206,10 +207,10 @@ static int iov_enable_xt(void) int amd_iommu_alloc_root(struct domain_iommu *hd) { - if ( unlikely(!hd->arch.root_table) ) + if ( unlikely(!hd->arch.amd.root_table) ) { - hd->arch.root_table = alloc_amd_iommu_pgtable(); - if ( !hd->arch.root_table ) + hd->arch.amd.root_table = alloc_amd_iommu_pgtable(); + if ( !hd->arch.amd.root_table ) return -ENOMEM; } @@ -239,7 +240,7 @@ static int amd_iommu_domain_init(struct domain *d) * physical address space we give it, but this isn't known yet so use 4 * unilaterally. */ - hd->arch.paging_mode = amd_iommu_get_paging_mode( + hd->arch.amd.paging_mode = amd_iommu_get_paging_mode( is_hvm_domain(d) ? 1ul << (DEFAULT_DOMAIN_ADDRESS_WIDTH - PAGE_SHIFT) : get_upper_mfn_bound() + 1); @@ -305,7 +306,7 @@ static void amd_iommu_disable_domain_device(const struct domain *domain, AMD_IOMMU_DEBUG("Disable: device id = %#x, " "domain = %d, paging mode = %d\n", req_id, domain->domain_id, - dom_iommu(domain)->arch.paging_mode); + dom_iommu(domain)->arch.amd.paging_mode); } spin_unlock_irqrestore(&iommu->lock, flags); @@ -420,10 +421,11 @@ static void deallocate_iommu_page_tables(struct domain *d) struct domain_iommu *hd = dom_iommu(d); spin_lock(&hd->arch.mapping_lock); - if ( hd->arch.root_table ) + if ( hd->arch.amd.root_table ) { - deallocate_next_page_table(hd->arch.root_table, hd->arch.paging_mode); - hd->arch.root_table = NULL; + deallocate_next_page_table(hd->arch.amd.root_table, + hd->arch.amd.paging_mode); + hd->arch.amd.root_table = NULL; } spin_unlock(&hd->arch.mapping_lock); } @@ -598,11 +600,12 @@ static void amd_dump_p2m_table(struct domain *d) { const struct domain_iommu *hd = dom_iommu(d); - if ( !hd->arch.root_table ) + if ( !hd->arch.amd.root_table ) return; - printk("p2m table has %d levels\n", hd->arch.paging_mode); - amd_dump_p2m_table_level(hd->arch.root_table, hd->arch.paging_mode, 0, 0); + printk("p2m table has %d levels\n", hd->arch.amd.paging_mode); + amd_dump_p2m_table_level(hd->arch.amd.root_table, + hd->arch.amd.paging_mode, 0, 0); } static const struct iommu_ops __initconstrel _iommu_ops = { diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c index deaeab095d..94e0455a4d 100644 --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -257,20 +257,20 @@ static u64 bus_to_context_maddr(struct vtd_iommu *iommu, u8 bus) static u64 addr_to_dma_page_maddr(struct domain *domain, u64 addr, int alloc) { struct domain_iommu *hd = dom_iommu(domain); - int addr_width = agaw_to_width(hd->arch.agaw); + int addr_width = agaw_to_width(hd->arch.vtd.agaw); struct dma_pte *parent, *pte = NULL; - int level = agaw_to_level(hd->arch.agaw); + int level = agaw_to_level(hd->arch.vtd.agaw); int offset; u64 pte_maddr = 0; addr &= (((u64)1) << addr_width) - 1; ASSERT(spin_is_locked(&hd->arch.mapping_lock)); - if ( !hd->arch.pgd_maddr && + if ( !hd->arch.vtd.pgd_maddr && (!alloc || - ((hd->arch.pgd_maddr = alloc_pgtable_maddr(1, hd->node)) == 0)) ) + ((hd->arch.vtd.pgd_maddr = alloc_pgtable_maddr(1, hd->node)) == 0)) ) goto out; - parent = (struct dma_pte *)map_vtd_domain_page(hd->arch.pgd_maddr); + parent = (struct dma_pte *)map_vtd_domain_page(hd->arch.vtd.pgd_maddr); while ( level > 1 ) { offset = address_level_offset(addr, level); @@ -593,7 +593,7 @@ static int __must_check iommu_flush_iotlb(struct domain *d, dfn_t dfn, { iommu = drhd->iommu; - if ( !test_bit(iommu->index, &hd->arch.iommu_bitmap) ) + if ( !test_bit(iommu->index, &hd->arch.vtd.iommu_bitmap) ) continue; flush_dev_iotlb = !!find_ats_dev_drhd(iommu); @@ -1278,7 +1278,10 @@ void __init iommu_free(struct acpi_drhd_unit *drhd) static int intel_iommu_domain_init(struct domain *d) { - dom_iommu(d)->arch.agaw = width_to_agaw(DEFAULT_DOMAIN_ADDRESS_WIDTH); + struct domain_iommu *hd = dom_iommu(d); + + hd->arch.vtd.agaw = width_to_agaw(DEFAULT_DOMAIN_ADDRESS_WIDTH); + INIT_LIST_HEAD(&hd->arch.vtd.mapped_rmrrs); return 0; } @@ -1375,10 +1378,10 @@ int domain_context_mapping_one( spin_lock(&hd->arch.mapping_lock); /* Ensure we have pagetables allocated down to leaf PTE. */ - if ( hd->arch.pgd_maddr == 0 ) + if ( hd->arch.vtd.pgd_maddr == 0 ) { addr_to_dma_page_maddr(domain, 0, 1); - if ( hd->arch.pgd_maddr == 0 ) + if ( hd->arch.vtd.pgd_maddr == 0 ) { nomem: spin_unlock(&hd->arch.mapping_lock); @@ -1389,7 +1392,7 @@ int domain_context_mapping_one( } /* Skip top levels of page tables for 2- and 3-level DRHDs. */ - pgd_maddr = hd->arch.pgd_maddr; + pgd_maddr = hd->arch.vtd.pgd_maddr; for ( agaw = level_to_agaw(4); agaw != level_to_agaw(iommu->nr_pt_levels); agaw-- ) @@ -1443,7 +1446,7 @@ int domain_context_mapping_one( if ( rc > 0 ) rc = 0; - set_bit(iommu->index, &hd->arch.iommu_bitmap); + set_bit(iommu->index, &hd->arch.vtd.iommu_bitmap); unmap_vtd_domain_page(context_entries); @@ -1714,7 +1717,7 @@ static int domain_context_unmap(struct domain *domain, u8 devfn, { int iommu_domid; - clear_bit(iommu->index, &dom_iommu(domain)->arch.iommu_bitmap); + clear_bit(iommu->index, &dom_iommu(domain)->arch.vtd.iommu_bitmap); iommu_domid = domain_iommu_domid(domain, iommu); if ( iommu_domid == -1 ) @@ -1739,7 +1742,7 @@ static void iommu_domain_teardown(struct domain *d) if ( list_empty(&acpi_drhd_units) ) return; - list_for_each_entry_safe ( mrmrr, tmp, &hd->arch.mapped_rmrrs, list ) + list_for_each_entry_safe ( mrmrr, tmp, &hd->arch.vtd.mapped_rmrrs, list ) { list_del(&mrmrr->list); xfree(mrmrr); @@ -1751,8 +1754,9 @@ static void iommu_domain_teardown(struct domain *d) return; spin_lock(&hd->arch.mapping_lock); - iommu_free_pagetable(hd->arch.pgd_maddr, agaw_to_level(hd->arch.agaw)); - hd->arch.pgd_maddr = 0; + iommu_free_pagetable(hd->arch.vtd.pgd_maddr, + agaw_to_level(hd->arch.vtd.agaw)); + hd->arch.vtd.pgd_maddr = 0; spin_unlock(&hd->arch.mapping_lock); } @@ -1892,7 +1896,7 @@ static void iommu_set_pgd(struct domain *d) mfn_t pgd_mfn; pgd_mfn = pagetable_get_mfn(p2m_get_pagetable(p2m_get_hostp2m(d))); - dom_iommu(d)->arch.pgd_maddr = + dom_iommu(d)->arch.vtd.pgd_maddr = pagetable_get_paddr(pagetable_from_mfn(pgd_mfn)); } @@ -1912,7 +1916,7 @@ static int rmrr_identity_mapping(struct domain *d, bool_t map, * No need to acquire hd->arch.mapping_lock: Both insertion and removal * get done while holding pcidevs_lock. */ - list_for_each_entry( mrmrr, &hd->arch.mapped_rmrrs, list ) + list_for_each_entry( mrmrr, &hd->arch.vtd.mapped_rmrrs, list ) { if ( mrmrr->base == rmrr->base_address && mrmrr->end == rmrr->end_address ) @@ -1959,7 +1963,7 @@ static int rmrr_identity_mapping(struct domain *d, bool_t map, mrmrr->base = rmrr->base_address; mrmrr->end = rmrr->end_address; mrmrr->count = 1; - list_add_tail(&mrmrr->list, &hd->arch.mapped_rmrrs); + list_add_tail(&mrmrr->list, &hd->arch.vtd.mapped_rmrrs); return 0; } @@ -2657,8 +2661,9 @@ static void vtd_dump_p2m_table(struct domain *d) return; hd = dom_iommu(d); - printk("p2m table has %d levels\n", agaw_to_level(hd->arch.agaw)); - vtd_dump_p2m_table_level(hd->arch.pgd_maddr, agaw_to_level(hd->arch.agaw), 0, 0); + printk("p2m table has %d levels\n", agaw_to_level(hd->arch.vtd.agaw)); + vtd_dump_p2m_table_level(hd->arch.vtd.pgd_maddr, + agaw_to_level(hd->arch.vtd.agaw), 0, 0); } static int __init intel_iommu_quarantine_init(struct domain *d) @@ -2669,7 +2674,7 @@ static int __init intel_iommu_quarantine_init(struct domain *d) unsigned int level = agaw_to_level(agaw); int rc; - if ( hd->arch.pgd_maddr ) + if ( hd->arch.vtd.pgd_maddr ) { ASSERT_UNREACHABLE(); return 0; @@ -2677,11 +2682,11 @@ static int __init intel_iommu_quarantine_init(struct domain *d) spin_lock(&hd->arch.mapping_lock); - hd->arch.pgd_maddr = alloc_pgtable_maddr(1, hd->node); - if ( !hd->arch.pgd_maddr ) + hd->arch.vtd.pgd_maddr = alloc_pgtable_maddr(1, hd->node); + if ( !hd->arch.vtd.pgd_maddr ) goto out; - parent = map_vtd_domain_page(hd->arch.pgd_maddr); + parent = map_vtd_domain_page(hd->arch.vtd.pgd_maddr); while ( level ) { uint64_t maddr; diff --git a/xen/drivers/passthrough/x86/iommu.c b/xen/drivers/passthrough/x86/iommu.c index 3d7670e8c6..a12109a1de 100644 --- a/xen/drivers/passthrough/x86/iommu.c +++ b/xen/drivers/passthrough/x86/iommu.c @@ -139,7 +139,6 @@ int arch_iommu_domain_init(struct domain *d) struct domain_iommu *hd = dom_iommu(d); spin_lock_init(&hd->arch.mapping_lock); - INIT_LIST_HEAD(&hd->arch.mapped_rmrrs); return 0; } diff --git a/xen/include/asm-x86/iommu.h b/xen/include/asm-x86/iommu.h index 6c9d5e5632..8ce97c981f 100644 --- a/xen/include/asm-x86/iommu.h +++ b/xen/include/asm-x86/iommu.h @@ -45,16 +45,23 @@ typedef uint64_t daddr_t; struct arch_iommu { - u64 pgd_maddr; /* io page directory machine address */ - spinlock_t mapping_lock; /* io page table lock */ - int agaw; /* adjusted guest address width, 0 is level 2 30-bit */ - u64 iommu_bitmap; /* bitmap of iommu(s) that the domain uses */ - struct list_head mapped_rmrrs; - - /* amd iommu support */ - int paging_mode; - struct page_info *root_table; - struct guest_iommu *g_iommu; + spinlock_t mapping_lock; /* io page table lock */ + + union { + /* Intel VT-d */ + struct { + uint64_t pgd_maddr; /* io page directory machine address */ + unsigned int agaw; /* adjusted guest address width, 0 is level 2 30-bit */ + uint64_t iommu_bitmap; /* bitmap of iommu(s) that the domain uses */ + struct list_head mapped_rmrrs; + } vtd; + /* AMD IOMMU */ + struct { + unsigned int paging_mode; + struct page_info *root_table; + struct guest_iommu *g_iommu; + } amd; + }; }; extern struct iommu_ops iommu_ops; -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 12:29:36 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 12:29:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zap-0007O3-NR; Mon, 03 Aug 2020 12:29:27 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zao-0007NQ-Vs for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 12:29:27 +0000 X-Inumbo-ID: f5e5f740-d584-11ea-908e-bc764e2007e4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f5e5f740-d584-11ea-908e-bc764e2007e4; Mon, 03 Aug 2020 12:29:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OjYigD2p3SvkFolBbmgzZMPONZM8wJufvetu1fVmKFs=; b=Mv/M2kubZrVgo78P30dXZa713L xCG+lnNtXVYNBD9qRDGHt/0bM+gz6qlDlxa/nYnGQR/7bOzJWstdviGCVgLqQPjQZF6SV0b1NO8o2 axL0HXsrWAJWHo/KUlDN+zU5teCj6mCLqNZUKmqz93LR+aYBzbs0w5HQbMWjDU1iSNxc=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zak-0000SZ-FW; Mon, 03 Aug 2020 12:29:22 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2Zak-0000zk-7k; Mon, 03 Aug 2020 12:29:22 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v3 05/11] iommu: remove unused iommu_ops method and tasklet Date: Mon, 3 Aug 2020 13:29:08 +0100 Message-Id: <20200803122914.2259-6-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200803122914.2259-1-paul@xen.org> References: <20200803122914.2259-1-paul@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Paul Durrant , Jan Beulich Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant The VT-d and AMD IOMMU both use the general x86 IOMMU page table allocator and ARM always shares page tables with CPU. Hence there is no need to retain the free_page_table() method or the tasklet which invokes it. Signed-off-by: Paul Durrant --- Cc: Jan Beulich v2: - New in v2 (split from "add common page-table allocator") --- xen/drivers/passthrough/iommu.c | 25 ------------------------- xen/include/xen/iommu.h | 2 -- 2 files changed, 27 deletions(-) diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c index 2b1db8022c..660dc5deb2 100644 --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -49,10 +49,6 @@ bool_t __read_mostly amd_iommu_perdev_intremap = 1; DEFINE_PER_CPU(bool_t, iommu_dont_flush_iotlb); -DEFINE_SPINLOCK(iommu_pt_cleanup_lock); -PAGE_LIST_HEAD(iommu_pt_cleanup_list); -static struct tasklet iommu_pt_cleanup_tasklet; - static int __init parse_iommu_param(const char *s) { const char *ss; @@ -226,9 +222,6 @@ static void iommu_teardown(struct domain *d) struct domain_iommu *hd = dom_iommu(d); iommu_vcall(hd->platform_ops, teardown, d); - - if ( hd->platform_ops->free_page_table ) - tasklet_schedule(&iommu_pt_cleanup_tasklet); } void iommu_domain_destroy(struct domain *d) @@ -368,23 +361,6 @@ int iommu_lookup_page(struct domain *d, dfn_t dfn, mfn_t *mfn, return iommu_call(hd->platform_ops, lookup_page, d, dfn, mfn, flags); } -static void iommu_free_pagetables(void *unused) -{ - do { - struct page_info *pg; - - spin_lock(&iommu_pt_cleanup_lock); - pg = page_list_remove_head(&iommu_pt_cleanup_list); - spin_unlock(&iommu_pt_cleanup_lock); - if ( !pg ) - return; - iommu_vcall(iommu_get_ops(), free_page_table, pg); - } while ( !softirq_pending(smp_processor_id()) ); - - tasklet_schedule_on_cpu(&iommu_pt_cleanup_tasklet, - cpumask_cycle(smp_processor_id(), &cpu_online_map)); -} - int iommu_iotlb_flush(struct domain *d, dfn_t dfn, unsigned int page_count, unsigned int flush_flags) { @@ -508,7 +484,6 @@ int __init iommu_setup(void) #ifndef iommu_intremap printk("Interrupt remapping %sabled\n", iommu_intremap ? "en" : "dis"); #endif - tasklet_init(&iommu_pt_cleanup_tasklet, iommu_free_pagetables, NULL); } return rc; diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h index 3272874958..1831dc66b0 100644 --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -263,8 +263,6 @@ struct iommu_ops { int __must_check (*lookup_page)(struct domain *d, dfn_t dfn, mfn_t *mfn, unsigned int *flags); - void (*free_page_table)(struct page_info *); - #ifdef CONFIG_X86 int (*enable_x2apic)(void); void (*disable_x2apic)(void); -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 12:29:36 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 12:29:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zav-0007PT-Ku; Mon, 03 Aug 2020 12:29:33 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zav-0007NV-0y for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 12:29:33 +0000 X-Inumbo-ID: f5e9f548-d584-11ea-af26-12813bfff9fa Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f5e9f548-d584-11ea-af26-12813bfff9fa; Mon, 03 Aug 2020 12:29:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=elpnTLLUZTjtNMvn+dphJvziiTX8WkV+tBvTSKCuAxs=; b=h7/WGRhL/brWZsD60ugtkY+z4H OvVOeBW5Do6tKAMB7+KM7b9mP8agqqgAnfHxsxNuxSHd8VD2/HjA2j10SwaSvtXuZ/cYJGNxXSe70 MTqXmW+V4Sa//PQTmYS5ol8cyLwrFiA2hpvm4OYtX2pPJad91yQBjCA3rFTjypcM8kmE=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zaj-0000SM-37; Mon, 03 Aug 2020 12:29:21 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2Zai-0000zk-Rd; Mon, 03 Aug 2020 12:29:21 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v3 03/11] x86/iommu: convert VT-d code to use new page table allocator Date: Mon, 3 Aug 2020 13:29:06 +0100 Message-Id: <20200803122914.2259-4-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200803122914.2259-1-paul@xen.org> References: <20200803122914.2259-1-paul@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Paul Durrant , Kevin Tian , Jan Beulich Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant This patch converts the VT-d code to use the new IOMMU page table allocator function. This allows all the free-ing code to be removed (since it is now handled by the general x86 code) which reduces TLB and cache thrashing as well as shortening the code. The scope of the mapping_lock in intel_iommu_quarantine_init() has also been increased slightly; it should have always covered accesses to 'arch.vtd.pgd_maddr'. NOTE: The common IOMMU needs a slight modification to avoid scheduling the cleanup tasklet if the free_page_table() method is not present (since the tasklet will unconditionally call it). Signed-off-by: Paul Durrant --- Cc: Jan Beulich Cc: Kevin Tian v2: - New in v2 (split from "add common page-table allocator") --- xen/drivers/passthrough/iommu.c | 6 +- xen/drivers/passthrough/vtd/iommu.c | 101 ++++++++++------------------ 2 files changed, 39 insertions(+), 68 deletions(-) diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c index 1d644844ab..2b1db8022c 100644 --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -225,8 +225,10 @@ static void iommu_teardown(struct domain *d) { struct domain_iommu *hd = dom_iommu(d); - hd->platform_ops->teardown(d); - tasklet_schedule(&iommu_pt_cleanup_tasklet); + iommu_vcall(hd->platform_ops, teardown, d); + + if ( hd->platform_ops->free_page_table ) + tasklet_schedule(&iommu_pt_cleanup_tasklet); } void iommu_domain_destroy(struct domain *d) diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c index 94e0455a4d..607e8b5e65 100644 --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -265,10 +265,15 @@ static u64 addr_to_dma_page_maddr(struct domain *domain, u64 addr, int alloc) addr &= (((u64)1) << addr_width) - 1; ASSERT(spin_is_locked(&hd->arch.mapping_lock)); - if ( !hd->arch.vtd.pgd_maddr && - (!alloc || - ((hd->arch.vtd.pgd_maddr = alloc_pgtable_maddr(1, hd->node)) == 0)) ) - goto out; + if ( !hd->arch.vtd.pgd_maddr ) + { + struct page_info *pg; + + if ( !alloc || !(pg = iommu_alloc_pgtable(domain)) ) + goto out; + + hd->arch.vtd.pgd_maddr = page_to_maddr(pg); + } parent = (struct dma_pte *)map_vtd_domain_page(hd->arch.vtd.pgd_maddr); while ( level > 1 ) @@ -279,13 +284,16 @@ static u64 addr_to_dma_page_maddr(struct domain *domain, u64 addr, int alloc) pte_maddr = dma_pte_addr(*pte); if ( !pte_maddr ) { + struct page_info *pg; + if ( !alloc ) break; - pte_maddr = alloc_pgtable_maddr(1, hd->node); - if ( !pte_maddr ) + pg = iommu_alloc_pgtable(domain); + if ( !pg ) break; + pte_maddr = page_to_maddr(pg); dma_set_pte_addr(*pte, pte_maddr); /* @@ -675,45 +683,6 @@ static void dma_pte_clear_one(struct domain *domain, uint64_t addr, unmap_vtd_domain_page(page); } -static void iommu_free_pagetable(u64 pt_maddr, int level) -{ - struct page_info *pg = maddr_to_page(pt_maddr); - - if ( pt_maddr == 0 ) - return; - - PFN_ORDER(pg) = level; - spin_lock(&iommu_pt_cleanup_lock); - page_list_add_tail(pg, &iommu_pt_cleanup_list); - spin_unlock(&iommu_pt_cleanup_lock); -} - -static void iommu_free_page_table(struct page_info *pg) -{ - unsigned int i, next_level = PFN_ORDER(pg) - 1; - u64 pt_maddr = page_to_maddr(pg); - struct dma_pte *pt_vaddr, *pte; - - PFN_ORDER(pg) = 0; - pt_vaddr = (struct dma_pte *)map_vtd_domain_page(pt_maddr); - - for ( i = 0; i < PTE_NUM; i++ ) - { - pte = &pt_vaddr[i]; - if ( !dma_pte_present(*pte) ) - continue; - - if ( next_level >= 1 ) - iommu_free_pagetable(dma_pte_addr(*pte), next_level); - - dma_clear_pte(*pte); - iommu_sync_cache(pte, sizeof(struct dma_pte)); - } - - unmap_vtd_domain_page(pt_vaddr); - free_pgtable_maddr(pt_maddr); -} - static int iommu_set_root_entry(struct vtd_iommu *iommu) { u32 sts; @@ -1748,16 +1717,7 @@ static void iommu_domain_teardown(struct domain *d) xfree(mrmrr); } - ASSERT(is_iommu_enabled(d)); - - if ( iommu_use_hap_pt(d) ) - return; - - spin_lock(&hd->arch.mapping_lock); - iommu_free_pagetable(hd->arch.vtd.pgd_maddr, - agaw_to_level(hd->arch.vtd.agaw)); hd->arch.vtd.pgd_maddr = 0; - spin_unlock(&hd->arch.mapping_lock); } static int __must_check intel_iommu_map_page(struct domain *d, dfn_t dfn, @@ -2669,23 +2629,28 @@ static void vtd_dump_p2m_table(struct domain *d) static int __init intel_iommu_quarantine_init(struct domain *d) { struct domain_iommu *hd = dom_iommu(d); + struct page_info *pg; struct dma_pte *parent; unsigned int agaw = width_to_agaw(DEFAULT_DOMAIN_ADDRESS_WIDTH); unsigned int level = agaw_to_level(agaw); - int rc; + int rc = 0; + + spin_lock(&hd->arch.mapping_lock); if ( hd->arch.vtd.pgd_maddr ) { ASSERT_UNREACHABLE(); - return 0; + goto out; } - spin_lock(&hd->arch.mapping_lock); + pg = iommu_alloc_pgtable(d); - hd->arch.vtd.pgd_maddr = alloc_pgtable_maddr(1, hd->node); - if ( !hd->arch.vtd.pgd_maddr ) + rc = -ENOMEM; + if ( !pg ) goto out; + hd->arch.vtd.pgd_maddr = page_to_maddr(pg); + parent = map_vtd_domain_page(hd->arch.vtd.pgd_maddr); while ( level ) { @@ -2697,10 +2662,12 @@ static int __init intel_iommu_quarantine_init(struct domain *d) * page table pages, and the resulting allocations are always * zeroed. */ - maddr = alloc_pgtable_maddr(1, hd->node); - if ( !maddr ) - break; + pg = iommu_alloc_pgtable(d); + + if ( !pg ) + goto out; + maddr = page_to_maddr(pg); for ( offset = 0; offset < PTE_NUM; offset++ ) { struct dma_pte *pte = &parent[offset]; @@ -2716,13 +2683,16 @@ static int __init intel_iommu_quarantine_init(struct domain *d) } unmap_vtd_domain_page(parent); + rc = 0; + out: spin_unlock(&hd->arch.mapping_lock); - rc = iommu_flush_iotlb_all(d); + if ( !rc ) + rc = iommu_flush_iotlb_all(d); - /* Pages leaked in failure case */ - return level ? -ENOMEM : rc; + /* Pages may be leaked in failure case */ + return rc; } static struct iommu_ops __initdata vtd_ops = { @@ -2737,7 +2707,6 @@ static struct iommu_ops __initdata vtd_ops = { .map_page = intel_iommu_map_page, .unmap_page = intel_iommu_unmap_page, .lookup_page = intel_iommu_lookup_page, - .free_page_table = iommu_free_page_table, .reassign_device = reassign_device_ownership, .get_device_group_id = intel_iommu_group_id, .enable_x2apic = intel_iommu_enable_eim, -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 12:29:36 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 12:29:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zam-0007Nh-Ew; Mon, 03 Aug 2020 12:29:24 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zal-0007NV-3K for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 12:29:23 +0000 X-Inumbo-ID: f481e80d-d584-11ea-af26-12813bfff9fa Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f481e80d-d584-11ea-af26-12813bfff9fa; Mon, 03 Aug 2020 12:29:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=iVlV6A3h4X55OEXHk9G84ICiy3M1GOBVbr0WOEPJNIs=; b=YqY4ceW9mOdF8yT22X22X4jIiS hg7fD5rTfJRA0uOrnS9IetqU8eavQDL9HdaNbSYhmiJPsIJSjjoJ9cFBvt/KDK8uWm8Xsk/L0XNGj pK2XRV/nfS79WQgJ0+VC2yRTuEt9/KxlXCOJUyXU+J085UWKZlmvOQCmIYbg0AyMPBAQ=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zag-0000SG-Dv; Mon, 03 Aug 2020 12:29:18 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2Zag-0000zk-1r; Mon, 03 Aug 2020 12:29:18 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v3 00/11] IOMMU cleanup Date: Mon, 3 Aug 2020 13:29:03 +0100 Message-Id: <20200803122914.2259-1-paul@xen.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Tian , Stefano Stabellini , Julien Grall , Jun Nakajima , Wei Liu , Paul Durrant , Andrew Cooper , Paul Durrant , Ian Jackson , George Dunlap , Lukasz Hawrylko , Jan Beulich , Volodymyr Babchuk , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant Paul Durrant (11): x86/iommu: re-arrange arch_iommu to separate common fields... x86/iommu: add common page-table allocator x86/iommu: convert VT-d code to use new page table allocator x86/iommu: convert AMD IOMMU code to use new page table allocator iommu: remove unused iommu_ops method and tasklet iommu: flush I/O TLB if iommu_map() or iommu_unmap() fail iommu: make map, unmap and flush all take both an order and a count remove remaining uses of iommu_legacy_map/unmap common/grant_table: batch flush I/O TLB iommu: remove the share_p2m operation iommu: stop calling IOMMU page tables 'p2m tables' xen/arch/arm/p2m.c | 2 +- xen/arch/x86/domain.c | 9 +- xen/arch/x86/mm.c | 21 +- xen/arch/x86/mm/p2m-ept.c | 20 +- xen/arch/x86/mm/p2m-pt.c | 15 +- xen/arch/x86/mm/p2m.c | 29 ++- xen/arch/x86/tboot.c | 4 +- xen/arch/x86/x86_64/mm.c | 27 ++- xen/common/grant_table.c | 142 +++++++---- xen/common/memory.c | 9 +- xen/drivers/passthrough/amd/iommu.h | 20 +- xen/drivers/passthrough/amd/iommu_guest.c | 8 +- xen/drivers/passthrough/amd/iommu_map.c | 26 +- xen/drivers/passthrough/amd/pci_amd_iommu.c | 110 +++------ xen/drivers/passthrough/arm/ipmmu-vmsa.c | 2 +- xen/drivers/passthrough/arm/smmu.c | 2 +- xen/drivers/passthrough/iommu.c | 118 ++-------- xen/drivers/passthrough/vtd/iommu.c | 248 +++++++++----------- xen/drivers/passthrough/x86/iommu.c | 53 ++++- xen/include/asm-x86/iommu.h | 34 ++- xen/include/xen/iommu.h | 37 +-- 21 files changed, 459 insertions(+), 477 deletions(-) --- Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich Cc: Julien Grall Cc: Jun Nakajima Cc: Kevin Tian Cc: Lukasz Hawrylko Cc: Paul Durrant Cc: "Roger Pau Monné" Cc: Stefano Stabellini Cc: Volodymyr Babchuk Cc: Wei Liu -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 12:29:36 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 12:29:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zal-0007Nb-6Y; Mon, 03 Aug 2020 12:29:23 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zak-0007NQ-3r for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 12:29:22 +0000 X-Inumbo-ID: f504fbfa-d584-11ea-908e-bc764e2007e4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f504fbfa-d584-11ea-908e-bc764e2007e4; Mon, 03 Aug 2020 12:29:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8U08S+YRqI08xJppp7uptBqaQOaqPH/Srqc89QgMt6g=; b=nnvDDOIxHC+qaZjUGzeRL/ech9 LK7BwMfqYd25257KxEZ9BdRG2y8Wf5e7OSA6f54XMMaJs7idIpqM9UrXqNWwtzNyF4ol+1Lugx31J 47AFXbJwScOdyYRQdEq5U9SnZFjwLYVUngk7QtGbex/OABmTTBcWplDpF2kBq5KJzApA=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zai-0000SK-Aw; Mon, 03 Aug 2020 12:29:20 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2Zai-0000zk-3q; Mon, 03 Aug 2020 12:29:20 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v3 02/11] x86/iommu: add common page-table allocator Date: Mon, 3 Aug 2020 13:29:05 +0100 Message-Id: <20200803122914.2259-3-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200803122914.2259-1-paul@xen.org> References: <20200803122914.2259-1-paul@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Paul Durrant , Wei Liu , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant Instead of having separate page table allocation functions in VT-d and AMD IOMMU code, we could use a common allocation function in the general x86 code. This patch adds a new allocation function, iommu_alloc_pgtable(), for this purpose. The function adds the page table pages to a list. The pages in this list are then freed by iommu_free_pgtables(), which is called by domain_relinquish_resources() after PCI devices have been de-assigned. Signed-off-by: Paul Durrant --- Cc: Jan Beulich Cc: Andrew Cooper Cc: Wei Liu Cc: "Roger Pau Monné" v2: - This is split out from a larger patch of the same name in v1 --- xen/arch/x86/domain.c | 9 +++++- xen/drivers/passthrough/x86/iommu.c | 50 +++++++++++++++++++++++++++++ xen/include/asm-x86/iommu.h | 7 ++++ 3 files changed, 65 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index f8084dc9e3..d1ecc7b83b 100644 --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -2153,7 +2153,8 @@ int domain_relinquish_resources(struct domain *d) d->arch.rel_priv = PROG_ ## x; /* Fallthrough */ case PROG_ ## x enum { - PROG_paging = 1, + PROG_iommu_pagetables = 1, + PROG_paging, PROG_vcpu_pagetables, PROG_shared, PROG_xen, @@ -2168,6 +2169,12 @@ int domain_relinquish_resources(struct domain *d) if ( ret ) return ret; + PROGRESS(iommu_pagetables): + + ret = iommu_free_pgtables(d); + if ( ret ) + return ret; + PROGRESS(paging): /* Tear down paging-assistance stuff. */ diff --git a/xen/drivers/passthrough/x86/iommu.c b/xen/drivers/passthrough/x86/iommu.c index a12109a1de..c0d4865dd7 100644 --- a/xen/drivers/passthrough/x86/iommu.c +++ b/xen/drivers/passthrough/x86/iommu.c @@ -140,6 +140,9 @@ int arch_iommu_domain_init(struct domain *d) spin_lock_init(&hd->arch.mapping_lock); + INIT_PAGE_LIST_HEAD(&hd->arch.pgtables.list); + spin_lock_init(&hd->arch.pgtables.lock); + return 0; } @@ -257,6 +260,53 @@ void __hwdom_init arch_iommu_hwdom_init(struct domain *d) return; } +int iommu_free_pgtables(struct domain *d) +{ + struct domain_iommu *hd = dom_iommu(d); + struct page_info *pg; + + while ( (pg = page_list_remove_head(&hd->arch.pgtables.list)) ) + { + free_domheap_page(pg); + + if ( general_preempt_check() ) + return -ERESTART; + } + + return 0; +} + +struct page_info *iommu_alloc_pgtable(struct domain *d) +{ + struct domain_iommu *hd = dom_iommu(d); + unsigned int memflags = 0; + struct page_info *pg; + void *p; + +#ifdef CONFIG_NUMA + if (hd->node != NUMA_NO_NODE) + memflags = MEMF_node(hd->node); +#endif + + pg = alloc_domheap_page(NULL, memflags); + if ( !pg ) + return NULL; + + p = __map_domain_page(pg); + clear_page(p); + + if ( hd->platform_ops->sync_cache ) + iommu_vcall(hd->platform_ops, sync_cache, p, PAGE_SIZE); + + unmap_domain_page(p); + + spin_lock(&hd->arch.pgtables.lock); + page_list_add(pg, &hd->arch.pgtables.list); + spin_unlock(&hd->arch.pgtables.lock); + + return pg; +} + /* * Local variables: * mode: C diff --git a/xen/include/asm-x86/iommu.h b/xen/include/asm-x86/iommu.h index 8ce97c981f..31f6d4a8d8 100644 --- a/xen/include/asm-x86/iommu.h +++ b/xen/include/asm-x86/iommu.h @@ -46,6 +46,10 @@ typedef uint64_t daddr_t; struct arch_iommu { spinlock_t mapping_lock; /* io page table lock */ + struct { + struct page_list_head list; + spinlock_t lock; + } pgtables; union { /* Intel VT-d */ @@ -131,6 +135,9 @@ int pi_update_irte(const struct pi_desc *pi_desc, const struct pirq *pirq, iommu_vcall(ops, sync_cache, addr, size); \ }) +int __must_check iommu_free_pgtables(struct domain *d); +struct page_info * __must_check iommu_alloc_pgtable(struct domain *d); + #endif /* !__ARCH_X86_IOMMU_H__ */ /* * Local variables: -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 12:29:38 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 12:29:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zaz-0007Rq-UW; Mon, 03 Aug 2020 12:29:37 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zay-0007NQ-WD for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 12:29:37 +0000 X-Inumbo-ID: f64d0c28-d584-11ea-908e-bc764e2007e4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f64d0c28-d584-11ea-908e-bc764e2007e4; Mon, 03 Aug 2020 12:29:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tvDh3hWaZXavS9k/pMM3gTVqpPl5TsT49cdKXt8Ayaw=; b=HvotJXgou3QFoAnBLa3W3QilbN Tkb+aZJvYDftm5g9OqfYQQwqupLc+wcIYHwMqN+95qRsVRDssUjqS5X0zjiV6Ngl7T0jDX3JF/mhb s21IVvF5pcx/wlz4jLcJ/+anUQvzMk5lgtqWjG5rNqnQHHxLAZk8mC66wDKPBltG9j14=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zal-0000Sj-3y; Mon, 03 Aug 2020 12:29:23 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2Zak-0000zk-SX; Mon, 03 Aug 2020 12:29:23 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v3 06/11] iommu: flush I/O TLB if iommu_map() or iommu_unmap() fail Date: Mon, 3 Aug 2020 13:29:09 +0100 Message-Id: <20200803122914.2259-7-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200803122914.2259-1-paul@xen.org> References: <20200803122914.2259-1-paul@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Paul Durrant , Jan Beulich Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant This patch adds a full I/O TLB flush to the error paths of iommu_map() and iommu_unmap(). Without this change callers need constructs such as: rc = iommu_map/unmap(...) err = iommu_flush(...) if ( !rc ) rc = err; With this change, it can be simplified to: rc = iommu_map/unmap(...) if ( !rc ) rc = iommu_flush(...) because, if the map or unmap fails the flush will be unnecessary. This saves a stack variable and generally makes the call sites tidier. Signed-off-by: Paul Durrant --- Cc: Jan Beulich v2: - New in v2 --- xen/drivers/passthrough/iommu.c | 28 ++++++++++++---------------- 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c index 660dc5deb2..e2c0193a09 100644 --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -274,6 +274,10 @@ int iommu_map(struct domain *d, dfn_t dfn, mfn_t mfn, break; } + /* Something went wrong so flush everything and clear flush flags */ + if ( unlikely(rc) && iommu_iotlb_flush_all(d, *flush_flags) ) + flush_flags = 0; + return rc; } @@ -283,14 +287,8 @@ int iommu_legacy_map(struct domain *d, dfn_t dfn, mfn_t mfn, unsigned int flush_flags = 0; int rc = iommu_map(d, dfn, mfn, page_order, flags, &flush_flags); - if ( !this_cpu(iommu_dont_flush_iotlb) ) - { - int err = iommu_iotlb_flush(d, dfn, (1u << page_order), - flush_flags); - - if ( !rc ) - rc = err; - } + if ( !this_cpu(iommu_dont_flush_iotlb) && !rc ) + rc = iommu_iotlb_flush(d, dfn, (1u << page_order), flush_flags); return rc; } @@ -330,6 +328,10 @@ int iommu_unmap(struct domain *d, dfn_t dfn, unsigned int page_order, } } + /* Something went wrong so flush everything and clear flush flags */ + if ( unlikely(rc) && iommu_iotlb_flush_all(d, *flush_flags) ) + flush_flags = 0; + return rc; } @@ -338,14 +340,8 @@ int iommu_legacy_unmap(struct domain *d, dfn_t dfn, unsigned int page_order) unsigned int flush_flags = 0; int rc = iommu_unmap(d, dfn, page_order, &flush_flags); - if ( !this_cpu(iommu_dont_flush_iotlb) ) - { - int err = iommu_iotlb_flush(d, dfn, (1u << page_order), - flush_flags); - - if ( !rc ) - rc = err; - } + if ( !this_cpu(iommu_dont_flush_iotlb) && ! rc ) + rc = iommu_iotlb_flush(d, dfn, (1u << page_order), flush_flags); return rc; } -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 12:29:39 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 12:29:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zb1-0007Sy-7o; Mon, 03 Aug 2020 12:29:39 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zb0-0007NV-1K for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 12:29:38 +0000 X-Inumbo-ID: f874932c-d584-11ea-af26-12813bfff9fa Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f874932c-d584-11ea-af26-12813bfff9fa; Mon, 03 Aug 2020 12:29:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fFPZHQeR1imbV8GidBB6NY5g3/DPW1fb7q91uXermqU=; b=uEf/Z2yliB8l5Ui5lvnwyjW9GU rstZL1kdKNsofLNh/3QBs3IdkSbTfZoLMk9Yy9Vse8kMg+Lz8GHuveJGvOseMoNC20LRE3IBXP5ln vhhOAekw9g1eeUiuH57MJpryT4qxcH4QwI/0HsZRn3qAgjRwOhx4P4e6DoER3U3GSTkE=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zam-0000Sy-LM; Mon, 03 Aug 2020 12:29:24 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2Zam-0000zk-EA; Mon, 03 Aug 2020 12:29:24 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v3 07/11] iommu: make map, unmap and flush all take both an order and a count Date: Mon, 3 Aug 2020 13:29:10 +0100 Message-Id: <20200803122914.2259-8-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200803122914.2259-1-paul@xen.org> References: <20200803122914.2259-1-paul@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Tian , Stefano Stabellini , Julien Grall , Jun Nakajima , Wei Liu , Andrew Cooper , Paul Durrant , Ian Jackson , George Dunlap , Jan Beulich , Volodymyr Babchuk , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant At the moment iommu_map() and iommu_unmap() take a page order but not a count, whereas iommu_iotlb_flush() takes a count but not a page order. This patch simply makes them consistent with each other. Signed-off-by: Paul Durrant --- Cc: Jun Nakajima Cc: Kevin Tian Cc: Jan Beulich Cc: Andrew Cooper Cc: George Dunlap Cc: Wei Liu Cc: "Roger Pau Monné" Cc: Ian Jackson Cc: Julien Grall Cc: Stefano Stabellini Cc: Volodymyr Babchuk v2: - New in v2 --- xen/arch/arm/p2m.c | 2 +- xen/arch/x86/mm/p2m-ept.c | 2 +- xen/common/memory.c | 4 +-- xen/drivers/passthrough/amd/iommu.h | 2 +- xen/drivers/passthrough/amd/iommu_map.c | 4 +-- xen/drivers/passthrough/arm/ipmmu-vmsa.c | 2 +- xen/drivers/passthrough/arm/smmu.c | 2 +- xen/drivers/passthrough/iommu.c | 31 ++++++++++++------------ xen/drivers/passthrough/vtd/iommu.c | 4 +-- xen/drivers/passthrough/x86/iommu.c | 2 +- xen/include/xen/iommu.h | 9 ++++--- 11 files changed, 33 insertions(+), 31 deletions(-) diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index ce59f2b503..71f4a78425 100644 --- a/xen/arch/arm/p2m.c +++ b/xen/arch/arm/p2m.c @@ -1061,7 +1061,7 @@ static int __p2m_set_entry(struct p2m_domain *p2m, flush_flags |= IOMMU_FLUSHF_added; rc = iommu_iotlb_flush(p2m->domain, _dfn(gfn_x(sgfn)), - 1UL << page_order, flush_flags); + page_order, 1, flush_flags); } else rc = 0; diff --git a/xen/arch/x86/mm/p2m-ept.c b/xen/arch/x86/mm/p2m-ept.c index b8154a7ecc..b2ac912cde 100644 --- a/xen/arch/x86/mm/p2m-ept.c +++ b/xen/arch/x86/mm/p2m-ept.c @@ -843,7 +843,7 @@ out: need_modify_vtd_table ) { if ( iommu_use_hap_pt(d) ) - rc = iommu_iotlb_flush(d, _dfn(gfn), (1u << order), + rc = iommu_iotlb_flush(d, _dfn(gfn), (1u << order), 1, (iommu_flags ? IOMMU_FLUSHF_added : 0) | (vtd_pte_present ? IOMMU_FLUSHF_modified : 0)); diff --git a/xen/common/memory.c b/xen/common/memory.c index 714077c1e5..8de334ff10 100644 --- a/xen/common/memory.c +++ b/xen/common/memory.c @@ -851,12 +851,12 @@ int xenmem_add_to_physmap(struct domain *d, struct xen_add_to_physmap *xatp, this_cpu(iommu_dont_flush_iotlb) = 0; - ret = iommu_iotlb_flush(d, _dfn(xatp->idx - done), done, + ret = iommu_iotlb_flush(d, _dfn(xatp->idx - done), 0, done, IOMMU_FLUSHF_added | IOMMU_FLUSHF_modified); if ( unlikely(ret) && rc >= 0 ) rc = ret; - ret = iommu_iotlb_flush(d, _dfn(xatp->gpfn - done), done, + ret = iommu_iotlb_flush(d, _dfn(xatp->gpfn - done), 0, done, IOMMU_FLUSHF_added | IOMMU_FLUSHF_modified); if ( unlikely(ret) && rc >= 0 ) rc = ret; diff --git a/xen/drivers/passthrough/amd/iommu.h b/xen/drivers/passthrough/amd/iommu.h index e2d174f3b4..f1f0415469 100644 --- a/xen/drivers/passthrough/amd/iommu.h +++ b/xen/drivers/passthrough/amd/iommu.h @@ -231,7 +231,7 @@ int amd_iommu_reserve_domain_unity_map(struct domain *domain, paddr_t phys_addr, unsigned long size, int iw, int ir); int __must_check amd_iommu_flush_iotlb_pages(struct domain *d, dfn_t dfn, - unsigned int page_count, + unsigned long page_count, unsigned int flush_flags); int __must_check amd_iommu_flush_iotlb_all(struct domain *d); diff --git a/xen/drivers/passthrough/amd/iommu_map.c b/xen/drivers/passthrough/amd/iommu_map.c index 54b991294a..0cb948d114 100644 --- a/xen/drivers/passthrough/amd/iommu_map.c +++ b/xen/drivers/passthrough/amd/iommu_map.c @@ -351,7 +351,7 @@ int amd_iommu_unmap_page(struct domain *d, dfn_t dfn, return 0; } -static unsigned long flush_count(unsigned long dfn, unsigned int page_count, +static unsigned long flush_count(unsigned long dfn, unsigned long page_count, unsigned int order) { unsigned long start = dfn >> order; @@ -362,7 +362,7 @@ static unsigned long flush_count(unsigned long dfn, unsigned int page_count, } int amd_iommu_flush_iotlb_pages(struct domain *d, dfn_t dfn, - unsigned int page_count, + unsigned long page_count, unsigned int flush_flags) { unsigned long dfn_l = dfn_x(dfn); diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c b/xen/drivers/passthrough/arm/ipmmu-vmsa.c index b2a65dfaaf..346165c3fa 100644 --- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c +++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c @@ -945,7 +945,7 @@ static int __must_check ipmmu_iotlb_flush_all(struct domain *d) } static int __must_check ipmmu_iotlb_flush(struct domain *d, dfn_t dfn, - unsigned int page_count, + unsigned long page_count, unsigned int flush_flags) { ASSERT(flush_flags); diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c index 94662a8501..06f9bda47d 100644 --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -2534,7 +2534,7 @@ static int __must_check arm_smmu_iotlb_flush_all(struct domain *d) } static int __must_check arm_smmu_iotlb_flush(struct domain *d, dfn_t dfn, - unsigned int page_count, + unsigned long page_count, unsigned int flush_flags) { ASSERT(flush_flags); diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c index e2c0193a09..568a4a5661 100644 --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -235,8 +235,8 @@ void iommu_domain_destroy(struct domain *d) } int iommu_map(struct domain *d, dfn_t dfn, mfn_t mfn, - unsigned int page_order, unsigned int flags, - unsigned int *flush_flags) + unsigned int page_order, unsigned int page_count, + unsigned int flags, unsigned int *flush_flags) { const struct domain_iommu *hd = dom_iommu(d); unsigned long i; @@ -248,7 +248,7 @@ int iommu_map(struct domain *d, dfn_t dfn, mfn_t mfn, ASSERT(IS_ALIGNED(dfn_x(dfn), (1ul << page_order))); ASSERT(IS_ALIGNED(mfn_x(mfn), (1ul << page_order))); - for ( i = 0; i < (1ul << page_order); i++ ) + for ( i = 0; i < ((unsigned long)page_count << page_order); i++ ) { rc = iommu_call(hd->platform_ops, map_page, d, dfn_add(dfn, i), mfn_add(mfn, i), flags, flush_flags); @@ -285,16 +285,16 @@ int iommu_legacy_map(struct domain *d, dfn_t dfn, mfn_t mfn, unsigned int page_order, unsigned int flags) { unsigned int flush_flags = 0; - int rc = iommu_map(d, dfn, mfn, page_order, flags, &flush_flags); + int rc = iommu_map(d, dfn, mfn, page_order, 1, flags, &flush_flags); if ( !this_cpu(iommu_dont_flush_iotlb) && !rc ) - rc = iommu_iotlb_flush(d, dfn, (1u << page_order), flush_flags); + rc = iommu_iotlb_flush(d, dfn, (1u << page_order), 1, flush_flags); return rc; } int iommu_unmap(struct domain *d, dfn_t dfn, unsigned int page_order, - unsigned int *flush_flags) + unsigned int page_count, unsigned int *flush_flags) { const struct domain_iommu *hd = dom_iommu(d); unsigned long i; @@ -305,7 +305,7 @@ int iommu_unmap(struct domain *d, dfn_t dfn, unsigned int page_order, ASSERT(IS_ALIGNED(dfn_x(dfn), (1ul << page_order))); - for ( i = 0; i < (1ul << page_order); i++ ) + for ( i = 0; i < ((unsigned long)page_count << page_order); i++ ) { int err = iommu_call(hd->platform_ops, unmap_page, d, dfn_add(dfn, i), flush_flags); @@ -338,10 +338,10 @@ int iommu_unmap(struct domain *d, dfn_t dfn, unsigned int page_order, int iommu_legacy_unmap(struct domain *d, dfn_t dfn, unsigned int page_order) { unsigned int flush_flags = 0; - int rc = iommu_unmap(d, dfn, page_order, &flush_flags); + int rc = iommu_unmap(d, dfn, page_order, 1, &flush_flags); if ( !this_cpu(iommu_dont_flush_iotlb) && ! rc ) - rc = iommu_iotlb_flush(d, dfn, (1u << page_order), flush_flags); + rc = iommu_iotlb_flush(d, dfn, (1u << page_order), 1, flush_flags); return rc; } @@ -357,8 +357,8 @@ int iommu_lookup_page(struct domain *d, dfn_t dfn, mfn_t *mfn, return iommu_call(hd->platform_ops, lookup_page, d, dfn, mfn, flags); } -int iommu_iotlb_flush(struct domain *d, dfn_t dfn, unsigned int page_count, - unsigned int flush_flags) +int iommu_iotlb_flush(struct domain *d, dfn_t dfn, unsigned int page_order, + unsigned int page_count, unsigned int flush_flags) { const struct domain_iommu *hd = dom_iommu(d); int rc; @@ -370,14 +370,15 @@ int iommu_iotlb_flush(struct domain *d, dfn_t dfn, unsigned int page_count, if ( dfn_eq(dfn, INVALID_DFN) ) return -EINVAL; - rc = iommu_call(hd->platform_ops, iotlb_flush, d, dfn, page_count, - flush_flags); + rc = iommu_call(hd->platform_ops, iotlb_flush, d, dfn, + (unsigned long)page_count << page_order, flush_flags); if ( unlikely(rc) ) { if ( !d->is_shutting_down && printk_ratelimit() ) printk(XENLOG_ERR - "d%d: IOMMU IOTLB flush failed: %d, dfn %"PRI_dfn", page count %u flags %x\n", - d->domain_id, rc, dfn_x(dfn), page_count, flush_flags); + "d%d: IOMMU IOTLB flush failed: %d, dfn %"PRI_dfn", page order %u, page count %u flags %x\n", + d->domain_id, rc, dfn_x(dfn), page_order, page_count, + flush_flags); if ( !is_hardware_domain(d) ) domain_crash(d); diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c index 607e8b5e65..68cf0e535a 100644 --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -584,7 +584,7 @@ static int __must_check iommu_flush_all(void) static int __must_check iommu_flush_iotlb(struct domain *d, dfn_t dfn, bool_t dma_old_pte_present, - unsigned int page_count) + unsigned long page_count) { struct domain_iommu *hd = dom_iommu(d); struct acpi_drhd_unit *drhd; @@ -632,7 +632,7 @@ static int __must_check iommu_flush_iotlb(struct domain *d, dfn_t dfn, static int __must_check iommu_flush_iotlb_pages(struct domain *d, dfn_t dfn, - unsigned int page_count, + unsigned long page_count, unsigned int flush_flags) { ASSERT(page_count && !dfn_eq(dfn, INVALID_DFN)); diff --git a/xen/drivers/passthrough/x86/iommu.c b/xen/drivers/passthrough/x86/iommu.c index c0d4865dd7..5d1a7cb296 100644 --- a/xen/drivers/passthrough/x86/iommu.c +++ b/xen/drivers/passthrough/x86/iommu.c @@ -244,7 +244,7 @@ void __hwdom_init arch_iommu_hwdom_init(struct domain *d) else if ( paging_mode_translate(d) ) rc = set_identity_p2m_entry(d, pfn, p2m_access_rw, 0); else - rc = iommu_map(d, _dfn(pfn), _mfn(pfn), PAGE_ORDER_4K, + rc = iommu_map(d, _dfn(pfn), _mfn(pfn), PAGE_ORDER_4K, 1, IOMMUF_readable | IOMMUF_writable, &flush_flags); if ( rc ) diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h index 1831dc66b0..d9c2e764aa 100644 --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -146,10 +146,10 @@ enum #define IOMMU_FLUSHF_modified (1u << _IOMMU_FLUSHF_modified) int __must_check iommu_map(struct domain *d, dfn_t dfn, mfn_t mfn, - unsigned int page_order, unsigned int flags, - unsigned int *flush_flags); + unsigned int page_order, unsigned int page_count, + unsigned int flags, unsigned int *flush_flags); int __must_check iommu_unmap(struct domain *d, dfn_t dfn, - unsigned int page_order, + unsigned int page_order, unsigned int page_count, unsigned int *flush_flags); int __must_check iommu_legacy_map(struct domain *d, dfn_t dfn, mfn_t mfn, @@ -162,6 +162,7 @@ int __must_check iommu_lookup_page(struct domain *d, dfn_t dfn, mfn_t *mfn, unsigned int *flags); int __must_check iommu_iotlb_flush(struct domain *d, dfn_t dfn, + unsigned int page_order, unsigned int page_count, unsigned int flush_flags); int __must_check iommu_iotlb_flush_all(struct domain *d, @@ -281,7 +282,7 @@ struct iommu_ops { void (*share_p2m)(struct domain *d); void (*crash_shutdown)(void); int __must_check (*iotlb_flush)(struct domain *d, dfn_t dfn, - unsigned int page_count, + unsigned long page_count, unsigned int flush_flags); int __must_check (*iotlb_flush_all)(struct domain *d); int (*get_reserved_device_memory)(iommu_grdm_t *, void *); -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 12:29:39 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 12:29:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zau-0007Oy-CZ; Mon, 03 Aug 2020 12:29:32 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zat-0007NQ-W0 for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 12:29:32 +0000 X-Inumbo-ID: f504fbfb-d584-11ea-908e-bc764e2007e4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f504fbfb-d584-11ea-908e-bc764e2007e4; Mon, 03 Aug 2020 12:29:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=c4JuIE359pliqogW7rVMUNX38I11naurubgFqG5WTDA=; b=05ilK4uRL41reMgocvGgUEdTlY 57MkkeK/w0NM2kF8bCIQFM3Z1Ns7CwbxpRCVvs00OOWesMslU1baIZStpUhDbymaSJuBFwHy+Bs9p VNGf3RpVt4RZh09XGHZ9zX9RAE+lwCxocLcJUcJgY+PXT+8VGuoOQFpmtoWUbiy0usVw=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zaj-0000SS-Q2; Mon, 03 Aug 2020 12:29:21 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2Zaj-0000zk-JA; Mon, 03 Aug 2020 12:29:21 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v3 04/11] x86/iommu: convert AMD IOMMU code to use new page table allocator Date: Mon, 3 Aug 2020 13:29:07 +0100 Message-Id: <20200803122914.2259-5-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200803122914.2259-1-paul@xen.org> References: <20200803122914.2259-1-paul@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Paul Durrant , Jan Beulich Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant This patch converts the AMD IOMMU code to use the new page table allocator function. This allows all the free-ing code to be removed (since it is now handled by the general x86 code) which reduces TLB and cache thrashing as well as shortening the code. Signed-off-by: Paul Durrant --- Cc: Jan Beulich Cc: Andrew Cooper v2: - New in v2 (split from "add common page-table allocator") --- xen/drivers/passthrough/amd/iommu.h | 18 +---- xen/drivers/passthrough/amd/iommu_map.c | 10 +-- xen/drivers/passthrough/amd/pci_amd_iommu.c | 75 +++------------------ 3 files changed, 16 insertions(+), 87 deletions(-) diff --git a/xen/drivers/passthrough/amd/iommu.h b/xen/drivers/passthrough/amd/iommu.h index 3489c2a015..e2d174f3b4 100644 --- a/xen/drivers/passthrough/amd/iommu.h +++ b/xen/drivers/passthrough/amd/iommu.h @@ -226,7 +226,7 @@ int __must_check amd_iommu_map_page(struct domain *d, dfn_t dfn, unsigned int *flush_flags); int __must_check amd_iommu_unmap_page(struct domain *d, dfn_t dfn, unsigned int *flush_flags); -int __must_check amd_iommu_alloc_root(struct domain_iommu *hd); +int __must_check amd_iommu_alloc_root(struct domain *d); int amd_iommu_reserve_domain_unity_map(struct domain *domain, paddr_t phys_addr, unsigned long size, int iw, int ir); @@ -356,22 +356,6 @@ static inline int amd_iommu_get_paging_mode(unsigned long max_frames) return level; } -static inline struct page_info *alloc_amd_iommu_pgtable(void) -{ - struct page_info *pg = alloc_domheap_page(NULL, 0); - - if ( pg ) - clear_domain_page(page_to_mfn(pg)); - - return pg; -} - -static inline void free_amd_iommu_pgtable(struct page_info *pg) -{ - if ( pg ) - free_domheap_page(pg); -} - static inline void *__alloc_amd_iommu_tables(unsigned int order) { return alloc_xenheap_pages(order, 0); diff --git a/xen/drivers/passthrough/amd/iommu_map.c b/xen/drivers/passthrough/amd/iommu_map.c index 47b4472e8a..54b991294a 100644 --- a/xen/drivers/passthrough/amd/iommu_map.c +++ b/xen/drivers/passthrough/amd/iommu_map.c @@ -217,7 +217,7 @@ static int iommu_pde_from_dfn(struct domain *d, unsigned long dfn, mfn = next_table_mfn; /* allocate lower level page table */ - table = alloc_amd_iommu_pgtable(); + table = iommu_alloc_pgtable(d); if ( table == NULL ) { AMD_IOMMU_DEBUG("Cannot allocate I/O page table\n"); @@ -248,7 +248,7 @@ static int iommu_pde_from_dfn(struct domain *d, unsigned long dfn, if ( next_table_mfn == 0 ) { - table = alloc_amd_iommu_pgtable(); + table = iommu_alloc_pgtable(d); if ( table == NULL ) { AMD_IOMMU_DEBUG("Cannot allocate I/O page table\n"); @@ -286,7 +286,7 @@ int amd_iommu_map_page(struct domain *d, dfn_t dfn, mfn_t mfn, spin_lock(&hd->arch.mapping_lock); - rc = amd_iommu_alloc_root(hd); + rc = amd_iommu_alloc_root(d); if ( rc ) { spin_unlock(&hd->arch.mapping_lock); @@ -458,7 +458,7 @@ int __init amd_iommu_quarantine_init(struct domain *d) spin_lock(&hd->arch.mapping_lock); - hd->arch.amd.root_table = alloc_amd_iommu_pgtable(); + hd->arch.amd.root_table = iommu_alloc_pgtable(d); if ( !hd->arch.amd.root_table ) goto out; @@ -473,7 +473,7 @@ int __init amd_iommu_quarantine_init(struct domain *d) * page table pages, and the resulting allocations are always * zeroed. */ - pg = alloc_amd_iommu_pgtable(); + pg = iommu_alloc_pgtable(d); if ( !pg ) break; diff --git a/xen/drivers/passthrough/amd/pci_amd_iommu.c b/xen/drivers/passthrough/amd/pci_amd_iommu.c index c27bfbd48e..d79668f948 100644 --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c @@ -205,11 +205,13 @@ static int iov_enable_xt(void) return 0; } -int amd_iommu_alloc_root(struct domain_iommu *hd) +int amd_iommu_alloc_root(struct domain *d) { + struct domain_iommu *hd = dom_iommu(d); + if ( unlikely(!hd->arch.amd.root_table) ) { - hd->arch.amd.root_table = alloc_amd_iommu_pgtable(); + hd->arch.amd.root_table = iommu_alloc_pgtable(d); if ( !hd->arch.amd.root_table ) return -ENOMEM; } @@ -217,12 +219,13 @@ int amd_iommu_alloc_root(struct domain_iommu *hd) return 0; } -static int __must_check allocate_domain_resources(struct domain_iommu *hd) +static int __must_check allocate_domain_resources(struct domain *d) { + struct domain_iommu *hd = dom_iommu(d); int rc; spin_lock(&hd->arch.mapping_lock); - rc = amd_iommu_alloc_root(hd); + rc = amd_iommu_alloc_root(d); spin_unlock(&hd->arch.mapping_lock); return rc; @@ -254,7 +257,7 @@ static void __hwdom_init amd_iommu_hwdom_init(struct domain *d) { const struct amd_iommu *iommu; - if ( allocate_domain_resources(dom_iommu(d)) ) + if ( allocate_domain_resources(d) ) BUG(); for_each_amd_iommu ( iommu ) @@ -323,7 +326,6 @@ static int reassign_device(struct domain *source, struct domain *target, { struct amd_iommu *iommu; int bdf, rc; - struct domain_iommu *t = dom_iommu(target); bdf = PCI_BDF2(pdev->bus, pdev->devfn); iommu = find_iommu_for_device(pdev->seg, bdf); @@ -344,7 +346,7 @@ static int reassign_device(struct domain *source, struct domain *target, pdev->domain = target; } - rc = allocate_domain_resources(t); + rc = allocate_domain_resources(target); if ( rc ) return rc; @@ -376,65 +378,9 @@ static int amd_iommu_assign_device(struct domain *d, u8 devfn, return reassign_device(pdev->domain, d, devfn, pdev); } -static void deallocate_next_page_table(struct page_info *pg, int level) -{ - PFN_ORDER(pg) = level; - spin_lock(&iommu_pt_cleanup_lock); - page_list_add_tail(pg, &iommu_pt_cleanup_list); - spin_unlock(&iommu_pt_cleanup_lock); -} - -static void deallocate_page_table(struct page_info *pg) -{ - struct amd_iommu_pte *table_vaddr; - unsigned int index, level = PFN_ORDER(pg); - - PFN_ORDER(pg) = 0; - - if ( level <= 1 ) - { - free_amd_iommu_pgtable(pg); - return; - } - - table_vaddr = __map_domain_page(pg); - - for ( index = 0; index < PTE_PER_TABLE_SIZE; index++ ) - { - struct amd_iommu_pte *pde = &table_vaddr[index]; - - if ( pde->mfn && pde->next_level && pde->pr ) - { - /* We do not support skip levels yet */ - ASSERT(pde->next_level == level - 1); - deallocate_next_page_table(mfn_to_page(_mfn(pde->mfn)), - pde->next_level); - } - } - - unmap_domain_page(table_vaddr); - free_amd_iommu_pgtable(pg); -} - -static void deallocate_iommu_page_tables(struct domain *d) -{ - struct domain_iommu *hd = dom_iommu(d); - - spin_lock(&hd->arch.mapping_lock); - if ( hd->arch.amd.root_table ) - { - deallocate_next_page_table(hd->arch.amd.root_table, - hd->arch.amd.paging_mode); - hd->arch.amd.root_table = NULL; - } - spin_unlock(&hd->arch.mapping_lock); -} - - static void amd_iommu_domain_destroy(struct domain *d) { - deallocate_iommu_page_tables(d); - amd_iommu_flush_all_pages(d); + dom_iommu(d)->arch.amd.root_table = NULL; } static int amd_iommu_add_device(u8 devfn, struct pci_dev *pdev) @@ -620,7 +566,6 @@ static const struct iommu_ops __initconstrel _iommu_ops = { .unmap_page = amd_iommu_unmap_page, .iotlb_flush = amd_iommu_flush_iotlb_pages, .iotlb_flush_all = amd_iommu_flush_iotlb_all, - .free_page_table = deallocate_page_table, .reassign_device = reassign_device, .get_device_group_id = amd_iommu_group_id, .enable_x2apic = iov_enable_xt, -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 12:29:42 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 12:29:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zb4-0007Vl-Mk; Mon, 03 Aug 2020 12:29:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zb4-0007NQ-0H for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 12:29:42 +0000 X-Inumbo-ID: f8e8b2b6-d584-11ea-908e-bc764e2007e4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f8e8b2b6-d584-11ea-908e-bc764e2007e4; Mon, 03 Aug 2020 12:29:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uX0pTBNJWLcwNpGyIoW6P7DNZjTBgM7ya3gdLDIudsU=; b=XmlL3CGh0/2nQEakG4aqucnSAh 7xJSbCx82mkqJzXLwoZIc+rc65UHxwebYZw5Ar4UEoASG2lJwYtOcaoCcauyPQCDApQqgsPOU2zg+ AeWxL1eLdrgCiROZaihTufWaBWqk2J6JYJ76HduPtYbghiGzNQwdmluPD2jG20RZJ36o=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zao-0000T2-4s; Mon, 03 Aug 2020 12:29:26 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2Zan-0000zk-TF; Mon, 03 Aug 2020 12:29:26 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v3 08/11] remove remaining uses of iommu_legacy_map/unmap Date: Mon, 3 Aug 2020 13:29:11 +0100 Message-Id: <20200803122914.2259-9-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200803122914.2259-1-paul@xen.org> References: <20200803122914.2259-1-paul@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Tian , Stefano Stabellini , Julien Grall , Jun Nakajima , Wei Liu , Andrew Cooper , Paul Durrant , Ian Jackson , George Dunlap , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant The 'legacy' functions do implicit flushing so amend the callers to do the appropriate flushing. Unfortunately, because of the structure of the P2M code, we cannot remove the per-CPU 'iommu_dont_flush_iotlb' global and the optimization it facilitates. It is now checked directly iommu_iotlb_flush(). Also, it is now declared as bool (rather than bool_t) and setting/clearing it are no longer pointlessly gated on is_iommu_enabled() returning true. (Arguably it is also pointless to gate the call to iommu_iotlb_flush() on that condition - since it is a no-op in that case - but the if clause allows the scope of a stack variable to be restricted). NOTE: The code in memory_add() now fails if the number of pages passed to a single call overflows an unsigned int. I don't believe this will ever happen in practice. Signed-off-by: Paul Durrant --- Cc: Jan Beulich Cc: Andrew Cooper Cc: Wei Liu Cc: "Roger Pau Monné" Cc: George Dunlap Cc: Ian Jackson Cc: Julien Grall Cc: Stefano Stabellini Cc: Jun Nakajima Cc: Kevin Tian v3: - Same as v2; elected to implement batch flushing in the grant table code as a subsequent patch v2: - Shorten the diff (mainly because of a prior patch introducing automatic flush-on-fail into iommu_map() and iommu_unmap()) --- xen/arch/x86/mm.c | 21 +++++++++++++++----- xen/arch/x86/mm/p2m-ept.c | 20 +++++++++++-------- xen/arch/x86/mm/p2m-pt.c | 15 +++++++++++---- xen/arch/x86/mm/p2m.c | 26 ++++++++++++++++++------- xen/arch/x86/x86_64/mm.c | 27 +++++++++++++------------- xen/common/grant_table.c | 34 ++++++++++++++++++++++++--------- xen/common/memory.c | 5 +++-- xen/drivers/passthrough/iommu.c | 25 +----------------------- xen/include/xen/iommu.h | 21 +++++--------------- 9 files changed, 106 insertions(+), 88 deletions(-) diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 638f6bf580..062af1f684 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -2446,10 +2446,16 @@ static int cleanup_page_mappings(struct page_info *page) if ( d && unlikely(need_iommu_pt_sync(d)) && is_pv_domain(d) ) { - int rc2 = iommu_legacy_unmap(d, _dfn(mfn), PAGE_ORDER_4K); + unsigned int flush_flags = 0; + int err; + err = iommu_unmap(d, _dfn(mfn), PAGE_ORDER_4K, 1, &flush_flags); if ( !rc ) - rc = rc2; + rc = err; + + err = iommu_iotlb_flush(d, _dfn(mfn), PAGE_ORDER_4K, 1, flush_flags); + if ( !rc ) + rc = err; } if ( likely(!is_special_page(page)) ) @@ -2971,12 +2977,17 @@ static int _get_page_type(struct page_info *page, unsigned long type, if ( d && unlikely(need_iommu_pt_sync(d)) && is_pv_domain(d) ) { mfn_t mfn = page_to_mfn(page); + dfn_t dfn = _dfn(mfn_x(mfn)); + unsigned int flush_flags = 0; if ( (x & PGT_type_mask) == PGT_writable_page ) - rc = iommu_legacy_unmap(d, _dfn(mfn_x(mfn)), PAGE_ORDER_4K); + rc = iommu_unmap(d, dfn, PAGE_ORDER_4K, 1, &flush_flags); else - rc = iommu_legacy_map(d, _dfn(mfn_x(mfn)), mfn, PAGE_ORDER_4K, - IOMMUF_readable | IOMMUF_writable); + rc = iommu_map(d, dfn, mfn, PAGE_ORDER_4K, 1, + IOMMUF_readable | IOMMUF_writable, &flush_flags); + + if ( !rc ) + rc = iommu_iotlb_flush(d, dfn, PAGE_ORDER_4K, 1, flush_flags); if ( unlikely(rc) ) { diff --git a/xen/arch/x86/mm/p2m-ept.c b/xen/arch/x86/mm/p2m-ept.c index b2ac912cde..e38b0bf95c 100644 --- a/xen/arch/x86/mm/p2m-ept.c +++ b/xen/arch/x86/mm/p2m-ept.c @@ -842,15 +842,19 @@ out: if ( rc == 0 && p2m_is_hostp2m(p2m) && need_modify_vtd_table ) { - if ( iommu_use_hap_pt(d) ) - rc = iommu_iotlb_flush(d, _dfn(gfn), (1u << order), 1, - (iommu_flags ? IOMMU_FLUSHF_added : 0) | - (vtd_pte_present ? IOMMU_FLUSHF_modified - : 0)); - else if ( need_iommu_pt_sync(d) ) + unsigned int flush_flags = 0; + + if ( need_iommu_pt_sync(d) ) rc = iommu_flags ? - iommu_legacy_map(d, _dfn(gfn), mfn, order, iommu_flags) : - iommu_legacy_unmap(d, _dfn(gfn), order); + iommu_map(d, _dfn(gfn), mfn, order, 1, iommu_flags, &flush_flags) : + iommu_unmap(d, _dfn(gfn), order, 1, &flush_flags); + else if ( iommu_use_hap_pt(d) ) + flush_flags = + (iommu_flags ? IOMMU_FLUSHF_added : 0) | + (vtd_pte_present ? IOMMU_FLUSHF_modified : 0); + + if ( !rc ) + rc = iommu_iotlb_flush(d, _dfn(gfn), order, 1, flush_flags); } unmap_domain_page(table); diff --git a/xen/arch/x86/mm/p2m-pt.c b/xen/arch/x86/mm/p2m-pt.c index badb26bc34..3c0901b56c 100644 --- a/xen/arch/x86/mm/p2m-pt.c +++ b/xen/arch/x86/mm/p2m-pt.c @@ -678,10 +678,17 @@ p2m_pt_set_entry(struct p2m_domain *p2m, gfn_t gfn_, mfn_t mfn, if ( need_iommu_pt_sync(p2m->domain) && (iommu_old_flags != iommu_pte_flags || old_mfn != mfn_x(mfn)) ) - rc = iommu_pte_flags - ? iommu_legacy_map(d, _dfn(gfn), mfn, page_order, - iommu_pte_flags) - : iommu_legacy_unmap(d, _dfn(gfn), page_order); + { + unsigned int flush_flags = 0; + + rc = iommu_pte_flags ? + iommu_map(d, _dfn(gfn), mfn, page_order, 1, iommu_pte_flags, + &flush_flags) : + iommu_unmap(d, _dfn(gfn), page_order, 1, &flush_flags); + + if ( !rc ) + rc = iommu_iotlb_flush(d, _dfn(gfn), page_order, 1, flush_flags); + } /* * Free old intermediate tables if necessary. This has to be the diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c index db7bde0230..9f8b9bc5fd 100644 --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@ -1350,10 +1350,15 @@ int set_identity_p2m_entry(struct domain *d, unsigned long gfn_l, if ( !paging_mode_translate(p2m->domain) ) { - if ( !is_iommu_enabled(d) ) - return 0; - return iommu_legacy_map(d, _dfn(gfn_l), _mfn(gfn_l), PAGE_ORDER_4K, - IOMMUF_readable | IOMMUF_writable); + unsigned int flush_flags = 0; + + ret = iommu_map(d, _dfn(gfn_l), _mfn(gfn_l), PAGE_ORDER_4K, 1, + IOMMUF_readable | IOMMUF_writable, &flush_flags); + if ( !ret ) + ret = iommu_iotlb_flush(d, _dfn(gfn_l), PAGE_ORDER_4K, 1, + flush_flags); + + return ret; } gfn_lock(p2m, gfn, 0); @@ -1441,9 +1446,16 @@ int clear_identity_p2m_entry(struct domain *d, unsigned long gfn_l) if ( !paging_mode_translate(d) ) { - if ( !is_iommu_enabled(d) ) - return 0; - return iommu_legacy_unmap(d, _dfn(gfn_l), PAGE_ORDER_4K); + unsigned int flush_flags = 0; + int err; + + ret = iommu_unmap(d, _dfn(gfn_l), PAGE_ORDER_4K, 1, &flush_flags); + + err = iommu_iotlb_flush(d, _dfn(gfn_l), PAGE_ORDER_4K, 1, flush_flags); + if ( !ret ) + ret = err; + + return ret; } gfn_lock(p2m, gfn, 0); diff --git a/xen/arch/x86/x86_64/mm.c b/xen/arch/x86/x86_64/mm.c index 102079a801..02684bcf9d 100644 --- a/xen/arch/x86/x86_64/mm.c +++ b/xen/arch/x86/x86_64/mm.c @@ -1413,21 +1413,22 @@ int memory_add(unsigned long spfn, unsigned long epfn, unsigned int pxm) !iommu_use_hap_pt(hardware_domain) && !need_iommu_pt_sync(hardware_domain) ) { - for ( i = spfn; i < epfn; i++ ) - if ( iommu_legacy_map(hardware_domain, _dfn(i), _mfn(i), - PAGE_ORDER_4K, - IOMMUF_readable | IOMMUF_writable) ) - break; - if ( i != epfn ) - { - while (i-- > old_max) - /* If statement to satisfy __must_check. */ - if ( iommu_legacy_unmap(hardware_domain, _dfn(i), - PAGE_ORDER_4K) ) - continue; + unsigned int flush_flags = 0; + unsigned int n = epfn - spfn; + int rc; + ret = -EOVERFLOW; + if ( spfn + n != epfn ) + goto destroy_m2p; + + rc = iommu_map(hardware_domain, _dfn(i), _mfn(i), + PAGE_ORDER_4K, n, IOMMUF_readable | IOMMUF_writable, + &flush_flags); + if ( !rc ) + rc = iommu_iotlb_flush(hardware_domain, _dfn(i), PAGE_ORDER_4K, n, + flush_flags); + if ( rc ) goto destroy_m2p; - } } /* We can't revert any more */ diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c index 9f0cae52c0..d6526bca12 100644 --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -1225,11 +1225,23 @@ map_grant_ref( kind = IOMMUF_readable; else kind = 0; - if ( kind && iommu_legacy_map(ld, _dfn(mfn_x(mfn)), mfn, 0, kind) ) + if ( kind ) { - double_gt_unlock(lgt, rgt); - rc = GNTST_general_error; - goto undo_out; + dfn_t dfn = _dfn(mfn_x(mfn)); + unsigned int flush_flags = 0; + int err; + + err = iommu_map(ld, dfn, mfn, 0, 1, kind, &flush_flags); + if ( !err ) + err = iommu_iotlb_flush(ld, dfn, 0, 1, flush_flags); + if ( err ) + rc = GNTST_general_error; + + if ( rc != GNTST_okay ) + { + double_gt_unlock(lgt, rgt); + goto undo_out; + } } } @@ -1473,21 +1485,25 @@ unmap_common( if ( rc == GNTST_okay && gnttab_need_iommu_mapping(ld) ) { unsigned int kind; + dfn_t dfn = _dfn(mfn_x(op->mfn)); + unsigned int flush_flags = 0; int err = 0; double_gt_lock(lgt, rgt); kind = mapkind(lgt, rd, op->mfn); if ( !kind ) - err = iommu_legacy_unmap(ld, _dfn(mfn_x(op->mfn)), 0); + err = iommu_unmap(ld, dfn, 0, 1, &flush_flags); else if ( !(kind & MAPKIND_WRITE) ) - err = iommu_legacy_map(ld, _dfn(mfn_x(op->mfn)), op->mfn, 0, - IOMMUF_readable); - - double_gt_unlock(lgt, rgt); + err = iommu_map(ld, dfn, op->mfn, 0, 1, IOMMUF_readable, + &flush_flags); + if ( !err ) + err = iommu_iotlb_flush(ld, dfn, 0, 1, flush_flags); if ( err ) rc = GNTST_general_error; + + double_gt_unlock(lgt, rgt); } /* If just unmapped a writable mapping, mark as dirtied */ diff --git a/xen/common/memory.c b/xen/common/memory.c index 8de334ff10..2891bef57b 100644 --- a/xen/common/memory.c +++ b/xen/common/memory.c @@ -824,8 +824,7 @@ int xenmem_add_to_physmap(struct domain *d, struct xen_add_to_physmap *xatp, xatp->gpfn += start; xatp->size -= start; - if ( is_iommu_enabled(d) ) - this_cpu(iommu_dont_flush_iotlb) = 1; + this_cpu(iommu_dont_flush_iotlb) = true; while ( xatp->size > done ) { @@ -845,6 +844,8 @@ int xenmem_add_to_physmap(struct domain *d, struct xen_add_to_physmap *xatp, } } + this_cpu(iommu_dont_flush_iotlb) = false; + if ( is_iommu_enabled(d) ) { int ret; diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c index 568a4a5661..ab44c332bb 100644 --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -281,18 +281,6 @@ int iommu_map(struct domain *d, dfn_t dfn, mfn_t mfn, return rc; } -int iommu_legacy_map(struct domain *d, dfn_t dfn, mfn_t mfn, - unsigned int page_order, unsigned int flags) -{ - unsigned int flush_flags = 0; - int rc = iommu_map(d, dfn, mfn, page_order, 1, flags, &flush_flags); - - if ( !this_cpu(iommu_dont_flush_iotlb) && !rc ) - rc = iommu_iotlb_flush(d, dfn, (1u << page_order), 1, flush_flags); - - return rc; -} - int iommu_unmap(struct domain *d, dfn_t dfn, unsigned int page_order, unsigned int page_count, unsigned int *flush_flags) { @@ -335,17 +323,6 @@ int iommu_unmap(struct domain *d, dfn_t dfn, unsigned int page_order, return rc; } -int iommu_legacy_unmap(struct domain *d, dfn_t dfn, unsigned int page_order) -{ - unsigned int flush_flags = 0; - int rc = iommu_unmap(d, dfn, page_order, 1, &flush_flags); - - if ( !this_cpu(iommu_dont_flush_iotlb) && ! rc ) - rc = iommu_iotlb_flush(d, dfn, (1u << page_order), 1, flush_flags); - - return rc; -} - int iommu_lookup_page(struct domain *d, dfn_t dfn, mfn_t *mfn, unsigned int *flags) { @@ -364,7 +341,7 @@ int iommu_iotlb_flush(struct domain *d, dfn_t dfn, unsigned int page_order, int rc; if ( !is_iommu_enabled(d) || !hd->platform_ops->iotlb_flush || - !page_count || !flush_flags ) + !page_count || !flush_flags || this_cpu(iommu_dont_flush_iotlb) ) return 0; if ( dfn_eq(dfn, INVALID_DFN) ) diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h index d9c2e764aa..b7e5d3da09 100644 --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -151,16 +151,8 @@ int __must_check iommu_map(struct domain *d, dfn_t dfn, mfn_t mfn, int __must_check iommu_unmap(struct domain *d, dfn_t dfn, unsigned int page_order, unsigned int page_count, unsigned int *flush_flags); - -int __must_check iommu_legacy_map(struct domain *d, dfn_t dfn, mfn_t mfn, - unsigned int page_order, - unsigned int flags); -int __must_check iommu_legacy_unmap(struct domain *d, dfn_t dfn, - unsigned int page_order); - int __must_check iommu_lookup_page(struct domain *d, dfn_t dfn, mfn_t *mfn, unsigned int *flags); - int __must_check iommu_iotlb_flush(struct domain *d, dfn_t dfn, unsigned int page_order, unsigned int page_count, @@ -370,15 +362,12 @@ void iommu_dev_iotlb_flush_timeout(struct domain *d, struct pci_dev *pdev); /* * The purpose of the iommu_dont_flush_iotlb optional cpu flag is to - * avoid unecessary iotlb_flush in the low level IOMMU code. - * - * iommu_map_page/iommu_unmap_page must flush the iotlb but somethimes - * this operation can be really expensive. This flag will be set by the - * caller to notify the low level IOMMU code to avoid the iotlb flushes. - * iommu_iotlb_flush/iommu_iotlb_flush_all will be explicitly called by - * the caller. + * avoid unecessary IOMMU flushing while updating the P2M. + * Setting the value to true will cause iommu_iotlb_flush() to return without + * actually performing a flush. A batch flush must therefore be done by the + * calling code after setting the value back to false. */ -DECLARE_PER_CPU(bool_t, iommu_dont_flush_iotlb); +DECLARE_PER_CPU(bool, iommu_dont_flush_iotlb); extern struct spinlock iommu_pt_cleanup_lock; extern struct page_list_head iommu_pt_cleanup_list; -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 12:29:44 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 12:29:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zb6-0007X2-21; Mon, 03 Aug 2020 12:29:44 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zb5-0007NV-1A for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 12:29:43 +0000 X-Inumbo-ID: f8ddcd10-d584-11ea-af26-12813bfff9fa Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f8ddcd10-d584-11ea-af26-12813bfff9fa; Mon, 03 Aug 2020 12:29:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9CNNemKJGP8SuVWzacpv68au3entEv5YFODLnV2d/u0=; b=sUVmnpcNrI10qLi84QPnqnAnP8 jU5qzZCRv+AQwxe0RbaGxXqpffhJXuIH3x+R2W2LI2ZFcGAakxhT7jnXj7Qi+p28XKlLZLQg/UGju pHWuh425o6RLot6mjQ3nYuQY5ZVgeazKHsD7xHsfbfDQB2ORbgQ//DsYWr8go7a8JLrk=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zap-0000TA-A7; Mon, 03 Aug 2020 12:29:27 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2Zap-0000zk-33; Mon, 03 Aug 2020 12:29:27 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v3 09/11] common/grant_table: batch flush I/O TLB Date: Mon, 3 Aug 2020 13:29:12 +0100 Message-Id: <20200803122914.2259-10-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200803122914.2259-1-paul@xen.org> References: <20200803122914.2259-1-paul@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Paul Durrant , Ian Jackson , George Dunlap , Jan Beulich Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant This patch avoids calling iommu_iotlb_flush() for each individual GNTTABOP and insteads calls iommu_iotlb_flush_all() at the end of the hypercall. This should mean batched map/unmap operations perform better but may be slightly detrimental to singleton performance. Suggested-by: Jan Beulich Signed-off-by: Paul Durrant --- Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich Cc: Julien Grall Cc: Stefano Stabellini Cc: Wei Liu v3: - New in v3 --- xen/common/grant_table.c | 132 ++++++++++++++++++++++++--------------- 1 file changed, 80 insertions(+), 52 deletions(-) diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c index d6526bca12..f382e0be52 100644 --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -979,7 +979,7 @@ static unsigned int mapkind( static void map_grant_ref( - struct gnttab_map_grant_ref *op) + struct gnttab_map_grant_ref *op, unsigned int *flush_flags) { struct domain *ld, *rd, *owner = NULL; struct grant_table *lgt, *rgt; @@ -1228,17 +1228,12 @@ map_grant_ref( if ( kind ) { dfn_t dfn = _dfn(mfn_x(mfn)); - unsigned int flush_flags = 0; int err; - err = iommu_map(ld, dfn, mfn, 0, 1, kind, &flush_flags); - if ( !err ) - err = iommu_iotlb_flush(ld, dfn, 0, 1, flush_flags); + err = iommu_map(ld, dfn, mfn, 0, 1, kind, flush_flags); if ( err ) - rc = GNTST_general_error; - - if ( rc != GNTST_okay ) { + rc = GNTST_general_error; double_gt_unlock(lgt, rgt); goto undo_out; } @@ -1322,6 +1317,8 @@ gnttab_map_grant_ref( { int i; struct gnttab_map_grant_ref op; + unsigned int flush_flags = 0; + int err, rc = 0; for ( i = 0; i < count; i++ ) { @@ -1329,20 +1326,30 @@ gnttab_map_grant_ref( return i; if ( unlikely(__copy_from_guest_offset(&op, uop, i, 1)) ) - return -EFAULT; + { + rc = -EFAULT; + break; + } - map_grant_ref(&op); + map_grant_ref(&op, &flush_flags); if ( unlikely(__copy_to_guest_offset(uop, i, &op, 1)) ) - return -EFAULT; + { + rc = -EFAULT; + break; + } } - return 0; + err = iommu_iotlb_flush_all(current->domain, flush_flags); + if ( !rc ) + rc = err; + + return rc; } static void unmap_common( - struct gnttab_unmap_common *op) + struct gnttab_unmap_common *op, unsigned int *flush_flags) { domid_t dom; struct domain *ld, *rd; @@ -1486,20 +1493,16 @@ unmap_common( { unsigned int kind; dfn_t dfn = _dfn(mfn_x(op->mfn)); - unsigned int flush_flags = 0; int err = 0; double_gt_lock(lgt, rgt); kind = mapkind(lgt, rd, op->mfn); if ( !kind ) - err = iommu_unmap(ld, dfn, 0, 1, &flush_flags); + err = iommu_unmap(ld, dfn, 0, 1, flush_flags); else if ( !(kind & MAPKIND_WRITE) ) err = iommu_map(ld, dfn, op->mfn, 0, 1, IOMMUF_readable, - &flush_flags); - - if ( !err ) - err = iommu_iotlb_flush(ld, dfn, 0, 1, flush_flags); + flush_flags); if ( err ) rc = GNTST_general_error; @@ -1600,8 +1603,8 @@ unmap_common_complete(struct gnttab_unmap_common *op) static void unmap_grant_ref( - struct gnttab_unmap_grant_ref *op, - struct gnttab_unmap_common *common) + struct gnttab_unmap_grant_ref *op, struct gnttab_unmap_common *common, + unsigned int *flush_flags) { common->host_addr = op->host_addr; common->dev_bus_addr = op->dev_bus_addr; @@ -1613,7 +1616,7 @@ unmap_grant_ref( common->rd = NULL; common->mfn = INVALID_MFN; - unmap_common(common); + unmap_common(common, flush_flags); op->status = common->status; } @@ -1622,31 +1625,50 @@ static long gnttab_unmap_grant_ref( XEN_GUEST_HANDLE_PARAM(gnttab_unmap_grant_ref_t) uop, unsigned int count) { - int i, c, partial_done, done = 0; + struct domain *currd = current->domain; struct gnttab_unmap_grant_ref op; struct gnttab_unmap_common common[GNTTAB_UNMAP_BATCH_SIZE]; + int rc = 0; while ( count != 0 ) { + unsigned int i, c, partial_done = 0, done = 0; + unsigned int flush_flags = 0; + int err; + c = min(count, (unsigned int)GNTTAB_UNMAP_BATCH_SIZE); - partial_done = 0; for ( i = 0; i < c; i++ ) { if ( unlikely(__copy_from_guest(&op, uop, 1)) ) - goto fault; - unmap_grant_ref(&op, &common[i]); + { + rc = -EFAULT; + break; + } + + unmap_grant_ref(&op, &common[i], &flush_flags); ++partial_done; + if ( unlikely(__copy_field_to_guest(uop, &op, status)) ) - goto fault; + { + rc = -EFAULT; + break; + } + guest_handle_add_offset(uop, 1); } - gnttab_flush_tlb(current->domain); + gnttab_flush_tlb(currd); + err = iommu_iotlb_flush_all(currd, flush_flags); + if ( !rc ) + rc = err; for ( i = 0; i < partial_done; i++ ) unmap_common_complete(&common[i]); + if ( rc ) + break; + count -= c; done += c; @@ -1654,20 +1676,14 @@ gnttab_unmap_grant_ref( return done; } - return 0; - -fault: - gnttab_flush_tlb(current->domain); - - for ( i = 0; i < partial_done; i++ ) - unmap_common_complete(&common[i]); - return -EFAULT; + return rc; } static void unmap_and_replace( struct gnttab_unmap_and_replace *op, - struct gnttab_unmap_common *common) + struct gnttab_unmap_common *common, + unsigned int *flush_flags) { common->host_addr = op->host_addr; common->new_addr = op->new_addr; @@ -1679,7 +1695,7 @@ unmap_and_replace( common->rd = NULL; common->mfn = INVALID_MFN; - unmap_common(common); + unmap_common(common, flush_flags); op->status = common->status; } @@ -1687,31 +1703,50 @@ static long gnttab_unmap_and_replace( XEN_GUEST_HANDLE_PARAM(gnttab_unmap_and_replace_t) uop, unsigned int count) { - int i, c, partial_done, done = 0; + struct domain *currd = current->domain; struct gnttab_unmap_and_replace op; struct gnttab_unmap_common common[GNTTAB_UNMAP_BATCH_SIZE]; + int rc = 0; while ( count != 0 ) { + unsigned int i, c, partial_done = 0, done = 0; + unsigned int flush_flags = 0; + int err; + c = min(count, (unsigned int)GNTTAB_UNMAP_BATCH_SIZE); - partial_done = 0; for ( i = 0; i < c; i++ ) { if ( unlikely(__copy_from_guest(&op, uop, 1)) ) - goto fault; - unmap_and_replace(&op, &common[i]); + { + rc = -EFAULT; + break; + } + + unmap_and_replace(&op, &common[i], &flush_flags); ++partial_done; + if ( unlikely(__copy_field_to_guest(uop, &op, status)) ) - goto fault; + { + rc = -EFAULT; + break; + } + guest_handle_add_offset(uop, 1); } - gnttab_flush_tlb(current->domain); + gnttab_flush_tlb(currd); + err = iommu_iotlb_flush_all(currd, flush_flags); + if ( !rc ) + rc = err; for ( i = 0; i < partial_done; i++ ) unmap_common_complete(&common[i]); + if ( rc ) + break; + count -= c; done += c; @@ -1719,14 +1754,7 @@ gnttab_unmap_and_replace( return done; } - return 0; - -fault: - gnttab_flush_tlb(current->domain); - - for ( i = 0; i < partial_done; i++ ) - unmap_common_complete(&common[i]); - return -EFAULT; + return rc; } static int -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 12:30:35 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 12:30:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zbv-00007x-DR; Mon, 03 Aug 2020 12:30:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zbt-00007R-IF for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 12:30:33 +0000 X-Inumbo-ID: 1eb3501e-d585-11ea-908e-bc764e2007e4 Received: from 4.mo2.mail-out.ovh.net (unknown [87.98.172.75]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1eb3501e-d585-11ea-908e-bc764e2007e4; Mon, 03 Aug 2020 12:30:31 +0000 (UTC) Received: from player796.ha.ovh.net (unknown [10.108.57.50]) by mo2.mail-out.ovh.net (Postfix) with ESMTP id 7CBEA1DE840 for ; Mon, 3 Aug 2020 14:30:24 +0200 (CEST) Received: from RCM-web4.webmail.mail.ovh.net (85-222-117-222.dynamic.chello.pl [85.222.117.222]) (Authenticated sender: norbert.kaminski@3mdeb.com) by player796.ha.ovh.net (Postfix) with ESMTPSA id 9F70714E43909; Mon, 3 Aug 2020 12:30:18 +0000 (UTC) MIME-Version: 1.0 Date: Mon, 03 Aug 2020 14:30:18 +0200 From: norbert.kaminski@3mdeb.com To: =?UTF-8?Q?Marek_Marczykowski-G=C3=B3recki?= Subject: Re: fwupd support under Xen - firmware updates with the UEFI capsule In-Reply-To: <20200728221645.GO1626@mail-itl> References: <497f1524-b57e-0ea1-5899-62f677bfae91@3mdeb.com> <39be665c-b6c8-23e3-b18b-d38cfe5c1286@suse.com> <20200728221645.GO1626@mail-itl> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <82c27cf6dd6dfac3fb5ce38b335fa997@3mdeb.com> X-Sender: norbert.kaminski@3mdeb.com X-Originating-IP: 85.222.117.222 X-Webmail-UserID: norbert.kaminski@3mdeb.com Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 243194383087999326 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduiedrjeeggdehfecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeggfffhvffujghffgfkgihitgfgsehtkehjtddtreejnecuhfhrohhmpehnohhrsggvrhhtrdhkrghmihhnshhkihesfehmuggvsgdrtghomhenucggtffrrghtthgvrhhnpeevgffgfeffteeivdetffekkeefueevjeejvddvfedtfffhtdeikeffuedvveetgeenucffohhmrghinhepfehmuggvsgdrtghomhenucfkpheptddrtddrtddrtddpkeehrddvvddvrdduudejrddvvddvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepphhlrgihvghrjeeliedrhhgrrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpehnohhrsggvrhhtrdhkrghmihhnshhkihesfehmuggvsgdrtghomhdprhgtphhtthhopeigvghnqdguvghvvghlsehlihhsthhsrdigvghnphhrohhjvggtthdrohhrgh X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Jan Beulich , Maciej Pijanowski , piotr.krol@3mdeb.com, xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 29.07.2020 00:16, Marek Marczykowski-Górecki wrote: > On Tue, Jul 28, 2020 at 10:01:33PM +0100, Andrew Cooper wrote: >> On 28/07/2020 21:00, Jan Beulich wrote: >> > On 28.07.2020 09:41, Norbert Kaminski wrote: >> >> I'm trying to add support for the firmware updates with the UEFI >> >> capsule in >> >> Qubes OS. I've got the troubles with reading ESRT (EFI System >> >> Resource Table) >> >> in the dom0, which is based on the EFI memory map. The EFI_MEMMAP is not >> >> enabled despite the loaded drivers (CONFIG_EFI, CONFIG_EFI_ESRT) and >> >> kernel >> >> cmdline parameters (add_efi_memmap): >> >> >> >> ``` >> >> [    3.451249] efi: EFI_MEMMAP is not enabled. >> >> ``` >> > >> > It is, according to my understanding, a layering violation to expose >> > the EFI memory map to Dom0. It's not supposed to make use of this >> > information in any way. Hence any functionality depending on its use >> > also needs to be implemented in the hypervisor, with Dom0 making a >> > suitable hypercall to access this functionality. (And I find it >> > quite natural to expect that Xen gets involved in an update of the >> > firmware of a system.) >> >> ERST is a table (read only by the looks of things) which is a >> catalogue >> of various bits of firmware in the system, including GUIDs for >> identification, and version information. >> >> It is the kind of data which the hardware domain should have access >> to, >> and AFAICT, behaves just like a static ACPI table. >> >> Presumably it wants to an E820 reserved region so dom0 gets indent >> access, and something in the EFI subsystem needs extending to pass the >> ERST address to dom0. > > I think most (if not all) pieces in Xen are already there - there is > XENPF_firmware_info with XEN_EFW_EFI_INFO + XEN_FW_EFI_CONFIG_TABLE > that gives address of the EFI config table. Linux saves it in > efi_systab_xen.tables (arch/x86/xen/efi.c:xen_efi_probe(). > I haven't figured out yet if it does anything with that information, > but > the content of /sys/firmware/efi/systab suggests it does. > > It seems ESRT driver in Linux uses memmap just for some sanity checks > (if the ESRT points at memory with EFI_MEMORY_RUNTIME and appropriate > type). Perhaps the check (if really necessary) can be added to Xen and > in case of dom0 simply skipped in Linux. > > Norbert, if you're brave enough ;) I would suggests trying the (Linux) > patch below: > > -----8<----- > diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c > index e3d692696583..a2a5ccbb00a8 100644 > --- a/drivers/firmware/efi/esrt.c > +++ b/drivers/firmware/efi/esrt.c > @@ -245,13 +245,14 @@ void __init efi_esrt_init(void) > int rc; > phys_addr_t end; > > - if (!efi_enabled(EFI_MEMMAP)) > + if (!efi_enabled(EFI_MEMMAP) && !efi_enabled(EFI_PARAVIRT)) > return; > > pr_debug("esrt-init: loading.\n"); > if (!esrt_table_exists()) > return; > > + if (!efi_enabled(EFI_PARAVIRT)) { > rc = efi_mem_desc_lookup(efi.esrt, &md); > if (rc < 0 || > (!(md.attribute & EFI_MEMORY_RUNTIME) && > @@ -276,6 +277,7 @@ void __init efi_esrt_init(void) > size, max); > return; > } > + } > > va = early_memremap(efi.esrt, size); > if (!va) { > @@ -331,7 +333,8 @@ void __init efi_esrt_init(void) > > end = esrt_data + size; > pr_info("Reserving ESRT space from %pa to %pa.\n", &esrt_data, &end); > - if (md.type == EFI_BOOT_SERVICES_DATA) > + > + if (!efi_enabled(EFI_PARAVIRT) && md.type == EFI_BOOT_SERVICES_DATA) > efi_mem_reserve(esrt_data, esrt_data_size); > > pr_debug("esrt-init: loaded.\n"); > ----8<----- I've built the kernel with your patch. Unfortunately it doesn't bring expected sysfs directories. We still need some changes here. --- Best Regards, Norbert Kamiński Embedded Systems Engineer GPG key ID: 9E9F90AFE10F466A 3mdeb.com From xen-devel-bounces@lists.xenproject.org Mon Aug 03 12:39:59 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 12:39:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zkw-0000nH-HE; Mon, 03 Aug 2020 12:39:54 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zkv-0000nC-6m for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 12:39:53 +0000 X-Inumbo-ID: 6cf15a90-d586-11ea-af2a-12813bfff9fa Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6cf15a90-d586-11ea-af2a-12813bfff9fa; Mon, 03 Aug 2020 12:39:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zIlKdkXsPhIQfdArjrBSxAJXwBuXmUMve699NvtwDOs=; b=6Na79cBn+4zynf6IKqEcHmKPa0 zN4K+x1W/BcDu3R841FiDdznkQLjJG3FY19r10fSkT0SZyUotyxyetz8bbvlnFGNJFvPUnKUNsbWa exwKFLLFcJXhKMsvM8X636ZP3wkDrCtkH+8uyM1GY2d5XFC1GYRqKMYPSssSw+xjCRbk=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zks-0000ix-3i; Mon, 03 Aug 2020 12:39:50 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2Zar-0000zk-3z; Mon, 03 Aug 2020 12:29:29 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v3 11/11] iommu: stop calling IOMMU page tables 'p2m tables' Date: Mon, 3 Aug 2020 13:29:14 +0100 Message-Id: <20200803122914.2259-12-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200803122914.2259-1-paul@xen.org> References: <20200803122914.2259-1-paul@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Paul Durrant , Kevin Tian , Jan Beulich , Paul Durrant Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant It's confusing and not consistent with the terminology introduced with 'dfn_t'. Just call them IOMMU page tables. Also remove a pointless check of the 'acpi_drhd_units' list in vtd_dump_page_table_level(). If the list is empty then IOMMU mappings would not have been enabled for the domain in the first place. NOTE: All calls to printk() have also been removed from iommu_dump_page_tables(); the implementation specific code is now responsible for all output. The check for the global 'iommu_enabled' has also been replaced by an ASSERT since iommu_dump_page_tables() is not registered as a key handler unless IOMMU mappings are enabled. Signed-off-by: Paul Durrant --- Cc: Jan Beulich Cc: Andrew Cooper Cc: Paul Durrant Cc: Kevin Tian v2: - Moved all output into implementation specific code --- xen/drivers/passthrough/amd/pci_amd_iommu.c | 16 ++++++------- xen/drivers/passthrough/iommu.c | 21 ++++------------- xen/drivers/passthrough/vtd/iommu.c | 26 +++++++++++---------- xen/include/xen/iommu.h | 2 +- 4 files changed, 28 insertions(+), 37 deletions(-) diff --git a/xen/drivers/passthrough/amd/pci_amd_iommu.c b/xen/drivers/passthrough/amd/pci_amd_iommu.c index d79668f948..b3e95cf18e 100644 --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c @@ -491,8 +491,8 @@ static int amd_iommu_group_id(u16 seg, u8 bus, u8 devfn) #include -static void amd_dump_p2m_table_level(struct page_info* pg, int level, - paddr_t gpa, int indent) +static void amd_dump_page_table_level(struct page_info* pg, int level, + paddr_t gpa, int indent) { paddr_t address; struct amd_iommu_pte *table_vaddr; @@ -529,7 +529,7 @@ static void amd_dump_p2m_table_level(struct page_info* pg, int level, address = gpa + amd_offset_level_address(index, level); if ( pde->next_level >= 1 ) - amd_dump_p2m_table_level( + amd_dump_page_table_level( mfn_to_page(_mfn(pde->mfn)), pde->next_level, address, indent + 1); else @@ -542,16 +542,16 @@ static void amd_dump_p2m_table_level(struct page_info* pg, int level, unmap_domain_page(table_vaddr); } -static void amd_dump_p2m_table(struct domain *d) +static void amd_dump_page_tables(struct domain *d) { const struct domain_iommu *hd = dom_iommu(d); if ( !hd->arch.amd.root_table ) return; - printk("p2m table has %d levels\n", hd->arch.amd.paging_mode); - amd_dump_p2m_table_level(hd->arch.amd.root_table, - hd->arch.amd.paging_mode, 0, 0); + printk("AMD IOMMU table has %d levels\n", hd->arch.amd.paging_mode); + amd_dump_page_table_level(hd->arch.amd.root_table, + hd->arch.amd.paging_mode, 0, 0); } static const struct iommu_ops __initconstrel _iommu_ops = { @@ -578,7 +578,7 @@ static const struct iommu_ops __initconstrel _iommu_ops = { .suspend = amd_iommu_suspend, .resume = amd_iommu_resume, .crash_shutdown = amd_iommu_crash_shutdown, - .dump_p2m_table = amd_dump_p2m_table, + .dump_page_tables = amd_dump_page_tables, }; static const struct iommu_init_ops __initconstrel _iommu_init_ops = { diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c index 7464f10d1c..0f468379e1 100644 --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -22,7 +22,7 @@ #include #include -static void iommu_dump_p2m_table(unsigned char key); +static void iommu_dump_page_tables(unsigned char key); unsigned int __read_mostly iommu_dev_iotlb_timeout = 1000; integer_param("iommu_dev_iotlb_timeout", iommu_dev_iotlb_timeout); @@ -212,7 +212,7 @@ void __hwdom_init iommu_hwdom_init(struct domain *d) if ( !is_iommu_enabled(d) ) return; - register_keyhandler('o', &iommu_dump_p2m_table, "dump iommu p2m table", 0); + register_keyhandler('o', &iommu_dump_page_tables, "dump iommu page tables", 0); hd->platform_ops->hwdom_init(d); } @@ -533,16 +533,12 @@ bool_t iommu_has_feature(struct domain *d, enum iommu_feature feature) return is_iommu_enabled(d) && test_bit(feature, dom_iommu(d)->features); } -static void iommu_dump_p2m_table(unsigned char key) +static void iommu_dump_page_tables(unsigned char key) { struct domain *d; const struct iommu_ops *ops; - if ( !iommu_enabled ) - { - printk("IOMMU not enabled!\n"); - return; - } + ASSERT(iommu_enabled); ops = iommu_get_ops(); @@ -553,14 +549,7 @@ static void iommu_dump_p2m_table(unsigned char key) if ( is_hardware_domain(d) || !is_iommu_enabled(d) ) continue; - if ( iommu_use_hap_pt(d) ) - { - printk("\ndomain%d IOMMU p2m table shared with MMU: \n", d->domain_id); - continue; - } - - printk("\ndomain%d IOMMU p2m table: \n", d->domain_id); - ops->dump_p2m_table(d); + ops->dump_page_tables(d); } rcu_read_unlock(&domlist_read_lock); diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c index a532d9e88c..f8da4fe0e7 100644 --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -2582,8 +2582,8 @@ static void vtd_resume(void) } } -static void vtd_dump_p2m_table_level(paddr_t pt_maddr, int level, paddr_t gpa, - int indent) +static void vtd_dump_page_table_level(paddr_t pt_maddr, int level, paddr_t gpa, + int indent) { paddr_t address; int i; @@ -2612,8 +2612,8 @@ static void vtd_dump_p2m_table_level(paddr_t pt_maddr, int level, paddr_t gpa, address = gpa + offset_level_address(i, level); if ( next_level >= 1 ) - vtd_dump_p2m_table_level(dma_pte_addr(*pte), next_level, - address, indent + 1); + vtd_dump_page_table_level(dma_pte_addr(*pte), next_level, + address, indent + 1); else printk("%*sdfn: %08lx mfn: %08lx\n", indent, "", @@ -2624,17 +2624,19 @@ static void vtd_dump_p2m_table_level(paddr_t pt_maddr, int level, paddr_t gpa, unmap_vtd_domain_page(pt_vaddr); } -static void vtd_dump_p2m_table(struct domain *d) +static void vtd_dump_page_tables(struct domain *d) { - const struct domain_iommu *hd; + const struct domain_iommu *hd = dom_iommu(d); - if ( list_empty(&acpi_drhd_units) ) + if ( iommu_use_hap_pt(d) ) + { + printk("VT-D sharing EPT table\n"); return; + } - hd = dom_iommu(d); - printk("p2m table has %d levels\n", agaw_to_level(hd->arch.vtd.agaw)); - vtd_dump_p2m_table_level(hd->arch.vtd.pgd_maddr, - agaw_to_level(hd->arch.vtd.agaw), 0, 0); + printk("VT-D table has %d levels\n", agaw_to_level(hd->arch.vtd.agaw)); + vtd_dump_page_table_level(hd->arch.vtd.pgd_maddr, + agaw_to_level(hd->arch.vtd.agaw), 0, 0); } static int __init intel_iommu_quarantine_init(struct domain *d) @@ -2734,7 +2736,7 @@ static struct iommu_ops __initdata vtd_ops = { .iotlb_flush = iommu_flush_iotlb_pages, .iotlb_flush_all = iommu_flush_iotlb_all, .get_reserved_device_memory = intel_iommu_get_reserved_device_memory, - .dump_p2m_table = vtd_dump_p2m_table, + .dump_page_tables = vtd_dump_page_tables, }; const struct iommu_init_ops __initconstrel intel_iommu_init_ops = { diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h index 1f25d2082f..23e884f54b 100644 --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -277,7 +277,7 @@ struct iommu_ops { unsigned int flush_flags); int __must_check (*iotlb_flush_all)(struct domain *d); int (*get_reserved_device_memory)(iommu_grdm_t *, void *); - void (*dump_p2m_table)(struct domain *d); + void (*dump_page_tables)(struct domain *d); #ifdef CONFIG_HAS_DEVICE_TREE /* -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 12:40:00 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 12:40:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zl0-0000nX-Pu; Mon, 03 Aug 2020 12:39:58 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zkz-0000nC-Vm for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 12:39:58 +0000 X-Inumbo-ID: 6d3f36ca-d586-11ea-af2a-12813bfff9fa Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6d3f36ca-d586-11ea-af2a-12813bfff9fa; Mon, 03 Aug 2020 12:39:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=JvpjW2yuqqsP9Nf9RqSvKwq47T2XEc66z0tnFgkOJgM=; b=jrw15mUT/SAFnLYs6hd81iN9Iu oMY4mnsYs4dNfQypRlA49iElqMBBK/3MqyTfy2LI6YqeCh0hZOHFtDdOlOzoZtSNii9LE8d+ShohJ /MmzXQOnKO29Pi+u1ScFIt0NkBeltiNnNy6HYcJ3GSpacxao6s3mTL+sM7xx3fItXkgw=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zks-0000iz-6b; Mon, 03 Aug 2020 12:39:50 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2Zaq-0000zk-6Q; Mon, 03 Aug 2020 12:29:28 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v3 10/11] iommu: remove the share_p2m operation Date: Mon, 3 Aug 2020 13:29:13 +0100 Message-Id: <20200803122914.2259-11-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200803122914.2259-1-paul@xen.org> References: <20200803122914.2259-1-paul@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Tian , Wei Liu , Andrew Cooper , Paul Durrant , George Dunlap , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant Sharing of HAP tables is now VT-d specific so the operation is never defined for AMD IOMMU any more. There's also no need to pro-actively set vtd.pgd_maddr when using shared EPT as it is straightforward to simply define a helper function to return the appropriate value in the shared and non-shared cases. Signed-off-by: Paul Durrant --- Cc: Jan Beulich Cc: Andrew Cooper Cc: George Dunlap Cc: Wei Liu Cc: "Roger Pau Monné" Cc: Kevin Tian v2: - Put the PGD level adjust into the helper function too, since it is irrelevant in the shared EPT case --- xen/arch/x86/mm/p2m.c | 3 - xen/drivers/passthrough/iommu.c | 8 --- xen/drivers/passthrough/vtd/iommu.c | 90 ++++++++++++++++------------- xen/include/xen/iommu.h | 3 - 4 files changed, 50 insertions(+), 54 deletions(-) diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c index 9f8b9bc5fd..3bd8d83d23 100644 --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@ -726,9 +726,6 @@ int p2m_alloc_table(struct p2m_domain *p2m) p2m->phys_table = pagetable_from_mfn(top_mfn); - if ( hap_enabled(d) ) - iommu_share_p2m_table(d); - p2m_unlock(p2m); return 0; } diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c index ab44c332bb..7464f10d1c 100644 --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -498,14 +498,6 @@ int iommu_do_domctl( return ret; } -void iommu_share_p2m_table(struct domain* d) -{ - ASSERT(hap_enabled(d)); - - if ( iommu_use_hap_pt(d) ) - iommu_get_ops()->share_p2m(d); -} - void iommu_crash_shutdown(void) { if ( !iommu_crash_disable ) diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c index 68cf0e535a..a532d9e88c 100644 --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -318,6 +318,48 @@ static u64 addr_to_dma_page_maddr(struct domain *domain, u64 addr, int alloc) return pte_maddr; } +static uint64_t domain_pgd_maddr(struct domain *d, struct vtd_iommu *iommu) +{ + struct domain_iommu *hd = dom_iommu(d); + uint64_t pgd_maddr; + unsigned int agaw; + + ASSERT(spin_is_locked(&hd->arch.mapping_lock)); + + if ( iommu_use_hap_pt(d) ) + { + mfn_t pgd_mfn = + pagetable_get_mfn(p2m_get_pagetable(p2m_get_hostp2m(d))); + + return pagetable_get_paddr(pagetable_from_mfn(pgd_mfn)); + } + + if ( !hd->arch.vtd.pgd_maddr ) + { + addr_to_dma_page_maddr(d, 0, 1); + + if ( !hd->arch.vtd.pgd_maddr ) + return 0; + } + + pgd_maddr = hd->arch.vtd.pgd_maddr; + + /* Skip top levels of page tables for 2- and 3-level DRHDs. */ + for ( agaw = level_to_agaw(4); + agaw != level_to_agaw(iommu->nr_pt_levels); + agaw-- ) + { + struct dma_pte *p = map_vtd_domain_page(pgd_maddr); + + pgd_maddr = dma_pte_addr(*p); + unmap_vtd_domain_page(p); + if ( !pgd_maddr ) + return 0; + } + + return pgd_maddr; +} + static void iommu_flush_write_buffer(struct vtd_iommu *iommu) { u32 val; @@ -1286,7 +1328,7 @@ int domain_context_mapping_one( struct context_entry *context, *context_entries; u64 maddr, pgd_maddr; u16 seg = iommu->drhd->segment; - int agaw, rc, ret; + int rc, ret; bool_t flush_dev_iotlb; ASSERT(pcidevs_locked()); @@ -1340,37 +1382,18 @@ int domain_context_mapping_one( if ( iommu_hwdom_passthrough && is_hardware_domain(domain) ) { context_set_translation_type(*context, CONTEXT_TT_PASS_THRU); - agaw = level_to_agaw(iommu->nr_pt_levels); } else { spin_lock(&hd->arch.mapping_lock); - /* Ensure we have pagetables allocated down to leaf PTE. */ - if ( hd->arch.vtd.pgd_maddr == 0 ) + pgd_maddr = domain_pgd_maddr(domain, iommu); + if ( !pgd_maddr ) { - addr_to_dma_page_maddr(domain, 0, 1); - if ( hd->arch.vtd.pgd_maddr == 0 ) - { - nomem: - spin_unlock(&hd->arch.mapping_lock); - spin_unlock(&iommu->lock); - unmap_vtd_domain_page(context_entries); - return -ENOMEM; - } - } - - /* Skip top levels of page tables for 2- and 3-level DRHDs. */ - pgd_maddr = hd->arch.vtd.pgd_maddr; - for ( agaw = level_to_agaw(4); - agaw != level_to_agaw(iommu->nr_pt_levels); - agaw-- ) - { - struct dma_pte *p = map_vtd_domain_page(pgd_maddr); - pgd_maddr = dma_pte_addr(*p); - unmap_vtd_domain_page(p); - if ( pgd_maddr == 0 ) - goto nomem; + spin_unlock(&hd->arch.mapping_lock); + spin_unlock(&iommu->lock); + unmap_vtd_domain_page(context_entries); + return -ENOMEM; } context_set_address_root(*context, pgd_maddr); @@ -1389,7 +1412,7 @@ int domain_context_mapping_one( return -EFAULT; } - context_set_address_width(*context, agaw); + context_set_address_width(*context, level_to_agaw(iommu->nr_pt_levels)); context_set_fault_enable(*context); context_set_present(*context); iommu_sync_cache(context, sizeof(struct context_entry)); @@ -1848,18 +1871,6 @@ static int __init vtd_ept_page_compatible(struct vtd_iommu *iommu) (ept_has_1gb(ept_cap) && opt_hap_1gb) <= cap_sps_1gb(vtd_cap); } -/* - * set VT-d page table directory to EPT table if allowed - */ -static void iommu_set_pgd(struct domain *d) -{ - mfn_t pgd_mfn; - - pgd_mfn = pagetable_get_mfn(p2m_get_pagetable(p2m_get_hostp2m(d))); - dom_iommu(d)->arch.vtd.pgd_maddr = - pagetable_get_paddr(pagetable_from_mfn(pgd_mfn)); -} - static int rmrr_identity_mapping(struct domain *d, bool_t map, const struct acpi_rmrr_unit *rmrr, u32 flag) @@ -2719,7 +2730,6 @@ static struct iommu_ops __initdata vtd_ops = { .adjust_irq_affinities = adjust_vtd_irq_affinities, .suspend = vtd_suspend, .resume = vtd_resume, - .share_p2m = iommu_set_pgd, .crash_shutdown = vtd_crash_shutdown, .iotlb_flush = iommu_flush_iotlb_pages, .iotlb_flush_all = iommu_flush_iotlb_all, diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h index b7e5d3da09..1f25d2082f 100644 --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -271,7 +271,6 @@ struct iommu_ops { int __must_check (*suspend)(void); void (*resume)(void); - void (*share_p2m)(struct domain *d); void (*crash_shutdown)(void); int __must_check (*iotlb_flush)(struct domain *d, dfn_t dfn, unsigned long page_count, @@ -348,8 +347,6 @@ void iommu_resume(void); void iommu_crash_shutdown(void); int iommu_get_reserved_device_memory(iommu_grdm_t *, void *); -void iommu_share_p2m_table(struct domain *d); - #ifdef CONFIG_HAS_PCI int iommu_do_pci_domctl(struct xen_domctl *, struct domain *d, XEN_GUEST_HANDLE_PARAM(xen_domctl_t)); -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 12:49:43 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 12:49:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2ZuQ-0001oi-2T; Mon, 03 Aug 2020 12:49:42 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2ZuO-0001oY-Mk for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 12:49:40 +0000 X-Inumbo-ID: cb1d6432-d587-11ea-af2b-12813bfff9fa Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id cb1d6432-d587-11ea-af2b-12813bfff9fa; Mon, 03 Aug 2020 12:49:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=TpRalkvkG38JtEdNhqPS3RNesiK5+8RoUBFVAeIBPhI=; b=HcGqnvkm6tlHw+zgLd1/kNuEYB SI5YhlrENiOZLAl0wm0EdzhX20S1VZ6gneUaKlARLRWqKGPwR+O1EyytYJsk7B4B/k72q6HWW4Kwl p4ziJymIfIxP8eBjRnxqLZgmRsjlPmUeAIgof9xUH1woX0+s4wTwoGCsa+8ouZR9STsQ=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2ZuN-0000xA-0f; Mon, 03 Aug 2020 12:49:39 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2ZuM-0002Mv-PT; Mon, 03 Aug 2020 12:49:38 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v2 4/4] tools/hotplug: modify set_mtu() to inform the frontend via xenstore Date: Mon, 3 Aug 2020 13:49:31 +0100 Message-Id: <20200803124931.2678-5-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200803124931.2678-1-paul@xen.org> References: <20200803124931.2678-1-paul@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Paul Durrant , Ian Jackson , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant set_mtu() currently sets the backend vif MTU but does not inform the frontend what it is. This patch adds code to write the MTU into a xenstore node. See netif.h for a specification of the node. NOTE: There is also a small modification replacing '$mtu' with '${mtu}' for style consistency. Signed-off-by: Paul Durrant --- Cc: Ian Jackson Cc: Wei Liu --- tools/hotplug/Linux/vif-bridge | 2 +- tools/hotplug/Linux/xen-network-common.sh | 14 +++++++++++++- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/tools/hotplug/Linux/vif-bridge b/tools/hotplug/Linux/vif-bridge index e1d7c49788..b99cc82a21 100644 --- a/tools/hotplug/Linux/vif-bridge +++ b/tools/hotplug/Linux/vif-bridge @@ -81,7 +81,7 @@ case "$command" in ;& online) setup_virtual_bridge_port "$dev" - set_mtu "$bridge" "$dev" + set_mtu "$bridge" "$dev" "$type_if" add_to_bridge "$bridge" "$dev" ;; remove) diff --git a/tools/hotplug/Linux/xen-network-common.sh b/tools/hotplug/Linux/xen-network-common.sh index 37e71cfa9c..24fc42d9cf 100644 --- a/tools/hotplug/Linux/xen-network-common.sh +++ b/tools/hotplug/Linux/xen-network-common.sh @@ -164,9 +164,21 @@ remove_from_bridge () { set_mtu () { local bridge=$1 local dev=$2 + local type_if=$3 + mtu="`ip link show dev ${bridge}| awk '/mtu/ { print $5 }'`" if [ -n "$mtu" ] && [ "$mtu" -gt 0 ] then - ip link set dev ${dev} mtu $mtu || : + ip link set dev ${dev} mtu ${mtu} || : + fi + + if [ ${type_if} = vif ] + then + dev_=${dev#vif} + domid=${dev_%.*} + devid=${dev_#*.} + + XENBUS_PATH="/local/domain/$domid/device/vif/$devid" + xenstore_write "$XENBUS_PATH/mtu" ${mtu} fi } -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 12:49:43 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 12:49:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2ZuL-0001oO-Qe; Mon, 03 Aug 2020 12:49:37 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2ZuK-0001oJ-LR for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 12:49:36 +0000 X-Inumbo-ID: c8e6ec4c-d587-11ea-908e-bc764e2007e4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c8e6ec4c-d587-11ea-908e-bc764e2007e4; Mon, 03 Aug 2020 12:49:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date: Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1Eiqy6Tzja3w0Of2qRJ6KsP0UfcjoS8ObDUmvaODP7Y=; b=6QYQYPkty4tJr3pCmRzGs+BQR4 Zl3naNLj4fyx9Oe0DbRxy9CU/se8GAa3Zwpe2A/jwvMMdkcHSFxZDtpj/FPymTsVkkHZvL/CcO6MT ddTpucBIQcmjbMKtSBcowlyOysc0mtqzqzp3xv45Qd7Ia9eL+i31BOcC9k9n0c+HgMGk=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2ZuJ-0000wl-4l; Mon, 03 Aug 2020 12:49:35 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2ZuI-0002Mv-Pb; Mon, 03 Aug 2020 12:49:34 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v2 0/4] tools: propagate bridge MTU to vif frontends Date: Mon, 3 Aug 2020 13:49:27 +0100 Message-Id: <20200803124931.2678-1-paul@xen.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Paul Durrant , Ian Jackson , George Dunlap , Jan Beulich Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant Paul Durrant (4): tools/hotplug: add remove_from_bridge() and improve debug output tools/hotplug: combine add/online and remove/offline in vif-bridge... public/io/netif: specify MTU override node tools/hotplug: modify set_mtu() to inform the frontend via xenstore docs/misc/xenstore-paths.pandoc | 3 ++ tools/hotplug/Linux/vif-bridge | 20 +++------ tools/hotplug/Linux/xen-network-common.sh | 51 +++++++++++++++++++---- xen/include/public/io/netif.h | 12 ++++++ 4 files changed, 63 insertions(+), 23 deletions(-) --- Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich Cc: Julien Grall Cc: Stefano Stabellini Cc: Wei Liu -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 12:49:43 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 12:49:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2ZuR-0001oz-B2; Mon, 03 Aug 2020 12:49:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2ZuP-0001oJ-KB for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 12:49:41 +0000 X-Inumbo-ID: c94bbfc8-d587-11ea-908e-bc764e2007e4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c94bbfc8-d587-11ea-908e-bc764e2007e4; Mon, 03 Aug 2020 12:49:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fEecjANlWh3hBTz/ieGtixPqvrZoBJyua6jWfk3Vf10=; b=etQRioOuZx5mSrQGtdIYJdZ0Yc ZEVxz5N3UUHLW/QPuNGa/Jorna3ZqR7Hwj3mwB5CcspH7meQgXSd7H/LTsHrqsMkc6uaQkP24+Mpf E1XkZpIWjBvJCHKM06adVaIfBZLO9RqRHMkbY8UkjB8DSItessioIBxTbwYNM3JyJJLA=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2ZuJ-0000wp-Tp; Mon, 03 Aug 2020 12:49:35 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2ZuJ-0002Mv-KR; Mon, 03 Aug 2020 12:49:35 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v2 1/4] tools/hotplug: add remove_from_bridge() and improve debug output Date: Mon, 3 Aug 2020 13:49:28 +0100 Message-Id: <20200803124931.2678-2-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200803124931.2678-1-paul@xen.org> References: <20200803124931.2678-1-paul@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Paul Durrant , Ian Jackson , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant This patch adds a remove_from_bridge() function into xen-network-common.sh to partner with the existing add_to_bridge() function. The code in add_to_bridge() is also slightly re-arranged to avoid duplication calls of 'ip link'. Both add_to_bridge() and remove_from_bridge() will check if their bridge manipulation operations are necessary and emit a log message if they are not. NOTE: A call to remove_from_bridge() will be added by a subsequent patch. Signed-off-by: Paul Durrant --- Cc: Ian Jackson Cc: Wei Liu --- tools/hotplug/Linux/xen-network-common.sh | 37 ++++++++++++++++++----- 1 file changed, 29 insertions(+), 8 deletions(-) diff --git a/tools/hotplug/Linux/xen-network-common.sh b/tools/hotplug/Linux/xen-network-common.sh index 8dd3a62068..37e71cfa9c 100644 --- a/tools/hotplug/Linux/xen-network-common.sh +++ b/tools/hotplug/Linux/xen-network-common.sh @@ -126,19 +126,40 @@ add_to_bridge () { local bridge=$1 local dev=$2 - # Don't add $dev to $bridge if it's already on a bridge. - if [ -e "/sys/class/net/${bridge}/brif/${dev}" ]; then - ip link set dev ${dev} up || true - return - fi - if which brctl >&/dev/null; then - brctl addif ${bridge} ${dev} + # Don't add $dev to $bridge if it's already on the bridge. + if [ ! -e "/sys/class/net/${bridge}/brif/${dev}" ]; then + log debug "adding $dev to bridge $bridge" + if which brctl >&/dev/null; then + brctl addif ${bridge} ${dev} + else + ip link set ${dev} master ${bridge} + fi else - ip link set ${dev} master ${bridge} + log debug "$dev already on bridge $bridge" fi + ip link set dev ${dev} up } +remove_from_bridge () { + local bridge=$1 + local dev=$2 + + ip link set dev ${dev} down || : + + # Don't remove $dev from $bridge if it's not on the bridge. + if [ -e "/sys/class/net/${bridge}/brif/${dev}" ]; then + log debug "removing $dev from bridge $bridge" + if which brctl >&/dev/null; then + brctl delif ${bridge} ${dev} + else + ip link set ${dev} nomaster + fi + else + log debug "$dev not on bridge $bridge" + fi +} + # Usage: set_mtu bridge dev set_mtu () { local bridge=$1 -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 12:49:47 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 12:49:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2ZuV-0001r6-NL; Mon, 03 Aug 2020 12:49:47 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2ZuU-0001oJ-KD for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 12:49:46 +0000 X-Inumbo-ID: c94bbfc9-d587-11ea-908e-bc764e2007e4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c94bbfc9-d587-11ea-908e-bc764e2007e4; Mon, 03 Aug 2020 12:49:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kR8KOrJwsxDE/ONPFOt3nY9mFnEziImu/LnFUCfqeYk=; b=ZJ+YGwogR5jrHLs2CgiehNTwnw COemTsnajKTmERoLv9bCRMdHA1p4sBqBeZJH4w2ewDSrlQDb4vMSsN2NBJDOySHSFjZ8GIkbkppFA 934tKxQUzzOfZL8Si5zYm6ODa2bIqWOPvg2C9LsRhGT1a7F85sZO546cKptlYuwLLGT0=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2ZuK-0000wv-Nq; Mon, 03 Aug 2020 12:49:36 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2ZuK-0002Mv-GL; Mon, 03 Aug 2020 12:49:36 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v2 2/4] tools/hotplug: combine add/online and remove/offline in vif-bridge... Date: Mon, 3 Aug 2020 13:49:29 +0100 Message-Id: <20200803124931.2678-3-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200803124931.2678-1-paul@xen.org> References: <20200803124931.2678-1-paul@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Paul Durrant , Ian Jackson , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant ... as they are in vif-route. The script is invoked with online/offline for vifs and add/remove for taps. The operations that are necessary, however, are the same in both cases. This patch therefore combines the cases. The open-coded bridge removal code is also replaced with call to remove_from_bridge(). Signed-off-by: Paul Durrant --- Cc: Ian Jackson Cc: Wei Liu --- tools/hotplug/Linux/vif-bridge | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/tools/hotplug/Linux/vif-bridge b/tools/hotplug/Linux/vif-bridge index e722090ca8..e1d7c49788 100644 --- a/tools/hotplug/Linux/vif-bridge +++ b/tools/hotplug/Linux/vif-bridge @@ -77,25 +77,17 @@ then fi case "$command" in + add) + ;& online) setup_virtual_bridge_port "$dev" set_mtu "$bridge" "$dev" add_to_bridge "$bridge" "$dev" ;; - + remove) + ;& offline) - if which brctl >&/dev/null; then - do_without_error brctl delif "$bridge" "$dev" - else - do_without_error ip link set "$dev" nomaster - fi - do_without_error ifconfig "$dev" down - ;; - - add) - setup_virtual_bridge_port "$dev" - set_mtu "$bridge" "$dev" - add_to_bridge "$bridge" "$dev" + remove_from_bridge "$bridge" "$dev" ;; esac -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 12:49:53 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 12:49:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2Zua-0001st-WD; Mon, 03 Aug 2020 12:49:53 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2ZuZ-0001oJ-KL for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 12:49:51 +0000 X-Inumbo-ID: cac696e8-d587-11ea-908e-bc764e2007e4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cac696e8-d587-11ea-908e-bc764e2007e4; Mon, 03 Aug 2020 12:49:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZlyGB/IJYGIn5IH/TrwY8/sEiVYZi4FF/kqtp/gyRxw=; b=hJC6+ih5zJRfQVFW6Xs+gmmWiq YJhFI9oAmkTlJ3xCbgIfFxXloH8CAPaa9IZvw7n+mgKWcE9optOJDA4EKcSC6R8CaVBpWJG+6GFA9 jxDVxDOYCpOSnTvDw1YveJc2AeAj2n80rk8zPkBxHrvglE/STnWKYVt/9dikQ/bDqeXg=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2ZuM-0000x6-5e; Mon, 03 Aug 2020 12:49:38 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2ZuL-0002Mv-TE; Mon, 03 Aug 2020 12:49:38 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v2 3/4] public/io/netif: specify MTU override node Date: Mon, 3 Aug 2020 13:49:30 +0100 Message-Id: <20200803124931.2678-4-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200803124931.2678-1-paul@xen.org> References: <20200803124931.2678-1-paul@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Paul Durrant , Ian Jackson , George Dunlap , Jan Beulich Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant There is currently no documentation to state what MTU a frontend should adertise to its network stack. It has however long been assumed that the default value of 1500 is correct. This patch specifies a mechanism to allow the tools to set the MTU via a xenstore node in the frontend area and states that the absence of that node means the frontend should assume an MTU of 1500 octets. NOTE: The Windows PV frontend has used an MTU sampled from the xenstore node specified in this patch. Signed-off-by: Paul Durrant Reviewed-by: Juergen Gross --- Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich Cc: Julien Grall Cc: Stefano Stabellini Cc: Wei Liu v2: - Add a note in xenstore-paths highlighting the new xenstore node --- docs/misc/xenstore-paths.pandoc | 3 +++ xen/include/public/io/netif.h | 12 ++++++++++++ 2 files changed, 15 insertions(+) diff --git a/docs/misc/xenstore-paths.pandoc b/docs/misc/xenstore-paths.pandoc index 766e8008dc..5cd5c8a3b9 100644 --- a/docs/misc/xenstore-paths.pandoc +++ b/docs/misc/xenstore-paths.pandoc @@ -298,6 +298,9 @@ A virtual keyboard device frontend. Described by A virtual network device frontend. Described by [xen/include/public/io/netif.h][NETIF] +NOTE: ~/device/vif/$DEVID/mtu can be used to inform the frontend of an + increased MTU. (The default MTU is 1500 octets). + #### ~/device/vscsi/$DEVID/* [] A virtual scsi device frontend. Described by diff --git a/xen/include/public/io/netif.h b/xen/include/public/io/netif.h index 9fcf91a2fe..00dd258712 100644 --- a/xen/include/public/io/netif.h +++ b/xen/include/public/io/netif.h @@ -204,6 +204,18 @@ * present). */ +/* + * MTU + * === + * + * The toolstack may set a value of MTU for the frontend by setting the + * /local/domain//device/vif//mtu node with the MTU value in + * octets. If this node is absent the frontend should assume an MTU value + * of 1500 octets. A frontend is also at liberty to ignore this value so + * it is only suitable for informing the frontend that a packet payload + * >1500 octets is permitted. + */ + /* * Hash types * ========== -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 13:18:21 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 13:18:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2aM0-0004nn-D3; Mon, 03 Aug 2020 13:18:12 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2aLy-0004ni-SC for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 13:18:10 +0000 X-Inumbo-ID: c67f5a8a-d58b-11ea-af2f-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c67f5a8a-d58b-11ea-af2f-12813bfff9fa; Mon, 03 Aug 2020 13:18:10 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 77287ADDF; Mon, 3 Aug 2020 13:18:24 +0000 (UTC) Subject: Re: RESCHEDULED Call for agenda items for Community Call, August 13 @ 15:00 UTC From: Jan Beulich To: George Dunlap References: <1E023F6E-0E3C-4CD5-A074-7BF62635E123@citrix.com> <40615946-FF55-48DB-91FB-58DD603FDD69@citrix.com> <9bfef1bf-31a7-1c95-60fa-2ca665942fda@suse.com> <047B12C2-71AA-459F-853C-DF1CD040D6C1@citrix.com> <37d5e973-7645-d4eb-7bd6-f8d3226d7cb5@suse.com> Message-ID: Date: Mon, 3 Aug 2020 15:18:08 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <37d5e973-7645-d4eb-7bd6-f8d3226d7cb5@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 31.07.2020 14:35, Jan Beulich wrote: > On 31.07.2020 14:27, George Dunlap wrote: >>> On Jul 31, 2020, at 1:25 PM, Jan Beulich wrote: >>> On 30.07.2020 17:41, George Dunlap wrote: >>>>> On Jul 30, 2020, at 4:17 PM, George Dunlap wrote: >>>>> >>>>> Hey all, >>>>> >>>>> The community call is scheduled for next week, 6 August. I, however, will be on PTO that week; I propose rescheduling it for the following week, 13 August, at the same time. >>>>> >>>>> The proposed agenda is in ZZZ and you can edit to add items. Alternatively, you can reply to this mail directly. >>>> >>>> Sorry, in all my manual templating I seem to have missed this one. Here’s the URL: >>>> >>>> https://cryptpad.fr/pad/#/3/pad/edit/9c58993a08fe97451f0a5b6c8bb906b1/ >>> >>> I get "This link does not give you access to the document". Maybe a >>> permissions problem? I've meant to add a "minimum toolchain versions" >>> topic ... >> >> Try this one? >> >> https://cryptpad.fr/pad/#/2/pad/edit/VlLdjiw7iBm0R-efOMyCY+Ks/ > > Ah yes, this one works. Thanks. And over the weekend I realized that the week of the 13th I'm going to be on PTO, so very likely won't be able to make the call. Not sure what to suggest you do with the topic ... Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 03 13:50:21 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 13:50:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2aqk-0007NW-Tl; Mon, 03 Aug 2020 13:49:58 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2aqj-0007NC-SO for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 13:49:57 +0000 X-Inumbo-ID: 33471762-d590-11ea-af32-12813bfff9fa Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 33471762-d590-11ea-af32-12813bfff9fa; Mon, 03 Aug 2020 13:49:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=LjsLlS0Fw7GKt5LpDyw/hAGuEg8lNCrCim8gUGx4brU=; b=I8BrKgP6+cO4ObIPy6sFXVcvT kn75LmYmAiCtA00cxz1hsY6/DrWwdC9JTze/bEXVzmBfykbptOxnR/Xl7xh0dBBuiV9RetTUUvPsm e/cOQ0bs1ygq0RXldWklr+YqzQJSekRwz4+CaLB1YMoCDFKB9j+3kyDIYmfOv0m9BFvXo=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2aqb-0002If-JF; Mon, 03 Aug 2020 13:49:49 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k2aqb-0004pb-7I; Mon, 03 Aug 2020 13:49:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k2aqb-0007BF-6h; Mon, 03 Aug 2020 13:49:49 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 152408: regressions - FAIL X-Osstest-Failures: libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=60f6f16c0cb5537c01fd5d5af12e7fdba928d5b0 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Mon, 03 Aug 2020 13:49:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152408 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/152408/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a version targeted for testing: libvirt 60f6f16c0cb5537c01fd5d5af12e7fdba928d5b0 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 24 days Failing since 151818 2020-07-11 04:18:52 Z 23 days 24 attempts Testing same since 152408 2020-08-03 04:25:51 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrea Bolognani Balázs Meskó Bastien Orivel Bihong Yu Boris Fiuczynski Côme Borsoi Daniel Henrique Barboza Daniel P. Berrange Daniel P. Berrangé Fedora Weblate Translation Han Han Hao Wang Jean-Baptiste Holcroft Jianan Gao Jin Yan Jiri Denemark Ján Tomko Laine Stump Liao Pingfang Michal Privoznik Nikolay Shirokovskiy Paulo de Rezende Pinatti Pavel Hrdina Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Roman Bogorodskiy Ryan Schmidt Stefan Berger Szymon Scholz Weblate Yi Wang Yuri Chornoivan Zheng Chuan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 3190 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Aug 03 14:47:54 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 14:47:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2bkd-00044u-N5; Mon, 03 Aug 2020 14:47:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2bkc-00044p-PM for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 14:47:42 +0000 X-Inumbo-ID: 485fd780-d598-11ea-9097-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 485fd780-d598-11ea-9097-bc764e2007e4; Mon, 03 Aug 2020 14:47:41 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 59A39ACC8; Mon, 3 Aug 2020 14:47:56 +0000 (UTC) To: "xen-devel@lists.xenproject.org" From: Jan Beulich Subject: [PATCH 00/10] x86emul: full coverage mem access / write testing Message-ID: <97ca3d9c-7540-c7b1-cf84-34c75c9127df@suse.com> Date: Mon, 3 Aug 2020 16:47:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" ... and a few fixes resulting from this work. This completes what was started for legacy encoded GPR insns in a rush before 4.14. There's one thing I'm still planning on top of both this and the EVEX-disp8 checking: For all encodings we produce via general logic (and in particular without involvement of any assembler) I'd like to add a kind of logging mechanism, the output of which could be fed to gas and then some disassembler, to allow verification that the produced encodings are actually valid ones. See e.g. the first patch here or commit 5f55389d6960 - the problems addressed there could have been caught earlier if the generated encodings could be easily disassembled. What's not clear to me here is whether this is deemed generally useful, or whether I should make this a private addition of mine. 01: adjustments to mem access / write logic testing 02: extend decoding / mem access testing to FPU insns 03: extend decoding / mem access testing to MMX / SSE insns 04: extend decoding / mem access testing to VEX-encoded insns 05: extend decoding / mem access testing to XOP-encoded insns 06: AVX512{F,BW} down conversion moves are memory writes 07: AVX512F scatter insns are memory writes 08: AVX512PF insns aren't memory accesses 09: extend decoding / mem access testing to EVEX-encoded insns 10: correct AVX512_BF16 insn names in EVEX Disp8 test Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 03 14:50:37 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 14:50:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2bnD-0004sx-57; Mon, 03 Aug 2020 14:50:23 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2bnB-0004sA-Ux for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 14:50:21 +0000 X-Inumbo-ID: a6cd0536-d598-11ea-af3a-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a6cd0536-d598-11ea-af3a-12813bfff9fa; Mon, 03 Aug 2020 14:50:20 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CE6F6ACC8; Mon, 3 Aug 2020 14:50:34 +0000 (UTC) Subject: [PATCH 01/10] x86emul: adjustments to mem access / write logic testing From: Jan Beulich To: "xen-devel@lists.xenproject.org" References: <97ca3d9c-7540-c7b1-cf84-34c75c9127df@suse.com> Message-ID: <12105df6-e0c6-c46d-8a9a-04192e8faabb@suse.com> Date: Mon, 3 Aug 2020 16:50:18 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <97ca3d9c-7540-c7b1-cf84-34c75c9127df@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" The combination of specifying a ModR/M byte with the upper two bits set and the modrm field set to T is pointless - the same test will be executed twice, i.e. overall things will be slower for no extra gain. I can only assume this was a copy-and-paste-without-enough-editing mistake of mine. Furthermore adjust the base type of a few bit fields to shrink table size, as subsequently quite a few new entries will get added to the tables using this type. Signed-off-by: Jan Beulich --- a/tools/tests/x86_emulator/predicates.c +++ b/tools/tests/x86_emulator/predicates.c @@ -21,8 +21,8 @@ static const struct { uint8_t opc[8]; uint8_t len[2]; /* 32- and 64-bit mode */ bool modrm:1; /* Should register form (also) be tested? */ - unsigned int mem:2; - unsigned int pfx:2; + uint8_t mem:2; + uint8_t pfx:2; #define REG(opc, more...) \ { { (opc) | 0 }, more }, /* %?ax */ \ { { (opc) | 1 }, more }, /* %?cx */ \ @@ -334,53 +334,53 @@ static const struct { /*{ 0x01, 0x28 }, { 2, 2 }, F, W, pfx_f3 }, rstorssp */ { { 0x01, 0x30 }, { 2, 2 }, T, R }, /* lmsw */ { { 0x01, 0x38 }, { 2, 2 }, F, N }, /* invlpg */ - { { 0x01, 0xc0 }, { 2, 2 }, T, N }, /* enclv */ - { { 0x01, 0xc1 }, { 2, 2 }, T, N }, /* vmcall */ + { { 0x01, 0xc0 }, { 2, 2 }, F, N }, /* enclv */ + { { 0x01, 0xc1 }, { 2, 2 }, F, N }, /* vmcall */ /*{ 0x01, 0xc2 }, { 2, 2 }, F, R }, vmlaunch */ /*{ 0x01, 0xc3 }, { 2, 2 }, F, R }, vmresume */ - { { 0x01, 0xc4 }, { 2, 2 }, T, N }, /* vmxoff */ - { { 0x01, 0xc5 }, { 2, 2 }, T, N }, /* pconfig */ - { { 0x01, 0xc8 }, { 2, 2 }, T, N }, /* monitor */ - { { 0x01, 0xc9 }, { 2, 2 }, T, N }, /* mwait */ - { { 0x01, 0xca }, { 2, 2 }, T, N }, /* clac */ - { { 0x01, 0xcb }, { 2, 2 }, T, N }, /* stac */ - { { 0x01, 0xcf }, { 2, 2 }, T, N }, /* encls */ - { { 0x01, 0xd0 }, { 2, 2 }, T, N }, /* xgetbv */ - { { 0x01, 0xd1 }, { 2, 2 }, T, N }, /* xsetbv */ - { { 0x01, 0xd4 }, { 2, 2 }, T, N }, /* vmfunc */ - { { 0x01, 0xd5 }, { 2, 2 }, T, N }, /* xend */ - { { 0x01, 0xd6 }, { 2, 2 }, T, N }, /* xtest */ - { { 0x01, 0xd7 }, { 2, 2 }, T, N }, /* enclu */ + { { 0x01, 0xc4 }, { 2, 2 }, F, N }, /* vmxoff */ + { { 0x01, 0xc5 }, { 2, 2 }, F, N }, /* pconfig */ + { { 0x01, 0xc8 }, { 2, 2 }, F, N }, /* monitor */ + { { 0x01, 0xc9 }, { 2, 2 }, F, N }, /* mwait */ + { { 0x01, 0xca }, { 2, 2 }, F, N }, /* clac */ + { { 0x01, 0xcb }, { 2, 2 }, F, N }, /* stac */ + { { 0x01, 0xcf }, { 2, 2 }, F, N }, /* encls */ + { { 0x01, 0xd0 }, { 2, 2 }, F, N }, /* xgetbv */ + { { 0x01, 0xd1 }, { 2, 2 }, F, N }, /* xsetbv */ + { { 0x01, 0xd4 }, { 2, 2 }, F, N }, /* vmfunc */ + { { 0x01, 0xd5 }, { 2, 2 }, F, N }, /* xend */ + { { 0x01, 0xd6 }, { 2, 2 }, F, N }, /* xtest */ + { { 0x01, 0xd7 }, { 2, 2 }, F, N }, /* enclu */ /*{ 0x01, 0xd8 }, { 2, 2 }, F, R }, vmrun */ - { { 0x01, 0xd9 }, { 2, 2 }, T, N }, /* vmcall */ - { { 0x01, 0xd9 }, { 2, 2 }, T, N, pfx_f3 }, /* vmgexit */ - { { 0x01, 0xd9 }, { 2, 2 }, T, N, pfx_f2 }, /* vmgexit */ + { { 0x01, 0xd9 }, { 2, 2 }, F, N }, /* vmcall */ + { { 0x01, 0xd9 }, { 2, 2 }, F, N, pfx_f3 }, /* vmgexit */ + { { 0x01, 0xd9 }, { 2, 2 }, F, N, pfx_f2 }, /* vmgexit */ /*{ 0x01, 0xda }, { 2, 2 }, F, R }, vmload */ /*{ 0x01, 0xdb }, { 2, 2 }, F, W }, vmsave */ - { { 0x01, 0xdc }, { 2, 2 }, T, N }, /* stgi */ - { { 0x01, 0xdd }, { 2, 2 }, T, N }, /* clgi */ + { { 0x01, 0xdc }, { 2, 2 }, F, N }, /* stgi */ + { { 0x01, 0xdd }, { 2, 2 }, F, N }, /* clgi */ /*{ 0x01, 0xde }, { 2, 2 }, F, R }, skinit */ - { { 0x01, 0xdf }, { 2, 2 }, T, N }, /* invlpga */ - { { 0x01, 0xe8 }, { 2, 2 }, T, N }, /* serialize */ + { { 0x01, 0xdf }, { 2, 2 }, F, N }, /* invlpga */ + { { 0x01, 0xe8 }, { 2, 2 }, F, N }, /* serialize */ /*{ 0x01, 0xe8 }, { 2, 2 }, F, W, pfx_f3 }, setssbsy */ - { { 0x01, 0xe8 }, { 2, 2 }, T, N, pfx_f2 }, /* xsusldtrk */ - { { 0x01, 0xe9 }, { 2, 2 }, T, N, pfx_f2 }, /* xresldtrk */ + { { 0x01, 0xe8 }, { 2, 2 }, F, N, pfx_f2 }, /* xsusldtrk */ + { { 0x01, 0xe9 }, { 2, 2 }, F, N, pfx_f2 }, /* xresldtrk */ /*{ 0x01, 0xea }, { 2, 2 }, F, W, pfx_f3 }, saveprevssp */ - { { 0x01, 0xee }, { 2, 2 }, T, N }, /* rdpkru */ - { { 0x01, 0xef }, { 2, 2 }, T, N }, /* wrpkru */ - { { 0x01, 0xf8 }, { 0, 2 }, T, N }, /* swapgs */ - { { 0x01, 0xf9 }, { 2, 2 }, T, N }, /* rdtscp */ - { { 0x01, 0xfa }, { 2, 2 }, T, N }, /* monitorx */ - { { 0x01, 0xfa }, { 2, 2 }, T, N, pfx_f3 }, /* mcommit */ - { { 0x01, 0xfb }, { 2, 2 }, T, N }, /* mwaitx */ + { { 0x01, 0xee }, { 2, 2 }, F, N }, /* rdpkru */ + { { 0x01, 0xef }, { 2, 2 }, F, N }, /* wrpkru */ + { { 0x01, 0xf8 }, { 0, 2 }, F, N }, /* swapgs */ + { { 0x01, 0xf9 }, { 2, 2 }, F, N }, /* rdtscp */ + { { 0x01, 0xfa }, { 2, 2 }, F, N }, /* monitorx */ + { { 0x01, 0xfa }, { 2, 2 }, F, N, pfx_f3 }, /* mcommit */ + { { 0x01, 0xfb }, { 2, 2 }, F, N }, /* mwaitx */ { { 0x01, 0xfc }, { 2, 2 }, F, W }, /* clzero */ - { { 0x01, 0xfd }, { 2, 2 }, T, N }, /* rdpru */ - { { 0x01, 0xfe }, { 2, 2 }, T, N }, /* invlpgb */ - { { 0x01, 0xfe }, { 0, 2 }, T, N, pfx_f3 }, /* rmpadjust */ - { { 0x01, 0xfe }, { 0, 2 }, T, N, pfx_f2 }, /* rmpupdate */ - { { 0x01, 0xff }, { 2, 2 }, T, N }, /* tlbsync */ - { { 0x01, 0xff }, { 0, 2 }, T, N, pfx_f3 }, /* psmash */ - { { 0x01, 0xff }, { 0, 2 }, T, N, pfx_f2 }, /* pvalidate */ + { { 0x01, 0xfd }, { 2, 2 }, F, N }, /* rdpru */ + { { 0x01, 0xfe }, { 2, 2 }, F, N }, /* invlpgb */ + { { 0x01, 0xfe }, { 0, 2 }, F, N, pfx_f3 }, /* rmpadjust */ + { { 0x01, 0xfe }, { 0, 2 }, F, N, pfx_f2 }, /* rmpupdate */ + { { 0x01, 0xff }, { 2, 2 }, F, N }, /* tlbsync */ + { { 0x01, 0xff }, { 0, 2 }, F, N, pfx_f3 }, /* psmash */ + { { 0x01, 0xff }, { 0, 2 }, F, N, pfx_f2 }, /* pvalidate */ { { 0x02 }, { 2, 2 }, T, R }, /* lar */ { { 0x03 }, { 2, 2 }, T, R }, /* lsl */ { { 0x05 }, { 1, 1 }, F, N }, /* syscall */ From xen-devel-bounces@lists.xenproject.org Mon Aug 03 14:50:41 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 14:50:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2bnV-0004uq-IM; Mon, 03 Aug 2020 14:50:41 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2bnU-0004ug-J1 for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 14:50:40 +0000 X-Inumbo-ID: b22f07b2-d598-11ea-9097-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b22f07b2-d598-11ea-9097-bc764e2007e4; Mon, 03 Aug 2020 14:50:39 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E49D7AD39; Mon, 3 Aug 2020 14:50:53 +0000 (UTC) Subject: [PATCH 02/10] x86emul: extend decoding / mem access testing to FPU insns From: Jan Beulich To: "xen-devel@lists.xenproject.org" References: <97ca3d9c-7540-c7b1-cf84-34c75c9127df@suse.com> Message-ID: Date: Mon, 3 Aug 2020 16:50:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <97ca3d9c-7540-c7b1-cf84-34c75c9127df@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Signed-off-by: Jan Beulich --- a/tools/tests/x86_emulator/predicates.c +++ b/tools/tests/x86_emulator/predicates.c @@ -517,6 +517,138 @@ static const struct { }; #undef CND #undef REG +static const struct { + uint8_t opc[2]; + bool modrm:1; /* Should register form (also) be tested? */ + uint8_t mem:2; +} fpu[] = { + { { 0xd8, 0x00 }, T, R }, /* fadd */ + { { 0xd8, 0x08 }, T, R }, /* fmul */ + { { 0xd8, 0x10 }, T, R }, /* fcom */ + { { 0xd8, 0x18 }, T, R }, /* fcomp */ + { { 0xd8, 0x20 }, T, R }, /* fsub */ + { { 0xd8, 0x28 }, T, R }, /* fsubr */ + { { 0xd8, 0x30 }, T, R }, /* fdiv */ + { { 0xd8, 0x38 }, T, R }, /* fdivr */ + { { 0xd9, 0x00 }, T, R }, /* fld */ + { { 0xd9, 0x10 }, F, W }, /* fst */ + { { 0xd9, 0x18 }, T, W }, /* fstp */ + { { 0xd9, 0x20 }, F, R }, /* fldenv */ + { { 0xd9, 0x28 }, F, R }, /* fldcw */ + { { 0xd9, 0x30 }, F, W }, /* fnstenv */ + { { 0xd9, 0x38 }, F, W }, /* fnstcw */ + { { 0xd9, 0xc8 }, F, N }, /* fxch */ + { { 0xd9, 0xd0 }, F, N }, /* fnop */ + { { 0xd9, 0xe0 }, F, N }, /* fchs */ + { { 0xd9, 0xe1 }, F, N }, /* fabs */ + { { 0xd9, 0xe4 }, F, N }, /* ftst */ + { { 0xd9, 0xe5 }, F, N }, /* fxam */ + { { 0xd9, 0xe6 }, F, N }, /* ftstp */ + { { 0xd9, 0xe8 }, F, N }, /* fld1 */ + { { 0xd9, 0xe9 }, F, N }, /* fldl2t */ + { { 0xd9, 0xea }, F, N }, /* fldl2e */ + { { 0xd9, 0xeb }, F, N }, /* fldpi */ + { { 0xd9, 0xec }, F, N }, /* fldlg2 */ + { { 0xd9, 0xed }, F, N }, /* fldln2 */ + { { 0xd9, 0xee }, F, N }, /* fldz */ + { { 0xd9, 0xf0 }, F, N }, /* f2xm1 */ + { { 0xd9, 0xf1 }, F, N }, /* fyl2x */ + { { 0xd9, 0xf2 }, F, N }, /* fptan */ + { { 0xd9, 0xf3 }, F, N }, /* fpatan */ + { { 0xd9, 0xf4 }, F, N }, /* fxtract */ + { { 0xd9, 0xf5 }, F, N }, /* fprem1 */ + { { 0xd9, 0xf6 }, F, N }, /* fdecstp */ + { { 0xd9, 0xf7 }, F, N }, /* fincstp */ + { { 0xd9, 0xf8 }, F, N }, /* fprem */ + { { 0xd9, 0xf9 }, F, N }, /* fyl2xp1 */ + { { 0xd9, 0xfa }, F, N }, /* fsqrt */ + { { 0xd9, 0xfb }, F, N }, /* fsincos */ + { { 0xd9, 0xfc }, F, N }, /* frndint */ + { { 0xd9, 0xfd }, F, N }, /* fscale */ + { { 0xd9, 0xfe }, F, N }, /* fsin */ + { { 0xd9, 0xff }, F, N }, /* fcos */ + { { 0xda, 0x00 }, F, R }, /* fiadd */ + { { 0xda, 0x08 }, F, R }, /* fimul */ + { { 0xda, 0x10 }, F, R }, /* ficom */ + { { 0xda, 0x18 }, F, R }, /* ficomp */ + { { 0xda, 0x20 }, F, R }, /* fisub */ + { { 0xda, 0x28 }, F, R }, /* fisubr */ + { { 0xda, 0x30 }, F, R }, /* fidiv */ + { { 0xda, 0x38 }, F, R }, /* fidivr */ + { { 0xda, 0xc0 }, F, N }, /* fcmovb */ + { { 0xda, 0xc8 }, F, N }, /* fcmove */ + { { 0xda, 0xd0 }, F, N }, /* fcmovbe */ + { { 0xda, 0xd8 }, F, N }, /* fcmovu */ + { { 0xda, 0xe9 }, F, N }, /* fucompp */ + { { 0xdb, 0x00 }, F, R }, /* fild */ + { { 0xdb, 0x08 }, F, W }, /* fisttp */ + { { 0xdb, 0x10 }, F, W }, /* fist */ + { { 0xdb, 0x18 }, F, W }, /* fistp */ + { { 0xdb, 0x28 }, F, R }, /* fld */ + { { 0xdb, 0x38 }, F, W }, /* fstp */ + { { 0xdb, 0xc0 }, F, N }, /* fcmovnb */ + { { 0xdb, 0xc8 }, F, N }, /* fcmovne */ + { { 0xdb, 0xd0 }, F, N }, /* fcmovnbe */ + { { 0xdb, 0xd8 }, F, N }, /* fcmovnu */ + { { 0xdb, 0xe0 }, F, N }, /* fneni */ + { { 0xdb, 0xe1 }, F, N }, /* fndisi */ + { { 0xdb, 0xe2 }, F, N }, /* fnclex */ + { { 0xdb, 0xe3 }, F, N }, /* fninit */ + { { 0xdb, 0xe4 }, F, N }, /* fsetpm */ + { { 0xdb, 0xe5 }, F, N }, /* frstpm */ + { { 0xdb, 0xe8 }, F, N }, /* fucomi */ + { { 0xdb, 0xf0 }, F, N }, /* fcomi */ + { { 0xdc, 0x00 }, T, R }, /* fadd */ + { { 0xdc, 0x08 }, T, R }, /* fmul */ + { { 0xdc, 0x10 }, T, R }, /* fcom */ + { { 0xdc, 0x18 }, T, R }, /* fcomp */ + { { 0xdc, 0x20 }, T, R }, /* fsub */ + { { 0xdc, 0x28 }, T, R }, /* fsubr */ + { { 0xdc, 0x30 }, T, R }, /* fdiv */ + { { 0xdc, 0x38 }, T, R }, /* fdivr */ + { { 0xdd, 0x00 }, F, R }, /* fld */ + { { 0xdd, 0x08 }, F, W }, /* fisttp */ + { { 0xdd, 0x10 }, T, W }, /* fst */ + { { 0xdd, 0x18 }, T, W }, /* fstp */ + { { 0xdd, 0x20 }, F, R }, /* frstor */ + { { 0xdd, 0x30 }, F, W }, /* fnsave */ + { { 0xdd, 0x38 }, F, W }, /* fnstsw */ + { { 0xdd, 0xc0 }, F, N }, /* ffree */ + { { 0xdd, 0xc8 }, F, N }, /* fxch */ + { { 0xdd, 0xe0 }, F, N }, /* fucom */ + { { 0xdd, 0xe8 }, F, N }, /* fucomp */ + { { 0xde, 0x00 }, F, R }, /* fiadd */ + { { 0xde, 0x08 }, F, R }, /* fimul */ + { { 0xde, 0x10 }, F, R }, /* ficom */ + { { 0xde, 0x18 }, F, R }, /* ficomp */ + { { 0xde, 0x20 }, F, R }, /* fisub */ + { { 0xde, 0x28 }, F, R }, /* fisubr */ + { { 0xde, 0x30 }, F, R }, /* fidiv */ + { { 0xde, 0x38 }, F, R }, /* fidivr */ + { { 0xde, 0xc0 }, F, N }, /* faddp */ + { { 0xde, 0xc8 }, F, N }, /* fmulp */ + { { 0xde, 0xd0 }, F, N }, /* fcomp */ + { { 0xde, 0xd9 }, F, N }, /* fcompp */ + { { 0xde, 0xe0 }, F, N }, /* fsubrp */ + { { 0xde, 0xe8 }, F, N }, /* fsubp */ + { { 0xde, 0xf0 }, F, N }, /* fdivrp */ + { { 0xde, 0xf8 }, F, N }, /* fdivp */ + { { 0xdf, 0x00 }, F, R }, /* fild */ + { { 0xdf, 0x08 }, F, W }, /* fisttp */ + { { 0xdf, 0x10 }, F, W }, /* fist */ + { { 0xdf, 0x18 }, F, W }, /* fistp */ + { { 0xdf, 0x20 }, F, R }, /* fbld */ + { { 0xdf, 0x28 }, F, R }, /* fild */ + { { 0xdf, 0x30 }, F, W }, /* fbstp */ + { { 0xdf, 0x38 }, F, W }, /* fistp */ + { { 0xdf, 0xc0 }, F, N }, /* ffreep */ + { { 0xdf, 0xc8 }, F, N }, /* fxch */ + { { 0xdf, 0xd0 }, F, N }, /* fstp */ + { { 0xdf, 0xd8 }, F, N }, /* fstp */ + { { 0xdf, 0xe0 }, F, N }, /* fnstsw */ + { { 0xdf, 0xe8 }, F, N }, /* fucomip */ + { { 0xdf, 0xf0 }, F, N }, /* fcomip */ +}; #undef F #undef N #undef R @@ -667,6 +799,16 @@ void predicates_test(void *instr, struct legacy_0f38[t].mem, ctxt, fetch); } + memset(instr + ARRAY_SIZE(fpu[t].opc), 0xcc, 13); + + for ( t = 0; t < ARRAY_SIZE(fpu); ++t ) + { + memcpy(instr, fpu[t].opc, ARRAY_SIZE(fpu[t].opc)); + + do_test(instr, ARRAY_SIZE(fpu[t].opc), fpu[t].modrm, fpu[t].mem, + ctxt, fetch); + } + if ( errors ) exit(1); From xen-devel-bounces@lists.xenproject.org Mon Aug 03 14:51:03 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 14:51:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2bnq-0004yc-Rm; Mon, 03 Aug 2020 14:51:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2bnq-0004yO-3A for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 14:51:02 +0000 X-Inumbo-ID: be701afc-d598-11ea-9097-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id be701afc-d598-11ea-9097-bc764e2007e4; Mon, 03 Aug 2020 14:51:00 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 742C5AF0E; Mon, 3 Aug 2020 14:51:14 +0000 (UTC) Subject: [PATCH 03/10] x86emul: extend decoding / mem access testing to MMX / SSE insns From: Jan Beulich To: "xen-devel@lists.xenproject.org" References: <97ca3d9c-7540-c7b1-cf84-34c75c9127df@suse.com> Message-ID: <197bf5e9-5246-abfb-3870-6ca3dbaee152@suse.com> Date: Mon, 3 Aug 2020 16:50:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <97ca3d9c-7540-c7b1-cf84-34c75c9127df@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" IOW just legacy encoded ones. For 3dNow! just one example is used, as they're all similar in nature both encoding- and operand-wise. Adjust a slightly misleading (but not wrong) memcpy() invocation, as noticed while further cloning that code. Rename pfx_none to pfx_no, so it can be used to improve readability / column alignment. Signed-off-by: Jan Beulich --- a/tools/tests/x86_emulator/predicates.c +++ b/tools/tests/x86_emulator/predicates.c @@ -3,7 +3,7 @@ #include enum mem_access { mem_none, mem_read, mem_write }; -enum pfx { pfx_none, pfx_66, pfx_f3, pfx_f2 }; +enum pfx { pfx_no, pfx_66, pfx_f3, pfx_f2 }; static const uint8_t prefixes[] = { 0x66, 0xf3, 0xf2 }; #define F false @@ -393,6 +393,30 @@ static const struct { { { 0x0d, 0x00 }, { 2, 2 }, F, N }, /* prefetch */ { { 0x0d, 0x08 }, { 2, 2 }, F, N }, /* prefetchw */ { { 0x0e }, { 1, 1 }, F, N }, /* femms */ + { { 0x0f, 0x00, 0x9e }, { 3, 3 }, T, R }, /* pfadd */ + { { 0x10 }, { 2, 2 }, T, R, pfx_no }, /* movups */ + { { 0x10 }, { 2, 2 }, T, R, pfx_66 }, /* movupd */ + { { 0x10 }, { 2, 2 }, T, R, pfx_f3 }, /* movss */ + { { 0x10 }, { 2, 2 }, T, R, pfx_f2 }, /* movsd */ + { { 0x11 }, { 2, 2 }, T, W, pfx_no }, /* movups */ + { { 0x11 }, { 2, 2 }, T, W, pfx_66 }, /* movupd */ + { { 0x11 }, { 2, 2 }, T, W, pfx_f3 }, /* movss */ + { { 0x11 }, { 2, 2 }, T, W, pfx_f2 }, /* movsd */ + { { 0x12 }, { 2, 2 }, T, R, pfx_no }, /* movlps / movhlps */ + { { 0x12 }, { 2, 2 }, F, R, pfx_66 }, /* movlpd */ + { { 0x12 }, { 2, 2 }, T, R, pfx_f3 }, /* movsldup */ + { { 0x12 }, { 2, 2 }, T, R, pfx_f2 }, /* movddup */ + { { 0x13 }, { 2, 2 }, F, W, pfx_no }, /* movlps */ + { { 0x13 }, { 2, 2 }, F, W, pfx_66 }, /* movlpd */ + { { 0x14 }, { 2, 2 }, T, R, pfx_no }, /* unpcklps */ + { { 0x14 }, { 2, 2 }, T, R, pfx_66 }, /* unpcklpd */ + { { 0x15 }, { 2, 2 }, T, R, pfx_no }, /* unpckhps */ + { { 0x15 }, { 2, 2 }, T, R, pfx_66 }, /* unpckhpd */ + { { 0x16 }, { 2, 2 }, T, R, pfx_no }, /* movhps / movlhps */ + { { 0x16 }, { 2, 2 }, F, R, pfx_66 }, /* movhpd */ + { { 0x16 }, { 2, 2 }, T, R, pfx_f3 }, /* movshdup */ + { { 0x17 }, { 2, 2 }, F, W, pfx_no }, /* movhps */ + { { 0x17 }, { 2, 2 }, F, W, pfx_66 }, /* movhpd */ { { 0x18, 0x00 }, { 2, 2 }, F, N }, /* prefetchnta */ { { 0x18, 0x08 }, { 2, 2 }, F, N }, /* prefetch0 */ { { 0x18, 0x10 }, { 2, 2 }, F, N }, /* prefetch1 */ @@ -414,6 +438,30 @@ static const struct { { { 0x21 }, { 2, 2 }, T, N }, /* mov */ { { 0x22 }, { 2, 2 }, T, N }, /* mov */ { { 0x23 }, { 2, 2 }, T, N }, /* mov */ + { { 0x28 }, { 2, 2 }, T, R, pfx_no }, /* movaps */ + { { 0x28 }, { 2, 2 }, T, R, pfx_66 }, /* movapd */ + { { 0x29 }, { 2, 2 }, T, W, pfx_no }, /* movaps */ + { { 0x29 }, { 2, 2 }, T, W, pfx_66 }, /* movapd */ + { { 0x2a }, { 2, 2 }, T, R, pfx_no }, /* cvtpi2ps */ + { { 0x2a }, { 2, 2 }, T, R, pfx_66 }, /* cvtpi2pd */ + { { 0x2a }, { 2, 2 }, T, R, pfx_f3 }, /* cvtsi2ss */ + { { 0x2a }, { 2, 2 }, T, R, pfx_f2 }, /* cvtsi2sd */ + { { 0x2b }, { 2, 2 }, T, W, pfx_no }, /* movntps */ + { { 0x2b }, { 2, 2 }, T, W, pfx_66 }, /* movntpd */ + { { 0x2b }, { 2, 2 }, T, W, pfx_f3 }, /* movntss */ + { { 0x2b }, { 2, 2 }, T, W, pfx_f2 }, /* movntsd */ + { { 0x2c }, { 2, 2 }, T, R, pfx_no }, /* cvttps2pi */ + { { 0x2c }, { 2, 2 }, T, R, pfx_66 }, /* cvttpd2pi */ + { { 0x2c }, { 2, 2 }, T, R, pfx_f3 }, /* cvttss2si */ + { { 0x2c }, { 2, 2 }, T, R, pfx_f2 }, /* cvttsd2si */ + { { 0x2d }, { 2, 2 }, T, R, pfx_no }, /* cvtps2pi */ + { { 0x2d }, { 2, 2 }, T, R, pfx_66 }, /* cvtpd2pi */ + { { 0x2d }, { 2, 2 }, T, R, pfx_f3 }, /* cvtss2si */ + { { 0x2d }, { 2, 2 }, T, R, pfx_f2 }, /* cvtsd2si */ + { { 0x2e }, { 2, 2 }, T, R, pfx_no }, /* ucomiss */ + { { 0x2e }, { 2, 2 }, T, R, pfx_66 }, /* ucomisd */ + { { 0x2f }, { 2, 2 }, T, R, pfx_no }, /* comiss */ + { { 0x2f }, { 2, 2 }, T, R, pfx_66 }, /* comisd */ { { 0x30 }, { 1, 1 }, F, N }, /* wrmsr */ { { 0x31 }, { 1, 1 }, F, N }, /* rdtsc */ { { 0x32 }, { 1, 1 }, F, N }, /* rdmsr */ @@ -421,8 +469,131 @@ static const struct { { { 0x34 }, { 1, 1 }, F, N }, /* sysenter */ { { 0x35 }, { 1, 1 }, F, N }, /* sysexit */ CND(0x40, { 2, 2 }, T, R ), /* cmov */ + { { 0x50, 0xc0 }, { 2, 2 }, F, N, pfx_no }, /* movmskps */ + { { 0x50, 0xc0 }, { 2, 2 }, F, N, pfx_66 }, /* movmskpd */ + { { 0x51 }, { 2, 2 }, T, R, pfx_no }, /* sqrtps */ + { { 0x51 }, { 2, 2 }, T, R, pfx_66 }, /* sqrtpd */ + { { 0x51 }, { 2, 2 }, T, R, pfx_f3 }, /* sqrtss */ + { { 0x51 }, { 2, 2 }, T, R, pfx_f2 }, /* sqrtsd */ + { { 0x52 }, { 2, 2 }, T, R, pfx_no }, /* rsqrtps */ + { { 0x52 }, { 2, 2 }, T, R, pfx_f3 }, /* rsqrtss */ + { { 0x53 }, { 2, 2 }, T, R, pfx_no }, /* rcpps */ + { { 0x53 }, { 2, 2 }, T, R, pfx_f3 }, /* rcpss */ + { { 0x54 }, { 2, 2 }, T, R, pfx_no }, /* andps */ + { { 0x54 }, { 2, 2 }, T, R, pfx_66 }, /* andpd */ + { { 0x55 }, { 2, 2 }, T, R, pfx_no }, /* andnps */ + { { 0x55 }, { 2, 2 }, T, R, pfx_66 }, /* andnpd */ + { { 0x56 }, { 2, 2 }, T, R, pfx_no }, /* orps */ + { { 0x56 }, { 2, 2 }, T, R, pfx_66 }, /* orpd */ + { { 0x57 }, { 2, 2 }, T, R, pfx_no }, /* xorps */ + { { 0x57 }, { 2, 2 }, T, R, pfx_66 }, /* xorpd */ + { { 0x58 }, { 2, 2 }, T, R, pfx_no }, /* addps */ + { { 0x58 }, { 2, 2 }, T, R, pfx_66 }, /* addpd */ + { { 0x58 }, { 2, 2 }, T, R, pfx_f3 }, /* addss */ + { { 0x58 }, { 2, 2 }, T, R, pfx_f2 }, /* addsd */ + { { 0x59 }, { 2, 2 }, T, R, pfx_no }, /* mulps */ + { { 0x59 }, { 2, 2 }, T, R, pfx_66 }, /* mulpd */ + { { 0x59 }, { 2, 2 }, T, R, pfx_f3 }, /* mulss */ + { { 0x59 }, { 2, 2 }, T, R, pfx_f2 }, /* mulsd */ + { { 0x5a }, { 2, 2 }, T, R, pfx_no }, /* cvtps2pd */ + { { 0x5a }, { 2, 2 }, T, R, pfx_66 }, /* cvtpd2ps */ + { { 0x5a }, { 2, 2 }, T, R, pfx_f3 }, /* cvtss2sd */ + { { 0x5a }, { 2, 2 }, T, R, pfx_f2 }, /* cvtsd2ss */ + { { 0x5b }, { 2, 2 }, T, R, pfx_no }, /* cvtdq2ps */ + { { 0x5b }, { 2, 2 }, T, R, pfx_66 }, /* cvtps2dq */ + { { 0x5b }, { 2, 2 }, T, R, pfx_f3 }, /* cvttps2dq */ + { { 0x5c }, { 2, 2 }, T, R, pfx_no }, /* subps */ + { { 0x5c }, { 2, 2 }, T, R, pfx_66 }, /* subpd */ + { { 0x5c }, { 2, 2 }, T, R, pfx_f3 }, /* subss */ + { { 0x5c }, { 2, 2 }, T, R, pfx_f2 }, /* subsd */ + { { 0x5d }, { 2, 2 }, T, R, pfx_no }, /* minps */ + { { 0x5d }, { 2, 2 }, T, R, pfx_66 }, /* minpd */ + { { 0x5d }, { 2, 2 }, T, R, pfx_f3 }, /* minss */ + { { 0x5d }, { 2, 2 }, T, R, pfx_f2 }, /* minsd */ + { { 0x5e }, { 2, 2 }, T, R, pfx_no }, /* divps */ + { { 0x5e }, { 2, 2 }, T, R, pfx_66 }, /* divpd */ + { { 0x5e }, { 2, 2 }, T, R, pfx_f3 }, /* divss */ + { { 0x5e }, { 2, 2 }, T, R, pfx_f2 }, /* divsd */ + { { 0x5f }, { 2, 2 }, T, R, pfx_no }, /* maxps */ + { { 0x5f }, { 2, 2 }, T, R, pfx_66 }, /* maxpd */ + { { 0x5f }, { 2, 2 }, T, R, pfx_f3 }, /* maxss */ + { { 0x5f }, { 2, 2 }, T, R, pfx_f2 }, /* maxsd */ + { { 0x60 }, { 2, 2 }, T, R, pfx_no }, /* punpcklbw */ + { { 0x60 }, { 2, 2 }, T, R, pfx_66 }, /* punpcklbw */ + { { 0x61 }, { 2, 2 }, T, R, pfx_no }, /* punpcklwd */ + { { 0x61 }, { 2, 2 }, T, R, pfx_66 }, /* punpcklwd */ + { { 0x62 }, { 2, 2 }, T, R, pfx_no }, /* punpckldq */ + { { 0x62 }, { 2, 2 }, T, R, pfx_66 }, /* punpckldq */ + { { 0x63 }, { 2, 2 }, T, R, pfx_no }, /* packsswb */ + { { 0x63 }, { 2, 2 }, T, R, pfx_66 }, /* packsswb */ + { { 0x64 }, { 2, 2 }, T, R, pfx_no }, /* pcmpgtb */ + { { 0x64 }, { 2, 2 }, T, R, pfx_66 }, /* pcmpgtb */ + { { 0x65 }, { 2, 2 }, T, R, pfx_no }, /* pcmpgtw */ + { { 0x65 }, { 2, 2 }, T, R, pfx_66 }, /* pcmpgtw */ + { { 0x66 }, { 2, 2 }, T, R, pfx_no }, /* pcmpgtd */ + { { 0x66 }, { 2, 2 }, T, R, pfx_66 }, /* pcmpgtd */ + { { 0x67 }, { 2, 2 }, T, R, pfx_no }, /* packuswb */ + { { 0x67 }, { 2, 2 }, T, R, pfx_66 }, /* packuswb */ + { { 0x68 }, { 2, 2 }, T, R, pfx_no }, /* punpckhbw */ + { { 0x68 }, { 2, 2 }, T, R, pfx_66 }, /* punpckhbw */ + { { 0x69 }, { 2, 2 }, T, R, pfx_no }, /* punpckhwd */ + { { 0x69 }, { 2, 2 }, T, R, pfx_66 }, /* punpckhwd */ + { { 0x6a }, { 2, 2 }, T, R, pfx_no }, /* punpckhdq */ + { { 0x6a }, { 2, 2 }, T, R, pfx_66 }, /* punpckhdq */ + { { 0x6b }, { 2, 2 }, T, R, pfx_no }, /* packssdw */ + { { 0x6b }, { 2, 2 }, T, R, pfx_66 }, /* packssdw */ + { { 0x6c }, { 2, 2 }, T, R, pfx_66 }, /* punpcklqdq */ + { { 0x6d }, { 2, 2 }, T, R, pfx_66 }, /* punpckhqdq */ + { { 0x6e }, { 2, 2 }, T, R, pfx_no }, /* movd */ + { { 0x6e }, { 2, 2 }, T, R, pfx_66 }, /* movd */ + { { 0x6f }, { 2, 2 }, T, R, pfx_no }, /* movq */ + { { 0x6f }, { 2, 2 }, T, R, pfx_66 }, /* movdqa */ + { { 0x6f }, { 2, 2 }, T, R, pfx_f3 }, /* movdqu */ + { { 0x70 }, { 3, 3 }, T, R, pfx_no }, /* pshufw */ + { { 0x70 }, { 3, 3 }, T, R, pfx_66 }, /* pshufd */ + { { 0x70 }, { 3, 3 }, T, R, pfx_f3 }, /* pshuflw */ + { { 0x70 }, { 3, 3 }, T, R, pfx_f2 }, /* pshufhw */ + { { 0x71, 0xd0 }, { 3, 3 }, F, N, pfx_no }, /* psrlw */ + { { 0x71, 0xd0 }, { 3, 3 }, F, N, pfx_66 }, /* psrlw */ + { { 0x71, 0xe0 }, { 3, 3 }, F, N, pfx_no }, /* psraw */ + { { 0x71, 0xe0 }, { 3, 3 }, F, N, pfx_66 }, /* psraw */ + { { 0x71, 0xf0 }, { 3, 3 }, F, N, pfx_no }, /* psllw */ + { { 0x71, 0xf0 }, { 3, 3 }, F, N, pfx_66 }, /* psllw */ + { { 0x72, 0xd0 }, { 3, 3 }, F, N, pfx_no }, /* psrld */ + { { 0x72, 0xd0 }, { 3, 3 }, F, N, pfx_66 }, /* psrld */ + { { 0x72, 0xe0 }, { 3, 3 }, F, N, pfx_no }, /* psrad */ + { { 0x72, 0xe0 }, { 3, 3 }, F, N, pfx_66 }, /* psrad */ + { { 0x72, 0xf0 }, { 3, 3 }, F, N, pfx_no }, /* pslld */ + { { 0x72, 0xf0 }, { 3, 3 }, F, N, pfx_66 }, /* pslld */ + { { 0x73, 0xd0 }, { 3, 3 }, F, N, pfx_no }, /* psrlq */ + { { 0x73, 0xd0 }, { 3, 3 }, F, N, pfx_66 }, /* psrlq */ + { { 0x73, 0xd8 }, { 3, 3 }, F, N, pfx_66 }, /* psrldq */ + { { 0x73, 0xf0 }, { 3, 3 }, F, N, pfx_no }, /* psllq */ + { { 0x73, 0xf0 }, { 3, 3 }, F, N, pfx_66 }, /* psllq */ + { { 0x73, 0xf8 }, { 3, 3 }, F, N, pfx_66 }, /* pslldq */ + { { 0x74 }, { 2, 2 }, T, R, pfx_no }, /* pcmpeqb */ + { { 0x74 }, { 2, 2 }, T, R, pfx_66 }, /* pcmpeqb */ + { { 0x75 }, { 2, 2 }, T, R, pfx_no }, /* pcmpeqw */ + { { 0x75 }, { 2, 2 }, T, R, pfx_66 }, /* pcmpeqw */ + { { 0x76 }, { 2, 2 }, T, R, pfx_no }, /* pcmpeqd */ + { { 0x76 }, { 2, 2 }, T, R, pfx_66 }, /* pcmpeqd */ + { { 0x77 }, { 1, 1 }, F, N }, /* emms */ /*{ 0x78 }, { 2, 2 }, T, W }, vmread */ + { { 0x78, 0xc0 }, { 4, 4 }, F, N, pfx_66 }, /* extrq */ + { { 0x78, 0xc0 }, { 4, 4 }, F, N, pfx_f2 }, /* insertq */ { { 0x79 }, { 2, 2 }, T, R }, /* vmwrite */ + { { 0x79, 0xc0 }, { 2, 2 }, F, N, pfx_66 }, /* extrq */ + { { 0x79, 0xc0 }, { 2, 2 }, F, N, pfx_f2 }, /* insertq */ + { { 0x7c }, { 2, 2 }, T, R, pfx_66 }, /* haddpd */ + { { 0x7c }, { 2, 2 }, T, R, pfx_f2 }, /* haddps */ + { { 0x7d }, { 2, 2 }, T, R, pfx_66 }, /* hsubpd */ + { { 0x7d }, { 2, 2 }, T, R, pfx_f2 }, /* hsubps */ + { { 0x7e }, { 2, 2 }, T, W, pfx_no }, /* movd */ + { { 0x7e }, { 2, 2 }, T, W, pfx_66 }, /* movd */ + { { 0x7e }, { 2, 2 }, T, R, pfx_f3 }, /* movq */ + { { 0x7f }, { 2, 2 }, T, W, pfx_no }, /* movq */ + { { 0x7f }, { 2, 2 }, T, W, pfx_66 }, /* movdqa */ + { { 0x7f }, { 2, 2 }, T, W, pfx_f3 }, /* movdqu */ CND(0x80, { 5, 5 }, F, N ), /* j */ CND(0x90, { 2, 2 }, T, W ), /* set */ { { 0xa0 }, { 1, 1 }, F, W }, /* push %fs */ @@ -484,7 +655,17 @@ static const struct { { { 0xbf }, { 2, 2 }, F, R }, /* movsx */ { { 0xc0 }, { 2, 2 }, F, W }, /* xadd */ { { 0xc1 }, { 2, 2 }, F, W }, /* xadd */ + { { 0xc2 }, { 3, 3 }, T, R, pfx_no }, /* cmpps */ + { { 0xc2 }, { 3, 3 }, T, R, pfx_66 }, /* cmppd */ + { { 0xc2 }, { 3, 3 }, T, R, pfx_f3 }, /* cmpss */ + { { 0xc2 }, { 3, 3 }, T, R, pfx_f2 }, /* cmpsd */ { { 0xc3 }, { 2, 2 }, F, W }, /* movnti */ + { { 0xc4 }, { 3, 3 }, T, R, pfx_no }, /* pinsrw */ + { { 0xc4 }, { 3, 3 }, T, R, pfx_66 }, /* pinsrw */ + { { 0xc5, 0xc0 }, { 3, 3 }, F, N, pfx_no }, /* pextrw */ + { { 0xc5, 0xc0 }, { 3, 3 }, F, N, pfx_66 }, /* pextrw */ + { { 0xc6 }, { 3, 3 }, T, R, pfx_no }, /* shufps */ + { { 0xc6 }, { 3, 3 }, T, R, pfx_66 }, /* shufpd */ { { 0xc7, 0x08 }, { 2, 2 }, F, W }, /* cmpxchg8b */ { { 0xc7, 0x18 }, { 2, 2 }, F, R }, /* xrstors */ { { 0xc7, 0x20 }, { 2, 2 }, F, W }, /* xsavec */ @@ -497,11 +678,179 @@ static const struct { { { 0xc7, 0xf8 }, { 2, 2 }, F, N }, /* rdseed */ { { 0xc7, 0xf8 }, { 2, 2 }, F, N, pfx_f3 }, /* rdpid */ REG(0xc8, { 1, 1 }, F, N ), /* bswap */ + { { 0xd0 }, { 2, 2 }, T, R, pfx_66 }, /* addsubpd */ + { { 0xd0 }, { 2, 2 }, T, R, pfx_f2 }, /* addsubps */ + { { 0xd1 }, { 2, 2 }, T, R, pfx_no }, /* psrlw */ + { { 0xd1 }, { 2, 2 }, T, R, pfx_66 }, /* psrlw */ + { { 0xd2 }, { 2, 2 }, T, R, pfx_no }, /* psrld */ + { { 0xd2 }, { 2, 2 }, T, R, pfx_66 }, /* psrld */ + { { 0xd3 }, { 2, 2 }, T, R, pfx_no }, /* psrlq */ + { { 0xd3 }, { 2, 2 }, T, R, pfx_66 }, /* psrlq */ + { { 0xd4 }, { 2, 2 }, T, R, pfx_no }, /* paddq */ + { { 0xd4 }, { 2, 2 }, T, R, pfx_66 }, /* paddq */ + { { 0xd5 }, { 2, 2 }, T, R, pfx_no }, /* pmullw */ + { { 0xd5 }, { 2, 2 }, T, R, pfx_66 }, /* pmullw */ + { { 0xd6 }, { 2, 2 }, T, W, pfx_66 }, /* movq */ + { { 0xd6, 0xc0 }, { 2, 2 }, F, N, pfx_f3 }, /* movq2dq */ + { { 0xd6, 0xc0 }, { 2, 2 }, F, N, pfx_f2 }, /* movdq2q */ + { { 0xd7, 0xc0 }, { 2, 2 }, F, N, pfx_no }, /* pmovmskb */ + { { 0xd7, 0xc0 }, { 2, 2 }, F, N, pfx_66 }, /* pmovmskb */ + { { 0xd8 }, { 2, 2 }, T, R, pfx_no }, /* psubusb */ + { { 0xd8 }, { 2, 2 }, T, R, pfx_66 }, /* psubusb */ + { { 0xd9 }, { 2, 2 }, T, R, pfx_no }, /* psubusw */ + { { 0xd9 }, { 2, 2 }, T, R, pfx_66 }, /* psubusw */ + { { 0xda }, { 2, 2 }, T, R, pfx_no }, /* pminub */ + { { 0xda }, { 2, 2 }, T, R, pfx_66 }, /* pminub */ + { { 0xdb }, { 2, 2 }, T, R, pfx_no }, /* pand */ + { { 0xdb }, { 2, 2 }, T, R, pfx_66 }, /* pand */ + { { 0xdc }, { 2, 2 }, T, R, pfx_no }, /* paddusb */ + { { 0xdc }, { 2, 2 }, T, R, pfx_66 }, /* paddusb */ + { { 0xdd }, { 2, 2 }, T, R, pfx_no }, /* paddusw */ + { { 0xdd }, { 2, 2 }, T, R, pfx_66 }, /* paddusw */ + { { 0xde }, { 2, 2 }, T, R, pfx_no }, /* pmaxub */ + { { 0xde }, { 2, 2 }, T, R, pfx_66 }, /* pmaxub */ + { { 0xdf }, { 2, 2 }, T, R, pfx_no }, /* pandn */ + { { 0xdf }, { 2, 2 }, T, R, pfx_66 }, /* pandn */ + { { 0xe0 }, { 2, 2 }, T, R, pfx_no }, /* pavgb */ + { { 0xe0 }, { 2, 2 }, T, R, pfx_66 }, /* pavgb */ + { { 0xe1 }, { 2, 2 }, T, R, pfx_no }, /* psraw */ + { { 0xe1 }, { 2, 2 }, T, R, pfx_66 }, /* psraw */ + { { 0xe2 }, { 2, 2 }, T, R, pfx_no }, /* psrad */ + { { 0xe2 }, { 2, 2 }, T, R, pfx_66 }, /* psrad */ + { { 0xe3 }, { 2, 2 }, T, R, pfx_no }, /* pavgw */ + { { 0xe3 }, { 2, 2 }, T, R, pfx_66 }, /* pavgw */ + { { 0xe4 }, { 2, 2 }, T, R, pfx_no }, /* pmulhuw */ + { { 0xe4 }, { 2, 2 }, T, R, pfx_66 }, /* pmulhuw */ + { { 0xe5 }, { 2, 2 }, T, R, pfx_no }, /* pmulhw */ + { { 0xe5 }, { 2, 2 }, T, R, pfx_66 }, /* pmulhw */ + { { 0xe6 }, { 2, 2 }, T, R, pfx_66 }, /* cvttpd2dq */ + { { 0xe6 }, { 2, 2 }, T, R, pfx_f3 }, /* cvtdq2pd */ + { { 0xe6 }, { 2, 2 }, T, R, pfx_f2 }, /* cvtpd2dq */ + { { 0xe7 }, { 2, 2 }, F, W, pfx_no }, /* movntq */ + { { 0xe7 }, { 2, 2 }, F, W, pfx_66 }, /* movntdq */ + { { 0xe8 }, { 2, 2 }, T, R, pfx_no }, /* psubsb */ + { { 0xe8 }, { 2, 2 }, T, R, pfx_66 }, /* psubsb */ + { { 0xe9 }, { 2, 2 }, T, R, pfx_no }, /* psubsw */ + { { 0xe9 }, { 2, 2 }, T, R, pfx_66 }, /* psubsw */ + { { 0xea }, { 2, 2 }, T, R, pfx_no }, /* pminsw */ + { { 0xea }, { 2, 2 }, T, R, pfx_66 }, /* pminsw */ + { { 0xeb }, { 2, 2 }, T, R, pfx_no }, /* por */ + { { 0xeb }, { 2, 2 }, T, R, pfx_66 }, /* por */ + { { 0xec }, { 2, 2 }, T, R, pfx_no }, /* paddsb */ + { { 0xec }, { 2, 2 }, T, R, pfx_66 }, /* paddsb */ + { { 0xed }, { 2, 2 }, T, R, pfx_no }, /* paddsw */ + { { 0xed }, { 2, 2 }, T, R, pfx_66 }, /* paddsw */ + { { 0xee }, { 2, 2 }, T, R, pfx_no }, /* pmaxsw */ + { { 0xee }, { 2, 2 }, T, R, pfx_66 }, /* pmaxsw */ + { { 0xef }, { 2, 2 }, T, R, pfx_no }, /* pxor */ + { { 0xef }, { 2, 2 }, T, R, pfx_66 }, /* pxor */ + { { 0xf0 }, { 2, 2 }, T, R, pfx_f2 }, /* lddqu */ + { { 0xf1 }, { 2, 2 }, T, R, pfx_no }, /* psllw */ + { { 0xf1 }, { 2, 2 }, T, R, pfx_66 }, /* psllw */ + { { 0xf2 }, { 2, 2 }, T, R, pfx_no }, /* pslld */ + { { 0xf2 }, { 2, 2 }, T, R, pfx_66 }, /* pslld */ + { { 0xf3 }, { 2, 2 }, T, R, pfx_no }, /* psllq */ + { { 0xf3 }, { 2, 2 }, T, R, pfx_66 }, /* psllq */ + { { 0xf4 }, { 2, 2 }, T, R, pfx_no }, /* pmuludq */ + { { 0xf4 }, { 2, 2 }, T, R, pfx_66 }, /* pmuludq */ + { { 0xf5 }, { 2, 2 }, T, R, pfx_no }, /* pmaddwd */ + { { 0xf5 }, { 2, 2 }, T, R, pfx_66 }, /* pmaddwd */ + { { 0xf6 }, { 2, 2 }, T, R, pfx_no }, /* psadbw */ + { { 0xf6 }, { 2, 2 }, T, R, pfx_66 }, /* psadbw */ + { { 0xf7, 0xc0 }, { 2, 2 }, F, W, pfx_no }, /* maskmovq */ + { { 0xf7, 0xc0 }, { 2, 2 }, F, W, pfx_66 }, /* maskmovdqu */ + { { 0xf8 }, { 2, 2 }, T, R, pfx_no }, /* psubb */ + { { 0xf8 }, { 2, 2 }, T, R, pfx_66 }, /* psubb */ + { { 0xf9 }, { 2, 2 }, T, R, pfx_no }, /* psubw */ + { { 0xf9 }, { 2, 2 }, T, R, pfx_66 }, /* psubw */ + { { 0xfa }, { 2, 2 }, T, R, pfx_no }, /* psubd */ + { { 0xfa }, { 2, 2 }, T, R, pfx_66 }, /* psubd */ + { { 0xfb }, { 2, 2 }, T, R, pfx_no }, /* psubq */ + { { 0xfb }, { 2, 2 }, T, R, pfx_66 }, /* psubq */ + { { 0xfc }, { 2, 2 }, T, R, pfx_no }, /* paddb */ + { { 0xfc }, { 2, 2 }, T, R, pfx_66 }, /* paddb */ + { { 0xfd }, { 2, 2 }, T, R, pfx_no }, /* paddw */ + { { 0xfd }, { 2, 2 }, T, R, pfx_66 }, /* paddw */ + { { 0xfe }, { 2, 2 }, T, R, pfx_no }, /* paddd */ + { { 0xfe }, { 2, 2 }, T, R, pfx_66 }, /* paddd */ { { 0xff }, { 2, 2 }, F, N }, /* ud0 */ }, legacy_0f38[] = { + { { 0x00 }, { 2, 2 }, T, R, pfx_no }, /* pshufb */ + { { 0x00 }, { 2, 2 }, T, R, pfx_66 }, /* pshufb */ + { { 0x01 }, { 2, 2 }, T, R, pfx_no }, /* phaddw */ + { { 0x01 }, { 2, 2 }, T, R, pfx_66 }, /* phaddw */ + { { 0x02 }, { 2, 2 }, T, R, pfx_no }, /* phaddd */ + { { 0x02 }, { 2, 2 }, T, R, pfx_66 }, /* phaddd */ + { { 0x03 }, { 2, 2 }, T, R, pfx_no }, /* phaddsw */ + { { 0x03 }, { 2, 2 }, T, R, pfx_66 }, /* phaddsw */ + { { 0x04 }, { 2, 2 }, T, R, pfx_no }, /* pmaddubsw */ + { { 0x04 }, { 2, 2 }, T, R, pfx_66 }, /* pmaddubsw */ + { { 0x05 }, { 2, 2 }, T, R, pfx_no }, /* phsubw */ + { { 0x05 }, { 2, 2 }, T, R, pfx_66 }, /* phsubw */ + { { 0x06 }, { 2, 2 }, T, R, pfx_no }, /* phsubd */ + { { 0x06 }, { 2, 2 }, T, R, pfx_66 }, /* phsubd */ + { { 0x07 }, { 2, 2 }, T, R, pfx_no }, /* phsubsw */ + { { 0x07 }, { 2, 2 }, T, R, pfx_66 }, /* phsubsw */ + { { 0x08 }, { 2, 2 }, T, R, pfx_no }, /* psignb */ + { { 0x08 }, { 2, 2 }, T, R, pfx_66 }, /* psignb */ + { { 0x09 }, { 2, 2 }, T, R, pfx_no }, /* psignw */ + { { 0x09 }, { 2, 2 }, T, R, pfx_66 }, /* psignw */ + { { 0x0a }, { 2, 2 }, T, R, pfx_no }, /* psignd */ + { { 0x0a }, { 2, 2 }, T, R, pfx_66 }, /* psignd */ + { { 0x0b }, { 2, 2 }, T, R, pfx_no }, /* pmulhrsw */ + { { 0x0b }, { 2, 2 }, T, R, pfx_66 }, /* pmulhrsw */ + { { 0x10 }, { 2, 2 }, T, R, pfx_66 }, /* pblendvb */ + { { 0x14 }, { 2, 2 }, T, R, pfx_66 }, /* blendvps */ + { { 0x15 }, { 2, 2 }, T, R, pfx_66 }, /* blendvpd */ + { { 0x17 }, { 2, 2 }, T, R, pfx_66 }, /* ptest */ + { { 0x1c }, { 2, 2 }, T, R, pfx_no }, /* pabsb */ + { { 0x1c }, { 2, 2 }, T, R, pfx_66 }, /* pabsb */ + { { 0x1d }, { 2, 2 }, T, R, pfx_no }, /* pabsw */ + { { 0x1d }, { 2, 2 }, T, R, pfx_66 }, /* pabsw */ + { { 0x1e }, { 2, 2 }, T, R, pfx_no }, /* pabsd */ + { { 0x1e }, { 2, 2 }, T, R, pfx_66 }, /* pabsd */ + { { 0x20 }, { 2, 2 }, T, R, pfx_66 }, /* pmovsxbw */ + { { 0x21 }, { 2, 2 }, T, R, pfx_66 }, /* pmovsxbd */ + { { 0x22 }, { 2, 2 }, T, R, pfx_66 }, /* pmovsxbq */ + { { 0x23 }, { 2, 2 }, T, R, pfx_66 }, /* pmovsxwd */ + { { 0x24 }, { 2, 2 }, T, R, pfx_66 }, /* pmovsxwq */ + { { 0x25 }, { 2, 2 }, T, R, pfx_66 }, /* pmovsxdq */ + { { 0x28 }, { 2, 2 }, T, R, pfx_66 }, /* pmuldq */ + { { 0x29 }, { 2, 2 }, T, R, pfx_66 }, /* pcmpeqq */ + { { 0x2a }, { 2, 2 }, F, R, pfx_66 }, /* movntdqa */ + { { 0x2b }, { 2, 2 }, T, R, pfx_66 }, /* packusdw */ + { { 0x30 }, { 2, 2 }, T, R, pfx_66 }, /* pmovzxbw */ + { { 0x31 }, { 2, 2 }, T, R, pfx_66 }, /* pmovzxbd */ + { { 0x32 }, { 2, 2 }, T, R, pfx_66 }, /* pmovzxbq */ + { { 0x33 }, { 2, 2 }, T, R, pfx_66 }, /* pmovzxwd */ + { { 0x34 }, { 2, 2 }, T, R, pfx_66 }, /* pmovzxwq */ + { { 0x35 }, { 2, 2 }, T, R, pfx_66 }, /* pmovzxdq */ + { { 0x37 }, { 2, 2 }, T, R, pfx_66 }, /* pcmpgtq */ + { { 0x38 }, { 2, 2 }, T, R, pfx_66 }, /* pminsb */ + { { 0x39 }, { 2, 2 }, T, R, pfx_66 }, /* pminsd */ + { { 0x3a }, { 2, 2 }, T, R, pfx_66 }, /* pminuw */ + { { 0x3b }, { 2, 2 }, T, R, pfx_66 }, /* pminud */ + { { 0x3c }, { 2, 2 }, T, R, pfx_66 }, /* pmaxsb */ + { { 0x3d }, { 2, 2 }, T, R, pfx_66 }, /* pmaxsd */ + { { 0x3e }, { 2, 2 }, T, R, pfx_66 }, /* pmaxuw */ + { { 0x3f }, { 2, 2 }, T, R, pfx_66 }, /* pmaxud */ + { { 0x40 }, { 2, 2 }, T, R, pfx_66 }, /* pmulld */ + { { 0x41 }, { 2, 2 }, T, R, pfx_66 }, /* phminposuw */ { { 0x80 }, { 2, 2 }, T, R, pfx_66 }, /* invept */ { { 0x81 }, { 2, 2 }, T, R, pfx_66 }, /* invvpid */ { { 0x82 }, { 2, 2 }, T, R, pfx_66 }, /* invpcid */ + { { 0xc8 }, { 2, 2 }, T, R, pfx_no }, /* sha1nexte */ + { { 0xc9 }, { 2, 2 }, T, R, pfx_no }, /* sha1msg1 */ + { { 0xca }, { 2, 2 }, T, R, pfx_no }, /* sha1msg2 */ + { { 0xcb }, { 2, 2 }, T, R, pfx_no }, /* sha256rnds2 */ + { { 0xcc }, { 2, 2 }, T, R, pfx_no }, /* sha256msg1 */ + { { 0xcd }, { 2, 2 }, T, R, pfx_no }, /* sha256msg2 */ + { { 0xcf }, { 2, 2 }, T, R, pfx_66 }, /* gf2p8mulb */ + { { 0xdb }, { 2, 2 }, T, R, pfx_66 }, /* aesimc */ + { { 0xdc }, { 2, 2 }, T, R, pfx_66 }, /* aesenc */ + { { 0xdd }, { 2, 2 }, T, R, pfx_66 }, /* aesenclast */ + { { 0xde }, { 2, 2 }, T, R, pfx_66 }, /* aesdec */ + { { 0xdf }, { 2, 2 }, T, R, pfx_66 }, /* aesdeclast */ { { 0xf0 }, { 2, 2 }, T, R }, /* movbe */ { { 0xf0 }, { 2, 2 }, T, R, pfx_f2 }, /* crc32 */ { { 0xf1 }, { 2, 2 }, T, W }, /* movbe */ @@ -517,6 +866,42 @@ static const struct { }; #undef CND #undef REG + +static const struct { + uint8_t opc; + uint8_t mem:2; + uint8_t pfx:2; +} legacy_0f3a[] = { + { 0x08, R, pfx_66 }, /* roundps */ + { 0x09, R, pfx_66 }, /* roundpd */ + { 0x0a, R, pfx_66 }, /* roundss */ + { 0x0b, R, pfx_66 }, /* roundsd */ + { 0x0c, R, pfx_66 }, /* blendps */ + { 0x0d, R, pfx_66 }, /* blendpd */ + { 0x0e, R, pfx_66 }, /* pblendw */ + { 0x0f, R, pfx_no }, /* palignr */ + { 0x0f, R, pfx_66 }, /* palignr */ + { 0x14, W, pfx_66 }, /* pextrb */ + { 0x15, W, pfx_66 }, /* pextrw */ + { 0x16, W, pfx_66 }, /* pextrd */ + { 0x17, W, pfx_66 }, /* extractps */ + { 0x20, R, pfx_66 }, /* pinsrb */ + { 0x21, R, pfx_66 }, /* insertps */ + { 0x22, R, pfx_66 }, /* pinsrd */ + { 0x40, R, pfx_66 }, /* dpps */ + { 0x41, R, pfx_66 }, /* dppd */ + { 0x42, R, pfx_66 }, /* mpsadbw */ + { 0x44, R, pfx_66 }, /* pclmulqdq */ + { 0x60, R, pfx_66 }, /* pcmpestrm */ + { 0x61, R, pfx_66 }, /* pcmpestri */ + { 0x62, R, pfx_66 }, /* pcmpistrm */ + { 0x63, R, pfx_66 }, /* pcmpistri */ + { 0xcc, R, pfx_no }, /* sha1rnds4 */ + { 0xce, R, pfx_66 }, /* gf2p8affineqb */ + { 0xcf, R, pfx_66 }, /* gf2p8affineinvqb */ + { 0xdf, R, pfx_66 }, /* aeskeygenassist */ +}; + static const struct { uint8_t opc[2]; bool modrm:1; /* Should register form (also) be tested? */ @@ -799,6 +1184,23 @@ void predicates_test(void *instr, struct legacy_0f38[t].mem, ctxt, fetch); } + for ( t = 0; t < ARRAY_SIZE(legacy_0f3a); ++t ) + { + uint8_t *ptr = instr; + + memset(instr + 5, 0xcc, 10); + if ( legacy_0f3a[t].pfx ) + *ptr++ = prefixes[legacy_0f3a[t].pfx - 1]; + *ptr++ = 0x0f; + *ptr++ = 0x3a; + *ptr++ = legacy_0f3a[t].opc; + *ptr++ = 0x00; /* ModR/M */ + *ptr++ = 0x00; /* imm8 */ + + do_test(instr, (void *)ptr - instr, (void *)ptr - instr - 2, + legacy_0f3a[t].mem, ctxt, fetch); + } + memset(instr + ARRAY_SIZE(fpu[t].opc), 0xcc, 13); for ( t = 0; t < ARRAY_SIZE(fpu); ++t ) From xen-devel-bounces@lists.xenproject.org Mon Aug 03 14:51:25 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 14:51:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2boD-00054U-8H; Mon, 03 Aug 2020 14:51:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2boB-00054C-Pk for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 14:51:23 +0000 X-Inumbo-ID: cb34c742-d598-11ea-9097-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cb34c742-d598-11ea-9097-bc764e2007e4; Mon, 03 Aug 2020 14:51:21 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DFFC3AC24; Mon, 3 Aug 2020 14:51:35 +0000 (UTC) Subject: [PATCH 04/10] x86emul: extend decoding / mem access testing to VEX-encoded insns From: Jan Beulich To: "xen-devel@lists.xenproject.org" References: <97ca3d9c-7540-c7b1-cf84-34c75c9127df@suse.com> Message-ID: <86fc942a-cd83-c7ca-8ef5-41b3ce0e37b9@suse.com> Date: Mon, 3 Aug 2020 16:51:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <97ca3d9c-7540-c7b1-cf84-34c75c9127df@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Signed-off-by: Jan Beulich --- a/tools/tests/x86_emulator/predicates.c +++ b/tools/tests/x86_emulator/predicates.c @@ -1034,6 +1034,449 @@ static const struct { { { 0xdf, 0xe8 }, F, N }, /* fucomip */ { { 0xdf, 0xf0 }, F, N }, /* fcomip */ }; + +#define VSIB(n) 0x04 | ((n) << 3), 0x38 /* reg: %xmm, mem: (%eax,%xmm7) */ + +static const struct vex { + uint8_t opc[3]; + uint8_t len:3; + bool modrm:1; /* Should register form (also) be tested? */ + uint8_t mem:2; + uint8_t pfx:2; + uint8_t w:2; +#define WIG 0 +#define W0 1 +#define W1 2 +#define Wn (W0 | W1) + uint8_t l:2; +#define LIG 0 +#define L0 1 +#define L1 2 +#define Ln (L0 | L1) +} vex_0f[] = { + { { 0x10 }, 2, T, R, pfx_no, WIG, Ln }, /* vmovups */ + { { 0x10 }, 2, T, R, pfx_66, WIG, Ln }, /* vmovupd */ + { { 0x10 }, 2, T, R, pfx_f3, WIG, LIG }, /* vmovss */ + { { 0x10 }, 2, T, R, pfx_f2, WIG, LIG }, /* vmovsd */ + { { 0x11 }, 2, T, W, pfx_no, WIG, Ln }, /* vmovups */ + { { 0x11 }, 2, T, W, pfx_66, WIG, Ln }, /* vmovupd */ + { { 0x11 }, 2, T, W, pfx_f3, WIG, LIG }, /* vmovss */ + { { 0x11 }, 2, T, W, pfx_f2, WIG, LIG }, /* vmovsd */ + { { 0x12 }, 2, T, R, pfx_no, WIG, L0 }, /* vmovlps / vmovhlps */ + { { 0x12 }, 2, F, R, pfx_66, WIG, L0 }, /* vmovlpd */ + { { 0x12 }, 2, T, R, pfx_f3, WIG, Ln }, /* vmovsldup */ + { { 0x12 }, 2, T, R, pfx_f2, WIG, Ln }, /* vmovddup */ + { { 0x13 }, 2, F, W, pfx_no, WIG, L0 }, /* vmovlps */ + { { 0x13 }, 2, F, W, pfx_66, WIG, L0 }, /* vmovlpd */ + { { 0x14 }, 2, T, R, pfx_no, WIG, Ln }, /* vunpcklps */ + { { 0x14 }, 2, T, R, pfx_66, WIG, Ln }, /* vunpcklpd */ + { { 0x15 }, 2, T, R, pfx_no, WIG, Ln }, /* vunpckhps */ + { { 0x15 }, 2, T, R, pfx_66, WIG, Ln }, /* vunpckhpd */ + { { 0x16 }, 2, T, R, pfx_no, WIG, L0 }, /* vmovhps / vmovlhps */ + { { 0x16 }, 2, F, R, pfx_66, WIG, L0 }, /* vmovhpd */ + { { 0x16 }, 2, T, R, pfx_f3, WIG, Ln }, /* vmovshdup */ + { { 0x17 }, 2, F, W, pfx_no, WIG, L0 }, /* vmovhps */ + { { 0x17 }, 2, F, W, pfx_66, WIG, L0 }, /* vmovhpd */ + { { 0x28 }, 2, T, R, pfx_no, WIG, Ln }, /* vmovaps */ + { { 0x28 }, 2, T, R, pfx_66, WIG, Ln }, /* vmovapd */ + { { 0x29 }, 2, T, W, pfx_no, WIG, Ln }, /* vmovaps */ + { { 0x29 }, 2, T, W, pfx_66, WIG, Ln }, /* vmovapd */ + { { 0x2a }, 2, T, R, pfx_f3, Wn, LIG }, /* vcvtsi2ss */ + { { 0x2a }, 2, T, R, pfx_f2, Wn, LIG }, /* vcvtsi2sd */ + { { 0x2b }, 2, T, W, pfx_no, WIG, Ln }, /* vmovntps */ + { { 0x2b }, 2, T, W, pfx_66, WIG, Ln }, /* vmovntpd */ + { { 0x2c }, 2, T, R, pfx_f3, Wn, LIG }, /* vcvttss2si */ + { { 0x2c }, 2, T, R, pfx_f2, Wn, LIG }, /* vcvttsd2si */ + { { 0x2d }, 2, T, R, pfx_f3, Wn, LIG }, /* vcvtss2si */ + { { 0x2d }, 2, T, R, pfx_f2, Wn, LIG }, /* vcvtsd2si */ + { { 0x2e }, 2, T, R, pfx_no, WIG, LIG }, /* vucomiss */ + { { 0x2e }, 2, T, R, pfx_66, WIG, LIG }, /* vucomisd */ + { { 0x2f }, 2, T, R, pfx_no, WIG, LIG }, /* vcomiss */ + { { 0x2f }, 2, T, R, pfx_66, WIG, LIG }, /* vcomisd */ + { { 0x41, 0xc0 }, 2, F, N, pfx_no, Wn, L1 }, /* kand{w,q} */ + { { 0x41, 0xc0 }, 2, F, N, pfx_66, Wn, L1 }, /* kand{b,d} */ + { { 0x42, 0xc0 }, 2, F, N, pfx_no, Wn, L1 }, /* kandn{w,q} */ + { { 0x42, 0xc0 }, 2, F, N, pfx_66, Wn, L1 }, /* kandn{b,d} */ + { { 0x44, 0xc0 }, 2, F, N, pfx_no, Wn, L0 }, /* knot{w,q} */ + { { 0x44, 0xc0 }, 2, F, N, pfx_66, Wn, L0 }, /* knot{b,d} */ + { { 0x45, 0xc0 }, 2, F, N, pfx_no, Wn, L1 }, /* kor{w,q} */ + { { 0x45, 0xc0 }, 2, F, N, pfx_66, Wn, L1 }, /* kor{b,d} */ + { { 0x46, 0xc0 }, 2, F, N, pfx_no, Wn, L1 }, /* kxnor{w,q} */ + { { 0x46, 0xc0 }, 2, F, N, pfx_66, Wn, L1 }, /* kxnor{b,d} */ + { { 0x47, 0xc0 }, 2, F, N, pfx_no, Wn, L1 }, /* kxor{w,q} */ + { { 0x47, 0xc0 }, 2, F, N, pfx_66, Wn, L1 }, /* kxor{b,d} */ + { { 0x4a, 0xc0 }, 2, F, N, pfx_no, Wn, L1 }, /* kadd{w,q} */ + { { 0x4a, 0xc0 }, 2, F, N, pfx_66, Wn, L1 }, /* kadd{b,d} */ + { { 0x4b, 0xc0 }, 2, F, N, pfx_no, Wn, L1 }, /* kunpck{wd,dq} */ + { { 0x4b, 0xc0 }, 2, F, N, pfx_66, W0, L1 }, /* kunpckbw */ + { { 0x50, 0xc0 }, 2, F, N, pfx_no, WIG, Ln }, /* vmovmskps */ + { { 0x50, 0xc0 }, 2, F, N, pfx_66, WIG, Ln }, /* vmovmskpd */ + { { 0x51 }, 2, T, R, pfx_no, WIG, Ln }, /* vsqrtps */ + { { 0x51 }, 2, T, R, pfx_66, WIG, Ln }, /* vsqrtpd */ + { { 0x51 }, 2, T, R, pfx_f3, WIG, LIG }, /* vsqrtss */ + { { 0x51 }, 2, T, R, pfx_f2, WIG, LIG }, /* vsqrtsd */ + { { 0x52 }, 2, T, R, pfx_no, WIG, Ln }, /* vrsqrtps */ + { { 0x52 }, 2, T, R, pfx_f3, WIG, LIG }, /* vrsqrtss */ + { { 0x53 }, 2, T, R, pfx_no, WIG, Ln }, /* vrcpps */ + { { 0x53 }, 2, T, R, pfx_f3, WIG, LIG }, /* vrcpss */ + { { 0x54 }, 2, T, R, pfx_no, WIG, Ln }, /* vandps */ + { { 0x54 }, 2, T, R, pfx_66, WIG, Ln }, /* vandpd */ + { { 0x55 }, 2, T, R, pfx_no, WIG, Ln }, /* vandnps */ + { { 0x55 }, 2, T, R, pfx_66, WIG, Ln }, /* vandnpd */ + { { 0x56 }, 2, T, R, pfx_no, WIG, Ln }, /* vorps */ + { { 0x56 }, 2, T, R, pfx_66, WIG, Ln }, /* vorpd */ + { { 0x57 }, 2, T, R, pfx_no, WIG, Ln }, /* vxorps */ + { { 0x57 }, 2, T, R, pfx_66, WIG, Ln }, /* vxorpd */ + { { 0x58 }, 2, T, R, pfx_no, WIG, Ln }, /* vaddps */ + { { 0x58 }, 2, T, R, pfx_66, WIG, Ln }, /* vaddpd */ + { { 0x58 }, 2, T, R, pfx_f3, WIG, LIG }, /* vaddss */ + { { 0x58 }, 2, T, R, pfx_f2, WIG, LIG }, /* vaddsd */ + { { 0x59 }, 2, T, R, pfx_no, WIG, Ln }, /* vmulps */ + { { 0x59 }, 2, T, R, pfx_66, WIG, Ln }, /* vmulpd */ + { { 0x59 }, 2, T, R, pfx_f3, WIG, LIG }, /* vmulss */ + { { 0x59 }, 2, T, R, pfx_f2, WIG, LIG }, /* vmulsd */ + { { 0x5a }, 2, T, R, pfx_no, WIG, Ln }, /* vcvtps2pd */ + { { 0x5a }, 2, T, R, pfx_66, WIG, Ln }, /* vcvtpd2ps */ + { { 0x5a }, 2, T, R, pfx_f3, WIG, LIG }, /* vcvtss2sd */ + { { 0x5a }, 2, T, R, pfx_f2, WIG, LIG }, /* vcvtsd2ss */ + { { 0x5b }, 2, T, R, pfx_no, WIG, Ln }, /* vcvtdq2ps */ + { { 0x5b }, 2, T, R, pfx_66, WIG, Ln }, /* vcvtps2dq */ + { { 0x5b }, 2, T, R, pfx_f3, WIG, Ln }, /* vcvttps2dq */ + { { 0x5c }, 2, T, R, pfx_no, WIG, Ln }, /* vsubps */ + { { 0x5c }, 2, T, R, pfx_66, WIG, Ln }, /* vsubpd */ + { { 0x5c }, 2, T, R, pfx_f3, WIG, LIG }, /* vsubss */ + { { 0x5c }, 2, T, R, pfx_f2, WIG, LIG }, /* vsubsd */ + { { 0x5d }, 2, T, R, pfx_no, WIG, Ln }, /* vminps */ + { { 0x5d }, 2, T, R, pfx_66, WIG, Ln }, /* vminpd */ + { { 0x5d }, 2, T, R, pfx_f3, WIG, LIG }, /* vminss */ + { { 0x5d }, 2, T, R, pfx_f2, WIG, LIG }, /* vminsd */ + { { 0x5e }, 2, T, R, pfx_no, WIG, Ln }, /* vdivps */ + { { 0x5e }, 2, T, R, pfx_66, WIG, Ln }, /* vdivpd */ + { { 0x5e }, 2, T, R, pfx_f3, WIG, LIG }, /* vdivss */ + { { 0x5e }, 2, T, R, pfx_f2, WIG, LIG }, /* vdivsd */ + { { 0x5f }, 2, T, R, pfx_no, WIG, Ln }, /* vmaxps */ + { { 0x5f }, 2, T, R, pfx_66, WIG, Ln }, /* vmaxpd */ + { { 0x5f }, 2, T, R, pfx_f3, WIG, LIG }, /* vmaxss */ + { { 0x5f }, 2, T, R, pfx_f2, WIG, LIG }, /* vmaxsd */ + { { 0x60 }, 2, T, R, pfx_66, WIG, Ln }, /* vpunpcklbw */ + { { 0x61 }, 2, T, R, pfx_66, WIG, Ln }, /* vpunpcklwd */ + { { 0x62 }, 2, T, R, pfx_66, WIG, Ln }, /* vpunpckldq */ + { { 0x63 }, 2, T, R, pfx_66, WIG, Ln }, /* vpacksswb */ + { { 0x64 }, 2, T, R, pfx_66, WIG, Ln }, /* vpcmpgtb */ + { { 0x65 }, 2, T, R, pfx_66, WIG, Ln }, /* vpcmpgtw */ + { { 0x66 }, 2, T, R, pfx_66, WIG, Ln }, /* vpcmpgtd */ + { { 0x67 }, 2, T, R, pfx_66, WIG, Ln }, /* vpackuswb */ + { { 0x68 }, 2, T, R, pfx_66, WIG, Ln }, /* vpunpckhbw */ + { { 0x69 }, 2, T, R, pfx_66, WIG, Ln }, /* vpunpckhwd */ + { { 0x6a }, 2, T, R, pfx_66, WIG, Ln }, /* vpunpckhdq */ + { { 0x6b }, 2, T, R, pfx_66, WIG, Ln }, /* vpackssdw */ + { { 0x6c }, 2, T, R, pfx_66, WIG, Ln }, /* vpunpcklqdq */ + { { 0x6d }, 2, T, R, pfx_66, WIG, Ln }, /* vpunpckhqdq */ + { { 0x6e }, 2, T, R, pfx_66, Wn, L0 }, /* vmov{d,q} */ + { { 0x6f }, 2, T, R, pfx_66, WIG, Ln }, /* vmovdqa */ + { { 0x6f }, 2, T, R, pfx_f3, WIG, Ln }, /* vmovdqu */ + { { 0x70 }, 3, T, R, pfx_66, WIG, Ln }, /* vpshufd */ + { { 0x70 }, 3, T, R, pfx_f3, WIG, Ln }, /* vpshuflw */ + { { 0x70 }, 3, T, R, pfx_f2, WIG, Ln }, /* vpshufhw */ + { { 0x71, 0xd0 }, 3, F, N, pfx_66, WIG, Ln }, /* vpsrlw */ + { { 0x71, 0xe0 }, 3, F, N, pfx_66, WIG, Ln }, /* vpsraw */ + { { 0x71, 0xf0 }, 3, F, N, pfx_66, WIG, Ln }, /* vpsllw */ + { { 0x72, 0xd0 }, 3, F, N, pfx_66, WIG, Ln }, /* vpsrld */ + { { 0x72, 0xe0 }, 3, F, N, pfx_66, WIG, Ln }, /* vpsrad */ + { { 0x72, 0xf0 }, 3, F, N, pfx_66, WIG, Ln }, /* vpslld */ + { { 0x73, 0xd0 }, 3, F, N, pfx_66, WIG, Ln }, /* vpsrlq */ + { { 0x73, 0xd8 }, 3, F, N, pfx_66, WIG, Ln }, /* vpsrldq */ + { { 0x73, 0xf0 }, 3, F, N, pfx_66, WIG, Ln }, /* vpsllq */ + { { 0x73, 0xf8 }, 3, F, N, pfx_66, WIG, Ln }, /* vpslldq */ + { { 0x74 }, 2, T, R, pfx_66, WIG, Ln }, /* vpcmpeqb */ + { { 0x75 }, 2, T, R, pfx_66, WIG, Ln }, /* vpcmpeqw */ + { { 0x76 }, 2, T, R, pfx_66, WIG, Ln }, /* vpcmpeqd */ + { { 0x77 }, 1, F, N, pfx_no, WIG, Ln }, /* vzero{upper,all} */ + { { 0x7c }, 2, T, R, pfx_66, WIG, Ln }, /* vhaddpd */ + { { 0x7c }, 2, T, R, pfx_f2, WIG, Ln }, /* vhaddps */ + { { 0x7d }, 2, T, R, pfx_66, WIG, Ln }, /* vhsubpd */ + { { 0x7d }, 2, T, R, pfx_f2, WIG, Ln }, /* vhsubps */ + { { 0x7e }, 2, T, W, pfx_66, Wn, L0 }, /* vmov{d,q} */ + { { 0x7e }, 2, T, R, pfx_f3, WIG, L0 }, /* vmovq */ + { { 0x7f }, 2, T, W, pfx_66, WIG, Ln }, /* vmovdqa */ + { { 0x7f }, 2, T, W, pfx_f3, WIG, Ln }, /* vmovdqu */ + { { 0x90 }, 2, T, R, pfx_no, Wn, L0 }, /* kmov{w,q} */ + { { 0x90 }, 2, T, R, pfx_66, Wn, L0 }, /* kmov{b,d} */ + { { 0x91 }, 2, N, W, pfx_no, Wn, L0 }, /* kmov{w,q} */ + { { 0x91 }, 2, N, W, pfx_66, Wn, L0 }, /* kmov{b,d} */ + { { 0x92, 0xc0 }, 2, F, N, pfx_no, W0, L0 }, /* kmovw */ + { { 0x92, 0xc0 }, 2, F, N, pfx_66, W0, L0 }, /* kmovb */ + { { 0x92, 0xc0 }, 2, F, N, pfx_f2, Wn, L0 }, /* kmov{d,q} */ + { { 0x93, 0xc0 }, 2, F, N, pfx_no, W0, L0 }, /* kmovw */ + { { 0x93, 0xc0 }, 2, F, N, pfx_66, W0, L0 }, /* kmovb */ + { { 0x93, 0xc0 }, 2, F, N, pfx_f2, Wn, L0 }, /* kmov{d,q} */ + { { 0x98, 0xc0 }, 2, F, N, pfx_no, Wn, L0 }, /* kortest{w,q} */ + { { 0x98, 0xc0 }, 2, F, N, pfx_66, Wn, L0 }, /* kortest{b,d} */ + { { 0x99, 0xc0 }, 2, F, N, pfx_no, Wn, L0 }, /* ktest{w,q} */ + { { 0x99, 0xc0 }, 2, F, N, pfx_66, Wn, L0 }, /* ktest{b,d} */ + { { 0xae, 0x10 }, 2, F, R, pfx_no, WIG, L0 }, /* vldmxcsr */ + { { 0xae, 0x18 }, 2, F, W, pfx_no, WIG, L0 }, /* vstmxcsr */ + { { 0xc2 }, 3, T, R, pfx_no, WIG, Ln }, /* vcmpps */ + { { 0xc2 }, 3, T, R, pfx_66, WIG, Ln }, /* vcmppd */ + { { 0xc2 }, 3, T, R, pfx_f3, WIG, LIG }, /* vcmpss */ + { { 0xc2 }, 3, T, R, pfx_f2, WIG, LIG }, /* vcmpsd */ + { { 0xc4 }, 3, T, R, pfx_66, WIG, L0 }, /* vpinsrw */ + { { 0xc5, 0xc0 }, 3, F, N, pfx_66, WIG, L0 }, /* vpextrw */ + { { 0xc6 }, 3, T, R, pfx_no, WIG, Ln }, /* vshufps */ + { { 0xc6 }, 3, T, R, pfx_66, WIG, Ln }, /* vshufpd */ + { { 0xd0 }, 2, T, R, pfx_66, WIG, Ln }, /* vaddsubpd */ + { { 0xd0 }, 2, T, R, pfx_f2, WIG, Ln }, /* vaddsubps */ + { { 0xd1 }, 2, T, R, pfx_66, WIG, Ln }, /* vpsrlw */ + { { 0xd2 }, 2, T, R, pfx_66, WIG, Ln }, /* vpsrld */ + { { 0xd3 }, 2, T, R, pfx_66, WIG, Ln }, /* vpsrlq */ + { { 0xd4 }, 2, T, R, pfx_66, WIG, Ln }, /* vpaddq */ + { { 0xd5 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmullw */ + { { 0xd6 }, 2, T, W, pfx_66, WIG, L0 }, /* vmovq */ + { { 0xd7, 0xc0 }, 2, F, N, pfx_66, WIG, Ln }, /* vpmovmskb */ + { { 0xd8 }, 2, T, R, pfx_66, WIG, Ln }, /* vpsubusb */ + { { 0xd9 }, 2, T, R, pfx_66, WIG, Ln }, /* vpsubusw */ + { { 0xda }, 2, T, R, pfx_66, WIG, Ln }, /* vpminub */ + { { 0xdb }, 2, T, R, pfx_66, WIG, Ln }, /* vpand */ + { { 0xdc }, 2, T, R, pfx_66, WIG, Ln }, /* vpaddusb */ + { { 0xdd }, 2, T, R, pfx_66, WIG, Ln }, /* vpaddusw */ + { { 0xde }, 2, T, R, pfx_66, WIG, Ln }, /* vpmaxub */ + { { 0xdf }, 2, T, R, pfx_66, WIG, Ln }, /* vpandn */ + { { 0xe0 }, 2, T, R, pfx_66, WIG, Ln }, /* vpavgb */ + { { 0xe1 }, 2, T, R, pfx_66, WIG, Ln }, /* vpsraw */ + { { 0xe2 }, 2, T, R, pfx_66, WIG, Ln }, /* vpsrad */ + { { 0xe3 }, 2, T, R, pfx_66, WIG, Ln }, /* vpavgw */ + { { 0xe4 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmulhuw */ + { { 0xe5 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmulhw */ + { { 0xe6 }, 2, T, R, pfx_66, WIG, Ln }, /* vcvttpd2dq */ + { { 0xe6 }, 2, T, R, pfx_f3, WIG, Ln }, /* vcvtdq2pd */ + { { 0xe6 }, 2, T, R, pfx_f2, WIG, Ln }, /* vcvtpd2dq */ + { { 0xe7 }, 2, F, W, pfx_66, WIG, Ln }, /* vmovntdq */ + { { 0xe8 }, 2, T, R, pfx_66, WIG, Ln }, /* vpsubsb */ + { { 0xe9 }, 2, T, R, pfx_66, WIG, Ln }, /* vpsubsw */ + { { 0xea }, 2, T, R, pfx_66, WIG, Ln }, /* vpminsw */ + { { 0xeb }, 2, T, R, pfx_66, WIG, Ln }, /* vpor */ + { { 0xec }, 2, T, R, pfx_66, WIG, Ln }, /* vpaddsb */ + { { 0xed }, 2, T, R, pfx_66, WIG, Ln }, /* vpaddsw */ + { { 0xee }, 2, T, R, pfx_66, WIG, Ln }, /* vpmaxsw */ + { { 0xef }, 2, T, R, pfx_66, WIG, Ln }, /* vpxor */ + { { 0xf0 }, 2, T, R, pfx_f2, WIG, Ln }, /* vlddqu */ + { { 0xf1 }, 2, T, R, pfx_66, WIG, Ln }, /* vpsllw */ + { { 0xf2 }, 2, T, R, pfx_66, WIG, Ln }, /* vpslld */ + { { 0xf3 }, 2, T, R, pfx_66, WIG, Ln }, /* vpsllq */ + { { 0xf4 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmuludq */ + { { 0xf5 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmaddwd */ + { { 0xf6 }, 2, T, R, pfx_66, WIG, Ln }, /* vpsadbw */ + { { 0xf7, 0xc0 }, 2, F, W, pfx_66, WIG, L0 }, /* vmaskmovdqu */ + { { 0xf8 }, 2, T, R, pfx_66, WIG, Ln }, /* vpsubb */ + { { 0xf9 }, 2, T, R, pfx_66, WIG, Ln }, /* vpsubw */ + { { 0xfa }, 2, T, R, pfx_66, WIG, Ln }, /* vpsubd */ + { { 0xfb }, 2, T, R, pfx_66, WIG, Ln }, /* vpsubq */ + { { 0xfc }, 2, T, R, pfx_66, WIG, Ln }, /* vpaddb */ + { { 0xfd }, 2, T, R, pfx_66, WIG, Ln }, /* vpaddw */ + { { 0xfe }, 2, T, R, pfx_66, WIG, Ln }, /* vpaddd */ +}, vex_0f38[] = { + { { 0x00 }, 2, T, R, pfx_66, WIG, Ln }, /* vpshufb */ + { { 0x01 }, 2, T, R, pfx_66, WIG, Ln }, /* vphaddw */ + { { 0x02 }, 2, T, R, pfx_66, WIG, Ln }, /* vphaddd */ + { { 0x03 }, 2, T, R, pfx_66, WIG, Ln }, /* vphaddsw */ + { { 0x04 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmaddubsw */ + { { 0x05 }, 2, T, R, pfx_66, WIG, Ln }, /* vphsubw */ + { { 0x06 }, 2, T, R, pfx_66, WIG, Ln }, /* vphsubd */ + { { 0x07 }, 2, T, R, pfx_66, WIG, Ln }, /* vphsubsw */ + { { 0x08 }, 2, T, R, pfx_66, WIG, Ln }, /* vpsignb */ + { { 0x09 }, 2, T, R, pfx_66, WIG, Ln }, /* vpsignw */ + { { 0x0a }, 2, T, R, pfx_66, WIG, Ln }, /* vpsignd */ + { { 0x0b }, 2, T, R, pfx_66, WIG, Ln }, /* vpmulhrsw */ + { { 0x0c }, 2, T, R, pfx_66, W0, Ln }, /* vpermilps */ + { { 0x0d }, 2, T, R, pfx_66, W0, Ln }, /* vpermilpd */ + { { 0x0e }, 2, T, R, pfx_66, W0, Ln }, /* vtestps */ + { { 0x0f }, 2, T, R, pfx_66, W0, Ln }, /* vtestpd */ + { { 0x13 }, 2, T, R, pfx_66, W0, Ln }, /* vcvtph2ps */ + { { 0x16 }, 2, T, R, pfx_66, W0, L1 }, /* vpermps */ + { { 0x17 }, 2, T, R, pfx_66, WIG, Ln }, /* vptest */ + { { 0x18 }, 2, T, R, pfx_66, W0, Ln }, /* vbroadcastss */ + { { 0x19 }, 2, T, R, pfx_66, W0, L1 }, /* vbroadcastsd */ + { { 0x1a }, 2, F, R, pfx_66, W0, L1 }, /* vbroadcastf128 */ + { { 0x1c }, 2, T, R, pfx_66, WIG, Ln }, /* vpabsb */ + { { 0x1d }, 2, T, R, pfx_66, WIG, Ln }, /* vpabsw */ + { { 0x1e }, 2, T, R, pfx_66, WIG, Ln }, /* vpabsd */ + { { 0x20 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmovsxbw */ + { { 0x21 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmovsxbd */ + { { 0x22 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmovsxbq */ + { { 0x23 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmovsxwd */ + { { 0x24 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmovsxwq */ + { { 0x25 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmovsxdq */ + { { 0x28 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmuldq */ + { { 0x29 }, 2, T, R, pfx_66, WIG, Ln }, /* vpcmpeqq */ + { { 0x2a }, 2, F, R, pfx_66, WIG, Ln }, /* vmovntdqa */ + { { 0x2b }, 2, T, R, pfx_66, WIG, Ln }, /* vpackusdw */ + { { 0x2c }, 2, F, R, pfx_66, W0, Ln }, /* vmaskmovps */ + { { 0x2d }, 2, F, R, pfx_66, W0, Ln }, /* vmaskmovpd */ + { { 0x2e }, 2, F, W, pfx_66, W0, Ln }, /* vmaskmovps */ + { { 0x2f }, 2, F, W, pfx_66, W0, Ln }, /* vmaskmovpd */ + { { 0x30 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmovzxbw */ + { { 0x31 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmovzxbd */ + { { 0x32 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmovzxbq */ + { { 0x33 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmovzxwd */ + { { 0x34 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmovzxwq */ + { { 0x35 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmovzxdq */ + { { 0x36 }, 2, T, R, pfx_66, W0, L1 }, /* vpermd */ + { { 0x37 }, 2, T, R, pfx_66, WIG, Ln }, /* vpcmpgtq */ + { { 0x38 }, 2, T, R, pfx_66, WIG, Ln }, /* vpminsb */ + { { 0x39 }, 2, T, R, pfx_66, WIG, Ln }, /* vpminsd */ + { { 0x3a }, 2, T, R, pfx_66, WIG, Ln }, /* vpminuw */ + { { 0x3b }, 2, T, R, pfx_66, WIG, Ln }, /* vpminud */ + { { 0x3c }, 2, T, R, pfx_66, WIG, Ln }, /* vpmaxsb */ + { { 0x3d }, 2, T, R, pfx_66, WIG, Ln }, /* vpmaxsd */ + { { 0x3e }, 2, T, R, pfx_66, WIG, Ln }, /* vpmaxuw */ + { { 0x3f }, 2, T, R, pfx_66, WIG, Ln }, /* vpmaxud */ + { { 0x40 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmulld */ + { { 0x41 }, 2, T, R, pfx_66, WIG, L0 }, /* vphminposuw */ + { { 0x45 }, 2, T, R, pfx_66, Wn, Ln }, /* vpsrlv{d,q} */ + { { 0x46 }, 2, T, R, pfx_66, W0, Ln }, /* vpsravd */ + { { 0x47 }, 2, T, R, pfx_66, Wn, Ln }, /* vpsllv{d,q} */ + { { 0x58 }, 2, T, R, pfx_66, W0, Ln }, /* vpbroadcastd */ + { { 0x59 }, 2, T, R, pfx_66, W0, Ln }, /* vpbroadcastq */ + { { 0x5a }, 2, F, R, pfx_66, W0, L1 }, /* vbroadcasti128 */ + { { 0x78 }, 2, T, R, pfx_66, W0, Ln }, /* vpbroadcastb */ + { { 0x79 }, 2, T, R, pfx_66, W0, Ln }, /* vpbroadcastw */ + { { 0x8c }, 2, F, R, pfx_66, Wn, Ln }, /* vpmaskmov{d,q} */ + { { 0x8e }, 2, F, W, pfx_66, Wn, Ln }, /* vpmaskmov{d,q} */ + { { 0x90, VSIB(1) }, 3, F, R, pfx_66, Wn, Ln }, /* vpgatherd{d,q} */ + { { 0x91, VSIB(1) }, 3, F, R, pfx_66, Wn, Ln }, /* vpgatherq{d,q} */ + { { 0x92, VSIB(1) }, 3, F, R, pfx_66, Wn, Ln }, /* vgatherdp{s,d} */ + { { 0x93, VSIB(1) }, 3, F, R, pfx_66, Wn, Ln }, /* vgatherqp{s,d} */ + { { 0x96 }, 2, T, R, pfx_66, Wn, Ln }, /* vmaddsub132p{s,d} */ + { { 0x97 }, 2, T, R, pfx_66, Wn, Ln }, /* vmsubadd132p{s,d} */ + { { 0x98 }, 2, T, R, pfx_66, Wn, Ln }, /* vmadd132p{s,d} */ + { { 0x99 }, 2, T, R, pfx_66, Wn, LIG }, /* vmadd132s{s,d} */ + { { 0x9a }, 2, T, R, pfx_66, Wn, Ln }, /* vmsub132p{s,d} */ + { { 0x9b }, 2, T, R, pfx_66, Wn, LIG }, /* vmsub132s{s,d} */ + { { 0x9c }, 2, T, R, pfx_66, Wn, Ln }, /* vnmadd132p{s,d} */ + { { 0x9d }, 2, T, R, pfx_66, Wn, LIG }, /* vnmadd132s{s,d} */ + { { 0x9e }, 2, T, R, pfx_66, Wn, Ln }, /* vnmsub132p{s,d} */ + { { 0x9f }, 2, T, R, pfx_66, Wn, LIG }, /* vnmsub132s{s,d} */ + { { 0xa6 }, 2, T, R, pfx_66, Wn, Ln }, /* vmaddsub213p{s,d} */ + { { 0xa7 }, 2, T, R, pfx_66, Wn, Ln }, /* vmsubadd213p{s,d} */ + { { 0xa8 }, 2, T, R, pfx_66, Wn, Ln }, /* vmadd213p{s,d} */ + { { 0xa9 }, 2, T, R, pfx_66, Wn, LIG }, /* vmadd213s{s,d} */ + { { 0xaa }, 2, T, R, pfx_66, Wn, Ln }, /* vmsub213p{s,d} */ + { { 0xab }, 2, T, R, pfx_66, Wn, LIG }, /* vmsub213s{s,d} */ + { { 0xac }, 2, T, R, pfx_66, Wn, Ln }, /* vnmadd213p{s,d} */ + { { 0xad }, 2, T, R, pfx_66, Wn, LIG }, /* vnmadd213s{s,d} */ + { { 0xae }, 2, T, R, pfx_66, Wn, Ln }, /* vnmsub213p{s,d} */ + { { 0xaf }, 2, T, R, pfx_66, Wn, LIG }, /* vnmsub213s{s,d} */ + { { 0xb6 }, 2, T, R, pfx_66, Wn, Ln }, /* vmaddsub231p{s,d} */ + { { 0xb7 }, 2, T, R, pfx_66, Wn, Ln }, /* vmsubadd231p{s,d} */ + { { 0xb8 }, 2, T, R, pfx_66, Wn, Ln }, /* vmadd231p{s,d} */ + { { 0xb9 }, 2, T, R, pfx_66, Wn, LIG }, /* vmadd231s{s,d} */ + { { 0xba }, 2, T, R, pfx_66, Wn, Ln }, /* vmsub231p{s,d} */ + { { 0xbb }, 2, T, R, pfx_66, Wn, LIG }, /* vmsub231s{s,d} */ + { { 0xbc }, 2, T, R, pfx_66, Wn, Ln }, /* vnmadd231p{s,d} */ + { { 0xbd }, 2, T, R, pfx_66, Wn, LIG }, /* vnmadd231s{s,d} */ + { { 0xbe }, 2, T, R, pfx_66, Wn, Ln }, /* vnmsub231p{s,d} */ + { { 0xbf }, 2, T, R, pfx_66, Wn, LIG }, /* vnmsub231s{s,d} */ + { { 0xcf }, 2, T, R, pfx_66, W0, Ln }, /* vgf2p8mulb */ + { { 0xdb }, 2, T, R, pfx_66, WIG, L0 }, /* vaesimc */ + { { 0xdc }, 2, T, R, pfx_66, WIG, Ln }, /* vaesenc */ + { { 0xdd }, 2, T, R, pfx_66, WIG, Ln }, /* vaesenclast */ + { { 0xde }, 2, T, R, pfx_66, WIG, Ln }, /* vaesdec */ + { { 0xdf }, 2, T, R, pfx_66, WIG, Ln }, /* vaesdeclast */ + { { 0xf2 }, 2, T, R, pfx_no, Wn, L0 }, /* andn */ + { { 0xf3, 0x08 }, 2, T, R, pfx_no, Wn, L0 }, /* blsr */ + { { 0xf3, 0x10 }, 2, T, R, pfx_no, Wn, L0 }, /* blsmsk */ + { { 0xf3, 0x18 }, 2, T, R, pfx_no, Wn, L0 }, /* blsi */ + { { 0xf5 }, 2, T, R, pfx_no, Wn, L0 }, /* bzhi */ + { { 0xf5 }, 2, T, R, pfx_f3, Wn, L0 }, /* pext */ + { { 0xf5 }, 2, T, R, pfx_f2, Wn, L0 }, /* pdep */ + { { 0xf6 }, 2, T, R, pfx_f2, Wn, L0 }, /* mulx */ + { { 0xf7 }, 2, T, R, pfx_no, Wn, L0 }, /* bextr */ + { { 0xf7 }, 2, T, R, pfx_66, Wn, L0 }, /* shlx */ + { { 0xf7 }, 2, T, R, pfx_f3, Wn, L0 }, /* sarx */ + { { 0xf7 }, 2, T, R, pfx_f2, Wn, L0 }, /* shrx */ +}, vex_0f3a[] = { + { { 0x00 }, 3, T, R, pfx_66, W1, L1 }, /* vpermq */ + { { 0x01 }, 3, T, R, pfx_66, W1, L1 }, /* vpermpd */ + { { 0x02 }, 3, T, R, pfx_66, W0, Ln }, /* vpblendd */ + { { 0x04 }, 3, T, R, pfx_66, W0, Ln }, /* vpermilps */ + { { 0x05 }, 3, T, R, pfx_66, W0, Ln }, /* vpermilpd */ + { { 0x06 }, 3, T, R, pfx_66, W0, L1 }, /* vperm2f128 */ + { { 0x08 }, 3, T, R, pfx_66, WIG, Ln }, /* vroundps */ + { { 0x09 }, 3, T, R, pfx_66, WIG, Ln }, /* vroundpd */ + { { 0x0a }, 3, T, R, pfx_66, WIG, LIG }, /* vroundss */ + { { 0x0b }, 3, T, R, pfx_66, WIG, LIG }, /* vroundsd */ + { { 0x0c }, 3, T, R, pfx_66, WIG, Ln }, /* vblendps */ + { { 0x0d }, 3, T, R, pfx_66, WIG, Ln }, /* vblendpd */ + { { 0x0e }, 3, T, R, pfx_66, WIG, Ln }, /* vpblendw */ + { { 0x0f }, 3, T, R, pfx_66, WIG, Ln }, /* vpalignr */ + { { 0x14 }, 3, T, W, pfx_66, WIG, L0 }, /* vpextrb */ + { { 0x15 }, 3, T, W, pfx_66, WIG, L0 }, /* vpextrw */ + { { 0x16 }, 3, T, W, pfx_66, Wn, L0 }, /* vpextr{d,q} */ + { { 0x17 }, 3, T, W, pfx_66, WIG, L0 }, /* vextractps */ + { { 0x18 }, 3, T, R, pfx_66, W0, L1 }, /* vinsertf128 */ + { { 0x19 }, 3, T, W, pfx_66, W0, L1 }, /* vextractf128 */ + { { 0x1d }, 3, T, W, pfx_66, W0, Ln }, /* vcvtps2ph */ + { { 0x20 }, 3, T, R, pfx_66, WIG, L0 }, /* vpinsrb */ + { { 0x21 }, 3, T, R, pfx_66, WIG, L0 }, /* vinsertps */ + { { 0x22 }, 3, T, R, pfx_66, Wn, L0 }, /* vpinsr{d,q} */ + { { 0x30, 0xc0 }, 3, F, N, pfx_66, Wn, L0 }, /* kshiftr{b,w} */ + { { 0x31, 0xc0 }, 3, F, N, pfx_66, Wn, L0 }, /* kshiftr{d,q} */ + { { 0x32, 0xc0 }, 3, F, N, pfx_66, Wn, L0 }, /* kshiftl{b,w} */ + { { 0x33, 0xc0 }, 3, F, N, pfx_66, Wn, L0 }, /* kshiftl{d,q} */ + { { 0x38 }, 3, T, R, pfx_66, W0, L1 }, /* vinserti128 */ + { { 0x39 }, 3, T, W, pfx_66, W0, L1 }, /* vextracti128 */ + { { 0x40 }, 3, T, R, pfx_66, WIG, Ln }, /* vdpps */ + { { 0x41 }, 3, T, R, pfx_66, WIG, Ln }, /* vdppd */ + { { 0x42 }, 3, T, R, pfx_66, WIG, Ln }, /* vmpsadbw */ + { { 0x44 }, 3, T, R, pfx_66, WIG, Ln }, /* vpclmulqdq */ + { { 0x46 }, 3, T, R, pfx_66, W0, L1 }, /* vperm2i128 */ + { { 0x48 }, 3, T, R, pfx_66, Wn, Ln }, /* vpermil2ps */ + { { 0x49 }, 3, T, R, pfx_66, Wn, Ln }, /* vpermil2pd */ + { { 0x4a }, 3, T, R, pfx_66, W0, Ln }, /* vblendvps */ + { { 0x4b }, 3, T, R, pfx_66, W0, Ln }, /* vblendvpd */ + { { 0x4c }, 3, T, R, pfx_66, W0, Ln }, /* vpblendvb */ + { { 0x5c }, 3, T, R, pfx_66, Wn, Ln }, /* vfmaddsubps */ + { { 0x5d }, 3, T, R, pfx_66, Wn, Ln }, /* vfmaddsubpd */ + { { 0x5e }, 3, T, R, pfx_66, Wn, Ln }, /* vfmsubaddps */ + { { 0x5f }, 3, T, R, pfx_66, Wn, Ln }, /* vfmsubaddpd */ + { { 0x60 }, 3, T, R, pfx_66, WIG, L0 }, /* vpcmpestrm */ + { { 0x61 }, 3, T, R, pfx_66, WIG, L0 }, /* vpcmpestri */ + { { 0x62 }, 3, T, R, pfx_66, WIG, L0 }, /* vpcmpistrm */ + { { 0x63 }, 3, T, R, pfx_66, WIG, L0 }, /* vpcmpistri */ + { { 0x68 }, 3, T, R, pfx_66, Wn, Ln }, /* vfmaddps */ + { { 0x69 }, 3, T, R, pfx_66, Wn, Ln }, /* vfmaddpd */ + { { 0x6a }, 3, T, R, pfx_66, Wn, LIG }, /* vfmaddss */ + { { 0x6b }, 3, T, R, pfx_66, Wn, LIG }, /* vfmaddsd */ + { { 0x6c }, 3, T, R, pfx_66, Wn, Ln }, /* vfmsubps */ + { { 0x6d }, 3, T, R, pfx_66, Wn, Ln }, /* vfmsubpd */ + { { 0x6e }, 3, T, R, pfx_66, Wn, LIG }, /* vfmsubss */ + { { 0x6f }, 3, T, R, pfx_66, Wn, LIG }, /* vfmsubsd */ + { { 0x78 }, 3, T, R, pfx_66, Wn, Ln }, /* vfnmaddps */ + { { 0x79 }, 3, T, R, pfx_66, Wn, Ln }, /* vfnmaddpd */ + { { 0x7a }, 3, T, R, pfx_66, Wn, LIG }, /* vfnmaddss */ + { { 0x7b }, 3, T, R, pfx_66, Wn, LIG }, /* vfnmaddsd */ + { { 0x7c }, 3, T, R, pfx_66, Wn, Ln }, /* vfnmsubps */ + { { 0x7d }, 3, T, R, pfx_66, Wn, Ln }, /* vfnmsubpd */ + { { 0x7e }, 3, T, R, pfx_66, Wn, LIG }, /* vfnmsubss */ + { { 0x7f }, 3, T, R, pfx_66, Wn, LIG }, /* vfnmsubsd */ + { { 0xce }, 3, T, R, pfx_66, W1, Ln }, /* vgf2p8affineqb */ + { { 0xcf }, 3, T, R, pfx_66, W1, Ln }, /* vgf2p8affineinvqb */ + { { 0xdf }, 3, T, R, pfx_66, WIG, Ln }, /* vaeskeygenassist */ + { { 0xf0 }, 3, T, R, pfx_f2, Wn, L0 }, /* rorx */ +}; + +static const struct { + const struct vex *tbl; + unsigned int num; +} vex[] = { + { vex_0f, ARRAY_SIZE(vex_0f) }, + { vex_0f38, ARRAY_SIZE(vex_0f38) }, + { vex_0f3a, ARRAY_SIZE(vex_0f3a) }, +}; + +#undef Wn +#undef Ln + #undef F #undef N #undef R @@ -1125,7 +1568,7 @@ void predicates_test(void *instr, struct for ( m = 0; m < sizeof(long) / sizeof(int); ++m ) { - unsigned int t; + unsigned int t, x; ctxt->addr_size = 32 << m; ctxt->sp_size = 32 << m; @@ -1211,6 +1654,90 @@ void predicates_test(void *instr, struct ctxt, fetch); } + for ( t = 0; t < ARRAY_SIZE(vex_0f); ++t ) + { + if ( vex_0f[t].w == WIG || (vex_0f[t].w & W0) ) + { + uint8_t *ptr = instr; + + memset(instr + 3, 0xcc, 12); + + *ptr++ = 0xc5; + *ptr++ = 0xf8 | vex_0f[t].pfx; + memcpy(ptr, vex_0f[t].opc, vex_0f[t].len); + + if ( vex_0f[t].l == LIG || (vex_0f[t].l & L0) ) + do_test(instr, vex_0f[t].len + ((void *)ptr - instr), + vex_0f[t].modrm ? (void *)ptr - instr + 1 : 0, + vex_0f[t].mem, ctxt, fetch); + + if ( vex_0f[t].l == LIG || (vex_0f[t].l & L1) ) + { + ptr[-1] |= 4; + memcpy(ptr, vex_0f[t].opc, vex_0f[t].len); + + do_test(instr, vex_0f[t].len + ((void *)ptr - instr), + vex_0f[t].modrm ? (void *)ptr - instr + 1 : 0, + vex_0f[t].mem, ctxt, fetch); + } + } + } + + for ( x = 0; x < ARRAY_SIZE(vex); ++x ) + { + for ( t = 0; t < vex[x].num; ++t ) + { + uint8_t *ptr = instr; + + memset(instr + 4, 0xcc, 11); + + *ptr++ = 0xc4; + *ptr++ = 0xe1 + x; + *ptr++ = 0x78 | vex[x].tbl[t].pfx; + + if ( vex[x].tbl[t].w == WIG || (vex[x].tbl[t].w & W0) ) + { + memcpy(ptr, vex[x].tbl[t].opc, vex[x].tbl[t].len); + + if ( vex[x].tbl[t].l == LIG || (vex[x].tbl[t].l & L0) ) + do_test(instr, vex[x].tbl[t].len + ((void *)ptr - instr), + vex[x].tbl[t].modrm ? (void *)ptr - instr + 1 : 0, + vex[x].tbl[t].mem, ctxt, fetch); + + if ( vex[x].tbl[t].l == LIG || (vex[x].tbl[t].l & L1) ) + { + ptr[-1] |= 4; + memcpy(ptr, vex[x].tbl[t].opc, vex[x].tbl[t].len); + + do_test(instr, vex[x].tbl[t].len + ((void *)ptr - instr), + vex[x].tbl[t].modrm ? (void *)ptr - instr + 1 : 0, + vex[x].tbl[t].mem, ctxt, fetch); + } + } + + if ( vex[x].tbl[t].w == WIG || (vex[x].tbl[t].w & W1) ) + { + ptr[-1] = 0xf8 | vex[x].tbl[t].pfx; + memcpy(ptr, vex[x].tbl[t].opc, vex[x].tbl[t].len); + + if ( vex[x].tbl[t].l == LIG || (vex[x].tbl[t].l & L0) ) + do_test(instr, vex[x].tbl[t].len + ((void *)ptr - instr), + vex[x].tbl[t].modrm ? (void *)ptr - instr + 1 : 0, + vex[x].tbl[t].mem, ctxt, fetch); + + if ( vex[x].tbl[t].l == LIG || (vex[x].tbl[t].l & L1) ) + { + ptr[-1] |= 4; + memcpy(ptr, vex[x].tbl[t].opc, vex[x].tbl[t].len); + + do_test(instr, vex[x].tbl[t].len + ((void *)ptr - instr), + vex[x].tbl[t].modrm ? (void *)ptr - instr + 1 : 0, + vex[x].tbl[t].mem, ctxt, fetch); + } + } + } + } + if ( errors ) exit(1); From xen-devel-bounces@lists.xenproject.org Mon Aug 03 14:51:40 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 14:51:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2boR-00058L-MA; Mon, 03 Aug 2020 14:51:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2boR-000589-74 for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 14:51:39 +0000 X-Inumbo-ID: d543e01a-d598-11ea-9097-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d543e01a-d598-11ea-9097-bc764e2007e4; Mon, 03 Aug 2020 14:51:38 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C3768AC24; Mon, 3 Aug 2020 14:51:52 +0000 (UTC) Subject: [PATCH 05/10] x86emul: extend decoding / mem access testing to XOP-encoded insns From: Jan Beulich To: "xen-devel@lists.xenproject.org" References: <97ca3d9c-7540-c7b1-cf84-34c75c9127df@suse.com> Message-ID: Date: Mon, 3 Aug 2020 16:51:36 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <97ca3d9c-7540-c7b1-cf84-34c75c9127df@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Signed-off-by: Jan Beulich --- a/tools/tests/x86_emulator/predicates.c +++ b/tools/tests/x86_emulator/predicates.c @@ -1474,6 +1474,96 @@ static const struct { { vex_0f3a, ARRAY_SIZE(vex_0f3a) }, }; +static const struct xop { + uint8_t opc[2]; + uint8_t w:2; + uint8_t l:2; +} xop_08[] = { + { { 0x85 }, W0, L0 }, /* vpmacssww */ + { { 0x86 }, W0, L0 }, /* vpmacsswd */ + { { 0x87 }, W0, L0 }, /* vpmacssdql */ + { { 0x8e }, W0, L0 }, /* vpmacssdd */ + { { 0x8f }, W0, L0 }, /* vpmacssdqh */ + { { 0x95 }, W0, L0 }, /* vpmacsww */ + { { 0x96 }, W0, L0 }, /* vpmacswd */ + { { 0x97 }, W0, L0 }, /* vpmacsdql */ + { { 0x9e }, W0, L0 }, /* vpmacsdd */ + { { 0x9f }, W0, L0 }, /* vpmacsdqh */ + { { 0xa2 }, Wn, Ln }, /* vpcmov */ + { { 0xa3 }, Wn, L0 }, /* vpperm */ + { { 0xa6 }, W0, L0 }, /* vpmadcsswd */ + { { 0xb6 }, W0, L0 }, /* vpmadcswd */ + { { 0xc0 }, W0, L0 }, /* vprotb */ + { { 0xc1 }, W0, L0 }, /* vprotw */ + { { 0xc2 }, W0, L0 }, /* vprotd */ + { { 0xc3 }, W0, L0 }, /* vprotq */ + { { 0xcc }, W0, L0 }, /* vpcomb */ + { { 0xcd }, W0, L0 }, /* vpcomw */ + { { 0xce }, W0, L0 }, /* vpcomd */ + { { 0xcf }, W0, L0 }, /* vpcomq */ + { { 0xec }, W0, L0 }, /* vpcomub */ + { { 0xed }, W0, L0 }, /* vpcomuw */ + { { 0xee }, W0, L0 }, /* vpcomud */ + { { 0xef }, W0, L0 }, /* vpcomuq */ +}, xop_09[] = { + { { 0x01, 0x08 }, Wn, L0 }, /* blcfill */ + { { 0x01, 0x10 }, Wn, L0 }, /* blsfill */ + { { 0x01, 0x18 }, Wn, L0 }, /* blcs */ + { { 0x01, 0x20 }, Wn, L0 }, /* tzmsk */ + { { 0x01, 0x28 }, Wn, L0 }, /* blcic */ + { { 0x01, 0x30 }, Wn, L0 }, /* blsic */ + { { 0x01, 0x38 }, Wn, L0 }, /* t1mskc */ + { { 0x02, 0x08 }, Wn, L0 }, /* blcmsk */ + { { 0x02, 0x30 }, Wn, L0 }, /* blci */ + { { 0x02, 0xc0 }, Wn, L0 }, /* llwpcb */ + { { 0x02, 0xc8 }, Wn, L0 }, /* slwpcb */ + { { 0x80 }, W0, Ln }, /* vfrczps */ + { { 0x81 }, W0, Ln }, /* vfrczpd */ + { { 0x82 }, W0, L0 }, /* vfrczss */ + { { 0x83 }, W0, L0 }, /* vfrczsd */ + { { 0x90 }, Wn, L0 }, /* vprotb */ + { { 0x91 }, Wn, L0 }, /* vprotw */ + { { 0x92 }, Wn, L0 }, /* vprotd */ + { { 0x93 }, Wn, L0 }, /* vprotq */ + { { 0x94 }, Wn, L0 }, /* vpshlb */ + { { 0x95 }, Wn, L0 }, /* vpshlw */ + { { 0x96 }, Wn, L0 }, /* vpshld */ + { { 0x97 }, Wn, L0 }, /* vpshlq */ + { { 0x9c }, Wn, L0 }, /* vpshab */ + { { 0x9d }, Wn, L0 }, /* vpshaw */ + { { 0x9e }, Wn, L0 }, /* vpshad */ + { { 0x9f }, Wn, L0 }, /* vpshaq */ + { { 0xc1 }, W0, L0 }, /* vphaddbw */ + { { 0xc2 }, W0, L0 }, /* vphaddbd */ + { { 0xc3 }, W0, L0 }, /* vphaddbq */ + { { 0xc6 }, W0, L0 }, /* vphaddwd */ + { { 0xc7 }, W0, L0 }, /* vphaddwq */ + { { 0xcb }, W0, L0 }, /* vphadddq */ + { { 0xd1 }, W0, L0 }, /* vphaddubw */ + { { 0xd2 }, W0, L0 }, /* vphaddubd */ + { { 0xd3 }, W0, L0 }, /* vphaddubq */ + { { 0xd6 }, W0, L0 }, /* vphadduwd */ + { { 0xd7 }, W0, L0 }, /* vphadduwq */ + { { 0xdb }, W0, L0 }, /* vphaddudq */ + { { 0xe1 }, W0, L0 }, /* vphsubbw */ + { { 0xe2 }, W0, L0 }, /* vphsubwd */ + { { 0xe3 }, W0, L0 }, /* vphsubdq */ +}, xop_0a[] = { + { { 0x10 }, Wn, L0 }, /* bextr */ + { { 0x12, 0x00 }, Wn, L0 }, /* lwpins */ + { { 0x12, 0x08 }, Wn, L0 }, /* lwpval */ +}; + +static const struct { + const struct xop *tbl; + unsigned int num; + unsigned int imm; +} xop[] = { + { xop_08, ARRAY_SIZE(xop_08), 1 }, + { xop_09, ARRAY_SIZE(xop_09), 0 }, + { xop_0a, ARRAY_SIZE(xop_0a), 4 }, +}; + #undef Wn #undef Ln @@ -1736,6 +1826,63 @@ void predicates_test(void *instr, struct } } } + } + + for ( x = 0; x < ARRAY_SIZE(xop); ++x ) + { + for ( t = 0; t < xop[x].num; ++t ) + { + uint8_t *ptr = instr; + unsigned int modrm; + enum mem_access mem; + + memset(instr + 5, 0xcc, 10); + + *ptr++ = 0x8f; + *ptr++ = 0xe8 + x; + *ptr++ = 0x78; + memcpy(ptr, xop[x].tbl[t].opc, 2); + memset(ptr + 2, 0, xop[x].imm); + + modrm = ptr[1] & 0xc0 ? 0 : 4; + mem = ptr[1] & 0xc0 ? mem_none : mem_read; + + assert(xop[x].tbl[t].w != WIG); + assert(xop[x].tbl[t].l != LIG); + + if ( xop[x].tbl[t].w & W0 ) + { + if ( xop[x].tbl[t].l & L0 ) + do_test(instr, 5 + xop[x].imm, modrm, mem, ctxt, fetch); + + if ( xop[x].tbl[t].l & L1 ) + { + ptr[-1] = 0x7c; + ptr[1] = mem != mem_none ? 0x00 : 0xc0; + + do_test(instr, 5 + xop[x].imm, modrm, mem, ctxt, fetch); + } + } + + if ( xop[x].tbl[t].w & W1 ) + { + if ( xop[x].tbl[t].l & L0 ) + { + ptr[-1] = 0xf8; + ptr[1] = mem != mem_none ? 0x00 : 0xc0; + + do_test(instr, 5 + xop[x].imm, modrm, mem, ctxt, fetch); + } + + if ( xop[x].tbl[t].l & L1 ) + { + ptr[-1] = 0xfc; + ptr[1] = mem != mem_none ? 0x00 : 0xc0; + + do_test(instr, 5 + xop[x].imm, modrm, mem, ctxt, fetch); + } + } + } } if ( errors ) From xen-devel-bounces@lists.xenproject.org Mon Aug 03 14:52:40 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 14:52:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2bpQ-0005Kf-13; Mon, 03 Aug 2020 14:52:40 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2bpP-0005KW-7k for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 14:52:39 +0000 X-Inumbo-ID: f8d0e709-d598-11ea-af3a-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f8d0e709-d598-11ea-af3a-12813bfff9fa; Mon, 03 Aug 2020 14:52:38 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F16DCAC24; Mon, 3 Aug 2020 14:52:52 +0000 (UTC) Subject: [PATCH 06/10] x86emul: AVX512{F, BW} down conversion moves are memory writes From: Jan Beulich To: "xen-devel@lists.xenproject.org" References: <97ca3d9c-7540-c7b1-cf84-34c75c9127df@suse.com> Message-ID: <1995835d-62f8-a372-25f0-80c20ada54c8@suse.com> Date: Mon, 3 Aug 2020 16:52:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <97ca3d9c-7540-c7b1-cf84-34c75c9127df@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" For this to be properly reported, the case labels need to move to a different switch() block. Fixes: 30e0bdf79828 ("x86emul: support AVX512{F,BW} down conversion moves") Signed-off-by: Jan Beulich --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -12359,6 +12359,14 @@ x86_insn_is_mem_write(const struct x86_e case X86EMUL_OPC_F2(0x0f38, 0xf8): /* ENQCMD */ case X86EMUL_OPC_F3(0x0f38, 0xf8): /* ENQCMDS */ return true; + + case X86EMUL_OPC_EVEX_F3(0x0f38, 0x10) ... + X86EMUL_OPC_EVEX_F3(0x0f38, 0x15): /* VPMOVUS* */ + case X86EMUL_OPC_EVEX_F3(0x0f38, 0x20) ... + X86EMUL_OPC_EVEX_F3(0x0f38, 0x25): /* VPMOVS* */ + case X86EMUL_OPC_EVEX_F3(0x0f38, 0x30) ... + X86EMUL_OPC_EVEX_F3(0x0f38, 0x35): /* VPMOV{D,Q,W}* */ + return state->modrm_mod != 3; } return false; @@ -12400,12 +12408,6 @@ x86_insn_is_mem_write(const struct x86_e case X86EMUL_OPC(0x0f, 0xab): /* BTS */ case X86EMUL_OPC(0x0f, 0xb3): /* BTR */ case X86EMUL_OPC(0x0f, 0xbb): /* BTC */ - case X86EMUL_OPC_EVEX_F3(0x0f38, 0x10) ... - X86EMUL_OPC_EVEX_F3(0x0f38, 0x15): /* VPMOVUS* */ - case X86EMUL_OPC_EVEX_F3(0x0f38, 0x20) ... - X86EMUL_OPC_EVEX_F3(0x0f38, 0x25): /* VPMOVS* */ - case X86EMUL_OPC_EVEX_F3(0x0f38, 0x30) ... - X86EMUL_OPC_EVEX_F3(0x0f38, 0x35): /* VPMOV{D,Q,W}* */ return true; case 0xd9: From xen-devel-bounces@lists.xenproject.org Mon Aug 03 14:53:28 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 14:53:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2bq9-0005UL-Bj; Mon, 03 Aug 2020 14:53:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2bq8-0005UA-HG for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 14:53:24 +0000 X-Inumbo-ID: 1431a5dc-d599-11ea-9097-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1431a5dc-d599-11ea-9097-bc764e2007e4; Mon, 03 Aug 2020 14:53:23 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 66E08B751; Mon, 3 Aug 2020 14:53:37 +0000 (UTC) Subject: [PATCH 07/10] x86emul: AVX512F scatter insns are memory writes From: Jan Beulich To: "xen-devel@lists.xenproject.org" References: <97ca3d9c-7540-c7b1-cf84-34c75c9127df@suse.com> Message-ID: <752561bb-ab7a-e7c0-3bce-832b2162c755@suse.com> Date: Mon, 3 Aug 2020 16:53:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <97ca3d9c-7540-c7b1-cf84-34c75c9127df@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" While the custom handling renders the "to_mem" field generally unused, x86_insn_is_mem_write() still (indirectly) consumes that information, and hence the table entries want to be correct. Fixes: ("x86emul: support AVX512F scatter insns") Signed-off-by: Jan Beulich --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -516,7 +516,7 @@ static const struct ext0f38_table { [0x9d] = { .simd_size = simd_scalar_vexw, .d8s = d8s_dq }, [0x9e] = { .simd_size = simd_packed_fp, .d8s = d8s_vl }, [0x9f] = { .simd_size = simd_scalar_vexw, .d8s = d8s_dq }, - [0xa0 ... 0xa3] = { .simd_size = simd_other, .vsib = 1, .d8s = d8s_dq }, + [0xa0 ... 0xa3] = { .simd_size = simd_other, .to_mem = 1, .vsib = 1, .d8s = d8s_dq }, [0xa6 ... 0xa8] = { .simd_size = simd_packed_fp, .d8s = d8s_vl }, [0xa9] = { .simd_size = simd_scalar_vexw, .d8s = d8s_dq }, [0xaa] = { .simd_size = simd_packed_fp, .d8s = d8s_vl }, From xen-devel-bounces@lists.xenproject.org Mon Aug 03 14:53:54 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 14:53:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2bqc-0005Y6-KZ; Mon, 03 Aug 2020 14:53:54 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2bqa-0005Xr-Pi for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 14:53:52 +0000 X-Inumbo-ID: 25152b08-d599-11ea-9097-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 25152b08-d599-11ea-9097-bc764e2007e4; Mon, 03 Aug 2020 14:53:52 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AC755AC24; Mon, 3 Aug 2020 14:54:06 +0000 (UTC) Subject: [PATCH 08/10] x86emul: AVX512PF insns aren't memory accesses From: Jan Beulich To: "xen-devel@lists.xenproject.org" References: <97ca3d9c-7540-c7b1-cf84-34c75c9127df@suse.com> Message-ID: Date: Mon, 3 Aug 2020 16:53:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <97ca3d9c-7540-c7b1-cf84-34c75c9127df@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" These are prefetches, so should be treated just like other prefetches. Fixes: ("x86emul: support AVX512PF insns") Signed-off-by: Jan Beulich --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -12265,6 +12265,8 @@ x86_insn_is_mem_access(const struct x86_ ... X86EMUL_OPC_F2(0x0f, 0x1f): /* NOP space */ case X86EMUL_OPC(0x0f, 0xb9): /* UD1 */ case X86EMUL_OPC(0x0f, 0xff): /* UD0 */ + case X86EMUL_OPC_EVEX_66(0x0f38, 0xc6): /* V{GATH,SCATT}ERPF*D* */ + case X86EMUL_OPC_EVEX_66(0x0f38, 0xc7): /* V{GATH,SCATT}ERPF*Q* */ return false; case X86EMUL_OPC(0x0f, 0x01): From xen-devel-bounces@lists.xenproject.org Mon Aug 03 14:54:20 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 14:54:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2br1-0005cK-UD; Mon, 03 Aug 2020 14:54:19 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2br0-0005c8-Fm for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 14:54:18 +0000 X-Inumbo-ID: 334f68f0-d599-11ea-9097-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 334f68f0-d599-11ea-9097-bc764e2007e4; Mon, 03 Aug 2020 14:54:16 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8AEB7AC24; Mon, 3 Aug 2020 14:54:30 +0000 (UTC) Subject: [PATCH 09/10] x86emul: extend decoding / mem access testing to EVEX-encoded insns From: Jan Beulich To: "xen-devel@lists.xenproject.org" References: <97ca3d9c-7540-c7b1-cf84-34c75c9127df@suse.com> Message-ID: Date: Mon, 3 Aug 2020 16:54:14 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <97ca3d9c-7540-c7b1-cf84-34c75c9127df@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Signed-off-by: Jan Beulich --- a/tools/tests/x86_emulator/predicates.c +++ b/tools/tests/x86_emulator/predicates.c @@ -1564,9 +1564,469 @@ static const struct { { xop_0a, ARRAY_SIZE(xop_0a), 4 }, }; -#undef Wn #undef Ln +static const struct evex { + uint8_t opc[3]; + uint8_t len:3; + bool modrm:1; /* Should register form (also) be tested? */ + uint8_t mem:2; + uint8_t pfx:2; + uint8_t w:2; + uint8_t l:3; + bool mask:1; +#define L2 4 +#define Ln (L0 | L1 | L2) +} evex_0f[] = { + { { 0x10 }, 2, T, R, pfx_no, W0, Ln }, /* vmovups */ + { { 0x10 }, 2, T, R, pfx_66, W1, Ln }, /* vmovupd */ + { { 0x10 }, 2, T, R, pfx_f3, W0, LIG }, /* vmovss */ + { { 0x10 }, 2, T, R, pfx_f2, W1, LIG }, /* vmovsd */ + { { 0x11 }, 2, T, W, pfx_no, W0, Ln }, /* vmovups */ + { { 0x11 }, 2, T, W, pfx_66, W1, Ln }, /* vmovupd */ + { { 0x11 }, 2, T, W, pfx_f3, W0, LIG }, /* vmovss */ + { { 0x11 }, 2, T, W, pfx_f2, W1, LIG }, /* vmovsd */ + { { 0x12 }, 2, T, R, pfx_no, W0, L0 }, /* vmovlps / vmovhlps */ + { { 0x12 }, 2, F, R, pfx_66, W1, L0 }, /* vmovlpd */ + { { 0x12 }, 2, T, R, pfx_f3, W0, Ln }, /* vmovsldup */ + { { 0x12 }, 2, T, R, pfx_f2, W1, Ln }, /* vmovddup */ + { { 0x13 }, 2, F, W, pfx_no, W0, L0 }, /* vmovlps */ + { { 0x13 }, 2, F, W, pfx_66, W1, L0 }, /* vmovlpd */ + { { 0x14 }, 2, T, R, pfx_no, W0, Ln }, /* vunpcklps */ + { { 0x14 }, 2, T, R, pfx_66, W1, Ln }, /* vunpcklpd */ + { { 0x15 }, 2, T, R, pfx_no, W0, Ln }, /* vunpckhps */ + { { 0x15 }, 2, T, R, pfx_66, W1, Ln }, /* vunpckhpd */ + { { 0x16 }, 2, T, R, pfx_no, W0, L0 }, /* vmovhps / vmovlhps */ + { { 0x16 }, 2, F, R, pfx_66, W1, L0 }, /* vmovhpd */ + { { 0x16 }, 2, T, R, pfx_f3, W0, Ln }, /* vmovshdup */ + { { 0x17 }, 2, F, W, pfx_no, W0, L0 }, /* vmovhps */ + { { 0x17 }, 2, F, W, pfx_66, W1, L0 }, /* vmovhpd */ + { { 0x28 }, 2, T, R, pfx_no, W0, Ln }, /* vmovaps */ + { { 0x28 }, 2, T, R, pfx_66, W1, Ln }, /* vmovapd */ + { { 0x29 }, 2, T, W, pfx_no, W0, Ln }, /* vmovaps */ + { { 0x29 }, 2, T, W, pfx_66, W1, Ln }, /* vmovapd */ + { { 0x2a }, 2, T, R, pfx_f3, W0, LIG }, /* vcvtsi2ss */ + { { 0x2a }, 2, T, R, pfx_f2, W1, LIG }, /* vcvtsi2sd */ + { { 0x2b }, 2, T, W, pfx_no, W0, Ln }, /* vmovntps */ + { { 0x2b }, 2, T, W, pfx_66, W1, Ln }, /* vmovntpd */ + { { 0x2c }, 2, T, R, pfx_f3, Wn, LIG }, /* vcvttss2si */ + { { 0x2c }, 2, T, R, pfx_f2, Wn, LIG }, /* vcvttsd2si */ + { { 0x2d }, 2, T, R, pfx_f3, Wn, LIG }, /* vcvtss2si */ + { { 0x2d }, 2, T, R, pfx_f2, Wn, LIG }, /* vcvtsd2si */ + { { 0x2e }, 2, T, R, pfx_no, W0, LIG }, /* vucomiss */ + { { 0x2e }, 2, T, R, pfx_66, W1, LIG }, /* vucomisd */ + { { 0x2f }, 2, T, R, pfx_no, W0, LIG }, /* vcomiss */ + { { 0x2f }, 2, T, R, pfx_66, W1, LIG }, /* vcomisd */ + { { 0x51 }, 2, T, R, pfx_no, W0, Ln }, /* vsqrtps */ + { { 0x51 }, 2, T, R, pfx_66, W1, Ln }, /* vsqrtpd */ + { { 0x51 }, 2, T, R, pfx_f3, W0, LIG }, /* vsqrtss */ + { { 0x51 }, 2, T, R, pfx_f2, W1, LIG }, /* vsqrtsd */ + { { 0x54 }, 2, T, R, pfx_no, W0, Ln }, /* vandps */ + { { 0x54 }, 2, T, R, pfx_66, W1, Ln }, /* vandpd */ + { { 0x55 }, 2, T, R, pfx_no, W0, Ln }, /* vandnps */ + { { 0x55 }, 2, T, R, pfx_66, W1, Ln }, /* vandnpd */ + { { 0x56 }, 2, T, R, pfx_no, W0, Ln }, /* vorps */ + { { 0x56 }, 2, T, R, pfx_66, W1, Ln }, /* vorpd */ + { { 0x57 }, 2, T, R, pfx_no, W0, Ln }, /* vxorps */ + { { 0x57 }, 2, T, R, pfx_66, W1, Ln }, /* vxorpd */ + { { 0x58 }, 2, T, R, pfx_no, W0, Ln }, /* vaddps */ + { { 0x58 }, 2, T, R, pfx_66, W1, Ln }, /* vaddpd */ + { { 0x58 }, 2, T, R, pfx_f3, W0, LIG }, /* vaddss */ + { { 0x58 }, 2, T, R, pfx_f2, W1, LIG }, /* vaddsd */ + { { 0x59 }, 2, T, R, pfx_no, W0, Ln }, /* vmulps */ + { { 0x59 }, 2, T, R, pfx_66, W1, Ln }, /* vmulpd */ + { { 0x59 }, 2, T, R, pfx_f3, W0, LIG }, /* vmulss */ + { { 0x59 }, 2, T, R, pfx_f2, W1, LIG }, /* vmulsd */ + { { 0x5a }, 2, T, R, pfx_no, W0, Ln }, /* vcvtps2pd */ + { { 0x5a }, 2, T, R, pfx_66, W1, Ln }, /* vcvtpd2ps */ + { { 0x5a }, 2, T, R, pfx_f3, W0, LIG }, /* vcvtss2sd */ + { { 0x5a }, 2, T, R, pfx_f2, W1, LIG }, /* vcvtsd2ss */ + { { 0x5b }, 2, T, R, pfx_no, Wn, Ln }, /* vcvt{d,q}q2ps */ + { { 0x5b }, 2, T, R, pfx_66, W0, Ln }, /* vcvtps2dq */ + { { 0x5b }, 2, T, R, pfx_f3, W0, Ln }, /* vcvttps2dq */ + { { 0x5c }, 2, T, R, pfx_no, W0, Ln }, /* vsubps */ + { { 0x5c }, 2, T, R, pfx_66, W1, Ln }, /* vsubpd */ + { { 0x5c }, 2, T, R, pfx_f3, W0, LIG }, /* vsubss */ + { { 0x5c }, 2, T, R, pfx_f2, W1, LIG }, /* vsubsd */ + { { 0x5d }, 2, T, R, pfx_no, W0, Ln }, /* vminps */ + { { 0x5d }, 2, T, R, pfx_66, W1, Ln }, /* vminpd */ + { { 0x5d }, 2, T, R, pfx_f3, W0, LIG }, /* vminss */ + { { 0x5d }, 2, T, R, pfx_f2, W1, LIG }, /* vminsd */ + { { 0x5e }, 2, T, R, pfx_no, W0, Ln }, /* vdivps */ + { { 0x5e }, 2, T, R, pfx_66, W1, Ln }, /* vdivpd */ + { { 0x5e }, 2, T, R, pfx_f3, W0, LIG }, /* vdivss */ + { { 0x5e }, 2, T, R, pfx_f2, W1, LIG }, /* vdivsd */ + { { 0x5f }, 2, T, R, pfx_no, W0, Ln }, /* vmaxps */ + { { 0x5f }, 2, T, R, pfx_66, W1, Ln }, /* vmaxpd */ + { { 0x5f }, 2, T, R, pfx_f3, W0, LIG }, /* vmaxss */ + { { 0x5f }, 2, T, R, pfx_f2, W1, LIG }, /* vmaxsd */ + { { 0x60 }, 2, T, R, pfx_66, WIG, Ln }, /* vpunpcklbw */ + { { 0x61 }, 2, T, R, pfx_66, WIG, Ln }, /* vpunpcklwd */ + { { 0x62 }, 2, T, R, pfx_66, W0, Ln }, /* vpunpckldq */ + { { 0x63 }, 2, T, R, pfx_66, WIG, Ln }, /* vpacksswb */ + { { 0x64 }, 2, T, R, pfx_66, WIG, Ln }, /* vpcmpgtb */ + { { 0x65 }, 2, T, R, pfx_66, WIG, Ln }, /* vpcmpgtw */ + { { 0x66 }, 2, T, R, pfx_66, W0, Ln }, /* vpcmpgtd */ + { { 0x67 }, 2, T, R, pfx_66, WIG, Ln }, /* vpackuswb */ + { { 0x68 }, 2, T, R, pfx_66, WIG, Ln }, /* vpunpckhbw */ + { { 0x69 }, 2, T, R, pfx_66, WIG, Ln }, /* vpunpckhwd */ + { { 0x6a }, 2, T, R, pfx_66, W0, Ln }, /* vpunpckhdq */ + { { 0x6b }, 2, T, R, pfx_66, W0, Ln }, /* vpackssdw */ + { { 0x6c }, 2, T, R, pfx_66, W1, Ln }, /* vpunpcklqdq */ + { { 0x6d }, 2, T, R, pfx_66, W1, Ln }, /* vpunpckhqdq */ + { { 0x6e }, 2, T, R, pfx_66, Wn, L0 }, /* vmov{d,q} */ + { { 0x6f }, 2, T, R, pfx_66, Wn, Ln }, /* vmovdqa{32,64} */ + { { 0x6f }, 2, T, R, pfx_f3, Wn, Ln }, /* vmovdqu{32,64} */ + { { 0x6f }, 2, T, R, pfx_f2, Wn, Ln }, /* vmovdqu{8,16} */ + { { 0x70 }, 3, T, R, pfx_66, W0, Ln }, /* vpshufd */ + { { 0x70 }, 3, T, R, pfx_f3, WIG, Ln }, /* vpshuflw */ + { { 0x70 }, 3, T, R, pfx_f2, WIG, Ln }, /* vpshufhw */ + { { 0x71, 0xd0 }, 3, F, N, pfx_66, WIG, Ln }, /* vpsrlw */ + { { 0x71, 0xe0 }, 3, F, N, pfx_66, WIG, Ln }, /* vpsraw */ + { { 0x71, 0xf0 }, 3, F, N, pfx_66, WIG, Ln }, /* vpsllw */ + { { 0x72, 0xc0 }, 3, F, N, pfx_66, Wn, Ln }, /* vpror{d,q} */ + { { 0x72, 0xc8 }, 3, F, N, pfx_66, Wn, Ln }, /* vprol{d,q} */ + { { 0x72, 0xd0 }, 3, F, N, pfx_66, W0, Ln }, /* vpsrld */ + { { 0x72, 0xe0 }, 3, F, N, pfx_66, Wn, Ln }, /* vpsra{d,q} */ + { { 0x72, 0xf0 }, 3, F, N, pfx_66, W0, Ln }, /* vpslld */ + { { 0x73, 0xd0 }, 3, F, N, pfx_66, W1, Ln }, /* vpsrlq */ + { { 0x73, 0xd8 }, 3, F, N, pfx_66, WIG, Ln }, /* vpsrldq */ + { { 0x73, 0xf0 }, 3, F, N, pfx_66, W0, Ln }, /* vpsllq */ + { { 0x73, 0xf8 }, 3, F, N, pfx_66, WIG, Ln }, /* vpslldq */ + { { 0x74 }, 2, T, R, pfx_66, WIG, Ln }, /* vpcmpeqb */ + { { 0x75 }, 2, T, R, pfx_66, WIG, Ln }, /* vpcmpeqw */ + { { 0x76 }, 2, T, R, pfx_66, W0, Ln }, /* vpcmpeqd */ + { { 0x78 }, 2, T, R, pfx_no, Wn, Ln }, /* vcvttp{s,d}2udq */ + { { 0x78 }, 2, T, R, pfx_66, Wn, Ln }, /* vcvttp{s,d}2uqq */ + { { 0x78 }, 2, T, R, pfx_f3, Wn, LIG }, /* vcvttss2usi */ + { { 0x78 }, 2, T, R, pfx_f2, Wn, LIG }, /* vcvttsd2usi */ + { { 0x79 }, 2, T, R, pfx_no, Wn, Ln }, /* vcvtp{s,d}2udq */ + { { 0x79 }, 2, T, R, pfx_66, Wn, Ln }, /* vcvtp{s,d}2uqq */ + { { 0x79 }, 2, T, R, pfx_f3, Wn, LIG }, /* vcvtss2usi */ + { { 0x79 }, 2, T, R, pfx_f2, Wn, LIG }, /* vcvtsd2usi */ + { { 0x7a }, 2, T, R, pfx_66, Wn, Ln }, /* vcvttp{s,d}2qq */ + { { 0x7a }, 2, T, R, pfx_f3, Wn, Ln }, /* vcvtu{d,q}2pd */ + { { 0x7a }, 2, T, R, pfx_f2, Wn, Ln }, /* vcvtu{d,q}2ps */ + { { 0x7b }, 2, T, R, pfx_66, Wn, Ln }, /* vcvtp{s,d}2qq */ + { { 0x7b }, 2, T, R, pfx_f3, Wn, LIG }, /* vcvtusi2s */ + { { 0x7b }, 2, T, R, pfx_f2, Wn, LIG }, /* vcvtusi2s */ + { { 0x7e }, 2, T, W, pfx_66, Wn, L0 }, /* vmov{d,q} */ + { { 0x7e }, 2, T, R, pfx_f3, W1, L0 }, /* vmovq */ + { { 0x7f }, 2, T, W, pfx_66, Wn, Ln }, /* vmovdqa{32,64} */ + { { 0x7f }, 2, T, W, pfx_f3, Wn, Ln }, /* vmovdqu{32,64} */ + { { 0x7f }, 2, T, W, pfx_f2, Wn, Ln }, /* vmovdqu{8,16} */ + { { 0xc2 }, 3, T, R, pfx_no, W0, Ln }, /* vcmpps */ + { { 0xc2 }, 3, T, R, pfx_66, W1, Ln }, /* vcmppd */ + { { 0xc2 }, 3, T, R, pfx_f3, W0, LIG }, /* vcmpss */ + { { 0xc2 }, 3, T, R, pfx_f2, W1, LIG }, /* vcmpsd */ + { { 0xc4 }, 3, T, R, pfx_66, WIG, L0 }, /* vpinsrw */ + { { 0xc5, 0xc0 }, 3, F, N, pfx_66, WIG, L0 }, /* vpextrw */ + { { 0xc6 }, 3, T, R, pfx_no, W0, Ln }, /* vshufps */ + { { 0xc6 }, 3, T, R, pfx_66, W1, Ln }, /* vshufpd */ + { { 0xd1 }, 2, T, R, pfx_66, WIG, Ln }, /* vpsrlw */ + { { 0xd2 }, 2, T, R, pfx_66, W0, Ln }, /* vpsrld */ + { { 0xd3 }, 2, T, R, pfx_66, W1, Ln }, /* vpsrlq */ + { { 0xd4 }, 2, T, R, pfx_66, W1, Ln }, /* vpaddq */ + { { 0xd5 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmullw */ + { { 0xd6 }, 2, T, W, pfx_66, W1, L0 }, /* vmovq */ + { { 0xd8 }, 2, T, R, pfx_66, WIG, Ln }, /* vpsubusb */ + { { 0xd9 }, 2, T, R, pfx_66, WIG, Ln }, /* vpsubusw */ + { { 0xda }, 2, T, R, pfx_66, WIG, Ln }, /* vpminub */ + { { 0xdb }, 2, T, R, pfx_66, Wn, Ln }, /* vpand{d,q} */ + { { 0xdc }, 2, T, R, pfx_66, WIG, Ln }, /* vpaddusb */ + { { 0xdd }, 2, T, R, pfx_66, WIG, Ln }, /* vpaddusw */ + { { 0xde }, 2, T, R, pfx_66, WIG, Ln }, /* vpmaxub */ + { { 0xdf }, 2, T, R, pfx_66, Wn, Ln }, /* vpandn{d,q} */ + { { 0xe0 }, 2, T, R, pfx_66, WIG, Ln }, /* vpavgb */ + { { 0xe1 }, 2, T, R, pfx_66, WIG, Ln }, /* vpsraw */ + { { 0xe2 }, 2, T, R, pfx_66, Wn, Ln }, /* vpsra{d,q} */ + { { 0xe3 }, 2, T, R, pfx_66, WIG, Ln }, /* vpavgw */ + { { 0xe4 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmulhuw */ + { { 0xe5 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmulhw */ + { { 0xe6 }, 2, T, R, pfx_66, WIG, Ln }, /* vcvttpd2dq */ + { { 0xe6 }, 2, T, R, pfx_f3, Wn, Ln }, /* vcvt{d,q}q2pd */ + { { 0xe6 }, 2, T, R, pfx_f2, WIG, Ln }, /* vcvtpd2dq */ + { { 0xe7 }, 2, F, W, pfx_66, W0, Ln }, /* vmovntdq */ + { { 0xe8 }, 2, T, R, pfx_66, WIG, Ln }, /* vpsubsb */ + { { 0xe9 }, 2, T, R, pfx_66, WIG, Ln }, /* vpsubsw */ + { { 0xea }, 2, T, R, pfx_66, WIG, Ln }, /* vpminsw */ + { { 0xeb }, 2, T, R, pfx_66, Wn, Ln }, /* vpor{d,q} */ + { { 0xec }, 2, T, R, pfx_66, WIG, Ln }, /* vpaddsb */ + { { 0xed }, 2, T, R, pfx_66, WIG, Ln }, /* vpaddsw */ + { { 0xee }, 2, T, R, pfx_66, WIG, Ln }, /* vpmaxsw */ + { { 0xef }, 2, T, R, pfx_66, Wn, Ln }, /* vpxor{d,q} */ + { { 0xf1 }, 2, T, R, pfx_66, WIG, Ln }, /* vpsllw */ + { { 0xf2 }, 2, T, R, pfx_66, W0, Ln }, /* vpslld */ + { { 0xf3 }, 2, T, R, pfx_66, W1, Ln }, /* vpsllq */ + { { 0xf4 }, 2, T, R, pfx_66, W1, Ln }, /* vpmuludq */ + { { 0xf5 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmaddwd */ + { { 0xf6 }, 2, T, R, pfx_66, WIG, Ln }, /* vpsadbw */ + { { 0xf8 }, 2, T, R, pfx_66, WIG, Ln }, /* vpsubb */ + { { 0xf9 }, 2, T, R, pfx_66, WIG, Ln }, /* vpsubw */ + { { 0xfa }, 2, T, R, pfx_66, W0, Ln }, /* vpsubd */ + { { 0xfb }, 2, T, R, pfx_66, W1, Ln }, /* vpsubq */ + { { 0xfc }, 2, T, R, pfx_66, WIG, Ln }, /* vpaddb */ + { { 0xfd }, 2, T, R, pfx_66, WIG, Ln }, /* vpaddw */ + { { 0xfe }, 2, T, R, pfx_66, W0, Ln }, /* vpaddd */ +}, evex_0f38[] = { + { { 0x00 }, 2, T, R, pfx_66, WIG, Ln }, /* vpshufb */ + { { 0x04 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmaddubsw */ + { { 0x0b }, 2, T, R, pfx_66, WIG, Ln }, /* vpmulhrsw */ + { { 0x0c }, 2, T, R, pfx_66, W0, Ln }, /* vpermilps */ + { { 0x0d }, 2, T, R, pfx_66, W1, Ln }, /* vpermilpd */ + { { 0x10 }, 2, T, R, pfx_66, W1, Ln }, /* vpsrlvw */ + { { 0x10 }, 2, T, W, pfx_f3, W0, Ln }, /* vpmovuswb */ + { { 0x11 }, 2, T, R, pfx_66, W1, Ln }, /* vpsravw */ + { { 0x11 }, 2, T, W, pfx_f3, W0, Ln }, /* vpmovusdb */ + { { 0x12 }, 2, T, R, pfx_66, W1, Ln }, /* vpsllvw */ + { { 0x12 }, 2, T, W, pfx_f3, W0, Ln }, /* vpmovusqb */ + { { 0x13 }, 2, T, R, pfx_66, W0, Ln }, /* vcvtph2ps */ + { { 0x13 }, 2, T, W, pfx_f3, W0, Ln }, /* vpmovusdw */ + { { 0x14 }, 2, T, R, pfx_66, Wn, Ln }, /* vprorv{d,q} */ + { { 0x14 }, 2, T, W, pfx_f3, W0, Ln }, /* vpmovusqw */ + { { 0x15 }, 2, T, R, pfx_66, Wn, Ln }, /* vprolv{d,q} */ + { { 0x15 }, 2, T, W, pfx_f3, W0, Ln }, /* vpmovusqd */ + { { 0x16 }, 2, T, R, pfx_66, Wn, L1|L2 }, /* vpermp{s,d} */ + { { 0x18 }, 2, T, R, pfx_66, W0, Ln }, /* vbroadcastss */ + { { 0x19 }, 2, T, R, pfx_66, Wn, L1|L2 }, /* vbroadcast{32x2,sd} */ + { { 0x1a }, 2, F, R, pfx_66, Wn, L1|L2 }, /* vbroadcastf{32x4,64x2} */ + { { 0x1b }, 2, F, R, pfx_66, Wn, L2 }, /* vbroadcastf{32x8,64x4} */ + { { 0x1c }, 2, T, R, pfx_66, WIG, Ln }, /* vpabsb */ + { { 0x1d }, 2, T, R, pfx_66, WIG, Ln }, /* vpabsw */ + { { 0x1e }, 2, T, R, pfx_66, W0, Ln }, /* vpabsd */ + { { 0x1f }, 2, T, R, pfx_66, W1, Ln }, /* vpabsq */ + { { 0x20 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmovsxbw */ + { { 0x20 }, 2, T, W, pfx_f3, W0, Ln }, /* vpmovswb */ + { { 0x21 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmovsxbd */ + { { 0x21 }, 2, T, W, pfx_f3, W0, Ln }, /* vpmovsdb */ + { { 0x22 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmovsxbq */ + { { 0x22 }, 2, T, W, pfx_f3, W0, Ln }, /* vpmovsqb */ + { { 0x23 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmovsxwd */ + { { 0x23 }, 2, T, W, pfx_f3, W0, Ln }, /* vpmovsdw */ + { { 0x24 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmovsxwq */ + { { 0x24 }, 2, T, W, pfx_f3, W0, Ln }, /* vpmovsqw */ + { { 0x25 }, 2, T, R, pfx_66, W0, Ln }, /* vpmovsxdq */ + { { 0x25 }, 2, T, W, pfx_f3, W0, Ln }, /* vpmovsqd */ + { { 0x26 }, 2, T, R, pfx_66, Wn, Ln }, /* vptestm{b,w} */ + { { 0x26 }, 2, T, R, pfx_f3, Wn, Ln }, /* vptestnm{b,w} */ + { { 0x27 }, 2, T, R, pfx_66, Wn, Ln }, /* vptestm{d,q} */ + { { 0x27 }, 2, T, R, pfx_f3, Wn, Ln }, /* vptestnm{d,q} */ + { { 0x28 }, 2, T, R, pfx_66, W1, Ln }, /* vpmuldq */ + { { 0x28, 0xc0 }, 2, F, N, pfx_f3, Wn, Ln }, /* vpmovm2{b,w} */ + { { 0x29 }, 2, T, R, pfx_66, W1, Ln }, /* vpcmpeqq */ + { { 0x29, 0xc0 }, 2, F, N, pfx_f3, Wn, Ln }, /* vpmov{b,w}2m */ + { { 0x2a }, 2, F, R, pfx_66, W0, Ln }, /* vmovntdqa */ + { { 0x2a, 0xc0 }, 2, F, N, pfx_f3, W1, Ln }, /* vpbroadcastmb2q */ + { { 0x2b }, 2, T, R, pfx_66, W0, Ln }, /* vpackusdw */ + { { 0x2c }, 2, F, R, pfx_66, Wn, Ln }, /* vscalefp{s,d} */ + { { 0x2d }, 2, F, R, pfx_66, Wn, LIG }, /* vscalefs{s,d} */ + { { 0x30 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmovzxbw */ + { { 0x30 }, 2, T, W, pfx_f3, W0, Ln }, /* vpmovwb */ + { { 0x31 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmovzxbd */ + { { 0x31 }, 2, T, W, pfx_f3, W0, Ln }, /* vpmovdb */ + { { 0x32 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmovzxbq */ + { { 0x32 }, 2, T, W, pfx_f3, W0, Ln }, /* vpmovqb */ + { { 0x33 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmovzxwd */ + { { 0x33 }, 2, T, W, pfx_f3, W0, Ln }, /* vpmovdw */ + { { 0x34 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmovzxwq */ + { { 0x34 }, 2, T, W, pfx_f3, W0, Ln }, /* vpmovqw */ + { { 0x35 }, 2, T, R, pfx_66, W0, Ln }, /* vpmovzxdq */ + { { 0x35 }, 2, T, W, pfx_f3, W0, Ln }, /* vpmovqd */ + { { 0x36 }, 2, T, R, pfx_66, Wn, L1|L2 }, /* vperm{d,q} */ + { { 0x37 }, 2, T, R, pfx_66, W1, Ln }, /* vpcmpgtq */ + { { 0x38 }, 2, T, R, pfx_66, WIG, Ln }, /* vpminsb */ + { { 0x38, 0xc0 }, 2, F, N, pfx_f3, Wn, Ln }, /* vpmovm2{d,q} */ + { { 0x39 }, 2, T, R, pfx_66, Wn, Ln }, /* vpmins{d,q} */ + { { 0x39, 0xc0 }, 2, F, N, pfx_f3, Wn, Ln }, /* vpmov{d,q}2m */ + { { 0x3a }, 2, T, R, pfx_66, WIG, Ln }, /* vpminuw */ + { { 0x2a, 0xc0 }, 2, F, N, pfx_f3, W0, Ln }, /* vpbroadcastmw2d */ + { { 0x3b }, 2, T, R, pfx_66, Wn, Ln }, /* vpminu{d,q} */ + { { 0x3c }, 2, T, R, pfx_66, WIG, Ln }, /* vpmaxsb */ + { { 0x3d }, 2, T, R, pfx_66, Wn, Ln }, /* vpmaxs{d,q} */ + { { 0x3e }, 2, T, R, pfx_66, WIG, Ln }, /* vpmaxuw */ + { { 0x3f }, 2, T, R, pfx_66, Wn, Ln }, /* vpmaxu{d,q} */ + { { 0x40 }, 2, T, R, pfx_66, Wn, Ln }, /* vpmull{d,q} */ + { { 0x42 }, 2, T, R, pfx_66, Wn, Ln }, /* vgetexpp{s,d} */ + { { 0x43 }, 2, T, R, pfx_66, Wn, LIG }, /* vgetexps{s,d} */ + { { 0x44 }, 2, T, R, pfx_66, Wn, Ln }, /* vlzcnt{d,q} */ + { { 0x45 }, 2, T, R, pfx_66, Wn, Ln }, /* vpsrlv{d,q} */ + { { 0x46 }, 2, T, R, pfx_66, Wn, Ln }, /* vpsrav{d,q} */ + { { 0x47 }, 2, T, R, pfx_66, Wn, Ln }, /* vpsllv{d,q} */ + { { 0x4c }, 2, T, R, pfx_66, Wn, Ln }, /* vrcp14p{s,d} */ + { { 0x4d }, 2, T, R, pfx_66, Wn, LIG }, /* vrcp14s{s,d} */ + { { 0x4e }, 2, T, R, pfx_66, Wn, Ln }, /* vrsqrt14p{s,d} */ + { { 0x4f }, 2, T, R, pfx_66, Wn, LIG }, /* vrsqrt14s{s,d} */ + { { 0x50 }, 2, T, R, pfx_66, W0, Ln }, /* vpdpbusd */ + { { 0x51 }, 2, T, R, pfx_66, W0, Ln }, /* vpdpbusds */ + { { 0x52 }, 2, T, R, pfx_66, W0, Ln }, /* vpdpwssd */ + { { 0x52 }, 2, T, R, pfx_f3, W0, Ln }, /* vdpbf16ps */ + { { 0x52 }, 2, T, R, pfx_f2, W0, L2 }, /* vp4dpwssd */ + { { 0x53 }, 2, T, R, pfx_66, W0, Ln }, /* vpdpwssds */ + { { 0x53 }, 2, T, R, pfx_f2, W0, L2 }, /* vp4dpwssds */ + { { 0x54 }, 2, T, R, pfx_66, Wn, Ln }, /* vpopcnt{b,w} */ + { { 0x55 }, 2, T, R, pfx_66, Wn, Ln }, /* vpopcnt{d,q} */ + { { 0x58 }, 2, T, R, pfx_66, W0, Ln }, /* vpbroadcastd */ + { { 0x59 }, 2, T, R, pfx_66, Wn, Ln }, /* vbroadcast32x2 / vpbroadcastq */ + { { 0x5a }, 2, F, R, pfx_66, Wn, L1|L2 }, /* vbroadcasti{32x4,64x2} */ + { { 0x5b }, 2, F, R, pfx_66, Wn, L2 }, /* vbroadcasti{32x8,64x4} */ + { { 0x62 }, 2, T, R, pfx_66, Wn, Ln }, /* vpexpand{b,w} */ + { { 0x63 }, 2, T, W, pfx_66, Wn, Ln }, /* vpcompress{b,w} */ + { { 0x64 }, 2, T, R, pfx_66, Wn, Ln }, /* vpblendm{d,q} */ + { { 0x65 }, 2, T, R, pfx_66, Wn, Ln }, /* vblendmp{s,d} */ + { { 0x66 }, 2, T, R, pfx_66, Wn, Ln }, /* vpblendm{b,w} */ + { { 0x68 }, 2, T, R, pfx_f2, Wn, Ln }, /* vp2intersect{d,q} */ + { { 0x70 }, 2, T, R, pfx_66, W1, Ln }, /* vpshldvw */ + { { 0x71 }, 2, T, R, pfx_66, Wn, Ln }, /* vpshldv{d,q} */ + { { 0x72 }, 2, T, R, pfx_66, W1, Ln }, /* vpshrdvw */ + { { 0x72 }, 2, T, R, pfx_f3, W1, Ln }, /* vcvtneps2bf16 */ + { { 0x72 }, 2, T, R, pfx_f2, W1, Ln }, /* vcvtne2ps2bf16 */ + { { 0x73 }, 2, T, R, pfx_66, Wn, Ln }, /* vpshrdv{d,q} */ + { { 0x75 }, 2, T, R, pfx_66, Wn, Ln }, /* vpermi2{b,w} */ + { { 0x76 }, 2, T, R, pfx_66, Wn, Ln }, /* vpermi2{d,q} */ + { { 0x77 }, 2, T, R, pfx_66, Wn, Ln }, /* vpermi2p{s,d} */ + { { 0x78 }, 2, T, R, pfx_66, W0, Ln }, /* vpbroadcastb */ + { { 0x79 }, 2, T, R, pfx_66, W0, Ln }, /* vpbroadcastw */ + { { 0x7a, 0xc0 }, 2, F, N, pfx_66, W0, Ln }, /* vpbroadcastb */ + { { 0x7b, 0xc0 }, 2, F, N, pfx_66, W0, Ln }, /* vpbroadcastw */ + { { 0x7c, 0xc0 }, 2, F, N, pfx_66, W0, Ln }, /* vpbroadcast{d,q} */ + { { 0x7d }, 2, T, R, pfx_66, Wn, Ln }, /* vpermt2{b,w} */ + { { 0x7e }, 2, T, R, pfx_66, Wn, Ln }, /* vpermt2{d,q} */ + { { 0x7f }, 2, T, R, pfx_66, Wn, Ln }, /* vpermt2p{s,d} */ + { { 0x83 }, 2, T, R, pfx_66, W1, Ln }, /* vpmultishiftqb */ + { { 0x88 }, 2, T, R, pfx_66, Wn, Ln }, /* vpexpandp{s,d} */ + { { 0x89 }, 2, T, R, pfx_66, Wn, Ln }, /* vpexpand{d,q} */ + { { 0x8a }, 2, T, W, pfx_66, Wn, Ln }, /* vpcompressp{s,d} */ + { { 0x8b }, 2, T, W, pfx_66, Wn, Ln }, /* vpcompress{d,q} */ + { { 0x8d }, 2, F, R, pfx_66, Wn, Ln }, /* vperm{b,w} */ + { { 0x8f }, 2, F, R, pfx_66, W0, Ln }, /* vpshufbitqmb */ + { { 0x90, VSIB(1) }, 3, F, R, pfx_66, Wn, Ln, T }, /* vpgatherd{d,q} */ + { { 0x91, VSIB(1) }, 3, F, R, pfx_66, Wn, Ln, T }, /* vpgatherq{d,q} */ + { { 0x92, VSIB(1) }, 3, F, R, pfx_66, Wn, Ln, T }, /* vgatherdp{s,d} */ + { { 0x93, VSIB(1) }, 3, F, R, pfx_66, Wn, Ln, T }, /* vgatherqp{s,d} */ + { { 0x96 }, 2, T, R, pfx_66, Wn, Ln }, /* vfmaddsub132p{s,d} */ + { { 0x97 }, 2, T, R, pfx_66, Wn, Ln }, /* vfmsubadd132p{s,d} */ + { { 0x98 }, 2, T, R, pfx_66, Wn, Ln }, /* vfmadd132p{s,d} */ + { { 0x99 }, 2, T, R, pfx_66, Wn, LIG }, /* vfmadd132s{s,d} */ + { { 0x9a }, 2, T, R, pfx_66, Wn, Ln }, /* vfmsub132p{s,d} */ + { { 0x9a }, 2, T, R, pfx_f2, W0, L2 }, /* v4fmaddps */ + { { 0x9b }, 2, T, R, pfx_66, Wn, LIG }, /* vfmsub132s{s,d} */ + { { 0x9b }, 2, T, R, pfx_f2, W0, LIG }, /* v4fmaddss */ + { { 0x9c }, 2, T, R, pfx_66, Wn, Ln }, /* vfnmadd132p{s,d} */ + { { 0x9d }, 2, T, R, pfx_66, Wn, LIG }, /* vfnmadd132s{s,d} */ + { { 0x9e }, 2, T, R, pfx_66, Wn, Ln }, /* vfnmsub132p{s,d} */ + { { 0x9f }, 2, T, R, pfx_66, Wn, LIG }, /* vfnmsub132s{s,d} */ + { { 0xa0, VSIB(1) }, 3, F, W, pfx_66, Wn, Ln, T }, /* vpscatterd{d,q} */ + { { 0xa1, VSIB(1) }, 3, F, W, pfx_66, Wn, Ln, T }, /* vpscatterq{d,q} */ + { { 0xa2, VSIB(1) }, 3, F, W, pfx_66, Wn, Ln, T }, /* vscatterdp{s,d} */ + { { 0xa3, VSIB(1) }, 3, F, W, pfx_66, Wn, Ln, T }, /* vscatterqp{s,d} */ + { { 0xa6 }, 2, T, R, pfx_66, Wn, Ln }, /* vfmaddsub213p{s,d} */ + { { 0xa7 }, 2, T, R, pfx_66, Wn, Ln }, /* vfmsubadd213p{s,d} */ + { { 0xa8 }, 2, T, R, pfx_66, Wn, Ln }, /* vfmadd213p{s,d} */ + { { 0xa9 }, 2, T, R, pfx_66, Wn, LIG }, /* vfmadd213s{s,d} */ + { { 0x9a }, 2, T, R, pfx_f2, W0, L2 }, /* v4fnmaddps */ + { { 0xaa }, 2, T, R, pfx_66, Wn, Ln }, /* vfmsub213p{s,d} */ + { { 0xab }, 2, T, R, pfx_66, Wn, LIG }, /* vfmsub213s{s,d} */ + { { 0x9b }, 2, T, R, pfx_f2, W0, LIG }, /* v4fnmaddss */ + { { 0xac }, 2, T, R, pfx_66, Wn, Ln }, /* vfnmadd213p{s,d} */ + { { 0xad }, 2, T, R, pfx_66, Wn, LIG }, /* vfnmadd213s{s,d} */ + { { 0xae }, 2, T, R, pfx_66, Wn, Ln }, /* vfnmsub213p{s,d} */ + { { 0xaf }, 2, T, R, pfx_66, Wn, LIG }, /* vfnmsub213s{s,d} */ + { { 0xb4 }, 2, T, R, pfx_66, W1, Ln }, /* vpmadd52luq */ + { { 0xb5 }, 2, T, R, pfx_66, W1, Ln }, /* vpmadd52huq */ + { { 0xb6 }, 2, T, R, pfx_66, Wn, Ln }, /* vfmaddsub231p{s,d} */ + { { 0xb7 }, 2, T, R, pfx_66, Wn, Ln }, /* vfmsubadd231p{s,d} */ + { { 0xb8 }, 2, T, R, pfx_66, Wn, Ln }, /* vfmadd231p{s,d} */ + { { 0xb9 }, 2, T, R, pfx_66, Wn, LIG }, /* vfmadd231s{s,d} */ + { { 0xba }, 2, T, R, pfx_66, Wn, Ln }, /* vfmsub231p{s,d} */ + { { 0xbb }, 2, T, R, pfx_66, Wn, LIG }, /* vfmsub231s{s,d} */ + { { 0xbc }, 2, T, R, pfx_66, Wn, Ln }, /* vfnmadd231p{s,d} */ + { { 0xbd }, 2, T, R, pfx_66, Wn, LIG }, /* vfnmadd231s{s,d} */ + { { 0xbe }, 2, T, R, pfx_66, Wn, Ln }, /* vfnmsub231p{s,d} */ + { { 0xbf }, 2, T, R, pfx_66, Wn, LIG }, /* vfnmsub231s{s,d} */ + { { 0xc4 }, 2, T, R, pfx_66, Wn, Ln }, /* vpconflict{d,q} */ + { { 0xc6, VSIB(1) }, 3, F, N, pfx_66, Wn, L2, T }, /* vgatherpf0dp{s,d} */ + { { 0xc6, VSIB(2) }, 3, F, N, pfx_66, Wn, L2, T }, /* vgatherpf1dp{s,d} */ + { { 0xc6, VSIB(5) }, 3, F, N, pfx_66, Wn, L2, T }, /* vscatterpf0dp{s,d} */ + { { 0xc6, VSIB(6) }, 3, F, N, pfx_66, Wn, L2, T }, /* vscatterpf1dp{s,d} */ + { { 0xc7, VSIB(1) }, 3, F, N, pfx_66, Wn, L2, T }, /* vgatherpf0qp{s,d} */ + { { 0xc7, VSIB(2) }, 3, F, N, pfx_66, Wn, L2, T }, /* vgatherpf1qp{s,d} */ + { { 0xc7, VSIB(5) }, 3, F, N, pfx_66, Wn, L2, T }, /* vscatterpf0qp{s,d} */ + { { 0xc7, VSIB(6) }, 3, F, N, pfx_66, Wn, L2, T }, /* vscatterpf1qp{s,d} */ + { { 0xc8 }, 2, T, R, pfx_66, Wn, L2 }, /* vexp2p{s,d} */ + { { 0xca }, 2, T, R, pfx_66, Wn, L2 }, /* vrcp28p{s,d} */ + { { 0xcb }, 2, T, R, pfx_66, Wn, LIG }, /* vrcp28s{s,d} */ + { { 0xcc }, 2, T, R, pfx_66, Wn, L2 }, /* vrsqrt28p{s,d} */ + { { 0xcd }, 2, T, R, pfx_66, Wn, LIG }, /* vrsqrt28s{s,d} */ + { { 0xcf }, 2, T, R, pfx_66, W0, Ln }, /* vgf2p8mulb */ + { { 0xdc }, 2, T, R, pfx_66, WIG, Ln }, /* vaesenc */ + { { 0xdd }, 2, T, R, pfx_66, WIG, Ln }, /* vaesenclast */ + { { 0xde }, 2, T, R, pfx_66, WIG, Ln }, /* vaesdec */ + { { 0xdf }, 2, T, R, pfx_66, WIG, Ln }, /* vaesdeclast */ +}, evex_0f3a[] = { + { { 0x00 }, 3, T, R, pfx_66, W1, L1|L2 }, /* vpermq */ + { { 0x01 }, 3, T, R, pfx_66, W1, L1|L2 }, /* vpermpd */ + { { 0x03 }, 3, T, R, pfx_66, Wn, Ln }, /* valign{d,q} */ + { { 0x04 }, 3, T, R, pfx_66, W0, Ln }, /* vpermilps */ + { { 0x05 }, 3, T, R, pfx_66, W1, Ln }, /* vpermilpd */ + { { 0x08 }, 3, T, R, pfx_66, W0, Ln }, /* vrndscaleps */ + { { 0x09 }, 3, T, R, pfx_66, W1, Ln }, /* vrndscalepd */ + { { 0x0a }, 3, T, R, pfx_66, WIG, LIG }, /* vrndscaless */ + { { 0x0b }, 3, T, R, pfx_66, WIG, LIG }, /* vrndscalesd */ + { { 0x0f }, 3, T, R, pfx_66, WIG, Ln }, /* vpalignr */ + { { 0x14 }, 3, T, W, pfx_66, WIG, L0 }, /* vpextrb */ + { { 0x15 }, 3, T, W, pfx_66, WIG, L0 }, /* vpextrw */ + { { 0x16 }, 3, T, W, pfx_66, Wn, L0 }, /* vpextr{d,q} */ + { { 0x17 }, 3, T, W, pfx_66, WIG, L0 }, /* vextractps */ + { { 0x18 }, 3, T, R, pfx_66, Wn, L1|L2 }, /* vinsertf{32x4,64x2} */ + { { 0x19 }, 3, T, W, pfx_66, Wn, L1|L2 }, /* vextractf{32x4,64x2} */ + { { 0x1a }, 3, T, R, pfx_66, Wn, L2 }, /* vinsertf{32x8,64x4} */ + { { 0x1b }, 3, T, W, pfx_66, Wn, L2 }, /* vextractf{32x8,64x4} */ + { { 0x1d }, 3, T, W, pfx_66, W0, Ln }, /* vcvtps2ph */ + { { 0x1e }, 3, T, R, pfx_66, Wn, Ln }, /* vpcmpu{d,q} */ + { { 0x1f }, 3, T, R, pfx_66, Wn, Ln }, /* vpcmp{d,q} */ + { { 0x20 }, 3, T, R, pfx_66, WIG, L0 }, /* vpinsrb */ + { { 0x21 }, 3, T, R, pfx_66, WIG, L0 }, /* vinsertps */ + { { 0x22 }, 3, T, R, pfx_66, Wn, L0 }, /* vpinsr{d,q} */ + { { 0x23 }, 3, T, R, pfx_66, Wn, L1|L2 }, /* vshuff{32x4,64x2} */ + { { 0x25 }, 3, T, R, pfx_66, Wn, Ln }, /* vpternlog{d,q} */ + { { 0x26 }, 3, T, R, pfx_66, Wn, Ln }, /* vgetmantp{s,d} */ + { { 0x27 }, 3, T, R, pfx_66, Wn, LIG }, /* vgetmants{s,d} */ + { { 0x38 }, 3, T, R, pfx_66, Wn, L1|L2 }, /* vinserti{32x4,64x2} */ + { { 0x39 }, 3, T, W, pfx_66, Wn, L1|L2 }, /* vextracti{32x4,64x2} */ + { { 0x3a }, 3, T, R, pfx_66, Wn, L2 }, /* vinserti{32x8,64x4} */ + { { 0x3b }, 3, T, W, pfx_66, Wn, L2 }, /* vextracti{32x8,64x4} */ + { { 0x3e }, 3, T, R, pfx_66, Wn, Ln }, /* vpcmpu{b,w} */ + { { 0x3f }, 3, T, R, pfx_66, Wn, Ln }, /* vpcmp{b,w} */ + { { 0x42 }, 3, T, R, pfx_66, W0, Ln }, /* vdbpsadbw */ + { { 0x43 }, 3, T, R, pfx_66, Wn, L1|L2 }, /* vshufi{32x4,64x2} */ + { { 0x44 }, 3, T, R, pfx_66, WIG, Ln }, /* vpclmulqdq */ + { { 0x50 }, 3, T, R, pfx_66, Wn, Ln }, /* vrangep{s,d} */ + { { 0x51 }, 3, T, R, pfx_66, Wn, LIG }, /* vranges{s,d} */ + { { 0x54 }, 3, T, R, pfx_66, Wn, Ln }, /* vfixupimmp{s,d} */ + { { 0x55 }, 3, T, R, pfx_66, Wn, LIG }, /* vfixumpimms{s,d} */ + { { 0x56 }, 3, T, R, pfx_66, Wn, Ln }, /* vreducep{s,d} */ + { { 0x57 }, 3, T, R, pfx_66, Wn, LIG }, /* vreduces{s,d} */ + { { 0x66 }, 3, T, R, pfx_66, Wn, Ln }, /* vfpclassp{s,d} */ + { { 0x67 }, 3, T, R, pfx_66, Wn, LIG }, /* vfpclasss{s,d} */ + { { 0x70 }, 3, T, R, pfx_66, W1, Ln }, /* vshldw */ + { { 0x71 }, 3, T, R, pfx_66, Wn, Ln }, /* vshld{d,q} */ + { { 0x72 }, 3, T, R, pfx_66, W1, Ln }, /* vshrdw */ + { { 0x73 }, 3, T, R, pfx_66, Wn, Ln }, /* vshrd{d,q} */ + { { 0xce }, 3, T, R, pfx_66, W1, Ln }, /* vgf2p8affineqb */ + { { 0xcf }, 3, T, R, pfx_66, W1, Ln }, /* vgf2p8affineinvqb */ +}; + +static const struct { + const struct evex *tbl; + unsigned int num; +} evex[] = { + { evex_0f, ARRAY_SIZE(evex_0f) }, + { evex_0f38, ARRAY_SIZE(evex_0f38) }, + { evex_0f3a, ARRAY_SIZE(evex_0f3a) }, +}; + +#undef Wn + #undef F #undef N #undef R @@ -1883,6 +2343,50 @@ void predicates_test(void *instr, struct } } } + } + + for ( x = 0; x < ARRAY_SIZE(evex); ++x ) + { + for ( t = 0; t < evex[x].num; ++t ) + { + uint8_t *ptr = instr; + unsigned int l; + + memset(instr + 5, 0xcc, 10); + + *ptr++ = 0x62; + *ptr++ = 0xf1 + x; + *ptr++ = 0x7c | evex[x].tbl[t].pfx; + *ptr++ = 0x08 | evex[x].tbl[t].mask; + + for ( l = 3; l--; ) + { + if ( evex[x].tbl[t].l != LIG && !(evex[x].tbl[t].l & (1u << l)) ) + continue; + + ptr[-1] &= ~0x60; + ptr[-1] |= l << 5; + memcpy(ptr, evex[x].tbl[t].opc, evex[x].tbl[t].len); + + if ( evex[x].tbl[t].w == WIG || (evex[x].tbl[t].w & W0) ) + { + ptr[-2] &= ~0x80; + do_test(instr, evex[x].tbl[t].len + ((void *)ptr - instr), + evex[x].tbl[t].modrm ? (void *)ptr - instr + 1 : 0, + evex[x].tbl[t].mem, ctxt, fetch); + } + + if ( evex[x].tbl[t].w == WIG || (evex[x].tbl[t].w & W1) ) + { + ptr[-2] |= 0x80; + memcpy(ptr, evex[x].tbl[t].opc, evex[x].tbl[t].len); + + do_test(instr, evex[x].tbl[t].len + ((void *)ptr - instr), + evex[x].tbl[t].modrm ? (void *)ptr - instr + 1 : 0, + evex[x].tbl[t].mem, ctxt, fetch); + } + } + } } if ( errors ) From xen-devel-bounces@lists.xenproject.org Mon Aug 03 14:54:41 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 14:54:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2brN-0005he-AC; Mon, 03 Aug 2020 14:54:41 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2brM-0005hM-8y for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 14:54:40 +0000 X-Inumbo-ID: 41141776-d599-11ea-9097-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 41141776-d599-11ea-9097-bc764e2007e4; Mon, 03 Aug 2020 14:54:39 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 26684AC24; Mon, 3 Aug 2020 14:54:54 +0000 (UTC) Subject: [PATCH 10/10] x86emul: correct AVX512_BF16 insn names in EVEX Disp8 test From: Jan Beulich To: "xen-devel@lists.xenproject.org" References: <97ca3d9c-7540-c7b1-cf84-34c75c9127df@suse.com> Message-ID: <917b6766-ad0a-ba05-74bc-2f0ec7ba6157@suse.com> Date: Mon, 3 Aug 2020 16:54:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <97ca3d9c-7540-c7b1-cf84-34c75c9127df@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" The leading 'v' ought to be omitted from the table entries. Fixes: 7ff66809ccd5 ("x86emul: support AVX512_BF16 insns") Signed-off-by: Jan Beulich --- a/tools/tests/x86_emulator/evex-disp8.c +++ b/tools/tests/x86_emulator/evex-disp8.c @@ -551,9 +551,9 @@ static const struct test avx512_4vnniw_5 }; static const struct test avx512_bf16_all[] = { - INSN(vcvtne2ps2bf16, f2, 0f38, 72, vl, d, vl), - INSN(vcvtneps2bf16, f3, 0f38, 72, vl, d, vl), - INSN(vdpbf16ps, f3, 0f38, 52, vl, d, vl), + INSN(cvtne2ps2bf16, f2, 0f38, 72, vl, d, vl), + INSN(cvtneps2bf16, f3, 0f38, 72, vl, d, vl), + INSN(dpbf16ps, f3, 0f38, 52, vl, d, vl), }; static const struct test avx512_bitalg_all[] = { From xen-devel-bounces@lists.xenproject.org Mon Aug 03 15:53:40 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 15:53:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2cm6-0002QP-Tt; Mon, 03 Aug 2020 15:53:18 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2cm5-0002QK-6g for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 15:53:17 +0000 X-Inumbo-ID: 70fc0b2e-d5a1-11ea-af4f-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 70fc0b2e-d5a1-11ea-af4f-12813bfff9fa; Mon, 03 Aug 2020 15:53:15 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id ED53EB02A; Mon, 3 Aug 2020 15:53:29 +0000 (UTC) Subject: Re: [PATCH v3 01/11] x86/iommu: re-arrange arch_iommu to separate common fields... To: Paul Durrant References: <20200803122914.2259-1-paul@xen.org> <20200803122914.2259-2-paul@xen.org> From: Jan Beulich Message-ID: <2a5a0a65-81aa-2c1f-c98a-5e6fd54ba3df@suse.com> Date: Mon, 3 Aug 2020 17:53:13 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200803122914.2259-2-paul@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Tian , Wei Liu , Andrew Cooper , Paul Durrant , Lukasz Hawrylko , xen-devel@lists.xenproject.org, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 03.08.2020 14:29, Paul Durrant wrote: > From: Paul Durrant > > ... from those specific to VT-d or AMD IOMMU, and put the latter in a union. > > There is no functional change in this patch, although the initialization of > the 'mapped_rmrrs' list occurs slightly later in iommu_domain_init() since > it is now done (correctly) in VT-d specific code rather than in general x86 > code. > > NOTE: I have not combined the AMD IOMMU 'root_table' and VT-d 'pgd_maddr' > fields even though they perform essentially the same function. The > concept of 'root table' in the VT-d code is different from that in the > AMD code so attempting to use a common name will probably only serve > to confuse the reader. > > Signed-off-by: Paul Durrant Acked-by: Jan Beulich with a remark (can be taken care of while committing if no other need for a v4 arises): > @@ -598,11 +600,12 @@ static void amd_dump_p2m_table(struct domain *d) > { > const struct domain_iommu *hd = dom_iommu(d); > > - if ( !hd->arch.root_table ) > + if ( !hd->arch.amd.root_table ) > return; > > - printk("p2m table has %d levels\n", hd->arch.paging_mode); > - amd_dump_p2m_table_level(hd->arch.root_table, hd->arch.paging_mode, 0, 0); > + printk("p2m table has %d levels\n", hd->arch.amd.paging_mode); > + amd_dump_p2m_table_level(hd->arch.amd.root_table, > + hd->arch.amd.paging_mode, 0, 0); At least where you touch the format string anyway, converting %d to %u where you converted fron plain int to unsigned int would be nice. Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 03 15:59:03 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 15:59:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2crb-0002bl-J0; Mon, 03 Aug 2020 15:58:59 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2cra-0002bg-8q for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 15:58:58 +0000 X-Inumbo-ID: 3c6f5180-d5a2-11ea-90a4-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3c6f5180-d5a2-11ea-90a4-bc764e2007e4; Mon, 03 Aug 2020 15:58:56 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 50FA3B16E; Mon, 3 Aug 2020 15:59:11 +0000 (UTC) Subject: Re: [PATCH v3 02/11] x86/iommu: add common page-table allocator To: Paul Durrant References: <20200803122914.2259-1-paul@xen.org> <20200803122914.2259-3-paul@xen.org> From: Jan Beulich Message-ID: <1bc6fcbe-534a-b056-7744-e96eb4f09757@suse.com> Date: Mon, 3 Aug 2020 17:58:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200803122914.2259-3-paul@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Andrew Cooper Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 03.08.2020 14:29, Paul Durrant wrote: > From: Paul Durrant > > Instead of having separate page table allocation functions in VT-d and AMD > IOMMU code, we could use a common allocation function in the general x86 code. > > This patch adds a new allocation function, iommu_alloc_pgtable(), for this > purpose. The function adds the page table pages to a list. The pages in this > list are then freed by iommu_free_pgtables(), which is called by > domain_relinquish_resources() after PCI devices have been de-assigned. > > Signed-off-by: Paul Durrant > --- > Cc: Jan Beulich > Cc: Andrew Cooper > Cc: Wei Liu > Cc: "Roger Pau Monné" > > v2: > - This is split out from a larger patch of the same name in v1 > --- > xen/arch/x86/domain.c | 9 +++++- > xen/drivers/passthrough/x86/iommu.c | 50 +++++++++++++++++++++++++++++ > xen/include/asm-x86/iommu.h | 7 ++++ > 3 files changed, 65 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c > index f8084dc9e3..d1ecc7b83b 100644 > --- a/xen/arch/x86/domain.c > +++ b/xen/arch/x86/domain.c > @@ -2153,7 +2153,8 @@ int domain_relinquish_resources(struct domain *d) > d->arch.rel_priv = PROG_ ## x; /* Fallthrough */ case PROG_ ## x > > enum { > - PROG_paging = 1, > + PROG_iommu_pagetables = 1, > + PROG_paging, > PROG_vcpu_pagetables, > PROG_shared, > PROG_xen, Is there a particular reason to make this new item the very first one? > @@ -257,6 +260,53 @@ void __hwdom_init arch_iommu_hwdom_init(struct domain *d) > return; > } > > +int iommu_free_pgtables(struct domain *d) > +{ > + struct domain_iommu *hd = dom_iommu(d); > + struct page_info *pg; > + > + while ( (pg = page_list_remove_head(&hd->arch.pgtables.list)) ) > + { > + free_domheap_page(pg); > + > + if ( general_preempt_check() ) > + return -ERESTART; Perhaps better only check once every so many pages? > +struct page_info *iommu_alloc_pgtable(struct domain *d) > +{ > + struct domain_iommu *hd = dom_iommu(d); > + unsigned int memflags = 0; > + struct page_info *pg; > + void *p; > + > +#ifdef CONFIG_NUMA > + if (hd->node != NUMA_NO_NODE) Missing blanks inside parentheses. > @@ -131,6 +135,9 @@ int pi_update_irte(const struct pi_desc *pi_desc, const struct pirq *pirq, > iommu_vcall(ops, sync_cache, addr, size); \ > }) > > +int __must_check iommu_free_pgtables(struct domain *d); > +struct page_info * __must_check iommu_alloc_pgtable(struct domain *d); Commonly we put a blank on the left side of *, but none to its right. Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 03 16:04:08 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 16:04:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2cwU-0003yH-6Q; Mon, 03 Aug 2020 16:04:02 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2cwS-0003yC-Gx for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 16:04:00 +0000 X-Inumbo-ID: f0d9ae5e-d5a2-11ea-af51-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f0d9ae5e-d5a2-11ea-af51-12813bfff9fa; Mon, 03 Aug 2020 16:03:59 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 07DB4B6D5; Mon, 3 Aug 2020 16:04:14 +0000 (UTC) Subject: Re: [PATCH v3 03/11] x86/iommu: convert VT-d code to use new page table allocator To: Paul Durrant References: <20200803122914.2259-1-paul@xen.org> <20200803122914.2259-4-paul@xen.org> From: Jan Beulich Message-ID: <0eda3f54-63ce-2694-ba3b-2a0c67826098@suse.com> Date: Mon, 3 Aug 2020 18:03:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200803122914.2259-4-paul@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Paul Durrant , Kevin Tian Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 03.08.2020 14:29, Paul Durrant wrote: > From: Paul Durrant > > This patch converts the VT-d code to use the new IOMMU page table allocator > function. This allows all the free-ing code to be removed (since it is now > handled by the general x86 code) which reduces TLB and cache thrashing as well > as shortening the code. > > The scope of the mapping_lock in intel_iommu_quarantine_init() has also been > increased slightly; it should have always covered accesses to > 'arch.vtd.pgd_maddr'. I think I disagree here (this is __init code and hence there's no risk of races), but anyway (as it doesn't hurt) ... > NOTE: The common IOMMU needs a slight modification to avoid scheduling the > cleanup tasklet if the free_page_table() method is not present (since > the tasklet will unconditionally call it). > > Signed-off-by: Paul Durrant Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Mon Aug 03 16:06:00 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 16:06:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2cyN-00044V-JZ; Mon, 03 Aug 2020 16:05:59 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2cyM-00044M-Lo for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 16:05:58 +0000 X-Inumbo-ID: 376692d8-d5a3-11ea-af51-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 376692d8-d5a3-11ea-af51-12813bfff9fa; Mon, 03 Aug 2020 16:05:57 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6AF84B6EA; Mon, 3 Aug 2020 16:06:12 +0000 (UTC) Subject: Re: [PATCH v3 04/11] x86/iommu: convert AMD IOMMU code to use new page table allocator To: Paul Durrant References: <20200803122914.2259-1-paul@xen.org> <20200803122914.2259-5-paul@xen.org> From: Jan Beulich Message-ID: <6e9875c4-a72d-231f-e386-19f21c891120@suse.com> Date: Mon, 3 Aug 2020 18:05:56 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200803122914.2259-5-paul@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Paul Durrant , Andrew Cooper Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 03.08.2020 14:29, Paul Durrant wrote: > From: Paul Durrant > > This patch converts the AMD IOMMU code to use the new page table allocator > function. This allows all the free-ing code to be removed (since it is now > handled by the general x86 code) which reduces TLB and cache thrashing as well > as shortening the code. > > Signed-off-by: Paul Durrant Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Mon Aug 03 16:06:34 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 16:06:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2cyv-00048l-T6; Mon, 03 Aug 2020 16:06:33 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2cyu-00048e-CS for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 16:06:32 +0000 X-Inumbo-ID: 4a9cc0a3-d5a3-11ea-af51-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4a9cc0a3-d5a3-11ea-af51-12813bfff9fa; Mon, 03 Aug 2020 16:06:31 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E62FEB6EB; Mon, 3 Aug 2020 16:06:45 +0000 (UTC) Subject: Re: [PATCH v3 05/11] iommu: remove unused iommu_ops method and tasklet To: Paul Durrant References: <20200803122914.2259-1-paul@xen.org> <20200803122914.2259-6-paul@xen.org> From: Jan Beulich Message-ID: Date: Mon, 3 Aug 2020 18:06:29 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200803122914.2259-6-paul@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Paul Durrant Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 03.08.2020 14:29, Paul Durrant wrote: > From: Paul Durrant > > The VT-d and AMD IOMMU both use the general x86 IOMMU page table allocator > and ARM always shares page tables with CPU. Hence there is no need to retain > the free_page_table() method or the tasklet which invokes it. > > Signed-off-by: Paul Durrant Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Mon Aug 03 16:17:18 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 16:17:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2d9B-00056g-SX; Mon, 03 Aug 2020 16:17:09 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2d9A-00056Z-OR for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 16:17:08 +0000 X-Inumbo-ID: c6735334-d5a4-11ea-af56-12813bfff9fa Received: from smtp-fw-6001.amazon.com (unknown [52.95.48.154]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c6735334-d5a4-11ea-af56-12813bfff9fa; Mon, 03 Aug 2020 16:17:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.co.uk; i=@amazon.co.uk; q=dns/txt; s=amazon201209; t=1596471427; x=1628007427; h=from:to:cc:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version:subject; bh=QXyg9b+PP6vrVQj4grqEMl3N+4MmPdmGswAr9dCXQtg=; b=F9wH5uIbojDSHsiRNYEEwWF1O3LQmJj7WI0mRkPuk/POYIs6xkSd2dcZ pLN7Nvcw6gg5ETN6JDfZupCtL3k7/VKlTWAMSpzwrR3bGkYO58SzwzAf5 PiNgTtnTKWC0ZlkM2OMBHx2Tb8uJmBV6EdkL2+NrOG2zjNbDBgpJoWZz1 s=; IronPort-SDR: KvcF9b4Hjr65tgUl+rBmyxmKEYmBLrVE/0S0supfO0zH4JF0Y1ziTfnQpN2r8VeixSHUVIwpTx 7lHEno5CTNLw== X-IronPort-AV: E=Sophos;i="5.75,430,1589241600"; d="scan'208";a="47131808" Subject: RE: [PATCH v3 02/11] x86/iommu: add common page-table allocator Thread-Topic: [PATCH v3 02/11] x86/iommu: add common page-table allocator Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-2c-c6afef2e.us-west-2.amazon.com) ([10.43.8.6]) by smtp-border-fw-out-6001.iad6.amazon.com with ESMTP; 03 Aug 2020 16:17:06 +0000 Received: from EX13MTAUEA002.ant.amazon.com (pdx4-ws-svc-p6-lb7-vlan2.pdx.amazon.com [10.170.41.162]) by email-inbound-relay-2c-c6afef2e.us-west-2.amazon.com (Postfix) with ESMTPS id 9A5ECA0370; Mon, 3 Aug 2020 16:17:04 +0000 (UTC) Received: from EX13D32EUC003.ant.amazon.com (10.43.164.24) by EX13MTAUEA002.ant.amazon.com (10.43.61.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 3 Aug 2020 16:17:04 +0000 Received: from EX13D32EUC003.ant.amazon.com (10.43.164.24) by EX13D32EUC003.ant.amazon.com (10.43.164.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 3 Aug 2020 16:17:03 +0000 Received: from EX13D32EUC003.ant.amazon.com ([10.43.164.24]) by EX13D32EUC003.ant.amazon.com ([10.43.164.24]) with mapi id 15.00.1497.006; Mon, 3 Aug 2020 16:17:03 +0000 From: "Durrant, Paul" To: Jan Beulich , Paul Durrant Thread-Index: AQHWaa8KHRMAXkKC7EeaIzxZlnqXcqkmjknw Date: Mon, 3 Aug 2020 16:17:03 +0000 Message-ID: <23bb9481c2534476aa992cefdf887ae4@EX13D32EUC003.ant.amazon.com> References: <20200803122914.2259-1-paul@xen.org> <20200803122914.2259-3-paul@xen.org> <1bc6fcbe-534a-b056-7744-e96eb4f09757@suse.com> In-Reply-To: <1bc6fcbe-534a-b056-7744-e96eb4f09757@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.165.145] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 Precedence: Bulk X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , Andrew Cooper Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxp Y2hAc3VzZS5jb20+DQo+IFNlbnQ6IDAzIEF1Z3VzdCAyMDIwIDE2OjU5DQo+IFRvOiBQYXVsIER1 cnJhbnQgPHBhdWxAeGVuLm9yZz4NCj4gQ2M6IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9y ZzsgRHVycmFudCwgUGF1bCA8cGR1cnJhbnRAYW1hem9uLmNvLnVrPjsgQW5kcmV3IENvb3Blcg0K PiA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT47IFdlaSBMaXUgPHdsQHhlbi5vcmc+OyBSb2dl ciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCj4gU3ViamVjdDogUkU6IFtFWFRF Uk5BTF0gW1BBVENIIHYzIDAyLzExXSB4ODYvaW9tbXU6IGFkZCBjb21tb24gcGFnZS10YWJsZSBh bGxvY2F0b3INCj4gDQo+IENBVVRJT046IFRoaXMgZW1haWwgb3JpZ2luYXRlZCBmcm9tIG91dHNp ZGUgb2YgdGhlIG9yZ2FuaXphdGlvbi4gRG8gbm90IGNsaWNrIGxpbmtzIG9yIG9wZW4NCj4gYXR0 YWNobWVudHMgdW5sZXNzIHlvdSBjYW4gY29uZmlybSB0aGUgc2VuZGVyIGFuZCBrbm93IHRoZSBj b250ZW50IGlzIHNhZmUuDQo+IA0KPiANCj4gDQo+IE9uIDAzLjA4LjIwMjAgMTQ6MjksIFBhdWwg RHVycmFudCB3cm90ZToNCj4gPiBGcm9tOiBQYXVsIER1cnJhbnQgPHBkdXJyYW50QGFtYXpvbi5j b20+DQo+ID4NCj4gPiBJbnN0ZWFkIG9mIGhhdmluZyBzZXBhcmF0ZSBwYWdlIHRhYmxlIGFsbG9j YXRpb24gZnVuY3Rpb25zIGluIFZULWQgYW5kIEFNRA0KPiA+IElPTU1VIGNvZGUsIHdlIGNvdWxk IHVzZSBhIGNvbW1vbiBhbGxvY2F0aW9uIGZ1bmN0aW9uIGluIHRoZSBnZW5lcmFsIHg4NiBjb2Rl Lg0KPiA+DQo+ID4gVGhpcyBwYXRjaCBhZGRzIGEgbmV3IGFsbG9jYXRpb24gZnVuY3Rpb24sIGlv bW11X2FsbG9jX3BndGFibGUoKSwgZm9yIHRoaXMNCj4gPiBwdXJwb3NlLiBUaGUgZnVuY3Rpb24g YWRkcyB0aGUgcGFnZSB0YWJsZSBwYWdlcyB0byBhIGxpc3QuIFRoZSBwYWdlcyBpbiB0aGlzDQo+ ID4gbGlzdCBhcmUgdGhlbiBmcmVlZCBieSBpb21tdV9mcmVlX3BndGFibGVzKCksIHdoaWNoIGlz IGNhbGxlZCBieQ0KPiA+IGRvbWFpbl9yZWxpbnF1aXNoX3Jlc291cmNlcygpIGFmdGVyIFBDSSBk ZXZpY2VzIGhhdmUgYmVlbiBkZS1hc3NpZ25lZC4NCj4gPg0KPiA+IFNpZ25lZC1vZmYtYnk6IFBh dWwgRHVycmFudCA8cGR1cnJhbnRAYW1hem9uLmNvbT4NCj4gPiAtLS0NCj4gPiBDYzogSmFuIEJl dWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiA+IENjOiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcu Y29vcGVyM0BjaXRyaXguY29tPg0KPiA+IENjOiBXZWkgTGl1IDx3bEB4ZW4ub3JnPg0KPiA+IENj OiAiUm9nZXIgUGF1IE1vbm7DqSIgPHJvZ2VyLnBhdUBjaXRyaXguY29tPg0KPiA+DQo+ID4gdjI6 DQo+ID4gIC0gVGhpcyBpcyBzcGxpdCBvdXQgZnJvbSBhIGxhcmdlciBwYXRjaCBvZiB0aGUgc2Ft ZSBuYW1lIGluIHYxDQo+ID4gLS0tDQo+ID4gIHhlbi9hcmNoL3g4Ni9kb21haW4uYyAgICAgICAg ICAgICAgIHwgIDkgKysrKystDQo+ID4gIHhlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3g4Ni9pb21t dS5jIHwgNTAgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysNCj4gPiAgeGVuL2luY2x1ZGUv YXNtLXg4Ni9pb21tdS5oICAgICAgICAgfCAgNyArKysrDQo+ID4gIDMgZmlsZXMgY2hhbmdlZCwg NjUgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQ0KPiA+DQo+ID4gZGlmZiAtLWdpdCBhL3hl bi9hcmNoL3g4Ni9kb21haW4uYyBiL3hlbi9hcmNoL3g4Ni9kb21haW4uYw0KPiA+IGluZGV4IGY4 MDg0ZGM5ZTMuLmQxZWNjN2I4M2IgMTAwNjQ0DQo+ID4gLS0tIGEveGVuL2FyY2gveDg2L2RvbWFp bi5jDQo+ID4gKysrIGIveGVuL2FyY2gveDg2L2RvbWFpbi5jDQo+ID4gQEAgLTIxNTMsNyArMjE1 Myw4IEBAIGludCBkb21haW5fcmVsaW5xdWlzaF9yZXNvdXJjZXMoc3RydWN0IGRvbWFpbiAqZCkN Cj4gPiAgICAgICAgICBkLT5hcmNoLnJlbF9wcml2ID0gUFJPR18gIyMgeDsgLyogRmFsbHRocm91 Z2ggKi8gY2FzZSBQUk9HXyAjIyB4DQo+ID4NCj4gPiAgICAgICAgICBlbnVtIHsNCj4gPiAtICAg ICAgICAgICAgUFJPR19wYWdpbmcgPSAxLA0KPiA+ICsgICAgICAgICAgICBQUk9HX2lvbW11X3Bh Z2V0YWJsZXMgPSAxLA0KPiA+ICsgICAgICAgICAgICBQUk9HX3BhZ2luZywNCj4gPiAgICAgICAg ICAgICAgUFJPR192Y3B1X3BhZ2V0YWJsZXMsDQo+ID4gICAgICAgICAgICAgIFBST0dfc2hhcmVk LA0KPiA+ICAgICAgICAgICAgICBQUk9HX3hlbiwNCj4gDQo+IElzIHRoZXJlIGEgcGFydGljdWxh ciByZWFzb24gdG8gbWFrZSB0aGlzIG5ldyBpdGVtIHRoZSB2ZXJ5IGZpcnN0DQo+IG9uZT8NCg0K SXQgc2VlbXMgbGlrZSB0aGUgbG9naWNhbCBwbGFjZSBhcyBpdCBjb21lcyBzdHJhaWdodCBhZnRl ciBkZXZpY2UgZGUtYXNzaWdubWVudC4NCg0KPiANCj4gPiBAQCAtMjU3LDYgKzI2MCw1MyBAQCB2 b2lkIF9faHdkb21faW5pdCBhcmNoX2lvbW11X2h3ZG9tX2luaXQoc3RydWN0IGRvbWFpbiAqZCkN Cj4gPiAgICAgICAgICByZXR1cm47DQo+ID4gIH0NCj4gPg0KPiA+ICtpbnQgaW9tbXVfZnJlZV9w Z3RhYmxlcyhzdHJ1Y3QgZG9tYWluICpkKQ0KPiA+ICt7DQo+ID4gKyAgICBzdHJ1Y3QgZG9tYWlu X2lvbW11ICpoZCA9IGRvbV9pb21tdShkKTsNCj4gPiArICAgIHN0cnVjdCBwYWdlX2luZm8gKnBn Ow0KPiA+ICsNCj4gPiArICAgIHdoaWxlICggKHBnID0gcGFnZV9saXN0X3JlbW92ZV9oZWFkKCZo ZC0+YXJjaC5wZ3RhYmxlcy5saXN0KSkgKQ0KPiA+ICsgICAgew0KPiA+ICsgICAgICAgIGZyZWVf ZG9taGVhcF9wYWdlKHBnKTsNCj4gPiArDQo+ID4gKyAgICAgICAgaWYgKCBnZW5lcmFsX3ByZWVt cHRfY2hlY2soKSApDQo+ID4gKyAgICAgICAgICAgIHJldHVybiAtRVJFU1RBUlQ7DQo+IA0KPiBQ ZXJoYXBzIGJldHRlciBvbmx5IGNoZWNrIG9uY2UgZXZlcnkgc28gbWFueSBwYWdlcz8NCj4gDQoN ClllcywgdGhhdCB3b3VsZCBiZSByZWFzb25hYmxlLg0KDQo+ID4gK3N0cnVjdCBwYWdlX2luZm8g KmlvbW11X2FsbG9jX3BndGFibGUoc3RydWN0IGRvbWFpbiAqZCkNCj4gPiArew0KPiA+ICsgICAg c3RydWN0IGRvbWFpbl9pb21tdSAqaGQgPSBkb21faW9tbXUoZCk7DQo+ID4gKyAgICB1bnNpZ25l ZCBpbnQgbWVtZmxhZ3MgPSAwOw0KPiA+ICsgICAgc3RydWN0IHBhZ2VfaW5mbyAqcGc7DQo+ID4g KyAgICB2b2lkICpwOw0KPiA+ICsNCj4gPiArI2lmZGVmIENPTkZJR19OVU1BDQo+ID4gKyAgICBp ZiAoaGQtPm5vZGUgIT0gTlVNQV9OT19OT0RFKQ0KPiANCj4gTWlzc2luZyBibGFua3MgaW5zaWRl IHBhcmVudGhlc2VzLg0KPiANCg0KT2ggeWVzLi4uIGJhZCBjb252ZXJzaW9uIGZyb20gdGVybmFy eSBzdGF0ZW1lbnQgaW4gcHJldmlvdXMgdmVyc2lvbi4NCg0KPiA+IEBAIC0xMzEsNiArMTM1LDkg QEAgaW50IHBpX3VwZGF0ZV9pcnRlKGNvbnN0IHN0cnVjdCBwaV9kZXNjICpwaV9kZXNjLCBjb25z dCBzdHJ1Y3QgcGlycSAqcGlycSwNCj4gPiAgICAgICAgICBpb21tdV92Y2FsbChvcHMsIHN5bmNf Y2FjaGUsIGFkZHIsIHNpemUpOyAgICAgICBcDQo+ID4gIH0pDQo+ID4NCj4gPiAraW50IF9fbXVz dF9jaGVjayBpb21tdV9mcmVlX3BndGFibGVzKHN0cnVjdCBkb21haW4gKmQpOw0KPiA+ICtzdHJ1 Y3QgcGFnZV9pbmZvICogX19tdXN0X2NoZWNrIGlvbW11X2FsbG9jX3BndGFibGUoc3RydWN0IGRv bWFpbiAqZCk7DQo+IA0KPiBDb21tb25seSB3ZSBwdXQgYSBibGFuayBvbiB0aGUgbGVmdCBzaWRl IG9mICosIGJ1dCBub25lIHRvIGl0cyByaWdodC4NCj4gDQoNCktpbmQgb2YgZmVsdCB3cm9uZyBu b3QgdG8gc2VwYXJhdGUgaXQgZnJvbSAnX19tdXN0X2NoZWNrJy4NCg0KICBQYXVsDQoNCj4gSmFu DQo= From xen-devel-bounces@lists.xenproject.org Mon Aug 03 16:35:33 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 16:35:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2dQr-0006pM-96; Mon, 03 Aug 2020 16:35:25 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2dQp-0006pF-OL for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 16:35:23 +0000 X-Inumbo-ID: 53286984-d5a7-11ea-af5d-12813bfff9fa Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 53286984-d5a7-11ea-af5d-12813bfff9fa; Mon, 03 Aug 2020 16:35:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596472523; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=MNUVdjqhQRP1dXRs4Aum5uFSIWFSBncZmJg7V1idQrI=; b=R7Y6oWzoQzuguTbDhllkB3thaANzbj80mhzDIA/Vhs7A6Pda3Sv5yp+q +oCeKWXyQGsl4NuXhZVR9+MhimoxpdzYNWNAKzrbp53xpSFG9P3Szvs+i XW3fCMQD6DTnSzhD2UXolXlTT6A2yj0Rhr3yVu6Mi2dFH6MG1gi2tzemg k=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: eqxk+0NeEGUCj9KM0nptCEKSlI8fcrI1rJOm9i9MdbTNrJp/02pz/cmIxq3i+fECreBovjI9qA nUceFlwzOFccjUgAF6MnJnCsRZCsB0oy0AIpvGLwjE3tB/h73VNLkzc2W3zjXXpTlFEe9T7et6 X1vpKQR+oOBEETDdXor5t6Nn/7MZZql07QpVvkdWYesPdnrVPQIWDM5Bq4EX2IoBSgpb9N53mQ X/h4V2OAJUKsYDQmm3RhHQdcTitw1SUryXRVpBOpqI7Xzr0i7KXrcSmFuMCnDgX04+9KiQ40HX RI4= X-SBRS: 3.7 X-MesageID: 23748486 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,430,1589256000"; d="scan'208";a="23748486" Date: Mon, 3 Aug 2020 17:35:15 +0100 From: Anthony PERARD To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH-for-5.1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects Message-ID: <20200803163515.GD2866@perard.uk.xensource.com> References: <20200728100925.10454-1-philmd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200728100925.10454-1-philmd@redhat.com> X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Stefano Stabellini , Paul Durrant , Paul Durrant , qemu-devel@nongnu.org, xen-devel@lists.xenproject.org, Paolo Bonzini Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Tue, Jul 28, 2020 at 12:09:25PM +0200, Philippe Mathieu-Daud wrote: > CONFIG_XEN is generated by configure and stored in "config-target.h", > which is (obviously) only include for target-specific objects. > This is a problem for target-agnostic objects as CONFIG_XEN is never > defined and xen_enabled() is always inlined as 'false'. > > Fix by following the KVM schema, defining CONFIG_XEN_IS_POSSIBLE > when we don't know to force the call of the non-inlined function, > returning the xen_allowed boolean. > > Fixes: da278d58a092 ("accel: Move Xen accelerator code under accel/xen/") > Reported-by: Paul Durrant > Suggested-by: Peter Maydell > Signed-off-by: Philippe Mathieu-Daud Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Mon Aug 03 16:40:34 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 16:40:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2dVn-0007fY-0i; Mon, 03 Aug 2020 16:40:31 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2dVl-0007fT-Rk for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 16:40:29 +0000 X-Inumbo-ID: 09134c1e-d5a8-11ea-af5f-12813bfff9fa Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 09134c1e-d5a8-11ea-af5f-12813bfff9fa; Mon, 03 Aug 2020 16:40:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596472827; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=WtYEFrjMgAoCEzoP+2m8fHJ340xJe620QI3eIGmhKU4=; b=ZhRSuaNWlwRZmnA31VmEtlLmhOwhhwCijcy1ppyZj8VjB/X1OCZln+qo QNSmay204T0w0/tJgoz09TRfijocbpmeS28Mi4oxwwD9SCPirUR4xUnNa cAtf9wPUN6+giL1+URnyzbuOFfBQTMwI1K1B+xus7HO1XclgfWEXct/5a Y=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 87DYH+HFcE2+lYQ08n4aMaamonkw4A1zUan8EpeMDz5Fb6xtpFpDiP5QafBJnLV11SoVH404DC tY/yU99VPihLDrypOVruRfCROxSAieqt9G0kHVxl0qAFFSnagVaQgW2smu3xdbkrnq/w/ExSRD DjUX4UnE+jMrbwUM8zp4ISxnZcFtREy9pyba11gurvJXbFcGEu+cPBcttIdGAk/pRmsQXfbZcz Odbm7IY37kwxi898GYnyIwvy50BPceCXwEj/62sQSJg6gmDn4dGsGBrSrElb6xa0Yt1HzjLR1s nA8= X-SBRS: 3.7 X-MesageID: 24083753 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,430,1589256000"; d="scan'208";a="24083753" Subject: Re: [PATCH 00/10] x86emul: full coverage mem access / write testing To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <97ca3d9c-7540-c7b1-cf84-34c75c9127df@suse.com> From: Andrew Cooper Message-ID: <60a128e9-0480-a753-4aa8-177c270d09f4@citrix.com> Date: Mon, 3 Aug 2020 17:40:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <97ca3d9c-7540-c7b1-cf84-34c75c9127df@suse.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 03/08/2020 15:47, Jan Beulich wrote: > ... and a few fixes resulting from this work. This completes what > was started for legacy encoded GPR insns in a rush before 4.14. > > There's one thing I'm still planning on top of both this and the > EVEX-disp8 checking: For all encodings we produce via general > logic (and in particular without involvement of any assembler) I'd > like to add a kind of logging mechanism, the output of which could > be fed to gas and then some disassembler, to allow verification > that the produced encodings are actually valid ones. See e.g. the > first patch here or commit 5f55389d6960 - the problems addressed > there could have been caught earlier if the generated encodings > could be easily disassembled. What's not clear to me here is > whether this is deemed generally useful, or whether I should make > this a private addition of mine. Seems fine to me. I have encountered a failure on AMD Naples which I doubt is related to this series, but is blocking testing on some of the content here. Testing fnstenv 4(%ecx)...              failed! AMD Fam17 does have the fcs/fds save-as-zero logic which is still not wired up anywhere in Xen, which seems like the most likely candidate here (without having investigated the issue at all yet). ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Aug 03 16:42:13 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 16:42:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2dXR-0007lN-DB; Mon, 03 Aug 2020 16:42:13 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2dXQ-0007lF-Ds for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 16:42:12 +0000 X-Inumbo-ID: 463e0638-d5a8-11ea-af5f-12813bfff9fa Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 463e0638-d5a8-11ea-af5f-12813bfff9fa; Mon, 03 Aug 2020 16:42:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596472931; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=+nnw8nebeoN62eFISAOEKZx22BhGHwjWOundpNtgQ3U=; b=eKNjw+zNtVpT0mGti0uqYMnpTAGSm0FsLc32DrL2PiOlSEaolvgw8shn Cm/5D5g35naH8LEv2KnrhIA7RDXw3VxzFTLpsNbFgzpdfH//utth5iIB+ sdSSJCfiXZjIoF0AfUT4NWo9CaMDk1eSZ77hJ6oAE/6M0Bbe0hIM9iWIg s=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: IN6psQeimS3m9tz3vqJiiS6DFePeRHYEaIE0jQS64fO77MWSHpNsNqSxXd6On8LLhRqTYtKy61 QjchKS/MivzEbrdwXGXsI5L2yNzGv83LcElAUGjAIuqpc3Q9SiLrE84p1gzfsHYw0NzcnLa6ht 04jOUq/ij6Nv8kA8TlmqUCrDdgz8034QXhO8mNlR7Jv0i/xh20np87SNwq2bClE3w7sBpqarzO CklE1I6ETs60O8TllW6JYDvQA9B+LWrd0OULpBq0krFA58+dvh9qrpZilqGp8Ix6rsZlTrGokA eKg= X-SBRS: 3.7 X-MesageID: 24093202 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,430,1589256000"; d="scan'208";a="24093202" Subject: Re: [PATCH 03/10] x86emul: extend decoding / mem access testing to MMX / SSE insns To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <97ca3d9c-7540-c7b1-cf84-34c75c9127df@suse.com> <197bf5e9-5246-abfb-3870-6ca3dbaee152@suse.com> From: Andrew Cooper Message-ID: Date: Mon, 3 Aug 2020 17:42:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <197bf5e9-5246-abfb-3870-6ca3dbaee152@suse.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 03/08/2020 15:50, Jan Beulich wrote: > IOW just legacy encoded ones. For 3dNow! just one example is used, as > they're all similar in nature both encoding- and operand-wise. > > Adjust a slightly misleading (but not wrong) memcpy() invocation, as > noticed while further cloning that code. I don't see any adjustment, in this or later patches. Is the comment stale? ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Aug 03 16:47:38 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 16:47:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2dcb-0007xS-1J; Mon, 03 Aug 2020 16:47:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2dcZ-0007xN-G5 for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 16:47:31 +0000 X-Inumbo-ID: 05710384-d5a9-11ea-90ad-bc764e2007e4 Received: from mail-ot1-x344.google.com (unknown [2607:f8b0:4864:20::344]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 05710384-d5a9-11ea-90ad-bc764e2007e4; Mon, 03 Aug 2020 16:47:30 +0000 (UTC) Received: by mail-ot1-x344.google.com with SMTP id h16so8330682oti.7 for ; Mon, 03 Aug 2020 09:47:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Usm/6h7N16x/wxM5TKQj5tj8P/i4BtTOOcp5csWYt4E=; b=Jtau3XcM89LL3xC7TEe3GAnS7qK4+9cw0OpAxEnX7eHGqhKSVKHxv0ZFe1n4UocDiA mW0JPWncTOEo2yO35nkxh4aFn+zGw2+aA4W/ReCP+h2fpz95V0mGkSoe9+AGG6RNt4ch Jwreu92lFF2+ySGmCXMOAecee4CVLUmQkNR1yDr1NqMMb3Fg6XX4+bmy2fH+dTx1wY+v TzPBygU05qkqPaKHH/lHj1kz20jXTapGgQ0iNov7HTY+sv7HLw7LbiCaMPlXdU4dPNK+ ZloEswYISPKAZjCx7GJJBFVR6+KTg8gK9eNt3s8ELOQq+2DbPNembJz0OX6ZR/Lit81t zS3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Usm/6h7N16x/wxM5TKQj5tj8P/i4BtTOOcp5csWYt4E=; b=ZUR4hnhTcctoRDGoIXe5BJmpB0DlM+kN1pIsPG1+S63PQgJnlmYjM+Fr9SxoaUKwVC qB0kRS26s2aEJidnt96b+F4SXP0oAu7GcmZkWed487Db1/lRGXv5EbtnqH2u91VlhZL3 Rzj19wv8yUEFIL4Aw+Kwj7FUAxG2VSQO1BMdKLnjz/VMD8fG4fsIz0Nj0vDMZ1+Rzsqp CiKk29NOKjNuXHx04qPW9FQCF/K0NfxnYbbObfU7p4lXesOwVPF5Yi6cHoXkH2maNgOP 7+s9EjEpRJnnwHNMTAaxVOqCSirnrMp9R/M6bNiWrJ+c40MMLft/wkhRomVi0q/9DQzW XGfQ== X-Gm-Message-State: AOAM531EI3mb3HIuVm4j2un2xfmWccFyV4dzpapOKuee5zA4WHe68PVo m354Y7cs9kq0tV/DCDhNu8jD7jxtTuKLAchm0I+m/w== X-Google-Smtp-Source: ABdhPJwL8bSuuMVu8QUpkQn41wKe+w9UJyQ8uUsj7OLcjzkDx+JlDczU0zS8LbPssRy+Hp1/anGlBwmjDitZlITg0E4= X-Received: by 2002:a9d:39c2:: with SMTP id y60mr14280078otb.91.1596473250307; Mon, 03 Aug 2020 09:47:30 -0700 (PDT) MIME-Version: 1.0 References: <20200728100925.10454-1-philmd@redhat.com> <20200803163515.GD2866@perard.uk.xensource.com> In-Reply-To: <20200803163515.GD2866@perard.uk.xensource.com> From: Peter Maydell Date: Mon, 3 Aug 2020 17:47:19 +0100 Message-ID: Subject: Re: [PATCH-for-5.1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects To: Anthony PERARD Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Paul Durrant , Paul Durrant , QEMU Developers , "open list:X86" , Paolo Bonzini , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Mon, 3 Aug 2020 at 17:35, Anthony PERARD wro= te: > > On Tue, Jul 28, 2020 at 12:09:25PM +0200, Philippe Mathieu-Daud=C3=A9 wro= te: > > CONFIG_XEN is generated by configure and stored in "config-target.h", > > which is (obviously) only include for target-specific objects. > > This is a problem for target-agnostic objects as CONFIG_XEN is never > > defined and xen_enabled() is always inlined as 'false'. > > > > Fix by following the KVM schema, defining CONFIG_XEN_IS_POSSIBLE > > when we don't know to force the call of the non-inlined function, > > returning the xen_allowed boolean. > > > > Fixes: da278d58a092 ("accel: Move Xen accelerator code under accel/xen/= ") > > Reported-by: Paul Durrant > > Suggested-by: Peter Maydell > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > > Reviewed-by: Anthony PERARD Note that rc3 is tomorrow so if you want this in 5.1 it would be a good idea to send a pullreq with it today... thanks -- PMM From xen-devel-bounces@lists.xenproject.org Mon Aug 03 16:53:14 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 16:53:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2di4-0000O9-Vn; Mon, 03 Aug 2020 16:53:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2di3-0000Lq-4j for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 16:53:11 +0000 X-Inumbo-ID: cc940269-d5a9-11ea-90ad-bc764e2007e4 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cc940269-d5a9-11ea-90ad-bc764e2007e4; Mon, 03 Aug 2020 16:53:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596473586; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=9FHDzk5jP15PoxSFIG/3+YaZpBrml62Q4eCYIN4d3r8=; b=Ky7VFNfUWN3Ydkd6hSyzTAp5UOfdE1XawX/uIot6MKPXY2BB9PLX7Hre WkhDiSoOG7ZIn2GATbMd5IMG+f8vugk3FbFa1zxseqdToYJPOsykbq6my flTnNQBVJmu88005+FYJWZR626PI2R190ocbGg664gQKMiYeOGEkFtCYx Y=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: oUizAzmZsbSPZfoucDhfLS3pp0o7C2fWvjF+HDf1ttDC08KVHWjcrG9PSqvQEBlqwv7JfCsNJg KCy83IsZWZRsis0vuW7kgTSt+MMgZXZ+KS0DXMtCnQpOnMZhrI1FX40OU3B/wgDdsEnUOyATwI YGlqEHb4rjBDjM8DRxExaVRzI5gZBGVI/J4h1Yz/Z3M8sxVwADYTCpUUhHCazqv8hug5gRb/Hu hBufHPAFCnV3pAUWFdL0u0BlUmLObj1z3j3Dd5PBli5UqhkzPWegs5b2fpiRvCJrtJwWcEzGnr Bec= X-SBRS: 3.7 X-MesageID: 23941194 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,430,1589256000"; d="scan'208";a="23941194" From: Anthony PERARD To: Subject: [PULL 1/1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects Date: Mon, 3 Aug 2020 17:52:51 +0100 Message-ID: <20200803165251.907213-2-anthony.perard@citrix.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200803165251.907213-1-anthony.perard@citrix.com> References: <20200803165251.907213-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony PERARD , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Philippe Mathieu-Daudé CONFIG_XEN is generated by configure and stored in "config-target.h", which is (obviously) only include for target-specific objects. This is a problem for target-agnostic objects as CONFIG_XEN is never defined and xen_enabled() is always inlined as 'false'. Fix by following the KVM schema, defining CONFIG_XEN_IS_POSSIBLE when we don't know to force the call of the non-inlined function, returning the xen_allowed boolean. Fixes: da278d58a092 ("accel: Move Xen accelerator code under accel/xen/") Reported-by: Paul Durrant Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Anthony PERARD Tested-by: Paul Durrant Message-Id: <20200728100925.10454-1-philmd@redhat.com> Signed-off-by: Anthony PERARD --- include/sysemu/xen.h | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/include/sysemu/xen.h b/include/sysemu/xen.h index 1ca292715e69..385a1fa2bff8 100644 --- a/include/sysemu/xen.h +++ b/include/sysemu/xen.h @@ -8,7 +8,15 @@ #ifndef SYSEMU_XEN_H #define SYSEMU_XEN_H -#ifdef CONFIG_XEN +#ifdef NEED_CPU_H +# ifdef CONFIG_XEN +# define CONFIG_XEN_IS_POSSIBLE +# endif +#else +# define CONFIG_XEN_IS_POSSIBLE +#endif + +#ifdef CONFIG_XEN_IS_POSSIBLE bool xen_enabled(void); @@ -18,7 +26,7 @@ void xen_ram_alloc(ram_addr_t ram_addr, ram_addr_t size, struct MemoryRegion *mr, Error **errp); #endif -#else /* !CONFIG_XEN */ +#else /* !CONFIG_XEN_IS_POSSIBLE */ #define xen_enabled() 0 #ifndef CONFIG_USER_ONLY @@ -33,6 +41,6 @@ static inline void xen_ram_alloc(ram_addr_t ram_addr, ram_addr_t size, } #endif -#endif /* CONFIG_XEN */ +#endif /* CONFIG_XEN_IS_POSSIBLE */ #endif -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Mon Aug 03 16:53:14 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 16:53:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2dhz-0000Ml-N2; Mon, 03 Aug 2020 16:53:07 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2dhy-0000Lq-Bq for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 16:53:06 +0000 X-Inumbo-ID: cc940268-d5a9-11ea-90ad-bc764e2007e4 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cc940268-d5a9-11ea-90ad-bc764e2007e4; Mon, 03 Aug 2020 16:53:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596473585; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=qUEzT/sythxNJ9sGpLp+qH5wmPU56dvfrIxZ3Qy2z3c=; b=BqeI4v5NTx3zl8AJtVKibCRO6SAhloXxc9MMwcmN9Qy5G4Hszyj5bpQj ni947T/JFWJQ7TqDzVZ02wRunpXZttuTvrKk+eKyObDDFJLYnhgYhAoJx Ngw6EfBC7IUzIy7Tmi/qZPk6U3g6+rnzr7hN9VD6fQGzw3HPX7M4Fj5IR E=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: Hs8xDfMQ8nyk+/4NscBbN7hK37UarIUXmgFSJxkAi2tcwAHYMYp0cMsfQwhouMF5pAnfi1xWv1 dOG1ygyAZdGvaL5BcbMAeVBkVY3OqVTXE5R+/r6tP19JlyXRUPvBT0E8HZSHdCLXMMpAyHBhYu 6GaPljbE5m3QcoAlEmh66MNNzO2R5dD99GvpB000qX0zt3k/e3XveVApjzhwMOL1ahkOeLwh4i fAbtOfz7Xo741x4nrVNSn0S1RaIR1shXFDHO9GbHMZ8nAzoerHiXpZB2RIoVzXfCmAVCLRa8Ah 6Hc= X-SBRS: 3.7 X-MesageID: 23750296 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,430,1589256000"; d="scan'208";a="23750296" From: Anthony PERARD To: Subject: [PULL 0/1] xen queue 2020-08-03 Date: Mon, 3 Aug 2020 17:52:50 +0100 Message-ID: <20200803165251.907213-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony PERARD , Peter Maydell , xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" The following changes since commit 45a150aa2b3492acf6691c7bdbeb25a8545d8345: Merge remote-tracking branch 'remotes/ericb/tags/pull-bitmaps-2020-08-03' into staging (2020-08-03 15:13:49 +0100) are available in the Git repository at: https://xenbits.xen.org/git-http/people/aperard/qemu-dm.git tags/pull-xen-20200803 for you to fetch changes up to b3fcc98f391e9a60a369d825333b852871cf67b0: accel/xen: Fix xen_enabled() behavior on target-agnostic objects (2020-08-03 17:39:38 +0100) ---------------------------------------------------------------- xen patches bug fix ---------------------------------------------------------------- Philippe Mathieu-Daudé (1): accel/xen: Fix xen_enabled() behavior on target-agnostic objects include/sysemu/xen.h | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) From xen-devel-bounces@lists.xenproject.org Mon Aug 03 17:20:50 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 17:20:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2e8V-00030k-9G; Mon, 03 Aug 2020 17:20:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2e8U-00030f-DD for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 17:20:30 +0000 X-Inumbo-ID: 9fa61120-d5ad-11ea-90b7-bc764e2007e4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9fa61120-d5ad-11ea-90b7-bc764e2007e4; Mon, 03 Aug 2020 17:20:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=j9+XfHZa5t+2gHTsK1jfPpeFQRrAZkgzlhEbG1+kA3c=; b=t/3XWqvG109x+Dm1k+iUIYdih DrHOjYVseEJMpbEP9TK3yWLRSUI1jSV7d011XDd6grMtYBSv0dDLT5wfdDU2caCJgJ/JSTrmoHhXc cWiv+LGmyZZm9VPTDL/6Nhlq0SenBuWn4qbf3f/k/lRy752UnLnOA7FEOcba/HjnhJ0iQ=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2e8Q-0007YR-PH; Mon, 03 Aug 2020 17:20:26 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k2e8Q-0003Ac-9Q; Mon, 03 Aug 2020 17:20:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k2e8Q-0004pf-8p; Mon, 03 Aug 2020 17:20:26 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 152398: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-libvirt-xsm:guest-start/debian.repeat:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking X-Osstest-Versions-This: linux=ac3a0c8472969a03c0496ae774b3a29eb26c8d5a X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Mon, 03 Aug 2020 17:20:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152398 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/152398/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-libvirt-xsm 16 guest-start/debian.repeat fail REGR. vs. 152332 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 10 debian-hvm-install fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail like 152332 test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 152332 test-armhf-armhf-libvirt 14 saverestore-support-check fail like 152332 test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail like 152332 test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail like 152332 test-amd64-i386-xl-pvshim 12 guest-start fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass version targeted for testing: linux ac3a0c8472969a03c0496ae774b3a29eb26c8d5a baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 2 days Failing since 152366 2020-08-01 20:49:34 Z 1 days 2 attempts Testing same since 152398 2020-08-02 18:47:39 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Aaron Brown Aaron Ma Akash Asthana Al Viro Alaa Hleihel Alex Veber Amit Cohen Andrew Cagney Andrii Nakryiko Arnaldo Carvalho de Melo Aya Levin Ben Hutchings Christian Brauner Christoph Hellwig Cong Wang Daniel Borkmann David Howells David S. Miller David Woodhouse Douglas Anderson Eran Ben Elisha Felix Fietkau Francesco Ruggeri Frank Wunderlich Guillaume Nault Guojia Liao Hangbin Liu Herbert Xu Huazhong Tan Ido Schimmel Jakub Kicinski Jean-Philippe Brucker Jian Shen Jianbo Liu Johan Hovold Johannes Berg Joyce Ooi Julian Squires Landen Chao laurent brando Linus Torvalds Linus Walleij liujian Lu Wei Maor Dickman Maor Gottlieb Mark Salyzyn Martin Varghese Matthieu Baerts Nick Bowler Paolo Abeni Parav Pandit Pavel Machek (CIP) Pavel Machek Peilin Ye Philippe Duplessis-Guindon Raed Salem Rajkumar Manoharan Remi Pommarel René van Dorst Rodrigo Madera Ron Diskin Roopa Prabhu Rustam Kovhaev Sabrina Dubroca Saeed Mahameed Salvatore Bonaccorso Santosh Shilimkar Shannon Nelson Song Liu Steffen Klassert Subbaraya Sundeep Sunil Goutham Taehee Yoo Tanner Love Thomas Falcon Thomas Richter Tobias Brunner Tony Nguyen Vasanthakumar Thiagarajan Vladimir Oltean Wang Hai Wei Li Willem de Bruijn Wolfram Sang Wolfram Sang Xin Long Xin Tan Xin Xiong Xiyu Yang Yangbo Lu Yonglong Liu Yunsheng Lin jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 3065 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Aug 03 17:28:14 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 17:28:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2eFu-0003FC-7z; Mon, 03 Aug 2020 17:28:10 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2eFs-0003EM-IO for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 17:28:08 +0000 X-Inumbo-ID: b16d7618-d5ae-11ea-af66-12813bfff9fa Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b16d7618-d5ae-11ea-af66-12813bfff9fa; Mon, 03 Aug 2020 17:28:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=jmyjTvBlJf219FGZqE6H9Lx7vxS+CFpPcS85FIstZBQ=; b=H+BvLWGG7p98/EBTs7UGa5i6x p3UkMY96YKAI+WJo2FJzgsPT5+NroI7xoR8UORvTcUSdhFNPB/gzmwGQjxyyCrIqjlKwbXcyPCpVz BIUI5rGSyCLmpVQqHVmtsI4+JnPMcFuT8RFQIqVwSexYqGzpdVPNCS6lluM377wCX9pYo=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2eFp-0007jF-QW; Mon, 03 Aug 2020 17:28:05 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k2eFp-00040S-Cf; Mon, 03 Aug 2020 17:28:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k2eFp-0001Iq-C4; Mon, 03 Aug 2020 17:28:05 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 152428: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=9909532113692020c1b50eb974cac47d4ea10e69 X-Osstest-Versions-That: xen=81fd0d3ca4b2cd309403c6e8da662c325dd35750 From: osstest service owner Date: Mon, 03 Aug 2020 17:28:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152428 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/152428/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass version targeted for testing: xen 9909532113692020c1b50eb974cac47d4ea10e69 baseline version: xen 81fd0d3ca4b2cd309403c6e8da662c325dd35750 Last test of basis 152334 2020-07-31 20:01:29 Z 2 days Testing same since 152428 2020-08-03 15:03:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 81fd0d3ca4..9909532113 9909532113692020c1b50eb974cac47d4ea10e69 -> smoke From xen-devel-bounces@lists.xenproject.org Mon Aug 03 18:22:03 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 18:22:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2f5x-0008Fz-4r; Mon, 03 Aug 2020 18:21:57 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2f5w-0008F4-6W for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 18:21:56 +0000 X-Inumbo-ID: 3188cb0d-d5b6-11ea-90c4-bc764e2007e4 Received: from mail-lf1-x141.google.com (unknown [2a00:1450:4864:20::141]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3188cb0d-d5b6-11ea-90c4-bc764e2007e4; Mon, 03 Aug 2020 18:21:48 +0000 (UTC) Received: by mail-lf1-x141.google.com with SMTP id b11so20987266lfe.10 for ; Mon, 03 Aug 2020 11:21:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=oslIVtwtHBl5F3ZhQAPxrDGKrXRg4UKsfSDdvc5ciUQ=; b=XjS6U4v4PSxa1s3IfmNtC3cWuXvF7nIUasRVK2guc6ntXJJAHaL0mrU8joAIIvYweP 5THry527m+O7psZ3j7XNum5igWNb7Bik4NYBcmwLcCeHzrbOA948vb2hLndQ+QRQ5M/9 reN+IcpKVZaQlgxIXKL4XPnXEYNM+Rbz7xguH3dWq3++rLoQ5qsulqsDGbpU/WClvzrw v5Bvw3RV0xj+qh+5ooSIpQVZsUDGuVmG/zZdlWdTWTzTHVFKhnvKmDlnanVA+MHQkcyA nuZlQ+Nsx9tUO9qy0gGabRQZScyHIKApfOj8UHxkBtyK+C4jgQXQfEOdQp/61KXD20Zh hD9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=oslIVtwtHBl5F3ZhQAPxrDGKrXRg4UKsfSDdvc5ciUQ=; b=dH5TERHIS5J4t7mAvwYWbeMaKLtdUn13HGsitaVP1A5Ke9XnZEf83j2cbJVikD/W9E Ye8is4a3eZS4rzv6y7nNb1ubrtYmj+5hN3lL34gD6f/FPMAAhQ+1Cjdu2VPtxpSBo065 Kz2AQhXJ1CnG9/ZRmTYBXv0cnQ+o6GhudJ2pzmrKa2BVXsn8vFFCZ9kUxGNQ4pq0PK72 PYq1wpd4fvUtS18I3QKTJ+2JvrTAfto7eQ/+36dO5qjZPxqimUsGCP0+3f/4xEUxU5C5 Gc8NpRaKU2yPq6Y3ScqPB4E/mnybEsZftdBvJit2cPZMkhqy7nL8U4iuU04TsLLP/QCC C14w== X-Gm-Message-State: AOAM533KYj4iQv7XB4900AyXFVtFRt4HY/FAjcuOtmL7Ch7G//QaT1+P epEIiIArnEvKoIVJBefJzIo3zS5zm20= X-Google-Smtp-Source: ABdhPJxOLAttpeuy9/RgN7qjnqDLVPrgno1Gy+KRXHv9MzMDEQy+mv7bT2weMP+GR17sWoTcH/sXyg== X-Received: by 2002:ac2:46d0:: with SMTP id p16mr9369899lfo.142.1596478907282; Mon, 03 Aug 2020 11:21:47 -0700 (PDT) Received: from otyshchenko.www.tendawifi.com ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id h18sm4486730ljk.7.2020.08.03.11.21.46 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Aug 2020 11:21:46 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Subject: [RFC PATCH V1 03/12] xen/mm: Make x86's XENMEM_resource_ioreq_server handling common Date: Mon, 3 Aug 2020 21:21:19 +0300 Message-Id: <1596478888-23030-4-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Julien Grall , Jan Beulich , Volodymyr Babchuk , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Oleksandr Tyshchenko As x86 implementation of XENMEM_resource_ioreq_server can be re-used on Arm later on, this patch makes it common and removes arch_acquire_resource as unneeded. This support is going to be used on Arm to be able run device emulator outside of Xen hypervisor. Please note, this is a split/cleanup of Julien's PoC: "Add support for Guest IO forwarding to a device emulator" Signed-off-by: Julien Grall Signed-off-by: Oleksandr Tyshchenko --- xen/arch/x86/mm.c | 45 --------------------------------------------- xen/common/memory.c | 45 +++++++++++++++++++++++++++++++++++++++++++-- xen/include/asm-arm/mm.h | 8 -------- xen/include/asm-x86/mm.h | 4 ---- 4 files changed, 43 insertions(+), 59 deletions(-) diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 2b06e15..33238d0 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -99,7 +99,6 @@ * doing the final put_page(), and remove it from the iommu if so. */ -#include #include #include #include @@ -4600,50 +4599,6 @@ int xenmem_add_to_physmap_one( return rc; } -int arch_acquire_resource(struct domain *d, unsigned int type, - unsigned int id, unsigned long frame, - unsigned int nr_frames, xen_pfn_t mfn_list[]) -{ - int rc; - - switch ( type ) - { -#ifdef CONFIG_HVM - case XENMEM_resource_ioreq_server: - { - ioservid_t ioservid = id; - unsigned int i; - - rc = -EINVAL; - if ( !is_hvm_domain(d) ) - break; - - if ( id != (unsigned int)ioservid ) - break; - - rc = 0; - for ( i = 0; i < nr_frames; i++ ) - { - mfn_t mfn; - - rc = hvm_get_ioreq_server_frame(d, id, frame + i, &mfn); - if ( rc ) - break; - - mfn_list[i] = mfn_x(mfn); - } - break; - } -#endif - - default: - rc = -EOPNOTSUPP; - break; - } - - return rc; -} - long arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg) { int rc; diff --git a/xen/common/memory.c b/xen/common/memory.c index 714077c..9283e5e 100644 --- a/xen/common/memory.c +++ b/xen/common/memory.c @@ -30,6 +30,10 @@ #include #include +#ifdef CONFIG_IOREQ_SERVER +#include +#endif + #ifdef CONFIG_X86 #include #endif @@ -1045,6 +1049,38 @@ static int acquire_grant_table(struct domain *d, unsigned int id, return 0; } +#ifdef CONFIG_IOREQ_SERVER +static int acquire_ioreq_server(struct domain *d, + unsigned int id, + unsigned long frame, + unsigned int nr_frames, + xen_pfn_t mfn_list[]) +{ + ioservid_t ioservid = id; + unsigned int i; + int rc; + + if ( !is_hvm_domain(d) ) + return -EINVAL; + + if ( id != (unsigned int)ioservid ) + return -EINVAL; + + for ( i = 0; i < nr_frames; i++ ) + { + mfn_t mfn; + + rc = hvm_get_ioreq_server_frame(d, id, frame + i, &mfn); + if ( rc ) + return rc; + + mfn_list[i] = mfn_x(mfn); + } + + return 0; +} +#endif + static int acquire_resource( XEN_GUEST_HANDLE_PARAM(xen_mem_acquire_resource_t) arg) { @@ -1095,9 +1131,14 @@ static int acquire_resource( mfn_list); break; +#ifdef CONFIG_IOREQ_SERVER + case XENMEM_resource_ioreq_server: + rc = acquire_ioreq_server(d, xmar.id, xmar.frame, xmar.nr_frames, + mfn_list); + break; +#endif default: - rc = arch_acquire_resource(d, xmar.type, xmar.id, xmar.frame, - xmar.nr_frames, mfn_list); + rc = -EOPNOTSUPP; break; } diff --git a/xen/include/asm-arm/mm.h b/xen/include/asm-arm/mm.h index f8ba49b..0b7de31 100644 --- a/xen/include/asm-arm/mm.h +++ b/xen/include/asm-arm/mm.h @@ -358,14 +358,6 @@ static inline void put_page_and_type(struct page_info *page) void clear_and_clean_page(struct page_info *page); -static inline -int arch_acquire_resource(struct domain *d, unsigned int type, unsigned int id, - unsigned long frame, unsigned int nr_frames, - xen_pfn_t mfn_list[]) -{ - return -EOPNOTSUPP; -} - unsigned int arch_get_dma_bitsize(void); #endif /* __ARCH_ARM_MM__ */ diff --git a/xen/include/asm-x86/mm.h b/xen/include/asm-x86/mm.h index 7e74996..2e111ad 100644 --- a/xen/include/asm-x86/mm.h +++ b/xen/include/asm-x86/mm.h @@ -649,8 +649,4 @@ static inline bool arch_mfn_in_directmap(unsigned long mfn) return mfn <= (virt_to_mfn(eva - 1) + 1); } -int arch_acquire_resource(struct domain *d, unsigned int type, - unsigned int id, unsigned long frame, - unsigned int nr_frames, xen_pfn_t mfn_list[]); - #endif /* __ASM_X86_MM_H__ */ -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 18:22:05 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 18:22:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2f5r-0008FL-Oq; Mon, 03 Aug 2020 18:21:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2f5r-0008F4-6E for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 18:21:51 +0000 X-Inumbo-ID: 30e6dd89-d5b6-11ea-90c4-bc764e2007e4 Received: from mail-lf1-x142.google.com (unknown [2a00:1450:4864:20::142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 30e6dd89-d5b6-11ea-90c4-bc764e2007e4; Mon, 03 Aug 2020 18:21:48 +0000 (UTC) Received: by mail-lf1-x142.google.com with SMTP id v15so16439298lfg.6 for ; Mon, 03 Aug 2020 11:21:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=0pU51lNIwHO5FoiBaR+EgnZXTe7Q2y5dW6t5E4s4GE0=; b=L5rF3KgsFvlVDo98woCwm4BaIz0k1rw0Xb4mS4wjytQGLduPEYVmvXPlKnzl5eD2Dt 69gVtlQ8s8gZWWofa3fLHq4aL5utJswNMUyS2ioZ1zlUww0TmLKNjvdEdtjxQsu+W1ql MPHYGq4ODov5OkpZidV2htaLqN4fd9SEFRtLZg+dzR9wg9th5Byi581AqwmrGxa2AZwt u7AmKOlKST+qcTugoOtBDlf64kf5jTnwlKdXeN4BloHGgsYj4+Nak6/TUiF17YQRuCh/ cRllifyG/soLz5YAOIqLQIjNE2g7N8APkwQKZ83PhuLUnG6cR6eEiIztphqniRDOcrMV J5Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=0pU51lNIwHO5FoiBaR+EgnZXTe7Q2y5dW6t5E4s4GE0=; b=MaoLHE2n+wYmR8bbgaohtGEKt4bjeE3iDE50wbSO2kRQqbXxGkmAoJJ91gJo4GSLQZ yLwZAkVDwlJFyIKZnMo4J6XKh+EYIzK7sXlC+8dMd2KywPv+MrE6FtbRakgvzirvvhJd mvn6vw1uecXxO7sD87ybTqnoTHm+F/1ejBaovtg1oY89gFRDUlDHmItq7yuooxiLzf/L ZIhInek8Iwcy9BQBEvdTrJ+naOceYRpzkx6Bf8K9MkXp65HkCwyPt7a//HMd8jWQAWum sGXmwQybZiQH79J4kqVDkfj9RbHX+sQS6XnerDx2Yx6lp32GkLgANARiYFVRU3wV8+5w GoHg== X-Gm-Message-State: AOAM530KSeaJoAKS/KkfSim2faUjENTxG+Ho7bv7yyrbn5d015glBE5I tBxw1yh+ITVL2FFIOvYS9jrMZXA0Gkg= X-Google-Smtp-Source: ABdhPJxAh1cGoaamlcK3AxiJn33g5R3UYun+leBRiIIdErmvieI0n2cMaaIqQ9LXWTrYBOFj3QtFNg== X-Received: by 2002:a05:6512:5c7:: with SMTP id o7mr9496108lfo.124.1596478906122; Mon, 03 Aug 2020 11:21:46 -0700 (PDT) Received: from otyshchenko.www.tendawifi.com ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id h18sm4486730ljk.7.2020.08.03.11.21.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Aug 2020 11:21:45 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Subject: [RFC PATCH V1 02/12] hvm/dm: Make x86's DM feature common Date: Mon, 3 Aug 2020 21:21:18 +0300 Message-Id: <1596478888-23030-3-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Julien Grall , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Oleksandr Tyshchenko As a lot of x86 code can be re-used on Arm later on, this patch splits devicemodel support into common and arch specific parts. This support is going to be used on Arm to be able run device emulator outside of Xen hypervisor. Please note, this is a split/cleanup of Julien's PoC: "Add support for Guest IO forwarding to a device emulator" Signed-off-by: Julien Grall Signed-off-by: Oleksandr Tyshchenko --- xen/arch/x86/hvm/dm.c | 287 +++----------------------------------------- xen/common/hvm/Makefile | 1 + xen/common/hvm/dm.c | 287 ++++++++++++++++++++++++++++++++++++++++++++ xen/include/xen/hypercall.h | 12 ++ 4 files changed, 319 insertions(+), 268 deletions(-) create mode 100644 xen/common/hvm/dm.c diff --git a/xen/arch/x86/hvm/dm.c b/xen/arch/x86/hvm/dm.c index 70adb27..fb1ff09 100644 --- a/xen/arch/x86/hvm/dm.c +++ b/xen/arch/x86/hvm/dm.c @@ -29,13 +29,6 @@ #include -struct dmop_args { - domid_t domid; - unsigned int nr_bufs; - /* Reserve enough buf elements for all current hypercalls. */ - struct xen_dm_op_buf buf[2]; -}; - static bool _raw_copy_from_guest_buf_offset(void *dst, const struct dmop_args *args, unsigned int buf_idx, @@ -337,148 +330,20 @@ static int inject_event(struct domain *d, return 0; } -static int dm_op(const struct dmop_args *op_args) +int arch_dm_op(struct xen_dm_op *op, struct domain *d, + const struct dmop_args *op_args, bool *const_op) { - struct domain *d; - struct xen_dm_op op; - bool const_op = true; long rc; - size_t offset; - - static const uint8_t op_size[] = { - [XEN_DMOP_create_ioreq_server] = sizeof(struct xen_dm_op_create_ioreq_server), - [XEN_DMOP_get_ioreq_server_info] = sizeof(struct xen_dm_op_get_ioreq_server_info), - [XEN_DMOP_map_io_range_to_ioreq_server] = sizeof(struct xen_dm_op_ioreq_server_range), - [XEN_DMOP_unmap_io_range_from_ioreq_server] = sizeof(struct xen_dm_op_ioreq_server_range), - [XEN_DMOP_set_ioreq_server_state] = sizeof(struct xen_dm_op_set_ioreq_server_state), - [XEN_DMOP_destroy_ioreq_server] = sizeof(struct xen_dm_op_destroy_ioreq_server), - [XEN_DMOP_track_dirty_vram] = sizeof(struct xen_dm_op_track_dirty_vram), - [XEN_DMOP_set_pci_intx_level] = sizeof(struct xen_dm_op_set_pci_intx_level), - [XEN_DMOP_set_isa_irq_level] = sizeof(struct xen_dm_op_set_isa_irq_level), - [XEN_DMOP_set_pci_link_route] = sizeof(struct xen_dm_op_set_pci_link_route), - [XEN_DMOP_modified_memory] = sizeof(struct xen_dm_op_modified_memory), - [XEN_DMOP_set_mem_type] = sizeof(struct xen_dm_op_set_mem_type), - [XEN_DMOP_inject_event] = sizeof(struct xen_dm_op_inject_event), - [XEN_DMOP_inject_msi] = sizeof(struct xen_dm_op_inject_msi), - [XEN_DMOP_map_mem_type_to_ioreq_server] = sizeof(struct xen_dm_op_map_mem_type_to_ioreq_server), - [XEN_DMOP_remote_shutdown] = sizeof(struct xen_dm_op_remote_shutdown), - [XEN_DMOP_relocate_memory] = sizeof(struct xen_dm_op_relocate_memory), - [XEN_DMOP_pin_memory_cacheattr] = sizeof(struct xen_dm_op_pin_memory_cacheattr), - }; - - rc = rcu_lock_remote_domain_by_id(op_args->domid, &d); - if ( rc ) - return rc; - - if ( !is_hvm_domain(d) ) - goto out; - - rc = xsm_dm_op(XSM_DM_PRIV, d); - if ( rc ) - goto out; - - offset = offsetof(struct xen_dm_op, u); - - rc = -EFAULT; - if ( op_args->buf[0].size < offset ) - goto out; - - if ( copy_from_guest_offset((void *)&op, op_args->buf[0].h, 0, offset) ) - goto out; - - if ( op.op >= ARRAY_SIZE(op_size) ) - { - rc = -EOPNOTSUPP; - goto out; - } - - op.op = array_index_nospec(op.op, ARRAY_SIZE(op_size)); - - if ( op_args->buf[0].size < offset + op_size[op.op] ) - goto out; - - if ( copy_from_guest_offset((void *)&op.u, op_args->buf[0].h, offset, - op_size[op.op]) ) - goto out; - - rc = -EINVAL; - if ( op.pad ) - goto out; - - switch ( op.op ) - { - case XEN_DMOP_create_ioreq_server: - { - struct xen_dm_op_create_ioreq_server *data = - &op.u.create_ioreq_server; - - const_op = false; - - rc = -EINVAL; - if ( data->pad[0] || data->pad[1] || data->pad[2] ) - break; - - rc = hvm_create_ioreq_server(d, data->handle_bufioreq, - &data->id); - break; - } - case XEN_DMOP_get_ioreq_server_info: + switch ( op->op ) { - struct xen_dm_op_get_ioreq_server_info *data = - &op.u.get_ioreq_server_info; - const uint16_t valid_flags = XEN_DMOP_no_gfns; - - const_op = false; - - rc = -EINVAL; - if ( data->flags & ~valid_flags ) - break; - - rc = hvm_get_ioreq_server_info(d, data->id, - (data->flags & XEN_DMOP_no_gfns) ? - NULL : &data->ioreq_gfn, - (data->flags & XEN_DMOP_no_gfns) ? - NULL : &data->bufioreq_gfn, - &data->bufioreq_port); - break; - } - - case XEN_DMOP_map_io_range_to_ioreq_server: - { - const struct xen_dm_op_ioreq_server_range *data = - &op.u.map_io_range_to_ioreq_server; - - rc = -EINVAL; - if ( data->pad ) - break; - - rc = hvm_map_io_range_to_ioreq_server(d, data->id, data->type, - data->start, data->end); - break; - } - - case XEN_DMOP_unmap_io_range_from_ioreq_server: - { - const struct xen_dm_op_ioreq_server_range *data = - &op.u.unmap_io_range_from_ioreq_server; - - rc = -EINVAL; - if ( data->pad ) - break; - - rc = hvm_unmap_io_range_from_ioreq_server(d, data->id, data->type, - data->start, data->end); - break; - } - case XEN_DMOP_map_mem_type_to_ioreq_server: { struct xen_dm_op_map_mem_type_to_ioreq_server *data = - &op.u.map_mem_type_to_ioreq_server; + &op->u.map_mem_type_to_ioreq_server; unsigned long first_gfn = data->opaque; - const_op = false; + *const_op = false; rc = -EOPNOTSUPP; if ( !hap_enabled(d) ) @@ -522,36 +387,10 @@ static int dm_op(const struct dmop_args *op_args) break; } - case XEN_DMOP_set_ioreq_server_state: - { - const struct xen_dm_op_set_ioreq_server_state *data = - &op.u.set_ioreq_server_state; - - rc = -EINVAL; - if ( data->pad ) - break; - - rc = hvm_set_ioreq_server_state(d, data->id, !!data->enabled); - break; - } - - case XEN_DMOP_destroy_ioreq_server: - { - const struct xen_dm_op_destroy_ioreq_server *data = - &op.u.destroy_ioreq_server; - - rc = -EINVAL; - if ( data->pad ) - break; - - rc = hvm_destroy_ioreq_server(d, data->id); - break; - } - case XEN_DMOP_track_dirty_vram: { const struct xen_dm_op_track_dirty_vram *data = - &op.u.track_dirty_vram; + &op->u.track_dirty_vram; rc = -EINVAL; if ( data->pad ) @@ -567,7 +406,7 @@ static int dm_op(const struct dmop_args *op_args) case XEN_DMOP_set_pci_intx_level: { const struct xen_dm_op_set_pci_intx_level *data = - &op.u.set_pci_intx_level; + &op->u.set_pci_intx_level; rc = set_pci_intx_level(d, data->domain, data->bus, data->device, data->intx, @@ -578,7 +417,7 @@ static int dm_op(const struct dmop_args *op_args) case XEN_DMOP_set_isa_irq_level: { const struct xen_dm_op_set_isa_irq_level *data = - &op.u.set_isa_irq_level; + &op->u.set_isa_irq_level; rc = set_isa_irq_level(d, data->isa_irq, data->level); break; @@ -587,7 +426,7 @@ static int dm_op(const struct dmop_args *op_args) case XEN_DMOP_set_pci_link_route: { const struct xen_dm_op_set_pci_link_route *data = - &op.u.set_pci_link_route; + &op->u.set_pci_link_route; rc = hvm_set_pci_link_route(d, data->link, data->isa_irq); break; @@ -596,19 +435,19 @@ static int dm_op(const struct dmop_args *op_args) case XEN_DMOP_modified_memory: { struct xen_dm_op_modified_memory *data = - &op.u.modified_memory; + &op->u.modified_memory; rc = modified_memory(d, op_args, data); - const_op = !rc; + *const_op = !rc; break; } case XEN_DMOP_set_mem_type: { struct xen_dm_op_set_mem_type *data = - &op.u.set_mem_type; + &op->u.set_mem_type; - const_op = false; + *const_op = false; rc = -EINVAL; if ( data->pad ) @@ -621,7 +460,7 @@ static int dm_op(const struct dmop_args *op_args) case XEN_DMOP_inject_event: { const struct xen_dm_op_inject_event *data = - &op.u.inject_event; + &op->u.inject_event; rc = -EINVAL; if ( data->pad0 || data->pad1 ) @@ -634,7 +473,7 @@ static int dm_op(const struct dmop_args *op_args) case XEN_DMOP_inject_msi: { const struct xen_dm_op_inject_msi *data = - &op.u.inject_msi; + &op->u.inject_msi; rc = -EINVAL; if ( data->pad ) @@ -647,7 +486,7 @@ static int dm_op(const struct dmop_args *op_args) case XEN_DMOP_remote_shutdown: { const struct xen_dm_op_remote_shutdown *data = - &op.u.remote_shutdown; + &op->u.remote_shutdown; domain_shutdown(d, data->reason); rc = 0; @@ -656,7 +495,7 @@ static int dm_op(const struct dmop_args *op_args) case XEN_DMOP_relocate_memory: { - struct xen_dm_op_relocate_memory *data = &op.u.relocate_memory; + struct xen_dm_op_relocate_memory *data = &op->u.relocate_memory; struct xen_add_to_physmap xatp = { .domid = op_args->domid, .size = data->size, @@ -679,7 +518,7 @@ static int dm_op(const struct dmop_args *op_args) data->size -= rc; data->src_gfn += rc; data->dst_gfn += rc; - const_op = false; + *const_op = false; rc = -ERESTART; } break; @@ -688,7 +527,7 @@ static int dm_op(const struct dmop_args *op_args) case XEN_DMOP_pin_memory_cacheattr: { const struct xen_dm_op_pin_memory_cacheattr *data = - &op.u.pin_memory_cacheattr; + &op->u.pin_memory_cacheattr; if ( data->pad ) { @@ -706,94 +545,6 @@ static int dm_op(const struct dmop_args *op_args) break; } - if ( (!rc || rc == -ERESTART) && - !const_op && copy_to_guest_offset(op_args->buf[0].h, offset, - (void *)&op.u, op_size[op.op]) ) - rc = -EFAULT; - - out: - rcu_unlock_domain(d); - - return rc; -} - -CHECK_dm_op_create_ioreq_server; -CHECK_dm_op_get_ioreq_server_info; -CHECK_dm_op_ioreq_server_range; -CHECK_dm_op_set_ioreq_server_state; -CHECK_dm_op_destroy_ioreq_server; -CHECK_dm_op_track_dirty_vram; -CHECK_dm_op_set_pci_intx_level; -CHECK_dm_op_set_isa_irq_level; -CHECK_dm_op_set_pci_link_route; -CHECK_dm_op_modified_memory; -CHECK_dm_op_set_mem_type; -CHECK_dm_op_inject_event; -CHECK_dm_op_inject_msi; -CHECK_dm_op_remote_shutdown; -CHECK_dm_op_relocate_memory; -CHECK_dm_op_pin_memory_cacheattr; - -int compat_dm_op(domid_t domid, - unsigned int nr_bufs, - XEN_GUEST_HANDLE_PARAM(void) bufs) -{ - struct dmop_args args; - unsigned int i; - int rc; - - if ( nr_bufs > ARRAY_SIZE(args.buf) ) - return -E2BIG; - - args.domid = domid; - args.nr_bufs = array_index_nospec(nr_bufs, ARRAY_SIZE(args.buf) + 1); - - for ( i = 0; i < args.nr_bufs; i++ ) - { - struct compat_dm_op_buf cmp; - - if ( copy_from_guest_offset(&cmp, bufs, i, 1) ) - return -EFAULT; - -#define XLAT_dm_op_buf_HNDL_h(_d_, _s_) \ - guest_from_compat_handle((_d_)->h, (_s_)->h) - - XLAT_dm_op_buf(&args.buf[i], &cmp); - -#undef XLAT_dm_op_buf_HNDL_h - } - - rc = dm_op(&args); - - if ( rc == -ERESTART ) - rc = hypercall_create_continuation(__HYPERVISOR_dm_op, "iih", - domid, nr_bufs, bufs); - - return rc; -} - -long do_dm_op(domid_t domid, - unsigned int nr_bufs, - XEN_GUEST_HANDLE_PARAM(xen_dm_op_buf_t) bufs) -{ - struct dmop_args args; - int rc; - - if ( nr_bufs > ARRAY_SIZE(args.buf) ) - return -E2BIG; - - args.domid = domid; - args.nr_bufs = array_index_nospec(nr_bufs, ARRAY_SIZE(args.buf) + 1); - - if ( copy_from_guest_offset(&args.buf[0], bufs, 0, args.nr_bufs) ) - return -EFAULT; - - rc = dm_op(&args); - - if ( rc == -ERESTART ) - rc = hypercall_create_continuation(__HYPERVISOR_dm_op, "iih", - domid, nr_bufs, bufs); - return rc; } diff --git a/xen/common/hvm/Makefile b/xen/common/hvm/Makefile index 326215d..335fcc9 100644 --- a/xen/common/hvm/Makefile +++ b/xen/common/hvm/Makefile @@ -1 +1,2 @@ +obj-y += dm.o obj-y += ioreq.o diff --git a/xen/common/hvm/dm.c b/xen/common/hvm/dm.c new file mode 100644 index 0000000..09e9542 --- /dev/null +++ b/xen/common/hvm/dm.c @@ -0,0 +1,287 @@ +/* + * Copyright (c) 2016 Citrix Systems Inc. + * Copyright (c) 2019 Arm ltd. + * + * This program is free software; you can redistribute it and/or modify it + * under the terms and conditions of the GNU General Public License, + * version 2, as published by the Free Software Foundation. + * + * This program is distributed in the hope it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + * + * You should have received a copy of the GNU General Public License along with + * this program; If not, see . + */ + +#include +#include +#include +#include + +static int dm_op(const struct dmop_args *op_args) +{ + struct domain *d; + struct xen_dm_op op; + long rc; + bool const_op = true; + const size_t offset = offsetof(struct xen_dm_op, u); + + static const uint8_t op_size[] = { + [XEN_DMOP_create_ioreq_server] = sizeof(struct xen_dm_op_create_ioreq_server), + [XEN_DMOP_get_ioreq_server_info] = sizeof(struct xen_dm_op_get_ioreq_server_info), + [XEN_DMOP_map_io_range_to_ioreq_server] = sizeof(struct xen_dm_op_ioreq_server_range), + [XEN_DMOP_unmap_io_range_from_ioreq_server] = sizeof(struct xen_dm_op_ioreq_server_range), + [XEN_DMOP_set_ioreq_server_state] = sizeof(struct xen_dm_op_set_ioreq_server_state), + [XEN_DMOP_destroy_ioreq_server] = sizeof(struct xen_dm_op_destroy_ioreq_server), + [XEN_DMOP_track_dirty_vram] = sizeof(struct xen_dm_op_track_dirty_vram), + [XEN_DMOP_set_pci_intx_level] = sizeof(struct xen_dm_op_set_pci_intx_level), + [XEN_DMOP_set_isa_irq_level] = sizeof(struct xen_dm_op_set_isa_irq_level), + [XEN_DMOP_set_pci_link_route] = sizeof(struct xen_dm_op_set_pci_link_route), + [XEN_DMOP_modified_memory] = sizeof(struct xen_dm_op_modified_memory), + [XEN_DMOP_set_mem_type] = sizeof(struct xen_dm_op_set_mem_type), + [XEN_DMOP_inject_event] = sizeof(struct xen_dm_op_inject_event), + [XEN_DMOP_inject_msi] = sizeof(struct xen_dm_op_inject_msi), + [XEN_DMOP_map_mem_type_to_ioreq_server] = sizeof(struct xen_dm_op_map_mem_type_to_ioreq_server), + [XEN_DMOP_remote_shutdown] = sizeof(struct xen_dm_op_remote_shutdown), + [XEN_DMOP_relocate_memory] = sizeof(struct xen_dm_op_relocate_memory), + [XEN_DMOP_pin_memory_cacheattr] = sizeof(struct xen_dm_op_pin_memory_cacheattr), + }; + + rc = rcu_lock_remote_domain_by_id(op_args->domid, &d); + if ( rc ) + return rc; + + if ( !is_hvm_domain(d) ) + goto out; + + rc = xsm_dm_op(XSM_DM_PRIV, d); + if ( rc ) + goto out; + + rc = -EFAULT; + if ( op_args->buf[0].size < offset ) + goto out; + + if ( copy_from_guest_offset((void *)&op, op_args->buf[0].h, 0, offset) ) + goto out; + + if ( op.op >= ARRAY_SIZE(op_size) ) + { + rc = -EOPNOTSUPP; + goto out; + } + + op.op = array_index_nospec(op.op, ARRAY_SIZE(op_size)); + + if ( op_args->buf[0].size < offset + op_size[op.op] ) + goto out; + + if ( copy_from_guest_offset((void *)&op.u, op_args->buf[0].h, offset, + op_size[op.op]) ) + goto out; + + rc = -EINVAL; + if ( op.pad ) + goto out; + + switch ( op.op ) + { + case XEN_DMOP_create_ioreq_server: + { + struct xen_dm_op_create_ioreq_server *data = + &op.u.create_ioreq_server; + + const_op = false; + + rc = -EINVAL; + if ( data->pad[0] || data->pad[1] || data->pad[2] ) + break; + + rc = hvm_create_ioreq_server(d, data->handle_bufioreq, + &data->id); + break; + } + + case XEN_DMOP_get_ioreq_server_info: + { + struct xen_dm_op_get_ioreq_server_info *data = + &op.u.get_ioreq_server_info; + const uint16_t valid_flags = XEN_DMOP_no_gfns; + + const_op = false; + + rc = -EINVAL; + if ( data->flags & ~valid_flags ) + break; + + rc = hvm_get_ioreq_server_info(d, data->id, + (data->flags & XEN_DMOP_no_gfns) ? + NULL : (unsigned long *)&data->ioreq_gfn, + (data->flags & XEN_DMOP_no_gfns) ? + NULL : (unsigned long *)&data->bufioreq_gfn, + &data->bufioreq_port); + break; + } + + case XEN_DMOP_map_io_range_to_ioreq_server: + { + const struct xen_dm_op_ioreq_server_range *data = + &op.u.map_io_range_to_ioreq_server; + + rc = -EINVAL; + if ( data->pad ) + break; + + rc = hvm_map_io_range_to_ioreq_server(d, data->id, data->type, + data->start, data->end); + break; + } + + case XEN_DMOP_unmap_io_range_from_ioreq_server: + { + const struct xen_dm_op_ioreq_server_range *data = + &op.u.unmap_io_range_from_ioreq_server; + + rc = -EINVAL; + if ( data->pad ) + break; + + rc = hvm_unmap_io_range_from_ioreq_server(d, data->id, data->type, + data->start, data->end); + break; + } + + case XEN_DMOP_set_ioreq_server_state: + { + const struct xen_dm_op_set_ioreq_server_state *data = + &op.u.set_ioreq_server_state; + + rc = -EINVAL; + if ( data->pad ) + break; + + rc = hvm_set_ioreq_server_state(d, data->id, !!data->enabled); + break; + } + + case XEN_DMOP_destroy_ioreq_server: + { + const struct xen_dm_op_destroy_ioreq_server *data = + &op.u.destroy_ioreq_server; + + rc = -EINVAL; + if ( data->pad ) + break; + + rc = hvm_destroy_ioreq_server(d, data->id); + break; + } + + default: + rc = arch_dm_op(&op, d, op_args, &const_op); + } + + if ( (!rc || rc == -ERESTART) && + !const_op && copy_to_guest_offset(op_args->buf[0].h, offset, + (void *)&op.u, op_size[op.op]) ) + rc = -EFAULT; + + out: + rcu_unlock_domain(d); + + return rc; +} + +#ifdef CONFIG_COMPAT +CHECK_dm_op_create_ioreq_server; +CHECK_dm_op_get_ioreq_server_info; +CHECK_dm_op_ioreq_server_range; +CHECK_dm_op_set_ioreq_server_state; +CHECK_dm_op_destroy_ioreq_server; +CHECK_dm_op_track_dirty_vram; +CHECK_dm_op_set_pci_intx_level; +CHECK_dm_op_set_isa_irq_level; +CHECK_dm_op_set_pci_link_route; +CHECK_dm_op_modified_memory; +CHECK_dm_op_set_mem_type; +CHECK_dm_op_inject_event; +CHECK_dm_op_inject_msi; +CHECK_dm_op_remote_shutdown; +CHECK_dm_op_relocate_memory; +CHECK_dm_op_pin_memory_cacheattr; + +int compat_dm_op(domid_t domid, + unsigned int nr_bufs, + XEN_GUEST_HANDLE_PARAM(void) bufs) +{ + struct dmop_args args; + unsigned int i; + int rc; + + if ( nr_bufs > ARRAY_SIZE(args.buf) ) + return -E2BIG; + + args.domid = domid; + args.nr_bufs = array_index_nospec(nr_bufs, ARRAY_SIZE(args.buf) + 1); + + for ( i = 0; i < args.nr_bufs; i++ ) + { + struct compat_dm_op_buf cmp; + + if ( copy_from_guest_offset(&cmp, bufs, i, 1) ) + return -EFAULT; + +#define XLAT_dm_op_buf_HNDL_h(_d_, _s_) \ + guest_from_compat_handle((_d_)->h, (_s_)->h) + + XLAT_dm_op_buf(&args.buf[i], &cmp); + +#undef XLAT_dm_op_buf_HNDL_h + } + + rc = dm_op(&args); + + if ( rc == -ERESTART ) + rc = hypercall_create_continuation(__HYPERVISOR_dm_op, "iih", + domid, nr_bufs, bufs); + + return rc; +} +#endif + +long do_dm_op(domid_t domid, + unsigned int nr_bufs, + XEN_GUEST_HANDLE_PARAM(xen_dm_op_buf_t) bufs) +{ + struct dmop_args args; + int rc; + + if ( nr_bufs > ARRAY_SIZE(args.buf) ) + return -E2BIG; + + args.domid = domid; + args.nr_bufs = array_index_nospec(nr_bufs, ARRAY_SIZE(args.buf) + 1); + + if ( copy_from_guest_offset(&args.buf[0], bufs, 0, args.nr_bufs) ) + return -EFAULT; + + rc = dm_op(&args); + + if ( rc == -ERESTART ) + rc = hypercall_create_continuation(__HYPERVISOR_dm_op, "iih", + domid, nr_bufs, bufs); + + return rc; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/include/xen/hypercall.h b/xen/include/xen/hypercall.h index 655acc7..19f509f 100644 --- a/xen/include/xen/hypercall.h +++ b/xen/include/xen/hypercall.h @@ -150,6 +150,18 @@ do_dm_op( unsigned int nr_bufs, XEN_GUEST_HANDLE_PARAM(xen_dm_op_buf_t) bufs); +struct dmop_args { + domid_t domid; + unsigned int nr_bufs; + /* Reserve enough buf elements for all current hypercalls. */ + struct xen_dm_op_buf buf[2]; +}; + +int arch_dm_op(struct xen_dm_op *op, + struct domain *d, + const struct dmop_args *op_args, + bool *const_op); + #ifdef CONFIG_HYPFS extern long do_hypfs_op( -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 18:22:05 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 18:22:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2f62-0008Gn-DK; Mon, 03 Aug 2020 18:22:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2f61-0008F4-6d for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 18:22:01 +0000 X-Inumbo-ID: 306e3785-d5b6-11ea-90c4-bc764e2007e4 Received: from mail-lf1-x143.google.com (unknown [2a00:1450:4864:20::143]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 306e3785-d5b6-11ea-90c4-bc764e2007e4; Mon, 03 Aug 2020 18:21:47 +0000 (UTC) Received: by mail-lf1-x143.google.com with SMTP id m15so20303250lfp.7 for ; Mon, 03 Aug 2020 11:21:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=SgPounakxdj3HtZ9qbiGo1zoQqRXX+aIAAD6NC3cqAA=; b=HhMbLvg3fg4aCR6fsnd1FBCT062tQqJzZiC+5xqsuGA7jnj88Qjy6AEWBsj8P5Vtsx MdHido/oWgwF5dz8pNUChSc6hej7b1B/MRt7BucrkrCekVN7WEzlOLvjTqFGrZjmLoZV Kx6q0/Vpmr34WFdmfcF9wvo4Oxx8e30ZHS3sGByk+NebGL+G0wTfz8SOfPTe8dHOqdW9 XnB5kGkgPS2UZBICfVKKUAu+51Al3JiJKxmwVHtzv27uDb1n5vI5qBRDx8R1+dZG6fkg cF+Q1nrC+OSh/9TugQZ/fTuZ6Fp+CwU7oyQRQ4SYFbw42NCBODf5BXMGkQV+EFnM3cml /qAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=SgPounakxdj3HtZ9qbiGo1zoQqRXX+aIAAD6NC3cqAA=; b=PvW4DI9uag7C1QtmiYNhOMui5ywVEOFI8JgMdvAaEViWPObK3EsPXSY7ukeUQ979Ae fxkV2/H8Jn+OF52kwq9dNjUEfwtKNeE2xK0jwNTUrBvrJZ3RcxRwC0OzMOm5ejMcIrEf ErVZOIUi2DuSl6yJogLN33em7wo6W91E74exs2WQ9IP6OhHR+b4t9tbMQaFb5fZD90Fu bk/4zQLwT9vMHBCl/m8u4eNkh5poSQ+YjOi3uRMoKDJkhpAQmVx3NtSSg6MORJhH3K5F Ks6liIfH0AJCbnsqrKkig1OW1BVxu1V+4LJLxN3bTVPXTSdu7gsc0hrFgXuUqg2XdDle +2sg== X-Gm-Message-State: AOAM532/Nh1cAyJxHsR7DYf2JqYrdwU8s71Hk41U6/c45cE/5lwboPxk A9HtNDkAJIYaj/kajShxHEvoCr5RwDE= X-Google-Smtp-Source: ABdhPJwgh7P6XQin4fOMZhcfe6ygtRGL+QwSG0ONkKOqBa4xbUnNX1BC3Ecw0HofIklym10jONBc6A== X-Received: by 2002:a05:6512:523:: with SMTP id o3mr9023231lfc.212.1596478904919; Mon, 03 Aug 2020 11:21:44 -0700 (PDT) Received: from otyshchenko.www.tendawifi.com ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id h18sm4486730ljk.7.2020.08.03.11.21.43 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Aug 2020 11:21:44 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Subject: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common Date: Mon, 3 Aug 2020 21:21:17 +0300 Message-Id: <1596478888-23030-2-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Tian , Stefano Stabellini , Julien Grall , Jun Nakajima , Wei Liu , Paul Durrant , Andrew Cooper , Ian Jackson , George Dunlap , Tim Deegan , Oleksandr Tyshchenko , Julien Grall , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Oleksandr Tyshchenko As a lot of x86 code can be re-used on Arm later on, this patch splits IOREQ support into common and arch specific parts. This support is going to be used on Arm to be able run device emulator outside of Xen hypervisor. Please note, this is a split/cleanup of Julien's PoC: "Add support for Guest IO forwarding to a device emulator" Signed-off-by: Julien Grall Signed-off-by: Oleksandr Tyshchenko --- xen/arch/x86/Kconfig | 1 + xen/arch/x86/hvm/dm.c | 2 +- xen/arch/x86/hvm/emulate.c | 2 +- xen/arch/x86/hvm/hvm.c | 2 +- xen/arch/x86/hvm/io.c | 2 +- xen/arch/x86/hvm/ioreq.c | 1431 +-------------------------------------- xen/arch/x86/hvm/stdvga.c | 2 +- xen/arch/x86/hvm/vmx/realmode.c | 1 + xen/arch/x86/hvm/vmx/vvmx.c | 2 +- xen/arch/x86/mm.c | 2 +- xen/arch/x86/mm/shadow/common.c | 2 +- xen/common/Kconfig | 3 + xen/common/Makefile | 1 + xen/common/hvm/Makefile | 1 + xen/common/hvm/ioreq.c | 1430 ++++++++++++++++++++++++++++++++++++++ xen/include/asm-x86/hvm/ioreq.h | 45 +- xen/include/asm-x86/hvm/vcpu.h | 7 - xen/include/xen/hvm/ioreq.h | 89 +++ 18 files changed, 1575 insertions(+), 1450 deletions(-) create mode 100644 xen/common/hvm/Makefile create mode 100644 xen/common/hvm/ioreq.c create mode 100644 xen/include/xen/hvm/ioreq.h diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig index a636a4b..f5a9f87 100644 --- a/xen/arch/x86/Kconfig +++ b/xen/arch/x86/Kconfig @@ -91,6 +91,7 @@ config PV_LINEAR_PT config HVM def_bool !PV_SHIM_EXCLUSIVE + select IOREQ_SERVER prompt "HVM support" ---help--- Interfaces to support HVM domains. HVM domains require hardware diff --git a/xen/arch/x86/hvm/dm.c b/xen/arch/x86/hvm/dm.c index e3f8451..70adb27 100644 --- a/xen/arch/x86/hvm/dm.c +++ b/xen/arch/x86/hvm/dm.c @@ -16,13 +16,13 @@ #include #include +#include #include #include #include #include #include -#include #include #include diff --git a/xen/arch/x86/hvm/emulate.c b/xen/arch/x86/hvm/emulate.c index 8b4e73a..78993b3 100644 --- a/xen/arch/x86/hvm/emulate.c +++ b/xen/arch/x86/hvm/emulate.c @@ -9,6 +9,7 @@ * Keir Fraser */ +#include #include #include #include @@ -20,7 +21,6 @@ #include #include #include -#include #include #include #include diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 5bb4758..c05025d 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -19,6 +19,7 @@ */ #include +#include #include #include #include @@ -64,7 +65,6 @@ #include #include #include -#include #include #include #include diff --git a/xen/arch/x86/hvm/io.c b/xen/arch/x86/hvm/io.c index 724ab44..5d501d1 100644 --- a/xen/arch/x86/hvm/io.c +++ b/xen/arch/x86/hvm/io.c @@ -18,6 +18,7 @@ * this program; If not, see . */ +#include #include #include #include @@ -35,7 +36,6 @@ #include #include #include -#include #include #include #include diff --git a/xen/arch/x86/hvm/ioreq.c b/xen/arch/x86/hvm/ioreq.c index 7240070..dd21e85 100644 --- a/xen/arch/x86/hvm/ioreq.c +++ b/xen/arch/x86/hvm/ioreq.c @@ -17,6 +17,7 @@ */ #include +#include #include #include #include @@ -28,1069 +29,16 @@ #include #include -#include -#include -#include -#include - -#include -#include - -static void set_ioreq_server(struct domain *d, unsigned int id, - struct hvm_ioreq_server *s) -{ - ASSERT(id < MAX_NR_IOREQ_SERVERS); - ASSERT(!s || !d->arch.hvm.ioreq_server.server[id]); - - d->arch.hvm.ioreq_server.server[id] = s; -} - -#define GET_IOREQ_SERVER(d, id) \ - (d)->arch.hvm.ioreq_server.server[id] - -static struct hvm_ioreq_server *get_ioreq_server(const struct domain *d, - unsigned int id) -{ - if ( id >= MAX_NR_IOREQ_SERVERS ) - return NULL; - - return GET_IOREQ_SERVER(d, id); -} - -/* - * Iterate over all possible ioreq servers. - * - * NOTE: The iteration is backwards such that more recently created - * ioreq servers are favoured in hvm_select_ioreq_server(). - * This is a semantic that previously existed when ioreq servers - * were held in a linked list. - */ -#define FOR_EACH_IOREQ_SERVER(d, id, s) \ - for ( (id) = MAX_NR_IOREQ_SERVERS; (id) != 0; ) \ - if ( !(s = GET_IOREQ_SERVER(d, --(id))) ) \ - continue; \ - else - -static ioreq_t *get_ioreq(struct hvm_ioreq_server *s, struct vcpu *v) -{ - shared_iopage_t *p = s->ioreq.va; - - ASSERT((v == current) || !vcpu_runnable(v)); - ASSERT(p != NULL); - - return &p->vcpu_ioreq[v->vcpu_id]; -} - -bool hvm_io_pending(struct vcpu *v) -{ - struct domain *d = v->domain; - struct hvm_ioreq_server *s; - unsigned int id; - - FOR_EACH_IOREQ_SERVER(d, id, s) - { - struct hvm_ioreq_vcpu *sv; - - list_for_each_entry ( sv, - &s->ioreq_vcpu_list, - list_entry ) - { - if ( sv->vcpu == v && sv->pending ) - return true; - } - } - - return false; -} - -static void hvm_io_assist(struct hvm_ioreq_vcpu *sv, uint64_t data) -{ - struct vcpu *v = sv->vcpu; - ioreq_t *ioreq = &v->arch.hvm.hvm_io.io_req; - - if ( hvm_ioreq_needs_completion(ioreq) ) - ioreq->data = data; - - sv->pending = false; -} - -static bool hvm_wait_for_io(struct hvm_ioreq_vcpu *sv, ioreq_t *p) -{ - unsigned int prev_state = STATE_IOREQ_NONE; - - while ( sv->pending ) - { - unsigned int state = p->state; - - smp_rmb(); - - recheck: - if ( unlikely(state == STATE_IOREQ_NONE) ) - { - /* - * The only reason we should see this case is when an - * emulator is dying and it races with an I/O being - * requested. - */ - hvm_io_assist(sv, ~0ul); - break; - } - - if ( unlikely(state < prev_state) ) - { - gdprintk(XENLOG_ERR, "Weird HVM ioreq state transition %u -> %u\n", - prev_state, state); - sv->pending = false; - domain_crash(sv->vcpu->domain); - return false; /* bail */ - } - - switch ( prev_state = state ) - { - case STATE_IORESP_READY: /* IORESP_READY -> NONE */ - p->state = STATE_IOREQ_NONE; - hvm_io_assist(sv, p->data); - break; - case STATE_IOREQ_READY: /* IOREQ_{READY,INPROCESS} -> IORESP_READY */ - case STATE_IOREQ_INPROCESS: - wait_on_xen_event_channel(sv->ioreq_evtchn, - ({ state = p->state; - smp_rmb(); - state != prev_state; })); - goto recheck; - default: - gdprintk(XENLOG_ERR, "Weird HVM iorequest state %u\n", state); - sv->pending = false; - domain_crash(sv->vcpu->domain); - return false; /* bail */ - } - } - - return true; -} - -bool handle_hvm_io_completion(struct vcpu *v) -{ - struct domain *d = v->domain; - struct hvm_vcpu_io *vio = &v->arch.hvm.hvm_io; - struct hvm_ioreq_server *s; - enum hvm_io_completion io_completion; - unsigned int id; - - if ( has_vpci(d) && vpci_process_pending(v) ) - { - raise_softirq(SCHEDULE_SOFTIRQ); - return false; - } - - FOR_EACH_IOREQ_SERVER(d, id, s) - { - struct hvm_ioreq_vcpu *sv; - - list_for_each_entry ( sv, - &s->ioreq_vcpu_list, - list_entry ) - { - if ( sv->vcpu == v && sv->pending ) - { - if ( !hvm_wait_for_io(sv, get_ioreq(s, v)) ) - return false; - - break; - } - } - } - - vio->io_req.state = hvm_ioreq_needs_completion(&vio->io_req) ? - STATE_IORESP_READY : STATE_IOREQ_NONE; - - msix_write_completion(v); - vcpu_end_shutdown_deferral(v); - - io_completion = vio->io_completion; - vio->io_completion = HVMIO_no_completion; - - switch ( io_completion ) - { - case HVMIO_no_completion: - break; - - case HVMIO_mmio_completion: - return handle_mmio(); - - case HVMIO_pio_completion: - return handle_pio(vio->io_req.addr, vio->io_req.size, - vio->io_req.dir); - - case HVMIO_realmode_completion: - { - struct hvm_emulate_ctxt ctxt; - - hvm_emulate_init_once(&ctxt, NULL, guest_cpu_user_regs()); - vmx_realmode_emulate_one(&ctxt); - hvm_emulate_writeback(&ctxt); - - break; - } - default: - ASSERT_UNREACHABLE(); - break; - } - - return true; -} - -static gfn_t hvm_alloc_legacy_ioreq_gfn(struct hvm_ioreq_server *s) -{ - struct domain *d = s->target; - unsigned int i; - - BUILD_BUG_ON(HVM_PARAM_BUFIOREQ_PFN != HVM_PARAM_IOREQ_PFN + 1); - - for ( i = HVM_PARAM_IOREQ_PFN; i <= HVM_PARAM_BUFIOREQ_PFN; i++ ) - { - if ( !test_and_clear_bit(i, &d->arch.hvm.ioreq_gfn.legacy_mask) ) - return _gfn(d->arch.hvm.params[i]); - } - - return INVALID_GFN; -} - -static gfn_t hvm_alloc_ioreq_gfn(struct hvm_ioreq_server *s) -{ - struct domain *d = s->target; - unsigned int i; - - for ( i = 0; i < sizeof(d->arch.hvm.ioreq_gfn.mask) * 8; i++ ) - { - if ( test_and_clear_bit(i, &d->arch.hvm.ioreq_gfn.mask) ) - return _gfn(d->arch.hvm.ioreq_gfn.base + i); - } - - /* - * If we are out of 'normal' GFNs then we may still have a 'legacy' - * GFN available. - */ - return hvm_alloc_legacy_ioreq_gfn(s); -} - -static bool hvm_free_legacy_ioreq_gfn(struct hvm_ioreq_server *s, - gfn_t gfn) -{ - struct domain *d = s->target; - unsigned int i; - - for ( i = HVM_PARAM_IOREQ_PFN; i <= HVM_PARAM_BUFIOREQ_PFN; i++ ) - { - if ( gfn_eq(gfn, _gfn(d->arch.hvm.params[i])) ) - break; - } - if ( i > HVM_PARAM_BUFIOREQ_PFN ) - return false; - - set_bit(i, &d->arch.hvm.ioreq_gfn.legacy_mask); - return true; -} - -static void hvm_free_ioreq_gfn(struct hvm_ioreq_server *s, gfn_t gfn) -{ - struct domain *d = s->target; - unsigned int i = gfn_x(gfn) - d->arch.hvm.ioreq_gfn.base; - - ASSERT(!gfn_eq(gfn, INVALID_GFN)); - - if ( !hvm_free_legacy_ioreq_gfn(s, gfn) ) - { - ASSERT(i < sizeof(d->arch.hvm.ioreq_gfn.mask) * 8); - set_bit(i, &d->arch.hvm.ioreq_gfn.mask); - } -} - -static void hvm_unmap_ioreq_gfn(struct hvm_ioreq_server *s, bool buf) -{ - struct hvm_ioreq_page *iorp = buf ? &s->bufioreq : &s->ioreq; - - if ( gfn_eq(iorp->gfn, INVALID_GFN) ) - return; - - destroy_ring_for_helper(&iorp->va, iorp->page); - iorp->page = NULL; - - hvm_free_ioreq_gfn(s, iorp->gfn); - iorp->gfn = INVALID_GFN; -} - -static int hvm_map_ioreq_gfn(struct hvm_ioreq_server *s, bool buf) -{ - struct domain *d = s->target; - struct hvm_ioreq_page *iorp = buf ? &s->bufioreq : &s->ioreq; - int rc; - - if ( iorp->page ) - { - /* - * If a page has already been allocated (which will happen on - * demand if hvm_get_ioreq_server_frame() is called), then - * mapping a guest frame is not permitted. - */ - if ( gfn_eq(iorp->gfn, INVALID_GFN) ) - return -EPERM; - - return 0; - } - - if ( d->is_dying ) - return -EINVAL; - - iorp->gfn = hvm_alloc_ioreq_gfn(s); - - if ( gfn_eq(iorp->gfn, INVALID_GFN) ) - return -ENOMEM; - - rc = prepare_ring_for_helper(d, gfn_x(iorp->gfn), &iorp->page, - &iorp->va); - - if ( rc ) - hvm_unmap_ioreq_gfn(s, buf); - - return rc; -} - -static int hvm_alloc_ioreq_mfn(struct hvm_ioreq_server *s, bool buf) -{ - struct hvm_ioreq_page *iorp = buf ? &s->bufioreq : &s->ioreq; - struct page_info *page; - - if ( iorp->page ) - { - /* - * If a guest frame has already been mapped (which may happen - * on demand if hvm_get_ioreq_server_info() is called), then - * allocating a page is not permitted. - */ - if ( !gfn_eq(iorp->gfn, INVALID_GFN) ) - return -EPERM; - - return 0; - } - - page = alloc_domheap_page(s->target, MEMF_no_refcount); - - if ( !page ) - return -ENOMEM; - - if ( !get_page_and_type(page, s->target, PGT_writable_page) ) - { - /* - * The domain can't possibly know about this page yet, so failure - * here is a clear indication of something fishy going on. - */ - domain_crash(s->emulator); - return -ENODATA; - } - - iorp->va = __map_domain_page_global(page); - if ( !iorp->va ) - goto fail; - - iorp->page = page; - clear_page(iorp->va); - return 0; - - fail: - put_page_alloc_ref(page); - put_page_and_type(page); - - return -ENOMEM; -} - -static void hvm_free_ioreq_mfn(struct hvm_ioreq_server *s, bool buf) -{ - struct hvm_ioreq_page *iorp = buf ? &s->bufioreq : &s->ioreq; - struct page_info *page = iorp->page; - - if ( !page ) - return; - - iorp->page = NULL; - - unmap_domain_page_global(iorp->va); - iorp->va = NULL; - - put_page_alloc_ref(page); - put_page_and_type(page); -} - -bool is_ioreq_server_page(struct domain *d, const struct page_info *page) -{ - const struct hvm_ioreq_server *s; - unsigned int id; - bool found = false; - - spin_lock_recursive(&d->arch.hvm.ioreq_server.lock); - - FOR_EACH_IOREQ_SERVER(d, id, s) - { - if ( (s->ioreq.page == page) || (s->bufioreq.page == page) ) - { - found = true; - break; - } - } - - spin_unlock_recursive(&d->arch.hvm.ioreq_server.lock); - - return found; -} - -static void hvm_remove_ioreq_gfn(struct hvm_ioreq_server *s, bool buf) - -{ - struct domain *d = s->target; - struct hvm_ioreq_page *iorp = buf ? &s->bufioreq : &s->ioreq; - - if ( gfn_eq(iorp->gfn, INVALID_GFN) ) - return; - - if ( guest_physmap_remove_page(d, iorp->gfn, - page_to_mfn(iorp->page), 0) ) - domain_crash(d); - clear_page(iorp->va); -} - -static int hvm_add_ioreq_gfn(struct hvm_ioreq_server *s, bool buf) -{ - struct domain *d = s->target; - struct hvm_ioreq_page *iorp = buf ? &s->bufioreq : &s->ioreq; - int rc; - - if ( gfn_eq(iorp->gfn, INVALID_GFN) ) - return 0; - - clear_page(iorp->va); - - rc = guest_physmap_add_page(d, iorp->gfn, - page_to_mfn(iorp->page), 0); - if ( rc == 0 ) - paging_mark_pfn_dirty(d, _pfn(gfn_x(iorp->gfn))); - - return rc; -} - -static void hvm_update_ioreq_evtchn(struct hvm_ioreq_server *s, - struct hvm_ioreq_vcpu *sv) -{ - ASSERT(spin_is_locked(&s->lock)); - - if ( s->ioreq.va != NULL ) - { - ioreq_t *p = get_ioreq(s, sv->vcpu); - - p->vp_eport = sv->ioreq_evtchn; - } -} - -#define HANDLE_BUFIOREQ(s) \ - ((s)->bufioreq_handling != HVM_IOREQSRV_BUFIOREQ_OFF) - -static int hvm_ioreq_server_add_vcpu(struct hvm_ioreq_server *s, - struct vcpu *v) -{ - struct hvm_ioreq_vcpu *sv; - int rc; - - sv = xzalloc(struct hvm_ioreq_vcpu); - - rc = -ENOMEM; - if ( !sv ) - goto fail1; - - spin_lock(&s->lock); - - rc = alloc_unbound_xen_event_channel(v->domain, v->vcpu_id, - s->emulator->domain_id, NULL); - if ( rc < 0 ) - goto fail2; - - sv->ioreq_evtchn = rc; - - if ( v->vcpu_id == 0 && HANDLE_BUFIOREQ(s) ) - { - rc = alloc_unbound_xen_event_channel(v->domain, 0, - s->emulator->domain_id, NULL); - if ( rc < 0 ) - goto fail3; - - s->bufioreq_evtchn = rc; - } - - sv->vcpu = v; - - list_add(&sv->list_entry, &s->ioreq_vcpu_list); - - if ( s->enabled ) - hvm_update_ioreq_evtchn(s, sv); - - spin_unlock(&s->lock); - return 0; - - fail3: - free_xen_event_channel(v->domain, sv->ioreq_evtchn); - - fail2: - spin_unlock(&s->lock); - xfree(sv); - - fail1: - return rc; -} - -static void hvm_ioreq_server_remove_vcpu(struct hvm_ioreq_server *s, - struct vcpu *v) -{ - struct hvm_ioreq_vcpu *sv; - - spin_lock(&s->lock); - - list_for_each_entry ( sv, - &s->ioreq_vcpu_list, - list_entry ) - { - if ( sv->vcpu != v ) - continue; - - list_del(&sv->list_entry); - - if ( v->vcpu_id == 0 && HANDLE_BUFIOREQ(s) ) - free_xen_event_channel(v->domain, s->bufioreq_evtchn); - - free_xen_event_channel(v->domain, sv->ioreq_evtchn); - - xfree(sv); - break; - } - - spin_unlock(&s->lock); -} - -static void hvm_ioreq_server_remove_all_vcpus(struct hvm_ioreq_server *s) -{ - struct hvm_ioreq_vcpu *sv, *next; - - spin_lock(&s->lock); - - list_for_each_entry_safe ( sv, - next, - &s->ioreq_vcpu_list, - list_entry ) - { - struct vcpu *v = sv->vcpu; - - list_del(&sv->list_entry); - - if ( v->vcpu_id == 0 && HANDLE_BUFIOREQ(s) ) - free_xen_event_channel(v->domain, s->bufioreq_evtchn); - - free_xen_event_channel(v->domain, sv->ioreq_evtchn); - - xfree(sv); - } - - spin_unlock(&s->lock); -} - -static int hvm_ioreq_server_map_pages(struct hvm_ioreq_server *s) -{ - int rc; - - rc = hvm_map_ioreq_gfn(s, false); - - if ( !rc && HANDLE_BUFIOREQ(s) ) - rc = hvm_map_ioreq_gfn(s, true); - - if ( rc ) - hvm_unmap_ioreq_gfn(s, false); - - return rc; -} - -static void hvm_ioreq_server_unmap_pages(struct hvm_ioreq_server *s) -{ - hvm_unmap_ioreq_gfn(s, true); - hvm_unmap_ioreq_gfn(s, false); -} - -static int hvm_ioreq_server_alloc_pages(struct hvm_ioreq_server *s) -{ - int rc; - - rc = hvm_alloc_ioreq_mfn(s, false); - - if ( !rc && (s->bufioreq_handling != HVM_IOREQSRV_BUFIOREQ_OFF) ) - rc = hvm_alloc_ioreq_mfn(s, true); - - if ( rc ) - hvm_free_ioreq_mfn(s, false); - - return rc; -} - -static void hvm_ioreq_server_free_pages(struct hvm_ioreq_server *s) -{ - hvm_free_ioreq_mfn(s, true); - hvm_free_ioreq_mfn(s, false); -} - -static void hvm_ioreq_server_free_rangesets(struct hvm_ioreq_server *s) -{ - unsigned int i; - - for ( i = 0; i < NR_IO_RANGE_TYPES; i++ ) - rangeset_destroy(s->range[i]); -} - -static int hvm_ioreq_server_alloc_rangesets(struct hvm_ioreq_server *s, - ioservid_t id) -{ - unsigned int i; - int rc; - - for ( i = 0; i < NR_IO_RANGE_TYPES; i++ ) - { - char *name; - - rc = asprintf(&name, "ioreq_server %d %s", id, - (i == XEN_DMOP_IO_RANGE_PORT) ? "port" : - (i == XEN_DMOP_IO_RANGE_MEMORY) ? "memory" : - (i == XEN_DMOP_IO_RANGE_PCI) ? "pci" : - ""); - if ( rc ) - goto fail; - - s->range[i] = rangeset_new(s->target, name, - RANGESETF_prettyprint_hex); - - xfree(name); - - rc = -ENOMEM; - if ( !s->range[i] ) - goto fail; - - rangeset_limit(s->range[i], MAX_NR_IO_RANGES); - } - - return 0; - - fail: - hvm_ioreq_server_free_rangesets(s); - - return rc; -} - -static void hvm_ioreq_server_enable(struct hvm_ioreq_server *s) -{ - struct hvm_ioreq_vcpu *sv; - - spin_lock(&s->lock); - - if ( s->enabled ) - goto done; - - hvm_remove_ioreq_gfn(s, false); - hvm_remove_ioreq_gfn(s, true); - - s->enabled = true; - - list_for_each_entry ( sv, - &s->ioreq_vcpu_list, - list_entry ) - hvm_update_ioreq_evtchn(s, sv); - - done: - spin_unlock(&s->lock); -} - -static void hvm_ioreq_server_disable(struct hvm_ioreq_server *s) -{ - spin_lock(&s->lock); - - if ( !s->enabled ) - goto done; - - hvm_add_ioreq_gfn(s, true); - hvm_add_ioreq_gfn(s, false); - - s->enabled = false; - - done: - spin_unlock(&s->lock); -} - -static int hvm_ioreq_server_init(struct hvm_ioreq_server *s, - struct domain *d, int bufioreq_handling, - ioservid_t id) -{ - struct domain *currd = current->domain; - struct vcpu *v; - int rc; - - s->target = d; - - get_knownalive_domain(currd); - s->emulator = currd; - - spin_lock_init(&s->lock); - INIT_LIST_HEAD(&s->ioreq_vcpu_list); - spin_lock_init(&s->bufioreq_lock); - - s->ioreq.gfn = INVALID_GFN; - s->bufioreq.gfn = INVALID_GFN; - - rc = hvm_ioreq_server_alloc_rangesets(s, id); - if ( rc ) - return rc; - - s->bufioreq_handling = bufioreq_handling; - - for_each_vcpu ( d, v ) - { - rc = hvm_ioreq_server_add_vcpu(s, v); - if ( rc ) - goto fail_add; - } - - return 0; - - fail_add: - hvm_ioreq_server_remove_all_vcpus(s); - hvm_ioreq_server_unmap_pages(s); - - hvm_ioreq_server_free_rangesets(s); - - put_domain(s->emulator); - return rc; -} - -static void hvm_ioreq_server_deinit(struct hvm_ioreq_server *s) -{ - ASSERT(!s->enabled); - hvm_ioreq_server_remove_all_vcpus(s); - - /* - * NOTE: It is safe to call both hvm_ioreq_server_unmap_pages() and - * hvm_ioreq_server_free_pages() in that order. - * This is because the former will do nothing if the pages - * are not mapped, leaving the page to be freed by the latter. - * However if the pages are mapped then the former will set - * the page_info pointer to NULL, meaning the latter will do - * nothing. - */ - hvm_ioreq_server_unmap_pages(s); - hvm_ioreq_server_free_pages(s); - - hvm_ioreq_server_free_rangesets(s); - - put_domain(s->emulator); -} - -int hvm_create_ioreq_server(struct domain *d, int bufioreq_handling, - ioservid_t *id) -{ - struct hvm_ioreq_server *s; - unsigned int i; - int rc; - - if ( bufioreq_handling > HVM_IOREQSRV_BUFIOREQ_ATOMIC ) - return -EINVAL; - - s = xzalloc(struct hvm_ioreq_server); - if ( !s ) - return -ENOMEM; - - domain_pause(d); - spin_lock_recursive(&d->arch.hvm.ioreq_server.lock); - - for ( i = 0; i < MAX_NR_IOREQ_SERVERS; i++ ) - { - if ( !GET_IOREQ_SERVER(d, i) ) - break; - } - - rc = -ENOSPC; - if ( i >= MAX_NR_IOREQ_SERVERS ) - goto fail; - - /* - * It is safe to call set_ioreq_server() prior to - * hvm_ioreq_server_init() since the target domain is paused. - */ - set_ioreq_server(d, i, s); - - rc = hvm_ioreq_server_init(s, d, bufioreq_handling, i); - if ( rc ) - { - set_ioreq_server(d, i, NULL); - goto fail; - } - - if ( id ) - *id = i; - - spin_unlock_recursive(&d->arch.hvm.ioreq_server.lock); - domain_unpause(d); - - return 0; - - fail: - spin_unlock_recursive(&d->arch.hvm.ioreq_server.lock); - domain_unpause(d); - - xfree(s); - return rc; -} - -int hvm_destroy_ioreq_server(struct domain *d, ioservid_t id) -{ - struct hvm_ioreq_server *s; - int rc; - - spin_lock_recursive(&d->arch.hvm.ioreq_server.lock); - - s = get_ioreq_server(d, id); - - rc = -ENOENT; - if ( !s ) - goto out; - - rc = -EPERM; - if ( s->emulator != current->domain ) - goto out; - - domain_pause(d); - - p2m_set_ioreq_server(d, 0, s); - - hvm_ioreq_server_disable(s); - - /* - * It is safe to call hvm_ioreq_server_deinit() prior to - * set_ioreq_server() since the target domain is paused. - */ - hvm_ioreq_server_deinit(s); - set_ioreq_server(d, id, NULL); - - domain_unpause(d); - - xfree(s); - - rc = 0; - - out: - spin_unlock_recursive(&d->arch.hvm.ioreq_server.lock); - - return rc; -} - -int hvm_get_ioreq_server_info(struct domain *d, ioservid_t id, - unsigned long *ioreq_gfn, - unsigned long *bufioreq_gfn, - evtchn_port_t *bufioreq_port) -{ - struct hvm_ioreq_server *s; - int rc; - - spin_lock_recursive(&d->arch.hvm.ioreq_server.lock); - - s = get_ioreq_server(d, id); - - rc = -ENOENT; - if ( !s ) - goto out; - - rc = -EPERM; - if ( s->emulator != current->domain ) - goto out; - - if ( ioreq_gfn || bufioreq_gfn ) - { - rc = hvm_ioreq_server_map_pages(s); - if ( rc ) - goto out; - } - - if ( ioreq_gfn ) - *ioreq_gfn = gfn_x(s->ioreq.gfn); - - if ( HANDLE_BUFIOREQ(s) ) - { - if ( bufioreq_gfn ) - *bufioreq_gfn = gfn_x(s->bufioreq.gfn); - - if ( bufioreq_port ) - *bufioreq_port = s->bufioreq_evtchn; - } - - rc = 0; - - out: - spin_unlock_recursive(&d->arch.hvm.ioreq_server.lock); - - return rc; -} - -int hvm_get_ioreq_server_frame(struct domain *d, ioservid_t id, - unsigned long idx, mfn_t *mfn) -{ - struct hvm_ioreq_server *s; - int rc; - - ASSERT(is_hvm_domain(d)); - - spin_lock_recursive(&d->arch.hvm.ioreq_server.lock); - - s = get_ioreq_server(d, id); - - rc = -ENOENT; - if ( !s ) - goto out; - - rc = -EPERM; - if ( s->emulator != current->domain ) - goto out; - - rc = hvm_ioreq_server_alloc_pages(s); - if ( rc ) - goto out; - - switch ( idx ) - { - case XENMEM_resource_ioreq_server_frame_bufioreq: - rc = -ENOENT; - if ( !HANDLE_BUFIOREQ(s) ) - goto out; - - *mfn = page_to_mfn(s->bufioreq.page); - rc = 0; - break; - - case XENMEM_resource_ioreq_server_frame_ioreq(0): - *mfn = page_to_mfn(s->ioreq.page); - rc = 0; - break; - - default: - rc = -EINVAL; - break; - } - - out: - spin_unlock_recursive(&d->arch.hvm.ioreq_server.lock); - - return rc; -} - -int hvm_map_io_range_to_ioreq_server(struct domain *d, ioservid_t id, - uint32_t type, uint64_t start, - uint64_t end) -{ - struct hvm_ioreq_server *s; - struct rangeset *r; - int rc; - - if ( start > end ) - return -EINVAL; - - spin_lock_recursive(&d->arch.hvm.ioreq_server.lock); - - s = get_ioreq_server(d, id); - - rc = -ENOENT; - if ( !s ) - goto out; - - rc = -EPERM; - if ( s->emulator != current->domain ) - goto out; - - switch ( type ) - { - case XEN_DMOP_IO_RANGE_PORT: - case XEN_DMOP_IO_RANGE_MEMORY: - case XEN_DMOP_IO_RANGE_PCI: - r = s->range[type]; - break; - - default: - r = NULL; - break; - } - - rc = -EINVAL; - if ( !r ) - goto out; - - rc = -EEXIST; - if ( rangeset_overlaps_range(r, start, end) ) - goto out; - - rc = rangeset_add_range(r, start, end); - - out: - spin_unlock_recursive(&d->arch.hvm.ioreq_server.lock); - - return rc; -} +#include +#include -int hvm_unmap_io_range_from_ioreq_server(struct domain *d, ioservid_t id, - uint32_t type, uint64_t start, - uint64_t end) +void handle_realmode_completion(void) { - struct hvm_ioreq_server *s; - struct rangeset *r; - int rc; - - if ( start > end ) - return -EINVAL; - - spin_lock_recursive(&d->arch.hvm.ioreq_server.lock); - - s = get_ioreq_server(d, id); - - rc = -ENOENT; - if ( !s ) - goto out; - - rc = -EPERM; - if ( s->emulator != current->domain ) - goto out; - - switch ( type ) - { - case XEN_DMOP_IO_RANGE_PORT: - case XEN_DMOP_IO_RANGE_MEMORY: - case XEN_DMOP_IO_RANGE_PCI: - r = s->range[type]; - break; - - default: - r = NULL; - break; - } - - rc = -EINVAL; - if ( !r ) - goto out; - - rc = -ENOENT; - if ( !rangeset_contains_range(r, start, end) ) - goto out; - - rc = rangeset_remove_range(r, start, end); - - out: - spin_unlock_recursive(&d->arch.hvm.ioreq_server.lock); + struct hvm_emulate_ctxt ctxt; - return rc; + hvm_emulate_init_once(&ctxt, NULL, guest_cpu_user_regs()); + vmx_realmode_emulate_one(&ctxt); + hvm_emulate_writeback(&ctxt); } /* @@ -1141,130 +89,12 @@ int hvm_map_mem_type_to_ioreq_server(struct domain *d, ioservid_t id, return rc; } -int hvm_set_ioreq_server_state(struct domain *d, ioservid_t id, - bool enabled) -{ - struct hvm_ioreq_server *s; - int rc; - - spin_lock_recursive(&d->arch.hvm.ioreq_server.lock); - - s = get_ioreq_server(d, id); - - rc = -ENOENT; - if ( !s ) - goto out; - - rc = -EPERM; - if ( s->emulator != current->domain ) - goto out; - - domain_pause(d); - - if ( enabled ) - hvm_ioreq_server_enable(s); - else - hvm_ioreq_server_disable(s); - - domain_unpause(d); - - rc = 0; - - out: - spin_unlock_recursive(&d->arch.hvm.ioreq_server.lock); - return rc; -} - -int hvm_all_ioreq_servers_add_vcpu(struct domain *d, struct vcpu *v) -{ - struct hvm_ioreq_server *s; - unsigned int id; - int rc; - - spin_lock_recursive(&d->arch.hvm.ioreq_server.lock); - - FOR_EACH_IOREQ_SERVER(d, id, s) - { - rc = hvm_ioreq_server_add_vcpu(s, v); - if ( rc ) - goto fail; - } - - spin_unlock_recursive(&d->arch.hvm.ioreq_server.lock); - - return 0; - - fail: - while ( ++id != MAX_NR_IOREQ_SERVERS ) - { - s = GET_IOREQ_SERVER(d, id); - - if ( !s ) - continue; - - hvm_ioreq_server_remove_vcpu(s, v); - } - - spin_unlock_recursive(&d->arch.hvm.ioreq_server.lock); - - return rc; -} - -void hvm_all_ioreq_servers_remove_vcpu(struct domain *d, struct vcpu *v) -{ - struct hvm_ioreq_server *s; - unsigned int id; - - spin_lock_recursive(&d->arch.hvm.ioreq_server.lock); - - FOR_EACH_IOREQ_SERVER(d, id, s) - hvm_ioreq_server_remove_vcpu(s, v); - - spin_unlock_recursive(&d->arch.hvm.ioreq_server.lock); -} - -void hvm_destroy_all_ioreq_servers(struct domain *d) +void hvm_get_ioreq_server_range_type(struct domain *d, + ioreq_t *p, + uint8_t *type, + uint64_t *addr) { - struct hvm_ioreq_server *s; - unsigned int id; - - if ( !relocate_portio_handler(d, 0xcf8, 0xcf8, 4) ) - return; - - spin_lock_recursive(&d->arch.hvm.ioreq_server.lock); - - /* No need to domain_pause() as the domain is being torn down */ - - FOR_EACH_IOREQ_SERVER(d, id, s) - { - hvm_ioreq_server_disable(s); - - /* - * It is safe to call hvm_ioreq_server_deinit() prior to - * set_ioreq_server() since the target domain is being destroyed. - */ - hvm_ioreq_server_deinit(s); - set_ioreq_server(d, id, NULL); - - xfree(s); - } - - spin_unlock_recursive(&d->arch.hvm.ioreq_server.lock); -} - -struct hvm_ioreq_server *hvm_select_ioreq_server(struct domain *d, - ioreq_t *p) -{ - struct hvm_ioreq_server *s; - uint32_t cf8; - uint8_t type; - uint64_t addr; - unsigned int id; - - if ( p->type != IOREQ_TYPE_COPY && p->type != IOREQ_TYPE_PIO ) - return NULL; - - cf8 = d->arch.hvm.pci_cf8; + uint32_t cf8 = d->arch.hvm.pci_cf8; if ( p->type == IOREQ_TYPE_PIO && (p->addr & ~3) == 0xcfc && @@ -1277,8 +107,8 @@ struct hvm_ioreq_server *hvm_select_ioreq_server(struct domain *d, reg = hvm_pci_decode_addr(cf8, p->addr, &sbdf); /* PCI config data cycle */ - type = XEN_DMOP_IO_RANGE_PCI; - addr = ((uint64_t)sbdf.sbdf << 32) | reg; + *type = XEN_DMOP_IO_RANGE_PCI; + *addr = ((uint64_t)sbdf.sbdf << 32) | reg; /* AMD extended configuration space access? */ if ( CF8_ADDR_HI(cf8) && d->arch.cpuid->x86_vendor == X86_VENDOR_AMD && @@ -1290,230 +120,15 @@ struct hvm_ioreq_server *hvm_select_ioreq_server(struct domain *d, if ( !rdmsr_safe(MSR_AMD64_NB_CFG, msr_val) && (msr_val & (1ULL << AMD64_NB_CFG_CF8_EXT_ENABLE_BIT)) ) - addr |= CF8_ADDR_HI(cf8); + *addr |= CF8_ADDR_HI(cf8); } } else { - type = (p->type == IOREQ_TYPE_PIO) ? - XEN_DMOP_IO_RANGE_PORT : XEN_DMOP_IO_RANGE_MEMORY; - addr = p->addr; - } - - FOR_EACH_IOREQ_SERVER(d, id, s) - { - struct rangeset *r; - - if ( !s->enabled ) - continue; - - r = s->range[type]; - - switch ( type ) - { - unsigned long start, end; - - case XEN_DMOP_IO_RANGE_PORT: - start = addr; - end = start + p->size - 1; - if ( rangeset_contains_range(r, start, end) ) - return s; - - break; - - case XEN_DMOP_IO_RANGE_MEMORY: - start = hvm_mmio_first_byte(p); - end = hvm_mmio_last_byte(p); - - if ( rangeset_contains_range(r, start, end) ) - return s; - - break; - - case XEN_DMOP_IO_RANGE_PCI: - if ( rangeset_contains_singleton(r, addr >> 32) ) - { - p->type = IOREQ_TYPE_PCI_CONFIG; - p->addr = addr; - return s; - } - - break; - } - } - - return NULL; -} - -static int hvm_send_buffered_ioreq(struct hvm_ioreq_server *s, ioreq_t *p) -{ - struct domain *d = current->domain; - struct hvm_ioreq_page *iorp; - buffered_iopage_t *pg; - buf_ioreq_t bp = { .data = p->data, - .addr = p->addr, - .type = p->type, - .dir = p->dir }; - /* Timeoffset sends 64b data, but no address. Use two consecutive slots. */ - int qw = 0; - - /* Ensure buffered_iopage fits in a page */ - BUILD_BUG_ON(sizeof(buffered_iopage_t) > PAGE_SIZE); - - iorp = &s->bufioreq; - pg = iorp->va; - - if ( !pg ) - return X86EMUL_UNHANDLEABLE; - - /* - * Return 0 for the cases we can't deal with: - * - 'addr' is only a 20-bit field, so we cannot address beyond 1MB - * - we cannot buffer accesses to guest memory buffers, as the guest - * may expect the memory buffer to be synchronously accessed - * - the count field is usually used with data_is_ptr and since we don't - * support data_is_ptr we do not waste space for the count field either - */ - if ( (p->addr > 0xffffful) || p->data_is_ptr || (p->count != 1) ) - return 0; - - switch ( p->size ) - { - case 1: - bp.size = 0; - break; - case 2: - bp.size = 1; - break; - case 4: - bp.size = 2; - break; - case 8: - bp.size = 3; - qw = 1; - break; - default: - gdprintk(XENLOG_WARNING, "unexpected ioreq size: %u\n", p->size); - return X86EMUL_UNHANDLEABLE; - } - - spin_lock(&s->bufioreq_lock); - - if ( (pg->ptrs.write_pointer - pg->ptrs.read_pointer) >= - (IOREQ_BUFFER_SLOT_NUM - qw) ) - { - /* The queue is full: send the iopacket through the normal path. */ - spin_unlock(&s->bufioreq_lock); - return X86EMUL_UNHANDLEABLE; - } - - pg->buf_ioreq[pg->ptrs.write_pointer % IOREQ_BUFFER_SLOT_NUM] = bp; - - if ( qw ) - { - bp.data = p->data >> 32; - pg->buf_ioreq[(pg->ptrs.write_pointer+1) % IOREQ_BUFFER_SLOT_NUM] = bp; - } - - /* Make the ioreq_t visible /before/ write_pointer. */ - smp_wmb(); - pg->ptrs.write_pointer += qw ? 2 : 1; - - /* Canonicalize read/write pointers to prevent their overflow. */ - while ( (s->bufioreq_handling == HVM_IOREQSRV_BUFIOREQ_ATOMIC) && - qw++ < IOREQ_BUFFER_SLOT_NUM && - pg->ptrs.read_pointer >= IOREQ_BUFFER_SLOT_NUM ) - { - union bufioreq_pointers old = pg->ptrs, new; - unsigned int n = old.read_pointer / IOREQ_BUFFER_SLOT_NUM; - - new.read_pointer = old.read_pointer - n * IOREQ_BUFFER_SLOT_NUM; - new.write_pointer = old.write_pointer - n * IOREQ_BUFFER_SLOT_NUM; - cmpxchg(&pg->ptrs.full, old.full, new.full); - } - - notify_via_xen_event_channel(d, s->bufioreq_evtchn); - spin_unlock(&s->bufioreq_lock); - - return X86EMUL_OKAY; -} - -int hvm_send_ioreq(struct hvm_ioreq_server *s, ioreq_t *proto_p, - bool buffered) -{ - struct vcpu *curr = current; - struct domain *d = curr->domain; - struct hvm_ioreq_vcpu *sv; - - ASSERT(s); - - if ( buffered ) - return hvm_send_buffered_ioreq(s, proto_p); - - if ( unlikely(!vcpu_start_shutdown_deferral(curr)) ) - return X86EMUL_RETRY; - - list_for_each_entry ( sv, - &s->ioreq_vcpu_list, - list_entry ) - { - if ( sv->vcpu == curr ) - { - evtchn_port_t port = sv->ioreq_evtchn; - ioreq_t *p = get_ioreq(s, curr); - - if ( unlikely(p->state != STATE_IOREQ_NONE) ) - { - gprintk(XENLOG_ERR, "device model set bad IO state %d\n", - p->state); - break; - } - - if ( unlikely(p->vp_eport != port) ) - { - gprintk(XENLOG_ERR, "device model set bad event channel %d\n", - p->vp_eport); - break; - } - - proto_p->state = STATE_IOREQ_NONE; - proto_p->vp_eport = port; - *p = *proto_p; - - prepare_wait_on_xen_event_channel(port); - - /* - * Following happens /after/ blocking and setting up ioreq - * contents. prepare_wait_on_xen_event_channel() is an implicit - * barrier. - */ - p->state = STATE_IOREQ_READY; - notify_via_xen_event_channel(d, port); - - sv->pending = true; - return X86EMUL_RETRY; - } - } - - return X86EMUL_UNHANDLEABLE; -} - -unsigned int hvm_broadcast_ioreq(ioreq_t *p, bool buffered) -{ - struct domain *d = current->domain; - struct hvm_ioreq_server *s; - unsigned int id, failed = 0; - - FOR_EACH_IOREQ_SERVER(d, id, s) - { - if ( !s->enabled ) - continue; - - if ( hvm_send_ioreq(s, p, buffered) == X86EMUL_UNHANDLEABLE ) - failed++; + *type = (p->type == IOREQ_TYPE_PIO) ? + XEN_DMOP_IO_RANGE_PORT : XEN_DMOP_IO_RANGE_MEMORY; + *addr = p->addr; } - - return failed; } static int hvm_access_cf8( @@ -1528,13 +143,19 @@ static int hvm_access_cf8( return X86EMUL_UNHANDLEABLE; } -void hvm_ioreq_init(struct domain *d) +void arch_hvm_ioreq_init(struct domain *d) { spin_lock_init(&d->arch.hvm.ioreq_server.lock); register_portio_handler(d, 0xcf8, 4, hvm_access_cf8); } +void arch_hvm_ioreq_destroy(struct domain *d) +{ + if ( !relocate_portio_handler(d, 0xcf8, 0xcf8, 4) ) + return; +} + /* * Local variables: * mode: C diff --git a/xen/arch/x86/hvm/stdvga.c b/xen/arch/x86/hvm/stdvga.c index e267513..ab6d315 100644 --- a/xen/arch/x86/hvm/stdvga.c +++ b/xen/arch/x86/hvm/stdvga.c @@ -27,10 +27,10 @@ * can have side effects. */ +#include #include #include #include -#include #include #include #include diff --git a/xen/arch/x86/hvm/vmx/realmode.c b/xen/arch/x86/hvm/vmx/realmode.c index bdbd9cb..b804262 100644 --- a/xen/arch/x86/hvm/vmx/realmode.c +++ b/xen/arch/x86/hvm/vmx/realmode.c @@ -9,6 +9,7 @@ * Keir Fraser */ +#include #include #include #include diff --git a/xen/arch/x86/hvm/vmx/vvmx.c b/xen/arch/x86/hvm/vmx/vvmx.c index 7dfff6c..acfeb1c 100644 --- a/xen/arch/x86/hvm/vmx/vvmx.c +++ b/xen/arch/x86/hvm/vmx/vvmx.c @@ -18,11 +18,11 @@ * this program; If not, see . * */ +#include #include #include #include -#include #include #include #include diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 82bc676..2b06e15 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -99,6 +99,7 @@ * doing the final put_page(), and remove it from the iommu if so. */ +#include #include #include #include @@ -141,7 +142,6 @@ #include #include #include -#include #include #include diff --git a/xen/arch/x86/mm/shadow/common.c b/xen/arch/x86/mm/shadow/common.c index 7737773..c84cbb2 100644 --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -20,6 +20,7 @@ * along with this program; If not, see . */ +#include #include #include #include @@ -34,7 +35,6 @@ #include #include #include -#include #include #include "private.h" diff --git a/xen/common/Kconfig b/xen/common/Kconfig index 15e3b79..fb6fb51 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -139,6 +139,9 @@ config HYPFS_CONFIG Disable this option in case you want to spare some memory or you want to hide the .config contents from dom0. +config IOREQ_SERVER + bool + config KEXEC bool "kexec support" default y diff --git a/xen/common/Makefile b/xen/common/Makefile index 06881d0..f6fc3f8 100644 --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -70,6 +70,7 @@ extra-y := symbols-dummy.o obj-$(CONFIG_COVERAGE) += coverage/ obj-y += sched/ +obj-$(CONFIG_IOREQ_SERVER) += hvm/ obj-$(CONFIG_UBSAN) += ubsan/ obj-$(CONFIG_NEEDS_LIBELF) += libelf/ diff --git a/xen/common/hvm/Makefile b/xen/common/hvm/Makefile new file mode 100644 index 0000000..326215d --- /dev/null +++ b/xen/common/hvm/Makefile @@ -0,0 +1 @@ +obj-y += ioreq.o diff --git a/xen/common/hvm/ioreq.c b/xen/common/hvm/ioreq.c new file mode 100644 index 0000000..7e1fa23 --- /dev/null +++ b/xen/common/hvm/ioreq.c @@ -0,0 +1,1430 @@ +/* + * hvm/ioreq.c: hardware virtual machine I/O emulation + * + * Copyright (c) 2016 Citrix Systems Inc. + * + * This program is free software; you can redistribute it and/or modify it + * under the terms and conditions of the GNU General Public License, + * version 2, as published by the Free Software Foundation. + * + * This program is distributed in the hope it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + * + * You should have received a copy of the GNU General Public License along with + * this program; If not, see . + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include + +static void set_ioreq_server(struct domain *d, unsigned int id, + struct hvm_ioreq_server *s) +{ + ASSERT(id < MAX_NR_IOREQ_SERVERS); + ASSERT(!s || !d->arch.hvm.ioreq_server.server[id]); + + d->arch.hvm.ioreq_server.server[id] = s; +} + +/* + * Iterate over all possible ioreq servers. + * + * NOTE: The iteration is backwards such that more recently created + * ioreq servers are favoured in hvm_select_ioreq_server(). + * This is a semantic that previously existed when ioreq servers + * were held in a linked list. + */ +#define FOR_EACH_IOREQ_SERVER(d, id, s) \ + for ( (id) = MAX_NR_IOREQ_SERVERS; (id) != 0; ) \ + if ( !(s = GET_IOREQ_SERVER(d, --(id))) ) \ + continue; \ + else + +static ioreq_t *get_ioreq(struct hvm_ioreq_server *s, struct vcpu *v) +{ + shared_iopage_t *p = s->ioreq.va; + + ASSERT((v == current) || !vcpu_runnable(v)); + ASSERT(p != NULL); + + return &p->vcpu_ioreq[v->vcpu_id]; +} + +bool hvm_io_pending(struct vcpu *v) +{ + struct domain *d = v->domain; + struct hvm_ioreq_server *s; + unsigned int id; + + FOR_EACH_IOREQ_SERVER(d, id, s) + { + struct hvm_ioreq_vcpu *sv; + + list_for_each_entry ( sv, + &s->ioreq_vcpu_list, + list_entry ) + { + if ( sv->vcpu == v && sv->pending ) + return true; + } + } + + return false; +} + +static void hvm_io_assist(struct hvm_ioreq_vcpu *sv, uint64_t data) +{ + struct vcpu *v = sv->vcpu; + ioreq_t *ioreq = &v->arch.hvm.hvm_io.io_req; + + if ( hvm_ioreq_needs_completion(ioreq) ) + ioreq->data = data; + + sv->pending = false; +} + +static bool hvm_wait_for_io(struct hvm_ioreq_vcpu *sv, ioreq_t *p) +{ + unsigned int prev_state = STATE_IOREQ_NONE; + + while ( sv->pending ) + { + unsigned int state = p->state; + + smp_rmb(); + + recheck: + if ( unlikely(state == STATE_IOREQ_NONE) ) + { + /* + * The only reason we should see this case is when an + * emulator is dying and it races with an I/O being + * requested. + */ + hvm_io_assist(sv, ~0ul); + break; + } + + if ( unlikely(state < prev_state) ) + { + gdprintk(XENLOG_ERR, "Weird HVM ioreq state transition %u -> %u\n", + prev_state, state); + sv->pending = false; + domain_crash(sv->vcpu->domain); + return false; /* bail */ + } + + switch ( prev_state = state ) + { + case STATE_IORESP_READY: /* IORESP_READY -> NONE */ + p->state = STATE_IOREQ_NONE; + hvm_io_assist(sv, p->data); + break; + case STATE_IOREQ_READY: /* IOREQ_{READY,INPROCESS} -> IORESP_READY */ + case STATE_IOREQ_INPROCESS: + wait_on_xen_event_channel(sv->ioreq_evtchn, + ({ state = p->state; + smp_rmb(); + state != prev_state; })); + goto recheck; + default: + gdprintk(XENLOG_ERR, "Weird HVM iorequest state %u\n", state); + sv->pending = false; + domain_crash(sv->vcpu->domain); + return false; /* bail */ + } + } + + return true; +} + +bool handle_hvm_io_completion(struct vcpu *v) +{ + struct domain *d = v->domain; + struct hvm_vcpu_io *vio = &v->arch.hvm.hvm_io; + struct hvm_ioreq_server *s; + enum hvm_io_completion io_completion; + unsigned int id; + + if ( has_vpci(d) && vpci_process_pending(v) ) + { + raise_softirq(SCHEDULE_SOFTIRQ); + return false; + } + + FOR_EACH_IOREQ_SERVER(d, id, s) + { + struct hvm_ioreq_vcpu *sv; + + list_for_each_entry ( sv, + &s->ioreq_vcpu_list, + list_entry ) + { + if ( sv->vcpu == v && sv->pending ) + { + if ( !hvm_wait_for_io(sv, get_ioreq(s, v)) ) + return false; + + break; + } + } + } + + vio->io_req.state = hvm_ioreq_needs_completion(&vio->io_req) ? + STATE_IORESP_READY : STATE_IOREQ_NONE; + + msix_write_completion(v); + vcpu_end_shutdown_deferral(v); + + io_completion = vio->io_completion; + vio->io_completion = HVMIO_no_completion; + + switch ( io_completion ) + { + case HVMIO_no_completion: + break; + + case HVMIO_mmio_completion: + return handle_mmio(); + + case HVMIO_pio_completion: + return handle_pio(vio->io_req.addr, vio->io_req.size, + vio->io_req.dir); + + case HVMIO_realmode_completion: + handle_realmode_completion(); + break; + + default: + ASSERT_UNREACHABLE(); + break; + } + + return true; +} + +static gfn_t hvm_alloc_legacy_ioreq_gfn(struct hvm_ioreq_server *s) +{ + struct domain *d = s->target; + unsigned int i; + + BUILD_BUG_ON(HVM_PARAM_BUFIOREQ_PFN != HVM_PARAM_IOREQ_PFN + 1); + + for ( i = HVM_PARAM_IOREQ_PFN; i <= HVM_PARAM_BUFIOREQ_PFN; i++ ) + { + if ( !test_and_clear_bit(i, &d->arch.hvm.ioreq_gfn.legacy_mask) ) + return _gfn(d->arch.hvm.params[i]); + } + + return INVALID_GFN; +} + +static gfn_t hvm_alloc_ioreq_gfn(struct hvm_ioreq_server *s) +{ + struct domain *d = s->target; + unsigned int i; + + for ( i = 0; i < sizeof(d->arch.hvm.ioreq_gfn.mask) * 8; i++ ) + { + if ( test_and_clear_bit(i, &d->arch.hvm.ioreq_gfn.mask) ) + return _gfn(d->arch.hvm.ioreq_gfn.base + i); + } + + /* + * If we are out of 'normal' GFNs then we may still have a 'legacy' + * GFN available. + */ + return hvm_alloc_legacy_ioreq_gfn(s); +} + +static bool hvm_free_legacy_ioreq_gfn(struct hvm_ioreq_server *s, + gfn_t gfn) +{ + struct domain *d = s->target; + unsigned int i; + + for ( i = HVM_PARAM_IOREQ_PFN; i <= HVM_PARAM_BUFIOREQ_PFN; i++ ) + { + if ( gfn_eq(gfn, _gfn(d->arch.hvm.params[i])) ) + break; + } + if ( i > HVM_PARAM_BUFIOREQ_PFN ) + return false; + + set_bit(i, &d->arch.hvm.ioreq_gfn.legacy_mask); + return true; +} + +static void hvm_free_ioreq_gfn(struct hvm_ioreq_server *s, gfn_t gfn) +{ + struct domain *d = s->target; + unsigned int i = gfn_x(gfn) - d->arch.hvm.ioreq_gfn.base; + + ASSERT(!gfn_eq(gfn, INVALID_GFN)); + + if ( !hvm_free_legacy_ioreq_gfn(s, gfn) ) + { + ASSERT(i < sizeof(d->arch.hvm.ioreq_gfn.mask) * 8); + set_bit(i, &d->arch.hvm.ioreq_gfn.mask); + } +} + +static void hvm_unmap_ioreq_gfn(struct hvm_ioreq_server *s, bool buf) +{ + struct hvm_ioreq_page *iorp = buf ? &s->bufioreq : &s->ioreq; + + if ( gfn_eq(iorp->gfn, INVALID_GFN) ) + return; + + destroy_ring_for_helper(&iorp->va, iorp->page); + iorp->page = NULL; + + hvm_free_ioreq_gfn(s, iorp->gfn); + iorp->gfn = INVALID_GFN; +} + +static int hvm_map_ioreq_gfn(struct hvm_ioreq_server *s, bool buf) +{ + struct domain *d = s->target; + struct hvm_ioreq_page *iorp = buf ? &s->bufioreq : &s->ioreq; + int rc; + + if ( iorp->page ) + { + /* + * If a page has already been allocated (which will happen on + * demand if hvm_get_ioreq_server_frame() is called), then + * mapping a guest frame is not permitted. + */ + if ( gfn_eq(iorp->gfn, INVALID_GFN) ) + return -EPERM; + + return 0; + } + + if ( d->is_dying ) + return -EINVAL; + + iorp->gfn = hvm_alloc_ioreq_gfn(s); + + if ( gfn_eq(iorp->gfn, INVALID_GFN) ) + return -ENOMEM; + + rc = prepare_ring_for_helper(d, gfn_x(iorp->gfn), &iorp->page, + &iorp->va); + + if ( rc ) + hvm_unmap_ioreq_gfn(s, buf); + + return rc; +} + +static int hvm_alloc_ioreq_mfn(struct hvm_ioreq_server *s, bool buf) +{ + struct hvm_ioreq_page *iorp = buf ? &s->bufioreq : &s->ioreq; + struct page_info *page; + + if ( iorp->page ) + { + /* + * If a guest frame has already been mapped (which may happen + * on demand if hvm_get_ioreq_server_info() is called), then + * allocating a page is not permitted. + */ + if ( !gfn_eq(iorp->gfn, INVALID_GFN) ) + return -EPERM; + + return 0; + } + + page = alloc_domheap_page(s->target, MEMF_no_refcount); + + if ( !page ) + return -ENOMEM; + + if ( !get_page_and_type(page, s->target, PGT_writable_page) ) + { + /* + * The domain can't possibly know about this page yet, so failure + * here is a clear indication of something fishy going on. + */ + domain_crash(s->emulator); + return -ENODATA; + } + + iorp->va = __map_domain_page_global(page); + if ( !iorp->va ) + goto fail; + + iorp->page = page; + clear_page(iorp->va); + return 0; + + fail: + put_page_alloc_ref(page); + put_page_and_type(page); + + return -ENOMEM; +} + +static void hvm_free_ioreq_mfn(struct hvm_ioreq_server *s, bool buf) +{ + struct hvm_ioreq_page *iorp = buf ? &s->bufioreq : &s->ioreq; + struct page_info *page = iorp->page; + + if ( !page ) + return; + + iorp->page = NULL; + + unmap_domain_page_global(iorp->va); + iorp->va = NULL; + + put_page_alloc_ref(page); + put_page_and_type(page); +} + +bool is_ioreq_server_page(struct domain *d, const struct page_info *page) +{ + const struct hvm_ioreq_server *s; + unsigned int id; + bool found = false; + + spin_lock_recursive(&d->arch.hvm.ioreq_server.lock); + + FOR_EACH_IOREQ_SERVER(d, id, s) + { + if ( (s->ioreq.page == page) || (s->bufioreq.page == page) ) + { + found = true; + break; + } + } + + spin_unlock_recursive(&d->arch.hvm.ioreq_server.lock); + + return found; +} + +static void hvm_remove_ioreq_gfn(struct hvm_ioreq_server *s, bool buf) + +{ + struct domain *d = s->target; + struct hvm_ioreq_page *iorp = buf ? &s->bufioreq : &s->ioreq; + + if ( gfn_eq(iorp->gfn, INVALID_GFN) ) + return; + + if ( guest_physmap_remove_page(d, iorp->gfn, + page_to_mfn(iorp->page), 0) ) + domain_crash(d); + clear_page(iorp->va); +} + +static int hvm_add_ioreq_gfn(struct hvm_ioreq_server *s, bool buf) +{ + struct domain *d = s->target; + struct hvm_ioreq_page *iorp = buf ? &s->bufioreq : &s->ioreq; + int rc; + + if ( gfn_eq(iorp->gfn, INVALID_GFN) ) + return 0; + + clear_page(iorp->va); + + rc = guest_physmap_add_page(d, iorp->gfn, + page_to_mfn(iorp->page), 0); + if ( rc == 0 ) + paging_mark_pfn_dirty(d, _pfn(gfn_x(iorp->gfn))); + + return rc; +} + +static void hvm_update_ioreq_evtchn(struct hvm_ioreq_server *s, + struct hvm_ioreq_vcpu *sv) +{ + ASSERT(spin_is_locked(&s->lock)); + + if ( s->ioreq.va != NULL ) + { + ioreq_t *p = get_ioreq(s, sv->vcpu); + + p->vp_eport = sv->ioreq_evtchn; + } +} + +#define HANDLE_BUFIOREQ(s) \ + ((s)->bufioreq_handling != HVM_IOREQSRV_BUFIOREQ_OFF) + +static int hvm_ioreq_server_add_vcpu(struct hvm_ioreq_server *s, + struct vcpu *v) +{ + struct hvm_ioreq_vcpu *sv; + int rc; + + sv = xzalloc(struct hvm_ioreq_vcpu); + + rc = -ENOMEM; + if ( !sv ) + goto fail1; + + spin_lock(&s->lock); + + rc = alloc_unbound_xen_event_channel(v->domain, v->vcpu_id, + s->emulator->domain_id, NULL); + if ( rc < 0 ) + goto fail2; + + sv->ioreq_evtchn = rc; + + if ( v->vcpu_id == 0 && HANDLE_BUFIOREQ(s) ) + { + rc = alloc_unbound_xen_event_channel(v->domain, 0, + s->emulator->domain_id, NULL); + if ( rc < 0 ) + goto fail3; + + s->bufioreq_evtchn = rc; + } + + sv->vcpu = v; + + list_add(&sv->list_entry, &s->ioreq_vcpu_list); + + if ( s->enabled ) + hvm_update_ioreq_evtchn(s, sv); + + spin_unlock(&s->lock); + return 0; + + fail3: + free_xen_event_channel(v->domain, sv->ioreq_evtchn); + + fail2: + spin_unlock(&s->lock); + xfree(sv); + + fail1: + return rc; +} + +static void hvm_ioreq_server_remove_vcpu(struct hvm_ioreq_server *s, + struct vcpu *v) +{ + struct hvm_ioreq_vcpu *sv; + + spin_lock(&s->lock); + + list_for_each_entry ( sv, + &s->ioreq_vcpu_list, + list_entry ) + { + if ( sv->vcpu != v ) + continue; + + list_del(&sv->list_entry); + + if ( v->vcpu_id == 0 && HANDLE_BUFIOREQ(s) ) + free_xen_event_channel(v->domain, s->bufioreq_evtchn); + + free_xen_event_channel(v->domain, sv->ioreq_evtchn); + + xfree(sv); + break; + } + + spin_unlock(&s->lock); +} + +static void hvm_ioreq_server_remove_all_vcpus(struct hvm_ioreq_server *s) +{ + struct hvm_ioreq_vcpu *sv, *next; + + spin_lock(&s->lock); + + list_for_each_entry_safe ( sv, + next, + &s->ioreq_vcpu_list, + list_entry ) + { + struct vcpu *v = sv->vcpu; + + list_del(&sv->list_entry); + + if ( v->vcpu_id == 0 && HANDLE_BUFIOREQ(s) ) + free_xen_event_channel(v->domain, s->bufioreq_evtchn); + + free_xen_event_channel(v->domain, sv->ioreq_evtchn); + + xfree(sv); + } + + spin_unlock(&s->lock); +} + +static int hvm_ioreq_server_map_pages(struct hvm_ioreq_server *s) +{ + int rc; + + rc = hvm_map_ioreq_gfn(s, false); + + if ( !rc && HANDLE_BUFIOREQ(s) ) + rc = hvm_map_ioreq_gfn(s, true); + + if ( rc ) + hvm_unmap_ioreq_gfn(s, false); + + return rc; +} + +static void hvm_ioreq_server_unmap_pages(struct hvm_ioreq_server *s) +{ + hvm_unmap_ioreq_gfn(s, true); + hvm_unmap_ioreq_gfn(s, false); +} + +static int hvm_ioreq_server_alloc_pages(struct hvm_ioreq_server *s) +{ + int rc; + + rc = hvm_alloc_ioreq_mfn(s, false); + + if ( !rc && (s->bufioreq_handling != HVM_IOREQSRV_BUFIOREQ_OFF) ) + rc = hvm_alloc_ioreq_mfn(s, true); + + if ( rc ) + hvm_free_ioreq_mfn(s, false); + + return rc; +} + +static void hvm_ioreq_server_free_pages(struct hvm_ioreq_server *s) +{ + hvm_free_ioreq_mfn(s, true); + hvm_free_ioreq_mfn(s, false); +} + +static void hvm_ioreq_server_free_rangesets(struct hvm_ioreq_server *s) +{ + unsigned int i; + + for ( i = 0; i < NR_IO_RANGE_TYPES; i++ ) + rangeset_destroy(s->range[i]); +} + +static int hvm_ioreq_server_alloc_rangesets(struct hvm_ioreq_server *s, + ioservid_t id) +{ + unsigned int i; + int rc; + + for ( i = 0; i < NR_IO_RANGE_TYPES; i++ ) + { + char *name; + + rc = asprintf(&name, "ioreq_server %d %s", id, + (i == XEN_DMOP_IO_RANGE_PORT) ? "port" : + (i == XEN_DMOP_IO_RANGE_MEMORY) ? "memory" : + (i == XEN_DMOP_IO_RANGE_PCI) ? "pci" : + ""); + if ( rc ) + goto fail; + + s->range[i] = rangeset_new(s->target, name, + RANGESETF_prettyprint_hex); + + xfree(name); + + rc = -ENOMEM; + if ( !s->range[i] ) + goto fail; + + rangeset_limit(s->range[i], MAX_NR_IO_RANGES); + } + + return 0; + + fail: + hvm_ioreq_server_free_rangesets(s); + + return rc; +} + +static void hvm_ioreq_server_enable(struct hvm_ioreq_server *s) +{ + struct hvm_ioreq_vcpu *sv; + + spin_lock(&s->lock); + + if ( s->enabled ) + goto done; + + hvm_remove_ioreq_gfn(s, false); + hvm_remove_ioreq_gfn(s, true); + + s->enabled = true; + + list_for_each_entry ( sv, + &s->ioreq_vcpu_list, + list_entry ) + hvm_update_ioreq_evtchn(s, sv); + + done: + spin_unlock(&s->lock); +} + +static void hvm_ioreq_server_disable(struct hvm_ioreq_server *s) +{ + spin_lock(&s->lock); + + if ( !s->enabled ) + goto done; + + hvm_add_ioreq_gfn(s, true); + hvm_add_ioreq_gfn(s, false); + + s->enabled = false; + + done: + spin_unlock(&s->lock); +} + +static int hvm_ioreq_server_init(struct hvm_ioreq_server *s, + struct domain *d, int bufioreq_handling, + ioservid_t id) +{ + struct domain *currd = current->domain; + struct vcpu *v; + int rc; + + s->target = d; + + get_knownalive_domain(currd); + s->emulator = currd; + + spin_lock_init(&s->lock); + INIT_LIST_HEAD(&s->ioreq_vcpu_list); + spin_lock_init(&s->bufioreq_lock); + + s->ioreq.gfn = INVALID_GFN; + s->bufioreq.gfn = INVALID_GFN; + + rc = hvm_ioreq_server_alloc_rangesets(s, id); + if ( rc ) + return rc; + + s->bufioreq_handling = bufioreq_handling; + + for_each_vcpu ( d, v ) + { + rc = hvm_ioreq_server_add_vcpu(s, v); + if ( rc ) + goto fail_add; + } + + return 0; + + fail_add: + hvm_ioreq_server_remove_all_vcpus(s); + hvm_ioreq_server_unmap_pages(s); + + hvm_ioreq_server_free_rangesets(s); + + put_domain(s->emulator); + return rc; +} + +static void hvm_ioreq_server_deinit(struct hvm_ioreq_server *s) +{ + ASSERT(!s->enabled); + hvm_ioreq_server_remove_all_vcpus(s); + + /* + * NOTE: It is safe to call both hvm_ioreq_server_unmap_pages() and + * hvm_ioreq_server_free_pages() in that order. + * This is because the former will do nothing if the pages + * are not mapped, leaving the page to be freed by the latter. + * However if the pages are mapped then the former will set + * the page_info pointer to NULL, meaning the latter will do + * nothing. + */ + hvm_ioreq_server_unmap_pages(s); + hvm_ioreq_server_free_pages(s); + + hvm_ioreq_server_free_rangesets(s); + + put_domain(s->emulator); +} + +int hvm_create_ioreq_server(struct domain *d, int bufioreq_handling, + ioservid_t *id) +{ + struct hvm_ioreq_server *s; + unsigned int i; + int rc; + + if ( bufioreq_handling > HVM_IOREQSRV_BUFIOREQ_ATOMIC ) + return -EINVAL; + + s = xzalloc(struct hvm_ioreq_server); + if ( !s ) + return -ENOMEM; + + domain_pause(d); + spin_lock_recursive(&d->arch.hvm.ioreq_server.lock); + + for ( i = 0; i < MAX_NR_IOREQ_SERVERS; i++ ) + { + if ( !GET_IOREQ_SERVER(d, i) ) + break; + } + + rc = -ENOSPC; + if ( i >= MAX_NR_IOREQ_SERVERS ) + goto fail; + + /* + * It is safe to call set_ioreq_server() prior to + * hvm_ioreq_server_init() since the target domain is paused. + */ + set_ioreq_server(d, i, s); + + rc = hvm_ioreq_server_init(s, d, bufioreq_handling, i); + if ( rc ) + { + set_ioreq_server(d, i, NULL); + goto fail; + } + + if ( id ) + *id = i; + + spin_unlock_recursive(&d->arch.hvm.ioreq_server.lock); + domain_unpause(d); + + return 0; + + fail: + spin_unlock_recursive(&d->arch.hvm.ioreq_server.lock); + domain_unpause(d); + + xfree(s); + return rc; +} + +int hvm_destroy_ioreq_server(struct domain *d, ioservid_t id) +{ + struct hvm_ioreq_server *s; + int rc; + + spin_lock_recursive(&d->arch.hvm.ioreq_server.lock); + + s = get_ioreq_server(d, id); + + rc = -ENOENT; + if ( !s ) + goto out; + + rc = -EPERM; + if ( s->emulator != current->domain ) + goto out; + + domain_pause(d); + + p2m_set_ioreq_server(d, 0, s); + + hvm_ioreq_server_disable(s); + + /* + * It is safe to call hvm_ioreq_server_deinit() prior to + * set_ioreq_server() since the target domain is paused. + */ + hvm_ioreq_server_deinit(s); + set_ioreq_server(d, id, NULL); + + domain_unpause(d); + + xfree(s); + + rc = 0; + + out: + spin_unlock_recursive(&d->arch.hvm.ioreq_server.lock); + + return rc; +} + +int hvm_get_ioreq_server_info(struct domain *d, ioservid_t id, + unsigned long *ioreq_gfn, + unsigned long *bufioreq_gfn, + evtchn_port_t *bufioreq_port) +{ + struct hvm_ioreq_server *s; + int rc; + + spin_lock_recursive(&d->arch.hvm.ioreq_server.lock); + + s = get_ioreq_server(d, id); + + rc = -ENOENT; + if ( !s ) + goto out; + + rc = -EPERM; + if ( s->emulator != current->domain ) + goto out; + + if ( ioreq_gfn || bufioreq_gfn ) + { + rc = hvm_ioreq_server_map_pages(s); + if ( rc ) + goto out; + } + + if ( ioreq_gfn ) + *ioreq_gfn = gfn_x(s->ioreq.gfn); + + if ( HANDLE_BUFIOREQ(s) ) + { + if ( bufioreq_gfn ) + *bufioreq_gfn = gfn_x(s->bufioreq.gfn); + + if ( bufioreq_port ) + *bufioreq_port = s->bufioreq_evtchn; + } + + rc = 0; + + out: + spin_unlock_recursive(&d->arch.hvm.ioreq_server.lock); + + return rc; +} + +int hvm_get_ioreq_server_frame(struct domain *d, ioservid_t id, + unsigned long idx, mfn_t *mfn) +{ + struct hvm_ioreq_server *s; + int rc; + + ASSERT(is_hvm_domain(d)); + + spin_lock_recursive(&d->arch.hvm.ioreq_server.lock); + + s = get_ioreq_server(d, id); + + rc = -ENOENT; + if ( !s ) + goto out; + + rc = -EPERM; + if ( s->emulator != current->domain ) + goto out; + + rc = hvm_ioreq_server_alloc_pages(s); + if ( rc ) + goto out; + + switch ( idx ) + { + case XENMEM_resource_ioreq_server_frame_bufioreq: + rc = -ENOENT; + if ( !HANDLE_BUFIOREQ(s) ) + goto out; + + *mfn = page_to_mfn(s->bufioreq.page); + rc = 0; + break; + + case XENMEM_resource_ioreq_server_frame_ioreq(0): + *mfn = page_to_mfn(s->ioreq.page); + rc = 0; + break; + + default: + rc = -EINVAL; + break; + } + + out: + spin_unlock_recursive(&d->arch.hvm.ioreq_server.lock); + + return rc; +} + +int hvm_map_io_range_to_ioreq_server(struct domain *d, ioservid_t id, + uint32_t type, uint64_t start, + uint64_t end) +{ + struct hvm_ioreq_server *s; + struct rangeset *r; + int rc; + + if ( start > end ) + return -EINVAL; + + spin_lock_recursive(&d->arch.hvm.ioreq_server.lock); + + s = get_ioreq_server(d, id); + + rc = -ENOENT; + if ( !s ) + goto out; + + rc = -EPERM; + if ( s->emulator != current->domain ) + goto out; + + switch ( type ) + { + case XEN_DMOP_IO_RANGE_PORT: + case XEN_DMOP_IO_RANGE_MEMORY: + case XEN_DMOP_IO_RANGE_PCI: + r = s->range[type]; + break; + + default: + r = NULL; + break; + } + + rc = -EINVAL; + if ( !r ) + goto out; + + rc = -EEXIST; + if ( rangeset_overlaps_range(r, start, end) ) + goto out; + + rc = rangeset_add_range(r, start, end); + + out: + spin_unlock_recursive(&d->arch.hvm.ioreq_server.lock); + + return rc; +} + +int hvm_unmap_io_range_from_ioreq_server(struct domain *d, ioservid_t id, + uint32_t type, uint64_t start, + uint64_t end) +{ + struct hvm_ioreq_server *s; + struct rangeset *r; + int rc; + + if ( start > end ) + return -EINVAL; + + spin_lock_recursive(&d->arch.hvm.ioreq_server.lock); + + s = get_ioreq_server(d, id); + + rc = -ENOENT; + if ( !s ) + goto out; + + rc = -EPERM; + if ( s->emulator != current->domain ) + goto out; + + switch ( type ) + { + case XEN_DMOP_IO_RANGE_PORT: + case XEN_DMOP_IO_RANGE_MEMORY: + case XEN_DMOP_IO_RANGE_PCI: + r = s->range[type]; + break; + + default: + r = NULL; + break; + } + + rc = -EINVAL; + if ( !r ) + goto out; + + rc = -ENOENT; + if ( !rangeset_contains_range(r, start, end) ) + goto out; + + rc = rangeset_remove_range(r, start, end); + + out: + spin_unlock_recursive(&d->arch.hvm.ioreq_server.lock); + + return rc; +} + +int hvm_set_ioreq_server_state(struct domain *d, ioservid_t id, + bool enabled) +{ + struct hvm_ioreq_server *s; + int rc; + + spin_lock_recursive(&d->arch.hvm.ioreq_server.lock); + + s = get_ioreq_server(d, id); + + rc = -ENOENT; + if ( !s ) + goto out; + + rc = -EPERM; + if ( s->emulator != current->domain ) + goto out; + + domain_pause(d); + + if ( enabled ) + hvm_ioreq_server_enable(s); + else + hvm_ioreq_server_disable(s); + + domain_unpause(d); + + rc = 0; + + out: + spin_unlock_recursive(&d->arch.hvm.ioreq_server.lock); + return rc; +} + +int hvm_all_ioreq_servers_add_vcpu(struct domain *d, struct vcpu *v) +{ + struct hvm_ioreq_server *s; + unsigned int id; + int rc; + + spin_lock_recursive(&d->arch.hvm.ioreq_server.lock); + + FOR_EACH_IOREQ_SERVER(d, id, s) + { + rc = hvm_ioreq_server_add_vcpu(s, v); + if ( rc ) + goto fail; + } + + spin_unlock_recursive(&d->arch.hvm.ioreq_server.lock); + + return 0; + + fail: + while ( ++id != MAX_NR_IOREQ_SERVERS ) + { + s = GET_IOREQ_SERVER(d, id); + + if ( !s ) + continue; + + hvm_ioreq_server_remove_vcpu(s, v); + } + + spin_unlock_recursive(&d->arch.hvm.ioreq_server.lock); + + return rc; +} + +void hvm_all_ioreq_servers_remove_vcpu(struct domain *d, struct vcpu *v) +{ + struct hvm_ioreq_server *s; + unsigned int id; + + spin_lock_recursive(&d->arch.hvm.ioreq_server.lock); + + FOR_EACH_IOREQ_SERVER(d, id, s) + hvm_ioreq_server_remove_vcpu(s, v); + + spin_unlock_recursive(&d->arch.hvm.ioreq_server.lock); +} + +void hvm_destroy_all_ioreq_servers(struct domain *d) +{ + struct hvm_ioreq_server *s; + unsigned int id; + + arch_hvm_ioreq_destroy(d); + + spin_lock_recursive(&d->arch.hvm.ioreq_server.lock); + + /* No need to domain_pause() as the domain is being torn down */ + + FOR_EACH_IOREQ_SERVER(d, id, s) + { + hvm_ioreq_server_disable(s); + + /* + * It is safe to call hvm_ioreq_server_deinit() prior to + * set_ioreq_server() since the target domain is being destroyed. + */ + hvm_ioreq_server_deinit(s); + set_ioreq_server(d, id, NULL); + + xfree(s); + } + + spin_unlock_recursive(&d->arch.hvm.ioreq_server.lock); +} + +struct hvm_ioreq_server *hvm_select_ioreq_server(struct domain *d, + ioreq_t *p) +{ + struct hvm_ioreq_server *s; + uint8_t type; + uint64_t addr; + unsigned int id; + + if ( p->type != IOREQ_TYPE_COPY && p->type != IOREQ_TYPE_PIO ) + return NULL; + + hvm_get_ioreq_server_range_type(d, p, &type, &addr); + + FOR_EACH_IOREQ_SERVER(d, id, s) + { + struct rangeset *r; + + if ( !s->enabled ) + continue; + + r = s->range[type]; + + switch ( type ) + { + unsigned long start, end; + + case XEN_DMOP_IO_RANGE_PORT: + start = addr; + end = start + p->size - 1; + if ( rangeset_contains_range(r, start, end) ) + return s; + + break; + + case XEN_DMOP_IO_RANGE_MEMORY: + start = hvm_mmio_first_byte(p); + end = hvm_mmio_last_byte(p); + + if ( rangeset_contains_range(r, start, end) ) + return s; + + break; + + case XEN_DMOP_IO_RANGE_PCI: + if ( rangeset_contains_singleton(r, addr >> 32) ) + { + p->type = IOREQ_TYPE_PCI_CONFIG; + p->addr = addr; + return s; + } + + break; + } + } + + return NULL; +} + +static int hvm_send_buffered_ioreq(struct hvm_ioreq_server *s, ioreq_t *p) +{ + struct domain *d = current->domain; + struct hvm_ioreq_page *iorp; + buffered_iopage_t *pg; + buf_ioreq_t bp = { .data = p->data, + .addr = p->addr, + .type = p->type, + .dir = p->dir }; + /* Timeoffset sends 64b data, but no address. Use two consecutive slots. */ + int qw = 0; + + /* Ensure buffered_iopage fits in a page */ + BUILD_BUG_ON(sizeof(buffered_iopage_t) > PAGE_SIZE); + + iorp = &s->bufioreq; + pg = iorp->va; + + if ( !pg ) + return IOREQ_IO_UNHANDLED; + + /* + * Return 0 for the cases we can't deal with: + * - 'addr' is only a 20-bit field, so we cannot address beyond 1MB + * - we cannot buffer accesses to guest memory buffers, as the guest + * may expect the memory buffer to be synchronously accessed + * - the count field is usually used with data_is_ptr and since we don't + * support data_is_ptr we do not waste space for the count field either + */ + if ( (p->addr > 0xffffful) || p->data_is_ptr || (p->count != 1) ) + return 0; + + switch ( p->size ) + { + case 1: + bp.size = 0; + break; + case 2: + bp.size = 1; + break; + case 4: + bp.size = 2; + break; + case 8: + bp.size = 3; + qw = 1; + break; + default: + gdprintk(XENLOG_WARNING, "unexpected ioreq size: %u\n", p->size); + return IOREQ_IO_UNHANDLED; + } + + spin_lock(&s->bufioreq_lock); + + if ( (pg->ptrs.write_pointer - pg->ptrs.read_pointer) >= + (IOREQ_BUFFER_SLOT_NUM - qw) ) + { + /* The queue is full: send the iopacket through the normal path. */ + spin_unlock(&s->bufioreq_lock); + return IOREQ_IO_UNHANDLED; + } + + pg->buf_ioreq[pg->ptrs.write_pointer % IOREQ_BUFFER_SLOT_NUM] = bp; + + if ( qw ) + { + bp.data = p->data >> 32; + pg->buf_ioreq[(pg->ptrs.write_pointer+1) % IOREQ_BUFFER_SLOT_NUM] = bp; + } + + /* Make the ioreq_t visible /before/ write_pointer. */ + smp_wmb(); + pg->ptrs.write_pointer += qw ? 2 : 1; + + /* Canonicalize read/write pointers to prevent their overflow. */ + while ( (s->bufioreq_handling == HVM_IOREQSRV_BUFIOREQ_ATOMIC) && + qw++ < IOREQ_BUFFER_SLOT_NUM && + pg->ptrs.read_pointer >= IOREQ_BUFFER_SLOT_NUM ) + { + union bufioreq_pointers old = pg->ptrs, new; + unsigned int n = old.read_pointer / IOREQ_BUFFER_SLOT_NUM; + + new.read_pointer = old.read_pointer - n * IOREQ_BUFFER_SLOT_NUM; + new.write_pointer = old.write_pointer - n * IOREQ_BUFFER_SLOT_NUM; + cmpxchg(&pg->ptrs.full, old.full, new.full); + } + + notify_via_xen_event_channel(d, s->bufioreq_evtchn); + spin_unlock(&s->bufioreq_lock); + + return IOREQ_IO_HANDLED; +} + +int hvm_send_ioreq(struct hvm_ioreq_server *s, ioreq_t *proto_p, + bool buffered) +{ + struct vcpu *curr = current; + struct domain *d = curr->domain; + struct hvm_ioreq_vcpu *sv; + + ASSERT(s); + + if ( buffered ) + return hvm_send_buffered_ioreq(s, proto_p); + + if ( unlikely(!vcpu_start_shutdown_deferral(curr)) ) + return IOREQ_IO_RETRY; + + list_for_each_entry ( sv, + &s->ioreq_vcpu_list, + list_entry ) + { + if ( sv->vcpu == curr ) + { + evtchn_port_t port = sv->ioreq_evtchn; + ioreq_t *p = get_ioreq(s, curr); + + if ( unlikely(p->state != STATE_IOREQ_NONE) ) + { + gprintk(XENLOG_ERR, "device model set bad IO state %d\n", + p->state); + break; + } + + if ( unlikely(p->vp_eport != port) ) + { + gprintk(XENLOG_ERR, "device model set bad event channel %d\n", + p->vp_eport); + break; + } + + proto_p->state = STATE_IOREQ_NONE; + proto_p->vp_eport = port; + *p = *proto_p; + + prepare_wait_on_xen_event_channel(port); + + /* + * Following happens /after/ blocking and setting up ioreq + * contents. prepare_wait_on_xen_event_channel() is an implicit + * barrier. + */ + p->state = STATE_IOREQ_READY; + notify_via_xen_event_channel(d, port); + + sv->pending = true; + return IOREQ_IO_RETRY; + } + } + + return IOREQ_IO_UNHANDLED; +} + +unsigned int hvm_broadcast_ioreq(ioreq_t *p, bool buffered) +{ + struct domain *d = current->domain; + struct hvm_ioreq_server *s; + unsigned int id, failed = 0; + + FOR_EACH_IOREQ_SERVER(d, id, s) + { + if ( !s->enabled ) + continue; + + if ( hvm_send_ioreq(s, p, buffered) == IOREQ_IO_UNHANDLED ) + failed++; + } + + return failed; +} + +void hvm_ioreq_init(struct domain *d) +{ + spin_lock_init(&d->arch.hvm.ioreq_server.lock); + + arch_hvm_ioreq_init(d); +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/include/asm-x86/hvm/ioreq.h b/xen/include/asm-x86/hvm/ioreq.h index e2588e9..0e871e0 100644 --- a/xen/include/asm-x86/hvm/ioreq.h +++ b/xen/include/asm-x86/hvm/ioreq.h @@ -19,41 +19,26 @@ #ifndef __ASM_X86_HVM_IOREQ_H__ #define __ASM_X86_HVM_IOREQ_H__ -bool hvm_io_pending(struct vcpu *v); -bool handle_hvm_io_completion(struct vcpu *v); -bool is_ioreq_server_page(struct domain *d, const struct page_info *page); +#include +#include +#include + +void handle_realmode_completion(void); + +void hvm_get_ioreq_server_range_type(struct domain *d, + ioreq_t *p, + uint8_t *type, + uint64_t *addr); -int hvm_create_ioreq_server(struct domain *d, int bufioreq_handling, - ioservid_t *id); -int hvm_destroy_ioreq_server(struct domain *d, ioservid_t id); -int hvm_get_ioreq_server_info(struct domain *d, ioservid_t id, - unsigned long *ioreq_gfn, - unsigned long *bufioreq_gfn, - evtchn_port_t *bufioreq_port); -int hvm_get_ioreq_server_frame(struct domain *d, ioservid_t id, - unsigned long idx, mfn_t *mfn); -int hvm_map_io_range_to_ioreq_server(struct domain *d, ioservid_t id, - uint32_t type, uint64_t start, - uint64_t end); -int hvm_unmap_io_range_from_ioreq_server(struct domain *d, ioservid_t id, - uint32_t type, uint64_t start, - uint64_t end); int hvm_map_mem_type_to_ioreq_server(struct domain *d, ioservid_t id, uint32_t type, uint32_t flags); -int hvm_set_ioreq_server_state(struct domain *d, ioservid_t id, - bool enabled); - -int hvm_all_ioreq_servers_add_vcpu(struct domain *d, struct vcpu *v); -void hvm_all_ioreq_servers_remove_vcpu(struct domain *d, struct vcpu *v); -void hvm_destroy_all_ioreq_servers(struct domain *d); -struct hvm_ioreq_server *hvm_select_ioreq_server(struct domain *d, - ioreq_t *p); -int hvm_send_ioreq(struct hvm_ioreq_server *s, ioreq_t *proto_p, - bool buffered); -unsigned int hvm_broadcast_ioreq(ioreq_t *p, bool buffered); +void arch_hvm_ioreq_init(struct domain *d); +void arch_hvm_ioreq_destroy(struct domain *d); -void hvm_ioreq_init(struct domain *d); +#define IOREQ_IO_HANDLED X86EMUL_OKAY +#define IOREQ_IO_UNHANDLED X86EMUL_UNHANDLEABLE +#define IOREQ_IO_RETRY X86EMUL_RETRY #endif /* __ASM_X86_HVM_IOREQ_H__ */ diff --git a/xen/include/asm-x86/hvm/vcpu.h b/xen/include/asm-x86/hvm/vcpu.h index 5ccd075..6c1feda 100644 --- a/xen/include/asm-x86/hvm/vcpu.h +++ b/xen/include/asm-x86/hvm/vcpu.h @@ -91,13 +91,6 @@ struct hvm_vcpu_io { const struct g2m_ioport *g2m_ioport; }; -static inline bool hvm_ioreq_needs_completion(const ioreq_t *ioreq) -{ - return ioreq->state == STATE_IOREQ_READY && - !ioreq->data_is_ptr && - (ioreq->type != IOREQ_TYPE_PIO || ioreq->dir != IOREQ_WRITE); -} - struct nestedvcpu { bool_t nv_guestmode; /* vcpu in guestmode? */ void *nv_vvmcx; /* l1 guest virtual VMCB/VMCS */ diff --git a/xen/include/xen/hvm/ioreq.h b/xen/include/xen/hvm/ioreq.h new file mode 100644 index 0000000..40b7b5e --- /dev/null +++ b/xen/include/xen/hvm/ioreq.h @@ -0,0 +1,89 @@ +/* + * hvm.h: Hardware virtual machine assist interface definitions. + * + * Copyright (c) 2016 Citrix Systems Inc. + * + * This program is free software; you can redistribute it and/or modify it + * under the terms and conditions of the GNU General Public License, + * version 2, as published by the Free Software Foundation. + * + * This program is distributed in the hope it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + * + * You should have received a copy of the GNU General Public License along with + * this program; If not, see . + */ + +#ifndef __HVM_IOREQ_H__ +#define __HVM_IOREQ_H__ + +#include + +#include + +#define GET_IOREQ_SERVER(d, id) \ + (d)->arch.hvm.ioreq_server.server[id] + +static inline struct hvm_ioreq_server *get_ioreq_server(const struct domain *d, + unsigned int id) +{ + if ( id >= MAX_NR_IOREQ_SERVERS ) + return NULL; + + return GET_IOREQ_SERVER(d, id); +} + +static inline bool hvm_ioreq_needs_completion(const ioreq_t *ioreq) +{ + return ioreq->state == STATE_IOREQ_READY && + !ioreq->data_is_ptr && + (ioreq->type != IOREQ_TYPE_PIO || ioreq->dir != IOREQ_WRITE); +} + +bool hvm_io_pending(struct vcpu *v); +bool handle_hvm_io_completion(struct vcpu *v); +bool is_ioreq_server_page(struct domain *d, const struct page_info *page); + +int hvm_create_ioreq_server(struct domain *d, int bufioreq_handling, + ioservid_t *id); +int hvm_destroy_ioreq_server(struct domain *d, ioservid_t id); +int hvm_get_ioreq_server_info(struct domain *d, ioservid_t id, + unsigned long *ioreq_gfn, + unsigned long *bufioreq_gfn, + evtchn_port_t *bufioreq_port); +int hvm_get_ioreq_server_frame(struct domain *d, ioservid_t id, + unsigned long idx, mfn_t *mfn); +int hvm_map_io_range_to_ioreq_server(struct domain *d, ioservid_t id, + uint32_t type, uint64_t start, + uint64_t end); +int hvm_unmap_io_range_from_ioreq_server(struct domain *d, ioservid_t id, + uint32_t type, uint64_t start, + uint64_t end); +int hvm_set_ioreq_server_state(struct domain *d, ioservid_t id, + bool enabled); + +int hvm_all_ioreq_servers_add_vcpu(struct domain *d, struct vcpu *v); +void hvm_all_ioreq_servers_remove_vcpu(struct domain *d, struct vcpu *v); +void hvm_destroy_all_ioreq_servers(struct domain *d); + +struct hvm_ioreq_server *hvm_select_ioreq_server(struct domain *d, + ioreq_t *p); +int hvm_send_ioreq(struct hvm_ioreq_server *s, ioreq_t *proto_p, + bool buffered); +unsigned int hvm_broadcast_ioreq(ioreq_t *p, bool buffered); + +void hvm_ioreq_init(struct domain *d); + +#endif /* __HVM_IOREQ_H__ */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 18:22:05 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 18:22:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2f5n-0008F9-GQ; Mon, 03 Aug 2020 18:21:47 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2f5m-0008F4-CS for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 18:21:46 +0000 X-Inumbo-ID: 2f45a374-d5b6-11ea-90c4-bc764e2007e4 Received: from mail-lj1-x241.google.com (unknown [2a00:1450:4864:20::241]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2f45a374-d5b6-11ea-90c4-bc764e2007e4; Mon, 03 Aug 2020 18:21:44 +0000 (UTC) Received: by mail-lj1-x241.google.com with SMTP id x9so40752796ljc.5 for ; Mon, 03 Aug 2020 11:21:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=kCrCUo6LTSRAdD0eh2bsSbVdTw1kcGXL8Ch5Id3ziSY=; b=SwTJHEJhDp0bLp5ZVRTtP9VYdIy+7L7xwlE2fa3ayYM+dBpMnAPAdZb9GxXGBOVU2Z id+PaPsNHjT8gUxYWTLXhgHEeJEAt8SugEc2fgzlZxy3AFzLnqlIusM3bPwmKPCpC9yO +bDPxA3mICO3xVUoCmWJwdShenm4Uv57/FyQAUB/jQ3TZYOx/j5aclAWCEB+TvUtUdN5 9VDXX6PWA5YLrCNGXsP3HNH0k+AdN5t/ytfh43m7ywL1I9GS3eurkejGiVrKHEaofszH QvhFoO3foddqAs2XE0u1lx09SiNGos1mxbAMbVBLRdSswK4CNBE8qD3WGDnnJXYK5t20 8sCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=kCrCUo6LTSRAdD0eh2bsSbVdTw1kcGXL8Ch5Id3ziSY=; b=Xviso8IQB40Su/ymUu11t6qMn/FDg3fR/XVhkRuTdmn+Sf5ot3nMXQfD8nWPAKQq7G u91eyUGWaWT9M2gRtQ6I+AkU/VTrz+iRxdcp0UddnK0PkLayJ0CxMLowsdlura8JMDz0 XUUmUjRFI0LEpJyAUCx4nceVsosoAHHT8azNNViIrUKpfXjPuPlh5YYQy11ANMwMjIS7 rhXpI6pVTMIbh7RDKDiRPZT3iVop70QC3Ijv5LAl0W1DhOi9bsGd57Ul33pIyW9+TAde tYaRHyVD2UbRTre1it5zMTqbowFyMCaJazIFWYVNdwAE5NjaNi1j0yNzjiiygxXc721P UMKw== X-Gm-Message-State: AOAM533Y6eTkyePcOkvS6tGg9jDk0lccCaMex13YzlwqPX4XnWIEhJvr YulhXVY1GEyh1Vk3ugLZfZMrrmAaPkY= X-Google-Smtp-Source: ABdhPJxeoQ9GFnLnWjMRHcBqrwoXNO7vzfxFn61Tgr9+J/8ok1kbDfkEpGBPwCDIxYXSSkTOJX8HhA== X-Received: by 2002:a05:651c:106e:: with SMTP id y14mr8189554ljm.49.1596478903394; Mon, 03 Aug 2020 11:21:43 -0700 (PDT) Received: from otyshchenko.www.tendawifi.com ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id h18sm4486730ljk.7.2020.08.03.11.21.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Aug 2020 11:21:42 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Subject: [RFC PATCH V1 00/12] IOREQ feature (+ virtio-mmio) on Arm Date: Mon, 3 Aug 2020 21:21:16 +0300 Message-Id: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Tian , Stefano Stabellini , Julien Grall , Jun Nakajima , Wei Liu , Paul Durrant , Andrew Cooper , Ian Jackson , George Dunlap , Tim Deegan , Oleksandr Tyshchenko , Jan Beulich , Anthony PERARD , Daniel De Graaf , Bertrand Marquis , Volodymyr Babchuk , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Oleksandr Tyshchenko Hello all. The purpose of this patch series is to add IOREQ/DM support to Xen on Arm. You can find an initial discussion at [1]. Xen on Arm requires some implementation to forward guest MMIO access to a device model in order to implement virtio-mmio backend or even mediator outside of hypervisor. As Xen on x86 already contains required support this patch series tries to make it common and introduce Arm specific bits plus some new functionality. Patch series is based on Julien's PoC "xen/arm: Add support for Guest IO forwarding to a device emulator". Besides splitting existing IOREQ/DM support and introducing Arm side, the patch series also includes virtio-mmio related changes (toolstack) for the reviewers to be able to see how the whole picture could look like. For a non-RFC, the IOREQ/DM and virtio-mmio support will be sent separately. According to the initial discussion there are a few open questions/concerns regarding security, performance in VirtIO solution: 1. virtio-mmio vs virtio-pci, SPI vs MSI, different use-cases require different transport... 2. virtio backend is able to access all guest memory, some kind of protection is needed: 'virtio-iommu in Xen' vs 'pre-shared-memory & memcpys in guest' 3. interface between toolstack and 'out-of-qemu' virtio backend, avoid using Xenstore in virtio backend if possible. 4. a lot of 'foreing mapping' could lead to the memory exhaustion, Julien has some idea regarding that. Looks like all of them are valid and worth considering, but the first thing which we need on Arm is a mechanism to forward guest IO to a device emulator, so let's focus on it in the first place. *** Patch series [2] was rebased on Xen v4.14 release and tested on Renesas Salvator-X board + H3 ES3.0 SoC (Arm64) with virtio-mmio disk backend (we will share it later) running in driver domain and unmodified Linux Guest running on existing virtio-blk driver (frontend). No issues were observed. Guest domain 'reboot/destroy' use-cases work properly. Patch series was only build-tested on x86. Please note, build-test passed for the following modes: 1. x86: CONFIG_HVM=y / CONFIG_IOREQ_SERVER=y (default) 2. x86: #CONFIG_HVM is not set / #CONFIG_IOREQ_SERVER is not set 3. Arm64: CONFIG_HVM=y / CONFIG_IOREQ_SERVER=y (default) 4. Arm64: CONFIG_HVM=y / #CONFIG_IOREQ_SERVER is not set 5. Arm32: CONFIG_HVM=y / #CONFIG_IOREQ_SERVER is not set Build-test didn't pass for Arm32 mode with 'CONFIG_IOREQ_SERVER=y' due to the lack of cmpxchg_64 support on Arm32. See cmpxchg usage in hvm_send_buffered_ioreq()). *** Any feedback/help would be highly appreciated. [1] https://lists.xenproject.org/archives/html/xen-devel/2020-07/msg00825.html [2] https://github.com/otyshchenko1/xen/commits/ioreq_4.14_ml1 Oleksandr Tyshchenko (12): hvm/ioreq: Make x86's IOREQ feature common hvm/dm: Make x86's DM feature common xen/mm: Make x86's XENMEM_resource_ioreq_server handling common xen/arm: Introduce arch specific bits for IOREQ/DM features hvm/dm: Introduce xendevicemodel_set_irq_level DM op libxl: Introduce basic virtio-mmio support on Arm A collection of tweaks to be able to run emulator in driver domain xen/arm: Invalidate qemu mapcache on XENMEM_decrease_reservation libxl: Handle virtio-mmio irq in more correct way libxl: Add support for virtio-disk configuration libxl: Insert "dma-coherent" property into virtio-mmio device node libxl: Fix duplicate memory node in DT tools/libs/devicemodel/core.c | 18 + tools/libs/devicemodel/include/xendevicemodel.h | 4 + tools/libs/devicemodel/libxendevicemodel.map | 1 + tools/libxc/xc_dom_arm.c | 25 +- tools/libxl/Makefile | 4 +- tools/libxl/libxl_arm.c | 98 +- tools/libxl/libxl_create.c | 1 + tools/libxl/libxl_internal.h | 1 + tools/libxl/libxl_types.idl | 16 + tools/libxl/libxl_types_internal.idl | 1 + tools/libxl/libxl_virtio_disk.c | 109 ++ tools/xl/Makefile | 2 +- tools/xl/xl.h | 3 + tools/xl/xl_cmdtable.c | 15 + tools/xl/xl_parse.c | 116 ++ tools/xl/xl_virtio_disk.c | 46 + xen/arch/arm/Kconfig | 1 + xen/arch/arm/Makefile | 2 + xen/arch/arm/dm.c | 54 + xen/arch/arm/domain.c | 9 + xen/arch/arm/hvm.c | 46 +- xen/arch/arm/io.c | 67 +- xen/arch/arm/ioreq.c | 100 ++ xen/arch/arm/traps.c | 23 + xen/arch/x86/Kconfig | 1 + xen/arch/x86/hvm/dm.c | 289 +---- xen/arch/x86/hvm/emulate.c | 2 +- xen/arch/x86/hvm/hvm.c | 2 +- xen/arch/x86/hvm/io.c | 2 +- xen/arch/x86/hvm/ioreq.c | 1431 +---------------------- xen/arch/x86/hvm/stdvga.c | 2 +- xen/arch/x86/hvm/vmx/realmode.c | 1 + xen/arch/x86/hvm/vmx/vvmx.c | 2 +- xen/arch/x86/mm.c | 45 - xen/arch/x86/mm/shadow/common.c | 2 +- xen/common/Kconfig | 3 + xen/common/Makefile | 1 + xen/common/domain.c | 15 + xen/common/domctl.c | 8 +- xen/common/event_channel.c | 14 +- xen/common/hvm/Makefile | 2 + xen/common/hvm/dm.c | 288 +++++ xen/common/hvm/ioreq.c | 1430 ++++++++++++++++++++++ xen/common/memory.c | 54 +- xen/include/asm-arm/domain.h | 82 ++ xen/include/asm-arm/hvm/ioreq.h | 105 ++ xen/include/asm-arm/mm.h | 8 - xen/include/asm-arm/mmio.h | 1 + xen/include/asm-arm/p2m.h | 7 +- xen/include/asm-x86/hvm/ioreq.h | 45 +- xen/include/asm-x86/hvm/vcpu.h | 7 - xen/include/asm-x86/mm.h | 4 - xen/include/public/hvm/dm_op.h | 15 + xen/include/xen/hvm/ioreq.h | 89 ++ xen/include/xen/hypercall.h | 12 + xen/include/xsm/dummy.h | 20 +- xen/include/xsm/xsm.h | 6 +- xen/xsm/dummy.c | 2 +- xen/xsm/flask/hooks.c | 5 +- 59 files changed, 2958 insertions(+), 1806 deletions(-) create mode 100644 tools/libxl/libxl_virtio_disk.c create mode 100644 tools/xl/xl_virtio_disk.c create mode 100644 xen/arch/arm/dm.c create mode 100644 xen/arch/arm/ioreq.c create mode 100644 xen/common/hvm/Makefile create mode 100644 xen/common/hvm/dm.c create mode 100644 xen/common/hvm/ioreq.c create mode 100644 xen/include/asm-arm/hvm/ioreq.h create mode 100644 xen/include/xen/hvm/ioreq.h -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 18:22:06 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 18:22:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2f66-0008Ii-Ty; Mon, 03 Aug 2020 18:22:06 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2f66-0008F4-6y for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 18:22:06 +0000 X-Inumbo-ID: 32a454ac-d5b6-11ea-90c4-bc764e2007e4 Received: from mail-lj1-x242.google.com (unknown [2a00:1450:4864:20::242]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 32a454ac-d5b6-11ea-90c4-bc764e2007e4; Mon, 03 Aug 2020 18:21:50 +0000 (UTC) Received: by mail-lj1-x242.google.com with SMTP id x9so40753131ljc.5 for ; Mon, 03 Aug 2020 11:21:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=VIKpZkxDN7eQd+zJAH4AgFtCzYqVcctBBddhzvbPXqo=; b=e3j1/HkO5R1dXvlgaiWw5rxSTHJNvfO+l/S5WMMyuCpZT87m6Yf1MuLXhh7PY9EnyD 1MGTQ0pNfMRuS/r5cVGQ1Zvx0z0V1D2I3+F+8d8JXrnXvQUxzmVphWWnJ/Tg3gbnRWbf cmGIx8NhkU0LyA3pVWBrW7C3WhUcWjxMGmzu9+L+SpY9rmHoAbGVqBk4AK1ElrudJRxT m5Z8SetlPA0SefvIYsKN0lmNhoLc/DZJP5fMdsxY+JMflv2Q19W8opgMzLdIyXIdBz03 05qzhXPYECXlvfzlqXWSyKC9CQxiB4GE/PIIovF+KUx4+JJfziMEcQnE2zMP7UAChF+2 D0dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=VIKpZkxDN7eQd+zJAH4AgFtCzYqVcctBBddhzvbPXqo=; b=IO6HgMFg8Ul7SRYbre/ySRS8mqEKQZ1EXdrofh/IdWJ+8PsHXXzUXnhNgYsSG98iHJ Th/0+XeiG4s5XfPZmNy+5MIZBr42XZVQRaFZ3GoZ2YqIxp4P7as7mw9Bn5S2eJZtsUXR hdTKhHXOJ97euwtycajj82jbKppwarYv5dCKotl9dSL1mo9Xg2BDjMhnXQ5ccpwHge9V H5UyHOr1WcsxjQ8okPO1Biv8psR+SC49VQDC7SkIOSRJJqPgriJ845qIbX0LNHp/BdKS qPxBmElkPXWDl+sOsMFV1dNE5dxaKIVfKSa7akPE6QPA5Fn59GM+m0eSk0vQR+yfq76e XkgQ== X-Gm-Message-State: AOAM531bq8jzLcyTl9XstEyFlGNyxL9MFFIIz0g3oaMHyHajxHDe78/t WKImdz+QZCOIlnfsYWZrdOeWy/cZCFE= X-Google-Smtp-Source: ABdhPJyPm5Z4kwcrUWIHRyaRXM9q/twQEsQ+GzpFpbwRFecJWQKGo/TF3Ea+USDqHv7zgWezKEs7Uw== X-Received: by 2002:a2e:8346:: with SMTP id l6mr8686276ljh.0.1596478908667; Mon, 03 Aug 2020 11:21:48 -0700 (PDT) Received: from otyshchenko.www.tendawifi.com ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id h18sm4486730ljk.7.2020.08.03.11.21.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Aug 2020 11:21:48 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Subject: [RFC PATCH V1 04/12] xen/arm: Introduce arch specific bits for IOREQ/DM features Date: Mon, 3 Aug 2020 21:21:20 +0300 Message-Id: <1596478888-23030-5-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Julien Grall , Jan Beulich , Daniel De Graaf , Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Oleksandr Tyshchenko This patch makes possible to forward Guest MMIO accesses to a device emulator on Arm and enables that support for Arm64. Also update XSM code a bit to let DM op be used on Arm. New arch DM op will be introduced in the follow-up patch. Please note, at the moment build on Arm32 is broken (see cmpxchg usage in hvm_send_buffered_ioreq()) if someone wants to enable CONFIG_IOREQ_SERVER due to the lack of cmpxchg_64 support on Arm32. Please note, this is a split/cleanup of Julien's PoC: "Add support for Guest IO forwarding to a device emulator" Signed-off-by: Julien Grall Signed-off-by: Oleksandr Tyshchenko --- tools/libxc/xc_dom_arm.c | 25 +++++++--- xen/arch/arm/Kconfig | 1 + xen/arch/arm/Makefile | 2 + xen/arch/arm/dm.c | 34 +++++++++++++ xen/arch/arm/domain.c | 9 ++++ xen/arch/arm/hvm.c | 46 +++++++++++++++++- xen/arch/arm/io.c | 67 +++++++++++++++++++++++++- xen/arch/arm/ioreq.c | 86 +++++++++++++++++++++++++++++++++ xen/arch/arm/traps.c | 17 +++++++ xen/common/memory.c | 5 +- xen/include/asm-arm/domain.h | 80 +++++++++++++++++++++++++++++++ xen/include/asm-arm/hvm/ioreq.h | 103 ++++++++++++++++++++++++++++++++++++++++ xen/include/asm-arm/mmio.h | 1 + xen/include/asm-arm/p2m.h | 7 +-- xen/include/xsm/dummy.h | 4 +- xen/include/xsm/xsm.h | 6 +-- xen/xsm/dummy.c | 2 +- xen/xsm/flask/hooks.c | 5 +- 18 files changed, 476 insertions(+), 24 deletions(-) create mode 100644 xen/arch/arm/dm.c create mode 100644 xen/arch/arm/ioreq.c create mode 100644 xen/include/asm-arm/hvm/ioreq.h diff --git a/tools/libxc/xc_dom_arm.c b/tools/libxc/xc_dom_arm.c index 931404c..b5fc066 100644 --- a/tools/libxc/xc_dom_arm.c +++ b/tools/libxc/xc_dom_arm.c @@ -26,11 +26,19 @@ #include "xg_private.h" #include "xc_dom.h" -#define NR_MAGIC_PAGES 4 + #define CONSOLE_PFN_OFFSET 0 #define XENSTORE_PFN_OFFSET 1 #define MEMACCESS_PFN_OFFSET 2 #define VUART_PFN_OFFSET 3 +#define IOREQ_SERVER_PFN_OFFSET 4 + +#define NR_IOREQ_SERVER_PAGES 8 +#define NR_MAGIC_PAGES (4 + NR_IOREQ_SERVER_PAGES) + +#define GUEST_MAGIC_BASE_PFN (GUEST_MAGIC_BASE >> XC_PAGE_SHIFT) + +#define special_pfn(x) (GUEST_MAGIC_BASE_PFN + (x)) #define LPAE_SHIFT 9 @@ -51,7 +59,7 @@ const char *xc_domain_get_native_protocol(xc_interface *xch, static int alloc_magic_pages(struct xc_dom_image *dom) { int rc, i; - const xen_pfn_t base = GUEST_MAGIC_BASE >> XC_PAGE_SHIFT; + const xen_pfn_t base = special_pfn(0); xen_pfn_t p2m[NR_MAGIC_PAGES]; BUILD_BUG_ON(NR_MAGIC_PAGES > GUEST_MAGIC_SIZE >> XC_PAGE_SHIFT); @@ -71,10 +79,9 @@ static int alloc_magic_pages(struct xc_dom_image *dom) dom->xenstore_pfn = base + XENSTORE_PFN_OFFSET; dom->vuart_gfn = base + VUART_PFN_OFFSET; - xc_clear_domain_page(dom->xch, dom->guest_domid, dom->console_pfn); - xc_clear_domain_page(dom->xch, dom->guest_domid, dom->xenstore_pfn); - xc_clear_domain_page(dom->xch, dom->guest_domid, base + MEMACCESS_PFN_OFFSET); - xc_clear_domain_page(dom->xch, dom->guest_domid, dom->vuart_gfn); + /* XXX: Check return */ + xc_clear_domain_pages(dom->xch, dom->guest_domid, special_pfn(0), + NR_MAGIC_PAGES); xc_hvm_param_set(dom->xch, dom->guest_domid, HVM_PARAM_CONSOLE_PFN, dom->console_pfn); @@ -88,6 +95,12 @@ static int alloc_magic_pages(struct xc_dom_image *dom) xc_hvm_param_set(dom->xch, dom->guest_domid, HVM_PARAM_STORE_EVTCHN, dom->xenstore_evtchn); + /* Tell the domain where the pages are and how many there are. */ + xc_hvm_param_set(dom->xch, dom->guest_domid, HVM_PARAM_IOREQ_SERVER_PFN, + special_pfn(IOREQ_SERVER_PFN_OFFSET)); + xc_hvm_param_set(dom->xch, dom->guest_domid, HVM_PARAM_NR_IOREQ_SERVER_PAGES, + NR_IOREQ_SERVER_PAGES); + return 0; } diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 2777388..6b8a969 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -13,6 +13,7 @@ config ARM_64 def_bool y depends on 64BIT select HAS_FAST_MULTIPLY + select IOREQ_SERVER config ARM def_bool y diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index 7e82b21..617fa3e 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -13,6 +13,7 @@ obj-y += cpuerrata.o obj-y += cpufeature.o obj-y += decode.o obj-y += device.o +obj-$(CONFIG_IOREQ_SERVER) += dm.o obj-y += domain.o obj-y += domain_build.init.o obj-y += domctl.o @@ -27,6 +28,7 @@ obj-y += guest_atomics.o obj-y += guest_walk.o obj-y += hvm.o obj-y += io.o +obj-$(CONFIG_IOREQ_SERVER) += ioreq.o obj-y += irq.o obj-y += kernel.init.o obj-$(CONFIG_LIVEPATCH) += livepatch.o diff --git a/xen/arch/arm/dm.c b/xen/arch/arm/dm.c new file mode 100644 index 0000000..2437099 --- /dev/null +++ b/xen/arch/arm/dm.c @@ -0,0 +1,34 @@ +/* + * Copyright (c) 2019 Arm ltd. + * + * This program is free software; you can redistribute it and/or modify it + * under the terms and conditions of the GNU General Public License, + * version 2, as published by the Free Software Foundation. + * + * This program is distributed in the hope it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + * + * You should have received a copy of the GNU General Public License along with + * this program; If not, see . + */ + +#include +#include + +int arch_dm_op(struct xen_dm_op *op, struct domain *d, + const struct dmop_args *op_args, bool *const_op) +{ + return -EOPNOTSUPP; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index 3116932..658eec0 100644 --- a/xen/arch/arm/domain.c +++ b/xen/arch/arm/domain.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -681,6 +682,10 @@ int arch_domain_create(struct domain *d, ASSERT(config != NULL); +#ifdef CONFIG_IOREQ_SERVER + hvm_ioreq_init(d); +#endif + /* p2m_init relies on some value initialized by the IOMMU subsystem */ if ( (rc = iommu_domain_init(d, config->iommu_opts)) != 0 ) goto fail; @@ -999,6 +1004,10 @@ int domain_relinquish_resources(struct domain *d) if (ret ) return ret; +#ifdef CONFIG_IOREQ_SERVER + hvm_destroy_all_ioreq_servers(d); +#endif + PROGRESS(xen): ret = relinquish_memory(d, &d->xenpage_list); if ( ret ) diff --git a/xen/arch/arm/hvm.c b/xen/arch/arm/hvm.c index 8951b34..0379493 100644 --- a/xen/arch/arm/hvm.c +++ b/xen/arch/arm/hvm.c @@ -51,6 +51,14 @@ static int hvm_allow_set_param(const struct domain *d, unsigned int param) case HVM_PARAM_MONITOR_RING_PFN: return d == current->domain ? -EPERM : 0; + /* + * XXX: Do we need to follow x86's logic here: + * "The following parameters should only be changed once"? + */ + case HVM_PARAM_IOREQ_SERVER_PFN: + case HVM_PARAM_NR_IOREQ_SERVER_PAGES: + return 0; + /* Writeable only by Xen, hole, deprecated, or out-of-range. */ default: return -EINVAL; @@ -69,6 +77,11 @@ static int hvm_allow_get_param(const struct domain *d, unsigned int param) case HVM_PARAM_CONSOLE_EVTCHN: return 0; + /* XXX: Could these be read by someone? What policy to apply? */ + case HVM_PARAM_IOREQ_SERVER_PFN: + case HVM_PARAM_NR_IOREQ_SERVER_PAGES: + return 0; + /* * The following parameters are intended for toolstack usage only. * They may not be read by the domain. @@ -82,6 +95,37 @@ static int hvm_allow_get_param(const struct domain *d, unsigned int param) } } +static int hvmop_set_param(struct domain *d, const struct xen_hvm_param *a) +{ + int rc = 0; + + switch ( a->index ) + { + case HVM_PARAM_IOREQ_SERVER_PFN: + d->arch.hvm.ioreq_gfn.base = a->value; + break; + case HVM_PARAM_NR_IOREQ_SERVER_PAGES: + { + unsigned int i; + + if ( a->value == 0 || + a->value > sizeof(d->arch.hvm.ioreq_gfn.mask) * 8 ) + { + rc = -EINVAL; + break; + } + for ( i = 0; i < a->value; i++ ) + set_bit(i, &d->arch.hvm.ioreq_gfn.mask); + + break; + } + } + + d->arch.hvm.params[a->index] = a->value; + + return rc; +} + long do_hvm_op(unsigned long op, XEN_GUEST_HANDLE_PARAM(void) arg) { long rc = 0; @@ -111,7 +155,7 @@ long do_hvm_op(unsigned long op, XEN_GUEST_HANDLE_PARAM(void) arg) if ( rc ) goto param_fail; - d->arch.hvm.params[a.index] = a.value; + rc = hvmop_set_param(d, &a); } else { diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c index ae7ef96..436f669 100644 --- a/xen/arch/arm/io.c +++ b/xen/arch/arm/io.c @@ -16,6 +16,7 @@ * GNU General Public License for more details. */ +#include #include #include #include @@ -107,6 +108,62 @@ static const struct mmio_handler *find_mmio_handler(struct domain *d, return handler; } +#ifdef CONFIG_IOREQ_SERVER +static enum io_state try_fwd_ioserv(struct cpu_user_regs *regs, + struct vcpu *v, mmio_info_t *info) +{ + struct hvm_vcpu_io *vio = &v->arch.hvm.hvm_io; + ioreq_t p = { + .type = IOREQ_TYPE_COPY, + .addr = info->gpa, + .size = 1 << info->dabt.size, + .count = 0, + .dir = !info->dabt.write, + .df = 0, /* XXX: What's for? */ + .data = get_user_reg(regs, info->dabt.reg), + .state = STATE_IOREQ_READY, + }; + struct hvm_ioreq_server *s = NULL; + enum io_state rc; + + switch ( vio->io_req.state ) + { + case STATE_IOREQ_NONE: + break; + default: + printk("d%u wrong state %u\n", v->domain->domain_id, + vio->io_req.state); + return IO_ABORT; + } + + s = hvm_select_ioreq_server(v->domain, &p); + if ( !s ) + return IO_UNHANDLED; + + if ( !info->dabt.valid ) + { + printk("Valid bit not set\n"); + return IO_ABORT; + } + + vio->io_req = p; + + rc = hvm_send_ioreq(s, &p, 0); + if ( rc != IO_RETRY || v->domain->is_shutting_down ) + vio->io_req.state = STATE_IOREQ_NONE; + else if ( !hvm_ioreq_needs_completion(&vio->io_req) ) + rc = IO_HANDLED; + else + vio->io_completion = HVMIO_mmio_completion; + + /* XXX: Decide what to do */ + if ( rc == IO_RETRY ) + rc = IO_HANDLED; + + return rc; +} +#endif + enum io_state try_handle_mmio(struct cpu_user_regs *regs, const union hsr hsr, paddr_t gpa) @@ -123,7 +180,15 @@ enum io_state try_handle_mmio(struct cpu_user_regs *regs, handler = find_mmio_handler(v->domain, info.gpa); if ( !handler ) - return IO_UNHANDLED; + { + int rc = IO_UNHANDLED; + +#ifdef CONFIG_IOREQ_SERVER + rc = try_fwd_ioserv(regs, v, &info); +#endif + + return rc; + } /* All the instructions used on emulated MMIO region should be valid */ if ( !dabt.valid ) diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c new file mode 100644 index 0000000..a9cc839 --- /dev/null +++ b/xen/arch/arm/ioreq.c @@ -0,0 +1,86 @@ +/* + * arm/ioreq.c: hardware virtual machine I/O emulation + * + * Copyright (c) 2019 Arm ltd. + * + * This program is free software; you can redistribute it and/or modify it + * under the terms and conditions of the GNU General Public License, + * version 2, as published by the Free Software Foundation. + * + * This program is distributed in the hope it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + * + * You should have received a copy of the GNU General Public License along with + * this program; If not, see . + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include + +bool handle_mmio(void) +{ + struct vcpu *v = current; + struct cpu_user_regs *regs = guest_cpu_user_regs(); + const union hsr hsr = { .bits = regs->hsr }; + const struct hsr_dabt dabt = hsr.dabt; + /* Code is similar to handle_read */ + uint8_t size = (1 << dabt.size) * 8; + register_t r = v->arch.hvm.hvm_io.io_req.data; + + /* We should only be here on Guest Data Abort */ + ASSERT(dabt.ec == HSR_EC_DATA_ABORT_LOWER_EL); + + /* We are done with the IO */ + /* XXX: Is it the right place? */ + v->arch.hvm.hvm_io.io_req.state = STATE_IOREQ_NONE; + + /* XXX: Do we need to take care of write here ? */ + if ( dabt.write ) + return true; + + /* + * Sign extend if required. + * Note that we expect the read handler to have zeroed the bits + * outside the requested access size. + */ + if ( dabt.sign && (r & (1UL << (size - 1))) ) + { + /* + * We are relying on register_t using the same as + * an unsigned long in order to keep the 32-bit assembly + * code smaller. + */ + BUILD_BUG_ON(sizeof(register_t) != sizeof(unsigned long)); + r |= (~0UL) << size; + } + + set_user_reg(regs, dabt.reg, r); + + return true; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index 8f40d0e..4cdf098 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -18,6 +18,7 @@ #include #include +#include #include #include #include @@ -1384,6 +1385,9 @@ static arm_hypercall_t arm_hypercall_table[] = { #ifdef CONFIG_HYPFS HYPERCALL(hypfs_op, 5), #endif +#ifdef CONFIG_IOREQ_SERVER + HYPERCALL(dm_op, 3), +#endif }; #ifndef NDEBUG @@ -1958,6 +1962,9 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs, case IO_UNHANDLED: /* IO unhandled, try another way to handle it. */ break; + default: + /* XXX: Handle IO_RETRY */ + ASSERT_UNREACHABLE(); } } @@ -2275,6 +2282,16 @@ static void check_for_vcpu_work(void) */ void leave_hypervisor_to_guest(void) { +#ifdef CONFIG_IOREQ_SERVER + /* + * XXX: Check the return. Shall we call that in + * continue_running and context_switch instead? + * The benefits would be to avoid calling + * handle_hvm_io_completion on every return. + */ + local_irq_enable(); + handle_hvm_io_completion(current); +#endif local_irq_disable(); check_for_vcpu_work(); diff --git a/xen/common/memory.c b/xen/common/memory.c index 9283e5e..0000477 100644 --- a/xen/common/memory.c +++ b/xen/common/memory.c @@ -8,6 +8,7 @@ */ #include +#include #include #include #include @@ -30,10 +31,6 @@ #include #include -#ifdef CONFIG_IOREQ_SERVER -#include -#endif - #ifdef CONFIG_X86 #include #endif diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h index 4e2f582..e060b0a 100644 --- a/xen/include/asm-arm/domain.h +++ b/xen/include/asm-arm/domain.h @@ -11,12 +11,64 @@ #include #include #include +#include +#include #include #include +struct hvm_ioreq_page { + gfn_t gfn; + struct page_info *page; + void *va; +}; + +struct hvm_ioreq_vcpu { + struct list_head list_entry; + struct vcpu *vcpu; + evtchn_port_t ioreq_evtchn; + bool pending; +}; + +#define NR_IO_RANGE_TYPES (XEN_DMOP_IO_RANGE_PCI + 1) +#define MAX_NR_IO_RANGES 256 + +#define MAX_NR_IOREQ_SERVERS 8 +#define DEFAULT_IOSERVID 0 + +struct hvm_ioreq_server { + struct domain *target, *emulator; + + /* Lock to serialize toolstack modifications */ + spinlock_t lock; + + struct hvm_ioreq_page ioreq; + struct list_head ioreq_vcpu_list; + struct hvm_ioreq_page bufioreq; + + /* Lock to serialize access to buffered ioreq ring */ + spinlock_t bufioreq_lock; + evtchn_port_t bufioreq_evtchn; + struct rangeset *range[NR_IO_RANGE_TYPES]; + bool enabled; + uint8_t bufioreq_handling; +}; + struct hvm_domain { uint64_t params[HVM_NR_PARAMS]; + + /* Guest page range used for non-default ioreq servers */ + struct { + unsigned long base; + unsigned long mask; + unsigned long legacy_mask; /* indexed by HVM param number */ + } ioreq_gfn; + + /* Lock protects all other values in the sub-struct and the default */ + struct { + spinlock_t lock; + struct hvm_ioreq_server *server[MAX_NR_IOREQ_SERVERS]; + } ioreq_server; }; #ifdef CONFIG_ARM_64 @@ -93,6 +145,29 @@ struct arch_domain #endif } __cacheline_aligned; +enum hvm_io_completion { + HVMIO_no_completion, + HVMIO_mmio_completion, + HVMIO_pio_completion, + HVMIO_realmode_completion +}; + +struct hvm_vcpu_io { + /* I/O request in flight to device model. */ + enum hvm_io_completion io_completion; + ioreq_t io_req; + + /* + * HVM emulation: + * Linear address @mmio_gla maps to MMIO physical frame @mmio_gpfn. + * The latter is known to be an MMIO frame (not RAM). + * This translation is only valid for accesses as per @mmio_access. + */ + struct npfec mmio_access; + unsigned long mmio_gla; + unsigned long mmio_gpfn; +}; + struct arch_vcpu { struct { @@ -206,6 +281,11 @@ struct arch_vcpu */ bool need_flush_to_ram; + struct hvm_vcpu + { + struct hvm_vcpu_io hvm_io; + } hvm; + } __cacheline_aligned; void vcpu_show_execution_state(struct vcpu *); diff --git a/xen/include/asm-arm/hvm/ioreq.h b/xen/include/asm-arm/hvm/ioreq.h new file mode 100644 index 0000000..83a560c --- /dev/null +++ b/xen/include/asm-arm/hvm/ioreq.h @@ -0,0 +1,103 @@ +/* + * hvm.h: Hardware virtual machine assist interface definitions. + * + * Copyright (c) 2016 Citrix Systems Inc. + * Copyright (c) 2019 Arm ltd. + * + * This program is free software; you can redistribute it and/or modify it + * under the terms and conditions of the GNU General Public License, + * version 2, as published by the Free Software Foundation. + * + * This program is distributed in the hope it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + * + * You should have received a copy of the GNU General Public License along with + * this program; If not, see . + */ + +#ifndef __ASM_ARM_HVM_IOREQ_H__ +#define __ASM_ARM_HVM_IOREQ_H__ + +#include +#include + +#define has_vpci(d) (false) + +bool handle_mmio(void); + +static inline bool handle_pio(uint16_t port, unsigned int size, int dir) +{ + /* XXX */ + BUG(); + return true; +} + +static inline paddr_t hvm_mmio_first_byte(const ioreq_t *p) +{ + return p->addr; +} + +static inline paddr_t hvm_mmio_last_byte(const ioreq_t *p) +{ + unsigned long size = p->size; + + return p->addr + size - 1; +} + +struct hvm_ioreq_server; + +static inline int p2m_set_ioreq_server(struct domain *d, + unsigned int flags, + struct hvm_ioreq_server *s) +{ + return -EOPNOTSUPP; +} + +static inline void msix_write_completion(struct vcpu *v) +{ +} + +static inline void handle_realmode_completion(void) +{ + ASSERT_UNREACHABLE(); +} + +static inline void paging_mark_pfn_dirty(struct domain *d, pfn_t pfn) +{ +} + +static inline void hvm_get_ioreq_server_range_type(struct domain *d, + ioreq_t *p, + uint8_t *type, + uint64_t *addr) +{ + *type = (p->type == IOREQ_TYPE_PIO) ? + XEN_DMOP_IO_RANGE_PORT : XEN_DMOP_IO_RANGE_MEMORY; + *addr = p->addr; +} + +static inline void arch_hvm_ioreq_init(struct domain *d) +{ +} + +static inline void arch_hvm_ioreq_destroy(struct domain *d) +{ +} + +#define IOREQ_IO_HANDLED IO_HANDLED +#define IOREQ_IO_UNHANDLED IO_UNHANDLED +#define IOREQ_IO_RETRY IO_RETRY + +#endif /* __ASM_X86_HVM_IOREQ_H__ */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/include/asm-arm/mmio.h b/xen/include/asm-arm/mmio.h index 8dbfb27..7ab873c 100644 --- a/xen/include/asm-arm/mmio.h +++ b/xen/include/asm-arm/mmio.h @@ -37,6 +37,7 @@ enum io_state IO_ABORT, /* The IO was handled by the helper and led to an abort. */ IO_HANDLED, /* The IO was successfully handled by the helper. */ IO_UNHANDLED, /* The IO was not handled by the helper. */ + IO_RETRY, /* Retry the emulation for some reason */ }; typedef int (*mmio_read_t)(struct vcpu *v, mmio_info_t *info, diff --git a/xen/include/asm-arm/p2m.h b/xen/include/asm-arm/p2m.h index 5fdb6e8..5823f11 100644 --- a/xen/include/asm-arm/p2m.h +++ b/xen/include/asm-arm/p2m.h @@ -385,10 +385,11 @@ static inline int set_foreign_p2m_entry(struct domain *d, unsigned long gfn, mfn_t mfn) { /* - * NOTE: If this is implemented then proper reference counting of - * foreign entries will need to be implemented. + * XXX: handle properly reference. It looks like the page may not always + * belong to d. */ - return -EOPNOTSUPP; + + return guest_physmap_add_entry(d, _gfn(gfn), mfn, 0, p2m_ram_rw); } /* diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h index 2368ace..317455a 100644 --- a/xen/include/xsm/dummy.h +++ b/xen/include/xsm/dummy.h @@ -713,14 +713,14 @@ static XSM_INLINE int xsm_pmu_op (XSM_DEFAULT_ARG struct domain *d, unsigned int } } +#endif /* CONFIG_X86 */ + static XSM_INLINE int xsm_dm_op(XSM_DEFAULT_ARG struct domain *d) { XSM_ASSERT_ACTION(XSM_DM_PRIV); return xsm_default_action(action, current->domain, d); } -#endif /* CONFIG_X86 */ - #ifdef CONFIG_ARGO static XSM_INLINE int xsm_argo_enable(const struct domain *d) { diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h index a80bcf3..2a9b39d 100644 --- a/xen/include/xsm/xsm.h +++ b/xen/include/xsm/xsm.h @@ -177,8 +177,8 @@ struct xsm_operations { int (*ioport_permission) (struct domain *d, uint32_t s, uint32_t e, uint8_t allow); int (*ioport_mapping) (struct domain *d, uint32_t s, uint32_t e, uint8_t allow); int (*pmu_op) (struct domain *d, unsigned int op); - int (*dm_op) (struct domain *d); #endif + int (*dm_op) (struct domain *d); int (*xen_version) (uint32_t cmd); int (*domain_resource_map) (struct domain *d); #ifdef CONFIG_ARGO @@ -688,13 +688,13 @@ static inline int xsm_pmu_op (xsm_default_t def, struct domain *d, unsigned int return xsm_ops->pmu_op(d, op); } +#endif /* CONFIG_X86 */ + static inline int xsm_dm_op(xsm_default_t def, struct domain *d) { return xsm_ops->dm_op(d); } -#endif /* CONFIG_X86 */ - static inline int xsm_xen_version (xsm_default_t def, uint32_t op) { return xsm_ops->xen_version(op); diff --git a/xen/xsm/dummy.c b/xen/xsm/dummy.c index d4cce68..e3afd06 100644 --- a/xen/xsm/dummy.c +++ b/xen/xsm/dummy.c @@ -148,8 +148,8 @@ void __init xsm_fixup_ops (struct xsm_operations *ops) set_to_dummy_if_null(ops, ioport_permission); set_to_dummy_if_null(ops, ioport_mapping); set_to_dummy_if_null(ops, pmu_op); - set_to_dummy_if_null(ops, dm_op); #endif + set_to_dummy_if_null(ops, dm_op); set_to_dummy_if_null(ops, xen_version); set_to_dummy_if_null(ops, domain_resource_map); #ifdef CONFIG_ARGO diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c index a314bf8..645192a 100644 --- a/xen/xsm/flask/hooks.c +++ b/xen/xsm/flask/hooks.c @@ -1662,14 +1662,13 @@ static int flask_pmu_op (struct domain *d, unsigned int op) return -EPERM; } } +#endif /* CONFIG_X86 */ static int flask_dm_op(struct domain *d) { return current_has_perm(d, SECCLASS_HVM, HVM__DM); } -#endif /* CONFIG_X86 */ - static int flask_xen_version (uint32_t op) { u32 dsid = domain_sid(current->domain); @@ -1872,8 +1871,8 @@ static struct xsm_operations flask_ops = { .ioport_permission = flask_ioport_permission, .ioport_mapping = flask_ioport_mapping, .pmu_op = flask_pmu_op, - .dm_op = flask_dm_op, #endif + .dm_op = flask_dm_op, .xen_version = flask_xen_version, .domain_resource_map = flask_domain_resource_map, #ifdef CONFIG_ARGO -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 18:22:12 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 18:22:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2f6C-0008KM-7N; Mon, 03 Aug 2020 18:22:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2f6B-0008F4-6y for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 18:22:11 +0000 X-Inumbo-ID: 32a454ae-d5b6-11ea-90c4-bc764e2007e4 Received: from mail-lf1-x142.google.com (unknown [2a00:1450:4864:20::142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 32a454ae-d5b6-11ea-90c4-bc764e2007e4; Mon, 03 Aug 2020 18:21:51 +0000 (UTC) Received: by mail-lf1-x142.google.com with SMTP id x24so3651762lfe.11 for ; Mon, 03 Aug 2020 11:21:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Mv84D4r2aumLFDv8lYRdBY/1g2sPieE7HeRa3w7RXVY=; b=PwJL8Ike+kIqVKmPv4Lw2iCjl0WHNL82j9B4uw9RwQQEO5EPmdiNiZqnuVtuBwWlEU Uosmt7kiLnfykZF/8NIzgiZBAu7LpgIadpcmhPbJg0Gda7UiU3wrkRWMUiPhuigx2vjs fgx7t8JQD1tYHx8TrRIqw54NcswwDk3NZH2aaOIElQVwKq8Sp1z39JU7Qzq1lGjaycPQ 3JPYcILbPRH9HhLPT1g3c5iDQH0ALiaBrmpQjlIu9Wx4LIco6LrI8KyePWraS4d8iXFo xKXCUm2X4VOAG7sjndU9Ltob7TYxUELO/oTbvE8jO4tQKeaiRJV1i2S7uM3hadfJ41OD /Adg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Mv84D4r2aumLFDv8lYRdBY/1g2sPieE7HeRa3w7RXVY=; b=bRtwMgOxh4WG0Och3XYnuo9a8HbECJPjODlL4vgeiA8OPvjGxQRlxnY0dyNlY76Lnu Ri3Fcxzi9NRK+aBhcZP7XUJneuwfTVCOfevr14Z0kyXyp2gCz5hHIG+DanW5gKGKM3jg D5JybWIirvyFOSbAiUdvLdeZLAp4vxWmwDwqBUx8SpbtOjD7dybrLqLFM4C1MFuFFYtz zx2hUKko1l8qMV2WK/+14//YVZc6lgj7Kt3Pybb+ImyYSJxoWoQp4EHSNuvd2C87sd/f q/ZWICF1+IQfVKHBoxL3arpX8scBzDLS5A2w9932rPsdnexeeYOeApJE0FghDWFh/3FH WQbA== X-Gm-Message-State: AOAM5339k+3/wRdXQJnSSEFVEK703B1xdjS436qxBPWB70sIVA2Mx2rv ldDaE+AdVs/EN/YWKfx+0xvkDiWQvCI= X-Google-Smtp-Source: ABdhPJxXWm0JBPyiKEZvceaAoqdJzrLR6fTtwnaGCqNa5E12FxcPBl8d3bee+TF2QDKbf03LyNkhCA== X-Received: by 2002:a19:c806:: with SMTP id y6mr2705506lff.156.1596478909751; Mon, 03 Aug 2020 11:21:49 -0700 (PDT) Received: from otyshchenko.www.tendawifi.com ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id h18sm4486730ljk.7.2020.08.03.11.21.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Aug 2020 11:21:49 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Subject: [RFC PATCH V1 05/12] hvm/dm: Introduce xendevicemodel_set_irq_level DM op Date: Mon, 3 Aug 2020 21:21:21 +0300 Message-Id: <1596478888-23030-6-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Julien Grall , Jan Beulich , Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Oleksandr Tyshchenko This patch adds ability to the device emulator to notify otherend (some entity running in the guest) using a SPI and implements Arm specific bits for it. Proposed interface allows emulator to set the logical level of a one of a domain's IRQ lines. Please note, this is a split/cleanup of Julien's PoC: "Add support for Guest IO forwarding to a device emulator" Signed-off-by: Julien Grall Signed-off-by: Oleksandr Tyshchenko --- tools/libs/devicemodel/core.c | 18 ++++++++++++++++++ tools/libs/devicemodel/include/xendevicemodel.h | 4 ++++ tools/libs/devicemodel/libxendevicemodel.map | 1 + xen/arch/arm/dm.c | 22 +++++++++++++++++++++- xen/common/hvm/dm.c | 1 + xen/include/public/hvm/dm_op.h | 15 +++++++++++++++ 6 files changed, 60 insertions(+), 1 deletion(-) diff --git a/tools/libs/devicemodel/core.c b/tools/libs/devicemodel/core.c index 4d40639..30bd79f 100644 --- a/tools/libs/devicemodel/core.c +++ b/tools/libs/devicemodel/core.c @@ -430,6 +430,24 @@ int xendevicemodel_set_isa_irq_level( return xendevicemodel_op(dmod, domid, 1, &op, sizeof(op)); } +int xendevicemodel_set_irq_level( + xendevicemodel_handle *dmod, domid_t domid, uint32_t irq, + unsigned int level) +{ + struct xen_dm_op op; + struct xen_dm_op_set_irq_level *data; + + memset(&op, 0, sizeof(op)); + + op.op = XEN_DMOP_set_irq_level; + data = &op.u.set_irq_level; + + data->irq = irq; + data->level = level; + + return xendevicemodel_op(dmod, domid, 1, &op, sizeof(op)); +} + int xendevicemodel_set_pci_link_route( xendevicemodel_handle *dmod, domid_t domid, uint8_t link, uint8_t irq) { diff --git a/tools/libs/devicemodel/include/xendevicemodel.h b/tools/libs/devicemodel/include/xendevicemodel.h index e877f5c..c06b3c8 100644 --- a/tools/libs/devicemodel/include/xendevicemodel.h +++ b/tools/libs/devicemodel/include/xendevicemodel.h @@ -209,6 +209,10 @@ int xendevicemodel_set_isa_irq_level( xendevicemodel_handle *dmod, domid_t domid, uint8_t irq, unsigned int level); +int xendevicemodel_set_irq_level( + xendevicemodel_handle *dmod, domid_t domid, unsigned int irq, + unsigned int level); + /** * This function maps a PCI INTx line to a an IRQ line. * diff --git a/tools/libs/devicemodel/libxendevicemodel.map b/tools/libs/devicemodel/libxendevicemodel.map index 561c62d..a0c3012 100644 --- a/tools/libs/devicemodel/libxendevicemodel.map +++ b/tools/libs/devicemodel/libxendevicemodel.map @@ -32,6 +32,7 @@ VERS_1.2 { global: xendevicemodel_relocate_memory; xendevicemodel_pin_memory_cacheattr; + xendevicemodel_set_irq_level; } VERS_1.1; VERS_1.3 { diff --git a/xen/arch/arm/dm.c b/xen/arch/arm/dm.c index 2437099..8431805 100644 --- a/xen/arch/arm/dm.c +++ b/xen/arch/arm/dm.c @@ -20,7 +20,27 @@ int arch_dm_op(struct xen_dm_op *op, struct domain *d, const struct dmop_args *op_args, bool *const_op) { - return -EOPNOTSUPP; + int rc; + + switch ( op->op ) + { + case XEN_DMOP_set_irq_level: + { + const struct xen_dm_op_set_irq_level *data = + &op->u.set_irq_level; + + /* XXX: Handle check */ + vgic_inject_irq(d, NULL, data->irq, data->level); + rc = 0; + break; + } + + default: + rc = -EOPNOTSUPP; + break; + } + + return rc; } /* diff --git a/xen/common/hvm/dm.c b/xen/common/hvm/dm.c index 09e9542..e2e1250 100644 --- a/xen/common/hvm/dm.c +++ b/xen/common/hvm/dm.c @@ -47,6 +47,7 @@ static int dm_op(const struct dmop_args *op_args) [XEN_DMOP_remote_shutdown] = sizeof(struct xen_dm_op_remote_shutdown), [XEN_DMOP_relocate_memory] = sizeof(struct xen_dm_op_relocate_memory), [XEN_DMOP_pin_memory_cacheattr] = sizeof(struct xen_dm_op_pin_memory_cacheattr), + [XEN_DMOP_set_irq_level] = sizeof(struct xen_dm_op_set_irq_level), }; rc = rcu_lock_remote_domain_by_id(op_args->domid, &d); diff --git a/xen/include/public/hvm/dm_op.h b/xen/include/public/hvm/dm_op.h index fd00e9d..c45d29e 100644 --- a/xen/include/public/hvm/dm_op.h +++ b/xen/include/public/hvm/dm_op.h @@ -417,6 +417,20 @@ struct xen_dm_op_pin_memory_cacheattr { uint32_t pad; }; +/* + * XEN_DMOP_set_irq_level: Set the logical level of a one of a domain's + * IRQ lines. + * XXX Handle PPIs. + */ +#define XEN_DMOP_set_irq_level 19 + +struct xen_dm_op_set_irq_level { + uint32_t irq; + /* IN - Level: 0 -> deasserted, 1 -> asserted */ + uint8_t level; +}; + + struct xen_dm_op { uint32_t op; uint32_t pad; @@ -430,6 +444,7 @@ struct xen_dm_op { struct xen_dm_op_track_dirty_vram track_dirty_vram; struct xen_dm_op_set_pci_intx_level set_pci_intx_level; struct xen_dm_op_set_isa_irq_level set_isa_irq_level; + struct xen_dm_op_set_irq_level set_irq_level; struct xen_dm_op_set_pci_link_route set_pci_link_route; struct xen_dm_op_modified_memory modified_memory; struct xen_dm_op_set_mem_type set_mem_type; -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 18:22:17 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 18:22:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2f6H-0008Mg-Lg; Mon, 03 Aug 2020 18:22:17 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2f6G-0008F4-7C for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 18:22:16 +0000 X-Inumbo-ID: 33932a00-d5b6-11ea-90c4-bc764e2007e4 Received: from mail-lf1-x143.google.com (unknown [2a00:1450:4864:20::143]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 33932a00-d5b6-11ea-90c4-bc764e2007e4; Mon, 03 Aug 2020 18:21:52 +0000 (UTC) Received: by mail-lf1-x143.google.com with SMTP id x24so3651785lfe.11 for ; Mon, 03 Aug 2020 11:21:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=KJwl2Gf8Kc5S6/JKnP2lqwji4gRYsqHMXGwGJUsp3PA=; b=HYJEXbGiDpX09e/7tZjQdogZIcJH4gMNC09XuyfFLcrQThKzJ7c6ZFJCl2riNdhQHn N0zLR59eCnQ48byQmeEticc8+PAD0yhFJJGO6IXTqOkC/kFxBGf8zuKAGiT9BDnofh+L Ze/ZNeonVO5rP7j6/vDr6T5/wJd35ZREnwHf6AWZD8kDX9FS3rZoOyFbtM+3BM/4SBxi 5lottYR/7hNls0wK9wO/RtKoCc5JrHbiULIfTo72r1rS3n+lXW+BsCKRtGINM3emRq1K +nJ7h1sWOFTi+IBjAeZoQ4sh+1LGtWIN6fXQgH1k9sIoCzqBO0FPRMY9X4ll1/RNWz82 nKxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=KJwl2Gf8Kc5S6/JKnP2lqwji4gRYsqHMXGwGJUsp3PA=; b=IUFu/dTEY5LkOYxAQx0EFwdVtskyv2cSXpFwqizsU1zL5E6P78BAbuJQbsgfTUSRFr gOjsGw+pHfx7d2WuogdYV2TDW9LmJaNGSUKUtDrkurV7Ft03H0qMbwk5iNT6iDthQui1 pVkadhh1YsDIks1bi+f1F/N/k5gf8RT8uNMSx4UjfX+D/TgiMrRsk38mLNAMoc3G2tJZ W+vSW6zWKa+a8Y2YX4/nRne7jOfDKW+hLEP96kD0tZyskatcU+pOpm/SJ5he77Xhg6Bj PfDpJQGQnCYpMUAzgmVZwon1rdu371NZx1eF5smC7571LhtXRJ3bNtquxGV8XdzwYVKz NvZw== X-Gm-Message-State: AOAM531mY97voCksnP1D1/ZhtYb/+6L2vGh28gX24uUG0Ek/YH1a96Ar fF6/7/ReBJ7I8ANEcTcsyJRVU3KDkTg= X-Google-Smtp-Source: ABdhPJz/K3XOJPdOW03K8F5ra2FDgmd10m+rY5j09JeC8qbFsgW0FOwPYAJfoEjxaSi+C7e6N/cx0w== X-Received: by 2002:ac2:4c33:: with SMTP id u19mr9422767lfq.154.1596478910795; Mon, 03 Aug 2020 11:21:50 -0700 (PDT) Received: from otyshchenko.www.tendawifi.com ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id h18sm4486730ljk.7.2020.08.03.11.21.49 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Aug 2020 11:21:50 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Subject: [RFC PATCH V1 06/12] libxl: Introduce basic virtio-mmio support on Arm Date: Mon, 3 Aug 2020 21:21:22 +0300 Message-Id: <1596478888-23030-7-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Ian Jackson , Oleksandr Tyshchenko , Julien Grall , Anthony PERARD Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Oleksandr Tyshchenko This patch creates specific device node in the Guest device-tree with allocated MMIO range and SPI interrupt if specific 'virtio' property is present in domain config. Please note, this patch breaks device passthrough use-case which will be fixed in one of the follow-up patches. Please note, this is a split/cleanup of Julien's PoC: "Add support for Guest IO forwarding to a device emulator" Signed-off-by: Julien Grall Signed-off-by: Oleksandr Tyshchenko --- tools/libxl/libxl_arm.c | 39 +++++++++++++++++++++++++++++++++++++++ tools/libxl/libxl_types.idl | 1 + tools/xl/xl_parse.c | 1 + 3 files changed, 41 insertions(+) diff --git a/tools/libxl/libxl_arm.c b/tools/libxl/libxl_arm.c index 34f8a29..620b499 100644 --- a/tools/libxl/libxl_arm.c +++ b/tools/libxl/libxl_arm.c @@ -68,6 +68,10 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, nr_spis = spi + 1; } + + /* XXX: Handle properly virtio */ + nr_spis = 1; + LOG(DEBUG, "Configure the domain"); config->arch.nr_spis = nr_spis; @@ -659,6 +663,37 @@ static int make_vpl011_uart_node(libxl__gc *gc, void *fdt, return 0; } +#define GUEST_VIRTIO_MMIO_BASE xen_mk_ullong(0x02000000) +#define GUEST_VIRTIO_MMIO_SIZE xen_mk_ullong(0x200) +#define GUEST_VIRTIO_MMIO_SPI 33 + +static int make_virtio_mmio_node(libxl__gc *gc, void *fdt) +{ + int res; + gic_interrupt intr; + + /* XXX: Add address in the node name */ + res = fdt_begin_node(fdt, "virtio"); + if (res) return res; + + res = fdt_property_compat(gc, fdt, 1, "virtio,mmio"); + if (res) return res; + + res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS, + 1, GUEST_VIRTIO_MMIO_BASE, GUEST_VIRTIO_MMIO_SIZE); + if (res) return res; + + set_interrupt(intr, GUEST_VIRTIO_MMIO_SPI, 0xf, DT_IRQ_TYPE_EDGE_RISING); + res = fdt_property_interrupts(gc, fdt, &intr, 1); + if (res) return res; + + res = fdt_end_node(fdt); + if (res) return res; + + return 0; + +} + static const struct arch_info *get_arch_info(libxl__gc *gc, const struct xc_dom_image *dom) { @@ -962,6 +997,9 @@ next_resize: if (info->tee == LIBXL_TEE_TYPE_OPTEE) FDT( make_optee_node(gc, fdt) ); + if (libxl_defbool_val(info->arch_arm.virtio)) + FDT( make_virtio_mmio_node(gc, fdt) ); + if (pfdt) FDT( copy_partial_fdt(gc, fdt, pfdt) ); @@ -1179,6 +1217,7 @@ void libxl__arch_domain_build_info_setdefault(libxl__gc *gc, { /* ACPI is disabled by default */ libxl_defbool_setdefault(&b_info->acpi, false); + libxl_defbool_setdefault(&b_info->arch_arm.virtio, false); if (b_info->type != LIBXL_DOMAIN_TYPE_PV) return; diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl index 9d3f05f..b054bf9 100644 --- a/tools/libxl/libxl_types.idl +++ b/tools/libxl/libxl_types.idl @@ -639,6 +639,7 @@ libxl_domain_build_info = Struct("domain_build_info",[ ("arch_arm", Struct(None, [("gic_version", libxl_gic_version), + ("virtio", libxl_defbool), ("vuart", libxl_vuart_type), ])), # Alternate p2m is not bound to any architecture or guest type, as it is diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index 61b4ef7..b8306aa 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -2579,6 +2579,7 @@ skip_usbdev: } xlu_cfg_get_defbool(config, "dm_restrict", &b_info->dm_restrict, 0); + xlu_cfg_get_defbool(config, "virtio", &b_info->arch_arm.virtio, 0); if (c_info->type == LIBXL_DOMAIN_TYPE_HVM) { if (!xlu_cfg_get_string (config, "vga", &buf, 0)) { -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 18:22:23 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 18:22:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2f6M-0008P2-UY; Mon, 03 Aug 2020 18:22:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2f6L-0008F4-7V for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 18:22:21 +0000 X-Inumbo-ID: 34593e8e-d5b6-11ea-90c4-bc764e2007e4 Received: from mail-lf1-x143.google.com (unknown [2a00:1450:4864:20::143]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 34593e8e-d5b6-11ea-90c4-bc764e2007e4; Mon, 03 Aug 2020 18:21:53 +0000 (UTC) Received: by mail-lf1-x143.google.com with SMTP id d2so15343777lfj.1 for ; Mon, 03 Aug 2020 11:21:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=81P0Yc4v6ZyioiYpKUcR0ZeC9nLn0E/s9OZDx4+Xc7c=; b=NRXK/Eep0Wp1l3ih8IjXSdhoX84+x4SxXAZnDjEc2HgGLPVFXjpD3VHiS9QGzhpqQN afIsSh1llgIKPdo5p+Pl9UD9MwJAbPYOShphK491g+ofAXERik6ynfXHeDX940X2Ny/e dSd3Sw76daOwNXKGFkaCVTn27xZT6NKXWXhPqq6/THS0Lv/p5wkivy+O3tmFeCP3GUxq tq86cBHGOSCI1OXhKfJznyGzsnLQHturZB72B9x0if6ZOVSx5D86Kf9MQNxJ9rWjgTRQ /JG3k1b//DzA9iUXyoBIypIwUAvapNyPnxvhfpkOpPCb6fjALE1BFmDO8x6u5GMC/yk4 bU2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=81P0Yc4v6ZyioiYpKUcR0ZeC9nLn0E/s9OZDx4+Xc7c=; b=jKauXWAfXoSiVuNKyBIiGIghogNuFhTyzaRHA6s47Xelh+ZsSC8mbCdsUv1YSo8Ub8 IE300Njd3zLvBRmYfZRNX0x/JE5A1nNmwpYF+Ej1BrodS/ektpsPzHhAO/yOkEkI6p2R x5K6g7k/JYQ0DaGtRHMBWekMLjbMG+O99XQDzHapxRN1TnQ5JGjwjC0eVP09MJkZwn+O qOAtzSu2NUQgePQMGSM0clhkMqRn1JleKxe2D30ExkvOt4fBY9NQu+rzYdNhrjVZ1q3X g6AjtaEDJPKiXSklHS9UQzxSCyHO238rhH0McmIft3kpERd5puOH4nq22G9SoXOemY18 iAMQ== X-Gm-Message-State: AOAM530MuXpEb4/v1l6W3wBPBVMVrOss9sQO6lxA5B4z2zyFGJEwa8PY 2FVglOusfN8KE/R+031GTR0CkLTwDs8= X-Google-Smtp-Source: ABdhPJwB9MeBGy/n2L9LbiCW8INF2cJ2XhF0qsz3n8TE1nbBrC5AGBbU+X5NCnGLXt/qAJfCnWS8oQ== X-Received: by 2002:a19:c653:: with SMTP id w80mr9132168lff.167.1596478912037; Mon, 03 Aug 2020 11:21:52 -0700 (PDT) Received: from otyshchenko.www.tendawifi.com ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id h18sm4486730ljk.7.2020.08.03.11.21.50 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Aug 2020 11:21:51 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Subject: [RFC PATCH V1 07/12] A collection of tweaks to be able to run emulator in driver domain Date: Mon, 3 Aug 2020 21:21:23 +0300 Message-Id: <1596478888-23030-8-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Jan Beulich , Daniel De Graaf Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Oleksandr Tyshchenko Trying to run emulator in driver domain I ran into various issues mostly policy-related. So this patch tries to resolve all them plobably in a hackish way. I would like to get feedback how to implement them properly as having an emulator in driver domain is a completely valid use-case. Signed-off-by: Oleksandr Tyshchenko --- xen/common/domain.c | 15 +++++++++++++++ xen/common/domctl.c | 8 +++++++- xen/common/event_channel.c | 14 ++++++++++++-- xen/common/memory.c | 6 ++++++ xen/include/xsm/dummy.h | 16 +++++++++++++--- 5 files changed, 53 insertions(+), 6 deletions(-) diff --git a/xen/common/domain.c b/xen/common/domain.c index e9be05f..5c9fef2 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -695,6 +695,7 @@ int domain_kill(struct domain *d) { int rc = 0; struct vcpu *v; + struct domain *td; if ( d == current->domain ) return -EINVAL; @@ -733,6 +734,20 @@ int domain_kill(struct domain *d) * have to be put before we call put_domain. */ vm_event_cleanup(d); put_domain(d); + /* + * XEN_DOMCTL_set_target implementation holds reference on + * target domain which doesn't allow to completely destroy it. + * Check if the reference are hold by someone and drop it + * when destroying target domain. + */ + for_each_domain ( td ) { + if ( td->target == d ) { + td->target = NULL; + put_domain(d); + break; + } + } + send_global_virq(VIRQ_DOM_EXC); /* fallthrough */ case DOMDYING_dead: diff --git a/xen/common/domctl.c b/xen/common/domctl.c index a69b3b5..079c7b0 100644 --- a/xen/common/domctl.c +++ b/xen/common/domctl.c @@ -871,6 +871,12 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) if ( (d == e) || (d->target != NULL) ) { put_domain(e); + /* + * Be a little bit more polite here, looks like the emulator + * has just been restarted. + */ + if ( d->target == e ) + ret = 0; break; } @@ -883,7 +889,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) break; } - /* Hold reference on @e until we destroy @d. */ + /* Hold reference on @e until we destroy either @d or @e */ d->target = e; break; } diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c index a8d182b5..2aa497a 100644 --- a/xen/common/event_channel.c +++ b/xen/common/event_channel.c @@ -235,7 +235,12 @@ static long evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc) ERROR_EXIT_DOM(port, d); chn = evtchn_from_port(d, port); - rc = xsm_evtchn_unbound(XSM_TARGET, d, chn, alloc->remote_dom); + /* + * XXX: XSM_TARGET is not functional for emulator running in driver domain. + * See xsm_default_action for details. Probably XSM_DM_PRIV could work, + * but there is a risk to break other users. + */ + rc = xsm_evtchn_unbound(XSM_HOOK, d, chn, alloc->remote_dom); if ( rc ) goto out; @@ -1218,7 +1223,12 @@ int alloc_unbound_xen_event_channel( port = rc; chn = evtchn_from_port(ld, port); - rc = xsm_evtchn_unbound(XSM_TARGET, ld, chn, remote_domid); + /* + * XXX: XSM_TARGET is not functional for emulator running in driver domain. + * See xsm_default_action for details. Probably XSM_DM_PRIV could work, + * but there is a risk to break other users. + */ + rc = xsm_evtchn_unbound(XSM_HOOK, ld, chn, remote_domid); if ( rc ) goto out; diff --git a/xen/common/memory.c b/xen/common/memory.c index 0000477..8b306f6 100644 --- a/xen/common/memory.c +++ b/xen/common/memory.c @@ -1153,12 +1153,18 @@ static int acquire_resource( unsigned int i; /* + * XXX: Ugly hack for now to let emulator running in driver domain + * to succeeded in acquiring resource. + */ +#if 0 + /* * FIXME: Until foreign pages inserted into the P2M are properly * reference counted, it is unsafe to allow mapping of * resource pages unless the caller is the hardware domain. */ if ( !is_hardware_domain(currd) ) return -EACCES; +#endif if ( copy_from_guest(gfn_list, xmar.frame_list, xmar.nr_frames) ) rc = -EFAULT; diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h index 317455a..c0813c0 100644 --- a/xen/include/xsm/dummy.h +++ b/xen/include/xsm/dummy.h @@ -139,13 +139,23 @@ static XSM_INLINE int xsm_domctl(XSM_DEFAULT_ARG struct domain *d, int cmd) XSM_ASSERT_ACTION(XSM_OTHER); switch ( cmd ) { + /* + * XXX: Emulator running in driver domain tries to get vcpus num. + * Probably we could avoid that change by modifying emulator to not use + * domctl for getting vcpus num. + */ + case XEN_DOMCTL_getdomaininfo: + /* + * XXX: XSM_DM_PRIV is not functional for emulator running in driver domain + * without setting a target in advance. See xsm_default_action for details. + */ + case XEN_DOMCTL_set_target: + return xsm_default_action(XSM_HOOK, current->domain, d); case XEN_DOMCTL_ioport_mapping: case XEN_DOMCTL_memory_mapping: case XEN_DOMCTL_bind_pt_irq: case XEN_DOMCTL_unbind_pt_irq: return xsm_default_action(XSM_DM_PRIV, current->domain, d); - case XEN_DOMCTL_getdomaininfo: - return xsm_default_action(XSM_XS_PRIV, current->domain, d); default: return xsm_default_action(XSM_PRIV, current->domain, d); } @@ -275,7 +285,7 @@ static XSM_INLINE int xsm_claim_pages(XSM_DEFAULT_ARG struct domain *d) static XSM_INLINE int xsm_evtchn_unbound(XSM_DEFAULT_ARG struct domain *d, struct evtchn *chn, domid_t id2) { - XSM_ASSERT_ACTION(XSM_TARGET); + XSM_ASSERT_ACTION(XSM_HOOK); return xsm_default_action(action, current->domain, d); } -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 18:22:27 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 18:22:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2f6R-0008Rt-7Q; Mon, 03 Aug 2020 18:22:27 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2f6Q-0008F4-7l for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 18:22:26 +0000 X-Inumbo-ID: 34f13356-d5b6-11ea-90c4-bc764e2007e4 Received: from mail-lf1-x141.google.com (unknown [2a00:1450:4864:20::141]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 34f13356-d5b6-11ea-90c4-bc764e2007e4; Mon, 03 Aug 2020 18:21:54 +0000 (UTC) Received: by mail-lf1-x141.google.com with SMTP id x24so3651859lfe.11 for ; Mon, 03 Aug 2020 11:21:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=1oSrmefLumOTqH6DfN/w0NjDRHD49Q9D8VghKe2JYu8=; b=V//h+OxqeiTG5OZxMtbFbmVHdAJskjcYsEd2xBVHcfS3K60z84ELVyvw9UsE2OTKoV UGXy+Lkr2/oNp+UXmgZTECJ9QucYCQc7vn0fYfk8wB8WrfvyFeeM0qCFPuLvyonPNYbM 2aR6pdbUjRTh9dJ3By/wPCTtqD49tMntucBW3z8MfI33eAhL36GKjOw+NAyBmmQr/4Tn 0LfDyEag75/lUkYqunp4lJlPfXoQtAyOBzyL/qIBtzj/OggwyILcXnTdnHy2sg7THa+o sIfQcR+jow8oa6VJg//vmD5oY+75hRDzyu7zKKxmXPzNk6iVuVQGY6lAS3bILycYEDoP 5vEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=1oSrmefLumOTqH6DfN/w0NjDRHD49Q9D8VghKe2JYu8=; b=Ap8qk2zJAKDGYOsOA33qUDPF+y3qEJBjMll6fcRqcB2nXoOp/Sy15w7Vfo9mN2yiy9 FB1raKhXu5UZoZkFs2qqQQxj+1QM1rP5AYKySnYzyzKneX5yaQaYueHvbhS3Kot2sGZA mA3+WyyDULzK+ERK5JP6QXeZI7x0wQsQEtmrK4aj8W1pfqqM6qQCouYUHrqT2b8VeTgI 19VFlv89yzu0Ws/sFn+wYoXWyJ/iAdMMCeXzi/mIRb2fR6NqffSXLnfZ7pLpv3skb9Kq ifsqF+udmHgmxzcyTpa1TOdUH1/MAzcueJOmdbslJyA0vDpTv51j+W7gzhIqv/thSRsk GV6g== X-Gm-Message-State: AOAM531hvV8mNb3fZaoSUYDQR321Fse+2d5mjpc4DYHEPn0Gmt+LRuPI THVS6SDnD0LwpPVPXnaMbp1El/imALs= X-Google-Smtp-Source: ABdhPJxm4yfX8MSfwMtCdpABV1bvZqTlKWi27x2GrGHTMWtxZu4TK/T5zajR7U42CXNf3f6RN1w07Q== X-Received: by 2002:a19:418a:: with SMTP id o132mr9319096lfa.63.1596478913112; Mon, 03 Aug 2020 11:21:53 -0700 (PDT) Received: from otyshchenko.www.tendawifi.com ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id h18sm4486730ljk.7.2020.08.03.11.21.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Aug 2020 11:21:52 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Subject: [RFC PATCH V1 08/12] xen/arm: Invalidate qemu mapcache on XENMEM_decrease_reservation Date: Mon, 3 Aug 2020 21:21:24 +0300 Message-Id: <1596478888-23030-9-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Jan Beulich , Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Oleksandr Tyshchenko Borrow x86's logic to invalidate qemu mapcache. TODO: Move send_invalidate_req() to common code (ioreq.c?). Signed-off-by: Oleksandr Tyshchenko --- xen/arch/arm/ioreq.c | 14 ++++++++++++++ xen/arch/arm/traps.c | 6 ++++++ xen/common/memory.c | 6 ++++++ xen/include/asm-arm/domain.h | 2 ++ xen/include/asm-arm/hvm/ioreq.h | 2 ++ 5 files changed, 30 insertions(+) diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c index a9cc839..8f60c41 100644 --- a/xen/arch/arm/ioreq.c +++ b/xen/arch/arm/ioreq.c @@ -75,6 +75,20 @@ bool handle_mmio(void) return true; } +/* Ask ioemu mapcache to invalidate mappings. */ +void send_invalidate_req(void) +{ + ioreq_t p = { + .type = IOREQ_TYPE_INVALIDATE, + .size = 4, + .dir = IOREQ_WRITE, + .data = ~0UL, /* flush all */ + }; + + if ( hvm_broadcast_ioreq(&p, false) != 0 ) + gprintk(XENLOG_ERR, "Unsuccessful map-cache invalidate\n"); +} + /* * Local variables: * mode: C diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index 4cdf098..ea472d1 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -1490,6 +1490,12 @@ static void do_trap_hypercall(struct cpu_user_regs *regs, register_t *nr, /* Ensure the hypercall trap instruction is re-executed. */ if ( current->hcall_preempted ) regs->pc -= 4; /* re-execute 'hvc #XEN_HYPERCALL_TAG' */ + +#ifdef CONFIG_IOREQ_SERVER + if ( unlikely(current->domain->arch.hvm.qemu_mapcache_invalidate) && + test_and_clear_bool(current->domain->arch.hvm.qemu_mapcache_invalidate) ) + send_invalidate_req(); +#endif } void arch_hypercall_tasklet_result(struct vcpu *v, long res) diff --git a/xen/common/memory.c b/xen/common/memory.c index 8b306f6..8d9f0a8 100644 --- a/xen/common/memory.c +++ b/xen/common/memory.c @@ -1652,6 +1652,12 @@ long do_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg) break; } + /* x86 already sets the flag in hvm_memory_op() */ +#if defined(CONFIG_ARM64) && defined(CONFIG_IOREQ_SERVER) + if ( op == XENMEM_decrease_reservation ) + curr_d->arch.hvm.qemu_mapcache_invalidate = true; +#endif + return rc; } diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h index e060b0a..0db8bb4 100644 --- a/xen/include/asm-arm/domain.h +++ b/xen/include/asm-arm/domain.h @@ -69,6 +69,8 @@ struct hvm_domain spinlock_t lock; struct hvm_ioreq_server *server[MAX_NR_IOREQ_SERVERS]; } ioreq_server; + + bool_t qemu_mapcache_invalidate; }; #ifdef CONFIG_ARM_64 diff --git a/xen/include/asm-arm/hvm/ioreq.h b/xen/include/asm-arm/hvm/ioreq.h index 83a560c..392ce64 100644 --- a/xen/include/asm-arm/hvm/ioreq.h +++ b/xen/include/asm-arm/hvm/ioreq.h @@ -90,6 +90,8 @@ static inline void arch_hvm_ioreq_destroy(struct domain *d) #define IOREQ_IO_UNHANDLED IO_UNHANDLED #define IOREQ_IO_RETRY IO_RETRY +void send_invalidate_req(void); + #endif /* __ASM_X86_HVM_IOREQ_H__ */ /* -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 18:22:32 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 18:22:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2f6W-0008W8-Hk; Mon, 03 Aug 2020 18:22:32 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2f6V-0008F4-7r for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 18:22:31 +0000 X-Inumbo-ID: 359da712-d5b6-11ea-90c4-bc764e2007e4 Received: from mail-lj1-x241.google.com (unknown [2a00:1450:4864:20::241]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 359da712-d5b6-11ea-90c4-bc764e2007e4; Mon, 03 Aug 2020 18:21:55 +0000 (UTC) Received: by mail-lj1-x241.google.com with SMTP id w14so10874971ljj.4 for ; Mon, 03 Aug 2020 11:21:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=FmQeBTMaiyQz/Hd6vgyjkGjraUz7GZ+o5Z5LqiJNJDo=; b=gAWzKt2Cbi1NKv4UBav+vbo8LfDixp+Eap1dTPtwi2BMWPaf2jU4Rjoydyz7agqrr9 +X6kk1zWdRLI6Wwn1U8IRrX2XwWY4awi9IqLlCRZPsI8lcKJqeHb9zfPJq5eOZtney6D 17hNLeYak2BbiiZvuAwy6/k+DRZ50CV7KLH3G6tnwc498srQz0pF6HbbE50eT1K7CVS9 jtituXwf2GEWFHkta829sxlrHqcIwj5DY2U3IF9qf8QF3ybtuvAWKIBa3pId7Xpem9jO Me2bjrfWwt1B2qAbtkA2Gzfs31yZXRhANkD3FnWfpiYpjWdPGJXs5XS9Jt5K5t1rg/QC TqrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=FmQeBTMaiyQz/Hd6vgyjkGjraUz7GZ+o5Z5LqiJNJDo=; b=YIIb4sSDldRLYrn3UP3EkqrHmXfCR1IcBlVTkY1j1Yj1sXT/Fp7Bdx+OB2mkiBadAA NUQl3r0t5wD8+2AdSbVbizy7DDExVWCVKUepPLC6yjCxhvq8ZzeTj53aPrYPXhXDLs2R 41N0P4RWSujN3xTqVE1xBOxfn0y8VIb2CRBEE6DAJ6JaoImv7Sy4yQqXzvg8H/sA91oL 1s3cqgOaIVlSmpDzeYxLvuOPeUGZgbJ8IY1LqJMnS5d2TeRzDFCxmmOh4UJnM1aUHXfa SJR/NiMgkpHsjhiOZAyl8XyDYD0xZyo936vmlo8gspw/bvxfQ/mBX29JiRdZWk+eX874 eVlw== X-Gm-Message-State: AOAM531KCGRPzOsvSMFSWVI4zg6Hq2PiK1DJKfZCilIeqeimDTzBMSJ4 KVtxZ9qkPZ/Cl15xqp4LFNZCHfFVaTs= X-Google-Smtp-Source: ABdhPJyPqjNSkPtYdYQNj5MmLgmHtV9oiYCjfWDQdqSaYeTCaiAqb1M+7uHa6BFqYFLlZF2nCrz+Vg== X-Received: by 2002:a2e:3c16:: with SMTP id j22mr8489386lja.92.1596478914266; Mon, 03 Aug 2020 11:21:54 -0700 (PDT) Received: from otyshchenko.www.tendawifi.com ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id h18sm4486730ljk.7.2020.08.03.11.21.53 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Aug 2020 11:21:53 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Subject: [RFC PATCH V1 09/12] libxl: Handle virtio-mmio irq in more correct way Date: Mon, 3 Aug 2020 21:21:25 +0300 Message-Id: <1596478888-23030-10-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Ian Jackson , Oleksandr Tyshchenko , Anthony PERARD Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Oleksandr Tyshchenko This patch makes possible to use device passthrough again. Signed-off-by: Oleksandr Tyshchenko --- tools/libxl/libxl_arm.c | 33 +++++++++++++++++++++++---------- 1 file changed, 23 insertions(+), 10 deletions(-) diff --git a/tools/libxl/libxl_arm.c b/tools/libxl/libxl_arm.c index 620b499..4f748e3 100644 --- a/tools/libxl/libxl_arm.c +++ b/tools/libxl/libxl_arm.c @@ -9,6 +9,10 @@ #include #include +#define GUEST_VIRTIO_MMIO_BASE xen_mk_ullong(0x02000000) +#define GUEST_VIRTIO_MMIO_SIZE xen_mk_ullong(0x200) +#define GUEST_VIRTIO_MMIO_SPI 33 + static const char *gicv_to_string(libxl_gic_version gic_version) { switch (gic_version) { @@ -27,8 +31,8 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, { uint32_t nr_spis = 0; unsigned int i; - uint32_t vuart_irq; - bool vuart_enabled = false; + uint32_t vuart_irq, virtio_irq; + bool vuart_enabled = false, virtio_enabled = false; /* * If pl011 vuart is enabled then increment the nr_spis to allow allocation @@ -40,6 +44,17 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, vuart_enabled = true; } + /* + * XXX: Handle properly virtio + * A proper solution would be the toolstack to allocate the interrupts + * used by each virtio backend and let the backend now which one is used + */ + if (libxl_defbool_val(d_config->b_info.arch_arm.virtio)) { + nr_spis += (GUEST_VIRTIO_MMIO_SPI - 32) + 1; + virtio_irq = GUEST_VIRTIO_MMIO_SPI; + virtio_enabled = true; + } + for (i = 0; i < d_config->b_info.num_irqs; i++) { uint32_t irq = d_config->b_info.irqs[i]; uint32_t spi; @@ -59,6 +74,12 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, return ERROR_FAIL; } + /* The same check as for vpl011 */ + if (virtio_enabled && irq == virtio_irq) { + LOG(ERROR, "Physical IRQ %u conflicting with virtio SPI\n", irq); + return ERROR_FAIL; + } + if (irq < 32) continue; @@ -68,10 +89,6 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, nr_spis = spi + 1; } - - /* XXX: Handle properly virtio */ - nr_spis = 1; - LOG(DEBUG, "Configure the domain"); config->arch.nr_spis = nr_spis; @@ -663,10 +680,6 @@ static int make_vpl011_uart_node(libxl__gc *gc, void *fdt, return 0; } -#define GUEST_VIRTIO_MMIO_BASE xen_mk_ullong(0x02000000) -#define GUEST_VIRTIO_MMIO_SIZE xen_mk_ullong(0x200) -#define GUEST_VIRTIO_MMIO_SPI 33 - static int make_virtio_mmio_node(libxl__gc *gc, void *fdt) { int res; -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 18:31:08 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 18:31:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2fEn-0001ZB-Rj; Mon, 03 Aug 2020 18:31:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2f6a-0008F4-7x for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 18:22:36 +0000 X-Inumbo-ID: 36cf2a99-d5b6-11ea-90c4-bc764e2007e4 Received: from mail-lj1-x241.google.com (unknown [2a00:1450:4864:20::241]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 36cf2a99-d5b6-11ea-90c4-bc764e2007e4; Mon, 03 Aug 2020 18:21:57 +0000 (UTC) Received: by mail-lj1-x241.google.com with SMTP id z14so3126925ljm.1 for ; Mon, 03 Aug 2020 11:21:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Dr2Tb8xNL8Zd44BZpRkZWI6gE4U1QZUhIvG9zNQ9PsI=; b=S4fDFMYUo5BvRyBoYeUyXtrUL2wsl88uUzfLHup9REJqHQU6+5cxkMSy8GXKdCon0i L80wX4sKQDnu4EmrpVeh0MsK2uTWek4a7p4nU35hXmuZlH/WCSx/YXxzHrV9q/4nvqgj fIVLNzLCM4+8QqBoqUL3/z642rYSqAvQYcytvE7A/Q3JHR6UXO8b2vU+M6r+mGXatGUz /R0KKRA0+n4kSD8aXKKDDI01t+9iVRLWS0822Z3GfxMhtJx35KgVhiib7Xgwz5Vb08jN GyTGLWdC3/dRurzDFE0ONX/nvLoD3qxP/idC6x8jsZSAgFQfWeNDhoP6sTOUvrWKpZS+ EHHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Dr2Tb8xNL8Zd44BZpRkZWI6gE4U1QZUhIvG9zNQ9PsI=; b=k4HesusM6yhlO1QLpNYMu3g58ZiRk3uqkxGTzyNFKaZfPQVlavWAoJbD2RwM+TAZqz 8oOltKzCDvGvaMBx/jQ3meijXDjlrvv0arlS0N0jj3kevRF8c6xafvlq3jp/UTE+5+az Za7MTw+Lv4qacvOCG8mTnHaFhkx70zr1XCU3q020PT/5W1cbDDyAlq/KrwDNOdjrWJr8 PLFkfbRLkr75MyOvmB44MDb1ibLcki2J5/Pu1QJEU99gJTE9YuMVoizUvuYXqyzBYLFy iaSEL0R9sr3byjr7SSPO4OrIfUUZsMrlDngnfsuRxLCgxFUbnvCaWHiujcqoy2MU60QT 5j6Q== X-Gm-Message-State: AOAM531LHxm7nANe41MOhaYm7HQAtGKMMQzAsKG84rF+Q7Wq3ToznXb9 8FCZG8DK4ZFNwtrSKCB5XdEuF+Qh2kc= X-Google-Smtp-Source: ABdhPJx0T4FW5vY5u1CcVrgLb849G9GBkehpIIWB2wGYtYkUD+nzSAKb+0ckDVMOZMkooigwBd884Q== X-Received: by 2002:a05:651c:201b:: with SMTP id s27mr8503674ljo.468.1596478916403; Mon, 03 Aug 2020 11:21:56 -0700 (PDT) Received: from otyshchenko.www.tendawifi.com ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id h18sm4486730ljk.7.2020.08.03.11.21.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Aug 2020 11:21:55 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Subject: [RFC PATCH V1 11/12] libxl: Insert "dma-coherent" property into virtio-mmio device node Date: Mon, 3 Aug 2020 21:21:27 +0300 Message-Id: <1596478888-23030-12-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Ian Jackson , Oleksandr Tyshchenko , Anthony PERARD Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Oleksandr Tyshchenko Without "dma-coherent" property present in virtio-mmio device node, guest assumes it is non-coherent and making non-cacheable accesses to the vring when the DMA API is used for vring operations. But virtio-mmio device which runs at the host size is making cacheable accesses to vring. This all may result in a loss of coherency between the guest and host. With this patch we can avoid modifying guest at all, otherwise we need to force VirtIO framework to not use DMA API for vring operations. Signed-off-by: Oleksandr Tyshchenko --- tools/libxl/libxl_arm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/libxl/libxl_arm.c b/tools/libxl/libxl_arm.c index 469a8b0..a68fb14 100644 --- a/tools/libxl/libxl_arm.c +++ b/tools/libxl/libxl_arm.c @@ -726,6 +726,9 @@ static int make_virtio_mmio_node(libxl__gc *gc, void *fdt, res = fdt_property_interrupts(gc, fdt, &intr, 1); if (res) return res; + res = fdt_property(fdt, "dma-coherent", NULL, 0); + if (res) return res; + res = fdt_end_node(fdt); if (res) return res; -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 18:31:08 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 18:31:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2fEo-0001ZH-3F; Mon, 03 Aug 2020 18:31:06 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2f6f-0008F4-7x for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 18:22:41 +0000 X-Inumbo-ID: 3639dd59-d5b6-11ea-90c4-bc764e2007e4 Received: from mail-lf1-x141.google.com (unknown [2a00:1450:4864:20::141]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3639dd59-d5b6-11ea-90c4-bc764e2007e4; Mon, 03 Aug 2020 18:21:57 +0000 (UTC) Received: by mail-lf1-x141.google.com with SMTP id i19so20962415lfj.8 for ; Mon, 03 Aug 2020 11:21:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=NkBcm5wYA9ezMLwUACSNL6Lbpvri20JEcy5Q9KlbYZE=; b=KyMrgyuB0vbQO26N7CcvnLy46KtME50o0ONY/HeRJ7LbyZLMTbsYQMlSVGT3sHIEQe KVZmKTqQHeP5sd58b6wMc3S85WiffZs68k2n1ClhqJkWRHYoI/5XVaCW1Teh5gyvS6rn ru9rQpbPutAD/UIRWGEqgrWa1rPu8t80Y2PpI8evtVjZEDHcQDmQJ2xmLLEQ9gDt7lbc /LN6vQlv0M5/rO5qjt6FcwrG8eRelzvUxw4dDNy0Fw8vWmKZ3oTmANwQ6Ht91xB6Qv82 lR6qMTrXMSUXd3OFpwsyNwSkC4ttVDL8MNX1UOpQ3S7CrwIP2dis2wglngAqGdNSRyTH I2dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=NkBcm5wYA9ezMLwUACSNL6Lbpvri20JEcy5Q9KlbYZE=; b=Ot6RZaSxzDXLGcbmgu02DW1UkFHVw+samRlv8dcIPwY6kMdsuF5zn3bHuOt+ApOqnW VtLgCzPxKoR1lN/SfrUn6gMgSka+VusS3UDsC8k2xnmGhWq5bSj9K2mf1qhn8MGAzm6y UMEhL1HNShUfEh+kPj8a4Fkz1yAPp8sedE9HYIL86u1wYcBFLl5CgbJY+hHmG4Y3/LFG 7LIJ7dP5C4C+ikSMyvlkRSPP1RDNsP0yMJ85Rs/Ro1qy+TcVZE3FhcovORz1Mo9NPigf tXAz7bVGb0OY9PbCBLibhEUW+E8egFwpsjPSKhyUabeSAOVdW0HqnZplYyC/PlB7CPt5 KqDQ== X-Gm-Message-State: AOAM532iiTW22sCNx+jZ6zKI1dztZgmo95t7+tjFEwfBbAuGg2TSl+lK uRTBRDZLoU8udsq4QIPh/sMJjD7T6bk= X-Google-Smtp-Source: ABdhPJyp9uHQ58t0oc/zp8wFTCh7uSzb9x/yAKr05xdSMw0lknBbQ514w1T9sEJrygK7Hqn2hzLbSQ== X-Received: by 2002:a19:4f11:: with SMTP id d17mr9081461lfb.48.1596478915315; Mon, 03 Aug 2020 11:21:55 -0700 (PDT) Received: from otyshchenko.www.tendawifi.com ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id h18sm4486730ljk.7.2020.08.03.11.21.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Aug 2020 11:21:54 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Subject: [RFC PATCH V1 10/12] libxl: Add support for virtio-disk configuration Date: Mon, 3 Aug 2020 21:21:26 +0300 Message-Id: <1596478888-23030-11-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Ian Jackson , Oleksandr Tyshchenko , Anthony PERARD Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Oleksandr Tyshchenko This patch adds basic support for configuring and assisting virtio-disk backend (emualator) which is intended to run out of Qemu and could be run in any domain. Xenstore was chosen as a communication interface for the emulator running in non-toolstack domain to be able to get configuration either by reading Xenstore directly or by receiving command line parameters (an updated 'xl devd' running in the same domain would read Xenstore beforehand and call backend executable with the required arguments). An example of domain configuration (two disks are assigned to the guest, the latter is in readonly mode): vdisk = [ 'backend=DomD, disks=rw:/dev/mmcblk0p3;ro:/dev/mmcblk1p3' ] Where per-disk Xenstore entries are: - filename and readonly flag (configured via "vdisk" property) - base and irq (allocated dynamically) Besides handling 'visible' params described in configuration file, patch also allocates virtio-mmio specific ones for each device and writes them into Xenstore. virtio-mmio params (irq and base) are unique per guest domain, they allocated at the domain creation time and passed through to the emulator. Each VirtIO device has at least one pair of these params. TODO: 1. An extra "virtio" property could be removed. 2. Update documentation. Signed-off-by: Oleksandr Tyshchenko --- tools/libxl/Makefile | 4 +- tools/libxl/libxl_arm.c | 63 +++++++++++++++---- tools/libxl/libxl_create.c | 1 + tools/libxl/libxl_internal.h | 1 + tools/libxl/libxl_types.idl | 15 +++++ tools/libxl/libxl_types_internal.idl | 1 + tools/libxl/libxl_virtio_disk.c | 109 +++++++++++++++++++++++++++++++++ tools/xl/Makefile | 2 +- tools/xl/xl.h | 3 + tools/xl/xl_cmdtable.c | 15 +++++ tools/xl/xl_parse.c | 115 +++++++++++++++++++++++++++++++++++ tools/xl/xl_virtio_disk.c | 46 ++++++++++++++ 12 files changed, 360 insertions(+), 15 deletions(-) create mode 100644 tools/libxl/libxl_virtio_disk.c create mode 100644 tools/xl/xl_virtio_disk.c diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile index 38cd43a..df94b13 100644 --- a/tools/libxl/Makefile +++ b/tools/libxl/Makefile @@ -141,7 +141,9 @@ LIBXL_OBJS = flexarray.o libxl.o libxl_create.o libxl_dm.o libxl_pci.o \ libxl_vtpm.o libxl_nic.o libxl_disk.o libxl_console.o \ libxl_cpupool.o libxl_mem.o libxl_sched.o libxl_tmem.o \ libxl_9pfs.o libxl_domain.o libxl_vdispl.o \ - libxl_pvcalls.o libxl_vsnd.o libxl_vkb.o $(LIBXL_OBJS-y) + libxl_pvcalls.o libxl_vsnd.o libxl_vkb.o \ + libxl_virtio_disk.o $(LIBXL_OBJS-y) + LIBXL_OBJS += libxl_genid.o LIBXL_OBJS += _libxl_types.o libxl_flask.o _libxl_types_internal.o diff --git a/tools/libxl/libxl_arm.c b/tools/libxl/libxl_arm.c index 4f748e3..469a8b0 100644 --- a/tools/libxl/libxl_arm.c +++ b/tools/libxl/libxl_arm.c @@ -13,6 +13,12 @@ #define GUEST_VIRTIO_MMIO_SIZE xen_mk_ullong(0x200) #define GUEST_VIRTIO_MMIO_SPI 33 +#ifndef container_of +#define container_of(ptr, type, member) ({ \ + typeof( ((type *)0)->member ) *__mptr = (ptr); \ + (type *)( (char *)__mptr - offsetof(type,member) );}) +#endif + static const char *gicv_to_string(libxl_gic_version gic_version) { switch (gic_version) { @@ -44,14 +50,32 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, vuart_enabled = true; } - /* - * XXX: Handle properly virtio - * A proper solution would be the toolstack to allocate the interrupts - * used by each virtio backend and let the backend now which one is used - */ if (libxl_defbool_val(d_config->b_info.arch_arm.virtio)) { - nr_spis += (GUEST_VIRTIO_MMIO_SPI - 32) + 1; + uint64_t virtio_base; + libxl_device_virtio_disk *virtio_disk; + + virtio_base = GUEST_VIRTIO_MMIO_BASE; virtio_irq = GUEST_VIRTIO_MMIO_SPI; + + if (!d_config->num_virtio_disks) { + LOG(ERROR, "Virtio is enabled, but no Virtio devices present\n"); + return ERROR_FAIL; + } + virtio_disk = &d_config->virtio_disks[0]; + + for (i = 0; i < virtio_disk->num_disks; i++) { + virtio_disk->disks[i].base = virtio_base; + virtio_disk->disks[i].irq = virtio_irq; + + LOG(DEBUG, "Allocate Virtio MMIO params: IRQ %u BASE 0x%"PRIx64, + virtio_irq, virtio_base); + + virtio_irq ++; + virtio_base += GUEST_VIRTIO_MMIO_SIZE; + } + virtio_irq --; + + nr_spis += (virtio_irq - 32) + 1; virtio_enabled = true; } @@ -75,8 +99,9 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, } /* The same check as for vpl011 */ - if (virtio_enabled && irq == virtio_irq) { - LOG(ERROR, "Physical IRQ %u conflicting with virtio SPI\n", irq); + if (virtio_enabled && + (irq >= GUEST_VIRTIO_MMIO_SPI && irq <= virtio_irq)) { + LOG(ERROR, "Physical IRQ %u conflicting with Virtio IRQ range\n", irq); return ERROR_FAIL; } @@ -680,7 +705,8 @@ static int make_vpl011_uart_node(libxl__gc *gc, void *fdt, return 0; } -static int make_virtio_mmio_node(libxl__gc *gc, void *fdt) +static int make_virtio_mmio_node(libxl__gc *gc, void *fdt, + uint64_t base, uint32_t irq) { int res; gic_interrupt intr; @@ -693,10 +719,10 @@ static int make_virtio_mmio_node(libxl__gc *gc, void *fdt) if (res) return res; res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS, - 1, GUEST_VIRTIO_MMIO_BASE, GUEST_VIRTIO_MMIO_SIZE); + 1, base, GUEST_VIRTIO_MMIO_SIZE); if (res) return res; - set_interrupt(intr, GUEST_VIRTIO_MMIO_SPI, 0xf, DT_IRQ_TYPE_EDGE_RISING); + set_interrupt(intr, irq, 0xf, DT_IRQ_TYPE_EDGE_RISING); res = fdt_property_interrupts(gc, fdt, &intr, 1); if (res) return res; @@ -1010,8 +1036,19 @@ next_resize: if (info->tee == LIBXL_TEE_TYPE_OPTEE) FDT( make_optee_node(gc, fdt) ); - if (libxl_defbool_val(info->arch_arm.virtio)) - FDT( make_virtio_mmio_node(gc, fdt) ); + if (libxl_defbool_val(info->arch_arm.virtio)) { + libxl_domain_config *d_config = + container_of(info, libxl_domain_config, b_info); + libxl_device_virtio_disk *virtio_disk = &d_config->virtio_disks[0]; + unsigned int i; + + for (i = 0; i < virtio_disk->num_disks; i++) { + uint64_t base = virtio_disk->disks[i].base; + uint32_t irq = virtio_disk->disks[i].irq; + + FDT( make_virtio_mmio_node(gc, fdt, base, irq) ); + } + } if (pfdt) FDT( copy_partial_fdt(gc, fdt, pfdt) ); diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c index 2814818..8a0651e 100644 --- a/tools/libxl/libxl_create.c +++ b/tools/libxl/libxl_create.c @@ -1817,6 +1817,7 @@ const libxl__device_type *device_type_tbl[] = { &libxl__dtdev_devtype, &libxl__vdispl_devtype, &libxl__vsnd_devtype, + &libxl__virtio_disk_devtype, NULL }; diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h index 94a2317..4e2024d 100644 --- a/tools/libxl/libxl_internal.h +++ b/tools/libxl/libxl_internal.h @@ -3988,6 +3988,7 @@ extern const libxl__device_type libxl__vdispl_devtype; extern const libxl__device_type libxl__p9_devtype; extern const libxl__device_type libxl__pvcallsif_devtype; extern const libxl__device_type libxl__vsnd_devtype; +extern const libxl__device_type libxl__virtio_disk_devtype; extern const libxl__device_type *device_type_tbl[]; diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl index b054bf9..5f8a3ff 100644 --- a/tools/libxl/libxl_types.idl +++ b/tools/libxl/libxl_types.idl @@ -935,6 +935,20 @@ libxl_device_vsnd = Struct("device_vsnd", [ ("pcms", Array(libxl_vsnd_pcm, "num_vsnd_pcms")) ]) +libxl_virtio_disk_param = Struct("virtio_disk_param", [ + ("filename", string), + ("readonly", bool), + ("irq", uint32), + ("base", uint64), + ]) + +libxl_device_virtio_disk = Struct("device_virtio_disk", [ + ("backend_domid", libxl_domid), + ("backend_domname", string), + ("devid", libxl_devid), + ("disks", Array(libxl_virtio_disk_param, "num_disks")), + ]) + libxl_domain_config = Struct("domain_config", [ ("c_info", libxl_domain_create_info), ("b_info", libxl_domain_build_info), @@ -951,6 +965,7 @@ libxl_domain_config = Struct("domain_config", [ ("pvcallsifs", Array(libxl_device_pvcallsif, "num_pvcallsifs")), ("vdispls", Array(libxl_device_vdispl, "num_vdispls")), ("vsnds", Array(libxl_device_vsnd, "num_vsnds")), + ("virtio_disks", Array(libxl_device_virtio_disk, "num_virtio_disks")), # a channel manifests as a console with a name, # see docs/misc/channels.txt ("channels", Array(libxl_device_channel, "num_channels")), diff --git a/tools/libxl/libxl_types_internal.idl b/tools/libxl/libxl_types_internal.idl index 3593e21..8f71980 100644 --- a/tools/libxl/libxl_types_internal.idl +++ b/tools/libxl/libxl_types_internal.idl @@ -32,6 +32,7 @@ libxl__device_kind = Enumeration("device_kind", [ (14, "PVCALLS"), (15, "VSND"), (16, "VINPUT"), + (17, "VIRTIO_DISK"), ]) libxl__console_backend = Enumeration("console_backend", [ diff --git a/tools/libxl/libxl_virtio_disk.c b/tools/libxl/libxl_virtio_disk.c new file mode 100644 index 0000000..25e7f1a --- /dev/null +++ b/tools/libxl/libxl_virtio_disk.c @@ -0,0 +1,109 @@ +/* + * Copyright (C) 2020 EPAM Systems Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published + * by the Free Software Foundation; version 2.1 only. with the special + * exception on linking described in file LICENSE. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + */ + +#include "libxl_internal.h" + +static int libxl__device_virtio_disk_setdefault(libxl__gc *gc, uint32_t domid, + libxl_device_virtio_disk *virtio_disk, + bool hotplug) +{ + return libxl__resolve_domid(gc, virtio_disk->backend_domname, + &virtio_disk->backend_domid); +} + +static int libxl__virtio_disk_from_xenstore(libxl__gc *gc, const char *libxl_path, + libxl_devid devid, + libxl_device_virtio_disk *virtio_disk) +{ + const char *be_path; + int rc; + + virtio_disk->devid = devid; + rc = libxl__xs_read_mandatory(gc, XBT_NULL, + GCSPRINTF("%s/backend", libxl_path), + &be_path); + if (rc) return rc; + + rc = libxl__backendpath_parse_domid(gc, be_path, &virtio_disk->backend_domid); + if (rc) return rc; + + return 0; +} + +static void libxl__update_config_virtio_disk(libxl__gc *gc, + libxl_device_virtio_disk *dst, + libxl_device_virtio_disk *src) +{ + dst->devid = src->devid; +} + +static int libxl_device_virtio_disk_compare(libxl_device_virtio_disk *d1, + libxl_device_virtio_disk *d2) +{ + return COMPARE_DEVID(d1, d2); +} + +static void libxl__device_virtio_disk_add(libxl__egc *egc, uint32_t domid, + libxl_device_virtio_disk *virtio_disk, + libxl__ao_device *aodev) +{ + libxl__device_add_async(egc, domid, &libxl__virtio_disk_devtype, virtio_disk, aodev); +} + +static int libxl__set_xenstore_virtio_disk(libxl__gc *gc, uint32_t domid, + libxl_device_virtio_disk *virtio_disk, + flexarray_t *back, flexarray_t *front, + flexarray_t *ro_front) +{ + int rc; + unsigned int i; + + for (i = 0; i < virtio_disk->num_disks; i++) { + rc = flexarray_append_pair(ro_front, GCSPRINTF("%d/filename", i), + GCSPRINTF("%s", virtio_disk->disks[i].filename)); + if (rc) return rc; + + rc = flexarray_append_pair(ro_front, GCSPRINTF("%d/readonly", i), + GCSPRINTF("%d", virtio_disk->disks[i].readonly)); + if (rc) return rc; + + rc = flexarray_append_pair(ro_front, GCSPRINTF("%d/base", i), + GCSPRINTF("%lu", virtio_disk->disks[i].base)); + if (rc) return rc; + + rc = flexarray_append_pair(ro_front, GCSPRINTF("%d/irq", i), + GCSPRINTF("%u", virtio_disk->disks[i].irq)); + if (rc) return rc; + } + + return 0; +} + +static LIBXL_DEFINE_UPDATE_DEVID(virtio_disk) +static LIBXL_DEFINE_DEVICE_FROM_TYPE(virtio_disk) +static LIBXL_DEFINE_DEVICES_ADD(virtio_disk) + +DEFINE_DEVICE_TYPE_STRUCT(virtio_disk, VIRTIO_DISK, + .update_config = (device_update_config_fn_t) libxl__update_config_virtio_disk, + .from_xenstore = (device_from_xenstore_fn_t) libxl__virtio_disk_from_xenstore, + .set_xenstore_config = (device_set_xenstore_config_fn_t) libxl__set_xenstore_virtio_disk +); + +/* + * Local variables: + * mode: C + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/tools/xl/Makefile b/tools/xl/Makefile index af4912e..38e4701 100644 --- a/tools/xl/Makefile +++ b/tools/xl/Makefile @@ -22,7 +22,7 @@ XL_OBJS += xl_vtpm.o xl_block.o xl_nic.o xl_usb.o XL_OBJS += xl_sched.o xl_pci.o xl_vcpu.o xl_cdrom.o xl_mem.o XL_OBJS += xl_info.o xl_console.o xl_misc.o XL_OBJS += xl_vmcontrol.o xl_saverestore.o xl_migrate.o -XL_OBJS += xl_vdispl.o xl_vsnd.o xl_vkb.o +XL_OBJS += xl_vdispl.o xl_vsnd.o xl_vkb.o xl_virtio_disk.o $(XL_OBJS): CFLAGS += $(CFLAGS_libxentoollog) $(XL_OBJS): CFLAGS += $(CFLAGS_XL) diff --git a/tools/xl/xl.h b/tools/xl/xl.h index 06569c6..3d26f19 100644 --- a/tools/xl/xl.h +++ b/tools/xl/xl.h @@ -178,6 +178,9 @@ int main_vsnddetach(int argc, char **argv); int main_vkbattach(int argc, char **argv); int main_vkblist(int argc, char **argv); int main_vkbdetach(int argc, char **argv); +int main_virtio_diskattach(int argc, char **argv); +int main_virtio_disklist(int argc, char **argv); +int main_virtio_diskdetach(int argc, char **argv); int main_usbctrl_attach(int argc, char **argv); int main_usbctrl_detach(int argc, char **argv); int main_usbdev_attach(int argc, char **argv); diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c index 0833539..2bdf0b7 100644 --- a/tools/xl/xl_cmdtable.c +++ b/tools/xl/xl_cmdtable.c @@ -434,6 +434,21 @@ struct cmd_spec cmd_table[] = { "Destroy a domain's virtual sound device", " ", }, + { "virtio-disk-attach", + &main_virtio_diskattach, 1, 1, + "Create a new virtio block device", + " TBD\n" + }, + { "virtio-disk-list", + &main_virtio_disklist, 0, 0, + "List virtio block devices for a domain", + "", + }, + { "virtio-disk-detach", + &main_virtio_diskdetach, 0, 1, + "Destroy a domain's virtio block device", + " ", + }, { "uptime", &main_uptime, 0, 0, "Print uptime for all/some domains", diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index b8306aa..fd72109 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -1202,6 +1202,120 @@ out: if (rc) exit(EXIT_FAILURE); } +#define MAX_VIRTIO_DISKS 4 + +static int parse_virtio_disk_config(libxl_device_virtio_disk *virtio_disk, char *token) +{ + char *oparg; + libxl_string_list disks = NULL; + int i, rc; + + if (MATCH_OPTION("backend", token, oparg)) { + virtio_disk->backend_domname = strdup(oparg); + } else if (MATCH_OPTION("disks", token, oparg)) { + split_string_into_string_list(oparg, ";", &disks); + + virtio_disk->num_disks = libxl_string_list_length(&disks); + if (virtio_disk->num_disks > MAX_VIRTIO_DISKS) { + fprintf(stderr, "vdisk: currently only %d disks are supported", + MAX_VIRTIO_DISKS); + return 1; + } + virtio_disk->disks = xcalloc(virtio_disk->num_disks, + sizeof(*virtio_disk->disks)); + + for(i = 0; i < virtio_disk->num_disks; i++) { + char *disk_opt; + + rc = split_string_into_pair(disks[i], ":", &disk_opt, + &virtio_disk->disks[i].filename); + if (rc) { + fprintf(stderr, "vdisk: failed to split \"%s\" into pair\n", + disks[i]); + goto out; + } + + if (!strcmp(disk_opt, "ro")) + virtio_disk->disks[i].readonly = 1; + else if (!strcmp(disk_opt, "rw")) + virtio_disk->disks[i].readonly = 0; + else { + fprintf(stderr, "vdisk: failed to parse \"%s\" disk option\n", + disk_opt); + rc = 1; + } + free(disk_opt); + + if (rc) goto out; + } + } else { + fprintf(stderr, "Unknown string \"%s\" in vdisk spec\n", token); + rc = 1; goto out; + } + + rc = 0; + +out: + libxl_string_list_dispose(&disks); + return rc; +} + +static void parse_virtio_disk_list(const XLU_Config *config, + libxl_domain_config *d_config) +{ + XLU_ConfigList *virtio_disks; + const char *item; + char *buf = NULL; + int rc; + + if (!xlu_cfg_get_list (config, "vdisk", &virtio_disks, 0, 0)) { + libxl_domain_build_info *b_info = &d_config->b_info; + int entry = 0; + + /* XXX Remove an extra property */ + libxl_defbool_setdefault(&b_info->arch_arm.virtio, false); + if (!libxl_defbool_val(b_info->arch_arm.virtio)) { + fprintf(stderr, "Virtio device requires Virtio property to be set\n"); + exit(EXIT_FAILURE); + } + + while ((item = xlu_cfg_get_listitem(virtio_disks, entry)) != NULL) { + libxl_device_virtio_disk *virtio_disk; + char *p; + + virtio_disk = ARRAY_EXTEND_INIT(d_config->virtio_disks, + d_config->num_virtio_disks, + libxl_device_virtio_disk_init); + + buf = strdup(item); + + p = strtok (buf, ","); + while (p != NULL) + { + while (*p == ' ') p++; + + rc = parse_virtio_disk_config(virtio_disk, p); + if (rc) goto out; + + p = strtok (NULL, ","); + } + + entry++; + + if (virtio_disk->num_disks == 0) { + fprintf(stderr, "At least one virtio disk should be specified\n"); + rc = 1; goto out; + } + } + } + + rc = 0; + +out: + free(buf); + if (rc) exit(EXIT_FAILURE); +} + void parse_config_data(const char *config_source, const char *config_data, int config_len, @@ -2732,6 +2846,7 @@ skip_usbdev: } parse_vkb_list(config, d_config); + parse_virtio_disk_list(config, d_config); xlu_cfg_get_defbool(config, "xend_suspend_evtchn_compat", &c_info->xend_suspend_evtchn_compat, 0); diff --git a/tools/xl/xl_virtio_disk.c b/tools/xl/xl_virtio_disk.c new file mode 100644 index 0000000..808a7da --- /dev/null +++ b/tools/xl/xl_virtio_disk.c @@ -0,0 +1,46 @@ +/* + * Copyright (C) 2020 EPAM Systems Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published + * by the Free Software Foundation; version 2.1 only. with the special + * exception on linking described in file LICENSE. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + */ + +#include + +#include +#include +#include + +#include "xl.h" +#include "xl_utils.h" +#include "xl_parse.h" + +int main_virtio_diskattach(int argc, char **argv) +{ + return 0; +} + +int main_virtio_disklist(int argc, char **argv) +{ + return 0; +} + +int main_virtio_diskdetach(int argc, char **argv) +{ + return 0; +} + +/* + * Local variables: + * mode: C + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 18:31:08 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 18:31:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2fEn-0001Z5-Js; Mon, 03 Aug 2020 18:31:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2f6k-0008F4-8O for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 18:22:46 +0000 X-Inumbo-ID: 377cf859-d5b6-11ea-90c4-bc764e2007e4 Received: from mail-lf1-x144.google.com (unknown [2a00:1450:4864:20::144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 377cf859-d5b6-11ea-90c4-bc764e2007e4; Mon, 03 Aug 2020 18:21:58 +0000 (UTC) Received: by mail-lf1-x144.google.com with SMTP id m15so20303516lfp.7 for ; Mon, 03 Aug 2020 11:21:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=1DZeLDeQLAW3wDtg4nsTIUzMiSJtyCyrnnqQeeQIfZc=; b=l5r/G7XizMtl4Jo6THLgp7+OQ05dU8uylAR5kvt92eMz9hNK9Wx9iJfWx1sOkeXew/ dDdjL8kxdVKO/5J/ePv2UXhqUvgsMh92fR2c8HAexuAQ7HwpD5cM3l1R+bG+WidbLDQF a+2b7FLpvBsZl4fYu4Pzb41NLeN2NrwTjfDvaWlZ8vaBkSthTZNZodBHuO/vxcGDIRaP 9ZwEtQYArHZvgwpAkrLFip40/rvpfJvmuceHnh4u/ceo0ASjfq/4jQh0AvZis+PktZt1 3i5tnB0Y89SS1+fRHFdv8sw30HZoBCEh5KnE9XCYEMMBdwfkJOyy6wF+tY/bMqnoy9L6 1b9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=1DZeLDeQLAW3wDtg4nsTIUzMiSJtyCyrnnqQeeQIfZc=; b=cLLPGX9hryIFtHJyeyAvpiVU2hCuNQZPNeEFbI4K0Ydo7SjKSghdLa+n6VaQqFTxYt 4cJotnvCiQNprB9bI1R/osUVRXc/8SnbLWALq4jIM4y5FbSakJjJRCyDlrzNWtNwn6bY OeCzW+NDmWbN0uFOT08Y9XDS3HIfiRlqIsppkC0bW1h/qnOt2LzUi231WaUFHvoVD4hB wQpP6xLyCvOHaUWVFPqRNAiuao1hGDABLNVtGrWeipwWlhm55xgcTodwiTcFS/4pvKGH ePthIijfwYcaBlIj9crynQJojQB2vqpDITtN8yAd0eSWQjiQf1/mW+y7nnNylAAK/SeZ cd4w== X-Gm-Message-State: AOAM531JOnCLJOL448rqK6w2cn+k/A1XvKTNMFGHLGqXh0bnvAXQG1vn vVC5Y8ZLdmbP+pQdfcEyEOTk5hSzR4g= X-Google-Smtp-Source: ABdhPJytiiD7l56b7Vm/NaSQXoaXOLDxnIvoSE8ZvLGZHZEUatUZoCFu/Kmqn5PTbDoeaT2KzUFD3A== X-Received: by 2002:ac2:598f:: with SMTP id w15mr9054121lfn.216.1596478917357; Mon, 03 Aug 2020 11:21:57 -0700 (PDT) Received: from otyshchenko.www.tendawifi.com ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id h18sm4486730ljk.7.2020.08.03.11.21.56 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Aug 2020 11:21:56 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Subject: [RFC PATCH V1 12/12] libxl: Fix duplicate memory node in DT Date: Mon, 3 Aug 2020 21:21:28 +0300 Message-Id: <1596478888-23030-13-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Ian Jackson , Oleksandr Tyshchenko , Anthony PERARD Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Oleksandr Tyshchenko When two or more VirtIO devices are passed to DomU the following message is observed: OF: Duplicate name in base, renamed to "virtio#1" Signed-off-by: Oleksandr Tyshchenko --- tools/libxl/libxl_arm.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl_arm.c b/tools/libxl/libxl_arm.c index a68fb14..9671a44 100644 --- a/tools/libxl/libxl_arm.c +++ b/tools/libxl/libxl_arm.c @@ -710,9 +710,11 @@ static int make_virtio_mmio_node(libxl__gc *gc, void *fdt, { int res; gic_interrupt intr; + /* Placeholder for virtio@ + a 64-bit number + \0 */ + char buf[24]; - /* XXX: Add address in the node name */ - res = fdt_begin_node(fdt, "virtio"); + snprintf(buf, sizeof(buf), "virtio@%"PRIx64, base); + res = fdt_begin_node(fdt, buf); if (res) return res; res = fdt_property_compat(gc, fdt, 1, "virtio,mmio"); -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 18:33:26 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2020 18:33:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2fH1-0001t4-Ku; Mon, 03 Aug 2020 18:33:23 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2fH0-0001su-QQ for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 18:33:22 +0000 X-Inumbo-ID: cf10efa2-d5b7-11ea-90c7-bc764e2007e4 Received: from mail-oi1-x233.google.com (unknown [2607:f8b0:4864:20::233]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cf10efa2-d5b7-11ea-90c7-bc764e2007e4; Mon, 03 Aug 2020 18:33:21 +0000 (UTC) Received: by mail-oi1-x233.google.com with SMTP id u24so24231644oiv.7 for ; Mon, 03 Aug 2020 11:33:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=tOj98KWxZfo7k/msteoXOzG655QSkI9RWTBbZ2s3YRY=; b=y6oM0HuwhNOMHv3CswCjVXigw95CYKCpxWHCggL8OoQcJxkeRNg5xNgVFZVuTHJtBY VKkSC2Ccj0FUCS6t6LXUsSCAx1vUsWEglUkfIyKR4Ga7GWYIJLf99ebsMsEH51vWT4Ho 93jG8A0FX96zCtfWEG5lE90T5hkdeVnuuMn3Gfy0RewfCgOF64kg5QMkVjZjCde5S+0g /08gtE0Pc5ovCteqftn3ITAT5KAc9aY3NYcgtW5dw6AKFcj2hd/GSDJjrvskWQWPijY8 SmPTw4J0HNsDeydm1xgIt9NSu+OuG8LILxr06BEKqRzHSjpKA9Xg7rMiL9uxzM3K+Dll KICA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=tOj98KWxZfo7k/msteoXOzG655QSkI9RWTBbZ2s3YRY=; b=hCakJP99OoxAAbj6cHYsuOc0lq9eOOM+G7RopDD0Q90bQoR2pVNQOOl1wxUxEOyhNK r9r9DZ+xkmkrGiagPm8NyiZ8X07tYf5KpJYf8LR7Inruie2V7yTRU3pRkrVqRzre385P JQNGiln7Zes5a3iIwS4rbcCXb1a40l9EcN9B7BU/lTsL6ApaEdvjBdCQw+cZWpq7e6U7 MfZuYeXKAC4QKvNVBclTEYTKOEztMgPfq5DcFXkhzH3feTS4vGhSxh7mA8cMUKPY49gC BbWiqYC/XVubFcdKhjUsb8ixQQ4LknM+VLmmv60KOSJcdTt0LlU8DGUftafUV67oGqvo 3yyg== X-Gm-Message-State: AOAM5314eZLTBQ+R4z+islAiIwX6/bNnUHu7cyIpVmMbweNJZWW7gqKO M0Rqc0l1nXvUnbRCgMHwvAUq8+LDQhnqv67MnejV8g== X-Google-Smtp-Source: ABdhPJykw6QlTCz5UZlKQ6UvLdnZmhQqKuAQH/eDVsm1AFm/IR10na8Eavap0iKbcegmHSN7XTnjydq+nvN4QSaJRgQ= X-Received: by 2002:aca:50c4:: with SMTP id e187mr553874oib.146.1596479601455; Mon, 03 Aug 2020 11:33:21 -0700 (PDT) MIME-Version: 1.0 References: <20200803165251.907213-1-anthony.perard@citrix.com> In-Reply-To: <20200803165251.907213-1-anthony.perard@citrix.com> From: Peter Maydell Date: Mon, 3 Aug 2020 19:33:10 +0100 Message-ID: Subject: Re: [PULL 0/1] xen queue 2020-08-03 To: Anthony PERARD , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "open list:X86" , QEMU Developers Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Mon, 3 Aug 2020 at 17:53, Anthony PERARD wro= te: > ---------------------------------------------------------------- > xen patches > > bug fix > > ---------------------------------------------------------------- > Philippe Mathieu-Daud=C3=A9 (1): > accel/xen: Fix xen_enabled() behavior on target-agnostic objects This fails to compile, all hosts :-( LINK avr-softmmu/qemu-system-avr ../migration/savevm.o: In function `qemu_loadvm_section_start_full': /home/petmay01/linaro/qemu-for-merges/migration/savevm.c:2320: undefined reference to `xen_enabled' collect2: error: ld returned 1 exit status [ditto other softmmu link attempts] Similar but different on OSX: LINK aarch64-softmmu/qemu-system-aarch64 Undefined symbols for architecture x86_64: "_xen_enabled", referenced from: _msix_is_masked in msix.o _msix_write_config in msix.o _msix_handle_mask_update in msix.o _msix_init in msix.o _msix_notify in msix.o _msix_reset in msix.o _msix_set_vector_notifiers in msix.o ... ld: symbol(s) not found for architecture x86_64 Fails in all the BSD VM builds as well, so I don't think this is related to incremental vs from-clean builds. I think the failure here is only on builds where CONFIG_XEN is not set by configure (which for my merge build setup appears to be all of them, I think). In that case when we build a target-agnostic object it gets an external reference to the xen_enabled() function, but because Xen is disabled we don't compile accel/xen/ and so there is no actual implementation of the function in the link. This doesn't happen for KVM because there the CONFIG_KVM_IS_POSSIBLE version of kvm_enabled() is a #define: #define kvm_enabled() (kvm_allowed) and we provide both the "real" version of the 'bool kvm_allowed' in accel/kvm/kvm-all.c and also the stub version in accel/stubs/kvm-stub.c which will be used in configurations thta don't build accel/kvm. I think then that the fix for this build failure is to either: (1) add a stub version of xen_allowed() to accel/stubs/xen-stub.c (which would always return false) (2) follow KVM more closely, and have xen_allowed() be a #define to (xen_allowed), with a (non-static) bool xen_allowed in accel/xen/xen-all.c and another one in accel/stubs/xen-stub.c thanks -- PMM From xen-devel-bounces@lists.xenproject.org Tue Aug 04 04:59:45 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 04:59:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2p2x-0001OB-UR; Tue, 04 Aug 2020 04:59:31 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2p2w-0001O5-RX for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 04:59:30 +0000 X-Inumbo-ID: 4414c2cc-d60f-11ea-b007-12813bfff9fa Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4414c2cc-d60f-11ea-b007-12813bfff9fa; Tue, 04 Aug 2020 04:59:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=XtVzeZ42mEWBr1C3cZImKZDDDlK2qxl3ZVE9XlrhNkw=; b=nCCyMOTtch8lDS6+5YGrqtyZk ioayPyR7uzVqb3S70P2FyOwmt5U/7uQefJ4SSw37cdZOb6irMcdJO2iw71olqv5uX9d1B8gwTluiV YiOxmHg0mUd1QCmLUir/ju38JsK6WD6o60pS2Jtf3kw8MgxNAxSloINs1q5grJmV2gmgI=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2p2p-0003xD-JI; Tue, 04 Aug 2020 04:59:23 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k2p2p-0003jG-4Q; Tue, 04 Aug 2020 04:59:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k2p2p-0001SC-3m; Tue, 04 Aug 2020 04:59:23 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 152411: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-qemuu-nested-intel:xen-boot/l1:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-amd:xen-boot/l1:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:windows-install:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:windows-install:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:windows-install:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:windows-install:fail:regression qemu-mainline:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug qemu-mainline:test-arm64-arm64-xl-credit2:xen-boot:fail:heisenbug qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=d74824cf7c8b352f9045e949dc636c7207a41eee X-Osstest-Versions-That: qemuu=9e3903136d9acde2fb2dd9e967ba928050a6cb4a From: osstest service owner Date: Tue, 04 Aug 2020 04:59:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152411 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/152411/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 14 xen-boot/l1 fail REGR. vs. 151065 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 10 debian-hvm-install fail REGR. vs. 151065 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 10 debian-hvm-install fail REGR. vs. 151065 test-amd64-amd64-qemuu-nested-amd 14 xen-boot/l1 fail REGR. vs. 151065 test-amd64-amd64-xl-qemuu-win7-amd64 10 windows-install fail REGR. vs. 151065 test-amd64-amd64-xl-qemuu-ws16-amd64 10 windows-install fail REGR. vs. 151065 test-amd64-i386-xl-qemuu-ws16-amd64 10 windows-install fail REGR. vs. 151065 test-amd64-i386-xl-qemuu-win7-amd64 10 windows-install fail REGR. vs. 151065 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-rtds 18 guest-localmigrate/x10 fail pass in 152337 test-arm64-arm64-xl-credit2 7 xen-boot fail pass in 152380 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-credit2 13 migrate-support-check fail in 152337 never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail in 152337 never pass test-armhf-armhf-libvirt 14 saverestore-support-check fail like 151065 test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail like 151065 test-armhf-armhf-xl-rtds 16 guest-start/debian.repeat fail like 151065 test-amd64-i386-xl-pvshim 12 guest-start fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass version targeted for testing: qemuu d74824cf7c8b352f9045e949dc636c7207a41eee baseline version: qemuu 9e3903136d9acde2fb2dd9e967ba928050a6cb4a Last test of basis 151065 2020-06-12 22:27:51 Z 52 days Failing since 151101 2020-06-14 08:32:51 Z 50 days 70 attempts Testing same since 152337 2020-08-01 01:13:57 Z 3 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Aaron Lindsay Ahmed Karaman Alberto Garcia Aleksandar Markovic Aleksandar Markovic Alex Bennée Alex Richardson Alex Williamson Alexander Boettcher Alexander Bulekov Alexander Duyck Alexandre Mergnat Alexey Kardashevskiy Alexey Krasikov Alistair Francis Allan Peramaki Andreas Schwab Andrew Andrew Jones Andrew Melnychenko Andrey Shinkevich Ani Sinha Anthony PERARD Antoine Damhet Ard Biesheuvel Artyom Tarasenko Atish Patra Aurelien Jarno Babu Moger BALATON Zoltan Basil Salman Basil Salman Beata Michalska Bin Meng Bin Meng Bruce Rogers Cameron Esfahani Catherine A. Frederick Cathy Zhang Chen Gang Chenyi Qiang Christian Borntraeger Christian Ehrhardt Christophe de Dinechin Chuan Zheng Cindy Lu Claudio Fontana Cleber Rosa Colin Xu Corey Minyard Cornelia Huck Cédric Le Goater Daniel P. Berrange Daniel P. Berrangé Daniele Buono David Carlier David Edmondson David Gibson David Hildenbrand Denis V. Lunev Derek Su Dongjiu Geng Dr. David Alan Gilbert Ed Robbins Edgar E. Iglesias Eduardo Habkost Emilio G. Cota Eric Auger Eric Blake Eric Farman Erik Smit erik-smit Evgeny Yakovlev fangying Farhan Ali Filip Bozuta Finn Thain Frank Chang Geoffrey McRae Gerd Hoffmann Giuseppe Musacchio Greg Kurz Guenter Roeck Gustavo Romero Halil Pasic Havard Skinnemoen Helge Deller Hogan Wang Hogan Wang Howard Spoelstra Huacai Chen Huacai Chen Ian Jiang Igor Mammedov Jan Kiszka Jan Kiszka Janne Grunau Janosch Frank Jason Andryuk Jason Wang Jay Zhou Jean-Christophe Dubois Jessica Clarke Jiaxun Yang Jingqi Liu John Paul Adrian Glaubitz John Snow Jon Doron Joseph Myers Josh DuBois Josh DuBois Josh Kunz Juan Quintela Julio Faracco Keqian Zhu Kevin Wolf Klaus Jensen Klaus Jensen KONRAD Frederic Laszlo Ersek Laurent Vivier Laurent Vivier Leif Lindholm Leonid Bloch Leonid Bloch Li Feng Li Qiang Li Qiang Liao Pingfang lichun Lijun Pan Like Xu Lingfeng Yang Lingshan zhu Liran Alon Liu Yi L LIU Zhiwei Luc Michel Lukas Straub Luwei Kang Maciej S. Szmigiero Magnus Damm Mao Zhongyi Marc-André Lureau Marcelo Tosatti Marek Marczykowski-Górecki Mario Smarduch Mark Cave-Ayland Markus Armbruster Masahiro Yamada Matus Kysel Mauro Matteo Cascella Max Filippov Max Reitz Maxim Levitsky Maxime Coquelin Menno Lageman Michael Rolnik Michael Roth Michael S. Tsirkin Michael Tokarev Michal Privoznik Michele Denber Niek Linnenbank Nir Soffer Nir Soffer Olaf Hering Pan Nengyuan Paolo Bonzini Paul Durrant Paul Zimmerman Pavel Dovgalyuk Pavel Dovgalyuk Peter Maydell Peter Turschmid Peter Xu Philippe Mathieu-Daude Philippe Mathieu-Daudé Philippe Mathieu-Daudé Prasad J Pandit Radoslaw Biernacki Raphael Norwitz Reza Arbab Richard Henderson Richard W.M. Jones Riku Voipio Robert Foley Roman Bolshakov Roman Kagan Roman Kagan Sai Pavan Boddu Sarah Harris Sebastian Rasmussen Sergio Lopez Shameer Kolothum Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Weil Sven Schnelle Tao Xu Thomas Huth Thomas Huth Tiwei Bie Tong Ho Viktor Mihajlovski Vitaly Kuznetsov Vivek Goyal Vladimir Sementsov-Ogievskiy Volker Rümelin WangBowen Wei Huang Wei Wang Wentong Wu Xiaoyao Li Xie Yongji Yi Wang Ying Fang Yoshinori Sato Yuri Benditovich Zhang Chen Zheng Chuan Zong Li jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 34403 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Aug 04 05:34:25 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 05:34:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2paN-0004zy-Pj; Tue, 04 Aug 2020 05:34:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2paM-0004zt-C9 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 05:34:02 +0000 X-Inumbo-ID: 19adee5a-d614-11ea-9126-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 19adee5a-d614-11ea-9126-bc764e2007e4; Tue, 04 Aug 2020 05:34:01 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 04B0AACB5; Tue, 4 Aug 2020 05:34:16 +0000 (UTC) Subject: Re: [PATCH v3 08/11] swiotlb-xen: remove XEN_PFN_PHYS To: Stefano Stabellini , boris.ostrovsky@oracle.com, konrad.wilk@oracle.com References: <20200710223427.6897-8-sstabellini@kernel.org> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <6a96e4a3-295c-8974-6d4e-16aadc7c8ce7@suse.com> Date: Tue, 4 Aug 2020 07:33:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200710223427.6897-8-sstabellini@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: hch@infradead.org, xen-devel@lists.xenproject.org, Stefano Stabellini , linux-kernel@vger.kernel.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 11.07.20 00:34, Stefano Stabellini wrote: > From: Stefano Stabellini > > XEN_PFN_PHYS is only used in one place in swiotlb-xen making things more > complex than need to be. > > Remove the definition of XEN_PFN_PHYS and open code the cast in the one > place where it is needed. > > Signed-off-by: Stefano Stabellini Reviewed-by: Juergen Gross Juergen From xen-devel-bounces@lists.xenproject.org Tue Aug 04 05:34:33 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 05:34:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2par-00053F-24; Tue, 04 Aug 2020 05:34:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2pap-000537-9R for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 05:34:31 +0000 X-Inumbo-ID: 2b18188e-d614-11ea-9126-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2b18188e-d614-11ea-9126-bc764e2007e4; Tue, 04 Aug 2020 05:34:30 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7A2D4ACB5; Tue, 4 Aug 2020 05:34:45 +0000 (UTC) Subject: Re: [PATCH v3 09/11] swiotlb-xen: introduce phys_to_dma/dma_to_phys translations To: Stefano Stabellini , boris.ostrovsky@oracle.com, konrad.wilk@oracle.com References: <20200710223427.6897-9-sstabellini@kernel.org> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <2f68bb03-60b6-44d6-b9cd-d21ef20a4a68@suse.com> Date: Tue, 4 Aug 2020 07:34:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200710223427.6897-9-sstabellini@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: hch@infradead.org, xen-devel@lists.xenproject.org, Stefano Stabellini , linux-kernel@vger.kernel.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 11.07.20 00:34, Stefano Stabellini wrote: > From: Stefano Stabellini > > With some devices physical addresses are different than dma addresses. > To be able to deal with these cases, we need to call phys_to_dma on > physical addresses (including machine addresses in Xen terminology) > before returning them from xen_swiotlb_alloc_coherent and > xen_swiotlb_map_page. > > We also need to convert dma addresses back to physical addresses using > dma_to_phys in xen_swiotlb_free_coherent and xen_swiotlb_unmap_page if > we want to do any operations on them. > > Call dma_to_phys in is_xen_swiotlb_buffer. > Introduce xen_phys_to_dma and call phys_to_dma in its implementation. > Introduce xen_dma_to_phys and call dma_to_phys in its implementation. > Call xen_phys_to_dma/xen_dma_to_phys instead of > xen_phys_to_bus/xen_bus_to_phys through swiotlb-xen.c. > > Everything is taken care of by these changes except for > xen_swiotlb_alloc_coherent and xen_swiotlb_free_coherent, which need a > few explicit phys_to_dma/dma_to_phys calls. > > Signed-off-by: Stefano Stabellini > Tested-by: Corey Minyard > Tested-by: Roman Shaposhnik Reviewed-by: Juergen Gross Juergen From xen-devel-bounces@lists.xenproject.org Tue Aug 04 05:35:35 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 05:35:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2pbr-00059i-Cz; Tue, 04 Aug 2020 05:35:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2pbq-00059d-Rc for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 05:35:34 +0000 X-Inumbo-ID: 5119d8e0-d614-11ea-9126-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5119d8e0-d614-11ea-9126-bc764e2007e4; Tue, 04 Aug 2020 05:35:34 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 12673ACB5; Tue, 4 Aug 2020 05:35:49 +0000 (UTC) Subject: Re: [PATCH v3 10/11] xen/arm: introduce phys/dma translations in xen_dma_sync_for_* To: Stefano Stabellini , boris.ostrovsky@oracle.com, konrad.wilk@oracle.com References: <20200710223427.6897-10-sstabellini@kernel.org> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <68f244b5-86e7-4c94-7a22-f9ca53311857@suse.com> Date: Tue, 4 Aug 2020 07:35:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200710223427.6897-10-sstabellini@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: hch@infradead.org, xen-devel@lists.xenproject.org, Stefano Stabellini , linux-kernel@vger.kernel.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 11.07.20 00:34, Stefano Stabellini wrote: > From: Stefano Stabellini > > xen_dma_sync_for_cpu, xen_dma_sync_for_device, xen_arch_need_swiotlb are > getting called passing dma addresses. On some platforms dma addresses > could be different from physical addresses. Before doing any operations > on these addresses we need to convert them back to physical addresses > using dma_to_phys. > > Move the arch_sync_dma_for_cpu and arch_sync_dma_for_device calls from > xen_dma_sync_for_cpu/device to swiotlb-xen.c, and add a call dma_to_phys > to do address translations there. > > dma_cache_maint is fixed by the next patch. > > Signed-off-by: Stefano Stabellini > Tested-by: Corey Minyard > Tested-by: Roman Shaposhnik Acked-by: Juergen Gross Juergen From xen-devel-bounces@lists.xenproject.org Tue Aug 04 05:56:47 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 05:56:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2pwF-0006xx-6Q; Tue, 04 Aug 2020 05:56:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2pwE-0006xs-7M for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 05:56:38 +0000 X-Inumbo-ID: 4212b3a0-d617-11ea-9128-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4212b3a0-d617-11ea-9128-bc764e2007e4; Tue, 04 Aug 2020 05:56:37 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4CC0DAC7D; Tue, 4 Aug 2020 05:56:52 +0000 (UTC) Subject: Re: [PATCH v3 00/11] fix swiotlb-xen for RPi4 To: Stefano Stabellini , boris.ostrovsky@oracle.com, konrad.wilk@oracle.com References: From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <8413f3e2-0bbf-efa3-1a8a-2ae05b1d07c8@suse.com> Date: Tue, 4 Aug 2020 07:56:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: hch@infradead.org, xen-devel@lists.xenproject.org, tamas@tklengyel.com, linux-kernel@vger.kernel.org, roman@zededa.com Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 11.07.20 00:34, Stefano Stabellini wrote: > Hi all, > > This series is a collection of fixes to get Linux running on the RPi4 as > dom0. Conceptually there are only two significant changes: > > - make sure not to call virt_to_page on vmalloc virt addresses (patch > #1) > - use phys_to_dma and dma_to_phys to translate phys to/from dma > addresses (all other patches) > > > I addressed all comments by Christoph to v2 of the series except from > the one about merging the precursor "add struct device *" patches. I can > always merge them together at any time as needed. > > > Boris gave his Reviewed-by to the whole series v2. I added his > Reviewed-by to all patches, including the ones with small cosmetic > fixes, except for patch #8 #9 #10 because they are either new or changed > significantly in this version of the series. > > I retained Roman and Corey's Tested-by. Series pushed to: xen/tip.git for-linus-5.9 Juergen From xen-devel-bounces@lists.xenproject.org Tue Aug 04 06:12:02 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 06:12:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2qAw-0000GZ-JF; Tue, 04 Aug 2020 06:11:50 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2qAv-0000GU-Iu for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 06:11:49 +0000 X-Inumbo-ID: 60cafd84-d619-11ea-9128-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 60cafd84-d619-11ea-9128-bc764e2007e4; Tue, 04 Aug 2020 06:11:48 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AD44FAC7D; Tue, 4 Aug 2020 06:12:03 +0000 (UTC) Subject: Re: [PATCH 1/6] xen/gntdev: Fix dmabuf import with non-zero sgt offset To: Oleksandr Andrushchenko , xen-devel@lists.xenproject.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, boris.ostrovsky@oracle.com, airlied@linux.ie, daniel@ffwll.ch References: <20200731125109.18666-1-andr2000@gmail.com> <20200731125109.18666-2-andr2000@gmail.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Tue, 4 Aug 2020 08:11:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200731125109.18666-2-andr2000@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, sstabellini@kernel.org, dan.carpenter@oracle.com, Oleksandr Andrushchenko Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 31.07.20 14:51, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > It is possible that the scatter-gather table during dmabuf import has > non-zero offset of the data, but user-space doesn't expect that. > Fix this by failing the import, so user-space doesn't access wrong data. > > Fixes: 37ccb44d0b00 ("xen/gntdev: Implement dma-buf import functionality") I can't find this commit in the tree. Did you mean bf8dc55b1358? And don't you want to Cc stable for this patch, too? > > Signed-off-by: Oleksandr Andrushchenko Acked-by: Juergen Gross Juergen From xen-devel-bounces@lists.xenproject.org Tue Aug 04 06:12:51 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 06:12:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2qBu-0000KM-UB; Tue, 04 Aug 2020 06:12:50 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2qBt-0000KE-Aj for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 06:12:49 +0000 X-Inumbo-ID: 8497d6c2-d619-11ea-b00c-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8497d6c2-d619-11ea-b00c-12813bfff9fa; Tue, 04 Aug 2020 06:12:48 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E76D7AC7D; Tue, 4 Aug 2020 06:13:02 +0000 (UTC) Subject: Re: [PATCH 2/6] drm/xen-front: Fix misused IS_ERR_OR_NULL checks To: Oleksandr Andrushchenko , xen-devel@lists.xenproject.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, boris.ostrovsky@oracle.com, airlied@linux.ie, daniel@ffwll.ch References: <20200731125109.18666-1-andr2000@gmail.com> <20200731125109.18666-3-andr2000@gmail.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <6d719ab2-d9f6-2c3c-8979-b12a4d10b96d@suse.com> Date: Tue, 4 Aug 2020 08:12:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200731125109.18666-3-andr2000@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, sstabellini@kernel.org, dan.carpenter@oracle.com, Oleksandr Andrushchenko Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 31.07.20 14:51, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > The patch c575b7eeb89f: "drm/xen-front: Add support for Xen PV > display frontend" from Apr 3, 2018, leads to the following static > checker warning: > > drivers/gpu/drm/xen/xen_drm_front_gem.c:140 xen_drm_front_gem_create() > warn: passing zero to 'ERR_CAST' > > drivers/gpu/drm/xen/xen_drm_front_gem.c > 133 struct drm_gem_object *xen_drm_front_gem_create(struct drm_device *dev, > 134 size_t size) > 135 { > 136 struct xen_gem_object *xen_obj; > 137 > 138 xen_obj = gem_create(dev, size); > 139 if (IS_ERR_OR_NULL(xen_obj)) > 140 return ERR_CAST(xen_obj); > > Fix this and the rest of misused places with IS_ERR_OR_NULL in the > driver. > > Fixes: c575b7eeb89f: "drm/xen-front: Add support for Xen PV display frontend" Again forgot to Cc stable? Juergen From xen-devel-bounces@lists.xenproject.org Tue Aug 04 06:14:09 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 06:14:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2qDB-0000RV-9I; Tue, 04 Aug 2020 06:14:09 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2qDA-0000RM-Kt for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 06:14:08 +0000 X-Inumbo-ID: b42b2ac4-d619-11ea-9128-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b42b2ac4-d619-11ea-9128-bc764e2007e4; Tue, 04 Aug 2020 06:14:07 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B8F2CAEFE; Tue, 4 Aug 2020 06:14:22 +0000 (UTC) Subject: Re: [PATCH 4/6] xen: Sync up with the canonical protocol definition in Xen To: Oleksandr Andrushchenko , xen-devel@lists.xenproject.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, boris.ostrovsky@oracle.com, airlied@linux.ie, daniel@ffwll.ch References: <20200731125109.18666-1-andr2000@gmail.com> <20200731125109.18666-5-andr2000@gmail.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <90b215cb-c878-340e-402a-7739ba17e4a7@suse.com> Date: Tue, 4 Aug 2020 08:14:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200731125109.18666-5-andr2000@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, sstabellini@kernel.org, dan.carpenter@oracle.com, Oleksandr Andrushchenko Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 31.07.20 14:51, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > This is the sync up with the canonical definition of the > display protocol in Xen. > > 1. Add protocol version as an integer > > Version string, which is in fact an integer, is hard to handle in the > code that supports different protocol versions. To simplify that > also add the version as an integer. > > 2. Pass buffer offset with XENDISPL_OP_DBUF_CREATE > > There are cases when display data buffer is created with non-zero > offset to the data start. Handle such cases and provide that offset > while creating a display buffer. > > 3. Add XENDISPL_OP_GET_EDID command > > Add an optional request for reading Extended Display Identification > Data (EDID) structure which allows better configuration of the > display connectors over the configuration set in XenStore. > With this change connectors may have multiple resolutions defined > with respect to detailed timing definitions and additional properties > normally provided by displays. > > If this request is not supported by the backend then visible area > is defined by the relevant XenStore's "resolution" property. > > If backend provides extended display identification data (EDID) with > XENDISPL_OP_GET_EDID request then EDID values must take precedence > over the resolutions defined in XenStore. > > 4. Bump protocol version to 2. > > Signed-off-by: Oleksandr Andrushchenko Reviewed-by: Juergen Gross Juergen From xen-devel-bounces@lists.xenproject.org Tue Aug 04 06:34:42 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 06:34:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2qWj-0002GF-W8; Tue, 04 Aug 2020 06:34:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2qWj-0002G8-7Z for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 06:34:21 +0000 X-Inumbo-ID: 86a6c8e4-d61c-11ea-912e-bc764e2007e4 Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 86a6c8e4-d61c-11ea-912e-bc764e2007e4; Tue, 04 Aug 2020 06:34:20 +0000 (UTC) Received: from pps.filterd (m0174677.ppops.net [127.0.0.1]) by mx0a-0039f301.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0746F4Tm030157; Tue, 4 Aug 2020 06:34:13 GMT Received: from eur04-vi1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2058.outbound.protection.outlook.com [104.47.14.58]) by mx0a-0039f301.pphosted.com with ESMTP id 32pxbn0b4s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 04 Aug 2020 06:34:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I2qMPqEkxAZfZ0d0HW79twlwuxkCI5Eo1wrgrhtUjErGfvOuzhYpK7wVCILinRMYlhz36CJZZi2CBmwMFrbZjAQLZfTfWHUgnKryrYdEKhdkI6ZjVZg5GLfmxYE0RNKsFXoW/+/HdZXJhvi+/St7CjVDExl530VLulyGplLD7fVV/PpB+Cmvvi/tVcufNrF4rL0rhq2u47PtY/4jG0FWsoT4/EjyA+g1Y+f3rdXxovEw3xv2YxVerFmlAY9R4iSfMapA2wHpzizGOdBwlsJqlecFR1rwhpiIFzlVCsk/qFwXSBeICyD2QSJktcrqqtZgbGUHqY6iEKIQf1xCA0uN4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dt7A68HQ6gnedq5sqGeegGqbUhQ1pFj77ot3E81bgeg=; b=E7c5szBumkGIc5bbhtrksE13bqVScpWRvKU2kS8U8VEOwqQvLrpd70M34blJVzxqlvIjei4fd+Xx2GGLb90hljXtfLkNSNqo53UQru/sq9TdEbLHA9OsxlfHGNw5GjeWQhbTFQ17yEl7OiUnNWgtw1+Fg7S5WGm335ciAPnIF7eYlEIs4ZdSJ1SNi2fhhwWefcorouDxepiuh91fFjXwe2hFDpM16q6BXKDleb3Rq1VGmr8m0yNS+Q4vc3t0LJn6nG38cBYdxKWY/GptEXI3rtCG2PJji7LY3DUs/Mq3tkJ8XAE0Tw4Pi19ZdkYY8yT+m3BvgAsjQcXMLJ4+cmMATw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dt7A68HQ6gnedq5sqGeegGqbUhQ1pFj77ot3E81bgeg=; b=ZdqmafcCcvAnNy5j2aw2FTlcDKcS4AEP8FokdC4D6MUA71zIXTocU7UUt+EOp4w3g1eOQJPKq8AAdXYAotRVwW0yy1qXHVpC0qNSROHVi/zHmu+bYdB9xEZdfr/ses9/A9w/Ddiwnp58C1Vvst7kY52porwneLV+LMo68WPUHI92XrHL5wdJaQ6u/wY3mYD8wkAI0GzlVMTyFwYIw/+36NWVWmvN1Tr7PpckEkRxy+YPtuImPc345ljkA6z+/gDeBB/7DkNcrw1pGS7cRBW7kl1m7b3tDyrtm+bsZ37DLuzHhaW4jTxujMNIOWYvjNAPZrazy2RrsGsaXO30GS5vsQ== Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17) by AM0PR03MB6242.eurprd03.prod.outlook.com (2603:10a6:20b:15c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.16; Tue, 4 Aug 2020 06:34:10 +0000 Received: from AM0PR03MB6324.eurprd03.prod.outlook.com ([fe80::21e5:6d27:5ba0:f508]) by AM0PR03MB6324.eurprd03.prod.outlook.com ([fe80::21e5:6d27:5ba0:f508%9]) with mapi id 15.20.3239.022; Tue, 4 Aug 2020 06:34:10 +0000 From: Oleksandr Andrushchenko To: =?utf-8?B?SsO8cmdlbiBHcm/Dnw==?= , Oleksandr Andrushchenko , "xen-devel@lists.xenproject.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "boris.ostrovsky@oracle.com" , "airlied@linux.ie" , "daniel@ffwll.ch" Subject: Re: [PATCH 1/6] xen/gntdev: Fix dmabuf import with non-zero sgt offset Thread-Topic: [PATCH 1/6] xen/gntdev: Fix dmabuf import with non-zero sgt offset Thread-Index: AQHWZzlJKFE4UhNAbk+yHV1cN0npaaknfdGAgAAGQIA= Date: Tue, 4 Aug 2020 06:34:10 +0000 Message-ID: References: <20200731125109.18666-1-andr2000@gmail.com> <20200731125109.18666-2-andr2000@gmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=epam.com; x-originating-ip: [185.199.97.5] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8da35b25-f110-4d4c-cf95-08d838406574 x-ms-traffictypediagnostic: AM0PR03MB6242: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:265; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YGxIjuTcC1ym7LSNcIU6NVRpoTZ9yA4Foa8hdQkd8aqwmrmlbStFhQm/C2N7cNHrJzG0ua3qH5OByx7SQW6q8tQSntu1b420l6+aPC7mlXps6gsGxTCp6wsaftmMv5IvCgdIQwBgChLSvgAFqLOkSgofMoaPsDcMnm454rAL/UL78pZlJNtU+Z/nKzzmGAAOVt7eWf5N5pBQf5WXqAjGIvFxm+fsevfn6oEjBK0CMb5r6AN4LVw0JAObMIH3nUC+BmYtFOfkiz+0LljG80CMJPvThh5EtLlPFyFduzaudykOv/lDw0Y5UepytCaGgAnzHjMwDyB8rXIPZ5vxMHaywA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR03MB6324.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(396003)(136003)(376002)(346002)(39860400002)(8676002)(316002)(7416002)(8936002)(478600001)(2616005)(31686004)(66556008)(66476007)(2906002)(4744005)(4326008)(91956017)(76116006)(66446008)(64756008)(6512007)(6486002)(71200400001)(5660300002)(31696002)(6506007)(66574015)(110136005)(54906003)(83380400001)(26005)(66946007)(36756003)(53546011)(86362001)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: INSR6J7iTUjY9XyKgBhBiirH/eEJSoTgHGW43dLM5sbH4OWEp71/BLqouEecEzd981Fshf40pJZAFUCRQxN/ctPEuWRRI1nWA1zha3L5gHb0pzTQR0dAa4oEwYE0T0yqvM1R27kJwYc+1PgeSZ9KR3y1sg4HW2qWLkdxE3nrIRPlnd7zJDEY64X93gY1PgJcZ/N0sI53weARP/is7kcRJN00Baz32wCFHpTSG3qLLyMbpHNkN+pZtO13UkeaMC2i9yL6S+5I0fEZFnjKWvfn+UfWuYtQ/JCscA3+hgktwk7Rs3MfcwExkGxFGx57cRCddVC/MOxxd/p5ivlXWA35KnVIvXRzzojDdBv9PtcP9YSnYjbDIAagbhrCZM002A2spncp4ARbfDDBtOYikaP0q0OzbhaNovdy5bBnqZCJYT+lH6OmUXSoMFmDXxVV7w8NHRphaZUhJBnYG3UfZM3LaWU/yr/gIEgOhpi61o8bSY7TPEvXLAl0q4A/qLVZnJ3pxLhFZOCdfT4p5YLJii2BcjWJ3C04O6h33Q6wKJamnUTwoRKau+lwZXS9rWSBvm7afbhRoW23aQNCtd6NvAbAnuG9hcpw4D27QPZz4FHgYFijMw5s0+ZfvzjkybirmTRNR754dAwYYc8h51FUW1t3ZA== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-ID: <44D1CE254150BE4D8C6C2DEB066AFF88@eurprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8da35b25-f110-4d4c-cf95-08d838406574 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Aug 2020 06:34:10.3016 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hV6Qrp8GB499WVSSD4JV2S2HYxmCfiV8zl3Sl3nW00RX9xOrT4QxFJD4I0FwGBpcx6A2UBbjdChwrBP03UnUjiH7BiMDvjJiAoUkBwsw/ZXYwsLgbPx/efolMd8QANRy X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB6242 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-08-04_02:2020-08-03, 2020-08-04 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 spamscore=0 mlxscore=0 phishscore=0 malwarescore=0 bulkscore=0 adultscore=0 clxscore=1011 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008040047 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "intel-gfx@lists.freedesktop.org" , "sstabellini@kernel.org" , "dan.carpenter@oracle.com" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" DQpPbiA4LzQvMjAgOToxMSBBTSwgSsO8cmdlbiBHcm/DnyB3cm90ZToNCj4gT24gMzEuMDcuMjAg MTQ6NTEsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4gRnJvbTogT2xla3NhbmRy IEFuZHJ1c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNoY2hlbmtvQGVwYW0uY29tPg0KPj4NCj4+ IEl0IGlzIHBvc3NpYmxlIHRoYXQgdGhlIHNjYXR0ZXItZ2F0aGVyIHRhYmxlIGR1cmluZyBkbWFi dWYgaW1wb3J0IGhhcw0KPj4gbm9uLXplcm8gb2Zmc2V0IG9mIHRoZSBkYXRhLCBidXQgdXNlci1z cGFjZSBkb2Vzbid0IGV4cGVjdCB0aGF0Lg0KPj4gRml4IHRoaXMgYnkgZmFpbGluZyB0aGUgaW1w b3J0LCBzbyB1c2VyLXNwYWNlIGRvZXNuJ3QgYWNjZXNzIHdyb25nIGRhdGEuDQo+Pg0KPj4gRml4 ZXM6IDM3Y2NiNDRkMGIwMCAoInhlbi9nbnRkZXY6IEltcGxlbWVudCBkbWEtYnVmIGltcG9ydCBm dW5jdGlvbmFsaXR5IikNCj4NCj4gSSBjYW4ndCBmaW5kIHRoaXMgY29tbWl0IGluIHRoZSB0cmVl LiBEaWQgeW91IG1lYW4gYmY4ZGM1NWIxMzU4Pw0KSSdsbCBkb3VibGUtY2hlY2ssIHRoYW5rIHlv dQ0KPg0KPiBBbmQgZG9uJ3QgeW91IHdhbnQgdG8gQ2Mgc3RhYmxlIGZvciB0aGlzIHBhdGNoLCB0 b28/DQpIbSwgeWVzLCBzb3VuZHMgcmVhc29uYWJsZQ0KPg0KPj4NCj4+IFNpZ25lZC1vZmYtYnk6 IE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIDxvbGVrc2FuZHJfYW5kcnVzaGNoZW5rb0BlcGFtLmNv bT4NCj4NCj4gQWNrZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4NCj4N Cj4gSnVlcmdlbg== From xen-devel-bounces@lists.xenproject.org Tue Aug 04 06:35:37 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 06:35:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2qXx-0002L0-EY; Tue, 04 Aug 2020 06:35:37 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2qXw-0002Kq-Be for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 06:35:36 +0000 X-Inumbo-ID: b3b4d7d6-d61c-11ea-b00d-12813bfff9fa Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b3b4d7d6-d61c-11ea-b00d-12813bfff9fa; Tue, 04 Aug 2020 06:35:35 +0000 (UTC) Received: from pps.filterd (m0174682.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0746ZVhp008400; Tue, 4 Aug 2020 06:35:31 GMT Received: from eur05-vi1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2170.outbound.protection.outlook.com [104.47.17.170]) by mx0b-0039f301.pphosted.com with ESMTP id 32n6tpwcm1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 04 Aug 2020 06:35:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CeAFWw1N8FMLvd6BjNQnvnM5GdsTvmZ1cmiMLHI+i2FOoWa+nUngMNOfW1nZ0CRrWmdc2d5iuYLRxBaAx5abb6nq3xn9jZCUfh1y5nMTAvTkfslrK+shhl/Al4Pe1rF5dV1vW8CvUUSORBeC0kB2kx37c3gumRTgbtkh2bQ5X/Y8YBraD/I7tQrN/JxGFw+lVCwrAjPvENgc7veZ9l4bzVSbtSVp9B2ConrPpxknG3UeHmi2wnbhqUVYDhzuPfvM1BL/qrUrS4j/Xv5EcRvfm/z7kXI/vzWREEq1+Rs3qXEMbMKEwZPw3kDjzjXcRRu2l/1YIkX3WQ54QFFh73llmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lc4bC+XGhCr1+jTG6XrTRAZNK53WspKNeV6btNcHLOQ=; b=Fh8C+9D3jY8xg8DY5Vw5G7iO9/yNOj8BIkPiRjbh9PohbGhnPqgUfecL5tWSd2Yn01ZSMTvSCukP9H/eUinIj/kFQNL5uYoytZry9WJhlkMzarGz0IyQZli1sxs82Ap8cTNRn32MXbW8ZWRHQLJQ7OgcBrmGCryqRJ0YNUzdN8+UXgzgwmgG6QshI4BI6Y9YjBJN2RH/I1/Mu6OZGsYDtB7gB4LTBQcXB1kfBRf577E94pWwY4xPuMJrtfg30Fpk9kRPi2QHQzbhyaDwjhfhT1qK+LJmkcjVBf8lXhYzUbGb5YNfYYSLjLPvxple9ZZAphNE+SrTqaf6Gy1O96ifyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lc4bC+XGhCr1+jTG6XrTRAZNK53WspKNeV6btNcHLOQ=; b=W1yKdZ3xXeFkNfbDw0Mw8vicuaylfoLjpGSFJ36M9uzzFArpOOrEcpcFpqZBvHE9JvlkdRe8THPAdCvq+wmDqbe3Mv9ZCtYCd9OJwOGoE+2jBkjX2j9aNvvLivM0bANzCduMvuk204g7u7orZi0AVmgr9gSCXv6iq1YPm7bmKyovE50VbQVeOSvWz43ELuZzmrFcJpP20IHOALSNSH/iXa+Rbe9jmA3brDUuMIl0p9ScmoUj6XPKUP8XZn3rNxjoOUL9hbf6/p5sfYAujpSAftj55WHQYoY2pSjwPzJs4/NTlTB5IRYD6CLwbe6mD5KQvp7HSrq55ZShQ4BAYASVmA== Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17) by AM0PR03MB4018.eurprd03.prod.outlook.com (2603:10a6:208:73::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.16; Tue, 4 Aug 2020 06:35:20 +0000 Received: from AM0PR03MB6324.eurprd03.prod.outlook.com ([fe80::21e5:6d27:5ba0:f508]) by AM0PR03MB6324.eurprd03.prod.outlook.com ([fe80::21e5:6d27:5ba0:f508%9]) with mapi id 15.20.3239.022; Tue, 4 Aug 2020 06:35:20 +0000 From: Oleksandr Andrushchenko To: =?utf-8?B?SsO8cmdlbiBHcm/Dnw==?= , Oleksandr Andrushchenko , "xen-devel@lists.xenproject.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "boris.ostrovsky@oracle.com" , "airlied@linux.ie" , "daniel@ffwll.ch" Subject: Re: [PATCH 2/6] drm/xen-front: Fix misused IS_ERR_OR_NULL checks Thread-Topic: [PATCH 2/6] drm/xen-front: Fix misused IS_ERR_OR_NULL checks Thread-Index: AQHWZzlL0sSwpF/GAkKOn1bzUQtIbaknfhgAgAAGTYA= Date: Tue, 4 Aug 2020 06:35:20 +0000 Message-ID: <0ed5082f-0280-16c0-7410-f6a90262bcee@epam.com> References: <20200731125109.18666-1-andr2000@gmail.com> <20200731125109.18666-3-andr2000@gmail.com> <6d719ab2-d9f6-2c3c-8979-b12a4d10b96d@suse.com> In-Reply-To: <6d719ab2-d9f6-2c3c-8979-b12a4d10b96d@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=epam.com; x-originating-ip: [185.199.97.5] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bacc23d0-ea50-4283-2028-08d838408f3a x-ms-traffictypediagnostic: AM0PR03MB4018: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sqyyZXAPZ/z3H/Ly6eF9f8KwJNrs3gHUd7BkzkMkooK993gYHTEATALdExOL6H9QMcfJh1tDL2F2gwXEZ0ME7/72z7KqgNkXvoTmiDLlx5bTRl+ZP16OVYb0lrrMHo1eyUxSTCJq3eIy6/Dsks54lUK3XTaFimEAKBd0jZaRh2P84kzti5xVgu6/ZcT8RxVM6hwlwe0DoQpLkW/V/IXpXDvpfq/Lns6qRLTneUgA11tahXTc2sCHWrJ9EsUlHc1V2p9Im/D2U/BpvZ8NCFsccFDhCq1OK2HF0NLKlj679PC3ECOf+81fWOdbJVEoP6SylEsJdb16FTFtdKuDtrrGEw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR03MB6324.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(136003)(39860400002)(376002)(366004)(346002)(66574015)(6506007)(6512007)(8676002)(53546011)(4326008)(186003)(26005)(83380400001)(36756003)(31686004)(8936002)(5660300002)(316002)(91956017)(66946007)(66476007)(86362001)(66556008)(2906002)(64756008)(7416002)(478600001)(31696002)(110136005)(6486002)(2616005)(71200400001)(54906003)(66446008)(76116006); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: QhMR69WQhyMQBpqeJiEZEx3t6YQfRYIHmcl9/oJQ/HDt4ZL3N+44TRYBCNnSIpLxDYIQSw0S5kIlIyqqePFeblBo8NkLY7Cf5pdFsUpKe300DENnQ5ZJ7gmILqCvA9rgn6afos3kr/OLASAShgamTSZZcVNFTgfO9UjUz20464hy6mpgQ+cljP/al8X4dOVSJrTMm4qJuSJve63M9Q/+Ev2iPQtDUw1efwrofG6IhBb6eJKdtMzjW1phYKSxZ3Qikm/w/azdvKxxXvC3ygYg9gNrd6eXb/wnuSS7FSZfSCDo4gJgV3S5Rnpl5kIGy/O0kJ73dd7yUansAwehyR4kr6STB4ZkJoQagqEzVxosgv3Ske/p1Pw+V1Cyyclm2lniAkuR+nmOGLJRb2gzYhJfBIwJAjqrWVZ3NwETooCK2l11zbOiLNL7sH1AFGuKmdNG/pejZJse0a1QybQAYtkFGwq1YJ7wmiTrEavtc7O4Urm9feUSZ1L7eQI10ZF1JvsUJPtratVDP8SR8o/S0VS728f3BH/r23Ep/yd/5lJ/D5o64U63zZ/sAr0eUuJfS/f33YwzFCqOlVd7nz4jvvOgm+80i1M+a9HOA0sz0UsIGsnpeHwZP0by9EO7qb/ZP+D9vSi4SUt4MhrVrRT/U4mvGQ== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-ID: <5ABBA776A8DB0E4FA17CEE06E29E6409@eurprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bacc23d0-ea50-4283-2028-08d838408f3a X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Aug 2020 06:35:20.3465 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eWW9QHSAhzV90syBmS6r/Z9p4/KgvXA0vEqEkQWozdMl3VOe2ymlHHY9Nfl97BEU53Knv0qBk4HcSN5cf6Tr8jBETyEVY2WLegbTT8kNbuOsKC6ByeJxghM8NwIZyVgh X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB4018 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-08-04_02:2020-08-03, 2020-08-04 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 mlxlogscore=999 priorityscore=1501 impostorscore=0 bulkscore=0 spamscore=0 phishscore=0 mlxscore=0 adultscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008040048 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "intel-gfx@lists.freedesktop.org" , "sstabellini@kernel.org" , "dan.carpenter@oracle.com" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" DQpPbiA4LzQvMjAgOToxMiBBTSwgSsO8cmdlbiBHcm/DnyB3cm90ZToNCj4gT24gMzEuMDcuMjAg MTQ6NTEsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4gRnJvbTogT2xla3NhbmRy IEFuZHJ1c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNoY2hlbmtvQGVwYW0uY29tPg0KPj4NCj4+ IFRoZSBwYXRjaCBjNTc1YjdlZWI4OWY6ICJkcm0veGVuLWZyb250OiBBZGQgc3VwcG9ydCBmb3Ig WGVuIFBWDQo+PiBkaXNwbGF5IGZyb250ZW5kIiBmcm9tIEFwciAzLCAyMDE4LCBsZWFkcyB0byB0 aGUgZm9sbG93aW5nIHN0YXRpYw0KPj4gY2hlY2tlciB3YXJuaW5nOg0KPj4NCj4+IMKgwqDCoMKg ZHJpdmVycy9ncHUvZHJtL3hlbi94ZW5fZHJtX2Zyb250X2dlbS5jOjE0MCB4ZW5fZHJtX2Zyb250 X2dlbV9jcmVhdGUoKQ0KPj4gwqDCoMKgwqB3YXJuOiBwYXNzaW5nIHplcm8gdG8gJ0VSUl9DQVNU Jw0KPj4NCj4+IGRyaXZlcnMvZ3B1L2RybS94ZW4veGVuX2RybV9mcm9udF9nZW0uYw0KPj4gwqDC oMKgIDEzM8KgIHN0cnVjdCBkcm1fZ2VtX29iamVjdCAqeGVuX2RybV9mcm9udF9nZW1fY3JlYXRl KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsDQo+PiDCoMKgwqAgMTM0wqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgc2l6ZV90IHNpemUpDQo+PiDCoMKgwqAgMTM1wqAgew0K Pj4gwqDCoMKgIDEzNsKgwqDCoMKgwqDCoMKgwqDCoCBzdHJ1Y3QgeGVuX2dlbV9vYmplY3QgKnhl bl9vYmo7DQo+PiDCoMKgwqAgMTM3DQo+PiDCoMKgwqAgMTM4wqDCoMKgwqDCoMKgwqDCoMKgIHhl bl9vYmogPSBnZW1fY3JlYXRlKGRldiwgc2l6ZSk7DQo+PiDCoMKgwqAgMTM5wqDCoMKgwqDCoMKg wqDCoMKgIGlmIChJU19FUlJfT1JfTlVMTCh4ZW5fb2JqKSkNCj4+IMKgwqDCoCAxNDDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiBFUlJfQ0FTVCh4ZW5fb2JqKTsNCj4+ DQo+PiBGaXggdGhpcyBhbmQgdGhlIHJlc3Qgb2YgbWlzdXNlZCBwbGFjZXMgd2l0aCBJU19FUlJf T1JfTlVMTCBpbiB0aGUNCj4+IGRyaXZlci4NCj4+DQo+PiBGaXhlczrCoCBjNTc1YjdlZWI4OWY6 ICJkcm0veGVuLWZyb250OiBBZGQgc3VwcG9ydCBmb3IgWGVuIFBWIGRpc3BsYXkgZnJvbnRlbmQi DQo+DQo+IEFnYWluIGZvcmdvdCB0byBDYyBzdGFibGU/DQoNCkkgd2FzIGp1c3Qgbm90IHN1cmUg aWYgdGhlc2UgbWlub3IgZml4ZXMgbmVlZCB0byBnbyB0aGUgc3RhYmxlLCBidXQgSSB3aWxsIGFk ZA0KDQpUaGFuayB5b3UNCg0KPg0KPg0KPiBKdWVyZ2Vu From xen-devel-bounces@lists.xenproject.org Tue Aug 04 06:39:50 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 06:39:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2qby-0002Xl-0w; Tue, 04 Aug 2020 06:39:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2qbw-0002Xg-8I for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 06:39:44 +0000 X-Inumbo-ID: 4722aedb-d61d-11ea-b00d-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4722aedb-d61d-11ea-b00d-12813bfff9fa; Tue, 04 Aug 2020 06:39:43 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2CA57AC20; Tue, 4 Aug 2020 06:39:58 +0000 (UTC) Subject: Re: [PATCH 2/6] drm/xen-front: Fix misused IS_ERR_OR_NULL checks To: Oleksandr Andrushchenko , Oleksandr Andrushchenko , "xen-devel@lists.xenproject.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "boris.ostrovsky@oracle.com" , "airlied@linux.ie" , "daniel@ffwll.ch" References: <20200731125109.18666-1-andr2000@gmail.com> <20200731125109.18666-3-andr2000@gmail.com> <6d719ab2-d9f6-2c3c-8979-b12a4d10b96d@suse.com> <0ed5082f-0280-16c0-7410-f6a90262bcee@epam.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <1ae2e8b4-eea3-e68b-2897-5e376a688881@suse.com> Date: Tue, 4 Aug 2020 08:39:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <0ed5082f-0280-16c0-7410-f6a90262bcee@epam.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "intel-gfx@lists.freedesktop.org" , "sstabellini@kernel.org" , "dan.carpenter@oracle.com" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 04.08.20 08:35, Oleksandr Andrushchenko wrote: > > On 8/4/20 9:12 AM, Jürgen Groß wrote: >> On 31.07.20 14:51, Oleksandr Andrushchenko wrote: >>> From: Oleksandr Andrushchenko >>> >>> The patch c575b7eeb89f: "drm/xen-front: Add support for Xen PV >>> display frontend" from Apr 3, 2018, leads to the following static >>> checker warning: >>> >>>     drivers/gpu/drm/xen/xen_drm_front_gem.c:140 xen_drm_front_gem_create() >>>     warn: passing zero to 'ERR_CAST' >>> >>> drivers/gpu/drm/xen/xen_drm_front_gem.c >>>     133  struct drm_gem_object *xen_drm_front_gem_create(struct drm_device *dev, >>>     134                                                  size_t size) >>>     135  { >>>     136          struct xen_gem_object *xen_obj; >>>     137 >>>     138          xen_obj = gem_create(dev, size); >>>     139          if (IS_ERR_OR_NULL(xen_obj)) >>>     140                  return ERR_CAST(xen_obj); >>> >>> Fix this and the rest of misused places with IS_ERR_OR_NULL in the >>> driver. >>> >>> Fixes:  c575b7eeb89f: "drm/xen-front: Add support for Xen PV display frontend" >> >> Again forgot to Cc stable? > > I was just not sure if these minor fixes need to go the stable, but I will add I'm fine both ways. Its just a reflex when I'm seeing a Fixes: tag but no Cc: stable. :-) Juergen From xen-devel-bounces@lists.xenproject.org Tue Aug 04 06:40:10 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 06:40:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2qcM-0003Dy-AC; Tue, 04 Aug 2020 06:40:10 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2qcL-0003Dr-7T for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 06:40:09 +0000 X-Inumbo-ID: 5673ca0e-d61d-11ea-b00d-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5673ca0e-d61d-11ea-b00d-12813bfff9fa; Tue, 04 Aug 2020 06:40:08 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8B7DFAC7D; Tue, 4 Aug 2020 06:40:23 +0000 (UTC) Subject: Re: [PATCH 03/10] x86emul: extend decoding / mem access testing to MMX / SSE insns To: Andrew Cooper References: <97ca3d9c-7540-c7b1-cf84-34c75c9127df@suse.com> <197bf5e9-5246-abfb-3870-6ca3dbaee152@suse.com> From: Jan Beulich Message-ID: <291ff1f5-a999-b337-c704-f9a7d0754ddf@suse.com> Date: Tue, 4 Aug 2020 08:40:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 03.08.2020 18:42, Andrew Cooper wrote: > On 03/08/2020 15:50, Jan Beulich wrote: >> IOW just legacy encoded ones. For 3dNow! just one example is used, as >> they're all similar in nature both encoding- and operand-wise. >> >> Adjust a slightly misleading (but not wrong) memcpy() invocation, as >> noticed while further cloning that code. > > I don't see any adjustment, in this or later patches. > > Is the comment stale? Indeed it is, thanks for noticing. That change we merged back into the patch that has already gone in (and afaict now it was a memset(), not a memcpy()). Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 04 06:42:44 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 06:42:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2qeo-0003Op-Op; Tue, 04 Aug 2020 06:42:42 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2qen-0003Oj-Jp for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 06:42:41 +0000 X-Inumbo-ID: b1291ee0-d61d-11ea-b00d-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b1291ee0-d61d-11ea-b00d-12813bfff9fa; Tue, 04 Aug 2020 06:42:40 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B89F6AC7D; Tue, 4 Aug 2020 06:42:55 +0000 (UTC) Subject: Re: [PATCH 00/10] x86emul: full coverage mem access / write testing To: Andrew Cooper References: <97ca3d9c-7540-c7b1-cf84-34c75c9127df@suse.com> <60a128e9-0480-a753-4aa8-177c270d09f4@citrix.com> From: Jan Beulich Message-ID: <78a9ef20-eb9b-81a0-8b3d-de668db3f828@suse.com> Date: Tue, 4 Aug 2020 08:42:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <60a128e9-0480-a753-4aa8-177c270d09f4@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 03.08.2020 18:40, Andrew Cooper wrote: > On 03/08/2020 15:47, Jan Beulich wrote: >> ... and a few fixes resulting from this work. This completes what >> was started for legacy encoded GPR insns in a rush before 4.14. >> >> There's one thing I'm still planning on top of both this and the >> EVEX-disp8 checking: For all encodings we produce via general >> logic (and in particular without involvement of any assembler) I'd >> like to add a kind of logging mechanism, the output of which could >> be fed to gas and then some disassembler, to allow verification >> that the produced encodings are actually valid ones. See e.g. the >> first patch here or commit 5f55389d6960 - the problems addressed >> there could have been caught earlier if the generated encodings >> could be easily disassembled. What's not clear to me here is >> whether this is deemed generally useful, or whether I should make >> this a private addition of mine. > > Seems fine to me. > > I have encountered a failure on AMD Naples which I doubt is related to > this series, but is blocking testing on some of the content here. > > Testing fnstenv 4(%ecx)...              failed! > > AMD Fam17 does have the fcs/fds save-as-zero logic which is still not > wired up anywhere in Xen, which seems like the most likely candidate > here (without having investigated the issue at all yet). There are two zap_fpsel() in place there, which I would have thought to cover this. I'll see whether I can repro on my Rome box. Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 04 07:28:39 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 07:28:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2rN5-0006wR-4j; Tue, 04 Aug 2020 07:28:27 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2rN3-0006wM-Vh for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 07:28:26 +0000 X-Inumbo-ID: 14a89ea4-d624-11ea-9132-bc764e2007e4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 14a89ea4-d624-11ea-9132-bc764e2007e4; Tue, 04 Aug 2020 07:28:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=OY7KqXJVEEPd3PhvurotlkLEXq19d1PnZbKTnp/8Wfw=; b=cULzcIH5CV51chkHHq+whPEnd AWBsbLj8kuIlf+mx5ioT05NX5oLT7rlI+0wcOqA3EokdyTOR6YHDUSQe70M1k7auMrsScwbBUjHgg eoccp98g80uczTkUezrSw3GGjnN+MYa9YCek/24oUZsgNbVzHGNnaK6/kz5UhnmpuJm64=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2rN1-0007cY-AS; Tue, 04 Aug 2020 07:28:23 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k2rN0-00057i-O7; Tue, 04 Aug 2020 07:28:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k2rN0-00018T-Na; Tue, 04 Aug 2020 07:28:22 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 152422: all pass - PUSHED X-Osstest-Versions-This: ovmf=bbb8a818583853ec4bb7804e78ed1d304b709d33 X-Osstest-Versions-That: ovmf=e557442e3f7ec7bee2d886978bbd259c6d68c75a From: osstest service owner Date: Tue, 04 Aug 2020 07:28:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152422 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/152422/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf bbb8a818583853ec4bb7804e78ed1d304b709d33 baseline version: ovmf e557442e3f7ec7bee2d886978bbd259c6d68c75a Last test of basis 152367 2020-08-01 20:49:35 Z 2 days Testing same since 152422 2020-08-03 12:09:55 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Pete Batard jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git e557442e3f..bbb8a81858 bbb8a818583853ec4bb7804e78ed1d304b709d33 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Aug 04 07:38:57 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 07:38:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2rX1-0007tp-72; Tue, 04 Aug 2020 07:38:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2rX0-0007tk-O1 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 07:38:42 +0000 X-Inumbo-ID: 843e2eb8-d625-11ea-9134-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 843e2eb8-d625-11ea-9134-bc764e2007e4; Tue, 04 Aug 2020 07:38:41 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 563F9ACB7; Tue, 4 Aug 2020 07:38:56 +0000 (UTC) Subject: Re: [PATCH 00/10] x86emul: full coverage mem access / write testing To: Andrew Cooper References: <97ca3d9c-7540-c7b1-cf84-34c75c9127df@suse.com> <60a128e9-0480-a753-4aa8-177c270d09f4@citrix.com> From: Jan Beulich Message-ID: Date: Tue, 4 Aug 2020 09:38:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <60a128e9-0480-a753-4aa8-177c270d09f4@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 03.08.2020 18:40, Andrew Cooper wrote: > On 03/08/2020 15:47, Jan Beulich wrote: >> ... and a few fixes resulting from this work. This completes what >> was started for legacy encoded GPR insns in a rush before 4.14. >> >> There's one thing I'm still planning on top of both this and the >> EVEX-disp8 checking: For all encodings we produce via general >> logic (and in particular without involvement of any assembler) I'd >> like to add a kind of logging mechanism, the output of which could >> be fed to gas and then some disassembler, to allow verification >> that the produced encodings are actually valid ones. See e.g. the >> first patch here or commit 5f55389d6960 - the problems addressed >> there could have been caught earlier if the generated encodings >> could be easily disassembled. What's not clear to me here is >> whether this is deemed generally useful, or whether I should make >> this a private addition of mine. > > Seems fine to me. > > I have encountered a failure on AMD Naples which I doubt is related to > this series, but is blocking testing on some of the content here. > > Testing fnstenv 4(%ecx)...              failed! > > AMD Fam17 does have the fcs/fds save-as-zero logic which is still not > wired up anywhere in Xen, which seems like the most likely candidate > here (without having investigated the issue at all yet). FIP/FOP/FDP are lost over a context switch in Linux here, as it seems. No idea yet why a context switch would happen this reliably on Fam17, but not on Fam15 (where I'd expect the behavior to be the same as long as there's no unmasked exception). Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 04 07:45:22 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 07:45:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2rdH-0000QO-CH; Tue, 04 Aug 2020 07:45:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2rdF-0000QJ-KO for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 07:45:09 +0000 X-Inumbo-ID: 6ac9eaa2-d626-11ea-9134-bc764e2007e4 Received: from mail-wm1-x341.google.com (unknown [2a00:1450:4864:20::341]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6ac9eaa2-d626-11ea-9134-bc764e2007e4; Tue, 04 Aug 2020 07:45:08 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id 184so1921522wmb.0 for ; Tue, 04 Aug 2020 00:45:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:content-language :thread-index; bh=vMBDvnVaS6aghQbQyMlKeQdm8TCMaIQQVDU0BX/qKtk=; b=jS3Yd+6MiVUkCKIA5ASH0C5xpBhp5PlVhcrUSMqq4piyRXGug78SKWbUzUaPzbjaTq DWzyuRJ37p+ddAPtijO19kJA5gYKNBpyYH1nhCiW4AgHLnJHWHvZ6Kd/N0UASdr7ORif aibm1E6dRYbe3KQEnU6yTY11VhEVWFoYVmaCLfit5Jw5H07yvkmDRQzpcdzk3WhG1b// A3MtVRqS0O5/YubLMOMTWrD7qQs4LWpib/0i35Pc0qLOCRTGy2AEx2ZNBuIrrzFk5BwA r3nZhdPZ7y1qJzn7MFPcMJJvShkB5FG7cmthXC5FHlmka2GXDFvoPG0N+YCtosXJVIif z5zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:to:cc:references:in-reply-to :subject:date:message-id:mime-version:content-transfer-encoding :content-language:thread-index; bh=vMBDvnVaS6aghQbQyMlKeQdm8TCMaIQQVDU0BX/qKtk=; b=IqZDmguEnt6pqox83CKObHqvY7FgSOj2SMnX1lcTa4EKk65PwyIYfP5T9viu+GNnCq /Qd5YksYNi6h1YUgfbQK7poQ34sM8UMYwSOu8bfpQ4jIYGBmQxkx1u/SBEMf/vhtETVs r01ODa9Q4YhyhPbtlpkuNk993H2soRkjTo5u7pjD/jiL9nRrR2jrl0j1+kv2vZPBvpQi mmI4Uxu6wX7CP5qRGjkhU7M0Ab2UmTWQbUt+fBpSLy546sEfQ+CQPskxiuc3szlutsJt IEuIn/9AuLNaPg6oUGDto/OBqPC9WFqIp7B76cDFmm2/cYYEYxvmnZuwt7kgjwCIq3AW Cccg== X-Gm-Message-State: AOAM532X66GECe36MHCqL8HzHM7bqH8iUJVJbOZlHUi5ax8JVvk5t7eZ t+vnZVxiy6mc/Jky+p+MUQE= X-Google-Smtp-Source: ABdhPJwY5TkHN3ZWB+03uyjHNCqBD/9KK7aSX1moKZl/0ygkNaUsDlMaVzJ64PhXiWk/3lhJEvlBog== X-Received: by 2002:a1c:18b:: with SMTP id 133mr2797011wmb.178.1596527107269; Tue, 04 Aug 2020 00:45:07 -0700 (PDT) Received: from CBGR90WXYV0 ([2a00:23c5:5785:9a01:9005:cf07:3ece:ca77]) by smtp.gmail.com with ESMTPSA id 32sm33571623wrh.18.2020.08.04.00.45.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Aug 2020 00:45:06 -0700 (PDT) From: Paul Durrant X-Google-Original-From: "Paul Durrant" To: "'Oleksandr Tyshchenko'" , References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-2-git-send-email-olekstysh@gmail.com> In-Reply-To: <1596478888-23030-2-git-send-email-olekstysh@gmail.com> Subject: RE: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common Date: Tue, 4 Aug 2020 08:45:05 +0100 Message-ID: <000c01d66a33$2bd56510$83802f30$@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Content-Language: en-gb Thread-Index: AQIHYXuU00Oy15gaFT3m+7M9vTQs4QHrpydYqLZB1/A= X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: paul@xen.org Cc: 'Kevin Tian' , 'Stefano Stabellini' , 'Julien Grall' , 'Jun Nakajima' , 'Wei Liu' , 'Andrew Cooper' , 'Ian Jackson' , 'George Dunlap' , 'Tim Deegan' , 'Oleksandr Tyshchenko' , 'Julien Grall' , 'Jan Beulich' , =?utf-8?Q?'Roger_Pau_Monn=C3=A9'?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" > -----Original Message----- > From: Oleksandr Tyshchenko > Sent: 03 August 2020 19:21 > To: xen-devel@lists.xenproject.org > Cc: Oleksandr Tyshchenko ; Jan Beulich = ; Andrew > Cooper ; Wei Liu ; Roger Pau = Monn=C3=A9 ; > George Dunlap ; Ian Jackson = ; Julien Grall > ; Stefano Stabellini ; Paul = Durrant ; Jun > Nakajima ; Kevin Tian ; = Tim Deegan ; Julien > Grall > Subject: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature = common >=20 > From: Oleksandr Tyshchenko >=20 > As a lot of x86 code can be re-used on Arm later on, this patch > splits IOREQ support into common and arch specific parts. >=20 > This support is going to be used on Arm to be able run device > emulator outside of Xen hypervisor. >=20 > Please note, this is a split/cleanup of Julien's PoC: > "Add support for Guest IO forwarding to a device emulator" >=20 > Signed-off-by: Julien Grall > Signed-off-by: Oleksandr Tyshchenko > --- > xen/arch/x86/Kconfig | 1 + > xen/arch/x86/hvm/dm.c | 2 +- > xen/arch/x86/hvm/emulate.c | 2 +- > xen/arch/x86/hvm/hvm.c | 2 +- > xen/arch/x86/hvm/io.c | 2 +- > xen/arch/x86/hvm/ioreq.c | 1431 = +-------------------------------------- > xen/arch/x86/hvm/stdvga.c | 2 +- > xen/arch/x86/hvm/vmx/realmode.c | 1 + > xen/arch/x86/hvm/vmx/vvmx.c | 2 +- > xen/arch/x86/mm.c | 2 +- > xen/arch/x86/mm/shadow/common.c | 2 +- > xen/common/Kconfig | 3 + > xen/common/Makefile | 1 + > xen/common/hvm/Makefile | 1 + > xen/common/hvm/ioreq.c | 1430 = ++++++++++++++++++++++++++++++++++++++ > xen/include/asm-x86/hvm/ioreq.h | 45 +- > xen/include/asm-x86/hvm/vcpu.h | 7 - > xen/include/xen/hvm/ioreq.h | 89 +++ > 18 files changed, 1575 insertions(+), 1450 deletions(-) > create mode 100644 xen/common/hvm/Makefile > create mode 100644 xen/common/hvm/ioreq.c > create mode 100644 xen/include/xen/hvm/ioreq.h You need to adjust the MAINTAINERS file since there will now be common = 'I/O EMULATION' code. Since I wrote most of ioreq.c, please retain me as = a maintainer of the common code. [snip] > @@ -1528,13 +143,19 @@ static int hvm_access_cf8( > return X86EMUL_UNHANDLEABLE; > } >=20 > -void hvm_ioreq_init(struct domain *d) > +void arch_hvm_ioreq_init(struct domain *d) > { > spin_lock_init(&d->arch.hvm.ioreq_server.lock); >=20 > register_portio_handler(d, 0xcf8, 4, hvm_access_cf8); > } >=20 > +void arch_hvm_ioreq_destroy(struct domain *d) > +{ > + if ( !relocate_portio_handler(d, 0xcf8, 0xcf8, 4) ) > + return; There's not really a lot of point in this. I think an empty function = here would be ok. > +} > + > /* > * Local variables: > * mode: C [snip] > +struct hvm_ioreq_server *hvm_select_ioreq_server(struct domain *d, > + ioreq_t *p) > +{ > + struct hvm_ioreq_server *s; > + uint8_t type; > + uint64_t addr; > + unsigned int id; > + > + if ( p->type !=3D IOREQ_TYPE_COPY && p->type !=3D IOREQ_TYPE_PIO = ) > + return NULL; > + > + hvm_get_ioreq_server_range_type(d, p, &type, &addr); Looking at this, I think it would make more sense to fold the check of = p->type into hvm_get_ioreq_server_range_type() and have it return = success/failure. > + > + FOR_EACH_IOREQ_SERVER(d, id, s) > + { > + struct rangeset *r; > + > + if ( !s->enabled ) > + continue; > + > + r =3D s->range[type]; > + > + switch ( type ) > + { > + unsigned long start, end; > + > + case XEN_DMOP_IO_RANGE_PORT: > + start =3D addr; > + end =3D start + p->size - 1; > + if ( rangeset_contains_range(r, start, end) ) > + return s; > + > + break; > + > + case XEN_DMOP_IO_RANGE_MEMORY: > + start =3D hvm_mmio_first_byte(p); > + end =3D hvm_mmio_last_byte(p); > + > + if ( rangeset_contains_range(r, start, end) ) > + return s; > + > + break; > + > + case XEN_DMOP_IO_RANGE_PCI: > + if ( rangeset_contains_singleton(r, addr >> 32) ) > + { > + p->type =3D IOREQ_TYPE_PCI_CONFIG; > + p->addr =3D addr; > + return s; > + } > + > + break; > + } > + } > + > + return NULL; > +} [snip] > diff --git a/xen/include/xen/hvm/ioreq.h b/xen/include/xen/hvm/ioreq.h > new file mode 100644 > index 0000000..40b7b5e > --- /dev/null > +++ b/xen/include/xen/hvm/ioreq.h > @@ -0,0 +1,89 @@ > +/* > + * hvm.h: Hardware virtual machine assist interface definitions. > + * > + * Copyright (c) 2016 Citrix Systems Inc. > + * > + * This program is free software; you can redistribute it and/or = modify it > + * under the terms and conditions of the GNU General Public License, > + * version 2, as published by the Free Software Foundation. > + * > + * This program is distributed in the hope it will be useful, but = WITHOUT > + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY = or > + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public = License for > + * more details. > + * > + * You should have received a copy of the GNU General Public License = along with > + * this program; If not, see . > + */ > + > +#ifndef __HVM_IOREQ_H__ > +#define __HVM_IOREQ_H__ > + > +#include > + > +#include > + > +#define GET_IOREQ_SERVER(d, id) \ > + (d)->arch.hvm.ioreq_server.server[id] > + > +static inline struct hvm_ioreq_server *get_ioreq_server(const struct = domain *d, > + unsigned int = id) > +{ > + if ( id >=3D MAX_NR_IOREQ_SERVERS ) > + return NULL; > + > + return GET_IOREQ_SERVER(d, id); > +} > + > +static inline bool hvm_ioreq_needs_completion(const ioreq_t *ioreq) > +{ > + return ioreq->state =3D=3D STATE_IOREQ_READY && > + !ioreq->data_is_ptr && > + (ioreq->type !=3D IOREQ_TYPE_PIO || ioreq->dir !=3D = IOREQ_WRITE); > +} I don't think having this in common code is correct. The short-cut of = not completing PIO reads seems somewhat x86 specific. Does ARM even have = the concept of PIO? Paul > + > +bool hvm_io_pending(struct vcpu *v); > +bool handle_hvm_io_completion(struct vcpu *v); > +bool is_ioreq_server_page(struct domain *d, const struct page_info = *page); > + > +int hvm_create_ioreq_server(struct domain *d, int bufioreq_handling, > + ioservid_t *id); > +int hvm_destroy_ioreq_server(struct domain *d, ioservid_t id); > +int hvm_get_ioreq_server_info(struct domain *d, ioservid_t id, > + unsigned long *ioreq_gfn, > + unsigned long *bufioreq_gfn, > + evtchn_port_t *bufioreq_port); > +int hvm_get_ioreq_server_frame(struct domain *d, ioservid_t id, > + unsigned long idx, mfn_t *mfn); > +int hvm_map_io_range_to_ioreq_server(struct domain *d, ioservid_t id, > + uint32_t type, uint64_t start, > + uint64_t end); > +int hvm_unmap_io_range_from_ioreq_server(struct domain *d, ioservid_t = id, > + uint32_t type, uint64_t = start, > + uint64_t end); > +int hvm_set_ioreq_server_state(struct domain *d, ioservid_t id, > + bool enabled); > + > +int hvm_all_ioreq_servers_add_vcpu(struct domain *d, struct vcpu *v); > +void hvm_all_ioreq_servers_remove_vcpu(struct domain *d, struct vcpu = *v); > +void hvm_destroy_all_ioreq_servers(struct domain *d); > + > +struct hvm_ioreq_server *hvm_select_ioreq_server(struct domain *d, > + ioreq_t *p); > +int hvm_send_ioreq(struct hvm_ioreq_server *s, ioreq_t *proto_p, > + bool buffered); > +unsigned int hvm_broadcast_ioreq(ioreq_t *p, bool buffered); > + > +void hvm_ioreq_init(struct domain *d); > + > +#endif /* __HVM_IOREQ_H__ */ > + > +/* > + * Local variables: > + * mode: C > + * c-file-style: "BSD" > + * c-basic-offset: 4 > + * tab-width: 4 > + * indent-tabs-mode: nil > + * End: > + */ > -- > 2.7.4 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 07:46:12 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 07:46:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2reG-0000W8-R9; Tue, 04 Aug 2020 07:46:12 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2reF-0000W0-GR for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 07:46:11 +0000 X-Inumbo-ID: 8f93da1e-d626-11ea-b019-12813bfff9fa Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8f93da1e-d626-11ea-b019-12813bfff9fa; Tue, 04 Aug 2020 07:46:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=cFTVX+QJZS7JePrXakKArGoOqieGeaxfgcIRWtM8PgE=; b=Z8MPb1bLE34nIcXZhlWRYdqz6 a/ycscKqpHFPxoKvqdm23meGVG+zx6FpfwnTIZa58SkrRpSHplL+SJObOLKCukXx1SNxyxIgCu6H7 VZ5edFVHGVWS/+zZdBfnHmfmUGHvKIVyenWzIxTCfOj4TApefrOzopeO5CAOUgovCtkJc=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2reC-00082V-H1; Tue, 04 Aug 2020 07:46:08 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k2reB-0007EQ-QQ; Tue, 04 Aug 2020 07:46:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k2reB-00050K-PL; Tue, 04 Aug 2020 07:46:07 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 152418: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking X-Osstest-Versions-This: xen=81fd0d3ca4b2cd309403c6e8da662c325dd35750 X-Osstest-Versions-That: xen=81fd0d3ca4b2cd309403c6e8da662c325dd35750 From: osstest service owner Date: Tue, 04 Aug 2020 07:46:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152418 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/152418/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 10 debian-hvm-install fail in 152389 pass in 152418 test-armhf-armhf-libvirt 16 guest-start/debian.repeat fail pass in 152389 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail like 152389 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail like 152389 test-armhf-armhf-xl-rtds 16 guest-start/debian.repeat fail like 152389 test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail like 152389 test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail like 152389 test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 152389 test-armhf-armhf-libvirt 14 saverestore-support-check fail like 152389 test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail like 152389 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail like 152389 test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail like 152389 test-amd64-i386-xl-pvshim 12 guest-start fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass version targeted for testing: xen 81fd0d3ca4b2cd309403c6e8da662c325dd35750 baseline version: xen 81fd0d3ca4b2cd309403c6e8da662c325dd35750 Last test of basis 152418 2020-08-03 11:11:04 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Tue Aug 04 07:49:13 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 07:49:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2rh9-0000k0-BI; Tue, 04 Aug 2020 07:49:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2rh8-0000jt-14 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 07:49:10 +0000 X-Inumbo-ID: fa5017a2-d626-11ea-9134-bc764e2007e4 Received: from mail-wr1-x444.google.com (unknown [2a00:1450:4864:20::444]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fa5017a2-d626-11ea-9134-bc764e2007e4; Tue, 04 Aug 2020 07:49:09 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id a15so36421158wrh.10 for ; Tue, 04 Aug 2020 00:49:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:content-language :thread-index; bh=YqRYaJb9Wy0HCA8xWccMhgRMKlPD8YVuiEuu/3WoXgs=; b=s0zQR/ioyw7NHKZhJ2YLIuq4vpAdzCgV/U5n/lDMOby0QfJmaM2YfI12Ljc5qntAxc WCzk5Au34L5uzyWa2ErWenRp2pnRGi0KQaAQ+1z/2SfVq4kGo3e/cbg/fDZFS9QlYJVD jN+icfR9MumsmkfYdSzuoFwlyfFum1oyKFQTUnnei1JN4my9k6adyUTwntznI6a/+yf3 xS7M6KvWp8YC+2+BieJpmxWt2fIZ4NBSKswJnuIqrwuxmFktQQthbAIu/Mo2lblk2TtH UdyKX/ConTg9MjBBV/F+0LRU83Z+tKJRXFHOqnKHBi6Z/K3jM8hLgchtsc3QOhiAKv5+ h0kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:to:cc:references:in-reply-to :subject:date:message-id:mime-version:content-transfer-encoding :content-language:thread-index; bh=YqRYaJb9Wy0HCA8xWccMhgRMKlPD8YVuiEuu/3WoXgs=; b=V0uoYt4Oi5Jc32lXetebX2xRyHODOs+9GSVnou8HsnCTF4nUGQ8i8ziZrWDbCMpQgo hivniJ849NAYpdnSftNO3CqpQxPgVuM3I2FPMI2rlolJkDGaJDQWhCAl9A2lwTGSgTCX dUWvQMGLoG3VHGt4SY2F56iEpM/d9ibU42EaAELyDXz/lEM9BA2dsY8FsOvfkJKHfEaB MJP9/MAvMr+huQSosTA3KeIm3CWGAH+ElBI11K2WzT0QCWdDDwGN7gfwiQlr2zV30wVI OyzbnTEc7GcdH3MMKljyDg0yUKnyKAQ4n1V1W/lgTZWzSK1+3P7WyNVTKUgRxaHpQVFH CdzA== X-Gm-Message-State: AOAM530A9l6NK9NKObTK3GX6BCkH6zy9NPNUat/7hFQO8FLyR/cbMwKd Mqz1qj0iHJlnNzoi3rK4oy8= X-Google-Smtp-Source: ABdhPJzOKccdVqUf09R6wonOyqQnsdTBxus57FS4lTYt2riPb7ByKqLpCgSVUqq/63uhfrcQSuO8aQ== X-Received: by 2002:adf:f247:: with SMTP id b7mr19529274wrp.128.1596527348378; Tue, 04 Aug 2020 00:49:08 -0700 (PDT) Received: from CBGR90WXYV0 ([2a00:23c5:5785:9a01:9005:cf07:3ece:ca77]) by smtp.gmail.com with ESMTPSA id k4sm32012456wrd.72.2020.08.04.00.49.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Aug 2020 00:49:07 -0700 (PDT) From: Paul Durrant X-Google-Original-From: "Paul Durrant" To: "'Oleksandr Tyshchenko'" , References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-5-git-send-email-olekstysh@gmail.com> In-Reply-To: <1596478888-23030-5-git-send-email-olekstysh@gmail.com> Subject: RE: [RFC PATCH V1 04/12] xen/arm: Introduce arch specific bits for IOREQ/DM features Date: Tue, 4 Aug 2020 08:49:06 +0100 Message-ID: <001101d66a33$bba44670$32ecd350$@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: en-gb Thread-Index: AQIHYXuU00Oy15gaFT3m+7M9vTQs4QI4vgcsqLPeFZA= X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: paul@xen.org Cc: 'Stefano Stabellini' , 'Julien Grall' , 'Wei Liu' , 'Andrew Cooper' , 'Ian Jackson' , 'George Dunlap' , 'Oleksandr Tyshchenko' , 'Julien Grall' , 'Jan Beulich' , 'Daniel De Graaf' , 'Volodymyr Babchuk' Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" > -----Original Message----- > From: Xen-devel On Behalf Of Oleksandr Tyshchenko > Sent: 03 August 2020 19:21 > To: xen-devel@lists.xenproject.org > Cc: Stefano Stabellini ; Julien Grall ; Wei Liu ; > Andrew Cooper ; Ian Jackson ; George Dunlap > ; Oleksandr Tyshchenko ; Julien Grall > ; Jan Beulich ; Daniel De Graaf ; > Volodymyr Babchuk > Subject: [RFC PATCH V1 04/12] xen/arm: Introduce arch specific bits for IOREQ/DM features > > From: Oleksandr Tyshchenko > > This patch makes possible to forward Guest MMIO accesses > to a device emulator on Arm and enables that support for > Arm64. > > Also update XSM code a bit to let DM op be used on Arm. > New arch DM op will be introduced in the follow-up patch. > > Please note, at the moment build on Arm32 is broken > (see cmpxchg usage in hvm_send_buffered_ioreq()) if someone > wants to enable CONFIG_IOREQ_SERVER due to the lack of > cmpxchg_64 support on Arm32. > > Please note, this is a split/cleanup of Julien's PoC: > "Add support for Guest IO forwarding to a device emulator" > > Signed-off-by: Julien Grall > Signed-off-by: Oleksandr Tyshchenko > --- > tools/libxc/xc_dom_arm.c | 25 +++++++--- > xen/arch/arm/Kconfig | 1 + > xen/arch/arm/Makefile | 2 + > xen/arch/arm/dm.c | 34 +++++++++++++ > xen/arch/arm/domain.c | 9 ++++ > xen/arch/arm/hvm.c | 46 +++++++++++++++++- > xen/arch/arm/io.c | 67 +++++++++++++++++++++++++- > xen/arch/arm/ioreq.c | 86 +++++++++++++++++++++++++++++++++ > xen/arch/arm/traps.c | 17 +++++++ > xen/common/memory.c | 5 +- > xen/include/asm-arm/domain.h | 80 +++++++++++++++++++++++++++++++ > xen/include/asm-arm/hvm/ioreq.h | 103 ++++++++++++++++++++++++++++++++++++++++ > xen/include/asm-arm/mmio.h | 1 + > xen/include/asm-arm/p2m.h | 7 +-- > xen/include/xsm/dummy.h | 4 +- > xen/include/xsm/xsm.h | 6 +-- > xen/xsm/dummy.c | 2 +- > xen/xsm/flask/hooks.c | 5 +- > 18 files changed, 476 insertions(+), 24 deletions(-) > create mode 100644 xen/arch/arm/dm.c > create mode 100644 xen/arch/arm/ioreq.c > create mode 100644 xen/include/asm-arm/hvm/ioreq.h > > diff --git a/tools/libxc/xc_dom_arm.c b/tools/libxc/xc_dom_arm.c > index 931404c..b5fc066 100644 > --- a/tools/libxc/xc_dom_arm.c > +++ b/tools/libxc/xc_dom_arm.c > @@ -26,11 +26,19 @@ > #include "xg_private.h" > #include "xc_dom.h" > > -#define NR_MAGIC_PAGES 4 > + > #define CONSOLE_PFN_OFFSET 0 > #define XENSTORE_PFN_OFFSET 1 > #define MEMACCESS_PFN_OFFSET 2 > #define VUART_PFN_OFFSET 3 > +#define IOREQ_SERVER_PFN_OFFSET 4 > + > +#define NR_IOREQ_SERVER_PAGES 8 > +#define NR_MAGIC_PAGES (4 + NR_IOREQ_SERVER_PAGES) > + > +#define GUEST_MAGIC_BASE_PFN (GUEST_MAGIC_BASE >> XC_PAGE_SHIFT) > + > +#define special_pfn(x) (GUEST_MAGIC_BASE_PFN + (x)) Why introduce 'magic pages' for Arm? It's quite a horrible hack that we have begun to do away with by adding resource mapping. Paul From xen-devel-bounces@lists.xenproject.org Tue Aug 04 07:49:40 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 07:49:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2rhc-0000oJ-Kh; Tue, 04 Aug 2020 07:49:40 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2rha-0000oD-Rs for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 07:49:39 +0000 X-Inumbo-ID: 0ba6fae7-d627-11ea-b019-12813bfff9fa Received: from us-smtp-1.mimecast.com (unknown [207.211.31.81]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 0ba6fae7-d627-11ea-b019-12813bfff9fa; Tue, 04 Aug 2020 07:49:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596527378; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=E2jiGLglr9GMSiEGPHsA3lR63Xofi0iHowxjVG7mx/w=; b=PqjBHAMza+5zw7DnIvirctPm6U9UXOhPsLniNCvi6k2sJ7vZyae6lXbS1Xn5wp09ze8uoq 3jbCMxXYkx5NlRuuiLxIHlVHUwolzTBUGXRianendqdFzCHeng2x82TgOhl14LCVWyUolv ilvP9ftFh3KYWXKRMm0tX0aBeMW8Zfw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-445-aO1xFc6YNNGSwKC2ozcedA-1; Tue, 04 Aug 2020 03:49:34 -0400 X-MC-Unique: aO1xFc6YNNGSwKC2ozcedA-1 Received: by mail-wm1-f70.google.com with SMTP id t26so917290wmn.4 for ; Tue, 04 Aug 2020 00:49:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=E2jiGLglr9GMSiEGPHsA3lR63Xofi0iHowxjVG7mx/w=; b=Yv8rZ7reUz4PWPluId1+jyKwxtEF+W53k5sCuSdVYLSOEsgRY/AyERXOHn35FwynMX w4DabM9YQ3fNC3Evx1caCxmgsJxpKRcqS9LcRjH/SZjzvkSk//3fh49M22GJXpRftDYS jYYG6sahIZe1o55hGhTTF32Jyzfcs2XtrvEG7P5/o/9Wqpvv/OGdPGiQYohO8NMkauCi nMHsGjQKXCgG4CogOsEbv2+i92Hx7kdXiBPe636Zh2EZSro0mQDv89wiNsYzu5Qj/93v p3xV7C7T485d3IBQMQ1is8m0XXr4kUXVcVPBnFkU0600i5GTrCVQ7HDBTXO+uolBgJLa VXiA== X-Gm-Message-State: AOAM532FmEKZA9XDZjLPUkBJ5pnEGHrInoW9WZGiTFuviTnchuvzY7bL SUrXlhs2Bevtg7lAbGJCH+ruUpaB9Xp6uXosr8gIpJH/HChtZ1nqWLQbMeaZwVNJsQ0ICB9S0Un mGx7YsWVetG9YZgXlKA3oU4qAYmU= X-Received: by 2002:a7b:cb98:: with SMTP id m24mr2996183wmi.10.1596527372815; Tue, 04 Aug 2020 00:49:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwVcaY1shpVa8jfBFMJx1xeZaNFrBZTRm99UYupi2noXnPadzDchI/0SLQAgLJaYlx8QkcURQ== X-Received: by 2002:a7b:cb98:: with SMTP id m24mr2996163wmi.10.1596527372609; Tue, 04 Aug 2020 00:49:32 -0700 (PDT) Received: from localhost.localdomain (214.red-88-21-68.staticip.rima-tde.net. [88.21.68.214]) by smtp.gmail.com with ESMTPSA id f12sm3317241wmc.46.2020.08.04.00.49.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2020 00:49:31 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH-for-5.1 v2 0/1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects Date: Tue, 4 Aug 2020 09:49:29 +0200 Message-Id: <20200804074930.13104-1-philmd@redhat.com> X-Mailer: git-send-email 2.21.3 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8; text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Stefano Stabellini , Paul Durrant , Paolo Bonzini , Anthony Perard , xen-devel@lists.xenproject.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Since v1: Fix build error reported by Peter: https://www.mail-archive.com/qemu-devel@nongnu.org/msg727251.html Now following KVM implementation closely. Philippe Mathieu-Daudé (1): accel/xen: Fix xen_enabled() behavior on target-agnostic objects include/sysemu/xen.h | 18 ++++++++++++++---- accel/stubs/xen-stub.c | 2 ++ accel/xen/xen-all.c | 7 +------ 3 files changed, 17 insertions(+), 10 deletions(-) -- 2.21.3 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 07:49:45 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 07:49:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2rhh-0000q4-12; Tue, 04 Aug 2020 07:49:45 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2rhf-0000oD-QR for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 07:49:43 +0000 X-Inumbo-ID: 0dbe3268-d627-11ea-b019-12813bfff9fa Received: from us-smtp-delivery-1.mimecast.com (unknown [205.139.110.120]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 0dbe3268-d627-11ea-b019-12813bfff9fa; Tue, 04 Aug 2020 07:49:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596527380; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DubP2PHuYgedFkG9BnFDW3kZHoveZWoPNSRntSxbcE8=; b=FRrLbNDcNESAr3BrAdeaqKi+fWMIIpzBObhlZYG720/hCO9olaIfpRD1eHgcweu0aiZrXo kuuxqi2eJCpKU9s6UkGg8joxtM2dw4nOaidwqzylbGq26Idcizxjtn8hOJXWzgEehqfLI4 enCuNz74v8HlUkkZSNWgiH83wB5yllQ= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-304-VYg0lAgLOdasHuA7fw8ezA-1; Tue, 04 Aug 2020 03:49:38 -0400 X-MC-Unique: VYg0lAgLOdasHuA7fw8ezA-1 Received: by mail-wm1-f72.google.com with SMTP id h205so923329wmf.0 for ; Tue, 04 Aug 2020 00:49:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DubP2PHuYgedFkG9BnFDW3kZHoveZWoPNSRntSxbcE8=; b=nWrzi+B5GDLNeHMQnTeDqsRx9htuYXJyUTRyTzpmwfPJO5Yz/nt75/3wHE9zXNxcCP 8/O8QKIByPMML11UIliGpp+EWU2oq9sIZzM/OchKJJyfo2PVY2B0GNC37XgEM2Cf9vbZ ratGwkVq1lqzcNCLLem/ayCebzgu9wKtWzqhM49j2g2EpJ+Eq7Z3tV5CeVxeqwbXLc36 6JiFoKnY15qGNLyeNAZCXzLi+s4PIPxstYI71tt3JLqdhIqGEwEdlpyn/Z18TcekGrB9 GMXoshPbhGPPhJLxrdA/pPb5n8Jq46InWFGfIuXxROTmbEsGCABUBtTbYJ5o2Fjt6qoi aMLA== X-Gm-Message-State: AOAM532XsW4sx3lOig29HyLgBluHdaM2d+LIg8BU50C2LbTiNcgf6XrZ sNdMT39yDhZQnovuRP1p6ijlVNCeSAn18aOhNiO8UWfvO8pE8+NZROaSWahzdRHzp8YGBucONqD lzbXTVwQ4FcpzlhHx2LIQaQKRGP8= X-Received: by 2002:a1c:7e02:: with SMTP id z2mr2831211wmc.138.1596527377724; Tue, 04 Aug 2020 00:49:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxNZ4uQ4vB8a5aJh7I4ZPsgC9K6vuCsuWWzRpjP2pDwPhZtBykcSfO33F9dwpNAm2EMiOXt+A== X-Received: by 2002:a1c:7e02:: with SMTP id z2mr2831191wmc.138.1596527377467; Tue, 04 Aug 2020 00:49:37 -0700 (PDT) Received: from localhost.localdomain (214.red-88-21-68.staticip.rima-tde.net. [88.21.68.214]) by smtp.gmail.com with ESMTPSA id 8sm30384185wrl.7.2020.08.04.00.49.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2020 00:49:36 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH-for-5.1 v2 1/1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects Date: Tue, 4 Aug 2020 09:49:30 +0200 Message-Id: <20200804074930.13104-2-philmd@redhat.com> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200804074930.13104-1-philmd@redhat.com> References: <20200804074930.13104-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8; text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Stefano Stabellini , Paul Durrant , Paul Durrant , Paolo Bonzini , Anthony Perard , xen-devel@lists.xenproject.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" CONFIG_XEN is generated by configure and stored in "config-target.h", which is (obviously) only include for target-specific objects. This is a problem for target-agnostic objects as CONFIG_XEN is never defined and xen_enabled() is always inlined as 'false'. Fix by following the KVM schema, defining CONFIG_XEN_IS_POSSIBLE when we don't know to force the call of the non-inlined function, returning the xen_allowed boolean. Fixes: da278d58a092 ("accel: Move Xen accelerator code under accel/xen/") Reported-by: Paul Durrant Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- include/sysemu/xen.h | 18 ++++++++++++++---- accel/stubs/xen-stub.c | 2 ++ accel/xen/xen-all.c | 7 +------ 3 files changed, 17 insertions(+), 10 deletions(-) diff --git a/include/sysemu/xen.h b/include/sysemu/xen.h index 1ca292715e..2c2c429ea8 100644 --- a/include/sysemu/xen.h +++ b/include/sysemu/xen.h @@ -8,9 +8,19 @@ #ifndef SYSEMU_XEN_H #define SYSEMU_XEN_H -#ifdef CONFIG_XEN +#ifdef NEED_CPU_H +# ifdef CONFIG_XEN +# define CONFIG_XEN_IS_POSSIBLE +# endif +#else +# define CONFIG_XEN_IS_POSSIBLE +#endif -bool xen_enabled(void); +#ifdef CONFIG_XEN_IS_POSSIBLE + +extern bool xen_allowed; + +#define xen_enabled() (xen_allowed) #ifndef CONFIG_USER_ONLY void xen_hvm_modified_memory(ram_addr_t start, ram_addr_t length); @@ -18,7 +28,7 @@ void xen_ram_alloc(ram_addr_t ram_addr, ram_addr_t size, struct MemoryRegion *mr, Error **errp); #endif -#else /* !CONFIG_XEN */ +#else /* !CONFIG_XEN_IS_POSSIBLE */ #define xen_enabled() 0 #ifndef CONFIG_USER_ONLY @@ -33,6 +43,6 @@ static inline void xen_ram_alloc(ram_addr_t ram_addr, ram_addr_t size, } #endif -#endif /* CONFIG_XEN */ +#endif /* CONFIG_XEN_IS_POSSIBLE */ #endif diff --git a/accel/stubs/xen-stub.c b/accel/stubs/xen-stub.c index dcca4e678a..8ae658acff 100644 --- a/accel/stubs/xen-stub.c +++ b/accel/stubs/xen-stub.c @@ -9,6 +9,8 @@ #include "hw/xen/xen.h" #include "qapi/qapi-commands-misc.h" +bool xen_allowed; + void xenstore_store_pv_console_info(int i, Chardev *chr) { } diff --git a/accel/xen/xen-all.c b/accel/xen/xen-all.c index 0c24d4b191..60b971d0a8 100644 --- a/accel/xen/xen-all.c +++ b/accel/xen/xen-all.c @@ -32,12 +32,7 @@ do { } while (0) #endif -static bool xen_allowed; - -bool xen_enabled(void) -{ - return xen_allowed; -} +bool xen_allowed; xc_interface *xen_xc; xenforeignmemory_handle *xen_fmem; -- 2.21.3 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 07:57:40 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 07:57:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2rpH-0001sQ-TI; Tue, 04 Aug 2020 07:57:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2rpG-0001sL-Ge for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 07:57:34 +0000 X-Inumbo-ID: 270839d4-d628-11ea-9134-bc764e2007e4 Received: from mail-wr1-x441.google.com (unknown [2a00:1450:4864:20::441]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 270839d4-d628-11ea-9134-bc764e2007e4; Tue, 04 Aug 2020 07:57:33 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id a14so36482280wra.5 for ; Tue, 04 Aug 2020 00:57:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:content-language :thread-index; bh=vvQsoFHR2+DeaNoRp6DMvUWjuYGvhITErRMiUFGaDog=; b=dRYw/T0yqo5tl0bDOFShRYSS6Qf3gjZEgMUmriHTzgnKjgLlSGhSdbJ5egLrYzbEpW kyJfO+uq4G3gnyQ0qxGkaHHZD0BfRoVzpJ7EamxfRuroAnSCec7bGONhnWOzQ0xGxrtG KFt4qpRaYMjrGRLyY+mNMBaD6JZjHiAcpOeCZ3HbBPrnaEfz+lKfxI/bxdJirJW2Mzs2 NFsKPMrLeT1vF5+ocVSwE2mCzRbLmZSK3iJboY+lEDqGYM/jFVi6CKGTDs0vUxnkWaHT pPtVo7tkVeJxSSFk9mTnY5wDIgIkouKaTx/GM7CMggRADoOZ7inEVmtPXlii3Hmplx16 Vm8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:to:cc:references:in-reply-to :subject:date:message-id:mime-version:content-transfer-encoding :content-language:thread-index; bh=vvQsoFHR2+DeaNoRp6DMvUWjuYGvhITErRMiUFGaDog=; b=P9Ovm3Bf65/rsPIyRtbyjxf+GbfFVvwuBqpF/KdaZZOpGu/gI2esGVeMdJjo3Lm3C0 EHg9WJ/NaCzviq68jbPuUaQAQK/+43Whdu6WH8pIziHXhBJo0t+gHG/WnFl3oJ7TRqfa yiv8JuUe/HqvVhmwFwpZsWmszmb4eAYqE0xPYsDuaoQnufzMr2kNxU64zm8m+COA33Aj H4eM3Tz5wumTb3TA/TXP4FQ0oJG/qTtgW2ZhK/SeIKJRWlabHp4afUaEaZgsELi+a1tA 2zDD8pUda82F7uWo4w1HuYLXr666LyNOpKFHlsncPGU0dG1by0y+BKmCqLbrS4+BxN5Q bNWg== X-Gm-Message-State: AOAM5319qZlz9+IFQu1FRkAtUQl0asaC9MxM/LnScqICNtnP2BGz6vw4 VkSPMp8vBNjKmUs64NsEw/w= X-Google-Smtp-Source: ABdhPJz5q55RXy9x8zNWsppP9ibasWEC4DANgO7R8btCtThODKtR27kGUGJdBZeIVcEjiBsemuaUpw== X-Received: by 2002:adf:ef92:: with SMTP id d18mr19684984wro.71.1596527852677; Tue, 04 Aug 2020 00:57:32 -0700 (PDT) Received: from CBGR90WXYV0 ([2a00:23c5:5785:9a01:9005:cf07:3ece:ca77]) by smtp.gmail.com with ESMTPSA id r3sm2114782wro.1.2020.08.04.00.57.31 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Aug 2020 00:57:32 -0700 (PDT) From: Paul Durrant X-Google-Original-From: "Paul Durrant" To: =?utf-8?Q?'Philippe_Mathieu-Daud=C3=A9'?= , References: <20200804074930.13104-1-philmd@redhat.com> <20200804074930.13104-2-philmd@redhat.com> In-Reply-To: <20200804074930.13104-2-philmd@redhat.com> Subject: RE: [PATCH-for-5.1 v2 1/1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects Date: Tue, 4 Aug 2020 08:57:31 +0100 Message-ID: <001201d66a34$e82ec070$b88c4150$@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Content-Language: en-gb Thread-Index: AQM/xXTZtf+c9Zv1otz4aIX099Jj8gDx5jXApk1PJBA= X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: paul@xen.org Cc: 'Peter Maydell' , 'Stefano Stabellini' , 'Paul Durrant' , 'Paolo Bonzini' , 'Anthony Perard' , xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" > -----Original Message----- > From: Philippe Mathieu-Daud=C3=A9 > Sent: 04 August 2020 08:50 > To: qemu-devel@nongnu.org > Cc: Peter Maydell ; Anthony Perard = ; Paolo > Bonzini ; Stefano Stabellini = ; xen- > devel@lists.xenproject.org; Paul Durrant ; Philippe = Mathieu-Daud=C3=A9 ; > Paul Durrant > Subject: [PATCH-for-5.1 v2 1/1] accel/xen: Fix xen_enabled() behavior = on target-agnostic objects >=20 > CONFIG_XEN is generated by configure and stored in "config-target.h", > which is (obviously) only include for target-specific objects. > This is a problem for target-agnostic objects as CONFIG_XEN is never > defined and xen_enabled() is always inlined as 'false'. >=20 > Fix by following the KVM schema, defining CONFIG_XEN_IS_POSSIBLE > when we don't know to force the call of the non-inlined function, > returning the xen_allowed boolean. >=20 > Fixes: da278d58a092 ("accel: Move Xen accelerator code under = accel/xen/") > Reported-by: Paul Durrant > Suggested-by: Peter Maydell > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > include/sysemu/xen.h | 18 ++++++++++++++---- > accel/stubs/xen-stub.c | 2 ++ > accel/xen/xen-all.c | 7 +------ > 3 files changed, 17 insertions(+), 10 deletions(-) >=20 > diff --git a/include/sysemu/xen.h b/include/sysemu/xen.h > index 1ca292715e..2c2c429ea8 100644 > --- a/include/sysemu/xen.h > +++ b/include/sysemu/xen.h > @@ -8,9 +8,19 @@ > #ifndef SYSEMU_XEN_H > #define SYSEMU_XEN_H >=20 > -#ifdef CONFIG_XEN > +#ifdef NEED_CPU_H > +# ifdef CONFIG_XEN > +# define CONFIG_XEN_IS_POSSIBLE > +# endif > +#else > +# define CONFIG_XEN_IS_POSSIBLE > +#endif >=20 > -bool xen_enabled(void); > +#ifdef CONFIG_XEN_IS_POSSIBLE > + > +extern bool xen_allowed; > + > +#define xen_enabled() (xen_allowed) Can this not move ahead of the #ifdef now (since xen_allowed is present = in both xen-stub and xen-all)? I think this is what Peter was saying in = his option '(2)'. Paul >=20 > #ifndef CONFIG_USER_ONLY > void xen_hvm_modified_memory(ram_addr_t start, ram_addr_t length); > @@ -18,7 +28,7 @@ void xen_ram_alloc(ram_addr_t ram_addr, ram_addr_t = size, > struct MemoryRegion *mr, Error **errp); > #endif >=20 > -#else /* !CONFIG_XEN */ > +#else /* !CONFIG_XEN_IS_POSSIBLE */ >=20 > #define xen_enabled() 0 > #ifndef CONFIG_USER_ONLY > @@ -33,6 +43,6 @@ static inline void xen_ram_alloc(ram_addr_t = ram_addr, ram_addr_t size, > } > #endif >=20 > -#endif /* CONFIG_XEN */ > +#endif /* CONFIG_XEN_IS_POSSIBLE */ >=20 > #endif > diff --git a/accel/stubs/xen-stub.c b/accel/stubs/xen-stub.c > index dcca4e678a..8ae658acff 100644 > --- a/accel/stubs/xen-stub.c > +++ b/accel/stubs/xen-stub.c > @@ -9,6 +9,8 @@ > #include "hw/xen/xen.h" > #include "qapi/qapi-commands-misc.h" >=20 > +bool xen_allowed; > + > void xenstore_store_pv_console_info(int i, Chardev *chr) > { > } > diff --git a/accel/xen/xen-all.c b/accel/xen/xen-all.c > index 0c24d4b191..60b971d0a8 100644 > --- a/accel/xen/xen-all.c > +++ b/accel/xen/xen-all.c > @@ -32,12 +32,7 @@ > do { } while (0) > #endif >=20 > -static bool xen_allowed; > - > -bool xen_enabled(void) > -{ > - return xen_allowed; > -} > +bool xen_allowed; >=20 > xc_interface *xen_xc; > xenforeignmemory_handle *xen_fmem; > -- > 2.21.3 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 08:35:02 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 08:35:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2sPK-0005r9-I7; Tue, 04 Aug 2020 08:34:50 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2sPK-0005r4-0C for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 08:34:50 +0000 X-Inumbo-ID: 5b3f0d22-d62d-11ea-b01c-12813bfff9fa Received: from us-smtp-delivery-1.mimecast.com (unknown [205.139.110.61]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 5b3f0d22-d62d-11ea-b01c-12813bfff9fa; Tue, 04 Aug 2020 08:34:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596530088; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qD/CeeZrbqIkgE83qE1EJDNBaCSUEFE64uJULaVnxnU=; b=OJAl3Y7jV6p0X6XOvu17rjqQvaNZ/Aou5oD1blX+8QOXMJqBHYkIQhozY0ILfkUyFZAVIF 6sXP1mXe2EC6AlXqNSouIqidllDxWCDumF0Q0sPESxQp5p/dbw1Podac7YslbnRW5Qx/dx nniGrHX8/jVtPbmI9B4tmDskXWTi3no= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-188-SJuPsT4uOx6Kh8aahEsxAA-1; Tue, 04 Aug 2020 04:34:46 -0400 X-MC-Unique: SJuPsT4uOx6Kh8aahEsxAA-1 Received: by mail-ej1-f72.google.com with SMTP id lg2so10542758ejb.23 for ; Tue, 04 Aug 2020 01:34:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=qD/CeeZrbqIkgE83qE1EJDNBaCSUEFE64uJULaVnxnU=; b=C8tUC3pKsXWWmNekQe1VxKFwbKMNCEOALrCCWreMwa6Q0Q1y8iDiqa4sL5l75e856b BxINx2hyAzBiNyWrHQooFclmGROZqeSNl5nYwYgDUDdQJ1tQ93YVHWYrJ8fx6ReWqYh/ XRe553YC+J5toxhq3y8PSgcNUOCIiRyi6gMEh/44jMWyxs6iivGA9eEjEqDsGdazzaqJ MrB78eLWdcPL154msEKTK6WaPCUhXY4d1bvAa/UID8w6q6Wfandr84DrHoiskrBMMRK+ d6qaimlbCy44YXCVcjzj6Db2kq3IUt6KmApcROhtMmJu5Qy0LGBB3JMCPk7KmCcY7WM3 Jn4Q== X-Gm-Message-State: AOAM532WTijbXbJJDYt4eNkKeAJFkEzB2aiG2FMcvgb/SWOAHEB8wG9K CC2E47o3sIh+Ir/+x7LU15b0Er8kmQz+o0Xl6h+CP9syY4pJsLCgo9Vos34x7y3dtfFVDqTUfWL X/HbFBeNtvt6FWgL8wtDYaOVFI3U= X-Received: by 2002:a05:6402:1a54:: with SMTP id bf20mr19573314edb.217.1596530085186; Tue, 04 Aug 2020 01:34:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxcPFG6nWYYGYKd1IYh4XRaBTvM1zmuSGq2bzNjsP1QuA5gXXRyHlNYGm5sTx/gM2BJ1aCXoA== X-Received: by 2002:a05:6402:1a54:: with SMTP id bf20mr19573296edb.217.1596530084967; Tue, 04 Aug 2020 01:34:44 -0700 (PDT) Received: from [192.168.1.43] (214.red-88-21-68.staticip.rima-tde.net. [88.21.68.214]) by smtp.gmail.com with ESMTPSA id dk28sm18329770edb.90.2020.08.04.01.34.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2020 01:34:44 -0700 (PDT) Subject: Re: [PATCH-for-5.1 v2 1/1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects To: paul@xen.org, qemu-devel@nongnu.org References: <20200804074930.13104-1-philmd@redhat.com> <20200804074930.13104-2-philmd@redhat.com> <001201d66a34$e82ec070$b88c4150$@xen.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Autocrypt: addr=philmd@redhat.com; keydata= mQINBDXML8YBEADXCtUkDBKQvNsQA7sDpw6YLE/1tKHwm24A1au9Hfy/OFmkpzo+MD+dYc+7 bvnqWAeGweq2SDq8zbzFZ1gJBd6+e5v1a/UrTxvwBk51yEkadrpRbi+r2bDpTJwXc/uEtYAB GvsTZMtiQVA4kRID1KCdgLa3zztPLCj5H1VZhqZsiGvXa/nMIlhvacRXdbgllPPJ72cLUkXf z1Zu4AkEKpccZaJspmLWGSzGu6UTZ7UfVeR2Hcc2KI9oZB1qthmZ1+PZyGZ/Dy+z+zklC0xl XIpQPmnfy9+/1hj1LzJ+pe3HzEodtlVA+rdttSvA6nmHKIt8Ul6b/h1DFTmUT1lN1WbAGxmg CH1O26cz5nTrzdjoqC/b8PpZiT0kO5MKKgiu5S4PRIxW2+RA4H9nq7nztNZ1Y39bDpzwE5Sp bDHzd5owmLxMLZAINtCtQuRbSOcMjZlg4zohA9TQP9krGIk+qTR+H4CV22sWldSkVtsoTaA2 qNeSJhfHQY0TyQvFbqRsSNIe2gTDzzEQ8itsmdHHE/yzhcCVvlUzXhAT6pIN0OT+cdsTTfif MIcDboys92auTuJ7U+4jWF1+WUaJ8gDL69ThAsu7mGDBbm80P3vvUZ4fQM14NkxOnuGRrJxO qjWNJ2ZUxgyHAh5TCxMLKWZoL5hpnvx3dF3Ti9HW2dsUUWICSQARAQABtDJQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSAoUGhpbCkgPHBoaWxtZEByZWRoYXQuY29tPokCVQQTAQgAPwIbDwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQSJweePYB7obIZ0lcuio/1u3q3A3gUCXsfWwAUJ KtymWgAKCRCio/1u3q3A3ircD/9Vjh3aFNJ3uF3hddeoFg1H038wZr/xi8/rX27M1Vj2j9VH 0B8Olp4KUQw/hyO6kUxqkoojmzRpmzvlpZ0cUiZJo2bQIWnvScyHxFCv33kHe+YEIqoJlaQc JfKYlbCoubz+02E2A6bFD9+BvCY0LBbEj5POwyKGiDMjHKCGuzSuDRbCn0Mz4kCa7nFMF5Jv piC+JemRdiBd6102ThqgIsyGEBXuf1sy0QIVyXgaqr9O2b/0VoXpQId7yY7OJuYYxs7kQoXI 6WzSMpmuXGkmfxOgbc/L6YbzB0JOriX0iRClxu4dEUg8Bs2pNnr6huY2Ft+qb41RzCJvvMyu gS32LfN0bTZ6Qm2A8ayMtUQgnwZDSO23OKgQWZVglGliY3ezHZ6lVwC24Vjkmq/2yBSLakZE 6DZUjZzCW1nvtRK05ebyK6tofRsx8xB8pL/kcBb9nCuh70aLR+5cmE41X4O+MVJbwfP5s/RW 9BFSL3qgXuXso/3XuWTQjJJGgKhB6xXjMmb1J4q/h5IuVV4juv1Fem9sfmyrh+Wi5V1IzKI7 RPJ3KVb937eBgSENk53P0gUorwzUcO+ASEo3Z1cBKkJSPigDbeEjVfXQMzNt0oDRzpQqH2vp apo2jHnidWt8BsckuWZpxcZ9+/9obQ55DyVQHGiTN39hkETy3Emdnz1JVHTU0Q== Message-ID: <56c70b44-2d5f-44fc-5d9a-535c3c5fca71@redhat.com> Date: Tue, 4 Aug 2020 10:34:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <001201d66a34$e82ec070$b88c4150$@xen.org> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: 'Peter Maydell' , 'Stefano Stabellini' , 'Paul Durrant' , 'Paolo Bonzini' , 'Anthony Perard' , xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Hi Paul, On 8/4/20 9:57 AM, Paul Durrant wrote: >> -----Original Message----- >> From: Philippe Mathieu-Daudé >> Sent: 04 August 2020 08:50 >> To: qemu-devel@nongnu.org >> Cc: Peter Maydell ; Anthony Perard ; Paolo >> Bonzini ; Stefano Stabellini ; xen- >> devel@lists.xenproject.org; Paul Durrant ; Philippe Mathieu-Daudé ; >> Paul Durrant >> Subject: [PATCH-for-5.1 v2 1/1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects >> >> CONFIG_XEN is generated by configure and stored in "config-target.h", >> which is (obviously) only include for target-specific objects. >> This is a problem for target-agnostic objects as CONFIG_XEN is never >> defined and xen_enabled() is always inlined as 'false'. >> >> Fix by following the KVM schema, defining CONFIG_XEN_IS_POSSIBLE >> when we don't know to force the call of the non-inlined function, >> returning the xen_allowed boolean. >> >> Fixes: da278d58a092 ("accel: Move Xen accelerator code under accel/xen/") >> Reported-by: Paul Durrant >> Suggested-by: Peter Maydell >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> include/sysemu/xen.h | 18 ++++++++++++++---- >> accel/stubs/xen-stub.c | 2 ++ >> accel/xen/xen-all.c | 7 +------ >> 3 files changed, 17 insertions(+), 10 deletions(-) >> >> diff --git a/include/sysemu/xen.h b/include/sysemu/xen.h >> index 1ca292715e..2c2c429ea8 100644 >> --- a/include/sysemu/xen.h >> +++ b/include/sysemu/xen.h >> @@ -8,9 +8,19 @@ >> #ifndef SYSEMU_XEN_H >> #define SYSEMU_XEN_H >> >> -#ifdef CONFIG_XEN >> +#ifdef NEED_CPU_H >> +# ifdef CONFIG_XEN >> +# define CONFIG_XEN_IS_POSSIBLE >> +# endif >> +#else >> +# define CONFIG_XEN_IS_POSSIBLE >> +#endif >> >> -bool xen_enabled(void); >> +#ifdef CONFIG_XEN_IS_POSSIBLE >> + >> +extern bool xen_allowed; >> + >> +#define xen_enabled() (xen_allowed) > > Can this not move ahead of the #ifdef now (since xen_allowed is present in both xen-stub and xen-all)? I think this is what Peter was saying in his option '(2)'. I think I respected Peter's option '(2)', following how KVM does, this is the case with stub, > > Paul > >> >> #ifndef CONFIG_USER_ONLY >> void xen_hvm_modified_memory(ram_addr_t start, ram_addr_t length); >> @@ -18,7 +28,7 @@ void xen_ram_alloc(ram_addr_t ram_addr, ram_addr_t size, >> struct MemoryRegion *mr, Error **errp); >> #endif >> >> -#else /* !CONFIG_XEN */ >> +#else /* !CONFIG_XEN_IS_POSSIBLE */ >> >> #define xen_enabled() 0 ^^^ here is the other case, >> #ifndef CONFIG_USER_ONLY >> @@ -33,6 +43,6 @@ static inline void xen_ram_alloc(ram_addr_t ram_addr, ram_addr_t size, >> } >> #endif >> >> -#endif /* CONFIG_XEN */ >> +#endif /* CONFIG_XEN_IS_POSSIBLE */ >> >> #endif >> diff --git a/accel/stubs/xen-stub.c b/accel/stubs/xen-stub.c >> index dcca4e678a..8ae658acff 100644 >> --- a/accel/stubs/xen-stub.c >> +++ b/accel/stubs/xen-stub.c >> @@ -9,6 +9,8 @@ >> #include "hw/xen/xen.h" >> #include "qapi/qapi-commands-misc.h" >> >> +bool xen_allowed; here is the stub, >> + >> void xenstore_store_pv_console_info(int i, Chardev *chr) >> { >> } >> diff --git a/accel/xen/xen-all.c b/accel/xen/xen-all.c >> index 0c24d4b191..60b971d0a8 100644 >> --- a/accel/xen/xen-all.c >> +++ b/accel/xen/xen-all.c >> @@ -32,12 +32,7 @@ >> do { } while (0) >> #endif >> >> -static bool xen_allowed; >> - >> -bool xen_enabled(void) >> -{ >> - return xen_allowed; >> -} >> +bool xen_allowed; here is the real variable. >> >> xc_interface *xen_xc; >> xenforeignmemory_handle *xen_fmem; >> -- >> 2.21.3 > > From xen-devel-bounces@lists.xenproject.org Tue Aug 04 08:37:21 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 08:37:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2sRl-0005yU-0L; Tue, 04 Aug 2020 08:37:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2sRj-0005yO-HX for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 08:37:19 +0000 X-Inumbo-ID: b485878a-d62d-11ea-9139-bc764e2007e4 Received: from mail-wm1-x344.google.com (unknown [2a00:1450:4864:20::344]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b485878a-d62d-11ea-9139-bc764e2007e4; Tue, 04 Aug 2020 08:37:18 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id g8so1883342wmk.3 for ; Tue, 04 Aug 2020 01:37:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:content-language :thread-index; bh=/nPyjZI9KV5I3szUDlWxSRO5+QFYlS+dHOy2SDtIKYI=; b=oXCdsQSipocZ1Yj1Isdzk6UckuRU8rqJ8m72XxMh7ClA1lkM7ZZ/YtrcvF+wSV2JA9 tfvYAPBB3QCV1swMVvJcTmH4pzwPi3u1IL57yvrfuyBPhK7Atgx9l2DQCs5+67gy+yax MQqyOHDHEHyP1Eb1GfsYWjNqYl2rwQaBKpCdoxmLIv5Fy+RZ56CHnEnlY3EIa9nYuG0j xMISVEuZSlfzMjwK0R2+Vw19VyTukis4CZWYA9LTofVUwOEhYSFqTV129ahtxQoBe+dZ hOPA0SdI8aPTbYTO6vGyI766ZsiKzSXkuz3KjohPfirrSRvh7nb3Wnbgq//oIVc5jUbt k0Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:to:cc:references:in-reply-to :subject:date:message-id:mime-version:content-transfer-encoding :content-language:thread-index; bh=/nPyjZI9KV5I3szUDlWxSRO5+QFYlS+dHOy2SDtIKYI=; b=Rib+dFfvnb0S2/y8IZcwr0bTOvyzYD7fOg7Hra/HkqXXPqOiFeftsmTbcYE0JF1Dzp 1oomeHohc0uVi2hXXuYk3t4QanDPM+/84lbfGUDPDdz75YSatschpnitE6bnCB1LukRs arHaUF7ZSnPfNN2rKpumqi+iL2yoEoW51U60T5cZqKT2WXhr/rdjDJwotmayyWHskBkr UJZT/7rQR6djZ7R3aIazG9jS5Z30qYEaywHNfuMLcZK2l1pvpjEOpjfK/nsFPXGaMfSe ySxOoPNwHm9r/Dqyca4nMRtNAyJFuOf1dzKVmXDH9VIUmvobL8xdNC4QYDPuB3Y4Kn5y eZHg== X-Gm-Message-State: AOAM533XFfAchNv325hOqUvYoLP+sbXZIBnkAvSjY905JvV/uhXbkqkH lF2VPvGa7yZdWW7RX4L+PG8= X-Google-Smtp-Source: ABdhPJzDapD/UdsRWGR4kmZkbCsJ5WPWtzEotAYMzUckkcs3AVBwHialxx4/CVNRuy1BJy6inh5O0Q== X-Received: by 2002:a1c:80c1:: with SMTP id b184mr3197422wmd.121.1596530237540; Tue, 04 Aug 2020 01:37:17 -0700 (PDT) Received: from CBGR90WXYV0 ([2a00:23c5:5785:9a01:ad9a:ab78:5748:a7ec]) by smtp.gmail.com with ESMTPSA id r22sm3644644wmh.45.2020.08.04.01.37.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Aug 2020 01:37:17 -0700 (PDT) From: Paul Durrant X-Google-Original-From: "Paul Durrant" To: =?utf-8?Q?'Philippe_Mathieu-Daud=C3=A9'?= , References: <20200804074930.13104-1-philmd@redhat.com> <20200804074930.13104-2-philmd@redhat.com> <001201d66a34$e82ec070$b88c4150$@xen.org> <56c70b44-2d5f-44fc-5d9a-535c3c5fca71@redhat.com> In-Reply-To: <56c70b44-2d5f-44fc-5d9a-535c3c5fca71@redhat.com> Subject: RE: [PATCH-for-5.1 v2 1/1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects Date: Tue, 4 Aug 2020 09:37:16 +0100 Message-ID: <001301d66a3a$75ac6c90$610545b0$@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Content-Language: en-gb Thread-Index: AQM/xXTZtf+c9Zv1otz4aIX099Jj8gDx5jXAAVRtvfwA7Pf4CaY7T1ag X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: paul@xen.org Cc: 'Peter Maydell' , 'Stefano Stabellini' , 'Paul Durrant' , 'Paolo Bonzini' , 'Anthony Perard' , xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" > -----Original Message----- > From: Philippe Mathieu-Daud=C3=A9 > Sent: 04 August 2020 09:35 > To: paul@xen.org; qemu-devel@nongnu.org > Cc: 'Peter Maydell' ; 'Anthony Perard' = ; 'Paolo > Bonzini' ; 'Stefano Stabellini' = ; xen- > devel@lists.xenproject.org; 'Paul Durrant' > Subject: Re: [PATCH-for-5.1 v2 1/1] accel/xen: Fix xen_enabled() = behavior on target-agnostic objects >=20 > Hi Paul, >=20 > On 8/4/20 9:57 AM, Paul Durrant wrote: > >> -----Original Message----- > >> From: Philippe Mathieu-Daud=C3=A9 > >> Sent: 04 August 2020 08:50 > >> To: qemu-devel@nongnu.org > >> Cc: Peter Maydell ; Anthony Perard = ; Paolo > >> Bonzini ; Stefano Stabellini = ; xen- > >> devel@lists.xenproject.org; Paul Durrant ; Philippe = Mathieu-Daud=C3=A9 > ; > >> Paul Durrant > >> Subject: [PATCH-for-5.1 v2 1/1] accel/xen: Fix xen_enabled() = behavior on target-agnostic objects > >> > >> CONFIG_XEN is generated by configure and stored in = "config-target.h", > >> which is (obviously) only include for target-specific objects. > >> This is a problem for target-agnostic objects as CONFIG_XEN is = never > >> defined and xen_enabled() is always inlined as 'false'. > >> > >> Fix by following the KVM schema, defining CONFIG_XEN_IS_POSSIBLE > >> when we don't know to force the call of the non-inlined function, > >> returning the xen_allowed boolean. > >> > >> Fixes: da278d58a092 ("accel: Move Xen accelerator code under = accel/xen/") > >> Reported-by: Paul Durrant > >> Suggested-by: Peter Maydell > >> Signed-off-by: Philippe Mathieu-Daud=C3=A9 > >> --- > >> include/sysemu/xen.h | 18 ++++++++++++++---- > >> accel/stubs/xen-stub.c | 2 ++ > >> accel/xen/xen-all.c | 7 +------ > >> 3 files changed, 17 insertions(+), 10 deletions(-) > >> > >> diff --git a/include/sysemu/xen.h b/include/sysemu/xen.h > >> index 1ca292715e..2c2c429ea8 100644 > >> --- a/include/sysemu/xen.h > >> +++ b/include/sysemu/xen.h > >> @@ -8,9 +8,19 @@ > >> #ifndef SYSEMU_XEN_H > >> #define SYSEMU_XEN_H > >> > >> -#ifdef CONFIG_XEN > >> +#ifdef NEED_CPU_H > >> +# ifdef CONFIG_XEN > >> +# define CONFIG_XEN_IS_POSSIBLE > >> +# endif > >> +#else > >> +# define CONFIG_XEN_IS_POSSIBLE > >> +#endif > >> > >> -bool xen_enabled(void); > >> +#ifdef CONFIG_XEN_IS_POSSIBLE > >> + > >> +extern bool xen_allowed; > >> + > >> +#define xen_enabled() (xen_allowed) > > > > Can this not move ahead of the #ifdef now (since xen_allowed is = present in both xen-stub and xen- > all)? I think this is what Peter was saying in his option '(2)'. >=20 > I think I respected Peter's option '(2)', following how KVM does, this > is the case with stub, Ok, if it follows the KVM pattern then that's fine. Reviewed-by: Paul Durrant From xen-devel-bounces@lists.xenproject.org Tue Aug 04 09:21:17 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 09:21:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2t7v-0001hV-DM; Tue, 04 Aug 2020 09:20:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2t7u-0001hQ-4U for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 09:20:54 +0000 X-Inumbo-ID: caf9ecc7-d633-11ea-913d-bc764e2007e4 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id caf9ecc7-d633-11ea-913d-bc764e2007e4; Tue, 04 Aug 2020 09:20:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596532853; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=0YqTm8Wb4K9XKQSC3g7togEL7aTIVm8AWDi9Gqx1kAM=; b=UEg12rMbo32BIeHedpZGvJ3+JQcQsmhQx1KWumEQykjzWCevLq2an2zT CXSG5Lh4fLdz1qby6eFyKywcsE463UM3zimECjqLQ+0Ynk+aC9opw2oni jbaqyiTuVx7ug66sUOHOapPvkVJH0OYz1xgnfcdzfyQqs3yVFCfe7WkPV w=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: mkDWYMpTe+0YcZjSXoM1iQw9PH9oKlyIwnALZB6VQtHcM6CZaDUcTXIHCRsqEG3ZKKltbNlDTM 1rTHpAFUWv/H+304+vK+T+YFCHdmDGPS44Eapvr+bZuzWNSlB4Mm62nXaSGKDaD3Th6YcxTHrJ E//VA8AsDwSQTMd5EbmQmj29guus6D0GiOfFIEakEO6NvXPqzZcYDEZxDyfPSUdTgTUey6NAeU eahzJ+HREgk6DNOHwvldFqoPAPJ2MCKgBPeoQwrb+mx+qb6q1U0iwX+YLM8Zh9lLmvGYMuLU68 skI= X-SBRS: 3.7 X-MesageID: 23979240 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,433,1589256000"; d="scan'208";a="23979240" Date: Tue, 4 Aug 2020 10:20:48 +0100 From: Anthony PERARD To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH-for-5.1 v2 1/1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects Message-ID: <20200804092048.GE2866@perard.uk.xensource.com> References: <20200804074930.13104-1-philmd@redhat.com> <20200804074930.13104-2-philmd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200804074930.13104-2-philmd@redhat.com> X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Stefano Stabellini , Paul Durrant , Paul Durrant , qemu-devel@nongnu.org, Paolo Bonzini , xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Tue, Aug 04, 2020 at 09:49:30AM +0200, Philippe Mathieu-Daud wrote: > CONFIG_XEN is generated by configure and stored in "config-target.h", > which is (obviously) only include for target-specific objects. > This is a problem for target-agnostic objects as CONFIG_XEN is never > defined and xen_enabled() is always inlined as 'false'. > > Fix by following the KVM schema, defining CONFIG_XEN_IS_POSSIBLE > when we don't know to force the call of the non-inlined function, > returning the xen_allowed boolean. > > Fixes: da278d58a092 ("accel: Move Xen accelerator code under accel/xen/") > Reported-by: Paul Durrant > Suggested-by: Peter Maydell > Signed-off-by: Philippe Mathieu-Daud Reviewed-by: Anthony PERARD This time, I've also check that build all targets works... I'll prepare the pull request right away. Thank you, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Aug 04 09:26:36 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 09:26:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2tDN-0001sk-1r; Tue, 04 Aug 2020 09:26:33 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2tDM-0001sf-DF for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 09:26:32 +0000 X-Inumbo-ID: 86032adc-4d69-477a-a118-c0ab5446eb94 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 86032adc-4d69-477a-a118-c0ab5446eb94; Tue, 04 Aug 2020 09:26:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596533191; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=BGtV4buQLSV4kVsmhw15UWdyjLxZS1wmHPQnT8rh4jE=; b=L9k1eWw6zNvMJQh+TF0r5ZQwzsL/avFvCL7k2NSLVa76x4vzhdjj52+u 3hv1dfAXJGC8zeBjVt1EJkjy+TrYTTxccAKPweJyFUluAUJYHz4zayVyA tKRhmWYWLeeVSmLRgexqzu1j7wDF375vd+IAMbpzTz39DrK/FAehW2Yaq Q=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 186U1PMTFN/6mFC++GOTqG77LsGWlYBb5SaonSm0/OhiP55JNb3TbJV9WIGWBcsA2EzDXE7EcR ZKeELt/7IBjcwB48D0IjIvy36wydjXxWJ8gmdCvuvT4fVCoPp5hu8e8YQgle6nIdF33xB9aiVQ g6t2T5HRpE8QYtyX/Xjo7oVrXl8aEoC/5BIYIQOdsatvvlVU9QsNo4+3UaLQhA3GerGUMlI0iz QVd/rm+VE6TwOGp2eoHUD8km/jI2Ed8Lz77C4ri2Rbrv8cFG3zrZjA44Pt8vQTHO420qV5AJzr se4= X-SBRS: 3.7 X-MesageID: 23979476 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,433,1589256000"; d="scan'208";a="23979476" From: Anthony PERARD To: Subject: [PULL 0/1] xen queue 2020-08-04 Date: Tue, 4 Aug 2020 10:26:23 +0100 Message-ID: <20200804092624.1126013-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony PERARD , Peter Maydell , xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" The following changes since commit 5c1c3e4f02e458cf280c677c817ae4fd1ed9bf10: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20200803' into staging (2020-08-03 20:34:26 +0100) are available in the Git repository at: https://xenbits.xen.org/git-http/people/aperard/qemu-dm.git tags/pull-xen-20200804 for you to fetch changes up to 8e0ef068942e4152f0d23e76ca1f5e35dc4456f7: accel/xen: Fix xen_enabled() behavior on target-agnostic objects (2020-08-04 10:21:35 +0100) ---------------------------------------------------------------- xen patch Bug fix. ---------------------------------------------------------------- Philippe Mathieu-Daudé (1): accel/xen: Fix xen_enabled() behavior on target-agnostic objects accel/stubs/xen-stub.c | 2 ++ accel/xen/xen-all.c | 7 +------ include/sysemu/xen.h | 18 ++++++++++++++---- 3 files changed, 17 insertions(+), 10 deletions(-) From xen-devel-bounces@lists.xenproject.org Tue Aug 04 09:26:37 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 09:26:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2tDP-0001sz-9l; Tue, 04 Aug 2020 09:26:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2tDO-0001sq-72 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 09:26:34 +0000 X-Inumbo-ID: 95bd8dc8-d634-11ea-913d-bc764e2007e4 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 95bd8dc8-d634-11ea-913d-bc764e2007e4; Tue, 04 Aug 2020 09:26:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596533193; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=q3ReqT69K9XKGGN+e8ZybiqO+/keDcz0thRqBcGSR3M=; b=SPB5k+Bhaw6JKzIojmQekE7L76rVDNoAbAPHQ61jksNJlb3zAkfbEBtP WGtemK6cDprR+IK5/vZqYwGURx59fFougDPKqHewAGZY8a8W80GQTEUFC FgyJ7HFDiJxwH4xhlaQK7u+KT6U3GpUZXvnTHrsSh50LJ4DW83ZYru2iT I=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: Eq+gN6YFmS3ohlQqKPhOe2NcoL+vSDTiKtV8jXYqR+o7M3gFioVAeSG2I1hriVOiye0+/6X/8h OqfLandO1LO14rrROu8L9enqiFcL2gLkDkVY+0SVwQ6ouPLhjJ41HSoB/Qi0BogF5/OcytdetB mIxVAeP0V93Qzse3rdr+TlFOhU7KTCfEYYrsOz+4vM5iLXQmyRRmWkuGRVB86HgBJEBdrB0JOH +TH3asiD+AJ9QUYIWOd4nz/Tv3VItzy03bKZLluN7MhPuT0A74mPOv+nNCXvrOKAsNJs2wTgDE 6C4= X-SBRS: 3.7 X-MesageID: 24124488 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,433,1589256000"; d="scan'208";a="24124488" From: Anthony PERARD To: Subject: [PULL 1/1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects Date: Tue, 4 Aug 2020 10:26:24 +0100 Message-ID: <20200804092624.1126013-2-anthony.perard@citrix.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200804092624.1126013-1-anthony.perard@citrix.com> References: <20200804092624.1126013-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony PERARD , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Philippe Mathieu-Daudé CONFIG_XEN is generated by configure and stored in "config-target.h", which is (obviously) only include for target-specific objects. This is a problem for target-agnostic objects as CONFIG_XEN is never defined and xen_enabled() is always inlined as 'false'. Fix by following the KVM schema, defining CONFIG_XEN_IS_POSSIBLE when we don't know to force the call of the non-inlined function, returning the xen_allowed boolean. Fixes: da278d58a092 ("accel: Move Xen accelerator code under accel/xen/") Reported-by: Paul Durrant Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Paul Durrant Reviewed-by: Anthony PERARD Message-Id: <20200804074930.13104-2-philmd@redhat.com> Signed-off-by: Anthony PERARD --- accel/stubs/xen-stub.c | 2 ++ accel/xen/xen-all.c | 7 +------ include/sysemu/xen.h | 18 ++++++++++++++---- 3 files changed, 17 insertions(+), 10 deletions(-) diff --git a/accel/stubs/xen-stub.c b/accel/stubs/xen-stub.c index dcca4e678a13..8ae658acff5f 100644 --- a/accel/stubs/xen-stub.c +++ b/accel/stubs/xen-stub.c @@ -9,6 +9,8 @@ #include "hw/xen/xen.h" #include "qapi/qapi-commands-misc.h" +bool xen_allowed; + void xenstore_store_pv_console_info(int i, Chardev *chr) { } diff --git a/accel/xen/xen-all.c b/accel/xen/xen-all.c index 0c24d4b191a4..60b971d0a82f 100644 --- a/accel/xen/xen-all.c +++ b/accel/xen/xen-all.c @@ -32,12 +32,7 @@ do { } while (0) #endif -static bool xen_allowed; - -bool xen_enabled(void) -{ - return xen_allowed; -} +bool xen_allowed; xc_interface *xen_xc; xenforeignmemory_handle *xen_fmem; diff --git a/include/sysemu/xen.h b/include/sysemu/xen.h index 1ca292715e69..2c2c429ea8bf 100644 --- a/include/sysemu/xen.h +++ b/include/sysemu/xen.h @@ -8,9 +8,19 @@ #ifndef SYSEMU_XEN_H #define SYSEMU_XEN_H -#ifdef CONFIG_XEN +#ifdef NEED_CPU_H +# ifdef CONFIG_XEN +# define CONFIG_XEN_IS_POSSIBLE +# endif +#else +# define CONFIG_XEN_IS_POSSIBLE +#endif + +#ifdef CONFIG_XEN_IS_POSSIBLE + +extern bool xen_allowed; -bool xen_enabled(void); +#define xen_enabled() (xen_allowed) #ifndef CONFIG_USER_ONLY void xen_hvm_modified_memory(ram_addr_t start, ram_addr_t length); @@ -18,7 +28,7 @@ void xen_ram_alloc(ram_addr_t ram_addr, ram_addr_t size, struct MemoryRegion *mr, Error **errp); #endif -#else /* !CONFIG_XEN */ +#else /* !CONFIG_XEN_IS_POSSIBLE */ #define xen_enabled() 0 #ifndef CONFIG_USER_ONLY @@ -33,6 +43,6 @@ static inline void xen_ram_alloc(ram_addr_t ram_addr, ram_addr_t size, } #endif -#endif /* CONFIG_XEN */ +#endif /* CONFIG_XEN_IS_POSSIBLE */ #endif -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Aug 04 09:37:05 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 09:37:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2tNP-0002tk-4g; Tue, 04 Aug 2020 09:36:55 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2tNO-0002tf-4o for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 09:36:54 +0000 X-Inumbo-ID: 78c85921-196b-437d-9fb0-e18aee3bf853 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 78c85921-196b-437d-9fb0-e18aee3bf853; Tue, 04 Aug 2020 09:36:52 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AAF9BAB55; Tue, 4 Aug 2020 09:37:07 +0000 (UTC) To: "xen-devel@lists.xenproject.org" From: Jan Beulich Subject: [PATCH] x86emul: further FPU env testing relaxation for AMD-like CPUs Message-ID: Date: Tue, 4 Aug 2020 11:36:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" See the code comment that's being extended. Additionally a few more zap_fpsel() invocations are needed - whenever we stored state after there potentially having been a context switch behind our backs. Reported-by: Andrew Cooper Signed-off-by: Jan Beulich --- a/tools/tests/x86_emulator/test_x86_emulator.c +++ b/tools/tests/x86_emulator/test_x86_emulator.c @@ -752,6 +752,13 @@ static struct x86_emulate_ops emulops = * 64-bit OSes may not (be able to) properly restore the two selectors in * the FPU environment. Zap them so that memcmp() on two saved images will * work regardless of whether a context switch occurred in the middle. + * + * Additionally on AMD-like CPUs FDP/FIP/FOP may get lost across context + * switches, when there's no unmasked pending FP exception: With + * CPUID[80000008].EBX[2] clear, the fields don't get written/read by + * {F,}XSAVE / {F,}XRSTOR, which OSes often compensate for by invoking an + * insn forcing the fields to gain a deterministic value. Whereas with said + * bit set, zeroes will get written (and hence later restored). */ static void zap_fpsel(unsigned int *env, bool is_32bit) { @@ -765,6 +772,21 @@ static void zap_fpsel(unsigned int *env, env[2] &= ~0xffff; env[3] &= ~0xffff; } + + if ( cp.x86_vendor != X86_VENDOR_AMD && cp.x86_vendor != X86_VENDOR_HYGON ) + return; + + if ( is_32bit ) + { + env[3] = 0; + env[4] = 0; + env[5] = 0; + } + else + { + env[1] &= 0xffff; + env[2] = 0; + } } static void zap_xfpsel(unsigned int *env) @@ -2460,6 +2482,7 @@ int main(int argc, char **argv) regs.edx = (unsigned long)res; rc = x86_emulate(&ctxt, &emulops); asm volatile ( "fnstenv %0" : "=m" (res[9]) :: "memory" ); + zap_fpsel(&res[9], true); if ( (rc != X86EMUL_OKAY) || memcmp(res + 2, res + 9, 28) || (regs.eip != (unsigned long)&instr[3]) ) @@ -2487,6 +2510,7 @@ int main(int argc, char **argv) res[23] = 0xaa55aa55; res[24] = 0xaa55aa55; rc = x86_emulate(&ctxt, &emulops); + zap_fpsel(&res[0], false); if ( (rc != X86EMUL_OKAY) || memcmp(res, res + 25, 94) || (res[23] >> 16) != 0xaa55 || @@ -2514,6 +2538,7 @@ int main(int argc, char **argv) regs.edx = (unsigned long)res; rc = x86_emulate(&ctxt, &emulops); asm volatile ( "fnsave %0" : "=m" (res[27]) :: "memory" ); + zap_fpsel(&res[27], true); if ( (rc != X86EMUL_OKAY) || memcmp(res, res + 27, 108) || (regs.eip != (unsigned long)&instr[2]) ) From xen-devel-bounces@lists.xenproject.org Tue Aug 04 10:14:05 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 10:14:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2txD-0006KK-1X; Tue, 04 Aug 2020 10:13:55 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2txB-0006Jo-Ib for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 10:13:53 +0000 X-Inumbo-ID: 419a531d-e690-4e6f-a276-00468615c287 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 419a531d-e690-4e6f-a276-00468615c287; Tue, 04 Aug 2020 10:13:52 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 86838B595; Tue, 4 Aug 2020 10:14:07 +0000 (UTC) To: "xen-devel@lists.xenproject.org" From: Jan Beulich Subject: [PATCH] x86emul: replace further UB shifts Message-ID: <0ae25858-f981-1552-0a3c-58a9733a758a@suse.com> Date: Tue, 4 Aug 2020 12:13:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" I have no explanation how I managed to overlook these while putting together what is now b6a907f8c83d ("x86emul: replace UB shifts"). Signed-off-by: Jan Beulich --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -9735,7 +9735,7 @@ x86_emulate( rc = ops->read(ea.mem.seg, truncate_ea(ea.mem.off + - (idx << state->sib_scale)), + idx * (1 << state->sib_scale)), (void *)mmvalp + i * op_bytes, op_bytes, ctxt); if ( rc != X86EMUL_OKAY ) { @@ -9857,7 +9857,8 @@ x86_emulate( continue; rc = ops->read(ea.mem.seg, - truncate_ea(ea.mem.off + (idx << state->sib_scale)), + truncate_ea(ea.mem.off + + idx * (1 << state->sib_scale)), (void *)mmvalp + i * op_bytes, op_bytes, ctxt); if ( rc != X86EMUL_OKAY ) { From xen-devel-bounces@lists.xenproject.org Tue Aug 04 10:33:45 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 10:33:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2uG5-00083P-LU; Tue, 04 Aug 2020 10:33:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2uG4-00083K-Fa for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 10:33:24 +0000 X-Inumbo-ID: 662f1912-3de7-435a-956e-2b1d39521bfb Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 662f1912-3de7-435a-956e-2b1d39521bfb; Tue, 04 Aug 2020 10:33:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=dATT9PUBgAISaoVjQioYqYy2QiyGY8Dpg6za/3ZiRWc=; b=lYSQTYSctDRRiy6sdbySNnrGo vovm5JOSGQ1sga6QhdmTMZazLWFU1GRF8koiw6aYD8YHn+WC8oqswLcbgGFsZuNcHOf/kRfACAXjC Slcfz3NmQskbCA3zNNTDc6CN2u1l4DmuosL/uf4wWR6gPddqN9p3BXv1Fs+D357z6sngg=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2uG1-0003ul-VA; Tue, 04 Aug 2020 10:33:21 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k2uG1-0005D8-Ed; Tue, 04 Aug 2020 10:33:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k2uG1-00088A-Dv; Tue, 04 Aug 2020 10:33:21 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 152454: regressions - FAIL X-Osstest-Failures: libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=f4f3e6de4af28a8c56b33429aa31b4ae9b3bc70e X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Tue, 04 Aug 2020 10:33:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152454 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/152454/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a version targeted for testing: libvirt f4f3e6de4af28a8c56b33429aa31b4ae9b3bc70e baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 25 days Failing since 151818 2020-07-11 04:18:52 Z 24 days 25 attempts Testing same since 152454 2020-08-04 04:20:02 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrea Bolognani Balázs Meskó Bastien Orivel Bihong Yu Boris Fiuczynski Côme Borsoi Daniel Henrique Barboza Daniel P. Berrange Daniel P. Berrangé Fedora Weblate Translation Han Han Hao Wang Jean-Baptiste Holcroft Jianan Gao Jin Yan Jiri Denemark Ján Tomko Laine Stump Liao Pingfang Martin Kletzander Michal Privoznik Nikolay Shirokovskiy Paulo de Rezende Pinatti Pavel Hrdina Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Roman Bogorodskiy Ryan Schmidt Stefan Berger Szymon Scholz Wang Xin Weblate Yang Hang Yi Wang Yuri Chornoivan Zheng Chuan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 8450 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Aug 04 11:07:01 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 11:07:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2umQ-0002IO-FF; Tue, 04 Aug 2020 11:06:50 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2umO-0002IJ-Kl for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 11:06:48 +0000 X-Inumbo-ID: a554e09f-f153-4f35-916c-f969ca5cc7c2 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a554e09f-f153-4f35-916c-f969ca5cc7c2; Tue, 04 Aug 2020 11:06:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596539208; h=from:mime-version:content-transfer-encoding:message-id: date:to:cc:subject:in-reply-to:references; bh=aRRm9AtF4JI4OwPE6/C24E09a/p3FpZlFw/JCID9GQE=; b=ZdQJ4bw/LNNvkQtMQFSRR/lwvKQdk0F28QiFhX+6BwDCU9l+d1QmA4pg It4gHbii080ElrtP9fRF79EsYScokT96cd6Ry+EZkgODPf9dNi4Qr0cob EBznWeYVreG3VpQPlWAJtdldFBBbsBwg0qfyqiFuo/uVzJLlSX2ML2LgQ 4=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: C7tKztucSK0C5k6Qce20AC1Orb5MB3kNMSAmv/Ia9Kbzm9pqawRt8lYYVS5AXUHs9SnGx4uG4T xXBYxbY3d7UGicccUC3TC0w6rEA1poBepkjIRUU+BH5xIxBzTsEP50lapmIZmNuiMZQ1rp2ofq k6H+ZyS78O6PXOctKKCJOTWX1J/qmH06DjkzQ9malDVTMO/0zZkoIHejP7eIxf+QCPPvlwbNfE VwOvPy0KcdUarie06K+MZnM7pQbOqyMrHbcCW7ca7uvM16QpvxWEWzhxBrQEM20039g7QKc6Vt g04= X-SBRS: 3.7 X-MesageID: 23820123 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,433,1589256000"; d="scan'208";a="23820123" From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-ID: <24361.16705.741010.285482@mariner.uk.xensource.com> Date: Tue, 4 Aug 2020 12:06:41 +0100 To: Paul Durrant Subject: Re: [PATCH v2 1/4] tools/hotplug: add remove_from_bridge() and improve debug output In-Reply-To: <20200803124931.2678-2-paul@xen.org> References: <20200803124931.2678-1-paul@xen.org> <20200803124931.2678-2-paul@xen.org> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" , Paul Durrant , Wei Liu , Ian Jackson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Paul Durrant writes ("[PATCH v2 1/4] tools/hotplug: add remove_from_bridge() and improve debug output"): > From: Paul Durrant > > This patch adds a remove_from_bridge() function into xen-network-common.sh > to partner with the existing add_to_bridge() function. The code in > add_to_bridge() is also slightly re-arranged to avoid duplication calls of > 'ip link'. > > Both add_to_bridge() and remove_from_bridge() will check if their bridge > manipulation operations are necessary and emit a log message if they are not. > > NOTE: A call to remove_from_bridge() will be added by a subsequent patch. I think there is another semantic change here which is that now it executes the "ip link set up" even if the device is already on the bridge. I think this is correct, but it probably ought to be mentioned in the commit message. I hesitate to suggest this, but: my personal preference would have been to split that refactoring (in particular, the inversion of the early exit if approach) into yet another commit. I find tiny commits easier to review. But this commit is already quite small so if you prefer to keep it this way I think that is fine. > +remove_from_bridge () { > + local bridge=$1 > + local dev=$2 > + > + ip link set dev ${dev} down || : > + > + # Don't remove $dev from $bridge if it's not on the bridge. > + if [ -e "/sys/class/net/${bridge}/brif/${dev}" ]; then > + log debug "removing $dev from bridge $bridge" > + if which brctl >&/dev/null; then > + brctl delif ${bridge} ${dev} > + else > + ip link set ${dev} nomaster > + fi > + else > + log debug "$dev not on bridge $bridge" > + fi > +} I think this is code motion split into two patches - here the added code and in 2/, the other copy is removed. Could you please shuffle this addition into patch 2 ? Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Tue Aug 04 11:08:39 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 11:08:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2uoA-0002NP-RK; Tue, 04 Aug 2020 11:08:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2uo9-0002NH-Th for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 11:08:37 +0000 X-Inumbo-ID: ebe2f065-f725-47b2-8cfe-b6e1fcde202c Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ebe2f065-f725-47b2-8cfe-b6e1fcde202c; Tue, 04 Aug 2020 11:08:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596539316; h=from:mime-version:content-transfer-encoding:message-id: date:to:cc:subject:in-reply-to:references; bh=LDZlDAUyFdhhsr8jIsjUPy20+y2smNRkNz/QqUF46fc=; b=eTvJS5RAgaeJS5zVtHiQEjzXalvSKdS0xsvgs0CxYpTIYLXyq1+TB3KO nl2UzFBJ42m9UUdYicFCm0cdGBIGDxv3y0UO1itl5TmCd5Zs8xJWSasYG IPYAW2UnPFGApmmBtM65z/mh7+ot3cRCzvjHxwya7oQJwAgjt0AtxP63Q 8=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: xbDK6NuB3IxMztfV/KWP86GkVvDnTiEWDD4MDvf6cPT8Ufl0LfrEUJB/mwfMKj8BfQd78iqXjQ 3fJd/bqIA2phSsf7j47cDuBH4uHh0umr49CRrRxZjPVXwqVT7Bi4bzRRiDUWaAuZZperYJRLIN gJc2bDJaAW9MWRsVRbciQJ68iJ9fR30t8bwmmXioLOQE4SMfX2bVkfwVXFRmaDCTQ6AdQeJQ+T JsrMRr2AK3H+5B8BtPvQMTyxuUlmyO6KqxTAPi8UxWvxUbsmFQStwp2nJ/w6qt4hGK5wj24V2Q mJ4= X-SBRS: 3.7 X-MesageID: 23984060 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,433,1589256000"; d="scan'208";a="23984060" From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-ID: <24361.16815.556488.913875@mariner.uk.xensource.com> Date: Tue, 4 Aug 2020 12:08:31 +0100 To: Paul Durrant Subject: Re: [PATCH v2 2/4] tools/hotplug: combine add/online and remove/offline in vif-bridge... In-Reply-To: <20200803124931.2678-3-paul@xen.org> References: <20200803124931.2678-1-paul@xen.org> <20200803124931.2678-3-paul@xen.org> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" , Paul Durrant , Wei Liu , Ian Jackson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Paul Durrant writes ("[PATCH v2 2/4] tools/hotplug: combine add/online and remove/offline in vif-bridge..."): > From: Paul Durrant > > ... as they are in vif-route. > > The script is invoked with online/offline for vifs and add/remove for taps. > The operations that are necessary, however, are the same in both cases. This > patch therefore combines the cases. This seems to newly add a "remove" case. Previously "remove" was a no-op here. Is that right ? If so it needs to be discussed in the commit message. We're not talking about a simple refactoring here! Perhaps it would be best to move this bit > + remove) > + ;& > offline) which I think is the relevant change, into its own commit ? Ian. From xen-devel-bounces@lists.xenproject.org Tue Aug 04 11:10:16 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 11:10:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2upk-0003Ao-6c; Tue, 04 Aug 2020 11:10:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2upi-0003Ah-N3 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 11:10:14 +0000 X-Inumbo-ID: d532daf4-e377-46dc-9366-bcc56b0d6e7c Received: from mail-lf1-x143.google.com (unknown [2a00:1450:4864:20::143]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d532daf4-e377-46dc-9366-bcc56b0d6e7c; Tue, 04 Aug 2020 11:10:13 +0000 (UTC) Received: by mail-lf1-x143.google.com with SMTP id i19so22124517lfj.8 for ; Tue, 04 Aug 2020 04:10:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=Ksoj43CvYDuJ0ax1qMdn/6dI9ibScn834n5uBtJNwtA=; b=ktBXVwl/nF57n5ozgSZas7Ll72z8TNsbELx8BZiEK1vCTqi3xAV2Z56jJ49J131BE/ SBoQjG9QfNtO3PdMzdJQfZtgl0PRJC5NTrkquT94KW+L3mO/Eva2Fm9noJgSGtS+IoEU RlLotDrg+vfNAOZyVuEmnqZSCU1u22tajKHIQRW2Fj0eahpf95FsfdwZ/y/hrZE7eEgw U6vTUIWCSauM111mkO42nwXeExNlNQNZAisoN1RicAZb+vASWC7Fn6Bd4Q96irFpCT3L x0LiNzZAhumJe7Wb1VKKdzRwIFKm1Dn66/oZCKHshft8sXh27jWcOCkemZAMkil9XnMC g2Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=Ksoj43CvYDuJ0ax1qMdn/6dI9ibScn834n5uBtJNwtA=; b=ZIjRSn3hKXrdX+zBsGZI0brTfNKnF9KzsHoasAvi2dPzWdnOW3JKRXRFmd6GIr/2Eb pVABt9hhsR4o+MKHOr4pjVx7IJyWyUsKQw1ZtrEjZN2Ocabnjfvw77cSYxQVCwhQuKZb CETvzETJR9heP/11eu6bklZkRQPJSIeXwKn6HYtlnJHinvlw6AdwIe91HBeHjUcTTkz+ ihMNl5A1qB8QwseZNQoUQADBSIgc5jLKV+cAJyP40xxV+k8p3ydmodTUoj1kQbjuxPhT nOs0Adc8I3dS7unB7r7KFYWAikroBFW9pmwspkpJ472UO7+E/gFtu+UdadocBIDSafHG 2uRQ== X-Gm-Message-State: AOAM532LInNACIdApxlYzlairw9GHru0GkGvvtf7rf149V7MrMmw+cjo 8oOrMNpYOj4iCdZbv9lACUw= X-Google-Smtp-Source: ABdhPJwr95FotJusYXKFUd+/k22e9FbS3PVu5GDiKoYLd9cUXWQvWpq1T0g6MLegp0LM1hPLaQiYjA== X-Received: by 2002:a19:f808:: with SMTP id a8mr10681202lff.62.1596539412477; Tue, 04 Aug 2020 04:10:12 -0700 (PDT) Received: from [192.168.1.2] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id t205sm6123016lff.8.2020.08.04.04.10.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2020 04:10:11 -0700 (PDT) Subject: Re: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common To: paul@xen.org, xen-devel@lists.xenproject.org References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-2-git-send-email-olekstysh@gmail.com> <000c01d66a33$2bd56510$83802f30$@xen.org> From: Oleksandr Message-ID: <9f83a7ed-ca97-449f-c7b9-a1140644abe9@gmail.com> Date: Tue, 4 Aug 2020 14:10:05 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <000c01d66a33$2bd56510$83802f30$@xen.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: 'Kevin Tian' , 'Stefano Stabellini' , 'Julien Grall' , 'Jun Nakajima' , 'Wei Liu' , 'Andrew Cooper' , 'Ian Jackson' , 'George Dunlap' , 'Tim Deegan' , 'Oleksandr Tyshchenko' , 'Julien Grall' , 'Jan Beulich' , =?UTF-8?B?J1JvZ2VyIFBhdSBNb25uw6kn?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 04.08.20 10:45, Paul Durrant wrote: Hi Paul >> -----Original Message----- >> From: Oleksandr Tyshchenko >> Sent: 03 August 2020 19:21 >> To: xen-devel@lists.xenproject.org >> Cc: Oleksandr Tyshchenko ; Jan Beulich ; Andrew >> Cooper ; Wei Liu ; Roger Pau Monné ; >> George Dunlap ; Ian Jackson ; Julien Grall >> ; Stefano Stabellini ; Paul Durrant ; Jun >> Nakajima ; Kevin Tian ; Tim Deegan ; Julien >> Grall >> Subject: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common >> >> From: Oleksandr Tyshchenko >> >> As a lot of x86 code can be re-used on Arm later on, this patch >> splits IOREQ support into common and arch specific parts. >> >> This support is going to be used on Arm to be able run device >> emulator outside of Xen hypervisor. >> >> Please note, this is a split/cleanup of Julien's PoC: >> "Add support for Guest IO forwarding to a device emulator" >> >> Signed-off-by: Julien Grall >> Signed-off-by: Oleksandr Tyshchenko >> --- >> xen/arch/x86/Kconfig | 1 + >> xen/arch/x86/hvm/dm.c | 2 +- >> xen/arch/x86/hvm/emulate.c | 2 +- >> xen/arch/x86/hvm/hvm.c | 2 +- >> xen/arch/x86/hvm/io.c | 2 +- >> xen/arch/x86/hvm/ioreq.c | 1431 +-------------------------------------- >> xen/arch/x86/hvm/stdvga.c | 2 +- >> xen/arch/x86/hvm/vmx/realmode.c | 1 + >> xen/arch/x86/hvm/vmx/vvmx.c | 2 +- >> xen/arch/x86/mm.c | 2 +- >> xen/arch/x86/mm/shadow/common.c | 2 +- >> xen/common/Kconfig | 3 + >> xen/common/Makefile | 1 + >> xen/common/hvm/Makefile | 1 + >> xen/common/hvm/ioreq.c | 1430 ++++++++++++++++++++++++++++++++++++++ >> xen/include/asm-x86/hvm/ioreq.h | 45 +- >> xen/include/asm-x86/hvm/vcpu.h | 7 - >> xen/include/xen/hvm/ioreq.h | 89 +++ >> 18 files changed, 1575 insertions(+), 1450 deletions(-) >> create mode 100644 xen/common/hvm/Makefile >> create mode 100644 xen/common/hvm/ioreq.c >> create mode 100644 xen/include/xen/hvm/ioreq.h > You need to adjust the MAINTAINERS file since there will now be common 'I/O EMULATION' code. Since I wrote most of ioreq.c, please retain me as a maintainer of the common code. Oh, I completely forgot about MAINTAINERS file. Sure, I will update file and retain you. > > [snip] >> @@ -1528,13 +143,19 @@ static int hvm_access_cf8( >> return X86EMUL_UNHANDLEABLE; >> } >> >> -void hvm_ioreq_init(struct domain *d) >> +void arch_hvm_ioreq_init(struct domain *d) >> { >> spin_lock_init(&d->arch.hvm.ioreq_server.lock); >> >> register_portio_handler(d, 0xcf8, 4, hvm_access_cf8); >> } >> >> +void arch_hvm_ioreq_destroy(struct domain *d) >> +{ >> + if ( !relocate_portio_handler(d, 0xcf8, 0xcf8, 4) ) >> + return; > There's not really a lot of point in this. I think an empty function here would be ok. ok >> +struct hvm_ioreq_server *hvm_select_ioreq_server(struct domain *d, >> + ioreq_t *p) >> +{ >> + struct hvm_ioreq_server *s; >> + uint8_t type; >> + uint64_t addr; >> + unsigned int id; >> + >> + if ( p->type != IOREQ_TYPE_COPY && p->type != IOREQ_TYPE_PIO ) >> + return NULL; >> + >> + hvm_get_ioreq_server_range_type(d, p, &type, &addr); > Looking at this, I think it would make more sense to fold the check of p->type into hvm_get_ioreq_server_range_type() and have it return success/failure. ok, will update. > diff --git a/xen/include/xen/hvm/ioreq.h b/xen/include/xen/hvm/ioreq.h >> new file mode 100644 >> index 0000000..40b7b5e >> --- /dev/null >> +++ b/xen/include/xen/hvm/ioreq.h >> @@ -0,0 +1,89 @@ >> +/* >> + * hvm.h: Hardware virtual machine assist interface definitions. >> + * >> + * Copyright (c) 2016 Citrix Systems Inc. >> + * >> + * This program is free software; you can redistribute it and/or modify it >> + * under the terms and conditions of the GNU General Public License, >> + * version 2, as published by the Free Software Foundation. >> + * >> + * This program is distributed in the hope it will be useful, but WITHOUT >> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or >> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for >> + * more details. >> + * >> + * You should have received a copy of the GNU General Public License along with >> + * this program; If not, see . >> + */ >> + >> +#ifndef __HVM_IOREQ_H__ >> +#define __HVM_IOREQ_H__ >> + >> +#include >> + >> +#include >> + >> +#define GET_IOREQ_SERVER(d, id) \ >> + (d)->arch.hvm.ioreq_server.server[id] >> + >> +static inline struct hvm_ioreq_server *get_ioreq_server(const struct domain *d, >> + unsigned int id) >> +{ >> + if ( id >= MAX_NR_IOREQ_SERVERS ) >> + return NULL; >> + >> + return GET_IOREQ_SERVER(d, id); >> +} >> + >> +static inline bool hvm_ioreq_needs_completion(const ioreq_t *ioreq) >> +{ >> + return ioreq->state == STATE_IOREQ_READY && >> + !ioreq->data_is_ptr && >> + (ioreq->type != IOREQ_TYPE_PIO || ioreq->dir != IOREQ_WRITE); >> +} > I don't think having this in common code is correct. The short-cut of not completing PIO reads seems somewhat x86 specific. Does ARM even have the concept of PIO? I am not 100% sure here, but it seems that doesn't have. Shall I make hvm_ioreq_needs_completion() per arch? Arm variant would have the same implementation, but without "ioreq->type != IOREQ_TYPE_PIO" check... -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Tue Aug 04 11:11:03 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 11:11:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2uqV-0003FS-Gu; Tue, 04 Aug 2020 11:11:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2uqU-0003FJ-AD for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 11:11:02 +0000 X-Inumbo-ID: 8f5d179d-7c52-4e16-b593-b66717bb9e96 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8f5d179d-7c52-4e16-b593-b66717bb9e96; Tue, 04 Aug 2020 11:11:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596539460; h=from:mime-version:content-transfer-encoding:message-id: date:to:cc:subject:in-reply-to:references; bh=7YWwNl0mEVEyS39mTw7Lz8R/igO1S3WG31NYnfYu0ZA=; b=TSBpjusiqJad4HE1ZNYFlJE2sx450NTFAKrIr2BXzM3BKhS7lV55P8CZ OTvZjJI0yXe1d2ssCSNiNpxzaZy7iJKWgtwCUp0ZU16fgokkNHCzd8mPd Q+ByBEjhewkgzqYoSfwJ/Gz5d/90xcRgs8i8HmBqW1Sp7nzkPy+9ZMTsW Y=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: J9o/DeEgSlB37WfzxUgdDwYW1NtPy1vrlz+ZxAtGdUUowOgadXrDW23xO6gZgxB9Ofv2+tCobh 6RRVHRlF09881Ufb0juAM7S8BNWFmipzxlK+6xM2ar8iKvrNsJgT47069MNkENpjo3IBPt2LOU TweQzvrAf4A7U4RdjYIQmGOXJJNyTRG7/4RK2Z/nNvKAYPjoKItHkKpPDknTRd7H9pDFz5W7Ke 8wZyDlvDG9C9IIxZj7AB6w2HvX9jgUiBJQowUpv7n+z7PDkuUqArHsPR9SaatKCxOfP66i8f8R DXk= X-SBRS: 3.7 X-MesageID: 24129520 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,433,1589256000"; d="scan'208";a="24129520" From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-ID: <24361.16958.407583.382490@mariner.uk.xensource.com> Date: Tue, 4 Aug 2020 12:10:54 +0100 To: Paul Durrant Subject: Re: [PATCH v2 3/4] public/io/netif: specify MTU override node In-Reply-To: <20200803124931.2678-4-paul@xen.org> References: <20200803124931.2678-1-paul@xen.org> <20200803124931.2678-4-paul@xen.org> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Paul Durrant , George Dunlap , Jan Beulich , "xen-devel@lists.xenproject.org" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Paul Durrant writes ("[PATCH v2 3/4] public/io/netif: specify MTU override node"): > From: Paul Durrant > > There is currently no documentation to state what MTU a frontend should > adertise to its network stack. It has however long been assumed that the > default value of 1500 is correct. > > This patch specifies a mechanism to allow the tools to set the MTU via a > xenstore node in the frontend area and states that the absence of that node > means the frontend should assume an MTU of 1500 octets. > > NOTE: The Windows PV frontend has used an MTU sampled from the xenstore > node specified in this patch. > > Signed-off-by: Paul Durrant > Reviewed-by: Juergen Gross Reviewed-by: Ian Jackson > +/* > + * MTU > + * === > + * > + * The toolstack may set a value of MTU for the frontend by setting the > + * /local/domain//device/vif//mtu node with the MTU value in > + * octets. If this node is absent the frontend should assume an MTU value > + * of 1500 octets. A frontend is also at liberty to ignore this value so > + * it is only suitable for informing the frontend that a packet payload > + * >1500 octets is permitted. > + */ I find this wording a bit clumsy - a more formal treatment might be better - but in my reading the overall semantics are correct. Thanks,X Ian. From xen-devel-bounces@lists.xenproject.org Tue Aug 04 11:13:58 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 11:13:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2utG-0003PK-Vk; Tue, 04 Aug 2020 11:13:54 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2utF-0003PF-Ko for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 11:13:53 +0000 X-Inumbo-ID: c322cf2b-fd05-4175-85f5-91d7e203133c Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c322cf2b-fd05-4175-85f5-91d7e203133c; Tue, 04 Aug 2020 11:13:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596539632; h=from:mime-version:content-transfer-encoding:message-id: date:to:cc:subject:in-reply-to:references; bh=xPd0M6dS+gWw72ToZDPJNht/q6Pm33+jr2PKdlHuuk8=; b=ZgajaVtrd4grGVW4Np9st8H2vDUkZPwGwsO+pINBhGmwDjfzKqOlbiOK /q16HRXqxmx3STHrs9lXkqtKwbj9rvePhxQNRgHsq46QbdIpRBrZ6bRd5 1gF4jU/SMRsBcoH0SXD9rpFF6VzrkRZW65rbDJMDVqylX+nGk3ozGglTx w=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: Mx05ncDJQ41Myh8L0mPSVtcZFHtur6JAz5rz5gOcM839mQEaGV9kzI/jqWkHVeBpcIxmb3nOIE PWzzACCoKIe73bkJUum2gpCZPstyGgX8o8/rQvfvB1nj6YRFEdqLgoP2TPYzXeSLztu3gzyIJx q7uAbySHiinEIpGdA9+xbXAGdPOozrlpUar5G3n77jx5QR3PsaJVAPW8AjEZ311FNaMeHYEXp0 O6731Il2MmXKIgoQuk8IMtnBWCSRTITlLlF+c6YDlQQalsNBqvu1g2AFIa+JwvLGWsqSZNc5tK ex0= X-SBRS: 3.7 X-MesageID: 23820543 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,433,1589256000"; d="scan'208";a="23820543" From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-ID: <24361.17132.762055.478992@mariner.uk.xensource.com> Date: Tue, 4 Aug 2020 12:13:48 +0100 To: Paul Durrant Subject: Re: [PATCH v2 4/4] tools/hotplug: modify set_mtu() to inform the frontend via xenstore In-Reply-To: <20200803124931.2678-5-paul@xen.org> References: <20200803124931.2678-1-paul@xen.org> <20200803124931.2678-5-paul@xen.org> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" , Paul Durrant , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Paul Durrant writes ("[PATCH v2 4/4] tools/hotplug: modify set_mtu() to inform the frontend via xenstore"): > From: Paul Durrant > > set_mtu() currently sets the backend vif MTU but does not inform the frontend > what it is. This patch adds code to write the MTU into a xenstore node. See > netif.h for a specification of the node. > > NOTE: There is also a small modification replacing '$mtu' with '${mtu}' > for style consistency. > > Signed-off-by: Paul Durrant Reviewed-by: Ian Jackson > diff --git a/tools/hotplug/Linux/xen-network-common.sh b/tools/hotplug/Linux/xen-network-common.sh > index 37e71cfa9c..24fc42d9cf 100644 > --- a/tools/hotplug/Linux/xen-network-common.sh > +++ b/tools/hotplug/Linux/xen-network-common.sh > @@ -164,9 +164,21 @@ remove_from_bridge () { > set_mtu () { > local bridge=$1 > local dev=$2 > + local type_if=$3 > + > mtu="`ip link show dev ${bridge}| awk '/mtu/ { print $5 }'`" > if [ -n "$mtu" ] && [ "$mtu" -gt 0 ] > then > - ip link set dev ${dev} mtu $mtu || : > + ip link set dev ${dev} mtu ${mtu} || : > + fi > + > + if [ ${type_if} = vif ] > + then > + dev_=${dev#vif} > + domid=${dev_%.*} > + devid=${dev_#*.} > + > + XENBUS_PATH="/local/domain/$domid/device/vif/$devid" > + xenstore_write "$XENBUS_PATH/mtu" ${mtu} It's surprising to me that this code doesn't have the xenbus path already in some variable. But I guess from the fact that you've added this code, that it doesn't. Ian. From xen-devel-bounces@lists.xenproject.org Tue Aug 04 11:20:26 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 11:20:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2uzU-0004HO-N2; Tue, 04 Aug 2020 11:20:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2uzU-0004HJ-7e for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 11:20:20 +0000 X-Inumbo-ID: eaa90474-3594-47d0-ae55-805b4948fc93 Received: from mail-wr1-x433.google.com (unknown [2a00:1450:4864:20::433]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id eaa90474-3594-47d0-ae55-805b4948fc93; Tue, 04 Aug 2020 11:20:19 +0000 (UTC) Received: by mail-wr1-x433.google.com with SMTP id z18so33464039wrm.12 for ; Tue, 04 Aug 2020 04:20:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:content-language :thread-index; bh=yC0YPO95gyvGNFiE8UyD0PZaDIuR1LSRi7PV1ffk01M=; b=tLvbmiSj1iiaT7waPbV59m+KIcaI24BuqtEVFyu+8sLN7Fd3qi7NuyQ7kH01HodT8Z ESzPAuNgsph2a5nTmz8i2vi/pBnxo8RyM1w89a5onfEqU/VgLC034Ri8mTOEQKj9aVd7 BCGVahHWj3EjzVfgHuxRTcJETou/3/sfVgwmcq9gbXUgsPFZKvwtlxqM+sYO90Wrgo/h vwBP0QtHQBhvmBNJ3c7QXhfNayzNeA7+Vs2QiDrFrRNe0E5JSy+kU0nNRFuKfY/kGtmC yTJQY2x8Uzh60Y09mkBRpng6ZZBuBdJDEEHK6bkDgaMdEx1YhcDEdQiCb4orqYAdXLhA +62Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:to:cc:references:in-reply-to :subject:date:message-id:mime-version:content-transfer-encoding :content-language:thread-index; bh=yC0YPO95gyvGNFiE8UyD0PZaDIuR1LSRi7PV1ffk01M=; b=O5uulMOzaDUc/+CXPGhY8/OOkAmmAMU0GUfLxmYcUGhjNvbrDcml14Pg3N4CEbh3N5 qhd9004hgHY23Khv3yhU2/x1O/TPB1Kvo4U5VT000Y6I4MsDkZIrjKBgR5cEsfbppBoZ KJdIH5cj0PiwXihbDva3JoHMrW7+j478A2W85f5s5duykzfKTZXCnBRg1heXi3nz9nPb lrys/twGdDAY5SxYoOxAiVdbvCJAgTw5cFI0QBbIr+UuOsdoZcdI0X7rSs+rqYVhoH/+ pIuwuRHUZB0DKQV+G6u78v0yv5eTKtl1HHgocIKKOxYO72QBDlweV+EWWnVQ0uw5/EAa S8Cg== X-Gm-Message-State: AOAM530j3i7FB0jvqxlWlzVIynP1kbJJZxZx9fSsf8Nmh0Lu7hg2uNS5 /ANQ36Bc2Y8Zn6VvX3Y0s6I= X-Google-Smtp-Source: ABdhPJzPRebCvbG2tTzxQL+1XHHturL7PC6cMYb29QUxy1ViahvmvK5hWOnFZEgccpDvdQ3Sr27JwA== X-Received: by 2002:adf:b1cf:: with SMTP id r15mr20527913wra.118.1596540018281; Tue, 04 Aug 2020 04:20:18 -0700 (PDT) Received: from CBGR90WXYV0 ([2a00:23c5:5785:9a01:ad9a:ab78:5748:a7ec]) by smtp.gmail.com with ESMTPSA id z63sm4300492wmb.2.2020.08.04.04.20.17 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Aug 2020 04:20:17 -0700 (PDT) From: Paul Durrant X-Google-Original-From: "Paul Durrant" To: "'Ian Jackson'" References: <20200803124931.2678-1-paul@xen.org> <20200803124931.2678-5-paul@xen.org> <24361.17132.762055.478992@mariner.uk.xensource.com> In-Reply-To: <24361.17132.762055.478992@mariner.uk.xensource.com> Subject: RE: [PATCH v2 4/4] tools/hotplug: modify set_mtu() to inform the frontend via xenstore Date: Tue, 4 Aug 2020 12:20:18 +0100 Message-ID: <002001d66a51$3cd055f0$b67101d0$@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: en-gb Thread-Index: AQIYGZMBbauEfHj5QMvrSYCboUsizgIdsxRvAjZRG3+ogc3BwA== X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: paul@xen.org Cc: xen-devel@lists.xenproject.org, 'Paul Durrant' , 'Wei Liu' Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" > -----Original Message----- > From: Ian Jackson > Sent: 04 August 2020 12:14 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Paul Durrant ; Wei Liu > Subject: Re: [PATCH v2 4/4] tools/hotplug: modify set_mtu() to inform the frontend via xenstore > > Paul Durrant writes ("[PATCH v2 4/4] tools/hotplug: modify set_mtu() to inform the frontend via > xenstore"): > > From: Paul Durrant > > > > set_mtu() currently sets the backend vif MTU but does not inform the frontend > > what it is. This patch adds code to write the MTU into a xenstore node. See > > netif.h for a specification of the node. > > > > NOTE: There is also a small modification replacing '$mtu' with '${mtu}' > > for style consistency. > > > > Signed-off-by: Paul Durrant > > Reviewed-by: Ian Jackson > Thanks. > > diff --git a/tools/hotplug/Linux/xen-network-common.sh b/tools/hotplug/Linux/xen-network-common.sh > > index 37e71cfa9c..24fc42d9cf 100644 > > --- a/tools/hotplug/Linux/xen-network-common.sh > > +++ b/tools/hotplug/Linux/xen-network-common.sh > > @@ -164,9 +164,21 @@ remove_from_bridge () { > > set_mtu () { > > local bridge=$1 > > local dev=$2 > > + local type_if=$3 > > + > > mtu="`ip link show dev ${bridge}| awk '/mtu/ { print $5 }'`" > > if [ -n "$mtu" ] && [ "$mtu" -gt 0 ] > > then > > - ip link set dev ${dev} mtu $mtu || : > > + ip link set dev ${dev} mtu ${mtu} || : > > + fi > > + > > + if [ ${type_if} = vif ] > > + then > > + dev_=${dev#vif} > > + domid=${dev_%.*} > > + devid=${dev_#*.} > > + > > + XENBUS_PATH="/local/domain/$domid/device/vif/$devid" > > + xenstore_write "$XENBUS_PATH/mtu" ${mtu} > > It's surprising to me that this code doesn't have the xenbus path > already in some variable. But I guess from the fact that you've added > this code, that it doesn't. > It is set, but set to the backend path. For safety I guess it's probably best if I use a local in this instance. Can I keep your R-b with such a change? Paul > Ian. From xen-devel-bounces@lists.xenproject.org Tue Aug 04 11:23:44 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 11:23:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2v2k-0004QC-AL; Tue, 04 Aug 2020 11:23:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2v2j-0004Q7-FM for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 11:23:41 +0000 X-Inumbo-ID: f8f67bc2-273d-415b-a66c-b0c2135bed2d Received: from mail-wm1-x342.google.com (unknown [2a00:1450:4864:20::342]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f8f67bc2-273d-415b-a66c-b0c2135bed2d; Tue, 04 Aug 2020 11:23:40 +0000 (UTC) Received: by mail-wm1-x342.google.com with SMTP id t14so2534830wmi.3 for ; Tue, 04 Aug 2020 04:23:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:content-language :thread-index; bh=2xr1Zha5BGUVWCkqX0z9uYsDmihPkLZm1fTgchVOAiA=; b=Kuy0vsn893BB1Z1pz0yxewdR8yonJkLCwj80UdVPgCXreZipJWdM5YF6P+iVkmLJl6 szm4IY8BN2sXc3Hjr/LB1v1OjAjtMlhDAjQ86MNpSi3vd31wQuMQjzG5+7vYnB1btBjS oX6WtJGaO1JLqyWWafvdbVbSz/cnqIo3UOR73TFGzVBu6Hy8mlct0RtTDFLK17Z/tuMA EKo2rNqOuTe+EHHz5/Puj9UWaYz7IyCno6dGNO/XSnc2ck4R6CEqzrnteHceA3m4+Pmh +HvUYKTF5uR5QdOXEkwUG2Vk7pw8Di8n2m9ppD1rtVHRoaLajU1j9E9XCT+W2nABr8zZ a61Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:to:cc:references:in-reply-to :subject:date:message-id:mime-version:content-transfer-encoding :content-language:thread-index; bh=2xr1Zha5BGUVWCkqX0z9uYsDmihPkLZm1fTgchVOAiA=; b=rUXkiQswg6Hp4xblZ99p8jgIG7kE06umb4pawyBvNPgPv4zv+ctQaN5q//2Ua2558K PpBr7NjrNlEpBQ4UkZMMpD6CEG/ru57rGcpPGAzU5PMIq7+Kmgd3cbEOMs+xW7Jwxs30 rdopiVKkuQ32KccL54G5+Vy5Z1jm73YVsE+wHsvULedRlS6qICrgWnL1Jgu7pAxuQGdp WKqbmfPo1z7Ur/io+LoU+ftgtReWdkh7T47y8JHXiy0QVZ94IuncpNBKekg03B+G5Jhp GUuKKIQ+nSv6yxkUzAF9ZPrRgmpx/6R2ADtfWa4Se/EiszSEvlyhmG60u6FRsz/3hzCk zQlg== X-Gm-Message-State: AOAM5330FRPTbckN8A6cHMNHrrgUi64USjKtUPygMyNnBZmzLnGtu+T1 RzgB/bq39EYGzKO+5NzNvH0= X-Google-Smtp-Source: ABdhPJwldR3x39/8FLNTHdN4sFmcIvDSZQnqH6q6zBfjmBPPfdSQjXwPkPGU+BfOOFuYsl9tJnJsMg== X-Received: by 2002:a1c:a942:: with SMTP id s63mr3495625wme.19.1596540219532; Tue, 04 Aug 2020 04:23:39 -0700 (PDT) Received: from CBGR90WXYV0 ([2a00:23c5:5785:9a01:ad9a:ab78:5748:a7ec]) by smtp.gmail.com with ESMTPSA id s205sm4451340wme.7.2020.08.04.04.23.38 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Aug 2020 04:23:39 -0700 (PDT) From: Paul Durrant X-Google-Original-From: "Paul Durrant" To: "'Oleksandr'" , References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-2-git-send-email-olekstysh@gmail.com> <000c01d66a33$2bd56510$83802f30$@xen.org> <9f83a7ed-ca97-449f-c7b9-a1140644abe9@gmail.com> In-Reply-To: <9f83a7ed-ca97-449f-c7b9-a1140644abe9@gmail.com> Subject: RE: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common Date: Tue, 4 Aug 2020 12:23:40 +0100 Message-ID: <002101d66a51$b4c59070$1e50b150$@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Content-Language: en-gb Thread-Index: AQIHYXuU00Oy15gaFT3m+7M9vTQs4QHrpydYAen0VmICUR8SMaiUqjDA X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: paul@xen.org Cc: 'Kevin Tian' , 'Stefano Stabellini' , 'Julien Grall' , 'Jun Nakajima' , 'Wei Liu' , 'Andrew Cooper' , 'Ian Jackson' , 'George Dunlap' , 'Tim Deegan' , 'Oleksandr Tyshchenko' , 'Julien Grall' , 'Jan Beulich' , =?utf-8?Q?'Roger_Pau_Monn=C3=A9'?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" > -----Original Message----- > From: Oleksandr > Sent: 04 August 2020 12:10 > To: paul@xen.org; xen-devel@lists.xenproject.org > Cc: 'Oleksandr Tyshchenko' ; 'Jan = Beulich' ; 'Andrew > Cooper' ; 'Wei Liu' ; 'Roger = Pau Monn=C3=A9' ; > 'George Dunlap' ; 'Ian Jackson' = ; 'Julien Grall' > ; 'Stefano Stabellini' ; 'Jun = Nakajima' > ; 'Kevin Tian' ; 'Tim = Deegan' ; 'Julien > Grall' > Subject: Re: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature = common >=20 >=20 > On 04.08.20 10:45, Paul Durrant wrote: >=20 > Hi Paul >=20 > >> -----Original Message----- > >> From: Oleksandr Tyshchenko > >> Sent: 03 August 2020 19:21 > >> To: xen-devel@lists.xenproject.org > >> Cc: Oleksandr Tyshchenko ; Jan = Beulich ; Andrew > >> Cooper ; Wei Liu ; Roger Pau = Monn=C3=A9 ; > >> George Dunlap ; Ian Jackson = ; Julien Grall > >> ; Stefano Stabellini ; Paul = Durrant ; Jun > >> Nakajima ; Kevin Tian = ; Tim Deegan ; > Julien > >> Grall > >> Subject: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature = common > >> > >> From: Oleksandr Tyshchenko > >> > >> As a lot of x86 code can be re-used on Arm later on, this patch > >> splits IOREQ support into common and arch specific parts. > >> > >> This support is going to be used on Arm to be able run device > >> emulator outside of Xen hypervisor. > >> > >> Please note, this is a split/cleanup of Julien's PoC: > >> "Add support for Guest IO forwarding to a device emulator" > >> > >> Signed-off-by: Julien Grall > >> Signed-off-by: Oleksandr Tyshchenko > >> --- > >> xen/arch/x86/Kconfig | 1 + > >> xen/arch/x86/hvm/dm.c | 2 +- > >> xen/arch/x86/hvm/emulate.c | 2 +- > >> xen/arch/x86/hvm/hvm.c | 2 +- > >> xen/arch/x86/hvm/io.c | 2 +- > >> xen/arch/x86/hvm/ioreq.c | 1431 = +-------------------------------------- > >> xen/arch/x86/hvm/stdvga.c | 2 +- > >> xen/arch/x86/hvm/vmx/realmode.c | 1 + > >> xen/arch/x86/hvm/vmx/vvmx.c | 2 +- > >> xen/arch/x86/mm.c | 2 +- > >> xen/arch/x86/mm/shadow/common.c | 2 +- > >> xen/common/Kconfig | 3 + > >> xen/common/Makefile | 1 + > >> xen/common/hvm/Makefile | 1 + > >> xen/common/hvm/ioreq.c | 1430 = ++++++++++++++++++++++++++++++++++++++ > >> xen/include/asm-x86/hvm/ioreq.h | 45 +- > >> xen/include/asm-x86/hvm/vcpu.h | 7 - > >> xen/include/xen/hvm/ioreq.h | 89 +++ > >> 18 files changed, 1575 insertions(+), 1450 deletions(-) > >> create mode 100644 xen/common/hvm/Makefile > >> create mode 100644 xen/common/hvm/ioreq.c > >> create mode 100644 xen/include/xen/hvm/ioreq.h > > You need to adjust the MAINTAINERS file since there will now be = common 'I/O EMULATION' code. Since I > wrote most of ioreq.c, please retain me as a maintainer of the common = code. >=20 > Oh, I completely forgot about MAINTAINERS file. Sure, I will update = file > and retain you. >=20 >=20 > > > > [snip] > >> @@ -1528,13 +143,19 @@ static int hvm_access_cf8( > >> return X86EMUL_UNHANDLEABLE; > >> } > >> > >> -void hvm_ioreq_init(struct domain *d) > >> +void arch_hvm_ioreq_init(struct domain *d) > >> { > >> spin_lock_init(&d->arch.hvm.ioreq_server.lock); > >> > >> register_portio_handler(d, 0xcf8, 4, hvm_access_cf8); > >> } > >> > >> +void arch_hvm_ioreq_destroy(struct domain *d) > >> +{ > >> + if ( !relocate_portio_handler(d, 0xcf8, 0xcf8, 4) ) > >> + return; > > There's not really a lot of point in this. I think an empty function = here would be ok. >=20 > ok >=20 >=20 > >> +struct hvm_ioreq_server *hvm_select_ioreq_server(struct domain *d, > >> + ioreq_t *p) > >> +{ > >> + struct hvm_ioreq_server *s; > >> + uint8_t type; > >> + uint64_t addr; > >> + unsigned int id; > >> + > >> + if ( p->type !=3D IOREQ_TYPE_COPY && p->type !=3D = IOREQ_TYPE_PIO ) > >> + return NULL; > >> + > >> + hvm_get_ioreq_server_range_type(d, p, &type, &addr); > > Looking at this, I think it would make more sense to fold the check = of p->type into > hvm_get_ioreq_server_range_type() and have it return success/failure. >=20 > ok, will update. >=20 >=20 > > diff --git a/xen/include/xen/hvm/ioreq.h = b/xen/include/xen/hvm/ioreq.h > >> new file mode 100644 > >> index 0000000..40b7b5e > >> --- /dev/null > >> +++ b/xen/include/xen/hvm/ioreq.h > >> @@ -0,0 +1,89 @@ > >> +/* > >> + * hvm.h: Hardware virtual machine assist interface definitions. > >> + * > >> + * Copyright (c) 2016 Citrix Systems Inc. > >> + * > >> + * This program is free software; you can redistribute it and/or = modify it > >> + * under the terms and conditions of the GNU General Public = License, > >> + * version 2, as published by the Free Software Foundation. > >> + * > >> + * This program is distributed in the hope it will be useful, but = WITHOUT > >> + * ANY WARRANTY; without even the implied warranty of = MERCHANTABILITY or > >> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public = License for > >> + * more details. > >> + * > >> + * You should have received a copy of the GNU General Public = License along with > >> + * this program; If not, see . > >> + */ > >> + > >> +#ifndef __HVM_IOREQ_H__ > >> +#define __HVM_IOREQ_H__ > >> + > >> +#include > >> + > >> +#include > >> + > >> +#define GET_IOREQ_SERVER(d, id) \ > >> + (d)->arch.hvm.ioreq_server.server[id] > >> + > >> +static inline struct hvm_ioreq_server *get_ioreq_server(const = struct domain *d, > >> + unsigned = int id) > >> +{ > >> + if ( id >=3D MAX_NR_IOREQ_SERVERS ) > >> + return NULL; > >> + > >> + return GET_IOREQ_SERVER(d, id); > >> +} > >> + > >> +static inline bool hvm_ioreq_needs_completion(const ioreq_t = *ioreq) > >> +{ > >> + return ioreq->state =3D=3D STATE_IOREQ_READY && > >> + !ioreq->data_is_ptr && > >> + (ioreq->type !=3D IOREQ_TYPE_PIO || ioreq->dir !=3D = IOREQ_WRITE); > >> +} > > I don't think having this in common code is correct. The short-cut = of not completing PIO reads seems > somewhat x86 specific. Does ARM even have the concept of PIO? >=20 > I am not 100% sure here, but it seems that doesn't have. >=20 > Shall I make hvm_ioreq_needs_completion() per arch? Arm variant would > have the same implementation, but without "ioreq->type !=3D > IOREQ_TYPE_PIO" check... >=20 With your series applied, does any common code actually call = hvm_ioreq_needs_completion()? I suspect it will remain x86 specific, = without any need for an Arm variant. Paul > -- > Regards, >=20 > Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Tue Aug 04 11:35:52 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 11:35:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2vEF-0005P9-Fa; Tue, 04 Aug 2020 11:35:35 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2vEE-0005P4-Ez for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 11:35:34 +0000 X-Inumbo-ID: 4ba57c47-3bab-41d7-a3d1-ef4d43c6abb3 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4ba57c47-3bab-41d7-a3d1-ef4d43c6abb3; Tue, 04 Aug 2020 11:35:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596540934; h=from:mime-version:content-transfer-encoding:message-id: date:to:cc:subject:in-reply-to:references; bh=xHGxEqLb1d3XP+GToLDqmxMFCU2q6yG9payxSnf3CRc=; b=GvyadbTWHy4J+mCqOL07UqPJjXrSZAayYS1mQMym+yqtqyvw8W965jmz 0A49xkH1JF1ESKi93NIJ2lELNCvo5PT10LRtRk+U9TD/Gj9Nl0/FQx0sH zDtisyhkBhr9Q9jH6x04+wUGUrJc/k7Y7TSfbZb/Sc4SGhyexeXhQ9KPK U=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 0ZpsD4Fll3JfMsMxbR53dUoSCU8buiSAMBxphrNHYIjByu7eT1jx4jQgAX17eugdX++O27KyqF gUm/WRXuJXYFN67fZesn0X/E2ZkPZB0n6u4PK5YuP0XQV9Hoywf1xuLhCppliZuqlbTEg/PH+w 8lSq+m+QdIKVtiYYnOOA/3zhY7wTG7/tr4bpkLgVEesaOUUMY1XjPWzvHaTTIeCm808866atZL yp1A168Vjm21p43zgDhU3SZPrYL1rcMs9VokP8bRzs6c6Z7w+Qt29ZIMwPT+xr4H1qH9nQlWKr cAQ= X-SBRS: 3.7 X-MesageID: 23796862 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,433,1589256000"; d="scan'208";a="23796862" From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-ID: <24361.18433.500622.984594@mariner.uk.xensource.com> Date: Tue, 4 Aug 2020 12:35:29 +0100 To: "paul@xen.org" Subject: RE: [PATCH v2 4/4] tools/hotplug: modify set_mtu() to inform the frontend via xenstore In-Reply-To: <002001d66a51$3cd055f0$b67101d0$@xen.org> References: <20200803124931.2678-1-paul@xen.org> <20200803124931.2678-5-paul@xen.org> <24361.17132.762055.478992@mariner.uk.xensource.com> <002001d66a51$3cd055f0$b67101d0$@xen.org> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" , 'Paul Durrant' , 'Wei Liu' Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Paul Durrant writes ("RE: [PATCH v2 4/4] tools/hotplug: modify set_mtu() to inform the frontend via xenstore"): > > -----Original Message----- > > From: Ian Jackson > > Sent: 04 August 2020 12:14 > > To: Paul Durrant > > Cc: xen-devel@lists.xenproject.org; Paul Durrant ; Wei Liu > > Subject: Re: [PATCH v2 4/4] tools/hotplug: modify set_mtu() to inform the frontend via xenstore > > > > Paul Durrant writes ("[PATCH v2 4/4] tools/hotplug: modify set_mtu() to inform the frontend via > > xenstore"): > > > + XENBUS_PATH="/local/domain/$domid/device/vif/$devid" > > > + xenstore_write "$XENBUS_PATH/mtu" ${mtu} > > > > It's surprising to me that this code doesn't have the xenbus path > > already in some variable. But I guess from the fact that you've added > > this code, that it doesn't. > > It is set, but set to the backend path. For safety I guess it's probably best if I use a local in this instance. Can I keep your R-b > with such a change? Oh, wow. I hadn't realised that. I take back my earlier R-b :-). Can you please use a different variable name for the frontend path ? ... Actually. This shouldn't be in the frontend at all, should it ? In general the backend writes to the backend and the frontend to the frontend. So maybe I need to take back my R-b of [PATCH v2 3/4] public/io/netif: specify MTU override node Sorry for the confusion. I seem rather undercaffienated today. Ian. From xen-devel-bounces@lists.xenproject.org Tue Aug 04 11:51:44 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 11:51:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2vTh-000742-SR; Tue, 04 Aug 2020 11:51:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2vTg-00073w-Gq for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 11:51:32 +0000 X-Inumbo-ID: 23fb40cd-9850-4833-9de9-03862019e94b Received: from mail-lj1-x242.google.com (unknown [2a00:1450:4864:20::242]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 23fb40cd-9850-4833-9de9-03862019e94b; Tue, 04 Aug 2020 11:51:31 +0000 (UTC) Received: by mail-lj1-x242.google.com with SMTP id s16so27992845ljc.8 for ; Tue, 04 Aug 2020 04:51:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=cxsqPnXRx7MzkEol47tQkkafzc9lF+bSt8dnruzqDso=; b=op1zwJalcODE4CkvOP4LoYmbJPHTGqQhQfRi0vSfZUa++oZlNr/esdbd/Q3fqQsW7k 6n3XNPshWyC9bfNt6p6b0CuaWaki94oEZep7uQk42Vd7cekYEdW+3jMvbJx/GAbgp4x3 CHSNd98bjhGRBQ8YUmYjtuPprh95noRWgGBkQ7GWDvOcz/BXY11TL7+dwSdP1r/g12HO 6JUvaWTCg5cLoIQw7WjjbO5TC+nwV4MgYqVXCL7UMfGZPVhvp1zNerDmyJCib1VEj4cz ofwtlp7r+KUFtybmkl99FQ2wbGUoRFt6gZ8zl+d9mc1IphvRfrO6ws0DWS+JkipGsukr TyDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=cxsqPnXRx7MzkEol47tQkkafzc9lF+bSt8dnruzqDso=; b=rmZQFdESSnibfZlKsMKv3W0auFPY0cZwPde+0vd49hAIl26lrnxnCZpVVfh0mU/QnK MOZ2zpc26CM4FAAgw6oPldxpzI/hjTBjBwtKrlZXEdvJzBUmXzyz/C5k+8AIMKfCc4P+ Mhzdk90NQgnrw0xNscukSWJwgCrY2Wuzknq/BPVJfPwHPcg1CCfj1s9uUvFQl/JAkt2Y l0iyKHszaQz8rY+P3NkdwkE9VVqOLUf13ZRpzbIDBU5VZ3H0NhaH8dVvK0Cmhmkod4yz 1JdGfQZyuYB8fC3xc1UAbrIw5eoscS5vQ7U+tknbhW8PsWsuHR+Q8Dd7VJSP0anb5s75 +C7w== X-Gm-Message-State: AOAM5310ipAmIHNraq3BirUvXMNh5nCQ5npmC9J2W2lfKG1allugjqHL rR2G5G9VSWCHG5KAJvBmepc= X-Google-Smtp-Source: ABdhPJzyX8Qg2dYRmmBdl6qDyiHqcjjHMnnhorkcIljRmkqTWWoBzL6AjynNywFYWPyE/WmgcHOe7w== X-Received: by 2002:a2e:b16c:: with SMTP id a12mr9846687ljm.146.1596541890217; Tue, 04 Aug 2020 04:51:30 -0700 (PDT) Received: from [192.168.1.2] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id c5sm930112lfb.24.2020.08.04.04.51.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2020 04:51:29 -0700 (PDT) Subject: Re: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common To: paul@xen.org, xen-devel@lists.xenproject.org References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-2-git-send-email-olekstysh@gmail.com> <000c01d66a33$2bd56510$83802f30$@xen.org> <9f83a7ed-ca97-449f-c7b9-a1140644abe9@gmail.com> <002101d66a51$b4c59070$1e50b150$@xen.org> From: Oleksandr Message-ID: <396a0833-021c-c21a-1dcf-cc8bddd1f4a9@gmail.com> Date: Tue, 4 Aug 2020 14:51:23 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <002101d66a51$b4c59070$1e50b150$@xen.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: 'Kevin Tian' , 'Stefano Stabellini' , 'Julien Grall' , 'Jun Nakajima' , 'Wei Liu' , 'Andrew Cooper' , 'Ian Jackson' , 'George Dunlap' , 'Tim Deegan' , 'Oleksandr Tyshchenko' , 'Julien Grall' , 'Jan Beulich' , =?UTF-8?B?J1JvZ2VyIFBhdSBNb25uw6kn?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 04.08.20 14:23, Paul Durrant wrote: >> >>> diff --git a/xen/include/xen/hvm/ioreq.h b/xen/include/xen/hvm/ioreq.h >>>> new file mode 100644 >>>> index 0000000..40b7b5e >>>> --- /dev/null >>>> +++ b/xen/include/xen/hvm/ioreq.h >>>> @@ -0,0 +1,89 @@ >>>> +/* >>>> + * hvm.h: Hardware virtual machine assist interface definitions. >>>> + * >>>> + * Copyright (c) 2016 Citrix Systems Inc. >>>> + * >>>> + * This program is free software; you can redistribute it and/or modify it >>>> + * under the terms and conditions of the GNU General Public License, >>>> + * version 2, as published by the Free Software Foundation. >>>> + * >>>> + * This program is distributed in the hope it will be useful, but WITHOUT >>>> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or >>>> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for >>>> + * more details. >>>> + * >>>> + * You should have received a copy of the GNU General Public License along with >>>> + * this program; If not, see . >>>> + */ >>>> + >>>> +#ifndef __HVM_IOREQ_H__ >>>> +#define __HVM_IOREQ_H__ >>>> + >>>> +#include >>>> + >>>> +#include >>>> + >>>> +#define GET_IOREQ_SERVER(d, id) \ >>>> + (d)->arch.hvm.ioreq_server.server[id] >>>> + >>>> +static inline struct hvm_ioreq_server *get_ioreq_server(const struct domain *d, >>>> + unsigned int id) >>>> +{ >>>> + if ( id >= MAX_NR_IOREQ_SERVERS ) >>>> + return NULL; >>>> + >>>> + return GET_IOREQ_SERVER(d, id); >>>> +} >>>> + >>>> +static inline bool hvm_ioreq_needs_completion(const ioreq_t *ioreq) >>>> +{ >>>> + return ioreq->state == STATE_IOREQ_READY && >>>> + !ioreq->data_is_ptr && >>>> + (ioreq->type != IOREQ_TYPE_PIO || ioreq->dir != IOREQ_WRITE); >>>> +} >>> I don't think having this in common code is correct. The short-cut of not completing PIO reads seems >> somewhat x86 specific. Does ARM even have the concept of PIO? >> >> I am not 100% sure here, but it seems that doesn't have. >> >> Shall I make hvm_ioreq_needs_completion() per arch? Arm variant would >> have the same implementation, but without "ioreq->type != >> IOREQ_TYPE_PIO" check... >> > With your series applied, does any common code actually call hvm_ioreq_needs_completion()? I suspect it will remain x86 specific, without any need for an Arm variant. Yes, it does. Please see common usage in hvm_io_assist() and handle_hvm_io_completion() (current patch) and usage in Arm code (arch/arm/io.c: io_state try_fwd_ioserv) [1] [1] https://lists.xenproject.org/archives/html/xen-devel/2020-08/msg00072.html -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Tue Aug 04 12:02:52 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 12:02:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2veY-00084K-Cx; Tue, 04 Aug 2020 12:02:46 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2veW-00084C-MU for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 12:02:44 +0000 X-Inumbo-ID: be2d07c0-4786-4108-b4a7-80c90ac08f18 Received: from mail-oi1-x22e.google.com (unknown [2607:f8b0:4864:20::22e]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id be2d07c0-4786-4108-b4a7-80c90ac08f18; Tue, 04 Aug 2020 12:02:43 +0000 (UTC) Received: by mail-oi1-x22e.google.com with SMTP id b22so10150937oic.8 for ; Tue, 04 Aug 2020 05:02:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=yoKmKiR2TJ74eR2Wzmi7g0ckceS6f1XmFqfjMXSAC0E=; b=EJD76uf1qlnEbnbsSXcCjiR1dwF63Eymy4O3vdUuxerJGrjkx8QmybzJ3s7f0BtRaA AJQMd2jWYVcLD7Q9+ET5jGb/RzyjdlWE1qbNFSWwkdvB7sa1fGpxIqPF5WLWDJz+EHVI BgHBMoZtVg5G6iWt+KPjMJgLgdGWV7NjEcR1yc2O9fDeIGk0bC/1lo81odjohmF32WZ2 gtQduwbXt96PWkauMBsGmvODCtFhxx4obfWoW0QUJjPsb6a9T0CzHWk/r8BGF1hw2YOs XudmYvMvo8I2nDzAch+QRxWvA+PuGI8kC5GuSFnlSFuYQqd0Bf39m47a9Q34hdgWvgZU mu2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=yoKmKiR2TJ74eR2Wzmi7g0ckceS6f1XmFqfjMXSAC0E=; b=jPtJSwucClxMgvRWcxW5FkXr0e8kdci9Hy7tIVGc98JXfaBAAab6F1h59O/T4PC6Xn t+kVJI2KHKX1vxlzdiVtUeyN/NfmGN6McN36tbi5DiSzr3DmYsBAyqdnMcCuWdvR16Jy 4H6AfySgCYC4d+Gvepd629as6o78ECi6AgS3qkSYdhmnXbHYOCVfLNUjMBS5qPO64VFA x7AD6ZzhqGcBcR425/lF06JgUWUf3RzaNQR/pWXgbLME+MMIBzmJd7l0TYnERVrgCSWT HvGbV9O8ftTEyLD1DHqrIKDKNL5TpNov/Tw37lJLg7VEA7K7spmXX0v6EvJDOyydPnu7 zLHw== X-Gm-Message-State: AOAM533W1Zt0PEqJZ5G8eo/GOp2F+w1kS0K6D5clxdtPFO6f7Ecjb9TP tTx+RvBTlahNhRuqcnZeVxN2cTDi92t+qUslX+Q3OQ== X-Google-Smtp-Source: ABdhPJwh89DKXqLZiAeMyV9LAFWrB/U0YIK3LfYvYk9eY4qJFGJuRx/INllEMvIAujSto2az2g/8kBZ0ao02G4dSGnE= X-Received: by 2002:aca:50c4:: with SMTP id e187mr2897725oib.146.1596542563240; Tue, 04 Aug 2020 05:02:43 -0700 (PDT) MIME-Version: 1.0 References: <20200804092624.1126013-1-anthony.perard@citrix.com> In-Reply-To: <20200804092624.1126013-1-anthony.perard@citrix.com> From: Peter Maydell Date: Tue, 4 Aug 2020 13:02:32 +0100 Message-ID: Subject: Re: [PULL 0/1] xen queue 2020-08-04 To: Anthony PERARD Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "open list:X86" , QEMU Developers Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Tue, 4 Aug 2020 at 10:26, Anthony PERARD wro= te: > > The following changes since commit 5c1c3e4f02e458cf280c677c817ae4fd1ed9bf= 10: > > Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-202= 00803' into staging (2020-08-03 20:34:26 +0100) > > are available in the Git repository at: > > https://xenbits.xen.org/git-http/people/aperard/qemu-dm.git tags/pull-x= en-20200804 > > for you to fetch changes up to 8e0ef068942e4152f0d23e76ca1f5e35dc4456f7: > > accel/xen: Fix xen_enabled() behavior on target-agnostic objects (2020-= 08-04 10:21:35 +0100) > > ---------------------------------------------------------------- > xen patch > > Bug fix. > > ---------------------------------------------------------------- > Philippe Mathieu-Daud=C3=A9 (1): > accel/xen: Fix xen_enabled() behavior on target-agnostic objects Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.1 for any user-visible changes. -- PMM From xen-devel-bounces@lists.xenproject.org Tue Aug 04 13:03:09 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 13:03:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2wab-0004iP-PX; Tue, 04 Aug 2020 13:02:45 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2waa-0004i5-VF for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 13:02:45 +0000 X-Inumbo-ID: 62a99caf-ce73-4f58-8e05-d0682633e5de Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 62a99caf-ce73-4f58-8e05-d0682633e5de; Tue, 04 Aug 2020 13:02:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=4MvOlzMDx+WN4OMr4ScMwMuzRCf0TyBFxu2LZiN/WmE=; b=GnZ5XdPr3OBJfh7q9LuTXAYnU iG0g0tfIsjgxc5vNglIBoRXM9PCPEgTmosIwwYmSfsS1OfJJlg20T4WP6C+y6AHglwkLYKugYCzj/ lCCWkGrONhKWl44wkwV2blQuMNs2bEbm/sGbyq54HmcDA4VqRXBXpM/tC2OM2/dpbtn0I=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2waS-0007D5-R4; Tue, 04 Aug 2020 13:02:36 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k2waS-0001Xu-CX; Tue, 04 Aug 2020 13:02:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k2waS-0003Aw-Ax; Tue, 04 Aug 2020 13:02:36 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 152432: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:guest-start/debian.repeat:fail:regression linux-linus:test-amd64-amd64-examine:memdisk-try-append:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking X-Osstest-Versions-This: linux=bcf876870b95592b52519ed4aafcf9d95999bc9c X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Tue, 04 Aug 2020 13:02:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152432 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/152432/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-boot fail REGR. vs. 152332 test-armhf-armhf-libvirt-raw 7 xen-boot fail REGR. vs. 152332 test-arm64-arm64-libvirt-xsm 16 guest-start/debian.repeat fail REGR. vs. 152332 test-amd64-amd64-examine 4 memdisk-try-append fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 10 debian-hvm-install fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail like 152332 test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 152332 test-armhf-armhf-libvirt 14 saverestore-support-check fail like 152332 test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail like 152332 test-amd64-i386-xl-pvshim 12 guest-start fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass version targeted for testing: linux bcf876870b95592b52519ed4aafcf9d95999bc9c baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 3 days Failing since 152366 2020-08-01 20:49:34 Z 2 days 3 attempts Testing same since 152432 2020-08-03 17:25:53 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Aaron Brown Aaron Ma Akash Asthana Al Viro Alaa Hleihel Alex Veber Amit Cohen Andrew Cagney Andrii Nakryiko Arnaldo Carvalho de Melo Aya Levin Ben Hutchings Christian Brauner Christoph Hellwig Cong Wang Daniel Borkmann David Howells David S. Miller David Woodhouse Douglas Anderson Eran Ben Elisha Felix Fietkau Francesco Ruggeri Frank Wunderlich Guillaume Nault Guojia Liao Haiwei Li Hangbin Liu Herbert Xu Huazhong Tan Ido Schimmel Ingo Molnar Jakub Kicinski Jean-Philippe Brucker Jian Shen Jianbo Liu Johan Hovold Johannes Berg Joyce Ooi Julian Squires Landen Chao laurent brando Linus Torvalds Linus Walleij liujian Lu Wei Maor Dickman Maor Gottlieb Marc Zyngier Mark Salyzyn Martin Varghese Masahiro Yamada Matthieu Baerts Nathan Chancellor Nick Bowler Paolo Abeni Paolo Bonzini Parav Pandit Pavel Machek (CIP) Pavel Machek Peilin Ye Philippe Duplessis-Guindon Quentin Perret Raed Salem Rajkumar Manoharan Remi Pommarel René van Dorst Rodrigo Madera Ron Diskin Roopa Prabhu Rustam Kovhaev Sabrina Dubroca Saeed Mahameed Salvatore Bonaccorso Santosh Shilimkar Shannon Nelson Song Liu Steffen Klassert Subbaraya Sundeep Sunil Goutham Taehee Yoo Tanner Love Thomas Falcon Thomas Gleixner Thomas Richter Tobias Brunner Tony Nguyen Vasanthakumar Thiagarajan Vladimir Oltean Wang Hai Wanpeng Li Wei Li Will Deacon Willem de Bruijn Wolfram Sang Wolfram Sang Xin Long Xin Tan Xin Xiong Xiyu Yang Yangbo Lu Yonglong Liu Yunsheng Lin jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw fail test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 3523 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Aug 04 13:19:00 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 13:19:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2wqB-0005in-6O; Tue, 04 Aug 2020 13:18:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2wqA-0005ii-0b for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 13:18:50 +0000 X-Inumbo-ID: 261eb5e3-4e59-4e09-9f8d-c71fdf3624f7 Received: from mail-wm1-x342.google.com (unknown [2a00:1450:4864:20::342]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 261eb5e3-4e59-4e09-9f8d-c71fdf3624f7; Tue, 04 Aug 2020 13:18:48 +0000 (UTC) Received: by mail-wm1-x342.google.com with SMTP id k20so2876416wmi.5 for ; Tue, 04 Aug 2020 06:18:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:content-language :thread-index; bh=+OaZ7tXWIqT0JKgQfjEJpgOpykpNB8yWAZ8qPO7QOhI=; b=LjdMZIcnmlGIbVkCvBdPn/rOh9eg6r2CWf/AQQyFmG2M1jsO6vveeTHFey8fLYE4/L Hozp5KastVX28g3QDILuEBoLeSzyVeciSf0B//wqith1IWzasctLDHjR7pXu1NfngWI8 J2Lr4U/K5D0TL6Vs6yMdYKapJqi5KOE11aKxVX8Ff6Zte7k/NJzyO0oMi9B50uepNFsd uPJI5wjohQb3OWMlaOGJ837e9snJ55qw0FlXTJwpVSEOuI7jjIf3CKz73P1PQNhZA89F Acu7LM4TZI2DKiMpJooBx4N+vM6COT2HtqtLJVlGscO8q9xaPS4QBOXgU4a1JslYR8WV GyEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:to:cc:references:in-reply-to :subject:date:message-id:mime-version:content-transfer-encoding :content-language:thread-index; bh=+OaZ7tXWIqT0JKgQfjEJpgOpykpNB8yWAZ8qPO7QOhI=; b=BrnpPp9nD6G2bhaHMM5Z3WardIA56lS81zICb4/RsM/FEgE7WvQmZXxdPTxzj2ew23 XPSjl6R12IwkzrhsZz2rEUTl112NG5JF5KZ8fIAWnLNc3A6S0+rMNG0Ev4qw6t6NEbyR ppKkA+DvigA3j1jsqFO30qmLKy5+kckgsj2zAfr93NMuQf81L9aHTxv5W6EZ2drUUjlr j94k8CfM14YXwBn50zE2JLm1S3gA5W7J86qljUf7A0Fn0ba3ZqI+FkcZjUeH5jwKbWKT 6BF5JbNH5g7dhAihci5758FwDCKCsKlZcujxvX8243/nbVsxRz/1iQ5Firzzin3O1Toc M3aQ== X-Gm-Message-State: AOAM5308DeOHprRKELb/uBEw/hWUwkwrll9Xd9KtsgC1jCeUw+XkJXcB cSZlF3IVusiwBjyCOkDnb2k= X-Google-Smtp-Source: ABdhPJwYvynzg7XP+NCMOyYm30Gl+2Z/GBc5rp7kPMvE3bzWC05EUFALD6wf4EPs4xUHMKy33K2FMg== X-Received: by 2002:a1c:c28b:: with SMTP id s133mr3982461wmf.43.1596547128039; Tue, 04 Aug 2020 06:18:48 -0700 (PDT) Received: from CBGR90WXYV0 ([2a00:23c5:5785:9a01:ad9a:ab78:5748:a7ec]) by smtp.gmail.com with ESMTPSA id b139sm5068608wmd.19.2020.08.04.06.18.46 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Aug 2020 06:18:47 -0700 (PDT) From: Paul Durrant X-Google-Original-From: "Paul Durrant" To: "'Oleksandr'" , References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-2-git-send-email-olekstysh@gmail.com> <000c01d66a33$2bd56510$83802f30$@xen.org> <9f83a7ed-ca97-449f-c7b9-a1140644abe9@gmail.com> <002101d66a51$b4c59070$1e50b150$@xen.org> <396a0833-021c-c21a-1dcf-cc8bddd1f4a9@gmail.com> In-Reply-To: <396a0833-021c-c21a-1dcf-cc8bddd1f4a9@gmail.com> Subject: RE: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common Date: Tue, 4 Aug 2020 14:18:48 +0100 Message-ID: <002401d66a61$ca9c2110$5fd46330$@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Content-Language: en-gb Thread-Index: AQIHYXuU00Oy15gaFT3m+7M9vTQs4QHrpydYAen0VmICUR8SMQI7+bD/AfnOTImocxvKYA== X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: paul@xen.org Cc: 'Kevin Tian' , 'Stefano Stabellini' , 'Julien Grall' , 'Jun Nakajima' , 'Wei Liu' , 'Andrew Cooper' , 'Ian Jackson' , 'George Dunlap' , 'Tim Deegan' , 'Oleksandr Tyshchenko' , 'Julien Grall' , 'Jan Beulich' , =?utf-8?Q?'Roger_Pau_Monn=C3=A9'?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" > -----Original Message----- > From: Oleksandr > Sent: 04 August 2020 12:51 > To: paul@xen.org; xen-devel@lists.xenproject.org > Cc: 'Oleksandr Tyshchenko' ; 'Jan = Beulich' ; 'Andrew > Cooper' ; 'Wei Liu' ; 'Roger = Pau Monn=C3=A9' ; > 'George Dunlap' ; 'Ian Jackson' = ; 'Julien Grall' > ; 'Stefano Stabellini' ; 'Jun = Nakajima' > ; 'Kevin Tian' ; 'Tim = Deegan' ; 'Julien > Grall' > Subject: Re: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature = common >=20 >=20 > On 04.08.20 14:23, Paul Durrant wrote: > >> > >>> diff --git a/xen/include/xen/hvm/ioreq.h = b/xen/include/xen/hvm/ioreq.h > >>>> new file mode 100644 > >>>> index 0000000..40b7b5e > >>>> --- /dev/null > >>>> +++ b/xen/include/xen/hvm/ioreq.h > >>>> @@ -0,0 +1,89 @@ > >>>> +/* > >>>> + * hvm.h: Hardware virtual machine assist interface definitions. > >>>> + * > >>>> + * Copyright (c) 2016 Citrix Systems Inc. > >>>> + * > >>>> + * This program is free software; you can redistribute it and/or = modify it > >>>> + * under the terms and conditions of the GNU General Public = License, > >>>> + * version 2, as published by the Free Software Foundation. > >>>> + * > >>>> + * This program is distributed in the hope it will be useful, = but WITHOUT > >>>> + * ANY WARRANTY; without even the implied warranty of = MERCHANTABILITY or > >>>> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public = License for > >>>> + * more details. > >>>> + * > >>>> + * You should have received a copy of the GNU General Public = License along with > >>>> + * this program; If not, see . > >>>> + */ > >>>> + > >>>> +#ifndef __HVM_IOREQ_H__ > >>>> +#define __HVM_IOREQ_H__ > >>>> + > >>>> +#include > >>>> + > >>>> +#include > >>>> + > >>>> +#define GET_IOREQ_SERVER(d, id) \ > >>>> + (d)->arch.hvm.ioreq_server.server[id] > >>>> + > >>>> +static inline struct hvm_ioreq_server *get_ioreq_server(const = struct domain *d, > >>>> + unsigned = int id) > >>>> +{ > >>>> + if ( id >=3D MAX_NR_IOREQ_SERVERS ) > >>>> + return NULL; > >>>> + > >>>> + return GET_IOREQ_SERVER(d, id); > >>>> +} > >>>> + > >>>> +static inline bool hvm_ioreq_needs_completion(const ioreq_t = *ioreq) > >>>> +{ > >>>> + return ioreq->state =3D=3D STATE_IOREQ_READY && > >>>> + !ioreq->data_is_ptr && > >>>> + (ioreq->type !=3D IOREQ_TYPE_PIO || ioreq->dir !=3D = IOREQ_WRITE); > >>>> +} > >>> I don't think having this in common code is correct. The short-cut = of not completing PIO reads > seems > >> somewhat x86 specific. Does ARM even have the concept of PIO? > >> > >> I am not 100% sure here, but it seems that doesn't have. > >> > >> Shall I make hvm_ioreq_needs_completion() per arch? Arm variant = would > >> have the same implementation, but without "ioreq->type !=3D > >> IOREQ_TYPE_PIO" check... > >> > > With your series applied, does any common code actually call = hvm_ioreq_needs_completion()? I suspect > it will remain x86 specific, without any need for an Arm variant. > Yes, it does. Please see common usage in hvm_io_assist() and > handle_hvm_io_completion() (current patch) and usage in Arm code > (arch/arm/io.c: io_state try_fwd_ioserv) [1] >=20 >=20 > [1] > = https://lists.xenproject.org/archives/html/xen-devel/2020-08/msg00072.htm= l >=20 Yes, but that code is clearly not finished since, after setting = io_completion it says: /* XXX: Decide what to do */ if ( rc =3D=3D IO_RETRY ) rc =3D IO_HANDLED; So, it's not clear what the eventual implementation will be and whether = it will need to make that call. Paul >=20 > -- > Regards, >=20 > Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Tue Aug 04 13:20:05 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 13:20:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2wrM-0006IG-LK; Tue, 04 Aug 2020 13:20:04 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2wrK-0005yN-SX for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 13:20:02 +0000 X-Inumbo-ID: 3fcca171-1d6e-4621-ac50-7669bde0fb1b Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3fcca171-1d6e-4621-ac50-7669bde0fb1b; Tue, 04 Aug 2020 13:20:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596547201; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=PJGeRv+JQkIXau8HxNCjCmynwmnMY5Ci9xTKGvS7QLU=; b=KgSFay+6mgwona/OW3FeuhDBxrT5Ks0U6Je4HPaSKuRbzj08nZ2vhdDP Zc8rVF8NaKTGLpA5Zy7Al8TZHZq/yAYTpGuQH8Rldtb8ZUcGLKvqeDYqI 4+DPUhBEPRKlIWR/g6S2DSWB040EKapbP9FaPI/efMLtURotBdhNT7DBK c=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: mmZ1w8wGMdgcbwsEJkHf78wDVmy4D8SLLB/y6+di9wLsIPRbS3X+ekvsHWPS4bRYuIlCzjiev7 RwGcZ2aCv2Luv9sEH5PkFv0FA1fGZlAEuS1lkpGBHSNJ8gtp3Ynxa6yYHfVr5r6MmMmmq3ellt xTap3NlACrHUwTGA4kFa5eC8eG2WgcwyACqDPbgf6BhdvFkW3hb+OeLoUD4PS3zspXm0cWrnnw 4HW8CjwualxsnSiErEB9dfEC/LtAHzYJujmN9XsnZq2OwF7qbudI/wwCCG9Kkr7yQBLaRudOH9 6Yw= X-SBRS: 3.7 X-MesageID: 24147975 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,434,1589256000"; d="scan'208";a="24147975" Subject: Re: [PATCH] x86emul: replace further UB shifts To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <0ae25858-f981-1552-0a3c-58a9733a758a@suse.com> From: Andrew Cooper Message-ID: Date: Tue, 4 Aug 2020 14:19:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <0ae25858-f981-1552-0a3c-58a9733a758a@suse.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 04/08/2020 11:13, Jan Beulich wrote: > I have no explanation how I managed to overlook these while putting > together what is now b6a907f8c83d ("x86emul: replace UB shifts"). > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper I've just checked, and GCC 9.3.0 does convert this pattern back to a single shift instruction, so at least we're not left with real mul instructions. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Aug 04 13:31:23 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 13:31:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2x2B-0007Rm-Mx; Tue, 04 Aug 2020 13:31:15 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2x2A-0007Rh-Ag for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 13:31:14 +0000 X-Inumbo-ID: a62b8f89-fafd-4d3a-bead-38dfb9e55709 Received: from mail-wm1-x330.google.com (unknown [2a00:1450:4864:20::330]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a62b8f89-fafd-4d3a-bead-38dfb9e55709; Tue, 04 Aug 2020 13:31:13 +0000 (UTC) Received: by mail-wm1-x330.google.com with SMTP id k8so2943557wma.2 for ; Tue, 04 Aug 2020 06:31:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:content-language :thread-index; bh=Exfbsw1LYEHKpD3Fp0p8k5eNg19gqSg72l4KRzBAg6I=; b=HzPtCS01eh92n0k2bVH+lNGZU7hA5R1TKEV55OVPjq+4O6sQK2DQLNlJ4DWmnRcqSm ma1eeCoWGWFAReStrM98iWYfSp2ROtMfVzrKQ1x52jfZ9x8jNNtO6Wx6tmCWm2yiF8nr KJ3B5sU6yeRbW0UorRDLa2ONV+Ml5gl/jXLdkDtl1STDJP8h9seg9eQdK1lIHWQo3jDe 8m+ls99C3Lq8w+6hks+vAAsh0dheP9Eh6ZOAZu4KMmfkEqb5+dP3qAAjP6B2lCRmpFZf a1PUHKhWcELztWCH2WyBPgaOyFua/8FOdg1gc1WFfXYIkv6VglvCVHkYk0DdGJ+Wc/n2 IrJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:to:cc:references:in-reply-to :subject:date:message-id:mime-version:content-transfer-encoding :content-language:thread-index; bh=Exfbsw1LYEHKpD3Fp0p8k5eNg19gqSg72l4KRzBAg6I=; b=BB7Bes3KblpCHGauJwXBJ78Zgit7Tx7hexc6wTw2nMfAeSGDVLgXTJlMFLA89nvvjV Qsrq9t53Fpe7o8w9BQctr5izZiMTZ2rG3zCubSV5qLy1b89Bpx344vKPWPZ0DXWJjeak iBDmbRe1lxPt8DSZFvwc0X4ERqFmXNQzbNvDKUqSIyoY3YKNkncUnXpNVOJCiv2waRuq uBcfCar7z0fDcwxZxzAtGPStK/zUaf42320x9L16SXZdGH+cdSKocpdSzrCgga6+3HDm uKJOqXI3EMdIo8/R4iPYs7jl44+xf10iLdlmDvAugzito9wnS8nbbuVk0KAlb0f4oAUL OwWw== X-Gm-Message-State: AOAM5334aiNj4opoZSe8U5Aw9puwMWjZ5N+Gz4Njia17s0dYazFnT0/c crTd9OQhU412JFEUYW26Ex0= X-Google-Smtp-Source: ABdhPJxxd5wng/cXBMewHz/8C3Z5LQFtsMnssxfrxAa/vBg5aukG6FkeVrYQyCo33P23uACXfImFQg== X-Received: by 2002:a1c:1d92:: with SMTP id d140mr4171448wmd.143.1596547872188; Tue, 04 Aug 2020 06:31:12 -0700 (PDT) Received: from CBGR90WXYV0 ([2a00:23c5:5785:9a01:ad9a:ab78:5748:a7ec]) by smtp.gmail.com with ESMTPSA id l10sm30624211wru.3.2020.08.04.06.31.10 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Aug 2020 06:31:10 -0700 (PDT) From: Paul Durrant X-Google-Original-From: "Paul Durrant" To: "'Ian Jackson'" References: <20200803124931.2678-1-paul@xen.org> <20200803124931.2678-5-paul@xen.org> <24361.17132.762055.478992@mariner.uk.xensource.com> <002001d66a51$3cd055f0$b67101d0$@xen.org> <24361.18433.500622.984594@mariner.uk.xensource.com> In-Reply-To: <24361.18433.500622.984594@mariner.uk.xensource.com> Subject: RE: [PATCH v2 4/4] tools/hotplug: modify set_mtu() to inform the frontend via xenstore Date: Tue, 4 Aug 2020 14:31:12 +0100 Message-ID: <002801d66a63$85fb8c10$91f2a430$@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: en-gb Thread-Index: AQIYGZMBbauEfHj5QMvrSYCboUsizgIdsxRvAjZRG38CQrq5MgKDUJ7HqFvABxA= X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: paul@xen.org Cc: xen-devel@lists.xenproject.org, 'Paul Durrant' , 'Wei Liu' Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" > -----Original Message----- > From: Ian Jackson > Sent: 04 August 2020 12:35 > To: paul@xen.org > Cc: xen-devel@lists.xenproject.org; 'Paul Durrant' ; 'Wei Liu' > Subject: RE: [PATCH v2 4/4] tools/hotplug: modify set_mtu() to inform the frontend via xenstore > > Paul Durrant writes ("RE: [PATCH v2 4/4] tools/hotplug: modify set_mtu() to inform the frontend via > xenstore"): > > > -----Original Message----- > > > From: Ian Jackson > > > Sent: 04 August 2020 12:14 > > > To: Paul Durrant > > > Cc: xen-devel@lists.xenproject.org; Paul Durrant ; Wei Liu > > > Subject: Re: [PATCH v2 4/4] tools/hotplug: modify set_mtu() to inform the frontend via xenstore > > > > > > Paul Durrant writes ("[PATCH v2 4/4] tools/hotplug: modify set_mtu() to inform the frontend via > > > xenstore"): > > > > + XENBUS_PATH="/local/domain/$domid/device/vif/$devid" > > > > + xenstore_write "$XENBUS_PATH/mtu" ${mtu} > > > > > > It's surprising to me that this code doesn't have the xenbus path > > > already in some variable. But I guess from the fact that you've added > > > this code, that it doesn't. > > > > It is set, but set to the backend path. For safety I guess it's probably best if I use a local in > this instance. Can I keep your R-b > > with such a change? > > Oh, wow. I hadn't realised that. I take back my earlier R-b :-). > > Can you please use a different variable name for the frontend path ? > OK. > ... > > Actually. > > This shouldn't be in the frontend at all, should it ? In general the > backend writes to the backend and the frontend to the frontend. > > So maybe I need to take back my R-b of > [PATCH v2 3/4] public/io/netif: specify MTU override node > > Sorry for the confusion. I seem rather undercaffienated today. > Too late. The xenstore node has been used by Windows frontends for the best part of a decade so we can't practically change the path. Another way would be to also modify netback to simply echo the value from backend into frontend, but that seems rather pointless. Interestingly libxl does define an 'mtu' field for libxl_device_nic, which it sets to 1492 in libxl__device_nic_setdefault() but never writes it into xenstore. There is even a comment: /* nic->mtu = */ in libxl__nic_from_xenstore() which implies it should have been there, but isn't. I still think picking up the MTU from the bridge is the better way though. Paul > Ian. From xen-devel-bounces@lists.xenproject.org Tue Aug 04 13:42:27 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 13:42:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xD0-0008NF-FF; Tue, 04 Aug 2020 13:42:26 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xCy-0008MU-Kl for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 13:42:24 +0000 X-Inumbo-ID: 8c99a871-8be8-4c3f-860d-3ef4149e67ed Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8c99a871-8be8-4c3f-860d-3ef4149e67ed; Tue, 04 Aug 2020 13:42:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4AoX2QcMIWlbm0K+83CDzVNO/lJ0Ivxf4f14fPbq6/4=; b=cfHxKelb8MqC2GoxjZCC5ILcex ULTpIT4ey1zmoWCYA1yl1hdAyliI0OFHNfFQIt40F5wCbeJB+3f/Jm6r+7DhtPLqekd7Sf0oYvhdK qdw+Ybe3HRk2N9kPXcagbBZkYlqVoyoWGHctUNk8DTSFFFK0VcW0kU+9HrtazgQJPfUs=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xCt-00084B-SL; Tue, 04 Aug 2020 13:42:19 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2xCt-0003ag-L8; Tue, 04 Aug 2020 13:42:19 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v4 05/14] iommu: remove unused iommu_ops method and tasklet Date: Tue, 4 Aug 2020 14:42:00 +0100 Message-Id: <20200804134209.8717-6-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200804134209.8717-1-paul@xen.org> References: <20200804134209.8717-1-paul@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Paul Durrant , Jan Beulich Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant The VT-d and AMD IOMMU implementations both use the general x86 IOMMU page table allocator and ARM always shares page tables with CPU. Hence there is no need to retain the free_page_table() method or the tasklet which invokes it. Signed-off-by: Paul Durrant Reviewed-by: Jan Beulich --- v2: - New in v2 (split from "add common page-table allocator") --- xen/drivers/passthrough/iommu.c | 25 ------------------------- xen/include/xen/iommu.h | 2 -- 2 files changed, 27 deletions(-) diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c index 2b1db8022c..660dc5deb2 100644 --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -49,10 +49,6 @@ bool_t __read_mostly amd_iommu_perdev_intremap = 1; DEFINE_PER_CPU(bool_t, iommu_dont_flush_iotlb); -DEFINE_SPINLOCK(iommu_pt_cleanup_lock); -PAGE_LIST_HEAD(iommu_pt_cleanup_list); -static struct tasklet iommu_pt_cleanup_tasklet; - static int __init parse_iommu_param(const char *s) { const char *ss; @@ -226,9 +222,6 @@ static void iommu_teardown(struct domain *d) struct domain_iommu *hd = dom_iommu(d); iommu_vcall(hd->platform_ops, teardown, d); - - if ( hd->platform_ops->free_page_table ) - tasklet_schedule(&iommu_pt_cleanup_tasklet); } void iommu_domain_destroy(struct domain *d) @@ -368,23 +361,6 @@ int iommu_lookup_page(struct domain *d, dfn_t dfn, mfn_t *mfn, return iommu_call(hd->platform_ops, lookup_page, d, dfn, mfn, flags); } -static void iommu_free_pagetables(void *unused) -{ - do { - struct page_info *pg; - - spin_lock(&iommu_pt_cleanup_lock); - pg = page_list_remove_head(&iommu_pt_cleanup_list); - spin_unlock(&iommu_pt_cleanup_lock); - if ( !pg ) - return; - iommu_vcall(iommu_get_ops(), free_page_table, pg); - } while ( !softirq_pending(smp_processor_id()) ); - - tasklet_schedule_on_cpu(&iommu_pt_cleanup_tasklet, - cpumask_cycle(smp_processor_id(), &cpu_online_map)); -} - int iommu_iotlb_flush(struct domain *d, dfn_t dfn, unsigned int page_count, unsigned int flush_flags) { @@ -508,7 +484,6 @@ int __init iommu_setup(void) #ifndef iommu_intremap printk("Interrupt remapping %sabled\n", iommu_intremap ? "en" : "dis"); #endif - tasklet_init(&iommu_pt_cleanup_tasklet, iommu_free_pagetables, NULL); } return rc; diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h index 3272874958..1831dc66b0 100644 --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -263,8 +263,6 @@ struct iommu_ops { int __must_check (*lookup_page)(struct domain *d, dfn_t dfn, mfn_t *mfn, unsigned int *flags); - void (*free_page_table)(struct page_info *); - #ifdef CONFIG_X86 int (*enable_x2apic)(void); void (*disable_x2apic)(void); -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 13:42:27 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 13:42:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xD0-0008N7-6g; Tue, 04 Aug 2020 13:42:26 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xCy-0008MP-25 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 13:42:24 +0000 X-Inumbo-ID: 8b828853-af9b-4a18-a32c-12d6bd55ee67 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8b828853-af9b-4a18-a32c-12d6bd55ee67; Tue, 04 Aug 2020 13:42:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QN4Jn8X04mBQxJgwotT2yBdMxM4X5ozPmZb9cH/rnGk=; b=KkTTPXw4sUpkf7CYQ7G7CrLi6v 2niOYQYYlbmN2NBYj9jrwCo3wohymes0yYUQ6+xdLP17x+WuokunTkvW791gT8gQWCcKQGdzg0XAF FPhrHQvOAA3o4yfmScICQVARh4Z2fOocIGsCcbFANsWNpZ6Rsk/t9DPTIlkQipP/6FtQ=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xCq-00083q-6p; Tue, 04 Aug 2020 13:42:16 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2xCp-0003ag-UM; Tue, 04 Aug 2020 13:42:16 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v4 01/14] x86/iommu: re-arrange arch_iommu to separate common fields... Date: Tue, 4 Aug 2020 14:41:56 +0100 Message-Id: <20200804134209.8717-2-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200804134209.8717-1-paul@xen.org> References: <20200804134209.8717-1-paul@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Tian , Wei Liu , Andrew Cooper , Paul Durrant , Lukasz Hawrylko , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant ... from those specific to VT-d or AMD IOMMU, and put the latter in a union. There is no functional change in this patch, although the initialization of the 'mapped_rmrrs' list occurs slightly later in iommu_domain_init() since it is now done (correctly) in VT-d specific code rather than in general x86 code. NOTE: I have not combined the AMD IOMMU 'root_table' and VT-d 'pgd_maddr' fields even though they perform essentially the same function. The concept of 'root table' in the VT-d code is different from that in the AMD code so attempting to use a common name will probably only serve to confuse the reader. Signed-off-by: Paul Durrant Acked-by: Jan Beulich --- Cc: Lukasz Hawrylko Cc: Andrew Cooper Cc: Wei Liu Cc: "Roger Pau Monné" Cc: Kevin Tian v4: - Fix format specifier as requested by Jan v2: - s/amd_iommu/amd - Definitions still left inline as re-arrangement into implementation headers is non-trivial - Also s/u64/uint64_t and s/int/unsigned int --- xen/arch/x86/tboot.c | 4 +- xen/drivers/passthrough/amd/iommu_guest.c | 8 ++-- xen/drivers/passthrough/amd/iommu_map.c | 14 +++--- xen/drivers/passthrough/amd/pci_amd_iommu.c | 35 +++++++------- xen/drivers/passthrough/vtd/iommu.c | 53 +++++++++++---------- xen/drivers/passthrough/x86/iommu.c | 1 - xen/include/asm-x86/iommu.h | 27 +++++++---- 7 files changed, 78 insertions(+), 64 deletions(-) diff --git a/xen/arch/x86/tboot.c b/xen/arch/x86/tboot.c index 320e06f129..e66b0940c4 100644 --- a/xen/arch/x86/tboot.c +++ b/xen/arch/x86/tboot.c @@ -230,8 +230,8 @@ static void tboot_gen_domain_integrity(const uint8_t key[TB_KEY_SIZE], { const struct domain_iommu *dio = dom_iommu(d); - update_iommu_mac(&ctx, dio->arch.pgd_maddr, - agaw_to_level(dio->arch.agaw)); + update_iommu_mac(&ctx, dio->arch.vtd.pgd_maddr, + agaw_to_level(dio->arch.vtd.agaw)); } } diff --git a/xen/drivers/passthrough/amd/iommu_guest.c b/xen/drivers/passthrough/amd/iommu_guest.c index 014a72a54b..30b7353cd6 100644 --- a/xen/drivers/passthrough/amd/iommu_guest.c +++ b/xen/drivers/passthrough/amd/iommu_guest.c @@ -50,12 +50,12 @@ static uint16_t guest_bdf(struct domain *d, uint16_t machine_bdf) static inline struct guest_iommu *domain_iommu(struct domain *d) { - return dom_iommu(d)->arch.g_iommu; + return dom_iommu(d)->arch.amd.g_iommu; } static inline struct guest_iommu *vcpu_iommu(struct vcpu *v) { - return dom_iommu(v->domain)->arch.g_iommu; + return dom_iommu(v->domain)->arch.amd.g_iommu; } static void guest_iommu_enable(struct guest_iommu *iommu) @@ -823,7 +823,7 @@ int guest_iommu_init(struct domain* d) guest_iommu_reg_init(iommu); iommu->mmio_base = ~0ULL; iommu->domain = d; - hd->arch.g_iommu = iommu; + hd->arch.amd.g_iommu = iommu; tasklet_init(&iommu->cmd_buffer_tasklet, guest_iommu_process_command, d); @@ -845,5 +845,5 @@ void guest_iommu_destroy(struct domain *d) tasklet_kill(&iommu->cmd_buffer_tasklet); xfree(iommu); - dom_iommu(d)->arch.g_iommu = NULL; + dom_iommu(d)->arch.amd.g_iommu = NULL; } diff --git a/xen/drivers/passthrough/amd/iommu_map.c b/xen/drivers/passthrough/amd/iommu_map.c index 93e96cd69c..47b4472e8a 100644 --- a/xen/drivers/passthrough/amd/iommu_map.c +++ b/xen/drivers/passthrough/amd/iommu_map.c @@ -180,8 +180,8 @@ static int iommu_pde_from_dfn(struct domain *d, unsigned long dfn, struct page_info *table; const struct domain_iommu *hd = dom_iommu(d); - table = hd->arch.root_table; - level = hd->arch.paging_mode; + table = hd->arch.amd.root_table; + level = hd->arch.amd.paging_mode; BUG_ON( table == NULL || level < 1 || level > 6 ); @@ -325,7 +325,7 @@ int amd_iommu_unmap_page(struct domain *d, dfn_t dfn, spin_lock(&hd->arch.mapping_lock); - if ( !hd->arch.root_table ) + if ( !hd->arch.amd.root_table ) { spin_unlock(&hd->arch.mapping_lock); return 0; @@ -450,7 +450,7 @@ int __init amd_iommu_quarantine_init(struct domain *d) unsigned int level = amd_iommu_get_paging_mode(end_gfn); struct amd_iommu_pte *table; - if ( hd->arch.root_table ) + if ( hd->arch.amd.root_table ) { ASSERT_UNREACHABLE(); return 0; @@ -458,11 +458,11 @@ int __init amd_iommu_quarantine_init(struct domain *d) spin_lock(&hd->arch.mapping_lock); - hd->arch.root_table = alloc_amd_iommu_pgtable(); - if ( !hd->arch.root_table ) + hd->arch.amd.root_table = alloc_amd_iommu_pgtable(); + if ( !hd->arch.amd.root_table ) goto out; - table = __map_domain_page(hd->arch.root_table); + table = __map_domain_page(hd->arch.amd.root_table); while ( level ) { struct page_info *pg; diff --git a/xen/drivers/passthrough/amd/pci_amd_iommu.c b/xen/drivers/passthrough/amd/pci_amd_iommu.c index 5f5f4a2eac..09a05f9d75 100644 --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c @@ -91,7 +91,8 @@ static void amd_iommu_setup_domain_device( u8 bus = pdev->bus; const struct domain_iommu *hd = dom_iommu(domain); - BUG_ON( !hd->arch.root_table || !hd->arch.paging_mode || + BUG_ON( !hd->arch.amd.root_table || + !hd->arch.amd.paging_mode || !iommu->dev_table.buffer ); if ( iommu_hwdom_passthrough && is_hardware_domain(domain) ) @@ -110,8 +111,8 @@ static void amd_iommu_setup_domain_device( /* bind DTE to domain page-tables */ amd_iommu_set_root_page_table( - dte, page_to_maddr(hd->arch.root_table), domain->domain_id, - hd->arch.paging_mode, valid); + dte, page_to_maddr(hd->arch.amd.root_table), + domain->domain_id, hd->arch.amd.paging_mode, valid); /* Undo what amd_iommu_disable_domain_device() may have done. */ ivrs_dev = &get_ivrs_mappings(iommu->seg)[req_id]; @@ -131,8 +132,8 @@ static void amd_iommu_setup_domain_device( "root table = %#"PRIx64", " "domain = %d, paging mode = %d\n", req_id, pdev->type, - page_to_maddr(hd->arch.root_table), - domain->domain_id, hd->arch.paging_mode); + page_to_maddr(hd->arch.amd.root_table), + domain->domain_id, hd->arch.amd.paging_mode); } spin_unlock_irqrestore(&iommu->lock, flags); @@ -206,10 +207,10 @@ static int iov_enable_xt(void) int amd_iommu_alloc_root(struct domain_iommu *hd) { - if ( unlikely(!hd->arch.root_table) ) + if ( unlikely(!hd->arch.amd.root_table) ) { - hd->arch.root_table = alloc_amd_iommu_pgtable(); - if ( !hd->arch.root_table ) + hd->arch.amd.root_table = alloc_amd_iommu_pgtable(); + if ( !hd->arch.amd.root_table ) return -ENOMEM; } @@ -239,7 +240,7 @@ static int amd_iommu_domain_init(struct domain *d) * physical address space we give it, but this isn't known yet so use 4 * unilaterally. */ - hd->arch.paging_mode = amd_iommu_get_paging_mode( + hd->arch.amd.paging_mode = amd_iommu_get_paging_mode( is_hvm_domain(d) ? 1ul << (DEFAULT_DOMAIN_ADDRESS_WIDTH - PAGE_SHIFT) : get_upper_mfn_bound() + 1); @@ -305,7 +306,7 @@ static void amd_iommu_disable_domain_device(const struct domain *domain, AMD_IOMMU_DEBUG("Disable: device id = %#x, " "domain = %d, paging mode = %d\n", req_id, domain->domain_id, - dom_iommu(domain)->arch.paging_mode); + dom_iommu(domain)->arch.amd.paging_mode); } spin_unlock_irqrestore(&iommu->lock, flags); @@ -420,10 +421,11 @@ static void deallocate_iommu_page_tables(struct domain *d) struct domain_iommu *hd = dom_iommu(d); spin_lock(&hd->arch.mapping_lock); - if ( hd->arch.root_table ) + if ( hd->arch.amd.root_table ) { - deallocate_next_page_table(hd->arch.root_table, hd->arch.paging_mode); - hd->arch.root_table = NULL; + deallocate_next_page_table(hd->arch.amd.root_table, + hd->arch.amd.paging_mode); + hd->arch.amd.root_table = NULL; } spin_unlock(&hd->arch.mapping_lock); } @@ -598,11 +600,12 @@ static void amd_dump_p2m_table(struct domain *d) { const struct domain_iommu *hd = dom_iommu(d); - if ( !hd->arch.root_table ) + if ( !hd->arch.amd.root_table ) return; - printk("p2m table has %d levels\n", hd->arch.paging_mode); - amd_dump_p2m_table_level(hd->arch.root_table, hd->arch.paging_mode, 0, 0); + printk("p2m table has %u levels\n", hd->arch.amd.paging_mode); + amd_dump_p2m_table_level(hd->arch.amd.root_table, + hd->arch.amd.paging_mode, 0, 0); } static const struct iommu_ops __initconstrel _iommu_ops = { diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c index deaeab095d..94e0455a4d 100644 --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -257,20 +257,20 @@ static u64 bus_to_context_maddr(struct vtd_iommu *iommu, u8 bus) static u64 addr_to_dma_page_maddr(struct domain *domain, u64 addr, int alloc) { struct domain_iommu *hd = dom_iommu(domain); - int addr_width = agaw_to_width(hd->arch.agaw); + int addr_width = agaw_to_width(hd->arch.vtd.agaw); struct dma_pte *parent, *pte = NULL; - int level = agaw_to_level(hd->arch.agaw); + int level = agaw_to_level(hd->arch.vtd.agaw); int offset; u64 pte_maddr = 0; addr &= (((u64)1) << addr_width) - 1; ASSERT(spin_is_locked(&hd->arch.mapping_lock)); - if ( !hd->arch.pgd_maddr && + if ( !hd->arch.vtd.pgd_maddr && (!alloc || - ((hd->arch.pgd_maddr = alloc_pgtable_maddr(1, hd->node)) == 0)) ) + ((hd->arch.vtd.pgd_maddr = alloc_pgtable_maddr(1, hd->node)) == 0)) ) goto out; - parent = (struct dma_pte *)map_vtd_domain_page(hd->arch.pgd_maddr); + parent = (struct dma_pte *)map_vtd_domain_page(hd->arch.vtd.pgd_maddr); while ( level > 1 ) { offset = address_level_offset(addr, level); @@ -593,7 +593,7 @@ static int __must_check iommu_flush_iotlb(struct domain *d, dfn_t dfn, { iommu = drhd->iommu; - if ( !test_bit(iommu->index, &hd->arch.iommu_bitmap) ) + if ( !test_bit(iommu->index, &hd->arch.vtd.iommu_bitmap) ) continue; flush_dev_iotlb = !!find_ats_dev_drhd(iommu); @@ -1278,7 +1278,10 @@ void __init iommu_free(struct acpi_drhd_unit *drhd) static int intel_iommu_domain_init(struct domain *d) { - dom_iommu(d)->arch.agaw = width_to_agaw(DEFAULT_DOMAIN_ADDRESS_WIDTH); + struct domain_iommu *hd = dom_iommu(d); + + hd->arch.vtd.agaw = width_to_agaw(DEFAULT_DOMAIN_ADDRESS_WIDTH); + INIT_LIST_HEAD(&hd->arch.vtd.mapped_rmrrs); return 0; } @@ -1375,10 +1378,10 @@ int domain_context_mapping_one( spin_lock(&hd->arch.mapping_lock); /* Ensure we have pagetables allocated down to leaf PTE. */ - if ( hd->arch.pgd_maddr == 0 ) + if ( hd->arch.vtd.pgd_maddr == 0 ) { addr_to_dma_page_maddr(domain, 0, 1); - if ( hd->arch.pgd_maddr == 0 ) + if ( hd->arch.vtd.pgd_maddr == 0 ) { nomem: spin_unlock(&hd->arch.mapping_lock); @@ -1389,7 +1392,7 @@ int domain_context_mapping_one( } /* Skip top levels of page tables for 2- and 3-level DRHDs. */ - pgd_maddr = hd->arch.pgd_maddr; + pgd_maddr = hd->arch.vtd.pgd_maddr; for ( agaw = level_to_agaw(4); agaw != level_to_agaw(iommu->nr_pt_levels); agaw-- ) @@ -1443,7 +1446,7 @@ int domain_context_mapping_one( if ( rc > 0 ) rc = 0; - set_bit(iommu->index, &hd->arch.iommu_bitmap); + set_bit(iommu->index, &hd->arch.vtd.iommu_bitmap); unmap_vtd_domain_page(context_entries); @@ -1714,7 +1717,7 @@ static int domain_context_unmap(struct domain *domain, u8 devfn, { int iommu_domid; - clear_bit(iommu->index, &dom_iommu(domain)->arch.iommu_bitmap); + clear_bit(iommu->index, &dom_iommu(domain)->arch.vtd.iommu_bitmap); iommu_domid = domain_iommu_domid(domain, iommu); if ( iommu_domid == -1 ) @@ -1739,7 +1742,7 @@ static void iommu_domain_teardown(struct domain *d) if ( list_empty(&acpi_drhd_units) ) return; - list_for_each_entry_safe ( mrmrr, tmp, &hd->arch.mapped_rmrrs, list ) + list_for_each_entry_safe ( mrmrr, tmp, &hd->arch.vtd.mapped_rmrrs, list ) { list_del(&mrmrr->list); xfree(mrmrr); @@ -1751,8 +1754,9 @@ static void iommu_domain_teardown(struct domain *d) return; spin_lock(&hd->arch.mapping_lock); - iommu_free_pagetable(hd->arch.pgd_maddr, agaw_to_level(hd->arch.agaw)); - hd->arch.pgd_maddr = 0; + iommu_free_pagetable(hd->arch.vtd.pgd_maddr, + agaw_to_level(hd->arch.vtd.agaw)); + hd->arch.vtd.pgd_maddr = 0; spin_unlock(&hd->arch.mapping_lock); } @@ -1892,7 +1896,7 @@ static void iommu_set_pgd(struct domain *d) mfn_t pgd_mfn; pgd_mfn = pagetable_get_mfn(p2m_get_pagetable(p2m_get_hostp2m(d))); - dom_iommu(d)->arch.pgd_maddr = + dom_iommu(d)->arch.vtd.pgd_maddr = pagetable_get_paddr(pagetable_from_mfn(pgd_mfn)); } @@ -1912,7 +1916,7 @@ static int rmrr_identity_mapping(struct domain *d, bool_t map, * No need to acquire hd->arch.mapping_lock: Both insertion and removal * get done while holding pcidevs_lock. */ - list_for_each_entry( mrmrr, &hd->arch.mapped_rmrrs, list ) + list_for_each_entry( mrmrr, &hd->arch.vtd.mapped_rmrrs, list ) { if ( mrmrr->base == rmrr->base_address && mrmrr->end == rmrr->end_address ) @@ -1959,7 +1963,7 @@ static int rmrr_identity_mapping(struct domain *d, bool_t map, mrmrr->base = rmrr->base_address; mrmrr->end = rmrr->end_address; mrmrr->count = 1; - list_add_tail(&mrmrr->list, &hd->arch.mapped_rmrrs); + list_add_tail(&mrmrr->list, &hd->arch.vtd.mapped_rmrrs); return 0; } @@ -2657,8 +2661,9 @@ static void vtd_dump_p2m_table(struct domain *d) return; hd = dom_iommu(d); - printk("p2m table has %d levels\n", agaw_to_level(hd->arch.agaw)); - vtd_dump_p2m_table_level(hd->arch.pgd_maddr, agaw_to_level(hd->arch.agaw), 0, 0); + printk("p2m table has %d levels\n", agaw_to_level(hd->arch.vtd.agaw)); + vtd_dump_p2m_table_level(hd->arch.vtd.pgd_maddr, + agaw_to_level(hd->arch.vtd.agaw), 0, 0); } static int __init intel_iommu_quarantine_init(struct domain *d) @@ -2669,7 +2674,7 @@ static int __init intel_iommu_quarantine_init(struct domain *d) unsigned int level = agaw_to_level(agaw); int rc; - if ( hd->arch.pgd_maddr ) + if ( hd->arch.vtd.pgd_maddr ) { ASSERT_UNREACHABLE(); return 0; @@ -2677,11 +2682,11 @@ static int __init intel_iommu_quarantine_init(struct domain *d) spin_lock(&hd->arch.mapping_lock); - hd->arch.pgd_maddr = alloc_pgtable_maddr(1, hd->node); - if ( !hd->arch.pgd_maddr ) + hd->arch.vtd.pgd_maddr = alloc_pgtable_maddr(1, hd->node); + if ( !hd->arch.vtd.pgd_maddr ) goto out; - parent = map_vtd_domain_page(hd->arch.pgd_maddr); + parent = map_vtd_domain_page(hd->arch.vtd.pgd_maddr); while ( level ) { uint64_t maddr; diff --git a/xen/drivers/passthrough/x86/iommu.c b/xen/drivers/passthrough/x86/iommu.c index 3d7670e8c6..a12109a1de 100644 --- a/xen/drivers/passthrough/x86/iommu.c +++ b/xen/drivers/passthrough/x86/iommu.c @@ -139,7 +139,6 @@ int arch_iommu_domain_init(struct domain *d) struct domain_iommu *hd = dom_iommu(d); spin_lock_init(&hd->arch.mapping_lock); - INIT_LIST_HEAD(&hd->arch.mapped_rmrrs); return 0; } diff --git a/xen/include/asm-x86/iommu.h b/xen/include/asm-x86/iommu.h index 6c9d5e5632..8ce97c981f 100644 --- a/xen/include/asm-x86/iommu.h +++ b/xen/include/asm-x86/iommu.h @@ -45,16 +45,23 @@ typedef uint64_t daddr_t; struct arch_iommu { - u64 pgd_maddr; /* io page directory machine address */ - spinlock_t mapping_lock; /* io page table lock */ - int agaw; /* adjusted guest address width, 0 is level 2 30-bit */ - u64 iommu_bitmap; /* bitmap of iommu(s) that the domain uses */ - struct list_head mapped_rmrrs; - - /* amd iommu support */ - int paging_mode; - struct page_info *root_table; - struct guest_iommu *g_iommu; + spinlock_t mapping_lock; /* io page table lock */ + + union { + /* Intel VT-d */ + struct { + uint64_t pgd_maddr; /* io page directory machine address */ + unsigned int agaw; /* adjusted guest address width, 0 is level 2 30-bit */ + uint64_t iommu_bitmap; /* bitmap of iommu(s) that the domain uses */ + struct list_head mapped_rmrrs; + } vtd; + /* AMD IOMMU */ + struct { + unsigned int paging_mode; + struct page_info *root_table; + struct guest_iommu *g_iommu; + } amd; + }; }; extern struct iommu_ops iommu_ops; -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 13:42:27 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 13:42:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xCu-0008MZ-MD; Tue, 04 Aug 2020 13:42:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xCt-0008MP-6q for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 13:42:19 +0000 X-Inumbo-ID: f94ac7b1-918d-45a7-8763-9eec23dc39e1 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f94ac7b1-918d-45a7-8763-9eec23dc39e1; Tue, 04 Aug 2020 13:42:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YUevJ2uOuasS55jtgIBrQn5dMBHQ7DGNAX5KglNqxbg=; b=tCbz+NysMtQRIDW27NV5t5ddxv 5dHN/DH/nff9RSm0Sly0F4HRr4TnYVptxE9U8cgmqCsbPpPEMKgcch9T9i6zhyUGZGNHskS/Hrk6Z 3yTAEAea3OBLwdlkztB4xk1iTffdu5KC/IkOFcP6uE/qpUHoXXSPSiksbeCANADMrwDA=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xCr-00083s-9j; Tue, 04 Aug 2020 13:42:17 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2xCr-0003ag-1e; Tue, 04 Aug 2020 13:42:17 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v4 02/14] x86/iommu: add common page-table allocator Date: Tue, 4 Aug 2020 14:41:57 +0100 Message-Id: <20200804134209.8717-3-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200804134209.8717-1-paul@xen.org> References: <20200804134209.8717-1-paul@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Paul Durrant , Wei Liu , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant Instead of having separate page table allocation functions in VT-d and AMD IOMMU code, we could use a common allocation function in the general x86 code. This patch adds a new allocation function, iommu_alloc_pgtable(), for this purpose. The function adds the page table pages to a list. The pages in this list are then freed by iommu_free_pgtables(), which is called by domain_relinquish_resources() after PCI devices have been de-assigned. Signed-off-by: Paul Durrant --- Cc: Jan Beulich Cc: Andrew Cooper Cc: Wei Liu Cc: "Roger Pau Monné" v4: - Remove space between '*' and '__must_check' - Reduce frequency of pre-empt check during table freeing - Fix parentheses formatting v2: - This is split out from a larger patch of the same name in v1 --- xen/arch/x86/domain.c | 9 ++++- xen/drivers/passthrough/x86/iommu.c | 51 +++++++++++++++++++++++++++++ xen/include/asm-x86/iommu.h | 7 ++++ 3 files changed, 66 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index f8084dc9e3..d1ecc7b83b 100644 --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -2153,7 +2153,8 @@ int domain_relinquish_resources(struct domain *d) d->arch.rel_priv = PROG_ ## x; /* Fallthrough */ case PROG_ ## x enum { - PROG_paging = 1, + PROG_iommu_pagetables = 1, + PROG_paging, PROG_vcpu_pagetables, PROG_shared, PROG_xen, @@ -2168,6 +2169,12 @@ int domain_relinquish_resources(struct domain *d) if ( ret ) return ret; + PROGRESS(iommu_pagetables): + + ret = iommu_free_pgtables(d); + if ( ret ) + return ret; + PROGRESS(paging): /* Tear down paging-assistance stuff. */ diff --git a/xen/drivers/passthrough/x86/iommu.c b/xen/drivers/passthrough/x86/iommu.c index a12109a1de..aea07e47c4 100644 --- a/xen/drivers/passthrough/x86/iommu.c +++ b/xen/drivers/passthrough/x86/iommu.c @@ -140,6 +140,9 @@ int arch_iommu_domain_init(struct domain *d) spin_lock_init(&hd->arch.mapping_lock); + INIT_PAGE_LIST_HEAD(&hd->arch.pgtables.list); + spin_lock_init(&hd->arch.pgtables.lock); + return 0; } @@ -257,6 +260,54 @@ void __hwdom_init arch_iommu_hwdom_init(struct domain *d) return; } +int iommu_free_pgtables(struct domain *d) +{ + struct domain_iommu *hd = dom_iommu(d); + struct page_info *pg; + unsigned int done = 0; + + while ( (pg = page_list_remove_head(&hd->arch.pgtables.list)) ) + { + free_domheap_page(pg); + + if ( !(++done & 0xff) && general_preempt_check() ) + return -ERESTART; + } + + return 0; +} + +struct page_info *iommu_alloc_pgtable(struct domain *d) +{ + struct domain_iommu *hd = dom_iommu(d); + unsigned int memflags = 0; + struct page_info *pg; + void *p; + +#ifdef CONFIG_NUMA + if ( hd->node != NUMA_NO_NODE ) + memflags = MEMF_node(hd->node); +#endif + + pg = alloc_domheap_page(NULL, memflags); + if ( !pg ) + return NULL; + + p = __map_domain_page(pg); + clear_page(p); + + if ( hd->platform_ops->sync_cache ) + iommu_vcall(hd->platform_ops, sync_cache, p, PAGE_SIZE); + + unmap_domain_page(p); + + spin_lock(&hd->arch.pgtables.lock); + page_list_add(pg, &hd->arch.pgtables.list); + spin_unlock(&hd->arch.pgtables.lock); + + return pg; +} + /* * Local variables: * mode: C diff --git a/xen/include/asm-x86/iommu.h b/xen/include/asm-x86/iommu.h index 8ce97c981f..970eb06ffa 100644 --- a/xen/include/asm-x86/iommu.h +++ b/xen/include/asm-x86/iommu.h @@ -46,6 +46,10 @@ typedef uint64_t daddr_t; struct arch_iommu { spinlock_t mapping_lock; /* io page table lock */ + struct { + struct page_list_head list; + spinlock_t lock; + } pgtables; union { /* Intel VT-d */ @@ -131,6 +135,9 @@ int pi_update_irte(const struct pi_desc *pi_desc, const struct pirq *pirq, iommu_vcall(ops, sync_cache, addr, size); \ }) +int __must_check iommu_free_pgtables(struct domain *d); +struct page_info *__must_check iommu_alloc_pgtable(struct domain *d); + #endif /* !__ARCH_X86_IOMMU_H__ */ /* * Local variables: -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 13:42:27 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 13:42:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xCu-0008Mf-UL; Tue, 04 Aug 2020 13:42:20 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xCt-0008MU-Uf for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 13:42:19 +0000 X-Inumbo-ID: 7622e856-a2f1-4fcb-a52f-8dd9985ee52e Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7622e856-a2f1-4fcb-a52f-8dd9985ee52e; Tue, 04 Aug 2020 13:42:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8IxjuGrfelQ0GDEesgxSqx9+VOb5d7SWH04DNE9oG3o=; b=EIedvXoBGl2Tw1aYppdVSMfLX3 q/9LRfnFrD7Wa9/WtkgSppUA+jxGcmP5mktbO8r1cPJwaIhLsycecpu0t5SEFw9hV7ifX7YzPHuyc aWbqwb4dpzC/T91dYa168LqgnVOq16HRZYKTwfz91/pJA+4K6mAyKXDOm99uLrd8w3DQ=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xCp-00083o-0M; Tue, 04 Aug 2020 13:42:15 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2xCo-0003ag-KK; Tue, 04 Aug 2020 13:42:14 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v4 00/14] IOMMU cleanup Date: Tue, 4 Aug 2020 14:41:55 +0100 Message-Id: <20200804134209.8717-1-paul@xen.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Tian , Stefano Stabellini , Julien Grall , Jun Nakajima , Wei Liu , Andrew Cooper , Paul Durrant , Ian Jackson , George Dunlap , Lukasz Hawrylko , Jan Beulich , Volodymyr Babchuk , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant v4: - Added three more patches to convert root_entry, context_entry and dma_pte to bit fields. Paul Durrant (14): x86/iommu: re-arrange arch_iommu to separate common fields... x86/iommu: add common page-table allocator x86/iommu: convert VT-d code to use new page table allocator x86/iommu: convert AMD IOMMU code to use new page table allocator iommu: remove unused iommu_ops method and tasklet iommu: flush I/O TLB if iommu_map() or iommu_unmap() fail iommu: make map, unmap and flush all take both an order and a count remove remaining uses of iommu_legacy_map/unmap common/grant_table: batch flush I/O TLB iommu: remove the share_p2m operation iommu: stop calling IOMMU page tables 'p2m tables' vtd: use a bit field for root_entry vtd: use a bit field for context_entry vtd: use a bit field for dma_pte xen/arch/arm/p2m.c | 2 +- xen/arch/x86/domain.c | 9 +- xen/arch/x86/mm.c | 21 +- xen/arch/x86/mm/p2m-ept.c | 20 +- xen/arch/x86/mm/p2m-pt.c | 15 +- xen/arch/x86/mm/p2m.c | 29 ++- xen/arch/x86/tboot.c | 4 +- xen/arch/x86/x86_64/mm.c | 27 +- xen/common/grant_table.c | 142 +++++++---- xen/common/memory.c | 9 +- xen/drivers/passthrough/amd/iommu.h | 20 +- xen/drivers/passthrough/amd/iommu_guest.c | 8 +- xen/drivers/passthrough/amd/iommu_map.c | 26 +- xen/drivers/passthrough/amd/pci_amd_iommu.c | 110 +++----- xen/drivers/passthrough/arm/ipmmu-vmsa.c | 2 +- xen/drivers/passthrough/arm/smmu.c | 2 +- xen/drivers/passthrough/iommu.c | 118 ++------- xen/drivers/passthrough/vtd/iommu.c | 269 +++++++++----------- xen/drivers/passthrough/vtd/iommu.h | 153 ++++++----- xen/drivers/passthrough/vtd/utils.c | 10 +- xen/drivers/passthrough/vtd/x86/ats.c | 27 +- xen/drivers/passthrough/x86/iommu.c | 54 +++- xen/include/asm-x86/iommu.h | 34 ++- xen/include/xen/iommu.h | 37 +-- 24 files changed, 585 insertions(+), 563 deletions(-) --- Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich Cc: Julien Grall Cc: Jun Nakajima Cc: Kevin Tian Cc: Lukasz Hawrylko Cc: "Roger Pau Monné" Cc: Stefano Stabellini Cc: Volodymyr Babchuk Cc: Wei Liu -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 13:42:29 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 13:42:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xD3-0008PK-Sh; Tue, 04 Aug 2020 13:42:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xD3-0008MP-2J for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 13:42:29 +0000 X-Inumbo-ID: 0bfa964c-5a51-4f97-a22f-1aa24d18082b Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0bfa964c-5a51-4f97-a22f-1aa24d18082b; Tue, 04 Aug 2020 13:42:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GNYwqPcBwnk0vcKVQIQgGJidOYMSGwZ6dlJjnlwKlHg=; b=WIk9AlvMkwRZEeLweZZubkx39X Z+/W4kJLtbkoD3LTXSVVd1MSJqnfhYz6pN+CpG4XtLBymtV7CEjzl1cHypw5RjK6M1uq6tSitsBFH nbKakrEZNkcNlYGoK7llKKmFmA/nDNOoEq6BMk5y0CcWPd9b+Xp0acqw7h4NByiy7kaM=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xCt-000845-2k; Tue, 04 Aug 2020 13:42:19 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2xCs-0003ag-Ra; Tue, 04 Aug 2020 13:42:19 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v4 04/14] x86/iommu: convert AMD IOMMU code to use new page table allocator Date: Tue, 4 Aug 2020 14:41:59 +0100 Message-Id: <20200804134209.8717-5-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200804134209.8717-1-paul@xen.org> References: <20200804134209.8717-1-paul@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Paul Durrant , Jan Beulich Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant This patch converts the AMD IOMMU code to use the new page table allocator function. This allows all the free-ing code to be removed (since it is now handled by the general x86 code) which reduces TLB and cache thrashing as well as shortening the code. Signed-off-by: Paul Durrant Reviewed-by: Jan Beulich --- Cc: Andrew Cooper v2: - New in v2 (split from "add common page-table allocator") --- xen/drivers/passthrough/amd/iommu.h | 18 +---- xen/drivers/passthrough/amd/iommu_map.c | 10 +-- xen/drivers/passthrough/amd/pci_amd_iommu.c | 75 +++------------------ 3 files changed, 16 insertions(+), 87 deletions(-) diff --git a/xen/drivers/passthrough/amd/iommu.h b/xen/drivers/passthrough/amd/iommu.h index 3489c2a015..e2d174f3b4 100644 --- a/xen/drivers/passthrough/amd/iommu.h +++ b/xen/drivers/passthrough/amd/iommu.h @@ -226,7 +226,7 @@ int __must_check amd_iommu_map_page(struct domain *d, dfn_t dfn, unsigned int *flush_flags); int __must_check amd_iommu_unmap_page(struct domain *d, dfn_t dfn, unsigned int *flush_flags); -int __must_check amd_iommu_alloc_root(struct domain_iommu *hd); +int __must_check amd_iommu_alloc_root(struct domain *d); int amd_iommu_reserve_domain_unity_map(struct domain *domain, paddr_t phys_addr, unsigned long size, int iw, int ir); @@ -356,22 +356,6 @@ static inline int amd_iommu_get_paging_mode(unsigned long max_frames) return level; } -static inline struct page_info *alloc_amd_iommu_pgtable(void) -{ - struct page_info *pg = alloc_domheap_page(NULL, 0); - - if ( pg ) - clear_domain_page(page_to_mfn(pg)); - - return pg; -} - -static inline void free_amd_iommu_pgtable(struct page_info *pg) -{ - if ( pg ) - free_domheap_page(pg); -} - static inline void *__alloc_amd_iommu_tables(unsigned int order) { return alloc_xenheap_pages(order, 0); diff --git a/xen/drivers/passthrough/amd/iommu_map.c b/xen/drivers/passthrough/amd/iommu_map.c index 47b4472e8a..54b991294a 100644 --- a/xen/drivers/passthrough/amd/iommu_map.c +++ b/xen/drivers/passthrough/amd/iommu_map.c @@ -217,7 +217,7 @@ static int iommu_pde_from_dfn(struct domain *d, unsigned long dfn, mfn = next_table_mfn; /* allocate lower level page table */ - table = alloc_amd_iommu_pgtable(); + table = iommu_alloc_pgtable(d); if ( table == NULL ) { AMD_IOMMU_DEBUG("Cannot allocate I/O page table\n"); @@ -248,7 +248,7 @@ static int iommu_pde_from_dfn(struct domain *d, unsigned long dfn, if ( next_table_mfn == 0 ) { - table = alloc_amd_iommu_pgtable(); + table = iommu_alloc_pgtable(d); if ( table == NULL ) { AMD_IOMMU_DEBUG("Cannot allocate I/O page table\n"); @@ -286,7 +286,7 @@ int amd_iommu_map_page(struct domain *d, dfn_t dfn, mfn_t mfn, spin_lock(&hd->arch.mapping_lock); - rc = amd_iommu_alloc_root(hd); + rc = amd_iommu_alloc_root(d); if ( rc ) { spin_unlock(&hd->arch.mapping_lock); @@ -458,7 +458,7 @@ int __init amd_iommu_quarantine_init(struct domain *d) spin_lock(&hd->arch.mapping_lock); - hd->arch.amd.root_table = alloc_amd_iommu_pgtable(); + hd->arch.amd.root_table = iommu_alloc_pgtable(d); if ( !hd->arch.amd.root_table ) goto out; @@ -473,7 +473,7 @@ int __init amd_iommu_quarantine_init(struct domain *d) * page table pages, and the resulting allocations are always * zeroed. */ - pg = alloc_amd_iommu_pgtable(); + pg = iommu_alloc_pgtable(d); if ( !pg ) break; diff --git a/xen/drivers/passthrough/amd/pci_amd_iommu.c b/xen/drivers/passthrough/amd/pci_amd_iommu.c index 09a05f9d75..3390c22cf3 100644 --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c @@ -205,11 +205,13 @@ static int iov_enable_xt(void) return 0; } -int amd_iommu_alloc_root(struct domain_iommu *hd) +int amd_iommu_alloc_root(struct domain *d) { + struct domain_iommu *hd = dom_iommu(d); + if ( unlikely(!hd->arch.amd.root_table) ) { - hd->arch.amd.root_table = alloc_amd_iommu_pgtable(); + hd->arch.amd.root_table = iommu_alloc_pgtable(d); if ( !hd->arch.amd.root_table ) return -ENOMEM; } @@ -217,12 +219,13 @@ int amd_iommu_alloc_root(struct domain_iommu *hd) return 0; } -static int __must_check allocate_domain_resources(struct domain_iommu *hd) +static int __must_check allocate_domain_resources(struct domain *d) { + struct domain_iommu *hd = dom_iommu(d); int rc; spin_lock(&hd->arch.mapping_lock); - rc = amd_iommu_alloc_root(hd); + rc = amd_iommu_alloc_root(d); spin_unlock(&hd->arch.mapping_lock); return rc; @@ -254,7 +257,7 @@ static void __hwdom_init amd_iommu_hwdom_init(struct domain *d) { const struct amd_iommu *iommu; - if ( allocate_domain_resources(dom_iommu(d)) ) + if ( allocate_domain_resources(d) ) BUG(); for_each_amd_iommu ( iommu ) @@ -323,7 +326,6 @@ static int reassign_device(struct domain *source, struct domain *target, { struct amd_iommu *iommu; int bdf, rc; - struct domain_iommu *t = dom_iommu(target); bdf = PCI_BDF2(pdev->bus, pdev->devfn); iommu = find_iommu_for_device(pdev->seg, bdf); @@ -344,7 +346,7 @@ static int reassign_device(struct domain *source, struct domain *target, pdev->domain = target; } - rc = allocate_domain_resources(t); + rc = allocate_domain_resources(target); if ( rc ) return rc; @@ -376,65 +378,9 @@ static int amd_iommu_assign_device(struct domain *d, u8 devfn, return reassign_device(pdev->domain, d, devfn, pdev); } -static void deallocate_next_page_table(struct page_info *pg, int level) -{ - PFN_ORDER(pg) = level; - spin_lock(&iommu_pt_cleanup_lock); - page_list_add_tail(pg, &iommu_pt_cleanup_list); - spin_unlock(&iommu_pt_cleanup_lock); -} - -static void deallocate_page_table(struct page_info *pg) -{ - struct amd_iommu_pte *table_vaddr; - unsigned int index, level = PFN_ORDER(pg); - - PFN_ORDER(pg) = 0; - - if ( level <= 1 ) - { - free_amd_iommu_pgtable(pg); - return; - } - - table_vaddr = __map_domain_page(pg); - - for ( index = 0; index < PTE_PER_TABLE_SIZE; index++ ) - { - struct amd_iommu_pte *pde = &table_vaddr[index]; - - if ( pde->mfn && pde->next_level && pde->pr ) - { - /* We do not support skip levels yet */ - ASSERT(pde->next_level == level - 1); - deallocate_next_page_table(mfn_to_page(_mfn(pde->mfn)), - pde->next_level); - } - } - - unmap_domain_page(table_vaddr); - free_amd_iommu_pgtable(pg); -} - -static void deallocate_iommu_page_tables(struct domain *d) -{ - struct domain_iommu *hd = dom_iommu(d); - - spin_lock(&hd->arch.mapping_lock); - if ( hd->arch.amd.root_table ) - { - deallocate_next_page_table(hd->arch.amd.root_table, - hd->arch.amd.paging_mode); - hd->arch.amd.root_table = NULL; - } - spin_unlock(&hd->arch.mapping_lock); -} - - static void amd_iommu_domain_destroy(struct domain *d) { - deallocate_iommu_page_tables(d); - amd_iommu_flush_all_pages(d); + dom_iommu(d)->arch.amd.root_table = NULL; } static int amd_iommu_add_device(u8 devfn, struct pci_dev *pdev) @@ -620,7 +566,6 @@ static const struct iommu_ops __initconstrel _iommu_ops = { .unmap_page = amd_iommu_unmap_page, .iotlb_flush = amd_iommu_flush_iotlb_pages, .iotlb_flush_all = amd_iommu_flush_iotlb_all, - .free_page_table = deallocate_page_table, .reassign_device = reassign_device, .get_device_group_id = amd_iommu_group_id, .enable_x2apic = iov_enable_xt, -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 13:42:31 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 13:42:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xD5-0008Q8-75; Tue, 04 Aug 2020 13:42:31 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xD3-0008MU-Kw for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 13:42:29 +0000 X-Inumbo-ID: 775e4e37-dd3e-4ab4-9697-3224ee56f866 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 775e4e37-dd3e-4ab4-9697-3224ee56f866; Tue, 04 Aug 2020 13:42:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gzK78nwZrm48tXtDUaXfQ78CtVcV80kTQQlmCFDMgJg=; b=Yabth19qTBUW6SLEgR2yYlJdyK f2CnG0UnIYOnOSUi4dr5FVDwlyfVVz61CdSo6ETz5VTUfHJkiFFD6E2UAR0Ec2+J/DqjeXzlUjpTa EebuDEGomCuFA5Z6W7PQFgCbF2EXJGR7mvcW3B6EUZltFH8ni2cXOuExbzNuoJ1cH82Q=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xCs-00083z-5w; Tue, 04 Aug 2020 13:42:18 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2xCr-0003ag-Uj; Tue, 04 Aug 2020 13:42:18 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v4 03/14] x86/iommu: convert VT-d code to use new page table allocator Date: Tue, 4 Aug 2020 14:41:58 +0100 Message-Id: <20200804134209.8717-4-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200804134209.8717-1-paul@xen.org> References: <20200804134209.8717-1-paul@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Paul Durrant , Kevin Tian , Jan Beulich Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant This patch converts the VT-d code to use the new IOMMU page table allocator function. This allows all the free-ing code to be removed (since it is now handled by the general x86 code) which reduces TLB and cache thrashing as well as shortening the code. The scope of the mapping_lock in intel_iommu_quarantine_init() has also been increased slightly; it should have always covered accesses to 'arch.vtd.pgd_maddr'. NOTE: The common IOMMU needs a slight modification to avoid scheduling the cleanup tasklet if the free_page_table() method is not present (since the tasklet will unconditionally call it). Signed-off-by: Paul Durrant Reviewed-by: Jan Beulich --- Cc: Kevin Tian v2: - New in v2 (split from "add common page-table allocator") --- xen/drivers/passthrough/iommu.c | 6 +- xen/drivers/passthrough/vtd/iommu.c | 101 ++++++++++------------------ 2 files changed, 39 insertions(+), 68 deletions(-) diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c index 1d644844ab..2b1db8022c 100644 --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -225,8 +225,10 @@ static void iommu_teardown(struct domain *d) { struct domain_iommu *hd = dom_iommu(d); - hd->platform_ops->teardown(d); - tasklet_schedule(&iommu_pt_cleanup_tasklet); + iommu_vcall(hd->platform_ops, teardown, d); + + if ( hd->platform_ops->free_page_table ) + tasklet_schedule(&iommu_pt_cleanup_tasklet); } void iommu_domain_destroy(struct domain *d) diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c index 94e0455a4d..607e8b5e65 100644 --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -265,10 +265,15 @@ static u64 addr_to_dma_page_maddr(struct domain *domain, u64 addr, int alloc) addr &= (((u64)1) << addr_width) - 1; ASSERT(spin_is_locked(&hd->arch.mapping_lock)); - if ( !hd->arch.vtd.pgd_maddr && - (!alloc || - ((hd->arch.vtd.pgd_maddr = alloc_pgtable_maddr(1, hd->node)) == 0)) ) - goto out; + if ( !hd->arch.vtd.pgd_maddr ) + { + struct page_info *pg; + + if ( !alloc || !(pg = iommu_alloc_pgtable(domain)) ) + goto out; + + hd->arch.vtd.pgd_maddr = page_to_maddr(pg); + } parent = (struct dma_pte *)map_vtd_domain_page(hd->arch.vtd.pgd_maddr); while ( level > 1 ) @@ -279,13 +284,16 @@ static u64 addr_to_dma_page_maddr(struct domain *domain, u64 addr, int alloc) pte_maddr = dma_pte_addr(*pte); if ( !pte_maddr ) { + struct page_info *pg; + if ( !alloc ) break; - pte_maddr = alloc_pgtable_maddr(1, hd->node); - if ( !pte_maddr ) + pg = iommu_alloc_pgtable(domain); + if ( !pg ) break; + pte_maddr = page_to_maddr(pg); dma_set_pte_addr(*pte, pte_maddr); /* @@ -675,45 +683,6 @@ static void dma_pte_clear_one(struct domain *domain, uint64_t addr, unmap_vtd_domain_page(page); } -static void iommu_free_pagetable(u64 pt_maddr, int level) -{ - struct page_info *pg = maddr_to_page(pt_maddr); - - if ( pt_maddr == 0 ) - return; - - PFN_ORDER(pg) = level; - spin_lock(&iommu_pt_cleanup_lock); - page_list_add_tail(pg, &iommu_pt_cleanup_list); - spin_unlock(&iommu_pt_cleanup_lock); -} - -static void iommu_free_page_table(struct page_info *pg) -{ - unsigned int i, next_level = PFN_ORDER(pg) - 1; - u64 pt_maddr = page_to_maddr(pg); - struct dma_pte *pt_vaddr, *pte; - - PFN_ORDER(pg) = 0; - pt_vaddr = (struct dma_pte *)map_vtd_domain_page(pt_maddr); - - for ( i = 0; i < PTE_NUM; i++ ) - { - pte = &pt_vaddr[i]; - if ( !dma_pte_present(*pte) ) - continue; - - if ( next_level >= 1 ) - iommu_free_pagetable(dma_pte_addr(*pte), next_level); - - dma_clear_pte(*pte); - iommu_sync_cache(pte, sizeof(struct dma_pte)); - } - - unmap_vtd_domain_page(pt_vaddr); - free_pgtable_maddr(pt_maddr); -} - static int iommu_set_root_entry(struct vtd_iommu *iommu) { u32 sts; @@ -1748,16 +1717,7 @@ static void iommu_domain_teardown(struct domain *d) xfree(mrmrr); } - ASSERT(is_iommu_enabled(d)); - - if ( iommu_use_hap_pt(d) ) - return; - - spin_lock(&hd->arch.mapping_lock); - iommu_free_pagetable(hd->arch.vtd.pgd_maddr, - agaw_to_level(hd->arch.vtd.agaw)); hd->arch.vtd.pgd_maddr = 0; - spin_unlock(&hd->arch.mapping_lock); } static int __must_check intel_iommu_map_page(struct domain *d, dfn_t dfn, @@ -2669,23 +2629,28 @@ static void vtd_dump_p2m_table(struct domain *d) static int __init intel_iommu_quarantine_init(struct domain *d) { struct domain_iommu *hd = dom_iommu(d); + struct page_info *pg; struct dma_pte *parent; unsigned int agaw = width_to_agaw(DEFAULT_DOMAIN_ADDRESS_WIDTH); unsigned int level = agaw_to_level(agaw); - int rc; + int rc = 0; + + spin_lock(&hd->arch.mapping_lock); if ( hd->arch.vtd.pgd_maddr ) { ASSERT_UNREACHABLE(); - return 0; + goto out; } - spin_lock(&hd->arch.mapping_lock); + pg = iommu_alloc_pgtable(d); - hd->arch.vtd.pgd_maddr = alloc_pgtable_maddr(1, hd->node); - if ( !hd->arch.vtd.pgd_maddr ) + rc = -ENOMEM; + if ( !pg ) goto out; + hd->arch.vtd.pgd_maddr = page_to_maddr(pg); + parent = map_vtd_domain_page(hd->arch.vtd.pgd_maddr); while ( level ) { @@ -2697,10 +2662,12 @@ static int __init intel_iommu_quarantine_init(struct domain *d) * page table pages, and the resulting allocations are always * zeroed. */ - maddr = alloc_pgtable_maddr(1, hd->node); - if ( !maddr ) - break; + pg = iommu_alloc_pgtable(d); + + if ( !pg ) + goto out; + maddr = page_to_maddr(pg); for ( offset = 0; offset < PTE_NUM; offset++ ) { struct dma_pte *pte = &parent[offset]; @@ -2716,13 +2683,16 @@ static int __init intel_iommu_quarantine_init(struct domain *d) } unmap_vtd_domain_page(parent); + rc = 0; + out: spin_unlock(&hd->arch.mapping_lock); - rc = iommu_flush_iotlb_all(d); + if ( !rc ) + rc = iommu_flush_iotlb_all(d); - /* Pages leaked in failure case */ - return level ? -ENOMEM : rc; + /* Pages may be leaked in failure case */ + return rc; } static struct iommu_ops __initdata vtd_ops = { @@ -2737,7 +2707,6 @@ static struct iommu_ops __initdata vtd_ops = { .map_page = intel_iommu_map_page, .unmap_page = intel_iommu_unmap_page, .lookup_page = intel_iommu_lookup_page, - .free_page_table = iommu_free_page_table, .reassign_device = reassign_device_ownership, .get_device_group_id = intel_iommu_group_id, .enable_x2apic = intel_iommu_enable_eim, -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 13:42:35 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 13:42:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xD9-0008SC-GA; Tue, 04 Aug 2020 13:42:35 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xD8-0008MU-L1 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 13:42:34 +0000 X-Inumbo-ID: 678af935-6a4c-4f6c-b259-9e4c468680e6 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 678af935-6a4c-4f6c-b259-9e4c468680e6; Tue, 04 Aug 2020 13:42:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tvDh3hWaZXavS9k/pMM3gTVqpPl5TsT49cdKXt8Ayaw=; b=FUi5xDkywTwxbeu4EQ+TWeByJU DFIE4zRgO0WPsnhHLHpaARytYJ3cFxUOvnL0S8tgK+J/P2yud3kl+9RI22AfY/FowSMHRHj4xAhKj eifOysnDzItFNeHKZjywM6yB0o9M5DNNVLBBUD+z3nZcmEx1/nksqBRuD9Aw3PLQ3IKU=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xCu-00084P-MD; Tue, 04 Aug 2020 13:42:20 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2xCu-0003ag-Ef; Tue, 04 Aug 2020 13:42:20 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v4 06/14] iommu: flush I/O TLB if iommu_map() or iommu_unmap() fail Date: Tue, 4 Aug 2020 14:42:01 +0100 Message-Id: <20200804134209.8717-7-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200804134209.8717-1-paul@xen.org> References: <20200804134209.8717-1-paul@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Paul Durrant , Jan Beulich Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant This patch adds a full I/O TLB flush to the error paths of iommu_map() and iommu_unmap(). Without this change callers need constructs such as: rc = iommu_map/unmap(...) err = iommu_flush(...) if ( !rc ) rc = err; With this change, it can be simplified to: rc = iommu_map/unmap(...) if ( !rc ) rc = iommu_flush(...) because, if the map or unmap fails the flush will be unnecessary. This saves a stack variable and generally makes the call sites tidier. Signed-off-by: Paul Durrant --- Cc: Jan Beulich v2: - New in v2 --- xen/drivers/passthrough/iommu.c | 28 ++++++++++++---------------- 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c index 660dc5deb2..e2c0193a09 100644 --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -274,6 +274,10 @@ int iommu_map(struct domain *d, dfn_t dfn, mfn_t mfn, break; } + /* Something went wrong so flush everything and clear flush flags */ + if ( unlikely(rc) && iommu_iotlb_flush_all(d, *flush_flags) ) + flush_flags = 0; + return rc; } @@ -283,14 +287,8 @@ int iommu_legacy_map(struct domain *d, dfn_t dfn, mfn_t mfn, unsigned int flush_flags = 0; int rc = iommu_map(d, dfn, mfn, page_order, flags, &flush_flags); - if ( !this_cpu(iommu_dont_flush_iotlb) ) - { - int err = iommu_iotlb_flush(d, dfn, (1u << page_order), - flush_flags); - - if ( !rc ) - rc = err; - } + if ( !this_cpu(iommu_dont_flush_iotlb) && !rc ) + rc = iommu_iotlb_flush(d, dfn, (1u << page_order), flush_flags); return rc; } @@ -330,6 +328,10 @@ int iommu_unmap(struct domain *d, dfn_t dfn, unsigned int page_order, } } + /* Something went wrong so flush everything and clear flush flags */ + if ( unlikely(rc) && iommu_iotlb_flush_all(d, *flush_flags) ) + flush_flags = 0; + return rc; } @@ -338,14 +340,8 @@ int iommu_legacy_unmap(struct domain *d, dfn_t dfn, unsigned int page_order) unsigned int flush_flags = 0; int rc = iommu_unmap(d, dfn, page_order, &flush_flags); - if ( !this_cpu(iommu_dont_flush_iotlb) ) - { - int err = iommu_iotlb_flush(d, dfn, (1u << page_order), - flush_flags); - - if ( !rc ) - rc = err; - } + if ( !this_cpu(iommu_dont_flush_iotlb) && ! rc ) + rc = iommu_iotlb_flush(d, dfn, (1u << page_order), flush_flags); return rc; } -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 13:42:41 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 13:42:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xDE-0008VP-Vd; Tue, 04 Aug 2020 13:42:40 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xDD-0008MU-LD for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 13:42:39 +0000 X-Inumbo-ID: afc6bc69-b8a6-4d13-9625-62a2febbeedd Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id afc6bc69-b8a6-4d13-9625-62a2febbeedd; Tue, 04 Aug 2020 13:42:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/0O2Z8CAhQQK7TsWFvy4DlpzDrss2wE2CpafAdDCzAw=; b=Yr1ZjU5nKtAJgqbZwjTiZmj7KH jykY8O3WC0WtuIBBzZLKdiLVGuGyRdHpPa2qBaWv83Xg4kDcmtiINn0pKZvhFpG2y7vQkdHrb2zXd nY4T9nFPLLGvvVZ3kgjgniTdGUVcXQnflLs35RDusi23Nqcs1qJrjUcYjefTdJhys2WY=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xCw-00084b-Fp; Tue, 04 Aug 2020 13:42:22 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2xCw-0003ag-7z; Tue, 04 Aug 2020 13:42:22 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v4 07/14] iommu: make map, unmap and flush all take both an order and a count Date: Tue, 4 Aug 2020 14:42:02 +0100 Message-Id: <20200804134209.8717-8-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200804134209.8717-1-paul@xen.org> References: <20200804134209.8717-1-paul@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Tian , Stefano Stabellini , Julien Grall , Jun Nakajima , Wei Liu , Andrew Cooper , Paul Durrant , Ian Jackson , George Dunlap , Jan Beulich , Volodymyr Babchuk , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant At the moment iommu_map() and iommu_unmap() take a page order but not a count, whereas iommu_iotlb_flush() takes a count but not a page order. This patch simply makes them consistent with each other. Signed-off-by: Paul Durrant --- Cc: Jun Nakajima Cc: Kevin Tian Cc: Jan Beulich Cc: Andrew Cooper Cc: George Dunlap Cc: Wei Liu Cc: "Roger Pau Monné" Cc: Ian Jackson Cc: Julien Grall Cc: Stefano Stabellini Cc: Volodymyr Babchuk v2: - New in v2 --- xen/arch/arm/p2m.c | 2 +- xen/arch/x86/mm/p2m-ept.c | 2 +- xen/common/memory.c | 4 +-- xen/drivers/passthrough/amd/iommu.h | 2 +- xen/drivers/passthrough/amd/iommu_map.c | 4 +-- xen/drivers/passthrough/arm/ipmmu-vmsa.c | 2 +- xen/drivers/passthrough/arm/smmu.c | 2 +- xen/drivers/passthrough/iommu.c | 31 ++++++++++++------------ xen/drivers/passthrough/vtd/iommu.c | 4 +-- xen/drivers/passthrough/x86/iommu.c | 2 +- xen/include/xen/iommu.h | 9 ++++--- 11 files changed, 33 insertions(+), 31 deletions(-) diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index ce59f2b503..71f4a78425 100644 --- a/xen/arch/arm/p2m.c +++ b/xen/arch/arm/p2m.c @@ -1061,7 +1061,7 @@ static int __p2m_set_entry(struct p2m_domain *p2m, flush_flags |= IOMMU_FLUSHF_added; rc = iommu_iotlb_flush(p2m->domain, _dfn(gfn_x(sgfn)), - 1UL << page_order, flush_flags); + page_order, 1, flush_flags); } else rc = 0; diff --git a/xen/arch/x86/mm/p2m-ept.c b/xen/arch/x86/mm/p2m-ept.c index b8154a7ecc..b2ac912cde 100644 --- a/xen/arch/x86/mm/p2m-ept.c +++ b/xen/arch/x86/mm/p2m-ept.c @@ -843,7 +843,7 @@ out: need_modify_vtd_table ) { if ( iommu_use_hap_pt(d) ) - rc = iommu_iotlb_flush(d, _dfn(gfn), (1u << order), + rc = iommu_iotlb_flush(d, _dfn(gfn), (1u << order), 1, (iommu_flags ? IOMMU_FLUSHF_added : 0) | (vtd_pte_present ? IOMMU_FLUSHF_modified : 0)); diff --git a/xen/common/memory.c b/xen/common/memory.c index 714077c1e5..8de334ff10 100644 --- a/xen/common/memory.c +++ b/xen/common/memory.c @@ -851,12 +851,12 @@ int xenmem_add_to_physmap(struct domain *d, struct xen_add_to_physmap *xatp, this_cpu(iommu_dont_flush_iotlb) = 0; - ret = iommu_iotlb_flush(d, _dfn(xatp->idx - done), done, + ret = iommu_iotlb_flush(d, _dfn(xatp->idx - done), 0, done, IOMMU_FLUSHF_added | IOMMU_FLUSHF_modified); if ( unlikely(ret) && rc >= 0 ) rc = ret; - ret = iommu_iotlb_flush(d, _dfn(xatp->gpfn - done), done, + ret = iommu_iotlb_flush(d, _dfn(xatp->gpfn - done), 0, done, IOMMU_FLUSHF_added | IOMMU_FLUSHF_modified); if ( unlikely(ret) && rc >= 0 ) rc = ret; diff --git a/xen/drivers/passthrough/amd/iommu.h b/xen/drivers/passthrough/amd/iommu.h index e2d174f3b4..f1f0415469 100644 --- a/xen/drivers/passthrough/amd/iommu.h +++ b/xen/drivers/passthrough/amd/iommu.h @@ -231,7 +231,7 @@ int amd_iommu_reserve_domain_unity_map(struct domain *domain, paddr_t phys_addr, unsigned long size, int iw, int ir); int __must_check amd_iommu_flush_iotlb_pages(struct domain *d, dfn_t dfn, - unsigned int page_count, + unsigned long page_count, unsigned int flush_flags); int __must_check amd_iommu_flush_iotlb_all(struct domain *d); diff --git a/xen/drivers/passthrough/amd/iommu_map.c b/xen/drivers/passthrough/amd/iommu_map.c index 54b991294a..0cb948d114 100644 --- a/xen/drivers/passthrough/amd/iommu_map.c +++ b/xen/drivers/passthrough/amd/iommu_map.c @@ -351,7 +351,7 @@ int amd_iommu_unmap_page(struct domain *d, dfn_t dfn, return 0; } -static unsigned long flush_count(unsigned long dfn, unsigned int page_count, +static unsigned long flush_count(unsigned long dfn, unsigned long page_count, unsigned int order) { unsigned long start = dfn >> order; @@ -362,7 +362,7 @@ static unsigned long flush_count(unsigned long dfn, unsigned int page_count, } int amd_iommu_flush_iotlb_pages(struct domain *d, dfn_t dfn, - unsigned int page_count, + unsigned long page_count, unsigned int flush_flags) { unsigned long dfn_l = dfn_x(dfn); diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c b/xen/drivers/passthrough/arm/ipmmu-vmsa.c index b2a65dfaaf..346165c3fa 100644 --- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c +++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c @@ -945,7 +945,7 @@ static int __must_check ipmmu_iotlb_flush_all(struct domain *d) } static int __must_check ipmmu_iotlb_flush(struct domain *d, dfn_t dfn, - unsigned int page_count, + unsigned long page_count, unsigned int flush_flags) { ASSERT(flush_flags); diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c index 94662a8501..06f9bda47d 100644 --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -2534,7 +2534,7 @@ static int __must_check arm_smmu_iotlb_flush_all(struct domain *d) } static int __must_check arm_smmu_iotlb_flush(struct domain *d, dfn_t dfn, - unsigned int page_count, + unsigned long page_count, unsigned int flush_flags) { ASSERT(flush_flags); diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c index e2c0193a09..568a4a5661 100644 --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -235,8 +235,8 @@ void iommu_domain_destroy(struct domain *d) } int iommu_map(struct domain *d, dfn_t dfn, mfn_t mfn, - unsigned int page_order, unsigned int flags, - unsigned int *flush_flags) + unsigned int page_order, unsigned int page_count, + unsigned int flags, unsigned int *flush_flags) { const struct domain_iommu *hd = dom_iommu(d); unsigned long i; @@ -248,7 +248,7 @@ int iommu_map(struct domain *d, dfn_t dfn, mfn_t mfn, ASSERT(IS_ALIGNED(dfn_x(dfn), (1ul << page_order))); ASSERT(IS_ALIGNED(mfn_x(mfn), (1ul << page_order))); - for ( i = 0; i < (1ul << page_order); i++ ) + for ( i = 0; i < ((unsigned long)page_count << page_order); i++ ) { rc = iommu_call(hd->platform_ops, map_page, d, dfn_add(dfn, i), mfn_add(mfn, i), flags, flush_flags); @@ -285,16 +285,16 @@ int iommu_legacy_map(struct domain *d, dfn_t dfn, mfn_t mfn, unsigned int page_order, unsigned int flags) { unsigned int flush_flags = 0; - int rc = iommu_map(d, dfn, mfn, page_order, flags, &flush_flags); + int rc = iommu_map(d, dfn, mfn, page_order, 1, flags, &flush_flags); if ( !this_cpu(iommu_dont_flush_iotlb) && !rc ) - rc = iommu_iotlb_flush(d, dfn, (1u << page_order), flush_flags); + rc = iommu_iotlb_flush(d, dfn, (1u << page_order), 1, flush_flags); return rc; } int iommu_unmap(struct domain *d, dfn_t dfn, unsigned int page_order, - unsigned int *flush_flags) + unsigned int page_count, unsigned int *flush_flags) { const struct domain_iommu *hd = dom_iommu(d); unsigned long i; @@ -305,7 +305,7 @@ int iommu_unmap(struct domain *d, dfn_t dfn, unsigned int page_order, ASSERT(IS_ALIGNED(dfn_x(dfn), (1ul << page_order))); - for ( i = 0; i < (1ul << page_order); i++ ) + for ( i = 0; i < ((unsigned long)page_count << page_order); i++ ) { int err = iommu_call(hd->platform_ops, unmap_page, d, dfn_add(dfn, i), flush_flags); @@ -338,10 +338,10 @@ int iommu_unmap(struct domain *d, dfn_t dfn, unsigned int page_order, int iommu_legacy_unmap(struct domain *d, dfn_t dfn, unsigned int page_order) { unsigned int flush_flags = 0; - int rc = iommu_unmap(d, dfn, page_order, &flush_flags); + int rc = iommu_unmap(d, dfn, page_order, 1, &flush_flags); if ( !this_cpu(iommu_dont_flush_iotlb) && ! rc ) - rc = iommu_iotlb_flush(d, dfn, (1u << page_order), flush_flags); + rc = iommu_iotlb_flush(d, dfn, (1u << page_order), 1, flush_flags); return rc; } @@ -357,8 +357,8 @@ int iommu_lookup_page(struct domain *d, dfn_t dfn, mfn_t *mfn, return iommu_call(hd->platform_ops, lookup_page, d, dfn, mfn, flags); } -int iommu_iotlb_flush(struct domain *d, dfn_t dfn, unsigned int page_count, - unsigned int flush_flags) +int iommu_iotlb_flush(struct domain *d, dfn_t dfn, unsigned int page_order, + unsigned int page_count, unsigned int flush_flags) { const struct domain_iommu *hd = dom_iommu(d); int rc; @@ -370,14 +370,15 @@ int iommu_iotlb_flush(struct domain *d, dfn_t dfn, unsigned int page_count, if ( dfn_eq(dfn, INVALID_DFN) ) return -EINVAL; - rc = iommu_call(hd->platform_ops, iotlb_flush, d, dfn, page_count, - flush_flags); + rc = iommu_call(hd->platform_ops, iotlb_flush, d, dfn, + (unsigned long)page_count << page_order, flush_flags); if ( unlikely(rc) ) { if ( !d->is_shutting_down && printk_ratelimit() ) printk(XENLOG_ERR - "d%d: IOMMU IOTLB flush failed: %d, dfn %"PRI_dfn", page count %u flags %x\n", - d->domain_id, rc, dfn_x(dfn), page_count, flush_flags); + "d%d: IOMMU IOTLB flush failed: %d, dfn %"PRI_dfn", page order %u, page count %u flags %x\n", + d->domain_id, rc, dfn_x(dfn), page_order, page_count, + flush_flags); if ( !is_hardware_domain(d) ) domain_crash(d); diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c index 607e8b5e65..68cf0e535a 100644 --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -584,7 +584,7 @@ static int __must_check iommu_flush_all(void) static int __must_check iommu_flush_iotlb(struct domain *d, dfn_t dfn, bool_t dma_old_pte_present, - unsigned int page_count) + unsigned long page_count) { struct domain_iommu *hd = dom_iommu(d); struct acpi_drhd_unit *drhd; @@ -632,7 +632,7 @@ static int __must_check iommu_flush_iotlb(struct domain *d, dfn_t dfn, static int __must_check iommu_flush_iotlb_pages(struct domain *d, dfn_t dfn, - unsigned int page_count, + unsigned long page_count, unsigned int flush_flags) { ASSERT(page_count && !dfn_eq(dfn, INVALID_DFN)); diff --git a/xen/drivers/passthrough/x86/iommu.c b/xen/drivers/passthrough/x86/iommu.c index aea07e47c4..dba6c9d642 100644 --- a/xen/drivers/passthrough/x86/iommu.c +++ b/xen/drivers/passthrough/x86/iommu.c @@ -244,7 +244,7 @@ void __hwdom_init arch_iommu_hwdom_init(struct domain *d) else if ( paging_mode_translate(d) ) rc = set_identity_p2m_entry(d, pfn, p2m_access_rw, 0); else - rc = iommu_map(d, _dfn(pfn), _mfn(pfn), PAGE_ORDER_4K, + rc = iommu_map(d, _dfn(pfn), _mfn(pfn), PAGE_ORDER_4K, 1, IOMMUF_readable | IOMMUF_writable, &flush_flags); if ( rc ) diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h index 1831dc66b0..d9c2e764aa 100644 --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -146,10 +146,10 @@ enum #define IOMMU_FLUSHF_modified (1u << _IOMMU_FLUSHF_modified) int __must_check iommu_map(struct domain *d, dfn_t dfn, mfn_t mfn, - unsigned int page_order, unsigned int flags, - unsigned int *flush_flags); + unsigned int page_order, unsigned int page_count, + unsigned int flags, unsigned int *flush_flags); int __must_check iommu_unmap(struct domain *d, dfn_t dfn, - unsigned int page_order, + unsigned int page_order, unsigned int page_count, unsigned int *flush_flags); int __must_check iommu_legacy_map(struct domain *d, dfn_t dfn, mfn_t mfn, @@ -162,6 +162,7 @@ int __must_check iommu_lookup_page(struct domain *d, dfn_t dfn, mfn_t *mfn, unsigned int *flags); int __must_check iommu_iotlb_flush(struct domain *d, dfn_t dfn, + unsigned int page_order, unsigned int page_count, unsigned int flush_flags); int __must_check iommu_iotlb_flush_all(struct domain *d, @@ -281,7 +282,7 @@ struct iommu_ops { void (*share_p2m)(struct domain *d); void (*crash_shutdown)(void); int __must_check (*iotlb_flush)(struct domain *d, dfn_t dfn, - unsigned int page_count, + unsigned long page_count, unsigned int flush_flags); int __must_check (*iotlb_flush_all)(struct domain *d); int (*get_reserved_device_memory)(iommu_grdm_t *, void *); -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 13:42:46 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 13:42:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xDK-00006n-9N; Tue, 04 Aug 2020 13:42:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xDI-0008MU-LS for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 13:42:44 +0000 X-Inumbo-ID: dd2b61c9-c9aa-45f3-a847-55ab54762e8a Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id dd2b61c9-c9aa-45f3-a847-55ab54762e8a; Tue, 04 Aug 2020 13:42:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9CNNemKJGP8SuVWzacpv68au3entEv5YFODLnV2d/u0=; b=iDhyTJA/uNWGx5JFxnska5MNUC wSfNwoBFoJpDUF3/J1X57vZHXyNMK1oWYgj+mnwk1RyGUIvy4E+BXAzq7FYamWzX8lC4+pI9IRhZK F1Tw9rfi/jJBN9Mgzs5SW75HzMxSCHJtr2+lRxoYiyTp9pFT7wCZRW5SndKX4WWUt7Qg=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xCz-00084p-Ij; Tue, 04 Aug 2020 13:42:25 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2xCz-0003ag-BH; Tue, 04 Aug 2020 13:42:25 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v4 09/14] common/grant_table: batch flush I/O TLB Date: Tue, 4 Aug 2020 14:42:04 +0100 Message-Id: <20200804134209.8717-10-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200804134209.8717-1-paul@xen.org> References: <20200804134209.8717-1-paul@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Paul Durrant , Ian Jackson , George Dunlap , Jan Beulich Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant This patch avoids calling iommu_iotlb_flush() for each individual GNTTABOP and insteads calls iommu_iotlb_flush_all() at the end of the hypercall. This should mean batched map/unmap operations perform better but may be slightly detrimental to singleton performance. Suggested-by: Jan Beulich Signed-off-by: Paul Durrant --- Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich Cc: Julien Grall Cc: Stefano Stabellini Cc: Wei Liu v3: - New in v3 --- xen/common/grant_table.c | 132 ++++++++++++++++++++++++--------------- 1 file changed, 80 insertions(+), 52 deletions(-) diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c index d6526bca12..f382e0be52 100644 --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -979,7 +979,7 @@ static unsigned int mapkind( static void map_grant_ref( - struct gnttab_map_grant_ref *op) + struct gnttab_map_grant_ref *op, unsigned int *flush_flags) { struct domain *ld, *rd, *owner = NULL; struct grant_table *lgt, *rgt; @@ -1228,17 +1228,12 @@ map_grant_ref( if ( kind ) { dfn_t dfn = _dfn(mfn_x(mfn)); - unsigned int flush_flags = 0; int err; - err = iommu_map(ld, dfn, mfn, 0, 1, kind, &flush_flags); - if ( !err ) - err = iommu_iotlb_flush(ld, dfn, 0, 1, flush_flags); + err = iommu_map(ld, dfn, mfn, 0, 1, kind, flush_flags); if ( err ) - rc = GNTST_general_error; - - if ( rc != GNTST_okay ) { + rc = GNTST_general_error; double_gt_unlock(lgt, rgt); goto undo_out; } @@ -1322,6 +1317,8 @@ gnttab_map_grant_ref( { int i; struct gnttab_map_grant_ref op; + unsigned int flush_flags = 0; + int err, rc = 0; for ( i = 0; i < count; i++ ) { @@ -1329,20 +1326,30 @@ gnttab_map_grant_ref( return i; if ( unlikely(__copy_from_guest_offset(&op, uop, i, 1)) ) - return -EFAULT; + { + rc = -EFAULT; + break; + } - map_grant_ref(&op); + map_grant_ref(&op, &flush_flags); if ( unlikely(__copy_to_guest_offset(uop, i, &op, 1)) ) - return -EFAULT; + { + rc = -EFAULT; + break; + } } - return 0; + err = iommu_iotlb_flush_all(current->domain, flush_flags); + if ( !rc ) + rc = err; + + return rc; } static void unmap_common( - struct gnttab_unmap_common *op) + struct gnttab_unmap_common *op, unsigned int *flush_flags) { domid_t dom; struct domain *ld, *rd; @@ -1486,20 +1493,16 @@ unmap_common( { unsigned int kind; dfn_t dfn = _dfn(mfn_x(op->mfn)); - unsigned int flush_flags = 0; int err = 0; double_gt_lock(lgt, rgt); kind = mapkind(lgt, rd, op->mfn); if ( !kind ) - err = iommu_unmap(ld, dfn, 0, 1, &flush_flags); + err = iommu_unmap(ld, dfn, 0, 1, flush_flags); else if ( !(kind & MAPKIND_WRITE) ) err = iommu_map(ld, dfn, op->mfn, 0, 1, IOMMUF_readable, - &flush_flags); - - if ( !err ) - err = iommu_iotlb_flush(ld, dfn, 0, 1, flush_flags); + flush_flags); if ( err ) rc = GNTST_general_error; @@ -1600,8 +1603,8 @@ unmap_common_complete(struct gnttab_unmap_common *op) static void unmap_grant_ref( - struct gnttab_unmap_grant_ref *op, - struct gnttab_unmap_common *common) + struct gnttab_unmap_grant_ref *op, struct gnttab_unmap_common *common, + unsigned int *flush_flags) { common->host_addr = op->host_addr; common->dev_bus_addr = op->dev_bus_addr; @@ -1613,7 +1616,7 @@ unmap_grant_ref( common->rd = NULL; common->mfn = INVALID_MFN; - unmap_common(common); + unmap_common(common, flush_flags); op->status = common->status; } @@ -1622,31 +1625,50 @@ static long gnttab_unmap_grant_ref( XEN_GUEST_HANDLE_PARAM(gnttab_unmap_grant_ref_t) uop, unsigned int count) { - int i, c, partial_done, done = 0; + struct domain *currd = current->domain; struct gnttab_unmap_grant_ref op; struct gnttab_unmap_common common[GNTTAB_UNMAP_BATCH_SIZE]; + int rc = 0; while ( count != 0 ) { + unsigned int i, c, partial_done = 0, done = 0; + unsigned int flush_flags = 0; + int err; + c = min(count, (unsigned int)GNTTAB_UNMAP_BATCH_SIZE); - partial_done = 0; for ( i = 0; i < c; i++ ) { if ( unlikely(__copy_from_guest(&op, uop, 1)) ) - goto fault; - unmap_grant_ref(&op, &common[i]); + { + rc = -EFAULT; + break; + } + + unmap_grant_ref(&op, &common[i], &flush_flags); ++partial_done; + if ( unlikely(__copy_field_to_guest(uop, &op, status)) ) - goto fault; + { + rc = -EFAULT; + break; + } + guest_handle_add_offset(uop, 1); } - gnttab_flush_tlb(current->domain); + gnttab_flush_tlb(currd); + err = iommu_iotlb_flush_all(currd, flush_flags); + if ( !rc ) + rc = err; for ( i = 0; i < partial_done; i++ ) unmap_common_complete(&common[i]); + if ( rc ) + break; + count -= c; done += c; @@ -1654,20 +1676,14 @@ gnttab_unmap_grant_ref( return done; } - return 0; - -fault: - gnttab_flush_tlb(current->domain); - - for ( i = 0; i < partial_done; i++ ) - unmap_common_complete(&common[i]); - return -EFAULT; + return rc; } static void unmap_and_replace( struct gnttab_unmap_and_replace *op, - struct gnttab_unmap_common *common) + struct gnttab_unmap_common *common, + unsigned int *flush_flags) { common->host_addr = op->host_addr; common->new_addr = op->new_addr; @@ -1679,7 +1695,7 @@ unmap_and_replace( common->rd = NULL; common->mfn = INVALID_MFN; - unmap_common(common); + unmap_common(common, flush_flags); op->status = common->status; } @@ -1687,31 +1703,50 @@ static long gnttab_unmap_and_replace( XEN_GUEST_HANDLE_PARAM(gnttab_unmap_and_replace_t) uop, unsigned int count) { - int i, c, partial_done, done = 0; + struct domain *currd = current->domain; struct gnttab_unmap_and_replace op; struct gnttab_unmap_common common[GNTTAB_UNMAP_BATCH_SIZE]; + int rc = 0; while ( count != 0 ) { + unsigned int i, c, partial_done = 0, done = 0; + unsigned int flush_flags = 0; + int err; + c = min(count, (unsigned int)GNTTAB_UNMAP_BATCH_SIZE); - partial_done = 0; for ( i = 0; i < c; i++ ) { if ( unlikely(__copy_from_guest(&op, uop, 1)) ) - goto fault; - unmap_and_replace(&op, &common[i]); + { + rc = -EFAULT; + break; + } + + unmap_and_replace(&op, &common[i], &flush_flags); ++partial_done; + if ( unlikely(__copy_field_to_guest(uop, &op, status)) ) - goto fault; + { + rc = -EFAULT; + break; + } + guest_handle_add_offset(uop, 1); } - gnttab_flush_tlb(current->domain); + gnttab_flush_tlb(currd); + err = iommu_iotlb_flush_all(currd, flush_flags); + if ( !rc ) + rc = err; for ( i = 0; i < partial_done; i++ ) unmap_common_complete(&common[i]); + if ( rc ) + break; + count -= c; done += c; @@ -1719,14 +1754,7 @@ gnttab_unmap_and_replace( return done; } - return 0; - -fault: - gnttab_flush_tlb(current->domain); - - for ( i = 0; i < partial_done; i++ ) - unmap_common_complete(&common[i]); - return -EFAULT; + return rc; } static int -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 13:42:51 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 13:42:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xDP-0000BS-Jq; Tue, 04 Aug 2020 13:42:51 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xDN-0008MU-LV for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 13:42:49 +0000 X-Inumbo-ID: 09676321-9f90-436f-960f-05a855f8956a Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 09676321-9f90-436f-960f-05a855f8956a; Tue, 04 Aug 2020 13:42:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uX0pTBNJWLcwNpGyIoW6P7DNZjTBgM7ya3gdLDIudsU=; b=1BvJC7ZUSTLTLpGtBNcWTJr/5+ 9bg0ShTmQ46PqBzIdxNVvuy2hGmdQiM1WisnYdn2jT3rDjIUE1/4dAy8snxKZ76rxFO71UNYbgqCh w3o87WCTilGWGbs0yXpsjG4J7b3iux4TH6htP10avDIXEYsJqlocgAg8+YNHqSRoyW4A=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xCy-00084j-5i; Tue, 04 Aug 2020 13:42:24 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2xCx-0003ag-UW; Tue, 04 Aug 2020 13:42:24 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v4 08/14] remove remaining uses of iommu_legacy_map/unmap Date: Tue, 4 Aug 2020 14:42:03 +0100 Message-Id: <20200804134209.8717-9-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200804134209.8717-1-paul@xen.org> References: <20200804134209.8717-1-paul@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Tian , Stefano Stabellini , Julien Grall , Jun Nakajima , Wei Liu , Andrew Cooper , Paul Durrant , Ian Jackson , George Dunlap , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant The 'legacy' functions do implicit flushing so amend the callers to do the appropriate flushing. Unfortunately, because of the structure of the P2M code, we cannot remove the per-CPU 'iommu_dont_flush_iotlb' global and the optimization it facilitates. It is now checked directly iommu_iotlb_flush(). Also, it is now declared as bool (rather than bool_t) and setting/clearing it are no longer pointlessly gated on is_iommu_enabled() returning true. (Arguably it is also pointless to gate the call to iommu_iotlb_flush() on that condition - since it is a no-op in that case - but the if clause allows the scope of a stack variable to be restricted). NOTE: The code in memory_add() now fails if the number of pages passed to a single call overflows an unsigned int. I don't believe this will ever happen in practice. Signed-off-by: Paul Durrant --- Cc: Jan Beulich Cc: Andrew Cooper Cc: Wei Liu Cc: "Roger Pau Monné" Cc: George Dunlap Cc: Ian Jackson Cc: Julien Grall Cc: Stefano Stabellini Cc: Jun Nakajima Cc: Kevin Tian v3: - Same as v2; elected to implement batch flushing in the grant table code as a subsequent patch v2: - Shorten the diff (mainly because of a prior patch introducing automatic flush-on-fail into iommu_map() and iommu_unmap()) --- xen/arch/x86/mm.c | 21 +++++++++++++++----- xen/arch/x86/mm/p2m-ept.c | 20 +++++++++++-------- xen/arch/x86/mm/p2m-pt.c | 15 +++++++++++---- xen/arch/x86/mm/p2m.c | 26 ++++++++++++++++++------- xen/arch/x86/x86_64/mm.c | 27 +++++++++++++------------- xen/common/grant_table.c | 34 ++++++++++++++++++++++++--------- xen/common/memory.c | 5 +++-- xen/drivers/passthrough/iommu.c | 25 +----------------------- xen/include/xen/iommu.h | 21 +++++--------------- 9 files changed, 106 insertions(+), 88 deletions(-) diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 638f6bf580..062af1f684 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -2446,10 +2446,16 @@ static int cleanup_page_mappings(struct page_info *page) if ( d && unlikely(need_iommu_pt_sync(d)) && is_pv_domain(d) ) { - int rc2 = iommu_legacy_unmap(d, _dfn(mfn), PAGE_ORDER_4K); + unsigned int flush_flags = 0; + int err; + err = iommu_unmap(d, _dfn(mfn), PAGE_ORDER_4K, 1, &flush_flags); if ( !rc ) - rc = rc2; + rc = err; + + err = iommu_iotlb_flush(d, _dfn(mfn), PAGE_ORDER_4K, 1, flush_flags); + if ( !rc ) + rc = err; } if ( likely(!is_special_page(page)) ) @@ -2971,12 +2977,17 @@ static int _get_page_type(struct page_info *page, unsigned long type, if ( d && unlikely(need_iommu_pt_sync(d)) && is_pv_domain(d) ) { mfn_t mfn = page_to_mfn(page); + dfn_t dfn = _dfn(mfn_x(mfn)); + unsigned int flush_flags = 0; if ( (x & PGT_type_mask) == PGT_writable_page ) - rc = iommu_legacy_unmap(d, _dfn(mfn_x(mfn)), PAGE_ORDER_4K); + rc = iommu_unmap(d, dfn, PAGE_ORDER_4K, 1, &flush_flags); else - rc = iommu_legacy_map(d, _dfn(mfn_x(mfn)), mfn, PAGE_ORDER_4K, - IOMMUF_readable | IOMMUF_writable); + rc = iommu_map(d, dfn, mfn, PAGE_ORDER_4K, 1, + IOMMUF_readable | IOMMUF_writable, &flush_flags); + + if ( !rc ) + rc = iommu_iotlb_flush(d, dfn, PAGE_ORDER_4K, 1, flush_flags); if ( unlikely(rc) ) { diff --git a/xen/arch/x86/mm/p2m-ept.c b/xen/arch/x86/mm/p2m-ept.c index b2ac912cde..e38b0bf95c 100644 --- a/xen/arch/x86/mm/p2m-ept.c +++ b/xen/arch/x86/mm/p2m-ept.c @@ -842,15 +842,19 @@ out: if ( rc == 0 && p2m_is_hostp2m(p2m) && need_modify_vtd_table ) { - if ( iommu_use_hap_pt(d) ) - rc = iommu_iotlb_flush(d, _dfn(gfn), (1u << order), 1, - (iommu_flags ? IOMMU_FLUSHF_added : 0) | - (vtd_pte_present ? IOMMU_FLUSHF_modified - : 0)); - else if ( need_iommu_pt_sync(d) ) + unsigned int flush_flags = 0; + + if ( need_iommu_pt_sync(d) ) rc = iommu_flags ? - iommu_legacy_map(d, _dfn(gfn), mfn, order, iommu_flags) : - iommu_legacy_unmap(d, _dfn(gfn), order); + iommu_map(d, _dfn(gfn), mfn, order, 1, iommu_flags, &flush_flags) : + iommu_unmap(d, _dfn(gfn), order, 1, &flush_flags); + else if ( iommu_use_hap_pt(d) ) + flush_flags = + (iommu_flags ? IOMMU_FLUSHF_added : 0) | + (vtd_pte_present ? IOMMU_FLUSHF_modified : 0); + + if ( !rc ) + rc = iommu_iotlb_flush(d, _dfn(gfn), order, 1, flush_flags); } unmap_domain_page(table); diff --git a/xen/arch/x86/mm/p2m-pt.c b/xen/arch/x86/mm/p2m-pt.c index badb26bc34..3c0901b56c 100644 --- a/xen/arch/x86/mm/p2m-pt.c +++ b/xen/arch/x86/mm/p2m-pt.c @@ -678,10 +678,17 @@ p2m_pt_set_entry(struct p2m_domain *p2m, gfn_t gfn_, mfn_t mfn, if ( need_iommu_pt_sync(p2m->domain) && (iommu_old_flags != iommu_pte_flags || old_mfn != mfn_x(mfn)) ) - rc = iommu_pte_flags - ? iommu_legacy_map(d, _dfn(gfn), mfn, page_order, - iommu_pte_flags) - : iommu_legacy_unmap(d, _dfn(gfn), page_order); + { + unsigned int flush_flags = 0; + + rc = iommu_pte_flags ? + iommu_map(d, _dfn(gfn), mfn, page_order, 1, iommu_pte_flags, + &flush_flags) : + iommu_unmap(d, _dfn(gfn), page_order, 1, &flush_flags); + + if ( !rc ) + rc = iommu_iotlb_flush(d, _dfn(gfn), page_order, 1, flush_flags); + } /* * Free old intermediate tables if necessary. This has to be the diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c index db7bde0230..9f8b9bc5fd 100644 --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@ -1350,10 +1350,15 @@ int set_identity_p2m_entry(struct domain *d, unsigned long gfn_l, if ( !paging_mode_translate(p2m->domain) ) { - if ( !is_iommu_enabled(d) ) - return 0; - return iommu_legacy_map(d, _dfn(gfn_l), _mfn(gfn_l), PAGE_ORDER_4K, - IOMMUF_readable | IOMMUF_writable); + unsigned int flush_flags = 0; + + ret = iommu_map(d, _dfn(gfn_l), _mfn(gfn_l), PAGE_ORDER_4K, 1, + IOMMUF_readable | IOMMUF_writable, &flush_flags); + if ( !ret ) + ret = iommu_iotlb_flush(d, _dfn(gfn_l), PAGE_ORDER_4K, 1, + flush_flags); + + return ret; } gfn_lock(p2m, gfn, 0); @@ -1441,9 +1446,16 @@ int clear_identity_p2m_entry(struct domain *d, unsigned long gfn_l) if ( !paging_mode_translate(d) ) { - if ( !is_iommu_enabled(d) ) - return 0; - return iommu_legacy_unmap(d, _dfn(gfn_l), PAGE_ORDER_4K); + unsigned int flush_flags = 0; + int err; + + ret = iommu_unmap(d, _dfn(gfn_l), PAGE_ORDER_4K, 1, &flush_flags); + + err = iommu_iotlb_flush(d, _dfn(gfn_l), PAGE_ORDER_4K, 1, flush_flags); + if ( !ret ) + ret = err; + + return ret; } gfn_lock(p2m, gfn, 0); diff --git a/xen/arch/x86/x86_64/mm.c b/xen/arch/x86/x86_64/mm.c index 102079a801..02684bcf9d 100644 --- a/xen/arch/x86/x86_64/mm.c +++ b/xen/arch/x86/x86_64/mm.c @@ -1413,21 +1413,22 @@ int memory_add(unsigned long spfn, unsigned long epfn, unsigned int pxm) !iommu_use_hap_pt(hardware_domain) && !need_iommu_pt_sync(hardware_domain) ) { - for ( i = spfn; i < epfn; i++ ) - if ( iommu_legacy_map(hardware_domain, _dfn(i), _mfn(i), - PAGE_ORDER_4K, - IOMMUF_readable | IOMMUF_writable) ) - break; - if ( i != epfn ) - { - while (i-- > old_max) - /* If statement to satisfy __must_check. */ - if ( iommu_legacy_unmap(hardware_domain, _dfn(i), - PAGE_ORDER_4K) ) - continue; + unsigned int flush_flags = 0; + unsigned int n = epfn - spfn; + int rc; + ret = -EOVERFLOW; + if ( spfn + n != epfn ) + goto destroy_m2p; + + rc = iommu_map(hardware_domain, _dfn(i), _mfn(i), + PAGE_ORDER_4K, n, IOMMUF_readable | IOMMUF_writable, + &flush_flags); + if ( !rc ) + rc = iommu_iotlb_flush(hardware_domain, _dfn(i), PAGE_ORDER_4K, n, + flush_flags); + if ( rc ) goto destroy_m2p; - } } /* We can't revert any more */ diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c index 9f0cae52c0..d6526bca12 100644 --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -1225,11 +1225,23 @@ map_grant_ref( kind = IOMMUF_readable; else kind = 0; - if ( kind && iommu_legacy_map(ld, _dfn(mfn_x(mfn)), mfn, 0, kind) ) + if ( kind ) { - double_gt_unlock(lgt, rgt); - rc = GNTST_general_error; - goto undo_out; + dfn_t dfn = _dfn(mfn_x(mfn)); + unsigned int flush_flags = 0; + int err; + + err = iommu_map(ld, dfn, mfn, 0, 1, kind, &flush_flags); + if ( !err ) + err = iommu_iotlb_flush(ld, dfn, 0, 1, flush_flags); + if ( err ) + rc = GNTST_general_error; + + if ( rc != GNTST_okay ) + { + double_gt_unlock(lgt, rgt); + goto undo_out; + } } } @@ -1473,21 +1485,25 @@ unmap_common( if ( rc == GNTST_okay && gnttab_need_iommu_mapping(ld) ) { unsigned int kind; + dfn_t dfn = _dfn(mfn_x(op->mfn)); + unsigned int flush_flags = 0; int err = 0; double_gt_lock(lgt, rgt); kind = mapkind(lgt, rd, op->mfn); if ( !kind ) - err = iommu_legacy_unmap(ld, _dfn(mfn_x(op->mfn)), 0); + err = iommu_unmap(ld, dfn, 0, 1, &flush_flags); else if ( !(kind & MAPKIND_WRITE) ) - err = iommu_legacy_map(ld, _dfn(mfn_x(op->mfn)), op->mfn, 0, - IOMMUF_readable); - - double_gt_unlock(lgt, rgt); + err = iommu_map(ld, dfn, op->mfn, 0, 1, IOMMUF_readable, + &flush_flags); + if ( !err ) + err = iommu_iotlb_flush(ld, dfn, 0, 1, flush_flags); if ( err ) rc = GNTST_general_error; + + double_gt_unlock(lgt, rgt); } /* If just unmapped a writable mapping, mark as dirtied */ diff --git a/xen/common/memory.c b/xen/common/memory.c index 8de334ff10..2891bef57b 100644 --- a/xen/common/memory.c +++ b/xen/common/memory.c @@ -824,8 +824,7 @@ int xenmem_add_to_physmap(struct domain *d, struct xen_add_to_physmap *xatp, xatp->gpfn += start; xatp->size -= start; - if ( is_iommu_enabled(d) ) - this_cpu(iommu_dont_flush_iotlb) = 1; + this_cpu(iommu_dont_flush_iotlb) = true; while ( xatp->size > done ) { @@ -845,6 +844,8 @@ int xenmem_add_to_physmap(struct domain *d, struct xen_add_to_physmap *xatp, } } + this_cpu(iommu_dont_flush_iotlb) = false; + if ( is_iommu_enabled(d) ) { int ret; diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c index 568a4a5661..ab44c332bb 100644 --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -281,18 +281,6 @@ int iommu_map(struct domain *d, dfn_t dfn, mfn_t mfn, return rc; } -int iommu_legacy_map(struct domain *d, dfn_t dfn, mfn_t mfn, - unsigned int page_order, unsigned int flags) -{ - unsigned int flush_flags = 0; - int rc = iommu_map(d, dfn, mfn, page_order, 1, flags, &flush_flags); - - if ( !this_cpu(iommu_dont_flush_iotlb) && !rc ) - rc = iommu_iotlb_flush(d, dfn, (1u << page_order), 1, flush_flags); - - return rc; -} - int iommu_unmap(struct domain *d, dfn_t dfn, unsigned int page_order, unsigned int page_count, unsigned int *flush_flags) { @@ -335,17 +323,6 @@ int iommu_unmap(struct domain *d, dfn_t dfn, unsigned int page_order, return rc; } -int iommu_legacy_unmap(struct domain *d, dfn_t dfn, unsigned int page_order) -{ - unsigned int flush_flags = 0; - int rc = iommu_unmap(d, dfn, page_order, 1, &flush_flags); - - if ( !this_cpu(iommu_dont_flush_iotlb) && ! rc ) - rc = iommu_iotlb_flush(d, dfn, (1u << page_order), 1, flush_flags); - - return rc; -} - int iommu_lookup_page(struct domain *d, dfn_t dfn, mfn_t *mfn, unsigned int *flags) { @@ -364,7 +341,7 @@ int iommu_iotlb_flush(struct domain *d, dfn_t dfn, unsigned int page_order, int rc; if ( !is_iommu_enabled(d) || !hd->platform_ops->iotlb_flush || - !page_count || !flush_flags ) + !page_count || !flush_flags || this_cpu(iommu_dont_flush_iotlb) ) return 0; if ( dfn_eq(dfn, INVALID_DFN) ) diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h index d9c2e764aa..b7e5d3da09 100644 --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -151,16 +151,8 @@ int __must_check iommu_map(struct domain *d, dfn_t dfn, mfn_t mfn, int __must_check iommu_unmap(struct domain *d, dfn_t dfn, unsigned int page_order, unsigned int page_count, unsigned int *flush_flags); - -int __must_check iommu_legacy_map(struct domain *d, dfn_t dfn, mfn_t mfn, - unsigned int page_order, - unsigned int flags); -int __must_check iommu_legacy_unmap(struct domain *d, dfn_t dfn, - unsigned int page_order); - int __must_check iommu_lookup_page(struct domain *d, dfn_t dfn, mfn_t *mfn, unsigned int *flags); - int __must_check iommu_iotlb_flush(struct domain *d, dfn_t dfn, unsigned int page_order, unsigned int page_count, @@ -370,15 +362,12 @@ void iommu_dev_iotlb_flush_timeout(struct domain *d, struct pci_dev *pdev); /* * The purpose of the iommu_dont_flush_iotlb optional cpu flag is to - * avoid unecessary iotlb_flush in the low level IOMMU code. - * - * iommu_map_page/iommu_unmap_page must flush the iotlb but somethimes - * this operation can be really expensive. This flag will be set by the - * caller to notify the low level IOMMU code to avoid the iotlb flushes. - * iommu_iotlb_flush/iommu_iotlb_flush_all will be explicitly called by - * the caller. + * avoid unecessary IOMMU flushing while updating the P2M. + * Setting the value to true will cause iommu_iotlb_flush() to return without + * actually performing a flush. A batch flush must therefore be done by the + * calling code after setting the value back to false. */ -DECLARE_PER_CPU(bool_t, iommu_dont_flush_iotlb); +DECLARE_PER_CPU(bool, iommu_dont_flush_iotlb); extern struct spinlock iommu_pt_cleanup_lock; extern struct page_list_head iommu_pt_cleanup_list; -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 13:53:04 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 13:53:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xNB-0001h7-V7; Tue, 04 Aug 2020 13:52:57 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xNA-0001h0-FM for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 13:52:56 +0000 X-Inumbo-ID: 27aa72e7-1a80-4003-b49f-1967c04e64d5 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 27aa72e7-1a80-4003-b49f-1967c04e64d5; Tue, 04 Aug 2020 13:52:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5ihO59wyAX8zkLS1CY3TtNPmuystf+aQGxWecJuP6eM=; b=ml8AtgUUu4GlCZpsftB6HeKtql Fgw05jiBmxFS4XfSh0GXD0m2zuOk+zRLiusaIfA0S2rY7OnaH+Hp2oeSXA0kfw5ZFNFSn7OADhkFY WeB6caaV8vukH53cgwoxxP9fODpkHW9nweihEED/AOlwDcI3Ju4MXAD4vG/c+VfHhdTo=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xN1-0008KJ-64; Tue, 04 Aug 2020 13:52:47 +0000 Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k2xN0-0004Ao-RL; Tue, 04 Aug 2020 13:52:46 +0000 Subject: Re: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common To: Oleksandr , paul@xen.org, xen-devel@lists.xenproject.org References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-2-git-send-email-olekstysh@gmail.com> <000c01d66a33$2bd56510$83802f30$@xen.org> <9f83a7ed-ca97-449f-c7b9-a1140644abe9@gmail.com> From: Julien Grall Message-ID: Date: Tue, 4 Aug 2020 14:52:43 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <9f83a7ed-ca97-449f-c7b9-a1140644abe9@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: 'Kevin Tian' , 'Stefano Stabellini' , 'Jun Nakajima' , 'Wei Liu' , 'Andrew Cooper' , 'Ian Jackson' , 'George Dunlap' , 'Tim Deegan' , 'Oleksandr Tyshchenko' , 'Julien Grall' , 'Jan Beulich' , =?UTF-8?B?J1JvZ2VyIFBhdSBNb25uw6kn?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Hi, On 04/08/2020 12:10, Oleksandr wrote: > On 04.08.20 10:45, Paul Durrant wrote: >>> +static inline bool hvm_ioreq_needs_completion(const ioreq_t *ioreq) >>> +{ >>> +    return ioreq->state == STATE_IOREQ_READY && >>> +           !ioreq->data_is_ptr && >>> +           (ioreq->type != IOREQ_TYPE_PIO || ioreq->dir != >>> IOREQ_WRITE); >>> +} >> I don't think having this in common code is correct. The short-cut of >> not completing PIO reads seems somewhat x86 specific. Hmmm, looking at the code, I think it doesn't wait for PIO writes to complete (not read). Did I miss anything? > Does ARM even >> have the concept of PIO? > > I am not 100% sure here, but it seems that doesn't have. Technically, the PIOs exist on Arm, however they are accessed the same way as MMIO and will have a dedicated area defined by the HW. AFAICT, on Arm64, they are only used for PCI IO Bar. Now the question is whether we want to expose them to the Device Emulator as PIO or MMIO access. From a generic PoV, a DM shouldn't have to care about the architecture used. It should just be able to request a given IOport region. So it may make sense to differentiate them in the common ioreq code as well. I had a quick look at QEMU and wasn't able to tell if PIOs and MMIOs address space are different on Arm as well. Paul, Stefano, do you know what they are doing? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Aug 04 14:02:28 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 14:02:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xWH-0002gS-T9; Tue, 04 Aug 2020 14:02:21 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xWG-0002gN-Bn for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 14:02:20 +0000 X-Inumbo-ID: 700f1ab7-786a-4b27-b03b-99a20e3dfb7c Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 700f1ab7-786a-4b27-b03b-99a20e3dfb7c; Tue, 04 Aug 2020 14:02:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=0xm34ZhZtkbjneIiksswdOIJjA+6W/un6UZlSsYeumU=; b=JT3do+Hri4H5cQNf7WCPxIcj9R +WN9eDi+alRjVABzYukw0nZEIVVYItwh6zkY6Et6EmBykTI2kQ1YX9Sd0cfaIzvyvwGcvSDuMoDhV MD0dAUIQSVBv6wUhr+fTbJNTNlwtQKQrEp1sxX47DfbmorBG3Ze+ueyjNfzyi9YYuPRA=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xVw-0000C7-Qr; Tue, 04 Aug 2020 14:02:00 +0000 Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k2xVw-0004ro-Fr; Tue, 04 Aug 2020 14:02:00 +0000 Subject: Re: [RFC PATCH V1 04/12] xen/arm: Introduce arch specific bits for IOREQ/DM features To: paul@xen.org, 'Oleksandr Tyshchenko' , xen-devel@lists.xenproject.org References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-5-git-send-email-olekstysh@gmail.com> <001101d66a33$bba44670$32ecd350$@xen.org> From: Julien Grall Message-ID: <6c4f7698-a015-91c7-83ec-203f63d48900@xen.org> Date: Tue, 4 Aug 2020 15:01:57 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <001101d66a33$bba44670$32ecd350$@xen.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: 'Stefano Stabellini' , 'Wei Liu' , 'Andrew Cooper' , 'Ian Jackson' , 'George Dunlap' , 'Oleksandr Tyshchenko' , 'Julien Grall' , 'Jan Beulich' , 'Daniel De Graaf' , 'Volodymyr Babchuk' Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Hi Paul, On 04/08/2020 08:49, Paul Durrant wrote: >> diff --git a/tools/libxc/xc_dom_arm.c b/tools/libxc/xc_dom_arm.c >> index 931404c..b5fc066 100644 >> --- a/tools/libxc/xc_dom_arm.c >> +++ b/tools/libxc/xc_dom_arm.c >> @@ -26,11 +26,19 @@ >> #include "xg_private.h" >> #include "xc_dom.h" >> >> -#define NR_MAGIC_PAGES 4 >> + >> #define CONSOLE_PFN_OFFSET 0 >> #define XENSTORE_PFN_OFFSET 1 >> #define MEMACCESS_PFN_OFFSET 2 >> #define VUART_PFN_OFFSET 3 >> +#define IOREQ_SERVER_PFN_OFFSET 4 >> + >> +#define NR_IOREQ_SERVER_PAGES 8 >> +#define NR_MAGIC_PAGES (4 + NR_IOREQ_SERVER_PAGES) >> + >> +#define GUEST_MAGIC_BASE_PFN (GUEST_MAGIC_BASE >> XC_PAGE_SHIFT) >> + >> +#define special_pfn(x) (GUEST_MAGIC_BASE_PFN + (x)) > > Why introduce 'magic pages' for Arm? It's quite a horrible hack that we have begun to do away with by adding resource mapping. This would require us to mandate at least Linux 4.17 in a domain that will run an IOREQ server. If we don't mandate this, the minimum version would be 4.10 where DM OP was introduced. Because of XSA-300, we could technically not safely run an IOREQ server with existing Linux. So it is probably OK to enforce the use of the acquire interface. Note that I haven't yet looked at the rest of the series. So I am not sure if there is more work necessary to enable it. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Aug 04 14:10:04 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 14:10:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xde-0002tI-78; Tue, 04 Aug 2020 14:09:58 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xdd-0002sb-2d for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 14:09:57 +0000 X-Inumbo-ID: 8aa9938d-f19e-463d-9cf1-90edaedb9d7c Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8aa9938d-f19e-463d-9cf1-90edaedb9d7c; Tue, 04 Aug 2020 14:09:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=JvpjW2yuqqsP9Nf9RqSvKwq47T2XEc66z0tnFgkOJgM=; b=xwRDKOxBVWnuOYXjXfJ1l7Y7RT /Re88HAIGfds3UwtASLEhpS8cDOsiSt7FpdYq0ztVDs4/pkOX5/+iulbdk1eQTT/LihBH4oHxAgDD 2IBjcQt0Vz67LtoBJYqfbuBdZwQxCWKgNpGf69gxnQFP0botnfTkpGZAQJCbPRAHHN8s=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xdW-0000NX-8o; Tue, 04 Aug 2020 14:09:50 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2xD0-0003ag-Kz; Tue, 04 Aug 2020 13:42:26 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v4 10/14] iommu: remove the share_p2m operation Date: Tue, 4 Aug 2020 14:42:05 +0100 Message-Id: <20200804134209.8717-11-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200804134209.8717-1-paul@xen.org> References: <20200804134209.8717-1-paul@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Tian , Wei Liu , Andrew Cooper , Paul Durrant , George Dunlap , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant Sharing of HAP tables is now VT-d specific so the operation is never defined for AMD IOMMU any more. There's also no need to pro-actively set vtd.pgd_maddr when using shared EPT as it is straightforward to simply define a helper function to return the appropriate value in the shared and non-shared cases. Signed-off-by: Paul Durrant --- Cc: Jan Beulich Cc: Andrew Cooper Cc: George Dunlap Cc: Wei Liu Cc: "Roger Pau Monné" Cc: Kevin Tian v2: - Put the PGD level adjust into the helper function too, since it is irrelevant in the shared EPT case --- xen/arch/x86/mm/p2m.c | 3 - xen/drivers/passthrough/iommu.c | 8 --- xen/drivers/passthrough/vtd/iommu.c | 90 ++++++++++++++++------------- xen/include/xen/iommu.h | 3 - 4 files changed, 50 insertions(+), 54 deletions(-) diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c index 9f8b9bc5fd..3bd8d83d23 100644 --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@ -726,9 +726,6 @@ int p2m_alloc_table(struct p2m_domain *p2m) p2m->phys_table = pagetable_from_mfn(top_mfn); - if ( hap_enabled(d) ) - iommu_share_p2m_table(d); - p2m_unlock(p2m); return 0; } diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c index ab44c332bb..7464f10d1c 100644 --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -498,14 +498,6 @@ int iommu_do_domctl( return ret; } -void iommu_share_p2m_table(struct domain* d) -{ - ASSERT(hap_enabled(d)); - - if ( iommu_use_hap_pt(d) ) - iommu_get_ops()->share_p2m(d); -} - void iommu_crash_shutdown(void) { if ( !iommu_crash_disable ) diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c index 68cf0e535a..a532d9e88c 100644 --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -318,6 +318,48 @@ static u64 addr_to_dma_page_maddr(struct domain *domain, u64 addr, int alloc) return pte_maddr; } +static uint64_t domain_pgd_maddr(struct domain *d, struct vtd_iommu *iommu) +{ + struct domain_iommu *hd = dom_iommu(d); + uint64_t pgd_maddr; + unsigned int agaw; + + ASSERT(spin_is_locked(&hd->arch.mapping_lock)); + + if ( iommu_use_hap_pt(d) ) + { + mfn_t pgd_mfn = + pagetable_get_mfn(p2m_get_pagetable(p2m_get_hostp2m(d))); + + return pagetable_get_paddr(pagetable_from_mfn(pgd_mfn)); + } + + if ( !hd->arch.vtd.pgd_maddr ) + { + addr_to_dma_page_maddr(d, 0, 1); + + if ( !hd->arch.vtd.pgd_maddr ) + return 0; + } + + pgd_maddr = hd->arch.vtd.pgd_maddr; + + /* Skip top levels of page tables for 2- and 3-level DRHDs. */ + for ( agaw = level_to_agaw(4); + agaw != level_to_agaw(iommu->nr_pt_levels); + agaw-- ) + { + struct dma_pte *p = map_vtd_domain_page(pgd_maddr); + + pgd_maddr = dma_pte_addr(*p); + unmap_vtd_domain_page(p); + if ( !pgd_maddr ) + return 0; + } + + return pgd_maddr; +} + static void iommu_flush_write_buffer(struct vtd_iommu *iommu) { u32 val; @@ -1286,7 +1328,7 @@ int domain_context_mapping_one( struct context_entry *context, *context_entries; u64 maddr, pgd_maddr; u16 seg = iommu->drhd->segment; - int agaw, rc, ret; + int rc, ret; bool_t flush_dev_iotlb; ASSERT(pcidevs_locked()); @@ -1340,37 +1382,18 @@ int domain_context_mapping_one( if ( iommu_hwdom_passthrough && is_hardware_domain(domain) ) { context_set_translation_type(*context, CONTEXT_TT_PASS_THRU); - agaw = level_to_agaw(iommu->nr_pt_levels); } else { spin_lock(&hd->arch.mapping_lock); - /* Ensure we have pagetables allocated down to leaf PTE. */ - if ( hd->arch.vtd.pgd_maddr == 0 ) + pgd_maddr = domain_pgd_maddr(domain, iommu); + if ( !pgd_maddr ) { - addr_to_dma_page_maddr(domain, 0, 1); - if ( hd->arch.vtd.pgd_maddr == 0 ) - { - nomem: - spin_unlock(&hd->arch.mapping_lock); - spin_unlock(&iommu->lock); - unmap_vtd_domain_page(context_entries); - return -ENOMEM; - } - } - - /* Skip top levels of page tables for 2- and 3-level DRHDs. */ - pgd_maddr = hd->arch.vtd.pgd_maddr; - for ( agaw = level_to_agaw(4); - agaw != level_to_agaw(iommu->nr_pt_levels); - agaw-- ) - { - struct dma_pte *p = map_vtd_domain_page(pgd_maddr); - pgd_maddr = dma_pte_addr(*p); - unmap_vtd_domain_page(p); - if ( pgd_maddr == 0 ) - goto nomem; + spin_unlock(&hd->arch.mapping_lock); + spin_unlock(&iommu->lock); + unmap_vtd_domain_page(context_entries); + return -ENOMEM; } context_set_address_root(*context, pgd_maddr); @@ -1389,7 +1412,7 @@ int domain_context_mapping_one( return -EFAULT; } - context_set_address_width(*context, agaw); + context_set_address_width(*context, level_to_agaw(iommu->nr_pt_levels)); context_set_fault_enable(*context); context_set_present(*context); iommu_sync_cache(context, sizeof(struct context_entry)); @@ -1848,18 +1871,6 @@ static int __init vtd_ept_page_compatible(struct vtd_iommu *iommu) (ept_has_1gb(ept_cap) && opt_hap_1gb) <= cap_sps_1gb(vtd_cap); } -/* - * set VT-d page table directory to EPT table if allowed - */ -static void iommu_set_pgd(struct domain *d) -{ - mfn_t pgd_mfn; - - pgd_mfn = pagetable_get_mfn(p2m_get_pagetable(p2m_get_hostp2m(d))); - dom_iommu(d)->arch.vtd.pgd_maddr = - pagetable_get_paddr(pagetable_from_mfn(pgd_mfn)); -} - static int rmrr_identity_mapping(struct domain *d, bool_t map, const struct acpi_rmrr_unit *rmrr, u32 flag) @@ -2719,7 +2730,6 @@ static struct iommu_ops __initdata vtd_ops = { .adjust_irq_affinities = adjust_vtd_irq_affinities, .suspend = vtd_suspend, .resume = vtd_resume, - .share_p2m = iommu_set_pgd, .crash_shutdown = vtd_crash_shutdown, .iotlb_flush = iommu_flush_iotlb_pages, .iotlb_flush_all = iommu_flush_iotlb_all, diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h index b7e5d3da09..1f25d2082f 100644 --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -271,7 +271,6 @@ struct iommu_ops { int __must_check (*suspend)(void); void (*resume)(void); - void (*share_p2m)(struct domain *d); void (*crash_shutdown)(void); int __must_check (*iotlb_flush)(struct domain *d, dfn_t dfn, unsigned long page_count, @@ -348,8 +347,6 @@ void iommu_resume(void); void iommu_crash_shutdown(void); int iommu_get_reserved_device_memory(iommu_grdm_t *, void *); -void iommu_share_p2m_table(struct domain *d); - #ifdef CONFIG_HAS_PCI int iommu_do_pci_domctl(struct xen_domctl *, struct domain *d, XEN_GUEST_HANDLE_PARAM(xen_domctl_t)); -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 14:10:04 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 14:10:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xdi-0003A0-TO; Tue, 04 Aug 2020 14:10:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xdi-0002sb-2i for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 14:10:02 +0000 X-Inumbo-ID: bc1489a7-74f6-4eaa-87cb-684913bc71d2 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id bc1489a7-74f6-4eaa-87cb-684913bc71d2; Tue, 04 Aug 2020 14:09:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uvyR25AaTXnMjxvAXH3JBMG1O3l/XReVQ/qLaoATIEQ=; b=IgSq7zX+HgUbR8jlXfmJavXvtT q9ou7mgARev09hJZJgQtgLCU3dJFScWjNLeMXNuaB8S8L4qITnosDgxAnPUxGtrecQurAM/jB4Ru3 WBy4irE7cRa/FAj9VcCsiFqTVFewVbi/gHmV06P4XYfHv5T3+Hs2CAYrnQLAoz8gcx+8=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xdW-0000Nd-FU; Tue, 04 Aug 2020 14:09:50 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2xD1-0003ag-L6; Tue, 04 Aug 2020 13:42:27 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v4 11/14] iommu: stop calling IOMMU page tables 'p2m tables' Date: Tue, 4 Aug 2020 14:42:06 +0100 Message-Id: <20200804134209.8717-12-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200804134209.8717-1-paul@xen.org> References: <20200804134209.8717-1-paul@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Paul Durrant , Kevin Tian , Jan Beulich , Paul Durrant Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant It's confusing and not consistent with the terminology introduced with 'dfn_t'. Just call them IOMMU page tables. Also remove a pointless check of the 'acpi_drhd_units' list in vtd_dump_page_table_level(). If the list is empty then IOMMU mappings would not have been enabled for the domain in the first place. NOTE: All calls to printk() have also been removed from iommu_dump_page_tables(); the implementation specific code is now responsible for all output. The check for the global 'iommu_enabled' has also been replaced by an ASSERT since iommu_dump_page_tables() is not registered as a key handler unless IOMMU mappings are enabled. Signed-off-by: Paul Durrant --- Cc: Jan Beulich Cc: Andrew Cooper Cc: Paul Durrant Cc: Kevin Tian v2: - Moved all output into implementation specific code --- xen/drivers/passthrough/amd/pci_amd_iommu.c | 16 ++++++------- xen/drivers/passthrough/iommu.c | 21 ++++------------- xen/drivers/passthrough/vtd/iommu.c | 26 +++++++++++---------- xen/include/xen/iommu.h | 2 +- 4 files changed, 28 insertions(+), 37 deletions(-) diff --git a/xen/drivers/passthrough/amd/pci_amd_iommu.c b/xen/drivers/passthrough/amd/pci_amd_iommu.c index 3390c22cf3..be578607b1 100644 --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c @@ -491,8 +491,8 @@ static int amd_iommu_group_id(u16 seg, u8 bus, u8 devfn) #include -static void amd_dump_p2m_table_level(struct page_info* pg, int level, - paddr_t gpa, int indent) +static void amd_dump_page_table_level(struct page_info* pg, int level, + paddr_t gpa, int indent) { paddr_t address; struct amd_iommu_pte *table_vaddr; @@ -529,7 +529,7 @@ static void amd_dump_p2m_table_level(struct page_info* pg, int level, address = gpa + amd_offset_level_address(index, level); if ( pde->next_level >= 1 ) - amd_dump_p2m_table_level( + amd_dump_page_table_level( mfn_to_page(_mfn(pde->mfn)), pde->next_level, address, indent + 1); else @@ -542,16 +542,16 @@ static void amd_dump_p2m_table_level(struct page_info* pg, int level, unmap_domain_page(table_vaddr); } -static void amd_dump_p2m_table(struct domain *d) +static void amd_dump_page_tables(struct domain *d) { const struct domain_iommu *hd = dom_iommu(d); if ( !hd->arch.amd.root_table ) return; - printk("p2m table has %u levels\n", hd->arch.amd.paging_mode); - amd_dump_p2m_table_level(hd->arch.amd.root_table, - hd->arch.amd.paging_mode, 0, 0); + printk("AMD IOMMU table has %u levels\n", hd->arch.amd.paging_mode); + amd_dump_page_table_level(hd->arch.amd.root_table, + hd->arch.amd.paging_mode, 0, 0); } static const struct iommu_ops __initconstrel _iommu_ops = { @@ -578,7 +578,7 @@ static const struct iommu_ops __initconstrel _iommu_ops = { .suspend = amd_iommu_suspend, .resume = amd_iommu_resume, .crash_shutdown = amd_iommu_crash_shutdown, - .dump_p2m_table = amd_dump_p2m_table, + .dump_page_tables = amd_dump_page_tables, }; static const struct iommu_init_ops __initconstrel _iommu_init_ops = { diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c index 7464f10d1c..0f468379e1 100644 --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -22,7 +22,7 @@ #include #include -static void iommu_dump_p2m_table(unsigned char key); +static void iommu_dump_page_tables(unsigned char key); unsigned int __read_mostly iommu_dev_iotlb_timeout = 1000; integer_param("iommu_dev_iotlb_timeout", iommu_dev_iotlb_timeout); @@ -212,7 +212,7 @@ void __hwdom_init iommu_hwdom_init(struct domain *d) if ( !is_iommu_enabled(d) ) return; - register_keyhandler('o', &iommu_dump_p2m_table, "dump iommu p2m table", 0); + register_keyhandler('o', &iommu_dump_page_tables, "dump iommu page tables", 0); hd->platform_ops->hwdom_init(d); } @@ -533,16 +533,12 @@ bool_t iommu_has_feature(struct domain *d, enum iommu_feature feature) return is_iommu_enabled(d) && test_bit(feature, dom_iommu(d)->features); } -static void iommu_dump_p2m_table(unsigned char key) +static void iommu_dump_page_tables(unsigned char key) { struct domain *d; const struct iommu_ops *ops; - if ( !iommu_enabled ) - { - printk("IOMMU not enabled!\n"); - return; - } + ASSERT(iommu_enabled); ops = iommu_get_ops(); @@ -553,14 +549,7 @@ static void iommu_dump_p2m_table(unsigned char key) if ( is_hardware_domain(d) || !is_iommu_enabled(d) ) continue; - if ( iommu_use_hap_pt(d) ) - { - printk("\ndomain%d IOMMU p2m table shared with MMU: \n", d->domain_id); - continue; - } - - printk("\ndomain%d IOMMU p2m table: \n", d->domain_id); - ops->dump_p2m_table(d); + ops->dump_page_tables(d); } rcu_read_unlock(&domlist_read_lock); diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c index a532d9e88c..f8da4fe0e7 100644 --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -2582,8 +2582,8 @@ static void vtd_resume(void) } } -static void vtd_dump_p2m_table_level(paddr_t pt_maddr, int level, paddr_t gpa, - int indent) +static void vtd_dump_page_table_level(paddr_t pt_maddr, int level, paddr_t gpa, + int indent) { paddr_t address; int i; @@ -2612,8 +2612,8 @@ static void vtd_dump_p2m_table_level(paddr_t pt_maddr, int level, paddr_t gpa, address = gpa + offset_level_address(i, level); if ( next_level >= 1 ) - vtd_dump_p2m_table_level(dma_pte_addr(*pte), next_level, - address, indent + 1); + vtd_dump_page_table_level(dma_pte_addr(*pte), next_level, + address, indent + 1); else printk("%*sdfn: %08lx mfn: %08lx\n", indent, "", @@ -2624,17 +2624,19 @@ static void vtd_dump_p2m_table_level(paddr_t pt_maddr, int level, paddr_t gpa, unmap_vtd_domain_page(pt_vaddr); } -static void vtd_dump_p2m_table(struct domain *d) +static void vtd_dump_page_tables(struct domain *d) { - const struct domain_iommu *hd; + const struct domain_iommu *hd = dom_iommu(d); - if ( list_empty(&acpi_drhd_units) ) + if ( iommu_use_hap_pt(d) ) + { + printk("VT-D sharing EPT table\n"); return; + } - hd = dom_iommu(d); - printk("p2m table has %d levels\n", agaw_to_level(hd->arch.vtd.agaw)); - vtd_dump_p2m_table_level(hd->arch.vtd.pgd_maddr, - agaw_to_level(hd->arch.vtd.agaw), 0, 0); + printk("VT-D table has %d levels\n", agaw_to_level(hd->arch.vtd.agaw)); + vtd_dump_page_table_level(hd->arch.vtd.pgd_maddr, + agaw_to_level(hd->arch.vtd.agaw), 0, 0); } static int __init intel_iommu_quarantine_init(struct domain *d) @@ -2734,7 +2736,7 @@ static struct iommu_ops __initdata vtd_ops = { .iotlb_flush = iommu_flush_iotlb_pages, .iotlb_flush_all = iommu_flush_iotlb_all, .get_reserved_device_memory = intel_iommu_get_reserved_device_memory, - .dump_p2m_table = vtd_dump_p2m_table, + .dump_page_tables = vtd_dump_page_tables, }; const struct iommu_init_ops __initconstrel intel_iommu_init_ops = { diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h index 1f25d2082f..23e884f54b 100644 --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -277,7 +277,7 @@ struct iommu_ops { unsigned int flush_flags); int __must_check (*iotlb_flush_all)(struct domain *d); int (*get_reserved_device_memory)(iommu_grdm_t *, void *); - void (*dump_p2m_table)(struct domain *d); + void (*dump_page_tables)(struct domain *d); #ifdef CONFIG_HAS_DEVICE_TREE /* -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 14:10:04 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 14:10:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xdZ-0002sr-Tr; Tue, 04 Aug 2020 14:09:53 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xdY-0002sc-EL for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 14:09:52 +0000 X-Inumbo-ID: e6d1172f-13ce-442e-96b2-c2dfa8c30830 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e6d1172f-13ce-442e-96b2-c2dfa8c30830; Tue, 04 Aug 2020 14:09:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=IHm3gqKYAGKodBfFZkdVX7R/Bh2xcC6ZnjwhNY8umHs=; b=Ll5cp1FeUPCVrAHmjsFlUQiFRO 8kbu9ol7KHkfVTGYi7UlsiYBPMnaZiiN2LKx9bqD+t+RoK/U7Lk8tY/pQ9n82DLDsr8rzndNldLax FXOeY2mjGGM0DNyJeplH1w3cDVPWb3Ec6nhARC8NauYN54qcCUcww31WRP8+yH5TNYKk=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xdW-0000NV-3W; Tue, 04 Aug 2020 14:09:50 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2xD4-0003ag-1m; Tue, 04 Aug 2020 13:42:30 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v4 14/14] vtd: use a bit field for dma_pte Date: Tue, 4 Aug 2020 14:42:09 +0100 Message-Id: <20200804134209.8717-15-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200804134209.8717-1-paul@xen.org> References: <20200804134209.8717-1-paul@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Paul Durrant , Kevin Tian Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant As with a prior patch for context_entry, this removes the need for much shifting, masking and several magic numbers. Signed-off-by: Paul Durrant --- Cc: Kevin Tian v4: - New in v4 --- xen/drivers/passthrough/vtd/iommu.c | 9 ++--- xen/drivers/passthrough/vtd/iommu.h | 55 +++++++++++++++++------------ 2 files changed, 38 insertions(+), 26 deletions(-) diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c index 766d33058e..2d60cebe67 100644 --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -1772,13 +1772,14 @@ static int __must_check intel_iommu_map_page(struct domain *d, dfn_t dfn, old = *pte; dma_set_pte_addr(new, mfn_to_maddr(mfn)); - dma_set_pte_prot(new, - ((flags & IOMMUF_readable) ? DMA_PTE_READ : 0) | - ((flags & IOMMUF_writable) ? DMA_PTE_WRITE : 0)); + if ( flags & IOMMUF_readable ) + dma_set_pte_readable(new); + if ( flags & IOMMUF_writable ) + dma_set_pte_writable(new); /* Set the SNP on leaf page table if Snoop Control available */ if ( iommu_snoop ) - dma_set_pte_snp(new); + dma_set_pte_snoop(new); if ( old.val == new.val ) { diff --git a/xen/drivers/passthrough/vtd/iommu.h b/xen/drivers/passthrough/vtd/iommu.h index 509d13918a..017286b0e1 100644 --- a/xen/drivers/passthrough/vtd/iommu.h +++ b/xen/drivers/passthrough/vtd/iommu.h @@ -283,29 +283,40 @@ struct context_entry { * 12-63: Host physcial address */ struct dma_pte { - u64 val; + union { + uint64_t val; + struct { + uint64_t r:1; + uint64_t w:1; + uint64_t reserved0:1; + uint64_t ignored0:4; + uint64_t ps:1; + uint64_t ignored1:3; + uint64_t snp:1; + uint64_t addr:52; + }; + }; }; -#define DMA_PTE_READ (1) -#define DMA_PTE_WRITE (2) -#define DMA_PTE_PROT (DMA_PTE_READ | DMA_PTE_WRITE) -#define DMA_PTE_SP (1 << 7) -#define DMA_PTE_SNP (1 << 11) -#define dma_clear_pte(p) do {(p).val = 0;} while(0) -#define dma_set_pte_readable(p) do {(p).val |= DMA_PTE_READ;} while(0) -#define dma_set_pte_writable(p) do {(p).val |= DMA_PTE_WRITE;} while(0) -#define dma_set_pte_superpage(p) do {(p).val |= DMA_PTE_SP;} while(0) -#define dma_set_pte_snp(p) do {(p).val |= DMA_PTE_SNP;} while(0) -#define dma_set_pte_prot(p, prot) do { \ - (p).val = ((p).val & ~DMA_PTE_PROT) | ((prot) & DMA_PTE_PROT); \ - } while (0) -#define dma_pte_prot(p) ((p).val & DMA_PTE_PROT) -#define dma_pte_read(p) (dma_pte_prot(p) & DMA_PTE_READ) -#define dma_pte_write(p) (dma_pte_prot(p) & DMA_PTE_WRITE) -#define dma_pte_addr(p) ((p).val & PADDR_MASK & PAGE_MASK_4K) -#define dma_set_pte_addr(p, addr) do {\ - (p).val |= ((addr) & PAGE_MASK_4K); } while (0) -#define dma_pte_present(p) (((p).val & DMA_PTE_PROT) != 0) -#define dma_pte_superpage(p) (((p).val & DMA_PTE_SP) != 0) + +#define dma_pte_read(p) ((p).r) +#define dma_set_pte_readable(p) do { (p).r = 1; } while (0) + +#define dma_pte_write(p) ((p).w) +#define dma_set_pte_writable(p) do { (p).w = 1; } while (0) + +#define dma_pte_addr(p) ((p).addr << PAGE_SHIFT_4K) +#define dma_set_pte_addr(p, val) \ + do { (p).addr = (val) >> PAGE_SHIFT_4K; } while (0) + +#define dma_pte_present(p) ((p).r || (p).w) + +#define dma_pte_superpage(p) ((p).ps) +#define dma_set_pte_superpage(p) do { (p).ps = 1; } while (0) + +#define dma_pte_snoop(p) ((p).snp) +#define dma_set_pte_snoop(p) do { (p).snp = 1; } while (0) + +#define dma_clear_pte(p) do { (p).val = 0; } while (0) /* interrupt remap entry */ struct iremap_entry { -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 14:10:04 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 14:10:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xde-0002tR-GT; Tue, 04 Aug 2020 14:09:58 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xdd-0002sc-A8 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 14:09:57 +0000 X-Inumbo-ID: 90780af9-081f-42d5-b893-424c160e7350 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 90780af9-081f-42d5-b893-424c160e7350; Tue, 04 Aug 2020 14:09:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vAf8F1azmxpSkAU8hG593+fhhZfmNP3RoDkUnJJss0w=; b=prve2la1ewe4a9OxTHH6gPrFEH B8TkYPdb3iFIQ0Coz6PZg3AyB6HjvJicebvoBR2FVNF5sppLB4XJAi6sDhatxMD481BMYm6q7fxSU 2gYS9iPcBoiB7BgdzLp1yhooNMLSDRqU/3UQxHE7R+AXPdtX5ofGA+VhRA/Q9nZRhkSY=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xdW-0000NZ-Bq; Tue, 04 Aug 2020 14:09:50 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2xD2-0003ag-Eg; Tue, 04 Aug 2020 13:42:28 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v4 12/14] vtd: use a bit field for root_entry Date: Tue, 4 Aug 2020 14:42:07 +0100 Message-Id: <20200804134209.8717-13-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200804134209.8717-1-paul@xen.org> References: <20200804134209.8717-1-paul@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Paul Durrant , Kevin Tian Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant This makes the code a little easier to read and also makes it more consistent with iremap_entry. Also take the opportunity to tidy up the implementation of device_in_domain(). Signed-off-by: Paul Durrant --- Cc: Kevin Tian v4: - New in v4 --- xen/drivers/passthrough/vtd/iommu.c | 4 ++-- xen/drivers/passthrough/vtd/iommu.h | 33 ++++++++++++++++----------- xen/drivers/passthrough/vtd/utils.c | 4 ++-- xen/drivers/passthrough/vtd/x86/ats.c | 27 ++++++++++++---------- 4 files changed, 39 insertions(+), 29 deletions(-) diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c index f8da4fe0e7..76025f6ccd 100644 --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -245,11 +245,11 @@ static u64 bus_to_context_maddr(struct vtd_iommu *iommu, u8 bus) unmap_vtd_domain_page(root_entries); return 0; } - set_root_value(*root, maddr); + set_root_ctp(*root, maddr); set_root_present(*root); iommu_sync_cache(root, sizeof(struct root_entry)); } - maddr = (u64) get_context_addr(*root); + maddr = root_ctp(*root); unmap_vtd_domain_page(root_entries); return maddr; } diff --git a/xen/drivers/passthrough/vtd/iommu.h b/xen/drivers/passthrough/vtd/iommu.h index 216791b3d6..031ac5f66c 100644 --- a/xen/drivers/passthrough/vtd/iommu.h +++ b/xen/drivers/passthrough/vtd/iommu.h @@ -184,21 +184,28 @@ #define dma_frcd_source_id(c) (c & 0xffff) #define dma_frcd_page_addr(d) (d & (((u64)-1) << 12)) /* low 64 bit */ -/* - * 0: Present - * 1-11: Reserved - * 12-63: Context Ptr (12 - (haw-1)) - * 64-127: Reserved - */ struct root_entry { - u64 val; - u64 rsvd1; + union { + __uint128_t val; + struct { uint64_t lo, hi; }; + struct { + /* 0 - 63 */ + uint64_t p:1; + uint64_t reserved0:11; + uint64_t ctp:52; + + /* 64 - 127 */ + uint64_t reserved1; + }; + }; }; -#define root_present(root) ((root).val & 1) -#define set_root_present(root) do {(root).val |= 1;} while(0) -#define get_context_addr(root) ((root).val & PAGE_MASK_4K) -#define set_root_value(root, value) \ - do {(root).val |= ((value) & PAGE_MASK_4K);} while(0) + +#define root_present(r) (r).p +#define set_root_present(r) do { (r).p = 1; } while (0) + +#define root_ctp(r) ((r).ctp << PAGE_SHIFT_4K) +#define set_root_ctp(r, val) \ + do { (r).ctp = ((val) >> PAGE_SHIFT_4K); } while (0) struct context_entry { u64 lo; diff --git a/xen/drivers/passthrough/vtd/utils.c b/xen/drivers/passthrough/vtd/utils.c index 4febcf506d..4c85242894 100644 --- a/xen/drivers/passthrough/vtd/utils.c +++ b/xen/drivers/passthrough/vtd/utils.c @@ -112,7 +112,7 @@ void print_vtd_entries(struct vtd_iommu *iommu, int bus, int devfn, u64 gmfn) return; } - printk(" root_entry[%02x] = %"PRIx64"\n", bus, root_entry[bus].val); + printk(" root_entry[%02x] = %"PRIx64"\n", bus, root_entry[bus].lo); if ( !root_present(root_entry[bus]) ) { unmap_vtd_domain_page(root_entry); @@ -120,7 +120,7 @@ void print_vtd_entries(struct vtd_iommu *iommu, int bus, int devfn, u64 gmfn) return; } - val = root_entry[bus].val; + val = root_ctp(root_entry[bus]); unmap_vtd_domain_page(root_entry); ctxt_entry = map_vtd_domain_page(val); if ( ctxt_entry == NULL ) diff --git a/xen/drivers/passthrough/vtd/x86/ats.c b/xen/drivers/passthrough/vtd/x86/ats.c index 04d702b1d6..8369415dcc 100644 --- a/xen/drivers/passthrough/vtd/x86/ats.c +++ b/xen/drivers/passthrough/vtd/x86/ats.c @@ -74,8 +74,8 @@ int ats_device(const struct pci_dev *pdev, const struct acpi_drhd_unit *drhd) static bool device_in_domain(const struct vtd_iommu *iommu, const struct pci_dev *pdev, uint16_t did) { - struct root_entry *root_entry; - struct context_entry *ctxt_entry = NULL; + struct root_entry *root_entry, *root_entries = NULL; + struct context_entry *context_entry, *context_entries = NULL; unsigned int tt; bool found = false; @@ -85,25 +85,28 @@ static bool device_in_domain(const struct vtd_iommu *iommu, return false; } - root_entry = map_vtd_domain_page(iommu->root_maddr); - if ( !root_present(root_entry[pdev->bus]) ) + root_entries = (struct root_entry *)map_vtd_domain_page(iommu->root_maddr); + root_entry = &root_entries[pdev->bus]; + if ( !root_present(*root_entry) ) goto out; - ctxt_entry = map_vtd_domain_page(root_entry[pdev->bus].val); - if ( context_domain_id(ctxt_entry[pdev->devfn]) != did ) + context_entries = map_vtd_domain_page(root_ctp(*root_entry)); + context_entry = &context_entries[pdev->devfn]; + if ( context_domain_id(*context_entry) != did ) goto out; - tt = context_translation_type(ctxt_entry[pdev->devfn]); + tt = context_translation_type(*context_entry); if ( tt != CONTEXT_TT_DEV_IOTLB ) goto out; found = true; -out: - if ( root_entry ) - unmap_vtd_domain_page(root_entry); - if ( ctxt_entry ) - unmap_vtd_domain_page(ctxt_entry); + out: + if ( root_entries ) + unmap_vtd_domain_page(root_entries); + + if ( context_entries ) + unmap_vtd_domain_page(context_entries); return found; } -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 14:10:06 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 14:10:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xdZ-0002sl-M8; Tue, 04 Aug 2020 14:09:53 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xdY-0002sb-8N for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 14:09:52 +0000 X-Inumbo-ID: 3063303c-812f-4369-bd1a-e5783ee241cb Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3063303c-812f-4369-bd1a-e5783ee241cb; Tue, 04 Aug 2020 14:09:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=AKVB45EUCXOkdgrC6CNoKokTirVUG6f1cqctimQSqX0=; b=I9AuG1SkfAZr8sUbD0vACgKtuq 3oaXtPm1URuBFWqFxWbPZ39rnNv/6tJv8ms1v/iBhmORl++Dr/10waHWR/XtmTIIq8My4UENUr+1T NS52tIJkDUPvobIlEofy5gQPNFrF+c7dnZVDa/RxcF9AU2j2Lhiudv1sxH1SAjtI0Bi8=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xdW-0000Nb-Dl; Tue, 04 Aug 2020 14:09:50 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2xD3-0003ag-8F; Tue, 04 Aug 2020 13:42:29 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v4 13/14] vtd: use a bit field for context_entry Date: Tue, 4 Aug 2020 14:42:08 +0100 Message-Id: <20200804134209.8717-14-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200804134209.8717-1-paul@xen.org> References: <20200804134209.8717-1-paul@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Paul Durrant , Kevin Tian Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant This removes the need for much shifting, masking and several magic numbers. On the whole it makes the code quite a bit more readable. Signed-off-by: Paul Durrant --- Cc: Kevin Tian v4: - New in v4 --- xen/drivers/passthrough/vtd/iommu.c | 8 ++-- xen/drivers/passthrough/vtd/iommu.h | 65 +++++++++++++++++---------- xen/drivers/passthrough/vtd/utils.c | 6 +-- xen/drivers/passthrough/vtd/x86/ats.c | 2 +- 4 files changed, 49 insertions(+), 32 deletions(-) diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c index 76025f6ccd..766d33058e 100644 --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -86,8 +86,6 @@ static int domain_iommu_domid(struct domain *d, return -1; } -#define DID_FIELD_WIDTH 16 -#define DID_HIGH_OFFSET 8 static int context_set_domain_id(struct context_entry *context, struct domain *d, struct vtd_iommu *iommu) @@ -121,7 +119,7 @@ static int context_set_domain_id(struct context_entry *context, } set_bit(i, iommu->domid_bitmap); - context->hi |= (i & ((1 << DID_FIELD_WIDTH) - 1)) << DID_HIGH_OFFSET; + context_set_did(*context, i); return 0; } @@ -135,7 +133,7 @@ static int context_get_domain_id(struct context_entry *context, { nr_dom = cap_ndoms(iommu->cap); - dom_index = context_domain_id(*context); + dom_index = context_did(*context); if ( dom_index < nr_dom && iommu->domid_map ) domid = iommu->domid_map[dom_index]; @@ -1396,7 +1394,7 @@ int domain_context_mapping_one( return -ENOMEM; } - context_set_address_root(*context, pgd_maddr); + context_set_slptp(*context, pgd_maddr); if ( ats_enabled && ecap_dev_iotlb(iommu->ecap) ) context_set_translation_type(*context, CONTEXT_TT_DEV_IOTLB); else diff --git a/xen/drivers/passthrough/vtd/iommu.h b/xen/drivers/passthrough/vtd/iommu.h index 031ac5f66c..509d13918a 100644 --- a/xen/drivers/passthrough/vtd/iommu.h +++ b/xen/drivers/passthrough/vtd/iommu.h @@ -199,6 +199,7 @@ struct root_entry { }; }; }; +#define ROOT_ENTRY_NR (PAGE_SIZE_4K / sizeof(struct root_entry)) #define root_present(r) (r).p #define set_root_present(r) do { (r).p = 1; } while (0) @@ -208,35 +209,53 @@ struct root_entry { do { (r).ctp = ((val) >> PAGE_SHIFT_4K); } while (0) struct context_entry { - u64 lo; - u64 hi; + union { + __uint128_t val; + struct { uint64_t lo, hi; }; + struct { + /* 0 - 63 */ + uint64_t p:1; + uint64_t fpd:1; + uint64_t tt:2; + uint64_t reserved0:8; + uint64_t slptp:52; + + /* 64 - 127 */ + uint64_t aw:3; + uint64_t ignored:4; + uint64_t reserved1:1; + uint64_t did:16; + uint64_t reserved2:40; + }; + }; }; -#define ROOT_ENTRY_NR (PAGE_SIZE_4K/sizeof(struct root_entry)) -#define context_present(c) ((c).lo & 1) -#define context_fault_disable(c) (((c).lo >> 1) & 1) -#define context_translation_type(c) (((c).lo >> 2) & 3) -#define context_address_root(c) ((c).lo & PAGE_MASK_4K) -#define context_address_width(c) ((c).hi & 7) -#define context_domain_id(c) (((c).hi >> 8) & ((1 << 16) - 1)) - -#define context_set_present(c) do {(c).lo |= 1;} while(0) -#define context_clear_present(c) do {(c).lo &= ~1;} while(0) -#define context_set_fault_enable(c) \ - do {(c).lo &= (((u64)-1) << 2) | 1;} while(0) - -#define context_set_translation_type(c, val) do { \ - (c).lo &= (((u64)-1) << 4) | 3; \ - (c).lo |= (val & 3) << 2; \ - } while(0) + +#define context_present(c) (c).p +#define context_set_present(c) do { (c).p = 1; } while (0) +#define context_clear_present(c) do { (c).p = 0; } while (0) + +#define context_fault_disable(c) (c).fpd +#define context_set_fault_enable(c) do { (c).fpd = 1; } while (0) + +#define context_translation_type(c) (c).tt +#define context_set_translation_type(c, val) do { (c).tt = val; } while (0) #define CONTEXT_TT_MULTI_LEVEL 0 #define CONTEXT_TT_DEV_IOTLB 1 #define CONTEXT_TT_PASS_THRU 2 -#define context_set_address_root(c, val) \ - do {(c).lo &= 0xfff; (c).lo |= (val) & PAGE_MASK_4K ;} while(0) +#define context_slptp(c) ((c).slptp << PAGE_SHIFT_4K) +#define context_set_slptp(c, val) \ + do { (c).slptp = (val) >> PAGE_SHIFT_4K; } while (0) + +#define context_address_width(c) (c).aw #define context_set_address_width(c, val) \ - do {(c).hi &= 0xfffffff8; (c).hi |= (val) & 7;} while(0) -#define context_clear_entry(c) do {(c).lo = 0; (c).hi = 0;} while(0) + do { (c).aw = (val); } while (0) + +#define context_did(c) (c).did +#define context_set_did(c, val) \ + do { (c).did = (val); } while (0) + +#define context_clear_entry(c) do { (c).val = 0; } while (0) /* page table handling */ #define LEVEL_STRIDE (9) diff --git a/xen/drivers/passthrough/vtd/utils.c b/xen/drivers/passthrough/vtd/utils.c index 4c85242894..eae0c43269 100644 --- a/xen/drivers/passthrough/vtd/utils.c +++ b/xen/drivers/passthrough/vtd/utils.c @@ -129,9 +129,8 @@ void print_vtd_entries(struct vtd_iommu *iommu, int bus, int devfn, u64 gmfn) return; } - val = ctxt_entry[devfn].lo; - printk(" context[%02x] = %"PRIx64"_%"PRIx64"\n", - devfn, ctxt_entry[devfn].hi, val); + printk(" context[%02x] = %"PRIx64"_%"PRIx64"\n", devfn, + ctxt_entry[devfn].hi, ctxt_entry[devfn].lo); if ( !context_present(ctxt_entry[devfn]) ) { unmap_vtd_domain_page(ctxt_entry); @@ -140,6 +139,7 @@ void print_vtd_entries(struct vtd_iommu *iommu, int bus, int devfn, u64 gmfn) } level = agaw_to_level(context_address_width(ctxt_entry[devfn])); + val = context_slptp(ctxt_entry[devfn]); unmap_vtd_domain_page(ctxt_entry); if ( level != VTD_PAGE_TABLE_LEVEL_3 && level != VTD_PAGE_TABLE_LEVEL_4) diff --git a/xen/drivers/passthrough/vtd/x86/ats.c b/xen/drivers/passthrough/vtd/x86/ats.c index 8369415dcc..a7bbd3198a 100644 --- a/xen/drivers/passthrough/vtd/x86/ats.c +++ b/xen/drivers/passthrough/vtd/x86/ats.c @@ -92,7 +92,7 @@ static bool device_in_domain(const struct vtd_iommu *iommu, context_entries = map_vtd_domain_page(root_ctp(*root_entry)); context_entry = &context_entries[pdev->devfn]; - if ( context_domain_id(*context_entry) != did ) + if ( context_did(*context_entry) != did ) goto out; tt = context_translation_type(*context_entry); -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 14:16:50 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 14:16:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xkC-00048E-M9; Tue, 04 Aug 2020 14:16:44 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xkB-000489-Sz for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 14:16:43 +0000 X-Inumbo-ID: ffc58760-1966-421c-a441-c030c16ff223 Received: from mail-wm1-f67.google.com (unknown [209.85.128.67]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ffc58760-1966-421c-a441-c030c16ff223; Tue, 04 Aug 2020 14:16:43 +0000 (UTC) Received: by mail-wm1-f67.google.com with SMTP id g8so2841201wmk.3 for ; Tue, 04 Aug 2020 07:16:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=k1GAM4yGJRVX+IjsFYQxKWWU3oYsEc17L61GHIF+wPc=; b=dzqdjaIaVukJ9mEf3FISK6L68tFyRT77cE9cvzWKRIqkuf+7rbRgFvZltA6a+zxCeM /SGHAmL+TSbEWnMF8tWJe1Rw9mzaEhHboZA7m8/95RMtw5pLlQpVAvcC53YNPrt6qARJ K1aV9UP3Rosanm7e2yPOnPubZk/vLjBKcGlDsplA99lwe9HvcRmACIFgh960DRDLVZSG IH3O52EUZNxbI7x1hw7QeIPDiy+vOYLrIazRJ0Wquv31vcQFqWxdHkpTjG6zxF1AjdZt w8dIdyRGVGaScq8FJWlcgOj0LoO2m/Uv0pysed2bs7rcuJ87vFDP8440DTU+UE8lJDwQ 3QhA== X-Gm-Message-State: AOAM530CfjGVHksy1Kg50Am7JREVqjAXJeNWv8crZEJM8RgnJAsBhcuR km66dZetJwkmiwpVFvLjISY= X-Google-Smtp-Source: ABdhPJwpr7tdJnbqlY4UQNBXiNrVbK4mSkw2DiB9ytf+3KXHekG/PpYkiWxNsQqWzjLgBuaSa7yvcw== X-Received: by 2002:a1c:dc8b:: with SMTP id t133mr4189443wmg.148.1596550602310; Tue, 04 Aug 2020 07:16:42 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id c14sm30601284wrw.85.2020.08.04.07.16.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2020 07:16:41 -0700 (PDT) Date: Tue, 4 Aug 2020 14:16:39 +0000 From: Wei Liu To: Jan Beulich Subject: Re: [PATCH] libxl: avoid golang building without CONFIG_GOLANG=y Message-ID: <20200804141639.k2tpoqy7jj34gcm6@liuwe-devbox-debian-v2> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony Perard , "xen-devel@lists.xenproject.org" , Ian Jackson , George Dunlap , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Mon, Aug 03, 2020 at 10:06:32AM +0200, Jan Beulich wrote: > While this doesn't address the real problem I've run into (attempting to > update r/o source files), not recursing into tools/golang/xenlight/ is > enough to fix the build for me for the moment. I don't currently see why > 60db5da62ac0 ("libxl: Generate golang bindings in libxl Makefile") found > it necessary to invoke this build step unconditionally. > Perhaps an oversight? > Signed-off-by: Jan Beulich Acked-by: Wei Liu > --- > I'm also having trouble to see why, besides the idl-gen target in > tools/golang/xenlight/Makefile, the commit also adds such a target to > (and mentions it in [only] a comment in) tools/libxl/Makefile. > > --- a/tools/libxl/Makefile > +++ b/tools/libxl/Makefile > @@ -282,7 +282,9 @@ _libxl_type%.h _libxl_type%_json.h _libx > # about races with tools/golang/xenlight/Makefile:all > .PHONY: idl-external > idl-external: > +ifeq ($(CONFIG_GOLANG),y) > $(MAKE) -C $(XEN_ROOT)/tools/golang/xenlight idl-gen > +endif > > LIBXL_IDLGEN_FILES = _libxl_types.h _libxl_types_json.h _libxl_types_private.h _libxl_types.c \ > _libxl_types_internal.h _libxl_types_internal_json.h _libxl_types_internal_private.h _libxl_types_internal.c From xen-devel-bounces@lists.xenproject.org Tue Aug 04 14:29:40 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 14:29:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xwb-00055t-Sa; Tue, 04 Aug 2020 14:29:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2xwa-00055o-Nm for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 14:29:32 +0000 X-Inumbo-ID: 1cafba08-b793-41f6-aaca-1a48390beab4 Received: from mail-wr1-f67.google.com (unknown [209.85.221.67]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1cafba08-b793-41f6-aaca-1a48390beab4; Tue, 04 Aug 2020 14:29:31 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id a5so27647740wrm.6 for ; Tue, 04 Aug 2020 07:29:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=mYMQB7mHofMy/iv+wAwdLHYSBZ2zh1IlGeawKmZRVq8=; b=C44aj/r7XOyUYbks6ByBNfpY77hXeaCraU/oMYVwmVElTc97s4FmsDAnUI7xs+21nX zmGipLu720ln5PBTeSdkbP9+7xol0EwC2IgNGpHbdGb6g/SiPPRExwK0Qex5/znF9YDn 1k0ljaAFLyQhmqDPWXv1v60LqOe8PZZKstZIOJHFWLEHx9TFye61+Ami+JfwJiNLDxV1 PykC9T/JQrzYlqczaDTI2UWj7bWaFKxuC4FfJuDKt7LUNpiuKs6qvLNGlOTLNUULsFf+ jaljiwMQ4EPifKLuNMJMuC410ygoy1XGlqEImKNtinr3N5nc5WRaBYNqag0JR4TmfCPm hbtA== X-Gm-Message-State: AOAM5330EXkHif8TM0JcHC0g/CMoQJ/vBR8N/sUmY6fFtFi9IxNCmC/q JZzvkHHIm7f8btRX4ZKimvU= X-Google-Smtp-Source: ABdhPJxP5BFIi+jzViOmDltZ0TpM950BHhYSUJof95hSw+vr1joSQ3PCJt4vRbeLChM6hH4ntSuK0Q== X-Received: by 2002:adf:b1cf:: with SMTP id r15mr21255479wra.118.1596551371130; Tue, 04 Aug 2020 07:29:31 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id 111sm31265608wrc.53.2020.08.04.07.29.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2020 07:29:29 -0700 (PDT) Date: Tue, 4 Aug 2020 14:29:28 +0000 From: Wei Liu To: Andrew Cooper Subject: Re: [PATCH 5/5] tools/foreignmem: Support querying the size of a resource Message-ID: <20200804142928.z6rpby4zydzu5jqn@liuwe-devbox-debian-v2> References: <20200728113712.22966-1-andrew.cooper3@citrix.com> <20200728113712.22966-6-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Hubert Jasudowicz , Wei Liu , Paul Durrant , =?utf-8?Q?Micha=C5=82_Leszczy=C5=84ski?= , Ian Jackson , Xen-devel Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Tue, Jul 28, 2020 at 03:14:39PM +0100, Andrew Cooper wrote: > On 28/07/2020 12:37, Andrew Cooper wrote: > > With the Xen side of this interface fixed to return real sizes, userspace > > needs to be able to make the query. > > > > Introduce xenforeignmemory_resource_size() for the purpose, bumping the > > library minor version and providing compatiblity for the non-Linux builds. > > > > Its not possible to reuse the IOCTL_PRIVCMD_MMAP_RESOURCE infrastructure, > > because it depends on having already mmap()'d a suitably sized region before > > it will make an XENMEM_acquire_resource hypercall to Xen. > > > > Instead, open a xencall handle and make an XENMEM_acquire_resource hypercall > > directly. > > > > Signed-off-by: Andrew Cooper > > --- > > CC: Ian Jackson > > CC: Wei Liu > > CC: Paul Durrant > > CC: Michał Leszczyński > > CC: Hubert Jasudowicz > > I've folded: > > diff --git a/tools/Rules.mk b/tools/Rules.mk > index 5ed5664bf7..b8ccf03ea9 100644 > --- a/tools/Rules.mk > +++ b/tools/Rules.mk > @@ -123,7 +123,7 @@ LDLIBS_libxencall = $(SHDEPS_libxencall) > $(XEN_LIBXENCALL)/libxencall$(libextens >  SHLIB_libxencall  = $(SHDEPS_libxencall) -Wl,-rpath-link=$(XEN_LIBXENCALL) >   >  CFLAGS_libxenforeignmemory = -I$(XEN_LIBXENFOREIGNMEMORY)/include > $(CFLAGS_xeninclude) > -SHDEPS_libxenforeignmemory = $(SHLIB_libxentoolcore) > +SHDEPS_libxenforeignmemory = $(SHLIB_libxentoolcore) $(SHDEPS_libxencall) >  LDLIBS_libxenforeignmemory = $(SHDEPS_libxenforeignmemory) > $(XEN_LIBXENFOREIGNMEMORY)/libxenforeignmemory$(libextension) >  SHLIB_libxenforeignmemory  = $(SHDEPS_libxenforeignmemory) > -Wl,-rpath-link=$(XEN_LIBXENFOREIGNMEMORY) >   > diff --git a/tools/libs/foreignmemory/Makefile > b/tools/libs/foreignmemory/Makefile > index 8e07f92c59..f3a61e27c7 100644 > --- a/tools/libs/foreignmemory/Makefile > +++ b/tools/libs/foreignmemory/Makefile > @@ -4,7 +4,7 @@ include $(XEN_ROOT)/tools/Rules.mk >  MAJOR    = 1 >  MINOR    = 4 >  LIBNAME  := foreignmemory > -USELIBS  := toollog toolcore > +USELIBS  := toollog toolcore call >   >  SRCS-y                 += core.c >  SRCS-$(CONFIG_Linux)   += linux.c > > to fix the build in certain containers. Acked-by: Wei Liu From xen-devel-bounces@lists.xenproject.org Tue Aug 04 14:46:30 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 14:46:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2yCs-0006nL-Ay; Tue, 04 Aug 2020 14:46:22 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2yCq-0006nG-Ki for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 14:46:20 +0000 X-Inumbo-ID: 58a3ea34-5590-469c-92f7-2325a1158269 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 58a3ea34-5590-469c-92f7-2325a1158269; Tue, 04 Aug 2020 14:46:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596552379; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=Nq19iTNJmoNA2xjrkYq5ivLgI2YhtNvzGmirNBmBNso=; b=fJkEx+PsQ43Y/v1Pjd/yc3Fm8PBUL08fft4bjm6ufihMZCTAPnnBXPSA xk5DhnzRYr/Riv5ojbI59ZPNDOwJh9g34QhuQTORDUmW8eMknh7OdfKYd mjBsHPD8p9wimc89WZ5p26dUS5xyuv7o6AM/JH4R3CEX/0pPcIHoT/IDG Y=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: beRNKA3wdJ5hUdlqiUrNMXJuSmfctF21FctbsPOZor/2dTnkJFl39VCUnyFmuYVuDS8fJP6etC Usiv4Gz3wF+ovQV6ZjWqznQkoHgC73nubS2qOAYx7QCqH83Q81Pt5q871MgY4IUqZ5nGkHTf3R FDNrrzgJ2mGTv6tmrFX6QR0Bmagtoo1NE4L0lyq1nFCiaMKhXZQOUMi/48fuUDzVhrWbu8vpyL Rh7PTEO5Wks5Zij9aYxnTGGoxVTTOqI1i3qbLmUK6OPJ8pJv4uWEE29kiGiAB05neAk9HGldJS B+0= X-SBRS: 3.7 X-MesageID: 23809598 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,434,1589256000"; d="scan'208";a="23809598" Subject: Re: [PATCH] x86emul: further FPU env testing relaxation for AMD-like CPUs To: Jan Beulich , "xen-devel@lists.xenproject.org" References: From: Andrew Cooper Message-ID: <91e628c6-cbbc-2023-51be-674de4901704@citrix.com> Date: Tue, 4 Aug 2020 15:46:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 04/08/2020 10:36, Jan Beulich wrote: > See the code comment that's being extended. Additionally a few more > zap_fpsel() invocations are needed - whenever we stored state after > there potentially having been a context switch behind our backs. > > Reported-by: Andrew Cooper > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper Tested-by: Andrew Cooper > > --- a/tools/tests/x86_emulator/test_x86_emulator.c > +++ b/tools/tests/x86_emulator/test_x86_emulator.c > @@ -752,6 +752,13 @@ static struct x86_emulate_ops emulops = > * 64-bit OSes may not (be able to) properly restore the two selectors in > * the FPU environment. Zap them so that memcmp() on two saved images will > * work regardless of whether a context switch occurred in the middle. > + * > + * Additionally on AMD-like CPUs FDP/FIP/FOP may get lost across context > + * switches, when there's no unmasked pending FP exception: With I think you want a full stop rather than a colon, and ... > + * CPUID[80000008].EBX[2] clear, the fields don't get written/read by > + * {F,}XSAVE / {F,}XRSTOR, which OSes often compensate for by invoking an > + * insn forcing the fields to gain a deterministic value. Whereas with said ... a comma here rather than a full stop. Having "whereas" at the beginning of a sentence like this is weird, given that you're contrasting the behaviour of the CPUID bit. Also, the more usual CPUID syntax would be CPUID.0x80000008.EBX[2]. ~Andrew > + * bit set, zeroes will get written (and hence later restored). > */ > static void zap_fpsel(unsigned int *env, bool is_32bit) > { > From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:00:29 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 15:00:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2yQP-0008VZ-Ph; Tue, 04 Aug 2020 15:00:21 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2yQP-0008VU-4w for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 15:00:21 +0000 X-Inumbo-ID: ef5fadc4-4bba-468c-bea2-51884dd8007a Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ef5fadc4-4bba-468c-bea2-51884dd8007a; Tue, 04 Aug 2020 15:00:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596553220; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=zwI3V060M/+vMgnPet7K7MC8n3DXrk47Ov37cF5uQO4=; b=ZeC9g0fRlgVZ2xoV+9FEcPe6480z/vun9HBnCa5sgNK7TSX2z/hJ1ucn FUl11UCUGmMojnBH4ED9CZ2C7wjQ8gV3iAMjNBXqXitEhps+LipPG5hqp UUvOAZg/JH+kLiuhxeO98jPDXVwH29lkSJe6+/Pq1GayeGUcIVEynmOHa Y=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: ss79eXD16EMThyJMkPQ+Kjxnq4Tn0puUppM72GVsw/gxfUVNfW647jWQEuooJPFLtWfAwvhBt8 Hrh0cvVxp9Iq+fTaid0t7BXHi6KMwhVkM9tHXW44gNjoIkRdQTOZ/ZM6QYYGEPRSfIPFoAd8M1 SGgsBI6mGmcsTz945qiAhkHMNyyS4yLfOxwdjjMTQyrx/0hgiu12hP8a9hFL7FRNg99eIeaMBF dxJ7F9D3jnzfS3qb9kl3h8fHyKB2AQOXu0HIpL+OvUgBIv5i/FKkFi0anl9/RH7Mqs7a+kf8BW sTk= X-SBRS: 3.7 X-MesageID: 24156014 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,434,1589256000"; d="scan'208";a="24156014" Subject: Re: [PATCH 00/10] x86emul: full coverage mem access / write testing To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <97ca3d9c-7540-c7b1-cf84-34c75c9127df@suse.com> From: Andrew Cooper Message-ID: <9d401ca1-e09f-48f7-dbda-3c6914577ef2@citrix.com> Date: Tue, 4 Aug 2020 15:59:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <97ca3d9c-7540-c7b1-cf84-34c75c9127df@suse.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 03/08/2020 15:47, Jan Beulich wrote: > ... and a few fixes resulting from this work. This completes what > was started for legacy encoded GPR insns in a rush before 4.14. > > There's one thing I'm still planning on top of both this and the > EVEX-disp8 checking: For all encodings we produce via general > logic (and in particular without involvement of any assembler) I'd > like to add a kind of logging mechanism, the output of which could > be fed to gas and then some disassembler, to allow verification > that the produced encodings are actually valid ones. See e.g. the > first patch here or commit 5f55389d6960 - the problems addressed > there could have been caught earlier if the generated encodings > could be easily disassembled. What's not clear to me here is > whether this is deemed generally useful, or whether I should make > this a private addition of mine. > > 01: adjustments to mem access / write logic testing > 02: extend decoding / mem access testing to FPU insns > 03: extend decoding / mem access testing to MMX / SSE insns > 04: extend decoding / mem access testing to VEX-encoded insns > 05: extend decoding / mem access testing to XOP-encoded insns > 06: AVX512{F,BW} down conversion moves are memory writes > 07: AVX512F scatter insns are memory writes > 08: AVX512PF insns aren't memory accesses > 09: extend decoding / mem access testing to EVEX-encoded insns > 10: correct AVX512_BF16 insn names in EVEX Disp8 test Acked-by: Andrew Cooper Ideally with the commit message for patch 3 adjusted. From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:23:34 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 15:23:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2ymV-0001qh-Go; Tue, 04 Aug 2020 15:23:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2ymU-0001qc-0l for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 15:23:10 +0000 X-Inumbo-ID: 7cd5a37a-9832-4763-ad9f-575c619145a4 Received: from mail-lj1-x243.google.com (unknown [2a00:1450:4864:20::243]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7cd5a37a-9832-4763-ad9f-575c619145a4; Tue, 04 Aug 2020 15:23:09 +0000 (UTC) Received: by mail-lj1-x243.google.com with SMTP id w25so8588413ljo.12 for ; Tue, 04 Aug 2020 08:23:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=30N5ObjJG57l4nH4ZLUzGYro785BrKf9hzlM1FImspk=; b=aLUIht1Y27iWOfNH0+ZuslP5EITbZil/6eb3hhIxKlJ3sNXYh2NZ3LJ6ILF1j3SstB cJexR2bmSb0a1t1EHriMMZ63h7+WpJs40bXG7nRmfUxzHdzdqqov8SgeTLDor+vXU5CL fUd2enFo4sHa0mi6BeCqx+BDrL7aQYErkUKfNEG2BaCCKiPfWWfgXH3Vgz/40AgmTpZV HNdLIk3fneVtTIffLlQ8ww6Wuhx7fsXcUZlGnSzg6HOb+kPQCPG4OMhVIQ88a4G6aiaN oKWrJMLiyNvRvtidy1dyaBJ1m5TwzfEt4aagkBF6hZ3KEp1eEPbAr4YH0BIWc4Vrjg42 V76w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=30N5ObjJG57l4nH4ZLUzGYro785BrKf9hzlM1FImspk=; b=M8/UgXkCsLQClCzG7O3F3SKKWdOYDwWnnhMb70qzWVOpXTSb2l4Ut2RXBVDW8QlAVg t/vtWwUCbIKPCicYNd8I3poEx1vzKXygSu808GQGrsrM3J+WGJgoaIGM8HQao/ieQpR8 WebndTGjDxx48srj/jqGrpbZASoxMH4QzfD0lR9nEELlWYBE/f3wDh8kz1voSJro9//A d6Wr2r1OlNwXFCxSENab8kZDb+AAbm9GDtz34cF9kj0qhyL8X0laEMHLApiDEsKlde6t 3wIhrjPDPoodN4YocYIGEAwDoFlkrsTCTgHcasjnocxfBJ+l5V79WVaJdCMWvr2gFS8L aj5A== X-Gm-Message-State: AOAM533Xvh2n4VQQugPoyHoj6F3CzMRpp7hzeDqykdGonseTxp21tKpy o0jqMgad+txZF0fJctiUIMSNTyrmAtkNv8abXEY= X-Google-Smtp-Source: ABdhPJwNIGpZXpDiGsloe0h9d1QKrJuFcdXD8xikVuvEtSJbEeo3a0UrSU3HUBHP5x6yRPr63BdBBsPyquKyg9HoBWE= X-Received: by 2002:a05:651c:2044:: with SMTP id t4mr4725732ljo.420.1596554587907; Tue, 04 Aug 2020 08:23:07 -0700 (PDT) MIME-Version: 1.0 References: <20200804141639.k2tpoqy7jj34gcm6@liuwe-devbox-debian-v2> In-Reply-To: <20200804141639.k2tpoqy7jj34gcm6@liuwe-devbox-debian-v2> From: Nick Rosbrook Date: Tue, 4 Aug 2020 11:22:56 -0400 Message-ID: Subject: Re: [PATCH] libxl: avoid golang building without CONFIG_GOLANG=y To: Wei Liu Content-Type: text/plain; charset="UTF-8" X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony Perard , "xen-devel@lists.xenproject.org" , Ian Jackson , George Dunlap , Jan Beulich Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Tue, Aug 4, 2020 at 10:17 AM Wei Liu wrote: > > On Mon, Aug 03, 2020 at 10:06:32AM +0200, Jan Beulich wrote: > > While this doesn't address the real problem I've run into (attempting to > > update r/o source files), not recursing into tools/golang/xenlight/ is > > enough to fix the build for me for the moment. I don't currently see why > > 60db5da62ac0 ("libxl: Generate golang bindings in libxl Makefile") found > > it necessary to invoke this build step unconditionally. > > > > Perhaps an oversight? This is intentional, and I think the commit message in 60db5da62ac0 ("libxl: Generate golang bindings in libxl Makefile") explains the reasoning well. But, to summarize, CONFIG_GOLANG is only used to control the bindings actually being compiled (i.e. with `go build`). However, we always want the code generation script (tools/golang/xenlight/gengotypes.py) to run if e.g. tools/libxl/libxl_types.idl is modified. I hope this helps. -NR From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:26:04 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 15:26:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2ypI-0001zo-1i; Tue, 04 Aug 2020 15:26:04 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2ypG-0001zj-Sh for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 15:26:02 +0000 X-Inumbo-ID: 7e0f829e-1eb2-4ce4-a626-014105533bb1 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7e0f829e-1eb2-4ce4-a626-014105533bb1; Tue, 04 Aug 2020 15:26:02 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3F62FAF4C; Tue, 4 Aug 2020 15:26:17 +0000 (UTC) To: "xen-devel@lists.xenproject.org" From: Jan Beulich Subject: [PATCH] x86: comment update after "drop high compat r/o M2P table address range" Message-ID: Date: Tue, 4 Aug 2020 17:26:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Commit 5af040ef8b57 clearly should also have updated the comment, not just the #define-s. Signed-off-by: Jan Beulich --- a/xen/include/asm-x86/config.h +++ b/xen/include/asm-x86/config.h @@ -144,18 +144,16 @@ extern unsigned char boot_edid_info[128] * 0xffff82d000000000 - 0xffff82d03fffffff [1GB, 2^30 bytes, PML4:261] * Compatibility machine-to-phys translation table. * 0xffff82d040000000 - 0xffff82d07fffffff [1GB, 2^30 bytes, PML4:261] - * High read-only compatibility machine-to-phys translation table. - * 0xffff82d080000000 - 0xffff82d0bfffffff [1GB, 2^30 bytes, PML4:261] * Xen text, static data, bss. #ifndef CONFIG_BIGMEM - * 0xffff82d0c0000000 - 0xffff82dfffffffff [61GB, PML4:261] + * 0xffff82d080000000 - 0xffff82dfffffffff [62GB, PML4:261] * Reserved for future use. * 0xffff82e000000000 - 0xffff82ffffffffff [128GB, 2^37 bytes, PML4:261] * Page-frame information array. * 0xffff830000000000 - 0xffff87ffffffffff [5TB, 5*2^40 bytes, PML4:262-271] * 1:1 direct mapping of all physical memory. #else - * 0xffff82d0c0000000 - 0xffff82ffffffffff [189GB, PML4:261] + * 0xffff82d080000000 - 0xffff82ffffffffff [190GB, PML4:261] * Reserved for future use. * 0xffff830000000000 - 0xffff847fffffffff [1.5TB, 3*2^39 bytes, PML4:262-264] * Page-frame information array. From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:30:49 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 15:30:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2yto-0002op-ME; Tue, 04 Aug 2020 15:30:44 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2ytn-0002ok-BH for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 15:30:43 +0000 X-Inumbo-ID: e7fafa4a-965e-468e-97bc-fd1747f3410c Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e7fafa4a-965e-468e-97bc-fd1747f3410c; Tue, 04 Aug 2020 15:30:41 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 86F16B675; Tue, 4 Aug 2020 15:30:56 +0000 (UTC) Subject: Re: [PATCH] libxl: avoid golang building without CONFIG_GOLANG=y To: Nick Rosbrook References: <20200804141639.k2tpoqy7jj34gcm6@liuwe-devbox-debian-v2> From: Jan Beulich Message-ID: <0deed4c6-ca87-09d3-a19c-ac0c00003cb7@suse.com> Date: Tue, 4 Aug 2020 17:30:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony Perard , "xen-devel@lists.xenproject.org" , Ian Jackson , George Dunlap , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 04.08.2020 17:22, Nick Rosbrook wrote: > On Tue, Aug 4, 2020 at 10:17 AM Wei Liu wrote: >> >> On Mon, Aug 03, 2020 at 10:06:32AM +0200, Jan Beulich wrote: >>> While this doesn't address the real problem I've run into (attempting to >>> update r/o source files), not recursing into tools/golang/xenlight/ is >>> enough to fix the build for me for the moment. I don't currently see why >>> 60db5da62ac0 ("libxl: Generate golang bindings in libxl Makefile") found >>> it necessary to invoke this build step unconditionally. >>> >> >> Perhaps an oversight? > > This is intentional, and I think the commit message in 60db5da62ac0 > ("libxl: Generate golang bindings in libxl Makefile") explains the > reasoning well. But, to summarize, CONFIG_GOLANG is only used to > control the bindings actually being compiled (i.e. with `go build`). > However, we always want the code generation script > (tools/golang/xenlight/gengotypes.py) to run if e.g. > tools/libxl/libxl_types.idl is modified. > > I hope this helps. Not really - I'm still not seeing the "why" behind this behavior. I.e. why build _anything_ that's not used further in the build, nor getting installed? Also if (aiui) you effectively object to the change that Wei has given his ack for, would you mind providing an alternative fix for the problem at hand? Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:40:22 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 15:40:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2z2z-0003jI-Lb; Tue, 04 Aug 2020 15:40:13 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2z2y-0003jD-F2 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 15:40:12 +0000 X-Inumbo-ID: ff6a0919-44a6-472d-8fd2-69a38907b509 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ff6a0919-44a6-472d-8fd2-69a38907b509; Tue, 04 Aug 2020 15:40:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596555611; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=oQU5z3p7u0qO2HONNSAn7MeYJ5u5tE1n/orWWBGSqVU=; b=atDLpBiUYOsn8EA+FoXQ1qEE4422Wd4YnAfd7EYZRWT4v588ouJxcciW SneJAAQsLlxp6eRkxB1wW5RaCaG/Eo1WqBySe1aFnA7YwSR4mcgDt4eW5 8wy1lT3CSTwubZ5LIAQehS+jGGo+G3OPNTtpQi4Qd3bYAxMMBtlZgMw2b s=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: WqSUKr43m+OwbMAfG/BV0p7AQBg783iTtV2hTgUZnQ6iAavQKGP6qwHIgNRfilR5Rp6dhMQhqV FACGJ9PgibiAKk4mpZYh7J1ze8NHc7w5kqVVVSZcLipjojkuo6YAeuxlU4/MTPXHLUSE0jat0k vmrRUkdYjcS6zalSr+Vhxt/JFx0Ymxk4YyDYX9jPCgegVL35xVuGqzhZJtFQfE6b34aLkSMNk2 5/l0FwkkLJJSEyh9/XR0sDtpWfFrWn2Kox/xKmuJ3cDiBoa4aunTWYgnZzy541gLjPjW1PRmWR v+A= X-SBRS: 3.7 X-MesageID: 23814667 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,434,1589256000"; d="scan'208";a="23814667" Subject: Re: [PATCH] x86: comment update after "drop high compat r/o M2P table address range" To: Jan Beulich , "xen-devel@lists.xenproject.org" References: From: Andrew Cooper Message-ID: <24bb58fa-9671-3ae1-8aad-47ab296c4a62@citrix.com> Date: Tue, 4 Aug 2020 16:40:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 04/08/2020 16:26, Jan Beulich wrote: > Commit 5af040ef8b57 clearly should also have updated the comment, not > just the #define-s. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:42:00 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 15:42:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2z4i-0003pO-1O; Tue, 04 Aug 2020 15:42:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2z4g-0003pF-J4 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 15:41:58 +0000 X-Inumbo-ID: d41fc4ad-5b12-4d88-b393-3257ce407432 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d41fc4ad-5b12-4d88-b393-3257ce407432; Tue, 04 Aug 2020 15:41:57 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F0C02ACB7; Tue, 4 Aug 2020 15:42:12 +0000 (UTC) Subject: Re: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common To: Julien Grall References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-2-git-send-email-olekstysh@gmail.com> <000c01d66a33$2bd56510$83802f30$@xen.org> <9f83a7ed-ca97-449f-c7b9-a1140644abe9@gmail.com> From: Jan Beulich Message-ID: <34907525-1f6e-5413-1017-51cefe0dfcbc@suse.com> Date: Tue, 4 Aug 2020 17:41:56 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: 'Kevin Tian' , 'Stefano Stabellini' , 'Wei Liu' , paul@xen.org, 'Andrew Cooper' , 'Ian Jackson' , 'George Dunlap' , 'Tim Deegan' , Oleksandr , 'Oleksandr Tyshchenko' , 'Julien Grall' , 'Jun Nakajima' , xen-devel@lists.xenproject.org, =?UTF-8?B?J1JvZ2VyIFBhdSBNb25uw6kn?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 04.08.2020 15:52, Julien Grall wrote: > On 04/08/2020 12:10, Oleksandr wrote: >> On 04.08.20 10:45, Paul Durrant wrote: >>>> +static inline bool hvm_ioreq_needs_completion(const ioreq_t *ioreq) >>>> +{ >>>> +    return ioreq->state == STATE_IOREQ_READY && >>>> +           !ioreq->data_is_ptr && >>>> +           (ioreq->type != IOREQ_TYPE_PIO || ioreq->dir != >>>> IOREQ_WRITE); >>>> +} >>> I don't think having this in common code is correct. The short-cut of >>> not completing PIO reads seems somewhat x86 specific. > > Hmmm, looking at the code, I think it doesn't wait for PIO writes to > complete (not read). Did I miss anything? The point of the check isn't to determine whether to wait, but what to do after having waited. Reads need a retry round through the emulator (to store the result in the designated place), while writes don't have such a requirement (and hence guest execution can continue immediately in the general case). Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:50:53 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 15:50:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2zDF-0004kU-4d; Tue, 04 Aug 2020 15:50:49 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2zDE-0004kJ-Ln for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 15:50:48 +0000 X-Inumbo-ID: e3b9ef3c-a254-46b5-bbbd-726a425dbd82 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e3b9ef3c-a254-46b5-bbbd-726a425dbd82; Tue, 04 Aug 2020 15:50:46 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DE8FEAE9D; Tue, 4 Aug 2020 15:51:01 +0000 (UTC) Subject: Re: [PATCH] x86emul: further FPU env testing relaxation for AMD-like CPUs To: Andrew Cooper References: <91e628c6-cbbc-2023-51be-674de4901704@citrix.com> From: Jan Beulich Message-ID: <84af154e-c2b9-a6da-f8ee-8acafdd02dff@suse.com> Date: Tue, 4 Aug 2020 17:50:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <91e628c6-cbbc-2023-51be-674de4901704@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 04.08.2020 16:46, Andrew Cooper wrote: > On 04/08/2020 10:36, Jan Beulich wrote: >> See the code comment that's being extended. Additionally a few more >> zap_fpsel() invocations are needed - whenever we stored state after >> there potentially having been a context switch behind our backs. >> >> Reported-by: Andrew Cooper >> Signed-off-by: Jan Beulich > > Acked-by: Andrew Cooper > Tested-by: Andrew Cooper Thanks. >> --- a/tools/tests/x86_emulator/test_x86_emulator.c >> +++ b/tools/tests/x86_emulator/test_x86_emulator.c >> @@ -752,6 +752,13 @@ static struct x86_emulate_ops emulops = >> * 64-bit OSes may not (be able to) properly restore the two selectors in >> * the FPU environment. Zap them so that memcmp() on two saved images will >> * work regardless of whether a context switch occurred in the middle. >> + * >> + * Additionally on AMD-like CPUs FDP/FIP/FOP may get lost across context >> + * switches, when there's no unmasked pending FP exception: With > > I think you want a full stop rather than a colon, and ... I'd prefer to stick to the colon here, while ... >> + * CPUID[80000008].EBX[2] clear, the fields don't get written/read by >> + * {F,}XSAVE / {F,}XRSTOR, which OSes often compensate for by invoking an >> + * insn forcing the fields to gain a deterministic value. Whereas with said > > ... a comma here rather than a full stop. > > Having "whereas" at the beginning of a sentence like this is weird, > given that you're contrasting the behaviour of the CPUID bit. > > Also, the more usual CPUID syntax would be CPUID.0x80000008.EBX[2]. ... I've adjusted these. Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:50:53 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 15:50:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2zDE-0004kO-Sf; Tue, 04 Aug 2020 15:50:48 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2zDD-0004kD-Hi for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 15:50:47 +0000 X-Inumbo-ID: 3957bb7d-4e80-46ef-b4d4-924741db5f8f Received: from mail-wr1-f67.google.com (unknown [209.85.221.67]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3957bb7d-4e80-46ef-b4d4-924741db5f8f; Tue, 04 Aug 2020 15:50:46 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id c15so1658336wrs.11 for ; Tue, 04 Aug 2020 08:50:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6XBMq2OUK/ORpEVxRNpgI9GI/0wcOHymaMOtJI3tPKA=; b=fQb43r+i/RfpXyLIMvst09+jVfsqm03jPk+WeEj5yOEpeXMFrDAoFeRysGKhZ74/TV 8ywuXItfXe0tRE4TmQkHZ+q31AICl6f2HOcDELs9uu5F2AScgvd4Agaycj9EvAYxMGqe GpM6nuQFACmS5tNocisns3KxUquBT/T5RDLw1VKSgUPHBMxbF25qa1DzXwKQ6HyyTBPK 8/DFP7F7/owwSbHEqy3AwaHfvIzp+4SxdcRIrfRRdZpJKZ7WOAykoZ5JqYgrZ0v8PRR2 QIMjiosuDf4KotQOX0FcvOjGuFxr7W+q/TSby9CdNgCa044FZ2kXhTisb9mhrCLF6mBM VWrQ== X-Gm-Message-State: AOAM530x8mdYLvF32hC6yax2O6lz4xF8PuDY3zoVFMMGuBoJ7OC4IYNA fwTygfNLE7KWnfLiTAqt+qk= X-Google-Smtp-Source: ABdhPJxV6Elycqx1dRICdiCNg79b4Htqdl3dOeDDKtv9plNUw3cTgOknWkb2K4DTrDHt370T7qeSHQ== X-Received: by 2002:a5d:55d2:: with SMTP id i18mr19291070wrw.378.1596556245535; Tue, 04 Aug 2020 08:50:45 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id 69sm5417207wmb.8.2020.08.04.08.50.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2020 08:50:44 -0700 (PDT) Date: Tue, 4 Aug 2020 15:50:43 +0000 From: Wei Liu To: Jan Beulich Subject: Re: [PATCH] libxl: avoid golang building without CONFIG_GOLANG=y Message-ID: <20200804155043.vq7aupbrvmmcgzlv@liuwe-devbox-debian-v2> References: <20200804141639.k2tpoqy7jj34gcm6@liuwe-devbox-debian-v2> <0deed4c6-ca87-09d3-a19c-ac0c00003cb7@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0deed4c6-ca87-09d3-a19c-ac0c00003cb7@suse.com> User-Agent: NeoMutt/20180716 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Wei Liu , Ian Jackson , George Dunlap , Nick Rosbrook , Anthony Perard , "xen-devel@lists.xenproject.org" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Tue, Aug 04, 2020 at 05:30:40PM +0200, Jan Beulich wrote: > On 04.08.2020 17:22, Nick Rosbrook wrote: > > On Tue, Aug 4, 2020 at 10:17 AM Wei Liu wrote: > >> > >> On Mon, Aug 03, 2020 at 10:06:32AM +0200, Jan Beulich wrote: > >>> While this doesn't address the real problem I've run into (attempting to > >>> update r/o source files), not recursing into tools/golang/xenlight/ is > >>> enough to fix the build for me for the moment. I don't currently see why > >>> 60db5da62ac0 ("libxl: Generate golang bindings in libxl Makefile") found > >>> it necessary to invoke this build step unconditionally. > >>> > >> > >> Perhaps an oversight? > > > > This is intentional, and I think the commit message in 60db5da62ac0 > > ("libxl: Generate golang bindings in libxl Makefile") explains the > > reasoning well. But, to summarize, CONFIG_GOLANG is only used to > > control the bindings actually being compiled (i.e. with `go build`). > > However, we always want the code generation script > > (tools/golang/xenlight/gengotypes.py) to run if e.g. > > tools/libxl/libxl_types.idl is modified. > > > > I hope this helps. > > Not really - I'm still not seeing the "why" behind this behavior. I.e. > why build _anything_ that's not used further in the build, nor getting > installed? Also if (aiui) you effectively object to the change that > Wei has given his ack for, would you mind providing an alternative fix > for the problem at hand? Is the solution here to make the target check if IDL definition file is actually changed before regenerating the bindings? Admittedly I had misunderstood what CONFIG_GOLANG meant. Wei. > > Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:52:58 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 15:52:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2zFJ-0004xQ-Lv; Tue, 04 Aug 2020 15:52:57 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2zFI-0004xL-H9 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 15:52:56 +0000 X-Inumbo-ID: be60f59d-d5b7-44c7-bc9e-de44d9d9656c Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id be60f59d-d5b7-44c7-bc9e-de44d9d9656c; Tue, 04 Aug 2020 15:52:55 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D16492177B; Tue, 4 Aug 2020 15:52:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596556375; bh=tDpIkWuSdpodqGPQDWIFOE7o7/wTSGZ0oJmR6Sz9Ia0=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=OI3MDkvGqDpsgTM5w7jN/tiL+atoldmOEjEfCWS7pHTnC2Uy1MY0J813NPeuSI6rz xhvQyEAAalWPyUsZx6E0SeXw3RI4fmv3s0L+a9GjazjECiPEKRU1BLI8ztJSblepe0 uakSz5POYLuNJqFDfji1qYcISOWDiO6oPuAcHGYI= Date: Tue, 4 Aug 2020 08:52:54 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: =?UTF-8?Q?J=C3=BCrgen_Gro=C3=9F?= Subject: Re: [PATCH v3 00/11] fix swiotlb-xen for RPi4 In-Reply-To: <8413f3e2-0bbf-efa3-1a8a-2ae05b1d07c8@suse.com> Message-ID: References: <8413f3e2-0bbf-efa3-1a8a-2ae05b1d07c8@suse.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1376642103-1596556375=:5748" X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , konrad.wilk@oracle.com, roman@zededa.com, linux-kernel@vger.kernel.org, hch@infradead.org, tamas@tklengyel.com, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1376642103-1596556375=:5748 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Tue, 4 Aug 2020, Jürgen Groß wrote: > On 11.07.20 00:34, Stefano Stabellini wrote: > > Hi all, > > > > This series is a collection of fixes to get Linux running on the RPi4 as > > dom0. Conceptually there are only two significant changes: > > > > - make sure not to call virt_to_page on vmalloc virt addresses (patch > > #1) > > - use phys_to_dma and dma_to_phys to translate phys to/from dma > > addresses (all other patches) > > > > > > I addressed all comments by Christoph to v2 of the series except from > > the one about merging the precursor "add struct device *" patches. I can > > always merge them together at any time as needed. > > > > > > Boris gave his Reviewed-by to the whole series v2. I added his > > Reviewed-by to all patches, including the ones with small cosmetic > > fixes, except for patch #8 #9 #10 because they are either new or changed > > significantly in this version of the series. > > > > I retained Roman and Corey's Tested-by. > > Series pushed to: xen/tip.git for-linus-5.9 Fantastic, thank you! --8323329-1376642103-1596556375=:5748-- From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:53:52 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 15:53:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2zGB-00052G-Vx; Tue, 04 Aug 2020 15:53:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2zGA-000528-M2 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 15:53:50 +0000 X-Inumbo-ID: a677f024-7f63-495c-b4e7-d28ce07d8cd1 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a677f024-7f63-495c-b4e7-d28ce07d8cd1; Tue, 04 Aug 2020 15:53:49 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 17C00AF2A; Tue, 4 Aug 2020 15:54:05 +0000 (UTC) Subject: Re: [PATCH] libxl: avoid golang building without CONFIG_GOLANG=y To: Wei Liu , Nick Rosbrook References: <20200804141639.k2tpoqy7jj34gcm6@liuwe-devbox-debian-v2> <0deed4c6-ca87-09d3-a19c-ac0c00003cb7@suse.com> <20200804155043.vq7aupbrvmmcgzlv@liuwe-devbox-debian-v2> From: Jan Beulich Message-ID: <12790d2b-020d-b6fe-4924-2233a4e93d83@suse.com> Date: Tue, 4 Aug 2020 17:53:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200804155043.vq7aupbrvmmcgzlv@liuwe-devbox-debian-v2> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony Perard , "xen-devel@lists.xenproject.org" , Ian Jackson , George Dunlap Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 04.08.2020 17:50, Wei Liu wrote: > On Tue, Aug 04, 2020 at 05:30:40PM +0200, Jan Beulich wrote: >> On 04.08.2020 17:22, Nick Rosbrook wrote: >>> On Tue, Aug 4, 2020 at 10:17 AM Wei Liu wrote: >>>> >>>> On Mon, Aug 03, 2020 at 10:06:32AM +0200, Jan Beulich wrote: >>>>> While this doesn't address the real problem I've run into (attempting to >>>>> update r/o source files), not recursing into tools/golang/xenlight/ is >>>>> enough to fix the build for me for the moment. I don't currently see why >>>>> 60db5da62ac0 ("libxl: Generate golang bindings in libxl Makefile") found >>>>> it necessary to invoke this build step unconditionally. >>>>> >>>> >>>> Perhaps an oversight? >>> >>> This is intentional, and I think the commit message in 60db5da62ac0 >>> ("libxl: Generate golang bindings in libxl Makefile") explains the >>> reasoning well. But, to summarize, CONFIG_GOLANG is only used to >>> control the bindings actually being compiled (i.e. with `go build`). >>> However, we always want the code generation script >>> (tools/golang/xenlight/gengotypes.py) to run if e.g. >>> tools/libxl/libxl_types.idl is modified. >>> >>> I hope this helps. >> >> Not really - I'm still not seeing the "why" behind this behavior. I.e. >> why build _anything_ that's not used further in the build, nor getting >> installed? Also if (aiui) you effectively object to the change that >> Wei has given his ack for, would you mind providing an alternative fix >> for the problem at hand? > > Is the solution here to make the target check if IDL definition file is > actually changed before regenerating the bindings? I don't know - Nick? A move-if-changed based approach would likely deal with the r/o source problem at the same time (at least until such time where the directory containing the file(s) is also r/o). Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:57:20 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 15:57:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2zJR-0005EW-Fj; Tue, 04 Aug 2020 15:57:13 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2zJP-0005ER-LM for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 15:57:11 +0000 X-Inumbo-ID: ab04286e-6d85-415f-a82c-e70dd903725c Received: from mail-wm1-f66.google.com (unknown [209.85.128.66]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ab04286e-6d85-415f-a82c-e70dd903725c; Tue, 04 Aug 2020 15:57:10 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id d190so3148812wmd.4 for ; Tue, 04 Aug 2020 08:57:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=UoAcjfHvmyoQkWA3vl2d+30miFVgs9OkVz7RuVOksEY=; b=o8lIRHH8gXWoTCiPLp1C6yRpNaAVdwjGLEqLcrh/epMnrkVTg0aDcAUnKEKy7RcUSK YWaPOz7ystpaae/F44guEfxlUmxSqGJ4GIpqfeGy4pr4USqXVDxvKWqUrmkfAEPHa6jH ri45TufVCOPtZKwtfHf3H0zM+35Kn1ugJPy7IESlUQjrgWNv7XHvIoq7zs5+OG0jO++7 KjyKgA7XGxaKsKX7qj9b4FjU9U4oLA9batvnU4oG8PzmGsxqWlinp13kGXY1UdJrICjT Ot2iKUa7YrboS9iGFlgALd2jZ2564vDkpzfgwluMAUVHaGmH7TVBJhJnZbm00CWDupcX zqvA== X-Gm-Message-State: AOAM533RELCqejVm7Tv+bYL7omQMEg1VZosza56wEie/vliPFbAFGa8l /hEmv7l9IzfOOTjaaQ6Bx5M= X-Google-Smtp-Source: ABdhPJyNKYbfzlBLa6T7QUi9jfa6byepNTQpOlrEs+ZOxzSxKkesGoHlL2ay4mzySXVtrxE6u2ugSQ== X-Received: by 2002:a1c:ba83:: with SMTP id k125mr4698113wmf.160.1596556629627; Tue, 04 Aug 2020 08:57:09 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id 32sm35391243wrh.18.2020.08.04.08.57.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2020 08:57:08 -0700 (PDT) Date: Tue, 4 Aug 2020 15:57:07 +0000 From: Wei Liu To: Jan Beulich Subject: Re: [PATCH] libxl: avoid golang building without CONFIG_GOLANG=y Message-ID: <20200804155707.rrtzkksrle2nojbj@liuwe-devbox-debian-v2> References: <20200804141639.k2tpoqy7jj34gcm6@liuwe-devbox-debian-v2> <0deed4c6-ca87-09d3-a19c-ac0c00003cb7@suse.com> <20200804155043.vq7aupbrvmmcgzlv@liuwe-devbox-debian-v2> <12790d2b-020d-b6fe-4924-2233a4e93d83@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <12790d2b-020d-b6fe-4924-2233a4e93d83@suse.com> User-Agent: NeoMutt/20180716 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Wei Liu , Ian Jackson , George Dunlap , Nick Rosbrook , Anthony Perard , "xen-devel@lists.xenproject.org" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Tue, Aug 04, 2020 at 05:53:49PM +0200, Jan Beulich wrote: > On 04.08.2020 17:50, Wei Liu wrote: > > On Tue, Aug 04, 2020 at 05:30:40PM +0200, Jan Beulich wrote: > >> On 04.08.2020 17:22, Nick Rosbrook wrote: > >>> On Tue, Aug 4, 2020 at 10:17 AM Wei Liu wrote: > >>>> > >>>> On Mon, Aug 03, 2020 at 10:06:32AM +0200, Jan Beulich wrote: > >>>>> While this doesn't address the real problem I've run into (attempting to > >>>>> update r/o source files), not recursing into tools/golang/xenlight/ is > >>>>> enough to fix the build for me for the moment. I don't currently see why > >>>>> 60db5da62ac0 ("libxl: Generate golang bindings in libxl Makefile") found > >>>>> it necessary to invoke this build step unconditionally. > >>>>> > >>>> > >>>> Perhaps an oversight? > >>> > >>> This is intentional, and I think the commit message in 60db5da62ac0 > >>> ("libxl: Generate golang bindings in libxl Makefile") explains the > >>> reasoning well. But, to summarize, CONFIG_GOLANG is only used to > >>> control the bindings actually being compiled (i.e. with `go build`). > >>> However, we always want the code generation script > >>> (tools/golang/xenlight/gengotypes.py) to run if e.g. > >>> tools/libxl/libxl_types.idl is modified. > >>> > >>> I hope this helps. > >> > >> Not really - I'm still not seeing the "why" behind this behavior. I.e. > >> why build _anything_ that's not used further in the build, nor getting > >> installed? Also if (aiui) you effectively object to the change that > >> Wei has given his ack for, would you mind providing an alternative fix > >> for the problem at hand? > > > > Is the solution here to make the target check if IDL definition file is > > actually changed before regenerating the bindings? > > I don't know - Nick? A move-if-changed based approach would likely deal > with the r/o source problem at the same time (at least until such time > where the directory containing the file(s) is also r/o). To make sure Nick and I understand your use case correct -- "r/o source problem" means you want the tools source to be read-only? But you would be fine recursing into tools directory to build all the libraries and programs? Wei. > > Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 04 16:02:07 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 16:02:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2zO8-0006ce-4K; Tue, 04 Aug 2020 16:02:04 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2zO7-0006c8-3a for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 16:02:03 +0000 X-Inumbo-ID: 998c316e-a590-411e-b098-82e9bf6f8c2c Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 998c316e-a590-411e-b098-82e9bf6f8c2c; Tue, 04 Aug 2020 16:02:02 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 71F78B1B4; Tue, 4 Aug 2020 16:02:17 +0000 (UTC) Subject: Re: [PATCH] libxl: avoid golang building without CONFIG_GOLANG=y To: Wei Liu References: <20200804141639.k2tpoqy7jj34gcm6@liuwe-devbox-debian-v2> <0deed4c6-ca87-09d3-a19c-ac0c00003cb7@suse.com> <20200804155043.vq7aupbrvmmcgzlv@liuwe-devbox-debian-v2> <12790d2b-020d-b6fe-4924-2233a4e93d83@suse.com> <20200804155707.rrtzkksrle2nojbj@liuwe-devbox-debian-v2> From: Jan Beulich Message-ID: <43f706e4-0292-5758-eb19-9fbb99b1337e@suse.com> Date: Tue, 4 Aug 2020 18:02:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200804155707.rrtzkksrle2nojbj@liuwe-devbox-debian-v2> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony Perard , "xen-devel@lists.xenproject.org" , Ian Jackson , Nick Rosbrook , George Dunlap Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 04.08.2020 17:57, Wei Liu wrote: > On Tue, Aug 04, 2020 at 05:53:49PM +0200, Jan Beulich wrote: >> On 04.08.2020 17:50, Wei Liu wrote: >>> On Tue, Aug 04, 2020 at 05:30:40PM +0200, Jan Beulich wrote: >>>> On 04.08.2020 17:22, Nick Rosbrook wrote: >>>>> On Tue, Aug 4, 2020 at 10:17 AM Wei Liu wrote: >>>>>> >>>>>> On Mon, Aug 03, 2020 at 10:06:32AM +0200, Jan Beulich wrote: >>>>>>> While this doesn't address the real problem I've run into (attempting to >>>>>>> update r/o source files), not recursing into tools/golang/xenlight/ is >>>>>>> enough to fix the build for me for the moment. I don't currently see why >>>>>>> 60db5da62ac0 ("libxl: Generate golang bindings in libxl Makefile") found >>>>>>> it necessary to invoke this build step unconditionally. >>>>>>> >>>>>> >>>>>> Perhaps an oversight? >>>>> >>>>> This is intentional, and I think the commit message in 60db5da62ac0 >>>>> ("libxl: Generate golang bindings in libxl Makefile") explains the >>>>> reasoning well. But, to summarize, CONFIG_GOLANG is only used to >>>>> control the bindings actually being compiled (i.e. with `go build`). >>>>> However, we always want the code generation script >>>>> (tools/golang/xenlight/gengotypes.py) to run if e.g. >>>>> tools/libxl/libxl_types.idl is modified. >>>>> >>>>> I hope this helps. >>>> >>>> Not really - I'm still not seeing the "why" behind this behavior. I.e. >>>> why build _anything_ that's not used further in the build, nor getting >>>> installed? Also if (aiui) you effectively object to the change that >>>> Wei has given his ack for, would you mind providing an alternative fix >>>> for the problem at hand? >>> >>> Is the solution here to make the target check if IDL definition file is >>> actually changed before regenerating the bindings? >> >> I don't know - Nick? A move-if-changed based approach would likely deal >> with the r/o source problem at the same time (at least until such time >> where the directory containing the file(s) is also r/o). > > To make sure Nick and I understand your use case correct -- "r/o source > problem" means you want the tools source to be read-only? But you would > be fine recursing into tools directory to build all the libraries and > programs? Yes - until we support out-of-tree builds, nothing more can be expected to work. Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 04 16:13:19 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 16:13:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2zYs-0007YC-6F; Tue, 04 Aug 2020 16:13:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2zYr-0007Y7-4A for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 16:13:09 +0000 X-Inumbo-ID: 1048a266-1bf8-4a1e-9fe0-25252faa01d1 Received: from chiark.greenend.org.uk (unknown [2001:ba8:1e3::]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1048a266-1bf8-4a1e-9fe0-25252faa01d1; Tue, 04 Aug 2020 16:13:08 +0000 (UTC) Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by chiark.greenend.org.uk (Debian Exim 4.84_2 #1) with esmtp (return-path ijackson@chiark.greenend.org.uk) id 1k2zYp-00043d-3J; Tue, 04 Aug 2020 17:13:07 +0100 From: Ian Jackson To: xen-devel@lists.xenproject.org Subject: [OSSTEST PATCH] cri-args-hostlists: Add some calls to date(1) Date: Tue, 4 Aug 2020 17:13:04 +0100 Message-Id: <20200804161304.3018-1-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Ian Jackson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" This will make it easier to see perf changes etc. Signed-off-by: Ian Jackson --- cri-args-hostlists | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/cri-args-hostlists b/cri-args-hostlists index 28d576db..61572c2d 100644 --- a/cri-args-hostlists +++ b/cri-args-hostlists @@ -117,17 +117,25 @@ start_email () { globallockdir=`getconfig GlobalLockDir` + date >&2 + with-lock-ex -w $globallockdir/report-lock \ ./sg-report-job-history --html-dir=$job_html_dir --flight=$flight + date >&2 + ./sg-report-flight --html-dir=$flight_html_dir/$flight/ \ --allow=allow.all --allow=allow.$branch \ $sgr_args $flight >tmp/$flight.report ./cr-fold-long-lines tmp/$flight.report + date >&2 + mkdir -p $host_html_dir with-lock-ex -w $globallockdir/report-lock \ ./sg-report-host-history --html-dir=$host_html_dir flight:$flight + + date >&2 } publish_send_email () { -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 16:42:30 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 16:42:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k300w-0001hG-IO; Tue, 04 Aug 2020 16:42:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k300u-0001h9-Ri for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 16:42:08 +0000 X-Inumbo-ID: 2efdb852-1011-45be-ae0a-f981828cacba Received: from mail-lj1-x244.google.com (unknown [2a00:1450:4864:20::244]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2efdb852-1011-45be-ae0a-f981828cacba; Tue, 04 Aug 2020 16:42:07 +0000 (UTC) Received: by mail-lj1-x244.google.com with SMTP id v4so34653756ljd.0 for ; Tue, 04 Aug 2020 09:42:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Fp+iJT6C3dAg6jOiB3xVAFaJaKEb1vg9/C4xVCr/NCU=; b=I0eAguXD4G7wuk/9ZOOWkMhp3RVRQrizacSlb2U9yDnl2RXe3/l6NS8501BSIoUkKZ Siu1KGA9NzMa+9JPJBRACO3RjwqwEJmQM/28dnUUI34xLRh6NakqVFjuqvTkoyK6Hz8W jJ1QzzoylebmnNMoQC/XAz4vZYJcSzehVF68IETQL8mB03uBcfe15d3AVVxLYXEgtFGl QkLKhRPHtM1yce4qZ9vlW3Y0rxd7Gm1NZ9jMdaXXUKAnUp/FBvCZ/zDaOSq806/Yk1b3 gqqUs9ueFFLd3/wqmGCu9/GeSF4OnQGWj1p+oaZf/liy/xAhxPhRm9/kT6GXvTCQkZrR udTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Fp+iJT6C3dAg6jOiB3xVAFaJaKEb1vg9/C4xVCr/NCU=; b=DNqxX8w6wDMSfU4Ud+1dRQIoJjYXa/z2OMW5EbyBB5f0TzcVEVnPc0l7VbKiPEd5Ze UDT1UicWnPhKFnnzCdiMvHMg+EzSTDbLNLOSiJnCc8gVZ0KW/eIQTvdIPegVV2QBGxmb ZT6frpGHgC79znX97oAcHfkDuDg7qVSqRJTSGoFyqdcfcUDvJtSpep8G0BAkDVjaOWp8 5Z9Iyk3Z4KrE+BoiMKuU8v2y8OF6XQqcNOXhQnhfwY+FejWgCDd+K9Mwtn0poNG5ME38 W5oHAO+T5ap9mqvvFbCupRfWcyEl2qvt+76hPA2LeFjcUjyQ1I9m1rfvd5aBllPTj9up 4Nuw== X-Gm-Message-State: AOAM532YkkVf1SyatxmGcSD7HBfBjXnOK9TmyD4RhOHY+EodW5gGiAbm 2Pv5LP2iTz2+vtvPpK6WAAG+Lxhp5JO4HygbjFw= X-Google-Smtp-Source: ABdhPJx1RGduHOwZizmmY61EQTIxjBBceDacAlXmh7alNKz8UOMV8dGfNQ4V3ROD+7zCl3T1nBHBwgi02OYhZoNCPfY= X-Received: by 2002:a05:651c:1182:: with SMTP id w2mr9680574ljo.197.1596559326615; Tue, 04 Aug 2020 09:42:06 -0700 (PDT) MIME-Version: 1.0 References: <20200804141639.k2tpoqy7jj34gcm6@liuwe-devbox-debian-v2> <0deed4c6-ca87-09d3-a19c-ac0c00003cb7@suse.com> <20200804155043.vq7aupbrvmmcgzlv@liuwe-devbox-debian-v2> <12790d2b-020d-b6fe-4924-2233a4e93d83@suse.com> <20200804155707.rrtzkksrle2nojbj@liuwe-devbox-debian-v2> <43f706e4-0292-5758-eb19-9fbb99b1337e@suse.com> In-Reply-To: <43f706e4-0292-5758-eb19-9fbb99b1337e@suse.com> From: Nick Rosbrook Date: Tue, 4 Aug 2020 12:41:54 -0400 Message-ID: Subject: Re: [PATCH] libxl: avoid golang building without CONFIG_GOLANG=y To: Jan Beulich Content-Type: text/plain; charset="UTF-8" X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony Perard , "xen-devel@lists.xenproject.org" , Ian Jackson , George Dunlap , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Tue, Aug 4, 2020 at 12:02 PM Jan Beulich wrote: > > On 04.08.2020 17:57, Wei Liu wrote: > > On Tue, Aug 04, 2020 at 05:53:49PM +0200, Jan Beulich wrote: > >> On 04.08.2020 17:50, Wei Liu wrote: > >>> On Tue, Aug 04, 2020 at 05:30:40PM +0200, Jan Beulich wrote: > >>>> On 04.08.2020 17:22, Nick Rosbrook wrote: > >>>>> On Tue, Aug 4, 2020 at 10:17 AM Wei Liu wrote: > >>>>>> > >>>>>> On Mon, Aug 03, 2020 at 10:06:32AM +0200, Jan Beulich wrote: > >>>>>>> While this doesn't address the real problem I've run into (attempting to > >>>>>>> update r/o source files), not recursing into tools/golang/xenlight/ is > >>>>>>> enough to fix the build for me for the moment. I don't currently see why > >>>>>>> 60db5da62ac0 ("libxl: Generate golang bindings in libxl Makefile") found > >>>>>>> it necessary to invoke this build step unconditionally. > >>>>>>> > >>>>>> > >>>>>> Perhaps an oversight? > >>>>> > >>>>> This is intentional, and I think the commit message in 60db5da62ac0 > >>>>> ("libxl: Generate golang bindings in libxl Makefile") explains the > >>>>> reasoning well. But, to summarize, CONFIG_GOLANG is only used to > >>>>> control the bindings actually being compiled (i.e. with `go build`). > >>>>> However, we always want the code generation script > >>>>> (tools/golang/xenlight/gengotypes.py) to run if e.g. > >>>>> tools/libxl/libxl_types.idl is modified. > >>>>> > >>>>> I hope this helps. > >>>> > >>>> Not really - I'm still not seeing the "why" behind this behavior. I.e. > >>>> why build _anything_ that's not used further in the build, nor getting > >>>> installed? Also if (aiui) you effectively object to the change that > >>>> Wei has given his ack for, would you mind providing an alternative fix > >>>> for the problem at hand? > >>> > >>> Is the solution here to make the target check if IDL definition file is > >>> actually changed before regenerating the bindings? > >> > >> I don't know - Nick? A move-if-changed based approach would likely deal > >> with the r/o source problem at the same time (at least until such time > >> where the directory containing the file(s) is also r/o). > > > > To make sure Nick and I understand your use case correct -- "r/o source > > problem" means you want the tools source to be read-only? But you would > > be fine recursing into tools directory to build all the libraries and > > programs? > > Yes - until we support out-of-tree builds, nothing more can be expected > to work. > Jan - is the problem specifically that a fresh clone, or `git checkout`, etc. changes file timestamps in a way that triggers make to rebuild those targets? I have not used the move-if-changed approach before, but AFAICT that would be sufficient. -NR From xen-devel-bounces@lists.xenproject.org Tue Aug 04 19:11:43 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 19:11:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k32LI-0005sK-Cv; Tue, 04 Aug 2020 19:11:20 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k32LH-0005sC-6E for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 19:11:19 +0000 X-Inumbo-ID: 1843586d-e402-4ff1-bc2e-7d0741c13e0e Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1843586d-e402-4ff1-bc2e-7d0741c13e0e; Tue, 04 Aug 2020 19:11:17 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 75FD92086A; Tue, 4 Aug 2020 19:11:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596568277; bh=cNzLu5oubj3oa6ifg+ClSYDUc7pQiFWRY0rRg3WdhE8=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=2KvCh74of8zz8mvuweyJbD7BTr7V77rvbnwIHN3W/7DD5vxovc7NiVaitcxL/tVmL 29PDnMvw2bwtLvPqcvD0c/3iW3MuUBFFWWqNjVFpdED+SaW7OCAGrdjcB/f8+Zs2to 1yPoh8q9gEkt89VloEgQvWIwB96r2b/El+qTwQ+8= Date: Tue, 4 Aug 2020 12:11:15 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Julien Grall Subject: Re: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common In-Reply-To: Message-ID: References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-2-git-send-email-olekstysh@gmail.com> <000c01d66a33$2bd56510$83802f30$@xen.org> <9f83a7ed-ca97-449f-c7b9-a1140644abe9@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1983374449-1596565169=:5748" Content-ID: X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: 'Kevin Tian' , 'Stefano Stabellini' , 'Jun Nakajima' , 'Wei Liu' , paul@xen.org, 'Andrew Cooper' , 'Ian Jackson' , 'George Dunlap' , 'Tim Deegan' , Oleksandr , 'Oleksandr Tyshchenko' , 'Julien Grall' , 'Jan Beulich' , xen-devel@lists.xenproject.org, =?UTF-8?Q?'Roger_Pau_Monn=C3=A9'?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1983374449-1596565169=:5748 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Tue, 4 Aug 2020, Julien Grall wrote: > On 04/08/2020 12:10, Oleksandr wrote: > > On 04.08.20 10:45, Paul Durrant wrote: > > > > +static inline bool hvm_ioreq_needs_completion(const ioreq_t *ioreq) > > > > +{ > > > > +    return ioreq->state == STATE_IOREQ_READY && > > > > +           !ioreq->data_is_ptr && > > > > +           (ioreq->type != IOREQ_TYPE_PIO || ioreq->dir != > > > > IOREQ_WRITE); > > > > +} > > > I don't think having this in common code is correct. The short-cut of not > > > completing PIO reads seems somewhat x86 specific. > > Hmmm, looking at the code, I think it doesn't wait for PIO writes to complete > (not read). Did I miss anything? > > > Does ARM even > > > have the concept of PIO? > > > > I am not 100% sure here, but it seems that doesn't have. > > Technically, the PIOs exist on Arm, however they are accessed the same way as > MMIO and will have a dedicated area defined by the HW. > > AFAICT, on Arm64, they are only used for PCI IO Bar. > > Now the question is whether we want to expose them to the Device Emulator as > PIO or MMIO access. From a generic PoV, a DM shouldn't have to care about the > architecture used. It should just be able to request a given IOport region. > > So it may make sense to differentiate them in the common ioreq code as well. > > I had a quick look at QEMU and wasn't able to tell if PIOs and MMIOs address > space are different on Arm as well. Paul, Stefano, do you know what they are > doing? On the QEMU side, it looks like PIO (address_space_io) is used in connection with the emulation of the "in" or "out" instructions, see ioport.c:cpu_inb for instance. Some parts of PCI on QEMU emulate PIO space regardless of the architecture, such as hw/pci/pci_bridge.c:pci_bridge_initfn. However, because there is no "in" and "out" on ARM, I don't think address_space_io can be accessed. Specifically, there is no equivalent for target/i386/misc_helper.c:helper_inb on ARM. So I think PIO is unused on ARM in QEMU. FYI the ioreq type for PCI conf space reads and writes is IOREQ_TYPE_PCI_CONFIG (neither MMIO nor PIO) which is implemented as pci_host_config_read_common/pci_host_config_write_common directly (neither PIO nor MMIO). It looks like PIO-specific things could be kept x86-specific, without loss of functionalities on the ARM side. > The point of the check isn't to determine whether to wait, but > what to do after having waited. Reads need a retry round through > the emulator (to store the result in the designated place), > while writes don't have such a requirement (and hence guest > execution can continue immediately in the general case). The x86 code looks like this: rc = hvm_send_ioreq(s, &p, 0); if ( rc != X86EMUL_RETRY || currd->is_shutting_down ) vio->io_req.state = STATE_IOREQ_NONE; else if ( !hvm_ioreq_needs_completion(&vio->io_req) ) rc = X86EMUL_OKAY; Basically hvm_send_ioreq is expected to return RETRY. Then, if it is a PIO write operation only, it is turned into OKAY right away. Otherwise, rc stays as RETRY. So, normally, hvmemul_do_io is expected to return RETRY, because the emulator is not done yet. Am I understanding the code correctly? If so, who is handling RETRY on x86? It tried to follow the call chain but ended up in the x86 emulator and got lost :-) At some point later, after the emulator (QEMU) has completed the request, handle_hvm_io_completion gets called which ends up calling handle_mmio() finishing the job on the Xen side too. In other words: RETRY ==> emulation in progress OKAY ==> emulation completed Is that correct? --8323329-1983374449-1596565169=:5748-- From xen-devel-bounces@lists.xenproject.org Tue Aug 04 19:15:21 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 19:15:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k32PB-00060T-1o; Tue, 04 Aug 2020 19:15:21 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k32P9-00060N-G7 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 19:15:19 +0000 X-Inumbo-ID: 6157cd1e-ddf6-4f5c-9b9b-93388cd9bc79 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6157cd1e-ddf6-4f5c-9b9b-93388cd9bc79; Tue, 04 Aug 2020 19:15:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=p2muXYs01Qs0Kky1ZN3hvlihh6Lxq/EYW6TQx8llERg=; b=4uvgOdIfM5XIV3yzMBU4AEVun Cne8RZTQgKfv90sDodEJvAYVoxXzt1qe8Wky622jVfcAQ5UXuBomqp1HXX3Cm9yl69y1uH/KMDvqS 12eR4D/zsSIafQVIE22ZylGWJeXjEZOEKFNdZoq6JBKYubSdKl4HbOhzVxxDo2rG9DZ1g=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k32P7-0007iM-MY; Tue, 04 Aug 2020 19:15:17 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k32P7-0002uD-74; Tue, 04 Aug 2020 19:15:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k32P7-00074W-6T; Tue, 04 Aug 2020 19:15:17 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 152459: all pass - PUSHED X-Osstest-Versions-This: ovmf=aa211bb6ef8edc70d2e6dfdab01a7d29e53f1ee2 X-Osstest-Versions-That: ovmf=bbb8a818583853ec4bb7804e78ed1d304b709d33 From: osstest service owner Date: Tue, 04 Aug 2020 19:15:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152459 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/152459/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf aa211bb6ef8edc70d2e6dfdab01a7d29e53f1ee2 baseline version: ovmf bbb8a818583853ec4bb7804e78ed1d304b709d33 Last test of basis 152422 2020-08-03 12:09:55 Z 1 days Testing same since 152459 2020-08-04 07:31:47 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Guomin Jiang Laszlo Ersek Michael D Kinney Wei6 Xu Yuwei Chen jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git bbb8a81858..aa211bb6ef aa211bb6ef8edc70d2e6dfdab01a7d29e53f1ee2 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Aug 04 21:36:08 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 21:36:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k34b2-0000wz-Gi; Tue, 04 Aug 2020 21:35:44 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k34b1-0000w1-G7 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 21:35:43 +0000 X-Inumbo-ID: b8314ad0-d1cd-4936-b834-f8ff72e23112 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b8314ad0-d1cd-4936-b834-f8ff72e23112; Tue, 04 Aug 2020 21:35:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=YAv3+qNsuf6ct6OcQvIsH4/EJgbJt+Ohq1aljL8aqkA=; b=hEAyInD6g/qI0NkOW61ZsEbv4 YaaTvXe3oZb+jX+xRBN73BOMmLTL0dy7DU730ASHWvP7pj/OdxJnwVjMsuR75HOKw2rlJ3cQCOmN8 +/yErpEUFphyQ0zaP/SXgNLwtknLaBIBVivbsPywDYYbIWeSl91PrUbjNh0g7W28e3JQ0=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k34ay-0002PW-FX; Tue, 04 Aug 2020 21:35:40 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k34ay-0001R7-3H; Tue, 04 Aug 2020 21:35:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k34ay-0007tK-2h; Tue, 04 Aug 2020 21:35:40 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 152473: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=fe49938f21c26f0ce630c69af055f927dd0ed75f X-Osstest-Versions-That: xen=9909532113692020c1b50eb974cac47d4ea10e69 From: osstest service owner Date: Tue, 04 Aug 2020 21:35:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152473 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/152473/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass version targeted for testing: xen fe49938f21c26f0ce630c69af055f927dd0ed75f baseline version: xen 9909532113692020c1b50eb974cac47d4ea10e69 Last test of basis 152428 2020-08-03 15:03:25 Z 1 days Testing same since 152473 2020-08-04 15:18:46 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Wei Liu jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 9909532113..fe49938f21 fe49938f21c26f0ce630c69af055f927dd0ed75f -> smoke From xen-devel-bounces@lists.xenproject.org Tue Aug 04 23:22:47 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 23:22:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k36GS-0001gK-Pd; Tue, 04 Aug 2020 23:22:36 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k36GR-0001g1-4O for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 23:22:35 +0000 X-Inumbo-ID: 21acce81-2bec-40b8-baa3-a7af217f98a2 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 21acce81-2bec-40b8-baa3-a7af217f98a2; Tue, 04 Aug 2020 23:22:33 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8424C20842; Tue, 4 Aug 2020 23:22:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596583353; bh=+541hY4oQwMDk7KvaXCUPFlpnBiTi3iZNAh1Io4ZNyo=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=uZeXslBW7+BXNpDxNO/2AX4Z6qXOe+X9eufVXoyyRp/5mzUw5CaHbqkiGamhT6D3K dhYY9rE2tItHGkQiiryDjtrMhGv2zJLlJKHil8nnwj8MVwjfLEDUrtevakblWSKFuP uILaSDMKeIKDjibKGP7qbUTcP/QN+qfQXGOB4HQc= Date: Tue, 4 Aug 2020 16:22:32 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Oleksandr Tyshchenko Subject: Re: [RFC PATCH V1 04/12] xen/arm: Introduce arch specific bits for IOREQ/DM features In-Reply-To: <1596478888-23030-5-git-send-email-olekstysh@gmail.com> Message-ID: References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-5-git-send-email-olekstysh@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Julien Grall , Jan Beulich , xen-devel@lists.xenproject.org, Daniel De Graaf , Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Mon, 3 Aug 2020, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > This patch makes possible to forward Guest MMIO accesses > to a device emulator on Arm and enables that support for > Arm64. > > Also update XSM code a bit to let DM op be used on Arm. > New arch DM op will be introduced in the follow-up patch. > > Please note, at the moment build on Arm32 is broken > (see cmpxchg usage in hvm_send_buffered_ioreq()) if someone Speaking of buffered_ioreq, if I recall correctly, they were only used for VGA-related things on x86. It looks like it is still true. If so, do we need it on ARM? Note that I don't think we can get rid of it from the interface as it is baked into ioreq, but it might be possible to have a dummy implementation on ARM. Or maybe not: looking at xen/common/hvm/ioreq.c it looks like it would be difficult to disentangle bufioreq stuff from the rest of the code. > wants to enable CONFIG_IOREQ_SERVER due to the lack of > cmpxchg_64 support on Arm32. > > Please note, this is a split/cleanup of Julien's PoC: > "Add support for Guest IO forwarding to a device emulator" > > Signed-off-by: Julien Grall > Signed-off-by: Oleksandr Tyshchenko [...] > @@ -2275,6 +2282,16 @@ static void check_for_vcpu_work(void) > */ > void leave_hypervisor_to_guest(void) > { > +#ifdef CONFIG_IOREQ_SERVER > + /* > + * XXX: Check the return. Shall we call that in > + * continue_running and context_switch instead? > + * The benefits would be to avoid calling > + * handle_hvm_io_completion on every return. > + */ Yeah, that could be a simple and good optimization > + local_irq_enable(); > + handle_hvm_io_completion(current); > +#endif > local_irq_disable(); > > check_for_vcpu_work(); > diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h > index 4e2f582..e060b0a 100644 > --- a/xen/include/asm-arm/domain.h > +++ b/xen/include/asm-arm/domain.h > @@ -11,12 +11,64 @@ > #include > #include > #include > +#include > +#include > #include > #include > > +struct hvm_ioreq_page { > + gfn_t gfn; > + struct page_info *page; > + void *va; > +}; > + > +struct hvm_ioreq_vcpu { > + struct list_head list_entry; > + struct vcpu *vcpu; > + evtchn_port_t ioreq_evtchn; > + bool pending; > +}; > + > +#define NR_IO_RANGE_TYPES (XEN_DMOP_IO_RANGE_PCI + 1) > +#define MAX_NR_IO_RANGES 256 > + > +#define MAX_NR_IOREQ_SERVERS 8 > +#define DEFAULT_IOSERVID 0 > + > +struct hvm_ioreq_server { > + struct domain *target, *emulator; > + > + /* Lock to serialize toolstack modifications */ > + spinlock_t lock; > + > + struct hvm_ioreq_page ioreq; > + struct list_head ioreq_vcpu_list; > + struct hvm_ioreq_page bufioreq; > + > + /* Lock to serialize access to buffered ioreq ring */ > + spinlock_t bufioreq_lock; > + evtchn_port_t bufioreq_evtchn; > + struct rangeset *range[NR_IO_RANGE_TYPES]; > + bool enabled; > + uint8_t bufioreq_handling; > +}; > + > struct hvm_domain > { > uint64_t params[HVM_NR_PARAMS]; > + > + /* Guest page range used for non-default ioreq servers */ > + struct { > + unsigned long base; > + unsigned long mask; > + unsigned long legacy_mask; /* indexed by HVM param number */ > + } ioreq_gfn; > + > + /* Lock protects all other values in the sub-struct and the default */ > + struct { > + spinlock_t lock; > + struct hvm_ioreq_server *server[MAX_NR_IOREQ_SERVERS]; > + } ioreq_server; > }; > > #ifdef CONFIG_ARM_64 > @@ -93,6 +145,29 @@ struct arch_domain > #endif > } __cacheline_aligned; > > +enum hvm_io_completion { > + HVMIO_no_completion, > + HVMIO_mmio_completion, > + HVMIO_pio_completion, > + HVMIO_realmode_completion realmode is an x86-ism (as pio), I wonder if we could get rid of it on ARM > +}; > + > +struct hvm_vcpu_io { > + /* I/O request in flight to device model. */ > + enum hvm_io_completion io_completion; > + ioreq_t io_req; > + > + /* > + * HVM emulation: > + * Linear address @mmio_gla maps to MMIO physical frame @mmio_gpfn. > + * The latter is known to be an MMIO frame (not RAM). > + * This translation is only valid for accesses as per @mmio_access. > + */ > + struct npfec mmio_access; > + unsigned long mmio_gla; > + unsigned long mmio_gpfn; > +}; > + > struct arch_vcpu > { > struct { > @@ -206,6 +281,11 @@ struct arch_vcpu > */ > bool need_flush_to_ram; > > + struct hvm_vcpu > + { > + struct hvm_vcpu_io hvm_io; > + } hvm; > + > } __cacheline_aligned; > > void vcpu_show_execution_state(struct vcpu *); > diff --git a/xen/include/asm-arm/hvm/ioreq.h b/xen/include/asm-arm/hvm/ioreq.h > new file mode 100644 > index 0000000..83a560c > --- /dev/null > +++ b/xen/include/asm-arm/hvm/ioreq.h > @@ -0,0 +1,103 @@ > +/* > + * hvm.h: Hardware virtual machine assist interface definitions. > + * > + * Copyright (c) 2016 Citrix Systems Inc. > + * Copyright (c) 2019 Arm ltd. > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms and conditions of the GNU General Public License, > + * version 2, as published by the Free Software Foundation. > + * > + * This program is distributed in the hope it will be useful, but WITHOUT > + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or > + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for > + * more details. > + * > + * You should have received a copy of the GNU General Public License along with > + * this program; If not, see . > + */ > + > +#ifndef __ASM_ARM_HVM_IOREQ_H__ > +#define __ASM_ARM_HVM_IOREQ_H__ > + > +#include > +#include > + > +#define has_vpci(d) (false) > + > +bool handle_mmio(void); > + > +static inline bool handle_pio(uint16_t port, unsigned int size, int dir) > +{ > + /* XXX */ > + BUG(); > + return true; > +} > + > +static inline paddr_t hvm_mmio_first_byte(const ioreq_t *p) > +{ > + return p->addr; > +} > + > +static inline paddr_t hvm_mmio_last_byte(const ioreq_t *p) > +{ > + unsigned long size = p->size; > + > + return p->addr + size - 1; > +} > + > +struct hvm_ioreq_server; > + > +static inline int p2m_set_ioreq_server(struct domain *d, > + unsigned int flags, > + struct hvm_ioreq_server *s) > +{ > + return -EOPNOTSUPP; > +} > + > +static inline void msix_write_completion(struct vcpu *v) > +{ > +} > + > +static inline void handle_realmode_completion(void) > +{ > + ASSERT_UNREACHABLE(); > +} > + > +static inline void paging_mark_pfn_dirty(struct domain *d, pfn_t pfn) > +{ > +} > + > +static inline void hvm_get_ioreq_server_range_type(struct domain *d, > + ioreq_t *p, > + uint8_t *type, > + uint64_t *addr) > +{ > + *type = (p->type == IOREQ_TYPE_PIO) ? > + XEN_DMOP_IO_RANGE_PORT : XEN_DMOP_IO_RANGE_MEMORY; > + *addr = p->addr; > +} > + > +static inline void arch_hvm_ioreq_init(struct domain *d) > +{ > +} > + > +static inline void arch_hvm_ioreq_destroy(struct domain *d) > +{ > +} > + > +#define IOREQ_IO_HANDLED IO_HANDLED > +#define IOREQ_IO_UNHANDLED IO_UNHANDLED > +#define IOREQ_IO_RETRY IO_RETRY > + > +#endif /* __ASM_X86_HVM_IOREQ_H__ */ > + > +/* > + * Local variables: > + * mode: C > + * c-file-style: "BSD" > + * c-basic-offset: 4 > + * tab-width: 4 > + * indent-tabs-mode: nil > + * End: > + */ > diff --git a/xen/include/asm-arm/p2m.h b/xen/include/asm-arm/p2m.h > index 5fdb6e8..5823f11 100644 > --- a/xen/include/asm-arm/p2m.h > +++ b/xen/include/asm-arm/p2m.h > @@ -385,10 +385,11 @@ static inline int set_foreign_p2m_entry(struct domain *d, unsigned long gfn, > mfn_t mfn) > { > /* > - * NOTE: If this is implemented then proper reference counting of > - * foreign entries will need to be implemented. > + * XXX: handle properly reference. It looks like the page may not always > + * belong to d. Just as a reference, and without taking away anything from the comment, I think that QEMU is doing its own internal reference counting for these mappings. > */ > - return -EOPNOTSUPP; > + > + return guest_physmap_add_entry(d, _gfn(gfn), mfn, 0, p2m_ram_rw); > } > > /* From xen-devel-bounces@lists.xenproject.org Tue Aug 04 23:22:47 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 23:22:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k36GY-0001ge-1b; Tue, 04 Aug 2020 23:22:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k36GW-0001gY-9b for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 23:22:40 +0000 X-Inumbo-ID: 2af5228c-9e89-43d0-81ed-fff943d236dd Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2af5228c-9e89-43d0-81ed-fff943d236dd; Tue, 04 Aug 2020 23:22:39 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AF0A82073E; Tue, 4 Aug 2020 23:22:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596583359; bh=O5lobv7IQQbkINSkzdl2ELQpbr6+hMPYTclAIKLSEKA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=zGTQeKo6Z2x/OUqg4XVeqCGyRyc2VYjG6V1g9d8FzHjNnLSV6GyUA5xMyXEnBL4VV zT6gM1WiKUT7K/I4v48HMnpylxptw/IVekdr1MsuwyDxWvQuo5L1P/JbNg9/sM6e33 INISlgG3pZ7iv5SKdOgdMgX0RLKAV3j4IBXS1dFk= Date: Tue, 4 Aug 2020 16:22:38 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Oleksandr Tyshchenko Subject: Re: [RFC PATCH V1 05/12] hvm/dm: Introduce xendevicemodel_set_irq_level DM op In-Reply-To: <1596478888-23030-6-git-send-email-olekstysh@gmail.com> Message-ID: References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-6-git-send-email-olekstysh@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Julien Grall , Jan Beulich , xen-devel@lists.xenproject.org, Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Mon, 3 Aug 2020, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > This patch adds ability to the device emulator to notify otherend > (some entity running in the guest) using a SPI and implements Arm > specific bits for it. Proposed interface allows emulator to set > the logical level of a one of a domain's IRQ lines. > > Please note, this is a split/cleanup of Julien's PoC: > "Add support for Guest IO forwarding to a device emulator" > > Signed-off-by: Julien Grall > Signed-off-by: Oleksandr Tyshchenko > --- > tools/libs/devicemodel/core.c | 18 ++++++++++++++++++ > tools/libs/devicemodel/include/xendevicemodel.h | 4 ++++ > tools/libs/devicemodel/libxendevicemodel.map | 1 + > xen/arch/arm/dm.c | 22 +++++++++++++++++++++- > xen/common/hvm/dm.c | 1 + > xen/include/public/hvm/dm_op.h | 15 +++++++++++++++ > 6 files changed, 60 insertions(+), 1 deletion(-) > > diff --git a/tools/libs/devicemodel/core.c b/tools/libs/devicemodel/core.c > index 4d40639..30bd79f 100644 > --- a/tools/libs/devicemodel/core.c > +++ b/tools/libs/devicemodel/core.c > @@ -430,6 +430,24 @@ int xendevicemodel_set_isa_irq_level( > return xendevicemodel_op(dmod, domid, 1, &op, sizeof(op)); > } > > +int xendevicemodel_set_irq_level( > + xendevicemodel_handle *dmod, domid_t domid, uint32_t irq, > + unsigned int level) It is a pity that having xen_dm_op_set_pci_intx_level and xen_dm_op_set_isa_irq_level already we need to add a third one, but from the names alone I don't think we can reuse either of them. It is very similar to set_isa_irq_level. We could almost rename xendevicemodel_set_isa_irq_level to xendevicemodel_set_irq_level or, better, just add an alias to it so that xendevicemodel_set_irq_level is implemented by calling xendevicemodel_set_isa_irq_level. Honestly I am not sure if it is worth doing it though. Any other opinions? But I think we should plan for not needing two calls (one to set level to 1, and one to set it to 0): https://marc.info/?l=xen-devel&m=159535112027405 > +{ > + struct xen_dm_op op; > + struct xen_dm_op_set_irq_level *data; > + > + memset(&op, 0, sizeof(op)); > + > + op.op = XEN_DMOP_set_irq_level; > + data = &op.u.set_irq_level; > + > + data->irq = irq; > + data->level = level; > + > + return xendevicemodel_op(dmod, domid, 1, &op, sizeof(op)); > +} > + > int xendevicemodel_set_pci_link_route( > xendevicemodel_handle *dmod, domid_t domid, uint8_t link, uint8_t irq) > { > diff --git a/tools/libs/devicemodel/include/xendevicemodel.h b/tools/libs/devicemodel/include/xendevicemodel.h > index e877f5c..c06b3c8 100644 > --- a/tools/libs/devicemodel/include/xendevicemodel.h > +++ b/tools/libs/devicemodel/include/xendevicemodel.h > @@ -209,6 +209,10 @@ int xendevicemodel_set_isa_irq_level( > xendevicemodel_handle *dmod, domid_t domid, uint8_t irq, > unsigned int level); > > +int xendevicemodel_set_irq_level( > + xendevicemodel_handle *dmod, domid_t domid, unsigned int irq, > + unsigned int level); > + > /** > * This function maps a PCI INTx line to a an IRQ line. > * > diff --git a/tools/libs/devicemodel/libxendevicemodel.map b/tools/libs/devicemodel/libxendevicemodel.map > index 561c62d..a0c3012 100644 > --- a/tools/libs/devicemodel/libxendevicemodel.map > +++ b/tools/libs/devicemodel/libxendevicemodel.map > @@ -32,6 +32,7 @@ VERS_1.2 { > global: > xendevicemodel_relocate_memory; > xendevicemodel_pin_memory_cacheattr; > + xendevicemodel_set_irq_level; > } VERS_1.1; > > VERS_1.3 { > diff --git a/xen/arch/arm/dm.c b/xen/arch/arm/dm.c > index 2437099..8431805 100644 > --- a/xen/arch/arm/dm.c > +++ b/xen/arch/arm/dm.c > @@ -20,7 +20,27 @@ > int arch_dm_op(struct xen_dm_op *op, struct domain *d, > const struct dmop_args *op_args, bool *const_op) > { > - return -EOPNOTSUPP; > + int rc; > + > + switch ( op->op ) > + { > + case XEN_DMOP_set_irq_level: > + { > + const struct xen_dm_op_set_irq_level *data = > + &op->u.set_irq_level; > + > + /* XXX: Handle check */ > + vgic_inject_irq(d, NULL, data->irq, data->level); > + rc = 0; > + break; > + } > + > + default: > + rc = -EOPNOTSUPP; > + break; > + } > + > + return rc; > } > > /* > diff --git a/xen/common/hvm/dm.c b/xen/common/hvm/dm.c > index 09e9542..e2e1250 100644 > --- a/xen/common/hvm/dm.c > +++ b/xen/common/hvm/dm.c > @@ -47,6 +47,7 @@ static int dm_op(const struct dmop_args *op_args) > [XEN_DMOP_remote_shutdown] = sizeof(struct xen_dm_op_remote_shutdown), > [XEN_DMOP_relocate_memory] = sizeof(struct xen_dm_op_relocate_memory), > [XEN_DMOP_pin_memory_cacheattr] = sizeof(struct xen_dm_op_pin_memory_cacheattr), > + [XEN_DMOP_set_irq_level] = sizeof(struct xen_dm_op_set_irq_level), > }; > > rc = rcu_lock_remote_domain_by_id(op_args->domid, &d); > diff --git a/xen/include/public/hvm/dm_op.h b/xen/include/public/hvm/dm_op.h > index fd00e9d..c45d29e 100644 > --- a/xen/include/public/hvm/dm_op.h > +++ b/xen/include/public/hvm/dm_op.h > @@ -417,6 +417,20 @@ struct xen_dm_op_pin_memory_cacheattr { > uint32_t pad; > }; > > +/* > + * XEN_DMOP_set_irq_level: Set the logical level of a one of a domain's > + * IRQ lines. > + * XXX Handle PPIs. > + */ > +#define XEN_DMOP_set_irq_level 19 > + > +struct xen_dm_op_set_irq_level { > + uint32_t irq; > + /* IN - Level: 0 -> deasserted, 1 -> asserted */ > + uint8_t level; > +}; > + > + > struct xen_dm_op { > uint32_t op; > uint32_t pad; > @@ -430,6 +444,7 @@ struct xen_dm_op { > struct xen_dm_op_track_dirty_vram track_dirty_vram; > struct xen_dm_op_set_pci_intx_level set_pci_intx_level; > struct xen_dm_op_set_isa_irq_level set_isa_irq_level; > + struct xen_dm_op_set_irq_level set_irq_level; > struct xen_dm_op_set_pci_link_route set_pci_link_route; > struct xen_dm_op_modified_memory modified_memory; > struct xen_dm_op_set_mem_type set_mem_type; > -- > 2.7.4 > From xen-devel-bounces@lists.xenproject.org Tue Aug 04 23:22:47 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 23:22:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k36GN-0001g6-HI; Tue, 04 Aug 2020 23:22:31 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k36GM-0001g1-Oo for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 23:22:30 +0000 X-Inumbo-ID: 1b6332ac-f65e-4ebd-8dbb-081a2cc29d21 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1b6332ac-f65e-4ebd-8dbb-081a2cc29d21; Tue, 04 Aug 2020 23:22:29 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D85C92073E; Tue, 4 Aug 2020 23:22:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596583348; bh=PsSJUCD59asltcoFiaVL865acSKkt2G4DHIVsCjUDOs=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=UqSjPVKuhrcyUhuZlqz/uf2//X+bnHxeXL4pwtRu1HNLEEmeQB+NkDAlTPcLo06NQ ZHdk9Zd9pmuO9R20Hjg1tkml5QRywe8TzUJQy/QyZ0g59UDiv9CPwsgUtVv4GOfvEN fylxSKRjtfeABEWpflj9Vb6/xD/R8KGc1B2s2tNI= Date: Tue, 4 Aug 2020 16:22:27 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Julien Grall Subject: Re: [RFC PATCH V1 04/12] xen/arm: Introduce arch specific bits for IOREQ/DM features In-Reply-To: <6c4f7698-a015-91c7-83ec-203f63d48900@xen.org> Message-ID: References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-5-git-send-email-olekstysh@gmail.com> <001101d66a33$bba44670$32ecd350$@xen.org> <6c4f7698-a015-91c7-83ec-203f63d48900@xen.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: 'Stefano Stabellini' , 'Wei Liu' , paul@xen.org, 'Andrew Cooper' , 'Ian Jackson' , 'George Dunlap' , 'Oleksandr Tyshchenko' , 'Oleksandr Tyshchenko' , 'Julien Grall' , 'Jan Beulich' , xen-devel@lists.xenproject.org, 'Daniel De Graaf' , 'Volodymyr Babchuk' Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Tue, 4 Aug 2020, Julien Grall wrote: > On 04/08/2020 08:49, Paul Durrant wrote: > > > diff --git a/tools/libxc/xc_dom_arm.c b/tools/libxc/xc_dom_arm.c > > > index 931404c..b5fc066 100644 > > > --- a/tools/libxc/xc_dom_arm.c > > > +++ b/tools/libxc/xc_dom_arm.c > > > @@ -26,11 +26,19 @@ > > > #include "xg_private.h" > > > #include "xc_dom.h" > > > > > > -#define NR_MAGIC_PAGES 4 > > > + > > > #define CONSOLE_PFN_OFFSET 0 > > > #define XENSTORE_PFN_OFFSET 1 > > > #define MEMACCESS_PFN_OFFSET 2 > > > #define VUART_PFN_OFFSET 3 > > > +#define IOREQ_SERVER_PFN_OFFSET 4 > > > + > > > +#define NR_IOREQ_SERVER_PAGES 8 > > > +#define NR_MAGIC_PAGES (4 + NR_IOREQ_SERVER_PAGES) > > > + > > > +#define GUEST_MAGIC_BASE_PFN (GUEST_MAGIC_BASE >> XC_PAGE_SHIFT) > > > + > > > +#define special_pfn(x) (GUEST_MAGIC_BASE_PFN + (x)) > > > > Why introduce 'magic pages' for Arm? It's quite a horrible hack that we have > > begun to do away with by adding resource mapping. > > This would require us to mandate at least Linux 4.17 in a domain that will run > an IOREQ server. If we don't mandate this, the minimum version would be 4.10 > where DM OP was introduced. > > Because of XSA-300, we could technically not safely run an IOREQ server with > existing Linux. So it is probably OK to enforce the use of the acquire > interface. +1 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 23:22:56 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 23:22:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k36Gm-0001jY-Dv; Tue, 04 Aug 2020 23:22:56 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k36Gl-0001jM-OY for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 23:22:55 +0000 X-Inumbo-ID: cd8bc00f-d201-478f-963e-677910a22c88 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id cd8bc00f-d201-478f-963e-677910a22c88; Tue, 04 Aug 2020 23:22:55 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 35A7C2073E; Tue, 4 Aug 2020 23:22:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596583374; bh=RYhMPLQdbmgiruH5kzVLc3tXrt8T11wvJwMZFyGZBg4=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=M074Fw57RaXO3uIS8dZ28VuB1V21hPegAyU84JS8AS7CUA/98yXR2ZrtA2APpitOP osUwNOOPVyxwiETRwTWdGk4SzvOpVIky3Prj59CIEBpeCHYzVIa6PM/wJdom0FlNQZ SPUqVwZBskJEs3i3RDdKzH55OkyFETAaNmPXWNwg= Date: Tue, 4 Aug 2020 16:22:53 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Oleksandr Tyshchenko Subject: Re: [RFC PATCH V1 09/12] libxl: Handle virtio-mmio irq in more correct way In-Reply-To: <1596478888-23030-10-git-send-email-olekstysh@gmail.com> Message-ID: References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-10-git-send-email-olekstysh@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Ian Jackson , Oleksandr Tyshchenko , Anthony PERARD , xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Mon, 3 Aug 2020, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > This patch makes possible to use device passthrough again. > > Signed-off-by: Oleksandr Tyshchenko > --- > tools/libxl/libxl_arm.c | 33 +++++++++++++++++++++++---------- > 1 file changed, 23 insertions(+), 10 deletions(-) > > diff --git a/tools/libxl/libxl_arm.c b/tools/libxl/libxl_arm.c > index 620b499..4f748e3 100644 > --- a/tools/libxl/libxl_arm.c > +++ b/tools/libxl/libxl_arm.c > @@ -9,6 +9,10 @@ > #include > #include > > +#define GUEST_VIRTIO_MMIO_BASE xen_mk_ullong(0x02000000) > +#define GUEST_VIRTIO_MMIO_SIZE xen_mk_ullong(0x200) > +#define GUEST_VIRTIO_MMIO_SPI 33 They should be in xen/include/public/arch-arm.h Is one interrupt enough if there are multiple virtio devices? Is it one interrupt for all virtio devices, or one for each device? Of course this patch should be folded in the patch to add virtio support to libxl. > static const char *gicv_to_string(libxl_gic_version gic_version) > { > switch (gic_version) { > @@ -27,8 +31,8 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, > { > uint32_t nr_spis = 0; > unsigned int i; > - uint32_t vuart_irq; > - bool vuart_enabled = false; > + uint32_t vuart_irq, virtio_irq; > + bool vuart_enabled = false, virtio_enabled = false; > > /* > * If pl011 vuart is enabled then increment the nr_spis to allow allocation > @@ -40,6 +44,17 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, > vuart_enabled = true; > } > > + /* > + * XXX: Handle properly virtio > + * A proper solution would be the toolstack to allocate the interrupts > + * used by each virtio backend and let the backend now which one is used > + */ > + if (libxl_defbool_val(d_config->b_info.arch_arm.virtio)) { > + nr_spis += (GUEST_VIRTIO_MMIO_SPI - 32) + 1; > + virtio_irq = GUEST_VIRTIO_MMIO_SPI; > + virtio_enabled = true; > + } > + > for (i = 0; i < d_config->b_info.num_irqs; i++) { > uint32_t irq = d_config->b_info.irqs[i]; > uint32_t spi; > @@ -59,6 +74,12 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, > return ERROR_FAIL; > } > > + /* The same check as for vpl011 */ > + if (virtio_enabled && irq == virtio_irq) { > + LOG(ERROR, "Physical IRQ %u conflicting with virtio SPI\n", irq); > + return ERROR_FAIL; > + } > + > if (irq < 32) > continue; > > @@ -68,10 +89,6 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, > nr_spis = spi + 1; > } > > - > - /* XXX: Handle properly virtio */ > - nr_spis = 1; > - > LOG(DEBUG, "Configure the domain"); > > config->arch.nr_spis = nr_spis; > @@ -663,10 +680,6 @@ static int make_vpl011_uart_node(libxl__gc *gc, void *fdt, > return 0; > } > > -#define GUEST_VIRTIO_MMIO_BASE xen_mk_ullong(0x02000000) > -#define GUEST_VIRTIO_MMIO_SIZE xen_mk_ullong(0x200) > -#define GUEST_VIRTIO_MMIO_SPI 33 > - > static int make_virtio_mmio_node(libxl__gc *gc, void *fdt) > { > int res; > -- > 2.7.4 > From xen-devel-bounces@lists.xenproject.org Tue Aug 04 23:23:15 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 23:23:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k36H5-0001pQ-Nb; Tue, 04 Aug 2020 23:23:15 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k36H4-0001oA-F6 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 23:23:14 +0000 X-Inumbo-ID: 0df81675-9523-43c0-b1ac-bd6fd599ce42 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0df81675-9523-43c0-b1ac-bd6fd599ce42; Tue, 04 Aug 2020 23:23:13 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 09CCA2073E; Tue, 4 Aug 2020 23:23:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596583393; bh=VhaC1sGLgYUZcmdAf8S9RVBpxG95QFFD7HAMearY5OA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=os4+pSx8KfmCnGijhrrvFmi1ftSEk3edYgtSTnDIlUm/EC4ZOhmEoCTyXAkE5gDuJ Dncivx6CK34UgLKqHpjB4vXa+e/7pfEXTZ8aUmrlpTp8hwBHzb8rIRApDcFfDb0sln Pg71iVRnrFt0UHkRvoxtKHqGMWGm4/jLiKi4rvKQ= Date: Tue, 4 Aug 2020 16:23:12 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Oleksandr Tyshchenko Subject: Re: [RFC PATCH V1 10/12] libxl: Add support for virtio-disk configuration In-Reply-To: <1596478888-23030-11-git-send-email-olekstysh@gmail.com> Message-ID: References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-11-git-send-email-olekstysh@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Ian Jackson , Oleksandr Tyshchenko , Anthony PERARD , xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Mon, 3 Aug 2020, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > This patch adds basic support for configuring and assisting virtio-disk > backend (emualator) which is intended to run out of Qemu and could be run > in any domain. > > Xenstore was chosen as a communication interface for the emulator running > in non-toolstack domain to be able to get configuration either by reading > Xenstore directly or by receiving command line parameters (an updated 'xl devd' > running in the same domain would read Xenstore beforehand and call backend > executable with the required arguments). > > An example of domain configuration (two disks are assigned to the guest, > the latter is in readonly mode): > > vdisk = [ 'backend=DomD, disks=rw:/dev/mmcblk0p3;ro:/dev/mmcblk1p3' ] > > Where per-disk Xenstore entries are: > - filename and readonly flag (configured via "vdisk" property) > - base and irq (allocated dynamically) > > Besides handling 'visible' params described in configuration file, > patch also allocates virtio-mmio specific ones for each device and > writes them into Xenstore. virtio-mmio params (irq and base) are > unique per guest domain, they allocated at the domain creation time > and passed through to the emulator. Each VirtIO device has at least > one pair of these params. > > TODO: > 1. An extra "virtio" property could be removed. > 2. Update documentation. > > Signed-off-by: Oleksandr Tyshchenko > --- > tools/libxl/Makefile | 4 +- > tools/libxl/libxl_arm.c | 63 +++++++++++++++---- > tools/libxl/libxl_create.c | 1 + > tools/libxl/libxl_internal.h | 1 + > tools/libxl/libxl_types.idl | 15 +++++ > tools/libxl/libxl_types_internal.idl | 1 + > tools/libxl/libxl_virtio_disk.c | 109 +++++++++++++++++++++++++++++++++ > tools/xl/Makefile | 2 +- > tools/xl/xl.h | 3 + > tools/xl/xl_cmdtable.c | 15 +++++ > tools/xl/xl_parse.c | 115 +++++++++++++++++++++++++++++++++++ > tools/xl/xl_virtio_disk.c | 46 ++++++++++++++ > 12 files changed, 360 insertions(+), 15 deletions(-) > create mode 100644 tools/libxl/libxl_virtio_disk.c > create mode 100644 tools/xl/xl_virtio_disk.c > > diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile > index 38cd43a..df94b13 100644 > --- a/tools/libxl/Makefile > +++ b/tools/libxl/Makefile > @@ -141,7 +141,9 @@ LIBXL_OBJS = flexarray.o libxl.o libxl_create.o libxl_dm.o libxl_pci.o \ > libxl_vtpm.o libxl_nic.o libxl_disk.o libxl_console.o \ > libxl_cpupool.o libxl_mem.o libxl_sched.o libxl_tmem.o \ > libxl_9pfs.o libxl_domain.o libxl_vdispl.o \ > - libxl_pvcalls.o libxl_vsnd.o libxl_vkb.o $(LIBXL_OBJS-y) > + libxl_pvcalls.o libxl_vsnd.o libxl_vkb.o \ > + libxl_virtio_disk.o $(LIBXL_OBJS-y) > + > LIBXL_OBJS += libxl_genid.o > LIBXL_OBJS += _libxl_types.o libxl_flask.o _libxl_types_internal.o > > diff --git a/tools/libxl/libxl_arm.c b/tools/libxl/libxl_arm.c > index 4f748e3..469a8b0 100644 > --- a/tools/libxl/libxl_arm.c > +++ b/tools/libxl/libxl_arm.c > @@ -13,6 +13,12 @@ > #define GUEST_VIRTIO_MMIO_SIZE xen_mk_ullong(0x200) > #define GUEST_VIRTIO_MMIO_SPI 33 > > +#ifndef container_of > +#define container_of(ptr, type, member) ({ \ > + typeof( ((type *)0)->member ) *__mptr = (ptr); \ > + (type *)( (char *)__mptr - offsetof(type,member) );}) > +#endif > + > static const char *gicv_to_string(libxl_gic_version gic_version) > { > switch (gic_version) { > @@ -44,14 +50,32 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, > vuart_enabled = true; > } > > - /* > - * XXX: Handle properly virtio > - * A proper solution would be the toolstack to allocate the interrupts > - * used by each virtio backend and let the backend now which one is used > - */ > if (libxl_defbool_val(d_config->b_info.arch_arm.virtio)) { > - nr_spis += (GUEST_VIRTIO_MMIO_SPI - 32) + 1; > + uint64_t virtio_base; > + libxl_device_virtio_disk *virtio_disk; > + > + virtio_base = GUEST_VIRTIO_MMIO_BASE; > virtio_irq = GUEST_VIRTIO_MMIO_SPI; > + > + if (!d_config->num_virtio_disks) { > + LOG(ERROR, "Virtio is enabled, but no Virtio devices present\n"); > + return ERROR_FAIL; > + } > + virtio_disk = &d_config->virtio_disks[0]; > + > + for (i = 0; i < virtio_disk->num_disks; i++) { > + virtio_disk->disks[i].base = virtio_base; > + virtio_disk->disks[i].irq = virtio_irq; > + > + LOG(DEBUG, "Allocate Virtio MMIO params: IRQ %u BASE 0x%"PRIx64, > + virtio_irq, virtio_base); > + > + virtio_irq ++; > + virtio_base += GUEST_VIRTIO_MMIO_SIZE; > + } > + virtio_irq --; > + > + nr_spis += (virtio_irq - 32) + 1; It looks like it is an interrupt per device, which could lead to quite a few of them being allocated. The issue is that today we don't really handle virtual interrupts different from physical interrupts in Xen. So, if we end up allocating let's say 6 virtio interrupts for a domain, the chance of a clash with a physical interrupt of a passthrough device is real. I am not entirely sure how to solve it, but these are a few ideas: - choosing virtio interrupts that are less likely to conflict (maybe > 1000) - make the virtio irq (optionally) configurable so that a user could override the default irq and specify one that doesn't conflict - implementing support for virq != pirq (even the xl interface doesn't allow to specify the virq number for passthrough devices, see "irqs") From xen-devel-bounces@lists.xenproject.org Tue Aug 04 23:23:24 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 23:23:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k36HE-0001sB-0U; Tue, 04 Aug 2020 23:23:24 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k36HC-0001rm-Gn for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 23:23:22 +0000 X-Inumbo-ID: eb4875ce-fcfe-48c7-96bf-150906aea421 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id eb4875ce-fcfe-48c7-96bf-150906aea421; Tue, 04 Aug 2020 23:23:22 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 283EB2073E; Tue, 4 Aug 2020 23:23:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596583401; bh=Ey9+1CdkZ+XZ6lcXk7hQ6Np+Ap3ZTgAwJFD9LKmfTY8=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=rVBS4T8w8ATJdRgP7xazg4QONFEdi9ALNGbkmeGNGFnOKgkrGK4CIfr/+JJNiM+g0 /GALs+GN7IclAoL75vGL4/UERPztygHx48vFaI7YLD4wTTkUxurAyv4U7zkfg1BGuU Tk2q72UCB8Fhrkl+TX0lDc3h7t/Co0U3Lb3JsBFc= Date: Tue, 4 Aug 2020 16:23:20 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Oleksandr Tyshchenko Subject: Re: [RFC PATCH V1 11/12] libxl: Insert "dma-coherent" property into virtio-mmio device node In-Reply-To: <1596478888-23030-12-git-send-email-olekstysh@gmail.com> Message-ID: References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-12-git-send-email-olekstysh@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Ian Jackson , Oleksandr Tyshchenko , Anthony PERARD , xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Mon, 3 Aug 2020, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > Without "dma-coherent" property present in virtio-mmio device node, > guest assumes it is non-coherent and making non-cacheable accesses > to the vring when the DMA API is used for vring operations. > But virtio-mmio device which runs at the host size is making cacheable > accesses to vring. This all may result in a loss of coherency between > the guest and host. > > With this patch we can avoid modifying guest at all, otherwise we > need to force VirtIO framework to not use DMA API for vring operations. > > Signed-off-by: Oleksandr Tyshchenko This should also be folded in the first patch for libxl > --- > tools/libxl/libxl_arm.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tools/libxl/libxl_arm.c b/tools/libxl/libxl_arm.c > index 469a8b0..a68fb14 100644 > --- a/tools/libxl/libxl_arm.c > +++ b/tools/libxl/libxl_arm.c > @@ -726,6 +726,9 @@ static int make_virtio_mmio_node(libxl__gc *gc, void *fdt, > res = fdt_property_interrupts(gc, fdt, &intr, 1); > if (res) return res; > > + res = fdt_property(fdt, "dma-coherent", NULL, 0); > + if (res) return res; > + > res = fdt_end_node(fdt); > if (res) return res; > > -- > 2.7.4 > From xen-devel-bounces@lists.xenproject.org Tue Aug 04 23:42:42 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2020 23:42:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k36Zl-0003sK-M6; Tue, 04 Aug 2020 23:42:33 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k36Zk-0003sF-Al for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 23:42:32 +0000 X-Inumbo-ID: 39487739-6e95-4ca9-9d6c-7fc734a5aa12 Received: from smtp-fw-9102.amazon.com (unknown [207.171.184.29]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 39487739-6e95-4ca9-9d6c-7fc734a5aa12; Tue, 04 Aug 2020 23:42:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1596584552; x=1628120552; h=date:from:to:cc:message-id:references:mime-version: in-reply-to:subject; bh=/JZsLbScAtVllbk3M4EYC9jSC+EH8BJFD7YNLkO2jbw=; b=tZ+cW1kD66MnZO70spMRdN6kvq3IO2uJaNGajKzQxzCk4aU1OmlSzFna sfyxzPwqIbvvSMDuO8Ij8bWRLjex8B7/S34LdCZzxQJSnKGJd65LGgdTQ GiUMgRsJJfREuHMk6sq8AB1o/FbhNu0WmrkFa7aBhaajSVgmj7ZO2OPen 8=; IronPort-SDR: tXSAvE3I+eAbNDPDnUOFaCSbmANsG665E5E2LDRc5x+gN2ZBKiLpEWpXlkrOemTAkQzeu7PQUy xDAgL7lVT3Tg== X-IronPort-AV: E=Sophos;i="5.75,435,1589241600"; d="scan'208";a="65620285" Subject: Re: [PATCH v2 01/11] xen/manage: keep track of the on-going suspend mode Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-2c-1968f9fa.us-west-2.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-9102.sea19.amazon.com with ESMTP; 04 Aug 2020 23:42:18 +0000 Received: from EX13MTAUWA001.ant.amazon.com (pdx4-ws-svc-p6-lb7-vlan3.pdx.amazon.com [10.170.41.166]) by email-inbound-relay-2c-1968f9fa.us-west-2.amazon.com (Postfix) with ESMTPS id 5A165A258A; Tue, 4 Aug 2020 23:42:11 +0000 (UTC) Received: from EX13D10UWA002.ant.amazon.com (10.43.160.228) by EX13MTAUWA001.ant.amazon.com (10.43.160.58) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 4 Aug 2020 23:42:02 +0000 Received: from EX13MTAUWA001.ant.amazon.com (10.43.160.58) by EX13D10UWA002.ant.amazon.com (10.43.160.228) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 4 Aug 2020 23:42:01 +0000 Received: from dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com (172.22.96.68) by mail-relay.amazon.com (10.43.160.118) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 4 Aug 2020 23:42:01 +0000 Received: by dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com (Postfix, from userid 4335130) id 935F940362; Tue, 4 Aug 2020 23:42:01 +0000 (UTC) Date: Tue, 4 Aug 2020 23:42:01 +0000 From: Anchal Agarwal To: Boris Ostrovsky Message-ID: <20200804234201.GA23820@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> References: <20200721000348.GA19610@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> <408d3ce9-2510-2950-d28d-fdfe8ee41a54@oracle.com> <20200722180229.GA32316@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> <20200723225745.GB32316@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> <66a9b838-70ed-0807-9260-f2c31343a081@oracle.com> <20200730230634.GA17221@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> <53b577a3-6af9-5587-7e47-485be38b3653@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <53b577a3-6af9-5587-7e47-485be38b3653@oracle.com> User-Agent: Mutt/1.5.21 (2010-09-15) Precedence: Bulk X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: x86@kernel.org, len.brown@intel.com, peterz@infradead.org, benh@kernel.crashing.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, pavel@ucw.cz, hpa@zytor.com, Stefano Stabellini , eduval@amazon.com, mingo@redhat.com, xen-devel@lists.xenproject.org, sblbir@amazon.com, axboe@kernel.dk, konrad.wilk@oracle.com, bp@alien8.de, tglx@linutronix.de, jgross@suse.com, netdev@vger.kernel.org, linux-pm@vger.kernel.org, rjw@rjwysocki.net, kamatam@amazon.com, vkuznets@redhat.com, davem@davemloft.net, dwmw@amazon.co.uk, roger.pau@citrix.com Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Fri, Jul 31, 2020 at 10:13:48AM -0400, Boris Ostrovsky wrote: > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. > > > > On 7/30/20 7:06 PM, Anchal Agarwal wrote: > > On Mon, Jul 27, 2020 at 06:08:29PM -0400, Boris Ostrovsky wrote: > >> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. > >> > >> > >> > >> On 7/24/20 7:01 PM, Stefano Stabellini wrote: > >>> Yes, it does, thank you. I'd rather not introduce unknown regressions so > >>> I would recommend to add an arch-specific check on registering > >>> freeze/thaw/restore handlers. Maybe something like the following: > >>> > >>> #ifdef CONFIG_X86 > >>> .freeze = blkfront_freeze, > >>> .thaw = blkfront_restore, > >>> .restore = blkfront_restore > >>> #endif > >>> > >>> > >>> maybe Boris has a better suggestion on how to do it > >> > >> An alternative might be to still install pm notifier in > >> drivers/xen/manage.c (I think as result of latest discussions we decided > >> we won't need it) and return -ENOTSUPP for ARM for > >> PM_HIBERNATION_PREPARE and friends. Would that work? > >> > > I think the question here is for registering driver specific freeze/thaw/restore > > callbacks for x86 only. I have dropped the pm_notifier in the v3 still pending > > testing. So I think just registering driver specific callbacks for x86 only is a > > good option. What do you think? > > > I suggested using the notifier under assumption that if it returns an > error then that will prevent callbacks to be called because hibernation > will be effectively disabled. But I haven't looked at PM code so I don't > know whether this is actually the case. > I think this could be done. PM_HIBERNATION_PREPARE could return -ENOTSUPP for arm and pvh dom0 when the notifier call chain is invoked for this case in hibernate(). This will then be an empty notifier just for checking two usecases. Also, for pvh dom0, the earlier code didn't register any notifier, with this approach you are suggesting setup the notifier for hvm/pvh dom0 and arm but fail during notifier call chain during PM_HIBERNATION_PREPARE ? I think still getting rid of suspend mode that was earlier a part of this notifier is a good idea as it seems redundant as you pointed out earlier. > > The advantage of doing it in the notifier is that instead of adding > ifdefs to each driver you will be able to prevent callbacks from a > single place. Plus you can use this do disable hibernation for PVH dom0 > as well. > > > > -boris > Anchal > > From xen-devel-bounces@lists.xenproject.org Wed Aug 05 02:23:40 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 02:23:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k395E-0006C7-Bh; Wed, 05 Aug 2020 02:23:12 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k395E-0006C2-0V for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 02:23:12 +0000 X-Inumbo-ID: 64534fcf-8e12-4b24-97c3-19bdc9cd2ae2 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 64534fcf-8e12-4b24-97c3-19bdc9cd2ae2; Wed, 05 Aug 2020 02:23:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=L9YiSCxasrHXo4r8FXmfi/l3y9E0cLur7b4gLBK2+yk=; b=LqRZUvdy9UAesZqxrUtKu97I/ TkaW7kjgxe+ZopyENyosq9nVI2Df521lvUB5J/xLlxGUuYwoo/ZDJ/HMyF0X2LNPNPVraBlrJNeOo Slv/ePh2DS6fh6z55QfmHGvWLFfi+5FWlleOtm0EVDQ6GJ/dmAy3y9it3nimDdtgFFqQc=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k395C-0006P7-IM; Wed, 05 Aug 2020 02:23:10 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k395C-0007oD-5p; Wed, 05 Aug 2020 02:23:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k395C-0001gE-59; Wed, 05 Aug 2020 02:23:10 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 152456: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-qemuu-nested-intel:xen-boot/l1:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-amd:xen-boot/l1:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:windows-install:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:windows-install:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:windows-install:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:windows-install:fail:regression qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=5c1c3e4f02e458cf280c677c817ae4fd1ed9bf10 X-Osstest-Versions-That: qemuu=9e3903136d9acde2fb2dd9e967ba928050a6cb4a From: osstest service owner Date: Wed, 05 Aug 2020 02:23:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152456 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/152456/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 14 xen-boot/l1 fail REGR. vs. 151065 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 10 debian-hvm-install fail REGR. vs. 151065 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 10 debian-hvm-install fail REGR. vs. 151065 test-amd64-amd64-qemuu-nested-amd 14 xen-boot/l1 fail REGR. vs. 151065 test-amd64-amd64-xl-qemuu-win7-amd64 10 windows-install fail REGR. vs. 151065 test-amd64-amd64-xl-qemuu-ws16-amd64 10 windows-install fail REGR. vs. 151065 test-amd64-i386-xl-qemuu-ws16-amd64 10 windows-install fail REGR. vs. 151065 test-amd64-i386-xl-qemuu-win7-amd64 10 windows-install fail REGR. vs. 151065 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 14 saverestore-support-check fail like 151065 test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail like 151065 test-amd64-i386-xl-pvshim 12 guest-start fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass version targeted for testing: qemuu 5c1c3e4f02e458cf280c677c817ae4fd1ed9bf10 baseline version: qemuu 9e3903136d9acde2fb2dd9e967ba928050a6cb4a Last test of basis 151065 2020-06-12 22:27:51 Z 53 days Failing since 151101 2020-06-14 08:32:51 Z 51 days 71 attempts Testing same since 152456 2020-08-04 05:04:20 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Aaron Lindsay Ahmed Karaman Alberto Garcia Aleksandar Markovic Aleksandar Markovic Alex Bennée Alex Richardson Alex Williamson Alexander Boettcher Alexander Bulekov Alexander Duyck Alexandre Mergnat Alexey Kardashevskiy Alexey Krasikov Alistair Francis Allan Peramaki Andrea Bolognani Andreas Schwab Andrew Andrew Jones Andrew Melnychenko Andrey Shinkevich Ani Sinha Anthony PERARD Antoine Damhet Ard Biesheuvel Artyom Tarasenko Atish Patra Aurelien Jarno Babu Moger BALATON Zoltan Basil Salman Basil Salman Beata Michalska Bin Meng Bin Meng Bruce Rogers Cameron Esfahani Catherine A. Frederick Cathy Zhang Chen Gang Chenyi Qiang Christian Borntraeger Christian Ehrhardt Christophe de Dinechin Chuan Zheng Cindy Lu Claudio Fontana Cleber Rosa Colin Xu Corey Minyard Cornelia Huck Cédric Le Goater Daniel P. Berrange Daniel P. Berrangé Daniele Buono David Carlier David Edmondson David Gibson David Hildenbrand Denis V. Lunev Derek Su Dongjiu Geng Dr. David Alan Gilbert Ed Robbins Edgar E. Iglesias Eduardo Habkost Emilio G. Cota Eric Auger Eric Blake Eric Farman Erik Smit erik-smit Evgeny Yakovlev fangying Farhan Ali Filip Bozuta Finn Thain Frank Chang Geoffrey McRae Gerd Hoffmann Giuseppe Musacchio Greg Kurz Guenter Roeck Gustavo Romero Halil Pasic Havard Skinnemoen Helge Deller Hogan Wang Hogan Wang Howard Spoelstra Huacai Chen Huacai Chen Ian Jiang Igor Mammedov Jan Kiszka Jan Kiszka Janne Grunau Janosch Frank Jason Andryuk Jason Wang Jay Zhou Jean-Christophe Dubois Jessica Clarke Jiaxun Yang Jingqi Liu John Paul Adrian Glaubitz John Snow Jon Doron Joseph Myers Josh DuBois Josh DuBois Josh Kunz Juan Quintela Julio Faracco Kaige Li Keqian Zhu Kevin Wolf Klaus Jensen Klaus Jensen KONRAD Frederic Laszlo Ersek Laurent Vivier Laurent Vivier Leif Lindholm Leonid Bloch Leonid Bloch Li Feng Li Qiang Li Qiang Liao Pingfang lichun Lijun Pan Like Xu Lingfeng Yang Lingshan zhu Liran Alon Liu Yi L LIU Zhiwei Luc Michel Lukas Straub Luwei Kang Maciej S. Szmigiero Magnus Damm Mao Zhongyi Marc-André Lureau Marcelo Tosatti Marek Marczykowski-Górecki Mario Smarduch Mark Cave-Ayland Markus Armbruster Masahiro Yamada Matus Kysel Mauro Matteo Cascella Max Filippov Max Reitz Maxim Levitsky Maxime Coquelin Menno Lageman Michael Rolnik Michael Roth Michael S. Tsirkin Michael Tokarev Michal Privoznik Michele Denber Niek Linnenbank Nir Soffer Nir Soffer Olaf Hering Pan Nengyuan Paolo Bonzini Paul Durrant Paul Zimmerman Pavel Dovgalyuk Pavel Dovgalyuk Peter Krempa Peter Maydell Peter Turschmid Peter Xu Philippe Mathieu-Daude Philippe Mathieu-Daudé Philippe Mathieu-Daudé Prasad J Pandit Radoslaw Biernacki Raphael Norwitz Reza Arbab Richard Henderson Richard W.M. Jones Riku Voipio Robert Foley Roman Bolshakov Roman Kagan Roman Kagan Sai Pavan Boddu Sarah Harris Sebastian Rasmussen Sergio Lopez Shameer Kolothum Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Weil Sven Schnelle Tao Xu Thomas Huth Thomas Huth Tiwei Bie Tong Ho Viktor Mihajlovski Vitaly Kuznetsov Vivek Goyal Vladimir Sementsov-Ogievskiy Volker Rümelin WangBowen Wei Huang Wei Wang Wentong Wu Xiaoyao Li Xie Yongji Yi Wang Ying Fang Yoshinori Sato Yuri Benditovich Zhang Chen Zheng Chuan Zong Li jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 34831 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Aug 05 02:26:16 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 02:26:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k398C-0006Lx-1Q; Wed, 05 Aug 2020 02:26:16 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k398A-0006KH-U9 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 02:26:14 +0000 X-Inumbo-ID: dfe0c549-91a2-4b04-aa77-4addaef9ec1c Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id dfe0c549-91a2-4b04-aa77-4addaef9ec1c; Wed, 05 Aug 2020 02:26:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=+OVXF1OsOLxDTjLsEf+KM2MdWcddbrLMD01WGVAow44=; b=hFpp3nqW4mrNxufkPUbXtilQr GmFGtYFHe0zx277wVtN/qPSvLSTeT8sWaLxqw09WdVr0iZc7iM7pvkK6fqaiQcfiC/8pE4PEGDUhV 6Rtpz0BKZMrPDK/bOe8pAhPfOJDe8rt5Ewk0X8rMlTp+unLrAeTZNRlWeP43dBFb4kM64=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3984-0006Rj-Ru; Wed, 05 Aug 2020 02:26:08 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k3984-0007sh-IW; Wed, 05 Aug 2020 02:26:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k3984-0004Pm-Hq; Wed, 05 Aug 2020 02:26:08 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 152477: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=c9f9a7258dc07735e2da2b6d0b51a0218c76a51f X-Osstest-Versions-That: xen=fe49938f21c26f0ce630c69af055f927dd0ed75f From: osstest service owner Date: Wed, 05 Aug 2020 02:26:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152477 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/152477/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass version targeted for testing: xen c9f9a7258dc07735e2da2b6d0b51a0218c76a51f baseline version: xen fe49938f21c26f0ce630c69af055f927dd0ed75f Last test of basis 152473 2020-08-04 15:18:46 Z 0 days Testing same since 152477 2020-08-04 22:02:33 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Wei Liu jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git fe49938f21..c9f9a7258d c9f9a7258dc07735e2da2b6d0b51a0218c76a51f -> smoke From xen-devel-bounces@lists.xenproject.org Wed Aug 05 05:10:34 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 05:10:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Bgm-00044z-6r; Wed, 05 Aug 2020 05:10:08 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Bgk-0003Qd-OI for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 05:10:06 +0000 X-Inumbo-ID: 2a5dd257-5b0c-4599-890b-ce78e93c70de Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2a5dd257-5b0c-4599-890b-ce78e93c70de; Wed, 05 Aug 2020 05:09:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=d21pbA7cJlF6hqe6BbhFd4Xm5oo3S7n3i1rn7CdSM94=; b=YB0j7jeEjnBCOTzQOSqkXs41K DlIKwPYuMB5+Q7aMgzHczNWtNDQcyMY2hyAi0HfB2zdm/nNdXFQ9cfkMuB9t+m8bAY1sblUuSnPTY TGugSHCfhZ/eZ5SPQBlOoKEJ2cIHB9ciTA8lfNSkmbtZ62cfm1ujM0M8TZoaShp4z4InY=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3BgZ-00023P-Su; Wed, 05 Aug 2020 05:09:55 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k3BgZ-0007ei-EP; Wed, 05 Aug 2020 05:09:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k3BgZ-0004Ud-DK; Wed, 05 Aug 2020 05:09:55 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 152461: regressions - FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking X-Osstest-Versions-This: xen=9909532113692020c1b50eb974cac47d4ea10e69 X-Osstest-Versions-That: xen=81fd0d3ca4b2cd309403c6e8da662c325dd35750 From: osstest service owner Date: Wed, 05 Aug 2020 05:09:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152461 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/152461/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 17 guest-start/debian.repeat fail REGR. vs. 152418 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail like 152418 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail like 152418 test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail like 152418 test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail like 152418 test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail like 152418 test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 152418 test-armhf-armhf-libvirt 14 saverestore-support-check fail like 152418 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail like 152418 test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail like 152418 test-amd64-i386-xl-pvshim 12 guest-start fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass version targeted for testing: xen 9909532113692020c1b50eb974cac47d4ea10e69 baseline version: xen 81fd0d3ca4b2cd309403c6e8da662c325dd35750 Last test of basis 152418 2020-08-03 11:11:04 Z 1 days Testing same since 152461 2020-08-04 07:50:21 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 9909532113692020c1b50eb974cac47d4ea10e69 Author: Jan Beulich Date: Mon Aug 3 16:27:22 2020 +0200 x86emul: avoid assembler warning about .type not taking effect in test harness gcc re-orders top level blocks by default when optimizing. This re-ordering results in all our .type directives to get emitted to the assembly file first, followed by gcc's. The assembler warns about attempts to change the type of a symbol when it was already set (and when there's no intervening setting to "notype"). Signed-off-by: Jan Beulich Acked-by: Andrew Cooper (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Wed Aug 05 06:35:32 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 06:35:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3D15-0002jp-4z; Wed, 05 Aug 2020 06:35:11 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3D13-0002jj-N7 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 06:35:09 +0000 X-Inumbo-ID: 94638f25-a9e6-4833-8e03-38693b438596 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 94638f25-a9e6-4833-8e03-38693b438596; Wed, 05 Aug 2020 06:35:08 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 17F1AAC7C; Wed, 5 Aug 2020 06:35:24 +0000 (UTC) Subject: Re: [PATCH] libxl: avoid golang building without CONFIG_GOLANG=y To: Nick Rosbrook References: <20200804141639.k2tpoqy7jj34gcm6@liuwe-devbox-debian-v2> <0deed4c6-ca87-09d3-a19c-ac0c00003cb7@suse.com> <20200804155043.vq7aupbrvmmcgzlv@liuwe-devbox-debian-v2> <12790d2b-020d-b6fe-4924-2233a4e93d83@suse.com> <20200804155707.rrtzkksrle2nojbj@liuwe-devbox-debian-v2> <43f706e4-0292-5758-eb19-9fbb99b1337e@suse.com> From: Jan Beulich Message-ID: <6e83d698-64bb-68f0-b046-b20bf6db1c56@suse.com> Date: Wed, 5 Aug 2020 08:35:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony Perard , "xen-devel@lists.xenproject.org" , Ian Jackson , George Dunlap , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 04.08.2020 18:41, Nick Rosbrook wrote: > On Tue, Aug 4, 2020 at 12:02 PM Jan Beulich wrote: >> >> On 04.08.2020 17:57, Wei Liu wrote: >>> On Tue, Aug 04, 2020 at 05:53:49PM +0200, Jan Beulich wrote: >>>> On 04.08.2020 17:50, Wei Liu wrote: >>>>> On Tue, Aug 04, 2020 at 05:30:40PM +0200, Jan Beulich wrote: >>>>>> On 04.08.2020 17:22, Nick Rosbrook wrote: >>>>>>> On Tue, Aug 4, 2020 at 10:17 AM Wei Liu wrote: >>>>>>>> >>>>>>>> On Mon, Aug 03, 2020 at 10:06:32AM +0200, Jan Beulich wrote: >>>>>>>>> While this doesn't address the real problem I've run into (attempting to >>>>>>>>> update r/o source files), not recursing into tools/golang/xenlight/ is >>>>>>>>> enough to fix the build for me for the moment. I don't currently see why >>>>>>>>> 60db5da62ac0 ("libxl: Generate golang bindings in libxl Makefile") found >>>>>>>>> it necessary to invoke this build step unconditionally. >>>>>>>>> >>>>>>>> >>>>>>>> Perhaps an oversight? >>>>>>> >>>>>>> This is intentional, and I think the commit message in 60db5da62ac0 >>>>>>> ("libxl: Generate golang bindings in libxl Makefile") explains the >>>>>>> reasoning well. But, to summarize, CONFIG_GOLANG is only used to >>>>>>> control the bindings actually being compiled (i.e. with `go build`). >>>>>>> However, we always want the code generation script >>>>>>> (tools/golang/xenlight/gengotypes.py) to run if e.g. >>>>>>> tools/libxl/libxl_types.idl is modified. >>>>>>> >>>>>>> I hope this helps. >>>>>> >>>>>> Not really - I'm still not seeing the "why" behind this behavior. I.e. >>>>>> why build _anything_ that's not used further in the build, nor getting >>>>>> installed? Also if (aiui) you effectively object to the change that >>>>>> Wei has given his ack for, would you mind providing an alternative fix >>>>>> for the problem at hand? >>>>> >>>>> Is the solution here to make the target check if IDL definition file is >>>>> actually changed before regenerating the bindings? >>>> >>>> I don't know - Nick? A move-if-changed based approach would likely deal >>>> with the r/o source problem at the same time (at least until such time >>>> where the directory containing the file(s) is also r/o). >>> >>> To make sure Nick and I understand your use case correct -- "r/o source >>> problem" means you want the tools source to be read-only? But you would >>> be fine recursing into tools directory to build all the libraries and >>> programs? >> >> Yes - until we support out-of-tree builds, nothing more can be expected >> to work. >> > > Jan - is the problem specifically that a fresh clone, or `git > checkout`, etc. changes file timestamps in a way that triggers make to > rebuild those targets? Afaict it's not deterministic in which order files get created / updated, and hence the generated files may or may not appear older than their dependencies. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 07:02:01 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 07:02:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3DQt-0005La-Aq; Wed, 05 Aug 2020 07:01:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3DQs-0005LV-Dx for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 07:01:50 +0000 X-Inumbo-ID: 34209da2-a50b-4022-8269-d29ea3474df0 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 34209da2-a50b-4022-8269-d29ea3474df0; Wed, 05 Aug 2020 07:01:49 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id BD26DAC37; Wed, 5 Aug 2020 07:02:04 +0000 (UTC) Subject: Re: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common To: Stefano Stabellini References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-2-git-send-email-olekstysh@gmail.com> <000c01d66a33$2bd56510$83802f30$@xen.org> <9f83a7ed-ca97-449f-c7b9-a1140644abe9@gmail.com> From: Jan Beulich Message-ID: <2ab4c567-8efa-1b9d-ab00-4ea7e1ab323e@suse.com> Date: Wed, 5 Aug 2020 09:01:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: 'Kevin Tian' , Julien Grall , 'Wei Liu' , paul@xen.org, 'Andrew Cooper' , 'Ian Jackson' , 'George Dunlap' , 'Tim Deegan' , Oleksandr , 'Oleksandr Tyshchenko' , 'Julien Grall' , 'Jun Nakajima' , xen-devel@lists.xenproject.org, =?UTF-8?B?J1JvZ2VyIFBhdSBNb25uw6kn?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 04.08.2020 21:11, Stefano Stabellini wrote: >> The point of the check isn't to determine whether to wait, but >> what to do after having waited. Reads need a retry round through >> the emulator (to store the result in the designated place), >> while writes don't have such a requirement (and hence guest >> execution can continue immediately in the general case). > > The x86 code looks like this: > > rc = hvm_send_ioreq(s, &p, 0); > if ( rc != X86EMUL_RETRY || currd->is_shutting_down ) > vio->io_req.state = STATE_IOREQ_NONE; > else if ( !hvm_ioreq_needs_completion(&vio->io_req) ) > rc = X86EMUL_OKAY; > > Basically hvm_send_ioreq is expected to return RETRY. > Then, if it is a PIO write operation only, it is turned into OKAY right > away. Otherwise, rc stays as RETRY. > > So, normally, hvmemul_do_io is expected to return RETRY, because the > emulator is not done yet. Am I understanding the code correctly? "The emulator" unfortunately is ambiguous here: Do you mean qemu (or whichever else ioreq server) or the x86 emulator inside Xen? There are various conditions leading to RETRY. As far as hvm_send_ioreq() goes, it is expected to return RETRY whenever some sort of response is to be expected (the most notable exception being the hvm_send_buffered_ioreq() path), or when submitting the request isn't possible in the first place. > If so, who is handling RETRY on x86? It tried to follow the call chain > but ended up in the x86 emulator and got lost :-) Not sure I understand the question correctly, but I'll try an answer nevertheless: hvm_send_ioreq() arranges for the vCPU to be put to sleep (prepare_wait_on_xen_event_channel()). Once the event channel got signaled (and vCPU unblocked), hvm_do_resume() -> handle_hvm_io_completion() -> hvm_wait_for_io() then check whether the wait reason has been satisfied (wait_on_xen_event_channel()), and ... > At some point later, after the emulator (QEMU) has completed the > request, handle_hvm_io_completion gets called which ends up calling > handle_mmio() finishing the job on the Xen side too. ..., as you say, handle_hvm_io_completion() invokes the retry of the original operation (handle_mmio() or handle_pio() in particular) if need be. What's potentially confusing is that there's a second form of retry, invoked by the x86 insn emulator itself when it needs to split complex insns (the repeated string insns being the most important example). This results in actually exiting back to guest context without having advanced rIP, but after having updated other register state suitably (to express the progress made so far). Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 07:05:17 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 07:05:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3DUC-0005SS-QN; Wed, 05 Aug 2020 07:05:16 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3DUA-0005SL-PR for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 07:05:14 +0000 X-Inumbo-ID: bf9c5f1b-4e7c-440e-88cd-5eb7b69d1534 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id bf9c5f1b-4e7c-440e-88cd-5eb7b69d1534; Wed, 05 Aug 2020 07:05:11 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1814AAC37; Wed, 5 Aug 2020 07:05:27 +0000 (UTC) Subject: Re: [RFC PATCH V1 04/12] xen/arm: Introduce arch specific bits for IOREQ/DM features To: Stefano Stabellini References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-5-git-send-email-olekstysh@gmail.com> From: Jan Beulich Message-ID: Date: Wed, 5 Aug 2020 09:05:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Julien Grall , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Oleksandr Tyshchenko , Julien Grall , xen-devel@lists.xenproject.org, Daniel De Graaf , Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 05.08.2020 01:22, Stefano Stabellini wrote: > On Mon, 3 Aug 2020, Oleksandr Tyshchenko wrote: >> --- a/xen/include/asm-arm/p2m.h >> +++ b/xen/include/asm-arm/p2m.h >> @@ -385,10 +385,11 @@ static inline int set_foreign_p2m_entry(struct domain *d, unsigned long gfn, >> mfn_t mfn) >> { >> /* >> - * NOTE: If this is implemented then proper reference counting of >> - * foreign entries will need to be implemented. >> + * XXX: handle properly reference. It looks like the page may not always >> + * belong to d. > > Just as a reference, and without taking away anything from the comment, > I think that QEMU is doing its own internal reference counting for these > mappings. Which of course in no way replaces the need to do proper ref counting in Xen. (Just FAOD, as I'm not sure why you've said what you've said.) Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 08:34:06 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 08:34:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Erx-0005Qy-Ad; Wed, 05 Aug 2020 08:33:53 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Erw-0005Qr-6F for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 08:33:52 +0000 X-Inumbo-ID: f8d7d757-1f74-4ba7-97ea-168ab3c9b879 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f8d7d757-1f74-4ba7-97ea-168ab3c9b879; Wed, 05 Aug 2020 08:33:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ebPJ7QKZ3SwQJZyPSfL//AJwnok9GwbuOP30WV/NUWQ=; b=lnRXONyyYZQP0yAPfsYqME1gIw wPxx5y4EHXSRlUo8LRlVOwhKlEwBXIRl5AHG+2KuUH2eC4N54+dD3DtqC/l2b3OfuZcvbSvQ5lgPu 8+KErEA8pMajTKo38vuWkZc2LjcUV5tE/B/Oiivi66Lsf9IUUXXnIJxRs8fNloaeFQm4=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Erh-0007RJ-8y; Wed, 05 Aug 2020 08:33:37 +0000 Received: from 54-240-197-228.amazon.com ([54.240.197.228] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k3Erh-0005gX-23; Wed, 05 Aug 2020 08:33:37 +0000 Subject: Re: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common To: Stefano Stabellini References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-2-git-send-email-olekstysh@gmail.com> <000c01d66a33$2bd56510$83802f30$@xen.org> <9f83a7ed-ca97-449f-c7b9-a1140644abe9@gmail.com> From: Julien Grall Message-ID: <5df97055-67f9-16cc-a274-864672d67164@xen.org> Date: Wed, 5 Aug 2020 09:33:33 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: 'Kevin Tian' , 'Jun Nakajima' , 'Wei Liu' , paul@xen.org, 'Andrew Cooper' , 'Ian Jackson' , 'George Dunlap' , 'Tim Deegan' , Oleksandr , 'Oleksandr Tyshchenko' , 'Julien Grall' , 'Jan Beulich' , xen-devel@lists.xenproject.org, =?UTF-8?B?J1JvZ2VyIFBhdSBNb25uw6kn?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Hi, On 04/08/2020 20:11, Stefano Stabellini wrote: > On Tue, 4 Aug 2020, Julien Grall wrote: >> On 04/08/2020 12:10, Oleksandr wrote: >>> On 04.08.20 10:45, Paul Durrant wrote: >>>>> +static inline bool hvm_ioreq_needs_completion(const ioreq_t *ioreq) >>>>> +{ >>>>> +    return ioreq->state == STATE_IOREQ_READY && >>>>> +           !ioreq->data_is_ptr && >>>>> +           (ioreq->type != IOREQ_TYPE_PIO || ioreq->dir != >>>>> IOREQ_WRITE); >>>>> +} >>>> I don't think having this in common code is correct. The short-cut of not >>>> completing PIO reads seems somewhat x86 specific. >> >> Hmmm, looking at the code, I think it doesn't wait for PIO writes to complete >> (not read). Did I miss anything? >> >>> Does ARM even >>>> have the concept of PIO? >>> >>> I am not 100% sure here, but it seems that doesn't have. >> >> Technically, the PIOs exist on Arm, however they are accessed the same way as >> MMIO and will have a dedicated area defined by the HW. >> >> AFAICT, on Arm64, they are only used for PCI IO Bar. >> >> Now the question is whether we want to expose them to the Device Emulator as >> PIO or MMIO access. From a generic PoV, a DM shouldn't have to care about the >> architecture used. It should just be able to request a given IOport region. >> >> So it may make sense to differentiate them in the common ioreq code as well. >> >> I had a quick look at QEMU and wasn't able to tell if PIOs and MMIOs address >> space are different on Arm as well. Paul, Stefano, do you know what they are >> doing? > > On the QEMU side, it looks like PIO (address_space_io) is used in > connection with the emulation of the "in" or "out" instructions, see > ioport.c:cpu_inb for instance. Some parts of PCI on QEMU emulate PIO > space regardless of the architecture, such as > hw/pci/pci_bridge.c:pci_bridge_initfn. > > However, because there is no "in" and "out" on ARM, I don't think > address_space_io can be accessed. Specifically, there is no equivalent > for target/i386/misc_helper.c:helper_inb on ARM. So how PCI I/O BAR are accessed? Surely, they could be used on Arm, right? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Aug 05 09:31:07 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 09:31:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Fl4-0002F5-9L; Wed, 05 Aug 2020 09:30:50 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Fl2-0002Eu-G7 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 09:30:48 +0000 X-Inumbo-ID: 6e0fff47-94e1-4858-8d70-2fa76597c762 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6e0fff47-94e1-4858-8d70-2fa76597c762; Wed, 05 Aug 2020 09:30:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596619846; h=from:mime-version:content-transfer-encoding:message-id: date:to:cc:subject:in-reply-to:references; bh=lzfvJxrHS0Et5UN/cVHgV6f2deW+qBdLKRzU9y4olOI=; b=NdHsh1E13Qo8gz695SLtvVOfWOF7otjgSv4kyqO1GO/YrXKp3zBSz8Br xv4bdv1LdJTB1Le/in/vtTkCiOovHR+MhZjsTD7X12hIBAyWT3Txc221v OlgujmFJTEsxMuYfIEVh8bOO9vjY6UTsX2kLKP/mqWuig3Pw4+HxmLn/+ 8=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: wFrC9A4r2LswraUKLm6BfTo3aXG1nTqddDLyedpxW0n5MQua+NYGBAKQ6eJaM/4R8LDM4IcaaX TcHE5GC7zGfDFYPNKGxpTqfgRAEmdNSx2/RtVT97nD7aKaOFIF2Jvji/tP7MlwHaXQqmJlnAth B5uKikGtlbdUuam2F+I27x7tHmw6ApqDlf0ak8Yr/8L3n0MpTjLTa5iuJjsAW8EJVTY7xGmrbB WFVpCcp6csVHuEEhUirtmgYqLFQ76k5Wx/kzsMOsgbAks8xkY6CG7+DxFrMNrXEgNKOIs2/+oh CUM= X-SBRS: 3.7 X-MesageID: 24092280 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,436,1589256000"; d="scan'208";a="24092280" From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-ID: <24362.31810.819871.943707@mariner.uk.xensource.com> Date: Wed, 5 Aug 2020 10:30:42 +0100 To: "paul@xen.org" Subject: RE: [PATCH v2 4/4] tools/hotplug: modify set_mtu() to inform the frontend via xenstore In-Reply-To: <002801d66a63$85fb8c10$91f2a430$@xen.org> References: <20200803124931.2678-1-paul@xen.org> <20200803124931.2678-5-paul@xen.org> <24361.17132.762055.478992@mariner.uk.xensource.com> <002001d66a51$3cd055f0$b67101d0$@xen.org> <24361.18433.500622.984594@mariner.uk.xensource.com> <002801d66a63$85fb8c10$91f2a430$@xen.org> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" , 'Paul Durrant' , 'Wei Liu' Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Paul Durrant writes ("RE: [PATCH v2 4/4] tools/hotplug: modify set_mtu() to inform the frontend via xenstore"): > > -----Original Message----- > > From: Ian Jackson ... > > Actually. > > > > This shouldn't be in the frontend at all, should it ? In general the > > backend writes to the backend and the frontend to the frontend. > > > > So maybe I need to take back my R-b of > > [PATCH v2 3/4] public/io/netif: specify MTU override node > > > > Sorry for the confusion. I seem rather undercaffienated today. > > Too late. The xenstore node has been used by Windows frontends for the best part of a decade so we can't practically change the > path. Another way would be to also modify netback to simply echo the value from backend into frontend, but that seems rather > pointless. Hmm. How does this interact with driver domains ? I think a driver domain might not have write access to this node. Is there a value we can store in it that won't break these Windows frontends, that libxl in the toolstack domain could write, before the hotplug script runs in the driver domain ? > Interestingly libxl does define an 'mtu' field for libxl_device_nic, which it sets to 1492 in libxl__device_nic_setdefault() but > never writes it into xenstore. There is even a comment: > > /* nic->mtu = */ > > in libxl__nic_from_xenstore() which implies it should have been there, but isn't. > I still think picking up the MTU from the bridge is the better way though. I agree that the default should come from the bridge. Ideally there would be a way to override it in the config. Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Wed Aug 05 09:32:32 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 09:32:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Fmh-0002MF-L4; Wed, 05 Aug 2020 09:32:31 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Fmg-0002Lg-EB for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 09:32:30 +0000 X-Inumbo-ID: 49039583-e85b-41cd-b3fe-3921b3648b06 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 49039583-e85b-41cd-b3fe-3921b3648b06; Wed, 05 Aug 2020 09:32:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nJjocjIYWMcdOhb7hGLP+yonmiIC1Un/MvbGymgJqFk=; b=6KaueVXVOK5Tm4F984/q7D6i8A h4HXvyRBnSNt56v5MwkW8FjySPzBnJPsDkJ3pHFRDM5uJXU6svBcipXOuWzjLuuWVz8iO/fj9665V PWNs2jlprIbOuyhp4CfVHOvPTNV3vlYwLrAQUIUiNcIa75KirCjTMM35NvedZEcZzlh0=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3FmQ-0000Jq-GS; Wed, 05 Aug 2020 09:32:14 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k3FmQ-0000yo-2o; Wed, 05 Aug 2020 09:32:14 +0000 Subject: Re: [RFC PATCH V1 04/12] xen/arm: Introduce arch specific bits for IOREQ/DM features To: Stefano Stabellini , Oleksandr Tyshchenko References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-5-git-send-email-olekstysh@gmail.com> From: Julien Grall Message-ID: <8e8a394c-bd2a-4444-9f4b-e022c59e0f81@xen.org> Date: Wed, 5 Aug 2020 10:32:10 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Julien Grall , Jan Beulich , xen-devel@lists.xenproject.org, Daniel De Graaf , Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Hi Stefano, On 05/08/2020 00:22, Stefano Stabellini wrote: > On Mon, 3 Aug 2020, Oleksandr Tyshchenko wrote: >> From: Oleksandr Tyshchenko >> >> This patch makes possible to forward Guest MMIO accesses >> to a device emulator on Arm and enables that support for >> Arm64. >> >> Also update XSM code a bit to let DM op be used on Arm. >> New arch DM op will be introduced in the follow-up patch. >> >> Please note, at the moment build on Arm32 is broken >> (see cmpxchg usage in hvm_send_buffered_ioreq()) if someone > > Speaking of buffered_ioreq, if I recall correctly, they were only used > for VGA-related things on x86. It looks like it is still true. > > If so, do we need it on ARM? Note that I don't think we can get rid of > it from the interface as it is baked into ioreq, but it might be > possible to have a dummy implementation on ARM. Or maybe not: looking at > xen/common/hvm/ioreq.c it looks like it would be difficult to > disentangle bufioreq stuff from the rest of the code. We possibly don't need it right now. However, this could possibly be used in the future (e.g. virtio notification doorbell). >> @@ -2275,6 +2282,16 @@ static void check_for_vcpu_work(void) >> */ >> void leave_hypervisor_to_guest(void) >> { >> +#ifdef CONFIG_IOREQ_SERVER >> + /* >> + * XXX: Check the return. Shall we call that in >> + * continue_running and context_switch instead? >> + * The benefits would be to avoid calling >> + * handle_hvm_io_completion on every return. >> + */ > > Yeah, that could be a simple and good optimization Well, it is not simple as it is sounds :). handle_hvm_io_completion() is the function in charge to mark the vCPU as waiting for I/O. So we would at least need to split the function. I wrote this TODO because I wasn't sure about the complexity of handle_hvm_io_completion(current). Looking at it again, the main complexity is the looping over the IOREQ servers. I think it would be better to optimize handle_hvm_io_completion() rather than trying to hack the context_switch() or continue_running(). [...] >> diff --git a/xen/include/asm-arm/p2m.h b/xen/include/asm-arm/p2m.h >> index 5fdb6e8..5823f11 100644 >> --- a/xen/include/asm-arm/p2m.h >> +++ b/xen/include/asm-arm/p2m.h >> @@ -385,10 +385,11 @@ static inline int set_foreign_p2m_entry(struct domain *d, unsigned long gfn, >> mfn_t mfn) >> { >> /* >> - * NOTE: If this is implemented then proper reference counting of >> - * foreign entries will need to be implemented. >> + * XXX: handle properly reference. It looks like the page may not always >> + * belong to d. > > Just as a reference, and without taking away anything from the comment, > I think that QEMU is doing its own internal reference counting for these > mappings. I am not sure how this matters here? We can't really trust the DM to do the right thing if it is not running in dom0. But, IIRC, the problem is some of the pages doesn't belong to do a domain, so it is not possible to treat them as foreign mapping (e.g. you wouldn't be able to grab a reference). This investigation was done a couple of years ago, so this may have changed in recent Xen. As a side note, I am a bit surprised to see most of my original TODOs present in the code. What is the plan to solve them? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Aug 05 09:39:25 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 09:39:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3FtG-0002Zq-BW; Wed, 05 Aug 2020 09:39:18 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3FtE-0002Zl-U4 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 09:39:16 +0000 X-Inumbo-ID: f4e3dd9e-7838-4d31-8b33-253b46ab88bd Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f4e3dd9e-7838-4d31-8b33-253b46ab88bd; Wed, 05 Aug 2020 09:39:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jRpEmS5YMER/RnQifqxP4UjBRHnj3hq0Ojyzac0TDHI=; b=OR0o3xO0cNXaAaEEexaMTFpeOQ 50ZnADrvTw5Gqy3FDhCXT61n/6hUr3hF41fPcqt90cTMVcYIqoa0SD9uXr8wq2mM+0Da1Bo1v5Ckr ADKOMztXk7HcAQ5gPjHZjsxSBMi8BUiefAzdOgHMiSMG0PTRf+7xHQbTqRR7f8oxLC5A=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Ft7-0000Sb-MO; Wed, 05 Aug 2020 09:39:09 +0000 Received: from 54-240-197-228.amazon.com ([54.240.197.228] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k3Ft7-0001Wq-AO; Wed, 05 Aug 2020 09:39:09 +0000 Subject: Re: [RFC PATCH V1 05/12] hvm/dm: Introduce xendevicemodel_set_irq_level DM op To: Stefano Stabellini , Oleksandr Tyshchenko References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-6-git-send-email-olekstysh@gmail.com> From: Julien Grall Message-ID: <00e261e0-295a-9cd8-ed11-7e3801a4eb58@xen.org> Date: Wed, 5 Aug 2020 10:39:06 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Julien Grall , Jan Beulich , xen-devel@lists.xenproject.org, Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Hi, On 05/08/2020 00:22, Stefano Stabellini wrote: > On Mon, 3 Aug 2020, Oleksandr Tyshchenko wrote: >> From: Oleksandr Tyshchenko >> >> This patch adds ability to the device emulator to notify otherend >> (some entity running in the guest) using a SPI and implements Arm >> specific bits for it. Proposed interface allows emulator to set >> the logical level of a one of a domain's IRQ lines. >> >> Please note, this is a split/cleanup of Julien's PoC: >> "Add support for Guest IO forwarding to a device emulator" >> >> Signed-off-by: Julien Grall >> Signed-off-by: Oleksandr Tyshchenko >> --- >> tools/libs/devicemodel/core.c | 18 ++++++++++++++++++ >> tools/libs/devicemodel/include/xendevicemodel.h | 4 ++++ >> tools/libs/devicemodel/libxendevicemodel.map | 1 + >> xen/arch/arm/dm.c | 22 +++++++++++++++++++++- >> xen/common/hvm/dm.c | 1 + >> xen/include/public/hvm/dm_op.h | 15 +++++++++++++++ >> 6 files changed, 60 insertions(+), 1 deletion(-) >> >> diff --git a/tools/libs/devicemodel/core.c b/tools/libs/devicemodel/core.c >> index 4d40639..30bd79f 100644 >> --- a/tools/libs/devicemodel/core.c >> +++ b/tools/libs/devicemodel/core.c >> @@ -430,6 +430,24 @@ int xendevicemodel_set_isa_irq_level( >> return xendevicemodel_op(dmod, domid, 1, &op, sizeof(op)); >> } >> >> +int xendevicemodel_set_irq_level( >> + xendevicemodel_handle *dmod, domid_t domid, uint32_t irq, >> + unsigned int level) > > It is a pity that having xen_dm_op_set_pci_intx_level and > xen_dm_op_set_isa_irq_level already we need to add a third one, but from > the names alone I don't think we can reuse either of them. The problem is not the name... > > It is very similar to set_isa_irq_level. We could almost rename > xendevicemodel_set_isa_irq_level to xendevicemodel_set_irq_level or, > better, just add an alias to it so that xendevicemodel_set_irq_level is > implemented by calling xendevicemodel_set_isa_irq_level. Honestly I am > not sure if it is worth doing it though. Any other opinions? ... the problem is the interrupt field is only 8-bit. So we would only be able to cover IRQ 0 - 255. It is not entirely clear how the existing subop could be extended without breaking existing callers. > > > But I think we should plan for not needing two calls (one to set level > to 1, and one to set it to 0): > https://marc.info/?l=xen-devel&m=159535112027405 I am not sure to understand your suggestion here? Are you suggesting to remove the 'level' parameter? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Aug 05 09:44:56 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 09:44:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Fyc-0003Qh-2l; Wed, 05 Aug 2020 09:44:50 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Fya-0003Qc-J4 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 09:44:48 +0000 X-Inumbo-ID: 64ea7f85-7265-410a-9f74-75ae43ad0366 Received: from smtp-fw-6001.amazon.com (unknown [52.95.48.154]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 64ea7f85-7265-410a-9f74-75ae43ad0366; Wed, 05 Aug 2020 09:44:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.co.uk; i=@amazon.co.uk; q=dns/txt; s=amazon201209; t=1596620687; x=1628156687; h=from:to:cc:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version:subject; bh=za7okMpA4SI+IfCgnq91XC9ou5HIclFe21JqbIWoxmw=; b=UYxjuncvyLbTdloGOwhrAYO5x5EUzZIjAxK4NdK19D9IKYXJBrARa1sR ojHNJaIA08W3ic0d/uWLW+F7Mp1xy2167nz0xlunxMnbk7qNicEzpxrq1 6muhIXlTuULz6486PXjRrO1wq5k4e+YEp5KgmGhz+la60ye2Zt3udYdQE 4=; IronPort-SDR: rI2cdBR4CUe1Dzg4XdmWXd4I4RxSrjWtpUCmhzzGh9wFvLzDKck2Us+mEXbFCSaDX50ACSYgZE KjtipuXjMsCQ== X-IronPort-AV: E=Sophos;i="5.75,436,1589241600"; d="scan'208";a="47582771" Subject: RE: [PATCH v2 4/4] tools/hotplug: modify set_mtu() to inform the frontend via xenstore Thread-Topic: [PATCH v2 4/4] tools/hotplug: modify set_mtu() to inform the frontend via xenstore Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-2a-22cc717f.us-west-2.amazon.com) ([10.43.8.6]) by smtp-border-fw-out-6001.iad6.amazon.com with ESMTP; 05 Aug 2020 09:44:46 +0000 Received: from EX13MTAUEA002.ant.amazon.com (pdx4-ws-svc-p6-lb7-vlan3.pdx.amazon.com [10.170.41.166]) by email-inbound-relay-2a-22cc717f.us-west-2.amazon.com (Postfix) with ESMTPS id 737C0A17C0; Wed, 5 Aug 2020 09:44:45 +0000 (UTC) Received: from EX13D32EUC002.ant.amazon.com (10.43.164.94) by EX13MTAUEA002.ant.amazon.com (10.43.61.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 5 Aug 2020 09:44:44 +0000 Received: from EX13D32EUC003.ant.amazon.com (10.43.164.24) by EX13D32EUC002.ant.amazon.com (10.43.164.94) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 5 Aug 2020 09:44:44 +0000 Received: from EX13D32EUC003.ant.amazon.com ([10.43.164.24]) by EX13D32EUC003.ant.amazon.com ([10.43.164.24]) with mapi id 15.00.1497.006; Wed, 5 Aug 2020 09:44:43 +0000 From: "Durrant, Paul" To: Ian Jackson , "paul@xen.org" Thread-Index: AQHWalBvjr/TvfDJJEyo1xgwd7E00aknzdYAgAAEPoCAACBVAIABTyMAgAACc7A= Date: Wed, 5 Aug 2020 09:44:43 +0000 Message-ID: References: <20200803124931.2678-1-paul@xen.org> <20200803124931.2678-5-paul@xen.org> <24361.17132.762055.478992@mariner.uk.xensource.com> <002001d66a51$3cd055f0$b67101d0$@xen.org> <24361.18433.500622.984594@mariner.uk.xensource.com> <002801d66a63$85fb8c10$91f2a430$@xen.org> <24362.31810.819871.943707@mariner.uk.xensource.com> In-Reply-To: <24362.31810.819871.943707@mariner.uk.xensource.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.166.209] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Precedence: Bulk X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" , 'Wei Liu' Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" > -----Original Message----- > From: Ian Jackson > Sent: 05 August 2020 10:31 > To: paul@xen.org > Cc: xen-devel@lists.xenproject.org; Durrant, Paul = ; 'Wei Liu' > Subject: RE: [EXTERNAL] [PATCH v2 4/4] tools/hotplug: modify set_mtu() to= inform the frontend via > xenstore >=20 > CAUTION: This email originated from outside of the organization. Do not c= lick links or open > attachments unless you can confirm the sender and know the content is saf= e. >=20 >=20 >=20 > Paul Durrant writes ("RE: [PATCH v2 4/4] tools/hotplug: modify set_mtu() = to inform the frontend via > xenstore"): > > > -----Original Message----- > > > From: Ian Jackson > ... > > > Actually. > > > > > > This shouldn't be in the frontend at all, should it ? In general the > > > backend writes to the backend and the frontend to the frontend. > > > > > > So maybe I need to take back my R-b of > > > [PATCH v2 3/4] public/io/netif: specify MTU override node > > > > > > Sorry for the confusion. I seem rather undercaffienated today. > > > > Too late. The xenstore node has been used by Windows frontends for the = best part of a decade so we > can't practically change the > > path. Another way would be to also modify netback to simply echo the va= lue from backend into > frontend, but that seems rather > > pointless. >=20 > Hmm. How does this interact with driver domains ? I think a driver > domain might not have write access to this node. >=20 That's a good point; I think we will also need to actually write it from li= bxl first in that case. > Is there a value we can store in it that won't break these Windows > frontends, that libxl in the toolstack domain could write, before the > hotplug script runs in the driver domain ? >=20 > > Interestingly libxl does define an 'mtu' field for libxl_device_nic, wh= ich it sets to 1492 in > libxl__device_nic_setdefault() but > > never writes it into xenstore. There is even a comment: > > > > /* nic->mtu =3D */ > > > > in libxl__nic_from_xenstore() which implies it should have been there, = but isn't. > > I still think picking up the MTU from the bridge is the better way thou= gh. >=20 > I agree that the default should come from the bridge. Ideally there > would be a way to override it in the config. >=20 Well, I guess we address the driver domain issue in this way too... I will = add a patch to libxl to write the libxl_device_nic mtu value into xenstore,= in both backend (where it should always have been) and frontend. I think t= he current setting of 1492 can be changed to 1500 safely (since nothing app= ears to currently use that value). The hotplug script should then have suff= icient access to update, and a subsequent patch can add a mechanism to set = the value from the config. Paul From xen-devel-bounces@lists.xenproject.org Wed Aug 05 09:55:30 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 09:55:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3G8o-0004LS-2h; Wed, 05 Aug 2020 09:55:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3G8m-0004LK-Ly for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 09:55:20 +0000 X-Inumbo-ID: 97749f16-824a-4045-9486-0e2bfdaaf52f Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 97749f16-824a-4045-9486-0e2bfdaaf52f; Wed, 05 Aug 2020 09:55:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596621318; h=from:mime-version:content-transfer-encoding:message-id: date:to:cc:subject:in-reply-to:references; bh=w2+u7I9XBs8VzIqw/b/kjdEgHa04heKz9RHkt1QQ+uY=; b=F2zAb8jbhC2/nesC17tl/YbPnvU9bVMeS/6fPXuoL19mz3LzwuJyaESJ iGEGzmsfc4nl1WqcvZJgfbeVqG8fhtJ5Txjx50jSe3XmRhCV+jghZZ7th Sq+++yksAbAESY96nb4MQopiT32V8/3fuDGG1PsRthqhpQK+JMlRopYRR E=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: NrlHOk4GkmwUNzvyIXArgpH4zbzQ8iO7O/c659c70QuZ70qtU2ZBkieUA8YjHpzeQiXDPsEpCb /N/V0uc11epFovF8ZFfdKyRie5e95lmWFOeTw/W5sPftfzKQExHmQq80hqWShoQ4rHIlp20Xh/ Pom+ShmYyXh6Ha/80nqQWLS/3ZcP01BZCy3BD9mZyJH3kCz7BBv21jTqxwXS78RxJFh2zceejW 3xlEGA1tLb8HnA+ByoFyVOAf1ki3lIAr4AMW2TiWRlY4Skfnt82fncIiSLf51qwFL2lRDv0kGp 8CQ= X-SBRS: 3.7 X-MesageID: 24239405 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,436,1589256000"; d="scan'208";a="24239405" From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-ID: <24362.33281.726014.586449@mariner.uk.xensource.com> Date: Wed, 5 Aug 2020 10:55:13 +0100 To: Nick Rosbrook Subject: Re: [PATCH] libxl: avoid golang building without CONFIG_GOLANG=y In-Reply-To: References: <20200804141639.k2tpoqy7jj34gcm6@liuwe-devbox-debian-v2> <0deed4c6-ca87-09d3-a19c-ac0c00003cb7@suse.com> <20200804155043.vq7aupbrvmmcgzlv@liuwe-devbox-debian-v2> <12790d2b-020d-b6fe-4924-2233a4e93d83@suse.com> <20200804155707.rrtzkksrle2nojbj@liuwe-devbox-debian-v2> <43f706e4-0292-5758-eb19-9fbb99b1337e@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony Perard , "xen-devel@lists.xenproject.org" , Wei Liu , Jan Beulich , George Dunlap Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Nick Rosbrook writes ("Re: [PATCH] libxl: avoid golang building without CONFIG_GOLANG=y"): > Jan - is the problem specifically that a fresh clone, or `git > checkout`, etc. changes file timestamps in a way that triggers make to > rebuild those targets? I have not used the move-if-changed approach > before, but AFAICT that would be sufficient. I don't think there is, from the point of view of the build system, anything different about gengotypes than about any other in-tree committed file which is updated using makefile rules based on only other in-tree files and common utilities (eg, in this case, Python). I guess using move-if-changed will probably fix this. Jan: the reasons why this output file has to be committed are complicated. We've discussed them at length. Ultimately the reason is deliberate deficiencies[1] in golang. Sadly this is the best of a not-very-good set of options. Ian. [1] This is an extreme phrase, but justified I think. The golang designers have deliberately aimed at what they regard as "simplicity" and one of the things they have "simplified" away (in their language and in their package management and build tools) is the ability to conveniently generate golang code at build time. Committing the generated code is the norm in the golang community. From xen-devel-bounces@lists.xenproject.org Wed Aug 05 10:13:38 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 10:13:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3GQM-00069e-Kn; Wed, 05 Aug 2020 10:13:30 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3GQL-00069Z-JS for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 10:13:29 +0000 X-Inumbo-ID: 3e590cc4-dab6-4703-818b-1afd6e1d0db2 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3e590cc4-dab6-4703-818b-1afd6e1d0db2; Wed, 05 Aug 2020 10:13:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596622408; h=from:mime-version:content-transfer-encoding:message-id: date:to:cc:subject:in-reply-to:references; bh=pjG3v7tmHzM7X0me8MnApuXBjsCzdEESNfqc7e2/qxU=; b=hX1Lgsj6uIzwhgzlk2Dcsd7KKZMhE+J+/v6bz5gKL1oAdNsIBdYvwtIw 4wncaiX4MwfsFMSmxfE0DPdQNJnb3tnFKuRZ3ldEdJDw9dCvdwgj4Rur8 GTHp1NjxdU7RjkSsd3uwXYDMFm8KL3gIA0CF4H2MBu4+qLEEpZmhaXUG+ k=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: ablncfU/hRROiiFatEA3enkULTpRhqCFDPWlbDAwFm2fG0LCxhl/JF3sd8LkANW4vfRFIxxBE+ k/nw0YqgJbOsWqskSwXHJYPAw0OdmYpgMjYRFMI/mQA20poD/R+ULlVubKzssD7pfb5wM8dIzU 56DPeOjiq7slsjbRCS1zzmsVCTIvLgclZndanBteOVbpd4xNIgTQ3tvhfKg/GcLtdvtpqk40/x Jr9h++69hBj4B9f+Hq9UFnoiiWKmBSpan7bp6YL7jDNOm9UbtoF74bcl7QydbONESSZEKqq0T8 Cvw= X-SBRS: 3.7 X-MesageID: 24804478 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,436,1589256000"; d="scan'208";a="24804478" From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-ID: <24362.34372.501505.911622@mariner.uk.xensource.com> Date: Wed, 5 Aug 2020 11:13:24 +0100 To: "Durrant, Paul" Subject: RE: [PATCH v2 4/4] tools/hotplug: modify set_mtu() to inform the frontend via xenstore In-Reply-To: References: <20200803124931.2678-1-paul@xen.org> <20200803124931.2678-5-paul@xen.org> <24361.17132.762055.478992@mariner.uk.xensource.com> <002001d66a51$3cd055f0$b67101d0$@xen.org> <24361.18433.500622.984594@mariner.uk.xensource.com> <002801d66a63$85fb8c10$91f2a430$@xen.org> <24362.31810.819871.943707@mariner.uk.xensource.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" , 'Wei Liu' , "paul@xen.org" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Durrant, Paul writes ("RE: [PATCH v2 4/4] tools/hotplug: modify set_mtu() to inform the frontend via xenstore"): > > -----Original Message----- > > From: Ian Jackson ... > Well, I guess we address the driver domain issue in this way > too... I will add a patch to libxl to write the libxl_device_nic mtu > value into xenstore, Do you mean libxl in dom0 or libxl in the driver domain ? libxl contains code that runs in both contexts. See device_hotplug in libxl_device.c, in particular notice if (aodev->dev->backend_domid != domid) { If you want the mtu to be read from the bridge, it can only be determined by the driver domain, because the bridge is in the driver domain. In v2 of this series you arrange for the hotplug script to copy the mtu from the bridge into the frontend path. That won't work because the hotplug script can't write to that xenstore node because (unlike a domo0 backend) a driver domain backend doesn't have write access to the frontend so can't create a new node there. ISTM that it is correct that it is the hotplug script that does this interface setup. If it weren't for this erroneous use of the frontend path I think the right design would be: * toolstack libxl reads the config file to find whether there is an MTU * toolstack libxl writes mtu node in backend iff one was in config (and leaves the node absent otherwise) * driver domain libxl runs hotplug script * driver domain hotplug script looks for mtu in backend; if there isn't one, it gets the value from the bridge and writes it to the backend in xenstore * driver domain backend driver reads mtu value from backend path * guest domain frontend driver reads mtu value from backend path * on domain save/migrate, toolstack libxl will record the mtu value as the actual configuration so that the migrated domain will get the same mtu I don't think I understand what (in these kind of terms) you are proposing, in order to support the frontends that want to read the mtu from the frontend. > I think the current setting of 1492 can be changed to 1500 safely > (since nothing appears to currently use that value). Right, that seems correct to me. > The hotplug script should then have sufficient access to update, and > a subsequent patch can add a mechanism to set the value from the > config. I think what I am missing is how this "subsequent patch" would work ? Ie what design are we aiming for, that we are now implementing part of ? Ian. From xen-devel-bounces@lists.xenproject.org Wed Aug 05 10:37:36 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 10:37:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3GnP-0007yW-La; Wed, 05 Aug 2020 10:37:19 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3GnO-0007yC-O2 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 10:37:18 +0000 X-Inumbo-ID: 819afbe8-de10-4f5c-b525-d092565a1635 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 819afbe8-de10-4f5c-b525-d092565a1635; Wed, 05 Aug 2020 10:37:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=PvXYfQiV658z27YKhv9WPmac6pVamZ2UOuRIgaTayoY=; b=u5xrT0gcG3ZO4hNUPgD14cyDF J5H0/LXeImd8LcN+hfmW47z+BEdL+XUUNpdHYwfEsuQXdXMJ9U3z6CCc3gxBHZpKURzUR9IEH4XHZ R+CGGimwLzeXmQX9QPtMFsYhTWjEy5DCVMzT5J6mG3xjJfZj1VUaI1DZzzIm6dtiwN8tA=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3GnH-0001pE-8o; Wed, 05 Aug 2020 10:37:11 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k3GnG-0001SK-TH; Wed, 05 Aug 2020 10:37:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k3GnG-00086Z-Sc; Wed, 05 Aug 2020 10:37:10 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-coverity test] 152488: all pass - PUSHED X-Osstest-Versions-This: xen=c9f9a7258dc07735e2da2b6d0b51a0218c76a51f X-Osstest-Versions-That: xen=81fd0d3ca4b2cd309403c6e8da662c325dd35750 From: osstest service owner Date: Wed, 05 Aug 2020 10:37:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152488 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/152488/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen c9f9a7258dc07735e2da2b6d0b51a0218c76a51f baseline version: xen 81fd0d3ca4b2cd309403c6e8da662c325dd35750 Last test of basis 152385 2020-08-02 09:18:50 Z 3 days Testing same since 152488 2020-08-05 09:18:39 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Wei Liu jobs: coverity-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 81fd0d3ca4..c9f9a7258d c9f9a7258dc07735e2da2b6d0b51a0218c76a51f -> coverity-tested/smoke From xen-devel-bounces@lists.xenproject.org Wed Aug 05 10:43:10 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 10:43:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Gsw-0000O8-AS; Wed, 05 Aug 2020 10:43:02 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Gsu-0000O3-RM for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 10:43:00 +0000 X-Inumbo-ID: 7eda6b78-f5a3-4f28-9b75-b6a626977f24 Received: from smtp-fw-33001.amazon.com (unknown [207.171.190.10]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7eda6b78-f5a3-4f28-9b75-b6a626977f24; Wed, 05 Aug 2020 10:42:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.co.uk; i=@amazon.co.uk; q=dns/txt; s=amazon201209; t=1596624180; x=1628160180; h=from:to:cc:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version:subject; bh=VRAPOeC1MmOq3/iWAGGXVUHPh8eViJyWgIeLUk1RZ8w=; b=ry9n7reS4ZCsQ7l4Pd3XqLxrnUSs/sr+3I3ppoH1N/dsmLI+aTCGIFfb 0WQVRzd37uRKMyktUT4rAblQHljH4/dvQVUnLRdYjXyw93l32P60k5jpE kow43QNH+Re0bjSvGbSP4Krra02XCR0vbsbCcEcFCe65SEM9Aad02gqWX Q=; IronPort-SDR: boTZSxI9IQH/b8wfGaTzW1Kb63Sqzw+kDORKnfxftFDfzfUep+D8eTDUN0Bo3hhnR6wBTBwoYX q/68jUznU2/A== X-IronPort-AV: E=Sophos;i="5.75,436,1589241600"; d="scan'208";a="64498978" Subject: RE: [PATCH v2 4/4] tools/hotplug: modify set_mtu() to inform the frontend via xenstore Thread-Topic: [PATCH v2 4/4] tools/hotplug: modify set_mtu() to inform the frontend via xenstore Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-2a-22cc717f.us-west-2.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-33001.sea14.amazon.com with ESMTP; 05 Aug 2020 10:42:56 +0000 Received: from EX13MTAUEA002.ant.amazon.com (pdx4-ws-svc-p6-lb7-vlan3.pdx.amazon.com [10.170.41.166]) by email-inbound-relay-2a-22cc717f.us-west-2.amazon.com (Postfix) with ESMTPS id C8F07A0807; Wed, 5 Aug 2020 10:42:54 +0000 (UTC) Received: from EX13D32EUC003.ant.amazon.com (10.43.164.24) by EX13MTAUEA002.ant.amazon.com (10.43.61.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 5 Aug 2020 10:42:54 +0000 Received: from EX13D32EUC003.ant.amazon.com (10.43.164.24) by EX13D32EUC003.ant.amazon.com (10.43.164.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 5 Aug 2020 10:42:53 +0000 Received: from EX13D32EUC003.ant.amazon.com ([10.43.164.24]) by EX13D32EUC003.ant.amazon.com ([10.43.164.24]) with mapi id 15.00.1497.006; Wed, 5 Aug 2020 10:42:53 +0000 From: "Durrant, Paul" To: Ian Jackson Thread-Index: AQHWalBvjr/TvfDJJEyo1xgwd7E00aknzdYAgAAEPoCAACBVAIABTyMAgAACc7CAAAl7AIAABRVA Date: Wed, 5 Aug 2020 10:42:53 +0000 Message-ID: <8fc31fce45d54e8a92bf3755fa829a84@EX13D32EUC003.ant.amazon.com> References: <20200803124931.2678-1-paul@xen.org> <20200803124931.2678-5-paul@xen.org> <24361.17132.762055.478992@mariner.uk.xensource.com> <002001d66a51$3cd055f0$b67101d0$@xen.org> <24361.18433.500622.984594@mariner.uk.xensource.com> <002801d66a63$85fb8c10$91f2a430$@xen.org> <24362.31810.819871.943707@mariner.uk.xensource.com> <24362.34372.501505.911622@mariner.uk.xensource.com> In-Reply-To: <24362.34372.501505.911622@mariner.uk.xensource.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.166.209] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Precedence: Bulk X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" , 'Wei Liu' , "paul@xen.org" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" > -----Original Message----- > From: Ian Jackson > Sent: 05 August 2020 11:13 > To: Durrant, Paul > Cc: paul@xen.org; xen-devel@lists.xenproject.org; 'Wei Liu' > Subject: RE: [EXTERNAL] [PATCH v2 4/4] tools/hotplug: modify set_mtu() to= inform the frontend via > xenstore >=20 > CAUTION: This email originated from outside of the organization. Do not c= lick links or open > attachments unless you can confirm the sender and know the content is saf= e. >=20 >=20 >=20 > Durrant, Paul writes ("RE: [PATCH v2 4/4] tools/hotplug: modify set_mtu()= to inform the frontend via > xenstore"): > > > -----Original Message----- > > > From: Ian Jackson > ... > > Well, I guess we address the driver domain issue in this way > > too... I will add a patch to libxl to write the libxl_device_nic mtu > > value into xenstore, >=20 > Do you mean libxl in dom0 or libxl in the driver domain ? >=20 > libxl contains code that runs in both contexts. >=20 > See device_hotplug in libxl_device.c, in particular notice > if (aodev->dev->backend_domid !=3D domid) { >=20 > If you want the mtu to be read from the bridge, it can only be > determined by the driver domain, because the bridge is in the driver > domain. >=20 > In v2 of this series you arrange for the hotplug script to copy the > mtu from the bridge into the frontend path. That won't work because > the hotplug script can't write to that xenstore node because (unlike a > domo0 backend) a driver domain backend doesn't have write access to > the frontend so can't create a new node there. >=20 > ISTM that it is correct that it is the hotplug script that does this > interface setup. If it weren't for this erroneous use of the frontend > path I think the right design would be: > * toolstack libxl reads the config file to find whether there is an MTU > * toolstack libxl writes mtu node in backend iff one was in config > (and leaves the node absent otherwise) This is where the 'subsequent patch' comes in (see the end of the email)... > * driver domain libxl runs hotplug script > * driver domain hotplug script looks for mtu in backend; if there > isn't one, it gets the value from the bridge and writes it to > the backend in xenstore > * driver domain backend driver reads mtu value from backend path > * guest domain frontend driver reads mtu value from backend path > * on domain save/migrate, toolstack libxl will record the mtu > value as the actual configuration so that the migrated domain > will get the same mtu >=20 That sounds right. > I don't think I understand what (in these kind of terms) you are > proposing, in order to support the frontends that want to read the mtu > from the frontend. We need some way for creating the frontend node such that the driver domain= has write access. Presumably there is a suitable place in the toolstack in= stance of libxl to do this. This would mean we either need to write a senti= nel 'invalid' value or write the default value. In the default case we coul= d still leave the backend node absent so the hotplug script will still know= whether or not a value was set in the cfg. >=20 > > I think the current setting of 1492 can be changed to 1500 safely > > (since nothing appears to currently use that value). >=20 > Right, that seems correct to me. >=20 > > The hotplug script should then have sufficient access to update, and > > a subsequent patch can add a mechanism to set the value from the > > config. >=20 > I think what I am missing is how this "subsequent patch" would work ? > Ie what design are we aiming for, that we are now implementing part > of ? The subsequent patch would be one that actually acquires the mtu value from= the vif config, and adds documentation to xl-network-configuration.5.pod, = since this is currently missing. Paul >=20 > Ian. From xen-devel-bounces@lists.xenproject.org Wed Aug 05 11:29:23 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 11:29:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Hbd-0003vV-Br; Wed, 05 Aug 2020 11:29:13 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Hbc-0003vQ-AJ for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 11:29:12 +0000 X-Inumbo-ID: dd690e3c-6293-47a5-b888-18ed8a6e535b Received: from mail-40134.protonmail.ch (unknown [185.70.40.134]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id dd690e3c-6293-47a5-b888-18ed8a6e535b; Wed, 05 Aug 2020 11:29:10 +0000 (UTC) Date: Wed, 05 Aug 2020 11:29:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trmm.net; s=protonmail; t=1596626949; bh=dgDV22qnACp8c/A+YHwl5V7sEd5nX62SR1yvllPcpcA=; h=Date:To:From:Reply-To:Subject:From; b=GQ/x7t88fw7zTil4ppLRAfUD2ZQSbuu/5Sx/jIYg2a3R2Xa5N11jDrl5o7dLfHWrd fL7zlK/k9Kh3ZNgMxCDAVv1/HsFrYAfHJd76JV7qU8jvmSvmaBLhnkMOX+ssmIVUTg pyveEDdNzeze+oJ4CHk7c8QyRdyULQBLLW3ENAaE= To: "xen-devel@lists.xenproject.org" From: Trammell Hudson Subject: Unified Xen executable for UEFI Secure Boot support Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: Trammell Hudson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" I have preliminary patches to support bundling the Xen hypervisor, xen.cfg,= the Linux kernel, initrd and XSM into a single "unified" EFI executable th= at can be signed by sbsigntool for verification by UEFI Secure Boot. It is= inspired by systemd-boot's unified kernel technique and borrows the functi= on to locate PE sections from systemd's LGPL'ed code. The configuration, kernel, etc are added after building using objcopy to ad= d named sections for each input file. This allows an administrator to upda= te the components independently without requiring rebuilding xen. During EF= I boot, Xen looks at its own loaded image to locate the PE sections and, if= secure boot is enabled, only allows use of the unified components. The resulting EFI executable can be invoked directly from the UEFI Boot Man= ager, removing the need to use a separate loader like grub. Unlike the shim= based verification, the signature covers the entire Xen+config+kernel+init= rd unified file. This also ensures that properly configured platforms will = measure the entire runtime into the TPM for unsealing secrets or remote att= estation. I've tested it on qemu OVMF with Secure Boot enabled, as well as on real Th= inkpad hardware. The EFI console is very slow, although it works and is ab= le to boot into dom0. The current patch set is here, and I'd appreciate suggestions on the techni= que or cleanup for submission: https://github.com/osresearch/xen/tree/secureboot -- Trammell From xen-devel-bounces@lists.xenproject.org Wed Aug 05 12:37:06 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 12:37:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Iez-0001SK-Ri; Wed, 05 Aug 2020 12:36:45 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Iey-0001SF-AS for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 12:36:44 +0000 X-Inumbo-ID: 54755987-84cb-4478-ba96-f6f80e84524b Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 54755987-84cb-4478-ba96-f6f80e84524b; Wed, 05 Aug 2020 12:36:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=uxPqVqn9QJM8yggNlrJLH5qHfwZEIT0UmYM0KzSjJrY=; b=eB25kopPT71J5PYbAOZXCLJx1 P7/AMVEREv1o6M5v55KOHb1cnsRKnWk7ee4El6b5UrwvpCK4cebhL+7RyYuuXPR2OlUXREkohyEvk SY/ztxfhD0mDLrgFxaoBqExcGBFItx04QwmKswm41xl4CXFywNM+mCCTNYql9cFPsE/+E=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Ieu-0004Sf-Rp; Wed, 05 Aug 2020 12:36:40 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k3Ieu-0006WU-6N; Wed, 05 Aug 2020 12:36:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k3Ieu-0003oN-5D; Wed, 05 Aug 2020 12:36:40 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 152470: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-boot:fail:regression linux-linus:test-amd64-i386-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-libvirt:xen-boot:fail:regression linux-linus:test-amd64-i386-examine:reboot:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-boot:fail:regression linux-linus:test-amd64-i386-xl:xen-boot:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:build-arm64-pvops:kernel-build:fail:regression linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking X-Osstest-Versions-This: linux=c0842fbc1b18c7a044e6ff3e8fa78bfa822c7d1a X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Wed, 05 Aug 2020 12:36:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152470 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/152470/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-boot/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-boot/dst_host fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-examine 8 reboot fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-boot/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-boot/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-boot fail REGR. vs. 152332 build-arm64-pvops 6 kernel-build fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-examine 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail like 152332 test-armhf-armhf-libvirt 14 saverestore-support-check fail like 152332 test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail like 152332 test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass version targeted for testing: linux c0842fbc1b18c7a044e6ff3e8fa78bfa822c7d1a baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 4 days Failing since 152366 2020-08-01 20:49:34 Z 3 days 4 attempts Testing same since 152470 2020-08-04 13:13:13 Z 0 days 1 attempts ------------------------------------------------------------ 661 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 51970 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Aug 05 12:37:18 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 12:37:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3IfW-0001Ve-5k; Wed, 05 Aug 2020 12:37:18 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3IfU-0001V9-Ly for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 12:37:16 +0000 X-Inumbo-ID: a9abef5d-f928-4216-9d08-8f9f1ce67230 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a9abef5d-f928-4216-9d08-8f9f1ce67230; Wed, 05 Aug 2020 12:37:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=KKyJTL2Avwbk1Um1CAQDb0ca4NMIZXOkQ+74RYSZ3nU=; b=2H4U+ftTorriNkmR2wQmdBMi4 +U7d0z21EeBKJdy5IINNKIc99iqa9AkIt42W8siGk1cEYcRXPn2eYWkKhSXGKym6hPrGIZN2V1kGs xccb3LaL8Kc/v27WNvBaiMU28QMa5ZzrOPpnIxDmRq9v6Sc6uEsRx2U1J1hAnxn4HgipM=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3IfN-0004Sy-RV; Wed, 05 Aug 2020 12:37:09 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k3IfN-0006Xi-6Q; Wed, 05 Aug 2020 12:37:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k3IfN-0004sm-5k; Wed, 05 Aug 2020 12:37:09 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 152487: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e58a71274c65e7547fc2e917f051c5c04e2820e2 X-Osstest-Versions-That: xen=c9f9a7258dc07735e2da2b6d0b51a0218c76a51f From: osstest service owner Date: Wed, 05 Aug 2020 12:37:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152487 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/152487/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass version targeted for testing: xen e58a71274c65e7547fc2e917f051c5c04e2820e2 baseline version: xen c9f9a7258dc07735e2da2b6d0b51a0218c76a51f Last test of basis 152477 2020-08-04 22:02:33 Z 0 days Testing same since 152487 2020-08-05 09:00:51 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git c9f9a7258d..e58a71274c e58a71274c65e7547fc2e917f051c5c04e2820e2 -> smoke From xen-devel-bounces@lists.xenproject.org Wed Aug 05 12:49:56 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 12:49:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Ird-0002XO-Br; Wed, 05 Aug 2020 12:49:49 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Irb-0002XH-CY for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 12:49:47 +0000 X-Inumbo-ID: 50127ec7-a3f3-4867-9ff7-a61c2ca12928 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 50127ec7-a3f3-4867-9ff7-a61c2ca12928; Wed, 05 Aug 2020 12:49:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=wkoqjcxxmKcN918VsWOUQ2FdLMhQdyLjRu/lW4jdXKA=; b=48vJKutazF2TGb1EOvDw8YXr3 RXte9IupmQagSPtH7nwEILBXUNK6vz88Yh7UB/CqynN/Oe3Onwkvu0DKrLHNc5yzOTI7SuvUSZh6U SDf51qOaexmrmXOrqIc2AkVCYTWWAWv6N0emWPmDLOIMAW69VYYB1Q/mOFU12z/5lcORE=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3IrY-0004iz-0l; Wed, 05 Aug 2020 12:49:44 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k3IrX-0006vo-K6; Wed, 05 Aug 2020 12:49:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k3IrX-0004U2-JX; Wed, 05 Aug 2020 12:49:43 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 152482: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=ed8d1385f775e8dc22887f0a1bdc425ab8e1b223 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Wed, 05 Aug 2020 12:49:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152482 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/152482/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a version targeted for testing: libvirt ed8d1385f775e8dc22887f0a1bdc425ab8e1b223 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 26 days Failing since 151818 2020-07-11 04:18:52 Z 25 days 26 attempts Testing same since 152482 2020-08-05 04:22:54 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrea Bolognani Balázs Meskó Bastien Orivel Bihong Yu Binfeng Wu Boris Fiuczynski Côme Borsoi Daniel Henrique Barboza Daniel P. Berrange Daniel P. Berrangé Erik Skultety Fedora Weblate Translation Han Han Hao Wang Jean-Baptiste Holcroft Jianan Gao Jin Yan Jiri Denemark Ján Tomko Laine Stump Liao Pingfang Martin Kletzander Michal Privoznik Nikolay Shirokovskiy Paulo de Rezende Pinatti Pavel Hrdina Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Roman Bogorodskiy Ryan Schmidt Stefan Berger Szymon Scholz Wang Xin Weblate Yang Hang Yi Wang Yuri Chornoivan Zheng Chuan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 8767 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Aug 05 12:51:31 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 12:51:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3ItG-0003IU-UI; Wed, 05 Aug 2020 12:51:30 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3ItG-0003IN-71 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 12:51:30 +0000 X-Inumbo-ID: f6f37747-bb4b-4353-b544-2153e2890fba Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f6f37747-bb4b-4353-b544-2153e2890fba; Wed, 05 Aug 2020 12:51:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596631888; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=DqXQeOCb8wl+MEQ6DYesZt1pzQQgZ5aV7kpKWqbWJ5o=; b=H6sz06H2dPEL86H4zFKqZYCmroR8zmFIr7RcZg+E2b6Yg7iX0N1/HOIP 0bbAKEyLlrRDZSfXVLGh2V7uqPsyrt47pbtt0nB6NTTiqnu5ETtnpzmjm PqwGrnOoRAWiPVoEQymfAn2QB331yUaaF57SNuUgW71Dl456+PSY+maqq c=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: H0IOtf+NmNNXtIb3vBP89mAfdirC7zbuDhNi6MaeCYBH7gNqSllvQWlWPDnHQfXv7QOxEAJPyE vqJDxUprDscE65Vj6snxU0t57kqjk2oJ1M0yuy3KDnHD04TyvydfNmf1H+SphV9xHPKAyrZism 9PK/9kl6k897Kz/WK2/qAX0s3Cn1EsLumCMdengXLaGHlK5qPkJ3eXtovNruFsqiVXpgGLp/ms tlOw/8QKUtNutCdWlFlwPP8RT14wVjnAfoVfRLfqRoyTYVq2ags30+95hytNMAEYu+0/bTSKcB VhA= X-SBRS: 3.7 X-MesageID: 24248781 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,436,1589256000"; d="scan'208";a="24248781" From: Andrew Cooper To: Xen-devel Subject: [PATCH] x86/ioapic: Fix fixmap error path logic in ioapic_init_mappings() Date: Wed, 5 Aug 2020 13:51:09 +0100 Message-ID: <20200805125109.7348-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" In the case that bad_ioapic_register() fails, the current position of idx++ means that clear_fixmap(idx) will be called with the wrong index, and not clean up the mapping just created. Increment idx as part of the loop, rather than midway through the loop body. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné --- xen/arch/x86/io_apic.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c index 878ee5192d..e66fa99ec7 100644 --- a/xen/arch/x86/io_apic.c +++ b/xen/arch/x86/io_apic.c @@ -2543,7 +2543,7 @@ static void __init ioapic_init_mappings(void) nr_irqs_gsi = 0; - for ( i = 0; i < nr_ioapics; i++ ) + for ( i = 0; i < nr_ioapics; i++, idx++ ) { union IO_APIC_reg_01 reg_01; paddr_t ioapic_phys = mp_ioapics[i].mpc_apicaddr; @@ -2560,7 +2560,6 @@ static void __init ioapic_init_mappings(void) set_fixmap_nocache(idx, ioapic_phys); apic_printk(APIC_VERBOSE, "mapped IOAPIC to %08Lx (%08lx)\n", __fix_to_virt(idx), ioapic_phys); - idx++; if ( bad_ioapic_register(i) ) { -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 12:51:57 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 12:51:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Itg-0003Lo-6i; Wed, 05 Aug 2020 12:51:56 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Ite-0003Lc-VC for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 12:51:54 +0000 X-Inumbo-ID: c0ce91e3-776a-4307-9d4e-17039861a371 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c0ce91e3-776a-4307-9d4e-17039861a371; Wed, 05 Aug 2020 12:51:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596631913; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=rRFT9u3/O3zvV8jxX2uNkA4cBsg0DH2hVxBAe+fvmPE=; b=HiTX2IOepLYkTi2o/oX+dTL42qv9b9uk6ILjEECIuVPNG+v4/+mjjmZ1 dWpfPzYZFo6sV8aJRqZUxI3nyMb/9W5zW7luImr37b0TKr/3MpgmVyd93 CZjhGBQtf3B+W++3CDQcvy29gWIdvtvK0cAPNXNwLTw40NRh+5HADt0VQ o=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: ohW9JmQu13lbrqMX3sYNIaH378KG3zbGQbpGh5NLpG4SXOlJm58gvC1FP0EN7C3lPO61nRNsqq 8o9nRuZrqezEWldAMWarq/9chwQYNLQEs2355qDCkXScVcrkG/Obah3o8V1mkp7Y+rKqxiDrbo jphMATrqV1EGja5YYJjVYEZsNKuENymEoVvU6y5pihkBJwDjlreG6bB5z3yy8dsyzOn4eCOPlQ oWlRUJHe8ZTMCbITrTCTjb7OWIwUSbOqa1Mj9/9uaqrYNJ3aPa7CV8pKZJLaJ8fXNOBAt7tE9+ Cn8= X-SBRS: 3.7 X-MesageID: 24813330 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,436,1589256000"; d="scan'208";a="24813330" From: Andrew Cooper To: Xen-devel Subject: [PATCH] x86/ioapic: Fix style in io_apic.h Date: Wed, 5 Aug 2020 13:51:24 +0100 Message-ID: <20200805125124.7763-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" This file is a mix of Xen and Linux styles. Switch it fully to Xen style. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné --- xen/include/asm-x86/io_apic.h | 48 +++++++++++++++++++++---------------------- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/xen/include/asm-x86/io_apic.h b/xen/include/asm-x86/io_apic.h index e006b2b8dd..daf17d4c3d 100644 --- a/xen/include/asm-x86/io_apic.h +++ b/xen/include/asm-x86/io_apic.h @@ -13,9 +13,9 @@ * Copyright (C) 1997, 1998, 1999, 2000 Ingo Molnar */ -#define IO_APIC_BASE(idx) \ - ((volatile int *)(__fix_to_virt(FIX_IO_APIC_BASE_0 + idx) \ - + (mp_ioapics[idx].mpc_apicaddr & ~PAGE_MASK))) +#define IO_APIC_BASE(idx) \ + ((volatile int *)(__fix_to_virt(FIX_IO_APIC_BASE_0 + idx) \ + + (mp_ioapics[idx].mpc_apicaddr & ~PAGE_MASK))) #define IO_APIC_ID(idx) (mp_ioapics[idx].mpc_apicid) @@ -78,14 +78,14 @@ extern int nr_ioapics; extern int nr_ioapic_entries[MAX_IO_APICS]; enum ioapic_irq_destination_types { - dest_Fixed = 0, - dest_LowestPrio = 1, - dest_SMI = 2, - dest__reserved_1 = 3, - dest_NMI = 4, - dest_INIT = 5, - dest__reserved_2 = 6, - dest_ExtINT = 7 + dest_Fixed = 0, + dest_LowestPrio = 1, + dest_SMI = 2, + dest__reserved_1 = 3, + dest_NMI = 4, + dest_INIT = 5, + dest__reserved_2 = 6, + dest_ExtINT = 7 }; struct IO_APIC_route_entry { @@ -135,28 +135,28 @@ unsigned int io_apic_gsi_base(unsigned int apic); static inline unsigned int __io_apic_read(unsigned int apic, unsigned int reg) { - *IO_APIC_BASE(apic) = reg; - return *(IO_APIC_BASE(apic)+4); + *IO_APIC_BASE(apic) = reg; + return *(IO_APIC_BASE(apic)+4); } static inline unsigned int io_apic_read(unsigned int apic, unsigned int reg) { - if (ioapic_reg_remapped(reg)) - return iommu_read_apic_from_ire(apic, reg); - return __io_apic_read(apic, reg); + if ( ioapic_reg_remapped(reg) ) + return iommu_read_apic_from_ire(apic, reg); + return __io_apic_read(apic, reg); } static inline void __io_apic_write(unsigned int apic, unsigned int reg, unsigned int value) { - *IO_APIC_BASE(apic) = reg; - *(IO_APIC_BASE(apic)+4) = value; + *IO_APIC_BASE(apic) = reg; + *(IO_APIC_BASE(apic)+4) = value; } static inline void io_apic_write(unsigned int apic, unsigned int reg, unsigned int value) { - if (ioapic_reg_remapped(reg)) - return iommu_update_ire_from_apic(apic, reg, value); - __io_apic_write(apic, reg, value); + if ( ioapic_reg_remapped(reg) ) + return iommu_update_ire_from_apic(apic, reg, value); + __io_apic_write(apic, reg, value); } /* @@ -165,9 +165,9 @@ static inline void io_apic_write(unsigned int apic, unsigned int reg, unsigned i */ static inline void io_apic_modify(unsigned int apic, unsigned int reg, unsigned int value) { - if (ioapic_reg_remapped(reg)) - return iommu_update_ire_from_apic(apic, reg, value); - *(IO_APIC_BASE(apic)+4) = value; + if ( ioapic_reg_remapped(reg) ) + return iommu_update_ire_from_apic(apic, reg, value); + *(IO_APIC_BASE(apic)+4) = value; } /* 1 if "noapic" boot option passed */ -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 13:30:59 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 13:30:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3JVK-0006us-Hw; Wed, 05 Aug 2020 13:30:50 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3JVJ-0006uh-3d for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 13:30:49 +0000 X-Inumbo-ID: 1fdd7be4-0537-4558-8ba0-31fef9e1cde0 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1fdd7be4-0537-4558-8ba0-31fef9e1cde0; Wed, 05 Aug 2020 13:30:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=NhU77mw8lxmVWmWAz3GWPDyUog0FnaFTIwxGxqeKRsw=; b=AYF33p9gSoEp7Ud7goSZByRiWG 8aYQbLkjhxYn94eiyvwEYATNvjE+9kKZkGitcU4F3aSkvSxFeHHHgRuM2OX/6Dh6zNA8pqQTP0ORR J9G2yLAX9pohSOqwjbEo3IpY4p3ZiV++KurJITy9dpjF/BHv9AyAW/9mm+ZZCCM204uQ=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3JV6-0005cr-S5; Wed, 05 Aug 2020 13:30:36 +0000 Received: from 54-240-197-228.amazon.com ([54.240.197.228] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k3JV6-0000U7-HJ; Wed, 05 Aug 2020 13:30:36 +0000 Subject: Re: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common To: Oleksandr Tyshchenko , xen-devel@lists.xenproject.org References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-2-git-send-email-olekstysh@gmail.com> From: Julien Grall Message-ID: <6bfc3920-8f29-188c-cff4-2b99dabe166f@xen.org> Date: Wed, 5 Aug 2020 14:30:33 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <1596478888-23030-2-git-send-email-olekstysh@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Tian , Stefano Stabellini , Jan Beulich , Wei Liu , Paul Durrant , Andrew Cooper , Ian Jackson , George Dunlap , Tim Deegan , Oleksandr Tyshchenko , Julien Grall , Jun Nakajima , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Hi, On 03/08/2020 19:21, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > As a lot of x86 code can be re-used on Arm later on, this patch > splits IOREQ support into common and arch specific parts. > > This support is going to be used on Arm to be able run device > emulator outside of Xen hypervisor. > > Please note, this is a split/cleanup of Julien's PoC: > "Add support for Guest IO forwarding to a device emulator" > > Signed-off-by: Julien Grall > Signed-off-by: Oleksandr Tyshchenko > --- > xen/arch/x86/Kconfig | 1 + > xen/arch/x86/hvm/dm.c | 2 +- > xen/arch/x86/hvm/emulate.c | 2 +- > xen/arch/x86/hvm/hvm.c | 2 +- > xen/arch/x86/hvm/io.c | 2 +- > xen/arch/x86/hvm/ioreq.c | 1431 +-------------------------------------- > xen/arch/x86/hvm/stdvga.c | 2 +- > xen/arch/x86/hvm/vmx/realmode.c | 1 + > xen/arch/x86/hvm/vmx/vvmx.c | 2 +- > xen/arch/x86/mm.c | 2 +- > xen/arch/x86/mm/shadow/common.c | 2 +- > xen/common/Kconfig | 3 + > xen/common/Makefile | 1 + > xen/common/hvm/Makefile | 1 + > xen/common/hvm/ioreq.c | 1430 ++++++++++++++++++++++++++++++++++++++ > xen/include/asm-x86/hvm/ioreq.h | 45 +- > xen/include/asm-x86/hvm/vcpu.h | 7 - > xen/include/xen/hvm/ioreq.h | 89 +++ > 18 files changed, 1575 insertions(+), 1450 deletions(-) That's quite a lot of code moved in a single patch. How can we check the code moved is still correct? Is it a verbatim copy? > create mode 100644 xen/common/hvm/Makefile > create mode 100644 xen/common/hvm/ioreq.c > create mode 100644 xen/include/xen/hvm/ioreq.h [...] > +static bool hvm_wait_for_io(struct hvm_ioreq_vcpu *sv, ioreq_t *p) > +{ > + unsigned int prev_state = STATE_IOREQ_NONE; > + > + while ( sv->pending ) > + { > + unsigned int state = p->state; > + > + smp_rmb(); > + > + recheck: > + if ( unlikely(state == STATE_IOREQ_NONE) ) > + { > + /* > + * The only reason we should see this case is when an > + * emulator is dying and it races with an I/O being > + * requested. > + */ > + hvm_io_assist(sv, ~0ul); > + break; > + } > + > + if ( unlikely(state < prev_state) ) > + { > + gdprintk(XENLOG_ERR, "Weird HVM ioreq state transition %u -> %u\n", > + prev_state, state); > + sv->pending = false; > + domain_crash(sv->vcpu->domain); > + return false; /* bail */ > + } > + > + switch ( prev_state = state ) > + { > + case STATE_IORESP_READY: /* IORESP_READY -> NONE */ > + p->state = STATE_IOREQ_NONE; > + hvm_io_assist(sv, p->data); > + break; > + case STATE_IOREQ_READY: /* IOREQ_{READY,INPROCESS} -> IORESP_READY */ > + case STATE_IOREQ_INPROCESS: > + wait_on_xen_event_channel(sv->ioreq_evtchn, > + ({ state = p->state; > + smp_rmb(); > + state != prev_state; })); > + goto recheck; I recall some discussion on security@ about this specific code. An IOREQ server can be destroyed at any time. When destroying IOREQ server, the all the vCPUs will be paused to avoid race. On x86, this was considered to be safe because wait_on_xen_event_channel() will never return if the vCPU is re-scheduled. However, on Arm, this function will return even after rescheduling. In this case, sv and p may point to invalid memory. IIRC, the suggestion was to harden hvm_wait_for_io(). I guess we could fetch the sv and p after wait_on_xen_event_channel. Any opinions? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Aug 05 13:33:00 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 13:33:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3JXP-00073d-V3; Wed, 05 Aug 2020 13:32:59 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3JXP-00073V-62 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 13:32:59 +0000 X-Inumbo-ID: dacd694f-1b84-4c18-90b2-d4337cbfddca Received: from aserp2120.oracle.com (unknown [141.146.126.78]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id dacd694f-1b84-4c18-90b2-d4337cbfddca; Wed, 05 Aug 2020 13:32:57 +0000 (UTC) Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 075DS6aw038978; Wed, 5 Aug 2020 13:31:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=wYBFPjXevv4FEJxjfZDQbIVAOxKAPwLvh+4h5JhT3CQ=; b=VFambJZ/EoDlm9yZUQgdDXONHvQkRuftCJ3aGlv07wUIl9YOPpK/myo5dAvWyfPbE7j9 Id8w3yFy4v3x+EDQB/OZvXW94e6POr7bHQhQlPuTE1A8BjB3be8VuS05QcNDIESSjGd/ Hd8rNH2giPY+QMS4b7defPYUjXf9wfU1Lr1ydfkmEYIgpqRorneUu+MIfjLG3Y8HiWpC FiK9qkn0hyxQNxHiS+ulCz6cR1D4I/S/clcLenMEMAAjDut+izkO8qJMJV747m3jKx7H FvQ8J9bpcecNhnv1dyZbKp6PcoOAFQC6gSDLsOxu4HNAMX6GHIKJAOTkR/1ln+hTDglO dw== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 32qnd42b1w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 05 Aug 2020 13:31:33 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 075DRlDt170630; Wed, 5 Aug 2020 13:31:32 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 32njayrrum-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 05 Aug 2020 13:31:32 +0000 Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 075DVPYl024799; Wed, 5 Aug 2020 13:31:25 GMT Received: from [10.39.234.166] (/10.39.234.166) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 05 Aug 2020 06:31:25 -0700 Subject: Re: [PATCH v2 01/11] xen/manage: keep track of the on-going suspend mode To: Anchal Agarwal References: <20200721000348.GA19610@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> <408d3ce9-2510-2950-d28d-fdfe8ee41a54@oracle.com> <20200722180229.GA32316@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> <20200723225745.GB32316@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> <66a9b838-70ed-0807-9260-f2c31343a081@oracle.com> <20200730230634.GA17221@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> <53b577a3-6af9-5587-7e47-485be38b3653@oracle.com> <20200804234201.GA23820@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> From: Boris Ostrovsky Autocrypt: addr=boris.ostrovsky@oracle.com; keydata= xsFNBFH8CgsBEAC0KiOi9siOvlXatK2xX99e/J3OvApoYWjieVQ9232Eb7GzCWrItCzP8FUV PQg8rMsSd0OzIvvjbEAvaWLlbs8wa3MtVLysHY/DfqRK9Zvr/RgrsYC6ukOB7igy2PGqZd+M MDnSmVzik0sPvB6xPV7QyFsykEgpnHbvdZAUy/vyys8xgT0PVYR5hyvhyf6VIfGuvqIsvJw5 C8+P71CHI+U/IhsKrLrsiYHpAhQkw+Zvyeml6XSi5w4LXDbF+3oholKYCkPwxmGdK8MUIdkM d7iYdKqiP4W6FKQou/lC3jvOceGupEoDV9botSWEIIlKdtm6C4GfL45RD8V4B9iy24JHPlom woVWc0xBZboQguhauQqrBFooHO3roEeM1pxXjLUbDtH4t3SAI3gt4dpSyT3EvzhyNQVVIxj2 FXnIChrYxR6S0ijSqUKO0cAduenhBrpYbz9qFcB/GyxD+ZWY7OgQKHUZMWapx5bHGQ8bUZz2 SfjZwK+GETGhfkvNMf6zXbZkDq4kKB/ywaKvVPodS1Poa44+B9sxbUp1jMfFtlOJ3AYB0WDS Op3d7F2ry20CIf1Ifh0nIxkQPkTX7aX5rI92oZeu5u038dHUu/dO2EcuCjl1eDMGm5PLHDSP 0QUw5xzk1Y8MG1JQ56PtqReO33inBXG63yTIikJmUXFTw6lLJwARAQABzTNCb3JpcyBPc3Ry b3Zza3kgKFdvcmspIDxib3Jpcy5vc3Ryb3Zza3lAb3JhY2xlLmNvbT7CwXgEEwECACIFAlH8 CgsCGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEIredpCGysGyasEP/j5xApopUf4g 9Fl3UxZuBx+oduuw3JHqgbGZ2siA3EA4bKwtKq8eT7ekpApn4c0HA8TWTDtgZtLSV5IdH+9z JimBDrhLkDI3Zsx2CafL4pMJvpUavhc5mEU8myp4dWCuIylHiWG65agvUeFZYK4P33fGqoaS VGx3tsQIAr7MsQxilMfRiTEoYH0WWthhE0YVQzV6kx4wj4yLGYPPBtFqnrapKKC8yFTpgjaK jImqWhU9CSUAXdNEs/oKVR1XlkDpMCFDl88vKAuJwugnixjbPFTVPyoC7+4Bm/FnL3iwlJVE qIGQRspt09r+datFzPqSbp5Fo/9m4JSvgtPp2X2+gIGgLPWp2ft1NXHHVWP19sPgEsEJXSr9 tskM8ScxEkqAUuDs6+x/ISX8wa5Pvmo65drN+JWA8EqKOHQG6LUsUdJolFM2i4Z0k40BnFU/ kjTARjrXW94LwokVy4x+ZYgImrnKWeKac6fMfMwH2aKpCQLlVxdO4qvJkv92SzZz4538az1T m+3ekJAimou89cXwXHCFb5WqJcyjDfdQF857vTn1z4qu7udYCuuV/4xDEhslUq1+GcNDjAhB nNYPzD+SvhWEsrjuXv+fDONdJtmLUpKs4Jtak3smGGhZsqpcNv8nQzUGDQZjuCSmDqW8vn2o hWwveNeRTkxh+2x1Qb3GT46uzsFNBFH8CgsBEADGC/yx5ctcLQlB9hbq7KNqCDyZNoYu1HAB Hal3MuxPfoGKObEktawQPQaSTB5vNlDxKihezLnlT/PKjcXC2R1OjSDinlu5XNGc6mnky03q yymUPyiMtWhBBftezTRxWRslPaFWlg/h/Y1iDuOcklhpr7K1h1jRPCrf1yIoxbIpDbffnuyz kuto4AahRvBU4Js4sU7f/btU+h+e0AcLVzIhTVPIz7PM+Gk2LNzZ3/on4dnEc/qd+ZZFlOQ4 KDN/hPqlwA/YJsKzAPX51L6Vv344pqTm6Z0f9M7YALB/11FO2nBB7zw7HAUYqJeHutCwxm7i BDNt0g9fhviNcJzagqJ1R7aPjtjBoYvKkbwNu5sWDpQ4idnsnck4YT6ctzN4I+6lfkU8zMzC gM2R4qqUXmxFIS4Bee+gnJi0Pc3KcBYBZsDK44FtM//5Cp9DrxRQOh19kNHBlxkmEb8kL/pw XIDcEq8MXzPBbxwHKJ3QRWRe5jPNpf8HCjnZz0XyJV0/4M1JvOua7IZftOttQ6KnM4m6WNIZ 2ydg7dBhDa6iv1oKdL7wdp/rCulVWn8R7+3cRK95SnWiJ0qKDlMbIN8oGMhHdin8cSRYdmHK kTnvSGJNlkis5a+048o0C6jI3LozQYD/W9wq7MvgChgVQw1iEOB4u/3FXDEGulRVko6xCBU4 SQARAQABwsFfBBgBAgAJBQJR/AoLAhsMAAoJEIredpCGysGyfvMQAIywR6jTqix6/fL0Ip8G jpt3uk//QNxGJE3ZkUNLX6N786vnEJvc1beCu6EwqD1ezG9fJKMl7F3SEgpYaiKEcHfoKGdh 30B3Hsq44vOoxR6zxw2B/giADjhmWTP5tWQ9548N4VhIZMYQMQCkdqaueSL+8asp8tBNP+TJ PAIIANYvJaD8xA7sYUXGTzOXDh2THWSvmEWWmzok8er/u6ZKdS1YmZkUy8cfzrll/9hiGCTj u3qcaOM6i/m4hqtvsI1cOORMVwjJF4+IkC5ZBoeRs/xW5zIBdSUoC8L+OCyj5JETWTt40+lu qoqAF/AEGsNZTrwHJYu9rbHH260C0KYCNqmxDdcROUqIzJdzDKOrDmebkEVnxVeLJBIhYZUd t3Iq9hdjpU50TA6sQ3mZxzBdfRgg+vaj2DsJqI5Xla9QGKD+xNT6v14cZuIMZzO7w0DoojM4 ByrabFsOQxGvE0w9Dch2BDSI2Xyk1zjPKxG1VNBQVx3flH37QDWpL2zlJikW29Ws86PHdthh Fm5PY8YtX576DchSP6qJC57/eAAe/9ztZdVAdesQwGb9hZHJc75B+VNm4xrh/PJO6c1THqdQ 19WVJ+7rDx3PhVncGlbAOiiiE3NOFPJ1OQYxPKtpBUukAlOTnkKE6QcA4zckFepUkfmBV1wM Jg6OxFYd01z+a+oL Message-ID: <50d0dbe1-533e-792a-6916-8c72d623064a@oracle.com> Date: Wed, 5 Aug 2020 09:31:13 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200804234201.GA23820@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9703 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 malwarescore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008050111 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9703 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 clxscore=1015 mlxscore=0 priorityscore=1501 mlxlogscore=999 malwarescore=0 adultscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 phishscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008050111 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: x86@kernel.org, len.brown@intel.com, peterz@infradead.org, benh@kernel.crashing.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, pavel@ucw.cz, hpa@zytor.com, Stefano Stabellini , eduval@amazon.com, mingo@redhat.com, xen-devel@lists.xenproject.org, sblbir@amazon.com, axboe@kernel.dk, konrad.wilk@oracle.com, bp@alien8.de, tglx@linutronix.de, jgross@suse.com, netdev@vger.kernel.org, linux-pm@vger.kernel.org, rjw@rjwysocki.net, kamatam@amazon.com, vkuznets@redhat.com, davem@davemloft.net, dwmw@amazon.co.uk, roger.pau@citrix.com Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 8/4/20 7:42 PM, Anchal Agarwal wrote: > > I think this could be done. PM_HIBERNATION_PREPARE could return -ENOTSU= PP > for arm and pvh dom0 when the notifier call chain is invoked for this c= ase > in hibernate(). This will then be an empty notifier just for checking t= wo > usecases. > Also, for pvh dom0, the earlier code didn't register any notifier, > with this approach you are suggesting setup the notifier for hvm/pvh do= m0 and > arm but fail during notifier call chain during PM_HIBERNATION_PREPARE ?= Right. (Although the earlier code did register the notifier: xen_setup_pm_notifier() would return an error for !xen_hvm_domain() and PVH *is* an HVM domain, so registration would actually happen) > > I think still getting rid of suspend mode that was earlier a part of th= is > notifier is a good idea as it seems redundant as you pointed out earlie= r.=20 Yes. -boris From xen-devel-bounces@lists.xenproject.org Wed Aug 05 13:55:34 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 13:55:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Jsq-0000Sf-VO; Wed, 05 Aug 2020 13:55:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Jsq-0000Sa-4v for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 13:55:08 +0000 X-Inumbo-ID: eefbd95f-2a62-4165-84c7-0511a117ab01 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id eefbd95f-2a62-4165-84c7-0511a117ab01; Wed, 05 Aug 2020 13:55:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596635706; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=4gaE8tRpToc/tJWR936re1gQrXhgXYeq0Cw0ab7DDzc=; b=iByycVsk1sGoMeq78N48XtUaJ6xyD1Y+SzERYWlwvOmEExJINesIS4/V g1kLPIEueIY5Rpip+OYSBmnTm84S0EVmE/0Rk4ud4WR6Q/rR7al85TZk0 SnzgcCt0sUgJ7VQbdU6OFZeHRfkUldYPKzFEItiaS3msdcJfh+Jv4zYRx Q=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: l3AaX3pjiT/6Ld2AsmG+4tHWQXSR/XNWZW4+dDgDdUU1Icc0YoEKLFli+JVwc4A4R1JExpg5+e v+SbinPt6V1uglH9UOcbhfKVckIrmozfDP7zwSJ7i1qIG7kBVeXR+1loRcuC3FSleKOLHlcjAY PwlOx0KzAXhz/yN7Om0CgixkbxCyUTcqxlefHwoFIL8AHv0riHByA+QoxK6Tp1oeiN3uMPEP0I QuRGV+JEaMO98orYLC/QuiwVNdftxbvXx02B35K2vvFuqKOT+iDUDWGg+fKg30x7KkiJa54FJT a/U= X-SBRS: 3.7 X-MesageID: 24253665 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,436,1589256000"; d="scan'208";a="24253665" From: Andrew Cooper To: Xen-devel Subject: [PATCH] x86/ioapic: Improve code generation for __io_apic_{read, write}() Date: Wed, 5 Aug 2020 14:54:18 +0100 Message-ID: <20200805135418.31528-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" The write into REGSEL prevents the optimiser from reusing the address calculation, forcing it to be calcualted twice. The calculation itself is quite expensive. Pull it out into a local varaible. Bloat-o-meter reports: add/remove: 0/0 grow/shrink: 0/26 up/down: 0/-1527 (-1527) Also correct the register type, which is uint32_t, not int. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné --- xen/include/asm-x86/io_apic.h | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/xen/include/asm-x86/io_apic.h b/xen/include/asm-x86/io_apic.h index daf17d4c3d..cb36e4ca1b 100644 --- a/xen/include/asm-x86/io_apic.h +++ b/xen/include/asm-x86/io_apic.h @@ -14,8 +14,8 @@ */ #define IO_APIC_BASE(idx) \ - ((volatile int *)(__fix_to_virt(FIX_IO_APIC_BASE_0 + idx) \ - + (mp_ioapics[idx].mpc_apicaddr & ~PAGE_MASK))) + ((volatile uint32_t *)(__fix_to_virt(FIX_IO_APIC_BASE_0 + idx) \ + + (mp_ioapics[idx].mpc_apicaddr & ~PAGE_MASK))) #define IO_APIC_ID(idx) (mp_ioapics[idx].mpc_apicid) @@ -135,8 +135,10 @@ unsigned int io_apic_gsi_base(unsigned int apic); static inline unsigned int __io_apic_read(unsigned int apic, unsigned int reg) { - *IO_APIC_BASE(apic) = reg; - return *(IO_APIC_BASE(apic)+4); + volatile uint32_t *regs = IO_APIC_BASE(apic); + + regs[0] = reg; + return regs[4]; } static inline unsigned int io_apic_read(unsigned int apic, unsigned int reg) @@ -148,8 +150,10 @@ static inline unsigned int io_apic_read(unsigned int apic, unsigned int reg) static inline void __io_apic_write(unsigned int apic, unsigned int reg, unsigned int value) { - *IO_APIC_BASE(apic) = reg; - *(IO_APIC_BASE(apic)+4) = value; + volatile uint32_t *regs = IO_APIC_BASE(apic); + + regs[0] = reg; + regs[4] = value; } static inline void io_apic_write(unsigned int apic, unsigned int reg, unsigned int value) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 14:12:49 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 14:12:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3K9k-0002Rd-1B; Wed, 05 Aug 2020 14:12:36 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3K9j-0002RY-0w for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 14:12:35 +0000 X-Inumbo-ID: be5b21f1-d1a8-4803-8e02-75a509e47075 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id be5b21f1-d1a8-4803-8e02-75a509e47075; Wed, 05 Aug 2020 14:12:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=HSjXZgwRmw4373BcTMA5IN7M3YvZ2IILySlCDnt9eQY=; b=mFLXHnggf9eVbfgKQ+we143Dal ViQEmaMnah4fB5yjuWwUmQ7nasuHCNvDBbmqyOSmiw4lkqBIQvTZXwC2MXPyStezc2OsvS62nfPEP WL0vH3CKd5lykcT9p/nzwlx6CLGvNcHaj5x3alIGEW42UGQ+wSEoCKam3qCpMNDj9MHY=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3K9X-0006ed-M0; Wed, 05 Aug 2020 14:12:23 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k3K9X-0003Mm-4N; Wed, 05 Aug 2020 14:12:23 +0000 Subject: Re: [RFC PATCH V1 04/12] xen/arm: Introduce arch specific bits for IOREQ/DM features To: Oleksandr Tyshchenko , xen-devel@lists.xenproject.org References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-5-git-send-email-olekstysh@gmail.com> From: Julien Grall Message-ID: <11eaa2f0-84c7-5972-d14c-4cb02458e882@xen.org> Date: Wed, 5 Aug 2020 15:12:20 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <1596478888-23030-5-git-send-email-olekstysh@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Julien Grall , Jan Beulich , Daniel De Graaf , Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Hi, On 03/08/2020 19:21, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > This patch makes possible to forward Guest MMIO accesses > to a device emulator on Arm and enables that support for > Arm64. > > Also update XSM code a bit to let DM op be used on Arm. > New arch DM op will be introduced in the follow-up patch. > > Please note, at the moment build on Arm32 is broken > (see cmpxchg usage in hvm_send_buffered_ioreq()) if someone > wants to enable CONFIG_IOREQ_SERVER due to the lack of > cmpxchg_64 support on Arm32. > > Please note, this is a split/cleanup of Julien's PoC: > "Add support for Guest IO forwarding to a device emulator" > > Signed-off-by: Julien Grall > Signed-off-by: Oleksandr Tyshchenko > --- > tools/libxc/xc_dom_arm.c | 25 +++++++--- > xen/arch/arm/Kconfig | 1 + > xen/arch/arm/Makefile | 2 + > xen/arch/arm/dm.c | 34 +++++++++++++ > xen/arch/arm/domain.c | 9 ++++ > xen/arch/arm/hvm.c | 46 +++++++++++++++++- > xen/arch/arm/io.c | 67 +++++++++++++++++++++++++- > xen/arch/arm/ioreq.c | 86 +++++++++++++++++++++++++++++++++ > xen/arch/arm/traps.c | 17 +++++++ > xen/common/memory.c | 5 +- > xen/include/asm-arm/domain.h | 80 +++++++++++++++++++++++++++++++ > xen/include/asm-arm/hvm/ioreq.h | 103 ++++++++++++++++++++++++++++++++++++++++ > xen/include/asm-arm/mmio.h | 1 + > xen/include/asm-arm/p2m.h | 7 +-- > xen/include/xsm/dummy.h | 4 +- > xen/include/xsm/xsm.h | 6 +-- > xen/xsm/dummy.c | 2 +- > xen/xsm/flask/hooks.c | 5 +- > 18 files changed, 476 insertions(+), 24 deletions(-) > create mode 100644 xen/arch/arm/dm.c > create mode 100644 xen/arch/arm/ioreq.c > create mode 100644 xen/include/asm-arm/hvm/ioreq.h It feels to me the patch is doing quite a few things that are indirectly related. Can this be split to make the review easier? I would like at least the following split from the series: - The tools changes - The P2M changes - The HVMOP plumbing (if we still require them) [...] > diff --git a/xen/arch/arm/dm.c b/xen/arch/arm/dm.c > new file mode 100644 > index 0000000..2437099 > --- /dev/null > +++ b/xen/arch/arm/dm.c > @@ -0,0 +1,34 @@ > +/* > + * Copyright (c) 2019 Arm ltd. > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms and conditions of the GNU General Public License, > + * version 2, as published by the Free Software Foundation. > + * > + * This program is distributed in the hope it will be useful, but WITHOUT > + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or > + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for > + * more details. > + * > + * You should have received a copy of the GNU General Public License along with > + * this program; If not, see . > + */ > + > +#include > +#include The list of includes sounds strange. Can we make sure to include only necessary headers and add the others when they are required? > + > +int arch_dm_op(struct xen_dm_op *op, struct domain *d, > + const struct dmop_args *op_args, bool *const_op) > +{ > + return -EOPNOTSUPP; > +} > + > +/* > + * Local variables: > + * mode: C > + * c-file-style: "BSD" > + * c-basic-offset: 4 > + * tab-width: 4 > + * indent-tabs-mode: nil > + * End: > + */ > long do_hvm_op(unsigned long op, XEN_GUEST_HANDLE_PARAM(void) arg) > { > long rc = 0; > @@ -111,7 +155,7 @@ long do_hvm_op(unsigned long op, XEN_GUEST_HANDLE_PARAM(void) arg) > if ( rc ) > goto param_fail; > > - d->arch.hvm.params[a.index] = a.value; > + rc = hvmop_set_param(d, &a); > } > else > { > diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c > index ae7ef96..436f669 100644 > --- a/xen/arch/arm/io.c > +++ b/xen/arch/arm/io.c > @@ -16,6 +16,7 @@ > * GNU General Public License for more details. > */ > > +#include > #include > #include > #include > @@ -107,6 +108,62 @@ static const struct mmio_handler *find_mmio_handler(struct domain *d, > return handler; > } > > +#ifdef CONFIG_IOREQ_SERVER Can we just implement this function in ioreq.c and provide a stub when !CONFIG_IOREQ_SERVER? > +static enum io_state try_fwd_ioserv(struct cpu_user_regs *regs, > + struct vcpu *v, mmio_info_t *info) > +{ > + struct hvm_vcpu_io *vio = &v->arch.hvm.hvm_io; > + ioreq_t p = { > + .type = IOREQ_TYPE_COPY, > + .addr = info->gpa, > + .size = 1 << info->dabt.size, > + .count = 0, > + .dir = !info->dabt.write, > + .df = 0, /* XXX: What's for? */ > + .data = get_user_reg(regs, info->dabt.reg), > + .state = STATE_IOREQ_READY, > + }; > + struct hvm_ioreq_server *s = NULL; > + enum io_state rc; > + > + switch ( vio->io_req.state ) > + { > + case STATE_IOREQ_NONE: > + break; > + default: > + printk("d%u wrong state %u\n", v->domain->domain_id, > + vio->io_req.state); This will likely want to be a gprintk() or gdprintk() to avoid a guest spamming Xen. > + return IO_ABORT; > + } > + > + s = hvm_select_ioreq_server(v->domain, &p); > + if ( !s ) > + return IO_UNHANDLED; > + > + if ( !info->dabt.valid ) > + { > + printk("Valid bit not set\n"); Same here. However, I am not convinced this is a useful message to keep. > + return IO_ABORT; > + } > + > + vio->io_req = p; > + > + rc = hvm_send_ioreq(s, &p, 0); > + if ( rc != IO_RETRY || v->domain->is_shutting_down ) > + vio->io_req.state = STATE_IOREQ_NONE; > + else if ( !hvm_ioreq_needs_completion(&vio->io_req) ) > + rc = IO_HANDLED; > + else > + vio->io_completion = HVMIO_mmio_completion; > + > + /* XXX: Decide what to do */ We want to understand how IO_RETRY can happen on x86 first. With that, we should be able to understand whether this can happen on Arm as well. > + if ( rc == IO_RETRY ) > + rc = IO_HANDLED; > + > + return rc; > +} > +#endif > + > enum io_state try_handle_mmio(struct cpu_user_regs *regs, > const union hsr hsr, > paddr_t gpa) > @@ -123,7 +180,15 @@ enum io_state try_handle_mmio(struct cpu_user_regs *regs, > > handler = find_mmio_handler(v->domain, info.gpa); > if ( !handler ) > - return IO_UNHANDLED; > + { > + int rc = IO_UNHANDLED; > + > +#ifdef CONFIG_IOREQ_SERVER > + rc = try_fwd_ioserv(regs, v, &info); > +#endif > + > + return rc; > + } > > /* All the instructions used on emulated MMIO region should be valid */ > if ( !dabt.valid ) > diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c > new file mode 100644 > index 0000000..a9cc839 > --- /dev/null > +++ b/xen/arch/arm/ioreq.c > @@ -0,0 +1,86 @@ > +/* > + * arm/ioreq.c: hardware virtual machine I/O emulation > + * > + * Copyright (c) 2019 Arm ltd. > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms and conditions of the GNU General Public License, > + * version 2, as published by the Free Software Foundation. > + * > + * This program is distributed in the hope it will be useful, but WITHOUT > + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or > + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for > + * more details. > + * > + * You should have received a copy of the GNU General Public License along with > + * this program; If not, see . > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > + > +bool handle_mmio(void) The name of the function is pretty generic and can be confusing on Arm (we already have a try_handle_mmio()). What is this function supposed to do? > +{ > + struct vcpu *v = current; > + struct cpu_user_regs *regs = guest_cpu_user_regs(); > + const union hsr hsr = { .bits = regs->hsr }; > + const struct hsr_dabt dabt = hsr.dabt; > + /* Code is similar to handle_read */ > + uint8_t size = (1 << dabt.size) * 8; > + register_t r = v->arch.hvm.hvm_io.io_req.data; > + > + /* We should only be here on Guest Data Abort */ > + ASSERT(dabt.ec == HSR_EC_DATA_ABORT_LOWER_EL); > + > + /* We are done with the IO */ > + /* XXX: Is it the right place? */ > + v->arch.hvm.hvm_io.io_req.state = STATE_IOREQ_NONE; > + > + /* XXX: Do we need to take care of write here ? */ > + if ( dabt.write ) > + return true; > + > + /* > + * Sign extend if required. > + * Note that we expect the read handler to have zeroed the bits > + * outside the requested access size. > + */ > + if ( dabt.sign && (r & (1UL << (size - 1))) ) > + { > + /* > + * We are relying on register_t using the same as > + * an unsigned long in order to keep the 32-bit assembly > + * code smaller. > + */ > + BUILD_BUG_ON(sizeof(register_t) != sizeof(unsigned long)); > + r |= (~0UL) << size; > + } > + > + set_user_reg(regs, dabt.reg, r); > + > + return true; > +} [...] > diff --git a/xen/common/memory.c b/xen/common/memory.c > index 9283e5e..0000477 100644 > --- a/xen/common/memory.c > +++ b/xen/common/memory.c > @@ -8,6 +8,7 @@ > */ > > #include > +#include > #include > #include > #include > @@ -30,10 +31,6 @@ > #include > #include > > -#ifdef CONFIG_IOREQ_SERVER > -#include > -#endif > - Why do you remove something your just introduced? > #ifdef CONFIG_X86 > #include > #endif > diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h > index 4e2f582..e060b0a 100644 > --- a/xen/include/asm-arm/domain.h > +++ b/xen/include/asm-arm/domain.h > @@ -11,12 +11,64 @@ > #include > #include > #include > +#include > +#include > #include > #include > > +struct hvm_ioreq_page { > + gfn_t gfn; > + struct page_info *page; > + void *va; > +}; AFAICT all the structures/define you introduced here are used by the code common. So it feels to me they should be defined in a common header. > + > +struct hvm_ioreq_vcpu { > + struct list_head list_entry; > + struct vcpu *vcpu; > + evtchn_port_t ioreq_evtchn; > + bool pending; > +}; > + > +#define NR_IO_RANGE_TYPES (XEN_DMOP_IO_RANGE_PCI + 1) > +#define MAX_NR_IO_RANGES 256 > + > +#define MAX_NR_IOREQ_SERVERS 8 > +#define DEFAULT_IOSERVID 0 > + > +struct hvm_ioreq_server { > + struct domain *target, *emulator; > + > + /* Lock to serialize toolstack modifications */ > + spinlock_t lock; > + > + struct hvm_ioreq_page ioreq; > + struct list_head ioreq_vcpu_list; > + struct hvm_ioreq_page bufioreq; > + > + /* Lock to serialize access to buffered ioreq ring */ > + spinlock_t bufioreq_lock; > + evtchn_port_t bufioreq_evtchn; > + struct rangeset *range[NR_IO_RANGE_TYPES]; > + bool enabled; > + uint8_t bufioreq_handling; > +}; > + > struct hvm_domain > { > uint64_t params[HVM_NR_PARAMS]; > + > + /* Guest page range used for non-default ioreq servers */ > + struct { > + unsigned long base; > + unsigned long mask; > + unsigned long legacy_mask; /* indexed by HVM param number */ > + } ioreq_gfn; > + > + /* Lock protects all other values in the sub-struct and the default */ > + struct { > + spinlock_t lock; > + struct hvm_ioreq_server *server[MAX_NR_IOREQ_SERVERS]; > + } ioreq_server; > }; > > #ifdef CONFIG_ARM_64 > @@ -93,6 +145,29 @@ struct arch_domain > #endif > } __cacheline_aligned; > > +enum hvm_io_completion { > + HVMIO_no_completion, > + HVMIO_mmio_completion, > + HVMIO_pio_completion, > + HVMIO_realmode_completion > +}; > + > +struct hvm_vcpu_io { > + /* I/O request in flight to device model. */ > + enum hvm_io_completion io_completion; > + ioreq_t io_req; > + > + /* > + * HVM emulation: > + * Linear address @mmio_gla maps to MMIO physical frame @mmio_gpfn. > + * The latter is known to be an MMIO frame (not RAM). > + * This translation is only valid for accesses as per @mmio_access. > + */ > + struct npfec mmio_access; > + unsigned long mmio_gla; > + unsigned long mmio_gpfn; > +}; > + > struct arch_vcpu > { > struct { > @@ -206,6 +281,11 @@ struct arch_vcpu > */ > bool need_flush_to_ram; > > + struct hvm_vcpu > + { > + struct hvm_vcpu_io hvm_io; > + } hvm; > + > } __cacheline_aligned; > > void vcpu_show_execution_state(struct vcpu *); > diff --git a/xen/include/asm-arm/hvm/ioreq.h b/xen/include/asm-arm/hvm/ioreq.h > new file mode 100644 > index 0000000..83a560c > --- /dev/null > +++ b/xen/include/asm-arm/hvm/ioreq.h > @@ -0,0 +1,103 @@ > +/* > + * hvm.h: Hardware virtual machine assist interface definitions. > + * > + * Copyright (c) 2016 Citrix Systems Inc. > + * Copyright (c) 2019 Arm ltd. > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms and conditions of the GNU General Public License, > + * version 2, as published by the Free Software Foundation. > + * > + * This program is distributed in the hope it will be useful, but WITHOUT > + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or > + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for > + * more details. > + * > + * You should have received a copy of the GNU General Public License along with > + * this program; If not, see . > + */ > + > +#ifndef __ASM_ARM_HVM_IOREQ_H__ > +#define __ASM_ARM_HVM_IOREQ_H__ > + > +#include > +#include > + > +#define has_vpci(d) (false) It feels to me this wants to be defined in vcpi.h. > + > +bool handle_mmio(void); > + > +static inline bool handle_pio(uint16_t port, unsigned int size, int dir) > +{ > + /* XXX */ Can you expand this TODO? What do you expect to do? > + BUG(); > + return true; > +} > + > +static inline paddr_t hvm_mmio_first_byte(const ioreq_t *p) > +{ > + return p->addr; > +} I understand that the x86 version is more complex as it check p->df. However, aside reducing the complexity, I am not sure why we would want to diverge it. After all, IOREQ is now meant to be a common feature. > + > +static inline paddr_t hvm_mmio_last_byte(const ioreq_t *p) > +{ > + unsigned long size = p->size; > + > + return p->addr + size - 1; > +} Same. > + > +struct hvm_ioreq_server; Why do we need a forward declaration? > + > +static inline int p2m_set_ioreq_server(struct domain *d, > + unsigned int flags, > + struct hvm_ioreq_server *s) > +{ > + return -EOPNOTSUPP; > +} This should be defined in p2m.h. But I am not even sure what it is meant for. Can you expand it? > + > +static inline void msix_write_completion(struct vcpu *v) > +{ > +} > + > +static inline void handle_realmode_completion(void) > +{ > + ASSERT_UNREACHABLE(); > +} realmode is very x86 specific. So I don't think this function should be called from common code. It might be worth considering to split handle_hvm_io_completion() is 2 parts: common and arch specific. > + > +static inline void paging_mark_pfn_dirty(struct domain *d, pfn_t pfn) > +{ > +} This will want to be stubbed in asm-arm/paging.h. > + > +static inline void hvm_get_ioreq_server_range_type(struct domain *d, > + ioreq_t *p, > + uint8_t *type, > + uint64_t *addr) > +{ > + *type = (p->type == IOREQ_TYPE_PIO) ? > + XEN_DMOP_IO_RANGE_PORT : XEN_DMOP_IO_RANGE_MEMORY; > + *addr = p->addr; > +} > + > +static inline void arch_hvm_ioreq_init(struct domain *d) > +{ > +} > + > +static inline void arch_hvm_ioreq_destroy(struct domain *d) > +{ > +} > + > +#define IOREQ_IO_HANDLED IO_HANDLED > +#define IOREQ_IO_UNHANDLED IO_UNHANDLED > +#define IOREQ_IO_RETRY IO_RETRY > + > +#endif /* __ASM_X86_HVM_IOREQ_H__ */ s/X86/ARM/ > + > +/* > + * Local variables: > + * mode: C > + * c-file-style: "BSD" > + * c-basic-offset: 4 > + * tab-width: 4 > + * indent-tabs-mode: nil > + * End: > + */ > diff --git a/xen/include/asm-arm/mmio.h b/xen/include/asm-arm/mmio.h > index 8dbfb27..7ab873c 100644 > --- a/xen/include/asm-arm/mmio.h > +++ b/xen/include/asm-arm/mmio.h > @@ -37,6 +37,7 @@ enum io_state > IO_ABORT, /* The IO was handled by the helper and led to an abort. */ > IO_HANDLED, /* The IO was successfully handled by the helper. */ > IO_UNHANDLED, /* The IO was not handled by the helper. */ > + IO_RETRY, /* Retry the emulation for some reason */ > }; > > typedef int (*mmio_read_t)(struct vcpu *v, mmio_info_t *info, > diff --git a/xen/include/asm-arm/p2m.h b/xen/include/asm-arm/p2m.h > index 5fdb6e8..5823f11 100644 > --- a/xen/include/asm-arm/p2m.h > +++ b/xen/include/asm-arm/p2m.h > @@ -385,10 +385,11 @@ static inline int set_foreign_p2m_entry(struct domain *d, unsigned long gfn, > mfn_t mfn) > { > /* > - * NOTE: If this is implemented then proper reference counting of > - * foreign entries will need to be implemented. > + * XXX: handle properly reference. It looks like the page may not always > + * belong to d. > */ > - return -EOPNOTSUPP; > + > + return guest_physmap_add_entry(d, _gfn(gfn), mfn, 0, p2m_ram_rw); Treating foreign as p2m_ram_rw is more an hack that a real fix. I have answered to this separately (see my answer on Stefano's e-mail), so we can continue the conversation there. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Aug 05 14:18:48 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 14:18:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3KFe-0002gj-MO; Wed, 05 Aug 2020 14:18:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3KFd-0002gc-E7 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 14:18:41 +0000 X-Inumbo-ID: 7302ee69-c1b0-4a6c-9fd3-66a3d6f35d8c Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7302ee69-c1b0-4a6c-9fd3-66a3d6f35d8c; Wed, 05 Aug 2020 14:18:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596637120; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=FDlDCRAZsXsq1+6c0TBThXxeS+gikua3wzMMup6S3zw=; b=Eif3x1mbLYd/bB/pc1QGfuqCxgTyrNXNpVjKvBsLycD24DRmoV7h86Rg a7l+kzVN0ZGizdHpmmLUlkrUEhqjniRuu1e75vhc1sbFFy6cwcstKTqpg ofWsySIwZeGJKY66ZnTktIPRz+82Cb/E9ghMls0Z/HcfAtE8vxLsvvTc6 0=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: yzYfChoYxqjXz6ZNKPrQGxfomKQf/lwxSR0u6zFXYBscLaDeYVSFkkF6r3ordtJAJyfAtaeW0W xugH1geM/s0FmSlhkicjqr8XsFtANsPJBd0xl4KPAmPcdVQaIOdNAPgp/Gyx01gVnYDjxDtubY VggY7gMlsl+EVZNJmGADmnp9tTDiuSahFMAxxICq5PmUKHDg8RKrkpVOJ8DhHpt/MYr00NNkBl EJXxqV5JehOuZu3R6Yc8YlH70U4pFGQL2vU1+MRtZhWnm2lplAbgOEQHQa2L4tvOhUYzVFctH0 s5I= X-SBRS: 3.7 X-MesageID: 24267910 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,436,1589256000"; d="scan'208";a="24267910" From: Andrew Cooper To: Xen-devel Subject: [PATCH] x86/tsc: Fix diagnostics for TSC frequency Date: Wed, 5 Aug 2020 15:18:04 +0100 Message-ID: <20200805141804.2585-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" A Gemini Lake platform prints: (XEN) CPU0: TSC: 19200000MHz * 279 / 3 = 1785600000MHz (XEN) CPU0: 800..1800 MHz during boot. The units on the first line are Hz, not MHz, so correct that and add a space for clarity. Also, for the min/max line, use three dots instead of two and add more spaces so that the line can't be mistaken for being a double decimal point typo. Boot now reads: (XEN) CPU0: TSC: 19200000 Hz * 279 / 3 = 1785600000 Hz (XEN) CPU0: 800 ... 1800 MHz Extend these changes to the other TSC diagnostics. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné --- xen/arch/x86/cpu/amd.c | 4 ++-- xen/arch/x86/cpu/intel.c | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c index 0cc6853c42..8bc51bec10 100644 --- a/xen/arch/x86/cpu/amd.c +++ b/xen/arch/x86/cpu/amd.c @@ -624,10 +624,10 @@ void amd_log_freq(const struct cpuinfo_x86 *c) if (idx && idx < h && !rdmsr_safe(0xC0010064 + idx, val) && (val >> 63) && !rdmsr_safe(0xC0010064, hi) && (hi >> 63)) - printk("CPU%u: %lu (%lu..%lu) MHz\n", + printk("CPU%u: %lu (%lu ... %lu) MHz\n", smp_processor_id(), FREQ(val), FREQ(lo), FREQ(hi)); else if (h && !rdmsr_safe(0xC0010064, hi) && (hi >> 63)) - printk("CPU%u: %lu..%lu MHz\n", + printk("CPU%u: %lu ... %lu MHz\n", smp_processor_id(), FREQ(lo), FREQ(hi)); else printk("CPU%u: %lu MHz\n", smp_processor_id(), FREQ(lo)); diff --git a/xen/arch/x86/cpu/intel.c b/xen/arch/x86/cpu/intel.c index 69e99bb358..ed70b43942 100644 --- a/xen/arch/x86/cpu/intel.c +++ b/xen/arch/x86/cpu/intel.c @@ -396,14 +396,14 @@ static void intel_log_freq(const struct cpuinfo_x86 *c) val *= ebx; do_div(val, eax); - printk("CPU%u: TSC: %uMHz * %u / %u = %LuMHz\n", + printk("CPU%u: TSC: %u Hz * %u / %u = %Lu Hz\n", smp_processor_id(), ecx, ebx, eax, val); } else if ( ecx | eax | ebx ) { printk("CPU%u: TSC:", smp_processor_id()); if ( ecx ) - printk(" core: %uMHz", ecx); + printk(" core: %u MHz", ecx); if ( ebx && eax ) printk(" ratio: %u / %u", ebx, eax); printk("\n"); @@ -417,11 +417,11 @@ static void intel_log_freq(const struct cpuinfo_x86 *c) { printk("CPU%u:", smp_processor_id()); if ( ecx ) - printk(" bus: %uMHz", ecx); + printk(" bus: %u MHz", ecx); if ( eax ) - printk(" base: %uMHz", eax); + printk(" base: %u MHz", eax); if ( ebx ) - printk(" max: %uMHz", ebx); + printk(" max: %u MHz", ebx); printk("\n"); } } @@ -446,7 +446,7 @@ static void intel_log_freq(const struct cpuinfo_x86 *c) printk("CPU%u: ", smp_processor_id()); if ( min_ratio ) - printk("%u..", (factor * min_ratio + 50) / 100); + printk("%u ... ", (factor * min_ratio + 50) / 100); printk("%u MHz\n", (factor * max_ratio + 50) / 100); } } -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 14:36:49 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 14:36:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3KX0-0004Oo-4t; Wed, 05 Aug 2020 14:36:38 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3KWz-0004Oj-5g for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 14:36:37 +0000 X-Inumbo-ID: 0e554b42-3d77-44ab-9eda-bdd0eca77639 Received: from mga07.intel.com (unknown [134.134.136.100]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0e554b42-3d77-44ab-9eda-bdd0eca77639; Wed, 05 Aug 2020 14:36:35 +0000 (UTC) IronPort-SDR: ziMiWei4GPhfYZ/fKpe31rZXwcW32hbUSqQw4t1hRd55Y+xv3MrzJmttGKfVb73AfN5WC5bwYI xj4rwkhglJSw== X-IronPort-AV: E=McAfee;i="6000,8403,9703"; a="216911708" X-IronPort-AV: E=Sophos;i="5.75,436,1589266800"; d="scan'208";a="216911708" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Aug 2020 07:36:33 -0700 IronPort-SDR: 5s5xL7ULjjcKwA1ZbMpzVSNN1By1k0TkGC8gswbPhyywEmWjzJT3xp3c7P9Gm/qC4oSD3648GN nvO0VM/eQO3A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,436,1589266800"; d="scan'208";a="323117445" Received: from lkp-server02.sh.intel.com (HELO 37a337f97289) ([10.239.97.151]) by orsmga008.jf.intel.com with ESMTP; 05 Aug 2020 07:36:30 -0700 Received: from kbuild by 37a337f97289 with local (Exim 4.92) (envelope-from ) id 1k3KWs-0000oK-7X; Wed, 05 Aug 2020 14:36:30 +0000 Date: Wed, 5 Aug 2020 22:35:32 +0800 From: kernel test robot To: Oleksandr Andrushchenko , xen-devel@lists.xenproject.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, boris.ostrovsky@oracle.com, jgross@suse.com, airlied@linux.ie, daniel@ffwll.ch Subject: Re: [Intel-gfx] [PATCH 6/6] drm/xen-front: Add support for EDID based configuration Message-ID: <202008052221.duhA3v0p%lkp@intel.com> References: <20200731125109.18666-7-andr2000@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200731125109.18666-7-andr2000@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, sstabellini@kernel.org, kbuild-all@lists.01.org, dan.carpenter@oracle.com Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Hi Oleksandr, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-exynos/exynos-drm-next] [also build test WARNING on drm-intel/for-linux-next tegra-drm/drm/tegra/for-next drm-tip/drm-tip linus/master v5.8 next-20200804] [cannot apply to xen-tip/linux-next drm/drm-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Oleksandr-Andrushchenko/Fixes-and-improvements-for-Xen-pvdrm/20200731-205350 base: https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git exynos-drm-next compiler: aarch64-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot cppcheck warnings: (new ones prefixed by >>) >> drivers/irqchip/irq-gic.c:161:24: warning: Local variable gic_data shadows outer variable [shadowVar] struct gic_chip_data *gic_data = irq_data_get_irq_chip_data(d); ^ drivers/irqchip/irq-gic.c:123:29: note: Shadowed declaration static struct gic_chip_data gic_data[CONFIG_ARM_GIC_MAX_NR] __read_mostly; ^ drivers/irqchip/irq-gic.c:161:24: note: Shadow variable struct gic_chip_data *gic_data = irq_data_get_irq_chip_data(d); ^ drivers/irqchip/irq-gic.c:167:24: warning: Local variable gic_data shadows outer variable [shadowVar] struct gic_chip_data *gic_data = irq_data_get_irq_chip_data(d); ^ drivers/irqchip/irq-gic.c:123:29: note: Shadowed declaration static struct gic_chip_data gic_data[CONFIG_ARM_GIC_MAX_NR] __read_mostly; ^ drivers/irqchip/irq-gic.c:167:24: note: Shadow variable struct gic_chip_data *gic_data = irq_data_get_irq_chip_data(d); ^ >> drivers/irqchip/irq-gic.c:400:28: warning: Local variable gic_irq shadows outer function [shadowFunction] unsigned int cascade_irq, gic_irq; ^ drivers/irqchip/irq-gic.c:171:28: note: Shadowed declaration static inline unsigned int gic_irq(struct irq_data *d) ^ drivers/irqchip/irq-gic.c:400:28: note: Shadow variable unsigned int cascade_irq, gic_irq; ^ >> drivers/irqchip/irq-gic.c:1507:14: warning: Local variable gic_cpu_base shadows outer function [shadowFunction] phys_addr_t gic_cpu_base; ^ drivers/irqchip/irq-gic.c:165:29: note: Shadowed declaration static inline void __iomem *gic_cpu_base(struct irq_data *d) ^ drivers/irqchip/irq-gic.c:1507:14: note: Shadow variable phys_addr_t gic_cpu_base; ^ >> drivers/irqchip/irq-gic-v3.c:874:71: warning: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] gic_data.rdists.has_direct_lpi &= (!!(typer & GICR_TYPER_DirectLPIS) | ^ >> drivers/irqchip/irq-gic-v3.c:1808:6: warning: Local variable nr_redist_regions shadows outer variable [shadowVar] u32 nr_redist_regions; ^ drivers/irqchip/irq-gic-v3.c:1880:6: note: Shadowed declaration u32 nr_redist_regions; ^ drivers/irqchip/irq-gic-v3.c:1808:6: note: Shadow variable u32 nr_redist_regions; ^ >> drivers/irqchip/irq-gic-v3.c:2042:6: warning: Local variable maint_irq_mode shadows outer variable [shadowVar] int maint_irq_mode; ^ drivers/irqchip/irq-gic-v3.c:1884:6: note: Shadowed declaration int maint_irq_mode; ^ drivers/irqchip/irq-gic-v3.c:2042:6: note: Shadow variable int maint_irq_mode; ^ >> drivers/gpu/drm/xen/xen_drm_front_cfg.c:76:6: warning: Variable 'ret' is reassigned a value before the old one has been used. [redundantAssignment] ret = xen_drm_front_get_edid(front_info, index, pages, ^ drivers/gpu/drm/xen/xen_drm_front_cfg.c:61:0: note: Variable 'ret' is reassigned a value before the old one has been used. int i, npages, ret = -ENOMEM; ^ drivers/gpu/drm/xen/xen_drm_front_cfg.c:76:6: note: Variable 'ret' is reassigned a value before the old one has been used. ret = xen_drm_front_get_edid(front_info, index, pages, ^ vim +/ret +76 drivers/gpu/drm/xen/xen_drm_front_cfg.c 54 55 static void cfg_connector_edid(struct xen_drm_front_info *front_info, 56 struct xen_drm_front_cfg_connector *connector, 57 int index) 58 { 59 struct page **pages; 60 u32 edid_sz; 61 int i, npages, ret = -ENOMEM; 62 63 connector->edid = vmalloc(XENDISPL_EDID_MAX_SIZE); 64 if (!connector->edid) 65 goto fail; 66 67 npages = DIV_ROUND_UP(XENDISPL_EDID_MAX_SIZE, PAGE_SIZE); 68 pages = kvmalloc_array(npages, sizeof(struct page *), GFP_KERNEL); 69 if (!pages) 70 goto fail_free_edid; 71 72 for (i = 0; i < npages; i++) 73 pages[i] = vmalloc_to_page((u8 *)connector->edid + 74 i * PAGE_SIZE); 75 > 76 ret = xen_drm_front_get_edid(front_info, index, pages, 77 XENDISPL_EDID_MAX_SIZE, &edid_sz); 78 79 kvfree(pages); 80 81 if (ret < 0) 82 goto fail_free_edid; 83 84 ret = -EINVAL; 85 if (!edid_sz || (edid_sz % EDID_LENGTH)) 86 goto fail_free_edid; 87 88 if (!drm_edid_is_valid(connector->edid)) 89 goto fail_free_edid; 90 91 DRM_INFO("Connector %s: using EDID for configuration, size %d\n", 92 connector->xenstore_path, edid_sz); 93 return; 94 95 fail_free_edid: 96 cfg_connector_free_edid(connector); 97 fail: 98 /* 99 * If any error this is not critical as we can still read 100 * connector settings from XenStore, so just warn. 101 */ 102 DRM_WARN("Connector %s: cannot read or wrong EDID: %d\n", 103 connector->xenstore_path, ret); 104 } 105 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org From xen-devel-bounces@lists.xenproject.org Wed Aug 05 14:45:38 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 14:45:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Kfd-0005Jv-5M; Wed, 05 Aug 2020 14:45:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Kfb-0005Jq-LY for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 14:45:31 +0000 X-Inumbo-ID: 06460938-a0d4-4e11-be43-98d59004d314 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 06460938-a0d4-4e11-be43-98d59004d314; Wed, 05 Aug 2020 14:45:30 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 38121B717; Wed, 5 Aug 2020 14:45:46 +0000 (UTC) Subject: Re: [RFC PATCH V1 04/12] xen/arm: Introduce arch specific bits for IOREQ/DM features To: Julien Grall References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-5-git-send-email-olekstysh@gmail.com> <11eaa2f0-84c7-5972-d14c-4cb02458e882@xen.org> From: Jan Beulich Message-ID: <4f17bfb9-0c65-3903-42f4-2826baab2649@suse.com> Date: Wed, 5 Aug 2020 16:45:29 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <11eaa2f0-84c7-5972-d14c-4cb02458e882@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Oleksandr Tyshchenko , Julien Grall , xen-devel@lists.xenproject.org, Daniel De Graaf , Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 05.08.2020 16:12, Julien Grall wrote: > On 03/08/2020 19:21, Oleksandr Tyshchenko wrote: >> --- /dev/null >> +++ b/xen/include/asm-arm/hvm/ioreq.h >> @@ -0,0 +1,103 @@ >> +/* >> + * hvm.h: Hardware virtual machine assist interface definitions. >> + * >> + * Copyright (c) 2016 Citrix Systems Inc. >> + * Copyright (c) 2019 Arm ltd. >> + * >> + * This program is free software; you can redistribute it and/or modify it >> + * under the terms and conditions of the GNU General Public License, >> + * version 2, as published by the Free Software Foundation. >> + * >> + * This program is distributed in the hope it will be useful, but WITHOUT >> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or >> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for >> + * more details. >> + * >> + * You should have received a copy of the GNU General Public License along with >> + * this program; If not, see . >> + */ >> + >> +#ifndef __ASM_ARM_HVM_IOREQ_H__ >> +#define __ASM_ARM_HVM_IOREQ_H__ >> + >> +#include >> +#include >> + >> +#define has_vpci(d) (false) > > It feels to me this wants to be defined in vcpi.h. On x86 it wants to live together with a bunch of other has_v*() macros. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 14:54:30 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 14:54:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3KoB-0006Fc-1Z; Wed, 05 Aug 2020 14:54:23 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Ko9-0006FX-Qs for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 14:54:21 +0000 X-Inumbo-ID: 44afce2c-2a43-4112-a806-20a68c5b0777 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 44afce2c-2a43-4112-a806-20a68c5b0777; Wed, 05 Aug 2020 14:54:20 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AA03DACA3; Wed, 5 Aug 2020 14:54:36 +0000 (UTC) Subject: Re: [PATCH] x86/tsc: Fix diagnostics for TSC frequency To: Andrew Cooper References: <20200805141804.2585-1-andrew.cooper3@citrix.com> From: Jan Beulich Message-ID: <3123eedc-252d-7e9e-a4af-6f8bfae82f41@suse.com> Date: Wed, 5 Aug 2020 16:54:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200805141804.2585-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Xen-devel , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 05.08.2020 16:18, Andrew Cooper wrote: > A Gemini Lake platform prints: > > (XEN) CPU0: TSC: 19200000MHz * 279 / 3 = 1785600000MHz > (XEN) CPU0: 800..1800 MHz > > during boot. The units on the first line are Hz, not MHz, so correct that and > add a space for clarity. > > Also, for the min/max line, use three dots instead of two and add more spaces > so that the line can't be mistaken for being a double decimal point typo. > > Boot now reads: > > (XEN) CPU0: TSC: 19200000 Hz * 279 / 3 = 1785600000 Hz > (XEN) CPU0: 800 ... 1800 MHz > > Extend these changes to the other TSC diagnostics. I'm happy to see the unit mistake fixed, but the choice of formatting was pretty deliberate when the code was introduced: As dense as possible without making things unreadable or ambiguous. (Considering "a double decimal point typo" looks like a joke to me, really.) > --- a/xen/arch/x86/cpu/intel.c > +++ b/xen/arch/x86/cpu/intel.c > @@ -396,14 +396,14 @@ static void intel_log_freq(const struct cpuinfo_x86 *c) > > val *= ebx; > do_div(val, eax); > - printk("CPU%u: TSC: %uMHz * %u / %u = %LuMHz\n", > + printk("CPU%u: TSC: %u Hz * %u / %u = %Lu Hz\n", > smp_processor_id(), ecx, ebx, eax, val); For this one I wonder whether ecx wouldn't better be scaled down to kHz, and val down to MHz. > } > else if ( ecx | eax | ebx ) > { > printk("CPU%u: TSC:", smp_processor_id()); > if ( ecx ) > - printk(" core: %uMHz", ecx); > + printk(" core: %u MHz", ecx); This one now clearly wants to say Hz too, or (as above) scaling down to kHz. With at least this last issue addressed Reviewed-by: Jan Beulich albeit I'd much prefer if the formatting adjustments were dropped. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 15:05:26 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 15:05:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3KyX-0007Ek-1l; Wed, 05 Aug 2020 15:05:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3KyW-0007Ef-5I for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 15:05:04 +0000 X-Inumbo-ID: 8c8dc02d-2d64-4142-aa53-d8bf646fba30 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8c8dc02d-2d64-4142-aa53-d8bf646fba30; Wed, 05 Aug 2020 15:05:03 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 41B76AC7F; Wed, 5 Aug 2020 15:05:19 +0000 (UTC) Subject: Re: [PATCH] x86/ioapic: Fix fixmap error path logic in ioapic_init_mappings() To: Andrew Cooper References: <20200805125109.7348-1-andrew.cooper3@citrix.com> From: Jan Beulich Message-ID: Date: Wed, 5 Aug 2020 17:05:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200805125109.7348-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Xen-devel , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 05.08.2020 14:51, Andrew Cooper wrote: > In the case that bad_ioapic_register() fails, the current position of idx++ > means that clear_fixmap(idx) will be called with the wrong index, and not > clean up the mapping just created. > > Increment idx as part of the loop, rather than midway through the loop body. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Wed Aug 05 15:08:08 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 15:08:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3L1T-0007OC-HI; Wed, 05 Aug 2020 15:08:07 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3L1S-0007O7-A3 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 15:08:06 +0000 X-Inumbo-ID: 2f524f99-b9f5-4538-8df4-5e5e98e2d2bd Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2f524f99-b9f5-4538-8df4-5e5e98e2d2bd; Wed, 05 Aug 2020 15:08:05 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 88212AC7F; Wed, 5 Aug 2020 15:08:21 +0000 (UTC) Subject: Re: [PATCH] x86/ioapic: Fix style in io_apic.h To: Andrew Cooper References: <20200805125124.7763-1-andrew.cooper3@citrix.com> From: Jan Beulich Message-ID: Date: Wed, 5 Aug 2020 17:08:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200805125124.7763-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Xen-devel , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 05.08.2020 14:51, Andrew Cooper wrote: > This file is a mix of Xen and Linux styles. Switch it fully to Xen style. > > No functional change. > > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich with a suggestion and, I'm afraid, a few more adjustments: > --- a/xen/include/asm-x86/io_apic.h > +++ b/xen/include/asm-x86/io_apic.h > @@ -13,9 +13,9 @@ > * Copyright (C) 1997, 1998, 1999, 2000 Ingo Molnar > */ > > -#define IO_APIC_BASE(idx) \ > - ((volatile int *)(__fix_to_virt(FIX_IO_APIC_BASE_0 + idx) \ > - + (mp_ioapics[idx].mpc_apicaddr & ~PAGE_MASK))) > +#define IO_APIC_BASE(idx) \ > + ((volatile int *)(__fix_to_virt(FIX_IO_APIC_BASE_0 + idx) \ > + + (mp_ioapics[idx].mpc_apicaddr & ~PAGE_MASK))) As you touch this anyway, would you mind parenthesizing idx when used as a, operand of + ? > @@ -135,28 +135,28 @@ unsigned int io_apic_gsi_base(unsigned int apic); > > static inline unsigned int __io_apic_read(unsigned int apic, unsigned int reg) > { > - *IO_APIC_BASE(apic) = reg; > - return *(IO_APIC_BASE(apic)+4); > + *IO_APIC_BASE(apic) = reg; > + return *(IO_APIC_BASE(apic)+4); Here and below + wants to be framed by spaces. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 15:10:36 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 15:10:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3L3m-00088r-V7; Wed, 05 Aug 2020 15:10:30 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3L3l-00088m-KA for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 15:10:29 +0000 X-Inumbo-ID: b62ff4a0-1d21-46da-8135-dcc0228eaac0 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b62ff4a0-1d21-46da-8135-dcc0228eaac0; Wed, 05 Aug 2020 15:10:28 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 87E42AF9F; Wed, 5 Aug 2020 15:10:44 +0000 (UTC) Subject: Re: [PATCH] x86/ioapic: Improve code generation for __io_apic_{read,write}() To: Andrew Cooper References: <20200805135418.31528-1-andrew.cooper3@citrix.com> From: Jan Beulich Message-ID: <4d7d2f7a-b37a-4487-5626-4861953042eb@suse.com> Date: Wed, 5 Aug 2020 17:10:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200805135418.31528-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Xen-devel , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 05.08.2020 15:54, Andrew Cooper wrote: > The write into REGSEL prevents the optimiser from reusing the address > calculation, forcing it to be calcualted twice. > > The calculation itself is quite expensive. Pull it out into a local varaible. > > Bloat-o-meter reports: > add/remove: 0/0 grow/shrink: 0/26 up/down: 0/-1527 (-1527) > > Also correct the register type, which is uint32_t, not int. > > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Wed Aug 05 15:11:05 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 15:11:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3L4L-0008Cf-84; Wed, 05 Aug 2020 15:11:05 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3L4J-0008C8-DE for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 15:11:03 +0000 X-Inumbo-ID: d53f5629-089f-4108-82d7-d237a3eb5010 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d53f5629-089f-4108-82d7-d237a3eb5010; Wed, 05 Aug 2020 15:10:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To:Sender: Reply-To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=w4q0oysIxaLNxRB+TodGGYga9pYqch9z9aTZXCIoq4Y=; b=f30zM5bI9I54JDnOb1ma469nHi UnehWo3MVuJh8ODjXw/uK9r/QqaPpqYv5/bZ7q1QH6+H19U/GMg8fXwlj5uSHqqmI+beZu580FCYg OhLaSqgdzXwRKxupd32WPZkHBtv7KdAKk/VHr4d419F9f45Ip5pxBRkaOkF3pUuY0j0o=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3L4E-0007v0-Tg; Wed, 05 Aug 2020 15:10:58 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k3L4E-0007i0-JB; Wed, 05 Aug 2020 15:10:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k3L4E-0006Dy-IT; Wed, 05 Aug 2020 15:10:58 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Subject: [qemu-mainline bisection] complete test-amd64-i386-xl-qemuu-ws16-amd64 Message-Id: From: osstest service owner Date: Wed, 05 Aug 2020 15:10:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" branch xen-unstable xenbranch xen-unstable job test-amd64-i386-xl-qemuu-ws16-amd64 testid windows-install Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://git.qemu.org/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: qemuu git://git.qemu.org/qemu.git Bug introduced: 7d3660e79830a069f1848bb4fa1cdf8f666424fb Bug not present: 9e3903136d9acde2fb2dd9e967ba928050a6cb4a Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/152490/ (Revision log too long, omitted.) For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/qemu-mainline/test-amd64-i386-xl-qemuu-ws16-amd64.windows-install.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/qemu-mainline/test-amd64-i386-xl-qemuu-ws16-amd64.windows-install --summary-out=tmp/152490.bisection-summary --basis-template=151065 --blessings=real,real-bisect qemu-mainline test-amd64-i386-xl-qemuu-ws16-amd64 windows-install Searching for failure / basis pass: 152456 fail [host=fiano1] / 151065 ok. Failure / basis pass flights: 152456 / 151065 (tree with no url: minios) Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://git.qemu.org/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git Latest c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 e557442e3f7ec7bee2d886978bbd259c6d68c75a 3c659044118e34603161457db9934a34f816d78b 5c1c3e4f02e458cf280c677c817ae4fd1ed9bf10 d9c812dda519a1a73e8370e1b81ddf46eb22ed16 81fd0d3ca4b2cd309403c6e8da662c325dd35750 Basis pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 dafce295e6f447ed8905db4e29241e2c6c2a4389 3c659044118e34603161457db9934a34f816d78b 9e3903136d9acde2fb2dd9e967ba928050a6cb4a 2e3de6253422112ae43e608661ba94ea6b345694 058023b343d4e366864831db46e9b438e9e3a178 Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/linux-pvops.git#c3038e718a19fc596f7b1baba0f83d5146dc7784-c3038e718a19fc596f7b1baba0f83d5146dc7784 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/osstest/ovmf.git#dafce295e6f447ed8905db4e29241e2c6c2a4389-e557442e3f7ec7bee2d886978bbd259c6d68c75a git://xenbits.xen.org/qemu-xen-traditional.git#3c659044118e34603161457db99\ 34a34f816d78b-3c659044118e34603161457db9934a34f816d78b git://git.qemu.org/qemu.git#9e3903136d9acde2fb2dd9e967ba928050a6cb4a-5c1c3e4f02e458cf280c677c817ae4fd1ed9bf10 git://xenbits.xen.org/osstest/seabios.git#2e3de6253422112ae43e608661ba94ea6b345694-d9c812dda519a1a73e8370e1b81ddf46eb22ed16 git://xenbits.xen.org/xen.git#058023b343d4e366864831db46e9b438e9e3a178-81fd0d3ca4b2cd309403c6e8da662c325dd35750 >From git://cache:9419/git://xenbits.xen.org/xen c9f9a7258d..e58a71274c smoke -> origin/smoke Use of uninitialized value $parents in array dereference at ./adhoc-revtuple-generator line 465. Use of uninitialized value in concatenation (.) or string at ./adhoc-revtuple-generator line 465. Use of uninitialized value $parents in array dereference at ./adhoc-revtuple-generator line 465. Use of uninitialized value in concatenation (.) or string at ./adhoc-revtuple-generator line 465. Use of uninitialized value $parents in array dereference at ./adhoc-revtuple-generator line 465. Use of uninitialized value in concatenation (.) or string at ./adhoc-revtuple-generator line 465. Use of uninitialized value $parents in array dereference at ./adhoc-revtuple-generator line 465. Use of uninitialized value in concatenation (.) or string at ./adhoc-revtuple-generator line 465. Loaded 55467 nodes in revision graph Searching for test results: 151101 fail irrelevant 151065 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 dafce295e6f447ed8905db4e29241e2c6c2a4389 3c659044118e34603161457db9934a34f816d78b 9e3903136d9acde2fb2dd9e967ba928050a6cb4a 2e3de6253422112ae43e608661ba94ea6b345694 058023b343d4e366864831db46e9b438e9e3a178 151149 [host=fiano0] 151221 fail irrelevant 151175 [host=fiano0] 151241 fail irrelevant 151286 fail irrelevant 151269 fail irrelevant 151328 fail irrelevant 151304 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 322969adf1fb3d6cfbd613f35121315715aff2ed 3c659044118e34603161457db9934a34f816d78b 171199f56f5f9bdf1e5d670d09ef1351d8f01bae 2e3de6253422112ae43e608661ba94ea6b345694 fde76f895d0aa817a1207d844d793239c6639bc6 151377 fail irrelevant 151353 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 1a992030522622c42aa063788b3276789c56c1e1 3c659044118e34603161457db9934a34f816d78b d4b78317b7cf8c0c635b70086503813f79ff21ec 2e3de6253422112ae43e608661ba94ea6b345694 fde76f895d0aa817a1207d844d793239c6639bc6 151399 fail irrelevant 151414 fail irrelevant 151435 fail irrelevant 151459 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 0f01cec52f4794777feb067e4fa0bfcedfdc124e 3c659044118e34603161457db9934a34f816d78b e7651153a8801dad6805d450ea8bef9b46c1adf5 88ab0c15525ced2eefe39220742efe4769089ad8 88cfd062e8318dfeb67c7d2eb50b6cd224b0738a 151471 fail irrelevant 151485 fail irrelevant 151500 fail irrelevant 151518 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 00217f1919270007d7a911f89b32e39b9dcaa907 3c659044118e34603161457db9934a34f816d78b fc1bff958998910ec8d25db86cd2f53ff125f7ab 88ab0c15525ced2eefe39220742efe4769089ad8 23ca7ec0ba620db52a646d80e22f9703a6589f66 151547 fail irrelevant 151598 fail irrelevant 151577 fail irrelevant 151622 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 627d1d6693b0594d257dbe1a3363a8d4bd4d8307 3c659044118e34603161457db9934a34f816d78b 7b7515702012219410802a168ae4aa45b72a44df 88ab0c15525ced2eefe39220742efe4769089ad8 be63d9d47f571a60d70f8fb630c03871312d9655 151656 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 627d1d6693b0594d257dbe1a3363a8d4bd4d8307 3c659044118e34603161457db9934a34f816d78b eb6490f544388dd24c0d054a96dd304bc7284450 88ab0c15525ced2eefe39220742efe4769089ad8 be63d9d47f571a60d70f8fb630c03871312d9655 151634 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 627d1d6693b0594d257dbe1a3363a8d4bd4d8307 3c659044118e34603161457db9934a34f816d78b eb6490f544388dd24c0d054a96dd304bc7284450 88ab0c15525ced2eefe39220742efe4769089ad8 be63d9d47f571a60d70f8fb630c03871312d9655 151645 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 627d1d6693b0594d257dbe1a3363a8d4bd4d8307 3c659044118e34603161457db9934a34f816d78b eb6490f544388dd24c0d054a96dd304bc7284450 88ab0c15525ced2eefe39220742efe4769089ad8 be63d9d47f571a60d70f8fb630c03871312d9655 151669 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 627d1d6693b0594d257dbe1a3363a8d4bd4d8307 3c659044118e34603161457db9934a34f816d78b eb6490f544388dd24c0d054a96dd304bc7284450 88ab0c15525ced2eefe39220742efe4769089ad8 be63d9d47f571a60d70f8fb630c03871312d9655 151685 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 627d1d6693b0594d257dbe1a3363a8d4bd4d8307 3c659044118e34603161457db9934a34f816d78b eb6490f544388dd24c0d054a96dd304bc7284450 88ab0c15525ced2eefe39220742efe4769089ad8 be63d9d47f571a60d70f8fb630c03871312d9655 151704 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 627d1d6693b0594d257dbe1a3363a8d4bd4d8307 3c659044118e34603161457db9934a34f816d78b eb6490f544388dd24c0d054a96dd304bc7284450 88ab0c15525ced2eefe39220742efe4769089ad8 be63d9d47f571a60d70f8fb630c03871312d9655 151778 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 bdafda8c457eb90c65f37026589b54258300f05c 3c659044118e34603161457db9934a34f816d78b aff2caf6b3fbab1062e117a47b66d27f7fd2f272 88ab0c15525ced2eefe39220742efe4769089ad8 3fdc211b01b29f252166937238efe02d15cb5780 151721 fail irrelevant 151763 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 bdafda8c457eb90c65f37026589b54258300f05c 3c659044118e34603161457db9934a34f816d78b 48f22ad04ead83e61b4b35871ec6f6109779b791 88ab0c15525ced2eefe39220742efe4769089ad8 3fdc211b01b29f252166937238efe02d15cb5780 151744 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 bdafda8c457eb90c65f37026589b54258300f05c 3c659044118e34603161457db9934a34f816d78b 8796c64ecdfd34be394ea277aaaaa53df0c76996 88ab0c15525ced2eefe39220742efe4769089ad8 3fdc211b01b29f252166937238efe02d15cb5780 151804 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 bdafda8c457eb90c65f37026589b54258300f05c 3c659044118e34603161457db9934a34f816d78b 45db94cc90c286a9965a285ba19450f448760a09 88ab0c15525ced2eefe39220742efe4769089ad8 3fdc211b01b29f252166937238efe02d15cb5780 151816 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 bdafda8c457eb90c65f37026589b54258300f05c 3c659044118e34603161457db9934a34f816d78b 45db94cc90c286a9965a285ba19450f448760a09 88ab0c15525ced2eefe39220742efe4769089ad8 3fdc211b01b29f252166937238efe02d15cb5780 151833 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f45e3a4afa65a45ea1a956a7c5e7410ff40190d1 3c659044118e34603161457db9934a34f816d78b 827937158b72ce2265841ff528bba3c44a1bfbc8 88ab0c15525ced2eefe39220742efe4769089ad8 02d69864b51a4302a148c28d6d391238a6778b4b 151855 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f45e3a4afa65a45ea1a956a7c5e7410ff40190d1 3c659044118e34603161457db9934a34f816d78b d34498309cff7560ac90c422c56e3137e6a64b19 88ab0c15525ced2eefe39220742efe4769089ad8 02d69864b51a4302a148c28d6d391238a6778b4b 151841 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f45e3a4afa65a45ea1a956a7c5e7410ff40190d1 3c659044118e34603161457db9934a34f816d78b 2033cc6efa98b831d7839e367aa7d5aa74d0750f 88ab0c15525ced2eefe39220742efe4769089ad8 02d69864b51a4302a148c28d6d391238a6778b4b 151849 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f45e3a4afa65a45ea1a956a7c5e7410ff40190d1 3c659044118e34603161457db9934a34f816d78b d34498309cff7560ac90c422c56e3137e6a64b19 88ab0c15525ced2eefe39220742efe4769089ad8 02d69864b51a4302a148c28d6d391238a6778b4b 151874 fail irrelevant 151895 fail irrelevant 151914 fail irrelevant 151934 fail irrelevant 151968 fail irrelevant 151952 fail irrelevant 152013 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d8327496762b4f2a54c9bafd7a214314ec28e9e 3c659044118e34603161457db9934a34f816d78b 939ab64b400b9bec4b59795a87817784093e1acd 6ada2285d9918859699c92e09540e023e0a16054 fb024b779336a0f73b3aee885b2ce082e812881f 151988 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 6ff53d2a13740e39dea110d6b3509c156c659586 3c659044118e34603161457db9934a34f816d78b b7bda69c4ef46c57480f6e378923f5215b122778 6ada2285d9918859699c92e09540e023e0a16054 f8fe3c07363d11fc81d8e7382dbcaa357c861569 151999 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d8327496762b4f2a54c9bafd7a214314ec28e9e 3c659044118e34603161457db9934a34f816d78b 97f750becac33e3d3e446d3ff4ae9af2577b7877 6ada2285d9918859699c92e09540e023e0a16054 fb024b779336a0f73b3aee885b2ce082e812881f 152026 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d8327496762b4f2a54c9bafd7a214314ec28e9e 3c659044118e34603161457db9934a34f816d78b 9fc87111005e8903785db40819af66b8f85b8b96 6ada2285d9918859699c92e09540e023e0a16054 fb024b779336a0f73b3aee885b2ce082e812881f 152039 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d8327496762b4f2a54c9bafd7a214314ec28e9e 3c659044118e34603161457db9934a34f816d78b 9fc87111005e8903785db40819af66b8f85b8b96 6ada2285d9918859699c92e09540e023e0a16054 fb024b779336a0f73b3aee885b2ce082e812881f 152058 fail irrelevant 152076 fail irrelevant 152108 fail irrelevant 152144 fail irrelevant 152171 fail irrelevant 152200 fail irrelevant 152189 fail irrelevant 152211 fail irrelevant 152219 fail irrelevant 152227 fail irrelevant 152241 fail irrelevant 152286 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 dafce295e6f447ed8905db4e29241e2c6c2a4389 3c659044118e34603161457db9934a34f816d78b 9e3903136d9acde2fb2dd9e967ba928050a6cb4a 2e3de6253422112ae43e608661ba94ea6b345694 058023b343d4e366864831db46e9b438e9e3a178 152266 fail irrelevant 152284 fail irrelevant 152289 fail irrelevant 152292 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 239b50a863704f7960525799eda82de061c7c458 3c659044118e34603161457db9934a34f816d78b eefe34ea4b82c2b47abe28af4cc7247d51553626 2e3de6253422112ae43e608661ba94ea6b345694 25636ed707cf1211ce846c7ec58f8643e435d7a7 152356 [host=fiano0] 152294 fail irrelevant 152376 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 dafce295e6f447ed8905db4e29241e2c6c2a4389 3c659044118e34603161457db9934a34f816d78b 9e3903136d9acde2fb2dd9e967ba928050a6cb4a 2e3de6253422112ae43e608661ba94ea6b345694 058023b343d4e366864831db46e9b438e9e3a178 152298 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 239b50a863704f7960525799eda82de061c7c458 3c659044118e34603161457db9934a34f816d78b 3f429a3400822141651486193d6af625eeab05a5 2e3de6253422112ae43e608661ba94ea6b345694 71ca0e0ad000e690899936327eb09709ab182ade 152325 [host=fiano0] 152299 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 58ae92a993687d913aa6dd00ef3497a1bc5f6c40 3c659044118e34603161457db9934a34f816d78b 54cdfe511219b8051046be55a6e156c4f08ff7ff 2e3de6253422112ae43e608661ba94ea6b345694 71ca0e0ad000e690899936327eb09709ab182ade 152300 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a2433243fbe471c250d7eddc2c7da325d91265fd 3c659044118e34603161457db9934a34f816d78b 6675a653d2e57ab09c32c0ea7b44a1d6c40a7f58 2e3de6253422112ae43e608661ba94ea6b345694 3625b04991b4d6affadd99d377ab84bac48dfff4 152345 [host=fiano0] 152301 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 8927e2777786a43cddfaa328b0f4c41a09c629c9 3c659044118e34603161457db9934a34f816d78b 53550e81e2cafe7c03a39526b95cd21b5194d9b1 2e3de6253422112ae43e608661ba94ea6b345694 3625b04991b4d6affadd99d377ab84bac48dfff4 152304 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 8927e2777786a43cddfaa328b0f4c41a09c629c9 3c659044118e34603161457db9934a34f816d78b d6cca8e111696fbbd7c233dc53f9c80b6a43359d 2e3de6253422112ae43e608661ba94ea6b345694 fec6a7af5c5760b9bccd9e7c3eaf29f0401af264 152328 [host=fiano0] 152295 [] 152359 [host=fiano0] 152307 blocked c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3ee4f6cb360a877d171f2f9bb76b0d46d2cfa985 3c659044118e34603161457db9934a34f816d78b 9e3903136d9acde2fb2dd9e967ba928050a6cb4a 2e3de6253422112ae43e608661ba94ea6b345694 3664f7b7788b66bb802432e6748be0fb57993581 152333 [host=fiano0] 152346 [host=fiano0] 152324 [host=fiano0] 152335 [host=fiano0] 152369 [host=fiano0] 152309 [host=fiano0] 152336 [host=fiano0] 152338 [host=fiano0] 152349 [host=fiano0] 152340 [host=fiano0] 152341 [host=fiano0] 152343 [host=fiano0] 152361 [host=fiano0] 152352 [host=fiano0] 152337 fail irrelevant 152364 [host=fiano0] 152372 [host=fiano0] 152394 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 365fdb0f939cf00b26d37f27adbf579aa984221b 3c659044118e34603161457db9934a34f816d78b 9e3903136d9acde2fb2dd9e967ba928050a6cb4a 2e3de6253422112ae43e608661ba94ea6b345694 6a49b9a7920c82015381740905582b666160d955 152381 fail irrelevant 152390 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b16fd231f6d8124fa05a0f086840934b8709faf9 3c659044118e34603161457db9934a34f816d78b 7d3660e79830a069f1848bb4fa1cdf8f666424fb 2e3de6253422112ae43e608661ba94ea6b345694 b91825f628c9a62cf2a3a0d972ea81484a8b7fce 152380 [host=fiano0] 152397 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3ee4f6cb360a877d171f2f9bb76b0d46d2cfa985 3c659044118e34603161457db9934a34f816d78b 9e3903136d9acde2fb2dd9e967ba928050a6cb4a 2e3de6253422112ae43e608661ba94ea6b345694 ceaae74cedd2f7f8ae5c66b90da82f7ead206011 152400 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a4cfb842fca9693a330cb5435284c1ee8bfbbace 3c659044118e34603161457db9934a34f816d78b 9e3903136d9acde2fb2dd9e967ba928050a6cb4a 2e3de6253422112ae43e608661ba94ea6b345694 2995d0afdf2d3fb44d07eada088db3613741db1e 152433 [host=fiano0] 152406 [host=fiano0] 152489 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 567bc4b4ae8a975791382dd30ac413bc0d3ce88c 3c659044118e34603161457db9934a34f816d78b 9e3903136d9acde2fb2dd9e967ba928050a6cb4a 2e3de6253422112ae43e608661ba94ea6b345694 b91825f628c9a62cf2a3a0d972ea81484a8b7fce 152409 [host=fiano0] 152436 [host=fiano0] 152453 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 e557442e3f7ec7bee2d886978bbd259c6d68c75a 3c659044118e34603161457db9934a34f816d78b d74824cf7c8b352f9045e949dc636c7207a41eee d9c812dda519a1a73e8370e1b81ddf46eb22ed16 81fd0d3ca4b2cd309403c6e8da662c325dd35750 152416 [host=fiano0] 152479 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 dafce295e6f447ed8905db4e29241e2c6c2a4389 3c659044118e34603161457db9934a34f816d78b 9e3903136d9acde2fb2dd9e967ba928050a6cb4a 2e3de6253422112ae43e608661ba94ea6b345694 058023b343d4e366864831db46e9b438e9e3a178 152420 [host=fiano0] 152411 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 e557442e3f7ec7bee2d886978bbd259c6d68c75a 3c659044118e34603161457db9934a34f816d78b d74824cf7c8b352f9045e949dc636c7207a41eee d9c812dda519a1a73e8370e1b81ddf46eb22ed16 81fd0d3ca4b2cd309403c6e8da662c325dd35750 152427 [host=fiano0] 152441 [host=fiano0] 152467 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 567bc4b4ae8a975791382dd30ac413bc0d3ce88c 3c659044118e34603161457db9934a34f816d78b 9e3903136d9acde2fb2dd9e967ba928050a6cb4a 2e3de6253422112ae43e608661ba94ea6b345694 b91825f628c9a62cf2a3a0d972ea81484a8b7fce 152450 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 dafce295e6f447ed8905db4e29241e2c6c2a4389 3c659044118e34603161457db9934a34f816d78b 9e3903136d9acde2fb2dd9e967ba928050a6cb4a 2e3de6253422112ae43e608661ba94ea6b345694 058023b343d4e366864831db46e9b438e9e3a178 152481 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 e557442e3f7ec7bee2d886978bbd259c6d68c75a 3c659044118e34603161457db9934a34f816d78b 5c1c3e4f02e458cf280c677c817ae4fd1ed9bf10 d9c812dda519a1a73e8370e1b81ddf46eb22ed16 81fd0d3ca4b2cd309403c6e8da662c325dd35750 152476 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 567bc4b4ae8a975791382dd30ac413bc0d3ce88c 3c659044118e34603161457db9934a34f816d78b 7d3660e79830a069f1848bb4fa1cdf8f666424fb 2e3de6253422112ae43e608661ba94ea6b345694 b91825f628c9a62cf2a3a0d972ea81484a8b7fce 152456 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 e557442e3f7ec7bee2d886978bbd259c6d68c75a 3c659044118e34603161457db9934a34f816d78b 5c1c3e4f02e458cf280c677c817ae4fd1ed9bf10 d9c812dda519a1a73e8370e1b81ddf46eb22ed16 81fd0d3ca4b2cd309403c6e8da662c325dd35750 152478 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 567bc4b4ae8a975791382dd30ac413bc0d3ce88c 3c659044118e34603161457db9934a34f816d78b 9e3903136d9acde2fb2dd9e967ba928050a6cb4a 2e3de6253422112ae43e608661ba94ea6b345694 b91825f628c9a62cf2a3a0d972ea81484a8b7fce 152490 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 567bc4b4ae8a975791382dd30ac413bc0d3ce88c 3c659044118e34603161457db9934a34f816d78b 7d3660e79830a069f1848bb4fa1cdf8f666424fb 2e3de6253422112ae43e608661ba94ea6b345694 b91825f628c9a62cf2a3a0d972ea81484a8b7fce 152485 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 567bc4b4ae8a975791382dd30ac413bc0d3ce88c 3c659044118e34603161457db9934a34f816d78b 7d3660e79830a069f1848bb4fa1cdf8f666424fb 2e3de6253422112ae43e608661ba94ea6b345694 b91825f628c9a62cf2a3a0d972ea81484a8b7fce Searching for interesting versions Result found: flight 151065 (pass), for basis pass Result found: flight 152456 (fail), for basis failure Repro found: flight 152479 (pass), for basis pass Repro found: flight 152481 (fail), for basis failure 0 revisions at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 567bc4b4ae8a975791382dd30ac413bc0d3ce88c 3c659044118e34603161457db9934a34f816d78b 9e3903136d9acde2fb2dd9e967ba928050a6cb4a 2e3de6253422112ae43e608661ba94ea6b345694 b91825f628c9a62cf2a3a0d972ea81484a8b7fce No revisions left to test, checking graph state. Result found: flight 152467 (pass), for last pass Result found: flight 152476 (fail), for first failure Repro found: flight 152478 (pass), for last pass Repro found: flight 152485 (fail), for first failure Repro found: flight 152489 (pass), for last pass Repro found: flight 152490 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: qemuu git://git.qemu.org/qemu.git Bug introduced: 7d3660e79830a069f1848bb4fa1cdf8f666424fb Bug not present: 9e3903136d9acde2fb2dd9e967ba928050a6cb4a Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/152490/ (Revision log too long, omitted.) dot: graph is too large for cairo-renderer bitmaps. Scaling by 0.510779 to fit pnmtopng: 201 colors found Revision graph left in /home/logs/results/bisect/qemu-mainline/test-amd64-i386-xl-qemuu-ws16-amd64.windows-install.{dot,ps,png,html,svg}. ---------------------------------------- 152490: tolerable ALL FAIL flight 152490 qemu-mainline real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/152490/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 10 windows-install fail baseline untested jobs: test-amd64-i386-xl-qemuu-ws16-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Wed Aug 05 15:15:34 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 15:15:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3L8c-0008RH-Uy; Wed, 05 Aug 2020 15:15:30 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3L8b-0008RC-Oi for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 15:15:29 +0000 X-Inumbo-ID: 058fdea1-78f5-49ec-ab22-bb62daa0f237 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 058fdea1-78f5-49ec-ab22-bb62daa0f237; Wed, 05 Aug 2020 15:15:28 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CEC44ACA2; Wed, 5 Aug 2020 15:15:44 +0000 (UTC) Subject: Re: Unified Xen executable for UEFI Secure Boot support To: Trammell Hudson References: From: Jan Beulich Message-ID: Date: Wed, 5 Aug 2020 17:15:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 05.08.2020 13:29, Trammell Hudson wrote: > I have preliminary patches to support bundling the Xen hypervisor, xen.cfg, the Linux kernel, initrd and XSM into a single "unified" EFI executable that can be signed by sbsigntool for verification by UEFI Secure Boot. It is inspired by systemd-boot's unified kernel technique and borrows the function to locate PE sections from systemd's LGPL'ed code. > > The configuration, kernel, etc are added after building using objcopy to add named sections for each input file. This allows an administrator to update the components independently without requiring rebuilding xen. During EFI boot, Xen looks at its own loaded image to locate the PE sections and, if secure boot is enabled, only allows use of the unified components. > > The resulting EFI executable can be invoked directly from the UEFI Boot Manager, removing the need to use a separate loader like grub. Unlike the shim based verification, the signature covers the entire Xen+config+kernel+initrd unified file. This also ensures that properly configured platforms will measure the entire runtime into the TPM for unsealing secrets or remote attestation. > > I've tested it on qemu OVMF with Secure Boot enabled, as well as on real Thinkpad hardware. The EFI console is very slow, although it works and is able to boot into dom0. > > The current patch set is here, and I'd appreciate suggestions on the technique or cleanup for submission: > https://github.com/osresearch/xen/tree/secureboot Sounds quite interesting, thanks, but please post the Xen patches here for commenting, perhaps with an RFC tag for now. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 15:39:36 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 15:39:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3LVm-0001pP-VE; Wed, 05 Aug 2020 15:39:26 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3LVl-0001pK-Pz for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 15:39:25 +0000 X-Inumbo-ID: 204fbe88-f953-4f1d-a239-24f35f21e742 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 204fbe88-f953-4f1d-a239-24f35f21e742; Wed, 05 Aug 2020 15:39:24 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9F029AC97; Wed, 5 Aug 2020 15:39:40 +0000 (UTC) Subject: Re: [PATCH v4 02/14] x86/iommu: add common page-table allocator To: Paul Durrant References: <20200804134209.8717-1-paul@xen.org> <20200804134209.8717-3-paul@xen.org> From: Jan Beulich Message-ID: <6eb5810f-b0ca-3b57-7dc0-93e705512024@suse.com> Date: Wed, 5 Aug 2020 17:39:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200804134209.8717-3-paul@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Andrew Cooper Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 04.08.2020 15:41, Paul Durrant wrote: > From: Paul Durrant > > Instead of having separate page table allocation functions in VT-d and AMD > IOMMU code, we could use a common allocation function in the general x86 code. > > This patch adds a new allocation function, iommu_alloc_pgtable(), for this > purpose. The function adds the page table pages to a list. The pages in this > list are then freed by iommu_free_pgtables(), which is called by > domain_relinquish_resources() after PCI devices have been de-assigned. > > Signed-off-by: Paul Durrant Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Wed Aug 05 15:41:16 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 15:41:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3LXY-0002Zc-Am; Wed, 05 Aug 2020 15:41:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3LXW-0002ZT-Kx for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 15:41:14 +0000 X-Inumbo-ID: 5b68ace9-94fd-4f5a-9074-e3664a2af17e Received: from mail-lj1-x242.google.com (unknown [2a00:1450:4864:20::242]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5b68ace9-94fd-4f5a-9074-e3664a2af17e; Wed, 05 Aug 2020 15:41:13 +0000 (UTC) Received: by mail-lj1-x242.google.com with SMTP id s16so32988304ljc.8 for ; Wed, 05 Aug 2020 08:41:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=XjzRB/do2UEi9u9BQ+A+eoj+qY0lKQjnu1Lpd4TAtLQ=; b=rIooioNCkecGI8MhRxR/LiQX0GqQjlO/pr8eJLRlaSTZ3WxTrLp6XGjOOODCdqnrfU vn/MSOGaCnJeogmzcVVyuRuOsfQSteYOdfRxaNJgRz5HYeaYfW8LyJBLFKcrFpFFU5is nvVBvkjRSh3LUUEJq+sD+hpljDbIbP0R1MyksJlwYe6zlZaRrDwSQZ6Euuz/8tQKIFMB eKlhPwxAZuY/EgZ/BGEOUuZ/zC23c7fISzjmT6sUuZwn7EgK56rfnZ9PPa68uh39DU65 B6BO08gFpbmZ5kzP+SbyyJOWl613oewQlfHVImge5mwhlsY1m0J/nLWMsPdEojkh87LL znag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=XjzRB/do2UEi9u9BQ+A+eoj+qY0lKQjnu1Lpd4TAtLQ=; b=YuIhl5QKCoRGnQ7B//X1QVDKP8Os61iKfjpJgBfqrfyYbw7g1beLeNXwSKMkij2W0n Nph7+HqPNpzKC2TPfquA/5xV2gLgr/uQMbJU2CEe667NPHCMlJmMte33Ir44eKnDBEmv 8/tEm2hk25kIc4gJ5VEeOscCdumteQop+gkaRqRdaD4tD4IMoiMML1MGU0Mb3pk9HOpb MdkIRyXiyMtJAosRvWQTWHTjfpg3TtwovLuupXahaO44YgqtrGHRpX4W3vMej2HT3Dnu ILWxPYF83RzeJs+wOlhDBqxylppo06RSrrLJ0JoWXEV6C9vwLUxDDWzAtRGUFbmWDLdK AkYg== X-Gm-Message-State: AOAM5338OlQpXKJ55H3bq53STu2wqX8GlOhfmdXvKr7czsEZDdMIFn/o +PJE2zHnxMKIraleHQxK2aA= X-Google-Smtp-Source: ABdhPJz6/lwZ56GLWgUNz4X/JDi1QcJE3dHZKsnXw1/FU2MYgICWZYKZQMvknvi/FAD5i6paFJJg4w== X-Received: by 2002:a2e:844f:: with SMTP id u15mr1899611ljh.200.1596642072501; Wed, 05 Aug 2020 08:41:12 -0700 (PDT) Received: from [192.168.1.2] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id l20sm1019453ljb.28.2020.08.05.08.41.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2020 08:41:11 -0700 (PDT) Subject: Re: [RFC PATCH V1 04/12] xen/arm: Introduce arch specific bits for IOREQ/DM features To: Julien Grall References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-5-git-send-email-olekstysh@gmail.com> <8e8a394c-bd2a-4444-9f4b-e022c59e0f81@xen.org> From: Oleksandr Message-ID: Date: Wed, 5 Aug 2020 18:41:06 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <8e8a394c-bd2a-4444-9f4b-e022c59e0f81@xen.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Julien Grall , Jan Beulich , xen-devel@lists.xenproject.org, Daniel De Graaf , Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 05.08.20 12:32, Julien Grall wrote: Hi Julien. > Hi Stefano, > > On 05/08/2020 00:22, Stefano Stabellini wrote: >> On Mon, 3 Aug 2020, Oleksandr Tyshchenko wrote: >>> From: Oleksandr Tyshchenko >>> >>> This patch makes possible to forward Guest MMIO accesses >>> to a device emulator on Arm and enables that support for >>> Arm64. >>> >>> Also update XSM code a bit to let DM op be used on Arm. >>> New arch DM op will be introduced in the follow-up patch. >>> >>> Please note, at the moment build on Arm32 is broken >>> (see cmpxchg usage in hvm_send_buffered_ioreq()) if someone >> >> Speaking of buffered_ioreq, if I recall correctly, they were only used >> for VGA-related things on x86. It looks like it is still true. >> >> If so, do we need it on ARM? Note that I don't think we can get rid of >> it from the interface as it is baked into ioreq, but it might be >> possible to have a dummy implementation on ARM. Or maybe not: looking at >> xen/common/hvm/ioreq.c it looks like it would be difficult to >> disentangle bufioreq stuff from the rest of the code. > > We possibly don't need it right now. However, this could possibly be > used in the future (e.g. virtio notification doorbell). > >>> @@ -2275,6 +2282,16 @@ static void check_for_vcpu_work(void) >>>    */ >>>   void leave_hypervisor_to_guest(void) >>>   { >>> +#ifdef CONFIG_IOREQ_SERVER >>> +    /* >>> +     * XXX: Check the return. Shall we call that in >>> +     * continue_running and context_switch instead? >>> +     * The benefits would be to avoid calling >>> +     * handle_hvm_io_completion on every return. >>> +     */ >> >> Yeah, that could be a simple and good optimization > > Well, it is not simple as it is sounds :). handle_hvm_io_completion() > is the function in charge to mark the vCPU as waiting for I/O. So we > would at least need to split the function. > > I wrote this TODO because I wasn't sure about the complexity of > handle_hvm_io_completion(current). Looking at it again, the main > complexity is the looping over the IOREQ servers. > > I think it would be better to optimize handle_hvm_io_completion() > rather than trying to hack the context_switch() or continue_running(). > > [...] > >>> diff --git a/xen/include/asm-arm/p2m.h b/xen/include/asm-arm/p2m.h >>> index 5fdb6e8..5823f11 100644 >>> --- a/xen/include/asm-arm/p2m.h >>> +++ b/xen/include/asm-arm/p2m.h >>> @@ -385,10 +385,11 @@ static inline int set_foreign_p2m_entry(struct >>> domain *d, unsigned long gfn, >>>                                           mfn_t mfn) >>>   { >>>       /* >>> -     * NOTE: If this is implemented then proper reference counting of >>> -     *       foreign entries will need to be implemented. >>> +     * XXX: handle properly reference. It looks like the page may >>> not always >>> +     * belong to d. >> >> Just as a reference, and without taking away anything from the comment, >> I think that QEMU is doing its own internal reference counting for these >> mappings. > > I am not sure how this matters here? We can't really trust the DM to > do the right thing if it is not running in dom0. > > But, IIRC, the problem is some of the pages doesn't belong to do a > domain, so it is not possible to treat them as foreign mapping (e.g. > you wouldn't be able to grab a reference). This investigation was done > a couple of years ago, so this may have changed in recent Xen. > > As a side note, I am a bit surprised to see most of my original TODOs > present in the code. What is the plan to solve them? The plan is to solve most critical TODOs in current series, and rest in follow-up series if no objections of course. Any pointers how to solve them properly would be much appreciated. Unfortunately, now I have a weak understanding how they should be fixed. I see at least 3 major TODO here: 1. handle properly reference in set_foreign_p2m_entry() 2. optimize handle_hvm_io_completion() 3. hande properly IO_RETRY in try_fwd_ioserv() -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Wed Aug 05 16:06:32 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 16:06:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Lvg-0004yD-Dq; Wed, 05 Aug 2020 16:06:12 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Lvf-0004y8-6Y for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 16:06:11 +0000 X-Inumbo-ID: 115bf38e-e4c0-489d-b230-e2431965cf35 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 115bf38e-e4c0-489d-b230-e2431965cf35; Wed, 05 Aug 2020 16:06:09 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 83F07B73F; Wed, 5 Aug 2020 16:06:25 +0000 (UTC) Subject: Re: [PATCH v4 06/14] iommu: flush I/O TLB if iommu_map() or iommu_unmap() fail To: Paul Durrant References: <20200804134209.8717-1-paul@xen.org> <20200804134209.8717-7-paul@xen.org> From: Jan Beulich Message-ID: <82d73571-3e05-65b5-2731-d8cdee651995@suse.com> Date: Wed, 5 Aug 2020 18:06:09 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200804134209.8717-7-paul@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Paul Durrant Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 04.08.2020 15:42, Paul Durrant wrote: > From: Paul Durrant > > This patch adds a full I/O TLB flush to the error paths of iommu_map() and > iommu_unmap(). > > Without this change callers need constructs such as: > > rc = iommu_map/unmap(...) > err = iommu_flush(...) > if ( !rc ) > rc = err; > > With this change, it can be simplified to: > > rc = iommu_map/unmap(...) > if ( !rc ) > rc = iommu_flush(...) > > because, if the map or unmap fails the flush will be unnecessary. This saves > a stack variable and generally makes the call sites tidier. I appreciate the intent of tidier code, but I wonder whether this flushing doesn't go a little too far: There's a need to flush in general when multiple pages were to be (un)mapped, and there was at least partial success. Hence e.g. in the order == 0 case I don't see why any flushing would be needed. Granted errors aren't commonly expected, but anyway. > --- a/xen/drivers/passthrough/iommu.c > +++ b/xen/drivers/passthrough/iommu.c > @@ -274,6 +274,10 @@ int iommu_map(struct domain *d, dfn_t dfn, mfn_t mfn, > break; > } > > + /* Something went wrong so flush everything and clear flush flags */ > + if ( unlikely(rc) && iommu_iotlb_flush_all(d, *flush_flags) ) Both here and in the unmap path, did you get the return value of iommu_iotlb_flush_all() the wrong way round (i.e. isn't there a missing ! )? Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 16:14:07 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 16:14:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3M3G-0005vC-Dj; Wed, 05 Aug 2020 16:14:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3M3F-0005v7-RU for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 16:14:01 +0000 X-Inumbo-ID: fd00bafe-f279-4562-9c3b-4e9c79ca9580 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fd00bafe-f279-4562-9c3b-4e9c79ca9580; Wed, 05 Aug 2020 16:14:00 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6942FAC65; Wed, 5 Aug 2020 16:14:16 +0000 (UTC) Subject: Re: [RFC PATCH V1 04/12] xen/arm: Introduce arch specific bits for IOREQ/DM features To: Oleksandr Tyshchenko , xen-devel@lists.xenproject.org References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-5-git-send-email-olekstysh@gmail.com> From: Jan Beulich Message-ID: Date: Wed, 5 Aug 2020 18:13:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <1596478888-23030-5-git-send-email-olekstysh@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Julien Grall , Daniel De Graaf , Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 03.08.2020 20:21, Oleksandr Tyshchenko wrote: > --- a/xen/include/xsm/dummy.h > +++ b/xen/include/xsm/dummy.h > @@ -713,14 +713,14 @@ static XSM_INLINE int xsm_pmu_op (XSM_DEFAULT_ARG struct domain *d, unsigned int > } > } > > +#endif /* CONFIG_X86 */ > + > static XSM_INLINE int xsm_dm_op(XSM_DEFAULT_ARG struct domain *d) > { > XSM_ASSERT_ACTION(XSM_DM_PRIV); > return xsm_default_action(action, current->domain, d); > } > > -#endif /* CONFIG_X86 */ > - > #ifdef CONFIG_ARGO > static XSM_INLINE int xsm_argo_enable(const struct domain *d) > { > diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h > index a80bcf3..2a9b39d 100644 > --- a/xen/include/xsm/xsm.h > +++ b/xen/include/xsm/xsm.h > @@ -177,8 +177,8 @@ struct xsm_operations { > int (*ioport_permission) (struct domain *d, uint32_t s, uint32_t e, uint8_t allow); > int (*ioport_mapping) (struct domain *d, uint32_t s, uint32_t e, uint8_t allow); > int (*pmu_op) (struct domain *d, unsigned int op); > - int (*dm_op) (struct domain *d); > #endif > + int (*dm_op) (struct domain *d); > int (*xen_version) (uint32_t cmd); > int (*domain_resource_map) (struct domain *d); > #ifdef CONFIG_ARGO > @@ -688,13 +688,13 @@ static inline int xsm_pmu_op (xsm_default_t def, struct domain *d, unsigned int > return xsm_ops->pmu_op(d, op); > } > > +#endif /* CONFIG_X86 */ > + > static inline int xsm_dm_op(xsm_default_t def, struct domain *d) > { > return xsm_ops->dm_op(d); > } > > -#endif /* CONFIG_X86 */ > - > static inline int xsm_xen_version (xsm_default_t def, uint32_t op) > { > return xsm_ops->xen_version(op); > diff --git a/xen/xsm/dummy.c b/xen/xsm/dummy.c > index d4cce68..e3afd06 100644 > --- a/xen/xsm/dummy.c > +++ b/xen/xsm/dummy.c > @@ -148,8 +148,8 @@ void __init xsm_fixup_ops (struct xsm_operations *ops) > set_to_dummy_if_null(ops, ioport_permission); > set_to_dummy_if_null(ops, ioport_mapping); > set_to_dummy_if_null(ops, pmu_op); > - set_to_dummy_if_null(ops, dm_op); > #endif > + set_to_dummy_if_null(ops, dm_op); > set_to_dummy_if_null(ops, xen_version); > set_to_dummy_if_null(ops, domain_resource_map); > #ifdef CONFIG_ARGO > diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c > index a314bf8..645192a 100644 > --- a/xen/xsm/flask/hooks.c > +++ b/xen/xsm/flask/hooks.c > @@ -1662,14 +1662,13 @@ static int flask_pmu_op (struct domain *d, unsigned int op) > return -EPERM; > } > } > +#endif /* CONFIG_X86 */ > > static int flask_dm_op(struct domain *d) > { > return current_has_perm(d, SECCLASS_HVM, HVM__DM); > } > > -#endif /* CONFIG_X86 */ > - > static int flask_xen_version (uint32_t op) > { > u32 dsid = domain_sid(current->domain); > @@ -1872,8 +1871,8 @@ static struct xsm_operations flask_ops = { > .ioport_permission = flask_ioport_permission, > .ioport_mapping = flask_ioport_mapping, > .pmu_op = flask_pmu_op, > - .dm_op = flask_dm_op, > #endif > + .dm_op = flask_dm_op, > .xen_version = flask_xen_version, > .domain_resource_map = flask_domain_resource_map, > #ifdef CONFIG_ARGO All of this looks to belong into patch 2? Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 16:15:36 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 16:15:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3M4l-0005zv-Pi; Wed, 05 Aug 2020 16:15:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3M4k-0005zo-Sw for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 16:15:34 +0000 X-Inumbo-ID: 57068566-27e5-4809-87bc-6dff6b979aaa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 57068566-27e5-4809-87bc-6dff6b979aaa; Wed, 05 Aug 2020 16:15:34 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2A721AC65; Wed, 5 Aug 2020 16:15:50 +0000 (UTC) Subject: Re: [RFC PATCH V1 05/12] hvm/dm: Introduce xendevicemodel_set_irq_level DM op To: Oleksandr Tyshchenko References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-6-git-send-email-olekstysh@gmail.com> From: Jan Beulich Message-ID: <1487bf45-3696-8052-ab98-149e612fff80@suse.com> Date: Wed, 5 Aug 2020 18:15:34 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <1596478888-23030-6-git-send-email-olekstysh@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Julien Grall , xen-devel@lists.xenproject.org, Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 03.08.2020 20:21, Oleksandr Tyshchenko wrote: > --- a/xen/include/public/hvm/dm_op.h > +++ b/xen/include/public/hvm/dm_op.h > @@ -417,6 +417,20 @@ struct xen_dm_op_pin_memory_cacheattr { > uint32_t pad; > }; > > +/* > + * XEN_DMOP_set_irq_level: Set the logical level of a one of a domain's > + * IRQ lines. > + * XXX Handle PPIs. > + */ > +#define XEN_DMOP_set_irq_level 19 > + > +struct xen_dm_op_set_irq_level { > + uint32_t irq; > + /* IN - Level: 0 -> deasserted, 1 -> asserted */ > + uint8_t level; > +}; If this is the way to go (I've seen other discussion going on), please make sure you add explicit padding fields and ... > + > + > struct xen_dm_op { ... you don't add double blank lines. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 16:16:02 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 16:16:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3M5C-00063n-2I; Wed, 05 Aug 2020 16:16:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3M5A-00063Y-P9 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 16:16:00 +0000 X-Inumbo-ID: 8041c16c-0e88-4c4c-833d-8c4d0c5a0796 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8041c16c-0e88-4c4c-833d-8c4d0c5a0796; Wed, 05 Aug 2020 16:15:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596644159; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=qfiJmy/YxqePuWm/akeJFID0CCDl/0vBNinplJX9SXA=; b=JU3OBm/tC9SeQGW2dh9XXE18onc8nr+6rAfGr2X6bs22P4EBe9NrgEDi Mjde0rnknGMdtTZQWILRu/GfRm744nD7ZX5eL6WNcBO5Vm2ianG3wMyOB XrJMNy2yK0PUQ6BzW5b7RaiMLSqTZZ74wKA0ImFHPK1ckrXkMOf+cqksN Y=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 78/Bts44FYobLCPgbp69v3G1MyIU/aAa4ojlHh24cBBf7mmSXDlcuD6qcvFaic1PQsGwPNJ/Os 2DEB3EzlPPMy5EOnRTdfiyLNvPrlWMEkWhZBbW3LHqikkLJ6Eyei+c36JYJc0PXkhXzie4MgUr IoC/rqrnibRHD/cjNrVlWocwLlqvTsCskzJiFDLQT57fxuDX9iJX8Xw2ykGRZ7UIDoAaetFHtO phZJMLVuobCyJGScxQnnKQvsL5s/llzRDfImBbqXA9alPf3VQmNLB6F8UDIHasAZYS3Ap+IIq9 ieA= X-SBRS: 3.7 X-MesageID: 23960864 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,438,1589256000"; d="scan'208";a="23960864" Subject: Re: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common To: Oleksandr Tyshchenko , References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-2-git-send-email-olekstysh@gmail.com> From: Andrew Cooper Message-ID: <57ab62fb-048f-44ae-f815-9d5054457eb9@citrix.com> Date: Wed, 5 Aug 2020 17:15:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1596478888-23030-2-git-send-email-olekstysh@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Tian , Stefano Stabellini , Julien Grall , Jan Beulich , Wei Liu , Paul Durrant , Tim Deegan , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Julien Grall , Jun Nakajima , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 03/08/2020 19:21, Oleksandr Tyshchenko wrote: > diff --git a/xen/common/Makefile b/xen/common/Makefile > index 06881d0..f6fc3f8 100644 > --- a/xen/common/Makefile > +++ b/xen/common/Makefile > @@ -70,6 +70,7 @@ extra-y := symbols-dummy.o > > obj-$(CONFIG_COVERAGE) += coverage/ > obj-y += sched/ > +obj-$(CONFIG_IOREQ_SERVER) += hvm/ > obj-$(CONFIG_UBSAN) += ubsan/ > > obj-$(CONFIG_NEEDS_LIBELF) += libelf/ > diff --git a/xen/common/hvm/Makefile b/xen/common/hvm/Makefile > new file mode 100644 > index 0000000..326215d > --- /dev/null > +++ b/xen/common/hvm/Makefile > @@ -0,0 +1 @@ > +obj-y += ioreq.o > diff --git a/xen/common/hvm/ioreq.c b/xen/common/hvm/ioreq.c > new file mode 100644 > index 0000000..7e1fa23 > --- /dev/null > +++ b/xen/common/hvm/ioreq.c > HVM is an internal detail of arch specific code.  It should not escape into common code. >From x86's point of view, there is nothing conceptually wrong with having an IOREQ server for PV guests, although it is very unlikely at this point that adding support would be a good use of time. Please make this into a proper top-level common set of functionality. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Aug 05 16:18:12 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 16:18:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3M7F-0006Gk-JN; Wed, 05 Aug 2020 16:18:09 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3M7E-0006Gf-OH for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 16:18:08 +0000 X-Inumbo-ID: ab52e3a5-a157-4252-ac08-d4f232f039c9 Received: from mail-wr1-x435.google.com (unknown [2a00:1450:4864:20::435]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ab52e3a5-a157-4252-ac08-d4f232f039c9; Wed, 05 Aug 2020 16:18:07 +0000 (UTC) Received: by mail-wr1-x435.google.com with SMTP id a15so41251064wrh.10 for ; Wed, 05 Aug 2020 09:18:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:content-language :thread-index; bh=+Thx91dusakiqrahsI/77vWl7YMCVAiBUNGy9z1ugI4=; b=Nofg4blC/GqZ+vEXGW0rM50lD48+CWu1r/3Bm3M5h8ChoPuAn8+h30Jov11Mp7Gnep eylGZ5eCwbVUnPT5GFT/hhy4LP7iIEYGxoYGM7twh70g72+zsUll/Y8p7pYuTxkNi6LY Zq0IMRTk7DMmztLbKki5DIACccwcmLJZyx84beQ8xZ9fBAC0BebqhSiTjxSQ8TcdiOP5 cdszslTq5FIg/jEWo/fjFREkMUhPo5bVJkSPOnXfXHEet5yC+VNjJ6sVcAEFTpJ0+EKy Y9z6RCSk8bN+1Z5pzLhhbCf+oMBj/8iMHytdm//JXJqcICKTUvujv4Qg6u7tLPQ81UFY IjKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:to:cc:references:in-reply-to :subject:date:message-id:mime-version:content-transfer-encoding :content-language:thread-index; bh=+Thx91dusakiqrahsI/77vWl7YMCVAiBUNGy9z1ugI4=; b=cfzPkD6VISwm4xlAKmJKqVY5IUZGOcJw/cAn0mqG9hKKgfjMvEOLZCdkZ/bo5Ii/P6 +lDvQH4y0AAhCPoBxt2ONGBNaa6MkVuoozCMBSDwzXXGrfsTk+SIkqQL5KRNORDsxjG8 3AV0VYGIm6h6QIx9nat3LcFXLsDYB4qDQcIlvbMWeq6VGlzRpnwWCcYtOu6WsGBmAg4S aUtUH5A4R8JXzQ89mzKt1X1Ackit/7WssiZdy7uJPFn+ACMkQXRsEq+4Ljgp0f7BwQza OqjZNdIv6KWWqoaeLhEmmV4mDPjfqT36h8yVsAXW9BuOFcFj8R0JXBN1745QsHJ581Y5 +Xjg== X-Gm-Message-State: AOAM533d0rosgNBNI2IACbpIqsjiNoE+UHEwaMDFK06+87Embo1BwAau 1cRTaCTBOWIQ9tDhABEEqqc= X-Google-Smtp-Source: ABdhPJycy6sEfMH4i60OfcKVUBubSvTbIi7jedUxc/2okLu7drPoUO+0viJcj9i7hs+jmnhrCHoS6g== X-Received: by 2002:adf:a195:: with SMTP id u21mr3674201wru.296.1596644286943; Wed, 05 Aug 2020 09:18:06 -0700 (PDT) Received: from CBGR90WXYV0 (54-240-197-226.amazon.com. [54.240.197.226]) by smtp.gmail.com with ESMTPSA id s19sm3805896wrb.54.2020.08.05.09.18.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Aug 2020 09:18:06 -0700 (PDT) From: Paul Durrant X-Google-Original-From: "Paul Durrant" To: "'Jan Beulich'" References: <20200804134209.8717-1-paul@xen.org> <20200804134209.8717-7-paul@xen.org> <82d73571-3e05-65b5-2731-d8cdee651995@suse.com> In-Reply-To: <82d73571-3e05-65b5-2731-d8cdee651995@suse.com> Subject: RE: [PATCH v4 06/14] iommu: flush I/O TLB if iommu_map() or iommu_unmap() fail Date: Wed, 5 Aug 2020 17:18:55 +0100 Message-ID: <005e01d66b44$1e57ff80$5b07fe80$@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: en-gb Thread-Index: AQGtxlp5X/CuH2IzEhv/FXA8KDRK/wEQIAkmATal672paMQrUA== X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: paul@xen.org Cc: xen-devel@lists.xenproject.org, 'Paul Durrant' Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" > -----Original Message----- > From: Jan Beulich > Sent: 05 August 2020 17:06 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Paul Durrant > Subject: Re: [PATCH v4 06/14] iommu: flush I/O TLB if iommu_map() or iommu_unmap() fail > > On 04.08.2020 15:42, Paul Durrant wrote: > > From: Paul Durrant > > > > This patch adds a full I/O TLB flush to the error paths of iommu_map() and > > iommu_unmap(). > > > > Without this change callers need constructs such as: > > > > rc = iommu_map/unmap(...) > > err = iommu_flush(...) > > if ( !rc ) > > rc = err; > > > > With this change, it can be simplified to: > > > > rc = iommu_map/unmap(...) > > if ( !rc ) > > rc = iommu_flush(...) > > > > because, if the map or unmap fails the flush will be unnecessary. This saves > > a stack variable and generally makes the call sites tidier. > > I appreciate the intent of tidier code, but I wonder whether this > flushing doesn't go a little too far: There's a need to flush in > general when multiple pages were to be (un)mapped, and there was > at least partial success. Hence e.g. in the order == 0 case I > don't see why any flushing would be needed. Granted errors aren't > commonly expected, but anyway. > Yes, I wasn't really worried about optimizing the error case, but I can avoid unnecessary flushing in the order 0 case. > > --- a/xen/drivers/passthrough/iommu.c > > +++ b/xen/drivers/passthrough/iommu.c > > @@ -274,6 +274,10 @@ int iommu_map(struct domain *d, dfn_t dfn, mfn_t mfn, > > break; > > } > > > > + /* Something went wrong so flush everything and clear flush flags */ > > + if ( unlikely(rc) && iommu_iotlb_flush_all(d, *flush_flags) ) > > Both here and in the unmap path, did you get the return value > of iommu_iotlb_flush_all() the wrong way round (i.e. isn't there > a missing ! )? > Yes, I think you're right. I'll need to re-work anyway to avoid the flush in the order 0 case. Paul > Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 16:20:05 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 16:20:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3M93-0006Rs-W6; Wed, 05 Aug 2020 16:20:01 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3M93-0006Nf-89 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 16:20:01 +0000 X-Inumbo-ID: 6ee376f5-8c27-4de6-a786-28a0ef7820ad Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6ee376f5-8c27-4de6-a786-28a0ef7820ad; Wed, 05 Aug 2020 16:20:00 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 33A38AC65; Wed, 5 Aug 2020 16:20:16 +0000 (UTC) Subject: Re: [RFC PATCH V1 07/12] A collection of tweaks to be able to run emulator in driver domain To: Oleksandr Tyshchenko , Paul Durrant References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-8-git-send-email-olekstysh@gmail.com> From: Jan Beulich Message-ID: <4ffa6434-3ad6-04dc-bfde-f75196930fb4@suse.com> Date: Wed, 5 Aug 2020 18:19:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <1596478888-23030-8-git-send-email-olekstysh@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, Daniel De Graaf Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 03.08.2020 20:21, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > Trying to run emulator in driver domain I ran into various issues > mostly policy-related. So this patch tries to resolve all them > plobably in a hackish way. I would like to get feedback how > to implement them properly as having an emulator in driver domain > is a completely valid use-case. >From going over the comments I can only derive you want to run an emulator in a driver domain, which doesn't really make sense to me. A driver domain has a different purpose after all. If instead you mean it to be run in just some other domain (which also isn't the domain controlling the target), then there may be more infrastructure changes needed. Paul - was/is your standalone ioreq server (demu?) able to run in other than the domain controlling a guest? Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 16:21:55 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 16:21:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3MAr-00079R-DP; Wed, 05 Aug 2020 16:21:53 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3MAq-00079L-9d for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 16:21:52 +0000 X-Inumbo-ID: 53b87ad9-041d-4b32-a0b8-24ac53ae949e Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 53b87ad9-041d-4b32-a0b8-24ac53ae949e; Wed, 05 Aug 2020 16:21:51 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 68107AC65; Wed, 5 Aug 2020 16:22:07 +0000 (UTC) Subject: Re: [RFC PATCH V1 08/12] xen/arm: Invalidate qemu mapcache on XENMEM_decrease_reservation To: Oleksandr Tyshchenko References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-9-git-send-email-olekstysh@gmail.com> From: Jan Beulich Message-ID: <21b7d8ed-f305-8abe-0e4e-174d72d087c8@suse.com> Date: Wed, 5 Aug 2020 18:21:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <1596478888-23030-9-git-send-email-olekstysh@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 03.08.2020 20:21, Oleksandr Tyshchenko wrote: > --- a/xen/common/memory.c > +++ b/xen/common/memory.c > @@ -1652,6 +1652,12 @@ long do_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg) > break; > } > > + /* x86 already sets the flag in hvm_memory_op() */ > +#if defined(CONFIG_ARM64) && defined(CONFIG_IOREQ_SERVER) > + if ( op == XENMEM_decrease_reservation ) > + curr_d->arch.hvm.qemu_mapcache_invalidate = true; > +#endif Doesn't the comment already indicate a route towards an approach not requiring to alter common code? Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 16:26:10 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 16:26:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3MEv-0007KB-Uw; Wed, 05 Aug 2020 16:26:05 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3MEu-0007K6-8e for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 16:26:04 +0000 X-Inumbo-ID: 75ac753c-4178-44db-b230-d12dbf8976e7 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 75ac753c-4178-44db-b230-d12dbf8976e7; Wed, 05 Aug 2020 16:26:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596644763; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=xkJq30v5eX12PpbKZRUkUdv8sNBcmHMawcoz0s6EJgw=; b=QbIerY7wrQOhOqeFRcDHA8WWwrzkpc+hAFiUOwrpxDDl4+M25L5m7UW3 hDjcQzVR4wMS6UvnYpW41E/celkle/ffxMGcOxnDefEbBGQ1w27zWFWOw b87szOJqRfhJtL38fmd0pxFQPkClwKpMhKtpPwMIFZB38hzSy04m8l/el k=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: ihCZq3+s5E+k/RSlmw/D4lYQLfyL2F0oK3snFL+sAjyEwpvXucv/VXs1V5HHqEBelmclWZHEWk cNDTPVQUrsYJ4CZq/xHGh99wjzvEAjIvQ1L9uiW2VcedMrVJDTNLCDeDAbBdRqmLtqzYDHtxed ezSSwPl5/QcBW0tshn9c+fb4wQWl72TDYgutY3cfEcCs5EzlrzkRiSzaPhgGJn/l6Gz3wb3Mjr 4f2BLo68cDF2u/FsPVEPVfYk4JJK+TanQaWjpTRlwF5f3+OXG6gfh94XnEze/B12ic8/u9LkGV kjA= X-SBRS: 3.7 X-MesageID: 23961699 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,438,1589256000"; d="scan'208";a="23961699" Subject: Re: [PATCH] x86/tsc: Fix diagnostics for TSC frequency To: Jan Beulich References: <20200805141804.2585-1-andrew.cooper3@citrix.com> <3123eedc-252d-7e9e-a4af-6f8bfae82f41@suse.com> From: Andrew Cooper Message-ID: Date: Wed, 5 Aug 2020 17:25:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <3123eedc-252d-7e9e-a4af-6f8bfae82f41@suse.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Xen-devel , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 05/08/2020 15:54, Jan Beulich wrote: > On 05.08.2020 16:18, Andrew Cooper wrote: >> A Gemini Lake platform prints: >> >> (XEN) CPU0: TSC: 19200000MHz * 279 / 3 = 1785600000MHz >> (XEN) CPU0: 800..1800 MHz >> >> during boot. The units on the first line are Hz, not MHz, so correct that and >> add a space for clarity. >> >> Also, for the min/max line, use three dots instead of two and add more spaces >> so that the line can't be mistaken for being a double decimal point typo. >> >> Boot now reads: >> >> (XEN) CPU0: TSC: 19200000 Hz * 279 / 3 = 1785600000 Hz >> (XEN) CPU0: 800 ... 1800 MHz >> >> Extend these changes to the other TSC diagnostics. > I'm happy to see the unit mistake fixed, but the choice of > formatting was pretty deliberate when the code was introduced: > As dense as possible without making things unreadable or > ambiguous. (Considering "a double decimal point typo" looks > like a joke to me, really.) I literally thought it was a typo until I read the code.  So no - I'm very much not joking. Decimal points are extremely commonly seen with frequencies, and nothing else in the log line gives any hint that it is range. Despite being deliberate, it is overly dense and ambiguous as a consequence. >> --- a/xen/arch/x86/cpu/intel.c >> +++ b/xen/arch/x86/cpu/intel.c >> @@ -396,14 +396,14 @@ static void intel_log_freq(const struct cpuinfo_x86 *c) >> >> val *= ebx; >> do_div(val, eax); >> - printk("CPU%u: TSC: %uMHz * %u / %u = %LuMHz\n", >> + printk("CPU%u: TSC: %u Hz * %u / %u = %Lu Hz\n", >> smp_processor_id(), ecx, ebx, eax, val); > For this one I wonder whether ecx wouldn't better be scaled down to > kHz, and val down to MHz. That depends on whether we will lose precision in the process. In principle we can, given ecx's unit of Hz, so I'd be tempted to leave it as is. > >> } >> else if ( ecx | eax | ebx ) >> { >> printk("CPU%u: TSC:", smp_processor_id()); >> if ( ecx ) >> - printk(" core: %uMHz", ecx); >> + printk(" core: %u MHz", ecx); > This one now clearly wants to say Hz too, or (as above) scaling > down to kHz. Oops.  Will fix. > With at least this last issue addressed > Reviewed-by: Jan Beulich Thanks, ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Aug 05 16:40:26 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 16:40:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3MSg-0000Xy-9T; Wed, 05 Aug 2020 16:40:18 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3MSe-0000Xt-Uq for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 16:40:17 +0000 X-Inumbo-ID: bd41ee21-15ea-4adb-997c-98667faf51d9 Received: from mail-wm1-x32e.google.com (unknown [2a00:1450:4864:20::32e]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id bd41ee21-15ea-4adb-997c-98667faf51d9; Wed, 05 Aug 2020 16:40:16 +0000 (UTC) Received: by mail-wm1-x32e.google.com with SMTP id k20so6976052wmi.5 for ; Wed, 05 Aug 2020 09:40:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:content-language :thread-index; bh=SaDNYE1xnldOkModmMjF+GRhgWILeGGODd/dskU7Ga4=; b=f/aBI1/vhiyiVvof8DmP7+mcqj+PYgvymSU9wTPytp0+sbkk+lyrLCE3fYv9/3Iown OErgOcHDRXE1eS1RdH4+cnPYXaZXJutNGZXzi0WJVQ1CEIY133htF2GfMKVuoIBEZhvx PS8dbgx/pwP/ak+lKLLTITVRgSuxq3xA5lIqYSbCgzm8Zn89yHASnBh8y2iK60xz2e1W cBVq6jwx8iU4IKBqSE6moOt/QOpcBfCzV1ME2fuqPp1freANxyVGZXeSWkcbhBwYT5jL +5JRJkbPDD11BBqujrTsYAUrjtoFjk2k19bgZTvkvt1l0ot558uCOuSH7sg8ABkK/7ed 0zEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:to:cc:references:in-reply-to :subject:date:message-id:mime-version:content-transfer-encoding :content-language:thread-index; bh=SaDNYE1xnldOkModmMjF+GRhgWILeGGODd/dskU7Ga4=; b=OvYF4786mZzBdpnqS5cataJQIPAWNHx+fjUPSeOLQ80c2I01hjd223LmI4txqM6aRs 1bxQNWcR38mZea9WlPTKgxp+A3ADSdDFHsIsqUctm0i9uVTEk2XGzICi9Se+TdgalyFm vN8ImJXFivOr20AL4mh73R/1dtyITV+ZAkf1vu7kovCkXfpujb2fO8z5hhiuktrrjTJa tPsc1ajA1WI1LtPcmScOju40v9/PsAGiy1UQHL3gV8gSRBDChy/KYoVuBX3H1njQylqM H/uFmWVS735yZ/E/eijE6CxZt5ZfCCG1U7t9MN/ay1xTvwj854cVpNUZ1ymNlhbTFObK fnuw== X-Gm-Message-State: AOAM530VZkRUyTZLevgvGLNTohqK4aIZdPUUXR3c7QLK4SWpvbNvAH9k DqgIwLMwsYVY67Cbe+YxKh0= X-Google-Smtp-Source: ABdhPJycPFS19GDOO1UnYYa1JYd5SfgEsQ2Nuo61hTVplMA8adccp1QKIZdT0PoU+bJZDlLL+Las2Q== X-Received: by 2002:a1c:ddc3:: with SMTP id u186mr3858771wmg.72.1596645615200; Wed, 05 Aug 2020 09:40:15 -0700 (PDT) Received: from CBGR90WXYV0 (54-240-197-234.amazon.com. [54.240.197.234]) by smtp.gmail.com with ESMTPSA id g16sm3265825wrs.88.2020.08.05.09.40.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Aug 2020 09:40:14 -0700 (PDT) From: Paul Durrant X-Google-Original-From: "Paul Durrant" To: "'Jan Beulich'" , "'Oleksandr Tyshchenko'" References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-8-git-send-email-olekstysh@gmail.com> <4ffa6434-3ad6-04dc-bfde-f75196930fb4@suse.com> In-Reply-To: <4ffa6434-3ad6-04dc-bfde-f75196930fb4@suse.com> Subject: RE: [RFC PATCH V1 07/12] A collection of tweaks to be able to run emulator in driver domain Date: Wed, 5 Aug 2020 17:40:20 +0100 Message-ID: <005f01d66b47$1c58ccc0$550a6640$@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Content-Language: en-gb Thread-Index: AQIHYXuU00Oy15gaFT3m+7M9vTQs4QJrY6HzAsS1Dt2onkgdgA== X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: paul@xen.org Cc: 'Stefano Stabellini' , 'Julien Grall' , 'Wei Liu' , 'Andrew Cooper' , 'Ian Jackson' , 'George Dunlap' , 'Oleksandr Tyshchenko' , xen-devel@lists.xenproject.org, 'Daniel De Graaf' Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" > -----Original Message----- > From: Jan Beulich > Sent: 05 August 2020 17:20 > To: Oleksandr Tyshchenko ; Paul Durrant = > Cc: xen-devel@lists.xenproject.org; Oleksandr Tyshchenko = ; Andrew > Cooper ; George Dunlap = ; Ian Jackson > ; Julien Grall ; Stefano = Stabellini > ; Wei Liu ; Daniel De Graaf = > Subject: Re: [RFC PATCH V1 07/12] A collection of tweaks to be able to = run emulator in driver domain >=20 > On 03.08.2020 20:21, Oleksandr Tyshchenko wrote: > > From: Oleksandr Tyshchenko > > > > Trying to run emulator in driver domain I ran into various issues > > mostly policy-related. So this patch tries to resolve all them > > plobably in a hackish way. I would like to get feedback how > > to implement them properly as having an emulator in driver domain > > is a completely valid use-case. >=20 > From going over the comments I can only derive you want to run > an emulator in a driver domain, which doesn't really make sense > to me. A driver domain has a different purpose after all. If > instead you mean it to be run in just some other domain (which > also isn't the domain controlling the target), then there may > be more infrastructure changes needed. >=20 > Paul - was/is your standalone ioreq server (demu?) able to run > in other than the domain controlling a guest? >=20 Not something I've done yet, but it was always part of the idea so that = we could e.g. pass through a device to a dedicated domain and then run = multiple demu instances there to virtualize it for many domUs. (I'm = thinking here of a device that is not SR-IOV and hence would need some = bespoke emulation code to share it out). That dedicated domain would be = termed the 'driver domain' simply because it is running the device = driver for the h/w that underpins the emulation. Paul From xen-devel-bounces@lists.xenproject.org Wed Aug 05 16:42:01 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 16:42:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3MUK-0000eU-LW; Wed, 05 Aug 2020 16:42:00 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3MUJ-0000eL-9E for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 16:41:59 +0000 X-Inumbo-ID: e4ffa99b-04ae-4d85-9e99-3dae58643633 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e4ffa99b-04ae-4d85-9e99-3dae58643633; Wed, 05 Aug 2020 16:41:58 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 55BC82067D; Wed, 5 Aug 2020 16:41:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596645717; bh=kQSllmn6YanvKxFLx6/+6zwojR89djKhoceBz2aAjyY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=y22tqEcv4kHr3qJFIZ3SklKLXa5g2UJ1OKBUk8ZkdLgyuyQdtIssWTYW+fDgpCj7R rF0mUHH+XnET6R7YrJqJZMvrknYQsyUPl4thfD2Lc59ZVE6FoeR+Thz2a/fL6X4yWg IO1LujMZLdl3HM5nWD5+qyYJ1VVOlIhNrYzeejJo= Date: Wed, 5 Aug 2020 09:41:56 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Jan Beulich Subject: Re: [RFC PATCH V1 04/12] xen/arm: Introduce arch specific bits for IOREQ/DM features In-Reply-To: Message-ID: References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-5-git-send-email-olekstysh@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Oleksandr Tyshchenko , Julien Grall , xen-devel@lists.xenproject.org, Daniel De Graaf , Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Wed, 5 Aug 2020, Jan Beulich wrote: > On 05.08.2020 01:22, Stefano Stabellini wrote: > > On Mon, 3 Aug 2020, Oleksandr Tyshchenko wrote: > >> --- a/xen/include/asm-arm/p2m.h > >> +++ b/xen/include/asm-arm/p2m.h > >> @@ -385,10 +385,11 @@ static inline int set_foreign_p2m_entry(struct domain *d, unsigned long gfn, > >> mfn_t mfn) > >> { > >> /* > >> - * NOTE: If this is implemented then proper reference counting of > >> - * foreign entries will need to be implemented. > >> + * XXX: handle properly reference. It looks like the page may not always > >> + * belong to d. > > > > Just as a reference, and without taking away anything from the comment, > > I think that QEMU is doing its own internal reference counting for these > > mappings. > > Which of course in no way replaces the need to do proper ref counting > in Xen. (Just FAOD, as I'm not sure why you've said what you've said.) Given the state of the series, which is a RFC, I only meant to say that the lack of refcounting shouldn't prevent things from working when using QEMU. In the sense that if somebody wants to give it a try for an early demo, they should be able to see it running without crashes. Of course, refcounting needs to be implemented. From xen-devel-bounces@lists.xenproject.org Wed Aug 05 17:21:41 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 17:21:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3N6C-000498-Qw; Wed, 05 Aug 2020 17:21:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3N6B-000493-Ii for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 17:21:07 +0000 X-Inumbo-ID: 886d5c0b-818e-472d-8033-dc25ab1f62df Received: from mail-40133.protonmail.ch (unknown [185.70.40.133]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 886d5c0b-818e-472d-8033-dc25ab1f62df; Wed, 05 Aug 2020 17:21:01 +0000 (UTC) Date: Wed, 05 Aug 2020 17:20:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trmm.net; s=protonmail; t=1596648059; bh=l1doubPoPn+XYU/lLBZRazYcvNj3vmi0JDcutwQoyQ0=; h=Date:To:From:Reply-To:Subject:From; b=AGrU1KVLW16bS57DpbUTZZG+rG2iKEZMXg4QnH1b0D64iZwGnAEdbbIks8RsTVj6z JIIcK8OSVTUAf4V55cq3v8YyQjEJ+UUbYTTbBLHj5zpYKheiWsFOHSw3bRKA9xKdx6 9evw2IJpXS2OSKwtwAbDeByh8jhFeaBtI/mGxNFQ= To: "xen-devel@lists.xenproject.org" From: Trammell Hudson Subject: [RFC] efi/boot: Unified Xen executable for UEFI Secure Boot support Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: Trammell Hudson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" This preliminary patch adds support for bundling the Xen hypervisor, xen.cf= g, the Linux kernel, initrd and XSM into a single "unified" EFI executable = that can be signed by sbsigntool for verification by UEFI Secure Boot. It = is inspired by systemd-boot's unified kernel technique and borrows the func= tion to locate PE sections from systemd's LGPL'ed code. The configuration, kernel, etc are added after building using objcopy to ad= d named sections for each input file. This allows an administrator to upda= te the components independently without requiring rebuilding xen. During EF= I boot, Xen looks at its own loaded image to locate the PE sections and, if= secure boot is enabled, only allows use of the unified components. The resulting EFI executable can be invoked directly from the UEFI Boot Man= ager, removing the need to use a separate loader like grub. Unlike the shim= based verification, the signature covers the entire Xen+config+kernel+init= rd unified file. This also ensures that properly configured platforms will = measure the entire runtime into the TPM for unsealing secrets or remote att= estation. It has been tested on qemu OVMF with Secure Boot enabled, as well as on rea= l Thinkpad hardware. The EFI console is very slow, although it works and i= s able to boot into dom0. diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index 5a520bf..b7b08b6 100644 --- a/xen/common/efi/boot.c +++ b/xen/common/efi/boot.c @@ -102,6 +102,7 @@ union string { struct file { UINTN size; + bool need_to_free; union { EFI_PHYSICAL_ADDRESS addr; void *ptr; @@ -330,13 +331,13 @@ static void __init noreturn blexit(const CHAR16 *str) if ( !efi_bs ) efi_arch_halt(); - if ( cfg.addr ) + if ( cfg.addr && cfg.need_to_free) efi_bs->FreePages(cfg.addr, PFN_UP(cfg.size)); - if ( kernel.addr ) + if ( kernel.addr && kernel.need_to_free) efi_bs->FreePages(kernel.addr, PFN_UP(kernel.size)); - if ( ramdisk.addr ) + if ( ramdisk.addr && ramdisk.need_to_free) efi_bs->FreePages(ramdisk.addr, PFN_UP(ramdisk.size)); - if ( xsm.addr ) + if ( xsm.addr && xsm.need_to_free) efi_bs->FreePages(xsm.addr, PFN_UP(xsm.size)); efi_arch_blexit(); @@ -619,6 +620,7 @@ static bool __init read_file(EFI_FILE_HANDLE dir_handle= , CHAR16 *name, what =3D what ?: L"Seek"; else { + file->need_to_free =3D true; file->addr =3D min(1UL << (32 + PAGE_SHIFT), HYPERVISOR_VIRT_END - DIRECTMAP_VIRT_START); ret =3D efi_bs->AllocatePages(AllocateMaxAddress, EfiLoaderData, @@ -665,6 +667,136 @@ static bool __init read_file(EFI_FILE_HANDLE dir_hand= le, CHAR16 *name, return true; } + +struct DosFileHeader { + UINT8 Magic[2]; + UINT16 LastSize; + UINT16 nBlocks; + UINT16 nReloc; + UINT16 HdrSize; + UINT16 MinAlloc; + UINT16 MaxAlloc; + UINT16 ss; + UINT16 sp; + UINT16 Checksum; + UINT16 ip; + UINT16 cs; + UINT16 RelocPos; + UINT16 nOverlay; + UINT16 reserved[4]; + UINT16 OEMId; + UINT16 OEMInfo; + UINT16 reserved2[10]; + UINT32 ExeHeader; +} __attribute__((packed)); + +#define PE_HEADER_MACHINE_I386 0x014c +#define PE_HEADER_MACHINE_X64 0x8664 +#define PE_HEADER_MACHINE_ARM64 0xaa64 + +struct PeFileHeader { + UINT16 Machine; + UINT16 NumberOfSections; + UINT32 TimeDateStamp; + UINT32 PointerToSymbolTable; + UINT32 NumberOfSymbols; + UINT16 SizeOfOptionalHeader; + UINT16 Characteristics; +} __attribute__((packed)); + +struct PeHeader { + UINT8 Magic[4]; + struct PeFileHeader FileHeader; +} __attribute__((packed)); + +struct PeSectionHeader { + UINT8 Name[8]; + UINT32 VirtualSize; + UINT32 VirtualAddress; + UINT32 SizeOfRawData; + UINT32 PointerToRawData; + UINT32 PointerToRelocations; + UINT32 PointerToLinenumbers; + UINT16 NumberOfRelocations; + UINT16 NumberOfLinenumbers; + UINT32 Characteristics; +} __attribute__((packed)); + +static void * __init pe_find_section(const void * const image_base, + const char * section_name, UINTN * size_out) +{ + const CHAR8 * const base =3D image_base; + const struct DosFileHeader * dos =3D (const void*) base; + const struct PeHeader * pe; + const UINTN name_len =3D strlen(section_name); + UINTN offset; + + if ( base =3D=3D NULL ) + return NULL; + + if ( memcmp(dos->Magic, "MZ", 2) !=3D 0 ) + return NULL; + + pe =3D (const void *) &base[dos->ExeHeader]; + if ( memcmp(pe->Magic, "PE\0\0", 4) !=3D 0 ) + return NULL; + + /* PE32+ Subsystem type */ + if (pe->FileHeader.Machine !=3D PE_HEADER_MACHINE_X64 + && pe->FileHeader.Machine !=3D PE_HEADER_MACHINE_ARM64 + && pe->FileHeader.Machine !=3D PE_HEADER_MACHINE_I386) + return NULL; + + if ( pe->FileHeader.NumberOfSections > 96 ) + return NULL; + + offset =3D dos->ExeHeader + sizeof(*pe) + pe->FileHeader.SizeOfOptiona= lHeader; + + for (UINTN i =3D 0; i < pe->FileHeader.NumberOfSections; i++) + { + const struct PeSectionHeader *const sect =3D (const struct PeSecti= onHeader *)&base[offset]; + if ( memcmp(sect->Name, section_name, name_len) =3D=3D 0 ) + { + if ( size_out ) + *size_out =3D sect->VirtualSize; + return (void*)(sect->VirtualAddress + (uintptr_t) image_base); + } + + offset +=3D sizeof(*sect); + } + + return NULL; +} + +static bool __init read_section(const void * const image_base, + char * const name, struct file *file, char *options) +{ + union string name_string =3D { .s =3D name + 1 }; + if ( !image_base ) + return false; + + file->ptr =3D pe_find_section(image_base, name, &file->size); + if ( !file->ptr ) + return false; + + file->need_to_free =3D false; + + if ( file =3D=3D &cfg ) + return true; + + s2w(&name_string); + PrintStr(name_string.w); + PrintStr(L": "); + DisplayUint(file->addr, 2 * sizeof(file->addr)); + PrintStr(L"-"); + DisplayUint(file->addr + file->size, 2 * sizeof(file->addr)); + PrintStr(newline); + efi_arch_handle_module(file, name_string.w, options); + efi_bs->FreePool(name_string.w); + + return true; +} + static void __init pre_parse(const struct file *cfg) { char *ptr =3D cfg->ptr, *end =3D ptr + cfg->size; @@ -968,6 +1100,21 @@ static void __init setup_efi_pci(void) efi_bs->FreePool(handles); } +static bool __init efi_secure_boot(void) +{ + static const EFI_GUID global_guid =3D EFI_GLOBAL_VARIABLE; + uint8_t buf[8]; + UINTN size =3D sizeof(buf); + + if ( efi_rs->GetVariable(L"SecureBoot", (EFI_GUID *)&global_guid, NULL= , &size, buf) !=3D EFI_SUCCESS ) + return false; + + if ( size !=3D 1 ) + return false; + + return buf[0] !=3D 0; +} + static void __init efi_variables(void) { EFI_STATUS status; @@ -1143,6 +1290,7 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *S= ystemTable) static EFI_GUID __initdata loaded_image_guid =3D LOADED_IMAGE_PROTOCOL= ; static EFI_GUID __initdata shim_lock_guid =3D SHIM_LOCK_PROTOCOL_GUID; EFI_LOADED_IMAGE *loaded_image; + void * image_base =3D NULL; EFI_STATUS status; unsigned int i, argc; CHAR16 **argv, *file_name, *cfg_file_name =3D NULL, *options =3D NULL; @@ -1153,6 +1301,7 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *S= ystemTable) bool base_video =3D false; char *option_str; bool use_cfg_file; + bool secure =3D false; __set_bit(EFI_BOOT, &efi_flags); __set_bit(EFI_LOADER, &efi_flags); @@ -1171,6 +1320,10 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *= SystemTable) PrintErrMesg(L"No Loaded Image Protocol", status); efi_arch_load_addr_check(loaded_image); + if ( loaded_image ) + image_base =3D loaded_image->ImageBase; + + secure =3D efi_secure_boot(); if ( use_cfg_file ) { @@ -1249,9 +1402,19 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *= SystemTable) /* Get the file system interface. */ dir_handle =3D get_parent_handle(loaded_image, &file_name); - /* Read and parse the config file. */ - if ( !cfg_file_name ) + if ( read_section(image_base, ".config", &cfg, NULL) ) + { + if ( secure ) + PrintStr(L"Secure Boot enabled: "); + PrintStr(L"Using unified config file\r\n"); + } + else if ( secure ) + { + blexit(L"Secure Boot enabled, but configuration not included."= ); + } + else if ( !cfg_file_name ) { + /* Read and parse the config file. */ CHAR16 *tail; while ( (tail =3D point_tail(file_name)) !=3D NULL ) @@ -1303,27 +1466,47 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE = *SystemTable) efi_arch_cfg_file_early(dir_handle, section.s); option_str =3D split_string(name.s); - read_file(dir_handle, s2w(&name), &kernel, option_str); - efi_bs->FreePool(name.w); - if ( !EFI_ERROR(efi_bs->LocateProtocol(&shim_lock_guid, NULL, - (void **)&shim_lock)) && - (status =3D shim_lock->Verify(kernel.ptr, kernel.size)) !=3D = EFI_SUCCESS ) - PrintErrMesg(L"Dom0 kernel image could not be verified", statu= s); - - name.s =3D get_value(&cfg, section.s, "ramdisk"); - if ( name.s ) + if ( !read_section(image_base, ".kernel", &kernel, option_str) ) { - read_file(dir_handle, s2w(&name), &ramdisk, NULL); + if ( secure ) + blexit(L"Secure Boot enabled, but no kernel included"); + read_file(dir_handle, s2w(&name), &kernel, option_str); efi_bs->FreePool(name.w); + + if ( !EFI_ERROR(efi_bs->LocateProtocol(&shim_lock_guid, NULL, + (void **)&shim_lock)) && + (status =3D shim_lock->Verify(kernel.ptr, kernel.size)) != =3D EFI_SUCCESS ) + PrintErrMesg(L"Dom0 kernel image could not be verified", s= tatus); } - name.s =3D get_value(&cfg, section.s, "xsm"); - if ( name.s ) + if ( !read_section(image_base, ".ramdisk", &ramdisk, NULL) ) { - read_file(dir_handle, s2w(&name), &xsm, NULL); - efi_bs->FreePool(name.w); + if ( secure ) + blexit(L"Secure Boot enabled, but no initrd included"); + name.s =3D get_value(&cfg, section.s, "ramdisk"); + if ( name.s ) + { + read_file(dir_handle, s2w(&name), &ramdisk, NULL); + efi_bs->FreePool(name.w); + } + } + +#ifdef CONFIG_XSM + if ( !read_section(image_base, ".xsm", &xsm, NULL) ) + { +#ifndef CONFIG_XSM_FLASK_POLICY + if ( secure ) + blexit(L"Secure Boot enabled, but no FLASK policy included= "); +#endif + name.s =3D get_value(&cfg, section.s, "xsm"); + if ( name.s ) + { + read_file(dir_handle, s2w(&name), &xsm, NULL); + efi_bs->FreePool(name.w); + } } +#endif /* * EFI_LOAD_OPTION does not supply an image name as first componen= t: diff --git a/xen/scripts/unify-xen b/xen/scripts/unify-xen new file mode 100755 index 0000000..b6072b1 --- /dev/null +++ b/xen/scripts/unify-xen @@ -0,0 +1,68 @@ +#!/bin/bash +# Merge a Linux kernel, initrd and commandline into xen.efi to produce a s= ingle signed +# EFI executable. +# +# turn off "expressions don't expand in single quotes" +# and "can't follow non-constant sources" +# shellcheck disable=3DSC2016 disable=3DSC1090 +set -e -o pipefail +export LC_ALL=3DC + +die() { echo "$@" >&2 ; exit 1 ; } +warn() { echo "$@" >&2 ; } +debug() { [ "$VERBOSE" =3D=3D 1 ] && echo "$@" >&2 ; } + +cleanup() { +=09rm -rf "$TMP" +} + +TMP=3D$(mktemp -d) +TMP_MOUNT=3Dn +trap cleanup EXIT + +######################################## + +# Usage +# unify xen.efi xen.cfg bzimage initrd +# Xen goes up to a pad at 00400000 + +XEN=3D"$1" +CONFIG=3D"$2" +KERNEL=3D"$3" +RAMDISK=3D"$4" +#=09--change-section-vma .config=3D0x0500000 \ +#=09--change-section-vma .kernel=3D0x0510000 \ +#=09--change-section-vma .ramdisk=3D0x3000000 \ + +objcopy \ +=09--add-section .kernel=3D"$KERNEL" \ +=09--add-section .ramdisk=3D"$RAMDISK" \ +=09--add-section .config=3D"$CONFIG" \ +=09--change-section-vma .config=3D0xffff82d041000000 \ +=09--change-section-vma .kernel=3D0xffff82d041010000 \ +=09--change-section-vma .ramdisk=3D0xffff82d042000000 \ +=09"$XEN" \ +=09"$TMP/xen.efi" \ +|| die "$TMP/xen.efi: unable to create" + +KEY_ENGINE=3D"" +KEY=3D"/etc/safeboot/signing.key" +CERT=3D"/etc/safeboot/cert.pem" + +for try in 1 2 3 ; do +=09warn "$TMP/xen.efi: Signing (ignore warnings about gaps)" +=09sbsign.safeboot \ +=09=09$KEY_ENGINE \ +=09=09--key "$KEY" \ +=09=09--cert "$CERT" \ +=09=09--output "xen.signed.efi" \ +=09=09"$TMP/xen.efi" \ +=09&& break + +=09if [ "$try" =3D=3D 3 ]; then +=09=09die "xen.signed.efi: failed after $try tries" +=09fi + +=09warn "$OUTDIR/linux.efi: signature failed! Try $try." +done + From xen-devel-bounces@lists.xenproject.org Wed Aug 05 17:42:56 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 17:42:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3NRA-0005zC-O2; Wed, 05 Aug 2020 17:42:48 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3NR9-0005z7-GB for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 17:42:47 +0000 X-Inumbo-ID: 5426db28-2a1c-4b93-85b2-055c0a10ca65 Received: from smtp-fw-9101.amazon.com (unknown [207.171.184.25]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5426db28-2a1c-4b93-85b2-055c0a10ca65; Wed, 05 Aug 2020 17:42:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1596649367; x=1628185367; h=date:from:to:cc:message-id:references:mime-version: in-reply-to:subject; bh=lNEkMbYi0vdrAauS7Kx1F2bZJKjVMy/W93IpO/fQsUY=; b=Fm6joPKFAVmwAkSmSuDiGnD7vVXqrnmajd3Am0kq/CpoJO3FbNIrY6py 14raY8atiI10mrwX80EUIUmiaXIsyZ7N1WOakfgRfqv8DrMuGVa7lpK28 ZTImJ0P6hBK+xf/ZRsknkuLA+1Mg3toe48eITJj9HKd9xCjEkxkKD2cdW A=; IronPort-SDR: 9ySw8fWle7MttK7suY4BIhxnPpUpw/OAAJafe5LAcUtSaR7nXlHuY3JimXe5qJR44ypaJ2YRoP 96gheUehfPyA== X-IronPort-AV: E=Sophos;i="5.75,438,1589241600"; d="scan'208";a="57653120" Subject: Re: [PATCH v2 01/11] xen/manage: keep track of the on-going suspend mode Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-2c-579b7f5b.us-west-2.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-9101.sea19.amazon.com with ESMTP; 05 Aug 2020 17:42:44 +0000 Received: from EX13MTAUEB002.ant.amazon.com (pdx4-ws-svc-p6-lb7-vlan3.pdx.amazon.com [10.170.41.166]) by email-inbound-relay-2c-579b7f5b.us-west-2.amazon.com (Postfix) with ESMTPS id C5250A2967; Wed, 5 Aug 2020 17:42:42 +0000 (UTC) Received: from EX13D08UEB001.ant.amazon.com (10.43.60.245) by EX13MTAUEB002.ant.amazon.com (10.43.60.12) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 5 Aug 2020 17:42:20 +0000 Received: from EX13MTAUEA002.ant.amazon.com (10.43.61.77) by EX13D08UEB001.ant.amazon.com (10.43.60.245) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 5 Aug 2020 17:42:20 +0000 Received: from dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com (172.22.96.68) by mail-relay.amazon.com (10.43.61.169) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 5 Aug 2020 17:42:19 +0000 Received: by dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com (Postfix, from userid 4335130) id D027740865; Wed, 5 Aug 2020 17:42:19 +0000 (UTC) Date: Wed, 5 Aug 2020 17:42:19 +0000 From: Anchal Agarwal To: Boris Ostrovsky Message-ID: <20200805174219.GA16105@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> References: <20200722180229.GA32316@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> <20200723225745.GB32316@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> <66a9b838-70ed-0807-9260-f2c31343a081@oracle.com> <20200730230634.GA17221@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> <53b577a3-6af9-5587-7e47-485be38b3653@oracle.com> <20200804234201.GA23820@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> <50d0dbe1-533e-792a-6916-8c72d623064a@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <50d0dbe1-533e-792a-6916-8c72d623064a@oracle.com> User-Agent: Mutt/1.5.21 (2010-09-15) Precedence: Bulk X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: x86@kernel.org, len.brown@intel.com, peterz@infradead.org, benh@kernel.crashing.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, pavel@ucw.cz, hpa@zytor.com, Stefano Stabellini , eduval@amazon.com, mingo@redhat.com, xen-devel@lists.xenproject.org, sblbir@amazon.com, axboe@kernel.dk, konrad.wilk@oracle.com, bp@alien8.de, tglx@linutronix.de, jgross@suse.com, netdev@vger.kernel.org, linux-pm@vger.kernel.org, rjw@rjwysocki.net, kamatam@amazon.com, vkuznets@redhat.com, davem@davemloft.net, dwmw@amazon.co.uk, roger.pau@citrix.com Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Wed, Aug 05, 2020 at 09:31:13AM -0400, Boris Ostrovsky wrote: > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. > > > > On 8/4/20 7:42 PM, Anchal Agarwal wrote: > > > > I think this could be done. PM_HIBERNATION_PREPARE could return -ENOTSUPP > > for arm and pvh dom0 when the notifier call chain is invoked for this case > > in hibernate(). This will then be an empty notifier just for checking two > > usecases. > > Also, for pvh dom0, the earlier code didn't register any notifier, > > with this approach you are suggesting setup the notifier for hvm/pvh dom0 and > > arm but fail during notifier call chain during PM_HIBERNATION_PREPARE ? > > > Right. > > > (Although the earlier code did register the notifier: > xen_setup_pm_notifier() would return an error for !xen_hvm_domain() and > PVH *is* an HVM domain, so registration would actually happen) > Yes you are right. My bad, what I meant with "earlier code" was whatever we discussed w.r.t to removing the notifier all together, it won't be registered for pvh dom0. Anyways got the point :) > > > > > I think still getting rid of suspend mode that was earlier a part of this > > notifier is a good idea as it seems redundant as you pointed out earlier. > > > Yes. > > > -boris Thanks, Anchal > > From xen-devel-bounces@lists.xenproject.org Wed Aug 05 18:19:30 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 18:19:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3O0X-0000Lk-Kk; Wed, 05 Aug 2020 18:19:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3O0W-0000Lf-Ez for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 18:19:20 +0000 X-Inumbo-ID: e040c6ea-82c3-4840-b2f7-3b12398c2c3b Received: from mail2.protonmail.ch (unknown [185.70.40.22]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e040c6ea-82c3-4840-b2f7-3b12398c2c3b; Wed, 05 Aug 2020 18:19:18 +0000 (UTC) Date: Wed, 05 Aug 2020 18:19:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trmm.net; s=protonmail; t=1596651557; bh=RopEZN0t10O0rBRL8XhbCwmqHbm4O7b177x8ArVDv1o=; h=Date:To:From:Reply-To:Subject:From; b=n1nPO2Be0j5Jy2BdiXFW2EDhuuKmbVOaSAGwkUbiPTC9teGDojtZPg2eW/6N5GH7F Tf6lXMClnKoyaDawSMpJO1zscEnX6wnCnFFU4eeQotUqPMJ5iKH483ILgcQK6TwK1u S8z/fwhGlor9azpH++u2pGsJDcOfnStnCsBNPa14= To: Xen-devel From: Trammell Hudson Subject: EFI executable corruption when live patching is turned off Message-ID: <3TMd7J2u5gCA8ouIG_Xfcw7s5JKMG06XsDIesEB3Fi9htUJ43Lfl057wXohlpCHcszqoCmicpIlneEDO26ZqT8QfC2Y39VxBuqD3nS1j5Q4=@trmm.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: Trammell Hudson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" When building xen from head with almost any combination of options, the res= ulting xen.efi seems properly formed. When CONFIG_LIVEPATCH is turned off, = however, the resulting xen.efi is corrupted in some way and binutils no lon= ger wants to work with it: ~/build/xen-clean/xen$ git rev-parse HEAD 81fd0d3ca4b2cd309403c6e8da662c325dd35750 ~/build/xen-clean/xen$ diff .config.orig .config 71,72c71 < CONFIG_LIVEPATCH=3Dy < CONFIG_FAST_SYMBOL_LOOKUP=3Dy --- > # CONFIG_LIVEPATCH is not set 105a105 > # CONFIG_COVERAGE is not set ~/build/xen-clean/xen$ objcopy xen-orig.efi test.efi ~/build/xen-clean/xen$ objcopy xen.efi test.efi objcopy: test.efi: Data Directory size (1c) exceeds space left in section (= 18) objcopy: test.efi: error copying private BFD data: file in wrong format ~/build/xen-clean/xen$ objcopy --version | head -1 GNU objcopy (GNU Binutils for Ubuntu) 2.34 I spent most of today unsuccessfully trying to figure out what was differen= t between the builds (on multiple build host OS with different binutils), s= o I'm hoping that perhaps someone else has seen this problem. -- Trammell From xen-devel-bounces@lists.xenproject.org Wed Aug 05 18:31:47 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 18:31:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3OC6-0001x2-OP; Wed, 05 Aug 2020 18:31:18 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3OC5-0001wx-U7 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 18:31:17 +0000 X-Inumbo-ID: 6a6e6de7-8463-4510-b17b-29cc8cf439c5 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6a6e6de7-8463-4510-b17b-29cc8cf439c5; Wed, 05 Aug 2020 18:31:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596652275; h=subject:to:references:cc:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=zblnwylMrCES0o0qd7d9zi2gUxjGxJewipIWMnjX2Eg=; b=SvbCb3eU1MHPkTXUNuIfgQ927Os3GAeMKEITbZp+4akHsDnHyfc/myOG cP2FxdOyp3MqClAPY0TCcV0W9q29xxAzXKRM/anUMCRxeALb3+nd4H9Az 2keDzSk88qECf5bddcPrjnVmyj9vMf/nH0zKGRtkJkgD/0LSmxmLwccWy E=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 0QLZ0NTlHQ9EPDseLviPBGYrz4w1SDXsh8SWacOwYnqIMeeKQINQDT0rCebWJ1QLcQ0arrLulj EtIZMQj6wvdjVzxW5KY3euCxt3JlExtpyByPNPtv/+kmklffSbCcQ9jGGS00Ns5jCvxeAfHpca HidgBqgpbHFWJmyt38Ts2BMt7W31pS/Fp63v+vFlPoiCW8i3nMa9EDEkdGQXartF4pP+53matN 5kpaU/N+qJiT7nnUgfbJJesz3tjpV8Zcj2wG1XoX+zORbNnZbnxLtesO5Oy7qx+LBLKsXAWGJg ewY= X-SBRS: 3.7 X-MesageID: 24843534 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,438,1589256000"; d="scan'208";a="24843534" Subject: Re: EFI executable corruption when live patching is turned off To: Trammell Hudson , Xen-devel References: <3TMd7J2u5gCA8ouIG_Xfcw7s5JKMG06XsDIesEB3Fi9htUJ43Lfl057wXohlpCHcszqoCmicpIlneEDO26ZqT8QfC2Y39VxBuqD3nS1j5Q4=@trmm.net> From: Andrew Cooper Message-ID: Date: Wed, 5 Aug 2020 19:30:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <3TMd7J2u5gCA8ouIG_Xfcw7s5JKMG06XsDIesEB3Fi9htUJ43Lfl057wXohlpCHcszqoCmicpIlneEDO26ZqT8QfC2Y39VxBuqD3nS1j5Q4=@trmm.net> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Ross Lagerwall , Jan Beulich , Konrad Rzeszutek Wilk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 05/08/2020 19:19, Trammell Hudson wrote: > When building xen from head with almost any combination of options, the resulting xen.efi seems properly formed. When CONFIG_LIVEPATCH is turned off, however, the resulting xen.efi is corrupted in some way and binutils no longer wants to work with it: > > ~/build/xen-clean/xen$ git rev-parse HEAD > 81fd0d3ca4b2cd309403c6e8da662c325dd35750 > ~/build/xen-clean/xen$ diff .config.orig .config > 71,72c71 > < CONFIG_LIVEPATCH=y > < CONFIG_FAST_SYMBOL_LOOKUP=y > --- >> # CONFIG_LIVEPATCH is not set > 105a105 >> # CONFIG_COVERAGE is not set > ~/build/xen-clean/xen$ objcopy xen-orig.efi test.efi > ~/build/xen-clean/xen$ objcopy xen.efi test.efi > objcopy: test.efi: Data Directory size (1c) exceeds space left in section (18) > objcopy: test.efi: error copying private BFD data: file in wrong format > ~/build/xen-clean/xen$ objcopy --version | head -1 > GNU objcopy (GNU Binutils for Ubuntu) 2.34 > > > I spent most of today unsuccessfully trying to figure out what was different between the builds (on multiple build host OS with different binutils), so I'm hoping that perhaps someone else has seen this problem. CC'ing appropriate maintainers. The difference caused by CONFIG_LIVEPATCH will probably be the logic to embed the GNU BuildID, which for xen.efi takes a trip through .bin/.ihex immediately prior to the final link. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Aug 05 19:30:46 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 19:30:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3P7T-00073n-AP; Wed, 05 Aug 2020 19:30:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3P7R-00073i-Q3 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 19:30:33 +0000 X-Inumbo-ID: 49caa562-2e20-4179-ad6b-5b0ae0a276b3 Received: from mail-lf1-x142.google.com (unknown [2a00:1450:4864:20::142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 49caa562-2e20-4179-ad6b-5b0ae0a276b3; Wed, 05 Aug 2020 19:30:31 +0000 (UTC) Received: by mail-lf1-x142.google.com with SMTP id v15so20337003lfg.6 for ; Wed, 05 Aug 2020 12:30:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=kv3aU3j6jANp5On1k4mOlf1qgiZKGerRAvM7osri8vo=; b=bC8ge7oysmtSVVS2yJGwPT22hbdD+lf4N8tio2YlroXhEmPTdh136kHkNK5HjAJnAC 4neDZMCGLw2YUrzgWrDgY8Yu22ajR4Cu5KGcRRL7tfsgAHLN4rztfIBjOwvIqHqbzZqj iJy/njxUqxC2IJfh7OQX0pEzn/rdRUcHs6jzrX7ukpgOSg/tlfW41PINyxYB8xfF/rxf 8GhaBm/u4lryS2jy6D4OSgbyF5m5XBJ3gT0Sj2+t65rWJ8AKR8gHN0zlyNLSpU9Lw6Cg GkQmtqqtfS+NgQW3e40huRdYOzVqEGcVhIpvyyFkn4ZhtdCKO0V34ZfjTKNmqN8BdsXp eTUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=kv3aU3j6jANp5On1k4mOlf1qgiZKGerRAvM7osri8vo=; b=TmuywoS487VdEDZQ4Mx1IzllSSdjq192UDC4hB97iUnpbOyg6OaVEdu+JAa3IWUOZl DaGpYUFKPmA028uCRZAItyyXxxEoZxb4v6EUNx6ou0IVhD+132tt63Psjb4QlpCRwjO4 /1bKPIeMFk7YTQIztjbm10kPnWdu99Jxwitrqi8vZN1u61BFdp5JfnVKgdrmfzr8ph25 3JyU7k8ETAS5G/kVQjQ7kfBzRyjdGq56XtbBY7iplg250qbgFdH/z4mi9NmCIYd/XiDU F8jZUp6J997APkHLeGEjLSZjSS9bM5K5XxxfOvfehLyMfqSSqwJto+zBzqkoHYY7rR7i bnXA== X-Gm-Message-State: AOAM532oCrbRvO1g65u734eTiZkGSNOjMkwQy6Nzk2geE4A8mN3Sv80O /GFKbH1BJGDHXkzP9y53Jm0= X-Google-Smtp-Source: ABdhPJy/tKLuIMuoNWj3Jq2Kfc3/XIBNypmZkIO4uwCqD65vnTyH1/0W/taTYnWn1b5T3aDP56FvZg== X-Received: by 2002:ac2:4436:: with SMTP id w22mr2314916lfl.176.1596655829662; Wed, 05 Aug 2020 12:30:29 -0700 (PDT) Received: from [192.168.1.2] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id s9sm1261145ljh.46.2020.08.05.12.30.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2020 12:30:29 -0700 (PDT) Subject: Re: [RFC PATCH V1 04/12] xen/arm: Introduce arch specific bits for IOREQ/DM features To: Julien Grall , xen-devel@lists.xenproject.org References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-5-git-send-email-olekstysh@gmail.com> <11eaa2f0-84c7-5972-d14c-4cb02458e882@xen.org> From: Oleksandr Message-ID: <3ee50c66-8761-6c86-3fab-a4c23622d2b8@gmail.com> Date: Wed, 5 Aug 2020 22:30:23 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <11eaa2f0-84c7-5972-d14c-4cb02458e882@xen.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Julien Grall , Jan Beulich , Daniel De Graaf , Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 05.08.20 17:12, Julien Grall wrote: > Hi, Hi Julien > > On 03/08/2020 19:21, Oleksandr Tyshchenko wrote: >> From: Oleksandr Tyshchenko >> >> This patch makes possible to forward Guest MMIO accesses >> to a device emulator on Arm and enables that support for >> Arm64. >> >> Also update XSM code a bit to let DM op be used on Arm. >> New arch DM op will be introduced in the follow-up patch. >> >> Please note, at the moment build on Arm32 is broken >> (see cmpxchg usage in hvm_send_buffered_ioreq()) if someone >> wants to enable CONFIG_IOREQ_SERVER due to the lack of >> cmpxchg_64 support on Arm32. >> >> Please note, this is a split/cleanup of Julien's PoC: >> "Add support for Guest IO forwarding to a device emulator" >> >> Signed-off-by: Julien Grall >> Signed-off-by: Oleksandr Tyshchenko >> --- >>   tools/libxc/xc_dom_arm.c        |  25 +++++++--- >>   xen/arch/arm/Kconfig            |   1 + >>   xen/arch/arm/Makefile           |   2 + >>   xen/arch/arm/dm.c               |  34 +++++++++++++ >>   xen/arch/arm/domain.c           |   9 ++++ >>   xen/arch/arm/hvm.c              |  46 +++++++++++++++++- >>   xen/arch/arm/io.c               |  67 +++++++++++++++++++++++++- >>   xen/arch/arm/ioreq.c            |  86 >> +++++++++++++++++++++++++++++++++ >>   xen/arch/arm/traps.c            |  17 +++++++ >>   xen/common/memory.c             |   5 +- >>   xen/include/asm-arm/domain.h    |  80 +++++++++++++++++++++++++++++++ >>   xen/include/asm-arm/hvm/ioreq.h | 103 >> ++++++++++++++++++++++++++++++++++++++++ >>   xen/include/asm-arm/mmio.h      |   1 + >>   xen/include/asm-arm/p2m.h       |   7 +-- >>   xen/include/xsm/dummy.h         |   4 +- >>   xen/include/xsm/xsm.h           |   6 +-- >>   xen/xsm/dummy.c                 |   2 +- >>   xen/xsm/flask/hooks.c           |   5 +- >>   18 files changed, 476 insertions(+), 24 deletions(-) >>   create mode 100644 xen/arch/arm/dm.c >>   create mode 100644 xen/arch/arm/ioreq.c >>   create mode 100644 xen/include/asm-arm/hvm/ioreq.h > > It feels to me the patch is doing quite a few things that are > indirectly related. Can this be split to make the review easier? > > I would like at least the following split from the series: >    - The tools changes >    - The P2M changes >    - The HVMOP plumbing (if we still require them) Sure, will split. However, I don't quite understand where we should leave HVMOP plumbing. If I understand correctly the suggestion was to switch to acquire interface instead (which requires a Linux version to be v4.17 at least)? I suspect, this is all about "xen/privcmd: add IOCTL_PRIVCMD_MMAP_RESOURCE" support for Linux? Sorry, if asking a lot of questions, my developing environment is based on Vendor's BSP which uses v4.14 currently. > > [...] > >> diff --git a/xen/arch/arm/dm.c b/xen/arch/arm/dm.c >> new file mode 100644 >> index 0000000..2437099 >> --- /dev/null >> +++ b/xen/arch/arm/dm.c >> @@ -0,0 +1,34 @@ >> +/* >> + * Copyright (c) 2019 Arm ltd. >> + * >> + * This program is free software; you can redistribute it and/or >> modify it >> + * under the terms and conditions of the GNU General Public License, >> + * version 2, as published by the Free Software Foundation. >> + * >> + * This program is distributed in the hope it will be useful, but >> WITHOUT >> + * ANY WARRANTY; without even the implied warranty of >> MERCHANTABILITY or >> + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public >> License for >> + * more details. >> + * >> + * You should have received a copy of the GNU General Public License >> along with >> + * this program; If not, see . >> + */ >> + >> +#include >> +#include > > The list of includes sounds strange. Can we make sure to include only > necessary headers and add the others when they are required? Sure, I moved arch_dm_op internals to the next patch in this series, but forgot to move corresponding headers as well. > > >> + >> +int arch_dm_op(struct xen_dm_op *op, struct domain *d, >> +               const struct dmop_args *op_args, bool *const_op) >> +{ >> +    return -EOPNOTSUPP; >> +} >> + >> +/* >> + * Local variables: >> + * mode: C >> + * c-file-style: "BSD" >> + * c-basic-offset: 4 >> + * tab-width: 4 >> + * indent-tabs-mode: nil >> + * End: >> + */ > >>   long do_hvm_op(unsigned long op, XEN_GUEST_HANDLE_PARAM(void) arg) >>   { >>       long rc = 0; >> @@ -111,7 +155,7 @@ long do_hvm_op(unsigned long op, >> XEN_GUEST_HANDLE_PARAM(void) arg) >>               if ( rc ) >>                   goto param_fail; >>   -            d->arch.hvm.params[a.index] = a.value; >> +            rc = hvmop_set_param(d, &a); >>           } >>           else >>           { >> diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c >> index ae7ef96..436f669 100644 >> --- a/xen/arch/arm/io.c >> +++ b/xen/arch/arm/io.c >> @@ -16,6 +16,7 @@ >>    * GNU General Public License for more details. >>    */ >>   +#include >>   #include >>   #include >>   #include >> @@ -107,6 +108,62 @@ static const struct mmio_handler >> *find_mmio_handler(struct domain *d, >>       return handler; >>   } >>   +#ifdef CONFIG_IOREQ_SERVER > > Can we just implement this function in ioreq.c and provide a stub when > !CONFIG_IOREQ_SERVER? Sure > > >> +static enum io_state try_fwd_ioserv(struct cpu_user_regs *regs, >> +                                    struct vcpu *v, mmio_info_t *info) >> +{ >> +    struct hvm_vcpu_io *vio = &v->arch.hvm.hvm_io; >> +    ioreq_t p = { >> +        .type = IOREQ_TYPE_COPY, >> +        .addr = info->gpa, >> +        .size = 1 << info->dabt.size, >> +        .count = 0, >> +        .dir = !info->dabt.write, >> +        .df = 0,         /* XXX: What's for? */ >> +        .data = get_user_reg(regs, info->dabt.reg), >> +        .state = STATE_IOREQ_READY, >> +    }; >> +    struct hvm_ioreq_server *s = NULL; >> +    enum io_state rc; >> + >> +    switch ( vio->io_req.state ) >> +    { >> +    case STATE_IOREQ_NONE: >> +        break; >> +    default: >> +        printk("d%u wrong state %u\n", v->domain->domain_id, >> +               vio->io_req.state); > > This will likely want to be a gprintk() or gdprintk() to avoid a guest > spamming Xen. ok > >> +        return IO_ABORT; >> +    } >> + >> +    s = hvm_select_ioreq_server(v->domain, &p); >> +    if ( !s ) >> +        return IO_UNHANDLED; >> + >> +    if ( !info->dabt.valid ) >> +    { >> +        printk("Valid bit not set\n"); > > Same here. However, I am not convinced this is a useful message to keep. ok > >> +        return IO_ABORT; >> +    } >> + >> +    vio->io_req = p; >> + >> +    rc = hvm_send_ioreq(s, &p, 0); >> +    if ( rc != IO_RETRY || v->domain->is_shutting_down ) >> +        vio->io_req.state = STATE_IOREQ_NONE; >> +    else if ( !hvm_ioreq_needs_completion(&vio->io_req) ) >> +        rc = IO_HANDLED; >> +    else >> +        vio->io_completion = HVMIO_mmio_completion; >> + >> +    /* XXX: Decide what to do */ > > We want to understand how IO_RETRY can happen on x86 first. With that, > we should be able to understand whether this can happen on Arm as well. Noted > > >> +    if ( rc == IO_RETRY ) >> +        rc = IO_HANDLED; >> + >> +    return rc; >> +} >> +#endif >> + >>   enum io_state try_handle_mmio(struct cpu_user_regs *regs, >>                                 const union hsr hsr, >>                                 paddr_t gpa) >> @@ -123,7 +180,15 @@ enum io_state try_handle_mmio(struct >> cpu_user_regs *regs, >>         handler = find_mmio_handler(v->domain, info.gpa); >>       if ( !handler ) >> -        return IO_UNHANDLED; >> +    { >> +        int rc = IO_UNHANDLED; >> + >> +#ifdef CONFIG_IOREQ_SERVER >> +        rc = try_fwd_ioserv(regs, v, &info); >> +#endif >> + >> +        return rc; >> +    } >>         /* All the instructions used on emulated MMIO region should >> be valid */ >>       if ( !dabt.valid ) >> diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c >> new file mode 100644 >> index 0000000..a9cc839 >> --- /dev/null >> +++ b/xen/arch/arm/ioreq.c >> @@ -0,0 +1,86 @@ >> +/* >> + * arm/ioreq.c: hardware virtual machine I/O emulation >> + * >> + * Copyright (c) 2019 Arm ltd. >> + * >> + * This program is free software; you can redistribute it and/or >> modify it >> + * under the terms and conditions of the GNU General Public License, >> + * version 2, as published by the Free Software Foundation. >> + * >> + * This program is distributed in the hope it will be useful, but >> WITHOUT >> + * ANY WARRANTY; without even the implied warranty of >> MERCHANTABILITY or >> + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public >> License for >> + * more details. >> + * >> + * You should have received a copy of the GNU General Public License >> along with >> + * this program; If not, see . >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#include >> +#include >> + >> +bool handle_mmio(void) > > The name of the function is pretty generic and can be confusing on Arm > (we already have a try_handle_mmio()). > > What is this function supposed to do? Agree, sounds confusing a bit. I assume it is supposed to complete Guest MMIO access after finishing emulation. Shall I rename it to something appropriate (maybe by adding ioreq prefix)? > > >> +{ >> +    struct vcpu *v = current; >> +    struct cpu_user_regs *regs = guest_cpu_user_regs(); >> +    const union hsr hsr = { .bits = regs->hsr }; >> +    const struct hsr_dabt dabt = hsr.dabt; >> +    /* Code is similar to handle_read */ >> +    uint8_t size = (1 << dabt.size) * 8; >> +    register_t r = v->arch.hvm.hvm_io.io_req.data; >> + >> +    /* We should only be here on Guest Data Abort */ >> +    ASSERT(dabt.ec == HSR_EC_DATA_ABORT_LOWER_EL); >> + >> +    /* We are done with the IO */ >> +    /* XXX: Is it the right place? */ >> +    v->arch.hvm.hvm_io.io_req.state = STATE_IOREQ_NONE; >> + >> +    /* XXX: Do we need to take care of write here ? */ >> +    if ( dabt.write ) >> +        return true; >> + >> +    /* >> +     * Sign extend if required. >> +     * Note that we expect the read handler to have zeroed the bits >> +     * outside the requested access size. >> +     */ >> +    if ( dabt.sign && (r & (1UL << (size - 1))) ) >> +    { >> +        /* >> +         * We are relying on register_t using the same as >> +         * an unsigned long in order to keep the 32-bit assembly >> +         * code smaller. >> +         */ >> +        BUILD_BUG_ON(sizeof(register_t) != sizeof(unsigned long)); >> +        r |= (~0UL) << size; >> +    } >> + >> +    set_user_reg(regs, dabt.reg, r); >> + >> +    return true; >> +} > > [...] > >> diff --git a/xen/common/memory.c b/xen/common/memory.c >> index 9283e5e..0000477 100644 >> --- a/xen/common/memory.c >> +++ b/xen/common/memory.c >> @@ -8,6 +8,7 @@ >>    */ >>     #include >> +#include >>   #include >>   #include >>   #include >> @@ -30,10 +31,6 @@ >>   #include >>   #include >>   -#ifdef CONFIG_IOREQ_SERVER >> -#include >> -#endif >> - > > Why do you remove something your just introduced? The reason I guarded that header is to make "xen/mm: Make x86's XENMEM_resource_ioreq_server handling common" (previous) patch buildable on Arm without arch IOREQ header added yet. I tried to make sure that the result after each patch was buildable to retain bisectability. As current patch adds Arm IOREQ specific bits (including header), that guard could be removed as not needed anymore. > >>   #ifdef CONFIG_X86 >>   #include >>   #endif >> diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h >> index 4e2f582..e060b0a 100644 >> --- a/xen/include/asm-arm/domain.h >> +++ b/xen/include/asm-arm/domain.h >> @@ -11,12 +11,64 @@ >>   #include >>   #include >>   #include >> +#include >> +#include >>   #include >>   #include >>   +struct hvm_ioreq_page { >> +    gfn_t gfn; >> +    struct page_info *page; >> +    void *va; >> +}; > > AFAICT all the structures/define you introduced here are used by the > code common. So it feels to me they should be defined in a common header. Make sense. Probably worth moving. I assume this also applies to x86 ones. > > >> + >> +struct hvm_ioreq_vcpu { >> +    struct list_head list_entry; >> +    struct vcpu      *vcpu; >> +    evtchn_port_t    ioreq_evtchn; >> +    bool             pending; >> +}; >> + >> +#define NR_IO_RANGE_TYPES (XEN_DMOP_IO_RANGE_PCI + 1) >> +#define MAX_NR_IO_RANGES  256 >> + >> +#define MAX_NR_IOREQ_SERVERS 8 >> +#define DEFAULT_IOSERVID 0 >> + >> +struct hvm_ioreq_server { >> +    struct domain          *target, *emulator; >> + >> +    /* Lock to serialize toolstack modifications */ >> +    spinlock_t             lock; >> + >> +    struct hvm_ioreq_page  ioreq; >> +    struct list_head       ioreq_vcpu_list; >> +    struct hvm_ioreq_page  bufioreq; >> + >> +    /* Lock to serialize access to buffered ioreq ring */ >> +    spinlock_t             bufioreq_lock; >> +    evtchn_port_t          bufioreq_evtchn; >> +    struct rangeset        *range[NR_IO_RANGE_TYPES]; >> +    bool                   enabled; >> +    uint8_t                bufioreq_handling; >> +}; >> + >>   struct hvm_domain >>   { >>       uint64_t              params[HVM_NR_PARAMS]; >> + >> +    /* Guest page range used for non-default ioreq servers */ >> +    struct { >> +        unsigned long base; >> +        unsigned long mask; >> +        unsigned long legacy_mask; /* indexed by HVM param number */ >> +    } ioreq_gfn; >> + >> +    /* Lock protects all other values in the sub-struct and the >> default */ >> +    struct { >> +        spinlock_t              lock; >> +        struct hvm_ioreq_server *server[MAX_NR_IOREQ_SERVERS]; >> +    } ioreq_server; >>   }; >>     #ifdef CONFIG_ARM_64 >> @@ -93,6 +145,29 @@ struct arch_domain >>   #endif >>   }  __cacheline_aligned; >>   +enum hvm_io_completion { >> +    HVMIO_no_completion, >> +    HVMIO_mmio_completion, >> +    HVMIO_pio_completion, >> +    HVMIO_realmode_completion >> +}; >> + >> +struct hvm_vcpu_io { >> +    /* I/O request in flight to device model. */ >> +    enum hvm_io_completion io_completion; >> +    ioreq_t                io_req; >> + >> +    /* >> +     * HVM emulation: >> +     *  Linear address @mmio_gla maps to MMIO physical frame >> @mmio_gpfn. >> +     *  The latter is known to be an MMIO frame (not RAM). >> +     *  This translation is only valid for accesses as per >> @mmio_access. >> +     */ >> +    struct npfec        mmio_access; >> +    unsigned long       mmio_gla; >> +    unsigned long       mmio_gpfn; >> +}; >> + >>   struct arch_vcpu >>   { >>       struct { >> @@ -206,6 +281,11 @@ struct arch_vcpu >>        */ >>       bool need_flush_to_ram; >>   +    struct hvm_vcpu >> +    { >> +        struct hvm_vcpu_io hvm_io; >> +    } hvm; >> + >>   }  __cacheline_aligned; >>     void vcpu_show_execution_state(struct vcpu *); >> diff --git a/xen/include/asm-arm/hvm/ioreq.h >> b/xen/include/asm-arm/hvm/ioreq.h >> new file mode 100644 >> index 0000000..83a560c >> --- /dev/null >> +++ b/xen/include/asm-arm/hvm/ioreq.h >> @@ -0,0 +1,103 @@ >> +/* >> + * hvm.h: Hardware virtual machine assist interface definitions. >> + * >> + * Copyright (c) 2016 Citrix Systems Inc. >> + * Copyright (c) 2019 Arm ltd. >> + * >> + * This program is free software; you can redistribute it and/or >> modify it >> + * under the terms and conditions of the GNU General Public License, >> + * version 2, as published by the Free Software Foundation. >> + * >> + * This program is distributed in the hope it will be useful, but >> WITHOUT >> + * ANY WARRANTY; without even the implied warranty of >> MERCHANTABILITY or >> + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public >> License for >> + * more details. >> + * >> + * You should have received a copy of the GNU General Public License >> along with >> + * this program; If not, see . >> + */ >> + >> +#ifndef __ASM_ARM_HVM_IOREQ_H__ >> +#define __ASM_ARM_HVM_IOREQ_H__ >> + >> +#include >> +#include >> + >> +#define has_vpci(d) (false) > > It feels to me this wants to be defined in vcpi.h. ok, will move. > > >> + >> +bool handle_mmio(void); >> + >> +static inline bool handle_pio(uint16_t port, unsigned int size, int >> dir) >> +{ >> +    /* XXX */ > > Can you expand this TODO? What do you expect to do? I didn't expect this to be called on Arm. Sorry, I am not sure l have an idea how to handle this properly. I would keep it unimplemented until a real reason. Will expand TODO. > > >> +    BUG(); >> +    return true; >> +} >> + >> +static inline paddr_t hvm_mmio_first_byte(const ioreq_t *p) >> +{ >> +    return p->addr; >> +} > > I understand that the x86 version is more complex as it check p->df. > However, aside reducing the complexity, I am not sure why we would > want to diverge it. > > After all, IOREQ is now meant to be a common feature. Well, no objections at all. Could you please clarify how could 'df' (Direction Flag?) be handled/used on Arm? I see that try_fwd_ioserv() always sets it 0. Or I need to just reuse x86's helpers as is, which (together with count = df = 0) will result in what we actually have here? > >> + >> +static inline paddr_t hvm_mmio_last_byte(const ioreq_t *p) >> +{ >> +    unsigned long size = p->size; >> + >> +    return p->addr + size - 1; >> +} > > Same. + > >> + >> +struct hvm_ioreq_server; > > Why do we need a forward declaration? I don't remember exactly, probably this way I temporally solved a build issue. Please let me recheck whether we could avoid using it. > > >> + >> +static inline int p2m_set_ioreq_server(struct domain *d, >> +                                       unsigned int flags, >> +                                       struct hvm_ioreq_server *s) >> +{ >> +    return -EOPNOTSUPP; >> +} > > This should be defined in p2m.h. But I am not even sure what it is > meant for. Can you expand it? ok, will move. In this series I tried to make as much IOREQ code common as possible and avoid complicating things, in order to achieve that a few stubs were added here. Please note, that I also considered splitting into arch parts. But some functions couldn't be split easily. This one is called from common hvm_destroy_ioreq_server() with flag being 0 (which will result in unmapping ioreq server from p2m type on x86). I could add a comment describing why this stub is present here. > > >> + >> +static inline void msix_write_completion(struct vcpu *v) >> +{ >> +} >> + >> +static inline void handle_realmode_completion(void) >> +{ >> +    ASSERT_UNREACHABLE(); >> +} > > realmode is very x86 specific. So I don't think this function should > be called from common code. It might be worth considering to split > handle_hvm_io_completion() is 2 parts: common and arch specific. I agree with you that realmode is x86 specific and looks not good in Arm header. I was thinking how to split handle_hvm_io_completion() gracefully but I failed find a good solution for that, so decided to add two stubs (msix_write_completion and handle_realmode_completion) on Arm. I could add a comment describing why they are here if appropriate. But if you think they shouldn't be called from the common code in any way, I will try to split it. > >> + >> +static inline void paging_mark_pfn_dirty(struct domain *d, pfn_t pfn) >> +{ >> +} > > This will want to be stubbed in asm-arm/paging.h. ok > > >> + >> +static inline void hvm_get_ioreq_server_range_type(struct domain *d, >> +                                                   ioreq_t *p, >> +                                                   uint8_t *type, >> +                                                   uint64_t *addr) >> +{ >> +    *type = (p->type == IOREQ_TYPE_PIO) ? >> +             XEN_DMOP_IO_RANGE_PORT : XEN_DMOP_IO_RANGE_MEMORY; >> +    *addr = p->addr; >> +} >> + >> +static inline void arch_hvm_ioreq_init(struct domain *d) >> +{ >> +} >> + >> +static inline void arch_hvm_ioreq_destroy(struct domain *d) >> +{ >> +} >> + >> +#define IOREQ_IO_HANDLED     IO_HANDLED >> +#define IOREQ_IO_UNHANDLED   IO_UNHANDLED >> +#define IOREQ_IO_RETRY       IO_RETRY >> + >> +#endif /* __ASM_X86_HVM_IOREQ_H__ */ > > s/X86/ARM/ ok > >> + >> +/* >> + * Local variables: >> + * mode: C >> + * c-file-style: "BSD" >> + * c-basic-offset: 4 >> + * tab-width: 4 >> + * indent-tabs-mode: nil >> + * End: >> + */ >> diff --git a/xen/include/asm-arm/mmio.h b/xen/include/asm-arm/mmio.h >> index 8dbfb27..7ab873c 100644 >> --- a/xen/include/asm-arm/mmio.h >> +++ b/xen/include/asm-arm/mmio.h >> @@ -37,6 +37,7 @@ enum io_state >>       IO_ABORT,       /* The IO was handled by the helper and led to >> an abort. */ >>       IO_HANDLED,     /* The IO was successfully handled by the >> helper. */ >>       IO_UNHANDLED,   /* The IO was not handled by the helper. */ >> +    IO_RETRY,       /* Retry the emulation for some reason */ >>   }; >>     typedef int (*mmio_read_t)(struct vcpu *v, mmio_info_t *info, >> diff --git a/xen/include/asm-arm/p2m.h b/xen/include/asm-arm/p2m.h >> index 5fdb6e8..5823f11 100644 >> --- a/xen/include/asm-arm/p2m.h >> +++ b/xen/include/asm-arm/p2m.h >> @@ -385,10 +385,11 @@ static inline int set_foreign_p2m_entry(struct >> domain *d, unsigned long gfn, >>                                           mfn_t mfn) >>   { >>       /* >> -     * NOTE: If this is implemented then proper reference counting of >> -     *       foreign entries will need to be implemented. >> +     * XXX: handle properly reference. It looks like the page may >> not always >> +     * belong to d. >>        */ >> -    return -EOPNOTSUPP; >> + >> +    return guest_physmap_add_entry(d, _gfn(gfn), mfn, 0, p2m_ram_rw); > > Treating foreign as p2m_ram_rw is more an hack that a real fix. I have > answered to this separately (see my answer on Stefano's e-mail), so we > can continue the conversation there. ok -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Wed Aug 05 19:45:38 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 19:45:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3PLh-00085W-Sm; Wed, 05 Aug 2020 19:45:17 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3PLg-00085R-Hp for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 19:45:16 +0000 X-Inumbo-ID: 8232f639-f170-492b-8925-a6896dabf402 Received: from mail-lj1-x243.google.com (unknown [2a00:1450:4864:20::243]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8232f639-f170-492b-8925-a6896dabf402; Wed, 05 Aug 2020 19:45:15 +0000 (UTC) Received: by mail-lj1-x243.google.com with SMTP id s16so33829955ljc.8 for ; Wed, 05 Aug 2020 12:45:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=jXGBKthtVoRPS37ymfF9cwHpxqndAf8UpmNF+uHu80w=; b=d3iuRYG7D0OqgVn3qvImKMbma7EhFkjB/cvRvFdniQLvHgdDil8ql5Cz+gR3Ot8jXW RByAt+q3dAQ4uN7Yn2EQy+48NKlnNdBUWlIcbqLEuaQMijI8e0VpKKwoyVHCTM5My17v DKEv8W4WI4kg/THnn3J3qMfXPZ2eUpjd044TPNpmlso+LJ7UhsekNOHdRoA9jVtkPu+p hcUCEWGhSC0n9laKxDJmNVCm8267kz15JsqiFcGgA7giAm+nI4ORj/P2RtJFLEbqAEGW SVdI9hwbtloCNgFFNIJbWyr0JV/KOcp3sV2I8Vy4WuP8IGNvyNUW3WaVlWIcR9BlIXZX 5wcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=jXGBKthtVoRPS37ymfF9cwHpxqndAf8UpmNF+uHu80w=; b=cDnSMikzf3NzVRzPH21haSKKuxCSDuSjQcniGHPfsyeO8T9uPfmEl9Jrrj2rRiKeiO Gwma8ReY8cB36wYi4Ikc+f4IebKu2++DpYvL8y9SyEKDoVnZ8lTpz6NDvy8qDG5oBM2R rQ3b2utqZFjFDTm4WYi7Yt0+8B6n1Z5kRp+IJ/ErabkVegfOA9NGri3x9E5l3xO3QL11 S/R4JxYFTLAL4yha3XYvrr6xQmS4Yi3i8NttUMzr41O3c00Z0nlQaibcV8w2aiiUEXc5 sDcPytDI3nPKprnQHp7VWkAoGfslcxQ4kcR8V4nFUw9cgbwKp/qvFN2EKCbDxLo0tx8s otbA== X-Gm-Message-State: AOAM530YO/PIIcDyMmfKEC7VVek6Ubl9ITFhIxDI8TUkk6ytbTjUiw4T vwdzJ6lisVJ22N2N/3t0Wus= X-Google-Smtp-Source: ABdhPJy+M/VpUSsI2AG6KIJdbcnHjoF/PsX9qeFnQLbp8rFEECt9g6pvloSeNNS6JNBez3Y+TfCbiw== X-Received: by 2002:a05:651c:1051:: with SMTP id x17mr2323222ljm.141.1596656714197; Wed, 05 Aug 2020 12:45:14 -0700 (PDT) Received: from [192.168.1.2] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id a19sm1553883lff.25.2020.08.05.12.45.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2020 12:45:13 -0700 (PDT) Subject: Re: [RFC PATCH V1 04/12] xen/arm: Introduce arch specific bits for IOREQ/DM features To: Stefano Stabellini , Jan Beulich References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-5-git-send-email-olekstysh@gmail.com> From: Oleksandr Message-ID: Date: Wed, 5 Aug 2020 22:45:07 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Julien Grall , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Julien Grall , xen-devel@lists.xenproject.org, Daniel De Graaf , Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 05.08.20 19:41, Stefano Stabellini wrote: Hi Stefano > On Wed, 5 Aug 2020, Jan Beulich wrote: >> On 05.08.2020 01:22, Stefano Stabellini wrote: >>> On Mon, 3 Aug 2020, Oleksandr Tyshchenko wrote: >>>> --- a/xen/include/asm-arm/p2m.h >>>> +++ b/xen/include/asm-arm/p2m.h >>>> @@ -385,10 +385,11 @@ static inline int set_foreign_p2m_entry(struct domain *d, unsigned long gfn, >>>> mfn_t mfn) >>>> { >>>> /* >>>> - * NOTE: If this is implemented then proper reference counting of >>>> - * foreign entries will need to be implemented. >>>> + * XXX: handle properly reference. It looks like the page may not always >>>> + * belong to d. >>> Just as a reference, and without taking away anything from the comment, >>> I think that QEMU is doing its own internal reference counting for these >>> mappings. >> Which of course in no way replaces the need to do proper ref counting >> in Xen. (Just FAOD, as I'm not sure why you've said what you've said.) > Given the state of the series, which is a RFC, I only meant to say that > the lack of refcounting shouldn't prevent things from working when using > QEMU. In the sense that if somebody wants to give it a try for an early > demo, they should be able to see it running without crashes. Yes, for the early demo it works fine, however I don't use Qemu. > > Of course, refcounting needs to be implemented. + -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Wed Aug 05 19:47:14 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 19:47:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3PNY-0008Bt-A9; Wed, 05 Aug 2020 19:47:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3PNW-0008BR-Om for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 19:47:10 +0000 X-Inumbo-ID: 3b640d2d-5b12-4bce-9284-5d8a4d769c7a Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3b640d2d-5b12-4bce-9284-5d8a4d769c7a; Wed, 05 Aug 2020 19:47:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=4qoPQ5Kv1njdbG3zNHkw4eJ0I4vsz8gw89PZwQCvMag=; b=EYBWby8Kjto4ks6rbID8Em72J Db6VvVSn6e8ZWccVjMNTusU+URxUepNqJX2CeWwzGEgVXRZYsVovVS1WscqhSzbqWM9pQWzxjswZM dskjE6JynstPt23SjJ0yD6jU5Z7RjrWCHRXck9FADXjXhz5XZKTCJ1XVfFobhpg8Qg8qs=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3PNO-0006H6-Fw; Wed, 05 Aug 2020 19:47:02 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k3PNO-00045J-4n; Wed, 05 Aug 2020 19:47:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k3PNO-00013Q-49; Wed, 05 Aug 2020 19:47:02 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 152480: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-armhf-armhf-xl-rtds:guest-start:fail:allowable qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking X-Osstest-Versions-This: qemuu=fd3cd581f9dcd11286daacaa5272e721c65aece8 X-Osstest-Versions-That: qemuu=9e3903136d9acde2fb2dd9e967ba928050a6cb4a From: osstest service owner Date: Wed, 05 Aug 2020 19:47:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152480 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/152480/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 12 guest-start fail REGR. vs. 151065 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail like 151065 test-armhf-armhf-libvirt 14 saverestore-support-check fail like 151065 test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 151065 test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail like 151065 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail like 151065 test-amd64-i386-xl-pvshim 12 guest-start fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass version targeted for testing: qemuu fd3cd581f9dcd11286daacaa5272e721c65aece8 baseline version: qemuu 9e3903136d9acde2fb2dd9e967ba928050a6cb4a Last test of basis 151065 2020-06-12 22:27:51 Z 53 days Failing since 151101 2020-06-14 08:32:51 Z 52 days 72 attempts Testing same since 152480 2020-08-05 02:25:42 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Aaron Lindsay Ahmed Karaman Alberto Garcia Aleksandar Markovic Aleksandar Markovic Alex Bennée Alex Richardson Alex Williamson Alexander Boettcher Alexander Bulekov Alexander Duyck Alexandre Mergnat Alexey Kardashevskiy Alexey Krasikov Alistair Francis Allan Peramaki Andrea Bolognani Andreas Schwab Andrew Andrew Jones Andrew Melnychenko Andrey Shinkevich Ani Sinha Anthony PERARD Antoine Damhet Ard Biesheuvel Artyom Tarasenko Atish Patra Aurelien Jarno Babu Moger BALATON Zoltan Basil Salman Basil Salman Beata Michalska Bin Meng Bin Meng Bruce Rogers Cameron Esfahani Catherine A. Frederick Cathy Zhang Chen Gang Chenyi Qiang Christian Borntraeger Christian Ehrhardt Christophe de Dinechin Chuan Zheng Cindy Lu Claudio Fontana Cleber Rosa Colin Xu Corey Minyard Cornelia Huck Cédric Le Goater Daniel P. Berrange Daniel P. Berrangé Daniele Buono David Carlier David Edmondson David Gibson David Hildenbrand Denis V. Lunev Derek Su Dongjiu Geng Dr. David Alan Gilbert Ed Robbins Edgar E. Iglesias Eduardo Habkost Emilio G. Cota Eric Auger Eric Blake Eric Farman Erik Smit erik-smit Evgeny Yakovlev fangying Farhan Ali Filip Bozuta Finn Thain Frank Chang Geoffrey McRae Gerd Hoffmann Giuseppe Musacchio Greg Kurz Guenter Roeck Gustavo Romero Halil Pasic Havard Skinnemoen Helge Deller Hogan Wang Hogan Wang Howard Spoelstra Huacai Chen Huacai Chen Ian Jiang Igor Mammedov Jan Kiszka Jan Kiszka Janne Grunau Janosch Frank Jason Andryuk Jason Wang Jay Zhou Jean-Christophe Dubois Jessica Clarke Jiaxun Yang Jingqi Liu John Paul Adrian Glaubitz John Snow Jon Doron Joseph Myers Josh DuBois Josh DuBois Josh Kunz Juan Quintela Julio Faracco Kaige Li Keqian Zhu Kevin Wolf Klaus Jensen Klaus Jensen KONRAD Frederic Laszlo Ersek Laurent Vivier Laurent Vivier Leif Lindholm Leonid Bloch Leonid Bloch Li Feng Li Qiang Li Qiang Liao Pingfang lichun Lijun Pan Like Xu Lingfeng Yang Lingshan zhu Liran Alon Liu Yi L LIU Zhiwei Luc Michel Lukas Straub Luwei Kang Maciej S. Szmigiero Magnus Damm Mao Zhongyi Marc-André Lureau Marcelo Tosatti Marek Marczykowski-Górecki Mario Smarduch Mark Cave-Ayland Markus Armbruster Masahiro Yamada Matus Kysel Mauro Matteo Cascella Max Filippov Max Reitz Maxim Levitsky Maxime Coquelin Menno Lageman Michael Rolnik Michael Roth Michael S. Tsirkin Michael Tokarev Michal Privoznik Michele Denber Niek Linnenbank Nir Soffer Nir Soffer Olaf Hering Pan Nengyuan Paolo Bonzini Paul Durrant Paul Zimmerman Pavel Dovgalyuk Pavel Dovgalyuk Peter Collingbourne Peter Krempa Peter Maydell Peter Turschmid Peter Xu Philippe Mathieu-Daude Philippe Mathieu-Daudé Philippe Mathieu-Daudé Prasad J Pandit Radoslaw Biernacki Raphael Norwitz Reza Arbab Richard Henderson Richard W.M. Jones Riku Voipio Robert Foley Roman Bolshakov Roman Kagan Roman Kagan Sai Pavan Boddu Sarah Harris Sebastian Rasmussen Sergio Lopez Shameer Kolothum Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Weil Sven Schnelle Tao Xu Thomas Huth Thomas Huth Tiwei Bie Tong Ho Viktor Mihajlovski Vitaly Kuznetsov Vivek Goyal Vladimir Sementsov-Ogievskiy Volker Rümelin WangBowen Wei Huang Wei Wang Wentong Wu Xiaoyao Li Xie Yongji Yi Wang Ying Fang Yoshinori Sato Yuri Benditovich Zhang Chen Zheng Chuan Zong Li jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 9e3903136d..fd3cd581f9 fd3cd581f9dcd11286daacaa5272e721c65aece8 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Wed Aug 05 19:47:55 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 19:47:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3POF-0008IK-O1; Wed, 05 Aug 2020 19:47:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3POE-0008IC-HZ for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 19:47:54 +0000 X-Inumbo-ID: 7a255ee2-1706-4ec3-ab00-a1104ec5ec9b Received: from mail-lj1-x241.google.com (unknown [2a00:1450:4864:20::241]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7a255ee2-1706-4ec3-ab00-a1104ec5ec9b; Wed, 05 Aug 2020 19:47:53 +0000 (UTC) Received: by mail-lj1-x241.google.com with SMTP id w25so13624032ljo.12 for ; Wed, 05 Aug 2020 12:47:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=/yzQDCFHb8N/iu1mEclfX2vLmhK7Prxz29nas03P9gc=; b=tLK28cuHfe+Jku4cyAekXRvs/I7yBznKrFAZh7SlzogAEJkxFAx4Fxd4TwnOHhiuoX fOnV/8cspOuZyVIQBZHV9q5xqSFidHRE8LdEIlyVua4LV8WTOQPzTIz2PGePf++eRWcB Jl3HGYSceOo9q/Ky+XM0Laswh9pORc61ft+SBnjss2bInDZ/JBvj1kt3hLD+xnoBF+6q BhRLALuZWj8+1OAjG/aqTyIsmGQ9JFHlQnioWtl0gQPVnAZu5gSVmxGSY1BUafhMrvPc nZh1up4/DuZgdXXYAe6BtgObaf+54+17sHjEtYHB21B3vPAmh0MIUuztJdxrpkz466fI DPzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=/yzQDCFHb8N/iu1mEclfX2vLmhK7Prxz29nas03P9gc=; b=r598zQ10rIwXcOztKYdaj0Sn/8da8riBOcV665x5vCvJlY55cNj9EUyyWoq0Aq5QXH PNmJmvR1aBnsJFqaNGbrUrEX4QDdxPymoGKPB3hux4gttS8kD4UpbopHcs4i7N9Qn1bf 9mOuRrx7upXF7Uj3klXIYXoCdnG/lwLXGKdk7ydm3CFDKzzAU5NsUZstqh9npzX+FJGB /65/r7CFZW/DSfSkH9msaNh1lMaAAx/muzQPVHOS4AO8PTfnPaFac0fmaViz0QfX3YrN NhOz3KLuildFBChXOt31VUd9EqKlJnSpSZIsj+Mmh9HV8iUa62RqFLL5K+uNxLL9Nm5l X/Eg== X-Gm-Message-State: AOAM533vO80dgZHadGIznuonWFQeK0sVTsBc4M5q0/XnHz5b3LeT6Nph x3kEPP6OiB+7duCxd0+01Yk= X-Google-Smtp-Source: ABdhPJz+jmjFLhuKpEPWc+xVepbfummzg7jPFn7vK7BVEAxGp6mDVWBf39u6y6Wb4D0C3846UTaNdQ== X-Received: by 2002:a2e:8612:: with SMTP id a18mr2249468lji.149.1596656872510; Wed, 05 Aug 2020 12:47:52 -0700 (PDT) Received: from [192.168.1.2] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id a9sm1267009ljb.57.2020.08.05.12.47.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2020 12:47:52 -0700 (PDT) Subject: Re: [RFC PATCH V1 04/12] xen/arm: Introduce arch specific bits for IOREQ/DM features To: Jan Beulich , xen-devel@lists.xenproject.org References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-5-git-send-email-olekstysh@gmail.com> From: Oleksandr Message-ID: Date: Wed, 5 Aug 2020 22:47:51 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Julien Grall , Daniel De Graaf , Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 05.08.20 19:13, Jan Beulich wrote: Hi, Jan > On 03.08.2020 20:21, Oleksandr Tyshchenko wrote: >> --- a/xen/include/xsm/dummy.h >> +++ b/xen/include/xsm/dummy.h >> @@ -713,14 +713,14 @@ static XSM_INLINE int xsm_pmu_op (XSM_DEFAULT_ARG struct domain *d, unsigned int >> } >> } >> >> +#endif /* CONFIG_X86 */ >> + >> static XSM_INLINE int xsm_dm_op(XSM_DEFAULT_ARG struct domain *d) >> { >> XSM_ASSERT_ACTION(XSM_DM_PRIV); >> return xsm_default_action(action, current->domain, d); >> } >> >> -#endif /* CONFIG_X86 */ >> - >> #ifdef CONFIG_ARGO >> static XSM_INLINE int xsm_argo_enable(const struct domain *d) >> { >> diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h >> index a80bcf3..2a9b39d 100644 >> --- a/xen/include/xsm/xsm.h >> +++ b/xen/include/xsm/xsm.h >> @@ -177,8 +177,8 @@ struct xsm_operations { >> int (*ioport_permission) (struct domain *d, uint32_t s, uint32_t e, uint8_t allow); >> int (*ioport_mapping) (struct domain *d, uint32_t s, uint32_t e, uint8_t allow); >> int (*pmu_op) (struct domain *d, unsigned int op); >> - int (*dm_op) (struct domain *d); >> #endif >> + int (*dm_op) (struct domain *d); >> int (*xen_version) (uint32_t cmd); >> int (*domain_resource_map) (struct domain *d); >> #ifdef CONFIG_ARGO >> @@ -688,13 +688,13 @@ static inline int xsm_pmu_op (xsm_default_t def, struct domain *d, unsigned int >> return xsm_ops->pmu_op(d, op); >> } >> >> +#endif /* CONFIG_X86 */ >> + >> static inline int xsm_dm_op(xsm_default_t def, struct domain *d) >> { >> return xsm_ops->dm_op(d); >> } >> >> -#endif /* CONFIG_X86 */ >> - >> static inline int xsm_xen_version (xsm_default_t def, uint32_t op) >> { >> return xsm_ops->xen_version(op); >> diff --git a/xen/xsm/dummy.c b/xen/xsm/dummy.c >> index d4cce68..e3afd06 100644 >> --- a/xen/xsm/dummy.c >> +++ b/xen/xsm/dummy.c >> @@ -148,8 +148,8 @@ void __init xsm_fixup_ops (struct xsm_operations *ops) >> set_to_dummy_if_null(ops, ioport_permission); >> set_to_dummy_if_null(ops, ioport_mapping); >> set_to_dummy_if_null(ops, pmu_op); >> - set_to_dummy_if_null(ops, dm_op); >> #endif >> + set_to_dummy_if_null(ops, dm_op); >> set_to_dummy_if_null(ops, xen_version); >> set_to_dummy_if_null(ops, domain_resource_map); >> #ifdef CONFIG_ARGO >> diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c >> index a314bf8..645192a 100644 >> --- a/xen/xsm/flask/hooks.c >> +++ b/xen/xsm/flask/hooks.c >> @@ -1662,14 +1662,13 @@ static int flask_pmu_op (struct domain *d, unsigned int op) >> return -EPERM; >> } >> } >> +#endif /* CONFIG_X86 */ >> >> static int flask_dm_op(struct domain *d) >> { >> return current_has_perm(d, SECCLASS_HVM, HVM__DM); >> } >> >> -#endif /* CONFIG_X86 */ >> - >> static int flask_xen_version (uint32_t op) >> { >> u32 dsid = domain_sid(current->domain); >> @@ -1872,8 +1871,8 @@ static struct xsm_operations flask_ops = { >> .ioport_permission = flask_ioport_permission, >> .ioport_mapping = flask_ioport_mapping, >> .pmu_op = flask_pmu_op, >> - .dm_op = flask_dm_op, >> #endif >> + .dm_op = flask_dm_op, >> .xen_version = flask_xen_version, >> .domain_resource_map = flask_domain_resource_map, >> #ifdef CONFIG_ARGO > All of this looks to belong into patch 2? Good point. Will move. -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Wed Aug 05 20:21:48 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 20:21:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Put-0003H5-Fd; Wed, 05 Aug 2020 20:21:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Pus-0003Gf-If for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 20:21:38 +0000 X-Inumbo-ID: a8351068-c87f-46f0-a77d-371101dd6f09 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a8351068-c87f-46f0-a77d-371101dd6f09; Wed, 05 Aug 2020 20:21:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Jf6Krz4y7GvmYPLwU5KWYkDngGRPvt4PJrJtLCD3LZQ=; b=UqpQI6DLV2ARLnw+qFir6pU4j jh5Z7gJfYOl+Zx52cYmhNsJAYWjzRKHC9EpJLQPzklkeqFEXzHkY+OlaJtGn9LvjuOPJasyxIQyw1 0NoNZbIPzrr9KL6GsoL72WjQhMoWppzKAqnOP+G5HtlybKXHnG036y32tO36SRTyRbZeI=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Pul-00076p-Ns; Wed, 05 Aug 2020 20:21:31 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k3Pul-0005zu-Cj; Wed, 05 Aug 2020 20:21:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k3Pul-0003A2-C1; Wed, 05 Aug 2020 20:21:31 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 152494: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=b2bc1e714462c6cc222e3bbc38d87b039b4fa405 X-Osstest-Versions-That: xen=e58a71274c65e7547fc2e917f051c5c04e2820e2 From: osstest service owner Date: Wed, 05 Aug 2020 20:21:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152494 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/152494/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass version targeted for testing: xen b2bc1e714462c6cc222e3bbc38d87b039b4fa405 baseline version: xen e58a71274c65e7547fc2e917f051c5c04e2820e2 Last test of basis 152487 2020-08-05 09:00:51 Z 0 days Testing same since 152494 2020-08-05 17:01:20 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git e58a71274c..b2bc1e7144 b2bc1e714462c6cc222e3bbc38d87b039b4fa405 -> smoke From xen-devel-bounces@lists.xenproject.org Wed Aug 05 20:35:52 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 20:35:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Q8V-0004Ga-Kx; Wed, 05 Aug 2020 20:35:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Q8U-0004GV-GG for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 20:35:42 +0000 X-Inumbo-ID: e03fe94c-19ab-41fd-b05c-461ace6b62c7 Received: from mail-lj1-x242.google.com (unknown [2a00:1450:4864:20::242]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e03fe94c-19ab-41fd-b05c-461ace6b62c7; Wed, 05 Aug 2020 20:35:41 +0000 (UTC) Received: by mail-lj1-x242.google.com with SMTP id s16so33982682ljc.8 for ; Wed, 05 Aug 2020 13:35:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=1YXgAcf/MkURvy5fQI+D8jfLLLAeCGsmKnn68DUsZ1c=; b=E6PIY3OCuHOcBzxx7Kg6w0BCxIbeSkFhMiVY4qwom/Budu6VBpBCBmrw2p7zD1l9Dg lmnqyiRsz4FvQus93cZ0/S6YTjA/B0Cn+derj+bhH/xutLJbzGU+D71Lynee60ZNFb/Q uX+/P1BXBpYvkCwXCNOKvbmGqTU3sNzmS1bHGHEIuiZ9xEdmMbmf5lH88LbSg8QyMbPB ySlfXwI54JZ78GqyY+yb8YVdvPt4ui+yQeKPsq1El9mgnIJhhQ8F6jAALQghPna8hnUX XORpMsi/LC8ILrK04AsSSJO0EpByOTi/qYksB8BWowXRISYrnUMpc7tlkHnGlT3qH9+o /mwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=1YXgAcf/MkURvy5fQI+D8jfLLLAeCGsmKnn68DUsZ1c=; b=Pr0Tdtm3w9F1LyJ9+Ubn0sGQZJte8NAO9wkFfBZQXUwwavLzG7OtVWmyIoev/uUNM0 jvj8Mysl0fpIRdZJS/3SfFd+Uk4xajrqR4YnLsthdHXvKEof1eCtUCHfjPBXfBFNau6k Ghi4wgwUwmwyLL/np5BUnB41G/qEyXlGh5me2BRARPE5W1hU1bG3wlJAMOEc2tnfeguO lX9h1PmxWniWfjq4qzYMeE+MOBrrkcTBsPPqTE+YFNW8tgmpysTZUUaKyxCWEKxzifSX 5/caupJ69b2qCqGoLUyA3Kb8sxMkIyDtlTduttskwRgfhlCaXx5wKeIbem6+6LfN2zNs fubA== X-Gm-Message-State: AOAM531mvmbqNivSjcovQJnp477tWFbNXOEduL4bagUe0JXcDOi5a4ta 7gOLinsP7WpWkwUjhahcdRE= X-Google-Smtp-Source: ABdhPJwjcNp5wjrYke3++cmCZ8Ebmm7LuoH5Cm7DU8h25kreAbFXeyvXJkM1+1yG0PFE4dufJ2Stdw== X-Received: by 2002:a2e:a49a:: with SMTP id h26mr2093549lji.168.1596659740380; Wed, 05 Aug 2020 13:35:40 -0700 (PDT) Received: from [192.168.1.2] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id y21sm1329036ljk.129.2020.08.05.13.35.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2020 13:35:39 -0700 (PDT) Subject: Re: [RFC PATCH V1 11/12] libxl: Insert "dma-coherent" property into virtio-mmio device node To: Stefano Stabellini References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-12-git-send-email-olekstysh@gmail.com> From: Oleksandr Message-ID: <5ed8d80a-da71-3f54-7e80-9f93bd285e4d@gmail.com> Date: Wed, 5 Aug 2020 23:35:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Julien Grall , Wei Liu , Ian Jackson , Oleksandr Tyshchenko , Anthony PERARD , xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 05.08.20 02:23, Stefano Stabellini wrote: Hi Stefano > On Mon, 3 Aug 2020, Oleksandr Tyshchenko wrote: >> From: Oleksandr Tyshchenko >> >> Without "dma-coherent" property present in virtio-mmio device node, >> guest assumes it is non-coherent and making non-cacheable accesses >> to the vring when the DMA API is used for vring operations. >> But virtio-mmio device which runs at the host size is making cacheable >> accesses to vring. This all may result in a loss of coherency between >> the guest and host. >> >> With this patch we can avoid modifying guest at all, otherwise we >> need to force VirtIO framework to not use DMA API for vring operations. >> >> Signed-off-by: Oleksandr Tyshchenko > This should also be folded in the first patch for libxl Agree, will do -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Wed Aug 05 20:52:06 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 20:52:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3QNz-0005yD-11; Wed, 05 Aug 2020 20:51:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3QNx-0005y8-QU for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 20:51:41 +0000 X-Inumbo-ID: d2c1a28e-392c-4c1f-92a4-bad31ad5abc6 Received: from mail-lf1-x141.google.com (unknown [2a00:1450:4864:20::141]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d2c1a28e-392c-4c1f-92a4-bad31ad5abc6; Wed, 05 Aug 2020 20:51:41 +0000 (UTC) Received: by mail-lf1-x141.google.com with SMTP id j22so19095944lfm.2 for ; Wed, 05 Aug 2020 13:51:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=uZbgQQ59cM99l8le6g15/UCmLOmI4BVnDuMGPUAYHsA=; b=VCVTNJpGKTivoLI2ScxDezNtyRJY7Mhf8ZoCerDEeA8JFO9UijVOLhc2c6jYi5woC3 RnfMZDNcMANu99KckoqrCpftkM9OAWQ4xrxcIpXP8G4i0aF753tPqcM+jmOGUy/KeXEH 5K1FCqfVPNA0G1BjwIxQBcuh/2oXiK7Y84ICj8rtLYtmgFl3GUguMVwjL9XR+hZVKO4X iLP3WZn2qa/34w7nTdHyQIrPrqJF7dEC0Tmv8giVKy5WsF/VQdKYIcsXuI1xH0TA40I8 wYxGEdu2Jfn9AEI64gNlSL2wcP2gMZE4UVPUf2PVmIGbAPKXdGvoPflU3ENl9IPCL62c Z6DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=uZbgQQ59cM99l8le6g15/UCmLOmI4BVnDuMGPUAYHsA=; b=Bk9WZDC1pt4jiPiDDRevyak7emLnfz1Oa2ZQdWRWDSE8eYNilm4xTJxSGMfS1zEtxS 9v7BV5863/ObJEui1wZRld4HU50FUWx69dnPWUEkWBFTtG7yNR9Newkxinfc12nekU6N D8afY0yxQa7dc0ILPrApvZIoCQ8YjGlmMKGf2x8pjDMAT2wYm1y/UnbDXuv62DU223nK Ihx75ANgUrbJ3DGpPlj6/JDqnCZOcaLQk1xqS4UAUy3R1UGqt6ZqrlA0456W9r5XPL+h lPiyJJj8aW+Bvpad/QHot7QmNFrWbYPFQNdkfC7dWt6X9Z/m4LiGTzdkQPNmhqcUnEvq JlKg== X-Gm-Message-State: AOAM533nn7NMW091DlV3GcbdyVX1L6lRqDZkqFTnx7EPvny8Kk2Qcoez V2Vm5VjIvDqIg7C+bCqysuc= X-Google-Smtp-Source: ABdhPJxMRvEbOqGUs4Xx38dzWPZ0NmuP9hkFEQT5ZKjnnFwPM5kSdG3pgneKGXGhvvOTaiBRW8i6Tw== X-Received: by 2002:a19:c752:: with SMTP id x79mr2273891lff.197.1596660699904; Wed, 05 Aug 2020 13:51:39 -0700 (PDT) Received: from [192.168.1.2] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id g6sm1610504lfr.51.2020.08.05.13.51.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2020 13:51:39 -0700 (PDT) Subject: Re: [RFC PATCH V1 09/12] libxl: Handle virtio-mmio irq in more correct way To: Stefano Stabellini References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-10-git-send-email-olekstysh@gmail.com> From: Oleksandr Message-ID: <2163c32b-6fcf-b28b-a357-793666b20a35@gmail.com> Date: Wed, 5 Aug 2020 23:51:33 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Julien Grall , Wei Liu , Ian Jackson , Oleksandr Tyshchenko , Anthony PERARD , xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 05.08.20 02:22, Stefano Stabellini wrote: Hi Stefano > On Mon, 3 Aug 2020, Oleksandr Tyshchenko wrote: >> From: Oleksandr Tyshchenko >> >> This patch makes possible to use device passthrough again. >> >> Signed-off-by: Oleksandr Tyshchenko >> --- >> tools/libxl/libxl_arm.c | 33 +++++++++++++++++++++++---------- >> 1 file changed, 23 insertions(+), 10 deletions(-) >> >> diff --git a/tools/libxl/libxl_arm.c b/tools/libxl/libxl_arm.c >> index 620b499..4f748e3 100644 >> --- a/tools/libxl/libxl_arm.c >> +++ b/tools/libxl/libxl_arm.c >> @@ -9,6 +9,10 @@ >> #include >> #include >> >> +#define GUEST_VIRTIO_MMIO_BASE xen_mk_ullong(0x02000000) >> +#define GUEST_VIRTIO_MMIO_SIZE xen_mk_ullong(0x200) >> +#define GUEST_VIRTIO_MMIO_SPI 33 > They should be in xen/include/public/arch-arm.h ok > > Is one interrupt enough if there are multiple virtio devices? Is it one > interrupt for all virtio devices, or one for each device?   One interrupt for each virtio device. I experimented with current series and assigned 4 disk partitions to the guest. This resulted in 4 separate device-tree nodes, and each node had individual SPI and MMIO range. > > Of course this patch should be folded in the patch to add virtio support > to libxl. ok -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Wed Aug 05 21:12:31 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 21:12:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Qhz-0007km-OE; Wed, 05 Aug 2020 21:12:23 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Qhy-0007kh-S5 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 21:12:22 +0000 X-Inumbo-ID: 12ad7f02-45c1-458a-ab80-d640e031215a Received: from mail-lj1-x244.google.com (unknown [2a00:1450:4864:20::244]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 12ad7f02-45c1-458a-ab80-d640e031215a; Wed, 05 Aug 2020 21:12:21 +0000 (UTC) Received: by mail-lj1-x244.google.com with SMTP id h19so49333760ljg.13 for ; Wed, 05 Aug 2020 14:12:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=WG+eSyDZgT7X7JvLlS9jnjRsripYVIDIOyCobhZHaN0=; b=BLhoPDr17mhrDoy3hdmIGjlv7JTj6GDWI9XwKils9jTFE7CFe4TxX03xvYPeffDlFn DyqtSRUkZkKEieiOC7R9uoK8cIMYsU3ihJGYOCgpiSeAIObzjLGdUPr9lyfd74xu4dZR 52kd8GhHli08WhC1ndNVw3gzxLGPkH3eHoICRGvxRDmIzrAVoUldQc7C7hao31Q2h0qD u3/jqSij+d+/zgLDciCn8MlShST9M/O8VxCKkKsbNnRXFQkbWpLCx/FUZ6iMKtWeeJhD TQUFXqJjaYSKRMbyBP57RQdi6zWMTYNF+4LztQEKVgaOWAkUKLaPsKNa90A+3N8F5+Ls s9OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=WG+eSyDZgT7X7JvLlS9jnjRsripYVIDIOyCobhZHaN0=; b=Tm1syiQrZI98xixhUwrC8U4zZd4edket+UtVbi1NixdychrHBwqMJpqPFwB4WponmE CP8NhK3OQLzZnrJ3FDDPN9HeD6qk5eGeVon70EZMhQsKIgqcoJVppJqcM8z0jKnxx5BO t6TarUEAHhCFDVp3B/lQg/SAu2wl3/f2lC+7zj3BSHDGPr3Cv7RSq8FnDEFEuVtEZWrf A8GxQdNDQbw8NxlijArkptwo4qPX952P9YBFHbrKiSnL79Dve5VaoV2itPVygVuLu5YY xLdeK4G4muzlOM3jmb2lB+Gn5QtU9q17yOxHW3CxY3Q0e1WwIJOzRCtM6yrowxlzYHYj 6swA== X-Gm-Message-State: AOAM530T7YDDU8d4ePPaR0KCsqcUgMi05ep/xrDKemVw4xbu0F3p8sKn nrFMWj8iecSffT8vP0u3SX4= X-Google-Smtp-Source: ABdhPJy0S97ZqouHeaRMzu9h44cY0559W7s2Ty8p06FQ3jEHQIRsU6cWyYJ9gkGNM4heaZjqcULjUg== X-Received: by 2002:a2e:9696:: with SMTP id q22mr2290165lji.11.1596661940493; Wed, 05 Aug 2020 14:12:20 -0700 (PDT) Received: from [192.168.1.2] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id j2sm1365043ljb.98.2020.08.05.14.12.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2020 14:12:20 -0700 (PDT) Subject: Re: [RFC PATCH V1 10/12] libxl: Add support for virtio-disk configuration To: Stefano Stabellini References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-11-git-send-email-olekstysh@gmail.com> From: Oleksandr Message-ID: <19fd2966-6e54-4f68-7f37-b2d8bb910d93@gmail.com> Date: Thu, 6 Aug 2020 00:12:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Julien Grall , Wei Liu , Ian Jackson , Oleksandr Tyshchenko , Anthony PERARD , xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 05.08.20 02:23, Stefano Stabellini wrote: Hi Stefano > On Mon, 3 Aug 2020, Oleksandr Tyshchenko wrote: >> From: Oleksandr Tyshchenko >> >> This patch adds basic support for configuring and assisting virtio-disk >> backend (emualator) which is intended to run out of Qemu and could be run >> in any domain. >> >> Xenstore was chosen as a communication interface for the emulator running >> in non-toolstack domain to be able to get configuration either by reading >> Xenstore directly or by receiving command line parameters (an updated 'xl devd' >> running in the same domain would read Xenstore beforehand and call backend >> executable with the required arguments). >> >> An example of domain configuration (two disks are assigned to the guest, >> the latter is in readonly mode): >> >> vdisk = [ 'backend=DomD, disks=rw:/dev/mmcblk0p3;ro:/dev/mmcblk1p3' ] >> >> Where per-disk Xenstore entries are: >> - filename and readonly flag (configured via "vdisk" property) >> - base and irq (allocated dynamically) >> >> Besides handling 'visible' params described in configuration file, >> patch also allocates virtio-mmio specific ones for each device and >> writes them into Xenstore. virtio-mmio params (irq and base) are >> unique per guest domain, they allocated at the domain creation time >> and passed through to the emulator. Each VirtIO device has at least >> one pair of these params. >> >> TODO: >> 1. An extra "virtio" property could be removed. >> 2. Update documentation. >> >> Signed-off-by: Oleksandr Tyshchenko >> --- >> tools/libxl/Makefile | 4 +- >> tools/libxl/libxl_arm.c | 63 +++++++++++++++---- >> tools/libxl/libxl_create.c | 1 + >> tools/libxl/libxl_internal.h | 1 + >> tools/libxl/libxl_types.idl | 15 +++++ >> tools/libxl/libxl_types_internal.idl | 1 + >> tools/libxl/libxl_virtio_disk.c | 109 +++++++++++++++++++++++++++++++++ >> tools/xl/Makefile | 2 +- >> tools/xl/xl.h | 3 + >> tools/xl/xl_cmdtable.c | 15 +++++ >> tools/xl/xl_parse.c | 115 +++++++++++++++++++++++++++++++++++ >> tools/xl/xl_virtio_disk.c | 46 ++++++++++++++ >> 12 files changed, 360 insertions(+), 15 deletions(-) >> create mode 100644 tools/libxl/libxl_virtio_disk.c >> create mode 100644 tools/xl/xl_virtio_disk.c >> >> diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile >> index 38cd43a..df94b13 100644 >> --- a/tools/libxl/Makefile >> +++ b/tools/libxl/Makefile >> @@ -141,7 +141,9 @@ LIBXL_OBJS = flexarray.o libxl.o libxl_create.o libxl_dm.o libxl_pci.o \ >> libxl_vtpm.o libxl_nic.o libxl_disk.o libxl_console.o \ >> libxl_cpupool.o libxl_mem.o libxl_sched.o libxl_tmem.o \ >> libxl_9pfs.o libxl_domain.o libxl_vdispl.o \ >> - libxl_pvcalls.o libxl_vsnd.o libxl_vkb.o $(LIBXL_OBJS-y) >> + libxl_pvcalls.o libxl_vsnd.o libxl_vkb.o \ >> + libxl_virtio_disk.o $(LIBXL_OBJS-y) >> + >> LIBXL_OBJS += libxl_genid.o >> LIBXL_OBJS += _libxl_types.o libxl_flask.o _libxl_types_internal.o >> >> diff --git a/tools/libxl/libxl_arm.c b/tools/libxl/libxl_arm.c >> index 4f748e3..469a8b0 100644 >> --- a/tools/libxl/libxl_arm.c >> +++ b/tools/libxl/libxl_arm.c >> @@ -13,6 +13,12 @@ >> #define GUEST_VIRTIO_MMIO_SIZE xen_mk_ullong(0x200) >> #define GUEST_VIRTIO_MMIO_SPI 33 >> >> +#ifndef container_of >> +#define container_of(ptr, type, member) ({ \ >> + typeof( ((type *)0)->member ) *__mptr = (ptr); \ >> + (type *)( (char *)__mptr - offsetof(type,member) );}) >> +#endif >> + >> static const char *gicv_to_string(libxl_gic_version gic_version) >> { >> switch (gic_version) { >> @@ -44,14 +50,32 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, >> vuart_enabled = true; >> } >> >> - /* >> - * XXX: Handle properly virtio >> - * A proper solution would be the toolstack to allocate the interrupts >> - * used by each virtio backend and let the backend now which one is used >> - */ >> if (libxl_defbool_val(d_config->b_info.arch_arm.virtio)) { >> - nr_spis += (GUEST_VIRTIO_MMIO_SPI - 32) + 1; >> + uint64_t virtio_base; >> + libxl_device_virtio_disk *virtio_disk; >> + >> + virtio_base = GUEST_VIRTIO_MMIO_BASE; >> virtio_irq = GUEST_VIRTIO_MMIO_SPI; >> + >> + if (!d_config->num_virtio_disks) { >> + LOG(ERROR, "Virtio is enabled, but no Virtio devices present\n"); >> + return ERROR_FAIL; >> + } >> + virtio_disk = &d_config->virtio_disks[0]; >> + >> + for (i = 0; i < virtio_disk->num_disks; i++) { >> + virtio_disk->disks[i].base = virtio_base; >> + virtio_disk->disks[i].irq = virtio_irq; >> + >> + LOG(DEBUG, "Allocate Virtio MMIO params: IRQ %u BASE 0x%"PRIx64, >> + virtio_irq, virtio_base); >> + >> + virtio_irq ++; >> + virtio_base += GUEST_VIRTIO_MMIO_SIZE; >> + } >> + virtio_irq --; >> + >> + nr_spis += (virtio_irq - 32) + 1; > It looks like it is an interrupt per device, which could lead to quite a > few of them being allocated. Yes. > So, if we end up allocating > let's say 6 virtio interrupts for a domain, the chance of a clash with a > physical interrupt of a passthrough device is real. Yes. > > I am not entirely sure how to solve it, but these are a few ideas: > - choosing virtio interrupts that are less likely to conflict (maybe > > 1000) > - make the virtio irq (optionally) configurable so that a user could > override the default irq and specify one that doesn't conflict > - implementing support for virq != pirq (even the xl interface doesn't > allow to specify the virq number for passthrough devices, see "irqs") Good ideas. The first requires minimum effort. Couldn't we choose virtio interrupt to allocate after making sure it is absent in guest "irqs" (d_config->b_info.irqs[i]), I mean to find some holes? -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Wed Aug 05 22:13:00 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2020 22:13:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3ReF-0004Qx-Cj; Wed, 05 Aug 2020 22:12:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3ReD-0004Qs-RY for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 22:12:33 +0000 X-Inumbo-ID: d0410a6e-f0e0-4738-b0a6-31b8b9e5adb7 Received: from mail-lj1-x244.google.com (unknown [2a00:1450:4864:20::244]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d0410a6e-f0e0-4738-b0a6-31b8b9e5adb7; Wed, 05 Aug 2020 22:12:32 +0000 (UTC) Received: by mail-lj1-x244.google.com with SMTP id w25so14031191ljo.12 for ; Wed, 05 Aug 2020 15:12:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=0J9dQqXxpUpqjksZBdycZsJ8XR9I4aZNdsZm+8ZNLUo=; b=XsUqtkA8P2Kf6TMHxNulA53u5KJ5YjuoJc6zFKSqGk44gwQdKhSYDgDq94W8NZuCIb JeHg6VHJmfsv+ewTeYEakT/Z+xh4F7OwJ+uNs7OeyUdtR77Q4/q8HVkdStsB5Wu4FM2N XE8oiax6Mr/mrn++D8Kz4xDHgiu6efvQwhKCf3g5modFRx+/SbRR5hP8Wmh2lZYD2A9W z6Y5V8BBaSTnUQ43LFbRITg04yKfiKHVczjF8TNGfz/nSURJdj3S3iAiCwzhOKEixvKZ sWWbiZqpQPFS6fjUJKyz/QTtg11ObxZ+miZvf6HSEphLhM6PedHo0JabjlJ/yV58M9xW B9QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=0J9dQqXxpUpqjksZBdycZsJ8XR9I4aZNdsZm+8ZNLUo=; b=SOMUg/qGEA48W7DJ0ImVjnAo6KOkeimeEoZGOGlj9cadNw/u8VZi5xfjA/K89cS+Kw +UZjYMB3ZeULq+hI2XLgw6JfcfPyC+Z5RSr2bHjsnsUf65eyYn9jXgQ0Ew5AT3iEHk6H t1qlRxS7d5GsBxzkNajw4Z+V73sKUpFbHgLezlPfBsRWsXxKKTIEsPNFl+klN1Q/li29 i5lIuFgwcR3OUPA+oUyTSnlV9TZy6RgIoWuDFFDmRR807dOpgUv3TKJbE5xxSQ16PHoN qN4zQZlT3zBEaTkkXgkGwfPUPpZDMMfe/4A5ng8xjDSm/D9TqpA/EV8MgHAeP0aAjTRB U9yA== X-Gm-Message-State: AOAM530SAqSuxZyWhltIBuMfAjkTeEgetMZwed7Bf28Me+f1jVveB+rg 4XlNzY8Yt4IU68zZdPmQZp0= X-Google-Smtp-Source: ABdhPJzLUK1uz4JnIFsfT4QmH56gQ+EvaO3JMxw80Vu7bsgYKHZCse4nWGc3sCL0uD8c7PFHJMKz6g== X-Received: by 2002:a2e:82cb:: with SMTP id n11mr2246202ljh.352.1596665551654; Wed, 05 Aug 2020 15:12:31 -0700 (PDT) Received: from [192.168.1.2] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id y26sm1435000ljm.132.2020.08.05.15.12.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2020 15:12:30 -0700 (PDT) Subject: Re: [RFC PATCH V1 05/12] hvm/dm: Introduce xendevicemodel_set_irq_level DM op To: Jan Beulich References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-6-git-send-email-olekstysh@gmail.com> <1487bf45-3696-8052-ab98-149e612fff80@suse.com> From: Oleksandr Message-ID: <12116823-2e68-8f21-6a31-fca234f26ebf@gmail.com> Date: Thu, 6 Aug 2020 01:12:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1487bf45-3696-8052-ab98-149e612fff80@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Julien Grall , xen-devel@lists.xenproject.org, Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 05.08.20 19:15, Jan Beulich wrote: Hi, Jan > On 03.08.2020 20:21, Oleksandr Tyshchenko wrote: >> --- a/xen/include/public/hvm/dm_op.h >> +++ b/xen/include/public/hvm/dm_op.h >> @@ -417,6 +417,20 @@ struct xen_dm_op_pin_memory_cacheattr { >> uint32_t pad; >> }; >> >> +/* >> + * XEN_DMOP_set_irq_level: Set the logical level of a one of a domain's >> + * IRQ lines. >> + * XXX Handle PPIs. >> + */ >> +#define XEN_DMOP_set_irq_level 19 >> + >> +struct xen_dm_op_set_irq_level { >> + uint32_t irq; >> + /* IN - Level: 0 -> deasserted, 1 -> asserted */ >> + uint8_t level; >> +}; > If this is the way to go (I've seen other discussion going on), > please make sure you add explicit padding fields and ... ok > >> + >> + >> struct xen_dm_op { > ... you don't add double blank lines. ok -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Thu Aug 06 00:37:36 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 00:37:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3TuW-0008TZ-Qg; Thu, 06 Aug 2020 00:37:32 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3TuV-0008TU-Hz for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 00:37:31 +0000 X-Inumbo-ID: d831240d-8a6f-4cb2-8ee9-61af3bf9f8c3 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d831240d-8a6f-4cb2-8ee9-61af3bf9f8c3; Thu, 06 Aug 2020 00:37:30 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 11CFA20842; Thu, 6 Aug 2020 00:37:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596674249; bh=58gxZQX+81rp2Tjj7Tyd17W45ID0rzbw2oOak7qz0kg=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=QKzgzsK1RLQ8/0hGy2twY24jIbxHMHkrhdJol3mjtsptH2YPlcAZ8ODHPL7XxlOsi cuO0NW3rMIozE63l1Dso1i0H7DBXmLrp/ZjO1tD2drh8BeUTREa2m4yOVAxNCbjs3/ YoUeP13gnMIXD95Jjy5LHMFbZuBj4a4mQHf4bsik= Date: Wed, 5 Aug 2020 17:37:28 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Julien Grall Subject: Re: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common In-Reply-To: <5df97055-67f9-16cc-a274-864672d67164@xen.org> Message-ID: References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-2-git-send-email-olekstysh@gmail.com> <000c01d66a33$2bd56510$83802f30$@xen.org> <9f83a7ed-ca97-449f-c7b9-a1140644abe9@gmail.com> <5df97055-67f9-16cc-a274-864672d67164@xen.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1102007525-1596651956=:5748" Content-ID: X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: 'Kevin Tian' , Stefano Stabellini , 'Jun Nakajima' , 'Wei Liu' , paul@xen.org, 'Andrew Cooper' , 'Ian Jackson' , 'George Dunlap' , 'Tim Deegan' , Oleksandr , 'Oleksandr Tyshchenko' , 'Julien Grall' , 'Jan Beulich' , xen-devel@lists.xenproject.org, =?UTF-8?Q?'Roger_Pau_Monn=C3=A9'?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1102007525-1596651956=:5748 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Wed, 5 Aug 2020, Julien Grall wrote: > On 04/08/2020 20:11, Stefano Stabellini wrote: > > On Tue, 4 Aug 2020, Julien Grall wrote: > > > On 04/08/2020 12:10, Oleksandr wrote: > > > > On 04.08.20 10:45, Paul Durrant wrote: > > > > > > +static inline bool hvm_ioreq_needs_completion(const ioreq_t *ioreq) > > > > > > +{ > > > > > > +    return ioreq->state == STATE_IOREQ_READY && > > > > > > +           !ioreq->data_is_ptr && > > > > > > +           (ioreq->type != IOREQ_TYPE_PIO || ioreq->dir != > > > > > > IOREQ_WRITE); > > > > > > +} > > > > > I don't think having this in common code is correct. The short-cut of > > > > > not > > > > > completing PIO reads seems somewhat x86 specific. > > > > > > Hmmm, looking at the code, I think it doesn't wait for PIO writes to > > > complete > > > (not read). Did I miss anything? > > > > > > > Does ARM even > > > > > have the concept of PIO? > > > > > > > > I am not 100% sure here, but it seems that doesn't have. > > > > > > Technically, the PIOs exist on Arm, however they are accessed the same way > > > as > > > MMIO and will have a dedicated area defined by the HW. > > > > > > AFAICT, on Arm64, they are only used for PCI IO Bar. > > > > > > Now the question is whether we want to expose them to the Device Emulator > > > as > > > PIO or MMIO access. From a generic PoV, a DM shouldn't have to care about > > > the > > > architecture used. It should just be able to request a given IOport > > > region. > > > > > > So it may make sense to differentiate them in the common ioreq code as > > > well. > > > > > > I had a quick look at QEMU and wasn't able to tell if PIOs and MMIOs > > > address > > > space are different on Arm as well. Paul, Stefano, do you know what they > > > are > > > doing? > > > > On the QEMU side, it looks like PIO (address_space_io) is used in > > connection with the emulation of the "in" or "out" instructions, see > > ioport.c:cpu_inb for instance. Some parts of PCI on QEMU emulate PIO > > space regardless of the architecture, such as > > hw/pci/pci_bridge.c:pci_bridge_initfn. > > > > However, because there is no "in" and "out" on ARM, I don't think > > address_space_io can be accessed. Specifically, there is no equivalent > > for target/i386/misc_helper.c:helper_inb on ARM. > > So how PCI I/O BAR are accessed? Surely, they could be used on Arm, right? PIO is also memory mapped on ARM and it seems to have its own MMIO address window. --8323329-1102007525-1596651956=:5748-- From xen-devel-bounces@lists.xenproject.org Thu Aug 06 00:37:36 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 00:37:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3TuQ-0008TC-Hj; Thu, 06 Aug 2020 00:37:26 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3TuP-0008T7-Bx for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 00:37:25 +0000 X-Inumbo-ID: dd9a61fe-4e98-43f0-b7a4-06b57264fcd9 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id dd9a61fe-4e98-43f0-b7a4-06b57264fcd9; Thu, 06 Aug 2020 00:37:23 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ED96C20842; Thu, 6 Aug 2020 00:37:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596674242; bh=IvvjNayDWHWpV02+RT2Wm7bTN+tg82sFIQ4J452VtMY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=aaiyM/WRGotg9LJl8yqafFSo0YLqLJ0ThXd47pNSk8X3LbX2Tj3qVtjLEBQFzCErX U2KezIWoaOYIlbBLOI/af9/lYp5H+2hGkT8OKiFkF2TaH0uFHvUzb565ptS0j0n7N0 i+c1GHoOp/3RKJ6TuxWI0Iu6J+4DfMKOYTSL9PNs= Date: Wed, 5 Aug 2020 17:37:21 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Jan Beulich Subject: Re: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common In-Reply-To: <2ab4c567-8efa-1b9d-ab00-4ea7e1ab323e@suse.com> Message-ID: References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-2-git-send-email-olekstysh@gmail.com> <000c01d66a33$2bd56510$83802f30$@xen.org> <9f83a7ed-ca97-449f-c7b9-a1140644abe9@gmail.com> <2ab4c567-8efa-1b9d-ab00-4ea7e1ab323e@suse.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: 'Kevin Tian' , Stefano Stabellini , Julien Grall , 'Wei Liu' , paul@xen.org, 'Andrew Cooper' , 'Ian Jackson' , 'George Dunlap' , 'Tim Deegan' , Oleksandr , 'Oleksandr Tyshchenko' , 'Julien Grall' , 'Jun Nakajima' , xen-devel@lists.xenproject.org, =?UTF-8?Q?'Roger_Pau_Monn=C3=A9'?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Wed, 5 Aug 2020, Jan Beulich wrote: > On 04.08.2020 21:11, Stefano Stabellini wrote: > >> The point of the check isn't to determine whether to wait, but > >> what to do after having waited. Reads need a retry round through > >> the emulator (to store the result in the designated place), > >> while writes don't have such a requirement (and hence guest > >> execution can continue immediately in the general case). > > > > The x86 code looks like this: > > > > rc = hvm_send_ioreq(s, &p, 0); > > if ( rc != X86EMUL_RETRY || currd->is_shutting_down ) > > vio->io_req.state = STATE_IOREQ_NONE; > > else if ( !hvm_ioreq_needs_completion(&vio->io_req) ) > > rc = X86EMUL_OKAY; > > > > Basically hvm_send_ioreq is expected to return RETRY. > > Then, if it is a PIO write operation only, it is turned into OKAY right > > away. Otherwise, rc stays as RETRY. > > > > So, normally, hvmemul_do_io is expected to return RETRY, because the > > emulator is not done yet. Am I understanding the code correctly? > > "The emulator" unfortunately is ambiguous here: Do you mean qemu > (or whichever else ioreq server) or the x86 emulator inside Xen? I meant QEMU. I'll use "QEMU" instead of "emulator" in this thread going forward for clarity. > There are various conditions leading to RETRY. As far as > hvm_send_ioreq() goes, it is expected to return RETRY whenever > some sort of response is to be expected (the most notable > exception being the hvm_send_buffered_ioreq() path), or when > submitting the request isn't possible in the first place. > > > If so, who is handling RETRY on x86? It tried to follow the call chain > > but ended up in the x86 emulator and got lost :-) > > Not sure I understand the question correctly, but I'll try an > answer nevertheless: hvm_send_ioreq() arranges for the vCPU to be > put to sleep (prepare_wait_on_xen_event_channel()). Once the event > channel got signaled (and vCPU unblocked), hvm_do_resume() -> > handle_hvm_io_completion() -> hvm_wait_for_io() then check whether > the wait reason has been satisfied (wait_on_xen_event_channel()), > and ... > > > At some point later, after the emulator (QEMU) has completed the > > request, handle_hvm_io_completion gets called which ends up calling > > handle_mmio() finishing the job on the Xen side too. > > ..., as you say, handle_hvm_io_completion() invokes the retry of > the original operation (handle_mmio() or handle_pio() in > particular) if need be. OK, thanks for the details. My interpretation seems to be correct. In which case, it looks like xen/arch/arm/io.c:try_fwd_ioserv should return IO_RETRY. Then, xen/arch/arm/traps.c:do_trap_stage2_abort_guest also needs to handle try_handle_mmio returning IO_RETRY the first around, and IO_HANDLED when after QEMU does its job. What should do_trap_stage2_abort_guest do on IO_RETRY? Simply return early and let the scheduler do its job? Something like: enum io_state state = try_handle_mmio(regs, hsr, gpa); switch ( state ) { case IO_ABORT: goto inject_abt; case IO_HANDLED: advance_pc(regs, hsr); return; case IO_RETRY: /* finish later */ return; case IO_UNHANDLED: /* IO unhandled, try another way to handle it. */ break; default: ASSERT_UNREACHABLE(); } Then, xen/arch/arm/ioreq.c:handle_mmio() gets called by handle_hvm_io_completion() after QEMU completes the emulation. Today, handle_mmio just sets the user register with the read value. But it would be better if it called again the original function do_trap_stage2_abort_guest to actually retry the original operation. This time do_trap_stage2_abort_guest calls try_handle_mmio() and gets IO_HANDLED instead of IO_RETRY, thus, it will advance_pc (the program counter) completing the handling of this instruction. The user register with the read value could be set by try_handle_mmio if try_fwd_ioserv returns IO_HANDLED instead of IO_RETRY. Is that how the state machine is expected to work? > What's potentially confusing is that there's a second form of > retry, invoked by the x86 insn emulator itself when it needs to > split complex insns (the repeated string insns being the most > important example). This results in actually exiting back to guest > context without having advanced rIP, but after having updated > other register state suitably (to express the progress made so > far). Ah! And it seems to be exactly the same label: X86EMUL_RETRY. It would be a good idea to differentiate between them. From xen-devel-bounces@lists.xenproject.org Thu Aug 06 00:37:37 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 00:37:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3TuK-0008Sy-9U; Thu, 06 Aug 2020 00:37:20 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3TuI-0008St-Ks for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 00:37:18 +0000 X-Inumbo-ID: 677f2daf-3738-4a90-8d48-2da1ce953f19 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 677f2daf-3738-4a90-8d48-2da1ce953f19; Thu, 06 Aug 2020 00:37:16 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4714720842; Thu, 6 Aug 2020 00:37:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596674235; bh=QL2X5XhqFxDTG6/bMrTWuGUIjxEqBB6EpA4FLHOdu94=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=K+RgeZLA5Yn124yXBV/brINIkhAyoYii2OQ9X2vyBUKIsU6UWzgDRPSIQT74Iam/b EqfnuLN30qpXXYLisXtq6TwLphrEN/Becv3R6c7CAj3z1HADho/6/JDYAd17k7eyHg e+lup9+nFhys67svZc3s9E3tyA9HK0VmF5vSgtkY= Date: Wed, 5 Aug 2020 17:37:14 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Julien Grall Subject: Re: [RFC PATCH V1 05/12] hvm/dm: Introduce xendevicemodel_set_irq_level DM op In-Reply-To: <00e261e0-295a-9cd8-ed11-7e3801a4eb58@xen.org> Message-ID: References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-6-git-send-email-olekstysh@gmail.com> <00e261e0-295a-9cd8-ed11-7e3801a4eb58@xen.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Oleksandr Tyshchenko , Julien Grall , Jan Beulich , xen-devel@lists.xenproject.org, Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Wed, 5 Aug 2020, Julien Grall wrote: > On 05/08/2020 00:22, Stefano Stabellini wrote: > > On Mon, 3 Aug 2020, Oleksandr Tyshchenko wrote: > > > From: Oleksandr Tyshchenko > > > > > > This patch adds ability to the device emulator to notify otherend > > > (some entity running in the guest) using a SPI and implements Arm > > > specific bits for it. Proposed interface allows emulator to set > > > the logical level of a one of a domain's IRQ lines. > > > > > > Please note, this is a split/cleanup of Julien's PoC: > > > "Add support for Guest IO forwarding to a device emulator" > > > > > > Signed-off-by: Julien Grall > > > Signed-off-by: Oleksandr Tyshchenko > > > --- > > > tools/libs/devicemodel/core.c | 18 ++++++++++++++++++ > > > tools/libs/devicemodel/include/xendevicemodel.h | 4 ++++ > > > tools/libs/devicemodel/libxendevicemodel.map | 1 + > > > xen/arch/arm/dm.c | 22 > > > +++++++++++++++++++++- > > > xen/common/hvm/dm.c | 1 + > > > xen/include/public/hvm/dm_op.h | 15 +++++++++++++++ > > > 6 files changed, 60 insertions(+), 1 deletion(-) > > > > > > diff --git a/tools/libs/devicemodel/core.c b/tools/libs/devicemodel/core.c > > > index 4d40639..30bd79f 100644 > > > --- a/tools/libs/devicemodel/core.c > > > +++ b/tools/libs/devicemodel/core.c > > > @@ -430,6 +430,24 @@ int xendevicemodel_set_isa_irq_level( > > > return xendevicemodel_op(dmod, domid, 1, &op, sizeof(op)); > > > } > > > +int xendevicemodel_set_irq_level( > > > + xendevicemodel_handle *dmod, domid_t domid, uint32_t irq, > > > + unsigned int level) > > > > It is a pity that having xen_dm_op_set_pci_intx_level and > > xen_dm_op_set_isa_irq_level already we need to add a third one, but from > > the names alone I don't think we can reuse either of them. > > The problem is not the name... > > > > > It is very similar to set_isa_irq_level. We could almost rename > > xendevicemodel_set_isa_irq_level to xendevicemodel_set_irq_level or, > > better, just add an alias to it so that xendevicemodel_set_irq_level is > > implemented by calling xendevicemodel_set_isa_irq_level. Honestly I am > > not sure if it is worth doing it though. Any other opinions? > > ... the problem is the interrupt field is only 8-bit. So we would only be able > to cover IRQ 0 - 255. Argh, that's not going to work :-( I wasn't sure if it was a good idea anyway. > It is not entirely clear how the existing subop could be extended without > breaking existing callers. > > > But I think we should plan for not needing two calls (one to set level > > to 1, and one to set it to 0): > > https://marc.info/?l=xen-devel&m=159535112027405 > > I am not sure to understand your suggestion here? Are you suggesting to remove > the 'level' parameter? My hope was to make it optional to call the hypercall with level = 0, not necessarily to remove 'level' from the struct. From xen-devel-bounces@lists.xenproject.org Thu Aug 06 00:37:40 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 00:37:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Tue-0008VK-2r; Thu, 06 Aug 2020 00:37:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Tuc-0008Un-KO for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 00:37:38 +0000 X-Inumbo-ID: 0318ceb1-8ef3-4499-ba90-c6c1c530e1d1 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0318ceb1-8ef3-4499-ba90-c6c1c530e1d1; Thu, 06 Aug 2020 00:37:38 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EC97E20842; Thu, 6 Aug 2020 00:37:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596674257; bh=HUah37MMBn0GfpIWlikSkdn3TmdrL0UVtnSZU4cStsQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=aEQ5h/vBXHTcZjJoUDP4Kj0475b8Lxd3Q9GRVrModzkvk+8W4eLL+HHjFKXtX9nZn hK9fG93kkGeiEEE4plX/NuRkqaM+7YCzEVPp3QDN5CJTqEfKBW5NUk0B9LdlHm7z3S 54V9rIh35DsWoRi4nAkO2S6aGsSapRJ0z5XdyGfE= Date: Wed, 5 Aug 2020 17:37:36 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Oleksandr Subject: Re: [RFC PATCH V1 10/12] libxl: Add support for virtio-disk configuration In-Reply-To: <19fd2966-6e54-4f68-7f37-b2d8bb910d93@gmail.com> Message-ID: References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-11-git-send-email-olekstysh@gmail.com> <19fd2966-6e54-4f68-7f37-b2d8bb910d93@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Ian Jackson , Oleksandr Tyshchenko , Anthony PERARD , xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Thu, 6 Aug 2020, Oleksandr wrote: > On 05.08.20 02:23, Stefano Stabellini wrote: > > On Mon, 3 Aug 2020, Oleksandr Tyshchenko wrote: > > > From: Oleksandr Tyshchenko > > > > > > This patch adds basic support for configuring and assisting virtio-disk > > > backend (emualator) which is intended to run out of Qemu and could be run > > > in any domain. > > > > > > Xenstore was chosen as a communication interface for the emulator running > > > in non-toolstack domain to be able to get configuration either by reading > > > Xenstore directly or by receiving command line parameters (an updated 'xl > > > devd' > > > running in the same domain would read Xenstore beforehand and call backend > > > executable with the required arguments). > > > > > > An example of domain configuration (two disks are assigned to the guest, > > > the latter is in readonly mode): > > > > > > vdisk = [ 'backend=DomD, disks=rw:/dev/mmcblk0p3;ro:/dev/mmcblk1p3' ] > > > > > > Where per-disk Xenstore entries are: > > > - filename and readonly flag (configured via "vdisk" property) > > > - base and irq (allocated dynamically) > > > > > > Besides handling 'visible' params described in configuration file, > > > patch also allocates virtio-mmio specific ones for each device and > > > writes them into Xenstore. virtio-mmio params (irq and base) are > > > unique per guest domain, they allocated at the domain creation time > > > and passed through to the emulator. Each VirtIO device has at least > > > one pair of these params. > > > > > > TODO: > > > 1. An extra "virtio" property could be removed. > > > 2. Update documentation. > > > > > > Signed-off-by: Oleksandr Tyshchenko > > > --- > > > tools/libxl/Makefile | 4 +- > > > tools/libxl/libxl_arm.c | 63 +++++++++++++++---- > > > tools/libxl/libxl_create.c | 1 + > > > tools/libxl/libxl_internal.h | 1 + > > > tools/libxl/libxl_types.idl | 15 +++++ > > > tools/libxl/libxl_types_internal.idl | 1 + > > > tools/libxl/libxl_virtio_disk.c | 109 > > > +++++++++++++++++++++++++++++++++ > > > tools/xl/Makefile | 2 +- > > > tools/xl/xl.h | 3 + > > > tools/xl/xl_cmdtable.c | 15 +++++ > > > tools/xl/xl_parse.c | 115 > > > +++++++++++++++++++++++++++++++++++ > > > tools/xl/xl_virtio_disk.c | 46 ++++++++++++++ > > > 12 files changed, 360 insertions(+), 15 deletions(-) > > > create mode 100644 tools/libxl/libxl_virtio_disk.c > > > create mode 100644 tools/xl/xl_virtio_disk.c > > > > > > diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile > > > index 38cd43a..df94b13 100644 > > > --- a/tools/libxl/Makefile > > > +++ b/tools/libxl/Makefile > > > @@ -141,7 +141,9 @@ LIBXL_OBJS = flexarray.o libxl.o libxl_create.o > > > libxl_dm.o libxl_pci.o \ > > > libxl_vtpm.o libxl_nic.o libxl_disk.o libxl_console.o > > > \ > > > libxl_cpupool.o libxl_mem.o libxl_sched.o libxl_tmem.o > > > \ > > > libxl_9pfs.o libxl_domain.o libxl_vdispl.o \ > > > - libxl_pvcalls.o libxl_vsnd.o libxl_vkb.o > > > $(LIBXL_OBJS-y) > > > + libxl_pvcalls.o libxl_vsnd.o libxl_vkb.o \ > > > + libxl_virtio_disk.o $(LIBXL_OBJS-y) > > > + > > > LIBXL_OBJS += libxl_genid.o > > > LIBXL_OBJS += _libxl_types.o libxl_flask.o _libxl_types_internal.o > > > diff --git a/tools/libxl/libxl_arm.c b/tools/libxl/libxl_arm.c > > > index 4f748e3..469a8b0 100644 > > > --- a/tools/libxl/libxl_arm.c > > > +++ b/tools/libxl/libxl_arm.c > > > @@ -13,6 +13,12 @@ > > > #define GUEST_VIRTIO_MMIO_SIZE xen_mk_ullong(0x200) > > > #define GUEST_VIRTIO_MMIO_SPI 33 > > > +#ifndef container_of > > > +#define container_of(ptr, type, member) ({ \ > > > + typeof( ((type *)0)->member ) *__mptr = (ptr); \ > > > + (type *)( (char *)__mptr - offsetof(type,member) );}) > > > +#endif > > > + > > > static const char *gicv_to_string(libxl_gic_version gic_version) > > > { > > > switch (gic_version) { > > > @@ -44,14 +50,32 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, > > > vuart_enabled = true; > > > } > > > - /* > > > - * XXX: Handle properly virtio > > > - * A proper solution would be the toolstack to allocate the > > > interrupts > > > - * used by each virtio backend and let the backend now which one is > > > used > > > - */ > > > if (libxl_defbool_val(d_config->b_info.arch_arm.virtio)) { > > > - nr_spis += (GUEST_VIRTIO_MMIO_SPI - 32) + 1; > > > + uint64_t virtio_base; > > > + libxl_device_virtio_disk *virtio_disk; > > > + > > > + virtio_base = GUEST_VIRTIO_MMIO_BASE; > > > virtio_irq = GUEST_VIRTIO_MMIO_SPI; > > > + > > > + if (!d_config->num_virtio_disks) { > > > + LOG(ERROR, "Virtio is enabled, but no Virtio devices > > > present\n"); > > > + return ERROR_FAIL; > > > + } > > > + virtio_disk = &d_config->virtio_disks[0]; > > > + > > > + for (i = 0; i < virtio_disk->num_disks; i++) { > > > + virtio_disk->disks[i].base = virtio_base; > > > + virtio_disk->disks[i].irq = virtio_irq; > > > + > > > + LOG(DEBUG, "Allocate Virtio MMIO params: IRQ %u BASE > > > 0x%"PRIx64, > > > + virtio_irq, virtio_base); > > > + > > > + virtio_irq ++; > > > + virtio_base += GUEST_VIRTIO_MMIO_SIZE; > > > + } > > > + virtio_irq --; > > > + > > > + nr_spis += (virtio_irq - 32) + 1; > > It looks like it is an interrupt per device, which could lead to quite a > > few of them being allocated. > > Yes. > > > > So, if we end up allocating > > let's say 6 virtio interrupts for a domain, the chance of a clash with a > > physical interrupt of a passthrough device is real. > > Yes. > > > > > > I am not entirely sure how to solve it, but these are a few ideas: > > - choosing virtio interrupts that are less likely to conflict (maybe > > > 1000) > > - make the virtio irq (optionally) configurable so that a user could > > override the default irq and specify one that doesn't conflict > > - implementing support for virq != pirq (even the xl interface doesn't > > allow to specify the virq number for passthrough devices, see "irqs") > > Good ideas. The first requires minimum effort. Couldn't we choose virtio > interrupt to allocate after making sure it is absent in guest "irqs" > (d_config->b_info.irqs[i]), I mean to find some holes? Yes, that might be possible too. So far we have tried to stay away from dynamic irq allocation for guests virtual devices, but we also didn't have to deal with potentially large amount of them :-) From xen-devel-bounces@lists.xenproject.org Thu Aug 06 01:44:19 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 01:44:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Uwm-0002b9-6x; Thu, 06 Aug 2020 01:43:56 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Uwk-0002aj-GN for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 01:43:54 +0000 X-Inumbo-ID: e582a014-047b-4c51-84c6-555e3f583ba3 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e582a014-047b-4c51-84c6-555e3f583ba3; Thu, 06 Aug 2020 01:43:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=d2Ov3MUFhspEOhienLEjPm9PsJwyvX0rRPP8VFhXe7o=; b=G8FhCxnGFc5jOGkqyTgQHi7Wy CY7vAVZ5oyJzNlmmC01RUu+/fomMiU0Mg7dPaQ7gXwkgI1Q/kkORhtPbPTRSBap/nvFcKOrzJeugA MA58Qdq6uG4oBJAaQJQ4TcPxb5rTzLMaBizSsdDCQtGBkna7jIszYBsMOZYgQh+zsV40c=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3Uwc-00034N-1o; Thu, 06 Aug 2020 01:43:46 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k3Uwb-0006YN-Cc; Thu, 06 Aug 2020 01:43:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k3Uwb-0002f1-4q; Thu, 06 Aug 2020 01:43:45 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 152484: regressions - FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking X-Osstest-Versions-This: xen=c9f9a7258dc07735e2da2b6d0b51a0218c76a51f X-Osstest-Versions-That: xen=81fd0d3ca4b2cd309403c6e8da662c325dd35750 From: osstest service owner Date: Thu, 06 Aug 2020 01:43:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152484 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/152484/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 16 guest-start/debianhvm.repeat fail REGR. vs. 152418 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 10 debian-hvm-install fail REGR. vs. 152418 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail like 152418 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail like 152418 test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail like 152418 test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail like 152418 test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail like 152418 test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 152418 test-armhf-armhf-libvirt 14 saverestore-support-check fail like 152418 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail like 152418 test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail like 152418 test-amd64-i386-xl-pvshim 12 guest-start fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass version targeted for testing: xen c9f9a7258dc07735e2da2b6d0b51a0218c76a51f baseline version: xen 81fd0d3ca4b2cd309403c6e8da662c325dd35750 Last test of basis 152418 2020-08-03 11:11:04 Z 2 days Failing since 152461 2020-08-04 07:50:21 Z 1 days 2 attempts Testing same since 152484 2020-08-05 05:20:21 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Wei Liu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit c9f9a7258dc07735e2da2b6d0b51a0218c76a51f Author: Wei Liu Date: Tue Aug 4 15:53:48 2020 +0000 Revert "libxl: avoid golang building without CONFIG_GOLANG=y" This reverts commit fe49938f21c26f0ce630c69af055f927dd0ed75f. We have an on-going discussion regarding this patch. Signed-off-by: Wei Liu commit fe49938f21c26f0ce630c69af055f927dd0ed75f Author: Jan Beulich Date: Mon Aug 3 10:06:32 2020 +0200 libxl: avoid golang building without CONFIG_GOLANG=y While this doesn't address the real problem I've run into (attempting to update r/o source files), not recursing into tools/golang/xenlight/ is enough to fix the build for me for the moment. I don't currently see why 60db5da62ac0 ("libxl: Generate golang bindings in libxl Makefile") found it necessary to invoke this build step unconditionally. Signed-off-by: Jan Beulich Acked-by: Wei Liu commit 9909532113692020c1b50eb974cac47d4ea10e69 Author: Jan Beulich Date: Mon Aug 3 16:27:22 2020 +0200 x86emul: avoid assembler warning about .type not taking effect in test harness gcc re-orders top level blocks by default when optimizing. This re-ordering results in all our .type directives to get emitted to the assembly file first, followed by gcc's. The assembler warns about attempts to change the type of a symbol when it was already set (and when there's no intervening setting to "notype"). Signed-off-by: Jan Beulich Acked-by: Andrew Cooper (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Thu Aug 06 03:10:58 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 03:10:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3WId-000232-0a; Thu, 06 Aug 2020 03:10:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3WIb-00022i-Rr for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 03:10:33 +0000 X-Inumbo-ID: fa01ab1d-c5b5-4dae-8e19-74767dbfe313 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fa01ab1d-c5b5-4dae-8e19-74767dbfe313; Thu, 06 Aug 2020 03:10:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=XVYDdqXMZG1WEVMr72L16mU2tiJO7w98ms1ksEgL+5s=; b=c5ispsp08JQ0RmjQGL4xmWfHi FirP8DxoFGdSHsct/zpwME8GeVwBqAspogmeiZPqYUVMPNSgk5V6P13BOu2mFbHpUSMABfjOQia3v ghB5Q1/AVoucqSILRl8Khf+hAviCYBwGMIlJnu+QqB4+ejAFPe+Z4J7kag7oOtlIO9FyE=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3WIT-0005QW-LF; Thu, 06 Aug 2020 03:10:25 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k3WIT-0001Vo-6J; Thu, 06 Aug 2020 03:10:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k3WIT-0004sH-5X; Thu, 06 Aug 2020 03:10:25 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 152486: regressions - FAIL X-Osstest-Failures: linux-5.4:test-amd64-amd64-qemuu-nested-amd:xen-boot/l1:fail:regression linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking X-Osstest-Versions-This: linux=1b940bbc5c55551a3420f403a2b10cb884cffb01 X-Osstest-Versions-That: linux=169b93899c7dfb93a2b57da8e3505da9b2afcf5c From: osstest service owner Date: Thu, 06 Aug 2020 03:10:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152486 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/152486/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-amd 14 xen-boot/l1 fail REGR. vs. 152331 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-pvshim 12 guest-start fail never pass test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail never pass test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail never pass test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail never pass version targeted for testing: linux 1b940bbc5c55551a3420f403a2b10cb884cffb01 baseline version: linux 169b93899c7dfb93a2b57da8e3505da9b2afcf5c Last test of basis 152331 2020-07-31 17:11:00 Z 5 days Testing same since 152486 2020-08-05 08:10:20 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abhishek Ambure Alaa Hleihel Alain Michaud Alex Deucher Andrea Righi Andrew Morton Andrii Nakryiko Armas Spann Arnaldo Carvalho de Melo Atish Patra Aya Levin Balaji Pothunoori Ben Hutchings Bjorn Helgaas Chen-Yu Tsai Christoph Hellwig Daniel Borkmann Daniel Vetter Dave Anglin David Hildenbrand David S. Miller Dominique Martinet Eran Ben Elisha Fabio Estevam Gary R Hook Geert Uytterhoeven Geert Uytterhoeven Greg Kroah-Hartman Gregory CLEMENT Guojia Liao Helge Deller Herbert Xu Honggang Li Huazhong Tan Ido Schimmel Ingo Molnar J. Bruce Fields Jakub Kicinski Jan Kara Jason Gunthorpe Jason Wang Johan Hovold Johannes Berg John Paul Adrian Glaubitz Josh Poimboeuf Kailang Yang Kalle Valo Laurence Oberman Laurence Tratt Liam Beguin Linus Torvalds Lu Wei Luis Machado Marc Zyngier Marcel Holtmann Martin K. Petersen Mauro Carvalho Chehab Maxime Ripard Mazin Rezk Michael Karcher Michael S. Tsirkin Michael Trimarchi Michal Simek Mike Marciniszyn Ming Lei Navid Emamdoost NeilBrown Nick Desaulniers Palmer Dabbelt Paolo Bonzini Paolo Pisati Parav Pandit Paul Cercueil Peilin Ye PeiSen Hou Peter Zijlstra (Intel) Peter Zijlstra Pi-Hsun Shih Quentin Perret Raviteja Narayanam Remi Pommarel Rich Felker Robert Hancock Robin Murphy Ron Diskin Roopa Prabhu Russell King Saeed Mahameed Sagi Grimberg Salvatore Bonaccorso Sam Ravnborg Sami Tolvanen Santosh Shilimkar Sasha Levin Sathishkumar Muruganandam Sean Young Shawn Guo Shuah Khan Song Liu Sonny Sasaka Steffen Klassert Steve Cohen Suniel Mahesh Taehee Yoo Takashi Iwai Tanner Love Thomas Falcon Thomas Gleixner Tobias Brunner Wang Hai Wang ShaoBo Wanpeng Li Wei Li Will Deacon Willem de Bruijn Wolfram Sang Xie He Xin Long Xin Tan Xin Xiong Xiyu Yang Yonglong Liu Yoshihiro Shimoda YueHaibing jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2552 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Aug 06 06:22:38 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 06:22:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3ZHs-0001jp-JI; Thu, 06 Aug 2020 06:22:00 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3ZHr-0001jj-6R for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 06:21:59 +0000 X-Inumbo-ID: b8cecaba-46ce-4961-9d87-2d44d936eeea Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b8cecaba-46ce-4961-9d87-2d44d936eeea; Thu, 06 Aug 2020 06:21:58 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C39F6ACB8; Thu, 6 Aug 2020 06:22:14 +0000 (UTC) Subject: Re: [PATCH] x86/tsc: Fix diagnostics for TSC frequency To: Andrew Cooper References: <20200805141804.2585-1-andrew.cooper3@citrix.com> <3123eedc-252d-7e9e-a4af-6f8bfae82f41@suse.com> From: Jan Beulich Message-ID: <1a4e9db8-6a04-54b3-c73c-aca64a9a70e5@suse.com> Date: Thu, 6 Aug 2020 08:21:56 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Xen-devel , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 05.08.2020 18:25, Andrew Cooper wrote: > On 05/08/2020 15:54, Jan Beulich wrote: >> On 05.08.2020 16:18, Andrew Cooper wrote: >>> --- a/xen/arch/x86/cpu/intel.c >>> +++ b/xen/arch/x86/cpu/intel.c >>> @@ -396,14 +396,14 @@ static void intel_log_freq(const struct cpuinfo_x86 *c) >>> >>> val *= ebx; >>> do_div(val, eax); >>> - printk("CPU%u: TSC: %uMHz * %u / %u = %LuMHz\n", >>> + printk("CPU%u: TSC: %u Hz * %u / %u = %Lu Hz\n", >>> smp_processor_id(), ecx, ebx, eax, val); >> For this one I wonder whether ecx wouldn't better be scaled down to >> kHz, and val down to MHz. > > That depends on whether we will lose precision in the process. I don't think losing the last three digits for the base clock and the last six ones of the calculated value would do any harm at all. All it would do (imo) is to make the numbers better readable (due less counting, and hence less possible counting mistakes). > In principle we can, given ecx's unit of Hz, so I'd be tempted to leave > it as is. Well, okay. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 07:00:03 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 07:00:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3ZsY-0004UI-K8; Thu, 06 Aug 2020 06:59:54 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3ZsY-0004UD-8T for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 06:59:54 +0000 X-Inumbo-ID: d7fcf635-7a57-4d5f-a186-bd9bab7e41ba Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d7fcf635-7a57-4d5f-a186-bd9bab7e41ba; Thu, 06 Aug 2020 06:59:53 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6A892ABCE; Thu, 6 Aug 2020 07:00:09 +0000 (UTC) Subject: Re: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common To: Stefano Stabellini References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-2-git-send-email-olekstysh@gmail.com> <000c01d66a33$2bd56510$83802f30$@xen.org> <9f83a7ed-ca97-449f-c7b9-a1140644abe9@gmail.com> <2ab4c567-8efa-1b9d-ab00-4ea7e1ab323e@suse.com> From: Jan Beulich Message-ID: <51e30c1c-6b19-e646-fdc4-683b3197817a@suse.com> Date: Thu, 6 Aug 2020 08:59:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: 'Kevin Tian' , Julien Grall , 'Wei Liu' , paul@xen.org, 'Andrew Cooper' , 'Ian Jackson' , 'George Dunlap' , 'Tim Deegan' , Oleksandr , 'Oleksandr Tyshchenko' , 'Julien Grall' , 'Jun Nakajima' , xen-devel@lists.xenproject.org, =?UTF-8?B?J1JvZ2VyIFBhdSBNb25uw6kn?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 06.08.2020 02:37, Stefano Stabellini wrote: > What should do_trap_stage2_abort_guest do on IO_RETRY? Simply return > early and let the scheduler do its job? Something like: > > enum io_state state = try_handle_mmio(regs, hsr, gpa); > > switch ( state ) > { > case IO_ABORT: > goto inject_abt; > case IO_HANDLED: > advance_pc(regs, hsr); > return; > case IO_RETRY: > /* finish later */ > return; > case IO_UNHANDLED: > /* IO unhandled, try another way to handle it. */ > break; > default: > ASSERT_UNREACHABLE(); > } > > Then, xen/arch/arm/ioreq.c:handle_mmio() gets called by > handle_hvm_io_completion() after QEMU completes the emulation. Today, > handle_mmio just sets the user register with the read value. > > But it would be better if it called again the original function > do_trap_stage2_abort_guest to actually retry the original operation. > This time do_trap_stage2_abort_guest calls try_handle_mmio() and gets > IO_HANDLED instead of IO_RETRY, thus, it will advance_pc (the program > counter) completing the handling of this instruction. > > The user register with the read value could be set by try_handle_mmio if > try_fwd_ioserv returns IO_HANDLED instead of IO_RETRY. > > Is that how the state machine is expected to work? I think so. Just because it has taken us quite some time (years) on the x86 side to get reasonably close to how hardware would behave (I think we're still not fully there): The re-execution path needs to make sure it observes exactly the same machine state as the original path did. In particular changes to memory (by another vCPU) must not be observed. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 07:58:03 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 07:58:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3amX-0001LZ-JI; Thu, 06 Aug 2020 07:57:45 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3amW-0001LU-0y for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 07:57:44 +0000 X-Inumbo-ID: e50c44e3-c9a8-4e68-bac4-ca16e3e58e89 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e50c44e3-c9a8-4e68-bac4-ca16e3e58e89; Thu, 06 Aug 2020 07:57:42 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id BE663AC37; Thu, 6 Aug 2020 07:57:58 +0000 (UTC) Subject: Re: [RFC] efi/boot: Unified Xen executable for UEFI Secure Boot support To: Trammell Hudson References: From: Jan Beulich Message-ID: <1bd2d79e-5bef-835c-f6cc-9fd367e8beb7@suse.com> Date: Thu, 6 Aug 2020 09:57:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 05.08.2020 19:20, Trammell Hudson wrote: > This preliminary patch adds support for bundling the Xen hypervisor, xen.cfg, the Linux kernel, initrd and XSM into a single "unified" EFI executable that can be signed by sbsigntool for verification by UEFI Secure Boot. It is inspired by systemd-boot's unified kernel technique and borrows the function to locate PE sections from systemd's LGPL'ed code. > > The configuration, kernel, etc are added after building using objcopy to add named sections for each input file. This allows an administrator to update the components independently without requiring rebuilding xen. During EFI boot, Xen looks at its own loaded image to locate the PE sections and, if secure boot is enabled, only allows use of the unified components. > > The resulting EFI executable can be invoked directly from the UEFI Boot Manager, removing the need to use a separate loader like grub. Unlike the shim based verification, the signature covers the entire Xen+config+kernel+initrd unified file. This also ensures that properly configured platforms will measure the entire runtime into the TPM for unsealing secrets or remote attestation. Looks reasonable for a PoC, thanks, but needs cleaning up I think. A couple of specific remarks / questions: > @@ -665,6 +667,136 @@ static bool __init read_file(EFI_FILE_HANDLE dir_handle, CHAR16 *name, > return true; > } > > + > +struct DosFileHeader { > + UINT8 Magic[2]; > + UINT16 LastSize; > + UINT16 nBlocks; > + UINT16 nReloc; > + UINT16 HdrSize; > + UINT16 MinAlloc; > + UINT16 MaxAlloc; > + UINT16 ss; > + UINT16 sp; > + UINT16 Checksum; > + UINT16 ip; > + UINT16 cs; > + UINT16 RelocPos; > + UINT16 nOverlay; > + UINT16 reserved[4]; > + UINT16 OEMId; > + UINT16 OEMInfo; > + UINT16 reserved2[10]; > + UINT32 ExeHeader; > +} __attribute__((packed)); > + > +#define PE_HEADER_MACHINE_I386 0x014c > +#define PE_HEADER_MACHINE_X64 0x8664 > +#define PE_HEADER_MACHINE_ARM64 0xaa64 > + > +struct PeFileHeader { > + UINT16 Machine; > + UINT16 NumberOfSections; > + UINT32 TimeDateStamp; > + UINT32 PointerToSymbolTable; > + UINT32 NumberOfSymbols; > + UINT16 SizeOfOptionalHeader; > + UINT16 Characteristics; > +} __attribute__((packed)); > + > +struct PeHeader { > + UINT8 Magic[4]; > + struct PeFileHeader FileHeader; > +} __attribute__((packed)); > + > +struct PeSectionHeader { > + UINT8 Name[8]; > + UINT32 VirtualSize; > + UINT32 VirtualAddress; > + UINT32 SizeOfRawData; > + UINT32 PointerToRawData; > + UINT32 PointerToRelocations; > + UINT32 PointerToLinenumbers; > + UINT16 NumberOfRelocations; > + UINT16 NumberOfLinenumbers; > + UINT32 Characteristics; > +} __attribute__((packed)); > + > +static void * __init pe_find_section(const void * const image_base, > + const char * section_name, UINTN * size_out) > +{ > + const CHAR8 * const base = image_base; > + const struct DosFileHeader * dos = (const void*) base; > + const struct PeHeader * pe; > + const UINTN name_len = strlen(section_name); > + UINTN offset; > + > + if ( base == NULL ) > + return NULL; > + > + if ( memcmp(dos->Magic, "MZ", 2) != 0 ) > + return NULL; > + > + pe = (const void *) &base[dos->ExeHeader]; > + if ( memcmp(pe->Magic, "PE\0\0", 4) != 0 ) > + return NULL; > + > + /* PE32+ Subsystem type */ > + if (pe->FileHeader.Machine != PE_HEADER_MACHINE_X64 > + && pe->FileHeader.Machine != PE_HEADER_MACHINE_ARM64 > + && pe->FileHeader.Machine != PE_HEADER_MACHINE_I386) > + return NULL; I don't think i386 should be recognized here, and of the two other ones only the one matching the current target architecture should be. > + if ( pe->FileHeader.NumberOfSections > 96 ) > + return NULL; What's this 96 about? Overall I think it might help if this PE parsing code (if UEFI doesn't offer a protocol to do it for us) was put into its own source file. I also wonder if it wouldn't better be optional (i.e. depend on a Kconfig option). > @@ -968,6 +1100,21 @@ static void __init setup_efi_pci(void) > efi_bs->FreePool(handles); > } > > +static bool __init efi_secure_boot(void) > +{ > + static const EFI_GUID global_guid = EFI_GLOBAL_VARIABLE; > + uint8_t buf[8]; > + UINTN size = sizeof(buf); > + > + if ( efi_rs->GetVariable(L"SecureBoot", (EFI_GUID *)&global_guid, NULL, &size, buf) != EFI_SUCCESS ) > + return false; > + > + if ( size != 1 ) > + return false; > + > + return buf[0] != 0; > +} I.e. "SecureBoot=N" still means "enabled"? > @@ -1249,9 +1402,19 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable) > /* Get the file system interface. */ > dir_handle = get_parent_handle(loaded_image, &file_name); > > - /* Read and parse the config file. */ > - if ( !cfg_file_name ) > + if ( read_section(image_base, ".config", &cfg, NULL) ) > + { > + if ( secure ) > + PrintStr(L"Secure Boot enabled: "); > + PrintStr(L"Using unified config file\r\n"); > + } > + else if ( secure ) > + { > + blexit(L"Secure Boot enabled, but configuration not included."); > + } > + else if ( !cfg_file_name ) > { > + /* Read and parse the config file. */ > CHAR16 *tail; "secure" depending merely on an env var, how is this logic compatible with the shim model? You need to keep the other approach working. Also, considering kernel and initrd are embedded, is there really a strict need for a config file? It would seem to me that you could boot the system fine without. > @@ -1303,27 +1466,47 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable) > efi_arch_cfg_file_early(dir_handle, section.s); > > option_str = split_string(name.s); > - read_file(dir_handle, s2w(&name), &kernel, option_str); > - efi_bs->FreePool(name.w); > > - if ( !EFI_ERROR(efi_bs->LocateProtocol(&shim_lock_guid, NULL, > - (void **)&shim_lock)) && > - (status = shim_lock->Verify(kernel.ptr, kernel.size)) != EFI_SUCCESS ) > - PrintErrMesg(L"Dom0 kernel image could not be verified", status); > - > - name.s = get_value(&cfg, section.s, "ramdisk"); > - if ( name.s ) > + if ( !read_section(image_base, ".kernel", &kernel, option_str) ) Once you know whether you're dealing with a "unified" image, you shouldn't have a need to make logic dependent upon read_section() finding a particular section: Either you find all of them (and don't even try to interpret respective config file settings), or you read everything from disk. > --- /dev/null > +++ b/xen/scripts/unify-xen > @@ -0,0 +1,68 @@ > +#!/bin/bash > +# Merge a Linux kernel, initrd and commandline into xen.efi to produce a single signed > +# EFI executable. > +# > +# turn off "expressions don't expand in single quotes" > +# and "can't follow non-constant sources" > +# shellcheck disable=SC2016 disable=SC1090 What are these three lines about? > +set -e -o pipefail > +export LC_ALL=C > + > +die() { echo "$@" >&2 ; exit 1 ; } > +warn() { echo "$@" >&2 ; } > +debug() { [ "$VERBOSE" == 1 ] && echo "$@" >&2 ; } > + > +cleanup() { > + rm -rf "$TMP" > +} > + > +TMP=$(mktemp -d) > +TMP_MOUNT=n > +trap cleanup EXIT > + > +######################################## > + > +# Usage > +# unify xen.efi xen.cfg bzimage initrd > +# Xen goes up to a pad at 00400000 "pad at 00400000"? > +XEN="$1" > +CONFIG="$2" > +KERNEL="$3" > +RAMDISK="$4" What about ucode and xsm policy? > +# --change-section-vma .config=0x0500000 \ > +# --change-section-vma .kernel=0x0510000 \ > +# --change-section-vma .ramdisk=0x3000000 \ > + > +objcopy \ > + --add-section .kernel="$KERNEL" \ > + --add-section .ramdisk="$RAMDISK" \ > + --add-section .config="$CONFIG" \ > + --change-section-vma .config=0xffff82d041000000 \ > + --change-section-vma .kernel=0xffff82d041010000 \ > + --change-section-vma .ramdisk=0xffff82d042000000 \ Of course these hard coded numbers will be eliminated in the long run? > + "$XEN" \ > + "$TMP/xen.efi" \ > +|| die "$TMP/xen.efi: unable to create" > + > +KEY_ENGINE="" > +KEY="/etc/safeboot/signing.key" > +CERT="/etc/safeboot/cert.pem" > + > +for try in 1 2 3 ; do > + warn "$TMP/xen.efi: Signing (ignore warnings about gaps)" > + sbsign.safeboot \ > + $KEY_ENGINE \ > + --key "$KEY" \ > + --cert "$CERT" \ > + --output "xen.signed.efi" \ > + "$TMP/xen.efi" \ > + && break > + > + if [ "$try" == 3 ]; then > + die "xen.signed.efi: failed after $try tries" > + fi > + > + warn "$OUTDIR/linux.efi: signature failed! Try $try." > +done Why the retries? (Also leftover "linux.efi" in the warning?) Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 08:20:43 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 08:20:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3b8b-0004OT-50; Thu, 06 Aug 2020 08:20:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3b8Z-0004OO-Fj for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 08:20:31 +0000 X-Inumbo-ID: 7526d188-3049-4643-836c-879667853536 Received: from mail-lj1-x242.google.com (unknown [2a00:1450:4864:20::242]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7526d188-3049-4643-836c-879667853536; Thu, 06 Aug 2020 08:20:30 +0000 (UTC) Received: by mail-lj1-x242.google.com with SMTP id g6so38115035ljn.11 for ; Thu, 06 Aug 2020 01:20:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=N/jRCuLrGIw0wydT6IPDn4A6ZllL+0k+MGioxejrhJg=; b=fb7bgxh3WV0Rcl9k4cctFwuf8nuNzqfQIxqe9CJES3R+MIqBGqEcE9jQVyD1pG26Wu OpKCrq0ImOqeeghZTvuikFf/qGKLFz62ohIoiQMVuVR9zNHDCzm7qGgQx1MdY0UFv1dE B4MtP6bCZNr/rhs/qRZdpH45ugKhAuXLqPLB21zwGT+L/bA1EP3W4L2A+IWIDAK1YMDD nQL8Y0ViPx3nzzqyvrquYcMySq6RPjK4cgkLQSyZ9Xx1xUIJouBo1ZS5TTX93FzIqp39 wl5p2wzHWTgxepH3av3pZ6uUHjxmg7k2udQdIvlDb/KwllQZk039+tzn3rQMW3bxSBhJ 9+WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=N/jRCuLrGIw0wydT6IPDn4A6ZllL+0k+MGioxejrhJg=; b=TYgzf0ODywyz1z038Nghyv8joEdURViGBC0DUdoHeFrqMg0vah27O9gAUI9EWvsRQJ Ax7/bcCZ0yGUmt5Wf6W196Th8q3Gns/9ftTyRiBUcMegSL/5Cy6w34uKEqfjztdCAaKK 0qGibS8vZBDD9I8V7f8wIhQrukg34vGAO/y8eZMAfhWlGU+DOL80cymVvXLCGJMoBFdD rjL1Q3pQVzMN7zwsO6s6OqmPj+qnPSpQOS9UMG3/+DVdPJldGipg2NyRuHKHhbaiUYJZ H5XtmdtiP12KXeKGwDB2fzQ9/A2SerzyE/bNPIIjfTf7cTMMmAIzrERPTIvp2jT1C8MU taag== X-Gm-Message-State: AOAM533gKvD691QgS147al1cLr8Y76NiDhYm2VCGD9JN4I1POTdy1LGy SyvmjHNx/lidyGo2OTSv5C8= X-Google-Smtp-Source: ABdhPJxBFTu29BeH2Ek58cpSwUhh14eMMNKF4cfifP4cm5VociUQNlxXx824iD0EeJNetUPazqkYhQ== X-Received: by 2002:a2e:850b:: with SMTP id j11mr3073243lji.254.1596702028899; Thu, 06 Aug 2020 01:20:28 -0700 (PDT) Received: from [192.168.1.2] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id i19sm2371150lfi.14.2020.08.06.01.20.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2020 01:20:28 -0700 (PDT) Subject: Re: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common To: Andrew Cooper , xen-devel@lists.xenproject.org References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-2-git-send-email-olekstysh@gmail.com> <57ab62fb-048f-44ae-f815-9d5054457eb9@citrix.com> From: Oleksandr Message-ID: <863748b5-f4f4-b240-b29a-a54d64b7a04e@gmail.com> Date: Thu, 6 Aug 2020 11:20:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <57ab62fb-048f-44ae-f815-9d5054457eb9@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Tian , Stefano Stabellini , Julien Grall , Jan Beulich , Wei Liu , Paul Durrant , Tim Deegan , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Julien Grall , Jun Nakajima , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 05.08.20 19:15, Andrew Cooper wrote: Hi Andrew > On 03/08/2020 19:21, Oleksandr Tyshchenko wrote: >> diff --git a/xen/common/Makefile b/xen/common/Makefile >> index 06881d0..f6fc3f8 100644 >> --- a/xen/common/Makefile >> +++ b/xen/common/Makefile >> @@ -70,6 +70,7 @@ extra-y := symbols-dummy.o >> >> obj-$(CONFIG_COVERAGE) += coverage/ >> obj-y += sched/ >> +obj-$(CONFIG_IOREQ_SERVER) += hvm/ >> obj-$(CONFIG_UBSAN) += ubsan/ >> >> obj-$(CONFIG_NEEDS_LIBELF) += libelf/ >> diff --git a/xen/common/hvm/Makefile b/xen/common/hvm/Makefile >> new file mode 100644 >> index 0000000..326215d >> --- /dev/null >> +++ b/xen/common/hvm/Makefile >> @@ -0,0 +1 @@ >> +obj-y += ioreq.o >> diff --git a/xen/common/hvm/ioreq.c b/xen/common/hvm/ioreq.c >> new file mode 100644 >> index 0000000..7e1fa23 >> --- /dev/null >> +++ b/xen/common/hvm/ioreq.c >> > HVM is an internal detail of arch specific code.  It should not escape > into common code. > > From x86's point of view, there is nothing conceptually wrong with > having an IOREQ server for PV guests, although it is very unlikely at > this point that adding support would be a good use of time. Got it. > Please make this into a proper top-level common set of functionality. ok. -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Thu Aug 06 08:27:51 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 08:27:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3bFV-0004bT-TN; Thu, 06 Aug 2020 08:27:41 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3bFU-0004bO-TD for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 08:27:40 +0000 X-Inumbo-ID: d8da35c5-b3de-460b-8bd4-fd3a927bdfea Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d8da35c5-b3de-460b-8bd4-fd3a927bdfea; Thu, 06 Aug 2020 08:27:39 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8B12CAB9F; Thu, 6 Aug 2020 08:27:55 +0000 (UTC) Subject: Re: EFI executable corruption when live patching is turned off To: Andrew Cooper References: <3TMd7J2u5gCA8ouIG_Xfcw7s5JKMG06XsDIesEB3Fi9htUJ43Lfl057wXohlpCHcszqoCmicpIlneEDO26ZqT8QfC2Y39VxBuqD3nS1j5Q4=@trmm.net> From: Jan Beulich Message-ID: <676d3a8f-fb65-31d7-1da8-983e226145b7@suse.com> Date: Thu, 6 Aug 2020 10:27:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Xen-devel , Trammell Hudson , Ross Lagerwall , Konrad Rzeszutek Wilk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 05.08.2020 20:30, Andrew Cooper wrote: > On 05/08/2020 19:19, Trammell Hudson wrote: >> When building xen from head with almost any combination of options, the resulting xen.efi seems properly formed. When CONFIG_LIVEPATCH is turned off, however, the resulting xen.efi is corrupted in some way and binutils no longer wants to work with it: >> >> ~/build/xen-clean/xen$ git rev-parse HEAD >> 81fd0d3ca4b2cd309403c6e8da662c325dd35750 >> ~/build/xen-clean/xen$ diff .config.orig .config >> 71,72c71 >> < CONFIG_LIVEPATCH=y >> < CONFIG_FAST_SYMBOL_LOOKUP=y >> --- >>> # CONFIG_LIVEPATCH is not set >> 105a105 >>> # CONFIG_COVERAGE is not set >> ~/build/xen-clean/xen$ objcopy xen-orig.efi test.efi >> ~/build/xen-clean/xen$ objcopy xen.efi test.efi >> objcopy: test.efi: Data Directory size (1c) exceeds space left in section (18) >> objcopy: test.efi: error copying private BFD data: file in wrong format >> ~/build/xen-clean/xen$ objcopy --version | head -1 >> GNU objcopy (GNU Binutils for Ubuntu) 2.34 >> >> >> I spent most of today unsuccessfully trying to figure out what was different between the builds (on multiple build host OS with different binutils), so I'm hoping that perhaps someone else has seen this problem. > > CC'ing appropriate maintainers. > > The difference caused by CONFIG_LIVEPATCH will probably be the logic to > embed the GNU BuildID, which for xen.efi takes a trip through .bin/.ihex > immediately prior to the final link. The build ID gets added independent of LIVEPATCH; aiui it's merely a prereq for it. In any event this wouldn't be an excuse: We don't fiddle with the binary after it was created by ld, so I can't help thinking this is a binutils bug. I'll look into this more closely, but initial experiments produce errors different from the ones Trammell has reported (albeit I'm using 2.35, not 2.34, in case this makes a difference). Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 09:03:03 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 09:03:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3bnV-0007yv-Ir; Thu, 06 Aug 2020 09:02:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3bnT-0007yq-NM for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 09:02:47 +0000 X-Inumbo-ID: c5c4606a-71d6-46e4-924c-ee61cb5b1a85 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c5c4606a-71d6-46e4-924c-ee61cb5b1a85; Thu, 06 Aug 2020 09:02:46 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 36E9EB1AF; Thu, 6 Aug 2020 09:03:03 +0000 (UTC) To: "xen-devel@lists.xenproject.org" From: Jan Beulich Subject: [PATCH 0/4] build: corrections to .init.o generation logic Message-ID: <305c2532-408a-9f78-61fe-c90a2e86eb8e@suse.com> Date: Thu, 6 Aug 2020 11:02:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , George Dunlap , Andrew Cooper , Anthony Perard , Ian Jackson , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Initially I merely noticed the regression addressed by the 1st patch, but looking more closely revealed further deficiencies. After having moved the FIXME in patch 3 I couldn't resist and address that issue at least partly (patch 4), seeing that three and a half years have passed and nothing was done to improve the situation. 1: build: work around bash issue 2: build: correctly report non-empty section sizes upon .o -> .init.o conversion 3: build: also check for empty .bss.* in .o -> .init.o conversion 4: EFI: free unused boot mem in at least some cases Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 09:04:45 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 09:04:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3bpN-00087P-2J; Thu, 06 Aug 2020 09:04:45 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3bpL-00087H-PO for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 09:04:43 +0000 X-Inumbo-ID: e331891c-c29d-4291-932e-303f8e4e7829 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e331891c-c29d-4291-932e-303f8e4e7829; Thu, 06 Aug 2020 09:04:42 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 577F1AD88; Thu, 6 Aug 2020 09:04:59 +0000 (UTC) Subject: [PATCH 1/4] build: work around bash issue From: Jan Beulich To: "xen-devel@lists.xenproject.org" References: <305c2532-408a-9f78-61fe-c90a2e86eb8e@suse.com> Message-ID: Date: Thu, 6 Aug 2020 11:04:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <305c2532-408a-9f78-61fe-c90a2e86eb8e@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , George Dunlap , Andrew Cooper , Anthony Perard , Ian Jackson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Older bash fails to honor "set -e" for certain built-in commands ("while" here), despite the command's status correctly bein non-zero. The subsequent objcopy invocation now being separated by a semicolon results in no failure. Insert an explicit "exit" (replacing ; by && ought to be another possible workaround). Fixes: e321576f4047 ("xen/build: start using if_changed") Signed-off-by: Jan Beulich --- I've done a pretty light-weight audit of possible further instances of this issue, but didn't find any. --- a/xen/Rules.mk +++ b/xen/Rules.mk @@ -193,7 +193,7 @@ define cmd_obj_init_o echo "Error: size of $<:$$name is 0x$$sz" >&2; \ exit $$(expr $$idx + 1);; \ esac; \ - done; \ + done || exit $$?; \ $(OBJCOPY) $(foreach s,$(SPECIAL_DATA_SECTIONS),--rename-section .$(s)=.init.$(s)) $< $@ endef From xen-devel-bounces@lists.xenproject.org Thu Aug 06 09:05:17 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 09:05:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3bpt-0008BA-Ba; Thu, 06 Aug 2020 09:05:17 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3bps-0008B2-9j for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 09:05:16 +0000 X-Inumbo-ID: 30b871ee-f5b2-49bf-980a-550ffac0fff5 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 30b871ee-f5b2-49bf-980a-550ffac0fff5; Thu, 06 Aug 2020 09:05:15 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 12D80AC50; Thu, 6 Aug 2020 09:05:32 +0000 (UTC) Subject: [PATCH 2/4] build: correctly report non-empty section sizes upon .o -> .init.o conversion From: Jan Beulich To: "xen-devel@lists.xenproject.org" References: <305c2532-408a-9f78-61fe-c90a2e86eb8e@suse.com> Message-ID: <5fcb47ec-4a0e-99a2-c548-f42ec1cc8030@suse.com> Date: Thu, 6 Aug 2020 11:05:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <305c2532-408a-9f78-61fe-c90a2e86eb8e@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" The originally used sed expression converted not just multiple leading zeroes (as intended), but also trailing ones, rendering the error message somewhat confusing. Collapse zeroes in just the one place where we need them collapsed, and leave objdump's output as is for all other purposes. Fixes: 48115d14743e ("Move more kernel decompression bits to .init.* sections") Signed-off-by: Jan Beulich --- a/xen/Rules.mk +++ b/xen/Rules.mk @@ -185,11 +185,11 @@ cmd_cc_o_S = $(CC) $(a_flags) -c $< -o $ quiet_cmd_obj_init_o = INIT_O $@ define cmd_obj_init_o - $(OBJDUMP) -h $< | sed -n '/[0-9]/{s,00*,0,g;p;}' | while read idx name sz rest; do \ + $(OBJDUMP) -h $< | while read idx name sz rest; do \ case "$$name" in \ .*.local) ;; \ .text|.text.*|.data|.data.*|.bss) \ - test $$sz != 0 || continue; \ + test $$(echo $$sz | sed 's,00*,0,') != 0 || continue; \ echo "Error: size of $<:$$name is 0x$$sz" >&2; \ exit $$(expr $$idx + 1);; \ esac; \ From xen-devel-bounces@lists.xenproject.org Thu Aug 06 09:05:47 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 09:05:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3bqM-0008Ea-Kf; Thu, 06 Aug 2020 09:05:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3bqL-0008EN-Fy for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 09:05:45 +0000 X-Inumbo-ID: 6749b8c9-f48b-4ee7-bec9-6f9092d053bc Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6749b8c9-f48b-4ee7-bec9-6f9092d053bc; Thu, 06 Aug 2020 09:05:44 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 424D0AD63; Thu, 6 Aug 2020 09:06:01 +0000 (UTC) Subject: [PATCH 3/4] build: also check for empty .bss.* in .o -> .init.o conversion From: Jan Beulich To: "xen-devel@lists.xenproject.org" References: <305c2532-408a-9f78-61fe-c90a2e86eb8e@suse.com> Message-ID: Date: Thu, 6 Aug 2020 11:05:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <305c2532-408a-9f78-61fe-c90a2e86eb8e@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" We're gaining such sections, and like .text.* and .data.* they shouldn't be present in objects subject to automatic to-init conversion. Oddly enough for quite some time we did have an instance breaking this rule, which gets fixed at this occasion, by breaking out the EFI boot allocator functions into its own translation unit. Fixes: c5b9805bc1f7 ("efi: create new early memory allocator") Signed-off-by: Jan Beulich --- This likely has a (weak) dependency on "x86/EFI: sanitize build logic" sent several weeks ago, due to the new source file added, as explicit dependencies upon the individual objects in x86/Makefile go away there. --- a/xen/Makefile +++ b/xen/Makefile @@ -355,7 +355,7 @@ $(TARGET): delete-unfresh-files $(MAKE) -C tools $(MAKE) -f $(BASEDIR)/Rules.mk include/xen/compile.h [ -e include/asm ] || ln -sf asm-$(TARGET_ARCH) include/asm - [ -e arch/$(TARGET_ARCH)/efi ] && for f in boot.c runtime.c compat.c efi.h;\ + [ -e arch/$(TARGET_ARCH)/efi ] && for f in $$(cd common/efi; echo *.[ch]); \ do test -r arch/$(TARGET_ARCH)/efi/$$f || \ ln -nsf ../../../common/efi/$$f arch/$(TARGET_ARCH)/efi/; \ done; \ --- a/xen/Rules.mk +++ b/xen/Rules.mk @@ -188,7 +188,7 @@ define cmd_obj_init_o $(OBJDUMP) -h $< | while read idx name sz rest; do \ case "$$name" in \ .*.local) ;; \ - .text|.text.*|.data|.data.*|.bss) \ + .text|.text.*|.data|.data.*|.bss|.bss.*) \ test $$(echo $$sz | sed 's,00*,0,') != 0 || continue; \ echo "Error: size of $<:$$name is 0x$$sz" >&2; \ exit $$(expr $$idx + 1);; \ --- a/xen/arch/arm/efi/Makefile +++ b/xen/arch/arm/efi/Makefile @@ -1,4 +1,4 @@ CFLAGS-y += -fshort-wchar -obj-y += boot.init.o runtime.o +obj-y += boot.init.o ebmalloc.o runtime.o obj-$(CONFIG_ACPI) += efi-dom0.init.o --- a/xen/arch/x86/efi/Makefile +++ b/xen/arch/x86/efi/Makefile @@ -8,7 +8,7 @@ cmd_objcopy_o_ihex = $(OBJCOPY) -I ihex boot.init.o: buildid.o -EFIOBJ := boot.init.o compat.o runtime.o +EFIOBJ := boot.init.o ebmalloc.o compat.o runtime.o $(call cc-option-add,cflags-stack-boundary,CC,-mpreferred-stack-boundary=4) $(EFIOBJ): CFLAGS-stack-boundary := $(cflags-stack-boundary) --- a/xen/common/efi/boot.c +++ b/xen/common/efi/boot.c @@ -112,7 +112,6 @@ static CHAR16 *FormatDec(UINT64 Val, CHA static CHAR16 *FormatHex(UINT64 Val, UINTN Width, CHAR16 *Buffer); static void DisplayUint(UINT64 Val, INTN Width); static CHAR16 *wstrcpy(CHAR16 *d, const CHAR16 *s); -static void noreturn blexit(const CHAR16 *str); static void PrintErrMesg(const CHAR16 *mesg, EFI_STATUS ErrCode); static char *get_value(const struct file *cfg, const char *section, const char *item); @@ -155,56 +154,6 @@ static CHAR16 __initdata newline[] = L"\ #define PrintStr(s) StdOut->OutputString(StdOut, s) #define PrintErr(s) StdErr->OutputString(StdErr, s) -#ifdef CONFIG_ARM -/* - * TODO: Enable EFI boot allocator on ARM. - * This code can be common for x86 and ARM. - * Things TODO on ARM before enabling ebmalloc: - * - estimate required EBMALLOC_SIZE value, - * - where (in which section) ebmalloc_mem[] should live; if in - * .bss.page_aligned, as it is right now, then whole BSS zeroing - * have to be disabled in xen/arch/arm/arm64/head.S; though BSS - * should be initialized somehow before use of variables living there, - * - use ebmalloc() in ARM/common EFI boot code, - * - call free_ebmalloc_unused_mem() somewhere in init code. - */ -#define EBMALLOC_SIZE MB(0) -#else -#define EBMALLOC_SIZE MB(1) -#endif - -static char __section(".bss.page_aligned") __aligned(PAGE_SIZE) - ebmalloc_mem[EBMALLOC_SIZE]; -static unsigned long __initdata ebmalloc_allocated; - -/* EFI boot allocator. */ -static void __init __maybe_unused *ebmalloc(size_t size) -{ - void *ptr = ebmalloc_mem + ebmalloc_allocated; - - ebmalloc_allocated += ROUNDUP(size, sizeof(void *)); - - if ( ebmalloc_allocated > sizeof(ebmalloc_mem) ) - blexit(L"Out of static memory\r\n"); - - return ptr; -} - -static void __init __maybe_unused free_ebmalloc_unused_mem(void) -{ -#if 0 /* FIXME: Putting a hole in the BSS breaks the IOMMU mappings for dom0. */ - unsigned long start, end; - - start = (unsigned long)ebmalloc_mem + PAGE_ALIGN(ebmalloc_allocated); - end = (unsigned long)ebmalloc_mem + sizeof(ebmalloc_mem); - - destroy_xen_mappings(start, end); - init_xenheap_pages(__pa(start), __pa(end)); - - printk(XENLOG_INFO "Freed %lukB unused BSS memory\n", (end - start) >> 10); -#endif -} - /* * Include architecture specific implementation here, which references the * static globals defined above. @@ -321,7 +270,7 @@ static bool __init match_guid(const EFI_ !memcmp(guid1->Data4, guid2->Data4, sizeof(guid1->Data4)); } -static void __init noreturn blexit(const CHAR16 *str) +void __init noreturn blexit(const CHAR16 *str) { if ( str ) PrintStr((CHAR16 *)str); --- /dev/null +++ b/xen/common/efi/ebmalloc.c @@ -0,0 +1,52 @@ +#include "efi.h" +#include + +#ifdef CONFIG_ARM +/* + * TODO: Enable EFI boot allocator on ARM. + * This code can be common for x86 and ARM. + * Things TODO on ARM before enabling ebmalloc: + * - estimate required EBMALLOC_SIZE value, + * - where (in which section) ebmalloc_mem[] should live; if in + * .bss.page_aligned, as it is right now, then whole BSS zeroing + * have to be disabled in xen/arch/arm/arm64/head.S; though BSS + * should be initialized somehow before use of variables living there, + * - use ebmalloc() in ARM/common EFI boot code, + * - call free_ebmalloc_unused_mem() somewhere in init code. + */ +#define EBMALLOC_SIZE MB(0) +#else +#define EBMALLOC_SIZE MB(1) +#endif + +static char __section(".bss.page_aligned") __aligned(PAGE_SIZE) + ebmalloc_mem[EBMALLOC_SIZE]; +static unsigned long __initdata ebmalloc_allocated; + +/* EFI boot allocator. */ +void __init *ebmalloc(size_t size) +{ + void *ptr = ebmalloc_mem + ebmalloc_allocated; + + ebmalloc_allocated += ROUNDUP(size, sizeof(void *)); + + if ( ebmalloc_allocated > sizeof(ebmalloc_mem) ) + blexit(L"Out of static memory\r\n"); + + return ptr; +} + +void __init free_ebmalloc_unused_mem(void) +{ +#if 0 /* FIXME: Putting a hole in the BSS breaks the IOMMU mappings for dom0. */ + unsigned long start, end; + + start = (unsigned long)ebmalloc_mem + PAGE_ALIGN(ebmalloc_allocated); + end = (unsigned long)ebmalloc_mem + sizeof(ebmalloc_mem); + + destroy_xen_mappings(start, end); + init_xenheap_pages(__pa(start), __pa(end)); + + printk(XENLOG_INFO "Freed %lukB unused BSS memory\n", (end - start) >> 10); +#endif +} --- a/xen/common/efi/efi.h +++ b/xen/common/efi/efi.h @@ -40,4 +40,10 @@ extern UINT64 efi_boot_max_var_store_siz extern UINT64 efi_apple_properties_addr; extern UINTN efi_apple_properties_len; +void noreturn blexit(const CHAR16 *str); + const CHAR16 *wmemchr(const CHAR16 *s, CHAR16 c, UINTN n); + +/* EFI boot allocator. */ +void *ebmalloc(size_t size); +void free_ebmalloc_unused_mem(void); From xen-devel-bounces@lists.xenproject.org Thu Aug 06 09:06:10 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 09:06:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3bqj-0008J7-Up; Thu, 06 Aug 2020 09:06:09 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3bqi-0008I9-B3 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 09:06:08 +0000 X-Inumbo-ID: 75dab13f-ff1d-496c-afa3-bab25eb6db47 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 75dab13f-ff1d-496c-afa3-bab25eb6db47; Thu, 06 Aug 2020 09:06:07 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 276C7B1AA; Thu, 6 Aug 2020 09:06:24 +0000 (UTC) Subject: [PATCH 4/4] EFI: free unused boot mem in at least some cases From: Jan Beulich To: "xen-devel@lists.xenproject.org" References: <305c2532-408a-9f78-61fe-c90a2e86eb8e@suse.com> Message-ID: <4e2d0d0a-9d85-d704-5d61-ae9efc69256a@suse.com> Date: Thu, 6 Aug 2020 11:06:09 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <305c2532-408a-9f78-61fe-c90a2e86eb8e@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Address at least the primary reason why 52bba67f8b87 ("efi/boot: Don't free ebmalloc area at all") was put in place: Make xen_in_range() aware of the freed range. This is in particular relevant for EFI-enabled builds not actually running on EFI, as the entire range will be unused in this case. Signed-off-by: Jan Beulich --- The remaining issue could be addressed too, by making the area 2M in size and 2M-aligned. --- a/xen/arch/x86/efi/stub.c +++ b/xen/arch/x86/efi/stub.c @@ -52,6 +52,12 @@ bool efi_enabled(unsigned int feature) void __init efi_init_memory(void) { } +bool __hwdom_init efi_boot_mem_unused(unsigned long *start, unsigned long *end) +{ + *start = *end = (unsigned long)_end; + return false; +} + void efi_update_l4_pgtable(unsigned int l4idx, l4_pgentry_t l4e) { } bool efi_rs_using_pgtables(void) --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -608,7 +608,7 @@ static void __init kexec_reserve_area(st #endif } -static inline bool using_2M_mapping(void) +bool using_2M_mapping(void) { return !l1_table_offset((unsigned long)__2M_text_end) && !l1_table_offset((unsigned long)__2M_rodata_start) && @@ -1970,7 +1970,7 @@ int __hwdom_init xen_in_range(unsigned l paddr_t start, end; int i; - enum { region_s3, region_ro, region_rw, nr_regions }; + enum { region_s3, region_ro, region_rw, region_bss, nr_regions }; static struct { paddr_t s, e; } xen_regions[nr_regions] __hwdom_initdata; @@ -1994,7 +1994,14 @@ int __hwdom_init xen_in_range(unsigned l xen_regions[region_ro].e = __pa(&__2M_rodata_end); /* hypervisor .data + .bss */ xen_regions[region_rw].s = __pa(&__2M_rwdata_start); - xen_regions[region_rw].e = __pa(&__2M_rwdata_end); + if ( efi_boot_mem_unused(&start, &end) ) + { + xen_regions[region_rw].e = __pa(start); + xen_regions[region_bss].s = __pa(end); + xen_regions[region_bss].e = __pa(&__2M_rwdata_end); + } + else + xen_regions[region_rw].e = __pa(&__2M_rwdata_end); } start = (paddr_t)mfn << PAGE_SHIFT; --- a/xen/common/efi/ebmalloc.c +++ b/xen/common/efi/ebmalloc.c @@ -1,5 +1,9 @@ #include "efi.h" #include +#include +#ifdef CONFIG_X86 +#include +#endif #ifdef CONFIG_ARM /* @@ -21,7 +25,7 @@ static char __section(".bss.page_aligned") __aligned(PAGE_SIZE) ebmalloc_mem[EBMALLOC_SIZE]; -static unsigned long __initdata ebmalloc_allocated; +static unsigned long __read_mostly ebmalloc_allocated; /* EFI boot allocator. */ void __init *ebmalloc(size_t size) @@ -36,17 +40,32 @@ void __init *ebmalloc(size_t size) return ptr; } +bool __hwdom_init efi_boot_mem_unused(unsigned long *start, unsigned long *end) +{ + *start = (unsigned long)ebmalloc_mem + PAGE_ALIGN(ebmalloc_allocated); + *end = (unsigned long)ebmalloc_mem + sizeof(ebmalloc_mem); + + return *start < *end; +} + void __init free_ebmalloc_unused_mem(void) { -#if 0 /* FIXME: Putting a hole in the BSS breaks the IOMMU mappings for dom0. */ unsigned long start, end; - start = (unsigned long)ebmalloc_mem + PAGE_ALIGN(ebmalloc_allocated); - end = (unsigned long)ebmalloc_mem + sizeof(ebmalloc_mem); +#ifdef CONFIG_X86 + /* FIXME: Putting a hole in .bss would shatter the large page mapping. */ + if ( using_2M_mapping() ) + { + ebmalloc_allocated = sizeof(ebmalloc_mem); + return; + } +#endif + + if ( !efi_boot_mem_unused(&start, &end) ) + return; destroy_xen_mappings(start, end); init_xenheap_pages(__pa(start), __pa(end)); printk(XENLOG_INFO "Freed %lukB unused BSS memory\n", (end - start) >> 10); -#endif } --- a/xen/include/asm-x86/setup.h +++ b/xen/include/asm-x86/setup.h @@ -9,6 +9,8 @@ extern const char __2M_rodata_start[], _ extern char __2M_init_start[], __2M_init_end[]; extern char __2M_rwdata_start[], __2M_rwdata_end[]; +bool using_2M_mapping(void); + extern unsigned long xenheap_initial_phys_start; extern uint64_t boot_tsc_stamp; --- a/xen/include/xen/efi.h +++ b/xen/include/xen/efi.h @@ -33,6 +33,7 @@ struct compat_pf_efi_runtime_call; bool efi_enabled(unsigned int feature); void efi_init_memory(void); +bool efi_boot_mem_unused(unsigned long *start, unsigned long *end); bool efi_rs_using_pgtables(void); unsigned long efi_get_time(void); void efi_halt_system(void); From xen-devel-bounces@lists.xenproject.org Thu Aug 06 09:07:25 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 09:07:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3brw-0008TA-9s; Thu, 06 Aug 2020 09:07:24 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3brv-0008T3-Hr for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 09:07:23 +0000 X-Inumbo-ID: fcc5e954-3ff2-4fc6-b734-cc3f96047b3d Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fcc5e954-3ff2-4fc6-b734-cc3f96047b3d; Thu, 06 Aug 2020 09:07:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=JRMwKKEpbRfbvlV3oeNr75bWFNzkmlb2XMoM7s4VMVk=; b=Pk4EOddwR79+fK7wRoQ4HWv+Qi Ya6uWnB4A7OIt0hr2OTnEor+GR+68LkmbKanV/ewE+jqzVenkgdPmmp/Buvo/4lEa3/klkwlUC05O yV7TF3+BryftkfrtunOEinwEPjupMW5MDnu5TGWIj2zYoegI/Mr9CXEvk0Ogx86QYZKs=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3brt-0005vu-0U; Thu, 06 Aug 2020 09:07:21 +0000 Received: from [54.239.6.185] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k3brs-00037n-PQ; Thu, 06 Aug 2020 09:07:20 +0000 Subject: Re: [PATCH 1/4] build: work around bash issue To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <305c2532-408a-9f78-61fe-c90a2e86eb8e@suse.com> From: Julien Grall Message-ID: Date: Thu, 6 Aug 2020 10:07:18 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , George Dunlap , Andrew Cooper , Anthony Perard , Ian Jackson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Hi Jan, On 06/08/2020 10:04, Jan Beulich wrote: > Older bash fails to honor "set -e" for certain built-in commands "Older" is pretty vague. May I ask the exact version you run into the issue? > ("while" here), despite the command's status correctly bein non-zero. > The subsequent objcopy invocation now being separated by a semicolon > results in no failure. Insert an explicit "exit" (replacing ; by && > ought to be another possible workaround). > > Fixes: e321576f4047 ("xen/build: start using if_changed") > Signed-off-by: Jan Beulich > --- > I've done a pretty light-weight audit of possible further instances of > this issue, but didn't find any. > > --- a/xen/Rules.mk > +++ b/xen/Rules.mk > @@ -193,7 +193,7 @@ define cmd_obj_init_o > echo "Error: size of $<:$$name is 0x$$sz" >&2; \ > exit $$(expr $$idx + 1);; \ > esac; \ > - done; \ > + done || exit $$?; \ > $(OBJCOPY) $(foreach s,$(SPECIAL_DATA_SECTIONS),--rename-section .$(s)=.init.$(s)) $< $@ > endef > > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Aug 06 09:14:49 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 09:14:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3bz1-0000zY-2o; Thu, 06 Aug 2020 09:14:43 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3bz0-0000zQ-1p for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 09:14:42 +0000 X-Inumbo-ID: 119ba00f-d325-4d22-94fe-f57a7fb398de Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 119ba00f-d325-4d22-94fe-f57a7fb398de; Thu, 06 Aug 2020 09:14:41 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A9BC8AD75; Thu, 6 Aug 2020 09:14:57 +0000 (UTC) Subject: Re: [PATCH 1/4] build: work around bash issue To: Julien Grall References: <305c2532-408a-9f78-61fe-c90a2e86eb8e@suse.com> From: Jan Beulich Message-ID: Date: Thu, 6 Aug 2020 11:14:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , Anthony Perard , "xen-devel@lists.xenproject.org" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 06.08.2020 11:07, Julien Grall wrote: > On 06/08/2020 10:04, Jan Beulich wrote: >> Older bash fails to honor "set -e" for certain built-in commands > > "Older" is pretty vague. May I ask the exact version you run into the issue? If I knew in what version the issue got fixed, I'd have specified that version. I've observed it with 3.2.57(2). Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 09:17:42 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 09:17:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3c1t-00016c-Hj; Thu, 06 Aug 2020 09:17:41 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3c1s-00016X-GN for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 09:17:40 +0000 X-Inumbo-ID: b16f0903-b9ee-4fed-8855-6bd9964c2b6c Received: from userp2130.oracle.com (unknown [156.151.31.86]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b16f0903-b9ee-4fed-8855-6bd9964c2b6c; Thu, 06 Aug 2020 09:17:39 +0000 (UTC) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0769DMXU134762; Thu, 6 Aug 2020 09:17:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=1mPUi5W2MorAFmoBzG9tPbGD54xKE1Byrx1RzDX0UmU=; b=eKiFr4Bs/bpWdX6yLxeMc5sFEBJ30+bhMqjEFXaCXU9wW5n47PIATToBiWpr+CLVaKDP 8A0tZz0TZdkw0tEIcpW0won99EJYkQ61jOuiGMnuepmHxUSOsxqA5JJ5wKYcJVq9OHaq pBALBvxS0QXNV4kM/rwuYDhi3OakRkd3/PSjnbSO/1A48svKmA+oG131xfSZev+LJtub qaecgcJ+E6qYTHY8Lb+CsIAGpJ7PEWqQfkjE/RVUhkE/V9xIB61oP9mBuPunQR0qJtkJ 7UQpAp1LRsK/9rfQca8fG0SveJMrEtCLE+oBzPX+VjLOeCGIz1EAujV989TnlId5PiMo fg== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2130.oracle.com with ESMTP id 32r6gwssfh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 06 Aug 2020 09:17:29 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0769CwME158826; Thu, 6 Aug 2020 09:17:28 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3020.oracle.com with ESMTP id 32pdnvtwtd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 06 Aug 2020 09:17:28 +0000 Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0769HI56012706; Thu, 6 Aug 2020 09:17:18 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 06 Aug 2020 02:17:17 -0700 Date: Thu, 6 Aug 2020 12:17:09 +0300 From: Dan Carpenter To: Oleksandr Andrushchenko Subject: Re: [PATCH 2/6] drm/xen-front: Fix misused IS_ERR_OR_NULL checks Message-ID: <20200806091709.GU5493@kadam> References: <20200731125109.18666-1-andr2000@gmail.com> <20200731125109.18666-3-andr2000@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200731125109.18666-3-andr2000@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9704 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 mlxscore=0 bulkscore=0 adultscore=0 phishscore=0 malwarescore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008060065 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9704 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 spamscore=0 impostorscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 priorityscore=1501 phishscore=0 clxscore=1011 suspectscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008060065 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: jgross@suse.com, sstabellini@kernel.org, Oleksandr Andrushchenko , airlied@linux.ie, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, daniel@ffwll.ch, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Looks great! Thanks. Reviewed-by: Dan Carpenter regards, dan carpenter From xen-devel-bounces@lists.xenproject.org Thu Aug 06 09:20:35 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 09:20:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3c4b-0001uu-4C; Thu, 06 Aug 2020 09:20:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3c4Z-0001un-HE for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 09:20:27 +0000 X-Inumbo-ID: b54d2ec2-fc36-4caf-9fc3-9f162f6ac9ab Received: from userp2130.oracle.com (unknown [156.151.31.86]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b54d2ec2-fc36-4caf-9fc3-9f162f6ac9ab; Thu, 06 Aug 2020 09:20:26 +0000 (UTC) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0769DP4M134775; Thu, 6 Aug 2020 09:20:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : content-transfer-encoding : in-reply-to; s=corp-2020-01-29; bh=K6nnIq7KbMdGmwq3DRCgXsdqJJG+nAKIN0b+IcOgc+k=; b=VBCNZ0B6tMfR1rKyX72Att5NUO6if4UBo9dHYDl+0D3q1NcsaDvCWtVjbHrVRnGpz+Ud x+ihOlgeDyR0x8PKISxsN7Wi0fs5rpqTqv77K4/3mB4xa8FbFlAx9iXJJ4ZMJO6qom7y umDcAh0fQbfMZh7yUC7s9oHI3OQ4H1pkGd/yCX4uFpcF8WusdLnV5nfVpNiqj4xyY49D AqxiVxYwMXOT1eEQP9aq1XCh5vWufjALgF8rY86Br7SxI+DUP7f1hNi71z1q7WUMAvyk daIl/wf/W3yD2yONtZ7Sym3V7oP4TmG+WPmyJSLme8ucD0jSm14WEvh5Vaas/7mgW53G tg== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 32r6gwssvs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 06 Aug 2020 09:20:15 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0769Dnvf019978; Thu, 6 Aug 2020 09:20:15 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 32r6cv0q8m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 06 Aug 2020 09:20:14 +0000 Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 0769KB5b024041; Thu, 6 Aug 2020 09:20:11 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 06 Aug 2020 02:20:10 -0700 Date: Thu, 6 Aug 2020 12:20:02 +0300 From: Dan Carpenter To: Oleksandr Andrushchenko Subject: Re: [PATCH 2/6] drm/xen-front: Fix misused IS_ERR_OR_NULL checks Message-ID: <20200806092001.GV5493@kadam> References: <20200731125109.18666-1-andr2000@gmail.com> <20200731125109.18666-3-andr2000@gmail.com> <6d719ab2-d9f6-2c3c-8979-b12a4d10b96d@suse.com> <0ed5082f-0280-16c0-7410-f6a90262bcee@epam.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0ed5082f-0280-16c0-7410-f6a90262bcee@epam.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9704 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 bulkscore=0 spamscore=0 adultscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008060065 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9704 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 spamscore=0 impostorscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 priorityscore=1501 phishscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008060065 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: =?iso-8859-1?Q?J=FCrgen_Gro=DF?= , "sstabellini@kernel.org" , Oleksandr Andrushchenko , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "airlied@linux.ie" , "daniel@ffwll.ch" , "xen-devel@lists.xenproject.org" , "boris.ostrovsky@oracle.com" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Tue, Aug 04, 2020 at 06:35:20AM +0000, Oleksandr Andrushchenko wrote: > > On 8/4/20 9:12 AM, Jrgen Gro wrote: > > On 31.07.20 14:51, Oleksandr Andrushchenko wrote: > >> From: Oleksandr Andrushchenko > >> > >> The patch c575b7eeb89f: "drm/xen-front: Add support for Xen PV > >> display frontend" from Apr 3, 2018, leads to the following static > >> checker warning: > >> > >> drivers/gpu/drm/xen/xen_drm_front_gem.c:140 xen_drm_front_gem_create() > >> warn: passing zero to 'ERR_CAST' > >> > >> drivers/gpu/drm/xen/xen_drm_front_gem.c > >> 133 struct drm_gem_object *xen_drm_front_gem_create(struct drm_device *dev, > >> 134 size_t size) > >> 135 { > >> 136 struct xen_gem_object *xen_obj; > >> 137 > >> 138 xen_obj = gem_create(dev, size); > >> 139 if (IS_ERR_OR_NULL(xen_obj)) > >> 140 return ERR_CAST(xen_obj); > >> > >> Fix this and the rest of misused places with IS_ERR_OR_NULL in the > >> driver. > >> > >> Fixes: c575b7eeb89f: "drm/xen-front: Add support for Xen PV display frontend" > > > > Again forgot to Cc stable? > > I was just not sure if these minor fixes need to go the stable, but I will add Correct. It's still a bug because it's setting the error code incorrectly on the impossible path. But fortunately impossible things don't affect runtime. regards, dan carpenter From xen-devel-bounces@lists.xenproject.org Thu Aug 06 09:20:57 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 09:20:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3c53-0001xC-DW; Thu, 06 Aug 2020 09:20:57 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3c53-0001x5-0c for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 09:20:57 +0000 X-Inumbo-ID: af3654ad-1e12-45b0-a886-e162e0da5462 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id af3654ad-1e12-45b0-a886-e162e0da5462; Thu, 06 Aug 2020 09:20:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5e3m0Zlscfd31zIo7nfR61RD4dMVu7MuA4qU9LNhAhc=; b=sgC7MTsYB3mVT6bkXyYzrCzedI f9/EbhIC6O6Wn/AbFWj98SoFQCy2fvRYkA/if1soOSYcvttDwttpwn4NcUJ8pKM9CfxnoFiCpXQ5H /DjklIcZ+JDMw+ilkuZDpnXHwOeO+xV7H2dDfPckuX6Ovv0ktQBxtbVxn13GHE2otM0Q=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3c4y-0006Cq-BH; Thu, 06 Aug 2020 09:20:52 +0000 Received: from [54.239.6.185] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k3c4y-0003sh-2V; Thu, 06 Aug 2020 09:20:52 +0000 Subject: Re: [PATCH 1/4] build: work around bash issue To: Jan Beulich References: <305c2532-408a-9f78-61fe-c90a2e86eb8e@suse.com> From: Julien Grall Message-ID: <1a3325a8-a59a-7759-b7a9-9263652b429c@xen.org> Date: Thu, 6 Aug 2020 10:20:49 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , Anthony Perard , "xen-devel@lists.xenproject.org" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 06/08/2020 10:14, Jan Beulich wrote: > On 06.08.2020 11:07, Julien Grall wrote: >> On 06/08/2020 10:04, Jan Beulich wrote: >>> Older bash fails to honor "set -e" for certain built-in commands >> >> "Older" is pretty vague. May I ask the exact version you run into the issue? > > If I knew in what version the issue got fixed, I'd have specified > that version. Right, but this is not what I asked. What I requested is that you provide the version you observe the issue. This doesn't mean other versions are not affected, but at least it give us a clue where this can happen. > I've observed it with 3.2.57(2). Thank you. Please mention it in the commit message. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Aug 06 09:22:40 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 09:22:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3c6h-00027c-PO; Thu, 06 Aug 2020 09:22:39 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3c6g-00027W-IW for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 09:22:38 +0000 X-Inumbo-ID: e5ffe48a-864c-4d38-83c4-ed66759bb9ec Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e5ffe48a-864c-4d38-83c4-ed66759bb9ec; Thu, 06 Aug 2020 09:22:38 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 727E4B65C; Thu, 6 Aug 2020 09:22:54 +0000 (UTC) To: "xen-devel@lists.xenproject.org" From: Jan Beulich Subject: [PATCH 0/3] x86: M2P maintenance adjustments (step 1) Message-ID: Date: Thu, 6 Aug 2020 11:22:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" As pointed out by Andrew, maintaining the compat M2P when !PV32 (or when "pv=no-32" was given) is a pointless waste of memory. Do away with this, with a possible plan to subsequently use the compat instance instead of the native one in shim mode with a 32-bit guest (requiring more intrusive rework, in particular to delay setting up the M2P until the bitness of the client domain is known). 1: slightly re-arrange 32-bit handling in dom0_construct_pv() 2: don't maintain compat M2P when !PV32 3: don't override INVALID_M2P_ENTRY with SHARED_M2P_ENTRY Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 09:22:49 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 09:22:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3c6r-00028h-1Q; Thu, 06 Aug 2020 09:22:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3c6p-00028U-RM for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 09:22:47 +0000 X-Inumbo-ID: b88acdc7-d9ec-4d48-9f23-7750deab8776 Received: from mail-lj1-x241.google.com (unknown [2a00:1450:4864:20::241]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b88acdc7-d9ec-4d48-9f23-7750deab8776; Thu, 06 Aug 2020 09:22:46 +0000 (UTC) Received: by mail-lj1-x241.google.com with SMTP id v9so16475731ljk.6 for ; Thu, 06 Aug 2020 02:22:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=V5VGMK+6XYnjTworljWPVg5y65/T5eBThBfgObSPij8=; b=VFtMT4pLZY0A+hDD1z7wT3BhGaR5KORHbJlTl8u5Rr+nn8ZRQta4vqSCs8C6AyceRr 3q9vEq61PuUX/izqc+PAlomAS986fuZiIaOTLl6T28lp9l4WX3YEvTViAG3LXkp8Tm6m KqHrbg8gaySIL3THPiM7uBmqtEmXU1Ps1uUL/z5ChxThnNIpCWHVzqFnzkjscv9aSTWW eaD9O7HDa8WEKU0mvUSCjLZAmIGWfSAssByjQ8eNDFOZT2FBdsjkH/RhHMF+i5/NOP5A QWvMAdIJo/yyvwHvnslGhvMCAgOdg4PdfEfBGFHVkpCMWe76yRRpWpxmPaProPb53N6/ 3IiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=V5VGMK+6XYnjTworljWPVg5y65/T5eBThBfgObSPij8=; b=g2EcUzqd5P8QzU3IUXZZ5iYiOsMiwrXYmVlYOtbQpvP8cm19kJ+Q101kInQwf6X0+G cjVIHPHfG7dv3I4zdTdDX2q2+VTmqD+yKpDgHE3DSaDppA9KGlOldnswF3gLjNhKNZXz DsY/2ZBPqKsjWrMnE/B0fd5tR/0wMM4ytQnnNh06+VxQAaeYtb4XRPCM2XLHTu6g6gws Y+eyFAfuMrEPL/Hb5DwRgq1onUaTZFW1hQL8nkxlEPoz29cVR7ucPOf1n+5bVkqieXjM nItr/0lMldjD1ANKkDYdifFO1MeWu+rjIzzawcdRvQ1j5a51TW+i/s6dJbjIdWnnoVXq b+GQ== X-Gm-Message-State: AOAM533v0ZX00aKz1iMfI5X8fnH1u9E+NS4EQO+3/KxC2bfzPLhp/shk bwDVhoPfEC1QRRW18XvzaIs= X-Google-Smtp-Source: ABdhPJxwafOxxZsJNrQkXWC3YT7Ml9rHQf/0Xsrq92lv9g+ByL0YmwhqUkgctOutuKFrQYsZw18zxw== X-Received: by 2002:a2e:8804:: with SMTP id x4mr3378619ljh.328.1596705765714; Thu, 06 Aug 2020 02:22:45 -0700 (PDT) Received: from [192.168.1.2] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id d15sm2124101ljl.32.2020.08.06.02.22.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2020 02:22:45 -0700 (PDT) Subject: Re: [RFC PATCH V1 07/12] A collection of tweaks to be able to run emulator in driver domain To: paul@xen.org, 'Jan Beulich' References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-8-git-send-email-olekstysh@gmail.com> <4ffa6434-3ad6-04dc-bfde-f75196930fb4@suse.com> <005f01d66b47$1c58ccc0$550a6640$@xen.org> From: Oleksandr Message-ID: Date: Thu, 6 Aug 2020 12:22:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <005f01d66b47$1c58ccc0$550a6640$@xen.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: 'Stefano Stabellini' , 'Julien Grall' , 'Wei Liu' , 'Andrew Cooper' , 'Ian Jackson' , 'George Dunlap' , 'Oleksandr Tyshchenko' , xen-devel@lists.xenproject.org, 'Daniel De Graaf' Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 05.08.20 19:40, Paul Durrant wrote: Hi Jan, Paul >> -----Original Message----- >> From: Jan Beulich >> Sent: 05 August 2020 17:20 >> To: Oleksandr Tyshchenko ; Paul Durrant >> Cc: xen-devel@lists.xenproject.org; Oleksandr Tyshchenko ; Andrew >> Cooper ; George Dunlap ; Ian Jackson >> ; Julien Grall ; Stefano Stabellini >> ; Wei Liu ; Daniel De Graaf >> Subject: Re: [RFC PATCH V1 07/12] A collection of tweaks to be able to run emulator in driver domain >> >> On 03.08.2020 20:21, Oleksandr Tyshchenko wrote: >>> From: Oleksandr Tyshchenko >>> >>> Trying to run emulator in driver domain I ran into various issues >>> mostly policy-related. So this patch tries to resolve all them >>> plobably in a hackish way. I would like to get feedback how >>> to implement them properly as having an emulator in driver domain >>> is a completely valid use-case. >> From going over the comments I can only derive you want to run >> an emulator in a driver domain, which doesn't really make sense >> to me. A driver domain has a different purpose after all. If >> instead you mean it to be run in just some other domain (which >> also isn't the domain controlling the target), then there may >> be more infrastructure changes needed. >> >> Paul - was/is your standalone ioreq server (demu?) able to run >> in other than the domain controlling a guest? >> > Not something I've done yet, but it was always part of the idea so that we could e.g. pass through a device to a dedicated domain and then run multiple demu instances there to virtualize it for many domUs. (I'm thinking here of a device that is not SR-IOV and hence would need some bespoke emulation code to share it out).That dedicated domain would be termed the 'driver domain' simply because it is running the device driver for the h/w that underpins the emulation. I may abuse "driver domain" terminology, but indeed in our use-case we pass through a set of H/W devices to a dedicated domain which is running the device drivers for that H/Ws. Our target system comprises a thin Dom0 (without H/W devices at all), DomD (which owns most of the H/W devices) and DomU which runs on virtual devices. This patch tries to make changes at Xen side to be able run standalone ioreq server (emulator) in that dedicated (driver?) domain. Actually the virtio-mmio PoC is based on IOREQ/DM features and emulator (based on demu) acting as a virtio-mmio backend. But it may be various use-cases for that (some mediator for sharing specific H/W resource between Guests or custom PCI emulator for example). If this is valid from Xen PoV I would be happy to get feedback how to transform tweaks (hacks) in current patch into the proper support. -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Thu Aug 06 09:25:40 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 09:25:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3c9U-0002Lg-GD; Thu, 06 Aug 2020 09:25:32 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3c9S-0002LU-In for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 09:25:30 +0000 X-Inumbo-ID: 17ea8c05-211c-4fd0-ba8f-6cf1a8fcaace Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 17ea8c05-211c-4fd0-ba8f-6cf1a8fcaace; Thu, 06 Aug 2020 09:25:29 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 619E1ADE2; Thu, 6 Aug 2020 09:25:46 +0000 (UTC) Subject: Re: [PATCH 1/4] build: work around bash issue To: Julien Grall References: <305c2532-408a-9f78-61fe-c90a2e86eb8e@suse.com> <1a3325a8-a59a-7759-b7a9-9263652b429c@xen.org> From: Jan Beulich Message-ID: <0f853234-3f62-de82-d083-3c0cfc285c20@suse.com> Date: Thu, 6 Aug 2020 11:25:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <1a3325a8-a59a-7759-b7a9-9263652b429c@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , Anthony Perard , "xen-devel@lists.xenproject.org" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 06.08.2020 11:20, Julien Grall wrote: > On 06/08/2020 10:14, Jan Beulich wrote: >> I've observed it with 3.2.57(2). > > Thank you. Please mention it in the commit message. Well, added. If I had seen any use of the precise version, I would have done so right away. Would you mind educating me how knowing the precise version is useful, without knowing up to which version the issue exists? Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 09:27:22 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 09:27:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3cBF-0002TR-SV; Thu, 06 Aug 2020 09:27:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3cBF-0002TM-Gi for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 09:27:21 +0000 X-Inumbo-ID: 3bd3c273-42dd-459a-bc18-41cb4c9eed69 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3bd3c273-42dd-459a-bc18-41cb4c9eed69; Thu, 06 Aug 2020 09:27:19 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id EE2BFB666; Thu, 6 Aug 2020 09:27:35 +0000 (UTC) Subject: Re: [RFC PATCH V1 07/12] A collection of tweaks to be able to run emulator in driver domain To: Oleksandr References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-8-git-send-email-olekstysh@gmail.com> <4ffa6434-3ad6-04dc-bfde-f75196930fb4@suse.com> <005f01d66b47$1c58ccc0$550a6640$@xen.org> From: Jan Beulich Message-ID: Date: Thu, 6 Aug 2020 11:27:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: 'Stefano Stabellini' , 'Julien Grall' , 'Wei Liu' , paul@xen.org, 'Andrew Cooper' , 'Ian Jackson' , 'George Dunlap' , 'Oleksandr Tyshchenko' , xen-devel@lists.xenproject.org, 'Daniel De Graaf' Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 06.08.2020 11:22, Oleksandr wrote: > > On 05.08.20 19:40, Paul Durrant wrote: > > Hi Jan, Paul > >>> -----Original Message----- >>> From: Jan Beulich >>> Sent: 05 August 2020 17:20 >>> To: Oleksandr Tyshchenko ; Paul Durrant >>> Cc: xen-devel@lists.xenproject.org; Oleksandr Tyshchenko ; Andrew >>> Cooper ; George Dunlap ; Ian Jackson >>> ; Julien Grall ; Stefano Stabellini >>> ; Wei Liu ; Daniel De Graaf >>> Subject: Re: [RFC PATCH V1 07/12] A collection of tweaks to be able to run emulator in driver domain >>> >>> On 03.08.2020 20:21, Oleksandr Tyshchenko wrote: >>>> From: Oleksandr Tyshchenko >>>> >>>> Trying to run emulator in driver domain I ran into various issues >>>> mostly policy-related. So this patch tries to resolve all them >>>> plobably in a hackish way. I would like to get feedback how >>>> to implement them properly as having an emulator in driver domain >>>> is a completely valid use-case. >>> From going over the comments I can only derive you want to run >>> an emulator in a driver domain, which doesn't really make sense >>> to me. A driver domain has a different purpose after all. If >>> instead you mean it to be run in just some other domain (which >>> also isn't the domain controlling the target), then there may >>> be more infrastructure changes needed. >>> >>> Paul - was/is your standalone ioreq server (demu?) able to run >>> in other than the domain controlling a guest? >>> >> Not something I've done yet, but it was always part of the idea so that we could e.g. pass through a device to a dedicated domain and then run multiple demu instances there to virtualize it for many domUs. (I'm thinking here of a device that is not SR-IOV and hence would need some bespoke emulation code to share it out).That dedicated domain would be termed the 'driver domain' simply because it is running the device driver for the h/w that underpins the emulation. > > I may abuse "driver domain" terminology, but indeed in our use-case we > pass through a set of H/W devices to a dedicated domain which is running > the device drivers for that H/Ws. Our target system comprises a thin > Dom0 (without H/W devices at all), DomD (which owns most of the H/W > devices) and DomU which runs on virtual devices. This patch tries to > make changes at Xen side to be able run standalone ioreq server > (emulator) in that dedicated (driver?) domain. Okay, in which case I'm fine with the term. I simply wasn't aware of the targeted scenario, sorry. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 09:28:13 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 09:28:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3cBy-0002XF-5a; Thu, 06 Aug 2020 09:28:06 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3cBw-0002X7-Sm for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 09:28:04 +0000 X-Inumbo-ID: 60544132-7af2-4fb0-820f-966b2ae4b41f Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 60544132-7af2-4fb0-820f-966b2ae4b41f; Thu, 06 Aug 2020 09:28:03 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 40FCBB65C; Thu, 6 Aug 2020 09:28:20 +0000 (UTC) Subject: [PATCH 1/3] x86: slightly re-arrange 32-bit handling in dom0_construct_pv() From: Jan Beulich To: "xen-devel@lists.xenproject.org" References: Message-ID: <0972ea3c-c2a8-b0f4-ae25-132bdb798f6a@suse.com> Date: Thu, 6 Aug 2020 11:28:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Add #ifdef-s (the 2nd one will be needed in particular, to guard the uses of m2p_compat_vstart and HYPERVISOR_COMPAT_VIRT_START()) and fold duplicate uses of elf_32bit(). Also adjust what gets logged: Avoid "compat32" when support isn't built in, and don't assume ELF class <> ELFCLASS64 means ELFCLASS32. Signed-off-by: Jan Beulich --- a/xen/arch/x86/pv/dom0_build.c +++ b/xen/arch/x86/pv/dom0_build.c @@ -300,7 +300,6 @@ int __init dom0_construct_pv(struct doma struct page_info *page = NULL; start_info_t *si; struct vcpu *v = d->vcpu[0]; - unsigned long long value; void *image_base = bootstrap_map(image); unsigned long image_len = image->mod_end; void *image_start = image_base + image_headroom; @@ -357,27 +356,36 @@ int __init dom0_construct_pv(struct doma goto out; /* compatibility check */ + printk(" Xen kernel: 64-bit, lsb%s\n", + IS_ENABLED(CONFIG_PV32) ? ", compat32" : ""); compatible = 0; machine = elf_uval(&elf, elf.ehdr, e_machine); - printk(" Xen kernel: 64-bit, lsb, compat32\n"); - if ( elf_32bit(&elf) && parms.pae == XEN_PAE_BIMODAL ) - parms.pae = XEN_PAE_EXTCR3; - if ( elf_32bit(&elf) && parms.pae && machine == EM_386 ) + +#ifdef CONFIG_PV32 + if ( elf_32bit(&elf) ) { - if ( unlikely(rc = switch_compat(d)) ) + if ( parms.pae == XEN_PAE_BIMODAL ) + parms.pae = XEN_PAE_EXTCR3; + if ( parms.pae && machine == EM_386 ) { - printk("Dom0 failed to switch to compat: %d\n", rc); - return rc; - } + if ( unlikely(rc = switch_compat(d)) ) + { + printk("Dom0 failed to switch to compat: %d\n", rc); + return rc; + } - compatible = 1; + compatible = 1; + } } - if (elf_64bit(&elf) && machine == EM_X86_64) +#endif + + if ( elf_64bit(&elf) && machine == EM_X86_64 ) compatible = 1; - printk(" Dom0 kernel: %s%s, %s, paddr %#" PRIx64 " -> %#" PRIx64 "\n", - elf_64bit(&elf) ? "64-bit" : "32-bit", - parms.pae ? ", PAE" : "", - elf_msb(&elf) ? "msb" : "lsb", + + printk(" Dom0 kernel: %s-bit%s, %s, paddr %#" PRIx64 " -> %#" PRIx64 "\n", + elf_64bit(&elf) ? "64" : elf_32bit(&elf) ? "32" : "??", + parms.pae ? ", PAE" : "", + elf_msb(&elf) ? "msb" : "lsb", elf.pstart, elf.pend); if ( elf.bsd_symtab_pstart ) printk(" Dom0 symbol map %#" PRIx64 " -> %#" PRIx64 "\n", @@ -405,23 +413,28 @@ int __init dom0_construct_pv(struct doma if ( parms.pae == XEN_PAE_EXTCR3 ) set_bit(VMASST_TYPE_pae_extended_cr3, &d->vm_assist); - if ( !pv_shim && (parms.virt_hv_start_low != UNSET_ADDR) && - elf_32bit(&elf) ) +#ifdef CONFIG_PV32 + if ( elf_32bit(&elf) ) { - unsigned long mask = (1UL << L2_PAGETABLE_SHIFT) - 1; - value = (parms.virt_hv_start_low + mask) & ~mask; - BUG_ON(!is_pv_32bit_domain(d)); - if ( value > __HYPERVISOR_COMPAT_VIRT_START ) - panic("Domain 0 expects too high a hypervisor start address\n"); - HYPERVISOR_COMPAT_VIRT_START(d) = - max_t(unsigned int, m2p_compat_vstart, value); - } + if ( !pv_shim && (parms.virt_hv_start_low != UNSET_ADDR) ) + { + unsigned long mask = (1UL << L2_PAGETABLE_SHIFT) - 1; + unsigned long value = (parms.virt_hv_start_low + mask) & ~mask; - if ( (parms.p2m_base != UNSET_ADDR) && elf_32bit(&elf) ) - { - printk(XENLOG_WARNING "P2M table base ignored\n"); - parms.p2m_base = UNSET_ADDR; + BUG_ON(!is_pv_32bit_domain(d)); + if ( value > __HYPERVISOR_COMPAT_VIRT_START ) + panic("Domain 0 expects too high a hypervisor start address\n"); + HYPERVISOR_COMPAT_VIRT_START(d) = + max_t(unsigned int, m2p_compat_vstart, value); + } + + if ( parms.p2m_base != UNSET_ADDR ) + { + printk(XENLOG_WARNING "P2M table base ignored\n"); + parms.p2m_base = UNSET_ADDR; + } } +#endif /* * Why do we need this? The number of page-table frames depends on the From xen-devel-bounces@lists.xenproject.org Thu Aug 06 09:28:38 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 09:28:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3cCT-0002cQ-IX; Thu, 06 Aug 2020 09:28:37 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3cCS-0002cA-0K for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 09:28:36 +0000 X-Inumbo-ID: 3c2c9161-dde8-40ea-813b-7b148645b323 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3c2c9161-dde8-40ea-813b-7b148645b323; Thu, 06 Aug 2020 09:28:34 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1D97AAE41; Thu, 6 Aug 2020 09:28:51 +0000 (UTC) Subject: [PATCH 2/3] x86: don't maintain compat M2P when !PV32 From: Jan Beulich To: "xen-devel@lists.xenproject.org" References: Message-ID: <4575f42b-a347-b34e-0032-e04668106a9b@suse.com> Date: Thu, 6 Aug 2020 11:28:36 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Note that opt_pv32's declaration / #define need to be moved due to other header dependencies; in particular can asm-x86/mm.h not include asm-x86/pv/domain.h. While touching their definitions anyway, also adjust section placement of m2p_compat_vstart and compat_idle_pg_table_l2. Similarly, while putting init_xen_pae_l2_slots() inside #ifdef, also move it to a PV-only source file. Suggested-by: Andrew Cooper Signed-off-by: Jan Beulich --- An alternative place for opt_pv32.h would seem to be asm-x86/config.h. --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -597,8 +597,10 @@ int arch_domain_create(struct domain *d, } d->arch.emulation_flags = emflags; +#ifdef CONFIG_PV32 HYPERVISOR_COMPAT_VIRT_START(d) = is_pv_domain(d) ? __HYPERVISOR_COMPAT_VIRT_START : ~0u; +#endif if ( (rc = paging_domain_init(d)) != 0 ) goto fail; --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -1427,13 +1427,6 @@ static bool pae_xen_mappings_check(const return true; } -void init_xen_pae_l2_slots(l2_pgentry_t *l2t, const struct domain *d) -{ - memcpy(&l2t[COMPAT_L2_PAGETABLE_FIRST_XEN_SLOT(d)], - compat_idle_pg_table_l2, - COMPAT_L2_PAGETABLE_XEN_SLOTS(d) * sizeof(*l2t)); -} - static int promote_l2_table(struct page_info *page, unsigned long type) { struct domain *d = page_get_owner(page); --- a/xen/arch/x86/pv/mm.c +++ b/xen/arch/x86/pv/mm.c @@ -128,6 +128,15 @@ bool pv_map_ldt_shadow_page(unsigned int return true; } +#ifdef CONFIG_PV32 +void init_xen_pae_l2_slots(l2_pgentry_t *l2t, const struct domain *d) +{ + memcpy(&l2t[COMPAT_L2_PAGETABLE_FIRST_XEN_SLOT(d)], + compat_idle_pg_table_l2, + COMPAT_L2_PAGETABLE_XEN_SLOTS(d) * sizeof(*l2t)); +} +#endif + /* * Local variables: * mode: C --- a/xen/arch/x86/x86_64/compat/mm.c +++ b/xen/arch/x86/x86_64/compat/mm.c @@ -103,6 +103,9 @@ int compat_arch_memory_op(unsigned long .max_mfn = MACH2PHYS_COMPAT_NR_ENTRIES(d) - 1 }; + if ( !opt_pv32 ) + return -EOPNOTSUPP; + if ( copy_to_guest(arg, &mapping, 1) ) rc = -EFAULT; @@ -115,6 +118,9 @@ int compat_arch_memory_op(unsigned long unsigned long limit; compat_pfn_t last_mfn; + if ( !opt_pv32 ) + return -EOPNOTSUPP; + if ( copy_from_guest(&xmml, arg, 1) ) return -EFAULT; --- a/xen/arch/x86/x86_64/mm.c +++ b/xen/arch/x86/x86_64/mm.c @@ -40,9 +40,11 @@ EMIT_FILE; #include #include -unsigned int __read_mostly m2p_compat_vstart = __HYPERVISOR_COMPAT_VIRT_START; +#ifdef CONFIG_PV32 +unsigned int __initdata m2p_compat_vstart = __HYPERVISOR_COMPAT_VIRT_START; -l2_pgentry_t *compat_idle_pg_table_l2; +l2_pgentry_t *__read_mostly compat_idle_pg_table_l2; +#endif void *do_page_walk(struct vcpu *v, unsigned long addr) { @@ -218,7 +220,8 @@ static void destroy_compat_m2p_mapping(s { unsigned long i, smap = info->spfn, emap = info->spfn; - if ( smap > ((RDWR_COMPAT_MPT_VIRT_END - RDWR_COMPAT_MPT_VIRT_START) >> 2) ) + if ( !opt_pv32 || + smap > ((RDWR_COMPAT_MPT_VIRT_END - RDWR_COMPAT_MPT_VIRT_START) >> 2) ) return; if ( emap > ((RDWR_COMPAT_MPT_VIRT_END - RDWR_COMPAT_MPT_VIRT_START) >> 2) ) @@ -315,10 +318,10 @@ static void destroy_m2p_mapping(struct m */ static int setup_compat_m2p_table(struct mem_hotadd_info *info) { + int err = 0; unsigned long i, smap, emap, epfn = info->epfn; mfn_t mfn; unsigned int n; - int err = 0; smap = info->spfn & (~((1UL << (L2_PAGETABLE_SHIFT - 2)) -1)); @@ -326,7 +329,8 @@ static int setup_compat_m2p_table(struct * Notice: For hot-added memory, only range below m2p_compat_vstart * will be filled up (assuming memory is discontinous when booting). */ - if ((smap > ((RDWR_COMPAT_MPT_VIRT_END - RDWR_COMPAT_MPT_VIRT_START) >> 2)) ) + if ( !opt_pv32 || + (smap > ((RDWR_COMPAT_MPT_VIRT_END - RDWR_COMPAT_MPT_VIRT_START) >> 2)) ) return 0; if ( epfn > ((RDWR_COMPAT_MPT_VIRT_END - RDWR_COMPAT_MPT_VIRT_START) >> 2) ) @@ -368,6 +372,7 @@ static int setup_compat_m2p_table(struct } #undef CNT #undef MFN + return err; } @@ -609,17 +614,24 @@ void __init paging_init(void) #undef MFN /* Create user-accessible L2 directory to map the MPT for compat guests. */ - if ( (l2_ro_mpt = alloc_xen_pagetable()) == NULL ) - goto nomem; - compat_idle_pg_table_l2 = l2_ro_mpt; - clear_page(l2_ro_mpt); - /* Allocate and map the compatibility mode machine-to-phys table. */ - mpt_size = (mpt_size >> 1) + (1UL << (L2_PAGETABLE_SHIFT - 1)); - if ( mpt_size > RDWR_COMPAT_MPT_VIRT_END - RDWR_COMPAT_MPT_VIRT_START ) - mpt_size = RDWR_COMPAT_MPT_VIRT_END - RDWR_COMPAT_MPT_VIRT_START; - mpt_size &= ~((1UL << L2_PAGETABLE_SHIFT) - 1UL); - if ( (m2p_compat_vstart + mpt_size) < MACH2PHYS_COMPAT_VIRT_END ) - m2p_compat_vstart = MACH2PHYS_COMPAT_VIRT_END - mpt_size; + if ( opt_pv32 ) + { + if ( (l2_ro_mpt = alloc_xen_pagetable()) == NULL ) + goto nomem; + compat_idle_pg_table_l2 = l2_ro_mpt; + clear_page(l2_ro_mpt); + + /* Allocate and map the compatibility mode machine-to-phys table. */ + mpt_size = (mpt_size >> 1) + (1UL << (L2_PAGETABLE_SHIFT - 1)); + if ( mpt_size > RDWR_COMPAT_MPT_VIRT_END - RDWR_COMPAT_MPT_VIRT_START ) + mpt_size = RDWR_COMPAT_MPT_VIRT_END - RDWR_COMPAT_MPT_VIRT_START; + mpt_size &= ~((1UL << L2_PAGETABLE_SHIFT) - 1UL); + if ( (m2p_compat_vstart + mpt_size) < MACH2PHYS_COMPAT_VIRT_END ) + m2p_compat_vstart = MACH2PHYS_COMPAT_VIRT_END - mpt_size; + } + else + mpt_size = 0; + #define MFN(x) (((x) << L2_PAGETABLE_SHIFT) / sizeof(unsigned int)) #define CNT ((sizeof(*frame_table) & -sizeof(*frame_table)) / \ sizeof(*compat_machine_to_phys_mapping)) @@ -845,23 +857,24 @@ void __init subarch_init_memory(void) mfn_to_page(_mfn(m2p_start_mfn + i)), SHARE_ro); } - for ( v = RDWR_COMPAT_MPT_VIRT_START; - v != RDWR_COMPAT_MPT_VIRT_END; - v += 1 << L2_PAGETABLE_SHIFT ) - { - l3e = l3e_from_l4e(idle_pg_table[l4_table_offset(v)], - l3_table_offset(v)); - if ( !(l3e_get_flags(l3e) & _PAGE_PRESENT) ) - continue; - l2e = l2e_from_l3e(l3e, l2_table_offset(v)); - if ( !(l2e_get_flags(l2e) & _PAGE_PRESENT) ) - continue; - m2p_start_mfn = l2e_get_pfn(l2e); + if ( opt_pv32 ) + for ( v = RDWR_COMPAT_MPT_VIRT_START; + v != RDWR_COMPAT_MPT_VIRT_END; + v += 1 << L2_PAGETABLE_SHIFT ) + { + l3e = l3e_from_l4e(idle_pg_table[l4_table_offset(v)], + l3_table_offset(v)); + if ( !(l3e_get_flags(l3e) & _PAGE_PRESENT) ) + continue; + l2e = l2e_from_l3e(l3e, l2_table_offset(v)); + if ( !(l2e_get_flags(l2e) & _PAGE_PRESENT) ) + continue; + m2p_start_mfn = l2e_get_pfn(l2e); - for ( i = 0; i < L1_PAGETABLE_ENTRIES; i++ ) - share_xen_page_with_privileged_guests( - mfn_to_page(_mfn(m2p_start_mfn + i)), SHARE_ro); - } + for ( i = 0; i < L1_PAGETABLE_ENTRIES; i++ ) + share_xen_page_with_privileged_guests( + mfn_to_page(_mfn(m2p_start_mfn + i)), SHARE_ro); + } /* Mark all of direct map NX if hardware supports it. */ if ( !cpu_has_nx ) @@ -933,6 +946,9 @@ long subarch_memory_op(unsigned long cmd break; case XENMEM_machphys_compat_mfn_list: + if ( !opt_pv32 ) + return -EOPNOTSUPP; + if ( copy_from_guest(&xmml, arg, 1) ) return -EFAULT; --- a/xen/include/asm-x86/config.h +++ b/xen/include/asm-x86/config.h @@ -142,7 +142,7 @@ extern unsigned char boot_edid_info[128] * 0xffff82c000000000 - 0xffff82cfffffffff [64GB, 2^36 bytes, PML4:261] * vmap()/ioremap()/fixmap area. * 0xffff82d000000000 - 0xffff82d03fffffff [1GB, 2^30 bytes, PML4:261] - * Compatibility machine-to-phys translation table. + * Compatibility machine-to-phys translation table (CONFIG_PV32). * 0xffff82d040000000 - 0xffff82d07fffffff [1GB, 2^30 bytes, PML4:261] * Xen text, static data, bss. #ifndef CONFIG_BIGMEM @@ -246,9 +246,18 @@ extern unsigned char boot_edid_info[128] #ifndef __ASSEMBLY__ +#ifdef CONFIG_PV32 + /* This is not a fixed value, just a lower limit. */ #define __HYPERVISOR_COMPAT_VIRT_START 0xF5800000 #define HYPERVISOR_COMPAT_VIRT_START(d) ((d)->arch.hv_compat_vstart) + +#else + +#define HYPERVISOR_COMPAT_VIRT_START(d) ((void)(d), 0) + +#endif + #define MACH2PHYS_COMPAT_VIRT_START HYPERVISOR_COMPAT_VIRT_START #define MACH2PHYS_COMPAT_VIRT_END 0xFFE00000 #define MACH2PHYS_COMPAT_NR_ENTRIES(d) \ --- a/xen/include/asm-x86/domain.h +++ b/xen/include/asm-x86/domain.h @@ -307,7 +307,9 @@ struct arch_domain { struct page_info *perdomain_l3_pg; +#ifdef CONFIG_PV32 unsigned int hv_compat_vstart; +#endif /* Maximum physical-address bitwidth supported by this guest. */ unsigned int physaddr_bitsize; --- a/xen/include/asm-x86/mm.h +++ b/xen/include/asm-x86/mm.h @@ -42,8 +42,12 @@ #define _PGT_validated PG_shift(6) #define PGT_validated PG_mask(1, 6) /* PAE only: is this an L2 page directory containing Xen-private mappings? */ +#ifdef CONFIG_PV32 #define _PGT_pae_xen_l2 PG_shift(7) #define PGT_pae_xen_l2 PG_mask(1, 7) +#else +#define PGT_pae_xen_l2 0 +#endif /* Has this page been *partially* validated for use as its current type? */ #define _PGT_partial PG_shift(8) #define PGT_partial PG_mask(1, 8) @@ -494,15 +498,39 @@ extern paddr_t mem_hotplug; #define SHARED_M2P_ENTRY (~0UL - 1UL) #define SHARED_M2P(_e) ((_e) == SHARED_M2P_ENTRY) -#define compat_machine_to_phys_mapping ((unsigned int *)RDWR_COMPAT_MPT_VIRT_START) +#ifdef CONFIG_PV32 + +extern int8_t opt_pv32; + +# define compat_machine_to_phys_mapping ((unsigned int *)RDWR_COMPAT_MPT_VIRT_START) + +# define set_compat_m2p(mfn, entry) \ + ((void)(!opt_pv32 || \ + (mfn) >= (RDWR_COMPAT_MPT_VIRT_END - RDWR_COMPAT_MPT_VIRT_START) / 4 || \ + (compat_machine_to_phys_mapping[mfn] = (entry)))) + +#else /* !CONFIG_PV32 */ + +# define opt_pv32 false + +/* + * Declare the symbol such that (dead) code referencing it can be built + * without a lot of #ifdef-ary, but mark it fully const and don't define + * this symbol anywhere (relying on DCE by the compiler). + */ +extern const unsigned int *const compat_machine_to_phys_mapping; + +# define set_compat_m2p(mfn, entry) + +#endif /* CONFIG_PV32 */ + #define _set_gpfn_from_mfn(mfn, pfn) ({ \ struct domain *d = page_get_owner(mfn_to_page(_mfn(mfn))); \ unsigned long entry = (d && (d == dom_cow)) ? \ SHARED_M2P_ENTRY : (pfn); \ - ((void)((mfn) >= (RDWR_COMPAT_MPT_VIRT_END - RDWR_COMPAT_MPT_VIRT_START) / 4 || \ - (compat_machine_to_phys_mapping[(mfn)] = (unsigned int)(entry))), \ - machine_to_phys_mapping[(mfn)] = (entry)); \ - }) + set_compat_m2p(mfn, (unsigned int)(entry)); \ + machine_to_phys_mapping[mfn] = (entry); \ +}) /* * Disable some users of set_gpfn_from_mfn() (e.g., free_heap_pages()) until --- a/xen/include/asm-x86/pv/domain.h +++ b/xen/include/asm-x86/pv/domain.h @@ -23,12 +23,6 @@ #include -#ifdef CONFIG_PV32 -extern int8_t opt_pv32; -#else -# define opt_pv32 false -#endif - /* * PCID values for the address spaces of 64-bit pv domains: * From xen-devel-bounces@lists.xenproject.org Thu Aug 06 09:29:02 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 09:29:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3cCs-0002iG-St; Thu, 06 Aug 2020 09:29:02 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3cCr-0002i4-G8 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 09:29:01 +0000 X-Inumbo-ID: c422bb10-8cea-499d-896f-e1bfa38e0de2 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c422bb10-8cea-499d-896f-e1bfa38e0de2; Thu, 06 Aug 2020 09:29:00 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5FD1FB66B; Thu, 6 Aug 2020 09:29:17 +0000 (UTC) Subject: [PATCH 3/3] x86: don't override INVALID_M2P_ENTRY with SHARED_M2P_ENTRY From: Jan Beulich To: "xen-devel@lists.xenproject.org" References: Message-ID: <1d83fd35-6ea5-289c-d8db-029c50957f85@suse.com> Date: Thu, 6 Aug 2020 11:29:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" While in most cases code ahead of the invocation of set_gpfn_from_mfn() deals with shared pages, at least in set_typed_p2m_entry() I can't spot such handling (it's entirely possible there's code missing there). Let's try to play safe and add an extra check. Signed-off-by: Jan Beulich --- a/xen/include/asm-x86/mm.h +++ b/xen/include/asm-x86/mm.h @@ -525,9 +525,14 @@ extern const unsigned int *const compat_ #endif /* CONFIG_PV32 */ #define _set_gpfn_from_mfn(mfn, pfn) ({ \ - struct domain *d = page_get_owner(mfn_to_page(_mfn(mfn))); \ - unsigned long entry = (d && (d == dom_cow)) ? \ - SHARED_M2P_ENTRY : (pfn); \ + unsigned long entry = (pfn); \ + if ( entry != INVALID_M2P_ENTRY ) \ + { \ + const struct domain *d; \ + d = page_get_owner(mfn_to_page(_mfn(mfn))); \ + if ( d && (d == dom_cow) ) \ + entry = SHARED_M2P_ENTRY; \ + } \ set_compat_m2p(mfn, (unsigned int)(entry)); \ machine_to_phys_mapping[mfn] = (entry); \ }) From xen-devel-bounces@lists.xenproject.org Thu Aug 06 09:44:49 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 09:44:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3cS1-0004Xg-9u; Thu, 06 Aug 2020 09:44:41 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3cS0-0004Xa-Lm for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 09:44:40 +0000 X-Inumbo-ID: ff8ff1f7-4cd1-4e94-9072-722a1face18c Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ff8ff1f7-4cd1-4e94-9072-722a1face18c; Thu, 06 Aug 2020 09:44:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vuPhnUSIT7TQpzuqweSrTCzl/IuMTfJWC4ovwxhQBoU=; b=q3j+oj4rwH/7acxpKboudYJhG+ gBPVElmAzQCb3NmBxvzY3wtrekNZin5gkt0GeUuNS8v4cWF+PxdLeGEMPlheXBMm5Uz6DBUEKu+Ud I0/vUhb253hxeDz22uuKy6JOHMx8RbdauTHKZJ1XM7kdEhpkGDzsD+qm+lhWc+Qr5+cs=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3cRx-0006m5-EB; Thu, 06 Aug 2020 09:44:37 +0000 Received: from [54.239.6.187] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k3cRx-0005Si-5w; Thu, 06 Aug 2020 09:44:37 +0000 Subject: Re: [PATCH 1/4] build: work around bash issue To: Jan Beulich References: <305c2532-408a-9f78-61fe-c90a2e86eb8e@suse.com> <1a3325a8-a59a-7759-b7a9-9263652b429c@xen.org> <0f853234-3f62-de82-d083-3c0cfc285c20@suse.com> From: Julien Grall Message-ID: <9dea7b27-f97e-45c3-30ae-66e85d9eda87@xen.org> Date: Thu, 6 Aug 2020 10:44:34 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <0f853234-3f62-de82-d083-3c0cfc285c20@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , Anthony Perard , "xen-devel@lists.xenproject.org" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 06/08/2020 10:25, Jan Beulich wrote: > On 06.08.2020 11:20, Julien Grall wrote: >> On 06/08/2020 10:14, Jan Beulich wrote: >>> I've observed it with 3.2.57(2). >> >> Thank you. Please mention it in the commit message. > > Well, added. If I had seen any use of the precise version, I would > have done so right away. Would you mind educating me how knowing > the precise version is useful, without knowing up to which version > the issue exists? Indeed, this wouldn't tell us whether other bash versions are affected. However, as a reviewer, I need to be able to verify what you wrote is correct and that your patch is the correct way to solve it. So providing the bash version where you observed the issue will at least fulfill this part. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Aug 06 09:45:35 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 09:45:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3cSt-0004aa-Jw; Thu, 06 Aug 2020 09:45:35 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3cSs-0004aT-R6 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 09:45:34 +0000 X-Inumbo-ID: 1bfb1a83-6506-4470-8765-4bf29376f5d0 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1bfb1a83-6506-4470-8765-4bf29376f5d0; Thu, 06 Aug 2020 09:45:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3kvMxfrz/ED50c7Hg32ZOSs/V6sID2XG0ios81uRB0Q=; b=ayMd67340+2GtqJaj28WNlY31Y zEKBEh9u22eERrlrEaiHAR0VCepsUEo3IUl9Jhbn4mDBtpaFE3oV3igB48bQvouewjqu1r8VP5+yV v0/cMm6jYNEMvbzB1Bh5e1NBgyHHb9Ktf9hq3WvCduWx5/srPh+kGVqhTtTfku+GmdQ8=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3cSg-0006n6-OL; Thu, 06 Aug 2020 09:45:22 +0000 Received: from [54.239.6.187] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k3cSg-0005UA-I0; Thu, 06 Aug 2020 09:45:22 +0000 Subject: Re: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common To: Stefano Stabellini References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-2-git-send-email-olekstysh@gmail.com> <000c01d66a33$2bd56510$83802f30$@xen.org> <9f83a7ed-ca97-449f-c7b9-a1140644abe9@gmail.com> <5df97055-67f9-16cc-a274-864672d67164@xen.org> From: Julien Grall Message-ID: <1afb9ffd-088c-ef4e-131a-0f2b62142405@xen.org> Date: Thu, 6 Aug 2020 10:45:19 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: 'Kevin Tian' , 'Jun Nakajima' , 'Wei Liu' , paul@xen.org, 'Andrew Cooper' , 'Ian Jackson' , 'George Dunlap' , 'Tim Deegan' , Oleksandr , 'Oleksandr Tyshchenko' , 'Julien Grall' , 'Jan Beulich' , xen-devel@lists.xenproject.org, =?UTF-8?B?J1JvZ2VyIFBhdSBNb25uw6kn?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Hi, On 06/08/2020 01:37, Stefano Stabellini wrote: > On Wed, 5 Aug 2020, Julien Grall wrote: >> On 04/08/2020 20:11, Stefano Stabellini wrote: >>> On Tue, 4 Aug 2020, Julien Grall wrote: >>>> On 04/08/2020 12:10, Oleksandr wrote: >>>>> On 04.08.20 10:45, Paul Durrant wrote: >>>>>>> +static inline bool hvm_ioreq_needs_completion(const ioreq_t *ioreq) >>>>>>> +{ >>>>>>> +    return ioreq->state == STATE_IOREQ_READY && >>>>>>> +           !ioreq->data_is_ptr && >>>>>>> +           (ioreq->type != IOREQ_TYPE_PIO || ioreq->dir != >>>>>>> IOREQ_WRITE); >>>>>>> +} >>>>>> I don't think having this in common code is correct. The short-cut of >>>>>> not >>>>>> completing PIO reads seems somewhat x86 specific. >>>> >>>> Hmmm, looking at the code, I think it doesn't wait for PIO writes to >>>> complete >>>> (not read). Did I miss anything? >>>> >>>>> Does ARM even >>>>>> have the concept of PIO? >>>>> >>>>> I am not 100% sure here, but it seems that doesn't have. >>>> >>>> Technically, the PIOs exist on Arm, however they are accessed the same way >>>> as >>>> MMIO and will have a dedicated area defined by the HW. >>>> >>>> AFAICT, on Arm64, they are only used for PCI IO Bar. >>>> >>>> Now the question is whether we want to expose them to the Device Emulator >>>> as >>>> PIO or MMIO access. From a generic PoV, a DM shouldn't have to care about >>>> the >>>> architecture used. It should just be able to request a given IOport >>>> region. >>>> >>>> So it may make sense to differentiate them in the common ioreq code as >>>> well. >>>> >>>> I had a quick look at QEMU and wasn't able to tell if PIOs and MMIOs >>>> address >>>> space are different on Arm as well. Paul, Stefano, do you know what they >>>> are >>>> doing? >>> >>> On the QEMU side, it looks like PIO (address_space_io) is used in >>> connection with the emulation of the "in" or "out" instructions, see >>> ioport.c:cpu_inb for instance. Some parts of PCI on QEMU emulate PIO >>> space regardless of the architecture, such as >>> hw/pci/pci_bridge.c:pci_bridge_initfn. >>> >>> However, because there is no "in" and "out" on ARM, I don't think >>> address_space_io can be accessed. Specifically, there is no equivalent >>> for target/i386/misc_helper.c:helper_inb on ARM. >> >> So how PCI I/O BAR are accessed? Surely, they could be used on Arm, right? > > PIO is also memory mapped on ARM and it seems to have its own MMIO > address window. This part is already well-understood :). However, this only tell us how an OS is accessing a PIO. What I am trying to figure out is how the hardware (or QEMU) is meant to work. From my understanding, the MMIO access will be received by the hostbridge and then forwarded to the appropriate PCI device. The two questions I am trying to answer is: How the I/O BARs are configured? Will it contain an MMIO address or an offset? If the answer is the latter, then we will need PIO because a DM will never see the MMIO address (the hostbridge will be emulated in Xen). I am still trying to navigate through the code and didn't manage to find an answer so far. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Aug 06 09:57:19 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 09:57:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3ce9-0005c9-NG; Thu, 06 Aug 2020 09:57:13 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3ce7-0005c4-SN for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 09:57:11 +0000 X-Inumbo-ID: 82258e23-b800-4150-b2ed-01af3552afdf Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 82258e23-b800-4150-b2ed-01af3552afdf; Thu, 06 Aug 2020 09:57:11 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7632EAC12; Thu, 6 Aug 2020 09:57:27 +0000 (UTC) Subject: Re: [PATCH v4 07/14] iommu: make map, unmap and flush all take both an order and a count To: Paul Durrant References: <20200804134209.8717-1-paul@xen.org> <20200804134209.8717-8-paul@xen.org> From: Jan Beulich Message-ID: <2765087f-4168-191d-c547-cbc2e74d3fee@suse.com> Date: Thu, 6 Aug 2020 11:57:12 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200804134209.8717-8-paul@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Tian , Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Paul Durrant , Ian Jackson , George Dunlap , Jun Nakajima , xen-devel@lists.xenproject.org, Volodymyr Babchuk , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 04.08.2020 15:42, Paul Durrant wrote: > From: Paul Durrant > > At the moment iommu_map() and iommu_unmap() take a page order but not a > count, whereas iommu_iotlb_flush() takes a count but not a page order. > This patch simply makes them consistent with each other. Why can't we do with just a count, where order gets worked out by functions knowing how to / wanting to deal with higher order pages? > --- a/xen/arch/x86/mm/p2m-ept.c > +++ b/xen/arch/x86/mm/p2m-ept.c > @@ -843,7 +843,7 @@ out: > need_modify_vtd_table ) > { > if ( iommu_use_hap_pt(d) ) > - rc = iommu_iotlb_flush(d, _dfn(gfn), (1u << order), > + rc = iommu_iotlb_flush(d, _dfn(gfn), (1u << order), 1, Forgot to drop the "1 << "? (There are then I think two more instances further down.) > --- a/xen/common/memory.c > +++ b/xen/common/memory.c > @@ -851,12 +851,12 @@ int xenmem_add_to_physmap(struct domain *d, struct xen_add_to_physmap *xatp, > > this_cpu(iommu_dont_flush_iotlb) = 0; > > - ret = iommu_iotlb_flush(d, _dfn(xatp->idx - done), done, > + ret = iommu_iotlb_flush(d, _dfn(xatp->idx - done), 0, done, Arguments wrong way round? (This risk of inverting their order is one of the primary reasons why I think we want just a count.) I'm also uncertain about the use of 0 vs PAGE_ORDER_4K here. > IOMMU_FLUSHF_added | IOMMU_FLUSHF_modified); > if ( unlikely(ret) && rc >= 0 ) > rc = ret; > > - ret = iommu_iotlb_flush(d, _dfn(xatp->gpfn - done), done, > + ret = iommu_iotlb_flush(d, _dfn(xatp->gpfn - done), 0, done, Same here then. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 10:19:26 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 10:19:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3czS-0007YK-PH; Thu, 06 Aug 2020 10:19:14 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3czR-0007YF-DH for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 10:19:13 +0000 X-Inumbo-ID: b1ca73ca-bc6a-4c02-ba21-a6d2383a8217 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b1ca73ca-bc6a-4c02-ba21-a6d2383a8217; Thu, 06 Aug 2020 10:19:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=SmE88vg8iPkyIESyDSppIYWzS5C1Aj/g36wK5TIZsdc=; b=v86h2BDL04C1eUr5+lM5gLvMqi D5rKp0d9mWTfWaGNISqbS+IPwFDMvaCUITsL2ROfOXhM18F9ODF3o9GeqD0j7zXbV9nomteQaQCP2 NV3ptGvwc4cugGwBJcQdjevy/n1iTtLDhMABALzSQhJM3sxw/xFRVjbIVbx2k3hJaiZE=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3czH-0007dz-2G; Thu, 06 Aug 2020 10:19:03 +0000 Received: from [54.239.6.186] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k3czG-0007Jv-MQ; Thu, 06 Aug 2020 10:19:02 +0000 Subject: Re: [RFC PATCH V1 04/12] xen/arm: Introduce arch specific bits for IOREQ/DM features To: Oleksandr References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-5-git-send-email-olekstysh@gmail.com> <8e8a394c-bd2a-4444-9f4b-e022c59e0f81@xen.org> From: Julien Grall Message-ID: <977d80d8-84b5-00dc-7ade-fab38a6ec84a@xen.org> Date: Thu, 6 Aug 2020 11:19:00 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Julien Grall , Jan Beulich , xen-devel@lists.xenproject.org, Daniel De Graaf , Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Hi, On 05/08/2020 16:41, Oleksandr wrote: > > On 05.08.20 12:32, Julien Grall wrote: > > Hi Julien. > >> Hi Stefano, >> >> On 05/08/2020 00:22, Stefano Stabellini wrote: >>> On Mon, 3 Aug 2020, Oleksandr Tyshchenko wrote: >>>> From: Oleksandr Tyshchenko >>>> >>>> This patch makes possible to forward Guest MMIO accesses >>>> to a device emulator on Arm and enables that support for >>>> Arm64. >>>> >>>> Also update XSM code a bit to let DM op be used on Arm. >>>> New arch DM op will be introduced in the follow-up patch. >>>> >>>> Please note, at the moment build on Arm32 is broken >>>> (see cmpxchg usage in hvm_send_buffered_ioreq()) if someone >>> >>> Speaking of buffered_ioreq, if I recall correctly, they were only used >>> for VGA-related things on x86. It looks like it is still true. >>> >>> If so, do we need it on ARM? Note that I don't think we can get rid of >>> it from the interface as it is baked into ioreq, but it might be >>> possible to have a dummy implementation on ARM. Or maybe not: looking at >>> xen/common/hvm/ioreq.c it looks like it would be difficult to >>> disentangle bufioreq stuff from the rest of the code. >> >> We possibly don't need it right now. However, this could possibly be >> used in the future (e.g. virtio notification doorbell). >> >>>> @@ -2275,6 +2282,16 @@ static void check_for_vcpu_work(void) >>>>    */ >>>>   void leave_hypervisor_to_guest(void) >>>>   { >>>> +#ifdef CONFIG_IOREQ_SERVER >>>> +    /* >>>> +     * XXX: Check the return. Shall we call that in >>>> +     * continue_running and context_switch instead? >>>> +     * The benefits would be to avoid calling >>>> +     * handle_hvm_io_completion on every return. >>>> +     */ >>> >>> Yeah, that could be a simple and good optimization >> >> Well, it is not simple as it is sounds :). handle_hvm_io_completion() >> is the function in charge to mark the vCPU as waiting for I/O. So we >> would at least need to split the function. >> >> I wrote this TODO because I wasn't sure about the complexity of >> handle_hvm_io_completion(current). Looking at it again, the main >> complexity is the looping over the IOREQ servers. >> >> I think it would be better to optimize handle_hvm_io_completion() >> rather than trying to hack the context_switch() or continue_running(). >> >> [...] >> >>>> diff --git a/xen/include/asm-arm/p2m.h b/xen/include/asm-arm/p2m.h >>>> index 5fdb6e8..5823f11 100644 >>>> --- a/xen/include/asm-arm/p2m.h >>>> +++ b/xen/include/asm-arm/p2m.h >>>> @@ -385,10 +385,11 @@ static inline int set_foreign_p2m_entry(struct >>>> domain *d, unsigned long gfn, >>>>                                           mfn_t mfn) >>>>   { >>>>       /* >>>> -     * NOTE: If this is implemented then proper reference counting of >>>> -     *       foreign entries will need to be implemented. >>>> +     * XXX: handle properly reference. It looks like the page may >>>> not always >>>> +     * belong to d. >>> >>> Just as a reference, and without taking away anything from the comment, >>> I think that QEMU is doing its own internal reference counting for these >>> mappings. >> >> I am not sure how this matters here? We can't really trust the DM to >> do the right thing if it is not running in dom0. >> >> But, IIRC, the problem is some of the pages doesn't belong to do a >> domain, so it is not possible to treat them as foreign mapping (e.g. >> you wouldn't be able to grab a reference). This investigation was done >> a couple of years ago, so this may have changed in recent Xen. >> >> As a side note, I am a bit surprised to see most of my original TODOs >> present in the code. What is the plan to solve them? > The plan is to solve most critical TODOs in current series, and rest in > follow-up series if no objections of course. Any pointers how to solve > them properly would be much appreciated. Unfortunately, now I have a > weak understanding how they should be fixed. AFAICT, there is already some discussion about those 3 major TODOs happening. I would suggest to go through the discussions. We can clarify anything if needed. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Aug 06 10:29:03 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 10:29:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3d8j-0008SI-Nt; Thu, 06 Aug 2020 10:28:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3d8i-0008SD-8v for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 10:28:48 +0000 X-Inumbo-ID: e8bdfaed-1eba-4c1b-93ba-e1b172916a3e Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e8bdfaed-1eba-4c1b-93ba-e1b172916a3e; Thu, 06 Aug 2020 10:28:46 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E67DDACB0; Thu, 6 Aug 2020 10:29:02 +0000 (UTC) Subject: Re: [PATCH v4 08/14] remove remaining uses of iommu_legacy_map/unmap To: Paul Durrant References: <20200804134209.8717-1-paul@xen.org> <20200804134209.8717-9-paul@xen.org> From: Jan Beulich Message-ID: <9d5a59cd-9e4e-2299-bc1c-af3c00a8719f@suse.com> Date: Thu, 6 Aug 2020 12:28:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200804134209.8717-9-paul@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Tian , Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Paul Durrant , Ian Jackson , George Dunlap , Jun Nakajima , xen-devel@lists.xenproject.org, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 04.08.2020 15:42, Paul Durrant wrote: > The 'legacy' functions do implicit flushing so amend the callers to do the > appropriate flushing. > > Unfortunately, because of the structure of the P2M code, we cannot remove > the per-CPU 'iommu_dont_flush_iotlb' global and the optimization it > facilitates. It is now checked directly iommu_iotlb_flush(). Also, it is > now declared as bool (rather than bool_t) and setting/clearing it are no > longer pointlessly gated on is_iommu_enabled() returning true. (Arguably > it is also pointless to gate the call to iommu_iotlb_flush() on that > condition - since it is a no-op in that case - but the if clause allows > the scope of a stack variable to be restricted). > > NOTE: The code in memory_add() now fails if the number of pages passed to > a single call overflows an unsigned int. I don't believe this will > ever happen in practice. I.e. you don't think adding 16Tb of memory in one go is possible? I wouldn't bet on that ... > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -2446,10 +2446,16 @@ static int cleanup_page_mappings(struct page_info *page) > > if ( d && unlikely(need_iommu_pt_sync(d)) && is_pv_domain(d) ) > { > - int rc2 = iommu_legacy_unmap(d, _dfn(mfn), PAGE_ORDER_4K); > + unsigned int flush_flags = 0; > + int err; > > + err = iommu_unmap(d, _dfn(mfn), PAGE_ORDER_4K, 1, &flush_flags); > if ( !rc ) > - rc = rc2; > + rc = err; > + > + err = iommu_iotlb_flush(d, _dfn(mfn), PAGE_ORDER_4K, 1, flush_flags); > + if ( !rc ) > + rc = err; > } Wasn't the earlier change to add flushing in the error case to allow to simplify code like this to if ( d && unlikely(need_iommu_pt_sync(d)) && is_pv_domain(d) ) { unsigned int flush_flags = 0; int err; err = iommu_unmap(d, _dfn(mfn), PAGE_ORDER_4K, 1, &flush_flags); if ( !err ) err = iommu_iotlb_flush(d, _dfn(mfn), PAGE_ORDER_4K, 1, flush_flags); if ( !rc ) rc = err; } ? > @@ -1441,9 +1446,16 @@ int clear_identity_p2m_entry(struct domain *d, unsigned long gfn_l) > > if ( !paging_mode_translate(d) ) > { > - if ( !is_iommu_enabled(d) ) > - return 0; > - return iommu_legacy_unmap(d, _dfn(gfn_l), PAGE_ORDER_4K); > + unsigned int flush_flags = 0; > + int err; > + > + ret = iommu_unmap(d, _dfn(gfn_l), PAGE_ORDER_4K, 1, &flush_flags); > + > + err = iommu_iotlb_flush(d, _dfn(gfn_l), PAGE_ORDER_4K, 1, flush_flags); > + if ( !ret ) > + ret = err; > + > + return ret; > } Similarly here then. > --- a/xen/arch/x86/x86_64/mm.c > +++ b/xen/arch/x86/x86_64/mm.c > @@ -1413,21 +1413,22 @@ int memory_add(unsigned long spfn, unsigned long epfn, unsigned int pxm) > !iommu_use_hap_pt(hardware_domain) && > !need_iommu_pt_sync(hardware_domain) ) > { > - for ( i = spfn; i < epfn; i++ ) > - if ( iommu_legacy_map(hardware_domain, _dfn(i), _mfn(i), > - PAGE_ORDER_4K, > - IOMMUF_readable | IOMMUF_writable) ) > - break; > - if ( i != epfn ) > - { > - while (i-- > old_max) > - /* If statement to satisfy __must_check. */ > - if ( iommu_legacy_unmap(hardware_domain, _dfn(i), > - PAGE_ORDER_4K) ) > - continue; > + unsigned int flush_flags = 0; > + unsigned int n = epfn - spfn; > + int rc; > > + ret = -EOVERFLOW; > + if ( spfn + n != epfn ) > + goto destroy_m2p; > + > + rc = iommu_map(hardware_domain, _dfn(i), _mfn(i), > + PAGE_ORDER_4K, n, IOMMUF_readable | IOMMUF_writable, > + &flush_flags); > + if ( !rc ) > + rc = iommu_iotlb_flush(hardware_domain, _dfn(i), PAGE_ORDER_4K, n, > + flush_flags); > + if ( rc ) > goto destroy_m2p; > - } > } Did you mean to use "ret" here instead of introducing "rc"? > --- a/xen/common/grant_table.c > +++ b/xen/common/grant_table.c > @@ -1225,11 +1225,23 @@ map_grant_ref( > kind = IOMMUF_readable; > else > kind = 0; > - if ( kind && iommu_legacy_map(ld, _dfn(mfn_x(mfn)), mfn, 0, kind) ) > + if ( kind ) > { > - double_gt_unlock(lgt, rgt); > - rc = GNTST_general_error; > - goto undo_out; > + dfn_t dfn = _dfn(mfn_x(mfn)); > + unsigned int flush_flags = 0; > + int err; > + > + err = iommu_map(ld, dfn, mfn, 0, 1, kind, &flush_flags); > + if ( !err ) > + err = iommu_iotlb_flush(ld, dfn, 0, 1, flush_flags); Question of 0 vs PAGE_ORDER_4K again. > @@ -1473,21 +1485,25 @@ unmap_common( > if ( rc == GNTST_okay && gnttab_need_iommu_mapping(ld) ) > { > unsigned int kind; > + dfn_t dfn = _dfn(mfn_x(op->mfn)); > + unsigned int flush_flags = 0; > int err = 0; > > double_gt_lock(lgt, rgt); > > kind = mapkind(lgt, rd, op->mfn); > if ( !kind ) > - err = iommu_legacy_unmap(ld, _dfn(mfn_x(op->mfn)), 0); > + err = iommu_unmap(ld, dfn, 0, 1, &flush_flags); > else if ( !(kind & MAPKIND_WRITE) ) > - err = iommu_legacy_map(ld, _dfn(mfn_x(op->mfn)), op->mfn, 0, > - IOMMUF_readable); > - > - double_gt_unlock(lgt, rgt); > + err = iommu_map(ld, dfn, op->mfn, 0, 1, IOMMUF_readable, > + &flush_flags); > > + if ( !err ) > + err = iommu_iotlb_flush(ld, dfn, 0, 1, flush_flags); > if ( err ) > rc = GNTST_general_error; > + > + double_gt_unlock(lgt, rgt); > } While moving the unlock ahead of the flush would be somewhat troublesome in the map case, it seems straightforward here. Even if this gets further adjusted by a later patch, it should imo be done here - the later patch may also go in much later. > --- a/xen/common/memory.c > +++ b/xen/common/memory.c > @@ -824,8 +824,7 @@ int xenmem_add_to_physmap(struct domain *d, struct xen_add_to_physmap *xatp, > xatp->gpfn += start; > xatp->size -= start; > > - if ( is_iommu_enabled(d) ) > - this_cpu(iommu_dont_flush_iotlb) = 1; > + this_cpu(iommu_dont_flush_iotlb) = true; Just like you replace the original instance here, ... > @@ -845,6 +844,8 @@ int xenmem_add_to_physmap(struct domain *d, struct xen_add_to_physmap *xatp, > } > } > > + this_cpu(iommu_dont_flush_iotlb) = false; > + > if ( is_iommu_enabled(d) ) > { > int ret; ... I'm sure you meant to also remove the original instance from down below here. > @@ -364,7 +341,7 @@ int iommu_iotlb_flush(struct domain *d, dfn_t dfn, unsigned int page_order, > int rc; > > if ( !is_iommu_enabled(d) || !hd->platform_ops->iotlb_flush || > - !page_count || !flush_flags ) > + !page_count || !flush_flags || this_cpu(iommu_dont_flush_iotlb) ) > return 0; The patch description ought to assure the safety of this change: So far, despite the flag set callers of iommu_iotlb_flush() (which may be unaware of the flag's state) did get what they did ask for. The change relies on there not being any such uses. > @@ -370,15 +362,12 @@ void iommu_dev_iotlb_flush_timeout(struct domain *d, struct pci_dev *pdev); > > /* > * The purpose of the iommu_dont_flush_iotlb optional cpu flag is to > - * avoid unecessary iotlb_flush in the low level IOMMU code. > - * > - * iommu_map_page/iommu_unmap_page must flush the iotlb but somethimes > - * this operation can be really expensive. This flag will be set by the > - * caller to notify the low level IOMMU code to avoid the iotlb flushes. > - * iommu_iotlb_flush/iommu_iotlb_flush_all will be explicitly called by > - * the caller. > + * avoid unecessary IOMMU flushing while updating the P2M. Correct the spelling of "unnecessary" at the same time? Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 11:08:37 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 11:08:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3dl5-0003Zi-Re; Thu, 06 Aug 2020 11:08:27 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3dl4-0003Zd-Eo for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 11:08:26 +0000 X-Inumbo-ID: 801f9e50-fc87-4094-a70f-c33bea81aa4d Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 801f9e50-fc87-4094-a70f-c33bea81aa4d; Thu, 06 Aug 2020 11:08:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RdG9A3SQ2LlYPQ4zlvqznH3SbKGcDOhgE31bU0J3MN8=; b=qOBrPPl9qh2QwAHG2Du+rwOTvf 0svHiUJvE8W/o+LrRAqhjGLi0Kx2rsOfIPGYzha4o3jjTzRaejgSIFqXGOYwYOMJncO0iNoxaqzij V7KVaskdyB7Kw3b8VeNYf6qj04u8lvuH9Vv0geG7yaBFFDCXt1EjPJBD/GL38i99ODno=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3dkt-0000JQ-8A; Thu, 06 Aug 2020 11:08:15 +0000 Received: from [54.239.6.186] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k3dks-0001mV-QD; Thu, 06 Aug 2020 11:08:15 +0000 Subject: Re: [RFC PATCH V1 04/12] xen/arm: Introduce arch specific bits for IOREQ/DM features To: Oleksandr , xen-devel@lists.xenproject.org References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-5-git-send-email-olekstysh@gmail.com> <11eaa2f0-84c7-5972-d14c-4cb02458e882@xen.org> <3ee50c66-8761-6c86-3fab-a4c23622d2b8@gmail.com> From: Julien Grall Message-ID: Date: Thu, 6 Aug 2020 12:08:12 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <3ee50c66-8761-6c86-3fab-a4c23622d2b8@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Julien Grall , Jan Beulich , Daniel De Graaf , Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 05/08/2020 20:30, Oleksandr wrote: > > On 05.08.20 17:12, Julien Grall wrote: >> Hi, > > Hi Julien > > >> >> On 03/08/2020 19:21, Oleksandr Tyshchenko wrote: >>> From: Oleksandr Tyshchenko >>> >>> This patch makes possible to forward Guest MMIO accesses >>> to a device emulator on Arm and enables that support for >>> Arm64. >>> >>> Also update XSM code a bit to let DM op be used on Arm. >>> New arch DM op will be introduced in the follow-up patch. >>> >>> Please note, at the moment build on Arm32 is broken >>> (see cmpxchg usage in hvm_send_buffered_ioreq()) if someone >>> wants to enable CONFIG_IOREQ_SERVER due to the lack of >>> cmpxchg_64 support on Arm32. >>> >>> Please note, this is a split/cleanup of Julien's PoC: >>> "Add support for Guest IO forwarding to a device emulator" >>> >>> Signed-off-by: Julien Grall >>> Signed-off-by: Oleksandr Tyshchenko >>> --- >>>   tools/libxc/xc_dom_arm.c        |  25 +++++++--- >>>   xen/arch/arm/Kconfig            |   1 + >>>   xen/arch/arm/Makefile           |   2 + >>>   xen/arch/arm/dm.c               |  34 +++++++++++++ >>>   xen/arch/arm/domain.c           |   9 ++++ >>>   xen/arch/arm/hvm.c              |  46 +++++++++++++++++- >>>   xen/arch/arm/io.c               |  67 +++++++++++++++++++++++++- >>>   xen/arch/arm/ioreq.c            |  86 >>> +++++++++++++++++++++++++++++++++ >>>   xen/arch/arm/traps.c            |  17 +++++++ >>>   xen/common/memory.c             |   5 +- >>>   xen/include/asm-arm/domain.h    |  80 +++++++++++++++++++++++++++++++ >>>   xen/include/asm-arm/hvm/ioreq.h | 103 >>> ++++++++++++++++++++++++++++++++++++++++ >>>   xen/include/asm-arm/mmio.h      |   1 + >>>   xen/include/asm-arm/p2m.h       |   7 +-- >>>   xen/include/xsm/dummy.h         |   4 +- >>>   xen/include/xsm/xsm.h           |   6 +-- >>>   xen/xsm/dummy.c                 |   2 +- >>>   xen/xsm/flask/hooks.c           |   5 +- >>>   18 files changed, 476 insertions(+), 24 deletions(-) >>>   create mode 100644 xen/arch/arm/dm.c >>>   create mode 100644 xen/arch/arm/ioreq.c >>>   create mode 100644 xen/include/asm-arm/hvm/ioreq.h >> >> It feels to me the patch is doing quite a few things that are >> indirectly related. Can this be split to make the review easier? >> >> I would like at least the following split from the series: >>    - The tools changes >>    - The P2M changes >>    - The HVMOP plumbing (if we still require them) > Sure, will split. > However, I don't quite understand where we should leave HVMOP plumbing. I think they will need to be droppped if we decide to use the acquire interface. > If I understand correctly the suggestion was to switch to acquire > interface instead (which requires a Linux version to be v4.17 at least)? This was the suggestion. > I suspect, this is all about "xen/privcmd: add > IOCTL_PRIVCMD_MMAP_RESOURCE" support for Linux? Correct. >> What is this function supposed to do? > Agree, sounds confusing a bit. I assume it is supposed to complete Guest > MMIO access after finishing emulation. > > Shall I rename it to something appropriate (maybe by adding ioreq prefix)? How about ioreq_handle_complete_mmio()? >>> diff --git a/xen/common/memory.c b/xen/common/memory.c >>> index 9283e5e..0000477 100644 >>> --- a/xen/common/memory.c >>> +++ b/xen/common/memory.c >>> @@ -8,6 +8,7 @@ >>>    */ >>>     #include >>> +#include >>>   #include >>>   #include >>>   #include >>> @@ -30,10 +31,6 @@ >>>   #include >>>   #include >>>   -#ifdef CONFIG_IOREQ_SERVER >>> -#include >>> -#endif >>> - >> >> Why do you remove something your just introduced? > The reason I guarded that header is to make "xen/mm: Make x86's > XENMEM_resource_ioreq_server handling common" (previous) patch buildable > on Arm > without arch IOREQ header added yet. I tried to make sure that the > result after each patch was buildable to retain bisectability. > As current patch adds Arm IOREQ specific bits (including header), that > guard could be removed as not needed anymore. I agree we want to have the build bisectable. However, I am still puzzled why it is necessary to remove the #ifdef and move it earlier in the list. Do you mind to provide more details? [...] >>> + >>> +bool handle_mmio(void); >>> + >>> +static inline bool handle_pio(uint16_t port, unsigned int size, int >>> dir) >>> +{ >>> +    /* XXX */ >> >> Can you expand this TODO? What do you expect to do? > I didn't expect this to be called on Arm. Sorry, I am not sure l have an > idea how to handle this properly. I would keep it unimplemented until a > real reason. > Will expand TODO. Let see how the conversation on patch#1 goes about PIO vs MMIO. >> >> >>> +    BUG(); >>> +    return true; >>> +} >>> + >>> +static inline paddr_t hvm_mmio_first_byte(const ioreq_t *p) >>> +{ >>> +    return p->addr; >>> +} >> >> I understand that the x86 version is more complex as it check p->df. >> However, aside reducing the complexity, I am not sure why we would >> want to diverge it. >> >> After all, IOREQ is now meant to be a common feature. > Well, no objections at all. > Could you please clarify how could 'df' (Direction Flag?) be > handled/used on Arm? On x86, this is used by 'rep' instruction to tell the direction to iterate (forward or backward). On Arm, all the accesses to MMIO region will do a single memory access. So for now, we can safely always set to 0. > I see that try_fwd_ioserv() always sets it 0. Or I > need to just reuse x86's helpers as is, > which (together with count = df = 0) will result in what we actually > have here? AFAIU, both count and df should be 0 on Arm. >> >> >>> + >>> +static inline int p2m_set_ioreq_server(struct domain *d, >>> +                                       unsigned int flags, >>> +                                       struct hvm_ioreq_server *s) >>> +{ >>> +    return -EOPNOTSUPP; >>> +} >> >> This should be defined in p2m.h. But I am not even sure what it is >> meant for. Can you expand it? > > ok, will move. > > > In this series I tried to make as much IOREQ code common as possible and > avoid complicating things, in order to achieve that a few stubs were > added here. Please note, > that I also considered splitting into arch parts. But some functions > couldn't be split easily. > This one is called from common hvm_destroy_ioreq_server() with flag > being 0 (which will result in unmapping ioreq server from p2m type on x86). > I could add a comment describing why this stub is present here. Sorry if I wasn't clear. I wasn't asking why the stub is there but what should be the expected implementation of the function. In particular, you are returning -EOPNOTSUPP. The only reason you are getting away from trouble is because the caller doesn't check the return. Would it make sense to have a stub arch_hvm_destroy_ioreq_server()? > > >> >> >>> + >>> +static inline void msix_write_completion(struct vcpu *v) >>> +{ >>> +} >>> + >>> +static inline void handle_realmode_completion(void) >>> +{ >>> +    ASSERT_UNREACHABLE(); >>> +} >> >> realmode is very x86 specific. So I don't think this function should >> be called from common code. It might be worth considering to split >> handle_hvm_io_completion() is 2 parts: common and arch specific. > > I agree with you that realmode is x86 specific and looks not good in Arm > header. It is not a problem of looking good or not. Instead, it is about abstraction. A developper shouldn't need to understand all the other architectures we support in order to follow the common code. > I was thinking how to split handle_hvm_io_completion() > gracefully but I failed find a good solution for that, so decided to add > two stubs (msix_write_completion and handle_realmode_completion) on Arm. > I could add a comment describing why they are here if appropriate. But > if you think they shouldn't be called from the common code in any way, I > will try to split it. I am not entirely sure what msix_write_completion is meant to do on x86. Is it dealing with virtual MSIx? Maybe Jan, Roger or Paul could help? Regarding handle_realmode_completion, I would add a new stub: arch_ioreq_handle_io_completion() that is called from the default case of the switch. On x86 it would be implemented as: switch (io_completion) { case HVMIO_realmode_completion: ... default: ASSERT_UNREACHABLE(); } On Arm, it would be implemented as: ASSERT_UNREACHABLE(); Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Aug 06 11:29:54 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 11:29:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3e5W-0005S4-NQ; Thu, 06 Aug 2020 11:29:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3e5U-0005Rz-JP for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 11:29:32 +0000 X-Inumbo-ID: a1f2031a-9104-4c36-9eac-0dd4c7461e03 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a1f2031a-9104-4c36-9eac-0dd4c7461e03; Thu, 06 Aug 2020 11:29:31 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E8A23ABE9; Thu, 6 Aug 2020 11:29:47 +0000 (UTC) Subject: Re: [RFC PATCH V1 04/12] xen/arm: Introduce arch specific bits for IOREQ/DM features To: Julien Grall References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-5-git-send-email-olekstysh@gmail.com> <11eaa2f0-84c7-5972-d14c-4cb02458e882@xen.org> <3ee50c66-8761-6c86-3fab-a4c23622d2b8@gmail.com> From: Jan Beulich Message-ID: Date: Thu, 6 Aug 2020 13:29:32 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr , Oleksandr Tyshchenko , Julien Grall , xen-devel@lists.xenproject.org, Daniel De Graaf , Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 06.08.2020 13:08, Julien Grall wrote: > On 05/08/2020 20:30, Oleksandr wrote: >> I was thinking how to split handle_hvm_io_completion() >> gracefully but I failed find a good solution for that, so decided to add >> two stubs (msix_write_completion and handle_realmode_completion) on Arm. >> I could add a comment describing why they are here if appropriate. But >> if you think they shouldn't be called from the common code in any way, I >> will try to split it. > > I am not entirely sure what msix_write_completion is meant to do on x86. > Is it dealing with virtual MSIx? Maybe Jan, Roger or Paul could help? Due to the split brain model of handling PCI pass-through (between Xen and qemu), a guest writing to an MSI-X entry needs this write handed to qemu, and upon completion of the write there Xen also needs to take some extra action. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 11:33:04 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 11:33:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3e8t-0006Fe-6t; Thu, 06 Aug 2020 11:33:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3e8s-0006FY-FM for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 11:33:02 +0000 X-Inumbo-ID: 1be2f495-e4d0-426c-b2dd-90b6e0f68c1d Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1be2f495-e4d0-426c-b2dd-90b6e0f68c1d; Thu, 06 Aug 2020 11:33:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QEUACFtf1ypg40cHhach0sxa3XyW//gtxv0Kq651cec=; b=qin4aG7TJrvGaULxGuWV2IxBiR ofEFRWQHg/tQ4cFL9W8ySQo0TurKUMiMXvBh0LNtlJ3kk5eAU08fSOOt2vJZegPZn+arq+fvsWWnq FqNyfXFvsWgL3cE5JOfD1Iu+WuzY9H4ChBssGsE0hszh+Trwn7GKndmA4xUl6NvDMPtI=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3e8l-0000q7-Nd; Thu, 06 Aug 2020 11:32:55 +0000 Received: from [54.239.6.187] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k3e8l-00035u-Ey; Thu, 06 Aug 2020 11:32:55 +0000 Subject: Re: [RFC PATCH V1 05/12] hvm/dm: Introduce xendevicemodel_set_irq_level DM op To: Stefano Stabellini References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-6-git-send-email-olekstysh@gmail.com> <00e261e0-295a-9cd8-ed11-7e3801a4eb58@xen.org> From: Julien Grall Message-ID: <92e2b136-8468-2877-0e8c-c13ff2a0a1fb@xen.org> Date: Thu, 6 Aug 2020 12:32:52 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Oleksandr Tyshchenko , Julien Grall , Jan Beulich , xen-devel@lists.xenproject.org, Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Hi Stefano, On 06/08/2020 01:37, Stefano Stabellini wrote: > On Wed, 5 Aug 2020, Julien Grall wrote: >> On 05/08/2020 00:22, Stefano Stabellini wrote: >>> On Mon, 3 Aug 2020, Oleksandr Tyshchenko wrote: >>>> From: Oleksandr Tyshchenko >>>> >>>> This patch adds ability to the device emulator to notify otherend >>>> (some entity running in the guest) using a SPI and implements Arm >>>> specific bits for it. Proposed interface allows emulator to set >>>> the logical level of a one of a domain's IRQ lines. >>>> >>>> Please note, this is a split/cleanup of Julien's PoC: >>>> "Add support for Guest IO forwarding to a device emulator" >>>> >>>> Signed-off-by: Julien Grall >>>> Signed-off-by: Oleksandr Tyshchenko >>>> --- >>>> tools/libs/devicemodel/core.c | 18 ++++++++++++++++++ >>>> tools/libs/devicemodel/include/xendevicemodel.h | 4 ++++ >>>> tools/libs/devicemodel/libxendevicemodel.map | 1 + >>>> xen/arch/arm/dm.c | 22 >>>> +++++++++++++++++++++- >>>> xen/common/hvm/dm.c | 1 + >>>> xen/include/public/hvm/dm_op.h | 15 +++++++++++++++ >>>> 6 files changed, 60 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/tools/libs/devicemodel/core.c b/tools/libs/devicemodel/core.c >>>> index 4d40639..30bd79f 100644 >>>> --- a/tools/libs/devicemodel/core.c >>>> +++ b/tools/libs/devicemodel/core.c >>>> @@ -430,6 +430,24 @@ int xendevicemodel_set_isa_irq_level( >>>> return xendevicemodel_op(dmod, domid, 1, &op, sizeof(op)); >>>> } >>>> +int xendevicemodel_set_irq_level( >>>> + xendevicemodel_handle *dmod, domid_t domid, uint32_t irq, >>>> + unsigned int level) >>> >>> It is a pity that having xen_dm_op_set_pci_intx_level and >>> xen_dm_op_set_isa_irq_level already we need to add a third one, but from >>> the names alone I don't think we can reuse either of them. >> >> The problem is not the name... >> >>> >>> It is very similar to set_isa_irq_level. We could almost rename >>> xendevicemodel_set_isa_irq_level to xendevicemodel_set_irq_level or, >>> better, just add an alias to it so that xendevicemodel_set_irq_level is >>> implemented by calling xendevicemodel_set_isa_irq_level. Honestly I am >>> not sure if it is worth doing it though. Any other opinions? >> >> ... the problem is the interrupt field is only 8-bit. So we would only be able >> to cover IRQ 0 - 255. > > Argh, that's not going to work :-( I wasn't sure if it was a good idea > anyway. > > >> It is not entirely clear how the existing subop could be extended without >> breaking existing callers. >> >>> But I think we should plan for not needing two calls (one to set level >>> to 1, and one to set it to 0): >>> https://marc.info/?l=xen-devel&m=159535112027405 >> >> I am not sure to understand your suggestion here? Are you suggesting to remove >> the 'level' parameter? > > My hope was to make it optional to call the hypercall with level = 0, > not necessarily to remove 'level' from the struct. From my understanding, the hypercall is meant to represent the status of the line between the device and the interrupt controller (either low or high). This is then up to the interrupt controller to decide when the interrupt is going to be fired: - For edge interrupt, this will fire when the line move from low to high (or vice versa). - For level interrupt, this will fire when line is high (assuming level trigger high) and will keeping firing until the device decided to lower the line. For a device, it is common to keep the line high until an OS wrote to a specific register. Furthermore, technically, the guest OS is in charge to configure how an interrupt is triggered. Admittely this information is part of the DT, but nothing prevent a guest to change it. As side note, we have a workaround in Xen for some buggy DT (see the arch timer) exposing the wrong trigger type. Because of that, I don't really see a way to make optional. Maybe you have something different in mind? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Aug 06 11:36:08 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 11:36:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3eBn-0006PS-Lm; Thu, 06 Aug 2020 11:36:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3eBm-0006PL-7n for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 11:36:02 +0000 X-Inumbo-ID: f9a4220f-4b5b-4088-86bb-f3b9e75aa515 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f9a4220f-4b5b-4088-86bb-f3b9e75aa515; Thu, 06 Aug 2020 11:36:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8iWgTxKYT/IHAOXP87qxT1QL7H18LTKdd2MXZH7yLDU=; b=p87upvN7VG2RgeRFxEmi28tYIi UYhl1xhvJH0pW+GJz40TESgDyBBzNLqMDgh0nSVfoD8FmyHNgoF+ueItj6iG8zoK74P7y7O3mTdDb slQ8sPwn8RRzNr15FZNZX7jMNNd62iXJ3I3yD/xHLRoxh6xVQzIn0FIUKHPod1kjrr+M=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3eBj-0000so-8b; Thu, 06 Aug 2020 11:35:59 +0000 Received: from [54.239.6.185] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k3eBj-0003MP-1n; Thu, 06 Aug 2020 11:35:59 +0000 Subject: Re: [RFC PATCH V1 08/12] xen/arm: Invalidate qemu mapcache on XENMEM_decrease_reservation To: Jan Beulich , Oleksandr Tyshchenko References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-9-git-send-email-olekstysh@gmail.com> <21b7d8ed-f305-8abe-0e4e-174d72d087c8@suse.com> From: Julien Grall Message-ID: Date: Thu, 6 Aug 2020 12:35:56 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <21b7d8ed-f305-8abe-0e4e-174d72d087c8@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Hi Jan, On 05/08/2020 17:21, Jan Beulich wrote: > On 03.08.2020 20:21, Oleksandr Tyshchenko wrote: >> --- a/xen/common/memory.c >> +++ b/xen/common/memory.c >> @@ -1652,6 +1652,12 @@ long do_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg) >> break; >> } >> >> + /* x86 already sets the flag in hvm_memory_op() */ >> +#if defined(CONFIG_ARM64) && defined(CONFIG_IOREQ_SERVER) >> + if ( op == XENMEM_decrease_reservation ) >> + curr_d->arch.hvm.qemu_mapcache_invalidate = true; >> +#endif > > Doesn't the comment already indicate a route towards an approach > not requiring to alter common code? Given that IOREQ is now moved under common/, I think it would make sense to have this set in common code as well for all the architecture. IOW, I would suggest to drop the #ifdef CONFIG_ARM64. In addition, we may want to introduce an helper to check if a domain is using ioreq. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Aug 06 11:37:49 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 11:37:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3eDV-0006Vm-1G; Thu, 06 Aug 2020 11:37:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3eDT-0006Vg-Qg for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 11:37:47 +0000 X-Inumbo-ID: 3e76ec6e-369b-4b10-abc5-867b43a3a818 Received: from mail-lj1-x242.google.com (unknown [2a00:1450:4864:20::242]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3e76ec6e-369b-4b10-abc5-867b43a3a818; Thu, 06 Aug 2020 11:37:47 +0000 (UTC) Received: by mail-lj1-x242.google.com with SMTP id z14so13780622ljm.1 for ; Thu, 06 Aug 2020 04:37:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=3qvrv2NcCrVhNCjBXcmn6ydC3U+4juJl4Q8+G+Je9Zk=; b=BdCPfklsNJcLwrOcGt/pIEQva8ijnwCjRAtFio+TZ/jR5Uhiux8Z/AmMrcdntQeFXp 553h3r/EmRU88emS7/btRuN3NZ6tmL+EVe0xOpiMD09qFIp0BG7GZknw/BQHN3b78tZW IPJrlMYe4135gwUkMmecWBdSUvxSGYTXt7jm4ypAQj5HaB8Ei4HApS93Zbzi+Qbyg82m WJmBD+Nc9aowWNfDiw7V+uKcE+BBWOuid7RED66DFw6itKw0Xpe9mp4ewpLcZonflm/p 2+T+taXYyfbkmumprNqzWlezzmo8FhEte6yLj6u6Whi8JyQHrB90X44tnQisEoc0GUnf FAXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=3qvrv2NcCrVhNCjBXcmn6ydC3U+4juJl4Q8+G+Je9Zk=; b=bThR6+kZxB3/I3cCHm/OUfusDgvT6DgEFMkAj8pqlOR5WpY7HF53m2TFVGbXCRBEN/ aVoHeCL9w2F7ahARGg20len4cbKLwTP01svtFMYT82+ZZx6g8XkNL2TSJX0s9xcSFpAE ClQqY4BLAznRWD4NjvfV00/p597OYBHNiQg7kn8t8NdCMdF9Ia5XV3E5rx2t9b1apQTG R6iiN8FWQsnJRZYytyFPRGlxsbB0RmDGKbe+JfnbNC0WQJDswxVu3cpEZ8zKLNjO5vc6 AAxofemvsCBj5uucqtl8NYix/HH0rbfzTtZ+7fDpLmi6wItjLOPLEU63aSSx+4/5IyXZ IJXQ== X-Gm-Message-State: AOAM533KQJPXkyrQ4VnmHwxiDA+T+5hqrO715NPSqFozuwxMax8C8pQA 74RsKD2o4IYdBeJLGN3MqbM= X-Google-Smtp-Source: ABdhPJwIz48LYBOkFJt9OBx2MfKKXy/WzkbfWa5xcacF/QjLGvR5GGktIpH29IDVMhsea39NomdmVw== X-Received: by 2002:a2e:b00f:: with SMTP id y15mr3844992ljk.223.1596713865812; Thu, 06 Aug 2020 04:37:45 -0700 (PDT) Received: from [192.168.1.2] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id l5sm2304962ljh.56.2020.08.06.04.37.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2020 04:37:45 -0700 (PDT) Subject: Re: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common To: Julien Grall , xen-devel@lists.xenproject.org References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-2-git-send-email-olekstysh@gmail.com> <6bfc3920-8f29-188c-cff4-2b99dabe166f@xen.org> From: Oleksandr Message-ID: Date: Thu, 6 Aug 2020 14:37:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <6bfc3920-8f29-188c-cff4-2b99dabe166f@xen.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Tian , Stefano Stabellini , Jan Beulich , Wei Liu , Paul Durrant , Andrew Cooper , Ian Jackson , George Dunlap , Tim Deegan , Oleksandr Tyshchenko , Julien Grall , Jun Nakajima , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 05.08.20 16:30, Julien Grall wrote: > Hi, Hi Julien > > On 03/08/2020 19:21, Oleksandr Tyshchenko wrote: >> From: Oleksandr Tyshchenko >> >> As a lot of x86 code can be re-used on Arm later on, this patch >> splits IOREQ support into common and arch specific parts. >> >> This support is going to be used on Arm to be able run device >> emulator outside of Xen hypervisor. >> >> Please note, this is a split/cleanup of Julien's PoC: >> "Add support for Guest IO forwarding to a device emulator" >> >> Signed-off-by: Julien Grall >> Signed-off-by: Oleksandr Tyshchenko >> --- >>   xen/arch/x86/Kconfig            |    1 + >>   xen/arch/x86/hvm/dm.c           |    2 +- >>   xen/arch/x86/hvm/emulate.c      |    2 +- >>   xen/arch/x86/hvm/hvm.c          |    2 +- >>   xen/arch/x86/hvm/io.c           |    2 +- >>   xen/arch/x86/hvm/ioreq.c        | 1431 >> +-------------------------------------- >>   xen/arch/x86/hvm/stdvga.c       |    2 +- >>   xen/arch/x86/hvm/vmx/realmode.c |    1 + >>   xen/arch/x86/hvm/vmx/vvmx.c     |    2 +- >>   xen/arch/x86/mm.c               |    2 +- >>   xen/arch/x86/mm/shadow/common.c |    2 +- >>   xen/common/Kconfig              |    3 + >>   xen/common/Makefile             |    1 + >>   xen/common/hvm/Makefile         |    1 + >>   xen/common/hvm/ioreq.c          | 1430 >> ++++++++++++++++++++++++++++++++++++++ >>   xen/include/asm-x86/hvm/ioreq.h |   45 +- >>   xen/include/asm-x86/hvm/vcpu.h  |    7 - >>   xen/include/xen/hvm/ioreq.h     |   89 +++ >>   18 files changed, 1575 insertions(+), 1450 deletions(-) > > That's quite a lot of code moved in a single patch. How can we check > the code moved is still correct? Is it a verbatim copy? In this patch I mostly tried to separate a common IOREQ part which also resulted in updating x86 sources to include new header.  Also I moved hvm_ioreq_needs_completion() to common header (which probably wanted to be in a separate patch). It was a verbatim copy initially (w/o hvm_map_mem_type_to_ioreq_server) and then updated to deal with arch specific parts. In which way do you want me to split this patch? I could think of the following: 1. Copy of x86's ioreq.c/ioreq.h to common code 2. Update common ioreq.c/ioreq.h 3. Update x86's parts to be able to deal with common code 4. Move hvm_ioreq_needs_completion() to common code -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Thu Aug 06 11:41:22 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 11:41:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3eGp-0007Mz-HJ; Thu, 06 Aug 2020 11:41:15 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3eGo-0007Mu-9X for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 11:41:14 +0000 X-Inumbo-ID: ae7ea68d-7cb1-4847-a5a7-ea9201b2b85e Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ae7ea68d-7cb1-4847-a5a7-ea9201b2b85e; Thu, 06 Aug 2020 11:41:13 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F076DAC3F; Thu, 6 Aug 2020 11:41:29 +0000 (UTC) Subject: Re: [PATCH v4 06/14] iommu: flush I/O TLB if iommu_map() or iommu_unmap() fail To: Paul Durrant References: <20200804134209.8717-1-paul@xen.org> <20200804134209.8717-7-paul@xen.org> From: Jan Beulich Message-ID: <13baa3ec-b038-32a5-a99a-3fb122b984a8@suse.com> Date: Thu, 6 Aug 2020 13:41:14 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200804134209.8717-7-paul@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Paul Durrant Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 04.08.2020 15:42, Paul Durrant wrote: > --- a/xen/drivers/passthrough/iommu.c > +++ b/xen/drivers/passthrough/iommu.c > @@ -274,6 +274,10 @@ int iommu_map(struct domain *d, dfn_t dfn, mfn_t mfn, > break; > } > > + /* Something went wrong so flush everything and clear flush flags */ > + if ( unlikely(rc) && iommu_iotlb_flush_all(d, *flush_flags) ) > + flush_flags = 0; Noticed only while looking at patch 9: There's also an indirection missing both here and ... > @@ -330,6 +328,10 @@ int iommu_unmap(struct domain *d, dfn_t dfn, unsigned int page_order, > } > } > > + /* Something went wrong so flush everything and clear flush flags */ > + if ( unlikely(rc) && iommu_iotlb_flush_all(d, *flush_flags) ) > + flush_flags = 0; ... here. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 11:44:52 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 11:44:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3eKI-0007WN-1H; Thu, 06 Aug 2020 11:44:50 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3eKG-0007WH-VD for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 11:44:49 +0000 X-Inumbo-ID: 28d2d612-df76-4d1a-9f34-5c38c085f630 Received: from mail-40133.protonmail.ch (unknown [185.70.40.133]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 28d2d612-df76-4d1a-9f34-5c38c085f630; Thu, 06 Aug 2020 11:44:46 +0000 (UTC) Date: Thu, 06 Aug 2020 11:44:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trmm.net; s=protonmail; t=1596714285; bh=KNAMclvymDk/FZJ4GGKyc5K4JCgXd7BWu3UZZXVnjNY=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=cAGhqfJRP7NQx7ae+o6KImXDmDJ/pI+WQjOH4Mv1q3Vw7NPe7xhapLtCwcEKRoxBF kSE/m1RaFHs/zUd0Ovt5fDA0kq/IH8kLISgBsRytHtG1FrH8WFqT84nNHrAOzcovqG ZRlFVaL8XIiPZOc1//vYsxR1N+To1RHxhXALRyxQ= To: Jan Beulich From: Trammell Hudson Subject: Re: [RFC] efi/boot: Unified Xen executable for UEFI Secure Boot support Message-ID: In-Reply-To: <1bd2d79e-5bef-835c-f6cc-9fd367e8beb7@suse.com> References: <1bd2d79e-5bef-835c-f6cc-9fd367e8beb7@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: Trammell Hudson Cc: "xen-devel@lists.xenproject.org" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Thursday, August 6, 2020 9:57 AM, Jan Beulich wrote: > On 05.08.2020 19:20, Trammell Hudson wrote: > > This preliminary patch adds support for bundling the Xen hypervisor, xe= n.cfg, > > the Linux kernel, initrd and XSM into a single "unified" EFI executable= that > > can be signed by sbsigntool for verification by UEFI Secure Boot. [...] > > Looks reasonable for a PoC, thanks, but needs cleaning up I think. Thanks for the comments. It is very much a WIP and hopefully we can clean it up for merging. > A couple of specific remarks / questions: > > [...] > > - /* PE32+ Subsystem type */ > > - if (pe->FileHeader.Machine !=3D PE_HEADER_MACHINE_X64 > > - && pe->FileHeader.Machine !=3D PE_HEADER_MACHINE_ARM64 > > - && pe->FileHeader.Machine !=3D PE_HEADER_MACHINE_I386) > > - return NULL; > > I don't think i386 should be recognized here, and of the two other > ones only the one matching the current target architecture should > be. That's a good point. There isn't much point in proceeding if Xen can't boot the executable anyway... > > - if ( pe->FileHeader.NumberOfSections > 96 ) > > - return NULL; > > What's this 96 about? Not sure, to be honest. The PE parsing code is directly copied from systemd-boot (including the bit about ARM and i386): https://github.com/systemd/systemd/blob/07d5ed536ec0a76b08229c7a80b910cb9ac= af6b1/src/boot/efi/pe.c#L83 > Overall I think it might help if this PE parsing code (if UEFI > doesn't offer a protocol to do it for us) was put into its own > source file. I tried to putting it into a separate file and ran into link issues, seems that it needs to be mentioned in both arch/x86/Makefile and arch/x86/pe/Makefile, so this was a "just make it work" for the PoC. Now that it is working, I'll go back to see if I can figure out the makefile magic. > I also wonder if it wouldn't better be optional > (i.e. depend on a Kconfig option). My preference would be to have it always on so that any Xen executable can be unified and signed by the end user, rather than requiring the user to do a separate build from source. For instance, the Qubes install DVD has a normal xen.efi, but I can generate my own signed version for my system by unifying it with the kernel and initrd. > > - if ( efi_rs->GetVariable(L"SecureBoot", (EFI_GUID *)&global_guid, N= ULL, &size, buf) !=3D EFI_SUCCESS ) > > - return false; > > - return buf[0] !=3D 0; > > I.e. "SecureBoot=3DN" still means "enabled"? Maybe? UEFI 2.8, section 3.3 "Global Variables" says for SecureBoot: "Whether the platform firmware is operating in Secure boot mode (1) or not = (0). All other values are reserved. Should be treated as read-only." > [...] > "secure" depending merely on an env var, how is this logic compatible > with the shim model? You need to keep the other approach working. Oops. Yes, I broke the shim model when booting in non-unified way with SecureBoot enabled. > Also, considering kernel and initrd are embedded, is there really a > strict need for a config file? It would seem to me that you could > boot the system fine without. The config file is still necessary for Xen options (console, etc) as well as the kernel command line. > [...] > Once you know whether you're dealing with a "unified" image, you > shouldn't have a need to make logic dependent upon read_section() > finding a particular section: Either you find all of them (and > don't even try to interpret respective config file settings), or > you read everything from disk. Another option that might be better would be to have a "special" file name -- if the config file has a leading "." then read_file() could do the PE section search instead of going to the disk. That way the config file could have some things on disk, and some things unified. For instance, microcode doesn't (always) need to be signed, since it is already signed and encrypted by Intel. Many OEM's leave the ucode regions of flash unprotected by bootguard, which allows the end user to update the microcode without requiring an OEM signature. This does potentially leave open some rollback attacks, so I'm not 100% positive it is a good idea (although the firmware volume should still be measured into the TPM and things like SGX include the microcode version in the attestation). > > --- /dev/null > > +++ b/xen/scripts/unify-xen > > @@ -0,0 +1,68 @@ > > +#!/bin/bash > > +# Merge a Linux kernel, initrd and commandline into xen.efi to produce= a single signed > > +# EFI executable. > > +# > > +# turn off "expressions don't expand in single quotes" > > +# and "can't follow non-constant sources" > > +# shellcheck disable=3DSC2016 disable=3DSC1090 > > What are these three lines about? Those are hold-overs from the safeboot script that I borrowed this from. When linting the script with shellcheck, it complains about sourcing files based on environment variables, and some code that has '$' in single quotes. This script is definitely NOT ready for inclusion and is just an example of how to use objcopy to build the unified image. A more full-featured unify script could take the xen.cfg file and use it to locate the kernel, initrd, xsm, ucode, etc instead of hard coded command line arguments. I'm surprised that systemd-boot doesn't have a proper script; their tutorials show how to run a raw objcopy command, which is about as user unfriendly as possible... > [...] > > +# Xen goes up to a pad at 00400000 > > "pad at 00400000"? $ objdump -h xen.efi xen.efi: file format pei-x86-64 Sections: Idx Name Size VMA LMA File off A= lgn [...] 8 .pad 00400000 ffff82d040c00000 ffff82d040c00000 00000000 2= **2 ALLOC There is this pad at the end of the image; I wasn't sure if it was importan= t, so I had the script deposit the extra sections after it. Hopefully there i= s someway to automatically figure out the correct address for the additional segments. > > +XEN=3D"$1" > > +CONFIG=3D"$2" > > +KERNEL=3D"$3" > > +RAMDISK=3D"$4" > > What about ucode and xsm policy? Yeah... Did I mention this is a total hack? It looks like microcode is handled in efi_arch_cfg_file_late(), so it will need to be updated. If the read_file() change is made, then it would automatically do the right thing. > > > +objcopy \ > > - --add-section .kernel=3D"$KERNEL" \ > > - --add-section .ramdisk=3D"$RAMDISK" \ > > - --add-section .config=3D"$CONFIG" \ > > - --change-section-vma .config=3D0xffff82d041000000 \ > > - --change-section-vma .kernel=3D0xffff82d041010000 \ > > - --change-section-vma .ramdisk=3D0xffff82d042000000 \ > > Of course these hard coded numbers will be eliminated in the > long run? Ideally. We could try to parse out the address based on the objdump output= , although oddly systemd-boot has hardcoded ones as well. [...] > > - warn "$OUTDIR/linux.efi: signature failed! Try $try." > > +done > > Why the retries? (Also leftover "linux.efi" in the warning?) The sbsign could be moved into a separate script or example. The retries in the safeboot script are because this happens after the dm-verity hashes have been computed, which takes a while, so it is a better user experience to give them another chance if they mis-type their signing key password (or haven't yet plugged in the yubikey). Thanks again for the comments! I'm really hopeful that we can have Xen interoperating with UEFI SecureBoot sometime soon! -- Trammell From xen-devel-bounces@lists.xenproject.org Thu Aug 06 11:49:15 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 11:49:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3eOV-0007he-NN; Thu, 06 Aug 2020 11:49:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3eOU-0007gT-Sy for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 11:49:10 +0000 X-Inumbo-ID: 9dacde75-e8e7-4001-86d1-28b9cd188ad8 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9dacde75-e8e7-4001-86d1-28b9cd188ad8; Thu, 06 Aug 2020 11:49:10 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8E2BCAE18; Thu, 6 Aug 2020 11:49:26 +0000 (UTC) Subject: Re: [PATCH v4 09/14] common/grant_table: batch flush I/O TLB To: Paul Durrant References: <20200804134209.8717-1-paul@xen.org> <20200804134209.8717-10-paul@xen.org> From: Jan Beulich Message-ID: <4f533589-4df9-59d3-d238-cb46d292e16d@suse.com> Date: Thu, 6 Aug 2020 13:49:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200804134209.8717-10-paul@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Paul Durrant , Ian Jackson , George Dunlap , xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 04.08.2020 15:42, Paul Durrant wrote: > From: Paul Durrant > > This patch avoids calling iommu_iotlb_flush() for each individual GNTTABOP and > insteads calls iommu_iotlb_flush_all() at the end of the hypercall. This > should mean batched map/unmap operations perform better but may be slightly > detrimental to singleton performance. I would strongly suggest keeping singleton operations do single-DFN flushes. > @@ -1329,20 +1326,30 @@ gnttab_map_grant_ref( > return i; This one line is part of a path which you can't bypass as far as flushing is concerned. In this regard the description is also slightly misleading: It's not just "at the end of the hypercall" when flushing needs doing, but also on every preemption. > if ( unlikely(__copy_from_guest_offset(&op, uop, i, 1)) ) > - return -EFAULT; > + { > + rc = -EFAULT; > + break; > + } > > - map_grant_ref(&op); > + map_grant_ref(&op, &flush_flags); > > if ( unlikely(__copy_to_guest_offset(uop, i, &op, 1)) ) > - return -EFAULT; > + { > + rc = -EFAULT; > + break; > + } > } > > - return 0; > + err = iommu_iotlb_flush_all(current->domain, flush_flags); > + if ( !rc ) > + rc = err; Not sure how important it is to retain performance upon errors: Strictly speaking there's no need to flush when i == 0 and rc != 0. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 11:50:50 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 11:50:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3eQ6-0008Re-2O; Thu, 06 Aug 2020 11:50:50 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3eQ4-0008RL-DL for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 11:50:48 +0000 X-Inumbo-ID: 6e7b2b75-82f7-4ce2-8e9f-5c67a3e2fe8c Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6e7b2b75-82f7-4ce2-8e9f-5c67a3e2fe8c; Thu, 06 Aug 2020 11:50:47 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 42F49AE18; Thu, 6 Aug 2020 11:51:04 +0000 (UTC) Subject: Re: [RFC PATCH V1 08/12] xen/arm: Invalidate qemu mapcache on XENMEM_decrease_reservation To: Julien Grall References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-9-git-send-email-olekstysh@gmail.com> <21b7d8ed-f305-8abe-0e4e-174d72d087c8@suse.com> From: Jan Beulich Message-ID: <04cfd6e4-1ed0-52c3-a3b0-d555d9dc632b@suse.com> Date: Thu, 6 Aug 2020 13:50:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 06.08.2020 13:35, Julien Grall wrote: > On 05/08/2020 17:21, Jan Beulich wrote: >> On 03.08.2020 20:21, Oleksandr Tyshchenko wrote: >>> --- a/xen/common/memory.c >>> +++ b/xen/common/memory.c >>> @@ -1652,6 +1652,12 @@ long do_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg) >>> break; >>> } >>> >>> + /* x86 already sets the flag in hvm_memory_op() */ >>> +#if defined(CONFIG_ARM64) && defined(CONFIG_IOREQ_SERVER) >>> + if ( op == XENMEM_decrease_reservation ) >>> + curr_d->arch.hvm.qemu_mapcache_invalidate = true; >>> +#endif >> >> Doesn't the comment already indicate a route towards an approach >> not requiring to alter common code? > > Given that IOREQ is now moved under common/, I think it would make sense > to have this set in common code as well for all the architecture. > > IOW, I would suggest to drop the #ifdef CONFIG_ARM64. In addition, we > may want to introduce an helper to check if a domain is using ioreq. Of course, with the (part of the) conditional dropped and the struct field moved out of the arch sub-struct, this is fine to live here. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 12:04:52 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 12:04:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3edX-0001CW-Mp; Thu, 06 Aug 2020 12:04:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3edW-0001CO-E4 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 12:04:42 +0000 X-Inumbo-ID: 5ccde9d2-8749-4329-9cb7-b4be8137846f Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5ccde9d2-8749-4329-9cb7-b4be8137846f; Thu, 06 Aug 2020 12:04:41 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D3417ACC6; Thu, 6 Aug 2020 12:04:57 +0000 (UTC) Subject: Re: [RFC] efi/boot: Unified Xen executable for UEFI Secure Boot support To: Trammell Hudson References: <1bd2d79e-5bef-835c-f6cc-9fd367e8beb7@suse.com> From: Jan Beulich Message-ID: <5e3b16b3-0f93-4683-dcc7-852c805870c8@suse.com> Date: Thu, 6 Aug 2020 14:04:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 06.08.2020 13:44, Trammell Hudson wrote: > On Thursday, August 6, 2020 9:57 AM, Jan Beulich wrote: >> Overall I think it might help if this PE parsing code (if UEFI >> doesn't offer a protocol to do it for us) was put into its own >> source file. > > I tried to putting it into a separate file and ran into link issues, > seems that it needs to be mentioned in both arch/x86/Makefile and > arch/x86/pe/Makefile, so this was a "just make it work" for the PoC. > Now that it is working, I'll go back to see if I can figure out the > makefile magic. I was rather thinking of e.g. xen/common/efi/pe.c. >> I also wonder if it wouldn't better be optional >> (i.e. depend on a Kconfig option). > > My preference would be to have it always on so that any Xen > executable can be unified and signed by the end user, rather than > requiring the user to do a separate build from source. For instance, > the Qubes install DVD has a normal xen.efi, but I can generate my own > signed version for my system by unifying it with the kernel and > initrd. It's still a choice that can be left to the distro imo. In particular embedded use cases may want to save the extra logic. >>> - if ( efi_rs->GetVariable(L"SecureBoot", (EFI_GUID *)&global_guid, NULL, &size, buf) != EFI_SUCCESS ) >>> - return false; >>> - return buf[0] != 0; >> >> I.e. "SecureBoot=N" still means "enabled"? > > Maybe? UEFI 2.8, section 3.3 "Global Variables" says for SecureBoot: > > "Whether the platform firmware is operating in Secure boot mode (1) or not (0). All other values > are reserved. Should be treated as read-only." But in your expression that's then presumably '0', not 0? >> Also, considering kernel and initrd are embedded, is there really a >> strict need for a config file? It would seem to me that you could >> boot the system fine without. > > The config file is still necessary for Xen options (console, etc) as > well as the kernel command line. But command line options are optional. Yes, you need a config file if you want to pass any options. But you may be able to get away without command line options, and hence without config file. >> [...] >> Once you know whether you're dealing with a "unified" image, you >> shouldn't have a need to make logic dependent upon read_section() >> finding a particular section: Either you find all of them (and >> don't even try to interpret respective config file settings), or >> you read everything from disk. > > Another option that might be better would be to have a "special" > file name -- if the config file has a leading "." then read_file() > could do the PE section search instead of going to the disk. > That way the config file could have some things on disk, and > some things unified. The config file name can by supplied on the xen.efi command line. There's nothing keeping a user from choosing a "special" file name. Hence your only option here would be to pick something which is guaranteed to not be a valid file name, not matter what file system. IOW - I'm unconvinced this is the route to go. >> [...] >>> +# Xen goes up to a pad at 00400000 >> >> "pad at 00400000"? > > $ objdump -h xen.efi > > xen.efi: file format pei-x86-64 > > Sections: > Idx Name Size VMA LMA File off Algn > [...] > 8 .pad 00400000 ffff82d040c00000 ffff82d040c00000 00000000 2**2 > ALLOC > > There is this pad at the end of the image; I wasn't sure if it was important, > so I had the script deposit the extra sections after it. Hopefully there is > someway to automatically figure out the correct address for the additional > segments. There's no useful data in this section - see the linker script for why it exists. But an important issue here again is that there shouldn't be hard coded numbers. The size of this section can easily change over time. >>> +objcopy \ >>> - --add-section .kernel="$KERNEL" \ >>> - --add-section .ramdisk="$RAMDISK" \ >>> - --add-section .config="$CONFIG" \ >>> - --change-section-vma .config=0xffff82d041000000 \ >>> - --change-section-vma .kernel=0xffff82d041010000 \ >>> - --change-section-vma .ramdisk=0xffff82d042000000 \ >> >> Of course these hard coded numbers will be eliminated in the >> long run? > > Ideally. We could try to parse out the address based on the objdump output, > although oddly systemd-boot has hardcoded ones as well. Perhaps the Linux kernel (or whatever else they work on) doesn't ever change addresses. The addresses shown here have changed just recently (they moved down by 1Gb). Earlier today I've submitted a patch where, in the course of putting together, I did consider whether I'd change the virtual memory layout again (and then even conditionally upon CONFIG_PV32). Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 12:11:06 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 12:11:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3eje-00023K-DM; Thu, 06 Aug 2020 12:11:02 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3ejd-00023B-NZ for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 12:11:01 +0000 X-Inumbo-ID: 01b64f45-19c1-44cb-bab2-4cc82b867c99 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 01b64f45-19c1-44cb-bab2-4cc82b867c99; Thu, 06 Aug 2020 12:10:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=HNFqvZLzS58u0UKm2xWeUoUfW2F4SICvBOP5dfa7F7k=; b=PbbHVKDvDNpmk/26bAkyqCSYF OKFrihFwQWsSoxEA9abVrJp3zJKgQ1fhwSM4l3X8tUXPr/heTcn0PMSe3i/kwH1K8k7/+lp8qOIgw K/OHM+AWfE56pDfPkZ1P9nBr9huNyTIenKvkii+/9A1uCfFGYFmaimYy/a/Fp6A8Z22as=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3eja-0001gq-RR; Thu, 06 Aug 2020 12:10:58 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k3eja-0008Qv-Dg; Thu, 06 Aug 2020 12:10:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k3eja-00053u-Cz; Thu, 06 Aug 2020 12:10:58 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 152495: all pass - PUSHED X-Osstest-Versions-This: ovmf=e188ecc8b4aed8fdd26b731d43883861f5e5e7b4 X-Osstest-Versions-That: ovmf=aa211bb6ef8edc70d2e6dfdab01a7d29e53f1ee2 From: osstest service owner Date: Thu, 06 Aug 2020 12:10:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152495 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/152495/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf e188ecc8b4aed8fdd26b731d43883861f5e5e7b4 baseline version: ovmf aa211bb6ef8edc70d2e6dfdab01a7d29e53f1ee2 Last test of basis 152459 2020-08-04 07:31:47 Z 2 days Testing same since 152495 2020-08-05 17:41:20 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michael D Kinney jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git aa211bb6ef..e188ecc8b4 e188ecc8b4aed8fdd26b731d43883861f5e5e7b4 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Aug 06 12:19:05 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 12:19:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3erL-0002H4-8U; Thu, 06 Aug 2020 12:18:59 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3erK-0002Gz-8r for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 12:18:58 +0000 X-Inumbo-ID: caa4109b-9966-41a1-96b1-177eed54cf97 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id caa4109b-9966-41a1-96b1-177eed54cf97; Thu, 06 Aug 2020 12:18:57 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CAE5BAD89; Thu, 6 Aug 2020 12:19:13 +0000 (UTC) Subject: Re: [PATCH v4 10/14] iommu: remove the share_p2m operation To: Paul Durrant References: <20200804134209.8717-1-paul@xen.org> <20200804134209.8717-11-paul@xen.org> From: Jan Beulich Message-ID: Date: Thu, 6 Aug 2020 14:18:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200804134209.8717-11-paul@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Tian , Wei Liu , Andrew Cooper , Paul Durrant , George Dunlap , xen-devel@lists.xenproject.org, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 04.08.2020 15:42, Paul Durrant wrote: > --- a/xen/drivers/passthrough/vtd/iommu.c > +++ b/xen/drivers/passthrough/vtd/iommu.c > @@ -318,6 +318,48 @@ static u64 addr_to_dma_page_maddr(struct domain *domain, u64 addr, int alloc) > return pte_maddr; > } > > +static uint64_t domain_pgd_maddr(struct domain *d, struct vtd_iommu *iommu) The 2nd param can be const, and I wonder whether it wouldn't better be named e.g. "vtd". Then again all you're after is iommu->nr_pt_levels, so maybe the caller would better pass in that value (removing the appearance of there being some further dependency about the specific IOMMU's properties)? > +{ > + struct domain_iommu *hd = dom_iommu(d); > + uint64_t pgd_maddr; > + unsigned int agaw; > + > + ASSERT(spin_is_locked(&hd->arch.mapping_lock)); > + > + if ( iommu_use_hap_pt(d) ) > + { > + mfn_t pgd_mfn = > + pagetable_get_mfn(p2m_get_pagetable(p2m_get_hostp2m(d))); > + > + return pagetable_get_paddr(pagetable_from_mfn(pgd_mfn)); Why the pagetable -> MFN -> pagetable -> paddr transformation? I.e. just return pagetable_get_paddr(p2m_get_pagetable(p2m_get_hostp2m(d))); ? Oh, I've now realized that's how the old code was written. > + } > + > + if ( !hd->arch.vtd.pgd_maddr ) > + { > + addr_to_dma_page_maddr(d, 0, 1); > + > + if ( !hd->arch.vtd.pgd_maddr ) > + return 0; > + } > + > + pgd_maddr = hd->arch.vtd.pgd_maddr; > + > + /* Skip top levels of page tables for 2- and 3-level DRHDs. */ > + for ( agaw = level_to_agaw(4); > + agaw != level_to_agaw(iommu->nr_pt_levels); > + agaw-- ) > + { > + struct dma_pte *p = map_vtd_domain_page(pgd_maddr); const? > + > + pgd_maddr = dma_pte_addr(*p); > + unmap_vtd_domain_page(p); > + if ( !pgd_maddr ) > + return 0; > + } > + > + return pgd_maddr; > +} Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 12:23:32 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 12:23:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3evh-00036O-R5; Thu, 06 Aug 2020 12:23:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3evg-00036I-BP for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 12:23:28 +0000 X-Inumbo-ID: 507d9808-a7a5-4e63-84e7-ee5ebf72a60e Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 507d9808-a7a5-4e63-84e7-ee5ebf72a60e; Thu, 06 Aug 2020 12:23:27 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2822EAD5B; Thu, 6 Aug 2020 12:23:44 +0000 (UTC) Subject: Re: [PATCH v4 11/14] iommu: stop calling IOMMU page tables 'p2m tables' To: Paul Durrant References: <20200804134209.8717-1-paul@xen.org> <20200804134209.8717-12-paul@xen.org> From: Jan Beulich Message-ID: <5aa64762-4406-8063-2fd0-c55f168dfa72@suse.com> Date: Thu, 6 Aug 2020 14:23:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200804134209.8717-12-paul@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Paul Durrant , Kevin Tian , Andrew Cooper Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 04.08.2020 15:42, Paul Durrant wrote: > @@ -553,14 +549,7 @@ static void iommu_dump_p2m_table(unsigned char key) > if ( is_hardware_domain(d) || !is_iommu_enabled(d) ) > continue; > > - if ( iommu_use_hap_pt(d) ) > - { > - printk("\ndomain%d IOMMU p2m table shared with MMU: \n", d->domain_id); > - continue; > - } > - > - printk("\ndomain%d IOMMU p2m table: \n", d->domain_id); This (importantish) information was lost. > @@ -2624,17 +2624,19 @@ static void vtd_dump_p2m_table_level(paddr_t pt_maddr, int level, paddr_t gpa, > unmap_vtd_domain_page(pt_vaddr); > } > > -static void vtd_dump_p2m_table(struct domain *d) > +static void vtd_dump_page_tables(struct domain *d) > { > - const struct domain_iommu *hd; > + const struct domain_iommu *hd = dom_iommu(d); > > - if ( list_empty(&acpi_drhd_units) ) > + if ( iommu_use_hap_pt(d) ) > + { > + printk("VT-D sharing EPT table\n"); > return; > + } > > - hd = dom_iommu(d); > - printk("p2m table has %d levels\n", agaw_to_level(hd->arch.vtd.agaw)); > - vtd_dump_p2m_table_level(hd->arch.vtd.pgd_maddr, > - agaw_to_level(hd->arch.vtd.agaw), 0, 0); > + printk("VT-D table has %d levels\n", agaw_to_level(hd->arch.vtd.agaw)); I think it's commonly VT-d (a mixture of case). Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 12:34:21 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 12:34:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3f5x-00041m-Ow; Thu, 06 Aug 2020 12:34:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3f5v-00041h-VV for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 12:34:03 +0000 X-Inumbo-ID: 01afc08c-84a8-4d08-9041-a6b1920390aa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 01afc08c-84a8-4d08-9041-a6b1920390aa; Thu, 06 Aug 2020 12:34:03 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A6532AC23; Thu, 6 Aug 2020 12:34:19 +0000 (UTC) Subject: Re: [PATCH v4 12/14] vtd: use a bit field for root_entry To: Paul Durrant References: <20200804134209.8717-1-paul@xen.org> <20200804134209.8717-13-paul@xen.org> From: Jan Beulich Message-ID: <71e1a4a9-eac0-5aae-f2d5-fa33ca8b6036@suse.com> Date: Thu, 6 Aug 2020 14:34:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200804134209.8717-13-paul@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Paul Durrant , Kevin Tian Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 04.08.2020 15:42, Paul Durrant wrote: > --- a/xen/drivers/passthrough/vtd/iommu.h > +++ b/xen/drivers/passthrough/vtd/iommu.h > @@ -184,21 +184,28 @@ > #define dma_frcd_source_id(c) (c & 0xffff) > #define dma_frcd_page_addr(d) (d & (((u64)-1) << 12)) /* low 64 bit */ > > -/* > - * 0: Present > - * 1-11: Reserved > - * 12-63: Context Ptr (12 - (haw-1)) > - * 64-127: Reserved > - */ > struct root_entry { > - u64 val; > - u64 rsvd1; > + union { > + __uint128_t val; I couldn't find a use of this field, and I also can't foresee any. Could it be left out? > + struct { uint64_t lo, hi; }; > + struct { > + /* 0 - 63 */ > + uint64_t p:1; bool? > + uint64_t reserved0:11; > + uint64_t ctp:52; > + > + /* 64 - 127 */ > + uint64_t reserved1; > + }; > + }; > }; > -#define root_present(root) ((root).val & 1) > -#define set_root_present(root) do {(root).val |= 1;} while(0) > -#define get_context_addr(root) ((root).val & PAGE_MASK_4K) > -#define set_root_value(root, value) \ > - do {(root).val |= ((value) & PAGE_MASK_4K);} while(0) > + > +#define root_present(r) (r).p > +#define set_root_present(r) do { (r).p = 1; } while (0) And then "true" here? > +#define root_ctp(r) ((r).ctp << PAGE_SHIFT_4K) > +#define set_root_ctp(r, val) \ > + do { (r).ctp = ((val) >> PAGE_SHIFT_4K); } while (0) For documentation purposes, can the 2nd macro param be named maddr or some such? > --- a/xen/drivers/passthrough/vtd/x86/ats.c > +++ b/xen/drivers/passthrough/vtd/x86/ats.c > @@ -74,8 +74,8 @@ int ats_device(const struct pci_dev *pdev, const struct acpi_drhd_unit *drhd) > static bool device_in_domain(const struct vtd_iommu *iommu, > const struct pci_dev *pdev, uint16_t did) > { > - struct root_entry *root_entry; > - struct context_entry *ctxt_entry = NULL; > + struct root_entry *root_entry, *root_entries = NULL; > + struct context_entry *context_entry, *context_entries = NULL; Just like root_entry, root_entries doesn't look to need an initializer. I'm unconvinced anyway that you now need two variables each: unmap_vtd_domain_page() does quite fine with the low 12 bits not all being zero, afaict. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 12:47:03 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 12:47:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3fIM-000533-SZ; Thu, 06 Aug 2020 12:46:54 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3fIM-00052y-Aw for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 12:46:54 +0000 X-Inumbo-ID: 1020df48-aa5e-415b-bd5c-8f286dc0b102 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1020df48-aa5e-415b-bd5c-8f286dc0b102; Thu, 06 Aug 2020 12:46:51 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4B9B6AE09; Thu, 6 Aug 2020 12:47:07 +0000 (UTC) Subject: Re: [PATCH v4 13/14] vtd: use a bit field for context_entry To: Paul Durrant References: <20200804134209.8717-1-paul@xen.org> <20200804134209.8717-14-paul@xen.org> From: Jan Beulich Message-ID: <6de24196-019c-f91c-5cca-0971676a9b38@suse.com> Date: Thu, 6 Aug 2020 14:46:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200804134209.8717-14-paul@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Paul Durrant , Kevin Tian Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 04.08.2020 15:42, Paul Durrant wrote: > @@ -208,35 +209,53 @@ struct root_entry { > do { (r).ctp = ((val) >> PAGE_SHIFT_4K); } while (0) > > struct context_entry { > - u64 lo; > - u64 hi; > + union { > + __uint128_t val; > + struct { uint64_t lo, hi; }; > + struct { > + /* 0 - 63 */ > + uint64_t p:1; > + uint64_t fpd:1; > + uint64_t tt:2; > + uint64_t reserved0:8; > + uint64_t slptp:52; > + > + /* 64 - 127 */ > + uint64_t aw:3; > + uint64_t ignored:4; > + uint64_t reserved1:1; > + uint64_t did:16; > + uint64_t reserved2:40; > + }; > + }; > }; > -#define ROOT_ENTRY_NR (PAGE_SIZE_4K/sizeof(struct root_entry)) > -#define context_present(c) ((c).lo & 1) > -#define context_fault_disable(c) (((c).lo >> 1) & 1) > -#define context_translation_type(c) (((c).lo >> 2) & 3) > -#define context_address_root(c) ((c).lo & PAGE_MASK_4K) > -#define context_address_width(c) ((c).hi & 7) > -#define context_domain_id(c) (((c).hi >> 8) & ((1 << 16) - 1)) > - > -#define context_set_present(c) do {(c).lo |= 1;} while(0) > -#define context_clear_present(c) do {(c).lo &= ~1;} while(0) > -#define context_set_fault_enable(c) \ > - do {(c).lo &= (((u64)-1) << 2) | 1;} while(0) > - > -#define context_set_translation_type(c, val) do { \ > - (c).lo &= (((u64)-1) << 4) | 3; \ > - (c).lo |= (val & 3) << 2; \ > - } while(0) > + > +#define context_present(c) (c).p > +#define context_set_present(c) do { (c).p = 1; } while (0) > +#define context_clear_present(c) do { (c).p = 0; } while (0) > + > +#define context_fault_disable(c) (c).fpd > +#define context_set_fault_enable(c) do { (c).fpd = 1; } while (0) > + > +#define context_translation_type(c) (c).tt > +#define context_set_translation_type(c, val) do { (c).tt = val; } while (0) > #define CONTEXT_TT_MULTI_LEVEL 0 > #define CONTEXT_TT_DEV_IOTLB 1 > #define CONTEXT_TT_PASS_THRU 2 > > -#define context_set_address_root(c, val) \ > - do {(c).lo &= 0xfff; (c).lo |= (val) & PAGE_MASK_4K ;} while(0) > +#define context_slptp(c) ((c).slptp << PAGE_SHIFT_4K) > +#define context_set_slptp(c, val) \ > + do { (c).slptp = (val) >> PAGE_SHIFT_4K; } while (0) Presumably "slptp" is in line with the doc, but "address_root" is quite a bit more readable. I wonder if I could talk you into restoring the old (or some similar) names. More generally, and more so here than perhaps already on the previous patch - are these helper macros useful to have anymore? > +#define context_address_width(c) (c).aw > #define context_set_address_width(c, val) \ > - do {(c).hi &= 0xfffffff8; (c).hi |= (val) & 7;} while(0) > -#define context_clear_entry(c) do {(c).lo = 0; (c).hi = 0;} while(0) > + do { (c).aw = (val); } while (0) > + > +#define context_did(c) (c).did > +#define context_set_did(c, val) \ > + do { (c).did = (val); } while (0) > + > +#define context_clear_entry(c) do { (c).val = 0; } while (0) While this is in line with previous code, I'm concerned: domain_context_unmap_one() has context_clear_present(*context); context_clear_entry(*context); No barrier means no guarantee of ordering. I'd drop clear_present() here and make clear_entry() properly ordered. This, I think, will at the same time render the __uint128_t field unused and hence unnecessary again. Also comments given on the previous patch apply respectively here. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 12:53:42 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 12:53:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3fOr-0005uH-LI; Thu, 06 Aug 2020 12:53:37 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3fOq-0005uC-QE for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 12:53:36 +0000 X-Inumbo-ID: 06a152a4-15d3-41eb-b53a-737220859221 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 06a152a4-15d3-41eb-b53a-737220859221; Thu, 06 Aug 2020 12:53:35 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6C54FAE09; Thu, 6 Aug 2020 12:53:52 +0000 (UTC) Subject: Re: [PATCH v4 14/14] vtd: use a bit field for dma_pte To: Paul Durrant References: <20200804134209.8717-1-paul@xen.org> <20200804134209.8717-15-paul@xen.org> From: Jan Beulich Message-ID: <918260ba-0241-80eb-567c-a2d48419c12a@suse.com> Date: Thu, 6 Aug 2020 14:53:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200804134209.8717-15-paul@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Paul Durrant , Kevin Tian Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 04.08.2020 15:42, Paul Durrant wrote: > --- a/xen/drivers/passthrough/vtd/iommu.c > +++ b/xen/drivers/passthrough/vtd/iommu.c > @@ -1772,13 +1772,14 @@ static int __must_check intel_iommu_map_page(struct domain *d, dfn_t dfn, > old = *pte; > > dma_set_pte_addr(new, mfn_to_maddr(mfn)); > - dma_set_pte_prot(new, > - ((flags & IOMMUF_readable) ? DMA_PTE_READ : 0) | > - ((flags & IOMMUF_writable) ? DMA_PTE_WRITE : 0)); > + if ( flags & IOMMUF_readable ) > + dma_set_pte_readable(new); > + if ( flags & IOMMUF_writable ) > + dma_set_pte_writable(new); > > /* Set the SNP on leaf page table if Snoop Control available */ > if ( iommu_snoop ) > - dma_set_pte_snp(new); > + dma_set_pte_snoop(new); Perhaps simply use an initializer: new = (struct dma_ptr){ .r = flags & IOMMUF_readable, .w = flags & IOMMUF_writable, .snp = iommu_snoop, .addr = mfn_x(mfn), }; ? This also points out that the "addr" field isn't really an address, and hence may want renaming. Again comments on the two earlier patch apply here respectively (or else part of the suggestion above isn't going to work as is). Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 13:28:03 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 13:28:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3fw2-0000Bx-IY; Thu, 06 Aug 2020 13:27:54 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3fw2-0000Bs-04 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 13:27:54 +0000 X-Inumbo-ID: 23dd9a41-138b-4a43-aa50-a4da4c5708de Received: from mail-lf1-x144.google.com (unknown [2a00:1450:4864:20::144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 23dd9a41-138b-4a43-aa50-a4da4c5708de; Thu, 06 Aug 2020 13:27:52 +0000 (UTC) Received: by mail-lf1-x144.google.com with SMTP id c15so8808549lfi.3 for ; Thu, 06 Aug 2020 06:27:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=AFNf1CHEaQX3/Ff6dZ20hSWg+v+SYrJPNYYJhhp5oAU=; b=HqDqLihpLFKSrLKu4XSokEx1eEt2tz6oyMQjkNEP3mbqq7/HqrGBbVFQOL3txfC4Pt lTxn44IeiXP1THu1P7Hq4ctVWP+e0MKxxniTPVlRG59IhGUCsMtrVhSB2lgjc6CMB1E8 XRWq24w/SinGUpx/hdFsgQ6AgdEi8dgKZideXtvGfxR7vwxbHZklSNk7OZYyIwl+UJtt 1gYdTihDOpWAeaW1d8HTiduCJ2ynBlNkpPVGMmiL4Cr1cVsQ7EdTJLsFmawLTkirrWNm KZbHi/I5dLkT+1d9YXSvqYN1HmDD3PHmEtoT/+4PWDlNYsxhCZErEUnMwFIN8a4GuIgs 7PRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=AFNf1CHEaQX3/Ff6dZ20hSWg+v+SYrJPNYYJhhp5oAU=; b=E4Nxa5MJn/uSCO7hD5rLfmQRVjBB9yda3UwKp0NpwCc7v3I3xQZyDOR4CGpWOl7RYZ 9Src1uhUtxhkJ/sB80MoIUoyxK/jCnVfmubj+PAop4dhPKTHqnOMqKQEwtxg1s3VCfGt CkZ2rOFRgFa4UwMPjSUTBriwsB0MECFggDfSdfQ+NkExFySP/zdWvLUkvIzVeTzvvQ9N HWlk4p+tXgCRJbKpwFBwOReO3i49ZSdKj191yMpiv/Nit8uKqExREXPlOc4kZO66/v5d /8ndb3Cc4tXYrhBJm9UByOtKe1lQBr0KxCl3q/mzonlSMDBwWWXhlcKuXUKZLpNVo3pm pfJw== X-Gm-Message-State: AOAM531O1BpjtdpX6UyppHdmYM5c89Sd1F++HCO6Sa/Ks5DlgnI3OLTe 06BJhqY6YOd8o7vyR826Wco= X-Google-Smtp-Source: ABdhPJyFWONz2LqDVd9oQHKJNYX4EV8KtEiYIc8CjqGRUu1U6wNQEclvRvyfcO132RStx2E3g/ZKkg== X-Received: by 2002:ac2:546f:: with SMTP id e15mr4052062lfn.133.1596720471343; Thu, 06 Aug 2020 06:27:51 -0700 (PDT) Received: from [192.168.1.2] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id t1sm2699655lfc.52.2020.08.06.06.27.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2020 06:27:50 -0700 (PDT) Subject: Re: [RFC PATCH V1 04/12] xen/arm: Introduce arch specific bits for IOREQ/DM features To: Julien Grall , xen-devel@lists.xenproject.org References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-5-git-send-email-olekstysh@gmail.com> <11eaa2f0-84c7-5972-d14c-4cb02458e882@xen.org> <3ee50c66-8761-6c86-3fab-a4c23622d2b8@gmail.com> From: Oleksandr Message-ID: <952392d9-22cc-af66-c1af-f82360b75cf4@gmail.com> Date: Thu, 6 Aug 2020 16:27:44 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Julien Grall , Jan Beulich , Daniel De Graaf , Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 06.08.20 14:08, Julien Grall wrote: Hi Julien > >>> What is this function supposed to do? >> Agree, sounds confusing a bit. I assume it is supposed to complete >> Guest MMIO access after finishing emulation. >> >> Shall I rename it to something appropriate (maybe by adding ioreq >> prefix)? > > How about ioreq_handle_complete_mmio()? For me it sounds fine. > >>>> diff --git a/xen/common/memory.c b/xen/common/memory.c >>>> index 9283e5e..0000477 100644 >>>> --- a/xen/common/memory.c >>>> +++ b/xen/common/memory.c >>>> @@ -8,6 +8,7 @@ >>>>    */ >>>>     #include >>>> +#include >>>>   #include >>>>   #include >>>>   #include >>>> @@ -30,10 +31,6 @@ >>>>   #include >>>>   #include >>>>   -#ifdef CONFIG_IOREQ_SERVER >>>> -#include >>>> -#endif >>>> - >>> >>> Why do you remove something your just introduced? >> The reason I guarded that header is to make "xen/mm: Make x86's >> XENMEM_resource_ioreq_server handling common" (previous) patch >> buildable on Arm >> without arch IOREQ header added yet. I tried to make sure that the >> result after each patch was buildable to retain bisectability. >> As current patch adds Arm IOREQ specific bits (including header), >> that guard could be removed as not needed anymore. > I agree we want to have the build bisectable. However, I am still > puzzled why it is necessary to remove the #ifdef and move it earlier > in the list. > > Do you mind to provide more details? Previous patch "xen/mm: Make x86's XENMEM_resource_ioreq_server handling common" breaks build on Arm as it includes xen/hvm/ioreq.h which requires arch header to be present (asm/hvm/ioreq.h). But the missing arch header together with other arch specific bits are introduced here in current patch. Probably I should have rearranged changes in a way to not introduce #ifdef and then remove it... > > [...] > >>>> + >>>> +bool handle_mmio(void); >>>> + >>>> +static inline bool handle_pio(uint16_t port, unsigned int size, >>>> int dir) >>>> +{ >>>> +    /* XXX */ >>> >>> Can you expand this TODO? What do you expect to do? >> I didn't expect this to be called on Arm. Sorry, I am not sure l have >> an idea how to handle this properly. I would keep it unimplemented >> until a real reason. >> Will expand TODO. > > Let see how the conversation on patch#1 goes about PIO vs MMIO. ok > >>> >>> >>>> +    BUG(); >>>> +    return true; >>>> +} >>>> + >>>> +static inline paddr_t hvm_mmio_first_byte(const ioreq_t *p) >>>> +{ >>>> +    return p->addr; >>>> +} >>> >>> I understand that the x86 version is more complex as it check p->df. >>> However, aside reducing the complexity, I am not sure why we would >>> want to diverge it. >>> >>> After all, IOREQ is now meant to be a common feature. >> Well, no objections at all. >> Could you please clarify how could 'df' (Direction Flag?) be >> handled/used on Arm? > > On x86, this is used by 'rep' instruction to tell the direction to > iterate (forward or backward). > > On Arm, all the accesses to MMIO region will do a single memory > access. So for now, we can safely always set to 0. > >> I see that try_fwd_ioserv() always sets it 0. Or I need to just reuse >> x86's helpers as is, >> which (together with count = df = 0) will result in what we actually >> have here? > AFAIU, both count and df should be 0 on Arm. Thanks for the explanation. The only one question remains where to put common helpers hvm_mmio_first_byte/hvm_mmio_last_byte (common io.h?)? >>> >>>> + >>>> +static inline int p2m_set_ioreq_server(struct domain *d, >>>> +                                       unsigned int flags, >>>> +                                       struct hvm_ioreq_server *s) >>>> +{ >>>> +    return -EOPNOTSUPP; >>>> +} >>> >>> This should be defined in p2m.h. But I am not even sure what it is >>> meant for. Can you expand it? >> >> ok, will move. >> >> >> In this series I tried to make as much IOREQ code common as possible >> and avoid complicating things, in order to achieve that a few stubs >> were added here. Please note, >> that I also considered splitting into arch parts. But some functions >> couldn't be split easily. >> This one is called from common hvm_destroy_ioreq_server() with flag >> being 0 (which will result in unmapping ioreq server from p2m type on >> x86). >> I could add a comment describing why this stub is present here. > > Sorry if I wasn't clear. I wasn't asking why the stub is there but > what should be the expected implementation of the function. > > In particular, you are returning -EOPNOTSUPP. The only reason you are > getting away from trouble is because the caller doesn't check the return. True. > > Would it make sense to have a stub arch_hvm_destroy_ioreq_server()? With what has been said above, it make sense, will create. >>>> + >>>> +static inline void msix_write_completion(struct vcpu *v) >>>> +{ >>>> +} >>>> + >>>> +static inline void handle_realmode_completion(void) >>>> +{ >>>> +    ASSERT_UNREACHABLE(); >>>> +} >>> >>> realmode is very x86 specific. So I don't think this function should >>> be called from common code. It might be worth considering to split >>> handle_hvm_io_completion() is 2 parts: common and arch specific. >> >> I agree with you that realmode is x86 specific and looks not good in >> Arm header. > It is not a problem of looking good or not. Instead, it is about > abstraction. A developper shouldn't need to understand all the other > architectures we support in order to follow the common code. > >> I was thinking how to split handle_hvm_io_completion() gracefully but >> I failed find a good solution for that, so decided to add two stubs >> (msix_write_completion and handle_realmode_completion) on Arm. I >> could add a comment describing why they are here if appropriate. But >> if you think they shouldn't be called from the common code in any >> way, I will try to split it. > > I am not entirely sure what msix_write_completion is meant to do on > x86. Is it dealing with virtual MSIx? Maybe Jan, Roger or Paul could > help? > > Regarding handle_realmode_completion, I would add a new stub: > > arch_ioreq_handle_io_completion() that is called from the default case > of the switch. > > On x86 it would be implemented as: > >  switch (io_completion) >  { >     case HVMIO_realmode_completion: >       ... >     default: >       ASSERT_UNREACHABLE(); >  } > > On Arm, it would be implemented as: > >   ASSERT_UNREACHABLE(); Good point, will update. -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Thu Aug 06 14:05:01 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 14:05:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3gVY-0003dj-G1; Thu, 06 Aug 2020 14:04:36 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3gVX-0003de-8Z for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 14:04:35 +0000 X-Inumbo-ID: bc74ab43-a97f-4293-ad70-9ef3ced1291b Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id bc74ab43-a97f-4293-ad70-9ef3ced1291b; Thu, 06 Aug 2020 14:04:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596722673; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=jcst+vUXWIDH9l1/b5ZOkB7hEbI0ii6Plnk5zFkhr7A=; b=hT2c6qGkuFeIqBT2xrQbd7l91gSBsC/TGOD6kY28wm4QjqG4oaV8shW7 f7FFBtzqwMtWkxpulC8x1MzXaSwv+/UVhjRgq7XGttrpTkd6Zd6DkCv9R rMsQkgLvTZtI36C8/+NJsFNPu77WBOY33eE2IxAmBYIejB0+l4X5dm9gT c=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 0UA42GqbT5uJQ+NWwSW/YZqyjubO0l8QFV+BH81zFoi/EJO9NgYdw0vc0kk/GV+OgL43mAxFbM U9QuKqE+rNwqqCuaS0QG6yR9R4tCizUFj5BMirJ4wmvjCfQ3G4QgZGSc4ASDkVISiRcyNlbN3p zgC8/asS0vuCVFMYnoJWmA/L+m51+S3+Kabn9F7/w3UTsHiP7WpEYZ3kUxxkPq4GANQx5T5U2r qSOU9kbYHWuSwDhrMKK24NGVCDNhKWbwrL+ZP9z5z4ZXREOEMd9pCH3Fj57ZqOwZfRBvd+8az6 5o4= X-SBRS: 3.7 X-MesageID: 24323162 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,441,1589256000"; d="scan'208";a="24323162" Subject: Re: [PATCH 1/3] x86: slightly re-arrange 32-bit handling in dom0_construct_pv() To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <0972ea3c-c2a8-b0f4-ae25-132bdb798f6a@suse.com> From: Andrew Cooper Message-ID: <0217c386-e93e-2f07-f2ac-9e683c14541a@citrix.com> Date: Thu, 6 Aug 2020 15:04:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <0972ea3c-c2a8-b0f4-ae25-132bdb798f6a@suse.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 06/08/2020 10:28, Jan Beulich wrote: > Add #ifdef-s (the 2nd one will be needed in particular, to guard the > uses of m2p_compat_vstart and HYPERVISOR_COMPAT_VIRT_START()) and fold > duplicate uses of elf_32bit(). > > Also adjust what gets logged: Avoid "compat32" when support isn't built > in, and don't assume ELF class <> ELFCLASS64 means ELFCLASS32. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper although with some further suggestions. > > --- a/xen/arch/x86/pv/dom0_build.c > +++ b/xen/arch/x86/pv/dom0_build.c > @@ -300,7 +300,6 @@ int __init dom0_construct_pv(struct doma > struct page_info *page = NULL; > start_info_t *si; > struct vcpu *v = d->vcpu[0]; > - unsigned long long value; > void *image_base = bootstrap_map(image); > unsigned long image_len = image->mod_end; > void *image_start = image_base + image_headroom; > @@ -357,27 +356,36 @@ int __init dom0_construct_pv(struct doma > goto out; > > /* compatibility check */ > + printk(" Xen kernel: 64-bit, lsb%s\n", > + IS_ENABLED(CONFIG_PV32) ? ", compat32" : ""); Here, and below, we print out lsb/msb for the ELF file.  However, we don't use or check that it is actually lsb, and blindly assume that it is. Why bother printing it then? > compatible = 0; > machine = elf_uval(&elf, elf.ehdr, e_machine); > - printk(" Xen kernel: 64-bit, lsb, compat32\n"); > - if ( elf_32bit(&elf) && parms.pae == XEN_PAE_BIMODAL ) > - parms.pae = XEN_PAE_EXTCR3; > - if ( elf_32bit(&elf) && parms.pae && machine == EM_386 ) > + > +#ifdef CONFIG_PV32 > + if ( elf_32bit(&elf) ) > { > - if ( unlikely(rc = switch_compat(d)) ) > + if ( parms.pae == XEN_PAE_BIMODAL ) > + parms.pae = XEN_PAE_EXTCR3; > + if ( parms.pae && machine == EM_386 ) > { > - printk("Dom0 failed to switch to compat: %d\n", rc); > - return rc; > - } > + if ( unlikely(rc = switch_compat(d)) ) > + { > + printk("Dom0 failed to switch to compat: %d\n", rc); > + return rc; > + } > > - compatible = 1; > + compatible = 1; > + } > } > - if (elf_64bit(&elf) && machine == EM_X86_64) > +#endif > + > + if ( elf_64bit(&elf) && machine == EM_X86_64 ) > compatible = 1; > - printk(" Dom0 kernel: %s%s, %s, paddr %#" PRIx64 " -> %#" PRIx64 "\n", > - elf_64bit(&elf) ? "64-bit" : "32-bit", > - parms.pae ? ", PAE" : "", > - elf_msb(&elf) ? "msb" : "lsb", > + > + printk(" Dom0 kernel: %s-bit%s, %s, paddr %#" PRIx64 " -> %#" PRIx64 "\n", > + elf_64bit(&elf) ? "64" : elf_32bit(&elf) ? "32" : "??", > + parms.pae ? ", PAE" : "", > + elf_msb(&elf) ? "msb" : "lsb", > elf.pstart, elf.pend); > if ( elf.bsd_symtab_pstart ) > printk(" Dom0 symbol map %#" PRIx64 " -> %#" PRIx64 "\n", > @@ -405,23 +413,28 @@ int __init dom0_construct_pv(struct doma > if ( parms.pae == XEN_PAE_EXTCR3 ) > set_bit(VMASST_TYPE_pae_extended_cr3, &d->vm_assist); > > - if ( !pv_shim && (parms.virt_hv_start_low != UNSET_ADDR) && > - elf_32bit(&elf) ) > +#ifdef CONFIG_PV32 > + if ( elf_32bit(&elf) ) > { > - unsigned long mask = (1UL << L2_PAGETABLE_SHIFT) - 1; > - value = (parms.virt_hv_start_low + mask) & ~mask; > - BUG_ON(!is_pv_32bit_domain(d)); > - if ( value > __HYPERVISOR_COMPAT_VIRT_START ) > - panic("Domain 0 expects too high a hypervisor start address\n"); > - HYPERVISOR_COMPAT_VIRT_START(d) = > - max_t(unsigned int, m2p_compat_vstart, value); > - } > + if ( !pv_shim && (parms.virt_hv_start_low != UNSET_ADDR) ) > + { > + unsigned long mask = (1UL << L2_PAGETABLE_SHIFT) - 1; > + unsigned long value = (parms.virt_hv_start_low + mask) & ~mask; ROUNDUP() instead of opencoding it? > > - if ( (parms.p2m_base != UNSET_ADDR) && elf_32bit(&elf) ) > - { > - printk(XENLOG_WARNING "P2M table base ignored\n"); > - parms.p2m_base = UNSET_ADDR; > + BUG_ON(!is_pv_32bit_domain(d)); This BUG_ON() is useless.  I suspect it is a vestigial safety measure from when the switch to compat was opencoded rather than using switch_compat() directly. > + if ( value > __HYPERVISOR_COMPAT_VIRT_START ) > + panic("Domain 0 expects too high a hypervisor start address\n"); It would be better to printk() and return -EINVAL, to be consistent with how other fatal errors are reported to the user. ~Andrew > + HYPERVISOR_COMPAT_VIRT_START(d) = > + max_t(unsigned int, m2p_compat_vstart, value); > + } > + > + if ( parms.p2m_base != UNSET_ADDR ) > + { > + printk(XENLOG_WARNING "P2M table base ignored\n"); > + parms.p2m_base = UNSET_ADDR; > + } > } > +#endif > > /* > * Why do we need this? The number of page-table frames depends on the > From xen-devel-bounces@lists.xenproject.org Thu Aug 06 14:15:16 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 14:15:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3gfl-0004Yq-Gn; Thu, 06 Aug 2020 14:15:09 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3gfj-0004Yl-Tm for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 14:15:08 +0000 X-Inumbo-ID: bd257d1e-0b1a-451d-89c0-ab393de73bc4 Received: from mail-40134.protonmail.ch (unknown [185.70.40.134]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id bd257d1e-0b1a-451d-89c0-ab393de73bc4; Thu, 06 Aug 2020 14:15:04 +0000 (UTC) Date: Thu, 06 Aug 2020 14:15:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trmm.net; s=protonmail; t=1596723302; bh=9EUXXDDRtXeDPJSObp3m53XCnteeXyv3fOc1N8qS8PM=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=raoClrxt9plFj3mPm+vDDW1fDxOaDP23c0zUnyREHj7duBd2udDGk9Frm2tM6g8dh 3okrXPC1FuOwKQLm7CHcLcvsHN6DuSz5qDw4FOlmhF6fxEuHAIwbI4MXlg7ggR6wUd BLd+YybUaTJdr3DlGFjwiF65HREKMYNE/BryO/WI= To: Jan Beulich From: Trammell Hudson Subject: Re: [RFC] efi/boot: Unified Xen executable for UEFI Secure Boot support Message-ID: In-Reply-To: <5e3b16b3-0f93-4683-dcc7-852c805870c8@suse.com> References: <1bd2d79e-5bef-835c-f6cc-9fd367e8beb7@suse.com> <5e3b16b3-0f93-4683-dcc7-852c805870c8@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: Trammell Hudson Cc: "xen-devel@lists.xenproject.org" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Thursday, August 6, 2020 2:04 PM, Jan Beulich wrote: > On 06.08.2020 13:44, Trammell Hudson wrote: > > > On Thursday, August 6, 2020 9:57 AM, Jan Beulich jbeulich@suse.com wrot= e: > > > > > Overall I think it might help if this PE parsing code (if UEFI > > > doesn't offer a protocol to do it for us) was put into its own > > > source file. > > > > I tried to putting it into a separate file and ran into link issues, > > seems that it needs to be mentioned in both arch/x86/Makefile and > > arch/x86/pe/Makefile, so this was a "just make it work" for the PoC. > > Now that it is working, I'll go back to see if I can figure out the > > makefile magic. > > I was rather thinking of e.g. xen/common/efi/pe.c. PE parsing code is in now in common/efi/pe.c, with a symlink in arch/x86/ef= i/, and I added an extern in common/efi/efi.h. The Makefiles in both arch/x86 = and arch/x86/efi required updates to link in the extra pe.init.o file. I think this still requires some changes for ARM. > [...] > > > > - if ( efi_rs->GetVariable(L"SecureBoot", (EFI_GUID *)&global_gui= d, NULL, &size, buf) !=3D EFI_SUCCESS ) > > > > - return false; > > > > > > > > > > > > - return buf[0] !=3D 0; > > > > > > I.e. "SecureBoot=3DN" still means "enabled"? > > > > Maybe? UEFI 2.8, section 3.3 "Global Variables" says for SecureBoot: > > "Whether the platform firmware is operating in Secure boot mode (1) or = not (0). All other values > > are reserved. Should be treated as read-only." > > But in your expression that's then presumably '0', not 0? The values are the bytes '\x00' or '\x01'. UEFI uses human readable strings= , except where it doesn't. > > > Also, considering kernel and initrd are embedded, is there really a > > > strict need for a config file? It would seem to me that you could > > > boot the system fine without. > > > > The config file is still necessary for Xen options (console, etc) as > > well as the kernel command line. > > But command line options are optional. Yes, you need a config file if > you want to pass any options. But you may be able to get away without > command line options, and hence without config file. My concern is that if there is no config file embedded in the unified image, then the logic for retrieving the untrustworthy file from disk kicks in. However, it is not a change from the status-quo, so I've reverted the behavior (as part of also fixing the shim logic). I also added code to load the ucode section from the unified image if it is present, which required touching the arm tree as well to add an additional parameter to efi_arch_cfg_file_late(). It also appears that in the event of the error path that the ucode will never be freed. Probably not a big deal, unless you're launching a failing Xen from the EFI shell over and over. > > > > +objcopy \ > > > > > > > > - --add-section .kernel=3D"$KERNEL" \ > > > > - --add-section .ramdisk=3D"$RAMDISK" \ > > > > - --add-section .config=3D"$CONFIG" \ > > > > - --change-section-vma .config=3D0xffff82d041000000 \ > > > > - --change-section-vma .kernel=3D0xffff82d041010000 \ > > > > - --change-section-vma .ramdisk=3D0xffff82d042000000 \ > > > > > > Of course these hard coded numbers will be eliminated in the > > > long run? > > > > Ideally. We could try to parse out the address based on the objdump out= put, > > although oddly systemd-boot has hardcoded ones as well. > > Perhaps the Linux kernel (or whatever else they work on) doesn't > ever change addresses. The addresses shown here have changed just > recently (they moved down by 1Gb). Since the unify script doesn't have access to the build tree, I added some logic that tries to deduce the correct address range and adds the unified bits a little ways above it. Updated patch: diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h index 6527cb0..fb763ce 100644 --- a/xen/arch/arm/efi/efi-boot.h +++ b/xen/arch/arm/efi/efi-boot.h @@ -395,7 +395,7 @@ static void __init efi_arch_cfg_file_early(EFI_FILE_HAN= DLE dir_handle, char *sec blexit(L"Unable to create new FDT"); } -static void __init efi_arch_cfg_file_late(EFI_FILE_HANDLE dir_handle, char= *section) +static void __init efi_arch_cfg_file_late(const void * image_base, EFI_FIL= E_HANDLE dir_handle, char *section) { } diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile index b388861..ebb2616 100644 --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -127,13 +127,13 @@ prelink-efi_lto.o: $(ALL_OBJS) efi/runtime.o efi/comp= at.o prelink.o: $(patsubst %/built_in.o,%/built_in_bin.o,$(ALL_OBJS)) prelink_l= to.o =09$(LD) $(XEN_LDFLAGS) -r -o $@ $^ -prelink-efi.o: $(patsubst %/built_in.o,%/built_in_bin.o,$(ALL_OBJS)) preli= nk-efi_lto.o efi/boot.init.o +prelink-efi.o: $(patsubst %/built_in.o,%/built_in_bin.o,$(ALL_OBJS)) preli= nk-efi_lto.o efi/boot.init.o efi/pe.init.o =09$(LD) $(XEN_LDFLAGS) -r -o $@ $^ else prelink.o: $(ALL_OBJS) =09$(LD) $(XEN_LDFLAGS) -r -o $@ $^ -prelink-efi.o: $(ALL_OBJS) efi/boot.init.o efi/runtime.o efi/compat.o +prelink-efi.o: $(ALL_OBJS) efi/boot.init.o efi/pe.init.o efi/runtime.o efi= /compat.o =09$(LD) $(XEN_LDFLAGS) -r -o $@ $(filter-out %/efi/built_in.o,$^) endif diff --git a/xen/arch/x86/efi/Makefile b/xen/arch/x86/efi/Makefile index 3e4c395..cdba3d0 100644 --- a/xen/arch/x86/efi/Makefile +++ b/xen/arch/x86/efi/Makefile @@ -8,7 +8,7 @@ cmd_objcopy_o_ihex =3D $(OBJCOPY) -I ihex -O binary $< $@ boot.init.o: buildid.o -EFIOBJ :=3D boot.init.o compat.o runtime.o +EFIOBJ :=3D boot.init.o pe.init.o compat.o runtime.o $(call cc-option-add,cflags-stack-boundary,CC,-mpreferred-stack-boundary= =3D4) $(EFIOBJ): CFLAGS-stack-boundary :=3D $(cflags-stack-boundary) diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h index 7188c9a..073d2e4 100644 --- a/xen/arch/x86/efi/efi-boot.h +++ b/xen/arch/x86/efi/efi-boot.h @@ -276,9 +276,11 @@ static void __init efi_arch_cfg_file_early(EFI_FILE_HA= NDLE dir_handle, char *sec { } -static void __init efi_arch_cfg_file_late(EFI_FILE_HANDLE dir_handle, char= *section) +static void __init efi_arch_cfg_file_late(const void * image_base, EFI_FIL= E_HANDLE dir_handle, char *section) { union string name; + if ( read_section(image_base, ".ucode", &ucode, NULL) ) + return; name.s =3D get_value(&cfg, section, "ucode"); if ( !name.s ) diff --git a/xen/arch/x86/efi/pe.c b/xen/arch/x86/efi/pe.c new file mode 120000 index 0000000..e1de52a --- /dev/null +++ b/xen/arch/x86/efi/pe.c @@ -0,0 +1 @@ +../../../common/efi/pe.c \ No newline at end of file diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index 5a520bf..0c76f31 100644 --- a/xen/common/efi/boot.c +++ b/xen/common/efi/boot.c @@ -102,6 +102,7 @@ union string { struct file { UINTN size; + bool need_to_free; union { EFI_PHYSICAL_ADDRESS addr; void *ptr; @@ -121,6 +122,8 @@ static CHAR16 *s2w(union string *str); static char *w2s(const union string *str); static bool read_file(EFI_FILE_HANDLE dir_handle, CHAR16 *name, struct file *file, char *options); +static bool read_section(const void * const image_base, + char * const name, struct file *file, char *options); static size_t wstrlen(const CHAR16 * s); static int set_color(u32 mask, int bpp, u8 *pos, u8 *sz); static bool match_guid(const EFI_GUID *guid1, const EFI_GUID *guid2); @@ -330,13 +333,13 @@ static void __init noreturn blexit(const CHAR16 *str) if ( !efi_bs ) efi_arch_halt(); - if ( cfg.addr ) + if ( cfg.addr && cfg.need_to_free) efi_bs->FreePages(cfg.addr, PFN_UP(cfg.size)); - if ( kernel.addr ) + if ( kernel.addr && kernel.need_to_free) efi_bs->FreePages(kernel.addr, PFN_UP(kernel.size)); - if ( ramdisk.addr ) + if ( ramdisk.addr && ramdisk.need_to_free) efi_bs->FreePages(ramdisk.addr, PFN_UP(ramdisk.size)); - if ( xsm.addr ) + if ( xsm.addr && xsm.need_to_free) efi_bs->FreePages(xsm.addr, PFN_UP(xsm.size)); efi_arch_blexit(); @@ -619,6 +622,7 @@ static bool __init read_file(EFI_FILE_HANDLE dir_handle= , CHAR16 *name, what =3D what ?: L"Seek"; else { + file->need_to_free =3D true; file->addr =3D min(1UL << (32 + PAGE_SHIFT), HYPERVISOR_VIRT_END - DIRECTMAP_VIRT_START); ret =3D efi_bs->AllocatePages(AllocateMaxAddress, EfiLoaderData, @@ -665,6 +669,37 @@ static bool __init read_file(EFI_FILE_HANDLE dir_handl= e, CHAR16 *name, return true; } + +static bool __init read_section(const void * const image_base, + char * const name, struct file *file, char *options) +{ + union string name_string =3D { .s =3D name + 1 }; + if ( !image_base ) + return false; + + file->ptr =3D pe_find_section(image_base, name, &file->size); + if ( !file->ptr ) + return false; + + file->need_to_free =3D false; + + if ( file =3D=3D &cfg ) + return true; + + s2w(&name_string); + PrintStr(name_string.w); + PrintStr(L": "); + DisplayUint(file->addr, 2 * sizeof(file->addr)); + PrintStr(L"-"); + DisplayUint(file->addr + file->size, 2 * sizeof(file->addr)); + PrintStr(newline); + + efi_arch_handle_module(file, name_string.w, options); + efi_bs->FreePool(name_string.w); + + return true; +} + static void __init pre_parse(const struct file *cfg) { char *ptr =3D cfg->ptr, *end =3D ptr + cfg->size; @@ -968,6 +1003,21 @@ static void __init setup_efi_pci(void) efi_bs->FreePool(handles); } +static bool __init efi_secure_boot(void) +{ + static const EFI_GUID global_guid =3D EFI_GLOBAL_VARIABLE; + uint8_t buf[8]; + UINTN size =3D sizeof(buf); + + if ( efi_rs->GetVariable(L"SecureBoot", (EFI_GUID *)&global_guid, NULL= , &size, buf) !=3D EFI_SUCCESS ) + return false; + + if ( size !=3D 1 ) + return false; + + return buf[0] !=3D 0; +} + static void __init efi_variables(void) { EFI_STATUS status; @@ -1143,6 +1193,7 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *S= ystemTable) static EFI_GUID __initdata loaded_image_guid =3D LOADED_IMAGE_PROTOCOL= ; static EFI_GUID __initdata shim_lock_guid =3D SHIM_LOCK_PROTOCOL_GUID; EFI_LOADED_IMAGE *loaded_image; + void * image_base =3D NULL; EFI_STATUS status; unsigned int i, argc; CHAR16 **argv, *file_name, *cfg_file_name =3D NULL, *options =3D NULL; @@ -1153,6 +1204,7 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *S= ystemTable) bool base_video =3D false; char *option_str; bool use_cfg_file; + bool secure =3D false; __set_bit(EFI_BOOT, &efi_flags); __set_bit(EFI_LOADER, &efi_flags); @@ -1171,6 +1223,10 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *= SystemTable) PrintErrMesg(L"No Loaded Image Protocol", status); efi_arch_load_addr_check(loaded_image); + if ( loaded_image ) + image_base =3D loaded_image->ImageBase; + + secure =3D efi_secure_boot(); if ( use_cfg_file ) { @@ -1249,9 +1305,15 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *= SystemTable) /* Get the file system interface. */ dir_handle =3D get_parent_handle(loaded_image, &file_name); - /* Read and parse the config file. */ - if ( !cfg_file_name ) + if ( read_section(image_base, ".config", &cfg, NULL) ) + { + if ( secure ) + PrintStr(L"Secure Boot enabled: "); + PrintStr(L"Using unified config file\r\n"); + } + else if ( !cfg_file_name ) { + /* Read and parse the config file. */ CHAR16 *tail; while ( (tail =3D point_tail(file_name)) !=3D NULL ) @@ -1303,26 +1365,36 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE = *SystemTable) efi_arch_cfg_file_early(dir_handle, section.s); option_str =3D split_string(name.s); - read_file(dir_handle, s2w(&name), &kernel, option_str); - efi_bs->FreePool(name.w); - if ( !EFI_ERROR(efi_bs->LocateProtocol(&shim_lock_guid, NULL, - (void **)&shim_lock)) && - (status =3D shim_lock->Verify(kernel.ptr, kernel.size)) !=3D = EFI_SUCCESS ) - PrintErrMesg(L"Dom0 kernel image could not be verified", statu= s); - - name.s =3D get_value(&cfg, section.s, "ramdisk"); - if ( name.s ) + if ( !read_section(image_base, ".kernel", &kernel, option_str) ) { - read_file(dir_handle, s2w(&name), &ramdisk, NULL); + read_file(dir_handle, s2w(&name), &kernel, option_str); efi_bs->FreePool(name.w); + + if ( !EFI_ERROR(efi_bs->LocateProtocol(&shim_lock_guid, NULL, + (void **)&shim_lock)) && + (status =3D shim_lock->Verify(kernel.ptr, kernel.size)) != =3D EFI_SUCCESS ) + PrintErrMesg(L"Dom0 kernel image could not be verified", s= tatus); } - name.s =3D get_value(&cfg, section.s, "xsm"); - if ( name.s ) + if ( !read_section(image_base, ".ramdisk", &ramdisk, NULL) ) { - read_file(dir_handle, s2w(&name), &xsm, NULL); - efi_bs->FreePool(name.w); + name.s =3D get_value(&cfg, section.s, "ramdisk"); + if ( name.s ) + { + read_file(dir_handle, s2w(&name), &ramdisk, NULL); + efi_bs->FreePool(name.w); + } + } + + if ( !read_section(image_base, ".xsm", &xsm, NULL) ) + { + name.s =3D get_value(&cfg, section.s, "xsm"); + if ( name.s ) + { + read_file(dir_handle, s2w(&name), &xsm, NULL); + efi_bs->FreePool(name.w); + } } /* @@ -1358,7 +1430,7 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *S= ystemTable) } } - efi_arch_cfg_file_late(dir_handle, section.s); + efi_arch_cfg_file_late(image_base, dir_handle, section.s); efi_bs->FreePages(cfg.addr, PFN_UP(cfg.size)); cfg.addr =3D 0; diff --git a/xen/common/efi/efi.h b/xen/common/efi/efi.h index 2e38d05..cd5f456 100644 --- a/xen/common/efi/efi.h +++ b/xen/common/efi/efi.h @@ -41,3 +41,6 @@ extern UINT64 efi_apple_properties_addr; extern UINTN efi_apple_properties_len; const CHAR16 *wmemchr(const CHAR16 *s, CHAR16 c, UINTN n); + +void * pe_find_section(const void * const image_base, + const char * section_name, UINTN * size_out); diff --git a/xen/common/efi/pe.c b/xen/common/efi/pe.c new file mode 100644 index 0000000..4eaa73d --- /dev/null +++ b/xen/common/efi/pe.c @@ -0,0 +1,107 @@ +#include "efi.h" + +struct DosFileHeader { + UINT8 Magic[2]; + UINT16 LastSize; + UINT16 nBlocks; + UINT16 nReloc; + UINT16 HdrSize; + UINT16 MinAlloc; + UINT16 MaxAlloc; + UINT16 ss; + UINT16 sp; + UINT16 Checksum; + UINT16 ip; + UINT16 cs; + UINT16 RelocPos; + UINT16 nOverlay; + UINT16 reserved[4]; + UINT16 OEMId; + UINT16 OEMInfo; + UINT16 reserved2[10]; + UINT32 ExeHeader; +} __attribute__((packed)); + +#define PE_HEADER_MACHINE_ARM64 0xaa64 +#define PE_HEADER_MACHINE_X64 0x8664 +#define PE_HEADER_MACHINE_I386 0x014c + +struct PeFileHeader { + UINT16 Machine; + UINT16 NumberOfSections; + UINT32 TimeDateStamp; + UINT32 PointerToSymbolTable; + UINT32 NumberOfSymbols; + UINT16 SizeOfOptionalHeader; + UINT16 Characteristics; +} __attribute__((packed)); + +struct PeHeader { + UINT8 Magic[4]; + struct PeFileHeader FileHeader; +} __attribute__((packed)); + +struct PeSectionHeader { + UINT8 Name[8]; + UINT32 VirtualSize; + UINT32 VirtualAddress; + UINT32 SizeOfRawData; + UINT32 PointerToRawData; + UINT32 PointerToRelocations; + UINT32 PointerToLinenumbers; + UINT16 NumberOfRelocations; + UINT16 NumberOfLinenumbers; + UINT32 Characteristics; +} __attribute__((packed)); + +void * __init pe_find_section(const void * const image_base, + const char * section_name, UINTN * size_out) +{ + const CHAR8 * const base =3D image_base; + const struct DosFileHeader * dos =3D (const void*) base; + const struct PeHeader * pe; + const UINTN name_len =3D strlen(section_name); + UINTN offset; + + if ( base =3D=3D NULL ) + return NULL; + + if ( memcmp(dos->Magic, "MZ", 2) !=3D 0 ) + return NULL; + + pe =3D (const void *) &base[dos->ExeHeader]; + if ( memcmp(pe->Magic, "PE\0\0", 4) !=3D 0 ) + return NULL; + + /* PE32+ Subsystem type */ +#if defined(__ARM__) + if (pe->FileHeader.Machine !=3D PE_HEADER_MACHINE_ARM64) + return NULL; +#elif defined(__x86_64__) + if (pe->FileHeader.Machine !=3D PE_HEADER_MACHINE_X64) + return NULL; +#else + // unknown architecture + return NULL; +#endif + + if ( pe->FileHeader.NumberOfSections > 96 ) + return NULL; + + offset =3D dos->ExeHeader + sizeof(*pe) + pe->FileHeader.SizeOfOptiona= lHeader; + + for (UINTN i =3D 0; i < pe->FileHeader.NumberOfSections; i++) + { + const struct PeSectionHeader *const sect =3D (const struct PeSecti= onHeader *)&base[offset]; + if ( memcmp(sect->Name, section_name, name_len) =3D=3D 0 ) + { + if ( size_out ) + *size_out =3D sect->VirtualSize; + return (void*)(sect->VirtualAddress + (uintptr_t) image_base); + } + + offset +=3D sizeof(*sect); + } + + return NULL; +} diff --git a/xen/scripts/unify-xen b/xen/scripts/unify-xen new file mode 100755 index 0000000..6d17169 --- /dev/null +++ b/xen/scripts/unify-xen @@ -0,0 +1,89 @@ +#!/bin/bash +# Build a "unified Xen" image. +# Usage +# unify xen.efi xen.cfg bzimage initrd [xsm [ucode]] +# +# Merge a Xen configuration, Linux kernel, initrd, and optional XSM or uco= de +# into xen.efi to produce a single signed EFI executable. +# +# For shellcheck +# - turn off "expressions don't expand in single quotes" +# - and "can't follow non-constant sources" +# shellcheck disable=3DSC2016 disable=3DSC1090 +set -e -o pipefail +export LC_ALL=3DC + +die() { echo "$@" >&2 ; exit 1 ; } +warn() { echo "$@" >&2 ; } +debug() { [ "$V" =3D=3D 1 ] && echo "$@" >&2 ; } + +cleanup() { +=09rm -rf "$TMP" +} + +TMP=3D$(mktemp -d) +trap cleanup EXIT + +######################################## + +XEN=3D"$1" +CONFIG=3D"$2" +KERNEL=3D"$3" +RAMDISK=3D"$4" +XSM=3D"$5" +UCODE=3D"$6" + +if [ ! -r "$XEN" ]; then +=09die "$XEN: Unable to find Xen executable" +fi + +BASE_ADDR=3D"$(objdump -h "$XEN" | awk '/ \.text / { print $4 }')" +PREFIX_ADDR=3D"0x$(echo "$BASE_ADDR" | cut -c1-9)" +warn "$XEN: Base address $BASE_ADDR" + +objcopy \ +=09${CONFIG:+\ +=09=09--add-section .config=3D"$CONFIG" \ +=09=09--change-section-vma .config=3D${PREFIX_ADDR}1000000 \ +=09} \ +=09${UCODE:+\ +=09=09--add-section .ucode=3D"$UCODE" \ +=09=09--change-section-vma .ucode=3D${PREFIX_ADDR}1010000 \ +=09} \ +=09${XSM:+\ +=09=09--add-section .xsm=3D"$XSM" \ +=09=09--change-section-vma .xsm=3D${PREFIX_ADDR}1080000 \ +=09} \ +=09${KERNEL:+\ +=09=09--add-section .kernel=3D"$KERNEL" \ +=09=09--change-section-vma .kernel=3D${PREFIX_ADDR}1100000 \ +=09} \ +=09${RAMDISK:+\ +=09=09--add-section .ramdisk=3D"$RAMDISK" \ +=09=09--change-section-vma .ramdisk=3D${PREFIX_ADDR}2000000 \ +=09} \ +=09"$XEN" \ +=09"$TMP/xen.efi" \ +|| die "$TMP/xen.efi: unable to create" + +KEY_ENGINE=3D"" +KEY=3D"/etc/safeboot/signing.key" +CERT=3D"/etc/safeboot/cert.pem" + +for try in 1 2 3 ; do +=09warn "$TMP/xen.efi: Signing (ignore warnings about gaps)" +=09sbsign.safeboot \ +=09=09$KEY_ENGINE \ +=09=09--key "$KEY" \ +=09=09--cert "$CERT" \ +=09=09--output "xen.signed.efi" \ +=09=09"$TMP/xen.efi" \ +=09&& break + +=09if [ "$try" =3D=3D 3 ]; then +=09=09die "xen.signed.efi: failed after $try tries" +=09fi + +=09warn "signature failed! Try $try." +done + From xen-devel-bounces@lists.xenproject.org Thu Aug 06 14:28:42 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 14:28:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3gsj-0005YC-S4; Thu, 06 Aug 2020 14:28:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3gsi-0005Y7-LU for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 14:28:32 +0000 X-Inumbo-ID: abc04708-6493-475b-9b33-dee18dee49f2 Received: from mail-lf1-x142.google.com (unknown [2a00:1450:4864:20::142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id abc04708-6493-475b-9b33-dee18dee49f2; Thu, 06 Aug 2020 14:28:31 +0000 (UTC) Received: by mail-lf1-x142.google.com with SMTP id x24so8892436lfe.11 for ; Thu, 06 Aug 2020 07:28:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=k70CcyaQid7eNox+lj8GvXJZM2fQRHdHzudRaxdVrwE=; b=XfJMPyotCYZOjizw3Y+NOcbVreTn1E/ROpVTR261WPmzHFXB9kKy4HJPW8Uw91yHwl tmoPlK4iqCW4Uw6VZ+XvlRqLaZqk/42D/YppFSpUs4N4ucu14013z1BUZ9197TfJDMvJ 61W+yTgBySHRqrcmpeLI4L4FwNNJAknfVw+F9+91R9bR0d7Fv+yINYaXMLTvz0c7Y2yz CSgDdRM+X7hbxXIF2hJ0NTNmyJouxe1zy84DZpPeM4EoAfaZ+YqhssIjhLe3n3zwZJrt pdHoE3RcQ/tHOQtF4d4MtNPY44AM4pH3Vh2iB31KY7iAdz3k9ffOoCvJVh5P0TOo+k/U hIsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=k70CcyaQid7eNox+lj8GvXJZM2fQRHdHzudRaxdVrwE=; b=nDPBUtEeX4egC7dqVfCOBjzP/tNSFLZ57E4IQYeMgKrkbfOIHG0nBFQROilBQtWU4/ /izsS2I/ctoS6MQFqQbxKju8BRVslyAXRLCJDF6JKm25UtkyaM+wKTlASb1EWvtkOM49 JcqTrLTLWwJuamwbslnaIk7eAMl9c9BqpLDN2z6AYIsUDibNMCGahyVs4Ujnv/RdcXev 0A7y5DGj1kUuP8nhdKIRz/xIG+NU/c/mhB6EJg835HRgo23K9VyTSY8y4H6pS/FPCdj6 uMaVuTt7MT0OsLZr9USXbkye4Gi5g0xzQCD9pjnU8Qtn0t3chFEzG4Ccvg5GJXvIDYTy SeCQ== X-Gm-Message-State: AOAM532cvixwq+k73/tlZUN5jBkm4TpIgKW5WxvSQn9H9i9UTJApUnQn xOtw4Irx/LLEDQpBdYxsnlc= X-Google-Smtp-Source: ABdhPJyHa05Cen5obpKOoZ8kv0NEhLNO7eSQk92T0cD1qqqRnSoky+AQ9fWe8qvDHZI9TBlEy+ylGw== X-Received: by 2002:a19:e45:: with SMTP id 66mr4035487lfo.82.1596724110519; Thu, 06 Aug 2020 07:28:30 -0700 (PDT) Received: from [192.168.1.2] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id t10sm2490758ljg.60.2020.08.06.07.28.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2020 07:28:30 -0700 (PDT) Subject: Re: [RFC PATCH V1 08/12] xen/arm: Invalidate qemu mapcache on XENMEM_decrease_reservation To: Jan Beulich References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-9-git-send-email-olekstysh@gmail.com> <21b7d8ed-f305-8abe-0e4e-174d72d087c8@suse.com> <04cfd6e4-1ed0-52c3-a3b0-d555d9dc632b@suse.com> From: Oleksandr Message-ID: <0ff0807f-c5d3-f63c-d54c-860648ef3a13@gmail.com> Date: Thu, 6 Aug 2020 17:28:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <04cfd6e4-1ed0-52c3-a3b0-d555d9dc632b@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 06.08.20 14:50, Jan Beulich wrote: Hi Jan >>> On 03.08.2020 20:21, Oleksandr Tyshchenko wrote: >>>> --- a/xen/common/memory.c >>>> +++ b/xen/common/memory.c >>>> @@ -1652,6 +1652,12 @@ long do_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg) >>>> break; >>>> } >>>> >>>> + /* x86 already sets the flag in hvm_memory_op() */ >>>> +#if defined(CONFIG_ARM64) && defined(CONFIG_IOREQ_SERVER) >>>> + if ( op == XENMEM_decrease_reservation ) >>>> + curr_d->arch.hvm.qemu_mapcache_invalidate = true; >>>> +#endif >>> Doesn't the comment already indicate a route towards an approach >>> not requiring to alter common code? >> Given that IOREQ is now moved under common/, I think it would make sense >> to have this set in common code as well for all the architecture. >> >> IOW, I would suggest to drop the #ifdef CONFIG_ARM64. In addition, we >> may want to introduce an helper to check if a domain is using ioreq. > Of course, with the (part of the) conditional dropped and the struct > field moved out of the arch sub-struct, this is fine to live here. ok. I suspect this should *also* live in compat_memory_op(). Please confirm whether my understanding correct. -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Thu Aug 06 14:57:55 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 14:57:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3hL0-00086q-Bj; Thu, 06 Aug 2020 14:57:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3hKz-00086l-DJ for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 14:57:45 +0000 X-Inumbo-ID: 69314e7d-1d3e-4e54-8e57-b508ae626cb9 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 69314e7d-1d3e-4e54-8e57-b508ae626cb9; Thu, 06 Aug 2020 14:57:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596725865; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=jFz80T16EOcJg2+pcu+RItNVey5tN69mEwikaX2UYpA=; b=G4RbuJs1TaoapNtUF0qH4oEEB6MneTcKMangY/RNhOXtAv7bcmuNUt7Q mzNP7WS9ipbHQg696mkIMSpfHw2FqOlhHLaYg9M7OQXv9eS2HKT2ZsD2Y TGZfBqJTr0yG8yCN33sE9fzYCgI72fhuobpurls7YZhdZ7RA1GqdlkKWa w=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 817E7x4PikiW+9i7BdycV0Pf9GSxivWjxZLH7dmxiaPUgImB8DsQrA3eGfSc8FExCVStn6wgIs jwuKwtmVum7Fj0gi1j2+yh5i8xaqcnfb87GJmkA8yMSc10T9nM7Xsa0k2JovJ6j3SkKhrtwjXN whTjikeURbgcnRJK6FWFr0Rm5jktCq73X3Zu7AW5h/Asg/5WFdonfcK8PhV+/TDtpYjvZonTip Icj8oQSx3+6jR6bTjHFppCxT6c5n9iqrmN2OFU8b8ePopHaY9ZCDS2+f9MruoJ6ubgI+Niti9F Ppc= X-SBRS: 3.7 X-MesageID: 24022695 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,441,1589256000"; d="scan'208";a="24022695" Subject: Re: [PATCH 1/4] build: work around bash issue To: Jan Beulich , Julien Grall References: <305c2532-408a-9f78-61fe-c90a2e86eb8e@suse.com> From: Andrew Cooper Message-ID: <6a7226b9-9702-9adc-c849-e21d27a8fced@citrix.com> Date: Thu, 6 Aug 2020 15:57:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , George Dunlap , Ian Jackson , Anthony Perard , "xen-devel@lists.xenproject.org" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 06/08/2020 10:14, Jan Beulich wrote: > On 06.08.2020 11:07, Julien Grall wrote: >> On 06/08/2020 10:04, Jan Beulich wrote: >>> Older bash fails to honor "set -e" for certain built-in commands >> "Older" is pretty vague. May I ask the exact version you run into the issue? > If I knew in what version the issue got fixed, I'd have specified > that version. I've observed it with 3.2.57(2). Its still very useful information for the commit message. I tend to phrase something like this as "Older versions of bash (at least, 3.2.57(2))" which gives a clear indication that the problem was observed with the specified version, without suggesting that this is a boundary of when the issue was introduced/fixed. With this adjusted, Acked-by: Andrew Cooper to avoid a second posting. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Aug 06 15:25:59 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 15:25:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3hm8-0002WC-E7; Thu, 06 Aug 2020 15:25:48 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3hm7-0002W5-6m for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 15:25:47 +0000 X-Inumbo-ID: bcfbc8a7-3df8-4100-b6a8-8f48f603add0 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id bcfbc8a7-3df8-4100-b6a8-8f48f603add0; Thu, 06 Aug 2020 15:25:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596727546; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=K+oriAnIaJvKhD6uHcdVOVRcgp4QC3R04HEDnpu2fDk=; b=W6Y0twERyKvBtdMUoejMX94OTPVUALZzXcQ3Yyx5By7k+vsOMATxZHVg xOIQ36dlYbOgaTZvpeb7JtlCI0cJeGxDUPI6RhnQgLvIjFCGqwwOLGElC fHSVdfbKfd5odnghpWtjtSRa0FRKHaIFwM3Hcgw+xdNRmQq4ESQqsunlH k=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: Kbr+6e/GVFDTfVNZLVRoVOv3aGr/uIu+2TIOgn2uwLLXTbCZjKhM+cfS0SlA1GELBjzymj3c8/ 87kXyY5PwS0M4+bPyVdsTA1gchDviL8YLCyqxvdRg1R8xNBPdBjNlQuRSyDjzvSzmSyYlI5wQ5 Wthr60Xas5DeJtpG4+93ByjUsx1C9bPjRMJw93wZkAkspdhjFV9gxmpwQNWziceJfxpBmKxzjh hKxiM8fbo+flIL+M8LHIYqTAqwsEkALtmKyp+jL2NkdKXV9C/x+ewZcoVz9oKSGlHwFWdAeHg1 YB4= X-SBRS: 3.7 X-MesageID: 24343692 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,441,1589256000"; d="scan'208";a="24343692" Subject: Re: [PATCH 2/4] build: correctly report non-empty section sizes upon .o -> .init.o conversion To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <305c2532-408a-9f78-61fe-c90a2e86eb8e@suse.com> <5fcb47ec-4a0e-99a2-c548-f42ec1cc8030@suse.com> From: Andrew Cooper Message-ID: <2d573b9e-e69e-80b9-444e-affbb105d8c5@citrix.com> Date: Thu, 6 Aug 2020 16:25:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <5fcb47ec-4a0e-99a2-c548-f42ec1cc8030@suse.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: George Dunlap , Ian Jackson , Stefano Stabellini , Julien Grall , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 06/08/2020 10:05, Jan Beulich wrote: > The originally used sed expression converted not just multiple leading > zeroes (as intended), but also trailing ones, rendering the error > message somewhat confusing. Collapse zeroes in just the one place where > we need them collapsed, and leave objdump's output as is for all other > purposes. > > Fixes: 48115d14743e ("Move more kernel decompression bits to .init.* sections") > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Thu Aug 06 16:16:39 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 16:16:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3iZD-0007Sl-1e; Thu, 06 Aug 2020 16:16:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3iZC-0007Sg-54 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 16:16:30 +0000 X-Inumbo-ID: 9ae527fb-bd6b-4291-a457-7565521ba2d2 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9ae527fb-bd6b-4291-a457-7565521ba2d2; Thu, 06 Aug 2020 16:16:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596730589; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=NOoPReUR2/73mPUGLgNxFVzpf2thMQlw+Cwzermcn7s=; b=U1GJQcef+Z4sXqnIGzjjA/yi/zKLjdawKmA65Z4Dqh0KhuDYm/9cA/qu heIRpQw8mruLO2LwNi0t5urPIJpiJIMpVgwVO1FITemOfM36ra+LDEl+6 DD2eXEUpFg9ABPiQfs+5DjoaloEmwn1H5nYDBXnfydn/kE+6PTwOc1H/V U=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: lV8/toVquaGlHPIi4C9qDuo0g1YwAuDeXM1B2L1YySKCQt6VLuxA4QUjnEmlzk1qXQJkrrY8gg gq/y/V5YO4uap0xXiXiPBxXbw5KLJm+cb7cr4rTYObSozSSCU3Ikv2wxXhBBQuh7jKRCqQNVVY A4CdBRgbGU9y8RPO8o11Smz0QipUCugvczKK1yJR8k5UVYYT/AwxzMwl2GDMG/3SMztyWvzp64 B1npECp4EC0S67sw5WPrt5CKGqW/ER0E/NNMMjYP/kNkcsB8CVXORuguN8D7+vdTK5tdB6XAHA Suw= X-SBRS: 3.7 X-MesageID: 24003567 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,441,1589256000"; d="scan'208";a="24003567" Subject: Re: [PATCH 3/4] build: also check for empty .bss.* in .o -> .init.o conversion To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <305c2532-408a-9f78-61fe-c90a2e86eb8e@suse.com> From: Andrew Cooper Message-ID: <5b2bbc31-0095-c3e2-9e34-20453ea2aa5f@citrix.com> Date: Thu, 6 Aug 2020 17:16:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , George Dunlap , Ian Jackson , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 06/08/2020 10:05, Jan Beulich wrote: > We're gaining such sections, and like .text.* and .data.* they shouldn't > be present in objects subject to automatic to-init conversion. Oddly > enough for quite some time we did have an instance breaking this rule, > which gets fixed at this occasion, by breaking out the EFI boot > allocator functions into its own translation unit. > > Fixes: c5b9805bc1f7 ("efi: create new early memory allocator") > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper > --- > This likely has a (weak) dependency on "x86/EFI: sanitize build logic" > sent several weeks ago, due to the new source file added, as explicit > dependencies upon the individual objects in x86/Makefile go away there. > > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -355,7 +355,7 @@ $(TARGET): delete-unfresh-files > $(MAKE) -C tools > $(MAKE) -f $(BASEDIR)/Rules.mk include/xen/compile.h > [ -e include/asm ] || ln -sf asm-$(TARGET_ARCH) include/asm > - [ -e arch/$(TARGET_ARCH)/efi ] && for f in boot.c runtime.c compat.c efi.h;\ > + [ -e arch/$(TARGET_ARCH)/efi ] && for f in $$(cd common/efi; echo *.[ch]); \ > do test -r arch/$(TARGET_ARCH)/efi/$$f || \ > ln -nsf ../../../common/efi/$$f arch/$(TARGET_ARCH)/efi/; \ > done; \ Maybe not for this patch, but we need to start removing this (and other) symlinking in the tree for proper out-of-tree builds to work. AFAICT, this logic predates both Kconfig and x86's blur into having EFI support in xen.gz. Can't we remove all of this by having CONFIG_XEN_PE expressed/selectable properly in Kconfig, and gathering all the objects normally, rather than bodging all of common/efi/ through arch/efi/ ? ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Aug 06 16:33:54 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 16:33:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3ipj-0000hg-JI; Thu, 06 Aug 2020 16:33:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3ipi-0000hb-9U for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 16:33:34 +0000 X-Inumbo-ID: 09ca4436-44b7-4f21-86f9-16f62750f315 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 09ca4436-44b7-4f21-86f9-16f62750f315; Thu, 06 Aug 2020 16:33:33 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A055DAC48; Thu, 6 Aug 2020 16:33:49 +0000 (UTC) Subject: Re: [RFC PATCH V1 08/12] xen/arm: Invalidate qemu mapcache on XENMEM_decrease_reservation To: Oleksandr References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-9-git-send-email-olekstysh@gmail.com> <21b7d8ed-f305-8abe-0e4e-174d72d087c8@suse.com> <04cfd6e4-1ed0-52c3-a3b0-d555d9dc632b@suse.com> <0ff0807f-c5d3-f63c-d54c-860648ef3a13@gmail.com> From: Jan Beulich Message-ID: <52549e1a-d29b-d2c5-8173-e44dbd67d04f@suse.com> Date: Thu, 6 Aug 2020 18:33:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <0ff0807f-c5d3-f63c-d54c-860648ef3a13@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 06.08.2020 16:28, Oleksandr wrote: > > On 06.08.20 14:50, Jan Beulich wrote: > > Hi Jan > >>>> On 03.08.2020 20:21, Oleksandr Tyshchenko wrote: >>>>> --- a/xen/common/memory.c >>>>> +++ b/xen/common/memory.c >>>>> @@ -1652,6 +1652,12 @@ long do_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg) >>>>> break; >>>>> } >>>>> >>>>> + /* x86 already sets the flag in hvm_memory_op() */ >>>>> +#if defined(CONFIG_ARM64) && defined(CONFIG_IOREQ_SERVER) >>>>> + if ( op == XENMEM_decrease_reservation ) >>>>> + curr_d->arch.hvm.qemu_mapcache_invalidate = true; >>>>> +#endif >>>> Doesn't the comment already indicate a route towards an approach >>>> not requiring to alter common code? >>> Given that IOREQ is now moved under common/, I think it would make sense >>> to have this set in common code as well for all the architecture. >>> >>> IOW, I would suggest to drop the #ifdef CONFIG_ARM64. In addition, we >>> may want to introduce an helper to check if a domain is using ioreq. >> Of course, with the (part of the) conditional dropped and the struct >> field moved out of the arch sub-struct, this is fine to live here. > > ok. > > > I suspect this should *also* live in compat_memory_op(). Please confirm > whether my understanding correct. Doesn't compat_memory_op() simply call here, so will have the flag set as needed? Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 16:36:24 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 16:36:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3isS-0000qm-1M; Thu, 06 Aug 2020 16:36:24 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3isR-0000qh-I7 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 16:36:23 +0000 X-Inumbo-ID: 62e90df1-a15b-4c69-a935-d05dd14dbb0e Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 62e90df1-a15b-4c69-a935-d05dd14dbb0e; Thu, 06 Aug 2020 16:36:22 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7D2C4AC48; Thu, 6 Aug 2020 16:36:39 +0000 (UTC) Subject: Re: [RFC] efi/boot: Unified Xen executable for UEFI Secure Boot support To: Trammell Hudson References: <1bd2d79e-5bef-835c-f6cc-9fd367e8beb7@suse.com> <5e3b16b3-0f93-4683-dcc7-852c805870c8@suse.com> From: Jan Beulich Message-ID: <72a81e28-7127-6589-d95d-b27b695b85da@suse.com> Date: Thu, 6 Aug 2020 18:36:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 06.08.2020 16:15, Trammell Hudson wrote: > On Thursday, August 6, 2020 2:04 PM, Jan Beulich wrote: >> On 06.08.2020 13:44, Trammell Hudson wrote: >>> On Thursday, August 6, 2020 9:57 AM, Jan Beulich jbeulich@suse.com wrote: >>>> Overall I think it might help if this PE parsing code (if UEFI >>>> doesn't offer a protocol to do it for us) was put into its own >>>> source file. >>> >>> I tried to putting it into a separate file and ran into link issues, >>> seems that it needs to be mentioned in both arch/x86/Makefile and >>> arch/x86/pe/Makefile, so this was a "just make it work" for the PoC. >>> Now that it is working, I'll go back to see if I can figure out the >>> makefile magic. >> >> I was rather thinking of e.g. xen/common/efi/pe.c. > > PE parsing code is in now in common/efi/pe.c, with a symlink in arch/x86/efi/, > and I added an extern in common/efi/efi.h. The Makefiles in both arch/x86 and > arch/x86/efi required updates to link in the extra pe.init.o file. Patches have already been submitted to hopefully make some or even all of these extra adjustments unnecessary. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 16:40:35 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 16:40:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3iwR-0001fS-JA; Thu, 06 Aug 2020 16:40:31 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3iwQ-0001fN-Ml for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 16:40:30 +0000 X-Inumbo-ID: 97cc05d9-200d-4892-9751-66741e1923e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 97cc05d9-200d-4892-9751-66741e1923e4; Thu, 06 Aug 2020 16:40:28 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 81D1CB734; Thu, 6 Aug 2020 16:40:44 +0000 (UTC) Subject: Re: EFI executable corruption when live patching is turned off To: Trammell Hudson References: <3TMd7J2u5gCA8ouIG_Xfcw7s5JKMG06XsDIesEB3Fi9htUJ43Lfl057wXohlpCHcszqoCmicpIlneEDO26ZqT8QfC2Y39VxBuqD3nS1j5Q4=@trmm.net> From: Jan Beulich Message-ID: Date: Thu, 6 Aug 2020 18:40:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <3TMd7J2u5gCA8ouIG_Xfcw7s5JKMG06XsDIesEB3Fi9htUJ43Lfl057wXohlpCHcszqoCmicpIlneEDO26ZqT8QfC2Y39VxBuqD3nS1j5Q4=@trmm.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Xen-devel Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 05.08.2020 20:19, Trammell Hudson wrote: > When building xen from head with almost any combination of options, the resulting xen.efi seems properly formed. When CONFIG_LIVEPATCH is turned off, however, the resulting xen.efi is corrupted in some way and binutils no longer wants to work with it: > > ~/build/xen-clean/xen$ git rev-parse HEAD > 81fd0d3ca4b2cd309403c6e8da662c325dd35750 > ~/build/xen-clean/xen$ diff .config.orig .config > 71,72c71 > < CONFIG_LIVEPATCH=y > < CONFIG_FAST_SYMBOL_LOOKUP=y > --- >> # CONFIG_LIVEPATCH is not set > 105a105 >> # CONFIG_COVERAGE is not set > ~/build/xen-clean/xen$ objcopy xen-orig.efi test.efi > ~/build/xen-clean/xen$ objcopy xen.efi test.efi > objcopy: test.efi: Data Directory size (1c) exceeds space left in section (18) > objcopy: test.efi: error copying private BFD data: file in wrong format > ~/build/xen-clean/xen$ objcopy --version | head -1 > GNU objcopy (GNU Binutils for Ubuntu) 2.34 > > > I spent most of today unsuccessfully trying to figure out what was different between the builds (on multiple build host OS with different binutils), so I'm hoping that perhaps someone else has seen this problem. I've tried to find a sensible way to fix this in objcopy, but could come up with only a somewhat hackish variant: https://sourceware.org/pipermail/binutils/2020-August/112746.html Let's see what the maintainers there think, or if they have better suggestions (or are willing to address this themselves). The issue is pretty certainly not tied to LIVEPATCH, but rather to how much padding space there is at the end of the .rodata section. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 16:57:29 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 16:57:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3jCk-0002hB-06; Thu, 06 Aug 2020 16:57:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3jCi-0002gf-JV for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 16:57:20 +0000 X-Inumbo-ID: 5de44ed9-0a5b-4eff-9dbb-453693d2fb70 Received: from mail-lj1-x242.google.com (unknown [2a00:1450:4864:20::242]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5de44ed9-0a5b-4eff-9dbb-453693d2fb70; Thu, 06 Aug 2020 16:57:19 +0000 (UTC) Received: by mail-lj1-x242.google.com with SMTP id z14so14982439ljm.1 for ; Thu, 06 Aug 2020 09:57:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=4qV6lUrNuALPJYj9m7qEjE220AEOLRVX5YbSyC4XAio=; b=oGVOb19DcQKszsJ6FntN0KTnw/p+sNSZLaNbgmitgAJrNaL0oSanHoyvL2V2tLT/1j F5//KIg4mn5D41FQqZWMuusG2ME0UuoSiJK87XX6QgDtI/CZQy73j2M8dVGwye0bMLdA 6tUWAbA4JTZr1jxz+b7UblA0q7eiPOKegk7bydaAyNupadMljXYBI7C/vTZr2NEbAhEe DB3SyD26XSwP7nAwx1fTKNY3CDgtam/Y+LOmWqtSdCZc/gGQycbzgzeDLoMHGrgRX7r6 l7H49Qeqzqkh1bMDUHhLzQqRI86C5DB7OBrw+FC3cYKyCq/CFxrzPwHfJoSoUCD6JXWu pZXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=4qV6lUrNuALPJYj9m7qEjE220AEOLRVX5YbSyC4XAio=; b=Lc8WV48F/iwNfsimQgUqUFqOF1+l7TicDzZAMgnSp9Q2q66V0T82uVrG3ZR2R5h2Yz O1ae/vO9cQ9HlLR+hzIW2VHpjwVAffUKeImAY67ZVF0lXwZwl+lT9z3wa4Mi8fpuMCWR x25U+1dwq5DQLLCL2a9gYZOXLTgHivznvEL7T7CMHb+MuVNqAcf9K8CHXgHokNgdX0OE E1dRxQw9LhvqcVr5w2Gm1LVU/QkEiQxDnx5IXusTvwHJ7bUuyfQJJ8jo/eIoWAUxVqMd 1CMMud/4pQ+fYGtEO9gLVmkGxyEiVGUlYq1jn7mwjCw/RV0W/PdhKRZ7VLyFmiZ1Z6+N hNsQ== X-Gm-Message-State: AOAM530ODQ3OJ3DNwSjOXcfAb04uR15yHt2zvEmGbkl85aTupXRCdjoy uh63YiM/j4b4LC34SLHZaJw= X-Google-Smtp-Source: ABdhPJzXJz2noTKioWXqsb7e/poKnbAn+qTf4RRcrgnXbvrgBF5Rxiv4+O3HGjveFX6IE24dpBOmWQ== X-Received: by 2002:a2e:a316:: with SMTP id l22mr2262606lje.301.1596733038503; Thu, 06 Aug 2020 09:57:18 -0700 (PDT) Received: from [192.168.1.2] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id w19sm2668465ljd.112.2020.08.06.09.57.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2020 09:57:18 -0700 (PDT) Subject: Re: [RFC PATCH V1 08/12] xen/arm: Invalidate qemu mapcache on XENMEM_decrease_reservation To: Jan Beulich References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-9-git-send-email-olekstysh@gmail.com> <21b7d8ed-f305-8abe-0e4e-174d72d087c8@suse.com> <04cfd6e4-1ed0-52c3-a3b0-d555d9dc632b@suse.com> <0ff0807f-c5d3-f63c-d54c-860648ef3a13@gmail.com> <52549e1a-d29b-d2c5-8173-e44dbd67d04f@suse.com> From: Oleksandr Message-ID: <343fa576-0575-c7cc-1097-6a463c3662dd@gmail.com> Date: Thu, 6 Aug 2020 19:57:12 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <52549e1a-d29b-d2c5-8173-e44dbd67d04f@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 06.08.20 19:33, Jan Beulich wrote: Hi Jan. > On 06.08.2020 16:28, Oleksandr wrote: >> On 06.08.20 14:50, Jan Beulich wrote: >> >> Hi Jan >> >>>>> On 03.08.2020 20:21, Oleksandr Tyshchenko wrote: >>>>>> --- a/xen/common/memory.c >>>>>> +++ b/xen/common/memory.c >>>>>> @@ -1652,6 +1652,12 @@ long do_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg) >>>>>> break; >>>>>> } >>>>>> >>>>>> + /* x86 already sets the flag in hvm_memory_op() */ >>>>>> +#if defined(CONFIG_ARM64) && defined(CONFIG_IOREQ_SERVER) >>>>>> + if ( op == XENMEM_decrease_reservation ) >>>>>> + curr_d->arch.hvm.qemu_mapcache_invalidate = true; >>>>>> +#endif >>>>> Doesn't the comment already indicate a route towards an approach >>>>> not requiring to alter common code? >>>> Given that IOREQ is now moved under common/, I think it would make sense >>>> to have this set in common code as well for all the architecture. >>>> >>>> IOW, I would suggest to drop the #ifdef CONFIG_ARM64. In addition, we >>>> may want to introduce an helper to check if a domain is using ioreq. >>> Of course, with the (part of the) conditional dropped and the struct >>> field moved out of the arch sub-struct, this is fine to live here. >> ok. >> >> >> I suspect this should *also* live in compat_memory_op(). Please confirm >> whether my understanding correct. > Doesn't compat_memory_op() simply call here, so will have the flag set > as needed? Indeed, sorry for the noise. -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Thu Aug 06 17:44:57 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 17:44:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3jwQ-0006uv-IW; Thu, 06 Aug 2020 17:44:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3jwP-0006ub-MF for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 17:44:33 +0000 X-Inumbo-ID: 22f86972-a485-4503-a3da-881acb80c9f4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 22f86972-a485-4503-a3da-881acb80c9f4; Thu, 06 Aug 2020 17:44:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=XrLVSe/9iOruavnpecAOGTHu2VAtkqiFn0DuxMFdFzI=; b=AbIyQAGfeQMTrMrEcItMpcTDs +WwVHF6lDGpW9jd4qBvsUHEnR5pltj+ZVM4RU28mpYgYeU5w25EUtUuA8SSBuL+7ghBuACd9gO0P0 D2ES30XuBJIamWJHtWU3WvEGHv9+/rkxj7llLd5+CPJiNZJsZ0sUlD7BQYTvg2dfdkdvo=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3jwI-0001Df-67; Thu, 06 Aug 2020 17:44:26 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k3jwH-0005za-PW; Thu, 06 Aug 2020 17:44:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k3jwH-0006hq-Os; Thu, 06 Aug 2020 17:44:25 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 152502: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=84bb5fd1ab2bce88e508d416f4bcea520c803ea8 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Thu, 06 Aug 2020 17:44:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152502 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/152502/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a version targeted for testing: libvirt 84bb5fd1ab2bce88e508d416f4bcea520c803ea8 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 27 days Failing since 151818 2020-07-11 04:18:52 Z 26 days 27 attempts Testing same since 152502 2020-08-06 04:20:09 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrea Bolognani Balázs Meskó Bastien Orivel Bihong Yu Binfeng Wu Boris Fiuczynski Côme Borsoi Daniel Henrique Barboza Daniel P. Berrange Daniel P. Berrangé Erik Skultety Fedora Weblate Translation Han Han Hao Wang Jean-Baptiste Holcroft Jianan Gao Jin Yan Jiri Denemark Ján Tomko Laine Stump Liao Pingfang Martin Kletzander Michal Privoznik Nikolay Shirokovskiy Paulo de Rezende Pinatti Pavel Hrdina Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Roman Bogorodskiy Ryan Schmidt Stefan Berger Szymon Scholz Wang Xin Weblate Yang Hang Yi Wang Yuri Chornoivan Zheng Chuan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 8907 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Aug 06 18:10:24 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 18:10:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3kLI-00015V-OP; Thu, 06 Aug 2020 18:10:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3kLH-00015Q-0B for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 18:10:15 +0000 X-Inumbo-ID: 1edb704f-63dd-4da4-a270-6dadf0dc6f39 Received: from mail1.protonmail.ch (unknown [185.70.40.18]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1edb704f-63dd-4da4-a270-6dadf0dc6f39; Thu, 06 Aug 2020 18:10:12 +0000 (UTC) Date: Thu, 06 Aug 2020 18:10:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trmm.net; s=protonmail; t=1596737411; bh=A96Ly/X7XtmMBUSs9TB/vOHY3B3n6bGi+f5LX2HnQSw=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=ZCUH+4I0B++i6EdEArGCQumN7ATjS6xiLjndfeXqTnEZj/CQQ7sFuqv9bRUAJK8Fn G4pBtljb9ZwWY4Www5SWyUUFPjJmR87gSqy/gQ2n252cn1DHae5/pD6R9Zha0XxR7U lJMFqy2+C7UAt9j3617GLrS+q6q4x9KB2zhJWXDg= To: Jan Beulich From: Trammell Hudson Subject: Re: EFI executable corruption when live patching is turned off Message-ID: In-Reply-To: References: <3TMd7J2u5gCA8ouIG_Xfcw7s5JKMG06XsDIesEB3Fi9htUJ43Lfl057wXohlpCHcszqoCmicpIlneEDO26ZqT8QfC2Y39VxBuqD3nS1j5Q4=@trmm.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: Trammell Hudson Cc: Xen-devel Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Thursday, August 6, 2020 6:40 PM, Jan Beulich wrote: > On 05.08.2020 20:19, Trammell Hudson wrote: > [...] > > ~/build/xen-clean/xen$ objcopy xen.efi test.efi > > objcopy: test.efi: Data Directory size (1c) exceeds space left in secti= on (18) > > objcopy: test.efi: error copying private BFD data: file in wrong format > > ~/build/xen-clean/xen$ objcopy --version | head -1 > > GNU objcopy (GNU Binutils for Ubuntu) 2.34 > > I've tried to find a sensible way to fix this in objcopy, but could > come up with only a somewhat hackish variant: > https://sourceware.org/pipermail/binutils/2020-August/112746.html > Let's see what the maintainers there think, or if they have better > suggestions (or are willing to address this themselves). The issue > is pretty certainly not tied to LIVEPATCH, but rather to how much > padding space there is at the end of the .rodata section. Thanks for tracking that down! I was also almost certain it was not a live= patch issue, although that was the easiest minimal test case that I could p= roduce. As a workaround for the Xen project, what do you think of forcing alignment= on .buildid so that the tool is happy: diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S index 111edb5..712ffc8 100644 --- a/xen/arch/x86/xen.lds.S +++ b/xen/arch/x86/xen.lds.S @@ -161,6 +161,7 @@ SECTIONS __note_gnu_build_id_end =3D .; } :note :text #elif defined(BUILD_ID_EFI) + . =3D ALIGN(4096); DECL_SECTION(.buildid) { __note_gnu_build_id_start =3D .; *(.buildid) -- Trammell From xen-devel-bounces@lists.xenproject.org Thu Aug 06 18:14:55 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 18:14:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3kPm-0001Gr-B6; Thu, 06 Aug 2020 18:14:54 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3kPl-0001Gm-MN for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 18:14:53 +0000 X-Inumbo-ID: 28bd1d69-615c-463c-9edd-5f52e2d15ec3 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 28bd1d69-615c-463c-9edd-5f52e2d15ec3; Thu, 06 Aug 2020 18:14:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596737692; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=NnooFXVGBE3t5Dl34Ex/rObZe8p4BOXf0ZuzvzW4zlY=; b=SoVOxDN60H8OyHRihzyH1idLz3I/LBgatHW2tPhDOupGVmPplFokIbqm rEgVuN3Ov99chooFpFQxBkuQzmzGI0BMjTCzFCP6j8jQ9gqwBqpJrd9jI yQKfII4eIaUwAR/wn0vMpJXPsaCj+Ty/H2KDk+p3Oscx820rfia51rKUi g=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 38KQS5iY/6syySpqkUy2DhJBo4gDFpxcatHY3SSKgAnUKagzlqdeCURXx7BV4ZiNhExGHmSAjH f59oU4s/mejxEJ27b0Dr32JdhkftFY6Ahr4ReOLJLcMTCFWyidhVqtW1+FEsCaFSBVDx9zBxaj sAG8fCxvYdDgBan/txE1YBdJ8IlUYh+ltGsR8uPYPTeaonN8MdUxtivZifc6HXjBxTRgTpBCV7 N/mTg0BRR8ZmIxsGIZX2lUwf9DENpXsU2LY2yRCoUPTvAUKKfQ+R74V+SDEKQp5ED4ni+ig5D0 KGk= X-SBRS: 3.7 X-MesageID: 24918326 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,441,1589256000"; d="scan'208";a="24918326" Subject: Re: [RFC] efi/boot: Unified Xen executable for UEFI Secure Boot support To: Trammell Hudson , Jan Beulich References: <1bd2d79e-5bef-835c-f6cc-9fd367e8beb7@suse.com> <5e3b16b3-0f93-4683-dcc7-852c805870c8@suse.com> From: Andrew Cooper Message-ID: <132b5b88-c78d-01cf-df27-6430689570e4@citrix.com> Date: Thu, 6 Aug 2020 19:14:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , "xen-devel@lists.xenproject.org" , Boris Ostrovsky Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 06/08/2020 15:15, Trammell Hudson wrote: > On Thursday, August 6, 2020 2:04 PM, Jan Beulich wrote: > >> On 06.08.2020 13:44, Trammell Hudson wrote: >> >>> On Thursday, August 6, 2020 9:57 AM, Jan Beulich jbeulich@suse.com wrote: >>>> Also, considering kernel and initrd are embedded, is there really a >>>> strict need for a config file? It would seem to me that you could >>>> boot the system fine without. >>> The config file is still necessary for Xen options (console, etc) as >>> well as the kernel command line. >> But command line options are optional. Yes, you need a config file if >> you want to pass any options. But you may be able to get away without >> command line options, and hence without config file. > My concern is that if there is no config file embedded in the unified > image, then the logic for retrieving the untrustworthy file from disk > kicks in. However, it is not a change from the status-quo, so I've > reverted the behavior (as part of also fixing the shim logic). > > I also added code to load the ucode section from the unified image > if it is present, which required touching the arm tree as well to add > an additional parameter to efi_arch_cfg_file_late(). It also > appears that in the event of the error path that the ucode will > never be freed. Probably not a big deal, unless you're launching > a failing Xen from the EFI shell over and over. For SecureBoot, it is important that nothing which is signed can be tricked into running unsigned code. That includes configuration such as xen.cfg or the command line.  Consuming these from unsigned sources is ok, so long as we can guarantee that the parsing is robust (see boothole for how this goes wrong), and the effects are controlled. I can't think of a Xen example offhand, but consider Linux's "unsafe_fsgsbase" command line option which was inserted for a period of time which deliberately opened up a privilege escalation vulnerability for the purpose of testing the FSGSBASE series carefully. I suppose the closest which Xen has is probably "ats" (but you've lost all security by using PCI Passthrough anyway...), but there are also problems with things like "flask=disabled", "hardware_domain", the various IVRS/DMAR fixup options. In the absence of a full audit of all our command line arguments, and extra vigilance reviewing code coming in, the safer alternative is to prohibit use of the command line, and only accept it in its Kconfig embedded form for now. Beyond that, things like LIVEPATCH and KEXEC need compiling out, until they can be taught to verify signatures. Beyond that, things like the GDB serial stub probably need a way of being able to be compiled out, and then being compiled out.  (This is definitely not an exhaustive list.) Xen's secureboot requirements also extend to the dom0 kernel, due to the responsibility-sharing which currently exists.  For a Linux dom0, Xen must ensure that lockdown mode is forced on (/dev/mem in dom0 still has a lot of system level power).  At a minimum, this involves extending lockdown mode to prohibit the use of /{dev/proc}/xen/privcmd, which is still a trivial privilege escalation hole in PV Linux that noone seems to want to admit to and fix. I think it is great that work is being started in this direction, but there is a huge quantity of work to do before a downstream could plausibly put together a Xen system which honours the intent of SecureBoot. I know Safeboot has different goals/rules here, but whatever we put together called "Secure Boot support" will have to be compatible with Microsoft's model for it to be useful in the general case. I think it might be worth having a CONFIG_SECURE_BOOT, selectable initially only under CONFIG_EXPERT, and use it to force off various other aspects of functionality, along with a list of known issues which can be chipped away at before it can be declared supported. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Aug 06 19:17:19 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 19:17:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3lNt-0006PH-86; Thu, 06 Aug 2020 19:17:01 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3lNs-0006PC-12 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 19:17:00 +0000 X-Inumbo-ID: 8cc625d6-1cb7-4673-9c0d-6780bb4433a5 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8cc625d6-1cb7-4673-9c0d-6780bb4433a5; Thu, 06 Aug 2020 19:16:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596741418; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=FEUdhmjUy/NnCsRpt6oD9B36F3Nekf8D3Ivt330Jyik=; b=HW7gMjsJO3htpLgYC0WtuiKdeVvA6E8FMEo5xhLUKMG0iBXfLrQoODDm rOp5LxK4V+FFlPMrXPOVljSUkyT7Sg9F/VNyGHDarGwBZdUuhlH5QJggp xjEVaqi0BevWSVETQwMiIgYRx3s2ydFz6mazL72GHkhoi2VhQKoxUquzG 8=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 1zR/2PDKAaqlrZNSqAWmRQn4vfqXx2M7qvWNZGpWj/h5L092BBCRMFy4QEqn82cByKTEnTJcP1 Q8Y64Zy0kqtw2VM5psYdNGmJxJFobVDrM3kaoPTLY4dHAvD6cxbaymZugsUsIBtBrQVpfzlfh8 F2bKKx2OOPpJSw1YoM/2cClgMDk6EQHwXsSU3YTgJ1FPXnMPsQKhmA+X2gn/kp8N7eRM2mFPyh +RRP6NsdPTZ23RHkF9G5os8DNHkwmLJL/a5GdxrMBTr0cxUSnnIqKOjwDZBZf6cLAMex4OAjH/ ZvI= X-SBRS: 3.7 X-MesageID: 24346601 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,441,1589256000"; d="scan'208";a="24346601" Subject: Re: [PATCH 2/3] x86: don't maintain compat M2P when !PV32 To: "xen-devel@lists.xenproject.org" References: <4575f42b-a347-b34e-0032-e04668106a9b@suse.com> From: Andrew Cooper Message-ID: <52b4f80f-9967-fae9-ce85-c69bf3b6e22d@citrix.com> Date: Thu, 6 Aug 2020 20:16:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <4575f42b-a347-b34e-0032-e04668106a9b@suse.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 06/08/2020 10:28, Jan Beulich wrote: > Note that opt_pv32's declaration / #define need to be moved due to other > header dependencies; in particular can asm-x86/mm.h not include > asm-x86/pv/domain.h. While I do appreciate that our headers are a complete tangle, I can't help but feel that this is making the problem worse. mm.h isn't a better place for opt_pv32 to live.  config.h perhaps, seeing as its effects are wider than both the domain support itself, or the memory management support ? > While touching their definitions anyway, also adjust section placement > of m2p_compat_vstart and compat_idle_pg_table_l2. Similarly, while > putting init_xen_pae_l2_slots() inside #ifdef, also move it to a PV-only > source file. > > Suggested-by: Andrew Cooper > Signed-off-by: Jan Beulich So interestingly, this is done out of the order which I was expecting to do things.  Its not a problem, but I'd like to double check that we aren't creating future problems. The goal of this suggestion was actually for PV-Shim, to have only the regular or compat M2P, as they're fairly large structures and adversely affect VM density. This of course requires the kernel elf file to be parsed earlier during boot, but that isn't a problem.  (It also allows for a PV/PVH dom0 usability fix, whereby the Xen command line has to match the ELF image provided, rather than auto-selecting the default when only one option is available.) The other aspect would be to teach Xen to run on only the compat M2P, which is fine for any shim smaller than 16T.  (Honestly, if it weren't an ABI with guests, Shim ought to run exclusively on the compat M2P to reduce the memory overhead.) Then during boot, the Shim path would chose to construct only the regular or compat M2P, based on bitness of the provided kernel. > --- > An alternative place for opt_pv32.h would seem to be asm-x86/config.h. Oh - yes please.  I think that would be better overall. > > --- a/xen/arch/x86/domain.c > +++ b/xen/arch/x86/domain.c > @@ -597,8 +597,10 @@ int arch_domain_create(struct domain *d, > } > d->arch.emulation_flags = emflags; > > +#ifdef CONFIG_PV32 > HYPERVISOR_COMPAT_VIRT_START(d) = > is_pv_domain(d) ? __HYPERVISOR_COMPAT_VIRT_START : ~0u; > +#endif Can we drop HYPERVISOR_COMPAT_VIRT_START() ? Its use here as an lvalue in particular makes logic especually hard to follow, but all it is actually doing is wrapping the shorter d->arch.hv_compat_vstart In particular, it would remove the need to conditionally stub HYPERVISOR_COMPAT_VIRT_START() later. > --- a/xen/arch/x86/x86_64/mm.c > +++ b/xen/arch/x86/x86_64/mm.c > @@ -315,10 +318,10 @@ static void destroy_m2p_mapping(struct m > */ > static int setup_compat_m2p_table(struct mem_hotadd_info *info) > { > + int err = 0; > unsigned long i, smap, emap, epfn = info->epfn; > mfn_t mfn; > unsigned int n; > - int err = 0; Remnants of an earlier change? > --- a/xen/include/asm-x86/mm.h > +++ b/xen/include/asm-x86/mm.h > @@ -42,8 +42,12 @@ > #define _PGT_validated PG_shift(6) > #define PGT_validated PG_mask(1, 6) > /* PAE only: is this an L2 page directory containing Xen-private mappings? */ > +#ifdef CONFIG_PV32 > #define _PGT_pae_xen_l2 PG_shift(7) > #define PGT_pae_xen_l2 PG_mask(1, 7) > +#else > +#define PGT_pae_xen_l2 0 > +#endif Hmm - this is going to irritate Coverity and Clang some more.  I still need to figure out an effective way to make Coverity not object to this type of short circuiting like this. I've looked through the users and I think that they're all safe.  I do however wonder whether is_guest_l2_slot() can be simplified and have its is_pv_32bit_domain() clause dropped, seeing as it is expensive with its lfences, and the logic ought to only care about PGT_pae_xen_l2 vs PGT_l2_page_table. > /* Has this page been *partially* validated for use as its current type? */ > #define _PGT_partial PG_shift(8) > #define PGT_partial PG_mask(1, 8) > @@ -494,15 +498,39 @@ extern paddr_t mem_hotplug; > #define SHARED_M2P_ENTRY (~0UL - 1UL) > #define SHARED_M2P(_e) ((_e) == SHARED_M2P_ENTRY) > > -#define compat_machine_to_phys_mapping ((unsigned int *)RDWR_COMPAT_MPT_VIRT_START) > +#ifdef CONFIG_PV32 > + > +extern int8_t opt_pv32; > + > +# define compat_machine_to_phys_mapping ((unsigned int *)RDWR_COMPAT_MPT_VIRT_START) > + > +# define set_compat_m2p(mfn, entry) \ > + ((void)(!opt_pv32 || \ > + (mfn) >= (RDWR_COMPAT_MPT_VIRT_END - RDWR_COMPAT_MPT_VIRT_START) / 4 || \ > + (compat_machine_to_phys_mapping[mfn] = (entry)))) I know this is extracting previous logic, but "entry" would probably be better if it were named "val" or similar. However, see my reply to patch 3 which I think will simplify this substantially. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Aug 06 19:34:28 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 19:34:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3leb-00085Y-PV; Thu, 06 Aug 2020 19:34:17 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3lea-000853-L6 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 19:34:16 +0000 X-Inumbo-ID: 2390428a-3ce1-4dbd-b01f-41ceb39128dd Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2390428a-3ce1-4dbd-b01f-41ceb39128dd; Thu, 06 Aug 2020 19:34:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=+ZoRx6PnZqxpFfDr1ZviFdY3g0stYOOjKngOhiM72ws=; b=xAnIum2GVCpO9JA+l+I8IXLJF 5lGPMY/NGKLUAk2F1U1XdRNtXPsABuo3bEAIsQ9KaQiYuXctGI1ORz4AK/359jl5iaj2BtUZu8ITI U7Ru/BeFBaY+xqaHVLrXpB7lta5nuHceyHOBhIrajEu3FqKLr1Zj2hvoEInTkOFSaAU98=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3leS-0003gC-KR; Thu, 06 Aug 2020 19:34:08 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k3leS-0002CB-5r; Thu, 06 Aug 2020 19:34:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k3leS-0002T9-3z; Thu, 06 Aug 2020 19:34:08 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 152492: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-boot:fail:regression linux-linus:test-amd64-i386-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-i386-libvirt:xen-boot:fail:regression linux-linus:test-amd64-i386-examine:reboot:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-boot:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-boot:fail:regression linux-linus:test-amd64-i386-xl:xen-boot:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-boot:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:build-arm64-pvops:kernel-build:fail:regression linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking X-Osstest-Versions-This: linux=2324d50d051ec0f14a548e78554fb02513d6dcef X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Thu, 06 Aug 2020 19:34:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152492 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/152492/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-boot/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-boot/dst_host fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-examine 8 reboot fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-boot/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-boot/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-boot fail REGR. vs. 152332 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 10 debian-hvm-install fail REGR. vs. 152332 build-arm64-pvops 6 kernel-build fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail like 152332 test-armhf-armhf-xl-rtds 16 guest-start/debian.repeat fail like 152332 test-armhf-armhf-libvirt 14 saverestore-support-check fail like 152332 test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail like 152332 test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass version targeted for testing: linux 2324d50d051ec0f14a548e78554fb02513d6dcef baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 5 days Failing since 152366 2020-08-01 20:49:34 Z 4 days 5 attempts Testing same since 152492 2020-08-05 12:44:47 Z 1 days 1 attempts ------------------------------------------------------------ 750 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 63192 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Aug 06 19:58:31 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 19:58:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3m1t-0001WX-UG; Thu, 06 Aug 2020 19:58:21 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3m1s-0001WS-6V for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 19:58:20 +0000 X-Inumbo-ID: ed4b60b1-2a44-496b-a533-c6f975ab0638 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ed4b60b1-2a44-496b-a533-c6f975ab0638; Thu, 06 Aug 2020 19:58:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ywgrq3ktyYRFAuY+QyyxomchdSs4yG2EIgi/A4FDoAs=; b=ImiNTu6WiQiNK/+I2yG8rfMoo pJkEw5mB83qoIjEvgrZ8IGn6cuUl/2UNd52BIa+w4GEWFNvsyq3KQFiJMTghHzn2mD3o5FXcdQqWn wAV4I0i9uMiF+ZnOcMMkliIFzuDQlu8ygkcraIQraIf6/zWgEL04nSoXx77I8aZr9LQio=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3m1p-0004Cs-H8; Thu, 06 Aug 2020 19:58:17 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k3m1o-0002ya-TW; Thu, 06 Aug 2020 19:58:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k3m1o-0001kO-Sq; Thu, 06 Aug 2020 19:58:16 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 152497: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-armhf-armhf-xl-rtds:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking X-Osstest-Versions-This: qemuu=e1d322c40524d2c544d1fcd37b267d106d16d328 X-Osstest-Versions-That: qemuu=fd3cd581f9dcd11286daacaa5272e721c65aece8 From: osstest service owner Date: Thu, 06 Aug 2020 19:58:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152497 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/152497/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 15 guest-stop fail blocked in 152480 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail like 152480 test-armhf-armhf-libvirt 14 saverestore-support-check fail like 152480 test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 152480 test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail like 152480 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail like 152480 test-amd64-i386-xl-pvshim 12 guest-start fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass version targeted for testing: qemuu e1d322c40524d2c544d1fcd37b267d106d16d328 baseline version: qemuu fd3cd581f9dcd11286daacaa5272e721c65aece8 Last test of basis 152480 2020-08-05 02:25:42 Z 1 days Testing same since 152497 2020-08-05 20:10:30 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Guoyi Tu Peter Maydell Thomas Huth Tuguoyi jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git fd3cd581f9..e1d322c405 e1d322c40524d2c544d1fcd37b267d106d16d328 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Thu Aug 06 20:33:00 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 20:33:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3mZ5-0004xe-Pp; Thu, 06 Aug 2020 20:32:39 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3mZ4-0004xZ-Nb for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 20:32:38 +0000 X-Inumbo-ID: 9ebcb23d-936c-4a6e-a579-d7c6782b22a3 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 9ebcb23d-936c-4a6e-a579-d7c6782b22a3; Thu, 06 Aug 2020 20:32:38 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BC2C120855; Thu, 6 Aug 2020 20:32:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596745957; bh=zfVa+e5Pv577pD3yrUmrJ2ITyvuhQKGJiFQlFwlLYzg=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=cFugBYn+7Ec6q/g1IQJRdQh94u6k6CKNcmsOPAISGMHsSk6Mj6Gd1tx+zHFVy4HrU 7jH/jaToOT/fVU8xtJxbiGUrx160OlkpR6+5qemKUd6saLO0sLdwNNbTnvSRFc8GEs o+6XPe5TBas1UI/K4AoPcUL2zfIdoXSO6KMwELSE= Date: Thu, 6 Aug 2020 13:32:36 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Jan Beulich Subject: Re: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common In-Reply-To: <51e30c1c-6b19-e646-fdc4-683b3197817a@suse.com> Message-ID: References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-2-git-send-email-olekstysh@gmail.com> <000c01d66a33$2bd56510$83802f30$@xen.org> <9f83a7ed-ca97-449f-c7b9-a1140644abe9@gmail.com> <2ab4c567-8efa-1b9d-ab00-4ea7e1ab323e@suse.com> <51e30c1c-6b19-e646-fdc4-683b3197817a@suse.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: 'Kevin Tian' , Stefano Stabellini , Julien Grall , 'Wei Liu' , paul@xen.org, 'Andrew Cooper' , 'Ian Jackson' , 'George Dunlap' , 'Tim Deegan' , Oleksandr , 'Oleksandr Tyshchenko' , 'Julien Grall' , 'Jun Nakajima' , xen-devel@lists.xenproject.org, =?UTF-8?Q?'Roger_Pau_Monn=C3=A9'?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Thu, 6 Aug 2020, Jan Beulich wrote: > On 06.08.2020 02:37, Stefano Stabellini wrote: > > What should do_trap_stage2_abort_guest do on IO_RETRY? Simply return > > early and let the scheduler do its job? Something like: > > > > enum io_state state = try_handle_mmio(regs, hsr, gpa); > > > > switch ( state ) > > { > > case IO_ABORT: > > goto inject_abt; > > case IO_HANDLED: > > advance_pc(regs, hsr); > > return; > > case IO_RETRY: > > /* finish later */ > > return; > > case IO_UNHANDLED: > > /* IO unhandled, try another way to handle it. */ > > break; > > default: > > ASSERT_UNREACHABLE(); > > } > > > > Then, xen/arch/arm/ioreq.c:handle_mmio() gets called by > > handle_hvm_io_completion() after QEMU completes the emulation. Today, > > handle_mmio just sets the user register with the read value. > > > > But it would be better if it called again the original function > > do_trap_stage2_abort_guest to actually retry the original operation. > > This time do_trap_stage2_abort_guest calls try_handle_mmio() and gets > > IO_HANDLED instead of IO_RETRY, thus, it will advance_pc (the program > > counter) completing the handling of this instruction. > > > > The user register with the read value could be set by try_handle_mmio if > > try_fwd_ioserv returns IO_HANDLED instead of IO_RETRY. > > > > Is that how the state machine is expected to work? > > I think so. Just because it has taken us quite some time (years) on > the x86 side to get reasonably close to how hardware would behave > (I think we're still not fully there): The re-execution path needs > to make sure it observes exactly the same machine state as the > original path did. In particular changes to memory (by another vCPU) > must not be observed. Thanks for the heads up. I think I understand how it is supposed to work now. I hope Oleksandr is on the same page. From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:49:24 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 23:49:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3pd9-00049C-65; Thu, 06 Aug 2020 23:49:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3pd8-000497-5t for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 23:49:02 +0000 X-Inumbo-ID: 82206bd8-f719-4ff3-bfe6-c9c0a0a50d8b Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 82206bd8-f719-4ff3-bfe6-c9c0a0a50d8b; Thu, 06 Aug 2020 23:49:01 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0FAE121744; Thu, 6 Aug 2020 23:49:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596757740; bh=4hvvMj7TSIsp1jNhqK0Abfhy7xqbt3iT7SqZXRwohxw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=PAaDKCmKriLeayD+ElW100QFbbE4pS9uXyxIlHallW5QQV3dvj+WePpQp5UneLa5v DTcMJ1d8qGE8st921Cyu8NCoFOgGnMXdcovNzg1luzZ83o5k7Ikzf9aQiNR4adSAZ5 ZnCaxTIhIpYL+seKG5KriH3luRjrCKnXq9h33awQ= Date: Thu, 6 Aug 2020 16:48:59 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Julien Grall Subject: Re: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common In-Reply-To: <1afb9ffd-088c-ef4e-131a-0f2b62142405@xen.org> Message-ID: References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-2-git-send-email-olekstysh@gmail.com> <000c01d66a33$2bd56510$83802f30$@xen.org> <9f83a7ed-ca97-449f-c7b9-a1140644abe9@gmail.com> <5df97055-67f9-16cc-a274-864672d67164@xen.org> <1afb9ffd-088c-ef4e-131a-0f2b62142405@xen.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1343060914-1596747559=:16004" Content-ID: X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: 'Kevin Tian' , Stefano Stabellini , 'Jun Nakajima' , 'Wei Liu' , paul@xen.org, 'Andrew Cooper' , 'Ian Jackson' , 'George Dunlap' , 'Tim Deegan' , Oleksandr , 'Oleksandr Tyshchenko' , 'Julien Grall' , 'Jan Beulich' , xen-devel@lists.xenproject.org, =?UTF-8?Q?'Roger_Pau_Monn=C3=A9'?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1343060914-1596747559=:16004 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Thu, 6 Aug 2020, Julien Grall wrote: > On 06/08/2020 01:37, Stefano Stabellini wrote: > > On Wed, 5 Aug 2020, Julien Grall wrote: > > > On 04/08/2020 20:11, Stefano Stabellini wrote: > > > > On Tue, 4 Aug 2020, Julien Grall wrote: > > > > > On 04/08/2020 12:10, Oleksandr wrote: > > > > > > On 04.08.20 10:45, Paul Durrant wrote: > > > > > > > > +static inline bool hvm_ioreq_needs_completion(const ioreq_t > > > > > > > > *ioreq) > > > > > > > > +{ > > > > > > > > +    return ioreq->state == STATE_IOREQ_READY && > > > > > > > > +           !ioreq->data_is_ptr && > > > > > > > > +           (ioreq->type != IOREQ_TYPE_PIO || ioreq->dir != > > > > > > > > IOREQ_WRITE); > > > > > > > > +} > > > > > > > I don't think having this in common code is correct. The short-cut > > > > > > > of > > > > > > > not > > > > > > > completing PIO reads seems somewhat x86 specific. > > > > > > > > > > Hmmm, looking at the code, I think it doesn't wait for PIO writes to > > > > > complete > > > > > (not read). Did I miss anything? > > > > > > > > > > > Does ARM even > > > > > > > have the concept of PIO? > > > > > > > > > > > > I am not 100% sure here, but it seems that doesn't have. > > > > > > > > > > Technically, the PIOs exist on Arm, however they are accessed the same > > > > > way > > > > > as > > > > > MMIO and will have a dedicated area defined by the HW. > > > > > > > > > > AFAICT, on Arm64, they are only used for PCI IO Bar. > > > > > > > > > > Now the question is whether we want to expose them to the Device > > > > > Emulator > > > > > as > > > > > PIO or MMIO access. From a generic PoV, a DM shouldn't have to care > > > > > about > > > > > the > > > > > architecture used. It should just be able to request a given IOport > > > > > region. > > > > > > > > > > So it may make sense to differentiate them in the common ioreq code as > > > > > well. > > > > > > > > > > I had a quick look at QEMU and wasn't able to tell if PIOs and MMIOs > > > > > address > > > > > space are different on Arm as well. Paul, Stefano, do you know what > > > > > they > > > > > are > > > > > doing? > > > > > > > > On the QEMU side, it looks like PIO (address_space_io) is used in > > > > connection with the emulation of the "in" or "out" instructions, see > > > > ioport.c:cpu_inb for instance. Some parts of PCI on QEMU emulate PIO > > > > space regardless of the architecture, such as > > > > hw/pci/pci_bridge.c:pci_bridge_initfn. > > > > > > > > However, because there is no "in" and "out" on ARM, I don't think > > > > address_space_io can be accessed. Specifically, there is no equivalent > > > > for target/i386/misc_helper.c:helper_inb on ARM. > > > > > > So how PCI I/O BAR are accessed? Surely, they could be used on Arm, right? > > > > PIO is also memory mapped on ARM and it seems to have its own MMIO > > address window. > This part is already well-understood :). However, this only tell us how an OS > is accessing a PIO. > > What I am trying to figure out is how the hardware (or QEMU) is meant to work. > > From my understanding, the MMIO access will be received by the hostbridge and > then forwarded to the appropriate PCI device. The two questions I am trying to > answer is: How the I/O BARs are configured? Will it contain an MMIO address or > an offset? > > If the answer is the latter, then we will need PIO because a DM will never see > the MMIO address (the hostbridge will be emulated in Xen). Now I understand the question :-) This is the way I understand it works. Let's say that the PIO aperture is 0x1000-0x2000 which is aliased to 0x3eff0000-0x3eff1000. 0x1000-0x2000 are addresses that cannot be accessed directly. 0x3eff0000-0x3eff1000 is the range that works. A PCI device PIO BAR will have an address in the 0x1000-0x2000 range, for instance 0x1100. However, when the operating system access 0x1100, it will issue a read to 0x3eff0100. Xen will trap the read to 0x3eff0100 and send it to QEMU. QEMU has to know that 0x3eff0000-0x3eff1000 is the alias to the PIO aperture and that 0x3eff0100 correspond to PCI device foobar. Similarly, QEMU has also to know the address range of the MMIO aperture and its remappings, if any (it is possible to have address remapping for MMIO addresses too.) I think today this information is "built-in" QEMU, not configurable. It works fine because *I think* the PCI aperture is pretty much the same on x86 boards, at least the one supported by QEMU for Xen. On ARM, I think we should explicitly declare the PCI MMIO aperture and its alias/address-remapping. When we do that, we can also declare the PIO aperture and its alias/address-remapping. --8323329-1343060914-1596747559=:16004-- From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:49:24 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 23:49:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3pdQ-0004Aq-RR; Thu, 06 Aug 2020 23:49:20 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3pdO-0004Ac-Qe for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 23:49:18 +0000 X-Inumbo-ID: 61072eba-8820-4db3-ad4c-8daa1294f427 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 61072eba-8820-4db3-ad4c-8daa1294f427; Thu, 06 Aug 2020 23:49:17 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 13A21221E4; Thu, 6 Aug 2020 23:49:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596757756; bh=GJ1IzTvNiAwJVw3MTZtu3L7Y5YULuS2PfxzMrgtr8ik=; h=Date:From:To:cc:Subject:From; b=VZDthHCks1RoaGQWJRIwAeOo9F283PnY7fQzcvvNEQ+4s5QuGlUmVkD1DdMFmzR9Q KXJYESRiHiT9NOtzamMqXTtC60wLgebAMUGYcAbdjR3W0fJ4wK8cSNQSwE+wN9dNSh YsuW6nkuYIMhzCvRgNc5TjYD7wLQinY0NlFNN6as= Date: Thu, 6 Aug 2020 16:49:15 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: xen-devel@lists.xenproject.org Subject: [PATCH 00/14] kernel-doc: public/arch-arm.h Message-ID: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-542490146-1596757090=:16004" Content-ID: X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: sstabellini@kernel.org, julien@xen.org, wl@xen.org, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com, jbeulich@suse.com Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-542490146-1596757090=:16004 Content-Type: text/plain; CHARSET=US-ASCII Content-ID: Hi all, This patch series convert Xen in-code comments to the kernel-doc format: https://www.kernel.org/doc/html/latest/doc-guide/kernel-doc.html # WHAT WAS CONVERTED I started from the public/ header files as I thought they are the most important to generated documentation for. I didn't cover all files under xen/include/public/, but we don't have to boil the ocean in one go. For the header files I addressed, I did cover all in-code comments except for very few exceptions where the conversion to kernel-doc format wasn't easily doable without major changes to the comments/code. The conversion was done by hand (sigh!) but was mechanical, and only stylistic: I didn't change the content of the comments (only in a couple of places to make the English work right, e.g. when a comment has been split into two comments.) # THE KERNEL-DOC KEYWORDS USED I used the "struct" keyword for structures, i.e.: /** * struct foobar */ "struct" makes kernel-doc go and look at the following struct in the code, parses struct members comments, and generate a doc optimized to describe a struct. Note that in these cases the struct needs to follow immediately the comment. Thus, I had to move an #define between the comment and the struct in a few places. Also note that kernel-doc supports nested structs but due to a quirk, comments for nested struct members cannot be on a single line. They have to be: struct foo { struct { /** * @u.bar: foobar */ bar; } u; } Otherwise for normal struct the single line comment works fine: struct foo { /** @bar: foobar */ bar; } I used the "DOC" keyword otherwise. "DOC" is freeform, not particularly tied to anything following (functions, enums, etc.) I kept a black line between "DOC" and the following comment if multiline and no blank line if it is single line. /** * DOC: doc1 * single line comment */ /** * DOC: doc2 * * this is * multiline */ DOC doesn't generate any cross-documents links but it is still a great place to start as it makes the in-code comments immediately available as documents. Linking and references can be added later. # HOW TO TEST IT Simply run kernel-doc on a header file, for instance: ../linux/scripts/kernel-doc xen/include/public/event_channel.h > /tmp/doc.rst You can inspect the rst file and also generate a html file out of it with sphinx: sphinx-quickstart sphinx-build . /path/to/out I am attaching two example output html files together with the static CSS and images to render them correctly. Note that of course I haven't worked on the CSS at all, clearly the style can be vastly improved, but I wanted to give you an idea of how readable they actually are even like this. Cheers, Stefano The following changes since commit 81fd0d3ca4b2cd309403c6e8da662c325dd35750: x86/hvm: simplify 'mmio_direct' check in epte_get_entry_emt() (2020-07-31 17:43:31 +0200) are available in the Git repository at: http://xenbits.xenproject.org/git-http/people/sstabellini/xen-unstable.git hyp-docs-1 for you to fetch changes up to abbd21dfa0ff14a7eb5faa57aaf3db24f83a149f: kernel-doc: public/hvm/params.h (2020-08-06 16:27:22 -0700) ---------------------------------------------------------------- Stefano Stabellini (14): kernel-doc: public/arch-arm.h kernel-doc: public/hvm/hvm_op.h kernel-doc: public/device_tree_defs.h kernel-doc: public/event_channel.h kernel-doc: public/features.h kernel-doc: public/grant_table.h kernel-doc: public/hypfs.h kernel-doc: public/memory.h kernel-doc: public/sched.h kernel-doc: public/vcpu.h kernel-doc: public/version.h kernel-doc: public/xen.h kernel-doc: public/elfnote.h kernel-doc: public/hvm/params.h xen/include/public/arch-arm.h | 43 ++- xen/include/public/device_tree_defs.h | 24 +- xen/include/public/elfnote.h | 109 +++++-- xen/include/public/event_channel.h | 188 +++++++---- xen/include/public/features.h | 78 +++-- xen/include/public/grant_table.h | 443 +++++++++++++++----------- xen/include/public/hvm/hvm_op.h | 20 +- xen/include/public/hvm/params.h | 158 ++++++++-- xen/include/public/hypfs.h | 72 +++-- xen/include/public/memory.h | 232 +++++++++----- xen/include/public/sched.h | 129 +++++--- xen/include/public/vcpu.h | 180 ++++++++--- xen/include/public/version.h | 74 ++++- xen/include/public/xen.h | 567 ++++++++++++++++++++++------------ 14 files changed, 1564 insertions(+), 753 deletions(-) --8323329-542490146-1596757090=:16004 Content-Type: application/gzip; NAME=html.tar.gz Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: ATTACHMENT; FILENAME=html.tar.gz H4sIAFqVLF8AA+w9TW8jyXXjReAserHwXhJvcnGZE8xIY35qZqRdfdDRSBwN E33QEjW7RmC0m91Fsnb6a7q6RdG7C08MXwIkiA+xsQvEgA8+5ORbcgrijePk ECCXIAGSIKf5BQE2QfaSj/eqqpvdJKUhJWpmZIvADMWuqvdevar3VVX9ih5R N+TFbujY1y7qU4bP4uId/K4s3S2nv+Fzd2nx7sK1yu2lyu0KfMrwvHJncbFy jZQvjKLUJ+KhERByjcN3i9o2c9nYes8qv6QfbfXLm3sbza83agTnAGkc3tuu b5BcoVR65/ZGqbTZ3CTvPmjubJNKsUyageFyFjLPNexSqbab0wjJdcPQXy6V er1esXe76AWdUnO/dIzQKthc/VkIU22LVmjlqpq2KnAeO7bL18bAqbz99tuy OVQmZLVLDQv/gD8dGhoEWxTo44gdreU2PDeEqVxo9n2aI6b8tZYL6XFYQggr xOwaAafhWhS2C2/lSElBCllo0+oNO1xxPSJ+3OiEK+TG9bcWKgsrxCDE8szI AWgGEr9akg1kY5gOj0hA7bUcD/s25V1KwxzpBrS9ltM5tjBLhm20DB7SoGhy niMhEKjoEr9LU4Dy+x1HyOupkLgZMD9MF79nHBnyaU7WIeQIZj2M/OFObbe5 3qzv7ep7Dfw6IGvkfVWHkMP9bX1/b6+5jD9uFks380nRw9r+AdQXJeRmqmBj b3t7vXFQ0+u7m7V3l0nbsDkdFN+vb9f0g8P79+tQdlNonlTjB+sH+sHe4f5G DQCHQZRqKB9v13d/N9U8PA5vqhofrsjul2RPJ2EG4YE54O57jyMa9Ivv8Vz1 7EAi16IBN72AnhMQzLrQ82w+DsxgrjBAd5yT83YtV5e/5KTpUFeUChaPnWfU CMxu0vhA/ZStZWGmrTbhLDVBp3rOKXNUiwXYNRwoPWK053tBmBLbHrPC7ppF j5hJC+JHnoDmDZlhF7hpALnl4tt54hjHzImcwSOBAMGXYl2x2vKsvkAqu2+x I2LaBgeFE8t1IhPjCnuB4fs0SOpkayHw0RqjdXIk8JDHjsHcTEXJDL+6ysPA czvVGtpjstE1XJfaHIZdPl4t+VUNqsliUxUTI6Ak7FIC+oWZxA+YAyw6ovCX d8QsapFWn7xLXdL2AkKxqeZ6IWszU6gyXiTrrnxOGBeAsLJQqMBPeOq1Qf+B 2rR6gEljMDhBEPlhkTS7tE8o51AJhsTuExhxoMVzgRYm2jEXkDoCT16AlvhF CYChXODkrAPmwJaUDiwEczvQBsoRWDvwHFImoQcmKObDbrobgg0BNSl0XQAy SCdCBEfMIIZLIh+mhy3hQAfz0BFLtAUsvS702Ii5YAQBwOBkDuxEKIkQHZov kvtRAD+CLAMFZsfgjwBvBKyw4wbYN9MGEYICowODTuawNQWegEYT1HHigJzA WFLzkWgGPI8osi6GYbSBUdCxAnWNlo3kSB5a1AYqgz6yhLo8AhrAdDkMhsMi Gfrmi9mJkyXehH63EvqBb3GvDdK2jc6KHALGtdSMAJQW44qcZEIAI1wrhhch GQlpmgG6gJks7GPXTBqEyA0PBEZRAb+ww3LEHtEAJnbxlOkeUB8mDzxWc0bM rNDsuvot0mbUthCiBmITmSHhXRwBHeeioFA9PjL9SDxUiCw7llVUVzl8AiNo reXMooIN88cz9chteaDfoYICtGp6Fk00BuUmKrRcdVyj1RLWra4acXVUUDRA fRrrz+snoIsVdIOCQAkFDNwVY2PRttCKHiiVn/3FaskARWGFSL9VRfY9bG48 2N1rDFOCfS5hlZJloxc2UD+bCcAh1ZPSZ13W6drwLywAeiOyQX+OLYbHMFQA 2jdcNGDiC/+PawLRko+qkAyXjufjmLp+rvq+KkB1OgTGgglo6SdigeJx1AHM lTPDDKjjhVQ/E2jVa7SIJyPA0meBHi74cFBSEiNTgmETU0F8DWbBDnVa4MQM TwE7bRtB2XEpKdWsFKgyYjNQDgZ47lkyAprhuJKKZNbWd4lvBCBF0FjM0bNh GOX/BSFKj8Mwir3D5ggOIXEZgZOO3ajE+dV1nPdGSEEfIxrUlNAhVJ8YrcCf IlBBveYYwSNigII0TeqHiWqWtbUW2ju3w6UFTIEYcAkhgTcANcClU9gAnCLA IlmcGuIMaBiBsrYQL5ZhIwEmJj/u4u5es3Yw1LkWAH70OALsUrdUV71kdgHH WuDNcOb4tlDGNqvWpVVEOw4mEUiLXPB2jphNO2hs0IineSIsK5iizb2d+qZ+ UNu+D1QBGAFrtOfAv362el70vYectD3Pbxlgo8E5dakpHScFreTZsfyslrJ9 eqZJwVHRU8M0qVUZbjeVYRlBen7bMkrPJTMvox2YtYW5cGugEExiFM6IARWB PRGCl9bqPDebMGY0LgjT6KjM2gZtgLaTWglQp4REBUzKNQflGfYodRMljYpT VQRboY0zNtln+RTTBiocYliIqtr92AKGXQMNk6Z8wcT2SSs0sH5ZizdKFJg6 7RRTN74XaYsnejTgfsbu1WGMDC4Dc5+CuVIgukiiHYB2xlCXySAJQi7iRUGW nZpPBf154CtGjASCwR60Fp3OkxNVL4DvGX2OQLmG6AWFQ0OlYCfkQigPIVsE 9XwjBFAuxmkQw+UzkdnTJx/zOJCe8wLCoxaHsBDDUYBrgVWeF2wElntoOfky mdtXkSsdxP8JFe0sDLUOIIJPVxr0eRUaY03R/pjxkLqmCJF7MBEAYIBG2RIG RcPVAipCeoPhOGI7CBA9jLuJQw2X5yVs4xEdtDeEQcc55VKKKyZzrA3V+vMX 4sa8TK7HEQseT+VzYIPpnQ2BZkZehqTgMroXkvKp/YoIhPv2wslWOQV2CoP/ TKimH12FraPWNs3t0wx6nlA3coisfmbbnh6FSxi83mNon8daIJD9h/X9rwkP AHgk1CDoYO5Tk7XRLmLXL0T/PmRBiJYOsMvVRFFXIgXT5dOggLgJmI6O7bUM u0gOqDRfgmIbTJAGZvGYusVuYpliIHJdFc0TNcyuaJEKO7cEQPGUJwHqwO2A hg83Godl0opCsZI6sI42WggtoAXp9OCq9pBelPyKMTXibihc0sLIxsB7cKEc D9DjYv2waxBI3mvoFAxoy9ZifAALu58dt9h+x6sO2BfXE51FABCuz8yC+dNa MP9MFsyfoQXzL60F8y/GgvkTWLBMgVnJVa8LnlNyr767qTdgkuv6O/Xtbf3g wfp+jVTOYfpw34Nf2b4xpmJC23cOa5Th/en2NT3yty6lATQgmpSGiMw1hozh xcQe68Tv9jkzFdbprIIKmwc2Zs+1MSrnURvsHhNGqpBakVXxqEDCFIIM/tmt oPpsupVTn51hxRSQzGqlFPFfRgMgCJ99BHMVa/zyef/qrIYs4Bei7c7uwIrD LfEKooYabPbuq2l7nE6qtkTlqXSWBH9+haUwXzJtpaieWlX94iuVKXckpton QKafIPGZ3WESb+UOhDG9Vy22crFcLpMSCmIKVXzbMAdr8/HyP543pNqcnK8H zfVmfEhkPk8MXAaWh5lc2kutoE585ofTyY/6YN2pRFQAP7+ESryXTEAl0Vfy +Tzl84CK7TIlmcrwpWTMy0plr4virITZtXwPZBR3WMYc9JhAkEBMIz6xKIna 0wmTRDADcVK4L5tAKbKnFqmLOBl3MWKaXvZJ6Xth6y11krpMyFSNYzMiPpUp G6e3XcnClI1xNSU5AH57ysZH6cZ3piXbZ4Oj53dTjacP3TKz7oVvP0WulMln icBoy1NEbLjpxUgQGUH64UnwsodgJ4f5cnTzApXFVFwcPew1FSdnsaZ9Frhn 2O09dS5dWj/pxR7rnRGKrPqcZAFm1utIGRx5sf2IHlOvy8yu9JuGV0zOQchk VJwHQXFIOQ4jGrX858I2RomcgjFT+xxYT9uHGXIwzoXntLMOQ77IGaKRIYd7 mWzRUMYfURBggCKfJ1GJ5zhg39X++iBGgXmqiVN1bhKk4D6GOgmeJxd6JD1z 3lxupgwWEoGosWfPJ9828VriRSmxPpkwIw7gtPQxOimvaXJAXHHNcpSC8x8a A3Uy3aExoX+mPjSGaGZ1aExQcMkiuhTlUwd1M/SpLsJ1f2m9iudg86fc1Zlq gUfonr7SBvIkTqIqedeLbPVuaH/onVdcXR06EjzTN3cadXVuafAapzylrKgR r74iuSntGapdY+ZQPIskXgR+xmkide5JODHirNaFo1u3bXW6OEGlcCD8Mh4+ VtoCt5Sk2sJf4r1nsHc4DNrQUvhgy2oue+Qd38yi8sB75mBYQPF1W2EFWTig G1+RFct8gpT5Wej/yMUXhSdV/rL2VJpfITi/2o9xXzKdH5P94hT+L4pqnkZv HgquD+0Dp3axCskxGJRGlD/1+j0xMrkA4jV1w/cDD1w6fG9TKCPWPkXXPlvs hCRPKnWi8lRCJ8GfX+YU5ksmcorqqSXu/MthL62oTbe2coYtYntoexhfGuKe yYTV67Gwm5LD5NjZpQvfuHLHpIMARtwdDxEYBr3oC8sv0t8EQLboi8ypkeQl Mfp5adX50LtiqVQaILQLBRuKbbJ+r46ax5TJVQRb0z1eW0uRIxDdr9/f07AV vmiGPkWRbMk0JQPnUbpJ8tQOsaIAPY2sBhAINUMkk+HxAR9x0t5mj6gtUpa0 cGORh7PwSVCj6Iprk+rIdJupVGUG2fk1ZpaOS6Y4s8RPrT8xjly8c7ICVZD1 TnuCBfppg1Sv3R5o/Re/bwVQ3zrlvWuYWnoLXPuZQ9Z946R9pN8b99xhuerS CQ2+8fLbtTFT6oKC/Oz8ejlWEs70cvnw1Luolfv0TBzGAUXoLp/B3ajLdHHs W1StIadsa/LqFlo9tJWjLgaYoBGQhtuPTZoIy8UbZHLFGkyb8uzB2IIpV6sG MlWVeAdePI5tHxkyruK9apnxTL7xHQfyCUqwL5px5DEMTnimhE8cS9Bj4LGl C29iUnOZbjOVucwgO7+5zNJxycxllviZm0sBdxJj+dJq55EezDj2WLfE6TdU JjIDLUDr0DhmTznZU5wODXVw/b2AhRPLUrrNlKdFU8hmcWo0Tcclk6Us8S9u sewM50KyVF8+KX0OOyTDPJr5MVi5zxyjEY6AMZTNRuoALZ3OVbJ67M/sj9TU 536XucecWbRlBHECWNc4Yh0RrudA4TCjYGNWcZkYlqQKx6ebzYBM8s6mawTU losBOMbd29V9/E0t0vR8ZsLMgEfaamRXZS5fVD9S16QyBVc30/muiXdEA8zQ K9SJalmC7zh8j+zBVERCUEvK5MEt7zhHRJpgGHvGfdvoL4Nj5NKYGSoBsczt fbv6tYiBayYfSkpF/zGPbMIAlaNYpm0ZylIMk6LrWZj4OJvSt7rKXD9KZ13O qczDjzFf8MgAZuvzqOUwaCHSs67ltrzRNunqXWZZ1I0RiBQ2+iPa73mBxRMg fTpI131qe/AwjaRVrGCTVM4lZM2A+6fn/f6tuZvXk3G5OV8Ez7M3V55H3ZJK LT359JbpbXH6DWqk/0xVbXvgTQ8SJN8wPb+/slBeKOeJUVQP1dcH6rvh9Wgg U7wmc1QliJdCUABtIpLE56oH4gGpFBeLSzhLYzSG469kW3No3mFhN2oVTc8p QXCDi/VdGg6StOeq6/GfpFxcKr6VgjhEYwJa514UmJSXKsUAnPsQJlhKeYhs 2a4n8yLlqg10PGSDBLTim/hb/Y8PZerqVZG/vnox+f/b1AgjiFIu8gaI0+9/ qCwsLiX3PyzcuVu5Vq7crSwtXt3/8Dw+V/c/XN3/cHX/w9X9D1f3P5xQ+Jzv f3i3tqvXtu/jDqd+v7bePNwf2emUKRsxFZU4EmrLSwdiQ55Kps8jH9nK1XUN uFqJW3StvgYhFI+vNxiHUewIpgsODhuNvf1mbTOpgiseeI5BvC0vr3qIL5GI aRHDy8mcwUmHQYBF8AYEsRfpRSIM054++dPEibrOrMpIROi1bIqXSJg5EVcw ayGHLEIi9CRENKpPn/wQQjraZsfz0EUMENX1AE+ffPTB0ycfC90PMQNIZlGr 46UWMYlAcoAWJFAZI5F+eQkBrqq0I1fmh0xeS053TYuzePmY0MCK754AnF/O 4EzfWkHVga72M9grclxzauUlankSWIu7bnlOmewcHjTFtjUV8AbjzrjaZm2h 3y12s7FBfniNO4bWg0gY03TquCamiz9Hbx4BrgGifAqN5VF5zhgzZ4oXBwAO LcCghdQMxXE0BCjhidybGuY1i3zLEGygjkhlZgHvobpoPJoLYoRGS0X3XjBT SjkVlpUMwGspwsnZCTei0NOF7yMCcR2T4DiGfzLVqirOunRW3UEWVphfPqeR 5RXihDo42wzLAumHjviGSTWVhI10PdXIMcwuvgqYqSZUgkzfmlym0QWFDfE+ 94IiqbtiXVFzcBHnFHZCCxGkIz2F0Cth1t1CjDHVIa6Jo6eqOioguQorcsQO zjGcyEtQaIo2HUnSpaBOMAFQyiPXlYnxyQAMET2bo8VOMU+O31ok4khDeTQB U0yBb4CUdGDkdaPlHVH9Tqd1lvkXH/MUOBvrNckHOaG8gFGuQajh9cidrXvq 7Cgmx5I6IRL37eBRFqY0zvgZdmIfHCfS/VCX01kXt6kE0BWxB5ftCVC3TDY9 YVQAN14OhBMqNiyihzs7h3qjqR82NtdBkTVAddX2H9b09U05k3Bj66snUYKL ww51dFD2YM3OjP79je3a+n5+Y6/x9Q/1xvpWbQLUHTeEaacDn3RwwJgdb3SO H8qt3WZz/d5eQ9TvAKtDHawNUON6gRybWOUmiSrgZ/pKG01gERPdD8X1PidP 8+6RoyPxmPpXPxJT4ky8efBwh8RwiIQj/LGTxwMQc6MNk+LIxG3S8VhVIUzi Dq6hdh1xoBmaIQvAZmEqS0B9GhJ8PWmU2xI6vt2cvkkIZjh2RN6ZdBJQtG8j 8BKNIs5zoclEQiWDqHWieFDHC/q65+tHLiqZVIMh+GILV5oGLvyondrOfdlK pPZWR8COVNJR8Rx9DIkBFN6JM2B9f0c/2NnY2DgFuxE4y+RBoq0Tb49AYwKN kwzm4FTj6vYg9ckoPqgXHesBt3w9cvFuroCZ43DCCJUaDx8sk1gw1jcadbJ/ sNmIh0zNf9wcd/uxtSmSPTwG12PAJqycOE6pnOs2LviRys69PI5W4pPB6Asc 8vWG+KwtcrG+XmhsaLwPkbXD1bH92DuLtaWH5/Wg/zyyBZqs17V1WDto6nsH IuwAx1zmTAefVLADfUrl417tB1ztB1ztBzxjel/tB1zG/YB4zWY20MZ/cJV/ aenuCev/4pPc/1y+I+5/rpQr18jdiyQq/vySr/8ny5Z+ASMBPPftu53Z4jh9 /6dcvr2wCOO/cHuhUlkqLy3C+C8uVRau9n+ex+cPGrtbr2u/qcGfr9cfbO7D 9xv479XPw/9f+vT/DPj6YR1iu+PPmW/+O/nE+8prrx60nszDf59svXHjnU81 8r9f+NuvPPjn/Ks///aTz7706sa/fufHb/6H5q688tPcQ/4bzb/56ht/9HfF 6zf+7a9+9N79N1/5vvnXnU9+7XutVz7Tiv9Q/Gh365t33v6i/fm//O6tz17/ +U+ffHbtjZuvPF79k/957dZ/f+HHv/6NT3/nzz41n3z0q3/8xf6P3vvJk//8 5Fe+/+RffvCH322/9o+vtcoH3/unjz/3g5/9+bf/6/f//gPsTb22u/mTe9/8 zgtk6CX7jN2kmjGO0+V/YeFuZVj/L969W7mS/+fx0YY/v80csYAQBfZcTtwr LTZy5lc0rXSLFApyqQpcd1zDL5z9Q26VNA0dGrXb2IYYrNA2HGZDUHCz40VQ 4tmWjBdu5slNh2GGL7zaGn/hUBAnhD+3KHh9zIBnD1hgdJjrkR3mml2PNERV TgPWXhng4OxbdJlUlvxj+RBXRzoBvqFeMD3bC5bxFfqQykL15DrMU/nAMQCZ u0zUz/9n70kDoyjSRTk0cVUUWVRWbRJwJjDTmcxMQg4C5uLhKgsSROVY7Mx0 Mg0z08N0DyGGKKKirKCCoiuL4rWuinnggYDoYz1Yj1VRdz0AuXF96qL48Eaf r746uqt7upMIrPt+OFFmurrqq6+++uo76viKbk/Hz22IeshsE9nKEW0YXr0q F8rCAVYjgxFCKXj2TgjgLwyCh0A9OkahuCrp5UJcbtQreMhFgcAgoyi3IEWL GRjjv2AQo0FzW/xHK740o51sYZaIBoLsj8mwtRMli8UYZowBaUDujYwIV4Ra qKlxJSrkVxdVh6tLLIiyzFk9kN+IP9Y+CNWFQ+EyO90JFcmXFfhwQdRIyFda D7hAfimuNCUZFWl24o902l9Bo7+MnuuAQAzt0tLSiqzq00A3e/0SxcBSEmVJ iREpxbXDMlSyMFCSMcTxusmPxhQALW5xvc1sVl6w4xIOh7lWROWISqbWGBSz 0/0Nqq6rCdL3UfQbeW35ZWVlLkwnlcdgRsHCNxYQlH1cIVi53WCMolJUtsiV 2VmplBhXm1R7Ydtg9xcRHkN/rHf5zozAbeTpjuuJFfEVEcB+XU1R4O5AueyM KsVO+S0M3REKfphJcMCjC6RqiGfSDU5FeSYEeQ1cAZvTXfo8FvI5pYYdVcF/ wHZfNRkFqU9lvVWqZ7EoNxiCYYsQa6byimFnl4/F0M2Okr0zdGl17sI1FnIe U46ZKVdKjmQKOaezMmQ8uZV0GG2cIHCAasO5uLjYSjYyNFxKZ+I2JcRyO402 i651AxdXRF2N6GlZ9seLkIiXsjuhKMjpww4BBF0AFLkCIDNzrjqupqamwoGF //XWjJxwYzvnvoYUQ3nbNVZVVZXdNGKpLmKHEwiQYHQp1aXFlJ7EgMTKmewe OmwD0j6kAgFkY1S7aCq8NQvsFoyMdSgwACW14SJm63UCwDA0YkU+7iHIP4T4 hzD/UMw/lBya5OtUphHbiCpCU3k5yDbaEKHVJthZXuPZIlxRvwptfNtReZ4t S+0ZQrYMxfYMYVuGkD1DsS1DwJ6hxDlDriSaJ6xsnV5bW5tlVoYtSjbb4LFB dGQmQyNZBlJdFfxZKZ/yCcbvaJR7iCsUps3eDnMjXooiLlE4A9FisGb3OmaG UMDdAcofyeSYg4wbWVXlVLOui7PSciNBnUuX0JtOjbtGCf4I2KgdQmu2ePGX 2FtFX5TwCpiDkeIe/Hi/4xEecY42B29adKT5rH3rjH9c0nQrKRgdzUFsHLZz dayoawv59XIdwYFF3A7KAS9UjQzVlRp1JGEPm6vfVldX58o4WDkyJSXLUlxT Dx+QDuuY7mBkWaYulEv/G86QkjQEe3bmcqlR50Y33qRaLuSV55H8admHuNwn 4MNuTnwFt6irqAeBr0bLyThW+rXyNEmYkBHqJeSajVaTOLFa0TVknEgJYYKc lizvEEoq3raVxXEBsYyKAzEWj7tTY+TIGjtj+ouC2VpBMBMN+uBz87gOJdEk ahFkQCW1mAosg9LQ6GenXYEU+AEv9pEUIAyXwXg0smQbYahNxbRRFuAWUFa/ zZ8mIyggBkpp0SxcIbs/oV6GRs8svxaTomozGrGIt+B/NHApy+BszXLDdEXv Qs6Oc0ALYOOPaJx/dLUfjbmCfzuKOuw8tSXFuoC4yURiEPUfLJmyXsTQGhU5 HvXD5mUGHyY/eKGSZadm0YJ75dB+fj7CnmqiYa3UcE84B9Ayu+bSbFNKWSRm Lfx1MEptOAxxpoR1ksBw+qkWxcn2VhnENTuLG9UBsRR6hCqM7CJRh2kQp4wp Fz0kljq3T4+KeFeLdYJNLMoWPGKIIEi+xWI3eFmI2gpE7X6ni1MfR8aWk31h TCaa8agcZ1NDbiZ1Ju5D/h4tg9ye0ZIeidHN+dgohy2y+CkppdNqs58IKSEP 2XvDkZuah4yOONmxR3aCImfHwqhkQspmydmQQHrJSaEbTGtkH2qBYh0MLvO9 IZPSWP1xhMLPqB1m9U6uodVuM2dvUZfE3Yr6y1zMvjJW3KaFnSyCSGOgMWR1 eIPBYAXrKdNKJlKyAkhPlBCxb7ECIj9529ZB21bDn+vUKBEhpkEmiQimnJaT EYb9oU21MheY+Nu1atKDRmwG9uOZ/its0VQSUhPiSNQ6ScS//Ub9sA3HltTR LC3nEHUpPydAmbuNC7MB7v8RhLDIV6xqIBVVrcPGeDZLgYTlj6GbEyqH0CBa BHiS/XbkTTYmYSb+nIQcVSSBigPYxu9NSLP8VGaWDkWMXoAAUNvMeQUnxzbD D2ltZhHb+pRd1bllt86z5ziN6RyHSWGWxmwzayrnw9iqzV7IOmzojjjTKo2Z SrdMOVQyc4cjO5TreUQFcIIcnxiA8ZaT46Bscigi9u7JoZ1jrjaxjJZVK/ds roS0k6CrAMmGOY4OzuyWi/m5U4Yu5hiaWxM0Zb+BJnwM6Ry0ar5O+RXLCrKA amJpH4bcwm9bx0PM0mzqGnVYjTHEgmLxoIqsJhZDc/yYg/xB47dDu7HGD1re WQRJKBQy35h+38hOWhUL+ZxSw06pKZ8rEGM2nau9K0R1KGbOQruWsqzduTOi nTG4Alk2vgPbcRAsA6TzCrNHXsfg7eyPJAQzuJyGgG30pvXoVNTEqT8CyQ5I 0om4OUI5uyZKQI4gWZtQtIiIZ/2RmTFTa9H8ZM7GaVl7ANnFIiV1ZgiNlqYj Y1vWkK7HXkxhIhPXFT+cFW1CfRQTFDhHIMRVdTqcu4MGKElhHBLekiZrNPw/ 4rdcYTDeAqOJwkXGSVZF8wnMT/agHm7C19xjZ6kxE5kup1uEiJQBOEoSjiOg F3CLCwJFTs7ii2rZab+o0ohtDh12CkPtEPEf46yJudB+xCv5Bj5IKZEJNbLT Aauo4QJWVqlyOP/gj8SUuM3LsU4dIuqMUuBsSqYJIvTiQ0oRWJEiZg4gLYhi g9IQV1RMq5bycnpYDW7xRiQA+xIhZp0wECMKOTJgn0kwXjjMMnDviAdrnw9A yFZjjwjO0pGjI5qakAU52oSwhr6qgHMecNoOjTw4I4ecE9xcgcwFaJAuI/GB XSrXyYWOphYcJhb+3fu4DvVjnNlXEyAIjvzm326d7v8tCgaK7Pt/g8U/x3/5 ST5d2P979Ciy//eam7ovOGPqKX/54MYtE8ZvnfDeqhsueGF13xUjxw99KLF+ yqf/HHbjq6Ov2rLv6coPhg/8+ObZ6767/JjJw89Ojn70i/27zvth2JCLep2S 8+3DQ+c+sbvvyvbLXlpx3PJbX+qzacSC5t0fXT9gRc8n7iyd+saY3u25m/dv /1P4trNPuTb3ntF/rf/lR57lj7T3L3zzD599uqwy/fZTly5/dsKLgQEPrh2h ewaeti1/lWfu3rFndrv0viVKL6l57K4tp/dd9uQzX1318Ija5+6dsfnKV8S+ l258Wrg7PnFQWY+qXxz9emvdm08eLQyokJeecWnj0vFTFo+dMrGmW+2p3eef 0P7KxfcF5YJ3lv9pa3plS/uYidqOua9f1y23dWnRsPtvmTd4Tu/qWYtWf76r 58rjd1768p6THz14xkLvw9Xhq5YGZy99e/o5q5actfOOP1euHHt/1RUbbt/8 4lK54q7cUa+2P3ph97n7dl66ofqLe9ddu/HNc7wfdr/l3J19ntm0tM+4bcc/ uGvk2rwHukn7vOJrwuxxg5v3vLa9z8TqwoaJX+U0Xrupx+j7z7pgyHUPnBYd 8LtXtwwI9ClZ0W/JR8XiWV9d/3xZ3YzuQ87pFrpr8/yHHjxjQv1z11/3UfSo 0nt3//7MX75Ssfz1o3ucfV5qVCzQbU5jRbc5Zz3y8imxPZes802Zfcqnz5wf QXpyW78NjR/PP69v5Ne7Ryotb363oHfvL7+rv+mOMXNjH79z56Bm7fiN/71v pvTDk79ufeCZbjuO3XJvRWF96NOnX/vFiBl/vCeyq2bl3yZfNWPlqF8d3f71 yln73vhMkxPrTn9k7vRgctiYL3ocX3bZU/eVXfvGvbvip15x1Il/1wev6x/a B4z381bt/xcfm/z3N2BP+siqgc7kfwi9s8r/ocXh4p/l/0/x6Yr8X0/l/83d /7x3WO95O26/b9v3ia1PoP9mPEG+E/eetWX0P5ZWHpx/x0knHKi9e13pi3s+ 1zcvXHPF5NYD/T99a/PnW/sXl3z/w7Q/Llw+/ILktj79Lg99e/Ky363XXqld 2rp1+7fq+vb6ISdsXr/+3TmVi9e8kPzmsb8lv7n71RMuenbElk8uziRu+KZn 7wNVSzaOOnDu6kGpYRPSz+3p2frJK/85VFw16JhP1vT89pNHfshs9WyY+d6Q Dfr2/BGrtw7asXqH/MONhbMf2n3/5NIez3w28YNJK06Z1XTB83vVnGNrZ5zU fcWpi0+++KgFfXOOf/Hqka8dmN9r0/blTRe+33/akOf3rtyuvz6o3zdDey2q GJy39FxlXsPcGybNW3/L/JxufeRJiyat3J/clt44tP2LP7xVMrX5tbKP3m4/ qvdpc4rrFx/15tXhXqt81/murOl1c9+T8iKpL6Y0T9aK+9+/4strdMl767uR 2Mb9N59efveu1mMmFd6982BqY/vNK0+b+/UZz24sD4VfemXU53U5877sNiK5 pNewnqvqJv6vt2HVyAXXrJ24bFbDwLpF21e/ED/vtP69Pzxu2Jhl7+1Vlly+ 5MOdPV8MHFN3wZxVM/Jynv9k+x1LVi96p3DK2uTGJ/95/MsXCRPuu+XkHd/v fW/tshMHblqz/7UbCz9/sf240PX/c92t7ZuWhR/7+8Kts6ZuWvNoSSIn1z/5 yX5nnxw4556+uxdom16oGnJTn9uP6nlM+8V946dP/XrLpt7PbZyXc+v4De07 dvc9OGLL4yU3vbr10bvu+KZGWPJ+j5m3zVn2db+/VN94539pn62df+DMK/fs Gj5Ke//GyKJ/zH/7xCsuUffcpy7d9+7U1vmrV/ebWBAuPVb7Ystjn+74cutt O/YfvPrl0jNO7HvJwueeukQ7sHNaaOHzz4T3PvEr7bdr819YfHC//tfrZ/x+ +sSdj7+3rHnftg2P71g9/IZnB6xdseub0ht2pCYkv2v99q0131W+nxz40MHU 5Pd/W1F5TLebFlesXth86ljg9Z9VTvaHyX/k7dAAAuK0n/b8T0lRODAUy//i kmBJMEjO/wV+Pv/zk3wKB8MshKX3IeFy/oMSII1MvolmXgE8dkVXZI2EUY7H raESRVqwHM530xn6GvZTCAYCQ/3I9StlkYfosW1dlhKw50oWqi4cP2rMuHoR w4grETmpyeVCdX0teX3+uTV1v6mvw3VHZV2C2QNSY2FurpeF7vIOLMDzCAPF xqQIM1BNabVZqDRCe3kL6NRIWtYzaRLwSJSlSMyblQNCJsJSFBzCRxAgJ10u sQAX0zIsSHlZ1gKWyUyh811iIyKXll0RfFhecs/0TCmOatRk/Vz65Fyoc0xY vjafUBwIGAltBkqwx98ZOD7gb9SfhR8Hi07c4e823HontPhOMDDkSA1ze6Pw /CfKCRHrZFS5l6MiHEzzeriFaU+BTyhijWIgNOgqhiyOnCBqKcS2Xs/kpIfL G1HjmUTSkhslaVZgNWomCejQudeBhFNwNb5slhK4MkMqYbEoJkZkBREPmCwu J5v0mFDIai4QZs+G3X88DaHeGKMBR5DBgpcDLRTR7FnEoXTxUSCsR9oKvNMu gGCXwJtZQ4VQI5HyoZGJe88IgwchGI3WwUMdvoDES6uHlBpUEOLvqWmS2pYF gJWhYAZ6mdAoEBEOeRE00qfn+QQP0J84JRG4Oc7DERiHazepjB/FVBp/15Ko GF6DH2NKVAa2QTQvECVdT3s9ShQCXmQaSHwXb7CgwEr2DnCaqeqHgQqOtTYB gWAIdb3itJyKtxxyzWpKTo4DCEeOErhX/IeHFoZxhPHSkGryq/jA3GF21Di5 HsH68V0FoVQgumBK1aT4IeMAUMZSIEeOOjAaDh83gHLkcePoJvvJCscRoJ5c gyH9S0h42GiahDziaEqRiJxCwpMI0UPGkICpIVCOHHZROS7r8mFjR8AcceyY 5klI6emZ1CFjh+ydpjjDbjSGVa3O+lFoYv1ZOHgwJA0W4P4SoprJPe9wZThO ICrXVLQ4dB5YxiANyXVhUQJCQVY0SaKN1Ei0Qp0GFcYBmPDamAEM2Z28Wmfb GgshDBwOiquk8ZbTNLLK43jtlNz5mSdpEURPQAHW6dATvSINr+kxILAnJC0n YHMMuZoF4viSMFBKo+BtaOGIE/CFCuDyUg+C5TF7ASwWBVlIlrwhU8sg5Hlr U0KWDSrMTH5pkjJF8AsN6KuCRRFvE+S4JhsVIDTNEHasPbALnW+Q2LXqGiY1 tEB9EnybFeYyeozDF6niY0r0lBxQiIZYxvdU4x1FqH8xIkTTiZSjQYrKcQ/j LYhHBccK8lEKoXENbLn3enCmCrNQQ4sH2ZENLSxblVkcwYpG7cWsbFmDLE5d pqxoNFxk/IGYEZmxkob7lmyn01Db1DRevyUgcMNQe6ohYJ86XZF9OKqiHkOS 0Ueu0cXEJ4myQIOfOXCr3Qpl++1aUJ94YAdhsslTAYSmwxXHagRKohzktWjj bwteOIgkHJshmEAw56SGnNaoybJMrIikBLP0hwsBK8vC1AMY9vb8OPjemEZE blxxpcfgZIBOSg2oFPxFvHvGgJHvIcJQ09mDuhCjdlBTXgWMUyjJ+YhQGS5m r0pwgUbaWcHlw0TPIO8oIqXkLLqYYxVX7QOwBRwCbbn8N/nXJoscRCRS/IQT SUBnZaaTRINgd0rU9EE8+ZIKIwClYf3uNQdHvhRjb3Axi8+YBIcLtRF5grN0 hL63VYmWo7zIv0YDU+PyptRUBsTCQC8aAEhajJcTKYjF6MUv2JOPwSyw4oEz iY2ov7we5uNNIjEBmTGXN8XjXoYf4Q7DmaCIIytWWsrlRxpp40k2yCKSEIje Q7QnUO1UXQOwLJ3sydcYufGpK0IfS5O0OGplrdqc9HoaJc1iPJhYNMnMaNG8 BvpOOhXvfemMYTBdbQwTc2UY1Y1hIAhiJWlkxEJXvIcHmnVhqqNGkXgeIKC9 HbRoLI3HDTceTpNm4WiqEKoWYhITA4LofTxrh+PSknKgZ4h5QK9MtdsHRgqc n3egko3mjFgiYOGlbYBwlHDUsm48u/Yjk46X49EicuUvHHc+fR2VdKlcaAU0 ycgiyVoGGaaaVm6SCTL68OxNvS7pGc3HGs7JrpkkCgDpg0jc0gf0tZaCKN2V gnEOnPaqMRJM+db5gOTyAnog0iHSI+pdeBTJE5shFKj6gDeM1Ex5VCIpHLAI 4Uwcxzn1eiBw629Us3NaZHq5uoeTpZCdYIAkjQ4eO9yuYmawGTwCp//SJFA8 g08NOhwHHzgmlaEP5JIC04g0SWqgVonLGjxiaSmPLOsDR1IMtnSNgPdzJaMG UBPPTLxDAuCLaTgKWDo7aQxhOioJSkNg3tosg2CawgjnYO8Ym8rpNGxnNZiU sqSVT3EmrnNBbNRBmtczRk1pPtoLzRKY+/RWDDAn04o8k93jYVDJY0cBWj2e jLppmpr0uMoNfEuqIQjhjgMsPpzFQpZUcBMKdoHPTfHiANsKdDTWK2Q04Rgb dChBBqzXYMqZV6YSbJDssCjJ4lSYqmyunG0A0wY5VkzHdoflLRqZAjCMQ1I7 MkU5/4Xr77FkyyeO/mN2htmp1IuwOw21iob3ber0NhZqmcJ90sAgRGMjn0E0 tbgVdR+mneE4RAk8fBLe+M2ageqrl+kNE0bnq9Q3Sc9knpBV7lPBnzd2TP34 PHarkyn6TS4xJX8W5/Lp5ZysIrqBcpN5YxRhgXKTW8xX0Oxy/C+XnXZbufGL 2Z8sT1d0jn0smy4d6xtTOAI/UKyt9nX2tBDLlm0dO3Ynr3kEzIMeaxKit9c+ cjwFliy8J8jzQI6DEmX4wRqGQW7eloem2iRwgW3pCr0vEPErLy+3OxXcHCWI mGLihtceXHZAX1Ip+sRWy6aupDLKJJrYqGj1aOmIhzIshVuNVzPPhdNybbbm OvYs4gZ8WQ8amkSc56VVFV99hcH5+KkQmoY3h6uzrEC8hmMNkffBrFN0fBQE u7EyzPfbNAMxngssFEfdJ/HtN7SdkxfGRsEhqbQOZY4bp7GyXdKH5FwE32JO ara5Kr1xciST1pSZcryFWhKcmUuEGg7Gz6iId/XjO4FgXz3idAIG789H3hvM hNgJ76YY/4+9v+9v4tgShdH7r/UpGpG9kbAk2xiSYGO4BMjezCTABDLZ5zFO 0pbadgdZUtQSxomZz37Xe62qbtkmycyZ3703Z87G6q6ul1WrVq33dQnfYqwz GRjDqwaZIMgVNLiqG5+W71nNqCCAY8Qjdj5zkjh98gzghwfm1ri8hYInspXQ ZTi/yVTJfqnr5xgh3lkYw4x28vpW6AXQ9s00y99PS8yElR9PGFRMQ0cUqUpa oVjW0I5I5YYnWu8TPwlY/WQ5HptaGON9iGYEBbMDRiPzQyk+BIlAKirOwpmE o6UlK5jCcOABT3OOgRCCBFMpUGEvL0WAmFopoXL80YptDSSt9VeDVU9OI1yb oJrMpelq0D6pAArcDxZrQPdE13FXFcaYTI5RTkBRUObQIT7eGo1L6v5SFOYu x6WJ5sYnYeHwU4waOiMSIhvFU3FA4YwI08D3Ar3WeSsL1Sn3NnezMntg81YN WFaur4cDincBKkY7hk/afr886GYPEsGOIDdCyLlmg0juzAR2nejZYQGTKjq4 6toBJmCkehP31nOVQeGmUAM58KygSwaB1ovAgTrTopL6LcB1TqwkISltq552 Mp3jOZIagVKZRSWJRHAMpKphMasWEnsaxGarVcoI1UYgU3qrgSn1nSR8KfCf qur7BO6wrpHg/T5VcfMoHxUvl4v6DgW0wGaRMh+rmOEuuOvuz93V17tvCTif cOXa3sRGuz+4N1En/117E+vsDPwxn4c9kUTHU7pVY/i+5f2RenM7DSweMRR4 bgJVPqXA6QWwJa6za6oJQ+NYWSgbE/2KT75npmHm3yODyZOmE4v20Hjelezm yD6DYT1VYsYAS3UOkF3tw8aQvTAWR3AfOrf2pS+Um/H0d+sd4aKUxSAh7s90 ZucO/gcgeXM0jH7m8c+5/YzAjP/h62oWtT6Jfw7ncV/jmjIxa9gspzxDbVjt /nVN9QAikCk3FiBkAEG9nWhBGttcftELnvwPkBia2h+hMJHvTKy2122qq+1P Zk1qe3wzm0fawMtvnsg3Jh77ZOXY1XXHtoN/6apVaxAPPxuuXPpwlcXCObxS F4uIBHrHyuASGmm69dq+1DN1f/Mg7fGTIN283pOV6539Feu9dYXkGi/lso1b 4ScSr+b0UOfMzWPjZ/ZPclnLzrRSMesG0KUF6+DBoVIbN3oWDFLzlvd3wwZe CqEsfeRHS5+ygpAeouMK+dJuvK3WN4KJMOuQRwaxxw/k80t4Y26AXhg3gCB5 /z1suEZG5NAo8pVJOVYiLXUTMess8/fFRqjiG5v1B7bc4sOslLqReyQGPkUr rXQTXg5gGHrjHh3Loy5s1Pbn99S2F5u9ZYlo14dmYho/PO82XCv0361dGqGo uH0YbTH9/s2T1wyJgNtOBF+iI0jsy04Gf69hqBlovOBFKrnEUrTKllMz46xU b0SKvksk8q/D8cAbAfk3QGN0wGUszyMcR8EDU6k1GW+D263HbcS9G8RLQp8A xCZ9fPv/TJe3gC/Tyr3j6XFJE8JpDNqXaeXpCIziU1MacaDBvXKQlPgjFNZp QXhmp5ipi11QeIa8wmrQOKh0ArIai1mU8AunyaWIEZMJduQDjw02TTQLvk3l 4laVbbFlGEte8/fwqy8PAZvPqNdwYLhDc4rHlZWjAZY/f7zobHXpUC8jby1u HxptslPX8lb2CAbHdIfJorDIPLHZXGW3WmFxIHYdev49xtWfWBiICEfPT2aH /+ExnZHjLJ8p9Ati0RmgtKOyC7S56fXChNqtbj0Bia321vtbsF4Cz3o2GoQJ W0CGXlARKEAkiUxxlaY/IcWUA4bKLpQzhMSXaJBw77EQ08xiOtQiyb/katYO wbTeOIn8Ai5EVfT60q/zMdyFo3PYP6wBzsXmgBJN6E9AvOA/1RlxoAZgDulG /v53MYpTx2gJ1wa30TMpYJbC3jqAplsI5ZGDMgI+AUO0gdft5n29G89MBO3J 9+HKMeLJjmam+ZhivpighaO/pMn6Xrp4gMgjg8BOmGU/s3Z684Tv9IPVmjz8 7TabOSqanswE+ZmBfc4SlMwykcJYAotWkd3KZtNysmC4ujcKWwJtReyinT81 MtISygn7QMqN8KesjXKd4JVQUx2M/gcEmyEwgizX5Au+Sq5jqng5o1uPQi7Y yktuvgAMfoSV5SfAIZSV9+9tuBBDNEi4gZTecUajQrokN1Qk/PgITwk9MUJn YmyNBA7nKYeto6CXgR9AN9NUH8DB1AhY4jNH3wafOdX2dBvmkQja6JdGmkXU KIar9zVcpUzr2VQuPMPc1h6Arrev6hDmiV/QVe5xVznIRS5yn/kBvLQfAmec PiqE8Xl/CCoAfLhcLKaT4JE0IC5jVaRfc+eBdlzLAy+ae80+LcGPl/B/T3Aa CfAJdQHnz8rFSUDjBhSP1xBw/Luge+NeEcMsa+PTl98OAnKPmiXvFYtln/66 d17j6bKjlCBYdLrCGUqxOpy7cOWsNmuS5JeTFQr5SbuElpXTrcxcHEGTx2wj ry/LN98jbEW2DhP6r7Zfpna8aKToZeIrKv702nkdBv8QpwvrPHg+4obnSGmQ qZkrrMg6AcJOj7+fOxiWk+F4OQp9VbfszxWOkMF61Qs9RXJ1WPP+AS8JhTf9 rhv+bO+Xox/3bgEDd9C2A9wcpGydm9ZQMXOl5hBZrjBBJ4Q2GANj6ZA7Vl0q 4aR+A7iZuhgGgM2W1YmzYsb0RbdVGkdKDgs0IA54qlyv81oD7jelBKvMp14M 1GkHNhqYThYOT1V7H0AsU4ST6Muaqxmm/fAN3B7vsvPp8kaWgQAZduOsBFkS jyyIVtmtVN4HJmmKWY9ZfsOACeKVQZCeA02h4ud5ZtMZcJXwW8ZvCp15BbNb lEfnkYTgAxvM/ooNz39SPsyeN7BsMtNO0iTl3UzVQtkWcwZM1qEIfQYsfoWy wzkcTYWXc7iw3Ifj824012FV/cS9hXmGvdIpWJe3bCYRxjCtTU25qzz5xYc/ VX1fwpZIwwZn/kSIcjExyP2NsukkmlgvCzVZnJeB03CoVZmWQSx/4hAyl4yQ e3Ez2jMUIFAM2kGRRs9fYOpJ+Ak9qKzjjnYiMF326TL9tEFIwrXEZ837CdDG 3IhMFbFHvIY4cCxyPEIMKHXs+wkRLZA6N39WxK+ab+NUkVLUcLKxczY3fVLn AAd+FOw64QTos27jaGzNWg16R8ngq/r1+TirSkBkYJYEnzNGd5C4slfjfFic TMeUH7RaDk/QEvjgb+Xobw/JWRy3AlpIzOHhuZ6EfVSBHTD7xhlX2UGV1aCj VR3fLEc3H3Jf2DtSEP2ifvkmh3JRO43uDoZeLvUmAcAEkTRRKHZmJz2ZRqJN BYq/p6OZUoEv7NmJpp8YYLqKZv6bv1/O95EmHKQXpO0ajw1nGf5gkRu/BIxp t8WJqwtHHJ5Fh00TnQhYBrJVnY0Hnf2/3Tzodvbfnr0dHNzuvt16uHHcOEXp QsCQz48JdtX+nYNeFn5tHZCe62+o50JOAObiPTdjlj/7Gqj7CcmvKDxnpyCe Y6Xpw3lZHAGH3xDAxVK2NKynk2jeSvXkZPsFEEDyiuzToLeC/HSlpxz3lt7g td6p377MEfrnbdI5J8O9mXZuYRLoIKShN8hz4P+q8fQscH5ABvPzzp3Nzc2o IbqNSMsIsuzWT8KG3TyUjBgYKBShYs0Uh1gxuMlmFzjJP5Azx6nBL4163jLc 5tuY06w8efntt89evPnp22dvHj99/OYxsMEHvh1X8tqT9siwKHvLfmfUSyOP IvNCt137/mG2CQ1XOPdmsdsvPfNdgcw+HFfWF6rpcFQgVTYlGN8uWwGG4Y8i nEOo1biXBzyOEBDDdXcw2LcXPQ7YyCmcNOi+j5uPkOK5xx+hRuWWBrK5Nx9j nL/6oJD/dON0s6yaD3d4E3rJm3y8gPFNOZm85aJs/E/06mNyJFMtR00Vw/9d pZCR2eLteb3Y/QZo/V/ea9KHoNphVExuNW31yf/AVvMJwpk8ccdoxd5z0p/m nZe3/3N7/wlJhBrAF994xE0gzUBwmLUqVknDEjd+kkc/cc4hahWFyVAjePJT fE7iKEpqBI+0UaU9Jb6N3Bk9TPpLPe2oJT9MWnriiK0kuWBDknH9IMWF1V8x Brtvx9McfbVXfYbWgD62AXb1uDyKZ+gI+yUjhmS48vVy9hgFsIZP4MoMzdBE uqohvqv3+IrNYY0d98VW1jTA6u+wScOXbEcWRowfmawhTw1FKVrtfFZMj+wi fvnqzfOXL16jNNbGalIgaRSjth4qwWdOLaZiNIvQSQeBQbHQeOXX0SftLXXn dSsxNavaQKng4ZAljvbDt3LUHszsg+BFUoX3WfaavWB2wpMHORHTvfbNdsPH 0JaVHe2HhxhDTQqLBxv5w0/oIAc+/bhoP5wUZ9DFp36MX6I8FH/5YGMW/naA Utzl0sTth0oJWFl02Rdynhi0w0kKWjtwQds7GGQPgOYjbd9rP/ibP5DwJdLx vXY723iYjL0c8xBjGSKdyHLchk+W43i29Em+esOBDvZzRZD2wyiWNayh0wBv HZeT/fD680MdiZ8i6Ls7VwGd22LNCO7l9LAOxXnxGoShITDOaLpD1QZ/tQOw fHgbDsHJ7Qcb5cNe9uDw4e3bcLlMJ8e34dEhPHJog5XEHv78M/7z888PNuin b0CVxqgyUbUjrXd2pB17G2PkBzADqH2idhkXuT0co+4Sswsm20bml9NicTKF lc2m1UIw5WjFNmJ7QAK6fAEPPM6bk10cb4uZEKGDLzdx/7WN/842W7NvsVXL 9x2fKJzgbJhMsCHNWNxDlolXIWIQm8H/fvP+5/e+2I3Gic5xfdyTdNyGvGHX Gvfz7UvG9ShZh6xFIjMkFjYjBXQ8PP9XzYrxeHhSDN/ttelGWLUdZF4kSzsA lYyebXak2Wvj8bNt3Vj1EbOj7cwFe2sHOtNrfivR3vq1/+7BBmKi+xmwWjTo xpAl+tvkKiJsH6XIFF1MD/5miuqISjlagcxcdBjcO1LvXo7Ny/fJBKg/5ov5 B/AUKVp5Ki0cRwrbq/F5uUxGXk6yPzi4sC1XzSEmQJ8MqtHVoEIu6bL5GqOF vVCfeRNiXg280bWAd+3p/CEAXs0CSGnzdiPNXeTHVG7LrthoXAzwsLVxnAeQ jb+phvpvQEKwyeqPlMt68LfILnX1hyCJLHL8blGeYmlw+NXwUUInGxZPd7Et 7sFN/H3zYQ0HZ+l3xPU2A6XOa7CVX2kXYsZc2aCH/E5umssQSicQErDKVTyv dwWXx1W4Wc1WX5BwdTy0nBfXmBpdfGl/Uc7RpL9rzG+UXqRx7kiF5kN+XOuN cIXAc5r0I5KPhBJQH8nZS2aSpzOJc2y2H/Lv2hSuQEYsdxwxNnZhzwP/+OBm ZLy6GXc3L+IRgcdOz7bY09sx8x1z2pfTXMoAjkVL2ylLf8mdGrlquRt1XDaS ImrehwdyOkZ1Dpo5UXp7VH/7x9nLqzkaOWsbqz8ShlQ/epJPhsX40i8u5WNW XDbX5KES7ukyPgizRXGmdpcUlfx16zp9zgJOEnw3ySV+5dfoBxxYQxBChifT eagfYOUYK3aNdHmnMLSG5ndLyoD2T/LK8sd2VTEvnoYwTrCgV4C2w5PsbDof UTFD+Q136HK8qKjTNscVksWunQZNeIMhzvC0Ij+B42JBC3+FjzCuvIoDiebU rsNfDH5Fo7v+vb95EEXOZDvmAsRnBmcWbCaRMxV1vMIsh58NbOFv0NZExpnF 9BuMz36SV0Wn28tuWZMQrfTRdpTBx0Z8uEXIRBQcWCbAhKBqSLxhycRLBhDa Sp8VUrMhDGCjKCskKpS4WZTSNbvPDvE3lVTdCsY8TdBS++x+tysK3jTKJhoW CQ4nFGzogZVQuOT/22U4/q/9p+rCX34lnd1fXvsF/7us/svW5tb29hd3/l9b 21v37nx+9+69rS2s/wJv/v/1X/4n/tu4fQPLqzAFz/4tf5+/Hs7L2SL7pjyc 5/Do/fbgzmAL25wsFrNqZ0NRBQ7rhhR4ec6+kVX2uvztt3EhNWS0fUUPf6n8 F6EMzL+9zr7G2tXMhqFiimNIkBbPS7hO4XpokT8rJUbDEJxRwR6z3z5/k0lZ mIb5TefHG+EtNsDQPKwcvvVFf/N+f3P7zebmztbd/4cKxnQCPc2Ox9PDfIxp prBu+3lG9cnXUKrJkHQMF22gkWtIzDJRjwMjuRxzcEZ7evgL0M02egVFbwfF ByyaU8WtuO81oLdfA/FEZe10AiBBOOiP/rh8hwnh3pfz6YRt9Jy7hMIJsLj0 z0yVf+aOSsqzXJEXWfGhGC4l9kSXg31jKg9R04fRoyHo+h1NydXmJH+Po+kw 7L0Dv5XkysAdddd5AUwIIEEXxxd1lg1eJeCQ8d+g8xtyz5PFkvKJcMiaJDEn BwXKrITBC0cUAwHyg05I+igGxwO6igSb9+iOgmus02acaHc7/AVQfPridQGg gTsEoHFz6+69u/dptNPpnKNNsN908wQ7QunsR9BoTZYXcIf8XeBap5eGWWe0 3/CIsefGWehGX6wtTuZU3fgsY/+WrC3LkcVgGIncwrIP2kc7o3WtrX2k/xXn DJvambz+CP9r2T5rU6dGWBR6I3uF7pYc8HVkFz+HfonlB904Wx+zrh0EaYVx W84+BIyPvNiRYtkOJPSiB73+Q8bHEwGjP8OCzg/2sq07WT/b2l7vZV/D6o+m H+Dh1pfw7O49ePb8Wba1iQ22etnr/Cifl9m9wRY8uA8vy5evs8/xbyBg0CND tvhAaUumk4qjSCfTSZ+PNevMO4hGvezx61eDF8/eZHcH97qEmBQCLQ1RcMQe zddpMATutSj4n3nWWczzYR9utu173UH21ZLyZAB4ZCe3B5tZB+jQ592e7xEd DJbjEQY4Duns4xDFZLo8PhFuGJ2H6Ywt0HtrwVn2j5f5XCpho4//OWvzB61W i9iy+Vz8y+mn4dueQN4wUBoAZXg1ny4wPd5LolEDfYJb/PJImlVIWqENdD+g v+U5kG3gvuQF/5A36PMtz/FPeSoJyOWF/NK+UCK8g8OikfyjPF1MOeRZY8Kp wUCfSiNg/V6eTeIm/OwVkczFuTQ8mrwJ/XGLtC8GgwYjW+PwJe16R9rh+WEI SZE0mTpQeXNee/ry22eYQIAQjirHy/HHv4iBRic+tzFrlHKx4puZGiSuF1mb XxIJgOb8S3N84DC73P0A7YLiyUGO/B3ttis5pYh4S3qhuAERho3bSihen58e Tsd4eXIu/VISDgKJkBZYN74A7ICbfDjABJ4ggiGCD80nG20cczwZIRSFv8U+ lxOP2hPmC8hXkTKyVQW6j1b5EbIDUyFJOjRlqzF3bybiLT4SrbX3IKqxa3Sb uJt2D2Cmi8B5cTwmlq0Lp7a1ZtdKoF5cimE6N99Sd6FjoK58wrc9BWUP4X4b w9x+WVbs2o3SNH5dkVUQZnyrmJyg2mB0i/t5URAEMCjAKAh6iiOpGWUd6gj+ RtJGnpMcIk3EboKfIL2W6JVRt2X3At4wwgIcTQYk0zctBzddwPOaMXonezwZ zTHZ3IO9u0DJENT0npz+qyUGO8L48/I0++rlt8RuvPjq9avW2pye7WUbP+6/ rd4uv3729ddvPzzePFi/SH5/tnEsQ36bL4YnQHdHIMphwQs+fLivQxC5x+Vv 8BM6Pq1eUdUQ6rx/WvU3evAUP3o8np1gXPNGv7Of93876FrX31ccUSEwoP5Q PkZSjbClXJoSWonusQC6o9DIIwE07kndEznHAmJ+hnka4LyJ8I3whCNqkA/+ EjMlsuQS1FIUGi7neCwzRdpwjbDnNIaAAm4Sg7OjrXCNDqd25JNe6FbqZ2SS U5uYqhq2brbW+P0OJgtorS2mj+fz/HwnVj7YeukiEGpI585jjwZjvYDRCiZb Gv58Srs8sseYLPfld9FXZyfTcXNDiqtFzSTlf8gBFeHCcjPMJstTdyq/k5ov kqNOeqr49oy6YR4Nv97jJIjKo122WmSd/Dh2zDGXg07bwg1h/u5AwkgPyGsU e9un3+uZLxV4IPwTvztwwH1D8TYyddxMWxdnaK/Q2x7moHHTC0Bu+rDDgyvx RaLQAGTAfezjNX7mQYtNKgfcr5ZwYUjyTEGmht7kOoORA/KfFvPjoiOxgAFx UVklg+zKGBo+PIWRBFPjdWUdQgkrNSM0j1z85I624p1+q2T943PyXKhNWXYJ /nFwfybyVR5IBhKn4j0ufQWWQ3cgWKAqz4PSvo9OlLpSod5PWOfQUOdxms+u 7okga5vYMbjns06NJ8eJwxWb4Lv2KygvjXh/BPfhC5sVHY9VlCKdDZ8lYEvG 5zod4619p5Rm4NJOi187cIbsA2D/rm7f3wofFL96WCoMKO8oBUC689hD4PwC z9ZLdDenTKB4fLHhjkxiJfizh+gh/ve/w18P6ItH2b4c7l/goB+QRthNazK6 HJYBuYF1rB8jh7Mo6lPR1gnwOKjUwAt8QK++KlDUrzLSOAA5IWp/qxKvnx6x EvzOjje9GTB92CFKA2CpiE0g2QD+wgczxgZ6RH+33C3InoKBGAA/Yo/iNYvX LEpvPbJ49NA03iNWjf/3eUWT7qFr6aTALVoAJhUskmhkCkD+AOH0+0dsgPlk t/APLbXh5Lqw06OioKpe6BCzy5CUlFvAx+I7YherEvUXML9YQaRzQLn4cDrF a6atPD/3yy2UJL1+V3I2AmlsCVa42YpVlboqRLxyfZ0leTfTIbIunCGMP6f6 ccJVUbE43E/80ZlNK0w/W3ChM1let3FVNxK11w3ZxrL62g6SNO3Kom32NNeP Skxpz5XFXQA3eoQMLPHyeH/qUknFhenARjKfkiAr25eMwJQe4NHvy1CUoCzj zL0uKZm7x17iiCNUMZGKBVUEyABsmEqDLWyVMgkdRcr6flD6I+MekGKEldIG 45Yw8EhXRHOjOL9yYr2qcghw3VBln1sdsMqHkG9PPwjv6CUHBaN/O1xwcDX1 pWrdeDqdBW2Uw1HqzTRSKAuUk2WhyiXtk1MMFKQdKm4B24+XOPYLDDNOnhZV IV4RW1KFoQihAFNoHMzukxnKvMJvmZJ1dB4XFzyRjj/hsFr6F76hf611V7CM v6Hx/Ge2rLW4MznY8gqJB+YiAIDD/JKB8Cla8/BfNtzxZ06r1tBJ8xLjvvjo Biiz/PeekrC+BzyZlwBgFG8ZtkLlqPyOaA8j3Kg5YxPklTYKwAKSPKVc4Ydz yUzUgO22RgMrnf7QMqgx04lgY6ee/Ei8sh59x4KBrF4elcXIDoVec0Iga/dG R6Wl7yclSEHMgAHDlMjvHGKNqb6PC7hPP8yAJE53VLvaphtcZax1rtU9xyan cPN0LUgy23j7FIMi20C+5T59XFVw4J1kzmmukHKEXDr4RLQQa2X1Hf7ekVQT MJkk0VB2Wh0rGUu1wfRKb/MJHOCYLaDHgfD6TgGejcwlEnN9SxeUftLWYcrq B9IVXtobPlBSB9iOP7E3+HfAmsbQ2wuA17wcNnUnPH6iLQU+Uz9CAI/L03JB iY+4OV9gLOuAZHSIocOd2RxblcjOAELIgenyB6RNxboZpGot5kPOooQqLGDm rYvjk/6dzz+/0xUGUGTzOtgcn9eRVghH7qdNDJk95Lni5f/3v+t1QMXtvx5P YVIv8hcVTgCX2scsUUyXMriOZTGddrsr3w0Gg0PAsNOyIn4O/eYAOAV54fd5 dIVNDwdZlMPlOJ+jA1rxAaAI30Dn0OPmB+jKuq2Wh6i/JlUlHCYs1llOCDYl B43CJLHpDdiU/AXDoO8WobvZDTvuSF4zEkltpcW0lz0BhlX5IEzXjwLe4fty ugTAFMc5QYHffo/pgVR9K1U4A+LQDuF0hyh4ZSfTaqFooPf2DZwAbk+syeVp EVuzLyImz/2gnchEdmkQvZ6J4lw15oYewlXIhSg8RRYUPmJz+Fk07qwf7Qjb 8HOX1Px0qdrEeah4MkhOvAoiGi8MZp0BEadcFECrCvKzEXlBM42IKlXECt01 6Bt3KKjLGWayeW0ndTCS8xsvjXixSMKLqMOI9uCXNRU7tWMq1aSVD/j2DJOL rsY3hM/tjFXTfUnbCzvSX05Qm9YHZKxQr202QjUtHwMkl4dkyOaP9Z8S7oCi 2vh86849QWa892jjE47OML4BhdKdpMVwIrumM0OYwHS2ST+Fb9bhovIo0aDC vTPYZg7b/J3K6gQu5ONnH2bd2k4pWTd+X4ibfxX2kGyjwQSz33zQSGixDslk Grr0yhZkQ8g4nKtNgrR2gqeism6t8W9sHalF0MLGEIrsL5GS8sl08h7rfYi+ mYiHqHx3OdneoeTVqfi6obSZfLFXsZL8+TMA7n0xTZIxUyyZrNguh/NpNT1a IIU9nlI205PlKQl95RwYEbgx51ILO+vcvH/vC7yGbDJ+YSK+xZpYhrJxLaYh hxN6WvXbnqMJevJe5jTcQfWQaKpgU3qpkkn0IygqUyHuTUJ9ls2Ya/6mfGdc huCpidvII2jtYJOBmuWzwNLH2ijoguQt0kjpDyEVfIMaZ3oI1PVdyok6zp2H L5PT+t8yaitin65rakEzit8QszuFwyo1Bokq0CFsy8GS1uvEwDocwD6Zq3Wz EAdJZLmOYqURJkTgyZzm74rUKIDyXs++DhjCGl99DodeRCcCLRqqb8SErI4/ KjVh427ApLVYiwzj9EQKYTpCRnDPfT3i1/v0BnVt8C89EhcJL8ihTkv2Gzvm sXeb9tDphstJDSisMCXQlPF28fRkt1AbuaN2cRmXPjKt7PXwpJe9Oskni+np v73OtoKRjlbDitafeiyYo0avywZDThU/GZaoK/ihOPz3EugpQdWvhLSwvawq gOSOYgqA2lB+nipJN+kvJA70uR34VjjwogqFP8Jpp8b7dP5RiuS+SUdq95rv D9NK77otoXcKsGPA95r5ItAyAC5T/7AiffUcX1SkTlw7FZskelXYmnh1Ngfq 2UNAO4JLlQ0QN3gs5Q3/MaUNYFePgvelx/dylVuNV8qY5ESYGXvoUE7vckT5 ohybdgUdTdaGc9JHAhqlbYLuEQXUr5BLThanh1IAxdn+XI8rTo80d9gNEv8V tOfy7cTv6/cTKTOSjWPKJORo5XaAVDSpxpz6jjQMkpydE1mxDQoub8q0HukH IxqmRrP0FvQ4c617UPOor9g1Wb+od2gemlU7orJiHaNN4gbd6J6qQYStW+8K U6kw69ZbfY8GO+H/4LzD3L8eo8MUErZz2Bz0WQ8aSUsiiq5KaoGCg02XlSe1 j5XP/Mf3z59ylh9JD2xC5fESU6lsyQdflRhl7Yt8UEA6Mak90dSSKwhJ5vQX DU95/ifnegLEENFC6fJDdKEcTWK3E9FSnM4Igijy4xfhhpXL0FIdxuoIgil8 TK5N+9aK9cshPeLRhHGTbGGnMy9c/McS6xZQ4DA75GipvfLI2Rtw11He6qld tAKioTSNqsPRPZRnWPiXlF69DLUcZwVnzySLuuya6R0HJhg32B5grnba0g8j 4ag8XY4pH+UhbB08QyjineMM/bYhvewO4xsBuWaoChfQRJFKYSj2Od4k8ZHr NA/CPA7N0SxD4hCBuEaOU6z01HTVaghHcRMFKFUYy3us3Y6eAKL7Yjevka5i QJ3iHqd/wZwFsPgTLUvh6AiWqUbybIccrQfwlxwE+VId4sSFlKQpQIEn6G2L Gyz+XfMpay3gyCKJJZLKnAt77okOCh3A6H/RSZieUN5zQIRKeSL5Ax1UYb7+ CIjrWiKt0saZCXJfWg1ITYZX6wF7KTa82G2Jx+x0RhjEImJwX4SLqhWZ8ttf iV3vBWvpRIdlFU/YKIFwFElctTB0IGQCbQkhytoZaaOd2ZqNo7wiL3+bPgv1 3dQEJIGDNi0Nf8aBQrsCulCwtC7L/Z4wouSYjY63Xw7uiF4Bdxs4rzlIyUM1 KVZ81qbzLn3+czn5WSiHprSXjEzZvz1/I45tpI/dunuPPxEXz7JCmwV9RE7x oyXp/Fj6cvpCEmeO8zkZvtDHkSp8yuULE3r+rOW4BGSGSDn4979nbX7UVoGQ lduOubtEL+zspSm2hSOl6vVYPE7UQ0iknCqGe6NbjLrSaVPeObKXCaq7F6aQ hhXI44fsg9DR330QFbqyUERqhAgHdWR7LYkVkd9PXr8GYsT+gtmzyTES+vd3 BtuD7esHf4iG/y8MALlW/Mfn/c0v4f848CN1RWecJt/knhET+AsO4bxHzmVv qGr8Wln969tveugU966YlL8hS4mZz8sx/sWelPDHdIm34LRaPJGbn70jnmME J/wNWPx0iQ4RmKCUj9I3XAxEHbVRGYn9LZ7KE/hqFP2JTsDu4fPqn29oYvPD 5fHx+X+8fmx/iztlr6W8Oc15ssjLSSWjP59UC/Q+7eO1XB6VQ1JxmcEMfWZ5 T5GCbAFUQ4WsHvIo6HU1L0ZPyZM5cTHHSZbz+ZLs5Js0ZTKQ4p9EpZ4AcSTO kFN24y/qlkC86qUAfb7qPYL75RxxJnLaBK7C61FzOiL6KNoX5HRMtW4Hc9Px hgo0cYepaF/ZAb3z+8du4noOc1KvfATZdKZu8dNZjx1pfpoQ2XLu8vIiflJz wu+pZ6t4dcxmxag/Ij9g8bPPKy7xhIUMtF4vD8ZEVWOoYPfnR3RoYUHzPn0+ Peq/r9A5buMeKjjUcT/AFEmq+oMZPxpJx9keV/kNUk4i5EQSDm0MtsfScLg9 rmvbh9IJk/YQC0jx7ogDDWJcmy6YYnTBhxP+yKvzyfACixJSMQr6C9M3XxDx mY6rixHi84VW9rvgYOuLsoIb/QLdJy7gGluUs3FxgWGyF2joxUvvQoJ1YKwh vBiphzlc5miBw7gozOCBvhotAzzA/ezsbHC2TbTrzXcbw6ra7qtPdrVx8+wE WI5qlg9hs8LfuLL9t28/3Nl8+3bx9u387dvJ27dHBzpkY89AvO9sbcDqqRIP pgq+SSJUH9bbLzErFNrgge8Kf+MwnUc7b+G/wQWMd9Y/uNj/8e1mH4bONw+6 6zogFkNEul2YO3m10zwLt7RcPwrrhVOiD2n33r7dR5rjFg68y+1Om9JW2izh WRemmbZk5vnlTDi2zjCfYQaujIy70Mv+7R8/u7jxXweP9rrNn7bDsli2t4rw eBGGCVTZvvZ974B8qsQ4bY+3M3Jf5x93D9o8gUc7tzoBvD/iv7cOure7ty7e ttMXb9v45m37omnx3YumFbRvv33LKDGriuVoShDdWQG8t287+IYX/gZd4IFz Y6ZWrMrAWNg+EQdOGiq5CK2o+rz4uhwvUOrgeyEINjvc99Yg+3VJ+e9tQ7Z3 A2w8oO7RRnU+HUjdC1vKnYFmNLfhPuduk287XUDwgwP8MnNIiOC57frbHqCg zg5zpPdI0Gpwm5u2u2/f4rboBc8WenZXmE76kskc1Usl1nt3e9eT9eNTdM6j 9m5rsaJcPsTUAwjioewDVhRDjQec33lEJ/CuZnmik5wjOL1Z+5jECIvT8K3b P9bP3voFwu1HgdlBV4EIMGpo/FkYAYbAALf8GmPc7jU8k2lCHyCo54SD1+ip s/9w/b94T+M3DbO9rfO03f8PxNPaOHuN4wA8Dm4B/t1+1NQ1HUQHCj6QSc96 SmmhERGurzM+wJ9Jv8ThIdNK4SSAhM+ftneSr282EQCG7lr7yTePX7+ufQL7 e9lHbx7/o/ZJQ/uL/dsH9s3jN2++q32UHD1u+er1s++fvmxs6wEGc//n82/q y93p0N1MNoEL9Ay/mCxO8P/38Ue336EcORfA56DwJJSwgZgivUbh9GI6GsEZ 2F+Hq7Dbeft2dLs7qVPfjKi7tFrRG3y7DhSiGV2IdGTtUuGFLE0dyHznGbuD m/KZ/0w8v9HhG+jzmML7UZdCBBGJMpIOkEU74iP1A2WKZ50cMmmvQKYnnBLv wJ/5AsDY7zbpYETAadydZE18EncCEItfL45hS3hDwv6ELUA4pUCFl8B8jLqP CPKrQNd5tLf/I4D+MwOicIZzyqJTUcwYdEW/hDW80OxAF5zPp/vZBgqDc06q Sl+cvB3RQ3hqzPrGj/s//n6w/vb3t9Xtt/vy+O3Zhvov5FU5Pu+ToxSykxvA rMIWvCfvk+dP8baD44P/0NHLHCc0/xV1q3Kaabo3sUxD/wCwpvP2DP4XjqU8 gMnStNB9m0NVN/YB3DoLZFf4xqk+iT+UW6ofrhwYYzmRGhQJXaJLFO7QUd4/ Ovh9q/f5x/r2PLqonS3A2YsB75PcRUduhCBo/KR1N0b2xw+hmyB7YJobZHQ2 P7St1PIo62ebH7Yw+cguY/qL/AUIbnho8HZFnxAqe9SKPWYk+vzBnbtyPqbz d/kcNReknpoU5KCmTorqj2cpC9ZxEkFAoZmh7Yz+uLhoWAbZqHXOZLynthRj 0hKP3a++fZX5Ca+tiX8Nhpg9gZ16Ai87PMi6LlvzEujy+PjnY6y9Qvn9pD9M 6AArO0YReJaX8+4VAzx8iLH4FzDM0y83N7mEUfZ3+Ln99df8+MnmZuxug1hO /W24+6ECEObj8jeJo3Bi6WieH2GwfVWdHROqwl8got7kcPm+fojuj+WonKKt dD7EwH3BoA3ASRBYPmwdvf3wxdHBxY/9R0A/4J/PRJSRN/23y6/hPzxPGC+6 duQ7cS5FJz0QqBECrwheXp2QPG4xuL9fpw148f0334DoANMGAvz9Ogz1NPvu 2atvHj95hlmysyf/fPzd4ydvnn0XzK6iwnu72U4F4DZN9ml718x14smEEqzn EJHf7Iyo+iUqlpYzwEz2KwUKZ16vaKZRrMNQWHSRInSonFVjeMIKhw6I9hQ+ hWcXWG6sN3RCdY5x+Y/Rhf9k4HWLFlzfybY+58+yyEPtJVsBppiHkoxirIgC 7Hz8+snz5349OFO0H1ZYOUa56JaDi8zHIRwF/ZI9+QhzdonLVkGRmKpf63RF VD+dmuHdNOBnc4ydR7GEKqjkWfsVGrlIlM+egvgDsj59ziprUSwvJ5gb+59i o6nZiqLBdbaqc3g8GRYVO1xy8n/heTstn1nEa0a0OhA8GmgvhD2UlATVvW3O zSyWWXK/G2N2I3vENidkG37HRGA7WTskBwDyPIHrcQcV48eAS+3sYwv9Zlok YC/KUxQBEcbO1QQpNn77DSrduy3MUvE7a7SkAYzUYaWYN4R5dSJXIcROgMkj jmbFW5pMk3PMg7uDzZbzKobbuMBKc9mRyF1hPqSh2181vsXjDjDdHtop0VLC bsawFbwPoq77nY26HPom3z0SXP8GLenozsCKPDjoGnUV7S3bTlGxZjZ0pyS0 qElp5eAHH6j5ECh+cp89f/bgvjtyVP2d80JY6rerZkG5diwgybu7rIkToNCi HG00gH2w+YoF0lr4OhTJs47EjPyyvn5A/hDVfgl/kkGEbPrROGhxQZoiatmP ZIOzc8pGioaMBuaXhv5LGrCCCwnBrIDfJTAWxOz2smO447GMM/A3au7AJcLP J2YUV9MuhTTRn4Pp2aSYB5U9Q1rRRaPvyW55H2ZSovJYe/EvVXWOI+rHYbxH Npy93Mnu75KpiJ3sGtztQrhNQbEAFI2O+CKe4uWEvIkMdKSFUd9ab0W1Bje8 JwGMc8PekCXK5naDajEBkKIn92tPtrb0zjTHOlrDrsULvZlTtevqBFB5uFxg 5MYIExVyNteKQsCnM8w9JYEdqIaqyLKFxhEDayUrumG4oBd4pwHI0Z5yhUJu shNRCokdSFM7eSof5dcgxfWwhkxpChiOnIuMPJ61kLqSBvoSy+cdHZXky4du ZCTo9ShDEGdbgcsLjtPtr85vtzEljRgvpLuO5EmCdjrrr4FW0YLsKHEeMora YsMHzA+POpniu8a8pJuLVxCdLkRPk2wGmKwsnFgg8iGMD9f31F4Fx6AO6qmo q/2tAx/2R9FsAn9D3rXahPYI/0JIIHdKl6JtBCZAkjw7X50/H3Wy02hqaylZ 7bGauYf+k+/KhWv05uXTlzuqCTnXaLPKtYiHIjcNBpTlczg811gCC3d5/lR7 oOnTvV/yjX/q1ramRME55KnLlGMnw1nj/z7KH0lw44rmLm5RFhKD33ppXR90 V0LuTwOOkSJQdERQQYLwtBkP/v53BYgaUjvhfAhXFtrU9yaA85K9WQVrD3KE EqJ0dEh8tCYfkzsHASU8g2a3Yh3rq6/O3+THLwB4/nTa9NLJ6WyeULneldNx R3f7gAKFxNYej0y94NgGxcYJhmYBqNdfnn1Nm7pyZQZ0k7I478rofQ5bf0we V+R8oIzC4/HYiKCu7tcq16XciEzX+wG4JBVlB9quc8NM+XS92q/BAkSDFSSz gfKGnW/iXnbtlbl17FnXYVt/hUmMp9N3Fdayr7CMfXLQ8Voo4eSJn9cZOiqj 814uGgpKQJRP3hF/g6w5OhCgMLoICbvOgnIFWPUT8nHzKosQYfOlPn72gQu0 i4OTnvsa3nmO6UXN5SlOZhDdJ0/EtsPVMhl4z58iG7mga7JcsLc55dwqMGFg jlnDbC86E3KpcwhoJsVO1i5Bjup2Hbnm1vC/LkrD1BAYqWMqCUXXNPxcBqpq A/V0LuLUETDekW/JqMXOvoGrYNMeGuW5JbPHKASI9c+jo/SKwgC38+7NgfEv +323cG5JJv8ME++vIxDkSKxjBJl038lCyzD/BhyWoX+ZliDGtHtt8y1mtEEQ 2IYiBqri1Olfa2dGtau1E0h5Xwtz9wn4FgRol9FgLTp7H/3JdUsIQfUsN6+k bnpfuEsrpUdJz/KFXTWNN02QbYF4sQeiTekj8t7kvBzxUBO55NRtyLEhChB2 Pq2dgdrt5qiuTxkAa2FPscoc43gXwm7U45s+20K18kpZkP04b7OXGicpfFec 99m7fJhT2Af61En8eQXojk3/3zx+lf1u4jJLQz2hRt2PInJxtIb4clLsIBfd QgWP0BB0s+TUJyiNQfdr4vgq/At20CENcZ/4+w/FqKsxgKThK1kQoOlStDxK zeLqQ3w2vfmGDmIX+6e6Garp4kpzGaAqEC90kDOROvKrUqkZwFNZ5ERoSo3w ZU9d82n/xTmpg7EDdKC75BX/HiOXhtMxUBXSsVF8NFtPQtiyc//twG5lzzHk Nru5de+LrgpHOBlhoGwEGPlhbdmKjprq5R3mI+HkE+RcjmmICQQlZ73gyiK8 rH0epjopjxYAh4PELawTGtk1vsdA4ASaIZ0WtPMI920+f+fjBYgUie4TLXHA wLJWg1COKglkv6vH8Ef0cn/jNZUAWCwsF+8hPkkc4wEQ6OysB/UgeLuZB7uf pdy+ROM4/SAjnl64Kyf3ihL2hFTOLsEaoq0eodxSHvHZjOePfcwXYeZUwn2c uaIDcV7U9lFZjEdwA7aJ5iv9lJXduHFEqlO2SSiRK5r9byM6p/rhgrUnJdbN JvqOuyT6m5bJYzHtJ8yLHsbpVmU+hFTktUx+ryBhn2ICbdEor9GqMRyGkCrs z+PRqAohABoWoPU1JGBJfDtRww/kt/J7xtr5j/wie1XO0CML3+GGkc80xlOa Yb55u3XYN6YZ4Hg1CuA4JD3juMTKEdHejkRD3uHBe9aNbTVriOmt+L63L9pd zeEVNKy413XmgqgAfszDUPAnMg8HlMuAhkqA+QQdBqugyZmSGykC8WyqbEIE AsE7AF/j08P4tmDn/3A3jAsK5wPc30QmMhefHqB4h6iHRMSeR++Pppj3taJ+ HSRlZjR77+lKEY1LBOEhsik5pTXDJBB79BgfDSLVCKlqDuvPEIPzQTVdzofF c3QEzfrQzP3eNXMLcum+Ic77fV5SCBDedYdTSoZBenvWcOGEoiOIT4Lqj1aF 3Rza8nP5FBfBX5pKmZcL/ztAm8VrBoyx2fZV5PsbOZFGbIfG62aPMgzSxQYB Wb4zCuZpsPhbqHsKxzJq9Z7Gk4cvmm5echl/Rf1IRAHNV+lUkylIE1FIdOEK mWc3gJobowhEk6RQAfrSYg4WZO0Qdfunrpy9KT5p1V/RJ//Ny+7U1g1idngm RZ26fzE0dooJ2eY2dtRK5wEjEUIfMzPhkfmOPtRHuxLn4ntrAuJTaa9gtC4t fuffJ+glbh2nWYd2Mr1I97XJAfBVbADcQQ8qcZrqTNbvdLOdYT7RvCqXbVUr sGBDuNfzchL0dUGFpyvL/NL5U3UMQA+VAd5qA1Q3iHMAu2bnx8UGZwtBcY1c WVQ+6CvI/oq+3MSIrCQ2VqepZwrGlADkFxIl9OsJXgHTCd36qFUilxTbFQXO jvR0m25kNmmf9oE5mgK36DgrSWscdlU2UT7Prrtm7L7i9WJAxDEwIn0e+c/0 NJ1Q8byjwsOOlyXVr1csA96STP8XDM4DpRN4rIUWbAJSAkU2VSWygV0iRBYc m6eUIrK/h5QgqrR6mayTwg04Ulj4SV0rWYe5rEtQEiRW+yBlN71t4ELXYmcB x5FG8zZy06hnWulukH7mdRyJHu9zypOjbyivFwmvSriCpc+EYczNYwephuGY xILcJqpWOkfXq58l6mRMK/SDGrbmBesx3Vx6Mu5pPqFU/vLR7ewXkAlhx/o/ bG59yemj1lTjH4ZE/eING9MsA6m3hxHJGiAZgNcAOlM1sZSelROg8KiyDcim WfBuURiD9XJYHGFILpnrVStgLz3m4x6iT/r7Euj6KfvjDPMlBvZhBOESMyEs sg5hYU/uih7IA5MlpVIYvutyZDeG8lLlE5gJd4t+oWxElBQDp5RgH0QYDBiT s6hyIsnWOB+v5V1xMq6FqyGF+2nORS1CNvU5BpWW5KNk19IkuZdSyfEPMQfq mAWdrBKpm276V/aZ3vUqKluWDacB8Bl7jr2x2n7uZev6t+OXVnSCSrSe5vGI nERYM0lvSAwgT3oUvjHTAn6mziNuIsGRxH/n88ZQIq3YyndENoN8kYi5JX+M 3zQpndlAA9PYzzq/JAOChNjNnNGMmv2CMuONjiyVf8qLWhIKUi7EqkUWK3OS e2i3yeOiXJxzNQOJsFXDaV2SvGAN4t7HqI3JlXGrC+Mk31C5ERQ+aGAUxahe LadjmAY3IMLdcz5ZMZY1qbYj/HKuMHG+iUaDYq1SVPCg0Zj6Z1xCTLMHUG6+ I3ZJeY/+dkAwW6HWjlSgS4rvCNzZ76vK/vXtNyJyrgTtRyYbj+1upjTGwR0n gncAMHLoKL/SxyVv8aRPrho6KMGTYofDdPVnkzQDINBR1dAGHb8HvpEwm2uh oC8iO2OUWLWtoKD480I8MbjSg1ZnQ1dE0jWzCyRrlOD+vXn3y+3tLmsJ0hEl 9FLt4nVPGHIaHCSfBR1i2t+j9InJaIwRCLE2SNhCQ90evsYcp/pxH9hk4ndh ziViMfLOQ06qPdLsNFpAJdq7FZu+D40Okl0P2h9W2wu9RvcjycXRjBXap9f8 N8xlo+UcgxwGRw9dNRNj36TO1ZPpKfJtPUzbynkESK1D8dfU+BH9U98yehl7 LjW5hwGVwM6wCpw4hpEukVMaayRty7yT+DZ1w2DRqcTfC23Y+DjFiljrY75P qvn5fjZCi4yk4bEtD5HvrAfetaB4rxeuo2biSoUpufAYdpzj1m6S3ALOyf2+ 5nNkKxRVhgvHKXiWiWWHXX81q017FryFR+wtzJ7CVSZVlLObW9v3tz/XTPuR X1nkVUasY8c2PVorK6D/syzOxLFCGg0W0xn1Ej4LYrhfZVijOi9oD/lo9Azz cqAPZzGxikdrq1t0kMAjENq9LHKE7qlAtNswA8qcqRkPI9bOjUQpYmiwhmmE lzCD6aR5DqZqJxy7HYKXAa36f8l/eMJTLHrwJT35TyTi58yHe3cASqIyPg82 kRAHxzGjC2cNayXees+ffWlRYF1LYDGIYqnFjOKvGwFgMR4MzZUG1WFtx/bd gLeR20Lb2raVyyEohqu+U3W/Or/9l8PSlMCNXkrt2+2uAY9y0ARvkEYnI+VG roBMVDYvsTg9kfLj7XY3SgguMGueZHCH+NhAa9A/+wqfqL1Mos/ED8Emtco5 qmGUrc1VICVXOoVj6khnlcQO5+j5kX4WO4TOMDPYcoZoewxk8hRrTnNwB1yh 2FvFqSsqvlvzjHx/8kOUV6Ol0CpwrRFoaMTLNk8uhHgH8e3A+8H4bWuGJA0v 19eK153g89Cwvc+fijMyneQjyjMWuYfpapzJij/YxwDeg4gXKEdeyMITTmCI XIY0fo7qO0UOQ5dp0GNJOT7z5ajNagkekJUSREV3w4wno8b5pgnrmhLTJX6W TSJCgxf0mkDhCt/dcqQeJm6BVHuJ/jiQeh4qu+1GpXKbduN/aDvIpIEM255C q7YzpNirA8upodLWvJcROCaivCSWURI1Nm91/cpGJd4XemPXfXLFHxBYduLb WNQlx31V7v0vQJ8JVWSVQBB1qLoWTgVFQqTvX4su+gIb21XM72Vbr9yh4NHZ sEHlqK7TVZyu+/Z9jb4AlL57OqnT17DoqnHVRujCYXLxPs74KnCjnkIoj0zy 2su+/rpXLDx1JfP4nh52CS/Jj1seFTGrAal4LmMeMCjXh0sdfyK2XqIVSYjy 5S7aMLLio4uCsOANUnzItUya1ONnX72heh4xkx28lVeMXvcslJEVnhxzdjlI lGTzSeP0o5JW2aXnpVDnc5jubHYOPZSTIYYCYHqUPOsw/9HldVAIG6qIMByz eemL6VSWoyFSnwJPzmhDinQrkTZk3q8KewyfkOX4dti79FTI8Om5CNakxOsi oDlAqSlMoAm9JUMrv6v7dn4UroQYxAjjOfnHSpz3Xvk+IFofp/t8JeaHDq9N ry87DM6hf+iZXw0VJCnlP14/3hANrqLxXy6ooMs+cnrJOJablBolLzs7WHzn fYEyDDaqRE7mwn2oYuw8f3Z/g0JlQFIfYGqkKL+fOWSSu37e2aHsZpd09+Rk joacO1sc+vxDIQWlyRf/sKBgZy4RDMOwwvDLjfssuGq+3gkrMqgD7Jqqlv1s fDIvSXboZy6FjaoT1tPlE9GfsHQy7WHEAM+BJ08ZQTnbOSehJsBKEd9FeVoE R1J8AtxImI2v4ALzrwaSIZKy24FgUiw2tra3v/jSZUw0CLLnvqeGK0WulB4G d/4NrYyLPc+L4+KDGpjgT/TdRZv6eZaPpjMy5qNL4dOyOJ5mr4BxmJRokFkp 2vAKx1KxmVSS06zA+jdW2HGSzZZz1KJL8ze4rSVnLEdn3+fPbsEPFGNZz8k1 w0GMGZfDkuOASTiTQIdgeqOzhw6cenn3tCkFtJJbJNms4Qeb+NDSWExwB6Xl VRtzZ/sehilfJsFNJsVcVHjtBzmwBHu3KN2HiGHrWfvWwwcb+UNJI7PWflAJ vOot+5g/71Z2WhHySTqvvVu33Mfim6CqT3z5YIMfwh/8+GHbLgzHIX8p8W1w aPtbdwZbn0uTF1POIRZApJ3zIfW7WYnXW/bjHipiP6P/vb1nO8vScdgRS1O3 nLybcCZImQSaXttVflS0yYjwQzn57k2yKafVaDI41VI1XPdo0l9WG5w+6Hyj LDZOTu5+fm/7yy8HeTX7EPL4/VQVWofA3GBrHEN7Pwb0jwDMA1OLBMbD4p34 2mtjtr6Dxtxbj3ZuYTK4t5SRytnLk42QR5qFOVGwtYm/bLO1F2vziL/ycDq3 wHiJG25elW7fddayIq3hox2axEUtqdPqdTEVf3Dnfs9lPLjby17nR/m8fPDF YHO9h6mZ5S8rD/Jga3B/8OX65YsCoJej/9pLjwtWRLtiiW34Kpkyh3fKDdbP diQxpx6AKJyD/X28l4xD0lriojubW1sb3z170o9zZ/bx+eb9O/c3bspY0glq S+UG44wdZERDJCBfZdx9DDYYs+stnKzqir3XtVy5867liv3kfcu+5F3LeIdS knlGoKTlA/TOfoKHg+Fx+Qho29b251/e29KFTvroA6Vpu6bzmxjiz/6w/ZBJ z2JnfqasGFesNmvnNxOMWL99DYwY3BysY06qtpMWmMW+5J6DCaSk/mReHAHJ MO+NvVv61wqK39iQ0WvjUuLNRoUq+zJ7wYEpj2ezyhNdqqyHynnkND09maM6 H2k3ofKIczm6lcCKy+PJqfh1UcZcMtGvjmlgF1WpyYJ/pyF+OBlMosXZapVg pApsHqabfowLwI+ftp3U00A7n02oNiQZn+GgTchTFF0YkH2IgHDFFYCN965F KmlqDdnkLHdrjTZ+/XW2PbiHJKbma0u7xRAKuu1O+gC3r1ogKZAOun+ecDTT Dek/gAEFoTurgWEfwF7Zoi679NByuW6zB44vgMLCF9F1gO1LorAnozXiy7yg NGY1R7vqcuYsOFlZDu3LgGDr+GuhIFzXJkAgLJFL63IOrEWfE5KqiVs8seTY 1Cd6u7fzQU5gStt6g9s7/Io9f2pCRCoKpgKFehUxBSC46hMKG9WHTPm/TXqL mpxOf7v0/fTyr6vkddcFmF8ukDzRIjB4BmD5lHPc9CWU1yaVeuXLqXj6gmgx 4dufNH8dNAnT2VMw+jbfSjIRrTjF2aPQ65A0MEbGSPARJgOvNw41RNGVzafM rkLDf8D0pwFVCi5Do6Ywlp8lkQR+0TDufnUDmVlAk8zjybdRTaz2jT1AXEtd GiGNl0UDjsmpQEWoy7cY3lOQMwZFUW+pViCew2V9aZuoP9KaPJE0F3+lqmQt +LE0ydeEjUN+r0o9dXQ0k6Y6kWgaDthW8mijl69Y/j1aolkdg2v7BaYLqDTv /WP0bum5MMaw99KfBOWGegkUNGazvrhYOW1p3k0UxK4AAduLKE//XhqCdT97 BI9ST5kdDt5aWztczjSc69D5b3uLklQ2gIZouLzRoT+x/XLWEO3VoW5pMmHu Ui4xfsodaS7JtXzlDlFc2YqX2snfM5aGu5aubBWsiJge1tWqhwgHB4JUp3rI hqy6mcTupVqweb1Er5yB10CAgI37y7WF5p7FgYaVDuNLWDike9RqglFLa54d s2u8lbGgKNN8rOrY61W88OUuQqUs9K3EcGKO7SQnQ1LyQMfkb4Fu2sxfnlAO yca9b0mNRTv4N1bjUD+7cbjq5a6uSHtKFcT01M//ST4ecqEmdbOmgMIpZT+j pMCHxXhKKe1DLK1LxRamDGCse9bl4rcPSFd/eSiUYPWBYfTeMebF/HLPigx1 OFyzG8f3dyC23rK66ekFWqUwggMnWSg6N/RKRTR7WqDbFIUmZCsh3rElSoOQ d4Yu/+lUIjg4IYrSVNIXww2sXpsAXYwSMB83D2KPo96dMAU3vo+c5MSDmCiU fwHUPZCEeoSnJxJ+vHQHP2G8w9p4WzFb+i18RHeLlWmjc+9w10oFCQnuaCGX TnjVo83oN75BRFIKHU5wfDAAFe5q2Vkqm4LtG2kveWOXi+AYShUhyKiG/XB6 ruGfpzASp5zU6MzpqssdiafHcgOmj3OyJMIU2Jh4yD8PMyvx+YraU8h1WIKE dgQnTo4t8oeMtSG5XKd8e3lyk6AsA5bv6vSNvsDOfDv6qb/+YhRo+WSBYeEa zE6GFwy9HGEM2q+homMrtg/TZghbEa+/Kfjc096InGHi+Ay5MgpkrCQ/QTkP 4Vvi64+YWlZ0Z3BId459NoR5NzAA+WywnHC+Dg4RFzug9HR4/Z4Om3vihf2Q j99lxMSRTWqO0v90+g7VPUccPACINC9msLRzN2I+0+pGh/SXsjlYZDE+ryVj APEJWOBJ0hQN1XEv7KhESHFabIMlSU/x7uCIPRu44crh/iScy1AX0YtpO8NX VxARxoDRh6sayHsqpbXbqkULsOO/OMQHqdjJnFiTLShrfByKJoDlJpgoQ/83 NG/q34nlaelu7MpiMrAOZ1SjjdN+FSNzhhczfmOoRNaYIjTKEGq2ffFJ+RZT zVWcgCz3Bp5QiAcPMtfToXptc/Zs9GmQknImIKfu3fps69ZB2xUrXKWnqBvi ybksTWJHA0cJ7Dqase5bU2MkT0RmEgB3k89QBsb/mlLf2SfCf1iGrFBvPhXO w1aaXgCVC7eqmpE+lvfRZb+JrWKo4VgwwdXaCU35xdLmWYGoWO+PiXFeEnN0 WEjgs2OLqIMj9Wjh2J37/ILQzcUHZNGDOAhjayvlTbh4vbruuFw4ce6L+FxZ ZT85W+ZGafq7h3ivu2PmxGfnN5IkzLz+EbsyNe/VB82n4v0YxbE1ZvOMVoPn qYFShOKr/+OUAvGeijPXst3U67syb0T3CXqDYfzuEZoaR+jjzeFLg+YEXCFW 5ctNyr8FciVFdCLacbVDOW/JNHpN0xCB6CiCXy84WZvfD90Wrnaz7RYOj2Cy d9QjPsVPGmIgvA+3dM/1Nmr+zrqZNHaH19nstIgNKSMsTmcQgk+Zb8Nn7LfI vBjnbnK41FBgolKlquYpwQdAW9vd6ySF9H2TicJ3fVodc9esBkcNIGX262Tt 1+eA+h9U6bmczIvh9BhTO45c3cIdysZIvUTxeU89j6A56eZaS8GUEVHopRUV /qjOaRQXJ3PnCtevOZwzLEDd91weMHYjDGOYL+EvKkSImyqHk02I+Qcu9DZK 1beN8+XqAKEbLPJRLTn1Xjk3j5ZWKtCYHM092Ct0tQtcvGuHD19T9C0ijWYA 1sIarMHVh1NMexb0QOG6jiaRZD+6zNUwuCojY6ZNgMkMsc4ItgAG0VmX3sXT DfZLiKe2Sc94KaGP/ewXIDrozai+eOqAWJjhUzIiCvosppYBjeMvq5pP1zEI bUvSVUjtX6k6vDGDI7Zx5869GPx88Fo1d0iHxN8vyjGaMqNcfFKtSVMi0J3B Bxo94yYZFWPGvzGXei28mHD8QvS3HF1MSC71hEPgZ3jQFApgPuosFqAdvG2I TXUJQpWAyIvU8OWGtTCh/jk6fFmu4B67/cH/wWln1oR5EV2jxzDnxR2jF0sp 7D2TY75uc5MNjBMuYH0vkxVrbKtihpM2EzW1BK86HXn6xNgbzSYC/T8RZzXc S+dKAi3IGE9AX1boI8Hp+EYaZl6xdpMt20AnQYCK7sCtrXvbloPSR2f4Ufd8 jYSGbBSu7W6QtRWUbxSG6FKn9li6M6l8rnO0H5BYRibYXXqwG711WdA8Axht g/Mq/njFXmzXIH83juI1HPxPPCnMYQXUKCecs1kxA/NezKcWUTsBeC35ADLO tCJmFQ+slESzoGkVhfY0sdUTwFrE3dEvS8qUdMhhGMsK9WwuJehOdm8Ty3RI Gg0yye1EiS6sqOJOZrUV8VlgbnaAWcYn6EKtf5Ous3yP7wAq7Ydt+KOppA5t 2w7741LhHRCgGpvK23X/dg5kabqsZGMbe/uvS9pjAR+arFVsldlKZUbHNZBY IIijdReyUILh6kgnVX1i7kzciOMSc70wHV1MLSE8Oj6SKk7qw2LlwonKtjr0 9gFp4O0H4CL/fdf9fY/+bqNX0rUmF+fKp2OLbm96WNzInJDaHlgpqzhFD713 1bLuZlpcqeUKVa4A8cZtS6dCXsGGePvy5QFNaov9j7i8JZZQHAwGnNr5Dudf Typb0qvtkGslFGJ8O7qN/39C5SqxKOWj0Nfd7AOWxzudTSfiJvxhsn7uesFv HuHXF/zBvQxdm7hh+JBefZ59aHz+hX1ynrz5MjtveMxplpowMcn1l2wtNAhb si3GjDaALuw0YCkmtrudSS3vylZKr/kytd03s6LnuHW0TctQHtJfaanAD8Qh n2fEJxRU2AyJuos1HNBW63dwORVUg5nUQKSa2KBzPswpdzHKHUhwxpT3aXNj y6HtXYTQeieckkfhkKyL48n+53RgtkDiye4AA+POF8EIUaUdjpc+BuRB0Mky rVcaTrv44sDOy5cIsRWdGJEg+z0nysR74aQ8LBehhjSdtFp9C7cVl+5E/Yy6 U2l1ZlccSxI3PuA9xVZ4JU3I3BsQgaVXMpKiX3SCRZMV5pdqZiTLrzMcPaa0 PUobDSIgp/TLKsF0B5BA1S6hk8HnD5iVmSzTl90jQmQrXrkd1gJFG3ZxkZXa G6uMQh43Cx2LBrBi4h0QP5fzijCayUpH2vmaA9pnj++8ru+a6nMMCzXmIguU DcdT4jH4YgX6ynBzfWuPAzOqtLuUPUIeW1VD+QLtL8nLuICRtOOsQMUxu5FS 525zNsPmbHoSpYPsphtpQ65oazgjSV3IPC/u9pWooZQpkkrUEqAuxv2Oubbq Vncvud22A//OnJByEy0rDh3nssHIrLTQgQo5kuIgbXbVPV5P8+qjm6MBNUiP VTS+LKM6oZOVMvsoSpsV0dk1bldD46IHidYLx9ZXcjl4xkCqbzcE13kwzajO O+r76LXo4ENTUcTvemqn34hGuhP6iGr4dn5cVSs96r6hiC/WWnZHMMwsihC8 ApYyK6EZXqxyCUq8UKXgDq+Bnq0Klm8KM6zr/ji/SburHKRsk2fgaiwy6y65 Fh3VHSTzXCzxXRLkz+qIINKgdBGrlX2oubZmrUYNhjoLBtSNvbYyIYGBsSbp t8EtykJKaaz1PbskmocBZvlRmNieAEC8xGozCm1vXN72R2rLDUxbFoizghnb bjb3cPt6PTwMlvikg88aOxDi16fnwYf9iqX/F/XVESFCugqELRyonlSxkGoW nzLfi+atQF/FaOqbgqU6+XUKNw4fYKBPW4cwZ7iYXNXkmAWpklD6CEkdRTDt ZVjc3ZMxLk4oyS0SzvyGcubMawFzfJbPR0nb/l1tiV1L0+mRaMJIBmIOkyWg dkQQ2UvJXCBpcoxHj0K2Wis1idk+STDoTLrXuRRu3CDCkjhnanh8+rkrTvPh 1J1o8olBGoosCCrEn/CPKdCpufzNySvwfyl3ZS+rFvl8oVWBQPbHcG6GNIJK IfkIwBvUQph2r65RkD4kKfFemi9Y30vWdQH85RegfrOseC3IPOOS4asb3EGY OdUoEMzjh5wdjacTcm3gTu10aD8vcBsvkN3p9pvEX81sxvBwSSRUt4nwco99 wopde5gqQvGfffo0SnahowlgHoXH1O2lLAKCdKfpgyQ5gGuS+q3Kfx9b9b+I M2TdIpf9VXX3DoIOpF+sJ3TGSXc1qeQI3Turadc6ITxDYwGhmGXHb2MXdLXe 4BbwV4RqNjebT90n1/KW2Cj7DnMZA5zSEzMa8jPcf350sOvQAxNyIprRGSa8 6KCGg0owFZWUTaLSTACIn7mvnz3G6OCwGENdD3+2TrzLfkZM+ZmlGSrlQScK YDpkB0tm/d1XMA0y9x//Vs76R/OymIyAVz/Lz7WN4BjPyWAXKIDhXyjmA7S+ kz7DpKhWAq1eUu++pvDRt0+LI6wKnR+jPZxEp4lUjqkZhI9P+ltfbN43zHCk CsmCzXSf87jw6+dPaaKGTZ3L2iWTH0rXbqB9RsADrXjsgMclSPa0kNNmdiDJ n+cgSVTkyslvtkLyGKU+4fvQ7E4W9582E0wMlcP33fuAlTUqsr4edeNz3whx CdnK1yyjDyX04Zgb8jrzCEhezHh+ApRr64ILjzhdajeYTWedpM4teblhQDpl We5piTFJ6OyOC4mLh/Mif2efmu2gIeZgfZ3moiulunHRTZqgku0w0gLZvOje o+4OHOWjuezWyZ/RlrS6rdiN6qdWfZnLWjUb/ZS1H54yOPBdecabr5k/e8av OOR/8pT/sWP+Sef8Ew76Hz/ptaO+W8MThFTD7eHeKnuI14+/X+R5h150H1nB FP95KIAUl4tw26S1ESgkYTydziiP2iGZU/joX3Hu/xitCZv2B8iGejn993E/ ocIy/CfkJOGJyBaIOLRQmoXmhCLH7PGTIRA0wMVwvt2Hq8/z2l9wMNeuPJtr f/p4rv3RE7r2iYd07Rpkukab3eFac/fEimugRss9M9vE4Vr9cscDPocNnwPA 0WWGil4eHVXFAh0f4HJjmdcAfT4cF1zpkz+n+ff3SErUWbhCZXxySaDE7edn f3Mi5iY50uLTDXn6cE+cfcJ0vWjdYIxgRW0vrdqAS+NXfVJccWZVcimlKH1Y kMTpayagxhwaZkXfuOl7KzTfwat5OZ1DL79RTUrsOfPx/+WEnw2XwFKfWnQr ziIfobaZgm4B4Ys5tRsXqOjTzr+LzFuwK2yQrrRWkpgHXIA2FwY8FlNM8H2U Jvuq1qbzSG9Cr/oy9Yu0UxDbkNqAwXxSC40RZz84GcJHGrOPQXaan1NKW+9X gJQaKBC7bOE65SNnyJkXqpvHOjdcipYDqkg3r6ggH6JvA94DUjgCY1dbepbi 4p6JaekoKv0RGwy+Wi6yU41Q0oIKKBlOxyOy0uZkQ3ADBZ/f4F2MO0MEQHFW /223Hf4KPZBZJZs0YIfSV1J6ptO8Z129Vz6lOImgTzn6YLWTucUo4/ok/FVa lGTN1SUxa48Sg+aq1mswBnwSInTcdEa+hLVUGME5ZVxlRCcdnjV9pkkuLSB3 lVrK7z1rnDZphVWgQXUL6dHEm3XkaO2oi9WrKfotlZS0HM3zY7hcwwltT6aL duxLE+1LbPwhb6dSOBd9N5PisdNMog2kZUj6hkcEhZ5xwdUtUAJZzIE1pwBa TkqG6lQ0kmYh341REE26osknQ3ZIfcJAp+ggnsOVhaaVHnhbWTH3x/FR67oY e5leUD1f8b/lJCCwDKg9sYs+fN2DNQVURkx2JXhcbfSktk7oGsj+z9K5qEaa kZ75PvE/s8+poo47GYTvZVxRh37ihyvqgXcbDXKrgESby7ZVJ1cZeEqOlHPw MefiXQMG+8hbpWiVAzsl16G+c18ZLjeYWe6DMlh9Y4lP9ma/Lt/2QOuuf1au lcJbIzb0Yw1kiCI00mlo+MPqufgsrgt2WJWy7n9R6vFO3YlSYiIGwWETniR+ i95EInN8aIG+bomwpe0fxMnM5X2g8GQptMeYnmc743xyDFeMQpC/xtSYVGem mo4Linn3iHELC69PjpfoT8p1lOijw4Lqif26zMfqj8Bhs0clzOOJxGNgqdTi GFaJjYldShtm5elpMcJijzAyZwTk2bb7banNRsWXEcUpB+QRfKM87WXTxGXB NYt1DjHjXcI2js9d59F8LF8GxR6KwzDXtQojUOxHu3Ut1hM/6vMlggiJP1Nk dAiEr90NQj95PZr/UCcTZm2cy415eMj2ZvqejL6BUl3CCmJzZgR5HuY7u0a/ 9+jxH3dbuMRcjA++gc6ZksCdohTPKO83PIOmYJc1iXehSe74J7EVHEgiHQE2 hDc04JeR1O+G1j8bFrgWuU5w+z0Glw5FX9qJpjdsjxRbbyw3ZU3Jx6NQXm+U 8jqEiANNjZxGMr4tq2ExhlkU0yXxNgvgnIpFJJ35TZIiTZic6Izr0oynwPZL WpTkETK6J37j6UuOqDInGzXNMiEcOUFxPp2unogvdyBh6M/kKpTPKc/up3zf kNiXMsiE4hgw768pey/XgYofdjhW6sYNLilGugJFL0zshz/+i1/lh6Rqcn4X LnmnL4Wz1tZ8YDsrSh+LUo18oi1f2KrG7EsmN6Jka1wFIFIrZE9ev97urUpo SQlG9BUyqJbh0sUj/DWpLRMXqkvMsB7fOuGTuAa42LBlgK5ptkJbTqLoG+vi vLeMPrsMiqGkFsWhWMHX0/xdURnI+ofnfalzJd/xDChYXTJnnk3n7+R7l7M1 oQhGTpPnNv+gCa6XXrUNpGLgYrQ0DBW2hfESc/hetuyr7kPqIFyIZOnmxMBY WAP9CZkBMMZ0i3TOmqKZo4s7yBHtZNu72RBNnDvZ3d0Mb74FFps62snudTWD c0b5gfFChz7JERe+ljiNnezL3RWBGjvZF9DjYjjQPIlGZh9kn9OGhITiLhyz c6eLGSdwOE7gT1LaXxzn0pBaHyeV+ms4q3ktE1S8xRKWcRXNvBGpowQTDnyc jWGMkNENlkbJ85mEAhBqi/lV48y5mUbGR76I/hDysb6qM06EdGVnsH8LOPeX 3X+TT6JBkwbyEy4IeiFjUuyRtZaHbmqI65dODBFwNz3SlxgjwowCwQizouHw XUskxqTgGz98UZxlyIHdcxkciFGFQ1AMjge9DIhkPh+eALMlR4EEgKbBqE9g dSQKvYExI1+nbtccBDGBErxtWhtPP0ZHzfcEIkB/CEKGpfRu0+mze7NWddh7 0joAkyHOi5nkrHV1L1FBXiwF7fPEWt/mkb0VD1L8+keHqGvYbTB78QDdxMLP dZ3GTqLdtNlg/MSfXDIprDJlfpk27sKTB9IO/173eVOjCsr1ON5IQyXN/Jwx LuMvmvLW/9CUx38Yr+qbrnP/hD2PVtnvl2Tk2f2rFnf8v2hx6+t+E//0AjFC VAM7w52J7p8HqWEHDzY60SDPOBplfAG4q9NU0DzVEjnD37N5PiqnHBopbq+H 0w/6+6jEKE7+G3XOwLCM9Hd5mh8XGlPJC43tTCXp5nlbKNhcxQha+cd4GtXy 8LRcaN+ob1pct++vaKFJ51QqO6/Os8evnnPgsmrE0ak/GFNCKe/wrENZXpzB JST92POBaFWyA7utxFIjIQS+Z9gfC+Uxp3b3pK7cRMjPq+IlBqpYzLuojkUd 3uPIH8DqhbiJVtOvc/jyeD5dzuCxBbKSVVBcdyReSGzTpkt1IRKcIZFbR2HM YUaP0Ltc2sSpGlA6oGmQPp07h8c8pYwLyoQI2wBLfYITUO0F9xOyeT6h7NRc MhJNxvMl3sIuBBEmjDLZqSRCnlM66wEcq6F1Fmd+iOLZgn4bw90p1YWYTig0 OyejCanPqLWtEv9VIFjQktF99AnBFuHUMyyEHnR4DwkyXZdKzRngzOGXQeBs Nqzf8svVlysWnVhFBpzFjSkST4Snpao14Mh2DOsURk/QMxzkqGExGeWUa9iG Je8bNDBRW0TLnQCSmnkIPfkJKjyB1QANgWZRrjk9zEqG6ayWE39Yo902SIXw Q3HOSMFFCpyApc7HirlN7ajexHAqAP1SqDeAvRHuAsxFcAgXI5G0Y0lN+rw2 JCW1Qe0UaaY/dTIJOUokgA6V59IRZyu0pPEcd0dtyWf61rxgyzxSDzJD+tR6 PUlAr4WzMks4JsSt1UB8lNLpUnb0ASt0YxW1sxbttBSB1QNKx5BtkPCsQIOF bHUjGocXs90fi6kVLJPeArm2dCQwT6W7mnCcyLUF4FEwUcoPwh/r65mmulI6 rf3slwecSWnXJ+wKJPejm2Q+GgXCoZiAUVn2sEdWnDB19mEP7wfwgKb8rpzF L1DHgG/eFeeIcfge9ZzcnDiLF9PJM7We7vE4cL6oPYpcPgFEC7X3E9XX4Z+Y ANKlI7Nh+QZ41HKJ9p1XWEXVnyTj4wac0mFB9vDg13Ydk2mTFr0W1rCyVCGm X0uXn2pZzPjaNIkV2peQh5tjZ2rrx4Jwq9deXXPxiAXT8ejJ5dE2NEXgdtSn zru46UYemD/QD5Rb6hZ5NAEffVgusH6WxRn869tvWEPXwxLYlN+ZK3QeFpPi qFyw05Mr04MMiHg20DZ4c/e1Nu8P7p5jHlZtnjftN4ZzuH94i73v9X/r5CNv Te459tZMn8UOjpc6av4pH83V7pm0yMg9M+tc9j6eMYc4IWUCusMUbO9STZzf vPoOqH3G9tLF+3f0yKRO2kjuDryLrjZsdMsOL7f0pZ6mJMjmMRVOQr7LTmE1 Nc8NDIboo+4/Pybfuan58kfGFoekHe2G4jpwG2wq8LubrPl3N5PvClRnw+fD PzGLOsxYmqInUbTOY2G0TqkmHPMZCKRdrKeNVU30hdniyWuFzoXQDMON2qIv PdpxSFvD4XbetrVT3kjI49taYPKtzkEmE2f21Yfe2zAurXE5aQ+ee9bHrr/z vAuT5w3nyHhcRfI+xYZAXJn1vXkQw+IUEKicjYsnPFLlmTMZverVsyAmnJe2 DAu9hNWqewrp55Qm2jtFfWzIn+cmD9+NgFOjxBxOdJ/1xIG1aXe8Jxtg5ffO kY1d8JKlWc+OrzxFlTmLG7PsRsj1d8mir/ZRYyQQqQooIP91BSb4FTRUa5Zr lGZryAO/E11ZwJ44C6/vPYY88Bd2fExG67ktNRYYy17pa/4b9kz+jjNycKyt NScbb/hZdy92TffiCYUXgkSuaxzddY0/V3U9Ga3oumkFEbZe6mopqNxIOhA7 F8UpYHDZCw6XAOFvc1ezHEeOH8wLqo5SkieMOv8pwgpziLlvykmJDrTB25I4 PpyXWXE/kKUbG1TisknZe1bSCXJgut225QRe6RFwq5r2+ADVWbpe9guVab2a F4L0cIVgcmD1gBV/SfKSm7/nksB44I6ofmQx6iulqM4nQxByJ+VvuXqrSx/P J16HQFoHW9ENJ7iyn1IgJ7R6GvpbpCYOw5M9Y3cmbt5yA79chpzgIjVLCky9 L/MIl2AWDAQqk4dYMp1TDDHN1iE05S4Mm624RAM4rKWgEPr2kVv/TvQttPEn RbMQWPwgPBXnv8gKj24A+AMEC24Pu7kTfTq1vP7IsOgucdy3MrL6dMcpcGC7 dk3zBBzubF6eovgiiphWLBbEKrdwjT+fGPV5ifhTl/lUvfV4NhufOxjoABFU aAw8knzNCYL4AfQ0Mi0NH3fkJMMZrU1CcP/7SZ+ZrCPRg9q5PIRlTzUL7Gmm Qbe2RroxyBn2dHYt9kLvHvwgdo0Oa9nXtaBjtPeUhgFr74rgNu2uD4Uh4Z6/ 2WLkDDgZTdI1sukJ5eKwFKxe444YBgbxnpgjT4S38GPqO1VGg3uWXbWgTsey QedxvMU1PM8dHBPXc2LeKfI/bKAUL6dvS/ZpxaQHuV+kfk+bLOrssCHBeb0e nsH/hJV3xO28E9Gn/YNuT5A0UogouaL0mcofNVwZiyCCKPtP2BoIMruJXQbZ RsBeBleT8Dqyf25/H6WRL+KLsSOknDqgTDZOyqPAAOyLMV5zVOsTh+exoCFE ZORAEwDCetfl8YmfHixLMkG1Ygkv2hWjMp400quQQTtEIRlQNQ22I/G9OtDt znKf4m+p87viENYRyZbpKWFAokh8RczFoq3j807Td0kS4G4ioHC7rwHp3pBe tq4GJpHziVJY4zx/uUQzLPE730naXLWSaRrdfdUBbx6wNwxLBqcI4nLhvkr7 0dg/66idtU2qSBtTZZpsU91g0NmdUh7kbGm3iw4mQmn0KFbRcI1LPoNQTZnd JZvhrD8u3hdjJXSdqqvCn8AHTfCxsvp6jrgexnSHoqU6BkfPHFllyMeT8z82 apx8ynZWWmqcxXWmwBbQ/VrpjFVSOyc7Bzks3StiHbGxK/qB2Y1ISXYKx0NX 2mWTJB/ejl9AkJO7jkd2h1HarZijP7YBsqvkw13hMB5T3NpJPjmm+Ay8D811 M4kpSuZqUUVx5ZaPrG6+UtQNcWzNJ6vUk5XYTmXDYnRZrbGx894V/6c6VY29 C+oTUNLEhC28tSBOY9fENkc1N+B8LmckCRcsmszMRUanZBS1ISTPmcSJ17WU oQqokO4OUyPlk/MuCT7sZ4wbOtKYQyqgsL5e8h2lG/OLbswvtjE6neYN+UXh 4TgXHwTv7r5gDLMtUQ7qIedauWTDkpbOvtcybkkKxwXbCs0xO0MXgWbLeA/d g4s5GqWMKiDU+ortP9/W9EpyGYT0byU583WxaNAwX3R+z8Q+LICh93eyA+cX mWHGO8zouYMJGz+Kfr27IkAzsifPDQAPYI80e2/TBaczLOEqwyMtH8rGrvg0 uDvEnfxCatV6F03mVWrkvKhMjcksqMlfznDtrovmbV95qf8DLcDyQdVJekBD leGYu/EPz18ToXYvXZwhrvLwXAwzwsG5PpOW1RIO1LdGKlJtjSesju0xuu9v DybFvwQexHFwQM6WNBsuM0kMQXuzrZmdgxaSOGvYGQ0ItjUGFSWpKnBWX4FY SIUp02vIfEl+kNC0fHyWn0vJPik/SQMZO4GuAbYmpwiqaYICZGGSQlgno31K u3vQYVWQg47N5HsqZr4ojou5WWIwP4WWAaEMGfadI6Fr0vp7Ml3g9ayfr9uN qoAQB2TmrABsJ4M5EtzTDl3Km4MtmQ+zhbS0KCCZ0+ele7tWu+Vt4FolV30O f9pXuyYw1CQGdP9zgr+humpLnEghn3t/7/s9CUKRd2+m44LSjaC1/5sSnUKc UfD5MyBXvNr2rny4kz2YLDETxsNuCOP0Wgh2xgrXPTI9Qju88bQi0Up14Y4b 0JK3Hms8yydlk1QEJyW4wlB98uOSZQ2FyuScNBQro/+QJ9pLK3FF11owCAem IdmS/V984Znkak/YMB+JRpQjMVdLcHZNX59cuYk4vwI57YBkZuLko5Jc3HoQ 38xRmRRIThDsSbG6EE1k5TcPya3XyLxB34GzEo4aUZRjTNWoAi+6RwAzhDVA Td9RNcj1avDSbfYw8jSz37eF2PhcTaVgPykuiUQFd96j1VsWZHkvWJe6cFPw 2ilPfpu2JJX5cfify59ZaUNVsjPK65RJAmgC5fsSmEG0ymPKrB7nNR8RJwNs CRzpn/0Cf5ZeOfSMPL8oKzUqgDWF+6CVQAWJX2mcKasy3ebhIPUtltYvXr4B UvAGCe+QC9eg0R6NRFzfFXPoYGqYpi6AHR0Ug17zCijivELwdNGlRSufjcoR epkQULKfgCv7KXRXyh5SbjHKNKaBW6Ipl64nQXAxrgLBOplyWglp9nwynFMr zs6hBo/xeZ8TeOOdS9uXYzA7TZVJLOagwXK33Iry19PULG0OBqljpuFyeMKY LxmP6bP2JnYbgYTFdUzBZOUMcDCMd8Pk/ONK4+ukRAelNfmtmE8HdhHxuYPj wWQ32n7FXkc9G2iYY5BS+mWUy9lOA6+xyleqteIMkXRE1zvdP/FWETYW4/IU efVCZB2pfCUV2NzhjJb5EF0C7aCuSnpDt0bHm1XJLdhWkypk16JXpEOcSSXJ NCdHg7OBrfhpWQ0xRyvneSPW/2Q6RsWZxFqJRYuwKR8uliYbCj2MeLtgXXCP azpZ5B4cVB1v0Kxni/vSXl4D+Ol0VkXYpGo5HBYsb6m5j59V1dFyHI5dBa+W Y9xJv3nJ7UTpeIWVDXNwvLcpcpMdX2/i6ruW7Ym/qRVtrG1cTLBfwsWA6Rdg qAlPHsUQoNjH4+khkizgdCYFle7yN9aKG/fS+3Y1r8hMqmMGRWpaBhv7WlSh ms//o1aSuyeLRJauFh+1RyRrSfagEA0RHjQFQ7AZauM2EFCshwCIivw6uQPf 3nB+H+xWG/hUFUlS/lWfW1BEUr95ZVzEjSgwgow/E+Zp81AoETbO6rXYU1GQ yo221ExO5LrJCRjNOdU53ETap8wXewn2YRF0gxnDWTAaSJKtuUE+p0cho5YL BWnSDvmTwKyJQqeuZU+l3Kb2rWC3CD7asjMjn+6tedtqCPNHRPiu2nhfI+do QKZMWgz7PJrEwHlxu4AXV0M557PjKms+Bk7iTFTh/A3lGzefcsQTjhKnqFc+ IbcqAwX2EaZmCOYrbb4mRuFCD+XH0Pxx+BPXhVqs/uUdA1MAXJufi55WP6II UB9NOk/rfn7M9oUIHjS9Q2p8QLOLeVU1K6tHKRUM5TlmSc3DFcTDWAV36+gR ZqoRIqnwXwmoQlMnRV8YBu5pJZWw56hu0zHbfJnIsK1waO2mCae349BG+x94 nxX9WzAyZGLTvyTfb4tlJpLEgYEBJuY3Vc5yIghlmcuKL3pKW68DCXs7Lslf 3thV6rTjWH1YM7OWx0vYNQAn3MfLygwGLcca6Z0Y5eQn/mu0HBYmgvK8LFMd 1bNbWjYQnBoy0NlzLPlmSkMmT83loZiIcPlRb0+Dq/kOqQNYSbsXbGddpzJ9 /tQi2muOQlxdFROWxumDVMFU01VvRbrqVuiTjDdOKQWjHsh0VZ/vI6WaUiR1 gxTfZRzIuuQ2uZaqJ5JMYuaiKDzHK6xoLYhtvBNJDsBAwf8CS1IenUskwfyc fPKBA5llyxlQDSJejsjzTaH96dDDlMdIC4Awo9FAQnVbVU3MIVMc8dIcDFYQ jeCjTZImhhKVxyeL/mIKtPZoYQokf1VyETpk9ythiKwWnXfAonjHCK1WXK4J kpUh+OHxIaYOlToSqP135gHbvASfOhJ+yhhCZTvc9Rt0MR+tgw4iVjApAZJl iR2L+WtMrtCTK53PH+8UQk3PZCWpQ5JEkTIQAXqPiKSYRlbi8YpcX6Lun8s4 WuQqNm1TMB6+MYtiHZX4JHitcJSGiy02NF+s50zpYkjnoiYFFq97WvtcrQX5 XN3BFAtnZvKwXFkx8gYRYoXxIlIkppkMVwtJQdSqn+dI7HP6udRrlsNHiclG Uo8hj0vmW0kngzttNz7MD+8J8fyZzafvQTrha+EV/xB1ws8h+yjMyzFIgumn 0xFmlBvFmUxJndJacxSD9i9JKKpsP+xlp8WOMHwdmw0h0ZlyPXBzObzh1J0J kjnIfzJ6cUX6hrLpIMdNiv6iPAWgUlgGK7XwBcqAmBv+kEqqtyRpHhW0f70g D4k95a8Jyxaddrtbr3c/+GVaTvAVR7DwBzy06d2fnADPW2Rbd/vb99YpLQDb VmBKGNMcytDLFYy1a6moTUgvq2x3Pi8rx5jatEfFAqD3NPQELM6Nk7yyJzyl 56zcQobEJ12UhFV2m7a8arybrOaH4vBduXhwb/uLwfadrK9JrT4fbA62N2Sp d+4h2ftA1WR0+Xe+6LYoGGnBogJnfoI9JBcWQATLGJndJumLvEJvRztjH+8h 8ArYC++nwYd2g4piufRmWz3SofGvKrsLU6NhYMiuM0QOGL6FLlwzWHRCijjO cyBsdacNp2g8AlBRMsa/YwqRjymwKMUOX+3vUb1lyXU2LH9YmxwQZ1NWMbRb knOr2tnYOK1GQL3L4XxaTY8WOMGNYtJfVhvj8hDj9KDBve3P7965/7c7X/7n 68GX9/525/4gr2YfWkzNVsIIVku5SolpAl7rQZ5haru9WzdvPXywkT9s73rA hJRWSRof/EYwv32zneH6uf98NOLS452Mcv1cYMuLkwIv/4uzcoRV02ouNlyh sKww6NA5htzwT6KUSNFk5PPJihRJlHFIzHx3giXaclRERrKWWB/lXPwnJyCd sMKOlEARGIgFancF6IqvLo0YOo9ffy/IjX2D9iAGfhWtV4btaQXIq/dLP8kE Ju3mDdN+P21/rlFVVPNUNWylh/T19savjK4EoJJHxHEecgLGCmu1T6J2IFUV 1VVnI8Ax3mXLymhpqxrBp6NfB34o6gK0d69E9X1OKHZg+fwAkxswXTy+OtBn 1pB3C8HUkWqddMtCuwH5JhE/IJ5l+JBT1HJ36tYVtiRK4AwE72O3IylDSTJu tTiYdCCMr7aTp3BHzlM1AfCxTDifYo5jvK9Gvvl+1t5pkw+5exiyvcjDoNsN DZfqAlDT/9pnIg5JA8nabG9pR+BKCC3oib3XhNRebcpPwoKJuQ61fbUhPyeA tUKEf4o1GLefLScgAAb1SPD9YJ0pYMSEijbsSUs0/lgRWZ/AJcpVqNGzDcln b5CA7U55/DpoEpRztilAV7xutYoCwDq2gBWC0ipr6sc4RmoR9HYtLs9JHGQV gW1ifp8N0PKeiBP4P3RbbEjKyNVeGkqCTQgy3h0hnvqkycmpPvG5F28TtGaV jW9AKGKCgBLYuPouilZZ5knqJ9V7bkh9iLOluaK7ybh4kx+TrmTjxwed/bz/ 28H+j2833m4+3Hn74c7m28Xb+dvJ26OD2939+PfbjUcPO492HkDbrYcX3c82 SqER1HVZvdYKqxs/DvZ/3Ln5dv/toHdw+7MNYVjxLRkGQ6bxIVA3hUaOzDuJ yBISxiqzRQAXEKbJ9MyUzECX0eRMObV7JEqFUEI78sFwYm0NdwXE0vYYBGrf d3p6y4SY37hhPYr5UNoZ0t6g8tviOav5m/ASpF0IJgmacejMUPXTZ5lMUUkE zMOvftW8SFk8Lt8VkYpY8gmEtG4wKrVUxaSobcMIN3zN7L9gEeISLlB2e+6c wi8FN+GlSaXeUmSBd+pzhXpsCb7CELxn5jzBxbAVy0XSvQqnNI43mTOvmjB2 N1IfYFUTr1onKYaT6Zyh8pjjsRvnF6ayd43RPZv5KZvyB/dkRUp0XLy4h0ZT ju9OoKQ9jcq0U64ul+aCxnk/W1rdSzW0wqK0d+AR1ZGnB1RmXkBvd2IVK9dX ZXFv3ObJSFVzQSvF5IDG61I8LM0Xg2Ep6szdKg3d6Lprm3PFzqyEsiZX0rEm cEUtismog1/jyDsN5h3H3JaIeexbKnE1J6WPqkFV3ZE83rVQwNSk00AaLGkB 9odX7+tFPnzXMdYjzMUQOs39uqZ5DykDZkNYgrI2CadHnR9R6sMe+6J6T5F6 8okoo4xPKMehI+kK9g/E4Hnl9BwCeA2dmx2OEI2HU8ONoNwUWY1v7vAXgGwc u/Gxh7uM4Ltkn1fshN67+DzE+bN9pGc1JLsyChy0v3oIDuyxEcrq6gFu3JAu yW6Avaqp4HlwO/aBGxsWfOEIMPkPcLW46qScqUWPx2BTiPRaTbPPOu3ZDmct Jk4ZflHy4W52RomWHD4Rm5OjNkpqrwB1b8+orMpaoxVUjwwQpYjhbLCmEI7W D4+IgAlo8RltYAtDGMz48rH1kXm7RNEoeJZND3+BXvj942wIF8Y8R6e4I7hL MbJV1JxYLkLPsWreuswuwhvhK4T30DLpZ/l5cN1AMJEyhddftZLigDfLUTZ9 DxfGg0V+/DBoy//1+nX2vsyzqOxF1rl5/96drS4zBdDhcMGdo63ueEJ4AG22 tu7c39xhz3muB05b9KCr+sj5Yrhc6HRxBlRjkPzZZmTenf+6LIfvnvHNs/Ej 8Mxvq9udB/tvz97+cLD+sLv/48OD2xc3O/Cgf7DeBU4agYDeiu7ungzkweVG 96nddCYf9SSBEpvu/vn4xdNvnu0gdra7PfgHlQD0h0mV9IuwoNtaZT1x59Yb Br8tFifTEXlaAjHOh8NitiDTcj4mV6JF4ba6pSfltGRPQWTCtOyfrLtaHmad 45P+na1N3Kk1WuAerxMtDdaZrY+UNQmWNF8+ew2Xj7gzcouQLqr9wCzW4aWZ T30acG7+sNbcDOR72XYwl3FSKUp/SsUnecL6I5+zowCm+GKke0jOuLQ4quaB +bWYAh0Dq0iHhPpVZ4h9iWQLqEIxEWIojXyG9JOArZqoM/J9Cn505MeTnSxO x2jgQ4flDGNT0dRnfgdVFpRQeCJucgiBywdLwZTsX0DgQ4VqMKp7QAXMxTG7 Wf8h/JmL5BF1yj3ZzV0zjFP5CLS1AzYIBXuk73jPLUGJq033ciZJKNHCmlXD eYm4jdEqSsEp9xZx6YtgDKViGHSljM+x8ijXwqL8m4fsKH9G9jvKuUk7a4ZA KgnGPclxOC3mx4Vei/LMPtSguQADLbjngigaMrPoozi0wsWv7IQABukQl8x/ WsnBhj3qUchJpVXqSGIylYNcVdGGmYYJ7stXY2DJXtLF0slijOA5MBfFWFRO Mu+JIS3EgqpBL7Db2ogL1I7RGJpXcKMj1SIbnQYraA+rtAe4A/sy+EEWOxRH 7zoBsax1lFttMBjgUQ6JUihfY+VqlWjjNA8cDUTGiI5S+qax9OtW9K/asCNC Xj9qcGB5++LBRdQy89lxsRDR86vz5yPb1Tt+tSZY+S2iE4J7HJU4tIgnStqB b2JGw8N5M0uKLK45SSTT9P+27uTicvQsLJpFrc+oUHrXEcrY5ScckMEvv9Ls EieggLZyU5HI4ll6F0+cjh68veh1hz3CgDRQft8CiPT7fEzasyl+ZNHkNAB2 4SceTYvAg1m3qYIOSqZ2dBqmtxYu9zDFpy+/le3utmLo2HWXaK2izXKum827 lSJlNLgyQF1+YRwY0gOLBZsX+eg8mVvDMXZsTczY4HYNqJNY4y78dHid8NR6 gp6Jw4cvmlge8bSaCLx2orOsC3d6A8A9S+o2z/+xrIqMOutW/4FyCyeKxkyu wdfVDlLIt09OSPmCkmzhrQjMPfkf4KdRWn7jRGsOBzWGvxX4Mvuw4wL1TFnO fh8VpqhU3lgeXeAz+Pk9mhcuHgOP2t0Q2eBbIdfmHjniNJdT8nnMJRco0VGy ExIjRR43GHjj37fWQh8WUopooIWgpFpCS65QmFd4MqHCVvoLp8u/eBca9Sog dnhRlSv5OX6dH1QOZvxEd5jVLaha4IY+XtWf7lWKkUuquDTEada0I8x2yNhc IaKeiDLoR4JPlIrqrTXJF90ksFe96A7n2Q6XHDltmRh5+YmuKbWarQVAJkx/ FaucnEkrtDCv9FDpxL2dYGCh3recuIl8fm/hoc5+Mhfzn5yPnNT8vERSd6qm S7aFXwFMBAa0B7v0AFm7JSvUlHWVhvC/afE549fEXYnkCDueR/P82CWKZW/T 5dzXMNvaYsZd4azFPRUvSR3MMxXd74678bnwA7pAkdLae5+zAVXZVj+oamGV n7lU14pok8DWMR2xYY8mqbzDiiwXFi2xQl+lPfoEsU1KOEVUVMTZ33o22IWq mJ+WE6beqo1CztUVDEZRUDRPRMMI2I1VxxiNX0zNVtNTrROHqZWU6t/HwTQa XMLdjf57+iNGqkdKeeYV+g4jOQSi3bGazzuaqUcm9Vwn4EoceyndLFUr1MOx wSG2S/fcjCO/5W+mQw069LBlR7mqnIfY1taKgVLVYYmsxrCA+7ZK1WE9yVOH ufN168qKgpFawkIr4/hIjPYseuLfLc66QXiRjxqV8Sm5bEbNVjgqDhFb7gQ5 mRL5+E63V6OJfijiK7vJ/DCc7ZpaXmjd8ToYydJgrCBiDot96AUeP7GLLfSv ExENZchKy1Z/IQXoDUFTCd4SRhwjX4mI5NxQC48LMFrOvX0KvRnpZuezsKL0 H15k3EB9d2LP/FB1Q5Ii8F/JRJCkSJMdzciE6m9hmFaMLX3DEtUC5YtAmA5d OiFuK+2JbNjOT+WKPq2tGgCIT7pscrZX0pnz2nAzJAbrU7rRxOe1rrB/IE7X h9jKCX1SL5fO5w9D3s8tBT2O+Me3NJlu2rm66FxrUyp1UPK3BojFv38kqVO9 GtVeLEMENvx6Q9AAobfQjzHvDf1k8p9YimMXnHYJ3NApOVb6tvift7DKAKo8 27WGH1v2Z1LL4T7qi7coTAx24+Xr7Av5+/FkNEejxVfz6VmFtoy9u4Ntrvvg unqDDsvsClCczsY+0J4yY82L4+UYy4pMyL/1kDtj1bLvh4t+qNYdRL4r4KGj NUHEGeAVIqF+QwNEEsmW7yE08HEPuIUvyJVcKLw3dbPL5dGEUcGkreBO6doS 3vbSSyl2IDPxeqZyztHEYbxyJ+ROJeFS/Xvi0dCmM2YcigtSoe+NA4k0JMRL XcMiUZtiegf2Ik7SjeQ1Kz5knuIDTzHHRohPaCmjfyOViA2ilmXiErY2thB8 h6JSVWRTCqiglHV8zdwm6wUSmD68Kd+ToTXMwasFRE4SVzidg/Lbcx6hk8Q0 X86lq6aEOAb22ZsuUF8NzAF5Wnayjf0fI2e39Y1jcW4jz5zJe0wvx2G/fVjX KQZujlw9cJBkmGPxbyeFq4XIAQdsUwDKpZ+aMwvzkKiOgJmuReyGtGWpp5PM vmt2eEP/n+DHOFcHSO54nx/hORGB/aP3AeJG7KVNUdRPaLoYRwdsMGWgpjDW pSRbLjILvMgo1BjlmGoHvoT/W5MJ76AQw3+DRE3fI/JjCbt+VeBnHogcmI3B kUNMWVlkJ9Mz7AzZxCKZxmGB2WEqjrE+xdzKCyy6KSNxj6o7pillX51baEy6 JhozB9iT6xvKXRTfETdC/GWfMewNixMXo3ZIlYFxSdVAxnqlCZAUDgqWybDY gfXQgJzYNauvDUehWGJyT5sTIg2BheXZUQWgOTztSqencLLn59YtJ2KmLE8A aysFIzlJcjIsIoi5jtV5GBvYdApRJ0k4P6Kc/Bq8fJJjSfViIvOhwM8sR0s9 ey9wKDOWBWvTdDD3c1v70tLTK+bPZCUFi9sjDw+apMBjMg3kzIdaa8fVYjp7 Ofkazdo7axSYM1/OeFvJ5kqqQjeOBhWxOwT1saFs/xNpFLsn+zMsLnxMKPQF 6R9rVKOJVgAZRGWRBodjrCQ5QJSS4oDFShB+tGtTdNkDf5WgdLWS4KAjiHkp i6oSrlprgJcfUiSM+0Wagem9MdsVzJGwATNHLedIsDHMq5xz0C//ofmMv8Ey logtjHl0F6DqB/4FkZOD8rAzvAMYg/XLxiEp+eeYlemEgzwghizGX80kOMum NZ4O34VmjzkPT3TgsBGOwbpEbgfQWbIXLKn1kZpQHTUKey5mANhoBb9Sc98B azvQAJlAKozdsejNw3NE7I0539F5JajQNahyb3tZf8vWW84D3agEGh453d3/ bALThhPDlti+gUZgA1/JH5i2UK4aPGJmqlLbho3H7kuY6q3gAGcDE1ejgG/m BToCsBberWEquXiYFM2RXTothOATP8AUZk+htRfUy6omJWCrIjxLARQ4BsKq bE/aR2VBVSmwvu4/f0D7GbIOObXpd8uJo5R4FZh7EgUyZ6zFsxIkwtdgf/vR FC3hME+PNEA9+8FGcTzJ7FRnyk/dFkfTEqPqvy1PZ5RpC7PNTcj54lh8Dwhz q2mGmhhg/4uKndEQEVTxGkPRgUHVpAZNV3aqMTve18m4VqYUy4fxdVEuAvNp rA33X9u8MByPYGgRCvcS4cU4LcydEA8nrXGbjqfT4Iki+O6dTf4d7028+ymA nelcKNhih/9ouaDraTQifHAh+8kKAk0JVvaoMCtmDGGWj51mxC4Ym92lEypg GqmmE4IW7iczmIs7rlEBzB3mbjvinIbAwxWWVSkcb7HBC3VM9JGRyYgmmCYD UKgJSMQKN8u5qjRlAqg4rJeoFjMbnCLRHR75GnOJyT46V5BV+IoytuIsH3zJ Wyy7Y5jL/waLWUZqynx+7Is5Rlw4vku4bHjkHUFWGZ25mfcYiZFf7JNSl+gI nRWbPiJskPXQW3P1MF+PyPyNbQB68I9Lm6CRcsA86Bg1n2zrli4youMh5ZZV oyS8SGdiTicB1Fm3E0JHEu+QK/ZY5bzGBOTm0fGxl0i5Ds25NILDZb5kG9A5 3etlLQwi3XAyriIKyhyDqrkUxFRcmIgBHz7v0Ux60qSbuZIkbpMtFwa2knwY gdaLy6NAjNqY0xCBlTt/sBddPQ6V3GNLsJrUU9T9Ww3sJ8ygHgG4jwEv3AVZ Vp4ft+ycR2gvVchiI/rMLFTAj1Nqak7YGgSPQJaAVeasYNhjYlpXxVCYMjwR K2W6DajoEcIlpsoA+ZCjcAVujceeD0rRi66PK4mlDZeFCkRX4fZTjlnOBkwz 4YrH+1yJO6W/IXmO+c2NOmfmrsp5sgzsjcU0bCTR0Q2rMIYxMLw8eVmLXdt6 YTUsJwzQdKmo9z52eBkAdN1j4GtG+gJv5ZB41l9BHbbbl5j5De8deodZZY+O gLh1a1Bshh4u/1OgIpkGV9O4VWBbiQs22iWgu8Et0tNKAn+06ya7y/FVV0nk IJX+KUv+A7T1x80c0KMbkxfsuCtaJTXZ45aSV80/3487Y2Vr9sj9wHB4/lw/ 9Vc7z2DX3Sp/yV1iAPMamhrQaoBq2Bi60xWIqmyObsTLZ/ImCMPxXLiWoIjF pJ9RF9cFpplCdRv6ZsnMLsUZahB0qi4PKc5ewp2NV3pOwbsLIKXvM59o4T0q EK3VG3R1pvTocvmQ73OG96WvB5GPgA+ibBEdJkKUSnA6fk9/sGF9MuXEHSEQ nFzCcJoLODnq+PDEpLIZEGb0rc2Ze2GjPOkHyvdwSx8XVqcMtWOkTiyDSwLr LLxzcmDmOjI2YC7nS9OhuoFd4xbiQcCddQcokXR0aWgEy0tKOUwygLkgkYyA +zxBmoZo5Vm6T5oY5Ui/dFY1SKfzQJVNw1xMqEDfpvl0nP0s/fzs8PqQvN9J A0D37k0+2EPES8mskf0sG0uJrqRAxI70fZtlvB0gELxsn40w23uoczcI23eo Mmj4bCv+rMvsIP1QqdzcPnv1zwMOmtmF5V10OUcMqDYer5PjBOkAiw8YCxPM Awxgvko4BnyozpkDUkWqZL6cnM3zWUABy5xmwR9AK+c5qyDg7p7N4EJnRlBc iljBepNz5FNwhqrGMU/8coZ+qFWY0ABtAUPyHzdY2pEyC6ZaKe8ONrUmfQij OkXrbsjFW07eT/EKQGI5XS4ywrkNBjIlxebMy30RgIPfHM/pst1Q02DwyDBv y9aaLj1iDOEv73G5nI0pp9a+ieU5teyRUI83MuYc7gUya0VMBoNBxoeKKjBR etvAzjKnvs8VHKtFvigO6MP9rA3sbHl03iYT+/QYgd+2YA6T3DuiOz8PRYMu bYK+9j0dQdAYh0Ay09w9qc2vMUbSDqsk6QCjdjQobhaOiaTsrx1zq6f905j4 HQ9MkEVWSVi0ttRAZhq8p1cutmq47+xSW1AetTXjqta4Rk7TJyNBKiHg7uIW El67yhtiDniQNp2y9gq5xdyCeDGEalqZ7Ghiuc17sc5qVs6ag5HwhR9pAwjq 5CmsAXv7Oi+p11eCkJboG//Dc3I0EZ6Nl6biZ2zB1/PmS/pNijN6vEqNwgfQ y9WYIRgfppE8WFdXjmtHD06PFHs9qpnbpXhPA34nvKE4JGrf1f54TU4mdzfn ERb6opH2s7vZgbqG1R5HYTyGFjpUx6NOdkiF3aYBHCjWyt8DJghWOyzuj9Ds +n0pQ9HcGWHop3RGBDn0pR0ZIFBFfdAQga8wttDoPQQ3QVHJ+QrGF/9jLwD9 tJm/0dcRw+W0Y+n7Tje8Wwu7VNuFqBmf8RpwozZ86lOYeW1cGre1po0NjOj4 uZ61USIA8tZx3bPDafiNagy4/gw4BywLLZ3DNv7XrAwMtYHDn3yyrcIjvQsw i+gVUiBPQqaTr5fjoxJljB78+E4INP5thCSiIqf5h6fABZ1kocqT8f3Gvo2w Rc9wtqfXa8+KLdZyMjShH93u6EOwl8UwDPKn6PTszSkasklMSU1nBleP0+Tg OwlUIGaQHBcIQhOv8c5gm/9f9InmhBSgV/lsvKwoJeTN2RSYxf69+1H758eT KZk0lsAP9glubJNE2/HpzKMBHSQCaPYgQD9akcAw4Itpw8NLOr+yDeH45ibv fyoMtj5t/Xe/TFYUZoX1vxzlZaRNFshyJpy5DJ1pn2HoLbAYb4ShJonWQbHt j24EiytWVsn2Aq+yPbj3iTt899PafxH3/10BfHcBhOlnxMifNff8sAitiFHd 80TVrexam3Y3bn/lHD9PPqACImwoZUafFY1BTDiaqqTLiXvD1xYVEG18m7tp ZxcXru1aY9NQNsBVDfcIPmg4y6JYz0NfKoUl+NgYICzS9u8pnIWIAdywmg6G p3T46ulybOdZXkpCdcNJ1wP7ENYIoe0xy/P+qS2xlzwVeqtkwZNc1eg4mvsJ X4umx33sv42oBcenzE8TgEj3XaqNlZ1Mp+9YatZr23UQ6SBcrxJXPSqreXGM lZm4GpMjl0HFrf/pYtbXozn+LwbsHxk6+iTIM4yEyILU9stBu/mEjMccwB5O Sgrcpm1SolAtDyuYGfqUqCjN0WHTiVMGuK9wY83XTh3KUDmFcDH1XTc9NtI5 WTgVGvUzRCyDS7HpXpqKOrBfq4AjuQcQo0lJQ7PsVN24xVPxQRTcRyuY7GFE /XS7sZSkbpe04/1Kr2M3JfurFxlyCfCTS04ea4DILYc52qDBsn502ns2w0dh aMdN7YSnzWyVqG0dqMPXnRgBTTVVpMQ1osUqiw5s2v9EKpLs9tqlrWGM5LDI ggcVOhRj8cwignaCAtfmB+96juiat2v6hXCFs2m18Dxhw66tRXzhOshwD/di 5jBa9B87pX/wnDacVCF6ta27/Ki6w1rEpzTdpDV3pBDR1SzTeJ78iYr+/hhp A66161vug6s5xC9c6++E7X9fqHaoijINwE05mo6OC/EbM9UuGahdP7ilxa9L VFhSRhrDEYcfHuyC/u5E1sm62cqcrzdd4KT0Hk7nUp4CT1CPHVor8a0UTPVd qaH2VuUypIyxAB8pyYM/5vEUnQjRihNrEdIDflwsKBqgTg0azvbepZ93moTs NU6XjRnd35SnxXS56Bh1b/CLSRyQPlGf1jI4KWP0kx5NjrNEHbUeL9adka5h P9tG18PRyPgZ5RxsGZuB8umQ4UkDvxuJ/O4WcM/dLVDnRRI1DB5CfacLiJxe jlTzcI0Vb/03rdi0H+mSw4uGNV+6LFVyX2NVd/6bVqVqnHRR9tytSWhzw5Lo 32ZVUkvW+g9MdGSmWZb+gAFScqzNnh+hvIiskZbG4cjqxKaL+RspHEC8FV2q IGkZqa6gx1TRjs9uWNX4xJ4EL3s2JDogyN/eE5O9WWT6ErrTMm9LtCX1JR3a UHNOtT5NHb7GGihxFBHloVl+yIzB8QXh7b0slMVSU4JSC3WWDJ5D2oL8ZVe+ RZVn8lZexYph1yYkOmKRgeaKj1igdTM3Pxr5UnC55srO3ZkBKJikpCq1UYhu Y2sxJsk7feEmojisfLM/nWYNHIi3kTUJdGlFGz2+21kfs3fQ9mkLN5QR9NAN OtLEfWzq9/YqicCrXwvOW6qBhLq3dUqkL21jdK+RCJEbWkhnlUiViT41fU0s F2bbyj6m3yufs6oDJwat7OGXpFxl0oExfeH7mp1jU9C5Jr40tnSqfKZpXk8J tCWkk9q5tv/PKtCSACjnTL2KVgDxek0VHE0tr1ht+gk5RgQnkm8xR6RUpWJQ GPlvGQWxCyO0sg6IsWRPK7Ljo7fpBC9UIiLOtE/UQlxbggbEdxiSgjyGPpHc 3WiFMHhpuOszs8i3J8V4hjfeWWIM4XAa55eElFr3bEjlrIHJheaU1x3vUeC+ gRumOujEeHNlPCbehg+W5qjek7CVReKfV5KaV7qy79xgevA51V6+yHlwQhHJ ToQ3g3jHlqJkkgb/yVIcUEp0gxEQO+y1AXGfT/MKffmfuhtdHtU46063carB czvHWGdinpYzmHSBLEsUfmcFGWpWIefFIvd9tFbOZLXn7PPxYvV9uieS5mcF IOBov9eaR3rN3ehk/X7YZm+oYLhE5CxL5mnuWbIHiQOjIxMbWlSiz/ljKYgl zC2nkBWQzooRB7mKlDoIuicxs+hMH7iiMN5BzyF9T3ZbbKZhk3hnutq5tRNn Ppr8DQcUI3RYC4q9Hsi0L45QIEVPJ6Mci/CqS1TWGR4NsuOT/vbm5mbXmAoZ h650rVOlbiJqM2g0LNf2HtNs154OUhW/1YShYXniwYdSaaCqQ5LtOD5GNXVt R0iSxoNolRhajaVQ/abUp9pLtyPZhHq2QXntmXefBPzNSVFhXfUl+ZCBxMth tzkzHPnpKaZIg5sACf5oSWzdCIvYTmecRRa6OMthmPwQ/cEAVKfZ49ePX2Xz XPwd0b/tLNeQcmpwaCHbA47aJ5UFJqeoOHfgMzhvF1qz/uI7jCG8+E5TEl68 Pp8s8g8XaAK8+P67512yA1Ixmss1hlHtCfymx7qLEObrs3p8CVzdfXGIY4dI 2At00cPQUNZZACAAnadj3vjpDGMeOLsnevWdoAMfmnLJ8RzDIVuMzaJXGEqP gJLxkwEBFKtUUG5hQlkDkGRRoAeDKJdCQyedrJ2AJOhmdjIqmkH9QL9VfgwH mn+KRkeAwwjDJbCkN3JMfqY91QErGZrq+pOE6RK/YfxkVyuG8ECMmeGex1xb qJ58+vJbyQjKiAN/fcMiVO0WilI3siv1Xt0/C12cpROYkLhm4Ts55T8gpWpe dolR5iFN1ZSdFChoBNBtOeMOGA0wxoVzvGBYLOrICE7EkbOLJ5zSfOSj9VrC vB/D1LgsOYbHDIacK6IR4kYF45laG8fFRVypS3PpvS5RZGebh4EdyfdhQdvx KHtdkOs1Zc2eShjGdIjhZDDTsvoOP9hhzaUVAyCuBwnDVJIZnAAGnOIJKRfF KUUomtn0sID/LVrKg/AELAwczgLMoMhufv7Fl1uyjT/ApzvZlowmAiqdVV0F 2WUoo+xcpmeApHGDg6xVnuZC8HjENXrkZDoeUY4KDklVT31NVcunHHtzpQD7 fb83OFHgK+zSIljpJgY/Dr1rviu4VkVAsXgta0lHGl3dUr1LrhYi/O67BJDE UA/nBecVpFQSOD1JXYCZMfyabuiagDA1LOoheXGvWMdzD83gL3CI1WV7FOXM Eel0fcmxjDkpy1+e7WuSPnMdztyZp88H5iuhfYlvgJAXj1FqqKBs/BhiO0RH 9uVM9Dsu34uy/UzELHM2ByA+w86+EWdjoL8A7yecQOmbaT4qRu1e6IDmLVSy +esxfFP7wq+wYwU4n5AxDVXwdDsBfD8LpTm0MaV4oFAS/CQkA5GkUgaKkJSB zjPepUmRT2AkKe+V+IyjaYms8vCmmgLIMG1KhtWc4fRL+Vx0x35ftPHKhDaY mJhsEwF+MN5r1t4gg6eLZg6vuSFFuCKQNAeslbYe6B+S3hp+vx7Op+Ox8XmB QGBZeRc1wmYXYlmsOADpIWnxywnamtEuU4xzO/MNd53fJsJMZ2ERnhh7Rbw7 TzLTOKzKR6NPRSmhtEcqcCFJ5enBVsEXPZeRh72js7Pp/J0tomHIJjz8qBc1 McKh2J9Gq8CwGBHA52mhRkNMgOrC0/Uk0tuNinPCzCym4bBQikCZVMh6FO5c 4gGwNEkVp2/RalrAjr0rznsaEjM8AcGElHMsR/0D0zHP87MQfGS5ibkQlq8d hk8Pl2PkIqHPUF2W+UbMnEuXmDpLeIsVh2TjV93Y24nJpE3L5cTQulLAYvB3 LBrQUqP1lbRELXSFGazTtbmQFpomqoNplq2GAKQ4Q/qq+el1cKNB5lIBXa+A /MwtK2Q0I1C6VCZf4W+s75DzjYCFOXz1czS4zAsty8Qyre4cKokmrlJj1dNZ 7MrLLOyWehQxHxzZHjGhhBL54PQS+fwKBhxNXM9pPsaAcjW7BH6+Is9tNOOP sbDJOjGLJ4jSSqfl0I4momWX4nmEGDQlhFcoH2ylg/mHB598VCKGxY8YF7uR fnpNC6lydmlDliixI3WyaxURATv1jBgiuPBuPxkrpOgqoz3yE9sME9sx3N/V wqhcuOgpZvmIEjxhgZRwDzyW8kZ4le3QE7jaMGEh/62/Bs++efbtsxdvfnrx 8umz5NXTl0++T971JRtUaPl4ch4Ss+EU0qTYmKin/vw+ZZDoZOvJuyAuGd7i SjsSk1lWWKwW6O8089Vr6cE6tRwsyxF6yAF89SdXbuCfvmYAQooSVu2sAGOU OYCuS3opkWDKThBrwZmvWlZbm2Krqfl+Fk37wHGwkylQNE59hTTMaFB00rSz 34OS/QeOsWNECPleXLpySo1JmQ0w2m0eUmxqyqPD5cKlNqGJVCh4fLm9fU+T IEj+ddlcyzfDyx8Y0Qr4GKDns9VwImqqYIezwqj38p04ghwWUlaqPDrvozg8 R0FzVnClNO0BRLNshhV3gKdB/utUE9DQ+CkGKYFqhL4GnDYkukHlHebLwclO aLIAzgmwLHM6/DOu1XOu3w2nk6PyeMkvqQAbVkxCIcI4LTEE02e8Wv0YGC3i OVjnQrmHKi6WKqblOCxDEkzzJSZFg85l5b1ohT3T2dIyRc3rSi3ZnLUeBI+m VDoi0hopLZpiyqtbLGqnpUcriC8IyioNE6WROSucVEagH4YpcWU0DISVLt2V c0CeTi2Pk4gRw/y0GGPVaCKVVIftzr0vrCqceFoTcJtSl9I8VOAaWGcd/qKb oErTFH/XzcX6TR/DNOuBx7NzjwtU7mlS9A/P+8i5iEsAAyk4BvCViJ8gOsqk eHNXTp1a89Txg31+cOCvNcsVjn3Iph43bmrg0uQTZhJr9WYadlUKKlx3v1Yc VZB9Gl80rZwneyALYq6yeU29Wtjw80kkYxYlUoQdescNsmxrgIUKcBDM7mdl 4/T1nQHWhGQPgVqjHhHbyVTGVT8R1/8bNT228UZpZ7N8wc6tgYyg2BGEkJFW YuDvWUHL3ZMjG25Xz9LaYR6kVat6ExjRBAF1YW8sK9tiOud8DTghWKb2Rcet jhxixOjIy5BRWJu6Ewkv5Z5LuHW9SHzSXKwDECGpV8f8oJoxfCO1jHLZmx7e L4dTBC69tlQy/CkqcNyuoYSHOfNIe5h1SEuOGyzxIV1Or7ECro81pStnNtVz HyFMfQotOU1VvELHSrfUfjYUjIGmgjCsoH/P5be1VBxuLlZUQjfNStWvAkoU RGfsNUUbfJiLRprxiTpFTEZDyWT/9kFyI6S1p+TpDs5YzmEtgVWdtnC5Zn9L rOaamB3nZg1SXaqcM7ysi4BCnUT5I0YsKoqKnpUh36+caUbakAOarM8gI4oV WmSImOcR/EM+jXvnPkBO00Y/FKqrQFSLyCPWFZ4KQ0CqDf6ITg6+51TgKRnU FNeed+BPVhDMXT9hPhOWM4ZAUYlxqEcUvFzY3F16QGFgbaGH55zLWsu+U+pn 6i1eQ8gXKyLcPj09UCGuIwtdnUc6SuldCmRc1akmW+Qas16Z3KGqaYguyZYq qKdSqUzRUDXnXE6JcjmLi8JKGhj04c+Qe7aakbTwbgMy7oDIMZ+eFtmDve17 IGDdvWdc/+E74E3/nn01LifvMqAolJIXKUG1PDpCj3cx4cECKde1JzvkU4UZ wFBbTtIBoVjF9o4wY7HayBfq+X24PIY7HudVLk8H0/nxxmxDf26UVbUsqg24 lPJy/Kgc7W1/8eXnm19kHfgKLyFKuyGebpdx7KsY9tiHPsJu2cwVJMMJ8z2q b4ZCSrOwJwW9LidBMfOUkBXU1F6612p0xIEQa17NS6wrh6GfLOLutuzd9xW5 oUTvUDG59hy1lSj/kFIJcOb0NJ+jrhpfwr2j+XMfv3qOBW+PkJyxuvIUq+cN M066UHIUI5/2rcH9wQeQEAGVTrAbuJxgmLkiP0iQyzGiPDpBLEgXwh8foqp4 tBxqlnVkEPLjArtYw8uDLF+5uGEA94KZc8vqFNXua9sD0xZXaPFNG+GnWveh PaMs/EWbVtIGSjRvE5Sop7uD7KcXmGn/JzymU+g0tKdrDdEbwTlE4bPz5uXT lzvZU+SLf2Kx5ScmswjnLnZ4D+5mKsxN3ZElMwY6IzqFllDHGjDaKY4HRirC 4aNOPx+g1wQyfqgroLR2dL8il590v5wdz/MRcXI/FPk7zCwBlPLO5tZdqUt4 KO7/XK37dy7Vffvtx4u3+/r3AdXpXptTfMtTrCcOzfcf9/+fg41jX4gIWCkW 3IN8wRYMk5pQSGzHcoDm5G/VGpNdNGmtWXEbmqMCM2mtpYNYicVRuZKkiJAJ 5HG0GZLi3LIQSQ5+xkFOGB2PtE5/rWftZDR67ufGsBWHBIFJ9MW/vX75gosa 6/tYl8cd+pRh+OQxlcF1utQAbtxR9HkQtTtrhejuRNbrCK2IlGxqTtYDVIiT KuGo4AA49uRgFZDmd8Ryy/foWf92qNSbwiSiXFTTJFHc8brJHwP2irpD9wq8 Y+fFbJxjnqmAYL2s3f/s7wDfwWL6DbrdE5tBFzQPyWMAwj3WGWnhjMDbXSWz h0A86TPBX7kgoiA8VxJci4Cfcf1Nn2+aNFQBl0ZcdbQlIyE5Zqa8toe7rfhK kolFdxZpk2sYUvNOaLqhGoo26XyktbXB+Eu5VtJ36io6aui9J9VqnIYhHckb aeLm2nEgoc3dS8fWI7ePWzh/VibSL0j2RWcjSQVJFwpRbboJHOFmwYfSCgpu cnECut+4YHPowS5fCXOgiI2qkJIZGFkG7ZH9B273p08HGW3A1SD76RNgRl2u glnsJBDXdE1nXzPksPjlJkiimNRKskKF9BApSSXn2GhGKASusikaQmjHzN60 gjeWM12rBtSNj7jhzLGeP5NbrGh3vRBndsPgdhzObVvOBZKgqp05F1eUHmiB cS75VIAQPWriNyCVssJL1JkwuKx8qCAXxe90bm7d/fL+XQ39YC06NteytarD VeobXg74rlhzX1LVJykE2TFCzXbZTd+Z9lYXBn3hqHuaNJD/S6+vgCmh9pK1 rpVxty5oJ6pVO8F23kQJ7dQ+ck2baMbG6Th2N7lDTMkUW6YjRRJHNdWjJiKK zyEQpmdSXblXkOthl9JczZ7dytqbFeeN5EfFuz6qzQmMpFhxpHRsVxVZZICR zztIAkkaRY8ytkKFMqycaVFc9OQUdzP5RHr4+T2ns7SaSMRy4Dh2SEmRxWaf WpF7Iq9jLKxdYZYA4FF/tu9+5nITCRkRxRJ+JR2wt2TuIsE5bEKzBbE6M8dY DCIHLEqVKIuMimCCUpLUrEMMapnHoVdUqMZsk1rwbHNYHRI8Sg6dDhuZMhLN LidVHnEc/9Xkk1DHdou8jWfeHpXVEM1jbVe5YqINmfkbLkEYO/U8YJVONOFJ /4pJ/oAGMCwSA1uGri4n+Vy03zZRZdlJrcTaJJfiyXi11449E43ZqhPboE1b TK1YlW0X66tXHu7YW0HPeE8yGoq3TVOMhTYxAnYJP1SzqFxChWqsUkKHPkaX fwMzSWmn65wFkseIc0G6RG0DG+7rLIutnOkq8pjtow9ITEGYoq/aBDDNJt50 6S7Erq9bO0MHzOUM+Cz+6pDSrLJqHVDl12U5fId++0ccnQb/R5mH8uCC7JBU 0ZIN59whTDJR0EaSXNN0Y3aNYWRFF98VSTeC95GJ1mf5dsJIsKjqntscObf4 R2XNi0s2TGYue+F3gsBqWxgud/oZd6EpSeeLbxh796LyRPSavH+iIkT0GFMk VKHzn6gFBiBUDUNgzdemYET5WBaaYseaCw9il9rs6IOsiuKu6U8gJ7l6JZh2 1gKGK7RkTYpxK/gXEQtQTiyXrTkc1Ra6m4CHi03UnJUEi7lCTW1kX9YrWgLd MoeFVI1BY9MSCHS+KIdEKXV5gSFWZlaOG4OQJ7yc8JSThcUUlEsnLGdS8K5a yESwKlPwNlwzFSptMdVs2mX4OI8loHGU8p7RICnkecOjFNzB0ohnzL0SAzEI ee0/BknvBXAbs+UhsJ5ZH8jABL3lUEUWMMwKlk/n3nQltSPYb8Yh5KUHCA8K 2x/oodIw+rDt9LtNZIyJtxeyY6JBlwgtWupqXJk5mMOUG9nPBoFvP55zuyfW EruxapdCo0RYozKNFwJcjhwIeaemnFloze9UOSO8Bb7fdTcHUyk8W9Rneqxq d+oDHTxm2GO6FiRTR0A8S96g5jJnBTYwXSYBrCaofAt7mAUb2jMtB8lHwHJG 0KeeBEb0M/QYy7UxBYCDRR8xH31jBVWrE9m493AhWfXphnvHHZir+ZSrBgwj kdb7P645mPbmrrqeWvyUdsQpOjTFAhvB6Ht1zS7maLagzlpq6MdDiqxqB0h0 yc7wNFgI5Ou2mnJz8NaHDB2UyfVU/Jwo/HkPg3XWJBy9OZZ4jVUspBhwGWBL 9ZFyN3JzigHH82DULg/sGJyRzwjMUSY6IFISG/wgxorrH3YEQP2sp1rPlRxL g2EWgNjIQOI81Rm8TrRl/jxn6AG9TE5nfOMEfykEDzqFrvE4ciER+bWsyd5c aJlquv5SIJhaAgBCgUBtyeFtsjzNuELzev/gEVpnRrffDi66b0fr8GO/eHZA L+DnRXcDLoBqupxT7Uqy6wyr6gV1gGa/74rjZx9mcGegkaeDn3X3Lrod1MDT MACGbmc/7//2t4Pb3c8wsX3ZZlGADJlV9YwMUZRjrP1mOsMW32HaOvzjq+kC uA/865viaNEm9wrSBFb/LEejYoIYU07ezIsI7+QiKsbOd6rhC0qOx8IyZRki 1ocPwU0uD25d7konE9bzohdWz1QYJHofFhJTbRdFy9STxTgUcBfGcTIG7AMe 53xMvpinM1JFhj0kZSG9xqwmM4x2YUsUFiIQj6VVbdqaljZxfyAHYTSrLtlj 5HysChbTEWIF1KMpVjm7u+1N+k9Rkp9M2AcnUhWSPts6lXnsoD9FQXZ7LhJD /pzzU4YeQaVUW78UNbOgG0erMR8ehiGI7pSM3U8tBk2EP1mrfhL4nLZMRlWM DLtdKlpOSFSd5bMGtJECgqFYha/HJJmrRb0IA0/HIUdRHCxYYK5U0flxZB8s heyD8ApPDpUyF/dJ0lCWk7iCOXZuyss9hxP6cLflscA1lW5cOzH9wTtdlqag 5lWHQlIWxkSF5xfJSi6fcPNkwipiG+RcggUiL/p8hFL0k9evdWbkncujvwIG Hi/ts6KYhP3gLziBbAWrK/RmO80/PF9YWAvwiBRfJAz5f4q7OndGPNeqSk7U ZADfaSYCZsxWNa+jIi+hbbIPTqOclAvM9bmX+QnxpYtxburVS2s2nSH9olxB uFkdN9YLMjirJ232CIfbydqzD21JJ4LnHCUg1F+wDomPLRvzya371yVGpHKt pykGueEEaTJwlYiON0z9+eR7nucl04BJ0vd0Nc+YP1zXpWsSablQBhgL1FkB PlZntLQUo58AdBk9YPCwVjCKKn4zR/0MPsTFIsXjOtFhxAB7+gdmX+85ysOj ZlrODMHcGSGUc6EmC21GQqzb0Wh7RcsilwPjLHnDwhmdTz+Up5Rwhku+Ahn7 rZhPs0o3k3wmG7bF4Ay9b1Hno2lQDDx3hexLPSUZ9oy+lctFT1LjZ1hOeoxr RE30bQowRbP/bY2+QPcYcT9ExKGv8AcQ/zMqGXxrgYaHEhP3cbEkuHv5nOYV pvIRQ/ZhMZ6ekfwlZ5j/RW5scK+9GxQarGXDmxYJGHFVycrj3xvc0667JohE xacz/mZdcEf35HveX+oIg6XHBDBYJW0FLPtF/kI09IFY8KdfzYv8naYmoGLK vLDSLx5PXDE/Uv0BV1yGm5XWepLDpTuZLo9PBiSoCFMaYIW43skUbjE9yTYy f96y8MUWR5FHVLLFwWXmZ+JwlKncKiSTB7BbHu02LXUfVamaF2NCbBB3jtCx obO+t9Hf6xJMnKu6EvTojHAyvEf17V6PpsnN1skt5Hb0/I56bK4nT3dNlgj3 CrDftI+OGuyGp3T0Ujxz7wviZ3UZNc+K8OKjsMEiyT1ljuVb4kuIp4gcoKJG XvtNsl3Bwh0wUsorxAwTvEPr8wu2rZo1+oUwMsZC1iezn9mHB0aDtX3sVsAP BYNwStjfdDg4nI7OB5SNY/QEsHdEIeUD9siVKPFOGIVV12FG/kqgdXrmbldG Qm8n6IYiAlkjJSPRNLq1iTt+WhwYbLz2IaYCJF4RFQ+XgAOXp2tu1aDg3auq k+kZiCCFF3DxWdhB+Yw5257eFpR9+YA5Bi6ArFHSrBrX3pw/MTLsGnhBnKau jK99tXgSD08cOaWawKJ2RI1aIcqVSx5n0jX/toBXk25M9qXm4TzdCOygBTNN Uf/sIpID0OvijHVkcFJ5hcIKzmgp8Mf7slI/0eVsSkEyw3xU9E9I4nPwBnnF EjyzXbqCO0drHLKA5BmhkpU8IsQQ+U5K4dJ1zEJ8DOQOx1uYkEPyHtaHx1xN /cW0f0jZpylUJTgcr8RNRQYD8goblhd6gP6GgkQuYNN1YnqYJlkyrpz70SZ5 mdzZIGcboVq9kpXELeg6nA0rgtSN60BKRT9VgJqUdkbJGCiRDBqqz+blQiwf zc4gCt1eIH9eHRNi/VmmlTZTNhPZmaOoTdEWEFKhxyh58mICqUU+wcrwR8QN STICPflXHclwZ7v1azZegU/tvNb2PelgNyzOaSe4gN3HFdp7PLG1un9aJ9Ao oehgnUV6Dc5svcZg44f2yWJ6fBxV1pYEtQ4koiWsQoYTKZaauttwi0es3cTx qEwy/cKZdWr6+0s0ziyqNJwHnr3hq6Yj4McyqgiaznKbNAvTkQOS6PjmRM4w gPaNWsbJD5seH04/XMzzUTntfrZRZurQP1/kx8IeQOMHpLU72P/x7cbbzYdv P9zZfLt4O387eXt0sN71X3GeFjfKZxdvN2CkX/L3+UUxPM273EK+obwlPwj9 xEtnPGUHe/zf/LjyHvX/Qi8RdEPbvoM5CXE4TF8oDFKrljgOE+Owh9tUEq3t U9XLB1WBSU/MFWvvlv516yFqFx9scIOHVIqTuuWhyYN6XgG3Qv5Gp/mxGEJF l+PPNDkswZcUJ3CWn0vCqBxFoeXMdTXIXk+l/ix2ChsOkuhEcm2VVOR3elqy p8GDBbJOD/Hq0NowcjnZxY/5Bop8ZGtd4KbLsuRv8owcTsfY5k5o8wAeHc9h ctLafsYfLubpdzwpGYL+Tr6g2WzXvniwmOtX84eNn6InK18F2ANWSW2T5uSA FEWrtluQYgC7TgsA7HCPSIFrbWhQ12BxNJ0u3G8Fgn+Ua7I9+wghvhv6PPHv ME13xLk/RgO1FWRHjOiuwt5+cNLUREVi4dA7AiXOvpXIlVhbLA48ZBEe/u8E SztYtMfNrXvw/7qmvDROWHqWiSEbIax49dX5GyEFdL+aucSFJaCgecmHHVom Cu+3hUf3GW+SkX9FyvaaTuB0jpmErzNq+tHKEcOn+6qA5ElA81oUHD4ENkY5 /Nq2RReSet4U82Noua9t0QSEAyYhF6zulLxN+fydJbjKqeo8nvao7nyB9zC6 dzsholj8g6o8Y5ZOy7gDzILCP0gTIZ9Skk0JIROlsfFJbCKuR7kFMWvhz/ax Dc9Fgm/4wb3TATGl7qWYxnwH5Aog15YIwnOMncQYoAcXf7/56O3Z+u6Gl4IP lyDRfT3Pj1lglPXbFglAMSRaclz1spIq+owCYMTZAqVI2NIeHVvuA20NvewX XNeRjOHwjYVVFadtEl0VrJ2g9odA78QpBlbi5yYmJOcubRqxkaRR4QAC0YnV smAJG15zNlauuFaV/MGe1iXvZa9ANFxMT//tdeZ8yOEjdCQTS8JPPQ6sxawp XfaYpdizfDIsEZQ/FIf/Xi4cL6MHR6I8Ywf5R2L+pdqs3pueElVwpBVG7RLC UFm7PKPDN6HcQWsRvblBeKX5W2NxhEYXh7h4r9/An6hOCJ/UZhBGt3DVGuPG BmP8X9hCRaxYGRKPawoRkDfet8O4LNgDE1Hm4/K3gtIF5JjFGR1Zsf68hubx sEjeMFRMuDpRr4cgnH27W7Muqc3qEVFra5Qt2u62faKCpNbX206v62C0LieT Yk7cE3+nKjnZdATZKyAMZGG1+axL0ztWEZoXOyzIFXyO2k9qMkMeSlKRzMmC O+SEfIxYNuam1qtSE/4vLrY67MkAXc5oF1TW/d9yHHByQ5zYCzrb3QbxlcwN 01l/jFmhlYRJOiJeoaEbqTBkndqP+AGRlxohntIRSqk8n8Ea0fHk5tad7ft3 ura/iKmSBDEoCWIJWELSZb9YMa5TaRlxbeipxcRzt2Xb1lHvfJraPhHMgxCQ jhv1rpwFRlyvULEr65Uc0h5mHUx+27+7+WXIwWP3hS+TPRFvWr4wQpNu9jDr WyJ3lvL8JYMP+bdQlUSXUVeC6eXjVJ3XMH073XrB5ccDiGX7lfdspjrcDZAA vjfboctXSEzm7wu5UZUVwdWDgCIlBDjLhU5dlp5wKAtWvYaImCfASiPScd4/ SjxvmyDskDpsZVrfuoYK0Ot+9otDBNNwOWHUUfuB+fVEsVQyYH2XfHopz8Ep GJmNSyV+ZC4c32AeDZcxDiMKrW/enqSD+q3ASuHZsmG00JgatM2oX6NqSNP6 8L/bLt86KUJZFUJV4iSrHNv8OQsIUIWtO1t4gnynP1AW0wppG6IlCB8//PCY 2/yMX/9MdrufcTt+5lxkmK4DmU0LtiX1NHxFwWf3N1FuoSVEjWBd2AdeX6TG YMt6YzvSd1CiVvtzdWOcI7ZUgI3Qe9bvCYN7JTDxinDiG6flZUIfgsDHmExL 5iJQHk7nzLkh2VJsgIMhepABtX4y5nJSOCnqhHkTVp81PLGbbSCDpbMmkdOL m8GkjTQTboGcteSqM+qqbYidJ7iYGBB4DH7H4UcMMc8AtB9oVw8/gKCvf+Ol oYubTGllTwQie9mNG81LDAvy09hFnVdHtF5J5mF/MJJXpInC4jJr83fFOSXd RbnjR/jBGQmmgJrhcefRDj25IGt7Mb+QiwW6Wl6MYMfgf6az7sVwXA7fUQeI oIhPnKqH+tj/cXBwu4vudoPOYL170Y2EGyYyb+Zktf09pImnLAYfaw2/xnwF UUvJYPBxtZ6ElNNFdnNre/v+Np00yg1TTo6mTsjMj4rHlI5LqQgntZSYdjVy WZZk3xSFuRDWPifn6OxjNPvY4d2Etaml58PcuojpRlSnwOd9PemJFycHXuOn GquaZ6fApIoXaLWhpbZaNQ/RqlH4wRhFft1/KS788ZSyNFefvq57nIp4kPZn vfjANryQtCdxPJduGxxUWWyke0w8hO2iTGOmUnhSY/HKPxDQardOoe9VI+KV znYDYIkoQCVYESKg9bhkg4Sq+AXJWlcsy8tnSf8roF3LtBBD269cpsRzshDA xpwHSRJE60yR8ZKOrrt7H1tRnA/Xk+WFHnGOfDvQCWBuWOrhFTtFV4JLg8Fn JdM8yWmWZKJnDnRPcsoNE5KmVujcyPViJS+6MnjIARChCLaI7mB6dGS97jo7 Ck9DXQwbq7NZFBU5ECFrcYw5cKsp++PO6XRL9NSS0ttwp7SqwTHny5Vx6Bc5 xPkHxk0fU65d0cdFLraNlhuNUXwvSeB9sIDk/mbksC2nniUx+8btVnY7+ycV OHN1FojY5pP8GFdCXVcZSKRoAJihN4kYCSXGiO4YTIo0wM4wkyoJvU8LgMmz 0RmI/NWtTJPFZ+PycI61nGQMsziWoyKvsIeNll+T2E5YE7eT/U5xCtBZc0gS rFgoan3ZjEhIo7kJ0LvnAB0ahdOQ9izogNcMv3uhMYf6cdVzG8biVuz2rHq0 r0j0LSbhaSCksRE8SDFP2fdssYBNVpAv0JBD32LUC1zgG8PpqctE3MEoYE5n yZl8NYuiEqUbNnhkOYxlHMNfKu1dUlLikGbRBT3ju3FZLHXHBAQ6mPwcaIEM jVYLwAYQyMvd8GZuT6nNwLdwZMo38aRM12H6gRyj5kGeK0e295WExIfK6FRt iWHNBZeoC9FhW0L5lEHT0tXiFK7pjMchO3TWKQbHg559mQjttfo7QHhHA3FW VfNAJx03ObuhsFjggLXai4KU02cvJ+WvwIw+f9rjukgodcOAG0KogM/XhDyM LbqDRJCi7Zs3Eik/mefofOY8B25VQmrhDlwOSYym2vCIpnZEXTgyBXai3sdm 09FjwHpmROOBPDG5eGULdkljviHqTkp5uC94NkmfK5tFN1Skksa4g1xrnbPD BEOA4qUiOg1swfFxMe9Q8gj9nkKs8G6jj6wAi1RfyeF4HnNGiiVV55Cc1sp4 M/sh+SRSk1RQFEXjQ+fYsmCVgySMjBqinwViZ83/3tU8TDIJeqQQKFpSEdmc kAr08BwVw5LGUrhe5WpUB3JZtkrSCOOICwmI8qlmVBWzSOOhYnFHdM3KeZKe xiLJNdhKSboqdLZEYxvIPk/8lNXCNvdqNi5RszGgHyDjdIJe/g1lRr6NqoXb LBrIVTIV2kTJPnWAPgpFWZAXFK9drF+srQthy8+PlD8inzn0oa5krKXmC+R7 La5xpOGWhSXw4mg/uwYDQWB0kcfKvyMUXIb95449FpTphazLyRTyWalhgZZL nuvA6hwsiYJ1+kj7GGD8NdZWpC3bsceHQP0kOyaaT0VEi5ymZRKWtndSnJEz MOU2+zOrtwuMVBF5JQQZkzrFQI8uTTdGcFiSxe8wgOi34udOzHxIrirLQaXk fMdoMD1Fcm6PiLhLeXGB7E6QVug5+mBWUqQ0vPNk5sNszud24NuKmjNcZ9Kd 4viOY6MGv0zLiZwcwuae5wGceSvcPFF9LslycCQuc/5+sRvB8HxPSJPtXdC8 rm6zpzTC2hjePZGg1U1XEgGPL4kvSdkk1VhG+F/ZOpjAVyyIBeXxDcVpQMzl TPOCr0VPo2wDzA57NtVfdN1E2OPeggtlbdIhBVbje43pjcZgYGn12kCimEOS mUNP1rl7Fq0lHI8ouvuGPR80sTLuWA0Stsb/3E2nJ2ZrseMF/kZ3CAtg9zLd +orVotNJwLSU+Qv4gtcD5gdrRqD19R56FUWrXUsMtvYlGwZqbXUF/14UM6mk CHwC54wyTHtPh2fOrhzIKvbY8ZrZF2CZT8vfzFgb0TyWy9yR8CWcQiVt4rSN t5nOOQ/8kc6Ao4XMV7Mpx3mzjBeUKKeo+h69MV2TiHq/sDRG4PwfE+/SJJJA F1eKfomcxgV8rmZ864LcS1SD0K6RVINGpaDRVTXcLm/UaU4l08hxj/jI/19j vb6fICsQLl+QpafiP2/dkniihSW6xgoZjjYyYLHq03bt9wbeOs5EImH4ARSN WF7L6NfE8X0ae/LXcVKXXpZuW9WdgbeLwyrXovD8zo8Xb98OuhiXX2cI4E3n 0c7g9ltMAiBZszr447Nu27EFYta3rPk8n5bwSnpB/xKIf5SlsskRwzNl+s0+ 9HDg76BORImwTpeh757TYgzssQaWYm5+lcDxu/iGir6VS819Jw477PGALFZo HIhAN/7GNtup9pOBXBO57GP99u3bJFs2fNBNL1132QFN3rKL2+uOkh6UwWi+ HDnnjZ2DmIkQDUfoI36xmploZlACOlE2pXKY8JrEZWqpqczCTknjoTUN7GhQ lj7ptUNuspWLYCYKji0rjO3BGsmU75orqtMI0Gh6tEJgc+UADMkxb2uC4rEf grGSiyKfj6Znkxo3qS/i9FWelawpU5rYSat0aiVsY2NQrZfIzUlyasV0xfnz tPw+WT7jpNIEVQaFLRlPQZ6dE6+jl3BznYH04l2RSKotU+bmbTNacRo60aJ4 fmZCwaXPvI1DVXp5hrE9VAJN5sTNLKkmf6vMlOYOJX9RUZlHhP+o/JCMZwnu SnQh5SQRrIUceY5I0YryC3G6Ysy8wLlUxOGolmpKktuFi6CTMD9sn2gbpPgi Qrc+UU65C8MzZSvvs/Sz3yNrDQt+H7AQXgTNeU4hCguYKbXpoCsWKVm6EYBb vGrOESXXGvWvtVexECJ5yKagiApuch8l9WENxXVWsFdUbnrhQityBOfS6y3T 1kt6vuKpYBVlxjL2hG8fOVB4AODQoKb3MC/HeABGRYURGa2EYPr+MPC6/ljO Pu+e2uZSC2EDXxqiO52CwyNWuq9Gq2oDBrY82E2+W06c6EUS/i4C4pyY3DOM T8MYHUzQh/4f+TF7hh0CHcdSEUvy6FLvreC8Jach3PT/wYnC1KMPiSpPt6xe hX5fwzgzqvjtlckDiXK3LZXeB4Wm2Wl0IPP8hn7h+A6bCVFHm81zDRpdOS3V SLwxLTBvJ/k4cShottVlsRBIpWOIAcfu6At92uFLh1KAZdXyUCt8/brMxywz Y8iUeDhSAXcZrkNFwywvjx+pO3C3k3DLgY9B5/Lk2RVcj15AHsE8Hwd/7/oW YjIP3YUc0xqe0Qk3RkKOGni8A6VxerMZP1XTSGAGQ9a1eyTRtD4R04QTWZFP WHlRlTQomfQeB3rUD21YuKTZlABX9au213iMHFqF91Fu8rjeZUS1ptXiSrJV I03+I/XcbHjXRKCMEKkd3cFjV25nPVI7qe+BJzeWlq6MLkjgVu3m/KepDOSB GvQqfyMqyZO7LVUYNvO6nAhvOdf7Z7AgSqI08GuUZfUDT2bZPyYaIqTbSpyu 5OlX43z4rn8yBSR9/Z//yB4Ah/SQ6ldRTazFvEC7Mzklb21vfbnZlZmFWIiG AVymrjvuHSd5hZ3svy+nY05RQi5pqEIblUN+wkbW2bzEmkyZeLRh/uuFuUdv f/n5lgbGa3Gts7Ozwdk2VdV6893G05ff9r9Bx/P+dp+u/2rjJkGyjxjXp1Eb wOJqEGxQNXAuOkm17aZnlCu0zTNuI09O7p3sdglYwDo2o28/85R/RndsqtO5 fXebJq36nkFITkl9kmjFb2S1D9l1RumZRucgYiAdIEYhYzTBLQk5Jkg25EBe Z6+ccmkW9J91duxKQli/7MYN4fbEzKy6Q1NKHYFMqkuy1rn5+f2trV5288ut z+/BP1tb21/eoX+/+FwqM7Aj9rJW0Rov1MsAgZ/YgPiOVSGBhCWn0Gnn19Lz aNbhNc/FbTIXFx2XuGb6KhVAaSoAD9jp5Ahmv+ByKVJsOFTKdjmXGN7bWrkC aErWKISvZ+2sbQMRINOV7SNFQh5zxbVQA4V94O9OZ7FRq/BaiOkmmieB3RR1 T/upkQY7SXtycXAfaWr3ffroAD1lfW0Qq3Zx6fLqC9JtX6EGT6+oqHv7NhGO Y5otPf9O2L6Dsw/3w07aVfaxWZkQ7kSyKJyQ0iAvJ0joOhoR1ycuqesJOR9q lgQayfqDVIuV+G9cYwlBT8NqmniAbtZQo8N3rtdpPhohixDLuljehO57ntWK 0ttePgtHRcujMD9ttcO51LakiE0rcFMSOS7BbGL91zYfmQmjdi0zniuegwxc OcH4EBXTBet0/dBRc9N48+VU/Jmh6o18YsUwFK88qSge1UxZBX05nQHWK6Dd DG96oXqL6KGvmS7gqKWCwFmDkB6VkWwAiHPYdGAINuecq1vSxsbf0wag2sLj WG0QnYqwlzs0KDrb7AQv1Feaid6kJ+BMjosBNovsWYfLQ04uB0LQGcWaUBua yPQrfBnKxVOWxaPpcFm5kZBtinU9aJDQGsTVNDscL+cb9BXQxV+XBXJo6DfE ARrYi0yylqTEYR6xDk1u9Jj1F5GOBwjRiPbM2P+kKKGRu4jDZe+ENn1ZTtq6 aFzDjliIrjHZvSsmi90lc8VHf3yq0+XC5krciN8guJQ13KSHuodku9A9OAqd 0ey7FAt6zSV7bkjGattyaUZxDgBRr2koVQIM+uAa0PArnAPK9Q8xJJQKfk4q svEPsVofcTp+4ToA8odYUZcMLiFLRpN3t5tIWIUXc2A1edvTDJreIZVoYl84 QSAvDTaPpSxtTTS5s7mu7/SRxkDlYwyeFicNniiHFB2VxXikVaSA4jqlRSR3 10ra8tsVFL/h5cCPupcKsTF3weVwW3VVe1bPHsy3q6nsJcvHGzxn7fKoTUsD XlCzrHoX45bzDXGDJO4hq153kqF3k2nXJ1zNh5z8sgoTfUyezyybLkrW6yGz PZXaSLeA3t9CIe1sOh+1zOmHPU5FojWfyYFuQ3TT1G8MP5FdiyF+FqniWX0x H5ImdT4cOAtxw12/h2129Z3YYvUzFfFZaA13itQgUU9hUnaGco0gKiPRySut m0IKX+iG/C3NbwXj5zMy+FBwNsj2u5TMC12/OR6ZLhK+ugc6w7IS9dAr7Vvm O0ofi5ar8V1aLfWyUPY7FvApvUXnwbRZdO2HwDS+86NwFQbCE66tzsQlLujt x3+dH+VzkAj3Ps/62Rc6ATwg/GEFiDYe0eFn501N6AAC3b3Nuyj2bm+xjM87 q9rfDu8u/1QUoV+xULytPKpr4GT6nfgVrY5pfKJtxjbRM0M2ynFajKKW0bNd j96snHPeRwnChuPwaonFyNDcW2KcqDpReKF3OlF/qvrRCec8uEyI9yPfbrXz J1uakzc/nOxTyl1bTobTU7P9G0Gnc0IlbngB8Mlr+mQvOrT2ONSbn3C2M4k/ nb9DwwoWFC4/4AHj+ik1blR9oiQnVERuMIGWepo+ffnttp7zvApJZvHQIqCe Pfn28WsOcf8mnxwv0R38K1SUTY5bKxVfdzY3tzd+eNqvK8D6+Gpze3trA9Oe 9Tm+vH/IHVLii1azPEYROWuU/Q89+9E71DcERqlOIXZ82Bi1qFsn6m0uMWXU G78uT5eEuTtMDpBJiNXZNS6LLKYiV8dEORymRmoXiIzLe0MqLPnGJmN2oEbV OhuI1xK1+h+cZx1If3CmjVp+N9WmbfmDc75kh//E5Jt6ddkQOV9iwyI/6hl9 PhmOl5RcBIskT09Pp+q6yJSnpPdIWf5dw7HR1PptCMOW0zvkDyyijSL4YKb5 eAFfmphM13pR2e8hsibjSJIWD/w30yXGCoXHi/nY9zQqFnk5tp806VcneRU6 OoUW/gsMK/lX9Ov/2C8qieYbvy+LM/sB8kg+b/sZzp9MR2Gkd+5D+Dt6xxrt 5Kdb1hjTzvwr+R0mxjm5/5X8Du/FTPB8lD5h0U6XNwSWZ/Kv5HfohS/WFOSL qYid7knUgvLBrJJA+GSIQn8v0u9bjpTRSIwHyHajkcF815xwwS1c3LOlBtBk IkGXnriNyivdMEu6+ih9sSMPZPe8WT+epEjGW8S3jIujxW52h/4+LUfAa+4C L4O/VO71hl3uBOYvMKlJSy67wSUroy6li79bhLGteMv5R8ZN76RNt1c2vZs2 veOayqPNZpMjrZJJTC+2G4u+lGy7gZOhNeN1M98YF/l7C53i4GJ6i0mAN1DW ydWk3keehVUOFfZVTaWIDbM/rN0gKWk6JyObzqRFVguOQkCdIhfVoAPDc5Af PBUcTx7QHPTv5QL6aTWw0F+EhA78oAJernJrzBbTaTY9AhZvFysu7Hh+5nB5 DCztCVaIWp4SWzPb0J8bZVUti2qDqd6jcrR394vNO/e+xO/VsgxknFgbSufA Qjx0mXVKqZfLqbOnlP3kCfZbZLCoiqNEMXn2eNwd1Ah4mPtO1rbtwDSD9IMA ZW+Wi3agQPqRg6B7qx8GmLYRY2K1KOqaPjAuNrsgYCPiPBFbY60WfElqN/Hf lQctNRSsVNFoMSFC/4X3TerJieCLOKgnnBjhY4/YeJZ4YpjX7teU5iPB/aH6 Dzh/Sx0POGgAUgXiBQuxLCZJby++2sleTLNYzBFNDo1CtGqDxirYHqN6LtbY Gg24oeNR4L7+IKuryXE3avmwVH+l7btOH+dNnQ0+I7tKZ6K36hR8Wa6CpGvY X9OcRdk9mafbvaSuJdyrk7RMX2MOlEQ9P0mSEDR9wKp2GKBWCPCvGUF8jHmQ o6NLB7Huo+QAPXNrtwQfVNuIYx1idj48d5ZHn6dDz1KmvqCJO2IrOR9JZ7SD llSb3iV+gpzeIj5nzgtKzLgNvknrFCGx3ug7tbPqq+RAD+LwwBq+4tMo5YZa Mj966F6a+MZnqpHsBPthDw8k8cnqxDOiecMUIGnmmSjnjM99t2qykRM8654k CKKWAUaxrmkduICjyYHL2XLtDDurMrQ0pWjxuXOurjmq1NvXR3e5RJJMBHG9 dMxQ1VrbuJ0V1Riur774a2Sn+Yf+uJhgag+pOVDY9X5cLk6Wh0AzTzf4K/1H rvbtO3fut9bmH1Ah8YayhG486Dy6gYm5Lg4xs9X4AvNLji5O5hfl6fEF2T0u 0PRwgZLOBUaan3Y7q/PD3+7u//gQ/vftxkOYTC9aQDGh+du842Rkm5QAu5c9 Gx0X2dYd/LXd4ohUaLFBj5lfmxfHxYeMMnVXGUV9D3O4fdBs9x5/YWUP1MNi fvQEPlLKcHBaoh0GeCQCFXR/VBQjLI0nzE+1sfXF9uf3tu5sALQm0+eY1szy EzMHdPGAiidcPEDobJQSnCcWqr2QcU6tWqjTmg8t09mG/Pm2uo11N3/cO7jY g781Ydugi12uuaSG3+aVfPkjCkZvNzqD211KN4ZVayeiy8LX0M2DG5hqbP/J 08dvHr/dv+j3uxf44ODtAf79EFp8tnHMLDImZKWMCJwdHTkoimhn3WjGnvMk lfBFTGH0xVmGN3tI7XWaT8oZag/gB9NQNYtIjlY+UnTSnF2Kvf1pjLZ63yYJ uCdOj0u1q7ZAstJOd6xNyHKKHc7VVhcOq9L79kNaaFtzabIrulXpTItdaFK1 74rZGIj4hlRuCdV4c0tfiORKkmaqCxfCDQ2slCPYwyhATo41758v7VRY+so9 tQ0dNyRChMY3QgYtuH828P6xj3drq3HJ5Ggp9ZHx4iYXHKR+KQa6ZMIiNFpW +VPnVOpnT8811NBpvJ1Bq2FZK/bCpk9ZAp9MZ+felgTyySIsouxlYzXMYUaC /CWiB/31BN11lvZsac9YNAw1o6DDBAEj7ilozbcGGc4mm83L9yh0crIA7s6H wBaL4UA7r8W4ospcuVqdsQ+G1YLu1G5XGz0hh6a4bg1OPKyaG4vYu2ePB2G1 Thti17wECekYwoDQfWrPrE/NznBp0KZzEIS9qQU2hliPNEd6eqdSci5eo4uN t444OGRFTlfYrDuyWUuUTnApbke+ryjvUsOOLOMdoYa1HVmGHUmTTXwMKCfe 59aN2zPrwBLkkx39A16UKL/3uI6iFEpBJY4jxCCgPMdLu/E8uCpwhteUIDxJ /00g+hrvQXS3wbzbINpL6hLvgcG1yyn/p7lu4IXHrrus6RkkVJ85OXGoQIVU VK1Gc1oEO29XxO5qMQi3JxnhotSmNlvjzQphr9AexAoLsZGJ9TS8FncSzBiE i6GEczMpiuhT8jUuAWttRc8102nbTz3KnhoZeCWT6VqcKnM0Pf0Wr4uOS1/N YQu+OrFPPs1QgNtlQYmPzuGSJnUMZSKHhUiwGdyXw3yhIu/+gY+F8GmMexz9 4yorwIl4rX/jiikvV63oQZiuKxFfvphqCtsxMnZW4o7DtzgcjBqaX2E4Pd7X UFzvZM9/oEI6mliXzLiWQVfKdTPPomiLtT4t+7oUabIB2b7egRk+ZA9qEUHe m2HcMlBqlFBDkl7DaLgpGZfVXTBxhnCASkQIqb7lVEWAqUcxbItfrdmuqVXc YpRo+mA7djzwcR3UA4khR2Sj7HS9wBZwEBtcgn1eeBG4ajZPlxU7qeAhvdmS aJZpunO2PUZnIBqVy/OtTnbPkp2+DDn11a3X58/0c+XIN6eg/45rL2lAFzLA yoNiab8Jp21EYgsYplM0NnAxpTI97yTjvkDQ5keLwIrDcS55zYpuJ+E0h71I E7v7JO69mJuUzQwHFymPZD4PZUmi2E61LYZ05qr5xRTMWC74VL5An58iH6kW mBdxWJAohpZ8DNXA5PTLmXxwWJDzwClQVtISR5mvh8WcDmpVLpZStbtz88vN LzY5eG1l6RQWFxwG+OwBJfFrRnyMkZBPVMGILztC0sjmZIkhuLnmeyFBCd1C KylehteebhLOkMs9M1sdqnFoTL5tQoig+2PFJv5EuYm04IQRd8UqhkLAqJrj Pf1jheSZmPhDTKV+uJcyyprTBIW1Na1aKxPZT/ATL4uUKvhqGKJSkI9afoF4 Vmx5kajjC2pYlspQlcC2lLipuctcKaXfdGNrwS5hdQnnKghniyzNz3xF6QL8 IC5doKkm1m7UZAHZs6i8UmhfU6Pjrc2eVT6YMzBpA+Z47QWlwyF2CMjC4397 /C9goDAvPjutYgzXGTmuzpcTAx10RultuTKNduQTA/yEhSW+n48DkMJc9Z2f z6420pCWKG8T/AcSNheeYNiF+iIgYZLoDnB2mhIqf9MlHmZFVMuKShAB2dPU 7D6DQdCHvgPSEZLGKhfuS0e5PDEW5cMVckIvIpzvWIXgUvOhKWnkhWehWgpF 9ogx2uMjW2BsWuLunEaQxXpMAhzLQ55SKH34aHctdeXc6rw92Q9Zw0r6MLn9 HZLihiQFRq4gWbR9yXTi6tDc/W5th03VUM8VGFUw8lYQUg5G/B2VnQqopypX LIH42dbDBxuf3XnYDjESdJvUM3ThWYd74ZkoEUYCQXsUh9KOeyhYPLOixyh5 2C8Ex1CYcFK81KosUJNy8gpd4f5QORqRUVWGYp2zYdyKog+ADJ2kABhjoKjk ksdbLkjfBIR/ffsNzCmq7yVMB4gIRQX8+Fn2uvztNyDupC8mi3wxh39OKRAX pLWKHGZUT/xLha9JOQxoBpdc/33Vr6iHjTusGQmgzUK1HQYwI6DbCtfCQayu DHGfXKYJiWR8/UCuXj8xrwSJIshR82HeolVIhWLcn0jKtBzdwFED4qmOrBkt Uxj4X7C7KUjW6nCNfrpPDM7NSqVrwnGtQYV4TXDK7eDvoLQzUX87jPB7cK06 S5dhWVy8aS1oK5OVgzS7aRJFTEEj+pDdkKMPB9LvTJ20BpnINC3KDBcLJ+Di s0Df5AJJaZwnYWxtdtEUNOdL89UwzdK70F2GxTipqSh68mD886hAwEN+araI cg1G8UNaHINe7gd1a3BOdvFBdmQGiQY0VZA2t4mSNrg8qjVeKbYwuux3Jr6s WRgKJVmnmsPD5SKUlW3o6VZFhiAsdWt8V8JvXZl/alTPPeXZN2W1TMYyQUj8 hh7sbd/D+lT31q3J46oCGdk5tDkhlG2DrLFmDSnu5E2eHvewct8Sm7DOzoJy 9oO612/27/93Jp/Mo3nyIX5ppUMKubfGnpVJvjhzcPH264b8iXTE61lGP6W3 0A+nQW4Ot5UuVPLhLlZE5krboL4LkH/kJUUczyqzs48GG/YxcVmnu8LA72MK 64xLw+MVz++7Q80BFFFlxPeiHXZiiRBhDf2nFr2GzGEKT65iVnMpt2JOquRL 3J96CaGOSOVfuGwk/OYB12RGlhQ0jkkQt7SGiobhmg3rByH0/0sBwOqIryh0 02gvvwp60GagcLznfwNM6rLfWvK8edp0/JpmSgUb/ndNdDCBM/q65NjBxkkT 7WiO4hD5/TKmhUOfVgrwLli0QWhXzZZG1p8CuZ2fZ8B/vYsUZA0iPa9QPaDi srNTclU+dxk2rOSx2PpX14Ztpc5fzSLvNYXdWA7ZS+SSPfO+53XsxO93iatO O95rGCx0FA+wU2+7m6yQlY/pjRFXjhetM6Pt1SvfjfELlQl/xR2pGGlIt6nZ 1dj30Ex7bNyjxXnLAWFi0w2LcdkrEHQtwIKaWM1IpywWty3OBIuWhAWn8jTm Fb3mf9EqotZDOOGXmO6yG96jKzHSqWrBql7Xqmhry6vLaHseUa2dzZWwnVkT yZCUW1y71O5hZeMDtXAlMqJzW7iaShUHHKwiDlcQl5j1vw4JWQtzjaqDesYm FQZkYa7cw3NlkUMXYudAK5MWogoFWI7EQJFh7uDpSBgnq06Ja0krJvhbImYA mc9wu6SE7dosmKgBfygXJ42Xghr+OMtWKySvDdViyIiBvZARDZPSY5Yx/VBr XetOU5YsSm4bDJV/4tbEOYo/4F56ezpCkJbPFiOzWTUfBE3EJSgknLjgDocw 89iGgfxbtauOA4wYCZdzmmMhhsH2SvbYoRrpPsZm5URoCnGGhAhvpjtZm/+k UBNmL+mp/I2PPe8Ab5jfCi8eM1fTJu4GH8taAALw1OFLErDCCYVMT+ejVo4m msMozvUQC2FK8VkhzBERkj2RZ2ZEqlZZhizAe2IEcwa6FewMBvuT1TiiW6zz 2UNt3R6/hhuWNm1Hk7DwxRhy8+t0eGBhjPYDEA5Mk2Tm7E82qmJCQmS2u2bC /kMGVvcR54GmiUnPtYRffJLgk9cgh7/jFKSEfxJGQlFCp3A6ywn5gG78yD82 aKX0drI8BTow+5BxGmnL+f9jB71AZ/AaXUK7nUc3Zh+66LX9t4P1z/DSKtvW CczuNboyV7WkJnp/1b21twSWIRnl9iam3ru3ef9LzNVwF/7q8pfwQQCZuURw sXKKFptNZ8uZ5Iv4+msg2fmE0/aGz47miNjBnwJeLI9Psrb6UJXFGQL5yfR0 toReaTltwXaMslWbR2S+GLivXfUQao+VQ/CPwXTmC/RIXxzOlG7n+6ZZOMn0 IxWeThhDzghBxmek7JTFd1Z+KMavplVJ6uC/w8MPr8vf4PV3xbgkEzU5/QG+ sFMK1TJDNfM4P8e4wTWNVizOsVgTm7bRFWwRghIpuBFzOWNImCuyN6TJE2Ec tCzHmjwuaElvcPBOQA2nW4Q5josF3sRnBWW7wSFkfHQKkZkOzaiA9b5jhY1B FSuBk4v9YFhVb/B228NWbYAGmmJgqJ3D6XxUzPvwZBfQnd7OBGw7FCVWvi92 MUYIALNzOJ4O31k7Pkk7+XIx3eVudrZmH3Zn+Qgj0elvbbqYzna2/rZ7Vo7g +r63+TcSbWrVzvlpXGsyVlGIKa2Yu5Tx0A3B1JCqAYEIRNh7hBf/STpx/X6A KbmpUOEWzq/VTAWRBvbhf7frpxef3yVcZhT7luDzTXG0SAY6tRfMWN+ZfaCl 15A0+Y7Ax5/cpU+uNUdphCrVimnUEP+mK5yYnFkB1zrA9bhgNkyyFWOibKQQ lLucc8tMbi0irOKFfIdB1Lh/urEE5G/Du8bly1fRYtK9j2zN6d5jOCXwjuUR G+Jwi+HEluhLwVPFLDjkszLSbN/Cq+cTyT6EjTEDGvDaU86ZQ/pl9nukqGV4 hWn4z9XWSXmLcCjRKbDVm5i7BLN6dZpDTxuAQ/GYdZShDG+26L1QNJ4JvwAJ biqYT5sZDJ7ZFQ3V3beclNUJMMJz9h8bl6clkrgOcsUSddrNisn7cj6d0KXR CgSHEWCFG3+SyJmikgQV8S19iZV82eKlDHd+dISJvGATl8hm6mNp1bn55X1K ARywDzEYQ5iAOoxLTJbTFjYdqRkiIjatmehXfoxfmDcq8NRzsrEraVk97F5t 4FbYtpT8AhvLlHJTiOGXQCVPCkQEeIRkcnMXQ4B3+vfhP6OgbSWqm7t8evpE UZHaKrHOD6vpGEgeLiMMH1FPoYKtNIeRrJqzbEZ4XM8D2HCL7TrVTHoKWM/e RNs+ueum42Tdp6fqj008PpbWef10fnL3jQdc/Wao9nnWpbABF5yznD95/doX t+kpDzEKnlCERb3stJz8IH/lH+Qvio5Prgi9ru5trbfUAj0vi/fIOPGRZjEr jITFg04o8BxzGACUSGFAjil8fcBtS3zXGZCJY7lBuDU64ZN9zDnywptKjhSx k/SDj4wMuBfGZncF5qy93wf0Dc81UyxHBES5AXeoTZbhwevcYh3RrW7WAYJ0 Xy7um1t37m1/0Y0a9vtcXVx7hi9ubm/dxUzhnCY8Ar+IfvpwkE6JRU3Wc2mj kCNX2TfqBGlIuzlkf7XPkGP6glqsChxzT8b3DgePMw21E/+Udn5W4BZnJ8gP HJ5nT0F2yJ6NzvL5qGrLR8JXfCWpCLQCqGMcKEqPUlUwB8EfkmcjMS1VgdLl gm5ZOQvnfOYwxDRigaXWOU4O8P/lt9loDiI+GfJ3WlFKfXpR4dadHVMiDvhr erpxcw4rGr8vRn1Dxth9Kj3rnK7VBEHRZ3JtCsr3Qk3Vr5T31DlIfQeYfXpY zGP/Hxt7Tdg2Pl/MxBFp0DNrr/QBv5VzHN7KA5PQMamdMDYouPKACGO0g+UB WVnpRlKNHL5Bfeh0NJ20ZGZIcf0smsl3GDW8cKq2kVt+3F9Yfm0m0fJr0wrL T50N62VHHjVK3BEjImK1ovJvzykShEGVVxqOcAxXqBz0dTyhO/yDXBsDpYa7 +R/F4p/T6bvnR8Snjuj6+3rCOca/noTooqc0Q84dAq9QyLuFKb2o6MF04uIA 0BdY64MBGzcenwt9G9jC8fQfFw2XkRArm0dSZwdnSs7FQjA707nWIVuEfM6A SBKHMJI82fApPDwF2s+uFurC3O2JRwI05pyzEvVI2hnJ7+iF02Ci4KnQNDDV J28gjqmpgkiudnF6mt42SORILwbuqu3YsJipROB/aYISSTsSEgYA5pzBB6Qn wBJVLP7y0JOCysUu8jl8zkpibEdfsRpdo7E1LLs/LMbjNhUr0gc5KdvbIbhe XSp1KD4+wZtyhKkS8W4ZnE5/A5ElJ3pXTPrfv94Adr/aAFK5IR8DfshfFayC 4tmRpy8uaPDOoxv94X6RH3QH6xL8bncete338SmQ0tdw7WNQamY8JtwWymX2 svcl4Ek5LtFK2z4pR4AK7Z4uAPW1qCxoZx+5sxfoKDp+M88nFcpRkgoIsARu 5tcz0snDN5ttzjs+WfzAPDEIh5ubbTV3VhVZfD6Qnm0/a/9QHL4rFwjob6e/ 4T+nVZui4MjuYKz75eKQsSDBHw+IZ1VpctBzqwU0hRdWGBHOIwjJI3SD5TlZ NtHzQBm4BYKWw/Hl8hBi8FpNcbjzlOSEcT7H9NWA40n/GgWKfWBYcFhjZLXE 90EWIx9hGiCdLQ3ITCTgo8S04kMOI1tMv4dVqx2O655qJYYtljZRYe32xJk1 tWZYadVKJ9y/a85a6HUdfFev6ZXrSxYovlnxvqV7lmNdxewMoaqcVUWJKUHO XB4fkw4Qo7Om2Eu+ckcHPjoYbveGHdWEVM7vW0ZydRE0ddMi4iBXtEcTXzP+ YMCs7nKUQslHU1TAjtLBfV+8WCJ/olyh2Nqq5SEWK1oEfHxMzgms88s66xv9 rjIVlKFWVSGY0ZnaT+hMl7+pXrSsOA2bS39AJ3WO5395Glt/d23m2lBv7X8s gfc0PjDc6m2dMSaeGBwPehxvjCUz8crGELiqwgsF2Y5v88UJsg8ddGiWEbi+ bx+9QnXtAMlN4ubWrfwKNNuWqs2zD21xaBNbq4dvvqRoOWJKXs7/SfQqltZA vp7nPbg2viKZ/ytMyi8qOJdfgXtX2w9bas8CtE9Uu0y5ClG1Xy3nBcsB7Hwq ExFLHFticWQSKzp++OyR6h+AlTGtRUjKjwf6rsziJUZpnpXkG1AiwYN9JjoC RKv8DcWTcUZUZb4oh/C3T1vtHF1LISos4xD314ZpbMH4m0KlvIX+Lv6zvidJ EBkfvkKFPobFn06Br8B6tZQMNWO2vIesAnBgyDSwswPVWCwtrWOAhWis22aK gGmv++On28efrCM+PSMnUXFl59BG3UKTqyRyOIDZCQdBvy5JWgvMC0PKHJq5 MU5+8sHcXFuC2zP1fRtn/aZFqM6ofa2FBJbssT/KCouSElXzYvDce+DLEvhl MucbDWC/ZMqKnOmMkfumg9ZeMXfnXH31MgSGhjkCqEtR4lOgee0ZECQ9NuBs VsPRpuAB2TzbPwPISLh6j2oqT/aAr76K5DkOB9lk5pKDQgkHZOJHVPW5I4+q HZJQjVjzEyhlk2pM18E5EMJZXAEe0SW2LUDeCDMds3Bs20IP1aIEF1JpUoho MDJMEc1MPLoGMeg0a0eqV3hPTgcRy0ZArnNsrCjDew2YMOBOLBUkZahV0XU5 UeWiCd2SbTS1g2UVcGUTDBdH556KTUCiB7I+glautZbuDzoduF/k6WXq40FN QdshToW2bM+r+4zBCXlSsAyNzIZTJxOObTCK8T3/XtV8bbQ4tkNpkBNScnP8 eDkZowBpZm5CvcnUkv8jV0TaSqx4uH3viy1V7eksuXPz9BhbrEqb59UWVvha TDJna+I1vlBmiTzecJSe+pGhLw7XWcfT05Jh4WlVfD2e5oYzyKwIxDTZQE5l h7Jg0OVLkmSV0WjD+JxyDhtcvMfLhRG9FcRloiKw2kaGpiUOJ+ShQieNntAx p9Sj12Evei3130sO+5pOZg32gVJvkSmwKXC0pUmeMcUBYbPx+ijk8/ZjxM28 pEToLk1Ni3MnACdVYpsjU1kj/BUh8qRXEjeJm+RiPlMUUlHWJdIbq10sT1uk Hl5rUBq31K/wh0LrdeTjM5DURWk3IU6dzwLFFMqw/F0QMWIK2JZWbXMXdKox US7D3mzhtqhCL45xkdx7XCkSkRN4YWTrgFbgnUScMFOKqlAV0XkfSeG4CKIy MX/M7B8WUkWrnU/KU+JNn4OoT39QAb+Qp30NMGUMNLL2+Kgcj1/KyvzjcfHh H0AK02evT+bl5F301BQJ/ilSiH/Wnk7rAzEqRw9mJ/mk8o+AowWi7J+wKjF6 Mp2etrW0moJaUNlVIDmjwtSsBzifLoF2VScIdMytzFYZdksRhGUCv1Bcl3J2 KkQK8I+QfrTxMFYV0ZJ2mME/ioWeAFazxacKRRxKuofW0xaf1DrO8+UrIqW/ /QM6Yf9yu6KGE+2gObvJBJda09HTVd8Yt7zd/PhLcjQKl8sKVxh1B0XhibUs ZwV69mDmcbJeqbsni1m4rFZIMq3loZAcEN1CNb+oTJS9gF9jughESmefvuqJ 1645XVtkTgi0sGYX+yMzHyB5oVpo/L1Wnf8VZxqwhfXL7HcE1CTjyTkKSOhW Up1ldALBawqzvfVFIh/YrkXLlA0QjU+iLzHARWYpQMUqrr9tKhjJfY5uqSjs T9IX0AHTf8/oEd02NiPUywmvbB7mLcx8F0lhCN5wL2ihSOep31jlXFI1esd5 kwWeTCdkImmv71E+03Z/r82p1kTdwoQfU/Z8sX33XtfY/1Bsz7nfi9WwWbEi RqtiQf70XlbgZGEjdPqvsc/iOKl6/q9JyYp56W/ev7P9BT2W9bV5qu1YakxQ lOI+8JS/yF+oEgk9joUcwCq3tj4Pq9QoA/6OmUYBc1wqtMmG8PwoXJxnWGIs ryry+enR3YXYRDx7R9TzlIlVkiUh2gcS3AR2WW0Cx3WuXa+AFoVRx+EZ34Ee 0fAKJsaI1ErxGoJTSf+21HRhf5hgUCRPlluVs6zFVs3UZwXm5oI3CG+INlDG spdHHeDVbNC2yD3BuTxm1ClXH8g35aLdAHs6uAR5qaulUQT5Qm+GqWmTKOTE rhyrKWXVWHlRfKSRssM8ie0uJ8LndbWMm6ENv+D8j5GKU++jbsOBDQxaE/FS A2QVbPodf9eZf3wU0p0CzUVoBEf6VFHRDELiB8m0O530E1OuJpuYB4AxaGCL 28cRsCQYRwkGA8qlFhbh90pAxXn6w/6/jPdVJx3PUzgLLalmvUXgUo2+GHpW cRqiU/VqVFUlYCzJ6X/jJf1X38Ygqanz4v+y6/jN/Dy2EwHNxNqWofabu4eF VfprLuErDsNlB+HSc+A0vg2ngDVhcgg8IAy9e7g5OUzqXB0sGqZD5VuqQPwc z5DE9kXTuUyb5SdjPATbXYh/iGeQDmgthfaLjSS1xcazqb2PT6g7A1SMuxwi aI4wNGhEiRyBy8zHSNTn8R4iN4BDjGlD5NtWXcNN+WCDJIGouzxt0od4/7rw PXl5YibICh1cMRs2ft6Fyxf/JXvPjijc4tAD0cE1xC3tZ2120UQTs5gwDnxI UamuVi6WqHYA9hr8NRLFQS9e9wr1AaKCsC8hFiSfsKVoVMID5Ithr4+mYlQo J2SsH5Mf9xmi7qn2hC5aQHROkXqzlS+T0pzmi8DUm2kdaSwOiwng8SK6GJzH gRDNBrWrNGoLk9qQ+0PqMX0Zcn68Ia0kawjIyCdNaLJ4Of5WzCOlYfb3DB9Z BwDxr5DHAer8hKq2fQe3UKcrHknLCSkwnIuHeDAN6pPzcTv29rvlhGK5G4dh IRo6l6oJSC5JmpaPy4mL7cE4zPl8OpeRRRimaAbrsIKJS9iYib2XL7CrpVbW cG8M49i9o9eQlMP29FqaftE3oROrVmdZu/6HoXp21XQuamoF0YGJobYXOFW8 ebgZ516qWw6goSpDXdOVOk+n9XR6T9F8yt9/0rDQc0wjhw53a/Ii5g4nGwOe ZPFOIwGOk2mqz6tRC1sjSYlXmOBDsPZK2zfbnT6EajFrDWr8iNFNwrQdcII3 alyh7vqOCs5Zy1NpJbVRYE3iladSUt0RuxditFYocpt8f4P63N9LiVo2zIdJ nggul55a9P7P+q3aif09O3Xu55vZx8az67MCXDaCHNuPXOvHqd7F/ifF/96Q vpdZKGE3iQVknW7BoWkzNmOYBrhWmo7jxNDugfU8OZCBf0kwhNok40Bd5jBx /4/S8nLhcuVGMH1ppfcsT2tVggd2vQiZGbg1OZ//zvRI800tURurYXmqZZDc rGgymIvhGAOqKQ3G6rwJjyR9ONw0JbqfZeRcAtwFtz3wGQ2DN4TLV6CzdKuu WXcDGHiHaVqW28B+9ckVJjzZlHS60cHU8cKxMw+myCVaZqNGzav3CMVq9DRO D36dAYuzbSVyYSSPXydxR01l7dGB6XAvg+uVkeKUnCejPB4uUp8C9AdlJYH6 zi08upQa4hfwPVafYseYKBlInK0Cq09G+SpOMZ0GWx9xQw9WkllxTEhuINVE eMYNuqxvfJOSM0r4VYsyCPDc8e0aqf/HxGpQS/rwUEvlaR0vcz54c1YUto9S YIKrr/cwUzr8T06+yQQxdRcszvi7UDF8gJLBdbpBU6QshboAgNO/MKmky6xe hJxaULqCsoG3WT1sj9WVvOucRiNkYtzVZzNWVuA/9kymvafzDzI3Pxj8JBZR +0JmAZ/IX/aGPJw1V8WEPIE5ucByzqFNPOKEKmxORvaE5r7HS1ihEqWp19Wh 5Cm8rCeqoiKIol0wqM+EtgRYHPgcQqYHMFmfEdiJ/j5dXdKtwcm3lBnOl1EJ SomB8akhcrgkezbYdSYdUmrJLgxGSzaVmm2BvphWvLd0UUU7K33Kvh8wCytz 663o+nZmDTZ72daKZq01KZXoVZ0N05G+5K5Yc2gjS0NU6WcOt7owA/563T1e AZBqUcwiYPgXriLHwOcYQwEnZDMJvnoJdlTmj7vmNMnuQ7fylZiSfhNwUTN2 UTH3JkoUUZGkgf+Eh2RKo+PuNGkVFkSr3N02Lyo69SJdfE/uRN7SS6mMJeJ2 VEpRCXK7Cc5ObA2WVj3pajrnZqSF45YsS4SIQhuHaz+Tkmxg9yjNdRDbdW9I MkDC4tBgXxoL/bgRSo27TkQ0iVqG4m7eipSt6jlWcb/KOd4lF5d0YfooSijb nqP7IKbW4KrRFEgoQeXei0L6wtJC0AcC36QGUoxZtiUKMpARpDAwNYUWJcfK kUqiPJ2ZvxewVcMTnE57axNpKTLq9A2FLNAYu/IdCjFjjXNyHwK2ATvf2Zrn oy53wCAiz+p+WUl8DSJRwnMEGPYcDLk0gOHbMwe3SlM+BdYCASB+VzmFnpLs y9Pf9KE9N2QKcK/oZILL1iPS7CmmS+hutepguJNApMWMz7QLCKfcqjZjI+Fm WUdfMbr79+J8gFri97BTpLTCdVEenHGeenqQq6A2DIdBud4PRNYSLE7yPjU2 siUyDmeh8lbTOeOsZKYDqJ+iWmRCNKFwBOWo1ln/ZAHJEoSNXIVD/DdeIuvy NzNGfm2/X04j9kInsYPrRxZw0whBrQv/CiTcIeACxRbMoDNMF4a5XszjBlE5 4+KTsXKvSgn2oBrOp+PxG+LXmt+JygIWsxJhLyGXMQGsZ+W8LnQMMBFrwfNC p6k8qtcwi2WumfBH1RmJ9yvbbQ4wqzOFZwynFb6+zb9ePYeGG9kd6SdccG3q su1ndvShflPSVcq7+lU4w9mDrcGXGcmQpBXnAJX4CGVSeVECANeOPrxAzqGc ANIfA0FBReP86IPUgsZwukc7i+nx8bi4QH36xUk5KrqfUSwdRm1Ci1+XxbKg Df5sY9fH5GAs/JI8Y38XWTqM4rfZYtY4sM7VVYbNljQ3mLsI5O/H6l/39dxs EBh0vLpNx+ZR52/kO0DDN+VpMaUKCdK458gT1eoyKwzdleEl3HnvOr7yog0f klZV55PhyXw6mS4r5DTwwqTqN/6xy4VAX32N+8Kga5hmIjXQJmZxZu+PPuwI vpAmMvMJdd7VcrX/wKxVqOSy+52LVtFU6JIG+k6RSro67yQ/+fqDFvaWuI8f RB3/uyRuQCfuqPYflsEl7i6ThCDshfIxCguSzjTvA6GveUZv4QRHwEFgSLFq hkJIPrJrZq+Pv7xDxO1dOePqxUSP8FuKj0cR1i1hL15RCOZpDuTpNwBgjV3Y 9xL91a5CYT8EjayLuztSK33nYjHCSynVa/XzGkal7wfi6an9WWi660D1SPg+ KZlL2y96CFFg8G1laBD2eCEagLVQ8YjkITsPA2pRzCsTijEnKtyUAy4y2dy0 fZvypRLyUNi6Fo+Uinz1CpJ+c+gL0i5xUQ/8HVc20mvHd7QvHx6IrGWr1eUH m4Jjr34g34gRBk2LY0RZeYeGiBMPV5Cv4sm3gMv0ynwC+UiRFsUF07mZAPdA FFr9QbLpeHQEgg1/yaoZrWn2lI1/FrysISQIWLX3CgNHPklqDbaHdHoBIKIj wZ/o2mDaw7pnJz5V0p7VbvOy+ie9w+yV5eTNvCi8JQtTHUtsthVicM4M7aMP eCuFRE//gZdRHw/3jOUYI8Yn5S8kc2DSgQ8MKNXwImAHdI0JZiT+HT+FK84N 7AupsCi9nFDDUSqDpW+JgADYeJfMSYMkLkzFztal9GG2VzeCOAey0L+pUGWA TpTfVAX2+KP1dRJgEF4DdtKvJR5k6WYizkCFyFeLQmtVkz0ZzgtaTTivDp0A bUZWv9X9r9Xg1O/vujXKVtCreBMsfa4uOwVcvP60/iglqlig/RoxaQP5G4c2 SkuIYtm5sIgZsv7NWFwI8jSHQgkTVSvrSrPUUtnpp2t8kvFw8R/mH8rFgukh +yUmybQBCfmMPaIMBQWpG+VwRP4UQF7QyCAJauQjEr81L6N8xqnjOBWGajyq BXIvVNiGHJKQNZhS9LlBL2yatwtRj3Dc7UC7v+1CaHQ1dsQD/V1clmfKwUsM wJTLrE770E3YRi7UncpPlDGsnCTOimtMxmwqe5fPNGibI/MAvfU14ohBL8eY kSaGMc8VU8RmyPcCkso/mCJYiDZMIhQtI73CS3Ir7Cga7ioFC5+EYnnJJ0Sk 41i8cAK+K1BhAWegjSzR0Vi233mxiF1ltJxz3tEP0SGxqOAPl6Vyb61MVNPL no2Oi2wLOait7ZYk2hlOkeOE7d3OdFrEplBSp8pS70I/o2nBertyciTJiSj3 +4mlPyRsBQBPREnF+ZJG1vG/aL366//grYa3go2LOTjYTVYf9ZLf/0of/B/n 6kcDH52zgwx53zC/PKMqsQRToNYJ7jJ/KsmhMDBymNPxiq/yFag6kIECQUq+ iu+oxj5r121watJrZGQfXOoDZbOw9uyyNynM27xpkkoCwihxg1g7ooQBg32w a9LE0T53qi55c8Kj6TyflxgWOp1TcvSQ2oU+xx34Jx5E2G9iQw56Prl0HU6B z1GIi8ouneangKppHg1V4R6La0IaCUoZIvBRnxLTNMKeG5ADYsPzvmS0Iaf/ aMU3Yrzxqjy/Hg7GUk+gsNG6R99xr3EesSgjkOYfxrtqepTNkO9ovqKNSQhk 0O4O4jhGlCO8wYUk3rdG7DKWYQWKpvp2v89R99JHw0mrHwkxF8ZfujqztYnH 2xar/4Q8x/SMpxsTLOxHkhvtXsoMrjV8GXUfnCwSGllvuNXY8P/UG94Rr1zP uT1H3pIMOc2Y4a9SUintpgydXIt6ObEiZOy6q+CqnEmoFtzclsHVFCErkc9q +hFpjlh2BbNW9ItaBH7HaDk/idhYx9E0CUnqFhLLSehaZVmrEkT8aARGeP3X dEB56A12quXQbWFNq2n28wDZP+Bd+FGn+zNWI8BotYISKooel9t3k+mavg8k mLC+MDyuyEiaiBQCdo4DPbURpCfzSLmciMsQt7OigkOz6ANEyIYBPNl4Op31 Edez2xstk1ga6EfcgxQWb+qAQ/cLDkZgTdQU3euFSQ+aFGQLh4slxSGfhLhu gYAX9+LFrr4qhFYYTsRlH73sjM1WnAsaYhWvy7UljCtuErTkYL0q5n0zjtKZ guf+eEbKJhNlaoz3DtrvgxLKcRY3wuTdkVJ5K+1nL+hG1Ba/AplCO3YAafpu LXloMn6wwTg9Dzb+WjQ8otuR0p3PnEsPue2hHsqcicVjRnQ+JOaK2sNifdKe kKkVr0W16mHIoFJB1nMlcu1kVRgRtyaIm7kkGs5HTyTSsWjUbLcSl7JEPLbu 6Xm4JJo7De02XeSGKEaxBcqVE2cwmKWpx8ylN5bL3aSpyyvifmJ1EEXmMOwb g3NcNB+3iksGxTNxmXQ5wcYi+3VZwvvPxGdQnD/OKAodL82zOb4mDwQE5bvi /P/T3p8AyJVdhcHwGNvYagw2wQk2OPZTzXi6Sqqurqreu6dH1kgaj+wZSUga j52etvSq6nX3k6rq1dSrUqs9krGNHbYk2Cxhh59AEhK+OA7bFzYTIIkTPgIf gbDGMUuAEAcwOAGCif3fs9177nuvulszYxO+TNujqnrv7vfcc89+rEb9YkTZ kaZxftOWkdqNXAQuw3uBZYQhSEzPiMozEOP7qsoJzAGURSGTtkyt8RGbvlfA yZUmiMiw7PoWLAREr2LuHFp5s0ZppLa2NmvuLJK2nUScKPKYLJN2guyByHLF 4A+FmsjzacOm0/wE0kftI32jGANockKYnkPirrKNcsfm4FEQBBqqmpjT3Sax KjwrkCeSWT0LdDIGJEI+8fJjKEVyngGtFDSGGiaI/6wVWFVuQ9IArgdetDp7 /RHexKaOq6fWgGvG663i7JZzGSGaLhcEMUnD9k4Yt82wwnQH3bzpkITg5ReM Uwn+erWB4fJAZ0uR8q5Chprm/MoS2Y0D84gsgkxltmicUJXmLNZyIP2YQdaT jWs1yCigCX3th58573AaDSJXdCNOlTEcaws+RQcJNNb6CYgoQA4v52HDU32I AZ1bgU1l93J2i6SE02nQQ8YOtHPVYC+Ous5lQ/q/D00xgozk1mX8pfZ9evAs i892KWQxcfdqfOleH0K2QNShkKmtgWibcWqxTeDF6CrT/WEXolHFvIcZavki BeKmSEWWqKMQWRjRF0xpQNPVHXMoB9chB/Ge0KPtK3sSb4suJmRtm23QTLwX w5VNt6lpcdWlEh1QzJRs1KHbGv+xHxGwYLmS5EHKlLbGuqvWgDzi38UWubhu CsNaB2bx16UxrGp8rIucp4qr1q6Y+EfGH6v7YSI5p7auPbn4mg7NqqQ4UzSp Z+UhVswqUMLQ6hG1DbXspjuWsKLaDpqFAn6BWuYyc0LnTDlnu110+DFZmG8l lVNCEhDhlaanuJ2MkjOZCSrERaN28TvNed9OkGNJRGZTtREeIfTHuI+CXHhH Y7MtOC29KY9aeVKcmt2kMhZByphOTEKVrJqfdJFlbFSPOFkKlRP9gmOGDsa3 ByHcRsYTQSEKNCXdRYu5vYhCd2B+O0xetubWBRCuBBOgiWU356lhrkPjn6rt 0HF4nkJFtQMDvYNmpoq25bajU4iK1HcjPoFLp4CJ2u8Q0U11uG21xp9FdNw+ xgGett4fjOJTufUC+WmcPmgPIJVC8UreltBTSLuOinCN6LWppXWPnTcjvbnn dVW1o3OUnr2VrbEpid+4EUxezHNW+NKzEbHOVAUTzW4am8uzEUvBS173zGS1 VPDkCBKx2OSdqUSXY6GgFt3VhETIDcTSDkD9sQQoUwQe5tbbqsWxHlgy5+rB Q3otxH6mAIfJ0/mL0NSsZ4B96kg2pREQ89XCmx6aXVUQCs8QHlYLoWSKnSSx XzELknI6UuFJRXNkBnPSHQdgW8SQh0O0HSuBD2D2Js25p8lVSk44WjDkVUAY VTGetG0tFSx0Ba56N2LOKifY5MgsPPbszQ9wLhbsypCoALQzPLCtxfKLNUuM oXYRLZ3WMlytvMbPGnJ+EGXVXA6jXnd3B1h8J2azZkFTOTbDXqLUkGItDnnT KRcsXzByZB8Dr/UDrb8OaKE27qc78RZ4G9slFxRUxUtA0DLAVdZ+CtIjqDJ6 I6U51MAOHClHXIr36EjRLTBxYGrvCusRSZafje8Kaq4uJEhUXl544mSAW8ry zhxgEsRRInV2yuUmQKdEwYhAq1RA81M5cM6FQQv2WoUeIOrCFpoUWB+7KXd7 aEiXRkxRGuiUJrXtI2ELMo3KN5UTSjdu/RxtHfbPBX1NokhOMFMdoQvA1k2k SZOtLf/iMVjUPOONNevm+HZ2eNXR3FVmeK/o0YJQaaJhc6XivvZwgBWwwr9s z9lyG35LLPbzaK4DWvCcH7Um0AvOC40QeTCDpO+stb2ZRZXmzP1oYuX0h1xa xa7TDzkejVtcfoGNuNsZTfRwE6EMWD2gqs9enDBb/Tsvp5qEb6U9i3H5gXKZ y3rHuWFyFW62E7GlGblVq2JyYNUdad6ueRb7niP3VtiJIN137ixDVGQ5z96N MuX0X2F/T/QRTrsPScBdaFS28AX/oSk/V7RYkeZNLMHoFmgeGwkWGANDI+4A oywSDbEu4ANGt6eNYgeFQCMCIksqaGYb2MjBppIgl6JZrpHjA9fMM9cTKzrX U5T/rE+wdiJDLJFhAOvpssZB0zmE6nogOUGiaZycLBbjZQ3IZB7D3rSTwR5a KUC/aQKCLqfuYgRGYseWYfOSdGS5aralVbJoArkJ4hkgX3hGKoTlGV8YlmIC pi1Mego9M3+XBnGvF3ViM2oWj1I8KqwMdiCeyQ8No0StlBQTQjpRVPx6pjHO vlQvX40aAOmUe6jdl233NC2FTsgJBH2Z2eMXqB+9NezSjG/5wOpWqn5hBrqs rIMssTCk5BdQLZ/BpoAJyeALGJ25mhmVDhWzWh34oVU5mae0gLYrxCvKIZgu npG4iNrIGtyb1FtXA8dm3U9n5m/jmWoHEdwvCvfiqjD9gF3S8ms/ZMGJUAJs ww1er6IJv0WqGv3QdmV1DJjGOpKrQeJGO3qVu3furvD7eFByLC8HE0J2SGnj 6De9Q+u5rA2b4H97X7M+U6uwoIZTO7E5nWP5mR0XxbsARbaerwdX13ZGh4bD tM0degBglDUcS0QSmYW2atp/XNqS6LZSL9gtwJWseZzAzMyav1JUyI2M4jas E9MmfpZHbHRZSzFk6ynqAUoqW+Uj2aIK73jHBo+YQJTTU0kDGISmLfrrqpbJ 2QWw+Tsow+RNm22SmmXvZJTPoQnHboi5TSgUoOhVLxNEsqJKXL3aLPiMh85k 3oomquTUww1geZkKRKsDPRZ3blqLUMyKE3dutFIciPWsYLCYmKF11qI2RoyE qbOo0fPILMYNLhi0oAXBL4fDB7QxB51cKiD7TJDtYQfKh3fE6ekLyhAGkYL7 4RDLMlOPJ+jTEzXztp0h6x933251w+0ADT3iG0AiiCE6fLr70Fmz2xvcQRwm xlQEaW4HBfFaQMgGetCoyj1StHCRTdRs8LA4hwPpySk3NGGBHvw0BTHB+iRg j4PRxJMH4ghNm9wZKvDXwPkQMU4AHoPGc+Bi1A9WIeB6YHMe3vefCNTYeRe+ zjE62YldRnbFcMA+rCoiRYHomkMOEyKFsjtKlf07qmLUNjlgKJoNpOmDmmnt K/uZ3LP9hCAZrkBC7LHgw904OYFIK0kMydMvEW2J45mYNFVRmJbPYZdXMssi MDuA15EoftrXNuWUmJTOhSMgK+vVbGy5tGsW93Sy21+VAYh/T5VfPjpwr2gn 7KvLuFXuNW8dFgAO9axpVbFv3PJtfnt+PPJfU+vyWhrXJaSD236gO1ozZW72 DOy4vznOou7g7fDQPkhhDQz6vt056QPKp6G8589cfJGgyqnA8dpTRRnUkEWZ FjvgC4tT2W94SmKxkjoVi2Buk3DL8HUqyx5qGNEhtYzGLnjcKfVSNAT7CCwa dityvR8lFUPFQ8AYU4aHYG/8DDadmbG4VJucH/UmxpV1PAKwHUb8UuTC7sVA qMlSKOLEjchbdVF70+u1Ka9HQ+NBl37b1sN/PWjMrU1lyudAoDiWgedTpd5a tbILiJDtn9nGTC+6CcBluVokVKRQGmZ7V4PFeh1PZGpOa7Nel0RHJAqkE6GD TczX69gkhZGA8B9wNSQciac73jb3XWsvOAUmzsFDUXcLaCNybh5EQ8yNbfh7 qC2pm3ejVi0ctncM0YBJm83v2Wa9Ua/PNefrjfml+aVZKGpKtkyjnTTeNmCI OrNZvMlqg52BqVBfma0vzV57AmY6Yy6mcG9WydbwQQ4SqoowGMXagnXrppN8 KxkrFtoUlsQQdPBhtqmQmp3ycI3igz3cZg5W1RMKCLIA97/1oCCQA1XBAeDp UbRb3jyP6yO7bluQ5kWAQFc2bmuW2CZSe4BjmZgoGgtwHjOyJtyvNJXg4qyI wEc1TFTXObUTdzvlyfVJKYvSJVQSQ+c1Sb6CmeJVWsKcqd996/PW2E8BOgfM xwDt0oZkIGtFplPIRm5TiUCB80CPUOcuHmQp168fFBtCw0MocXK14HlHHUyJ hTkPIG48HzZr7ESlXPfm+SWuyHJwaefAzk/2eTe7SQqyvVEqjlMoIG5F5lhR Vp9h2IkTXt3D7P2a7ISYKZcwF4q/O9goPLbhhuHBG7iGV3+dWzCgiZcfhJ4J gAgDbgzEwKPR8CH0ItcK5cGw5l5Mkq5DiacQJ5XbgtqHjtBZRSwAl+vJgk4L SJJihpe7di3JmFTU0EKqe/KkJ8V6tSm9XJ6QPvnk+j66QlOQfbFhuWchTKBy teVcZlWbyAzoDfveT2vW97OYuZ/L/s+mcz3NZi97UEWIQ6E3UjJqPJI1nkEP tRFabCoxoU/aISIMWuKi5Pct4AB9Fa6mHpxr08WK7kDInB56rXPSEMggMsRc pi53FxD/w7BlkD6AYjikbI4g3wEazfBsPDp/JSVAoNKNvvGRh08nbYmT4YWZ cAcIz45zT6iNkodhTJy/c9NlFtIHDi0ManA0vXQw5gKV42ouSuWi72vT9kkY lgkI4LlMFpyIXBT1fDasjKdFenAuoHzSJBvJuDjyQGEmIHL4VbDlI53jHA7Q VbfeJQVBOXMpjIKJ6Yu8sfqu23qUIoZX9I8hGxAasss6xb4k/Rl0E8Fz7c6Y hBTGAIa7cN5EbwwG830Hq17+TRrZCbWYkoYT8acFSjI3gOPKWUYnJ0XIOJkU XDd++i+6mKwIGpATJQBivze55ZwwhZMqCVpUEf6LdrsEoy5lkmO5ZDRODu8a I3cXT/qegw7t17LvbZNfGhi/zdsQOxNdD1tRsk1IngIBMCBKI2QUeejyIw8H aEiUGtY9gowgkH/A4CxuQEh7MDhCk8ra7k442t1G+r5nSJt4EG5Hs2B9H96s Qam7HRDNNKEV+H0Oe5cUd7JhEy2a5KC4qvvElTiCMbYM8QDhnNh7zVbcQHZa B2TEZtzSqjOczQxuZTYP2ay7LDpSB2XKYsaioIZF6MaK0x3QOnk6L/tFSTSf 7Y7uQkwql1C1CURFLhS5UkRNxGGquDvZ8HAtFy8R9m3C1ZEm42Hbbu7s47vH Z7dBRLaPUBDSuyJ/70i+gnRaFpWtTWmqsVB0pK9xvDJzRBHWJfM4ua05hVr+ wnQgedQ1JmfsBjAjIaYhwjxMkPdpkA04gXvD8TRTO06XOI5WAC9yIYX1DP0h kuHcPu/RU2kk11Cwzs0XL4uoWynuvd8Sxbgn+cOBXe4wre6BD6N/kbkx+T/c MlwI+V1zmEnEy7eI/bkF5KahrMJbBjpHSb9yz2wMMSfb3bh9XVcKb0EpeD2J QwCi7qlzCGSOcsccwoWCTg/NIYjjnimxocfxYHxTnwmVqewAfiG7BJ8cfkF5 D30q+YU7JpX51JrVpCXksYHJOIeFy/pAT1j8tQKq20a7zWWSOxSF/BdAz9oQ oRQ013eKnhhN/pNHuEpOH7WAbOvLK8ukY9hCScvkJPXOkmBC1CnPTRQBXBrF gFLkJIqW+PbMRlJc/KNplSR6/A6ZBbTAvNxcigZZxWAHYDZK6h0gKZ1vNBqL zbm5OScp3eqO446ZPBi2YdFWN9kGIenybL0xW1+Z5czoM2wROGPgeUYumxkz I9LAUmTUGZDezlwLb4RpexgPRrMyLojrTQdYnVMz7WEcmZrgCFtfapIjLAo1 udl9uIySlLHR0ZlFl6pZvyyM434WBFFSpBo06hkHKmiCa9kLhFlVi6IoyacN 1O0ujQkFhVPA5zvDaAt/ZodX98bBD2caHsUocGqQhSSlT4aQkh6I2wfNV8Cp pXY3TFNMVA9fzpGDvaI2i0V+QGjgDSWRQXyBo400CsHOwCwFA7cHLUi3R+H6 hxGQ7yNrOSr1oQanRSApJWfDEposwpiPELTOF2ZiPEDVBh0CcBmBApBseQCP KURKMIQQzKV+MjPuQ2atGaAZI9QgpCWUfVAQlo4LtdOG7IE2Daw5XZBxJu6A no2C+dNqgFS1b+itKZ891IJVrSNS4cid3BW2aj8MYiO9BIUTMFuZbG2VJOQL +mFgZHK5OF2c8jWL6rmEwZz0rSCY+ZHcm5q36Rb2jihmHXFpQT6AT9WEMmPP DNjhgcmzPtS0fW5ZeyexecLUkZKgczh2JUMmds6bg4Q/euHNh5F4w1/tqNu9 BJpryGXIvy9w3GWsmuya1316l3Ttd7Nsj4QD/Ipemw9gijcu1geByplOPAKw Lk1tZnPYZWkLJAizQrp1dou0pDNZqhnUjWQLxCwOB+A76zh4cyzMMNgZF9l7 OPZTd8DLGzZmGFJuJ3PwiacH89MBXi3S54zr02UVxMQXg5P9zikuVc4RmKPk etS3ooAJEgDnHSRXL9aqXUviPqeTI02rjkM+OgX4VEF6NkWgE4aINGHbl+wQ ZqbuQf1ze5LWodPBvibl3EMzFygAkUToOmyPh/jPG4hSM2/f8hbDZVQpVAE9 teIbx20WuDlkYuXsw08E1zIyVrENqskEuDXPKsyMya0lZ46q2EwUGYJwcgpA K5QT9zdaj0NuvC/UIfMw5oiy8hxZVGJyPRhYkwJZDsamAwkImo4XAK5tFzNG BhkyBhp18bECCfikR417jBbaOHPDy2VG7pqqIb1zfktGQ1W52+A+8M6wdXA+ x9d1Ge5aRIu3nYM+YLwAsvpsY5DfTry1FSGahuQ7KLcY9ymvqqEPzBhg7zgp rwNM0OoWLY8v/LTrhQairnJGIJoWHbmqV8ETlCo873PPPsf9l/s8qjk87SN5 NCegKBgZUep29Uulv2wHWxiXyxiV0ZIuQEpisGoU1hIBC2bX+JrivAblNILU woQBK//7ogg+NU4afMyAxDFDYkM6jjbnUXatHYhG7jfsShaPrGO1YTTohmDJ latWtZft/7kIhkwZixFMlZxO32AVP0jiOBMiOUI5zx5bzbdIFY8X78T559fW PMFH2b/LwWSVXuSRSvaQPz1sFk/CZmrBmFnPo7Q4j9L0WtqE4fSAOPIcvjuc e4Fls7FXw0psVd2zVJnQF6+8xTQUxtQcsfhG3BmbUWIjpFijU+/OOPRihSO+ Sbbr+g5Qpo8zqL7gjQI9lz2ep8C8KYgwHoattx3fgAgdxC+kEST9AT64G7Nf IsfPMVOo7YQp75Gr7vkaQSEP0FQ5OWZetBiq4oC2oLwStLh1390xR0Qt+ZRr OaNMc4JPtv7OnDF7v6iFzMLimkLjauJqZSk8rntpyoqcz4VcTZUn5ZUrtvCV K6VqfuIuRhAFU7PBhncw/6KbOnh3xhB5aRrTH6ZgunkVdYFXq9LECKQxbAsM banlwybKMQdsw4BqGMkEQ5e1oEIa3jBNxqNKTZo7b8M0tSgDAJjnAPcI0X6x CXPF3ogpxRVVhx7C/h6mj6vYcUH2R9uA+O7rXJMxJhxH3wRoFmMUk7+TSpWq cbxyBsm+cuifYc+tuZdYQ3mamj+Ivc1fC11i/Y0UbpFq+G4Xyrtq6ogcJc8V nOM1ZulUwlY2kIsjQjXMMlUiTVhO4HDkFfn+7pcjcRLVk+O0LfXj6A99aHy6 Q3C2xNrK3rziwHc7oy/k1+vB7OPD2e1J2j6zp/sxAZwgCZVc7tbDNfbWqq6z FU8kqO0S2tlltEGme1YGkXoBFtlaXh0pLiSC6awsSFOWnlLoSE4XQ48nKmRK uCqlvKKIbtnMRom2SEm+M4YycrTZhLOXpCNU/LE4yBxkUBKrQP1MApHFUJ7O 0V070pQBwPEqGmFy19gPpxy1+d5AKEqhLQBvUuCOKb8XZbiEgfeLNGSOcrJw o8MP5CiotQMIFEc+sfmRJkQopbOXIthX4qnhcfIVOygpSBZNhZRXhl4DDY9j J9VlrZpQHcKdDJbDamUpt20KQjPJacsrjfFVaYPtYLHZjBEgdUU21/7F7sho TpHgh17BmseLq+ajTCvihXrUYczMk+oE5OHARW4ND2Cc7R9DpudWORErkMxX sMKE9/sjBKIWQP9O40vdca7iZWtvWjLgE/WP3QxKH4Za83JW7YxXWyZPeJWW ySGR9UJdMw49a/ymbsSJxgoye1KgkarpMEpeZ8Q3USMpQ16b8vczYwCDkLGq KD1fH1fPKI8xiuWA4leB5/hoB3RuQXSzHbHRf/nuxvzi8mI1MJ/LC8sVRUPu I8m3pfYV2x8kmYe//BUuDlNmvO4Wd1vknD8OWHm18MAL0zIAiqGOxeuB7wsd r9VFfGCmXSl4pHbfWp4ozgwLzkCalKriLaEPKH+CNtKGcD1ypBfetO+oy+OY xVMCwOowyzouhCd0BQLMNMSlfIYmzjS/mlEVk0PxAOFivL1jA6Fa/aONTHjk iOcWCB0qZ0C7nuQoAlWcR2ARpK74MHr2zPLMirVsGA866IQqgyCnEdN9DxTF Bp2U724uLDQqiiEsC5jbSgY7xLgtotE3tAdTzs4+yEVJQlgY7UAeeDCaF40v cDN9So3FD0R9zE0d5X5tASFxgMiRl0pbaMsJpQVtODvgXIUqOiJhl0QV+dI3 yCeFG0axj9rKwUgpzY84YFSMP+8Y37FrqtXHMFmoWR+QjoHSPIRLClsFaKI1 FhkfBavqa1lXgQGxE8yRc1J3FM+QEtyasEg/erjiMXmjUDg2le2Lo7SSifEh zLY5Rp15fwnIbsYRh0AQ9mDbO/p65OeLqKoTWHSchROKZ2YOe4iKssIYiqYz wzJOSeti44d5B4IDrNoYeX0eb+Zm54kSUS4gwuuWMsfE/KTdb7uEgQ5U7ESx BcloMuP2cdKDYCQi9iEppYPE9A9oZoHuABDCBMQIYCiOIipMmCZ0tUg7Ykmi ysOzQ84jdjN0tpjxY/9quJrKGl9fBHv+lG5J9uYzi0TGKWB4CFaz2cgE5ANQ VT6EwSQFvE9toc79yanDAPYh8pj4xnXka6jzPmTgQy5WQhauO2KgveVZExfr rB+j52SdnRsAXM5IOiPqLdKLe7Se0L3gt7ma8Zi47TPuqLpQHlbklOncAyi+ jY2Jry2DH0mGgx2x8sUncR8/buG/yXjU6o6HFcw5nyEi5ecNTFeAYWiH8fa2 HwGU34KAR1SCMBpiJIepXAHoM8vawlFvUA1a45Y5XZfR9TfpkwswW5JLMhwS J0D7F0KMIMN5mSDEGrtecgAaVhTshOn53b4ENqaBkZdJAK5X+IRIoFV+DZVR 7gxEXjqpCVtCt2Mfovs+uH3WSqgzYFEzaYVGmOyCZSLZ0fv2v52EWrZmv0zQ kuWvZ+ubFzehzW/+8fIEY180bjPbPwubD4kmBjuIuhhAZg1YrLHBGotHwU1w Kx5KyrBgCOmszdNdGZMCN7YP5IBBGoxqDEGRii5ZZIcMVZUSruap3ZhdOycb 0Am41TWOnA2uutF2dHNA7sOY5uUG6tJgRMCVIaCVK7ntx371fq4p8HIlaxS0 lt7qx8mQnwJ+IbCWVt1sVsUWAex/E8xXP1LW4Kcg+fMQPYxAJk00HS/iGZwG BaKtBuf50yCDa+hB3dfztMICerZO7zaUs4lZhcQg6hP2nJG8th/tev2Jh744 hVJzOiIumAHd4IQoUyzYwB0JWvGoF6bXV4N7DbMAWKsfYigkTnadrpkXTXzB mK3MpsJwNVdk8OZikAbXffRywtReDebWbEm7G/6GscGTbCmVHerC2eonZCku Rttnbg5M5fKbbz3+eK0C+5Vv2bwxCLZ2zHzeqpRIlFuGH/fgL1pYNCvkXUZ/ pPGABPe4eGaj0dM1HgFZ0Ioo5CTYFLoRS0h9LwIh3WB8wMLhtiMevGeEgDQO ONUFWhiiM5nLg7zcMXAYIB6J3mzHx3HpxWxW0pWbtkXjpYKOOcEODGODZ7hJ 65CnQ+n6cMUsHJ3E7EJ8IQh+hJw4w3AXskGDISs5CpvFAPwoRdd9vMOPOYoZ SomevO3WzoMpir4MxQVdFTySQEd05XEEQt8FrRDtnhYXZ54r2C2G2xRZcwDX HBz3zg0wTMBcQcFjc6dk3jAEw0+urBA/CeFG8BZFMErstVIlpZV5QpEu1oJd xIEUyWG7m7TM+iS7/Wh4Wq5RuJ5Nw0vN+crENTkqK9BPuFsv0PRj2FfOQ8Td 84HNcgehR6JtiEbPwUFsfE3qOX+VqFaO6wCHQBs684uMNS2SxiIIMO/xn1xR 246lNCS4uLOboFscmpg6oqS3ZLPR6fA6ky4RQgvq3QjKUW27VsULdNAFf1GD NQFldyLwlTG31+nzj1Ts5LErzENPnJy3TZryqUwcuGmixibmb4gjzOADj2jK tE3wjAet6eEp9ugZOgQtJu0MraaXKaWgV9p0svyRoTg1GQCJIPELDtgvUbaY soMURZ6tG1YSvMFIjqg2n/SJAkbg3eCDEG8M3yU8B3hofQHLmZiISJGW6ICx DvJJQ3dvaGpxUwQlRVWpZSEVSK1EnVllFv4UhIG1CF/40HTOuxm9QTMlYZbS 1N6Qn5u5HiFqoeoMfoN1/2B02vQnhlQe2LgbZf9RMt3pVckiO2kSNNjmk8PI lHOq3KnMXmvi5yxorVtJZy/gVjilj7hMhKRoBGI59sjPPLoSoDtt0xlQewrk WBxnMZvEdBKBV/a5RfruxEHorUL8zyCj1z+DGoXYM0iZqSKDCYJeNNpJOnLs +OrGYFEoOwNVMLnbpe5cWvMCy0n464WnmM57FQWH06Ld49vA4P8YpB1AdpiL YLGxVK+4bXfgV5RWAH3M+JxUDnUneELNGbljwd+l/+D584xqJK8Txn2FoDzm ldk6Wh5qxTFX+kwosRIU8K3aXMFg3bp5aPHPbMCAooaG8eG33PozOUQONZC3 qwtOEXt8S4HBB9l/TGkZVpb/UVGlZWg0MDkwkysq4u/wkzWvDzbX0wdc7C1g SUzfe6j/wijtnaQP4e9usHliGvfGXWK7nNmiISyn2CGuQ/F34Sa+ijd72VyC t4B6q1xl0mbqiDSSjyhOFBbzF9YCwQtxhPKKQtal4oQI+I2VahgvA5snKE8v cfedVeQ8ZG2IDi3aCAPUVQ7qYW3kzUp62jjPpKJQekIzVPGrDx33KDMY11BV J2iwMYm5ICPIfYeAq5sz4iiw0vCD/uwzINpBF0dWySV9iaPho1AggVAiwohA BFWgUIG4KWl7mEBAaHBHDDqtLn0xbBk4JCXALxmqKcBvhjDGTzTfwm+Q05e/ mRbxC9wK/MwwZaYgNdU2N+K2KBCCdNzqmXN9PdrD1s0n2kLDF9MJuindHBnC bAzmOyJBCDgwaGG8hillcEHQDfQMsuz7B/OkRZXUNdbtPu9OX1dB/53LPgGt asRFZrW7Z+NXZEN8+lZCO7CaGpi2+ufNE2j3/HhUANJuvaWsWS238mWuaIgw eesLQkVKK6ABMog+/0B9O3M8U74DKFC0W8lNCHQ3P8UULvwWJR7K6zOoSTAT yl4RNWCGMHMZz1hNcmu8/Za42w3NFOgTNMkQ8vWKeVNrb8cn4s764vLS0vKS accb0qmdYWLW2Ixo2TQ4v1INLoVb5hYGfWMNVOMrtcaUiOlyowJRXGR1jXBY 7g3w5NDrKvmRxobpi5ltvBEnXUkBzB7Ru7u7td05HPPli7OG9ph52FTvzszN IO5MZ++m1mawB/w+Q/+if95BK5PW2jDHeNzDLgaz8nM2TtNxlM4CAxR3YYnm 51eWF5Yynqeyx1rJwEF8ac6rQUm2voqzlwcJxCXywuVCylMwXb8pNIhLbxfC Pb6NRk8DA6hw14tog2kwy3IRt5OafQOxCSTltEhqVjpmBCpNrGdF5UERGpfL rwxDrArrgaRf1cev5r1rSCW7KBZ2wIRFEQOamLEOX6H1imaKjO7zHCcaqxDl QOEdIokJj6yQhPswTfAKaxuAo7aKJU1MQTBbRhh7GBVkgA1oh3jZqvmEKEcm dlil+EbUC6WcRtOEiuhXAbtF4bCDIZ8/+dMHs5ZDLAHZFB9+FdwCUM2CFc+k E528YG5EWd5sTQKfogqpm7Qldw8HTZUna6Rj6if9tqLEJCozqp8w7Cxy3LOP n5hlDA4szzBJ0xlxqL/Z62LEArj3xJUXAhhARJ3spRfYMEemltXc4RsXnxx/ FqR68V27OYmWNvTwglmgnYeYICUcVOFBg78ukSUmMmRx/0bYjTscpBOIrD3s CuYE8wZqlNfNYNcL0AREha7UMq3JlV4CGmLW1Ga3XIOSQG5nDjzPgRrWsl8X IxremVUwHyCdOMNZrh7Yuxxuk7lGCXsdRsNhAlZ/hdGk8aUpepZnZnZhFa2X rSjgtvUGxj24zWFIzdPWMMRLACyLNx7fvGcWAg2duvjwg2RrfOLx/uw2PCJK ytxcILpJRTVJTzlM0a24F25Ht9CA5taWQboSt4jrHhzuyJBl21G/guGMrGtz axx3O2Ybwl6K2QnxLCSta3DQwk4MZcAkDyR6FtIoQM1UoZYaBHkVdaNcMqwi hfYjG5R4FPVqanHx8sL+PIrwhqcJV0OB/ZRlZUEojTojRCArUnROcR0H6OyQ GvY5HJJ8wMzLTfuGYA2LNKS1s1AZ7H2T/gxVD8rULJjUoManAkm3Ia4EMuZ9 gyuHcZuMl2ossnMrTdiIB348KG0APDlz1Jwm6YYzIwziYBXtlKHepjVU40+9 aYygO2x77VtJTnnGrEf1CjuZBoxHttQbUtH+0ju7wSRkRqKZ5bu8owUQZ5cA i9O8oIqQ+kXAKAoEvVfeeHifZDzeTuNwiIwmqthBqRhLmX1Ai7VIcuOhpgCs 15ItqGJO0ywb1cR9cEgMCLmzitHh7bDnIe3Qm4w7VDw0M1LKFlClMXt1TZ9s uXF+6Nlks7j07JYzoQltvSog5eQ6KtFAizVOCUa1gczUEWVsuY/tudfvCSYW vOdlZp6yz+lkGdbZMmNAhdGRefTi2VNJb2AoSNCsmlkSdK8j0wmyioJS+9hK OxqQ1sTuKfoSkU9TDGmkDc3di8hqkBSME3e/VoztQpKOmy81Cinvy/ougG5D 8gaG2vzPgzkgqL3esvgxzNoXMTiTDTelCnE20U7MkTsd4PylTxJjLBhAKel2 SmaF9oIy+nSZL43aXK2JGK7bQem7aaETo/NW1SWRl0YQ1AGq2mNDuhimac+h AT7mqLafjAbMjmxI0X3OvBAqF23kLM4gTpGHaFU5C7f4tYpK+t6ShLAvZN6l dpQjijPRnGHc1l+M6xBMVFwyQO/FpBZJBgAuArlUkCgL7+PUJbQQSgxLAicl tE+hhMSAnjqdHBxZ0RXiMC+WnHU6c815wYVtrRMFVpL2pbgEM9BNQWZyTg5a 5DAr+g3xTrD6KYgSZo4M2IKIjS3cM2lC53Mrjrodg3035OVmsJsMKaKeXkm8 MNwhtH4o+ZZZGaHpJzHS0a4RLL/PkGjanKfi3Nooqzib4oHbwxB/hKyr82tV 1JL5AAAUkJYqZv0PfO8a5dxT5P2Sid+kPXv29WHxIX6CE0vOheVJvLLZdk+F gUTcrDyugAg2oPf48HH0mr3NTJenAHwGmjQNomLSk5kRbd6sA7n86madSPCd EDOnzd5dO0ZketgfxaeAJYSn5Y0T925WrqxvvPnezWP4eicKO5SXx5DctWMn KqsbweOjzWPljTfDCDaPGfq8t83KgruXFhfmqsHdy43mAn4sNFeRk+zCyR4l 7aSLgd7bjLXw1QV5I/FIW4mh6sPBAP6bAedVYAhqx2cQgYGVI/IFwCLc2o07 ZtqVVZpKPzlFMaOkqdeeuXzroTMnT1fo/UD39Pjs47OzOO5jgc13bs5ZcCxo VCB42x6a2BsqYmvcBQRkyJ9h0hlDhGdKNAWMETEyFA7jWnhz9lqa9Ae1aynn PguimyEkLKxgu01sN42wYVBuRZ1VfGH+ZoIHzjx4/uIZc1tflyxDIdwN/RTY VFfs5IOXz1ykW8i/BcwoasirIVXkXIFTwIIgBjjNL9m+yjQ4V0EqJCZ9oswH X81X8BmyoaCGS/d6LbNypWMlNE9r4cp0sOhCxUzTXIc4CEzASEl/SHMpM7DN I3F2+aEz51B0HvfHIGbbRaMVaB2clzHYBbQ9qxPUgzTrNu/YZWk2FdG53bpJ M2oefkZmXYirvNMZbSeTpjFyA7bTkLjHbOgJ6Y67yTYGEDf9G0ILJCzluxv1 +spyZS3ooaHfYBCBpRhGnoN+oxvmgLoALXCuzOyEwS4dmy3VzDqbWZdxXBXp ud/eAe+LkECN5TC+0BNEUrFpjz65xj7JT0K6WXVxDAZp6ojwCH+v2XxJAUR5 ozhpIJlwxoA1OE32WOJE1Qu7+47BN0TB5cSd4/NDByHlwEZic9oX2bszXtwb MsE36Ao6ZEV6yltqqSxfMuU3QveGkL/a+bKgw6KsxFh9vaA0XhgFjcAel6yZ GYo0uZCOZa/qpoXN+66RB4fTmBT8hKevaLsHQWEMAgp7XDgJZH4QUMPZFdny brxFMTpIb48GizF4RJtzk47YE9smBIbKqM4kBv+48pQu6KaWUla2Bk2ZFxhJ HwtKG258mxR8p+A5rpe5m8d9Mhvm5XEO3y4oBGV7KhDmPtU+ySJMOvRlvRLv UY5h3MfApgBPLqx6wtw6IV84EQ6JuYPHVQ88euK2hJnVAUGE3fPy4NoTb3zo Iu8opdjCNimwKLtSRnAt2pZRyOqONabXcxgWFzg7QgVQTtvtUkWBNyX3mllm cRXyeNV91l7Tjleqbg3PDx8MAc/taXpXKqtVM13m65QPXj5nE5ZBOV7bfhwy hIujudUFVqBgOXRDm+4EiuOYPaUO3otqillZdlsKymQCWviu6blRZ0j6o+VA Baid3ItzqbZ8tIMKwKr81A44N1/CLIgr9LLBfYuZaG1NvIHl5J10xs3ImhPN Z643686KQWgMVzgyDGkalLa64ahkvUDLfbI2bYGJXDTgRqJOhdTc4OF198ry 8pK6I03bZ1gKICrGdNh2wjkUvEFjcOSgt/PWuVDdvpfI/T2t6RJsVS1ZOZEI 67vWOR7SsL2BrzaLw6uXA9WklDwhlnCrgMthpiiKwm/raLEJ/5PS66oTK0eR PN+RmEll3J3ghFftklA5f+/pHe3cMTbdSDEetBlphCRCSAssN9DqlCEkZyBm WoeIUXKbscii3Is6cThCu7vRLoQ754C3MyMhKaObjAWlUoXalDAFSM5CFHUY RYd8BmhAU0BzevtOQ74oAzZ7wXijqmbhMDD4lpAdDwZ9Oy0kBWXVPq0oDB41 wAikoaQf8ELTG+qsrIlUCw1zwjHYS2s6GnbaWwmmFpiJmbIEQub0IWI7Jve6 Q0XKX4diUY2Kwy1glsa01ot71jYd1wf4alm2h5AZNseY+cyZy+Rh5gvsKGCY jS7VicKu1RuGwfU+MDt6hlN2YDQUOkEyd7u+WlMkD631JdgHZ56xFKat7cUL MDRJaQjdtgxBf31NUwl6RmDvF0Vs6o52M6GFHevKnYPZKZ8I492K+xmw41iG pwtpPjJDywh5L5uLlAOlxKAUtOVzS5jtSWmP1ZDMhiMAQ4OYt5ed2EpWC6oK b9olzQ7bmXb6q8mdeudHNaKfqka0cf559vUCxQZWIEvL3Aj832BQpVt3GvCz uJFbyRiyd6j9Is96kLJqKl0ijYHDj+ZuTWk4ti6/wySURAvgD07dDf4LuB5y 1+uTU8UgnGmTT6MLTsS7v5EpuGk1Y8cMhId01jjXYEoR/ljqjgidKGCIVsD0 l8a2wcluCsdjlIqgHt+88Y1vZJGuWBQRrSYBSPN4+hQBIOJnacVi6ji9NKZU qfbKhiE30bt2SI5a5jf72YIZPWNohmkresA9TobXBSm1kwEqgxzOFo80SFsH 0RXAnTLpxFugYaZs63atJuN65qMqjPNPkYumGk8vHNAQbCKkDlzdaR5pNCwE 0NmGRpDCUEfWonJ1iOF7QUx4/6RjY5sKi/NyaizkLhKaC4doMuuCzC3Ja0ZA zbmTpOLK2sD+lhaqyfY+iACyYUtZUMdd39i3JGWpordrClecRCcQOb8PkhTF 9Gtu0RtxxyXIPApAgiSqBS1weKupWtbklzH9uve6rKDU7bwKMIodrMuQ4fEB i2sj1eolozjF0TCaTsmkHLQi5GsF05LSTsRARgxAXrhLU/pVlAJiXzcgGKxV 1cgW25nj+pnZFPVCEiO0gU8pIxm3muVasIWjPARIXSG/szMm5Wl0HW3rMVOO BVkaNQDteqDhGNuSG8sBibkCdKnSMf+9k0agC06f74QqMlim90EYD5005Sj2 a6Un7jQ2A4tBR8r93zVNhZLxaDA2aFItzxHrZgclPBNqlrtYNwdCBOtFy2X7 wVVgka6MBxEYOeREbLUllQ5aR+yV7nwVDKdgQV1BGbUl1m54w2Tg6kQAVAZv xDfCLsp6XaO2qGuBZBxesObi0dM6W3eYjKAJzCRSxFw7QByBSyoxIgpv8Z8G 24IOEGoLRmRPkyzImntZRIDKrlZcudv2myOi9HMbRJv+FfglrGeHivFTgUsG RYxbZuXehKvnTWNKFuzRfhewIZrFUYriEBySCZLI3afKVno+/dObymwcIlS2 J3QrpfAplHJ4dFLQXzExPGTtAhtCrknaRrvCGCB61bcRrNq3+HuVJnIigPAZ pXOJuvwJ1wH420MD4nKHX+zWrRXv3RGP2bC6UBlVSrdSidwWVt08/YQ1ytcG D9e4z7G4gp2k2xHNBsU9BEIHnOMMAwPGLDFwDPR7ldK+QrixMB3NPAIET2x2 nJSgZj3bZMJiSKKbI6ELp450TWEpu0oCy2gUbq8ysaVlJhQMbjzsrvoqEVhw ck0qvfbMZVz/OH0Y1KNmyp6alNk6W9sqNdHfiZz6yJOpirevVf25h2G612+7 n8w4Xqbuwc8xprZnb87s7u7OgK3FjBkyGcB01lBBZUjd9UcvPzizXCJ68hhM wPDOBr2vksKB9gtdThSF6J4YNmZIGm95AjZL5l7vuCe44u4nHaJVkgfiA2c7 o56yzpq34gjFmyLkzxtwxFy+q4HoydhO/KYZOdnhorM2HQLQfshj+E5Pb+JD b6l63WpgjXixEOiCM6XgERdzGeQg7jFR5cLC8yCxl9nHW+bz8dasGo55Bl9m VTfmEXwx5WxrPtWo2yxZ/uSRh0t69vL8svnpTUJevO7S+XNuvODLCUpl794y D19vSHgbFT2gXLZBGZgGUb6a9a+wki01B4MU2CPkIJglYdcMicHoulhVZkNM oUmMbORRzdBph/Gr2WaytLb5nC9jhMkkgBUMyoj4180tQfoDgHUcDF4SuO1Y sCTHhRs5A6YZMDmK1gMad1gplUbD1YcXpj4sHZl/21bQLtw2YbbGVbqJfWbM 4vXCg1rNCwiY7iTjboeSJ/oS4VWqsZeMkSwCzt58HwYoiCJbBmkJPYPjLaoA +4O+uFiTmDcgD3PdUXGvT2cTQRJnWE8l3GVoREQoeOgIu9JZP8zbzg2VWEcy 9zTgs9WNOtumE47EmlqrXDBRJVktVkNYaiUAUAoJ48RsVeLPayISYWEzKIPR EMrQwbtDCAbK9q9aAG5xu+dd42Tr0oVnCWefnhAweABsBAF8w+yEoICW2hdJ 8Ask85gIwnW+aqEWq2JPqnS2k4IGRTjuQrF7+vnV/dXvSosIl5SnwT+gqlbq MSg8ApIa8QWHtvTSG4CyikZlhGr21bxh01eJoWSdl834Zhq1hQCi/IWg05vy 9WhQNWcXfkSHXjQl1hiesxF6brvz2o7ciUW9jR3MlG4syapUyKJQVsJij0cv PowADt6sYMU1Q/QJmgbhcYKfppCtIGJspmdSzdaTaDsVXJl/Y1vhW55dlfDy oCeXzcfQjW4IfrpR2B8PArREw9UhqxA1IhKtIbUXlFtRO4GkHhRIYTyA8Oeg GCPd85gfga1LN7JImn+ag2oxfIJSdmBcOMgBu04CFc8as9hcLCOIwQJ1wKXy tVjSTRMDzkpwBHgW21cG2ih8ywCMgjg8gJkczpHf2cIs9ELjZ5Qayva6E57X r40HZSBeHCS75sztCe74qTge007Tw1P0yKlibqIfm5uUFAAa1l8ayBaaacUs H5uLY3QKsBQNXLQuCJUshnxCd6JLW9EgrOVopg8Xsg5kFJl3bGouBvg2RU52 nGKJ73lC2imfjrYMDxN1ENo7/MMtuLzmcAECTKdzBe3Cl8Hx2BzlXtRLhnsl tTeXDBSP05kOGqMACywjxb5TfHsKVhGWRv3Eg25b4fOG9ulkg5hCWxgtBET+ zMAy9/GQtc8kYjfzXJLkqPZPS3yQFqjAzes03I5ogMOTLbI/KLVBOg0WxLba g+H1KLi5gweZhNjrVt0edvYuEb9Wr1pmHG+1VHANhFfcIe8tpTw4gnGxffXa qu8J4nhXwIJol7Tmcdh8+hWPy6GkfPzl88D+q3WOCIZ/zgCJ4geuB2IEWwMz R8dqeyjTej0cKe5jg1pDSUeBPJpfNpWwJCPrOGJHk23YLFI+sL2uyoQHN2Bd STjMt1rS2273Loa7KucA7NLJbtffqLTApVb6cttyYsJ6raoYLKrfU+SdimHm sDy+SAFIFFxrGFGm0m4DMrCRNRa36ekLTgt5Y+X3yAHPYavoJPe5itk88YVb Jh4H3hJBdIRh3FH2B77CXK1bwkUfYa12NvrHHSyYUo178WsOMeD98aJCjHp4 oBryjn5bgrvxYL0CRchANgwJX7BPplvY8OPDZDBEkac/kCOM2WoUiBK72GAr ABqkllL63pPUz8PhW/ZmRHMKPsC2A3IKAncj5J6AS4yGN8weJl0IkmNTEVqB egdV1/4k9VptUBmAn40g/7hKg+cyE7HKIXbvFF4FWhOKb/D68BIx4Rgu042s 9g2pnstMEbgyQJfwhaN3dZSz5jribKdr2GlZNemHWj/SMStZNpdQQYn8FOHf 2zbaJIWE6ChqQb6DiK0XY84HMbTjOuSxROI3FjWLgi0oK66nh6Y/ZBoBbmVT OuMOELt7xJ70OauBz9SSBfjcqgsr3t4jzhZgxzIt3Cqo7kEXDVYCTJcSSxCx CjC8EcZdJmrTGnEscNvBN7SB4C+efJI8FUvoxXNEOaPI9KsFAklTYXa2pJar G4epDXJGIduBXUfLnxQjXnIwkbsbzXp9HsfHjlRicse1zfDkyYipR/1O+VwR 1zsM2yOl3OagpUpTTfakTn9JVr+YiPGQZtGwOpt2qkEbQx10kl6IBijE5sSI BjCECglWnDmBDUhDtzTaUbAihQrUpqziGNs+TU1nELVlsQ620xei1Ut4sYyR EKrBmc52FDSa8GuOC7qgCDYvC8YEQ/m8DQ0LsAL4NRqO9gDamO3uhV0QrQFf RK1BZEyJRsNOMoZb6K0u129imH2n7bBTEl8ChFCntCyagEvbYV0dpg0JCmm1 3OBwudFYpQ1x+sHnGTeFTkAM12sXg/MVD8N/QDglszeB5wqRPRjH/dc4uqPr TGe41vPVVM+mDtvF+soemftZSVFIog/U5njOHiAfEA9h4vbUDGzKwXgkCtVh dI3su1pkXuDwtWUXOTZG4YLkc9YpMS55L7HKjgPrhY4KZejHUqhT035NnPUV 0sLWJsUB4QOv3EPJv5Ueg/2C57Ket6cYKD+xIwcYvruyVbDlSXLG2lOyQYId wG0bLzjUUGN449A1A6ldMQVO5ORTOeZHnBmhDz38xyLcPwwdlRGJpCDAYGlJ mF5H/eaUCtOIdURIsOWFJILNdnaUMaZGOfnI6ZkxcJRB2o764TBO4P5aaDQw Z5MStGTCNNOO0thkbR5TsYuBmKKoBLJeNiS+btQFdSCN3vHjKLmzeYiKI9aV UOwCLl4lf9sfHQzILIlgnZTj9lKiL+aKwGJ0RdjA/jbYs3NKwSykTKpjO5DP 0nosHnX+i6zj445sm5dCzkQKkj9noDWNUq09a2MKJc5uWe3lzCUIVjklEv1Z s5zm7TlDKc08ggvM2k0QhULgq6kjyj4X3UUp0OOgC9ZfgBp7YT8ejLvse27l jIKaFXkA1SXdILX7CKR8tdoGoIDE21G2lSbRT9RKcXQwvV7KLsgMNUK9LsUm NwM25M8uQfxgjDEPgATH61EkdzJUdvSRKdjIODoznHWqFMKpys469MasDsv+ NIKyIaplcY4DhUGRkcQyV15BZglw2V8NSico4gk14u64u1cWl5urkowWOxCP 8RgiugLGHKf2ECJ4j9FC0dyj2AjE3QZdHDd8REUfBjLWrD+ns8pKkn1xjVAg 5DCcCwOsQMEuqYMG62psQOKehrXuUZty+BUqXVmnYDIYhwozfB23gll/fhdQ WJ2SnYaaHltkQvu4kujo2bJcDtDw2zszjaW5ZoUuD6KV3Y6q/vgio7iR069u 1qcBLqaPT8PyoRe7+T8r0Cl4AUY6ZhDHjpqLlNfOc3GZeNvBiMrO4t4SrV4K 2YOV+ZKRpp67IumL2r2mYavQcU4jyEuc2CuHb/ZDNVWkFSDZvbWw6EHSMXfH qzfaZJuxt7a32HD74WyymWXPCI0guFV2mKXqwY1mTLjlChmF23fcuVsK13G+ oRyBJKvMxKpeRkFOlDMiVfhSw45CnPhbQ81Re4oVV6ULaGvUonl5zhDVTOuF 0HKSbDHk5hHfAZSIQPBxFBRh6GXfU3Rq4ihggCVqluwWct5ZOG82AtkIcq85 F8qR/ctQnJ4j5fw7seg0eKqK5k/WCdvgqrXgifV6rd4oSUyr1Wxf6Co2JVGH rcsFGjCxkNomySMJUUzWzzu+dHvSJsVVVxaztWXIW8y1wbYAXGwW5H1kkoHO SOEQUh60MBiBQFgrMoOJLsFd6FCSe8jJlDIKG2vOngY6bjpaqTp6Vl3wpJVg xqCDeUuEO7CWd1nql0VF/izhEUZFgBsz6CZ9DD4ekLLD0jNaD4KtlCyxDmb7 EH/YSvUMgGqRUVZ9VMP4RXAi6DmtOg2QZFVpLRWTfvdqyxAa8IrYNQsTmEXR RYRwcrFg/SA3XKdHP4gbEUsYVDVjiPPxKJnx9v1oTkhHc5lpVNE60HYsl4Uy ZKQJOpWRGXrDySIAkDR/YpGupvEF0eZ1jlmK3jRXgtwyFt4ccnXk3X7sFzeS 4b0maZ6y3JdK9kwackVBoQ0em4ayQv1+lS5Vq9RdCE5zrrmlfNQhK7smEWmJ W3CZvquqK70KTtKixP/K5VaJX1O0D/H1GFU6kZL6ulgMcTFC0VEwSNLRjNPf qwy/U0cmryvZ/QWRyG2lVckpElGULmRmKUQWNeegMiq4VEWhi0gWBT8G5IZs SGYwRIe9q8Q7h88rSrCrnLbhkpVnKzfKapBByujSLv4VZhvkCx5v7ebTY/qD 5C5KWL6e688xKNt9YKkgAgJwA/0bLIdNDwRUBQN650lEw61DrqqhNfkgEU90 MybumyX2GlSlBwZYMAAZWpD1S/on5LQ5Wpg/oK1lSlsYOwIunu1w2AKpgm92 YCqW+5joDXjXHQMkgNSVoxWL0IW0Bx6pMnXER52ZnAqihHTatYPMZUwbsuNI git8BlbCguomoD/WLGHM9mCech/bRVFCBAabrTHxmtZfx7WwHjTrmFqOH9wX zJnfqGjB35gtsD5vm39tpJxbgJ6xe5rzmNQG54d3J/a3WMR8bsMgCTfYOQDz Fe4Vec2R3T2mhTPIrzKVH8lhHeY0R++WUiIukxaiDV6AOrO773AneOeZZnr2 YXuOHBGcAPKyif7Inrm6c5shPWmuySMHsTzrtpKvXjvUWICfOfQQcszPhK4d 0kcyUMmGZPEciDfr804JRIZ7EARMhXzxMGupn3BrpTW/l5EdC41BM+beiZrc 8khaUG2fdQ7UJHc2mHc6FSNqg2F1b0XtCpijUlp04qlFB/a1FfWwG4d+hw9k jxQuOapekIY0GyRY1GnUJLp/qNEBRd4HI2oM+Ym+EuAh18KgMXokqbrKsrsI cTSK1Mn+6pKrioYzi/dU3vkjslWSU973PFGYGtll4UW32NxJmel5hgAygbXs Gx5dOXdjO0TMkzruXRW0A7NnYFIT8A/SNMJZmJ1Mujeix+LRTgGHteGojFTR KHQpWipYg5hqGCY8sV2hpVWrtKU52np/sw+9ZmC4UFZGDNySZzGXuaWfElfg lvMEcwjsXQR8OZpAa+8nN9eqV1NO2uqkiZ9iakpTVpYjhDEffnFtQsynwQbJ cApYITnTbIoAgM/s18nXnXyjQUnoR+XO51FDTs94ChZt9bavciUZOFbEI8Uz XBNanph7BdwlcpbdhC9l4Xy7eu4d8/MVFDasKTpiOBN2U/ISOuDkujlkBxYk vV7YqcfLX5NNrm7aADERsEN+WnUQ1LAdA/ZNFTfkmZ8NqHCW1qyLuJxL4GTp MgRZkaE8QbaXPR2mfAmnDuvGOg3e6pGzAtOGu7i7du3IvRufsUi50C7+Mtuo sH4ZTOI9A+mgTNlsMLEphkDEmxOE8ZXc3gCoOQmtC3jMniawYDL+VV5TLzae ygxG7mu4ulPuel21k51Clro4BjbMB+Pp0hcvm5LAwpXoRth9FDUK3o7SGhdN C+bhpkGr9whcU6hfiG6CqD+2yenAvQ4XVWwAqRiw0uNt6w8zHoB6ttFcxOyv GQ9EtyoC1MonL+NMaJ3vxAPRPiiR1UhJ3HpuS2jq4tjUu8NwcLLb1WcSPbVc zDYo4QIF2ERlRZoCDcLcimAr/LmOT1lMqVrKSG8gro0EgobcumYAOkVjOAR/ eSiMb1z4Ymi86trNZJip1KInykCqGDYZZQuS88Wx1rZmQdJa6KtGvtwPoMR1 0gywYD70NrSRSfjGF4JYQGMkYgwew7ZDp8wLRcSr3Pb5Yp6wRoXaZsqjUiMd qsR4tijBt9NDRA0TONvv+2a/CigOt+P75NcLYqe98SNP267LWUipYiUhpArH PyGNH8cd3Aqyca6J7tABtUwpG1PLi4AtD/1ULq5yjY+RLEIm4QfSxdC4bIKU kovZ3ZLQ0D6H0a13UJhOQXV/qA0oWH+churnRPFWrKpJqPGP+9kZUHS/RIRV OB46X/pdzTBvkJQw6YCPx74ZGe1oWVlK5B0HSTdHAY6tl5YxC+TZjIg3B8Pa II3GnSSt7cQdQzx7t4SLmS6RDosq3ohTiIslxRHn7lPugB6OSlbqra00MtxB xwCdufrVs4citHKVhwYxnurGZlEvmgU1wKtMK25TRr+ikILAca1nllkE1BLh 3aVWeuMjDz80Gg1Y11UuyJx0GzvDvFE7QybhLwkHJzTSg4DurJkdi5v2SADF 7B7aUdetpVyzXjdV66vwRa5i3w5xRUwQwXqjMb9gykL2OBCBplBCYvg1ms05 kj7H4lMLZFATzV/h5Sp9B+cenAJ2oh2TsuuHeEIy6bUTdG85etSraygTA9pg Z3PKsCQUtijFJIpeMdOQtIORDdeDzAj8Zte8LbVKIH3MtWcmGfVbuhV5qVOW kmSv3yQFQTwaD2LYH4nBgfJQGYjQND44TLFMQK8EZMnKLMRRq/JWhooe3U92 EQZNemhQtB9Otafu1JhZSAJn6UE2h9/UEoN7OUeStmau+o+EaHVPkOTKluJo CpnHElIBnyqGjyOlkMKXZa1+eChJAO3GTnEEsqF/UA+9TymYKWmc1/PF8MUE QZ+4uQSgh+ZYfp7nmDc+65xithTXNuP54gZU9LagHcurynjeOHNRDINmAMNr Pxv2xy8y+k4xjhL6XKOMj+xLOUEAmnd2EW+GpFpEK73rMVrGh8G1eDsNd4PB +C1vAbOz3YgM8fbMMkCKVDCIjCUIbDoeRjYbeJktdhmZtSIyngQflEE0nBGd ZytMY0z5BDx7ME6Va/h4UNFTg+zX+Zntookop8tlaw6wI2X1vICTEnIXHjc4 htY4oZRd6JIyrjmyf7F189hDAqXsLoKgT+lzNBBntHYEKYWmFHlDCt3FKcch euzwJNerbFj5rFOTL4w4kmnVw5uEomsGVSZhx7msEcz3RfRKv0K2caBfuGEo T+bdlBzp0oZ1iCeJOhlGeL5J0JCyuqBDrWTmrrIkIlTOU/vcoPb9eQDfXtgH y0aSrpLCvmoqrLBzgi7PsZsA6vt7zvCfPBbYepJsJ30lnT/fZAuXiAkBtPOh OEL+7K2kD/2P7BTtSmTDOekabhUsPbJ6AEFSX8NgrHcvL9Yh1UpjvllfUq24 EVcLn15mz3H6K4q8lRuuG61uz6OpNvRKbfJtmx+HP4yqmv1BQEB+KCtoSN1P gjc+dLEZtMYjla2zFffDIST3GobtmYZZlsWKVxtwGVYDtQSJXbtiXQcZWSR/ L+BVtMqcX1lWLZRxRjZMjlhdYqQZAw4IHfRDB4s7ouBIh9jxnRROqJ16kiey 6tUJbourOxeicCm5Zm9nFrvQe7fspqXO65T3KfmKHOFACWsx7OUNyb11ROMc i68ECxQjKMFFtrQ+MhZZezlatU8PpNEqQFpmWMyDBYzgpAIE/KGNBaPdMd64 TimFh12jxcLw5DJRwZwZkjV/aiai1lwOtCPK6E9ZB5ApnbW/MFAfy3UrmM4O XRsVmNHPZ31gycZPVp5oBkpCRAGCq6osnSmxiQYMyYsXeojXaz1NDKUDoll/ w5GO0XE0uAIEPFKQYIgV6AYkwIhQmMY7Yk1J9rd9OrLPZZkBwXIxtnN+vT7o u2vdBfIgAGhPuOcVSMstySBNnOyULMHphMKb6CDDZRQl9MAaIsS0IMpIqqLJ EpDaCC3lm/fq9ATog47+gQKfBQZazKMuLhtm8zxwWUM21xLbddM+BXoyJ9/s EunyQ+VRthcxLEzaBM+Cy9PAEvrPehNLzQntZXGMn8VaxCmYZeHCkPyL0IzR 5akCRzGUaafEfZvbRCToLr4rJtK0Dr2XzH2LNwI4BBSlKdKcLpORBR6bNAkX K79G41A2dzIBZXHKZawhdEG4mCk/xF3Kqq1SJtocOq+4gHTqOach9ZwGonav sN7NGfemRNIJP3iddD/7eKt8YhW6uQU1KvQcw9RxJRXWTYKfcbtetAJlCCCK OFZ8hl15jcAgsjW2LLjtrScrOlGHMZ3aBBzoSQWmC2qjJmyxVYVM3mzrHJO9 Qew7tdX7gQjr2VAh48PFAzGEMCOggBxeO4hqrW1wsRxm8tCnSM2ByeHEMA7l LZC8gD2y2loY43zwJg4fxdwMOlpDuJ9U5UqBPMUeDxG2lu6jR/eDXJYyfApa oMCUq4EcqlP0gK+2dNheJb8vxoUVc/0wOVtC6sWLflrIukU3dGQC6qVGflnu YlE1XZATRmZ+A4prMC9qORbpRDBfB5tAkDO6Erm7Cj8U4QTkEV/UELpJO+zh hYxp5yAEoNnOR+Al6fsNIdq+HonHmLiPA7fLigLU7JR5Wz1NU/WTiMUBkpJu x4W+4sTRQ8y2GEDeyvXK4yfKJ9bvvXVP5dbjJx4/MUvHRGIdUUEJrFCMPbHM KoQ+om4ADPCZ9JubmBZggnRLDbE2MGDJSZOd0N1gmAR917Kua7gApL2zDerU UxJVxx0jhQtOY0bNqjK7EjErYLQ457OAWfZwQewpnoDqMKQlFvVxhstB5QIE ZnN4SX/nMDwPCNwgjKK5IZyZJtAsBl9A0DgKNAoG3eh6RsNznkkosKbttr6x pCtHpqlkvpeINfKdwIuyXU3wmiOQfGq+c5Jj1x8g20yYsZfgK4RNlewBfA3F W1v5pCks6kxp+QclEM+5hCsulAemYxEpt109NHwsSo3DjTnLELD+tcBGQZSG 7EkLYsDBMEJDb/hOwZXCNE3aEDanQxcCGirqbXZbp9i9Ap1gthDvYuaxZFjP PFa+OJEiwik6J8BEMiQHSzZo9pdHvBw33CNMB6F/K59H7Jm9VY97IO15tvAd mIVa61IJw8r7/1oQzjn/UkOcGt7rVlvOPMpW2yrgOfK/BtwNyUvxaMMteMxX qKV+hf50Eey5BFlIbWY5VEHhR3MnN6M3J7PSsr9SEBN8NyRBGzGcJaVqzqZp sU3b0PE2Rg+F0MR5KY/APLizpdckr60piovF6Mh612z4o8aui98ULE9+Ydad 0ZU3CfCo6M+MBy7RYhms+lLeKrcrgJH8cFRFmdM530GcjFM+pp0Yo/Li4cVk YegzHjvnI2/yhXIOobRo+qjYhkYuIK2VPQU8EJfJ0kxmBFKLHAbBLdcCkonL q4bom+JgCAQ87yGk2YicO1aaa0ab7KOdFGhISKwxjGbGNgSK3JYSgcechWg3 QD+gVNn2ZBGRDe/ibsECTOUHbvDwLV7EW2NMYDlOSTbi0xCYwTOPdZSlKcA1 eeWg+5oDKozdnEvTZVcrD68ucoZG1RpWnO2UelrQVN4Cqeh0+EfQNw10Domn o26EHl5w2yGOctSQsDM5lt+KDS+FW+EwDpZJdIiowD0T+jbl0Nad4EYcuqBJ oGdDayaKakVlHrr8yMNivwXtgTdSOEhBLdeSQBY9w8qSNzNo+zBgtsS1Naga Lag4ZKxN4lVDli5qhxC0C1+GI7Ibg1bGZpX2gl4UIvyC6NvGsAWZGgZ9kFlh SxBWKV2dnW2NDUjuRq3r8aiWDLdn051k94p5WGtvxyfiznpjbmlubsnZCuSm iHbsPqoD0g5DF6zfwVKVKS4B1DObBR+GzjJgAGUAXd8Hy3b/fbP0oX/A5vJ2 YzVnTyP2JOjxgcaVqFvHxJpi20p0lzKr4KzoZonBVoh2kILIliX1c2UVPYRA MICueLRTw3CbrGXZkUxAJiYjHmmmCk3qvNEdBSzXo2hwiWVOme4oASU2Hvfb 3XEnstIp0OBLRxGZOHFEJB0cnlfST01dtcPy+nayCiaWJ8VL4oXf2FSCCq4i y4akZStJ4FKTarqvdSkJ59pWUuIPhqgQnLZwJuBsS5UBB9iUQ1b+M8W+BYZS kyVKIGNwF9zkSNRHsmrJw0SREYj2gYXscb4bsc5p7bHiewI8Cw25zzFhvOjm d6dHw/MYhH2GBaFgauKQIhBnIYoqpAkpN3HpnJUqEuiPXnw45WLgR9fC9GoS UoGbmU4xAAqqulYWF5ANws7tzuXCx8FroeDguwREs5POJHt3K1MgSsC+cl7i +ZW0orypIzzX9WBIOSIuh9scmZc4LlM0teB3VEOjueMofTmsNOWXGIXbDGXc rA/6kxaBCktaus21zMhaEPv4QUYaYPGPI9tUB1JGWLFQnrpB8lffuFOIMltT i51U7hxGC71ouG1YGEhHTcPK2CKiEd7ssWOQvPBhkH2FHIMSFTYDiAkNyQmd jTar9zLuB8iPplmXCZdaGxycKZGsdc6cIttTtjmGn8kWB9RT7HdQUmsDBe4P ZhoiGRUrTcyBHg9OGnDimxiHJWGdoBoLVzgyv3tXr9LrNZ0PE4MpOSpKmOs8 XUTTdmEqKMYaWwe6uEya5pvy5ILUAIyMm8p4OM16KbsQnoT7txHxvLRy1IoL gyfN5vMWiFT5wvlLLFZW6UCRYNTG7pT1EcLJXo/8ILAEtWBFzHDqAhjk/BZ8 xwXurjTC9LmiHPTCyVXJ4QNF3+L9or24a1OKsCfGJ2FtFZqzOW1OyuHPoHTe KSIeFbhESHYJ8YgQRxfrGaFdI1xWIHIZoYUnMpaDfLgz46npFRuHHIKXTBdI wdgF0va0jdoF2jGZJFA32wEjUqbMJ7TnaeieA8eg6BzE2pFKVW2hAEMXd8a9 3p6hOW9IY2du+oSKlSufPRNMXwC/dcyDY0j4vml/mq1xPP6ydJ9pD8X4Yoee pWlyK1apQUZtz4h71ZkMWh5Uot9ithiKCUEiOq81FfZE62DR1yfqpEyCW55q G9K7Ek0Jfl5owQLfkEsvTSnNOQfujzE2A1CeRNrbfcOlj9AE4QYa7Qn6CSD0 y4SOqRuvZ9ISMKyJmMBiGYMMHOR5roVWNAXgUmzabpEV7E13Tyzt7RQw5q2E M3CLWrURMrK+ptow391WZAJ/2/JuHIc5NAvZN5/mTMvASHBtQwaag9EzS4N6 CzZF8b3spo6osI5V+ysZ2B/OMZIfWPdPzznU/oZwMlNZbz1ny2evSpuVW9+W WxmrYnQPEGPAKr5e025ixd4AYT/uhRyhZbK1vihIh9HAHimwIQF75ckjInce kF72a+ypA2BFyD1rtU82/2hED9H5z+PP1cygVKAhcfBA1cB4eCFJ0Q4WMxc/ HG2N8MupS5cuJwP8Kp/UsLzlkmG3jZl7bCsAYQP+4WTO7TSVcZTkbYndbEx7 Z8h9SZARrSI1NUwGkhViytLltgMylzFocYZCgyaD2W6EXpZkZovGtJC7Bqj+ NjYsTIQbJLFbUMDaEaLfRDra60Y1NZmShCEuWeGvXZcA86CecU4YpEqzS1m8 Fs4X161qcUmYlhTNLjoKB/z5hK006RouqwTYwX+1Fd8kjYnECXNjPK42149e OB4lUAUoP9mIc5yMGgyFgGYwX+3IXJdmraMYLoMpNv4aAJOImwSBPCVfryuf cvlApoBqBBjzlFNfZuYvXJ+DZrUd0jTrNgmi6b2UrplhyUveAv0WRouz9hgj aQdvyAcNTT7SS4kax3qm0XxRWmlb9rZ1piySAFqXDUWugOrB87KlxHGwrGhl RlEviAsMUFyQDDuQ5g+EYCKdweiay/NkXplLf8X+XQSIcTXn1HtboQch8t1E rD9FAgoZL0Q6Hm58sZ4pOONaxN8VAs3LtE23s20jOBU23qWFzxTVzXdpB44L +vNHX0KBREl5Vkj7zt3DFPCWiHBWpQhiECDxWNtCYhezNsELN8nh83xStQuc w8KGzcELGpTseO5wJpY8zTgq8pVjd91TQ5AhLJJAq/brPj6bR7w7qWavI6FZ 9CUkZnAOXuBG6iRtiGPWPoNLOUR1+i7HP1f+saySkskddRevjqkl+rmLNMe3 RMOEaJdOnBr+v0+qXsA/7NtXhmxk3XBvFbNvVxzhjVKZuUadUzv4ptEuyj30 Ne7jDhhK8QFQWJjvzvsOLeCpnDeEPicZcZH9xaDPm+FkVz5vL58ENAsZoBDP mi/BbbsaGLV03ToG5ofIflFmC6SY5yu9Ru/4xjbfaiIXYokMK+vkJUlg3xBH u9rzFEeLg4Tx4BE/DttcA2nHmxiVzAgc1No4OiBEoB5NCivi4XU13zihJpzr KTZmAbZXroScHQkHVcw6smcgCq1gsKcL6Kxa5V+FQEpkDJazlELhBk2xx8FN LT0EQoYJPBShsh6wnG0Q2nPNoQ0QsEDM7XA2ABDQgikZN0htZC6cCZRahnRw AUFJzlIM7BjkAG4jtOsE/hnlvvqul4v9iKViD4RMLwwSW08cG0Zh95i3Ka5R +s17UtPPyk7cizYYHNSXiqTesFRdJiQIVuDkgj6w7HVOO88SCaWuy2ybruI3 7ocE19NoYdKStAiqCEMDZOk3fLr0/hYNldo1Zww9ig1LSzEQyAKP4MprlY/e 4ZqFA+i3i5PUOPrSuEXRrKgX2QSKeEvHIeiZSyzGeIo5PJK4uc7kpz9TBN7U 2mVgQ/Vkaa6JmuVMwcz3aREmq+dp0Y5YdmohGk8kg0RFybSVABGHTLbhb9JV bKNRQd+ZkYuFIVFS4VG8BWZJNh2pj6dGxd1js+YvOwrWjvKOEO7Bsk03BL45 4VKNRhQ9nkeFJeeoJCoqQWgAWjN+b6iAWlSz6RO4MyyB9+EMKtPVIhkEFnW3 oNkpJ+BJ0kgFLw12Ad+QTyZm9uqP2EAenDm6QTfeQpEU8ospNgMARmmhWhEl djIAS5V6bDyxFQ2RxeGQpjU7BNzObrIdG6JlJ9mNMGg2e7Jtj0OIsx8xhQGy TvY6CUekKUpitdNjSner9yt3PWmBRWEYkezNVIT0COVJZBGvtLM8yJ3nousg wzRn0W0BdpMRKHsEoj51TcMMFdAUIq+yxpbsBZK2h+aQIB8VkiW2+QkcGIF5 Rhb1pCq/aqbkiIZS1dXlN0yIlILbWljDwYqQgnc6FuJi/GqwSFAKVlyJpAoj SN0Iu74MiJxvhHDOSnNkEFKNb4tTSdiN0nakTCrQ/ARPbioQYn66G8wymo9h ISvDssFtkJZT8WKcpgOvaps3Fma7UlDNpwHtzmMLMPxiwydeBWjmBPy7Qeu9 CbHeTKNuFbNN7lqzdxxETTaVrcuPwkadwI5Xs3QjW5sXleA9xQJFIVz8MQWY SdIa1t329qtawIppeWOB2cx960sGG67UGtXglGEPDHq/b30OHs2vTDGNgEGQ RPxlTu9DSXI9ZXW64yvlCE+hlgzMUQwW3V49tJ1Kc6W+PI8mMt24f72gbhuG F497WHswKz9nY0MnRuksXBFxF1paWF6Zm1+CpoCnYdLwEkjcbEAOSPiD9w6m AhP1CKnheaazrWQ0SnqzqCZZg9aGIQqPRgbTOkWZWQ8QhIxN4xQDUXTvTN7R u2pwDYKatW28/3iEwpRczDiUXItILiuFdmjBoVLcDAvB65Bo3dCb8PTsljNn GBhauKsFqdlDbylobQmafXjEPlhnGZOWS2ifzrNbXCC74gbeq2AYYt0GEwf8 YiPaH/cMizy4Kflh3CgyOaIJnSgpnF2H4wZd3iyJH6204E7NFJw0lsE7fE/m Shjhpko/kLCEUAD0bJd+GuJHyiEOxN8ULWfCzUCFQY+IX8wWY/FViM8CpKt/ DZCddk7nII0NzB6bs2cq4xjBephqsME7x7cLSiVTBMcmRchnWNkPEfrEYK80 ALI/tNKfR5DqBLIDuTuAXDX5qpr51BF9D9mm/JuIiNhMHl9UFoBwKaQARTkU hn4BeqhwjbMCnFokuyZnoUTYNsKy67mqMg68HpCUNg9pSPbJCaG40WabOA1r wnOoa5T2wM9YzFIoPicH3pEEvWYb7lFWum7JZxkE5T6b3WG7MkwSg3dTKxym nOCoucLeDyoSBWyREsUzrIjDg7iq0wXkAxvcluq1ldRkRTamHslJXEUWzllc Aeyx1KIThtQ8zs2t034EgZYo5cg7u4hnSPZPC7OhV3ATOiRElH9Ow/efV22j GLYSWQJzRrYRjXDqXFnnR8ytYSjqm2W9XMCzkEG+GYtbGhRPFj0vqJswJZit m3vOdeltdjPopR/dhAfuToQW2tqZw7ZldkuuPsuEsa4d4BE4KmBdDAppo+eJ 1Vd40l3F8tIBokNs9f+iptu/Z69J1LUVnErbNl0L8s6hohOCJ1a9ILD2fWVN OPCgkg386Qnap460Yt8FEjPuSFjXfZXGkIVi3O3qssTzHxn3J7Ra3N7WVqZB 19QUJo4DC+yiCHrVOxutq1Yw4kP1wz3QDUS3YTqAaA+VAOP4ZCoEG1BlM1CB YnNXCEBxgxCaWw3XTunYMZuwKbda1ggF0wUfK7kp+XF/d5Ju5yJGRNJXHjxV xrjup4AnRnR4LIxHx4+vTWnKX793YUNJn2NvjZPDYQgd4qf8XvOshiHGsikB H/TAvhYBI3iw8ldronEx2oYgIEMScMAedCDtp6VnKf4sNSRhfQ39AdZFfec9 hilboLmt2DCPZDMHYQ9AckwnqmoxAxjmhxzARzUF0lzxgTbVoTGAo2E6MqQX 8KBJf68HjjFudGktOKmGDAb24RbY/KA8BjLwDpOWocehLUzWDg5VNN1agJmg UWp0Df240GAtVfY9rh8CTQzqhRbhw/gGMBFDjLYmr6vYKy8Uym/AgRO9rrum /JDzOQZd6VeWC6vXIH4EitbYcwiuGPFp4SjeNknkFudmleHthmAwQ3FRQIsY YO7RrW7cxnBiOzZesBlGykpcGmjVysd2k+H1GkLEuWTEVo9ABpobLe6NewGw F2Er7sYjU6kbt4aGqZSdBg0D7CxPniz0aana3RDddKKeOV43opQCTchW8jbS 0pG9Gbv1moXiWeNskUU1EwazVbqDWTJXUyseehEAaig0RPFb3Af3g5BMVNIo 0m4V2wZ8xy3I6TV7bdgaD69Hs3CbxcPoWjq7G1+PZx+FVJpmSDPi/zRjp383 FJiB+UxNeTb4CPKs8GAUAS6r/KIW9hg50G9wzkUYhKDumhn0EDBN1F5D4kxN QuFHwgGaQdrlcBJR8c2Jpo5c4bc2BxVDQaYNgLl7JjVxj6t9j0OKCuI8x4Uo GiisKPVwZXgsNEf3JrhyDxuVYRVswaycN+CJ9e38rrjVyhpTk/ET2jwOEmv6 gCBoJo0BNLditK5C058YjxqUL9+91Kg37wZbNeC+GvVqIRThTsrHwFzBswsL S5UpFhOfQku3113Cw9UCPa1Z8KgHxigQ3qx8d2NuYXGxMiWqIUoQQLPMTlIt mp0agkV2vgAwdz37Z/6ukMB5ljdxpt01IFAb9LefwT7q5m9xcR4+G0sLdf0J f435pYW7GnPNuWajsVRfWrzLvJ0zH0H9GRzDxD9zHRrmNLgrNZ+tqNuN+3Fh uYPe/yX9+9IL5177mVOfB6fhM88+dPqi+XwJ/PfCTzf/vuqjnwjvuuu5zzt7 +uTlm8/p/fRzv+l/LL/0b/7hn9zzey+7/tHv6f3q99v/f/DkHzzy01uDX/zE x79l9W3nf/u9n/uS6c+JPv8j93zBDzzxM1Nf+4pPfG/46z97fuOvvuzPvuOB 3377i+e++NEP/cnKx89/9y9sv+T4v3rH82b+2vuXG52PffHu+tKP/s5nfdeH nviqv/8H//yP//wXGz/wtz/3h9//sVMffv03h1/9yrd+5j/7ya/44b/zspd/ 7L6f/vno333jf/nSF/z1D27/P9Mf3PuJJz84/K3X9t/3n5/7i1f++Fs+XLv1 /yx87o/8h3/yU+980xff1/vym+982fO/9tUv+08/8KePfkVg2n/7v/mXU39j 6n1f+20vv/ANv/xo8FvHPuuP7/6VG79/6WM/9BNvfeV0OPq8hfaHf+fX3/qj y68sfdrcxju+49XB83+s+dhzPu099RfcdfKl/+TrP+dWb/rmx8f/Y+8N73nP z7z1RS/66iNvXn7ba5/z4y/6rJfc9aZ3vnHq/33Hr//s83596oX//qce/o6X vv/13/CnH/uD6qv/y69+Re1dZze+6ntfXX3OL338r1SPvOF7v/xt5//pj/2N X29/5HeCE58/eP7/bPzan/zGE7/27l/uHXvje9479SX//X1/9fdnr/7y2771 B173Ge979Uc+9o9u/5uFbz/xdW9f/8wnf/PaD77j6l3f8PzmN3/wHaP/+7P+ w/f9p/c/Nvsjr1s7/Ybv7M19R/DdMy//oS+/5wP/92/86uf/zmv+xrf/i//2 nJu/PH3kP73g1t/83hcspd+y/tGrT26+/r4ffOK3fv33vvhnv+Lvf+vzjpy9 +Lo//vJfPvuSwXe9rvfDZ7/p037yu//wP/zId5Xv/4HP+O7uN/7M1/zD7//7 r3rl5ud85X947jve870/93v//t9+zrvee/6b57/6HV/U/aWjf+Xkj73mNS/8 td3ffOV3//f+V3zrV/zep+/9yLvf/OLv+KMfvxkee/u3rL288ZXj91/6wZ/9 88d+8IP/4Px9Hz/24S9d+rrt+1vf8tZv3ftP3/JDfx70zv3CXd/zbx//9peX /87ow5/94W9cfcFLjn/0h0eP3nv/yt+4/dsfPv+b772+/vtf9tvv/dVX7P78 l6z/nc956e9Hb/vNj+1cS6befv5Xfv9Pfu1S56e+p3f3z5Tf2/zvv/Lev/2l X/bHX3Lvh48+9wvu/cB/v+/jH/8n8Qt//cpbP/yR4E0ff9G3/dAr17/iB3/4 O1//G9GHvvP8TzznnV//ip8Lfq7yc4//3Oy9L/74733t1j98/8d+5Jf/sPOR V/3WB/7FV/7po3/w9f/4Y9//U6/513+6+54vvOvn9554293/a+VH4NCcPXPu 9HsfuPqOv8iD+wz9Cf4n1qJtqMPatfQZ7mNf/G+wf3Nx6a5Gc6FuvtTnFhsG /5vS88/i/0/FHxkpBI/q7Q8ateXa3BS/ApLOUHQOQK6loImS1+V2BeI3rcw0 642F4HWGr+vtBSfTneuGhzUko9i4neomY1Lan+3fANHYNgVwuhhhsHJD6d0b nOnEQPNN5caErHMrwpAIwEDG4CPWQt0IDgsJ9EfOXg7A+Q3yv01Nlf1wEkEA CjZDvaMjbQp+UPRsxvvjgmdgr7txukOOM4lh5cjJrBpcJRrzqtgYMMUKMYOC q9FNTEJ8VaRylPK7ZhoFATi2Y1ORYEc2dEImygXbbVy9ctX6j0krUlKtzjo2 XbvitdraA3NkHmXPQC0q+soidNh+SzwYRJ2KsMCr3DzKUS5AcF4rXMFQvSQj PN+6Ju8oG5B+CVbV8lYsrN17GRyrnAxHicFAJSuqTJNsSQ3fCiYeHMoYEiIO OYcByqZ4LaYASiCMRKD/1tUcMMhEFcuhY+TEcviWCo4SznvqCsq0a/KOSu6E 6fldDKuDkZe9kv47mfzJbjc4duzMqUdOktNusHDsmIQys/5Qvlc1ixTAedG0 BYsB0TSwNZAksESBTNT1ulCrZ1lQpmcs0rKqKvf6aC/1Jwybe9081aUwLp8r ZTe8BgJZXZA3OdMceRnLWpwLr4PQSGbtQAEBYDwcJiAwnbG7PpPuhoMBGIYz qJ4iH1l30NGhRQNZiPIv1fQoweOgzg6n4RKfRIPhDQPJHVzRrZuCgElgQsCK mp8UfMw0a07rlYpoo8yLNVvqKAU89QrakpDq4wq2SxVQAHsF8rkMUNPMLdlJ nUHsss8Ejh0D/2eDwI8dq6IYkuqBxnk3HHZSzE1t9oekVtb3HiSzV1nGU65c DU5eOFsjf9lplBVRKx6yCzsdRE4oI2W5FA0E1g5mzoIfxoiop5y2yoRpvZKi 0CTRXaYgSDroTY2bkqqBbXs9UwKkHbSit6dUudoVeWFlzfCWUKd9JQBk4A/U cowdYVZXam84c/HSWZQpT+MNOS07cxbyCPbNGlho5jg8ZAIAdudbW3E7Rr8Q WPY2Nx/1t800U4uFqTlrIgixMWZiFxmvyr5BlA476kDKEIjjRqJUlDkr0KDG rIOhQDX4C/Tit0SnWhq84Yty4A+H26cgPaLeKB0VA0WTdQvKUJuWPDVwBxF4 pQFTmlxITgRzwWqu3YBEao1V3RIOCC9CVyzQBcg1xA6Wiq5xydtruuXmhJar tFx30IHUKO5nbmI/qGauqtTed9RnvnZx//P5/s31OWY52j7NHWowh2sqMzI6 fUX5H/LdkReuBj/SY3Gbtz1EeBJ1Gd09czRy5y4JtqN+NAyVTznfoJKCkQ4M I7UkAOMSZfMLUYzsjKo8RtE7dKI0hruWbFaD33jbV4sjHrZGslLQB0BukmEr Hg1DVBLJ6Q1dmoYeBKpmujHMZm9ILM3Y9g4pr/y+p1S013jq7AG9UpPBucvp ivaEozPkbjGLJCZ36rfE2SEz7Vyp8UTL+pDalzJv9Ra32jQ4wk2MJk9fJi3R Q/MjPds3l4iZcsWHHhBhZ+EGkbKomAzejbchjlcOdxIFc1Leq7EBqfQg4lB7 eUGw8cwgi6gJaln0tTkVrhwqWGcudF/QBJ0skCDZfbbUR4BTKmO6JjiopuXG Gn+9j3vj38ePaySAwU2SMcQiVIPZwJKbVVsM/mDOppBMvUzVKn6hLpfITEeP L4Ds1ebDjMt8+MOhAZkGuJmNeHNNvUQiy1txXpkNU3jTu6rcQ54f/nKN3Z7y P7MrevtOoQgJPCbPSE/ZNwcBPIZQUxr28T4R0IJQQUy2KrCy1K8+4kfVeXMF LAw8edudTE2OO8JTPVQNUC2gqh3XFqwHioOT7WD8t44zhAoTqlJ4aLWYVNEt JDG0jPv803Sok+P2SNEZtOGG2JAdL9q/h6IuqNtxxyy+FytGjG0GYWh7IC3Y 3YnIeVqVpEZc6DVGV5I3IESmKxnyT86yjnUugr971FkVuYohfg27V+slb4m7 3RBtfN96zVBv/U4y3NqajdLFmc4w3Bph3JO706g9M0roKDEgwnSBDL8BOrB+ mJqVjM9fCpaD1529DNbEIIw4efGRmcX5WnB3s74yz+v+yMk3Xjl58eLJN105 e+70mTea5UeLrUGyW25Wg4W5SjBjUAYX3o5GDwuGskh7msYxXZFSzFg+HF/3 gDhPbXgYz7ZdztESYmpDLIK1aQmmKUcRsgcSnodCFcvP+9azE/S2/5Tbc7kC 0yKBkCcWgky5hrDugw1GAhYcZmuvAv1wNcOzmzfXw+CqAa4z8LbGIIeB29Jg GApaoOAzHUqahv7lsHwzXbN+aS24DAc0BZ9zhjY0YtFlMGXKFkVkQSedDkm/ 4AJFusZwNTUeRYaXrQrI5i9UdfUqMiBf3OGDuBpo7A6IR4ECHll3ZhHvI86v OhgwRWr2UtIXlH8byCCgSXMToOu8Y6AFd3v8nb1AkC9EkUZZVykcjr6wDj0e vp42q3JRFY5Nw3WWw78olmXWLQp4QaSNhQS1m5MhXWnTe5ig+UqND9JT2vP2 /nvNK3k0u8Fw9tTyOiLALirSSHw9i5e1KyYTZiEV0zrccY6WqR+CluFgLMBo v97SD+Z+oN1BesZcEvhF9ogHIW/X/Q12jW1WVct6m73t5dZ8xCOSKcNHjNEg 1Mn9sC94hA4nZsroggE7a8sQAXoR6kblTmz5VwgPxWe1ww0ljn4FPMHpDzPU pVQWOTEkuLC10A6qEwkSgBJVysvWWFlp1Ghn/NEnwyyg9aJeQifCsoy8tT5G kA0VPF64vRBnXM36Ke5ygIPSu0uDPOQe50hEqC3bP4lmyS9J5gQeGu9Wg3k7 kKd0IA99JAN73MyaY/y7E0hXcXUmDxiCTlt6CdGU4bvA8Iy4UchsCpGC41Ql zeQetlBW5Fut3gcurk9md0twbPHmKkpeg8qELbtzaNVEJJ/lY8foIB47RiEM zSEbgMyZYm8ykUy0ftCFeOUGmeOCpEwgxH2gAq5WqTnQIG0l3U73KiFzxBAR 3+HmMX6jKoCmNSZoVNYUjYJoY0YSGoBuQdk5UqtmAN00Ca73k13EDtjx0Ov4 ItqXS+/DbJczrk91bVHQZ9p1dBEgKSbQp6Ph2GwtuAnUgpPdGMO1Qs8dTPDB XUP4O+yTnuYusIEZG0Teyd9gfBQOQ4EQN0mdnYVNntj2WhE9oasb1HBQZTsg qHfUMqRwPOWJWUtFElieJUsXgCWrMvZnuRYssL+8zBioNSZTbrvGkAAFp0DP 73CV3U29wYfOlifyYeJaEFVKfUwQk8I5USjRLJttrahkxfqPYzh5LWS67fMQ RZfxpHWFC4mgV68rRS+UI3LtzhbOirw4/QwWv1Lro1dAWS9apeIvmx3t6TxH agbOygI7dpS3HQQPpiIDQ3SD7UNr0Njh53PYLX/mScZPLUWI8hYHggeSCE4l QkHAHQoQXhaTHhVuK1h2j8zoQ4qbr6XSqKcjURIJVA888mF/j7c4TXp0i0CA hGd3uGiHn8oGy0ZmFR2y78UbjAk2RTrEO9qmxBGoS43RxHoU9YIyUexX19fX r1YKNphD6adX0apGfvKe2yaJZqCS+kcRa9irIrVylvArxNroeGLH/I2KgjfT KFE1iq9Wil3bJESTs4Ibs+PcgXsPW+wjS3HRLBphBVkFb6XP9m8k14G54qAB ZfTFccokEIURwsMVzmh7aOViaiO7PNSivgZNs7CiaDlC6jLbUTVoaukISsdp 8Z3ChRvMTBgikBRcjz6Ab1Fz3O4Jme0q0V0b9NPSw4oZUUJS/LmqlW98u8K0 vBtUycz6NyDaMZrrOIIylGC1YD8hDhJXzUSumuYjg6tIGC5SQ1rlQXfspx7E SefFvmpFlLYIyj2NsdEVbIZH5A/mzMAYXiSUoxb5BKFLMcVJaAdXTceruE5X DdllSF2azC4G5MpOJhyNhukB178ox6js05pSv2MmtM3OQir/ihI938GUoL3H 7mha/c5hJqVYBXGkkluubBAif5+hZA4UvgAlqhWRb908vEzL01TMiDLQEI7m fj3lAjq4N0qmwIpECZ9geQrLovNBgoTEBgceFTWcHFNCjLnr8AS+WC3CmFmF 2J0LR1nzG5BsVLHDVit8P6+Hr2Cza4SFJinEMkzQ4QSGT4HkDwIVbMMKaApq +BO0le7399fcM669dbXbsHUyc/38cGsTZKHIhxVv+SaLBiceDTOSOz4aGBzo qRyNiSfj/5yDcd//AQfjvv0PxoRz8Rd+LC7tjLe2ulHGLsflt+slnQiCNrgb 0jylqhsPxqm5iGbehJGZU2pos8yK16hfA2/VAeRLQrUrOrdSld9421dhpStc ic8Y/5pgFkppYUZ3CN6eKpRCIToeCJukTjuH1YxUg6FhCA7BK0ExpErhS9Ir 1xmMLAAB+GAhkFHRKzsapyKxT6CoPV3+U5rahhbUevsupf2dD0GpGhw71j92 LKAxsvhUhKo+7U7hl6g4xwtUCUCsMaaVz1KLSn/G4lNr13EVOZSrLqY3hv9O MatKgg7i5OyPxC5DCI05i4j7BexU3+JKxwtpudedsFtao7hhN9ShR5DVV4oW 3sI0NsbZgwwg2OAt5ns/Q8NdEitkoi2nU9mV1h7sCbhFD+EoGnIdJMUdfN63 KEuEEsPRA3lxxNNUUDrDMuAvyhP5qQko1kZA9W4O5qvcLYh1WYrgnvLEw9V9 kbNgP+GwcCGcs0oXU0CgAN/n+SCeE7ysSTdaBQRGgqQrzL5F9Qqe35ant8bH 95uKBvbCIovexlqm8H1UuFVUeMaWzqhZcMSEiGZ4hEr2crtSDaZxjaYPYaKH sSgA3YXb20NKm1naHibjgYGvUgCcYejZ6tE7BWCtaCe8ESfDDPNySADMEE1i ZPUMXvhZrSbpGSYAkz77QSBTK9P4rI0uMMp2a7K4wl22WeOo18LSpYc447Xg AmgfJLuEZKAEzg/9s6bEylY2iu1di+3kKRGgNI1oAushnsBv7qAUTFTh1ivg f2PLoLiAp4vKFU9ZQOSbeguKDXxHSpiKky6ZlY8OsywQJaYXdzGEqblFaA5X KeKLgWBqDkMw7iVjVMLRQphfcpFzuzYpWD9+YhyJhMoUuLM18WdniTY3N7To dY4qZHcihms0ONlCmGg0BEFCFg6oqYnAQI5c4BNwMBywwMIHBqz8jAPD8eOF INDwF+hSuAWuh21nvgFRRyGQDYtz2aZzDzMr06llr70rtVEi4YomuRMdxd8q JakbPJMBZU/4rKSOvtA1TzQUSdLEGDx7bWYIiyLelAS4AB9eBjWBFb7dwVxk f+eprOWyL/otpqCFmlnVSgVFMDsSZdA1RJomECn142iXbezSVdSw7FKoa5sZ wBy21Nwi6dYexRkCaTy1qNQfIec9LqjcSYjsVG3Yiiz4DIcjyabzydDEoDZ4 naLmhHFXKWn3u3+ui3bDXkF5tasrc4J6WcUeKgdqXjegNA3HV2vTodjf/lJu JM4cS0JNkYsQksINJQwER48YAB3j3FU8R60xcmW9GtfXuhXI5Mp6lVF4Pbpa Q8bg2DEk003rGM+W2prEE+B5sxp36Bwod2gYv0CzGgRwEMWMAuGX7HkhEswd /CJ2wkaFMw1s1DdzyhW00ZGuaRksv9AvwgApqU8Ix3EyQGT5A7Mdwz1RRvOK nuHwU12Me7Y17gZiOE2FWFsimGOfHRQNvd043QyOPropAUDtkM7JdUmmSAcv dh63csEMQ5RZqYKlN0ekYc6H4Zz8VRQwpiW7cyimeU0GYpwwFvqUglZmQRpZ SBtCPGMexj4LmWU094E5xgMFQKePMQTG5mPcGSYDMcQugssDQNJsUG5HHAzC /IJzk3cE39Opj8mMC4bzdCByH5DzlvDyMO5BsGI8QaCa3vNFKH09THQPbudh Z5ISi8eSISeUNpZZON84npRYw6g9HqZAPl3d6hoSMepftb0KB8cv9Hji/mAM WTh3EO1WkcZsU1rO4eis5qLQ1XU8MsX5Oow7SsPsiZRdZUwaVy1yTcCOK/uI maExETRjYSVqzhJmrNOF+M6OvuOHZgT0jEFRPOo0dzg7K0sjjsRdc0bQFsh5 nmRg2WPnj/ICVuyQuUG57DMLrFhNmOc1K4cXbiLn3UVLL2f7OAgv+u4tZ8q4 Rovpy5ap5obZruPHLbeycc38KBAiu8wJR3mkqq3ClnxJhW+Oj+U9GH6Q1xmP UN9eNsTiWBg2iKTc2pN42xVkbjDuPZCJuDVMB+QBmlu0++GLJnhT/EJVsjEp pNDDjCCc4QHZq04SkVSU9cAUosTmAMDVKacs6pZcNwfigk68xdEV7DALLSIa GeR+gaSDmHsZcllDrAeI71I4gZokMabp7IBbVRcDxFJjrQjSGUAgmU4Veeod CaxC2fGgMTaAN4tH4V2724lhL3d6BaY1xG0z8QY/EGfT04LNi9NL3PVk8aW4 7T1AsdrLUkeda+tfb5spEDFJPfuKf8OwshZnnmLOauIO7+phhV3CQpCGAwFY Hk3UzTnUSXBzSNRJBEXseZoW6L3MbZcTjDE9URFDGB/78nJnhKBHY0C4OCcQ kkpPIiDI8zbwx0uQ1W0pZCRjy3XnLLPK0IpTpVZ8JAgvqXNbQGvZ9htdEW5U 3XqyEq/XyY0W4MoCTZ090X2NdawlGpxGc4QgQyA6LnUweGzb0cFEkaBJqyOt XBAM4tvtmfQ56BxagsNadvjToiGw2qN/J+Gj4tErszGDhint+WgXAIF5ExYT FA4XhdkpCyImYdSJJw4ssqzzZbF7+DN1CnF+7hDqE1QAQlDaQBA8j/vuvNnB XEMxWgC3vJuD+Z3xocsAqPM5v7Zp+2gZZH89q2SAmtdQH+Ga908u1j6cnvmy JLZxF5rdYrjGCSgwLrOSgVHMFbfX4IcFpmSeSTaHZgbGAKkCx8BQo8xTgPMV wYsawgHQMlKkWyGUw8Wb4cZ86j1jaJhRhWUwRybYSsZA8G/Eg2CUbJNtes8s cAy6UFB7pSR+s7pXmvfMTMaVAU8Wi1X6LAjfTmybtDhviQcHnHxTouxHEFFG dcKLwO5hY7XgUaiBoTcGI+2+zdQ05ftCkbOIuAF/4bvp1E0B4rUTajAjNyRQ yqgqM+DcNqrQD9AtmkwDg8wbZI+wzUxLma1zOCNjHZBBDHdgRM2CcKvhF3Wq kDvKSOCgU4VGjBCTSUEBm1nmdEcaNMCmcQMljqSJuSroNYY41BC4ajeBVBoG +Rq+h7eJKcYUIvuLUGEGD695Qz5dIrvVVwymKE0HCaZGZfaYQI3VH2rzYBo8 prQQcYte8BAYmYx1JiNka56U5m/pDagMzsbC1ujAGBmLpGydjTpWk1+NzTu7 5l9L8XW0eykodkgxQqiN3apwteHXw4bkpidbStibcWq9IAJnLPkgQNlQu7jm whsRNE4Wmx9ecD4xIAFfmvqGPKRH5NPyafVdEvg2pgAsov+lkVk5nOfRkFHC i3be810U2Zq7i2gwSd8iQIwx4HzM0OXErSjm+xFTYbHf32cn6Rqi4g4e9q2i XAwfTckCrAdnPgt7W/H2GCLhsWwwhTQTkZ0RBE8EXy57r/CpVsE7+mmEPFSa APtnWoSrGFlkzH9Vg+7ToBX3IZxTGoXD9o6zYons7LOg+bQsWtzF7UmWlD+6 NiBLdgnN7MTbkyGYpS5Q+D4s6RN/vRg4LJTPbnWTZFjGkse55Kz1afAZSwZP U3mzYpplKRYNCFo8DiQg4iMem3lYcHeYCneGZdg1BHFMV+DJ/N4Hw2QQi8Id 8LAaqN08AOmQK0rcuZkhnw+ivtX6sXcMSiWdX0wWCzCa8ZnDADuCmohYTuDX VSdZh5/HeRRmlJo3zN4M8GeHq1qktuI+t9VwTvurgW4et3c/1lOfEMCAnZsu SIs3WZTOqtJ6qdUMPL2DqUQxnpBvkXXIWyMxvPbIkBEazPXsgUI5L3C3IU4q KPBOz4Xn8qPKbMlxs09Fw6GQIx3/Gon9a8S1xaumbo3OpDujYFUqamx3fj8Q Cy655Zm+YseSNsme2xErsKxLlYhJp8SrfaYhnm9UhqSQ7IjWyelLyI7TSfsg HbQh5yNivkjsB5UAWAhBV0khfRUYHqYUKR6qiH2OHePAuUVIXDDJegGaaFT1 DVf1UT7faBr7FLUxYxux914lg+Yi4ndG0XbEIZi1sw6uKIgqo1HcBrPKbUOW YVjS4CTmIfLIWQ4nfGFvtGP27OoQ0mNDWFerXQkuRWIgDeW5oOQPRB2NNZI2 T9PaAEugjTRl+tmbdZHxMCwVdsKSY/yub0NUr4AmIRnAv9FAC0VTTPKc9RKg p6SYUexOwE+sGocgGdrE0ubDFG4w7+PRdBY54pd2FHfL1PcMtQkXHI6tarCt Yq54MvvzVh3hrLLn9PhxVk3BgdVTD6hlPqtURqbk0d9QytdIyJ1WDnfgeB8Y virrhZpa93EIIXQzao/RoEnHigkxZ7s5TZD+zR7jkFN46QAxox02cqGoHk48 NUXrx+0/kIzR1tzBBEbgo4CJLXj5oB9/FlCvAf1TKuhkqsHmaNkvoUMs2/aU uZTtriDSaKr2O426cIhdMD410lo2VJ7H+OW6gKa89jORMtnjpJJntZze1zTh s9Nifma3ACeLocPYd5ip2zIFsUQPYggsfZVzilkZEW8rqkdAFV6pGRChJIVI AmfDlE+nglmuCshh2O+rZl5MWt8I464zemvF/pZ7EYY9Q3gXW9zcdeiRSnUB Ldh3meiF8IgXmhreV+ukFDAP6vGY1R/tDA2tCoEMIcHqmeHQEL7TOJgeyOpa FEc2wvTWbt2nFQgc2hG4lT0FOctzfVx4XlhJnQxKugt91ihXYLmo44rM+7YH UNiYL/YGezQ0hcDF9EBrTwezFLUc8oOggNsJgWHq4fUfi9es0zobgmpmK4aV o1jkwJ21d0IIeA3mkWnQ2euHPfBARfCUCdaCK0FonXARFw26YTuC/JEYeRw0 oHQpwh3Zg/vcWhXYzilMthuCsr3zLYEQCJQcBxfo5H4b2jjchqItnhBOPldg +8gozRUsFTj6TAiYWuzxBs1sxJu6M/xpTtQVQ2s6EbsMERTkq17hLLHIzKOd 0305VUSFoBIF74U9ZA3QJ0M7AbkD9UMCMx5bLZ633L7BXiq2J8KwmPhcRMG7 FxxNYJk4TXavp5yXBFnYNYoFwHoINibqp+MhmZ+FZG1jw09Ta5JJOFHGsphu AOok5kQ4rHkyF4lFg2hc1RJjfwuqfggkFwuzoREdIznpSvAc6a7c+ccJC6Kz YRIb+wAeeSyooMEWihIXfJfmKBETNydGz8sGR3wk6iVgVgzR9G8OzHp7STMM sjLk3FCQi0QFwjXtcc3cZWTQmIoBjzKQfFFlTc7xRcL2DpTgsjX87R3iTgcI dFNketowgWXqxpw7+sLXloVuCU6x6rlr8IUFpuvYQVWaBY0bPNjg35JpfkKz mTPnV/WOlTcfJcpWUe7Ma29PDMWA+hE/BLI1nVYnsWfwcJxGBst3WAw/Av8H OCR8QDDxKtOTDpOnY4rXzoox6C+/j7th7Lk2H+pGtjTW6HLci8z1pFIGZa5l tbyUQlrjJO4+sy5bkNLIrYuhT8yidsZdAlDMvDvuc25bVEKwIRemqzWkbPs6 QAu11u5GoFaSJdji4F18nZV5WQyTSbfTlCfg1WMA3FQlxxMKc4J3M2jcQWdp UMBoGG9vY2peyFecoAVTm5nFDuE3oTMpDxLKBGJI13uO0/tWcTqAbEajrkYn pOUc9+3N3huDFg1Np9th31EJmFV+O4HOMFutGXUfxxFAxOarsNpXYTR4769R c2AXak7MXjKe7gQkt07AwgDzlaMyFu8aJBTYlDYKUd8TdbYjkh9QS1ef5Der ZFBzG4y/XVu5dkZDQ/W6hjrxaJSw1wevQTG8Vpn29tRIHltS9VgCeD0iQA10 ZG2dE8oxxuRTIh3wF3WmkTcOR34Me09xIg1y3ZqsF9AQuDCs+rhS6ye7ZYtm ioao/MXVSSpiwXjg3EhFmUTxkXaN+shpAgXWRzF0ZogS0otmCIEKJk2xohei TxJqaXpoyYZ13E80BDfdzdg6tkM3C8r95Wg0fVvq4bnG7wMR4K1bqrv7PXQn NeySadkuIg7BblJiTRUo3i1H9AUTFuBOdvQO9tQ3WpLBqR2yh+2o2yI3YTcb hdQRyqtu/SYFcZ3sDTkZkxrkhfQbIzG2gxEi0Uex/YSj8Gg0S34lPop0HCfd DqZlEFSl5gXMnN9ZN8Jz3tWKhpJX414PohqMoqsYchXpuqr0SjJc6ZKwGDXl o0SQqIC3Ckt9ZenlFgISuD0Rt9kRaOzG+yPYzbG05rm58noDh/EOg6ToNVvW 4wk3h8+2xW0wIQzF7qNzCuoH+AnC9cNCDx9wqFfJgGpRA/5hIjvD7ILc+TG6 o4OUi1KyVhyauMj89DBYyq5zHr8SjdztnkPkaycOCy+DL8b2B+2Ah8G5h7xp xOEWc38sNHWnuMHpRezJYnZKEkJwCAnOQEfHlYVwVqYBlssgyuugmZiiWYFW bCcdsEjbApIIRXlbuDDm65RE96JEAijNEcEu2kCbgx9rX3o28R6Gg4Lzi/nn slYXjtrk92Q4VuyvA5lPtjEbRsaW21lHZrwiqbwejAuHOkETm5OduSid+3JC B+F2TtXC3uhJT2u/XBhnq/+oojGY3YF03BMfNHGm0gk9/U62EvQddM434E9a gOoUS5M5hyiyZpVI6CRKzhBlf/LIOr/4hA2fIhQi4evNA3hLlg3FMzOVTPV4 k/gvqski77U7PV3Z3fF4FoZ0lqx0FE91zqwE9E4LTM/V8iIKYzg+EMgA5czM YBVzkTR8tJNlEiet0+2nPccxWFi6LK6kQwWqpmDCjCv2n7EIPQ4CFz3/jEEC h2c/9PwdwZqyaAqq5jiGbGj9w6+aXjDHx0Z4v1TNukEIXYCFnWSXWku2RhyL AdnveOSJ9rrhW/YkoH38ltAh0KTP4dkdJ05rTkIGapu0PQep6bgwpmE16PHs GQNkKzylpD898nIMtfYwtwyK20zhWq12lSUqhk7vxYBjxYVuJ0zP9Me9B8bA phx9UvLXruJa37YRNc9iKQpZUJ6WUi6xTz/puwKQ1BZ9zCl2y/mt6WowHacX RDtGD2wjfjow9zdd1DnU9FPnUlsPJ2ZnIm5xE9fWGfeQk/85GiOOzoYT9bhr nsVZVNfmp5SLvKWUoAEFm1NPNPdNOY/9hHqqKHr6qd9KkQis3XnOGcwUGlnN 2o5jDFlFDqsY77OmO4YLfFo1Pa1VjSA75NACyQAHoc25ySAWX1Uo4Q1K7vEB D4Xxuls3QPBORoC959dxw5X3PAiwQkzZuig84AY82kRmDpeEf+83UId2ckP2 cOyUZ8oyjCP2ByMpfkY1AEkQGBrjSOz4D6sNPe9yJV9FtMDBsCeG+lA6YC9C hw774bIyZ/Ser/fzF6ng2zmPLEYP2H0GICgIiltBJ3gGT7gdMG4jFFSzI3KY pHLAifOuEniSxdy0G+LTb/O/5beGL+5u9/VPc0kPu0x/sSuiIhxkANQHTonT so+SaFK+K88mJpeW0VqaHpiG6QANpDVJD1zaFrBWL1DzUNGJTNWd5sESSlvH PT7bR3ZvCFy/KU5psmIvP7Mtji/P5+z+n4ngdGpfioPiB4Vbo9+71BtP3vY8 JG2QekGDT8nxI8jHzvdiNqoh6CD5wZ3nyZogfsvkyiLnEaUvZS8i4cJ8FxEd vxq/flLOh7T8dI4HtkGnQ45G1TsnRQcFK3nrc5aWB8Ad5wM0YAH+ICEjvxBl bwpRAoGctfY6MbU2ec1yPi77LeRE/5fDpdZjjxVvTYJMBthDBlQO2arYQo3H iNOlY02XRKvj7p+MazhbEdBNb6UAuAJiYDB5BamzA+4gzXF5FKVozM31hg1l LypvPagEBpf0hTRnbhpep5M1F6NECf6NHFMsEye0obI2REBELa1nsiKX7Y1t eSB6le7bqU+DiVFwQefUJBqopmChCuEVoJqXQhXsVmcfi1qzrzNbS2Tb7MWI nSpnX9tNWmH3CqH5dJY+Z8lirqLmZtgQ3Fl6UzTT63qaeWEg7Ktn8HEobxrC vp+M6GD506osRp7mkb1elKM5n1yFbD6u59Kp2GHcLjzD7WSw59/tJBxRZtLw ynAsowgOujmuWaJpEOdSTkQQOyY5XJh0c+NyAF6p6OoJTTc5vJ0WcuVPto0X 4C0nbRUfJi/ab3GqwIKJ8JLmEpghlsr7DaNKzX40ivrz/YW90HFqKxmbrYma VgK/KyJdI62nCXoTU4Rr16nEywadcWLKTsaLEBl4oWP2vXYOglmxcYBHrW7Y vj4BVpNefCf0ZxagCuBJbaFNO2aLFYKJhzAgeOQhAKYakIzmkJBTIEbNc/5e ENuCPaCTPWmJvMvvQRAPYtqf/EXE0XtyW8HP030uOg4o4Vtpp1m076d/d0ZS LmO6R3Wc3bKpocOuvhrBLtEa3KMVFSWAZtGnqRR1WM80xWFUI5Qbaqa6PTnV PMlait2blWF81hpeRDymoro/bbAIerW23+HRBu5lDnY00+4mfQjIYqMEFUgI sMxTkQ+wjaEOiqiirXLQUQqKXkFbF5pXme+CbLwz0PenFLoaYglAFkGxaEPo tGZvwnlC81M28PxgGPfAOWkwHqIqCFFHLJarqJNKgtIImFfDB5Vcnqv2jjku VRsWEX2ioKyBGINZeyo4dpBwaG1RygpHCQNlmgtbYxMmX0NIR8xNz66xe6RQ +wQ7TqGSbBJDe0owrBMfCkikABxecXqiOH0E0xwW3OZefqI8zUOvJ9ww+gZH AUDmEj+aZQazl1pkQ6Xdgahkwt2FDn0wWrqDQEhqrWhv3QqOlhXTcEdZBwVa OTqfi8RH7tVxmqgc0DCPq3F65olxSCkj0avnCb3yYTVomXW/BEaL5it+yvyg IwwO2DY9ceAHRGARNFgLrtYp+06do2MjJjPvQeURS8WaNHUpIiHZxkPhsJf0 94Kr5h7rXkXckqRh17qtQSqPWtTuhSmS/swSXB/XBjuDE3FnfYfqr0L1ipPo UST8lotuiauO9leNYJYD5cO3lhMNcoQ8vXjg4Bi1ozSFw9yK2iE4Hl7FaI2m /rjPpuBX/Y5tOMdWDu54XLbTR/uouwcXCFLHC25PdZPKJepKBRMIhLUrXN6B eitTDnIJtDLlOHAK7NvVjY1TXcO/bG5eZR7THoY2PD8XYrJJ0f6w9a26Ilwp WFu/XKsQkFODm8xZdzXd4QGYwPrmCiZbY9Qyb4+76Hs2YD9J87ADNzJh4BaF YCM4pG0jpRpFMuSmMbXa9AZjgovR9pmbg83pVdcxPZJWAP/hrUtRzymHrIKJ 8rlkFK2SQfhsOBvjjk7Dt+lKYY80L9cjB6kytD6oAVK5S+JhJn6JkDRkpmEP W2wmZ47TGioJq8HV0kIJjMN0464Uhq0HTwEaRNkUrlyt2bK8RTgXAk382lor nMg53JfMRK6eC89dzQ6OUEA/6c8Mo61udNPMs6YrMZ4F12s4Y/54zVNbFuDs OB3e46EFqeMtemLHSQe4L1jEP8F8d3LOCYrzhHquuK1ixHgLcpwWo46hWGfl J+ILQzzwz+MTlum0AVC3SP47DhqYWcNTCHQE2T5gm+WQoQ4EYmTQ2FEe9hGU dOvKqtDMj0NYcYaNAIBZiFrTbtzhUSC5s09N3QHc7gAFOBQwZnD7OWllZe1u O/tAU/kkRf9Z1wgIYFJWD99vKs3oUVvJl7ZxSIYQE5Wy7gUQMj9v6edZROXw AkuVmKngSF4jrf9NC6ZMsM/KRHMy4NrFMV5NXdPIOLgmt4YkvBzaY4Ircor0 1aHWVpvm+XErr8TmCwMLYKoY/AZaWJ+rxBKoR6ay6uIIuYrduAl/Xnst214r 2x692qc1iJ3rKb6JrTOPc09blQI2U90vfuAjElea00MkCmREQ1S+1zZsQEAN j4dwkIBkt1FEsRAlrUcrXSwuDbpaqM7vhANgx3A3z1wKFmqNQIIDNsyPZm3O XFQtUwmCMVvaPbj6uvMGCVuySgxSMJ0nOowAvzAMweYuSxBAedAjdoBPwrSe aQzGK7sRSdH6EbGSNA1Lp6HDMB4uhxupQaL2AMroizklItRuyatW7pUf7Qxf e6S3BKjBR9rWwIz/YUMyoYM2Bm4ILhB6BnCBNUXlRQqBeJEWHDLXzNaW1g3J NcfBXPsRil/UtuoTgSPcoOGQ96S7TVr5lz52AkDqdHTEDJYFsAXoAVvGy0Pe lBW9tPSsVXH2IhdVIGJG6gWbqGjDPP5TJB5F3aCJ4V3S8TKUm5/RYBK5K8vn djnj5KrcEhHVWN/RonOJVhi2s4hNMg3jgrKneLtPDn9AMbj7Tktv9gUqvgyi J8qhbKNBk+5rhqMpHmJhDsjsuL2NLeRKtRy+WA2s1uQM+Jry/dsylInday+w M9yDzv9OyY/YLpB30KwfbqhgO30AeHQtG3kQtmy/DdtnrbNrgkr7XgTjs2UU H8y7sObvFduwtFh4aLA97h7pFFr8md23fTfOHaFeciPKn1YrqzvseU0G5cxp dU8KmHEi61lOkz9bEPMKco1gAJ3dpICFZnkIMuhZrjxj1gprBU99qZWTuUj8 biT6qypBfdQbjPZOTAm9XMLfJS226SdBZK3AQJc3kxWjmiFCrX2kdEVqE1mq 4uRGmQj6+Ijj5zPnoh+5kPooMtFCQIFvJN8zEsFsoiFXqGgNSdsQBqfPPyIm KSdk/myhUrwCImI6Wnb2cbV+0okgLAUxEhM3jjvlHeSN8uzXwHptwRmt4XrJ uvHwJEUVFTnLv83a7TNan33H95NI7+JxD2MEGCsDlLUqtMDxfIlwVYQ0z8px R7Jm0zZghxDy9FioeyByj2YllHBtY2SLOMXFZ8X+aqBgCKK+CyGLEeD50MQp 8bvw7TRqYeOUJAXwDT3vWXsOyZg2pm2DYOcqDcJ3sZ4NpqlB+AYNwic1CN+w welNFca3rwQkVzam4xRYc3i4OWE1D72Z0pD5mBZ2iqyyrebjNEq2MMg+BT/I eoCIKNvQT8NkNwUBBcYxEuu6CronSxDgEZKqcQrSQBB2GQZhYEaCIFOyK1fC fYVVtbJ+d9RVRBRZFP3+oDVRNpPT6HkXSUAEL1raeVbCgqhUNvEqUksDwIND ELXXgscgO1Q4xKAhCF/CWI630eAh6XaCG8vsFGTWo9EIync3FpugVgMyzhS5 FG6ZMxMsw4uV5kpFZs0tzdZmkUl1UG8AnN+d7Y+W6Ux7bKxbFBtZ6iA4sWcu yJ0wLX/WC3Q2Z/wRBphYWmgUOfgP0sN9caSUsnfAUYzHVzaXZho92E1C1vJk 0Y5TuRHCRPHDiQAESuLwQ9wQUU0YNdRlzcDrFoJLRN2titxpUHXfsWIhbM+O NsG86OvB8SzeKbhGWKQjq8OCoP27pI1Zx7sT9kR+k9c2oMEDDroVN+0/OloQ lDV1uzLCc+OJwUsywxNvj30vBissl/YflQeH68SlslIJxQ172B6PfB0HUlkY nGFrgkbK2il34qF51+XUI8AAIUwY8qTPcsLdZAhRLgBqMGqUU5US3ECzWbWa l63TzoGzdgDY+G4Rdu+cftzO8NFRjHKLA3xOxOnk4rgfwLIO07bhC2rXEBcd 6yenkv5WN26PjmGOdcmgLZY2V69cdduEAWy4G+sxbqhAiJ3rXHWGYoAlPLDr 1VPnuq6LvOGGSTKqXQnWbUeuFZ8GYC9WuyyvB9oabYc5XZWKeUdImWQ4ZAYg lgRCvkqdrB1DZtNcblWXWILNn2a2KdgjrKC1HKwF59H5SBKRjUep6QquS7Ul U+QgiOKx0UEjmOwhqY1Y3BBhvf1kZJUn5Y2F+XUL/tnIlbnoLxk872V2zZ6l mtcLxs888FDTgTjhDRdyURbG63E1le3PJFcyZ0nnYYTDKKqpqQna6h7oqjlo C333jr+nscYfWNKZUIC1ARVaK9zoYsKFdeSEI3T1zPTHOq4dZ7lD5zw2AYh7 /nD7+xgiofy53R73rIF0QSL5SeZr+4TALtKm91mRjv2RMbU154r9lcIiBZsO OMkQVknPxl6VjB+9mJxJzcgBr7e7YxCvuQinUEetSQ/ML0xZzc5C1VxgU3wI rYsYAjrKhDMV10fz5rgOx41fqW9zto9RDzNcLpte6ySGakvjlqFnKONVJdiF rDYJRKX2Qg45V37yVee1EFwMTvzAeOBXzQ5mTifoC6FcuVLbJvd9bXlMIlwy wH7o8iMPB4hOQRyF0dPSdjjg4BJoYAC/o0fQ+oQ6mb53etX8A4Ed2KNw+j58 0h3ZB/fjg233oIQPnhgn9lFpugSP7r7ZXLKlrk7To8X62vQUHw8YxLivhyEG 8mX70HI99p715oLww22QjJ4Uw6NkFoVKuApoOTNIutarFBXpaAR1BvvxPJZ7 4UCftKiohDnyOWRg6m3gGz/gFymxMac5DJyuuK09ivIEsjjE3aAbkJAm1GPH joCCnoIPYvnEKvCHLC6BgdauJXG/PH3L8BiGYaxMOxUAGDtjx7CuxMtymFUv sCrGfSwuZ7ix7ekJ2JDWWccSHlKUHvlib5Dp6YA18vRqzV81N8wafLUNn+Di NR5i2RtqVbYFDMZ0u4J2kfnHItaikLfaAy3KHTOhoAJNC4UcM9uLNwDseie4 KhfsVfImVS7TNhKYDr/GlxlddlcBKzBCXiP6djdOLTloAxd6wTc8iyzpvWql AhqIlXmuMrkyi0yku1lEerMhzSgvSa5r6fyMA1qwbnsswK+eKpIJqRNsAyLE Ndhz6XRy2fQEwKKxJkluEDOOMj9SNnVwskDm3o0B46ZkllJh2z/laz6KeoME ImyjADHupIIT4s4pQ6JSBIO6QAf0ctbjhAwJsxV7OVAxqcPx466+OYzT3smh OpDVm74chzoQ5t+b8QM2v2VV0+1j8GQ4c/GBmXS0B4yAGT9EbDFlu2B4gAY5 GPY1cpBFcS+QkZDihooaMXbEMO1hF63TUFjpmmKKhCtdkjpyR0SwT9Ca+VsN Zu97dXnj8fTxS5vHT1Reff/sNqF7h3EjKrReVIrPXWCbmvFL6ZV5DAMZjtNR 0iNt7NXsCK9WOTgdKGCnzUELyWalw+Iyttv0LoOqTAelZ+paGQKaqYLqFrW2 GNiAQpZQK5AN2LQP74ABxWwmI4p1T07wYjo5W65V3jxrLW/N2QLdkdks0DuD ZI60whrxQ4YU7Azt9NqGWIC4oWNxzJsSbTeMs4vUWNe/0t1m4U0c8De+iR9/ fJqewTd5NpRnQ/uoL4/69tG4WW8uw0VOX/TjFXm8Mm23zb8+Zx9//Nb0rceH tx7v36KW6GNldjtT+pRZnYn3rdhFmcGbQ8QTVhevhRjnlGSot/YwmWGAQQly aoAdzNfMgr4u2embiy+Nt6fTTBZlQR3uJLo2DH/S73TRMqQVjxCb6OOIFjnD GxgI3jxKB+bukkhEhmRBczKQb9gtAwIqsibC6gB1MCgRD+XcA6vmzuh2LNCT MC26iZm/ALkBIt4Nhx02JxjFrVg0ju5U69UlJkBwQzVQrXvm3RZ7gHRNl0kd ilDP2azQvXNG/shruQ7zyEZp3U9h9GmNnzi/WT8qsEEMbsShQ2tiR4HhVyx7 yDTOBl9iZRmI0AuG+ubjW6kxIZQrqvHbYcpbpJkvjGU3fTru1j3TQnypdRjE HGbTIXSm0zLkr2CFVEvGu3tuMZy7cp7ILF25Mji+Pl2iVxgtXEgwXsNq5mQK MVbVUGsxq/mWbG2ZlVDEIvV1fJ2aJ9N/TrnFZW2fjD+qCjU4txeeBtUxC0c4 WFT5UsoAL1XWmnI3htL08cf75fKVK6P1csmiFPOlVKmsr6PYdXp6VchJKFep mBqyQl44RbUAh+tMA1K2R9PRpH5kbSd1svZ4H6ciYGeafrzvbayKv4bKuMTc MW94JLVGSrSWjG3phhpw8labzg8Mp7a2DNUu5gyWEzJVmRjkzcoOzgE2eOA4 GSenrbEJs6sUmB4sH0Pxro4hkRWYuhuUPIhqeQxVk+YqincCxArU5q1bT96u PGnWFTgSHlUwfds84DG5kwDnwuxC1Szc+vS0+bi2TjpdK2rGY1s1S80LUDJn rT9aV1IzXHRTMxshedoc7tu0TZlTYe5gpp2vDNbcsEbmgnGEN7BucCuBKjna tcxxObcEgHFADwUI5cp0NfBYwNuGukCrbwVIUc0uAH0ReKHQ5tbvQTGa+TsF tivHINOIdagyKGbwvxOZCVBcIM8rGx4u7iJZhOOS1Ck3on6Mcm649cwFQOUy aN+GBFwPJi+NoDqah5u/1bqV0QhbmgJGOw9Ask+Wr6XWcjrvMCih709J5wrC 6HL4mOQC4nAwQXaPJffR24uNJ9y6yldIHteuSAPO8kMYTS7iDfv8+QtTRcoN yxKrYZoDLIFV/WCuOhRIxqECqV1qjKndMVj+nD9P/A4YgZpm2dg+gCQVKV3y LvghBWPQSaLHbkxKD/CY78lhUBWGfsP1gIBeVPehqAs9ORY+sXFn3S4VeXgJ HZ7n02VhxY23aNFlX07wrtE+o1NckfWEYXWG6NFPbJGb5gGan158cyL0sMmE irrADuyFpg80WQ4sd2VDDCBAEYDfBXVccRhzI2cloe8wFYRxA1CEdZFRNmpg mMkh8CjEbT4EXsb5kbGNip13hUOV5lxeK/nzirnSs+uZW2uBztxCl69Uss31 xiNMukiGApOa8ixYBglaosDc4XMYoXUcfE134q0RfkmG9AkunPhq3KeXkyxX KCwh2oqwJgFDpOm9O+TOOTc9b9es/B074bUnVUluz+AGx9GRmpxGjvSye0Yz E/2+ZypWAQ4hGiGkb9QtuBTBgUOIGcMa2R9IUp2md7ZBlCYIVh1IAtwHHOwn f+2LpugtuLcleumLV+HMTbSJ15GhyEDToW3kYAllegDv6CIrGpygx8iBidLk 0tU/Rvc75GpMszfJQQANeiQEDF4SBpNFkO4oUv63LCHhzAcqqx+M+3WXzp9j PslQmG0VaTIzelSU6qejBOuu54s6Ra4tekkE4pNWAEXik5fh5COngb+NwUEB 76AdKAOX54hlnR3n/SZMPgmXoWo3CQFXTbGFFwToNJCMFjZ9U60Ncq2boxlO ztELwQcU/ZZ7hsbvguPFmRvo856Mt3cC0ql3p9j0wEBHzHRXbpixaDHCftLf 6yXgB6euYiprR4Y0AsnPqWPx5KxSfolrXzCOhpiflITq4BkfcHpEXyBnECTJ Avo4Ys4gNAYRTYe8VsxaDzuQztysk2lC/OA4K4/K72hIEFlCM94nxsDgGBIE nMXBYwwEK5DTeFtllYzAQpByfoic0c6fBZDliqKNlAVCyHtlu5ryjM1Yepkx szQIkF7Uwl5HAIv7mXbLbdDQhkZAeQW2d+1N3XbEOSCHu579e2b+rqQgT2zP DrrjtDbob38y+qibv8XFefhsLC3U9Sf+Neaad5n/5pqNxlJ9afGuemNhsd64 K6h/MgaT/RtDhOsguCs1n60IckrGheUOev+X9O9LL5x77WdOfR4cqM88+9Dp i+bzM+C/F8LLv/WB8p+Zj6NnT5+8fPM57eUvuutF2/e/5sfWyhtf9ZKNz/m0 L3n0E5819Zru8+66a+Zo+NUf/chrngeVzp45d/q9D1x9x1/cnJ79O/yfnP+t 2HCzf0Hnf35uMXv+F+bnnz3/n4q/gvP/EvjvhZ9u/n3VRz8Rmo/fovP/T77q iy5++nNe+q4/qTz5ru4vBr/6/Z/+y6/Y+tX117z3tz7jm1Z/9AfeP/ehP3vr 77z3nR//+Md/4I/+aPjGe05+5HNf/MaZPz595K1f+IV/+L/+12f+0Uc/+jlv +8CXlr/swktf/f63/e0XvOAFy/fd97yV1dWp3/zTP/2lCy/5mv96/t6vvOd3 P+OXXvbN3be+441/8t9+829/7Lfv/Tcv/5FfOPPYv3jpm+e/b/c5X3D7x3/6 J57z6d//5j//us/9+T/5d9/+/i98zmc+98u/M/6vn/aP/uAb6rMPzf7uax6s /O7ptzxx/Cs/eu3dX73x/G+59OjC+9/24p/6Ly/f+YZ/MPuRH03e9HePvPbe h7fSW2//9i/8th/6oSf/3X/90J9+aO7V//zRLzx+6X2/e/Xkg/8eVuX/HBwm 558ENbV2mj7zfRx0/usL5v5vLpn/zy8tNhvm/C82nj3/n5q/2WMkwgT8j3LD PrlOd8EDeGsEQer612vBsdlnSe7/T/7J+e8k7VGSdNPatWceAex//pvm0q+b +3+pMddoNOrzdTj/zcWFZ8//p+Jv9thUcCxQuw8/3+r+zE94cmmwE/dvasOV MTqZiAEvyCZNI2Ntn4IVVyEI5jDe3hmtBqfka9Cs15dmmvXGMoeekfZHUdgD +4soOPno5YfOX7xUwzZAXNlPo9XggUun6fXDZ0+dOXfpjETdCONuyj3OTk3N HsOu06hLjmYuYgpbuEEtJ4rASveMKTCmdT0B42VpqRdeF4Uf5uDqJrtWutUl Oz/nz8ghPqFeyAoUytgXD6PWeJukRx34uh0Np1A7TLlU0cMjIeXfUf5e41ok HvFiSJe6yXapGpSwKfgS97cS+NwNh334RMkPfIFww8MRlo2HbGsFX2/2uvBw e5iMB/bLmX4HvoNRuHzyozYYEOKzYdiOpJ3BMIG7A57zVyiOcuLMtCRweKEx P4YSkwB5x4/HFPvFbwFFzRgLPCO8NM3e9rceUtEGO3ld2XjY7US4i2yOjdVI lldzL1XzbEzJUil6/+jFs2D0kvQNTJkC1iJk9vHjs9vVYDoA85jba4caTtTf Zzj8cj2gL7pf1zrd39KqaDIpejbGKTANwVezeGikRCojqCkeAFaU+Mi4O4oH XRstHsZ7nSLyYSZmDKRehaox51oKu7sQH0YcLShajOlBh0FzZskgzMSDaie5 HY3wywU3PrX4bOalhI4pyRutXyBHT4Nagn9qYIKBOIiCxYg9P3YO2vZaOobo OmUwlupEN89vladPoHVTo1IDRc6oPH2vy32UCXtfBL00rYLwjmiEgDkSsQik Q+MO1qddJmoXAjILiGVTeaO+qcqJ9qKwZENKwoJxeEjOuWaFqzaqMYWRIcNn qgU2PPlygGsowwJJYnPhWxWg7xjs3kUMb92jSNmAbpDXnoAxi2a9xcELOSM2 BC81J2UAImuyc0xd9FRqC+N7IarwQGirX7P9XqacjhkLwkzkQHtWbLVyHz0c w07n7CjqecaF8MaPwzDnKxdvYNwNW+wNzsmOwS4BoDOlapDGajcangpTcJIR 2FNxujmIrqkAyUnRs5nmSKOAuCn90TnztQIupBiHUUVFzGqrYS3XvCdxerZ/ 6Q2vteCDzVYgfG4KDg6lVtKB+B83DA6DEDHxdp/iMJTMaNNyybwoZdL6cot+ UlPcRHUe2XeBdvXcpXJJonTu7tZ25zA4pyEI6rPQPlwvUF93lMu0ekAXZqSZ FqhCTUeotN9VP1NeadRqdU7txN1OOdMRgBnsAxwfwSZm26pkNcgRcipqAJn9 M5sPV/IDGImnDL1V9y+iZnK4oYAGT49FZ4shWDVvLxnyBVxasgO1cMyAy83W qwDMh4EAALZWKwELSFxKg+UfeCC5Wfa2hJArOvk+VVAZInDaRo8E2GDtZg20 cWYGVtkLg6nd1L1jwb3ignu5grtxZ7RTXBhf5SrsRIBXimvQu1yVNBqdHBl0 2RqPovI0wue0xl3ZtSNYOb/FOC8LP+6rrigojrC/3jP4K1Gl0mq2tWwSv5Jh msymmoIw9NuV/CHS8ZVcTm8P7wBOMZMdgQ0WEet0gEyvYUmhM8bzaM6A42rD mYRhpYUaxEAhdk5FKYjdGtWo9AO3+aKXQoEkaPFuf9SH4xByPe7bG/VURDXY rdBkLzfJ6yRFgHCgzahwiknvFW1GZd/7GW5XMcDPqOZhcLzGzMVYslKCylvi z/BNhvFDZmbLnG9gaFB6dBNzTppLWW2ztEaTEoolzIXuHluDzDFEKR6H/k2p soH3rOtKe2eYmDOxETw+u1neeHy3tnm8MluDtJ/Y3K1bvNGz5d2odT0eHaYk mmlUyidWa8fYdu/WYar10tgQFvuVMTOS277k+MZSxQAB3vKmDcpdQ52fCIY3 VqW9W4Utbmz6Np0C+rziq7RSG0EjwGDhpZIcYJ6YLdDkAvWSMrhZc9vFDVry 13+84W9quR/eiLfBgKw2Nm9PbhPAUtlNa9R529KLl5Ax0u4wZGohXENOpDA7 BWBwWj9GjyJgEvqGilzN4wM8uAZAHySQPdlv7yTDB8bbchnhe3uELyHL8BgE 8PAKQOtnYQ8vY45UfgWLVUWzGJhPAHxRY7kvpwWfzJp/L188ee7Swycvnz1/ 7pIZIuVuu/DwoxdPPnzlzBsvXNTD7qtEKn0OIHwC/SAbawFWfPj8qZMPnwHX 1XH/ej/ZBScoMuwwSACTmoMxUV9+kMsZGY5RPgHlxOUsyKaskWsabkEgyRaG xMB8a06AghZvZYi+4e1BjTsDNkP6VXPyXXKRKRqG/ZRciLJN6cXaoJrK5ZPZ QF2/iB+0B0N74PKjSW2knPTWLLd6tap+sPUebXm/aKKmAbD1Ad+A8TDsQsyD pzJrbuZpzLsMsAO5lU8E0poZKI3KWw01O39EBJ8AngYm1bzNxXOZ66DloZq+ YbvDbmI3OpvejF/XehArdDtKZch4wLwFYL4zW0HF8MA6+ghlvA2m+2SMSuGj 0UpeWqNFuAKuWeSZrs85Hy7XN/pzRGv5k27WQfyiHceKwr2dCK2mQsQ05lH/ empRgal1iiqdkToFOOue8nQnvrERdzaD+4NVam8V41JOVyYQIVjpvpDoxfUS 1YG+S/c/Pq7XH1i8bza8f7oi/jAQEKQ8vWNQIqzT3dbiL+5kioziEaZlvlKe vhANDb42TZK1qcEk0It5EE1XXC3kmi4nZKrlu9rAtEYwq/+9ZoFHCBPtHGoe GTjYTYbXOX5QaOmidDQexB1DXFGZNIpWA8lYZ2gmSlSnE9alO8nuFfOm1t6O IUPF4vxCfWnBgk3B/VUEN4Ap8mKwnTDdATLjHrmKpWc5gCxmTSlsRzIeFW1M UCBgg5UHzynxKIfFCRr1omVyoiGMporXLAXKcsmM2Fke5JX8FQ6KXYSiS7po FZg5CpGUv6dAxFhWAjXwlIByZarhKAFAndln5gJgAd7s4+nxWXB/0FmbsS0b 0VgLiUCyAoPBc12DX9OezOcoPMrVDFQ9v87tO9u5e+i44fgmsEzUly9JI/ts jxiH/OxSBG4dxfhV8jAgB3pgD7TUnaFDbY46wNB66ZqhASlZy6p/DU1bL7QA uu5EHoVWuh+jjpSnHwKbVXoVPEIxlshhFRDGfbOD+6d1NPmaPd1mdHcTMBrO fLqi2cIMYQfkJdGkvRDdoMHDc5Rsb4NpMHKxDsv71OIkGKXKKPE2w4h72zV+ Mg0yOchpNsGfIR22sQ6iphphOPPM7QYFfuhjHCa/WGz2TOQ5S3qPRkODemam MfqDqVjhsZQ9MDWdSOWZFY4a2Iv7ZDqqVjg/tGqg6tbpF4eJXsF9EgNUNwkl jr7DFpexRTUwQd9g3wJH0JzhcA+uDHkFkzt9/tSjj5w5dxlpkCvnLyApUjt1 /uGHT164dObK2XOnz7xRnxjZPt6ryaBToPjZERdCRoS9cHg9DcLtEHN4Cbrz gH0CneCgN6j5p8ts9Ja5Ps8bpDBXr7srGCVy3iGuDTH6NQmU8+c7Mx2rDQU8 HbbSpDseRXbU8PbRiw/r0Q6jLkbyMI8zngbFS27KXbl4/vxl2MRZgEjVQMF4 svGspDSMzw7LFDpF7zOD8y8NjLqev+fgRd/KirUyCd7YK2F2VlaZ8O3+09PV CpEyXilAoOA5q9XUASONkwotfltdabAvrHFi5/3ZTLAkGjUeHYiSbSrUzN4T ygJ12Cypw6pUkJ2ZZiQCdVXY7fP910d7ENUL/A3SQviUtaxAYKjxwGG06AY8 9dAaOG/cEOEvqVvcXngva6NwW8vuDedKbC4LICJyeIj7cr7geGB4HZIuqgXO dwqxWacvn3nj5ZMXz5xEh4YJZc6eu/Do5f0KXDrz8JlTl6c10pBkVjh9WJNT IAr17mHM/TO3tAqzAhss9YphbxjdeAgoL7w34KhvGJhfL8HzEtDWEFmByWJP amzz8WJ1v1f4Y2rCJ+/WbX9rmeJFYfXp73ZuOis4HbT+yM0HVBFF84Hnh5iP VD/0fKTCU5lPRrwt3ikgYp0NnhhDiuEQ0oWTCEvxyVMThSamrj4nBjw7e9mb 368IZw8Ovun+6dr/WP+PvW3kRj8ZFqD723816vMLc1n7r/nFZ+0/PyV/jhAw 5EO3GzyJSoJt5Gdn2kk3Ga4Gd2+Zv3bbwLkq7ZU0ZaIIyqz5hWptU0xama8v 11fqa+Zk9EfkPr8axKMQ0irdNrc5xJHBIAbmvtZNRMMh9IVJTVeDxsAw1wlk HLv7wQcBfKguxsHP1ryuOq/Xl+pN6Xw3IoO0FkRcx/rmHgNeNNtColpYxD8q fh4dOvM9Gsx+x/OtPWTY81bY38411nsKjaEFD4hkcq0Ncqvh17wAudqSdr7e 1lMYBjf2IFgVZxtsPIX2LhkypaCptKCpYvitb2WmewniuITdbJPbHdXkybqD MIz4F7drp9GXOwcp25GpN2kWUvdMb7CTqzhUHWqQtpWKQHt7x9vNupn7RNiW hh4yF0ucB7Pt2GvqZG4AZ9EQoWDK+nTM4Z9f0XAeEBsuW00DYntxoVNfOXDo F4ZJb5BvKZU1n1zz0miYFMx5rMawfLjluzRu7UxYwZG3gvPzp0/7VS+DwSSm w8hiqPYdo6jaKYkDnm2rc+dtnY7a3ZDdo7PN9e+8OSDJMZxcrrFJyEdqXkij cSfJVRve+RguUnC7HLRe15u0Um9aMJeKSLZnKmkM3DRAssB1HubYhpTZIVvL x0pL9TBTix3wM7X64YRqsKo1axmSq9aasLRY7YFxbO6D3Ob2PbiLludbCxMX FttB0UCuFe96rIedzoKuMgFO+xpOF/Bv/74NkCaFt21fY66OaWduaf+WzlAI /2wz0X4reOYmJDYvOCB9fS/WF5vLS5GqZpOpZGt1vc6aprv9x/wwUJ25Vvp3 uH8TT2Z/lJ3F3P4tXQ7zkHtDtdFqLdY9OHiDxLTK0la7hz/cQm/VHisg0na9 3uGPKoEEu/aYDXGZO9utQx3u2gP549PbOlxVzEWTq7xzuMoPRTdzVePDVT3L sYiz1ZPDVT/fzg06nYScfJxWO7kF/hXZyq3DVX7A3JCjOH9Lpu3D1cfgrJm6 ne7h6p6WIJ65zju5BiaTq9lG8+R02jzkeJJxwZlJo0mDyZ+ZTIMUOjzX4M7h hvMQRDQrmI0GSKjcOfzinOX4krk2b+bow8L65zEpR7ayphiacwtzy8uFlTFW e65y43CLUcyMpPraX2gsrTSKu76012vlZ92aRCHpa3wCmbTVO8xNVHsk3I5z O3ijfRjcXXz/39g+VN3XdpNWntG6ER+q8lmJF5it3jtU9cI5x907QqO1h4mD +IsW1XxS/kT+Nx58sqI/HOz/PdeYy8Z/aM7PPSv/+1T8TYz/ALFcvu/Plv6r +fhKjv/w7u/7tne+5mXv/NboD773+W8J7vn2L//ovd955B8v/6/VX7o3WH39 YPfL+7e/8Ju//p+ef/HH//TzX/zu93zgua+871//x9WjR//s3U9+6Wtf87YP fPeJf1H6qX/4H37nF1545IUfvfThf//k9u/f958/+Pe+POg+8gW737X367d+ +8T3TdWPDJ5YfuLqB4684Gvv+p7B57/wFx7+vJnp/+uzX/ZvLz3w8peeO/ln v7F7+c8+9MKf+1fv/Ke3Hv2MN8AU/s8J1vBJ+JPzb5Xln4Q+nkL8p6WFZ+M/ fUr+nlr8p4/99aPff+/zXvJdH//rL33bL5mim/9tq9n//D8/B5WePY5/mf7k /JOe/JMTAmL/87/YWDCHPaP/W1p6Nv7Dp+RvlkMl6N2/MsoEgbiTSBDkVNDt zqBhNDX8FxkMYgp4gqQ/Yy44DNtvM1K/7hJ4Lhn4j3o9Q+RD2tMtDoOjTFKP zQbirHIBHKCGwSWqYJ1R+Hc2nuoUm+qNokGzC4nvJPFNSAF2VoNpzOZNpufy CI2QOQVRvx2bJxBHnp+E9CR0T+K3gE502nzwg1YXSrS6tkoXH4Rd2+ioS62O 5An95l/JOMXf5tN2gQP2epEnbgIgnPMfmDn3dM/gwR2lKbRzQwoZOOFn5psb AT9zYwgBvvzG6IFrCl3Z/Ll3k214YD78vD+wJXPelmDST2iu7SZ4Ax64/t8S ef23uf+2fYDbZ3+b+bjqPB9/FGDBWdp4cxjFyXiztOZsTcALB+Jd9MP+iMve wLJYdC9b9kayG3W53CnwW4CMGtzu3uYxKq3bNEfmiTFAFVd6Azj5YiUayzHp QBp3FbhGb3tYhxG9GfOEnMLsICfg6xvgpxqe/jOtbZzafMOpWq0GB6x3f11a i55oTG4Nfpbll3lxj50Qtrbxhk1sbb3hxrZ/a0VjlNbU6KS99MoNU6CowRsT JqpXDgzQDHqAhUNTaviBImyHLILyrjZBhBLOki8dgzzV/UYXEElggpHNDQrd pQZ32SMQTKJ2xWbvvmAu4xi0q9wph8qgcRg19Y85/WOe63D30JkzvG0oE1pb wCzYXsm6F8B06U1tlDwKAcrJmNysom2ooTIKGZQ6CBohWyyCv+eby7XjJyrl NL0VV6L0nlmxZmyqlxtvTjcr+M6OZxhR6sbdih7LrsrcWC3d07inKT7k1lHZ tHxQzaar6o+7lRt3FHWKhxx1boFjnLzMDNlPZQBRRMxL9AXdtWZw2A14PnHu KDibnsm2tLeF4UG0jRyNsCadF69OKeNycHvyOhUNt5kdL8A3gAOMxs2h6U/C HLrMHJqSgjPqeXOAAbsjoxa4HI5utbq34rdU9PwMXPs9lcqCKrvpWzYrjz/e uEfHjTCgnyn/ZsECNxSe3b25t3lPNjRGAQjZJYa6UcmVV+s5l1/PCZu1/3Zp o0XV/PwhxyS77YN2Owfae08Ddoth4SBQ0JCQgwOYRFxaKxp8M49OmBS7xR9A cd0CIusW0FUGfMwvQz/dQqLpliGUbiF5dItJolvybzK8heTOLaZxbjFdc4tp mVtIv9xCouUWESq3gDh5Oue+aO3otqCnzYkrOhFDTF5SS8RuUBebhQs8l19g JKxuITV1C4moW0g53QJyCVbpFizPX6plmDtwGeYL4KwLYBUBgJl/hmb6t0A7 cQuiAJg3o1toN34L/4H/kvEtACdYO1gtA0YAWgCVleJ7JL01Moud9J/ppSxY tMadLJpziXmm7gyzDZltbR44xOahxuht4kL+Dv9ULm1+VoZIVm+zt9hhbqXc dkHch8zqYMgpdwnRih2wr7RI3a4PmcUz89cOeisEhtxlN/mic/sGQQ84Z5U5 NGE3eBOagoK31d4dEajK2zFLoNLghI5Gy/+pKRfNAlO0SsgYiC0JZl6cIlWk BRBxcsicJ6Qok6yuJDixmZG1s9jWeIi67tFuFF4nrzHK9ARpgUNMhQg9UoOX VVCHYBRehzSwMiQMzxdsgJADvJmqAbpFV9lTvRp0orRtPrD1zSm7qjqkIOwr vsesr+CBhb88by8MOOc7enE8uXmJI4BeWdQDBYWjBJ6pFR9RpAlIQtLngHGm tPkC6l3071wNGg3OWpsMbXV2GwZnpqCTjMBqlROo4HMOPQdtU3MXzEsDK9zi Ijd4stOJ0YMM5wYO4uAtynHsMLDiMDabO9rz2+UmzbvV4Mn6ahA0FqoEm5gP iBK/xJDgG+ziLlJeNkWGmQqmUkEdar6oQnM1mFm4Xc1WGPcLujFFINV4h3yj vGlwbktevR5F5au5+Zym9LirQb3q7doWur1DNQCkqYA+V2HixcXAARmKmc9V g2RBHAJ/FK7OEEZgwoPe2IX+eZlQjMwjozUGRm1aWawGjeU6/LNk/llpVIMm 7EFz3vxcml+pBsvL5udKfQ7+WYJ/zLOVOahRb8ybfxfnl1Woq8aS+QktrkAb jUVsaQ7+XYamF5rwZLHewH+hzGKjif9Cn4sLUHKp3lQNmp9QZakJhZfmluDf edN7c3kBvi8vLuC/ptPmSgOerzTx+zz+uwgdrSw1dIMrMJ65OkzL/GuanWs0 4EmjaaYz18TvzcYS/DvfgH8XmvDvCpSfwydz8wuqwbm5RWhkAcY5twBTnluc g0aWYFJzS02osjQHz5fm5/HfZfh3oY7/4vNFPcK5JViruRVYmfnmnGl8fg62 Y34Rns8vwkjMv/BkaR6+Ly3jvytQchnWdn65OacanF+GigtLi6bHhRUosLAC 1RfnYLJmOU315TpM3/y7iP8uw7+wy8sNWIrlRlNPebkBE1xuQLPL87D4y/Mw BvPvEv4LcDO/Ag0uNAGuQFGBHwsr8LGIwNaAmSjQaSwBlJkPKrvUwLJL1MDS nGnfbBGCV3OBVqUOOw4f8/SBDxdM42ruZncW4fESzHVx3sAKfuD853FY8MG/ VvCj2aQP0+PiQmNeKBB0Ea8G1wy6hxSfVUjbRW8wbIuKU8YHrCi+KWF4RO1c iqPzuuydt93pDfvbdE43YKJLm9VgY2EZBgff4LCu4LdGExZucQW/L8HqLWHZ xnITDiOWwXO0VDdl3OJsLMFUzdJiAYDtJepkaQF2dgkbXF6G/V2m77CnBoKw 8cbCPO5iw2vSbDVs0VxzGQvNLcL2zS3yryVAHAbe8Rfih4aBGfy1AMfF/Euz WMApLUA93fgiwoYBXCxk9hEx0AJNHE5UY4kWx3wu4TrM0S8AycbSSp1+reC6 1Jf8xpfnERHyWFdgpRsr8gtHvrKMzTXrAJTNOi2c+QRkU59v0K/5OfzlNw5m y/B4iRtYArxVl+aW6dcS/wJcN1enX3OLgCDnaFbmE7DhHNTTjc9hAwZlYKH5 OlQxx5p+NRAXN6kBA9bwa26Rfs0jrp+XX1hyoe43Pr9MCJybW4F5zK80+dc8 oPU6blpzoUFInma1APjD/Mu/5mHkC9llWVjABnh6C0vYwJL8WsJfuAPmjoBV NtcN/VrAG2ORZry4hLfIUmZZFrGBRR7rEo5giRtAaGkaKKFfi3i/8H4sLWNJ gvnmch3vm2ZmWZbxSlqeq1MhwIjmXxr58hLMapng3HziZcQbugLYyvzLv3CR VmAHdOMrOL2VBS6Eu86gaFAX/uJlWcGLVQBzBTCr+RdHPlcHQJirN/1lMQ/w 7qNjM1cHnGygDcdqbgS4lszx5V9wYTUWqLkGgKL5d4l+LWHJzJqb049VCBTN JzRuTgP+asKRmjM3P/1apIt1jn6twLs5wi1zc3D5zc3BMHTjc7Ax5t9lKgSg ODdP4GY+F/EXjXV+Hn/N8y+8Zue5Y3NVwq9lH3GZu3sZb3CqgheXuUxo5It4 fy8SdpxD4DNHkTpeXMJbvUFLtoSkw1LDR1yGDECSgE6h+cRrn9CYIQKaSApQ cwaBwa8lbo4aX6K9WlrGVlYyI1/GfTYXNhZaRkpkeY7msYwky/ISdbUMmM+s G5VcgQM/t8KNrwAdOF9fWfAan2/gXdtYwDWfx103/y7QL7hgzL/8awXf0XEz n/P4a5F/QSvNeqbxZh0f09rNN2FZzH4u0S84oeZfary5Qpc8jtwQRHTX46wM BbKI5JGPW+aBkjS3JlfBA2/+pSpLONYlAtN5XLL5ZTqhhlzCX4SO5/Eozq9k bqL5FcDS8yvUwEK9bmBnoU6guNCAWS00mghuC3ixmn+b9AtO6AJ3vLAMt5T5 17+WDQkzB49pBIZkWwSSjQBzYQVum4UVmscC3ksLfPwX60DcGfJ6gX4BZbbY qPuHyDyYx8fY+CKO1VyrDfqFtE+jye/msAE6/ou49Yu89YtNANPF5pIPiuZm XkDCkqrgCTX/0q/5JtJXRKcYyqqO9FWDfwEJtsAdLwA+X1xYyYx8ETCx+ZcK LSK5tkjwsbi4hL9oyRZxzRcZn5tXMNYlHsYydrzczDS+DATw4koD4dUQjfhr uU6/gAZa5M1eQrS6VKcNXarDXi3V6QwYAsuUXEIc6dFZsOYGB1ADTaBbzL9E mCFkGyocuzIDr8MvgiTDGADVtkiU2BKSJObfDBGH14P5F6dubisk4ev8q4Fk PUGEAfMm/CLEZYh6Iu2JtGvAkpl/fXxuHizjYy4EiHSZIWK5sYRsABGbhh0A sp9PqPlcxF/0bg6HMZfBiubSBBZjjuioZeSulhlnL88jDTq/MM+/FvEXNTcP oGj+bfIv4kAyI0eOzPxLVRbgRjH/LtKvJv5qUscLcOBX5ggUV+YA+FZ4GCvz 8MvwuvUMmQs2mED+NmkxG2aFkHsxiIF+LxA3wz3Cl2X6vcK/F+h3BlQMQd3E hheJsoAv9JsuH/MFKfwGA4VhjeaxIwRo+I2AbA5y5vTAE6C3m3OEl8wXZOPN xyL/RnLafMzJ7xX8vUANG6pxhXiw+UzDC/PY4wKRVubLCja8sMIVid8zHyv8 ewXLM2Y2X5rI1S1ldrBBpJf5YHq/uUwjXF7mGSzTjFYIbZgvc9jQCjMYzRUk 9OdwZ3XDK8jImDuJzoy59AB/w923QpcN8LtwL/H90GxCw/CxIlcT3lsLmYbN k3m+tKTgCnLxC0TlGBoFhCjmo8k3HohP4LfccigoMB9L85mGl4Cugg8uuIz3 j1mBOv8G8JsHko8uSGRDzAc3PIdH33xkEPY8yT3MB9+65ozCiOaaDa5Il/Jc k84DsMX0mwkCIOfw9+JcpuE5vH7n+FiZL8DCmw9eGkPG4R0+t8IdzdOIzdnm 30hcEEHmNbwAYh1g9JkWWCAOf2GFG14kscCizGCRpAWL8zyQRepoMcOLgKgA p75U5xGgQAI+5vk3NbwkM0IJj/mY46VYmscRr2SO9LzB7dDQPKNh8wXXdL5O cL2wgNeD+aD35guM2HwwzbDQBCiCD598Wliag5O3aDqmi26+Po/ijTrhCjNj vOvm5Xo3EI3iAyaqzJdFkopkwA3kJHUSl8xTwXngBMzHIl2PBtni+2XpCKVV 8MEDWUHaY6Ge4bHNkyZd+4Tz4cani3+Ff+O9YT6IJDRfYCnMB12W5gtgP/OR od4XDWeJL+aJwzZfcAYLSObT72X6zeTH/Ap2NL+ytLlZLMYh8cskKQ4KgUB5 haU24k2OdUx/kNJdv2uod9jPNVQMmSbWgmvBfesoTAqu+V3AHwuLrvkyIvjT 5iXZAPYVDAJvtRooKaYA+ShfLhQRbyg5l0xupqGWJhONH1uatDoY+9DKpzeo bNt8h+hdJ0fluLKZnSlWwX4hFNhMIx+dSlaDUjFQmylYt5ZZIhfrxBzZjZK5 +OuH35yqlQsXDkAaiov3YL/x7ztuHUMzv5VTWl/G4Tox5rvTkNFTjup+heJs rgb9cbcLR+SK6XAcda6QZkE9H4zNrNGcfQyxEmcaNkxdUbi/O4gSy1HTKBTs E/lEJzSSdQkW+4R3cjDiYtwfjEeYvWy99ARENIM4spISBKvrCmgpOIiGBkp7 tBgM5to2h4LwdZOwc5YXyKVTGHZt/L1aeC28WX4SooevBqXXnrlcqkJ4wFX4 pxp0wlHoVtD9wfPLVIVisppa7bC9E63iofULQ0IDCImjRnDtiZs7Q8rlQfuR B34KlyvvDYyZrsYYo75UdFJsGECzTRxm74G9s51yiQzMEUhgMaJhqVKj8Khm htnTc9s/MTqccxqNcguJrWrk8gQ1iBvEgLlOgWCderv8hCQL8SC1gscIltpN L18qoCIybtr92hOE6nIBRnfCNDdmrUSn+O5qsDIEN+1OtBUNv4CPkm3Ew6oT xmnBltdvlAwuwAksHgw14R1RwLyqusEcE+tLIMxMC5Aky9km0HwZwctVgeUz hz7OLG92WOXC55AdLnh1ML+mWuokI47lokNgZy/eoubohrFjdw1BMO3adGaE 5nVag9NStgU93FQ44PsBadse8oGisTCIeeoewuYVc1tj46wySgpCCaoJE00T gyx3YORl82s3NNiWMsQQxMUp4qiogyPBSKweZpsIdWCxjrmgUCMNCQrjIUYI N5h5C6J5SMh9dyLNpCiCJIfEnaFLJ/Xi+6OCmordt9OU6NGXGItsS8xoeFWp eTHgoX3dEmwKNwQRde+/bxY/ctWwR13RAhpFxsZICeslDkoMmZf6UYlDVu8/ goTia1FD467E2KbZl2Yn1aebwS3TYJhsm6Uy60QwBjHyh5G5zWBX2YEHgs9m 5sDn1ebnMTtGex52MYQlb3wVN1DSyOyGKUXJPOofbEFl5YqXFOIJReRR7yoo NO2CRWCqWAZwwRoLIicx2JYZmlJ5IKG8wXIiC61P7IsbFTohOjMZUEh7yM8a lqqlEFKnlsJhBP+m8I+5S0st+Nka49c9888W5GktxVvwTx//GSXwARViKNU3 A4WPBP+BJwkUTqAw1jV35475gLQu+BHRv5DuFT779DHkxyl/7uEHdoMd7uIQ IecTfox2Sptuc9GIzYWsprj5YB4EiTDM8x7lU4AkuUNM6waWkmppxEsKLIjY Z0rH4det+tR7dLPdHXcwZ4p+vNMtKkzZNnMcgitAtjTZqlmcbZop5gUQYnsD wwThbVrKUCuqdSKPqaxvVaYIOdXqPWObJMrCUTUorA/k0kwD7Pf4NZo/lWff /Hjn+D2zKk0UHhMa7XputLCn1+MB5cAoQX8l+w4Sm8R9x58J5aThAGqoy5Dd UMSfTlxd9l8B0x5EFwb7N4GQrWHSC8x5HQH6wUYxfS7Yv+2Ehp7ZTQLgvFK7 dGUM3+YcXsCskDvlh/d7STsDGSoVyk6RIvOfRMSphsnZpAsBnJ1uTKuGsAfb wukZL+izNGf6FGBeyw4GJ5ExNXSDyiTAVA2qc+Pa5LNxKBC0M0z63T08zGYy YA0meFxs6vzZHjXwClASxv20LOOp4jSUwai8oJHgy6xZiA3MklpS6oR9tg4X 9D0uFXJZZoZxzUtBqaKuH8mZjRmxzaV+5uTFUw+tBsIibMMpXxVqQJWHxNnl aaExVgNILeBWdVJ52UksLz/UaAZ4hwq6dAiKMY+iy2tq97AIUAyF5ewL1w3Z dCZbd2DWqSUlGgkW0wRRbzDa07d8N0mujweBucmt2WMegWpEWIhIERfDnUQj AFhqh6OyrkdChToIQrL5JzN/+Vrx8Ua1YBAO8N30+ZuMQLPflP6WmXDVmjlP VR69E3fk14fpC9pKc4zAsFUy2hxuAJehKvevYNIBXDXgBw429JHocm6ElMyO kxvRcAipJ9iwFRMshwbbmhunZy2WhdaxJBoZLdewktvBnICRp6G3W3Fn+BKE h/Mg/NNNlt3L3GL2k13DYwxHzAbQkrX22ALasOhBMhgkaWzIO4wQjSbDBuWE Q/C4qILxWjuifOfUINPZjkVsRV3TxziFdOeQTwHIGMNLDmNzLQUxpYNG23JD RtlD1x3shK1oBH4s3T29nTUYrLNeDatBy4d5iOhv5h+yLbQ9jegKvx601HNY eix+P732RXDI3VshoBL6YZX7JlaZydbxKQIwu2aTblz3gqnCn51GYzObrdP2 Z6e0TxnOVudP8wRQN6tBOTOVEwE8rWfurtsK3CkCgMH+2waO+SEzx2ASnj9y hCwqa7SrAcQn4Go+sueTzNVWDcbPN+vh/rjvgWwG655KDJOshsFHxpddMKSe MwgDMr0qKQZkUuCpwApVkWuhcz7u9ULDsADACqTH+tr2e8ymDI/JUUUKqfwi FnwNFXCWSgHX2Y2z/Kuwr934fp2sYXKCnQfPPnzmyqVHH3zw7Bsp0cm0T1Lj mR3ujHrdoDWOux0IvRDoIZm3fcrpDcMHCgzzxmjhH+ZFo2JCKz8+i3fq47OG YM5KHF2LUsnlSjHXkTzkbEOLnpReHUTbjJkUdjY7PbmnaW/AWlIpS87MfBkz 5BF3r9Lfec0emFdH+j3uVcuSYsdpRZublRqsfxl/gRexUhnkc7Mj1oYce4He tPTpzcht7cFQ9PQn5YEtFpjLKHiKpoDynwBzTXIdzC9pBUMenDD+IBmOtCKt eiVtVwZZdaLTyW6/vDAxiVuQRxseXOW3bvLJfOjkpSuXzj968dSZvNLDOlkW V6VqD58993relOxplPrmbNgcpjkNlfQxXRvdHE08H6LkQL3GwRmlrqTJeNiO 0lm7TwuwT2X+ylfCDHVu8SQMlMdzwpxVcw/Rr0LKVOlPgNwrFZV5amoTtwHQ h1karFMzCHtg7qvoMqaTKaqC+AiqYGIiTFpkf07cAPeXBXeGXkj2RV8v0cWD fXjsU1WY0SJlZnYr3d/hj0fBIA93UNzfvkdGjbTw+e2CM5VDhwEBXRDeCOMu +P5Wg2tj8FHjO1r8p+58+p807FAg+WGxf9yP0x1gPcaDDkroUaYOJAeLtjlf b7HsgqdmFUZ6CPwOG7TCaNYUXBRpfoaqOKpIqkp+CWlItrE3mX2QiXTiDgo6 KKt82N+zasa0FlzoRpC4CpPdpeNhRCmzIV05SXiRtR9E3W7UEYFQd48ZBVNw Lxk/Pg0ehCg2MmWifjLe3oG0wtG2YbOitObNxEt2OHn4l7JbQK51rza8i1nw ssEYOBm451R2QdLRY54/8qCdfnVqSFi9cPlN4J4hheBZA1P1HN09NRGeMvJ3 pS5SDpguW2YBs60l7lSH+W1CJUr8LlKPrKzEPndyFbO7RSXlcVZGnC3HT71i Re3J44xAp1CYk6poPEqR4MtmnICFs7/BLRSLX2ya4cgxoxrQdq7EBtXZzJL7 II9g8rPMzZ6Q9o+DHhKSzKNKzCU/lGMndX3OzoqwqecKaSHz1ANy76wB1i8k raJtnXIkmqF4iAqEcTtR+zoxfDY7PR1kMHZIV4PoZtgeWcfgZEu7FQ/9tkro LwyvSoYOqEW1nAOxRix69kDbM0zfukWj36DEiy5p4qYrlKNwcB2OW3GIdnDO zFd5ONvRFrMdE0ZxiK0pHJB2kZ5EgmHkrZBCQ2VgDs1eNrP7zGeEiuNp2cD6 hhDfVNEdpLhobenMcNH65mZmjc5uBb2EULWB/X6EsjFGP2Yjt0AYumu1yYRQ GJ2j9s9vzXktg9+7GeMsdj+L4tR4YCVkDiochrKah6CeXWKUeYd7Br0a+HUH z5y3YJpPmvyYQK7QnyyhVCQ98yRBi/RsLjCaV9b+Dv5yQtzsfHKGcW7uMiUH ZrYyyPWCiUZwakQFmRfhrzWMwuvZxxlbHp9ZBLJA2s33mVVu5ZvIwjZuuQNW MhqoAmwgdsSlX5vKVCLxu6lF4DrnQSumHuUCJPTwBmPrCqLRde1Jtw2gwqm4 gYLzhVFUpjHXc1HzIAnrdLRQOLKmHvZqDNvmOYZEMCeHpMuZ2SkMMowT0PCf 3+1fGCbmth/tlWk0zc2c7KUIA5n6G1LBW8UCcntiCxzDYBIKszIvUFRtCE3g UE3VrlU1mL57+niRcqXqqBFXcXMiUc1Sbs9EMt2ffnKRVa1SAbATnrksPaV0 B5qcOrQaQRFZh6ac7oAaOyRRhC7qUN3v5JFwkI0DATuQf1xASoGAlm2ZFJHM oT2sqZHEqihwiHcrOFm3JepwV1bpmmUWWvtGT68k8MgCzJNYapUGswFtblZF PM/gDa9uV/M17EZOqAbvBR43LfIibpXu8tZ4RNMAq53QrYy5WafcOb9nXItu gKXFlUTxnUnlSYbrpMYz1ZKGtdvewfcwvOI46WLgDcKhGIAH9G0tv4IA+odk 25nuM6TuFVluHo5PzF4pGKLGpzSVqYI6ctFPrGo73qBv2nKe31BDrP2jUhV1 myDnPVKIWIwvYDEw/g9GLTZ4WEGE60TM8+tomh94wy6w0ce21rnYxrXcpXW0 TDGS+/bAVfybRx6jPnoTT+PUpLcEmrgr+KIAU1Y0aCqTQA5SozkfNct9J8lT zM+QIkTR7BjJVDJLY4ees2iAvwwX71UAEMDpZtlowUmg6iSuJqaoQgQflNic TS2cMVQGPWWH7eGiGyEkzBWKTy2n9AZiDT7eKP5A6QZxHB111P0FYMg/ul6A EPWyOXLL9Rz1nUwFNEYSSMmfHpiP8g3nKeD0piu8LJX38+IgjCglKVoJgYJv NRVoBHqY4p45TL6W4Q43Nukiq+xbdUKvun6Wn6bNzRHPGbLZ0R5uG8yKGH5o JwRB1Sg2QBByc+xGY162DSuFRkEjse/jdxl7IKyXNS8jmynYX0Pw3axkcBhM pqbLw4sWJEXHYDHXzfFGfi3dScZdQ5CG3fa4C+efX4IdwDgVM7EUpY9mUHE7 NYO7HgWtMI3bwWhrJu5s1WquJy2BMGtvRlbGj4EP4Oo62bW3WRZ/bd7WorMJ RCQ3x9wr/5o2DAS6XuRpRyyxWShvO5BY3Im6A7CiU/HjuE5oTlonEkzCIkKP whTtMexDGGxDOFPURtSC65QkFU9kaLf+GBxbstvrBGywuNO1BcVqDEqRRrBq 7kguT/WxbI2hYZgSrJiqEsvMXKek2E7a7fFwGKFNhx22AQaAFRiu1fLBvOJR zRLDORWFpoVhclU7OTt4TfpCEeSoAX/CWhQw2NrHjEVa9xBR4pqe4IEUc7PY puWdyXC80GAPNZIZ4/6MK5eI8eXxI+FoB6GcHswEDfBarKvBG1QTDQdQtsyF UHBxIpgGy2+RAgrBVRsN4x6unRgsssNac75eceWkqePw3PSKFUSf5jWtqPUb bFjQiW+IPTvSezdHYFRgnt4vZuo85oq33ryBhcuNbQ9vuExwoC3DpTaH0T6M OjIeWUY5cjfwtGHMunvKoikAmXrY2cvGq2MZOnifAZCYpv6iE31M+JP8L51k tz8zAJM/c38+w2mgDsz/NreYyf+01DSPns3/8in4m5j/7dPNv6/66CdC8/H3 Of/TL73iVT/zU6955V0ffv5nv+413df/za2Nd7/5ZduvfsmV5/zGy4Lf/rFv /9IX/OPfnnroxT/4n18ffPwF//JH3/6nn/uSV931G6eDv/PF3/2FJ3/r42// +dbcB5//JZ849Vf//LUf2BnW/vk33Xz+d7ztrve/Y/bqG9/2p5/xWY/9+Rf9 5D97ydQHmy/6p8EvRf/ywZ89Xq3dPPO6V3zGp/3hq77z333i/9c9efFzfnLq nl997N3fePnEO+rPfX78wZe+s9J42/Nf0fuiz7vrrp/+tB/9mfDRP3gfzOrZ HFSH/ZPzDyYUM+RBWduOt57RPg44/43mPOR/ajaXGvMQkIfyPz17/j8lf689 ++DySvgSc+j/6K67PvGJT3z2o7f+9S986Nzbvtl86f7d937Zd73/67//Xx/9 +OedQs67wxbDBlgAVtA48q6j//N5dwH+OPqJzzh35vKlUycvnGnW6s99jnlU hS6g8bueO/fCH/yPH6//5Nnrn9N+4eoLX/5NLzj3dVtHzvyzxo//4Eu//se+ v3b1X/74E//vzMbLVj74D16w8rIXveB113/nobu46efoduahnXN/62jw+e98 0Q+977e/7PQTD3zB5auNlwdXHz6z8XnfeesV3zf+0O+FL3vB24JffNlv/M1T L//uV99z7K9wQ5+mG1p84Q827z7+kyf/zbt/6qvfMPvp72q/4rP++8vP/eHZ B8Kv+67BKz4y9VPf8yOv+NffefzT3vR7n/vnz/min3hx8x91Pu9bf/R53NRz M3Nrvfr4Tzb/5nv+2ze94cq7vvwfHHnX0Rc9r3H6i8NXfPY/fvAd7/vZVz23 dXHzo+uvqi9XP+8r/s13DFcelrk9T7fTfOEPDqePv+53Oi/9yMs++vDbX3Tv jZ+4+njr8le/650/8MqdNz1Q+ZmffM1LnvvK373vVT9xL7Zz8SulmednhhP8 +LtXPvc3R7/zw7/yLfWXf+AVv3a09sD3f/NPPvZ//b3Giz79M16ahj/0voU/ +ZrnvL3+viNf+kPf2qu8Ttr59Mxw/uPHP3Lks3/5mx7d/Ibn/P6vPDH4mqtf 8sHwmz44/3ffdfLBf1V/6buvfuP3P+czn/fjr3nJNzbe9uO/8NPvkWZekGvG 7Px3RQ/8/DdVfvGVL3zhTwR/5wNPfNbzGvV/9JPve++Fl/242a43/Mrf/7Rg 3HrZO75l47Pffddd/7uSS/+f+9P03ycrA/DB+X9z+T8XFp/N//cp+TtM/t/3 cP7fv/V93/ZFF176mj/42t//2NR/e83ZD/y1D33t1Xu/rvSWxZuvf81fvd76 mb9382vSzXe94Hd/7JEjX7L6gc9++4tf/mWz33L827fff6HzO83Xfk/0E+/+ wrd+84f++eu+6sqftF/0eZf+ypV/9VtfO3Xpc14d3ew8+mfftvk/yo8+9Oe/ 9kf3v+fel37ti9/1vT/2grX5X/mfL46/+KW/ec/X9L9u7mvvf+GRj33uK/e+ +vPbz/ndP3znP+2881f+GszgWVrv6fzJ+UdZWa2dPsOpP/Fv//PfhFjXmfyf C4tL88+e/0/FH+X/tLvvJf70M36in0e6E0WjYGZGZKs7US/6i8zuOXsMBtML 0SpqDyJAzDz1P2yxE9+otbtRCO5yJDnCX6tBKwEPndvS5zDqtgzgPI3u/D5N e0hgU5+7cWcEKS7q9VevsZKnP5pJMQ3lCjy77dfameOKXhiJXLFxl4v1wuF2 3F8VaeUg7IAth/mN/2vUBxzRBsS3M7jzE1rsxtmO4745I0UFawQQVHzL8A8G TvDRmhrSDAPQAozALnYad6JnYLXtYqcIg9zq7hDsq2W37VLAIsAw7HrcLqjr zwacsdb0/jXn7Ery9KAIBKeauLFYOxl2ZmBYq6TEmYEH9Ao8OE1vu/g68N8X DtBu+cStzJUfd6uFL2q7oRnrIIlBQ/hkflbNQrBJnxiHw31789saJQMLl/zI HL1R0sOnha2gKUe+kX22DSNycZUWOo6a4mav0wS0X3evLHda7bbaoK2wF3cN cKdhP51Jo2G8ldu9BqRFKuyMnapbyU3qdwMsVNfJNWQzc+CXZMxxbzszPrsm N2c89OBOCWlxwBL8aaNBs9vcnI8w8FQAjnCb7ZAHjsXVtLjBlqDjBP+66pCk aXsIhh4zcc8MHWOToSYO+JFKrtAwGkRw2PoJf82VQH9gzFBcD5Z4Ob1RhXJs Yfd2I8I4raTbyRfF64AUEHIdJF3IdXz38vLymrc0TV4Zd+ah1kzYjbf7ghuo edYKiUmvQY3bSdJhN4R9x0YbTQFrnu4+00aPwBulJjY1+MsHSYuVvLMejkdJ Ed6m57eL2x3UWvG2uR2uW5TUj2Z2eI6NBQbmMFNKn7HaHJ8ycKmrQSEyzdQl Ce3EI7PwbQ9CCSssyO4UXKm0vNtRPxqGEsLqmVhebKlgbe0BzhUbCSWQhyHU lUVD9MiWN2Zmxe3cGXb1cfcMhQ20l0Wu8fuDUSvp7MHnEP7pmH9sh7LoBC91 3rf8RIe1QdtcZVTJAoOgwaLyrnge22dQgRzWrSb8TxBrbZRsb3ftle9D8Fzm xsbG7cP2eJhCi3gLRkOL8XtJBwc5c23cGwCm17ibB+jul06Hr3N+L1tQVMRi 3qgHpAj8m8W7tXl19xjo/d9gJHSSOgmS5j2M8PnUz5M6SbLOmVNiR9C0QEDz MQDQDQfAUMi3goOOQEz8zVMeHiw9tjOoBvZ7p6N+dGP1o9VN2tefGCcjwQgz veQtMzt7gx3D/mj0OtNLCx/vRq3r8ajoVeYRYtSdCDQ7CqneiNMYU9EaomYn 7nSiPpbcaazuAIlpDrKuVJ3aaU56MTfpxfykFwuTXixOeNEZTXhhMAFe9MVv B7X939Pd3olmcDNm9itcsGr4vesIW9p86bIAe8f9HUM4jvwK++B5U6xGRjEF GDw4ajP8YclBbThuDQ1Lni/r6JFimgIQInY8Q8EkTKfb42HkPSOzf/XI543d xZTjhHzkKkSy6xNfZDvlh16vmnvkbhX3OJGfpOsn3287Avyd7Vieej3TQ+za crkIMmtTE6iiCTRRfv2Kdz3XrV+QXuiiem10SV6OLB/9lLBcEcLzuWArVID/ 1RbM/dCQVLEFPFan08rcHoZWx/+Yap90lW9FHo89bzlpDwTwTPD4Zsh/7GDC 2pwXsB58equj1gfbm8xmttvtg5cgw3nRB88P28/PTohlu/wFcy4mn+xKhJ1e 0kcu6mkth10J196+pFuGJG3kmcwlxdOrRjujfbc3WzpDFfsChoEq6i2uBXCz BU48tD921VcDntuoCOPLkc6uTNOXgyHV8wzBJ9FTYMc2irtpBkjrhyGiqIUC ZPUUOMVA7k1k7PjHTH/ca0X7cXf7V2eu/XZusiNweMo82smSknBQl2GnaaO9 FdFsFD9iPsd7xlP1HxaQ2GEYqhXdSpJRHyhDN0z3aCe7U1lKwJYo5hyFLcvI WZldj0EbZM+oNzMaKgx6exjuFd2xxU1ZCiczfctWEmjTNfy0YdsiHGove3Dh VsrxLAuKe+JqWTpOlZ7br/QdQ+/BrTggloWKuh2yq37qLIuHA7DFGWxRQZx6 eCDM6dIH6BgyBJmuOchXdCXQ77aIVeqF/XHYLWCWvBdZdkm/zD20a00e4k+T PeS1Trq1cBi2LD2gZeSdqB33uGdTrgt23xh4r6AsvpzBt1J+DPqLSeXxpV8e mxga3rw/sX1867U/qTy178pPulsbgmo6naBIflN3r8eQm6ITaIFZIWFApQs4 ngPJCQ9xzdnGRqsj8yIyrAceQWUULieggB5tRQvzhMkgCExBpa242/ULdrq1 7W6SpuCOsB/lUkzRwaFIEDmEXQ+7ZGSkhvzdnoEYtP18qS7Mk3kIw+6mpjEQ rZiz1tkfYdXSPfDgmOEYP/usSyfMYNrMJYr7xNfKMOrwYeeLjjci2Kf9LYLn GkqRkR/LqiItk5YhN+UOyIKHrJtqMd/6oQWp/uVob5na9hhCQEUGxmu9qD8m Jyl31UzUNyG7126b4sNwlHiMocEfyTAknQd4oQ6tCraGThSwr0UXUdLqxk+M qWTYahnGN2wPk/5er/jK5oAojawwFHyOFNYEmYpswtO40BFrDuwdLppPTVFa baiTYoErlDlxN8FzUgJgpukYQsD0g1M7QwhiwNkIUuhBdAmuI/96ITIld7mo x9mrxb3KPALaqIMA1U/SwHXoq8eyh0SIx9wJGA0NcODxZtJOToZPTVp8VIBO mWa1sFlYIy9kFfa+niGe8sK0AvFsoQIGQ7zv1w7C1CRc4K3E5DYg7OWN4H4U wto5mt+DDJ1oz/bkpibTeYpSRAk5YeMDKMCDenA0IJTuxiO47rnCJPMFEr+o aRRX8xejiACDwdVAzaZIsENA42GusyYDj+0CsdXh+5GqN4fRVhXj9x4WSiaM EEXg2Ew12GnKlzn5Mi9fFuTL4p1BZu1GHO3ibmsFZ1Zw5UpBixMtZva7KWBb XSuw43Kj+ls8AwzdTIGcpZ6VCPXC0Y5FqU8ZqRNWBzEstkeDyWozewaVZyXr qGSDKgN98eUlonhuoif6yaTFdQUKBPzOdADtluIbjMkZUcoqvWUGlVCrEH9b FIBmbKw6uAPFAS0thosG4zXPxu6pLe1relEnDjkCtdBDN2rir1jNPWFE4F7A cvtIxcMJHu8nb3P2auxlnjOGcd2wYZh7AKSfjONug4L1EaEynmkb9XL7L9qA 8tm/Z/+e/Xv279m/Z/+e/Xv279m/Z/+e/Xv279m/Z//+Evz9/wF0Uwr+AAgH AA== --8323329-542490146-1596757090=:16004-- From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:49:26 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 23:49:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3pdE-00049i-I5; Thu, 06 Aug 2020 23:49:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3pdD-000497-6P for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 23:49:07 +0000 X-Inumbo-ID: ef0a8600-ae4f-4719-be5a-8f4611405119 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ef0a8600-ae4f-4719-be5a-8f4611405119; Thu, 06 Aug 2020 23:49:06 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C2937221E2; Thu, 6 Aug 2020 23:49:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596757746; bh=1OY1VeWI4aiTYikcUEmnMBeLg9G9bo4U06TqQ4H7Hdw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=HUBiKB++9n4ez6V/cQLegI0WNgHh/4pYY9lUFVv7i5V0Z7FEu5H8kpIjeG26m2uP7 rTBubGicmNQB/gQsmjJKK+gduOVTtEvuc8ZBYGXNm8RtyZFckwvXKE/AvxYQlDZ0Ws T103tmchJWeEi8bzSQm0O8vabcEQtRc8k7Gaugy4= Date: Thu, 6 Aug 2020 16:49:05 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Julien Grall Subject: Re: [RFC PATCH V1 05/12] hvm/dm: Introduce xendevicemodel_set_irq_level DM op In-Reply-To: <92e2b136-8468-2877-0e8c-c13ff2a0a1fb@xen.org> Message-ID: References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-6-git-send-email-olekstysh@gmail.com> <00e261e0-295a-9cd8-ed11-7e3801a4eb58@xen.org> <92e2b136-8468-2877-0e8c-c13ff2a0a1fb@xen.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Oleksandr Tyshchenko , Julien Grall , Jan Beulich , xen-devel@lists.xenproject.org, Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Thu, 6 Aug 2020, Julien Grall wrote: > On 06/08/2020 01:37, Stefano Stabellini wrote: > > On Wed, 5 Aug 2020, Julien Grall wrote: > > > On 05/08/2020 00:22, Stefano Stabellini wrote: > > > > On Mon, 3 Aug 2020, Oleksandr Tyshchenko wrote: > > > > > From: Oleksandr Tyshchenko > > > > > > > > > > This patch adds ability to the device emulator to notify otherend > > > > > (some entity running in the guest) using a SPI and implements Arm > > > > > specific bits for it. Proposed interface allows emulator to set > > > > > the logical level of a one of a domain's IRQ lines. > > > > > > > > > > Please note, this is a split/cleanup of Julien's PoC: > > > > > "Add support for Guest IO forwarding to a device emulator" > > > > > > > > > > Signed-off-by: Julien Grall > > > > > Signed-off-by: Oleksandr Tyshchenko > > > > > --- > > > > > tools/libs/devicemodel/core.c | 18 > > > > > ++++++++++++++++++ > > > > > tools/libs/devicemodel/include/xendevicemodel.h | 4 ++++ > > > > > tools/libs/devicemodel/libxendevicemodel.map | 1 + > > > > > xen/arch/arm/dm.c | 22 > > > > > +++++++++++++++++++++- > > > > > xen/common/hvm/dm.c | 1 + > > > > > xen/include/public/hvm/dm_op.h | 15 > > > > > +++++++++++++++ > > > > > 6 files changed, 60 insertions(+), 1 deletion(-) > > > > > > > > > > diff --git a/tools/libs/devicemodel/core.c > > > > > b/tools/libs/devicemodel/core.c > > > > > index 4d40639..30bd79f 100644 > > > > > --- a/tools/libs/devicemodel/core.c > > > > > +++ b/tools/libs/devicemodel/core.c > > > > > @@ -430,6 +430,24 @@ int xendevicemodel_set_isa_irq_level( > > > > > return xendevicemodel_op(dmod, domid, 1, &op, sizeof(op)); > > > > > } > > > > > +int xendevicemodel_set_irq_level( > > > > > + xendevicemodel_handle *dmod, domid_t domid, uint32_t irq, > > > > > + unsigned int level) > > > > > > > > It is a pity that having xen_dm_op_set_pci_intx_level and > > > > xen_dm_op_set_isa_irq_level already we need to add a third one, but from > > > > the names alone I don't think we can reuse either of them. > > > > > > The problem is not the name... > > > > > > > > > > > It is very similar to set_isa_irq_level. We could almost rename > > > > xendevicemodel_set_isa_irq_level to xendevicemodel_set_irq_level or, > > > > better, just add an alias to it so that xendevicemodel_set_irq_level is > > > > implemented by calling xendevicemodel_set_isa_irq_level. Honestly I am > > > > not sure if it is worth doing it though. Any other opinions? > > > > > > ... the problem is the interrupt field is only 8-bit. So we would only be > > > able > > > to cover IRQ 0 - 255. > > > > Argh, that's not going to work :-( I wasn't sure if it was a good idea > > anyway. > > > > > > > It is not entirely clear how the existing subop could be extended without > > > breaking existing callers. > > > > > > > But I think we should plan for not needing two calls (one to set level > > > > to 1, and one to set it to 0): > > > > https://marc.info/?l=xen-devel&m=159535112027405 > > > > > > I am not sure to understand your suggestion here? Are you suggesting to > > > remove > > > the 'level' parameter? > > > > My hope was to make it optional to call the hypercall with level = 0, > > not necessarily to remove 'level' from the struct. > > From my understanding, the hypercall is meant to represent the status of the > line between the device and the interrupt controller (either low or high). > > This is then up to the interrupt controller to decide when the interrupt is > going to be fired: > - For edge interrupt, this will fire when the line move from low to high (or > vice versa). > - For level interrupt, this will fire when line is high (assuming level > trigger high) and will keeping firing until the device decided to lower the > line. > > For a device, it is common to keep the line high until an OS wrote to a > specific register. > > Furthermore, technically, the guest OS is in charge to configure how an > interrupt is triggered. Admittely this information is part of the DT, but > nothing prevent a guest to change it. > > As side note, we have a workaround in Xen for some buggy DT (see the arch > timer) exposing the wrong trigger type. > > Because of that, I don't really see a way to make optional. Maybe you have > something different in mind? For level, we need the level parameter. For edge, we are only interested in the "edge", right? So maybe we don't want to specify the interrupt line state for edge interrupts (note that virtio interrupts are edge.) Maybe something like this: struct xen_dm_op_set_irq { uint32_t irq; #define XEN_DMOP_IRQ_LEVEL 0 #define XEN_DMOP_IRQ_EDGE 1 uint8_t type; /* * If type is XEN_DMOP_IRQ_EDGE, level is ignored. * If type is XEN_DMOP_IRQ_LEVEL, level means: * Level: 0 -> level low * Level: 1 -> asserted */ uint8_t level; }; So a level interrupt would get two xen_dm_op_set_irq hypercalls, an edge interrupt only one. From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:49:39 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 23:49:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3pdj-0004FQ-Ao; Thu, 06 Aug 2020 23:49:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3pdi-0004FC-LX for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 23:49:38 +0000 X-Inumbo-ID: ecfadc8d-df65-4027-ba04-4b0b249ec072 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ecfadc8d-df65-4027-ba04-4b0b249ec072; Thu, 06 Aug 2020 23:49:38 +0000 (UTC) Received: from sstabellini-ThinkPad-T480s.hsd1.ca.comcast.net (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7446422CA1; Thu, 6 Aug 2020 23:49:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596757777; bh=y/bvXVXIYfS8TsoXxqPnkT0rBiCwLBaUOaB2sinhwII=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RathqVvuF9/ZQFWQuqonkD41ff9FoYx3yIubp0sNft+yv8ZQW6VSkwpeGvuOJupQR 5gg3g5RASn3D68OUyCDCc6EV+ncEoGgRcRoe4BVlEIErgqsdLdfBnJGQW3ynBRs7lS eCCdrIcxDlVe6hA1vPB59Qc3EXXB5I08unnoYDV8= From: Stefano Stabellini To: xen-devel@lists.xenproject.org Subject: [PATCH 02/14] kernel-doc: public/hvm/hvm_op.h Date: Thu, 6 Aug 2020 16:49:21 -0700 Message-Id: <20200806234933.16448-2-sstabellini@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: sstabellini@kernel.org, julien@xen.org, wl@xen.org, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, Stefano Stabellini Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Stefano Stabellini Convert in-code comments to kernel-doc format wherever possible. Signed-off-by: Stefano Stabellini --- xen/include/public/hvm/hvm_op.h | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/xen/include/public/hvm/hvm_op.h b/xen/include/public/hvm/hvm_op.h index 870ec52060..d62d3a96f8 100644 --- a/xen/include/public/hvm/hvm_op.h +++ b/xen/include/public/hvm/hvm_op.h @@ -27,14 +27,26 @@ #include "../trace.h" #include "../event_channel.h" -/* Get/set subcommands: extra argument == pointer to xen_hvm_param struct. */ +/** + * DOC: HVMOP_set_param and HVMOP_get_param + * + * Get/set subcommands: extra argument == pointer to xen_hvm_param struct. + */ #define HVMOP_set_param 0 #define HVMOP_get_param 1 + +/** + * struct xen_hvm_param + */ struct xen_hvm_param { - domid_t domid; /* IN */ + /** @domid: IN parameter */ + domid_t domid; + /** @pad: padding */ uint16_t pad; - uint32_t index; /* IN */ - uint64_t value; /* IN/OUT */ + /** @index: IN parameter */ + uint32_t index; + /** @value: IN/OUT parameter */ + uint64_t value; }; typedef struct xen_hvm_param xen_hvm_param_t; DEFINE_XEN_GUEST_HANDLE(xen_hvm_param_t); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:49:39 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 23:49:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3pdj-0004Ff-Jv; Thu, 06 Aug 2020 23:49:39 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3pdi-0004FE-O4 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 23:49:38 +0000 X-Inumbo-ID: de17af2a-d198-4f62-9232-95fbba937597 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id de17af2a-d198-4f62-9232-95fbba937597; Thu, 06 Aug 2020 23:49:37 +0000 (UTC) Received: from sstabellini-ThinkPad-T480s.hsd1.ca.comcast.net (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E798D221E2; Thu, 6 Aug 2020 23:49:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596757777; bh=+bH6i0fxdSimA4/2UszHbXiunli/VYKW3yjongFM0ps=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CSxslA4bgxv99uzScg4Rmpw7RWF9fBuyGiYdfCccb2kT4cb/joDyRSAooKspjQhBC 1ftMZtNDzjrmYeXuovc6e7VfJwaWx3cA6iF3QL3jw7/9ckFmX8/4pAwcR65cLecggq szfjyhrdf5i5uy1GrmBSIKhZ4YKnXfAx011R5qMY= From: Stefano Stabellini To: xen-devel@lists.xenproject.org Subject: [PATCH 01/14] kernel-doc: public/arch-arm.h Date: Thu, 6 Aug 2020 16:49:20 -0700 Message-Id: <20200806234933.16448-1-sstabellini@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: sstabellini@kernel.org, julien@xen.org, wl@xen.org, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, Stefano Stabellini Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Stefano Stabellini Convert in-code comments to kernel-doc format wherever possible. Signed-off-by: Stefano Stabellini --- xen/include/public/arch-arm.h | 43 ++++++++++++++++++++++------------- 1 file changed, 27 insertions(+), 16 deletions(-) diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h index c365b1b39e..409697dede 100644 --- a/xen/include/public/arch-arm.h +++ b/xen/include/public/arch-arm.h @@ -27,8 +27,8 @@ #ifndef __XEN_PUBLIC_ARCH_ARM_H__ #define __XEN_PUBLIC_ARCH_ARM_H__ -/* - * `incontents 50 arm_abi Hypercall Calling Convention +/** + * DOC: Hypercall Calling Convention * * A hypercall is issued using the ARM HVC instruction. * @@ -72,8 +72,8 @@ * Any cache allocation hints are acceptable. */ -/* - * `incontents 55 arm_hcall Supported Hypercalls +/** + * DOC: Supported Hypercalls * * Xen on ARM makes extensive use of hardware facilities and therefore * only a subset of the potential hypercalls are required. @@ -175,10 +175,17 @@ typedef union { type *p; uint64_aligned_t q; } \ __guest_handle_64_ ## name -/* +/** + * DOC: XEN_GUEST_HANDLE - a guest pointer in a struct + * * XEN_GUEST_HANDLE represents a guest pointer, when passed as a field * in a struct in memory. On ARM is always 8 bytes sizes and 8 bytes * aligned. + */ + +/** + * DOC: XEN_GUEST_HANDLE_PARAM - a guest pointer as a hypercall arg + * * XEN_GUEST_HANDLE_PARAM represents a guest pointer, when passed as an * hypercall argument. It is 4 bytes on aarch32 and 8 bytes on aarch64. */ @@ -201,7 +208,9 @@ typedef uint64_t xen_pfn_t; #define PRI_xen_pfn PRIx64 #define PRIu_xen_pfn PRIu64 -/* +/** + * DOC: XEN_LEGACY_MAX_VCPUS + * * Maximum number of virtual CPUs in legacy multi-processor guests. * Only one. All other VCPUS must use VCPUOP_register_vcpu_info. */ @@ -299,26 +308,28 @@ struct vcpu_guest_context { typedef struct vcpu_guest_context vcpu_guest_context_t; DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t); -/* + +/** + * struct xen_arch_domainconfig - arch-specific domain creation params + * * struct xen_arch_domainconfig's ABI is covered by * XEN_DOMCTL_INTERFACE_VERSION. */ +struct xen_arch_domainconfig { + /** @gic_version: IN/OUT parameter */ #define XEN_DOMCTL_CONFIG_GIC_NATIVE 0 #define XEN_DOMCTL_CONFIG_GIC_V2 1 #define XEN_DOMCTL_CONFIG_GIC_V3 2 - + uint8_t gic_version; + /** @tee_type: IN parameter */ #define XEN_DOMCTL_CONFIG_TEE_NONE 0 #define XEN_DOMCTL_CONFIG_TEE_OPTEE 1 - -struct xen_arch_domainconfig { - /* IN/OUT */ - uint8_t gic_version; - /* IN */ uint16_t tee_type; - /* IN */ + /** @nr_spis: IN parameter */ uint32_t nr_spis; - /* - * OUT + /** + * @clock_frequency: OUT parameter + * * Based on the property clock-frequency in the DT timer node. * The property may be present when the bootloader/firmware doesn't * set correctly CNTFRQ which hold the timer frequency. -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:49:43 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 23:49:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3pdn-0004Hl-Sw; Thu, 06 Aug 2020 23:49:43 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3pdm-0004FE-9P for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 23:49:42 +0000 X-Inumbo-ID: de950a77-4645-4183-8609-e3c81e6c3e77 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id de950a77-4645-4183-8609-e3c81e6c3e77; Thu, 06 Aug 2020 23:49:40 +0000 (UTC) Received: from sstabellini-ThinkPad-T480s.hsd1.ca.comcast.net (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 237ED22D07; Thu, 6 Aug 2020 23:49:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596757780; bh=vVWvxFFs7Yr6hpfuyCAosWa4IVXyicJJf2O/VvYAi0Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=If5S1EL3ji2mtq9qiY+h/4Ky85NXw1uNXd49fNwqCoCfcO+LgaxgCglvB1jOoxYIJ Zifs7DLec76pfR57z+Jjk/KwrYyeo2YscTgcMp6/zsZtCi+RJp4J+Tiyb/fEF+dtAs +9EFJ3NggIJuEl8E7YY3X1GPDaf66lYOZEKdiYWI= From: Stefano Stabellini To: xen-devel@lists.xenproject.org Subject: [PATCH 07/14] kernel-doc: public/hypfs.h Date: Thu, 6 Aug 2020 16:49:26 -0700 Message-Id: <20200806234933.16448-7-sstabellini@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: sstabellini@kernel.org, julien@xen.org, wl@xen.org, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, Stefano Stabellini Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Stefano Stabellini Convert in-code comments to kernel-doc format wherever possible. Signed-off-by: Stefano Stabellini --- xen/include/public/hypfs.h | 72 ++++++++++++++++++++++++-------------- 1 file changed, 45 insertions(+), 27 deletions(-) diff --git a/xen/include/public/hypfs.h b/xen/include/public/hypfs.h index 63a5df1629..ef33aee4ce 100644 --- a/xen/include/public/hypfs.h +++ b/xen/include/public/hypfs.h @@ -32,12 +32,21 @@ * Definitions for the __HYPERVISOR_hypfs_op hypercall. */ -/* Highest version number of the hypfs interface currently defined. */ +/** + * DOC: XEN_HYPFS_VERSION + * Highest version number of the hypfs interface currently defined. + */ #define XEN_HYPFS_VERSION 1 -/* Maximum length of a path in the filesystem. */ +/** + * DOC: XEN_HYPFS_MAX_PATHLEN + * Maximum length of a path in the filesystem. + */ #define XEN_HYPFS_MAX_PATHLEN 1024 +/** + * struct xen_hypfs_direntry + */ struct xen_hypfs_direntry { uint8_t type; #define XEN_HYPFS_TYPE_DIR 0 @@ -49,16 +58,22 @@ struct xen_hypfs_direntry { uint8_t encoding; #define XEN_HYPFS_ENC_PLAIN 0 #define XEN_HYPFS_ENC_GZIP 1 - uint16_t pad; /* Returned as 0. */ - uint32_t content_len; /* Current length of data. */ - uint32_t max_write_len; /* Max. length for writes (0 if read-only). */ + /** @pad: Returned as 0. */ + uint16_t pad; + /** @content_len: Current length of data. */ + uint32_t content_len; + /** @max_write_len: Max. length for writes (0 if read-only). */ + uint32_t max_write_len; }; +/** + * struct xen_hypfs_dirlistentry + */ struct xen_hypfs_dirlistentry { struct xen_hypfs_direntry e; - /* Offset in bytes to next entry (0 == this is the last entry). */ + /** @off_next: Offset in bytes to next entry (0 == this is the last entry). */ uint16_t off_next; - /* Zero terminated entry name, possibly with some padding for alignment. */ + /** @name: Zero terminated entry name, possibly with some padding for alignment. */ char name[XEN_FLEX_ARRAY_DIM]; }; @@ -66,21 +81,22 @@ struct xen_hypfs_dirlistentry { * Hypercall operations. */ -/* - * XEN_HYPFS_OP_get_version +/** + * DOC: XEN_HYPFS_OP_get_version * * Read highest interface version supported by the hypervisor. * * arg1 - arg4: all 0/NULL * * Possible return values: - * >0: highest supported interface version - * <0: negative Xen errno value + * + * - >0: highest supported interface version + * - <0: negative Xen errno value */ #define XEN_HYPFS_OP_get_version 0 -/* - * XEN_HYPFS_OP_read +/** + * DOC: XEN_HYPFS_OP_read * * Read a filesystem entry. * @@ -95,19 +111,20 @@ struct xen_hypfs_dirlistentry { * The contents of a directory are multiple struct xen_hypfs_dirlistentry * items. * - * arg1: XEN_GUEST_HANDLE(path name) - * arg2: length of path name (including trailing zero byte) - * arg3: XEN_GUEST_HANDLE(data buffer written by hypervisor) - * arg4: data buffer size + * - arg1: XEN_GUEST_HANDLE(path name) + * - arg2: length of path name (including trailing zero byte) + * - arg3: XEN_GUEST_HANDLE(data buffer written by hypervisor) + * - arg4: data buffer size * * Possible return values: - * 0: success - * <0 : negative Xen errno value + * + * - 0: success + * - <0 : negative Xen errno value */ #define XEN_HYPFS_OP_read 1 -/* - * XEN_HYPFS_OP_write_contents +/** + * DOC: XEN_HYPFS_OP_write_contents * * Write contents of a filesystem entry. * @@ -115,14 +132,15 @@ struct xen_hypfs_dirlistentry { * The data type and encoding can't be changed. The size can be changed only * for blobs and strings. * - * arg1: XEN_GUEST_HANDLE(path name) - * arg2: length of path name (including trailing zero byte) - * arg3: XEN_GUEST_HANDLE(content buffer read by hypervisor) - * arg4: content buffer size + * - arg1: XEN_GUEST_HANDLE(path name) + * - arg2: length of path name (including trailing zero byte) + * - arg3: XEN_GUEST_HANDLE(content buffer read by hypervisor) + * - arg4: content buffer size * * Possible return values: - * 0: success - * <0 : negative Xen errno value + * + * - 0: success + * - <0: negative Xen errno value */ #define XEN_HYPFS_OP_write_contents 2 -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:49:45 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 23:49:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3pdp-0004Id-5j; Thu, 06 Aug 2020 23:49:45 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3pdn-0004FC-KI for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 23:49:43 +0000 X-Inumbo-ID: 29a9c849-bce0-46c7-947d-d1f4f0fd0f11 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 29a9c849-bce0-46c7-947d-d1f4f0fd0f11; Thu, 06 Aug 2020 23:49:38 +0000 (UTC) Received: from sstabellini-ThinkPad-T480s.hsd1.ca.comcast.net (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F111222CBB; Thu, 6 Aug 2020 23:49:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596757778; bh=kQJOWQmiev2GmAsfEYKexaRWR3uthIyBp6QIEIE2jMM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GbWqXG4ZBOtym3xLogVvTTc16LfMczACHj42CNSN9hiB7Q0xwaUktOn2ocbpdmud8 sP6CMrMJVlhP1tKliZzMutB3ardys81p12byqv4EtlEu8xedMN+RMaVpsYkOYBfYBm ZA7utGr39Bm04LZsY8AogBhOeq3UmE2Vf/5t2C/w= From: Stefano Stabellini To: xen-devel@lists.xenproject.org Subject: [PATCH 03/14] kernel-doc: public/device_tree_defs.h Date: Thu, 6 Aug 2020 16:49:22 -0700 Message-Id: <20200806234933.16448-3-sstabellini@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: sstabellini@kernel.org, julien@xen.org, wl@xen.org, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, Stefano Stabellini Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Stefano Stabellini Convert in-code comments to kernel-doc format wherever possible. Signed-off-by: Stefano Stabellini --- xen/include/public/device_tree_defs.h | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/xen/include/public/device_tree_defs.h b/xen/include/public/device_tree_defs.h index 209d43de3f..be35598b53 100644 --- a/xen/include/public/device_tree_defs.h +++ b/xen/include/public/device_tree_defs.h @@ -2,7 +2,9 @@ #define __XEN_DEVICE_TREE_DEFS_H__ #if defined(__XEN__) || defined(__XEN_TOOLS__) -/* +/** + * DOC: GUEST_PHANDLE_GIC + * * The device tree compiler (DTC) is allocating the phandle from 1 to * onwards. Reserve a high value for the GIC phandle. */ @@ -12,17 +14,17 @@ #define GUEST_ROOT_SIZE_CELLS 2 /** - * IRQ line type. + * DOC: IRQ line type. * - * DT_IRQ_TYPE_NONE - default, unspecified type - * DT_IRQ_TYPE_EDGE_RISING - rising edge triggered - * DT_IRQ_TYPE_EDGE_FALLING - falling edge triggered - * DT_IRQ_TYPE_EDGE_BOTH - rising and falling edge triggered - * DT_IRQ_TYPE_LEVEL_HIGH - high level triggered - * DT_IRQ_TYPE_LEVEL_LOW - low level triggered - * DT_IRQ_TYPE_LEVEL_MASK - Mask to filter out the level bits - * DT_IRQ_TYPE_SENSE_MASK - Mask for all the above bits - * DT_IRQ_TYPE_INVALID - Use to initialize the type + * - DT_IRQ_TYPE_NONE - default, unspecified type + * - DT_IRQ_TYPE_EDGE_RISING - rising edge triggered + * - DT_IRQ_TYPE_EDGE_FALLING - falling edge triggered + * - DT_IRQ_TYPE_EDGE_BOTH - rising and falling edge triggered + * - DT_IRQ_TYPE_LEVEL_HIGH - high level triggered + * - DT_IRQ_TYPE_LEVEL_LOW - low level triggered + * - DT_IRQ_TYPE_LEVEL_MASK - Mask to filter out the level bits + * - DT_IRQ_TYPE_SENSE_MASK - Mask for all the above bits + * - DT_IRQ_TYPE_INVALID - Use to initialize the type */ #define DT_IRQ_TYPE_NONE 0x00000000 #define DT_IRQ_TYPE_EDGE_RISING 0x00000001 -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:49:45 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 23:49:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3pdp-0004Ix-ES; Thu, 06 Aug 2020 23:49:45 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3pdn-0004FE-MY for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 23:49:43 +0000 X-Inumbo-ID: c9ced62e-f05d-4d98-8091-18072f6dbee6 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c9ced62e-f05d-4d98-8091-18072f6dbee6; Thu, 06 Aug 2020 23:49:40 +0000 (UTC) Received: from sstabellini-ThinkPad-T480s.hsd1.ca.comcast.net (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 88F0B221E4; Thu, 6 Aug 2020 23:49:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596757780; bh=KF+NaTTtpfYKF6P4n5wsUKlOBm1SEFIE1xgAr22kRHk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rdpgL/a4tE+Lt7VhIMXKv9y3N2e2bTVq3IPq4PPYaUzy7fHsd8KuzceRDYvbkd8I0 O+EbWVsWb6F/eAT1PXP9YKvMBG545AB7MHqg0j9mLNlaZ5tkElb//7MDVve8H7/x1/ +kWjEmrt52zZ7cB24gxQNgTAcNwDQ7V/SrRn6RIE= From: Stefano Stabellini To: xen-devel@lists.xenproject.org Subject: [PATCH 06/14] kernel-doc: public/grant_table.h Date: Thu, 6 Aug 2020 16:49:25 -0700 Message-Id: <20200806234933.16448-6-sstabellini@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: sstabellini@kernel.org, julien@xen.org, wl@xen.org, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, Stefano Stabellini Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Stefano Stabellini Convert in-code comments to kernel-doc format wherever possible. Signed-off-by: Stefano Stabellini --- xen/include/public/grant_table.h | 443 ++++++++++++++++++------------- 1 file changed, 257 insertions(+), 186 deletions(-) diff --git a/xen/include/public/grant_table.h b/xen/include/public/grant_table.h index 3b7bf93d74..e461458225 100644 --- a/xen/include/public/grant_table.h +++ b/xen/include/public/grant_table.h @@ -30,8 +30,8 @@ #include "xen.h" -/* - * `incontents 150 gnttab Grant Tables +/** + * DOC: Grant Tables * * Xen's grant tables provide a generic mechanism to memory sharing * between domains. This shared memory interface underpins the split @@ -53,11 +53,10 @@ * fully virtualised memory. */ -/*********************************** - * GRANT TABLE REPRESENTATION - */ - -/* Some rough guidelines on accessing and updating grant-table entries +/** + * DOC: GRANT TABLE REPRESENTATION + * + * Some rough guidelines on accessing and updating grant-table entries * in a concurrency-safe manner. For more information, Linux contains a * reference implementation for guest OSes (drivers/xen/grant_table.c, see * http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=drivers/xen/grant-table.c;hb=HEAD @@ -108,56 +107,66 @@ * Use SMP-safe bit-setting instruction. */ -/* +/** + * typedef * Reference to a grant entry in a specified domain's grant table. */ typedef uint32_t grant_ref_t; -/* +/** + * DOC: grant table + * * A grant table comprises a packed array of grant entries in one or more * page frames shared between Xen and a guest. * [XEN]: This field is written by Xen and read by the sharing guest. * [GST]: This field is written by the guest and read by Xen. */ -/* - * Version 1 of the grant table entry structure is maintained purely - * for backwards compatibility. New guests should use version 2. - */ #if __XEN_INTERFACE_VERSION__ < 0x0003020a #define grant_entry_v1 grant_entry #define grant_entry_v1_t grant_entry_t #endif +/** + * struct grant_entry_v1 + * + * Version 1 of the grant table entry structure is maintained purely + * for backwards compatibility. New guests should use version 2. + */ struct grant_entry_v1 { - /* GTF_xxx: various type and flag information. [XEN,GST] */ + /** @flags: GTF_xxx, various type and flag information. [XEN,GST] */ uint16_t flags; - /* The domain being granted foreign privileges. [GST] */ + /** @domid: The domain being granted foreign privileges. [GST] */ domid_t domid; - /* - * GTF_permit_access: GFN that @domid is allowed to map and access. [GST] - * GTF_accept_transfer: GFN that @domid is allowed to transfer into. [GST] - * GTF_transfer_completed: MFN whose ownership transferred by @domid - * (non-translated guests only). [XEN] + /** + * @frame: + * - GTF_permit_access: GFN that @domid is allowed to map and access. [GST] + * - GTF_accept_transfer: GFN that @domid is allowed to transfer into. [GST] + * - GTF_transfer_completed: MFN whose ownership transferred by @domid + * (non-translated guests only). [XEN] */ uint32_t frame; }; typedef struct grant_entry_v1 grant_entry_v1_t; -/* The first few grant table entries will be preserved across grant table +/** + * DOC: GNTTAB_NR_RESERVED_ENTRIES + * + * The first few grant table entries will be preserved across grant table * version changes and may be pre-populated at domain creation by tools. */ #define GNTTAB_NR_RESERVED_ENTRIES 8 #define GNTTAB_RESERVED_CONSOLE 0 #define GNTTAB_RESERVED_XENSTORE 1 -/* - * Type of grant entry. - * GTF_invalid: This grant entry grants no privileges. - * GTF_permit_access: Allow @domid to map/access @frame. - * GTF_accept_transfer: Allow @domid to transfer ownership of one page frame - * to this guest. Xen writes the page number to @frame. - * GTF_transitive: Allow @domid to transitively access a subrange of - * @trans_grant in @trans_domid. No mappings are allowed. +/** + * DOC: Type of grant entry. + * + * - GTF_invalid: This grant entry grants no privileges. + * - GTF_permit_access: Allow @domid to map/access @frame. + * - GTF_accept_transfer: Allow @domid to transfer ownership of one page frame + * to this guest. Xen writes the page number to @frame. + * - GTF_transitive: Allow @domid to transitively access a subrange of + * @trans_grant in @trans_domid. No mappings are allowed. */ #define GTF_invalid (0U<<0) #define GTF_permit_access (1U<<0) @@ -165,15 +174,16 @@ typedef struct grant_entry_v1 grant_entry_v1_t; #define GTF_transitive (3U<<0) #define GTF_type_mask (3U<<0) -/* - * Subflags for GTF_permit_access. - * GTF_readonly: Restrict @domid to read-only mappings and accesses. [GST] - * GTF_reading: Grant entry is currently mapped for reading by @domid. [XEN] - * GTF_writing: Grant entry is currently mapped for writing by @domid. [XEN] - * GTF_PAT, GTF_PWT, GTF_PCD: (x86) cache attribute flags for the grant [GST] - * GTF_sub_page: Grant access to only a subrange of the page. @domid - * will only be allowed to copy from the grant, and not - * map it. [GST] +/** + * DOC: Subflags for GTF_permit_access. + * + * - GTF_readonly: Restrict @domid to read-only mappings and accesses. [GST] + * - GTF_reading: Grant entry is currently mapped for reading by @domid. [XEN] + * - GTF_writing: Grant entry is currently mapped for writing by @domid. [XEN] + * - GTF_PAT, GTF_PWT, GTF_PCD: (x86) cache attribute flags for the grant [GST] + * - GTF_sub_page: Grant access to only a subrange of the page. @domid + * will only be allowed to copy from the grant, and not + * map it. [GST] */ #define _GTF_readonly (2) #define GTF_readonly (1U<<_GTF_readonly) @@ -190,8 +200,9 @@ typedef struct grant_entry_v1 grant_entry_v1_t; #define _GTF_sub_page (8) #define GTF_sub_page (1U<<_GTF_sub_page) -/* - * Subflags for GTF_accept_transfer: +/** + * DOC: Subflags for GTF_accept_transfer: + * * GTF_transfer_committed: Xen sets this flag to indicate that it is committed * to transferring ownership of a page frame. When a guest sees this flag * it must /not/ modify the grant entry until GTF_transfer_completed is @@ -205,38 +216,43 @@ typedef struct grant_entry_v1 grant_entry_v1_t; #define _GTF_transfer_completed (3) #define GTF_transfer_completed (1U<<_GTF_transfer_completed) -/* - * Version 2 grant table entries. These fulfil the same role as - * version 1 entries, but can represent more complicated operations. - * Any given domain will have either a version 1 or a version 2 table, - * and every entry in the table will be the same version. +#if __XEN_INTERFACE_VERSION__ >= 0x0003020a +/** + * DOC: Version 2 grant table entries + * + * These fulfil the same role as version 1 entries, but can represent + * more complicated operations. Any given domain will have either a + * version 1 or a version 2 table, and every entry in the table will be + * the same version. * * The interface by which domains use grant references does not depend * on the grant table version in use by the other domain. - */ -#if __XEN_INTERFACE_VERSION__ >= 0x0003020a -/* + * * Version 1 and version 2 grant entries share a common prefix. The * fields of the prefix are documented as part of struct * grant_entry_v1. */ +/** + * struct grant_entry_header + */ struct grant_entry_header { uint16_t flags; domid_t domid; }; typedef struct grant_entry_header grant_entry_header_t; -/* - * Version 2 of the grant entry structure. +/** + * union grant_entry_v2 - Version 2 of the grant entry structure. */ union grant_entry_v2 { grant_entry_header_t hdr; - /* + /** + * @full_page: * This member is used for V1-style full page grants, where either: * - * -- hdr.type is GTF_accept_transfer, or - * -- hdr.type is GTF_permit_access and GTF_sub_page is not set. + * - hdr.type is GTF_accept_transfer, or + * - hdr.type is GTF_permit_access and GTF_sub_page is not set. * * In that case, the frame field has the same semantics as the * field of the same name in the V1 entry structure. @@ -247,7 +263,9 @@ union grant_entry_v2 { uint64_t frame; } full_page; - /* + /** + * @sub_page: + * * If the grant type is GTF_grant_access and GTF_sub_page is set, * @domid is allowed to access bytes [@page_off,@page_off+@length) * in frame @frame. @@ -259,7 +277,9 @@ union grant_entry_v2 { uint64_t frame; } sub_page; - /* + /** + * @transitive: + * * If the grant is GTF_transitive, @domid is allowed to use the * grant @gref in domain @trans_domid, as if it was the local * domain. Obviously, the transitive access must be compatible @@ -275,7 +295,8 @@ union grant_entry_v2 { grant_ref_t gref; } transitive; - uint32_t __spacer[4]; /* Pad to a power of two */ + /** @__spacer: Pad to a power of two */ + uint32_t __spacer[4]; }; typedef union grant_entry_v2 grant_entry_v2_t; @@ -283,16 +304,14 @@ typedef uint16_t grant_status_t; #endif /* __XEN_INTERFACE_VERSION__ */ -/*********************************** - * GRANT TABLE QUERIES AND USES - */ - -/* ` enum neg_errnoval - * ` HYPERVISOR_grant_table_op(enum grant_table_op cmd, - * ` void *args, - * ` unsigned int count) - * ` +/** + * DOC: GRANT TABLE QUERIES AND USES * + * enum neg_errnoval + * HYPERVISOR_grant_table_op(enum grant_table_op cmd, + * void *args, + * unsigned int count) + * * @args points to an array of a per-command data structure. The array * has @count members */ @@ -315,16 +334,19 @@ typedef uint16_t grant_status_t; #endif /* __XEN_INTERFACE_VERSION__ */ /* ` } */ -/* +/** + * typedef * Handle to track a mapping created via a grant reference. */ typedef uint32_t grant_handle_t; -/* - * GNTTABOP_map_grant_ref: Map the grant entry (,) for access - * by devices and/or host CPUs. If successful, is a tracking number - * that must be presented later to destroy the mapping(s). On error, - * is a negative status code. +/** + * struct gnttab_map_grant_ref - GNTTABOP_map_grant_ref + * + * Map the grant entry (,) for access by devices and/or host + * CPUs. If successful, is a tracking number that must be + * presented later to destroy the mapping(s). On error, is a + * negative status code. * NOTES: * 1. If GNTMAP_device_map is specified then is the address * via which I/O devices may access the granted frame. @@ -338,24 +360,31 @@ typedef uint32_t grant_handle_t; * to be accounted to the correct grant reference! */ struct gnttab_map_grant_ref { - /* IN parameters. */ + /** @host_addr: IN parameter */ uint64_t host_addr; - uint32_t flags; /* GNTMAP_* */ + /** @flags: IN parameter, GNTMAP_* */ + uint32_t flags; + /** @ref: IN parameter */ grant_ref_t ref; + /** @dom: IN parameter */ domid_t dom; - /* OUT parameters. */ - int16_t status; /* => enum grant_status */ + /** @status: OUT parameter, enum grant_status */ + int16_t status; + /** @handle: OUT parameter */ grant_handle_t handle; + /** @dev_bus_addr: OUT parameter */ uint64_t dev_bus_addr; }; typedef struct gnttab_map_grant_ref gnttab_map_grant_ref_t; DEFINE_XEN_GUEST_HANDLE(gnttab_map_grant_ref_t); -/* - * GNTTABOP_unmap_grant_ref: Destroy one or more grant-reference mappings - * tracked by . If or is zero, that - * field is ignored. If non-zero, they must refer to a device/host mapping - * that is tracked by +/** + * struct gnttab_unmap_grant_ref - GNTTABOP_unmap_grant_ref + * + * Destroy one or more grant-reference mappings tracked by . If + * or is zero, that field is ignored. If + * non-zero, they must refer to a device/host mapping that is tracked by + * * NOTES: * 1. The call may fail in an undefined manner if either mapping is not * tracked by . @@ -363,31 +392,37 @@ DEFINE_XEN_GUEST_HANDLE(gnttab_map_grant_ref_t); * mappings will remain in the device or host TLBs. */ struct gnttab_unmap_grant_ref { - /* IN parameters. */ + /** @host_addr: IN parameter */ uint64_t host_addr; + /** @dev_bus_addr: IN parameter */ uint64_t dev_bus_addr; + /** @handle: IN parameter */ grant_handle_t handle; - /* OUT parameters. */ - int16_t status; /* => enum grant_status */ + /** @status: OUT parameter, enum grant_status */ + int16_t status; }; typedef struct gnttab_unmap_grant_ref gnttab_unmap_grant_ref_t; DEFINE_XEN_GUEST_HANDLE(gnttab_unmap_grant_ref_t); -/* - * GNTTABOP_setup_table: Set up a grant table for comprising at least - * pages. The frame addresses are written to the . - * Only addresses are written, even if the table is larger. +/** + * struct gnttab_setup_table - GNTTABOP_setup_table + * + * Set up a grant table for comprising at least pages. + * The frame addresses are written to the . Only + * addresses are written, even if the table is larger. * NOTES: * 1. may be specified as DOMID_SELF. * 2. Only a sufficiently-privileged domain may specify != DOMID_SELF. * 3. Xen may not support more than a single grant-table page per domain. */ struct gnttab_setup_table { - /* IN parameters. */ + /** @dom: IN parameter */ domid_t dom; + /** @nr_frames: IN parameter */ uint32_t nr_frames; - /* OUT parameters. */ + /** @status: OUT parameter */ int16_t status; /* => enum grant_status */ + /** @frame_list: OUT parameter */ #if __XEN_INTERFACE_VERSION__ < 0x00040300 XEN_GUEST_HANDLE(ulong) frame_list; #else @@ -397,21 +432,25 @@ struct gnttab_setup_table { typedef struct gnttab_setup_table gnttab_setup_table_t; DEFINE_XEN_GUEST_HANDLE(gnttab_setup_table_t); -/* - * GNTTABOP_dump_table: Dump the contents of the grant table to the - * xen console. Debugging use only. +/** + * struct gnttab_dump_table - GNTTABOP_dump_table + * + * Dump the contents of the grant table to the xen console. Debugging + * use only. */ struct gnttab_dump_table { - /* IN parameters. */ + /** @dom: IN parameter */ domid_t dom; - /* OUT parameters. */ - int16_t status; /* => enum grant_status */ + /** @status: OUT parameter, enum grant_status */ + int16_t status; }; typedef struct gnttab_dump_table gnttab_dump_table_t; DEFINE_XEN_GUEST_HANDLE(gnttab_dump_table_t); -/* - * GNTTABOP_transfer: Transfer to a foreign domain. The foreign domain +/** + * struct gnttab_transfer - GNTTABOP_transfer + * + * Transfer to a foreign domain. The foreign domain * has previously registered its interest in the transfer via . * * Note that, even if the transfer fails, the specified page no longer belongs @@ -420,19 +459,26 @@ DEFINE_XEN_GUEST_HANDLE(gnttab_dump_table_t); * Note further that only PV guests can use this operation. */ struct gnttab_transfer { - /* IN parameters. */ + /** @mfn: IN parameter */ xen_pfn_t mfn; + /** @domid: IN parameter */ domid_t domid; + /** @ref: IN parameter */ grant_ref_t ref; - /* OUT parameters. */ + /** @status: OUT parameter */ int16_t status; }; typedef struct gnttab_transfer gnttab_transfer_t; DEFINE_XEN_GUEST_HANDLE(gnttab_transfer_t); -/* - * GNTTABOP_copy: Hypervisor based copy +#define _GNTCOPY_source_gref (0) +#define GNTCOPY_source_gref (1<<_GNTCOPY_source_gref) +#define _GNTCOPY_dest_gref (1) +#define GNTCOPY_dest_gref (1<<_GNTCOPY_dest_gref) +/** + * struct gnttab_copy - GNTTABOP_copy, Hypervisor based copy + * * source and destinations can be eithers MFNs or, for foreign domains, * grant references. the foreign domain has to grant read/write access * in its grant table. @@ -448,14 +494,9 @@ DEFINE_XEN_GUEST_HANDLE(gnttab_transfer_t); * the offset in the target frame and len specifies the number of * bytes to be copied. */ - -#define _GNTCOPY_source_gref (0) -#define GNTCOPY_source_gref (1<<_GNTCOPY_source_gref) -#define _GNTCOPY_dest_gref (1) -#define GNTCOPY_dest_gref (1<<_GNTCOPY_dest_gref) - struct gnttab_copy { - /* IN parameters. */ + /** @source: IN parameter */ + /** @dest: IN parameter */ struct gnttab_copy_ptr { union { grant_ref_t ref; @@ -464,37 +505,44 @@ struct gnttab_copy { domid_t domid; uint16_t offset; } source, dest; + /** @len: IN parameter */ uint16_t len; - uint16_t flags; /* GNTCOPY_* */ - /* OUT parameters. */ + /** @flags: IN parameter, GNTCOPY_* */ + uint16_t flags; + /** @status: OUT parameters. */ int16_t status; }; typedef struct gnttab_copy gnttab_copy_t; DEFINE_XEN_GUEST_HANDLE(gnttab_copy_t); -/* - * GNTTABOP_query_size: Query the current and maximum sizes of the shared - * grant table. +/** + * struct gnttab_query_size - GNTTABOP_query_size + * + * Query the current and maximum sizes of the shared grant table. * NOTES: * 1. may be specified as DOMID_SELF. * 2. Only a sufficiently-privileged domain may specify != DOMID_SELF. */ struct gnttab_query_size { - /* IN parameters. */ + /** @dom: IN parameter */ domid_t dom; - /* OUT parameters. */ + /** @nr_frames: OUT parameter */ uint32_t nr_frames; + /** @max_nr_frames: OUT parameter */ uint32_t max_nr_frames; - int16_t status; /* => enum grant_status */ + /** @status: OUT parameter, enum grant_status */ + int16_t status; }; typedef struct gnttab_query_size gnttab_query_size_t; DEFINE_XEN_GUEST_HANDLE(gnttab_query_size_t); -/* - * GNTTABOP_unmap_and_replace: Destroy one or more grant-reference mappings - * tracked by but atomically replace the page table entry with one - * pointing to the machine address under . will be - * redirected to the null entry. +/** + * struct gnttab_unmap_and_replace - GNTTABOP_unmap_and_replace + * + * Destroy one or more grant-reference mappings tracked by but + * atomically replace the page table entry with one pointing to the + * machine address under . will be redirected to + * the null entry. * NOTES: * 1. The call may fail in an undefined manner if either mapping is not * tracked by . @@ -502,36 +550,42 @@ DEFINE_XEN_GUEST_HANDLE(gnttab_query_size_t); * mappings will remain in the device or host TLBs. */ struct gnttab_unmap_and_replace { - /* IN parameters. */ + /** @host_addr: IN parameter */ uint64_t host_addr; + /** @new_addr: IN parameter */ uint64_t new_addr; + /** @handle: IN parameter */ grant_handle_t handle; - /* OUT parameters. */ - int16_t status; /* => enum grant_status */ + /** @status: OUT parameter, enum grant_status */ + int16_t status; }; typedef struct gnttab_unmap_and_replace gnttab_unmap_and_replace_t; DEFINE_XEN_GUEST_HANDLE(gnttab_unmap_and_replace_t); #if __XEN_INTERFACE_VERSION__ >= 0x0003020a -/* - * GNTTABOP_set_version: Request a particular version of the grant - * table shared table structure. This operation may be used to toggle - * between different versions, but must be performed while no grants - * are active. The only defined versions are 1 and 2. +/** + * struct gnttab_set_version - GNTTABOP_set_version + * + * Request a particular version of the grant table shared table + * structure. This operation may be used to toggle between different + * versions, but must be performed while no grants are active. The only + * defined versions are 1 and 2. */ struct gnttab_set_version { - /* IN/OUT parameters */ + /** @version: IN/OUT parameter */ uint32_t version; }; typedef struct gnttab_set_version gnttab_set_version_t; DEFINE_XEN_GUEST_HANDLE(gnttab_set_version_t); -/* - * GNTTABOP_get_status_frames: Get the list of frames used to store grant - * status for . In grant format version 2, the status is separated - * from the other shared grant fields to allow more efficient synchronization - * using barriers instead of atomic cmpexch operations. +/** + * struct gnttab_get_status_frames - GNTTABOP_get_status_frames + * + * Get the list of frames used to store grant status for . In grant + * format version 2, the status is separated from the other shared grant + * fields to allow more efficient synchronization using barriers instead + * of atomic cmpexch operations. * specify the size of vector . * The frame addresses are returned in the . * Only addresses are returned, even if the table is larger. @@ -540,44 +594,53 @@ DEFINE_XEN_GUEST_HANDLE(gnttab_set_version_t); * 2. Only a sufficiently-privileged domain may specify != DOMID_SELF. */ struct gnttab_get_status_frames { - /* IN parameters. */ + /** @nr_frames: IN parameter */ uint32_t nr_frames; + /** @dom: IN parameter */ domid_t dom; - /* OUT parameters. */ - int16_t status; /* => enum grant_status */ + /** @status: OUT parameter, enum grant_status */ + int16_t status; + /** @frame_list: OUT parameter */ XEN_GUEST_HANDLE(uint64_t) frame_list; }; typedef struct gnttab_get_status_frames gnttab_get_status_frames_t; DEFINE_XEN_GUEST_HANDLE(gnttab_get_status_frames_t); -/* - * GNTTABOP_get_version: Get the grant table version which is in - * effect for domain . +/** + * struct gnttab_get_version - GNTTABOP_get_version + * + * Get the grant table version which is in effect for domain . */ struct gnttab_get_version { - /* IN parameters */ + /** @dom: IN parameters */ domid_t dom; + /** @pad: padding */ uint16_t pad; - /* OUT parameters */ + /** @version: OUT parameter */ uint32_t version; }; typedef struct gnttab_get_version gnttab_get_version_t; DEFINE_XEN_GUEST_HANDLE(gnttab_get_version_t); -/* - * GNTTABOP_swap_grant_ref: Swap the contents of two grant entries. +/** + * struct gnttab_swap_grant_ref - GNTTABOP_swap_grant_ref + * + * Swap the contents of two grant entries. */ struct gnttab_swap_grant_ref { - /* IN parameters */ + /** @ref_a: IN parameter */ grant_ref_t ref_a; + /** @ref_b: IN parameter */ grant_ref_t ref_b; - /* OUT parameters */ - int16_t status; /* => enum grant_status */ + /** @status: OUT parameter, enum grant_status */ + int16_t status; }; typedef struct gnttab_swap_grant_ref gnttab_swap_grant_ref_t; DEFINE_XEN_GUEST_HANDLE(gnttab_swap_grant_ref_t); -/* +/** + * struct gnttab_cache_flush - GNTTABOP_cache_flush + * * Issue one or more cache maintenance operations on a portion of a * page granted to the calling domain by a foreign domain. */ @@ -598,61 +661,69 @@ DEFINE_XEN_GUEST_HANDLE(gnttab_cache_flush_t); #endif /* __XEN_INTERFACE_VERSION__ */ -/* - * Bitfield values for gnttab_map_grant_ref.flags. +/** + * DOC: Bitfield values for gnttab_map_grant_ref.flags. + * + * - GNTMAP_device_map: Map the grant entry for access by I/O devices. + * - GNTMAP_host_map: Map the grant entry for access by host CPUs. + * - GNTMAP_readonly: Accesses to the granted frame will be restricted to read-only access. + * - GNTMAP_host_map: 0 => The host mapping is usable only by the guest OS + * 1 => The host mapping is usable by guest OS + current application. + * - GNTMAP_contains_pte: 0 => This map request contains a host virtual address. + * 1 => This map request contains the machine addess of the PTE to update. + * - GNTMAP_can_fail + * - GNTMAP_guest_avail_mask: Bits to be placed in guest kernel available PTE bits + * (architecture dependent; only supported when + * XENFEAT_gnttab_map_avail_bits is set). */ - /* Map the grant entry for access by I/O devices. */ #define _GNTMAP_device_map (0) #define GNTMAP_device_map (1<<_GNTMAP_device_map) - /* Map the grant entry for access by host CPUs. */ #define _GNTMAP_host_map (1) #define GNTMAP_host_map (1<<_GNTMAP_host_map) - /* Accesses to the granted frame will be restricted to read-only access. */ #define _GNTMAP_readonly (2) #define GNTMAP_readonly (1<<_GNTMAP_readonly) - /* - * GNTMAP_host_map subflag: - * 0 => The host mapping is usable only by the guest OS. - * 1 => The host mapping is usable by guest OS + current application. - */ #define _GNTMAP_application_map (3) #define GNTMAP_application_map (1<<_GNTMAP_application_map) - - /* - * GNTMAP_contains_pte subflag: - * 0 => This map request contains a host virtual address. - * 1 => This map request contains the machine addess of the PTE to update. - */ #define _GNTMAP_contains_pte (4) #define GNTMAP_contains_pte (1<<_GNTMAP_contains_pte) - #define _GNTMAP_can_fail (5) #define GNTMAP_can_fail (1<<_GNTMAP_can_fail) - -/* - * Bits to be placed in guest kernel available PTE bits (architecture - * dependent; only supported when XENFEAT_gnttab_map_avail_bits is set). - */ #define _GNTMAP_guest_avail0 (16) #define GNTMAP_guest_avail_mask ((uint32_t)~0 << _GNTMAP_guest_avail0) -/* - * Values for error status returns. All errors are -ve. +/** + * DOC: Values for error status returns. All errors are -ve. + * + * + * - GNTST_okay: Normal return. + * - GNTST_general_error: General undefined error. + * - GNTST_bad_domain: Unrecognsed domain id. + * - GNTST_bad_gntref: Unrecognised or inappropriate gntref. + * - GNTST_bad_handle: Unrecognised or inappropriate handle. + * - GNTST_bad_virt_addr: Inappropriate virtual address to map. + * - GNTST_bad_dev_addr: Inappropriate device address to unmap. + * - GNTST_no_device_space: Out of space in I/O MMU. + * - GNTST_permission_denied: Not enough privilege for operation. + * - GNTST_bad_page: Specified page was invalid for op. + * - GNTST_bad_copy_arg: copy arguments cross page boundary. + * - GNTST_address_too_big: transfer page address too large. + * - GNTST_eagain: Operation not done; try again. + * */ /* ` enum grant_status { */ -#define GNTST_okay (0) /* Normal return. */ -#define GNTST_general_error (-1) /* General undefined error. */ -#define GNTST_bad_domain (-2) /* Unrecognsed domain id. */ -#define GNTST_bad_gntref (-3) /* Unrecognised or inappropriate gntref. */ -#define GNTST_bad_handle (-4) /* Unrecognised or inappropriate handle. */ -#define GNTST_bad_virt_addr (-5) /* Inappropriate virtual address to map. */ -#define GNTST_bad_dev_addr (-6) /* Inappropriate device address to unmap.*/ -#define GNTST_no_device_space (-7) /* Out of space in I/O MMU. */ -#define GNTST_permission_denied (-8) /* Not enough privilege for operation. */ -#define GNTST_bad_page (-9) /* Specified page was invalid for op. */ -#define GNTST_bad_copy_arg (-10) /* copy arguments cross page boundary. */ -#define GNTST_address_too_big (-11) /* transfer page address too large. */ -#define GNTST_eagain (-12) /* Operation not done; try again. */ +#define GNTST_okay (0) +#define GNTST_general_error (-1) +#define GNTST_bad_domain (-2) +#define GNTST_bad_gntref (-3) +#define GNTST_bad_handle (-4) +#define GNTST_bad_virt_addr (-5) +#define GNTST_bad_dev_addr (-6) +#define GNTST_no_device_space (-7) +#define GNTST_permission_denied (-8) +#define GNTST_bad_page (-9) +#define GNTST_bad_copy_arg (-10) +#define GNTST_address_too_big (-11) +#define GNTST_eagain (-12) /* ` } */ #define GNTTABOP_error_msgs { \ -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:49:50 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 23:49:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3pdt-0004Mn-Vj; Thu, 06 Aug 2020 23:49:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3pds-0004FC-KX for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 23:49:48 +0000 X-Inumbo-ID: 917eb6cc-950b-4155-96f7-ae1c6209ab86 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 917eb6cc-950b-4155-96f7-ae1c6209ab86; Thu, 06 Aug 2020 23:49:39 +0000 (UTC) Received: from sstabellini-ThinkPad-T480s.hsd1.ca.comcast.net (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7716522D01; Thu, 6 Aug 2020 23:49:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596757778; bh=cE/8MB3BpG4nT+iCEeN/zJiUoBtOO+C3o59h9hTnhyw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=M6SOR+q4lzAjtT2DpFvyBZYneDI0oJyCm6ObiDP1yKWgGb+g/eSlfGCU1iRSyETJG g13bkWEkwfGFTQATeuYuqp+bEbEOsTvfI7yizT/6+/Ne2tmVt5ZPpQjtcYXjM9V8L2 arEEh76pTWR0cq0bpV8wqWE/CO24PvhzjqY19QpU= From: Stefano Stabellini To: xen-devel@lists.xenproject.org Subject: [PATCH 04/14] kernel-doc: public/event_channel.h Date: Thu, 6 Aug 2020 16:49:23 -0700 Message-Id: <20200806234933.16448-4-sstabellini@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: sstabellini@kernel.org, julien@xen.org, wl@xen.org, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, Stefano Stabellini Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Stefano Stabellini Convert in-code comments to kernel-doc format wherever possible. Signed-off-by: Stefano Stabellini --- xen/include/public/event_channel.h | 188 +++++++++++++++++++---------- 1 file changed, 121 insertions(+), 67 deletions(-) diff --git a/xen/include/public/event_channel.h b/xen/include/public/event_channel.h index cfb7929fef..893ea744d4 100644 --- a/xen/include/public/event_channel.h +++ b/xen/include/public/event_channel.h @@ -29,8 +29,8 @@ #include "xen.h" -/* - * `incontents 150 evtchn Event Channels +/** + * DOC: Event Channels * * Event channels are the basic primitive provided by Xen for event * notifications. An event is the Xen equivalent of a hardware @@ -79,27 +79,34 @@ typedef uint32_t evtchn_port_t; DEFINE_XEN_GUEST_HANDLE(evtchn_port_t); -/* - * EVTCHNOP_alloc_unbound: Allocate a port in domain and mark as - * accepting interdomain bindings from domain . A fresh port - * is allocated in and returned as . +/** + * struct evtchn_alloc_unbound - EVTCHNOP_alloc_unbound + * + * Allocate a port in domain and mark as accepting interdomain + * bindings from domain . A fresh port is allocated in + * and returned as . + * * NOTES: * 1. If the caller is unprivileged then must be DOMID_SELF. * 2. may be DOMID_SELF, allowing loopback connections. */ struct evtchn_alloc_unbound { - /* IN parameters */ - domid_t dom, remote_dom; - /* OUT parameters */ + /** @dom: IN parameter */ + domid_t dom; + /** @remote_dom: IN parameter */ + domid_t remote_dom; + /** @port: OUT parameter */ evtchn_port_t port; }; typedef struct evtchn_alloc_unbound evtchn_alloc_unbound_t; -/* - * EVTCHNOP_bind_interdomain: Construct an interdomain event channel between - * the calling domain and . must identify - * a port that is unbound and marked as accepting bindings from the calling - * domain. A fresh port is allocated in the calling domain and returned as +/** + * struct evtchn_bind_interdomain - EVTCHNOP_bind_interdomain + * + * Construct an interdomain event channel between the calling domain and + * . must identify a port that is + * unbound and marked as accepting bindings from the calling domain. A + * fresh port is allocated in the calling domain and returned as * . * * In case the peer domain has already tried to set our event channel @@ -116,17 +123,20 @@ typedef struct evtchn_alloc_unbound evtchn_alloc_unbound_t; * 1. may be DOMID_SELF, allowing loopback connections. */ struct evtchn_bind_interdomain { - /* IN parameters. */ + /** @remote_dom: IN parameter */ domid_t remote_dom; + /** @remote_port: IN parameter */ evtchn_port_t remote_port; - /* OUT parameters. */ + /** @local_port:OUT parameter */ evtchn_port_t local_port; }; typedef struct evtchn_bind_interdomain evtchn_bind_interdomain_t; -/* - * EVTCHNOP_bind_virq: Bind a local event channel to VIRQ on specified - * vcpu. +/** + * struct evtchn_bind_virq - EVTCHNOP_bind_virq + * + * Bind a local event channel to VIRQ on specified vcpu. + * * NOTES: * 1. Virtual IRQs are classified as per-vcpu or global. See the VIRQ list * in xen.h for the classification of each VIRQ. @@ -137,65 +147,78 @@ typedef struct evtchn_bind_interdomain evtchn_bind_interdomain_t; * binding cannot be changed. */ struct evtchn_bind_virq { - /* IN parameters. */ - uint32_t virq; /* enum virq */ + /** @virq: IN parameter, enum virq */ + uint32_t virq; + /** @vcpu: IN parameter */ uint32_t vcpu; - /* OUT parameters. */ + /** @port: OUT parameter */ evtchn_port_t port; }; typedef struct evtchn_bind_virq evtchn_bind_virq_t; -/* - * EVTCHNOP_bind_pirq: Bind a local event channel to a real IRQ (PIRQ ). +/** + * struct evtchn_bind_pirq - EVTCHNOP_bind_pirq + * + * Bind a local event channel to a real IRQ (PIRQ ). * NOTES: * 1. A physical IRQ may be bound to at most one event channel per domain. * 2. Only a sufficiently-privileged domain may bind to a physical IRQ. */ struct evtchn_bind_pirq { - /* IN parameters. */ + /** @pirq: IN parameter */ uint32_t pirq; + /** @flags: IN parameter, BIND_PIRQ__* */ #define BIND_PIRQ__WILL_SHARE 1 - uint32_t flags; /* BIND_PIRQ__* */ - /* OUT parameters. */ + uint32_t flags; + /** @port: OUT parameter */ evtchn_port_t port; }; typedef struct evtchn_bind_pirq evtchn_bind_pirq_t; -/* - * EVTCHNOP_bind_ipi: Bind a local event channel to receive events. +/** + * struct struct evtchn_bind_ipi - EVTCHNOP_bind_ipi + * + * Bind a local event channel to receive events. * NOTES: * 1. The allocated event channel is bound to the specified vcpu. The binding * may not be changed. */ struct evtchn_bind_ipi { + /** @vcpu: IN parameter */ uint32_t vcpu; - /* OUT parameters. */ + /** @port: OUT parameter */ evtchn_port_t port; }; typedef struct evtchn_bind_ipi evtchn_bind_ipi_t; -/* - * EVTCHNOP_close: Close a local event channel . If the channel is - * interdomain then the remote end is placed in the unbound state +/** + * struct evtchn_close - EVTCHNOP_close + * + * Close a local event channel . If the channel is interdomain + * then the remote end is placed in the unbound state * (EVTCHNSTAT_unbound), awaiting a new connection. */ struct evtchn_close { - /* IN parameters. */ + /** @port: IN parameter */ evtchn_port_t port; }; typedef struct evtchn_close evtchn_close_t; -/* - * EVTCHNOP_send: Send an event to the remote end of the channel whose local - * endpoint is . +/** + * struct evtchn_send - EVTCHNOP_send + * + * Send an event to the remote end of the channel whose local endpoint + * is . */ struct evtchn_send { - /* IN parameters. */ + /** @port: IN parameter */ evtchn_port_t port; }; typedef struct evtchn_send evtchn_send_t; -/* +/** + * struct evtchn_status - EVTCHNOP_status + * * EVTCHNOP_status: Get the current status of the communication channel which * has an endpoint at . * NOTES: @@ -204,10 +227,11 @@ typedef struct evtchn_send evtchn_send_t; * channel for which is not DOMID_SELF. */ struct evtchn_status { - /* IN parameters */ + /** @dom: IN parameter */ domid_t dom; + /** @port: IN parameter */ evtchn_port_t port; - /* OUT parameters */ + /** @status: OUT parameter */ #define EVTCHNSTAT_closed 0 /* Channel is not in use. */ #define EVTCHNSTAT_unbound 1 /* Channel is waiting interdom connection.*/ #define EVTCHNSTAT_interdomain 2 /* Channel is connected to remote domain. */ @@ -215,24 +239,39 @@ struct evtchn_status { #define EVTCHNSTAT_virq 4 /* Channel is bound to a virtual IRQ line */ #define EVTCHNSTAT_ipi 5 /* Channel is bound to a virtual IPI line */ uint32_t status; - uint32_t vcpu; /* VCPU to which this channel is bound. */ + /** @vcpu: OUT parameter, VCPU to which this channel is bound */ + uint32_t vcpu; + /** @u: OUT parameter */ union { + /** + * @u.unbound: EVTCHNSTAT_unbound + */ struct { domid_t dom; - } unbound; /* EVTCHNSTAT_unbound */ + } unbound; + /** + * @u.interdomain: EVTCHNSTAT_interdomain + */ struct { domid_t dom; evtchn_port_t port; - } interdomain; /* EVTCHNSTAT_interdomain */ - uint32_t pirq; /* EVTCHNSTAT_pirq */ - uint32_t virq; /* EVTCHNSTAT_virq */ + } interdomain; + /** + * @u.pirq: EVTCHNSTAT_pirq + */ + uint32_t pirq; + /** + * @u.virq: EVTCHNSTAT_virq + */ + uint32_t virq; } u; }; typedef struct evtchn_status evtchn_status_t; -/* - * EVTCHNOP_bind_vcpu: Specify which vcpu a channel should notify when an - * event is pending. +/** + * struct evtchn_bind_vcpu - EVTCHNOP_bind_vcpu + * + * Specify which vcpu a channel should notify when an event is pending. * NOTES: * 1. IPI-bound channels always notify the vcpu specified at bind time. * This binding cannot be changed. @@ -243,24 +282,29 @@ typedef struct evtchn_status evtchn_status_t; * has its binding reset to vcpu0). */ struct evtchn_bind_vcpu { - /* IN parameters. */ + /** @port: IN parameter */ evtchn_port_t port; + /** @vcpu: IN parameter */ uint32_t vcpu; }; typedef struct evtchn_bind_vcpu evtchn_bind_vcpu_t; -/* - * EVTCHNOP_unmask: Unmask the specified local event-channel port and deliver - * a notification to the appropriate VCPU if an event is pending. +/** + * struct evtchn_unmask - EVTCHNOP_unmask + * + * Unmask the specified local event-channel port and deliver a + * notification to the appropriate VCPU if an event is pending. */ struct evtchn_unmask { - /* IN parameters. */ + /** @port: IN parameter */ evtchn_port_t port; }; typedef struct evtchn_unmask evtchn_unmask_t; -/* - * EVTCHNOP_reset: Close all event channels associated with specified domain. +/** + * struct evtchn_reset - EVTCHNOP_reset + * + * Close all event channels associated with specified domain. * NOTES: * 1. may be specified as DOMID_SELF. * 2. Only a sufficiently-privileged domain may specify other than DOMID_SELF. @@ -270,44 +314,54 @@ typedef struct evtchn_unmask evtchn_unmask_t; * as these events are likely to be lost. */ struct evtchn_reset { - /* IN parameters. */ + /** @dom: IN parameter */ domid_t dom; }; typedef struct evtchn_reset evtchn_reset_t; -/* - * EVTCHNOP_init_control: initialize the control block for the FIFO ABI. +/** + * struct evtchn_init_control - EVTCHNOP_init_control + * + * Initialize the control block for the FIFO ABI. * * Note: any events that are currently pending will not be resent and * will be lost. Guests should call this before binding any event to * avoid losing any events. */ struct evtchn_init_control { - /* IN parameters. */ + /** @control_gfn: IN parameter */ uint64_t control_gfn; + /** @offset: IN parameter */ uint32_t offset; + /** @vcpu: IN parameter */ uint32_t vcpu; - /* OUT parameters. */ + /** @link_bits: OUT parameter */ uint8_t link_bits; + /** @_pad: padding */ uint8_t _pad[7]; }; typedef struct evtchn_init_control evtchn_init_control_t; -/* - * EVTCHNOP_expand_array: add an additional page to the event array. +/** + * struct evtchn_expand_array - EVTCHNOP_expand_array + * + * Add an additional page to the event array. */ struct evtchn_expand_array { - /* IN parameters. */ + /** @array_gfn: IN parameter */ uint64_t array_gfn; }; typedef struct evtchn_expand_array evtchn_expand_array_t; -/* - * EVTCHNOP_set_priority: set the priority for an event channel. +/** + * struct evtchn_set_priority - EVTCHNOP_set_priority + * + * Set the priority for an event channel. */ struct evtchn_set_priority { - /* IN parameters. */ + /** @port: IN parameter */ evtchn_port_t port; + /** @priority: IN parameter */ uint32_t priority; }; typedef struct evtchn_set_priority evtchn_set_priority_t; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:49:50 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 23:49:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3pdu-0004NB-AU; Thu, 06 Aug 2020 23:49:50 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3pds-0004FE-Ml for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 23:49:48 +0000 X-Inumbo-ID: 64cc51bb-e701-4fd5-b585-337cf1a47716 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 64cc51bb-e701-4fd5-b585-337cf1a47716; Thu, 06 Aug 2020 23:49:41 +0000 (UTC) Received: from sstabellini-ThinkPad-T480s.hsd1.ca.comcast.net (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9854122D0A; Thu, 6 Aug 2020 23:49:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596757781; bh=1i0A/yLeRs9Euo2cflhW8+2Che9bifUajcXNkMOKeGQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tfhsB1inKyz8eryNqcRz+jhO914SuQXY2t1YjsML6HAVwBm+YUw2HCSOBgutT1gV5 rDZnrJHVBJIErHF1AG1cSHH5PFwf4ohzT5XVt8lhjrpvYm6XPO2rdIEtXYm4rhownV HkAZV1Z31KMZbjiD7nVlo70eU1idlPlcly/PupqA= From: Stefano Stabellini To: xen-devel@lists.xenproject.org Subject: [PATCH 08/14] kernel-doc: public/memory.h Date: Thu, 6 Aug 2020 16:49:27 -0700 Message-Id: <20200806234933.16448-8-sstabellini@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: sstabellini@kernel.org, julien@xen.org, wl@xen.org, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, Stefano Stabellini Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Stefano Stabellini Convert in-code comments to kernel-doc format wherever possible. Signed-off-by: Stefano Stabellini --- xen/include/public/memory.h | 232 ++++++++++++++++++++++++------------ 1 file changed, 155 insertions(+), 77 deletions(-) diff --git a/xen/include/public/memory.h b/xen/include/public/memory.h index 21057ed78e..4c57ed213c 100644 --- a/xen/include/public/memory.h +++ b/xen/include/public/memory.h @@ -30,7 +30,9 @@ #include "xen.h" #include "physdev.h" -/* +/** + * DOC: XENMEM_increase_reservation and XENMEM_decrease_reservation + * * Increase or decrease the specified domain's memory reservation. Returns the * number of extents successfully allocated or freed. * arg == addr of struct xen_memory_reservation. @@ -40,29 +42,37 @@ #define XENMEM_populate_physmap 6 #if __XEN_INTERFACE_VERSION__ >= 0x00030209 -/* - * Maximum # bits addressable by the user of the allocated region (e.g., I/O - * devices often have a 32-bit limitation even in 64-bit systems). If zero - * then the user has no addressing restriction. This field is not used by - * XENMEM_decrease_reservation. +/** + * DOC: XENMEMF_* + * + * - XENMEMF_address_bits, XENMEMF_get_address_bits: + * Maximum # bits addressable by the user of the allocated region + * (e.g., I/O devices often have a 32-bit limitation even in 64-bit + * systems). If zero then the user has no addressing restriction. This + * field is not used by XENMEM_decrease_reservation. + * - XENMEMF_node, XENMEMF_get_node: NUMA node to allocate from + * - XENMEMF_populate_on_demand: Flag to populate physmap with populate-on-demand entries + * - XENMEMF_exact_node_request, XENMEMF_exact_node: Flag to request allocation only from the node specified + * - XENMEMF_vnode: Flag to indicate the node specified is virtual node */ #define XENMEMF_address_bits(x) (x) #define XENMEMF_get_address_bits(x) ((x) & 0xffu) -/* NUMA node to allocate from. */ #define XENMEMF_node(x) (((x) + 1) << 8) #define XENMEMF_get_node(x) ((((x) >> 8) - 1) & 0xffu) -/* Flag to populate physmap with populate-on-demand entries */ #define XENMEMF_populate_on_demand (1<<16) -/* Flag to request allocation only from the node specified */ #define XENMEMF_exact_node_request (1<<17) #define XENMEMF_exact_node(n) (XENMEMF_node(n) | XENMEMF_exact_node_request) -/* Flag to indicate the node specified is virtual node */ #define XENMEMF_vnode (1<<18) #endif +/** + * struct xen_memory_reservation + */ struct xen_memory_reservation { - /* + /** + * @extent_start: + * * XENMEM_increase_reservation: * OUT: MFN (*not* GMFN) bases of extents that were allocated * XENMEM_decrease_reservation: @@ -76,18 +86,20 @@ struct xen_memory_reservation { */ XEN_GUEST_HANDLE(xen_pfn_t) extent_start; - /* Number of extents, and size/alignment of each (2^extent_order pages). */ + /** @nr_extents: Number of extents, and size/alignment of each (2^extent_order pages). */ xen_ulong_t nr_extents; unsigned int extent_order; #if __XEN_INTERFACE_VERSION__ >= 0x00030209 - /* XENMEMF flags. */ + /** @mem_flags: XENMEMF flags. */ unsigned int mem_flags; #else unsigned int address_bits; #endif - /* + /** + * @domid: + * * Domain whose reservation is being changed. * Unprivileged domains can specify only DOMID_SELF. */ @@ -96,7 +108,10 @@ struct xen_memory_reservation { typedef struct xen_memory_reservation xen_memory_reservation_t; DEFINE_XEN_GUEST_HANDLE(xen_memory_reservation_t); -/* +#define XENMEM_exchange 11 +/** + * struct xen_memory_exchange - XENMEM_exchange + * * An atomic exchange of memory pages. If return code is zero then * @out.extent_list provides GMFNs of the newly-allocated memory. * Returns zero on complete success, otherwise a negative error code. @@ -105,15 +120,18 @@ DEFINE_XEN_GUEST_HANDLE(xen_memory_reservation_t); * * Note that only PV guests can use this operation. */ -#define XENMEM_exchange 11 struct xen_memory_exchange { - /* + /** + * @in: + * * [IN] Details of memory extents to be exchanged (GMFN bases). * Note that @in.address_bits is ignored and unused. */ struct xen_memory_reservation in; - /* + /** + * @out: + * * [IN/OUT] Details of new memory extents. * We require that: * 1. @in.domid == @out.domid @@ -125,7 +143,9 @@ struct xen_memory_exchange { */ struct xen_memory_reservation out; - /* + /** + * @nr_exchanged: + * * [OUT] Number of input extents that were successfully exchanged: * 1. The first @nr_exchanged input extents were successfully * deallocated. @@ -141,14 +161,18 @@ struct xen_memory_exchange { typedef struct xen_memory_exchange xen_memory_exchange_t; DEFINE_XEN_GUEST_HANDLE(xen_memory_exchange_t); -/* +/** + * DOC: XENMEM_maximum_ram_page + * * Returns the maximum machine frame number of mapped RAM in this system. * This command always succeeds (it never returns an error code). * arg == NULL. */ #define XENMEM_maximum_ram_page 2 -/* +/** + * DOC: XENMEM_current_reservation and XENMEM_maximum_reservation + * * Returns the current or maximum memory reservation, in pages, of the * specified domain (may be DOMID_SELF). Returns -ve errcode on failure. * arg == addr of domid_t. @@ -156,33 +180,43 @@ DEFINE_XEN_GUEST_HANDLE(xen_memory_exchange_t); #define XENMEM_current_reservation 3 #define XENMEM_maximum_reservation 4 -/* +/** + * DOC: XENMEM_maximum_gpfn + * * Returns the maximum GPFN in use by the guest, or -ve errcode on failure. */ #define XENMEM_maximum_gpfn 14 -/* +#define XENMEM_machphys_mfn_list 5 +/** + * struct xen_machphys_mfn_list - XENMEM_machphys_mfn_list + * * Returns a list of MFN bases of 2MB extents comprising the machine_to_phys * mapping table. Architectures which do not have a m2p table do not implement * this command. * arg == addr of xen_machphys_mfn_list_t. */ -#define XENMEM_machphys_mfn_list 5 struct xen_machphys_mfn_list { - /* + /** + * @max_extents: + * * Size of the 'extent_start' array. Fewer entries will be filled if the * machphys table is smaller than max_extents * 2MB. */ unsigned int max_extents; - /* + /** + * @extent_start: + * * Pointer to buffer to fill with list of extent starts. If there are * any large discontiguities in the machine address space, 2MB gaps in * the machphys table will be represented by an MFN base of zero. */ XEN_GUEST_HANDLE(xen_pfn_t) extent_start; - /* + /** + * @nr_extents: + * * Number of extents written to the above array. This will be smaller * than 'max_extents' if the machphys table is smaller than max_e * 2MB. */ @@ -191,7 +225,9 @@ struct xen_machphys_mfn_list { typedef struct xen_machphys_mfn_list xen_machphys_mfn_list_t; DEFINE_XEN_GUEST_HANDLE(xen_machphys_mfn_list_t); -/* +/** + * DOC: XENMEM_machphys_compat_mfn_list + * * For a compat caller, this is identical to XENMEM_machphys_mfn_list. * * For a non compat caller, this functions similarly to @@ -200,90 +236,115 @@ DEFINE_XEN_GUEST_HANDLE(xen_machphys_mfn_list_t); */ #define XENMEM_machphys_compat_mfn_list 25 -/* +#define XENMEM_machphys_mapping 12 +/** + * struct xen_machphys_mapping - XENMEM_machphys_mapping + * * Returns the location in virtual address space of the machine_to_phys * mapping table. Architectures which do not have a m2p table, or which do not * map it by default into guest address space, do not implement this command. * arg == addr of xen_machphys_mapping_t. */ -#define XENMEM_machphys_mapping 12 struct xen_machphys_mapping { + /** @v_start: Start virtual address */ xen_ulong_t v_start, v_end; /* Start and end virtual addresses. */ - xen_ulong_t max_mfn; /* Maximum MFN that can be looked up. */ + /** @v_end: End virtual addresses */ + xen_ulong_t v_end; + /** @max_mfn: Maximum MFN that can be looked up */ + xen_ulong_t max_mfn; }; typedef struct xen_machphys_mapping xen_machphys_mapping_t; DEFINE_XEN_GUEST_HANDLE(xen_machphys_mapping_t); -/* Source mapping space. */ +/** + * DOC: Source mapping space. + * + * - XENMAPSPACE_shared_info: shared info page + * - XENMAPSPACE_grant_table: grant table page + * - XENMAPSPACE_gmfn: GMFN + * - XENMAPSPACE_gmfn_range: GMFN range, XENMEM_add_to_physmap only. + * - XENMAPSPACE_gmfn_foreign: GMFN from another dom, + * XENMEM_add_to_physmap_batch only. + * - XENMAPSPACE_dev_mmio: device mmio region ARM only; the region is mapped + * in Stage-2 using the Normal MemoryInner/Outer + * Write-Back Cacheable memory attribute. + */ /* ` enum phys_map_space { */ -#define XENMAPSPACE_shared_info 0 /* shared info page */ -#define XENMAPSPACE_grant_table 1 /* grant table page */ -#define XENMAPSPACE_gmfn 2 /* GMFN */ -#define XENMAPSPACE_gmfn_range 3 /* GMFN range, XENMEM_add_to_physmap only. */ -#define XENMAPSPACE_gmfn_foreign 4 /* GMFN from another dom, - * XENMEM_add_to_physmap_batch only. */ -#define XENMAPSPACE_dev_mmio 5 /* device mmio region - ARM only; the region is mapped in - Stage-2 using the Normal Memory - Inner/Outer Write-Back Cacheable - memory attribute. */ +#define XENMAPSPACE_shared_info 0 +#define XENMAPSPACE_grant_table 1 +#define XENMAPSPACE_gmfn 2 +#define XENMAPSPACE_gmfn_range 3 +#define XENMAPSPACE_gmfn_foreign 4 +#define XENMAPSPACE_dev_mmio 5 /* ` } */ -/* +#define XENMEM_add_to_physmap 7 +/** + * struct xen_add_to_physmap - XENMEM_add_to_physmap + * * Sets the GPFN at which a particular page appears in the specified guest's * physical address space (translated guests only). * arg == addr of xen_add_to_physmap_t. */ -#define XENMEM_add_to_physmap 7 struct xen_add_to_physmap { - /* Which domain to change the mapping for. */ + /** @domid: Which domain to change the mapping for. */ domid_t domid; - /* Number of pages to go through for gmfn_range */ + /** @size: Number of pages to go through for gmfn_range */ uint16_t size; - unsigned int space; /* => enum phys_map_space */ + /** @space: enum phys_map_space */ + unsigned int space; #define XENMAPIDX_grant_table_status 0x80000000 - /* Index into space being mapped. */ + /** @idx: Index into space being mapped. */ xen_ulong_t idx; - /* GPFN in domid where the source mapping page should appear. */ + /** @gpfn: GPFN in domid where the source mapping page should appear. */ xen_pfn_t gpfn; }; typedef struct xen_add_to_physmap xen_add_to_physmap_t; DEFINE_XEN_GUEST_HANDLE(xen_add_to_physmap_t); -/* A batched version of add_to_physmap. */ #define XENMEM_add_to_physmap_batch 23 +/** + * struct xen_add_to_physmap_batch - XENMEM_add_to_physmap_batch + * + * A batched version of add_to_physmap. + */ struct xen_add_to_physmap_batch { - /* IN */ - /* Which domain to change the mapping for. */ + /** @domid: IN, which domain to change the mapping for */ domid_t domid; - uint16_t space; /* => enum phys_map_space */ + /** @space: IN, enum phys_map_space */ + uint16_t space; - /* Number of pages to go through */ + /** @size: IN, Number of pages to go through */ uint16_t size; #if __XEN_INTERFACE_VERSION__ < 0x00040700 - domid_t foreign_domid; /* IFF gmfn_foreign. Should be 0 for other spaces. */ + /** @foreign_domid: IN, iff gmfn_foreign. Should be 0 for other spaces. */ + domid_t foreign_domid; #else + /** + * @u: IN + * + * - u.foreign_domid: gmfn_foreign + * - u.res0: All the other spaces. Should be 0 + */ union xen_add_to_physmap_batch_extra { - domid_t foreign_domid; /* gmfn_foreign */ - uint16_t res0; /* All the other spaces. Should be 0 */ + domid_t foreign_domid; + uint16_t res0; } u; #endif - /* Indexes into space being mapped. */ + /** @idxs: IN, Indexes into space being mapped. */ XEN_GUEST_HANDLE(xen_ulong_t) idxs; - /* GPFN in domid where the source mapping page should appear. */ + /** @gpfns: IN, GPFN in domid where the source mapping page should appear. */ XEN_GUEST_HANDLE(xen_pfn_t) gpfns; - /* OUT */ - - /* Per index error code. */ + /** @errs: OUT, Per index error code. */ XEN_GUEST_HANDLE(int) errs; }; typedef struct xen_add_to_physmap_batch xen_add_to_physmap_batch_t; @@ -296,17 +357,19 @@ typedef struct xen_add_to_physmap_batch xen_add_to_physmap_range_t; DEFINE_XEN_GUEST_HANDLE(xen_add_to_physmap_range_t); #endif -/* +#define XENMEM_remove_from_physmap 15 +/** + * struct xen_remove_from_physmap - XENMEM_remove_from_physmap + * * Unmaps the page appearing at a particular GPFN from the specified guest's * physical address space (translated guests only). * arg == addr of xen_remove_from_physmap_t. */ -#define XENMEM_remove_from_physmap 15 struct xen_remove_from_physmap { - /* Which domain to change the mapping for. */ + /** @domid: Which domain to change the mapping for. */ domid_t domid; - /* GPFN of the current mapping of the page. */ + /** @gpfn: GPFN of the current mapping of the page. */ xen_pfn_t gpfn; }; typedef struct xen_remove_from_physmap xen_remove_from_physmap_t; @@ -315,21 +378,27 @@ DEFINE_XEN_GUEST_HANDLE(xen_remove_from_physmap_t); /*** REMOVED ***/ /*#define XENMEM_translate_gpfn_list 8*/ -/* +#define XENMEM_memory_map 9 +/** + * struct xen_memory_map - XENMEM_memory_map + * * Returns the pseudo-physical memory map as it was when the domain * was started (specified by XENMEM_set_memory_map). * arg == addr of xen_memory_map_t. */ -#define XENMEM_memory_map 9 struct xen_memory_map { - /* + /** + * @nr_entries: + * * On call the number of entries which can be stored in buffer. On * return the number of entries which have been stored in * buffer. */ unsigned int nr_entries; - /* + /** + * @buffer: + * * Entries in the buffer are in the same format as returned by the * BIOS INT 0x15 EAX=0xE820 call. */ @@ -338,7 +407,9 @@ struct xen_memory_map { typedef struct xen_memory_map xen_memory_map_t; DEFINE_XEN_GUEST_HANDLE(xen_memory_map_t); -/* +/** + * DOC: XENMEM_machine_memory_map + * * Returns the real physical memory map. Passes the same structure as * XENMEM_memory_map. * Specifying buffer as NULL will return the number of entries required @@ -347,12 +418,14 @@ DEFINE_XEN_GUEST_HANDLE(xen_memory_map_t); */ #define XENMEM_machine_memory_map 10 -/* +#define XENMEM_set_memory_map 13 +/** + * struct xen_foreign_memory_map - XENMEM_set_memory_map + * * Set the pseudo-physical memory map of a domain, as returned by * XENMEM_memory_map. * arg == addr of xen_foreign_memory_map_t. */ -#define XENMEM_set_memory_map 13 struct xen_foreign_memory_map { domid_t domid; struct xen_memory_map map; @@ -362,14 +435,19 @@ DEFINE_XEN_GUEST_HANDLE(xen_foreign_memory_map_t); #define XENMEM_set_pod_target 16 #define XENMEM_get_pod_target 17 +/** + * struct xen_pod_target - XENMEM_set_pod_target and XENMEM_get_pod_target + */ struct xen_pod_target { - /* IN */ + /** @target_pages: IN */ uint64_t target_pages; - /* OUT */ + /** @tot_pages: OUT */ uint64_t tot_pages; + /** @pod_cache_pages: OUT */ uint64_t pod_cache_pages; + /** @pod_entries: OUT */ uint64_t pod_entries; - /* IN */ + /** @domid: IN */ domid_t domid; }; typedef struct xen_pod_target xen_pod_target_t; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:49:54 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 23:49:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3pdy-0004SJ-S2; Thu, 06 Aug 2020 23:49:54 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3pdx-0004FC-Kj for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 23:49:53 +0000 X-Inumbo-ID: 2e66862a-07a4-432f-a589-c70212a3ad76 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2e66862a-07a4-432f-a589-c70212a3ad76; Thu, 06 Aug 2020 23:49:39 +0000 (UTC) Received: from sstabellini-ThinkPad-T480s.hsd1.ca.comcast.net (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0B77622D05; Thu, 6 Aug 2020 23:49:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596757779; bh=tG7IOMVzAKrOpHe65a5zGXzao6XoCl9HRXWwSXpjlE0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GxI0OoETdZHYjWzTj7zc4Fx7XEP9Op9CJs1G9FU0BQNvMB2GW4qPIDUvWHf/BCHIq ddrxZ/cSHMxwm9bGiH6wcUoxkQi0iFiursnZBvZz6U6d1sABRHB03beYxelhageYdv 9c/MR87PwOwyC7H57kU4xg0+BW+t22TwJ0vwBAV0= From: Stefano Stabellini To: xen-devel@lists.xenproject.org Subject: [PATCH 05/14] kernel-doc: public/features.h Date: Thu, 6 Aug 2020 16:49:24 -0700 Message-Id: <20200806234933.16448-5-sstabellini@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: sstabellini@kernel.org, julien@xen.org, wl@xen.org, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, Stefano Stabellini Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Stefano Stabellini Convert in-code comments to kernel-doc format wherever possible. Signed-off-by: Stefano Stabellini --- xen/include/public/features.h | 78 ++++++++++++++++++++++++++--------- 1 file changed, 59 insertions(+), 19 deletions(-) diff --git a/xen/include/public/features.h b/xen/include/public/features.h index 1613b2aab8..524d1758c4 100644 --- a/xen/include/public/features.h +++ b/xen/include/public/features.h @@ -27,8 +27,8 @@ #ifndef __XEN_PUBLIC_FEATURES_H__ #define __XEN_PUBLIC_FEATURES_H__ -/* - * `incontents 200 elfnotes_features XEN_ELFNOTE_FEATURES +/** + * DOC: XEN_ELFNOTE_FEATURES * * The list of all the features the guest supports. They are set by * parsing the XEN_ELFNOTE_FEATURES and XEN_ELFNOTE_SUPPORTED_FEATURES @@ -41,19 +41,25 @@ * XENFEAT_dom0 MUST be set if the guest is to be booted as dom0, */ -/* - * If set, the guest does not need to write-protect its pagetables, and can - * update them via direct writes. +/** + * DOC: XENFEAT_writable_page_tables + * + * If set, the guest does not need to write-protect its pagetables, and + * can update them via direct writes. */ #define XENFEAT_writable_page_tables 0 -/* +/** + * DOC: XENFEAT_writable_descriptor_tables + * * If set, the guest does not need to write-protect its segment descriptor * tables, and can update them via direct writes. */ #define XENFEAT_writable_descriptor_tables 1 -/* +/** + * DOC: XENFEAT_auto_translated_physmap + * * If set, translation between the guest's 'pseudo-physical' address space * and the host's machine address space are handled by the hypervisor. In this * mode the guest does not need to perform phys-to/from-machine translations @@ -61,37 +67,63 @@ */ #define XENFEAT_auto_translated_physmap 2 -/* If set, the guest is running in supervisor mode (e.g., x86 ring 0). */ +/** + * DOC: XENFEAT_supervisor_mode_kernel + * + * If set, the guest is running in supervisor mode (e.g., x86 ring 0). + */ #define XENFEAT_supervisor_mode_kernel 3 -/* +/** + * DOC: XENFEAT_pae_pgdir_above_4gb + * * If set, the guest does not need to allocate x86 PAE page directories * below 4GB. This flag is usually implied by auto_translated_physmap. */ #define XENFEAT_pae_pgdir_above_4gb 4 -/* x86: Does this Xen host support the MMU_PT_UPDATE_PRESERVE_AD hypercall? */ +/** + * DOC: XENFEAT_mmu_pt_update_preserve_ad + * x86: Does this Xen host support the MMU_PT_UPDATE_PRESERVE_AD hypercall? + */ #define XENFEAT_mmu_pt_update_preserve_ad 5 -/* x86: Does this Xen host support the MMU_{CLEAR,COPY}_PAGE hypercall? */ +/** + * DOC: XENFEAT_highmem_assist + * x86: Does this Xen host support the MMU_{CLEAR,COPY}_PAGE hypercall? + */ #define XENFEAT_highmem_assist 6 -/* +/** + * DOC: XENFEAT_gnttab_map_avail_bits + * * If set, GNTTABOP_map_grant_ref honors flags to be placed into guest kernel * available pte bits. */ #define XENFEAT_gnttab_map_avail_bits 7 -/* x86: Does this Xen host support the HVM callback vector type? */ +/** + * DOC: XENFEAT_hvm_callback_vector + * x86: Does this Xen host support the HVM callback vector type? + */ #define XENFEAT_hvm_callback_vector 8 -/* x86: pvclock algorithm is safe to use on HVM */ +/** + * DOC: XENFEAT_hvm_safe_pvclock + * x86: pvclock algorithm is safe to use on HVM + */ #define XENFEAT_hvm_safe_pvclock 9 -/* x86: pirq can be used by HVM guests */ +/** + * DOC: XENFEAT_hvm_pirqs + * x86: pirq can be used by HVM guests + */ #define XENFEAT_hvm_pirqs 10 -/* operation as Dom0 is supported */ +/** + * DOC: XENFEAT_dom0 + * operation as Dom0 is supported + */ #define XENFEAT_dom0 11 /* Xen also maps grant references at pfn = mfn. @@ -99,13 +131,21 @@ #define XENFEAT_grant_map_identity 12 */ -/* Guest can use XENMEMF_vnode to specify virtual node for memory op. */ +/** + * DOC: XENFEAT_memory_op_vnode_supported + * Guest can use XENMEMF_vnode to specify virtual node for memory op. + */ #define XENFEAT_memory_op_vnode_supported 13 -/* arm: Hypervisor supports ARM SMC calling convention. */ +/** + * DOC: XENFEAT_ARM_SMCCC_supported + * arm: Hypervisor supports ARM SMC calling convention. + */ #define XENFEAT_ARM_SMCCC_supported 14 -/* +/** + * DOC: XENFEAT_linux_rsdp_unrestricted + * * x86/PVH: If set, ACPI RSDP can be placed at any address. Otherwise RSDP * must be located in lower 1MB, as required by ACPI Specification for IA-PC * systems. -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:49:55 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 23:49:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3pdz-0004Sp-7c; Thu, 06 Aug 2020 23:49:55 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3pdx-0004FE-Mw for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 23:49:53 +0000 X-Inumbo-ID: 65196a16-6859-4420-b545-0fc5d466942c Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 65196a16-6859-4420-b545-0fc5d466942c; Thu, 06 Aug 2020 23:49:41 +0000 (UTC) Received: from sstabellini-ThinkPad-T480s.hsd1.ca.comcast.net (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 247E3221E2; Thu, 6 Aug 2020 23:49:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596757781; bh=fI8sUwAia9oJeCWiNXgbqAhwYFTIQGUCuTFqxFs8WNk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LW3TnvpD+CyGwfYRt8OjItPvI8tVr0URGSRNUGwRNk6Cc3Y9/KJFUZ0JICZnPoG3g t3HiKoftepNBqtWOFUQ9XtnBmA3+Y+rXwErRidWFIxdf0LbV0JD/YYjnLxG4TBudZa DxQ7KWE+SiblsFcKVJuIyRAJJmSEJ22gznSkYpag= From: Stefano Stabellini To: xen-devel@lists.xenproject.org Subject: [PATCH 09/14] kernel-doc: public/sched.h Date: Thu, 6 Aug 2020 16:49:28 -0700 Message-Id: <20200806234933.16448-9-sstabellini@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: sstabellini@kernel.org, julien@xen.org, wl@xen.org, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, Stefano Stabellini Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Stefano Stabellini Convert in-code comments to kernel-doc format wherever possible. Signed-off-by: Stefano Stabellini --- xen/include/public/sched.h | 129 ++++++++++++++++++++++++++----------- 1 file changed, 92 insertions(+), 37 deletions(-) diff --git a/xen/include/public/sched.h b/xen/include/public/sched.h index 811bd87c82..6f36c3748a 100644 --- a/xen/include/public/sched.h +++ b/xen/include/public/sched.h @@ -29,41 +29,50 @@ #include "event_channel.h" -/* - * `incontents 150 sched Guest Scheduler Operations +/** + * DOC: Guest Scheduler Operations * * The SCHEDOP interface provides mechanisms for a guest to interact * with the scheduler, including yield, blocking and shutting itself * down. */ -/* +/** + * DOC: HYPERVISOR_sched_op + * * The prototype for this hypercall is: - * ` long HYPERVISOR_sched_op(enum sched_op cmd, void *arg, ...) * - * @cmd == SCHEDOP_??? (scheduler operation). - * @arg == Operation-specific extra argument(s), as described below. - * ... == Additional Operation-specific extra arguments, described below. + * long HYPERVISOR_sched_op(enum sched_op cmd, void *arg, ...) + * + * - @cmd == SCHEDOP_??? (scheduler operation). + * - @arg == Operation-specific extra argument(s), as described below. + * - ... == Additional Operation-specific extra arguments, described below. * * Versions of Xen prior to 3.0.2 provided only the following legacy version * of this hypercall, supporting only the commands yield, block and shutdown: + * * long sched_op(int cmd, unsigned long arg) - * @cmd == SCHEDOP_??? (scheduler operation). - * @arg == 0 (SCHEDOP_yield and SCHEDOP_block) - * == SHUTDOWN_* code (SCHEDOP_shutdown) + * + * - @cmd == SCHEDOP_??? (scheduler operation). + * - @arg == 0 (SCHEDOP_yield and SCHEDOP_block) + * - == SHUTDOWN_* code (SCHEDOP_shutdown) * * This legacy version is available to new guests as: - * ` long HYPERVISOR_sched_op_compat(enum sched_op cmd, unsigned long arg) + * + * long HYPERVISOR_sched_op_compat(enum sched_op cmd, unsigned long arg) */ /* ` enum sched_op { // SCHEDOP_* => struct sched_* */ -/* - * Voluntarily yield the CPU. - * @arg == NULL. + +/** + * DOC: SCHEDOP_yield + * Voluntarily yield the CPU. @arg == NULL. */ #define SCHEDOP_yield 0 -/* +/** + * DOC: SCHEDOP_block + * * Block execution of this VCPU until an event is received for processing. * If called with event upcalls masked, this operation will atomically * reenable event delivery and check for pending events before blocking the @@ -72,7 +81,9 @@ */ #define SCHEDOP_block 1 -/* +/** + * DOC: SCHEDOP_shutdown + * * Halt execution of this domain (all VCPUs) and notify the system controller. * @arg == pointer to sched_shutdown_t structure. * @@ -87,14 +98,18 @@ */ #define SCHEDOP_shutdown 2 -/* +/** + * DOC: SCHEDOP_poll + * * Poll a set of event-channel ports. Return when one or more are pending. An * optional timeout may be specified. * @arg == pointer to sched_poll_t structure. */ #define SCHEDOP_poll 3 -/* +/** + * DOC: SCHEDOP_remote_shutdown + * * Declare a shutdown for another domain. The main use of this function is * in interpreting shutdown requests and reasons for fully-virtualized * domains. A para-virtualized domain may use SCHEDOP_shutdown directly. @@ -102,14 +117,18 @@ */ #define SCHEDOP_remote_shutdown 4 -/* +/** + * DOC: SCHEDOP_shutdown_code + * * Latch a shutdown code, so that when the domain later shuts down it * reports this code to the control tools. * @arg == sched_shutdown_t, as for SCHEDOP_shutdown. */ #define SCHEDOP_shutdown_code 5 -/* +/** + * DOC: SCHEDOP_watchdog + * * Setup, poke and destroy a domain watchdog timer. * @arg == pointer to sched_watchdog_t structure. * With id == 0, setup a domain watchdog timer to cause domain shutdown @@ -119,7 +138,9 @@ */ #define SCHEDOP_watchdog 6 -/* +/** + * DOC: SCHEDOP_pin_override + * * Override the current vcpu affinity by pinning it to one physical cpu or * undo this override restoring the previous affinity. * @arg == pointer to sched_pin_override_t structure. @@ -132,12 +153,19 @@ #define SCHEDOP_pin_override 7 /* ` } */ +/** + * struct sched_shutdown + */ struct sched_shutdown { - unsigned int reason; /* SHUTDOWN_* => enum sched_shutdown_reason */ + /** @reason: SHUTDOWN_* => enum sched_shutdown_reason */ + unsigned int reason; }; typedef struct sched_shutdown sched_shutdown_t; DEFINE_XEN_GUEST_HANDLE(sched_shutdown_t); +/** + * struct sched_poll + */ struct sched_poll { XEN_GUEST_HANDLE(evtchn_port_t) ports; unsigned int nr_ports; @@ -146,39 +174,62 @@ struct sched_poll { typedef struct sched_poll sched_poll_t; DEFINE_XEN_GUEST_HANDLE(sched_poll_t); +/** + * struct sched_remote_shutdown + */ struct sched_remote_shutdown { - domid_t domain_id; /* Remote domain ID */ - unsigned int reason; /* SHUTDOWN_* => enum sched_shutdown_reason */ + /** @domain_id: Remote domain ID */ + domid_t domain_id; + /** @reason: SHUTDOWN_* => enum sched_shutdown_reason */ + unsigned int reason; }; typedef struct sched_remote_shutdown sched_remote_shutdown_t; DEFINE_XEN_GUEST_HANDLE(sched_remote_shutdown_t); +/** + * struct sched_watchdog + */ struct sched_watchdog { - uint32_t id; /* watchdog ID */ - uint32_t timeout; /* timeout */ + /** @id: watchdog ID */ + uint32_t id; + /** @timeout: timeout */ + uint32_t timeout; }; typedef struct sched_watchdog sched_watchdog_t; DEFINE_XEN_GUEST_HANDLE(sched_watchdog_t); +/** + * struct sched_pin_override + */ struct sched_pin_override { int32_t pcpu; }; typedef struct sched_pin_override sched_pin_override_t; DEFINE_XEN_GUEST_HANDLE(sched_pin_override_t); -/* - * Reason codes for SCHEDOP_shutdown. These may be interpreted by control - * software to determine the appropriate action. For the most part, Xen does - * not care about the shutdown code. +/** + * DOC: Reason codes for SCHEDOP_shutdown + * + * These may be interpreted by control software to determine the + * appropriate action. For the most part, Xen does not care about the + * shutdown code. + * + * - SHUTDOWN_poweroff: Domain exited normally. Clean up and kill. + * - SHUTDOWN_reboot: Clean up, kill, and then restart. + * - SHUTDOWN_suspend: Clean up, save suspend info, kill. + * - SHUTDOWN_crash: Tell controller we've crashed. + * - SHUTDOWN_watchdog: Restart because watchdog time expired. */ /* ` enum sched_shutdown_reason { */ -#define SHUTDOWN_poweroff 0 /* Domain exited normally. Clean up and kill. */ -#define SHUTDOWN_reboot 1 /* Clean up, kill, and then restart. */ -#define SHUTDOWN_suspend 2 /* Clean up, save suspend info, kill. */ -#define SHUTDOWN_crash 3 /* Tell controller we've crashed. */ -#define SHUTDOWN_watchdog 4 /* Restart because watchdog time expired. */ +#define SHUTDOWN_poweroff 0 +#define SHUTDOWN_reboot 1 +#define SHUTDOWN_suspend 2 +#define SHUTDOWN_crash 3 +#define SHUTDOWN_watchdog 4 -/* +/** + * DOC: SHUTDOWN_soft_reset + * * Domain asked to perform 'soft reset' for it. The expected behavior is to * reset internal Xen state for the domain returning it to the point where it * was created but leaving the domain's memory contents and vCPU contexts @@ -186,7 +237,11 @@ DEFINE_XEN_GUEST_HANDLE(sched_pin_override_t); * interfaces again. */ #define SHUTDOWN_soft_reset 5 -#define SHUTDOWN_MAX 5 /* Maximum valid shutdown reason. */ +/** + * DOC: SHUTDOWN_MAX + * Maximum valid shutdown reason + */ +#define SHUTDOWN_MAX 5 /* ` } */ #endif /* __XEN_PUBLIC_SCHED_H__ */ -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:49:59 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 23:49:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3pe3-0004XM-JU; Thu, 06 Aug 2020 23:49:59 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3pe2-0004FC-Ko for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 23:49:58 +0000 X-Inumbo-ID: 6954ef09-0bf3-4d94-8bf6-5350f103198a Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6954ef09-0bf3-4d94-8bf6-5350f103198a; Thu, 06 Aug 2020 23:49:42 +0000 (UTC) Received: from sstabellini-ThinkPad-T480s.hsd1.ca.comcast.net (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2AFCE22D01; Thu, 6 Aug 2020 23:49:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596757782; bh=48yV9TkD2TZYv7cImPdyFJp0Stqs2SUX0/t0o7IpwKo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tHiMGuXBeLAKKHmdrUk+S7Ht1wpP8C/POC2Dho1OP8zsVoEN1ZYVochY6hArtHNQB hT7q3b7v6MJAiRoIM8G+is0tima6EAUMURtyIs6MhRxg0J5Cw2b5SJptPY1ujdsMZA RdCXvOZ6apA5UMcSmeJ4eh+F1abVe7Tirbu13CUg= From: Stefano Stabellini To: xen-devel@lists.xenproject.org Subject: [PATCH 11/14] kernel-doc: public/version.h Date: Thu, 6 Aug 2020 16:49:30 -0700 Message-Id: <20200806234933.16448-11-sstabellini@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: sstabellini@kernel.org, julien@xen.org, wl@xen.org, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, Stefano Stabellini Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Stefano Stabellini Convert in-code comments to kernel-doc format wherever possible. Signed-off-by: Stefano Stabellini --- xen/include/public/version.h | 74 +++++++++++++++++++++++++++++------- 1 file changed, 60 insertions(+), 14 deletions(-) diff --git a/xen/include/public/version.h b/xen/include/public/version.h index 17a81e23cd..9a7d8d26dd 100644 --- a/xen/include/public/version.h +++ b/xen/include/public/version.h @@ -30,19 +30,33 @@ #include "xen.h" -/* NB. All ops return zero on success, except XENVER_{version,pagesize} - * XENVER_{version,pagesize,build_id} */ +/** + * DOC: XENVER_* + * + * NB. All ops return zero on success, except for: + * + * - XENVER_{version,pagesize} + * - XENVER_{version,pagesize,build_id} + */ -/* arg == NULL; returns major:minor (16:16). */ +/** + * DOC: XENVER_version + * @arg == NULL; returns major:minor (16:16). + */ #define XENVER_version 0 -/* arg == xen_extraversion_t. */ +/** + * DOC: XENVER_extraversion + * @arg == xen_extraversion_t. + */ #define XENVER_extraversion 1 typedef char xen_extraversion_t[16]; #define XEN_EXTRAVERSION_LEN (sizeof(xen_extraversion_t)) -/* arg == xen_compile_info_t. */ #define XENVER_compile_info 2 +/** + * struct xen_compile_info - XENVER_compile_info + */ struct xen_compile_info { char compiler[64]; char compile_by[16]; @@ -51,52 +65,84 @@ struct xen_compile_info { }; typedef struct xen_compile_info xen_compile_info_t; +/** + * DOC: XENVER_capabilities + * @arg: xen_capabilities_info_t + */ #define XENVER_capabilities 3 typedef char xen_capabilities_info_t[1024]; #define XEN_CAPABILITIES_INFO_LEN (sizeof(xen_capabilities_info_t)) +/** + * DOC: XENVER_changeset + * @arg: xen_changeset_info_t + */ #define XENVER_changeset 4 typedef char xen_changeset_info_t[64]; #define XEN_CHANGESET_INFO_LEN (sizeof(xen_changeset_info_t)) #define XENVER_platform_parameters 5 +/** + * struct xen_platform_parameters - XENVER_platform_parameters + */ struct xen_platform_parameters { xen_ulong_t virt_start; }; typedef struct xen_platform_parameters xen_platform_parameters_t; #define XENVER_get_features 6 +/** + * struct xen_feature_info - XENVER_get_features + */ struct xen_feature_info { - unsigned int submap_idx; /* IN: which 32-bit submap to return */ - uint32_t submap; /* OUT: 32-bit submap */ + /** @submap_idx: IN: which 32-bit submap to return */ + unsigned int submap_idx; + /** @submap: OUT: 32-bit submap */ + uint32_t submap; }; typedef struct xen_feature_info xen_feature_info_t; -/* Declares the features reported by XENVER_get_features. */ +/** + * DOC: features.h + * Declares the features reported by XENVER_get_features. + */ #include "features.h" -/* arg == NULL; returns host memory page size. */ +/** + * DOC: XENVER_pagesize + * @arg == NULL; returns host memory page size. + */ #define XENVER_pagesize 7 -/* arg == xen_domain_handle_t. +/** + * DOC: XENVER_guest_handle + * + * @arg == xen_domain_handle_t. * * The toolstack fills it out for guest consumption. It is intended to hold * the UUID of the guest. */ #define XENVER_guest_handle 8 +/** + * DOC: XENVER_commandline + * @arg: xen_commandline_t + */ #define XENVER_commandline 9 typedef char xen_commandline_t[1024]; -/* +#define XENVER_build_id 10 +/** + * struct xen_build_id - XENVER_build_id + * * Return value is the number of bytes written, or XEN_Exx on error. * Calling with empty parameter returns the size of build_id. */ -#define XENVER_build_id 10 struct xen_build_id { - uint32_t len; /* IN: size of buf[]. */ + /** @len: IN: size of buf[]. */ + uint32_t len; + /** @buf: OUT: Variable length buffer with build_id. */ unsigned char buf[XEN_FLEX_ARRAY_DIM]; - /* OUT: Variable length buffer with build_id. */ }; typedef struct xen_build_id xen_build_id_t; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:50:00 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 23:50:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3pe3-0004Xu-Uy; Thu, 06 Aug 2020 23:49:59 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3pe2-0004FE-NE for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 23:49:58 +0000 X-Inumbo-ID: 8139484b-b3d0-4e4c-af37-410066716d08 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8139484b-b3d0-4e4c-af37-410066716d08; Thu, 06 Aug 2020 23:49:42 +0000 (UTC) Received: from sstabellini-ThinkPad-T480s.hsd1.ca.comcast.net (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A682422CBB; Thu, 6 Aug 2020 23:49:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596757782; bh=bW6ejKKTP+vV2xlvpty1Lmx1E+3uq+jCbhkmCet5nT0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0Je5iQz4036qcptRt+9EO0e3hP/eye2dYlJWmTWRrJLNYt/2gWF+ld/XqemeIF4tQ rAMzuGJAUTAh0xRNPsv6ir/EQ3L4mcb253Sc0Po3TXeHwr4xrsYYqI3NCT/9oAXZB0 hw02b3K+WkWMjmi5qZFBrMCvs9/xozVLBy1lg9V8= From: Stefano Stabellini To: xen-devel@lists.xenproject.org Subject: [PATCH 10/14] kernel-doc: public/vcpu.h Date: Thu, 6 Aug 2020 16:49:29 -0700 Message-Id: <20200806234933.16448-10-sstabellini@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: sstabellini@kernel.org, julien@xen.org, wl@xen.org, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, Stefano Stabellini Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Stefano Stabellini Convert in-code comments to kernel-doc format wherever possible. Signed-off-by: Stefano Stabellini --- xen/include/public/vcpu.h | 180 ++++++++++++++++++++++++++++---------- 1 file changed, 136 insertions(+), 44 deletions(-) diff --git a/xen/include/public/vcpu.h b/xen/include/public/vcpu.h index 3623af932f..e50471e2b2 100644 --- a/xen/include/public/vcpu.h +++ b/xen/include/public/vcpu.h @@ -29,15 +29,20 @@ #include "xen.h" -/* +/** + * DOC: VCPUOP hypercall + * * Prototype for this hypercall is: * long vcpu_op(int cmd, unsigned int vcpuid, void *extra_args) - * @cmd == VCPUOP_??? (VCPU operation). - * @vcpuid == VCPU to operate on. - * @extra_args == Operation-specific extra arguments (NULL if none). + * + * - @cmd == VCPUOP_??? (VCPU operation). + * - @vcpuid == VCPU to operate on. + * - @extra_args == Operation-specific extra arguments (NULL if none). */ -/* +/** + * DOC: VCPUOP_initialise + * * Initialise a VCPU. Each VCPU can be initialised only once. A * newly-initialised VCPU will not run until it is brought up by VCPUOP_up. * @@ -48,13 +53,17 @@ */ #define VCPUOP_initialise 0 -/* +/** + * DOC: VCPUOP_up + * * Bring up a VCPU. This makes the VCPU runnable. This operation will fail * if the VCPU has not been initialised (VCPUOP_initialise). */ #define VCPUOP_up 1 -/* +/** + * DOC: VCPUOP_down + * * Bring down a VCPU (i.e., make it non-runnable). * There are a few caveats that callers should observe: * 1. This operation may return, and VCPU_is_up may return false, before the @@ -70,26 +79,36 @@ */ #define VCPUOP_down 2 -/* Returns 1 if the given VCPU is up. */ +/** + * DOC: VCPUOP_is_up + * Returns 1 if the given VCPU is up. + */ #define VCPUOP_is_up 3 -/* +#define VCPUOP_get_runstate_info 4 +/** + * struct vcpu_runstate_info - VCPUOP_get_runstate_info + * * Return information about the state and running time of a VCPU. * @extra_arg == pointer to vcpu_runstate_info structure. */ -#define VCPUOP_get_runstate_info 4 struct vcpu_runstate_info { - /* VCPU's current state (RUNSTATE_*). */ + /** @state: VCPU's current state (RUNSTATE_*). */ int state; - /* When was current state entered (system time, ns)? */ - uint64_t state_entry_time; - /* - * Update indicator set in state_entry_time: + /** + * @state_entry_time: + * + * When was current state entered (system time, ns)? + * + * XEN_RUNSTATE_UPDATE is the update indicator in state_entry_time: * When activated via VMASST_TYPE_runstate_update_flag, set during * updates in guest memory mapped copy of vcpu_runstate_info. */ #define XEN_RUNSTATE_UPDATE (xen_mk_ullong(1) << 63) - /* + uint64_t state_entry_time; + /** + * @time: + * * Time spent in each RUNSTATE_* (ns). The sum of these times is * guaranteed not to drift from system time. */ @@ -98,16 +117,27 @@ struct vcpu_runstate_info { typedef struct vcpu_runstate_info vcpu_runstate_info_t; DEFINE_XEN_GUEST_HANDLE(vcpu_runstate_info_t); -/* VCPU is currently running on a physical CPU. */ +/** + * DOC: RUNSTATE_running + * VCPU is currently running on a physical CPU. + */ #define RUNSTATE_running 0 -/* VCPU is runnable, but not currently scheduled on any physical CPU. */ +/** + * DOC: RUNSTATE_runnable + * VCPU is runnable, but not currently scheduled on any physical CPU. + */ #define RUNSTATE_runnable 1 -/* VCPU is blocked (a.k.a. idle). It is therefore not runnable. */ +/** + * DOC: RUNSTATE_blocked + * VCPU is blocked (a.k.a. idle). It is therefore not runnable. + */ #define RUNSTATE_blocked 2 -/* +/** + * DOC: RUNSTATE_offline + * * VCPU is not runnable, but it is not blocked. * This is a 'catch all' state for things like hotplug and pauses by the * system administrator (or for critical sections in the hypervisor). @@ -115,7 +145,10 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_runstate_info_t); */ #define RUNSTATE_offline 3 -/* +#define VCPUOP_register_runstate_memory_area 5 +/** + * struct vcpu_register_runstate_memory_area - VCPUOP_register_runstate_memory_area + * * Register a shared memory area from which the guest may obtain its own * runstate information without needing to execute a hypercall. * Notes: @@ -127,9 +160,9 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_runstate_info_t); * runstate.state will always be RUNSTATE_running and * runstate.state_entry_time will indicate the system time at which the * VCPU was last scheduled to run. + * * @extra_arg == pointer to vcpu_register_runstate_memory_area structure. */ -#define VCPUOP_register_runstate_memory_area 5 struct vcpu_register_runstate_memory_area { union { XEN_GUEST_HANDLE(vcpu_runstate_info_t) h; @@ -140,38 +173,74 @@ struct vcpu_register_runstate_memory_area { typedef struct vcpu_register_runstate_memory_area vcpu_register_runstate_memory_area_t; DEFINE_XEN_GUEST_HANDLE(vcpu_register_runstate_memory_area_t); -/* - * Set or stop a VCPU's periodic timer. Every VCPU has one periodic timer - * which can be set via these commands. Periods smaller than one millisecond - * may not be supported. +/** + * DOC: VCPUOP_set_periodic_timer + * + * Set a VCPU's periodic timer. Every VCPU has one periodic timer which + * can be set via this command. Periods smaller than one millisecond may + * not be supported. + * + * @arg == vcpu_set_periodic_timer_t + */ +#define VCPUOP_set_periodic_timer 6 +/** + * DOC: VCPUOP_stop_periodic_timer + * + * Stop a VCPU's periodic timer. + * + * @arg == NULL + */ +#define VCPUOP_stop_periodic_timer 7 +/** + * struct vcpu_set_periodic_timer */ -#define VCPUOP_set_periodic_timer 6 /* arg == vcpu_set_periodic_timer_t */ -#define VCPUOP_stop_periodic_timer 7 /* arg == NULL */ struct vcpu_set_periodic_timer { uint64_t period_ns; }; typedef struct vcpu_set_periodic_timer vcpu_set_periodic_timer_t; DEFINE_XEN_GUEST_HANDLE(vcpu_set_periodic_timer_t); -/* - * Set or stop a VCPU's single-shot timer. Every VCPU has one single-shot - * timer which can be set via these commands. +/** + * DOC: VCPUOP_set_singleshot_timer + * + * Set a VCPU's single-shot timer. Every VCPU has one single-shot timer + * which can be set via this command. + * + * @arg == vcpu_set_singleshot_timer_t + */ +#define VCPUOP_set_singleshot_timer 8 +/** + * DOC: VCPUOP_stop_singleshot_timer + * + * Stop a VCPU's single-shot timer. + * + * arg == NULL + */ +#define VCPUOP_stop_singleshot_timer 9 +/** + * struct vcpu_set_singleshot_timer */ -#define VCPUOP_set_singleshot_timer 8 /* arg == vcpu_set_singleshot_timer_t */ -#define VCPUOP_stop_singleshot_timer 9 /* arg == NULL */ struct vcpu_set_singleshot_timer { - uint64_t timeout_abs_ns; /* Absolute system time value in nanoseconds. */ - uint32_t flags; /* VCPU_SSHOTTMR_??? */ + /** @timeout_abs_ns: Absolute system time value in nanoseconds. */ + uint64_t timeout_abs_ns; + /** @flags: VCPU_SSHOTTMR_??? */ + uint32_t flags; }; typedef struct vcpu_set_singleshot_timer vcpu_set_singleshot_timer_t; DEFINE_XEN_GUEST_HANDLE(vcpu_set_singleshot_timer_t); -/* Flags to VCPUOP_set_singleshot_timer. */ - /* Require the timeout to be in the future (return -ETIME if it's passed). */ +/** + * DOC: flags to VCPUOP_set_singleshot_timer. + * + * VCPU_SSHOTTMR_future: Require the timeout to be in the future + * (return -ETIME if it's passed). + */ #define _VCPU_SSHOTTMR_future (0) #define VCPU_SSHOTTMR_future (1U << _VCPU_SSHOTTMR_future) -/* +/** + * DOC: VCPUOP_register_vcpu_info + * * Register a memory location in the guest address space for the * vcpu_info structure. This allows the guest to place the vcpu_info * structure in a convenient place, such as in a per-cpu data area. @@ -179,26 +248,44 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_set_singleshot_timer_t); * cross a page boundary. * * This may be called only once per vcpu. + * + * @arg == vcpu_register_vcpu_info_t + */ +#define VCPUOP_register_vcpu_info 10 +/** + * struct vcpu_register_vcpu_info - VCPUOP_register_vcpu_info */ -#define VCPUOP_register_vcpu_info 10 /* arg == vcpu_register_vcpu_info_t */ struct vcpu_register_vcpu_info { + /** @mfn: mfn of page to place vcpu_info */ uint64_t mfn; /* mfn of page to place vcpu_info */ + /** @offset: offset within page */ uint32_t offset; /* offset within page */ - uint32_t rsvd; /* unused */ + /** @rsvd: unused */ + uint32_t rsvd; }; typedef struct vcpu_register_vcpu_info vcpu_register_vcpu_info_t; DEFINE_XEN_GUEST_HANDLE(vcpu_register_vcpu_info_t); -/* Send an NMI to the specified VCPU. @extra_arg == NULL. */ +/** + * DOC: VCPUOP_send_nmi + * Send an NMI to the specified VCPU. @extra_arg == NULL. + */ #define VCPUOP_send_nmi 11 -/* +/** + * DOC: VCPUOP_get_physid + * * Get the physical ID information for a pinned vcpu's underlying physical * processor. The physical ID informmation is architecture-specific. * On x86: id[31:0]=apic_id, id[63:32]=acpi_id. * This command returns -EINVAL if it is not a valid operation for this VCPU. + * + * @arg == vcpu_get_physid_t + */ +#define VCPUOP_get_physid 12 +/** + * struct vcpu_get_physid */ -#define VCPUOP_get_physid 12 /* arg == vcpu_get_physid_t */ struct vcpu_get_physid { uint64_t phys_id; }; @@ -207,7 +294,9 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_get_physid_t); #define xen_vcpu_physid_to_x86_apicid(physid) ((uint32_t)(physid)) #define xen_vcpu_physid_to_x86_acpiid(physid) ((uint32_t)((physid) >> 32)) -/* +/** + * DOC: VCPUOP_register_vcpu_time_memory_area + * * Register a memory location to get a secondary copy of the vcpu time * parameters. The master copy still exists as part of the vcpu shared * memory area, and this secondary copy is updated whenever the master copy @@ -225,6 +314,9 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_get_physid_t); */ #define VCPUOP_register_vcpu_time_memory_area 13 DEFINE_XEN_GUEST_HANDLE(vcpu_time_info_t); +/** + * struct vcpu_register_time_memory_area + */ struct vcpu_register_time_memory_area { union { XEN_GUEST_HANDLE(vcpu_time_info_t) h; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:50:05 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 23:50:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3pe9-00056E-HD; Thu, 06 Aug 2020 23:50:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3pe7-0004FC-L8 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 23:50:03 +0000 X-Inumbo-ID: b2313342-8bf6-4c8a-a335-aa716498bec0 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b2313342-8bf6-4c8a-a335-aa716498bec0; Thu, 06 Aug 2020 23:49:43 +0000 (UTC) Received: from sstabellini-ThinkPad-T480s.hsd1.ca.comcast.net (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 32F4721744; Thu, 6 Aug 2020 23:49:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596757783; bh=vnHOSZP36XBZyuOzf22Utt63pStrj792RtEXdoyLc8w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AwDhNC2n60jw7dP/yE+B4W96E6HahDVbkYiJAEs2bf/Kv7WIViv7UbiTPQpcRaGQU HdFr6gaOHJpSabiQsE4g6uNlJKpvgt1k9QF5z/ZIH17u8a9AehWShFkI4C8qiz9+qk WVYDbMELp9ZUjT6rTSemRxHmut2Gx2z0GKvcZcyg= From: Stefano Stabellini To: xen-devel@lists.xenproject.org Subject: [PATCH 13/14] kernel-doc: public/elfnote.h Date: Thu, 6 Aug 2020 16:49:32 -0700 Message-Id: <20200806234933.16448-13-sstabellini@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: sstabellini@kernel.org, julien@xen.org, wl@xen.org, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, Stefano Stabellini Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Stefano Stabellini Convert in-code comments to kernel-doc format wherever possible. Signed-off-by: Stefano Stabellini --- xen/include/public/elfnote.h | 109 ++++++++++++++++++++++++++--------- 1 file changed, 81 insertions(+), 28 deletions(-) diff --git a/xen/include/public/elfnote.h b/xen/include/public/elfnote.h index 181cbc4ec7..1dd567a6f1 100644 --- a/xen/include/public/elfnote.h +++ b/xen/include/public/elfnote.h @@ -27,8 +27,8 @@ #ifndef __XEN_PUBLIC_ELFNOTE_H__ #define __XEN_PUBLIC_ELFNOTE_H__ -/* - * `incontents 200 elfnotes ELF notes +/** + * DOC: ELF notes * * The notes should live in a PT_NOTE segment and have "Xen" in the * name field. @@ -43,26 +43,35 @@ * as ASCIZ type. */ -/* +/** + * DOC: XEN_ELFNOTE_INFO * NAME=VALUE pair (string). */ #define XEN_ELFNOTE_INFO 0 -/* +/** + * DOC: XEN_ELFNOTE_ENTRY + * * The virtual address of the entry point (numeric). * * LEGACY: VIRT_ENTRY */ #define XEN_ELFNOTE_ENTRY 1 -/* The virtual address of the hypercall transfer page (numeric). +/** + * DOC: XEN_ELFNOTE_HYPERCALL_PAGE + * + * The virtual address of the hypercall transfer page (numeric). * * LEGACY: HYPERCALL_PAGE. (n.b. legacy value is a physical page * number not a virtual address) */ #define XEN_ELFNOTE_HYPERCALL_PAGE 2 -/* The virtual address where the kernel image should be mapped (numeric). +/** + * DOC: XEN_ELFNOTE_VIRT_BASE + * + * The virtual address where the kernel image should be mapped (numeric). * * Defaults to 0. * @@ -70,7 +79,9 @@ */ #define XEN_ELFNOTE_VIRT_BASE 3 -/* +/** + * DOC: XEN_ELFNOTE_PADDR_OFFSET + * * The offset of the ELF paddr field from the actual required * pseudo-physical address (numeric). * @@ -82,35 +93,45 @@ */ #define XEN_ELFNOTE_PADDR_OFFSET 4 -/* +/** + * DOC: XEN_ELFNOTE_XEN_VERSION + * * The version of Xen that we work with (string). * * LEGACY: XEN_VER */ #define XEN_ELFNOTE_XEN_VERSION 5 -/* +/** + * DOC: XEN_ELFNOTE_GUEST_OS + * * The name of the guest operating system (string). * * LEGACY: GUEST_OS */ #define XEN_ELFNOTE_GUEST_OS 6 -/* +/** + * DOC: XEN_ELFNOTE_GUEST_VERSION + * * The version of the guest operating system (string). * * LEGACY: GUEST_VER */ #define XEN_ELFNOTE_GUEST_VERSION 7 -/* +/** + * DOC: XEN_ELFNOTE_LOADER + * * The loader type (string). * * LEGACY: LOADER */ #define XEN_ELFNOTE_LOADER 8 -/* +/** + * DOC: XEN_ELFNOTE_PAE_MODE + * * The kernel supports PAE (x86/32 only, string = "yes", "no" or * "bimodal"). * @@ -126,7 +147,9 @@ */ #define XEN_ELFNOTE_PAE_MODE 9 -/* +/** + * DOC: XEN_ELFNOTE_FEATURES + * * The features supported/required by this kernel (string). * * The string must consist of a list of feature names (as given in @@ -138,7 +161,9 @@ */ #define XEN_ELFNOTE_FEATURES 10 -/* +/** + * DOC: XEN_ELFNOTE_BSD_SYMTAB + * * The kernel requires the symbol table to be loaded (string = "yes" or "no") * LEGACY: BSD_SYMTAB (n.b. The legacy treated the presence or absence * of this string as a boolean flag rather than requiring "yes" or @@ -146,7 +171,9 @@ */ #define XEN_ELFNOTE_BSD_SYMTAB 11 -/* +/** + * DOC: XEN_ELFNOTE_HV_START_LOW + * * The lowest address the hypervisor hole can begin at (numeric). * * This must not be set higher than HYPERVISOR_VIRT_START. Its presence @@ -155,13 +182,17 @@ */ #define XEN_ELFNOTE_HV_START_LOW 12 -/* +/** + * DOC: XEN_ELFNOTE_L1_MFN_VALID + * * List of maddr_t-sized mask/value pairs describing how to recognize * (non-present) L1 page table entries carrying valid MFNs (numeric). */ #define XEN_ELFNOTE_L1_MFN_VALID 13 -/* +/** + * DOC: XEN_ELFNOTE_SUSPEND_CANCEL + * * Whether or not the guest supports cooperative suspend cancellation. * This is a numeric value. * @@ -169,7 +200,9 @@ */ #define XEN_ELFNOTE_SUSPEND_CANCEL 14 -/* +/** + * DOC: XEN_ELFNOTE_INIT_P2M + * * The (non-default) location the initial phys-to-machine map should be * placed at by the hypervisor (Dom0) or the tools (DomU). * The kernel must be prepared for this mapping to be established using @@ -182,13 +215,17 @@ */ #define XEN_ELFNOTE_INIT_P2M 15 -/* +/** + * DOC: XEN_ELFNOTE_MOD_START_PFN + * * Whether or not the guest can deal with being passed an initrd not * mapped through its initial page tables. */ #define XEN_ELFNOTE_MOD_START_PFN 16 -/* +/** + * DOC: XEN_ELFNOTE_SUPPORTED_FEATURES + * * The features supported by this kernel (numeric). * * Other than XEN_ELFNOTE_FEATURES on pre-4.2 Xen, this note allows a @@ -201,7 +238,9 @@ */ #define XEN_ELFNOTE_SUPPORTED_FEATURES 17 -/* +/** + * DOC: XEN_ELFNOTE_PHYS32_ENTRY + * * Physical entry point into the kernel. * * 32bit entry point into the kernel. When requested to launch the @@ -211,12 +250,16 @@ */ #define XEN_ELFNOTE_PHYS32_ENTRY 18 -/* +/** + * DOC: XEN_ELFNOTE_MAX + * * The number of the highest elfnote defined. */ #define XEN_ELFNOTE_MAX XEN_ELFNOTE_PHYS32_ENTRY -/* +/** + * DOC: XEN_ELFNOTE_CRASH_INFO + * * System information exported through crash notes. * * The kexec / kdump code will create one XEN_ELFNOTE_CRASH_INFO @@ -225,7 +268,9 @@ */ #define XEN_ELFNOTE_CRASH_INFO 0x1000001 -/* +/** + * DOC: XEN_ELFNOTE_CRASH_REGS + * * System registers exported through crash notes. * * The kexec / kdump code will create one XEN_ELFNOTE_CRASH_REGS @@ -236,7 +281,9 @@ #define XEN_ELFNOTE_CRASH_REGS 0x1000002 -/* +/** + * DOC: XEN_ELFNOTE_DUMPCORE_NONE + * * xen dump-core none note. * xm dump-core code will create one XEN_ELFNOTE_DUMPCORE_NONE * in its dump file to indicate that the file is xen dump-core @@ -245,7 +292,9 @@ */ #define XEN_ELFNOTE_DUMPCORE_NONE 0x2000000 -/* +/** + * DOC: XEN_ELFNOTE_DUMPCORE_HEADER + * * xen dump-core header note. * xm dump-core code will create one XEN_ELFNOTE_DUMPCORE_HEADER * in its dump file. @@ -253,7 +302,9 @@ */ #define XEN_ELFNOTE_DUMPCORE_HEADER 0x2000001 -/* +/** + * DOC: XEN_ELFNOTE_DUMPCORE_XEN_VERSION + * * xen dump-core xen version note. * xm dump-core code will create one XEN_ELFNOTE_DUMPCORE_XEN_VERSION * in its dump file. It contains the xen version obtained via the @@ -262,7 +313,9 @@ */ #define XEN_ELFNOTE_DUMPCORE_XEN_VERSION 0x2000002 -/* +/** + * DOC: XEN_ELFNOTE_DUMPCORE_FORMAT_VERSION + * * xen dump-core format version note. * xm dump-core code will create one XEN_ELFNOTE_DUMPCORE_FORMAT_VERSION * in its dump file. It contains a format version identifier. -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:50:05 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 23:50:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3pe9-00058Z-RN; Thu, 06 Aug 2020 23:50:05 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3pe7-0004FE-NY for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 23:50:03 +0000 X-Inumbo-ID: acef60d6-8127-41b1-b47d-007f07aad2ee Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id acef60d6-8127-41b1-b47d-007f07aad2ee; Thu, 06 Aug 2020 23:49:44 +0000 (UTC) Received: from sstabellini-ThinkPad-T480s.hsd1.ca.comcast.net (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ABBB022D05; Thu, 6 Aug 2020 23:49:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596757784; bh=yQnpCwRzQRezG1HLCjIgl3OYzzzq49k+wYugXLQJyAI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GoPnk3i/qJwzSEur0lzoCIjYmaYRcSzecusHlF0ttuHjXBZJnobJ1Lhmn6/6i0HVq Eyab6U0bEr2uhbV4T9SRO/VG8iSBrmYslv5z6eDpPIM+LUgL4lrU+aSZVTUEZxlGNj //EDQoIqEU7Z6tAyZnWnM5/amKvNQBZ1lvNlQl7U= From: Stefano Stabellini To: xen-devel@lists.xenproject.org Subject: [PATCH 14/14] kernel-doc: public/hvm/params.h Date: Thu, 6 Aug 2020 16:49:33 -0700 Message-Id: <20200806234933.16448-14-sstabellini@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: sstabellini@kernel.org, julien@xen.org, wl@xen.org, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, Stefano Stabellini Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Stefano Stabellini Convert in-code comments to kernel-doc format wherever possible. Signed-off-by: Stefano Stabellini --- xen/include/public/hvm/params.h | 158 +++++++++++++++++++++++++------- 1 file changed, 124 insertions(+), 34 deletions(-) diff --git a/xen/include/public/hvm/params.h b/xen/include/public/hvm/params.h index 0a91bfa749..1f2a9fe4f9 100644 --- a/xen/include/public/hvm/params.h +++ b/xen/include/public/hvm/params.h @@ -40,13 +40,16 @@ #endif /* defined(__XEN__) || defined(__XEN_TOOLS__) */ -/* +/** + * DOC: HVMOP_set_param and HVMOP_get_param * Parameter space for HVMOP_{set,get}_param. */ #define HVM_PARAM_CALLBACK_IRQ 0 #define HVM_PARAM_CALLBACK_IRQ_TYPE_MASK xen_mk_ullong(0xFF00000000000000) -/* +/** + * DOC: HVM_PARAM_CALLBACK_* + * * How should CPU0 event-channel notifications be delivered? * * If val == 0 then CPU0 event-channel notifications are not delivered. @@ -54,26 +57,34 @@ */ #define HVM_PARAM_CALLBACK_TYPE_GSI 0 -/* +/** + * DOC: HVM_PARAM_CALLBACK_TYPE_GSI + * * val[55:0] is a delivery GSI. GSI 0 cannot be used, as it aliases val == 0, * and disables all notifications. */ #define HVM_PARAM_CALLBACK_TYPE_PCI_INTX 1 -/* +/** + * DOC: HVM_PARAM_CALLBACK_TYPE_PCI_INTX + * * val[55:0] is a delivery PCI INTx line: * Domain = val[47:32], Bus = val[31:16] DevFn = val[15:8], IntX = val[1:0] */ #if defined(__i386__) || defined(__x86_64__) #define HVM_PARAM_CALLBACK_TYPE_VECTOR 2 -/* +/** + * DOC: HVM_PARAM_CALLBACK_TYPE_VECTOR + * * val[7:0] is a vector number. Check for XENFEAT_hvm_callback_vector to know * if this delivery method is available. */ #elif defined(__arm__) || defined(__aarch64__) #define HVM_PARAM_CALLBACK_TYPE_PPI 2 -/* +/** + * DOC: HVM_PARAM_CALLBACK_TYPE_PPI + * * val[55:16] needs to be zero. * val[15:8] is interrupt flag of the PPI used by event-channel: * bit 8: the PPI is edge(1) or level(0) triggered @@ -86,7 +97,9 @@ #define HVM_PARAM_CALLBACK_TYPE_PPI_FLAG_LOW_LEVEL 2 #endif -/* +/** + * DOC: HVM_PARAM_STORE_*, HVM_PARAM_IOREQ_PFN, HVM_PARAM_BUFIOREQ_PFN + * * These are not used by Xen. They are here for convenience of HVM-guest * xenbus implementations. */ @@ -99,7 +112,9 @@ #if defined(__i386__) || defined(__x86_64__) -/* +/** + * DOC: HVM_PARAM_VIRIDIAN + * * Viridian enlightenments * * (See http://download.microsoft.com/download/A/B/4/AB43A34E-BDD0-4FA6-BDEF-79EEF16E880B/Hypervisor%20Top%20Level%20Functional%20Specification%20v4.0.docx) @@ -110,7 +125,10 @@ */ #define HVM_PARAM_VIRIDIAN 9 -/* Base+Freq viridian feature sets: +/** + * DOC: HVMPV_base_freq + * + * Base+Freq viridian feature sets: * * - Hypercall MSRs (HV_X64_MSR_GUEST_OS_ID and HV_X64_MSR_HYPERCALL) * - APIC access MSRs (HV_X64_MSR_EOI, HV_X64_MSR_ICR and HV_X64_MSR_TPR) @@ -123,7 +141,10 @@ /* Feature set modifications */ -/* Disable timer frequency MSRs (HV_X64_MSR_TSC_FREQUENCY and +/** + * DOC: HVMPV_no_freq + * + * Disable timer frequency MSRs (HV_X64_MSR_TSC_FREQUENCY and * HV_X64_MSR_APIC_FREQUENCY). * This modification restores the viridian feature set to the * original 'base' set exposed in releases prior to Xen 4.4. @@ -131,35 +152,59 @@ #define _HVMPV_no_freq 1 #define HVMPV_no_freq (1 << _HVMPV_no_freq) -/* Enable Partition Time Reference Counter (HV_X64_MSR_TIME_REF_COUNT) */ +/** + * DOC: HVMPV_time_ref_count + * Enable Partition Time Reference Counter (HV_X64_MSR_TIME_REF_COUNT) + */ #define _HVMPV_time_ref_count 2 #define HVMPV_time_ref_count (1 << _HVMPV_time_ref_count) -/* Enable Reference TSC Page (HV_X64_MSR_REFERENCE_TSC) */ +/** + * DOC: HVMPV_reference_tsc + * Enable Reference TSC Page (HV_X64_MSR_REFERENCE_TSC) + */ #define _HVMPV_reference_tsc 3 #define HVMPV_reference_tsc (1 << _HVMPV_reference_tsc) -/* Use Hypercall for remote TLB flush */ +/** + * DOC: HVMPV_hcall_remote_tlb_flush + * Use Hypercall for remote TLB flush + */ #define _HVMPV_hcall_remote_tlb_flush 4 #define HVMPV_hcall_remote_tlb_flush (1 << _HVMPV_hcall_remote_tlb_flush) -/* Use APIC assist */ +/** + * DOC: HVMPV_apic_assist + * Use APIC assist + */ #define _HVMPV_apic_assist 5 #define HVMPV_apic_assist (1 << _HVMPV_apic_assist) -/* Enable crash MSRs */ +/** + * DOC: HVMPV_crash_ctl + * Enable crash MSRs + */ #define _HVMPV_crash_ctl 6 #define HVMPV_crash_ctl (1 << _HVMPV_crash_ctl) -/* Enable SYNIC MSRs */ +/** + * DOC: HVMPV_synic + * Enable SYNIC MSRs + */ #define _HVMPV_synic 7 #define HVMPV_synic (1 << _HVMPV_synic) -/* Enable STIMER MSRs */ +/** + * DOC: HVMPV_stimer + * Enable STIMER MSRs + */ #define _HVMPV_stimer 8 #define HVMPV_stimer (1 << _HVMPV_stimer) -/* Use Synthetic Cluster IPI Hypercall */ +/** + * DOC: HVMPV_hcall_ipi + * Use Synthetic Cluster IPI Hypercall + */ #define _HVMPV_hcall_ipi 9 #define HVMPV_hcall_ipi (1 << _HVMPV_hcall_ipi) @@ -177,7 +222,9 @@ #endif -/* +/** + * DOC: HVM_PARAM_TIMER_MODE + * * Set mode for virtual timers (currently x86 only): * delay_for_missed_ticks (default): * Do not advance a vcpu's time beyond the correct delivery time for @@ -202,26 +249,47 @@ #define HVMPTM_no_missed_ticks_pending 2 #define HVMPTM_one_missed_tick_pending 3 -/* Boolean: Enable virtual HPET (high-precision event timer)? (x86-only) */ +/** + * DOC: HVM_PARAM_HPET_ENABLED + * Boolean: Enable virtual HPET (high-precision event timer)? (x86-only) + */ #define HVM_PARAM_HPET_ENABLED 11 -/* Identity-map page directory used by Intel EPT when CR0.PG=0. */ +/** + * DOC: HVM_PARAM_IDENT_PT + * Identity-map page directory used by Intel EPT when CR0.PG=0. + */ #define HVM_PARAM_IDENT_PT 12 -/* ACPI S state: currently support S0 and S3 on x86. */ +/** + * DOC: HVM_PARAM_ACPI_S_STATE + * ACPI S state: currently support S0 and S3 on x86. + */ #define HVM_PARAM_ACPI_S_STATE 14 -/* TSS used on Intel when CR0.PE=0. */ +/** + * DOC: HVM_PARAM_VM86_TSS + * TSS used on Intel when CR0.PE=0. + */ #define HVM_PARAM_VM86_TSS 15 -/* Boolean: Enable aligning all periodic vpts to reduce interrupts */ +/** + * DOC: HVM_PARAM_VPT_ALIGN + * Boolean: Enable aligning all periodic vpts to reduce interrupts + */ #define HVM_PARAM_VPT_ALIGN 16 -/* Console debug shared memory ring and event channel */ +/** + * DOC: HVM_PARAM_CONSOLE_PFN and HVM_PARAM_CONSOLE_EVTCHN + * + * Console debug shared memory ring and event channel + */ #define HVM_PARAM_CONSOLE_PFN 17 #define HVM_PARAM_CONSOLE_EVTCHN 18 -/* +/** + * DOC: HVM_PARAM_ACPI_IOPORTS_LOCATION + * * Select location of ACPI PM1a and TMR control blocks. Currently two locations * are supported, specified by version 0 or 1 in this parameter: * - 0: default, use the old addresses @@ -232,24 +300,39 @@ */ #define HVM_PARAM_ACPI_IOPORTS_LOCATION 19 -/* Boolean: Enable nestedhvm (hvm only) */ +/** + * DOC: HVM_PARAM_NESTEDHVM + * Boolean: Enable nestedhvm (hvm only) + */ #define HVM_PARAM_NESTEDHVM 24 -/* Params for the mem event rings */ +/** + * DOC: HVM_PARAM_*_RING_PFN + * + * Params for the mem event rings + */ #define HVM_PARAM_PAGING_RING_PFN 27 #define HVM_PARAM_MONITOR_RING_PFN 28 #define HVM_PARAM_SHARING_RING_PFN 29 -/* SHUTDOWN_* action in case of a triple fault */ +/** + * DOC: HVM_PARAM_TRIPLE_FAULT_REASON + * SHUTDOWN_* action in case of a triple fault + */ #define HVM_PARAM_TRIPLE_FAULT_REASON 31 #define HVM_PARAM_IOREQ_SERVER_PFN 32 #define HVM_PARAM_NR_IOREQ_SERVER_PAGES 33 -/* Location of the VM Generation ID in guest physical address space. */ +/** + * DOC: HVM_PARAM_VM_GENERATION_ID_ADDR + * Location of the VM Generation ID in guest physical address space. + */ #define HVM_PARAM_VM_GENERATION_ID_ADDR 34 -/* +/** + * DOC: HVM_PARAM_ALTP2M + * * Set mode for altp2m: * disabled: don't activate altp2m (default) * mixed: allow access to all altp2m ops for both in-guest and external tools @@ -267,7 +350,9 @@ #define XEN_ALTP2M_external 2 #define XEN_ALTP2M_limited 3 -/* +/** + * DOC: HVM_PARAM_X87_FIP_WIDTH + * * Size of the x87 FPU FIP/FDP registers that the hypervisor needs to * save/restore. This is a workaround for a hardware limitation that * does not allow the full FIP/FDP and FCS/FDS to be restored. @@ -289,13 +374,18 @@ */ #define HVM_PARAM_X87_FIP_WIDTH 36 -/* +/** + * DOC: HVM_PARAM_VM86_TSS_SIZED + * * TSS (and its size) used on Intel when CR0.PE=0. The address occupies * the low 32 bits, while the size is in the high 32 ones. */ #define HVM_PARAM_VM86_TSS_SIZED 37 -/* Enable MCA capabilities. */ +/** + * DOC: HVM_PARAM_MCA_CAP + * Enable MCA capabilities. + */ #define HVM_PARAM_MCA_CAP 38 #define XEN_HVM_MCA_CAP_LMCE (xen_mk_ullong(1) << 0) #define XEN_HVM_MCA_CAP_MASK XEN_HVM_MCA_CAP_LMCE -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:50:10 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2020 23:50:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3peE-0005Nf-5p; Thu, 06 Aug 2020 23:50:10 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3peC-0004FE-Ns for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 23:50:08 +0000 X-Inumbo-ID: f60b2582-df49-4385-8d51-593f62dafe57 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f60b2582-df49-4385-8d51-593f62dafe57; Thu, 06 Aug 2020 23:49:43 +0000 (UTC) Received: from sstabellini-ThinkPad-T480s.hsd1.ca.comcast.net (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A248722D06; Thu, 6 Aug 2020 23:49:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596757783; bh=1PV4YQrQf7k0QK17w6CBpGmWSxJkpL6AY83QSU2LVic=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xsrFBROCfr8GH2k/GnGdCOZik27g0nJi3O70BoNb4WpSwoaIzkfPE6Z/BRx+7+XGX aFATLgr8tj0pQGJlIgDQNyjYKKKGXLIsQreWe3SGxdA9L+iqVVHxsUk9ZVCHIzx71K 0ZZkVCsataJDIwzjX8I/tGamiy9k2utMhE2PF020= From: Stefano Stabellini To: xen-devel@lists.xenproject.org Subject: [PATCH 12/14] kernel-doc: public/xen.h Date: Thu, 6 Aug 2020 16:49:31 -0700 Message-Id: <20200806234933.16448-12-sstabellini@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: sstabellini@kernel.org, julien@xen.org, wl@xen.org, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, Stefano Stabellini Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Stefano Stabellini Convert in-code comments to kernel-doc format wherever possible. Signed-off-by: Stefano Stabellini --- xen/include/public/xen.h | 567 ++++++++++++++++++++++++++------------- 1 file changed, 378 insertions(+), 189 deletions(-) diff --git a/xen/include/public/xen.h b/xen/include/public/xen.h index 945ef30273..ff1a62209d 100644 --- a/xen/include/public/xen.h +++ b/xen/include/public/xen.h @@ -81,14 +81,63 @@ DEFINE_XEN_GUEST_HANDLE(xen_ulong_t); #endif -/* - * HYPERCALLS - */ - -/* `incontents 100 hcalls List of hypercalls - * ` enum hypercall_num { // __HYPERVISOR_* => HYPERVISOR_*() +/** + * DOC: HYPERCALLS + * + * List of hypercalls + * + * - __HYPERVISOR_set_trap_table + * - __HYPERVISOR_mmu_update + * - __HYPERVISOR_set_gdt + * - __HYPERVISOR_stack_switch + * - __HYPERVISOR_set_callbacks + * - __HYPERVISOR_fpu_taskswitch + * - __HYPERVISOR_sched_op_compat + * - __HYPERVISOR_platform_op + * - __HYPERVISOR_set_debugreg + * - __HYPERVISOR_get_debugreg + * - __HYPERVISOR_update_descriptor + * - __HYPERVISOR_memory_op + * - __HYPERVISOR_multicall + * - __HYPERVISOR_update_va_mapping + * - __HYPERVISOR_set_timer_op + * - __HYPERVISOR_event_channel_op_compat + * - __HYPERVISOR_xen_version + * - __HYPERVISOR_console_io + * - __HYPERVISOR_physdev_op_compat + * - __HYPERVISOR_grant_table_op + * - __HYPERVISOR_vm_assist + * - __HYPERVISOR_update_va_mapping_otherdomain + * - __HYPERVISOR_iret + * - __HYPERVISOR_vcpu_op + * - __HYPERVISOR_set_segment_base + * - __HYPERVISOR_mmuext_op + * - __HYPERVISOR_xsm_op + * - __HYPERVISOR_nmi_op + * - __HYPERVISOR_sched_op + * - __HYPERVISOR_callback_op + * - __HYPERVISOR_xenoprof_op + * - __HYPERVISOR_event_channel_op + * - __HYPERVISOR_physdev_op + * - __HYPERVISOR_hvm_op + * - __HYPERVISOR_sysctl + * - __HYPERVISOR_domctl + * - __HYPERVISOR_kexec_op + * - __HYPERVISOR_tmem_op + * - __HYPERVISOR_argo_op + * - __HYPERVISOR_xenpmu_op + * - __HYPERVISOR_dm_op + * - __HYPERVISOR_hypfs_op + * - __HYPERVISOR_arch_0 + * - __HYPERVISOR_arch_1 + * - __HYPERVISOR_arch_2 + * - __HYPERVISOR_arch_3 + * - __HYPERVISOR_arch_4 + * - __HYPERVISOR_arch_5 + * - __HYPERVISOR_arch_6 + * - __HYPERVISOR_arch_7 */ - + /* ` enum hypercall_num { // __HYPERVISOR_* => HYPERVISOR_*() */ #define __HYPERVISOR_set_trap_table 0 #define __HYPERVISOR_mmu_update 1 #define __HYPERVISOR_set_gdt 2 @@ -167,8 +216,8 @@ DEFINE_XEN_GUEST_HANDLE(xen_ulong_t); #define __HYPERVISOR_dom0_op __HYPERVISOR_platform_op #endif -/* - * VIRTUAL INTERRUPTS +/** + * DOC: VIRTUAL INTERRUPTS * * Virtual interrupts that a guest OS may receive from Xen. * @@ -176,21 +225,43 @@ DEFINE_XEN_GUEST_HANDLE(xen_ulong_t); * global VIRQ. The former can be bound once per VCPU and cannot be re-bound. * The latter can be allocated only once per guest: they must initially be * allocated to VCPU0 but can subsequently be re-bound. + * + * - VIRQ_TIMER: V. Timebase update, and/or requested timeout. + * - VIRQ_DEBUG: V. Request guest to dump debug info. + * - VIRQ_CONSOLE: G. (DOM0) Bytes received on emergency console. + * - VIRQ_DOM_EXC: G. (DOM0) Exceptional event for some domain. + * - VIRQ_TBUF: G. (DOM0) Trace buffer has records available. + * - VIRQ_DEBUGGER: G. (DOM0) A domain has paused for debugging. + * - VIRQ_XENOPROF: V. XenOprofile interrupt: new sample available + * - VIRQ_CON_RING: G. (DOM0) Bytes received on console + * - VIRQ_PCPU_STATE: G. (DOM0) PCPU state changed + * - VIRQ_MEM_EVENT: G. (DOM0) A memory event has occurred + * - VIRQ_ARGO: G. Argo interdomain message notification + * - VIRQ_ENOMEM: G. (DOM0) Low on heap memory + * - VIRQ_XENPMU: V. PMC interrupt + * - VIRQ_ARCH_0 + * - VIRQ_ARCH_1 + * - VIRQ_ARCH_2 + * - VIRQ_ARCH_3 + * - VIRQ_ARCH_4 + * - VIRQ_ARCH_5 + * - VIRQ_ARCH_6 + * - VIRQ_ARCH_7 */ /* ` enum virq { */ -#define VIRQ_TIMER 0 /* V. Timebase update, and/or requested timeout. */ -#define VIRQ_DEBUG 1 /* V. Request guest to dump debug info. */ -#define VIRQ_CONSOLE 2 /* G. (DOM0) Bytes received on emergency console. */ -#define VIRQ_DOM_EXC 3 /* G. (DOM0) Exceptional event for some domain. */ -#define VIRQ_TBUF 4 /* G. (DOM0) Trace buffer has records available. */ -#define VIRQ_DEBUGGER 6 /* G. (DOM0) A domain has paused for debugging. */ -#define VIRQ_XENOPROF 7 /* V. XenOprofile interrupt: new sample available */ -#define VIRQ_CON_RING 8 /* G. (DOM0) Bytes received on console */ -#define VIRQ_PCPU_STATE 9 /* G. (DOM0) PCPU state changed */ -#define VIRQ_MEM_EVENT 10 /* G. (DOM0) A memory event has occurred */ -#define VIRQ_ARGO 11 /* G. Argo interdomain message notification */ -#define VIRQ_ENOMEM 12 /* G. (DOM0) Low on heap memory */ -#define VIRQ_XENPMU 13 /* V. PMC interrupt */ +#define VIRQ_TIMER 0 +#define VIRQ_DEBUG 1 +#define VIRQ_CONSOLE 2 +#define VIRQ_DOM_EXC 3 +#define VIRQ_TBUF 4 +#define VIRQ_DEBUGGER 6 +#define VIRQ_XENOPROF 7 +#define VIRQ_CON_RING 8 +#define VIRQ_PCPU_STATE 9 +#define VIRQ_MEM_EVENT 10 +#define VIRQ_ARGO 11 +#define VIRQ_ENOMEM 12 +#define VIRQ_XENPMU 13 /* Architecture-specific VIRQ definitions. */ #define VIRQ_ARCH_0 16 @@ -205,12 +276,14 @@ DEFINE_XEN_GUEST_HANDLE(xen_ulong_t); #define NR_VIRQS 24 -/* - * ` enum neg_errnoval - * ` HYPERVISOR_mmu_update(const struct mmu_update reqs[], - * ` unsigned count, unsigned *done_out, - * ` unsigned foreigndom) - * ` +/** + * DOC: HYPERVISOR_mmu_update + * + * enum neg_errnoval + * HYPERVISOR_mmu_update(const struct mmu_update reqs[], + * unsigned count, unsigned *done_out, + * unsigned foreigndom) + * * @reqs is an array of mmu_update_t structures ((ptr, val) pairs). * @count is the length of the above array. * @pdone is an output parameter indicating number of completed operations @@ -222,8 +295,9 @@ DEFINE_XEN_GUEST_HANDLE(xen_ulong_t); * x == 0 => PFD == DOMID_SELF * x != 0 => PFD == x - 1 * + * * Sub-commands: ptr[1:0] specifies the appropriate MMU_* command. - * ------------- + * * ptr[1:0] == MMU_NORMAL_PT_UPDATE: * Updates an entry in a page table belonging to PFD. If updating an L1 table, * and the new table entry is valid/present, the mapped frame must belong to @@ -354,16 +428,16 @@ DEFINE_XEN_GUEST_HANDLE(xen_ulong_t); #define MMU_PT_UPDATE_NO_TRANSLATE 3 /* checked '*ptr = val'. ptr is MA. */ /* val never translated. */ -/* - * MMU EXTENDED OPERATIONS +/** + * DOC: MMU EXTENDED OPERATIONS * - * ` enum neg_errnoval - * ` HYPERVISOR_mmuext_op(mmuext_op_t uops[], - * ` unsigned int count, - * ` unsigned int *pdone, - * ` unsigned int foreigndom) - */ -/* HYPERVISOR_mmuext_op() accepts a list of mmuext_op structures. + * enum neg_errnoval + * HYPERVISOR_mmuext_op(mmuext_op_t uops[], + * unsigned int count, + * unsigned int *pdone, + * unsigned int foreigndom) + * + * HYPERVISOR_mmuext_op() accepts a list of mmuext_op structures. * A foreigndom (FD) can be specified (or DOMID_SELF for none). * Where the FD has some effect, it is described below. * @@ -468,19 +542,21 @@ typedef struct mmuext_op mmuext_op_t; DEFINE_XEN_GUEST_HANDLE(mmuext_op_t); #endif -/* - * ` enum neg_errnoval - * ` HYPERVISOR_update_va_mapping(unsigned long va, u64 val, - * ` enum uvm_flags flags) - * ` - * ` enum neg_errnoval - * ` HYPERVISOR_update_va_mapping_otherdomain(unsigned long va, u64 val, - * ` enum uvm_flags flags, - * ` domid_t domid) - * ` - * ` @va: The virtual address whose mapping we want to change - * ` @val: The new page table entry, must contain a machine address - * ` @flags: Control TLB flushes +/** + * DOC: HYPERVISOR_update_va_mapping + * + * enum neg_errnoval + * HYPERVISOR_update_va_mapping(unsigned long va, u64 val, + * enum uvm_flags flags) + * + * enum neg_errnoval + * HYPERVISOR_update_va_mapping_otherdomain(unsigned long va, u64 val, + * enum uvm_flags flags, + * domid_t domid) + * + * @va: The virtual address whose mapping we want to change + * @val: The new page table entry, must contain a machine address + * @flags: Control TLB flushes */ /* These are passed as 'flags' to update_va_mapping. They can be ORed. */ /* When specifying UVMF_MULTI, also OR in a pointer to a CPU bitmap. */ @@ -495,11 +571,13 @@ DEFINE_XEN_GUEST_HANDLE(mmuext_op_t); #define UVMF_ALL (xen_mk_ulong(1)<<2) /* Flush all TLBs. */ /* ` } */ -/* - * ` int - * ` HYPERVISOR_console_io(unsigned int cmd, - * ` unsigned int count, - * ` char buffer[]); +/** + * DOC: HYPERVISOR_console_io + * + * int + * HYPERVISOR_console_io(unsigned int cmd, + * unsigned int count, + * char buffer[]); * * @cmd: Command (see below) * @count: Size of the buffer to read/write @@ -522,29 +600,43 @@ DEFINE_XEN_GUEST_HANDLE(mmuext_op_t); #define CONSOLEIO_write 0 #define CONSOLEIO_read 1 -/* +/** + * DOC: VMASST_CMD_enable and VMASST_CMD_disable * Commands to HYPERVISOR_vm_assist(). */ #define VMASST_CMD_enable 0 #define VMASST_CMD_disable 1 -/* x86/32 guests: simulate full 4GB segment limits. */ +/** + * DOC: VMASST_TYPE_4gb_segments + * x86/32 guests: simulate full 4GB segment limits. + */ #define VMASST_TYPE_4gb_segments 0 -/* x86/32 guests: trap (vector 15) whenever above vmassist is used. */ +/** + * DOC: VMASST_TYPE_4gb_segments_notify + * x86/32 guests: trap (vector 15) whenever above vmassist is used. + */ #define VMASST_TYPE_4gb_segments_notify 1 -/* +/** + * DOC: VMASST_TYPE_writable_pagetables + * * x86 guests: support writes to bottom-level PTEs. * NB1. Page-directory entries cannot be written. * NB2. Guest must continue to remove all writable mappings of PTEs. */ #define VMASST_TYPE_writable_pagetables 2 -/* x86/PAE guests: support PDPTs above 4GB. */ +/** + * DOC: VMASST_TYPE_pae_extended_cr3 + * x86/PAE guests: support PDPTs above 4GB. + */ #define VMASST_TYPE_pae_extended_cr3 3 -/* +/** + * DOC: VMASST_TYPE_architectural_iopl + * * x86 guests: Sane behaviour for virtual iopl * - virtual iopl updated from do_iret() hypercalls. * - virtual iopl reported in bounce frames. @@ -552,14 +644,18 @@ DEFINE_XEN_GUEST_HANDLE(mmuext_op_t); */ #define VMASST_TYPE_architectural_iopl 4 -/* +/** + * DOC: VMASST_TYPE_runstate_update_flag + * * All guests: activate update indicator in vcpu_runstate_info * Enable setting the XEN_RUNSTATE_UPDATE flag in guest memory mapped * vcpu_runstate_info during updates of the runstate information. */ #define VMASST_TYPE_runstate_update_flag 5 -/* +/** + * DOC: VMASST_TYPE_m2p_strict + * * x86/64 guests: strictly hide M2P from user mode. * This allows the guest to control respective hypervisor behavior: * - when not set, L4 tables get created with the respective slot blank, @@ -578,10 +674,15 @@ DEFINE_XEN_GUEST_HANDLE(mmuext_op_t); /* Domain ids >= DOMID_FIRST_RESERVED cannot be used for ordinary domains. */ #define DOMID_FIRST_RESERVED xen_mk_uint(0x7FF0) -/* DOMID_SELF is used in certain contexts to refer to oneself. */ +/** + * DOC: DOMID_SELF + * DOMID_SELF is used in certain contexts to refer to oneself. + */ #define DOMID_SELF xen_mk_uint(0x7FF0) -/* +/** + * DOC: DOMID_IO + * * DOMID_IO is used to restrict page-table updates to mapping I/O memory. * Although no Foreign Domain need be specified to map I/O pages, DOMID_IO * is useful to ensure that no mappings to the OS's own heap are accidentally @@ -594,7 +695,9 @@ DEFINE_XEN_GUEST_HANDLE(mmuext_op_t); */ #define DOMID_IO xen_mk_uint(0x7FF1) -/* +/** + * DOC: DOMID_XEN + * * DOMID_XEN is used to allow privileged domains to map restricted parts of * Xen's heap space (e.g., the machine_to_phys table). * This only makes sense as @@ -605,38 +708,55 @@ DEFINE_XEN_GUEST_HANDLE(mmuext_op_t); */ #define DOMID_XEN xen_mk_uint(0x7FF2) -/* - * DOMID_COW is used as the owner of sharable pages */ +/** + * DOC: DOMID_COW + * DOMID_COW is used as the owner of sharable pages + */ #define DOMID_COW xen_mk_uint(0x7FF3) -/* DOMID_INVALID is used to identify pages with unknown owner. */ +/** + * DOC: DOMID_INVALID + * DOMID_INVALID is used to identify pages with unknown owner. + */ #define DOMID_INVALID xen_mk_uint(0x7FF4) -/* Idle domain. */ +/** + * DOC: DOMID_IDLE + * Idle domain. + */ #define DOMID_IDLE xen_mk_uint(0x7FFF) -/* Mask for valid domain id values */ +/** + * DOC: DOMID_MASK + * Mask for valid domain id values + */ #define DOMID_MASK xen_mk_uint(0x7FFF) #ifndef __ASSEMBLY__ typedef uint16_t domid_t; -/* +/** + * struct mmu_update - HYPERVISOR_mmu_update + * * Send an array of these to HYPERVISOR_mmu_update(). * NB. The fields are natural pointer/address size for this architecture. */ struct mmu_update { - uint64_t ptr; /* Machine address of PTE. */ - uint64_t val; /* New contents of PTE. */ + /** @ptr: Machine address of PTE. */ + uint64_t ptr; + /** @val: New contents of PTE. */ + uint64_t val; }; typedef struct mmu_update mmu_update_t; DEFINE_XEN_GUEST_HANDLE(mmu_update_t); -/* - * ` enum neg_errnoval - * ` HYPERVISOR_multicall(multicall_entry_t call_list[], - * ` uint32_t nr_calls); +/** + * struct multicall_entry - HYPERVISOR_multicall + * + * enum neg_errnoval + * HYPERVISOR_multicall(multicall_entry_t call_list[], + * uint32_t nr_calls); * * NB. The fields are logically the natural register size for this * architecture. In cases where xen_ulong_t is larger than this then @@ -650,34 +770,40 @@ typedef struct multicall_entry multicall_entry_t; DEFINE_XEN_GUEST_HANDLE(multicall_entry_t); #if __XEN_INTERFACE_VERSION__ < 0x00040400 -/* +/** + * DOC: NR_EVENT_CHANNELS + * * Event channel endpoints per domain (when using the 2-level ABI): * 1024 if a long is 32 bits; 4096 if a long is 64 bits. */ #define NR_EVENT_CHANNELS EVTCHN_2L_NR_CHANNELS #endif +/** + * struct vcpu_time_info + * + * Updates to the following values are preceded and followed by an + * increment of 'version'. The guest can therefore detect updates by + * looking for changes to 'version'. If the least-significant bit of + * the version number is set then an update is in progress and the guest + * must wait to read a consistent set of values. + * The correct way to interact with the version number is similar to + * Linux's seqlock: see the implementations of read_seqbegin/read_seqretry. + * + * Current system time: + * system_time + + * ((((tsc - tsc_timestamp) << tsc_shift) * tsc_to_system_mul) >> 32) + * CPU frequency (Hz): + * ((10^9 << 32) / tsc_to_system_mul) >> tsc_shift + */ struct vcpu_time_info { - /* - * Updates to the following values are preceded and followed by an - * increment of 'version'. The guest can therefore detect updates by - * looking for changes to 'version'. If the least-significant bit of - * the version number is set then an update is in progress and the guest - * must wait to read a consistent set of values. - * The correct way to interact with the version number is similar to - * Linux's seqlock: see the implementations of read_seqbegin/read_seqretry. - */ uint32_t version; uint32_t pad0; - uint64_t tsc_timestamp; /* TSC at last update of time vals. */ - uint64_t system_time; /* Time, in nanosecs, since boot. */ - /* - * Current system time: - * system_time + - * ((((tsc - tsc_timestamp) << tsc_shift) * tsc_to_system_mul) >> 32) - * CPU frequency (Hz): - * ((10^9 << 32) / tsc_to_system_mul) >> tsc_shift - */ + /** @tsc_timestamp: TSC at last update of time vals. */ + uint64_t tsc_timestamp; + /** @system_time: Time, in nanosecs, since boot. */ + uint64_t system_time; + uint32_t tsc_to_system_mul; int8_t tsc_shift; #if __XEN_INTERFACE_VERSION__ > 0x040600 @@ -692,18 +818,23 @@ typedef struct vcpu_time_info vcpu_time_info_t; #define XEN_PVCLOCK_TSC_STABLE_BIT (1 << 0) #define XEN_PVCLOCK_GUEST_STOPPED (1 << 1) +/** + * struct vcpu_info + */ struct vcpu_info { - /* - * 'evtchn_upcall_pending' is written non-zero by Xen to indicate - * a pending notification for a particular VCPU. It is then cleared - * by the guest OS /before/ checking for pending work, thus avoiding - * a set-and-check race. Note that the mask is only accessed by Xen - * on the CPU that is currently hosting the VCPU. This means that the - * pending and mask flags can be updated by the guest without special - * synchronisation (i.e., no need for the x86 LOCK prefix). - * This may seem suboptimal because if the pending flag is set by - * a different CPU then an IPI may be scheduled even when the mask - * is set. However, note: + /** + * @evtchn_upcall_pending: + * + * it is written non-zero by Xen to indicate a pending notification + * for a particular VCPU. It is then cleared by the guest OS + * /before/ checking for pending work, thus avoiding a set-and-check + * race. Note that the mask is only accessed by Xen on the CPU that + * is currently hosting the VCPU. This means that the pending and + * mask flags can be updated by the guest without special + * synchronisation (i.e., no need for the x86 LOCK prefix). This + * may seem suboptimal because if the pending flag is set by a + * different CPU then an IPI may be scheduled even when the mask is + * set. However, note: * 1. The task of 'interrupt holdoff' is covered by the per-event- * channel mask bits. A 'noisy' event that is continually being * triggered can be masked at source at this very precise @@ -732,61 +863,69 @@ struct vcpu_info { typedef struct vcpu_info vcpu_info_t; #endif -/* - * `incontents 200 startofday_shared Start-of-day shared data structure +/** + * struct shared_info - Start-of-day shared data structure + * * Xen/kernel shared data -- pointer provided in start_info. * * This structure is defined to be both smaller than a page, and the * only data on the shared page, but may vary in actual size even within * compatible Xen versions; guests should not rely on the size * of this structure remaining constant. + * + * A domain can create "event channels" on which it can send and receive + * asynchronous event notifications. There are three classes of event that + * are delivered by this mechanism: + * 1. Bi-directional inter- and intra-domain connections. Domains must + * arrange out-of-band to set up a connection (usually by allocating + * an unbound 'listener' port and avertising that via a storage service + * such as xenstore). + * 2. Physical interrupts. A domain with suitable hardware-access + * privileges can bind an event-channel port to a physical interrupt + * source. + * 3. Virtual interrupts ('events'). A domain can bind an event-channel + * port to a virtual interrupt source, such as the virtual-timer + * device or the emergency console. + * + * + * @evtchn_pending: pending notifications + * @evtchn_mask: mask/unmask notifications + * + * Event channels are addressed by a "port index". Each channel is + * associated with two bits of information: + * 1. PENDING -- notifies the domain that there is a pending notification + * to be processed. This bit is cleared by the guest. + * 2. MASK -- if this bit is clear then a 0->1 transition of PENDING + * will cause an asynchronous upcall to be scheduled. This bit is only + * updated by the guest. It is read-only within Xen. If a channel + * becomes pending while the channel is masked then the 'edge' is lost + * (i.e., when the channel is unmasked, the guest must manually handle + * pending notifications as no upcall will be scheduled by Xen). + * + * To expedite scanning of pending notifications, any 0->1 pending + * transition on an unmasked channel causes a corresponding bit in a + * per-vcpu selector word to be set. Each bit in the selector covers a + * 'C long' in the PENDING bitfield array. + * + * + * @wc_version: wallclock time version + * @wc_sec: secs offset from Unix epoc + * @wc_nsec: nsecs offset from Unix epoc + * + * Wallclock time: updated by control software or RTC emulation. + * Guests should base their gettimeofday() syscall on this + * wallclock-base value. + * The values of wc_sec and wc_nsec are offsets from the Unix epoch + * adjusted by the domain's 'time offset' (in seconds) as set either + * by XEN_DOMCTL_settimeoffset, or adjusted via a guest write to the + * emulated RTC. */ struct shared_info { struct vcpu_info vcpu_info[XEN_LEGACY_MAX_VCPUS]; - /* - * A domain can create "event channels" on which it can send and receive - * asynchronous event notifications. There are three classes of event that - * are delivered by this mechanism: - * 1. Bi-directional inter- and intra-domain connections. Domains must - * arrange out-of-band to set up a connection (usually by allocating - * an unbound 'listener' port and avertising that via a storage service - * such as xenstore). - * 2. Physical interrupts. A domain with suitable hardware-access - * privileges can bind an event-channel port to a physical interrupt - * source. - * 3. Virtual interrupts ('events'). A domain can bind an event-channel - * port to a virtual interrupt source, such as the virtual-timer - * device or the emergency console. - * - * Event channels are addressed by a "port index". Each channel is - * associated with two bits of information: - * 1. PENDING -- notifies the domain that there is a pending notification - * to be processed. This bit is cleared by the guest. - * 2. MASK -- if this bit is clear then a 0->1 transition of PENDING - * will cause an asynchronous upcall to be scheduled. This bit is only - * updated by the guest. It is read-only within Xen. If a channel - * becomes pending while the channel is masked then the 'edge' is lost - * (i.e., when the channel is unmasked, the guest must manually handle - * pending notifications as no upcall will be scheduled by Xen). - * - * To expedite scanning of pending notifications, any 0->1 pending - * transition on an unmasked channel causes a corresponding bit in a - * per-vcpu selector word to be set. Each bit in the selector covers a - * 'C long' in the PENDING bitfield array. - */ xen_ulong_t evtchn_pending[sizeof(xen_ulong_t) * 8]; xen_ulong_t evtchn_mask[sizeof(xen_ulong_t) * 8]; - /* - * Wallclock time: updated by control software or RTC emulation. - * Guests should base their gettimeofday() syscall on this - * wallclock-base value. - * The values of wc_sec and wc_nsec are offsets from the Unix epoch - * adjusted by the domain's 'time offset' (in seconds) as set either - * by XEN_DOMCTL_settimeoffset, or adjusted via a guest write to the - * emulated RTC. - */ uint32_t wc_version; /* Version counter: see vcpu_time_info_t. */ uint32_t wc_sec; uint32_t wc_nsec; @@ -804,8 +943,9 @@ struct shared_info { typedef struct shared_info shared_info_t; #endif -/* - * `incontents 200 startofday Start-of-day memory layout +#ifdef XEN_HAVE_PV_GUEST_ENTRY +/** + * struct start_info - Start-of-day memory layout * * 1. The domain is started within contiguous virtual-memory region. * 2. The contiguous region ends on an aligned 4MB boundary. @@ -841,38 +981,72 @@ typedef struct shared_info shared_info_t; * 32-bit and runs under a 64-bit hypervisor should _NOT_ use two of the * pages preceding pt_base and mark them as reserved/unused. */ -#ifdef XEN_HAVE_PV_GUEST_ENTRY struct start_info { /* THE FOLLOWING ARE FILLED IN BOTH ON INITIAL BOOT AND ON RESUME. */ - char magic[32]; /* "xen--". */ - unsigned long nr_pages; /* Total pages allocated to this domain. */ - unsigned long shared_info; /* MACHINE address of shared info struct. */ - uint32_t flags; /* SIF_xxx flags. */ - xen_pfn_t store_mfn; /* MACHINE page number of shared page. */ - uint32_t store_evtchn; /* Event channel for store communication. */ + /** @magic: "xen--". */ + char magic[32]; + /** @nr_pages: Total pages allocated to this domain. */ + unsigned long nr_pages; + /** @shared_info: MACHINE address of shared info struct. */ + unsigned long shared_info; + /** flags: SIF_xxx flags. */ + uint32_t flags; + /** @store_mfn: MACHINE page number of shared page. */ + xen_pfn_t store_mfn; + /** @store_evtchn: Event channel for store communication. */ + uint32_t store_evtchn; union { struct { - xen_pfn_t mfn; /* MACHINE page number of console page. */ - uint32_t evtchn; /* Event channel for console page. */ + /** + * @console.domU.mfn: MACHINE page number of console page. + */ + xen_pfn_t mfn; + /** + * @console.domU.evtchn: Event channel for console page. + */ + uint32_t evtchn; } domU; struct { - uint32_t info_off; /* Offset of console_info struct. */ - uint32_t info_size; /* Size of console_info struct from start.*/ + /** + * @console.dom0.info_off: Offset of console_info struct. + */ + uint32_t info_off; + /** + * @info_size: Size of console_info struct from start. + */ + uint32_t info_size; } dom0; } console; /* THE FOLLOWING ARE ONLY FILLED IN ON INITIAL BOOT (NOT RESUME). */ - unsigned long pt_base; /* VIRTUAL address of page directory. */ - unsigned long nr_pt_frames; /* Number of bootstrap p.t. frames. */ - unsigned long mfn_list; /* VIRTUAL address of page-frame list. */ - unsigned long mod_start; /* VIRTUAL address of pre-loaded module */ - /* (PFN of pre-loaded module if */ - /* SIF_MOD_START_PFN set in flags). */ - unsigned long mod_len; /* Size (bytes) of pre-loaded module. */ + /** @pt_base: VIRTUAL address of page directory. */ + unsigned long pt_base; + /** @nr_pt_frames: Number of bootstrap p.t. frames. */ + unsigned long nr_pt_frames; + /** @mfn_list: VIRTUAL address of page-frame list. */ + unsigned long mfn_list; + /** + * @mod_start: VIRTUAL address of pre-loaded module. + * (PFN of pre-loaded module if SIF_MOD_START_PFN set in flags). + */ + unsigned long mod_start; + /** @mod_len: Size (bytes) of pre-loaded module. */ + unsigned long mod_len; #define MAX_GUEST_CMDLINE 1024 int8_t cmd_line[MAX_GUEST_CMDLINE]; - /* The pfn range here covers both page table and p->m table frames. */ - unsigned long first_p2m_pfn;/* 1st pfn forming initial P->M table. */ - unsigned long nr_p2m_frames;/* # of pfns forming initial P->M table. */ + /** + * @first_p2m_pfn: + * + * 1st pfn forming initial P->M table from the pfn range that covers + * both page table and p->m table frames. + */ + unsigned long first_p2m_pfn; + /** + * @nr_p2m_frames: + * + * # of pfns forming initial P->M table from the pfn range that + * covers both page table and p->m table frames. + */ + unsigned long nr_p2m_frames; }; typedef struct start_info start_info_t; @@ -883,16 +1057,29 @@ typedef struct start_info start_info_t; #endif #endif /* XEN_HAVE_PV_GUEST_ENTRY */ -/* These flags are passed in the 'flags' field of start_info_t. */ -#define SIF_PRIVILEGED (1<<0) /* Is the domain privileged? */ -#define SIF_INITDOMAIN (1<<1) /* Is this the initial control domain? */ -#define SIF_MULTIBOOT_MOD (1<<2) /* Is mod_start a multiboot module? */ -#define SIF_MOD_START_PFN (1<<3) /* Is mod_start a PFN? */ -#define SIF_VIRT_P2M_4TOOLS (1<<4) /* Do Xen tools understand a virt. mapped */ - /* P->M making the 3 level tree obsolete? */ -#define SIF_PM_MASK (0xFF<<8) /* reserve 1 byte for xen-pm options */ - -/* +/** + * DOC: SIF_* + * + * These flags are passed in the 'flags' field of start_info_t. + * + * - SIF_PRIVILEGED: Is the domain privileged? + * - SIF_INITDOMAIN: Is this the initial control domain? + * - SIF_MULTIBOOT_MOD: Is mod_start a multiboot module? + * - SIF_MOD_START_PFN: Is mod_start a PFN? + * - SIF_VIRT_P2M_4TOOLS: Do Xen tools understand a virt. mapped + * P->M making the 3 level tree obsolete? + * - SIF_PM_MASK: reserve 1 byte for xen-pm options + */ +#define SIF_PRIVILEGED (1<<0) +#define SIF_INITDOMAIN (1<<1) +#define SIF_MULTIBOOT_MOD (1<<2) +#define SIF_MOD_START_PFN (1<<3) +#define SIF_VIRT_P2M_4TOOLS (1<<4) +#define SIF_PM_MASK (0xFF<<8) + +/** + * struct xen_multiboot_mod_list + * * A multiboot module is a package containing modules very similar to a * multiboot module array. The only differences are: * - the array of module descriptors is by convention simply at the beginning @@ -908,13 +1095,13 @@ typedef struct start_info start_info_t; */ struct xen_multiboot_mod_list { - /* Address of first byte of the module */ + /** @mod_start: Address of first byte of the module */ uint32_t mod_start; - /* Address of last byte of the module (inclusive) */ + /** @mod_end: Address of last byte of the module (inclusive) */ uint32_t mod_end; - /* Address of zero-terminated command line */ + /** @cmdline: Address of zero-terminated command line */ uint32_t cmdline; - /* Unused, must be zero */ + /** @pad: Unused, must be zero */ uint32_t pad; }; /* @@ -984,7 +1171,9 @@ typedef struct { uint8_t a[16]; } xen_uuid_t; -/* +/** + * DOC: XEN_DEFINE_UUID + * * XEN_DEFINE_UUID(0x00112233, 0x4455, 0x6677, 0x8899, * 0xaa, 0xbb, 0xcc, 0xdd, 0xee, 0xff) * will construct UUID 00112233-4455-6677-8899-aabbccddeeff presented as -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri Aug 07 03:26:19 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 03:26:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3t11-0004dw-Eg; Fri, 07 Aug 2020 03:25:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3t10-0004dV-Rm for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 03:25:54 +0000 X-Inumbo-ID: 6ef7ef97-80a4-4aee-b1c7-1ef842d9fa7f Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6ef7ef97-80a4-4aee-b1c7-1ef842d9fa7f; Fri, 07 Aug 2020 03:25:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=klo+F4ldPHfSN22YaqHE7EZhk7mPIRWxRUqgh1HhR0A=; b=OXma7w9TbftWxKOOMjWB98ar3 vuWN6k9L/y6yTjArbGL1nWbEGbrggKqWjY/NRw9qgqNg1oCvAQFN/vpHWH/Nji8sc5AWpaain5894 NJaqbsBYk+NnYQ/zmJhLamd/0ojXS6ekMhFBwO8rOybSNvPsZMCoTr9fwxDXBAhMa97bc=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3t0r-0003RD-L9; Fri, 07 Aug 2020 03:25:45 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k3t0r-0008K9-9U; Fri, 07 Aug 2020 03:25:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k3t0r-0000gu-86; Fri, 07 Aug 2020 03:25:45 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 152498: regressions - FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-examine:memdisk-try-append:fail:regression xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking X-Osstest-Versions-This: xen=b2bc1e714462c6cc222e3bbc38d87b039b4fa405 X-Osstest-Versions-That: xen=81fd0d3ca4b2cd309403c6e8da662c325dd35750 From: osstest service owner Date: Fri, 07 Aug 2020 03:25:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152498 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/152498/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-examine 4 memdisk-try-append fail REGR. vs. 152418 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail like 152418 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail like 152418 test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail like 152418 test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail like 152418 test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail like 152418 test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 152418 test-armhf-armhf-libvirt 14 saverestore-support-check fail like 152418 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail like 152418 test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail like 152418 test-amd64-i386-xl-pvshim 12 guest-start fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass version targeted for testing: xen b2bc1e714462c6cc222e3bbc38d87b039b4fa405 baseline version: xen 81fd0d3ca4b2cd309403c6e8da662c325dd35750 Last test of basis 152418 2020-08-03 11:11:04 Z 3 days Failing since 152461 2020-08-04 07:50:21 Z 2 days 3 attempts Testing same since 152498 2020-08-06 01:55:41 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Wei Liu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit b2bc1e714462c6cc222e3bbc38d87b039b4fa405 Author: Andrew Cooper Date: Wed Aug 5 14:56:11 2020 +0100 x86/tsc: Fix diagnostics for TSC frequency A Gemini Lake platform prints: (XEN) CPU0: TSC: 19200000MHz * 279 / 3 = 1785600000MHz (XEN) CPU0: 800..1800 MHz during boot. The units on the first line are Hz, not MHz, so correct that and add a space for clarity. Also, for the min/max line, use three dots instead of two and add more spaces so that the line can't be mistaken for being a double decimal point typo. Boot now reads: (XEN) CPU0: TSC: 19200000 Hz * 279 / 3 = 1785600000 Hz (XEN) CPU0: 800 ... 1800 MHz Extend these changes to the other TSC diagnostics. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich commit dae7ea5138f72f3ac38367f50d941e8f70628119 Author: Andrew Cooper Date: Wed Aug 5 14:35:16 2020 +0100 x86/ioapic: Improve code generation for __io_apic_{read,write}() The write into REGSEL prevents the optimiser from reusing the address calculation, forcing it to be calcualted twice. The calculation itself is quite expensive. Pull it out into a local varaible. Bloat-o-meter reports: add/remove: 0/0 grow/shrink: 0/26 up/down: 0/-1527 (-1527) Also correct the register type, which is uint32_t, not int. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich commit a8ee9c4d3fb8532a60c6c87abd0fe80b5b03c6e8 Author: Andrew Cooper Date: Wed Aug 5 11:49:15 2020 +0100 x86/ioapic: Fix style in io_apic.h This file is a mix of Xen and Linux styles. Switch it fully to Xen style. No functional change. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich commit b4175c6693e089ffcd77cd1ea388e76e67d36d57 Author: Andrew Cooper Date: Wed Aug 5 12:05:27 2020 +0100 x86/ioapic: Fix fixmap error path logic in ioapic_init_mappings() In the case that bad_ioapic_register() fails, the current position of idx++ means that clear_fixmap(idx) will be called with the wrong index, and not clean up the mapping just created. Increment idx as part of the loop, rather than midway through the loop body. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich commit e58a71274c65e7547fc2e917f051c5c04e2820e2 Author: Jan Beulich Date: Wed Aug 5 10:30:18 2020 +0200 x86emul: correct AVX512_BF16 insn names in EVEX Disp8 test The leading 'v' ought to be omitted from the table entries. Fixes: 7ff66809ccd5 ("x86emul: support AVX512_BF16 insns") Signed-off-by: Jan Beulich Acked-by: Andrew Cooper commit 062aad5190aea2c8a57933c16acae571551a7737 Author: Jan Beulich Date: Wed Aug 5 10:29:55 2020 +0200 x86emul: extend decoding / mem access testing to EVEX-encoded insns Signed-off-by: Jan Beulich Acked-by: Andrew Cooper commit 96137cf1426a1d6419ec9fd205e22b03b2af313d Author: Jan Beulich Date: Wed Aug 5 10:29:18 2020 +0200 x86emul: AVX512PF insns aren't memory accesses These are prefetches, so should be treated just like other prefetches. Fixes: 467e91bde720 ("x86emul: support AVX512PF insns") Signed-off-by: Jan Beulich Acked-by: Andrew Cooper commit 6156cfeaf28c9cd0ffb84c25216c43aa64d93de4 Author: Jan Beulich Date: Wed Aug 5 10:28:40 2020 +0200 x86emul: AVX512F scatter insns are memory writes While the custom handling renders the "to_mem" field generally unused, x86_insn_is_mem_write() still (indirectly) consumes that information, and hence the table entries want to be correct. Fixes: 7d569b848036 ("x86emul: support AVX512F scatter insns") Signed-off-by: Jan Beulich Acked-by: Andrew Cooper commit 067e7b76fd38a2f6ba3898c15a09878498a73226 Author: Jan Beulich Date: Wed Aug 5 10:28:01 2020 +0200 x86emul: AVX512{F,BW} down conversion moves are memory writes For this to be properly reported, the case labels need to move to a different switch() block. Fixes: 30e0bdf79828 ("x86emul: support AVX512{F,BW} down conversion moves") Signed-off-by: Jan Beulich Acked-by: Andrew Cooper commit 3cb82fe3ff4262ddd4fa594c425cbd8f3f14dc76 Author: Jan Beulich Date: Wed Aug 5 10:27:31 2020 +0200 x86emul: extend decoding / mem access testing to XOP-encoded insns Signed-off-by: Jan Beulich Acked-by: Andrew Cooper commit 5e6dc9b8e51679ead71ab3834c8d24bcb95a4fdf Author: Jan Beulich Date: Wed Aug 5 10:27:23 2020 +0200 x86emul: extend decoding / mem access testing to VEX-encoded insns Signed-off-by: Jan Beulich Acked-by: Andrew Cooper commit d9dad3584b63f7a4d1a33ee3a4b637b4b0d36856 Author: Jan Beulich Date: Wed Aug 5 10:27:11 2020 +0200 x86emul: extend decoding / mem access testing to MMX / SSE insns IOW just legacy encoded ones. For 3dNow! just one example is used, as they're all similar in nature both encoding- and operand-wise. Rename pfx_none to pfx_no, so it can be used to improve readability / column alignment. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper commit 37b7b1571bedbbe93392a1f51da501d88985071c Author: Jan Beulich Date: Wed Aug 5 10:26:59 2020 +0200 x86emul: extend decoding / mem access testing to FPU insns Signed-off-by: Jan Beulich Acked-by: Andrew Cooper commit df8fb11d8880cb0f4f1bbcff1700d0a80e0f6983 Author: Jan Beulich Date: Wed Aug 5 10:26:11 2020 +0200 x86emul: adjustments to mem access / write logic testing The combination of specifying a ModR/M byte with the upper two bits set and the modrm field set to T is pointless - the same test will be executed twice, i.e. overall things will be slower for no extra gain. I can only assume this was a copy-and-paste-without-enough-editing mistake of mine. Furthermore adjust the base type of a few bit fields to shrink table size, as subsequently quite a few new entries will get added to the tables using this type. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper commit 2e98d0b1d09e99e3d1287cb13f42b604ebc3c29a Author: Jan Beulich Date: Wed Aug 5 10:21:22 2020 +0200 x86: comment update after "drop high compat r/o M2P table address range" Commit 5af040ef8b57 clearly should also have updated the comment, not just the #define-s. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper commit 48660560d1b64763551be5746f980eec700ba46c Author: Jan Beulich Date: Wed Aug 5 10:20:59 2020 +0200 x86emul: further FPU env testing relaxation for AMD-like CPUs See the code comment that's being extended. Additionally a few more zap_fpsel() invocations are needed - whenever we stored state after there potentially having been a context switch behind our backs. Reported-by: Andrew Cooper Signed-off-by: Jan Beulich Acked-by: Andrew Cooper Tested-by: Andrew Cooper commit 21de9680eb594a7038d4d4ed78e53ac90a8c5a6e Author: Jan Beulich Date: Wed Aug 5 10:19:29 2020 +0200 x86emul: replace further UB shifts I have no explanation how I managed to overlook these while putting together what is now b6a907f8c83d ("x86emul: replace UB shifts"). Signed-off-by: Jan Beulich Acked-by: Andrew Cooper commit c9f9a7258dc07735e2da2b6d0b51a0218c76a51f Author: Wei Liu Date: Tue Aug 4 15:53:48 2020 +0000 Revert "libxl: avoid golang building without CONFIG_GOLANG=y" This reverts commit fe49938f21c26f0ce630c69af055f927dd0ed75f. We have an on-going discussion regarding this patch. Signed-off-by: Wei Liu commit fe49938f21c26f0ce630c69af055f927dd0ed75f Author: Jan Beulich Date: Mon Aug 3 10:06:32 2020 +0200 libxl: avoid golang building without CONFIG_GOLANG=y While this doesn't address the real problem I've run into (attempting to update r/o source files), not recursing into tools/golang/xenlight/ is enough to fix the build for me for the moment. I don't currently see why 60db5da62ac0 ("libxl: Generate golang bindings in libxl Makefile") found it necessary to invoke this build step unconditionally. Signed-off-by: Jan Beulich Acked-by: Wei Liu commit 9909532113692020c1b50eb974cac47d4ea10e69 Author: Jan Beulich Date: Mon Aug 3 16:27:22 2020 +0200 x86emul: avoid assembler warning about .type not taking effect in test harness gcc re-orders top level blocks by default when optimizing. This re-ordering results in all our .type directives to get emitted to the assembly file first, followed by gcc's. The assembler warns about attempts to change the type of a symbol when it was already set (and when there's no intervening setting to "notype"). Signed-off-by: Jan Beulich Acked-by: Andrew Cooper (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Fri Aug 07 05:05:12 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 05:05:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3uYo-0005AY-2D; Fri, 07 Aug 2020 05:04:54 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3uYm-0005AT-NJ for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 05:04:52 +0000 X-Inumbo-ID: 13fd974c-96ca-4876-95d4-97010c12b47b Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 13fd974c-96ca-4876-95d4-97010c12b47b; Fri, 07 Aug 2020 05:04:51 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C7F1DAB8B; Fri, 7 Aug 2020 05:05:08 +0000 (UTC) From: Juergen Gross To: torvalds@linux-foundation.org Subject: [GIT PULL] xen: branch for v5.9-rc1 Date: Fri, 7 Aug 2020 07:04:50 +0200 Message-Id: <20200807050450.7517-1-jgross@suse.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, linux-kernel@vger.kernel.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.9-rc1-tag xen: branch for v5.9-rc1 It contains the following: - two trivial comment fixes - A small series for the Xen balloon driver fixing some issues - A series of the Xen privcmd driver targeting elimination of using get_user_pages*() in this driver - A series for the Xen swiotlb driver cleaning it up and adding support for letting the kernel run as dom0 on Rpi4 Thanks. Juergen arch/arm/xen/mm.c | 34 +++++----- arch/x86/include/asm/xen/hypercall.h | 2 +- drivers/xen/balloon.c | 26 +++----- drivers/xen/privcmd.c | 32 +++++----- drivers/xen/swiotlb-xen.c | 119 +++++++++++++++++++++-------------- include/uapi/xen/gntdev.h | 2 +- include/xen/page.h | 1 - include/xen/swiotlb-xen.h | 8 +-- 8 files changed, 119 insertions(+), 105 deletions(-) Boris Ostrovsky (1): swiotlb-xen: use vmalloc_to_page on vmalloc virt addresses Randy Dunlap (2): xen/gntdev: gntdev.h: drop a duplicated word xen: hypercall.h: fix duplicated word Roger Pau Monne (3): xen/balloon: fix accounting in alloc_xenballooned_pages error path xen/balloon: make the balloon wait interruptible Revert "xen/balloon: Fix crash when ballooning on x86 32 bit PAE" Souptick Joarder (3): xen/privcmd: Corrected error handling path xen/privcmd: Mark pages as dirty xen/privcmd: Convert get_user_pages*() to pin_user_pages*() Stefano Stabellini (10): swiotlb-xen: remove start_dma_addr swiotlb-xen: add struct device * parameter to xen_phys_to_bus swiotlb-xen: add struct device * parameter to xen_bus_to_phys swiotlb-xen: add struct device * parameter to xen_dma_sync_for_cpu swiotlb-xen: add struct device * parameter to xen_dma_sync_for_device swiotlb-xen: add struct device * parameter to is_xen_swiotlb_buffer swiotlb-xen: remove XEN_PFN_PHYS swiotlb-xen: introduce phys_to_dma/dma_to_phys translations xen/arm: introduce phys/dma translations in xen_dma_sync_for_* xen/arm: call dma_to_phys on the dma_addr_t parameter of dma_cache_maint From xen-devel-bounces@lists.xenproject.org Fri Aug 07 05:27:19 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 05:27:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3uuL-0006yb-PD; Fri, 07 Aug 2020 05:27:09 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3uuK-0006yE-EA for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 05:27:08 +0000 X-Inumbo-ID: ac933c47-9918-46b5-ba25-87edbfb7679e Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ac933c47-9918-46b5-ba25-87edbfb7679e; Fri, 07 Aug 2020 05:26:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=s8UaryRVGRqltp57X0scD+bqXbcOSokX9Rx/8d9/xSs=; b=QC4nMpV6nnIBJG7oCzCF9TgFI 2wO8AgXtOlJrgeAN5jNXDRjWdHYt/Xucq3DqLwAE+qCEgQ4HVy2hXeauSpVAElTwEcWCU90u4XLEK u9Ox3YHjeBICf7CbvgnuSLwxdeSKHIZqxf1xLO8oDV5zZwFdcfg9znYCm1XIRw0f3li6Y=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3uuB-0006a4-77; Fri, 07 Aug 2020 05:26:59 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k3uuA-0004HL-SB; Fri, 07 Aug 2020 05:26:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k3uuA-0007GC-Qb; Fri, 07 Aug 2020 05:26:58 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 152501: tolerable FAIL - PUSHED X-Osstest-Failures: linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking X-Osstest-Versions-This: linux=1b940bbc5c55551a3420f403a2b10cb884cffb01 X-Osstest-Versions-That: linux=169b93899c7dfb93a2b57da8e3505da9b2afcf5c From: osstest service owner Date: Fri, 07 Aug 2020 05:26:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152501 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/152501/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-pvshim 12 guest-start fail never pass test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail never pass test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail never pass test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail never pass test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass version targeted for testing: linux 1b940bbc5c55551a3420f403a2b10cb884cffb01 baseline version: linux 169b93899c7dfb93a2b57da8e3505da9b2afcf5c Last test of basis 152331 2020-07-31 17:11:00 Z 6 days Testing same since 152486 2020-08-05 08:10:20 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Abhishek Ambure Alaa Hleihel Alain Michaud Alex Deucher Andrea Righi Andrew Morton Andrii Nakryiko Armas Spann Arnaldo Carvalho de Melo Atish Patra Aya Levin Balaji Pothunoori Ben Hutchings Bjorn Helgaas Chen-Yu Tsai Christoph Hellwig Daniel Borkmann Daniel Vetter Dave Anglin David Hildenbrand David S. Miller Dominique Martinet Eran Ben Elisha Fabio Estevam Gary R Hook Geert Uytterhoeven Geert Uytterhoeven Greg Kroah-Hartman Gregory CLEMENT Guojia Liao Helge Deller Herbert Xu Honggang Li Huazhong Tan Ido Schimmel Ingo Molnar J. Bruce Fields Jakub Kicinski Jan Kara Jason Gunthorpe Jason Wang Johan Hovold Johannes Berg John Paul Adrian Glaubitz Josh Poimboeuf Kailang Yang Kalle Valo Laurence Oberman Laurence Tratt Liam Beguin Linus Torvalds Lu Wei Luis Machado Marc Zyngier Marcel Holtmann Martin K. Petersen Mauro Carvalho Chehab Maxime Ripard Mazin Rezk Michael Karcher Michael S. Tsirkin Michael Trimarchi Michal Simek Mike Marciniszyn Ming Lei Navid Emamdoost NeilBrown Nick Desaulniers Palmer Dabbelt Paolo Bonzini Paolo Pisati Parav Pandit Paul Cercueil Peilin Ye PeiSen Hou Peter Zijlstra (Intel) Peter Zijlstra Pi-Hsun Shih Quentin Perret Raviteja Narayanam Remi Pommarel Rich Felker Robert Hancock Robin Murphy Ron Diskin Roopa Prabhu Russell King Saeed Mahameed Sagi Grimberg Salvatore Bonaccorso Sam Ravnborg Sami Tolvanen Santosh Shilimkar Sasha Levin Sathishkumar Muruganandam Sean Young Shawn Guo Shuah Khan Song Liu Sonny Sasaka Steffen Klassert Steve Cohen Suniel Mahesh Taehee Yoo Takashi Iwai Tanner Love Thomas Falcon Thomas Gleixner Tobias Brunner Wang Hai Wang ShaoBo Wanpeng Li Wei Li Will Deacon Willem de Bruijn Wolfram Sang Xie He Xin Long Xin Tan Xin Xiong Xiyu Yang Yonglong Liu Yoshihiro Shimoda YueHaibing jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 169b93899c7d..1b940bbc5c55 1b940bbc5c55551a3420f403a2b10cb884cffb01 -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Fri Aug 07 08:29:37 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 08:29:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xkV-0005uO-Fb; Fri, 07 Aug 2020 08:29:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xkT-0005uJ-W9 for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 08:29:10 +0000 X-Inumbo-ID: 75d6fa44-6226-4554-89e2-2c4716fd734a Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 75d6fa44-6226-4554-89e2-2c4716fd734a; Fri, 07 Aug 2020 08:29:09 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1AA53AAC7; Fri, 7 Aug 2020 08:29:26 +0000 (UTC) Subject: Re: EFI executable corruption when live patching is turned off To: Trammell Hudson References: <3TMd7J2u5gCA8ouIG_Xfcw7s5JKMG06XsDIesEB3Fi9htUJ43Lfl057wXohlpCHcszqoCmicpIlneEDO26ZqT8QfC2Y39VxBuqD3nS1j5Q4=@trmm.net> From: Jan Beulich Message-ID: <8429c8d0-053a-ea57-bf6b-3d515f2cfb6a@suse.com> Date: Fri, 7 Aug 2020 10:29:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Xen-devel Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 06.08.2020 20:10, Trammell Hudson wrote: > On Thursday, August 6, 2020 6:40 PM, Jan Beulich wrote: > >> On 05.08.2020 20:19, Trammell Hudson wrote: >> [...] >>> ~/build/xen-clean/xen$ objcopy xen.efi test.efi >>> objcopy: test.efi: Data Directory size (1c) exceeds space left in section (18) >>> objcopy: test.efi: error copying private BFD data: file in wrong format >>> ~/build/xen-clean/xen$ objcopy --version | head -1 >>> GNU objcopy (GNU Binutils for Ubuntu) 2.34 >> >> I've tried to find a sensible way to fix this in objcopy, but could >> come up with only a somewhat hackish variant: >> https://sourceware.org/pipermail/binutils/2020-August/112746.html >> Let's see what the maintainers there think, or if they have better >> suggestions (or are willing to address this themselves). The issue >> is pretty certainly not tied to LIVEPATCH, but rather to how much >> padding space there is at the end of the .rodata section. > > Thanks for tracking that down! I was also almost certain it was not a livepatch issue, although that was the easiest minimal test case that I could produce. > > As a workaround for the Xen project, what do you think of forcing alignment on .buildid so that the tool is happy: > > diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S > index 111edb5..712ffc8 100644 > --- a/xen/arch/x86/xen.lds.S > +++ b/xen/arch/x86/xen.lds.S > @@ -161,6 +161,7 @@ SECTIONS > __note_gnu_build_id_end = .; > } :note :text > #elif defined(BUILD_ID_EFI) > + . = ALIGN(4096); > DECL_SECTION(.buildid) { > __note_gnu_build_id_start = .; > *(.buildid) Only as a last resort, when it gets in the way of something that's in the upstream tree. I.e. suitably described and commented you could make this part of your future submission. I don't think a full 4096 bytes of alignment are actually needed, though - afaict 32 bytes ought to suffice. Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 07 08:37:45 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 08:37:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xsj-0006p6-Cj; Fri, 07 Aug 2020 08:37:41 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xsi-0006p1-De for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 08:37:40 +0000 X-Inumbo-ID: 5e73d92b-809b-4c3c-ae8e-c00fb9aa0e80 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5e73d92b-809b-4c3c-ae8e-c00fb9aa0e80; Fri, 07 Aug 2020 08:37:39 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AD1C0AAC7; Fri, 7 Aug 2020 08:37:56 +0000 (UTC) Subject: Re: [RFC] efi/boot: Unified Xen executable for UEFI Secure Boot support To: Trammell Hudson References: <1bd2d79e-5bef-835c-f6cc-9fd367e8beb7@suse.com> <5e3b16b3-0f93-4683-dcc7-852c805870c8@suse.com> From: Jan Beulich Message-ID: <4bbb7619-275a-1fe7-3e1c-53603a1a3231@suse.com> Date: Fri, 7 Aug 2020 10:37:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 06.08.2020 16:15, Trammell Hudson wrote: > Updated patch: Before I get to look at this new version, one more general remark (just to not forget making it later): There's a scalability issue here: Right now xen.efi requires to be loaded below the 4Gb boundary. I've seen systems with as little as just 1Gb of memory below that boundary, yet lots above. On such a system one ought to be allowed to expect a huge initrd to work. If, however, the unified Xen binary doesn't fit in what's not already used by UEFI itself in the space below 4Gb, then you'll be in trouble. Probably not something needing addressing right away, but once you get to the point of submitting a non-RFC series, you will want to mention this as a restriction. Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 07 08:38:34 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 08:38:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xta-0006sZ-Me; Fri, 07 Aug 2020 08:38:34 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xtZ-0006sR-DY for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 08:38:33 +0000 X-Inumbo-ID: 076e7353-05c9-4c5a-854f-579ddf3fa160 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 076e7353-05c9-4c5a-854f-579ddf3fa160; Fri, 07 Aug 2020 08:38:32 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A0329B641; Fri, 7 Aug 2020 08:38:49 +0000 (UTC) From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 3/7] x86/xen: drop tests for highmem in pv code Date: Fri, 7 Aug 2020 10:38:22 +0200 Message-Id: <20200807083826.16794-4-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200807083826.16794-1-jgross@suse.com> References: <20200807083826.16794-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Stefano Stabellini , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Boris Ostrovsky , Thomas Gleixner Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" With support for 32-bit pv guests gone pure pv-code no longer needs to test for highmem. Dropping those tests removes the need for flushing in some places. Signed-off-by: Juergen Gross --- arch/x86/xen/enlighten_pv.c | 11 ++- arch/x86/xen/mmu_pv.c | 138 ++++++++++++++---------------------- 2 files changed, 57 insertions(+), 92 deletions(-) diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c index 7d90b3da8bb4..9fec952f84f3 100644 --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -347,6 +347,7 @@ static void set_aliased_prot(void *v, pgprot_t prot) unsigned long pfn; struct page *page; unsigned char dummy; + void *av; ptep = lookup_address((unsigned long)v, &level); BUG_ON(ptep == NULL); @@ -383,14 +384,10 @@ static void set_aliased_prot(void *v, pgprot_t prot) if (HYPERVISOR_update_va_mapping((unsigned long)v, pte, 0)) BUG(); - if (!PageHighMem(page)) { - void *av = __va(PFN_PHYS(pfn)); + av = __va(PFN_PHYS(pfn)); - if (av != v) - if (HYPERVISOR_update_va_mapping((unsigned long)av, pte, 0)) - BUG(); - } else - kmap_flush_unused(); + if (av != v && HYPERVISOR_update_va_mapping((unsigned long)av, pte, 0)) + BUG(); preempt_enable(); } diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c index 1f9500d0b839..3774fa6d2ef7 100644 --- a/arch/x86/xen/mmu_pv.c +++ b/arch/x86/xen/mmu_pv.c @@ -537,25 +537,26 @@ __visible p4d_t xen_make_p4d(p4dval_t p4d) PV_CALLEE_SAVE_REGS_THUNK(xen_make_p4d); #endif /* CONFIG_PGTABLE_LEVELS >= 5 */ -static int xen_pmd_walk(struct mm_struct *mm, pmd_t *pmd, - int (*func)(struct mm_struct *mm, struct page *, enum pt_level), - bool last, unsigned long limit) +static void xen_pmd_walk(struct mm_struct *mm, pmd_t *pmd, + void (*func)(struct mm_struct *mm, struct page *, + enum pt_level), + bool last, unsigned long limit) { - int i, nr, flush = 0; + int i, nr; nr = last ? pmd_index(limit) + 1 : PTRS_PER_PMD; for (i = 0; i < nr; i++) { if (!pmd_none(pmd[i])) - flush |= (*func)(mm, pmd_page(pmd[i]), PT_PTE); + (*func)(mm, pmd_page(pmd[i]), PT_PTE); } - return flush; } -static int xen_pud_walk(struct mm_struct *mm, pud_t *pud, - int (*func)(struct mm_struct *mm, struct page *, enum pt_level), - bool last, unsigned long limit) +static void xen_pud_walk(struct mm_struct *mm, pud_t *pud, + void (*func)(struct mm_struct *mm, struct page *, + enum pt_level), + bool last, unsigned long limit) { - int i, nr, flush = 0; + int i, nr; nr = last ? pud_index(limit) + 1 : PTRS_PER_PUD; for (i = 0; i < nr; i++) { @@ -566,29 +567,26 @@ static int xen_pud_walk(struct mm_struct *mm, pud_t *pud, pmd = pmd_offset(&pud[i], 0); if (PTRS_PER_PMD > 1) - flush |= (*func)(mm, virt_to_page(pmd), PT_PMD); - flush |= xen_pmd_walk(mm, pmd, func, - last && i == nr - 1, limit); + (*func)(mm, virt_to_page(pmd), PT_PMD); + xen_pmd_walk(mm, pmd, func, last && i == nr - 1, limit); } - return flush; } -static int xen_p4d_walk(struct mm_struct *mm, p4d_t *p4d, - int (*func)(struct mm_struct *mm, struct page *, enum pt_level), - bool last, unsigned long limit) +static void xen_p4d_walk(struct mm_struct *mm, p4d_t *p4d, + void (*func)(struct mm_struct *mm, struct page *, + enum pt_level), + bool last, unsigned long limit) { - int flush = 0; pud_t *pud; if (p4d_none(*p4d)) - return flush; + return; pud = pud_offset(p4d, 0); if (PTRS_PER_PUD > 1) - flush |= (*func)(mm, virt_to_page(pud), PT_PUD); - flush |= xen_pud_walk(mm, pud, func, last, limit); - return flush; + (*func)(mm, virt_to_page(pud), PT_PUD); + xen_pud_walk(mm, pud, func, last, limit); } /* @@ -603,12 +601,12 @@ static int xen_p4d_walk(struct mm_struct *mm, p4d_t *p4d, * We must skip the Xen hole in the middle of the address space, just after * the big x86-64 virtual hole. */ -static int __xen_pgd_walk(struct mm_struct *mm, pgd_t *pgd, - int (*func)(struct mm_struct *mm, struct page *, - enum pt_level), - unsigned long limit) +static void __xen_pgd_walk(struct mm_struct *mm, pgd_t *pgd, + void (*func)(struct mm_struct *mm, struct page *, + enum pt_level), + unsigned long limit) { - int i, nr, flush = 0; + int i, nr; unsigned hole_low = 0, hole_high = 0; /* The limit is the last byte to be touched */ @@ -633,22 +631,20 @@ static int __xen_pgd_walk(struct mm_struct *mm, pgd_t *pgd, continue; p4d = p4d_offset(&pgd[i], 0); - flush |= xen_p4d_walk(mm, p4d, func, i == nr - 1, limit); + xen_p4d_walk(mm, p4d, func, i == nr - 1, limit); } /* Do the top level last, so that the callbacks can use it as a cue to do final things like tlb flushes. */ - flush |= (*func)(mm, virt_to_page(pgd), PT_PGD); - - return flush; + (*func)(mm, virt_to_page(pgd), PT_PGD); } -static int xen_pgd_walk(struct mm_struct *mm, - int (*func)(struct mm_struct *mm, struct page *, - enum pt_level), - unsigned long limit) +static void xen_pgd_walk(struct mm_struct *mm, + void (*func)(struct mm_struct *mm, struct page *, + enum pt_level), + unsigned long limit) { - return __xen_pgd_walk(mm, mm->pgd, func, limit); + __xen_pgd_walk(mm, mm->pgd, func, limit); } /* If we're using split pte locks, then take the page's lock and @@ -681,26 +677,17 @@ static void xen_do_pin(unsigned level, unsigned long pfn) xen_extend_mmuext_op(&op); } -static int xen_pin_page(struct mm_struct *mm, struct page *page, - enum pt_level level) +static void xen_pin_page(struct mm_struct *mm, struct page *page, + enum pt_level level) { unsigned pgfl = TestSetPagePinned(page); - int flush; - - if (pgfl) - flush = 0; /* already pinned */ - else if (PageHighMem(page)) - /* kmaps need flushing if we found an unpinned - highpage */ - flush = 1; - else { + + if (!pgfl) { void *pt = lowmem_page_address(page); unsigned long pfn = page_to_pfn(page); struct multicall_space mcs = __xen_mc_entry(0); spinlock_t *ptl; - flush = 0; - /* * We need to hold the pagetable lock between the time * we make the pagetable RO and when we actually pin @@ -737,8 +724,6 @@ static int xen_pin_page(struct mm_struct *mm, struct page *page, xen_mc_callback(xen_pte_unlock, ptl); } } - - return flush; } /* This is called just after a mm has been created, but it has not @@ -752,14 +737,7 @@ static void __xen_pgd_pin(struct mm_struct *mm, pgd_t *pgd) xen_mc_batch(); - if (__xen_pgd_walk(mm, pgd, xen_pin_page, USER_LIMIT)) { - /* re-enable interrupts for flushing */ - xen_mc_issue(0); - - kmap_flush_unused(); - - xen_mc_batch(); - } + __xen_pgd_walk(mm, pgd, xen_pin_page, USER_LIMIT); xen_do_pin(MMUEXT_PIN_L4_TABLE, PFN_DOWN(__pa(pgd))); @@ -803,11 +781,10 @@ void xen_mm_pin_all(void) spin_unlock(&pgd_lock); } -static int __init xen_mark_pinned(struct mm_struct *mm, struct page *page, - enum pt_level level) +static void __init xen_mark_pinned(struct mm_struct *mm, struct page *page, + enum pt_level level) { SetPagePinned(page); - return 0; } /* @@ -823,12 +800,12 @@ static void __init xen_after_bootmem(void) xen_pgd_walk(&init_mm, xen_mark_pinned, FIXADDR_TOP); } -static int xen_unpin_page(struct mm_struct *mm, struct page *page, - enum pt_level level) +static void xen_unpin_page(struct mm_struct *mm, struct page *page, + enum pt_level level) { unsigned pgfl = TestClearPagePinned(page); - if (pgfl && !PageHighMem(page)) { + if (pgfl) { void *pt = lowmem_page_address(page); unsigned long pfn = page_to_pfn(page); spinlock_t *ptl = NULL; @@ -859,8 +836,6 @@ static int xen_unpin_page(struct mm_struct *mm, struct page *page, xen_mc_callback(xen_pte_unlock, ptl); } } - - return 0; /* never need to flush on unpin */ } /* Release a pagetables pages back as normal RW */ @@ -1554,20 +1529,14 @@ static inline void xen_alloc_ptpage(struct mm_struct *mm, unsigned long pfn, if (static_branch_likely(&xen_struct_pages_ready)) SetPagePinned(page); - if (!PageHighMem(page)) { - xen_mc_batch(); + xen_mc_batch(); - __set_pfn_prot(pfn, PAGE_KERNEL_RO); + __set_pfn_prot(pfn, PAGE_KERNEL_RO); - if (level == PT_PTE && USE_SPLIT_PTE_PTLOCKS) - __pin_pagetable_pfn(MMUEXT_PIN_L1_TABLE, pfn); + if (level == PT_PTE && USE_SPLIT_PTE_PTLOCKS) + __pin_pagetable_pfn(MMUEXT_PIN_L1_TABLE, pfn); - xen_mc_issue(PARAVIRT_LAZY_MMU); - } else { - /* make sure there are no stray mappings of - this page */ - kmap_flush_unused(); - } + xen_mc_issue(PARAVIRT_LAZY_MMU); } } @@ -1590,16 +1559,15 @@ static inline void xen_release_ptpage(unsigned long pfn, unsigned level) trace_xen_mmu_release_ptpage(pfn, level, pinned); if (pinned) { - if (!PageHighMem(page)) { - xen_mc_batch(); + xen_mc_batch(); - if (level == PT_PTE && USE_SPLIT_PTE_PTLOCKS) - __pin_pagetable_pfn(MMUEXT_UNPIN_TABLE, pfn); + if (level == PT_PTE && USE_SPLIT_PTE_PTLOCKS) + __pin_pagetable_pfn(MMUEXT_UNPIN_TABLE, pfn); - __set_pfn_prot(pfn, PAGE_KERNEL); + __set_pfn_prot(pfn, PAGE_KERNEL); + + xen_mc_issue(PARAVIRT_LAZY_MMU); - xen_mc_issue(PARAVIRT_LAZY_MMU); - } ClearPagePinned(page); } } -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Fri Aug 07 08:38:35 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 08:38:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xtb-0006ss-1h; Fri, 07 Aug 2020 08:38:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xta-0006sY-L2 for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 08:38:34 +0000 X-Inumbo-ID: 3847c3f2-9fdf-4493-85fc-38d497f0eb66 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3847c3f2-9fdf-4493-85fc-38d497f0eb66; Fri, 07 Aug 2020 08:38:33 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0815AB642; Fri, 7 Aug 2020 08:38:50 +0000 (UTC) From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: [PATCH v3 4/7] x86/paravirt: remove 32-bit support from PARAVIRT_XXL Date: Fri, 7 Aug 2020 10:38:23 +0200 Message-Id: <20200807083826.16794-5-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200807083826.16794-1-jgross@suse.com> References: <20200807083826.16794-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Stefano Stabellini , Deep Shah , "VMware, Inc." , Ingo Molnar , Borislav Petkov , Andy Lutomirski , "H. Peter Anvin" , Thomas Gleixner , Boris Ostrovsky Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" The last 32-bit user of stuff under CONFIG_PARAVIRT_XXL is gone. Remove 32-bit specific parts. Signed-off-by: Juergen Gross --- arch/x86/entry/vdso/vdso32/vclock_gettime.c | 1 + arch/x86/include/asm/paravirt.h | 92 +++------------------ arch/x86/include/asm/paravirt_types.h | 21 ----- arch/x86/include/asm/pgtable-3level_types.h | 5 -- arch/x86/include/asm/segment.h | 4 - arch/x86/kernel/cpu/common.c | 8 -- arch/x86/kernel/kprobes/core.c | 1 - arch/x86/kernel/kprobes/opt.c | 1 - arch/x86/kernel/paravirt.c | 18 ---- arch/x86/kernel/paravirt_patch.c | 17 ---- arch/x86/xen/enlighten_pv.c | 6 -- 11 files changed, 13 insertions(+), 161 deletions(-) diff --git a/arch/x86/entry/vdso/vdso32/vclock_gettime.c b/arch/x86/entry/vdso/vdso32/vclock_gettime.c index 84a4a73f77f7..283ed9d00426 100644 --- a/arch/x86/entry/vdso/vdso32/vclock_gettime.c +++ b/arch/x86/entry/vdso/vdso32/vclock_gettime.c @@ -14,6 +14,7 @@ #undef CONFIG_ILLEGAL_POINTER_VALUE #undef CONFIG_SPARSEMEM_VMEMMAP #undef CONFIG_NR_CPUS +#undef CONFIG_PARAVIRT_XXL #define CONFIG_X86_32 1 #define CONFIG_PGTABLE_LEVELS 2 diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h index 3d2afecde50c..dedc89a07826 100644 --- a/arch/x86/include/asm/paravirt.h +++ b/arch/x86/include/asm/paravirt.h @@ -160,8 +160,6 @@ static inline void wbinvd(void) PVOP_VCALL0(cpu.wbinvd); } -#define get_kernel_rpl() (pv_info.kernel_rpl) - static inline u64 paravirt_read_msr(unsigned msr) { return PVOP_CALL1(u64, cpu.read_msr, msr); @@ -277,12 +275,10 @@ static inline void load_TLS(struct thread_struct *t, unsigned cpu) PVOP_VCALL2(cpu.load_tls, t, cpu); } -#ifdef CONFIG_X86_64 static inline void load_gs_index(unsigned int gs) { PVOP_VCALL1(cpu.load_gs_index, gs); } -#endif static inline void write_ldt_entry(struct desc_struct *dt, int entry, const void *desc) @@ -377,10 +373,7 @@ static inline pte_t __pte(pteval_t val) { pteval_t ret; - if (sizeof(pteval_t) > sizeof(long)) - ret = PVOP_CALLEE2(pteval_t, mmu.make_pte, val, (u64)val >> 32); - else - ret = PVOP_CALLEE1(pteval_t, mmu.make_pte, val); + ret = PVOP_CALLEE1(pteval_t, mmu.make_pte, val); return (pte_t) { .pte = ret }; } @@ -389,11 +382,7 @@ static inline pteval_t pte_val(pte_t pte) { pteval_t ret; - if (sizeof(pteval_t) > sizeof(long)) - ret = PVOP_CALLEE2(pteval_t, mmu.pte_val, - pte.pte, (u64)pte.pte >> 32); - else - ret = PVOP_CALLEE1(pteval_t, mmu.pte_val, pte.pte); + ret = PVOP_CALLEE1(pteval_t, mmu.pte_val, pte.pte); return ret; } @@ -402,10 +391,7 @@ static inline pgd_t __pgd(pgdval_t val) { pgdval_t ret; - if (sizeof(pgdval_t) > sizeof(long)) - ret = PVOP_CALLEE2(pgdval_t, mmu.make_pgd, val, (u64)val >> 32); - else - ret = PVOP_CALLEE1(pgdval_t, mmu.make_pgd, val); + ret = PVOP_CALLEE1(pgdval_t, mmu.make_pgd, val); return (pgd_t) { ret }; } @@ -414,11 +400,7 @@ static inline pgdval_t pgd_val(pgd_t pgd) { pgdval_t ret; - if (sizeof(pgdval_t) > sizeof(long)) - ret = PVOP_CALLEE2(pgdval_t, mmu.pgd_val, - pgd.pgd, (u64)pgd.pgd >> 32); - else - ret = PVOP_CALLEE1(pgdval_t, mmu.pgd_val, pgd.pgd); + ret = PVOP_CALLEE1(pgdval_t, mmu.pgd_val, pgd.pgd); return ret; } @@ -438,51 +420,32 @@ static inline void ptep_modify_prot_commit(struct vm_area_struct *vma, unsigned pte_t *ptep, pte_t old_pte, pte_t pte) { - if (sizeof(pteval_t) > sizeof(long)) - /* 5 arg words */ - pv_ops.mmu.ptep_modify_prot_commit(vma, addr, ptep, pte); - else - PVOP_VCALL4(mmu.ptep_modify_prot_commit, - vma, addr, ptep, pte.pte); + PVOP_VCALL4(mmu.ptep_modify_prot_commit, vma, addr, ptep, pte.pte); } static inline void set_pte(pte_t *ptep, pte_t pte) { - if (sizeof(pteval_t) > sizeof(long)) - PVOP_VCALL3(mmu.set_pte, ptep, pte.pte, (u64)pte.pte >> 32); - else - PVOP_VCALL2(mmu.set_pte, ptep, pte.pte); + PVOP_VCALL2(mmu.set_pte, ptep, pte.pte); } static inline void set_pte_at(struct mm_struct *mm, unsigned long addr, pte_t *ptep, pte_t pte) { - if (sizeof(pteval_t) > sizeof(long)) - /* 5 arg words */ - pv_ops.mmu.set_pte_at(mm, addr, ptep, pte); - else - PVOP_VCALL4(mmu.set_pte_at, mm, addr, ptep, pte.pte); + PVOP_VCALL4(mmu.set_pte_at, mm, addr, ptep, pte.pte); } static inline void set_pmd(pmd_t *pmdp, pmd_t pmd) { pmdval_t val = native_pmd_val(pmd); - if (sizeof(pmdval_t) > sizeof(long)) - PVOP_VCALL3(mmu.set_pmd, pmdp, val, (u64)val >> 32); - else - PVOP_VCALL2(mmu.set_pmd, pmdp, val); + PVOP_VCALL2(mmu.set_pmd, pmdp, val); } -#if CONFIG_PGTABLE_LEVELS >= 3 static inline pmd_t __pmd(pmdval_t val) { pmdval_t ret; - if (sizeof(pmdval_t) > sizeof(long)) - ret = PVOP_CALLEE2(pmdval_t, mmu.make_pmd, val, (u64)val >> 32); - else - ret = PVOP_CALLEE1(pmdval_t, mmu.make_pmd, val); + ret = PVOP_CALLEE1(pmdval_t, mmu.make_pmd, val); return (pmd_t) { ret }; } @@ -491,11 +454,7 @@ static inline pmdval_t pmd_val(pmd_t pmd) { pmdval_t ret; - if (sizeof(pmdval_t) > sizeof(long)) - ret = PVOP_CALLEE2(pmdval_t, mmu.pmd_val, - pmd.pmd, (u64)pmd.pmd >> 32); - else - ret = PVOP_CALLEE1(pmdval_t, mmu.pmd_val, pmd.pmd); + ret = PVOP_CALLEE1(pmdval_t, mmu.pmd_val, pmd.pmd); return ret; } @@ -504,12 +463,9 @@ static inline void set_pud(pud_t *pudp, pud_t pud) { pudval_t val = native_pud_val(pud); - if (sizeof(pudval_t) > sizeof(long)) - PVOP_VCALL3(mmu.set_pud, pudp, val, (u64)val >> 32); - else - PVOP_VCALL2(mmu.set_pud, pudp, val); + PVOP_VCALL2(mmu.set_pud, pudp, val); } -#if CONFIG_PGTABLE_LEVELS >= 4 + static inline pud_t __pud(pudval_t val) { pudval_t ret; @@ -574,29 +530,6 @@ static inline void p4d_clear(p4d_t *p4dp) set_p4d(p4dp, __p4d(0)); } -#endif /* CONFIG_PGTABLE_LEVELS == 4 */ - -#endif /* CONFIG_PGTABLE_LEVELS >= 3 */ - -#ifdef CONFIG_X86_PAE -/* Special-case pte-setting operations for PAE, which can't update a - 64-bit pte atomically */ -static inline void set_pte_atomic(pte_t *ptep, pte_t pte) -{ - PVOP_VCALL3(mmu.set_pte_atomic, ptep, pte.pte, pte.pte >> 32); -} - -static inline void pte_clear(struct mm_struct *mm, unsigned long addr, - pte_t *ptep) -{ - PVOP_VCALL3(mmu.pte_clear, mm, addr, ptep); -} - -static inline void pmd_clear(pmd_t *pmdp) -{ - PVOP_VCALL1(mmu.pmd_clear, pmdp); -} -#else /* !CONFIG_X86_PAE */ static inline void set_pte_atomic(pte_t *ptep, pte_t pte) { set_pte(ptep, pte); @@ -612,7 +545,6 @@ static inline void pmd_clear(pmd_t *pmdp) { set_pmd(pmdp, __pmd(0)); } -#endif /* CONFIG_X86_PAE */ #define __HAVE_ARCH_START_CONTEXT_SWITCH static inline void arch_start_context_switch(struct task_struct *prev) diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h index 8dfcb2508e6d..f27c3febaa6e 100644 --- a/arch/x86/include/asm/paravirt_types.h +++ b/arch/x86/include/asm/paravirt_types.h @@ -68,12 +68,7 @@ struct paravirt_callee_save { /* general info */ struct pv_info { #ifdef CONFIG_PARAVIRT_XXL - unsigned int kernel_rpl; - int shared_kernel_pmd; - -#ifdef CONFIG_X86_64 u16 extra_user_64bit_cs; /* __USER_CS if none */ -#endif #endif const char *name; @@ -126,9 +121,7 @@ struct pv_cpu_ops { void (*set_ldt)(const void *desc, unsigned entries); unsigned long (*store_tr)(void); void (*load_tls)(struct thread_struct *t, unsigned int cpu); -#ifdef CONFIG_X86_64 void (*load_gs_index)(unsigned int idx); -#endif void (*write_ldt_entry)(struct desc_struct *ldt, int entrynum, const void *desc); void (*write_gdt_entry)(struct desc_struct *, @@ -264,21 +257,11 @@ struct pv_mmu_ops { struct paravirt_callee_save pgd_val; struct paravirt_callee_save make_pgd; -#if CONFIG_PGTABLE_LEVELS >= 3 -#ifdef CONFIG_X86_PAE - void (*set_pte_atomic)(pte_t *ptep, pte_t pteval); - void (*pte_clear)(struct mm_struct *mm, unsigned long addr, - pte_t *ptep); - void (*pmd_clear)(pmd_t *pmdp); - -#endif /* CONFIG_X86_PAE */ - void (*set_pud)(pud_t *pudp, pud_t pudval); struct paravirt_callee_save pmd_val; struct paravirt_callee_save make_pmd; -#if CONFIG_PGTABLE_LEVELS >= 4 struct paravirt_callee_save pud_val; struct paravirt_callee_save make_pud; @@ -291,10 +274,6 @@ struct pv_mmu_ops { void (*set_pgd)(pgd_t *pgdp, pgd_t pgdval); #endif /* CONFIG_PGTABLE_LEVELS >= 5 */ -#endif /* CONFIG_PGTABLE_LEVELS >= 4 */ - -#endif /* CONFIG_PGTABLE_LEVELS >= 3 */ - struct pv_lazy_ops lazy_mode; /* dom0 ops */ diff --git a/arch/x86/include/asm/pgtable-3level_types.h b/arch/x86/include/asm/pgtable-3level_types.h index 80fbb4a9ed87..56baf43befb4 100644 --- a/arch/x86/include/asm/pgtable-3level_types.h +++ b/arch/x86/include/asm/pgtable-3level_types.h @@ -20,12 +20,7 @@ typedef union { } pte_t; #endif /* !__ASSEMBLY__ */ -#ifdef CONFIG_PARAVIRT_XXL -#define SHARED_KERNEL_PMD ((!static_cpu_has(X86_FEATURE_PTI) && \ - (pv_info.shared_kernel_pmd))) -#else #define SHARED_KERNEL_PMD (!static_cpu_has(X86_FEATURE_PTI)) -#endif #define ARCH_PAGE_TABLE_SYNC_MASK (SHARED_KERNEL_PMD ? 0 : PGTBL_PMD_MODIFIED) diff --git a/arch/x86/include/asm/segment.h b/arch/x86/include/asm/segment.h index 9646c300f128..517920928989 100644 --- a/arch/x86/include/asm/segment.h +++ b/arch/x86/include/asm/segment.h @@ -222,10 +222,6 @@ #endif -#ifndef CONFIG_PARAVIRT_XXL -# define get_kernel_rpl() 0 -#endif - #define IDT_ENTRIES 256 #define NUM_EXCEPTION_VECTORS 32 diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c index 965474d78cef..ca89cea31e81 100644 --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -1412,15 +1412,7 @@ static void generic_identify(struct cpuinfo_x86 *c) * ESPFIX issue, we can change this. */ #ifdef CONFIG_X86_32 -# ifdef CONFIG_PARAVIRT_XXL - do { - extern void native_iret(void); - if (pv_ops.cpu.iret == native_iret) - set_cpu_bug(c, X86_BUG_ESPFIX); - } while (0); -# else set_cpu_bug(c, X86_BUG_ESPFIX); -# endif #endif } diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86/kernel/kprobes/core.c index fdadc37d72af..2ca10b770cff 100644 --- a/arch/x86/kernel/kprobes/core.c +++ b/arch/x86/kernel/kprobes/core.c @@ -793,7 +793,6 @@ __used __visible void *trampoline_handler(struct pt_regs *regs) /* fixup registers */ regs->cs = __KERNEL_CS; #ifdef CONFIG_X86_32 - regs->cs |= get_kernel_rpl(); regs->gs = 0; #endif /* We use pt_regs->sp for return address holder. */ diff --git a/arch/x86/kernel/kprobes/opt.c b/arch/x86/kernel/kprobes/opt.c index 40f380461e6d..b8dd113a1284 100644 --- a/arch/x86/kernel/kprobes/opt.c +++ b/arch/x86/kernel/kprobes/opt.c @@ -181,7 +181,6 @@ optimized_callback(struct optimized_kprobe *op, struct pt_regs *regs) /* Save skipped registers */ regs->cs = __KERNEL_CS; #ifdef CONFIG_X86_32 - regs->cs |= get_kernel_rpl(); regs->gs = 0; #endif regs->ip = (unsigned long)op->kp.addr + INT3_INSN_SIZE; diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c index de2138ba38e5..e56a144c13b3 100644 --- a/arch/x86/kernel/paravirt.c +++ b/arch/x86/kernel/paravirt.c @@ -263,13 +263,8 @@ enum paravirt_lazy_mode paravirt_get_lazy_mode(void) struct pv_info pv_info = { .name = "bare hardware", #ifdef CONFIG_PARAVIRT_XXL - .kernel_rpl = 0, - .shared_kernel_pmd = 1, /* Only used when CONFIG_X86_PAE is set */ - -#ifdef CONFIG_X86_64 .extra_user_64bit_cs = __USER_CS, #endif -#endif }; /* 64-bit pagetable entries */ @@ -305,9 +300,7 @@ struct paravirt_patch_template pv_ops = { .cpu.load_idt = native_load_idt, .cpu.store_tr = native_store_tr, .cpu.load_tls = native_load_tls, -#ifdef CONFIG_X86_64 .cpu.load_gs_index = native_load_gs_index, -#endif .cpu.write_ldt_entry = native_write_ldt_entry, .cpu.write_gdt_entry = native_write_gdt_entry, .cpu.write_idt_entry = native_write_idt_entry, @@ -317,9 +310,7 @@ struct paravirt_patch_template pv_ops = { .cpu.load_sp0 = native_load_sp0, -#ifdef CONFIG_X86_64 .cpu.usergs_sysret64 = native_usergs_sysret64, -#endif .cpu.iret = native_iret, .cpu.swapgs = native_swapgs, @@ -375,18 +366,11 @@ struct paravirt_patch_template pv_ops = { .mmu.ptep_modify_prot_start = __ptep_modify_prot_start, .mmu.ptep_modify_prot_commit = __ptep_modify_prot_commit, -#if CONFIG_PGTABLE_LEVELS >= 3 -#ifdef CONFIG_X86_PAE - .mmu.set_pte_atomic = native_set_pte_atomic, - .mmu.pte_clear = native_pte_clear, - .mmu.pmd_clear = native_pmd_clear, -#endif .mmu.set_pud = native_set_pud, .mmu.pmd_val = PTE_IDENT, .mmu.make_pmd = PTE_IDENT, -#if CONFIG_PGTABLE_LEVELS >= 4 .mmu.pud_val = PTE_IDENT, .mmu.make_pud = PTE_IDENT, @@ -398,8 +382,6 @@ struct paravirt_patch_template pv_ops = { .mmu.set_pgd = native_set_pgd, #endif /* CONFIG_PGTABLE_LEVELS >= 5 */ -#endif /* CONFIG_PGTABLE_LEVELS >= 4 */ -#endif /* CONFIG_PGTABLE_LEVELS >= 3 */ .mmu.pte_val = PTE_IDENT, .mmu.pgd_val = PTE_IDENT, diff --git a/arch/x86/kernel/paravirt_patch.c b/arch/x86/kernel/paravirt_patch.c index 3eff63c090d2..ace6e334cb39 100644 --- a/arch/x86/kernel/paravirt_patch.c +++ b/arch/x86/kernel/paravirt_patch.c @@ -26,14 +26,10 @@ struct patch_xxl { const unsigned char mmu_read_cr3[3]; const unsigned char mmu_write_cr3[3]; const unsigned char irq_restore_fl[2]; -# ifdef CONFIG_X86_64 const unsigned char cpu_wbinvd[2]; const unsigned char cpu_usergs_sysret64[6]; const unsigned char cpu_swapgs[3]; const unsigned char mov64[3]; -# else - const unsigned char cpu_iret[1]; -# endif }; static const struct patch_xxl patch_data_xxl = { @@ -42,7 +38,6 @@ static const struct patch_xxl patch_data_xxl = { .irq_save_fl = { 0x9c, 0x58 }, // pushf; pop %[re]ax .mmu_read_cr2 = { 0x0f, 0x20, 0xd0 }, // mov %cr2, %[re]ax .mmu_read_cr3 = { 0x0f, 0x20, 0xd8 }, // mov %cr3, %[re]ax -# ifdef CONFIG_X86_64 .mmu_write_cr3 = { 0x0f, 0x22, 0xdf }, // mov %rdi, %cr3 .irq_restore_fl = { 0x57, 0x9d }, // push %rdi; popfq .cpu_wbinvd = { 0x0f, 0x09 }, // wbinvd @@ -50,19 +45,11 @@ static const struct patch_xxl patch_data_xxl = { 0x48, 0x0f, 0x07 }, // swapgs; sysretq .cpu_swapgs = { 0x0f, 0x01, 0xf8 }, // swapgs .mov64 = { 0x48, 0x89, 0xf8 }, // mov %rdi, %rax -# else - .mmu_write_cr3 = { 0x0f, 0x22, 0xd8 }, // mov %eax, %cr3 - .irq_restore_fl = { 0x50, 0x9d }, // push %eax; popf - .cpu_iret = { 0xcf }, // iret -# endif }; unsigned int paravirt_patch_ident_64(void *insn_buff, unsigned int len) { -#ifdef CONFIG_X86_64 return PATCH(xxl, mov64, insn_buff, len); -#endif - return 0; } # endif /* CONFIG_PARAVIRT_XXL */ @@ -98,13 +85,9 @@ unsigned int native_patch(u8 type, void *insn_buff, unsigned long addr, PATCH_CASE(mmu, read_cr3, xxl, insn_buff, len); PATCH_CASE(mmu, write_cr3, xxl, insn_buff, len); -# ifdef CONFIG_X86_64 PATCH_CASE(cpu, usergs_sysret64, xxl, insn_buff, len); PATCH_CASE(cpu, swapgs, xxl, insn_buff, len); PATCH_CASE(cpu, wbinvd, xxl, insn_buff, len); -# else - PATCH_CASE(cpu, iret, xxl, insn_buff, len); -# endif #endif #ifdef CONFIG_PARAVIRT_SPINLOCKS diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c index 9fec952f84f3..b84d3d47082b 100644 --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -1017,8 +1017,6 @@ void __init xen_setup_vcpu_info_placement(void) } static const struct pv_info xen_info __initconst = { - .shared_kernel_pmd = 0, - .extra_user_64bit_cs = FLAT_USER_CS64, .name = "Xen", }; @@ -1317,10 +1315,6 @@ asmlinkage __visible void __init xen_start_kernel(void) xen_start_info->nr_pages); xen_reserve_special_pages(); - /* keep using Xen gdt for now; no urgent need to change it */ - - pv_info.kernel_rpl = 0; - /* set the limit of our address space */ xen_reserve_top(); -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Fri Aug 07 08:38:39 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 08:38:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xtf-0006ut-Es; Fri, 07 Aug 2020 08:38:39 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xte-0006sR-AQ for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 08:38:38 +0000 X-Inumbo-ID: 8773b939-5612-4d5a-ae68-5c69eae17efd Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8773b939-5612-4d5a-ae68-5c69eae17efd; Fri, 07 Aug 2020 08:38:31 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 058FFAAC7; Fri, 7 Aug 2020 08:38:49 +0000 (UTC) From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: [PATCH v3 0/7] Remove 32-bit Xen PV guest support Date: Fri, 7 Aug 2020 10:38:19 +0200 Message-Id: <20200807083826.16794-1-jgross@suse.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Stefano Stabellini , Deep Shah , "VMware, Inc." , Ingo Molnar , Borislav Petkov , Andy Lutomirski , "H. Peter Anvin" , Thomas Gleixner , Boris Ostrovsky Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" The long term plan has been to replace Xen PV guests by PVH. The first victim of that plan are now 32-bit PV guests, as those are used only rather seldom these days. Xen on x86 requires 64-bit support and with Grub2 now supporting PVH officially since version 2.04 there is no need to keep 32-bit PV guest support alive in the Linux kernel. Additionally Meltdown mitigation is not available in the kernel running as 32-bit PV guest, so dropping this mode makes sense from security point of view, too. Changes in V3: - addressed comments to V2 - split patch 1 into 2 patches - new patches 3 and 7 Changes in V2: - rebase to 5.8 kernel - addressed comments to V1 - new patches 3 and 4 Juergen Gross (7): x86/xen: remove 32-bit Xen PV guest support x86/xen: eliminate xen-asm_64.S x86/xen: drop tests for highmem in pv code x86/paravirt: remove 32-bit support from PARAVIRT_XXL x86/paravirt: cleanup paravirt macros x86/paravirt: use CONFIG_PARAVIRT_XXL instead of CONFIG_PARAVIRT x86/entry/32: revert "Fix XEN_PV build dependency" arch/x86/entry/entry_32.S | 109 +---- arch/x86/entry/entry_64.S | 4 +- arch/x86/entry/vdso/vdso32/note.S | 30 -- arch/x86/entry/vdso/vdso32/vclock_gettime.c | 1 + arch/x86/include/asm/fixmap.h | 2 +- arch/x86/include/asm/idtentry.h | 4 +- arch/x86/include/asm/paravirt.h | 107 +---- arch/x86/include/asm/paravirt_types.h | 21 - arch/x86/include/asm/pgtable-3level_types.h | 5 - arch/x86/include/asm/proto.h | 2 +- arch/x86/include/asm/required-features.h | 2 +- arch/x86/include/asm/segment.h | 6 +- arch/x86/kernel/cpu/common.c | 8 - arch/x86/kernel/head_32.S | 31 -- arch/x86/kernel/kprobes/core.c | 1 - arch/x86/kernel/kprobes/opt.c | 1 - arch/x86/kernel/paravirt.c | 18 - arch/x86/kernel/paravirt_patch.c | 17 - arch/x86/xen/Kconfig | 3 +- arch/x86/xen/Makefile | 3 +- arch/x86/xen/apic.c | 17 - arch/x86/xen/enlighten_pv.c | 78 +--- arch/x86/xen/mmu_pv.c | 488 ++++---------------- arch/x86/xen/p2m.c | 6 +- arch/x86/xen/setup.c | 36 +- arch/x86/xen/smp_pv.c | 18 - arch/x86/xen/vdso.h | 6 - arch/x86/xen/xen-asm.S | 193 +++++++- arch/x86/xen/xen-asm_32.S | 185 -------- arch/x86/xen/xen-asm_64.S | 192 -------- arch/x86/xen/xen-head.S | 6 - drivers/xen/Kconfig | 4 +- 32 files changed, 305 insertions(+), 1299 deletions(-) delete mode 100644 arch/x86/xen/vdso.h delete mode 100644 arch/x86/xen/xen-asm_32.S delete mode 100644 arch/x86/xen/xen-asm_64.S -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Fri Aug 07 08:38:40 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 08:38:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xtg-0006vm-PC; Fri, 07 Aug 2020 08:38:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xtf-0006sY-Jr for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 08:38:39 +0000 X-Inumbo-ID: 49129e61-96ff-441b-8e45-79e168c68078 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 49129e61-96ff-441b-8e45-79e168c68078; Fri, 07 Aug 2020 08:38:32 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1CD96B628; Fri, 7 Aug 2020 08:38:49 +0000 (UTC) From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 1/7] x86/xen: remove 32-bit Xen PV guest support Date: Fri, 7 Aug 2020 10:38:20 +0200 Message-Id: <20200807083826.16794-2-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200807083826.16794-1-jgross@suse.com> References: <20200807083826.16794-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Stefano Stabellini , Ingo Molnar , Borislav Petkov , Andy Lutomirski , "H. Peter Anvin" , Thomas Gleixner , Boris Ostrovsky Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Xen is requiring 64-bit machines today and since Xen 4.14 it can be built without 32-bit PV guest support. There is no need to carry the burden of 32-bit PV guest support in the kernel any longer, as new guests can be either HVM or PVH, or they can use a 64 bit kernel. Remove the 32-bit Xen PV support from the kernel. Signed-off-by: Juergen Gross --- arch/x86/entry/entry_32.S | 109 +-------- arch/x86/entry/vdso/vdso32/note.S | 30 --- arch/x86/include/asm/proto.h | 2 +- arch/x86/include/asm/segment.h | 2 +- arch/x86/kernel/head_32.S | 31 --- arch/x86/xen/Kconfig | 3 +- arch/x86/xen/apic.c | 17 -- arch/x86/xen/enlighten_pv.c | 63 +----- arch/x86/xen/mmu_pv.c | 352 ++++-------------------------- arch/x86/xen/p2m.c | 6 +- arch/x86/xen/setup.c | 36 +-- arch/x86/xen/smp_pv.c | 18 -- arch/x86/xen/vdso.h | 6 - arch/x86/xen/xen-asm.S | 14 -- arch/x86/xen/xen-asm_32.S | 185 ---------------- arch/x86/xen/xen-head.S | 6 - drivers/xen/Kconfig | 4 +- 17 files changed, 51 insertions(+), 833 deletions(-) delete mode 100644 arch/x86/xen/vdso.h delete mode 100644 arch/x86/xen/xen-asm_32.S diff --git a/arch/x86/entry/entry_32.S b/arch/x86/entry/entry_32.S index 29b7d52143e9..df8c017e6161 100644 --- a/arch/x86/entry/entry_32.S +++ b/arch/x86/entry/entry_32.S @@ -449,8 +449,6 @@ .macro SWITCH_TO_KERNEL_STACK - ALTERNATIVE "", "jmp .Lend_\@", X86_FEATURE_XENPV - BUG_IF_WRONG_CR3 SWITCH_TO_KERNEL_CR3 scratch_reg=%eax @@ -599,8 +597,6 @@ */ .macro SWITCH_TO_ENTRY_STACK - ALTERNATIVE "", "jmp .Lend_\@", X86_FEATURE_XENPV - /* Bytes to copy */ movl $PTREGS_SIZE, %ecx @@ -872,17 +868,6 @@ SYM_ENTRY(__begin_SYSENTER_singlestep_region, SYM_L_GLOBAL, SYM_A_NONE) * will ignore all of the single-step traps generated in this range. */ -#ifdef CONFIG_XEN_PV -/* - * Xen doesn't set %esp to be precisely what the normal SYSENTER - * entry point expects, so fix it up before using the normal path. - */ -SYM_CODE_START(xen_sysenter_target) - addl $5*4, %esp /* remove xen-provided frame */ - jmp .Lsysenter_past_esp -SYM_CODE_END(xen_sysenter_target) -#endif - /* * 32-bit SYSENTER entry. * @@ -965,9 +950,8 @@ SYM_FUNC_START(entry_SYSENTER_32) movl %esp, %eax call do_SYSENTER_32 - /* XEN PV guests always use IRET path */ - ALTERNATIVE "testl %eax, %eax; jz .Lsyscall_32_done", \ - "jmp .Lsyscall_32_done", X86_FEATURE_XENPV + testl %eax, %eax + jz .Lsyscall_32_done STACKLEAK_ERASE @@ -1165,95 +1149,6 @@ SYM_FUNC_END(entry_INT80_32) #endif .endm -#ifdef CONFIG_PARAVIRT -SYM_CODE_START(native_iret) - iret - _ASM_EXTABLE(native_iret, asm_iret_error) -SYM_CODE_END(native_iret) -#endif - -#ifdef CONFIG_XEN_PV -/* - * See comment in entry_64.S for further explanation - * - * Note: This is not an actual IDT entry point. It's a XEN specific entry - * point and therefore named to match the 64-bit trampoline counterpart. - */ -SYM_FUNC_START(xen_asm_exc_xen_hypervisor_callback) - /* - * Check to see if we got the event in the critical - * region in xen_iret_direct, after we've reenabled - * events and checked for pending events. This simulates - * iret instruction's behaviour where it delivers a - * pending interrupt when enabling interrupts: - */ - cmpl $xen_iret_start_crit, (%esp) - jb 1f - cmpl $xen_iret_end_crit, (%esp) - jae 1f - call xen_iret_crit_fixup -1: - pushl $-1 /* orig_ax = -1 => not a system call */ - SAVE_ALL - ENCODE_FRAME_POINTER - - mov %esp, %eax - call xen_pv_evtchn_do_upcall - jmp handle_exception_return -SYM_FUNC_END(xen_asm_exc_xen_hypervisor_callback) - -/* - * Hypervisor uses this for application faults while it executes. - * We get here for two reasons: - * 1. Fault while reloading DS, ES, FS or GS - * 2. Fault while executing IRET - * Category 1 we fix up by reattempting the load, and zeroing the segment - * register if the load fails. - * Category 2 we fix up by jumping to do_iret_error. We cannot use the - * normal Linux return path in this case because if we use the IRET hypercall - * to pop the stack frame we end up in an infinite loop of failsafe callbacks. - * We distinguish between categories by maintaining a status value in EAX. - */ -SYM_FUNC_START(xen_failsafe_callback) - pushl %eax - movl $1, %eax -1: mov 4(%esp), %ds -2: mov 8(%esp), %es -3: mov 12(%esp), %fs -4: mov 16(%esp), %gs - /* EAX == 0 => Category 1 (Bad segment) - EAX != 0 => Category 2 (Bad IRET) */ - testl %eax, %eax - popl %eax - lea 16(%esp), %esp - jz 5f - jmp asm_iret_error -5: pushl $-1 /* orig_ax = -1 => not a system call */ - SAVE_ALL - ENCODE_FRAME_POINTER - jmp handle_exception_return - -.section .fixup, "ax" -6: xorl %eax, %eax - movl %eax, 4(%esp) - jmp 1b -7: xorl %eax, %eax - movl %eax, 8(%esp) - jmp 2b -8: xorl %eax, %eax - movl %eax, 12(%esp) - jmp 3b -9: xorl %eax, %eax - movl %eax, 16(%esp) - jmp 4b -.previous - _ASM_EXTABLE(1b, 6b) - _ASM_EXTABLE(2b, 7b) - _ASM_EXTABLE(3b, 8b) - _ASM_EXTABLE(4b, 9b) -SYM_FUNC_END(xen_failsafe_callback) -#endif /* CONFIG_XEN_PV */ - SYM_CODE_START_LOCAL_NOALIGN(handle_exception) /* the function address is in %gs's slot on the stack */ SAVE_ALL switch_stacks=1 skip_gs=1 unwind_espfix=1 diff --git a/arch/x86/entry/vdso/vdso32/note.S b/arch/x86/entry/vdso/vdso32/note.S index e78047d119f6..2cbd39939dc6 100644 --- a/arch/x86/entry/vdso/vdso32/note.S +++ b/arch/x86/entry/vdso/vdso32/note.S @@ -16,33 +16,3 @@ ELFNOTE_START(Linux, 0, "a") ELFNOTE_END BUILD_SALT - -#ifdef CONFIG_XEN -/* - * Add a special note telling glibc's dynamic linker a fake hardware - * flavor that it will use to choose the search path for libraries in the - * same way it uses real hardware capabilities like "mmx". - * We supply "nosegneg" as the fake capability, to indicate that we - * do not like negative offsets in instructions using segment overrides, - * since we implement those inefficiently. This makes it possible to - * install libraries optimized to avoid those access patterns in someplace - * like /lib/i686/tls/nosegneg. Note that an /etc/ld.so.conf.d/file - * corresponding to the bits here is needed to make ldconfig work right. - * It should contain: - * hwcap 1 nosegneg - * to match the mapping of bit to name that we give here. - * - * At runtime, the fake hardware feature will be considered to be present - * if its bit is set in the mask word. So, we start with the mask 0, and - * at boot time we set VDSO_NOTE_NONEGSEG_BIT if running under Xen. - */ - -#include "../../xen/vdso.h" /* Defines VDSO_NOTE_NONEGSEG_BIT. */ - -ELFNOTE_START(GNU, 2, "a") - .long 1 /* ncaps */ -VDSO32_NOTE_MASK: /* Symbol used by arch/x86/xen/setup.c */ - .long 0 /* mask */ - .byte VDSO_NOTE_NONEGSEG_BIT; .asciz "nosegneg" /* bit, name */ -ELFNOTE_END -#endif diff --git a/arch/x86/include/asm/proto.h b/arch/x86/include/asm/proto.h index 6e81788a30c1..28996fe19301 100644 --- a/arch/x86/include/asm/proto.h +++ b/arch/x86/include/asm/proto.h @@ -25,7 +25,7 @@ void entry_SYSENTER_compat(void); void __end_entry_SYSENTER_compat(void); void entry_SYSCALL_compat(void); void entry_INT80_compat(void); -#if defined(CONFIG_X86_64) && defined(CONFIG_XEN_PV) +#ifdef CONFIG_XEN_PV void xen_entry_INT80_compat(void); #endif #endif diff --git a/arch/x86/include/asm/segment.h b/arch/x86/include/asm/segment.h index 6669164abadc..9646c300f128 100644 --- a/arch/x86/include/asm/segment.h +++ b/arch/x86/include/asm/segment.h @@ -301,7 +301,7 @@ static inline void vdso_read_cpunode(unsigned *cpu, unsigned *node) extern const char early_idt_handler_array[NUM_EXCEPTION_VECTORS][EARLY_IDT_HANDLER_SIZE]; extern void early_ignore_irq(void); -#if defined(CONFIG_X86_64) && defined(CONFIG_XEN_PV) +#ifdef CONFIG_XEN_PV extern const char xen_early_idt_handler_array[NUM_EXCEPTION_VECTORS][XEN_EARLY_IDT_HANDLER_SIZE]; #endif diff --git a/arch/x86/kernel/head_32.S b/arch/x86/kernel/head_32.S index f66a6b90f954..7ed84c282233 100644 --- a/arch/x86/kernel/head_32.S +++ b/arch/x86/kernel/head_32.S @@ -134,38 +134,7 @@ SYM_CODE_START(startup_32) movl %eax,pa(initial_page_table+0xffc) #endif -#ifdef CONFIG_PARAVIRT - /* This is can only trip for a broken bootloader... */ - cmpw $0x207, pa(boot_params + BP_version) - jb .Ldefault_entry - - /* Paravirt-compatible boot parameters. Look to see what architecture - we're booting under. */ - movl pa(boot_params + BP_hardware_subarch), %eax - cmpl $num_subarch_entries, %eax - jae .Lbad_subarch - - movl pa(subarch_entries)(,%eax,4), %eax - subl $__PAGE_OFFSET, %eax - jmp *%eax - -.Lbad_subarch: -SYM_INNER_LABEL_ALIGN(xen_entry, SYM_L_WEAK) - /* Unknown implementation; there's really - nothing we can do at this point. */ - ud2a - - __INITDATA - -subarch_entries: - .long .Ldefault_entry /* normal x86/PC */ - .long xen_entry /* Xen hypervisor */ - .long .Ldefault_entry /* Moorestown MID */ -num_subarch_entries = (. - subarch_entries) / 4 -.previous -#else jmp .Ldefault_entry -#endif /* CONFIG_PARAVIRT */ SYM_CODE_END(startup_32) #ifdef CONFIG_HOTPLUG_CPU diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig index 1aded63a95cb..218acbd5c7a0 100644 --- a/arch/x86/xen/Kconfig +++ b/arch/x86/xen/Kconfig @@ -19,6 +19,7 @@ config XEN_PV bool "Xen PV guest support" default y depends on XEN + depends on X86_64 select PARAVIRT_XXL select XEN_HAVE_PVMMU select XEN_HAVE_VPMU @@ -50,7 +51,7 @@ config XEN_PVHVM_SMP config XEN_512GB bool "Limit Xen pv-domain memory to 512GB" - depends on XEN_PV && X86_64 + depends on XEN_PV default y help Limit paravirtualized user domains to 512GB of RAM. diff --git a/arch/x86/xen/apic.c b/arch/x86/xen/apic.c index 5e53bfbe5823..ea6e9c54da9d 100644 --- a/arch/x86/xen/apic.c +++ b/arch/x86/xen/apic.c @@ -58,10 +58,6 @@ static u32 xen_apic_read(u32 reg) if (reg == APIC_LVR) return 0x14; -#ifdef CONFIG_X86_32 - if (reg == APIC_LDR) - return SET_APIC_LOGICAL_ID(1UL << smp_processor_id()); -#endif if (reg != APIC_ID) return 0; @@ -127,14 +123,6 @@ static int xen_phys_pkg_id(int initial_apic_id, int index_msb) return initial_apic_id >> index_msb; } -#ifdef CONFIG_X86_32 -static int xen_x86_32_early_logical_apicid(int cpu) -{ - /* Match with APIC_LDR read. Otherwise setup_local_APIC complains. */ - return 1 << cpu; -} -#endif - static void xen_noop(void) { } @@ -197,11 +185,6 @@ static struct apic xen_pv_apic = { .icr_write = xen_apic_icr_write, .wait_icr_idle = xen_noop, .safe_wait_icr_idle = xen_safe_apic_wait_icr_idle, - -#ifdef CONFIG_X86_32 - /* generic_processor_info and setup_local_APIC. */ - .x86_32_early_logical_apicid = xen_x86_32_early_logical_apicid, -#endif }; static void __init xen_apic_check(void) diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c index 2aab43a13a8c..7d90b3da8bb4 100644 --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -119,14 +119,6 @@ static void __init xen_banner(void) printk(KERN_INFO "Xen version: %d.%d%s%s\n", version >> 16, version & 0xffff, extra.extraversion, xen_feature(XENFEAT_mmu_pt_update_preserve_ad) ? " (preserve-AD)" : ""); - -#ifdef CONFIG_X86_32 - pr_warn("WARNING! WARNING! WARNING! WARNING! WARNING! WARNING! WARNING!\n" - "Support for running as 32-bit PV-guest under Xen will soon be removed\n" - "from the Linux kernel!\n" - "Please use either a 64-bit kernel or switch to HVM or PVH mode!\n" - "WARNING! WARNING! WARNING! WARNING! WARNING! WARNING! WARNING!\n"); -#endif } static void __init xen_pv_init_platform(void) @@ -538,30 +530,12 @@ static void load_TLS_descriptor(struct thread_struct *t, static void xen_load_tls(struct thread_struct *t, unsigned int cpu) { /* - * XXX sleazy hack: If we're being called in a lazy-cpu zone - * and lazy gs handling is enabled, it means we're in a - * context switch, and %gs has just been saved. This means we - * can zero it out to prevent faults on exit from the - * hypervisor if the next process has no %gs. Either way, it - * has been saved, and the new value will get loaded properly. - * This will go away as soon as Xen has been modified to not - * save/restore %gs for normal hypercalls. - * - * On x86_64, this hack is not used for %gs, because gs points - * to KERNEL_GS_BASE (and uses it for PDA references), so we - * must not zero %gs on x86_64 - * - * For x86_64, we need to zero %fs, otherwise we may get an + * In lazy mode we need to zero %fs, otherwise we may get an * exception between the new %fs descriptor being loaded and * %fs being effectively cleared at __switch_to(). */ - if (paravirt_get_lazy_mode() == PARAVIRT_LAZY_CPU) { -#ifdef CONFIG_X86_32 - lazy_load_gs(0); -#else + if (paravirt_get_lazy_mode() == PARAVIRT_LAZY_CPU) loadsegment(fs, 0); -#endif - } xen_mc_batch(); @@ -572,13 +546,11 @@ static void xen_load_tls(struct thread_struct *t, unsigned int cpu) xen_mc_issue(PARAVIRT_LAZY_CPU); } -#ifdef CONFIG_X86_64 static void xen_load_gs_index(unsigned int idx) { if (HYPERVISOR_set_segment_base(SEGBASE_GS_USER_SEL, idx)) BUG(); } -#endif static void xen_write_ldt_entry(struct desc_struct *dt, int entrynum, const void *ptr) @@ -597,7 +569,6 @@ static void xen_write_ldt_entry(struct desc_struct *dt, int entrynum, preempt_enable(); } -#ifdef CONFIG_X86_64 void noist_exc_debug(struct pt_regs *regs); DEFINE_IDTENTRY_RAW(xenpv_exc_nmi) @@ -697,7 +668,6 @@ static bool __ref get_trap_addr(void **addr, unsigned int ist) return true; } -#endif static int cvt_gate_to_trap(int vector, const gate_desc *val, struct trap_info *info) @@ -710,10 +680,8 @@ static int cvt_gate_to_trap(int vector, const gate_desc *val, info->vector = vector; addr = gate_offset(val); -#ifdef CONFIG_X86_64 if (!get_trap_addr((void **)&addr, val->bits.ist)) return 0; -#endif /* CONFIG_X86_64 */ info->address = addr; info->cs = gate_segment(val); @@ -958,15 +926,12 @@ static u64 xen_read_msr_safe(unsigned int msr, int *err) static int xen_write_msr_safe(unsigned int msr, unsigned low, unsigned high) { int ret; -#ifdef CONFIG_X86_64 unsigned int which; u64 base; -#endif ret = 0; switch (msr) { -#ifdef CONFIG_X86_64 case MSR_FS_BASE: which = SEGBASE_FS; goto set; case MSR_KERNEL_GS_BASE: which = SEGBASE_GS_USER; goto set; case MSR_GS_BASE: which = SEGBASE_GS_KERNEL; goto set; @@ -976,7 +941,6 @@ static int xen_write_msr_safe(unsigned int msr, unsigned low, unsigned high) if (HYPERVISOR_set_segment_base(which, base) != 0) ret = -EIO; break; -#endif case MSR_STAR: case MSR_CSTAR: @@ -1058,9 +1022,7 @@ void __init xen_setup_vcpu_info_placement(void) static const struct pv_info xen_info __initconst = { .shared_kernel_pmd = 0, -#ifdef CONFIG_X86_64 .extra_user_64bit_cs = FLAT_USER_CS64, -#endif .name = "Xen", }; @@ -1086,18 +1048,14 @@ static const struct pv_cpu_ops xen_cpu_ops __initconst = { .read_pmc = xen_read_pmc, .iret = xen_iret, -#ifdef CONFIG_X86_64 .usergs_sysret64 = xen_sysret64, -#endif .load_tr_desc = paravirt_nop, .set_ldt = xen_set_ldt, .load_gdt = xen_load_gdt, .load_idt = xen_load_idt, .load_tls = xen_load_tls, -#ifdef CONFIG_X86_64 .load_gs_index = xen_load_gs_index, -#endif .alloc_ldt = xen_alloc_ldt, .free_ldt = xen_free_ldt, @@ -1364,13 +1322,8 @@ asmlinkage __visible void __init xen_start_kernel(void) /* keep using Xen gdt for now; no urgent need to change it */ -#ifdef CONFIG_X86_32 - pv_info.kernel_rpl = 1; - if (xen_feature(XENFEAT_supervisor_mode_kernel)) - pv_info.kernel_rpl = 0; -#else pv_info.kernel_rpl = 0; -#endif + /* set the limit of our address space */ xen_reserve_top(); @@ -1384,12 +1337,6 @@ asmlinkage __visible void __init xen_start_kernel(void) if (rc != 0) xen_raw_printk("physdev_op failed %d\n", rc); -#ifdef CONFIG_X86_32 - /* set up basic CPUID stuff */ - cpu_detect(&new_cpu_data); - set_cpu_cap(&new_cpu_data, X86_FEATURE_FPU); - new_cpu_data.x86_capability[CPUID_1_EDX] = cpuid_edx(1); -#endif if (xen_start_info->mod_start) { if (xen_start_info->flags & SIF_MOD_START_PFN) @@ -1458,12 +1405,8 @@ asmlinkage __visible void __init xen_start_kernel(void) xen_efi_init(&boot_params); /* Start the world */ -#ifdef CONFIG_X86_32 - i386_start_kernel(); -#else cr4_init_shadow(); /* 32b kernel does this in i386_start_kernel() */ x86_64_start_reservations((char *)__pa_symbol(&boot_params)); -#endif } static int xen_cpu_up_prepare_pv(unsigned int cpu) diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c index a58d9c69807a..1f9500d0b839 100644 --- a/arch/x86/xen/mmu_pv.c +++ b/arch/x86/xen/mmu_pv.c @@ -86,19 +86,8 @@ #include "mmu.h" #include "debugfs.h" -#ifdef CONFIG_X86_32 -/* - * Identity map, in addition to plain kernel map. This needs to be - * large enough to allocate page table pages to allocate the rest. - * Each page can map 2MB. - */ -#define LEVEL1_IDENT_ENTRIES (PTRS_PER_PTE * 4) -static RESERVE_BRK_ARRAY(pte_t, level1_ident_pgt, LEVEL1_IDENT_ENTRIES); -#endif -#ifdef CONFIG_X86_64 /* l3 pud for userspace vsyscall mapping */ static pud_t level3_user_vsyscall[PTRS_PER_PUD] __page_aligned_bss; -#endif /* CONFIG_X86_64 */ /* * Protects atomic reservation decrease/increase against concurrent increases. @@ -280,10 +269,7 @@ static inline void __xen_set_pte(pte_t *ptep, pte_t pteval) if (!xen_batched_set_pte(ptep, pteval)) { /* * Could call native_set_pte() here and trap and - * emulate the PTE write but with 32-bit guests this - * needs two traps (one for each of the two 32-bit - * words in the PTE) so do one hypercall directly - * instead. + * emulate the PTE write, but a hypercall is much cheaper. */ struct mmu_update u; @@ -439,26 +425,6 @@ static void xen_set_pud(pud_t *ptr, pud_t val) xen_set_pud_hyper(ptr, val); } -#ifdef CONFIG_X86_PAE -static void xen_set_pte_atomic(pte_t *ptep, pte_t pte) -{ - trace_xen_mmu_set_pte_atomic(ptep, pte); - __xen_set_pte(ptep, pte); -} - -static void xen_pte_clear(struct mm_struct *mm, unsigned long addr, pte_t *ptep) -{ - trace_xen_mmu_pte_clear(mm, addr, ptep); - __xen_set_pte(ptep, native_make_pte(0)); -} - -static void xen_pmd_clear(pmd_t *pmdp) -{ - trace_xen_mmu_pmd_clear(pmdp); - set_pmd(pmdp, __pmd(0)); -} -#endif /* CONFIG_X86_PAE */ - __visible pmd_t xen_make_pmd(pmdval_t pmd) { pmd = pte_pfn_to_mfn(pmd); @@ -466,7 +432,6 @@ __visible pmd_t xen_make_pmd(pmdval_t pmd) } PV_CALLEE_SAVE_REGS_THUNK(xen_make_pmd); -#ifdef CONFIG_X86_64 __visible pudval_t xen_pud_val(pud_t pud) { return pte_mfn_to_pfn(pud.pud); @@ -571,7 +536,6 @@ __visible p4d_t xen_make_p4d(p4dval_t p4d) } PV_CALLEE_SAVE_REGS_THUNK(xen_make_p4d); #endif /* CONFIG_PGTABLE_LEVELS >= 5 */ -#endif /* CONFIG_X86_64 */ static int xen_pmd_walk(struct mm_struct *mm, pmd_t *pmd, int (*func)(struct mm_struct *mm, struct page *, enum pt_level), @@ -636,11 +600,8 @@ static int xen_p4d_walk(struct mm_struct *mm, p4d_t *p4d, * will be STACK_TOP_MAX, but at boot we need to pin up to * FIXADDR_TOP. * - * For 32-bit the important bit is that we don't pin beyond there, - * because then we start getting into Xen's ptes. - * - * For 64-bit, we must skip the Xen hole in the middle of the address - * space, just after the big x86-64 virtual hole. + * We must skip the Xen hole in the middle of the address space, just after + * the big x86-64 virtual hole. */ static int __xen_pgd_walk(struct mm_struct *mm, pgd_t *pgd, int (*func)(struct mm_struct *mm, struct page *, @@ -654,14 +615,12 @@ static int __xen_pgd_walk(struct mm_struct *mm, pgd_t *pgd, limit--; BUG_ON(limit >= FIXADDR_TOP); -#ifdef CONFIG_X86_64 /* * 64-bit has a great big hole in the middle of the address * space, which contains the Xen mappings. */ hole_low = pgd_index(GUARD_HOLE_BASE_ADDR); hole_high = pgd_index(GUARD_HOLE_END_ADDR); -#endif nr = pgd_index(limit) + 1; for (i = 0; i < nr; i++) { @@ -787,6 +746,8 @@ static int xen_pin_page(struct mm_struct *mm, struct page *page, read-only, and can be pinned. */ static void __xen_pgd_pin(struct mm_struct *mm, pgd_t *pgd) { + pgd_t *user_pgd = xen_get_user_pgd(pgd); + trace_xen_mmu_pgd_pin(mm, pgd); xen_mc_batch(); @@ -800,26 +761,14 @@ static void __xen_pgd_pin(struct mm_struct *mm, pgd_t *pgd) xen_mc_batch(); } -#ifdef CONFIG_X86_64 - { - pgd_t *user_pgd = xen_get_user_pgd(pgd); + xen_do_pin(MMUEXT_PIN_L4_TABLE, PFN_DOWN(__pa(pgd))); - xen_do_pin(MMUEXT_PIN_L4_TABLE, PFN_DOWN(__pa(pgd))); - - if (user_pgd) { - xen_pin_page(mm, virt_to_page(user_pgd), PT_PGD); - xen_do_pin(MMUEXT_PIN_L4_TABLE, - PFN_DOWN(__pa(user_pgd))); - } + if (user_pgd) { + xen_pin_page(mm, virt_to_page(user_pgd), PT_PGD); + xen_do_pin(MMUEXT_PIN_L4_TABLE, + PFN_DOWN(__pa(user_pgd))); } -#else /* CONFIG_X86_32 */ -#ifdef CONFIG_X86_PAE - /* Need to make sure unshared kernel PMD is pinnable */ - xen_pin_page(mm, pgd_page(pgd[pgd_index(TASK_SIZE)]), - PT_PMD); -#endif - xen_do_pin(MMUEXT_PIN_L3_TABLE, PFN_DOWN(__pa(pgd))); -#endif /* CONFIG_X86_64 */ + xen_mc_issue(0); } @@ -870,9 +819,7 @@ static int __init xen_mark_pinned(struct mm_struct *mm, struct page *page, static void __init xen_after_bootmem(void) { static_branch_enable(&xen_struct_pages_ready); -#ifdef CONFIG_X86_64 SetPagePinned(virt_to_page(level3_user_vsyscall)); -#endif xen_pgd_walk(&init_mm, xen_mark_pinned, FIXADDR_TOP); } @@ -919,29 +866,19 @@ static int xen_unpin_page(struct mm_struct *mm, struct page *page, /* Release a pagetables pages back as normal RW */ static void __xen_pgd_unpin(struct mm_struct *mm, pgd_t *pgd) { + pgd_t *user_pgd = xen_get_user_pgd(pgd); + trace_xen_mmu_pgd_unpin(mm, pgd); xen_mc_batch(); xen_do_pin(MMUEXT_UNPIN_TABLE, PFN_DOWN(__pa(pgd))); -#ifdef CONFIG_X86_64 - { - pgd_t *user_pgd = xen_get_user_pgd(pgd); - - if (user_pgd) { - xen_do_pin(MMUEXT_UNPIN_TABLE, - PFN_DOWN(__pa(user_pgd))); - xen_unpin_page(mm, virt_to_page(user_pgd), PT_PGD); - } + if (user_pgd) { + xen_do_pin(MMUEXT_UNPIN_TABLE, + PFN_DOWN(__pa(user_pgd))); + xen_unpin_page(mm, virt_to_page(user_pgd), PT_PGD); } -#endif - -#ifdef CONFIG_X86_PAE - /* Need to make sure unshared kernel PMD is unpinned */ - xen_unpin_page(mm, pgd_page(pgd[pgd_index(TASK_SIZE)]), - PT_PMD); -#endif __xen_pgd_walk(mm, pgd, xen_unpin_page, USER_LIMIT); @@ -1089,7 +1026,6 @@ static void __init pin_pagetable_pfn(unsigned cmd, unsigned long pfn) BUG(); } -#ifdef CONFIG_X86_64 static void __init xen_cleanhighmap(unsigned long vaddr, unsigned long vaddr_end) { @@ -1273,17 +1209,15 @@ static void __init xen_pagetable_cleanhighmap(void) xen_cleanhighmap(addr, roundup(addr + size, PMD_SIZE * 2)); xen_start_info->pt_base = (unsigned long)__va(__pa(xen_start_info->pt_base)); } -#endif static void __init xen_pagetable_p2m_setup(void) { xen_vmalloc_p2m_tree(); -#ifdef CONFIG_X86_64 xen_pagetable_p2m_free(); xen_pagetable_cleanhighmap(); -#endif + /* And revector! Bye bye old array */ xen_start_info->mfn_list = (unsigned long)xen_p2m_addr; } @@ -1420,6 +1354,8 @@ static void __xen_write_cr3(bool kernel, unsigned long cr3) } static void xen_write_cr3(unsigned long cr3) { + pgd_t *user_pgd = xen_get_user_pgd(__va(cr3)); + BUG_ON(preemptible()); xen_mc_batch(); /* disables interrupts */ @@ -1430,20 +1366,14 @@ static void xen_write_cr3(unsigned long cr3) __xen_write_cr3(true, cr3); -#ifdef CONFIG_X86_64 - { - pgd_t *user_pgd = xen_get_user_pgd(__va(cr3)); - if (user_pgd) - __xen_write_cr3(false, __pa(user_pgd)); - else - __xen_write_cr3(false, 0); - } -#endif + if (user_pgd) + __xen_write_cr3(false, __pa(user_pgd)); + else + __xen_write_cr3(false, 0); xen_mc_issue(PARAVIRT_LAZY_CPU); /* interrupts restored */ } -#ifdef CONFIG_X86_64 /* * At the start of the day - when Xen launches a guest, it has already * built pagetables for the guest. We diligently look over them @@ -1478,49 +1408,39 @@ static void __init xen_write_cr3_init(unsigned long cr3) xen_mc_issue(PARAVIRT_LAZY_CPU); /* interrupts restored */ } -#endif static int xen_pgd_alloc(struct mm_struct *mm) { pgd_t *pgd = mm->pgd; - int ret = 0; + struct page *page = virt_to_page(pgd); + pgd_t *user_pgd; + int ret = -ENOMEM; BUG_ON(PagePinned(virt_to_page(pgd))); + BUG_ON(page->private != 0); -#ifdef CONFIG_X86_64 - { - struct page *page = virt_to_page(pgd); - pgd_t *user_pgd; - - BUG_ON(page->private != 0); - - ret = -ENOMEM; - - user_pgd = (pgd_t *)__get_free_page(GFP_KERNEL | __GFP_ZERO); - page->private = (unsigned long)user_pgd; + user_pgd = (pgd_t *)__get_free_page(GFP_KERNEL | __GFP_ZERO); + page->private = (unsigned long)user_pgd; - if (user_pgd != NULL) { + if (user_pgd != NULL) { #ifdef CONFIG_X86_VSYSCALL_EMULATION - user_pgd[pgd_index(VSYSCALL_ADDR)] = - __pgd(__pa(level3_user_vsyscall) | _PAGE_TABLE); + user_pgd[pgd_index(VSYSCALL_ADDR)] = + __pgd(__pa(level3_user_vsyscall) | _PAGE_TABLE); #endif - ret = 0; - } - - BUG_ON(PagePinned(virt_to_page(xen_get_user_pgd(pgd)))); + ret = 0; } -#endif + + BUG_ON(PagePinned(virt_to_page(xen_get_user_pgd(pgd)))); + return ret; } static void xen_pgd_free(struct mm_struct *mm, pgd_t *pgd) { -#ifdef CONFIG_X86_64 pgd_t *user_pgd = xen_get_user_pgd(pgd); if (user_pgd) free_page((unsigned long)user_pgd); -#endif } /* @@ -1539,7 +1459,6 @@ static void xen_pgd_free(struct mm_struct *mm, pgd_t *pgd) */ __visible pte_t xen_make_pte_init(pteval_t pte) { -#ifdef CONFIG_X86_64 unsigned long pfn; /* @@ -1553,7 +1472,7 @@ __visible pte_t xen_make_pte_init(pteval_t pte) pfn >= xen_start_info->first_p2m_pfn && pfn < xen_start_info->first_p2m_pfn + xen_start_info->nr_p2m_frames) pte &= ~_PAGE_RW; -#endif + pte = pte_pfn_to_mfn(pte); return native_make_pte(pte); } @@ -1561,13 +1480,6 @@ PV_CALLEE_SAVE_REGS_THUNK(xen_make_pte_init); static void __init xen_set_pte_init(pte_t *ptep, pte_t pte) { -#ifdef CONFIG_X86_32 - /* If there's an existing pte, then don't allow _PAGE_RW to be set */ - if (pte_mfn(pte) != INVALID_P2M_ENTRY - && pte_val_ma(*ptep) & _PAGE_PRESENT) - pte = __pte_ma(((pte_val_ma(*ptep) & _PAGE_RW) | ~_PAGE_RW) & - pte_val_ma(pte)); -#endif __xen_set_pte(ptep, pte); } @@ -1702,7 +1614,6 @@ static void xen_release_pmd(unsigned long pfn) xen_release_ptpage(pfn, PT_PMD); } -#ifdef CONFIG_X86_64 static void xen_alloc_pud(struct mm_struct *mm, unsigned long pfn) { xen_alloc_ptpage(mm, pfn, PT_PUD); @@ -1712,19 +1623,9 @@ static void xen_release_pud(unsigned long pfn) { xen_release_ptpage(pfn, PT_PUD); } -#endif void __init xen_reserve_top(void) { -#ifdef CONFIG_X86_32 - unsigned long top = HYPERVISOR_VIRT_START; - struct xen_platform_parameters pp; - - if (HYPERVISOR_xen_version(XENVER_platform_parameters, &pp) == 0) - top = pp.virt_start; - - reserve_top_address(-top); -#endif /* CONFIG_X86_32 */ } /* @@ -1733,11 +1634,7 @@ void __init xen_reserve_top(void) */ static void * __init __ka(phys_addr_t paddr) { -#ifdef CONFIG_X86_64 return (void *)(paddr + __START_KERNEL_map); -#else - return __va(paddr); -#endif } /* Convert a machine address to physical address */ @@ -1771,56 +1668,7 @@ static void __init set_page_prot(void *addr, pgprot_t prot) { return set_page_prot_flags(addr, prot, UVMF_NONE); } -#ifdef CONFIG_X86_32 -static void __init xen_map_identity_early(pmd_t *pmd, unsigned long max_pfn) -{ - unsigned pmdidx, pteidx; - unsigned ident_pte; - unsigned long pfn; - - level1_ident_pgt = extend_brk(sizeof(pte_t) * LEVEL1_IDENT_ENTRIES, - PAGE_SIZE); - ident_pte = 0; - pfn = 0; - for (pmdidx = 0; pmdidx < PTRS_PER_PMD && pfn < max_pfn; pmdidx++) { - pte_t *pte_page; - - /* Reuse or allocate a page of ptes */ - if (pmd_present(pmd[pmdidx])) - pte_page = m2v(pmd[pmdidx].pmd); - else { - /* Check for free pte pages */ - if (ident_pte == LEVEL1_IDENT_ENTRIES) - break; - - pte_page = &level1_ident_pgt[ident_pte]; - ident_pte += PTRS_PER_PTE; - - pmd[pmdidx] = __pmd(__pa(pte_page) | _PAGE_TABLE); - } - - /* Install mappings */ - for (pteidx = 0; pteidx < PTRS_PER_PTE; pteidx++, pfn++) { - pte_t pte; - - if (pfn > max_pfn_mapped) - max_pfn_mapped = pfn; - - if (!pte_none(pte_page[pteidx])) - continue; - - pte = pfn_pte(pfn, PAGE_KERNEL_EXEC); - pte_page[pteidx] = pte; - } - } - - for (pteidx = 0; pteidx < ident_pte; pteidx += PTRS_PER_PTE) - set_page_prot(&level1_ident_pgt[pteidx], PAGE_KERNEL_RO); - - set_page_prot(pmd, PAGE_KERNEL_RO); -} -#endif void __init xen_setup_machphys_mapping(void) { struct xen_machphys_mapping mapping; @@ -1831,13 +1679,8 @@ void __init xen_setup_machphys_mapping(void) } else { machine_to_phys_nr = MACH2PHYS_NR_ENTRIES; } -#ifdef CONFIG_X86_32 - WARN_ON((machine_to_phys_mapping + (machine_to_phys_nr - 1)) - < machine_to_phys_mapping); -#endif } -#ifdef CONFIG_X86_64 static void __init convert_pfn_mfn(void *v) { pte_t *pte = v; @@ -2168,105 +2011,6 @@ void __init xen_relocate_p2m(void) xen_start_info->nr_p2m_frames = n_frames; } -#else /* !CONFIG_X86_64 */ -static RESERVE_BRK_ARRAY(pmd_t, initial_kernel_pmd, PTRS_PER_PMD); -static RESERVE_BRK_ARRAY(pmd_t, swapper_kernel_pmd, PTRS_PER_PMD); -RESERVE_BRK(fixup_kernel_pmd, PAGE_SIZE); -RESERVE_BRK(fixup_kernel_pte, PAGE_SIZE); - -static void __init xen_write_cr3_init(unsigned long cr3) -{ - unsigned long pfn = PFN_DOWN(__pa(swapper_pg_dir)); - - BUG_ON(read_cr3_pa() != __pa(initial_page_table)); - BUG_ON(cr3 != __pa(swapper_pg_dir)); - - /* - * We are switching to swapper_pg_dir for the first time (from - * initial_page_table) and therefore need to mark that page - * read-only and then pin it. - * - * Xen disallows sharing of kernel PMDs for PAE - * guests. Therefore we must copy the kernel PMD from - * initial_page_table into a new kernel PMD to be used in - * swapper_pg_dir. - */ - swapper_kernel_pmd = - extend_brk(sizeof(pmd_t) * PTRS_PER_PMD, PAGE_SIZE); - copy_page(swapper_kernel_pmd, initial_kernel_pmd); - swapper_pg_dir[KERNEL_PGD_BOUNDARY] = - __pgd(__pa(swapper_kernel_pmd) | _PAGE_PRESENT); - set_page_prot(swapper_kernel_pmd, PAGE_KERNEL_RO); - - set_page_prot(swapper_pg_dir, PAGE_KERNEL_RO); - xen_write_cr3(cr3); - pin_pagetable_pfn(MMUEXT_PIN_L3_TABLE, pfn); - - pin_pagetable_pfn(MMUEXT_UNPIN_TABLE, - PFN_DOWN(__pa(initial_page_table))); - set_page_prot(initial_page_table, PAGE_KERNEL); - set_page_prot(initial_kernel_pmd, PAGE_KERNEL); - - pv_ops.mmu.write_cr3 = &xen_write_cr3; -} - -/* - * For 32 bit domains xen_start_info->pt_base is the pgd address which might be - * not the first page table in the page table pool. - * Iterate through the initial page tables to find the real page table base. - */ -static phys_addr_t __init xen_find_pt_base(pmd_t *pmd) -{ - phys_addr_t pt_base, paddr; - unsigned pmdidx; - - pt_base = min(__pa(xen_start_info->pt_base), __pa(pmd)); - - for (pmdidx = 0; pmdidx < PTRS_PER_PMD; pmdidx++) - if (pmd_present(pmd[pmdidx]) && !pmd_large(pmd[pmdidx])) { - paddr = m2p(pmd[pmdidx].pmd); - pt_base = min(pt_base, paddr); - } - - return pt_base; -} - -void __init xen_setup_kernel_pagetable(pgd_t *pgd, unsigned long max_pfn) -{ - pmd_t *kernel_pmd; - - kernel_pmd = m2v(pgd[KERNEL_PGD_BOUNDARY].pgd); - - xen_pt_base = xen_find_pt_base(kernel_pmd); - xen_pt_size = xen_start_info->nr_pt_frames * PAGE_SIZE; - - initial_kernel_pmd = - extend_brk(sizeof(pmd_t) * PTRS_PER_PMD, PAGE_SIZE); - - max_pfn_mapped = PFN_DOWN(xen_pt_base + xen_pt_size + 512 * 1024); - - copy_page(initial_kernel_pmd, kernel_pmd); - - xen_map_identity_early(initial_kernel_pmd, max_pfn); - - copy_page(initial_page_table, pgd); - initial_page_table[KERNEL_PGD_BOUNDARY] = - __pgd(__pa(initial_kernel_pmd) | _PAGE_PRESENT); - - set_page_prot(initial_kernel_pmd, PAGE_KERNEL_RO); - set_page_prot(initial_page_table, PAGE_KERNEL_RO); - set_page_prot(empty_zero_page, PAGE_KERNEL_RO); - - pin_pagetable_pfn(MMUEXT_UNPIN_TABLE, PFN_DOWN(__pa(pgd))); - - pin_pagetable_pfn(MMUEXT_PIN_L3_TABLE, - PFN_DOWN(__pa(initial_page_table))); - xen_write_cr3(__pa(initial_page_table)); - - memblock_reserve(xen_pt_base, xen_pt_size); -} -#endif /* CONFIG_X86_64 */ - void __init xen_reserve_special_pages(void) { phys_addr_t paddr; @@ -2300,12 +2044,7 @@ static void xen_set_fixmap(unsigned idx, phys_addr_t phys, pgprot_t prot) switch (idx) { case FIX_BTMAP_END ... FIX_BTMAP_BEGIN: -#ifdef CONFIG_X86_32 - case FIX_WP_TEST: -# ifdef CONFIG_HIGHMEM - case FIX_KMAP_BEGIN ... FIX_KMAP_END: -# endif -#elif defined(CONFIG_X86_VSYSCALL_EMULATION) +#ifdef CONFIG_X86_VSYSCALL_EMULATION case VSYSCALL_PAGE: #endif /* All local page mappings */ @@ -2357,9 +2096,7 @@ static void __init xen_post_allocator_init(void) pv_ops.mmu.set_pte = xen_set_pte; pv_ops.mmu.set_pmd = xen_set_pmd; pv_ops.mmu.set_pud = xen_set_pud; -#ifdef CONFIG_X86_64 pv_ops.mmu.set_p4d = xen_set_p4d; -#endif /* This will work as long as patching hasn't happened yet (which it hasn't) */ @@ -2367,15 +2104,11 @@ static void __init xen_post_allocator_init(void) pv_ops.mmu.alloc_pmd = xen_alloc_pmd; pv_ops.mmu.release_pte = xen_release_pte; pv_ops.mmu.release_pmd = xen_release_pmd; -#ifdef CONFIG_X86_64 pv_ops.mmu.alloc_pud = xen_alloc_pud; pv_ops.mmu.release_pud = xen_release_pud; -#endif pv_ops.mmu.make_pte = PV_CALLEE_SAVE(xen_make_pte); -#ifdef CONFIG_X86_64 pv_ops.mmu.write_cr3 = &xen_write_cr3; -#endif } static void xen_leave_lazy_mmu(void) @@ -2420,17 +2153,11 @@ static const struct pv_mmu_ops xen_mmu_ops __initconst = { .make_pte = PV_CALLEE_SAVE(xen_make_pte_init), .make_pgd = PV_CALLEE_SAVE(xen_make_pgd), -#ifdef CONFIG_X86_PAE - .set_pte_atomic = xen_set_pte_atomic, - .pte_clear = xen_pte_clear, - .pmd_clear = xen_pmd_clear, -#endif /* CONFIG_X86_PAE */ .set_pud = xen_set_pud_hyper, .make_pmd = PV_CALLEE_SAVE(xen_make_pmd), .pmd_val = PV_CALLEE_SAVE(xen_pmd_val), -#ifdef CONFIG_X86_64 .pud_val = PV_CALLEE_SAVE(xen_pud_val), .make_pud = PV_CALLEE_SAVE(xen_make_pud), .set_p4d = xen_set_p4d_hyper, @@ -2442,7 +2169,6 @@ static const struct pv_mmu_ops xen_mmu_ops __initconst = { .p4d_val = PV_CALLEE_SAVE(xen_p4d_val), .make_p4d = PV_CALLEE_SAVE(xen_make_p4d), #endif -#endif /* CONFIG_X86_64 */ .activate_mm = xen_activate_mm, .dup_mmap = xen_dup_mmap, diff --git a/arch/x86/xen/p2m.c b/arch/x86/xen/p2m.c index 0acba2c712ab..be4151f42611 100644 --- a/arch/x86/xen/p2m.c +++ b/arch/x86/xen/p2m.c @@ -379,12 +379,8 @@ static void __init xen_rebuild_p2m_list(unsigned long *p2m) if (type == P2M_TYPE_PFN || i < chunk) { /* Use initial p2m page contents. */ -#ifdef CONFIG_X86_64 mfns = alloc_p2m_page(); copy_page(mfns, xen_p2m_addr + pfn); -#else - mfns = xen_p2m_addr + pfn; -#endif ptep = populate_extra_pte((unsigned long)(p2m + pfn)); set_pte(ptep, pfn_pte(PFN_DOWN(__pa(mfns)), PAGE_KERNEL)); @@ -467,7 +463,7 @@ EXPORT_SYMBOL_GPL(get_phys_to_machine); * Allocate new pmd(s). It is checked whether the old pmd is still in place. * If not, nothing is changed. This is okay as the only reason for allocating * a new pmd is to replace p2m_missing_pte or p2m_identity_pte by a individual - * pmd. In case of PAE/x86-32 there are multiple pmds to allocate! + * pmd. */ static pte_t *alloc_p2m_pmd(unsigned long addr, pte_t *pte_pg) { diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c index 3566e37241d7..7eab14d56369 100644 --- a/arch/x86/xen/setup.c +++ b/arch/x86/xen/setup.c @@ -32,7 +32,6 @@ #include #include #include "xen-ops.h" -#include "vdso.h" #include "mmu.h" #define GB(x) ((uint64_t)(x) * 1024 * 1024 * 1024) @@ -545,13 +544,10 @@ static unsigned long __init xen_get_pages_limit(void) { unsigned long limit; -#ifdef CONFIG_X86_32 - limit = GB(64) / PAGE_SIZE; -#else limit = MAXMEM / PAGE_SIZE; if (!xen_initial_domain() && xen_512gb_limit) limit = GB(512) / PAGE_SIZE; -#endif + return limit; } @@ -722,17 +718,8 @@ static void __init xen_reserve_xen_mfnlist(void) if (!xen_is_e820_reserved(start, size)) return; -#ifdef CONFIG_X86_32 - /* - * Relocating the p2m on 32 bit system to an arbitrary virtual address - * is not supported, so just give up. - */ - xen_raw_console_write("Xen hypervisor allocated p2m list conflicts with E820 map\n"); - BUG(); -#else xen_relocate_p2m(); memblock_free(start, size); -#endif } /** @@ -921,20 +908,6 @@ char * __init xen_memory_setup(void) return "Xen"; } -/* - * Set the bit indicating "nosegneg" library variants should be used. - * We only need to bother in pure 32-bit mode; compat 32-bit processes - * can have un-truncated segments, so wrapping around is allowed. - */ -static void __init fiddle_vdso(void) -{ -#ifdef CONFIG_X86_32 - u32 *mask = vdso_image_32.data + - vdso_image_32.sym_VDSO32_NOTE_MASK; - *mask |= 1 << VDSO_NOTE_NONEGSEG_BIT; -#endif -} - static int register_callback(unsigned type, const void *func) { struct callback_register callback = { @@ -951,11 +924,7 @@ void xen_enable_sysenter(void) int ret; unsigned sysenter_feature; -#ifdef CONFIG_X86_32 - sysenter_feature = X86_FEATURE_SEP; -#else sysenter_feature = X86_FEATURE_SYSENTER32; -#endif if (!boot_cpu_has(sysenter_feature)) return; @@ -967,7 +936,6 @@ void xen_enable_sysenter(void) void xen_enable_syscall(void) { -#ifdef CONFIG_X86_64 int ret; ret = register_callback(CALLBACKTYPE_syscall, xen_syscall_target); @@ -983,7 +951,6 @@ void xen_enable_syscall(void) if (ret != 0) setup_clear_cpu_cap(X86_FEATURE_SYSCALL32); } -#endif /* CONFIG_X86_64 */ } static void __init xen_pvmmu_arch_setup(void) @@ -1024,7 +991,6 @@ void __init xen_arch_setup(void) disable_cpuidle(); disable_cpufreq(); WARN_ON(xen_set_default_idle()); - fiddle_vdso(); #ifdef CONFIG_NUMA numa_off = 1; #endif diff --git a/arch/x86/xen/smp_pv.c b/arch/x86/xen/smp_pv.c index 9ea598dcc132..3a70cb1e9550 100644 --- a/arch/x86/xen/smp_pv.c +++ b/arch/x86/xen/smp_pv.c @@ -210,15 +210,6 @@ static void __init xen_pv_smp_prepare_boot_cpu(void) * sure the old memory can be recycled. */ make_lowmem_page_readwrite(xen_initial_gdt); -#ifdef CONFIG_X86_32 - /* - * Xen starts us with XEN_FLAT_RING1_DS, but linux code - * expects __USER_DS - */ - loadsegment(ds, __USER_DS); - loadsegment(es, __USER_DS); -#endif - xen_filter_cpu_maps(); xen_setup_vcpu_info_placement(); @@ -299,10 +290,6 @@ cpu_initialize_context(unsigned int cpu, struct task_struct *idle) gdt = get_cpu_gdt_rw(cpu); -#ifdef CONFIG_X86_32 - ctxt->user_regs.fs = __KERNEL_PERCPU; - ctxt->user_regs.gs = __KERNEL_STACK_CANARY; -#endif memset(&ctxt->fpu_ctxt, 0, sizeof(ctxt->fpu_ctxt)); /* @@ -340,12 +327,7 @@ cpu_initialize_context(unsigned int cpu, struct task_struct *idle) ctxt->kernel_ss = __KERNEL_DS; ctxt->kernel_sp = task_top_of_stack(idle); -#ifdef CONFIG_X86_32 - ctxt->event_callback_cs = __KERNEL_CS; - ctxt->failsafe_callback_cs = __KERNEL_CS; -#else ctxt->gs_base_kernel = per_cpu_offset(cpu); -#endif ctxt->event_callback_eip = (unsigned long)xen_asm_exc_xen_hypervisor_callback; ctxt->failsafe_callback_eip = diff --git a/arch/x86/xen/vdso.h b/arch/x86/xen/vdso.h deleted file mode 100644 index 873c54c488fe..000000000000 --- a/arch/x86/xen/vdso.h +++ /dev/null @@ -1,6 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0 */ - -/* Bit used for the pseudo-hwcap for non-negative segments. We use - bit 1 to avoid bugs in some versions of glibc when bit 0 is - used; the choice is otherwise arbitrary. */ -#define VDSO_NOTE_NONEGSEG_BIT 1 diff --git a/arch/x86/xen/xen-asm.S b/arch/x86/xen/xen-asm.S index 508fe204520b..c59d077510bf 100644 --- a/arch/x86/xen/xen-asm.S +++ b/arch/x86/xen/xen-asm.S @@ -76,11 +76,7 @@ SYM_FUNC_END(xen_save_fl_direct) */ SYM_FUNC_START(xen_restore_fl_direct) FRAME_BEGIN -#ifdef CONFIG_X86_64 testw $X86_EFLAGS_IF, %di -#else - testb $X86_EFLAGS_IF>>8, %ah -#endif setz PER_CPU_VAR(xen_vcpu_info) + XEN_vcpu_info_mask /* * Preempt here doesn't matter because that will deal with any @@ -104,15 +100,6 @@ SYM_FUNC_END(xen_restore_fl_direct) */ SYM_FUNC_START(check_events) FRAME_BEGIN -#ifdef CONFIG_X86_32 - push %eax - push %ecx - push %edx - call xen_force_evtchn_callback - pop %edx - pop %ecx - pop %eax -#else push %rax push %rcx push %rdx @@ -132,7 +119,6 @@ SYM_FUNC_START(check_events) pop %rdx pop %rcx pop %rax -#endif FRAME_END ret SYM_FUNC_END(check_events) diff --git a/arch/x86/xen/xen-asm_32.S b/arch/x86/xen/xen-asm_32.S deleted file mode 100644 index 4757cec33abe..000000000000 --- a/arch/x86/xen/xen-asm_32.S +++ /dev/null @@ -1,185 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0 */ -/* - * Asm versions of Xen pv-ops, suitable for direct use. - * - * We only bother with direct forms (ie, vcpu in pda) of the - * operations here; the indirect forms are better handled in C. - */ - -#include -#include -#include -#include - -#include - -#include - -/* Pseudo-flag used for virtual NMI, which we don't implement yet */ -#define XEN_EFLAGS_NMI 0x80000000 - -/* - * This is run where a normal iret would be run, with the same stack setup: - * 8: eflags - * 4: cs - * esp-> 0: eip - * - * This attempts to make sure that any pending events are dealt with - * on return to usermode, but there is a small window in which an - * event can happen just before entering usermode. If the nested - * interrupt ends up setting one of the TIF_WORK_MASK pending work - * flags, they will not be tested again before returning to - * usermode. This means that a process can end up with pending work, - * which will be unprocessed until the process enters and leaves the - * kernel again, which could be an unbounded amount of time. This - * means that a pending signal or reschedule event could be - * indefinitely delayed. - * - * The fix is to notice a nested interrupt in the critical window, and - * if one occurs, then fold the nested interrupt into the current - * interrupt stack frame, and re-process it iteratively rather than - * recursively. This means that it will exit via the normal path, and - * all pending work will be dealt with appropriately. - * - * Because the nested interrupt handler needs to deal with the current - * stack state in whatever form its in, we keep things simple by only - * using a single register which is pushed/popped on the stack. - */ - -.macro POP_FS -1: - popw %fs -.pushsection .fixup, "ax" -2: movw $0, (%esp) - jmp 1b -.popsection - _ASM_EXTABLE(1b,2b) -.endm - -SYM_CODE_START(xen_iret) - /* test eflags for special cases */ - testl $(X86_EFLAGS_VM | XEN_EFLAGS_NMI), 8(%esp) - jnz hyper_iret - - push %eax - ESP_OFFSET=4 # bytes pushed onto stack - - /* Store vcpu_info pointer for easy access */ -#ifdef CONFIG_SMP - pushw %fs - movl $(__KERNEL_PERCPU), %eax - movl %eax, %fs - movl %fs:xen_vcpu, %eax - POP_FS -#else - movl %ss:xen_vcpu, %eax -#endif - - /* check IF state we're restoring */ - testb $X86_EFLAGS_IF>>8, 8+1+ESP_OFFSET(%esp) - - /* - * Maybe enable events. Once this happens we could get a - * recursive event, so the critical region starts immediately - * afterwards. However, if that happens we don't end up - * resuming the code, so we don't have to be worried about - * being preempted to another CPU. - */ - setz %ss:XEN_vcpu_info_mask(%eax) -xen_iret_start_crit: - - /* check for unmasked and pending */ - cmpw $0x0001, %ss:XEN_vcpu_info_pending(%eax) - - /* - * If there's something pending, mask events again so we can - * jump back into exc_xen_hypervisor_callback. Otherwise do not - * touch XEN_vcpu_info_mask. - */ - jne 1f - movb $1, %ss:XEN_vcpu_info_mask(%eax) - -1: popl %eax - - /* - * From this point on the registers are restored and the stack - * updated, so we don't need to worry about it if we're - * preempted - */ -iret_restore_end: - - /* - * Jump to hypervisor_callback after fixing up the stack. - * Events are masked, so jumping out of the critical region is - * OK. - */ - je xen_asm_exc_xen_hypervisor_callback - -1: iret -xen_iret_end_crit: - _ASM_EXTABLE(1b, asm_iret_error) - -hyper_iret: - /* put this out of line since its very rarely used */ - jmp hypercall_page + __HYPERVISOR_iret * 32 -SYM_CODE_END(xen_iret) - - .globl xen_iret_start_crit, xen_iret_end_crit - -/* - * This is called by xen_asm_exc_xen_hypervisor_callback in entry_32.S when it sees - * that the EIP at the time of interrupt was between - * xen_iret_start_crit and xen_iret_end_crit. - * - * The stack format at this point is: - * ---------------- - * ss : (ss/esp may be present if we came from usermode) - * esp : - * eflags } outer exception info - * cs } - * eip } - * ---------------- - * eax : outer eax if it hasn't been restored - * ---------------- - * eflags } - * cs } nested exception info - * eip } - * return address : (into xen_asm_exc_xen_hypervisor_callback) - * - * In order to deliver the nested exception properly, we need to discard the - * nested exception frame such that when we handle the exception, we do it - * in the context of the outer exception rather than starting a new one. - * - * The only caveat is that if the outer eax hasn't been restored yet (i.e. - * it's still on stack), we need to restore its value here. -*/ -.pushsection .noinstr.text, "ax" -SYM_CODE_START(xen_iret_crit_fixup) - /* - * Paranoia: Make sure we're really coming from kernel space. - * One could imagine a case where userspace jumps into the - * critical range address, but just before the CPU delivers a - * PF, it decides to deliver an interrupt instead. Unlikely? - * Definitely. Easy to avoid? Yes. - */ - testb $2, 2*4(%esp) /* nested CS */ - jnz 2f - - /* - * If eip is before iret_restore_end then stack - * hasn't been restored yet. - */ - cmpl $iret_restore_end, 1*4(%esp) - jae 1f - - movl 4*4(%esp), %eax /* load outer EAX */ - ret $4*4 /* discard nested EIP, CS, and EFLAGS as - * well as the just restored EAX */ - -1: - ret $3*4 /* discard nested EIP, CS, and EFLAGS */ - -2: - ret -SYM_CODE_END(xen_iret_crit_fixup) -.popsection diff --git a/arch/x86/xen/xen-head.S b/arch/x86/xen/xen-head.S index 1ba601df3a37..2d7c8f34f56c 100644 --- a/arch/x86/xen/xen-head.S +++ b/arch/x86/xen/xen-head.S @@ -35,13 +35,8 @@ SYM_CODE_START(startup_xen) rep __ASM_SIZE(stos) mov %_ASM_SI, xen_start_info -#ifdef CONFIG_X86_64 mov initial_stack(%rip), %rsp -#else - mov initial_stack, %esp -#endif -#ifdef CONFIG_X86_64 /* Set up %gs. * * The base of %gs always points to fixed_percpu_data. If the @@ -53,7 +48,6 @@ SYM_CODE_START(startup_xen) movq $INIT_PER_CPU_VAR(fixed_percpu_data),%rax cdq wrmsr -#endif call xen_start_kernel SYM_CODE_END(startup_xen) diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig index 1d339ef92422..ea6c1e7e3e42 100644 --- a/drivers/xen/Kconfig +++ b/drivers/xen/Kconfig @@ -52,9 +52,7 @@ config XEN_BALLOON_MEMORY_HOTPLUG config XEN_BALLOON_MEMORY_HOTPLUG_LIMIT int "Hotplugged memory limit (in GiB) for a PV guest" - default 512 if X86_64 - default 4 if X86_32 - range 0 64 if X86_32 + default 512 depends on XEN_HAVE_PVMMU depends on XEN_BALLOON_MEMORY_HOTPLUG help -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Fri Aug 07 08:38:44 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 08:38:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xtk-0006y1-8R; Fri, 07 Aug 2020 08:38:44 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xtj-0006sR-Ah for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 08:38:43 +0000 X-Inumbo-ID: 840a6692-13d7-48e9-855b-33b292bdcd00 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 840a6692-13d7-48e9-855b-33b292bdcd00; Fri, 07 Aug 2020 08:38:32 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 607D9B63F; Fri, 7 Aug 2020 08:38:49 +0000 (UTC) From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/7] x86/xen: eliminate xen-asm_64.S Date: Fri, 7 Aug 2020 10:38:21 +0200 Message-Id: <20200807083826.16794-3-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200807083826.16794-1-jgross@suse.com> References: <20200807083826.16794-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Stefano Stabellini , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Boris Ostrovsky , Thomas Gleixner Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" With 32-bit pv-guest support removed xen-asm_64.S can be merged with xen-asm.S Signed-off-by: Juergen Gross --- arch/x86/xen/Makefile | 3 +- arch/x86/xen/xen-asm.S | 179 +++++++++++++++++++++++++++++++++++ arch/x86/xen/xen-asm_64.S | 192 -------------------------------------- 3 files changed, 180 insertions(+), 194 deletions(-) delete mode 100644 arch/x86/xen/xen-asm_64.S diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile index 084de77a109e..5de137d536cc 100644 --- a/arch/x86/xen/Makefile +++ b/arch/x86/xen/Makefile @@ -1,5 +1,5 @@ # SPDX-License-Identifier: GPL-2.0 -OBJECT_FILES_NON_STANDARD_xen-asm_$(BITS).o := y +OBJECT_FILES_NON_STANDARD_xen-asm.o := y ifdef CONFIG_FUNCTION_TRACER # Do not profile debug and lowlevel utilities @@ -34,7 +34,6 @@ obj-$(CONFIG_XEN_PV) += mmu_pv.o obj-$(CONFIG_XEN_PV) += irq.o obj-$(CONFIG_XEN_PV) += multicalls.o obj-$(CONFIG_XEN_PV) += xen-asm.o -obj-$(CONFIG_XEN_PV) += xen-asm_$(BITS).o obj-$(CONFIG_XEN_PVH) += enlighten_pvh.o diff --git a/arch/x86/xen/xen-asm.S b/arch/x86/xen/xen-asm.S index c59d077510bf..d1272a63f097 100644 --- a/arch/x86/xen/xen-asm.S +++ b/arch/x86/xen/xen-asm.S @@ -6,12 +6,19 @@ * operations here; the indirect forms are better handled in C. */ +#include #include #include #include +#include +#include +#include #include #include +#include + +#include #include /* @@ -137,3 +144,175 @@ SYM_FUNC_START(xen_read_cr2_direct) FRAME_END ret SYM_FUNC_END(xen_read_cr2_direct); + +.macro xen_pv_trap name +SYM_CODE_START(xen_\name) + pop %rcx + pop %r11 + jmp \name +SYM_CODE_END(xen_\name) +_ASM_NOKPROBE(xen_\name) +.endm + +xen_pv_trap asm_exc_divide_error +xen_pv_trap asm_xenpv_exc_debug +xen_pv_trap asm_exc_int3 +xen_pv_trap asm_xenpv_exc_nmi +xen_pv_trap asm_exc_overflow +xen_pv_trap asm_exc_bounds +xen_pv_trap asm_exc_invalid_op +xen_pv_trap asm_exc_device_not_available +xen_pv_trap asm_exc_double_fault +xen_pv_trap asm_exc_coproc_segment_overrun +xen_pv_trap asm_exc_invalid_tss +xen_pv_trap asm_exc_segment_not_present +xen_pv_trap asm_exc_stack_segment +xen_pv_trap asm_exc_general_protection +xen_pv_trap asm_exc_page_fault +xen_pv_trap asm_exc_spurious_interrupt_bug +xen_pv_trap asm_exc_coprocessor_error +xen_pv_trap asm_exc_alignment_check +#ifdef CONFIG_X86_MCE +xen_pv_trap asm_exc_machine_check +#endif /* CONFIG_X86_MCE */ +xen_pv_trap asm_exc_simd_coprocessor_error +#ifdef CONFIG_IA32_EMULATION +xen_pv_trap entry_INT80_compat +#endif +xen_pv_trap asm_exc_xen_hypervisor_callback + + __INIT +SYM_CODE_START(xen_early_idt_handler_array) + i = 0 + .rept NUM_EXCEPTION_VECTORS + pop %rcx + pop %r11 + jmp early_idt_handler_array + i*EARLY_IDT_HANDLER_SIZE + i = i + 1 + .fill xen_early_idt_handler_array + i*XEN_EARLY_IDT_HANDLER_SIZE - ., 1, 0xcc + .endr +SYM_CODE_END(xen_early_idt_handler_array) + __FINIT + +hypercall_iret = hypercall_page + __HYPERVISOR_iret * 32 +/* + * Xen64 iret frame: + * + * ss + * rsp + * rflags + * cs + * rip <-- standard iret frame + * + * flags + * + * rcx } + * r11 }<-- pushed by hypercall page + * rsp->rax } + */ +SYM_CODE_START(xen_iret) + pushq $0 + jmp hypercall_iret +SYM_CODE_END(xen_iret) + +SYM_CODE_START(xen_sysret64) + /* + * We're already on the usermode stack at this point, but + * still with the kernel gs, so we can easily switch back. + * + * tss.sp2 is scratch space. + */ + movq %rsp, PER_CPU_VAR(cpu_tss_rw + TSS_sp2) + movq PER_CPU_VAR(cpu_current_top_of_stack), %rsp + + pushq $__USER_DS + pushq PER_CPU_VAR(cpu_tss_rw + TSS_sp2) + pushq %r11 + pushq $__USER_CS + pushq %rcx + + pushq $VGCF_in_syscall + jmp hypercall_iret +SYM_CODE_END(xen_sysret64) + +/* + * Xen handles syscall callbacks much like ordinary exceptions, which + * means we have: + * - kernel gs + * - kernel rsp + * - an iret-like stack frame on the stack (including rcx and r11): + * ss + * rsp + * rflags + * cs + * rip + * r11 + * rsp->rcx + */ + +/* Normal 64-bit system call target */ +SYM_FUNC_START(xen_syscall_target) + popq %rcx + popq %r11 + + /* + * Neither Xen nor the kernel really knows what the old SS and + * CS were. The kernel expects __USER_DS and __USER_CS, so + * report those values even though Xen will guess its own values. + */ + movq $__USER_DS, 4*8(%rsp) + movq $__USER_CS, 1*8(%rsp) + + jmp entry_SYSCALL_64_after_hwframe +SYM_FUNC_END(xen_syscall_target) + +#ifdef CONFIG_IA32_EMULATION + +/* 32-bit compat syscall target */ +SYM_FUNC_START(xen_syscall32_target) + popq %rcx + popq %r11 + + /* + * Neither Xen nor the kernel really knows what the old SS and + * CS were. The kernel expects __USER32_DS and __USER32_CS, so + * report those values even though Xen will guess its own values. + */ + movq $__USER32_DS, 4*8(%rsp) + movq $__USER32_CS, 1*8(%rsp) + + jmp entry_SYSCALL_compat_after_hwframe +SYM_FUNC_END(xen_syscall32_target) + +/* 32-bit compat sysenter target */ +SYM_FUNC_START(xen_sysenter_target) + /* + * NB: Xen is polite and clears TF from EFLAGS for us. This means + * that we don't need to guard against single step exceptions here. + */ + popq %rcx + popq %r11 + + /* + * Neither Xen nor the kernel really knows what the old SS and + * CS were. The kernel expects __USER32_DS and __USER32_CS, so + * report those values even though Xen will guess its own values. + */ + movq $__USER32_DS, 4*8(%rsp) + movq $__USER32_CS, 1*8(%rsp) + + jmp entry_SYSENTER_compat_after_hwframe +SYM_FUNC_END(xen_sysenter_target) + +#else /* !CONFIG_IA32_EMULATION */ + +SYM_FUNC_START_ALIAS(xen_syscall32_target) +SYM_FUNC_START(xen_sysenter_target) + lea 16(%rsp), %rsp /* strip %rcx, %r11 */ + mov $-ENOSYS, %rax + pushq $0 + jmp hypercall_iret +SYM_FUNC_END(xen_sysenter_target) +SYM_FUNC_END_ALIAS(xen_syscall32_target) + +#endif /* CONFIG_IA32_EMULATION */ diff --git a/arch/x86/xen/xen-asm_64.S b/arch/x86/xen/xen-asm_64.S deleted file mode 100644 index aab1d99b2b48..000000000000 --- a/arch/x86/xen/xen-asm_64.S +++ /dev/null @@ -1,192 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0 */ -/* - * Asm versions of Xen pv-ops, suitable for direct use. - * - * We only bother with direct forms (ie, vcpu in pda) of the - * operations here; the indirect forms are better handled in C. - */ - -#include -#include -#include -#include -#include -#include -#include - -#include - -#include -#include - -.macro xen_pv_trap name -SYM_CODE_START(xen_\name) - pop %rcx - pop %r11 - jmp \name -SYM_CODE_END(xen_\name) -_ASM_NOKPROBE(xen_\name) -.endm - -xen_pv_trap asm_exc_divide_error -xen_pv_trap asm_xenpv_exc_debug -xen_pv_trap asm_exc_int3 -xen_pv_trap asm_xenpv_exc_nmi -xen_pv_trap asm_exc_overflow -xen_pv_trap asm_exc_bounds -xen_pv_trap asm_exc_invalid_op -xen_pv_trap asm_exc_device_not_available -xen_pv_trap asm_exc_double_fault -xen_pv_trap asm_exc_coproc_segment_overrun -xen_pv_trap asm_exc_invalid_tss -xen_pv_trap asm_exc_segment_not_present -xen_pv_trap asm_exc_stack_segment -xen_pv_trap asm_exc_general_protection -xen_pv_trap asm_exc_page_fault -xen_pv_trap asm_exc_spurious_interrupt_bug -xen_pv_trap asm_exc_coprocessor_error -xen_pv_trap asm_exc_alignment_check -#ifdef CONFIG_X86_MCE -xen_pv_trap asm_exc_machine_check -#endif /* CONFIG_X86_MCE */ -xen_pv_trap asm_exc_simd_coprocessor_error -#ifdef CONFIG_IA32_EMULATION -xen_pv_trap entry_INT80_compat -#endif -xen_pv_trap asm_exc_xen_hypervisor_callback - - __INIT -SYM_CODE_START(xen_early_idt_handler_array) - i = 0 - .rept NUM_EXCEPTION_VECTORS - pop %rcx - pop %r11 - jmp early_idt_handler_array + i*EARLY_IDT_HANDLER_SIZE - i = i + 1 - .fill xen_early_idt_handler_array + i*XEN_EARLY_IDT_HANDLER_SIZE - ., 1, 0xcc - .endr -SYM_CODE_END(xen_early_idt_handler_array) - __FINIT - -hypercall_iret = hypercall_page + __HYPERVISOR_iret * 32 -/* - * Xen64 iret frame: - * - * ss - * rsp - * rflags - * cs - * rip <-- standard iret frame - * - * flags - * - * rcx } - * r11 }<-- pushed by hypercall page - * rsp->rax } - */ -SYM_CODE_START(xen_iret) - pushq $0 - jmp hypercall_iret -SYM_CODE_END(xen_iret) - -SYM_CODE_START(xen_sysret64) - /* - * We're already on the usermode stack at this point, but - * still with the kernel gs, so we can easily switch back. - * - * tss.sp2 is scratch space. - */ - movq %rsp, PER_CPU_VAR(cpu_tss_rw + TSS_sp2) - movq PER_CPU_VAR(cpu_current_top_of_stack), %rsp - - pushq $__USER_DS - pushq PER_CPU_VAR(cpu_tss_rw + TSS_sp2) - pushq %r11 - pushq $__USER_CS - pushq %rcx - - pushq $VGCF_in_syscall - jmp hypercall_iret -SYM_CODE_END(xen_sysret64) - -/* - * Xen handles syscall callbacks much like ordinary exceptions, which - * means we have: - * - kernel gs - * - kernel rsp - * - an iret-like stack frame on the stack (including rcx and r11): - * ss - * rsp - * rflags - * cs - * rip - * r11 - * rsp->rcx - */ - -/* Normal 64-bit system call target */ -SYM_FUNC_START(xen_syscall_target) - popq %rcx - popq %r11 - - /* - * Neither Xen nor the kernel really knows what the old SS and - * CS were. The kernel expects __USER_DS and __USER_CS, so - * report those values even though Xen will guess its own values. - */ - movq $__USER_DS, 4*8(%rsp) - movq $__USER_CS, 1*8(%rsp) - - jmp entry_SYSCALL_64_after_hwframe -SYM_FUNC_END(xen_syscall_target) - -#ifdef CONFIG_IA32_EMULATION - -/* 32-bit compat syscall target */ -SYM_FUNC_START(xen_syscall32_target) - popq %rcx - popq %r11 - - /* - * Neither Xen nor the kernel really knows what the old SS and - * CS were. The kernel expects __USER32_DS and __USER32_CS, so - * report those values even though Xen will guess its own values. - */ - movq $__USER32_DS, 4*8(%rsp) - movq $__USER32_CS, 1*8(%rsp) - - jmp entry_SYSCALL_compat_after_hwframe -SYM_FUNC_END(xen_syscall32_target) - -/* 32-bit compat sysenter target */ -SYM_FUNC_START(xen_sysenter_target) - /* - * NB: Xen is polite and clears TF from EFLAGS for us. This means - * that we don't need to guard against single step exceptions here. - */ - popq %rcx - popq %r11 - - /* - * Neither Xen nor the kernel really knows what the old SS and - * CS were. The kernel expects __USER32_DS and __USER32_CS, so - * report those values even though Xen will guess its own values. - */ - movq $__USER32_DS, 4*8(%rsp) - movq $__USER32_CS, 1*8(%rsp) - - jmp entry_SYSENTER_compat_after_hwframe -SYM_FUNC_END(xen_sysenter_target) - -#else /* !CONFIG_IA32_EMULATION */ - -SYM_FUNC_START_ALIAS(xen_syscall32_target) -SYM_FUNC_START(xen_sysenter_target) - lea 16(%rsp), %rsp /* strip %rcx, %r11 */ - mov $-ENOSYS, %rax - pushq $0 - jmp hypercall_iret -SYM_FUNC_END(xen_sysenter_target) -SYM_FUNC_END_ALIAS(xen_syscall32_target) - -#endif /* CONFIG_IA32_EMULATION */ -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Fri Aug 07 08:38:49 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 08:38:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xtp-00071Y-IG; Fri, 07 Aug 2020 08:38:49 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xto-0006sR-Au for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 08:38:48 +0000 X-Inumbo-ID: 331e9460-27c0-4fb0-8f24-18b1601f04f5 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 331e9460-27c0-4fb0-8f24-18b1601f04f5; Fri, 07 Aug 2020 08:38:33 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8FC3DB644; Fri, 7 Aug 2020 08:38:50 +0000 (UTC) From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 6/7] x86/paravirt: use CONFIG_PARAVIRT_XXL instead of CONFIG_PARAVIRT Date: Fri, 7 Aug 2020 10:38:25 +0200 Message-Id: <20200807083826.16794-7-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200807083826.16794-1-jgross@suse.com> References: <20200807083826.16794-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Ingo Molnar , Borislav Petkov , Andy Lutomirski , "H. Peter Anvin" , Thomas Gleixner Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" There are some code parts using CONFIG_PARAVIRT for Xen pvops related issues instead of the more stringent CONFIG_PARAVIRT_XXL. Signed-off-by: Juergen Gross --- arch/x86/entry/entry_64.S | 4 ++-- arch/x86/include/asm/fixmap.h | 2 +- arch/x86/include/asm/required-features.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S index 70dea9337816..26fc9b42fadc 100644 --- a/arch/x86/entry/entry_64.S +++ b/arch/x86/entry/entry_64.S @@ -46,13 +46,13 @@ .code64 .section .entry.text, "ax" -#ifdef CONFIG_PARAVIRT +#ifdef CONFIG_PARAVIRT_XXL SYM_CODE_START(native_usergs_sysret64) UNWIND_HINT_EMPTY swapgs sysretq SYM_CODE_END(native_usergs_sysret64) -#endif /* CONFIG_PARAVIRT */ +#endif /* CONFIG_PARAVIRT_XXL */ /* * 64-bit SYSCALL instruction entry. Up to 6 arguments in registers. diff --git a/arch/x86/include/asm/fixmap.h b/arch/x86/include/asm/fixmap.h index b9527a54db99..f1422ada4ffe 100644 --- a/arch/x86/include/asm/fixmap.h +++ b/arch/x86/include/asm/fixmap.h @@ -99,7 +99,7 @@ enum fixed_addresses { FIX_PCIE_MCFG, #endif #endif -#ifdef CONFIG_PARAVIRT +#ifdef CONFIG_PARAVIRT_XXL FIX_PARAVIRT_BOOTMAP, #endif #ifdef CONFIG_X86_INTEL_MID diff --git a/arch/x86/include/asm/required-features.h b/arch/x86/include/asm/required-features.h index 6847d85400a8..3ff0d48469f2 100644 --- a/arch/x86/include/asm/required-features.h +++ b/arch/x86/include/asm/required-features.h @@ -54,7 +54,7 @@ #endif #ifdef CONFIG_X86_64 -#ifdef CONFIG_PARAVIRT +#ifdef CONFIG_PARAVIRT_XXL /* Paravirtualized systems may not have PSE or PGE available */ #define NEED_PSE 0 #define NEED_PGE 0 -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Fri Aug 07 08:38:54 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 08:38:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xtu-00074J-Sj; Fri, 07 Aug 2020 08:38:54 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xtt-0006sR-B6 for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 08:38:53 +0000 X-Inumbo-ID: 87eccea8-7006-4d6d-a4ef-eb3a486a0b6e Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 87eccea8-7006-4d6d-a4ef-eb3a486a0b6e; Fri, 07 Aug 2020 08:38:33 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C33E3B645; Fri, 7 Aug 2020 08:38:50 +0000 (UTC) From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 7/7] x86/entry/32: revert "Fix XEN_PV build dependency" Date: Fri, 7 Aug 2020 10:38:26 +0200 Message-Id: <20200807083826.16794-8-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200807083826.16794-1-jgross@suse.com> References: <20200807083826.16794-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" With 32-bit Xen PV support gone commit a4c0e91d1d65bc58 ("x86/entry/32: Fix XEN_PV build dependency") can be reverted again. Signed-off-by: Juergen Gross --- arch/x86/include/asm/idtentry.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/idtentry.h b/arch/x86/include/asm/idtentry.h index a43366191212..337dcfd45472 100644 --- a/arch/x86/include/asm/idtentry.h +++ b/arch/x86/include/asm/idtentry.h @@ -547,7 +547,7 @@ DECLARE_IDTENTRY_RAW(X86_TRAP_MC, exc_machine_check); /* NMI */ DECLARE_IDTENTRY_NMI(X86_TRAP_NMI, exc_nmi); -#if defined(CONFIG_XEN_PV) && defined(CONFIG_X86_64) +#ifdef CONFIG_XEN_PV DECLARE_IDTENTRY_RAW(X86_TRAP_NMI, xenpv_exc_nmi); #endif @@ -557,7 +557,7 @@ DECLARE_IDTENTRY_DEBUG(X86_TRAP_DB, exc_debug); #else DECLARE_IDTENTRY_RAW(X86_TRAP_DB, exc_debug); #endif -#if defined(CONFIG_XEN_PV) && defined(CONFIG_X86_64) +#ifdef CONFIG_XEN_PV DECLARE_IDTENTRY_RAW(X86_TRAP_DB, xenpv_exc_debug); #endif -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Fri Aug 07 08:39:00 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 08:39:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xu0-00077g-5w; Fri, 07 Aug 2020 08:39:00 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xty-0006sR-BQ for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 08:38:58 +0000 X-Inumbo-ID: 11b9c77f-e984-414a-94f3-f0c4c07f335e Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 11b9c77f-e984-414a-94f3-f0c4c07f335e; Fri, 07 Aug 2020 08:38:33 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4FE19B643; Fri, 7 Aug 2020 08:38:50 +0000 (UTC) From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 5/7] x86/paravirt: cleanup paravirt macros Date: Fri, 7 Aug 2020 10:38:24 +0200 Message-Id: <20200807083826.16794-6-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200807083826.16794-1-jgross@suse.com> References: <20200807083826.16794-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Deep Shah , "VMware, Inc." , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Thomas Gleixner Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Some paravirt macros are no longer used, delete them. Signed-off-by: Juergen Gross --- arch/x86/include/asm/paravirt.h | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h index dedc89a07826..99da08852df0 100644 --- a/arch/x86/include/asm/paravirt.h +++ b/arch/x86/include/asm/paravirt.h @@ -614,16 +614,9 @@ bool __raw_callee_save___native_vcpu_is_preempted(long cpu); #endif /* SMP && PARAVIRT_SPINLOCKS */ #ifdef CONFIG_X86_32 -#define PV_SAVE_REGS "pushl %ecx; pushl %edx;" -#define PV_RESTORE_REGS "popl %edx; popl %ecx;" - /* save and restore all caller-save registers, except return value */ #define PV_SAVE_ALL_CALLER_REGS "pushl %ecx;" #define PV_RESTORE_ALL_CALLER_REGS "popl %ecx;" - -#define PV_FLAGS_ARG "0" -#define PV_EXTRA_CLOBBERS -#define PV_VEXTRA_CLOBBERS #else /* save and restore all caller-save registers, except return value */ #define PV_SAVE_ALL_CALLER_REGS \ @@ -644,14 +637,6 @@ bool __raw_callee_save___native_vcpu_is_preempted(long cpu); "pop %rsi;" \ "pop %rdx;" \ "pop %rcx;" - -/* We save some registers, but all of them, that's too much. We clobber all - * caller saved registers but the argument parameter */ -#define PV_SAVE_REGS "pushq %%rdi;" -#define PV_RESTORE_REGS "popq %%rdi;" -#define PV_EXTRA_CLOBBERS EXTRA_CLOBBERS, "rcx" , "rdx", "rsi" -#define PV_VEXTRA_CLOBBERS EXTRA_CLOBBERS, "rdi", "rcx" , "rdx", "rsi" -#define PV_FLAGS_ARG "D" #endif /* -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Fri Aug 07 08:43:26 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 08:43:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xyC-0008QV-P6; Fri, 07 Aug 2020 08:43:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3xyC-0008QQ-6R for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 08:43:20 +0000 X-Inumbo-ID: d9c2f7ba-b568-4422-b808-b36b29076757 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d9c2f7ba-b568-4422-b808-b36b29076757; Fri, 07 Aug 2020 08:43:19 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 151F0B649; Fri, 7 Aug 2020 08:43:36 +0000 (UTC) Subject: Re: [RFC PATCH V1 05/12] hvm/dm: Introduce xendevicemodel_set_irq_level DM op To: Stefano Stabellini References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-6-git-send-email-olekstysh@gmail.com> <00e261e0-295a-9cd8-ed11-7e3801a4eb58@xen.org> <92e2b136-8468-2877-0e8c-c13ff2a0a1fb@xen.org> From: Jan Beulich Message-ID: Date: Fri, 7 Aug 2020 10:43:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Julien Grall , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Oleksandr Tyshchenko , Julien Grall , xen-devel@lists.xenproject.org, Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 07.08.2020 01:49, Stefano Stabellini wrote: > On Thu, 6 Aug 2020, Julien Grall wrote: >> On 06/08/2020 01:37, Stefano Stabellini wrote: >>> On Wed, 5 Aug 2020, Julien Grall wrote: >>>> On 05/08/2020 00:22, Stefano Stabellini wrote: >>>>> On Mon, 3 Aug 2020, Oleksandr Tyshchenko wrote: >>>>>> From: Oleksandr Tyshchenko >>>>>> >>>>>> This patch adds ability to the device emulator to notify otherend >>>>>> (some entity running in the guest) using a SPI and implements Arm >>>>>> specific bits for it. Proposed interface allows emulator to set >>>>>> the logical level of a one of a domain's IRQ lines. >>>>>> >>>>>> Please note, this is a split/cleanup of Julien's PoC: >>>>>> "Add support for Guest IO forwarding to a device emulator" >>>>>> >>>>>> Signed-off-by: Julien Grall >>>>>> Signed-off-by: Oleksandr Tyshchenko >>>>>> --- >>>>>> tools/libs/devicemodel/core.c | 18 >>>>>> ++++++++++++++++++ >>>>>> tools/libs/devicemodel/include/xendevicemodel.h | 4 ++++ >>>>>> tools/libs/devicemodel/libxendevicemodel.map | 1 + >>>>>> xen/arch/arm/dm.c | 22 >>>>>> +++++++++++++++++++++- >>>>>> xen/common/hvm/dm.c | 1 + >>>>>> xen/include/public/hvm/dm_op.h | 15 >>>>>> +++++++++++++++ >>>>>> 6 files changed, 60 insertions(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/tools/libs/devicemodel/core.c >>>>>> b/tools/libs/devicemodel/core.c >>>>>> index 4d40639..30bd79f 100644 >>>>>> --- a/tools/libs/devicemodel/core.c >>>>>> +++ b/tools/libs/devicemodel/core.c >>>>>> @@ -430,6 +430,24 @@ int xendevicemodel_set_isa_irq_level( >>>>>> return xendevicemodel_op(dmod, domid, 1, &op, sizeof(op)); >>>>>> } >>>>>> +int xendevicemodel_set_irq_level( >>>>>> + xendevicemodel_handle *dmod, domid_t domid, uint32_t irq, >>>>>> + unsigned int level) >>>>> >>>>> It is a pity that having xen_dm_op_set_pci_intx_level and >>>>> xen_dm_op_set_isa_irq_level already we need to add a third one, but from >>>>> the names alone I don't think we can reuse either of them. >>>> >>>> The problem is not the name... >>>> >>>>> >>>>> It is very similar to set_isa_irq_level. We could almost rename >>>>> xendevicemodel_set_isa_irq_level to xendevicemodel_set_irq_level or, >>>>> better, just add an alias to it so that xendevicemodel_set_irq_level is >>>>> implemented by calling xendevicemodel_set_isa_irq_level. Honestly I am >>>>> not sure if it is worth doing it though. Any other opinions? >>>> >>>> ... the problem is the interrupt field is only 8-bit. So we would only be >>>> able >>>> to cover IRQ 0 - 255. >>> >>> Argh, that's not going to work :-( I wasn't sure if it was a good idea >>> anyway. >>> >>> >>>> It is not entirely clear how the existing subop could be extended without >>>> breaking existing callers. >>>> >>>>> But I think we should plan for not needing two calls (one to set level >>>>> to 1, and one to set it to 0): >>>>> https://marc.info/?l=xen-devel&m=159535112027405 >>>> >>>> I am not sure to understand your suggestion here? Are you suggesting to >>>> remove >>>> the 'level' parameter? >>> >>> My hope was to make it optional to call the hypercall with level = 0, >>> not necessarily to remove 'level' from the struct. >> >> From my understanding, the hypercall is meant to represent the status of the >> line between the device and the interrupt controller (either low or high). >> >> This is then up to the interrupt controller to decide when the interrupt is >> going to be fired: >> - For edge interrupt, this will fire when the line move from low to high (or >> vice versa). >> - For level interrupt, this will fire when line is high (assuming level >> trigger high) and will keeping firing until the device decided to lower the >> line. >> >> For a device, it is common to keep the line high until an OS wrote to a >> specific register. >> >> Furthermore, technically, the guest OS is in charge to configure how an >> interrupt is triggered. Admittely this information is part of the DT, but >> nothing prevent a guest to change it. >> >> As side note, we have a workaround in Xen for some buggy DT (see the arch >> timer) exposing the wrong trigger type. >> >> Because of that, I don't really see a way to make optional. Maybe you have >> something different in mind? > > For level, we need the level parameter. For edge, we are only interested > in the "edge", right? I don't think so, unless Arm has special restrictions. Edges can be both rising and falling ones. Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 07 08:48:58 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 08:48:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3y3W-0000C1-IG; Fri, 07 Aug 2020 08:48:50 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3y3V-0000Bw-2r for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 08:48:49 +0000 X-Inumbo-ID: 61de6ee3-d85a-4ed9-999f-77ac46da74c3 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 61de6ee3-d85a-4ed9-999f-77ac46da74c3; Fri, 07 Aug 2020 08:48:48 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 558C2AF06; Fri, 7 Aug 2020 08:49:05 +0000 (UTC) Subject: Re: [PATCH 00/14] kernel-doc: public/arch-arm.h To: Stefano Stabellini References: From: Jan Beulich Message-ID: <7923d0f4-a446-c852-5423-0fe65ef27a41@suse.com> Date: Fri, 7 Aug 2020 10:48:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: julien@xen.org, wl@xen.org, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com, xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 07.08.2020 01:49, Stefano Stabellini wrote: > # THE KERNEL-DOC KEYWORDS USED > > I used the "struct" keyword for structures, i.e.: > > /** > * struct foobar > */ > > "struct" makes kernel-doc go and look at the following struct in the > code, parses struct members comments, and generate a doc optimized to > describe a struct. Note that in these cases the struct needs to follow > immediately the comment. Thus, I had to move an #define between the > comment and the struct in a few places. > > Also note that kernel-doc supports nested structs but due to a quirk, > comments for nested struct members cannot be on a single line. They have > to be: > > struct foo { > struct { > /** > * @u.bar: foobar > */ > bar; > } u; > } Urgh. > Otherwise for normal struct the single line comment works fine: > > struct foo { > /** @bar: foobar */ > bar; > } > > > I used the "DOC" keyword otherwise. "DOC" is freeform, not particularly > tied to anything following (functions, enums, etc.) I kept a black line > between "DOC" and the following comment if multiline and no blank line > if it is single line. > > /** > * DOC: doc1 > * single line comment > */ > > /** > * DOC: doc2 > * > * this is > * multiline > */ I think before the first piece of this goes in (or together with it going in), ./CODING_STYLE wants to be updated to reflect this. It is particularly relevant imo to mention the quirk above and hence the necessary exception (even better of course would be to get the quirk out of kernel-doc). Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 07 09:00:17 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 09:00:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3yEU-0001oj-MC; Fri, 07 Aug 2020 09:00:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3yET-0001oe-09 for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 09:00:09 +0000 X-Inumbo-ID: 65eaaea1-c3c9-4d95-ba4f-f9e50b9ed558 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 65eaaea1-c3c9-4d95-ba4f-f9e50b9ed558; Fri, 07 Aug 2020 09:00:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=s51XE3ddaoYXVBREoTTdiJ84Ux9ukeDufU0lMiwEsns=; b=hvVofteG/JPFR9mScBcE/5hYA zcjDN36c4qOonoh4eZEe5T9BL5hTZntNN4K98kH0lOdjd/RoaW9RJ0JAbgF6qB8JDidDlFkIKZJO0 aRdy32pjWGFYzTtHt4aQrcPHMB9FmRPimC7I0DHR5ljrALMAmWgXpIO8JDZ50xypmp16A=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3yEQ-0003PX-Uy; Fri, 07 Aug 2020 09:00:06 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k3yEQ-0006rt-JN; Fri, 07 Aug 2020 09:00:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k3yEQ-0004fi-Ip; Fri, 07 Aug 2020 09:00:06 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 152504: all pass - PUSHED X-Osstest-Versions-This: ovmf=8834e10b30125daa47da9f6c5c1a41b4eafbae7f X-Osstest-Versions-That: ovmf=e188ecc8b4aed8fdd26b731d43883861f5e5e7b4 From: osstest service owner Date: Fri, 07 Aug 2020 09:00:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152504 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/152504/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 8834e10b30125daa47da9f6c5c1a41b4eafbae7f baseline version: ovmf e188ecc8b4aed8fdd26b731d43883861f5e5e7b4 Last test of basis 152495 2020-08-05 17:41:20 Z 1 days Testing same since 152504 2020-08-06 12:15:14 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Peter Grehan Rebecca Cran jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git e188ecc8b4..8834e10b30 8834e10b30125daa47da9f6c5c1a41b4eafbae7f -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Aug 07 09:34:21 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 09:34:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3ylB-0004Vw-G3; Fri, 07 Aug 2020 09:33:57 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3yl9-0004Vr-Bx for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 09:33:55 +0000 X-Inumbo-ID: cc44c402-c43c-493f-be3f-f049b9594f81 Received: from smtp.domeneshop.no (unknown [2a01:5b40:0:3005::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cc44c402-c43c-493f-be3f-f049b9594f81; Fri, 07 Aug 2020 09:33:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tronnes.org ; s=ds201912; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dhBn85DVkd9WiwzdeA0ZAk87Jr2Z06qRR9qaDjfK2Q0=; b=m+PWgSDl91eMGK8rvIUKM0yLbY BTtvVt7GHjbFDWuiAwCew1o4DpGo0X5EvPmAu5NoF3KVa/WrJcno0rE7yU1ZuLLtdori78nG3MTCt /b8lIQ2wjTrAa0IiTxbfflVOoB7ItTWH5BtnD5ca03DmpWO/VJDk2VuV869dshjYbkabO+gvNdp24 JWObB1zbNo/5PI0p3ZVDSwL/BO7R7V/6mJxK0CCdbPFRQbzPeg7iUN/yZAnyl20Pngs2xjN3NmTPy zdQzdFT7BoYqEc5G2bz0PhPFH2d51HiC/khBGUEla9ZiuFb88uEbH9k/urcGwnv8sV65Q7rLD6Dvg 5yexQLUA==; Received: from 211.81-166-168.customer.lyse.net ([81.166.168.211]:52994 helo=[192.168.10.61]) by smtp.domeneshop.no with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k3yl5-0001BT-1d; Fri, 07 Aug 2020 11:33:51 +0200 Subject: Re: [PATCH 5/6] drm/xen-front: Pass dumb buffer data offset to the backend To: Oleksandr Andrushchenko , xen-devel@lists.xenproject.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, boris.ostrovsky@oracle.com, jgross@suse.com, airlied@linux.ie, daniel@ffwll.ch References: <20200731125109.18666-1-andr2000@gmail.com> <20200731125109.18666-6-andr2000@gmail.com> From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Message-ID: Date: Fri, 7 Aug 2020 11:33:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200731125109.18666-6-andr2000@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, sstabellini@kernel.org, dan.carpenter@oracle.com, Oleksandr Andrushchenko Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Den 31.07.2020 14.51, skrev Oleksandr Andrushchenko: > From: Oleksandr Andrushchenko > > While importing a dmabuf it is possible that the data of the buffer > is put with offset which is indicated by the SGT offset. > Respect the offset value and forward it to the backend. > > Signed-off-by: Oleksandr Andrushchenko > --- Acked-by: Noralf Trønnes From xen-devel-bounces@lists.xenproject.org Fri Aug 07 09:34:26 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 09:34:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3yle-0004X0-P7; Fri, 07 Aug 2020 09:34:26 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3yld-0004Ws-VD for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 09:34:25 +0000 X-Inumbo-ID: 337ec982-9bc0-4759-bae4-36d08e5a3d1d Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 337ec982-9bc0-4759-bae4-36d08e5a3d1d; Fri, 07 Aug 2020 09:34:23 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DFC0FAC55; Fri, 7 Aug 2020 09:34:40 +0000 (UTC) Subject: Re: [PATCH 1/3] x86: slightly re-arrange 32-bit handling in dom0_construct_pv() To: Andrew Cooper References: <0972ea3c-c2a8-b0f4-ae25-132bdb798f6a@suse.com> <0217c386-e93e-2f07-f2ac-9e683c14541a@citrix.com> From: Jan Beulich Message-ID: Date: Fri, 7 Aug 2020 11:34:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <0217c386-e93e-2f07-f2ac-9e683c14541a@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 06.08.2020 16:04, Andrew Cooper wrote: > On 06/08/2020 10:28, Jan Beulich wrote: >> Add #ifdef-s (the 2nd one will be needed in particular, to guard the >> uses of m2p_compat_vstart and HYPERVISOR_COMPAT_VIRT_START()) and fold >> duplicate uses of elf_32bit(). >> >> Also adjust what gets logged: Avoid "compat32" when support isn't built >> in, and don't assume ELF class <> ELFCLASS64 means ELFCLASS32. >> >> Signed-off-by: Jan Beulich > > Acked-by: Andrew Cooper although with some > further suggestions. Thanks. >> @@ -357,27 +356,36 @@ int __init dom0_construct_pv(struct doma >> goto out; >> >> /* compatibility check */ >> + printk(" Xen kernel: 64-bit, lsb%s\n", >> + IS_ENABLED(CONFIG_PV32) ? ", compat32" : ""); > > Here, and below, we print out lsb/msb for the ELF file.  However, we > don't use or check that it is actually lsb, and blindly assume that it is. > > Why bother printing it then? To be honest, I'd rather add a check than drop the printing. However unlikely it may be to encounter an MSB ELF binary ... This particular one I'd like to do in a separate, follow-on patch though. I've addressed the other comments in what I intend to commit. Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 07 09:35:31 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 09:35:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3ymh-0004dS-2q; Fri, 07 Aug 2020 09:35:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3ymf-0004dK-Q9 for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 09:35:29 +0000 X-Inumbo-ID: c2be4be2-fcba-4cd0-b29e-78fb660b8eb5 Received: from smtp.domeneshop.no (unknown [2a01:5b40:0:3005::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c2be4be2-fcba-4cd0-b29e-78fb660b8eb5; Fri, 07 Aug 2020 09:35:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tronnes.org ; s=ds201912; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gGIwDhOjA1LUWyVCPaxr0QUqfVFuaQ2aeOuDTG1FAG0=; b=MslSwSkr01gt37As8fjtp3c4L+ 6xxPqtPSL4bh0HaSr22/l0EGjObkF7Y1b2yd2VrnO1qxWjAao21ToRnsob2Q5HbRxmUk+K7ktL12e fWSA93OWvOje0tkgZmr2nk07ub+RYndaYdyv+soRH/pget70PhJuqhr+rN+PgY2iCwHGJtCohnlZg v4TLPW1TL7Ywcwt3k72wJq6XiXclEFTwFNgw7x4GdYH1v54sHHX+/uCERdnN1lRTARFnk8sUiEwEi Uit4ZbeeL+I0RrTXQKS5ObwCFH0AHHQtFg6tWAe7QKe14ZsFxgXUV+ABxCRIBtndf2CBx3IADZFgB HQotCxuQ==; Received: from 211.81-166-168.customer.lyse.net ([81.166.168.211]:53009 helo=[192.168.10.61]) by smtp.domeneshop.no with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k3ymc-0001ze-4F; Fri, 07 Aug 2020 11:35:26 +0200 Subject: Re: [PATCH 3/6] drm/xen-front: Add YUYV to supported formats To: Oleksandr Andrushchenko , xen-devel@lists.xenproject.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, boris.ostrovsky@oracle.com, jgross@suse.com, airlied@linux.ie, daniel@ffwll.ch References: <20200731125109.18666-1-andr2000@gmail.com> <20200731125109.18666-4-andr2000@gmail.com> From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Message-ID: Date: Fri, 7 Aug 2020 11:35:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200731125109.18666-4-andr2000@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, sstabellini@kernel.org, dan.carpenter@oracle.com, Oleksandr Andrushchenko Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Den 31.07.2020 14.51, skrev Oleksandr Andrushchenko: > From: Oleksandr Andrushchenko > > Add YUYV to supported formats, so the frontend can work with the > formats used by cameras and other HW. > > Signed-off-by: Oleksandr Andrushchenko > --- Acked-by: Noralf Trønnes From xen-devel-bounces@lists.xenproject.org Fri Aug 07 09:39:41 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 09:39:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3yqf-0004rh-LR; Fri, 07 Aug 2020 09:39:37 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3yqd-0004rb-N8 for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 09:39:36 +0000 X-Inumbo-ID: 49a9cbc8-18f4-4e9a-b419-191b9776df99 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 49a9cbc8-18f4-4e9a-b419-191b9776df99; Fri, 07 Aug 2020 09:39:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+m1NmxTmerVA7hYyNCbbSvji27rWMrnyKtnC8SpXeuw=; b=qlCBun+hYZ3NXDb+jynUBPF5jC h9Q8p+P3btJMKnRDYbi2BAa/sQ74mPob6WiFPQE7IgnqvAvjrylnmYcrWJF9imSnSE5vuAFnJW6mc /y/aeZjjYDdFSGbNOSq2ne5dZoxfVeJSJGt1evL6K7pnXkBi+cEGjvymLKMqvmrbfThHYTlmX1cKW Io2IvfmaI+W/P6SHIXiDMP87UdS6e+JDN+LOCBA1KZFBQ34DxczGekQV+vaYBzHAOYqOYYkcnRbly B7oGexBlDV3M4ABknh2jvnraRpH0zOmNsZphbhXmzYDft4HfoPllAJsfVSOHfTQFQbje2Cz2bPhXY Zk297Ehw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3yqO-0001GI-HQ; Fri, 07 Aug 2020 09:39:24 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id AC842300446; Fri, 7 Aug 2020 11:39:16 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 8E2DC23EA04DA; Fri, 7 Aug 2020 11:39:16 +0200 (CEST) Date: Fri, 7 Aug 2020 11:39:16 +0200 From: peterz@infradead.org To: Juergen Gross Subject: Re: [PATCH v3 4/7] x86/paravirt: remove 32-bit support from PARAVIRT_XXL Message-ID: <20200807093916.GF2674@hirez.programming.kicks-ass.net> References: <20200807083826.16794-1-jgross@suse.com> <20200807083826.16794-5-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200807083826.16794-5-jgross@suse.com> X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Deep Shah , "VMware, Inc." , x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Ingo Molnar , Borislav Petkov , Andy Lutomirski , "H. Peter Anvin" , xen-devel@lists.xenproject.org, Thomas Gleixner , Boris Ostrovsky Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Fri, Aug 07, 2020 at 10:38:23AM +0200, Juergen Gross wrote: > -# else > - const unsigned char cpu_iret[1]; > -# endif > }; > > static const struct patch_xxl patch_data_xxl = { > @@ -42,7 +38,6 @@ static const struct patch_xxl patch_data_xxl = { > .irq_save_fl = { 0x9c, 0x58 }, // pushf; pop %[re]ax > .mmu_read_cr2 = { 0x0f, 0x20, 0xd0 }, // mov %cr2, %[re]ax > .mmu_read_cr3 = { 0x0f, 0x20, 0xd8 }, // mov %cr3, %[re]ax > -# ifdef CONFIG_X86_64 > .mmu_write_cr3 = { 0x0f, 0x22, 0xdf }, // mov %rdi, %cr3 > .irq_restore_fl = { 0x57, 0x9d }, // push %rdi; popfq > .cpu_wbinvd = { 0x0f, 0x09 }, // wbinvd > @@ -50,19 +45,11 @@ static const struct patch_xxl patch_data_xxl = { > 0x48, 0x0f, 0x07 }, // swapgs; sysretq > .cpu_swapgs = { 0x0f, 0x01, 0xf8 }, // swapgs > .mov64 = { 0x48, 0x89, 0xf8 }, // mov %rdi, %rax > -# else > - .mmu_write_cr3 = { 0x0f, 0x22, 0xd8 }, // mov %eax, %cr3 > - .irq_restore_fl = { 0x50, 0x9d }, // push %eax; popf > - .cpu_iret = { 0xcf }, // iret > -# endif I was looking at x86_64 paravirt the other day and found we actually have pv_ops.cpu.iret users there.. So we want to change the above to also patch iret on x86_64 or do we need to fix x86_64 to not have pv-iret? From xen-devel-bounces@lists.xenproject.org Fri Aug 07 10:03:16 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 10:03:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3zDL-0007Sb-My; Fri, 07 Aug 2020 10:03:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3zDJ-0007SW-On for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 10:03:01 +0000 X-Inumbo-ID: dd8b9c34-a845-4da0-8d4b-fb8092e5a0dd Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id dd8b9c34-a845-4da0-8d4b-fb8092e5a0dd; Fri, 07 Aug 2020 10:03:00 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DAF6FAB9F; Fri, 7 Aug 2020 10:03:17 +0000 (UTC) Subject: Re: [PATCH v3 4/7] x86/paravirt: remove 32-bit support from PARAVIRT_XXL To: peterz@infradead.org References: <20200807083826.16794-1-jgross@suse.com> <20200807083826.16794-5-jgross@suse.com> <20200807093916.GF2674@hirez.programming.kicks-ass.net> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <3a0712ee-efca-5684-d321-3b789e01fc16@suse.com> Date: Fri, 7 Aug 2020 12:02:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200807093916.GF2674@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Deep Shah , "VMware, Inc." , x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Ingo Molnar , Borislav Petkov , Andy Lutomirski , "H. Peter Anvin" , xen-devel@lists.xenproject.org, Thomas Gleixner , Boris Ostrovsky Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 07.08.20 11:39, peterz@infradead.org wrote: > On Fri, Aug 07, 2020 at 10:38:23AM +0200, Juergen Gross wrote: > >> -# else >> - const unsigned char cpu_iret[1]; >> -# endif >> }; >> >> static const struct patch_xxl patch_data_xxl = { >> @@ -42,7 +38,6 @@ static const struct patch_xxl patch_data_xxl = { >> .irq_save_fl = { 0x9c, 0x58 }, // pushf; pop %[re]ax >> .mmu_read_cr2 = { 0x0f, 0x20, 0xd0 }, // mov %cr2, %[re]ax >> .mmu_read_cr3 = { 0x0f, 0x20, 0xd8 }, // mov %cr3, %[re]ax >> -# ifdef CONFIG_X86_64 >> .mmu_write_cr3 = { 0x0f, 0x22, 0xdf }, // mov %rdi, %cr3 >> .irq_restore_fl = { 0x57, 0x9d }, // push %rdi; popfq >> .cpu_wbinvd = { 0x0f, 0x09 }, // wbinvd >> @@ -50,19 +45,11 @@ static const struct patch_xxl patch_data_xxl = { >> 0x48, 0x0f, 0x07 }, // swapgs; sysretq >> .cpu_swapgs = { 0x0f, 0x01, 0xf8 }, // swapgs >> .mov64 = { 0x48, 0x89, 0xf8 }, // mov %rdi, %rax >> -# else >> - .mmu_write_cr3 = { 0x0f, 0x22, 0xd8 }, // mov %eax, %cr3 >> - .irq_restore_fl = { 0x50, 0x9d }, // push %eax; popf >> - .cpu_iret = { 0xcf }, // iret >> -# endif > > I was looking at x86_64 paravirt the other day and found we actually > have pv_ops.cpu.iret users there.. On x86_64 we have (without PARAVIRT_XXL): #define INTERRUPT_RETURN jmp native_iret and with PARAVIRT_XXL this is basically a jmp *pv_ops.cpu.iret which will then be patched to either jmp native_iret or jmp xen_iret. On x86_32 INTERRUPT_RETURN was just "iret" for the non-paravirt case. This is the reason for above dropping of the static patch data. > So we want to change the above to also patch iret on x86_64 or do we > need to fix x86_64 to not have pv-iret? We want it to stay how it is. This will let both variants (PARVIRT y/n) continue to work. Juergen From xen-devel-bounces@lists.xenproject.org Fri Aug 07 10:12:50 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 10:12:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3zMj-0008Mr-Oa; Fri, 07 Aug 2020 10:12:45 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3zMi-0008Mm-OE for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 10:12:44 +0000 X-Inumbo-ID: 5932de4e-2086-451b-bdc7-589828b61b78 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5932de4e-2086-451b-bdc7-589828b61b78; Fri, 07 Aug 2020 10:12:43 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 85B8BB6A4; Fri, 7 Aug 2020 10:13:00 +0000 (UTC) Subject: Re: [PATCH 2/3] x86: don't maintain compat M2P when !PV32 To: Andrew Cooper References: <4575f42b-a347-b34e-0032-e04668106a9b@suse.com> <52b4f80f-9967-fae9-ce85-c69bf3b6e22d@citrix.com> From: Jan Beulich Message-ID: <9cf5d060-3fee-db3c-8455-e09da998594b@suse.com> Date: Fri, 7 Aug 2020 12:12:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <52b4f80f-9967-fae9-ce85-c69bf3b6e22d@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 06.08.2020 21:16, Andrew Cooper wrote: > On 06/08/2020 10:28, Jan Beulich wrote: >> Note that opt_pv32's declaration / #define need to be moved due to other >> header dependencies; in particular can asm-x86/mm.h not include >> asm-x86/pv/domain.h. >> >> While touching their definitions anyway, also adjust section placement >> of m2p_compat_vstart and compat_idle_pg_table_l2. Similarly, while >> putting init_xen_pae_l2_slots() inside #ifdef, also move it to a PV-only >> source file. >> >> Suggested-by: Andrew Cooper >> Signed-off-by: Jan Beulich > > So interestingly, this is done out of the order which I was expecting to > do things.  Its not a problem, but I'd like to double check that we > aren't creating future problems. I've thought about this for quite some time, and didn't see how it would cause problems. And the change here clearly is the more low hanging fruit. > The goal of this suggestion was actually for PV-Shim, to have only the > regular or compat M2P, as they're fairly large structures and adversely > affect VM density. But in particular for {INVALID,SHARED}_M2P_ENTRY there'll need to be some, well, hacks if we want to use the compat one as a replacement for the native one. This will require some more careful thought (at least on my side). > This of course requires the kernel elf file to be parsed earlier during > boot, but that isn't a problem.  (It also allows for a PV/PVH dom0 > usability fix, whereby the Xen command line has to match the ELF image > provided, rather than auto-selecting the default when only one option is > available.) Hmm, no, that's not my current plan, see the cover letter. I've already checked that there are no set_gpfn_from_mfn() uses (except with INVALID_M2P_ENTRY) ahead of Dom0 creation. So instead of moving the parsing earlier, I'm intending to move the setting up of the (right) M2P later. My current take on this is that it'll mainly involve breaking out existing code into its own functions. > The other aspect would be to teach Xen to run on only the compat M2P, > which is fine for any shim smaller than 16T.  (Honestly, if it weren't > an ABI with guests, Shim ought to run exclusively on the compat M2P to > reduce the memory overhead.) You've covered the shim aspect above, I thought, and the ABI aspect precludes not maintaining the native M2P when there's a 64-bit guest. So I'm not sure what you're trying to suggest here that we may be able to gain. > Then during boot, the Shim path would chose to construct only the > regular or compat M2P, based on bitness of the provided kernel. That's the plan, yes, but covered higher up. >> --- >> An alternative place for opt_pv32.h would seem to be asm-x86/config.h. > > Oh - yes please.  I think that would be better overall. Done. >> --- a/xen/arch/x86/domain.c >> +++ b/xen/arch/x86/domain.c >> @@ -597,8 +597,10 @@ int arch_domain_create(struct domain *d, >> } >> d->arch.emulation_flags = emflags; >> >> +#ifdef CONFIG_PV32 >> HYPERVISOR_COMPAT_VIRT_START(d) = >> is_pv_domain(d) ? __HYPERVISOR_COMPAT_VIRT_START : ~0u; >> +#endif > > Can we drop HYPERVISOR_COMPAT_VIRT_START() ? > > Its use here as an lvalue in particular makes logic especually hard to > follow, but all it is actually doing is wrapping the shorter > d->arch.hv_compat_vstart > > In particular, it would remove the need to conditionally stub > HYPERVISOR_COMPAT_VIRT_START() later. I can do this as a prereq patch, sure, but I'm not convinced as the avoiding of the stub will mean a few new #ifdef-s afaict. Please confirm that you're convinced this will yield the overall better result. >> --- a/xen/arch/x86/x86_64/mm.c >> +++ b/xen/arch/x86/x86_64/mm.c >> @@ -315,10 +318,10 @@ static void destroy_m2p_mapping(struct m >> */ >> static int setup_compat_m2p_table(struct mem_hotadd_info *info) >> { >> + int err = 0; >> unsigned long i, smap, emap, epfn = info->epfn; >> mfn_t mfn; >> unsigned int n; >> - int err = 0; > > Remnants of an earlier change? Oops. >> --- a/xen/include/asm-x86/mm.h >> +++ b/xen/include/asm-x86/mm.h >> @@ -42,8 +42,12 @@ >> #define _PGT_validated PG_shift(6) >> #define PGT_validated PG_mask(1, 6) >> /* PAE only: is this an L2 page directory containing Xen-private mappings? */ >> +#ifdef CONFIG_PV32 >> #define _PGT_pae_xen_l2 PG_shift(7) >> #define PGT_pae_xen_l2 PG_mask(1, 7) >> +#else >> +#define PGT_pae_xen_l2 0 >> +#endif > > Hmm - this is going to irritate Coverity and Clang some more.  I still > need to figure out an effective way to make Coverity not object to this > type of short circuiting like this. I assume this is just a remark, not implying any action on my part? > I've looked through the users and I think that they're all safe. I wouldn't have dared make the change without first checking. >  I do > however wonder whether is_guest_l2_slot() can be simplified and have its > is_pv_32bit_domain() clause dropped, seeing as it is expensive with its > lfences, and the logic ought to only care about PGT_pae_xen_l2 vs > PGT_l2_page_table. Good idea, yes, but that'll be a separate patch. >> @@ -494,15 +498,39 @@ extern paddr_t mem_hotplug; >> #define SHARED_M2P_ENTRY (~0UL - 1UL) >> #define SHARED_M2P(_e) ((_e) == SHARED_M2P_ENTRY) >> >> -#define compat_machine_to_phys_mapping ((unsigned int *)RDWR_COMPAT_MPT_VIRT_START) >> +#ifdef CONFIG_PV32 >> + >> +extern int8_t opt_pv32; >> + >> +# define compat_machine_to_phys_mapping ((unsigned int *)RDWR_COMPAT_MPT_VIRT_START) >> + >> +# define set_compat_m2p(mfn, entry) \ >> + ((void)(!opt_pv32 || \ >> + (mfn) >= (RDWR_COMPAT_MPT_VIRT_END - RDWR_COMPAT_MPT_VIRT_START) / 4 || \ >> + (compat_machine_to_phys_mapping[mfn] = (entry)))) > > I know this is extracting previous logic, but "entry" would probably be > better if it were named "val" or similar. I was wondering myself, but didn't consider val or alike meaningfully better. As it looks you do, I'll switch. > However, see my reply to patch 3 which I think will simplify this > substantially. Neither my inbox nor the list archives have such a reply, so I can only assume this is yet to be sent. Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 07 10:22:23 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 10:22:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3zVu-0000sS-0g; Fri, 07 Aug 2020 10:22:14 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3zVs-0000sN-C5 for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 10:22:12 +0000 X-Inumbo-ID: 40730464-e283-4997-9115-c691fb87e740 Received: from merlin.infradead.org (unknown [2001:8b0:10b:1231::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 40730464-e283-4997-9115-c691fb87e740; Fri, 07 Aug 2020 10:22:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=4/VCHM/wzhSgd4qyRAmAC4AWdDxulH6gS0+92poTPxI=; b=XJSka808E+4ltstGU3BqwdVOtZ hXkd+8kwG+mMF3YBC9gYdFKqQ0shdnwEeGlVgLK2rKX9zQM0cV+cX2kJ4LmaDy9pbGemoN/OFohKt qnuXOPc82zBE1eZRt+Hlbu7DoTyuXW9ud2aYWjPMUx5Dw/3JDO4mQ3YCdTM4HEoCeY/awHrW5ttq7 yGPXiF6gmAUlT3tKwYWzxUSDGRDD8KGANnAswpVZO8evJINZiqIYWUR2sglBnT5anAp66EWDa3CPF 1DOFDSa4vUFlAE+qdQ+8lQ3yc5sir2LRPdpMuROK+/SSyWXy9+HBgPYjDo4knnSw2IjRdxZeDX7ZH TrODYMfA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3zVg-0002mK-4n; Fri, 07 Aug 2020 10:22:00 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id A12A33012DC; Fri, 7 Aug 2020 12:21:58 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 89ED32B84E245; Fri, 7 Aug 2020 12:21:58 +0200 (CEST) Date: Fri, 7 Aug 2020 12:21:58 +0200 From: peterz@infradead.org To: =?iso-8859-1?Q?J=FCrgen_Gro=DF?= Subject: Re: [PATCH v3 4/7] x86/paravirt: remove 32-bit support from PARAVIRT_XXL Message-ID: <20200807102158.GG2674@hirez.programming.kicks-ass.net> References: <20200807083826.16794-1-jgross@suse.com> <20200807083826.16794-5-jgross@suse.com> <20200807093916.GF2674@hirez.programming.kicks-ass.net> <3a0712ee-efca-5684-d321-3b789e01fc16@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3a0712ee-efca-5684-d321-3b789e01fc16@suse.com> X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Deep Shah , "VMware, Inc." , x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Ingo Molnar , Borislav Petkov , Andy Lutomirski , "H. Peter Anvin" , xen-devel@lists.xenproject.org, Thomas Gleixner , Boris Ostrovsky Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Fri, Aug 07, 2020 at 12:02:59PM +0200, Jrgen Gro wrote: > On 07.08.20 11:39, peterz@infradead.org wrote: > > On Fri, Aug 07, 2020 at 10:38:23AM +0200, Juergen Gross wrote: > > > > > -# else > > > - const unsigned char cpu_iret[1]; > > > -# endif > > > }; > > > static const struct patch_xxl patch_data_xxl = { > > > @@ -42,7 +38,6 @@ static const struct patch_xxl patch_data_xxl = { > > > .irq_save_fl = { 0x9c, 0x58 }, // pushf; pop %[re]ax > > > .mmu_read_cr2 = { 0x0f, 0x20, 0xd0 }, // mov %cr2, %[re]ax > > > .mmu_read_cr3 = { 0x0f, 0x20, 0xd8 }, // mov %cr3, %[re]ax > > > -# ifdef CONFIG_X86_64 > > > .mmu_write_cr3 = { 0x0f, 0x22, 0xdf }, // mov %rdi, %cr3 > > > .irq_restore_fl = { 0x57, 0x9d }, // push %rdi; popfq > > > .cpu_wbinvd = { 0x0f, 0x09 }, // wbinvd > > > @@ -50,19 +45,11 @@ static const struct patch_xxl patch_data_xxl = { > > > 0x48, 0x0f, 0x07 }, // swapgs; sysretq > > > .cpu_swapgs = { 0x0f, 0x01, 0xf8 }, // swapgs > > > .mov64 = { 0x48, 0x89, 0xf8 }, // mov %rdi, %rax > > > -# else > > > - .mmu_write_cr3 = { 0x0f, 0x22, 0xd8 }, // mov %eax, %cr3 > > > - .irq_restore_fl = { 0x50, 0x9d }, // push %eax; popf > > > - .cpu_iret = { 0xcf }, // iret > > > -# endif > > > > I was looking at x86_64 paravirt the other day and found we actually > > have pv_ops.cpu.iret users there.. > > On x86_64 we have (without PARAVIRT_XXL): > > #define INTERRUPT_RETURN jmp native_iret > > and with PARAVIRT_XXL this is basically a jmp *pv_ops.cpu.iret which > will then be patched to either jmp native_iret or jmp xen_iret. Ah, okay. Clearly I didn't look hard enough. Thanks! From xen-devel-bounces@lists.xenproject.org Fri Aug 07 10:24:55 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 10:24:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3zYU-0000zg-FX; Fri, 07 Aug 2020 10:24:54 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3zYT-0000zb-O3 for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 10:24:53 +0000 X-Inumbo-ID: 1ee3a185-a805-43b6-b43b-bdb466294d55 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1ee3a185-a805-43b6-b43b-bdb466294d55; Fri, 07 Aug 2020 10:24:52 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 12E2FAB89; Fri, 7 Aug 2020 10:25:10 +0000 (UTC) Subject: Re: [PATCH 2/3] x86: don't maintain compat M2P when !PV32 From: Jan Beulich To: Andrew Cooper References: <4575f42b-a347-b34e-0032-e04668106a9b@suse.com> <52b4f80f-9967-fae9-ce85-c69bf3b6e22d@citrix.com> <9cf5d060-3fee-db3c-8455-e09da998594b@suse.com> Message-ID: <50650e99-e8c9-d442-79ba-a37130a7a3bf@suse.com> Date: Fri, 7 Aug 2020 12:24:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <9cf5d060-3fee-db3c-8455-e09da998594b@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 07.08.2020 12:12, Jan Beulich wrote: > On 06.08.2020 21:16, Andrew Cooper wrote: >> On 06/08/2020 10:28, Jan Beulich wrote: >>> An alternative place for opt_pv32.h would seem to be asm-x86/config.h. >> >> Oh - yes please.  I think that would be better overall. > > Done. Now that I'm trying to build the result: There's an immediate downside - we can't use int8_t in config.h, so I'll have to switch to using signed char instead. Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 07 10:56:59 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 10:56:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4037-0003eK-67; Fri, 07 Aug 2020 10:56:33 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4036-0003eF-AF for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 10:56:32 +0000 X-Inumbo-ID: 397e11ab-53b2-42c6-abf1-eb1333d29b5c Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 397e11ab-53b2-42c6-abf1-eb1333d29b5c; Fri, 07 Aug 2020 10:56:28 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 96F20AB3D; Fri, 7 Aug 2020 10:56:45 +0000 (UTC) Subject: Re: [PATCH 3/4] build: also check for empty .bss.* in .o -> .init.o conversion To: Andrew Cooper References: <305c2532-408a-9f78-61fe-c90a2e86eb8e@suse.com> <5b2bbc31-0095-c3e2-9e34-20453ea2aa5f@citrix.com> From: Jan Beulich Message-ID: <61481966-3052-ebf2-e23b-aac292cd09a1@suse.com> Date: Fri, 7 Aug 2020 12:56:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <5b2bbc31-0095-c3e2-9e34-20453ea2aa5f@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , George Dunlap , Ian Jackson , "xen-devel@lists.xenproject.org" , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 06.08.2020 18:16, Andrew Cooper wrote: > On 06/08/2020 10:05, Jan Beulich wrote: >> We're gaining such sections, and like .text.* and .data.* they shouldn't >> be present in objects subject to automatic to-init conversion. Oddly >> enough for quite some time we did have an instance breaking this rule, >> which gets fixed at this occasion, by breaking out the EFI boot >> allocator functions into its own translation unit. >> >> Fixes: c5b9805bc1f7 ("efi: create new early memory allocator") >> Signed-off-by: Jan Beulich > > Acked-by: Andrew Cooper Thanks. >> --- >> This likely has a (weak) dependency on "x86/EFI: sanitize build logic" >> sent several weeks ago, due to the new source file added, as explicit >> dependencies upon the individual objects in x86/Makefile go away there. >> >> --- a/xen/Makefile >> +++ b/xen/Makefile >> @@ -355,7 +355,7 @@ $(TARGET): delete-unfresh-files >> $(MAKE) -C tools >> $(MAKE) -f $(BASEDIR)/Rules.mk include/xen/compile.h >> [ -e include/asm ] || ln -sf asm-$(TARGET_ARCH) include/asm >> - [ -e arch/$(TARGET_ARCH)/efi ] && for f in boot.c runtime.c compat.c efi.h;\ >> + [ -e arch/$(TARGET_ARCH)/efi ] && for f in $$(cd common/efi; echo *.[ch]); \ >> do test -r arch/$(TARGET_ARCH)/efi/$$f || \ >> ln -nsf ../../../common/efi/$$f arch/$(TARGET_ARCH)/efi/; \ >> done; \ > > Maybe not for this patch, but we need to start removing this (and other) > symlinking in the tree for proper out-of-tree builds to work. Yes, but indeed not right here. > AFAICT, this logic predates both Kconfig and x86's blur into having EFI > support in xen.gz. Yes, it was a result of making parts of that code also usable by Arm64. > Can't we remove all of this by having CONFIG_XEN_PE expressed/selectable > properly in Kconfig, and gathering all the objects normally, rather than > bodging all of common/efi/ through arch/efi/ ? _If_ we settle on Kconfig to be allowed to check compiler (and linker) features, then yes. This continues to be a pending topic though, so the switch can't be made like this at this point in time. (It could be made a Kconfig item now - which, when enabled, implies the assertion that a capable tool chain is in use.) Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 07 11:18:53 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 11:18:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k40Oa-0005St-5c; Fri, 07 Aug 2020 11:18:44 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k40OY-0005So-PS for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 11:18:42 +0000 X-Inumbo-ID: 3bfc7a81-8e43-496c-930b-87953db851d3 Received: from mga14.intel.com (unknown [192.55.52.115]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3bfc7a81-8e43-496c-930b-87953db851d3; Fri, 07 Aug 2020 11:18:40 +0000 (UTC) IronPort-SDR: 52FS+zEOkpkc0Ncgmij29JpnTxA+vUcxeK4/aJYa4kEYQr9cV8ncBvx+gmOmRHHxiGSvn4mvKi mi120uhy/WJg== X-IronPort-AV: E=McAfee;i="6000,8403,9705"; a="152289605" X-IronPort-AV: E=Sophos;i="5.75,445,1589266800"; d="gz'50?scan'50,208,50";a="152289605" X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Aug 2020 04:18:38 -0700 IronPort-SDR: NIry2HdWLas7GCTf1T8+P/Bm140l84tT9Bxs4Vqb+mJTXFChY9FrK/2fH5v4KLpbh424waWZno GLuyjUFeMqCA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,445,1589266800"; d="gz'50?scan'50,208,50";a="307349835" Received: from lkp-server02.sh.intel.com (HELO 090e49ab5480) ([10.239.97.151]) by orsmga002.jf.intel.com with ESMTP; 07 Aug 2020 04:18:34 -0700 Received: from kbuild by 090e49ab5480 with local (Exim 4.92) (envelope-from ) id 1k40OP-0000Cn-Rx; Fri, 07 Aug 2020 11:18:33 +0000 Date: Fri, 7 Aug 2020 19:18:18 +0800 From: kernel test robot To: Juergen Gross , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/7] x86/xen: drop tests for highmem in pv code Message-ID: <202008071923.cKhbPPhZ%lkp@intel.com> References: <20200807083826.16794-4-jgross@suse.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="nFreZHaLTZJo0R7j" Content-Disposition: inline In-Reply-To: <20200807083826.16794-4-jgross@suse.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Stefano Stabellini , kbuild-all@lists.01.org, Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Boris Ostrovsky , Thomas Gleixner Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" --nFreZHaLTZJo0R7j Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Juergen, I love your patch! Perhaps something to improve: [auto build test WARNING on tip/x86/core] [also build test WARNING on tip/x86/asm v5.8 next-20200806] [cannot apply to xen-tip/linux-next tip/x86/vdso] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Juergen-Gross/Remove-32-bit-Xen-PV-guest-support/20200807-164058 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git ef2ff0f5d6008d325c9a068e20981c0d0acc4d6b config: x86_64-allyesconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): arch/x86/xen/enlighten_pv.c: In function 'set_aliased_prot': >> arch/x86/xen/enlighten_pv.c:348:15: warning: variable 'page' set but not used [-Wunused-but-set-variable] 348 | struct page *page; | ^~~~ arch/x86/xen/enlighten_pv.c: At top level: arch/x86/xen/enlighten_pv.c:1198:34: warning: no previous prototype for 'xen_start_kernel' [-Wmissing-prototypes] 1198 | asmlinkage __visible void __init xen_start_kernel(void) | ^~~~~~~~~~~~~~~~ vim +/page +348 arch/x86/xen/enlighten_pv.c e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 335 e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 336 /* e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 337 * Set the page permissions for a particular virtual address. If the e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 338 * address is a vmalloc mapping (or other non-linear mapping), then e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 339 * find the linear mapping of the page and also set its protections to e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 340 * match. e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 341 */ e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 342 static void set_aliased_prot(void *v, pgprot_t prot) e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 343 { e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 344 int level; e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 345 pte_t *ptep; e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 346 pte_t pte; e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 347 unsigned long pfn; e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 @348 struct page *page; e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 349 unsigned char dummy; 64aef3716eab524 Juergen Gross 2020-08-07 350 void *av; e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 351 e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 352 ptep = lookup_address((unsigned long)v, &level); e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 353 BUG_ON(ptep == NULL); e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 354 e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 355 pfn = pte_pfn(*ptep); e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 356 page = pfn_to_page(pfn); e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 357 e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 358 pte = pfn_pte(pfn, prot); e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 359 e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 360 /* e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 361 * Careful: update_va_mapping() will fail if the virtual address e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 362 * we're poking isn't populated in the page tables. We don't e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 363 * need to worry about the direct map (that's always in the page e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 364 * tables), but we need to be careful about vmap space. In e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 365 * particular, the top level page table can lazily propagate e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 366 * entries between processes, so if we've switched mms since we e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 367 * vmapped the target in the first place, we might not have the e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 368 * top-level page table entry populated. e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 369 * e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 370 * We disable preemption because we want the same mm active when e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 371 * we probe the target and when we issue the hypercall. We'll e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 372 * have the same nominal mm, but if we're a kernel thread, lazy e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 373 * mm dropping could change our pgd. e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 374 * e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 375 * Out of an abundance of caution, this uses __get_user() to fault e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 376 * in the target address just in case there's some obscure case e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 377 * in which the target address isn't readable. e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 378 */ e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 379 e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 380 preempt_disable(); e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 381 fe557319aa06c23 Christoph Hellwig 2020-06-17 382 copy_from_kernel_nofault(&dummy, v, 1); e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 383 e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 384 if (HYPERVISOR_update_va_mapping((unsigned long)v, pte, 0)) e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 385 BUG(); e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 386 64aef3716eab524 Juergen Gross 2020-08-07 387 av = __va(PFN_PHYS(pfn)); e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 388 64aef3716eab524 Juergen Gross 2020-08-07 389 if (av != v && HYPERVISOR_update_va_mapping((unsigned long)av, pte, 0)) e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 390 BUG(); e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 391 e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 392 preempt_enable(); e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 393 } e1dab14cf68d1e0 Vitaly Kuznetsov 2017-03-14 394 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org --nFreZHaLTZJo0R7j Content-Type: application/gzip Content-Disposition: attachment; filename=".config.gz" Content-Transfer-Encoding: base64 H4sICMoqLV8AAy5jb25maWcAlDzJdty2svt8RR9nkyySK8m24px3tABJsBtukqABsAdtcBS5 7eg8WfLVcK/9968K4FAA0YqfF4lYVZgLNaN//unnBXt+uv9y9XRzfXV7+33x+XB3eLh6Onxc fLq5PfzPopCLRpoFL4T5HYirm7vnb//69u7cnr9ZvP393e8nvz1cny/Wh4e7w+0iv7/7dPP5 Gdrf3N/99PNPuWxKsbR5bjdcaSEba/jOXLz6fH3925+LX4rDXzdXd4s/f38N3Zy+/dX/9Yo0 E9ou8/zi+wBaTl1d/Hny+uRkQFTFCD97/fbE/Rv7qVizHNEnpPucNbYSzXoagACtNsyIPMCt mLZM13YpjUwiRANNOUHJRhvV5UYqPUGF+mC3UpFxs05UhRE1t4ZlFbdaKjNhzUpxVkDnpYT/ AInGprDBPy+W7rxuF4+Hp+ev05aLRhjLm41lCjZH1MJcvD6bJlW3AgYxXJNBOtYKu4JxuIow lcxZNezfq1fBnK1mlSHAFdtwu+aq4ZVdXop26oViMsCcpVHVZc3SmN3lsRbyGOLNhAjn9PMi BLsJLW4eF3f3T7iXMwKc1kv43eXLreXL6DcU3SMLXrKuMu4syQ4P4JXUpmE1v3j1y9393eHX kUBvGdl2vdcb0eYzAP4/N9UEb6UWO1t/6HjH09BZky0z+cpGLXIltbY1r6XaW2YMy1eEyTSv RDZ9sw4ES3R6TEGnDoHjsaqKyCeouwFwmRaPz389fn98OnyZbsCSN1yJ3N21VsmMzJCi9Epu 0xheljw3AidUlrb2dy6ia3lTiMZd6HQntVgqkCJwb5Jo0bzHMSh6xVQBKA3HaBXXMEC6ab6i lwshhayZaEKYFnWKyK4EV7jP+xBbMm24FBMaptMUFafCa5hErUV63T0iOR+Hk3XdHdkuZhSw G5wuiByQmWkq3Ba1cdtqa1nwaA1S5bzoZSYcDuH8linNjx9WwbNuWWonHg53Hxf3nyLmmjSK zNdadjCQvwOFJMM4/qUk7gJ/TzXesEoUzHBbwcbbfJ9XCTZ1amEzuwsD2vXHN7wxiUMiSJsp yYqcUcmeIquBPVjxvkvS1VLbrsUpD9fP3Hw5PDymbiAoz7WVDYcrRrpqpF1dogqqHdePohCA LYwhC5EnZKFvJQq3P2MbDy27qjrWhNwrsVwh57jtVMEhz5YwCj/Fed0a6KoJxh3gG1l1jWFq nxTuPVViakP7XELzYSPztvuXuXr838UTTGdxBVN7fLp6elxcXV/fP9893dx9jrYWGliWuz48 m48jb4QyERqPMDETZHvHX0FHVBrrfAW3iW0iIefBZsVVzSpckNadIsyb6QLFbg5w7Nscx9jN a2LpgJhFu0uHILiaFdtHHTnELgETMrmcVovgY9SkhdBodBWUJ37gNMYLDRsttKwGOe9OU+Xd QifuBJy8Bdw0EfiwfAesT1ahAwrXJgLhNrmm/c1MoGagruApuFEsT8wJTqGqpntKMA2Hk9d8 mWeVoEICcSVrZGcuzt/MgbbirLw4PQ8x2sQX1Q0h8wz39ehcrTOI64weWbjloZWaieaMbJJY +z/mEMeaFOwtYsKPlcROS7AcRGkuTv+gcGSFmu0ofrS6WyUaA14FK3ncx+vgxnXgMngnwN0x J5sHttLXfx8+Pt8eHhafDldPzw+Hx4m3OnB06nbwDkJg1oF8B+HuJc7badMSHQZ6THdtC76I tk1XM5sx8KXy4FY5qi1rDCCNm3DX1AymUWW2rDpNjL/eT4JtOD17F/UwjhNjj40bwse7zJvh Kg+DLpXsWnJ+LVtyvw+c2Bdgr+bL6DOypD1sDf8jwqxa9yPEI9qtEoZnLF/PMO5cJ2jJhLJJ TF6C1gYDbCsKQ/YRhHuSnDCATc+pFYWeAVVBPa4eWILQuaQb1MNX3ZLD0RJ4CzY9ldd4gXCg HjProeAbkfMZGKhDUT5MmatyBszaOcxZb0SGynw9opghK0SnCUxBUEBk65DDqdJBnUgB6DHR b1iaCgC4YvrdcBN8w1Hl61YCe6MVArYt2YJex3ZGRscGRh+wQMFBv4I9TM86xtgN8acVasuQ SWHXnR2qSB/um9XQjzdHiZOpish7B0DktAMk9NUBQF10h5fRN3HIMynRAgrFMIgI2cLmi0uO hrw7fQkmRpMHBlhMpuGPhHUT+6tevIri9DzYSKABFZzz1nkUTsdEbdpct2uYDeh4nA5ZBGXE WI1HI9UgnwTyDRkcLhN6lnZm3fvznYFL748RtnP++WjTBrom/rZNTSyg4LbwqoSzoDx5fMkM fCi0ucmsOsN30SdcCNJ9K4PFiWXDqpKwolsABThnhAL0KhC8TBDWAoOvU6FWKjZC82H/dHSc TuPgSTidURZ2G4r5jCkl6DmtsZN9recQGxzPBM3AIIRtQAYO7JiRwm0jXlQMMQQMZSsdctic DSalO+g9JHtP3cweAPPbsr221IgbUENbiiO7Eg2HqnvaG5hTk0csA8418RCcPI5g0JwXBZVj /nrBmDZ2YR0QpmM3tYsHUNY8PXkzWER96Lk9PHy6f/hydXd9WPD/HO7AVGdg4eRorINzN1lJ ybH8XBMjjnbSDw4zdLip/RiDoUHG0lWXzZQVwnqbw118eiQYrmVwwi5ePIpAXbEsJfKgp5BM pskYDqjAFOq5gE4GcKj/0by3CgSOrI9hMVoFHkhwT7uyBOPVmVmJQI5bKtrJLVNGsFDkGV47 ZY3RelGKPAqdgWlRiiq46E5aO7UauPRhWHwgPn+T0Suyc2mM4JsqRx+4R5VQ8FwWVB6AO9OC R+NUk7l4dbj9dP7mt2/vzn87fzOqUDTbQT8Pli1ZpwGj0HsyM1wQGXPXrkZjWjXowvjgzMXZ u5cI2I5E+kOCgZGGjo70E5BBd5PLNgbLNLOB0TggAqYmwFHQWXdUwX3wg7P9oGltWeTzTkD+ iUxhqKwIjZtRNiFP4TC7FI6BhYVZHe5MhQQF8BVMy7ZL4LE4IA1WrDdEfUwFXE9q5oHtNaCc eIOuFAbzVh1NLAV07m4kyfx8RMZV4+OboN+1yKp4yrrTGHs+hnaqwW0dq+Ym+6WEfYDze02s ORdZd41nI/WOWS8jYeqROF4zzRq496yQWyvLEo3+k28fP8G/65PxX7CjyAOVNbvZZbS6bo9N oHNhfMI5JVg+nKlqn2MgmFoHxR6MfIzPr/YapEgVhe/bpXewK5DRYBy8JdYn8gIsh/tbiszA cy+/nLZpH+6vD4+P9w+Lp+9ffVxo7ogP+0uuPF0VrrTkzHSKe18kRO3OWEsDOgirWxe6JtdC VkUpqHOtuAEjK0g+Ykt/K8DEVVWI4DsDDIRMObPwEI3udZhiQOhmtpBuE37PJ4ZQf961KFLg qtXRFrB6mtbMXxRSl7bOxBwSa1XsauSePiEFznbVzX0vWQP3l+AMjRKKyIA93FswJ8HPWHZB YhQOhWGsdQ6xu12VgEYTHOG6FY1LC4STX21Q7lUYRACNmAd6dMeb4MO2m/g7YjuAgSY/ialW mzoBmrd9e3q2zEKQxrs882bdQE5YlHrWMxEbMEi0nz5z0nYY54ebWJnQbQiaj3t3NHw9UgwR tB7+HlhgJdHOi4fPVTPCRguqXr9LhvfrVudpBFrF6WQyWAuyTphjo5ajrsJwQ1QDxkevwuKg ItJUpwHynOKMjiRJXre7fLWMzB5M7EQXGQwEUXe1EyAlCNNqT6K6SOCOGFznWhOuFKBUnHCz gePtZEe9Oyb2+nQAOvK84kEQCEaHK+wlxRwMgmIOXO2Xgfncg3Mwx1mn5ojLFZM7mqhctdyz lYpgHFx4NEGUIbvK2iwmLqifvQQ7N855glkV3K/G2QUajW2wDDK+ROvs9M+zNB5zwinsYMkn cAHMizxdU5vUgep8DsHYgQxP0tWD2LmWwrzLDKi4kugIY5gmU3INYsBFfjDHHXFczmcADJRX fMny/QwV88QADnhiAGI2WK9AN6W6eR+wnLs2fV5rEyp/4vx9ub+7ebp/CLJyxLXsVVvXREGV GYVibfUSPsds2JEenJqUW8d5o+dzZJJ0dafnMzeI6xasqVgqDEnnnvEDX8wfeFvhfzi1HsQ7 ImvBCIO7HeToR1B8gBMiOMIJDMfnBWLJZqxChVBv98TWxltn7oWwQig4YrvM0K7VcRfM14Bp I3LqsMC2gzUB1zBX+9YcRYA+cS5Ptp/72GhehQ1DSG8Ns7wVEcblPTgVJqge9KAZRjvb287O bPRzYgkvYkTPJujxThoPphOWWsQxqB4VFdg4lMsDrJH/fdXfxCAV3uhqMLSwCKLj6DEcrj6e nMw9BtyLFifpBcHMIIzw0SFi2B18WYm5L6W6ds7FKI7QVqiH1UyEvnks0LD6BHN4W6IRa6No Ngm+0I0QRgRJlBDeH8q4+SdHyPCY0M5y0nwgPg2Wz+KjA/NGg5+DEoiFWSKHjqM6zlSuWWzc 17ED0Bvy46kbX75k13yvU5RG7xzfoF9IjaoURZM0mRKUmChJGFG8pBHnUsDl7bIQUotdEKvi OQY7LsIylNOTk0TvgDh7exKRvg5Jo17S3VxAN6GSXSms5yCWMd/xPPrEAEUqbuGRbaeWGGbb x600Ta6MIF8jFSOyS1FjYMLF3vZh01wxvbJFR40W3+p9ABsdbhCcCsMAp+FdVtwFBENZ5JkR czkYFI/8UIybuFY6MQqrxLKBUc6CQQbvv2fTiu2xJiExnCc4jpkGalnhaslOvl2NJwlSo+qW oc0+yRKCJi6X94vSuD7utim0pGzWS71IF6fSXTHlTjbV/qWusK4p0U9eFy5UBouhNreHkiQh XEZklKow8wyFC/NUoP5arAqY4BQ02SwvRFVmHA8nYSNt7XC9MO1Prt/if6JR8BdNv6BX6FM2 XtE610vE0rPvRreVMKB6YD4mdDEpFYbfXMAvUQtK6cyqDUi8yXn/38PDAqy5q8+HL4e7J7c3 aBUs7r9ikT2JOs1Ch75yhUg7HzOcAea5/gGh16J1iR5yrv0AfIxM6DkyLGglU9INa7EcEHU4 uc41iIvCJwRMWGOOqIrzNiRGSBigAChqhTntlq15FFmh0L42/nQSHgF2SbNOddBFHMqpMeeI eeoigcJ6+vn+j0uJGhRuDnFZKYU6hxOF2ukZnXiUuh4gob8K0LxaB99D+MFX7JKt2n7wDgYW Q4tc8Cnh+FL7xJHFFJKmzQG1TJuXY/QOWZ7gZl+DaHOaBU5VynUXB5Lhcq1MnwDGJi3NMzhI n4HyS3aOl56naBylO7ElvTMB2IZpft95mysbaT4/9VbE3Ucb6KcL9nSpR4ePohTfWBBjSomC p1ICSAOqeqpvpggW70LGDJjl+xjaGROILgRuYEAZwUoWUxlWxPsUSksEuTiT4sBwOp7hFB6K veEILYrZsvO2zW345CBoE8FFW8ecldTz0cBsuQTzPEx0+qX7QELCcOt3BiV/14LUL+KZv4SL BIafTY58I2NWgr8NXLkZzwzLim2gAClkGNDxzJnFBxT6F27UThuJDpVZyRiXLWfXSfGiQ8mJ 6eQtOju95UJp4C/qQMMX2u+dEmaf3I/IxXbzrFmc2/NXoOXiGDwsmkmQT5TLFZ9dLoTDyXA2 OwCHOpaVmCi4aN4n4Zg9nCkOUyYFROKRgpMJO7BbYiArgtQFGtKyBe4OlHq2N7nKj2Hz1UvY nZevx3reGbt9qed/wBb4YOIYwXAj4G8qB02rz9+9+ePk6IxdhCGO8mrnbw61+4vy4fDv58Pd 9ffF4/XVbRAYHGQbmekg7ZZyg4+kMPJtjqDjGuwRicKQmvcjYijswdakgi7pqqYb4QlhdufH m6DGc1WVP95ENgWHiRU/3gJw/dOfTdJxSbVxPnZnRHVke8MSwyTFsBtH8OPSj+CHdR4932lR R0joGkaG+xQz3OLjw81/gmInIPP7EfJWD3M51sASn4ItbaRp3RXI86F1iBgU+MsY+H8WYuEG pZu5HW/k1q7fRf3VRc/7vNHgLGxA+kd9tpwXYMb5hI8STZS8aN/4fGDt9JLbzMe/rx4OH+ce VdhdYER8kEp8IHOn70YSkmA8M/Hx9hDKhdBmGSDu1Ctwdbk6gqx50x1BGWqTBZh5TnWADGnX eC1uwgOxZ42Y7J99VLf87PlxACx+AZW4ODxd//4ryZ6A/eLD8UT7AKyu/UcIDdLfngTTlKcn q5Aub7KzE1j9h07Q99ZYwZR1OgQU4PCzwLPAuHzMs3tdBs9OjqzLr/nm7urh+4J/eb69ipjL ZUqP5FV2tDKnDwvNQTMSTLF1mDXAqBjwB83v9Y9+x5bT9GdTdDMvbx6+/BeuxaKIZQpT4Lbm tTN/jcxlYNwOKKfh4wegHt0eb9kea8mLIvjow8k9oBSqdlYjWFNBDLuoBY3dwKcvr4xA+OLf Vbs0HENiLlJc9tENyiE5Pl7NSthoQYX5hCBT2tq8XMajUegYT5uskA4cOA1+8M6qraElwHn9 5o/dzjYbxRJgDdtJwIZzmzVgRZX0YbOUy4qPOzVD6CBj7WGYunGp2shp7dFYrgqaS76I8vni KC8zTAbLbbKuLLEqrh/rpa6O0mzaUZTD0S1+4d+eDnePN3/dHiY2Flif++nq+vDrQj9//Xr/ 8DRxNJ73htGaRIRwTd2UgQYVY5DSjRDxo8KQUGGNSg2rolzq2W09Z1+XsWC7ETkVbLrshizN kIxKj7JVrG15vK4hFIPZkf5JyBjxrWQYMkR63HIPd76kotcW8TlrdVel24a/IwGzwcJghQlj I6ivhMsw/scC1rYGvb6MpKJbVi7OYl5EeL/TXoE4n28Ubv8fdgjOvq9TT1yYzq25pSsdQWEF sZsb32BybmVdpjXanaF2MdpP7zprDQYaBnUqRlNrot7ZQrchQNPHmz3ATpfCHD4/XC0+DWv3 VqLDDA+g0wQDeqYLAk95TevHBgiWd4TlgxRTxg8AerjFUpH5E+T1UE1P2yGwrmlpCkKYe5ZA H+WMPdQ69vEROlYN+8oCfAQU9rgp4zHGWKZQZo8FKu4tap8MDUljRR0sNtu3jMa6RmQjbWik YRVbB1r9MroVwda7bsOKCrcjdTEDgPW8iXeyi3+LA2NUm93b07MApFfs1DYihp29PY+hpmWd Hn8mYCjIv3q4/vvm6XCNyZ3fPh6+AouhyTizvX3CMaye8QnHEDZEqoJqJukfCvA5pH+V4Z5i gTDaRbv/QsMGLIUoALCOC5IxFwpWe0bPwP+KkEuQYz1FGYpE2Zq4k75X8BptGQX0ZxXQbtJT bL5rnOmHbwlzjExS+8rXBLjn0HDFbBa+bV1j+XDUuXviCPBONcCSRpTBkyhfxw1ngc8GEkXz s83x0MQ4/c6n4S/shsOXXeMrELhSGAFO/aDKhodBvOkNmOtxJeU6QqIngMpOLDtJvYRRd8I5 O6fK/8pItM/uPYEEFYdZdP+yck6ACm8We6XIvjQpsAjIzP1PQvk3Kna7EoaHr/HHdwB6zIe7 h8G+RdylrjH/0v/GU3wGii9BFmA+0Olnz1uhp+Tpgrde4fHg71Adbbja2gyW45/HRjhXskHQ 2k0nIvoBVqWFc3NuwMAzRgXcO2Jf8h+9PJ46SYw/vBxT/RaFhRLTqaUERAqbeBiIEhqsohXv k0gua5tE488jpEh67vK3wf8OQV8NHE+mFyI9c2HyOqLo2/lK0CO4QnZHHqb07ir6o/4XeYbf FkvQYs3fRJ/atb6Ip3/BQwTvEThpiWdVAWNFyNnTj0En9c9DAvTw4zCTuE+2jRrB1sqZneNX LQw4oj0fORcpZjYUTBz8OxRe67m1dOTHX2LJ/Y8//IKFEVjc8H+c/Wtz5DbSLor+FcXsiLXm jbO8XSTruk/4A4pkVbHFmwhWFdVfGHK3bCum3fJWy+941q8/SIAXZCJR7XUmYtyq5wFxTQAJ IJHwjJultkpTLTTaN/zdcH19ZuMEHm5e0mNbLQaaBEsLpWs0bFJ6OaRVMqccyWjtmMZwqdDq NFVyhuNimBjhBjT0OmY01tRoGsSlja7g0dm5y1p+msBfzbf6mHitK3m+SOwgTFQDrYODlZUr VPXjOKm0zoVpI42Dtyp3dlX1lhmLmOlqo7UeMVtteNiHbi2z42ASYTkAGvI58ILM5dNe2D4z Fvpca4AMmZxYGjSDzbNtq+b0dnTG11w7u9t6Kfq5ESb2c46a81ur6ovC0TQOz7+T3qZUBU7V gjnLvmlMPx0ubVu2ykYbj6vLDz8/fXv+fPcvc7H5j7fXX17wqRUEGkrOxKrZUTk2pl/z7dsb 0aPygz9PUN+N0Ylze/c7i4UxqgYUejUk2kKtr9dLuMdtmdWaZhgMINFZ8DASUMAYSuqtDYc6 lyxsvpjI+erPrF7xV4OGzDXx6CtVsG7N5kI4STOWnRaDzPMsHFZ0JKMWFYbLm9kdQq3WfyNU tP07cakV581ig/SdfvrHt9+egn8QFoaHBq17COG4/6Q8duOJA8G116vSR6WEKXXyItNnhbZR shZOpeqxavx6LPZV7mRGGode1ERpjy0IwWeLmqL1VVsy0gGlt5yb9AFfYJu9EamxZjgdtijY jNrLIwui063ZYUybHht0xOZQfRssXBquwCYurCaYqm3xDX6X06b1uFDD/iTdRQPuuudrIAOP bGrce/SwcUWrTsXUFw80Z/Qio41y5YSmr2pbLQbUOAYex2Fs8cDR9gGEsQR9ent/gXHvrv3P H/Zt48lscjJAtEbruFIrotmw0kf08bkQpfDzaSqrzk/j+zGEFMnhBqsPfNo09odoMhlnduJZ xxUJLgFzJS2UGsESrWgyjihEzMIyqSRHgEPDJJP3ZF0HFyi7Xp73zCfgLRDOeszdDYc+qy/1 gRYTbZ4U3CcAU6ciR7Z451z7WOVydWZl5V6ouZIjYLeai+ZRXtZbjrG68UTNx8hEwNHA6Oyk QqcpHmDP38FgAWTv2Q4wdnMGoLboNT6Eq9kRntW11FdZZe5oJEoxxsd1Fnn/uLdHpRHeH+zB 5PDQj0MP8dsGFHFiNjugRTmb+vzkmNTsdSD3dtjbmZBlgCTLjDRw41xrKY5GPNvcthXsGjWF NRhrPct8rHpmdUV2hWrOUaqmh9St6OEmLVe7kk646/B+hn7cXPlPHXxSZeHM15y01DVMPyJJ tDJAbHpmhX90fdTv0wP8Azs/2BGxFdZctRjO4uYQs9G9Obj86/nTn+9PcEgFjvfv9B3Od0sW 91l5KFpYizrLIY5SP/BGuc4v7EvNrhLVstbxbjnEJeMms09CBlgpPzGOctjpmk/cPOXQhSye f399+89dMZuKOPv+N68czvcV1Wx1FhwzQ/rm0LjRby5J0p2B8RobuNluuWTSDm6IpBx1Mae1 zsVKJwRJVLs8Pdqan75ocg/3ANQH4OPf6m4mh7Z3WTsuOJqFlPTDACW+Zeu5BoPxIbdeevYQ RsY+7wWa4U5MawZtuHm+JB/tQadF86cBjDRzC36C6U2kJoVBCimSzP2aWO/h99R/2OlRXyNq +pa6hNqrRbTd542HiQrbCsFeq7vLfG97bRsrTouI8aidND8tF7vJOwMea312wD78dK0rJRWl c3v99s4cux9nPMTZqyI2WGF86jHrI+uoAS4x4ZMlF4nzVJhbqfZoqFqKBENeSVUXIerNBNna JYDgoEn+tLGqkN0c/DgkN5VaA9NSsGpmU4704Llx5/3EeL78ftTbJe8o5EbE/Br61gcn3k+J 95OPsk3+Dwr70z++/O/Xf+BQH+uqyucI9+fErQ4SJjpUOW8KzAaXxkefN58o+E//+N8///mZ 5JFzf6i/sn7u7b1qk0VbgqhnwhGZPEwVRqVgQuDl+XiwqE1CxmNVNJykTYOPZMizAvo4UuPu ucCkjdTafxreZDfeqsidemO3ctQ7jpXtPflUqMk3g7NWFFh9DI5CLshm2PhToo6L5uvp2iW/ ykyvuteRU8xqfK18uJhJ/MMfwR+wWjifCmFbeOqdbLhGokcgMI08sEm0qTkYsLWJodXMiKF0 pLwmLwb4FZlZ+3DtMxWmHxYqVPfBF1jBWbBKEO9dAZgymJIDYiYr7/fGn9d4equ1rfL5/d+v b/8Cw3BHzVKT6r2dQ/NbFVhYYgPLUPwLrDsJgj9BRwfqhyNYgLWVbVh+QK7H1C8w7sRbqxoV +bEiEL5lpyHOPwjgah0ORjUZ8g8BhNEanOCM3w+TixMBUtsYy2ShHpwKWG2mBNkBPEmnsMZp Y9sLNPLLU8Skzruk1t6ukRduCyTBMySaWW10ZPwuiEKn26zafU+DuEO2V6NMltKuOEYGCre5 iYk44wjIhBC2Q/OJU4uwfWXroxMT50JK25hXMXVZ0999copdUN/Kd9BGNKSVsjpzkKO26SzO HSX69lyio5EpPBcF8/gK1NZQOHLDZ2K4wLdquM4KqRYeAQdadlxqAavSrO4zZwyqL22GoXPC l/RQnR1grhWJ5Q11Gw2gbjMibs8fGdIjMpNZ3M80qLsQza9mWNDtGr1KiIOhHhi4EVcOBkiJ DRzzWx0folZ/Hpmd2onao8c8RjQ+8/hVJXGtKi6iE6qxGZYe/HFvH35P+CU9Csng5YUBYa8D L4cnKucSvaT29ZwJfkxteZngLFfTp1r2MFQS86WKkyNXx/vGVkcnH9rs00MjOzaB8xlUNKu3 TgGgam+G0JX8nRAl/4TcGGCUhJuBdDXdDKEq7Cavqu4m35B8Enpsgp/+8enPn18+/cNumiJZ oVNNNRit8a9hLoIdmwPH9Hj3RBPmnQCYyvuEjixrZ1xauwPT2j8yrT1D09odmyArRVbTAmV2 nzOfekewtYtCFGjE1ohE64IB6dfo6QdAyySTsd43ah/rlJBsWmhy0wiaBkaE//jGxAVZPO/h XJTC7jw4gd+J0J32TDrpcd3nVzaHmlPriJjD0VMPRubqnIkJtHxyElQjCdE/iXQbDJImdyZU bPBSKFiz4fUNzDJ1Ww+K0eHR/aQ+PeqTY6WkFXgRqkJQq7gJYuamfZMlal1pf2UuNL6+PcMq 45eXL+/Pb77XX+eYuRXOQA1LI44yzkeHTNwIQLU5HDN5O8zlySuWbgB0U96lK2mJRwmvaZSl XokjVD8SRbS9AVYRobu4cxIQ1fhUHJNATwTDplyxsVlY+ksPZ9yNeEj6fgIiR980flZLpIfX fYdE3Zobg2r6imuewVq3Rci49XyiFLo8a1NPNgRc2BYe8kDjnJhTFEYeKmtiD8OsDRCvJEE7 MCx9NS5Lb3XWtTev4ObcR2W+j1qn7C3TeW2Yl4eZNtsrt7rWMT+rNRKOoBTOb67NAKY5Bow2 BmC00IA5xQXQ3YAZiEJINYxgfy1zcdSqS0le94g+o1PXBJF1+ow748ShhSMkZOILGM6fqobc uOfHaowOSR9DM2BZGudYCMajIABuGKgGjOgaI1kW5CtnHlVYtf+AVD3A6ECtoQo98KVT/JDS GjCYU7GjQTrGtJUZrkDbRGoAmMjwhhYgZh+GlEySYrWObLS8xCTnmpUBH364Jjyucu/iRkzM 5rUjgTPHyXc3ybLWDjp9Cvzt7tPr7z+/fH3+fPf7K1gxfOM0g66lk5hNgSjeoI3nFJTm+9Pb r8/vvqRa0RxhTwLfd+OCaPev8lx8JxSngrmhbpfCCsXpem7A72Q9kTGrD80hTvl3+O9nAg4d yKU4Lhh6kJENwOtWc4AbWcEDCfNtCW+sfacuysN3s1AevCqiFaiiOh8TCDZ9qZLvBnInGbZe bs04c7g2/V4AOtBwYbBhPxfkb4muWuoU/DIAhVErd7Cfr2nn/v3p/dNvN8YReJMejtvxopYJ hFZ0DE8f9uSC5GfpWUfNYZS+j+xL2DBluX9sU1+tzKHI2tIXiszKfKgbTTUHuiXQQ6j6fJMn ajsTIL18v6pvDGgmQBqXt3l5+3uY8b9fb351dQ5yu32Y8yE3iH7p4TthLrelJQ/b26nkaXm0 j2G4IN+tD7RbwvLfkTGzi4NcbDKhyoNvAT8FwSoVw2OjQyYEPSDkgpwepWeZPoe5b7879lCV 1Q1xe5YYwqQi9yknY4j4e2MPWSIzAaj+ygTB3sI8IfQ27HdCNfxO1Rzk5uwxBEH3JZgAZ+1N aXZ0dWsja4wGXCGTk1N9h1t0P4WrNUH3GegcfVY74SeGbDPaJO4NAwfDExfhgON+hrlb8Wkz Om+swJZMqadE3TJoykuU8EzZjThvEbc4fxEVmWGDgIHVD1jSJr1I8tM5hgCMmKIZUC1/zPXL IBysytUIfff+9vT1GziYgTtw76+fXr/cfXl9+nz389OXp6+fwDjjG/VHZKIzu1QtOc6eiHPi IQSZ6WzOS4gTjw9jw1ycb6MxOs1u09AYri6Ux04gF8JHOIBUl4MT0979EDAnycQpmXSQwg2T JhQqH1BFyJO/LpTUTcKwtb4pbnxTmG+yMkk7LEFPf/zx5eWTHozufnv+8of77aF1mrU8xFSw +zod9riGuP+fv7F5f4Cju0boEw/rdSCFm1nBxc1KgsGHbS2Cz9syDgE7Gi6qd108keMzALyZ QT/hYtcb8TQSwJyAnkybjcSy0JesM3eP0dmOBRBvGqu2UnhWM+YdCh+WNyceRyqwTTQ1PfCx 2bbNKcEHn9ameHMNke6mlaHROh19wS1iUQC6gieZoQvlsWjlMffFOKzbMl+kTEWOC1O3rhpx pdDomZriSrb4dhW+FlLEXJT5WtCNzjv07v9e/73+PffjNe5SUz9ec12N4nY/JsTQ0wg69GMc Oe6wmOOi8SU6dlo0c699HWvt61kWkZ4z+3k0xMEA6aFgE8NDnXIPAfmmj3egAIUvk5wQ2XTr IWTjxsjsEg6MJw3v4GCz3Oiw5rvrmulba1/nWjNDjJ0uP8bYIcq6xT3sVgdi58f1OLUmafz1 +f1vdD8VsNRbi/2xEXvwBVuhx/y+F5HbLZ1j8kM7nt8XKT0kGQj3rER3HzcqdGaJydFG4NCn e9rBBk4RcNSJzDksqnXkCpGobS1muwj7iGVEgVzs2Iw9w1t45oPXLE42RywGL8YswtkasDjZ 8slfcvtFDVyMJq3thxIsMvFVGOSt5yl3KrWz54sQ7ZxbONlT3ztj04j0Z6KA4w1DY1AZz2aZ po8p4C6Os+Sbr3MNEfUQKGSWbBMZeWDfN+2hIW+KIMa5w+vN6lyQe+Mm5fT06V/IB8sYMR8n +cr6CO/pwK8+2R/hPDVGNx01MZr+aYtgY4RUJKufLFNHbzhwHsLaA3q/8Lw5psO7OfCxg9MS W0JMisgUt0kk+kHugAOC1tcAkDZvkdcx+KXGUZVKbze/BaNluca1R4eKgDifwvb2rH4o9dQe ikYEHINmcUGYHJlxAFLUlcDIvgnX2yWHKWGh3RLvG8Mv956dRi8RATL6XWpvL6Px7YjG4MId kJ0hJTuqVZUsqwrbsg0sDJLDBMLRKAHjA0+fkeItWBZQM+sRZpnggadEs4uigOf2TVy49l4k wI1PYXxHT4bZIY7ySq8rjJS3HKmXKdp7nriXH3migueZW557iD3JqGbaRYuIJ+UHEQSLFU8q vSPLbTnVTU4aZsb648Vuc4soEGFUMPrbufWS29tN6oftFbcV9ntqcHVOe7rGcN7W6Oq8fakO fvWJeLQ9sGishVOgEim1Cd73Uz/Bawx6uTW0ajAX9qMb9alChV2r5VZtaxcD4Hb4kShPMQvq yw48A+oxPgC12VNV8wRevdlMUe2zHOn/Nuv4kLZJNDyPxFER4FDxlDR8do63voQRmcupHStf OXYIvITkQlBD6DRNQZ5XSw7ry3z4I+1qNSRC/ds3HK2Q9HTHohzxUFMvTdNMvcafidZnHv58 /vNZqSM/Dn5LkD4zhO7j/YMTRX9q9wx4kLGLohlzBPFL9SOqzxeZ1BpilKJB87aHAzKft+lD zqD7gwvGe+mCacuEbAVfhiOb2US6JuGAq39TpnqSpmFq54FPUd7veSI+VfepCz9wdRRj9x0j DO5ueCYWXNxc1KcTU311xn7N4+x9Wx0LcpgxtxcTdH4M07kIc3i4fc8GKuBmiLGWbgaSOBnC KtXuUGmPI/b0ZLihCD/9449fXn557X95+vb+j8Gs/8vTt28vvwxHDrjvxjmpBQU4W90D3Mbm MMMh9Ei2dHH7wZIRO6N3bwxAPDOPqNsZdGLyUvPomskB8jw3oowdkCk3sR+aoiBmBhrXG23I ByMwaYGfR56xwVtpFDJUTK8XD7g2IWIZVI0WTvaEZgI8DLNELMosYZmslin/DXIlNFaIIOYc ABgLjNTFjyj0URgr/r0bEHwT0LEScCmKOmcidrIGIDUpNFlLqbmoiTijjaHR+z0fPKbWpCbX Ne1XgOKNnxF1pE5Hy1lzGabFl+KsHBYVU1HZgaklY5vt3mI3CXDNReVQRauTdPI4EO5kMxDs KNLGo88DZrzP7OImsSUkSQne42WVX9A2lFImhPaeyGHjnx7Svr9n4QnaK5tx+yltCy7w7Q87 IqqIU45lyLtTFgO7t0g7rtQC86JWkmgYskB8tcYmLh2ST/RNWqa2V6iL45/gwjsnmOBcrfP3 xIWzdol4KeKMi087/fs+4azGT49qNrkwH5bD7ROcQbenAqLW4hUO4y5DNKqGG+YufWmbJJwk VdN0nVKjsz6P4FADtk8R9dC0Df7VS9uJu0ZUJghSnMi9/zK238uBX32VFuDCsTfnKZYkN/Zi tjlI/dKDVcYOLXaNp0NIA3d6i3C8PegleQduuB7J2zh7Ww1XY2P/Ae3JK0C2TSoKx3csRKmP G8dtfNtpyt3787d3Z+VS37f4mg1sTzRVrVakZUaObpyICGG7ZZmaXhSNSHSdDD5fP/3r+f2u efr88jqZD9lP8aGlPvxSA08hepmjx0pVNtELcU01v8sjuv87XN19HTL7+fm/Xz49u++IFveZ rSmva9Qz9/VDCi9P2APOYwxvWMHtzKRj8RODqyaasUf91t1UbTczOomQPSDBs37o+BCAvb3f BsCRBPgQ7KLdWDsKuEtMUs47iBD44iR46RxI5g6EeiwAschjsBeCu+r2oAGcaHcBRg556iZz bBzogyg/9pn6K8L4/UVAE8C71PaTWjqz53KZYajL1DiI06uNIkjK4IH0M7PgcJ3lYpJaHG82 CwaCdwQ4mI880w/TlbR0hZvF4kYWDdeq/yy7VYe5OhX3fA1+EMFiQYqQFtItqgHVfEYKdtgG 60XgazI+G57MxSzuJlnnnRvLUBK35keCrzVwtucI8QD28XQ/DPqWrLO7l/EpPtK3TlkUBKTS i7gOVxqcbXfdaKboz3LvjX4L+7QqgNskLigTAEOMHpmQQys5eBHvhYvq1nDQsxFRVEBSEDyU 7M+jCzZJvyNj1zTc2jMkHMqnSYOQ5gBqEgP1LXIGr74t09oBVHndw/yBMnalDBsXLY7plCUE kOinvZxTP53NSh0kwd8U8oBXtnBS7qjYLfNSmwX2aWxbldqMLCb7yv2XP5/fX1/ff/POqmBa gB/sg0qKSb23mEcnK1ApcbZvkRBZYC/ObTU8ssIHoMlNBDoPsgmaIU3IBHnc1uhZNC2HwfSP JkCLOi1ZuKzuM6fYmtnHsmYJ0Z4ipwSayZ38azi6Zk3KMm4jzak7tadxpo40zjSeyexx3XUs UzQXt7rjIlxETvh9rUZlFz0wwpG0eeA2YhQ7WH5OY9E4snM5Ib/rTDYB6B2pcBtFiZkTSmGO 7Dyo0QetY0xGGr1ImR+z9vW5SUc+qGVEY5/EjQg5b5ph7WBXrUfRc4ojS5bgTXePnnk69Pe2 hHhWImAJ2eDnZ0AWc7Q7PSJ40+Oa6vvRtuBqCLx3EEjWj06gzFZDD0c427FPsvUZUqA90mD3 5mNYmHfSHN7z7dXivFQTvGQCxfDc7yEzjxv1VXnmAsFjJqqI8MILvD3XpMdkzwQDR+/ja0wQ pMcuQqdw4LlbzEHA/cA//sEkqn6keX7OhVqRZMinCQpknogF+4uGrYVhv5373PVRPNVLk4jR BTRDX1FLIxhO9dBHebYnjTcixv5EfVV7uRjtJxOyvc84kgj+cDAYuIj2smp725iIJgbP2NAn cp6dnGj/nVA//eP3l6/f3t+ev/S/vf/DCVik9h7LBGMFYYKdNrPjkaOTXby9g75V4cozQ5ZV Rl2pj9Tg+9JXs32RF35Sto5/7LkBWi9VxXsvl+2lYw01kbWfKur8BgdvYXvZ07Wo/axqQfP0 ws0QsfTXhA5wI+ttkvtJ066DrxRONKANhstvnRrGPqbzy2PXDK4J/gf9HCLMYQSdX+xrDveZ raCY30ROBzAra9utzoAea7qTvqvpb+eNlAHu6O6WwrDN3ABSX+wiO+BfXAj4mOx8ZAeyAErr EzatHBGwhVKLDxrtyMK8wG/vlwd0DQds744ZMoYAsLQVmgGA10ZcEKsmgJ7ot/KUaHOhYUfx 6e3u8PL85fNd/Pr7739+He9y/VMF/a9BUbG9GagI2uaw2W0WAkdbpBncPyZpZQUGYGII7P0H AA/2UmoA+iwkNVOXq+WSgTwhIUMOHEUMhBt5hrl4o5Cp4iKLmwq/oYlgN6aZcnKJldURcfNo UDcvALvpaYWXCoxsw0D9K3jUjUW2riQazBeWEdKuZsTZgEws0eHalCsW5NLcrbTlhbWd/bfE e4yk5g5i0Zmj61FxRPDRZ6LKT16RODaVVuesoRKOdcaHS9O+o94MDF9IYvChRins0cw8XIve BoA3OSo00qTtqYVHB0rqD808BDsfThi7b8++sgmM9tzcX/0lhxGR7BZrplatzH2gRvyzUFpz ZdtsaqpkHhlGm4H0R59Uhchsd3Sw1wgDD3onZXxFBr6AADi4sKtuAJznTADv09jWH3VQWRcu wpnjTJx+Z06qorH2NDgYKOV/K3Da6IdEy5gzadd5rwtS7D6pSWH6uiWF6fdXWgUJriwlspkD 6EedTdNgDlZW95I0IZ5IAQJvEvA0hXnSSO8d4QCyPe8xoo/XbFBpEEDA5qp+0wVtPMEXyGG8 ltVY4OLrp8L0UtdgmBwvmBTnHBNZdSF5a0gV1QKdKWoorJF6o5PHHnYAMofErGTz4i7i+gaj dOuCZ2NvjMD0H9vVarW4EWB4R4QPIU/1pJWo33efXr++v71++fL85u5N6qyKJrkggw0ti+Y8 qC+vpJIOrfov0jwAhWdCBYmhiUXDQCqzkvZ9jdtrV90clWydg/yJcOrAyjUO3kFQBnJ71yXq ZVpQEMaINstpDxewt03LbEA3Zp3l9nQuEzjeSYsbrNNTVPWorhKfstoDszU6cin9St9gaVNk c5GQMHAtQbZ7rntwb2+Y7lyVR6mbapj4vr38+vX69PaspVA7X5HUB4YZKukwmFy5EimUSkjS iE3XcZgbwUg49aHihRMuHvVkRFM0N2n3WFZk2MuKbk0+l3UqmiCi+c7FoxK0WNS0Xifc7SAZ EbNUb6BSkVRTVyL6Le3gSuOt05jmbkC5co+UU4N65xwdsWv4PmvIFJXqLPeOZCnFpKIh9YgS 7JYemMvgxDk5PJdZfcqoKjLB7gcCvXR+S5bNk4evP6uR9eUL0M+3ZB0uNVzSLCfJjTBXqokb pHR+nsifqDkbffr8/PXTs6HnWeCb64pGpxOLJC1jOsoNKJexkXIqbySYbmVTt+KcO9h80vnd 4kxvzPKz3jQjpl8///H68hVXgNKHkrrKSjJqjOigpRyoWqNUo+EEESU/JTEl+u3fL++ffvvu bCyvgyWYeSwZReqPYo4Bn+NQIwDzW79038f2ExvwmdHqhwz/8Onp7fPdz28vn3+1ty0e4YbJ /Jn+2VchRdTEXJ0oaL9gYBCYhNWiL3VCVvKU7e18J+tNuJt/Z9twsQvtckEB4NapdkBmG62J OkMnTwPQtzLbhIGL69cSRmfW0YLSg9bcdH3b9eRF+CmKAop2RBvAE0eOkqZozwW1sB85ePOs dGH9Hn0fm6023WrN0x8vn+EpYSMnjnxZRV9tOiahWvYdg0P49ZYPrxSp0GWaTjORLcGe3Omc H5+/Pr+9fBqWyXcVfcjsrF3RO14ZEdzr16bm4x9VMW1R2x12RNSQitzsK5kpE5FXSEtsTNyH rDEWqftzlk+3nw4vb7//G6YDcPJle2o6XHXnQud+I6S3FxIVkf2Arz7AGhOxcj9/ddZ2dKTk LG2/Ju+EG190RNy4szI1Ei3YGBbe/dR3Hq3XgAcKVpNXD+dDtTFLk6F9lcnEpUklRbXVhfmg p2/RqhX6QyX7ezWZt+RZjRO8Csq8IaujE+aUwUQK1wzSn34fA5jIRi4l0cpHOSjDmbTfPByf d4TnC2FZbSJl6cs5Vz+EvuGI3ueSamWOtlea9Ii8IpnfaoG52zgg2sgbMJlnBRMh3lCcsMIF r4EDFQUaUYfEmwc3QtXREmxxMTKxbbI/RmHbJsAoKk+iMV3mgEQFXpPUesLorHgSYM9IYmx1 /vzmbsSL4TlBeKSvavocmXoEPbpYq4HOqqKi6lr7Ngyot7ma+8o+t/d/QCvv031mP86WwQYp CC9qnIPMwawKP0R8ygZgtoCwSjJN4VVZkkc4wT7AecXjWEryC0x10MuYGizae56QWXPgmfO+ c4iiTdAP3Zek6mqD7fPb+4veSP7j6e0btkZWYUWzATsKO/sA7+NirRZQHBUXCZy8clR14FBj pqEWampwbtEdgJlsmw7jIJe1aiomPiWv8BDhLcq4X9GvZMMm2E8/BN4I1BJF79apBXtyIx39 Dio8g4pURqdudZWf1Z9q7aC99N8JFbQF35VfzHZ+/vQfpxH2+b0alWkT6JzPctuisxb6q29s /06Ybw4J/lzKQ4KewsS0bkp0sV63lGyRfYxuJfTS9NCebQb2KfBovJDWK0eNKH5squLHw5en b0rF/u3lD8Y+HuTrkOEoP6RJGpORHvAjbJG6sPpe39CBB8uqkgqvIsuKvlg9MnulhDzCQ7aK Z3esx4C5JyAJdkyrIm2bR5wHGIf3orzvr1nSnvrgJhveZJc32e3tdNc36Sh0ay4LGIwLt2Qw khv0kugUCPY5kLnO1KJFIuk4B7jSLIWLntuMyHNjb/lpoCKA2EvjXGHWp/0Sa/Yknv74A66f DODdL69vJtTTJzVtULGuYDrqxjeRaec6PcrC6UsGdJ5VsTlV/qb9afHXdqH/xwXJ0/InloDW 1o39U8jR1YFPktmuteljWmRl5uFqtXSBNwXIMBKvwkWckOKXaasJMrnJ1WpBMLmP+2NHZhAl MZt15zRzFp9cMJX70AHj++1i6YaV8T6El7aRHZTJ7vvzF4zly+XiSPKFTiYMgLcQZqwXar39 qNZSRFrMduClUUMZqUnY1WnwhZ/vSakWZfn85ZcfYNvjST8xo6Ly32GCZIp4tSKDgcF6MPjK aJENRS2CFJOIVjB1OcH9tcnMe8boXRgcxhlKivhUh9F9uCJDnJRtuCIDg8ydoaE+OZD6P8XU 776tWpEbG6XlYrcmrFp+yNSwQbi1o9Nze2gUN7OX//LtXz9UX3+IoWF8J9q61FV8tN30mccl 1GKr+ClYumj703KWhO83MpJntWQnJrF63C5TYFhwaCfTaHwI51DJJqUo5Lk88qTTyiMRdqAG HJ0202Qax7DjdxIFPuL3BMBvhJuJ49q7BbY/3esbv8P+0L9/VKrg05cvz1/uIMzdL2bumDdT cXPqeBJVjjxjEjCEO2LYZNIynKpHxeetYLhKDcShBx/K4qOmLRoaAPwrVQw+aPEME4tDymW8 LVIueCGaS5pzjMxjWApGIR3/zXc3WTiE87StWgAtN11XcgO9rpKuFJLBj2qB75MXWHpmh5hh Lod1sMAWdnMROg5Vw94hj6nWbgRDXLKSFZm263ZlcqAirrkPH5eb7YIhMnCdlcUg7Z7Plosb ZLjae6TKpOghD05HNMU+lx1XMtgWWC2WDIPP6+Zata/lWHVNhyZTb/jsfc5NW0RKFyhirj+R IzdLQjKuq7h3AK2+Qs6N5u6iZhgxHQgXL98+4eFFul7zpm/hP8jocWLI2cIsWJm8r0p8TM6Q ZlHGvH97K2yid04X3w96yo6389bv9y0zAcl66pe6svJapXn3P8y/4Z1SuO5+f/799e0/vMaj g+EYH8AhyLQCnWbZ70fsZItqcQOojXGX+vFZtfS2tzAVL2SdpgmerwAfz/ceziJBO5BAmsPh A/kEbBrVvwcS2GiZThwTjOclQrHSfN5nDtBf8749qdY/VWpqIVqUDrBP94NvgXBBOfDJ5Kyb gIC3TrnUyK4KwHqjGRvc7YtYzaFr2z9b0lq1Zi+NqgOccrd4A1uBIs/VR7bLsgr8sosWnudG YCqa/JGn7qv9BwQkj6UoshinNPQeG0N7xZU2GUe/C3RkV4EDeJmqORbGrYISYAmOMLDXzIWl kIsGnCCprtmOZo+wE4Tv1viAHhnyDRjd5JzDEsc0FqGtDTOec85pB0p02+1mt3YJpbEvXbSs SHbLGv2Ybq3o2y3zaa/rcyKTgn6Mjd32+T32bzAAfXlWkrW3fWJSpjf3fYwRaGaP/mNIdNk+ QWtcVdQsmfxa1KM2q7C7315+/e2HL8//rX66R+v6s75OaEyqvhjs4EKtCx3ZbEwPADkvoQ7f ida+fzGA+zq+d0B8PXsAE2m7fhnAQ9aGHBg5YIo2ayww3jIwEUoda2P7WZzA+uqA9/ssdsHW tgMYwKq0N1JmcO3KBpiJSAkqUlYPivO0AfpRrbKYDc/x0zMaPEYUfBDxKFxJM1eB5ps7I2/8 PfPfJs3ekin49X2RL+1PRlDec2C3dUG0vLTAIfvBmuOcnQHd18D/TZxcaBcc4eEwTs5Vgukr sdYXYCACx6jISzQYEJtzBcaA2CLhNBtxg6MndoBpuDpsJLpzPaJsfQMKPriRG1tE6lloOjQo L0XqGnoBSrYmpla+oCfrIKB5GFGgFxoBP12xO2nADmKvtF9JUHJ1SweMCYAcoBtEv4fBgqRL 2AyT1sC4SY64PzaTq/mSiV2d05rBPbKVaSmVxglPu0X5ZRHad7GTVbjq+qS2rz9YID4itwmk SSbnonjEWkq2L5RWaw/HJ1G29tRk9MsiU6sle4hrs0NBxEFDav1uO7eP5S4K5dL2CKO3G3pp e8ZVynNeyTPcoAbzgxiZDhyzvrNqOparVbTqi8PRnrxsdLp7CyXdkBAx6KLm9LiX9tWMU91n uaXH6NPtuFKrerQHomHQgNFFfMjksTk7AN1+FXUid9tFKOxrPpnMw93C9ituEHvyGIWjVQyy oh+J/SlAvodGXKe4s10rnIp4Ha2seTWRwXpr/R6c1e3hiLYijpPqk31hArTnDGwl4zpyLjzI ht6NmKwOsd4+2OTL5GC7/CnAYq1ppW1QfKlFaU++cUiun+vfSs5V0qLpw0DXlO5zaaoWjYVr JGpwJZShpXnO4MoB8/Qo7HdWB7gQ3Xq7cYPvoti2lZ7Qrlu6cJa0/XZ3qlO71AOXpsFCb7ZM Awsp0lQJ+02wIF3TYPT+6QyqMUCei+nwVtdY+/zX07e7DO6l//n789f3b3fffnt6e/5svQr5 5eXr891nNZq9/AF/zrXawiGhndf/PyLjxkUy0JlrCbIVte0e3AxY9sXJCertiWpG246FT4k9 v1g+HMcqyr6+K/VYLQ3v/sfd2/OXp3dVIPdFzGEAJfYvMs4OGLko3QwB85fYpnjGsV0sRGl3 IMVX9th+qdDEdCv34yfHtLw+YGsv9XvaaujTpqnAeC0GZehx3ktK45O94QZ9WeRKJsm++tjH fTC61noSe1GKXlghz+Cs0S4TmlrnD9XqOEOvZ1mLrS/PT9+elWL9fJe8ftLCqY1Gfnz5/Az/ /7/fvr3r8zt4vvLHl6+/vN69ftVLIr0cs1eXSrvvlBLZY38jABvXeBKDSodk1p6aksI+RgDk mNDfPRPmRpy2gjWp9Gl+nzFqOwRnFEkNT74edNMzkapQLbrvYRF4ta1rRsj7PqvQrrpehoKR 12EajKC+4QBVrX9GGf3x5z9//eXlL9oCzmHXtMRytsemVU+RrJcLH66mrRPZVLVKhPYTLFzb +R0OP1lX1qwyMLcV7DhjXEm1uYOqxoa+apAV7vhRdTjsK+zraGC81QGmOmvbVHxaEXzELgBJ oVDmRk6k8TrkViQiz4JVFzFEkWyW7BdtlnVMnerGYMK3TQYuJZkPlMIXcq0KiiCDn+o2WjNL 8w/6Nj7TS2QchFxF1VnGZCdrt8EmZPEwYCpI40w8pdxulsGKSTaJw4VqhL7KGTmY2DK9MkW5 XO+ZriwzbUDIEaoSuVzLPN4tUq4a26ZQOq2LXzKxDeOOE4U23q7jxYKRUSOLY+eSsczGU3Wn XwHZI2/hjchgoGzR7j7yGKy/QWtCjTh34zVKRiqdmSEXd+//+eP57p9KqfnX/7p7f/rj+X/d xckPSmn7L7ffS3tr4tQYjFmw2x6Wp3BHBrOP+HRGp1UWwWN9vwRZ02o8r45HdH6vUanduoKV OSpxO+px30jV63MTt7LVCpqFM/1fjpFCevE820vBf0AbEVB9M1XaxvuGauophdmAg5SOVNHV +MCxlm6A45fPNaTNWolvc1P93XEfmUAMs2SZfdmFXqJTdVvZnTYNSdBRlqJrrzpep3sEiehU S1pzKvQO9dMRdateUMUUsJMINvY0a1ARM6mLLN6gpAYAZgF4C7wZnIZaT0yMIeBMBbYAcvHY F/KnlWWgNwYxSx5z58lNYjhNUHrJT86X4E7N+PKBG/r4NcIh2zua7d13s737frZ3N7O9u5Ht 3d/K9m5Jsg0AXTAawchMJ/LA5IBSD74XN7jG2PgNA2phntKMFpdz4QzTNWx/VbRIcBAuHx25 hBvgDQFTlWBonwarFb6eI9RUiVymT4R9fjGDIsv3VccwdMtgIph6UUoIi4ZQK9o51xFZttlf 3eJDZnws4O7zA63Q80GeYtohDcg0riL65BrDqxYsqb9yNO/p0xj8Xt3gx6j9IfB18Qlus/7D JgzoXAfUXjoyDTsfdDZQ6raaAW3V2cxbYJxErtSaSn5s9i5kr+/NBkJ9wYMxnAuYmJ0jg8E3 AVwCQGqYmu7sjWn90x7x3V/9oXRKInloGEmceSopuijYBVQyDtRpi40yMnFMWqqYqNmJhspq RzEoM+T1bQQF8tphNLKaTl1ZQUUn+6i9SNS2Rf5MSLj8F7d0pJBtSqc/+VisonirBsvQy8Cy abAXAHNHvT0Q+MIOe9etOErrgIuEgo6uQ6yXvhCFW1k1LY9CprtmFMeXGzX8oPsDnNLTGn/I BToqaeMCsBDN4RbIjvwQCVFUHtIE/zLuu5AKVh9i9k1eqI6s2AQ0r0kc7VZ/0YkB6m23WRL4 mmyCHW1yLu91wakxdbFFyxczrhxwXWmQ+jQ0+t8pzWVWke6MFE/fXXhQtlZhN9/9HPCxt1K8 zMoPwqyCKGVa3YGNqMG1gN9x7dDenZz6JhG0wAo9qX52deG0YMKK/CwcrZws+SbtBen8cFJL XDIIfW2f7MgBiLa2MKVmn5ic/+LNLJ3Qx7pKEoLVs1v12PLv8O+X99+U0H79QR4Od1+f3l/+ +3l2k2+toXRKyEujhvQ7oqmS/sK8O2btvU6fMNOmhrOiI0icXgSBiH8hjT1UyEpCJ0SvnmhQ IXGwDjsC62UBVxqZ5fb5i4bmzTOooU+06j79+e399fc7NbZy1VYnanmJV/AQ6YNEN0lN2h1J eV/YewsK4TOgg1k3bqGp0c6Pjl0pMC4CWzS9mztg6OAy4heOALtMuFBEZeNCgJICcHCUyZSg 2LXV2DAOIilyuRLknNMGvmS0sJesVfPhvA3/d+tZ915kum8Q5O1JI9pOt48PDt7aup7ByKbj ANbbte1RQqN0H9KAZK9xAiMWXFPwkTgx0KjSBBoC0T3KCXSyCWAXlhwasSCWR03QrckZpKk5 e6QadS4QaLRM25hBYQKKQorSzU6Nqt6De5pBlRLvlsHsezrVA+MD2ifVKDxghRaNBk1igtCd 3wE8UUSb1Vwr7L9w6FbrrRNBRoO5HmM0Sne8a6eHaeSalftqNr6us+qH169f/kN7Gelaw6EH UtxNw1PjSd3ETEOYRqOlq+qWxujahwLozFnm84OPmc4rkM+VX56+fPn56dO/7n68+/L869Mn xsS8didxM6FRF3yAOmt4Zo/dxopEO8tI0hb5BFUwXOS3O3aR6P23hYMELuIGWqL7dglneFUM hnoo932cnyV+xoaYuJnfdEIa0GEn2dnCGWjjhaRJj5lU6wvWNDAp9M2mljt/TKw2Tgqahv7y YGvLYxhjaa7GnVItlxvtixNtYJNw+pVa1xs+xJ/BJYMMXSZJtM9U1UlbsB1KkJapuDP4+c9q +5hQodqgEiGyFLU8VRhsT5m+V3/JlL5f0tyQhhmRXhYPCNU3MNzAqW0Pn+grkjgy7CNIIfAQ ra0nKUgtArRTHlmj5aJi8LpHAR/TBrcNI5M22tuvICJCth7iRBi9b4qRMwkC+we4wbQRGIIO uUDPxCoIble2HDTeuwSfxNpzvsyOXDBk1ATtT54rHepWt50kOYY7UDT1j+DmYUYGm0NiiadW 2hm5dQHYQS0Z7H4DWI1X3ABBO1sz8ficqWNcqaO0SjecfZBQNmqONCxNcF874Q9niQYM8xtb Mg6YnfgYzN7mHDBmW3RgkNnBgKGHYUdsOgoz1ghpmt4F0W5598/Dy9vzVf3/v9yTx0PWpNhL 0Ij0FVoCTbCqjpCB0T2SGa0kcoxyM1PTwA9jHagVgxso/BYEeCaGm+/pvsVvKcxPtI2BM/Lk KrEMVnoHHsXA9HT+CQU4ntEZ0QTR4T59OCt1/6Pz/KkteAfymnab2raHI6J33vp9U4kEv1mM AzTg3qlR6+vSG0KUSeVNQMStqlroMfTh9TkMuC/bi1zgK4Yixs9mA9DaN62yGgL0eSQphn6j b8hTx/R5471o0rPtBuKI7nyLWNoDGCjvVSkr4gV/wNybUorDT97qp2gVAqfObaP+QO3a7p13 Nhrwa9PS3+CnkF7yH5jGZdCTwahyFNNftPw2lZToWb4LMu0fLPRRVsocG7OraC6NtdzU7zKj IHDTPi3wQxiiiVGs5nevVhiBCy5WLojeiR2w2C7kiFXFbvHXXz7cnhjGmDM1j3Dh1erHXu4S Ai8eKBmjTbfCHYg0iMcLgNCZOgBKrEWGobR0AccGe4DBRadSJBt7IBg5DYOMBevrDXZ7i1ze IkMv2dxMtLmVaHMr0cZNFKYS86wbxj+KlkG4eiyzGJzhsKC+SasEPvOzWdJuNkqmcQiNhraF uo1y2Zi4JgaTs9zD8hkSxV5IKZKq8eFckqeqyT7aXdsC2SwK+psLpZa3qeolKY/qAjgn4yhE C4f94P1qPjpCvElzgTJNUjulnopSI7ztCNy8lEQ7r0bRQ6saASsg8rL3jBtbIhs+2SqpRqYD ktF1y/vby89/gsny4HlVvH367eX9+dP7n2/cc6Ur21htFemEqa9OwAvtzpYjwB8HR8hG7HkC ngq1rzWBgYcU4Oail4fQJciVohEVZZs99Ee1cGDYot2gTcYJv2y36Xqx5ijYq9O39u/lR8dX ARtqt9xs/kYQ8uaONxh+9ocLtt3sVn8jiCcmXXZ09uhQ/TGvlALGtMIcpG65CpdxrBZ1ecbE LppdFAUuDm9Oo2GOEHxKI9kKRohG8pK73EMsbL/4IwxPpLTpfS8Lps6kKheI2i6yLyJxLN/I KAS+6D4GGXb8lVoUbyKucUgAvnFpIGtXcPZs/zeHh2mJ0Z7gWU60T0dLcElLmAoi5Nokze3t cXMwGsUr+xx5RreWq+9L1SBbgvaxPlWOMmmSFImo2xRd8NOA9kN3QAtM+6tjajNpG0RBx4fM Rax3juyTW/D3KqUnfJuimS9OkSWJ+d1XBXguzo5qPrQnEnNnp5WeXBcCzappKZjWQR/Y9ySL ZBvAA6q25l6D+olOFoYj7yJGCyP1cd8dbc+WI9IntlffCTWPXcWkM5Bz0wnqLyFfALW8VQO8 rR484MvUdmD7xqL6oRbsIiZr7xG2KhECua+t2PFCFVdIB8+R/pUH+FeKf6JLWR4pOzeVvfFo fvflfrtdLNgvzELd7m57+4U/9cO89APPhKc52mYfOKiYW7wFxAU0kh2k7KwaiJGEa6mO6G96 uVnb4pKfSltAbz3tj6il9E/IjKAYYwH3KNu0wBcgVRrkl5MgYIdcvxRWHQ6wD0FIJOwaoZe2 UROB7xs7vGADuu6UhJ0M/NJa5+mqBrWiJgxqKrO8zbs0EapnoepDCV6ys1Vb4ztEMDLZjjBs /OLB97Y7SZtobMKkiKfyPHs444caRgQlZufb2PxY0Q5GQG3AYX1wZOCIwZYchhvbwrHJ0UzY uR5R9OSpXZSsadBz2XK7+2tBfzOSndZwPxaP4iheGVsVhCcfO5x2kG/JozFVYeaTuIP3qeyz AN90k5DNsL495/aYmqRhsLDNAwZAqS75vOwiH+mffXHNHAgZ8RmsRBf8Zkx1HaUfq5FI4Nkj SZedpXkOh8L91rbET4pdsLBGOxXpKlyjp5z0lNllTUz3PceKwTdjkjy0rVJUl8FbnSNCimhF CI/koWtdaYjHZ/3bGXMNqv5hsMjB9AZs48Dy/vEkrvd8vj7iWdT87staDueOBRwPpj4BOohG qW+PPNekqVRDm31iYMsb+DI8oFdTAKkfiLYKoB4YCX7MRIlMSiBgUgsR4q6GYDxCzJQa5owv BUxCuWMGQsPdjLoZN/it2OFdDL76zh+yVp4dqT0Ulw/BltdKjlV1tOv7eOH10ukJhJk9Zd3q lIQ9noL0PYhDSrB6scR1fMqCqAvot6UkNXKyfakDrVZAB4xgSVNIhH/1pzi3bcc1hhp1DnU5 ENQrxqezuNo37E+ZbxTOtuGKLvZGCu6xWz0JWXKn+Baq/pnS36r729fWsuMe/aCjA0CJ/aCx AuwyZx2KAK8GMqP0kxiH9YFwIRoT2LTbvVmDNHUFOOGWdrnhF4lcoEgUj37bo+6hCBb3dumt ZD4UvOS7XmAv66UzPRcXLLgFHKrY7jsvtX20WXciWG9xFPLeFlP45RhDAgZqOrZBvH8M8S/6 XRXDgrXtwr5AF3Rm3O5UZQLPrMvxLEvbWqCzzPkzW5GcUY9mV6haFCW6IJR3algoHQC3rwaJ T2iAqGfvMRh5vErhK/fzVQ+eE3KCHeqjYL6keVxBHkVj3xAZ0abDDnUBxs9VmZDUCsKklUs4 PCWoGvEdbMiVU1EDk9VVRgkoG+1aY645WIdvc5pzF1HfuyA8eNemaYP9X+edwp22GDA6tFgM KKyFyCmHnWZoCO3NGchUNamPCe9CB6/VUrmx104YdypdguJZZjSDB+u0ye4GWdzYgncvt9tl iH/bh5zmt4oQffNRfdS560IrjYqoaWUcbj/Y2+EjYkxvqLd7xXbhUtHWF6r7btTQ508SP7Or d4or1cvg4i+Vd4cbfvGRP9rPQcOvYGEPliOCJ6JDKvKSz20pWpxXF5DbaBvyGzPqT/D5aZ9r h/bgf+nszMGv8cEzuGuED+hwtE1VVmgeOtToRy/qeti9cHGx16eLmCCjpJ2cXVp93+FvKfDb yPZiMF636fARPnVwOgDUG1SZhvfE0tbEV8e+5MtLltibhfpeSoIm0ryO/dmv7lFqpx7pOCqe ilfjanBZ2A4PQNpKqShgfpyBxxRezjtQ45kxmrSUYDxjKSGVT3N8INcvH3IRoUOdhxxvy5nf dMdrQNGoNWDuxhZcxsRx2sZ26kef2xujANDkUns/DAJg74KAuLfcyIYLIFXFL4zBHAq7UH2I xQYpywOAD1BG8CzsHUPziBtahjSFT3iQJXyzXiz58WE4aLLE394T2wbRLia/W7usA9Ajn+0j qK022muGbZdHdhvY76kCqq/aNMP9eivz22C982S+TPFd6RPWUxtx4fe7YIfdzhT9bQV1Ht2Q eoXg2/GSafrAE1Wu9LBcIJ8e6HLhIe4L+w0nDcQJuEQpMUrkeArougFRzAFksOQwnJyd1wwd t8h4Fy7oYekU1K7/TO7QFd9MBjte8OAQ0hlLZRHvgth+VzetsxjfGlbf7QL7eEwjS8/8J6sY TM3srXapZhBk3QCA+oQaz01RtFphsMK3hTbARCsig8k0P5jnBSnjbp0mV8Dhwhi8HopiM5Rz u8HAauLDM7qBs/phu7A3Ag2sZphg2zlwkaqpCXX8EZdu1OQxDwOa0ag9oS0eQ7nnVwZXjYGX LQNs3zYZocI+BhxA/LjFBG4dMCtsF8UDhncwxmbxqKXSNkM8KZXlsUhtpdlYB86/YwEXxpGa cuYjfiyrGl1cAgnocry9NGPeHLbp6Yy8vJLfdlDkDHZ8AIVMJRaB9wcUEdewhDk9gnw7hBvS aMnINFRTdrdo0QhjZRZdjlI/+uaE3rGeILIfDfhFqeUxssK3Ir5mH9FkaX731xUaXyY00uh0 gX3AwbGbeT2TfQDRCpWVbjg3lCgf+Ry5FhVDMYwL1pkaXLKKjjboQOS5Eg3f0Rs9JbAOD0Lb rcMhsS/3J+kBjSjwk3oxuLeXA2osQI/9ViJpzmWJZ+ARU2u3Rin4Db7zrff693ij0RiAGTc9 GMTP1wJi3gOhweDyBTgFY/AzLJMdImv3Au0TDKn1xbnjUX8iA08evLEpPRr3xyAUvgCq0pvU k5/hEk6ednZF6xD0yFWDTEa4LXJN4M0LjdQPy0Wwc1E1Ky0JWlQd0mwNCOvsIstotooLci2q MbODR0A1Ji8zgg1HwAQlhh8Gq21rZzXY4VMyDdhOY67IMjxXq4C2yY5wl80Qxn14lt2pn97H AqXdS0QCN8uQvXmREGCwQCGoWbLuMTq9UUxA7R2LgtsNA/bx47FUsuTg0BlphYwmIE7o1TKA S6o0weV2G2A0zmKRkKINB8MYhHnKSSmpYRckdME23gYBE3a5ZcD1hgN3GDxkXUoaJovrnNaU 8f3bXcUjxnNwZNUGiyCICdG1GBg29HkwWBwJYUaLjobXu3guZqwzPXAbMAxsO2G41CfYgsQO Dya1YPRIZUq020VEsAc31tH6kYB6sUfAQdPEqDZwxEibBgvbawBYtikpzmIS4WiyiMBhJj2q 3hw2R3Sfaqjce7nd7VboRjsyG6hr/KPfS+grBFQTqVolpBg8ZDlaPwNW1DUJpYd6MmLVdYVu BwCAPmtx+lUeEmRyHmlB+rowshqXqKgyP8WY0w/0gtMEe/7VhHZrRjB95wr+sjbf1ARgjEqp CTsQsbCPsQG5F1e0nAKsTo9CnsmnTZtvA9tF/wyGGIT9ZLSMAlD9H2mUYzZhPA42nY/Y9cFm K1w2TmJt78IyfWovN2yijBnCHPr6eSCKfcYwSbFb29eZRlw2u81iweJbFledcLOiVTYyO5Y5 5utwwdRMCcPllkkEBt29Cxex3GwjJnxTwnEh9jFkV4k876XeOsWOG90gmIOHRovVOiJCI8pw E5Jc7Ikfbx2uKVTXPZMKSWs1nIfb7ZYIdxyiPZUxbx/FuaHyrfPcbcMoWPROjwDyXuRFxlT4 gxqSr1dB8nmSlRtUzXKroCMCAxVVnyqnd2T1ycmHzNKm0b5GMH7J15xcxaddyOHiIQ4CKxtX tMCEK6u5GoL6ayJxmNl0u8AboUmxDQNkS3tybmCgCOyCQWDn0tDJnKpoj4QSE+D2czzFhjvd Gjj9jXBx2phHOtC+nwq6uic/mfysjEsFe8gxKL4VaAKqNFTlC7VEy3Gmdvf96UoRWlM2yuRE cclhcFFxcKLft3GVdvCAHbah1SwNTPOuIHHaO6nxKclWazTmX9lmsROi7XY7LuvQENkhs+e4 gVTNFTu5vFZOlTWH+wxfiNNVZqpcX8JF+5hjaau0YKqgL6vhORKnrezpcoJ8FXK6NqXTVEMz mmNme1ssFk2+C+zHbUYEVkiSgZ1kJ+Zqv9ozoW5+1vc5/d1LtIM1gGiqGDBXEgF1/IwMuOp9 1IWmaFar0LLjumZqDgsWDtBnUpu5uoST2EhwLYKMgszvHju70xDtA4DRTgCYU08A0nrSAcsq dkC38ibUzTYjLQPB1baOiO9V17iM1rb2MAB8wsE9/c1lO/BkO2Byh8d89B43+amvPFDIHELT 7zbreLUgj6jYCXEXLCL0g15FUIi0Y9NB1JQhdcBev8+s+WnzEodg9zfnIOpb7qFDxfsvekTf uegREXkcS4WPF3U8DnB67I8uVLpQXrvYiWQDj1WAkGEHIOpOaRlRx1MTdKtO5hC3amYI5WRs wN3sDYQvk9iFnJUNUrFzaC0xtd68S1IiNlYoYH2iM6fhBBsDNXFxbm1HhoBIfPFGIQcWAbdM LezeJn6ykMf9+cDQRPRGGPXIOa44SzHsjhOAJnvPwEEuRoisIb+Q7wX7S3KOldXXEB1gDAAc GmfIg+ZIEJEAOKQRhL4IgADXexXxdWIY46syPlfoaayBRAeFI0gyk2f7zH7H1fx2snylPU0h y916hYBotwRA78O+/PsL/Lz7Ef6CkHfJ889//vrry9df76o/4A0p+2miK995MH5AT0/8nQSs eK7oNfEBIL1bocmlQL8L8lt/tQcHOcM2keX46HYB9Zdu+Wb4IDkCjlosSZ9v8XoLS0W3QW5K YSVuC5L5Dd4utAN2L9GXF/Rk4UDX9oXGEbNVoQGz+xbYa6bOb+1SrnBQ48ztcO3hpizyUqaS dqJqi8TBSrhNnDswTBAupnUFD+zaflaq+au4wkNWvVo6azHAnEDYtk0B6AByACaf53RpATwW X12B9gvxtiQ4luqqoytNz7YyGBGc0wmNuaB4DJ9huyQT6g49BleVfWJg8PsH4neD8kY5BcAn WdCp7HtTA0CKMaJ4zhlREmNuexNANe4YfBRK6VwEZwxQk2eAcLtqCKeqkL8WIb5cOIJMSEce DXymAMnHXyH/YeiEIzEtIhIiWLExBSsSLgz7Kz76VOA6wtHv0Gd2lau1DtqQb9qwsyda9Xu5 WKB+p6CVA60DGmbrfmYg9VeE/DUgZuVjVv5v0ENgJnuoSZt2ExEAvuYhT/YGhsneyGwinuEy PjCe2M7lfVldS0ph4Z0xYtZgmvA2QVtmxGmVdEyqY1h3ArRI8/I7S+GuahHOnD5wZMRC4ktN Q/XByHZBgY0DONnI9eunkgTchXHqQNKFEgJtwki40J5+uN2mblwU2oYBjQvydUYQ1tYGgLaz AUkjs3rWmIgzCA0l4XCzA5rZ5xYQuuu6s4soIYfdWnvTpGmv9kGC/knGeoORUgGkKincc2Ds gCr3NFHzuZOO/t5FIQIHdepvAg+eRVJj22yrH/3OthhtJKPkAognXkBwe+oX+OwZ207Tbpv4 ir2Om98mOE4EMbaeYkfdIjwIVwH9Tb81GEoJQLRtlmPD0GuO5cH8phEbDEesD57nh4axv2W7 HB8fE1vFg/H4Y4K9J8LvIGiuLnJrrNJmMWlpexB4aEu8SzAARI8atOlGPMaujq0WkSs7c+rz 7UJlBnxfcGen5ngRnzyBN7R+GEH0wuz6UojuDny+fnn+9u1u//b69PnnJ7WOGt9C/r/migV3 uBloCYVd3TNKNgxtxlzjMU8ebueV2ndTnyKzC6FKpBXIGTkleYx/YeeWI0LuUgNK9j40dmgI gCwmNNLZL7yrRlTdRj7aZ3Gi7NBOa7RYoMsKB9Fgcwa4p36OY1IW8KfUJzJcr0LbBDm3B0b4 Bb6Kf9rONVTvyem9yjAYUFgx79HrK+rXZLdhXxtO0xSkTK2oHHsHizuI+zTfs5Rot+vmENoH 4BzLLPTnUIUKsvyw5KOI4xC9oYFiRyJpM8lhE9rXB+0IxRYdmjjU7bzGDTIbsCjSUfWdIe21 lnnCzSLBIzDiLgVcG7O00MGDQZ/i8WyJz7GHV+HoJR2VBMoWjB0HkeUVckyYyaTEv8BXLPK2 qFbk5FGwKVhfZEmSp1iLLHCc+qeS9ZpCeVBl01NIvwN099vT2+d/P3EOG80np0NMX4Y3qBZx BscrQ42KS3FosvYjxbXt7kF0FIdVdYkNQTV+Xa/tSyQGVJX8AfmNMxlBfX+IthYuJm13HKW9 Ead+9PU+v3eRacoyrsi//vHnu/fx46ysz7YrdvhJdwQ1djioxXyRo0doDAPOmpHVvYFlrQa+ 9L5AO7aaKUTbZN3A6Dyevz2/fYHpYHqo6RvJYq+9jjPJjHhfS2HbshBWxk2qOlr3U7AIl7fD PP60WW9xkA/VI5N0emFBp+4TU/cJlWDzwX36SF5mHxE1dsUsWuO3hDBjK9yE2XFMXatGtfv3 TLX3ey5bD22wWHHpA7HhiTBYc0Sc13KD7lVNlPYXBLce1tsVQ+f3fOaMayiGwHbmCNYinHKx tbFYL+0XIG1muwy4ujbizWW52Eb2oT0iIo5Qc/0mWnHNVth644zWjdJaGUKWF9nX1wY9XjGx WdEp4e95skyvrT3WTURVpyXo5VxG6iKDRya5WnBuNs5NUeXJIYPblPDuBhetbKuruAoum1L3 JHh7nCPPJS8tKjH9FRthYZu7zpX1ING7dXN9qAFtyUpKpLoe90VbhH1bneMTX/PtNV8uIq7b dJ6eCdbSfcqVRs3NYBjNMHvbUHOWpPZeNyI7oFqzFPxUQ2/IQL3I7cs8M75/TDgYLnOrf20N fCaVCi1qbBjFkL0s8B2cKYjzgJqVbnZI91V1z3Gg5tyTt3xnNgXPy8grqsv5syRTOFO1q9hK V0tFxqZ6qGLYIuOTvRS+FuIzItMmQ245NKonBZ0HysDNCvQKqoHjR2E/qWtAqAJyZQfhNzk2 txepxhThJESuEJmCTTLBpDKTeNkwTvZggmfJw4jAJVglpRxhb0DNqH19bULjam+7OZ3w4yHk 0jw2tp07gvuCZc6Zms0K21PIxOmzUORBZ6JklqTXDF9bmsi2sFWROTry6CkhcO1SMrQNlydS rRyarOLyUIijdpDE5R3enKoaLjFN7ZFHkZkD81W+vNcsUT8Y5uMpLU9nrv2S/Y5rDVGkccVl uj03++rYiEPHiY5cLWwz4IkAVfTMtntXC04IAe4PBx+DdX2rGfJ7JSlKneMyUUv9LVIbGZJP tu4aTpYOMhNrpzO2YBJvvyilfxv79TiNRcJTWY3OECzq2Nq7QBZxEuUVXbK0uPu9+sEyzgWP gTPjqqrGuCqWTqFgZDWrDevDGQSLlhpMENGxvsVvt3WxXS86nhWJ3GyXax+52dqu+h1ud4vD gynDI5HAvO/DRi3JghsRg9FiX9g2yCzdt5GvWGdwFdLFWcPz+3MYLOxnTB0y9FQKXAKryrTP 4nIb2YsBX6CV7eMfBXrcxm0hAnvry+WPQeDl21bW9JU3N4C3mgfe236Gp37muBDfSWLpTyMR u0W09HP29SjEwXRum7LZ5EkUtTxlvlynaevJjerZufB0McM52hMK0sFWsKe5HE+kNnmsqiTz JHxSs3Ra81yWZ0pWPR+Su+A2JdfycbMOPJk5lx99VXffHsIg9PS6FE3VmPE0lR4t++t2sfBk xgTwCphaLgfB1vexWjKvvA1SFDIIPKKnBpgDWOhktS8AUZVRvRfd+pz3rfTkOSvTLvPUR3G/ CTwir9beSpUtPYNimrT9oV11C88k0AhZ79OmeYQ5+upJPDtWngFT/91kx5Mnef33NfM0f5v1 ooiiVeevlHO8VyOhp6luDeXXpNV3yr0ici226JULzO023Q3ON3YD52snzXmmFn1lrSrqSmat p4sVnezzxjt3Fuh0Cgt7EG22NxK+NbppxUaUHzJP+wIfFX4ua2+QqdZ7/fyNAQfopIhBbnzz oE6+udEfdYCEGpk4mQAnSEp/+05Exwq9FE/pD0KiZ1mcqvANhJoMPfOSPr9+BE+I2a24W6UR xcsVWoLRQDfGHh2HkI83akD/nbWhT75budz6OrFqQj17elJXdLhYdDe0DRPCMyAb0tM1DOmZ tQayz3w5q9HDiWhQLfrWo6/LLE/RUgVx0j9cyTZAy2TMFQdvgnjzElHYXwmmGp/+qaiDWnBF fuVNdtv1ytcetVyvFhvPcPMxbddh6BGij2SLASmUVZ7tm6y/HFaebDfVqRhUeE/82YNENnvD Nmcmna3PcdHVVyXar7VYH6kWR8HSScSguPERg+p6YPT7gQKcg+Hd0IHWqyEloqTbGnavFhh2 TQ0nVlG3UHXUol3+4WgvlvV946DFdrcMnOOEiQRPLxfVMALf4xhoczDg+RoOPDZKVPhqNOwu GkrP0NtduPJ+u93tNr5PzXQJueJroijEdunWnVDTJLoXo1F9prRXenrqlF9TSRpXiYfTFUeZ GEYdf+ZEmyv9dN+WjDxkfQN7gfZzF9O5o1S5H2iH7doPO6fxwK1uIdzQjykxOh6yXQQLJxJ4 xDkH0fA0RaMUBH9R9UgSBtsbldHVoeqHdepkZzhPuRH5EIBtA0WCP1OePLPn6LXICyH96dWx GrjWkRK74sxwW/RM3ABfC49kAcPmrbnfwgOCbH/TItdUrWgewaE1J5Vm4c13Ks15Ohxw64jn jBbeczXimguIpMsjbvTUMD98GooZP7NCtUfs1LaaBcL1zu13hcBreARzSYM1z/0+4U19hrSU 9qk3SHP11144FS6reBiO1WjfCLdim0sI05BnCtD0enWb3vho7XpN93Om2Rp4z07eGIiU8rQZ B3+Ha2HsD6hANEVGN5U0hOpWI6g1DVLsCXKw36YcEapoajxM4ABO2jOUCW/vug9ISBH7UHZA lhRZuch0MfA0WjVlP1Z3YJBjO2fDmRVNfIK1+Kk1zwnWjt6sf/bZdmFbuRlQ/Re7rjBw3G7D eGMvoQxeiwadKw9onKEDXoMqzYtBkTGmgYb3HJnACgIrLeeDJuZCi5pLsAJf5qK2bckG6zfX rmaoE9B/uQSMJYiNn0lNw1kOrs8R6Uu5Wm0ZPF8yYFqcg8V9wDCHwmxfTYaznKSMHGvZpeUr /u3p7enT+/Oba92LfGhdbOPxSvWGXN+zLGWu/ZFIO+QYgMPUWIZ2JU9XNvQM93twVGqftpzL rNupab21ndSOV7c9oIoNtsDC1fSUdZ4oxV3fZh/eLdTVIZ/fXp6+MH4QzSFNKpr8MUbOqg2x DVcLFlQaXN3Ag3Dghb0mVWWHq8uaJ4L1arUQ/UXp8wLZutiBDnBce89zTv2i7NnX7FF+bFtJ m0g7eyJCCXkyV+hdpj1Plo32Ii9/WnJso1otK9JbQdIOps408aQtSiUAVeOrOON2tb9gT/Z2 CHmC+7xZ8+Br3zaNWz/fSE8FJ1fsr9Oi9nERbqMVslLEn3rSasPt1vON42fbJlWXqk9Z6mlX OPpGO0g4Xulr9szTJm16bNxKqQ62D3LdG8vXrz/AF3ffTLeEYcs1TB2+Jy5LbNTbBQxbJ27Z DKOGQOGKxf0x2fdl4fYP10aREN6MuE78EW7kv1/e5p3+MbK+VNVKN8LO623cLUZWsJg3fshV jnasCfHdL+fhIaBlOykd0m0CA8+fhTzvbQdDe8f5gedGzZOEPhaFTB+bKW/CWK+1QPeLcWIE U1Tnkw+2U4AB057woQv7GX+FZIfs4oO9X4FFW+YOiAb2fvXApBPHZedOjAb2ZzoO1pncdHRX mNI3PkSLCodFC4yBVfPUPm0SweRn8HTsw/3Dk1GIP7TiyM5PhP+78cyq1WMtmNF7CH4rSR2N GibMzErHHTvQXpyTBjaCgmAVLhY3Qvpynx26dbd2Ryl4cYjN40j4x71OKs2P+3RivN8OvnZr yaeNaX8OwMzy74Vwm6Bhpqsm9re+4tR4aJqKDqNNHTofKGweQCM6gsKltLxmczZT3szoIFl5 yNPOH8XM3xgvS6WIlm2fZMcsVjq8q7u4QfwDRqsUQabDa9jfRHDoEEQr97uaLiYH8EYG0Hsi NupP/pLuz7yIGMr3YXV15w2FecOrQY3D/BnL8n0qYK9T0t0Hyvb8AILDzOlMC1qyTqOfx22T E1vfgSpVXK0oE7Tc168rtXi9Hj/GuUhss7r48SNYxdq++qtOGH9XOTYr7oRxHY0y8FjGeOt7 RGwbzRHrj/YesX1bnF4Jm+5CoPW6jRp1xm2usj/a2kJZfazQs33nPMeRmjf3muqMHH4bVKKi nS7xcDkUY2iZBEBnGzYOALMfOrSevvp4dmcswHWbq+ziZoTi141qo3sOG64fT5sCGrXznDNK Rl2jy1xwfxoJ6dhodZGBqWiSo51yQBP4vz7ZIQQsgMj1dIMLeGJOX3ZhGdni10FNKsYbli7R Ad/BBNqWKQMopY5AVwHv5FQ0Zr3rWx1o6PtY9vvCdsNpFteA6wCILGv91IOHHT7dtwynkP2N 0p2ufQPvAhYMBFoa7NQVKcsS33UzIYqEg9FbQDaMu76VgFotNaX9VvLMkTlgJsibVzNBX0mx PrHlfYbT7rG0vdzNDLQGh8PZX1uVXPX2sepyyC1qXcO75tPy3TgpuPvk32KcRjt76whcsRSi 7JfoPGVGbcMDGTchOvCpR0fa9mzhzcg0Yl/Rg2tKtpCAqN/3CCDe3cCNAB3twNOBxtOLtPcd 1W88Qp3qlPyCI+SagUbnZhYllCydUrgiAHI9E+eL+oJgbaz+X/O9woZ1uExSixqDusGwmccM 9nGDbC0GBm7skK0am3JvTNtseb5ULSVLZBsYO15uAeKjRZMPALF9MQSAi6oZsLHvHpkytlH0 sQ6XfoZY61AW11yax3ll3yVSS4n8Ec12I0JchExwdbCl3t3an+XVtHpzBpfpte2hx2b2VdXC 5rgWInNLOYyZi+F2IUWsWh6aqqqb9IieAQRUn7OoxqgwDLaN9kabxk4qKLo1rUDzipV5uujP L+8vf3x5/ksVEPIV//byB5s5tQDamyMbFWWep6X9ovAQKVEWZxQ9mzXCeRsvI9tidiTqWOxW y8BH/MUQWQmKi0ugV7MATNKb4Yu8i+s8sQXgZg3Z35/SvE4bfRiCIyZX63Rl5sdqn7UuWOv3 oicxmY6j9n9+s5plmBjuVMwK/+312/vdp9ev72+vX76AoDoX33XkWbCyV1kTuI4YsKNgkWxW aw7r5XK7DR1mi55pGEC1HichT1m3OiUEzJBNuUYksq7SSEGqr86ybkmlv+2vMcZKbeAWsqAq y25L6si876yE+ExaNZOr1W7lgGvkkMVguzWRf6TyDIC5UaGbFvo/34wyLjJbQL7959v78+93 PysxGMLf/fN3JQ9f/nP3/PvPz58/P3+++3EI9cPr1x8+Ken9LyoZsHtE2oq8o2fmmx1tUYX0 Modj8rRTsp/BQ92CdCvRdbSww8mMA9JLEyN8X5U0BvAX3e5Ja8Po7Q5Bw3uXdByQ2bHUTmbx DE1IXTov6z73SgLsxaNa2GW5PwYnY+5ODMDpAam1GjqGC9IF0iK90FBaWSV17VaSHtmN09es /JDGLc3AKTuecoGvq+p+WBwpoIb2GpvqAFzVaPMWsA8fl5st6S33aWEGYAvL69i+qqsHa6zN a6hdr2gK2r8nnUku62XnBOzICD0srDBYEf8LGsMeVwC5kvZWg7pHVOpCyTH5vC5JqnUnHIAT TH0OEVOBYs4tAG6yjLRQcx+RhGUUh8uADmenvlBzV04Sl1mBbO8N1hwIgvb0NNLS30rQD0sO 3FDwHC1o5s7lWq2swysprVoiPZzxEzgA6zPUfl8XpAnck1wb7UmhwHmXaJ0audIJanilklQy felVY3lDgXpHhbGJxaRSpn8pDfXr0xeYE340WsHT56c/3n3aQJJVcPH/THtpkpdk/KgFMWnS SVf7qj2cP37sK7zdAaUU4BPjQgS9zcpHcvlfz3pq1hithnRBqvffjJ41lMKa2HAJZk3NngGM Pw54kx6bCSvuoLdqZmMen3ZFRGz/0+8IcbvdMAESV9lmnAfnfNz8AjioexxulEWUUSdvkf1o TlJKQNRiWaJtt+TKwvjYrXYclwLEfNObtbsx8FHqSfH0DcQrnvVOx+ESfEW1C401O2RgqrH2 ZF+FNsEKeCk0Qg/SmbDYSEFDShU5S7yND3iX6X/VegW53wPMUUMsEFuNGJycPs5gf5JOpYLe 8uCi9GVhDZ5b2H7LHzEcqzVjGZM8M8YRugVHhYLgV3LIbjBslWQw8rAzgGgs0JVIfD1plwMy owAcXzklB1gNwYlDaAtYeVCDgRM3nE7DGZbzDTmUgMVyAf8eMoqSGD+Qo2wF5QU8W2W/F6PR ertdBn1jv6I1lQ5ZHA0gW2C3tOb1VvVXHHuIAyWIWmMwrNYY7B6eHSA1qLSY/mA/Uj+hbhMN hgVSkhxUZvgmoFJ7wiXNWJsxQg9B+2Bhv2ml4QZtbACkqiUKGaiXDyROpQKFNHGDudI9Ph9L UCefnIWHgpUWtHYKKuNgq9Z6C5JbUI5kVh0o6oQ6Oak7NiKA6amlaMONkz4+HB0Q7AFHo+RI dISYZpItNP2SgPj22gCtKeSqV1oku4yIkla40MXvCQ0XahTIBa2riSOnfkA5+pRGqzrOs8MB DBgI03VkhmEs9hTagWduAhElTWN0zAATSinUP4f6SAbdj6qCmCoHuKj7o8uYo5J5srU2oVzT PajqeUsPwtdvr++vn16/DLM0mZPV/9GeoO78VVWDP1T9AuSs8+h6y9N12C0Y0eSkFfbLOVw+ KpWi0A8cNhWavZENIJxTFbLQF9dgz3GmTvZMo36gbVBj5i8zax/s27hRpuEvL89fbbN/iAA2 R+coa9t7mvqB3XoqYIzEbQEIrYQuLdv+npwXWJQ2lmYZR8m2uGGumzLx6/PX57en99c3d0Ow rVUWXz/9i8lgq0bgFTiDx7vjGO8T9Cw15h7UeG0dO8OT6Wv64jv5RGlc0kui7km4e3v5QCNN 2m1Y2+4b3QCx//NLcbW1a7fOpu/oHrG+o57FI9Efm+qMRCYr0T63FR62lg9n9Rm2XIeY1F98 EogwKwMnS2NWhIw2thvrCYe7eTsGV9qyEqslw9hHtCO4L4KtvU8z4onYgo37uWa+0dfRmCw5 FtQjUcR1GMnFFp+EOCwaKSnrMs1HEbAok7XmY8mElVl5RIYLI94FqwVTDrgmzhVP36UNmVo0 txZd3DEYn/IJFwxduIrT3HZCN+FXRmIkWlRN6I5D6WYwxvsjJ0YDxWRzpNaMnMHaK+CEw1mq TZUEO8ZkPTBy8eOxPMsedcqRo93QYLUnplKGvmhqntinTW47ZLF7KlPFJni/Py5jpgXdXeSp iCfwKnPJ0qvL5Y9q/YRdaU7CqL6Ch6VyplWJ9caUh6bq0KHxlAVRllWZi3umj8RpIppD1dy7 lFrbXtKGjfGYFlmZ8TFmSshZ4gPIVcNzeXrN5P7cHBmJP5dNJlNPPbXZ0Rensz88dWd7t9YC wxUfONxwo4VtUjbJTv2wXay53gbEliGy+mG5CJgJIPNFpYkNT6wXATPCqqxu12tGpoHYsURS 7NYB05nhi45LXEcVMCOGJjY+YueLauf9gingQyyXCyamh+QQdpwE6HWkVmSxR1/My72Pl/Em 4KZbmRRsRSt8u2SqUxUIuZ+w8JDF6fWZkaAGTxiHfbpbHCdm+mSBqztnsT0Rp74+cJWlcc+4 rUhQuzwsfEdOzGyq2YpNJJjMj+Rmyc3mE3kj2o39qrNL3kyTaeiZ5OaWmeVUoZnd32TjWzFv mG4zk8z4M5G7W9HubuVod6t+d7fqlxsWZpLrGRZ7M0tc77TY29/eatjdzYbdcaPFzN6u450n XXnahAtPNQLHdeuJ8zS54iLhyY3iNqx6PHKe9tacP5+b0J/PTXSDW2383NZfZ5stM7cYrmNy iffxbFRNA7stO9zjLT0EH5YhU/UDxbXKcLK6ZDI9UN6vTuwopqmiDrjqa7M+qxKlwD26nLsV R5k+T5jmmli1ELhFyzxhBin7a6ZNZ7qTTJVbObM9KTN0wHR9i+bk3k4b6tmY6z1/fnlqn/91 98fL10/vb8wd+1QpsthweVJwPGDPTYCAFxU6LLGpWjQZoxDATvWCKao+r2CEReOMfBXtNuBW e4CHjGBBugFbivWGG1cB37HxwHOwfLobNv/bYMvjK1ZdbdeRTne2LvQ1qLOGqeJTKY6C6SAF GJcyiw6lt25yTs/WBFe/muAGN01w84ghmCpLH86Z9hZnm9aDHoZOzwagPwjZ1qI99XlWZO1P q2C6L1cdiPamLZXAQM6NJWse8DmP2TZjvpeP0n5lTGPD5htB9ZMwi9le9vn317f/3P3+9Mcf z5/vIITbBfV3G6XFkkNVk3NyHm7AIqlbipFdFwvsJVcl+ADdeJqy/M6m9g1g4zHNMa2b4O4o qTGe4ajdnbEIpifVBnWOqo0ztquoaQRpRk2DDFxQAHnNMDZrLfyzsK2U7NZk7K4M3TBVeMqv NAuZvUttkIrWIzykEl9oVTkbnSOKL7cbIdtv13LjoGn5EQ13Bq3JSz8GJSfCBuwcae6o1Otz Fk/9o60MI1Cx0wDoXqPpXKIQqyRUQ0G1P1OOnHIOYEXLI0s4AUHm2wZ3c6lGjr5DjxSNXTy2 d5c0SJxmzFhgq20GJt5UDegcOWrYVV6Mb8Fuu1oR7Bon2PhFox2Iay9pv6DHjgbMqQB+pEHA 1PqgJdeaaLwDlzk8en17/2FgwffRjaEtWCzBgKxfbmlDApMBFdDaHBj1De2/mwB5WzG9U8sq 7bNZu6WdQTrdUyGRO+i0crVyGvOalfuqpOJ0lcE61tmcD4lu1c1kiq3R57/+ePr62a0z56k4 G8UXOgempK18vPbI4M2anmjJNBo6Y4RBmdT0xYqIhh9QNjw4S3Qquc7icOuMxKojmWMFZNJG astMrofkb9RiSBMYfLTSqSrZLFYhrXGFBlsG3a02QXG9EDxuHmWrL8E7Y1asJCqinZs+mjCD TkhkXKWhD6L82LdtTmBqED1MI9HOXn0N4HbjNCKAqzVNnqqMk3zgIyoLXjmwdHQlepI1TBmr drWleSUOk42g0IfbDMp4BBnEDZwcu+P24LGUg7drV2YVvHNl1sC0iQDeok02Az8UnZsP+prc iK7R3Uszf1D/+2YkOmXyPn3kpI+61Z9Ap5mu4z74PBO4vWy4T5R9p/fRWz1mVIbzIuymatBe 3DMmQ+Td/sBhtLaLXClbdHyvnRFf5dsz6cAFP0PZm0CD1qL0MKcGZQWXRXLsJYGpl8nO5mZ9 qSVAsKYJa69QOydlM447ClwcRejk3RQrk5WkukbXwGM2tJsVVdfqi7Gzzwc31+ZJWLm/XRpk qz1Fx3yGZeZ4VEoc9kw95Cy+P1tT3NV+7D7ojeqmcxb88O+XwUbbsWZSIY2psn4F1NYiZyaR 4dJeumLGvrpmxWZrzvYHwbXgCCgSh8sjMjpnimIXUX55+u9nXLrBpuqUNjjdwaYK3aeeYCiX bSGAia2X6JtUJGAE5glhPzyAP117iNDzxdabvWjhIwIf4ctVFKkJPPaRnmpANh02gW4qYcKT s21qHxtiJtgwcjG0//iFdhDRi4s1o5orPrW9CaQDNam0779boGsbZHGwnMc7AJRFi32bNIf0 jBMLFAh1C8rAny2y2LdDGHOWWyXTFz6/k4O8jcPdylN82I5D25IWdzNvrj8Hm6UrT5f7TqYb esHKJu3FXgMPqcIjsbYPlCEJlkNZibFZcQnuGm59Js91bV9SsFF6iQRxp2uB6iMRhremhGG3 RiRxvxdwHcJKZ3xngHwzODWH8QpNJAZmAoOtGkbB1pViQ/LMm39gLnqEHqlWIQv7MG/8RMTt drdcCZeJsaP1Cb6GC3uDdsRhVLGPfmx868OZDGk8dPE8PVZ9eolcBvw7u6hjijYS9AmnEZd7 6dYbAgtRCgccP98/gGgy8Q4EthGk5Cl58JNJ25+VAKqWB4FnqgzexOOqmCztxkIpHBlZWOER PgmPfi6BkR2Cj88qYOEEFExZTWQOfjgrVfwozrZvhjEBeKxtg5YehGHkRDNITR6Z8emGAr2V NRbS33fGJxjcGJvOPlsfw5OOM8KZrCHLLqHHClsNHglnOTYSsEC2N1lt3N6wGXE8p83panFm ommjNVcwqNrlasMkbHwhV0OQte11wfqYLMkxs2MqYHiQxUcwJS3qEJ3OjbixXyr2e5dSvWwZ rJh218SOyTAQ4YrJFhAbe4fFIlZbLiqVpWjJxGQ2Crgvhr2CjSuNuhMZ7WHJDKyjYzhGjNvV ImKqv2nVzMCURl9ZVaso24Z6KpCaoW21d+7ezuQ9fnKOZbBYMOOUsx02E7vdbsV0pWuWx8j9 VoH9Z6mfalGYUGi49GrO4YwD6qf3l/9+5tzBw3sQshf7rD0fz419S41SEcMlqnKWLL704lsO L+BFXB+x8hFrH7HzEJEnjcAeBSxiFyInXRPRbrrAQ0Q+Yukn2FwpwrbeR8TGF9WGqyts8DzD MbnCOBJd1h9EydwTGgLcb9sU+Xoc8WDBEwdRBKsTnUmn9IqkB+Xz+MhwSntNpe00b2KaYnTF wjI1x8g9cRM+4vigd8LbrmYqaN8GfW0/JEGIXuQqD9LltW81vooSibZ9Zzhg2yhJc7AiLRjG PF4kEqbO6D74iGere9UKe6bhwAx2deCJbXg4cswq2qyYwh8lk6PxFTI2uwcZnwqmWQ6tbNNz Cxokk0y+CraSqRhFhAuWUIq+YGGm+5kTM1G6zCk7rYOIacNsX4iUSVfhddoxOJyD46F+bqgV J79wpZoXK3xgN6If4iVTNNU9myDkpDDPylTYGu1EuCYxE6UnbkbYDMHkaiDwyoKSkuvXmtxx GW9jpQwx/QeIMOBztwxDpnY04SnPMlx7Eg/XTOL60WZu0AdivVgziWgmYKY1TayZORWIHVPL evd7w5XQMJwEK2bNDkOaiPhsrdeckGli5UvDn2GudYu4jli1oci7Jj3y3bSN0Zud0ydpeQiD fRH7up4aoTqms+bFmlGMwKMBi/JhOakqOJVEoUxT58WWTW3LprZlU+OGibxg+1Sx47pHsWNT 263CiKluTSy5jqkJJot1vN1EXDcDYhky2S/b2GzbZ7KtmBGqjFvVc5hcA7HhGkURm+2CKT0Q uwVTTueO0kRIEXFDbRXHfb3lx0DN7Xq5Z0biKmY+0EYCyIS/IF6nh3A8DJpxyNXDHh6bOTC5 UFNaHx8ONRNZVsr63PRZLVm2iVYh15UVga9JzUQtV8sF94nM11ulVnDCFa4Wa2bVoCcQtmsZ Yn7Ckw0SbbmpZBjNucFGD9pc3hUTLnxjsGK4ucwMkFy3Bma55JYwsOOw3jIFrrtUTTTMF2qh vlwsuXlDMatovWFmgXOc7BacwgJEyBFdUqcBl8jHfM2q7vAGKDvO24aXniFdnlqu3RTMSaKC o79YOOZCU9+Ukw5epGqSZYQzVbowOj62iDDwEGvYvmZSL2S83BQ3GG4MN9w+4mZhpYqv1vqJ l4KvS+C5UVgTEdPnZNtKVp7VsmbN6UBqBg7CbbLldxDkBhkVIWLDrXJV5W3ZEacU6Ma+jXMj ucIjduhq4w3T99tTEXP6T1vUATe1aJxpfI0zBVY4OyoCzuayqFcBE/8lE+BSmV9WKHK9XTOL pksbhJxme2m3Ibf5ct1Gm03ELCOB2AbM4g+InZcIfQRTQo0zcmZwGFXAjJ7lczXctsw0Zqh1 yRdI9Y8Ts5Y2TMpSxMjIxjkh0kasP910YTvJPzi49u3ItPeLwJ4EtBplu5UdANWJRavUK/Ss 7silRdqo/MDDlcNZa69vHvWF/GlBA5MheoRtP04jdm2yVuz1u51ZzaQ7eJfvj9VF5S+t+2sm jTnRjYAHkTXmicS7l293X1/f7749v9/+BN5KVetREf/9TwZ7glytm0GZsL8jX+E8uYWkhWNo cHPXY193Nj1nn+dJXudAalRwBQLAQ5M+8EyW5CnDaHcwDpykFz6mWbDO5rVWl8LXPbRjOyca cI/LgjJm8W1RuPh95GKj9abLaM89LizrVDQMfC63TL5HJ2oME3PRaFR1QCan91lzf62qhKn8 6sK01OAH0g2tXcwwNdHa7Wrss7++P3+5A9+iv3MP0xobRi1zcS7sOUcpqn19D5YCBVN08x08 IJ60ai6u5IF6+0QBSKb0EKlCRMtFdzNvEICplrie2kktEXC21Cdr9xPtLMWWVqWo1vlPliXS zTzhUu271twe8VQLPCA3U9YrylxT6ArZv70+ff70+ru/MsAPzCYI3CQHBzEMYYyY2C/UOpjH ZcPl3Js9nfn2+a+nb6p0397f/vxduwnzlqLNtEi4QwzT78B5ItOHAF7yMFMJSSM2q5Ar0/dz bWxdn37/9ufXX/1FGtw9MCn4Pp0KreaIys2ybRFE+s3Dn09fVDPcEBN9Qt2CQmGNgpNXDt2X 9SmJnU9vrGMEH7twt964OZ0u6jIjbMMMcu5zUCNCBo8JLqureKzOLUOZp7H0IyN9WoJikjCh qjottWM+iGTh0ONtSF2716f3T799fv31rn57fn/5/fn1z/e746uqia+vyPJ2/Lhu0iFmmLiZ xHEApebls3tBX6Cysm/Z+ULpZ7ts3YoLaGtAEC2j9nzvszEdXD+JeQje9XpcHVqmkRFspWSN POaInvl2OFbzECsPsY58BBeVuS1wG4ZXME9qeM/aWNjP5s77124EcItxsd4xjO75HdcfEqGq KrHl3Rj1MUGNXZ9LDE+IusTHLGvADNdlNCxrrgx5h/MzuabuuCSELHbhmssVON5rCth98pBS FDsuSnOncskww+Vbhjm0Ks+LgEtq8OzPyceVAY3jZ4bQrn1duC675WLBS7J+jINhlE7btBzR lKt2HXCRKVW1474YH8VjRG4wW2Piagt4oKIDl8/ch/o2KEtsQjYpOFLiK23S1JmHAYsuxJKm kM05rzGoBo8zF3HVwWuvKCi8wQDKBldiuI3MFUm/iuDiegZFkRun1cduv2c7PpAcnmSiTe85 6ZjemHW54T41229yITec5CgdQgpJ686AzUeBu7S5Ws/VE2i5AcNMMz+TdJsEAd+TQSlguoz2 cMaVLn44Z01Kxp/kIpSSrQZjDOdZAa88uegmWAQYTfdxH0fbJUa1zcWWpCbrVaCEv7XNwY5p ldBg8QqEGkEqkUPW1jE346TnpnLLkO03iwWFCmFfeLqKA1Q6CrKOFotU7gmawq4xhsyKLOb6 z3SVjeNU6UlMgFzSMqmMoTt+JaPdboLwQL/YbjBy4kbPU63C9OX4vCl6k9TcBqX1HoS0yvS5 ZBBhsLzgNhwuweFA6wWtsrg+E4mCvfrxprXLRJv9hhbUXJHEGGzy4ll+2KV00O1m44I7ByxE fProCmBad0rS/e2dZqSast0i6igWbxYwCdmgWiouN7S2xpUoBbWrDT9KL1AobrOISIJZcazV eggXuoZuR5pfv3G0pqBaBIiQDAPwUjACzkVuV9V4NfSHn5++PX+etd/46e2zpfSqEHXMaXKt ccc/3jH8TjRgCMtEI1XHrispsz16KNv2lwBBJH6CBaA97PKhxyIgqjg7VfrmBxPlyJJ4lpG+ aLpvsuTofAAPo96McQxA8ptk1Y3PRhqj+gNpe2YB1DycClmENaQnQhyI5bB1uxJCwcQFMAnk 1LNGTeHizBPHxHMwKqKG5+zzRIE25E3eyYsCGqTPDGiw5MCxUtTA0sdF6WHdKkOe47Xv/l/+ /Prp/eX16/CKqLtlURwSsvzXCPEyAJh7y0ijMtrYZ18jhq7+aZ/61IeCDinacLtZMDngHtYx eKHGTnidJbb73Eyd8tg2q5wJZFALsKqy1W5hn25q1PXJoOMg92RmDJut6NobnoNCjx0AQd0f zJgbyYAj0z/TNMS71gTSBnO8ak3gbsGBtMX0laSOAe37SPD5sE3gZHXAnaJRi9wRWzPx2oZm A4buN2kMObUAZNgWzGshJWaOaglwrZp7YpqrazwOoo6KwwC6hRsJt+HI9RWNdSozjaCCqVZd K7WSc/BTtl6qCRO76R2I1aojxKmF59JkFkcYUzlDHjwgAqN6PJxFc8+8yAjrMuR5CgD8BOp0 sIDzgHHYo7/62fj0HRb2XjNvgKI58MXKa9raM05ctxESje0zh32NzHhd6CIS6kGuQyI92rdK XChlusIE9a4CmL69tlhw4IoB13Q4cq92DSjxrjKjtCMZ1HYpMqO7iEG3Sxfd7hZuFuAiLQPu uJD2nTANtmtkAzlizsfjbuAMpx/16801Dhi7EPIyYeGw44ER9ybhiGB7/gnFXWxwucLMeKpJ ndGH8eatc0W9iGiQ3ADTGHWCo8H77YJU8bDXRRJPYyabMltu1h1HFKtFwECkAjR+/7hVohrS 0HRENrfNSAWIfbdyKlDso8AHVi1p7NEJkDliaouXT2+vz1+eP72/vX59+fTtTvP6wPDtlyd2 qx0CEHNVDZlZYj6D+vtxo/yZ10SbmCg49II/YC282RRFalJoZexMJNRfk8HwBdMhlrwggq73 WM+D5k9ElThcgvuMwcK+f2nuPiJrGo1siNC6zpRmlGop7q3JEcW+kcYCEbdUFowcU1lR01px fDdNKHLdZKEhj7pawsQ4ioVi1Cxg242Nu8dunxsZcUYzzODtifngmgfhJmKIvIhWdPTgXGBp nDrM0iBxRqVHVeyIUKfjXp7RqjT1pWaBbuWNBK8c206XdJmLFTIyHDHahNpl1YbBtg62pNM0 tVmbMTf3A+5kntq3zRgbB3pmwgxr1+XWmRWqU2G8z9G5ZWTw9Vz8DWXMG355TR4bmylNSMro jWwn+IHWF3VROR6MDdI6exK7tbKdPnaN1yeIbnrNxCHrUiW3Vd6iq19zgEvWtGftmq+UZ1QJ cxgwMtM2ZjdDKSXuiAYXRGFNkFBrW8OaOVihb+2hDVN48W5xySqyZdxiSvVPzTJm4c5SetZl maHb5kkV3OKVtMDGNhuEbDdgxt50sBiydJ8ZdwfA4mjPQBTuGoTyRehsLMwkUUktSSWLcMys 2ALT9TVm1t5v7LU2YsKAbU/NsI1xEOUqWvF5wOrgjJtFr5+5rCI2F2ZNzDGZzHfRgs0EXJcJ NwHbH9RUuOarnJm8LFLpWhs2/5pha107AeGTItoLZviadVQbTG1Zic3NbO6j1vYrRzPlrjUx t9r6PiOLUcqtfNx2vWQzqam196sdP1Q6S1JC8R1LUxu2lzjLWUqxle8uuCm386W2wZfyKBfy cQ6bVlj/w/xmyyepqO2OTzGuA9VwPFevlgGfl3q7XfFNqhh+Yizqh83OIz7tOuIHI+puDTMr vmEUs/Wmw7czXRVZzD7zEJ5R391ksLjD+WPqmWHry3a74DuDpvgiaWrHU7bfyRnWJhlNXZy8 pCwSCODn0fO7M+nsWFgU3rewCLp7YVFKlWVxslkyMzIsarFgBQkoycuYXBXbzZoVC+pNx2Kc bRCLy49g/MA2ilG191UFvj79AS5NetifD/4A9dXzNdHXbUovMfpLYe+yWbwq0GLNzqqK2oZL tlfDXcpgHbH14G4tYC6MeHE3Wwh8t3e3IijHj8jutgThAn8Z8MaFw7HCazhvnZG9CcLteJ3N 3adAHNl5sDjqx8xa7jivEFjLJXybbCboghkzvBZAF96IQcvhhu5cKqCwh9o8sz207uuDRrT7 yRB9pU1h0JI2a/oynQiEq8HLg69Z/MOFj0dW5SNPiPKx4pmTaGqWKdQ69H6fsFxX8N9kxqMW V5KicAldT5cstl3TKEy0mWqjorJf91ZxpCX+fcq61SkJnQy4OWrElRbtbBtjQLhWrboznOkD nNrc4y/BSBAjLQ5Rni9VS8I0adKINsIVb2/jwO+2SUXx0Ra2rBnffHCylh2rps7PR6cYx7Ow t8MU1LYqEPkcOy/U1XSkv51aA+zkQkqoHezDxcVAOF0QxM9FQVzd/MQrBlsj0cmrqsYeobNm eACBVIFxb98hDO7H25CK0N7ChlYCE16MpE2GLhONUN82opRF1ra0y5GcaLtylGi3r7o+uSQo mO1IN3aOWAApqxY82DcYre13nbUxq4btcWwI1qdNA2vc8gP3gWMzqDNhTBYwaCxpRcWhxyAU DkV8VEJi5m1XpR/VhLAPeA2AnhcEiLyao0OlMU1BIagS4MiiPucy3QKP8UZkpRLVpLpiztSO UzMIVsNIjkRgZPdJc+nFua1kmqf6He35zbxxd/L9P3/YHtaH1hCFNvHgk1X9P6+OfXvxBQCr ZXglxB+iEfAIga9YCWM/aqjx8Sofr/0Xzxx+VQ4XefzwkiVpRSxiTCUYh3u5XbPJZT92C12V l5fPz6/L/OXrn3/dvf4Bu75WXZqYL8vckp4Zw1vnFg7tlqp2s4dvQ4vkQjeIDWE2h4ushAWE 6uz2dGdCtOfSLodO6EOdqvE2zWuHOaHHTDVUpEUI7rBRRWlG24n1ucpAnCOrFsNeS+Q5W2dH Kf9wn41BEzBHo+UD4lLou8+eT6CtsqPd4lzLWNL/6fXr+9vrly/Pb2670eaHVvcLh5p7H84g dqbBjHnol+enb89wq0rL229P73CJTmXt6ecvz5/dLDTP/++fz9/e71QUcBsr7VSTZEVaqk6k 40NSzGRdB0pefn15f/py117cIoHcFkjPBKS0HcnrIKJTQibqFvTKYG1TyWMptI0LCJnEnyVp ce5gvINb4GqGlOCK7ojDnPN0kt2pQEyW7RFqOt025TM/7355+fL+/Kaq8enb3Td9gg1/v9/9 z4Mm7n63P/6f1iVTsLzt0xTbxJrmhCF4HjbMtbbnnz89/T6MGdgid+hTRNwJoWa5+tz26QX1 GAh0lHUsMFSs1vYulc5Oe1ms7Q17/WmOXsCdYuv3afnA4QpIaRyGqDP79euZSNpYoh2ImUrb qpAcofTYtM7YdD6kcO/sA0vl4WKx2scJR96rKOOWZaoyo/VnmEI0bPaKZgeOYNlvyut2wWa8 uqxsD3+IsH2oEaJnv6lFHNr7vYjZRLTtLSpgG0mmyKuMRZQ7lZJ9BEQ5trBKccq6vZdhmw/+ g/xfUorPoKZWfmrtp/hSAbX2phWsPJXxsPPkAojYw0Se6gMPLaxMKCZAL/falOrgW77+zqVa e7Gy3K4Dtm+2lRrXeOJco0WmRV22q4gVvUu8QM/lWYzqewVHdFmjOvq9WgaxvfZjHNHBrL5S 5fgaU/1mhNnBdBht1UhGCvGxidZLmpxqimu6d3Ivw9A+tDJxKqK9jDOB+Pr05fVXmKTgcSdn QjBf1JdGsY6mN8D0fV1MIv2CUFAd2cHRFE+JCkFBLWzrheMVDLEUPlabhT002WiPVv+IySuB dlroZ7peF/1ouWhV5I+f51n/RoWK8wIdZdsoq1QPVOPUVdyFUWBLA4L9H/Qil8LHMW3WFmu0 L26jbFwDZaKiOhxbNVqTsttkAGi3meBsH6kk7D3xkRLIjsP6QOsjXBIj1WtHAI/+EExqilps uATPRdsjc7yRiDu2oBoelqAuCzfJOy51tSC9uPil3ixs76Y2HjLxHOttLe9dvKwuajTt8QAw knp7jMGTtlX6z9klKqX927rZ1GKH3WLB5NbgzobmSNdxe1muQoZJriGyP5vqONP+3/uWzfVl FXANKT4qFXbDFD+NT2Umha96LgwGJQo8JY04vHyUKVNAcV6vOdmCvC6YvMbpOoyY8Gkc2E6d J3FQ2jjTTnmRhisu2aLLgyCQB5dp2jzcdh0jDOpfec/0tY9JgJ5HBFxLWr8/J0e6sDNMYu8s yUKaBBrSMfZhHA73mGp3sKEsN/IIacTKWkf9LxjS/vmEJoD/ujX8p0W4dcdsg7LD/0Bx4+xA MUP2wDSTMxP5+sv7v5/enlW2fnn5qhaWb0+fX175jGpJyhpZW80D2EnE980BY4XMQqQsD/tZ akVK1p3DIv/pj/c/VTa+/fnHH69v77R2ivSR7qkoTT2v1vghjFaEXRDAHQJn6rmutmiPZ0DX zowLmD7Nc3P349OkGXnymV1aR18DTElN3aSxaNOkz6q4zR3dSIfiGvOwZ2Md4P5QNXGqlk4t DXBKu+xcDM/0eciqyVy9qegcsUnaKNBKo7dOfvztPz+/vXy+UTVxFzh1DZhX69iiG3NmJxb2 fdVa3imPCr9C7lQR7Eliy+Rn68uPIva5EvR9Zt9MsVimt2ncOGVSU2y0WDkCqEPcoIo6dTY/ 9+12SQZnBbljhxRiE0ROvAPMFnPkXBVxZJhSjhSvWGvW7XlxtVeNiSXK0pPhyV3xWUkYuu2h x9rLJggWfUY2qQ3MYX0lE1JbesIgxz0zwQfOWFjQucTANVxgvzGP1E50hOVmGbVCbiuiPMDj QVRFqtuAAvZ1AlG2mWQKbwiMnaq6pscB5REdG+tcJPRWvI3CXGA6AeZlkcH7zCT2tD3XYMjA CFpWnyPVEHYdmHOVaQuX4G0qVhtksWKOYbLlhu5rUAyuZFJs/ppuSVBsPrYhxBitjc3Rrkmm imZL95sSuW/op4XoMv2XE+dJNPcsSPYP7lPUplpDE6Bfl2SLpRA7ZJE1V7PdxRHcdy1yC2oy oUaFzWJ9cr85qNnXaWDu/othzDUaDt3aA+IyHxilmA/X9h1pyezx0EDgWqulYNM26DzcRnut 2USLXzjSKdYAjx99IlL9EZYSjqxrdPhktcCkmuzR1peNDp8sP/FkU+2dyi2ypqrjApl5muY7 BOsDMhu04MZtvrRplOoTO3hzlk71atBTvvaxPlW2xoLg4aP5HAezxVlJV5M+/LTdKM0Uh/lY 5W2TOX19gE3E4dxA45kYbDup5SscA03uE8GFJFyG0ecxvkNS0G+WgTNltxd6XBM/Kr1Ryv6Q NcUVuWIezwNDMpbPOLNq0HihOnZNFVDNoKNFNz7fkWToPcYke310qrsxCbLnvlqZWK49cH+x ZmNY7slMlEqKk5bFm5hDdbru1qU+221rO0dqTJnGeWdIGZpZHNI+jjNHnSqKejA6cBKazBHc yLSfPw/cx2rF1bibfhbbOuzojO9SZ4c+yaQqz+PNMLGaaM+OtKnmXy9V/cfI4cdIRauVj1mv 1KibHfxJ7lNftuBSrBJJ8NR5aQ6OrjDTlKGv7Q0idILAbmM4UHF2alF76GVBXorrToSbvyhq XnYXhXSkSEYxEG49GePhBD1DaJjRx12cOgUYDYGMZ45lnznpzYxvZ31VqwGpcBcJCldKXQbS 5olVf9fnWevI0JiqDnArU7UZpnhJFMUy2nRKcg4OZRyC8ijp2jZzaZ1yatfm0KNY4pI5FWb8 3mTSiWkknAZUTbTU9cgQa5ZoFWorWjA+TUYsnuGpSpxRBjzRX5KKxevO2VeZfDl+YFaqE3mp 3X40ckXij/QC5q3u4DmZ5oA5aZMLd1C0rN36Y+j2dovmMm7zhXsYBT46UzAvaZys496FXduM nTbr9zCoccTp4q7JDeybmIBO0rxlv9NEX7BFnGgjHL4R5JDUzrbKyH1wm3X6LHbKN1IXycQ4 Pi7QHN1TI5gInBY2KD/A6qH0kpZnt7b02wa3BEcHaCp43pNNMim4DLrNDN1RkoMhv7qg7ey2 YFGEHzZLmu/qGHrMUdxhVECLIv4RPMfdqUjvnpxNFK3qgHKLNsJhtNDGhJ5ULsxwf8kumdO1 NIhtOm0CLK6S9CJ/Wi+dBMLC/WYcAHTJDi9vz1f1/7t/Zmma3gXRbvlfnm0ipS+nCT0CG0Bz uP6Tay5pO7w30NPXTy9fvjy9/Yfx12Z2JNtW6EWaeWWiuVMr/FH3f/rz/fWHyWLr5//c/U+h EAO4Mf9PZy+5GUwmzVnyn7Av//n50+tnFfh/3f3x9vrp+du317dvKqrPd7+//IVyN64niD+K AU7EZhk5s5eCd9ule6CbiGC327iLlVSsl8HKlXzAQyeaQtbR0j0ujmUULdyNWLmKlo6VAqB5 FLodML9E4UJkcRg5iuBZ5T5aOmW9Flv0xuKM2u+JDlJYhxtZ1O4GK1wO2beH3nDzExp/q6l0 qzaJnALSxlOrmvVK71FPMaPgs0GuNwqRXMCdr6N1aNhRWQFebp1iArxeODu4A8x1daC2bp0P MPfFvt0GTr0rcOWs9RS4dsB7uQhCZ+u5yLdrlcc1vycdONViYFfO4Vr2ZulU14hz5Wkv9SpY Mut7Ba/cHgbn7wu3P17DrVvv7XW3W7iZAdSpF0Ddcl7qLjIPLVsiBJL5hASXkcdN4A4D+oxF jxrYFpkV1OevN+J2W1DDW6ebavnd8GLtdmqAI7f5NLxj4VXgKCgDzEv7LtrunIFH3G+3jDCd 5NY8PUlqa6oZq7ZefldDx38/w7Msd59+e/nDqbZznayXiyhwRkRD6C5O0nHjnKeXH02QT68q jBqwwKcLmyyMTJtVeJLOqOeNwRw2J83d+59f1dRIogU9B14YNa03e+0i4c3E/PLt07OaOb8+ v/757e635y9/uPFNdb2J3K5SrEL0nvMw27q3E5Q2BKvZRPfMWVfwp6/zFz/9/vz2dPft+asa 8b3GXnWblXC9I3cSLTJR1xxzylbucAjvBQTOGKFRZzwFdOVMtYBu2BiYSiq6iI03ck0Kq0u4 dpUJQFdODIC605RGuXg3XLwrNjWFMjEo1Blrqgt+GXwO6440GmXj3THoJlw544lCkb+RCWVL sWHzsGHrYctMmtVlx8a7Y0scRFtXTC5yvQ4dMSnaXbFYOKXTsKtgAhy4Y6uCa3TZeYJbPu42 CLi4Lws27gufkwuTE9ksokUdR06llFVVLgKWKlZF5ZpzNB9Wy9KNf3W/Fu5KHVBnmFLoMo2P rta5ul/thbsXqMcNiqbtNr132lKu4k1UoMmBH7X0gJYrzF3+jHPfauuq+uJ+E7ndI7nuNu5Q pdDtYtNfYvQWF0rTrP2+PH37zTucJuD3xKlCcKXnGgCDVyF9hjClhuM2U1Wd3ZxbjjJYr9G8 4HxhLSOBc9epcZeE2+0CLi4Pi3GyIEWf4XXneL/NTDl/fnt//f3lfz+D6YSeMJ11qg7fy6yo kQ9Bi4Nl3jZEbu8wu0UTgkMih5JOvLY/JsLuttuNh9QnyL4vNen5spAZGjoQ14bY1zjh1p5S ai7ycqG9LCFcEHny8tAGyBjY5jpysQVzq4VrXTdySy9XdLn6cCVvsRv3lqlh4+VSbhe+GgD1 be1YbNkyEHgKc4gXaOR2uPAG58nOkKLny9RfQ4dY6Ui+2ttuGwkm7J4aas9i5xU7mYXByiOu WbsLIo9INmqA9bVIl0eLwDa9RLJVBEmgqmjpqQTN71VplmgiYMYSe5D59qz3FQ9vr1/f1SfT bUXtCvLbu1pGPr19vvvnt6d3pSS/vD//190vVtAhG9r8p90vtjtLFRzAtWNtDReHdou/GJBa fClwrRb2btA1muy1uZOSdXsU0Nh2m8jIvHfOFeoTXGe9+//cqfFYrW7e317AptdTvKTpiOH8 OBDGYUIM0kA01sSKqyi32+Um5MApewr6Qf6dulZr9KVjHqdB2y+PTqGNApLox1y1SLTmQNp6 q1OAdv7GhgptU8uxnRdcO4euROgm5SRi4dTvdrGN3EpfIC9CY9CQmrJfUhl0O/r90D+TwMmu oUzVuqmq+DsaXriybT5fc+CGay5aEUpyqBS3Us0bJJwSayf/xX67FjRpU196tp5ErL3759+R eFlvkSPSCeucgoTO1RgDhow8RdTkselI98nVam5LrwbocixJ0mXXumKnRH7FiHy0Io063i3a 83DswBuAWbR20J0rXqYEpOPomyIkY2nMDpnR2pEgpW+GC+reAdBlQM089Q0NejfEgCELwiYO M6zR/MNVif5ArD7N5Q64V1+RtjU3kJwPBtXZltJ4GJ+98gn9e0s7hqnlkJUeOjaa8WkzJipa qdIsX9/ef7sTavX08unp64/3r2/PT1/v2rm//BjrWSNpL96cKbEMF/QeV9WsgpDOWgAGtAH2 sVrn0CEyPyZtFNFIB3TFora7OAOH6P7k1CUXZIwW5+0qDDmsd87gBvyyzJmIg2ncyWTy9wee HW0/1aG2/HgXLiRKAk+f/+P/KN02Br+/3BS9jKYLJOMNRyvCu9evX/4z6FY/1nmOY0U7f/M8 AxcKF3R4tajd1BlkGo8+M8Y17d0valGvtQVHSYl23eMH0u7l/hRSEQFs52A1rXmNkSoBF79L KnMapF8bkHQ7WHhGVDLl9pg7UqxAOhmKdq+0OjqOqf69Xq+Imph1avW7IuKqVf7QkSV9MY9k 6lQ1ZxmRPiRkXLX0LuIpzY29tVGsjcHo/BLFP9NytQjD4L9s1yfOBsw4DC4cjalG+xI+vd28 Wf/6+uXb3Tsc1vz385fXP+6+Pv/bq9Gei+LRjMRkn8I9JdeRH9+e/vgNntpwbgSJozUDqh+9 KBLbgBwg/cAPhpBVGQCXzPbMpl8EOra2xd9R9KLZO4A2QzjWZ9vpC1DymrXxKW0q21da0cHN gwt9qyFpCvTDWL4l+4xDJUETVeRz18cn0aAb/poDk5a+KDhUpvkBzDQwd19Ix6/RiB/2LGWi U9koZAu+FKq8Oj72TWobGEG4g/bNlBbg3hHdFZvJ6pI2xjA4mM2qZzpPxX1fnx5lL4uUFAou 1fdqSZow9s1DNaEDN8DatnAAbRFYiyO8e1jlmL40omCrAL7j8GNa9PoRQk+N+jj4Tp7AMI1j LyTXUsnZ5CgAjEaGA8A7NVLzG4/wFdwfiU9KhVzj2My9khxdtBrxsqv1NtvOPtp3yBU6k7yV IaP8NAVzWx9qqCpSbVU4HwxaQe2QjUhSKlEG0+821C2pQTVGHG2Dsxnrafca4Di7Z/Eb0fdH eEB7trUzhY3ru38aq474tR6tOf5L/fj6y8uvf749gY0/rgYVGzx0hurhb8UyKA3f/vjy9J+7 9OuvL1+fv5dOEjslUVh/SmwbPNPh79OmVIOk/sLySnUjtfH7kxQQMU6prM6XVFhtMgCq0x9F /NjHbed6rhvDGNO9FQur/2qnCz9FPF0UZzYnPbiqzLPjqeVpSbthtkP37gdkvFWrL8X84x8O PRgfG/eOzOdxVZhrG74ArARq5nhpebS/vxTH6cbk57fff3xRzF3y/POfv6p2+5UMFPAVvUSI cFWHtmXYRMqrmuPhyoAJVe0/pHErbwVUI1l83yfCn9TxHHMRsJOZpvLqqmTokmqfn3FaV2py 5/Jgor/sc1He9+lFJKk3UHMu4U2cvkYHTUw94vpVHfWXF7V+O/758vn58131x/uLUqaYnmjk RlcIpAM3D2DPaMG2vRZu46ryLOu0TH4KV27IU6oGo30qWq3bNBeRQzA3nJK1tKjbKV2lbTth QOMZPfftz/LxKrL2py2XP6nUAbsITgDgZJ6BiJwboxYETI3eqjk0Mx6pWnC5L0hjG3PqSWNu 2phMOybAahlF2ilyyX2udLGOTssDc8mSyZlhOljiaJOo/dvL51/pHDd85Gh1A35KCp4wr+eZ RdqfP//gqvRzUGS0buGZfcZr4fg6hkVoU2Y6Bg2cjEXuqRBkuG70l+vx0HGY0vOcCj8W2FXa gK0ZLHJApUAcsjQnFXBOiGIn6MhRHMUxpJEZ8+gr0yiayS8JEbWHjqSzr+ITCQNvT8HdSaqO 1KLUaxY0iddPX5+/kFbWAdVKBMzUG6n6UJ4yMakinmX/cbFQXbtY1au+bKPVarfmgu6rtD9l 8MJJuNklvhDtJVgE17OaEHM2Frc6DE4PjmcmzbNE9PdJtGoDtCKeQhzSrMvK/l6lrBZT4V6g bV472KMoj/3hcbFZhMskC9ciWrAlyeD+0L36ZxeFbFxTgGy33QYxG6Qsq1wtwerFZvfRdq84 B/mQZH3eqtwU6QIft85h7rPyONxQU5Ww2G2SxZKt2FQkkKW8vVdxnaJgub5+J5xK8pQEW7Tr MjfIcM8kT3aLJZuzXJH7RbR64Ksb6ONytWGbDNzql/l2sdyecrQFOYeoLvqGjpbIgM2AFWS3 CFhxq3I1lXR9HifwZ3lWclKx4ZpMpvrec9XCe2w7tr0qmcD/lZy14Wq76VcR1RlMOPVfAW4e 4/5y6YLFYREtS751GyHrvdLhHtUavq3OahyI1VRb8kEfE3Cp0hTrTbBj68wKsnXGqSFIFd/r cn44LVabckFOuaxw5b7qG/AxlkRsiOkK0zoJ1sl3gqTRSbBSYgVZRx8W3YIVFxSq+F5a261Y qKWEBB9dhwVbU3ZoIfgI0+y+6pfR9XIIjmwA/Q5D/qDEoQlk50nIBJKLaHPZJNfvBFpGbZCn nkBZ24DrUKU+bTZ/I8h2d2HDwJ0CEXfLcCnu61shVuuVuC+4EG0NlzYW4bZVosTmZAixjIo2 Ff4Q9THgu3bbnPPHYTba9NeH7sh2yEsmlXJYdSDxO3yyO4VRXV7pv8e+q+vFahWHG7R5SeZQ NC1TlyPzRDcyaBqe91dZnS5OSkaji0+qxWBbETZd6PQ2jvsKAt+9VMmCubQnFxiNeqPWxqes VvpXm9QdvAJ2TPv9drW4RP2BzArlNfdsIcLOTd2W0XLtNBHsovS13K7d2XGi6KQhMxDQbIve hDNEtsPOAQcwjJYUBCWBbZj2lJVK+zjF60hVS7AIyadqHXTK9mK4U0F3sQi7ucluCatG7kO9 pHIMd/bK9UrV6nbtflAnQSgXdGfAOGFU/VeU3RpdT6LsBrljQmxCOjVswjl3DghBXxWmtLNH yuq7A9iL056LcKSzUN6iTVpOB3V7F8psQbce4TaxgG1j2I2iN/zHEO2FLucVmCd7F3RLm4Gf oowuYiKiT17ipQPY5bQXRm0pLtmFBZVkp00h6AKliesjWSEUnXSAAylQnDWN0vsfUrrJdSyC 8BzZHbTNykdgTt02Wm0SlwAVOLQP82wiWgY8sbQ7xUgUmZpSoofWZZq0FmjDeyTURLfiooIJ MFqR8bLOA9oHlAA4ilJH9S8F9Ac9TJe0dfdVp811ycCcFe50pWKg60njKaJ3lr1FTLeZ2iyR pF3NDigJltComiAk41W2pUNVQSdXdAxmlqM0hLgIOgSnnXk7BZ4QSyWvGSs9Gx5h0M8aPJyz 5p4WKgPHUGWiPdQYs+y3p9+f737+85dfnt/uEnogcNj3cZEozd7Ky2FvntV5tCHr7+EgSB8L oa8Se59b/d5XVQtGHcy7LZDuAe775nmDvOoPRFzVjyoN4RBKMo7pPs/cT5r00tdZl+bw0EG/ f2xxkeSj5JMDgk0OCD451URpdix7Jc+ZKEmZ29OM/193FqP+MQS8qPH19f3u2/M7CqGSadX0 7AYipUC+gaDe04NaAmnHlQg/pfF5T8p0OQolIwgrRAyPueE4mW16CKrCDYdnODjsj0A1qfHj yEreb09vn40bU7qnBs2nx1MUYV2E9LdqvkMFc9GgzmEJyGuJ74ZqYcG/40e1VsS2AjbqCLBo 8O/YvLGCwyi9TDVXSxKWLUZUvdsrbIWcoWfgMBRIDxn6XS7t8Rda+Ig/OO5T+huccfy0tGvy 0uCqrZR6DyfnuAFkkOgHcHFhwRsKzhJszAoGwvf1ZpgcecwEL3FNdhEO4MStQTdmDfPxZuhq FnS+dKsW9Fvc3qJRI0YFI6rt5033GSUIHQOpSVipTGV2LljyUbbZwznluCMH0oKO8YhLiscd elY7QW5dGdhT3YZ0q1K0j2gmnCBPRKJ9pL/72AkCby6lTRbDBpPLUdl79KQlI/LT6ch0up0g p3YGWMQxEXQ0p5vffURGEo3ZixLo1KR3XPRzZDALwellfJAO2+nTSTXH72GXFFdjmVZqRspw nu8fGzzwR0iNGQCmTBqmNXCpqqSq8DhzadWyE9dyqxaRKRn2kDNLPWjjb1R/KqiqMWBKexEF HBDm9rSJyPgs26rg58VrsUVvuGiohWV7Q2fLY4qe/xqRPu8Y8MiDuHbqTiAzWkg8oKJxUpOn atAURB1XeFuQeRsA01pEBKOY/h6PTtPjtcmoxlOgF280IuMzEQ10agMD414tY7p2uSIFOFZ5 csgkHgYTsSUzBBy8nO11llb+tZ2RuwSAAS2FLbeqIEPiXskbiXnAtPPdI6nCkaOyvG8qkchT mmI5PT0qBeaCq4acnwAkweh5Q2pwE5DZE/zYuchoDsYovoYvz2B/JWf7iflL/VRXxn2EFjHo A3fEJtzB92UMj8ap0ShrHsA/e+tNoc48jJqLYg9lVurER90QYjmFcKiVnzLxysTHoG04xKiR pD+AB9gUXo2//2nBx5ynad2LQ6tCQcFU35LpZNUB4Q57s9upj5+Hs+jxLTik1ppIQblKVGRV LaI1JyljALoL5gZwd72mMPG4xdknF64CZt5Tq3OA6TVNJpRZhfKiMHBSNXjhpfNjfVLTWi3t s69ps+q71TvGCu45sYu2EWFfyZxI9AQxoNNm+uli69JA6UXvfAWZW0drmdg/ffrXl5dff3u/ +x93anAfH/V0bGrhEM08xGdegJ5TAyZfHhaLcBm29gmOJgoZbqPjwZ7eNN5eotXi4YJRs53U uSDalQKwTapwWWDscjyGyygUSwyPHs4wKgoZrXeHo23qOGRYTTz3B1oQswWGsQocZIYrq+Yn Fc9TVzNvXDPi6XRmB82So+DWuX1UYCXJK/xzgPpacHAidgv7eihm7MtLMwOWADt7488qWY3m opnQfvOuue0ddSalOImGrUn6gryVUlKvVrZkIGqL3nYk1Ialttu6UF+xidXxYbVY8zUvRBt6 ogR3ANGCLZimdixTb1crNheK2di3HWematFeppVx2FHjq1beP26DJd/CbS3Xq9C+JmiVV0Yb ezFvCS56GdrK90U11CavOW6frIMFn04Td3FZclSjFpG9ZOMzEjaNfd8Z4cbv1QgqGbeM/KbR MA0NFyy+fnv98nz3eTirGNzzue+UHLX3a1nZvUOB6q9eVgfVGjGM/Pg1dJ5XCt/H1PZxyIeC PGdSaa3t+EzI/nEyfZ2SMBcvnJwhGPSsc1HKn7YLnm+qq/wpnKxtD2rJo/S2wwGusNKYGVLl qjWLyqwQzePtsNrmDN0W4GMc9hVbcZ9WxgXpfGvldptNg3xlP/QOv3ptR9LjpwssguyUWUyc n9swRJfhnRss42eyOtsrDf2zryR9VwPjYKepZp3MGuMlikWFBdvKBkN1XDhAj8zjRjBL453t uQfwpBBpeYRVrhPP6ZqkNYZk+uBMiYA34lpktlIM4GTlXB0OcJMDsx9QNxmR4WFLdOlFmjqC SyYY1PaaQLlF9YHwSooqLUMyNXtqGND38LPOkOhgEk/UuipE1TY8TK8Wsfgdc514U8X9gcSk xH1fydTZpMFcVrakDslCbILGj9xyd83Z2XHTrdfm/UWA9R7uqjoHhRpqnYrRPv5VJ3ZE5gxW zw0jSTACeUK7LQhfDC3ijoFjAJDCPr2grSGb833hyBZQl6xxvynq83IR9GfRkCSqOo96dLox oEsW1WEhGT68y1w6Nx4R7zbUhkS3BfXSa1pbku7MNIBafFUkFF8NbS0uFJK2ZYapxSYTeX8O 1ivbc9BcjySHqpMUogy7JVPMurqCmxRxSW+Sk2ws7EBXeIOd1h68cEg2Bwy8VetIOvLtg7WL ojdhdGYSt42SYBusnXABeqXLVL1E+3Ya+9gGa3vtNYBhZM9SExiSz+Mi20bhlgEjGlIuwyhg MJJMKoP1dutgaCNO11eMPSkAdjxLvarKYgdPu7ZJi9TB1YhKahxuOlwdIZhgcB1Cp5WPH2ll Qf+TtkmjAVu1eu3Ythk5rpo0F5F8wts4jli5IkURcU0ZyB0MtDg6/VnKWNQkAqgUvfdJ8qf7 W1aWIs5ThmIbCr1LNorxdkewXEaOGOdy6YiDmlxWyxWpTCGzE50h1QyUdTWH6SNhoraI8xbZ SIwY7RuA0V4grkQmVK+KnA60b5HTkgnSV13jvKKKTSwWwYI0daxfNyOC1D0e05KZLTTu9s2t 21/XtB8arC/Tqzt6xXK1cscBha2IgZfRB7oDyW8imlzQalXalYPl4tENaL5eMl8vua8JqEZt MqQWGQHS+FRFRKvJyiQ7VhxGy2vQ5AMf1hmVTGACK7UiWNwHLOj26YGgcZQyiDYLDqQRy2AX uUPzbs1ik5d7lyGPxQFzKLZ0stbQ+IYeWNsQDepk5M0Y2b5+/Z/v4GXi1+d3cCfw9Pnz3c9/ vnx5/+Hl690vL2+/g3GGcUMBnw3LOcsB8BAf6epqHRKgE5EJpOKiL/9vuwWPkmjvq+YYhDTe vMqJgOXderleps4iIJVtU0U8ylW7Wsc42mRZhCsyZNRxdyJadJOpuSehi7EijUIH2q0ZaEXC 6WsPl2xPy+Qctxq9UGxDOt4MIDcw68O5ShLJunRhSHLxWBzM2Khl55T8oG9FU2kQVNwE9Qkx wsxCFuAmNQAXDyxC9yn31czpMv4U0AD6cU/tusBZTybCKOsqaXiq9t5H0+fcMSuzYyHYghr+ QgfCmcKnL5ijZlCErcq0E1QELF7NcXTWxSyVScq685MVQjsm9FcIfiB3ZJ1N+KmJuNXCtKsz CZybWpO6kals32jtolYVx1Ubvlk+okoP9iRTg8wo3cJsHYaL5dYZyfryRNfEBk/MwZQj6/DS WMcsK6WrgW2iOAwiHu1b0cCztvushXccf1ra94YhIHo1fQCoETmC4RL09Iqie6A2hj2LgM5K GpZd+OjCscjEgwfmhmUTVRCGuYuv4a0YFz5lB0H3xvZxEjq6LwQGu9e1C9dVwoInBm6VcOET /pG5CLXyJmMz5Pnq5HtEXTFInH2+qrMvoGgBk9ggaoqxQtbBuiLSfbX3pK3Upwy5OENsK9TC pvCQRdWeXcpthzouYjqGXLpaaespyX+daCGM6U5WFTuA2X3Y03ETmNG47MYOKwQbd0ldZnS7 wyVKO6hGne0tA/ai09c2/KSsk8wtrOWkhCHij0qD34TBruh2cLIKhrwnb9CmBU/7N8KodKK/ eKq56M+34Y3Pm7SsMrrFiDjmY3OE6zTrBCtB8FLonS9MSen9SlG3IgWaiXgXGFYUu2O4MK8Q 0WXzFIdidwu6f2ZH0a2+E4Ne+if+OinolDqTrJQV2X1T6a3sloz3RXyqx+/UDxLtPi5CJVn+ iOPHY0l7nvpoHWlbLNlfT5lsnYkjrXcQwGn2JFVDWanvFjipWZzpxMZJw2s8POYEC5fD2/Pz t09PX57v4vo8+T0evLfNQYcXf5lP/h+s4Up9LACX/Btm3AFGCqbDA1E8MLWl4zqr1qM7dWNs 0hObZ3QAKvVnIYsPGd1TH7/ii6QvfcWF2wNGEnJ/pivvYmxK0iTDkRyp55f/u+jufn59evvM VTdElkp3x3Tk5LHNV85cPrH+ehJaXEWT+AuWoTfCbooWKr+S81O2DoOFK7UfPi43ywXff+6z 5v5aVcysZjPggkIkItos+oTqiDrvRxbUucrotrrFVVTXGsnp0p83hK5lb+SG9UevBgS4XFuZ DWO1zFKTGCeKWm2WxveddjREwigmq+mHBnR3SUeCn7bntL7D3/rU9Y+Hw5yEvCKD3jFfoq0K UFuzkLGzuhGILyUX8Gap7h9zce/NtbxnRhBDidpL3e+91DG/91Fx6f0qPvipQtXtLTJn1CdU 9v4giixnlDwcSsISzp/7MdjJqK7cmaAbmD38GtTLIWgBmxm+eHh1zHDgxao/wH3BJH9U6+Py 2JeioPtKjoDejHOfXLUmuFr8rWAbn046BAPr7O+n+djGjVFfv5PqFHAV3AwYg8WUHLLo02nd oF7tGQcthFLHF7sF3FP/O+FLfTSy/F7RdPi4CxebsPtbYfXaIPpbQWHGDdZ/K2hZmR2fW2HV oKEqLNzejhFC6bLnodIwZbFUjfH3P9C1rBY94uYnZn1kBWY3pKxSdq37ja+T3vjkZk2qD1Tt 7La3C1sdYJGwXdwWDDXSatlcRyb1XXi7Dq3w6p9VsPz7n/0fFZJ+8LfzdbuLgwiMO37j6p4P X7T3/b6NL3Jy4SpAo7N1UvH7l9dfXz7d/fHl6V39/v0bVkfVUFmVvcjI1sYAd0d9HdXLNUnS +Mi2ukUmBdwvVsO+Y9+DA2n9yd1kQYGokoZIR0ebWWMW56rLVghQ827FALw/ebWG5ShIsT+3 WU5PdAyrR55jfmaLfOy+k+1jEApV94KZmVEA2KJvmSWaCdTuzAWM2Wvs9+UKJdVJfh9LE+zy ZtgkZr8Ci3AXzWswnY/rs4/yaJoTn9UP28WaqQRDC6Ad2wnY3mjZSIfwvdx7iuAdZB9UV19/ l+XUbsOJwy1KjVGMZjzQVERnqlGCby66819K75eKupEmIxSy2O7owaGu6KTYLlcuDv7JwHeR n+F3cibW6ZmI9aywJ35Ufm4EMaoUE+Berfq3gwcc5vhtCBPtdv2xOffUwHesF+OYjBCDtzJ3 +3d0Y8YUa6DY2pq+K5J7ffd0y5SYBtrtqG0eBCpE01LTIvqxp9atiPmdbVmnj9I5nQamrfZp U1QNs+rZK4WcKXJeXXPB1bjxWgHX3pkMlNXVRaukqTImJtGUiaC2UHZltEWoyrsyx5w3dpua 56/P356+AfvN3WOSp2V/4LbawN/oT+wWkDdyJ+6s4RpKodxpG+Z69xxpCnB2DM2AUTqiZ3dk YN0tgoHgtwSAqbj8K9wYMWuH21yH0CFUPiq4XencerWDDSuIm+TtGGSr9L62F/vMeLb25scx qR4p4z18WstUXBeZC60NtMHp8q1Ao024uymFgpmU9SZVJTPXsBuHHu6cDBd4lWajyvs3wk8u erRv7lsfQEYOOew1Yj/fbsgmbUVWjgfZbdrxofkotK+wm5IKIW58vb0tERDCzxTf/5gbPIHS q47v5Nzshnk7lOG9PXHYfFHKcp/WfukZUhl393rnXggK59OXIESRNk2m3TffrpY5nGcIqasc LLJga+xWPHM4nj+quaPMvh/PHI7nY1GWVfn9eOZwHr46HNL0b8QzhfO0RPw3IhkC+VIo0vZv 0N/L5xgsr2+HbLNj2nw/wikYT6f5/UnpNN+PxwrIB/gA/t3+RobmcDw/2AF5e4Qx7vFPbMCL /Coe5TQgKx01D/yh86y87/dCptizmh2sa9OS3l0wOht3RgUouLXjaqCdDPVkW7x8ent9/vL8 6f3t9Svci5NwwfpOhbt7sjUZRiuCgPyBpqF4Rdh8Bfppw6wWDZ0cZILedPg/yKfZuvny5d8v X78+v7kqGSnIuVxm7Nb7udx+j+BXHedytfhOgCVn3KFhTnHXCYpEyxw4bikEfoTmRlkdLT49 NowIaThcaMsYP5sIzuJlINnGHknPckTTkUr2dGZOKkfWH/Owx+9jwWRiFd1gd4sb7M6xUp5Z pU4W+rkMXwCRx6s1tZ6caf+idy7XxtcS9p6PEXZnxdE+/6XWG9nXb+9vf/7+/PXdt7BplVqg 39ni1oLgT/cWeZ5J8/Cck2giMjtbzOl9Ii5ZGWfgl9NNYySL+CZ9iTnZAscgvWv3MlFFvOci HTizp+GpXWOLcPfvl/ff/nZNQ7xR317z5YJe35iSFfsUQqwXnEjrEIMt8Nz1/27L09jOZVaf MueCp8X0glt7TmyeBMxsNtF1Jxnhn2ilGwvfeWeXqSmw43v9wJnFr2fP2wrnGXa69lAfBU7h oxP6Y+eEaLmdLu21Gf6uZ+8EUDLXb+W0a5HnpvBMCV1vGPNeR/bRuUADxFUp+Oc9E5cihHsp EqICz+QLXwP4LqhqLgm29HrhgDvX6WbcNU62OOSBy+a4HTKRbKKIkzyRiDN3DjByQbRhxnrN bKg98sx0XmZ9g/EVaWA9lQEsvR1mM7di3d6KdcfNJCNz+zt/mpvFgungmgkCZmU9Mv2J2d6b SF9yly3bIzTBV5ki2PaWQUDvAWrifhlQC8wRZ4tzv1xStwwDvoqYrWrA6XWHAV9TE/0RX3Il A5yreIXTu2UGX0Vbrr/er1Zs/kFvCbkM+RSafRJu2S/24BaFmULiOhbMmBQ/LBa76MK0f9xU ahkV+4akWEarnMuZIZicGYJpDUMwzWcIph7hSmfONYgm6EVZi+BF3ZDe6HwZ4IY2INZsUZYh vZo44Z78bm5kd+MZeoDruD22gfDGGAWcggQE1yE0vmPxTU5v60wEvWo4EXzjK2LrIzgl3hBs M66inC1eFy6WrBwZ+x2XGAxFPZ0C2HC1v0VvvB/njDhp0wwm48ZmyIMzrW9MPFg84oqpvaEx dc9r9oPzSLZUqdwEXKdXeMhJljFx4nHO2NjgvFgPHNtRjm2x5iaxUyK4y38WxZlc6/7AjYbw OBqchi64YSyTAg7xmOVsXix3S24RnVfxqRRH0fT06gSwBdytY/JnFr7UGcXMcL1pYBghmCyL fBQ3oGlmxU32mlkzytJgkOTLwS7kzuEHIyZv1pg6NYy3Dqg7ljnPHAF2AMG6v4LfRc/huB0G bnO1gjmxUCv8YM0ppkBsqCcJi+C7giZ3TE8fiJtf8T0IyC1nejIQ/iiB9EUZLRaMmGqCq++B 8KalSW9aqoYZIR4Zf6Sa9cW6ChYhH+sqCJmLWwPhTU2TbGJgZcGNiU2+dlyvDHi05Lpt04Yb pmdq21AW3nGptsGCWyNqnLMjaZXK4cP5+BXey4RZyhgbSR/uqb12teZmGsDZ2vPsenrtZLSB swdn+q8xq/TgzLClcU+61JHFiHMqqG/XczAM99bdlpnuhtuHrCgPnKf9NtxdIQ17v+CFTcH+ L9jq2sBTzdwX/ktMMltuuKFPOxxgN39Ghq+biZ3OGZwA+kU4of4LZ73M5ptln+Kz2/BYJ8ki ZDsiECtOmwRizW1EDAQvMyPJV4CxK2eIVrAaKuDczKzwVcj0LrjNtNusWVPIrJfsGYuQ4Ypb Fmpi7SE2XB9TxGrBjaVAbKgjm4mgjoAGYr3kVlKtUuaXnJLfHsRuu+GI/BKFC5HF3EaCRfJN ZgdgG3wOwBV8JKPAcYiGaMfFnUN/J3s6yO0McnuohlQqP7eXMXyZxF3AHoTJSIThhjunkmYh 7mG4zSrv6YX30OKciCDiFl2aWDKJa4Lb+VU66i7iluea4KK65kHIadnXYrHglrLXIghXiz69 MKP5tXD9QQx4yOMrxy/ghDP9dbJRdPAtO7gofMnHv1154llxfUvjTPv4LFThSJWb7QDn1joa ZwZu7jb7hHvi4Rbp+ojXk09u1Qo4NyxqnBkcAOfUC3PRxofz48DAsQOAPozm88UeUnMeA0ac 64iAc9sogHOqnsb5+t5x8w3g3GJb4558bni5UCtgD+7JP7eboG2cPeXaefK586TLGWFr3JMf zvhe47xc77glzLXYLbg1N+B8uXYbTnPymTFonCuvFNstpwV8zNWozEnKR30cu1vX1CMYkHmx 3K48WyAbbumhCW7NoPc5uMVBEQfRhhOZIg/XATe2Fe064pZDGueSbtfscghuFq64zlZy7iwn gqun4Uanj2Aatq3FWq1CBXoMBZ87o0+M1u67LWXRmDBq/LER9YlhO1uR1HuveZ2yZuuPJTxy 6XiC4N95tfzzGG9yWeIab53s+wDqR7/XtgCPYOudlsf2hNhGWKuqs/PtfMnTWMX98fzp5emL Ttg5xYfwYtmmMU4Bnt86t9XZhRu71BPUHw4ExU94TJDtIkeD0vafopEz+BkjtZHm9/ZlOoO1 Ve2ku8+Oe2gGAsentLEvexgsU78oWDVS0EzG1fkoCFaIWOQ5+bpuqiS7Tx9JkajzOI3VYWCP ZRpTJW8zcCG8X6C+qMlH4qUJQCUKx6psMtuv+ow51ZAW0sVyUVIkRbfqDFYR4KMqJ5W7Yp81 VBgPDYnqmFdNVtFmP1XYH6H57eT2WFVH1bdPokB+8TXVrrcRwVQeGSm+fySieY7h7fMYg1eR ozsPgF2y9KpdVJKkHxvipB7QLBYJSQi9UQfAB7FviGS016w80Ta5T0uZqYGAppHH2pUgAdOE AmV1IQ0IJXb7/Yj2tt9ZRKgftVUrE263FIDNudjnaS2S0KGOSqtzwOsphbeLaYPr5x4LJS4p xXN4OY+Cj4dcSFKmJjVdgoTN4Ci+OrQEhvG7oaJdnPM2YySpbDMKNLaPQ4CqBgs2jBOihAfZ VUewGsoCnVqo01LVQdlStBX5Y0kG5FoNa+g9UQvs7ZesbZx5WdSmvfEpUZM8E9NRtFYDDTRZ FtMv4MmWjraZCkp7T1PFsSA5VKO1U73OJUgNorEefjm1rJ9TB9t1ArepKBxICauaZVNSFpVu ndOxrSmIlBybNC2FtOeECXJyZV5r7Jk+oC9PfqgecYo26kSmphcyDqgxTqZ0wGhParApKNac ZUsf3rBRJ7UzqCp9bT9Qq+Hw8DFtSD6uwpl0rllWVHTE7DLVFTAEkeE6GBEnRx8fE6Ww0LFA qtEVngY871ncvLw6/CLaSl6Txi7UzB6Gga3JchqYVs3Ocs/rg8aVp9PnLGAIYd6pmVKiEepU 1PqdTwWMPU0qUwQ0rIng6/vzl7tMnjzR6DtXisZZnuHpPl5SXcvJU+2cJh/95A3Xzo5V+uoU Z/jNeFw7zp2ZM/PchnaDmmr/0keMnvM6w341zfdlSZ4o0z5jG5gZhexPMW4jHAzdgtPflaUa 1uEuJrjH1+8aTQuF4uXbp+cvX56+Pr/++U237OC5D4vJ4D94fKoLx+97K0jXX3t0APBYqFrN iQeofa7nCNnifjLSB/vW/1CtUtfrUY0MCnAbQ6glhtL/1eQGDg5z8fhTaNOmoeaO8vrtHZ7d en97/fKFe3JUt8960y0WTjP0HQgLjyb7I7LhmwintUYUHHqm6GxjZh3HEnPqGXoZZMIL+wml Gb2k+zODD5e0LTgFeN/EhRM9C6ZsTWi0qSrduH3bMmzbgpRKtZTivnUqS6MHmTNo0cV8nvqy jouNvY2PWFg3lB5OSRFbMZprubwBA35JGcrWICcw7R7LSnLFuWAwLmXUdZ0mPenyYlJ15zBY nGq3eTJZB8G644loHbrEQfVJ8MnoEErVipZh4BIVKxjVjQquvBU8M1Ecold9EZvXcIzUeVi3 cSZKX0DxcMNNGg/ryOmcVTpaV5woVD5RGFu9clq9ut3qZ7bez+CQ3kFlvg2YpptgJQ8VR8Uk s81WrNer3caNahja4O+TO53pNPax7R91RJ3qAxBu1RP/Ak4i9hhvHha+i788ffvmblbpOSMm 1acfoUuJZF4TEqotpv2wUqmU/8+drpu2UgvD9O7z8x9K1/h2B25yY5nd/fzn+90+v4cJuZfJ 3e9P/xmd6T59+fZ69/Pz3dfn58/Pn/+/d9+en1FMp+cvf+ibS7+/vj3fvXz95RXnfghHmsiA 1GGDTTnPNQyAnkLrwhOfaMVB7HnyoNYbSOG2yUwm6CDQ5tTfouUpmSTNYufn7DMbm/twLmp5 qjyxilycE8FzVZmSVbnN3oPzWJ4adtPUGCNiTw0pGe3P+3W4IhVxFkhks9+ffn35+uvwKCyR 1iKJt7Qi9cYDakyFZjVx42SwCzc2zLh2mSJ/2jJkqZYzqtcHmDpVRLOD4OckphgjinFSyoiB +qNIjilVszXjpDbgoEJdG6pzGY7OJAbNCjJJFO050msIguk0716+3X19fVe9850JYfJrh6Eh krPIlTKUp26aXM0UerRLtEdpnJwmbmYI/nM7Q1qNtzKkBa8efKvdHb/8+XyXP/3Hfqto+qxV /1kv6OxrYpS1ZOBzt3LEVf8HNrCNzJq1iR6sC6HGuc/Pc8o6rFocqX5pb43rBK9x5CJ6lUWr TRM3q02HuFltOsR3qs0sIO4kt/jW31cFlVENc7O/JhzdwpRE0KrWMBwTwOsZDDW742NIcACk D7gYzln+AfjgDPMKDplKD51K15V2fPr86/P7j8mfT19+eIMnj6HN796e/98/X+DJLJAEE2S6 uvuu58jnr08/f3n+PNwhxQmpxWpWn9JG5P72C3390MTA1HXI9U6NO4/PTgy4CLpXY7KUKewR HtymCkffTyrPVZKRpQv4dMuSVPBoT8fWmWEGx5FyyjYxBV1kT4wzQk6M4/MVscSHwrim2KwX LMivQOAiqCkpaurpG1VU3Y7eDj2GNH3aCcuEdPo2yKGWPlZtPEuJzP70RK/fhuUw98Vxi2Pr c+C4njlQIlNL972PbO6jwLaatjh6+Gln84SukVmM3sc5pY6mZli4HgFHvGmeursyY9y1Wj52 PDUoT8WWpdOiTqkea5hDm6gVFd08G8hLhnZXLSar7WeTbIIPnyoh8pZrJB1NY8zjNgjtK0eY WkV8lRyVqulppKy+8vj5zOIwMdSihEeAbvE8l0u+VPfVPlPiGfN1UsRtf/aVuoCjGJ6p5MbT qwwXrOA9BW9TQJjt0vN9d/Z+V4pL4amAOg+jRcRSVZuttyteZB9iceYb9kGNM7BpzHf3Oq63 HV3VDBxyvUoIVS1JQvfRpjEkbRoBL0vl6LzfDvJY7Ct+5PJIdfy4Txv84r3FdmpsctaCw0By 9dQ0PDpMd+NGqiizki4JrM9iz3cdnLAoNZvPSCZPe0dfGitEngNnwTo0YMuL9blONtvDYhPx n42axDS34O14dpJJi2xNElNQSIZ1kZxbV9guko6ZeXqsWny4r2E6AY+jcfy4idd0hfYIR8qk ZbOEnCUCqIdmbAuiMwtGO4madGF3fmI02heHrD8I2cYneH2PFCiT6p/LkQ5hI9w7MpCTYinF rIzTS7ZvREvnhay6ikZpYwTGPhx19Z+kUif0LtQh69ozWWEPj8cdyAD9qMLRPeiPupI60ryw Wa7+DVdBR3e/ZBbDH9GKDkcjs1zbNq+6CsBtmqrotGGKomq5ksjmRrdPS7stnGEzeyJxB4Za GDun4pinThTdGbZ4Clv469/+8+3l09MXs9Tkpb8+WXkbVzcuU1a1SSVOM2vjXBRRtOrGxxYh hMOpaDAO0cBZXH9B53StOF0qHHKCjC66f5ye3XR02WhBNKri4h6VGddVqFy6QvM6cxFtNYQn s+HKuokAnd56ahoVmdlwGRRnZv0zMOwKyP5KdZA8lbd4noS677VJYsiw42ZaeS76/flwSBtp hXPV7Vnint9e/vjt+U3VxHzmhwWOPT0Yzz2chdexcbFxG5ygaAvc/WimSc8GR/UbulF1cWMA LKKTf8nsAGpUfa5PDkgckHEyGu2TeEgM73awOxwQ2D2PLpLVKlo7OVazeRhuQhbEz6VNxJbM q8fqngw/6TFc8GJsPF6RAutzK6ZhhR7y+otzKp2ci+JxWLDiPsbKFh6J9/rlXIkM9rR8uScQ B6V+9DlJfJRtiqYwIVOQGBkPkTLfH/pqT6emQ1+6OUpdqD5VjlKmAqZuac576QZsSqUGULCA 1xDYQ42DM14c+rOIAw4DVUfEjwwVOtgldvKQJRnFTtRU5sCfEx36llaU+ZNmfkTZVplIRzQm xm22iXJab2KcRrQZtpmmAExrzR/TJp8YTkQm0t/WU5CD6gY9XbNYrLdWOdkgJCskOEzoJV0Z sUhHWOxYqbxZHCtRFt/GSIcaNkn/eHv+9Pr7H6/fnj/ffXr9+svLr3++PTF2PdhCbkT6U1m7 uiEZP4ZRFFepBbJVmbbU6KE9cWIEsCNBR1eKTXrOIHAuY1g3+nE3IxbHDUIzy+7M+cV2qBHz djgtD9fPQYp47csjC4l5XZmZRkAPvs8EBdUA0hdUzzLWxyzIVchIxY4G5Er6EayfjP9dBzVl uvfsww5huGo69td0j57L1mqTuM51h6bj73eMSY1/rO0b+Pqn6mb2AfiE2aqNAZs22ATBicIH UOTsa6wGvsbVJaXgOUb7a+pXH8dHgmBf+ObDUxJJGYX2ZtmQ01oqRW7b2SNF+58/nn+I74o/ v7y//PHl+a/ntx+TZ+vXnfz3y/un31xLTBNlcVZrpSzSxVpFTsGAHpzyFzFti//TpGmexZf3 57evT+/PdwWcEjkLRZOFpO5F3mK7EMOUF9XHhMVyufMkgqRNLSd6ec1aug4GQg7l75CpTlFY olVfG5k+9CkHymS72W5cmOz9q0/7fV7ZW24TNBpkTif3Em6mnYW9RoTAw1BvzlyL+EeZ/Agh v28LCR+TxSBAMqFFNlCvUofzACmRmejM1/QzNc5WJ1xnc2jcA6xY8vZQcAS8k9AIae8+YVLr +D4S2YkhKrnGhTyxeYTLOWWcstnsxCXyESFHHOBfeydxpoos36fi3LK1XjcVyZw5+4XHnBOa b4uyZ3ugjD9l0nLXvSRVBlvZDZGw7KBUSRLuWOXJIbNN33Se3UY1UhCThNtCe0tp3Mp1pSLr 5aOEJaTbSJn1RrLDuz6fAY33m4C0wkUNJzJxBDUWl+xc9O3pXCap7btf95wr/c2JrkL3+Tkl b4QMDDUSGOBTFm122/iCzKsG7j5yU3V6q+5ztr8ZXcazGupJhGdH7s9Qp2s1AJKQoy2Z28cH Am2l6cp7cIaRk3wgQlDJU7YXbqz7uAi3tu8LLdvtvdP+qoN0aVnxYwIyzbBGnmJtO/vQfeOa cyHTbpYti08L2WZozB4QfCJQPP/++vYf+f7y6V/uJDd9ci71YU+TynNhdwap+r0zN8gJcVL4 /nA/pqi7s61BTswHbXdW9tG2Y9gGbSbNMCsalEXyATcZ8K0wfREgzoVksZ7c2NPMvoF9+RKO NU5X2Pouj+n0kqkK4da5/sz1N65hIdogtB0NGLRUWt9qJyhsvxppkCazHz8ymIzWy5Xz7TVc 2I4ITFniYo38yc3oiqLEnbDBmsUiWAa2HzaNp3mwChcR8uSiibyIVhELhhxI86tA5JV5Anch rVhAFwFFwfVASGNVBdu5GRhQcqNGUwyU19FuSasBwJWT3Xq16jrnts/EhQEHOjWhwLUb9Xa1 cD9XKiFtTAUiZ5aDzKeXSi1KMypRuipWtC4HlKsNoNYR/QB87AQd+OVqz7S/Uf87GgSftE4s 2lEtLXki4iBcyoXtusTk5FoQpEmP5xyf2xmpT8LtgsY7vG0sl6Erym202tFmEQk0Fg3quM4w 949isV4tNhTN49UOOcgyUYhus1k7NWRgJxsKxm5Qpi61+ouAVesWrUjLQxjsbb1E4/dtEq53 Th3JKDjkUbCjeR6I0CmMjMON6gL7vJ0OBOaB07z88eXl67/+GfyXXlo1x73m1Wr/z6+fYaHn Xlq8++d8N/S/yNC7h8NLKgZKtYud/qeG6IUz8BV5F9e2GjWijX0srsGzTKlYlVm82e6dGoAL fI/2zotp/Ew10tkzNsAwxzTpGjnyNNGohXuwcDqsPBaRcV42VXn79vLrr+5kNVyNo510vDHX ZoVTzpGr1MyI7OURm2Ty3kMVLa3ikTmlavG5RwZjiGcuiCM+dqbNkRFxm12y9tFDMyPbVJDh auN8D/Dlj3cwKv12927qdBbX8vn9lxfYFxj2ju7+CVX//vT26/M7ldWpihtRyiwtvWUSBfL7 jMhaIDcQiCvT1lzM5T8E1y5U8qbawlu5ZlGe7bMc1aAIgkelJKlZBBzdUGPFTP23VLq37YZm xnQHAp/WftKkyvJpVw/bx/pIWWp97yzspaGTlL1bbJFKGU3SAv6qxRG9J20FEkkyNNR3aObg xgpXtKdY+Bm6V2LxD9neh/eJJ864O+6XfPUd+C+y5SKzF505+F9kmlERq++1bxU3aE1jURdz D7u+eEOcJRJrizl5mkDhallbL9Y32S3L7suu7RtWdPvTIbPULPg1GCLod7yqJkHuWgEzNg6o o9gNliYNS0BdXKwxAH73TZcSRNoNZDddXXlERDN9zEu/If1yZ/H6JhcbSDa1D2/5WNHkSQj+ k6Zt+IYHQumzeAClvIr24kmyqlWTIWlL4SkAeOQ1U6v0uLEP9DXlXOkHlIQZBielethDgaZI ZQ8Y+BlT2mNKiOMppd+LIlkvOaxPm6ZqVNk+pDG2itRh0s3KXjppLNuGu83KQfFybsBCF0uj wEW7aEvDrZbutxu8NTcEZBLGXj+HjyMHk2q1nhxpjPLeKVywKAuC1WUS0lLAMZ7V91p4Y32P AaXsL9fbYOsyZJ8BoFPcVvKRBwenCz/94+390+IfdgAJBmz2FpoF+r8iIgZQeTEToFZgFHD3 8lWpKb88ocuCEFCtgw5Ubicc7xRPMFIzbLQ/Zyn4qMsxnTQXdKgA/j4gT85+yhjY3VJBDEeI /X71MbUvC85MWn3ccXjHxuQ4MJg+kNHGdj044okMInu1h/E+VkPV2fYDZ/O2ho/x/mo/PGtx 6w2Th9NjsV2tmdLTTYIRVwvJNfKXahHbHVccTdiOFBGx49PAi1WLUItb2/XhyDT32wUTUyNX ccSVO5O5GpOYLwzBNdfAMIl3CmfKV8cH7PoXEQuu1jUTeRkvsWWIYhm0W66hNM6LyT7ZLFYh Uy37hyi8d2HHL/WUK5EXQjIfwAkyejEEMbuAiUsx28XC9lk8NW+8atmyA7EOmM4ro1W0WwiX OBT49aspJtXZuUwpfLXlsqTCc8KeFtEiZES6uSick9zLFr2jNxVgVTBgogaM7ThMyjq7PUyC BOw8ErPzDCwL3wDGlBXwJRO/xj0D3o4fUta7gOvtO/Ry5Fz3S0+brAO2DWF0WHoHOabEqrOF Adeli7je7EhVMM+TQtM8ff38/ZkskRG64oTx/nRF20E4ez4p28VMhIaZIsS2uDezGBcV08Ev TRuzLRxyw7bCVwHTYoCveAlab1f9QRRZzs+Ma73hO1kIIWbHXum0gmzC7eq7YZZ/I8wWh+Fi YRs3XC64/kc2uBHO9T+Fc1OFbO+DTSs4gV9uW659AI+4qVvhK2Z4LWSxDrmi7R+WW65DNfUq 5roySCXTY82BAY+vmPBmX5nBsX8gq//AvMwqg1HAaT0fH8uHonbx4eXMsUe9fv0hrs+3+5OQ xS5cM2k4PoImIjuC/8qKKclBwgXWAvyRNMyEoa0zPLCnC+ND7Hk+ZYKm9S7iav3SLAMOB5uY RhWeq2DgpCgYWXMMKKdk2u2Ki0qeyzVTiwruGLjtlruIE/ELk8mmEIlAh9WTIFDLnamFWvUX q1rE1Wm3CCJO4ZEtJ2z4HHaekgLw8eQS5v1KTuWPwyX3gXN3ZUq42LIpkHv6U+7LCzNjFFWH TMkmvA2RA/0ZX0fs4qDdrDm9nVmi65FnE3EDj6phbt6N+Tpu2iRAx1xzZx5swCY36vL567fX t9tDgOXGE05UGJl3bJ2mETDL46q3DU4TeAlydNLoYHTxbzEXZDwCjlMS6i5IyMcyVl2kT0tw E6CNHko4FyVGjLAVmZbHzG4AvfmZNe1Z+wTQ3+EcEos8vYFq2RCBGUcD3iWOaFtYdBmxvNrD vYO96BthWxIPvct+0wpSgE5hr5b0JqoIgo5ieBBJrkzCZvzDtjowIKcIOWUyw2Gy4ghOmAho PJMqbL100c71YVqJloug+v9Rdm3NaiNJ+q+cmOedHRAgxEM/CEmAGpVURyU4nH5ReGzG42jb p8N2x2zvr9/M0oXMqhR4H3zh+1J1v1dWpm5jAcfTywtMbTzS48LRNEp2TuoHTUF0PsDU3Qb8 4qrB6VbzEADhKVXQWZnK38XwZJRbveuL+wZqNADOgMIpe9unJyDuGMGiikvqOnW+Xdhx0ql0 O+YFszbWWy7eEfOZU/zQwR3BQUvQJiARcKdI7cDGg/jNyblqju3BeFDyzCA0uoNjDzRvtacv 2m8Ea/GYDEdlskd9MaaMhaqGbmAIoBS1nGxOPBs9wAMzO6dBDW8deWXZxpG125i+J+1R8m0S 104OyNNJt6pzNxs4RLH1UWMbqV0GwhBU08E0+fzp+vWHNJi6YfK3M7exdBjRhiC3p51vbtcG is9kSa5fLEpaVvcxiwN+w5R8ztqyavLdq8eZrNhhwozHHDJmPIqi9iya3qwysjPROCrPOzka P6H3l/Hp4j30P6RLPoYfDayvIve3tUP3y+x/FuvIIRyzvsku3uO2dUnOdG8YVEKT/RLM6OAd myTPHfvzzTw80h1Fb2MEr+Spop79ORogmTlwXdmaXHG4UzXEVbth74U6dosGcgfub3+7bVTR BII1o1/AvLoT97JUpBR2soR3NCKdbPWCpMmxt6Ooek31gxHQ/eI+r585kapMiURMlz0ImKxO KmYAEMNNcuHRFRBl1lwc0frEHgYCpHYh9RKE0EHYg5x3QOSVUif7RmTuMLDued6lHHREysp+ 7qBs5BuQlpmsGFHFRqIRhvn+IsF7Jz0w/dB7mhEa7pFuC4j6ud2+alSLVXEJrYxM3bjAg3Vp fmY6Q+dtddmf2KiGgqwM7G9UODt5IC+EEfNeCPbUOdWxL88UPHpwGxdFRTfEYyp82bzUJy/9 UOZSJuzTAoVeGrLWW4s7yYNf+CqHFO8uOZOucbbGIPKqoY+3O7Bm+ihnbqytE3HK02Ls9WwH GfZkrMPOhql+9yBPvMXsZNdbt7/VSW8e/v23t+9v//rxdPjrj+u3v5+fPv55/f5D8C1l/UeQ 4bPzJ+Hol/Wo406rR2+VOc4oj6K3abxcvw4Kh16y0FuW10gIiC2lql/bQ9Xogm6rpmXaIld5 88tqHlBZq0iAKkZ2h+ZY/UAB7IjZGTZZXkKSI3PlBSC9m0UZfN4ZNxKDl8td8XG7ZsjBH7Sa 4TsLQ3JfcuWxG9a6awtL1XHZ2DxgmSQiiRtATsKuEps9CvEvoPNjWFLeW31Gn1dT6R5Y8VPs BROBwogGHZqDuF21V972RRrnVJKhwyAOHuIzqjWxUR7xbJc7IZ+aqr0UMVULHWJ0K1AZIZKz duOwxdHqfZrXsAruKmjsJ0IXGL7d19krM1zTA21mqFe9xlGOgwIzKuCPLqAZZvSFe/fbPZAY 0U6t0i4989+y9riFRdcyuiOm4guVnDmiKjeJPzX15LYqUw/k6/Ae9GzF9bgx0PRL7eG5iSdj 1UnBfLsSmC46KByKML3BvMERPUajsBhIRI9GRlgtpKSgL3IozLwKZjPM4YSAToJFeJ8PFyIP 8yizSU1hP1NpnIiomYfKL17AYdEvxWq/kFApLSg8gYdLKTlNEM2E1AAstAEL+wVv4ZUMr0WY KnUNsFKLIPab8K5YCS0mxpV2Xs2D1m8fyOV5XbVCseX2QW4wOyYelYQXvMOoPELpJJSaW/o8 D7yRpC2Bado4mK/8Wug5PwpLKCHugZiH/kgAXBFvdSK2Gugksf8JoGksdkAlxQ7wSSoQtJLw vPBwsxJHgnxyqImC1YovpMeyhb9eYlhZpJU/DFs2xoDns4XQNm70SugKlBZaCKVDqdZHOrz4 rfhGB/eTxv2FezQqKd6jV0KnJfRFTFqBZR0yTSPOrS+Lye9ggJZKw3KbuTBY3DgpPrwoyufs zbHLiSUwcH7ru3FSOnsunAyzTYWWzqYUsaGSKeUuHy7u8nkwOaEhKUylCa4kk8mUd/OJFGXa cFXZAX4t7ZnmfCa0nT2sUg5aWCepXXjxE54n2jW9MibreVvFNTrJ8JPway0X0hFfapy4lZih FKxrMDu7TXNTTOoPmx2jpj9S0lcqW0r5UehJ5NmDYdwOV4E/MVpcKHzEmR4pwdcy3s0LUlmW dkSWWkzHSNNA3aQroTOaUBjuFTPYcwu6ySu2V7nNMEk+vRaFMrfLH2YogbVwgShtM2vX0GWn WezTywm+Kz2Zs6coPvN8ijvnr/Gzlnh7bj+RybTZSIvi0n4VSiM94OnJr/gORsOyE5TJ98pv vWd1jKROD7Oz36lwypbncWERcuz+Zarmwsh6b1SVq13a0KRC1obKvLt2mviwkftIXZ0atqus G9ilbILTL18Igll2frdJ/aphC50kSk9xzTGf5F4yTmGkGUdgWtwaAkXreUC23DXspqKMJBR/ wYrB8TNVN7CQo2VcJU1WlZ0BRn5O14QhNIcv7HcIvzsN+bx6+v6j9/EzahlYKn7//vr5+u3t y/UH0z2I0xx6e0B1TXvI6oiMZwPO912YX999fvuILjQ+fPr46ce7z/ieESJ1Y1izrSb87gxu 3sK+Fw6NaaD/+envHz59u77HG6KJOJv1gkdqAW4XZgDzIBGS8yiyzlnIuz/evQexr++vP1EO bIcCv9fLkEb8OLDuys+mBv7paPPX1x//vn7/xKLaRHQtbH8vaVSTYXRux64//vP27XdbEn/9 7/Xbfz3lX/64frAJS8SsrTaLBQ3/J0Pom+YPaKrw5fXbx7+ebAPDBpwnNIJsHdGxsQf6qnNA 0/vpGZvuVPjdM5fr97fPeOb1sP4CMw/mrOU++nZ0Gyt0zCHc3bY1ar0an2GbP67vfv/zDwzn O7qw+f7H9fr+3+RmV2fx8UROmHoAL3ebQxsnZUMnBp+lg7PD6qooqkn2lOqmnmK39Mklp9Is aYrjHTa7NHdYSO+XCfJOsMfsdTqjxZ0PuZ91h9PH6jTJNhddT2cELfz+wj0tS/U8ft2dpXbu rMgEkKdZhSfk2b6u2pS+Be00euyTRKO9L+7CaE0cBvz5FF2dV8yohMsG7IUTZ/dJEFAlYs4q U3d+erNC8xtEJtVsFLMq40YxW9B9rZe8MJpkrREML+SD9f8uo+i/KFITXF0lR3RY5NLwzViV nXmA/1aX1T/Cf6yf1PXDp3dP5s9/+n75bt/ym7kBXvf42Kjuhcq/7pV9U3p53jGoyuIVyJAv 8QtHh5aAbZKlNTN4b63Rn+nqp8+NPqHvvP1pKKDvb+/b9+++XL+9e/reKU96ipNoZX9MWGp/ XbyKHgXQYr5Lwir9nJv89vgh/vrh29unD1Q958CNAtA7QPjR67ZYXRZOJCoeULK26IJ3e7nd ot8+L5qs3adqHSwvt7Fvl9cZulrxDJnuXprmFe892qZq0LGM9bQYLn0+gVh6ejFePA5apZ5p XtPu9D5GRZIbeCpzyLDRzL+uxTqnSOyNNCWci3NKHbZ8O6Cw8IpjeynKC/7n5TdaNjBfNnSE 7n638V7Ng3B5bHeFx23TMFws6aPJnjhcYF0025YysfZitfhqMYEL8rAT28zpYwyCL+gOn+Er GV9OyFO/WgRfRlN46OE6SWHl5BdQHUfR2k+OCdNZEPvBAz6fBwKeadjhCOEc5vOZnxpj0nkQ bUScPTljuBwOU6Sn+ErAm/V6sapFPNqcPRy2pa9MvWnACxMFM780T8k8nPvRAswetA2wTkF8 LYTzYs2yVNT1OSoYpzqOAwHCfaQhBiFQWXzOjs8GxDHXeYPptmlEDy9tVW1x3UG1dq0uCFqS LrOSqgl2BFMXUJ4eikVMdWJ2RKzGCQ7XDpbmKnAgth+wCLt7Ppo1e3Mx3GK7I18P49BXU2dT AwFDsbVO4jPMbPUAOsaIRpjetNzASm+Z86uB0dzB0gCjOxMP9H0RjXmyBhBS7hBmILmBowFl hTqm5kUoFyMWI2s9A8gNCI8ora2xdurkQIoaFfttc+A6yL2tzvYMkz05AjZl6pvx7CZ/D9b5 0m5je1+i33+//vDXZMOUvY/NMWvaXR2r7KWq6X6il4h1dunPIOkawAl4+OqSF/iYABvXjhSi Ndlq/dbQnnNQaBQSSwdqlK6voKwuPWMvLGrY0THdKfjQ6pOybnfUCb8f6IGWF/GAsgodQNZK BpArmhdUTfVlRw5AL1E4upz3deWsis2LomOQytut4u9C8qy0FoOY4OEUv2TOx91GCYMwqMH6 giMtU7K5CfQ2d7cVVcRSF8UDhI3eM0cueQzbC47FSVYf0h0HWt95XgezL60Psz17rBAbHCxi 3VTaAYUQLcxCRKTccjDLMp14YXYoE0yTdEvva9KsKFqjtnklg87XhDDUW6El3OgtWG+b0oNO XpBVxDQxLOpHjfWaZiapc81GyJGM6SA2ogU16o0vkGFrsTvmBV1unn7NG3Py8jDgDb6WoqOe xtV4YocRak/8oDuPpwzxqxVB1q63Cg+lCZDC9iNOvfR0j8xgskqZyj5aSzyivOMVgMLQz0zs GzfiMlaXaxcnaAkuz6ZicFW+ONnbI+bmebmIsybg5KFqjtlriydabsdODg3+b7HYeX0en+Bl Z8dKlH1AVTYwngXtmU+R/SuqrCyqFxet4mNTM+OpHX5mjdmcaiipbMGrskfbBYzuTVP58sDY 9UBb6Trb55IEDPP+58rkXnNAjI9e1XzVZrD6OTLMa+866V6kWEvEVA8wVrD73/vtrsef6RrM 1lZvgZtUZm+Se9t4sQ4Ud1Y+oM6QC2EnyrmO0rE/zBR+anVcxqaCDa2fj6p8FUGMzWrZEtge D6xDt1NVGpYJtRcKWo3ofKLkJQiUTc5mJlVcxnmSBnZKDjCgZagh7M90OS2nDqqN18KNghUZ IGWW3Ewuff1x/YwnldcPT+b6Ga8Mmuv7f399+/z28a+bcShfY7oP0no7MzBsJU1nIB8bJl0L /X8j4OE3J5iZ7cHGws3NqcSlC6zOsudhHeSKbC/NS9JqfALZUD3ZcZBI0eUAusxgHbbv8rsC zctmtYq9gFWe9p3T7X09X+PHcrhauW/revxU5lCGtCX3ZZycJmBJkikoENhrUixwq2rvcvAn Q3/LZBuBicdzVTLDDWdLOte0Ge9SYiNh6JkH2GtlY1qMy1T+emckNHpNygSiYVaL/Tg7gC9e B7DWyuwFWXNotA+zRfEAFloIFwbmpnLg4zbFuU6yXTt8ho+p2CZgjATlt/REbmDOWyH6bnY2 Qg7ssoD5JhwpbuptgB0nRxaGLRwsa2Bvy14EEcp9Wei/XR8QP6kjYydpiRCapYIlXFxW0sjZ WW32H270OJ3qK6hLlkoLwLRIz8duGBO12vgJvXOCH/h2AXb77C5vEIQ2kml2wHA7F5Wwm2mU 7lr689vo7MHaz45r9VRf/3X9dsUb2A/X758+0teiecI0WCA8oyN+1fmTQQpJ8822cXKzjFYi 51h1I8whD5n9eUKZROUThJ4g8hU7QnWo1STlKGYTZjnJrGcis1XzKJKpJE2y9UwuPeSYcT3K mW4Hr0UWDwdNLBfIPlN5KVOucyOauUBpw7RSAWxeinC2lDOGT/nh3z191oP4c1XTAxyECjOf BVEMHbhI870YmmPngzBFlRzKeB/XIuuaqqMUPeIieHUpJ744J3JdKKUD95CR1n66nkcXuT3v 8gtMC46yOJaetd5qOFi9QK1yFewBXYvoxkVhzQtD9xa2q+1LDcUNYBlEBzaNYYrj/Air6Map 7m0zbxO7nihkIqV+tC3hnsH1YBsyG0IUbfdsSTxQx6qUr5Ecz1WDfPK6L0/Gxw914IMlvTq/ gYKkqTlWQ5fZZnX9OjH6HHIYYcLkvJjJvcTymykqDCe/CieGGtGtEx9bme+/OkO/9GiuhGxq mtNWFCbEZNq2lWluF67514/Xr5/eP5m35Lt/w5uX+OIb1j573wsC5VyjRi4XrLbT5PrOh9EE d+EXKJyKFgLVQPPvZm+y+xHyLpTY4KH+FmiT9w4r+iDlWd/qADTX3zGCW5nScQk1EppMXlKg BaaZPPl1FIxKzFaxL5Cr/QMJVCd4IHLIdw8k8H7rvsQ21Q8kYHR+ILFf3JVwFIo59SgBIPGg rEDiV71/UFogpHb7ZCdPkYPE3VoDgUd1giJZeUckXIcT86Clupnw/ufo0OKBxD7JHkjcy6kV uFvmVuKMJtcfZBXL/JFErvNZ/DNC258Qmv9MSPOfCSn4mZCCuyGt5cmpox5UAQg8qAKU0Hfr GSQetBWQuN+kO5EHTRozc69vWYm7o0i43qzvUA/KCgQelBVIPMonitzNJzei51H3h1orcXe4 thJ3CwkkphoUUg8TsLmfgGi+mBqaovl6cYe6Wz3RPJr+Nlo8GvGszN1WbCXu1n8noU/2+FBe eTlCU3P7KBSnxeNwyvKezN0u00k8yvX9Nt2J3G3TkfvqlFO39jh92MFWUsRQEt3N7rtaFuwl WUNq+9SQXYiFaq2SREwZ0o5wvFqwbZUFbcw6MWh6N2LGskfaqBQjEhhAiemmWD/DlJq00Sxa clQpD8574eWM7k0GNJzRF6j5GDA1/I5oIaKdLNXWg8x1KNtSjCjL9w2l5ltvqBtC4aNpJ7sJ 6RN7RAsfhRC64vEC7qJzs9ELi7nbbGQ0FINw4V44clB9EvEhkIi2C9PXKUkGGsvIjQZ4Pad7 IcD3Imjj82BljA92SjyeNBQ0DIWYvOWKw7Zt0XLGJDcnNIDEU434c2hg06Sd7PSh+EF35eTC QxI9oi8UDy/QIJZH9JGy9z8DGDBQq7y7koIOyg5LOmOMOzYEHDUU6yVxDjd6y4UczFR2dk4r 6t9i5/imXptNMHdOhOooXi/ipQ+yDfcNdGOx4EICVxK4FgP1UmrRrYgmUgjrSAI3AriRPt9I MW2krG6kktpIWWUjBkHFqEIxBLGwNpGIyvnyUraJZ+GeW1LASeQAbcANAI1m7rMyaBO9l6nF BHUyW/gKXUjj7bDYfPFLHDbc4zTGsns4wkLPkWf8XgPhxnW+z9GEd7gU71gGAVgjGBtEwnQt 0BjsfCZ+2XHBNLdcyLc6mM58l58zCWt3p9Vy1uqaGUNFK7ViPEiYZBOFsyliEQvR8wcdI9TV mZEYSJByzSP7bHSX3TANGBsfvcYGKD+3uzlqHxuPWs3yNsZKFPBDOAXXHrGEYLBGXXk/MSFI LuYeHAEcLER4IcPRopHwgyh9Xvh5j1CZKpDgeulnZYNR+jBKc5B0nAbNdnjH+oNtYo4We4UH oTfw8GJ0XnIf8jfMsZ1LCL4KJoTJ651MaPpUhBLcsPvBZKo99Y4CyOGpefvzG95muufQ1gIh s0PeIbqutrybZucGHeZR9yX2Z8uzD5LbInUlATV14tz2DIrNjhXE4c7DxXt/ER48eIvwiBdr tNpBd02j6hn0AwfPLxqNXzuofUwWuijeMDlQnXrp7bqcD0KHOxgH7l6POWDn8MFFS52otZ/S 3iFD2zSJS/UeOLwvujpJtxeMBYcq2kMKbdbzuRdN3BSxWXvFdDEupOtcxYGXeGi3deaVfWnz 30AdxnoimTo3TZwcmF/eWp3Xyiqi5bQJxo1CxaK8cSFHFwCDHTT32JXo4GXErXa8HoXNpZdX tD3u1jNOQ3JOfrUKXCx55tB3u0RJqGqoEuKwFqig6wvCTOUr6zMBWc/9Ir1QW+TRAtuaqiMB o/vQHqSuprso8DUnPn1LGj/PpuEaQ3GTQAHM/dY9XirJMDMBC7uJurIvICGszpy1c9DhjHrj h3FebCu6O8dHrAwZdfbV4cRaXAwdfYH9r36BFsI/Gl9kOmHRjczg5oFJdJeKHohXkA7YJ92x 3dido+BxCdOYw5FUp4kbBFrKV+mzA3fzvjJ7jmI75oI2spxlqrMMnVdn6oehig19M9TJcCfV FrrpXHfPU9Cewaf3T5Z80u8+Xq278SfjqWL2kbZ6b/XP/eQMDG5eH9GjAfg7cnbAMQ8FaFC3 xzEPssXD9PTDBrgzB4p78eZQV6c9Oeeqdq1jYrv/iLkTUakrNUIt3UjfUC8tEGDdukXee+NQ vsLpVI4Iac6ehibPsK9r2vG7otL6tX0R/ILYcJO4+L/Wvq25bVxZ9/38Clee9q6aWaO7pVOV B4qkJMa8maBk2S8sj61JVBPb2bazd2b/+tMNgFR3A1Syqk7VmhXr6ybuaDSARrfuGHRL40+s ugaByvQ0q0PLupS6hTLqggK6Gx96bF2kjYAc1c0yySMQX8rDFCVKl856G1/eur6R1XiBCu2N LI7GYbEUMM5tAZnpyjHrUrpFrbuQp5f3w7fXlwdPIJ84K+qYm5u0InlXbmFNNCTiP8RJzGTy 7entsyd9bpCqf2qzUImZA+c0ya/6KfxQ2KEq9uqdkBV1Kmbwzov7qWKsAl1v4MNOfMfSNiYs PM+PN8fXgxtjqON1Y2idSHoQ+wh252AyKcKL/1D/vL0fni6K54vwy/Hbf6K3jYfjXyBoItnI qLWWWRPBriTBgPDCMQUnt3kET19fPhtLDrfbjKuFMMh39FTOotoKI1BbautpSGvQE4owyelr wI7CisCIcXyGmNE0T14JPKU31Xozlvm+WkE6jjmg+Y06DKo3qZeg8oI/WdOUchS0n5yK5eZ+ UowWQ10CunR2oFp1IVeWry/3jw8vT/46tFsr8bQW0zjFc+7K403LOEzal3+sXg+Ht4d7WKuu X16Ta3+G19skDJ2YWHj0rNgLIkS4W7ktVSSuY4ydxDXxDPYo7G2SefsNP1SRskcXPytt55/E XwfUAtdluBt5x5lWb8MttiFv0NZrCvNV4uaLG8wfP3pyNpvP62zt7kjzkj8scZMxoQjIRZ5n plqdT6wU+aoK2C0movqU/qaiSyLCKuSGPoi1V5yniAS+UujyXX+//wpDrGe8GgUW4yywsJPm Rg9WKYw3Gy0FAdefhoY/MqhaJgJK01DeUJZRZSWgEpTrLOmh8GvFDiojF3Qwvuq0643n/hIZ 8aF1LeulsnIkm0ZlyvleSlaN3oS5UkJ02U0De8Lt7SU62J07GLTWcy9ICDr2olMvSo/9CUwv SQi89MOhNxF6JXJCF17ehTfhhbd+9FqEoN76sYsRCvvzm/kT8TcSuxwhcE8NWVBnjLUSUmXL MHqgrFiy0FvdjndNzy071CdH9TrWd1uhdj6sYcFeLY4Z0EXSwt4s9ZG7qoKMF6ONbbcr0jpY a9fAZSrXS800/hkTETlbfZ7WreEmCMvx6/G5R/jvE9BL981OH1CfYla4X9AM76h8uNuPFrNL XvWTO7Zf0hLbpErtpQBfF7ZFtz8v1i/A+PxCS25JzbrYYYwffMtf5FGM0pqs1oQJhCoeqgRM 62UMqK+oYNdD3iqglkHv17CLMrdLrOSOJowbMDtcrAMKW2FCx+W+l2iOa/tJMKYc4qll5UNs BrcFywv6wMXLUrIoKJzl5D2MBl+J9/gQtm2f+Mf7w8uz3aG4rWSYmyAKm0/Mb0tLqJI79jSh xfflaD534JUKFhMqpCzO351bsHubPp5QcxBGxdfuN2EPUT9FdWhZsB9OppeXPsJ4TN0Rn/DL S+YhkBLmEy9hvli4OcjnOC1c51NmPWFxs5aj0QTGdXHIVT1fXI7dtlfZdEpjc1gYfUZ72xkI oft41ER0IkMrotcz9bBJQf2m/hhQTU9WJAXzwqDJY/pIVWuRzBmAPXzPWAVxbE8nIwxj6uAg xOnNWcJcFmDEs+1qxc6NO6wJl16Yx45luNzNEOrmRu8/tpnM7Aqd3DQsQBTCdZXgs1F8B+sp ofmTHY6dvnFYda4KZWnHMqIs6sYNaWdgb4qnorVi6Zf8KhOVpYUWFNqn48uRA0g/xQZkj5SX WcBe3sDvycD5Lb8JYRJJ3yIU7efnRYqCEQuXHIzpyz88+Yzok0UDLARALY1I7GuTHXWyp3vU Pjk2VBnz72qvooX4KdwUaYg7KdqHn66GgyGRTlk4ZqEfYEsFSvjUAYSjMQuyDBHk9opZMJ9M RwxYTKfDhr/3t6gEaCH3IXTtlAEz5iVehQEPOaHqq/mYvlBBYBlM/7/5+G60p3v0llPTk9/o crAYVlOGDGngDfy9YBPgcjQT3sIXQ/Fb8FMjRvg9ueTfzwbOb5DC2kNKUKEn3bSHLCYhrHAz 8Xve8KKx52L4WxT9ki6R6Bh9fsl+L0acvpgs+G8abD6IFpMZ+z7Rb2pBEyGgOV7jmD4nC7Jg Go0EBXSSwd7F5nOO4Y2ZflbJ4VD7BRwKsAyDkkNRsEC5si45muaiOHG+i9OixCuJOg6Zs6Z2 10PZ8Xo9rVARY7A+HNuPphzdJKCWkIG52bMYbO2xPfuGuu/ghGx/KaC0nF/KZkvLEN/5OuB4 5IB1OJpcDgVA38lrgCp9BiDjAbW4wUgAwyEVCwaZc2BEH8MjMKYOTPHBPnNimYXleESDoiAw oa9IEFiwT+yzQ3ySAmomhnPmHRnnzd1Qtp45wVZBxdFyhI8+GJYH20sWIA6NQTiL0TPlENTq 5A5HkHxsak7DMui9fbMv3I+0Dpr04LseHGB6vqCNJm+rgpe0yqf1bCjaQoWjSzlm0N94JSA9 KPFab5tyd5Am1r2pKV19OlxC0UobZnuYDUV+ArNWQDAaieDXBmXhYD4MXYxaarXYRA2oY1kD D0fD8dwBB3N0F+DyztVg6sKzIQ+ro2FIgJr5G+xyQXcgBpuPJ7JSaj6by0IpmFUsigqiGeyl RB8CXKfhZEqnYH2TTgbjAcw8xomeFcaOEN2tZsMBT3OXlOjBEF0/M9weqNip9+9H41i9vjy/ X8TPj/SEHjS1Ksb75NiTJvnC3pp9+3r86yhUifmYrrObLJxoDxfktqr7yljufTk8HR8wioV2 E07TQiusptxYzZKugEiI7wqHssxi5ize/JZqsca4w59QsfiNSXDN50qZoQsGesoLOSeV9iC+ LqnOqUpFf+7u5nrVP9nsyPrSxue+fJSYsB6Os8QmBbU8yNdpd1i0OT7afHVQi/Dl6enlmQRw PqnxZhvGpaggnzZaXeX86dMiZqornekVc8mryvY7WSa9q1MlaRIslKj4icH4PzqdCzoJs89q URg/jQ0VQbM9ZEO7mBkHk+/eTBm/tj0dzJgOPR3PBvw3V0Snk9GQ/57MxG+maE6ni1HVLAN6 a2RRAYwFMODlmo0mldSjp8wXkPnt8ixmMrjL9HI6Fb/n/PdsKH7zwlxeDnhppXo+5mGQ5jxQ K3RbFFB9tSxqgajJhG5uWn2PMYGeNmT7QlTcZnTJy2ajMfsd7KdDrsdN5yOugqGLCw4sRmy7 p1fqwF3WA6kB1CaQ7nwE69VUwtPp5VBil2zvb7EZ3WyaRcnkTkIQnRnrXTirx+9PT//Yo30+ pXVAlSbeMf9Bem6ZI/Y24EoPxfEg5jB0R1AsjA8rkC7m6vXwX98Pzw//dGGU/heqcBFF6o8y TdsAXMbSUpu33b+/vP4RHd/eX49/fsewUixy03TEIimd/U6nXH65fzv8ngLb4fEifXn5dvEf kO9/XvzVleuNlIvmtYIdEJMTAOj+7XL/d9Nuv/tJmzBh9/mf15e3h5dvBxvnwzlFG3BhhtBw 7IFmEhpxqbiv1GTK1vb1cOb8lmu9xph4Wu0DNYJ9FOU7Yfx7grM0yEqoVX563JWV2/GAFtQC 3iXGfI2Ow/0kdCh6hgyFcsj1emycAzlz1e0qoxQc7r++fyH6V4u+vl9U9++Hi+zl+fjOe3YV TyZM3GqAPoAN9uOB3K0iMmL6gi8TQqTlMqX6/nR8PL7/4xls2WhMlf5oU1PBtsGdxWDv7cLN NkuipCbiZlOrERXR5jfvQYvxcVFv6WcquWQnffh7xLrGqY/1qgSC9Ag99nS4f/v+eng6gOL9 HdrHmVzs0NhCMxe6nDoQV5MTMZUSz1RKPFOpUHPmmqxF5DSyKD/TzfYzdmazw6ky01OFe2km BDaHCMGno6Uqm0Vq34d7J2RLO5Nek4zZUnimt2gC2O4NC+1J0dN6pUdAevz85d0zyK0Pb9qb n2AcszU8iLZ4dERHQTpmgTPgN8gIetJbRmrBfJhphJlyLDfDy6n4zd6qgkIypEFrEGAvUWHH zOJQZ6D3TvnvGT06p1sa7SUVH2yR7lyXo6Ac0LMCg0DVBgN6N3WtZjBTWbt1er9KRwvm8IBT RtQVAiJDqqnRew+aOsF5kT+pYDiiylVVVoMpkxnt3i0bT8ektdK6YqFt0x106YSGzgUBO+Fx lS1CNgd5EfAYPEWJ4a1JuiUUcDTgmEqGQ1oW/M2Mm+qrMQvhhpFbdokaTT0Qn3YnmM24OlTj CfXQqQF619a2Uw2dMqVHnBqYC+CSfgrAZEoDC23VdDgfkTV8F+Ypb0qDsCgkcabPcCRCLZd2 6Yx5R7iD5h6Za8VOfPCpbswc7z8/H97NTY5HCFxxDxT6NxXwV4MFO7C1F4FZsM69oPfaUBP4 lViwBjnjv/VD7rgusriOK64NZeF4OmLO/Yww1en7VZu2TOfIHs2ni4uQhVNmtCAIYgAKIqty S6yyMdNlOO5P0NJEOFNv15pO//71/fjt6+EHN5rFM5MtO0FijFZfePh6fO4bL/TYJg/TJPd0 E+Ex1+pNVdRBbSITkJXOk48uQf16/PwZ9wi/Y6TU50fYET4feC02lX2657uf1+7lq21Z+8lm t5uWZ1IwLGcYalxBMD5Tz/foI9t3puWvml2ln0GBhQ3wI/z3+ftX+Pvby9tRxxp2ukGvQpOm LBSf/T9Pgu23vr28g35x9JgsTEdUyEUKJA+/+ZlO5LkECzJnAHpSEZYTtjQiMByLo4upBIZM 16jLVGr9PVXxVhOanGq9aVYurO/O3uTMJ2Zz/Xp4Q5XMI0SX5WA2yIh15jIrR1wpxt9SNmrM UQ5bLWUZ0LCjUbqB9YBaCZZq3CNAy0oEh6F9l4TlUGymynTIPBnp38KuwWBchpfpmH+opvw+ UP8WCRmMJwTY+FJMoVpWg6JeddtQ+NI/ZTvLTTkazMiHd2UAWuXMAXjyLSikrzMeTsr2M0Z3 doeJGi/G7P7CZbYj7eXH8Ql3cjiVH49vJhC4KwVQh+SKXBJhJJGkjtnTxGw5ZNpzmVBT4mqF 8cep6quqFXOVtF9wjWy/YJ6lkZ3MbFRvxmzPsEun43TQbpJIC56t578dk3vBNqsYo5tP7p+k ZRafw9M3PF/zTnQtdgcBLCwxfXSBx7aLOZePSWZighTG+tk7T3kqWbpfDGZUTzUIuwLNYI8y E7/JzKlh5aHjQf+myigenAznUxZs3lflTsevyR4TfmCEIA4E9BEgAklUC4A/zUNI3SR1uKmp CSXCOC7Lgo5NROuiEJ+jVbRTLPHCW39ZBbni4al2WWzD5Onuhp8Xy9fj42ePOS+yhsFiGO7p Qw1Ea9i0TOYcWwVXMUv15f710Zdogtyw251S7j6TYuRFG24yd6nfBfghA3IgJMJpIaT9OXig ZpOGUeim2tn1uDB3r25RET4RwbgC/VBg3VM6AraeMwRahRIQRrcIxuWCeYdHzDqj4OAmWdII 6Qgl2VoC+6GDULMZC4EeIlK3goGDaTle0K2Dwcw9kAprh4C2PxJUykV46J4T6oQ0QZI2lRFQ faWd1klG6QBco3tRAPTQ00SZ9F0ClBLmymwuBgHzmIEAfyOjEeudgznI0AQngLoe7vIljAaF kyyNoRGMhKhPII3UiQSYd6AOgjZ20FLmiP5rOKQfNwgoicOgdLBN5czB+iZ1AB58EEHj9IZj d138l6S6vnj4cvzmCcxVXfPWDWDa0JjdWRCh4w3gO2GftCuWgLK1/QdiPkTmkk76jgiZuSj6 HRSkWk3muAummVK/+YzQprOZm+zJJ9V155IKihvRWIs4g4Gu6pjt2xDNaxZZ05oWYmJhkS2T nH4A2798jXZoZYhBrcIeilkwT9te2R9d/mUQXvEIrsZSp4bpPuIHBhj0HT4owpqGHDPhGUJP qFdDCeoNfdNnwb0a0qsMg0rZbVEpvRlsrX0kdaOiK4mhkaSDaYvK9Y3EU4x8d+2gRo5KWEg7 AhqPvE1QOcVHi0CJeXwnGUL37NZLKJm1nsZ5ECKL6btlB0Uxk5XDqdM0qghX5TpwYO6az4Bd OAhJcB20cbxZp1unTHe3OY2/Y5zAtWFAvGE9WqINBmL2M5vbC/X9zzf9pO4kgDBMTwXTmsef PoHa4zzscykZ4XYNxTc6Rb3mRBH8ByHjVozFk7Ywuu/x52F84/m+QU8ngI85QY+x+VK7s/RQ mvU+7acNR8FPiWNc9WMfB7qbPkfTNUQGG9GH85nYN54ETAQb3gSdoznttdNpNBMJx1OVE0E0 W65GnqwRxc6N2GqN6WjvkAF9V9DBTl/ZCrjJd47fiqpizwop0R0SLUXBZKmCHlqQ7gpO0i+9 0OHBtVvELNnrIJHeIWi9WTkfWddXHhyFMK5TnqQURhHNC0/fGPna7Kr9CJ3aOa1l6RWsvfxj 49prfDnVb+LSrcJzYHdM6JXE12mG4LbJDjYvDaQLpdnWLLY2oc73WFMnN1A3m9E8B3Vf0QWZ kdwmQJJbjqwce1B0XOdki+iWbcIsuFfuMNKPINyEg7LcFHmM3sWhewecWoRxWqChYBXFIhu9 qrvpWZ9j1+iWvYeKfT3y4MyhxAl1203jOFE3qoeg8lI1qzirC3YeJT6WXUVIusv6Ehe5VoF2 V+RU9uSC2BVA3atfPTs2kRxvnO42AadHKnHn8eltvzO3OpKInok0q3tGpQxuTYhacvST3Qzb 96NuRdS03I2GAw/Fvi9FiiOQO+XB/YySxj0kTwFrs28bjqEsUD1nXe7okx56spkMLj0rt97E YdjRza1oab1HGy4mTTnackoUWD1DwNl8OPPgQTabTryT9NPlaBg3N8ndCdYbaausc7GJkYaT MhaNVkN2Q+aSXaNJs86ShPvORoJ98Q2rQeEjxFnGj2KZitbxo3MBtlm1MaODMpX25B2BYFGK jrk+xfSwI6PPiuEHP81AwPi9NJrj4fWvl9cnfSz8ZIy6yEb2VPozbJ1CS9+SV+g3nM44C8iT M2jzSVuW4Pnx9eX4SI6c86gqmNcpA2gHdujek/nvZDS6VoivzJWp+vjhz+Pz4+H1ty//Y//4 7+dH89eH/vy8jhTbgrefpcky30VJRuTqMr3CjJuSOd3JIySw32EaJIKjJp3LfgCxXJF9iMnU i0UB2coVK1kOw4Sx7xwQKwu75iSNPj61JEgNdMdkx30hkxywqj5A5NuiGy96Jcro/pRHswbU Bw2Jw4twERbUj731CRCvttT63rC3m6AYnQw6ibVUlpwh4dNIkQ9qKiITs+SvfGnr92oqoq5h unVMpNLhnnKgei7KYdPXkhqDdpMcuiXD2xjGqlzWqnVz5/1E5TsFzbQu6YYYQy6r0mlT+8RO pKMdvbaYMSi9uXh/vX/Q93nytI27Hq4zE/obH1YkoY+AfoFrThBm7AipYluFMfHs5tI2sFrW yziovdRVXTHnMDag+8ZFfAHjAQ1YLOUOXnuTUF4UVBJfdrUv3VY+n4xe3TZvP+JnJvirydaV e5oiKej0n4hn4364RPkq1jyHpM/gPQm3jOJ2WtLDXekh4hlMX13swz1/qrCMTKSRbUvLgnCz L0Ye6rJKorVbyVUVx3exQ7UFKHHdcvw86fSqeJ3Q0yiQ7l5cg9EqdZFmlcV+tGHu/xhFFpQR +/JugtXWg7KRz/olK2XP0OtR+NHksXYu0uRFFHNKFugdM/cyQwjm9ZmLw/834aqHxJ1wIkmx yAkaWcboc4WDBXX4V8edTIM/XQdcQRYZltMdMmHrBPA2rRMYEfuTKTIxN/O4XNziE9j15WJE GtSCajihJgaI8oZDxAZL8Bm3OYUrYfUpyXSDBQZF7i5RRcUO4VXCvHvDL+3liueu0iTjXwFg nTEyF4InPF9Hgqbt1uDvnOnLFEUloZ8ypxqdS8zPEa97iLqoBQZHY0ENt8hzAoaDSXO9DaKG mj4TG7owryWhtb9jJNjNxNcxFYJ1phOOmLOlguu34u7cvMQ6fj1cmN0Mdb8WgtiDfViBD6DD kJkX7QI0nqlhSVToDYTduQOU8NAk8b4eNVS3s0CzD2rqzb+Fy0IlMJDD1CWpONxW7MUIUMYy 8XF/KuPeVCYylUl/KpMzqYhdkcauYMbUWv0mWXxaRiP+S34LmWRL3Q1E74oThXsiVtoOBNbw yoNrpyPccydJSHYEJXkagJLdRvgkyvbJn8in3o9FI2hGNInFOBwk3b3IB39fbwt6dLr3Z40w NXPB30UOazMotGFFVxJCqeIySCpOEiVFKFDQNHWzCtht43ql+AywgI5ug2H4opSII9CsBHuL NMWIngh0cOe5sLFnyx4ebEMnSV0DXBGv2GUHJdJyLGs58lrE184dTY9KG4eFdXfHUW3x2Bsm ya2cJYZFtLQBTVv7UotXDWxokxXJKk9S2aqrkaiMBrCdfGxykrSwp+ItyR3fmmKaw8lCv+xn GwyTjo4qYE6GuCJmc8GzfbTm9BLTu8IHTlzwTtWR9/uKbpbuijyWrab4+YD5DUoDU678khTt zbjYNUizNCGuSppPgsE0zIQhC1yQR+ij5baHDmnFeVjdlqLxKAx6+5pXCEcP67cW8ohoS8Bz lRpvb5J1HtTbKmYp5kXNhmMkgcQAwoBtFUi+FrFrMpr3ZYnufOpQmstB/RO061qf+WudZcUG WlkBaNlugipnLWhgUW8D1lVMz0FWWd3shhIYia+Yb8cW0aOY7geDbV2sFF+UDcYHH7QXA0J2 7mBCLHBZCv2VBrc9GMiOKKlQm4uotPcxBOlNAFrwqkiZD3rCikeNey9lD92tq+OlZjG0SVHe tjuB8P7hCw3ysFJCKbCAlPEtjLedxZo5KG5JznA2cLFEcdOkCQtqhSScZcqHyaQIheZ/eqFv KmUqGP1eFdkf0S7Syqiji8JGY4H3uEyvKNKEWirdAROlb6OV4T/l6M/FPH8o1B+waP8R7/H/ 89pfjpVYGjIF3zFkJ1nwdxsaJoR9bRnATnsyvvTRkwKjkiio1Yfj28t8Pl38PvzgY9zWK+YC V2ZqEE+y39//mncp5rWYTBoQ3aix6obtIc61lbmKeDt8f3y5+MvXhloVZfe/CFwJtz+I7bJe sH0sFW3Z/SsyoEUPlTAaxFaHvRAoGNRrkSaFmySNKuoNw3yBLnyqcKPn1FYWN8SwNLHie9Kr uMppxcSJdp2Vzk/fqmgIQtvYbNcgvpc0AQvpupEhGWcr2CxXMfPxr2uyQc9tyRptFELxlflH DAeYvbugEpPI07Vd1okK9SqMMfPijMrXKsjXUm8IIj9gRluLrWSh9KLth/AYWwVrtnptxPfw uwQdmSuxsmgakDqn0zpynyP1yxaxKQ0c/AYUh1i67D1RgeKosYaqtlkWVA7sDpsO9+7A2p2B ZxuGJKJY4nNlrmIYljv2rt5gTOU0kH6B6IDbZWJeOfJcdTStHPTMi+PbxfMLPtF9/z8eFlBa CltsbxIquWNJeJlWwa7YVlBkT2ZQPtHHLQJDdYdu5iPTRh4G1ggdypvrBDPV28ABNhmJXie/ ER3d4W5nngq9rTcxTv6A68IhrMxMhdK/jQoOctYhZLS06nobqA0TexYxCnmrqXStz8lGl/I0 fseGZ+VZCb1p/am5CVkOfYTq7XAvJ2rOIMbPZS3auMN5N3Yw21YRtPCg+ztfusrXss1E3zcv dSzru9jDEGfLOIpi37erKlhn6LLfKoiYwLhTVuQZSpbkICWYZpxJ+VkK4DrfT1xo5oeETK2c 5A2yDMIr9GZ+awYh7XXJAIPR2+dOQkW98fS1YQMBt+SBhkvQWJnuoX+jSpXiuWcrGh0G6O1z xMlZ4ibsJ88no34iDpx+ai9B1oYECOza0VOvls3b7p6q/iI/qf2vfEEb5Ff4WRv5PvA3Wtcm Hx4Pf329fz98cBjFfbLFedBBC8orZAuzrVlb3iJ3GZmJyQnD/1BSf5CFQ9oVxhrUE3828ZCz YA+qbIBvAUYecnn+a1v7MxymypIBVMQdX1rlUmvWLK0icVQesFfyTKBF+jide4cW9x1RtTTP aX9LuqMPgzq0s/LFrUeaZEn9cdgJ3mWxVyu+94rrm6K68uvPudyo4bHTSPwey9+8Jhqb8N/q ht7TGA7qm90i1Foxb1fuNLgttrWgSCmquVPYKJIvnmR+jX7igauUVkwa2HmZSEMfP/x9eH0+ fP3Xy+vnD85XWYJRvZkmY2ltX0GOS2rrVxVF3eSyIZ3TFATxWKmNspqLD+QOGSEba3Ubla7O BgwR/wWd53ROJHsw8nVhJPsw0o0sIN0NsoM0RYUq8RLaXvIScQyYc8NG0XgxLbGvwdd66oOi lRSkBbReKX46QxMq7m1Jxzmu2uYVNR40v5s1Xe8shtpAuAnynEU/NTQ+FQCBOmEizVW1nDrc bX8nua56jIfJaJfs5ikGi0X3ZVU3FYsOE8blhp9kGkAMTov6ZFVL6uuNMGHJ465AHxiOBBjg geapajJoiOa5iQNYG27wTGEjSNsyhBQEKESuxnQVBCYPETtMFtJcTuH5j7B1NNS+cqhsafcc guA2NKIoMQhURAE/sZAnGG4NAl/aHV8DLcwcaS9KlqD+KT7WmK//DcFdqHLqIQ1+nFQa95QR ye0xZTOhjkYY5bKfQj1iMcqcOrETlFEvpT+1vhLMZ735ULeHgtJbAuriTFAmvZTeUlMf7YKy 6KEsxn3fLHpbdDHuqw+LjcJLcCnqk6gCRwc1VGEfDEe9+QNJNHWgwiTxpz/0wyM/PPbDPWWf +uGZH770w4uecvcUZdhTlqEozFWRzJvKg205lgUh7lOD3IXDOK2pTewJh8V6S30idZSqAKXJ m9ZtlaSpL7V1EPvxKqY+EFo4gVKxII0dId8mdU/dvEWqt9VVQhcYJPDLD2Y5AT+cVwl5EjJz Qgs0OYaKTJM7o3OStwCWLymaG7T0OjlnpmZSxnv+4eH7K7rkefmGfsPIJQdfkvAX7LGut2h/ L6Q5RgJOQN3Pa2SrkpzeRC+dpOoKdxWRQO1VtoPDrybaNAVkEojzWyTpm2R7HEg1l1Z/iLJY 6dfNdZXQBdNdYrpPcL+mNaNNUVx50lz58rF7H9IoKENMOjB5UqHld98l8DNPlmysyUSb/Yq6 +ejIZeCxr96TSqYqwxhiJR6KNQEGKZxNp+NZS96g/fsmqKI4h2bHW3u8sdW6U8hjxjhMZ0jN ChJYsniYLg+2jirpfFmBlow2AcZQndQWd1Sh/hJPu03g6Z+QTct8+OPtz+PzH9/fDq9PL4+H 378cvn4jr2m6ZoR5A7N672lgS2mWoEJhxDBfJ7Q8Vp0+xxHrmFZnOIJdKO+/HR5teQMTEZ8N oBHjNj7dyjjMKolgCGoNFyYipLs4xzqCSUIPWUfTmcuesZ7lOFph5+utt4qaDgMaNmjMuEtw BGUZ55GxQEl97VAXWXFb9BL0WRDalZQ1iJS6uv04GkzmZ5m3UVI3aDs2HIwmfZxFBkwnG7W0 QGcp/aXodh6dSU1c1+xSr/sCahzA2PUl1pLEFsVPJyefvXxyJ+dnsFZpvtYXjOayMj7LeTIc 9XBhOzIHMpICnQiSIfTNq9uA7j1P4yhYoU+KxCdQ9T69uMlRMv6E3MRBlRI5p425NBHvyEHS 6mLpS76P5Ky5h60zHPQe7/Z8pKkRXnfBIs8/JTJf2CN20MmKy0cM1G2WxbgoivX2xELW6YoN 3RNL64PK5cHua7bxKulNXs87QmBhZrMAxlagcAaVYdUk0R5mJ6ViD1VbY8fTtSMS0Mke3gj4 WgvI+brjkF+qZP2zr1tzlC6JD8en+9+fTyd7lElPSrUJhjIjyQBy1jssfLzT4ejXeG/KX2ZV 2fgn9dXy58Pbl/shq6k+2YZtPGjWt7zzqhi630cAsVAFCbVv0yjadpxjN08+z7OgdprgBUVS ZTdBhYsYVUS9vFfxHmNe/ZxRB9L7pSRNGc9xQlpA5cT+yQbEVqs2lpK1ntn2StAuLyBnQYoV ecRMKvDbZQrLKhrB+ZPW83Q/pX7eEUak1aIO7w9//H345+2PHwjCgP8XfZTMamYLBhpt7Z/M /WIHmGBzsY2N3NUql4fFrqqgLmOV20ZbsiOueJexHw2e2zUrtd3SNQEJ8b6uAqt46NM9JT6M Ii/uaTSE+xvt8N9PrNHaeeXRQbtp6vJgOb0z2mE1Wsiv8bYL9a9xR0HokRW4nH7AcEWPL//z /Ns/90/3v319uX/8dnz+7e3+rwNwHh9/Oz6/Hz7jXvO3t8PX4/P3H7+9Pd0//P3b+8vTyz8v v91/+3YPivrrb39+++uD2Zxe6auTiy/3r48H7Tb3tEk1z8sOwP/PxfH5iDE0jv97z0Mq4TBE fRoVT3YTqQnaZhpW3q6ORe5y4DNIznB6bebPvCX3l72LLye33m3mexja+vqDHsuq21zG6zJY Fmch3ZAZdM+CHmqovJYITNpoBoIrLHaSVHc7GvgO9xk8DrzDhGV2uPSOHnV1YyH7+s+395eL h5fXw8XL64XZjp16yzCjHXvAwitSeOTisNB4QZdVXYVJuaFauyC4n4irgRPoslZUsp4wL6Or qrcF7y1J0Ff4q7J0ua/oU8c2BTQHcFmzIA/WnnQt7n7Arfs5dzccxAsYy7VeDUfzbJs6hHyb +kE3+1L/68D6H89I0PZioYPr7ciTHAdJ5qaAbvIae6ywp+ELLT3O10nePZ8tv//59fjwO0j+ iwc93D+/3n/78o8zyivlTJMmcodaHLpFj0MvYxV5kgShvYtH0+lwcYZkq2Wcnnx//4KO8B/u 3w+PF/GzrgTGE/if4/uXi+Dt7eXhqEnR/fu9U6uQelZs28+DhZsA/jcagKp0y0PKdBN4nagh jZ8jCPCHypMG9qmeeR5fJztPC20CkOq7tqZLHV0PD4be3Hos3WYPV0sXq92ZEHrGfRy636bU RNhihSeP0leYvScTUJZuqsCd9/mmt5lPJH9LEnqw23uEUpQEeb11OxgtbruW3ty/felr6Cxw K7fxgXtfM+wMZxv84fD27uZQheORpzc1LF2VU6Ifhe5IfQJsv/cuFaB8X8Ujt1MN7vahxb2C BvKvh4MoWfVT+kq39haud1h0nQ7FaOgNYSvsIx/mppMlMOe0w0O3A6os8s1vhJmX0Q4eTd0m AXg8crntntsFYZQr6mfrRILU+4mwkT77Zc83PtiTRObB8FHasnAVinpdDRduwnqv7+/1Ro+I Jk+6sW50seO3L8wZQydf3UEJWFN7NDKASbKCmG+XiSepKnSHDqi6N6vEO3sMwbGXkfSecRoG WZymiWdZtISffWhXGZB9v8456mfFmzN/TZDmzh+Nns9d1R5Bgei5zyJPJwM2buIo7vtm5Ve7 rjbBnUcBV0GqAs/MbBf+XkJf9or5OenAqmQOXTmu17T+BA3PmWYiLP3JZC5Wx+6Iq28K7xC3 eN+4aMk9uXNyM74Jbnt5WEWNDHh5+oYxbdieuRsOq5S9vmq1FvoSwGLziSt72DuCE7ZxFwL7 YMAEf7l/fnx5usi/P/15eG0jH/uKF+QqacLSt+eKqiXeS+RbP8WrXBiKb43UFJ+ahwQH/JTU dYw+hit2RWqpuHFqfHvbluAvQkft3b92HL726IjenbK4bWw1MFw4rKsNunX/evzz9f71n4vX l+/vx2ePPofBSH1LiMZ9st8+6tvFJo5pj1pEaK3D8HM8P8nFyBpvAoZ0No+er0UW/fsuTj6f 1flUfGIc8U59q/Qt7nB4tqi9WiBL6lwxz6bw060eMvWoURt3h4SutYI0vUny3DMRkKq2+Rxk gyu6KNGx0ZQsyrdCnohnvi+DiBuQuzTvFKF05RlgSEff4mEQZH3LBeexvY3OxmPlEXqUOdBT /qe8URkEI/2Fv/xJWOzD2HOWg1TrpdgrtLFtp+7eVXe3DlvUd5BDOHoa1VBrv9LTkvta3FAT zw7yRPUd0rCUR4OJP/Uw9FcZ8CZyhbVupfLsV+Zn35elOpMfjuiVv42uA1fJsngTbeaL6Y+e JkCGcLyngTskdTbqJ7Zp79w9L0v9HB3S7yGHTJ8Ndsk2E9iJN09qFovZITVhnk+nPRXNAhDk PbOiCOu4yOt9b9a2ZOyFDq1kj6i7xgdLfRpDx9Az7JEW5/ok19ifdxdCfqY2I+8dUs8nm8Bz kSTLd6NNdNI4/wg7XC9TkfVKlCRb13HYo9gB3Xp07BMcboQs2iubOFXUJaAFmqTEVxeJ9rh1 7sumpuZNBLR+IbzfGl8w/ukdrGKUvT0TnHm5IRQdKkLF/unbEl39vqNe+1cCTesbspq4KSt/ iYIsLdZJiCFUfkZ3Hiqw22XtZd9LLLfL1PKo7bKXrS4zP4++6A3jypqexo4DwfIqVHN83b9D KqYhOdq0fV9etnZVPVTtAxs+PuH23r2Mzbs27XHh9EbeqPCH1/fjX/pg/+3iL3SYfvz8bIJA Pnw5PPx9fP5MXHN21g46nw8P8PHbH/gFsDV/H/7517fD08mSUr/16zdhcOmKPPO0VHMXTxrV +d7hMFaKk8GCmikaG4ifFuaMWYTDoXUj7UcISn1yxfMLDdomuUxyLJT2UbVqeyTt3U2Ze1l6 X9sizRKUINjDUktjlDRB1Wj/JPSBdCDciC1hoYphaFDjmzb8kqqrPETb3UoH26BjjrKAIO6h 5hhaqk6oTGtJqySP0CgHHbdTu5CwqCIWCqRCdxH5NlvG1ODCmH0zV4RtzKgwkX46W5KAMXif I1f1PggfSYZZuQ83xgyvileCA13OrPDszvq3ZTG1ujRAajRBntvA52xBCUH8JjVb3MPhjHO4 J/tQh3rb8K/4rQReR7g2/xYH+RYvb+d86SaUSc9SrVmC6kbYwAkO6Efv4h3yQyq+4Q8v6Zhd ujczIbkPkBcqMLqjIvPW2O9WAFHjK4Pj6PgCzzb48dad2VAL1O8JAVFfyn7XCH0+EZDbWz6/ HwQN+/j3dw3zlmt+8xski+nwHqXLmwS02ywY0CcHJ6zewPx0CAoWKjfdZfjJwXjXnSrUrJm2 QAhLIIy8lPSOGpsQAvVMwviLHpxUv5UgnlcQoENFjSrSIuPh9k4ovmKZ95Agwz4SfEUFgvyM 0pYhmRQ1LIkqRhnkw5or6liM4MvMC6+oTfSS+0XUD6fRvofD+6CqglsjGakKpYoQVOdkB9sH ZDiRUJgmPNSDgfCRdMNkNuLMmijXzbJGEHcELOSApiEBX7vgoaaU80jDFzBN3cwmbBmKtJ1r mAbaEcYm5jHiTkuANslG5m3evVXiqaB2zv19qpukqNMlZ2szgflIA11rkq6vuc8+/HX//es7 Bix/P37+/vL97eLJWJzdvx7uQdn438P/Jeev2n75Lm6y5S1MsdOTkI6g8CLWEOmaQMnoTQg9 GKx7RD9LKsl/gSnY+5YJ7IoUNFZ0l/BxTutvDqCYTs/ghvojUevUzFIyTIss2zbyjZBxVusx hw/LLfoNborVSpsJMkpTseEYXVMNJC2W/JdnXcpT/mA8rbby5VyY3uEbMVKB6hrPU0lWWZlw V01uNaIkYyzwY0WDsmPMIAyBoGpqHLwN0QtbzXVffSzcisBdpIjAbNE1vmTJ4mIV0YlNv9Fe 4BuqBK0KvI6TrhAQlUzzH3MHofJPQ7Mfw6GALn/QJ6sawrhhqSfBABTP3IOj56hm8sOT2UBA w8GPofwaj4bdkgI6HP0YjQQMwnQ4+0HVOfRQA7plzRAuIDpRhFGL+EUSADLGRce9tV52V+lW beQjfsmUhXiOIBj03LgJqN8eDUVxSe2uFYhVNmXQrpg+8SuWn4I1ncB68HljWDl7I24P3G5X Nfrt9fj8/vfFPXz5+HR4++w+ZdX7rquGe/CzIDpYYMLCegNKi3WKD/Y6W83LXo7rLXpxnZw6 w2zenRQ6Dm3cbvOP0F0Jmcu3eZAljs8NBgszYNh6LPHNQRNXFXBRwaC54T/Y9S0LxSJ49LZa dzd8/Hr4/f34ZLezb5r1weCvbhvbY71si1YO3IX/qoJSaafMH+fDxYh2fwnKAsbNop6C8O2I OXqkCskmxhd36JAYxh4VkHZhMK7F0YFnFtQhfy3HKLog6BL/VgznNiQEm0bWgbxe/I3DEAxi oUPXn04CfrWxdNPqa+3jQzuYo8Of3z9/RgPx5Pnt/fX70+H5nQZJCfCsS90qGgedgJ1xumn/ jyCZfFwmhrg/BRtfXOHj7hw2yB8+iMpT13mB1ulQuVxHZMlxf7XJhtK3mCYK++ATpv3Ysecc hKbnjV2yPuyGq+Fg8IGxodMXM+dqZgqpiVesiNHyTNMh9Sq+1QHZ+TfwZ53kW3QKWQcKL/o3 SXhStzqBal6xyPPJTtwuVWCjBaCuxMazpomfojoGWxbbPFISRQ+2VL2H6WhSfDoN2F8agnwQ mIeJcl7YzOhjjC4xIn5RGsI+I86VZ24hVahxgtDKFsdqXidc3LCrYI2VRaIK7gKe401e2GAN vRx3cVX4itSwIyKDVwXIjUBsbrveNjw3e/kVRbozrVr4g9a/hcS3oHNlZ5I1js/7YI+iyukr tsPjNB3Dpzdl7gCB0zCe9IZZoHC68WTqhhriXGIgdPNVpdtly0ofEyMsTFy0BLNjGtSmFGS6 zO1nOKpbWjczB9DD2WAw6OHk7wwEsXtXtHIGVMeDDvYbFQbOtDFL1lYxH9gKVt7IkvAZvViI xYjcQS3WNfda0FJcRFtbc/WxI1VLD1iuV2mwdkaLL1dZMNhIbwNH2vTA0FQYO4M/OrSgcQ+C cSSrqqic4LR2VpslHc8O/EtdwCSyIGC7cPEV6jtHS3UtZwwVJ4sRRKdlIIr42Z7IuCdBAxfb 2l45dntxQzBXkZ59uCGbje+Qg06VzJVTINYRR+SLIbpJtNZizzOA6aJ4+fb220X68vD3929G SdrcP3+mqjo0RohKQMEOUhhs3V4MOVFvSrf1aS3G4/wtSska+pz5VyhWdS+x8/VB2XQOv8Ij i4aeT0RWONxWdDR1HOacAusBnZKVXp5zBSZsvQWWPF2ByZNPzKHZYNxwUHGuPCPn5hqUaFCl I2qiroeISfoji9Z2rt+NDyLQmR+/o6LsUR6MSJOOKzTIg4FprBX2p0eWnrT5KMX2vorj0mgL 5mYOnwadtKL/ePt2fMbnQlCFp+/vhx8H+OPw/vCvf/3rP08FNU4cMMm13tXK046yKnae4D4G roIbk0AOrSgcKeDZVR04UgvPS7d1vI8dCaugLtwGzQpKP/vNjaHAclnccJ9CNqcbxVy5GtRY snExYdytlx/ZM+aWGQiesWQ9jtQFbm9VGselLyNsUW0Da5UXJRoIZgSeiQkN7FQz3xHDv9HJ 3RjXzkBBqomVTQtR4RdZbzOhfZptjtbrMF7NHZaz1BvlpgcGbRP0gFPMYTOdjE/Zi8f79/sL 1Ngf8NqZBj40DZe4Wl7pA+mpqkHadZM68tLKVaMVXVBHq20bjkpM9Z6y8fTDKraOTVRbM9AQ vZsHMz/CrTNlQKPklfEPAuRDkeuB+z9AdUCfM3TLymjIvuR9jVB8fTIL7ZqEV0rMu2t7rlC1 JwqMbMKHwbYJL67pBS8UbQPiPDVKoPZ9jhbnRC/CW8w8vK2psyltB34apx7HtEVpqsX8fkFD r7a5OUE5T13DFnXj52lPr6TrcA+xuUnqDZ5WOyq7h81GscIjPMlu2TK9odBP3OlOXrNglB3d w8gJ+77c2SasjAcpDoY2NZM0GX265tpeTVTTFCXkIlkffcrAKfEO74WQn60B2ME4EBTUOnTb mCRlHd9yT8Al7OgymK3Vtb+uTn7tZlRmZBk9J/mixqhv6EsAJ+newfSTcdQ3hH4+en594HRF AAGDdlTczRyuMqJQ0KKgAK4c3KgnzlS4gXnpoBjEWMZMtDPUjE/lDDGVw0ZlU7hjryV0Oxo+ DpawAKGfHVM7x3VVi1szFvSroj+IlWfZRrf42sbSifh4BeksYzOUVQ+MC0kuq731f7gsVw7W 9qnE+1Ow2WOEuiqJ3MbuERTtiOfWRLc5jCGZC0aIA/5kvWbLpkneTGy5/TzNRp9dF53WHnKb cJDqS2/sOjKDw2LXdaicM+34cg6CWkIdwLpYimXxJJt+hUPvBtwRTOvkT6SbD+LshAgxfWUi yKRPUHyJROng85BZ18m9BmobMGKaYhMmw/Fiom+k7WHDKTxPgP7/fROFnBaEbDdPzjx2eKCU WK/lLAaO9lpqOYjcKRyKVqF+zGc+FYprra70NmfV9j5qq6h5z3zW2LsjLdOpa0f6VU9a0XLd 8wFm0+wj+qYffcWV61rEw7N7tHSpry9pE+BNv+gqA/KjO93+p0HlVD4p7Hga7OcD2qWEEPvj 83QcW/3PeZ6eaGBW19MXgrhBp5aDpROy1HALrcRq7FnimdHYgfYWh2qYpfbJiJsumcM2v8GQ n1VTaIOurh4dbi7ztNCS9v5W5+WjkF7c1oe3d9xr4f4/fPnvw+v95wNxOLxlJ3jGb6Rzxu1z J2mweK8noZem9Ty+b/QeDbL7iTL72flhsdIrRn96JLu41q9FznN1KkhvofpjKQdJqlJqTIKI ubIQ23RNyIKruPXoLEhJ0W17OGGFu+nesnjuC+1XuaesMClDN/9OKl4xp1T20BQEKC5sZipT S0bOjb/auwIdlLfCSx0lGPAmudrqyGLsAs4QYZ0JqtgYM30c/JgMyCF/BaqC1m7NYY14bpxe RTWzsFMmCm2jmODRODpm3sRBKWDOaVYvRaOLE+XmtKOD2S+3stqMT4LUvFA4DKdmfoJmb2j4 smvObWYTj+ihLsY4RVdxE++5pDcVNyYhxoJLuUTFXJ2ZU2mAa/o2S6OdqT0FpYFKC8KETCMB c2+BGtoLY0YNoka5YtGTNVyh+bK45TD1ZmbNGkqiQJZeWM6YMXSVnRq+LTqeknOwPbvnqN7+ a8/dIolyJRF897Ap9DXb7kTTVvyQoVcVxe9at5uy00QsW/PbK8bNcwwvgbxw8A2mrbCiscNF uwbXz014Fa+yIhJQzw2TmaRxFsLOTQ6cNNnFpbY14UlJM6e2MHiKmTgCIM486CYjAgRYhLp6 C5Nj10qfj+S46ew663gm5G9U9HmljsOODuqKUEtGnIL/DzbH0n6Q0gQA --nFreZHaLTZJo0R7j-- From xen-devel-bounces@lists.xenproject.org Fri Aug 07 11:30:25 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 11:30:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k40Zm-00077Q-JC; Fri, 07 Aug 2020 11:30:18 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k40Zl-00077K-Ga for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 11:30:17 +0000 X-Inumbo-ID: 559e7006-e16d-4e6a-96fa-51d7cf011199 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 559e7006-e16d-4e6a-96fa-51d7cf011199; Fri, 07 Aug 2020 11:30:16 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E928DAD60; Fri, 7 Aug 2020 11:30:33 +0000 (UTC) From: Jan Beulich Subject: [PATCH v2 0/7] x86: build adjustments To: "xen-devel@lists.xenproject.org" Message-ID: <3a8356a9-313c-6de8-f409-977eae1fbfa5@suse.com> Date: Fri, 7 Aug 2020 13:30:18 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" This is a in part just loosely connected set of changes in particular aiming at further shim size binary reduction. One patch of v1 did go in. Besides the dropping of that one, there was a small adjustment to what is now patch 4 (based on feedback) and I did notice an omission in patch 1. 1: x86/EFI: sanitize build logic 2: x86: don't build with EFI support in shim-exclusive mode 3: x86: shrink struct arch_{vcpu,domain} when !HVM 4: bitmap: move to/from xenctl_bitmap conversion helpers 5: x86: move domain_cpu_policy_changed() 6: x86: move cpu_{up,down}_helper() 7: x86: don't include domctl and alike in shim-exclusive builds Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 07 11:32:11 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 11:32:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k40ba-0007Go-Vv; Fri, 07 Aug 2020 11:32:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k40ba-0007Gj-3X for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 11:32:10 +0000 X-Inumbo-ID: 3eb016cc-7f66-4fd5-a421-6ddd3735d91f Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3eb016cc-7f66-4fd5-a421-6ddd3735d91f; Fri, 07 Aug 2020 11:32:09 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 59389AFB4; Fri, 7 Aug 2020 11:32:26 +0000 (UTC) Subject: [PATCH v2 1/7] x86/EFI: sanitize build logic From: Jan Beulich To: "xen-devel@lists.xenproject.org" References: <3a8356a9-313c-6de8-f409-977eae1fbfa5@suse.com> Message-ID: <07e622b4-bb61-08e8-d96c-e770ec7abc53@suse.com> Date: Fri, 7 Aug 2020 13:32:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <3a8356a9-313c-6de8-f409-977eae1fbfa5@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" With changes done over time and as far as linking goes, the only special thing about building with EFI support enabled is the need for the dummy relocations object for xen.gz uniformly in all build stages. All other efi/*.o can be consumed from the built_in*.o files. In efi/Makefile, besides moving relocs-dummy.o to "extra", also properly split between obj-y and obj-bin-y. Signed-off-by: Jan Beulich --- v2: Drop a now stale piece of Makefile logic. --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -113,28 +113,35 @@ $(TARGET): $(TARGET)-syms $(efi-y) boot/ { echo "No Multiboot2 header found" >&2; false; } mv $(TMP) $(TARGET) +# Check if the compiler supports the MS ABI. +export XEN_BUILD_EFI := $(shell $(CC) $(XEN_CFLAGS) -c efi/check.c -o efi/check.o 2>/dev/null && echo y) +# Check if the linker supports PE. +XEN_BUILD_PE := $(if $(XEN_BUILD_EFI),$(shell $(LD) -mi386pep --subsystem=10 -o efi/check.efi efi/check.o 2>/dev/null && echo y)) +CFLAGS-$(XEN_BUILD_EFI) += -DXEN_BUILD_EFI + ALL_OBJS := $(BASEDIR)/arch/x86/boot/built_in.o $(BASEDIR)/arch/x86/efi/built_in.o $(ALL_OBJS) +EFI_OBJS-$(XEN_BUILD_EFI) := efi/relocs-dummy.o ifeq ($(CONFIG_LTO),y) # Gather all LTO objects together prelink_lto.o: $(ALL_OBJS) $(LD_LTO) -r -o $@ $^ -prelink-efi_lto.o: $(ALL_OBJS) efi/runtime.o efi/compat.o - $(LD_LTO) -r -o $@ $(filter-out %/efi/built_in.o,$^) +prelink-efi_lto.o: $(ALL_OBJS) + $(LD_LTO) -r -o $@ $^ # Link it with all the binary objects -prelink.o: $(patsubst %/built_in.o,%/built_in_bin.o,$(ALL_OBJS)) prelink_lto.o +prelink.o: $(patsubst %/built_in.o,%/built_in_bin.o,$(ALL_OBJS)) prelink_lto.o $(EFI_OBJS-y) $(LD) $(XEN_LDFLAGS) -r -o $@ $^ -prelink-efi.o: $(patsubst %/built_in.o,%/built_in_bin.o,$(ALL_OBJS)) prelink-efi_lto.o efi/boot.init.o +prelink-efi.o: $(patsubst %/built_in.o,%/built_in_bin.o,$(ALL_OBJS)) prelink-efi_lto.o $(LD) $(XEN_LDFLAGS) -r -o $@ $^ else -prelink.o: $(ALL_OBJS) +prelink.o: $(ALL_OBJS) $(EFI_OBJS-y) $(LD) $(XEN_LDFLAGS) -r -o $@ $^ -prelink-efi.o: $(ALL_OBJS) efi/boot.init.o efi/runtime.o efi/compat.o - $(LD) $(XEN_LDFLAGS) -r -o $@ $(filter-out %/efi/built_in.o,$^) +prelink-efi.o: $(ALL_OBJS) + $(LD) $(XEN_LDFLAGS) -r -o $@ $^ endif $(TARGET)-syms: prelink.o xen.lds @@ -171,12 +178,6 @@ EFI_LDFLAGS += --minor-image-version=$(X EFI_LDFLAGS += --major-os-version=2 --minor-os-version=0 EFI_LDFLAGS += --major-subsystem-version=2 --minor-subsystem-version=0 -# Check if the compiler supports the MS ABI. -export XEN_BUILD_EFI := $(shell $(CC) $(XEN_CFLAGS) -c efi/check.c -o efi/check.o 2>/dev/null && echo y) -# Check if the linker supports PE. -XEN_BUILD_PE := $(if $(XEN_BUILD_EFI),$(shell $(LD) -mi386pep --subsystem=10 -o efi/check.efi efi/check.o 2>/dev/null && echo y)) -CFLAGS-$(XEN_BUILD_EFI) += -DXEN_BUILD_EFI - $(TARGET).efi: VIRT_BASE = 0x$(shell $(NM) efi/relocs-dummy.o | sed -n 's, A VIRT_START$$,,p') $(TARGET).efi: ALT_BASE = 0x$(shell $(NM) efi/relocs-dummy.o | sed -n 's, A ALT_START$$,,p') @@ -223,9 +224,6 @@ $(TARGET).efi: FORCE echo '$(if $(filter y,$(XEN_BUILD_EFI)),xen.efi generation,EFI support) disabled' endif -efi/boot.init.o efi/runtime.o efi/compat.o efi/buildid.o efi/relocs-dummy.o: $(BASEDIR)/arch/x86/efi/built_in.o -efi/boot.init.o efi/runtime.o efi/compat.o efi/buildid.o efi/relocs-dummy.o: ; - asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c $(BASEDIR)/include/asm-x86/asm-macros.h $(CC) $(filter-out -Wa$(comma)% -flto,$(c_flags)) -S -o $@ $< --- a/xen/arch/x86/efi/Makefile +++ b/xen/arch/x86/efi/Makefile @@ -14,6 +14,7 @@ $(call cc-option-add,cflags-stack-bounda $(EFIOBJ): CFLAGS-stack-boundary := $(cflags-stack-boundary) obj-y := stub.o -obj-$(XEN_BUILD_EFI) := $(EFIOBJ) relocs-dummy.o -extra-$(XEN_BUILD_EFI) += buildid.o +obj-$(XEN_BUILD_EFI) := $(filter-out %.init.o,$(EFIOBJ)) +obj-bin-$(XEN_BUILD_EFI) := $(filter %.init.o,$(EFIOBJ)) +extra-$(XEN_BUILD_EFI) += buildid.o relocs-dummy.o nocov-$(XEN_BUILD_EFI) += stub.o From xen-devel-bounces@lists.xenproject.org Fri Aug 07 11:32:39 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 11:32:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k40c3-0007KW-B9; Fri, 07 Aug 2020 11:32:39 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k40c1-0007KB-HU for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 11:32:37 +0000 X-Inumbo-ID: 747ef8fc-e896-4c9f-a028-0debb54bf08f Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 747ef8fc-e896-4c9f-a028-0debb54bf08f; Fri, 07 Aug 2020 11:32:36 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id EF04BAFB4; Fri, 7 Aug 2020 11:32:53 +0000 (UTC) Subject: [PATCH v2 2/7] x86: don't build with EFI support in shim-exclusive mode From: Jan Beulich To: "xen-devel@lists.xenproject.org" References: <3a8356a9-313c-6de8-f409-977eae1fbfa5@suse.com> Message-ID: <1a501ca8-8cf0-6fd0-547e-30b709fec6fc@suse.com> Date: Fri, 7 Aug 2020 13:32:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <3a8356a9-313c-6de8-f409-977eae1fbfa5@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" There's no need for xen.efi at all, and there's also no need for EFI support in xen.gz since the shim runs in PVH mode, i.e. without any firmware (and hence by implication also without EFI one). The slightly odd looking use of $(space) is to ensure the new ifneq() evaluates consistently between "build" and "install" invocations of make. Signed-off-by: Jan Beulich --- There are further anomalies associated with the need to use $(space) here: - xen.efi rebuilding gets suppressed when installing (typically as root) from a non-root-owned tree. I think we should similarly suppress re-building of xen.gz as well in this case, as tool chains available may vary (and hence a partial or full re-build may mistakenly occur). - xen.lds (re-)generation has a dependency issue: The value of XEN_BUILD_EFI changing between builds (like would happen on a pre- built tree with a shim-exclusive config, on which then this patch would be applied) does not cause it to be re-built. Anthony's switching to Linux'es build system will address this afaict, so I didn't see a need to supply a separate patch. --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -80,7 +80,9 @@ x86_emulate.o: x86_emulate/x86_emulate.c efi-y := $(shell if [ ! -r $(BASEDIR)/include/xen/compile.h -o \ -O $(BASEDIR)/include/xen/compile.h ]; then \ - echo '$(TARGET).efi'; fi) + echo '$(TARGET).efi'; fi) \ + $(space) +efi-$(CONFIG_PV_SHIM_EXCLUSIVE) := ifneq ($(build_id_linker),) notes_phdrs = --notes @@ -113,11 +115,13 @@ $(TARGET): $(TARGET)-syms $(efi-y) boot/ { echo "No Multiboot2 header found" >&2; false; } mv $(TMP) $(TARGET) +ifneq ($(efi-y),) # Check if the compiler supports the MS ABI. export XEN_BUILD_EFI := $(shell $(CC) $(XEN_CFLAGS) -c efi/check.c -o efi/check.o 2>/dev/null && echo y) # Check if the linker supports PE. XEN_BUILD_PE := $(if $(XEN_BUILD_EFI),$(shell $(LD) -mi386pep --subsystem=10 -o efi/check.efi efi/check.o 2>/dev/null && echo y)) CFLAGS-$(XEN_BUILD_EFI) += -DXEN_BUILD_EFI +endif ALL_OBJS := $(BASEDIR)/arch/x86/boot/built_in.o $(BASEDIR)/arch/x86/efi/built_in.o $(ALL_OBJS) EFI_OBJS-$(XEN_BUILD_EFI) := efi/relocs-dummy.o From xen-devel-bounces@lists.xenproject.org Fri Aug 07 11:33:02 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 11:33:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k40cQ-0007Pp-Ll; Fri, 07 Aug 2020 11:33:02 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k40cP-0007Pb-FU for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 11:33:01 +0000 X-Inumbo-ID: 52495dac-76c0-45e7-a5eb-cace31abca90 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 52495dac-76c0-45e7-a5eb-cace31abca90; Fri, 07 Aug 2020 11:32:59 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CB14FAFB4; Fri, 7 Aug 2020 11:33:16 +0000 (UTC) Subject: [PATCH v2 3/7] x86: shrink struct arch_{vcpu,domain} when !HVM From: Jan Beulich To: "xen-devel@lists.xenproject.org" References: <3a8356a9-313c-6de8-f409-977eae1fbfa5@suse.com> Message-ID: <014a655b-7080-3804-3a56-5e00851a2a7d@suse.com> Date: Fri, 7 Aug 2020 13:33:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <3a8356a9-313c-6de8-f409-977eae1fbfa5@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" While this won't affect overall memory overhead (struct vcpu as well as struct domain get allocated as single pages) nor code size (the offsets into the base structures are too large to be representable as signed 8- bit displacements), it'll allow the tail of struct pv_{domain,vcpu} to share a cache line with subsequent struct arch_{domain,vcpu} fields. Signed-off-by: Jan Beulich --- RFC: There is a risk associated with this: If we still have code somewhere accessing the HVM parts of the structures without a prior type check of the guest, this going to end up worse than the so far not uncommon case of the access simply going to space unused by PV. We may therefore want to consider whether to further restrict when this conversion to union gets done. And of course there's also the risk of future compilers complaining about this abuse of unions. But this is limited to code that's dead in !HVM configs, so only an apparent problem. --- a/xen/arch/x86/domctl.c +++ b/xen/arch/x86/domctl.c @@ -709,7 +709,7 @@ long arch_do_domctl( unsigned int fmp = domctl->u.ioport_mapping.first_mport; unsigned int np = domctl->u.ioport_mapping.nr_ports; unsigned int add = domctl->u.ioport_mapping.add_mapping; - struct hvm_domain *hvm; + hvm_domain_t *hvm; struct g2m_ioport *g2m_ioport; int found = 0; --- a/xen/include/asm-x86/domain.h +++ b/xen/include/asm-x86/domain.h @@ -319,7 +319,7 @@ struct arch_domain union { struct pv_domain pv; - struct hvm_domain hvm; + hvm_domain_t hvm; }; struct paging_domain paging; @@ -582,7 +582,7 @@ struct arch_vcpu /* Virtual Machine Extensions */ union { struct pv_vcpu pv; - struct hvm_vcpu hvm; + hvm_vcpu_t hvm; }; /* --- a/xen/include/asm-x86/hvm/domain.h +++ b/xen/include/asm-x86/hvm/domain.h @@ -99,7 +99,13 @@ struct hvm_pi_ops { #define MAX_NR_IOREQ_SERVERS 8 -struct hvm_domain { +typedef +#ifdef CONFIG_HVM +struct +#else +union +#endif +hvm_domain { /* Guest page range used for non-default ioreq servers */ struct { unsigned long base; @@ -203,7 +209,7 @@ struct hvm_domain { #ifdef CONFIG_MEM_SHARING struct mem_sharing_domain mem_sharing; #endif -}; +} hvm_domain_t; #endif /* __ASM_X86_HVM_DOMAIN_H__ */ --- a/xen/include/asm-x86/hvm/vcpu.h +++ b/xen/include/asm-x86/hvm/vcpu.h @@ -149,7 +149,13 @@ struct altp2mvcpu { #define vcpu_altp2m(v) ((v)->arch.hvm.avcpu) -struct hvm_vcpu { +typedef +#ifdef CONFIG_HVM +struct +#else +union +#endif +hvm_vcpu { /* Guest control-register and EFER values, just as the guest sees them. */ unsigned long guest_cr[5]; unsigned long guest_efer; @@ -213,7 +219,7 @@ struct hvm_vcpu { struct x86_event inject_event; struct viridian_vcpu *viridian; -}; +} hvm_vcpu_t; #endif /* __ASM_X86_HVM_VCPU_H__ */ From xen-devel-bounces@lists.xenproject.org Fri Aug 07 11:33:43 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 11:33:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k40d5-0007WC-06; Fri, 07 Aug 2020 11:33:43 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k40d4-0007W5-DZ for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 11:33:42 +0000 X-Inumbo-ID: 73a8c4dd-169d-4f74-bf5d-9c900e1003b4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 73a8c4dd-169d-4f74-bf5d-9c900e1003b4; Fri, 07 Aug 2020 11:33:40 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 29564AD60; Fri, 7 Aug 2020 11:33:58 +0000 (UTC) Subject: [PATCH v2 4/7] bitmap: move to/from xenctl_bitmap conversion helpers From: Jan Beulich To: "xen-devel@lists.xenproject.org" References: <3a8356a9-313c-6de8-f409-977eae1fbfa5@suse.com> Message-ID: <677805f1-c44c-ef65-8190-c4de3bdb327d@suse.com> Date: Fri, 7 Aug 2020 13:33:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <3a8356a9-313c-6de8-f409-977eae1fbfa5@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" A subsequent change will exclude domctl.c from getting built for a particular configuration, yet the two functions get used from elsewhere. Signed-off-by: Jan Beulich --- v2: Move function decls to xen/bitmap.h. --- a/xen/common/bitmap.c +++ b/xen/common/bitmap.c @@ -9,6 +9,8 @@ #include #include #include +#include +#include #include /* @@ -384,3 +386,87 @@ void bitmap_byte_to_long(unsigned long * } #endif + +int bitmap_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_bitmap, + const unsigned long *bitmap, unsigned int nbits) +{ + unsigned int guest_bytes, copy_bytes, i; + uint8_t zero = 0; + int err = 0; + uint8_t *bytemap = xmalloc_array(uint8_t, (nbits + 7) / 8); + + if ( !bytemap ) + return -ENOMEM; + + guest_bytes = (xenctl_bitmap->nr_bits + 7) / 8; + copy_bytes = min_t(unsigned int, guest_bytes, (nbits + 7) / 8); + + bitmap_long_to_byte(bytemap, bitmap, nbits); + + if ( copy_bytes != 0 ) + if ( copy_to_guest(xenctl_bitmap->bitmap, bytemap, copy_bytes) ) + err = -EFAULT; + + for ( i = copy_bytes; !err && i < guest_bytes; i++ ) + if ( copy_to_guest_offset(xenctl_bitmap->bitmap, i, &zero, 1) ) + err = -EFAULT; + + xfree(bytemap); + + return err; +} + +int xenctl_bitmap_to_bitmap(unsigned long *bitmap, + const struct xenctl_bitmap *xenctl_bitmap, + unsigned int nbits) +{ + unsigned int guest_bytes, copy_bytes; + int err = 0; + uint8_t *bytemap = xzalloc_array(uint8_t, (nbits + 7) / 8); + + if ( !bytemap ) + return -ENOMEM; + + guest_bytes = (xenctl_bitmap->nr_bits + 7) / 8; + copy_bytes = min_t(unsigned int, guest_bytes, (nbits + 7) / 8); + + if ( copy_bytes != 0 ) + { + if ( copy_from_guest(bytemap, xenctl_bitmap->bitmap, copy_bytes) ) + err = -EFAULT; + if ( (xenctl_bitmap->nr_bits & 7) && (guest_bytes == copy_bytes) ) + bytemap[guest_bytes-1] &= ~(0xff << (xenctl_bitmap->nr_bits & 7)); + } + + if ( !err ) + bitmap_byte_to_long(bitmap, bytemap, nbits); + + xfree(bytemap); + + return err; +} + +int cpumask_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_cpumap, + const cpumask_t *cpumask) +{ + return bitmap_to_xenctl_bitmap(xenctl_cpumap, cpumask_bits(cpumask), + nr_cpu_ids); +} + +int xenctl_bitmap_to_cpumask(cpumask_var_t *cpumask, + const struct xenctl_bitmap *xenctl_cpumap) +{ + int err = 0; + + if ( alloc_cpumask_var(cpumask) ) { + err = xenctl_bitmap_to_bitmap(cpumask_bits(*cpumask), xenctl_cpumap, + nr_cpu_ids); + /* In case of error, cleanup is up to us, as the caller won't care! */ + if ( err ) + free_cpumask_var(*cpumask); + } + else + err = -ENOMEM; + + return err; +} --- a/xen/common/domctl.c +++ b/xen/common/domctl.c @@ -34,91 +34,6 @@ static DEFINE_SPINLOCK(domctl_lock); -static int bitmap_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_bitmap, - const unsigned long *bitmap, - unsigned int nbits) -{ - unsigned int guest_bytes, copy_bytes, i; - uint8_t zero = 0; - int err = 0; - uint8_t *bytemap = xmalloc_array(uint8_t, (nbits + 7) / 8); - - if ( !bytemap ) - return -ENOMEM; - - guest_bytes = (xenctl_bitmap->nr_bits + 7) / 8; - copy_bytes = min_t(unsigned int, guest_bytes, (nbits + 7) / 8); - - bitmap_long_to_byte(bytemap, bitmap, nbits); - - if ( copy_bytes != 0 ) - if ( copy_to_guest(xenctl_bitmap->bitmap, bytemap, copy_bytes) ) - err = -EFAULT; - - for ( i = copy_bytes; !err && i < guest_bytes; i++ ) - if ( copy_to_guest_offset(xenctl_bitmap->bitmap, i, &zero, 1) ) - err = -EFAULT; - - xfree(bytemap); - - return err; -} - -int xenctl_bitmap_to_bitmap(unsigned long *bitmap, - const struct xenctl_bitmap *xenctl_bitmap, - unsigned int nbits) -{ - unsigned int guest_bytes, copy_bytes; - int err = 0; - uint8_t *bytemap = xzalloc_array(uint8_t, (nbits + 7) / 8); - - if ( !bytemap ) - return -ENOMEM; - - guest_bytes = (xenctl_bitmap->nr_bits + 7) / 8; - copy_bytes = min_t(unsigned int, guest_bytes, (nbits + 7) / 8); - - if ( copy_bytes != 0 ) - { - if ( copy_from_guest(bytemap, xenctl_bitmap->bitmap, copy_bytes) ) - err = -EFAULT; - if ( (xenctl_bitmap->nr_bits & 7) && (guest_bytes == copy_bytes) ) - bytemap[guest_bytes-1] &= ~(0xff << (xenctl_bitmap->nr_bits & 7)); - } - - if ( !err ) - bitmap_byte_to_long(bitmap, bytemap, nbits); - - xfree(bytemap); - - return err; -} - -int cpumask_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_cpumap, - const cpumask_t *cpumask) -{ - return bitmap_to_xenctl_bitmap(xenctl_cpumap, cpumask_bits(cpumask), - nr_cpu_ids); -} - -int xenctl_bitmap_to_cpumask(cpumask_var_t *cpumask, - const struct xenctl_bitmap *xenctl_cpumap) -{ - int err = 0; - - if ( alloc_cpumask_var(cpumask) ) { - err = xenctl_bitmap_to_bitmap(cpumask_bits(*cpumask), xenctl_cpumap, - nr_cpu_ids); - /* In case of error, cleanup is up to us, as the caller won't care! */ - if ( err ) - free_cpumask_var(*cpumask); - } - else - err = -ENOMEM; - - return err; -} - static int nodemask_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_nodemap, const nodemask_t *nodemask) { --- a/xen/include/xen/bitmap.h +++ b/xen/include/xen/bitmap.h @@ -273,6 +273,13 @@ static inline void bitmap_clear(unsigned void bitmap_long_to_byte(uint8_t *bp, const unsigned long *lp, int nbits); void bitmap_byte_to_long(unsigned long *lp, const uint8_t *bp, int nbits); +struct xenctl_bitmap; +int xenctl_bitmap_to_bitmap(unsigned long *bitmap, + const struct xenctl_bitmap *xenctl_bitmap, + unsigned int nbits); +int bitmap_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_bitmap, + const unsigned long *bitmap, unsigned int nbits); + #endif /* __ASSEMBLY__ */ #endif /* __XEN_BITMAP_H */ --- a/xen/include/xen/domain.h +++ b/xen/include/xen/domain.h @@ -27,9 +27,6 @@ struct xen_domctl_getdomaininfo; void getdomaininfo(struct domain *d, struct xen_domctl_getdomaininfo *info); void arch_get_domain_info(const struct domain *d, struct xen_domctl_getdomaininfo *info); -int xenctl_bitmap_to_bitmap(unsigned long *bitmap, - const struct xenctl_bitmap *xenctl_bitmap, - unsigned int nbits); /* * Arch-specifics. From xen-devel-bounces@lists.xenproject.org Fri Aug 07 11:34:15 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 11:34:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k40dZ-0007bd-9s; Fri, 07 Aug 2020 11:34:13 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k40dX-0007bH-N4 for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 11:34:11 +0000 X-Inumbo-ID: f0e49c15-728a-45c1-9915-99dceac38ae0 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f0e49c15-728a-45c1-9915-99dceac38ae0; Fri, 07 Aug 2020 11:34:10 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AA8BEABF1; Fri, 7 Aug 2020 11:34:27 +0000 (UTC) Subject: [PATCH v2 5/7] x86: move domain_cpu_policy_changed() From: Jan Beulich To: "xen-devel@lists.xenproject.org" References: <3a8356a9-313c-6de8-f409-977eae1fbfa5@suse.com> Message-ID: Date: Fri, 7 Aug 2020 13:34:12 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <3a8356a9-313c-6de8-f409-977eae1fbfa5@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" This is in preparation of making the building of domctl.c conditional. Signed-off-by: Jan Beulich --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -294,6 +294,173 @@ void update_guest_memory_policy(struct v } } +void domain_cpu_policy_changed(struct domain *d) +{ + const struct cpuid_policy *p = d->arch.cpuid; + struct vcpu *v; + + if ( is_pv_domain(d) ) + { + if ( ((levelling_caps & LCAP_1cd) == LCAP_1cd) ) + { + uint64_t mask = cpuidmask_defaults._1cd; + uint32_t ecx = p->basic._1c; + uint32_t edx = p->basic._1d; + + /* + * Must expose hosts HTT and X2APIC value so a guest using native + * CPUID can correctly interpret other leaves which cannot be + * masked. + */ + if ( cpu_has_x2apic ) + ecx |= cpufeat_mask(X86_FEATURE_X2APIC); + if ( cpu_has_htt ) + edx |= cpufeat_mask(X86_FEATURE_HTT); + + switch ( boot_cpu_data.x86_vendor ) + { + case X86_VENDOR_INTEL: + /* + * Intel masking MSRs are documented as AND masks. + * Experimentally, they are applied after OSXSAVE and APIC + * are fast-forwarded from real hardware state. + */ + mask &= ((uint64_t)edx << 32) | ecx; + + if ( ecx & cpufeat_mask(X86_FEATURE_XSAVE) ) + ecx = cpufeat_mask(X86_FEATURE_OSXSAVE); + else + ecx = 0; + edx = cpufeat_mask(X86_FEATURE_APIC); + + mask |= ((uint64_t)edx << 32) | ecx; + break; + + case X86_VENDOR_AMD: + case X86_VENDOR_HYGON: + mask &= ((uint64_t)ecx << 32) | edx; + + /* + * AMD masking MSRs are documented as overrides. + * Experimentally, fast-forwarding of the OSXSAVE and APIC + * bits from real hardware state only occurs if the MSR has + * the respective bits set. + */ + if ( ecx & cpufeat_mask(X86_FEATURE_XSAVE) ) + ecx = cpufeat_mask(X86_FEATURE_OSXSAVE); + else + ecx = 0; + edx = cpufeat_mask(X86_FEATURE_APIC); + + /* + * If the Hypervisor bit is set in the policy, we can also + * forward it into real CPUID. + */ + if ( p->basic.hypervisor ) + ecx |= cpufeat_mask(X86_FEATURE_HYPERVISOR); + + mask |= ((uint64_t)ecx << 32) | edx; + break; + } + + d->arch.pv.cpuidmasks->_1cd = mask; + } + + if ( ((levelling_caps & LCAP_6c) == LCAP_6c) ) + { + uint64_t mask = cpuidmask_defaults._6c; + + if ( boot_cpu_data.x86_vendor == X86_VENDOR_AMD ) + mask &= (~0ULL << 32) | p->basic.raw[6].c; + + d->arch.pv.cpuidmasks->_6c = mask; + } + + if ( ((levelling_caps & LCAP_7ab0) == LCAP_7ab0) ) + { + uint64_t mask = cpuidmask_defaults._7ab0; + + /* + * Leaf 7[0].eax is max_subleaf, not a feature mask. Take it + * wholesale from the policy, but clamp the features in 7[0].ebx + * per usual. + */ + if ( boot_cpu_data.x86_vendor & + (X86_VENDOR_AMD | X86_VENDOR_HYGON) ) + mask = (((uint64_t)p->feat.max_subleaf << 32) | + ((uint32_t)mask & p->feat._7b0)); + + d->arch.pv.cpuidmasks->_7ab0 = mask; + } + + if ( ((levelling_caps & LCAP_Da1) == LCAP_Da1) ) + { + uint64_t mask = cpuidmask_defaults.Da1; + uint32_t eax = p->xstate.Da1; + + if ( boot_cpu_data.x86_vendor == X86_VENDOR_INTEL ) + mask &= (~0ULL << 32) | eax; + + d->arch.pv.cpuidmasks->Da1 = mask; + } + + if ( ((levelling_caps & LCAP_e1cd) == LCAP_e1cd) ) + { + uint64_t mask = cpuidmask_defaults.e1cd; + uint32_t ecx = p->extd.e1c; + uint32_t edx = p->extd.e1d; + + /* + * Must expose hosts CMP_LEGACY value so a guest using native + * CPUID can correctly interpret other leaves which cannot be + * masked. + */ + if ( cpu_has_cmp_legacy ) + ecx |= cpufeat_mask(X86_FEATURE_CMP_LEGACY); + + /* + * If not emulating AMD or Hygon, clear the duplicated features + * in e1d. + */ + if ( !(p->x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) ) + edx &= ~CPUID_COMMON_1D_FEATURES; + + switch ( boot_cpu_data.x86_vendor ) + { + case X86_VENDOR_INTEL: + mask &= ((uint64_t)edx << 32) | ecx; + break; + + case X86_VENDOR_AMD: + case X86_VENDOR_HYGON: + mask &= ((uint64_t)ecx << 32) | edx; + + /* + * Fast-forward bits - Must be set in the masking MSR for + * fast-forwarding to occur in hardware. + */ + ecx = 0; + edx = cpufeat_mask(X86_FEATURE_APIC); + + mask |= ((uint64_t)ecx << 32) | edx; + break; + } + + d->arch.pv.cpuidmasks->e1cd = mask; + } + } + + for_each_vcpu ( d, v ) + { + cpuid_policy_updated(v); + + /* If PMU version is zero then the guest doesn't have VPMU */ + if ( boot_cpu_data.x86_vendor == X86_VENDOR_INTEL && + p->basic.pmu_version == 0 ) + vpmu_destroy(v); + } +} + #ifndef CONFIG_BIGMEM /* * The hole may be at or above the 44-bit boundary, so we need to determine --- a/xen/arch/x86/domctl.c +++ b/xen/arch/x86/domctl.c @@ -49,173 +49,6 @@ static int gdbsx_guest_mem_io(domid_t do } #endif -void domain_cpu_policy_changed(struct domain *d) -{ - const struct cpuid_policy *p = d->arch.cpuid; - struct vcpu *v; - - if ( is_pv_domain(d) ) - { - if ( ((levelling_caps & LCAP_1cd) == LCAP_1cd) ) - { - uint64_t mask = cpuidmask_defaults._1cd; - uint32_t ecx = p->basic._1c; - uint32_t edx = p->basic._1d; - - /* - * Must expose hosts HTT and X2APIC value so a guest using native - * CPUID can correctly interpret other leaves which cannot be - * masked. - */ - if ( cpu_has_x2apic ) - ecx |= cpufeat_mask(X86_FEATURE_X2APIC); - if ( cpu_has_htt ) - edx |= cpufeat_mask(X86_FEATURE_HTT); - - switch ( boot_cpu_data.x86_vendor ) - { - case X86_VENDOR_INTEL: - /* - * Intel masking MSRs are documented as AND masks. - * Experimentally, they are applied after OSXSAVE and APIC - * are fast-forwarded from real hardware state. - */ - mask &= ((uint64_t)edx << 32) | ecx; - - if ( ecx & cpufeat_mask(X86_FEATURE_XSAVE) ) - ecx = cpufeat_mask(X86_FEATURE_OSXSAVE); - else - ecx = 0; - edx = cpufeat_mask(X86_FEATURE_APIC); - - mask |= ((uint64_t)edx << 32) | ecx; - break; - - case X86_VENDOR_AMD: - case X86_VENDOR_HYGON: - mask &= ((uint64_t)ecx << 32) | edx; - - /* - * AMD masking MSRs are documented as overrides. - * Experimentally, fast-forwarding of the OSXSAVE and APIC - * bits from real hardware state only occurs if the MSR has - * the respective bits set. - */ - if ( ecx & cpufeat_mask(X86_FEATURE_XSAVE) ) - ecx = cpufeat_mask(X86_FEATURE_OSXSAVE); - else - ecx = 0; - edx = cpufeat_mask(X86_FEATURE_APIC); - - /* - * If the Hypervisor bit is set in the policy, we can also - * forward it into real CPUID. - */ - if ( p->basic.hypervisor ) - ecx |= cpufeat_mask(X86_FEATURE_HYPERVISOR); - - mask |= ((uint64_t)ecx << 32) | edx; - break; - } - - d->arch.pv.cpuidmasks->_1cd = mask; - } - - if ( ((levelling_caps & LCAP_6c) == LCAP_6c) ) - { - uint64_t mask = cpuidmask_defaults._6c; - - if ( boot_cpu_data.x86_vendor == X86_VENDOR_AMD ) - mask &= (~0ULL << 32) | p->basic.raw[6].c; - - d->arch.pv.cpuidmasks->_6c = mask; - } - - if ( ((levelling_caps & LCAP_7ab0) == LCAP_7ab0) ) - { - uint64_t mask = cpuidmask_defaults._7ab0; - - /* - * Leaf 7[0].eax is max_subleaf, not a feature mask. Take it - * wholesale from the policy, but clamp the features in 7[0].ebx - * per usual. - */ - if ( boot_cpu_data.x86_vendor & - (X86_VENDOR_AMD | X86_VENDOR_HYGON) ) - mask = (((uint64_t)p->feat.max_subleaf << 32) | - ((uint32_t)mask & p->feat._7b0)); - - d->arch.pv.cpuidmasks->_7ab0 = mask; - } - - if ( ((levelling_caps & LCAP_Da1) == LCAP_Da1) ) - { - uint64_t mask = cpuidmask_defaults.Da1; - uint32_t eax = p->xstate.Da1; - - if ( boot_cpu_data.x86_vendor == X86_VENDOR_INTEL ) - mask &= (~0ULL << 32) | eax; - - d->arch.pv.cpuidmasks->Da1 = mask; - } - - if ( ((levelling_caps & LCAP_e1cd) == LCAP_e1cd) ) - { - uint64_t mask = cpuidmask_defaults.e1cd; - uint32_t ecx = p->extd.e1c; - uint32_t edx = p->extd.e1d; - - /* - * Must expose hosts CMP_LEGACY value so a guest using native - * CPUID can correctly interpret other leaves which cannot be - * masked. - */ - if ( cpu_has_cmp_legacy ) - ecx |= cpufeat_mask(X86_FEATURE_CMP_LEGACY); - - /* - * If not emulating AMD or Hygon, clear the duplicated features - * in e1d. - */ - if ( !(p->x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) ) - edx &= ~CPUID_COMMON_1D_FEATURES; - - switch ( boot_cpu_data.x86_vendor ) - { - case X86_VENDOR_INTEL: - mask &= ((uint64_t)edx << 32) | ecx; - break; - - case X86_VENDOR_AMD: - case X86_VENDOR_HYGON: - mask &= ((uint64_t)ecx << 32) | edx; - - /* - * Fast-forward bits - Must be set in the masking MSR for - * fast-forwarding to occur in hardware. - */ - ecx = 0; - edx = cpufeat_mask(X86_FEATURE_APIC); - - mask |= ((uint64_t)ecx << 32) | edx; - break; - } - - d->arch.pv.cpuidmasks->e1cd = mask; - } - } - - for_each_vcpu ( d, v ) - { - cpuid_policy_updated(v); - - /* If PMU version is zero then the guest doesn't have VPMU */ - if ( boot_cpu_data.x86_vendor == X86_VENDOR_INTEL && - p->basic.pmu_version == 0 ) - vpmu_destroy(v); - } -} - static int update_domain_cpu_policy(struct domain *d, xen_domctl_cpu_policy_t *xdpc) { From xen-devel-bounces@lists.xenproject.org Fri Aug 07 11:34:33 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 11:34:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k40dt-0007gA-MT; Fri, 07 Aug 2020 11:34:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k40dr-0007fs-Oc for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 11:34:31 +0000 X-Inumbo-ID: eef526d7-ee84-4f15-9ce2-d9c363ce3b96 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id eef526d7-ee84-4f15-9ce2-d9c363ce3b96; Fri, 07 Aug 2020 11:34:31 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 373B8B071; Fri, 7 Aug 2020 11:34:48 +0000 (UTC) Subject: [PATCH v2 6/7] x86: move cpu_{up,down}_helper() From: Jan Beulich To: "xen-devel@lists.xenproject.org" References: <3a8356a9-313c-6de8-f409-977eae1fbfa5@suse.com> Message-ID: Date: Fri, 7 Aug 2020 13:34:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <3a8356a9-313c-6de8-f409-977eae1fbfa5@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" This is in preparation of making the building of sysctl.c conditional. Signed-off-by: Jan Beulich --- a/xen/arch/x86/smp.c +++ b/xen/arch/x86/smp.c @@ -22,6 +22,7 @@ #include #include #include +#include #include #include @@ -396,3 +397,36 @@ void call_function_interrupt(struct cpu_ perfc_incr(ipis); smp_call_function_interrupt(); } + +long cpu_up_helper(void *data) +{ + unsigned int cpu = (unsigned long)data; + int ret = cpu_up(cpu); + + /* Have one more go on EBUSY. */ + if ( ret == -EBUSY ) + ret = cpu_up(cpu); + + if ( !ret && !opt_smt && + cpu_data[cpu].compute_unit_id == INVALID_CUID && + cpumask_weight(per_cpu(cpu_sibling_mask, cpu)) > 1 ) + { + ret = cpu_down_helper(data); + if ( ret ) + printk("Could not re-offline CPU%u (%d)\n", cpu, ret); + else + ret = -EPERM; + } + + return ret; +} + +long cpu_down_helper(void *data) +{ + int cpu = (unsigned long)data; + int ret = cpu_down(cpu); + /* Have one more go on EBUSY. */ + if ( ret == -EBUSY ) + ret = cpu_down(cpu); + return ret; +} --- a/xen/arch/x86/sysctl.c +++ b/xen/arch/x86/sysctl.c @@ -79,39 +79,6 @@ static void l3_cache_get(void *arg) l3_info->size = info.size / 1024; /* in KB unit */ } -long cpu_up_helper(void *data) -{ - unsigned int cpu = (unsigned long)data; - int ret = cpu_up(cpu); - - /* Have one more go on EBUSY. */ - if ( ret == -EBUSY ) - ret = cpu_up(cpu); - - if ( !ret && !opt_smt && - cpu_data[cpu].compute_unit_id == INVALID_CUID && - cpumask_weight(per_cpu(cpu_sibling_mask, cpu)) > 1 ) - { - ret = cpu_down_helper(data); - if ( ret ) - printk("Could not re-offline CPU%u (%d)\n", cpu, ret); - else - ret = -EPERM; - } - - return ret; -} - -long cpu_down_helper(void *data) -{ - int cpu = (unsigned long)data; - int ret = cpu_down(cpu); - /* Have one more go on EBUSY. */ - if ( ret == -EBUSY ) - ret = cpu_down(cpu); - return ret; -} - static long smt_up_down_helper(void *data) { bool up = (bool)data; From xen-devel-bounces@lists.xenproject.org Fri Aug 07 11:35:08 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 11:35:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k40eS-0007nI-0a; Fri, 07 Aug 2020 11:35:08 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k40eR-0007n5-8h for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 11:35:07 +0000 X-Inumbo-ID: 2215ec07-676a-4598-802a-fbaff9580f76 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2215ec07-676a-4598-802a-fbaff9580f76; Fri, 07 Aug 2020 11:35:06 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9347FB6D7; Fri, 7 Aug 2020 11:35:23 +0000 (UTC) Subject: [PATCH v2 7/7] x86: don't include domctl and alike in shim-exclusive builds From: Jan Beulich To: "xen-devel@lists.xenproject.org" References: <3a8356a9-313c-6de8-f409-977eae1fbfa5@suse.com> Message-ID: Date: Fri, 7 Aug 2020 13:35:08 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <3a8356a9-313c-6de8-f409-977eae1fbfa5@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" There is no need for platform-wide, system-wide, or per-domain control in this case. Hence avoid including this dead code in the build. Signed-off-by: Jan Beulich --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -23,7 +23,6 @@ obj-$(CONFIG_GDBSX) += debug.o obj-y += delay.o obj-y += desc.o obj-bin-y += dmi_scan.init.o -obj-y += domctl.o obj-y += domain.o obj-bin-y += dom0_build.init.o obj-y += domain_page.o @@ -51,7 +50,6 @@ obj-y += numa.o obj-y += pci.o obj-y += percpu.o obj-y += physdev.o x86_64/physdev.o -obj-y += platform_hypercall.o x86_64/platform_hypercall.o obj-y += psr.o obj-y += setup.o obj-y += shutdown.o @@ -60,7 +58,6 @@ obj-y += smpboot.o obj-y += spec_ctrl.o obj-y += srat.o obj-y += string.o -obj-y += sysctl.o obj-y += time.o obj-y += trace.o obj-y += traps.o @@ -71,6 +68,13 @@ obj-$(CONFIG_TBOOT) += tboot.o obj-y += hpet.o obj-y += vm_event.o obj-y += xstate.o + +ifneq ($(CONFIG_PV_SHIM_EXCLUSIVE),y) +obj-y += domctl.o +obj-y += platform_hypercall.o x86_64/platform_hypercall.o +obj-y += sysctl.o +endif + extra-y += asm-macros.i ifneq ($(CONFIG_HVM),y) --- a/xen/arch/x86/mm/paging.c +++ b/xen/arch/x86/mm/paging.c @@ -47,6 +47,8 @@ /* Per-CPU variable for enforcing the lock ordering */ DEFINE_PER_CPU(int, mm_lock_level); +#ifndef CONFIG_PV_SHIM_EXCLUSIVE + /************************************************/ /* LOG DIRTY SUPPORT */ /************************************************/ @@ -628,6 +630,8 @@ void paging_log_dirty_init(struct domain d->arch.paging.log_dirty.ops = ops; } +#endif /* CONFIG_PV_SHIM_EXCLUSIVE */ + /************************************************/ /* CODE FOR PAGING SUPPORT */ /************************************************/ @@ -667,7 +671,7 @@ void paging_vcpu_init(struct vcpu *v) shadow_vcpu_init(v); } - +#ifndef CONFIG_PV_SHIM_EXCLUSIVE int paging_domctl(struct domain *d, struct xen_domctl_shadow_op *sc, XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl, bool_t resuming) @@ -788,6 +792,7 @@ long paging_domctl_continuation(XEN_GUES return ret; } +#endif /* CONFIG_PV_SHIM_EXCLUSIVE */ /* Call when destroying a domain */ int paging_teardown(struct domain *d) @@ -803,10 +808,12 @@ int paging_teardown(struct domain *d) if ( preempted ) return -ERESTART; +#ifndef CONFIG_PV_SHIM_EXCLUSIVE /* clean up log dirty resources. */ rc = paging_free_log_dirty_bitmap(d, 0); if ( rc == -ERESTART ) return rc; +#endif /* Move populate-on-demand cache back to domain_list for destruction */ rc = p2m_pod_empty_cache(d); --- a/xen/arch/x86/pv/hypercall.c +++ b/xen/arch/x86/pv/hypercall.c @@ -42,7 +42,9 @@ const hypercall_table_t pv_hypercall_tab COMPAT_CALL(set_callbacks), HYPERCALL(fpu_taskswitch), HYPERCALL(sched_op_compat), +#ifndef CONFIG_PV_SHIM_EXCLUSIVE COMPAT_CALL(platform_op), +#endif HYPERCALL(set_debugreg), HYPERCALL(get_debugreg), COMPAT_CALL(update_descriptor), @@ -72,8 +74,10 @@ const hypercall_table_t pv_hypercall_tab #endif HYPERCALL(event_channel_op), COMPAT_CALL(physdev_op), +#ifndef CONFIG_PV_SHIM_EXCLUSIVE HYPERCALL(sysctl), HYPERCALL(domctl), +#endif #ifdef CONFIG_KEXEC COMPAT_CALL(kexec_op), #endif @@ -89,7 +93,9 @@ const hypercall_table_t pv_hypercall_tab HYPERCALL(hypfs_op), #endif HYPERCALL(mca), +#ifndef CONFIG_PV_SHIM_EXCLUSIVE HYPERCALL(arch_1), +#endif }; #undef do_arch_1 --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -6,7 +6,6 @@ obj-$(CONFIG_CORE_PARKING) += core_parki obj-y += cpu.o obj-$(CONFIG_DEBUG_TRACE) += debugtrace.o obj-$(CONFIG_HAS_DEVICE_TREE) += device_tree.o -obj-y += domctl.o obj-y += domain.o obj-y += event_2l.o obj-y += event_channel.o @@ -26,7 +25,6 @@ obj-$(CONFIG_NEEDS_LIST_SORT) += list_so obj-$(CONFIG_LIVEPATCH) += livepatch.o livepatch_elf.o obj-$(CONFIG_MEM_ACCESS) += mem_access.o obj-y += memory.o -obj-y += monitor.o obj-y += multicall.o obj-y += notifier.o obj-y += page_alloc.o @@ -47,7 +45,6 @@ obj-y += spinlock.o obj-y += stop_machine.o obj-y += string.o obj-y += symbols.o -obj-y += sysctl.o obj-y += tasklet.o obj-y += time.o obj-y += timer.o @@ -66,6 +63,12 @@ obj-bin-$(CONFIG_X86) += $(foreach n,dec obj-$(CONFIG_COMPAT) += $(addprefix compat/,domain.o kernel.o memory.o multicall.o xlat.o) +ifneq ($(CONFIG_PV_SHIM_EXCLUSIVE),y) +obj-y += domctl.o +obj-y += monitor.o +obj-y += sysctl.o +endif + extra-y := symbols-dummy.o obj-$(CONFIG_COVERAGE) += coverage/ --- a/xen/include/asm-x86/paging.h +++ b/xen/include/asm-x86/paging.h @@ -154,6 +154,8 @@ struct paging_mode { /***************************************************************************** * Log dirty code */ +#ifndef CONFIG_PV_SHIM_EXCLUSIVE + /* get the dirty bitmap for a specific range of pfns */ void paging_log_dirty_range(struct domain *d, unsigned long begin_pfn, @@ -202,6 +204,15 @@ struct sh_dirty_vram { s_time_t last_dirty; }; +#else /* !CONFIG_PV_SHIM_EXCLUSIVE */ + +static inline void paging_log_dirty_init(struct domain *d, + const struct log_dirty_ops *ops) {} +static inline void paging_mark_dirty(struct domain *d, mfn_t gmfn) {} +static inline void paging_mark_pfn_dirty(struct domain *d, pfn_t pfn) {} + +#endif /* CONFIG_PV_SHIM_EXCLUSIVE */ + /***************************************************************************** * Entry points into the paging-assistance code */ --- a/xen/include/xen/domain.h +++ b/xen/include/xen/domain.h @@ -125,6 +125,10 @@ struct vnuma_info { struct xen_vmemrange *vmemrange; }; +#ifndef CONFIG_PV_SHIM_EXCLUSIVE void vnuma_destroy(struct vnuma_info *vnuma); +#else +static inline void vnuma_destroy(struct vnuma_info *vnuma) { ASSERT(!vnuma); } +#endif #endif /* __XEN_DOMAIN_H__ */ From xen-devel-bounces@lists.xenproject.org Fri Aug 07 12:11:06 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 12:11:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k41Ct-0002sM-8c; Fri, 07 Aug 2020 12:10:43 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k41Cr-0002sH-QL for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 12:10:42 +0000 X-Inumbo-ID: dddb61da-bedb-4c0c-89da-96ea24444195 Received: from sonic301-2.consmr.mail.bf2.yahoo.com (unknown [74.6.129.41]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id dddb61da-bedb-4c0c-89da-96ea24444195; Fri, 07 Aug 2020 12:10:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1596802240; bh=W37xUrb1O1ev2yKI+LITNo03bA7zyIc0nYk01MXwqSo=; h=Date:From:Reply-To:To:Subject:References:From:Subject; b=Cb1Ca/7T2LdbrbvFoR0+wThMhhGjKtzcXeAJ3qwTJPRfr3791URoX1wt6BDYXGP6iRMmxwXTAcsR0Qe+yfuiJlk1ZFS4gb2r14wcRqfIYHVJiPCxKPvgTNQt2w/aumFQJGBWPf2nodH5U5WofZYVMxcVHnNJ27UU7qjDfuQVm0htF3Fop/0biJSkTkH726aB/uTI0YCYRMqG8rxucbEvgdtxP2e1o+iNveWNNo5DxeUXOZbvDe0lJzu4TTEAEIQYXcrKRb2hMmk/PjdMxTlMPCU0+84BViOhAN8XRhBi/IYWqruNvhoPxEClH2bcVo74+khCiIywNp63sBgFC6LU2w== X-YMail-OSG: 6FrrMgwVM1ly0MQ2Wyk81S9Emo5QWKtzuTfGFh4HxNy6Ask0FEkIr3SOV5EUyiN Ogl.Llk7tzgWO1DxXTXLTzW0EDAKojGvFKEkvrqUeYhRLfPlloSoFor_Iq12giJyN9QDZJWkU5xl 9EhipZH8KSe8DsK6giBf8eAQSQH5KZJeXXcGyks17H7Yy6v1frOQtDWJ_Au7UDKEE8XzWcUyNL89 nfQSaReEuOWYCmMxT3zpI70IkgIc.xfYcC7Bh2zpn5ptL8vOgAV9NMvaZm7hSI90WSRIIYha9bUe 1lrHxSUrgXX6bPZltolcAeby5eg855vNIrqmovRESAutaSGg1XnOAGfzkDCwJoB7JofXsva0G7Sn jau3EuWjffOImWCoiRy0_lbI48vnYKmvdLTYCPhSPiE63rWx5Pk503YSNMZAX8x0iQ2VddZr5XV0 80atlc1VQAGBsCvF0aMQF_w6ZuAlHwlZBrrLvDBb2KEdC1hgvNA9qoShw2QXL0lI.H2hvtmoreDc pOPe0JLQ5jOevDa0yzevT31IBqKf5TniaMOIbOfBgNifMxoj8PNrdtvJMMnVtZAhVDrPSEP58KFE wjUi0shtESolYVjbbfnN7UmwAjWS6T9Rz74JaBn4sgW.QAxiJ4EanlyicVmiIwiTuqCS7IeQ2z0u _mfnANL6toRMxqGbpIdeW78UUNizkXx5nsvfZ4FI2KN1IKbUhLCtJwb0SsjG.6L7SLsKqzuobcoZ i.nzxj_HUDKiUhi1foXxD8WOju2bAsXEoAWOgETRYYsQM0SGUtgRHMJ4sYcxoShFsywHMGggC2IH sveW5obOK73_vQaRfEvslUliDLZQ3MgHS.oCBF2oydchsx9mJPedj9PAv_sIjJomz67md5gRisBF DlhPfN7RfyvlpiLoqjscTJHcI53Xlpx3WPkq.E24I1Q4ETzBdFLvcXS.QVbzay7mxESGGj0g1oeZ PLcnmu.P0H4i4pLMCB.J.owTyt86k4qJGDHCiJIDkE7VI6xOqn45vdeahde14PxNYyPABLmq.q4z QiQV9NEDLEv7WEBJvFOM1Bq_2D55jGL1a7UC02zi0gN3lENC0F7eUC7yOWCiXpa2ReDLSLGTKFmM kqqgWKG4DvJe3njy4F00Gk3zT1H66623uT9B9kRk29Se.1MyFJtVhfhYlE5k_iCPSGFKXXsGkKWZ EUzz3dy4JbgQA3zLeigOxQI1nMoWsm5QR7NTdLWoyuw0NXi_nZYl5YTjKQx88Dwd3xGHtDRhBzbl jtlYUCzzqvua0jGp4udYo6KvmPJyz8v4ByWU.CvBtFkUBknhINkFT9bR39s1IhbTMnItshzPqLea 7BSNn7SjLNufXOalxZhCTvLrb5RrH0wxVF2aDFSH2LDONe_21k_rFK51TiB6VnjJ2MMv2cCiNPoL 24wO99OVaBC7brpSCvcZ2TgLqXfBxpiVE3w-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.bf2.yahoo.com with HTTP; Fri, 7 Aug 2020 12:10:40 +0000 Date: Fri, 7 Aug 2020 12:10:39 +0000 (UTC) From: Jason Long To: Xen-devel Message-ID: <1571516620.940720.1596802239062@mail.yahoo.com> Subject: Spectre and Meltdown attack. MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_940719_687164724.1596802239061" References: <1571516620.940720.1596802239062.ref@mail.yahoo.com> X-Mailer: WebService/1.1.16436 YahooMailAndroidMobile YMobile/1.0 (com.yahoo.mobile.client.android.mail/6.8.5; Android/7.1.1; NMF26F; bbc100; BlackBerry; BBC100-1; 5.16; 1184x720; ) Content-Length: 758 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: "hack3rcon@yahoo.com" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" ------=_Part_940719_687164724.1596802239061 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hello, Is Spectre and Meltdown solved in Xen hypervisor completely?How many versions of it existed? Tnx. ------=_Part_940719_687164724.1596802239061 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit
Hello,
Is Spectre and Meltdown solved in Xen hypervisor completely?
How many versions of it existed?

Tnx.
------=_Part_940719_687164724.1596802239061-- From xen-devel-bounces@lists.xenproject.org Fri Aug 07 12:23:33 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 12:23:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k41PC-0003rm-ES; Fri, 07 Aug 2020 12:23:26 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k41PA-0003rh-Of for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 12:23:24 +0000 X-Inumbo-ID: 568c2916-908f-4e77-89ed-bf583fa82b3a Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 568c2916-908f-4e77-89ed-bf583fa82b3a; Fri, 07 Aug 2020 12:23:23 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id BAD0AB16D; Fri, 7 Aug 2020 12:23:40 +0000 (UTC) Subject: Re: [RFC] efi/boot: Unified Xen executable for UEFI Secure Boot support To: Trammell Hudson References: <1bd2d79e-5bef-835c-f6cc-9fd367e8beb7@suse.com> <5e3b16b3-0f93-4683-dcc7-852c805870c8@suse.com> From: Jan Beulich Message-ID: <1489916a-24cc-3e2c-98a0-1f35186e4b06@suse.com> Date: Fri, 7 Aug 2020 14:23:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 06.08.2020 16:15, Trammell Hudson wrote: > Updated patch: I'm afraid the number of style issues has further increased. First and foremost please read ./CODING_STYLE and look at surrounding code. > --- /dev/null > +++ b/xen/arch/x86/efi/pe.c > @@ -0,0 +1 @@ > +../../../common/efi/pe.c > \ No newline at end of file This isn't supposed to be part of the patch; the symlinks get created in the course of building. > @@ -665,6 +669,37 @@ static bool __init read_file(EFI_FILE_HANDLE dir_handle, CHAR16 *name, > return true; > } > > + > +static bool __init read_section(const void * const image_base, > + char * const name, struct file *file, char *options) > +{ > + union string name_string = { .s = name + 1 }; > + if ( !image_base ) > + return false; > + > + file->ptr = pe_find_section(image_base, name, &file->size); > + if ( !file->ptr ) > + return false; > + > + file->need_to_free = false; > + > + if ( file == &cfg ) > + return true; > + > + s2w(&name_string); > + PrintStr(name_string.w); > + PrintStr(L": "); > + DisplayUint(file->addr, 2 * sizeof(file->addr)); > + PrintStr(L"-"); > + DisplayUint(file->addr + file->size, 2 * sizeof(file->addr)); > + PrintStr(newline); > + > + efi_arch_handle_module(file, name_string.w, options); This is a copy of existing code - please make a helper function instead of duplicating (preferably in a separate, prereq patch, but I guess there's anyway the open question on whether this change can/should be split into smaller pieces). > @@ -968,6 +1003,21 @@ static void __init setup_efi_pci(void) > efi_bs->FreePool(handles); > } > > +static bool __init efi_secure_boot(void) > +{ > + static const EFI_GUID global_guid = EFI_GLOBAL_VARIABLE; Also __initconst please. > + uint8_t buf[8]; > + UINTN size = sizeof(buf); > + > + if ( efi_rs->GetVariable(L"SecureBoot", (EFI_GUID *)&global_guid, NULL, &size, buf) != EFI_SUCCESS ) > + return false; > + > + if ( size != 1 ) > + return false; Judging from Linux code you also need to evaluate the SetupMode var. > @@ -1171,6 +1223,10 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable) > PrintErrMesg(L"No Loaded Image Protocol", status); > > efi_arch_load_addr_check(loaded_image); > + if ( loaded_image ) > + image_base = loaded_image->ImageBase; There's no point in having the if() - efi_arch_load_addr_check() has already de-referenced loaded_image. If HandleProtocol() fails we won't make it here. > @@ -1249,9 +1305,15 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable) > /* Get the file system interface. */ > dir_handle = get_parent_handle(loaded_image, &file_name); > > - /* Read and parse the config file. */ > - if ( !cfg_file_name ) > + if ( read_section(image_base, ".config", &cfg, NULL) ) > + { > + if ( secure ) > + PrintStr(L"Secure Boot enabled: "); > + PrintStr(L"Using unified config file\r\n"); > + } > + else if ( !cfg_file_name ) > { > + /* Read and parse the config file. */ > CHAR16 *tail; As said before, I think we want an all-or-nothing approach. You want to first establish whether the image is a unified one, and if so not fall back to reading from disk. Otherwise the claim of secure boot above is liable to be wrong. I'm also unconvinced of reporting the secure boot status only in the case you're interested in. > +void * __init pe_find_section(const void * const image_base, > + const char * section_name, UINTN * size_out) > +{ > + const CHAR8 * const base = image_base; Why the extra variable? The more that ... > + const struct DosFileHeader * dos = (const void*) base; ... if you used image_base, the cast would become unnecessary. > + const struct PeHeader * pe; > + const UINTN name_len = strlen(section_name); > + UINTN offset; > + > + if ( base == NULL ) > + return NULL; Looks to be quite pointless a check. > + if ( memcmp(dos->Magic, "MZ", 2) != 0 ) > + return NULL; > + > + pe = (const void *) &base[dos->ExeHeader]; > + if ( memcmp(pe->Magic, "PE\0\0", 4) != 0 ) > + return NULL; > + > + /* PE32+ Subsystem type */ > +#if defined(__ARM__) > + if (pe->FileHeader.Machine != PE_HEADER_MACHINE_ARM64) > + return NULL; > +#elif defined(__x86_64__) > + if (pe->FileHeader.Machine != PE_HEADER_MACHINE_X64) > + return NULL; > +#else > + // unknown architecture > + return NULL; > +#endif > + > + if ( pe->FileHeader.NumberOfSections > 96 ) > + return NULL; Besides there still needing to be an explanation for this apparently arbitrary limit, I also find the amount of consistency checking insufficient. At the very least I'd like to see you check the COFF magic value (0x020b). > + offset = dos->ExeHeader + sizeof(*pe) + pe->FileHeader.SizeOfOptionalHeader; > + > + for (UINTN i = 0; i < pe->FileHeader.NumberOfSections; i++) > + { > + const struct PeSectionHeader *const sect = (const struct PeSectionHeader *)&base[offset]; > + if ( memcmp(sect->Name, section_name, name_len) == 0 ) > + { > + if ( size_out ) > + *size_out = sect->VirtualSize; Is this correct in all cases? Iirc zero tail padding can be expressed by SizeOfRawData < VirtualSize, in which case there won't be as many bytes to copy / use as you tell your caller. > + return (void*)(sect->VirtualAddress + (uintptr_t) image_base); Again no need for the cast; the function should return const void * anyway, as the caller isn't supposed to alter section contents (I hope). > --- /dev/null > +++ b/xen/scripts/unify-xen > @@ -0,0 +1,89 @@ > +#!/bin/bash > +# Build a "unified Xen" image. > +# Usage > +# unify xen.efi xen.cfg bzimage initrd [xsm [ucode]] > +# > +# Merge a Xen configuration, Linux kernel, initrd, and optional XSM or ucode > +# into xen.efi to produce a single signed EFI executable. > +# > +# For shellcheck > +# - turn off "expressions don't expand in single quotes" > +# - and "can't follow non-constant sources" > +# shellcheck disable=SC2016 disable=SC1090 > +set -e -o pipefail > +export LC_ALL=C > + > +die() { echo "$@" >&2 ; exit 1 ; } > +warn() { echo "$@" >&2 ; } > +debug() { [ "$V" == 1 ] && echo "$@" >&2 ; } > + > +cleanup() { > + rm -rf "$TMP" > +} > + > +TMP=$(mktemp -d) > +trap cleanup EXIT > + > +######################################## > + > +XEN="$1" > +CONFIG="$2" > +KERNEL="$3" > +RAMDISK="$4" > +XSM="$5" > +UCODE="$6" > + > +if [ ! -r "$XEN" ]; then > + die "$XEN: Unable to find Xen executable" > +fi > + > +BASE_ADDR="$(objdump -h "$XEN" | awk '/ \.text / { print $4 }')" > +PREFIX_ADDR="0x$(echo "$BASE_ADDR" | cut -c1-9)" > +warn "$XEN: Base address $BASE_ADDR" > + > +objcopy \ > + ${CONFIG:+\ > + --add-section .config="$CONFIG" \ > + --change-section-vma .config=${PREFIX_ADDR}1000000 \ > + } \ > + ${UCODE:+\ > + --add-section .ucode="$UCODE" \ > + --change-section-vma .ucode=${PREFIX_ADDR}1010000 \ > + } \ > + ${XSM:+\ > + --add-section .xsm="$XSM" \ > + --change-section-vma .xsm=${PREFIX_ADDR}1080000 \ > + } \ > + ${KERNEL:+\ > + --add-section .kernel="$KERNEL" \ > + --change-section-vma .kernel=${PREFIX_ADDR}1100000 \ > + } \ > + ${RAMDISK:+\ > + --add-section .ramdisk="$RAMDISK" \ > + --change-section-vma .ramdisk=${PREFIX_ADDR}2000000 \ > + } \ With all these hard coded size restrictions I take it this still is just an example, not something that is to eventually get committed. Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 07 12:54:15 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 12:54:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k41ss-0006Rw-Rt; Fri, 07 Aug 2020 12:54:06 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k41ss-0006Rr-Gd for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 12:54:06 +0000 X-Inumbo-ID: aba66811-5e6b-4b43-84ed-3f6926986aee Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id aba66811-5e6b-4b43-84ed-3f6926986aee; Fri, 07 Aug 2020 12:54:05 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C633AAB8B; Fri, 7 Aug 2020 12:54:22 +0000 (UTC) Subject: Re: [PATCH 05/14] kernel-doc: public/features.h To: Stefano Stabellini References: <20200806234933.16448-5-sstabellini@kernel.org> From: Jan Beulich Message-ID: Date: Fri, 7 Aug 2020 14:54:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200806234933.16448-5-sstabellini@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: julien@xen.org, wl@xen.org, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com, xen-devel@lists.xenproject.org, Stefano Stabellini Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 07.08.2020 01:49, Stefano Stabellini wrote: > @@ -41,19 +41,25 @@ > * XENFEAT_dom0 MUST be set if the guest is to be booted as dom0, > */ > > -/* > - * If set, the guest does not need to write-protect its pagetables, and can > - * update them via direct writes. > +/** > + * DOC: XENFEAT_writable_page_tables > + * > + * If set, the guest does not need to write-protect its pagetables, and > + * can update them via direct writes. > */ > #define XENFEAT_writable_page_tables 0 I dislike such redundancy (and it's more noticable here than with the struct-s). Is there really no way for the tool to find the right item, the more that in the cover letter you say that you even need to get the placement right, i.e. there can't be e.g. intervening #define-s? Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 07 12:59:48 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 12:59:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k41yJ-0006d5-Fa; Fri, 07 Aug 2020 12:59:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k41yI-0006d0-Nw for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 12:59:42 +0000 X-Inumbo-ID: b413e6f2-d939-491b-a821-c5c4a87d2aca Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b413e6f2-d939-491b-a821-c5c4a87d2aca; Fri, 07 Aug 2020 12:59:41 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E31FCAC1C; Fri, 7 Aug 2020 12:59:58 +0000 (UTC) Subject: Re: [PATCH 06/14] kernel-doc: public/grant_table.h To: Stefano Stabellini References: <20200806234933.16448-6-sstabellini@kernel.org> From: Jan Beulich Message-ID: <5a4d6a81-bc8f-3d00-f760-d39023711dbc@suse.com> Date: Fri, 7 Aug 2020 14:59:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200806234933.16448-6-sstabellini@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: julien@xen.org, wl@xen.org, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com, xen-devel@lists.xenproject.org, Stefano Stabellini Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 07.08.2020 01:49, Stefano Stabellini wrote: > @@ -108,56 +107,66 @@ > * Use SMP-safe bit-setting instruction. > */ > > -/* > +/** > + * typedef > * Reference to a grant entry in a specified domain's grant table. > */ > typedef uint32_t grant_ref_t; In the comment, did you mean grant_ref_t? > -/* > +/** > + * DOC: grant table > + * > * A grant table comprises a packed array of grant entries in one or more > * page frames shared between Xen and a guest. > * [XEN]: This field is written by Xen and read by the sharing guest. > * [GST]: This field is written by the guest and read by Xen. > */ > > -/* > - * Version 1 of the grant table entry structure is maintained purely > - * for backwards compatibility. New guests should use version 2. > - */ > #if __XEN_INTERFACE_VERSION__ < 0x0003020a > #define grant_entry_v1 grant_entry > #define grant_entry_v1_t grant_entry_t > #endif > +/** > + * struct grant_entry_v1 > + * > + * Version 1 of the grant table entry structure is maintained purely > + * for backwards compatibility. New guests should use version 2. > + */ I realize content changes aren't intended, but here I can't resist recommending to drop the second sentence at this occasion. > +/** > + * DOC: Values for error status returns. All errors are -ve. > + * > + * > + * - GNTST_okay: Normal return. Nit: Why two blank comment lines above? Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 07 13:01:10 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 13:01:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k41zh-0007Pb-R2; Fri, 07 Aug 2020 13:01:09 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k41zh-0007PS-2j for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 13:01:09 +0000 X-Inumbo-ID: f1ff6f57-1318-494e-a1e1-5306b0a4eb1c Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f1ff6f57-1318-494e-a1e1-5306b0a4eb1c; Fri, 07 Aug 2020 13:01:08 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 98DFCAC1C; Fri, 7 Aug 2020 13:01:25 +0000 (UTC) Subject: Re: [PATCH 04/14] kernel-doc: public/event_channel.h To: Stefano Stabellini References: <20200806234933.16448-4-sstabellini@kernel.org> From: Jan Beulich Message-ID: <57b251fc-8997-48b8-693c-08e38d643fc3@suse.com> Date: Fri, 7 Aug 2020 15:01:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200806234933.16448-4-sstabellini@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: julien@xen.org, wl@xen.org, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com, xen-devel@lists.xenproject.org, Stefano Stabellini Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 07.08.2020 01:49, Stefano Stabellini wrote: > @@ -137,65 +147,78 @@ typedef struct evtchn_bind_interdomain evtchn_bind_interdomain_t; > * binding cannot be changed. > */ > struct evtchn_bind_virq { > - /* IN parameters. */ > - uint32_t virq; /* enum virq */ > + /** @virq: IN parameter, enum virq */ > + uint32_t virq; > + /** @vcpu: IN parameter */ > uint32_t vcpu; > - /* OUT parameters. */ > + /** @port: OUT parameter */ > evtchn_port_t port; > }; > typedef struct evtchn_bind_virq evtchn_bind_virq_t; > > -/* > - * EVTCHNOP_bind_pirq: Bind a local event channel to a real IRQ (PIRQ ). > +/** > + * struct evtchn_bind_pirq - EVTCHNOP_bind_pirq > + * > + * Bind a local event channel to a real IRQ (PIRQ ). > * NOTES: > * 1. A physical IRQ may be bound to at most one event channel per domain. > * 2. Only a sufficiently-privileged domain may bind to a physical IRQ. > */ > struct evtchn_bind_pirq { > - /* IN parameters. */ > + /** @pirq: IN parameter */ > uint32_t pirq; > + /** @flags: IN parameter, BIND_PIRQ__* */ > #define BIND_PIRQ__WILL_SHARE 1 > - uint32_t flags; /* BIND_PIRQ__* */ > - /* OUT parameters. */ > + uint32_t flags; > + /** @port: OUT parameter */ > evtchn_port_t port; > }; > typedef struct evtchn_bind_pirq evtchn_bind_pirq_t; > > -/* > - * EVTCHNOP_bind_ipi: Bind a local event channel to receive events. > +/** > + * struct struct evtchn_bind_ipi - EVTCHNOP_bind_ipi > + * > + * Bind a local event channel to receive events. > * NOTES: > * 1. The allocated event channel is bound to the specified vcpu. The binding > * may not be changed. > */ > struct evtchn_bind_ipi { > + /** @vcpu: IN parameter */ > uint32_t vcpu; > - /* OUT parameters. */ > + /** @port: OUT parameter */ > evtchn_port_t port; > }; > typedef struct evtchn_bind_ipi evtchn_bind_ipi_t; > > -/* > - * EVTCHNOP_close: Close a local event channel . If the channel is > - * interdomain then the remote end is placed in the unbound state > +/** > + * struct evtchn_close - EVTCHNOP_close > + * > + * Close a local event channel . If the channel is interdomain > + * then the remote end is placed in the unbound state > * (EVTCHNSTAT_unbound), awaiting a new connection. > */ > struct evtchn_close { > - /* IN parameters. */ > + /** @port: IN parameter */ > evtchn_port_t port; > }; > typedef struct evtchn_close evtchn_close_t; > > -/* > - * EVTCHNOP_send: Send an event to the remote end of the channel whose local > - * endpoint is . > +/** > + * struct evtchn_send - EVTCHNOP_send > + * > + * Send an event to the remote end of the channel whose local endpoint > + * is . > */ > struct evtchn_send { > - /* IN parameters. */ > + /** @port: IN parameter */ > evtchn_port_t port; > }; > typedef struct evtchn_send evtchn_send_t; > > -/* > +/** > + * struct evtchn_status - EVTCHNOP_status > + * > * EVTCHNOP_status: Get the current status of the communication channel which > * has an endpoint at . > * NOTES: Nit: I guess you meant to remove the "EVTCHNOP_status: " prefix from the original comment, like is done elsewhere? Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 07 13:07:18 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 13:07:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k425X-0007eq-Ih; Fri, 07 Aug 2020 13:07:11 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k425V-0007ek-NI for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 13:07:09 +0000 X-Inumbo-ID: 47cdaec6-e49a-4a45-be44-ed0d002fe3db Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 47cdaec6-e49a-4a45-be44-ed0d002fe3db; Fri, 07 Aug 2020 13:07:08 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D91A4B6EC; Fri, 7 Aug 2020 13:07:25 +0000 (UTC) Subject: Re: [PATCH 08/14] kernel-doc: public/memory.h To: Stefano Stabellini References: <20200806234933.16448-8-sstabellini@kernel.org> From: Jan Beulich Message-ID: <5567ef5a-35c4-6dd8-38f5-348c7c3713b1@suse.com> Date: Fri, 7 Aug 2020 15:07:09 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200806234933.16448-8-sstabellini@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: julien@xen.org, wl@xen.org, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com, xen-devel@lists.xenproject.org, Stefano Stabellini Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 07.08.2020 01:49, Stefano Stabellini wrote: > From: Stefano Stabellini > > Convert in-code comments to kernel-doc format wherever possible. > > Signed-off-by: Stefano Stabellini > --- > xen/include/public/memory.h | 232 ++++++++++++++++++++++++------------ > 1 file changed, 155 insertions(+), 77 deletions(-) > > diff --git a/xen/include/public/memory.h b/xen/include/public/memory.h > index 21057ed78e..4c57ed213c 100644 > --- a/xen/include/public/memory.h > +++ b/xen/include/public/memory.h > @@ -30,7 +30,9 @@ > #include "xen.h" > #include "physdev.h" > > -/* > +/** > + * DOC: XENMEM_increase_reservation and XENMEM_decrease_reservation > + * > * Increase or decrease the specified domain's memory reservation. Returns the > * number of extents successfully allocated or freed. > * arg == addr of struct xen_memory_reservation. > @@ -40,29 +42,37 @@ > #define XENMEM_populate_physmap 6 > > #if __XEN_INTERFACE_VERSION__ >= 0x00030209 > -/* > - * Maximum # bits addressable by the user of the allocated region (e.g., I/O > - * devices often have a 32-bit limitation even in 64-bit systems). If zero > - * then the user has no addressing restriction. This field is not used by > - * XENMEM_decrease_reservation. > +/** > + * DOC: XENMEMF_* > + * > + * - XENMEMF_address_bits, XENMEMF_get_address_bits: > + * Maximum # bits addressable by the user of the allocated region > + * (e.g., I/O devices often have a 32-bit limitation even in 64-bit > + * systems). If zero then the user has no addressing restriction. This > + * field is not used by XENMEM_decrease_reservation. > + * - XENMEMF_node, XENMEMF_get_node: NUMA node to allocate from > + * - XENMEMF_populate_on_demand: Flag to populate physmap with populate-on-demand entries > + * - XENMEMF_exact_node_request, XENMEMF_exact_node: Flag to request allocation only from the node specified Nit: overly long line > + * - XENMEMF_vnode: Flag to indicate the node specified is virtual node > */ > #define XENMEMF_address_bits(x) (x) > #define XENMEMF_get_address_bits(x) ((x) & 0xffu) > -/* NUMA node to allocate from. */ > #define XENMEMF_node(x) (((x) + 1) << 8) > #define XENMEMF_get_node(x) ((((x) >> 8) - 1) & 0xffu) > -/* Flag to populate physmap with populate-on-demand entries */ > #define XENMEMF_populate_on_demand (1<<16) > -/* Flag to request allocation only from the node specified */ > #define XENMEMF_exact_node_request (1<<17) > #define XENMEMF_exact_node(n) (XENMEMF_node(n) | XENMEMF_exact_node_request) > -/* Flag to indicate the node specified is virtual node */ > #define XENMEMF_vnode (1<<18) > #endif > > +/** > + * struct xen_memory_reservation > + */ > struct xen_memory_reservation { > > - /* > + /** > + * @extent_start: > + * Take the opportunity and drop the stray blank line? > @@ -200,90 +236,115 @@ DEFINE_XEN_GUEST_HANDLE(xen_machphys_mfn_list_t); > */ > #define XENMEM_machphys_compat_mfn_list 25 > > -/* > +#define XENMEM_machphys_mapping 12 > +/** > + * struct xen_machphys_mapping - XENMEM_machphys_mapping > + * > * Returns the location in virtual address space of the machine_to_phys > * mapping table. Architectures which do not have a m2p table, or which do not > * map it by default into guest address space, do not implement this command. > * arg == addr of xen_machphys_mapping_t. > */ > -#define XENMEM_machphys_mapping 12 > struct xen_machphys_mapping { > + /** @v_start: Start virtual address */ > xen_ulong_t v_start, v_end; /* Start and end virtual addresses. */ > - xen_ulong_t max_mfn; /* Maximum MFN that can be looked up. */ > + /** @v_end: End virtual addresses */ > + xen_ulong_t v_end; > + /** @max_mfn: Maximum MFN that can be looked up */ > + xen_ulong_t max_mfn; > }; > typedef struct xen_machphys_mapping xen_machphys_mapping_t; > DEFINE_XEN_GUEST_HANDLE(xen_machphys_mapping_t); > > -/* Source mapping space. */ > +/** > + * DOC: Source mapping space. > + * > + * - XENMAPSPACE_shared_info: shared info page > + * - XENMAPSPACE_grant_table: grant table page > + * - XENMAPSPACE_gmfn: GMFN > + * - XENMAPSPACE_gmfn_range: GMFN range, XENMEM_add_to_physmap only. > + * - XENMAPSPACE_gmfn_foreign: GMFN from another dom, > + * XENMEM_add_to_physmap_batch only. > + * - XENMAPSPACE_dev_mmio: device mmio region ARM only; the region is mapped > + * in Stage-2 using the Normal MemoryInner/Outer > + * Write-Back Cacheable memory attribute. > + */ > /* ` enum phys_map_space { */ Isn't this and ... > -#define XENMAPSPACE_shared_info 0 /* shared info page */ > -#define XENMAPSPACE_grant_table 1 /* grant table page */ > -#define XENMAPSPACE_gmfn 2 /* GMFN */ > -#define XENMAPSPACE_gmfn_range 3 /* GMFN range, XENMEM_add_to_physmap only. */ > -#define XENMAPSPACE_gmfn_foreign 4 /* GMFN from another dom, > - * XENMEM_add_to_physmap_batch only. */ > -#define XENMAPSPACE_dev_mmio 5 /* device mmio region > - ARM only; the region is mapped in > - Stage-2 using the Normal Memory > - Inner/Outer Write-Back Cacheable > - memory attribute. */ > +#define XENMAPSPACE_shared_info 0 > +#define XENMAPSPACE_grant_table 1 > +#define XENMAPSPACE_gmfn 2 > +#define XENMAPSPACE_gmfn_range 3 > +#define XENMAPSPACE_gmfn_foreign 4 > +#define XENMAPSPACE_dev_mmio 5 > /* ` } */ ... this also something that wants converting? Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 07 13:12:14 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 13:12:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k42AD-0008Uw-AO; Fri, 07 Aug 2020 13:12:01 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k42AC-0008Ur-Gz for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 13:12:00 +0000 X-Inumbo-ID: c5945bda-4e7b-437b-82c1-565938ada16d Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c5945bda-4e7b-437b-82c1-565938ada16d; Fri, 07 Aug 2020 13:11:59 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 322AAAF5D; Fri, 7 Aug 2020 13:12:17 +0000 (UTC) Subject: Re: [PATCH 11/14] kernel-doc: public/version.h To: Stefano Stabellini References: <20200806234933.16448-11-sstabellini@kernel.org> From: Jan Beulich Message-ID: Date: Fri, 7 Aug 2020 15:12:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200806234933.16448-11-sstabellini@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: julien@xen.org, wl@xen.org, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com, xen-devel@lists.xenproject.org, Stefano Stabellini Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 07.08.2020 01:49, Stefano Stabellini wrote: > --- a/xen/include/public/version.h > +++ b/xen/include/public/version.h > @@ -30,19 +30,33 @@ > > #include "xen.h" > > -/* NB. All ops return zero on success, except XENVER_{version,pagesize} > - * XENVER_{version,pagesize,build_id} */ > +/** > + * DOC: XENVER_* > + * > + * NB. All ops return zero on success, except for: > + * > + * - XENVER_{version,pagesize} > + * - XENVER_{version,pagesize,build_id} You make the mistake made by 460d24188d81 even more obvious, instead of fixing it (by removing the first of these two lines). Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 07 13:19:21 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 13:19:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k42HD-0000GN-32; Fri, 07 Aug 2020 13:19:15 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k42HB-0000GI-KG for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 13:19:13 +0000 X-Inumbo-ID: bc00dd05-3b7e-411f-91ec-f4fdadf27f3f Received: from mail-lf1-x143.google.com (unknown [2a00:1450:4864:20::143]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id bc00dd05-3b7e-411f-91ec-f4fdadf27f3f; Fri, 07 Aug 2020 13:19:12 +0000 (UTC) Received: by mail-lf1-x143.google.com with SMTP id s9so983231lfs.4 for ; Fri, 07 Aug 2020 06:19:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=v+tM16kBQeEArp/adNDsPzgISiWKOmzNK4PsOuCVXOk=; b=F3jAJtuaL4zH/YZxgGIVjrxZkgFXL2u2QJRIDsbh3PQnWj+CkFd2xXhkJ5id0S/hkL sANXkkyp0e+F/+Phcz2FnvLX2bynNV73mMn8PvXHH+K0lGl085t4LHjqffBc3gfuiWWS opmcETb9Lybo57jx91XzkklCOBkjBhu6LD5r0IHXt6q6u+HiJDBp9P8kuDXvvNQ87LrG p72zUb7+pKkHxoYI6er91tebsTlbjj21ehViOi5X0OVg2tvDE34gxaZiB8oHiARZWVFf VRj7VjtAy0MuXXiUPF/saA0pg4N7ftObEE2R7MBug5v+vcNqpK9ZWOtttZtokg8rXB1Q 5s4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=v+tM16kBQeEArp/adNDsPzgISiWKOmzNK4PsOuCVXOk=; b=KW9q1x1UZEk/R4Qe0T9XuMa0sDcOXVgCFCOZoaTLZdKIq8hsioV2imfIOWMVN9TY3Z qW9086nzn+BUeMw4/viKp4W4VEoFti3DuX18v8ZF4Cb8njXUrEsIMimggkdN0cOfdTv/ z/TDiwW52wl8jURlfQ2X7cGC17Rz9nXMSbXAgqwoH33YpOnhcFCCk7hywY+I8qfrCeSf WlzxLhcv9I+BcPHA/URkj+UokJ4QVbTdSa9NyhojTCv65OtK8mKLDkqamxfSRbP1cMta n2myQOkbEvFgKiD0a/CJCoq2RgQn63vlxfivTL6PE2GSUhER3o9KBXEwzIKlE2RYXURp iQQQ== X-Gm-Message-State: AOAM531K8MhssE4CKBx4D5BUvWESBg6//vLE1RccjB9taBsn0vtKJZzz yv8qXd18GZGSotd0E4Jcm70= X-Google-Smtp-Source: ABdhPJwiNF+s/P6sp7pcOgva+W3yKCz/a2anYi1V4/WmeXBGqfYjUsImZRDOATVmqEKVvuSMiAGLAw== X-Received: by 2002:a19:8957:: with SMTP id l84mr6186828lfd.66.1596806351338; Fri, 07 Aug 2020 06:19:11 -0700 (PDT) Received: from [192.168.1.2] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id j66sm4233203lfd.74.2020.08.07.06.19.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Aug 2020 06:19:10 -0700 (PDT) Subject: Re: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common To: Stefano Stabellini References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-2-git-send-email-olekstysh@gmail.com> <000c01d66a33$2bd56510$83802f30$@xen.org> <9f83a7ed-ca97-449f-c7b9-a1140644abe9@gmail.com> <2ab4c567-8efa-1b9d-ab00-4ea7e1ab323e@suse.com> <51e30c1c-6b19-e646-fdc4-683b3197817a@suse.com> From: Oleksandr Message-ID: <6b616d44-9539-1766-cac7-da6a2dfbd7df@gmail.com> Date: Fri, 7 Aug 2020 16:19:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: 'Kevin Tian' , Julien Grall , 'Jun Nakajima' , 'Wei Liu' , paul@xen.org, 'Andrew Cooper' , 'Ian Jackson' , 'George Dunlap' , 'Tim Deegan' , 'Oleksandr Tyshchenko' , 'Julien Grall' , Jan Beulich , xen-devel@lists.xenproject.org, =?UTF-8?B?J1JvZ2VyIFBhdSBNb25uw6kn?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 06.08.20 23:32, Stefano Stabellini wrote: Hi Stefano > On Thu, 6 Aug 2020, Jan Beulich wrote: >> On 06.08.2020 02:37, Stefano Stabellini wrote: >>> What should do_trap_stage2_abort_guest do on IO_RETRY? Simply return >>> early and let the scheduler do its job? Something like: >>> >>> enum io_state state = try_handle_mmio(regs, hsr, gpa); >>> >>> switch ( state ) >>> { >>> case IO_ABORT: >>> goto inject_abt; >>> case IO_HANDLED: >>> advance_pc(regs, hsr); >>> return; >>> case IO_RETRY: >>> /* finish later */ >>> return; >>> case IO_UNHANDLED: >>> /* IO unhandled, try another way to handle it. */ >>> break; >>> default: >>> ASSERT_UNREACHABLE(); >>> } >>> >>> Then, xen/arch/arm/ioreq.c:handle_mmio() gets called by >>> handle_hvm_io_completion() after QEMU completes the emulation. Today, >>> handle_mmio just sets the user register with the read value. >>> >>> But it would be better if it called again the original function >>> do_trap_stage2_abort_guest to actually retry the original operation. >>> This time do_trap_stage2_abort_guest calls try_handle_mmio() and gets >>> IO_HANDLED instead of IO_RETRY, thus, it will advance_pc (the program >>> counter) completing the handling of this instruction. >>> >>> The user register with the read value could be set by try_handle_mmio if >>> try_fwd_ioserv returns IO_HANDLED instead of IO_RETRY. >>> >>> Is that how the state machine is expected to work? >> I think so. Just because it has taken us quite some time (years) on >> the x86 side to get reasonably close to how hardware would behave >> (I think we're still not fully there): The re-execution path needs >> to make sure it observes exactly the same machine state as the >> original path did. In particular changes to memory (by another vCPU) >> must not be observed. > Thanks for the heads up. I think I understand how it is supposed to work > now. I hope Oleksandr is on the same page. Not completely. I am still going through the discussion and navigating the code trying to understand missing bits for me. Thanks for trying to clarify how it supposed to work. -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Fri Aug 07 14:04:06 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 14:04:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k42yR-0004US-Lk; Fri, 07 Aug 2020 14:03:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k42yQ-0004Th-Cp for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 14:03:54 +0000 X-Inumbo-ID: 2e3324a0-465b-471e-9e8d-9e56a32ec071 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2e3324a0-465b-471e-9e8d-9e56a32ec071; Fri, 07 Aug 2020 14:03:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=D8+E4SYWcni1n9PxJjq2oUTp+eia2VvpWFnLlFKUMIA=; b=QlU8ax1+mAKeU5LtaxFlDfYOd zhFE5kAzJlIJth18k9QwJMHAFi1grQ4jCtONe2GWjOHAgXmfwpvkE2bTD+Tn2dZnSa6adDVNLiojr uTuYo8RlMOOmUY+ezs+7GqK5Oo3kdRH0Lu6gMQw9AjHGDKOyuk2D5FLAmk+DGcQC5vAlE=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k42yI-0001p5-Rh; Fri, 07 Aug 2020 14:03:46 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k42yI-0002vK-8V; Fri, 07 Aug 2020 14:03:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k42yI-0003th-80; Fri, 07 Aug 2020 14:03:46 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 152512: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=84bb5fd1ab2bce88e508d416f4bcea520c803ea8 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Fri, 07 Aug 2020 14:03:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152512 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/152512/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a version targeted for testing: libvirt 84bb5fd1ab2bce88e508d416f4bcea520c803ea8 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 28 days Failing since 151818 2020-07-11 04:18:52 Z 27 days 28 attempts Testing same since 152502 2020-08-06 04:20:09 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Andrea Bolognani Balázs Meskó Bastien Orivel Bihong Yu Binfeng Wu Boris Fiuczynski Côme Borsoi Daniel Henrique Barboza Daniel P. Berrange Daniel P. Berrangé Erik Skultety Fedora Weblate Translation Han Han Hao Wang Jean-Baptiste Holcroft Jianan Gao Jin Yan Jiri Denemark Ján Tomko Laine Stump Liao Pingfang Martin Kletzander Michal Privoznik Nikolay Shirokovskiy Paulo de Rezende Pinatti Pavel Hrdina Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Roman Bogorodskiy Ryan Schmidt Stefan Berger Szymon Scholz Wang Xin Weblate Yang Hang Yi Wang Yuri Chornoivan Zheng Chuan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 8907 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Aug 07 14:05:48 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 14:05:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k430G-0004ZE-2P; Fri, 07 Aug 2020 14:05:48 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k430E-0004Z4-ML for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 14:05:46 +0000 X-Inumbo-ID: a2639879-7456-4c42-9ec3-2504e0af3fe9 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a2639879-7456-4c42-9ec3-2504e0af3fe9; Fri, 07 Aug 2020 14:05:45 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F329EAC41; Fri, 7 Aug 2020 14:06:02 +0000 (UTC) Subject: Re: [PATCH v8 03/15] x86/mm: rewrite virt_to_xen_l*e To: Hongyan Xia References: From: Jan Beulich Message-ID: <41d9d8d4-d5cb-8350-c118-c9e1fe73b6d0@suse.com> Date: Fri, 7 Aug 2020 16:05:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , jgrall@amazon.com, Ian Jackson , George Dunlap , xen-devel@lists.xenproject.org, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 27.07.2020 16:21, Hongyan Xia wrote: > From: Wei Liu > > Rewrite those functions to use the new APIs. Modify its callers to unmap > the pointer returned. Since alloc_xen_pagetable_new() is almost never > useful unless accompanied by page clearing and a mapping, introduce a > helper alloc_map_clear_xen_pt() for this sequence. > > Note that the change of virt_to_xen_l1e() also requires vmap_to_mfn() to > unmap the page, which requires domain_page.h header in vmap. > > Signed-off-by: Wei Liu > Signed-off-by: Hongyan Xia > Reviewed-by: Jan Beulich > > --- > Changed in v8: > - s/virtual address/linear address/. > - BUG_ON() on NULL return in vmap_to_mfn(). The justification for this should be recorded in the description. In reply to v7 I did even suggest how to easily address the issue you did notice with large pages, as well as alternative behavior for vmap_to_mfn(). > --- a/xen/include/asm-x86/page.h > +++ b/xen/include/asm-x86/page.h > @@ -291,7 +291,15 @@ void copy_page_sse2(void *, const void *); > #define pfn_to_paddr(pfn) __pfn_to_paddr(pfn) > #define paddr_to_pfn(pa) __paddr_to_pfn(pa) > #define paddr_to_pdx(pa) pfn_to_pdx(paddr_to_pfn(pa)) > -#define vmap_to_mfn(va) _mfn(l1e_get_pfn(*virt_to_xen_l1e((unsigned long)(va)))) > + > +#define vmap_to_mfn(va) ({ \ > + const l1_pgentry_t *pl1e_ = virt_to_xen_l1e((unsigned long)(va)); \ > + mfn_t mfn_; \ > + BUG_ON(!pl1e_); \ > + mfn_ = l1e_get_mfn(*pl1e_); \ > + unmap_domain_page(pl1e_); \ > + mfn_; }) Additionally - no idea why I only notice this now, this wants some further formatting adjustment: Either #define vmap_to_mfn(va) ({ \ const l1_pgentry_t *pl1e_ = virt_to_xen_l1e((unsigned long)(va)); \ mfn_t mfn_; \ BUG_ON(!pl1e_); \ mfn_ = l1e_get_mfn(*pl1e_); \ unmap_domain_page(pl1e_); \ mfn_; \ }) or (preferably imo) #define vmap_to_mfn(va) ({ \ const l1_pgentry_t *pl1e_ = virt_to_xen_l1e((unsigned long)(va)); \ mfn_t mfn_; \ BUG_ON(!pl1e_); \ mfn_ = l1e_get_mfn(*pl1e_); \ unmap_domain_page(pl1e_); \ mfn_; \ }) Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 07 14:09:49 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 14:09:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4345-0004lI-KM; Fri, 07 Aug 2020 14:09:45 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4344-0004lD-Is for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 14:09:44 +0000 X-Inumbo-ID: 86808189-a9db-4cbe-8328-a32fa1c8fdd5 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 86808189-a9db-4cbe-8328-a32fa1c8fdd5; Fri, 07 Aug 2020 14:09:43 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 17AA3B5E9; Fri, 7 Aug 2020 14:10:01 +0000 (UTC) Subject: Re: [PATCH v8 07/15] x86_64/mm: switch to new APIs in paging_init To: Hongyan Xia References: <9919850a82a7f189de2b5dcc62c55bc9d5337c4b.1595857947.git.hongyxia@amazon.com> From: Jan Beulich Message-ID: <249246be-fcf4-a610-24e8-ca85963f00d0@suse.com> Date: Fri, 7 Aug 2020 16:09:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <9919850a82a7f189de2b5dcc62c55bc9d5337c4b.1595857947.git.hongyxia@amazon.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, jgrall@amazon.com, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Andrew Cooper Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 27.07.2020 16:21, Hongyan Xia wrote: > From: Wei Liu > > Map and unmap pages instead of relying on the direct map. > > Signed-off-by: Wei Liu > Signed-off-by: Hongyan Xia > Reviewed-by: Jan Beulich > > --- > Changed in v8: > - replace l3/2_ro_mpt_mfn with just mfn since their lifetimes do not > overlap Good, but ... > --- a/xen/arch/x86/x86_64/mm.c > +++ b/xen/arch/x86/x86_64/mm.c > @@ -481,6 +481,7 @@ void __init paging_init(void) > l3_pgentry_t *l3_ro_mpt; > l2_pgentry_t *pl2e = NULL, *l2_ro_mpt = NULL; > struct page_info *l1_pg; > + mfn_t mfn; > > /* > * We setup the L3s for 1:1 mapping if host support memory hotplug > @@ -493,22 +494,23 @@ void __init paging_init(void) > if ( !(l4e_get_flags(idle_pg_table[l4_table_offset(va)]) & > _PAGE_PRESENT) ) > { > - l3_pgentry_t *pl3t = alloc_xen_pagetable(); > + mfn_t l3mfn; ... what about this one? It's again only used ... > + l3_pgentry_t *pl3t = alloc_map_clear_xen_pt(&l3mfn); > > if ( !pl3t ) > goto nomem; > - clear_page(pl3t); > + UNMAP_DOMAIN_PAGE(pl3t); > l4e_write(&idle_pg_table[l4_table_offset(va)], > - l4e_from_paddr(__pa(pl3t), __PAGE_HYPERVISOR_RW)); > + l4e_from_mfn(l3mfn, __PAGE_HYPERVISOR_RW)); > } > } > > /* Create user-accessible L2 directory to map the MPT for guests. */ > - if ( (l3_ro_mpt = alloc_xen_pagetable()) == NULL ) > + l3_ro_mpt = alloc_map_clear_xen_pt(&mfn); ... without colliding with this first use of mfn. Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 07 14:13:44 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 14:13:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k437i-0005a0-5C; Fri, 07 Aug 2020 14:13:30 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k437h-0005Zv-Cb for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 14:13:29 +0000 X-Inumbo-ID: 4336478e-84f5-4e75-8e30-d7232f3257b4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4336478e-84f5-4e75-8e30-d7232f3257b4; Fri, 07 Aug 2020 14:13:28 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AC5B9B5DC; Fri, 7 Aug 2020 14:13:45 +0000 (UTC) Subject: Re: [PATCH v8 09/15] efi: use new page table APIs in copy_mapping To: Hongyan Xia References: <971376c3e2c04248ca0e5ef53ce59b8207bf1c6e.1595857947.git.hongyxia@amazon.com> From: Jan Beulich Message-ID: <4baffb98-3e23-33c6-b8bd-f83d2b615d46@suse.com> Date: Fri, 7 Aug 2020 16:13:29 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <971376c3e2c04248ca0e5ef53ce59b8207bf1c6e.1595857947.git.hongyxia@amazon.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, jgrall@amazon.com Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 27.07.2020 16:21, Hongyan Xia wrote: > From: Wei Liu > > Signed-off-by: Wei Liu > Signed-off-by: Hongyan Xia Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Fri Aug 07 14:22:29 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 14:22:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k43GG-0006V3-63; Fri, 07 Aug 2020 14:22:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k43GF-0006Uy-37 for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 14:22:19 +0000 X-Inumbo-ID: 99b96ece-4275-4878-a302-e0b0313680c6 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 99b96ece-4275-4878-a302-e0b0313680c6; Fri, 07 Aug 2020 14:22:18 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9F375AD78; Fri, 7 Aug 2020 14:22:35 +0000 (UTC) Subject: Re: [PATCH v6 03/11] x86/vmx: add IPT cpu feature To: =?UTF-8?Q?Micha=c5=82_Leszczy=c5=84ski?= References: <4d6eac657d082efaa0e7d141b5c9a07791b31f94.1594150543.git.michal.leszczynski@cert.pl> From: Jan Beulich Message-ID: <8ef32ee0-d614-cee5-6e34-295d8d278b12@suse.com> Date: Fri, 7 Aug 2020 16:22:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <4d6eac657d082efaa0e7d141b5c9a07791b31f94.1594150543.git.michal.leszczynski@cert.pl> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Julien Grall , Kevin Tian , Stefano Stabellini , tamas.lengyel@intel.com, Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , luwei.kang@intel.com, Jun Nakajima , xen-devel@lists.xenproject.org, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 07.07.2020 21:39, Michał Leszczyński wrote: > --- a/xen/arch/x86/hvm/vmx/vmcs.c > +++ b/xen/arch/x86/hvm/vmx/vmcs.c > @@ -291,6 +291,20 @@ static int vmx_init_vmcs_config(void) > _vmx_cpu_based_exec_control &= > ~(CPU_BASED_CR8_LOAD_EXITING | CPU_BASED_CR8_STORE_EXITING); > > + rdmsrl(MSR_IA32_VMX_MISC, _vmx_misc_cap); > + > + /* Check whether IPT is supported in VMX operation. */ > + if ( !smp_processor_id() ) Despite us not supporting offlining and re-onlining of the BSP (i.e. CPU 0) yet, I'm trying hard to keep new code from making assumptions like this one. Please don't base this on CPU number, but some other property (system_state, if nothing else can be found). Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 07 14:29:33 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 14:29:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k43NA-0006hS-VR; Fri, 07 Aug 2020 14:29:28 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k43N9-0006hN-0h for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 14:29:27 +0000 X-Inumbo-ID: 64207437-e62f-4bfc-bc5e-82df444351aa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 64207437-e62f-4bfc-bc5e-82df444351aa; Fri, 07 Aug 2020 14:29:26 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6DEBCACA9; Fri, 7 Aug 2020 14:29:43 +0000 (UTC) Subject: Re: [PATCH v6 04/11] common: add vmtrace_pt_size domain parameter To: =?UTF-8?Q?Micha=c5=82_Leszczy=c5=84ski?= References: <036bc768bfb074269d9bd4530304a11170b7142d.1594150543.git.michal.leszczynski@cert.pl> From: Jan Beulich Message-ID: <93de2427-d5ef-32b0-d5b0-dd9759c884f9@suse.com> Date: Fri, 7 Aug 2020 16:29:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <036bc768bfb074269d9bd4530304a11170b7142d.1594150543.git.michal.leszczynski@cert.pl> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Julien Grall , Stefano Stabellini , tamas.lengyel@intel.com, Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , luwei.kang@intel.com, xen-devel@lists.xenproject.org, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 07.07.2020 21:39, Michał Leszczyński wrote: > @@ -443,6 +449,9 @@ struct domain *domain_create(domid_t domid, > d->nr_pirqs = min(d->nr_pirqs, nr_irqs); > > radix_tree_init(&d->pirq_tree); > + > + if ( config->processor_trace_buf_kb ) > + d->processor_trace_buf_kb = config->processor_trace_buf_kb; There's no real need for the if, is there? > --- a/xen/include/public/domctl.h > +++ b/xen/include/public/domctl.h > @@ -92,6 +92,7 @@ struct xen_domctl_createdomain { > uint32_t max_evtchn_port; > int32_t max_grant_frames; > int32_t max_maptrack_frames; > + uint32_t processor_trace_buf_kb; Adding a new field to an existing interface struct requires bumping of the interface version, unless that has already happened during a release cycle. Here I agree with the choice of uint32_t, but ... > --- a/xen/include/xen/sched.h > +++ b/xen/include/xen/sched.h > @@ -457,6 +457,9 @@ struct domain > unsigned pbuf_idx; > spinlock_t pbuf_lock; > > + /* Used by vmtrace features */ > + uint32_t processor_trace_buf_kb; ... why a fixed size type here? unsigned int will do fine, won't it? Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 07 14:37:59 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 14:37:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k43VG-0007c0-Rp; Fri, 07 Aug 2020 14:37:50 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k43VG-0007bv-6W for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 14:37:50 +0000 X-Inumbo-ID: 91c23aa3-bcf8-42c5-8dd6-c8d57238241b Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 91c23aa3-bcf8-42c5-8dd6-c8d57238241b; Fri, 07 Aug 2020 14:37:49 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A5C13B71B; Fri, 7 Aug 2020 14:38:06 +0000 (UTC) Subject: Re: [PATCH v6 06/11] x86/hvm: processor trace interface in HVM To: =?UTF-8?Q?Micha=c5=82_Leszczy=c5=84ski?= References: <1916e06793ffaaa70c471bcd6bcf168597793bd5.1594150543.git.michal.leszczynski@cert.pl> From: Jan Beulich Message-ID: Date: Fri, 7 Aug 2020 16:37:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <1916e06793ffaaa70c471bcd6bcf168597793bd5.1594150543.git.michal.leszczynski@cert.pl> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Julien Grall , Stefano Stabellini , tamas.lengyel@intel.com, Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , luwei.kang@intel.com, xen-devel@lists.xenproject.org, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 07.07.2020 21:39, Michał Leszczyński wrote: > --- a/xen/arch/x86/domain.c > +++ b/xen/arch/x86/domain.c > @@ -2205,6 +2205,27 @@ int domain_relinquish_resources(struct domain *d) > altp2m_vcpu_disable_ve(v); > } > > + for_each_vcpu ( d, v ) > + { > + unsigned int i; > + uint64_t nr_pages = v->domain->processor_trace_buf_kb * KB(1); > + nr_pages >>= PAGE_SHIFT; > + > + if ( !v->vmtrace.pt_buf ) > + continue; > + > + for ( i = 0; i < nr_pages; i++ ) > + { > + struct page_info *pg = mfn_to_page( > + mfn_add(page_to_mfn(v->vmtrace.pt_buf), i)); > + > + put_page_alloc_ref(pg); > + put_page_and_type(pg); > + } > + > + v->vmtrace.pt_buf = NULL; > + } This needs to allow for preemption. Also this isn't x86-specific, so should be implemented in common code (just like allocation is). Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 07 15:00:11 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 15:00:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k43ql-0001Lc-PA; Fri, 07 Aug 2020 15:00:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k43ql-0001CQ-2z for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 15:00:03 +0000 X-Inumbo-ID: 36320f87-9cfc-4aac-b8fd-8a0005964dfc Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 36320f87-9cfc-4aac-b8fd-8a0005964dfc; Fri, 07 Aug 2020 15:00:01 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id EEA75ABA2; Fri, 7 Aug 2020 15:00:18 +0000 (UTC) Subject: Re: [PATCH v6 07/11] x86/vmx: implement IPT in VMX To: =?UTF-8?Q?Micha=c5=82_Leszczy=c5=84ski?= References: <7ddfc44d6ffde0fa307f0e074225f588c397aef0.1594150543.git.michal.leszczynski@cert.pl> From: Jan Beulich Message-ID: Date: Fri, 7 Aug 2020 17:00:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <7ddfc44d6ffde0fa307f0e074225f588c397aef0.1594150543.git.michal.leszczynski@cert.pl> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Tian , tamas.lengyel@intel.com, Wei Liu , Andrew Cooper , luwei.kang@intel.com, Jun Nakajima , xen-devel@lists.xenproject.org, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 07.07.2020 21:39, Michał Leszczyński wrote: > --- a/xen/arch/x86/hvm/vmx/vmx.c > +++ b/xen/arch/x86/hvm/vmx/vmx.c > @@ -428,6 +428,56 @@ static void vmx_domain_relinquish_resources(struct domain *d) > vmx_free_vlapic_mapping(d); > } > > +static int vmx_init_pt(struct vcpu *v) > +{ > + int rc; > + uint64_t size = v->domain->processor_trace_buf_kb * KB(1); > + > + if ( !v->vmtrace.pt_buf || !size ) > + return -EINVAL; > + > + /* > + * We don't accept trace buffer size smaller than single page > + * and the upper bound is defined as 4GB in the specification. > + * The buffer size must be also a power of 2. > + */ > + if ( size < PAGE_SIZE || size > GB(4) || (size & (size - 1)) ) > + return -EINVAL; > + > + v->arch.hvm.vmx.ipt_state = xzalloc(struct ipt_state); > + > + if ( !v->arch.hvm.vmx.ipt_state ) > + return -ENOMEM; > + > + v->arch.hvm.vmx.ipt_state->output_base = > + page_to_maddr(v->vmtrace.pt_buf); > + v->arch.hvm.vmx.ipt_state->output_mask.raw = size - 1; > + > + rc = vmx_add_host_load_msr(v, MSR_RTIT_CTL, 0); > + > + if ( rc ) > + return rc; > + > + rc = vmx_add_guest_msr(v, MSR_RTIT_CTL, > + RTIT_CTL_TRACE_EN | RTIT_CTL_OS | > + RTIT_CTL_USR | RTIT_CTL_BRANCH_EN); Indentation is off by three here, and ... > + if ( rc ) > + return rc; > + > + return 0; > +} ... this whole thing would be shorter (and hence easier to read) as return vmx_add_guest_msr(v, MSR_RTIT_CTL, RTIT_CTL_TRACE_EN | RTIT_CTL_OS | RTIT_CTL_USR | RTIT_CTL_BRANCH_EN); > +static int vmx_destroy_pt(struct vcpu* v) > +{ > + if ( v->arch.hvm.vmx.ipt_state ) > + xfree(v->arch.hvm.vmx.ipt_state); No need for the if(). > + v->arch.hvm.vmx.ipt_state = NULL; And everything together is actually simply "XFREE(v->arch.hvm.vmx.ipt_state);". > @@ -471,6 +521,14 @@ static int vmx_vcpu_initialise(struct vcpu *v) > > vmx_install_vlapic_mapping(v); > > + if ( v->domain->processor_trace_buf_kb ) > + { > + rc = vmx_init_pt(v); > + > + if ( rc ) > + return rc; > + } > + > return 0; > } Is there no cleanup you need to do in case of failure? The caller will invoke vmx_vcpu_destroy() only for failures subsequent to one coming from here. > @@ -513,6 +572,18 @@ static void vmx_save_guest_msrs(struct vcpu *v) > * be updated at any time via SWAPGS, which we cannot trap. > */ > v->arch.hvm.vmx.shadow_gs = rdgsshadow(); > + > + if ( unlikely(v->arch.hvm.vmx.ipt_state && > + v->arch.hvm.vmx.ipt_state->active) ) likely() / unlikely(), for being efficient, don't want && or || in their expressions. Please limit to just the left side of &&. > @@ -2240,6 +2322,25 @@ static bool vmx_get_pending_event(struct vcpu *v, struct x86_event *info) > return true; > } > > +static int vmx_control_pt(struct vcpu *v, bool enable) > +{ > + if ( !v->arch.hvm.vmx.ipt_state ) > + return -EINVAL; > + > + v->arch.hvm.vmx.ipt_state->active = enable; Peeking ahead into patch 9, the vCPU is paused at this point. Please add a respective ASSERT(), if only for documentation purposes. > +static int vmx_get_pt_offset(struct vcpu *v, uint64_t *offset, uint64_t *size) > +{ > + if ( !v->arch.hvm.vmx.ipt_state ) > + return -EINVAL; > + > + *offset = v->arch.hvm.vmx.ipt_state->output_mask.offset; > + *size = v->arch.hvm.vmx.ipt_state->output_mask.size + 1; Either the function parameter or the struct field is misnamed, or else there shouldn't be an addition of 1 here. > @@ -2295,6 +2396,8 @@ static struct hvm_function_table __initdata vmx_function_table = { > .altp2m_vcpu_update_vmfunc_ve = vmx_vcpu_update_vmfunc_ve, > .altp2m_vcpu_emulate_ve = vmx_vcpu_emulate_ve, > .altp2m_vcpu_emulate_vmfunc = vmx_vcpu_emulate_vmfunc, > + .vmtrace_control_pt = vmx_control_pt, > + .vmtrace_get_pt_offset = vmx_get_pt_offset, Better install these hooks only if the underlying feature is available (like we do for several other hooks)? > @@ -3674,6 +3777,13 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) > > hvm_invalidate_regs_fields(regs); > > + if ( unlikely(v->arch.hvm.vmx.ipt_state && > + v->arch.hvm.vmx.ipt_state->active) ) > + { > + rdmsrl(MSR_RTIT_OUTPUT_MASK, > + v->arch.hvm.vmx.ipt_state->output_mask.raw); Don't you also need to latch RTIT_STATUS? > --- a/xen/include/asm-x86/hvm/vmx/vmx.h > +++ b/xen/include/asm-x86/hvm/vmx/vmx.h > @@ -689,4 +689,18 @@ typedef union ldt_or_tr_instr_info { > }; > } ldt_or_tr_instr_info_t; > > +/* Processor Trace state per vCPU */ > +struct ipt_state { > + bool active; > + uint64_t status; > + uint64_t output_base; maddr_t according to its use. Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 07 15:12:53 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 15:12:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4433-0002d1-VV; Fri, 07 Aug 2020 15:12:45 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4432-0002cw-NC for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 15:12:44 +0000 X-Inumbo-ID: 6e73d427-1216-4706-998b-76718d023b63 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6e73d427-1216-4706-998b-76718d023b63; Fri, 07 Aug 2020 15:12:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596813162; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=iWe7U1LSxZC/AETA/35Xuxm0unXNKWryeklFWGAW/5A=; b=Mak56FsSH1oyTqFmFDYgQkvPmOIlCozJQLd30r4LNVa1Dgvj+pvf3tjm ce+C7ZsJpk30NgeAJlAPg2gzfTxznSR/hky47Ncboy/ptgMzgSxagADwV +vvprgmf7Ukb8eyNU9RyuIvyAZGPqG3jKDFOnYIHIJ6Mw4dU1J9S0R139 s=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: sItmGOFlMv+DnxvJprH98OAaukHpi19xFUrQhHgAVsoiJokVCvfC55M7C+EWKhjd77jrRJdLrv 3NaT12TvtHyMcv6JKR0+B+WzR1pbqIC1w0xJr1854GNIC9wbumJDtRWpAn0QsHGlEgvFakOcYZ v0XWPEHWHxyFml42ssnFzHf6vvRY5oOcIx4oRVLFIg+Bz211OjzASSoqoNIC1krG+UsmUm8Lrs gGNs1tFeIp2cYcyoh267I/PqdnnXHwx+YDZsvZA94fIrjF6dB1ulth/POGhrVugU2jCWepCBBr oaM= X-SBRS: 2.7 X-MesageID: 24971644 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,446,1589256000"; d="scan'208";a="24971644" Subject: Re: [PATCH 3/4] build: also check for empty .bss.* in .o -> .init.o conversion To: Jan Beulich References: <305c2532-408a-9f78-61fe-c90a2e86eb8e@suse.com> <5b2bbc31-0095-c3e2-9e34-20453ea2aa5f@citrix.com> <61481966-3052-ebf2-e23b-aac292cd09a1@suse.com> From: Andrew Cooper Message-ID: <9a3cd872-bc6c-3113-fdf9-2f80ad8fabce@citrix.com> Date: Fri, 7 Aug 2020 16:12:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <61481966-3052-ebf2-e23b-aac292cd09a1@suse.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , George Dunlap , Ian Jackson , "xen-devel@lists.xenproject.org" , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 07/08/2020 11:56, Jan Beulich wrote: > On 06.08.2020 18:16, Andrew Cooper wrote: >> On 06/08/2020 10:05, Jan Beulich wrote: >> Can't we remove all of this by having CONFIG_XEN_PE expressed/selectable >> properly in Kconfig, and gathering all the objects normally, rather than >> bodging all of common/efi/ through arch/efi/ ? > _If_ we settle on Kconfig to be allowed to check compiler (and linker) > features, then yes. This continues to be a pending topic though, so > the switch can't be made like this at this point in time. (It could be > made a Kconfig item now - which, when enabled, implies the assertion > that a capable tool chain is in use.) I am still of the opinion that nothing needs discussing, but you are obviously not. Please raise this as a topic and lets discuss it, because it has a meaningful impacting on a large number of pending series. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Aug 07 15:13:57 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 15:13:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k443z-0002gj-9w; Fri, 07 Aug 2020 15:13:43 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k443x-0002g1-O1 for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 15:13:41 +0000 X-Inumbo-ID: 10323f95-3e1c-4165-8328-722a33e63570 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 10323f95-3e1c-4165-8328-722a33e63570; Fri, 07 Aug 2020 15:13:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=FKsFWzYGU6fzzaDiAZUitSZ5clSCSNIRQFoYu57Cyco=; b=V6MRUQD1g03ROQg+OV9UE6+T4 s0U9hNTMr/SVHfxXdlN/Gx3HL0HAzMd4FmfXo1QCLIbjzpxGWvVuqCqSlzYl7UwiY2PDTxiSYuFas 4qNVb84LebK4XWDrpEgOCv5LSPhi7Gn3Er/rQ2rsU0Twy4tndBvMZ6C1AajtzPP36tIy0=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k443q-0003NZ-7S; Fri, 07 Aug 2020 15:13:34 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k443p-0005fN-S1; Fri, 07 Aug 2020 15:13:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k443p-0003UG-RM; Fri, 07 Aug 2020 15:13:33 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 152524: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=16dcc135e89663628ee2eaf2d02991fc9ce954bf X-Osstest-Versions-That: xen=b2bc1e714462c6cc222e3bbc38d87b039b4fa405 From: osstest service owner Date: Fri, 07 Aug 2020 15:13:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152524 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/152524/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass version targeted for testing: xen 16dcc135e89663628ee2eaf2d02991fc9ce954bf baseline version: xen b2bc1e714462c6cc222e3bbc38d87b039b4fa405 Last test of basis 152494 2020-08-05 17:01:20 Z 1 days Testing same since 152524 2020-08-07 12:02:32 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git b2bc1e7144..16dcc135e8 16dcc135e89663628ee2eaf2d02991fc9ce954bf -> smoke From xen-devel-bounces@lists.xenproject.org Fri Aug 07 15:40:49 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 15:40:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k44Tz-0005f4-M6; Fri, 07 Aug 2020 15:40:35 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k44Ty-0005ez-UI for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 15:40:34 +0000 X-Inumbo-ID: a565c9e8-62f3-44a5-a1b6-75eececcfc29 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a565c9e8-62f3-44a5-a1b6-75eececcfc29; Fri, 07 Aug 2020 15:40:34 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5F9C5ADE0; Fri, 7 Aug 2020 15:40:51 +0000 (UTC) Subject: Re: [PATCH 3/4] build: also check for empty .bss.* in .o -> .init.o conversion To: Andrew Cooper References: <305c2532-408a-9f78-61fe-c90a2e86eb8e@suse.com> <5b2bbc31-0095-c3e2-9e34-20453ea2aa5f@citrix.com> <61481966-3052-ebf2-e23b-aac292cd09a1@suse.com> <9a3cd872-bc6c-3113-fdf9-2f80ad8fabce@citrix.com> From: Jan Beulich Message-ID: <039916f1-c9f2-710f-8f46-3ff9d91a9109@suse.com> Date: Fri, 7 Aug 2020 17:40:34 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <9a3cd872-bc6c-3113-fdf9-2f80ad8fabce@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , George Dunlap , Ian Jackson , "xen-devel@lists.xenproject.org" , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 07.08.2020 17:12, Andrew Cooper wrote: > On 07/08/2020 11:56, Jan Beulich wrote: >> On 06.08.2020 18:16, Andrew Cooper wrote: >>> On 06/08/2020 10:05, Jan Beulich wrote: >>> Can't we remove all of this by having CONFIG_XEN_PE expressed/selectable >>> properly in Kconfig, and gathering all the objects normally, rather than >>> bodging all of common/efi/ through arch/efi/ ? >> _If_ we settle on Kconfig to be allowed to check compiler (and linker) >> features, then yes. This continues to be a pending topic though, so >> the switch can't be made like this at this point in time. (It could be >> made a Kconfig item now - which, when enabled, implies the assertion >> that a capable tool chain is in use.) > > I am still of the opinion that nothing needs discussing, but you are > obviously not. > > Please raise this as a topic and lets discuss it, because it has a > meaningful impacting on a large number of pending series. Preferably I would have put this on this month's community meeting agenda, but I'll be ooo next week, so that's not going to help, I'm afraid. I guess I should put it up in email form when I'm back, albeit I wasn't thinking it should need to be me to start the discussion. Instead my view was that such a discussion should (have been, now after-the-fact) be started by whoever wants to introduce a new feature. You did say this was discussed in Chicago, but while I'm pretty sure I was in all relevant sessions, I don't think this can have been mentioned more than just in passing. Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 07 16:34:10 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 16:34:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k45JY-0002AG-4X; Fri, 07 Aug 2020 16:33:52 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k45JW-0002AB-6z for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 16:33:50 +0000 X-Inumbo-ID: f38a59c4-e603-4c6a-a3ff-7116ba1103e3 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f38a59c4-e603-4c6a-a3ff-7116ba1103e3; Fri, 07 Aug 2020 16:33:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596818029; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=nnO5aTOZjX5ID+ZoNXOeOZbxKmrfJzqt5vu6mexE4SI=; b=hsRWI1QoDqyDAB+fm3DdlZnvx12QVjMxI4ReF97HGwhYd3yM5Qwqpdun MJgoffL3Xe4FnRskUe0W1AmSi2zI8N80HTMlb2DzbxQW/YafOzWf/mJtq nFjKeupX6p1DDnyXvwIcbeI8bkMQB1I8YMdwEzr5uazh6JjhC4EvYVpD2 c=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: wtMOLiNMujuNa+yCG+2xE1d/W+TgArODTJtev51V8xVAEFbrnK9wjmjtGzN4kHLohU84aubPDB 9D8oVSruLAtBSi35/aGYVHE+T2DkMn2mjQO7B5uTG0kEV3VIzbWhNf4gwgKkmzKMlZwZaf9BjV R0rXwzh6jodNfCMt1ZM4C62NSp6zb/ZGsDadNCh0mVqqaAGJm/XnY9NH6dLIIA6puLH719dAhS jdptwiRU7yuvlt7hcrv02XcNsHsc1iYEAJSAGqpLQaccifWdYKOtodw00irCh/NLLNkATv5YO7 hVQ= X-SBRS: 2.7 X-MesageID: 24253274 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,446,1589256000"; d="scan'208";a="24253274" Subject: Re: [PATCH v2 1/7] x86/EFI: sanitize build logic To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <3a8356a9-313c-6de8-f409-977eae1fbfa5@suse.com> <07e622b4-bb61-08e8-d96c-e770ec7abc53@suse.com> From: Andrew Cooper Message-ID: <0a544a9d-edc8-cb71-05a2-77c860050836@citrix.com> Date: Fri, 7 Aug 2020 17:33:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <07e622b4-bb61-08e8-d96c-e770ec7abc53@suse.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 07/08/2020 12:32, Jan Beulich wrote: > With changes done over time and as far as linking goes, the only special > thing about building with EFI support enabled is the need for the dummy > relocations object for xen.gz uniformly in all build stages. All other > efi/*.o can be consumed from the built_in*.o files. > > In efi/Makefile, besides moving relocs-dummy.o to "extra", also properly > split between obj-y and obj-bin-y. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper I'd prefer to see this all in Kconfig, but this is a clear improvement in its own right. From xen-devel-bounces@lists.xenproject.org Fri Aug 07 16:45:50 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 16:45:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k45V0-000378-7k; Fri, 07 Aug 2020 16:45:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k45Ux-000373-Vy for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 16:45:40 +0000 X-Inumbo-ID: 24368799-a221-453a-957f-4d67da6648d7 Received: from mail-lj1-x243.google.com (unknown [2a00:1450:4864:20::243]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 24368799-a221-453a-957f-4d67da6648d7; Fri, 07 Aug 2020 16:45:39 +0000 (UTC) Received: by mail-lj1-x243.google.com with SMTP id w14so2897129ljj.4 for ; Fri, 07 Aug 2020 09:45:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=OKnKaDsW4tXKd1t6D0Hn6bOIWa9VRPJN8GCZNprwAxw=; b=rWtAOm3p42vcepX9bTiK6E1onY4lThF1oWXO0xv2H5/pRnJQ8oWf4Gg2VVfEe2Nu6p k4Cr5A3qMRck362TE7a76VKzRWwtqDvXEl/Rtq/xtbpFR1KlCMIzNdU2aVZyAqQbAnvX HFteaupAIuO1e1TLQufKQmTxUZDB2V5cwDpASpp76KcSSNAUXPNJ5NcJ6c53y/hHMok4 tubu1HSIeda3OEp1nxvZNVTshrnb64RGdxLE6aeF2mBXIWqsKyjCuHKiTHO6KD77LKfF KTcQ5JjR0QqMjRMD/bRPjRVVtN9O1JyV2Vw5Lw8tdE/wRFE3CLqb1Af5xSgzEM3ELfup bN7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=OKnKaDsW4tXKd1t6D0Hn6bOIWa9VRPJN8GCZNprwAxw=; b=KTu2KCXQxkPEhrevKpUS7CxkWavkrFstfbrqw79yiOKhXm0YRZgWfcyTzpAWsFJn8g 07+TPd5LNXdvrztA66qN1xK2luSCjRDRtwJQDAHiGmwL3sHCZc1y98Rcw/VUk88zoq+n HKD3FjL8D/xwA8GrGnUyEI6MAdsDL8P3/YFisAHQX9rTzOYCduUd6IsM+EE3DnALosVR 0vngmEkGGa1mELPnTXWYlDHOdFntzM7j0+LyoPTQlq8WsYdxmVlnE6D5yZgRRzAxOkDW QbPWVrl1kwx55WvE8vjY2E+R9d3nF1xGlpL7kSMAl5Ttu5B9oo6gOhXyOPgUizmvW4pF Lh7A== X-Gm-Message-State: AOAM533z6IwciYaVSFvxAqisCBpn2zhbK9nBw5WwhLyU1X+4gmP+fJ0E lloVGMnofkoTRx4ECfsP2Ac= X-Google-Smtp-Source: ABdhPJzlvlMiDaTgaWxs+TXT686mYyyf+coLR/aYlu3B49X/+CPgbNcAIJXDgnxJI8WmKGp3HXuuVQ== X-Received: by 2002:a2e:810c:: with SMTP id d12mr6319288ljg.34.1596818737811; Fri, 07 Aug 2020 09:45:37 -0700 (PDT) Received: from [192.168.1.2] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id v14sm3964892ljk.10.2020.08.07.09.45.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Aug 2020 09:45:37 -0700 (PDT) Subject: Re: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common To: Stefano Stabellini References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-2-git-send-email-olekstysh@gmail.com> <000c01d66a33$2bd56510$83802f30$@xen.org> <9f83a7ed-ca97-449f-c7b9-a1140644abe9@gmail.com> <2ab4c567-8efa-1b9d-ab00-4ea7e1ab323e@suse.com> From: Oleksandr Message-ID: <013b142d-5296-5bbe-7d19-903f59e0c974@gmail.com> Date: Fri, 7 Aug 2020 19:45:31 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: 'Kevin Tian' , Julien Grall , 'Jun Nakajima' , 'Wei Liu' , paul@xen.org, 'Andrew Cooper' , 'Ian Jackson' , 'George Dunlap' , 'Tim Deegan' , 'Oleksandr Tyshchenko' , 'Julien Grall' , Jan Beulich , xen-devel@lists.xenproject.org, =?UTF-8?B?J1JvZ2VyIFBhdSBNb25uw6kn?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 06.08.20 03:37, Stefano Stabellini wrote: Hi Stefano Trying to simulate IO_RETRY handling mechanism (according to model below) I continuously get IO_RETRY from try_fwd_ioserv() ... > OK, thanks for the details. My interpretation seems to be correct. > > In which case, it looks like xen/arch/arm/io.c:try_fwd_ioserv should > return IO_RETRY. Then, xen/arch/arm/traps.c:do_trap_stage2_abort_guest > also needs to handle try_handle_mmio returning IO_RETRY the first > around, and IO_HANDLED when after QEMU does its job. > > What should do_trap_stage2_abort_guest do on IO_RETRY? Simply return > early and let the scheduler do its job? Something like: > > enum io_state state = try_handle_mmio(regs, hsr, gpa); > > switch ( state ) > { > case IO_ABORT: > goto inject_abt; > case IO_HANDLED: > advance_pc(regs, hsr); > return; > case IO_RETRY: > /* finish later */ > return; > case IO_UNHANDLED: > /* IO unhandled, try another way to handle it. */ > break; > default: > ASSERT_UNREACHABLE(); > } > > Then, xen/arch/arm/ioreq.c:handle_mmio() gets called by > handle_hvm_io_completion() after QEMU completes the emulation. Today, > handle_mmio just sets the user register with the read value. > > But it would be better if it called again the original function > do_trap_stage2_abort_guest to actually retry the original operation. > This time do_trap_stage2_abort_guest calls try_handle_mmio() and gets > IO_HANDLED instead of IO_RETRY, I may miss some important point, but I failed to see why try_handle_mmio (try_fwd_ioserv) will return IO_HANDLED instead of IO_RETRY at this stage. Or current try_fwd_ioserv() logic needs rework? > thus, it will advance_pc (the program > counter) completing the handling of this instruction. > > The user register with the read value could be set by try_handle_mmio if > try_fwd_ioserv returns IO_HANDLED instead of IO_RETRY. > > Is that how the state machine is expected to work? -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Fri Aug 07 16:56:47 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 16:56:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k45fa-00042e-B0; Fri, 07 Aug 2020 16:56:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k45fZ-00042Z-BR for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 16:56:37 +0000 X-Inumbo-ID: 893ed4c8-0c39-429e-8975-f20b523d7f7f Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 893ed4c8-0c39-429e-8975-f20b523d7f7f; Fri, 07 Aug 2020 16:56:36 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9C48920866; Fri, 7 Aug 2020 16:56:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596819396; bh=L4Oo2e9/6G/FSJhkz8IPjwKYaQ0EbVwCkTFCedj4wbg=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=hbqQRAcqeRAIK1Pip7I+BPWcgWaSSbDBQEA9p1KOM2bNPvCMF1KrrgnNFw5DffbwN q/ti0TCOEzMXEFhbe+CZQxfcb7QMPqB+tYySqYqfMPwp6mze4dckzl+B4BFTgbCple uADLkJ9QotGDM4lx8H2aZC+drxBJ34fiv6Ut8vfY= Date: Fri, 7 Aug 2020 09:56:35 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Stefano Stabellini Subject: Re: [PATCH 00/14] kernel-doc: public/arch-arm.h In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: julien@xen.org, wl@xen.org, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" I am replying to this email as I have been told that the original was filtered as spam due to the tarball attachment. The tarball contains some example html output document files from sphinx. I have uploaded the tarball here for your convenience: http://xenbits.xenproject.org/people/sstabellini/html.tar.gz You can read the original email below. On Thu, 6 Aug 2020, Stefano Stabellini wrote: > Hi all, > > This patch series convert Xen in-code comments to the kernel-doc format: > > https://www.kernel.org/doc/html/latest/doc-guide/kernel-doc.html > > > # WHAT WAS CONVERTED > > I started from the public/ header files as I thought they are the most > important to generated documentation for. > > I didn't cover all files under xen/include/public/, but we don't have to > boil the ocean in one go. > > For the header files I addressed, I did cover all in-code comments > except for very few exceptions where the conversion to kernel-doc format > wasn't easily doable without major changes to the comments/code. > > The conversion was done by hand (sigh!) but was mechanical, and only > stylistic: I didn't change the content of the comments (only in a couple > of places to make the English work right, e.g. when a comment has been > split into two comments.) > > > # THE KERNEL-DOC KEYWORDS USED > > I used the "struct" keyword for structures, i.e.: > > /** > * struct foobar > */ > > "struct" makes kernel-doc go and look at the following struct in the > code, parses struct members comments, and generate a doc optimized to > describe a struct. Note that in these cases the struct needs to follow > immediately the comment. Thus, I had to move an #define between the > comment and the struct in a few places. > > Also note that kernel-doc supports nested structs but due to a quirk, > comments for nested struct members cannot be on a single line. They have > to be: > > struct foo { > struct { > /** > * @u.bar: foobar > */ > bar; > } u; > } > > Otherwise for normal struct the single line comment works fine: > > struct foo { > /** @bar: foobar */ > bar; > } > > > I used the "DOC" keyword otherwise. "DOC" is freeform, not particularly > tied to anything following (functions, enums, etc.) I kept a black line > between "DOC" and the following comment if multiline and no blank line > if it is single line. > > /** > * DOC: doc1 > * single line comment > */ > > /** > * DOC: doc2 > * > * this is > * multiline > */ > > DOC doesn't generate any cross-documents links but it is still a great > place to start as it makes the in-code comments immediately available as > documents. Linking and references can be added later. > > > # HOW TO TEST IT > > Simply run kernel-doc on a header file, for instance: > > ../linux/scripts/kernel-doc xen/include/public/event_channel.h > /tmp/doc.rst > > You can inspect the rst file and also generate a html file out of it with > sphinx: > > sphinx-quickstart > sphinx-build . /path/to/out > > I am attaching two example output html files together with the static CSS > and images to render them correctly. Note that of course I haven't > worked on the CSS at all, clearly the style can be vastly improved, but > I wanted to give you an idea of how readable they actually are even like > this. > > > Cheers, > > Stefano > > > The following changes since commit 81fd0d3ca4b2cd309403c6e8da662c325dd35750: > > x86/hvm: simplify 'mmio_direct' check in epte_get_entry_emt() (2020-07-31 17:43:31 +0200) > > are available in the Git repository at: > > http://xenbits.xenproject.org/git-http/people/sstabellini/xen-unstable.git hyp-docs-1 > > for you to fetch changes up to abbd21dfa0ff14a7eb5faa57aaf3db24f83a149f: > > kernel-doc: public/hvm/params.h (2020-08-06 16:27:22 -0700) > > ---------------------------------------------------------------- > Stefano Stabellini (14): > kernel-doc: public/arch-arm.h > kernel-doc: public/hvm/hvm_op.h > kernel-doc: public/device_tree_defs.h > kernel-doc: public/event_channel.h > kernel-doc: public/features.h > kernel-doc: public/grant_table.h > kernel-doc: public/hypfs.h > kernel-doc: public/memory.h > kernel-doc: public/sched.h > kernel-doc: public/vcpu.h > kernel-doc: public/version.h > kernel-doc: public/xen.h > kernel-doc: public/elfnote.h > kernel-doc: public/hvm/params.h > > xen/include/public/arch-arm.h | 43 ++- > xen/include/public/device_tree_defs.h | 24 +- > xen/include/public/elfnote.h | 109 +++++-- > xen/include/public/event_channel.h | 188 +++++++---- > xen/include/public/features.h | 78 +++-- > xen/include/public/grant_table.h | 443 +++++++++++++++----------- > xen/include/public/hvm/hvm_op.h | 20 +- > xen/include/public/hvm/params.h | 158 ++++++++-- > xen/include/public/hypfs.h | 72 +++-- > xen/include/public/memory.h | 232 +++++++++----- > xen/include/public/sched.h | 129 +++++--- > xen/include/public/vcpu.h | 180 ++++++++--- > xen/include/public/version.h | 74 ++++- > xen/include/public/xen.h | 567 ++++++++++++++++++++++------------ > 14 files changed, 1564 insertions(+), 753 deletions(-) From xen-devel-bounces@lists.xenproject.org Fri Aug 07 17:14:21 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 17:14:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k45wZ-0005mq-Tz; Fri, 07 Aug 2020 17:14:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k45wZ-0005ml-3f for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 17:14:11 +0000 X-Inumbo-ID: 37846215-4723-44f4-90ea-dc4faf91d2cb Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 37846215-4723-44f4-90ea-dc4faf91d2cb; Fri, 07 Aug 2020 17:14:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596820449; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=YOv9m0OA/Njj00Z8OLpL/M86vtvTEEo/iImQR6upzVE=; b=XfSZjtlFJEX603sk+nth7vm7NEFEcrpDIRlqjP4wfXDQx+hCqi9RznsM CPe68pp1Fif3jzi9xk+kb/E/4aggIESavAhCfAcByTvMgzyRSUBL9XqIs Z9Mu3yIRXJc2VJ2UXDG8up6TWgfjxAd4O8Nz4H95sZLmd3hfrIObpEt0n o=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: yr4h3eRYOVSRdXPMgdRowVeJMPmBfN3D987wTz6jkjI8us0o1k3CX5W5mcRBKizGuE6iJbPDl2 igK9F/vry0+r5yzwS7CVk6K45dhKeGX1Gay476bsUMt713AfEKoMgXdfZOpGxZG67CFyDUgf24 C0dGBdxqprpgWrCk6Bw1rNwaD23F+t4bOjM7HJmHRQY1XuWTgNAN4onW+IftoMfmvJcBV3Y0Be MfeV5UTnm+H0HL00jdnL7KuexmyPQzESJnwh0kF7MiutpVvZDxu0A0MEHhE402288uWw+uSZda kiw= X-SBRS: 2.7 X-MesageID: 24398669 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,446,1589256000"; d="scan'208";a="24398669" Subject: Re: [PATCH v2 3/7] x86: shrink struct arch_{vcpu,domain} when !HVM To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <3a8356a9-313c-6de8-f409-977eae1fbfa5@suse.com> <014a655b-7080-3804-3a56-5e00851a2a7d@suse.com> From: Andrew Cooper Message-ID: <306cec0c-93e6-4b45-f68c-3808309478bf@citrix.com> Date: Fri, 7 Aug 2020 18:14:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <014a655b-7080-3804-3a56-5e00851a2a7d@suse.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 07/08/2020 12:33, Jan Beulich wrote: > While this won't affect overall memory overhead (struct vcpu as well as > struct domain get allocated as single pages) nor code size (the offsets > into the base structures are too large to be representable as signed 8- > bit displacements), it'll allow the tail of struct pv_{domain,vcpu} to > share a cache line with subsequent struct arch_{domain,vcpu} fields. > > Signed-off-by: Jan Beulich > --- > RFC: There is a risk associated with this: If we still have code > somewhere accessing the HVM parts of the structures without a prior > type check of the guest, this going to end up worse than the so far > not uncommon case of the access simply going to space unused by PV. > We may therefore want to consider whether to further restrict when > this conversion to union gets done. > And of course there's also the risk of future compilers complaining > about this abuse of unions. But this is limited to code that's dead > in !HVM configs, so only an apparent problem. > > --- a/xen/include/asm-x86/hvm/domain.h > +++ b/xen/include/asm-x86/hvm/domain.h > @@ -99,7 +99,13 @@ struct hvm_pi_ops { > > #define MAX_NR_IOREQ_SERVERS 8 > > -struct hvm_domain { > +typedef > +#ifdef CONFIG_HVM > +struct > +#else > +union > +#endif > +hvm_domain { > /* Guest page range used for non-default ioreq servers */ > struct { > unsigned long base; > @@ -203,7 +209,7 @@ struct hvm_domain { > #ifdef CONFIG_MEM_SHARING > struct mem_sharing_domain mem_sharing; > #endif > -}; > +} hvm_domain_t; Honestly, I'd say no to this patch even it resulted in a 100x speedup, because I am totally lost for words about this construct, and the effect it comprehensibility of our code. Seeing as improved cache locality appears to be the sole benefit, marginal as it is, you can achieve that in a better way by rearranging struct domain/vcpu to put the pv/hvm union at the end. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Aug 07 17:51:02 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 17:51:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k46Vs-0000l5-1f; Fri, 07 Aug 2020 17:50:40 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k46Vq-0000l0-Nn for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 17:50:38 +0000 X-Inumbo-ID: d5ad2b37-00c7-46cf-940e-f048e993cece Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d5ad2b37-00c7-46cf-940e-f048e993cece; Fri, 07 Aug 2020 17:50:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596822636; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=wwCZLKDhb5/YHhej40g9Rn2xcYtbyTNw7MdBP6jan68=; b=ihfffQgDex21wl4lLunsxYKBS0kNghNDffsk7YBiBV9L4LC/YleBzxKQ w/Iuu8WPZmSQT2TVubXnBoBD2zrsyNZkvxYLFQvDuuwez+og8P1QJmj+1 ipPyQX+XpTnpxxrFFZ7AJDz6lXBVhZbXdKcOMHBY3jKkEsP7KeyqeX0SG M=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 95vaTNz1rDw8oL3yK908yQAuC+KF38oWZ9SCRarG7Ppc57YIt+MjzVY6128t47a/nJt1VcyH5I WkMdJKbXOOns/87G16HF2FQnx1d0CK1/7MgRkM68/cqkBbNSIud8nFkh20wKUMl4YR4kzGav/Z Yy0mLqgiq+6N3ppxYFKJiAu84HRVamHvYT1ocNfQr3HJcEVH0xcdexQANKw+8RY03qhpsvcInq sCOdWqe8Io5Mtr9AhFTuzlQ2Vv9wmwu37BEqjrmbtvQDH4I1EYpJE7KCLXVjTmnZTuGyHQBzgP /jU= X-SBRS: 2.7 X-MesageID: 24071940 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,446,1589256000"; d="scan'208";a="24071940" Subject: Re: [PATCH v2 4/7] bitmap: move to/from xenctl_bitmap conversion helpers To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <3a8356a9-313c-6de8-f409-977eae1fbfa5@suse.com> <677805f1-c44c-ef65-8190-c4de3bdb327d@suse.com> From: Andrew Cooper Message-ID: Date: Fri, 7 Aug 2020 18:50:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <677805f1-c44c-ef65-8190-c4de3bdb327d@suse.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: George Dunlap , Ian Jackson , Stefano Stabellini , Julien Grall , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 07/08/2020 12:33, Jan Beulich wrote: > --- a/xen/common/bitmap.c > +++ b/xen/common/bitmap.c > @@ -384,3 +386,87 @@ void bitmap_byte_to_long(unsigned long * > } > > #endif > + > +int bitmap_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_bitmap, > + const unsigned long *bitmap, unsigned int nbits) > +{ > + unsigned int guest_bytes, copy_bytes, i; > + uint8_t zero = 0; > + int err = 0; > + uint8_t *bytemap = xmalloc_array(uint8_t, (nbits + 7) / 8); > + > + if ( !bytemap ) > + return -ENOMEM; > + > + guest_bytes = (xenctl_bitmap->nr_bits + 7) / 8; > + copy_bytes = min_t(unsigned int, guest_bytes, (nbits + 7) / 8); > + > + bitmap_long_to_byte(bytemap, bitmap, nbits); > + > + if ( copy_bytes != 0 ) > + if ( copy_to_guest(xenctl_bitmap->bitmap, bytemap, copy_bytes) ) > + err = -EFAULT; > + > + for ( i = copy_bytes; !err && i < guest_bytes; i++ ) > + if ( copy_to_guest_offset(xenctl_bitmap->bitmap, i, &zero, 1) ) > + err = -EFAULT; > + > + xfree(bytemap); > + > + return err; > +} > + > +int xenctl_bitmap_to_bitmap(unsigned long *bitmap, > + const struct xenctl_bitmap *xenctl_bitmap, > + unsigned int nbits) > +{ > + unsigned int guest_bytes, copy_bytes; > + int err = 0; > + uint8_t *bytemap = xzalloc_array(uint8_t, (nbits + 7) / 8); > + > + if ( !bytemap ) > + return -ENOMEM; > + > + guest_bytes = (xenctl_bitmap->nr_bits + 7) / 8; > + copy_bytes = min_t(unsigned int, guest_bytes, (nbits + 7) / 8); > + > + if ( copy_bytes != 0 ) > + { > + if ( copy_from_guest(bytemap, xenctl_bitmap->bitmap, copy_bytes) ) > + err = -EFAULT; > + if ( (xenctl_bitmap->nr_bits & 7) && (guest_bytes == copy_bytes) ) > + bytemap[guest_bytes-1] &= ~(0xff << (xenctl_bitmap->nr_bits & 7)); > + } > + > + if ( !err ) > + bitmap_byte_to_long(bitmap, bytemap, nbits); > + > + xfree(bytemap); > + > + return err; > +} > + > +int cpumask_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_cpumap, > + const cpumask_t *cpumask) > +{ > + return bitmap_to_xenctl_bitmap(xenctl_cpumap, cpumask_bits(cpumask), > + nr_cpu_ids); > +} > + > +int xenctl_bitmap_to_cpumask(cpumask_var_t *cpumask, > + const struct xenctl_bitmap *xenctl_cpumap) > +{ > + int err = 0; > + > + if ( alloc_cpumask_var(cpumask) ) { At a minimum, please fix this style during the move. However, the more I look at this code, the more concerned I get. There is absolutely no need to allocate(/doubly allocate) memory or double/triple bounce buffer the data.  All that is necessary is some careful handling of the copy length, and trailing zeroing. The cpumask variants should be trivial static inline wrapper.  The fact that they're not suggests an API error. In reality, these are just data-shuffling helpers, and would probably live better in a guest-access.c if we had a suitable one to hand, but I guess bitmap.c will have to do for now. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Aug 07 17:54:04 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 17:54:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k46Z9-0000v2-Hq; Fri, 07 Aug 2020 17:54:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k46Z8-0000ux-AW for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 17:54:02 +0000 X-Inumbo-ID: 44207fe7-28eb-420d-9be1-f51a810eab98 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 44207fe7-28eb-420d-9be1-f51a810eab98; Fri, 07 Aug 2020 17:54:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596822841; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=iD617Y6OVoROGJrkQRY9v/hlsFrigV94JtMP9NuHCvI=; b=fwkG5I6mnuTGykbQ9PyCbMZs4sFup9TGticFlP9k94NSI34VhLLPESii zccgXJwNTBUiJ6ne4tqkQAZm0wu/qworVTMgZ2eLS87gdcAzzqVVfHzp+ ElfkLZhpGnObHSiwaCkFjbA2YuvnCD05iO9YwfA4tI8Rjb5SRDBc8ICKo M=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: qbVREyPxdTMHWS4OYhkrlBB8iXSdsAwKaqB77aYthwjcwveIAGYNhkdWUmYljsuxCzG7i67yca 2K6jGy/ExXYt9er851wyViNH4HwZYx42iDll9usL4nDG///8LYjMQYjEKZvZ4Ap2P/RPci8Aaz o2jyr8hYVYb0U602nnOakPceSwpz2FPKM6zJJM5iP9B/dDn+8KJxw+przWvUYKCcOM3eYBxKZm kMo2IqaiBmlLgoY6DDJ2xm3wz07woH0cj7dONptuLXHwAyTFv2VNIkY5k5GmRyYPWKo1Lu5kk7 /QM= X-SBRS: 2.7 X-MesageID: 24257184 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,446,1589256000"; d="scan'208";a="24257184" Subject: Re: [PATCH v2 5/7] x86: move domain_cpu_policy_changed() To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <3a8356a9-313c-6de8-f409-977eae1fbfa5@suse.com> From: Andrew Cooper Message-ID: <1c8be060-bbbb-b41e-23d9-a665561d6988@citrix.com> Date: Fri, 7 Aug 2020 18:53:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 07/08/2020 12:34, Jan Beulich wrote: > This is in preparation of making the building of domctl.c conditional. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Fri Aug 07 17:55:45 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 17:55:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k46am-00011n-2t; Fri, 07 Aug 2020 17:55:44 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k46ak-00011f-S6 for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 17:55:42 +0000 X-Inumbo-ID: 1b06ae9d-bddd-429e-85f7-b0430542ab50 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1b06ae9d-bddd-429e-85f7-b0430542ab50; Fri, 07 Aug 2020 17:55:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596822941; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=maXFjAVsA9odGgKp4lfxSgc/MADSKx+Y4l1fhazwDV8=; b=XywZMHhGZzOvBNOV+ozvnycgkflUzEFpvYZPA8QmZ71fpOV/bCJddqNx D8vgc31K/AKp/krr365cVGwXj9XkX1Zqp3fxkVrfjNe8EmT26um0GODZ6 Lp1Q+nWbj+l5o3p7mLBFtgjTbVVF9aLDAMV8yTderdplCa35w2iPtoAL9 I=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: qoO1xcrbRBTvjYT3SumY5p2CmGelmu4Uew+Xo+6rU3700qYQv2TMNsFlEh8EHzG71kdlQPdOBi yL2cZGkJ8zEJXR4CmdBVUEZ6IJ8E+aFqFdSQcGeTaT3ceg0UYYHyb0VaDmewPIgHWciAnY8d0b 5C9gNxjs3w97LTpfn/MRr+teuhNEavBopPhugouF88esLudOfVJhrL3m/3J+ut6A2AlaCCX1ms rtWuAkvYH0AFIphA1T+ulijg4UH+3GGuidpZw/QVJGqsGlr7SgTz/JSidenNPZCuKSyQ/CPsdx tlQ= X-SBRS: 2.7 X-MesageID: 24257257 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,446,1589256000"; d="scan'208";a="24257257" Subject: Re: [PATCH v2 6/7] x86: move cpu_{up,down}_helper() To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <3a8356a9-313c-6de8-f409-977eae1fbfa5@suse.com> From: Andrew Cooper Message-ID: Date: Fri, 7 Aug 2020 18:55:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 07/08/2020 12:34, Jan Beulich wrote: > This is in preparation of making the building of sysctl.c conditional. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Fri Aug 07 18:01:21 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 18:01:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k46g7-0001yB-Oz; Fri, 07 Aug 2020 18:01:15 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k46g6-0001y5-2G for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 18:01:14 +0000 X-Inumbo-ID: 3a68d5d5-f24f-4d6b-8d32-54046412860b Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3a68d5d5-f24f-4d6b-8d32-54046412860b; Fri, 07 Aug 2020 18:01:13 +0000 (UTC) Subject: Re: [GIT PULL] xen: branch for v5.9-rc1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596823272; bh=0ehE2VzF4nqUoT893BcZnKAU1i5Tq0u904T1d7kqRSU=; h=From:In-Reply-To:References:Date:To:Cc:From; b=P6BaZgiTal2HNlPXJYTR/I4aNG23E6QrY1C3ZtZGtEpbXnGTFbDeMkxruyaWUx1sR O3eMd0E099Q9ila7AS8vihT8eyJronZoUpSYxz6vKEBKIwqF4B0w514j5BHV3nLTDF tf9t4fFY8IoGQpThjruhJxRdprODIUCv4sRbQfmg= From: pr-tracker-bot@kernel.org In-Reply-To: <20200807050450.7517-1-jgross@suse.com> References: <20200807050450.7517-1-jgross@suse.com> X-PR-Tracked-List-Id: Xen developer discussion X-PR-Tracked-Message-Id: <20200807050450.7517-1-jgross@suse.com> X-PR-Tracked-Remote: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.9-rc1-tag X-PR-Tracked-Commit-Id: d7b461caa6cc64dd190577b46b0ec892a8d5e7c0 X-PR-Merge-Tree: torvalds/linux.git X-PR-Merge-Refname: refs/heads/master X-PR-Merge-Commit-Id: e51418191f5a741b5f94764798c81bf69dec4806 Message-Id: <159682327228.30890.17036828138503121566.pr-tracker-bot@kernel.org> Date: Fri, 07 Aug 2020 18:01:12 +0000 To: Juergen Gross X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" The pull request you sent on Fri, 7 Aug 2020 07:04:50 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.9-rc1-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/e51418191f5a741b5f94764798c81bf69dec4806 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html From xen-devel-bounces@lists.xenproject.org Fri Aug 07 18:03:52 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 18:03:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k46ie-00026u-84; Fri, 07 Aug 2020 18:03:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k46ic-00026U-3y for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 18:03:50 +0000 X-Inumbo-ID: 8b476be4-d640-452d-bdf0-66675a0c203a Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8b476be4-d640-452d-bdf0-66675a0c203a; Fri, 07 Aug 2020 18:03:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=KNM/UA6Q666YHRxHHpsqc2zsP8SPbrZHsjJkVfOEwMw=; b=bqbqJoWWJdRTkEBc1pFAcBy2W 1ndWKiJiip1QlbtmZaYqHJ2rLzhBp705k5NPrbebVqev9mAFpcwHxCm6/A0LE1PrnCF4iKx4knEMD A2E14kSHi61srzlnNChZQLiqIYKs0YneKn8aYUzQi+oeL3gkBVEUs6k+aWbMC/E3XyKGI=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k46iU-0007mj-FS; Fri, 07 Aug 2020 18:03:42 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k46iT-0003tC-W4; Fri, 07 Aug 2020 18:03:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k46iT-0005y5-VP; Fri, 07 Aug 2020 18:03:41 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 152505: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-boot:fail:regression linux-linus:test-amd64-i386-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-i386-libvirt:xen-boot:fail:regression linux-linus:test-amd64-i386-examine:reboot:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-boot:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-xl:xen-boot:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-boot:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:build-arm64-pvops:kernel-build:fail:regression linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking X-Osstest-Versions-This: linux=bfdd5aaa54b0a44d9df550fe4c9db7e1470a11b8 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Fri, 07 Aug 2020 18:03:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152505 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/152505/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-boot/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-boot/dst_host fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-examine 8 reboot fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-boot/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-boot/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-boot fail REGR. vs. 152332 build-arm64-pvops 6 kernel-build fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail like 152332 test-armhf-armhf-xl-rtds 16 guest-start/debian.repeat fail like 152332 test-armhf-armhf-libvirt 14 saverestore-support-check fail like 152332 test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail like 152332 test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass version targeted for testing: linux bfdd5aaa54b0a44d9df550fe4c9db7e1470a11b8 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 6 days Failing since 152366 2020-08-01 20:49:34 Z 5 days 6 attempts Testing same since 152505 2020-08-06 19:41:56 Z 0 days 1 attempts ------------------------------------------------------------ 1470 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 169225 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Aug 07 18:22:54 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 18:22:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k470u-0003ro-Uu; Fri, 07 Aug 2020 18:22:44 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k470u-0003rj-6i for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 18:22:44 +0000 X-Inumbo-ID: c2036141-5803-4be7-9ca0-92d2ce9a077a Received: from mail2.protonmail.ch (unknown [185.70.40.22]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c2036141-5803-4be7-9ca0-92d2ce9a077a; Fri, 07 Aug 2020 18:22:41 +0000 (UTC) Date: Fri, 07 Aug 2020 18:22:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trmm.net; s=protonmail; t=1596824560; bh=mWuowmtVHupWq5n0J2fbIRjJDLNlHQjQNXMUB8Hgh2U=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=qF7p/RWxNknRFlOPEoAIAMhmrmqzJlZIkjpHwb9252ja1mJkPZowWh8M8zdzfQ59h UF9RUhWVR5zCp0sY5uSHhBGpWd3g3SkuH/Utf11DQpvidKQ2+AN3Xm8JLTBs2ERs8D rdXtTrn9RW/tBjUVU04DYaqdr1i5L+pyOinJipoI= To: Andrew Cooper From: Trammell Hudson Subject: Re: [RFC] efi/boot: Unified Xen executable for UEFI Secure Boot support Message-ID: In-Reply-To: <132b5b88-c78d-01cf-df27-6430689570e4@citrix.com> References: <1bd2d79e-5bef-835c-f6cc-9fd367e8beb7@suse.com> <5e3b16b3-0f93-4683-dcc7-852c805870c8@suse.com> <132b5b88-c78d-01cf-df27-6430689570e4@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: Trammell Hudson Cc: Juergen Gross , "xen-devel@lists.xenproject.org" , Boris Ostrovsky , Jan Beulich Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Thursday, August 6, 2020 8:14 PM, Andrew Cooper wrote: > For SecureBoot, it is important that nothing which is signed can be > tricked into running unsigned code. > > That includes configuration such as xen.cfg or the command line. > Consuming these from unsigned sources is ok, so long as we can guarantee > that the parsing is robust (see boothole for how this goes wrong), and > the effects are controlled. In addition to the "unsafe_fsgsbase", the Linux command line is full of potential issues, from subtle ones like "lockdown=3Dnone" to more brute force things like "init=3D/bin/sh". safeboot uses the signed kernel command line to pass in the root hash of the dm-verity Merkle tree, which cryptographically protects the rest of the runtime, so it definitely needs to come from a trusted source. > [...] > In the absence of a full audit of all our command line arguments, and > extra vigilance reviewing code coming in, the safer alternative is to > prohibit use of the command line, and only accept it in its Kconfig > embedded form for now. Turning off command line or config parsing might be a step too far. Since the xen.cfg in the unified image is included in the signature, any options configured in it should be trustworthy. This makes it easier for distributions to have a Xen build with boot-time work arounds for different hardware or configurations. > [...] > I think it might be worth having a CONFIG_SECURE_BOOT, selectable > initially only under CONFIG_EXPERT, and use it to force off various > other aspects of functionality, along with a list of known issues which > can be chipped away at before it can be declared supported. That makes sense to me. Either doing it at compile time (by making CONFIG_LIVEPATCH and CONFIG_KEXEC and etc depend on !CONFIG_SECURE_BOOT), or having a global variable that turns off the code (similar to the Linux lockdown patches that are triggered if UEFI secure boot is enabled). > [...] > I think it is great that work is being started in this direction, but > there is a huge quantity of work to do before a downstream could > plausibly put together a Xen system which honours the intent of SecureBoo= t. I'm really worried that the current shim based approach is a false sense of security -- it provides trivial ways for attackers to bypass the SecureBoot guarantees, so closing some of those easy holes with the verified unified image is definitely an incremental improvement towards a more secure system. However, I also don't want the unified image patch to get bogged down while trying to pursue every UEFI SecureBoot(tm) related issue, so perhaps the patch series should be renamed to only focus on the unified build part, not the SecureBoot part. That way downstream distributions can use it to add the security features that they need (caveat lector), without necessarily depending on the strict UEFI compliance. -- Trammell From xen-devel-bounces@lists.xenproject.org Fri Aug 07 19:36:52 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 19:36:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k48AJ-0001SF-Tu; Fri, 07 Aug 2020 19:36:31 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k48AI-0001Ru-Ag for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 19:36:30 +0000 X-Inumbo-ID: 26a4b76b-339e-4466-bdf6-bb851ba2d46b Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 26a4b76b-339e-4466-bdf6-bb851ba2d46b; Fri, 07 Aug 2020 19:36:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Lsxnf6EbTRVC/vcZ0p4MuG+LUGoBKLkHXP/GQPSnZiE=; b=wsM6pdD2Jtkd96vGmukpPn9VS t5sTQwmmzfYApKKQ9XqkA43DIbJXmBrplnHuVRkd7h3eXxLKQOwd/vpdHyEc8KiBeXip9s9KlGB5j /NpiiMbcnWKnyBiA70xjIP4rBxO509Oo6Kzst6BSJRXcrfpjgt3lv0Jn6i+cjwWTNUACw=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k48AB-0001OU-RO; Fri, 07 Aug 2020 19:36:23 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k48AB-0007Zg-Hd; Fri, 07 Aug 2020 19:36:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k48AB-0000km-Ge; Fri, 07 Aug 2020 19:36:23 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 152532: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=90c7eee53fcc0b48bd51aa3a7d1d0d9980ce1a7a X-Osstest-Versions-That: xen=16dcc135e89663628ee2eaf2d02991fc9ce954bf From: osstest service owner Date: Fri, 07 Aug 2020 19:36:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152532 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/152532/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass version targeted for testing: xen 90c7eee53fcc0b48bd51aa3a7d1d0d9980ce1a7a baseline version: xen 16dcc135e89663628ee2eaf2d02991fc9ce954bf Last test of basis 152524 2020-08-07 12:02:32 Z 0 days Testing same since 152532 2020-08-07 17:04:43 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 16dcc135e8..90c7eee53f 90c7eee53fcc0b48bd51aa3a7d1d0d9980ce1a7a -> smoke From xen-devel-bounces@lists.xenproject.org Fri Aug 07 21:51:08 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 21:51:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4AGH-0004kC-4G; Fri, 07 Aug 2020 21:50:49 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4AGG-0004k7-Ca for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 21:50:48 +0000 X-Inumbo-ID: 45022f6d-0751-4755-b529-ea264dbe6131 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 45022f6d-0751-4755-b529-ea264dbe6131; Fri, 07 Aug 2020 21:50:46 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 084392177B; Fri, 7 Aug 2020 21:50:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596837045; bh=d8HaMhlTaGM01v77iK+nJX2tQA+46Ioxn1SY+g1hQcw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Zm/4TetZWuR2g+Ua9OGU61GhTPMowUQXuPQMp7n45X3abkUGCoivS6sSv1N1jSE95 BmNT8rRiXOBVCc+WzfJaTlrY+CbBts4WAeYo5SG4VFz2flUZ8ktAlLinPfVAVKn5zZ /0BrT+GCvyoRl1li3PbiApdx9OHa3mQaEWs5quXc= Date: Fri, 7 Aug 2020 14:50:44 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Oleksandr Subject: Re: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common In-Reply-To: <013b142d-5296-5bbe-7d19-903f59e0c974@gmail.com> Message-ID: References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-2-git-send-email-olekstysh@gmail.com> <000c01d66a33$2bd56510$83802f30$@xen.org> <9f83a7ed-ca97-449f-c7b9-a1140644abe9@gmail.com> <2ab4c567-8efa-1b9d-ab00-4ea7e1ab323e@suse.com> <013b142d-5296-5bbe-7d19-903f59e0c974@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: 'Kevin Tian' , Stefano Stabellini , Julien Grall , 'Jun Nakajima' , 'Wei Liu' , paul@xen.org, 'Andrew Cooper' , 'Ian Jackson' , 'George Dunlap' , 'Tim Deegan' , 'Oleksandr Tyshchenko' , 'Julien Grall' , Jan Beulich , xen-devel@lists.xenproject.org, =?UTF-8?Q?'Roger_Pau_Monn=C3=A9'?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Fri, 7 Aug 2020, Oleksandr wrote: > On 06.08.20 03:37, Stefano Stabellini wrote: > > Hi Stefano > > Trying to simulate IO_RETRY handling mechanism (according to model below) I > continuously get IO_RETRY from try_fwd_ioserv() ... > > > OK, thanks for the details. My interpretation seems to be correct. > > > > In which case, it looks like xen/arch/arm/io.c:try_fwd_ioserv should > > return IO_RETRY. Then, xen/arch/arm/traps.c:do_trap_stage2_abort_guest > > also needs to handle try_handle_mmio returning IO_RETRY the first > > around, and IO_HANDLED when after QEMU does its job. > > > > What should do_trap_stage2_abort_guest do on IO_RETRY? Simply return > > early and let the scheduler do its job? Something like: > > > > enum io_state state = try_handle_mmio(regs, hsr, gpa); > > > > switch ( state ) > > { > > case IO_ABORT: > > goto inject_abt; > > case IO_HANDLED: > > advance_pc(regs, hsr); > > return; > > case IO_RETRY: > > /* finish later */ > > return; > > case IO_UNHANDLED: > > /* IO unhandled, try another way to handle it. */ > > break; > > default: > > ASSERT_UNREACHABLE(); > > } > > > > Then, xen/arch/arm/ioreq.c:handle_mmio() gets called by > > handle_hvm_io_completion() after QEMU completes the emulation. Today, > > handle_mmio just sets the user register with the read value. > > > > But it would be better if it called again the original function > > do_trap_stage2_abort_guest to actually retry the original operation. > > This time do_trap_stage2_abort_guest calls try_handle_mmio() and gets > > IO_HANDLED instead of IO_RETRY, > I may miss some important point, but I failed to see why try_handle_mmio > (try_fwd_ioserv) will return IO_HANDLED instead of IO_RETRY at this stage. > Or current try_fwd_ioserv() logic needs rework? I think you should check the ioreq->state in try_fwd_ioserv(), if the result is ready, then ioreq->state should be STATE_IORESP_READY, and you can return IO_HANDLED. That is assuming that you are looking at the live version of the ioreq shared with QEMU instead of a private copy of it, which I am not sure. Looking at try_fwd_ioserv() it would seem that vio->io_req is just a copy? The live version is returned by get_ioreq() ? Even in handle_hvm_io_completion, instead of setting vio->io_req.state to STATE_IORESP_READY by hand, it would be better to look at the live version of the ioreq because QEMU will have already set ioreq->state to STATE_IORESP_READY (hw/i386/xen/xen-hvm.c:cpu_handle_ioreq). > > thus, it will advance_pc (the program > > counter) completing the handling of this instruction. > > > > The user register with the read value could be set by try_handle_mmio if > > try_fwd_ioserv returns IO_HANDLED instead of IO_RETRY. > > > > Is that how the state machine is expected to work? From xen-devel-bounces@lists.xenproject.org Fri Aug 07 21:51:09 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 21:51:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4AGR-0004ke-Cr; Fri, 07 Aug 2020 21:50:59 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4AGQ-0004kZ-EI for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 21:50:58 +0000 X-Inumbo-ID: ffb5e211-c1d8-426a-9af0-6e8b40d0b556 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ffb5e211-c1d8-426a-9af0-6e8b40d0b556; Fri, 07 Aug 2020 21:50:57 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3742B2177B; Fri, 7 Aug 2020 21:50:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596837056; bh=CG9QwhsLJfw504BN17t/b6iO0h5SQDJspA7AuuEQLzE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=h7kqbL5Y5/HQcE/JUcQ320EUR2zVtfQQjXwZXHyGFzmg8VqZgbuoXUU7rZwm3Bu3Z wJUtq78ZjrKyN7vYfoN6y7suSCmz3kcptDBqm6PC9sBhdM2h+/vIpcgI3Vg7vq4Mdd KKc9YAkATqT2L/+E/C+vG0e0onh93BsnczQ6NfUs= Date: Fri, 7 Aug 2020 14:50:55 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Jan Beulich Subject: Re: [RFC PATCH V1 05/12] hvm/dm: Introduce xendevicemodel_set_irq_level DM op In-Reply-To: Message-ID: References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-6-git-send-email-olekstysh@gmail.com> <00e261e0-295a-9cd8-ed11-7e3801a4eb58@xen.org> <92e2b136-8468-2877-0e8c-c13ff2a0a1fb@xen.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Oleksandr Tyshchenko , Julien Grall , xen-devel@lists.xenproject.org, Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Fri, 7 Aug 2020, Jan Beulich wrote: > On 07.08.2020 01:49, Stefano Stabellini wrote: > > On Thu, 6 Aug 2020, Julien Grall wrote: > >> On 06/08/2020 01:37, Stefano Stabellini wrote: > >>> On Wed, 5 Aug 2020, Julien Grall wrote: > >>>> On 05/08/2020 00:22, Stefano Stabellini wrote: > >>>>> On Mon, 3 Aug 2020, Oleksandr Tyshchenko wrote: > >>>>>> From: Oleksandr Tyshchenko > >>>>>> > >>>>>> This patch adds ability to the device emulator to notify otherend > >>>>>> (some entity running in the guest) using a SPI and implements Arm > >>>>>> specific bits for it. Proposed interface allows emulator to set > >>>>>> the logical level of a one of a domain's IRQ lines. > >>>>>> > >>>>>> Please note, this is a split/cleanup of Julien's PoC: > >>>>>> "Add support for Guest IO forwarding to a device emulator" > >>>>>> > >>>>>> Signed-off-by: Julien Grall > >>>>>> Signed-off-by: Oleksandr Tyshchenko > >>>>>> --- > >>>>>> tools/libs/devicemodel/core.c | 18 > >>>>>> ++++++++++++++++++ > >>>>>> tools/libs/devicemodel/include/xendevicemodel.h | 4 ++++ > >>>>>> tools/libs/devicemodel/libxendevicemodel.map | 1 + > >>>>>> xen/arch/arm/dm.c | 22 > >>>>>> +++++++++++++++++++++- > >>>>>> xen/common/hvm/dm.c | 1 + > >>>>>> xen/include/public/hvm/dm_op.h | 15 > >>>>>> +++++++++++++++ > >>>>>> 6 files changed, 60 insertions(+), 1 deletion(-) > >>>>>> > >>>>>> diff --git a/tools/libs/devicemodel/core.c > >>>>>> b/tools/libs/devicemodel/core.c > >>>>>> index 4d40639..30bd79f 100644 > >>>>>> --- a/tools/libs/devicemodel/core.c > >>>>>> +++ b/tools/libs/devicemodel/core.c > >>>>>> @@ -430,6 +430,24 @@ int xendevicemodel_set_isa_irq_level( > >>>>>> return xendevicemodel_op(dmod, domid, 1, &op, sizeof(op)); > >>>>>> } > >>>>>> +int xendevicemodel_set_irq_level( > >>>>>> + xendevicemodel_handle *dmod, domid_t domid, uint32_t irq, > >>>>>> + unsigned int level) > >>>>> > >>>>> It is a pity that having xen_dm_op_set_pci_intx_level and > >>>>> xen_dm_op_set_isa_irq_level already we need to add a third one, but from > >>>>> the names alone I don't think we can reuse either of them. > >>>> > >>>> The problem is not the name... > >>>> > >>>>> > >>>>> It is very similar to set_isa_irq_level. We could almost rename > >>>>> xendevicemodel_set_isa_irq_level to xendevicemodel_set_irq_level or, > >>>>> better, just add an alias to it so that xendevicemodel_set_irq_level is > >>>>> implemented by calling xendevicemodel_set_isa_irq_level. Honestly I am > >>>>> not sure if it is worth doing it though. Any other opinions? > >>>> > >>>> ... the problem is the interrupt field is only 8-bit. So we would only be > >>>> able > >>>> to cover IRQ 0 - 255. > >>> > >>> Argh, that's not going to work :-( I wasn't sure if it was a good idea > >>> anyway. > >>> > >>> > >>>> It is not entirely clear how the existing subop could be extended without > >>>> breaking existing callers. > >>>> > >>>>> But I think we should plan for not needing two calls (one to set level > >>>>> to 1, and one to set it to 0): > >>>>> https://marc.info/?l=xen-devel&m=159535112027405 > >>>> > >>>> I am not sure to understand your suggestion here? Are you suggesting to > >>>> remove > >>>> the 'level' parameter? > >>> > >>> My hope was to make it optional to call the hypercall with level = 0, > >>> not necessarily to remove 'level' from the struct. > >> > >> From my understanding, the hypercall is meant to represent the status of the > >> line between the device and the interrupt controller (either low or high). > >> > >> This is then up to the interrupt controller to decide when the interrupt is > >> going to be fired: > >> - For edge interrupt, this will fire when the line move from low to high (or > >> vice versa). > >> - For level interrupt, this will fire when line is high (assuming level > >> trigger high) and will keeping firing until the device decided to lower the > >> line. > >> > >> For a device, it is common to keep the line high until an OS wrote to a > >> specific register. > >> > >> Furthermore, technically, the guest OS is in charge to configure how an > >> interrupt is triggered. Admittely this information is part of the DT, but > >> nothing prevent a guest to change it. > >> > >> As side note, we have a workaround in Xen for some buggy DT (see the arch > >> timer) exposing the wrong trigger type. > >> > >> Because of that, I don't really see a way to make optional. Maybe you have > >> something different in mind? > > > > For level, we need the level parameter. For edge, we are only interested > > in the "edge", right? > > I don't think so, unless Arm has special restrictions. Edges can be > both rising and falling ones. And the same is true for level interrupts too: they could be active-low or active-high. Instead of modelling the state of the line, which seems to be a bit error prone especially in the case of a single-device emulator that might not have enough information about the rest of the system (it might not know if the interrupt is active-high or active-low), we could model the triggering of the interrupt instead. In the case of level=1, it would mean that the interrupt line is active, no matter if it is active-low or active-high. In the case of level=0, it would mean that it is inactive. Similarly, in the case of an edge interrupt edge=1 or level=1 would mean that there is an edge, no matter if it is a rising or falling. From xen-devel-bounces@lists.xenproject.org Fri Aug 07 21:51:14 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 21:51:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4AGg-0004nO-LS; Fri, 07 Aug 2020 21:51:14 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4AGf-0004n5-3R for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 21:51:13 +0000 X-Inumbo-ID: 7fae22d1-4225-4835-b1c8-1287742aeb5b Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7fae22d1-4225-4835-b1c8-1287742aeb5b; Fri, 07 Aug 2020 21:51:12 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 43BA32177B; Fri, 7 Aug 2020 21:51:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596837071; bh=BS4dpglETiiSLoYi4FTffbo0X4N/96tbX+74HErGi20=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=k4cfZ2rm8/F/isH3OXkB2W9ohWhkTMVtgic98icawn1kFHg/k8MxO9iloO49A5Ehk vk1NIUVa/YQs/yIp3YhBdehR5c9BMUDnRr4IGgPfm39Ylw6BVCWFtMrAsEHYuxzb3p g1IPttt9MKU4GTSpbqmYn+e3JG5k1Uckbat5N3hc= Date: Fri, 7 Aug 2020 14:51:10 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Jan Beulich Subject: Re: [PATCH 00/14] kernel-doc: public/arch-arm.h In-Reply-To: <7923d0f4-a446-c852-5423-0fe65ef27a41@suse.com> Message-ID: References: <7923d0f4-a446-c852-5423-0fe65ef27a41@suse.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , julien@xen.org, wl@xen.org, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com, xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Fri, 7 Aug 2020, Jan Beulich wrote: > On 07.08.2020 01:49, Stefano Stabellini wrote: > > # THE KERNEL-DOC KEYWORDS USED > > > > I used the "struct" keyword for structures, i.e.: > > > > /** > > * struct foobar > > */ > > > > "struct" makes kernel-doc go and look at the following struct in the > > code, parses struct members comments, and generate a doc optimized to > > describe a struct. Note that in these cases the struct needs to follow > > immediately the comment. Thus, I had to move an #define between the > > comment and the struct in a few places. > > > > Also note that kernel-doc supports nested structs but due to a quirk, > > comments for nested struct members cannot be on a single line. They have > > to be: > > > > struct foo { > > struct { > > /** > > * @u.bar: foobar > > */ > > bar; > > } u; > > } > > Urgh. > > > Otherwise for normal struct the single line comment works fine: > > > > struct foo { > > /** @bar: foobar */ > > bar; > > } > > > > > > I used the "DOC" keyword otherwise. "DOC" is freeform, not particularly > > tied to anything following (functions, enums, etc.) I kept a black line > > between "DOC" and the following comment if multiline and no blank line > > if it is single line. > > > > /** > > * DOC: doc1 > > * single line comment > > */ > > > > /** > > * DOC: doc2 > > * > > * this is > > * multiline > > */ > > I think before the first piece of this goes in (or together with it > going in), ./CODING_STYLE wants to be updated to reflect this. It is > particularly relevant imo to mention the quirk above and hence the > necessary exception (even better of course would be to get the quirk > out of kernel-doc). Yes, I can add a patch to change ./CODING_STYLE. I think we should encourage people to use the kernel-doc syntax at least for public headers. I can document the use of the "struct" and "DOC" keywords, and also the quirk with nested structs. Note that instead the black line after DOC is completely optional from a kernel-doc perspective, I did it for style, but I can add that to ./CODING_STYLE too. From xen-devel-bounces@lists.xenproject.org Fri Aug 07 21:51:20 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 21:51:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4AGl-0004ob-UU; Fri, 07 Aug 2020 21:51:19 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4AGl-0004oT-9P for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 21:51:19 +0000 X-Inumbo-ID: cd8d72f7-e89e-4ee6-b779-2a814443e982 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cd8d72f7-e89e-4ee6-b779-2a814443e982; Fri, 07 Aug 2020 21:51:18 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9CAB42177B; Fri, 7 Aug 2020 21:51:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596837078; bh=ZJMzXL8ZeHi2wRlmaD0+M0EXul71j0VOol4lp0yDtag=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=w0xRorkbbrOg/VIHJu50jnmvv6vVtrAV2H2Jgv3vK1wy/l4UBWTT3ns7rRzBAD+yn D8/rtNSbLXM7mDkBHhWkp/+gd74g0smaa/m94pMNFwiLVLR0mS6cpe1+3vHuZpWDFC dX/nsjihi490B/SQrIe2b2oOGkmpUBHU6EJWDrIc= Date: Fri, 7 Aug 2020 14:51:17 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Jan Beulich Subject: Re: [PATCH 04/14] kernel-doc: public/event_channel.h In-Reply-To: <57b251fc-8997-48b8-693c-08e38d643fc3@suse.com> Message-ID: References: <20200806234933.16448-4-sstabellini@kernel.org> <57b251fc-8997-48b8-693c-08e38d643fc3@suse.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , julien@xen.org, wl@xen.org, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com, xen-devel@lists.xenproject.org, Stefano Stabellini Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Fri, 7 Aug 2020, Jan Beulich wrote: > On 07.08.2020 01:49, Stefano Stabellini wrote: > > @@ -137,65 +147,78 @@ typedef struct evtchn_bind_interdomain evtchn_bind_interdomain_t; > > * binding cannot be changed. > > */ > > struct evtchn_bind_virq { > > - /* IN parameters. */ > > - uint32_t virq; /* enum virq */ > > + /** @virq: IN parameter, enum virq */ > > + uint32_t virq; > > + /** @vcpu: IN parameter */ > > uint32_t vcpu; > > - /* OUT parameters. */ > > + /** @port: OUT parameter */ > > evtchn_port_t port; > > }; > > typedef struct evtchn_bind_virq evtchn_bind_virq_t; > > > > -/* > > - * EVTCHNOP_bind_pirq: Bind a local event channel to a real IRQ (PIRQ ). > > +/** > > + * struct evtchn_bind_pirq - EVTCHNOP_bind_pirq > > + * > > + * Bind a local event channel to a real IRQ (PIRQ ). > > * NOTES: > > * 1. A physical IRQ may be bound to at most one event channel per domain. > > * 2. Only a sufficiently-privileged domain may bind to a physical IRQ. > > */ > > struct evtchn_bind_pirq { > > - /* IN parameters. */ > > + /** @pirq: IN parameter */ > > uint32_t pirq; > > + /** @flags: IN parameter, BIND_PIRQ__* */ > > #define BIND_PIRQ__WILL_SHARE 1 > > - uint32_t flags; /* BIND_PIRQ__* */ > > - /* OUT parameters. */ > > + uint32_t flags; > > + /** @port: OUT parameter */ > > evtchn_port_t port; > > }; > > typedef struct evtchn_bind_pirq evtchn_bind_pirq_t; > > > > -/* > > - * EVTCHNOP_bind_ipi: Bind a local event channel to receive events. > > +/** > > + * struct struct evtchn_bind_ipi - EVTCHNOP_bind_ipi > > + * > > + * Bind a local event channel to receive events. > > * NOTES: > > * 1. The allocated event channel is bound to the specified vcpu. The binding > > * may not be changed. > > */ > > struct evtchn_bind_ipi { > > + /** @vcpu: IN parameter */ > > uint32_t vcpu; > > - /* OUT parameters. */ > > + /** @port: OUT parameter */ > > evtchn_port_t port; > > }; > > typedef struct evtchn_bind_ipi evtchn_bind_ipi_t; > > > > -/* > > - * EVTCHNOP_close: Close a local event channel . If the channel is > > - * interdomain then the remote end is placed in the unbound state > > +/** > > + * struct evtchn_close - EVTCHNOP_close > > + * > > + * Close a local event channel . If the channel is interdomain > > + * then the remote end is placed in the unbound state > > * (EVTCHNSTAT_unbound), awaiting a new connection. > > */ > > struct evtchn_close { > > - /* IN parameters. */ > > + /** @port: IN parameter */ > > evtchn_port_t port; > > }; > > typedef struct evtchn_close evtchn_close_t; > > > > -/* > > - * EVTCHNOP_send: Send an event to the remote end of the channel whose local > > - * endpoint is . > > +/** > > + * struct evtchn_send - EVTCHNOP_send > > + * > > + * Send an event to the remote end of the channel whose local endpoint > > + * is . > > */ > > struct evtchn_send { > > - /* IN parameters. */ > > + /** @port: IN parameter */ > > evtchn_port_t port; > > }; > > typedef struct evtchn_send evtchn_send_t; > > > > -/* > > +/** > > + * struct evtchn_status - EVTCHNOP_status > > + * > > * EVTCHNOP_status: Get the current status of the communication channel which > > * has an endpoint at . > > * NOTES: > > Nit: I guess you meant to remove the "EVTCHNOP_status: " prefix from > the original comment, like is done elsewhere? Yes, good catch, I'll change it. From xen-devel-bounces@lists.xenproject.org Fri Aug 07 21:51:25 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 21:51:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4AGr-0004qk-Bn; Fri, 07 Aug 2020 21:51:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4AGq-0004oT-87 for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 21:51:24 +0000 X-Inumbo-ID: 2a5d4289-be0b-4f9c-a8d4-18ae226fc777 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2a5d4289-be0b-4f9c-a8d4-18ae226fc777; Fri, 07 Aug 2020 21:51:23 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 37A672177B; Fri, 7 Aug 2020 21:51:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596837082; bh=edsL0bKqr3nBRy1G7eK+IKPYfybxuQ1GO7oH2i5QL78=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=L7zkJkO7oUgV4cye17F96WTiGzg/d0kf52jGlUd85je+9D12obGUau1D4Qw+z6zn2 PhsQubBqojOZUV9feK+FQR5Um5vxlDaPQwFJSWRKr92PMwtBfX2fLTXXs8UhkABHSg bVryj9Kjq0H/tzBPwf6vfs2fr3dWkK710XuI+ry0= Date: Fri, 7 Aug 2020 14:51:21 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Jan Beulich Subject: Re: [PATCH 11/14] kernel-doc: public/version.h In-Reply-To: Message-ID: References: <20200806234933.16448-11-sstabellini@kernel.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , julien@xen.org, wl@xen.org, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com, xen-devel@lists.xenproject.org, Stefano Stabellini Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Fri, 7 Aug 2020, Jan Beulich wrote: > On 07.08.2020 01:49, Stefano Stabellini wrote: > > --- a/xen/include/public/version.h > > +++ b/xen/include/public/version.h > > @@ -30,19 +30,33 @@ > > > > #include "xen.h" > > > > -/* NB. All ops return zero on success, except XENVER_{version,pagesize} > > - * XENVER_{version,pagesize,build_id} */ > > +/** > > + * DOC: XENVER_* > > + * > > + * NB. All ops return zero on success, except for: > > + * > > + * - XENVER_{version,pagesize} > > + * - XENVER_{version,pagesize,build_id} > > You make the mistake made by 460d24188d81 even more obvious, instead of > fixing it (by removing the first of these two lines). Ops, I have been too mechanic in these transformations :-) I can fix it. From xen-devel-bounces@lists.xenproject.org Fri Aug 07 21:51:41 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 21:51:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4AH7-0004wJ-LT; Fri, 07 Aug 2020 21:51:41 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4AH6-0004vg-Ak for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 21:51:40 +0000 X-Inumbo-ID: feecf013-7a49-4498-a040-f30b92ad38a0 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id feecf013-7a49-4498-a040-f30b92ad38a0; Fri, 07 Aug 2020 21:51:39 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2BE232224D; Fri, 7 Aug 2020 21:51:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596837098; bh=omEu2n5h0G8ePh6GhttUk/F2l7a9JCfDphcbEaPW80M=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=c08Dr5Myy0DMhAqbumcuIiViBd3yj5u1OgvWS2RTXsI9/9djra425bTgbZ5pd1veX r2e5rgq5/IXklacjFxCMyF4iSKkLm+6ekEnMeg+snG6gaJ0tNqVvB1YjyUAizZW8kS AVaaCFYu8sdPW2x31cQeK9eTA1kJ5fgcpowJQ5lg= Date: Fri, 7 Aug 2020 14:51:37 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Jan Beulich Subject: Re: [PATCH 08/14] kernel-doc: public/memory.h In-Reply-To: <5567ef5a-35c4-6dd8-38f5-348c7c3713b1@suse.com> Message-ID: References: <20200806234933.16448-8-sstabellini@kernel.org> <5567ef5a-35c4-6dd8-38f5-348c7c3713b1@suse.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , julien@xen.org, wl@xen.org, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com, xen-devel@lists.xenproject.org, Stefano Stabellini Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Fri, 7 Aug 2020, Jan Beulich wrote: > On 07.08.2020 01:49, Stefano Stabellini wrote: > > From: Stefano Stabellini > > > > Convert in-code comments to kernel-doc format wherever possible. > > > > Signed-off-by: Stefano Stabellini > > --- > > xen/include/public/memory.h | 232 ++++++++++++++++++++++++------------ > > 1 file changed, 155 insertions(+), 77 deletions(-) > > > > diff --git a/xen/include/public/memory.h b/xen/include/public/memory.h > > index 21057ed78e..4c57ed213c 100644 > > --- a/xen/include/public/memory.h > > +++ b/xen/include/public/memory.h > > @@ -30,7 +30,9 @@ > > #include "xen.h" > > #include "physdev.h" > > > > -/* > > +/** > > + * DOC: XENMEM_increase_reservation and XENMEM_decrease_reservation > > + * > > * Increase or decrease the specified domain's memory reservation. Returns the > > * number of extents successfully allocated or freed. > > * arg == addr of struct xen_memory_reservation. > > @@ -40,29 +42,37 @@ > > #define XENMEM_populate_physmap 6 > > > > #if __XEN_INTERFACE_VERSION__ >= 0x00030209 > > -/* > > - * Maximum # bits addressable by the user of the allocated region (e.g., I/O > > - * devices often have a 32-bit limitation even in 64-bit systems). If zero > > - * then the user has no addressing restriction. This field is not used by > > - * XENMEM_decrease_reservation. > > +/** > > + * DOC: XENMEMF_* > > + * > > + * - XENMEMF_address_bits, XENMEMF_get_address_bits: > > + * Maximum # bits addressable by the user of the allocated region > > + * (e.g., I/O devices often have a 32-bit limitation even in 64-bit > > + * systems). If zero then the user has no addressing restriction. This > > + * field is not used by XENMEM_decrease_reservation. > > + * - XENMEMF_node, XENMEMF_get_node: NUMA node to allocate from > > + * - XENMEMF_populate_on_demand: Flag to populate physmap with populate-on-demand entries > > + * - XENMEMF_exact_node_request, XENMEMF_exact_node: Flag to request allocation only from the node specified > > Nit: overly long line I'll fix > > + * - XENMEMF_vnode: Flag to indicate the node specified is virtual node > > */ > > #define XENMEMF_address_bits(x) (x) > > #define XENMEMF_get_address_bits(x) ((x) & 0xffu) > > -/* NUMA node to allocate from. */ > > #define XENMEMF_node(x) (((x) + 1) << 8) > > #define XENMEMF_get_node(x) ((((x) >> 8) - 1) & 0xffu) > > -/* Flag to populate physmap with populate-on-demand entries */ > > #define XENMEMF_populate_on_demand (1<<16) > > -/* Flag to request allocation only from the node specified */ > > #define XENMEMF_exact_node_request (1<<17) > > #define XENMEMF_exact_node(n) (XENMEMF_node(n) | XENMEMF_exact_node_request) > > -/* Flag to indicate the node specified is virtual node */ > > #define XENMEMF_vnode (1<<18) > > #endif > > > > +/** > > + * struct xen_memory_reservation > > + */ > > struct xen_memory_reservation { > > > > - /* > > + /** > > + * @extent_start: > > + * > > Take the opportunity and drop the stray blank line? Sure > > @@ -200,90 +236,115 @@ DEFINE_XEN_GUEST_HANDLE(xen_machphys_mfn_list_t); > > */ > > #define XENMEM_machphys_compat_mfn_list 25 > > > > -/* > > +#define XENMEM_machphys_mapping 12 > > +/** > > + * struct xen_machphys_mapping - XENMEM_machphys_mapping > > + * > > * Returns the location in virtual address space of the machine_to_phys > > * mapping table. Architectures which do not have a m2p table, or which do not > > * map it by default into guest address space, do not implement this command. > > * arg == addr of xen_machphys_mapping_t. > > */ > > -#define XENMEM_machphys_mapping 12 > > struct xen_machphys_mapping { > > + /** @v_start: Start virtual address */ > > xen_ulong_t v_start, v_end; /* Start and end virtual addresses. */ > > - xen_ulong_t max_mfn; /* Maximum MFN that can be looked up. */ > > + /** @v_end: End virtual addresses */ > > + xen_ulong_t v_end; > > + /** @max_mfn: Maximum MFN that can be looked up */ > > + xen_ulong_t max_mfn; > > }; > > typedef struct xen_machphys_mapping xen_machphys_mapping_t; > > DEFINE_XEN_GUEST_HANDLE(xen_machphys_mapping_t); > > > > -/* Source mapping space. */ > > +/** > > + * DOC: Source mapping space. > > + * > > + * - XENMAPSPACE_shared_info: shared info page > > + * - XENMAPSPACE_grant_table: grant table page > > + * - XENMAPSPACE_gmfn: GMFN > > + * - XENMAPSPACE_gmfn_range: GMFN range, XENMEM_add_to_physmap only. > > + * - XENMAPSPACE_gmfn_foreign: GMFN from another dom, > > + * XENMEM_add_to_physmap_batch only. > > + * - XENMAPSPACE_dev_mmio: device mmio region ARM only; the region is mapped > > + * in Stage-2 using the Normal MemoryInner/Outer > > + * Write-Back Cacheable memory attribute. > > + */ > > /* ` enum phys_map_space { */ > > Isn't this and ... > > > -#define XENMAPSPACE_shared_info 0 /* shared info page */ > > -#define XENMAPSPACE_grant_table 1 /* grant table page */ > > -#define XENMAPSPACE_gmfn 2 /* GMFN */ > > -#define XENMAPSPACE_gmfn_range 3 /* GMFN range, XENMEM_add_to_physmap only. */ > > -#define XENMAPSPACE_gmfn_foreign 4 /* GMFN from another dom, > > - * XENMEM_add_to_physmap_batch only. */ > > -#define XENMAPSPACE_dev_mmio 5 /* device mmio region > > - ARM only; the region is mapped in > > - Stage-2 using the Normal Memory > > - Inner/Outer Write-Back Cacheable > > - memory attribute. */ > > +#define XENMAPSPACE_shared_info 0 > > +#define XENMAPSPACE_grant_table 1 > > +#define XENMAPSPACE_gmfn 2 > > +#define XENMAPSPACE_gmfn_range 3 > > +#define XENMAPSPACE_gmfn_foreign 4 > > +#define XENMAPSPACE_dev_mmio 5 > > /* ` } */ > > ... this also something that wants converting? For clarity, I take you are talking about these two enum-related comments: /* ` enum phys_map_space { */ [... various #defines ... ] /* ` } */ Is this something we want to convert to kernel-doc? I don't know. I couldn't see an obvious value in doing it, in the sense that it doesn't necessarely make things clearer. I took a second look at the header and the following would work: /** * DOC: Source mapping space. * * enum phys_map_space { * * - XENMAPSPACE_shared_info: shared info page * - XENMAPSPACE_grant_table: grant table page * - XENMAPSPACE_gmfn: GMFN * - XENMAPSPACE_gmfn_range: GMFN range, XENMEM_add_to_physmap only. * - XENMAPSPACE_gmfn_foreign: GMFN from another dom, * XENMEM_add_to_physmap_batch only. * - XENMAPSPACE_dev_mmio: device mmio region ARM only; the region is mapped * in Stage-2 using the Normal MemoryInner/Outer * Write-Back Cacheable memory attribute. * } */ Note the blank line after "enum phys_map_space {" is required. All in all I am in favor of *not* converting the enum comment to kernel-doc, but I'd be OK with it anyway. From xen-devel-bounces@lists.xenproject.org Fri Aug 07 21:51:47 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 21:51:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4AHC-0004yk-Ux; Fri, 07 Aug 2020 21:51:46 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4AHA-0004xs-VJ for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 21:51:44 +0000 X-Inumbo-ID: f0f5f576-1ed4-42f1-9e15-95ddc937d1f7 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f0f5f576-1ed4-42f1-9e15-95ddc937d1f7; Fri, 07 Aug 2020 21:51:44 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 85B952224D; Fri, 7 Aug 2020 21:51:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596837103; bh=KL5rEqFnEXUZReoD4jjORNAHEdWDvjcsM6jX9HnzfFw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=W80mn6hGXSPcT81WDJfdirbEwUpa+PUIwskFtCbuNBGi9DUyYCIZw9WCpdTMwW8DJ sLk4xsbdHaV38b7KN2LV/dZXB82w/bCuFLM5wHiupIKQTLR0EsjLEFizmi20sxh5/k r/D69RLHXX6KctPUGbfaAAS3zd2PpL21GMjj7n6I= Date: Fri, 7 Aug 2020 14:51:43 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Jan Beulich Subject: Re: [PATCH 06/14] kernel-doc: public/grant_table.h In-Reply-To: <5a4d6a81-bc8f-3d00-f760-d39023711dbc@suse.com> Message-ID: References: <20200806234933.16448-6-sstabellini@kernel.org> <5a4d6a81-bc8f-3d00-f760-d39023711dbc@suse.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , julien@xen.org, wl@xen.org, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com, xen-devel@lists.xenproject.org, Stefano Stabellini Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Fri, 7 Aug 2020, Jan Beulich wrote: > On 07.08.2020 01:49, Stefano Stabellini wrote: > > @@ -108,56 +107,66 @@ > > * Use SMP-safe bit-setting instruction. > > */ > > > > -/* > > +/** > > + * typedef > > * Reference to a grant entry in a specified domain's grant table. > > */ > > typedef uint32_t grant_ref_t; > > In the comment, did you mean grant_ref_t? Yes, I'll fix it. > > -/* > > +/** > > + * DOC: grant table > > + * > > * A grant table comprises a packed array of grant entries in one or more > > * page frames shared between Xen and a guest. > > * [XEN]: This field is written by Xen and read by the sharing guest. > > * [GST]: This field is written by the guest and read by Xen. > > */ > > > > -/* > > - * Version 1 of the grant table entry structure is maintained purely > > - * for backwards compatibility. New guests should use version 2. > > - */ > > #if __XEN_INTERFACE_VERSION__ < 0x0003020a > > #define grant_entry_v1 grant_entry > > #define grant_entry_v1_t grant_entry_t > > #endif > > +/** > > + * struct grant_entry_v1 > > + * > > + * Version 1 of the grant table entry structure is maintained purely > > + * for backwards compatibility. New guests should use version 2. > > + */ > > I realize content changes aren't intended, but here I can't resist > recommending to drop the second sentence at this occasion. OK > > +/** > > + * DOC: Values for error status returns. All errors are -ve. > > + * > > + * > > + * - GNTST_okay: Normal return. > > Nit: Why two blank comment lines above? A small mistake, I'll fix it. From xen-devel-bounces@lists.xenproject.org Fri Aug 07 21:52:05 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 21:52:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4AHV-000559-9N; Fri, 07 Aug 2020 21:52:05 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4AHU-00054h-AP for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 21:52:04 +0000 X-Inumbo-ID: 05c2fdcc-573e-4e6d-88de-06190720877f Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 05c2fdcc-573e-4e6d-88de-06190720877f; Fri, 07 Aug 2020 21:52:02 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 100F52177B; Fri, 7 Aug 2020 21:52:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596837121; bh=2o2xY2k+5MnqEGwKfJYGxIBlc1BP9NxLYYu/963VmbQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=pC91Jx16bOLDNj5f3WTHyJP/698eodVxY3fk7/B8+vNH5WPD1m0vScDSo6pe7LgQ8 vzrdJGt89OnDM28NFwLA+qf/Niyg1pEq1QhlJ5YFcv6UuCXSNLi55Qj6C0KdUXZbvG zo+6oMr5xmbwz1AehTa5LLCj5h1wH8HUolguIVCA= Date: Fri, 7 Aug 2020 14:52:00 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Jan Beulich Subject: Re: [PATCH 05/14] kernel-doc: public/features.h In-Reply-To: Message-ID: References: <20200806234933.16448-5-sstabellini@kernel.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , julien@xen.org, wl@xen.org, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com, xen-devel@lists.xenproject.org, Stefano Stabellini Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Fri, 7 Aug 2020, Jan Beulich wrote: > On 07.08.2020 01:49, Stefano Stabellini wrote: > > @@ -41,19 +41,25 @@ > > * XENFEAT_dom0 MUST be set if the guest is to be booted as dom0, > > */ > > > > -/* > > - * If set, the guest does not need to write-protect its pagetables, and can > > - * update them via direct writes. > > +/** > > + * DOC: XENFEAT_writable_page_tables > > + * > > + * If set, the guest does not need to write-protect its pagetables, and > > + * can update them via direct writes. > > */ > > #define XENFEAT_writable_page_tables 0 > > I dislike such redundancy (and it's more noticable here than with > the struct-s). Is there really no way for the tool to find the > right item, the more that in the cover letter you say that you > even need to get the placement right, i.e. there can't be e.g. > intervening #define-s? Let me clarify that the right placement (nothing between the comment and the following structure) is important for structs, typedefs, etc., but not for "DOC". DOC is freeform and doesn't have to be followed by anything specifically. In regards to the redundancy, there is only another option, that I didn't choose because it leads to worse documents being generated. However, they are still readable, so if the agreement is to use the other format, I would be OK with it. The other format is the keyword "macro" (this one would have to have the right placement, straight on top of the #define): /** * macro XENFEAT_writable_page_tables * * If set, the guest does not need to write-protect its pagetables, and * can update them via direct writes. */ Which could be further simplified to: /** * macro * * If set, the guest does not need to write-protect its pagetables, and * can update them via direct writes. */ In terms of redundancy, that's the best we can do. The reason why I say it is not optimal is that with DOC the pleudo-html generated via sphinx is: --- * XENFEAT_writable_page_tables * If set, the guest does not need to write-protect its pagetables, and can update them via direct writes. --- While with macro, two () parenthesis gets added to the title, and also an empty "Parameters" section gets added, like this: --- * XENFEAT_writable_page_tables() * ** Parameters ** ** Description ** If set, the guest does not need to write-protect its pagetables, and can update them via direct writes. --- I think it could be confusing to the user: it looks like a macro with parameters, which is not what we want. For that reason, I think we should stick with "DOC" for now. From xen-devel-bounces@lists.xenproject.org Fri Aug 07 22:19:16 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 22:19:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4Ahh-0007La-UU; Fri, 07 Aug 2020 22:19:09 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4Ahg-0007LT-EF for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 22:19:08 +0000 X-Inumbo-ID: 284a3f31-97a4-4ed2-b3a5-c49f995fcda9 Received: from mail-lj1-x244.google.com (unknown [2a00:1450:4864:20::244]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 284a3f31-97a4-4ed2-b3a5-c49f995fcda9; Fri, 07 Aug 2020 22:19:07 +0000 (UTC) Received: by mail-lj1-x244.google.com with SMTP id z14so3782585ljm.1 for ; Fri, 07 Aug 2020 15:19:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=kj4Bm7zVW/G9YqXBxFTfDMQ1Hf0mmGOOW4bVv9Zf+rU=; b=H4b6LI2upQmf7gF/zfst/s6b7W3sbHGR0CI81Qfutl3T4ayiOOU7tPzDF102t3waf3 oPwlnc5XQIWklh0W4P4R08U3VG0tXqL9olZQQ0LxNjdD7wBBrwirG0FMFMQkvXn9zPxJ 8SS1R2q5rH1gVy3PlptmUNU3AIbHwXCGuqr+6NBYVAIdDO893NkXlmEDOPT16jJmU7zX Gs8Wv78eajDOZG3nzOP/QVBFVtX9+nx7PTC4eC4ooLMokPbaqoGtbkodDHWtRg9ujoqd rVhx6+46hULAzH9w8BP/ag90GJI3Cqdd7AMIymKSd4pcv1sCcla1j5K5LFGs2BkLfhou Ubmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=kj4Bm7zVW/G9YqXBxFTfDMQ1Hf0mmGOOW4bVv9Zf+rU=; b=KnvrWhLpjCECE308BT2k32Ilp6yjYM6yFa77Y0Jc3jFuOudNAyUsy08CA8KvOS07bg q+4O3ELt1olg7oE+J0fH/pgdAPpr3vs2dNYv1nBlVzJzizMiLwJV30/OXirLUeloyMG3 lGEZyIAbbjAuAUI6TQzAQijMFcr32cknJKfpyjAQkfucKZhFZKuCfYS/oT/b0AxPue2S QMTxyNkAHPnrzam/obZ2f7BXUUO4tiZnVa2yYqnErobL8P6TPzJ8tWHVVJe5lSz2My43 fE/2ZpoMbo6RFjpB7qBXLXvOiYVHwlbj/4o4aWKVWa3ay5+0waNiPdwiZbdu9LTaPtJa JFsw== X-Gm-Message-State: AOAM533XK6cmz3sx0+tcd87k9xAKOzRO+zVtXSA0aAMq2XQqMbNpMjmL 3+LtQToQLcUHi92nBnQHOhg= X-Google-Smtp-Source: ABdhPJxgEB9BFCLKt0ZaVMBqxEgnqk5i7MFsZ211f4+LpjvjkG+xNiZS+99oxE4r1FCD7OfBpzqaEA== X-Received: by 2002:a2e:9c86:: with SMTP id x6mr6961727lji.346.1596838745819; Fri, 07 Aug 2020 15:19:05 -0700 (PDT) Received: from [192.168.1.2] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id g24sm4298490ljl.139.2020.08.07.15.19.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Aug 2020 15:19:05 -0700 (PDT) Subject: Re: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common To: Stefano Stabellini References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-2-git-send-email-olekstysh@gmail.com> <000c01d66a33$2bd56510$83802f30$@xen.org> <9f83a7ed-ca97-449f-c7b9-a1140644abe9@gmail.com> <2ab4c567-8efa-1b9d-ab00-4ea7e1ab323e@suse.com> <013b142d-5296-5bbe-7d19-903f59e0c974@gmail.com> From: Oleksandr Message-ID: <06f78323-b8f5-fd11-486a-437267eccc29@gmail.com> Date: Sat, 8 Aug 2020 01:19:03 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: 'Kevin Tian' , Julien Grall , 'Jun Nakajima' , 'Wei Liu' , paul@xen.org, 'Andrew Cooper' , 'Ian Jackson' , 'George Dunlap' , 'Tim Deegan' , 'Oleksandr Tyshchenko' , 'Julien Grall' , Jan Beulich , xen-devel@lists.xenproject.org, =?UTF-8?B?J1JvZ2VyIFBhdSBNb25uw6kn?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 08.08.20 00:50, Stefano Stabellini wrote: Hi Stefano > On Fri, 7 Aug 2020, Oleksandr wrote: >> On 06.08.20 03:37, Stefano Stabellini wrote: >> >> Hi Stefano >> >> Trying to simulate IO_RETRY handling mechanism (according to model below) I >> continuously get IO_RETRY from try_fwd_ioserv() ... >> >>> OK, thanks for the details. My interpretation seems to be correct. >>> >>> In which case, it looks like xen/arch/arm/io.c:try_fwd_ioserv should >>> return IO_RETRY. Then, xen/arch/arm/traps.c:do_trap_stage2_abort_guest >>> also needs to handle try_handle_mmio returning IO_RETRY the first >>> around, and IO_HANDLED when after QEMU does its job. >>> >>> What should do_trap_stage2_abort_guest do on IO_RETRY? Simply return >>> early and let the scheduler do its job? Something like: >>> >>> enum io_state state = try_handle_mmio(regs, hsr, gpa); >>> >>> switch ( state ) >>> { >>> case IO_ABORT: >>> goto inject_abt; >>> case IO_HANDLED: >>> advance_pc(regs, hsr); >>> return; >>> case IO_RETRY: >>> /* finish later */ >>> return; >>> case IO_UNHANDLED: >>> /* IO unhandled, try another way to handle it. */ >>> break; >>> default: >>> ASSERT_UNREACHABLE(); >>> } >>> >>> Then, xen/arch/arm/ioreq.c:handle_mmio() gets called by >>> handle_hvm_io_completion() after QEMU completes the emulation. Today, >>> handle_mmio just sets the user register with the read value. >>> >>> But it would be better if it called again the original function >>> do_trap_stage2_abort_guest to actually retry the original operation. >>> This time do_trap_stage2_abort_guest calls try_handle_mmio() and gets >>> IO_HANDLED instead of IO_RETRY, >> I may miss some important point, but I failed to see why try_handle_mmio >> (try_fwd_ioserv) will return IO_HANDLED instead of IO_RETRY at this stage. >> Or current try_fwd_ioserv() logic needs rework? > I think you should check the ioreq->state in try_fwd_ioserv(), if the > result is ready, then ioreq->state should be STATE_IORESP_READY, and you > can return IO_HANDLED. Indeed! Just coming to this opinion I saw your answer) This is a dirty test patch: ---  xen/arch/arm/io.c               | 12 ++++++++++++  xen/arch/arm/ioreq.c            | 12 ++++++++++++  xen/arch/arm/traps.c            |  6 ++++--  xen/include/asm-arm/hvm/ioreq.h |  2 ++  xen/include/asm-arm/traps.h     |  3 +++  5 files changed, 33 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c index 436f669..65a08f8 100644 --- a/xen/arch/arm/io.c +++ b/xen/arch/arm/io.c @@ -130,6 +130,10 @@ static enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,      {      case STATE_IOREQ_NONE:          break; + +    case STATE_IORESP_READY: +        return IO_HANDLED; +      default:          printk("d%u wrong state %u\n", v->domain->domain_id,                 vio->io_req.state); @@ -156,9 +160,11 @@ static enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,      else          vio->io_completion = HVMIO_mmio_completion; +#if 0      /* XXX: Decide what to do */      if ( rc == IO_RETRY )          rc = IO_HANDLED; +#endif      return rc;  } @@ -185,6 +191,12 @@ enum io_state try_handle_mmio(struct cpu_user_regs *regs,  #ifdef CONFIG_IOREQ_SERVER          rc = try_fwd_ioserv(regs, v, &info); +        if ( rc == IO_HANDLED ) +        { +            printk("HANDLED %s[%d]\n", __func__, __LINE__); +            handle_mmio_finish(); +        } else +            printk("RETRY %s[%d]\n", __func__, __LINE__);  #endif          return rc; diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c index 8f60c41..c8ed454 100644 --- a/xen/arch/arm/ioreq.c +++ b/xen/arch/arm/ioreq.c @@ -33,8 +33,20 @@  #include  #include +#include +  bool handle_mmio(void)  { +    struct cpu_user_regs *regs = guest_cpu_user_regs(); +    const union hsr hsr = { .bits = regs->hsr }; + +    do_trap_stage2_abort_guest(regs, hsr); + +    return true; +} + +bool handle_mmio_finish(void) +{      struct vcpu *v = current;      struct cpu_user_regs *regs = guest_cpu_user_regs();      const union hsr hsr = { .bits = regs->hsr }; diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index ea472d1..3493d77 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -1882,7 +1882,7 @@ static bool try_map_mmio(gfn_t gfn)      return !map_regions_p2mt(d, gfn, 1, mfn, p2m_mmio_direct_c);  } -static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs, +void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,                                         const union hsr hsr)  {      /* @@ -1965,11 +1965,13 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,              case IO_HANDLED:                  advance_pc(regs, hsr);                  return; +            case IO_RETRY: +                /* finish later */ +                return;              case IO_UNHANDLED:                  /* IO unhandled, try another way to handle it. */                  break;              default: -                /* XXX: Handle IO_RETRY */                  ASSERT_UNREACHABLE();              }          } diff --git a/xen/include/asm-arm/hvm/ioreq.h b/xen/include/asm-arm/hvm/ioreq.h index 392ce64..fb4684d 100644 --- a/xen/include/asm-arm/hvm/ioreq.h +++ b/xen/include/asm-arm/hvm/ioreq.h @@ -27,6 +27,8 @@  bool handle_mmio(void); +bool handle_mmio_finish(void); +  static inline bool handle_pio(uint16_t port, unsigned int size, int dir)  {      /* XXX */ diff --git a/xen/include/asm-arm/traps.h b/xen/include/asm-arm/traps.h index 997c378..392fdb1 100644 --- a/xen/include/asm-arm/traps.h +++ b/xen/include/asm-arm/traps.h @@ -40,6 +40,9 @@ void advance_pc(struct cpu_user_regs *regs, const union hsr hsr);  void inject_undef_exception(struct cpu_user_regs *regs, const union hsr hsr); +void do_trap_stage2_abort_guest(struct cpu_user_regs *regs, +                                        const union hsr hsr); +  /* read as zero and write ignore */  void handle_raz_wi(struct cpu_user_regs *regs, int regidx, bool read,                     const union hsr hsr, int min_el); -- 2.7.4 > > That is assuming that you are looking at the live version of the ioreq > shared with QEMU instead of a private copy of it, which I am not sure. > Looking at try_fwd_ioserv() it would seem that vio->io_req is just a > copy? The live version is returned by get_ioreq() ? > > Even in handle_hvm_io_completion, instead of setting vio->io_req.state > to STATE_IORESP_READY by hand, it would be better to look at the live > version of the ioreq because QEMU will have already set ioreq->state > to STATE_IORESP_READY (hw/i386/xen/xen-hvm.c:cpu_handle_ioreq). I need to recheck that. Thank you. -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Fri Aug 07 23:45:38 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2020 23:45:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4C2z-000745-GW; Fri, 07 Aug 2020 23:45:13 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4C2y-000740-9N for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 23:45:12 +0000 X-Inumbo-ID: f8dc32a9-9fa5-484b-b7a9-4751a7c1e700 Received: from mail-lf1-x144.google.com (unknown [2a00:1450:4864:20::144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f8dc32a9-9fa5-484b-b7a9-4751a7c1e700; Fri, 07 Aug 2020 23:45:11 +0000 (UTC) Received: by mail-lf1-x144.google.com with SMTP id h8so1834498lfp.9 for ; Fri, 07 Aug 2020 16:45:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=/DvT9xa8toEseeHzoJwpWlVyvQeSAfvo/Pdjio7ZUHo=; b=TRk1K5rTfN3WTqw7I9O08Ep5Yb08hOBYekkD6qLJIRCIyLnzQW29UMpkjU751YxW1N KLP2f79jgfxjqNx0wo1tTJ1envrH+cE5+Oaq1Md42cXR7SzvDyt+GDiIQiUbKCsX5pV2 QgKDYum5MYd/3oaj82C0k3G9GTELN7Skawkz0hXnu/hUj1Dh6nNfgh7T5zXMtzeVZzCb feKZJ18rXgmVqfPDDADPyhwh6xVs6yULkeGdLle6yZ4QZOeCCI+Bggc7chx4cYveTAYE kB8bTWfP25+JT/MNdeYjwS5UbatiRSPoHUxmeGFQ3d/9BcWSYJDpfzBESOQvwBnUVLXl UHqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=/DvT9xa8toEseeHzoJwpWlVyvQeSAfvo/Pdjio7ZUHo=; b=GPhE3VMJZAavHFQhX1WixHpz63DUd5OL2r72MamBaFzlWVA8py5V2Ea6Nyg+rNwzlg xRWPhBfa3BEmWLdEwY5ftsbrYM61fh4MybjVy6mrI4sx2Qe41Kr6txqQjWD4Bk3gQuTz bwBV6bR+GUo/F5a7KJTmWo8Rc1Pw0vQVTvn3FzDnITFtlzq0tgosTD432YUSPjYToOy4 v7UuOHNiZ7gseyB1AuAHqx+BleAHGfnIqZTC4iI4kpzITJf+EDd5jWfZ/dtsBb0mKfTs 3G1VIRjPO3rLQnU49qJjZlUZTDON9DNVIwQEPPZcGzRVcWPXCpTWiRIkZL4WwWrV6PW3 5mkQ== X-Gm-Message-State: AOAM531cd2VgFO9OWvJ6shhqPo5i1b/BhALI1ysWnSNx0lcxv/ZPHN6P Il3xmu27MdYk8g+oKhvj6BU= X-Google-Smtp-Source: ABdhPJyvjoFf7UPJOZrqQkzqOQbQA2Is69QLebe6zjCOg3y15r5kBkOQz4J/k0430iZyH7agJ3rAOQ== X-Received: by 2002:a19:3c7:: with SMTP id 190mr7456986lfd.14.1596843909932; Fri, 07 Aug 2020 16:45:09 -0700 (PDT) Received: from [192.168.1.2] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id g24sm4364133ljl.139.2020.08.07.16.45.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Aug 2020 16:45:09 -0700 (PDT) Subject: Re: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common To: Stefano Stabellini References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-2-git-send-email-olekstysh@gmail.com> <000c01d66a33$2bd56510$83802f30$@xen.org> <9f83a7ed-ca97-449f-c7b9-a1140644abe9@gmail.com> <2ab4c567-8efa-1b9d-ab00-4ea7e1ab323e@suse.com> <013b142d-5296-5bbe-7d19-903f59e0c974@gmail.com> From: Oleksandr Message-ID: <910ec6ee-1076-2c9d-c01d-b6b4cc0bc6b8@gmail.com> Date: Sat, 8 Aug 2020 02:45:03 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: 'Kevin Tian' , Julien Grall , 'Jun Nakajima' , 'Wei Liu' , paul@xen.org, 'Andrew Cooper' , 'Ian Jackson' , 'George Dunlap' , 'Tim Deegan' , 'Oleksandr Tyshchenko' , 'Julien Grall' , Jan Beulich , xen-devel@lists.xenproject.org, =?UTF-8?B?J1JvZ2VyIFBhdSBNb25uw6kn?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 08.08.20 00:50, Stefano Stabellini wrote: Hi > On Fri, 7 Aug 2020, Oleksandr wrote: >> On 06.08.20 03:37, Stefano Stabellini wrote: >> >> Hi Stefano >> >> Trying to simulate IO_RETRY handling mechanism (according to model below) I >> continuously get IO_RETRY from try_fwd_ioserv() ... >> >>> OK, thanks for the details. My interpretation seems to be correct. >>> >>> In which case, it looks like xen/arch/arm/io.c:try_fwd_ioserv should >>> return IO_RETRY. Then, xen/arch/arm/traps.c:do_trap_stage2_abort_guest >>> also needs to handle try_handle_mmio returning IO_RETRY the first >>> around, and IO_HANDLED when after QEMU does its job. >>> >>> What should do_trap_stage2_abort_guest do on IO_RETRY? Simply return >>> early and let the scheduler do its job? Something like: >>> >>> enum io_state state = try_handle_mmio(regs, hsr, gpa); >>> >>> switch ( state ) >>> { >>> case IO_ABORT: >>> goto inject_abt; >>> case IO_HANDLED: >>> advance_pc(regs, hsr); >>> return; >>> case IO_RETRY: >>> /* finish later */ >>> return; >>> case IO_UNHANDLED: >>> /* IO unhandled, try another way to handle it. */ >>> break; >>> default: >>> ASSERT_UNREACHABLE(); >>> } >>> >>> Then, xen/arch/arm/ioreq.c:handle_mmio() gets called by >>> handle_hvm_io_completion() after QEMU completes the emulation. Today, >>> handle_mmio just sets the user register with the read value. >>> >>> But it would be better if it called again the original function >>> do_trap_stage2_abort_guest to actually retry the original operation. >>> This time do_trap_stage2_abort_guest calls try_handle_mmio() and gets >>> IO_HANDLED instead of IO_RETRY, >> I may miss some important point, but I failed to see why try_handle_mmio >> (try_fwd_ioserv) will return IO_HANDLED instead of IO_RETRY at this stage. >> Or current try_fwd_ioserv() logic needs rework? > I think you should check the ioreq->state in try_fwd_ioserv(), if the > result is ready, then ioreq->state should be STATE_IORESP_READY, and you > can return IO_HANDLED. > > That is assuming that you are looking at the live version of the ioreq > shared with QEMU instead of a private copy of it, which I am not sure. > Looking at try_fwd_ioserv() it would seem that vio->io_req is just a > copy? The live version is returned by get_ioreq() ? If I understand the code correctly, indeed, get_ioreq() returns live version shared with emulator. Desired state change (STATE_IORESP_READY) what actually the hvm_wait_for_io() is waiting for is set here (in my case): https://xenbits.xen.org/gitweb/?p=people/pauldu/demu.git;a=blob;f=demu.c;h=f785b394d0cf141dffa05bdddecf338214358aea;hb=refs/heads/master#l698 > Even in handle_hvm_io_completion, instead of setting vio->io_req.state > to STATE_IORESP_READY by hand, it would be better to look at the live > version of the ioreq because QEMU will have already set ioreq->state > to STATE_IORESP_READY (hw/i386/xen/xen-hvm.c:cpu_handle_ioreq). It seems that after detecting STATE_IORESP_READY in hvm_wait_for_io() the state of live version is set to STATE_IOREQ_NONE immediately, so looking at the live version down the handle_hvm_io_completion() or in try_fwd_ioserv() shows us nothing I am afraid. -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Sat Aug 08 00:49:03 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 08 Aug 2020 00:49:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4D2J-0004PL-Q0; Sat, 08 Aug 2020 00:48:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4D2I-0004PG-3c for xen-devel@lists.xenproject.org; Sat, 08 Aug 2020 00:48:34 +0000 X-Inumbo-ID: 49428086-450e-4b52-baa2-94737807d055 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 49428086-450e-4b52-baa2-94737807d055; Sat, 08 Aug 2020 00:48:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=z45vHzJdu7o9VJgVd5brvZ2E/3Og8zrXUaFAMHZkpOE=; b=rpGb68sJfXjDTQ0Wuc0qlsAVa cKy9zVfKD1A+3yAZLRg+LetEQJZrA19jkN832XtryR498488bcok3fAB6LwjPoNULsotpg5wRxUou 9Jq+WzOoximQEVlp0xN4kFhzE21fHOM2V1/MdlaoGFBOmAeeGeuH8HJBi+a3GdvQqsfls=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4D2E-0000W0-Cd; Sat, 08 Aug 2020 00:48:30 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k4D2E-0006gl-3i; Sat, 08 Aug 2020 00:48:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k4D2E-0007Y9-1A; Sat, 08 Aug 2020 00:48:30 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 152511: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking X-Osstest-Versions-This: xen=b2bc1e714462c6cc222e3bbc38d87b039b4fa405 X-Osstest-Versions-That: xen=81fd0d3ca4b2cd309403c6e8da662c325dd35750 From: osstest service owner Date: Sat, 08 Aug 2020 00:48:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152511 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/152511/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail like 152418 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail like 152418 test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail like 152418 test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail like 152418 test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail like 152418 test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 152418 test-armhf-armhf-libvirt 14 saverestore-support-check fail like 152418 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail like 152418 test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail like 152418 test-amd64-i386-xl-pvshim 12 guest-start fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass version targeted for testing: xen b2bc1e714462c6cc222e3bbc38d87b039b4fa405 baseline version: xen 81fd0d3ca4b2cd309403c6e8da662c325dd35750 Last test of basis 152418 2020-08-03 11:11:04 Z 4 days Failing since 152461 2020-08-04 07:50:21 Z 3 days 4 attempts Testing same since 152498 2020-08-06 01:55:41 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Wei Liu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 81fd0d3ca4..b2bc1e7144 b2bc1e714462c6cc222e3bbc38d87b039b4fa405 -> master From xen-devel-bounces@lists.xenproject.org Sat Aug 08 01:43:27 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 08 Aug 2020 01:43:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4DtG-0006AP-1V; Sat, 08 Aug 2020 01:43:18 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4DtE-00069L-Ok for xen-devel@lists.xenproject.org; Sat, 08 Aug 2020 01:43:16 +0000 X-Inumbo-ID: 70b9fb96-013e-42b9-bd73-a94b1e93a8c6 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 70b9fb96-013e-42b9-bd73-a94b1e93a8c6; Sat, 08 Aug 2020 01:43:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=OJDg9UIP8k2FZhfj9exr9u/gH/2MOxyy7clgbA2nlhM=; b=M+9udQvxuyNiKdJU7kcXlq2HN /uUH6AR1OZmuBLsYpEu1HmLT7pCiIDLTB5Njx1A6M4bWNzrO9qe7kTwu3xRcaCBpGjAmfR/zNFRCA dHzHCQkUxMowvtZK1g7IfwLttll5dpzNboi2XGMF7aw6rWM9xFwvH9qkBqIm6U2dhZCr0=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4Dt6-0006rp-Ck; Sat, 08 Aug 2020 01:43:08 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k4Dt5-0000E3-Hg; Sat, 08 Aug 2020 01:43:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k4Dt5-0000AM-Ex; Sat, 08 Aug 2020 01:43:07 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 152514: tolerable FAIL - PUSHED X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking X-Osstest-Versions-This: linux=d9939285fc818425ae92bd99f8c97b6b9ef3bb88 X-Osstest-Versions-That: linux=1b940bbc5c55551a3420f403a2b10cb884cffb01 From: osstest service owner Date: Sat, 08 Aug 2020 01:43:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152514 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/152514/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 16 guest-start/debian.repeat fail REGR. vs. 152501 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-pvshim 12 guest-start fail never pass test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail never pass test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail never pass test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail never pass test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass version targeted for testing: linux d9939285fc818425ae92bd99f8c97b6b9ef3bb88 baseline version: linux 1b940bbc5c55551a3420f403a2b10cb884cffb01 Last test of basis 152501 2020-08-06 03:21:27 Z 1 days Testing same since 152514 2020-08-07 07:44:50 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alexei Starovoitov Daniel Borkmann Greg Kroah-Hartman Grygorii Strashko Guenter Roeck Jiang Ying Linus Torvalds Lorenz Bauer Marc Zyngier Shuah Khan Wang Long Willy Tarreau jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 1b940bbc5c55..d9939285fc81 d9939285fc818425ae92bd99f8c97b6b9ef3bb88 -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Sat Aug 08 05:44:47 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 08 Aug 2020 05:44:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4Hee-0001wV-SL; Sat, 08 Aug 2020 05:44:28 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4Hed-0001wQ-7v for xen-devel@lists.xenproject.org; Sat, 08 Aug 2020 05:44:27 +0000 X-Inumbo-ID: 776ce44f-1436-49e2-be04-9849543dc716 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 776ce44f-1436-49e2-be04-9849543dc716; Sat, 08 Aug 2020 05:44:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=9KHuZaekUynz024ICXxKhIJZYIwyz1T2q1uoYRpM/48=; b=TOTKzTbZMQZiLof0qEUVegnHm gRfUbFP41fCN1ct4X5Zgndzi0AsHsyuXF5FHYEYjxIvkACjJUBKZPygF8QmKBpYjfpvm/G2d+QjF8 txUOm9V6iFTk1M4hlnqDYgnRWQccB+NJO+anO7+gKn5P5EzvB/UJ1j/dfaEeOeKAO7ZEA=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4HeY-0004Xz-JH; Sat, 08 Aug 2020 05:44:22 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k4HeY-00042m-CE; Sat, 08 Aug 2020 05:44:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k4HeY-0002mk-Bc; Sat, 08 Aug 2020 05:44:22 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 152517: all pass - PUSHED X-Osstest-Versions-This: ovmf=9565ab67c2095a5ea893e63561a49aedf3387b8f X-Osstest-Versions-That: ovmf=8834e10b30125daa47da9f6c5c1a41b4eafbae7f From: osstest service owner Date: Sat, 08 Aug 2020 05:44:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152517 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/152517/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 9565ab67c2095a5ea893e63561a49aedf3387b8f baseline version: ovmf 8834e10b30125daa47da9f6c5c1a41b4eafbae7f Last test of basis 152504 2020-08-06 12:15:14 Z 1 days Testing same since 152517 2020-08-07 09:02:31 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Bob Feng Feng, Bob C Gao, Zhichao Laszlo Ersek Michael D Kinney Michael Kubacki Samer El-Haj-Mahmoud Zhichao Gao jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 8834e10b30..9565ab67c2 9565ab67c2095a5ea893e63561a49aedf3387b8f -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Aug 08 09:28:24 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 08 Aug 2020 09:28:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4L8t-0004Ck-Jh; Sat, 08 Aug 2020 09:27:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4L8s-0004Cf-Fr for xen-devel@lists.xenproject.org; Sat, 08 Aug 2020 09:27:54 +0000 X-Inumbo-ID: 031871fd-48f7-4811-8c24-e225470a8786 Received: from mail-wr1-x443.google.com (unknown [2a00:1450:4864:20::443]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 031871fd-48f7-4811-8c24-e225470a8786; Sat, 08 Aug 2020 09:27:53 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id l2so3737700wrc.7 for ; Sat, 08 Aug 2020 02:27:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ju3yrQZ0C1jwOZhE8FGnux8NGFbcKUy7GP+6ib/P3Kc=; b=bzpIOwx7Ehg1yiS5w71jAsJTQEbGkslshrb5+yA68wbm7MaPIS0dIMrFu4dVT+XNVz PnNY+xAzrphGUSxABu7YqkPzFG+E7bntRGlEjUjuskeDGIPOyysosMYL3BSqAnv0lKIO TfD3LlOjjqTbfIQiBxkVkoS31FgGUo320gKKHealciQgTI2xwToK6nEwsgtq9QkVk1IC yrbOe5RurM/39ooeu5XrYv8jAz23FvG1YMAJ0+1ZTri8H6wNfsWogr30bwXPZQiHe/xK OUWmRcF3LH4ViTL5iEDv9DAnJUohEnLBdQNySrTDetVf0cdBDZ+J6tPPlC0Q8AaLhWcN F3aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ju3yrQZ0C1jwOZhE8FGnux8NGFbcKUy7GP+6ib/P3Kc=; b=Kt29g0fP8NdFq1LFiVkLiJsNacCONpmWFz+m0pju3PLxR8SCABH8w8GgRA/Vbs+9hB PJzPPIwWEnvDvazepnW41e+uIueTh9PmMHBwu4JT9UvfBlSdAcIsX5XifWiYlO3SydF/ o0+JZOEnZmq0swBeBKj4WXtkBK/KPO+hNOqvHOD5pBnXxJDJVSEk4YynIBxEPkVlqDrk n0jh5+qeHwj2oRSFInGgoyYI/7XmeQxG3KxZwBQpxYXxXjD3wSllAt87ZmbcZycmnO2K jyDTdrEKymP0V0tvlP3VEuH8vOB7FLzm0W9EGZ402HKw3R/dcEMQw22+IlSQbzmluhSu TeGg== X-Gm-Message-State: AOAM530n8xPz3DSlLfVRPBpefBaF8pfH9pYYu2bpFLwCL/D7CvxQarix cZL4YzzRwEim1rmMjlig2zDEsfGitfoSWqpZJ9M= X-Google-Smtp-Source: ABdhPJxJ7os9jqo3lo/nNhaxlO/y9jQ20LSeqUNX7vobMskl1936iKRAa0YDth22YeiHT+GAA0cvTZp9ZyS9DINn0xU= X-Received: by 2002:a5d:43c4:: with SMTP id v4mr16377578wrr.426.1596878872101; Sat, 08 Aug 2020 02:27:52 -0700 (PDT) MIME-Version: 1.0 References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-6-git-send-email-olekstysh@gmail.com> <00e261e0-295a-9cd8-ed11-7e3801a4eb58@xen.org> <92e2b136-8468-2877-0e8c-c13ff2a0a1fb@xen.org> In-Reply-To: From: Julien Grall Date: Sat, 8 Aug 2020 10:27:40 +0100 Message-ID: Subject: Re: [RFC PATCH V1 05/12] hvm/dm: Introduce xendevicemodel_set_irq_level DM op To: Stefano Stabellini Content-Type: text/plain; charset="UTF-8" X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Oleksandr Tyshchenko , Julien Grall , Jan Beulich , xen-devel , Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Fri, 7 Aug 2020 at 22:51, Stefano Stabellini wrote: > > On Fri, 7 Aug 2020, Jan Beulich wrote: > > On 07.08.2020 01:49, Stefano Stabellini wrote: > > > On Thu, 6 Aug 2020, Julien Grall wrote: > > >> On 06/08/2020 01:37, Stefano Stabellini wrote: > > >>> On Wed, 5 Aug 2020, Julien Grall wrote: > > >>>> On 05/08/2020 00:22, Stefano Stabellini wrote: > > >>>>> On Mon, 3 Aug 2020, Oleksandr Tyshchenko wrote: > > >>>>>> From: Oleksandr Tyshchenko > > >>>>>> > > >>>>>> This patch adds ability to the device emulator to notify otherend > > >>>>>> (some entity running in the guest) using a SPI and implements Arm > > >>>>>> specific bits for it. Proposed interface allows emulator to set > > >>>>>> the logical level of a one of a domain's IRQ lines. > > >>>>>> > > >>>>>> Please note, this is a split/cleanup of Julien's PoC: > > >>>>>> "Add support for Guest IO forwarding to a device emulator" > > >>>>>> > > >>>>>> Signed-off-by: Julien Grall > > >>>>>> Signed-off-by: Oleksandr Tyshchenko > > >>>>>> --- > > >>>>>> tools/libs/devicemodel/core.c | 18 > > >>>>>> ++++++++++++++++++ > > >>>>>> tools/libs/devicemodel/include/xendevicemodel.h | 4 ++++ > > >>>>>> tools/libs/devicemodel/libxendevicemodel.map | 1 + > > >>>>>> xen/arch/arm/dm.c | 22 > > >>>>>> +++++++++++++++++++++- > > >>>>>> xen/common/hvm/dm.c | 1 + > > >>>>>> xen/include/public/hvm/dm_op.h | 15 > > >>>>>> +++++++++++++++ > > >>>>>> 6 files changed, 60 insertions(+), 1 deletion(-) > > >>>>>> > > >>>>>> diff --git a/tools/libs/devicemodel/core.c > > >>>>>> b/tools/libs/devicemodel/core.c > > >>>>>> index 4d40639..30bd79f 100644 > > >>>>>> --- a/tools/libs/devicemodel/core.c > > >>>>>> +++ b/tools/libs/devicemodel/core.c > > >>>>>> @@ -430,6 +430,24 @@ int xendevicemodel_set_isa_irq_level( > > >>>>>> return xendevicemodel_op(dmod, domid, 1, &op, sizeof(op)); > > >>>>>> } > > >>>>>> +int xendevicemodel_set_irq_level( > > >>>>>> + xendevicemodel_handle *dmod, domid_t domid, uint32_t irq, > > >>>>>> + unsigned int level) > > >>>>> > > >>>>> It is a pity that having xen_dm_op_set_pci_intx_level and > > >>>>> xen_dm_op_set_isa_irq_level already we need to add a third one, but from > > >>>>> the names alone I don't think we can reuse either of them. > > >>>> > > >>>> The problem is not the name... > > >>>> > > >>>>> > > >>>>> It is very similar to set_isa_irq_level. We could almost rename > > >>>>> xendevicemodel_set_isa_irq_level to xendevicemodel_set_irq_level or, > > >>>>> better, just add an alias to it so that xendevicemodel_set_irq_level is > > >>>>> implemented by calling xendevicemodel_set_isa_irq_level. Honestly I am > > >>>>> not sure if it is worth doing it though. Any other opinions? > > >>>> > > >>>> ... the problem is the interrupt field is only 8-bit. So we would only be > > >>>> able > > >>>> to cover IRQ 0 - 255. > > >>> > > >>> Argh, that's not going to work :-( I wasn't sure if it was a good idea > > >>> anyway. > > >>> > > >>> > > >>>> It is not entirely clear how the existing subop could be extended without > > >>>> breaking existing callers. > > >>>> > > >>>>> But I think we should plan for not needing two calls (one to set level > > >>>>> to 1, and one to set it to 0): > > >>>>> https://marc.info/?l=xen-devel&m=159535112027405 > > >>>> > > >>>> I am not sure to understand your suggestion here? Are you suggesting to > > >>>> remove > > >>>> the 'level' parameter? > > >>> > > >>> My hope was to make it optional to call the hypercall with level = 0, > > >>> not necessarily to remove 'level' from the struct. > > >> > > >> From my understanding, the hypercall is meant to represent the status of the > > >> line between the device and the interrupt controller (either low or high). > > >> > > >> This is then up to the interrupt controller to decide when the interrupt is > > >> going to be fired: > > >> - For edge interrupt, this will fire when the line move from low to high (or > > >> vice versa). > > >> - For level interrupt, this will fire when line is high (assuming level > > >> trigger high) and will keeping firing until the device decided to lower the > > >> line. > > >> > > >> For a device, it is common to keep the line high until an OS wrote to a > > >> specific register. > > >> > > >> Furthermore, technically, the guest OS is in charge to configure how an > > >> interrupt is triggered. Admittely this information is part of the DT, but > > >> nothing prevent a guest to change it. > > >> > > >> As side note, we have a workaround in Xen for some buggy DT (see the arch > > >> timer) exposing the wrong trigger type. > > >> > > >> Because of that, I don't really see a way to make optional. Maybe you have > > >> something different in mind? > > > > > > For level, we need the level parameter. For edge, we are only interested > > > in the "edge", right? > > > > I don't think so, unless Arm has special restrictions. Edges can be > > both rising and falling ones. > > And the same is true for level interrupts too: they could be active-low > or active-high. > > > Instead of modelling the state of the line, which seems to be a bit > error prone especially in the case of a single-device emulator that > might not have enough information about the rest of the system (it might > not know if the interrupt is active-high or active-low), we could model > the triggering of the interrupt instead. I am not sure to understand why the single (or event multiple) device emulator needs to know the trigger type. The information of the trigger type of the interrupt would be described in the firmware table and it is expected to be the same as what the emulator expects. If the guest OS decided to configure wrongly the interrupt trigger type, then it may not work properly. But, from my understanding, this doesn't differ from the HW behavior. > > In the case of level=1, it would mean that the interrupt line is active, > no matter if it is active-low or active-high. In the case of level=0, it > would mean that it is inactive. > > Similarly, in the case of an edge interrupt edge=1 or level=1 would mean > that there is an edge, no matter if it is rising or falling. TBH, I think your approach is only going to introduce more headache in Xen if a guest OS decides to change the trigger type. It feels much easier to just ask the emulator to let us know the level of the line. Then if the guest OS decides to change the trigger type, we only need to resample the line. Cheers, From xen-devel-bounces@lists.xenproject.org Sat Aug 08 09:29:04 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 08 Aug 2020 09:29:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4L9z-0004HJ-VB; Sat, 08 Aug 2020 09:29:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4L9y-0004HC-Ho for xen-devel@lists.xenproject.org; Sat, 08 Aug 2020 09:29:02 +0000 X-Inumbo-ID: ca6223c5-20e5-4a18-92cb-f10a2c4eabbb Received: from mail-wm1-x344.google.com (unknown [2a00:1450:4864:20::344]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ca6223c5-20e5-4a18-92cb-f10a2c4eabbb; Sat, 08 Aug 2020 09:29:01 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id 3so3951277wmi.1 for ; Sat, 08 Aug 2020 02:29:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=U6WzWpHmSqGqUrp2Pgfeis/uo0uwjwAVhwvkPXq5ats=; b=T7TZ1HJzKxSttopluJmiMP/sVZGRw38XxMJS8i+g7idKWjNm8R5VtT3B5konxXGBKN Vf7LPpGaU310x40n5R9qt+NDcz2zBe3mDn1llhKLA/JG+P5TQvw5kxTbmRAPpLK+MR6J D4tbZTYxQq+KZVczJnwwWFOHRZX88f//ZAI+0oHYVsl6ulRgOOyAqgeiwqPo10BSoXAt LE4GzlaShuFbuUSJV/8QiTk0U80ffZ6v1OgYr8mPr+hY5oqOS+XNixPVLZoW9c5Ob4II wPQqbs/sVCGicHMfOTLgvYRUKxkaORDifnrzxD7m34zyNpYRyKYCcDz6OpMLOHIBotAd BE+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=U6WzWpHmSqGqUrp2Pgfeis/uo0uwjwAVhwvkPXq5ats=; b=DNibVLv4xHleq/aW3TpqkpBsy/hHNTXCKXolZR2YomCOIMDZzE7Bh6myp/Vx30mMZc BYMH0YC4h8eUyf5TW5+TTWlYkJLDNgXO4KNuOmvnpRVr7hJqhiva4BDw6FjOe1p2njvI Rio4Nqk64bUBXWr7W7UGC0sFtrrJZ1sJ6uwE13XerBn27Bswn8XQqWkg3z2xY9maCiwI SGYGppPcY2++7IoXrkwy6tJoDrJXjr3Ni5FMaK3VTmeD1ZBVJ1oD0aXMxbkOQDBfTmqs vkfpa8zOwdBw8dH+k9tLCfigPFzyF1g+qa+qPqRvkrqC48g9F9ctn6V80WQD38c5iUrl CfWg== X-Gm-Message-State: AOAM533NtVlJmTbK7M7+PkYaO+cq5QzpDGGXN+W0wzpKGjU9sqtgp0ec OPuVACDSpTB3fCixpKG7xPnbX88/NCO7DNR+J4A= X-Google-Smtp-Source: ABdhPJxj8yb4YF92pDXktjtrNnwhqN3Vr+p4ZKJqEq7lGcxC2r2fbYb/WGExwJn5xiTnkygfvuUGGCMkXMreA6IpHdw= X-Received: by 2002:a7b:cc90:: with SMTP id p16mr16803231wma.79.1596878940561; Sat, 08 Aug 2020 02:29:00 -0700 (PDT) MIME-Version: 1.0 References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-6-git-send-email-olekstysh@gmail.com> <00e261e0-295a-9cd8-ed11-7e3801a4eb58@xen.org> <92e2b136-8468-2877-0e8c-c13ff2a0a1fb@xen.org> In-Reply-To: From: Julien Grall Date: Sat, 8 Aug 2020 10:28:49 +0100 Message-ID: Subject: Re: [RFC PATCH V1 05/12] hvm/dm: Introduce xendevicemodel_set_irq_level DM op To: Stefano Stabellini Content-Type: text/plain; charset="UTF-8" X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Oleksandr Tyshchenko , Julien Grall , Jan Beulich , xen-devel , Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Sat, 8 Aug 2020 at 10:27, Julien Grall wrote: > > On Fri, 7 Aug 2020 at 22:51, Stefano Stabellini wrote: > > > > On Fri, 7 Aug 2020, Jan Beulich wrote: > > > On 07.08.2020 01:49, Stefano Stabellini wrote: > > > > On Thu, 6 Aug 2020, Julien Grall wrote: > > > >> On 06/08/2020 01:37, Stefano Stabellini wrote: > > > >>> On Wed, 5 Aug 2020, Julien Grall wrote: > > > >>>> On 05/08/2020 00:22, Stefano Stabellini wrote: > > > >>>>> On Mon, 3 Aug 2020, Oleksandr Tyshchenko wrote: > > > >>>>>> From: Oleksandr Tyshchenko > > > >>>>>> > > > >>>>>> This patch adds ability to the device emulator to notify otherend > > > >>>>>> (some entity running in the guest) using a SPI and implements Arm > > > >>>>>> specific bits for it. Proposed interface allows emulator to set > > > >>>>>> the logical level of a one of a domain's IRQ lines. > > > >>>>>> > > > >>>>>> Please note, this is a split/cleanup of Julien's PoC: > > > >>>>>> "Add support for Guest IO forwarding to a device emulator" > > > >>>>>> > > > >>>>>> Signed-off-by: Julien Grall > > > >>>>>> Signed-off-by: Oleksandr Tyshchenko > > > >>>>>> --- > > > >>>>>> tools/libs/devicemodel/core.c | 18 > > > >>>>>> ++++++++++++++++++ > > > >>>>>> tools/libs/devicemodel/include/xendevicemodel.h | 4 ++++ > > > >>>>>> tools/libs/devicemodel/libxendevicemodel.map | 1 + > > > >>>>>> xen/arch/arm/dm.c | 22 > > > >>>>>> +++++++++++++++++++++- > > > >>>>>> xen/common/hvm/dm.c | 1 + > > > >>>>>> xen/include/public/hvm/dm_op.h | 15 > > > >>>>>> +++++++++++++++ > > > >>>>>> 6 files changed, 60 insertions(+), 1 deletion(-) > > > >>>>>> > > > >>>>>> diff --git a/tools/libs/devicemodel/core.c > > > >>>>>> b/tools/libs/devicemodel/core.c > > > >>>>>> index 4d40639..30bd79f 100644 > > > >>>>>> --- a/tools/libs/devicemodel/core.c > > > >>>>>> +++ b/tools/libs/devicemodel/core.c > > > >>>>>> @@ -430,6 +430,24 @@ int xendevicemodel_set_isa_irq_level( > > > >>>>>> return xendevicemodel_op(dmod, domid, 1, &op, sizeof(op)); > > > >>>>>> } > > > >>>>>> +int xendevicemodel_set_irq_level( > > > >>>>>> + xendevicemodel_handle *dmod, domid_t domid, uint32_t irq, > > > >>>>>> + unsigned int level) > > > >>>>> > > > >>>>> It is a pity that having xen_dm_op_set_pci_intx_level and > > > >>>>> xen_dm_op_set_isa_irq_level already we need to add a third one, but from > > > >>>>> the names alone I don't think we can reuse either of them. > > > >>>> > > > >>>> The problem is not the name... > > > >>>> > > > >>>>> > > > >>>>> It is very similar to set_isa_irq_level. We could almost rename > > > >>>>> xendevicemodel_set_isa_irq_level to xendevicemodel_set_irq_level or, > > > >>>>> better, just add an alias to it so that xendevicemodel_set_irq_level is > > > >>>>> implemented by calling xendevicemodel_set_isa_irq_level. Honestly I am > > > >>>>> not sure if it is worth doing it though. Any other opinions? > > > >>>> > > > >>>> ... the problem is the interrupt field is only 8-bit. So we would only be > > > >>>> able > > > >>>> to cover IRQ 0 - 255. > > > >>> > > > >>> Argh, that's not going to work :-( I wasn't sure if it was a good idea > > > >>> anyway. > > > >>> > > > >>> > > > >>>> It is not entirely clear how the existing subop could be extended without > > > >>>> breaking existing callers. > > > >>>> > > > >>>>> But I think we should plan for not needing two calls (one to set level > > > >>>>> to 1, and one to set it to 0): > > > >>>>> https://marc.info/?l=xen-devel&m=159535112027405 > > > >>>> > > > >>>> I am not sure to understand your suggestion here? Are you suggesting to > > > >>>> remove > > > >>>> the 'level' parameter? > > > >>> > > > >>> My hope was to make it optional to call the hypercall with level = 0, > > > >>> not necessarily to remove 'level' from the struct. > > > >> > > > >> From my understanding, the hypercall is meant to represent the status of the > > > >> line between the device and the interrupt controller (either low or high). > > > >> > > > >> This is then up to the interrupt controller to decide when the interrupt is > > > >> going to be fired: > > > >> - For edge interrupt, this will fire when the line move from low to high (or > > > >> vice versa). > > > >> - For level interrupt, this will fire when line is high (assuming level > > > >> trigger high) and will keeping firing until the device decided to lower the > > > >> line. > > > >> > > > >> For a device, it is common to keep the line high until an OS wrote to a > > > >> specific register. > > > >> > > > >> Furthermore, technically, the guest OS is in charge to configure how an > > > >> interrupt is triggered. Admittely this information is part of the DT, but > > > >> nothing prevent a guest to change it. > > > >> > > > >> As side note, we have a workaround in Xen for some buggy DT (see the arch > > > >> timer) exposing the wrong trigger type. > > > >> > > > >> Because of that, I don't really see a way to make optional. Maybe you have > > > >> something different in mind? > > > > > > > > For level, we need the level parameter. For edge, we are only interested > > > > in the "edge", right? > > > > > > I don't think so, unless Arm has special restrictions. Edges can be > > > both rising and falling ones. > > > > And the same is true for level interrupts too: they could be active-low > > or active-high. > > > > > > Instead of modelling the state of the line, which seems to be a bit > > error prone especially in the case of a single-device emulator that > > might not have enough information about the rest of the system (it might > > not know if the interrupt is active-high or active-low), we could model > > the triggering of the interrupt instead. > > I am not sure to understand why the single (or event multiple) device > emulator needs to know the trigger type. The information of the I mean trigger type configured by the OS here. Sorry for the confusion. > trigger type of the interrupt would be described in the firmware table > and it is expected to be the same as what the emulator expects. > > If the guest OS decided to configure wrongly the interrupt trigger > type, then it may not work properly. But, from my understanding, this > doesn't differ from the HW behavior. > > > > > In the case of level=1, it would mean that the interrupt line is active, > > no matter if it is active-low or active-high. In the case of level=0, it > > would mean that it is inactive. > > > > Similarly, in the case of an edge interrupt edge=1 or level=1 would mean > > that there is an edge, no matter if it is rising or falling. > > TBH, I think your approach is only going to introduce more headache in > Xen if a guest OS decides to change the trigger type. > > It feels much easier to just ask the emulator to let us know the level > of the line. Then if the guest OS decides to change the trigger type, > we only need to resample the line. > > Cheers, From xen-devel-bounces@lists.xenproject.org Sat Aug 08 11:56:03 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 08 Aug 2020 11:56:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4NRn-0008WR-S4; Sat, 08 Aug 2020 11:55:35 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4NRm-0008Vm-LX for xen-devel@lists.xenproject.org; Sat, 08 Aug 2020 11:55:34 +0000 X-Inumbo-ID: a3b594aa-38df-4a15-aac0-3f36f76ceea1 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a3b594aa-38df-4a15-aac0-3f36f76ceea1; Sat, 08 Aug 2020 11:55:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=XrGsVKa1Yh4BrdlaxwaNB1jpHI1aGdwm9UsxqO1Yxok=; b=vcXhOzMm0dIUDt+SW74+4zBp3 QoE1huR6wTal+Fxt2ctbjvsus1h9JAIzXhB5iVdVgkmgjKrd0mCIM1ErRrDTaw+UwlOzlAyBszHrW ckhvCVRlkmXO7Hn2dSjdoXNkqn5qTYNQepBYZuu2MGTkgwFMiNWkl9rUHAVC5Dn/ex1FQ=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4NRj-0004lu-AA; Sat, 08 Aug 2020 11:55:31 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k4NRi-0006HZ-V1; Sat, 08 Aug 2020 11:55:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k4NRi-0005kY-Rg; Sat, 08 Aug 2020 11:55:30 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.13-testing test] 152528: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.13-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking X-Osstest-Versions-This: xen=9b367b2b0b714f3ffb69ed6be0a118e8d3eac07f X-Osstest-Versions-That: xen=378321bb1fd5272653ae64f0306827614a3bd196 From: osstest service owner Date: Sat, 08 Aug 2020 11:55:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152528 xen-4.13-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/152528/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 12 guest-start fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt 14 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail never pass test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail never pass test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail never pass test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail never pass version targeted for testing: xen 9b367b2b0b714f3ffb69ed6be0a118e8d3eac07f baseline version: xen 378321bb1fd5272653ae64f0306827614a3bd196 Last test of basis 151712 2020-07-07 13:13:16 Z 31 days Testing same since 152528 2020-08-07 15:39:16 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Fam Zheng Grzegorz Uriasz Jan Beulich Paul Durrant Roger Pau Monné Tamas K Lengyel jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 378321bb1f..9b367b2b0b 9b367b2b0b714f3ffb69ed6be0a118e8d3eac07f -> stable-4.13 From xen-devel-bounces@lists.xenproject.org Sat Aug 08 15:48:18 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 08 Aug 2020 15:48:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4R4S-0002pY-7G; Sat, 08 Aug 2020 15:47:44 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4R4R-0002pE-Sp for xen-devel@lists.xenproject.org; Sat, 08 Aug 2020 15:47:43 +0000 X-Inumbo-ID: 721e35ed-3dea-4e49-a119-1e0eb0fb15f5 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 721e35ed-3dea-4e49-a119-1e0eb0fb15f5; Sat, 08 Aug 2020 15:47:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=PzDUzC1FW2F/y7I8uQhkzT8pcj4bgbPjpnz7eUwZKL8=; b=a2xdfAuFL9+KTd0sNEPceoMKO 7kOTFeBQq1cOpND+yGZTItTG4wj6gjWndjG/ckGz94vCT2UD9LePmGAYphK5PBOuyM+M9VGu4Imte t3FJRO2rmytLJx8/W9uNh4RlmBtMUU4Nu03rihoTl0FIgyEHdQYvaurTzyo6hL8p86NdQ=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4R4L-0001Ui-1P; Sat, 08 Aug 2020 15:47:37 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k4R4K-0002fL-L4; Sat, 08 Aug 2020 15:47:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k4R4K-0005QZ-Ho; Sat, 08 Aug 2020 15:47:36 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.14-testing test] 152531: regressions - FAIL X-Osstest-Failures: xen-4.14-testing:test-amd64-i386-libvirt:guest-start/debian.repeat:fail:regression xen-4.14-testing:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking X-Osstest-Versions-This: xen=c3a0fc22af90ef28e68b116c6a49d9cec57f71cf X-Osstest-Versions-That: xen=456957aaa1391e0dfa969e2dd97b87c51a79444e From: osstest service owner Date: Sat, 08 Aug 2020 15:47:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152531 xen-4.14-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/152531/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt 18 guest-start/debian.repeat fail REGR. vs. 152153 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 16 guest-start/debian.repeat fail like 152153 test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 12 guest-start fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 14 saverestore-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail never pass test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail never pass test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail never pass version targeted for testing: xen c3a0fc22af90ef28e68b116c6a49d9cec57f71cf baseline version: xen 456957aaa1391e0dfa969e2dd97b87c51a79444e Last test of basis 152153 2020-07-23 15:18:22 Z 16 days Testing same since 152531 2020-08-07 15:39:18 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Fam Zheng Jan Beulich Paul Durrant jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit c3a0fc22af90ef28e68b116c6a49d9cec57f71cf Author: Jan Beulich Date: Fri Aug 7 17:11:44 2020 +0200 x86: comment update after "drop high compat r/o M2P table address range" Commit 5af040ef8b57 clearly should also have updated the comment, not just the #define-s. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper master commit: 2e98d0b1d09e99e3d1287cb13f42b604ebc3c29a master date: 2020-08-05 10:21:22 +0200 commit 864d5701ec5dc5af028d415e86bf5cf6aaed3a7c Author: Paul Durrant Date: Fri Aug 7 17:11:10 2020 +0200 x86/hvm: set 'ipat' in EPT for special pages All non-MMIO ranges (i.e those not mapping real device MMIO regions) that map valid MFNs are normally marked MTRR_TYPE_WRBACK and 'ipat' is set. Hence when PV drivers running in a guest populate the BAR space of the Xen Platform PCI Device with pages such as the Shared Info page or Grant Table pages, accesses to these pages will be cachable. However, should IOMMU mappings be enabled be enabled for the guest then these accesses become uncachable. This has a substantial negative effect on I/O throughput of PV devices. Arguably PV drivers should bot be using BAR space to host the Shared Info and Grant Table pages but it is currently commonplace for them to do this and so this problem needs mitigation. Hence this patch makes sure the 'ipat' bit is set for any special page regardless of where in GFN space it is mapped. NOTE: Clearly this mitigation only applies to Intel EPT. It is not obvious that there is any similar mitigation possible for AMD NPT. Downstreams such as Citrix XenServer have been carrying a patch similar to this for several releases though. Signed-off-by: Paul Durrant Reviewed-by: Jan Beulich master commit: ca24b2ffdbd9a25b2d313a547ccbe97baf3e5a8d master date: 2020-07-31 17:42:47 +0200 commit afed8e4365f0dec26a040ea0670b654e00d8c869 Author: Jan Beulich Date: Fri Aug 7 17:10:34 2020 +0200 x86emul: replace UB shifts Displacement values can be negative, hence we shouldn't left-shift them. Or else we get (XEN) UBSAN: Undefined behaviour in x86_emulate/x86_emulate.c:3482:55 (XEN) left shift of negative value -2 While auditing shifts, I noticed a pair of missing parentheses, which also get added right here. Reported-by: Andrew Cooper Signed-off-by: Jan Beulich Acked-by: Andrew Cooper Tested-by: Andrew Cooper x86: comment update after "drop high compat r/o M2P table address range" Commit 5af040ef8b57 clearly should also have updated the comment, not just the #define-s. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper master commit: b6a907f8c83d37886d0523f1aeff61b98e133498 master date: 2020-07-31 17:41:58 +0200 master commit: 2e98d0b1d09e99e3d1287cb13f42b604ebc3c29a master date: 2020-08-05 10:21:22 +0200 commit a5dab0a2453da1e15fd49e6a7fa9138e333ba9af Author: Fam Zheng Date: Fri Aug 7 17:09:51 2020 +0200 x86/cpuid: Fix APIC bit clearing The bug is obvious here, other places in this function used "cpufeat_mask" correctly. Fixed: b648feff8ea2 ("xen/x86: Improvements to in-hypervisor cpuid sanity checks") Signed-off-by: Fam Zheng Reviewed-by: Roger Pau Monné Reviewed-by: Andrew Cooper master commit: 64219fa179c3e48adad12bfce3f6b3f1596cccbf master date: 2020-07-29 19:03:41 +0100 commit b8c3e33a4fe4374f633b4369200731662ff1f750 Author: Jan Beulich Date: Fri Aug 7 17:09:19 2020 +0200 x86/S3: put data segment registers into known state upon resume wakeup_32 sets %ds and %es to BOOT_DS, while leaving %fs at what wakeup_start did set it to, and %gs at whatever BIOS did load into it. All of this may end up confusing the first load_segments() to run on the BSP after resume, in particular allowing a non-nul selector value to be left in %fs. Alongside %ss, also put all other data segment registers into the same state that the boot and CPU bringup paths put them in. Reported-by: M. Vefa Bicakci Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné Reviewed-by: Andrew Cooper master commit: 55f8c389d4348cc517946fdcb10794112458e81e master date: 2020-07-24 10:17:26 +0200 commit f836759a7bbf095dc5b1f31a069296bcfd694b82 Author: Jan Beulich Date: Fri Aug 7 17:07:56 2020 +0200 update Xen version to 4.14.1-pre (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Sat Aug 08 20:01:15 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 08 Aug 2020 20:01:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4V1Q-0008Vs-2X; Sat, 08 Aug 2020 20:00:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4V1P-0008Vm-Kk for xen-devel@lists.xenproject.org; Sat, 08 Aug 2020 20:00:51 +0000 X-Inumbo-ID: 0da47ca9-d2e1-4303-8e41-6f5cb270f395 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0da47ca9-d2e1-4303-8e41-6f5cb270f395; Sat, 08 Aug 2020 20:00:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=URKqyMGX5HOMIMTVHS0YJeKhY5JUcF5isoWYJUn75fA=; b=uhiw6dKklerJwyOiAsanKpq7u xf4S8GP2BW5EJDoyBJyZubjOvKKTDsKXb1R+3x811f+nAA+lzwkKwF2/A2tHOdAgEHzPa232BDG6t qyA1Wxr+69WMQGcp1VMFvQ7iW9lQmpWjN2iN9UInIvWxWdalvYib76AGK8m2KPXoFMfeQ=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4V1M-0007dH-Ez; Sat, 08 Aug 2020 20:00:48 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k4V1M-0006tF-1A; Sat, 08 Aug 2020 20:00:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k4V1M-0006YC-0V; Sat, 08 Aug 2020 20:00:48 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.12-testing test] 152525: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-localmigrate/x10:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking X-Osstest-Versions-This: xen=1336ca17742471fc4a59879ae2f637a59530a933 X-Osstest-Versions-That: xen=19e0bbb4eba8d781b972448ec01ede6ca7fa22cb From: osstest service owner Date: Sat, 08 Aug 2020 20:00:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152525 xen-4.12-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/152525/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qcow2 17 guest-localmigrate/x10 fail like 151715 test-amd64-i386-xl-pvshim 12 guest-start fail never pass test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail never pass test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail never pass test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass version targeted for testing: xen 1336ca17742471fc4a59879ae2f637a59530a933 baseline version: xen 19e0bbb4eba8d781b972448ec01ede6ca7fa22cb Last test of basis 151715 2020-07-07 13:36:08 Z 32 days Testing same since 152525 2020-08-07 15:39:19 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Fam Zheng Grzegorz Uriasz Jan Beulich Paul Durrant Roger Pau Monné Tamas K Lengyel jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 19e0bbb4eb..1336ca1774 1336ca17742471fc4a59879ae2f637a59530a933 -> stable-4.12 From xen-devel-bounces@lists.xenproject.org Sun Aug 09 02:02:40 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 09 Aug 2020 02:02:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4afE-0002Ib-HY; Sun, 09 Aug 2020 02:02:20 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4afC-0002IW-Io for xen-devel@lists.xenproject.org; Sun, 09 Aug 2020 02:02:18 +0000 X-Inumbo-ID: c91d2229-9a3c-49bb-b0cc-01c4cb360c57 Received: from userp2130.oracle.com (unknown [156.151.31.86]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c91d2229-9a3c-49bb-b0cc-01c4cb360c57; Sun, 09 Aug 2020 02:02:16 +0000 (UTC) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0791vsOi177885; Sun, 9 Aug 2020 02:01:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=sxEn2QuF/4tTg+v0JciiPd0Yn6jnKBgua+CjfIuKe/g=; b=VMhNhhi+NbhelaW0Zt9INn9caw1IVkJ/kBRdNsYO6BxMijPaqw9zsQ5jauMZFCJafMzQ 97Vr5JkFqhHniWXyLMaO8JoZ1MtrU3fHFC3IBSo/M6uBMQIKPbIR71BTwLL8VK2JOz8S +cc6sdOZLtT/LPWXmHNUnn6zm1pl+Qcmmq/EYK5f1uH9Ve6BEcObO3RYGb/FaI0mMrY4 DWPE0N0le1xVQzh5RQb7ZFsjKGTbAgAquz+DCheHfy+PXYADXgBzwvpzxhXjREbcCnLz klxDNczdLUOHqT+mgMCB4tyWcLdZoeWufasuaxN0OQAyBR6sWSgjNCv0/zH64y2wnvAw QQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 32t2yd8aqv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 09 Aug 2020 02:01:50 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0791w8Xq181078; Sun, 9 Aug 2020 02:01:50 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 32t5ytvusg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 09 Aug 2020 02:01:49 +0000 Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 07921gcr021040; Sun, 9 Aug 2020 02:01:43 GMT Received: from [192.168.29.236] (/73.249.50.119) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 09 Aug 2020 02:01:42 +0000 Subject: Re: [PATCH v3 1/7] x86/xen: remove 32-bit Xen PV guest support To: Juergen Gross , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org References: <20200807083826.16794-1-jgross@suse.com> <20200807083826.16794-2-jgross@suse.com> From: Boris Ostrovsky Autocrypt: addr=boris.ostrovsky@oracle.com; keydata= xsFNBFH8CgsBEAC0KiOi9siOvlXatK2xX99e/J3OvApoYWjieVQ9232Eb7GzCWrItCzP8FUV PQg8rMsSd0OzIvvjbEAvaWLlbs8wa3MtVLysHY/DfqRK9Zvr/RgrsYC6ukOB7igy2PGqZd+M MDnSmVzik0sPvB6xPV7QyFsykEgpnHbvdZAUy/vyys8xgT0PVYR5hyvhyf6VIfGuvqIsvJw5 C8+P71CHI+U/IhsKrLrsiYHpAhQkw+Zvyeml6XSi5w4LXDbF+3oholKYCkPwxmGdK8MUIdkM d7iYdKqiP4W6FKQou/lC3jvOceGupEoDV9botSWEIIlKdtm6C4GfL45RD8V4B9iy24JHPlom woVWc0xBZboQguhauQqrBFooHO3roEeM1pxXjLUbDtH4t3SAI3gt4dpSyT3EvzhyNQVVIxj2 FXnIChrYxR6S0ijSqUKO0cAduenhBrpYbz9qFcB/GyxD+ZWY7OgQKHUZMWapx5bHGQ8bUZz2 SfjZwK+GETGhfkvNMf6zXbZkDq4kKB/ywaKvVPodS1Poa44+B9sxbUp1jMfFtlOJ3AYB0WDS Op3d7F2ry20CIf1Ifh0nIxkQPkTX7aX5rI92oZeu5u038dHUu/dO2EcuCjl1eDMGm5PLHDSP 0QUw5xzk1Y8MG1JQ56PtqReO33inBXG63yTIikJmUXFTw6lLJwARAQABzTNCb3JpcyBPc3Ry b3Zza3kgKFdvcmspIDxib3Jpcy5vc3Ryb3Zza3lAb3JhY2xlLmNvbT7CwXgEEwECACIFAlH8 CgsCGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEIredpCGysGyasEP/j5xApopUf4g 9Fl3UxZuBx+oduuw3JHqgbGZ2siA3EA4bKwtKq8eT7ekpApn4c0HA8TWTDtgZtLSV5IdH+9z JimBDrhLkDI3Zsx2CafL4pMJvpUavhc5mEU8myp4dWCuIylHiWG65agvUeFZYK4P33fGqoaS VGx3tsQIAr7MsQxilMfRiTEoYH0WWthhE0YVQzV6kx4wj4yLGYPPBtFqnrapKKC8yFTpgjaK jImqWhU9CSUAXdNEs/oKVR1XlkDpMCFDl88vKAuJwugnixjbPFTVPyoC7+4Bm/FnL3iwlJVE qIGQRspt09r+datFzPqSbp5Fo/9m4JSvgtPp2X2+gIGgLPWp2ft1NXHHVWP19sPgEsEJXSr9 tskM8ScxEkqAUuDs6+x/ISX8wa5Pvmo65drN+JWA8EqKOHQG6LUsUdJolFM2i4Z0k40BnFU/ kjTARjrXW94LwokVy4x+ZYgImrnKWeKac6fMfMwH2aKpCQLlVxdO4qvJkv92SzZz4538az1T m+3ekJAimou89cXwXHCFb5WqJcyjDfdQF857vTn1z4qu7udYCuuV/4xDEhslUq1+GcNDjAhB nNYPzD+SvhWEsrjuXv+fDONdJtmLUpKs4Jtak3smGGhZsqpcNv8nQzUGDQZjuCSmDqW8vn2o hWwveNeRTkxh+2x1Qb3GT46uzsFNBFH8CgsBEADGC/yx5ctcLQlB9hbq7KNqCDyZNoYu1HAB Hal3MuxPfoGKObEktawQPQaSTB5vNlDxKihezLnlT/PKjcXC2R1OjSDinlu5XNGc6mnky03q yymUPyiMtWhBBftezTRxWRslPaFWlg/h/Y1iDuOcklhpr7K1h1jRPCrf1yIoxbIpDbffnuyz kuto4AahRvBU4Js4sU7f/btU+h+e0AcLVzIhTVPIz7PM+Gk2LNzZ3/on4dnEc/qd+ZZFlOQ4 KDN/hPqlwA/YJsKzAPX51L6Vv344pqTm6Z0f9M7YALB/11FO2nBB7zw7HAUYqJeHutCwxm7i BDNt0g9fhviNcJzagqJ1R7aPjtjBoYvKkbwNu5sWDpQ4idnsnck4YT6ctzN4I+6lfkU8zMzC gM2R4qqUXmxFIS4Bee+gnJi0Pc3KcBYBZsDK44FtM//5Cp9DrxRQOh19kNHBlxkmEb8kL/pw XIDcEq8MXzPBbxwHKJ3QRWRe5jPNpf8HCjnZz0XyJV0/4M1JvOua7IZftOttQ6KnM4m6WNIZ 2ydg7dBhDa6iv1oKdL7wdp/rCulVWn8R7+3cRK95SnWiJ0qKDlMbIN8oGMhHdin8cSRYdmHK kTnvSGJNlkis5a+048o0C6jI3LozQYD/W9wq7MvgChgVQw1iEOB4u/3FXDEGulRVko6xCBU4 SQARAQABwsFfBBgBAgAJBQJR/AoLAhsMAAoJEIredpCGysGyfvMQAIywR6jTqix6/fL0Ip8G jpt3uk//QNxGJE3ZkUNLX6N786vnEJvc1beCu6EwqD1ezG9fJKMl7F3SEgpYaiKEcHfoKGdh 30B3Hsq44vOoxR6zxw2B/giADjhmWTP5tWQ9548N4VhIZMYQMQCkdqaueSL+8asp8tBNP+TJ PAIIANYvJaD8xA7sYUXGTzOXDh2THWSvmEWWmzok8er/u6ZKdS1YmZkUy8cfzrll/9hiGCTj u3qcaOM6i/m4hqtvsI1cOORMVwjJF4+IkC5ZBoeRs/xW5zIBdSUoC8L+OCyj5JETWTt40+lu qoqAF/AEGsNZTrwHJYu9rbHH260C0KYCNqmxDdcROUqIzJdzDKOrDmebkEVnxVeLJBIhYZUd t3Iq9hdjpU50TA6sQ3mZxzBdfRgg+vaj2DsJqI5Xla9QGKD+xNT6v14cZuIMZzO7w0DoojM4 ByrabFsOQxGvE0w9Dch2BDSI2Xyk1zjPKxG1VNBQVx3flH37QDWpL2zlJikW29Ws86PHdthh Fm5PY8YtX576DchSP6qJC57/eAAe/9ztZdVAdesQwGb9hZHJc75B+VNm4xrh/PJO6c1THqdQ 19WVJ+7rDx3PhVncGlbAOiiiE3NOFPJ1OQYxPKtpBUukAlOTnkKE6QcA4zckFepUkfmBV1wM Jg6OxFYd01z+a+oL Message-ID: <893bc936-81bf-1e86-8423-a61fbfb5dc02@oracle.com> Date: Sat, 8 Aug 2020 22:01:35 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200807083826.16794-2-jgross@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9707 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 phishscore=0 bulkscore=0 adultscore=0 spamscore=0 suspectscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008090010 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9707 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 priorityscore=1501 malwarescore=0 impostorscore=0 lowpriorityscore=0 mlxscore=0 bulkscore=0 suspectscore=0 phishscore=0 adultscore=0 spamscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008090010 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Ingo Molnar , Borislav Petkov , Andy Lutomirski , "H. Peter Anvin" , Thomas Gleixner Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 8/7/20 4:38 AM, Juergen Gross wrote: > > void __init xen_reserve_top(void) > { > -#ifdef CONFIG_X86_32 > - unsigned long top = HYPERVISOR_VIRT_START; > - struct xen_platform_parameters pp; > - > - if (HYPERVISOR_xen_version(XENVER_platform_parameters, &pp) == 0) > - top = pp.virt_start; > - > - reserve_top_address(-top); > -#endif /* CONFIG_X86_32 */ > } > We should be able now to get rid of xen_reserve_top() altogether. Other than that Reviewed-by: Boris Ostrovsky -boris From xen-devel-bounces@lists.xenproject.org Sun Aug 09 02:05:19 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 09 Aug 2020 02:05:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4ai7-0002R8-19; Sun, 09 Aug 2020 02:05:19 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4ai5-0002R3-Sw for xen-devel@lists.xenproject.org; Sun, 09 Aug 2020 02:05:17 +0000 X-Inumbo-ID: fff65698-749e-47b9-8b86-afac605ed2f7 Received: from userp2120.oracle.com (unknown [156.151.31.85]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fff65698-749e-47b9-8b86-afac605ed2f7; Sun, 09 Aug 2020 02:05:17 +0000 (UTC) Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0791wEeD054014; Sun, 9 Aug 2020 02:05:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=YxSp4K2wlTC691uVVaHqry3eVtQTsiPQ4FKxKCSNgVM=; b=Wn49Z8jbrnrAquD6556G4OJjQNFVm6TWY8i1IxiQXNXWITmodXsfhfhtXKopCQ4nX0LO LDd+/+UmQtRyKU2yn6rD+g8ZWlhgr9bflWA0wBPKk3v9a2fXC7pGzommcHb9GIhX4Xyy iz9CHcY5Exol9BOqpkxQhxpEoW9l9xoVWC/n3fZBvLgZIwS+KA+OkHh2i6AneZAwN/ak /ImywwJ99owJVeEzV/P6w/K6FtUZpUNwH7X3bZh+i370P7BFcqV8Ll6Hwj9mkAc3O3cS +mmCC9JCip0DSfwaBu/goVwzLambbSqDMsC7A0Ev7N36jvsXFe0sGnSzQ27mACfOChCu Qg== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 32smpn1wmp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 09 Aug 2020 02:05:03 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07923QGs126587; Sun, 9 Aug 2020 02:05:02 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3020.oracle.com with ESMTP id 32t5xvgk8q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 09 Aug 2020 02:05:02 +0000 Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 079250m5010498; Sun, 9 Aug 2020 02:05:00 GMT Received: from [192.168.29.236] (/73.249.50.119) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 09 Aug 2020 02:05:00 +0000 Subject: Re: [PATCH v3 2/7] x86/xen: eliminate xen-asm_64.S To: Juergen Gross , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org References: <20200807083826.16794-1-jgross@suse.com> <20200807083826.16794-3-jgross@suse.com> From: Boris Ostrovsky Autocrypt: addr=boris.ostrovsky@oracle.com; keydata= xsFNBFH8CgsBEAC0KiOi9siOvlXatK2xX99e/J3OvApoYWjieVQ9232Eb7GzCWrItCzP8FUV PQg8rMsSd0OzIvvjbEAvaWLlbs8wa3MtVLysHY/DfqRK9Zvr/RgrsYC6ukOB7igy2PGqZd+M MDnSmVzik0sPvB6xPV7QyFsykEgpnHbvdZAUy/vyys8xgT0PVYR5hyvhyf6VIfGuvqIsvJw5 C8+P71CHI+U/IhsKrLrsiYHpAhQkw+Zvyeml6XSi5w4LXDbF+3oholKYCkPwxmGdK8MUIdkM d7iYdKqiP4W6FKQou/lC3jvOceGupEoDV9botSWEIIlKdtm6C4GfL45RD8V4B9iy24JHPlom woVWc0xBZboQguhauQqrBFooHO3roEeM1pxXjLUbDtH4t3SAI3gt4dpSyT3EvzhyNQVVIxj2 FXnIChrYxR6S0ijSqUKO0cAduenhBrpYbz9qFcB/GyxD+ZWY7OgQKHUZMWapx5bHGQ8bUZz2 SfjZwK+GETGhfkvNMf6zXbZkDq4kKB/ywaKvVPodS1Poa44+B9sxbUp1jMfFtlOJ3AYB0WDS Op3d7F2ry20CIf1Ifh0nIxkQPkTX7aX5rI92oZeu5u038dHUu/dO2EcuCjl1eDMGm5PLHDSP 0QUw5xzk1Y8MG1JQ56PtqReO33inBXG63yTIikJmUXFTw6lLJwARAQABzTNCb3JpcyBPc3Ry b3Zza3kgKFdvcmspIDxib3Jpcy5vc3Ryb3Zza3lAb3JhY2xlLmNvbT7CwXgEEwECACIFAlH8 CgsCGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEIredpCGysGyasEP/j5xApopUf4g 9Fl3UxZuBx+oduuw3JHqgbGZ2siA3EA4bKwtKq8eT7ekpApn4c0HA8TWTDtgZtLSV5IdH+9z JimBDrhLkDI3Zsx2CafL4pMJvpUavhc5mEU8myp4dWCuIylHiWG65agvUeFZYK4P33fGqoaS VGx3tsQIAr7MsQxilMfRiTEoYH0WWthhE0YVQzV6kx4wj4yLGYPPBtFqnrapKKC8yFTpgjaK jImqWhU9CSUAXdNEs/oKVR1XlkDpMCFDl88vKAuJwugnixjbPFTVPyoC7+4Bm/FnL3iwlJVE qIGQRspt09r+datFzPqSbp5Fo/9m4JSvgtPp2X2+gIGgLPWp2ft1NXHHVWP19sPgEsEJXSr9 tskM8ScxEkqAUuDs6+x/ISX8wa5Pvmo65drN+JWA8EqKOHQG6LUsUdJolFM2i4Z0k40BnFU/ kjTARjrXW94LwokVy4x+ZYgImrnKWeKac6fMfMwH2aKpCQLlVxdO4qvJkv92SzZz4538az1T m+3ekJAimou89cXwXHCFb5WqJcyjDfdQF857vTn1z4qu7udYCuuV/4xDEhslUq1+GcNDjAhB nNYPzD+SvhWEsrjuXv+fDONdJtmLUpKs4Jtak3smGGhZsqpcNv8nQzUGDQZjuCSmDqW8vn2o hWwveNeRTkxh+2x1Qb3GT46uzsFNBFH8CgsBEADGC/yx5ctcLQlB9hbq7KNqCDyZNoYu1HAB Hal3MuxPfoGKObEktawQPQaSTB5vNlDxKihezLnlT/PKjcXC2R1OjSDinlu5XNGc6mnky03q yymUPyiMtWhBBftezTRxWRslPaFWlg/h/Y1iDuOcklhpr7K1h1jRPCrf1yIoxbIpDbffnuyz kuto4AahRvBU4Js4sU7f/btU+h+e0AcLVzIhTVPIz7PM+Gk2LNzZ3/on4dnEc/qd+ZZFlOQ4 KDN/hPqlwA/YJsKzAPX51L6Vv344pqTm6Z0f9M7YALB/11FO2nBB7zw7HAUYqJeHutCwxm7i BDNt0g9fhviNcJzagqJ1R7aPjtjBoYvKkbwNu5sWDpQ4idnsnck4YT6ctzN4I+6lfkU8zMzC gM2R4qqUXmxFIS4Bee+gnJi0Pc3KcBYBZsDK44FtM//5Cp9DrxRQOh19kNHBlxkmEb8kL/pw XIDcEq8MXzPBbxwHKJ3QRWRe5jPNpf8HCjnZz0XyJV0/4M1JvOua7IZftOttQ6KnM4m6WNIZ 2ydg7dBhDa6iv1oKdL7wdp/rCulVWn8R7+3cRK95SnWiJ0qKDlMbIN8oGMhHdin8cSRYdmHK kTnvSGJNlkis5a+048o0C6jI3LozQYD/W9wq7MvgChgVQw1iEOB4u/3FXDEGulRVko6xCBU4 SQARAQABwsFfBBgBAgAJBQJR/AoLAhsMAAoJEIredpCGysGyfvMQAIywR6jTqix6/fL0Ip8G jpt3uk//QNxGJE3ZkUNLX6N786vnEJvc1beCu6EwqD1ezG9fJKMl7F3SEgpYaiKEcHfoKGdh 30B3Hsq44vOoxR6zxw2B/giADjhmWTP5tWQ9548N4VhIZMYQMQCkdqaueSL+8asp8tBNP+TJ PAIIANYvJaD8xA7sYUXGTzOXDh2THWSvmEWWmzok8er/u6ZKdS1YmZkUy8cfzrll/9hiGCTj u3qcaOM6i/m4hqtvsI1cOORMVwjJF4+IkC5ZBoeRs/xW5zIBdSUoC8L+OCyj5JETWTt40+lu qoqAF/AEGsNZTrwHJYu9rbHH260C0KYCNqmxDdcROUqIzJdzDKOrDmebkEVnxVeLJBIhYZUd t3Iq9hdjpU50TA6sQ3mZxzBdfRgg+vaj2DsJqI5Xla9QGKD+xNT6v14cZuIMZzO7w0DoojM4 ByrabFsOQxGvE0w9Dch2BDSI2Xyk1zjPKxG1VNBQVx3flH37QDWpL2zlJikW29Ws86PHdthh Fm5PY8YtX576DchSP6qJC57/eAAe/9ztZdVAdesQwGb9hZHJc75B+VNm4xrh/PJO6c1THqdQ 19WVJ+7rDx3PhVncGlbAOiiiE3NOFPJ1OQYxPKtpBUukAlOTnkKE6QcA4zckFepUkfmBV1wM Jg6OxFYd01z+a+oL Message-ID: Date: Sat, 8 Aug 2020 22:04:54 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200807083826.16794-3-jgross@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9707 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 suspectscore=0 mlxscore=0 adultscore=0 bulkscore=0 phishscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008090011 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9707 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 impostorscore=0 phishscore=0 clxscore=1015 spamscore=0 malwarescore=0 adultscore=0 mlxlogscore=999 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008090010 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Thomas Gleixner , Stefano Stabellini , Borislav Petkov , Ingo Molnar , "H. Peter Anvin" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 8/7/20 4:38 AM, Juergen Gross wrote: > With 32-bit pv-guest support removed xen-asm_64.S can be merged with > xen-asm.S > > Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky except for > diff --git a/arch/x86/xen/xen-asm.S b/arch/x86/xen/xen-asm.S > index c59d077510bf..d1272a63f097 100644 > --- a/arch/x86/xen/xen-asm.S > +++ b/arch/x86/xen/xen-asm.S > @@ -6,12 +6,19 @@ > * operations here; the indirect forms are better handled in C. > */ > > +#include > #include > #include > #include > +#include > +#include > +#include > #include > #include asm/asm.h included twice now. From xen-devel-bounces@lists.xenproject.org Sun Aug 09 02:24:39 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 09 Aug 2020 02:24:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4b0e-0004AH-MZ; Sun, 09 Aug 2020 02:24:28 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4b0d-0004AC-NV for xen-devel@lists.xenproject.org; Sun, 09 Aug 2020 02:24:27 +0000 X-Inumbo-ID: 1e95eefd-f67d-4b37-8bfa-8e0d96cdee61 Received: from userp2130.oracle.com (unknown [156.151.31.86]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1e95eefd-f67d-4b37-8bfa-8e0d96cdee61; Sun, 09 Aug 2020 02:24:26 +0000 (UTC) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0792Mkq7008496; Sun, 9 Aug 2020 02:24:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=KDJ+jCsIdC7X/bzGxKLszgvp0oAdjJ7d+BTcByVJjQI=; b=qKLyJ/T75v46keNrVtfM+2ck5obpWzZhtcOYpIFydR6yzMh5oDxJQ2LT2ITDlP6sR0C4 GKsP8Ed2s2Ckxpvx3xP1ac4fmXlBXp9uk4o/34gw/DWfmFpYK1+2lBTSAc17axwz7rQD gS2hdh53gFCu9x03O3J1NmTgyIkm1GQ4tHaFGwP26t2BDgwZA0xcqgdhLGmaX1pWDOn3 z7/zeuL1siT5Y9xpF4KZTkr5HFoQUF1RznEqbQV8kLaE9qG2d5sPcQT6v1j9Ow8iCbWG N9x+IcsGtjfVL68K3xQBw+cwxRT+tp3gJxSzvfzjeoqtNuW66Cdl8NNUs/lOTX6X5L9b lA== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 32t2yd8bcm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 09 Aug 2020 02:24:20 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0792HL1w051571; Sun, 9 Aug 2020 02:22:19 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 32t5mjmjxx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 09 Aug 2020 02:22:19 +0000 Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 0792MH0V030284; Sun, 9 Aug 2020 02:22:17 GMT Received: from [192.168.29.236] (/73.249.50.119) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 09 Aug 2020 02:22:17 +0000 Subject: Re: [PATCH v3 3/7] x86/xen: drop tests for highmem in pv code To: Juergen Gross , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org References: <20200807083826.16794-1-jgross@suse.com> <20200807083826.16794-4-jgross@suse.com> From: Boris Ostrovsky Autocrypt: addr=boris.ostrovsky@oracle.com; keydata= xsFNBFH8CgsBEAC0KiOi9siOvlXatK2xX99e/J3OvApoYWjieVQ9232Eb7GzCWrItCzP8FUV PQg8rMsSd0OzIvvjbEAvaWLlbs8wa3MtVLysHY/DfqRK9Zvr/RgrsYC6ukOB7igy2PGqZd+M MDnSmVzik0sPvB6xPV7QyFsykEgpnHbvdZAUy/vyys8xgT0PVYR5hyvhyf6VIfGuvqIsvJw5 C8+P71CHI+U/IhsKrLrsiYHpAhQkw+Zvyeml6XSi5w4LXDbF+3oholKYCkPwxmGdK8MUIdkM d7iYdKqiP4W6FKQou/lC3jvOceGupEoDV9botSWEIIlKdtm6C4GfL45RD8V4B9iy24JHPlom woVWc0xBZboQguhauQqrBFooHO3roEeM1pxXjLUbDtH4t3SAI3gt4dpSyT3EvzhyNQVVIxj2 FXnIChrYxR6S0ijSqUKO0cAduenhBrpYbz9qFcB/GyxD+ZWY7OgQKHUZMWapx5bHGQ8bUZz2 SfjZwK+GETGhfkvNMf6zXbZkDq4kKB/ywaKvVPodS1Poa44+B9sxbUp1jMfFtlOJ3AYB0WDS Op3d7F2ry20CIf1Ifh0nIxkQPkTX7aX5rI92oZeu5u038dHUu/dO2EcuCjl1eDMGm5PLHDSP 0QUw5xzk1Y8MG1JQ56PtqReO33inBXG63yTIikJmUXFTw6lLJwARAQABzTNCb3JpcyBPc3Ry b3Zza3kgKFdvcmspIDxib3Jpcy5vc3Ryb3Zza3lAb3JhY2xlLmNvbT7CwXgEEwECACIFAlH8 CgsCGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEIredpCGysGyasEP/j5xApopUf4g 9Fl3UxZuBx+oduuw3JHqgbGZ2siA3EA4bKwtKq8eT7ekpApn4c0HA8TWTDtgZtLSV5IdH+9z JimBDrhLkDI3Zsx2CafL4pMJvpUavhc5mEU8myp4dWCuIylHiWG65agvUeFZYK4P33fGqoaS VGx3tsQIAr7MsQxilMfRiTEoYH0WWthhE0YVQzV6kx4wj4yLGYPPBtFqnrapKKC8yFTpgjaK jImqWhU9CSUAXdNEs/oKVR1XlkDpMCFDl88vKAuJwugnixjbPFTVPyoC7+4Bm/FnL3iwlJVE qIGQRspt09r+datFzPqSbp5Fo/9m4JSvgtPp2X2+gIGgLPWp2ft1NXHHVWP19sPgEsEJXSr9 tskM8ScxEkqAUuDs6+x/ISX8wa5Pvmo65drN+JWA8EqKOHQG6LUsUdJolFM2i4Z0k40BnFU/ kjTARjrXW94LwokVy4x+ZYgImrnKWeKac6fMfMwH2aKpCQLlVxdO4qvJkv92SzZz4538az1T m+3ekJAimou89cXwXHCFb5WqJcyjDfdQF857vTn1z4qu7udYCuuV/4xDEhslUq1+GcNDjAhB nNYPzD+SvhWEsrjuXv+fDONdJtmLUpKs4Jtak3smGGhZsqpcNv8nQzUGDQZjuCSmDqW8vn2o hWwveNeRTkxh+2x1Qb3GT46uzsFNBFH8CgsBEADGC/yx5ctcLQlB9hbq7KNqCDyZNoYu1HAB Hal3MuxPfoGKObEktawQPQaSTB5vNlDxKihezLnlT/PKjcXC2R1OjSDinlu5XNGc6mnky03q yymUPyiMtWhBBftezTRxWRslPaFWlg/h/Y1iDuOcklhpr7K1h1jRPCrf1yIoxbIpDbffnuyz kuto4AahRvBU4Js4sU7f/btU+h+e0AcLVzIhTVPIz7PM+Gk2LNzZ3/on4dnEc/qd+ZZFlOQ4 KDN/hPqlwA/YJsKzAPX51L6Vv344pqTm6Z0f9M7YALB/11FO2nBB7zw7HAUYqJeHutCwxm7i BDNt0g9fhviNcJzagqJ1R7aPjtjBoYvKkbwNu5sWDpQ4idnsnck4YT6ctzN4I+6lfkU8zMzC gM2R4qqUXmxFIS4Bee+gnJi0Pc3KcBYBZsDK44FtM//5Cp9DrxRQOh19kNHBlxkmEb8kL/pw XIDcEq8MXzPBbxwHKJ3QRWRe5jPNpf8HCjnZz0XyJV0/4M1JvOua7IZftOttQ6KnM4m6WNIZ 2ydg7dBhDa6iv1oKdL7wdp/rCulVWn8R7+3cRK95SnWiJ0qKDlMbIN8oGMhHdin8cSRYdmHK kTnvSGJNlkis5a+048o0C6jI3LozQYD/W9wq7MvgChgVQw1iEOB4u/3FXDEGulRVko6xCBU4 SQARAQABwsFfBBgBAgAJBQJR/AoLAhsMAAoJEIredpCGysGyfvMQAIywR6jTqix6/fL0Ip8G jpt3uk//QNxGJE3ZkUNLX6N786vnEJvc1beCu6EwqD1ezG9fJKMl7F3SEgpYaiKEcHfoKGdh 30B3Hsq44vOoxR6zxw2B/giADjhmWTP5tWQ9548N4VhIZMYQMQCkdqaueSL+8asp8tBNP+TJ PAIIANYvJaD8xA7sYUXGTzOXDh2THWSvmEWWmzok8er/u6ZKdS1YmZkUy8cfzrll/9hiGCTj u3qcaOM6i/m4hqtvsI1cOORMVwjJF4+IkC5ZBoeRs/xW5zIBdSUoC8L+OCyj5JETWTt40+lu qoqAF/AEGsNZTrwHJYu9rbHH260C0KYCNqmxDdcROUqIzJdzDKOrDmebkEVnxVeLJBIhYZUd t3Iq9hdjpU50TA6sQ3mZxzBdfRgg+vaj2DsJqI5Xla9QGKD+xNT6v14cZuIMZzO7w0DoojM4 ByrabFsOQxGvE0w9Dch2BDSI2Xyk1zjPKxG1VNBQVx3flH37QDWpL2zlJikW29Ws86PHdthh Fm5PY8YtX576DchSP6qJC57/eAAe/9ztZdVAdesQwGb9hZHJc75B+VNm4xrh/PJO6c1THqdQ 19WVJ+7rDx3PhVncGlbAOiiiE3NOFPJ1OQYxPKtpBUukAlOTnkKE6QcA4zckFepUkfmBV1wM Jg6OxFYd01z+a+oL Message-ID: <60f40558-a3a8-2c1e-2c32-09f93bfca724@oracle.com> Date: Sat, 8 Aug 2020 22:22:07 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200807083826.16794-4-jgross@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9707 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 mlxscore=0 adultscore=0 malwarescore=0 mlxlogscore=999 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008090013 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9707 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 priorityscore=1501 malwarescore=0 impostorscore=0 lowpriorityscore=0 mlxscore=0 bulkscore=0 suspectscore=0 phishscore=0 adultscore=0 spamscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008090013 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Thomas Gleixner , Stefano Stabellini , Borislav Petkov , Ingo Molnar , "H. Peter Anvin" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 8/7/20 4:38 AM, Juergen Gross wrote: > With support for 32-bit pv guests gone pure pv-code no longer needs to > test for highmem. Dropping those tests removes the need for flushing > in some places. > > Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky with a suggestion > --- > arch/x86/xen/enlighten_pv.c | 11 ++- > arch/x86/xen/mmu_pv.c | 138 ++++++++++++++----------------------= > 2 files changed, 57 insertions(+), 92 deletions(-) > > diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c > index 7d90b3da8bb4..9fec952f84f3 100644 > --- a/arch/x86/xen/enlighten_pv.c > +++ b/arch/x86/xen/enlighten_pv.c > @@ -347,6 +347,7 @@ static void set_aliased_prot(void *v, pgprot_t prot= ) > unsigned long pfn; > struct page *page; > unsigned char dummy; > + void *av; to rename this to va since you are modifying those lines anyway. > =20 > ptep =3D lookup_address((unsigned long)v, &level); > BUG_ON(ptep =3D=3D NULL); > @@ -383,14 +384,10 @@ static void set_aliased_prot(void *v, pgprot_t pr= ot) > if (HYPERVISOR_update_va_mapping((unsigned long)v, pte, 0)) > BUG(); > =20 > - if (!PageHighMem(page)) { > - void *av =3D __va(PFN_PHYS(pfn)); > + av =3D __va(PFN_PHYS(pfn)); > =20 From xen-devel-bounces@lists.xenproject.org Sun Aug 09 02:35:29 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 09 Aug 2020 02:35:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4bBB-00057G-NQ; Sun, 09 Aug 2020 02:35:21 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4bBA-00057B-Hp for xen-devel@lists.xenproject.org; Sun, 09 Aug 2020 02:35:20 +0000 X-Inumbo-ID: 1439a22e-a165-42e8-9f82-43a033626cfd Received: from userp2130.oracle.com (unknown [156.151.31.86]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1439a22e-a165-42e8-9f82-43a033626cfd; Sun, 09 Aug 2020 02:35:18 +0000 (UTC) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0792XvX2026168; Sun, 9 Aug 2020 02:35:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=6ZRtf8FS7xL94chgQEhL0kkialPRsW1/lgBWdpFkeLY=; b=gLSskbVPU/hnTzo16mBN+3izzI2KqatJ7h4zdzGkzah6ndd0ahT8tbPwjD61pUZv9uUv y1vE/7wpASwdwZwaNC1KeaetOvb8AqDOfioEZ92zOZKkumb9E9JYYWFU6WESgLGoZEAE LOj/wyjKqwGOFNs5o+UMPh1GUSaWu7MiNPazSyldJA1BwgRSQpic8lN5OeH7lIO7OiDZ XGpT/GgkUvqOtgpv2kiZ/5FaKbfxzVIlKTUVzeuagVswurLh8IjM0XFWiPcOcwDlJjRy uo5m8UOJ1M32zRpFWAxsyjp8ZBe3pTGHxGK7ojrXEuipijCoQGt+zsBp57Y/gG3QoUpA BQ== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 32t2yd8bpk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 09 Aug 2020 02:35:10 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0792XSPI088134; Sun, 9 Aug 2020 02:35:09 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3030.oracle.com with ESMTP id 32t5mjmsje-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 09 Aug 2020 02:35:09 +0000 Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 0792Z6GH028575; Sun, 9 Aug 2020 02:35:06 GMT Received: from [192.168.29.236] (/73.249.50.119) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 09 Aug 2020 02:35:06 +0000 Subject: Re: [PATCH v3 4/7] x86/paravirt: remove 32-bit support from PARAVIRT_XXL To: Juergen Gross , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org References: <20200807083826.16794-1-jgross@suse.com> <20200807083826.16794-5-jgross@suse.com> From: Boris Ostrovsky Autocrypt: addr=boris.ostrovsky@oracle.com; keydata= xsFNBFH8CgsBEAC0KiOi9siOvlXatK2xX99e/J3OvApoYWjieVQ9232Eb7GzCWrItCzP8FUV PQg8rMsSd0OzIvvjbEAvaWLlbs8wa3MtVLysHY/DfqRK9Zvr/RgrsYC6ukOB7igy2PGqZd+M MDnSmVzik0sPvB6xPV7QyFsykEgpnHbvdZAUy/vyys8xgT0PVYR5hyvhyf6VIfGuvqIsvJw5 C8+P71CHI+U/IhsKrLrsiYHpAhQkw+Zvyeml6XSi5w4LXDbF+3oholKYCkPwxmGdK8MUIdkM d7iYdKqiP4W6FKQou/lC3jvOceGupEoDV9botSWEIIlKdtm6C4GfL45RD8V4B9iy24JHPlom woVWc0xBZboQguhauQqrBFooHO3roEeM1pxXjLUbDtH4t3SAI3gt4dpSyT3EvzhyNQVVIxj2 FXnIChrYxR6S0ijSqUKO0cAduenhBrpYbz9qFcB/GyxD+ZWY7OgQKHUZMWapx5bHGQ8bUZz2 SfjZwK+GETGhfkvNMf6zXbZkDq4kKB/ywaKvVPodS1Poa44+B9sxbUp1jMfFtlOJ3AYB0WDS Op3d7F2ry20CIf1Ifh0nIxkQPkTX7aX5rI92oZeu5u038dHUu/dO2EcuCjl1eDMGm5PLHDSP 0QUw5xzk1Y8MG1JQ56PtqReO33inBXG63yTIikJmUXFTw6lLJwARAQABzTNCb3JpcyBPc3Ry b3Zza3kgKFdvcmspIDxib3Jpcy5vc3Ryb3Zza3lAb3JhY2xlLmNvbT7CwXgEEwECACIFAlH8 CgsCGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEIredpCGysGyasEP/j5xApopUf4g 9Fl3UxZuBx+oduuw3JHqgbGZ2siA3EA4bKwtKq8eT7ekpApn4c0HA8TWTDtgZtLSV5IdH+9z JimBDrhLkDI3Zsx2CafL4pMJvpUavhc5mEU8myp4dWCuIylHiWG65agvUeFZYK4P33fGqoaS VGx3tsQIAr7MsQxilMfRiTEoYH0WWthhE0YVQzV6kx4wj4yLGYPPBtFqnrapKKC8yFTpgjaK jImqWhU9CSUAXdNEs/oKVR1XlkDpMCFDl88vKAuJwugnixjbPFTVPyoC7+4Bm/FnL3iwlJVE qIGQRspt09r+datFzPqSbp5Fo/9m4JSvgtPp2X2+gIGgLPWp2ft1NXHHVWP19sPgEsEJXSr9 tskM8ScxEkqAUuDs6+x/ISX8wa5Pvmo65drN+JWA8EqKOHQG6LUsUdJolFM2i4Z0k40BnFU/ kjTARjrXW94LwokVy4x+ZYgImrnKWeKac6fMfMwH2aKpCQLlVxdO4qvJkv92SzZz4538az1T m+3ekJAimou89cXwXHCFb5WqJcyjDfdQF857vTn1z4qu7udYCuuV/4xDEhslUq1+GcNDjAhB nNYPzD+SvhWEsrjuXv+fDONdJtmLUpKs4Jtak3smGGhZsqpcNv8nQzUGDQZjuCSmDqW8vn2o hWwveNeRTkxh+2x1Qb3GT46uzsFNBFH8CgsBEADGC/yx5ctcLQlB9hbq7KNqCDyZNoYu1HAB Hal3MuxPfoGKObEktawQPQaSTB5vNlDxKihezLnlT/PKjcXC2R1OjSDinlu5XNGc6mnky03q yymUPyiMtWhBBftezTRxWRslPaFWlg/h/Y1iDuOcklhpr7K1h1jRPCrf1yIoxbIpDbffnuyz kuto4AahRvBU4Js4sU7f/btU+h+e0AcLVzIhTVPIz7PM+Gk2LNzZ3/on4dnEc/qd+ZZFlOQ4 KDN/hPqlwA/YJsKzAPX51L6Vv344pqTm6Z0f9M7YALB/11FO2nBB7zw7HAUYqJeHutCwxm7i BDNt0g9fhviNcJzagqJ1R7aPjtjBoYvKkbwNu5sWDpQ4idnsnck4YT6ctzN4I+6lfkU8zMzC gM2R4qqUXmxFIS4Bee+gnJi0Pc3KcBYBZsDK44FtM//5Cp9DrxRQOh19kNHBlxkmEb8kL/pw XIDcEq8MXzPBbxwHKJ3QRWRe5jPNpf8HCjnZz0XyJV0/4M1JvOua7IZftOttQ6KnM4m6WNIZ 2ydg7dBhDa6iv1oKdL7wdp/rCulVWn8R7+3cRK95SnWiJ0qKDlMbIN8oGMhHdin8cSRYdmHK kTnvSGJNlkis5a+048o0C6jI3LozQYD/W9wq7MvgChgVQw1iEOB4u/3FXDEGulRVko6xCBU4 SQARAQABwsFfBBgBAgAJBQJR/AoLAhsMAAoJEIredpCGysGyfvMQAIywR6jTqix6/fL0Ip8G jpt3uk//QNxGJE3ZkUNLX6N786vnEJvc1beCu6EwqD1ezG9fJKMl7F3SEgpYaiKEcHfoKGdh 30B3Hsq44vOoxR6zxw2B/giADjhmWTP5tWQ9548N4VhIZMYQMQCkdqaueSL+8asp8tBNP+TJ PAIIANYvJaD8xA7sYUXGTzOXDh2THWSvmEWWmzok8er/u6ZKdS1YmZkUy8cfzrll/9hiGCTj u3qcaOM6i/m4hqtvsI1cOORMVwjJF4+IkC5ZBoeRs/xW5zIBdSUoC8L+OCyj5JETWTt40+lu qoqAF/AEGsNZTrwHJYu9rbHH260C0KYCNqmxDdcROUqIzJdzDKOrDmebkEVnxVeLJBIhYZUd t3Iq9hdjpU50TA6sQ3mZxzBdfRgg+vaj2DsJqI5Xla9QGKD+xNT6v14cZuIMZzO7w0DoojM4 ByrabFsOQxGvE0w9Dch2BDSI2Xyk1zjPKxG1VNBQVx3flH37QDWpL2zlJikW29Ws86PHdthh Fm5PY8YtX576DchSP6qJC57/eAAe/9ztZdVAdesQwGb9hZHJc75B+VNm4xrh/PJO6c1THqdQ 19WVJ+7rDx3PhVncGlbAOiiiE3NOFPJ1OQYxPKtpBUukAlOTnkKE6QcA4zckFepUkfmBV1wM Jg6OxFYd01z+a+oL Message-ID: Date: Sat, 8 Aug 2020 22:34:50 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200807083826.16794-5-jgross@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9707 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 mlxscore=0 adultscore=0 malwarescore=0 mlxlogscore=999 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008090015 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9707 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 priorityscore=1501 malwarescore=0 impostorscore=0 lowpriorityscore=0 mlxscore=0 bulkscore=0 suspectscore=0 phishscore=0 adultscore=0 spamscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008090015 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Deep Shah , "VMware, Inc." , Ingo Molnar , Borislav Petkov , Andy Lutomirski , "H. Peter Anvin" , Thomas Gleixner Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 8/7/20 4:38 AM, Juergen Gross wrote: > @@ -377,10 +373,7 @@ static inline pte_t __pte(pteval_t val) > { > pteval_t ret; > > - if (sizeof(pteval_t) > sizeof(long)) > - ret = PVOP_CALLEE2(pteval_t, mmu.make_pte, val, (u64)val >> 32); > - else > - ret = PVOP_CALLEE1(pteval_t, mmu.make_pte, val); > + ret = PVOP_CALLEE1(pteval_t, mmu.make_pte, val); > > return (pte_t) { .pte = ret }; Can this now simply return (pte_t) ret? -boris From xen-devel-bounces@lists.xenproject.org Sun Aug 09 03:40:43 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 09 Aug 2020 03:40:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4cC7-0002Vs-GJ; Sun, 09 Aug 2020 03:40:23 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4cC5-0002VP-SK for xen-devel@lists.xenproject.org; Sun, 09 Aug 2020 03:40:21 +0000 X-Inumbo-ID: 35a13f65-a8ea-4fc5-a558-8bf0ac4749e1 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 35a13f65-a8ea-4fc5-a558-8bf0ac4749e1; Sun, 09 Aug 2020 03:40:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=215L9PCmUPFU9jHuxUwnfFnqAwj4n70ol/7vkWFW0U4=; b=WcIz4CIWujws657CAtCX6KVAd NOr7kEvpQWfcIAGhG+h7AM54oui9GfVR9175QGmHJ04RVKJbI0lWSMJxJOOJcqa+ZT1HE040/CDH0 UK9V5YZsqmA6ueyPsKXfKII/dbZg+mmSu3rRzURrQ662mpXQxItR955mQ4nkwhRrK50WQ=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4cBy-0006tc-BC; Sun, 09 Aug 2020 03:40:14 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k4cBx-0000Ed-T7; Sun, 09 Aug 2020 03:40:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k4cBx-0004JH-Ri; Sun, 09 Aug 2020 03:40:13 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 152535: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=4b696beee31fb927b8f3d10df8145486e089b06c X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sun, 09 Aug 2020 03:40:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152535 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/152535/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a version targeted for testing: libvirt 4b696beee31fb927b8f3d10df8145486e089b06c baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 29 days Failing since 151818 2020-07-11 04:18:52 Z 28 days 29 attempts Testing same since 152535 2020-08-08 04:20:24 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrea Bolognani Balázs Meskó Bastien Orivel Bihong Yu Binfeng Wu Boris Fiuczynski Côme Borsoi Daniel Henrique Barboza Daniel P. Berrange Daniel P. Berrangé Erik Skultety Fedora Weblate Translation Han Han Hao Wang Jean-Baptiste Holcroft Jianan Gao Jin Yan Jiri Denemark Ján Tomko Laine Stump Liao Pingfang Martin Kletzander Michal Privoznik Nikolay Shirokovskiy Paulo de Rezende Pinatti Pavel Hrdina Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Roman Bogorodskiy Ryan Schmidt Stefan Berger Szymon Scholz Wang Xin Weblate Yang Hang Yi Wang Yuri Chornoivan Zheng Chuan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 9072 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Aug 09 04:50:25 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 09 Aug 2020 04:50:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4dHY-00005T-MZ; Sun, 09 Aug 2020 04:50:04 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4dHX-0007zK-EA for xen-devel@lists.xenproject.org; Sun, 09 Aug 2020 04:50:03 +0000 X-Inumbo-ID: 90f091f2-0373-4788-918d-60ad035e9dc5 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 90f091f2-0373-4788-918d-60ad035e9dc5; Sun, 09 Aug 2020 04:49:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=dCp1yatos0tg9Gruu6fRd3mPoAnymJ+4j0we4jgi5u4=; b=YJjVL1I739F5hboq9S/E9Ytc1 suTwCkLVZADxbAzHZ7rzXgxWAHSyvLHZg1Gm3ckN5fvHAnC2E/gGEmefqrWsuATa1/ChGNwBTmXMN rCMw2icXwG/Gvtel1oOo+SDmBwnNYmrgd39UCy8CLgVMF8Gc5Zzc9dDyaa+nAVXi+7DeE=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4dHQ-0000Bk-DV; Sun, 09 Aug 2020 04:49:56 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k4dHP-0002mx-VG; Sun, 09 Aug 2020 04:49:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k4dHP-0000e3-UL; Sun, 09 Aug 2020 04:49:55 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 152533: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-boot:fail:regression linux-linus:test-amd64-i386-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-i386-libvirt:xen-boot:fail:regression linux-linus:test-amd64-i386-examine:reboot:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-boot:fail:regression linux-linus:test-amd64-i386-xl:xen-boot:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-boot:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:build-arm64-pvops:kernel-build:fail:regression linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking X-Osstest-Versions-This: linux=5631c5e0eb9035d92ceb20fcd9cdb7779a3f5cc7 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Sun, 09 Aug 2020 04:49:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152533 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/152533/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-boot/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-boot/dst_host fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-examine 8 reboot fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-boot/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-boot/dst_host fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-boot fail REGR. vs. 152332 build-arm64-pvops 6 kernel-build fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail like 152332 test-armhf-armhf-libvirt 14 saverestore-support-check fail like 152332 test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail like 152332 test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass version targeted for testing: linux 5631c5e0eb9035d92ceb20fcd9cdb7779a3f5cc7 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 8 days Failing since 152366 2020-08-01 20:49:34 Z 7 days 7 attempts Testing same since 152533 2020-08-07 18:11:29 Z 1 days 1 attempts ------------------------------------------------------------ 1764 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 218084 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Aug 09 06:41:34 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 09 Aug 2020 06:41:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4f17-0001On-WC; Sun, 09 Aug 2020 06:41:13 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4f16-0001Oi-K0 for xen-devel@lists.xenproject.org; Sun, 09 Aug 2020 06:41:12 +0000 X-Inumbo-ID: 427d1803-1ab4-4214-bc09-37a97a0b1282 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 427d1803-1ab4-4214-bc09-37a97a0b1282; Sun, 09 Aug 2020 06:41:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=qB9/0znosrPD08yFNbo8vjTY2CQ/zXSW2i+LLySDZ3U=; b=kTFs1ug3cqQ4oN6nh8rQLwNE3 vKyRnMqUnIbwkoF8IX1F9kBPQejk/hFEdC0OeFNEqAyFtSSJGQ6ftjGQSfMcClOdDVwbMBpy3o1Y4 vQEHpS04aOYD8+3UKglOeWpaexmz+jOW5z/r8O9T3u047I73sKxPLKi12t+WkXmKeAmc0=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4f13-0002xu-LP; Sun, 09 Aug 2020 06:41:09 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k4f12-0002o8-Sz; Sun, 09 Aug 2020 06:41:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k4f12-0007AK-R1; Sun, 09 Aug 2020 06:41:08 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 152536: all pass - PUSHED X-Osstest-Versions-This: ovmf=a3741780fe3535e19e02efa869a7cac481891129 X-Osstest-Versions-That: ovmf=9565ab67c2095a5ea893e63561a49aedf3387b8f From: osstest service owner Date: Sun, 09 Aug 2020 06:41:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152536 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/152536/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf a3741780fe3535e19e02efa869a7cac481891129 baseline version: ovmf 9565ab67c2095a5ea893e63561a49aedf3387b8f Last test of basis 152517 2020-08-07 09:02:31 Z 1 days Testing same since 152536 2020-08-08 05:47:10 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Bret Barkelew Bret Barkelew Michael D Kinney Pierre Gondois Sami Mujawar jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 9565ab67c2..a3741780fe a3741780fe3535e19e02efa869a7cac481891129 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sun Aug 09 08:33:30 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 09 Aug 2020 08:33:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4glP-0002pk-Qe; Sun, 09 Aug 2020 08:33:07 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4glO-0002of-KL for xen-devel@lists.xenproject.org; Sun, 09 Aug 2020 08:33:06 +0000 X-Inumbo-ID: f9388106-6047-4b2e-b8ef-2f978e5d15d7 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f9388106-6047-4b2e-b8ef-2f978e5d15d7; Sun, 09 Aug 2020 08:32:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=t7e1NhVIw0XFzLEBZQvQCMSvoieA0sVmYGcUDX0FpgI=; b=zuXBZ/2qxSpYGO5jlV8TwXYFi e0cpoqqJgQSHKOlxiWaacYq4lTudx6IFsfe/oSCQiAJnnW59ljb92pYyCpAFIxcDF4UdB7ghXcYyJ E+jQp8l23r8x5bDQn0ycIjmseiSFI4OH5C/Kb+t/L9AI6Ij3PgmK2ovV/FoopsGaPeXp0=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4glF-00061k-MD; Sun, 09 Aug 2020 08:32:57 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k4glF-0007z6-C4; Sun, 09 Aug 2020 08:32:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k4glF-0006Vk-Ap; Sun, 09 Aug 2020 08:32:57 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 152534: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-examine:memdisk-try-append:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking X-Osstest-Versions-This: xen=90c7eee53fcc0b48bd51aa3a7d1d0d9980ce1a7a X-Osstest-Versions-That: xen=b2bc1e714462c6cc222e3bbc38d87b039b4fa405 From: osstest service owner Date: Sun, 09 Aug 2020 08:32:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152534 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/152534/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-examine 4 memdisk-try-append fail like 152498 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail like 152511 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail like 152511 test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail like 152511 test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail like 152511 test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 152511 test-armhf-armhf-libvirt 14 saverestore-support-check fail like 152511 test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail like 152511 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail like 152511 test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail like 152511 test-amd64-i386-xl-pvshim 12 guest-start fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass version targeted for testing: xen 90c7eee53fcc0b48bd51aa3a7d1d0d9980ce1a7a baseline version: xen b2bc1e714462c6cc222e3bbc38d87b039b4fa405 Last test of basis 152511 2020-08-07 03:39:55 Z 2 days Testing same since 152534 2020-08-08 01:09:27 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git b2bc1e7144..90c7eee53f 90c7eee53fcc0b48bd51aa3a7d1d0d9980ce1a7a -> master From xen-devel-bounces@lists.xenproject.org Sun Aug 09 10:17:20 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 09 Aug 2020 10:17:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4iNy-00031o-Rt; Sun, 09 Aug 2020 10:17:02 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4iNx-00031U-LJ for xen-devel@lists.xenproject.org; Sun, 09 Aug 2020 10:17:01 +0000 X-Inumbo-ID: 0d39a234-a712-4b98-a2ca-1fcf1a469b7a Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0d39a234-a712-4b98-a2ca-1fcf1a469b7a; Sun, 09 Aug 2020 10:16:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=x9oQZOhsUuivOAXtX7gebMY25vLOk8PEVPEAb75CbB8=; b=1U8y4LfG3Iqo3uhIs17njxWex 0TWEzoz5fBEBFMTZqmErSuYJtCnPqSWeSLTOJNMVstq0Dr8qm955NDPLPklUmxpVg+CQH0l07ItrN T9WN72u4hs17dNatXo3ZFdSCQmdQScN9yYVo0Ler8ruQgUUU2wN+LeenwFWI61tDRKp7w=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4iNp-0008M1-Ef; Sun, 09 Aug 2020 10:16:53 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k4iNp-0004g8-1X; Sun, 09 Aug 2020 10:16:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k4iNp-0007qf-13; Sun, 09 Aug 2020 10:16:53 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 152539: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=b94cde18fffe9efe2513e6bb2f281ca2b9756489 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sun, 09 Aug 2020 10:16:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152539 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/152539/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt b94cde18fffe9efe2513e6bb2f281ca2b9756489 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 30 days Failing since 151818 2020-07-11 04:18:52 Z 29 days 30 attempts Testing same since 152539 2020-08-09 04:21:40 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrea Bolognani Balázs Meskó Bastien Orivel Bihong Yu Binfeng Wu Boris Fiuczynski Côme Borsoi Daniel Henrique Barboza Daniel P. Berrange Daniel P. Berrangé Erik Skultety Fedora Weblate Translation Han Han Hao Wang Jean-Baptiste Holcroft Jianan Gao Jin Yan Jiri Denemark Ján Tomko Laine Stump Liao Pingfang Martin Kletzander Michal Privoznik Nikolay Shirokovskiy Paulo de Rezende Pinatti Pavel Hrdina Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Roman Bogorodskiy Ryan Schmidt Stefan Berger Szymon Scholz Wang Xin Weblate Yang Hang Yi Wang Yuri Chornoivan Zheng Chuan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 9126 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Aug 09 10:17:20 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 09 Aug 2020 10:17:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4iO4-00032n-9S; Sun, 09 Aug 2020 10:17:08 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4iO3-00032f-Oz for xen-devel@lists.xenproject.org; Sun, 09 Aug 2020 10:17:07 +0000 X-Inumbo-ID: ce537349-fdce-4b7d-9fca-0d7de0236493 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ce537349-fdce-4b7d-9fca-0d7de0236493; Sun, 09 Aug 2020 10:17:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=P0bUMA6z1R9U9Bdj4emisFkOg4Wa9YaIYWUUjvnVf3s=; b=6GZJa4sNlGeVZm812jH3ztJTG aQPSEG5zVTpcHmLgKA0Ur0+IYw8aDUehhLZ+Np8BR5q4CXV8lu04zIQMjBuw16zF93pAIxE4MwjLu KeyrTdJWyJ/HBVIUCSmIUL8vPbvTde/I6Uy/6HghgHjYfA0Q4WAkeuWQUhQH49FU+BhNo=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4iO1-0008Mm-Pj; Sun, 09 Aug 2020 10:17:05 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k4iO1-0004gU-Gw; Sun, 09 Aug 2020 10:17:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k4iO1-0007sI-GU; Sun, 09 Aug 2020 10:17:05 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-coverity test] 152543: all pass - PUSHED X-Osstest-Versions-This: xen=90c7eee53fcc0b48bd51aa3a7d1d0d9980ce1a7a X-Osstest-Versions-That: xen=c9f9a7258dc07735e2da2b6d0b51a0218c76a51f From: osstest service owner Date: Sun, 09 Aug 2020 10:17:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152543 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/152543/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 90c7eee53fcc0b48bd51aa3a7d1d0d9980ce1a7a baseline version: xen c9f9a7258dc07735e2da2b6d0b51a0218c76a51f Last test of basis 152488 2020-08-05 09:18:39 Z 4 days Testing same since 152543 2020-08-09 09:18:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: coverity-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git c9f9a7258d..90c7eee53f 90c7eee53fcc0b48bd51aa3a7d1d0d9980ce1a7a -> coverity-tested/smoke From xen-devel-bounces@lists.xenproject.org Sun Aug 09 11:15:08 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 09 Aug 2020 11:15:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4jI1-00089V-R8; Sun, 09 Aug 2020 11:14:57 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4jI0-000895-Gb for xen-devel@lists.xenproject.org; Sun, 09 Aug 2020 11:14:56 +0000 X-Inumbo-ID: 6b4fbc49-fe59-405c-8400-ecba21e77438 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6b4fbc49-fe59-405c-8400-ecba21e77438; Sun, 09 Aug 2020 11:14:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=0ViL4Scvv/H34R/46yLh/Kaac2QKSjlwUV3tjtvDapA=; b=zofDK8mMMsrgZePIN8nD/cJyE e2NkPal4AbeLOfw+VpJDsqsrOAepPBet3FJm20nB2OybOkDYer9hQsjfIBJtZjRxHqGG1BgJNiARn be3NQDmqVWjxTOaqKOrLYvsTgbuRp65xy0ZDfNcujb9YYyZD6IbcoX1DR/MLQgdmBmw/g=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4jHs-0001Dj-Ek; Sun, 09 Aug 2020 11:14:48 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k4jHs-0006W0-1K; Sun, 09 Aug 2020 11:14:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k4jHs-0002De-0K; Sun, 09 Aug 2020 11:14:48 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.14-testing test] 152537: regressions - FAIL X-Osstest-Failures: xen-4.14-testing:test-amd64-i386-libvirt:guest-start/debian.repeat:fail:regression xen-4.14-testing:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking X-Osstest-Versions-This: xen=c3a0fc22af90ef28e68b116c6a49d9cec57f71cf X-Osstest-Versions-That: xen=456957aaa1391e0dfa969e2dd97b87c51a79444e From: osstest service owner Date: Sun, 09 Aug 2020 11:14:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152537 xen-4.14-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/152537/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt 18 guest-start/debian.repeat fail REGR. vs. 152153 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 16 guest-start/debian.repeat fail like 152153 test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 12 guest-start fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail never pass test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail never pass version targeted for testing: xen c3a0fc22af90ef28e68b116c6a49d9cec57f71cf baseline version: xen 456957aaa1391e0dfa969e2dd97b87c51a79444e Last test of basis 152153 2020-07-23 15:18:22 Z 16 days Testing same since 152531 2020-08-07 15:39:18 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Fam Zheng Jan Beulich Paul Durrant jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit c3a0fc22af90ef28e68b116c6a49d9cec57f71cf Author: Jan Beulich Date: Fri Aug 7 17:11:44 2020 +0200 x86: comment update after "drop high compat r/o M2P table address range" Commit 5af040ef8b57 clearly should also have updated the comment, not just the #define-s. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper master commit: 2e98d0b1d09e99e3d1287cb13f42b604ebc3c29a master date: 2020-08-05 10:21:22 +0200 commit 864d5701ec5dc5af028d415e86bf5cf6aaed3a7c Author: Paul Durrant Date: Fri Aug 7 17:11:10 2020 +0200 x86/hvm: set 'ipat' in EPT for special pages All non-MMIO ranges (i.e those not mapping real device MMIO regions) that map valid MFNs are normally marked MTRR_TYPE_WRBACK and 'ipat' is set. Hence when PV drivers running in a guest populate the BAR space of the Xen Platform PCI Device with pages such as the Shared Info page or Grant Table pages, accesses to these pages will be cachable. However, should IOMMU mappings be enabled be enabled for the guest then these accesses become uncachable. This has a substantial negative effect on I/O throughput of PV devices. Arguably PV drivers should bot be using BAR space to host the Shared Info and Grant Table pages but it is currently commonplace for them to do this and so this problem needs mitigation. Hence this patch makes sure the 'ipat' bit is set for any special page regardless of where in GFN space it is mapped. NOTE: Clearly this mitigation only applies to Intel EPT. It is not obvious that there is any similar mitigation possible for AMD NPT. Downstreams such as Citrix XenServer have been carrying a patch similar to this for several releases though. Signed-off-by: Paul Durrant Reviewed-by: Jan Beulich master commit: ca24b2ffdbd9a25b2d313a547ccbe97baf3e5a8d master date: 2020-07-31 17:42:47 +0200 commit afed8e4365f0dec26a040ea0670b654e00d8c869 Author: Jan Beulich Date: Fri Aug 7 17:10:34 2020 +0200 x86emul: replace UB shifts Displacement values can be negative, hence we shouldn't left-shift them. Or else we get (XEN) UBSAN: Undefined behaviour in x86_emulate/x86_emulate.c:3482:55 (XEN) left shift of negative value -2 While auditing shifts, I noticed a pair of missing parentheses, which also get added right here. Reported-by: Andrew Cooper Signed-off-by: Jan Beulich Acked-by: Andrew Cooper Tested-by: Andrew Cooper x86: comment update after "drop high compat r/o M2P table address range" Commit 5af040ef8b57 clearly should also have updated the comment, not just the #define-s. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper master commit: b6a907f8c83d37886d0523f1aeff61b98e133498 master date: 2020-07-31 17:41:58 +0200 master commit: 2e98d0b1d09e99e3d1287cb13f42b604ebc3c29a master date: 2020-08-05 10:21:22 +0200 commit a5dab0a2453da1e15fd49e6a7fa9138e333ba9af Author: Fam Zheng Date: Fri Aug 7 17:09:51 2020 +0200 x86/cpuid: Fix APIC bit clearing The bug is obvious here, other places in this function used "cpufeat_mask" correctly. Fixed: b648feff8ea2 ("xen/x86: Improvements to in-hypervisor cpuid sanity checks") Signed-off-by: Fam Zheng Reviewed-by: Roger Pau Monné Reviewed-by: Andrew Cooper master commit: 64219fa179c3e48adad12bfce3f6b3f1596cccbf master date: 2020-07-29 19:03:41 +0100 commit b8c3e33a4fe4374f633b4369200731662ff1f750 Author: Jan Beulich Date: Fri Aug 7 17:09:19 2020 +0200 x86/S3: put data segment registers into known state upon resume wakeup_32 sets %ds and %es to BOOT_DS, while leaving %fs at what wakeup_start did set it to, and %gs at whatever BIOS did load into it. All of this may end up confusing the first load_segments() to run on the BSP after resume, in particular allowing a non-nul selector value to be left in %fs. Alongside %ss, also put all other data segment registers into the same state that the boot and CPU bringup paths put them in. Reported-by: M. Vefa Bicakci Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné Reviewed-by: Andrew Cooper master commit: 55f8c389d4348cc517946fdcb10794112458e81e master date: 2020-07-24 10:17:26 +0200 commit f836759a7bbf095dc5b1f31a069296bcfd694b82 Author: Jan Beulich Date: Fri Aug 7 17:07:56 2020 +0200 update Xen version to 4.14.1-pre (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Sun Aug 09 16:30:34 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 09 Aug 2020 16:30:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4oD8-0001lC-05; Sun, 09 Aug 2020 16:30:14 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4oD7-0001ks-Bn for xen-devel@lists.xenproject.org; Sun, 09 Aug 2020 16:30:13 +0000 X-Inumbo-ID: d56311d7-6b91-416f-a4d5-6f5e9dea2802 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d56311d7-6b91-416f-a4d5-6f5e9dea2802; Sun, 09 Aug 2020 16:30:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=FrK351Pivaqj6I7j6TINgmLk4tZQ5klY9Sa3Q3A558A=; b=lxdFhJF/kB1NSY3sw3rLtTO1S gLatB42itGB8OWxOB7evQzEPmR18vCPkTyklYowtUyO42SIr2W7P/M3KCxTKhBYaYpajJORj4KCHd 4RPnvXJYYq51zmhIl+p4aA9hJG4UOHDs3gx0Rm8ZEromy1To2aGeIIPZwEnnqZn0A9RFo=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4oCy-0000Fd-OZ; Sun, 09 Aug 2020 16:30:04 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k4oCy-0001rO-9p; Sun, 09 Aug 2020 16:30:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k4oCy-0001Eu-9B; Sun, 09 Aug 2020 16:30:04 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 152540: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-boot:fail:regression linux-linus:test-amd64-i386-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-i386-libvirt:xen-boot:fail:regression linux-linus:test-amd64-i386-examine:reboot:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-xl:xen-boot:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-boot:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:guest-start/debian.repeat:fail:regression linux-linus:test-amd64-amd64-examine:memdisk-try-append:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-saverestore:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking X-Osstest-Versions-This: linux=06a81c1c7db9bd5de0bd38cd5acc44bb22b99150 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Sun, 09 Aug 2020 16:30:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152540 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/152540/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-boot/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-boot/dst_host fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-examine 8 reboot fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-boot/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-boot/dst_host fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-boot fail REGR. vs. 152332 test-arm64-arm64-libvirt-xsm 16 guest-start/debian.repeat fail REGR. vs. 152332 test-amd64-amd64-examine 4 memdisk-try-append fail REGR. vs. 152332 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 15 guest-saverestore fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail like 152332 test-armhf-armhf-libvirt 14 saverestore-support-check fail like 152332 test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail like 152332 test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass version targeted for testing: linux 06a81c1c7db9bd5de0bd38cd5acc44bb22b99150 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 8 days Failing since 152366 2020-08-01 20:49:34 Z 7 days 8 attempts Testing same since 152540 2020-08-09 04:52:34 Z 0 days 1 attempts ------------------------------------------------------------ 1897 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 238734 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Aug 09 18:23:23 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 09 Aug 2020 18:23:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4pyI-0002ig-SU; Sun, 09 Aug 2020 18:23:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4pyI-0002ib-7b for xen-devel@lists.xenproject.org; Sun, 09 Aug 2020 18:23:02 +0000 X-Inumbo-ID: 5d882930-4d2b-4426-bd3e-6e20fc95902b Received: from mail-qk1-x744.google.com (unknown [2607:f8b0:4864:20::744]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5d882930-4d2b-4426-bd3e-6e20fc95902b; Sun, 09 Aug 2020 18:23:01 +0000 (UTC) Received: by mail-qk1-x744.google.com with SMTP id p25so6478539qkp.2 for ; Sun, 09 Aug 2020 11:23:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=UdJzhXUqKipeiiWy8QBA1srJWv+WaepWTdw1sLK832U=; b=eXls3dRI6vK/fxRZ62BINomD3eew55PTT21kF6VO97Fkby1EYA168vkHhrN5ekkAWW nwwIzdxHDnuEMIXmhgJy/MW8JYAhoGQDXJczCqUSHLjqV+INzCTGkMF1tOq+r38F2ASs eR3xYnF4XrBvm/xXOpKNZ8ba83QHAVsslqfWPg+RiENrbVDgVCIqGtk52hIGEpWGYMqi PQV5ZBlK4Y2+D+vOqiC8mN1C3+U/sR+nkVfxKUZFp3FvRpHtDz45H+myzw52UeNscb4t kQdIxLfDybp3E0uBiuoPbv3pWdUBXypL6h3pod9YAH5K12cs419OeFJlY4DGL9b5g8qc 9YIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=UdJzhXUqKipeiiWy8QBA1srJWv+WaepWTdw1sLK832U=; b=LQTcveFIdZIOzeLXBQ7AuFe3JrkV4br6FjO7gosTDwsxcJN9AtHnyidd9lQu7B/9nK 1KbIpwjxalM7rhLKzyuvCzVc1fVD0h1oE0GMohUj9hVz5crdCJNVvSRaE1vlWOGRR+aV gNIdoXoY+h0MrhNed5gZT2XHxWtSy9dN8H5G5fKzYw7tWidmqu3h8ab475HOAKdmlB3L 0b9K7Q64xLoAIkzMqvUpmtGXgNKEnOcHSLGb7ZePK6qS48L10tDKe5zUgiCooZJnCaPW 1cJ6251QjXkrOll+GBufgSsTXoDVwjuEbDA8alEu+hNOJJCfJFGJdDFIcN0bSyfNfkCF vYEg== X-Gm-Message-State: AOAM532RUEUvuhnJ1/7OB8DgGhR0r6aVkapzxpYPzoc0idbsdcDhuuIp iVi8/Mo35IEUD/nino6pdk6sePPtM30= X-Google-Smtp-Source: ABdhPJzwc0CCC8V/nQ1uPQ0Ixsaef2NvhgThpZmjAQ9hFaTWRWm35zPu2a2pQIO/hLu0OUrcfPbCLQ== X-Received: by 2002:a37:a851:: with SMTP id r78mr22478118qke.419.1596997380598; Sun, 09 Aug 2020 11:23:00 -0700 (PDT) Received: from TestCloud1.zatium.us (pool-96-230-225-98.bstnma.fios.verizon.net. [96.230.225.98]) by smtp.googlemail.com with ESMTPSA id l13sm13188231qth.77.2020.08.09.11.22.59 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 09 Aug 2020 11:23:00 -0700 (PDT) From: Don Slutz X-Google-Original-From: Don Slutz X-Mailer: git-send-email 1.8.3.1 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Ian Jackson , Don Slutz , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Don Slutz Also prevent warning: directory /boot: remove failed Before: [root@TestCloud1 xen]# rpm -hiv dist/xen*rpm Preparing... ################################# [100%] file /boot from install of xen-4.15-unstable.x86_64 conflicts with file from package filesystem-3.2-25.el7.x86_64 file /usr/bin from install of xen-4.15-unstable.x86_64 conflicts with file from package filesystem-3.2-25.el7.x86_64 file /usr/lib from install of xen-4.15-unstable.x86_64 conflicts with file from package filesystem-3.2-25.el7.x86_64 file /usr/lib64 from install of xen-4.15-unstable.x86_64 conflicts with file from package filesystem-3.2-25.el7.x86_64 file /usr/sbin from install of xen-4.15-unstable.x86_64 conflicts with file from package filesystem-3.2-25.el7.x86_64 [root@TestCloud1 xen]# rpm -e xen warning: directory /boot: remove failed: Device or resource busy After: [root@TestCloud1 xen]# rpm -hiv dist/xen*rpm Preparing... ################################# [100%] Updating / installing... 1:xen-4.15-unstable ################################# [100%] [root@TestCloud1 xen]# rpm -e xen [root@TestCloud1 xen]# Signed-off-by: Don Slutz --- tools/misc/mkrpm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/misc/mkrpm b/tools/misc/mkrpm index ae40e1a..68819b2 100644 --- a/tools/misc/mkrpm +++ b/tools/misc/mkrpm @@ -62,7 +62,8 @@ rm -rf \$RPM_BUILD_ROOT %files %defattr(-,root,root,-) -/* +/*/*/* +/boot/* %post EOF -- 1.8.3.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 10 00:23:40 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 00:23:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4var-00089K-Bp; Mon, 10 Aug 2020 00:23:13 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4vap-00089D-8V for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 00:23:11 +0000 X-Inumbo-ID: 58927d10-fe9a-4bba-98a3-72bef3b01530 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 58927d10-fe9a-4bba-98a3-72bef3b01530; Mon, 10 Aug 2020 00:23:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=aMtKtkhl92m1iEqajHgo6rzlVCvIcvYDot3qoLNrGlE=; b=DUxopdzslzpdiJu1MlTLwS1Cj gCBMvpaLHuVcvCTZuyYHfSRVBoegsvKwTglWCGZMO64yUf75knxmo3cMUH1MEA/e7e5HITwPd0F4r f/JsX2w6APkqQOmF+M2UtZpmWa/m0EuYqJ7n/DKrml6OdHbVDVW6pd8aJmHVvHHbNzsD0=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4val-0002yq-Lp; Mon, 10 Aug 2020 00:23:07 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k4val-0003M3-5t; Mon, 10 Aug 2020 00:23:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k4val-0006A1-5H; Mon, 10 Aug 2020 00:23:07 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 152542: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking X-Osstest-Versions-This: xen=90c7eee53fcc0b48bd51aa3a7d1d0d9980ce1a7a X-Osstest-Versions-That: xen=90c7eee53fcc0b48bd51aa3a7d1d0d9980ce1a7a From: osstest service owner Date: Mon, 10 Aug 2020 00:23:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152542 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/152542/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-examine 4 memdisk-try-append fail in 152534 pass in 152542 test-armhf-armhf-xl-rtds 16 guest-start/debian.repeat fail pass in 152534 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail like 152534 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail like 152534 test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail like 152534 test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail like 152534 test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 152534 test-armhf-armhf-libvirt 14 saverestore-support-check fail like 152534 test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail like 152534 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail like 152534 test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail like 152534 test-amd64-i386-xl-pvshim 12 guest-start fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass version targeted for testing: xen 90c7eee53fcc0b48bd51aa3a7d1d0d9980ce1a7a baseline version: xen 90c7eee53fcc0b48bd51aa3a7d1d0d9980ce1a7a Last test of basis 152542 2020-08-09 08:34:48 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon Aug 10 01:49:57 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 01:49:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4wwT-000300-O9; Mon, 10 Aug 2020 01:49:37 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4wwS-0002zv-9f for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 01:49:36 +0000 X-Inumbo-ID: 5782b038-32be-4b7a-8fce-1eea1ce88b44 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5782b038-32be-4b7a-8fce-1eea1ce88b44; Mon, 10 Aug 2020 01:49:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=D039d4nSSMlLkCpNw2UuOhIZGwj0J5oVVexWXuNHbiU=; b=3pGuGs+F9JqLHNQUlwLTXJoEA tTaZ53N0/x5tURfjvqb1SDNHYtdW4MLuX50OtpgH56B0FQa6QcDbZvGgb5YYuOB+Wl/sOCe1iqAQR vzItN5wWKQuxaDmJ0GbxXmzcJIsb6mJQ6drSN/EPVlnBEVhfqrFkeIancb4IjWsLdp+KU=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4wwO-0001Vk-GE; Mon, 10 Aug 2020 01:49:32 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k4wwO-0005lt-4V; Mon, 10 Aug 2020 01:49:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k4wwO-000610-1d; Mon, 10 Aug 2020 01:49:32 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.14-testing test] 152545: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.14-testing:test-amd64-i386-libvirt:guest-start/debian.repeat:fail:heisenbug xen-4.14-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-4.14-testing:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:heisenbug xen-4.14-testing:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking X-Osstest-Versions-This: xen=c3a0fc22af90ef28e68b116c6a49d9cec57f71cf X-Osstest-Versions-That: xen=456957aaa1391e0dfa969e2dd97b87c51a79444e From: osstest service owner Date: Mon, 10 Aug 2020 01:49:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152545 xen-4.14-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/152545/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt 18 guest-start/debian.repeat fail in 152537 pass in 152545 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 10 debian-hvm-install fail pass in 152537 test-armhf-armhf-xl-vhd 15 guest-start/debian.repeat fail pass in 152537 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 16 guest-start/debian.repeat fail in 152537 like 152153 test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 12 guest-start fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail never pass version targeted for testing: xen c3a0fc22af90ef28e68b116c6a49d9cec57f71cf baseline version: xen 456957aaa1391e0dfa969e2dd97b87c51a79444e Last test of basis 152153 2020-07-23 15:18:22 Z 17 days Testing same since 152531 2020-08-07 15:39:18 Z 2 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Fam Zheng Jan Beulich Paul Durrant jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 456957aaa1..c3a0fc22af c3a0fc22af90ef28e68b116c6a49d9cec57f71cf -> stable-4.14 From xen-devel-bounces@lists.xenproject.org Mon Aug 10 04:36:56 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 04:36:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4zY6-0001Sy-8Q; Mon, 10 Aug 2020 04:36:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4zY4-0001St-IB for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 04:36:36 +0000 X-Inumbo-ID: 9a1e2a81-7f90-4ad3-b82e-16ed8e1a936e Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9a1e2a81-7f90-4ad3-b82e-16ed8e1a936e; Mon, 10 Aug 2020 04:36:35 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 11E5CABE2; Mon, 10 Aug 2020 04:36:54 +0000 (UTC) Subject: Re: [PATCH v3 1/7] x86/xen: remove 32-bit Xen PV guest support To: Boris Ostrovsky , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org References: <20200807083826.16794-1-jgross@suse.com> <20200807083826.16794-2-jgross@suse.com> <893bc936-81bf-1e86-8423-a61fbfb5dc02@oracle.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <8dc06c59-54a5-8716-5e26-ec1442aaadd4@suse.com> Date: Mon, 10 Aug 2020 06:36:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <893bc936-81bf-1e86-8423-a61fbfb5dc02@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Ingo Molnar , Borislav Petkov , Andy Lutomirski , "H. Peter Anvin" , Thomas Gleixner Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 09.08.20 04:01, Boris Ostrovsky wrote: > On 8/7/20 4:38 AM, Juergen Gross wrote: >> >> void __init xen_reserve_top(void) >> { >> -#ifdef CONFIG_X86_32 >> - unsigned long top = HYPERVISOR_VIRT_START; >> - struct xen_platform_parameters pp; >> - >> - if (HYPERVISOR_xen_version(XENVER_platform_parameters, &pp) == 0) >> - top = pp.virt_start; >> - >> - reserve_top_address(-top); >> -#endif /* CONFIG_X86_32 */ >> } >> > > > We should be able now to get rid of xen_reserve_top() altogether. Oh, yes. > > > Other than that > > > Reviewed-by: Boris Ostrovsky Thanks, Juergen From xen-devel-bounces@lists.xenproject.org Mon Aug 10 04:37:02 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 04:37:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4zYU-0001Vs-Hj; Mon, 10 Aug 2020 04:37:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4zYT-0001V9-En for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 04:37:01 +0000 X-Inumbo-ID: 27ce598d-ce4b-4ee0-a72b-100320c92d83 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 27ce598d-ce4b-4ee0-a72b-100320c92d83; Mon, 10 Aug 2020 04:37:00 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DAF34ABE2; Mon, 10 Aug 2020 04:37:19 +0000 (UTC) Subject: Re: [PATCH v3 2/7] x86/xen: eliminate xen-asm_64.S To: Boris Ostrovsky , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org References: <20200807083826.16794-1-jgross@suse.com> <20200807083826.16794-3-jgross@suse.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <7358d7c4-37a6-c304-e569-bd7069884681@suse.com> Date: Mon, 10 Aug 2020 06:36:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Thomas Gleixner , Stefano Stabellini , Borislav Petkov , Ingo Molnar , "H. Peter Anvin" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 09.08.20 04:04, Boris Ostrovsky wrote: > On 8/7/20 4:38 AM, Juergen Gross wrote: >> With 32-bit pv-guest support removed xen-asm_64.S can be merged with >> xen-asm.S >> >> Signed-off-by: Juergen Gross > > > Reviewed-by: Boris Ostrovsky > > > except for > > >> diff --git a/arch/x86/xen/xen-asm.S b/arch/x86/xen/xen-asm.S >> index c59d077510bf..d1272a63f097 100644 >> --- a/arch/x86/xen/xen-asm.S >> +++ b/arch/x86/xen/xen-asm.S >> @@ -6,12 +6,19 @@ >> * operations here; the indirect forms are better handled in C. >> */ >> >> +#include >> #include >> #include >> #include >> +#include >> +#include >> +#include >> #include >> #include > > > asm/asm.h included twice now. Right, will drop that. Juergen From xen-devel-bounces@lists.xenproject.org Mon Aug 10 04:37:36 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 04:37:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4zZ2-0001Zf-RW; Mon, 10 Aug 2020 04:37:36 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4zZ1-0001ZX-UP for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 04:37:35 +0000 X-Inumbo-ID: d015c87b-02de-4088-aa5e-20b7ad5c27b6 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d015c87b-02de-4088-aa5e-20b7ad5c27b6; Mon, 10 Aug 2020 04:37:35 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 57B1FABE2; Mon, 10 Aug 2020 04:37:54 +0000 (UTC) Subject: Re: [PATCH v3 3/7] x86/xen: drop tests for highmem in pv code To: Boris Ostrovsky , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org References: <20200807083826.16794-1-jgross@suse.com> <20200807083826.16794-4-jgross@suse.com> <60f40558-a3a8-2c1e-2c32-09f93bfca724@oracle.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Mon, 10 Aug 2020 06:37:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <60f40558-a3a8-2c1e-2c32-09f93bfca724@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Thomas Gleixner , Stefano Stabellini , Borislav Petkov , Ingo Molnar , "H. Peter Anvin" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 09.08.20 04:22, Boris Ostrovsky wrote: > On 8/7/20 4:38 AM, Juergen Gross wrote: >> With support for 32-bit pv guests gone pure pv-code no longer needs to >> test for highmem. Dropping those tests removes the need for flushing >> in some places. >> >> Signed-off-by: Juergen Gross > > > Reviewed-by: Boris Ostrovsky > > > with a suggestion > > >> --- >> arch/x86/xen/enlighten_pv.c | 11 ++- >> arch/x86/xen/mmu_pv.c | 138 ++++++++++++++---------------------- >> 2 files changed, 57 insertions(+), 92 deletions(-) >> >> diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c >> index 7d90b3da8bb4..9fec952f84f3 100644 >> --- a/arch/x86/xen/enlighten_pv.c >> +++ b/arch/x86/xen/enlighten_pv.c >> @@ -347,6 +347,7 @@ static void set_aliased_prot(void *v, pgprot_t prot) >> unsigned long pfn; >> struct page *page; >> unsigned char dummy; >> + void *av; > > > to rename this to va since you are modifying those lines anyway. Yes. Juergen From xen-devel-bounces@lists.xenproject.org Mon Aug 10 04:39:48 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 04:39:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4zbA-0001n0-D5; Mon, 10 Aug 2020 04:39:48 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k4zb9-0001ms-Ai for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 04:39:47 +0000 X-Inumbo-ID: 66f69e93-db95-43e3-afdf-13ba93e3f3e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 66f69e93-db95-43e3-afdf-13ba93e3f3e4; Mon, 10 Aug 2020 04:39:45 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E1653ABE2; Mon, 10 Aug 2020 04:40:04 +0000 (UTC) Subject: Re: [PATCH v3 4/7] x86/paravirt: remove 32-bit support from PARAVIRT_XXL To: Boris Ostrovsky , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org References: <20200807083826.16794-1-jgross@suse.com> <20200807083826.16794-5-jgross@suse.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <4c5fb964-6acb-6bb8-4eff-0bcb67d922f2@suse.com> Date: Mon, 10 Aug 2020 06:39:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Deep Shah , "VMware, Inc." , Ingo Molnar , Borislav Petkov , Andy Lutomirski , "H. Peter Anvin" , Thomas Gleixner Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 09.08.20 04:34, Boris Ostrovsky wrote: > On 8/7/20 4:38 AM, Juergen Gross wrote: >> @@ -377,10 +373,7 @@ static inline pte_t __pte(pteval_t val) >> { >> pteval_t ret; >> >> - if (sizeof(pteval_t) > sizeof(long)) >> - ret = PVOP_CALLEE2(pteval_t, mmu.make_pte, val, (u64)val >> 32); >> - else >> - ret = PVOP_CALLEE1(pteval_t, mmu.make_pte, val); >> + ret = PVOP_CALLEE1(pteval_t, mmu.make_pte, val); >> >> return (pte_t) { .pte = ret }; > > > Can this now simply return (pte_t) ret? I don't think so, but I can turn it into return native_make_pte(PVOP_CALLEE1(...)); Juergen From xen-devel-bounces@lists.xenproject.org Mon Aug 10 06:43:06 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 06:43:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k51W9-0004VC-CK; Mon, 10 Aug 2020 06:42:45 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k51W7-0004V6-W0 for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 06:42:44 +0000 X-Inumbo-ID: c3094bd9-23eb-4162-a7eb-0b4b247a98a9 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c3094bd9-23eb-4162-a7eb-0b4b247a98a9; Mon, 10 Aug 2020 06:42:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=PTU6R70wQ5WhDDXPvnvV3ZAyO4saJa57YN8lgC61Lf4=; b=cJELD0svaKcylsy1hLvvNXgYB Jf8WbEkeCOiIBwkczk+LnCikzAXohc2TjWTC4SLTMgPqX4ULU11oFAc93euqlg2cIPnEz4PTl3UXJ X5YfMYhiE2/MWpBbjgAPUoSjJvF5pNYawO3AwzJuAa7nNnGJ+IQ8gXJC8ueR0Sks3H6zE=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k51W4-0000vt-8z; Mon, 10 Aug 2020 06:42:40 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k51W3-0008Uo-Qu; Mon, 10 Aug 2020 06:42:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k51W3-0001Fq-QH; Mon, 10 Aug 2020 06:42:39 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 152549: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=b94cde18fffe9efe2513e6bb2f281ca2b9756489 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Mon, 10 Aug 2020 06:42:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152549 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/152549/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt b94cde18fffe9efe2513e6bb2f281ca2b9756489 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 31 days Failing since 151818 2020-07-11 04:18:52 Z 30 days 31 attempts Testing same since 152539 2020-08-09 04:21:40 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Andrea Bolognani Balázs Meskó Bastien Orivel Bihong Yu Binfeng Wu Boris Fiuczynski Côme Borsoi Daniel Henrique Barboza Daniel P. Berrange Daniel P. Berrangé Erik Skultety Fedora Weblate Translation Han Han Hao Wang Jean-Baptiste Holcroft Jianan Gao Jin Yan Jiri Denemark Ján Tomko Laine Stump Liao Pingfang Martin Kletzander Michal Privoznik Nikolay Shirokovskiy Paulo de Rezende Pinatti Pavel Hrdina Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Roman Bogorodskiy Ryan Schmidt Stefan Berger Szymon Scholz Wang Xin Weblate Yang Hang Yi Wang Yuri Chornoivan Zheng Chuan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 9126 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Aug 10 07:46:56 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 07:46:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k52Vv-0001Dv-AR; Mon, 10 Aug 2020 07:46:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k52Vt-0001Db-Vh for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 07:46:34 +0000 X-Inumbo-ID: f88c3fb2-53ae-4214-9f50-178934ab21eb Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f88c3fb2-53ae-4214-9f50-178934ab21eb; Mon, 10 Aug 2020 07:46:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=daouMWeMZM7Xkv2Ui5I7D5yt9KkWJl4HUaq5lNft6GE=; b=DaONmOBdEMXTyIdmNcc8PLc2X Zl0QMP8VYt3vAXq9qiPYDMyodi6U2oGd+Y8jTjCR+wfJ7l40Mgi23hg+ICIVKYuLNmKSGtH1kAyyC oyZzxoTk+jYH45pv3VZpDvXFjKx7G4NuLTJ/XgtvJO+Vg2PZF7hamCMknwb9A6nCWvHpk=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k52Vl-0002L6-Fc; Mon, 10 Aug 2020 07:46:25 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k52Vl-0002hT-2e; Mon, 10 Aug 2020 07:46:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k52Vl-0007BD-25; Mon, 10 Aug 2020 07:46:25 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 152547: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-boot:fail:regression linux-linus:test-amd64-i386-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-i386-libvirt:xen-boot:fail:regression linux-linus:test-amd64-i386-examine:reboot:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-boot:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-xl:xen-boot:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-boot:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:guest-start/debian.repeat:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-saverestore:fail:heisenbug linux-linus:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug linux-linus:test-arm64-arm64-xl:xen-boot:fail:heisenbug linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking X-Osstest-Versions-This: linux=06a81c1c7db9bd5de0bd38cd5acc44bb22b99150 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Mon, 10 Aug 2020 07:46:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152547 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/152547/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-boot/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-boot/dst_host fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-examine 8 reboot fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-boot/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-boot/dst_host fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-boot fail REGR. vs. 152332 test-arm64-arm64-libvirt-xsm 16 guest-start/debian.repeat fail REGR. vs. 152332 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-rtds 15 guest-saverestore fail in 152540 pass in 152547 test-amd64-amd64-examine 4 memdisk-try-append fail in 152540 pass in 152547 test-arm64-arm64-xl 7 xen-boot fail pass in 152540 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl 13 migrate-support-check fail in 152540 never pass test-arm64-arm64-xl 14 saverestore-support-check fail in 152540 never pass test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail like 152332 test-armhf-armhf-libvirt 14 saverestore-support-check fail like 152332 test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail like 152332 test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass version targeted for testing: linux 06a81c1c7db9bd5de0bd38cd5acc44bb22b99150 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 9 days Failing since 152366 2020-08-01 20:49:34 Z 8 days 9 attempts Testing same since 152540 2020-08-09 04:52:34 Z 1 days 2 attempts ------------------------------------------------------------ 1897 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 238734 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Aug 10 10:13:56 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 10:13:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k54o5-0002WN-6Z; Mon, 10 Aug 2020 10:13:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k54o3-0002WI-79 for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 10:13:27 +0000 X-Inumbo-ID: c8f285d4-3d7a-471d-a7df-d0081147d8c5 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c8f285d4-3d7a-471d-a7df-d0081147d8c5; Mon, 10 Aug 2020 10:13:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1597054406; h=from:mime-version:content-transfer-encoding:message-id: date:to:cc:subject:in-reply-to:references; bh=5G+AFUMcR0ud52AqEaZcrGoU7QxA96sIRzOeUjXAWOY=; b=C90INUfBA8DOGSPFONr/NSlbl9B27xFiDpRjhAAXommS9S8icUZZPCBW SqB6K2/VOSGW9dBnWbtBA703s+hUuKFYHMrtPtLHzzzWnrCMEcHDUraM4 SxUUn89ASuTFiocpNjifUeRQtjiGeOeI5wgevAc519Us8z3z5Jk/AMvvZ k=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: QhQsU6Y7N45Yhr3F1qcl4oTbEOJnlBOcGOTp1h8zDDMYyvSGLkU9JOKijJ7rxs7bXj94nyTDUl TITxvN0ZZbr4SJDYfNDvbzIOcQGYDrHg2Zkgq1RqFo3JmWDRDJJ4UIlRU7St6PDCxOybD81NIu s/UZNqm4OHfYcB4+riMzE3RUoGbIs1NWoNSqM0CzsutEG0Vm/kcOaMbX13FZznL+4zntY5qGJq KpjsDJwYZK3VEVvyldKm72hITkK1IF2AwBoxgvYOnr21/Yd6KPDjugxGXRI6cZ7LwOm6WiANeO GYY= X-SBRS: 2.7 X-MesageID: 24175880 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,457,1589256000"; d="scan'208";a="24175880" From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-ID: <24369.7617.103361.244607@mariner.uk.xensource.com> Date: Mon, 10 Aug 2020 11:13:21 +0100 To: Jim Fehlig Subject: Re: [PATCH] OSSTEST: Install libtirpc-dev for libvirt builds In-Reply-To: <20200723213134.11044-1-jfehlig@suse.com> References: <20200723213134.11044-1-jfehlig@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Jim Fehlig writes ("[PATCH] OSSTEST: Install libtirpc-dev for libvirt builds"): > The check for XDR support was changed in libvirt commit d7147b3797 > to use libtirpc pkg-config instead of complicated AC_CHECK_LIB, > AC_COMPILE_IFELSE, et. al. logic. The libvirt OSSTEST has been > failing since this change hit libvirt.git master. Fix it by adding > libtirpc-dev to the list of 'extra_packages' installed for libvirt > builds. > > Signed-off-by: Jim Fehlig Reviewed-by: Ian Jackson Thanks! I will push this to osstest pretest shortly. Ian. From xen-devel-bounces@lists.xenproject.org Mon Aug 10 11:21:12 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 11:21:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k55rN-0008Fo-7G; Mon, 10 Aug 2020 11:20:57 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k55rL-0008Fj-57 for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 11:20:55 +0000 X-Inumbo-ID: d6fc8dc5-26af-483d-9627-9eef76f38bca Received: from chiark.greenend.org.uk (unknown [2001:ba8:1e3::]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d6fc8dc5-26af-483d-9627-9eef76f38bca; Mon, 10 Aug 2020 11:20:53 +0000 (UTC) Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by chiark.greenend.org.uk (Debian Exim 4.84_2 #1) with esmtp (return-path ijackson@chiark.greenend.org.uk) id 1k55rI-0003aJ-U4; Mon, 10 Aug 2020 12:20:53 +0100 From: Ian Jackson To: xen-devel@lists.xenproject.org Subject: [OSSTEST PATCH 1/6] cr-publish-flight-logs: Make a proper option parser Date: Mon, 10 Aug 2020 12:20:42 +0100 Message-Id: <20200810112047.30285-1-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Ian Jackson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" I was going to add another option but changed my mind. But, let's keep this patch anyway. Signed-off-by: Ian Jackson --- cr-publish-flight-logs | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/cr-publish-flight-logs b/cr-publish-flight-logs index faae7e0e..717cb957 100755 --- a/cr-publish-flight-logs +++ b/cr-publish-flight-logs @@ -28,9 +28,14 @@ our %c; readglobalconfig(); my $push_harness = 0; -if (@ARGV && $ARGV[0] =~ m{^--push-harness(?:-try)?$}) { - $push_harness = $&; - shift @ARGV; +while (@ARGV && $ARGV[0] =~ m{^-}) { + $_ = shift @ARGV; + last if $_ eq '--'; + if (m{^--push-harness(?:-try)?$}) { + $push_harness = $&; + } else { + die "unknown option \`$_' ?"; + } } my $flight= shift @ARGV // ''; -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 10 11:21:12 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 11:21:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k55rQ-0008Fy-FV; Mon, 10 Aug 2020 11:21:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k55rP-0008Fj-UW for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 11:20:59 +0000 X-Inumbo-ID: 276036f7-fddc-46d1-b86e-4ff89e0331dc Received: from chiark.greenend.org.uk (unknown [2001:ba8:1e3::]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 276036f7-fddc-46d1-b86e-4ff89e0331dc; Mon, 10 Aug 2020 11:20:54 +0000 (UTC) Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by chiark.greenend.org.uk (Debian Exim 4.84_2 #1) with esmtp (return-path ijackson@chiark.greenend.org.uk) id 1k55rJ-0003aJ-AT; Mon, 10 Aug 2020 12:20:53 +0100 From: Ian Jackson To: xen-devel@lists.xenproject.org Subject: [OSSTEST PATCH 2/6] timing traces: cr-publish-flight-logs: Report more progress Date: Mon, 10 Aug 2020 12:20:43 +0100 Message-Id: <20200810112047.30285-2-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200810112047.30285-1-ian.jackson@eu.citrix.com> References: <20200810112047.30285-1-ian.jackson@eu.citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Ian Jackson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" More tools to see where it is faffing too much. Signed-off-by: Ian Jackson --- cr-publish-flight-logs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/cr-publish-flight-logs b/cr-publish-flight-logs index 717cb957..ba5d3b70 100755 --- a/cr-publish-flight-logs +++ b/cr-publish-flight-logs @@ -43,6 +43,9 @@ die unless $flight =~ m/^\d*$/; die "usage: ./cr-publish-flight-logs [flight]" unless @ARGV==0; +sub progress { print (show_abs_time time), @_, "\n" } + +progress("acquiring publish-lock..."); open LOCK, "> $c{GlobalLockDir}/publish-lock" or die $!; flock LOCK, LOCK_EX or die $!; @@ -51,6 +54,7 @@ if ($push_harness) { my $gitdir= $c{HarnessPublishGitRepoDir}; if ($githost && $gitdir) { + progress("pushing..."); eval { system_checked("git push $githost:$gitdir HEAD:refs/heads/flight-$flight"); system_checked("ssh $githost 'cd $gitdir && git update-server-info'"); @@ -72,9 +76,10 @@ sub copydir ($$) { push @cmd, '-e', join(' ', map { s/\'/''/g; "'$_'"; } @ssh); #--bwlimit=50 push @cmd, $src, $dst; - print "+ @cmd\n"; + progress "+ @cmd"; $!=0; $?=0; system @cmd; die "rsync $? $!" if $? or $!; } copydir(qw(Logs), "/$flight") if $flight; copydir(qw(Results), ''); +progress "complete."; -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 10 11:21:12 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 11:21:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k55ra-0008H3-Vp; Mon, 10 Aug 2020 11:21:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k55rZ-0008Fj-Ux for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 11:21:09 +0000 X-Inumbo-ID: 5e45584a-3d19-4d05-a336-5bdc192aae41 Received: from chiark.greenend.org.uk (unknown [2001:ba8:1e3::]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5e45584a-3d19-4d05-a336-5bdc192aae41; Mon, 10 Aug 2020 11:20:54 +0000 (UTC) Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by chiark.greenend.org.uk (Debian Exim 4.84_2 #1) with esmtp (return-path ijackson@chiark.greenend.org.uk) id 1k55rJ-0003aJ-QP; Mon, 10 Aug 2020 12:20:53 +0100 From: Ian Jackson To: xen-devel@lists.xenproject.org Subject: [OSSTEST PATCH 4/6] timing traces: sg-check-tested: Add prints of (show_abs_time time) Date: Mon, 10 Aug 2020 12:20:45 +0100 Message-Id: <20200810112047.30285-4-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200810112047.30285-1-ian.jackson@eu.citrix.com> References: <20200810112047.30285-1-ian.jackson@eu.citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Ian Jackson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" More tools to see where it is faffing too much. Signed-off-by: Ian Jackson --- sg-check-tested | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sg-check-tested b/sg-check-tested index 7946e4b5..39c0d0c2 100755 --- a/sg-check-tested +++ b/sg-check-tested @@ -148,7 +148,7 @@ sub prepare_execute ($@) { my ($qtxt, @vars) = @_; print DEBUG "\n==========\n", $qtxt, "\n----------\n", (join ' | ', @vars), - "\n==========\n"; + "\n========== ".(show_abs_time time)."\n"; my $q= $dbh_tests->prepare($qtxt); $q->execute(@vars); return $q; @@ -169,7 +169,7 @@ sub search () { while (my $row= $q->fetchrow_hashref()) { my $flight= $row->{flight}; if (!defined $prrev) { - print DEBUG "==========YES\n"; + print DEBUG "========== ".(show_abs_time time)." YES\n"; output $flight,"\n"; return; } else { @@ -195,7 +195,7 @@ END my $row1= $valsq->fetchrow_hashref(); next unless defined $row1->{val} && length $row1->{val}; my $val1 = massage($row1->{val}); - print DEBUG "got $val1\n"; + print DEBUG (show_abs_time time)." got $val1\n"; while (my $row2 = $valsq->fetchrow_hashref()) { my $val2 = massage($row2->{val}); next if $val2 eq $val1; @@ -212,7 +212,7 @@ END return; } } - print DEBUG "==========NO\n"; + print DEBUG "========== ".(show_abs_time time)." NO\n"; } db_retry($dbh_tests, [], sub { -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 10 11:21:14 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 11:21:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k55rV-0008GO-Na; Mon, 10 Aug 2020 11:21:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k55rU-0008Fj-Ul for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 11:21:04 +0000 X-Inumbo-ID: f70dfcdf-0d3f-4b96-aec0-c4ee5e881699 Received: from chiark.greenend.org.uk (unknown [2001:ba8:1e3::]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f70dfcdf-0d3f-4b96-aec0-c4ee5e881699; Mon, 10 Aug 2020 11:20:54 +0000 (UTC) Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by chiark.greenend.org.uk (Debian Exim 4.84_2 #1) with esmtp (return-path ijackson@chiark.greenend.org.uk) id 1k55rJ-0003aJ-He; Mon, 10 Aug 2020 12:20:53 +0100 From: Ian Jackson To: xen-devel@lists.xenproject.org Subject: [OSSTEST PATCH 3/6] timing traces: cr-daily-branch: Add more calls to date >&2 Date: Mon, 10 Aug 2020 12:20:44 +0100 Message-Id: <20200810112047.30285-3-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200810112047.30285-1-ian.jackson@eu.citrix.com> References: <20200810112047.30285-1-ian.jackson@eu.citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Ian Jackson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" More tools to see where it is faffing too much. Signed-off-by: Ian Jackson --- cr-daily-branch | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/cr-daily-branch b/cr-daily-branch index d84dcc8e..b8f221ee 100755 --- a/cr-daily-branch +++ b/cr-daily-branch @@ -51,6 +51,7 @@ determine_version () { if [ "x$FORCE_REVISION" != x ]; then tversion="$FORCE_REVISION" else + date >&2 tversion=`$AP_FETCH_PFX ./ap-fetch-version "$tbranch"` fi determine_tree "$treevarwhich" "" _${treevarwhich} @@ -98,6 +99,7 @@ if [ "x$OLD_REVISION" = x ]; then # last test will have tested the previous upstream baseline OLD_REVISION=`check_tested --print-revision=$tree` else + date >&2 OLD_REVISION="`$AP_FETCH_PFX ./ap-fetch-version-old $branch`" fi ;; @@ -159,6 +161,7 @@ if [ "x$REVISION_XEN" = x ]; then export REVISION_XEN fi if [ "x$REVISION_PREVXEN" = x -a "x$prevxenbranch" != "x" ]; then + date >&2 REVISION_PREVXEN="`\ $AP_FETCH_PFX ./ap-fetch-version-baseline $prevxenbranch`" export REVISION_PREVXEN @@ -321,6 +324,7 @@ unset IFS if [ "x$OLD_REVISION" = xdetermine-late ]; then OLD_REVISION="`\ + date >&2 $AP_FETCH_PFX ./ap-fetch-version-baseline-late $branch $NEW_REVISION`" fi @@ -430,6 +434,7 @@ case "$NEW_REVISION/$OLD_REVISION" in case "$realtree" in xen-4*|xen-unstable*) + date >&2 oldqemu=`./ap-qemu-revision $realtree $OLD_REVISION` newqemu=`./ap-qemu-revision $realtree $NEW_REVISION` if [ "$oldqemu" ] && [ "$newqemu" ]; then @@ -445,6 +450,7 @@ case "$NEW_REVISION/$OLD_REVISION" in cat <tmp/$flight.people-touched People who touched revisions under test: END + date >&2 ./adhoc-people-touched-filter <$revlog \ >>tmp/$flight.people-touched touched_lines=`wc -l &2 : $flight $branch $OSSTEST_BLESSING $sgr_args $DAILY_BRANCH_PREEXEC_HOOK execute_flight $flight $OSSTEST_BLESSING +date >&2 + start_email $flight $branch "$sgr_args" "$subject_prefix" push=false @@ -502,6 +511,7 @@ elif $push; then echo >&2 "BAD PUSH REVISION $to_push" ;; [0-9a-f]*) + date >&2 if ./ap-push $branch $to_push 2>&1; then rm -f $branch.push $branch.force-rev perl -i~ -pe ' @@ -527,6 +537,7 @@ freebsd-*) if grep '^tolerable$' $mrof >/dev/null 2>&1 && $OSSTEST_ANOINT && [ "x$OSSTEST_BLESSING" == "xreal" ]; then IFS=$'\n' + date >&2 for anointed in `./mg-anoint list-prepared \ "freebsd build $freebsd_branch *"`; do # Update anointed versions @@ -554,4 +565,5 @@ if [ -f $revlog ]; then fi fi +date >&2 publish_send_email $flight -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 10 11:21:16 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 11:21:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k55rg-0008Ih-8U; Mon, 10 Aug 2020 11:21:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k55re-0008Fj-VB for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 11:21:14 +0000 X-Inumbo-ID: d25bf53b-c4b2-46da-8e49-dcfd55ead790 Received: from chiark.greenend.org.uk (unknown [2001:ba8:1e3::]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d25bf53b-c4b2-46da-8e49-dcfd55ead790; Mon, 10 Aug 2020 11:20:54 +0000 (UTC) Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by chiark.greenend.org.uk (Debian Exim 4.84_2 #1) with esmtp (return-path ijackson@chiark.greenend.org.uk) id 1k55rK-0003aJ-2L; Mon, 10 Aug 2020 12:20:54 +0100 From: Ian Jackson To: xen-devel@lists.xenproject.org Subject: [OSSTEST PATCH 5/6] timing traces: Executive: Provide processing timestamp facilities Date: Mon, 10 Aug 2020 12:20:46 +0100 Message-Id: <20200810112047.30285-5-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200810112047.30285-1-ian.jackson@eu.citrix.com> References: <20200810112047.30285-1-ian.jackson@eu.citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Ian Jackson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Nothing uses these yet. Signed-off-by: Ian Jackson --- Osstest/Executive.pm | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm index c46a979d..1e94b282 100644 --- a/Osstest/Executive.pm +++ b/Osstest/Executive.pm @@ -51,6 +51,7 @@ BEGIN { report_run_getinfo report_altcolour report_altchangecolour opendb_tests report_blessingscond report_find_push_age_info + log_stderr_timestamped tcpconnect_queuedaemon plan_search manual_allocation_base_jobinfo alloc_resources alloc_resources_rollback_begin_work @@ -293,11 +294,23 @@ sub restrictflight_arg ($) { $restrictflight_cond .= " AND flights.flight != $_" foreach split /,/, $1; return 1; + } elsif ($arg =~ m/^--report-processing-start-time$/) { + # This functionality is wanted by all the callers of + # restrictflight_arg and is here for convenience, rather than + # out of principle. + log_stderr_timestamped("starting..."); + return 1; } else { return 0; } } +sub log_stderr_timestamped ($) { + my $us = $0; + $us =~ s{.*/}{}; + print STDERR (show_abs_time time)." $us: @_\n"; +} + sub restrictflight_cond () { return "($restrictflight_cond)"; } -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 10 11:21:20 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 11:21:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k55rk-0008Jt-HV; Mon, 10 Aug 2020 11:21:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k55rj-0008Fj-VE for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 11:21:19 +0000 X-Inumbo-ID: 3a3d34f7-c5cd-43be-9fbb-eaaa765e87eb Received: from chiark.greenend.org.uk (unknown [2001:ba8:1e3::]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3a3d34f7-c5cd-43be-9fbb-eaaa765e87eb; Mon, 10 Aug 2020 11:20:55 +0000 (UTC) Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by chiark.greenend.org.uk (Debian Exim 4.84_2 #1) with esmtp (return-path ijackson@chiark.greenend.org.uk) id 1k55rK-0003aJ-9Z; Mon, 10 Aug 2020 12:20:54 +0100 From: Ian Jackson To: xen-devel@lists.xenproject.org Subject: [OSSTEST PATCH 6/6] timing traces: cri-args-hostlists: Add some timestamps Date: Mon, 10 Aug 2020 12:20:47 +0100 Message-Id: <20200810112047.30285-6-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200810112047.30285-1-ian.jackson@eu.citrix.com> References: <20200810112047.30285-1-ian.jackson@eu.citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Ian Jackson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Pass --report-processing-start-time, and add some calls to date >&2. Signed-off-by: Ian Jackson --- cri-args-hostlists | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/cri-args-hostlists b/cri-args-hostlists index 61572c2d..994e00c0 100644 --- a/cri-args-hostlists +++ b/cri-args-hostlists @@ -77,11 +77,13 @@ execute_flight () { rm -f abort check_stop_core '' + date >&2 ./cr-ensure-disk-space Logs ./cr-ensure-disk-space LogsPublish export OSSTEST_RESOURCE_PREINFO="[$branch $2]" + date >&2 set +e ./sg-execute-flight $1 $2 >tmp/$1.transcript 2>&1 local rc=$? @@ -120,11 +122,13 @@ start_email () { date >&2 with-lock-ex -w $globallockdir/report-lock \ - ./sg-report-job-history --html-dir=$job_html_dir --flight=$flight + ./sg-report-job-history --report-processing-start-time \ + --html-dir=$job_html_dir --flight=$flight date >&2 - ./sg-report-flight --html-dir=$flight_html_dir/$flight/ \ + ./sg-report-flight --report-processing-start-time \ + --html-dir=$flight_html_dir/$flight/ \ --allow=allow.all --allow=allow.$branch \ $sgr_args $flight >tmp/$flight.report ./cr-fold-long-lines tmp/$flight.report @@ -133,7 +137,8 @@ start_email () { mkdir -p $host_html_dir with-lock-ex -w $globallockdir/report-lock \ - ./sg-report-host-history --html-dir=$host_html_dir flight:$flight + ./sg-report-host-history --report-processing-start-time \ + --html-dir=$host_html_dir flight:$flight date >&2 } -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 10 13:00:15 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 13:00:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k57P9-0007w1-Fn; Mon, 10 Aug 2020 12:59:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k57P8-0007vw-Q2 for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 12:59:54 +0000 X-Inumbo-ID: e5881b1a-4cd2-4c26-b04d-cdadbaec4ca4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e5881b1a-4cd2-4c26-b04d-cdadbaec4ca4; Mon, 10 Aug 2020 12:59:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=k3JokX2b9OZ1qaOFf6KLzSBii8gJx+Fv6J5vILVRbhg=; b=3PhuDVvfteQxjbFlBUb/TphzA uCmkkJmoor7EnyauGkDa/jGWoW2Qmt7ijRgi8v72BawYzU2GyJ2nAjlW2nuKtBvoQ2TgTTIVaWJO+ FWOIoX+mJxamY0k8X16GOjZQpfiIJh5g9IXeSfVC7xSFbglPDdQbQrIQWQMCCreOOdJGM=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k57P6-0006L9-65; Mon, 10 Aug 2020 12:59:52 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k57P5-0002Vk-Ls; Mon, 10 Aug 2020 12:59:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k57P5-0006zv-LB; Mon, 10 Aug 2020 12:59:51 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 152548: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking X-Osstest-Versions-This: xen=90c7eee53fcc0b48bd51aa3a7d1d0d9980ce1a7a X-Osstest-Versions-That: xen=90c7eee53fcc0b48bd51aa3a7d1d0d9980ce1a7a From: osstest service owner Date: Mon, 10 Aug 2020 12:59:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152548 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/152548/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail like 152542 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail like 152542 test-armhf-armhf-xl-rtds 16 guest-start/debian.repeat fail like 152542 test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail like 152542 test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail like 152542 test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 152542 test-armhf-armhf-libvirt 14 saverestore-support-check fail like 152542 test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail like 152542 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail like 152542 test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail like 152542 test-amd64-i386-xl-pvshim 12 guest-start fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass version targeted for testing: xen 90c7eee53fcc0b48bd51aa3a7d1d0d9980ce1a7a baseline version: xen 90c7eee53fcc0b48bd51aa3a7d1d0d9980ce1a7a Last test of basis 152548 2020-08-10 01:54:48 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon Aug 10 13:06:08 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 13:06:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k57V6-0000PF-5d; Mon, 10 Aug 2020 13:06:04 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k576N-0006wE-JT for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 12:40:31 +0000 X-Inumbo-ID: f0982355-bf7a-46ca-8f47-c95c6b6325f1 Received: from mail-wr1-x42e.google.com (unknown [2a00:1450:4864:20::42e]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f0982355-bf7a-46ca-8f47-c95c6b6325f1; Mon, 10 Aug 2020 12:40:29 +0000 (UTC) Received: by mail-wr1-x42e.google.com with SMTP id f7so8036612wrw.1 for ; Mon, 10 Aug 2020 05:40:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iittp-ac-in.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=6RI9ge20MGwyQDF/q+D13QX8FqQS5DG75aexxfmIIus=; b=CUvUy+/HbzjMNa3L+c0Sb05/HonofISu/AZopp9MtVAsrUM+R77cXjsDIgsa+8kAaQ iBX7G+8FRHeZspfG0zPtQzVHlCF6hku1lnhIdFP/ykjfMmh6v4jXj+erMS28B4SCR5DV sn0z9KHcz9Wuo02vGliR9h2aSmJjxdibHWtrneqSPFAdsYMQlpD6bH4MCmiE+NN8In2e a+T2Bysh2Vn3grgZGQh7fZkkBeCOOipUl9O4JynRif/xdJeCOZbjn3ZyXMN9Thb/ndY9 QXcGWztozPIIFj3MaKeK/ewoIT/WtQS2gF9zxdKd1g5l+O7I9/8GablVihIA9KAg9b2i TXVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=6RI9ge20MGwyQDF/q+D13QX8FqQS5DG75aexxfmIIus=; b=sWKpXXACl0tbizHPwUSA5olAxPub8IBoCenIoxJROUsUmb2YtasYjhPDwWNHTJE95b fVY0J3lzmWHKphztcR3OxxrUVMMq8tS157LgrdPigF1F3gZNmGKVw48uuXY6caeM8ChZ qAg9c5ZEm5XdVvV6PbL0TAO7YKmRM2QIhSXp03h3Moci913oGLAwy2v9s+6IN5XTVpXh npkRzNAa3iVOvPgzZdjkoKMCyB4qXdNb1AVEUegrnsHQL0sQaw7DPDXkCYEW3+cEiOkp vxkN0zsb96ofoO6uuOOCp+cBgC74Q1G+40t9xMS55DEYvVr2l5HS9A77UX7e1hA4YyAW +NVw== X-Gm-Message-State: AOAM533QFQF3iXYkJEq/Iay121PSbmjfrhTN/e/UTgvpi31BhHpjlQrJ lQrd1bPhc/VIMUn8fcGxz1F2hmrCykVfLllqazjjoTHMk55paA== X-Google-Smtp-Source: ABdhPJxdjdUEEWqrFiCEvsNGbXTUMu/gjazRjRZbo3UHJaYxy39H6Xlo0vyt5b5ncut0XJQ5o+yhyYHM0h6KCeDp2P4= X-Received: by 2002:adf:df08:: with SMTP id y8mr26127825wrl.152.1597063228049; Mon, 10 Aug 2020 05:40:28 -0700 (PDT) MIME-Version: 1.0 From: CS17B006 ARNAB DUTTA Date: Mon, 10 Aug 2020 18:10:17 +0530 Message-ID: Subject: Xen VMI APIs To: xen-devel@lists.xenproject.org Content-Type: multipart/alternative; boundary="000000000000645def05ac85425d" X-Mailman-Approved-At: Mon, 10 Aug 2020 13:06:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" --000000000000645def05ac85425d Content-Type: text/plain; charset="UTF-8" Respected Sir/Ma'm I am Arnab and I am currently writing rust bindings for xen vmi APIs for a project known as Libmicrovmi which aims to provide unified vmi APIs for various hypervisors. I am facing some difficulty regarding setting up the event system in the sense that after enabling monitoring for events, on polling I get a return value of 1, but xenevtchn_pending() returns a value -1, which probably means it cannot get a port with pending events. I am really confused and need help here. Thanking you With regards Arnab Dutta Computer Science and Engineering Department Indian Institute of Technology, Tirupati, India Ph no. 8420771531 --000000000000645def05ac85425d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Respected Sir/Ma'm
= I am Arnab and I am currently writing rust bindings = for xen vmi APIs for a project known as Libmicrovmi which aims to provide u= nified vmi APIs for various hypervisors. I am facing some difficulty regard= ing setting up the event system in the sense that after enabling monitoring= for events, on polling I get a return value of 1, but xenevtchn_pending() = returns a value -1, which probably means it cannot get a port with pending = events. I am really confused and need help here.
<= /font>

Thanking you
<= span style=3D"background-color:rgb(255,255,255)">
With regards
Arnab= Dutta
Computer Science and Engineering Department
= Indian Institute of Technology, Tirupati, India=
Ph no. 8420771531
--000000000000645def05ac85425d-- From xen-devel-bounces@lists.xenproject.org Mon Aug 10 13:25:17 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 13:25:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k57nY-000262-Ph; Mon, 10 Aug 2020 13:25:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k57nX-00025x-I9 for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 13:25:07 +0000 X-Inumbo-ID: 8aff9d79-ce8a-49db-9ca3-6e496c3b5f98 Received: from mail-wm1-f54.google.com (unknown [209.85.128.54]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8aff9d79-ce8a-49db-9ca3-6e496c3b5f98; Mon, 10 Aug 2020 13:25:06 +0000 (UTC) Received: by mail-wm1-f54.google.com with SMTP id c80so7621089wme.0 for ; Mon, 10 Aug 2020 06:25:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0ynUFJpbuM6ihmRdtWyzhJzCORfgz4nGuPongSlaZv0=; b=NIBOsaFZ6GP76OLaoKWeGu0BNpz8/mM5cjcZTJ2gXHbQabksQGTlzc25cq4BCWujcS 1w3Ld61R7I47gHUjz6Ovg2C1lq8ZeEY95SonsDFV4rmJYXeARj2q+1Z4CDTvSSF5Y3ev BjH3YXY6XJ48qnO3DgvgMujNqK5r7DiIncZOCWGj+t0QM5tkoseBy1aidaCDuPFwUmpe OQwxkIbTzI9igJq+EbuorZ9g3faMyyDPxKzzH3vP0AZHaLHeOTaqGn0s17IF/h/Iq9go wefCpqzqZ3lP1Bmz1k1fFqJxBEdnsvxOvHO8hDOlZ8s1sJhUrAHqOShLggtJiu6N+gpF AvrA== X-Gm-Message-State: AOAM533dzQk2FihvY7PgOnheZ2NRs5/mDGXrfPSfOx64OZwfJFbif30M GOEQ5ypL1+eVn3shVi/O4kc= X-Google-Smtp-Source: ABdhPJxTFYoBHUlKdDg8jHrQxr+2M+BeoEWH256LiDRgkZF5vPDvJht2VdQM3tRFcMsIIcjUiX6SAg== X-Received: by 2002:a1c:23c2:: with SMTP id j185mr24773204wmj.84.1597065905735; Mon, 10 Aug 2020 06:25:05 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id 126sm22079956wme.42.2020.08.10.06.25.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2020 06:25:04 -0700 (PDT) Date: Mon, 10 Aug 2020 13:25:03 +0000 From: Wei Liu To: CS17B006 ARNAB DUTTA Subject: Re: Xen VMI APIs Message-ID: <20200810132503.fywmbihmaadaj45i@liuwe-devbox-debian-v2> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Mon, Aug 10, 2020 at 06:10:17PM +0530, CS17B006 ARNAB DUTTA wrote: > Respected Sir/Ma'm > I am Arnab and I am currently writing rust bindings for xen vmi APIs for a > project known as Libmicrovmi which aims to provide unified vmi APIs for > various hypervisors. I am facing some difficulty regarding setting up the > event system in the sense that after enabling monitoring for events, on > polling I get a return value of 1, but xenevtchn_pending() returns a value > -1, which probably means it cannot get a port with pending events. I am > really confused and need help here. > If you can, please post your code. Also, you can check why eenevtchn_pending returns -1 by reading kernel / hypervisor code and adding a few debug prints. Wei. > Thanking you > > With regards > Arnab Dutta > Computer Science and Engineering Department > Indian Institute of Technology, Tirupati, India > Ph no. 8420771531 From xen-devel-bounces@lists.xenproject.org Mon Aug 10 13:31:13 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 13:31:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k57tM-0002y1-JG; Mon, 10 Aug 2020 13:31:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k57tK-0002xw-Nz for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 13:31:06 +0000 X-Inumbo-ID: 852d7cc9-044a-442d-b2f0-eab5c0502c9d Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 852d7cc9-044a-442d-b2f0-eab5c0502c9d; Mon, 10 Aug 2020 13:31:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1597066265; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=YZYCVIElUZ9DPa9FwwQV5ojxIpDLXnJ7SpCIq/Yhxck=; b=c+kaF4afbzI0M+NlJdXptmhwYi02atkoRUvpq8B//f6wN1dLcOaU5zqa h0x+V5SjiGtJ9IJ+r7x4YgomftfHQ8bY091byuQ89Bf8iqjF9hkMhVNoz 8XoldhyaF4balbwol744kWpfipAJDqM2LNd64vNDJbCVaaDAKlvvoPMiv c=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 6t3Pj5/K2nopBs2JzBzP+C7r0C6Nk+84KzfE5snkGm4twf0kpi6xA/NGQtmTYU5inwL+Z7o+1O SyVSQoChupUdiAU8z1KwXAfoGVkPBcRw+Pxd2QKPCsf2+z6wvA67eX6uJhqSAkPjyLCJqYgQzN kGXA1sIkgy7BQum9wZJarYTsA3SIaDhVhuKhyAGhQJUZLJnVBMTp4zQxLLERlNM7DdQg2daLWK Z81rx6xV69Yn8EHVa4sWFBvA/lvrhIYNAB/5Nn4gj/03O0bDQQdaeALp047jGZaWDozgkilKFf nIs= X-SBRS: 2.7 X-MesageID: 24495014 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,457,1589256000"; d="scan'208";a="24495014" Subject: Re: [RFC] efi/boot: Unified Xen executable for UEFI Secure Boot support To: Trammell Hudson References: <1bd2d79e-5bef-835c-f6cc-9fd367e8beb7@suse.com> <5e3b16b3-0f93-4683-dcc7-852c805870c8@suse.com> <132b5b88-c78d-01cf-df27-6430689570e4@citrix.com> From: Andrew Cooper Message-ID: <2afa43a1-d29e-32db-1583-a752b4a122e9@citrix.com> Date: Mon, 10 Aug 2020 14:31:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , "xen-devel@lists.xenproject.org" , Boris Ostrovsky , Jan Beulich Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 07/08/2020 19:22, Trammell Hudson wrote: > On Thursday, August 6, 2020 8:14 PM, Andrew Cooper wrote: >> For SecureBoot, it is important that nothing which is signed can be >> tricked into running unsigned code. >> >> That includes configuration such as xen.cfg or the command line. >> Consuming these from unsigned sources is ok, so long as we can guarantee >> that the parsing is robust (see boothole for how this goes wrong), and >> the effects are controlled. > In addition to the "unsafe_fsgsbase", the Linux command line is full > of potential issues, from subtle ones like "lockdown=none" to more > brute force things like "init=/bin/sh". Oh - of course.  That one is far easier. > safeboot uses the signed > kernel command line to pass in the root hash of the dm-verity Merkle > tree, which cryptographically protects the rest of the runtime, so > it definitely needs to come from a trusted source. > >> [...] >> In the absence of a full audit of all our command line arguments, and >> extra vigilance reviewing code coming in, the safer alternative is to >> prohibit use of the command line, and only accept it in its Kconfig >> embedded form for now. > Turning off command line or config parsing might be a step too far. > Since the xen.cfg in the unified image is included in the signature, > any options configured in it should be trustworthy. This makes it easier > for distributions to have a Xen build with boot-time work arounds for > different hardware or configurations. Apologies - I didn't mean to suggest disabling command line parsing entirely.  Simply from unsigned sources. With the proposal here, there are two signed sources; one in Kconfig, and one in the embedded xen.cfg file. > >> [...] >> I think it might be worth having a CONFIG_SECURE_BOOT, selectable >> initially only under CONFIG_EXPERT, and use it to force off various >> other aspects of functionality, along with a list of known issues which >> can be chipped away at before it can be declared supported. > That makes sense to me. Either doing it at compile time (by making > CONFIG_LIVEPATCH and CONFIG_KEXEC and etc depend on !CONFIG_SECURE_BOOT), > or having a global variable that turns off the code (similar to the > Linux lockdown patches that are triggered if UEFI secure boot is enabled). Hmm - I'm in two minds here. >From a user point of view, we really don't want it to be compile-time only, because it is very important to be able to debug the exact binary which is giving you problems, and some times that will mean "disable secure boot and poke". On the other hand, simply putting a "Secure Boot Enabled" check/print in there will probably (at this point) give users a false sense of any of this being remotely supported. >> [...] >> I think it is great that work is being started in this direction, but >> there is a huge quantity of work to do before a downstream could >> plausibly put together a Xen system which honours the intent of SecureBoot. > I'm really worried that the current shim based approach is a false sense > of security -- it provides trivial ways for attackers to bypass the > SecureBoot guarantees, so closing some of those easy holes with the > verified unified image is definitely an incremental improvement towards > a more secure system. > > However, I also don't want the unified image patch to get bogged down > while trying to pursue every UEFI SecureBoot(tm) related issue, so > perhaps the patch series should be renamed to only focus on the unified > build part, not the SecureBoot part. That way downstream distributions > can use it to add the security features that they need (caveat lector), > without necessarily depending on the strict UEFI compliance. Its entirely fine to take incremental work.  I didn't mean to give the impression of objecting to this change just because it wasn't fully UEFI SecureBoot(tm) compliant. My main concern is simply to avoid giving any kind of impression that UEFI SecureBoot is generally usable at the moment. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Aug 10 13:41:51 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 13:41:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k583a-0003sh-Iw; Mon, 10 Aug 2020 13:41:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k583Y-0003sZ-W3 for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 13:41:41 +0000 X-Inumbo-ID: 65a6df08-4d61-41fe-ae44-2df671a08727 Received: from mail-lj1-x243.google.com (unknown [2a00:1450:4864:20::243]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 65a6df08-4d61-41fe-ae44-2df671a08727; Mon, 10 Aug 2020 13:41:39 +0000 (UTC) Received: by mail-lj1-x243.google.com with SMTP id w14so9613271ljj.4 for ; Mon, 10 Aug 2020 06:41:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=dOILpsKXJFlU3OVwX84p9SOcs/Wqrqoxliu9OBxc+jg=; b=sYOf9QYwFP+uakTNk/MvagovCIfMxbATr2tDDMOKF6o/8k/KKFcc6nmPdaZkPOCapB SMU/NFFgB4lSunuQdscjAm2kVaoYDsh+CajRLRqYchHur2zsJ0T2Y82AFKNa/GTG57wV GHJqffsIKMxHTocuXca4nEPh24OyDEsyhbh+RvFXRHWRm0pzq0EpknOhf398wKCRg1e6 IyKMjPj/xYehcniXe6nb6jhUoEz8hg1qM/SjHFyqPLFM2T3d2WzVP3Vy7rVPU9OjGEv7 nflCtMvoyPnXei4vpkG/92EdjCx578n7QMqzI6DtZLiXP+LnYkE3UEcAuK8WxLgL8RzK 2grg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=dOILpsKXJFlU3OVwX84p9SOcs/Wqrqoxliu9OBxc+jg=; b=kdT5LTyP4fZIAawQcTVSBMHjwXyUmsjt1h45/ISgaevXqaYkOuuY1TKsIMSIpxH29g bzt0taAxwLy6nHrM5APh5t538qed2of7q2xSaTnSPDvGthnCLG7YB4aouHkPnwBaZmF8 mW4eVnFm/aSi5i6MpE1F/Ta8lwfh3UH9Q8/8bXqHyOvWC8luRLCFepFrpZMntDS9IpT+ HtQGdoJy/pgdnSFjvrXuOyJU2TuOUxbBURJ4jbkXnFqmJU7rhHaXyHTmos5zkgg4KyU6 Nan02sleDMopYsp3klNqOkBEOeNctfO7A6ReQPz6qClwrapfcH3YCFGibCXyI1ntZcj5 IiAg== X-Gm-Message-State: AOAM533L01iPyuHmqsZPkX4GsXKPM7jvU+UotfrWw286wMbv10XBampR cZk2fMJrP6gSuvkRLc7+t8k= X-Google-Smtp-Source: ABdhPJyTZCcH4+dGgpp7rMwtg+13BFZ5MybMBGSkw/OIsKt5OzcO9CJzvOdMtUGUNXMNUjzcmlANiw== X-Received: by 2002:a2e:9f0a:: with SMTP id u10mr627913ljk.140.1597066898203; Mon, 10 Aug 2020 06:41:38 -0700 (PDT) Received: from [192.168.1.2] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id g6sm10751454lfr.51.2020.08.10.06.41.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Aug 2020 06:41:37 -0700 (PDT) Subject: Re: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common From: Oleksandr To: Stefano Stabellini , Julien Grall References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-2-git-send-email-olekstysh@gmail.com> <000c01d66a33$2bd56510$83802f30$@xen.org> <9f83a7ed-ca97-449f-c7b9-a1140644abe9@gmail.com> <2ab4c567-8efa-1b9d-ab00-4ea7e1ab323e@suse.com> <013b142d-5296-5bbe-7d19-903f59e0c974@gmail.com> <06f78323-b8f5-fd11-486a-437267eccc29@gmail.com> Message-ID: <27513b2b-e59b-d446-7e68-eac4bc503409@gmail.com> Date: Mon, 10 Aug 2020 16:41:31 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <06f78323-b8f5-fd11-486a-437267eccc29@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: 'Kevin Tian' , 'Jun Nakajima' , 'Wei Liu' , paul@xen.org, 'Andrew Cooper' , 'Ian Jackson' , 'George Dunlap' , 'Tim Deegan' , 'Oleksandr Tyshchenko' , 'Julien Grall' , Jan Beulich , xen-devel@lists.xenproject.org, =?UTF-8?B?J1JvZ2VyIFBhdSBNb25uw6kn?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Hi On 08.08.20 01:19, Oleksandr wrote: > > On 08.08.20 00:50, Stefano Stabellini wrote: > > Hi Stefano > >> On Fri, 7 Aug 2020, Oleksandr wrote: >>> On 06.08.20 03:37, Stefano Stabellini wrote: >>> >>> Hi Stefano >>> >>> Trying to simulate IO_RETRY handling mechanism (according to model >>> below) I >>> continuously get IO_RETRY from try_fwd_ioserv() ... >>> >>>> OK, thanks for the details. My interpretation seems to be correct. >>>> >>>> In which case, it looks like xen/arch/arm/io.c:try_fwd_ioserv should >>>> return IO_RETRY. Then, xen/arch/arm/traps.c:do_trap_stage2_abort_guest >>>> also needs to handle try_handle_mmio returning IO_RETRY the first >>>> around, and IO_HANDLED when after QEMU does its job. >>>> >>>> What should do_trap_stage2_abort_guest do on IO_RETRY? Simply return >>>> early and let the scheduler do its job? Something like: >>>> >>>>               enum io_state state = try_handle_mmio(regs, hsr, gpa); >>>> >>>>               switch ( state ) >>>>               { >>>>               case IO_ABORT: >>>>                   goto inject_abt; >>>>               case IO_HANDLED: >>>>                   advance_pc(regs, hsr); >>>>                   return; >>>>               case IO_RETRY: >>>>                   /* finish later */ >>>>                   return; >>>>               case IO_UNHANDLED: >>>>                   /* IO unhandled, try another way to handle it. */ >>>>                   break; >>>>               default: >>>>                   ASSERT_UNREACHABLE(); >>>>               } >>>> >>>> Then, xen/arch/arm/ioreq.c:handle_mmio() gets called by >>>> handle_hvm_io_completion() after QEMU completes the emulation. Today, >>>> handle_mmio just sets the user register with the read value. >>>> >>>> But it would be better if it called again the original function >>>> do_trap_stage2_abort_guest to actually retry the original operation. >>>> This time do_trap_stage2_abort_guest calls try_handle_mmio() and gets >>>> IO_HANDLED instead of IO_RETRY, >>> I may miss some important point, but I failed to see why >>> try_handle_mmio >>> (try_fwd_ioserv) will return IO_HANDLED instead of IO_RETRY at this >>> stage. >>> Or current try_fwd_ioserv() logic needs rework? >> I think you should check the ioreq->state in try_fwd_ioserv(), if the >> result is ready, then ioreq->state should be STATE_IORESP_READY, and you >> can return IO_HANDLED. > I optimized test patch a bit (now it looks much simpler). I didn't face any issues during a quick test. Julien, Stefano, what do you think it does proper things for addressing TODO? Or I missed something? ---  xen/arch/arm/io.c    | 4 ----  xen/arch/arm/ioreq.c | 7 ++++++-  xen/arch/arm/traps.c | 4 +++-  3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c index 436f669..3063577 100644 --- a/xen/arch/arm/io.c +++ b/xen/arch/arm/io.c @@ -156,10 +156,6 @@ static enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,      else          vio->io_completion = HVMIO_mmio_completion; -    /* XXX: Decide what to do */ -    if ( rc == IO_RETRY ) -        rc = IO_HANDLED; -      return rc;  }  #endif diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c index 8f60c41..e5235c6 100644 --- a/xen/arch/arm/ioreq.c +++ b/xen/arch/arm/ioreq.c @@ -33,6 +33,8 @@  #include  #include +#include +  bool handle_mmio(void)  {      struct vcpu *v = current; @@ -52,7 +54,7 @@ bool handle_mmio(void)      /* XXX: Do we need to take care of write here ? */      if ( dabt.write ) -        return true; +        goto done;      /*       * Sign extend if required. @@ -72,6 +74,9 @@ bool handle_mmio(void)      set_user_reg(regs, dabt.reg, r); +done: +    advance_pc(regs, hsr); +      return true;  } diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index ea472d1..974c744 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -1965,11 +1965,13 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,              case IO_HANDLED:                  advance_pc(regs, hsr);                  return; +            case IO_RETRY: +                /* finish later */ +                return;              case IO_UNHANDLED:                  /* IO unhandled, try another way to handle it. */                  break;              default: -                /* XXX: Handle IO_RETRY */                  ASSERT_UNREACHABLE();              }          } -- 2.7.4 -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Mon Aug 10 14:27:12 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 14:27:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k58lI-0007NT-2Q; Mon, 10 Aug 2020 14:26:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k58lH-0007NO-6f for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 14:26:51 +0000 X-Inumbo-ID: 894d7c5b-5cb4-435c-9564-82f6262768ae Received: from de-smtp-delivery-102.mimecast.com (unknown [62.140.7.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 894d7c5b-5cb4-435c-9564-82f6262768ae; Mon, 10 Aug 2020 14:26:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1597069608; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9fJ4rP5Ppql3dWjpVe3p5qyhArwp/LiyABy+nrrg6m0=; b=jTYkfiHUgSEPh1L67GGJv9/Jm7N2MyPm689VFPPQNQJkehKT50yG7Yuw9uXsS4eWJKB2tA exJdamRW6ytmxDTWn5ngqUK5ZUK7c/MIK9lV6gwrlFJmYKQHKD8JaR13JYSg//gwAGdjXH OtQpurbmJ97B/3oYDS6OvDYf/qowm8Y= Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2052.outbound.protection.outlook.com [104.47.12.52]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-14-iaAFU8WEOiqgw3RyfeveNQ-1; Mon, 10 Aug 2020 16:26:47 +0200 X-MC-Unique: iaAFU8WEOiqgw3RyfeveNQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NymGibz4QCVCwGipvfXXECpbJE7LekMTovUqT8YCt31pX/ve+69LfTMKM/Yq2fmxvHUUicVsCmMMlTWbFZVOLzVkjNQTQjsPh9cgPBcNZ6Lc6LFcvJI0D7h/w0xKtXEpRyXtPziTkPB+jgcg53kHivHNaKxfOZ1cPppUB6gDflA6VC0xGXzy2asTOglVdGsesuOnvVTaqRl4ygV/ad7enzQiNbx00QJ79ziWeGj0CJM/yIYGRsh0fDRRn5A9s1zMBnuy+JWuuC8VEBRymtENrxH2WTwYfDzvISVdeqalsw5fwK0Gnrv+DqD5S85xnUjaaQRUc32HO0tUdSA6NYvAYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9fJ4rP5Ppql3dWjpVe3p5qyhArwp/LiyABy+nrrg6m0=; b=oTswLGIBblQCxp8zYdz3JqQpqaUnBorJyJU5KNzGq5PwAnaTwveb8Ycewp6Z/p6fZSCHQKZp/BHKzpoG1aQqiDGgo924GIqsQH0F1yo7FxT7JK6ilzZYkquGUoXo0M5shpGxUgKDqczIOr+/ETx0We2RpH+DQDKdgcfl4JYfxwolx+AZ1igx9QSJIU0sQXWLJu2iWAybZGJn275kvcUYkFsgVUtCA+iwgnahx1RDZiwl7q34rOzSflFkrOY8WtoilFeKHsas0D6YxSKNNX11saaqV1ZNDeJk0OjKn0nn17k/hGYK6HE0WluLBbAlIvn+/xalsefE/I70KG1G4yxXDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Received: from VI1PR0401MB2429.eurprd04.prod.outlook.com (2603:10a6:800:2c::13) by VI1PR0402MB3824.eurprd04.prod.outlook.com (2603:10a6:803:22::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.17; Mon, 10 Aug 2020 14:26:44 +0000 Received: from VI1PR0401MB2429.eurprd04.prod.outlook.com ([fe80::7cc0:b0a4:b951:90e2]) by VI1PR0401MB2429.eurprd04.prod.outlook.com ([fe80::7cc0:b0a4:b951:90e2%11]) with mapi id 15.20.3261.024; Mon, 10 Aug 2020 14:26:44 +0000 Subject: Re: [PATCH] OSSTEST: Install libtirpc-dev for libvirt builds To: Ian Jackson References: <20200723213134.11044-1-jfehlig@suse.com> <24369.7617.103361.244607@mariner.uk.xensource.com> From: Jim Fehlig Message-ID: <91fa6814-858d-be20-4a33-849e37d9bbca@suse.com> Date: Mon, 10 Aug 2020 08:26:38 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 In-Reply-To: <24369.7617.103361.244607@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR06CA0143.eurprd06.prod.outlook.com (2603:10a6:208:ab::48) To VI1PR0401MB2429.eurprd04.prod.outlook.com (2603:10a6:800:2c::13) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.55] (192.150.153.236) by AM0PR06CA0143.eurprd06.prod.outlook.com (2603:10a6:208:ab::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.17 via Frontend Transport; Mon, 10 Aug 2020 14:26:43 +0000 X-Originating-IP: [192.150.153.236] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 46413480-e80a-4b09-b9e0-08d83d39681e X-MS-TrafficTypeDiagnostic: VI1PR0402MB3824: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:409; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rSpCbJGXVAn0UyYCM4JrvbxO94EEDSSEUqGGLfQtCBQqEQ+Xmms6P+WcmCU7Hu+rIg3CVrp2v+bz5YKjnPuDYylC6DGEQhHUZIOSvlP0goac5INtoBmIq7HUgUIggWnQPSC4G5OOuBuDSpQ8pfqZ05zBr8+BPTMllAcVPUcv1EpzpDjrZu1uXNxBPBUOBEI76r1M2I0SIyNtHjmtQPxWS8XjD0n5gDIOHqRKKKjE1wdVFfUXl9eeSE/w/ZkG03AOsMihVBiU3Tt+50CcUW/CyqFTyK6xz57Y1LATFeEqhg+mAjxijmuqABPHd0UhbPpCjuVlncMGtB3rs+TdJmO8trKBa5wfxrndEbcuJDSyCloT3RPXicdkCnI9/m+Ueb7A X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR0401MB2429.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(366004)(376002)(39860400002)(346002)(396003)(136003)(956004)(36756003)(83380400001)(66556008)(66476007)(186003)(16526019)(26005)(6486002)(66946007)(4326008)(6666004)(53546011)(31696002)(31686004)(316002)(52116002)(2616005)(2906002)(8676002)(6916009)(16576012)(478600001)(5660300002)(86362001)(4744005)(8936002)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: +u3dThyVm5HAzCwZsJKzMnCja4KgiPkaS2i/Lmpt/BBvWShVBPaT8JWK2/lme9PixReB7ZaQ689u+Ayl/YZZT/el/i3nVp8ojEoeetJjKGArh4YKt/ZfFMPZJVusIJGg9ih2g9zy0mEhKzGazq0Z11Bn2U2zMSTnf2qPW7F15Dhq9MGznijES7sB0VWfJ73z4Y5dkETf3ntKLurMBsz43vCWN2Dc7WY2UG7xIMevMSY/wE99xX5nMIa/467WHLfyahB0xNp4wSCaFQ6heeAJZjD+0S9xg0FD6GoSG4T6ZDLNG7QYGf+3vnBGGUCQpOSJhlFhQukoPkg5m/k+ES2x4Gn9J6LrZxKFtqtOZerp1zSRVIx/b8hBE+lzdWY+/u8vBXMPvclMcyAQrIAULNGgoknlLV1nuY1+ygXYfpESOr7DTQmH1LldEqjrJe0ezp3sgTBP/qBZt5eNGNW+f3fBIfx2t9zF0ghB+oX4wI27Ba0b+6Accb1wQ147srE6cZkhxO/gg5G8AwHZan3mtFexWuSgR8/mtbgTGZdTgPrtzNf9TuTaGItoq95RZPhlbw3LkV5OHqMNcNNf9XASCBTXAsO1HqbNeYk3eRW2crt8J0EesaWgASNccydxEjLAfqietU62Rd3ZjT0DgQtVWToGug== X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 46413480-e80a-4b09-b9e0-08d83d39681e X-MS-Exchange-CrossTenant-AuthSource: VI1PR0401MB2429.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2020 14:26:44.5408 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kYA8UEDmPuzJS/F01wwIZSJxmGyjubLBa0Ce3Tskk4EyAX/ZUFFy3fN+wBFN3oXzN78/May/k+Hmk7Fq7m1HPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3824 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 8/10/20 4:13 AM, Ian Jackson wrote: > Jim Fehlig writes ("[PATCH] OSSTEST: Install libtirpc-dev for libvirt builds"): >> The check for XDR support was changed in libvirt commit d7147b3797 >> to use libtirpc pkg-config instead of complicated AC_CHECK_LIB, >> AC_COMPILE_IFELSE, et. al. logic. The libvirt OSSTEST has been >> failing since this change hit libvirt.git master. Fix it by adding >> libtirpc-dev to the list of 'extra_packages' installed for libvirt >> builds. >> >> Signed-off-by: Jim Fehlig > > Reviewed-by: Ian Jackson > > Thanks! I will push this to osstest pretest shortly. Thanks Ian! Perhaps you've noticed libvirt has now moved to the meson build system. My weak perl skills have discouraged me from investigating ways to accommodate that. Regards, Jim From xen-devel-bounces@lists.xenproject.org Mon Aug 10 14:38:41 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 14:38:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k58we-0008Jd-6D; Mon, 10 Aug 2020 14:38:36 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k58wc-0008JV-I6 for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 14:38:34 +0000 X-Inumbo-ID: b032379c-6dd9-473a-8e01-0e058991cac3 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b032379c-6dd9-473a-8e01-0e058991cac3; Mon, 10 Aug 2020 14:38:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1597070314; h=subject:from:to:cc:references:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=vJ8dmo/QwxWAU3avpF0Dyh7p54QkxZbboNwEPvKU0bY=; b=Y4lhEhdAAKh+jQYzNJnj9XNDthCkIaeiwHM9VFXnRKr0UsX3JD0kiDk+ klwIWQMFwzXSJlfC9+quESrhMlZT5YBnMZY2Y1cpAkEzetj97kTN6cS4D geK8NJUytGwRtnZf+nYiHjrPm3pXyiKPKmrp9i1z0v627UXCSdvJzaqxY 0=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: yVArj69cwGdbAc4XJMplrUGOO5p8oFN0LYe3fIvfu5trejZ/7t3u0AkmIrBo42c1bDwzodo8jG 6iRfa82htnOV74g/teD02lpdANupbD07AK6gWIUvXaj72SRckfbJZkn23SSCXaC3zNHhFcstPT 4lHCeOOBZ3NirmPQIGcXfXzHqGQmtqwnJUCGyo4vlGfvJfsBAaiDrQd6aOGqnT6Bf3ZP4iEyrF 6XO3x4cQYPLID9lTCmrTgzMNPvipD94yy8dQvlpnJHbuxHIwpfRoLSlT7lfDjGHQI3B49GgWGc y2E= X-SBRS: 2.7 X-MesageID: 24197825 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,457,1589256000"; d="scan'208";a="24197825" Subject: Re: [PATCH v2 1/7] x86/EFI: sanitize build logic From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <3a8356a9-313c-6de8-f409-977eae1fbfa5@suse.com> <07e622b4-bb61-08e8-d96c-e770ec7abc53@suse.com> <0a544a9d-edc8-cb71-05a2-77c860050836@citrix.com> Message-ID: <6eab1af6-1845-c4b6-5fbb-76d9974404f1@citrix.com> Date: Mon, 10 Aug 2020 15:38:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <0a544a9d-edc8-cb71-05a2-77c860050836@citrix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 07/08/2020 17:33, Andrew Cooper wrote: > On 07/08/2020 12:32, Jan Beulich wrote: >> With changes done over time and as far as linking goes, the only special >> thing about building with EFI support enabled is the need for the dummy >> relocations object for xen.gz uniformly in all build stages. All other >> efi/*.o can be consumed from the built_in*.o files. >> >> In efi/Makefile, besides moving relocs-dummy.o to "extra", also properly >> split between obj-y and obj-bin-y. >> >> Signed-off-by: Jan Beulich > Acked-by: Andrew Cooper > > I'd prefer to see this all in Kconfig, but this is a clear improvement > in its own right. Actually, it breaks the build with LIVEPATCH enabled. make[2]: *** No rule to make target 'efi/buildid.o', needed by '/local/security/xen.git/xen/xen.efi'.  Stop. make[2]: *** Waiting for unfinished jobs.... Makefile:355: recipe for target '/local/security/xen.git/xen/xen' failed From xen-devel-bounces@lists.xenproject.org Mon Aug 10 15:17:52 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 15:17:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k59YV-0003GW-A8; Mon, 10 Aug 2020 15:17:43 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k59YT-0003GR-VX for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 15:17:42 +0000 X-Inumbo-ID: 117a42e4-a2a3-4d1e-ba08-85b4588d2c96 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 117a42e4-a2a3-4d1e-ba08-85b4588d2c96; Mon, 10 Aug 2020 15:17:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1597072660; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=MuVaQQQS00VxLuoI+eySNOnbLtmhSt7iT1Acd8MfNBk=; b=REulUawi79upWINyQQBQhCXHaFNcb/lKmI4ZPVC0o6BjUVct6w9KNILI XGIUiC24Gg5l+6FvlOmZljWdbmu1ztVt/g9h4Y8sT8eRq6DuGNc0Q7wCL u8kLExCZ3kd6ghyeZoBaoS6PFgXW5fPLQRTlCe5orU+OMBKXM8wZpg8DR U=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: q3AvQsF6wTuD8vajCChvoRHlWOjqr7CePcO2BliNFURUFHXH5ee+RzxXid6TroYILFxE9Zr5/t byWoDwUXPUowSX5HeEr3HrYDpIR2tj+xD2x2HxZdD+/8QPxLkUFljcGaPQXjzXIYkBqF9G3XE0 yuLR3Vs99hHjUiMF1FjG0S0wPXKHOeSRtFAL/TMbwPUAy74KNMQYY9MSrxUO5cSMPi+6EpduA1 jPtN+d5l4N1pkHawRiBTSZ/8ZC3mzBQlnidu8ndhQ3epmAjZ9ITSgCQsC2AZ3SnwJEJUzLv1LX HbY= X-SBRS: 2.7 X-MesageID: 24522621 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,457,1589256000"; d="scan'208";a="24522621" From: George Dunlap To: Ian Jackson Subject: Re: [PATCH] libxl: avoid golang building without CONFIG_GOLANG=y Thread-Topic: [PATCH] libxl: avoid golang building without CONFIG_GOLANG=y Thread-Index: AQHWaW0Cnjv2J5dpD0iO4FcEWA2no6kn31uAgAAShQCAAAIpAIAABZqAgAAA3oCAAADsgIAAAV+AgAALJACAASC1gIAINbsA Date: Mon, 10 Aug 2020 15:17:36 +0000 Message-ID: <2B6E76FB-C520-4988-9C3A-BD495568360E@citrix.com> References: <20200804141639.k2tpoqy7jj34gcm6@liuwe-devbox-debian-v2> <0deed4c6-ca87-09d3-a19c-ac0c00003cb7@suse.com> <20200804155043.vq7aupbrvmmcgzlv@liuwe-devbox-debian-v2> <12790d2b-020d-b6fe-4924-2233a4e93d83@suse.com> <20200804155707.rrtzkksrle2nojbj@liuwe-devbox-debian-v2> <43f706e4-0292-5758-eb19-9fbb99b1337e@suse.com> <24362.33281.726014.586449@mariner.uk.xensource.com> In-Reply-To: <24362.33281.726014.586449@mariner.uk.xensource.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3608.120.23.2.1) x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted Content-Type: text/plain; charset="utf-8" Content-ID: <0243A5921A5CD64099F0223AF063D45C@citrix.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony Perard , Wei Liu , Nick Rosbrook , Jan Beulich , "xen-devel@lists.xenproject.org" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" DQoNCj4gT24gQXVnIDUsIDIwMjAsIGF0IDEwOjU1IEFNLCBJYW4gSmFja3NvbiA8aWFuLmphY2tz b25AY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBOaWNrIFJvc2Jyb29rIHdyaXRlcyAoIlJlOiBb UEFUQ0hdIGxpYnhsOiBhdm9pZCBnb2xhbmcgYnVpbGRpbmcgd2l0aG91dCBDT05GSUdfR09MQU5H PXkiKToNCj4+IEphbiAtIGlzIHRoZSBwcm9ibGVtIHNwZWNpZmljYWxseSB0aGF0IGEgZnJlc2gg Y2xvbmUsICBvciBgZ2l0DQo+PiBjaGVja291dGAsIGV0Yy4gY2hhbmdlcyBmaWxlIHRpbWVzdGFt cHMgaW4gYSB3YXkgdGhhdCB0cmlnZ2VycyBtYWtlIHRvDQo+PiByZWJ1aWxkIHRob3NlIHRhcmdl dHM/IEkgaGF2ZSBub3QgdXNlZCB0aGUgbW92ZS1pZi1jaGFuZ2VkIGFwcHJvYWNoDQo+PiBiZWZv cmUsIGJ1dCBBRkFJQ1QgdGhhdCB3b3VsZCBiZSBzdWZmaWNpZW50Lg0KPiANCj4gSSBkb24ndCB0 aGluayB0aGVyZSBpcywgZnJvbSB0aGUgcG9pbnQgb2YgdmlldyBvZiB0aGUgYnVpbGQgc3lzdGVt LA0KPiBhbnl0aGluZyBkaWZmZXJlbnQgYWJvdXQgZ2VuZ290eXBlcyB0aGFuIGFib3V0IGFueSBv dGhlciBpbi10cmVlDQo+IGNvbW1pdHRlZCBmaWxlIHdoaWNoIGlzIHVwZGF0ZWQgdXNpbmcgbWFr ZWZpbGUgcnVsZXMgYmFzZWQgb24gb25seQ0KPiBvdGhlciBpbi10cmVlIGZpbGVzIGFuZCBjb21t b24gdXRpbGl0aWVzIChlZywgaW4gdGhpcyBjYXNlLCBQeXRob24pLg0KPiANCj4gSSBndWVzcyB1 c2luZyBtb3ZlLWlmLWNoYW5nZWQgd2lsbCBwcm9iYWJseSBmaXggdGhpcy4NCg0KVGhhdOKAmXMg cHJvYmFibHkgdGhlIHF1aWNrZXN0IGZpeCBBVE0uDQoNCj4gSmFuOiB0aGUgcmVhc29ucyB3aHkg dGhpcyBvdXRwdXQgZmlsZSBoYXMgdG8gYmUgY29tbWl0dGVkIGFyZQ0KPiBjb21wbGljYXRlZC4g IFdlJ3ZlIGRpc2N1c3NlZCB0aGVtIGF0IGxlbmd0aC4gIFVsdGltYXRlbHkgdGhlIHJlYXNvbg0K PiBpcyBkZWxpYmVyYXRlIGRlZmljaWVuY2llc1sxXSBpbiBnb2xhbmcuICBTYWRseSB0aGlzIGlz IHRoZSBiZXN0IG9mIGENCj4gbm90LXZlcnktZ29vZCBzZXQgb2Ygb3B0aW9ucy4NCg0KSSB0aGlu ayB3ZSBkZWNpZGVkIGF0IHRoZSBTdW1taXQgdG8gbWFrZSBhIHNlcGFyYXRlIHJlcG8gZm9yIHRo ZSBnZW5lcmF0ZWQgY29kZSwgZGlkbuKAmXQgd2U/DQoNClRvIGV4cGFuZCBvbiB0aGlzLCBKYW46 DQoNCjEuIEEgKnVzZWZ1bCogZ28gcGFja2FnZSBtdXN0IGJlIGFibGUgdG8gYmUgZG93bmxvYWRl ZCBhbmQgYnVpbHQgYnkgdGhlIGdvIGJ1aWxkIHRvb2xzIGZyb20gdGhlIFVSTCBvZiBhIGdpdCBy ZXBvDQoNCjIuIFRoZSBnbyBidWlsZCBwcm9jZXNzIGlzIHJlc3RyaWN0ZWQgaW4gd2hhdCBpdCB3 aWxsIGRvIGF1dG9tYXRpY2FsbHkgZm9yIHNlY3VyaXR5IHJlYXNvbnMuDQoNCkZvciA0LjE0LCB3 ZSBjaG9zZSB0byBjaGVjayB0aGUgZ2VuZXJhdGVkIGNvZGUgaW50byB4ZW4uZ2l0LCBzbyB0aGF0 IHRoZSBtYWluIFhlbiByZXBvIGNvdWxkIGZ1bGZpbGwgIzEuICBUbyBtYWtlIHN1cmUgdGhhdCB0 aGUgZ2VuZXJhdGVkIGNvZGUgd2FzIGtlcHQgdXAgdG8gZGF0ZSB3aXRoIGNoYW5nZXMgaW4gbGli eGxfdHlwZXMuaWRsLCB3ZSBkZWNpZGVkIHRvIHJlLWdlbmVyYXRlIHRoZSBjb2RlIGV2ZW4gZm9y IHN5c3RlbXMgd2hpY2ggZG9u4oCZdCBoYXZlIGdvbGFuZyBpbnN0YWxsZWQuDQoNCkJ1dCB0aGlz IGlzIGFub3RoZXIgZXhhbXBsZSBvZiB0aGUgYW5ub3lpbmcgc2lkZSBlZmZlY3RzIG9mIHRoaXMg YXBwcm9hY2guDQoNClRoZSBvdGhlciBhcHByb2FjaCwgd2hpY2ggSSB0aG91Z2h0IHdl4oCZZCBh Z3JlZWQgdXBvbiBhdCB0aGUgc3VtbWl0LCBpcyB0byBoYXZlIGEgc2VwYXJhdGUgcmVwbyB3aXRo IGEgbW9yZSBmcmllbmRseSBVUkwgd2hpY2ggaXMgcHJvZ3JhbW1hdGljYWxseSBnZW5lcmF0ZWQg b24gYSByZWd1bGFyIGJhc2lzLiAgVGhhdCB3b3VsZCBvYnZpYXRlIHRoZSBuZWVkIHRvIHJ1biB0 aGUgZ2VuZXJhdG9yLCBleGNlcHQgdG8gdmVyaWZ5IHRoYXQgdGhlIGdlbmVyYXRlZCBjb2RlIHN0 aWxsIGNvbXBpbGVkICh3aGljaCB3b3VsZG7igJl0IGJlIHBvc3NpYmxlIHdpdGhvdXQgaGF2aW5n IGdvbGFuZyBpbnN0YWxsZWQgYW55d2F5KS4NCg0KPiBbMV0gVGhpcyBpcyBhbiBleHRyZW1lIHBo cmFzZSwgYnV0IGp1c3RpZmllZCBJIHRoaW5rLiAgVGhlIGdvbGFuZw0KPiBkZXNpZ25lcnMgaGF2 ZSBkZWxpYmVyYXRlbHkgYWltZWQgYXQgd2hhdCB0aGV5IHJlZ2FyZCBhcyAic2ltcGxpY2l0eSIN Cj4gYW5kIG9uZSBvZiB0aGUgdGhpbmdzIHRoZXkgaGF2ZSAic2ltcGxpZmllZCIgYXdheSAoaW4g dGhlaXIgbGFuZ3VhZ2UNCj4gYW5kIGluIHRoZWlyIHBhY2thZ2UgbWFuYWdlbWVudCBhbmQgYnVp bGQgdG9vbHMpIGlzIHRoZSBhYmlsaXR5IHRvDQo+IGNvbnZlbmllbnRseSBnZW5lcmF0ZSBnb2xh bmcgY29kZSBhdCBidWlsZCB0aW1lLiAgQ29tbWl0dGluZyB0aGUNCj4gZ2VuZXJhdGVkIGNvZGUg aXMgdGhlIG5vcm0gaW4gdGhlIGdvbGFuZyBjb21tdW5pdHkuDQoNCkl04oCZcyBhIGJpdCBsZXNz IHVucmVhc29uYWJsZSB0aGFuIHRoaXMuIDotKSAgVGhlcmUgYWN0dWFsbHkgaXMgaW5mcmFzdHJ1 Y3R1cmUgZm9yIGdlbmVyYXRpbmcgZmlsZXMg4oCUIGBnbyBnZW5lcmF0ZWAuICBJdOKAmXMganVz dCBub3QgYWxsb3dlZCB0byBydW4gYXMgcGFydCBvZiBhIGJ1aWxkLg0KDQpPbmUgb2YgdGhlIGNv cmUgdGhpbmdzIHRoZXkgd2FudGVkIHRvIGJlIGFibGUgdG8gZG8gd2FzIHRvIGRvd25sb2FkIGFu ZCBidWlsZCBkZXBlbmRlbmNpZXMsIHJlY3Vyc2l2ZWx5IGFuZCBhdXRvbWF0aWNhbGx5LCBmcm9t IGFyYml0cmFyeSBVUkxzLCB3aXRob3V0IHRoZSBuZWVkIGZvciBhbnkgY3VyYXRpb24uICBGb3Ig c2FmZXR5IGNvbmNlcm5zLCB0aGV5IGRvbuKAmXQgd2FudCBhbnkgc3VjaCBkZXBlbmRlbmNpZXMg dG8gYmUgYWJsZSB0byBydW4gYXJiaXRyYXJ5IGNvbW1hbmRzIGFzIHBhcnQgb2YgdGhlaXIgYnVp bGQ6IEdvIGJ1aWxkcyBjYW4gYmFzaWNhbGx5IGNhbGwgY29tcGlsZXJzIGFuZCBsaW5rZXJzIGFu ZCB0aGF04oCZcyBpdC4NCg0KTm90IHN1cmUgSSBhY3R1YWxseSBidXkgdGhhdCB0aGlzIGdpdmVz IHlvdSBhIHdob2xlIGxvdCBvZiBzYWZldHksIHNpbmNlIHRoZXJl4oCZcyBub3QgYSBub3Qgb2Yg cG9pbnQgaW4gY29tcGlsaW5nIHNvbWV0aGluZyB5b3XigJlyZSBub3QgZ29pbmcgdG8gcnVuOyBh bmQgaXTigJlzIG5vdCBjbGVhciB0byBtZSB0aGF0IGl04oCZcyB0ZXJyaWJseSBtb3JlIHJpc2t5 IHRvIHJ1biBjb2RlIHlvdSBoYXZlbuKAmXQgdmV0dGVkIHRoYW4gdG8gYnVpbGQgY29kZSB5b3Ug aGF2ZW7igJl0IHZldHRlZC4gIEJ1dCBhdCBsZWFzdCBpdOKAmXMgbm90IG9idmlvdXNseSB3cm9u Zy4NCg0KIC1HZW9yZ2UNCg0K From xen-devel-bounces@lists.xenproject.org Mon Aug 10 15:24:25 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 15:24:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k59ev-00048j-5f; Mon, 10 Aug 2020 15:24:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k59eu-00048e-Jy for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 15:24:20 +0000 X-Inumbo-ID: 1d694ced-4a14-4482-95eb-827d14a2c1ad Received: from chiark.greenend.org.uk (unknown [2001:ba8:1e3::]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1d694ced-4a14-4482-95eb-827d14a2c1ad; Mon, 10 Aug 2020 15:24:19 +0000 (UTC) Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by chiark.greenend.org.uk (Debian Exim 4.84_2 #1) with esmtp (return-path ijackson@chiark.greenend.org.uk) id 1k59er-0007Qb-VJ; Mon, 10 Aug 2020 16:24:18 +0100 From: Ian Jackson To: xen-devel@lists.xenproject.org Subject: [OSSTEST PATCH] SQL: Change "... LIKE '...\_...' ..." to "... LIKE '...\\_...' ..." Date: Mon, 10 Aug 2020 16:24:04 +0100 Message-Id: <20200810152404.15325-1-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Ian Jackson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Perl's "" quotes, and corresponding < --- Osstest/Executive.pm | 2 +- cs-bisection-step | 8 ++++---- mg-force-push | 2 +- mg-report-host-usage-collect | 2 +- sg-report-flight | 4 ++-- sg-report-host-history | 8 ++++---- sg-report-job-history | 2 +- ts-logs-capture | 2 +- 8 files changed, 15 insertions(+), 15 deletions(-) diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm index 1e94b282..0808202b 100644 --- a/Osstest/Executive.pm +++ b/Osstest/Executive.pm @@ -444,7 +444,7 @@ END $querytext .= <{Rtuple}; diff --git a/mg-force-push b/mg-force-push index 3a701a11..9c3cc786 100755 --- a/mg-force-push +++ b/mg-force-push @@ -54,7 +54,7 @@ END FROM rv url JOIN rv built ON url.job = built.job - AND url.name LIKE 'tree\_%' + AND url.name LIKE 'tree\\_%' AND built.name = 'built_revision_' || substring(url.name, 6) WHERE url.val = ? END diff --git a/mg-report-host-usage-collect b/mg-report-host-usage-collect index 1944c8d7..34d24943 100755 --- a/mg-report-host-usage-collect +++ b/mg-report-host-usage-collect @@ -166,7 +166,7 @@ END SELECT val, synth FROM runvars WHERE flight=? AND job=? - AND (name LIKE '%\_host' OR name='host') + AND (name LIKE '%\\_host' OR name='host') END my $finishq = db_prepare(</dev/null"; -my $namecond= "(name = 'host' OR name LIKE '%\_host')"; +my $namecond= "(name = 'host' OR name LIKE '%\\_host')"; csreadconfig(); while (@ARGV && $ARGV[0] =~ m/^-/) { @@ -172,7 +172,7 @@ sub mainquery ($) { SELECT flight, job, name, status FROM runvars JOIN jobs USING (flight, job) - WHERE (name = 'host' OR name LIKE '%\_host') + WHERE (name = 'host' OR name LIKE '%\\_host') AND val = ? AND $flightcond AND $restrictflight_cond @@ -246,7 +246,7 @@ END FROM runvars WHERE flight=? AND job=? AND ( - name LIKE (? || '\_power\_%') + name LIKE (? || '\\_power\\_%') ) END @@ -449,7 +449,7 @@ foreach my $host (@ARGV) { SELECT DISTINCT val FROM runvars WHERE flight=? - AND (name = 'host' OR name LIKE '%\_host') + AND (name = 'host' OR name LIKE '%\\_host') END $hostsinflightq->execute($flight); while (my $row = $hostsinflightq->fetchrow_hashref()) { diff --git a/sg-report-job-history b/sg-report-job-history index 22a28627..6008ca72 100755 --- a/sg-report-job-history +++ b/sg-report-job-history @@ -92,7 +92,7 @@ if (defined($flight)) { our $revisionsq= db_prepare(<prepare(<execute($flight, $job); -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 10 15:45:13 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 15:45:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k59yr-0006Hd-Rm; Mon, 10 Aug 2020 15:44:57 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k59yq-0006HX-4A for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 15:44:56 +0000 X-Inumbo-ID: ba908b98-eaf4-4893-82bf-1d1fa1e7e90f Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ba908b98-eaf4-4893-82bf-1d1fa1e7e90f; Mon, 10 Aug 2020 15:44:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5QAXP4UYNN7yGkrkRUaK70/8Ehd9BsqTA/H5YBOiq60=; b=hJqT3eXqBfaHVbUSDfvmGz3hxr r4QQw8Iwg7/bEmIupAfLailzp5KIdBipzpL27h2ZGUfkxW0Y67oheAdlNx01CSO0MtLgN2ZhHNNch STCQnhl9CZAKbevJt7hPjvGlfF/L1y5InzfPN3Tg4pigDvJB8IC7ngtQDVuR5zP06IfU=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k59yn-0001NL-1a; Mon, 10 Aug 2020 15:44:53 +0000 Received: from [54.239.6.186] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k59ym-0007MT-Jq; Mon, 10 Aug 2020 15:44:52 +0000 Subject: Re: [PATCH v2 4/7] bitmap: move to/from xenctl_bitmap conversion helpers To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <3a8356a9-313c-6de8-f409-977eae1fbfa5@suse.com> <677805f1-c44c-ef65-8190-c4de3bdb327d@suse.com> From: Julien Grall Message-ID: <3163b048-921b-fa87-e372-46dd13deb0da@xen.org> Date: Mon, 10 Aug 2020 16:44:50 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <677805f1-c44c-ef65-8190-c4de3bdb327d@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: George Dunlap , Andrew Cooper , Stefano Stabellini , Wei Liu , Ian Jackson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Hi, On 07/08/2020 12:33, Jan Beulich wrote: > A subsequent change will exclude domctl.c from getting built for a > particular configuration, yet the two functions get used from elsewhere. > > Signed-off-by: Jan Beulich Acked-by: Julien Grall Cheers, > --- > v2: Move function decls to xen/bitmap.h. > > --- a/xen/common/bitmap.c > +++ b/xen/common/bitmap.c > @@ -9,6 +9,8 @@ > #include > #include > #include > +#include > +#include > #include > > /* > @@ -384,3 +386,87 @@ void bitmap_byte_to_long(unsigned long * > } > > #endif > + > +int bitmap_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_bitmap, > + const unsigned long *bitmap, unsigned int nbits) > +{ > + unsigned int guest_bytes, copy_bytes, i; > + uint8_t zero = 0; > + int err = 0; > + uint8_t *bytemap = xmalloc_array(uint8_t, (nbits + 7) / 8); > + > + if ( !bytemap ) > + return -ENOMEM; > + > + guest_bytes = (xenctl_bitmap->nr_bits + 7) / 8; > + copy_bytes = min_t(unsigned int, guest_bytes, (nbits + 7) / 8); > + > + bitmap_long_to_byte(bytemap, bitmap, nbits); > + > + if ( copy_bytes != 0 ) > + if ( copy_to_guest(xenctl_bitmap->bitmap, bytemap, copy_bytes) ) > + err = -EFAULT; > + > + for ( i = copy_bytes; !err && i < guest_bytes; i++ ) > + if ( copy_to_guest_offset(xenctl_bitmap->bitmap, i, &zero, 1) ) > + err = -EFAULT; > + > + xfree(bytemap); > + > + return err; > +} > + > +int xenctl_bitmap_to_bitmap(unsigned long *bitmap, > + const struct xenctl_bitmap *xenctl_bitmap, > + unsigned int nbits) > +{ > + unsigned int guest_bytes, copy_bytes; > + int err = 0; > + uint8_t *bytemap = xzalloc_array(uint8_t, (nbits + 7) / 8); > + > + if ( !bytemap ) > + return -ENOMEM; > + > + guest_bytes = (xenctl_bitmap->nr_bits + 7) / 8; > + copy_bytes = min_t(unsigned int, guest_bytes, (nbits + 7) / 8); > + > + if ( copy_bytes != 0 ) > + { > + if ( copy_from_guest(bytemap, xenctl_bitmap->bitmap, copy_bytes) ) > + err = -EFAULT; > + if ( (xenctl_bitmap->nr_bits & 7) && (guest_bytes == copy_bytes) ) > + bytemap[guest_bytes-1] &= ~(0xff << (xenctl_bitmap->nr_bits & 7)); > + } > + > + if ( !err ) > + bitmap_byte_to_long(bitmap, bytemap, nbits); > + > + xfree(bytemap); > + > + return err; > +} > + > +int cpumask_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_cpumap, > + const cpumask_t *cpumask) > +{ > + return bitmap_to_xenctl_bitmap(xenctl_cpumap, cpumask_bits(cpumask), > + nr_cpu_ids); > +} > + > +int xenctl_bitmap_to_cpumask(cpumask_var_t *cpumask, > + const struct xenctl_bitmap *xenctl_cpumap) > +{ > + int err = 0; > + > + if ( alloc_cpumask_var(cpumask) ) { > + err = xenctl_bitmap_to_bitmap(cpumask_bits(*cpumask), xenctl_cpumap, > + nr_cpu_ids); > + /* In case of error, cleanup is up to us, as the caller won't care! */ > + if ( err ) > + free_cpumask_var(*cpumask); > + } > + else > + err = -ENOMEM; > + > + return err; > +} > --- a/xen/common/domctl.c > +++ b/xen/common/domctl.c > @@ -34,91 +34,6 @@ > > static DEFINE_SPINLOCK(domctl_lock); > > -static int bitmap_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_bitmap, > - const unsigned long *bitmap, > - unsigned int nbits) > -{ > - unsigned int guest_bytes, copy_bytes, i; > - uint8_t zero = 0; > - int err = 0; > - uint8_t *bytemap = xmalloc_array(uint8_t, (nbits + 7) / 8); > - > - if ( !bytemap ) > - return -ENOMEM; > - > - guest_bytes = (xenctl_bitmap->nr_bits + 7) / 8; > - copy_bytes = min_t(unsigned int, guest_bytes, (nbits + 7) / 8); > - > - bitmap_long_to_byte(bytemap, bitmap, nbits); > - > - if ( copy_bytes != 0 ) > - if ( copy_to_guest(xenctl_bitmap->bitmap, bytemap, copy_bytes) ) > - err = -EFAULT; > - > - for ( i = copy_bytes; !err && i < guest_bytes; i++ ) > - if ( copy_to_guest_offset(xenctl_bitmap->bitmap, i, &zero, 1) ) > - err = -EFAULT; > - > - xfree(bytemap); > - > - return err; > -} > - > -int xenctl_bitmap_to_bitmap(unsigned long *bitmap, > - const struct xenctl_bitmap *xenctl_bitmap, > - unsigned int nbits) > -{ > - unsigned int guest_bytes, copy_bytes; > - int err = 0; > - uint8_t *bytemap = xzalloc_array(uint8_t, (nbits + 7) / 8); > - > - if ( !bytemap ) > - return -ENOMEM; > - > - guest_bytes = (xenctl_bitmap->nr_bits + 7) / 8; > - copy_bytes = min_t(unsigned int, guest_bytes, (nbits + 7) / 8); > - > - if ( copy_bytes != 0 ) > - { > - if ( copy_from_guest(bytemap, xenctl_bitmap->bitmap, copy_bytes) ) > - err = -EFAULT; > - if ( (xenctl_bitmap->nr_bits & 7) && (guest_bytes == copy_bytes) ) > - bytemap[guest_bytes-1] &= ~(0xff << (xenctl_bitmap->nr_bits & 7)); > - } > - > - if ( !err ) > - bitmap_byte_to_long(bitmap, bytemap, nbits); > - > - xfree(bytemap); > - > - return err; > -} > - > -int cpumask_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_cpumap, > - const cpumask_t *cpumask) > -{ > - return bitmap_to_xenctl_bitmap(xenctl_cpumap, cpumask_bits(cpumask), > - nr_cpu_ids); > -} > - > -int xenctl_bitmap_to_cpumask(cpumask_var_t *cpumask, > - const struct xenctl_bitmap *xenctl_cpumap) > -{ > - int err = 0; > - > - if ( alloc_cpumask_var(cpumask) ) { > - err = xenctl_bitmap_to_bitmap(cpumask_bits(*cpumask), xenctl_cpumap, > - nr_cpu_ids); > - /* In case of error, cleanup is up to us, as the caller won't care! */ > - if ( err ) > - free_cpumask_var(*cpumask); > - } > - else > - err = -ENOMEM; > - > - return err; > -} > - > static int nodemask_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_nodemap, > const nodemask_t *nodemask) > { > --- a/xen/include/xen/bitmap.h > +++ b/xen/include/xen/bitmap.h > @@ -273,6 +273,13 @@ static inline void bitmap_clear(unsigned > void bitmap_long_to_byte(uint8_t *bp, const unsigned long *lp, int nbits); > void bitmap_byte_to_long(unsigned long *lp, const uint8_t *bp, int nbits); > > +struct xenctl_bitmap; > +int xenctl_bitmap_to_bitmap(unsigned long *bitmap, > + const struct xenctl_bitmap *xenctl_bitmap, > + unsigned int nbits); > +int bitmap_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_bitmap, > + const unsigned long *bitmap, unsigned int nbits); > + > #endif /* __ASSEMBLY__ */ > > #endif /* __XEN_BITMAP_H */ > --- a/xen/include/xen/domain.h > +++ b/xen/include/xen/domain.h > @@ -27,9 +27,6 @@ struct xen_domctl_getdomaininfo; > void getdomaininfo(struct domain *d, struct xen_domctl_getdomaininfo *info); > void arch_get_domain_info(const struct domain *d, > struct xen_domctl_getdomaininfo *info); > -int xenctl_bitmap_to_bitmap(unsigned long *bitmap, > - const struct xenctl_bitmap *xenctl_bitmap, > - unsigned int nbits); > > /* > * Arch-specifics. > -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Aug 10 16:30:16 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 16:30:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5AgZ-0002UR-DU; Mon, 10 Aug 2020 16:30:07 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5AgY-0002UM-L9 for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 16:30:06 +0000 X-Inumbo-ID: df600f23-b581-4e8d-a3d6-c79092e5d976 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id df600f23-b581-4e8d-a3d6-c79092e5d976; Mon, 10 Aug 2020 16:30:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PvsCx8S2JYO+IEBaSTZwP9snZvkloGE0UQ91hC/SGms=; b=g+qVPyvScwQ9MQFBO7YZeXDMBp o8dnzvTFjqJ2GWeWQZChvO4kEx9mdKjyMDCfOuOWB6PRgjrWo0yVqvVwGoVCotDc0cjoPsXJ04Eui ADKPlvZYfFzWc+VpxuoV/GL5yDGKgxx7xoNvXfF7dKORNOoFiZUKa9HY021NQTbzCm+I=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5AgM-0002ox-Dz; Mon, 10 Aug 2020 16:29:54 +0000 Received: from [54.239.6.186] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k5AgM-00010k-4W; Mon, 10 Aug 2020 16:29:54 +0000 Subject: Re: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common To: Oleksandr , xen-devel@lists.xenproject.org References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-2-git-send-email-olekstysh@gmail.com> <6bfc3920-8f29-188c-cff4-2b99dabe166f@xen.org> From: Julien Grall Message-ID: Date: Mon, 10 Aug 2020 17:29:51 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Tian , Stefano Stabellini , Jan Beulich , Wei Liu , Paul Durrant , Andrew Cooper , Ian Jackson , George Dunlap , Tim Deegan , Oleksandr Tyshchenko , Julien Grall , Jun Nakajima , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Hi, On 06/08/2020 12:37, Oleksandr wrote: > > On 05.08.20 16:30, Julien Grall wrote: >> Hi, > > Hi Julien > > >> >> On 03/08/2020 19:21, Oleksandr Tyshchenko wrote: >>> From: Oleksandr Tyshchenko >>> >>> As a lot of x86 code can be re-used on Arm later on, this patch >>> splits IOREQ support into common and arch specific parts. >>> >>> This support is going to be used on Arm to be able run device >>> emulator outside of Xen hypervisor. >>> >>> Please note, this is a split/cleanup of Julien's PoC: >>> "Add support for Guest IO forwarding to a device emulator" >>> >>> Signed-off-by: Julien Grall >>> Signed-off-by: Oleksandr Tyshchenko >>> --- >>>   xen/arch/x86/Kconfig            |    1 + >>>   xen/arch/x86/hvm/dm.c           |    2 +- >>>   xen/arch/x86/hvm/emulate.c      |    2 +- >>>   xen/arch/x86/hvm/hvm.c          |    2 +- >>>   xen/arch/x86/hvm/io.c           |    2 +- >>>   xen/arch/x86/hvm/ioreq.c        | 1431 >>> +-------------------------------------- >>>   xen/arch/x86/hvm/stdvga.c       |    2 +- >>>   xen/arch/x86/hvm/vmx/realmode.c |    1 + >>>   xen/arch/x86/hvm/vmx/vvmx.c     |    2 +- >>>   xen/arch/x86/mm.c               |    2 +- >>>   xen/arch/x86/mm/shadow/common.c |    2 +- >>>   xen/common/Kconfig              |    3 + >>>   xen/common/Makefile             |    1 + >>>   xen/common/hvm/Makefile         |    1 + >>>   xen/common/hvm/ioreq.c          | 1430 >>> ++++++++++++++++++++++++++++++++++++++ >>>   xen/include/asm-x86/hvm/ioreq.h |   45 +- >>>   xen/include/asm-x86/hvm/vcpu.h  |    7 - >>>   xen/include/xen/hvm/ioreq.h     |   89 +++ >>>   18 files changed, 1575 insertions(+), 1450 deletions(-) >> >> That's quite a lot of code moved in a single patch. How can we check >> the code moved is still correct? Is it a verbatim copy? > In this patch I mostly tried to separate a common IOREQ part which also > resulted in updating x86 sources to include new header.  Also I moved > hvm_ioreq_needs_completion() to common header (which probably wanted to > be in a separate patch). It was a verbatim copy initially (w/o > hvm_map_mem_type_to_ioreq_server) and then updated to deal with arch > specific parts. I would prefer if the two parts are done separately. IOW, the code movement be nearly a verbatim copy. > In which way do you want me to split this patch? > > I could think of the following: > > 1. Copy of x86's ioreq.c/ioreq.h to common code > 2. Update common ioreq.c/ioreq.h > 3. Update x86's parts to be able to deal with common code > 4. Move hvm_ioreq_needs_completion() to common code > Ideally the code movement should be done in the same patch. This helps to check the patch is only moving code and also avoids mistakes on rebase. So my preference would be to first modify the x86 code (e.g. renaming) to make it common and then have one patch that will move the code. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Aug 10 16:42:31 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 16:42:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5AsK-0003RD-Fl; Mon, 10 Aug 2020 16:42:16 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5AsJ-0003R8-1T for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 16:42:15 +0000 X-Inumbo-ID: 01ebea01-743f-45a9-8fd3-2bd121a82ed2 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 01ebea01-743f-45a9-8fd3-2bd121a82ed2; Mon, 10 Aug 2020 16:42:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1597077733; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=EcgfFN/+d8mb20FR7tJz9Rr+CJutAnglFHqFQLdce2M=; b=QUUJB1rbErihSsV83x6dr5dQpOqUscV70+39AesoedAPAqc1OCsmpHiX fNruXCoSsc9Ic+U9jMSVooPNR699nTWB7gvTI8z/sUq6JsrSVA2iIURAO YCx9N02LU0AvSlxQytjItC7/pOxXP50Lbiu/33V6Aq4sBBGqjPPRNlfon 0=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: clb2IGQRU5WW/DHB10O/9taj+PCWQ4eZ1ZY+J/vwTkzn1gWI2MdsSlBq4Maad/9WK4RoWWhThO bGZGxhOFHS+4tme3oM0UhYgl0st+j7i37xLmGlHWO9JKnY+eVVvaFE+21Oke73C1tedDFLhSHa T9q7pcNg/uxtnpCaQfUeV7RDlDZWTEavd6dx8K4XzdtZMw8WbxTnwzWe5lg6sta+fwEDdg6ede DG0oCAw+4cENpgAfhZy3t25stfoLu/Lg72ZNkb27Kw+I4tc9QQ8LfZ4Yqr81NaZLltRbO2JfyM TCg= X-SBRS: 2.7 X-MesageID: 24367557 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,458,1589256000"; d="scan'208";a="24367557" Subject: Re: [PATCH 3/3] x86: don't override INVALID_M2P_ENTRY with SHARED_M2P_ENTRY To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <1d83fd35-6ea5-289c-d8db-029c50957f85@suse.com> From: Andrew Cooper Message-ID: Date: Mon, 10 Aug 2020 17:42:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1d83fd35-6ea5-289c-d8db-029c50957f85@suse.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 06/08/2020 10:29, Jan Beulich wrote: > While in most cases code ahead of the invocation of set_gpfn_from_mfn() > deals with shared pages, at least in set_typed_p2m_entry() I can't spot > such handling (it's entirely possible there's code missing there). Let's > try to play safe and add an extra check. > > Signed-off-by: Jan Beulich > > --- a/xen/include/asm-x86/mm.h > +++ b/xen/include/asm-x86/mm.h > @@ -525,9 +525,14 @@ extern const unsigned int *const compat_ > #endif /* CONFIG_PV32 */ > > #define _set_gpfn_from_mfn(mfn, pfn) ({ \ > - struct domain *d = page_get_owner(mfn_to_page(_mfn(mfn))); \ > - unsigned long entry = (d && (d == dom_cow)) ? \ > - SHARED_M2P_ENTRY : (pfn); \ > + unsigned long entry = (pfn); \ > + if ( entry != INVALID_M2P_ENTRY ) \ > + { \ > + const struct domain *d; \ > + d = page_get_owner(mfn_to_page(_mfn(mfn))); \ > + if ( d && (d == dom_cow) ) \ > + entry = SHARED_M2P_ENTRY; \ > + } \ > set_compat_m2p(mfn, (unsigned int)(entry)); \ > machine_to_phys_mapping[mfn] = (entry); \ > }) > Hmm - we already have a lot of callers, and this is already too complicated to be a define. We have x86 which uses M2P, and ARM which doesn't.  We have two more architectures on the way which probably won't want M2P, and certainly won't in the beginning. Can we introduce CONFIG_M2P which is selected by x86, rename this infrastructure to set_m2p() or something, provide a no-op fallback in common code, and move this implementation into x86/mm.c ? In particular, silently clobbering pfn to SHARED_M2P_ENTRY is rude behaviour.  It would be better to ASSERT() the right one is passed in, which also simplifies release builds. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Aug 10 16:54:17 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 16:54:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5B3o-0004Nw-OJ; Mon, 10 Aug 2020 16:54:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5B3n-0004Nr-4R for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 16:54:07 +0000 X-Inumbo-ID: 5e1f5faf-b487-4d2d-a9c3-20a70c97ffe2 Received: from userp2130.oracle.com (unknown [156.151.31.86]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5e1f5faf-b487-4d2d-a9c3-20a70c97ffe2; Mon, 10 Aug 2020 16:54:06 +0000 (UTC) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07AGlsrE150091; Mon, 10 Aug 2020 16:53:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=sF3viSF8yTpiZjA9z0PefnqgzKjAGloxUHPTj+8nY3c=; b=AQgVr8qUIdGph852SUrYWTqhmE4e68TELBw4p/CUmYSxTx6ZLHX0h5VD2ZlOuqkHcMGa az/iaaxQNMaUqiS7ZcahHolsXO+Q4qhuwG6pYII4oGqN5ISJ7nu9oDbph1FXsqMfOWVb YtcY8JqBQzSjadbvjUvqT+icJt/1JROoHbNl9aW5YHa8Nw3sby4YfxzgnY/ts9U6IV7y C4jTDp0+fw58ng0dFikNDZ0N7AYvMhiD5aKlHkSRf1dyn91WqC92AoXUs7Ynb3WRoCBi OP0Br8YxP/bH/HLkNVzVGjR9LKQvMQZCjiRJTDhT0V4j4/6OREuRttNeMNt+BEGPdyd/ 8w== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 32t2yde37e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 10 Aug 2020 16:53:48 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07AGlPcv061003; Mon, 10 Aug 2020 16:53:48 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3020.oracle.com with ESMTP id 32u3gyy0gn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 10 Aug 2020 16:53:47 +0000 Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 07AGrjWt022041; Mon, 10 Aug 2020 16:53:45 GMT Received: from [10.39.224.213] (/10.39.224.213) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 10 Aug 2020 16:53:42 +0000 Subject: Re: [PATCH v3 4/7] x86/paravirt: remove 32-bit support from PARAVIRT_XXL To: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org References: <20200807083826.16794-1-jgross@suse.com> <20200807083826.16794-5-jgross@suse.com> <4c5fb964-6acb-6bb8-4eff-0bcb67d922f2@suse.com> From: Boris Ostrovsky Autocrypt: addr=boris.ostrovsky@oracle.com; keydata= xsFNBFH8CgsBEAC0KiOi9siOvlXatK2xX99e/J3OvApoYWjieVQ9232Eb7GzCWrItCzP8FUV PQg8rMsSd0OzIvvjbEAvaWLlbs8wa3MtVLysHY/DfqRK9Zvr/RgrsYC6ukOB7igy2PGqZd+M MDnSmVzik0sPvB6xPV7QyFsykEgpnHbvdZAUy/vyys8xgT0PVYR5hyvhyf6VIfGuvqIsvJw5 C8+P71CHI+U/IhsKrLrsiYHpAhQkw+Zvyeml6XSi5w4LXDbF+3oholKYCkPwxmGdK8MUIdkM d7iYdKqiP4W6FKQou/lC3jvOceGupEoDV9botSWEIIlKdtm6C4GfL45RD8V4B9iy24JHPlom woVWc0xBZboQguhauQqrBFooHO3roEeM1pxXjLUbDtH4t3SAI3gt4dpSyT3EvzhyNQVVIxj2 FXnIChrYxR6S0ijSqUKO0cAduenhBrpYbz9qFcB/GyxD+ZWY7OgQKHUZMWapx5bHGQ8bUZz2 SfjZwK+GETGhfkvNMf6zXbZkDq4kKB/ywaKvVPodS1Poa44+B9sxbUp1jMfFtlOJ3AYB0WDS Op3d7F2ry20CIf1Ifh0nIxkQPkTX7aX5rI92oZeu5u038dHUu/dO2EcuCjl1eDMGm5PLHDSP 0QUw5xzk1Y8MG1JQ56PtqReO33inBXG63yTIikJmUXFTw6lLJwARAQABzTNCb3JpcyBPc3Ry b3Zza3kgKFdvcmspIDxib3Jpcy5vc3Ryb3Zza3lAb3JhY2xlLmNvbT7CwXgEEwECACIFAlH8 CgsCGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEIredpCGysGyasEP/j5xApopUf4g 9Fl3UxZuBx+oduuw3JHqgbGZ2siA3EA4bKwtKq8eT7ekpApn4c0HA8TWTDtgZtLSV5IdH+9z JimBDrhLkDI3Zsx2CafL4pMJvpUavhc5mEU8myp4dWCuIylHiWG65agvUeFZYK4P33fGqoaS VGx3tsQIAr7MsQxilMfRiTEoYH0WWthhE0YVQzV6kx4wj4yLGYPPBtFqnrapKKC8yFTpgjaK jImqWhU9CSUAXdNEs/oKVR1XlkDpMCFDl88vKAuJwugnixjbPFTVPyoC7+4Bm/FnL3iwlJVE qIGQRspt09r+datFzPqSbp5Fo/9m4JSvgtPp2X2+gIGgLPWp2ft1NXHHVWP19sPgEsEJXSr9 tskM8ScxEkqAUuDs6+x/ISX8wa5Pvmo65drN+JWA8EqKOHQG6LUsUdJolFM2i4Z0k40BnFU/ kjTARjrXW94LwokVy4x+ZYgImrnKWeKac6fMfMwH2aKpCQLlVxdO4qvJkv92SzZz4538az1T m+3ekJAimou89cXwXHCFb5WqJcyjDfdQF857vTn1z4qu7udYCuuV/4xDEhslUq1+GcNDjAhB nNYPzD+SvhWEsrjuXv+fDONdJtmLUpKs4Jtak3smGGhZsqpcNv8nQzUGDQZjuCSmDqW8vn2o hWwveNeRTkxh+2x1Qb3GT46uzsFNBFH8CgsBEADGC/yx5ctcLQlB9hbq7KNqCDyZNoYu1HAB Hal3MuxPfoGKObEktawQPQaSTB5vNlDxKihezLnlT/PKjcXC2R1OjSDinlu5XNGc6mnky03q yymUPyiMtWhBBftezTRxWRslPaFWlg/h/Y1iDuOcklhpr7K1h1jRPCrf1yIoxbIpDbffnuyz kuto4AahRvBU4Js4sU7f/btU+h+e0AcLVzIhTVPIz7PM+Gk2LNzZ3/on4dnEc/qd+ZZFlOQ4 KDN/hPqlwA/YJsKzAPX51L6Vv344pqTm6Z0f9M7YALB/11FO2nBB7zw7HAUYqJeHutCwxm7i BDNt0g9fhviNcJzagqJ1R7aPjtjBoYvKkbwNu5sWDpQ4idnsnck4YT6ctzN4I+6lfkU8zMzC gM2R4qqUXmxFIS4Bee+gnJi0Pc3KcBYBZsDK44FtM//5Cp9DrxRQOh19kNHBlxkmEb8kL/pw XIDcEq8MXzPBbxwHKJ3QRWRe5jPNpf8HCjnZz0XyJV0/4M1JvOua7IZftOttQ6KnM4m6WNIZ 2ydg7dBhDa6iv1oKdL7wdp/rCulVWn8R7+3cRK95SnWiJ0qKDlMbIN8oGMhHdin8cSRYdmHK kTnvSGJNlkis5a+048o0C6jI3LozQYD/W9wq7MvgChgVQw1iEOB4u/3FXDEGulRVko6xCBU4 SQARAQABwsFfBBgBAgAJBQJR/AoLAhsMAAoJEIredpCGysGyfvMQAIywR6jTqix6/fL0Ip8G jpt3uk//QNxGJE3ZkUNLX6N786vnEJvc1beCu6EwqD1ezG9fJKMl7F3SEgpYaiKEcHfoKGdh 30B3Hsq44vOoxR6zxw2B/giADjhmWTP5tWQ9548N4VhIZMYQMQCkdqaueSL+8asp8tBNP+TJ PAIIANYvJaD8xA7sYUXGTzOXDh2THWSvmEWWmzok8er/u6ZKdS1YmZkUy8cfzrll/9hiGCTj u3qcaOM6i/m4hqtvsI1cOORMVwjJF4+IkC5ZBoeRs/xW5zIBdSUoC8L+OCyj5JETWTt40+lu qoqAF/AEGsNZTrwHJYu9rbHH260C0KYCNqmxDdcROUqIzJdzDKOrDmebkEVnxVeLJBIhYZUd t3Iq9hdjpU50TA6sQ3mZxzBdfRgg+vaj2DsJqI5Xla9QGKD+xNT6v14cZuIMZzO7w0DoojM4 ByrabFsOQxGvE0w9Dch2BDSI2Xyk1zjPKxG1VNBQVx3flH37QDWpL2zlJikW29Ws86PHdthh Fm5PY8YtX576DchSP6qJC57/eAAe/9ztZdVAdesQwGb9hZHJc75B+VNm4xrh/PJO6c1THqdQ 19WVJ+7rDx3PhVncGlbAOiiiE3NOFPJ1OQYxPKtpBUukAlOTnkKE6QcA4zckFepUkfmBV1wM Jg6OxFYd01z+a+oL Message-ID: <8506b0cd-6f7e-7505-d9b9-e1468cefa4ec@oracle.com> Date: Mon, 10 Aug 2020 12:53:30 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <4c5fb964-6acb-6bb8-4eff-0bcb67d922f2@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9709 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxlogscore=999 mlxscore=0 malwarescore=0 spamscore=0 suspectscore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008100121 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9709 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 priorityscore=1501 malwarescore=0 impostorscore=0 lowpriorityscore=0 mlxscore=0 bulkscore=0 suspectscore=0 phishscore=0 adultscore=0 spamscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008100121 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Deep Shah , "VMware, Inc." , Ingo Molnar , Borislav Petkov , Andy Lutomirski , "H. Peter Anvin" , Thomas Gleixner Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 8/10/20 12:39 AM, J=C3=BCrgen Gro=C3=9F wrote: > On 09.08.20 04:34, Boris Ostrovsky wrote: >> On 8/7/20 4:38 AM, Juergen Gross wrote: >>> @@ -377,10 +373,7 @@ static inline pte_t __pte(pteval_t val) >>> =C2=A0 { >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pteval_t ret; >>> =C2=A0 -=C2=A0=C2=A0=C2=A0 if (sizeof(pteval_t) > sizeof(long)) >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ret =3D PVOP_CALLEE2(ptev= al_t, mmu.make_pte, val, (u64)val >> >>> 32); >>> -=C2=A0=C2=A0=C2=A0 else >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ret =3D PVOP_CALLEE1(ptev= al_t, mmu.make_pte, val); >>> +=C2=A0=C2=A0=C2=A0 ret =3D PVOP_CALLEE1(pteval_t, mmu.make_pte, val)= ; >>> =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return (pte_t) { .pte =3D ret }= ; >> >> >> Can this now simply return (pte_t) ret? > > I don't think so, but I can turn it into > > =C2=A0 return native_make_pte(PVOP_CALLEE1(...));=20 I thought that since now this is only built for 64-bit we don't have to worry about different pte_t definitions and can do what we do for example, for __pgd()? -boris From xen-devel-bounces@lists.xenproject.org Mon Aug 10 17:09:55 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 17:09:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5BIv-0005Rb-14; Mon, 10 Aug 2020 17:09:45 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5BIt-0005RW-Kq for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 17:09:43 +0000 X-Inumbo-ID: 1eb1bb9f-45de-4e04-b814-8f849502fbdf Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1eb1bb9f-45de-4e04-b814-8f849502fbdf; Mon, 10 Aug 2020 17:09:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1597079381; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=/2+gS0lISNF3o4YpqCfDxgKBrBW8TDmJPPOHpW2WEjY=; b=F6NONhOVHy8JdhYpP5vPAvqQU5Z+RZ4oF/0+9955m/XzxDSIY0VppiZ1 93AyzD4ODwPPkWaxiGYRz8zNLBkqsuSC2SYO7l0C80DYtgw0k46o4NnWU 2ISVhZDMAxTjczcDbUdqTKlFw6/kuZpQy3OEvZzUZTEaRb2L5+nU+votL U=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: YSkhbkww0dm3N0QHllcHopkZ6zlWAT/Di4dSHbL7WP8BV+Tu1uio48n1NbMoDf1MAXaAH8XRT4 v1gEl8DB1nBLiDG/V2zRMA65OtjDhEs+55PQRr65TGf7upwMWU1RezOfXtdsr+RvUjzR7Uu3jU ihGiBxN/8jE/WZRkNMSR4MoKYj616MMca6rS4/n/Cs8lZ1neAJJ0KvJ3XYoRpG9BP895soLQVc 7uyDb3XNDCtbg/uT7Mzj6qasCrMgJ+B0M2Q/yfiZaivZJ9OEPEqiGQgsCRdi6mYhqj2fD1vdTI 4Gg= X-SBRS: 2.7 X-MesageID: 24517334 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,458,1589256000"; d="scan'208";a="24517334" Subject: Re: [PATCH 4/4] EFI: free unused boot mem in at least some cases To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <305c2532-408a-9f78-61fe-c90a2e86eb8e@suse.com> <4e2d0d0a-9d85-d704-5d61-ae9efc69256a@suse.com> From: Andrew Cooper Message-ID: <21bd3372-ac86-f20f-b2b8-3cfb697ef894@citrix.com> Date: Mon, 10 Aug 2020 18:09:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <4e2d0d0a-9d85-d704-5d61-ae9efc69256a@suse.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , George Dunlap , Ian Jackson , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 06/08/2020 10:06, Jan Beulich wrote: > Address at least the primary reason why 52bba67f8b87 ("efi/boot: Don't > free ebmalloc area at all") was put in place: Make xen_in_range() aware > of the freed range. This is in particular relevant for EFI-enabled > builds not actually running on EFI, as the entire range will be unused > in this case. > > Signed-off-by: Jan Beulich > --- > The remaining issue could be addressed too, by making the area 2M in > size and 2M-aligned. This memory range is only used for relocating the (synthesized?) multiboot strings, is it not? I'm not actually convinced that this is a sensible tradeoff. For one, you've broken setup.c's:     /* This needs to remain in sync with xen_in_range(). */     reserve_e820_ram(&boot_e820, __pa(_stext), __pa(__2M_rwdata_end)); which covers the runtime aspect of what xen_in_range() covers during boot. I think the better course of action is to go with David Woodhouse's work to not relocate the trampoline until later on boot (if even necessary), at which point both of the custom allocators can disappear. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Aug 10 17:28:31 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 17:28:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5Bav-00078t-IL; Mon, 10 Aug 2020 17:28:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5Bau-00078o-7t for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 17:28:20 +0000 X-Inumbo-ID: 4da25352-ed87-4dca-ad4d-6e68e0de9c8f Received: from mail-lf1-x143.google.com (unknown [2a00:1450:4864:20::143]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4da25352-ed87-4dca-ad4d-6e68e0de9c8f; Mon, 10 Aug 2020 17:28:18 +0000 (UTC) Received: by mail-lf1-x143.google.com with SMTP id j22so5163746lfm.2 for ; Mon, 10 Aug 2020 10:28:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=OfDLlFqJUG7ZuiZEqW5c6ioQLjjFvuKwk1+W93IdMac=; b=YW+wIbIjx+YCudCZHMtvmQ9lHyviX5URgIGkTEJUapmLvWG2eJnjy37upFo6trobcI fO0I98LxE3O5ls8JqAy6dY+gV6WFCvCWBHgJywBQQqP105T6nklDjQli5kMgO69sjvde OtHQbp1kbKg5WamTVnzyvmG/R45LL3tePGJszCt4x/llOKO9pckeuB5wnQUJl+4OzwyT aICm8rwARBkB/4tClqneJePu9+BTE985Sm/6B4UVKJYLCUtM94sx/upyZKUFMQGO5VQL ifn59XINmeAvcrfv30HuuIFCU8Up6gSCg5bLL3xRoDvgriSUcWwbludfMuARbzdpWWqj rpIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=OfDLlFqJUG7ZuiZEqW5c6ioQLjjFvuKwk1+W93IdMac=; b=umQW0bpX77i9HBpUCFVXWR2UHRmovZBaMqngLIkS+XrlRiyX6LbodiOQ7MZx7WV9UA FbqFDHEy/vj/ldnDc6dsEBoiw3HDBDYE3Gtk8C3BZe1h+cDJ/LVHZEV4US7lOAhDTfAz tYP9oa1ZCfVwiSBs79C/diPsX4K6p4zroWvm6fQb3DffFENfW9gY2m2a7t9YLOQxCTRF 3nQ14rt14KTDGr+pVdt069raKJzEWhttqsi0a+gvWPbJoqheyAJjvC+N6GtP35QF9R+H WDfCZQoHJqdKSaVMc9eUWYSBURiki/SbmKl1hgZ82zXaw5NyK3Qh/wz1YfYpuoYp5pbE 43bw== X-Gm-Message-State: AOAM533NAl6E5fqMNo4Rxbo7S10t1xOt2x+RM92BxG0IzGdfcPOtfbyB A9sPpF2vjGJ35WB82j3gqC8= X-Google-Smtp-Source: ABdhPJw6e3CoQUn2MTFVZrYtb1GKVSjwn6vXSfsRV+Pjqg3xb9dCFc3Nnpdtw+wXbWm/p65JY8wByw== X-Received: by 2002:a19:ef0d:: with SMTP id n13mr1087860lfh.102.1597080496771; Mon, 10 Aug 2020 10:28:16 -0700 (PDT) Received: from [192.168.1.2] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id y9sm9448046ljm.89.2020.08.10.10.28.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Aug 2020 10:28:16 -0700 (PDT) Subject: Re: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common To: Julien Grall , xen-devel@lists.xenproject.org References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-2-git-send-email-olekstysh@gmail.com> <6bfc3920-8f29-188c-cff4-2b99dabe166f@xen.org> From: Oleksandr Message-ID: <5b79b86a-abb8-3b37-baa1-1bcc43034eab@gmail.com> Date: Mon, 10 Aug 2020 20:28:14 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Tian , Stefano Stabellini , Jan Beulich , Wei Liu , Paul Durrant , Andrew Cooper , Ian Jackson , George Dunlap , Tim Deegan , Oleksandr Tyshchenko , Julien Grall , Jun Nakajima , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 10.08.20 19:29, Julien Grall wrote: > Hi, Hi Julien > > On 06/08/2020 12:37, Oleksandr wrote: >> >> On 05.08.20 16:30, Julien Grall wrote: >>> Hi, >> >> Hi Julien >> >> >>> >>> On 03/08/2020 19:21, Oleksandr Tyshchenko wrote: >>>> From: Oleksandr Tyshchenko >>>> >>>> As a lot of x86 code can be re-used on Arm later on, this patch >>>> splits IOREQ support into common and arch specific parts. >>>> >>>> This support is going to be used on Arm to be able run device >>>> emulator outside of Xen hypervisor. >>>> >>>> Please note, this is a split/cleanup of Julien's PoC: >>>> "Add support for Guest IO forwarding to a device emulator" >>>> >>>> Signed-off-by: Julien Grall >>>> Signed-off-by: Oleksandr Tyshchenko >>>> --- >>>>   xen/arch/x86/Kconfig            |    1 + >>>>   xen/arch/x86/hvm/dm.c           |    2 +- >>>>   xen/arch/x86/hvm/emulate.c      |    2 +- >>>>   xen/arch/x86/hvm/hvm.c          |    2 +- >>>>   xen/arch/x86/hvm/io.c           |    2 +- >>>>   xen/arch/x86/hvm/ioreq.c        | 1431 >>>> +-------------------------------------- >>>>   xen/arch/x86/hvm/stdvga.c       |    2 +- >>>>   xen/arch/x86/hvm/vmx/realmode.c |    1 + >>>>   xen/arch/x86/hvm/vmx/vvmx.c     |    2 +- >>>>   xen/arch/x86/mm.c               |    2 +- >>>>   xen/arch/x86/mm/shadow/common.c |    2 +- >>>>   xen/common/Kconfig              |    3 + >>>>   xen/common/Makefile             |    1 + >>>>   xen/common/hvm/Makefile         |    1 + >>>>   xen/common/hvm/ioreq.c          | 1430 >>>> ++++++++++++++++++++++++++++++++++++++ >>>>   xen/include/asm-x86/hvm/ioreq.h |   45 +- >>>>   xen/include/asm-x86/hvm/vcpu.h  |    7 - >>>>   xen/include/xen/hvm/ioreq.h     |   89 +++ >>>>   18 files changed, 1575 insertions(+), 1450 deletions(-) >>> >>> That's quite a lot of code moved in a single patch. How can we check >>> the code moved is still correct? Is it a verbatim copy? >> In this patch I mostly tried to separate a common IOREQ part which >> also resulted in updating x86 sources to include new header.  Also I >> moved hvm_ioreq_needs_completion() to common header (which probably >> wanted to be in a separate patch). It was a verbatim copy initially >> (w/o hvm_map_mem_type_to_ioreq_server) and then updated to deal with >> arch specific parts. > > I would prefer if the two parts are done separately. IOW, the code > movement be nearly a verbatim copy. > >> In which way do you want me to split this patch? >> >> I could think of the following: >> >> 1. Copy of x86's ioreq.c/ioreq.h to common code > 2. Update common >> ioreq.c/ioreq.h >> 3. Update x86's parts to be able to deal with common code >> 4. Move hvm_ioreq_needs_completion() to common code >> > > Ideally the code movement should be done in the same patch. This helps > to check the patch is only moving code and also avoids mistakes on > rebase. > > So my preference would be to first modify the x86 code (e.g. renaming) > to make it common and then have one patch that will move the code. ok, will try to split accordingly. Thank you -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Mon Aug 10 17:51:28 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 17:51:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5Bwz-00019v-9C; Mon, 10 Aug 2020 17:51:09 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5Bwy-00019q-Tl for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 17:51:08 +0000 X-Inumbo-ID: d18c217a-cd09-4a8e-8c60-8daf9e806c93 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d18c217a-cd09-4a8e-8c60-8daf9e806c93; Mon, 10 Aug 2020 17:51:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1597081867; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=XX1/rTgTk+ljHUeylRrlCmjlLIl+c2a4VtaC9LrINfQ=; b=EhnSGj9x22nEdGwvd09i/YOmgF3vypXoN9Xy/gR0WewEmN4OpxQoG35b NlPHDBabECnOE/sdLl/7N/wA3FRw8bqcKU+6j8L14+ABqqX6T6jCLHlpY 3JdUn6gLdfqNPwf6F03I65NnkuUWP6Jwvqv9QKvxCQhi5gamdnBn+pCf6 0=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: UzGXBFmxAbZgzvdn4UK35Ly06bpm+QHLygvmTSkXh8ckNK3mW4ns46o6/wbKQTMClZuvM6yKAT NNLa0smxPXD3JrTYOdIpRfcT902pZHPVvep5zHGxAPAPx3zFDCJ93+YtjzBHHauNrRlso3xqJa 37WnKC9TGtNGNX7ksXYulF7Ug8sWfMlhnu1/V0sepwhjL0dgzGKHf5k8+g54frmWpVpskA3BmE euFVYDO7yKjtEfhfbxXkBWPa3DVRLLYW1TQnkKVgu7f/uf6905LpEgzXx07PKvunIzBekbV0RH uBE= X-SBRS: 2.7 X-MesageID: 24193490 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,458,1589256000"; d="scan'208";a="24193490" Subject: Re: [PATCH 3/4] build: also check for empty .bss.* in .o -> .init.o conversion To: Jan Beulich References: <305c2532-408a-9f78-61fe-c90a2e86eb8e@suse.com> <5b2bbc31-0095-c3e2-9e34-20453ea2aa5f@citrix.com> <61481966-3052-ebf2-e23b-aac292cd09a1@suse.com> <9a3cd872-bc6c-3113-fdf9-2f80ad8fabce@citrix.com> <039916f1-c9f2-710f-8f46-3ff9d91a9109@suse.com> From: Andrew Cooper Message-ID: Date: Mon, 10 Aug 2020 18:51:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <039916f1-c9f2-710f-8f46-3ff9d91a9109@suse.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , George Dunlap , Ian Jackson , "xen-devel@lists.xenproject.org" , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 07/08/2020 16:40, Jan Beulich wrote: > On 07.08.2020 17:12, Andrew Cooper wrote: >> On 07/08/2020 11:56, Jan Beulich wrote: >>> On 06.08.2020 18:16, Andrew Cooper wrote: >>>> On 06/08/2020 10:05, Jan Beulich wrote: >>>> Can't we remove all of this by having CONFIG_XEN_PE expressed/selectable >>>> properly in Kconfig, and gathering all the objects normally, rather than >>>> bodging all of common/efi/ through arch/efi/ ? >>> _If_ we settle on Kconfig to be allowed to check compiler (and linker) >>> features, then yes. This continues to be a pending topic though, so >>> the switch can't be made like this at this point in time. (It could be >>> made a Kconfig item now - which, when enabled, implies the assertion >>> that a capable tool chain is in use.) >> I am still of the opinion that nothing needs discussing, but you are >> obviously not. >> >> Please raise this as a topic and lets discuss it, because it has a >> meaningful impacting on a large number of pending series. > Preferably I would have put this on this month's community meeting > agenda, but I'll be ooo next week, so that's not going to help, I'm > afraid. I guess I should put it up in email form when I'm back, > albeit I wasn't thinking it should need to be me to start the > discussion. Instead my view was that such a discussion should (have > been, now after-the-fact) be started by whoever wants to introduce > a new feature. It would have been better to raise a concern/objectection before you committed the feature. It was a very clear intent of upgrading Kconfig and switching to Kbuild, to clean up the total and chronic mess we call a build system.  It has been discussed multiple times in person, and on xen-devel, without apparent objection at the time. The state of 4.14 and later is that we have the feature, and it is already in use, with a lot more use expected to continue fixing the build system. You are currently blocking work to fix aspects of the build system based on a dislike of this feature, *and* expecting someone else to justify why using this feature as intended is ok in the first place. I do not consider that a reasonable expectation of how to proceed. If you wish to undo what was a deliberate intention of the Kconfig/Kbuild work, then it is you who must start the conversation on why we should revert the improvements. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Aug 10 17:51:39 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 17:51:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5BxT-0001Bc-Is; Mon, 10 Aug 2020 17:51:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5BxS-0001BV-Ol for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 17:51:38 +0000 X-Inumbo-ID: 3044a447-b355-425a-8068-c62f4393274b Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3044a447-b355-425a-8068-c62f4393274b; Mon, 10 Aug 2020 17:51:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1597081898; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=KkYNIp5BI1P9vw8nTLp+dFkkzlA7M9TvIj9SgxC4PmM=; b=JOOsrQ+2wkm5JZhsZbXnPePTNIdL5K6CnBXUVmF7iXxEdp5T3rwUcufy xZl8pAmmS4Bm2kPtmprAXcexKIestyVNg1SlKrGW2TAbUfgCY+682aij3 xfO/77v2XW+lbVj+HwvdYW1uTDMTaoB3DydUAGPkWOycGNsr/7MpPlDN+ 8=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: fYuSZd2x8vS2u4Apf7Hd/jn9yAdSa7b7/A5OqwkAfS/LizD5KAu/1+oPivauIhDScqcz0qvEk+ EzCRHuYm2AyOO9wjY1N3n5XUpOlyvxZA84Rnj64bAPjhaHpDtUXAvadHaG3bgMORzGYwnzX0t/ eyQf0rGkw4JZrmedirC3YFhDvp4sCI+gVOJVrr1m9LNA1ECRX/GqQO2D9JlW3orv7g2p6olX1Q wzpn1wg8WjErVlBJHuWUJK6D3rlX1iPw8A7rpUpCnchaTVBFv2XrloXUSZcqXneM8KqUMVG7g6 brE= X-SBRS: 2.7 X-MesageID: 24193531 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,458,1589256000"; d="scan'208";a="24193531" Subject: Re: [PATCH 3/4] build: also check for empty .bss.* in .o -> .init.o conversion To: Jan Beulich References: <305c2532-408a-9f78-61fe-c90a2e86eb8e@suse.com> <5b2bbc31-0095-c3e2-9e34-20453ea2aa5f@citrix.com> <61481966-3052-ebf2-e23b-aac292cd09a1@suse.com> <9a3cd872-bc6c-3113-fdf9-2f80ad8fabce@citrix.com> <039916f1-c9f2-710f-8f46-3ff9d91a9109@suse.com> From: Andrew Cooper Message-ID: <039a6c48-8825-1e3e-44d8-23c7de4ac159@citrix.com> Date: Mon, 10 Aug 2020 18:51:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <039916f1-c9f2-710f-8f46-3ff9d91a9109@suse.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , George Dunlap , Ian Jackson , "xen-devel@lists.xenproject.org" , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 07/08/2020 16:40, Jan Beulich wrote: > On 07.08.2020 17:12, Andrew Cooper wrote: >> On 07/08/2020 11:56, Jan Beulich wrote: >>> On 06.08.2020 18:16, Andrew Cooper wrote: >>>> On 06/08/2020 10:05, Jan Beulich wrote: >>>> Can't we remove all of this by having CONFIG_XEN_PE expressed/selectable >>>> properly in Kconfig, and gathering all the objects normally, rather than >>>> bodging all of common/efi/ through arch/efi/ ? >>> _If_ we settle on Kconfig to be allowed to check compiler (and linker) >>> features, then yes. This continues to be a pending topic though, so >>> the switch can't be made like this at this point in time. (It could be >>> made a Kconfig item now - which, when enabled, implies the assertion >>> that a capable tool chain is in use.) >> I am still of the opinion that nothing needs discussing, but you are >> obviously not. >> >> Please raise this as a topic and lets discuss it, because it has a >> meaningful impacting on a large number of pending series. > Preferably I would have put this on this month's community meeting > agenda, but I'll be ooo next week, so that's not going to help, I'm > afraid. I guess I should put it up in email form when I'm back, > albeit I wasn't thinking it should need to be me to start the > discussion. Instead my view was that such a discussion should (have > been, now after-the-fact) be started by whoever wants to introduce > a new feature. It would have been better to raise a concern/objection before you committed the feature. It was a very clear intent of upgrading Kconfig and switching to Kbuild, to clean up the total and chronic mess we call a build system.  It has been discussed multiple times in person, and on xen-devel, without apparent objection at the time. The state of 4.14 and later is that we have the feature, and it is already in use, with a lot more use expected to continue fixing the build system. You are currently blocking work to fix aspects of the build system based on a dislike of this feature, *and* expecting someone else to justify why using this feature as intended is ok in the first place. I do not consider that a reasonable expectation of how to proceed. If you wish to undo what was a deliberate intention of the Kconfig/Kbuild work, then it is you who must start the conversation on why we should revert the improvements. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Aug 10 18:10:05 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 18:10:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5CFA-0002NM-AQ; Mon, 10 Aug 2020 18:09:56 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5CF8-0002NH-FA for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 18:09:54 +0000 X-Inumbo-ID: 2a0efc40-f520-4bdf-bcce-154a7e2fb095 Received: from mail-lj1-x242.google.com (unknown [2a00:1450:4864:20::242]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2a0efc40-f520-4bdf-bcce-154a7e2fb095; Mon, 10 Aug 2020 18:09:53 +0000 (UTC) Received: by mail-lj1-x242.google.com with SMTP id w14so10632900ljj.4 for ; Mon, 10 Aug 2020 11:09:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=8H1B1lRjuf0v1kBYb6EpJ8pTqtiQ6R1hS951zjs9hCk=; b=gmK6vaIA3pZY1Q8lHh6bGKU/KgNBl7xQvDXQ8wqpeoTD9ocpzmWDBdMwqMtJ/T4x3J kHDCS4vEd9dBNUzOQykr4+/sVSuIMAeMzAvT7QPemI66BM3M5yfSbMv1miLH9OIrzUgW uV/QbeOgKMoL3cX7icfnpi+7VRh4elmIJImUs+QFLeqedG6+xlMABpLjFrvqtYeb2/Jk yw91iVzC3m9FY6K9DiFWF6CmKyxVeSlw0I0PIaxbtPAitn1JkgYswArHuhPgZuNcrq8b D+rKBSsc3cZSb+I3t4+NXmp4Qj3l3NXa9H3bLSRCD10ZFTeY1v4sDxZadfyhzWabXQZZ XOuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=8H1B1lRjuf0v1kBYb6EpJ8pTqtiQ6R1hS951zjs9hCk=; b=RGFdES+aQpY0ZEggObStr8/Nhs26bRmYCnqtPM1vubTffFeJOVEF9KlEbx5eYw/BsE 8P/9/h4upZu89zzzM/jA3tKXCOCLPRedwixdx/Tj26eKQOSy5YF6M3U1x//rpOrWCqJq qs35YW9uNIsYNA3q/iW/Kkm+zuTjVrYQdPCiUdHgFPBMDtGbM2hK7f483qXA1gSecWg2 MRh75QDESAaBzmtOH56/2JtZoHIfE0WlRu0u15RDO/EOANAjsTqktEuuB14iW4YWRHWm LFBUWxBlenyrzAgPjRwfxfQusyu9kdta2DdEU1vEyNm9dDD3pDK0d5ZONFa82jNh5knL HgGg== X-Gm-Message-State: AOAM532nz/Ud+/Kmq39FYMe9Pmhxc/QEn1aOWtiWZh9f1PFTZoaUqt0s 94bGYRJTwEJ6WqDnCE/LLCo= X-Google-Smtp-Source: ABdhPJzrljsKVIpuOVqf3UFBejG14VMca4thwbwwDtlMyrkxcc83nrcJxfS8bEF7jzFaAaa3HCKwFw== X-Received: by 2002:a2e:a28b:: with SMTP id k11mr1131799lja.405.1597082992178; Mon, 10 Aug 2020 11:09:52 -0700 (PDT) Received: from [192.168.1.2] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id h18sm9404548ljk.7.2020.08.10.11.09.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Aug 2020 11:09:51 -0700 (PDT) Subject: Re: [RFC PATCH V1 04/12] xen/arm: Introduce arch specific bits for IOREQ/DM features To: Julien Grall References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-5-git-send-email-olekstysh@gmail.com> <8e8a394c-bd2a-4444-9f4b-e022c59e0f81@xen.org> From: Oleksandr Message-ID: Date: Mon, 10 Aug 2020 21:09:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <8e8a394c-bd2a-4444-9f4b-e022c59e0f81@xen.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Julien Grall , Jan Beulich , xen-devel@lists.xenproject.org, Daniel De Graaf , Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 05.08.20 12:32, Julien Grall wrote: Hi Julien > >>> @@ -2275,6 +2282,16 @@ static void check_for_vcpu_work(void) >>>    */ >>>   void leave_hypervisor_to_guest(void) >>>   { >>> +#ifdef CONFIG_IOREQ_SERVER >>> +    /* >>> +     * XXX: Check the return. Shall we call that in >>> +     * continue_running and context_switch instead? >>> +     * The benefits would be to avoid calling >>> +     * handle_hvm_io_completion on every return. >>> +     */ >> >> Yeah, that could be a simple and good optimization > > Well, it is not simple as it is sounds :). handle_hvm_io_completion() > is the function in charge to mark the vCPU as waiting for I/O. So we > would at least need to split the function. > > I wrote this TODO because I wasn't sure about the complexity of > handle_hvm_io_completion(current). Looking at it again, the main > complexity is the looping over the IOREQ servers. > > I think it would be better to optimize handle_hvm_io_completion() > rather than trying to hack the context_switch() or continue_running(). Well, is the idea in proposed dirty test patch below close to what you expect? Patch optimizes handle_hvm_io_completion() to avoid extra actions if vcpu's domain doesn't have ioreq_server, alternatively the check could be moved out of handle_hvm_io_completion() to avoid calling that function at all. BTW, TODO also suggests checking the return value of handle_hvm_io_completion(), but I am completely sure we can simply just return from leave_hypervisor_to_guest() at this point. Could you please share your opinion? ---  xen/common/hvm/ioreq.c       | 12 +++++++++++-  xen/include/asm-arm/domain.h |  1 +  xen/include/xen/hvm/ioreq.h  |  5 +++++  3 files changed, 17 insertions(+), 1 deletion(-) diff --git a/xen/common/hvm/ioreq.c b/xen/common/hvm/ioreq.c index 7e1fa23..dc6647a 100644 --- a/xen/common/hvm/ioreq.c +++ b/xen/common/hvm/ioreq.c @@ -38,9 +38,15 @@ static void set_ioreq_server(struct domain *d, unsigned int id,                               struct hvm_ioreq_server *s)  {      ASSERT(id < MAX_NR_IOREQ_SERVERS); -    ASSERT(!s || !d->arch.hvm.ioreq_server.server[id]); +    ASSERT((!s && d->arch.hvm.ioreq_server.server[id]) || +           (s && !d->arch.hvm.ioreq_server.server[id]));      d->arch.hvm.ioreq_server.server[id] = s; + +    if ( s ) +        d->arch.hvm.ioreq_server.nr_servers ++; +    else +        d->arch.hvm.ioreq_server.nr_servers --;  }  /* @@ -169,6 +175,9 @@ bool handle_hvm_io_completion(struct vcpu *v)          return false;      } +    if ( !hvm_domain_has_ioreq_server(d) ) +        return true; +      FOR_EACH_IOREQ_SERVER(d, id, s)      {          struct hvm_ioreq_vcpu *sv; @@ -1415,6 +1424,7 @@ unsigned int hvm_broadcast_ioreq(ioreq_t *p, bool buffered)  void hvm_ioreq_init(struct domain *d)  {      spin_lock_init(&d->arch.hvm.ioreq_server.lock); +    d->arch.hvm.ioreq_server.nr_servers = 0;      arch_hvm_ioreq_init(d);  } diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h index 6a01d69..484bd1a 100644 --- a/xen/include/asm-arm/domain.h +++ b/xen/include/asm-arm/domain.h @@ -68,6 +68,7 @@ struct hvm_domain      struct {          spinlock_t              lock;          struct hvm_ioreq_server *server[MAX_NR_IOREQ_SERVERS]; +        unsigned int            nr_servers;      } ioreq_server;      bool_t qemu_mapcache_invalidate; diff --git a/xen/include/xen/hvm/ioreq.h b/xen/include/xen/hvm/ioreq.h index 40b7b5e..8f78852 100644 --- a/xen/include/xen/hvm/ioreq.h +++ b/xen/include/xen/hvm/ioreq.h @@ -23,6 +23,11 @@  #include +static inline bool hvm_domain_has_ioreq_server(const struct domain *d) +{ +    return (d->arch.hvm.ioreq_server.nr_servers > 0); +} +  #define GET_IOREQ_SERVER(d, id) \      (d)->arch.hvm.ioreq_server.server[id] -- 2.7.4 -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Mon Aug 10 18:13:06 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 18:13:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5CID-0003AC-QW; Mon, 10 Aug 2020 18:13:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5CIB-0003A7-QG for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 18:13:03 +0000 X-Inumbo-ID: 414899a0-1f2e-4649-9dc2-cf811689ee72 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 414899a0-1f2e-4649-9dc2-cf811689ee72; Mon, 10 Aug 2020 18:13:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=L0P1sDpsJ6B6uHzswNe7gVS7HuPewOgFbVLjt/ETPmg=; b=2dIC8IXwBrXuwjZtgejrcD3c5 RYHXTW5m1tCyhj5dOF0Vs6VyvYn0ZADX3q5ITaBRQNs9E90LIW2S9r0Y/Q4IwoiKUCCH/a9lQ/VKM ZSaiH/XLQZFNFXaBdzvh+LN3zDSzmqTmDuArT6W9Y3gOxjWQNVwLoRYgg0oFVdN4lbLOI=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5CI8-0004yh-Jg; Mon, 10 Aug 2020 18:13:00 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k5CI8-0007OG-3D; Mon, 10 Aug 2020 18:13:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k5CI8-0000a1-2a; Mon, 10 Aug 2020 18:13:00 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 152550: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-boot:fail:regression linux-linus:test-amd64-i386-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-i386-libvirt:xen-boot:fail:regression linux-linus:test-amd64-i386-examine:reboot:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-boot:fail:regression linux-linus:test-amd64-i386-xl:xen-boot:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-boot:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:guest-start/debian.repeat:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking X-Osstest-Versions-This: linux=fc80c51fd4b23ec007e88d4c688f2cac1b8648e7 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Mon, 10 Aug 2020 18:13:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152550 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/152550/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-boot/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-boot/dst_host fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-examine 8 reboot fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-boot/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-boot/dst_host fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-boot fail REGR. vs. 152332 test-arm64-arm64-libvirt-xsm 16 guest-start/debian.repeat fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail like 152332 test-armhf-armhf-xl-rtds 16 guest-start/debian.repeat fail like 152332 test-armhf-armhf-libvirt 14 saverestore-support-check fail like 152332 test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail like 152332 test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass version targeted for testing: linux fc80c51fd4b23ec007e88d4c688f2cac1b8648e7 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 9 days Failing since 152366 2020-08-01 20:49:34 Z 8 days 10 attempts Testing same since 152550 2020-08-10 07:53:26 Z 0 days 1 attempts ------------------------------------------------------------ 1931 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 243614 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Aug 10 18:20:40 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 18:20:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5CPR-000422-Ou; Mon, 10 Aug 2020 18:20:33 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5CPQ-00041x-Jz for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 18:20:32 +0000 X-Inumbo-ID: e38137c7-a0a7-425c-b319-cd2eb10df800 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e38137c7-a0a7-425c-b319-cd2eb10df800; Mon, 10 Aug 2020 18:20:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Fg8NRnp0STkuQeb0N92kQUhAtHRoALYIgYC9b95OEgI=; b=mdjWIhCcw6K/pNwZYlvSL2Ytj 9shFeaufbe7JCLtUAoOb51yjJGl6XdIl67OFKH0DCOoKL797oTLIfb8TuCbEEeD9afjRcZISO03rv +mVUk9s4A/Qbovdxg2IYnhK3EgIxzpxe8WCq0q5I2M2fp5vgUsGQZJQt7dOPgIfSCQnrI=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5CPN-00058b-Th; Mon, 10 Aug 2020 18:20:29 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k5CPN-0007nS-KA; Mon, 10 Aug 2020 18:20:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k5CPN-0002pQ-Je; Mon, 10 Aug 2020 18:20:29 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 152553: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=7a4dd361d10718608ad37f969df0a3cf5bc17b12 X-Osstest-Versions-That: xen=90c7eee53fcc0b48bd51aa3a7d1d0d9980ce1a7a From: osstest service owner Date: Mon, 10 Aug 2020 18:20:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152553 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/152553/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass version targeted for testing: xen 7a4dd361d10718608ad37f969df0a3cf5bc17b12 baseline version: xen 90c7eee53fcc0b48bd51aa3a7d1d0d9980ce1a7a Last test of basis 152532 2020-08-07 17:04:43 Z 3 days Testing same since 152553 2020-08-10 15:34:58 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 90c7eee53f..7a4dd361d1 7a4dd361d10718608ad37f969df0a3cf5bc17b12 -> smoke From xen-devel-bounces@lists.xenproject.org Mon Aug 10 18:22:03 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 18:22:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5CQt-00048x-4Y; Mon, 10 Aug 2020 18:22:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5CQs-00048q-73 for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 18:22:02 +0000 X-Inumbo-ID: 28c427e4-5203-4baf-97a4-9b7c74f2f84c Received: from mail-lf1-x143.google.com (unknown [2a00:1450:4864:20::143]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 28c427e4-5203-4baf-97a4-9b7c74f2f84c; Mon, 10 Aug 2020 18:22:01 +0000 (UTC) Received: by mail-lf1-x143.google.com with SMTP id m15so5239493lfp.7 for ; Mon, 10 Aug 2020 11:22:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=HgKgbfmapv2awSuIkdFWqh6I3NOLVUpRMGCZLQRgbvU=; b=o4BHEQHLQVzhxOQIpuCS0N0fjZEQLNKzceFZXiMeDHQbekjBQ2BrADsjWgaMsFt3fK 6xW2Gxn9Vmfv4KqMZbVGf3eCIpj6mErgYR/Cpm42RESW4bsLgjHBiX0iEz7tZTYqVLRq FWlu/TjqSYDpbC4O1zAgAlqU3bls7yIOsY4RzJlBGHSzvqHSDUoACi+xRdY+8a382juF VAYFRcE5Tb1jSRQL2PKd4m0crwc1j7psOcrKnXNe/mqvBWo7F15Cbg6o1aOTlC9kFm6q fY1Q+UAMbsl0OgZtg4XSfMij8zBqZgyE1tiPBzLGC4bMqAfthFTTQuWz2p++51zf344z mbFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=HgKgbfmapv2awSuIkdFWqh6I3NOLVUpRMGCZLQRgbvU=; b=PITKP/wX9SWHJ4IdY8ldorvvF0BrWVFVKcnjDHOSntrAoHYjydh/Vyvgl9AyHOk6lU 7jbD/jw2PmPaDjvlw74M6/JNryh1DEDi7d1sjNhHQJC58BY3PGSMtRTTfgzDZ/aVCL0s ka1/a6L0WwILxvcsP9W3C+PaEN8QdKbfOlR/FwgCr4kB7S+Kc+ZufRbYz6axEggQ10WP dFAPCqsSVKOYi8foSYvW3qP/oBghgSo7zjOCpricg/wpSsoWpnAtLPY2IsgPjkdkKu7Z eglxuJTRoo0IqV1OdFy5xJVgTJgTYxzGMEJxZwq3R7ycQNxplAwhlHByEWL73SKlK0lW dKsw== X-Gm-Message-State: AOAM531d0E+dGhVjvbY0QDGcELQriQzWp6vmFxBFY+k8hZsGX0+nGTVB wooJitL7HKz4ABMxdlLB7hY= X-Google-Smtp-Source: ABdhPJyf4+dPC7Vy5zvO7YwkLzPG7rvMvMuOPYbhu2xkp+evAhFVOBxNnRBuBf6rhbhBfd9qApbQDQ== X-Received: by 2002:a19:f808:: with SMTP id a8mr1197210lff.62.1597083720172; Mon, 10 Aug 2020 11:22:00 -0700 (PDT) Received: from [192.168.1.2] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id m15sm9394695ljh.62.2020.08.10.11.21.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Aug 2020 11:21:59 -0700 (PDT) Subject: Re: [RFC PATCH V1 04/12] xen/arm: Introduce arch specific bits for IOREQ/DM features From: Oleksandr To: Julien Grall References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-5-git-send-email-olekstysh@gmail.com> <8e8a394c-bd2a-4444-9f4b-e022c59e0f81@xen.org> Message-ID: <6a5022c9-ad55-1513-e808-e74e58442551@gmail.com> Date: Mon, 10 Aug 2020 21:21:58 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Julien Grall , Jan Beulich , xen-devel@lists.xenproject.org, Daniel De Graaf , Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Hi > >> >>>> @@ -2275,6 +2282,16 @@ static void check_for_vcpu_work(void) >>>>    */ >>>>   void leave_hypervisor_to_guest(void) >>>>   { >>>> +#ifdef CONFIG_IOREQ_SERVER >>>> +    /* >>>> +     * XXX: Check the return. Shall we call that in >>>> +     * continue_running and context_switch instead? >>>> +     * The benefits would be to avoid calling >>>> +     * handle_hvm_io_completion on every return. >>>> +     */ >>> >>> Yeah, that could be a simple and good optimization >> >> Well, it is not simple as it is sounds :). handle_hvm_io_completion() >> is the function in charge to mark the vCPU as waiting for I/O. So we >> would at least need to split the function. >> >> I wrote this TODO because I wasn't sure about the complexity of >> handle_hvm_io_completion(current). Looking at it again, the main >> complexity is the looping over the IOREQ servers. >> >> I think it would be better to optimize handle_hvm_io_completion() >> rather than trying to hack the context_switch() or continue_running(). > Well, is the idea in proposed dirty test patch below close to what you > expect? Patch optimizes handle_hvm_io_completion() to avoid extra > actions if vcpu's domain doesn't have ioreq_server, alternatively > the check could be moved out of handle_hvm_io_completion() to avoid > calling that function at all. BTW, TODO also suggests checking the > return value of handle_hvm_io_completion(), but I am completely sure > we can simply > just return from leave_hypervisor_to_guest() at this point. Sorry, made a mistake in last sentence).  s / I am completely sure / I am not completely sure -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Mon Aug 10 18:26:07 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 18:26:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5CUj-0004Kh-LS; Mon, 10 Aug 2020 18:26:01 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5CUi-0004KW-8W for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 18:26:00 +0000 X-Inumbo-ID: 5d9a9b2d-609d-4e16-be6f-42127c4ab7dd Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5d9a9b2d-609d-4e16-be6f-42127c4ab7dd; Mon, 10 Aug 2020 18:25:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xvymexlVpdJ7sRZiNLtAZV337z413VmfBXPfJrLI204=; b=priKNzHIl7r4Gs9NF1+/AoXgyj gz4bQQyNXAidUFdpJqRZPH6ltQVDuAepfmahSpDFxB7Ak4uTk5reLOJ+X0ZJUBILrb8hsuJca3//W 8v8wraFuGVv9u2iw2TbCXjQSplE1xhBmFOAHUW4PpyayWqrbWQe8BvuohSrzCl9VtrZ0=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5CUX-0005G2-WC; Mon, 10 Aug 2020 18:25:50 +0000 Received: from [54.239.6.185] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k5CUX-00029u-N5; Mon, 10 Aug 2020 18:25:49 +0000 Subject: Re: [RFC PATCH V1 04/12] xen/arm: Introduce arch specific bits for IOREQ/DM features To: Oleksandr , xen-devel@lists.xenproject.org References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-5-git-send-email-olekstysh@gmail.com> <11eaa2f0-84c7-5972-d14c-4cb02458e882@xen.org> <3ee50c66-8761-6c86-3fab-a4c23622d2b8@gmail.com> <952392d9-22cc-af66-c1af-f82360b75cf4@gmail.com> From: Julien Grall Message-ID: <31914fc1-9a00-ef1c-2935-20ced2a2b574@xen.org> Date: Mon, 10 Aug 2020 19:25:47 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <952392d9-22cc-af66-c1af-f82360b75cf4@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Julien Grall , Jan Beulich , Daniel De Graaf , Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 06/08/2020 14:27, Oleksandr wrote: > > On 06.08.20 14:08, Julien Grall wrote: > > Hi Julien > >> >>>> What is this function supposed to do? >>> Agree, sounds confusing a bit. I assume it is supposed to complete >>> Guest MMIO access after finishing emulation. >>> >>> Shall I rename it to something appropriate (maybe by adding ioreq >>> prefix)? >> >> How about ioreq_handle_complete_mmio()? > > For me it sounds fine. > > > >> >>>>> diff --git a/xen/common/memory.c b/xen/common/memory.c >>>>> index 9283e5e..0000477 100644 >>>>> --- a/xen/common/memory.c >>>>> +++ b/xen/common/memory.c >>>>> @@ -8,6 +8,7 @@ >>>>>    */ >>>>>     #include >>>>> +#include >>>>>   #include >>>>>   #include >>>>>   #include >>>>> @@ -30,10 +31,6 @@ >>>>>   #include >>>>>   #include >>>>>   -#ifdef CONFIG_IOREQ_SERVER >>>>> -#include >>>>> -#endif >>>>> - >>>> >>>> Why do you remove something your just introduced? >>> The reason I guarded that header is to make "xen/mm: Make x86's >>> XENMEM_resource_ioreq_server handling common" (previous) patch >>> buildable on Arm >>> without arch IOREQ header added yet. I tried to make sure that the >>> result after each patch was buildable to retain bisectability. >>> As current patch adds Arm IOREQ specific bits (including header), >>> that guard could be removed as not needed anymore. >> I agree we want to have the build bisectable. However, I am still >> puzzled why it is necessary to remove the #ifdef and move it earlier >> in the list. >> >> Do you mind to provide more details? > Previous patch "xen/mm: Make x86's XENMEM_resource_ioreq_server handling > common" breaks build on Arm as it includes xen/hvm/ioreq.h which > requires arch header > to be present (asm/hvm/ioreq.h). But the missing arch header together > with other arch specific bits are introduced here in current patch. I understand that both Arm and x86 now implement the asm/hvm/ioreq.h. However, please keep in mind that there might be other architectures in the future. With your change here, you would impose a new arch to implement asm/hvm/ioreq.h even if the developper have no plan to use the feature. > Probably I should have rearranged > changes in a way to not introduce #ifdef and then remove it... Ideally we want to avoid #ifdef in the common code. But if this can't be done in an header, then the #ifdef here would be fine. > > >> >> [...] >> >>>>> + >>>>> +bool handle_mmio(void); >>>>> + >>>>> +static inline bool handle_pio(uint16_t port, unsigned int size, >>>>> int dir) >>>>> +{ >>>>> +    /* XXX */ >>>> >>>> Can you expand this TODO? What do you expect to do? >>> I didn't expect this to be called on Arm. Sorry, I am not sure l have >>> an idea how to handle this properly. I would keep it unimplemented >>> until a real reason. >>> Will expand TODO. >> >> Let see how the conversation on patch#1 goes about PIO vs MMIO. > > ok > > >> >>>> >>>> >>>>> +    BUG(); >>>>> +    return true; >>>>> +} >>>>> + >>>>> +static inline paddr_t hvm_mmio_first_byte(const ioreq_t *p) >>>>> +{ >>>>> +    return p->addr; >>>>> +} >>>> >>>> I understand that the x86 version is more complex as it check p->df. >>>> However, aside reducing the complexity, I am not sure why we would >>>> want to diverge it. >>>> >>>> After all, IOREQ is now meant to be a common feature. >>> Well, no objections at all. >>> Could you please clarify how could 'df' (Direction Flag?) be >>> handled/used on Arm? >> >> On x86, this is used by 'rep' instruction to tell the direction to >> iterate (forward or backward). >> >> On Arm, all the accesses to MMIO region will do a single memory >> access. So for now, we can safely always set to 0. >> >>> I see that try_fwd_ioserv() always sets it 0. Or I need to just reuse >>> x86's helpers as is, >>> which (together with count = df = 0) will result in what we actually >>> have here? >> AFAIU, both count and df should be 0 on Arm. > > Thanks for the explanation. The only one question remains where to put > common helpers hvm_mmio_first_byte/hvm_mmio_last_byte (common io.h?)? It feels to me it should be part of the common ioreq.h. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Aug 10 18:43:07 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 18:43:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5Cl7-00060C-2W; Mon, 10 Aug 2020 18:42:57 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5Cl5-000607-8K for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 18:42:55 +0000 X-Inumbo-ID: 6f02a5aa-7a9f-4702-9636-a5eff9f42a1b Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6f02a5aa-7a9f-4702-9636-a5eff9f42a1b; Mon, 10 Aug 2020 18:42:53 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D34E6AB55; Mon, 10 Aug 2020 18:43:12 +0000 (UTC) Subject: Re: [PATCH v3 4/7] x86/paravirt: remove 32-bit support from PARAVIRT_XXL To: Boris Ostrovsky , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org References: <20200807083826.16794-1-jgross@suse.com> <20200807083826.16794-5-jgross@suse.com> <4c5fb964-6acb-6bb8-4eff-0bcb67d922f2@suse.com> <8506b0cd-6f7e-7505-d9b9-e1468cefa4ec@oracle.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Mon, 10 Aug 2020 20:42:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <8506b0cd-6f7e-7505-d9b9-e1468cefa4ec@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Deep Shah , "VMware, Inc." , Ingo Molnar , Borislav Petkov , Andy Lutomirski , "H. Peter Anvin" , Thomas Gleixner Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 10.08.20 18:53, Boris Ostrovsky wrote: > On 8/10/20 12:39 AM, Jürgen Groß wrote: >> On 09.08.20 04:34, Boris Ostrovsky wrote: >>> On 8/7/20 4:38 AM, Juergen Gross wrote: >>>> @@ -377,10 +373,7 @@ static inline pte_t __pte(pteval_t val) >>>>   { >>>>       pteval_t ret; >>>>   -    if (sizeof(pteval_t) > sizeof(long)) >>>> -        ret = PVOP_CALLEE2(pteval_t, mmu.make_pte, val, (u64)val >> >>>> 32); >>>> -    else >>>> -        ret = PVOP_CALLEE1(pteval_t, mmu.make_pte, val); >>>> +    ret = PVOP_CALLEE1(pteval_t, mmu.make_pte, val); >>>>         return (pte_t) { .pte = ret }; >>> >>> >>> Can this now simply return (pte_t) ret? >> >> I don't think so, but I can turn it into >> >>   return native_make_pte(PVOP_CALLEE1(...)); > > > I thought that since now this is only built for 64-bit we don't have to > worry about different pte_t definitions and can do what we do for > example, for __pgd()? Yes, I did that: return (pte_t) { ret }; Juergen From xen-devel-bounces@lists.xenproject.org Mon Aug 10 19:00:44 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 19:00:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5D1y-0007gC-Jk; Mon, 10 Aug 2020 19:00:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5D1x-0007g7-CK for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 19:00:21 +0000 X-Inumbo-ID: 391ec1e0-6835-47be-84e4-2421b6afbea5 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 391ec1e0-6835-47be-84e4-2421b6afbea5; Mon, 10 Aug 2020 19:00:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=W7cjAGAbeUEfsu+nc4Pbpl7AkOuBYIRkkqS8eJURwe4=; b=doCXJ02OB1i3klBXF7VcGYrlOk l6mkijCUctoemcD81Rv+1pqo60y5Et3Qlic0OCaqSYO9dBpeT/d/5+CKmvRtYduT/CStdpqwC4hsO 9nY+933SigXkaa+TSsRoPYyOCSTK1GS8slgRiLs2xkx0iKsUJRm7ReAzZRmc9oyEYbXI=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5D1n-0005yj-Ao; Mon, 10 Aug 2020 19:00:11 +0000 Received: from [54.239.6.185] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k5D1n-00047H-0c; Mon, 10 Aug 2020 19:00:11 +0000 Subject: Re: [RFC PATCH V1 04/12] xen/arm: Introduce arch specific bits for IOREQ/DM features To: Oleksandr References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-5-git-send-email-olekstysh@gmail.com> <8e8a394c-bd2a-4444-9f4b-e022c59e0f81@xen.org> From: Julien Grall Message-ID: <659a5b45-a37a-5cf2-0bcd-ba1ea3d47cc4@xen.org> Date: Mon, 10 Aug 2020 20:00:08 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Julien Grall , Jan Beulich , xen-devel@lists.xenproject.org, Daniel De Graaf , Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 10/08/2020 19:09, Oleksandr wrote: > > On 05.08.20 12:32, Julien Grall wrote: > > Hi Julien > >> >>>> @@ -2275,6 +2282,16 @@ static void check_for_vcpu_work(void) >>>>    */ >>>>   void leave_hypervisor_to_guest(void) >>>>   { >>>> +#ifdef CONFIG_IOREQ_SERVER >>>> +    /* >>>> +     * XXX: Check the return. Shall we call that in >>>> +     * continue_running and context_switch instead? >>>> +     * The benefits would be to avoid calling >>>> +     * handle_hvm_io_completion on every return. >>>> +     */ >>> >>> Yeah, that could be a simple and good optimization >> >> Well, it is not simple as it is sounds :). handle_hvm_io_completion() >> is the function in charge to mark the vCPU as waiting for I/O. So we >> would at least need to split the function. >> >> I wrote this TODO because I wasn't sure about the complexity of >> handle_hvm_io_completion(current). Looking at it again, the main >> complexity is the looping over the IOREQ servers. >> >> I think it would be better to optimize handle_hvm_io_completion() >> rather than trying to hack the context_switch() or continue_running(). > Well, is the idea in proposed dirty test patch below close to what you > expect? Patch optimizes handle_hvm_io_completion() to avoid extra > actions if vcpu's domain doesn't have ioreq_server, alternatively > the check could be moved out of handle_hvm_io_completion() to avoid > calling that function at all. This looks ok to me. > BTW, TODO also suggests checking the > return value of handle_hvm_io_completion(), but I am completely sure we > can simply > just return from leave_hypervisor_to_guest() at this point. Could you > please share your opinion? From my understanding, handle_hvm_io_completion() may return false if there is pending I/O or a failure. In the former case, I think we want to call handle_hvm_io_completion() later on. Possibly after we call do_softirq(). I am wondering whether check_for_vcpu_work() could return whether there are more work todo on the behalf of the vCPU. So we could have: do { check_for_pcpu_work(); } while (check_for_vcpu_work()) The implementation of check_for_vcpu_work() would be: if ( !handle_hvm_io_completion() ) return true; /* Rest of the existing code */ return false; Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Aug 10 19:20:55 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 19:20:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5DLi-0000zI-Cs; Mon, 10 Aug 2020 19:20:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5DLg-0000zD-RL for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 19:20:44 +0000 X-Inumbo-ID: 9c0b969d-87f3-4cb3-8432-e5cd5801bf9f Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 9c0b969d-87f3-4cb3-8432-e5cd5801bf9f; Mon, 10 Aug 2020 19:20:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=0lzQzniDZCy13yvf5T1dOfx/ubaamxq3OOCnY2J80CA=; b=wBnpNT8HJp/kHNzvT+zWoHNWER I3UNOYsxRL2iDVsRv3CYa0lcL/AsgkRpOaS5n3oN/JCmQf6UI5E6dmXEdKhV5cOFVvQqnsktzN9Fv g06cGk3qQuEhHqqmYmNRuJfhW8IWFYzsbdIxTx1VI5tYj3YpdGkeP6F0rF0TIVxlerhY=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5DLT-0006NP-PU; Mon, 10 Aug 2020 19:20:31 +0000 Received: from [54.239.6.185] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k5DLS-0004vP-Rz; Mon, 10 Aug 2020 19:20:31 +0000 Subject: Re: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common To: Stefano Stabellini References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-2-git-send-email-olekstysh@gmail.com> <000c01d66a33$2bd56510$83802f30$@xen.org> <9f83a7ed-ca97-449f-c7b9-a1140644abe9@gmail.com> <5df97055-67f9-16cc-a274-864672d67164@xen.org> <1afb9ffd-088c-ef4e-131a-0f2b62142405@xen.org> From: Julien Grall Message-ID: <598e2f35-e70e-36a7-1e5d-259ebb2e3cde@xen.org> Date: Mon, 10 Aug 2020 20:20:27 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: 'Kevin Tian' , 'Jun Nakajima' , 'Wei Liu' , paul@xen.org, 'Andrew Cooper' , 'Ian Jackson' , 'George Dunlap' , 'Tim Deegan' , Oleksandr , 'Oleksandr Tyshchenko' , 'Julien Grall' , 'Jan Beulich' , xen-devel@lists.xenproject.org, =?UTF-8?B?J1JvZ2VyIFBhdSBNb25uw6kn?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 07/08/2020 00:48, Stefano Stabellini wrote: > On Thu, 6 Aug 2020, Julien Grall wrote: >> On 06/08/2020 01:37, Stefano Stabellini wrote: >>> On Wed, 5 Aug 2020, Julien Grall wrote: >>>> On 04/08/2020 20:11, Stefano Stabellini wrote: >>>>> On Tue, 4 Aug 2020, Julien Grall wrote: >>>>>> On 04/08/2020 12:10, Oleksandr wrote: >>>>>>> On 04.08.20 10:45, Paul Durrant wrote: >>>>>>>>> +static inline bool hvm_ioreq_needs_completion(const ioreq_t >>>>>>>>> *ioreq) >>>>>>>>> +{ >>>>>>>>> +    return ioreq->state == STATE_IOREQ_READY && >>>>>>>>> +           !ioreq->data_is_ptr && >>>>>>>>> +           (ioreq->type != IOREQ_TYPE_PIO || ioreq->dir != >>>>>>>>> IOREQ_WRITE); >>>>>>>>> +} >>>>>>>> I don't think having this in common code is correct. The short-cut >>>>>>>> of >>>>>>>> not >>>>>>>> completing PIO reads seems somewhat x86 specific. >>>>>> >>>>>> Hmmm, looking at the code, I think it doesn't wait for PIO writes to >>>>>> complete >>>>>> (not read). Did I miss anything? >>>>>> >>>>>>> Does ARM even >>>>>>>> have the concept of PIO? >>>>>>> >>>>>>> I am not 100% sure here, but it seems that doesn't have. >>>>>> >>>>>> Technically, the PIOs exist on Arm, however they are accessed the same >>>>>> way >>>>>> as >>>>>> MMIO and will have a dedicated area defined by the HW. >>>>>> >>>>>> AFAICT, on Arm64, they are only used for PCI IO Bar. >>>>>> >>>>>> Now the question is whether we want to expose them to the Device >>>>>> Emulator >>>>>> as >>>>>> PIO or MMIO access. From a generic PoV, a DM shouldn't have to care >>>>>> about >>>>>> the >>>>>> architecture used. It should just be able to request a given IOport >>>>>> region. >>>>>> >>>>>> So it may make sense to differentiate them in the common ioreq code as >>>>>> well. >>>>>> >>>>>> I had a quick look at QEMU and wasn't able to tell if PIOs and MMIOs >>>>>> address >>>>>> space are different on Arm as well. Paul, Stefano, do you know what >>>>>> they >>>>>> are >>>>>> doing? >>>>> >>>>> On the QEMU side, it looks like PIO (address_space_io) is used in >>>>> connection with the emulation of the "in" or "out" instructions, see >>>>> ioport.c:cpu_inb for instance. Some parts of PCI on QEMU emulate PIO >>>>> space regardless of the architecture, such as >>>>> hw/pci/pci_bridge.c:pci_bridge_initfn. >>>>> >>>>> However, because there is no "in" and "out" on ARM, I don't think >>>>> address_space_io can be accessed. Specifically, there is no equivalent >>>>> for target/i386/misc_helper.c:helper_inb on ARM. >>>> >>>> So how PCI I/O BAR are accessed? Surely, they could be used on Arm, right? >>> >>> PIO is also memory mapped on ARM and it seems to have its own MMIO >>> address window. >> This part is already well-understood :). However, this only tell us how an OS >> is accessing a PIO. >> >> What I am trying to figure out is how the hardware (or QEMU) is meant to work. >> >> From my understanding, the MMIO access will be received by the hostbridge and >> then forwarded to the appropriate PCI device. The two questions I am trying to >> answer is: How the I/O BARs are configured? Will it contain an MMIO address or >> an offset? >> >> If the answer is the latter, then we will need PIO because a DM will never see >> the MMIO address (the hostbridge will be emulated in Xen). > > Now I understand the question :-) > > This is the way I understand it works. Let's say that the PIO aperture > is 0x1000-0x2000 which is aliased to 0x3eff0000-0x3eff1000. > 0x1000-0x2000 are addresses that cannot be accessed directly. > 0x3eff0000-0x3eff1000 is the range that works. > > A PCI device PIO BAR will have an address in the 0x1000-0x2000 range, > for instance 0x1100. > > However, when the operating system access 0x1100, it will issue a read > to 0x3eff0100. > > Xen will trap the read to 0x3eff0100 and send it to QEMU. > > QEMU has to know that 0x3eff0000-0x3eff1000 is the alias to the PIO > aperture and that 0x3eff0100 correspond to PCI device foobar. Similarly, > QEMU has also to know the address range of the MMIO aperture and its > remappings, if any (it is possible to have address remapping for MMIO > addresses too.) > > I think today this information is "built-in" QEMU, not configurable. It > works fine because *I think* the PCI aperture is pretty much the same on > x86 boards, at least the one supported by QEMU for Xen. Well on x86, the OS will access PIO using inb/outb. So the address received by Xen is 0x1000-0x2000 and then forwarded to the DM using the PIO type. > > On ARM, I think we should explicitly declare the PCI MMIO aperture and > its alias/address-remapping. When we do that, we can also declare the > PIO aperture and its alias/address-remapping. Well yes, we need to define PCI MMIO and PCI I/O region because the guest OS needs to know them. However, I am unsure how this would help us to solve the question whether access to the PCI I/O aperture should be sent as a PIO or MMIO. Per what you wrote, the PCI I/O Bar would be configured with the range 0x1000-0x2000. So a device emulator (this may not be QEMU and only emulate one PCI device!!) will only see that range. How does the device-emulator then know that it needs to watch the region 0x3eff0000-0x3eff1000? It feels to me that it would be easier/make more sense if the DM only say "I want to watch the PIO range 0x1000-0x2000". So Xen would be in charge to do the translation between the OS view and the DM view. This also means a DM would be completely arch-agnostic. This would follow the HW where you can plug your PCI card on any HW. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Aug 10 19:58:54 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 19:58:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5DwS-0003gW-Ks; Mon, 10 Aug 2020 19:58:44 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5DwQ-0003gR-Vf for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 19:58:43 +0000 X-Inumbo-ID: 24964a00-df77-414f-a720-671093d12bc3 Received: from mail-lj1-x243.google.com (unknown [2a00:1450:4864:20::243]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 24964a00-df77-414f-a720-671093d12bc3; Mon, 10 Aug 2020 19:58:41 +0000 (UTC) Received: by mail-lj1-x243.google.com with SMTP id m22so10908097ljj.5 for ; Mon, 10 Aug 2020 12:58:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=Wg6R239/TK4XmUBof9QhqJaWi5XLLO9Eo+nnF7br/6c=; b=VpeNb1/oydOvdrHOyc26PqpFkDVPGjTqEg9GxRX6YDO3yYcmUWXNdu+BawQkdZWSf8 C987833IHBFVXN+iV/0igmYBmggCDugEkjGv/THoYBS9Prw1fLiGA1yLZCUI4CElN3zM VOj0XnZbDVaYIFboJSTDRtpKqlV4bByiPKCaMFfm6sNCIgOEk/99gk4Hbj7VcgCO2Dz/ 2K7ZPGMmPYSSXugIhEg7NzhrKxdIC45vhKXwJU+PiII58KrzEzSUnbuFPiBnubHQ+ow6 yDGazYMCtmCEMES6X+iqCuXG2tX6uREpLCPpe8K78Xlr4iFwCO7/1iMFHCr7JcgzyzKp LWeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=Wg6R239/TK4XmUBof9QhqJaWi5XLLO9Eo+nnF7br/6c=; b=PiHudjIl8YceCY9Gpu2RhWL0cgIkzXQWTZSMb3nTLpGqpBFx6F9VbPG/251i2/vZlJ wboEljTN0NKOlVOnkvVQFxa2/9R3Z7Id0exzraEAiK+eIDEjwPmP/NMh0Hky/2IPXbZk 95i4zIdBIEZu1lUop7WpQn5HC/zHRlO5r8Fga+iDNHuSrX+mYXm7s2CmpWV03WPnAVVW PZc0Er+8dzQ3t87PpEBG2WQM447Wr3MWFmlTM2rN/Z0u/RjU9qoKTIIi9HQM8LCRJ6Il 3HLWUkq6B98K/+kdXgxsrd9n9nDS6W4LSJMh/fWpakKY1PBwcUk2/RXUDNn9Ov/FfXne 6rGg== X-Gm-Message-State: AOAM530Ge5KzXwYnYRLKHiFtrvYmwTaGpX5OO9tXLdxspx9Hui1eBvI+ eWBe0H8sinS5MoqVWSO8XOY= X-Google-Smtp-Source: ABdhPJyMBP5aRLQ5DGnwa9VBPVDzbp0psVJ2QUC2v7udl0oXAhyUx+8NZrbUKM6sUemxfvufGoxl5g== X-Received: by 2002:a2e:80d8:: with SMTP id r24mr1255384ljg.305.1597089520692; Mon, 10 Aug 2020 12:58:40 -0700 (PDT) Received: from [192.168.1.2] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id b81sm11050828lfg.60.2020.08.10.12.58.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Aug 2020 12:58:39 -0700 (PDT) Subject: Re: [RFC PATCH V1 04/12] xen/arm: Introduce arch specific bits for IOREQ/DM features To: Julien Grall References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-5-git-send-email-olekstysh@gmail.com> <11eaa2f0-84c7-5972-d14c-4cb02458e882@xen.org> <3ee50c66-8761-6c86-3fab-a4c23622d2b8@gmail.com> <952392d9-22cc-af66-c1af-f82360b75cf4@gmail.com> <31914fc1-9a00-ef1c-2935-20ced2a2b574@xen.org> From: Oleksandr Message-ID: <19ecf924-1b34-1582-97ad-83c47741109f@gmail.com> Date: Mon, 10 Aug 2020 22:58:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <31914fc1-9a00-ef1c-2935-20ced2a2b574@xen.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Julien Grall , Jan Beulich , xen-devel@lists.xenproject.org, Daniel De Graaf , Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 10.08.20 21:25, Julien Grall wrote: Hi Julien > >>> >>> Do you mind to provide more details? >> Previous patch "xen/mm: Make x86's XENMEM_resource_ioreq_server >> handling common" breaks build on Arm as it includes xen/hvm/ioreq.h >> which requires arch header >> to be present (asm/hvm/ioreq.h). But the missing arch header together >> with other arch specific bits are introduced here in current patch. > > I understand that both Arm and x86 now implement the asm/hvm/ioreq.h. > However, please keep in mind that there might be other architectures > in the future. > > With your change here, you would impose a new arch to implement > asm/hvm/ioreq.h even if the developper have no plan to use the feature. > >> Probably I should have rearranged >> changes in a way to not introduce #ifdef and then remove it... > > Ideally we want to avoid #ifdef in the common code. But if this can't > be done in an header, then the #ifdef here would be fine. Got it. > >>>>> I understand that the x86 version is more complex as it check >>>>> p->df. However, aside reducing the complexity, I am not sure why >>>>> we would want to diverge it. >>>>> >>>>> After all, IOREQ is now meant to be a common feature. >>>> Well, no objections at all. >>>> Could you please clarify how could 'df' (Direction Flag?) be >>>> handled/used on Arm? >>> >>> On x86, this is used by 'rep' instruction to tell the direction to >>> iterate (forward or backward). >>> >>> On Arm, all the accesses to MMIO region will do a single memory >>> access. So for now, we can safely always set to 0. >>> >>>> I see that try_fwd_ioserv() always sets it 0. Or I need to just >>>> reuse x86's helpers as is, >>>> which (together with count = df = 0) will result in what we >>>> actually have here? >>> AFAIU, both count and df should be 0 on Arm. >> >> Thanks for the explanation. The only one question remains where to >> put common helpers hvm_mmio_first_byte/hvm_mmio_last_byte (common >> io.h?)? > > It feels to me it should be part of the common ioreq.h. ok, will move. -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Mon Aug 10 20:29:55 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 20:29:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5EQG-0006Hy-WF; Mon, 10 Aug 2020 20:29:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5EQF-0006Ht-1g for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 20:29:31 +0000 X-Inumbo-ID: dadc102b-93cb-4dd0-92dc-4f0f9d4275c5 Received: from mail-lf1-x142.google.com (unknown [2a00:1450:4864:20::142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id dadc102b-93cb-4dd0-92dc-4f0f9d4275c5; Mon, 10 Aug 2020 20:29:29 +0000 (UTC) Received: by mail-lf1-x142.google.com with SMTP id k13so5449960lfo.0 for ; Mon, 10 Aug 2020 13:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=BD3Vbwi+oq2LFO2ToiTTgKWN0QCnSaB8lgbwysBqW58=; b=bQK33hiwmvWSB0PSKI0qgzCS975J2m4mttz1+ObwWo5jkCGHcmhoErzAks0mxXEg5r sTmwUgY+fPmhMMu3msHi6wP6dXgb2Ry5PivXrNFP5QtWCvnj8xkYYrGqRpmLZ7s1L1JN z/qqJ2QcxZgFsMykcr4PxM0so99tJWLnCt6mvsGp8Kob6Tys/4N2QMpM8TQo3m+PuGvH 4Cv2HKldaVX/5RXiwrKXzVBj0VUQ0if+ADJpUCuQ1uUPqI32xLxHByl8M7Qnm37HCq3w sbNV2t2W9CntBXjHqjRxlF6YwJ5yLT2V2UDGEfKGkHNuZBqckp39p9qBv1wgR3FaGtNx Rjtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=BD3Vbwi+oq2LFO2ToiTTgKWN0QCnSaB8lgbwysBqW58=; b=PZbq/7gWeHKH0VjvqNM1bL/C8/RhFdLqSqlhLdbK0GJ4Vfu1EEW+NBEb8zTVcyIf7l BlyrdFWKTaZ+py1mFyZ0mMJVcDCGXs7SzsQXOw0ndWHh23KG1hPcdpIqG7CdLucc8RDF qXRkjvIjliwZdzapp6+Mpe6IYeJS4RVTM5mRfWLdZFohXgf/Bzm3g64At2pWuwYuuotW p6SU/Ebrqa1KAbmRF38DgP3WcZ9ZaVeDKUeGfMfpPPKh0PxmhxdijKk2zRzalxMMayDT 0EWQpqIWO/akvr8ROZfASl8I97rb3sukCuj40jQIzB+CFGKI9xD/nMuOfBqdsXQ/XY2h BfrA== X-Gm-Message-State: AOAM530EjTc4zdJZqHhSYBlULLFZa0runItjexCuN4bxBqbScUFVArRT yrICKS6vPYRlj+A+kehzs/s= X-Google-Smtp-Source: ABdhPJylUbJdP83G68k67pcp+SNO2xrODP/C/otX700w96K1H1511nNo0RPaTSRCG3IkjyL6bRlNjg== X-Received: by 2002:ac2:4c05:: with SMTP id t5mr1404300lfq.89.1597091368413; Mon, 10 Aug 2020 13:29:28 -0700 (PDT) Received: from [192.168.1.2] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id j6sm10563647ljc.18.2020.08.10.13.29.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Aug 2020 13:29:27 -0700 (PDT) Subject: Re: [RFC PATCH V1 04/12] xen/arm: Introduce arch specific bits for IOREQ/DM features To: Julien Grall References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-5-git-send-email-olekstysh@gmail.com> <8e8a394c-bd2a-4444-9f4b-e022c59e0f81@xen.org> <659a5b45-a37a-5cf2-0bcd-ba1ea3d47cc4@xen.org> From: Oleksandr Message-ID: <48a130dc-57fd-0627-d188-ddff4abf6778@gmail.com> Date: Mon, 10 Aug 2020 23:29:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <659a5b45-a37a-5cf2-0bcd-ba1ea3d47cc4@xen.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Julien Grall , Jan Beulich , xen-devel@lists.xenproject.org, Daniel De Graaf , Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 10.08.20 22:00, Julien Grall wrote: Hi Julien > >>> >>>>> @@ -2275,6 +2282,16 @@ static void check_for_vcpu_work(void) >>>>>    */ >>>>>   void leave_hypervisor_to_guest(void) >>>>>   { >>>>> +#ifdef CONFIG_IOREQ_SERVER >>>>> +    /* >>>>> +     * XXX: Check the return. Shall we call that in >>>>> +     * continue_running and context_switch instead? >>>>> +     * The benefits would be to avoid calling >>>>> +     * handle_hvm_io_completion on every return. >>>>> +     */ >>>> >>>> Yeah, that could be a simple and good optimization >>> >>> Well, it is not simple as it is sounds :). >>> handle_hvm_io_completion() is the function in charge to mark the >>> vCPU as waiting for I/O. So we would at least need to split the >>> function. >>> >>> I wrote this TODO because I wasn't sure about the complexity of >>> handle_hvm_io_completion(current). Looking at it again, the main >>> complexity is the looping over the IOREQ servers. >>> >>> I think it would be better to optimize handle_hvm_io_completion() >>> rather than trying to hack the context_switch() or continue_running(). >> Well, is the idea in proposed dirty test patch below close to what >> you expect? Patch optimizes handle_hvm_io_completion() to avoid extra >> actions if vcpu's domain doesn't have ioreq_server, alternatively >> the check could be moved out of handle_hvm_io_completion() to avoid >> calling that function at all. > > This looks ok to me. > >> BTW, TODO also suggests checking the return value of >> handle_hvm_io_completion(), but I am completely sure we can simply >> just return from leave_hypervisor_to_guest() at this point. Could you >> please share your opinion? > > From my understanding, handle_hvm_io_completion() may return false if > there is pending I/O or a failure. It seems, yes > > In the former case, I think we want to call handle_hvm_io_completion() > later on. Possibly after we call do_softirq(). > > I am wondering whether check_for_vcpu_work() could return whether > there are more work todo on the behalf of the vCPU. > > So we could have: > > do > { >   check_for_pcpu_work(); > } while (check_for_vcpu_work()) > > The implementation of check_for_vcpu_work() would be: > > if ( !handle_hvm_io_completion() ) >   return true; > > /* Rest of the existing code */ > > return false; Thank you, will give it a try. Can we behave the same way for both "pending I/O" and "failure" or we need to distinguish them? Probably we need some sort of safe timeout/number attempts in order to not spin forever? -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Mon Aug 10 22:38:23 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 22:38:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5GQd-00008s-HB; Mon, 10 Aug 2020 22:38:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5GQc-00008n-V4 for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 22:38:03 +0000 X-Inumbo-ID: 3ea5796a-7e7c-4262-9a14-29338de17ed8 Received: from mail-wm1-x342.google.com (unknown [2a00:1450:4864:20::342]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3ea5796a-7e7c-4262-9a14-29338de17ed8; Mon, 10 Aug 2020 22:38:01 +0000 (UTC) Received: by mail-wm1-x342.google.com with SMTP id f18so897436wmc.0 for ; Mon, 10 Aug 2020 15:38:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fDsiuLPQ59OP1+i2xJ/jl++wqzTXI6dpK6NdpqI0a28=; b=aYw4TuF/9xzpkpCvhbHDgrmbLO7ufHfKK5m5btLFjv/da3idv1CJ+0k3u5i0759LYU McNRMdKAru+g2rLq30sESl/nK3qxyvX5NtTabp/nNZraiav7FMFdZcOZSFWejLde7X1f YuK4YDKdXy4D05mQW82m+hp4nZTaElzcxoRWUpw94mkdqkRurveE02/qSwQpaJoSNY7q iDuPkx5RaUQWjGMDFqzcHduyHIs4BLjKWrMxILyisvlj599eYdLJ+eVMnMH3msptDpYE rx0uFP0Cu2R1XPEW+0WIIyCPCmcsrz0RzKDuFgBD5k62DkgqTKl/i0paXgcS4iB3XXoh +pyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fDsiuLPQ59OP1+i2xJ/jl++wqzTXI6dpK6NdpqI0a28=; b=CzGR1QFzwOQR8pG4vDTmppDR7ClQAzZCVvYO3Ixez/0u2nEk1brArviMpdlnEVDdNn 7jDkjVQCxe7sHXZbpwuknqdtjRtDTErV7YwGZf88tE+gKOiPlXFf/mJq5HjtdlokvsJa 0hv3GDVfWB152NJk92px4IYrVlck//Pmxp7WMX6rcRJxvbC3z8XAXXFOppdHzoPmJ0/c /2/c+1gpl8p/eTjBhSmgV4qyfKLmf04Ypz6I1glBVU1oy6I/ecM3FA+MdEFd/HP+/M2O 5KMhklnjsNVRAiwfSwd8DXMwU2gYM0utLpba6VK0qx1/tDjVuln+yfFdHmz89+Rh8rWb O+3g== X-Gm-Message-State: AOAM5336ljEJzSWC8z/5jDJyENMBJJfbTXQ012KsZY96xGoOTXXYGob5 naF6HaCtLd2jf5VZ/pKpH+zhI1VJ5kGmgJQ0yaw= X-Google-Smtp-Source: ABdhPJyJFZKkVxDdmu7DqL8Zc4lYiAm68TbqKneMEczWt/q/Ui/nTACz/yxfM96NFcyTe4RTjkTJVBWb/YZzZ1i7/E0= X-Received: by 2002:a7b:cc90:: with SMTP id p16mr1260039wma.79.1597099080842; Mon, 10 Aug 2020 15:38:00 -0700 (PDT) MIME-Version: 1.0 References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-5-git-send-email-olekstysh@gmail.com> <8e8a394c-bd2a-4444-9f4b-e022c59e0f81@xen.org> <659a5b45-a37a-5cf2-0bcd-ba1ea3d47cc4@xen.org> <48a130dc-57fd-0627-d188-ddff4abf6778@gmail.com> In-Reply-To: <48a130dc-57fd-0627-d188-ddff4abf6778@gmail.com> From: Julien Grall Date: Mon, 10 Aug 2020 23:37:49 +0100 Message-ID: Subject: Re: [RFC PATCH V1 04/12] xen/arm: Introduce arch specific bits for IOREQ/DM features To: Oleksandr Content-Type: text/plain; charset="UTF-8" X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Julien Grall , Jan Beulich , xen-devel , Daniel De Graaf , Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Mon, 10 Aug 2020 at 21:29, Oleksandr wrote: > > > On 10.08.20 22:00, Julien Grall wrote: > > Hi Julien > > > > >>> > >>>>> @@ -2275,6 +2282,16 @@ static void check_for_vcpu_work(void) > >>>>> */ > >>>>> void leave_hypervisor_to_guest(void) > >>>>> { > >>>>> +#ifdef CONFIG_IOREQ_SERVER > >>>>> + /* > >>>>> + * XXX: Check the return. Shall we call that in > >>>>> + * continue_running and context_switch instead? > >>>>> + * The benefits would be to avoid calling > >>>>> + * handle_hvm_io_completion on every return. > >>>>> + */ > >>>> > >>>> Yeah, that could be a simple and good optimization > >>> > >>> Well, it is not simple as it is sounds :). > >>> handle_hvm_io_completion() is the function in charge to mark the > >>> vCPU as waiting for I/O. So we would at least need to split the > >>> function. > >>> > >>> I wrote this TODO because I wasn't sure about the complexity of > >>> handle_hvm_io_completion(current). Looking at it again, the main > >>> complexity is the looping over the IOREQ servers. > >>> > >>> I think it would be better to optimize handle_hvm_io_completion() > >>> rather than trying to hack the context_switch() or continue_running(). > >> Well, is the idea in proposed dirty test patch below close to what > >> you expect? Patch optimizes handle_hvm_io_completion() to avoid extra > >> actions if vcpu's domain doesn't have ioreq_server, alternatively > >> the check could be moved out of handle_hvm_io_completion() to avoid > >> calling that function at all. > > > > This looks ok to me. > > > >> BTW, TODO also suggests checking the return value of > >> handle_hvm_io_completion(), but I am completely sure we can simply > >> just return from leave_hypervisor_to_guest() at this point. Could you > >> please share your opinion? > > > > From my understanding, handle_hvm_io_completion() may return false if > > there is pending I/O or a failure. > > It seems, yes > > > > > > In the former case, I think we want to call handle_hvm_io_completion() > > later on. Possibly after we call do_softirq(). > > > > I am wondering whether check_for_vcpu_work() could return whether > > there are more work todo on the behalf of the vCPU. > > > > So we could have: > > > > do > > { > > check_for_pcpu_work(); > > } while (check_for_vcpu_work()) > > > > The implementation of check_for_vcpu_work() would be: > > > > if ( !handle_hvm_io_completion() ) > > return true; > > > > /* Rest of the existing code */ > > > > return false; > > Thank you, will give it a try. > > Can we behave the same way for both "pending I/O" and "failure" or we > need to distinguish them? We don't need to distinguish them. In both cases, we will want to process softirqs. In all the failure cases, the domain will have crashed. Therefore the vCPU will be unscheduled. > > Probably we need some sort of safe timeout/number attempts in order to > not spin forever? Well, anything based on timeout/number of attempts is flaky. How do you know whether the I/O is just taking a "long time" to complete? But a vCPU shouldn't continue until an I/O has completed. This is nothing very different than what a processor would do. In Xen case, if an I/O never completes then it most likely means that something went horribly wrong with the Device Emulator. So it is most likely not safe to continue. In HW, when there is a device failure, the OS may receive an SError (this is implementation defined) and could act accordingly if it is able to recognize the issue. It *might* be possible to send a virtual SError but there are a couple of issues with it: * How do you detect a failure? * SErrors are implementations defined. You would need to teach your OS (or the firmware) how to deal with them. I would expect quite a bit of effort in order to design and implement it. For now, it is probably best to just let the vCPU spin forever. This wouldn't be an issue for Xen as do_softirq() would be called at every loop. Cheers, From xen-devel-bounces@lists.xenproject.org Mon Aug 10 23:34:23 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 23:34:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5HJ0-00055f-P2; Mon, 10 Aug 2020 23:34:14 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5HIz-00055a-9e for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 23:34:13 +0000 X-Inumbo-ID: bf34b211-bbce-4357-b72e-ba6cd6f4d004 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id bf34b211-bbce-4357-b72e-ba6cd6f4d004; Mon, 10 Aug 2020 23:34:12 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F1207206DA; Mon, 10 Aug 2020 23:34:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597102451; bh=tVD2FJ00WBqm2ZG05dmvzk6bspKQ4r+EHqC9bGPgIBY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=o+ylv8hhpuSfbUEMTkPPiTZDpPOXd7VXwRUvypdvYCZirh/8blnURJuOyCur7uz/f LP5guFGvDfQnCMRRoQwUjsVyKoZeTtowTdOTKdmJnYRV38WNKhLQW7zEGCjeOx45Ry 4STD2X5GNokEytC8tHgz7v7h+Qyx93GNNV1cdKg4= Date: Mon, 10 Aug 2020 16:34:10 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Julien Grall Subject: Re: [RFC PATCH V1 05/12] hvm/dm: Introduce xendevicemodel_set_irq_level DM op In-Reply-To: Message-ID: References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-6-git-send-email-olekstysh@gmail.com> <00e261e0-295a-9cd8-ed11-7e3801a4eb58@xen.org> <92e2b136-8468-2877-0e8c-c13ff2a0a1fb@xen.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Oleksandr Tyshchenko , Julien Grall , Jan Beulich , xen-devel , Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Sat, 8 Aug 2020, Julien Grall wrote: > On Fri, 7 Aug 2020 at 22:51, Stefano Stabellini wrote: > > > > On Fri, 7 Aug 2020, Jan Beulich wrote: > > > On 07.08.2020 01:49, Stefano Stabellini wrote: > > > > On Thu, 6 Aug 2020, Julien Grall wrote: > > > >> On 06/08/2020 01:37, Stefano Stabellini wrote: > > > >>> On Wed, 5 Aug 2020, Julien Grall wrote: > > > >>>> On 05/08/2020 00:22, Stefano Stabellini wrote: > > > >>>>> On Mon, 3 Aug 2020, Oleksandr Tyshchenko wrote: > > > >>>>>> From: Oleksandr Tyshchenko > > > >>>>>> > > > >>>>>> This patch adds ability to the device emulator to notify otherend > > > >>>>>> (some entity running in the guest) using a SPI and implements Arm > > > >>>>>> specific bits for it. Proposed interface allows emulator to set > > > >>>>>> the logical level of a one of a domain's IRQ lines. > > > >>>>>> > > > >>>>>> Please note, this is a split/cleanup of Julien's PoC: > > > >>>>>> "Add support for Guest IO forwarding to a device emulator" > > > >>>>>> > > > >>>>>> Signed-off-by: Julien Grall > > > >>>>>> Signed-off-by: Oleksandr Tyshchenko > > > >>>>>> --- > > > >>>>>> tools/libs/devicemodel/core.c | 18 > > > >>>>>> ++++++++++++++++++ > > > >>>>>> tools/libs/devicemodel/include/xendevicemodel.h | 4 ++++ > > > >>>>>> tools/libs/devicemodel/libxendevicemodel.map | 1 + > > > >>>>>> xen/arch/arm/dm.c | 22 > > > >>>>>> +++++++++++++++++++++- > > > >>>>>> xen/common/hvm/dm.c | 1 + > > > >>>>>> xen/include/public/hvm/dm_op.h | 15 > > > >>>>>> +++++++++++++++ > > > >>>>>> 6 files changed, 60 insertions(+), 1 deletion(-) > > > >>>>>> > > > >>>>>> diff --git a/tools/libs/devicemodel/core.c > > > >>>>>> b/tools/libs/devicemodel/core.c > > > >>>>>> index 4d40639..30bd79f 100644 > > > >>>>>> --- a/tools/libs/devicemodel/core.c > > > >>>>>> +++ b/tools/libs/devicemodel/core.c > > > >>>>>> @@ -430,6 +430,24 @@ int xendevicemodel_set_isa_irq_level( > > > >>>>>> return xendevicemodel_op(dmod, domid, 1, &op, sizeof(op)); > > > >>>>>> } > > > >>>>>> +int xendevicemodel_set_irq_level( > > > >>>>>> + xendevicemodel_handle *dmod, domid_t domid, uint32_t irq, > > > >>>>>> + unsigned int level) > > > >>>>> > > > >>>>> It is a pity that having xen_dm_op_set_pci_intx_level and > > > >>>>> xen_dm_op_set_isa_irq_level already we need to add a third one, but from > > > >>>>> the names alone I don't think we can reuse either of them. > > > >>>> > > > >>>> The problem is not the name... > > > >>>> > > > >>>>> > > > >>>>> It is very similar to set_isa_irq_level. We could almost rename > > > >>>>> xendevicemodel_set_isa_irq_level to xendevicemodel_set_irq_level or, > > > >>>>> better, just add an alias to it so that xendevicemodel_set_irq_level is > > > >>>>> implemented by calling xendevicemodel_set_isa_irq_level. Honestly I am > > > >>>>> not sure if it is worth doing it though. Any other opinions? > > > >>>> > > > >>>> ... the problem is the interrupt field is only 8-bit. So we would only be > > > >>>> able > > > >>>> to cover IRQ 0 - 255. > > > >>> > > > >>> Argh, that's not going to work :-( I wasn't sure if it was a good idea > > > >>> anyway. > > > >>> > > > >>> > > > >>>> It is not entirely clear how the existing subop could be extended without > > > >>>> breaking existing callers. > > > >>>> > > > >>>>> But I think we should plan for not needing two calls (one to set level > > > >>>>> to 1, and one to set it to 0): > > > >>>>> https://marc.info/?l=xen-devel&m=159535112027405 > > > >>>> > > > >>>> I am not sure to understand your suggestion here? Are you suggesting to > > > >>>> remove > > > >>>> the 'level' parameter? > > > >>> > > > >>> My hope was to make it optional to call the hypercall with level = 0, > > > >>> not necessarily to remove 'level' from the struct. > > > >> > > > >> From my understanding, the hypercall is meant to represent the status of the > > > >> line between the device and the interrupt controller (either low or high). > > > >> > > > >> This is then up to the interrupt controller to decide when the interrupt is > > > >> going to be fired: > > > >> - For edge interrupt, this will fire when the line move from low to high (or > > > >> vice versa). > > > >> - For level interrupt, this will fire when line is high (assuming level > > > >> trigger high) and will keeping firing until the device decided to lower the > > > >> line. > > > >> > > > >> For a device, it is common to keep the line high until an OS wrote to a > > > >> specific register. > > > >> > > > >> Furthermore, technically, the guest OS is in charge to configure how an > > > >> interrupt is triggered. Admittely this information is part of the DT, but > > > >> nothing prevent a guest to change it. > > > >> > > > >> As side note, we have a workaround in Xen for some buggy DT (see the arch > > > >> timer) exposing the wrong trigger type. > > > >> > > > >> Because of that, I don't really see a way to make optional. Maybe you have > > > >> something different in mind? > > > > > > > > For level, we need the level parameter. For edge, we are only interested > > > > in the "edge", right? > > > > > > I don't think so, unless Arm has special restrictions. Edges can be > > > both rising and falling ones. > > > > And the same is true for level interrupts too: they could be active-low > > or active-high. > > > > > > Instead of modelling the state of the line, which seems to be a bit > > error prone especially in the case of a single-device emulator that > > might not have enough information about the rest of the system (it might > > not know if the interrupt is active-high or active-low), we could model > > the triggering of the interrupt instead. > > I am not sure to understand why the single (or event multiple) device > emulator needs to know the trigger type. The information of the > trigger type of the interrupt would be described in the firmware table > and it is expected to be the same as what the emulator expects. > > If the guest OS decided to configure wrongly the interrupt trigger > type, then it may not work properly. But, from my understanding, this > doesn't differ from the HW behavior. > > > > > In the case of level=1, it would mean that the interrupt line is active, > > no matter if it is active-low or active-high. In the case of level=0, it > > would mean that it is inactive. > > > > Similarly, in the case of an edge interrupt edge=1 or level=1 would mean > > that there is an edge, no matter if it is rising or falling. > > TBH, I think your approach is only going to introduce more headache in > Xen if a guest OS decides to change the trigger type. > > It feels much easier to just ask the emulator to let us know the level > of the line. Then if the guest OS decides to change the trigger type, > we only need to resample the line. Emulators, at least the ones in QEMU, don't model the hardware so closely to care about trigger type. The only thing they typically care about is to fire a notification. The trigger type only comes into the picture when there is a bug or a disagreement between Xen and QEMU. Imagine a device that can be both level active-high or active-low, if the guest kernel changes the configuration, Xen would know about it, but QEMU wouldn't. I vaguely recall a bug 10+ years ago about this with QEMU on x86 and a line that could be both active-high and active-low. So QEMU would raise the interrupt but Xen would actually think that QEMU stopped the interrupt. To do this right, we would have to introduce an interface between Xen and QEMU to propagate the trigger type. Xen would have to tell QEMU when the guest changed the configuration. That would work, but it would be better if we can figure out a way to do without it to reduce complexity. Instead, given that QEMU and other emulators don't actually care about active-high or active-low, if we have a Xen interface that just says "fire the interrupt" we get away from this kind of troubles. It would also be more efficient because the total number of hypercalls required would be lower. From xen-devel-bounces@lists.xenproject.org Mon Aug 10 23:34:23 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 23:34:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5HJ8-00056K-79; Mon, 10 Aug 2020 23:34:22 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5HJ6-00056C-5f for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 23:34:20 +0000 X-Inumbo-ID: ee4bccd4-e02b-478c-a0f1-6d591fcbf6eb Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ee4bccd4-e02b-478c-a0f1-6d591fcbf6eb; Mon, 10 Aug 2020 23:34:19 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 55648206DA; Mon, 10 Aug 2020 23:34:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597102458; bh=JlWIceHJKmkCzLojUgDXFu8M8TOrsQD3Kh5m9CJMlv4=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=0nL56wCN9Gi3aIYWwcoKODFe/BxskENM7i96BQPhkyPG1/P1rqzOLp2J1HwQDotpA 2KdYUykzmgIm9kNQ9/Z5tZDPATTxXn65EyFFsrsFeW4RJaw31B8g+dunXuTTB8k1U0 l3k3goVG8yGtsdUVs7CK50hHwnNjhzRLRQBn8R00= Date: Mon, 10 Aug 2020 16:34:17 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Oleksandr Subject: Re: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common In-Reply-To: <910ec6ee-1076-2c9d-c01d-b6b4cc0bc6b8@gmail.com> Message-ID: References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-2-git-send-email-olekstysh@gmail.com> <000c01d66a33$2bd56510$83802f30$@xen.org> <9f83a7ed-ca97-449f-c7b9-a1140644abe9@gmail.com> <2ab4c567-8efa-1b9d-ab00-4ea7e1ab323e@suse.com> <013b142d-5296-5bbe-7d19-903f59e0c974@gmail.com> <910ec6ee-1076-2c9d-c01d-b6b4cc0bc6b8@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: 'Kevin Tian' , Stefano Stabellini , Julien Grall , 'Jun Nakajima' , 'Wei Liu' , paul@xen.org, 'Andrew Cooper' , 'Ian Jackson' , 'George Dunlap' , 'Tim Deegan' , 'Oleksandr Tyshchenko' , 'Julien Grall' , Jan Beulich , xen-devel@lists.xenproject.org, =?UTF-8?Q?'Roger_Pau_Monn=C3=A9'?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Sat, 8 Aug 2020, Oleksandr wrote: > On 08.08.20 00:50, Stefano Stabellini wrote: > > On Fri, 7 Aug 2020, Oleksandr wrote: > > > On 06.08.20 03:37, Stefano Stabellini wrote: > > > > > > Hi Stefano > > > > > > Trying to simulate IO_RETRY handling mechanism (according to model below) > > > I > > > continuously get IO_RETRY from try_fwd_ioserv() ... > > > > > > > OK, thanks for the details. My interpretation seems to be correct. > > > > > > > > In which case, it looks like xen/arch/arm/io.c:try_fwd_ioserv should > > > > return IO_RETRY. Then, xen/arch/arm/traps.c:do_trap_stage2_abort_guest > > > > also needs to handle try_handle_mmio returning IO_RETRY the first > > > > around, and IO_HANDLED when after QEMU does its job. > > > > > > > > What should do_trap_stage2_abort_guest do on IO_RETRY? Simply return > > > > early and let the scheduler do its job? Something like: > > > > > > > > enum io_state state = try_handle_mmio(regs, hsr, gpa); > > > > > > > > switch ( state ) > > > > { > > > > case IO_ABORT: > > > > goto inject_abt; > > > > case IO_HANDLED: > > > > advance_pc(regs, hsr); > > > > return; > > > > case IO_RETRY: > > > > /* finish later */ > > > > return; > > > > case IO_UNHANDLED: > > > > /* IO unhandled, try another way to handle it. */ > > > > break; > > > > default: > > > > ASSERT_UNREACHABLE(); > > > > } > > > > > > > > Then, xen/arch/arm/ioreq.c:handle_mmio() gets called by > > > > handle_hvm_io_completion() after QEMU completes the emulation. Today, > > > > handle_mmio just sets the user register with the read value. > > > > > > > > But it would be better if it called again the original function > > > > do_trap_stage2_abort_guest to actually retry the original operation. > > > > This time do_trap_stage2_abort_guest calls try_handle_mmio() and gets > > > > IO_HANDLED instead of IO_RETRY, > > > I may miss some important point, but I failed to see why try_handle_mmio > > > (try_fwd_ioserv) will return IO_HANDLED instead of IO_RETRY at this stage. > > > Or current try_fwd_ioserv() logic needs rework? > > I think you should check the ioreq->state in try_fwd_ioserv(), if the > > result is ready, then ioreq->state should be STATE_IORESP_READY, and you > > can return IO_HANDLED. > > > > That is assuming that you are looking at the live version of the ioreq > > shared with QEMU instead of a private copy of it, which I am not sure. > > Looking at try_fwd_ioserv() it would seem that vio->io_req is just a > > copy? The live version is returned by get_ioreq() ? > > If I understand the code correctly, indeed, get_ioreq() returns live version > shared with emulator. > Desired state change (STATE_IORESP_READY) what actually the hvm_wait_for_io() > is waiting for is set here (in my case): > https://xenbits.xen.org/gitweb/?p=people/pauldu/demu.git;a=blob;f=demu.c;h=f785b394d0cf141dffa05bdddecf338214358aea;hb=refs/heads/master#l698 > > > Even in handle_hvm_io_completion, instead of setting vio->io_req.state > > to STATE_IORESP_READY by hand, it would be better to look at the live > > version of the ioreq because QEMU will have already set ioreq->state > > to STATE_IORESP_READY (hw/i386/xen/xen-hvm.c:cpu_handle_ioreq). > It seems that after detecting STATE_IORESP_READY in hvm_wait_for_io() the > state of live version is set to STATE_IOREQ_NONE immediately, so looking at > the live version down the handle_hvm_io_completion() > or in try_fwd_ioserv() shows us nothing I am afraid. I see. That is because we want to "free" the ioreq as soon as possible, which is good. handle_hvm_io_completion also sets vio->io_req.state to STATE_IORESP_READY, so our private copy is still set to STATE_IORESP_READY. Thus, try_fwd_ioserv should do the right thing simply reading vio->io_req.state: try_fwd_ioserv should be able to return IO_HANDLED when the "state" is STATE_IORESP_READY, right? From xen-devel-bounces@lists.xenproject.org Mon Aug 10 23:34:33 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 23:34:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5HJJ-00058N-Hc; Mon, 10 Aug 2020 23:34:33 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5HJI-00058F-Q0 for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 23:34:32 +0000 X-Inumbo-ID: c0eac35a-3d07-4be8-a27e-860e5302fa37 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c0eac35a-3d07-4be8-a27e-860e5302fa37; Mon, 10 Aug 2020 23:34:26 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6DDD1206DA; Mon, 10 Aug 2020 23:34:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597102466; bh=UNAKJZe0LSWkIc0N1phrCRKY4Ib/jVT1H5CObG+5mXY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=TvICtCiSTGEzLilQUlsbwWQST8sJbBzMusxxq+o2ygWsmq7DyWs8m6o7zVU7yWKat akK7rBU1431liTqQRpLmJ3vUeJS8NcBTZD4TsV2LKH5sUmuZ+P06RW8joaZgJ7ekPO GdOvxQcE3QgDwNeaYBYvuB3vmuLbgEDEN7xdsUkk= Date: Mon, 10 Aug 2020 16:34:25 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Oleksandr Subject: Re: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common In-Reply-To: <27513b2b-e59b-d446-7e68-eac4bc503409@gmail.com> Message-ID: References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-2-git-send-email-olekstysh@gmail.com> <000c01d66a33$2bd56510$83802f30$@xen.org> <9f83a7ed-ca97-449f-c7b9-a1140644abe9@gmail.com> <2ab4c567-8efa-1b9d-ab00-4ea7e1ab323e@suse.com> <013b142d-5296-5bbe-7d19-903f59e0c974@gmail.com> <06f78323-b8f5-fd11-486a-437267eccc29@gmail.com> <27513b2b-e59b-d446-7e68-eac4bc503409@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1044303261-1597086100=:16004" Content-ID: X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: 'Kevin Tian' , Stefano Stabellini , Julien Grall , 'Jun Nakajima' , 'Wei Liu' , paul@xen.org, 'Andrew Cooper' , 'Ian Jackson' , 'George Dunlap' , 'Tim Deegan' , 'Oleksandr Tyshchenko' , 'Julien Grall' , Jan Beulich , xen-devel@lists.xenproject.org, =?UTF-8?Q?'Roger_Pau_Monn=C3=A9'?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1044303261-1597086100=:16004 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Mon, 10 Aug 2020, Oleksandr wrote: > On 08.08.20 01:19, Oleksandr wrote: > > On 08.08.20 00:50, Stefano Stabellini wrote: > > > On Fri, 7 Aug 2020, Oleksandr wrote: > > > > On 06.08.20 03:37, Stefano Stabellini wrote: > > > > > > > > Hi Stefano > > > > > > > > Trying to simulate IO_RETRY handling mechanism (according to model > > > > below) I > > > > continuously get IO_RETRY from try_fwd_ioserv() ... > > > > > > > > > OK, thanks for the details. My interpretation seems to be correct. > > > > > > > > > > In which case, it looks like xen/arch/arm/io.c:try_fwd_ioserv should > > > > > return IO_RETRY. Then, xen/arch/arm/traps.c:do_trap_stage2_abort_guest > > > > > also needs to handle try_handle_mmio returning IO_RETRY the first > > > > > around, and IO_HANDLED when after QEMU does its job. > > > > > > > > > > What should do_trap_stage2_abort_guest do on IO_RETRY? Simply return > > > > > early and let the scheduler do its job? Something like: > > > > > > > > > >               enum io_state state = try_handle_mmio(regs, hsr, gpa); > > > > > > > > > >               switch ( state ) > > > > >               { > > > > >               case IO_ABORT: > > > > >                   goto inject_abt; > > > > >               case IO_HANDLED: > > > > >                   advance_pc(regs, hsr); > > > > >                   return; > > > > >               case IO_RETRY: > > > > >                   /* finish later */ > > > > >                   return; > > > > >               case IO_UNHANDLED: > > > > >                   /* IO unhandled, try another way to handle it. */ > > > > >                   break; > > > > >               default: > > > > >                   ASSERT_UNREACHABLE(); > > > > >               } > > > > > > > > > > Then, xen/arch/arm/ioreq.c:handle_mmio() gets called by > > > > > handle_hvm_io_completion() after QEMU completes the emulation. Today, > > > > > handle_mmio just sets the user register with the read value. > > > > > > > > > > But it would be better if it called again the original function > > > > > do_trap_stage2_abort_guest to actually retry the original operation. > > > > > This time do_trap_stage2_abort_guest calls try_handle_mmio() and gets > > > > > IO_HANDLED instead of IO_RETRY, > > > > I may miss some important point, but I failed to see why try_handle_mmio > > > > (try_fwd_ioserv) will return IO_HANDLED instead of IO_RETRY at this > > > > stage. > > > > Or current try_fwd_ioserv() logic needs rework? > > > I think you should check the ioreq->state in try_fwd_ioserv(), if the > > > result is ready, then ioreq->state should be STATE_IORESP_READY, and you > > > can return IO_HANDLED. > > > > I optimized test patch a bit (now it looks much simpler). I didn't face any > issues during a quick test. Both patches get much closer to following the proper state machine, great! I think this patch is certainly a good improvement. I think the other patch you sent earlier, slightly larger, is even better. It makes the following additional changes that would be good to have: - try_fwd_ioserv returns IO_HANDLED on state == STATE_IORESP_READY - handle_mmio simply calls do_trap_stage2_abort_guest I would also remove "handle_mmio_finish" and do the guest register setting as well as setting vio->io_req.state to STATE_IOREQ_NONE directly in try_fwd_ioserv. > --- >  xen/arch/arm/io.c    | 4 ---- >  xen/arch/arm/ioreq.c | 7 ++++++- >  xen/arch/arm/traps.c | 4 +++- >  3 files changed, 9 insertions(+), 6 deletions(-) > > diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c > index 436f669..3063577 100644 > --- a/xen/arch/arm/io.c > +++ b/xen/arch/arm/io.c > @@ -156,10 +156,6 @@ static enum io_state try_fwd_ioserv(struct cpu_user_regs > *regs, >      else >          vio->io_completion = HVMIO_mmio_completion; > > -    /* XXX: Decide what to do */ > -    if ( rc 7== IO_RETRY ) > -        rc = IO_HANDLED; > - >      return rc; >  } >  #endif > diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c > index 8f60c41..e5235c6 100644 > --- a/xen/arch/arm/ioreq.c > +++ b/xen/arch/arm/ioreq.c > @@ -33,6 +33,8 @@ >  #include >  #include > > +#include > + >  bool handle_mmio(void) >  { >      struct vcpu *v = current; > @@ -52,7 +54,7 @@ bool handle_mmio(void) > >      /* XXX: Do we need to take care of write here ? */ >      if ( dabt.write ) > -        return true; > +        goto done; > >      /* >       * Sign extend if required. > @@ -72,6 +74,9 @@ bool handle_mmio(void) > >      set_user_reg(regs, dabt.reg, r); > > +done: > +    advance_pc(regs, hsr); > + >      return true; >  } > > diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c > index ea472d1..974c744 100644 > --- a/xen/arch/arm/traps.c > +++ b/xen/arch/arm/traps.c > @@ -1965,11 +1965,13 @@ static void do_trap_stage2_abort_guest(struct > cpu_user_regs *regs, >              case IO_HANDLED: >                  advance_pc(regs, hsr); >                  return; > +            case IO_RETRY: > +                /* finish later */ > +                return; >              case IO_UNHANDLED: >                  /* IO unhandled, try another way to handle it. */ >                  break; >              default: > -                /* XXX: Handle IO_RETRY */ >                  ASSERT_UNREACHABLE(); >              } >          } --8323329-1044303261-1597086100=:16004-- From xen-devel-bounces@lists.xenproject.org Mon Aug 10 23:34:46 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 23:34:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5HJW-0005Bl-RR; Mon, 10 Aug 2020 23:34:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5HJV-0005BU-9d for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 23:34:45 +0000 X-Inumbo-ID: 4a739c9c-53b9-4d4d-9c1b-a74747a7275b Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4a739c9c-53b9-4d4d-9c1b-a74747a7275b; Mon, 10 Aug 2020 23:34:44 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6641C206DA; Mon, 10 Aug 2020 23:34:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597102484; bh=aAcQyU5g0zrcYfx/4ZmXuH+wo4uNDaDrQKM52vHMFmc=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=l4P/2mr17zKPaWYyx5GSq1eSVeLV8zRyqumDkFneWk5sdHFJFLSJkE3R772/1WAQH 9EmdHqPsQb2nu/TQytziZuZiALAAEr03tUa3zPWF+DIkukOqdGn9n0LWtkvE3Jus5J y0/iHC9XounscuHTzaTXXUHh1ItIbzSfFXts0TR8= Date: Mon, 10 Aug 2020 16:34:42 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Julien Grall Subject: Re: [RFC PATCH V1 01/12] hvm/ioreq: Make x86's IOREQ feature common In-Reply-To: <598e2f35-e70e-36a7-1e5d-259ebb2e3cde@xen.org> Message-ID: References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-2-git-send-email-olekstysh@gmail.com> <000c01d66a33$2bd56510$83802f30$@xen.org> <9f83a7ed-ca97-449f-c7b9-a1140644abe9@gmail.com> <5df97055-67f9-16cc-a274-864672d67164@xen.org> <1afb9ffd-088c-ef4e-131a-0f2b62142405@xen.org> <598e2f35-e70e-36a7-1e5d-259ebb2e3cde@xen.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-2138485484-1597095280=:16004" Content-ID: X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: 'Kevin Tian' , Stefano Stabellini , 'Jun Nakajima' , 'Wei Liu' , paul@xen.org, 'Andrew Cooper' , 'Ian Jackson' , 'George Dunlap' , 'Tim Deegan' , Oleksandr , 'Oleksandr Tyshchenko' , 'Julien Grall' , 'Jan Beulich' , xen-devel@lists.xenproject.org, =?UTF-8?Q?'Roger_Pau_Monn=C3=A9'?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-2138485484-1597095280=:16004 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Mon, 10 Aug 2020, Julien Grall wrote: > On 07/08/2020 00:48, Stefano Stabellini wrote: > > On Thu, 6 Aug 2020, Julien Grall wrote: > > > On 06/08/2020 01:37, Stefano Stabellini wrote: > > > > On Wed, 5 Aug 2020, Julien Grall wrote: > > > > > On 04/08/2020 20:11, Stefano Stabellini wrote: > > > > > > On Tue, 4 Aug 2020, Julien Grall wrote: > > > > > > > On 04/08/2020 12:10, Oleksandr wrote: > > > > > > > > On 04.08.20 10:45, Paul Durrant wrote: > > > > > > > > > > +static inline bool hvm_ioreq_needs_completion(const ioreq_t > > > > > > > > > > *ioreq) > > > > > > > > > > +{ > > > > > > > > > > +    return ioreq->state == STATE_IOREQ_READY && > > > > > > > > > > +           !ioreq->data_is_ptr && > > > > > > > > > > +           (ioreq->type != IOREQ_TYPE_PIO || ioreq->dir != > > > > > > > > > > IOREQ_WRITE); > > > > > > > > > > +} > > > > > > > > > I don't think having this in common code is correct. The > > > > > > > > > short-cut > > > > > > > > > of > > > > > > > > > not > > > > > > > > > completing PIO reads seems somewhat x86 specific. > > > > > > > > > > > > > > Hmmm, looking at the code, I think it doesn't wait for PIO writes > > > > > > > to > > > > > > > complete > > > > > > > (not read). Did I miss anything? > > > > > > > > > > > > > > > Does ARM even > > > > > > > > > have the concept of PIO? > > > > > > > > > > > > > > > > I am not 100% sure here, but it seems that doesn't have. > > > > > > > > > > > > > > Technically, the PIOs exist on Arm, however they are accessed the > > > > > > > same > > > > > > > way > > > > > > > as > > > > > > > MMIO and will have a dedicated area defined by the HW. > > > > > > > > > > > > > > AFAICT, on Arm64, they are only used for PCI IO Bar. > > > > > > > > > > > > > > Now the question is whether we want to expose them to the Device > > > > > > > Emulator > > > > > > > as > > > > > > > PIO or MMIO access. From a generic PoV, a DM shouldn't have to > > > > > > > care > > > > > > > about > > > > > > > the > > > > > > > architecture used. It should just be able to request a given > > > > > > > IOport > > > > > > > region. > > > > > > > > > > > > > > So it may make sense to differentiate them in the common ioreq > > > > > > > code as > > > > > > > well. > > > > > > > > > > > > > > I had a quick look at QEMU and wasn't able to tell if PIOs and > > > > > > > MMIOs > > > > > > > address > > > > > > > space are different on Arm as well. Paul, Stefano, do you know > > > > > > > what > > > > > > > they > > > > > > > are > > > > > > > doing? > > > > > > > > > > > > On the QEMU side, it looks like PIO (address_space_io) is used in > > > > > > connection with the emulation of the "in" or "out" instructions, see > > > > > > ioport.c:cpu_inb for instance. Some parts of PCI on QEMU emulate PIO > > > > > > space regardless of the architecture, such as > > > > > > hw/pci/pci_bridge.c:pci_bridge_initfn. > > > > > > > > > > > > However, because there is no "in" and "out" on ARM, I don't think > > > > > > address_space_io can be accessed. Specifically, there is no > > > > > > equivalent > > > > > > for target/i386/misc_helper.c:helper_inb on ARM. > > > > > > > > > > So how PCI I/O BAR are accessed? Surely, they could be used on Arm, > > > > > right? > > > > > > > > PIO is also memory mapped on ARM and it seems to have its own MMIO > > > > address window. > > > This part is already well-understood :). However, this only tell us how an > > > OS > > > is accessing a PIO. > > > > > > What I am trying to figure out is how the hardware (or QEMU) is meant to > > > work. > > > > > > From my understanding, the MMIO access will be received by the hostbridge > > > and > > > then forwarded to the appropriate PCI device. The two questions I am > > > trying to > > > answer is: How the I/O BARs are configured? Will it contain an MMIO > > > address or > > > an offset? > > > > > > If the answer is the latter, then we will need PIO because a DM will never > > > see > > > the MMIO address (the hostbridge will be emulated in Xen). > > > > Now I understand the question :-) > > > > This is the way I understand it works. Let's say that the PIO aperture > > is 0x1000-0x2000 which is aliased to 0x3eff0000-0x3eff1000. > > 0x1000-0x2000 are addresses that cannot be accessed directly. > > 0x3eff0000-0x3eff1000 is the range that works. > > > > A PCI device PIO BAR will have an address in the 0x1000-0x2000 range, > > for instance 0x1100. > > > > However, when the operating system access 0x1100, it will issue a read > > to 0x3eff0100. > > > > Xen will trap the read to 0x3eff0100 and send it to QEMU. > > > > QEMU has to know that 0x3eff0000-0x3eff1000 is the alias to the PIO > > aperture and that 0x3eff0100 correspond to PCI device foobar. Similarly, > > QEMU has also to know the address range of the MMIO aperture and its > > remappings, if any (it is possible to have address remapping for MMIO > > addresses too.) > > > > I think today this information is "built-in" QEMU, not configurable. It > > works fine because *I think* the PCI aperture is pretty much the same on > > x86 boards, at least the one supported by QEMU for Xen. > > Well on x86, the OS will access PIO using inb/outb. So the address received by > Xen is 0x1000-0x2000 and then forwarded to the DM using the PIO type. > > > On ARM, I think we should explicitly declare the PCI MMIO aperture and > > its alias/address-remapping. When we do that, we can also declare the > > PIO aperture and its alias/address-remapping. > > Well yes, we need to define PCI MMIO and PCI I/O region because the guest OS > needs to know them. [1] (see below) > However, I am unsure how this would help us to solve the question whether > access to the PCI I/O aperture should be sent as a PIO or MMIO. > > Per what you wrote, the PCI I/O Bar would be configured with the range > 0x1000-0x2000. So a device emulator (this may not be QEMU and only emulate one > PCI device!!) will only see that range. > > How does the device-emulator then know that it needs to watch the region > 0x3eff0000-0x3eff1000? It would know because the PCI PIO aperture, together with the alias, are specified [1]. > It feels to me that it would be easier/make more sense if the DM only say "I > want to watch the PIO range 0x1000-0x2000". So Xen would be in charge to do > the translation between the OS view and the DM view. > > This also means a DM would be completely arch-agnostic. This would follow the > HW where you can plug your PCI card on any HW. As you know, PIO access is actually not modelled by QEMU for ARM targets. I worry about the long term stability of it, given that it is untested. I.e. qemu-system-aarch64 could have a broken PIO emulation and nobody would find out except for us when we send ioreqs to it. Thinking from a Xen/Emulator interface on ARM, is it wise to rely on an access-type that doesn't exist on the architecture? --8323329-2138485484-1597095280=:16004-- From xen-devel-bounces@lists.xenproject.org Mon Aug 10 23:38:09 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2020 23:38:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5HMl-0005Wm-EC; Mon, 10 Aug 2020 23:38:07 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5HMk-0005We-7Z for xen-devel@lists.xenproject.org; Mon, 10 Aug 2020 23:38:06 +0000 X-Inumbo-ID: c7d9d170-5779-4a52-b3ae-ca3b6cd2d477 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c7d9d170-5779-4a52-b3ae-ca3b6cd2d477; Mon, 10 Aug 2020 23:38:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=hF7cfDJfZMdDV5rdqkafaUX/KhSsh4IRWvfa8YaTULY=; b=6H5OXZ6+9wpKBvmOW3vTkEqNt fKs84dm5xylEmcRHsRODJjGqVOq1NUp2JUgPOfE2DN3cX28PcPebh6BhNL13fErosp8iBuEsAb06N 00ygOgghiOPcuq/+iNXnxVJOeEZCEHq8Z/Ma/pajeW7SV3ssBlEQ978QwdFPHLomjUf0c=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5HMh-0003Gw-MU; Mon, 10 Aug 2020 23:38:03 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k5HMh-0005DZ-93; Mon, 10 Aug 2020 23:38:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k5HMh-0003r3-87; Mon, 10 Aug 2020 23:38:03 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [seabios test] 152554: tolerable FAIL - PUSHED X-Osstest-Failures: seabios:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking seabios:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking seabios:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking seabios:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking seabios:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking seabios:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking seabios:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking X-Osstest-Versions-This: seabios=155821a1990b6de78dde5f98fa5ab90e802021e0 X-Osstest-Versions-That: seabios=d9c812dda519a1a73e8370e1b81ddf46eb22ed16 From: osstest service owner Date: Mon, 10 Aug 2020 23:38:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152554 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/152554/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail like 152267 test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 152267 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail like 152267 test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail like 152267 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass version targeted for testing: seabios 155821a1990b6de78dde5f98fa5ab90e802021e0 baseline version: seabios d9c812dda519a1a73e8370e1b81ddf46eb22ed16 Last test of basis 152267 2020-07-28 15:41:06 Z 13 days Testing same since 152554 2020-08-10 15:41:45 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Kevin O'Connor jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/seabios.git d9c812d..155821a 155821a1990b6de78dde5f98fa5ab90e802021e0 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Aug 11 06:13:57 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2020 06:13:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5NXP-0002PY-I1; Tue, 11 Aug 2020 06:13:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5NXO-0002PT-SM for xen-devel@lists.xenproject.org; Tue, 11 Aug 2020 06:13:30 +0000 X-Inumbo-ID: 7cf2b69f-81b8-460d-b50b-253db2ecb95d Received: from mail-lj1-x243.google.com (unknown [2a00:1450:4864:20::243]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7cf2b69f-81b8-460d-b50b-253db2ecb95d; Tue, 11 Aug 2020 06:13:29 +0000 (UTC) Received: by mail-lj1-x243.google.com with SMTP id t23so12216402ljc.3 for ; Mon, 10 Aug 2020 23:13:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=1Bzfmvk2BnHsFI3KruBg0hyGec2mKW3d8FB+a2+h33c=; b=R2V33lcpM/PdrQJeW4Rk47P+3MpfvhJqkVnIpRWDhin+V+ee+2w0T1W2IqiJdwSl/S xysgx2V2A/6tnF5U8icw/rmZMSvhV7n4x6olv8ZUTU//Xb6jT9sLhLx310JcQYQS3TO7 rBVvPFo2SI8UxyRMUeX6PtpDZD66fG4KrAI24ZZZuDjJ9D7xzUsuXxXCOwvz1Un86DTS XlRKGkw9XFyAD/HHgaTcDXQ11b0kZf6jsZ4hUn4coEEGKA5bp4MXmGkttCGxZDQnChOC XdIcL0/EEk6jpgKmD7Ye+gZasvOxmYPnIDGeIGnMgPvnL3ZCfRKWCKZ3lry0Klygk2+0 WudQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=1Bzfmvk2BnHsFI3KruBg0hyGec2mKW3d8FB+a2+h33c=; b=RMW2TidVGpaoEnzx8mABKakZcteZ+GdExy/8K4Of/X+RNOMNkjT1WnwwcuYLhJG3TI CUy9nSB6gfYSt3d7wBYW8ltYi4K6kWnol0deDqMfV4EPE9ZQ9IV/fQIx9xJqcgQMdJgM xdP9VwyUNmfzuX+hc/hbtZDTZCDS0wzpYnqCUQxizH9tYw8AEr5IbazvKkMQSRu4AGZp g9efFTI27BIbC5EsmMLhvvsPZMaDxYViFBydCjkgLbrtKkFIWLEpdZkYXdDJWOkidj0a S3ChqpOtMnQA6Tl5djjyPM4PWFhjp4wocbaQaTTBidpF9VT/xRm9ktBHyjZ4TtQGUo7d uMLw== X-Gm-Message-State: AOAM533ds56nK6/cwHi2IJJeCXY6Dc42jqL2++6El1UClY/3gC0kS0J3 LBYczzFxE2TDXu6ASDu0D4A= X-Google-Smtp-Source: ABdhPJy6CzmdlhEpECJL+V+fEk+co/1olpyqWacCcNMTbMg4vZ6Jz4V5DU5X6T55caK7vZgvc2zYIA== X-Received: by 2002:a2e:9284:: with SMTP id d4mr2233165ljh.64.1597126408116; Mon, 10 Aug 2020 23:13:28 -0700 (PDT) Received: from [192.168.1.2] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id t18sm11339511lfb.69.2020.08.10.23.13.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Aug 2020 23:13:27 -0700 (PDT) Subject: Re: [RFC PATCH V1 04/12] xen/arm: Introduce arch specific bits for IOREQ/DM features To: Julien Grall References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-5-git-send-email-olekstysh@gmail.com> <8e8a394c-bd2a-4444-9f4b-e022c59e0f81@xen.org> <659a5b45-a37a-5cf2-0bcd-ba1ea3d47cc4@xen.org> <48a130dc-57fd-0627-d188-ddff4abf6778@gmail.com> From: Oleksandr Message-ID: <5cf9c14c-3bac-ccbd-6586-1a540dbe9b8d@gmail.com> Date: Tue, 11 Aug 2020 09:13:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , Julien Grall , Jan Beulich , xen-devel , Daniel De Graaf , Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 11.08.20 01:37, Julien Grall wrote: Hi Julien > On Mon, 10 Aug 2020 at 21:29, Oleksandr wrote: >> >> On 10.08.20 22:00, Julien Grall wrote: >> >> Hi Julien >> >>>>>>> @@ -2275,6 +2282,16 @@ static void check_for_vcpu_work(void) >>>>>>> */ >>>>>>> void leave_hypervisor_to_guest(void) >>>>>>> { >>>>>>> +#ifdef CONFIG_IOREQ_SERVER >>>>>>> + /* >>>>>>> + * XXX: Check the return. Shall we call that in >>>>>>> + * continue_running and context_switch instead? >>>>>>> + * The benefits would be to avoid calling >>>>>>> + * handle_hvm_io_completion on every return. >>>>>>> + */ >>>>>> Yeah, that could be a simple and good optimization >>>>> Well, it is not simple as it is sounds :). >>>>> handle_hvm_io_completion() is the function in charge to mark the >>>>> vCPU as waiting for I/O. So we would at least need to split the >>>>> function. >>>>> >>>>> I wrote this TODO because I wasn't sure about the complexity of >>>>> handle_hvm_io_completion(current). Looking at it again, the main >>>>> complexity is the looping over the IOREQ servers. >>>>> >>>>> I think it would be better to optimize handle_hvm_io_completion() >>>>> rather than trying to hack the context_switch() or continue_running(). >>>> Well, is the idea in proposed dirty test patch below close to what >>>> you expect? Patch optimizes handle_hvm_io_completion() to avoid extra >>>> actions if vcpu's domain doesn't have ioreq_server, alternatively >>>> the check could be moved out of handle_hvm_io_completion() to avoid >>>> calling that function at all. >>> This looks ok to me. >>> >>>> BTW, TODO also suggests checking the return value of >>>> handle_hvm_io_completion(), but I am completely sure we can simply >>>> just return from leave_hypervisor_to_guest() at this point. Could you >>>> please share your opinion? >>> From my understanding, handle_hvm_io_completion() may return false if >>> there is pending I/O or a failure. >> It seems, yes >> >> >>> In the former case, I think we want to call handle_hvm_io_completion() >>> later on. Possibly after we call do_softirq(). >>> >>> I am wondering whether check_for_vcpu_work() could return whether >>> there are more work todo on the behalf of the vCPU. >>> >>> So we could have: >>> >>> do >>> { >>> check_for_pcpu_work(); >>> } while (check_for_vcpu_work()) >>> >>> The implementation of check_for_vcpu_work() would be: >>> >>> if ( !handle_hvm_io_completion() ) >>> return true; >>> >>> /* Rest of the existing code */ >>> >>> return false; >> Thank you, will give it a try. >> >> Can we behave the same way for both "pending I/O" and "failure" or we >> need to distinguish them? > We don't need to distinguish them. In both cases, we will want to > process softirqs. In all the failure cases, the domain will have > crashed. Therefore the vCPU will be unscheduled. Got it. >> Probably we need some sort of safe timeout/number attempts in order to >> not spin forever? > Well, anything based on timeout/number of attempts is flaky. How do > you know whether the I/O is just taking a "long time" to complete? > > But a vCPU shouldn't continue until an I/O has completed. This is > nothing very different than what a processor would do. > > In Xen case, if an I/O never completes then it most likely means that > something went horribly wrong with the Device Emulator. So it is most > likely not safe to continue. In HW, when there is a device failure, > the OS may receive an SError (this is implementation defined) and > could act accordingly if it is able to recognize the issue. > > It *might* be possible to send a virtual SError but there are a couple > of issues with it: > * How do you detect a failure? > * SErrors are implementations defined. You would need to teach > your OS (or the firmware) how to deal with them. > > I would expect quite a bit of effort in order to design and implement > it. For now, it is probably best to just let the vCPU spin forever. > > This wouldn't be an issue for Xen as do_softirq() would be called at > every loop.  Thank you for clarification. Fair enough and sounds reasonable. -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Tue Aug 11 07:25:00 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2020 07:25:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5OeH-0008Hv-33; Tue, 11 Aug 2020 07:24:41 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5OeF-0008Hq-Hn for xen-devel@lists.xenproject.org; Tue, 11 Aug 2020 07:24:39 +0000 X-Inumbo-ID: a5b9a2e0-5fb9-4ff1-bdaa-3bc02dbb7e30 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a5b9a2e0-5fb9-4ff1-bdaa-3bc02dbb7e30; Tue, 11 Aug 2020 07:24:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=2XS5GrrongWArctNr7GJHn/tQCCtUiMzbaC20MFPdqs=; b=Kpx4KILOaBgv9pCQHTN5R3O+/ aFup3ZufaYkH0HGF6/S039aDp53MsriumVd0PUaN6QooobtDjPP3DYki8xsDaw2DDaAMm+SAnTgg/ StAVy5fipNYVw24U2JRKxhZTUkhLUQwCPjlwaMy7poF85KZsbdKTgkaSc6Txww2m3sGEM=; Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5OeC-0002Yw-81; Tue, 11 Aug 2020 07:24:36 +0000 Received: from [172.16.144.3] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1k5OeB-00030x-Vj; Tue, 11 Aug 2020 07:24:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.89) (envelope-from ) id 1k5OeB-0007Uo-UQ; Tue, 11 Aug 2020 07:24:35 +0000 To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 152555: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking X-Osstest-Versions-This: xen=7a4dd361d10718608ad37f969df0a3cf5bc17b12 X-Osstest-Versions-That: xen=90c7eee53fcc0b48bd51aa3a7d1d0d9980ce1a7a From: osstest service owner Date: Tue, 11 Aug 2020 07:24:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flight 152555 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/152555/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail like 152548 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail like 152548 test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail like 152548 test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail like 152548 test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 152548 test-armhf-armhf-libvirt 14 saverestore-support-check fail like 152548 test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail like 152548 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail like 152548 test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail like 152548 test-amd64-i386-xl-pvshim 12 guest-start fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass version targeted for testing: xen 7a4dd361d10718608ad37f969df0a3cf5bc17b12 baseline version: xen 90c7eee53fcc0b48bd51aa3a7d1d0d9980ce1a7a Last test of basis 152548 2020-08-10 01:54:48 Z 1 days Testing same since 152555 2020-08-10 18:39:06 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 90c7eee53f..7a4dd361d1 7a4dd361d10718608ad37f969df0a3cf5bc17b12 -> master From xen-devel-bounces@lists.xenproject.org Tue Aug 11 07:42:20 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2020 07:42:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5OvE-0001b7-Ky; Tue, 11 Aug 2020 07:42:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5OvD-0001az-9U for xen-devel@lists.xenproject.org; Tue, 11 Aug 2020 07:42:11 +0000 X-Inumbo-ID: 74b323f7-1a81-4fc9-b82a-be93835b4198 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 74b323f7-1a81-4fc9-b82a-be93835b4198; Tue, 11 Aug 2020 07:42:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1597131731; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=WSu7s2Lf8kXyXplp0k91hWyufrO1ODj/KA72M7I4wVY=; b=HdacQdX+f9DGi/gi/qSx7qXct0bT68QtF6hGD3a/vQodKGjEWlkJ7yTA 36PaE91SPYyJqZShADgrzOAkTBEJOeu+s7XxXbE4zkVpK976aFdVecXdz xUlJqzmnItaELDPTbtX1Uq1xov7DISxgENVhjWGKcidSUvwPVOCXQazQO Q=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: yoNpL3MbJDz7hb1vtBl3wTTeyXOH6O/zGiqTmrR2DOgQGToQbJySWkPkyAZqLRUWCyZusn+Q9A ygOCIOyQW02WiZsB0gAwtgpa7/Q55p+KhUWjYF80MWiC+sUF85boFWDPKS+6Vz/XAxRo7aG0oh 9dvVVwvrrvQJKOVPXICqha/Tn3OaW3rgNGOpqtoZakJVWk2Xl0qK+TjixsFpA0UBa0gmOe13i3 ziO1db3lawOfnZy8w6Wy+puckM9RAXTk2l0Dx7UL7evRjb20/6JFY+LYvbhlE1QOKHgvsUNCPo 9h8= X-SBRS: 2.7 X-MesageID: 24235665 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,460,1589256000"; d="scan'208";a="24235665" Date: Tue, 11 Aug 2020 09:41:58 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Subject: Re: RESCHEDULED Call for agenda items for Community Call, August 13 @ 15:00 UTC Message-ID: <20200811074158.GA22095@Air-de-Roger> References: <1E023F6E-0E3C-4CD5-A074-7BF62635E123@citrix.com> <40615946-FF55-48DB-91FB-58DD603FDD69@citrix.com> <9bfef1bf-31a7-1c95-60fa-2ca665942fda@suse.com> <047B12C2-71AA-459F-853C-DF1CD040D6C1@citrix.com> <37d5e973-7645-d4eb-7bd6-f8d3226d7cb5@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" , George Dunlap Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Mon, Aug 03, 2020 at 03:18:08PM +0200, Jan Beulich wrote: > On 31.07.2020 14:35, Jan Beulich wrote: > > On 31.07.2020 14:27, George Dunlap wrote: > >>> On Jul 31, 2020, at 1:25 PM, Jan Beulich wrote: > >>> On 30.07.2020 17:41, George Dunlap wrote: > >>>>> On Jul 30, 2020, at 4:17 PM, George Dunlap wrote: > >>>>> > >>>>> Hey all, > >>>>> > >>>>> The community call is scheduled for next week, 6 August. I, however, will be on PTO that week; I propose rescheduling it for the following week, 13 August, at the same time. > >>>>> > >>>>> The proposed agenda is in ZZZ and you can edit to add items. Alternatively, you can reply to this mail directly. > >>>> > >>>> Sorry, in all my manual templating I seem to have missed this one. Here’s the URL: > >>>> > >>>> https://cryptpad.fr/pad/#/3/pad/edit/9c58993a08fe97451f0a5b6c8bb906b1/ > >>> > >>> I get "This link does not give you access to the document". Maybe a > >>> permissions problem? I've meant to add a "minimum toolchain versions" > >>> topic ... > >> > >> Try this one? > >> > >> https://cryptpad.fr/pad/#/2/pad/edit/VlLdjiw7iBm0R-efOMyCY+Ks/ > > > > Ah yes, this one works. Thanks. > > And over the weekend I realized that the week of the 13th I'm going to be > on PTO, so very likely won't be able to make the call. Not sure what to > suggest you do with the topic ... Maybe we can postpone to the next call? I think you have strong opinions on the topic, so it won't seem fair to have the discussion without you present. Roger. From xen-devel-bounces@lists.xenproject.org Tue Aug 11 08:02:15 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2020 08:02:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5PEX-0003tZ-3X; Tue, 11 Aug 2020 08:02:09 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5PEV-0003tU-Lt for xen-devel@lists.xenproject.org; Tue, 11 Aug 2020 08:02:07 +0000 X-Inumbo-ID: 453e3899-8766-4964-9a98-ad2a79907b3f Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 453e3899-8766-4964-9a98-ad2a79907b3f; Tue, 11 Aug 2020 08:02:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date: Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=TkZYeQpgUd1FHivM4BUwJruERlVtCbxqKit7za38K4g=; b=1mKHLl9jkpGw4pWY8y+LeIhSGW K+P0ujz0Kmyf1mgUg1U/H1wFFJ34f7AuN0lWFDDAEuWX9oKq7sYy/t1iY+dSEKTTp4yhApKfYmjdP cC1YQ7bpWqZXd/hLNrrbytAVLpMWHfVr5/CiclgmPy8ZHIBmN8ywTbF36+ZeV8hdlyl8=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5PET-0003uU-Vr; Tue, 11 Aug 2020 08:02:05 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5PET-0000k5-LC; Tue, 11 Aug 2020 08:02:05 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v3 0/8] tools: propogate MTU to vif frontends Date: Tue, 11 Aug 2020 09:01:54 +0100 Message-Id: <20200811080202.31163-1-paul@xen.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Paul Durrant , Ian Jackson , George Dunlap , Jan Beulich , Anthony PERARD Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant This is an expansion from v2 of the series to include the facility to set the MTU in the vif config. There is also one cleanup patch to remove the defunct 'vif2' script. Paul Durrant (8): public/io/netif: specify MTU override node tools/hotplug/Linux: re-factor add_to_bridge() in xen-network-common.sh tools/hotplug/Linux: add remove_from_bridge() tools/hotplug/Linux: remove code duplication in vif-bridge libxl: wire the libxl_device_nic 'mtu' value into xenstore tools/hotplug/Linux: modify set_mtu() to optionally use a configured value... xl: add 'mtu' option to network configuration remove netchannel2 hotplug script... ancient history docs/man/xl-network-configuration.5.pod | 6 +++ docs/misc/xenstore-paths.pandoc | 3 ++ tools/hotplug/Linux/Makefile | 1 - tools/hotplug/Linux/vif-bridge | 20 +++---- tools/hotplug/Linux/vif2 | 54 ------------------- tools/hotplug/Linux/xen-network-common.sh | 65 +++++++++++++++++++---- tools/libxl/libxl_nic.c | 27 +++++++++- tools/xl/xl_cmdtable.c | 2 +- tools/xl/xl_parse.c | 2 + xen/include/public/io/netif.h | 12 +++++ 10 files changed, 110 insertions(+), 82 deletions(-) delete mode 100644 tools/hotplug/Linux/vif2 --- Cc: Andrew Cooper Cc: Anthony PERARD Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich Cc: Julien Grall Cc: Stefano Stabellini Cc: Wei Liu -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 11 08:02:15 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2020 08:02:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5PEY-0003tk-C1; Tue, 11 Aug 2020 08:02:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5PEX-0003tc-7o for xen-devel@lists.xenproject.org; Tue, 11 Aug 2020 08:02:09 +0000 X-Inumbo-ID: 24a6a5c4-9476-4a0d-bc69-354df03b0b8f Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 24a6a5c4-9476-4a0d-bc69-354df03b0b8f; Tue, 11 Aug 2020 08:02:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zLawH4FvOFWl21OKR3+ucyTpJY4mEJwrzwh5lh6ZTTM=; b=3zpUIDAnftjjPCSyjPccOSSNuY N7FS8KaWcFTUtzNJGrDqUyyZsCNVcP+qON9Ez4E01DcQMgcpZp+V8Adk75AkUFSG9y1gPmjRhPkzx ysZj/AHAueajNN/YwscPZxvGDbfYMbqVvip5iPfnGDQI9UKza8vfjcVymSLfvQhXUQEo=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5PEV-0003uZ-Cm; Tue, 11 Aug 2020 08:02:07 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5PEV-0000k5-4z; Tue, 11 Aug 2020 08:02:07 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v3 1/8] public/io/netif: specify MTU override node Date: Tue, 11 Aug 2020 09:01:55 +0100 Message-Id: <20200811080202.31163-2-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200811080202.31163-1-paul@xen.org> References: <20200811080202.31163-1-paul@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Paul Durrant , Ian Jackson , George Dunlap , Jan Beulich Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant There is currently no documentation to state what MTU a frontend should adertise to its network stack. It has however long been assumed that the default value of 1500 is correct. This patch specifies a mechanism to allow the tools to set the MTU via a xenstore node in the frontend area and states that the absence of that node means the frontend should assume an MTU of 1500 octets. NOTE: The Windows PV frontend has used an MTU sampled from the xenstore node specified in this patch. Signed-off-by: Paul Durrant Reviewed-by: Juergen Gross Reviewed-by: Ian Jackson --- Cc: Andrew Cooper Cc: George Dunlap Cc: Jan Beulich Cc: Julien Grall Cc: Stefano Stabellini Cc: Wei Liu v2: - Add a note in xenstore-paths highlighting the new xenstore node --- docs/misc/xenstore-paths.pandoc | 3 +++ xen/include/public/io/netif.h | 12 ++++++++++++ 2 files changed, 15 insertions(+) diff --git a/docs/misc/xenstore-paths.pandoc b/docs/misc/xenstore-paths.pandoc index 766e8008dc..5cd5c8a3b9 100644 --- a/docs/misc/xenstore-paths.pandoc +++ b/docs/misc/xenstore-paths.pandoc @@ -298,6 +298,9 @@ A virtual keyboard device frontend. Described by A virtual network device frontend. Described by [xen/include/public/io/netif.h][NETIF] +NOTE: ~/device/vif/$DEVID/mtu can be used to inform the frontend of an + increased MTU. (The default MTU is 1500 octets). + #### ~/device/vscsi/$DEVID/* [] A virtual scsi device frontend. Described by diff --git a/xen/include/public/io/netif.h b/xen/include/public/io/netif.h index 9fcf91a2fe..00dd258712 100644 --- a/xen/include/public/io/netif.h +++ b/xen/include/public/io/netif.h @@ -204,6 +204,18 @@ * present). */ +/* + * MTU + * === + * + * The toolstack may set a value of MTU for the frontend by setting the + * /local/domain//device/vif//mtu node with the MTU value in + * octets. If this node is absent the frontend should assume an MTU value + * of 1500 octets. A frontend is also at liberty to ignore this value so + * it is only suitable for informing the frontend that a packet payload + * >1500 octets is permitted. + */ + /* * Hash types * ========== -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 11 08:02:15 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2020 08:02:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5PEb-0003u7-Kr; Tue, 11 Aug 2020 08:02:13 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5PEa-0003tU-GL for xen-devel@lists.xenproject.org; Tue, 11 Aug 2020 08:02:12 +0000 X-Inumbo-ID: 6418cc07-9d07-4265-8172-d0cc86b34d7d Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6418cc07-9d07-4265-8172-d0cc86b34d7d; Tue, 11 Aug 2020 08:02:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dBwj4wik0LPt/hwNL21RAdLL6al/lz/Xx5lYUZ+jc9M=; b=SnQBnfDbIVzQJeMl9esibza4Tb 2zXxpNeILmFRRXctbbGuVsUA1122jmLVnNpPhHI1wFHOH70yfLetzl9llb0QIeuzpnipXWosh5KB1 lZBBydwF8s1uqxxXQ1QPVbyFZkztDSz+D/Y7A+Q5b44NyTIHhZrIRPa6iTfcSQh3F4dA=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5PEW-0003ud-9F; Tue, 11 Aug 2020 08:02:08 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5PEW-0000k5-1k; Tue, 11 Aug 2020 08:02:08 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v3 2/8] tools/hotplug/Linux: re-factor add_to_bridge() in xen-network-common.sh Date: Tue, 11 Aug 2020 09:01:56 +0100 Message-Id: <20200811080202.31163-3-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200811080202.31163-1-paul@xen.org> References: <20200811080202.31163-1-paul@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Paul Durrant , Ian Jackson , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant Remove duplication of 'ip link set dev'. It is perfectly fine to call it even if the device has already been added to the bridge. NOTE: This patch also adds code to write a debug log entry if the device was already on the bridge. Signed-off-by: Paul Durrant --- Cc: Ian Jackson Cc: Wei Liu v3: - Re-factored from "tools/hotplug: add remove_from_bridge() and improve debug output" in v2 --- tools/hotplug/Linux/xen-network-common.sh | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/tools/hotplug/Linux/xen-network-common.sh b/tools/hotplug/Linux/xen-network-common.sh index 8dd3a62068..ec3bd4ec4a 100644 --- a/tools/hotplug/Linux/xen-network-common.sh +++ b/tools/hotplug/Linux/xen-network-common.sh @@ -126,16 +126,18 @@ add_to_bridge () { local bridge=$1 local dev=$2 - # Don't add $dev to $bridge if it's already on a bridge. - if [ -e "/sys/class/net/${bridge}/brif/${dev}" ]; then - ip link set dev ${dev} up || true - return - fi - if which brctl >&/dev/null; then - brctl addif ${bridge} ${dev} + # Don't add $dev to $bridge if it's already on the bridge. + if [ ! -e "/sys/class/net/${bridge}/brif/${dev}" ]; then + log debug "adding $dev to bridge $bridge" + if which brctl >&/dev/null; then + brctl addif ${bridge} ${dev} + else + ip link set ${dev} master ${bridge} + fi else - ip link set ${dev} master ${bridge} + log debug "$dev already on bridge $bridge" fi + ip link set dev ${dev} up } -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 11 08:02:16 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2020 08:02:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5PEd-0003v7-US; Tue, 11 Aug 2020 08:02:15 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5PEc-0003tc-5m for xen-devel@lists.xenproject.org; Tue, 11 Aug 2020 08:02:14 +0000 X-Inumbo-ID: 53e06020-7d57-44ed-b070-05e1453e4c9f Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 53e06020-7d57-44ed-b070-05e1453e4c9f; Tue, 11 Aug 2020 08:02:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eSmprS1bsesB0cQvNRI38Z139gI/ZjEmaiUVzzjZXv4=; b=S5x8KVbrxbU9txM7PfsxBvEg8M DtAJMTFQUnLErPOfvE3R48IX7bhErJxl2xNZGUF1cHx86gsUajNc91q7eoxOkfKJxD4LvRXD0zK9W DCitwEVJzOreK/ov6feZIwaKrt6nbBH51/ag+nF66bJEEny1RUMCC596PW+GCRBi/Rts=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5PEX-0003un-6K; Tue, 11 Aug 2020 08:02:09 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5PEW-0000k5-Ul; Tue, 11 Aug 2020 08:02:09 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v3 3/8] tools/hotplug/Linux: add remove_from_bridge() Date: Tue, 11 Aug 2020 09:01:57 +0100 Message-Id: <20200811080202.31163-4-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200811080202.31163-1-paul@xen.org> References: <20200811080202.31163-1-paul@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Paul Durrant , Ian Jackson , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant This patch adds a remove_from_bridge() function into xen-network-common.sh to partner with the existing add_to_bridge() function. The vif-bridge script is then modified to use it. Signed-off-by: Paul Durrant --- Cc: Ian Jackson Cc: Wei Liu v3: - Re-factored from "tools/hotplug: add remove_from_bridge() and improve debug output" and "tools/hotplug: combine add/online and remove/offline in vif-bridge..." in v2 --- tools/hotplug/Linux/vif-bridge | 7 +------ tools/hotplug/Linux/xen-network-common.sh | 19 +++++++++++++++++++ 2 files changed, 20 insertions(+), 6 deletions(-) diff --git a/tools/hotplug/Linux/vif-bridge b/tools/hotplug/Linux/vif-bridge index e722090ca8..c3e409926d 100644 --- a/tools/hotplug/Linux/vif-bridge +++ b/tools/hotplug/Linux/vif-bridge @@ -84,12 +84,7 @@ case "$command" in ;; offline) - if which brctl >&/dev/null; then - do_without_error brctl delif "$bridge" "$dev" - else - do_without_error ip link set "$dev" nomaster - fi - do_without_error ifconfig "$dev" down + remove_from_bridge "$bridge" "$dev" ;; add) diff --git a/tools/hotplug/Linux/xen-network-common.sh b/tools/hotplug/Linux/xen-network-common.sh index ec3bd4ec4a..6a0904361f 100644 --- a/tools/hotplug/Linux/xen-network-common.sh +++ b/tools/hotplug/Linux/xen-network-common.sh @@ -141,6 +141,25 @@ add_to_bridge () { ip link set dev ${dev} up } +remove_from_bridge () { + local bridge=$1 + local dev=$2 + + do_without_error ip link set dev ${dev} down + + # Don't remove $dev from $bridge if it's not on the bridge. + if [ -e "/sys/class/net/${bridge}/brif/${dev}" ]; then + log debug "removing $dev from bridge $bridge" + if which brctl >&/dev/null; then + do_without_error brctl delif ${bridge} ${dev} + else + do_without_error ip link set ${dev} nomaster + fi + else + log debug "$dev not on bridge $bridge" + fi +} + # Usage: set_mtu bridge dev set_mtu () { local bridge=$1 -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 11 08:02:19 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2020 08:02:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5PEh-0003wd-Jz; Tue, 11 Aug 2020 08:02:19 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5PEh-0003tc-5u for xen-devel@lists.xenproject.org; Tue, 11 Aug 2020 08:02:19 +0000 X-Inumbo-ID: 279b2850-dbf8-4292-a5a9-cbb1fd60efac Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 279b2850-dbf8-4292-a5a9-cbb1fd60efac; Tue, 11 Aug 2020 08:02:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Nc+eSdOT6VBsLMIDsh/OIxsUOynady1C/hs/XmoSJsg=; b=2cn19lo+wmOmZDpc4P0MKJGxov bONXxTcc9LuTfH49j8h0a5q+86wboVKstcJWhcboTMY8M+v27UMiogjDlgmMs04eczkO9ACY0a+fd zDknOW29XkrHlrGikVLMIdXB8q2Slt7n9R0B80AtDnH4Wo9VliR9glieboA5wuGCILsI=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5PEZ-0003vT-3O; Tue, 11 Aug 2020 08:02:11 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5PEY-0000k5-RX; Tue, 11 Aug 2020 08:02:11 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v3 5/8] libxl: wire the libxl_device_nic 'mtu' value into xenstore Date: Tue, 11 Aug 2020 09:01:59 +0100 Message-Id: <20200811080202.31163-6-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200811080202.31163-1-paul@xen.org> References: <20200811080202.31163-1-paul@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony PERARD , Paul Durrant , Ian Jackson , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant Currently the 'mtu' field of libxl_device_nic objects is effectively ignored: It is set by libxl__device_nic_setdefault() to a slightly odd default value of 1492 but otherwise ignored. This patch changes the default value to a more conventional 1500 and modifies libxl__set_xenstore_nic() to write the value into an 'mtu' node in the xenstore backend area (if it is a non-default value), as well as a read-only node of the same name in the frontend area. The backend node is used to set the value of 'mtu' in libxl__nic_from_xenstore(), when retrieving the configuration. NOTE: There is currently no way to set a non-default value of 'mtu', hence the backend node is never written. This, however, will be addressed by a subsequent patch. Signed-off-by: Paul Durrant --- Cc: Ian Jackson Cc: Wei Liu Cc: Anthony PERARD v3: - New in v3 --- tools/libxl/libxl_nic.c | 27 +++++++++++++++++++++++++-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl_nic.c b/tools/libxl/libxl_nic.c index 07880b39e1..0e5d120ae9 100644 --- a/tools/libxl/libxl_nic.c +++ b/tools/libxl/libxl_nic.c @@ -53,13 +53,15 @@ int libxl_mac_to_device_nic(libxl_ctx *ctx, uint32_t domid, return rc; } +#define LIBXL_DEVICE_NIC_MTU_DEFAULT 1500 + static int libxl__device_nic_setdefault(libxl__gc *gc, uint32_t domid, libxl_device_nic *nic, bool hotplug) { int rc; if (!nic->mtu) - nic->mtu = 1492; + nic->mtu = LIBXL_DEVICE_NIC_MTU_DEFAULT; if (!nic->model) { nic->model = strdup("rtl8139"); if (!nic->model) return ERROR_NOMEM; @@ -223,6 +225,11 @@ static int libxl__set_xenstore_nic(libxl__gc *gc, uint32_t domid, nic->rate_interval_usecs)); } + if (nic->mtu != LIBXL_DEVICE_NIC_MTU_DEFAULT) { + flexarray_append(back, "mtu"); + flexarray_append(back, GCSPRINTF("%u", nic->mtu)); + } + flexarray_append(back, "bridge"); flexarray_append(back, libxl__strdup(gc, nic->bridge)); flexarray_append(back, "handle"); @@ -237,6 +244,9 @@ static int libxl__set_xenstore_nic(libxl__gc *gc, uint32_t domid, flexarray_append(front, GCSPRINTF( LIBXL_MAC_FMT, LIBXL_MAC_BYTES(nic->mac))); + flexarray_append(ro_front, "mtu"); + flexarray_append(ro_front, GCSPRINTF("%u", nic->mtu)); + return 0; } @@ -275,7 +285,20 @@ static int libxl__nic_from_xenstore(libxl__gc *gc, const char *libxl_path, rc = libxl__backendpath_parse_domid(gc, tmp, &nic->backend_domid); if (rc) goto out; - /* nic->mtu = */ + rc = libxl__xs_read_checked(gc, XBT_NULL, + GCSPRINTF("%s/mtu", libxl_path), &tmp); + if (rc) goto out; + if (tmp) { + char *endptr; + + nic->mtu = strtol(tmp, &endptr, 10); + if (*endptr != '\0') { + rc = ERROR_INVAL; + goto out; + } + } else { + nic->mtu = LIBXL_DEVICE_NIC_MTU_DEFAULT; + } rc = libxl__xs_read_checked(gc, XBT_NULL, GCSPRINTF("%s/mac", libxl_path), &tmp); -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 11 08:02:19 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2020 08:02:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5PEh-0003wN-8T; Tue, 11 Aug 2020 08:02:19 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5PEf-0003tU-GT for xen-devel@lists.xenproject.org; Tue, 11 Aug 2020 08:02:17 +0000 X-Inumbo-ID: 6a799ae5-b692-48b2-8791-240e05f53c63 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6a799ae5-b692-48b2-8791-240e05f53c63; Tue, 11 Aug 2020 08:02:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=aHjZE/ipDyZpIQn2BBAjOYE1vFoNpiNeV+OmHeWemBA=; b=gOto8wyhSFIt+KkuFzEr1CEguq hexDYyKMppmfnbBmJ6NEW007SqlYPp1CV5QQkqQ2FOdjCWToC8EH17EM7EO2D/fFDnAXgHUqydWBT yvpFwCA07dGpA7RwQY7mFWLvuScZAu4Pldj+Pt8dPOBTNNOUn021M8YqPEMveegpH974=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5PEY-0003vL-2m; Tue, 11 Aug 2020 08:02:10 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5PEX-0000k5-RY; Tue, 11 Aug 2020 08:02:10 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v3 4/8] tools/hotplug/Linux: remove code duplication in vif-bridge Date: Tue, 11 Aug 2020 09:01:58 +0100 Message-Id: <20200811080202.31163-5-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200811080202.31163-1-paul@xen.org> References: <20200811080202.31163-1-paul@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Paul Durrant , Ian Jackson , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant The 'add' and 'online' cases do exactly the same thing so have 'add' simply fall through to 'online'. NOTE: This patch also adds in the missing 'remove' case, which falls though to 'offline'. (The former is passed for 'tap' devices, the latter for 'vif' devices). Signed-off-by: Paul Durrant --- Cc: Ian Jackson Cc: Wei Liu v3: - Re-factored from "tools/hotplug: combine add/online and remove/offline in vif-bridge..." in v2 --- tools/hotplug/Linux/vif-bridge | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/tools/hotplug/Linux/vif-bridge b/tools/hotplug/Linux/vif-bridge index c3e409926d..e1d7c49788 100644 --- a/tools/hotplug/Linux/vif-bridge +++ b/tools/hotplug/Linux/vif-bridge @@ -77,21 +77,18 @@ then fi case "$command" in + add) + ;& online) setup_virtual_bridge_port "$dev" set_mtu "$bridge" "$dev" add_to_bridge "$bridge" "$dev" ;; - + remove) + ;& offline) remove_from_bridge "$bridge" "$dev" ;; - - add) - setup_virtual_bridge_port "$dev" - set_mtu "$bridge" "$dev" - add_to_bridge "$bridge" "$dev" - ;; esac handle_iptable -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 11 08:02:24 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2020 08:02:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5PEl-0003z2-Tf; Tue, 11 Aug 2020 08:02:23 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5PEk-0003tU-GV for xen-devel@lists.xenproject.org; Tue, 11 Aug 2020 08:02:22 +0000 X-Inumbo-ID: 7bbe9025-e812-45b0-b51a-67c5798dabd1 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7bbe9025-e812-45b0-b51a-67c5798dabd1; Tue, 11 Aug 2020 08:02:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eU2vamnIGUwArjo4gv27KRnIl7mjwar3lCX+4HlpkTs=; b=IHHTk0PSAlI3aK6j7O/v1M0f7T Qrd8nAFXETWG5HZmCtUN9iHr1iZM4lF/1rHhcxdLcl47BKekJzk2PuqfBEVDrDVhnTsKrj63QfQec Oqu3ZcrRVXjDHZl3Jd6UXxq9ySUtQOf0gwRis6Q3onGZKr+T5lmlj/f1Ys45ZwN2w0fI=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5PEa-0003vY-0Z; Tue, 11 Aug 2020 08:02:12 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5PEZ-0000k5-OL; Tue, 11 Aug 2020 08:02:11 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v3 6/8] tools/hotplug/Linux: modify set_mtu() to optionally use a configured value... Date: Tue, 11 Aug 2020 09:02:00 +0100 Message-Id: <20200811080202.31163-7-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200811080202.31163-1-paul@xen.org> References: <20200811080202.31163-1-paul@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Paul Durrant , Ian Jackson , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant ...and also inform the frontend. The set_mtu() function in xen-network-common.sh currently sets the backend vif MTU to match that of the bridge. A prior patch added code into libxl such that a tools-configured 'mtu' value may be present in the xenstore backend area. If the node is present in xenstore then it should be authoritative. Hence set_mtu() is modified to only read the MTU of the bridge if it is not present. The function is also modified to write whatever value it applies to the backend vif into the xenstore frontend area where is may then be used to configure the frontend network stack. NOTE: There is also a small modification replacing '$mtu' with '${mtu}' for style consistency. Signed-off-by: Paul Durrant --- Cc: Ian Jackson Cc: Wei Liu v3: - Re-factored from "tools/hotplug: modify set_mtu() to inform the frontend via xenstore" in v2 --- tools/hotplug/Linux/vif-bridge | 2 +- tools/hotplug/Linux/xen-network-common.sh | 28 +++++++++++++++++++++-- 2 files changed, 27 insertions(+), 3 deletions(-) diff --git a/tools/hotplug/Linux/vif-bridge b/tools/hotplug/Linux/vif-bridge index e1d7c49788..b99cc82a21 100644 --- a/tools/hotplug/Linux/vif-bridge +++ b/tools/hotplug/Linux/vif-bridge @@ -81,7 +81,7 @@ case "$command" in ;& online) setup_virtual_bridge_port "$dev" - set_mtu "$bridge" "$dev" + set_mtu "$bridge" "$dev" "$type_if" add_to_bridge "$bridge" "$dev" ;; remove) diff --git a/tools/hotplug/Linux/xen-network-common.sh b/tools/hotplug/Linux/xen-network-common.sh index 6a0904361f..82ee70aab4 100644 --- a/tools/hotplug/Linux/xen-network-common.sh +++ b/tools/hotplug/Linux/xen-network-common.sh @@ -164,9 +164,33 @@ remove_from_bridge () { set_mtu () { local bridge=$1 local dev=$2 - mtu="`ip link show dev ${bridge}| awk '/mtu/ { print $5 }'`" + local type_if=$3 + + XENBUS_PATH="${XENBUS_PATH:?}" + + local mtu=$(xenstore_read_default "$XENBUS_PATH/mtu" "") + if [ -z "$mtu" ] + then + mtu="`ip link show dev ${bridge}| awk '/mtu/ { print $5 }'`" + if [ -n "$mtu" ] + then + log debug "$bridge MTU is $mtu" + fi + fi if [ -n "$mtu" ] && [ "$mtu" -gt 0 ] then - ip link set dev ${dev} mtu $mtu || : + log debug "setting $dev MTU to $mtu" + ip link set dev ${dev} mtu ${mtu} || : + + if [ ${type_if} = vif ] + then + local dev_=${dev#vif} + local domid=${dev_%.*} + local devid=${dev_#*.} + + local FRONTEND_PATH="/local/domain/$domid/device/vif/$devid" + + xenstore_write "$FRONTEND_PATH/mtu" ${mtu} + fi fi } -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 11 08:02:29 2020 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2020 08:02:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5PEr-00042i-B0; Tue, 11 Aug 2020 08:02:29 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5PEp-0003tU-Ge for xen-devel@lists.xenproject.org; Tue, 11 Aug 2020 08:02:27 +0000 X-Inumbo-ID: 764ba1c8-d299-41f0-8d8c-eee0084d7b95 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 764ba1c8-d299-41f0-8d8c-eee0084d7b95; Tue, 11 Aug 2020 08:02:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=CMw0RcWu/LXhzXxdRQOMwsBd24sui0EzlfPHLuiHcFQ=; b=JZGxjTOiGRxLxYjyguj/5ZR1+5 kviMy5oF4IkRlmX/4+uf5IQTay4PNOlAmiZIOuyCGXn1FxCkZTKwBbfwLEYnWl0Qfa4f2NGzqrCn+ XsP/G3/4GtMWcn6httDpaOgdoWqxQ6qvtchnbwlxEf+Zwe7xCGhBF1h/+HBgz5h1pIqM=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k5PEa-0003vg-Vd; Tue, 11 Aug 2020 08:02:12 +0000 Received: from host86-143-223-30.range86-143.btcentralplus.com ([86.143.223.30] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5PEa-0000k5-OI; Tue, 11 Aug 2020 08:02:12 +0000 From: Paul Durrant To: xen-devel@lists.xenproject.org Subject: [PATCH v3 7/8] xl: add 'mtu' option to network configuration Date: Tue, 11 Aug 2020 09:02:01 +0100 Message-Id: <20200811080202.31163-8-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200811080202.31163-1-paul@xen.org> References: <20200811080202.31163-1-paul@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony PERARD , Paul Durrant , Ian Jackson , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant This patch adds code to parse a value for MTU from the network configuration if it is present. The documentation in xl-network-configuration.5.pod is also modified accordingly. Signed-off-by: Paul Durrant --- Cc: Ian Jackson Cc: Wei Liu Cc: Anthony PERARD v3: - New in v3 --- docs/man/xl-network-configuration.5.pod | 6 ++++++ tools/xl/xl_cmdtable.c | 2 +- tools/xl/xl_parse.c | 2 ++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/docs/man/xl-network-configuration.5.pod b/docs/man/xl-network-configuration.5.pod index 0ac24c4a18..af058d4d3c 100644 --- a/docs/man/xl-network-configuration.5.pod +++ b/docs/man/xl-network-configuration.5.pod @@ -249,3 +249,9 @@ on the underlying netback implementation. Specifies the devid manually instead of letting xl choose the lowest index available. NOTE: This should not be set unless you have a reason to. + +=head2 mtu + +Specifies the MTU (i.e. the maximum size of an IP payload, exclusing headers). The +default value is 1500 but, if the VIF is attached to a bridge, it will be set to match +unless overridden by this parameter. diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c index 08335394e5..2b8e1b321a 100644 --- a/tools/xl/xl_cmdtable.c +++ b/tools/xl/xl_cmdtable.c @@ -338,7 +338,7 @@ struct cmd_spec cmd_table[] = { "Create a new virtual network device", " [type=] [mac=] [bridge=] " "[ip=] [script=