From xen-devel-bounces@lists.xenproject.org Thu Apr 01 01:07:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 01:07:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104091.198680 (Exim 4.92) (envelope-from ) id 1lRlnE-0006bo-MZ; Thu, 01 Apr 2021 01:06:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104091.198680; Thu, 01 Apr 2021 01:06:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRlnE-0006bh-JU; Thu, 01 Apr 2021 01:06:40 +0000 Received: by outflank-mailman (input) for mailman id 104091; Thu, 01 Apr 2021 01:06:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRlnD-0006bc-ON for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 01:06:39 +0000 Received: from mail-qt1-x82d.google.com (unknown [2607:f8b0:4864:20::82d]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 57233a77-0717-43da-8c2d-705c60856b16; Thu, 01 Apr 2021 01:06:37 +0000 (UTC) Received: by mail-qt1-x82d.google.com with SMTP id g24so393038qts.6 for ; Wed, 31 Mar 2021 18:06:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57233a77-0717-43da-8c2d-705c60856b16 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zededa.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=I4XnTBqWaNHfJM0uifctrfC1GtW1564zJxX4MuGrMVI=; b=j4JCaWgTgHeE9hNCyf3zLgLl3NZvmOoLiw4Ep/EC6ix7jX0/TAzMjB+byX+ZGjleg1 tlNWElFHsnba0WSpmSvZVrmBUBLfaeYKGv3Mc8ilJN6xtyu/5Jt9XvWQbvt0PXJpvx95 jYOogg0fpdsx6ZmBvcrEa70SERHP4L6GMG4AQZm3ejWOFjLPGEy9gTUj76prrx6RccTT a14OEn6o3qJwbyRWZT5BJw5TUimbm3lXCtkhpPKCKJeEGZCB9w/T8Qp+ybP9yht/6RBD B4DlodB28DAGjJVdFlWDy4P57Yb3RaWiE+gTVk08iOh92euQ/XYTWh8wKOGJHUsDQkId rBlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I4XnTBqWaNHfJM0uifctrfC1GtW1564zJxX4MuGrMVI=; b=FQJKh2Jo0ko1zJ1u6uFXxvNEzUni9WXk/R8JfpQOrzFcNu715evzZZGE6ZnPRHuuUB uBbQf/kHnmggYuhCc7ZETLYxrQrb54XtKYWHsDD0UW4sohuzNxAKC94bu7zjC7oFpk1f VFbdslzAot2qQmdnBflRNYPD8HRAp+WzRQrOKzOaHj2jbMzUEstPaaPBDfjDv78zhYCX xYA9yoSBMME2yhCcHkCPIesDEjlJDM4bo3BdVAk8OydmhfaLJ59Z4KiykwPYMljYhhlM LAnp0iAgl1K92eUUhaG6mBzhzOmZEhYhiBMO3+QfxaO6DaJqYkLnDtm9rZZ6YJ/4MwXN BJpA== X-Gm-Message-State: AOAM532RuWtGjI4URlBunrU3fRDkwVG8NVMTQwT/M1vvGgoZdLo7/Trb eGCSHjVTlICmvhKbHCh+Sfp28hadt1WS4KrxWjJQhA== X-Google-Smtp-Source: ABdhPJwGa4irE89lKL5j7+qT7fRWuH62QG8dMMrr/BtnompBjfBQ5fQ3cVmy8GlUz5hnj8n23BMFDOCaDyC0diXaLjY= X-Received: by 2002:ac8:1093:: with SMTP id a19mr5064689qtj.365.1617239197376; Wed, 31 Mar 2021 18:06:37 -0700 (PDT) MIME-Version: 1.0 References: <23baec07-a3ae-949a-a1fb-09100efd53e5@citrix.com> In-Reply-To: <23baec07-a3ae-949a-a1fb-09100efd53e5@citrix.com> From: Roman Shaposhnik Date: Wed, 31 Mar 2021 18:06:31 -0700 Message-ID: Subject: Re: multiboot2 and module2 boot issues via GRUB2 To: Andrew Cooper Cc: Xen-devel , grub-devel@gnu.org Content-Type: multipart/alternative; boundary="000000000000e0809d05beded750" --000000000000e0809d05beded750 Content-Type: text/plain; charset="UTF-8" Hi Andrew! first of all -- thanks for pointing me in the right direction. So after reading relevant sources: comments inline. On Tue, Mar 30, 2021 at 12:08 PM Andrew Cooper wrote: > On 30/03/2021 19:28, Roman Shaposhnik wrote: > > Hi! > > > > seems like I've run into an issue with multiboot2 and module2 > > commands that I can't quite explain. Since it may be something > > super simply and silly -- I wanted to reach out here before I do > > a GRUB/Xen/LK source deepdive. > > > > So here's the deal: whenever I boot straight up Linux kernel > > I can do the following sequence of commands: > > linux /kernel > > initrd foo.cpio.gz bar.cpio.gz > > and have linux kernel effectively stack content of bar.cpio.gz > > on top of foo.cpio.gz and present a unified initramfs that way. > > > > I'm trying to replicate it with Xen, but: > > multiboot2 /boot/xen.gz > > module2 /kernel > > module2 foo.cpio.gz > > module2 bar.cpio.gz > > only seems to be picking up foo.cpio.gz > > > > Has anyone run into this issue before? > > I can explain why that happens. Not sure if it counts as a feature, bug > or mis-expectation, but CC'ing grub-devel for their input. > > The initrd command is presumably concatenating those two files together > in memory, and presenting Linux a single initrd pointer. > It is indeed what seems to be happening. > For the module2 example, you're putting 3 distinct files in memory, and > giving Xen a list 3 modules. > And that is also correct -- nothing like that is possible with modules. Kernel actually needs to be aware of them. So the question then becomes... > Xen is capable of taking various things via modules, such as an > XSM/Flask policy, or microcode, so has logic to identify these if > present and separate them from "other stuff". However, there is a > hardcoded expectation that the first module is the dom0 kernel, and the > next unrecognised module, if present, is *the* initrd. I expect that Xen isn't handing bar.cpio.gz on to dom0, but I'm not sure > whether passing two distinct initrd-like-things to Linux is even possible. > > What you presumably want is some `initrd` side effect in Grub so you can > write `module2 foo.cpio.gz bar.cpio.gz` and have it concatenate things > together in memory and present one MB2 module, but I suspect that exact > syntax might be ambiguous with command line handling. I have no idea > whether such a command currently exists. > ...I guess there's no mechanism out-of-the box to achieve what I want? And the obvious next question: is my EVE usecase esoteric enough that I should just go ahead and do a custom GRUB patch or is there a more general interest in this? Thanks, Roman. --000000000000e0809d05beded750 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Andrew!

first of all -- thanks for pointing me in the right direction. So aft= er reading relevant sources: comments inline.

On Tue, Mar 30, 2021 at = 12:08 PM Andrew Cooper <and= rew.cooper3@citrix.com> wrote:
On 30/03/2021 19:28, Roman Shaposhnik wrote:
> Hi!
>
> seems like I've run into an issue with multiboot2=C2=A0and module2=
> commands that I can't quite explain. Since it may be something
> super simply and silly -- I wanted to reach out here before I do
> a GRUB/Xen/LK source deepdive.
>
> So here's the deal: whenever I boot straight up Linux kernel
> I can do the following sequence of commands:
> =C2=A0 =C2=A0linux /kernel
> =C2=A0 =C2=A0initrd foo.cpio.gz bar.cpio.gz
> and have linux kernel effectively stack content of bar.cpio.gz
> on top of foo.cpio.gz and present a unified initramfs that way.
>
> I'm trying to replicate it with Xen, but:
> =C2=A0 =C2=A0 =C2=A0multiboot2 /boot/xen.gz
> =C2=A0 =C2=A0 =C2=A0module2 /kernel
> =C2=A0 =C2=A0 =C2=A0module2 foo.cpio.gz
> =C2=A0 =C2=A0 =C2=A0module2 bar.cpio.gz
> only seems to be picking up foo.cpio.gz
>
> Has anyone run into this=C2=A0issue before?

I can explain why that happens.=C2=A0 Not sure if it counts as a feature, b= ug
or mis-expectation, but CC'ing grub-devel for their input.

The initrd command is presumably concatenating those two files together
in memory, and presenting Linux a single initrd pointer.

It is indeed what seems to be happening.
=C2=A0=
For the module2 example, you're putting 3 distinct files in memory, and=
giving Xen a list 3 modules.

And that i= s also correct -- nothing like that is possible with modules.
Ker= nel actually needs to be aware of them. So the question then
beco= mes...
=C2=A0
Xen is capable of taking various things via modules, such as an
XSM/Flask policy, or microcode, so has logic to identify these if
present and separate them from "other stuff".=C2=A0 However, ther= e is a
hardcoded expectation that the first module is the dom0 kernel, and the
next unrecognised module, if present, is *the* initrd.=C2=A0
I expect that Xen isn't= handing bar.cpio.gz on to dom0, but I'm not sure
whether passing two distinct initrd-like-things to Linux is even possible.<= br>
What you presumably want is some `initrd` side effect in Grub so you can write `module2 foo.cpio.gz bar.cpio.gz` and have it concatenate things
together in memory and present one MB2 module, but I suspect that exact
syntax might be ambiguous with command line handling.=C2=A0 I have no idea<= br> whether such a command currently exists.

...I guess there's no mechanism out-of-the box to achieve=C2=A0w= hat I want?
=C2=A0
And the obvious nex= t question: is my EVE usecase esoteric enough that
I should just = go ahead and do a custom=C2=A0GRUB patch or is there a more
gener= al interest in this?

Thanks,
Roman.
=
--000000000000e0809d05beded750-- From xen-devel-bounces@lists.xenproject.org Thu Apr 01 04:00:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 04:00:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104099.198705 (Exim 4.92) (envelope-from ) id 1lRoUo-0003r6-A7; Thu, 01 Apr 2021 03:59:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104099.198705; Thu, 01 Apr 2021 03:59:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRoUo-0003qy-40; Thu, 01 Apr 2021 03:59:50 +0000 Received: by outflank-mailman (input) for mailman id 104099; Thu, 01 Apr 2021 03:59:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRoUm-0003qq-6v; Thu, 01 Apr 2021 03:59:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRoUl-0004BX-Uf; Thu, 01 Apr 2021 03:59:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRoUl-0006lk-B8; Thu, 01 Apr 2021 03:59:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lRoUl-0001Se-Ad; Thu, 01 Apr 2021 03:59:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=B987X/bvncCJUt2TB/PBhd/FvG5R7pr/ew2B3UB/fQs=; b=2QMr1IKrMuyCMSLmwnRKGCsOZH QMUiReBADUvpEr4DdktV9ku08635lu3u1pDeW7MUO2i0UCigWUZukRrLhQpuUfZeSglYcm1sasJAf ZN2Emsn72fXLxAfSu76f+lPu7rsihSShlIu+q5AbT3WCWe1alWcOeh+E5pyFoiRp2QVw=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160619: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-freebsd10-i386:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-freebsd10-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-i386-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-arm64-arm64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-armhf-armhf-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install/l1/l2:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=b307a3174ffc293d4af9a0f03d9f78ae63327157 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Thu, 01 Apr 2021 03:59:47 +0000 flight 160619 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/160619/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-freebsd10-i386 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-freebsd10-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-i386-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-amd64-qemuu-freebsd12-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-arm64-arm64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-qemuu-nested-intel 20 debian-hvm-install/l1/l2 fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: qemuu b307a3174ffc293d4af9a0f03d9f78ae63327157 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 223 days Failing since 152659 2020-08-21 14:07:39 Z 222 days 420 attempts Testing same since 160619 2021-03-31 13:54:40 Z 0 days 1 attempts ------------------------------------------------------------ 469 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair fail test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 138842 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Apr 01 06:14:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 06:14:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104112.198732 (Exim 4.92) (envelope-from ) id 1lRqaX-00087B-51; Thu, 01 Apr 2021 06:13:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104112.198732; Thu, 01 Apr 2021 06:13:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRqaX-000874-1l; Thu, 01 Apr 2021 06:13:53 +0000 Received: by outflank-mailman (input) for mailman id 104112; Thu, 01 Apr 2021 06:13:51 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRqaV-00086z-KI for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 06:13:51 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 39cabee8-158e-4335-898e-90d3ae046903; Thu, 01 Apr 2021 06:13:50 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7B9F1AF2A; Thu, 1 Apr 2021 06:13:49 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 39cabee8-158e-4335-898e-90d3ae046903 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617257629; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LrC8NH6cwvyNTaMUZ7lEQO8HaDcFzcZL/32U3WaYC68=; b=DdWrNAzbSDiulrJgKuOuWMsjXkucx4Ir2CcCGVIXshS/bz8LsaTlCMA1QLpxff/+DlK5xy jS0u7s1hcf22sxQ8TPcZXo1F5k5hCnAS/l6acr0l8DgozPkCaPZFEb+8aUU072rStlaeF4 bDf/snoaCKb3Qh15fhw5uGaff2UF+u0= Subject: Re: [PATCH] fix for_each_cpu() again for NR_CPUS=1 To: Dario Faggioli Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <4d993e67-2bdf-9ac3-f78e-daf279642de1@suse.com> <800b163affc6334837006a6ef6f8e21415d874e9.camel@suse.com> From: Jan Beulich Message-ID: <0ab32afb-d8d4-de24-e10c-0e9c5e170e45@suse.com> Date: Thu, 1 Apr 2021 08:13:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <800b163affc6334837006a6ef6f8e21415d874e9.camel@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 31.03.2021 18:55, Dario Faggioli wrote: > On Wed, 2021-03-31 at 16:52 +0200, Jan Beulich wrote: >> Unfortunately aa50f45332f1 ("xen: fix for_each_cpu when NR_CPUS=1") >> has >> caused quite a bit of fallout with gcc10, e.g. (there are at least >> two >> more similar ones, and I didn't bother trying to find them all): >> > Oh, wow... Sorry about that. I was sure I had checked (and with gcc10), > but clearly I'm wrong. Perhaps you did try a debug build, while I was seeing the issues in a non-debug one? >> Re-instate a special form of for_each_cpu(), experimentally "proven" >> to >> avoid the diagnostics. >> >> Signed-off-by: Jan Beulich >> > Reviewed-by: Dario Faggioli Thanks. Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 01 07:31:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 07:31:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104116.198743 (Exim 4.92) (envelope-from ) id 1lRrnL-0006Yn-RM; Thu, 01 Apr 2021 07:31:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104116.198743; Thu, 01 Apr 2021 07:31:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRrnL-0006Yg-OM; Thu, 01 Apr 2021 07:31:11 +0000 Received: by outflank-mailman (input) for mailman id 104116; Thu, 01 Apr 2021 07:31:10 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRrnK-0006Yb-2N for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 07:31:10 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 95d809e2-e143-4727-86d0-885f1def281a; Thu, 01 Apr 2021 07:31:08 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id EE0E9B119; Thu, 1 Apr 2021 07:31:07 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 95d809e2-e143-4727-86d0-885f1def281a X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617262268; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VlvKU9J+T+KwoivZaZ0SLwGW3IXl34XrRCMhiAm7cto=; b=dVFKMh8eIHxMCyRVhQpwn1AiYwKxzIgHq2lzRqT1eGMFV4b+BIOsFmAe4a0w5oabvmxiTe elIc8fxTF17E3H9VNRD/gwM0MMtbwWiHV5riaVnFmfLBv2aRNNTRgKRiJpLbl/NFmtD8nt tcwYKlrvljpGxMNWvz9TJifoCHR96sE= Subject: Re: multiboot2 and module2 boot issues via GRUB2 To: Roman Shaposhnik Cc: Xen-devel , grub-devel@gnu.org, Andrew Cooper References: <23baec07-a3ae-949a-a1fb-09100efd53e5@citrix.com> From: Jan Beulich Message-ID: Date: Thu, 1 Apr 2021 09:31:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 01.04.2021 03:06, Roman Shaposhnik wrote: > And the obvious next question: is my EVE usecase esoteric enough that > I should just go ahead and do a custom GRUB patch or is there a more > general interest in this? Not sure if it ought to be a grub patch - the issue could as well be dealt with in Xen, by concatenating modules to form a monolithic initrd. Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 01 07:51:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 07:51:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104119.198756 (Exim 4.92) (envelope-from ) id 1lRs6q-0008Kk-Aa; Thu, 01 Apr 2021 07:51:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104119.198756; Thu, 01 Apr 2021 07:51:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRs6q-0008Kd-7U; Thu, 01 Apr 2021 07:51:20 +0000 Received: by outflank-mailman (input) for mailman id 104119; Thu, 01 Apr 2021 07:51:19 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRs6o-0008KY-S3 for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 07:51:18 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4f27c75c-d8f4-4639-abcf-ca1f1e361d2b; Thu, 01 Apr 2021 07:51:18 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 21A85AF4F; Thu, 1 Apr 2021 07:51:17 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f27c75c-d8f4-4639-abcf-ca1f1e361d2b X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617263477; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mM301/30alX098xW5XnviSToFopYKP7Lp25WeUemPCc=; b=OeHmsI0nhC9iydjwRHN0rVFTlD1/Q2lL3t6yScXSWn1j0eSLxuHwXTIrXC2ZJK3QC9iIIf iP6DDl0xivWpCf98eD/3t4klDm7r+TMz9AAlGzzyVlOqG5UNlQg31AwMETcbXTgs33FIXX xf89n6KqaU9oGG0FzaluS3oGEgh7EQs= Subject: Ping: [PATCH 5/5] x86: don't build unused entry code when !PV32 To: Andrew Cooper Cc: "xen-devel@lists.xenproject.org" , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <46d83c92-0b06-fc09-4832-7a7d7935d5c2@suse.com> <20201228153004.qip3v6er5rk22fnu@Air-de-Roger> <0341c1f1-dc50-552c-f246-56605ae7c83a@suse.com> <20210104155358.snzakj4kcs47tt22@Air-de-Roger> From: Jan Beulich Message-ID: Date: Thu, 1 Apr 2021 09:51:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210104155358.snzakj4kcs47tt22@Air-de-Roger> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 04.01.2021 16:53, Roger Pau Monné wrote: > On Mon, Jan 04, 2021 at 02:56:12PM +0100, Jan Beulich wrote: >> On 28.12.2020 16:30, Roger Pau Monné wrote: >>> I would like to have Andrew's opinion on this one (as you and him tend >>> to modify more asm code than myself). There are quite a lot of >>> addition to the assembly code, and IMO it makes the code more complex >>> which I think we should try to avoid, as assembly is already hard >>> enough. >> >> Well, while I can see your point (and I indeed asked myself the same >> question when making this change), this merely follows the route >> started with the addition on CONFIG_PV conditionals. If we think that >> prior step didn't set a good precedent, we ought to undo it. >> Otherwise I see no good argument against doing the same kind of >> transformation a 2nd time (and further ones, if need be down the >> road). > > I think we need to apply some common sense and reach consensus about > where it's fine to make code conditional at build time as to not make > the existing code much harder to read and reason about. This is mostly > a subjective decision, so I understand your concern. > > I still think I would like Andrew opinion on this one, as said you and > him are the ones mostly doing assembly coding. I find it already hard > to follow myself without the conditionals. Seeing no feedback for about 3 months, I intend to commit this once the tree is fully open again (if need be without any acks), unless I hear otherwise by then. Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 01 07:56:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 07:56:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104122.198768 (Exim 4.92) (envelope-from ) id 1lRsBV-0008VI-UP; Thu, 01 Apr 2021 07:56:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104122.198768; Thu, 01 Apr 2021 07:56:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRsBV-0008VB-Qa; Thu, 01 Apr 2021 07:56:09 +0000 Received: by outflank-mailman (input) for mailman id 104122; Thu, 01 Apr 2021 07:56:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRsBU-0008V6-JH for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 07:56:08 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d9a6458f-1a25-436d-bbf6-fc1c94ea109f; Thu, 01 Apr 2021 07:56:07 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0758EB21F; Thu, 1 Apr 2021 07:56:07 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d9a6458f-1a25-436d-bbf6-fc1c94ea109f X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617263767; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=crDx6RJ3pOXnjuMYs8hePdC2YuFryi75VhhC9or0s44=; b=r4SmKVGNDkmjpjPnOau9hDW5sVVc6W6lthXxMZuNi+ylG+hMgvdiarN3uM4jfDcKvH2ITJ V91ln7HPpKHz753bshK81wr+ZZO5Gtmo8vvCA43Qpe8HUwO5A+xtTGg02GU5s8/rI8x36X 2QhY+Um393XpTxT1bycZaRI4VhkIhUE= Subject: Ping: [PATCH 4/5] x86/PV: restrict TLB flushing after mod_l[234]_entry() From: Jan Beulich To: Andrew Cooper Cc: "xen-devel@lists.xenproject.org" , Wei Liu , George Dunlap , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <10a01f61-197b-7df4-192d-917fe135df70@suse.com> <20210111130020.ogpsylc7sh3wzb7i@Air-de-Roger> <2bee9e95-17f7-4089-4adf-29db50c5c4fd@suse.com> Message-ID: Date: Thu, 1 Apr 2021 09:56:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <2bee9e95-17f7-4089-4adf-29db50c5c4fd@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 11.01.2021 14:22, Jan Beulich wrote: > On 11.01.2021 14:00, Roger Pau Monné wrote: >> On Tue, Nov 03, 2020 at 11:57:33AM +0100, Jan Beulich wrote: >>> Just like we avoid to invoke remote root pt flushes when all uses of an >>> L4 table can be accounted for locally, the same can be done for all of >>> L[234] for the linear pt flush when the table is a "free floating" one, >>> i.e. it is pinned but not hooked up anywhere. While this situation >>> doesn't occur very often, it can be observed. >>> >>> Since this breaks one of the implications of the XSA-286 fix, drop the >>> flush_root_pt_local variable again and set ->root_pgt_changed directly, >>> just like it was before that change. >>> >>> Signed-off-by: Jan Beulich >> >> LGTM, so: >> >> Acked-by: Roger Pau Monné > > Thanks. > >> It would be good however if Andrew can give is opinion also, since he >> was the one to introduce such logic, and it's not trivial. > > I can certainly wait some, also to hopefully get a comment on > >>> --- >>> While adjusting the big comment that was added for XSA-286 I wondered >>> why it talks about the "construction of 32bit PV guests". How are 64-bit >>> PV guests different in this regard? > > ... this, but his email troubles make it hard to judge for how > long to wait. About like for the other one just pinged, I intend to commit this one together with the other two still pending ones in this series once the tree is fully open again, unless I hear otherwise by then. All three have been acked by Roger. Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 01 08:00:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 08:00:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104129.198783 (Exim 4.92) (envelope-from ) id 1lRsFm-0001UN-Pq; Thu, 01 Apr 2021 08:00:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104129.198783; Thu, 01 Apr 2021 08:00:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRsFm-0001UG-MN; Thu, 01 Apr 2021 08:00:34 +0000 Received: by outflank-mailman (input) for mailman id 104129; Thu, 01 Apr 2021 08:00:33 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRsFl-0001UB-JI for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 08:00:33 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id df1147cc-8342-4dfe-b6d1-d69926d99a1d; Thu, 01 Apr 2021 08:00:31 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DD4E9B1F1; Thu, 1 Apr 2021 08:00:30 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: df1147cc-8342-4dfe-b6d1-d69926d99a1d X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617264031; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2sZt9qo8NcRMWOTASDKrGZPc39F8TkStruAYUradwBg=; b=BNI9vvGASYaxegAmu077BgRMLih4wIpzx5xfZ6xgZMVG7uo1OBWbtayuuxFSFbMn3YbVcr JmYaYTKewcCCx7v43l9n+CWJkPQKaHVPwYlZ3kDm70JCVxgS2K/ncgILy+/31+Pv/0ZijS WppXTO+lpU3Ems6Hg3beCRlhcMEm9ys= Subject: =?UTF-8?Q?Ping=c2=b2=3a_=5bPATCH_v2=5d_x86/PV=3a_make_post-migratio?= =?UTF-8?Q?n_page_state_consistent?= From: Jan Beulich To: Andrew Cooper Cc: "xen-devel@lists.xenproject.org" , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <07ebce3c-4dcf-bc9e-6d82-7f3def486ab8@suse.com> <8df7e434-6cea-54ca-4f24-09cbd692ad3b@suse.com> Message-ID: Date: Thu, 1 Apr 2021 10:00:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <8df7e434-6cea-54ca-4f24-09cbd692ad3b@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 23.11.2020 13:50, Jan Beulich wrote: > On 23.11.2020 13:26, Andrew Cooper wrote: >> On 20/11/2020 12:48, Jan Beulich wrote: >>> On 04.11.2020 08:56, Jan Beulich wrote: >>>> When a page table page gets de-validated, its type reference count drops >>>> to zero (and PGT_validated gets cleared), but its type remains intact. >>>> XEN_DOMCTL_getpageframeinfo3, therefore, so far reported prior usage for >>>> such pages. An intermediate write to such a page via e.g. >>>> MMU_NORMAL_PT_UPDATE, however, would transition the page's type to >>>> PGT_writable_page, thus altering what XEN_DOMCTL_getpageframeinfo3 would >>>> return. In libxc the decision which pages to normalize / localize >>>> depends solely on the type returned from the domctl. As a result without >>>> further precautions the guest won't be able to tell whether such a page >>>> has had its (apparent) PTE entries transitioned to the new MFNs. >>>> >>>> Add a check of PGT_validated, thus consistently avoiding normalization / >>>> localization in the tool stack. >>>> >>>> Also use XEN_DOMCTL_PFINFO_NOTAB in the variable's initializer instead >>>> open coding it. >>>> >>>> Signed-off-by: Jan Beulich >>>> --- >>>> v2: Don't change type's type. >>> Ping? >> >> Ping what?  There is still nothing addressing my concerns from v1. > > I did reply to your concerns on Sep 11th, and then replied to this > reply of mine another time on Sep 28th. Neither of these got any > response from you, hence I had to conclude - after two further > pings on v1 - that they were satisfactory to you. Now you say they > weren't, but without saying in which way, so I still wouldn't know > what to change in the description. > > On the code change itself you did say "... so this is probably a > good change", so I was further understanding that your concern is > merely with the description. Maybe I misunderstood this aspect, > too? > >> To re-iterate - this is a very subtle change, in a very complicated >> piece of migration.  As the problems described do not manifest in >> practice, it is vital to understand why. > > Until now it has been my understanding that they just don't happen > to manifest, because guests know to behave themselves (read: pin, > first and foremost, all their page tables, which means we wouldn't > in practice run into ones with an in-flight state change). Another example where I think I have waited long enough for a reply. Roger has acked the change, so unless I hear otherwise by then I'm intending to commit this, too, once the tree is fully open again. Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 01 08:05:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 08:05:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104132.198795 (Exim 4.92) (envelope-from ) id 1lRsKV-0001g7-D0; Thu, 01 Apr 2021 08:05:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104132.198795; Thu, 01 Apr 2021 08:05:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRsKV-0001g0-9t; Thu, 01 Apr 2021 08:05:27 +0000 Received: by outflank-mailman (input) for mailman id 104132; Thu, 01 Apr 2021 08:05:26 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRsKU-0001fu-4l for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 08:05:26 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id cef6a366-a162-45c2-8f87-fee1d92a60c0; Thu, 01 Apr 2021 08:05:25 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5EC53AD6D; Thu, 1 Apr 2021 08:05:24 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cef6a366-a162-45c2-8f87-fee1d92a60c0 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617264324; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VqrCyBIF8QFz2KGAE0AiTc4J1eYaPJ7bzhliUAFzRms=; b=PBhTZPGW1iG5KOP1Mjy/xCpSbtoJovXsgHbmssSYzjSbS7sOrZVI5ZtAAVX/LaPUXUo9Zo UHc7aIDkr3ZqhZVmAGbv+22O2l8cFkwuYpJ7yrE7n8FG4gtORwgMYLTmdbQMUfFwZv1/sx gVaYrsOV6MqEZvKrrdY3nvBi1y97s34= Subject: =?UTF-8?Q?Ping=c2=b2=3a_=5bPATCH=5d_x86emul=3a_de-duplicate_scatter?= =?UTF-8?Q?s_to_the_same_linear_address?= From: Jan Beulich To: Andrew Cooper Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <6064996d-943f-1be3-9bfd-e872149da2a1@suse.com> <2e559806-5bc0-0f61-8e23-95e0dba34c41@suse.com> Message-ID: <6f200e53-02fc-c540-3b23-46f8f4b3385e@suse.com> Date: Thu, 1 Apr 2021 10:05:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 17.02.2021 09:32, Jan Beulich wrote: > On 05.02.2021 12:28, Jan Beulich wrote: >> On 05.02.2021 11:41, Andrew Cooper wrote: >>> On 10/11/2020 13:26, Jan Beulich wrote: >>>> The SDM specifically allows for earlier writes to fully overlapping >>>> ranges to be dropped. If a guest did so, hvmemul_phys_mmio_access() >>>> would crash it if varying data was written to the same address. Detect >>>> overlaps early, as doing so in hvmemul_{linear,phys}_mmio_access() would >>>> be quite a bit more difficult. >>> >>> Are you saying that there is currently a bug if a guest does encode such >>> an instruction, and we emulate it? >> >> That is my take on it, yes. >> >>>> Note that due to cache slot use being linear address based, there's no >>>> similar issue with multiple writes to the same physical address (mapped >>>> through different linear addresses). >>>> >>>> Since this requires an adjustment to the EVEX Disp8 scaling test, >>>> correct a comment there at the same time. >>>> >>>> Signed-off-by: Jan Beulich >>>> --- >>>> TBD: The SDM isn't entirely unambiguous about the faulting behavior in >>>> this case: If a fault would need delivering on the earlier slot >>>> despite the write getting squashed, we'd have to call ops->write() >>>> with size set to zero for the earlier write(s). However, >>>> hvm/emulate.c's handling of zero-byte accesses extends only to the >>>> virtual-to-linear address conversions (and raising of involved >>>> faults), so in order to also observe #PF changes to that logic >>>> would then also be needed. Can we live with a possible misbehavior >>>> here? >>> >>> Do you have a chapter/section reference? >> >> The instruction pages. They say in particular >> >> "If two or more destination indices completely overlap, the “earlier” >> write(s) may be skipped." >> >> and >> >> "Faults are delivered in a right-to-left manner. That is, if a fault >> is triggered by an element and delivered ..." >> >> To me this may or may not mean the skipping of indices includes the >> skipping of faults (which a later element then would raise anyway). > > Does the above address your concerns / questions? If not, what else > do I need to provide? I have to admit that I find it quite disappointing that this bug fix has missed 4.15. It doesn't feel well here even more than elsewhere, but again I'm intending to commit this - if need be without any acks - once the tree is fully open again. As a bug fix it'll want backporting as well. Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 01 08:08:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 08:08:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104135.198806 (Exim 4.92) (envelope-from ) id 1lRsNl-0001oO-SN; Thu, 01 Apr 2021 08:08:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104135.198806; Thu, 01 Apr 2021 08:08:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRsNl-0001oH-PE; Thu, 01 Apr 2021 08:08:49 +0000 Received: by outflank-mailman (input) for mailman id 104135; Thu, 01 Apr 2021 08:08:48 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRsNj-0001oC-V8 for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 08:08:47 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fccfb449-61ac-41b7-8c55-206b68946616; Thu, 01 Apr 2021 08:08:47 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 49277B06A; Thu, 1 Apr 2021 08:08:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fccfb449-61ac-41b7-8c55-206b68946616 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617264526; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lxipyp9rt3pRxcGI+J9L6VZB7lZCIV/pDMRlARWLStQ=; b=A7KGEJUKSoKxX/JVRTQeIWWzA9m2aWowhXYJqxAefA8kAFHgjlDD7+nbWsxi7c9xslJGE7 Hm4CiHGogrTY0N2SdLgM78xm6yuqVO4Yq/iM3A/6Ea+483GljePWKq9yiKfm3b36pG9bh0 If+51CXjfonExerjZjB92G2IeL/1qpc= Subject: Ping: [PATCH] libxg: don't use max policy in xc_cpuid_xend_policy() From: Jan Beulich To: Andrew Cooper Cc: "xen-devel@lists.xenproject.org" , Ian Jackson , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <4fa05759-24ac-5ff3-3db9-94537f6be95d@suse.com> <20201106155839.vnhdqcptbpkbzfly@liuwe-devbox-debian-v2> Message-ID: <44e9cf2e-e90a-12bd-59bf-3c8389ac0862@suse.com> Date: Thu, 1 Apr 2021 10:08:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 23.11.2020 14:58, Jan Beulich wrote: > On 06.11.2020 16:58, Wei Liu wrote: >> On Thu, Nov 05, 2020 at 04:56:53PM +0100, Jan Beulich wrote: >>> Using max undermines the separation between default and max. For example, >>> turning off AVX512F on an MPX-capable system silently turns on MPX, >>> despite this not being part of the default policy anymore. Since the >>> information is used only for determining what to convert 'x' to (but not >>> to e.g. validate '1' settings), the effect of this change is identical >>> for guests with (suitable) "cpuid=" settings to that of the changes >>> separating default from max and then converting (e.g.) MPX from being >>> part of default to only being part of max for guests without (affected) >>> "cpuid=" settings. >>> >>> Signed-off-by: Jan Beulich >> >> I will defer this to Andrew. > > Andrew? Yet another one (here having been pending for nearly 5 months), and hence same thing (despite again not feeling well, albeit iirc at the time we discussed this on irc and you looked to be basically agreeing): I intend to commit this once the tree is fully open again, unless I hear otherwise. Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 01 08:14:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 08:14:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104142.198822 (Exim 4.92) (envelope-from ) id 1lRsTK-0002kT-Mu; Thu, 01 Apr 2021 08:14:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104142.198822; Thu, 01 Apr 2021 08:14:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRsTK-0002kM-J5; Thu, 01 Apr 2021 08:14:34 +0000 Received: by outflank-mailman (input) for mailman id 104142; Thu, 01 Apr 2021 08:14:34 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRsTK-0002kH-29 for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 08:14:34 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8c259dab-e72e-4d58-ad03-c299b6bc02f0; Thu, 01 Apr 2021 08:14:32 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CA2C4AD9F; Thu, 1 Apr 2021 08:14:31 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8c259dab-e72e-4d58-ad03-c299b6bc02f0 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617264871; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A+Mwczd/JLppQkoJwt/WdnAEqqg2B2/Bm6sAPhNxIaQ=; b=GObWplHcaORdQh3kcmXAJzUYEdVO3cN6NN/+sGUlggjxtkRM4h1vw6+FNaVUq16GkYJGix ym7//FSMQwtUFLeFc8nFxHGFAM91uKlWHaJ9KyTEbuhIwJ6Fiw7jXXobEy6wt6H6w99NE/ E7SODNZ74QVDiufIDVQZz0nvbP3qM0A= Subject: =?UTF-8?Q?Ping=c2=b2=3a_=5bPATCH=5d_x86/CPUID=3a_move_some_static_m?= =?UTF-8?Q?asks_into_=2einit?= From: Jan Beulich To: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" References: <2e3dfe1a-bc8b-6774-ef7e-efb565343c52@suse.com> Message-ID: Date: Thu, 1 Apr 2021 10:14:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 31.07.2020 16:55, Jan Beulich wrote: > On 15.07.2020 09:45, Jan Beulich wrote: >> Except for hvm_shadow_max_featuremask and deep_features they're >> referenced by __init functions only. >> >> Signed-off-by: Jan Beulich >> >> --- a/xen/arch/x86/cpuid.c >> +++ b/xen/arch/x86/cpuid.c >> @@ -16,12 +16,15 @@ >> const uint32_t known_features[] = INIT_KNOWN_FEATURES; >> const uint32_t special_features[] = INIT_SPECIAL_FEATURES; >> >> -static const uint32_t pv_max_featuremask[] = INIT_PV_MAX_FEATURES; >> +static const uint32_t __initconst pv_max_featuremask[] = INIT_PV_MAX_FEATURES; >> static const uint32_t hvm_shadow_max_featuremask[] = INIT_HVM_SHADOW_MAX_FEATURES; >> -static const uint32_t hvm_hap_max_featuremask[] = INIT_HVM_HAP_MAX_FEATURES; >> -static const uint32_t pv_def_featuremask[] = INIT_PV_DEF_FEATURES; >> -static const uint32_t hvm_shadow_def_featuremask[] = INIT_HVM_SHADOW_DEF_FEATURES; >> -static const uint32_t hvm_hap_def_featuremask[] = INIT_HVM_HAP_DEF_FEATURES; >> +static const uint32_t __initconst hvm_hap_max_featuremask[] = >> + INIT_HVM_HAP_MAX_FEATURES; >> +static const uint32_t __initconst pv_def_featuremask[] = INIT_PV_DEF_FEATURES; >> +static const uint32_t __initconst hvm_shadow_def_featuremask[] = >> + INIT_HVM_SHADOW_DEF_FEATURES; >> +static const uint32_t __initconst hvm_hap_def_featuremask[] = >> + INIT_HVM_HAP_DEF_FEATURES; >> static const uint32_t deep_features[] = INIT_DEEP_FEATURES; >> >> static int __init parse_xen_cpuid(const char *s) While I seem to recall that you, Andrew, said on irc that this change may need almost immediate reverting with some further work you were meaning to do, this work hasn't surfaced in the 8.5 months this patch has been pending. Therefore I think I should have gone in right at the time. Even if it's going to get (partly) reverted over time, I think until such time it is benefitial to have that data moved to .init. I therefore intend to commit this, again if need be without any acks, once the tree is fully open again. Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 01 08:23:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 08:23:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104145.198834 (Exim 4.92) (envelope-from ) id 1lRscI-0003hi-Jm; Thu, 01 Apr 2021 08:23:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104145.198834; Thu, 01 Apr 2021 08:23:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRscI-0003hb-Ff; Thu, 01 Apr 2021 08:23:50 +0000 Received: by outflank-mailman (input) for mailman id 104145; Thu, 01 Apr 2021 08:23:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRscH-0003hU-Fq for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 08:23:49 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2d2afe57-061e-45bc-99f1-8c13340dbd1d; Thu, 01 Apr 2021 08:23:48 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9E4B3AE8D; Thu, 1 Apr 2021 08:23:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2d2afe57-061e-45bc-99f1-8c13340dbd1d X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617265427; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rfHY6YVcp6pTaCljzpBFGILhRmitcEpxa1sbLFaLekA=; b=j5LO0Ho9gjBvocpKFIcMSyDpES8J39upuUXfH134CVFIV1ZCpD9KUmNtbmFRVelnUC+gjX LmcGSVx9Qo/9K8e1cL4KPXCv1Nqk1B7cv9jV7DrLuxNcTMWamrCO7UN5iKmg6060pI5q6o 3TKzoI2myTrPXSlf7qQKV1dQYMnCjLQ= Subject: Ping: [PATCH v2] x86: refine guest_mode() From: Jan Beulich To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , "xen-devel@lists.xenproject.org" References: <369ec8ad-7d07-9c50-7458-fd68a2d717fb@suse.com> Message-ID: <9ea89aba-5c2c-0795-9704-0afd5b31349d@suse.com> Date: Thu, 1 Apr 2021 10:23:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <369ec8ad-7d07-9c50-7458-fd68a2d717fb@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 27.05.2020 18:23, Jan Beulich wrote: > The 2nd of the assertions as well as the macro's return value have been > assuming we're on the primary stack. While for most IST exceptions we > switch back to the main one when user mode was interrupted, for #DF we > intentionally never do, and hence a #DF actually triggering on a user > mode insn (which then is still a Xen bug) would in turn trigger this > assertion, rather than cleanly logging state. > > Reported-by: Andrew Cooper > Signed-off-by: Jan Beulich > Reviewed-by: Roger Pau Monné In a prior discussion, as so often, my most recent reply remained unanswered. Quoting it partially (fully reply at [1]): "> I'd certainly prefer to go for something which is more robust, even if > it is a larger change. ... what's your suggestion? Basing on _just_ CS.RPL obviously won't work. Not even if we put in place the guest's CS (albeit that somewhat depends on the meaning we assign to the macro's returned value). Using current inside the macro to determine whether the guest is HVM would also seem fragile to me - there are quite a few uses of guest_mode(). Which would leave passing in a const struct vcpu * (or domain *), requiring to touch all call sites, including Arm's. Compared to this it would seem to me that the change as presented is a clear improvement without becoming overly large of a change." Lacking a clear route to take to address your request for further change, based on the last sentence I intend to finally commit this one (in its re-based form) as well once the tree is fully open again. Of course, as always, unless I hear otherwise by then (including a clear path forward). I definitely don't want to celebrate the 1st anniversary of this patch's submission without it having got committed. Jan [1] https://lists.xen.org/archives/html/xen-devel/2020-04/msg01550.html > --- > v2: Correct description. > --- > While we could go further and also assert we're on the correct IST > stack in an "else" ti the "if()" added, I'm not fully convinced this > would be generally helpful. I'll be happy to adjust accordingly if > others think differently; at such a point though I think this should > then no longer be a macro. > > --- unstable.orig/xen/include/asm-x86/regs.h 2020-01-22 20:03:18.000000000 +0100 > +++ unstable/xen/include/asm-x86/regs.h 2020-04-27 10:02:40.009916762 +0200 > @@ -10,9 +10,10 @@ > /* Frame pointer must point into current CPU stack. */ \ > ASSERT(diff < STACK_SIZE); \ > /* If not a guest frame, it must be a hypervisor frame. */ \ > - ASSERT((diff == 0) || (r->cs == __HYPERVISOR_CS)); \ > + if ( diff < PRIMARY_STACK_SIZE ) \ > + ASSERT(!diff || ((r)->cs == __HYPERVISOR_CS)); \ > /* Return TRUE if it's a guest frame. */ \ > - (diff == 0); \ > + !diff || ((r)->cs != __HYPERVISOR_CS); \ > }) > > #endif /* __X86_REGS_H__ */ > From xen-devel-bounces@lists.xenproject.org Thu Apr 01 08:28:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 08:28:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104148.198846 (Exim 4.92) (envelope-from ) id 1lRsgS-0003t3-6K; Thu, 01 Apr 2021 08:28:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104148.198846; Thu, 01 Apr 2021 08:28:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRsgS-0003sw-1V; Thu, 01 Apr 2021 08:28:08 +0000 Received: by outflank-mailman (input) for mailman id 104148; Thu, 01 Apr 2021 08:28:06 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRsgQ-0003sr-HL for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 08:28:06 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d7c79b19-9747-4feb-9a33-9e1ea16f3f9e; Thu, 01 Apr 2021 08:28:05 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C85F7AE86; Thu, 1 Apr 2021 08:28:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d7c79b19-9747-4feb-9a33-9e1ea16f3f9e X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617265684; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cWIQ6va35/HadgSZsBXIRMGX3zL3qfKRBRXkkpIfliA=; b=sDhUkmNTd5oIFSOkfnM/qYhVwfDqGgi6ca3UIvXBfw03d9pzwOogDm0nwsIJrXhHzEJ2qN JFk5Jw1KWP2e8S7DknCSqrPrPLbiiQP0grYWl+uy+QCVSXp1aePFXYaDiWeQu5WOj/pFhe 7CGcpg3a1U1Ek0TqY689BwOfYExedaw= To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] x86/ucode: log blob date also for AMD Message-ID: Date: Thu, 1 Apr 2021 10:28:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Like Intel, AMD also records the date in their blobs. The field was merely misnamed as "data_code" so far; this was perhaps meant to be "date_code". Split it into individual fields, just like we did for Intel some time ago, and extend the message logged after a successful update. Signed-off-by: Jan Beulich --- a/xen/arch/x86/cpu/microcode/amd.c +++ b/xen/arch/x86/cpu/microcode/amd.c @@ -33,7 +33,9 @@ struct equiv_cpu_entry { }; struct microcode_patch { - uint32_t data_code; + uint16_t year; + uint8_t day; + uint8_t month; uint32_t patch_id; uint8_t mc_patch_data_id[2]; uint8_t mc_patch_data_len; @@ -251,8 +253,9 @@ static int apply_microcode(const struct return -EIO; } - printk(XENLOG_WARNING "microcode: CPU%u updated from revision %#x to %#x\n", - cpu, old_rev, rev); + printk(XENLOG_WARNING + "microcode: CPU%u updated from revision %#x to %#x, date = %04x-%02x-%02x\n", + cpu, old_rev, rev, patch->year, patch->month, patch->day); return 0; } From xen-devel-bounces@lists.xenproject.org Thu Apr 01 08:28:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 08:28:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104151.198858 (Exim 4.92) (envelope-from ) id 1lRsh2-0003yv-FT; Thu, 01 Apr 2021 08:28:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104151.198858; Thu, 01 Apr 2021 08:28:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRsh2-0003yo-Aw; Thu, 01 Apr 2021 08:28:44 +0000 Received: by outflank-mailman (input) for mailman id 104151; Thu, 01 Apr 2021 08:28:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRsh0-0003yd-W8; Thu, 01 Apr 2021 08:28:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRsh0-0001Oo-QS; Thu, 01 Apr 2021 08:28:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRsh0-0003KV-Fs; Thu, 01 Apr 2021 08:28:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lRsh0-0003YN-FN; Thu, 01 Apr 2021 08:28:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=kIAAqHJurFVRyMxC/z6STXn8yZSzmfcvsw75wY1IomY=; b=NmI4kMn7VrYholHifGyJ24JR6i esN54g1rORd27gvx8ttIev4Qrz62XlgJ1OnIw8OdfxfFrsVRdTnrjFwVNH7m3z/YhL8Hz6tq+rprU P6dbeSIQEjN3Aug8FGk0qEec/yStQ9Xq6RbpuvSAwKi8tCtTgTYTxf8Y9KCnE5uSYp1g=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.12-testing test] 160622: regressions - FAIL X-Osstest-Failures: xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-localmigrate/x10:fail:regression xen-4.12-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-saverestore.2:fail:heisenbug xen-4.12-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=5b280a59c4dd8dad6cc8da28db981b193d10acee X-Osstest-Versions-That: xen=4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 From: osstest service owner Date: Thu, 01 Apr 2021 08:28:42 +0000 flight 160622 xen-4.12-testing real [real] flight 160636 xen-4.12-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160622/ http://logs.test-lab.xenproject.org/osstest/logs/160636/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 19 guest-localmigrate/x10 fail in 160549 REGR. vs. 159418 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 160549 pass in 160622 test-amd64-amd64-xl-qcow2 18 guest-saverestore.2 fail pass in 160549 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159418 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159418 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159418 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 5b280a59c4dd8dad6cc8da28db981b193d10acee baseline version: xen 4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 Last test of basis 159418 2021-02-16 15:06:11 Z 43 days Failing since 160128 2021-03-18 14:36:18 Z 13 days 15 attempts Testing same since 160150 2021-03-20 04:11:48 Z 12 days 13 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Christian Lindig Edwin Török Igor Druzhinin Jan Beulich Julien Grall Olaf Hering Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 311 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Apr 01 08:34:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 08:34:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104158.198872 (Exim 4.92) (envelope-from ) id 1lRslz-0004ve-Bf; Thu, 01 Apr 2021 08:33:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104158.198872; Thu, 01 Apr 2021 08:33:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRslz-0004vX-8e; Thu, 01 Apr 2021 08:33:51 +0000 Received: by outflank-mailman (input) for mailman id 104158; Thu, 01 Apr 2021 08:33:50 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRsly-0004vR-42 for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 08:33:50 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f079bd8c-45a0-4c0c-bd77-ebbedea5e2eb; Thu, 01 Apr 2021 08:33:48 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E1A48AE92; Thu, 1 Apr 2021 08:33:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f079bd8c-45a0-4c0c-bd77-ebbedea5e2eb X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617266028; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RF79SsoAyFEuhqGnkFY5BlU6Era99vx8Fr7JdyqLln8=; b=aaybsiO9FjCfGOPDQXFbzYpZXZcfKQAOxhR8gOBWlxfEOAAuEAHR7rIIaOoR50dK/Kb1pw /KqC+eto5/tezWUDsCBVWzWue53QSjcyzEpiLVRjTZhY/5ceBiN2xkb4GjEf/owCIhncxS fdqQWsTpNAItkaah+lJEu0xNhau+VD0= To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] build: centralize / unify asm-offsets generation Message-ID: Date: Thu, 1 Apr 2021 10:33:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Except for an additional prereq Arm and x86 have the same needs here, and Arm can also benefit from the recent x86 side improvement. Recurse into arch/*/ only for a phony include target (doing nothing on Arm), and handle asm-offsets itself entirely locally to xen/Makefile. Signed-off-by: Jan Beulich --- a/.gitignore +++ b/.gitignore @@ -318,7 +318,6 @@ xen/arch/x86/efi/check.efi xen/arch/x86/efi/mkreloc xen/arch/*/xen.lds -xen/arch/*/asm-offsets.s xen/arch/*/efi/boot.c xen/arch/*/efi/compat.c xen/arch/*/efi/ebmalloc.c @@ -325,6 +324,7 @@ xen/arch/*/efi/efi.h xen/arch/*/efi/pe.c xen/arch/*/efi/runtime.c +xen/asm-offsets.s xen/common/config_data.S xen/common/config.gz xen/include/headers*.chk --- a/xen/Makefile +++ b/xen/Makefile @@ -341,7 +341,7 @@ _clean: delete-unfresh-files find . \( -name "*.o" -o -name ".*.d" -o -name ".*.d2" \ -o -name "*.gcno" -o -name ".*.cmd" \) -exec rm -f {} \; rm -f include/asm $(TARGET) $(TARGET).gz $(TARGET).efi $(TARGET).efi.map $(TARGET)-syms $(TARGET)-syms.map *~ core - rm -f include/asm-*/asm-offsets.h + rm -f asm-offsets.s include/asm-*/asm-offsets.h rm -f .banner .PHONY: _distclean @@ -362,7 +362,7 @@ $(TARGET): delete-unfresh-files done; \ true $(MAKE) -f $(BASEDIR)/Rules.mk -C include - $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) asm-offsets.s + $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) include $(MAKE) -f $(BASEDIR)/Rules.mk include/asm-$(TARGET_ARCH)/asm-offsets.h $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) $@ @@ -399,7 +399,11 @@ include/xen/compile.h: include/xen/compi @sed -rf tools/process-banner.sed < .banner >> $@.new @mv -f $@.new $@ -include/asm-$(TARGET_ARCH)/asm-offsets.h: arch/$(TARGET_ARCH)/asm-offsets.s +asm-offsets.s: arch/$(TARGET_ARCH)/$(TARGET_SUBARCH)/asm-offsets.c + $(CC) $(filter-out -Wa$(comma)% -flto,$(c_flags)) -S -g0 -o $@.new -MQ $@ $< + $(call move-if-changed,$@.new,$@) + +include/asm-$(TARGET_ARCH)/asm-offsets.h: asm-offsets.s @(set -e; \ echo "/*"; \ echo " * DO NOT MODIFY."; \ --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -131,8 +131,8 @@ $(TARGET)-syms: prelink.o xen.lds >$(@D)/$(@F).map rm -f $(@D)/.$(@F).[0-9]* -asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c - $(CC) $(filter-out -flto,$(c_flags)) -S -o $@ $< +.PHONY: include +include: xen.lds: xen.lds.S $(CPP) -P $(a_flags) -MQ $@ -o $@ $< @@ -141,6 +141,6 @@ dtb.o: $(CONFIG_DTB_FILE) .PHONY: clean clean:: - rm -f asm-offsets.s xen.lds + rm -f xen.lds rm -f $(BASEDIR)/.xen-syms.[0-9]* rm -f $(TARGET).efi --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -244,9 +244,8 @@ endif efi/buildid.o efi/relocs-dummy.o: $(BASEDIR)/arch/x86/efi/built_in.o efi/buildid.o efi/relocs-dummy.o: ; -asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c $(BASEDIR)/include/asm-x86/asm-macros.h - $(CC) $(filter-out -Wa$(comma)% -flto,$(c_flags)) -S -g0 -o $@.new -MQ $@ $< - $(call move-if-changed,$@.new,$@) +.PHONY: include +include: $(BASEDIR)/include/asm-x86/asm-macros.h asm-macros.i: CFLAGS-y += -D__ASSEMBLY__ -P @@ -276,7 +275,7 @@ hweight.o: CFLAGS-y += $(foreach reg,cx .PHONY: clean clean:: - rm -f asm-offsets.s *.lds *.new boot/*.o boot/*~ boot/core boot/mkelf32 + rm -f *.lds *.new boot/*.o boot/*~ boot/core boot/mkelf32 rm -f asm-macros.i $(BASEDIR)/include/asm-x86/asm-macros.* rm -f $(BASEDIR)/.xen-syms.[0-9]* boot/.*.d $(BASEDIR)/.xen.elf32 rm -f $(BASEDIR)/.xen.efi.[0-9]* efi/*.efi efi/mkreloc From xen-devel-bounces@lists.xenproject.org Thu Apr 01 08:35:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 08:35:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104161.198884 (Exim 4.92) (envelope-from ) id 1lRsnx-00054h-P9; Thu, 01 Apr 2021 08:35:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104161.198884; Thu, 01 Apr 2021 08:35:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRsnx-00054a-Lb; Thu, 01 Apr 2021 08:35:53 +0000 Received: by outflank-mailman (input) for mailman id 104161; Thu, 01 Apr 2021 08:35:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRsnw-00054S-B1; Thu, 01 Apr 2021 08:35:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRsnw-0001VY-3g; Thu, 01 Apr 2021 08:35:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRsnv-0003fV-Rr; Thu, 01 Apr 2021 08:35:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lRsnv-0001Nk-Pd; Thu, 01 Apr 2021 08:35:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rcSXw7MHTY/qB3auMy//cyDEJ3Y9EG8Dn5+Sf5serrU=; b=f6MSf6Tcey7fQFl+paiQyBVcmm DNaWwlOjBqDp6JAPlJbJkr5v81Tn49rP5vqC5ixgW+3YEOd5RYwQ+4eARPzL6Eqdv6bWWZBroo0BW VGOFZR7s7YBl6Iz3SBG7s4DOVJMIzjoZRM/knz2vexgI5TV9BISTqcqVzjShbLStV+XI=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 160634: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=af35fa91be9182482c5b84a31c443c6840df8a72 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Thu, 01 Apr 2021 08:35:51 +0000 flight 160634 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/160634/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt af35fa91be9182482c5b84a31c443c6840df8a72 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 265 days Failing since 151818 2020-07-11 04:18:52 Z 264 days 257 attempts Testing same since 160634 2021-04-01 04:21:41 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei simmon Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin WangJian Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yaroslav Kargin Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 49362 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Apr 01 08:43:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 08:43:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104166.198900 (Exim 4.92) (envelope-from ) id 1lRsun-00061Z-J2; Thu, 01 Apr 2021 08:42:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104166.198900; Thu, 01 Apr 2021 08:42:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRsun-00061S-EZ; Thu, 01 Apr 2021 08:42:57 +0000 Received: by outflank-mailman (input) for mailman id 104166; Thu, 01 Apr 2021 08:42:55 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRsul-00061K-Ez for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 08:42:55 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d2611743-2902-4a0b-9f3c-89f79843af36; Thu, 01 Apr 2021 08:42:53 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 87D8DAEFB; Thu, 1 Apr 2021 08:42:52 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d2611743-2902-4a0b-9f3c-89f79843af36 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617266572; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UR99GWV6w+2q0MVEXspBRN36LxCrMHtPwkQFye7fZwA=; b=P7Iuk6XST4U71Ju1Ih12WwbfoK+xfwNqrWPPabqhrHcp2bcZfCXc6Jch8toeN6tQVrEWNz wT1kumXvux1m3Ho+AOPkbE2Au0kR6yul+N/aEUIIdNSSsMGCBz2qBH+9r9dnyZS2Mtz2/6 2CPl0Q0vtAMhz/p+YflX54VmdPyWJKs= To: "xen-devel@lists.xenproject.org" Cc: Kevin Tian From: Jan Beulich Subject: [PATCH 0/6] VT-d: assorted cleanup Message-ID: <157e4a65-6d0b-7ea8-1c23-cd393c8c0d7f@suse.com> Date: Thu, 1 Apr 2021 10:42:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit This is effectively the other "half" of what was submitted as 4.15 candidates in "[PATCH 0/4][4.15?] VT-d: mostly S3 related corrections". 1: improve save/restore of registers across S3 2: don't open-code dmar_readl() 3: bring print_qi_regs() in line with print_iommu_regs() 4: qinval indexes are only up to 19 bits wide 5: avoid pointless use of 64-bit constants 6: drop unused #define-s Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 01 08:44:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 08:44:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104170.198911 (Exim 4.92) (envelope-from ) id 1lRsvy-00068V-SM; Thu, 01 Apr 2021 08:44:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104170.198911; Thu, 01 Apr 2021 08:44:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRsvy-00068O-PL; Thu, 01 Apr 2021 08:44:10 +0000 Received: by outflank-mailman (input) for mailman id 104170; Thu, 01 Apr 2021 08:44:08 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRsvw-00068H-JW for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 08:44:08 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ff23fd63-710c-46c3-8f90-b409ab186394; Thu, 01 Apr 2021 08:44:07 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id BF2A1AE86; Thu, 1 Apr 2021 08:44:06 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff23fd63-710c-46c3-8f90-b409ab186394 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617266646; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EVCTE1tfqI4iUXHiO5xFd7e8mHxtUGLrwEPBx00R958=; b=tyd7dgVvsLyTX3ldvHPf2mSEZI6d5TO41Hsq1IcgrXwSWoDsT1AxGciCXL8jP58OwmhL1V pSMqGtdvjSA2di/unGO4Oshs9ePmDFdgWkrB1Xb2x1phKR2Rpvk6dZtiNIsmrCyuFJKDzj JGwOHG9Qk22r6g95AxemrduZPxjqrPc= Subject: [PATCH 1/6] VT-d: improve save/restore of registers across S3 From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Kevin Tian References: <157e4a65-6d0b-7ea8-1c23-cd393c8c0d7f@suse.com> Message-ID: <2ff7ac44-5a67-55e5-758b-680e68ebacaa@suse.com> Date: Thu, 1 Apr 2021 10:44:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <157e4a65-6d0b-7ea8-1c23-cd393c8c0d7f@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit The static allocation of the save space is not only very inefficient (most of the array slots won't ever get used), but is also the sole reason for a build-time upper bound on the number of IOMMUs. Introduce a structure containing just the one needed field we can't (easily) restore from other in-memory state, and allocate the respective array dynamically. Take the opportunity and make the FEUADDR write dependent upon x2apic_enabled, like is already the case in dma_msi_set_affinity(). Also alter properties of nr_iommus: static, unsigned, and __initdata. Signed-off-by: Jan Beulich --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -57,7 +57,7 @@ bool __read_mostly iommu_qinval = true; bool __read_mostly iommu_snoop = true; #endif -int nr_iommus; +static unsigned int __initdata nr_iommus; static struct iommu_ops vtd_ops; static struct tasklet vtd_fault_tasklet; @@ -1165,13 +1165,6 @@ int __init iommu_alloc(struct acpi_drhd_ unsigned long sagaw, nr_dom; int agaw; - if ( nr_iommus >= MAX_IOMMUS ) - { - dprintk(XENLOG_ERR VTDPREFIX, - "IOMMU: nr_iommus %d > MAX_IOMMUS\n", nr_iommus + 1); - return -ENOMEM; - } - iommu = xzalloc(struct vtd_iommu); if ( iommu == NULL ) return -ENOMEM; @@ -2226,6 +2219,10 @@ static void __hwdom_init setup_hwdom_rmr pcidevs_unlock(); } +static struct iommu_state { + uint32_t fectl; +} *__read_mostly iommu_state; + static int __init vtd_setup(void) { struct acpi_drhd_unit *drhd; @@ -2251,6 +2248,13 @@ static int __init vtd_setup(void) goto error; } + iommu_state = xmalloc_array(struct iommu_state, nr_iommus); + if ( !iommu_state ) + { + ret = -ENOMEM; + goto error; + } + /* We enable the following features only if they are supported by all VT-d * engines: Snoop Control, DMA passthrough, Queued Invalidation, Interrupt * Remapping, and Posted Interrupt @@ -2508,8 +2512,6 @@ static int intel_iommu_group_id(u16 seg, return PCI_BDF2(bus, devfn); } -static u32 iommu_state[MAX_IOMMUS][MAX_IOMMU_REGS]; - static int __must_check vtd_suspend(void) { struct acpi_drhd_unit *drhd; @@ -2534,14 +2536,7 @@ static int __must_check vtd_suspend(void iommu = drhd->iommu; i = iommu->index; - iommu_state[i][DMAR_FECTL_REG] = - (u32) dmar_readl(iommu->reg, DMAR_FECTL_REG); - iommu_state[i][DMAR_FEDATA_REG] = - (u32) dmar_readl(iommu->reg, DMAR_FEDATA_REG); - iommu_state[i][DMAR_FEADDR_REG] = - (u32) dmar_readl(iommu->reg, DMAR_FEADDR_REG); - iommu_state[i][DMAR_FEUADDR_REG] = - (u32) dmar_readl(iommu->reg, DMAR_FEUADDR_REG); + iommu_state[i].fectl = dmar_readl(iommu->reg, DMAR_FECTL_REG); /* don't disable VT-d engine when force_iommu is set. */ if ( force_iommu ) @@ -2594,15 +2589,13 @@ static void vtd_resume(void) for_each_drhd_unit ( drhd ) { iommu = drhd->iommu; - i = iommu->index; spin_lock_irqsave(&iommu->register_lock, flags); - dmar_writel(iommu->reg, DMAR_FEDATA_REG, - iommu_state[i][DMAR_FEDATA_REG]); - dmar_writel(iommu->reg, DMAR_FEADDR_REG, - iommu_state[i][DMAR_FEADDR_REG]); - dmar_writel(iommu->reg, DMAR_FEUADDR_REG, - iommu_state[i][DMAR_FEUADDR_REG]); + dmar_writel(iommu->reg, DMAR_FEDATA_REG, iommu->msi.msg.data); + dmar_writel(iommu->reg, DMAR_FEADDR_REG, iommu->msi.msg.address_lo); + if ( x2apic_enabled ) + dmar_writel(iommu->reg, DMAR_FEUADDR_REG, + iommu->msi.msg.address_hi); spin_unlock_irqrestore(&iommu->register_lock, flags); } @@ -2615,8 +2608,7 @@ static void vtd_resume(void) i = iommu->index; spin_lock_irqsave(&iommu->register_lock, flags); - dmar_writel(iommu->reg, DMAR_FECTL_REG, - (u32) iommu_state[i][DMAR_FECTL_REG]); + dmar_writel(iommu->reg, DMAR_FECTL_REG, iommu_state[i].fectl); spin_unlock_irqrestore(&iommu->register_lock, flags); iommu_enable_translation(drhd); --- a/xen/drivers/passthrough/vtd/iommu.h +++ b/xen/drivers/passthrough/vtd/iommu.h @@ -499,8 +499,6 @@ struct qinval_entry { #define VTD_PAGE_TABLE_LEVEL_3 3 #define VTD_PAGE_TABLE_LEVEL_4 4 -#define MAX_IOMMU_REGS 0xc0 - extern struct list_head acpi_drhd_units; extern struct list_head acpi_rmrr_units; extern struct list_head acpi_ioapic_units; --- a/xen/include/asm-x86/iommu.h +++ b/xen/include/asm-x86/iommu.h @@ -22,7 +22,6 @@ #include #define DEFAULT_DOMAIN_ADDRESS_WIDTH 48 -#define MAX_IOMMUS 32 struct g2m_ioport { struct list_head list; From xen-devel-bounces@lists.xenproject.org Thu Apr 01 08:44:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 08:44:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104175.198924 (Exim 4.92) (envelope-from ) id 1lRswQ-0006Gi-8X; Thu, 01 Apr 2021 08:44:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104175.198924; Thu, 01 Apr 2021 08:44:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRswQ-0006Gb-5V; Thu, 01 Apr 2021 08:44:38 +0000 Received: by outflank-mailman (input) for mailman id 104175; Thu, 01 Apr 2021 08:44:37 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRswP-0006GT-5t for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 08:44:37 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e703b07c-674a-4a5d-8e3e-639abbca8c6f; Thu, 01 Apr 2021 08:44:36 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id BED10AE8D; Thu, 1 Apr 2021 08:44:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e703b07c-674a-4a5d-8e3e-639abbca8c6f X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617266675; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5qi6++u9QBggB8E7CGEoTNUFM2DKPu+n9nR4wGp6C/U=; b=RGHEfTZYySo1EMvwvxwxQK9e2SYicqFszHLrDPzRlPxPscjsrTilBG+cu32oDWIgVrNRgj rsUB10uiziJIfDY2WELwdwmhKZIh4X6Zcz+sygR227WN06vDZTw6efxHRbT+ARQn9HZfWR Xrfptbo+SHJFAOofp2QXx4c+OU8GfQs= Subject: [PATCH 2/6] VT-d: don't open-code dmar_readl() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Kevin Tian References: <157e4a65-6d0b-7ea8-1c23-cd393c8c0d7f@suse.com> Message-ID: Date: Thu, 1 Apr 2021 10:44:35 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <157e4a65-6d0b-7ea8-1c23-cd393c8c0d7f@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit While at it also drop the unnecessary use of a local variable there. Signed-off-by: Jan Beulich --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -990,8 +990,7 @@ static void __do_iommu_page_fault(struct } clear_overflow: /* clear primary fault overflow */ - fault_status = readl(iommu->reg + DMAR_FSTS_REG); - if ( fault_status & DMA_FSTS_PFO ) + if ( dmar_readl(iommu->reg, DMAR_FSTS_REG) & DMA_FSTS_PFO ) { spin_lock_irqsave(&iommu->register_lock, flags); dmar_writel(iommu->reg, DMAR_FSTS_REG, DMA_FSTS_PFO); From xen-devel-bounces@lists.xenproject.org Thu Apr 01 08:44:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 08:44:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104177.198936 (Exim 4.92) (envelope-from ) id 1lRswZ-0006Kh-JY; Thu, 01 Apr 2021 08:44:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104177.198936; Thu, 01 Apr 2021 08:44:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRswZ-0006KW-EZ; Thu, 01 Apr 2021 08:44:47 +0000 Received: by outflank-mailman (input) for mailman id 104177; Thu, 01 Apr 2021 08:44:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRswY-0006K7-Bo for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 08:44:46 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 37dcbb4c-1df8-41ec-904b-e7ff9b163d65; Thu, 01 Apr 2021 08:44:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 37dcbb4c-1df8-41ec-904b-e7ff9b163d65 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617266684; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=5D2x9xvQ/eqIpLFUni7fwPs6RISj+bxDXQyNeALKiBI=; b=gBkXEO0pRcgWHx75pR8tF5/VszA6iYJ6UMw0F9UDLQqdf+XbVIyub5Kq v6LtKG3LNewYzfkfokcjGAs+zYISbvDd8mEv+KNnS5kSscCJWIs/hnhkQ rrDSWMhG/h1Oqgv5+wKLqNJJhZ9Q3jp4IvSwQaGZVeOqBTMZXt3uim3hx c=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: EjYvMt54dSf9UVCTBP3+3sEKziGZjVJRq96QRgRkySvFy9GvuIqxvOcYgMWFEheGAUqT3vqs5w PMzN/0O5Wn3LJ8cSExYB4Gmy5z8fsCTX1jzvzximR2jPhCvjGOjJn+vFzLZ3lGtFMKTHAcLIyz llpuGQ8BlmTgDN45t/LaPoRP+0B9R237gdmysMasUrdmIzO/XZxcr9kKPP71y61nHBUUg0QXlc nkMqpNCsUBNuuYEqcLVEEWNbpX0QhLd4SiqZJaamb2AMOIB9Cjk+XSE01SdP6jsRrzZxhcJgOx aA8= X-SBRS: 5.2 X-MesageID: 40530448 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:3f0YGqGRlSoUrMsNpLqF/ZfXdLJzesId70hD6mlYcjYQWtCEls yogfQQ3QL1jjFUY307hdWcIsC7LE/03aVepa0cJ62rUgWjgmunK4l+8ZDvqgeLJwTXzcQY76 tpdsFFY+HYJVJxgd/mpCyxFNg9yNeKmZrY/tv25V0Fd3AIV4hL6QBlBgGHVmh/QwdbDZQ0fa DsnPZvjTymZHgRc4CHFmAINtKz6uHjubDHRVo9BxAh4BSTlj/A0tLHOjWRwxt2aUIp/Z4M6m 7A+jaZ2oyCtLWBxgbYxyvv6f1t6aPc4/9iIODJtcQPMDXrjW+TFchccpmPpio8ru3qyHtCqq irnz4aM85+62zccwiOyHODtTXI6zog52TvzlWVmxLY0LXEbQgnAMlMj58xSGq612Mcvcpx2K 8O/2WVu4s/N2KloA3B5sPFXxwvq0ysoXBKq593s1VjV+IlCIN5nMg6xgd4AZ0AFCX15MQMC+ 91FvjG6PJXa1+BK1jEo2hG2rWXLy0ONybDZnJHlt2e0jBQknw85VAf3tYnhXsF9IgwUd1t+/ nEFqhjlblITtUTBJgNXNspcI+SMCjgUBjMOGWdLRDMD6ccIUvXp5r2+rkuoMm3ZZ0zyocokp ipaiICiUcCP2bVTeGe1pxC9R7ABE+nWy7289pT45hitqe5b5DAWBfzF2wGoo+FmbEyE8fbU/ G8NNZ9GPn4N1L0FYJIxQHlH6N5DBAlIZAok+d+f2jLjtPAK4XsuOCeWu3UPqDVCjohWnnyGD 8/RzD1PtxH9V2XQXf2jxjaZmP1diXEjMhNOZmf29JW5JkGN4VKvARQo0++/NuzMjFHsrY7Zg 93J67miLqyoS2t927O5WNvJxZNEy9ukebdekIPgTVPH1L/cL4FtdnaU3tVxmG/PRN6T9nbCk pTp058/Kq2K5CKgSErEdPPCBPLs1Ij4FaxC7sMkKyK4snoPrkiCIw9Ybd8EQXQGwYwnQpxsm 9MZBUDWlTUGlrV+PmYpa1RINuaW8h3gQ+tL8IRg2nYr1+kvs0qRmEWRXqpSs6YgQEnQjBQhl F37q8HiLeMgjq0MwIE8boFGWwJTF7SLKNNDQyDaokRsKvsYhtIVmuPhSaXkVUrYWzh+18Jim GkJj3RevfWGV1Uv3Be3M/RgQFJX1TYW3g1RmFxsIV7G2iDkG10y/Wzfaa203GccB8e2ekbKi jCeiYOOQtgyNC8yQ6NlF+5ZCQb76RrGtaYIKUocrnV1H/oApaPj7s6E/hd+4sgHMzys8cQON jvNTO9HXfdMacEygaVrnEqNG1fs38/i87l3xXj8SyRwGM/O/zPO15rLotrYu203izBfbKlwZ 95hdU6sa+bKWPqcOOLzqnRcnplJg7Mp3W1C8Uls4pds653lLYbJeiabRL4kFV8mDkuJsb9k0 0TBI5h5qraB4Npd8sOPy1D+F4kk8mOMVsrvgT6DvRWRyBus1bre/eyp5bYo7smBUOM4CHqP0 OEziFb9/DZGyuPvIRqTp4YECBzUgwR+X5i9OSNe8n7EwOxbdxO+1K8Lzu4eL9ZQ66VBKUIon 9BkpW1tt7SUxC99BHbvDN9LK4L2X2gW9mODAWFHvMN9ce7N1SKiq6j+9Wykz/zVDu+Zy0j9M 54XH1VSv4GpigpjYUx3CT3YLfwuFgZn1xX5iwiikTgwZG84GDQHVhPNArQhpk+Z0gVDlG4ye D+tcSI3nX05zZInaTZHEBLZ9dUBpw7VY7sNRpjLsAWoZ+l96cimT54fR8rFmIw4QqNmd9O7P Oc4rHyU/enIWr0MVgBkAQ1e7Jcr2gOkyV8VOSQqbi6eR4aE+YUBeBX3PErrBtZ7n7p4VUabw Zkqwwv0aDAJlHqJG5EDqT1kZDojBVwntnW13Re4FNKml2mj1mAvUPShMjdgQt6k0TUshJnpa KBRDE4nSZesUp9zbZ8N2eWOFScPk+tIRf5yrAlNmZiDn1qw+I3jADbJ61OjZymyXF4xA5LSR QY0vWqD3iaRy6VCcT1IDSgGM/dOq8HX99Bfm4CJWWxLhLKh9A5SQ/JYs5o0nyX6z4zLLnLPq OtewSGCpYRuKQWJqz3WoabwcPDzBJQ+X1Xr4X1jxW+7bpXxNLeIg53qtQmdad1fg+s4Sdjy9 OWGRvVIJJ/2lChk0XxrSBDYNMGyQUcxkcX4S8WBSOzHtu2AkVsviQPxZPlTDARoPzxA+p9oC PEuxqsqXPWPAebPA23V7oB72kg+QzBTIjZ1mLKDYbZJlRX4rWhAK25nS3120vGvN2HliDZrQ 4o3mVGRxk5oj3lLug5GjPT1QQdPBVtHB83z1bn1aoZ/3d9hUgrNjYWX9IO+S31CRbaSy3o7Q 6gVQdY5sUCSStyg+MMon9DxkQlk1UQRa5nlpqOpEy2H100OTpk1p4TkU+WiMc5V35iIEf/P+ r/pcizL62Rr+ZnNiHZ6u9AMeZwZStOg6/E/eXTSSpMaAKDwLdYpCC6iS0U/hwkgM8qtEbpnY vecHzy+dZSx9A4aZM= X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="40530448" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NgI8oVoJ8Qx9zfyla7K0DFuPHxOady6KSYceNYbCofeLVtFMlcyWNytp2Oy/6Fo0biqTtEmsHPztrv2OUwB3lQnkd5QK9Mf1WmWIf684YUvQFqeNZXrWXk0JguBnOCitket03vkHsU8L3aTJz7s8COgX2fXh++3iuX66Hrg6O6ecQ20YMaAYhdu0uUdSe5CptBvtV3JqRwY+i6f1Fb8bfPT+NVphGa7CT8jMK9ELJX/z/apPpBqbCVMB4i6yZr4aoXKO2DczvAZixkjOqZXB36g2h1JG0OVnzLWedoo3SLExsCFUofPj+s+IpfoMBc1VXwnTIUzqw3+yW+GN7DSz5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BPEZlh9KDUoP9LgRoP8WHL37awvqHitPtHVi0D9l44I=; b=PhZccKvPxSb6mAQGWhRRx7K+kc4CqMvznJGw9xnMGmvrJsp/xRhITbWSmxbij0axGxCZlx19Cv6ciKJ+gEv+lRvJqbyxL1KuXSORMeBtFPNkrLBBjZ9fo0e8w6k7XPDwrHui+z8h6VmhCXS+5qASZLPW3+Zch8Ge3It+7DlF/V/J0RwLAUgD3k6CFnjIriLo7U/eu8P7XiC1nKiCTquYZOPnlgZHQJajdUqYSVOeYSHPhOAQF0/5grF0dRslUhuBQV2Mcl5z/ZNTmKtxN25/V0DpA/CAkew008nLp+ZGPbtHCkMfmEtK3XcS08by9dBZ2rSFpGfqbpWg3JCdVqY22g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BPEZlh9KDUoP9LgRoP8WHL37awvqHitPtHVi0D9l44I=; b=pIAdggDbe7WYg/+eZLag0EkhAzH1WgEC50Qu6a9KV7Dg6dO1lfCGutGp9yfcyLCJqZq7PGRg1MGuHdydQWfIM50Ek8ZDcyxt5700f81LOYLIr4hc728WNhvrfj9d1vI4ASOrLXW8iKm/imEvPHkc84rhrLq1QOms6M6KgQUW+Ro= Date: Thu, 1 Apr 2021 10:44:35 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: Roman Shaposhnik , Xen-devel , , Andrew Cooper Subject: Re: multiboot2 and module2 boot issues via GRUB2 Message-ID: References: <23baec07-a3ae-949a-a1fb-09100efd53e5@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MR2P264CA0169.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501::8) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 39967864-c3f9-4760-5dab-08d8f4ea63d9 X-MS-TrafficTypeDiagnostic: DM6PR03MB3739: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9Xk8bu+m2JPu6yluVb/mwwC6okgToCPLrEDtexn/UJWF+Hc90MaXgKh2Nm5L45jMkojwoAmBOS5RMybaTO4NNZM4Ap9RCjBXlPltgAzKh47mnB0TVB4qGmUKetqsK4fLxEyKlRRqtjVEQP5NI62p8TE2mqzLNVmIe2ccji/jAry4UAX1rVP03/QKwkgfV8dIhI6ocISEqC84B+lEYFDDXZbLrYe3RvOYyStjSEmSGmJTA0LafvJsdZiJjgZ31F4iD6BoKeHvQDrY/cILUzHymn4qskomVxNSu2K8AT68CnzxEUfAUcyzg/xl9ZT1RV7YDmKdjk14VDDcdR+ZcE9BEIJAyO88YNOpCb4RNS2pKwAPnknADrwHr86vSy4rwapFNKujjS/XX8HZQWx8nAgTV2b2qy+QJY8o/p4DcElc9JyDCGk45GUBVZT/zdi0VkzAPvYNr0BuD2f7aaFJUoSTQSbqRHf28G52pm9ye2GwkuYDvMmjxbVMQEATzu9DZTzcSPMPWAr5gnmknpOrliZMNZdVnCjJE1S5D1/BNfE6uiXqNZWNILrKfJ9rdNq1gsEcb0+WKIzUCjOmg117/d42zw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(346002)(136003)(396003)(376002)(39850400004)(366004)(8936002)(9686003)(107886003)(66556008)(33716001)(38100700001)(54906003)(478600001)(956004)(86362001)(4326008)(26005)(6666004)(66476007)(2906002)(66946007)(5660300002)(6486002)(316002)(8676002)(6496006)(53546011)(186003)(4744005)(16526019)(85182001)(6916009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?dzdZQm0vK09aU1JvR2xYcGhidGgxTEI1ZWRBMXMvWWI5b0R6ai9lb0NGWjdL?= =?utf-8?B?aHhGT1VvVXJpeWNlODFvR0Vrb2pXUXZBeE1PUXkxd3p2RklUTUU2Y0gzNWY5?= =?utf-8?B?Z2M0TUZ2TjdaZXRQa2JzakMrVVRzWjR5b0RSUi90eWl3aThBNUJPS1dINnhI?= =?utf-8?B?Wld5ZjV4YWpOL3lldysydk9Uc1dMakIza0FRR0pFTjRIWUl6YVVZaW5yZmRw?= =?utf-8?B?ZHptcEpXQXNCa1phL2UvaUR0YW9LUFRoMzQyZHpmS0xiQnpKVFE1eGY3NW5D?= =?utf-8?B?MWJrTXdHTmV6YUY2ejFUTmt6K1paQlFhZkV4K1h1RTBHOFIzVk5Sb2NLZzMw?= =?utf-8?B?dmM1TmZNTFY4WHltaUVaZ1hTTTROTmNHMmpWVGdKM0svakFTTE51Z1UzNVd6?= =?utf-8?B?S1hYQi9KTWpDYW9Fb1d5cFpFSmN0Nyt5MnB3ZGhUbkgwK0NHajFvZ0YvR1FM?= =?utf-8?B?NFpXVjF5MW5zbXE2Mnh1UTU2Sk80UUp4WmVYYVN3dld3dWJ6eTA1WWxMc2Fn?= =?utf-8?B?OEdYbEtiaWExeVZQeERmVUR6eGhDelRvcXVvYS9RRXNNSitsaWJvVTIwTGZk?= =?utf-8?B?N2Y4NS81Uko3dWtOd0lGbkJva0RqQ0RUNzY1dWlyaDh0NTU0emlsVnlubE5s?= =?utf-8?B?UFNNRmt2ZW9RbUFZelRSN2ZsMUo1ems2WEttaWw1VFZSK2lNT0lMbUlLNmho?= =?utf-8?B?MlU3WFovWS9EWW1NZkM1ZkdTMkR1MTJzZ3lmNVBwUml3NVc5dHpXNlpJcmNU?= =?utf-8?B?MENSKzVVeWNIdjRUUFpXaHJMN2JKa0JGUUZncDhQYSt0YUNvSFFVZmswTnJr?= =?utf-8?B?TDlVSmNMNGx6dFVzeGRFY0prTWR4WEREQW85UWRXenVOa2NGU3h1bTdSNEpJ?= =?utf-8?B?cjdZYzZheWVKK3QwamU4eWRLKzhkV0o0Qm9JQmVIMVpsV1NEVFlEczBFYjZV?= =?utf-8?B?QlVmS3JFVjRORG9seCtURnR1cjhZV1Fna3VwQnBYZC9VK2hjR00vT3RHVWo4?= =?utf-8?B?OW9SSk5weVJoai9wM0lROHkxQ05VZXhyNm9OYWtLSVl0WUlCeXNMbWcrN2to?= =?utf-8?B?SW1RL2VseTJESk1qdmdPRFAyakJXNnllZG5nOG5CdmZJMktZeE9yV0Rnc25i?= =?utf-8?B?RkVHd3pWYWpoK2x5UzRJTjF1encvTjdjQ2lVUXkvM0NIS0l2MWw1enZVamJa?= =?utf-8?B?cXRmR0tKcEgzeldNeElzMVloNjhxL1hoWkMzaUFLcEZiVUQ5YlBIUW9FSkNI?= =?utf-8?B?SjlMaDE4UC80TVcxcWhsZGdYanZKSWhNZ3dSMTcrU2JJY2p5OXBVMmtMNmZ5?= =?utf-8?B?VWIrbi9jS05WSElNZ0FBSnBvb1phYUxheVVFdTNQa25nVFFWRTlBRVNPcjZs?= =?utf-8?B?dEdpUW5xbzFiNlo0SkVQOSsvU21tUVZWN2ZIMjJwWmJieitrTGVHT3FtVTZl?= =?utf-8?B?SmJ5cjZFMDF3LzcrNHVJMHNYcDJUYzNranZFckgxNTc5aHFqMWhESEt5NURX?= =?utf-8?B?U2RoNlUrem5Pc3A3U09tRHhMdmNDenAyZ0k2YU5yeEVDVHNzK040YlVCL1Bk?= =?utf-8?B?eWFEck9FdUlRdFhDSlc2YlY1OWhzN3hmSVA1Q0NTMVRGTVRkUHB6OG5iM0hT?= =?utf-8?B?OEZxU2JpVUdrTzNWb3pyb1ptWEZTVEJLVXYyQVNCbkVKUk9rbzdwV01GaUpH?= =?utf-8?B?ZDN0NFlMam9McCtrdU9PTUhuY2RqWGtkQld4emp4dEIzaDdYVXB1ZlJVQ1dx?= =?utf-8?B?KzNTOW0rd2ZwTTVaM052czhHcEVzb3ljUXArN0NuVUJBRjg2NWFkQlRXUmdC?= =?utf-8?B?dGc4d1JISVB5UitQUnJhZz09?= X-MS-Exchange-CrossTenant-Network-Message-Id: 39967864-c3f9-4760-5dab-08d8f4ea63d9 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 08:44:40.8535 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: e52TnFDO9K3G5XbPdCr/iHkdvYW9tV6i4PWyJebbBC14oXn4WCM0I7INbYaP9kVWDF8dhMJ6V9CUEMZJ5Rs68w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3739 X-OriginatorOrg: citrix.com On Thu, Apr 01, 2021 at 09:31:07AM +0200, Jan Beulich wrote: > On 01.04.2021 03:06, Roman Shaposhnik wrote: > > And the obvious next question: is my EVE usecase esoteric enough that > > I should just go ahead and do a custom GRUB patch or is there a more > > general interest in this? > > Not sure if it ought to be a grub patch - the issue could as well > be dealt with in Xen, by concatenating modules to form a monolithic > initrd. I would rather have it done in the loader than Xen, mostly because it's a Linux boot specific format, and hence I don't think Xen should have any knowledge about it. If it turns out to be impossible to implement on the loader side we should consider doing it in Xen, but that's not my first option. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Apr 01 08:44:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 08:44:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104179.198948 (Exim 4.92) (envelope-from ) id 1lRswk-0006QM-RW; Thu, 01 Apr 2021 08:44:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104179.198948; Thu, 01 Apr 2021 08:44:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRswk-0006QE-OK; Thu, 01 Apr 2021 08:44:58 +0000 Received: by outflank-mailman (input) for mailman id 104179; Thu, 01 Apr 2021 08:44:57 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRswi-0006Pc-VZ for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 08:44:57 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 9ede36b3-4053-4dfe-8ccb-620126c57cad; Thu, 01 Apr 2021 08:44:56 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 777A5AE8D; Thu, 1 Apr 2021 08:44:55 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9ede36b3-4053-4dfe-8ccb-620126c57cad X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617266695; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QXGl+Z7RFWWbp6so6Tz4DSduWEpNaC1fGMoL4+RAnfw=; b=YFqKBl8t+X/fp14wXCvuISzEcX96Oj9LnuDL2GWTfM3/HrsQUMIjDGkExvaym5vw4XqXoX 4ubzo1mMMNqI4gqSKFqmZNSyI4D5z7MTk/X3mBXtFZUfXTLc0YBDGnqWl2FjrixmG9td7/ oF04HydMdM6Y2Fme5BTCtNDRK/IaF2k= Subject: [PATCH 3/6] VT-d: bring print_qi_regs() in line with print_iommu_regs() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Kevin Tian References: <157e4a65-6d0b-7ea8-1c23-cd393c8c0d7f@suse.com> Message-ID: Date: Thu, 1 Apr 2021 10:44:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <157e4a65-6d0b-7ea8-1c23-cd393c8c0d7f@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Shorten the names printed. There's also no need to go through a local variable. While at it also constify the function's parameter. Signed-off-by: Jan Beulich --- a/xen/drivers/passthrough/vtd/qinval.c +++ b/xen/drivers/passthrough/vtd/qinval.c @@ -33,18 +33,11 @@ static int __must_check invalidate_sync(struct vtd_iommu *iommu); -static void print_qi_regs(struct vtd_iommu *iommu) +static void print_qi_regs(const struct vtd_iommu *iommu) { - u64 val; - - val = dmar_readq(iommu->reg, DMAR_IQA_REG); - printk("DMAR_IQA_REG = %"PRIx64"\n", val); - - val = dmar_readq(iommu->reg, DMAR_IQH_REG); - printk("DMAR_IQH_REG = %"PRIx64"\n", val); - - val = dmar_readq(iommu->reg, DMAR_IQT_REG); - printk("DMAR_IQT_REG = %"PRIx64"\n", val); + printk(" IQA = %"PRIx64"\n", dmar_readq(iommu->reg, DMAR_IQA_REG)); + printk(" IQH = %"PRIx64"\n", dmar_readq(iommu->reg, DMAR_IQH_REG)); + printk(" IQT = %"PRIx64"\n", dmar_readq(iommu->reg, DMAR_IQT_REG)); } static unsigned int qinval_next_index(struct vtd_iommu *iommu) From xen-devel-bounces@lists.xenproject.org Thu Apr 01 08:45:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 08:45:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104184.198960 (Exim 4.92) (envelope-from ) id 1lRsx3-0006Y1-62; Thu, 01 Apr 2021 08:45:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104184.198960; Thu, 01 Apr 2021 08:45:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRsx3-0006Xu-2S; Thu, 01 Apr 2021 08:45:17 +0000 Received: by outflank-mailman (input) for mailman id 104184; Thu, 01 Apr 2021 08:45:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRsx2-0006Xi-Cq for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 08:45:16 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f0586108-a1c4-4fbc-976c-8edaee73635d; Thu, 01 Apr 2021 08:45:15 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DE21BAF28; Thu, 1 Apr 2021 08:45:14 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f0586108-a1c4-4fbc-976c-8edaee73635d X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617266715; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Oa+4GqEAwgAdkWZtpOQ4w42vy8M9iwn2JbhahcRbFHk=; b=p4bdMQfAUysFNQynw9wXfroabi+6rKY/aIIN+h8kgvJbfnyKUolIWMUHub1Stm3KeUKcQn zYBbTrL+x61AgBP/SOdhOY0NZhTcNBYA6CtEUfgt5F8LNTHgez5osoN0kGfcAWSN7CF+S6 ZLISuj2XfJnjNEY3S3KdqcpJVh0RKN8= Subject: [PATCH 4/6] VT-d: qinval indexes are only up to 19 bits wide From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Kevin Tian References: <157e4a65-6d0b-7ea8-1c23-cd393c8c0d7f@suse.com> Message-ID: Date: Thu, 1 Apr 2021 10:45:14 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <157e4a65-6d0b-7ea8-1c23-cd393c8c0d7f@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit There's no need for 64-bit accesses to these registers (outside of initial setup and dumping). Also remove some stray blanks. Signed-off-by: Jan Beulich --- a/xen/drivers/passthrough/vtd/qinval.c +++ b/xen/drivers/passthrough/vtd/qinval.c @@ -42,14 +42,13 @@ static void print_qi_regs(const struct v static unsigned int qinval_next_index(struct vtd_iommu *iommu) { - u64 tail; + unsigned int tail = dmar_readl(iommu->reg, DMAR_IQT_REG); - tail = dmar_readq(iommu->reg, DMAR_IQT_REG); tail >>= QINVAL_INDEX_SHIFT; /* (tail+1 == head) indicates a full queue, wait for HW */ - while ( ( tail + 1 ) % QINVAL_ENTRY_NR == - ( dmar_readq(iommu->reg, DMAR_IQH_REG) >> QINVAL_INDEX_SHIFT ) ) + while ( (tail + 1) % QINVAL_ENTRY_NR == + (dmar_readl(iommu->reg, DMAR_IQH_REG) >> QINVAL_INDEX_SHIFT) ) cpu_relax(); return tail; @@ -57,12 +56,12 @@ static unsigned int qinval_next_index(st static void qinval_update_qtail(struct vtd_iommu *iommu, unsigned int index) { - u64 val; + unsigned int val; /* Need hold register lock when update tail */ ASSERT( spin_is_locked(&iommu->register_lock) ); val = (index + 1) % QINVAL_ENTRY_NR; - dmar_writeq(iommu->reg, DMAR_IQT_REG, (val << QINVAL_INDEX_SHIFT)); + dmar_writel(iommu->reg, DMAR_IQT_REG, val << QINVAL_INDEX_SHIFT); } static int __must_check queue_invalidate_context_sync(struct vtd_iommu *iommu, From xen-devel-bounces@lists.xenproject.org Thu Apr 01 08:45:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 08:45:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104188.198972 (Exim 4.92) (envelope-from ) id 1lRsxQ-0006fh-Ga; Thu, 01 Apr 2021 08:45:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104188.198972; Thu, 01 Apr 2021 08:45:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRsxQ-0006fa-Cy; Thu, 01 Apr 2021 08:45:40 +0000 Received: by outflank-mailman (input) for mailman id 104188; Thu, 01 Apr 2021 08:45:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRsxP-0006ea-Os for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 08:45:39 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c655badc-64b4-4a19-a25d-c955f41f23d5; Thu, 01 Apr 2021 08:45:35 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C5355AEFB; Thu, 1 Apr 2021 08:45:34 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c655badc-64b4-4a19-a25d-c955f41f23d5 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617266734; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U0UO+wcl/jJCDP3esQE6oeXB/el7db31934Dib0PPcY=; b=ssFYZXkOpDDuCBuV8ar2q5Oy2a+BYqVUl/Y8nlVS6h0oQX3+2zYyEY439LwNm3qooOBYm0 c/WZh7B6lp9mTmcPNRLO0l37Ih8O/u7vclO6KIOiE/NDIUzqtzukR5o6OjMVvdtTnLPrQ1 ZmUB5IdTwQKyUQvVzuFczKqXD1oHwFs= Subject: [PATCH 5/6] VT-d: avoid pointless use of 64-bit constants From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Kevin Tian References: <157e4a65-6d0b-7ea8-1c23-cd393c8c0d7f@suse.com> Message-ID: Date: Thu, 1 Apr 2021 10:45:34 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <157e4a65-6d0b-7ea8-1c23-cd393c8c0d7f@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit When the respective registers are just 32 bits wide there's no point in making corresponding constants 64-bit ones. Signed-off-by: Jan Beulich --- a/xen/drivers/passthrough/vtd/iommu.h +++ b/xen/drivers/passthrough/vtd/iommu.h @@ -121,30 +121,30 @@ #define DMA_TLB_IVA_HINT(x) ((((u64)x) & 1) << 6) /* GCMD_REG */ -#define DMA_GCMD_TE (((u64)1) << 31) -#define DMA_GCMD_SRTP (((u64)1) << 30) -#define DMA_GCMD_SFL (((u64)1) << 29) -#define DMA_GCMD_EAFL (((u64)1) << 28) -#define DMA_GCMD_WBF (((u64)1) << 27) -#define DMA_GCMD_QIE (((u64)1) << 26) -#define DMA_GCMD_IRE (((u64)1) << 25) -#define DMA_GCMD_SIRTP (((u64)1) << 24) -#define DMA_GCMD_CFI (((u64)1) << 23) +#define DMA_GCMD_TE (1u << 31) +#define DMA_GCMD_SRTP (1u << 30) +#define DMA_GCMD_SFL (1u << 29) +#define DMA_GCMD_EAFL (1u << 28) +#define DMA_GCMD_WBF (1u << 27) +#define DMA_GCMD_QIE (1u << 26) +#define DMA_GCMD_IRE (1u << 25) +#define DMA_GCMD_SIRTP (1u << 24) +#define DMA_GCMD_CFI (1u << 23) /* GSTS_REG */ -#define DMA_GSTS_TES (((u64)1) << 31) -#define DMA_GSTS_RTPS (((u64)1) << 30) -#define DMA_GSTS_FLS (((u64)1) << 29) -#define DMA_GSTS_AFLS (((u64)1) << 28) -#define DMA_GSTS_WBFS (((u64)1) << 27) -#define DMA_GSTS_QIES (((u64)1) <<26) -#define DMA_GSTS_IRES (((u64)1) <<25) -#define DMA_GSTS_SIRTPS (((u64)1) << 24) -#define DMA_GSTS_CFIS (((u64)1) <<23) +#define DMA_GSTS_TES (1u << 31) +#define DMA_GSTS_RTPS (1u << 30) +#define DMA_GSTS_FLS (1u << 29) +#define DMA_GSTS_AFLS (1u << 28) +#define DMA_GSTS_WBFS (1u << 27) +#define DMA_GSTS_QIES (1u << 26) +#define DMA_GSTS_IRES (1u << 25) +#define DMA_GSTS_SIRTPS (1u << 24) +#define DMA_GSTS_CFIS (1u << 23) /* PMEN_REG */ -#define DMA_PMEN_EPM (((u32)1) << 31) -#define DMA_PMEN_PRS (((u32)1) << 0) +#define DMA_PMEN_EPM (1u << 31) +#define DMA_PMEN_PRS (1u << 0) /* CCMD_REG */ #define DMA_CCMD_INVL_GRANU_OFFSET 61 @@ -164,21 +164,23 @@ #define DMA_CCMD_CAIG_MASK(x) (((u64)x) & ((u64) 0x3 << 59)) /* FECTL_REG */ -#define DMA_FECTL_IM (((u64)1) << 31) +#define DMA_FECTL_IM (1u << 31) /* FSTS_REG */ -#define DMA_FSTS_PFO ((u64)1 << 0) -#define DMA_FSTS_PPF ((u64)1 << 1) -#define DMA_FSTS_AFO ((u64)1 << 2) -#define DMA_FSTS_APF ((u64)1 << 3) -#define DMA_FSTS_IQE ((u64)1 << 4) -#define DMA_FSTS_ICE ((u64)1 << 5) -#define DMA_FSTS_ITE ((u64)1 << 6) -#define DMA_FSTS_FAULTS DMA_FSTS_PFO | DMA_FSTS_PPF | DMA_FSTS_AFO | DMA_FSTS_APF | DMA_FSTS_IQE | DMA_FSTS_ICE | DMA_FSTS_ITE +#define DMA_FSTS_PFO (1u << 0) +#define DMA_FSTS_PPF (1u << 1) +#define DMA_FSTS_AFO (1u << 2) +#define DMA_FSTS_APF (1u << 3) +#define DMA_FSTS_IQE (1u << 4) +#define DMA_FSTS_ICE (1u << 5) +#define DMA_FSTS_ITE (1u << 6) +#define DMA_FSTS_FAULTS (DMA_FSTS_PFO | DMA_FSTS_PPF | DMA_FSTS_AFO | \ + DMA_FSTS_APF | DMA_FSTS_IQE | DMA_FSTS_ICE | \ + DMA_FSTS_ITE) #define dma_fsts_fault_record_index(s) (((s) >> 8) & 0xff) /* FRCD_REG, 32 bits access */ -#define DMA_FRCD_F (((u64)1) << 31) +#define DMA_FRCD_F (1u << 31) #define dma_frcd_type(d) ((d >> 30) & 1) #define dma_frcd_fault_reason(c) (c & 0xff) #define dma_frcd_source_id(c) (c & 0xffff) From xen-devel-bounces@lists.xenproject.org Thu Apr 01 08:45:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 08:45:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104190.198984 (Exim 4.92) (envelope-from ) id 1lRsxg-0006lq-PK; Thu, 01 Apr 2021 08:45:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104190.198984; Thu, 01 Apr 2021 08:45:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRsxg-0006lh-LU; Thu, 01 Apr 2021 08:45:56 +0000 Received: by outflank-mailman (input) for mailman id 104190; Thu, 01 Apr 2021 08:45:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRsxf-0006lL-IS for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 08:45:55 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4b40a4a9-cb32-4a9a-8f79-f2e4d4d12201; Thu, 01 Apr 2021 08:45:55 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3AB96B06A; Thu, 1 Apr 2021 08:45:54 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4b40a4a9-cb32-4a9a-8f79-f2e4d4d12201 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617266754; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sz7pYz3SSChzPfaCLOKsspYeFrYrOKDDv1mzKeQ9WSc=; b=C5WivcIWPbxFb6n70fdiFuFmF4fq79Pu1zMvQzJiACePVHeSlekCBdlwsPuqPU1cSV2Xsl aR5QJ1ZXPtr7eXm/7eRGmZXZeT0PMQLhouqcMw5zxFu2JADtp5XulLevIiYMy5KbO/+Nek ucvVtRFVaVzMChaOiI2ODEpPqTA22A0= Subject: [PATCH 6/6] VT-d: drop unused #define-s From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Kevin Tian References: <157e4a65-6d0b-7ea8-1c23-cd393c8c0d7f@suse.com> Message-ID: <38aab031-d9a3-dfa2-9958-ec625a0ce042@suse.com> Date: Thu, 1 Apr 2021 10:45:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <157e4a65-6d0b-7ea8-1c23-cd393c8c0d7f@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Signed-off-by: Jan Beulich --- a/xen/drivers/passthrough/vtd/iommu.h +++ b/xen/drivers/passthrough/vtd/iommu.h @@ -471,26 +471,12 @@ struct qinval_entry { /* Queue invalidation head/tail shift */ #define QINVAL_INDEX_SHIFT 4 -#define qinval_present(v) ((v).lo & 1) -#define qinval_fault_disable(v) (((v).lo >> 1) & 1) - -#define qinval_set_present(v) do {(v).lo |= 1;} while(0) -#define qinval_clear_present(v) do {(v).lo &= ~1;} while(0) - -#define RESERVED_VAL 0 - #define TYPE_INVAL_CONTEXT 0x1 #define TYPE_INVAL_IOTLB 0x2 #define TYPE_INVAL_DEVICE_IOTLB 0x3 #define TYPE_INVAL_IEC 0x4 #define TYPE_INVAL_WAIT 0x5 -#define NOTIFY_TYPE_POLL 1 -#define NOTIFY_TYPE_INTR 1 -#define INTERRUTP_FLAG 1 -#define STATUS_WRITE 1 -#define FENCE_FLAG 1 - #define IEC_GLOBAL_INVL 0 #define IEC_INDEX_INVL 1 #define IRTA_EIME (((u64)1) << 11) From xen-devel-bounces@lists.xenproject.org Thu Apr 01 08:48:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 08:48:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104197.198995 (Exim 4.92) (envelope-from ) id 1lRszt-00070e-C9; Thu, 01 Apr 2021 08:48:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104197.198995; Thu, 01 Apr 2021 08:48:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRszt-00070X-90; Thu, 01 Apr 2021 08:48:13 +0000 Received: by outflank-mailman (input) for mailman id 104197; Thu, 01 Apr 2021 08:48:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRszr-00070O-BJ for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 08:48:11 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 54ea3bfb-de98-450b-b3c4-23f6b2c46a20; Thu, 01 Apr 2021 08:48:09 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 54ea3bfb-de98-450b-b3c4-23f6b2c46a20 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617266889; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=ycESowqVYSX6sOd3+5kZmSuk1kAnamQnVGJeMtY0Z+I=; b=aPGdwughSMSVU8RGFBJGTkZduqCMZLbDRkzrV6gJS2+XMI8kbyvoFPbY z1sDSm8Ukh0qiKIzSI68gkvfi3HxdueW7xfQp37zhZMj6px16zgP3zAKv aVx3c6qmVK3vxaD83YkcKo7s8h0K3EKxDBoJj3gc2NcQ/TvVrPaMVeuMf w=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 6pGHwN491dY/sBdxrtQZ5zgn3uRge0bE9xgLF62jz4w/Sko483q7nMj/aeeyKF2Mf6idf58P91 rq3Ako9dpDFarf/BPCkf1PsrcmM2F9ZT0wi1LhrtZnZxSrrhTK4YOba0h7BF0oWW0ThMeiNNTH iiOsWVJgbQWym5lWuC6ciS3/Ul0XT0xs5nBkvWGwqV7HmWo1SyYlNWxLRMbwnHadS6Rm2ptvxx W5O9pZsenWHn5E8JtgUOFMV9RrFar44P+HoZ0/VJnREuWIcIF8wLyWGrSowDrzFS1L90PTGGil HqM= X-SBRS: 5.2 X-MesageID: 40807053 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:fBIx+6tR+1S6RWoAoNJB2xrJ7skCIIMji2hD6mlwRA09T+Wzna mV7Y0m/DXzjyscX2xlpMCYNMC7MAvh3LNWwa1UB7etWwH6pHClRbsJ0aLOyyDtcheOk9J1+r xnd8FFeb/NJHh8yf33+QypV+snqeP3k5yAocf74zNTQRpxa6dmhj0ZNi++HldtTAdLQboVfa DsgvZvnDardXQJYsnTPBBsNNTrnNHFmInrZhQLHXcciDWmty+i67LxDnGjr3Ajeg5IqI1Sl1 TtokjW4uGGv+ugwhHRk1XP54lb8eGM9vJzQOKLjMYRJnHAqCaNIL5gVbqLoSwvrIiUhWoCoZ 3jpREvOsg20XfNZyWOpwf30QWI6lkTwk6n8lOTjXv9rcGRflwHN/Y= X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="40807053" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e/iPIqtm/rwsVrPnt4dnursB8qN8NAtYroNr9M9GhXZRO2uO+s1H3oQ/fh240Hi3OnDvn15MzERZ9nNrSNmeVkBqVSobZ3meE7FF+yy5bhc0/DIxiUjVln6jsgWKMTvOQSgCud/DGQEEErgbrcGs5CKP4Qg/MKzpUzWQlfKBih/U6u+TWhu75yy4vTjD95QLDb/qmyQvDU53DGvAgOiIgCEekJSdVHFFhKDm1uimyKJ6gLJuQXoOuQATnVLUcziuTBjCqSwhpVDAMpIIFWBXlkSd5IixR4CGRqjApb1IlUQHGmwJbVmFstDVU1JDATAb8BJTHFaCMMN+iiM41k6GWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UUcEZb4vYsSnIknMdrcaUmgBNIX+6bgQlq5dQ+9sTIM=; b=QvNEo4lGPx0WbEIX/gk/fkTNMJc8L+F6lDJyEq6FY0182ypkhOryZtNT5L1aHxi5paHACQNV95fi9QbYnCyGk+FVNzOVkRaB/IytMBavvHD2gZ70RNJFeBTW284skQWhXq99WfUHI7nhVe9PseuA9ff7owFPL1hP4je+aa1q3pBOrAllLG6PusoWiux0U4E6i4u5PXaphvrzt9RTBVgIx5h6xYowioD1cU5b06zKCBJMQXJs4YK77jJUh2XfgAslgt7qI5ysA+MHCuHK5G+kwU8O3pJvD3hVv4YICkuSKjl9QhPNUfIkrPMMZIgpRGzyBe/CkqIZSTEHEgmL3QBeZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UUcEZb4vYsSnIknMdrcaUmgBNIX+6bgQlq5dQ+9sTIM=; b=uxPLG38u5tacv8P/QNTZOvibr5B2fry4bn63WmZ9W2G23Zp+PjPpkKCSqSW6tkHTynyjCl4dPsPFM+5xWo/R0SHqOqYskPlDe4JHMomEZO3KNBEPC5gx52cUxQpBRmkDTQ+govbWMe1kTH4kGLQa4BMu3PgVVMJGMYC9rgFGFYY= Date: Thu, 1 Apr 2021 10:48:00 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper CC: , Ian Jackson , Wei Liu Subject: Re: [PATCH 03/21] libs/guest: introduce xc_cpu_policy_t Message-ID: References: <20210323095849.37858-1-roger.pau@citrix.com> <20210323095849.37858-4-roger.pau@citrix.com> <7f52bd98-24fd-95ba-f8c6-05a331941b49@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7f52bd98-24fd-95ba-f8c6-05a331941b49@citrix.com> X-ClientProxiedBy: MRXP264CA0009.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:15::21) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1125c19e-7626-47b7-8b23-08d8f4eade4e X-MS-TrafficTypeDiagnostic: DS7PR03MB5591: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ec+SsOJojLakCyvyrDxvvpKBhc736buEVp2Jm0GkkGI1JS6dF9vG9s0xEl9PiqaV+LsShkF0L2uM5SMMk4utPevU84bnfXyR/xoSAXg52rGlYtEIe+zDcF+oavaIINAFfPUybPb0y/ooO1faZqnwsI55TOu/8vWSfh2gaW3JRZQfypicFSm8d0TUUYNujCMZBHkMcFYX5h8xxs8VDAH16krcCRzB6EkrB8di/u3mm+gssT+4fenzhQLkgou2g7AuoNY5ucXeSrTiTTE0ixsuhxLMzVPQLrzW2CEFmySHIUGOJwBC3bCFcG2uWAjFzsFmz9elHB+63J66pUgJqqh2xd76jlCT6PDrRbRarHVwrtDc0tK+NWOFrn8dkqm+rkFJGgmN3IWKGsxxAYS44yNObtu/LeP3Q/nKZF6TfjOeXX3WwBGz76RneZq3DP0aPdNmlf2Osg0TR5KanKtDFZ7eRZwD6FYeE3/JNRXoIf1dxvb5he9TdSVjNE3pMeEUBJodk2gMtXqTJLNMWdIblUoZ7jYQlnVkKmheYQCDdBNGLtJin5YYWC8DBnvoxUkAkdSTygvOovxnM6FQ4Zvl5871jYNrJZ8HUA4uYO0RRnwU/QvN2cYyrzUCZMFgYNTYz9ZL2dnnUQScinBaG/AFbAZmrmQccaLDkhjtgUQt8F1AmaE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(376002)(366004)(346002)(136003)(396003)(39850400004)(54906003)(86362001)(316002)(38100700001)(85182001)(66556008)(6862004)(478600001)(6636002)(186003)(6496006)(8936002)(26005)(4326008)(53546011)(9686003)(33716001)(6486002)(66946007)(6666004)(16526019)(8676002)(5660300002)(2906002)(956004)(66476007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Z3h2amRSeTlYY3ZnYTJMaGRLeHRCUnJhYThrVUpzSjI5VmtwREltQlRVMmZ4?= =?utf-8?B?RWs1V0JjSFVlVHc4TmwwSDFUK1VKTWlleHJnRS94ZVc1Nk9pZ0JYN09zQ3hx?= =?utf-8?B?Z25ScFVxaE9mV0tyRFRtMnJSY0dBcDE3TmJzRVUwd0tNSTRYWHJTVVlyWDZv?= =?utf-8?B?RUNxakhrcWxIVDRpUjVNeHBsSlh4MngrN05uVnV1TFNNK1pYR2d6ZEdXL3J1?= =?utf-8?B?SElJTEJSVEc1alZrMHFJKzdXbmR3d0taaklmemFHNmI2U0FGVWRKQ2hIMXUw?= =?utf-8?B?NFNmYTU0Y0RTRzNnQy8wNDZvY0Q5QkpZNFJ6dkMxSDJYUjZHYlByR2FlWktu?= =?utf-8?B?ZHRIRXBuRk1kd0swYWJQR0VPQXBtV1pQaGovWjJJRS91Z0l6dHJtbFpUY29o?= =?utf-8?B?T3NTY3RmV2FCa2ZNRG5LRDMzamM3bHhXL2pRcTVDOEhTcTEyeFhFT0djT2Jl?= =?utf-8?B?UjRxRDM1RmV6Vk5xMU1kdUUwbmVYcER0eWpVaTZ2UTh1bW81Y0ltV3NVRkdl?= =?utf-8?B?VUE0NmtNNEVNc0FxdUNtNitGUU5iMjB2dDN4dkJZRHN1cy8yMlVrOGJtUjcy?= =?utf-8?B?LzZycEIzTlUvMlg5d1kzaEliaU9KWDBrVjgwdVI4cm5PaFJndFFIL2hhUU5Y?= =?utf-8?B?cksyNWcvaThuQm1yWUphSGRlUi9ZT0p3ZklIVFpDMEVzOEp1ajl4T2FNczhM?= =?utf-8?B?dk93N3NSNWg1Y0V4aEZMcDBKN1hweWxIME1BZVBNbkJGV2JsVkl2OGdqMjVM?= =?utf-8?B?SENIOUJlWWltck10MGl1WjBWa2xZOVN3Y2Q1d05kN0pYVUl5cnF0dEs1cU4y?= =?utf-8?B?QnNHTFd6Y1dQWVlUM0RmNldhK1FnN0F0Ump2Q0x2R1hxRGpsTXorMEN6NEUz?= =?utf-8?B?c0ZuNzRTb3ZyMFZTR2p6RlNCV1BEaWZhdFBuNW1paTNCRDJ4SlhyV3FtTmk0?= =?utf-8?B?aWIvMElrYXZhaFZtUE1vTUdzYU1wRCtHc2Q4bTE5QUwyRENlOVlTY2FKZmho?= =?utf-8?B?RlltSVBGRHBGTXJqTVgvZjVUd1EwbFNmUkxCRUhmRDhOcjQ4dG1qZjZWSDJS?= =?utf-8?B?YSt3a1B0bFdScEtxcjFGdjJ2UzRJMm92N2JGcFJ3RHhWb2tDR20xTm0rWkNU?= =?utf-8?B?YjRweDMvMm9iU2RTYnhxK2pvcExTckxoZFc5ZGJDRnpWUTAxTlMzMmw4MEJ5?= =?utf-8?B?NHdtTGZTUWFBVWlOOHY0aTJaaFJqOFNmTStQR1ZwVTRJb0paMnMxT2RRb1FW?= =?utf-8?B?NDFDYmk5OG12ei9kRmxrTzVub0NkM0svRmVWTXFZd2RlV2VCbjNiYnJWNjJa?= =?utf-8?B?T3dWZTlnS0VrVW1ZTnZ1ejhXSmxBR2loY3ZsaXJPQkE3SjV2Z0k5QXNVd0or?= =?utf-8?B?QTZRRkZkakI3SEtYanh3MTQxQ3pZOGJDQWdoYVlIaFBjdHdFaGpWblRNQzBi?= =?utf-8?B?S0p5NHg3WWxlMS9rSTRVcGhEQ3JISmVtSUVZTGxWcUp2b01Qakw0dWNwY2tx?= =?utf-8?B?R1dmbWNwaXV1VWFxUWhBalp0YUk2ckFnMGdoOGlNKzhoeGpZVTdTN05EWHFo?= =?utf-8?B?Qm1xNUFjNFQ1R1gzUFpoOTRsRGlLOVNlOXJmaENLa1dETy9OY2hWODdXWnoz?= =?utf-8?B?aHBMblJOL1lUcDNTOGJwaWNGNEw0d21xblFCT1ZXUzNwMHpZc0Fucjd2K0Y3?= =?utf-8?B?VkZJbmFHSVNCNGtMMkRQbk80ODBIQlhLRHlKWk92U3gwU2dkVUROdElRcGVn?= =?utf-8?B?Zm9Cc3IyWG04UTJieXBvcVBWOTRweVZta3VidFhHQ09uV2NCc3pDK09nNVRB?= =?utf-8?B?YVkzQXJaZ1RuVTRIc1I0dz09?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1125c19e-7626-47b7-8b23-08d8f4eade4e X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 08:48:06.4229 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7fEMHS8be/3w1ZtBodqoG4pUgM1KLddxNPDK3ukQCGbF9kOrJ7svJFjhyg45ZoUcw2rwX2R2aH+FwYVisBZsdw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5591 X-OriginatorOrg: citrix.com On Wed, Mar 31, 2021 at 09:10:13PM +0100, Andrew Cooper wrote: > On 23/03/2021 09:58, Roger Pau Monne wrote: > > Introduce an opaque type that is used to store the CPUID and MSRs > > policies of a domain. Such type uses the existing cpu_policy structure > > to store the data, but doesn't expose the type to the users of the > > xenguest library. > > > > Introduce an allocation (init) and freeing function (destroy) to > > manage the type. > > > > Note the type is not yet used anywhere. > > > > Signed-off-by: Roger Pau Monné > > --- > > tools/include/xenctrl.h | 6 ++++++ > > tools/libs/guest/xg_cpuid_x86.c | 28 ++++++++++++++++++++++++++++ > > 2 files changed, 34 insertions(+) > > > > diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h > > index e91ff92b9b1..ffb3024bfeb 100644 > > --- a/tools/include/xenctrl.h > > +++ b/tools/include/xenctrl.h > > @@ -2590,6 +2590,12 @@ int xc_psr_get_domain_data(xc_interface *xch, uint32_t domid, > > int xc_psr_get_hw_info(xc_interface *xch, uint32_t socket, > > xc_psr_feat_type type, xc_psr_hw_info *hw_info); > > > > +typedef struct cpu_policy *xc_cpu_policy_t; > > + > > +/* Create and free a xc_cpu_policy object. */ > > +xc_cpu_policy_t xc_cpu_policy_init(void); > > +void xc_cpu_policy_destroy(xc_cpu_policy_t policy); > > + > > int xc_get_cpu_levelling_caps(xc_interface *xch, uint32_t *caps); > > int xc_get_cpu_featureset(xc_interface *xch, uint32_t index, > > uint32_t *nr_features, uint32_t *featureset); > > diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c > > index 9846f81e1f1..ade5281c178 100644 > > --- a/tools/libs/guest/xg_cpuid_x86.c > > +++ b/tools/libs/guest/xg_cpuid_x86.c > > @@ -659,3 +659,31 @@ out: > > > > return rc; > > } > > + > > +xc_cpu_policy_t xc_cpu_policy_init(void) > > +{ > > + xc_cpu_policy_t policy = calloc(1, sizeof(*policy)); > > + > > + if ( !policy ) > > + return NULL; > > + > > + policy->cpuid = calloc(1, sizeof(*policy->cpuid)); > > + policy->msr = calloc(1, sizeof(*policy->msr)); > > + if ( !policy->cpuid || !policy->msr ) > > + { > > + xc_cpu_policy_destroy(policy); > > + return NULL; > > + } > > + > > + return policy; > > +} > > + > > +void xc_cpu_policy_destroy(xc_cpu_policy_t policy) > > +{ > > + if ( !policy ) > > + return; > > + > > + free(policy->cpuid); > > + free(policy->msr); > > + free(policy); > > +} > > Looking at the series as a whole, we have a fair quantity of complexity > from short-lived dynamic allocations. > > I suspect that the code would be rather better if we had > > struct xc_cpu_policy { >     struct cpuid_policy cpuid; >     struct msr_policy msr; >     xen_cpuid_leaf_t leaves[CPUID_MAX_SERIALISED_LEAVES]; >     xen_msr_entry_t msrs[MSR_MAX_SERIALISED_ENTRIES]; >     /* Names perhaps subject to improvement */ > }; > > and just made one memory allocation. > > This is userspace after all, and we're taking about <4k at the moment. > > All operations with Xen need to bounce through the leaves/msrs encoding > (so we're using the space a minimum of twice for any logical operation > at the higher level), and several userspace-only operations use them too. We would still need to do some allocations for the system policies, but yes, it would prevent some of the short-lived allocations. I didn't care much because it's all user-space, but removing them will likely make the code simpler. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Apr 01 09:01:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 09:01:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104200.199008 (Exim 4.92) (envelope-from ) id 1lRtCK-0000KX-Hj; Thu, 01 Apr 2021 09:01:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104200.199008; Thu, 01 Apr 2021 09:01:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRtCK-0000KQ-Dx; Thu, 01 Apr 2021 09:01:04 +0000 Received: by outflank-mailman (input) for mailman id 104200; Thu, 01 Apr 2021 09:01:04 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRtCJ-0000KL-WD for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 09:01:04 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 585d9682-affb-4431-863e-9da158275984; Thu, 01 Apr 2021 09:01:01 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 585d9682-affb-4431-863e-9da158275984 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617267661; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=HlDFjEgLUu+h8qOLdpW3m//3hH3Zngbb3AnmDpjWIG0=; b=LMJwGS2D2qfKP7H7qEC3HVTJn2mWwbFRaFYb2v5h2tkR/aqJpbJFYbVC oJy7P39hm/jatGugTve/PQLvj1C2waEQCh2cTO9Mm3l5ShoKQQTvGv24O Ed3XTUB20mgAUHFMIHCIYTNRcW9X5GD5h/Fvq2PNseO0ZTyEFpePi24KL s=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: WunBr5vtlhzG6tTeZRB7xEZxbL5R2UzpuFrkMdE4jq0Qf6eGfEAYbMAEqqouDnPKGLeCiVe025 KGUgPg6U+FBFJZ1JIHzpX2DW35XHI9BfqaVAnV6HEl+uulq4I9W1swA1HYUtMnctR4sFJCeojw VNHXA8LqKO80XUK538ZV+QmHWTPVYuwEevKRvXGx2uVveKVOM3spyP/075+Rc83E0KJuJ2yxIZ 11Ay2DMKB4/YYFlhBdqhHmJ63nIDjtZTFLXI89lYJemfPArsHOE5xAVlM/uYQi9U7/XD2aO0Fz l14= X-SBRS: 5.2 X-MesageID: 40531267 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:U1sb5axfQz+ruIVTxDlfKrPxnO4kLtp033Aq2lEZdDV8Sebdv9 yynfgdyB//gCsQXnZlotybJKycWxrnmqJdybI6eZOvRhPvtmftFoFt6oP+3ybtcheTysd07o 0lSaR3DbTLYGRSpdrm4QW+DtYryMSG9qftvuvF03JxV2hRCp1IxS0RMHf9LmRdQg5aCZ0lUL ed/NNAvTq8eXIRB/7LfEUtde7FutHNidbaehYAHREq802jijmv5b78HXGjr2ojehlIxqov9n WArhzh6syYwoqG4zL/90uW1ZRZn9P91sBObfbjtuE5Iijh4zzYBrhJdKaFuFkO0YSSwXYs1O LBuhIxe/l0gkmhAl2dhTvI903e3C0163nkoGXo8UfLhcDiXjo1B45gqOtiA2LkwnEttt19z6 5Htljx3/E8bWKi7VbAzuPFWB1wmk2/rWBKq59qs1VlXZYDc7gUlIQD/SpuYeY9NRjn44MqGv QGNrC72N9qdzqhHhTkl1gq6tmtUnMvJwyBU0gPt+eEugIm4kxR/g82wtcSkWwH8494Y55Y5/ 7cOqAtr71WSNQKBJgNSNspcI+SMCjgUBjMOGWdLRDOE7wGAWvEr9rS7K8u7O+nVZQUxPIJ6d v8eWIdkVR3V1PlCMWI0pEO2AvKWn+BUTPkzdwbz4Rlu5XnLYCbcRGreRQLqY+Nsv8fCsrUV7 KYI5RNGcLuKmPoBMJgwxD+YZ9PMnMTOfdl++oTaharmIbmO4fqvuvUfLL4P7z2CwspXWv5Hz 8tRz72CMJc7l26e3PxjRTLMkmdOHDXzNZVKuz37uITwI8COslnqQ4Ok2m04cmNNHljv8UNDQ 5DCYKitpn+iXi9/G7O4WksEAFaFFxp7LLpVG4PgQcLNkjzYIsSotn3QxEX4FK3YjtEC+/GGg 9WoFp6vYitKYaL+CwkA9W7dkWXkmUUv3DPa5sHgKWM6YPEd/oDf9gbcZ00MT+OOw1+mA5spm sGQhQDXFXjGjTnjrjgqocVCuHZf9xVmxyqPsZQlHLauSyn1IISb0peewTrfd+cgA4oSTYRrE Z26bUjjL2JnivqFXEym90iMFpHaH2eBZVPCAjtXvQSppnbPCVLCUuajz2TjB8+Pk7n7V8biG DaISqIQv3TGVZGtndE0qHlzUNsegymDjFNQ0E/lbc4OXXNu3513+POXKa13meLQnYpw+0WMl j+EHAvCzIr4+ry+A+emT6EG3lj+44nOfbFCq8/N5vJ3Gm2FYGOnaYaPvNd8Zp/LuryuusTXe /3QX7SEBrIT8cSnyCFrHcsPyd57EQ+mfTzwRv/8SyW2mU8Dfe6GiURe5grZ/Wnq07qSPaD3M 8n0ZYbve6sPn7wbdDD46fNdDJHIg7Sp2nzb+xAk+EhgYsC8J9IW7/cWn/08VsC+jMUBsL9jl kfT6R2+6qpAP4mQ+UiPwZiumM0n9GOJnYxugP4AuUCbUgg5kWrSu+h0v7tk/4TGUWPqwv7BE mH/wBc9/nDWTGf1bRyMdNGHU1mLGw94m9l5uWMasn5DxirbfhK+DOBQzWAWY4YbKiOArMLqB lmp/mOgu+MbiL9nCTdpyFyLK4L02GpR6qJcU+xMN8N19yxIlKXhKS2pOa1kTfsUDO+L30iur ctTz1YUu1zzh84jIM21SCuSqv45mId+mEung1PpxrKwYip4GDSAEdcFxbW668mBAVuDg== X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="40531267" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y9WRa342OOHmO8WJh0qcthcu29jAAm7Tu1UMPyAMy9Tfz43lRp9Q/uqgZI28pbQgHrylJRnqawtAsUBpyOYvQ5EpYgRJHrycrxEAykbDojBGqhMxhIaB1Us83GQ2tEyf8E9zGHMwWBzEUG7PbxldHki8mkfMdLQ1gHUqwLQW7z7fZP3joErKD6mx+ef40vkhTnaHuOFyIPmvKkyGgJlO6T05JqyjYwoya28KQqOTpDe5qQ1FgbbL5GPXYCi7fulVPKlyX/L1fBS+V0XScjb6mDV4ISutkYFuMctDm1cv3sF132Fa+ffDh+iCwR+urkPNoeqo1yTiU58kroSnBdrNyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qEoRPbqbDx09jsw9MPEd1Mx3j080F815Z6eTMvjOSQY=; b=GWjjqmateYPbqJBjXZAcvSwofWXudVVqh/p/a/jP1j6fOofDzIbO5b29+DDMwpcM5Z9FS0nujkDbX6JRzOt3gNkCOayPbAZPxRGsOGrY9O72qhKE8migtMPSJZcNUgbxt1cjX8S9KWFBfIuGytacUuDJlCnbirPrg7WDZyy2TCqk1U9eCjBljJWjZsAyE6gLPKVjw7GbL6BFU5f/2h1W6IVEZ4DZYHQWRZ3lahgkSWDMvR9Zx+yHQKP+4VCAnyVAShsk4OErNQuHwYMcAviB9HIg4uk3G1SoPGwtcF/ZNBBRou+a3VhyYrbtiqGAvv2p16kgDC69JeodKz4prpR52A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qEoRPbqbDx09jsw9MPEd1Mx3j080F815Z6eTMvjOSQY=; b=TdJuzfE7pG48OdXd/WkY2ViiAcVq0gFZNCzaX/KO4yTCet86Urj/YPWeiUhq034GJ20CVND4ZhKFhyjQil7uzJLaqJKRyMwmit9bnJcF0DEewcFx6nRF3qq2enEchVwoldKzaozSnjZA4xricGBBMvEn31ocrB5S38GEjEI6ef0= Date: Thu, 1 Apr 2021 11:00:53 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich , Ian Jackson CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Dario Faggioli Subject: Revert NR_CPUS=1 fix from 4.15 (was: Re: [PATCH] fix for_each_cpu() again for NR_CPUS=1) Message-ID: References: <4d993e67-2bdf-9ac3-f78e-daf279642de1@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4d993e67-2bdf-9ac3-f78e-daf279642de1@suse.com> X-ClientProxiedBy: MR2P264CA0111.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:33::27) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d1f64f75-558e-43fa-ff53-08d8f4ecaad4 X-MS-TrafficTypeDiagnostic: DM6PR03MB4538: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xAZhdw78ToqYaOWGPihY51+AJ6h4QRs5UKrqP2S/0awhnLwergxEYz0uSI0hg2IXARXZG91KDPWqUGSdPqN4/08PATKrmfffc1oVbCkAGTnZT7kMh5nEx31e45rmw71yk/aJF+sz1GXWsae/Btlcq+n7zonp08lg1spUxc8JNtSLvAvrJdP1q9P5t8RvJzSk0j8NcH/RFMbLEDVm7WR8N91iQP79TmyawCVgproBdmhNtMGdMGzz8/emkhrdHZHIX3D1J4ajafi7OguMOGl2U13mpePxCaWwPSd99ezfPtEENRtBPypaxtCP+q+wUnmkZzqmKbI9NeL0hllia+Tg0oHvQ5hGAxQ7AEQ4WKg0BjVDVSnyxiiH7Km+Q12selPYeRMGmjnkZqghLIQsSBak4tf5V5WpHxeJu6WZkPh2wO6yYKSuH3yXfXztoPGjiQqu2x+II4xB9iNo6uKplHCVwTrxvCf+FVJOzRE9Gg1OstWKByHgmn3v8ttuugcwpSBFq8bxSAgIeWdAGbeQVJiEycICXJSI6i7XXLW7hYgDBtBde/RDJmdDTv/xQcjJywX8VLQ9LhCVJDQqBJpIOVPZt6zb9svMD4Ad4MZxwc/3EPgqFzpXISI7oHCCp5ToNeraHvfXF0xUXdjzBRpy06fEK3XCgILUpwlp9o/ed4mO+hY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(346002)(39850400004)(136003)(376002)(396003)(38100700001)(33716001)(6666004)(316002)(85182001)(86362001)(9686003)(6496006)(478600001)(66946007)(83380400001)(5660300002)(8676002)(110136005)(66556008)(66476007)(6486002)(2906002)(4326008)(26005)(8936002)(16526019)(54906003)(186003)(956004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?d0g1dGhpTVRxa2dCSDN0VktkRG16a1Byd3lWR2VSRE5NSzlDMXdrMStqWmk1?= =?utf-8?B?OVplaVRCc2k1bXdFS1ZKQUZablNaQ0lXQXQycURWYUU0VlRRcU14KyttTnhC?= =?utf-8?B?YlhPSUVhOVJPZVdFdENPY1duZVAxSUQ5bmhPTy9ZTVhvbkZBME41eCtiSmJE?= =?utf-8?B?QS9lMGFPS2FPZitHV2VWMEw2YTBOcS9OTkFHUnZ4bDdMT2hWSzhnZVFibDRI?= =?utf-8?B?S21kd0VrYjVvR2tIZStJelovMTd1MFptUjJhRk40VTRxVG5naFBiM3BUME5n?= =?utf-8?B?VWZIcW9weDJUU2NzMXU3ci8zZ2dDN1kzRmNIcTFsZTJjOGtQMnl6L0ZXYnlh?= =?utf-8?B?a2hLOG1iSXBhMklnTzNiK3c2YXJ0U3VGc1RuSmFGNGNtVkc3c1d5TkpuT3Vs?= =?utf-8?B?ci9sWG9JblZnZUFkSndvdERGUXAzeGpRWVFHbFJ2eGQxaEVrRHR2bFpBYzlS?= =?utf-8?B?VzBNaHYyVGdoUlpQam5Ram5uRWxkbzJwdGIvMFAvbm9RcGpTOWUyMEdydUpj?= =?utf-8?B?ejFSZGdjWElORG1MaWZOeFRockw4YnBKRjNiZTg4N3kxNHZlUkV1cklzN2pa?= =?utf-8?B?MmpnclFEaWo0Rk42ajFkZ0YrMnI3dHl1dkVLem5FVTJmTDhSVmJQS3hOQXF5?= =?utf-8?B?SUJkcG1KN0d5M1EwdURGYzl6ck9tQlBmOTBicEl1U3Z0enJGQXNINTVUb0xh?= =?utf-8?B?MS9YeXNodDdBN3VETTEyN3JEOUhKeE1MMEdGcW4xY1RLdG5SYUI3SVBvSVRD?= =?utf-8?B?c1JHSGpoR1plTndkUVlZU3doNXJQV3h4anR6ajRXV0pWWnlCY2FsQlJYZUtY?= =?utf-8?B?aGZwdWJMbk9UWHNBUG9jcStWUzEvcDNVY3ZHd0tnU0VySHZ0UEdZd2V5N1dt?= =?utf-8?B?MHVhbVFLSUIyblZzQzBYUHhBOThkTzd4TXJyTWR4VUQvRE9YelBzNW1CTzBW?= =?utf-8?B?TEl4c1ZNSXlxQ1RMMVlZY1Job1Vnai96Z1hsQVFqeUQzQlhZZW5tbXJYZU9Y?= =?utf-8?B?eVJnRHhFMWcwUnEvS2l6bWRhTktpSGgyZWtVTTRFUk4rWmlvMCtSMDBiMTA4?= =?utf-8?B?ZmVwQzdmSkJrRW9RZ0w5SElQZUdzeFRubytOQlBHZzR2a0dIUFJPY2ZUTnJz?= =?utf-8?B?dDMvdjFjT0VRWWJPVm5yN2UxM0dIbW42b3dyejNxelJHd21ZQ2dLZmpXVmlX?= =?utf-8?B?SnA3WUhZZ0gvZUQvbFVmT245NFpTa1ZyekNyWkFPSTdiV2ZhRDNZTzg2NGZH?= =?utf-8?B?T0JXWlB1YzRZNmtCaUc3WXJGNUpaNXAyVk5WZlpoS1F6aXlJdCtqMmpDOU9x?= =?utf-8?B?d3hDd01aOVhVVGZMODdTK3F4V3JoMUtacWtWWUZmdGFtWlN3MENMdi9yMmZN?= =?utf-8?B?eW45K25ESEF1Vkt3VldUUVp2dWY2KzZsMXN0WEZiM1NuM3VjZ3Z2UUVack1G?= =?utf-8?B?T3c0alZMZDl0eXMvckZtVU56OG5xQ1F2d2NnN1NWZ1gxalY3UVROWGl1R2xT?= =?utf-8?B?U1BySlV3Q1g4MUV1cUkxeHd1V3ZWc0pZaXBzNGJqeURIVzl4SUhqOU0rYysx?= =?utf-8?B?RDlLejZpVVUzeVNXQnlLb3JjbTkzcFE3WFg5WHpjQ0RHYm91Q1BYejNuRGpR?= =?utf-8?B?ajVtTjFFYzF1WTA4QW9TdXhVbUNlVm93Nk9pWUswdzNUK2s1ZDZoZi9QRDBn?= =?utf-8?B?WUVsdmloUXA0T0ExMnc2YktkcHhFOUNseW1RMGxCQmpMNkdxZUZpMkEwQU9Q?= =?utf-8?B?Z0VGY05id0haZlBhSGYwMnV0clhtSlloK3RhanQzeXlPUWFQelp0UlI3c1hP?= =?utf-8?B?aVdYb3JQWFhia2ZnQ0hZZz09?= X-MS-Exchange-CrossTenant-Network-Message-Id: d1f64f75-558e-43fa-ff53-08d8f4ecaad4 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 09:00:59.0381 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: irR5BWMV1MAGTGMAjC4dBq2L/iwzkzt7dOxaWrcodD4xVTADuFkxbmwiXiLaZxXoOgJ3M85smjdz3QGGzPAXHA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4538 X-OriginatorOrg: citrix.com On Wed, Mar 31, 2021 at 04:52:47PM +0200, Jan Beulich wrote: > Unfortunately aa50f45332f1 ("xen: fix for_each_cpu when NR_CPUS=1") has > caused quite a bit of fallout with gcc10, e.g. (there are at least two > more similar ones, and I didn't bother trying to find them all): > > In file included from .../xen/include/xen/config.h:13, > from : > core_parking.c: In function ‘core_parking_power’: > .../xen/include/asm/percpu.h:12:51: error: array subscript 1 is above array bounds of ‘long unsigned int[1]’ [-Werror=array-bounds] > 12 | (*RELOC_HIDE(&per_cpu__##var, __per_cpu_offset[cpu])) > .../xen/include/xen/compiler.h:141:29: note: in definition of macro ‘RELOC_HIDE’ > 141 | (typeof(ptr)) (__ptr + (off)); }) > | ^~~ > core_parking.c:133:39: note: in expansion of macro ‘per_cpu’ > 133 | core_tmp = cpumask_weight(per_cpu(cpu_core_mask, cpu)); > | ^~~~~~~ > In file included from .../xen/include/xen/percpu.h:4, > from .../xen/include/asm/msr.h:7, > from .../xen/include/asm/time.h:5, > from .../xen/include/xen/time.h:76, > from .../xen/include/xen/spinlock.h:4, > from .../xen/include/xen/cpu.h:5, > from core_parking.c:19: > .../xen/include/asm/percpu.h:6:22: note: while referencing ‘__per_cpu_offset’ > 6 | extern unsigned long __per_cpu_offset[NR_CPUS]; > | ^~~~~~~~~~~~~~~~ At this point, should be consider reverting the original fix from the 4.15 branch, so that we don't release something that's build broken with gcc 10? Roger. From xen-devel-bounces@lists.xenproject.org Thu Apr 01 09:13:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 09:13:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104203.199020 (Exim 4.92) (envelope-from ) id 1lRtNy-0001Ht-Hi; Thu, 01 Apr 2021 09:13:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104203.199020; Thu, 01 Apr 2021 09:13:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRtNy-0001Hm-EM; Thu, 01 Apr 2021 09:13:06 +0000 Received: by outflank-mailman (input) for mailman id 104203; Thu, 01 Apr 2021 09:13:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRtNx-0001Hh-7W for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 09:13:05 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8268550a-75d6-4898-9536-6747e970796d; Thu, 01 Apr 2021 09:13:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8268550a-75d6-4898-9536-6747e970796d DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617268383; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=LiR6CcfMz38H6AH3iC600Pju/Q4fqaW6qXchljKs1/k=; b=b73Bv9hQeBMKvdEWj0f5RzSYzB1g3tlhNJu6o/UiwHLKs0Qg0EYu47iz sE0yqlaCdI96Cqe5vOpFGf1qWtpvhVnQGH9A/whD9Z2OdsLc/tYnEd0/Z L0hBkHKC322et1AYNsgnTMIMt4+KbYGRxyOaD9vG+ET/SM9PGHLBnKDFE E=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: yOin2xhUPiG9rcEqeJg85pwO1j5MmEAv+Mw+8mo80L1iH7ZjAX3Bcs2B0dv4XLpD2reC82osrq mZgw5WxOS5SBJ+1BLotH/rgaKtaL18pxaWhGq+eQLjSbMR7wifs+UVMDBQrZSxe0gpsgz2w9TQ S4Hfa4tLuoP29OHLxApRvjyTMwagj0cr3NracDC0tYJcQwdy43X3LC+ypboyUKFlV8AqJMK0qU 3HtXFF2sxAlyQgjV1e+Q1W2Ia6dW4iAfyqouoM5VLoLI9rGOa2BAeCFIszTrVguse8aRzKf8nA xl0= X-SBRS: 5.2 X-MesageID: 40667943 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:bdQNVK9yEsJqE4OWDStuk+AOI+orLtY04lQ7vn1ZYxpTb8Ceio SSjO0WvCWVtB89UGwt8OrqBICuWnXZnKQe3aA0HZOPGDbro3GpKoYK1+rf6hntATf3+OIY9Y oIScdDIeb9B1R7ksr2iTPQe+oI+9Wf9bDtuOG29RpQZDt3YKJt5RoRMGimO3BxLTMrObMJUK OG5sxdpyexEE5nDfiGOg== X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="40667943" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ji8WuRR92PjjWwgnmBN0sCIzNklx+i8y3br/G6jNgp0lhFYtledXcWslHxU3BhyZUPOzaQ7buQEVMNkPdyHTiQxgtV41SNkmEIQuv5L7QxBZglmYkVIbuMhu6ROf4vwy3SA15YpnhDy1iEXTwRwLF6EEULarX/B74RLD0omCuT3tDUkeLUZ53UoaKI8sfK1lYwZKohmQZtgCe8k5VDQDv7irGIIRf/bjq2PheCIW7brWJ7X2HRkgPrh+nraH7MBwpwnnTrkK+1g2NKbphl9bQc1Ac1q77qlyzcn4Txq8XF6E8Z10PtdTHmzIzH/GqMi6od4a0jx8YTIELvc0UKnlsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F6xTik7cg0w5yMM+5ODaWnDwMfxiWiQ9Cpu9dj2GIqM=; b=JG99yIG3H4oqFfVSTSJ0zq/BKerlbYEWUgmZvnh4ov9sQUwAcquolhFWUNYkXPH8EbVaNBcEjS9UL0v3UzQZEcRUWemRzd2s+I2dWHMgtWFc4j6zSawt+720RVv+8h7XE48ZxtjGTU+Tgmy6jQLRMdXx0Dc6e9T+y6FSUuiPAnpm1z6XC/PlEqDXkhBpeyqQLvI6JJZJ8DX9cRzHDCZmcRHffYPv6270t7Yv2Rbv2zUmkpTH7I7wddARVfRa35wjuARzSAXQ6NcYn+iF3SIqjgOH59uAAoQWLMMSDdWgZPpEuqFLi589j6jXl13EPEIPUo9qn1ByyQ2jNCmDBBXsbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F6xTik7cg0w5yMM+5ODaWnDwMfxiWiQ9Cpu9dj2GIqM=; b=o9A2RWYmKa/5VCgcbXB6iJj0FGNAdhYfPuEKpj20yAcQxtVN3dmJbx+tQBa7df8x/xKlmaySMIxRzcN/EVXcOrSsSoyeSGMaWSiuiaXH/xwakL4Xl6yQeYfob5km6OSXkg/pGFFggm/Ypwq7NDvDPcPIgiOaMGpJPPQWVUsCEME= Date: Thu, 1 Apr 2021 11:12:52 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper CC: Jan Beulich , Wei Liu , Paul Durrant , Paul Durrant , Subject: Re: [PATCH v3 01/11] x86/hvm: drop vcpu parameter from vlapic EOI callbacks Message-ID: References: <20210331103303.79705-1-roger.pau@citrix.com> <20210331103303.79705-2-roger.pau@citrix.com> <1bc56db3-203d-1fa8-ad5c-68d97d584600@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1bc56db3-203d-1fa8-ad5c-68d97d584600@citrix.com> X-ClientProxiedBy: AM6PR10CA0037.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:80::14) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4ca16840-e7cc-49a4-017c-08d8f4ee57de X-MS-TrafficTypeDiagnostic: DM5PR03MB2489: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +gpL9/+jKQNnz7KMuMr3KaOxKOfPVqTlxSNuxVo+aAG66e4xs7weJ8woZwkDpEirW274k7OJZnIDrZqtDdKtaLLEMmTQZr2AYToMqE3bmmu5g2+dMbPN8s3CU9JJPqBdrSD3tysFwmgetV3kowOPwpxe13CE/HMl/MiAJCiKt5WUqJZ9JvBfwuP7YTVYDKNSBbLEABxF2YBlLqAcb4AoNgdhUFlSxWDkAOirQVN3sxGO09gH29QNLpFYwLY2ms8rz3neH80YZiGoZ+I8HEpwmoAofuDG+kLANKBkutyM8SlQMh1SaR21B7/Al9xb8jQC8MKoeA7KqENLV7BmjTcmRPTSMxag6wNMCUX+qmrkKkQMglSjc5MuWawgrgb9ufffiSlec4mk+lwuc9QaBZwFJQuD/P0HCE3+A+xTOdr0euvGUk1ovLgl2n2Q3uDQnGHJEEDRaBkHnci9AZ0KOKjUkhNZXgaWmTBkdg6XK57CS2o4XVxyUIuq9gkmJvPTZ06xqFmuNhfFzlQtGYwVCmkx5ci+sMcnCA4enkW67urewP5rCK0N1/GyTHcOpJUxtochBlQRFkkoCkVHmDpXWk+JpoOMyAi9XZ+jSQ52C5khx7hfJgHww7Rvxr4IZWIhVNnozwLHuca7uq0Iqx3cEx+IigPy/q94qfNWxoN4bXjDI84= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(136003)(366004)(376002)(346002)(396003)(39850400004)(6666004)(16526019)(956004)(86362001)(53546011)(5660300002)(9686003)(83380400001)(85182001)(2906002)(186003)(6496006)(478600001)(66476007)(8676002)(66556008)(66946007)(33716001)(6636002)(316002)(6486002)(38100700001)(4326008)(8936002)(54906003)(26005)(6862004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?VWdwZDAxTUxTTWVDdDJ1cWpkdW4zUmJIYlVoay9BQkt0WFh2clUvLzRLTzZK?= =?utf-8?B?clZaVllTdXRBbkVNUk1GL3F5OXdWamVpL2UyZXZ6ZmZMWGlXYWZhZGNJeVlO?= =?utf-8?B?V3MyckFiMjZ5b0VodnZSNkFyZjNvekZKd3p3MUpRSVZFdXZ5QkVMaHUyYms1?= =?utf-8?B?Rk5GVXlGeVphZ3RqQ3RiL01CMG45NjZSWnhhcG5tY1lHbXF5VVBiSjJ4NTFr?= =?utf-8?B?MXZDY08xWWFuZUE3MTNSWmFieHNvSzVtTVBZNFB4ejV0b0FEdmpDTmlvRDcw?= =?utf-8?B?YktoUk9ZK1hiUUVmWDNsR3ZLYk5WMjBJdCt5TCtzMHNqYkhKd2FiSDJVZFpo?= =?utf-8?B?OHJ2M2RVaDMrcHZwV2V5cnkxS0llbFRYajRUd1pJc3BzeVRiM2ZYQTZKK1Ft?= =?utf-8?B?NlJZTENIYXZRd0RPTkw0S09OU2hjV0NUOU5DbFRRS2lCcnprZUlQK3JZb1J4?= =?utf-8?B?SjJtVXdqNlpOVlB3azB3WGxCdm9sK2hKdW5TS1NxWUlMRVNnaGwyWFNTc2xk?= =?utf-8?B?d2pMZE9qZ3k5YzdxYkdCTlk4U243ekUvWWg4UUpzdVl2L3E5MDlVQi9obEhq?= =?utf-8?B?TDRkaGpqVWVuTC8rcUVFdThjYjMxUit6TU1rVlQwSGlEQXVpSGtFTjUvcTZD?= =?utf-8?B?aC8zSmE0UXpHMGQ1eHRveGY4cG1XNjRjQnRXNmJ3VXZobi95Vm10OFFmdW1G?= =?utf-8?B?bnJFeFZaUkhLQkZkamJqQmhQVzJWdmFzMUdkcXNRSUxWZ3ZIUE1qb0F0YjFK?= =?utf-8?B?VkNKakRaMUFCbExEdUtKV2VJR2FSWlhCTEo5TS9JQUo4T0NjblQ4NUYrazZV?= =?utf-8?B?TWJVbm1MWnR4Yk9tU1d1c1VSK2R4TWp4bjdaM3ZzbjdMWmNEU0ZhdXJuNi9H?= =?utf-8?B?SE0xS0FRUmpTaHhSczdJZHZub1FEeEhvRmZ5MzBoRHBaQ3hsSlNkY1R4QkF0?= =?utf-8?B?WTk3dEtadDdtSk9LL2R5aTNrenRCc09LekVFSHZ5ZitmcGNONm5oL3NRK1A1?= =?utf-8?B?cnpDOU1CT0g4d0NhclhNUFRMaUhQRnQ3czdBQXdFbExvRlV3aWc4MXVIZTRa?= =?utf-8?B?ZjN4d1U3amRiRk1VTEVzclpsTitxeldJYUhCWlU2TDVrL3p2ZVE5emFiUld0?= =?utf-8?B?OTEzai9ySEs3Ym9uYUtERXJHc3BXazdwY1lYSWpGbDJIOG1QVFNEVk5CNUxR?= =?utf-8?B?TTZma3dIQUFBNUdYMy8zY2hsNExWbUNrZ1FHN3dPK1dyeW1zZzllSlFKcU1s?= =?utf-8?B?Z2p0eDBHdDYxMGdmRVhlQnpKOVhNeDJkemZBdVg3cWtvcjRCb0pEVzBHNGNa?= =?utf-8?B?YXhpcklSSjFsU0FVajMxdzJZUG1zeXp3QkdxUzFuQ2pmVmt0cWNsR0lrWTJr?= =?utf-8?B?KzkwYW5XcW16cERQWVBQTnprMUdJT1RSQUM3NWJXc0JPKzBYa0VJaDBnYm1p?= =?utf-8?B?eW5veGtZNUtqUUxFY2xuTmRwOG9HZGE0by96YVFRWk9BOXJMUjVFS3MzTlY2?= =?utf-8?B?a0drVHVNa3dMcEFZRjlOMW5EaDVuK0N6SGdCTUJGSzZsb3FBUWV4djFwTllp?= =?utf-8?B?ckpuY001c3o4K3pHcC9sODFBZEpHZVpHSmJjR2dPWG1OelZTYXBMdWRRYldj?= =?utf-8?B?U0c1RjF0bWJYRDlxTXFjc29KYXhmR1BFMkJaejF4QnVpbGJQM0cvVVFnWUFZ?= =?utf-8?B?M3lwQ1puejlxV2VNNmwrcGxDdjVYNTl6M3FOL29rb1JUN2FTOTZGR1BUS1Fu?= =?utf-8?B?cHQ3Z0VFd2dNdko4SlZYb3dBejVUWU1uVTdnYW9jMFEvZm1XRk1IOGtNQzhC?= =?utf-8?B?TUpYVkpmMWJOQzJtRlU0QT09?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4ca16840-e7cc-49a4-017c-08d8f4ee57de X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 09:12:58.7471 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mcWL9cQzj3LyBnIq9w2boWASGM5lbWzcvrezDy1n1n2bnOiSzIPzkJjT+XUJ/0amRywt3C6DT0ylUHTXbAN1Qg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2489 X-OriginatorOrg: citrix.com On Wed, Mar 31, 2021 at 05:24:24PM +0100, Andrew Cooper wrote: > On 31/03/2021 17:02, Jan Beulich wrote: > > On 31.03.2021 12:32, Roger Pau Monne wrote: > >> EOIs are always executed in guest vCPU context, so there's no reason to > >> pass a vCPU parameter around as can be fetched from current. > >> > >> While there make the vector parameter of both callbacks unsigned int. > >> > >> No functional change intended. > >> > >> Suggested-by: Paul Durrant > >> Signed-off-by: Roger Pau Monné > >> Reviewed-by: Paul Durrant > >> --- > >> Changes since v1: > >> - New in this version. > > I'm afraid the situation with viridian_synic_wrmsr() hasn't changed > > since v2, and hence my previous comment still applies. > > Only just spotted that line of reasoning. > > Longterm, I do want to remove all the Viridian special cases, and handle > all of the state via architectural mechanisms (cpu policy for static > settings, and the existing MSR records for dynamic content). > > A consequence of this cleanup is that guest_{rd,wr}msr() will be > eventually be used to save/restore dynamic state in the migrate stream, > which is why I've been engineering guest_{rd,wr}msr() to work for MSRs > in "current || !scheduled" context. > > As such, it is important to retain a vcpu pointer because it will not be > current on the save/restore hypercalls, which execute in control domain > context. But you are never going to restore an HV_X64_MSR_EOI MSR, as such should never be part of the migrate stream in the first place. It doesn't have a value itself - it's only used as an alternative way to EOI an interrupt. I still think the EOIs will always be performed on the affected vCPU context, but I don't want this discussion the block the current series, so I'm just going to drop this patch. Roger. From xen-devel-bounces@lists.xenproject.org Thu Apr 01 09:16:03 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 09:16:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104209.199032 (Exim 4.92) (envelope-from ) id 1lRtQp-0001Ru-4W; Thu, 01 Apr 2021 09:16:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104209.199032; Thu, 01 Apr 2021 09:16:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRtQp-0001Rn-1W; Thu, 01 Apr 2021 09:16:03 +0000 Received: by outflank-mailman (input) for mailman id 104209; Thu, 01 Apr 2021 09:16:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRtQn-0001Rg-Ud for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 09:16:01 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 343f3375-e764-4e0b-8be3-543d6c93c60e; Thu, 01 Apr 2021 09:16:01 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 343f3375-e764-4e0b-8be3-543d6c93c60e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617268560; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=VBigh4Jjc9bf+9Suh37vdMLsfns5kgMGZiGdO285b38=; b=XeQSH/G03LuwrZZL5hy//FBDrPtxAAD0zofIfGDbZbIIPsGtcC5nfMHW v3t/YMWLehaMrXU8HYiwPARo+Op3KHu5izIh2dP0O2HKqnLxvkRTukueP 1GMh/NCBtQuvDF3B8bLE0OcWn1SdAQ9dZq0vKR54rphei0fn1DzGT59TB 0=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: gzGQLHkO/6MaMEO8/Rl5ZRpIcQEyiGWPyUJDMgC7Wwomf7pk4e6+Tap+bQ1JKFU/YoOGacdU3o gR4tZqPonMXeMdnSw0rvA01S2Yw/MXBoyguVAFuwsxhAM/NBcvuEoV7jWllKr+whNKKGU189UZ KeJaQI5hACPqAPdJmXHOJIXsNxXp2M4oXj/Yi7izNhYjkiUV16xLwqJTn4T8zrKZDgXyCZS/Gp gCalMzbiGhLNCtPT0veTFq/vnQZLLVUyejPkcrivAw4pqk+r1vlJ768evqjON/tzyeECoLU7Ml YgU= X-SBRS: 5.2 X-MesageID: 40668093 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:SgtE7K7A+HWNx6rT2QPXwRKBI+orLtY04lQ7vn1ZYQBJc8Ceis CllOka0xixszoKRHQ8g7m7VZWoa3Xa6JJz/M0tLa6vNTOW3VeAAaNDyc/ZwzPmEzDj7eI178 1dWoV3FdGYNzdHpOng5g3QKbgd6f2m1IztuuvE1XdqSmhRGsNdxiN0EBySHEEzZCQuP/oEPa GR7MZGuDasEE5/BqiGL0IIQvTZoJnznI/mCCRsOzcc9AKMgTm0gYSKcCSw4xF2aVJy6IZny0 fpuUjT5qKvs/a0oyWsrVP73tBtt/bKjvdGDMyIoMAJJjvrkRbAXvUdZ5Sy+AobjcvqxFE2kM TdgxpIBbUO11rhOlubjDGo+w783C0g43XvoGXo/kfLkIjCax8RT+9i7LgpFifx2g4bk/xXlJ 9v5Sa/saFaCBvR9R6Nn+TgZlVRuWef5UY5nfV7tQ05baIuLIV/gKY4501vHJIJDEvBmfsaOd grNs3a6fpMGGnqCUzxjy1qyNyoaHw5Ag2LdEgEotCUyDhbhhlCvjIl+PA= X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="40668093" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RLq87aEgwqtFtwpITzKBXImTeWcY2bUUeiyK8yhkh58g41RckDHo9XpE4bgJGOLH5Ha8psecVMlnTUbOzAy2rsLbk1Iv0fZ8K1rx93MkqEnaX3KJMct9wnxrxW4hm4jJjF3u/tB8Izgn14XPUxvvOranWs9GZUmQ52+OkmNzW4NAr3Ifbvw/n0SjL+e+UyR9mU5iEVFccxYL5jX6oE6T6VC7fDAa5gcicjO545EwyurIhjbc5TpH069i3YGc7p+YPOWTA3K/HluyfdSkO1yqCe1N/0fTSJISkfYwYnLUQXsG38M66Mk95u/AR3zspSMfuDkmxc5bD8cNWQxAaR7Hbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R+bvJqg/PbAj/zaIBp4Zsin11W4wJLOT6sVFvy9DVdI=; b=hHWq4I8ziMggBgY31mVBw+CMVxsvV8xQ8IMm5d3XsQQeEhnqznpSZQ+vZdMlCsEgTCiVjjiRiRlOyPNgwX4+RJYEaD+IuViwOLlGxwWZIN1QWJmH9BLCIr/zfJcgSMj/Im4W6WNIkAQC6ztgxJ1RBi2gpuQtw+vVsnArVUZmg0l6R2JWZAMGdk7drWvlrCsXP8eRapsejR6tKOOz67QSp16/6SZ+JHapiY4MrC/GEcDuoHE+0VIs+S4jiNzufNCTDurHTivhN2F1vqaemKbCoP+wmfzljU94L4TvWWJzFtQ0B47Gd96R/TeJFmt4RGkg2QjqB+1eXndWgl4zvm7c/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R+bvJqg/PbAj/zaIBp4Zsin11W4wJLOT6sVFvy9DVdI=; b=q63sK+Y+Dv3sE98B2wdoWoYLtCnM/1/VIXnTyWmxwon+n6+FS7/MzFct9i3V1YVlFSivwSvejZTcziHeJEim/5mG0SWTvbVg5XQfGRVGcjpeDRV46rW9d7+mzZ72w9JQh4bu4Z+0L0sXU8YmDMD712qj8MvKn5k0aLDMaZDWYV0= Date: Thu, 1 Apr 2021 11:15:52 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: Andrew Cooper , Wei Liu , "Paul Durrant" , Subject: Re: [PATCH v3 02/11] x86/hvm: drop domain parameter from vioapic/vpic EOI callbacks Message-ID: References: <20210331103303.79705-1-roger.pau@citrix.com> <20210331103303.79705-3-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: MR2P264CA0032.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500::20) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9adb56d8-3bc8-42c7-2ac7-08d8f4eec273 X-MS-TrafficTypeDiagnostic: DM4PR03MB5965: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4M66Opk2kC2KPa1R2GK3bQku/tAgD7h7qpGfwW0SOc2P9Fb2FlMAohYfC+viOxPw/RNx2kqyUSB5qjZxqwPIwDeB7Z0KjeEmB/8PFReyRz/xi+9wmua+KjagVC61EcYnpqxH5OUuBEThn7CuYXoTfLKF0JYxUjVP7thAEn2zJgNCWBT3g+qtaPltdQIXK8DAExzur1yWspB/9v8EJ6wLVWNXoIhAUB10fgBXXvEZdJqfn4uXRlS+DkIAWmZMmtPYu8cr08jrj4vtJDh/Xo6Epw9fRUOqYYL6nstS0U+cURnGB0baZ9SVFFCYziL7hDvOLO8IT5V9ctKh2U/wsCQ/gJt/Eedz6AaH2oGDuUXo+AiQNpamEouiaNy1TwA8qwLFGIsPzwKG1VReHWhXNWtT/3NJCIuaq45SbnucZCuVARqhM4VPfJX7TcbgeCc73Zy5ztrgJ2KGa+MULS8rsUz9bwdPzICshx5G4BFXuCq5oZusXk8uaIfkWxKoFSmOArIAf6NRSuGYaX7Wock+96nZvRY4enVkLLvC3aSuozaExExS9yKC7cnVEQ7LC0TwwEq0lgAsib228jiFyjXsu5GvR4H9KFrRpicofAZQVUVIKNP3sWVxl2Onj9rbbtdw9/dmuXip6xbAfsmBaMn+GqHxze0P+MCKoYH9l1TMseUkoGQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(396003)(346002)(136003)(376002)(39850400004)(366004)(38100700001)(26005)(4744005)(86362001)(16526019)(316002)(186003)(8676002)(4326008)(85182001)(6666004)(6916009)(5660300002)(6486002)(66946007)(83380400001)(2906002)(54906003)(6496006)(8936002)(956004)(33716001)(9686003)(66556008)(66476007)(478600001)(53546011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?VENWLzU3SW11K1RiaG03NzBObm9aM0NsUVkvd1cwSVFmWm5nUmZ5S3Z4VjNJ?= =?utf-8?B?VUFibGRBNWxhOXNsdW1oa0IzMmcwTm9nZERRZ3V1d3FOWkZod2d5ai9Xc0Uv?= =?utf-8?B?MVYxYnBRNnkySVQyKzJJM2pLSlRUVloxTzRxUW5LTlljK21pV0ZwMi9RS1I1?= =?utf-8?B?UEExTjJ0NjZNREQ4V0d6OVhhYnJLQm1HS1JmMWU2WTZ6STBmSlR1MlNvN0Zt?= =?utf-8?B?aTNjaWJzSUtkc0plUE9EVWpZNkNIZFo3Qyt4eFdHSVJEcnEyeFJyQ0JIbU05?= =?utf-8?B?ODNZTncraXlFNFBWTElXNWIvbHk4cXdBQnAxQXloajJycHF4MEgrazVOcmxW?= =?utf-8?B?cUtUclg4M01rckhIbXY4UnJoMWJjNS9ZNXNDZ2xzWkg5aWwyU0xEZ2dLelp3?= =?utf-8?B?MUtwTytwQ2p6dC9KRDZvQnROL3M4VnhZTkVtVEozM0w0OTNOS1ZTV1Zya1gz?= =?utf-8?B?aHdLQk5tc0Z3c3hSbTVaYi9INUxmaVFkd2h0WWdycVU5OEdCcmJqbVpsSmNK?= =?utf-8?B?VE9lS3RCemMyWnozcklQMEFtQ0ZraFhleEdkOCtYYUgwM1BzV2NVVWxmUFQ1?= =?utf-8?B?ZGh6SHZ0TkZHV0xsTkN2ZW85eDFPK2ppV2NTNzcvVkhCQ0ZncGUwdVkyaTlt?= =?utf-8?B?akNXOUFyRUdQOW4zbFQxc0F1VWNvSHl3L2p1Q2JmeFpDbmxIcHdQUmRDTHRa?= =?utf-8?B?d3UwaFN0b054OXdHVlprQmVkR3NuYmRkTWVWbGVKeVhPdTZRZU11RmxPT0F4?= =?utf-8?B?R0VHdTU3V2MyaUc2M2k0RUEyaFV3M3k0WVpuNko1LzZHc0Z6ZW9pQ25YRlZv?= =?utf-8?B?SnpOdXZvR0JldXVRQURRZmtFRmxEaUN3RFYvMUF1dWdaR0ZubGliUitXcC9H?= =?utf-8?B?SDl2VmpQUjlFVnI4OWFtanlwVWhjZVBCS2Fha0RDTWM3ZlVvYkxBYnVJRUJR?= =?utf-8?B?REx3SFVKVzQ1c216eFFQbERCZjBRZktZenVRL1V6bW00M3FIcmN0Z044djdI?= =?utf-8?B?VFZMTElTMUlicUVZR0p3M1I1dHNlZTdXMnNmN0FiQ3BQa0RIWmlZUDRoenY3?= =?utf-8?B?QXlWeCtTWFJ2TkJFWEVqK0xMdm1ESUZRc1RkSlJTVlNFeXJ3czZJUEpYMEYr?= =?utf-8?B?cUdHVnRhSGxYMzdUT2FLMWFqQUhVREFQL1kzc2RzUEtDOElhUGJXYXg4ZEJh?= =?utf-8?B?dTh0Z09YMGVXTzh4eDhub29VRmVQR1NNUUdFRG5nOXJYOStqbHVjTUZTSTlB?= =?utf-8?B?UGdjb1A0eDNsOUF1UlRydGsrS3FaM0dIZ01EeTZIb2hzZ2NyT0MrTlB6aWV2?= =?utf-8?B?WXhpclM0M0J3SXp2aDlHcW4vVXdXR1U5OEpXYXNPM1NsVzFkbThOemhycnE0?= =?utf-8?B?TmNDR1A2UW1pc3Y1a0Q2Z0F0ZzdmN1lYSitXbUZ0TzZZWEN1SVV1K0xxQUdy?= =?utf-8?B?MHBQM2dWcUJMclJod2R0UnhsTWttK2dpdEJjVExlcWJiK3A5WXAxOTJZTHU3?= =?utf-8?B?UWVEZG94VjBSekhVSngvQWhyaG96bDI1ZndRN2NDbGg4REVIeGRxaTNrb2dV?= =?utf-8?B?ajBMejF6NTQ0ek1VZDVGY0dKRDUxVG13SnRLck9ibnhKd3VZa0wyNnZuM0lh?= =?utf-8?B?aHRlQWZhZVpmdkFZalBJZURPNDZaVVlFRklvQjlxY1pvcUhXem9CNGgrQVdr?= =?utf-8?B?RE5SRjlmYzdza3lYM1NzeVIxM0VKYi9qT2V3cTNJb0NneE83OEJNTk9uTENZ?= =?utf-8?B?TUx5V3NPcFcwMkhEUkpwbUkydXJaV2RMdVNjMTlyd3NVSFpNVDZFcERJaFln?= =?utf-8?B?MmZmK3NsSXVhUzBPNk12dz09?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9adb56d8-3bc8-42c7-2ac7-08d8f4eec273 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 09:15:57.5313 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: f6tFQVcA42ecJy4ojDI9lpPRYWh/gDQPj1ZMVjGrZEMwd3AmVTMb+9RAIFH1NoLIQGO6lhWcI17GvR1am+HXmg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB5965 X-OriginatorOrg: citrix.com On Wed, Mar 31, 2021 at 06:04:43PM +0200, Jan Beulich wrote: > On 31.03.2021 12:32, Roger Pau Monne wrote: > > EOIs are always executed in guest vCPU context, so there's no reason to > > pass a domain parameter around as can be fetched from current->domain. > > > > No functional change intended. > > > > Signed-off-by: Roger Pau Monné > > Reviewed-by: Paul Durrant > > --- > > Changes since v1: > > - New in this version. > > Just to make it explicit - possibly same thing as with patch 1, > depending on how exactly the issue there gets taken care of. I don't think we have any scenario ATM where we allow EOI'ing of interrupts from a different vCPU context, neither I can see us allowing such in the future, but I don't want this discussion to block the series, hence I'm going to drop this patch together with patch 1. Roger. From xen-devel-bounces@lists.xenproject.org Thu Apr 01 09:26:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 09:26:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104214.199047 (Exim 4.92) (envelope-from ) id 1lRtaa-0002RZ-5c; Thu, 01 Apr 2021 09:26:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104214.199047; Thu, 01 Apr 2021 09:26:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRtaa-0002RS-1m; Thu, 01 Apr 2021 09:26:08 +0000 Received: by outflank-mailman (input) for mailman id 104214; Thu, 01 Apr 2021 09:26:07 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRtaZ-0002RN-Ni for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 09:26:07 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 104cbf2f-9beb-464f-8526-1937eb753ffe; Thu, 01 Apr 2021 09:26:04 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C586DAE6D; Thu, 1 Apr 2021 09:26:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 104cbf2f-9beb-464f-8526-1937eb753ffe X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617269163; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v6lOjNU+svs0+TiXpKu5imyHz2geYNGSrUhOwv1fq+E=; b=OTbD65dcOzWEIPi7d81zK/m578CscN/JdVT+gZc7eVdyFDEZ7Ha86zeHjFxYdqlmhAB0sL BQW2z1U4GzCv1HexBvwEMr8+t3+Cx2a9UVmhEF5rzijiVS4jgSetevcQbkItlONkVlUdpA mxs24bGG/ml4GqGE7+F6qjXnkbvh5RU= Subject: Re: Revert NR_CPUS=1 fix from 4.15 (was: Re: [PATCH] fix for_each_cpu() again for NR_CPUS=1) To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Dario Faggioli References: <4d993e67-2bdf-9ac3-f78e-daf279642de1@suse.com> From: Jan Beulich Message-ID: <59387a2d-e28d-4e12-6b91-5df464e8ab9a@suse.com> Date: Thu, 1 Apr 2021 11:26:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 01.04.2021 11:00, Roger Pau Monné wrote: > On Wed, Mar 31, 2021 at 04:52:47PM +0200, Jan Beulich wrote: >> Unfortunately aa50f45332f1 ("xen: fix for_each_cpu when NR_CPUS=1") has >> caused quite a bit of fallout with gcc10, e.g. (there are at least two >> more similar ones, and I didn't bother trying to find them all): >> >> In file included from .../xen/include/xen/config.h:13, >> from : >> core_parking.c: In function ‘core_parking_power’: >> .../xen/include/asm/percpu.h:12:51: error: array subscript 1 is above array bounds of ‘long unsigned int[1]’ [-Werror=array-bounds] >> 12 | (*RELOC_HIDE(&per_cpu__##var, __per_cpu_offset[cpu])) >> .../xen/include/xen/compiler.h:141:29: note: in definition of macro ‘RELOC_HIDE’ >> 141 | (typeof(ptr)) (__ptr + (off)); }) >> | ^~~ >> core_parking.c:133:39: note: in expansion of macro ‘per_cpu’ >> 133 | core_tmp = cpumask_weight(per_cpu(cpu_core_mask, cpu)); >> | ^~~~~~~ >> In file included from .../xen/include/xen/percpu.h:4, >> from .../xen/include/asm/msr.h:7, >> from .../xen/include/asm/time.h:5, >> from .../xen/include/xen/time.h:76, >> from .../xen/include/xen/spinlock.h:4, >> from .../xen/include/xen/cpu.h:5, >> from core_parking.c:19: >> .../xen/include/asm/percpu.h:6:22: note: while referencing ‘__per_cpu_offset’ >> 6 | extern unsigned long __per_cpu_offset[NR_CPUS]; >> | ^~~~~~~~~~~~~~~~ > > At this point, should be consider reverting the original fix from the > 4.15 branch, so that we don't release something that's build broken > with gcc 10? Well, I didn't propose reverting (or taking this fix) because I think build breakage is better than runtime breakage. But in the end, Ian, it's up to you. Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 01 09:28:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 09:28:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104217.199059 (Exim 4.92) (envelope-from ) id 1lRtcs-0002Z8-Iv; Thu, 01 Apr 2021 09:28:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104217.199059; Thu, 01 Apr 2021 09:28:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRtcs-0002Z1-Ff; Thu, 01 Apr 2021 09:28:30 +0000 Received: by outflank-mailman (input) for mailman id 104217; Thu, 01 Apr 2021 09:28:29 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRtcr-0002Yw-NN for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 09:28:29 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e08efd25-6b68-486d-8a30-af0fe2fcb1fd; Thu, 01 Apr 2021 09:28:28 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 00FA9AE6D; Thu, 1 Apr 2021 09:28:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e08efd25-6b68-486d-8a30-af0fe2fcb1fd X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617269308; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mkdbBrVK/p16/Dm78k97AvAwNFvaoVHKkhdL9CZCm9Q=; b=eK/Hclm3fC6Au6C5zJJvnkeIc7uy4wGD2fJWEloBmb5hrwcV2Ms+KAhbgu67osbZM1QSLQ 5gAi8UcdUwrlcQMQ3z47Dp0pYXIbgrnq4zC/uwnj2y+tAZrgW20UYhi2LWC+rc4+gIpnQb tiSW/xKhtVldVZoQic7sGluKgw8QoHE= Subject: Re: [PATCH v3 02/11] x86/hvm: drop domain parameter from vioapic/vpic EOI callbacks To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Andrew Cooper , Wei Liu , Paul Durrant , xen-devel@lists.xenproject.org References: <20210331103303.79705-1-roger.pau@citrix.com> <20210331103303.79705-3-roger.pau@citrix.com> From: Jan Beulich Message-ID: <74913386-ba01-182b-464a-6a5c5c5816ff@suse.com> Date: Thu, 1 Apr 2021 11:28:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 01.04.2021 11:15, Roger Pau Monné wrote: > On Wed, Mar 31, 2021 at 06:04:43PM +0200, Jan Beulich wrote: >> On 31.03.2021 12:32, Roger Pau Monne wrote: >>> EOIs are always executed in guest vCPU context, so there's no reason to >>> pass a domain parameter around as can be fetched from current->domain. >>> >>> No functional change intended. >>> >>> Signed-off-by: Roger Pau Monné >>> Reviewed-by: Paul Durrant >>> --- >>> Changes since v1: >>> - New in this version. >> >> Just to make it explicit - possibly same thing as with patch 1, >> depending on how exactly the issue there gets taken care of. > > I don't think we have any scenario ATM where we allow EOI'ing of > interrupts from a different vCPU context, neither I can see us > allowing such in the future, but I don't want this discussion to block > the series, hence I'm going to drop this patch together with patch 1. Well, having seen also your reply to Andrew wrt patch 1, I just wanted to clarify that dropping the two patches isn't the only option. Making Viridian code resilient in this regard might be another one. Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 01 09:43:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 09:43:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104222.199074 (Exim 4.92) (envelope-from ) id 1lRtrG-0004J7-Va; Thu, 01 Apr 2021 09:43:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104222.199074; Thu, 01 Apr 2021 09:43:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRtrG-0004J0-SI; Thu, 01 Apr 2021 09:43:22 +0000 Received: by outflank-mailman (input) for mailman id 104222; Thu, 01 Apr 2021 09:43:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRtrF-0004Iv-Gv for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 09:43:21 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2edd54c0-d6de-4dd1-8293-7e1c83934915; Thu, 01 Apr 2021 09:43:20 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CE97EAF5B; Thu, 1 Apr 2021 09:43:19 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2edd54c0-d6de-4dd1-8293-7e1c83934915 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617270199; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GzLeFqJW3FBoJkiPqpRmFDkCHlruQu4pViPhOQvIlrs=; b=DHoLZMWZihyCUJtmQAs9jYGKlq3IHGJ+ZnNBVYMMVxiY76QVdKk4PdH+mG1WsoH09ZX1/W 6VEey810g7YeCNRSOR0SdjdjaHE+e3aVdPUaatOuO99lKTCoFsmqvTiEVKoaM0aimW+qEH Ga5PxBWn5CV6IhmZ8/FZ7g+TPp2MKXU= From: Jan Beulich Subject: [PATCH 0/8] x86/EFI: build adjustments To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Message-ID: Date: Thu, 1 Apr 2021 11:43:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit So far we've taken care of just the immediate breakage caused by binutils 2.36. But we can also take advantage, in particular to avoid "manually" creating base relocations for xen.efi. Since it was requested and is possible with up-to-date binutils, inclusion of debug info in xen.efi is another part here. The other changes here are cleanup related to both the work here as well as the one to make binutils fit for our purposes. 1: EFI: drop stale section special casing when generating base relocs 2: EFI: sections may not live at VA 0 in PE binaries 3: EFI: program headers are an ELF concept 4: EFI: redo .reloc section bounds determination 5: drop use of prelink-efi.o 6: EFI: avoid use of GNU ld's --disable-reloc-section when possible 7: EFI: keep debug info in xen.efi 8: EFI: don't have an overly large image size Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 01 09:44:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 09:44:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104225.199085 (Exim 4.92) (envelope-from ) id 1lRtsH-0004PQ-Au; Thu, 01 Apr 2021 09:44:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104225.199085; Thu, 01 Apr 2021 09:44:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRtsH-0004PJ-6I; Thu, 01 Apr 2021 09:44:25 +0000 Received: by outflank-mailman (input) for mailman id 104225; Thu, 01 Apr 2021 09:44:23 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRtsF-0004OP-5T for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 09:44:23 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f93c7e43-ff02-4be7-8954-a579a24e35d6; Thu, 01 Apr 2021 09:44:22 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 97E67AEA6; Thu, 1 Apr 2021 09:44:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f93c7e43-ff02-4be7-8954-a579a24e35d6 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617270261; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T3WVBUNZlwkjFctAwYGueyDD3YPIMV4/P6HSt5pzgHA=; b=NUcZU/GoXoDLtUTyg8NorkhNCs9ED7+rX+WfQPPsdOcH6v1cFfA9JS/pISL1iVJFY84d5g sUE62iTiyq9PFQdB1700hkojGl0u5V+cOIAp5qAEfX+tC6Ejt8VnYof4AVjN0OR4o5UYZY ysql3Jogls1tBttB2PzqOMxx/2nPu6s= Subject: [PATCH 1/8] x86/EFI: drop stale section special casing when generating base relocs From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Message-ID: <63ad859f-82f0-62ea-5e55-9c6d3db6816e@suse.com> Date: Thu, 1 Apr 2021 11:44:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit As of commit a6066af5b142 ("xen/init: Annotate all command line parameter infrastructure as const") .init.setup has been part of .init. As of commit 544ad7f5caf5 ("xen/init: Move initcall infrastructure into .init.data") .initcall* have been part of .init. Hence neither can be encountered as a stand-alone section in the final binaries anymore. Signed-off-by: Jan Beulich --- a/xen/arch/x86/efi/mkreloc.c +++ b/xen/arch/x86/efi/mkreloc.c @@ -346,9 +346,7 @@ int main(int argc, char *argv[]) * Don't generate relocations for sections that definitely * aren't used by the boot loader code. */ - if ( memcmp(sec1[i].name, ".initcal", sizeof(sec1[i].name)) == 0 || - memcmp(sec1[i].name, ".init.se", sizeof(sec1[i].name)) == 0 || - memcmp(sec1[i].name, ".buildid", sizeof(sec1[i].name)) == 0 || + if ( memcmp(sec1[i].name, ".buildid", sizeof(sec1[i].name)) == 0 || memcmp(sec1[i].name, ".lockpro", sizeof(sec1[i].name)) == 0 ) continue; From xen-devel-bounces@lists.xenproject.org Thu Apr 01 09:44:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 09:44:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104227.199098 (Exim 4.92) (envelope-from ) id 1lRtsf-0004Vf-Hw; Thu, 01 Apr 2021 09:44:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104227.199098; Thu, 01 Apr 2021 09:44:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRtsf-0004VY-Ep; Thu, 01 Apr 2021 09:44:49 +0000 Received: by outflank-mailman (input) for mailman id 104227; Thu, 01 Apr 2021 09:44:48 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRtsd-0004VQ-Um for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 09:44:47 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id fe3208f1-ecda-432e-992b-d7c37b5347b1; Thu, 01 Apr 2021 09:44:46 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 103B1AEB6; Thu, 1 Apr 2021 09:44:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fe3208f1-ecda-432e-992b-d7c37b5347b1 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617270286; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DTY3+YpVaKr0M5lxEi40/UGmLAUNw4TGq/wK3vHEKos=; b=RMb8FYQPGQ4y2QUArjxQ8e8E9Ki9Di/g32LAqqoALfhUEAYYcyRsoG6ubbRT+syvdahlPu lXOaLpqN4iKXypG7Dci1xCZ5NpTMPOqT1r5+HjsoJ3UbWNQVFfiwMyVHhWGHGcLdoHIwBu gVDLQzqmktH+1xJiyWBW2AilaEM3PEc= Subject: [PATCH 2/8] x86/EFI: sections may not live at VA 0 in PE binaries From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Message-ID: <5d7c61b0-8441-dccc-4917-cc8a436fd96f@suse.com> Date: Thu, 1 Apr 2021 11:44:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit PE binaries specify section addresses by (32-bit) RVA. GNU ld up to at least 2.36 would silently truncate the (negative) difference when a section is placed below the image base. Such sections would also be wrongly placed ahead of all "normal" ones. Since, for the time being, we build xen.efi with --strip-debug anyway, .stab* can't appear. And .comment has an entry in /DISCARD/ already anyway in the EFI case. Because of their unclear origin, keep the directives for the ELF case though. Signed-off-by: Jan Beulich --- It's certainly odd that we have stabs section entries in the script, but no Dwarf ones. --- a/xen/arch/x86/xen.lds.S +++ b/xen/arch/x86/xen.lds.S @@ -347,6 +347,7 @@ SECTIONS #endif } +#ifndef EFI /* Stabs debugging sections. */ .stab 0 : { *(.stab) } .stabstr 0 : { *(.stabstr) } @@ -355,6 +356,7 @@ SECTIONS .stab.index 0 : { *(.stab.index) } .stab.indexstr 0 : { *(.stab.indexstr) } .comment 0 : { *(.comment) } +#endif } ASSERT(__2M_rwdata_end <= XEN_VIRT_END - XEN_VIRT_START + __XEN_VIRT_START - From xen-devel-bounces@lists.xenproject.org Thu Apr 01 09:45:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 09:45:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104230.199110 (Exim 4.92) (envelope-from ) id 1lRtt2-0004cl-Vj; Thu, 01 Apr 2021 09:45:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104230.199110; Thu, 01 Apr 2021 09:45:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRtt2-0004cc-Ru; Thu, 01 Apr 2021 09:45:12 +0000 Received: by outflank-mailman (input) for mailman id 104230; Thu, 01 Apr 2021 09:45:11 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRtt1-0004cP-P5 for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 09:45:11 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id fdc01e63-a97f-4d35-a452-27dddd54c2a6; Thu, 01 Apr 2021 09:45:10 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 25BD5AEC2; Thu, 1 Apr 2021 09:45:10 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fdc01e63-a97f-4d35-a452-27dddd54c2a6 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617270310; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zGF5/no4yyDySevuLNlCcruxFje6e6BtvrRRyJsweIc=; b=QUl1VmTsvmGOtkCxbMHlKH6XDNRr9b7AwnLSaHzocfueemup8rnq/nu2jKjyszFeQrYutJ SNbJT0+x7uqF1oj9w54L+o8q/r+E8kMivj2Flaicqsdws1y3n5zm31BM/OcOUyyxXZN7j3 lkLiPaFKQGTkXhj/dR9EGEPor/nN7T8= Subject: [PATCH 3/8] x86/EFI: program headers are an ELF concept From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Message-ID: <017478f9-76d2-4dc4-de93-b662c4552968@suse.com> Date: Thu, 1 Apr 2021 11:45:09 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit While they apparently do no harm when building xen.efi, their use is potentially misleading. Conditionalize their use to be for just the ELF binary we produce. No change to the resulting binaries. Signed-off-by: Jan Beulich --- a/xen/arch/x86/xen.lds.S +++ b/xen/arch/x86/xen.lds.S @@ -34,13 +34,19 @@ OUTPUT_FORMAT(FORMAT, FORMAT, FORMAT) OUTPUT_ARCH(i386:x86-64) +#ifndef EFI PHDRS { text PT_LOAD ; -#if (defined(BUILD_ID) || defined (CONFIG_PVH_GUEST)) && !defined(EFI) +#if defined(BUILD_ID) || defined(CONFIG_PVH_GUEST) note PT_NOTE ; #endif } +#define PHDR(x) :x +#else +#define PHDR(x) +#endif + SECTIONS { #if !defined(EFI) @@ -83,7 +89,7 @@ SECTIONS *(.text.kexec) *(.gnu.warning) _etext = .; /* End of text section */ - } :text = 0x9090 + } PHDR(text) = 0x9090 . = ALIGN(SECTION_ALIGN); __2M_text_end = .; @@ -134,7 +140,7 @@ SECTIONS *(SORT(.data.vpci.*)) __end_vpci_array = .; #endif - } :text + } PHDR(text) #if defined(CONFIG_PVH_GUEST) && !defined(EFI) DECL_SECTION(.note.Xen) { @@ -160,7 +166,7 @@ SECTIONS __note_gnu_build_id_start = .; *(.buildid) __note_gnu_build_id_end = .; - } :text + } #endif #endif @@ -260,7 +266,7 @@ SECTIONS *(SORT(.data.vpci.*)) __end_vpci_array = .; #endif - } :text + } PHDR(text) . = ALIGN(SECTION_ALIGN); __init_end = .; @@ -281,7 +287,7 @@ SECTIONS *(.data.paramhypfs) __paramhypfs_end = .; #endif - } :text + } PHDR(text) DECL_SECTION(.data) { *(.data.page_aligned) @@ -289,7 +295,7 @@ SECTIONS *(.data.rel) *(.data.rel.*) CONSTRUCTORS - } :text + } PHDR(text) DECL_SECTION(.bss) { __bss_start = .; @@ -306,7 +312,7 @@ SECTIONS *(.bss) . = ALIGN(POINTER_ALIGN); __bss_end = .; - } :text + } PHDR(text) _end = . ; . = ALIGN(SECTION_ALIGN); @@ -316,12 +322,12 @@ SECTIONS . = ALIGN(4); DECL_SECTION(.reloc) { *(.reloc) - } :text + } /* Trick the linker into setting the image size to exactly 16Mb. */ . = ALIGN(__section_alignment__); DECL_SECTION(.pad) { . = ALIGN(MB(16)); - } :text + } #endif #ifndef XEN_BUILD_EFI From xen-devel-bounces@lists.xenproject.org Thu Apr 01 09:45:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 09:45:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104236.199121 (Exim 4.92) (envelope-from ) id 1lRttV-0004ju-87; Thu, 01 Apr 2021 09:45:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104236.199121; Thu, 01 Apr 2021 09:45:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRttV-0004jn-55; Thu, 01 Apr 2021 09:45:41 +0000 Received: by outflank-mailman (input) for mailman id 104236; Thu, 01 Apr 2021 09:45:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRttU-0004je-7R for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 09:45:40 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 36a9c5e2-07e6-440f-9656-22fac216e603; Thu, 01 Apr 2021 09:45:39 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 888FEAEF5; Thu, 1 Apr 2021 09:45:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 36a9c5e2-07e6-440f-9656-22fac216e603 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617270338; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UKBqIqEP4Yay9/oLsxxVgXNUOGzjbOD2XiVhg/zRm+8=; b=OMjhq7Xrj0Yd6y7h4Txz18Q+XpBGF/zE1K7PXE6yQA8Dnb68sum0FQamoFRoYm+rhaf9Mp 9DPcAVdioNm+lB6A6aoQEkGQZW/m8ihhqdi6JCJ7kxAz0FBFAxX2dHElsiH/qotTclg+lu yri3lBTmdwAEgOrFbmvbDdk17nOY8Dw= Subject: [PATCH 4/8] x86/EFI: redo .reloc section bounds determination From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Message-ID: Date: Thu, 1 Apr 2021 11:45:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit There's no need to link relocs-dummy.o into the ELF binary. The two symbols needed can as well be provided by the linker script. Then our mkreloc tool also doesn't need to put them in the generated assembler source. Signed-off-by: Jan Beulich --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -133,7 +133,6 @@ XEN_NO_PE_FIXUPS := $(if $(XEN_BUILD_EFI endif ALL_OBJS := $(BASEDIR)/arch/x86/boot/built_in.o $(BASEDIR)/arch/x86/efi/built_in.o $(ALL_OBJS) -EFI_OBJS-$(XEN_BUILD_EFI) := efi/relocs-dummy.o ifeq ($(CONFIG_LTO),y) # Gather all LTO objects together @@ -141,13 +140,13 @@ prelink_lto.o: $(ALL_OBJS) $(ALL_LIBS) $(LD_LTO) -r -o $@ $(filter-out %.a,$^) --start-group $(filter %.a,$^) --end-group # Link it with all the binary objects -prelink.o: $(patsubst %/built_in.o,%/built_in_bin.o,$(ALL_OBJS)) prelink_lto.o $(EFI_OBJS-y) FORCE +prelink.o: $(patsubst %/built_in.o,%/built_in_bin.o,$(ALL_OBJS)) prelink_lto.o FORCE $(call if_changed,ld) prelink-efi.o: $(patsubst %/built_in.o,%/built_in_bin.o,$(ALL_OBJS)) prelink_lto.o FORCE $(call if_changed,ld) else -prelink.o: $(ALL_OBJS) $(ALL_LIBS) $(EFI_OBJS-y) FORCE +prelink.o: $(ALL_OBJS) $(ALL_LIBS) FORCE $(call if_changed,ld) prelink-efi.o: $(ALL_OBJS) $(ALL_LIBS) FORCE --- a/xen/arch/x86/efi/mkreloc.c +++ b/xen/arch/x86/efi/mkreloc.c @@ -320,9 +320,7 @@ int main(int argc, char *argv[]) } puts("\t.section .reloc, \"a\", @progbits\n" - "\t.balign 4\n" - "\t.globl __base_relocs_start, __base_relocs_end\n" - "__base_relocs_start:"); + "\t.balign 4"); for ( i = 0; i < nsec; ++i ) { @@ -373,8 +371,6 @@ int main(int argc, char *argv[]) diff_sections(NULL, NULL, NULL, 0, 0, 0, 0); - puts("__base_relocs_end:"); - close(in1); close(in2); --- a/xen/arch/x86/efi/relocs-dummy.S +++ b/xen/arch/x86/efi/relocs-dummy.S @@ -1,10 +1,8 @@ .section .reloc, "a", @progbits .balign 4 -GLOBAL(__base_relocs_start) .long 0 .long 8 -GLOBAL(__base_relocs_end) .globl VIRT_START, ALT_START .equ VIRT_START, XEN_VIRT_START --- a/xen/arch/x86/xen.lds.S +++ b/xen/arch/x86/xen.lds.S @@ -170,18 +170,6 @@ SECTIONS #endif #endif -/* - * ELF builds are linked to a fixed virtual address, and in principle - * shouldn't have a .reloc section. However, due to the way EFI support is - * currently implemented, retaining the .reloc section is necessary. - */ -#if defined(XEN_BUILD_EFI) && !defined(EFI) - . = ALIGN(4); - DECL_SECTION(.reloc) { - *(.reloc) - } :text -#endif - _erodata = .; . = ALIGN(SECTION_ALIGN); @@ -319,18 +307,27 @@ SECTIONS __2M_rwdata_end = .; #ifdef EFI - . = ALIGN(4); - DECL_SECTION(.reloc) { + .reloc ALIGN(4) : { + __base_relocs_start = .; *(.reloc) + __base_relocs_end = .; } /* Trick the linker into setting the image size to exactly 16Mb. */ . = ALIGN(__section_alignment__); DECL_SECTION(.pad) { . = ALIGN(MB(16)); } -#endif - -#ifndef XEN_BUILD_EFI +#elif defined(XEN_BUILD_EFI) + /* + * Due to the way EFI support is currently implemented, these two symbols + * need to be defined. Their precise values shouldn't matter (the consuming + * function doesn't get called), but to be on the safe side both values would + * better match. Of course the need to be reachable by the relocations + * referencing them. + */ + PROVIDE(__base_relocs_start = .); + PROVIDE(__base_relocs_end = .); +#else efi = .; #endif From xen-devel-bounces@lists.xenproject.org Thu Apr 01 09:46:03 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 09:46:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104237.199134 (Exim 4.92) (envelope-from ) id 1lRttr-0004qH-Gi; Thu, 01 Apr 2021 09:46:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104237.199134; Thu, 01 Apr 2021 09:46:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRttr-0004qA-Dg; Thu, 01 Apr 2021 09:46:03 +0000 Received: by outflank-mailman (input) for mailman id 104237; Thu, 01 Apr 2021 09:46:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRttq-0004pv-8H for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 09:46:02 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 07af8a97-5e05-44aa-8f35-8a8b086b82e3; Thu, 01 Apr 2021 09:46:01 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CBB9FAEB6; Thu, 1 Apr 2021 09:46:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 07af8a97-5e05-44aa-8f35-8a8b086b82e3 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617270360; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qw1kb41OPZcRbU+DKLj0F67252xeEtyBQIm85C/nQy0=; b=G9I0SyuKAvHYvcionj9PHoTEsg5cT12638o2mJHraetOulmhy92uf9M3s2SS6EGY1EOu3/ JgN00BRJrlCtxgFlWgatXv5m4KFUTSniFS151jC/nnIHGPXhlOx+aXJJcDCKvlhfemE9nY LY1tGzynz+Rv5PCBEZUAzhusjvm5mRY= Subject: [PATCH 5/8] x86: drop use of prelink-efi.o From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Message-ID: Date: Thu, 1 Apr 2021 11:46:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Now that its contents matches prelink.o, use that one uniformly. Signed-off-by: Jan Beulich --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -142,18 +142,12 @@ prelink_lto.o: $(ALL_OBJS) $(ALL_LIBS) # Link it with all the binary objects prelink.o: $(patsubst %/built_in.o,%/built_in_bin.o,$(ALL_OBJS)) prelink_lto.o FORCE $(call if_changed,ld) - -prelink-efi.o: $(patsubst %/built_in.o,%/built_in_bin.o,$(ALL_OBJS)) prelink_lto.o FORCE - $(call if_changed,ld) else prelink.o: $(ALL_OBJS) $(ALL_LIBS) FORCE $(call if_changed,ld) - -prelink-efi.o: $(ALL_OBJS) $(ALL_LIBS) FORCE - $(call if_changed,ld) endif -targets += prelink.o prelink-efi.o +targets += prelink.o $(TARGET)-syms: prelink.o xen.lds $(LD) $(XEN_LDFLAGS) -T xen.lds -N prelink.o $(build_id_linker) \ @@ -214,7 +208,7 @@ endif note_file_option ?= $(note_file) ifeq ($(XEN_BUILD_PE),y) -$(TARGET).efi: prelink-efi.o $(note_file) efi.lds efi/relocs-dummy.o efi/mkreloc +$(TARGET).efi: prelink.o $(note_file) efi.lds efi/relocs-dummy.o efi/mkreloc $(foreach base, $(VIRT_BASE) $(ALT_BASE), \ $(LD) $(call EFI_LDFLAGS,$(base)) -T efi.lds -N $< efi/relocs-dummy.o \ $(BASEDIR)/common/symbols-dummy.o $(note_file_option) -o $(@D)/.$(@F).$(base).0 &&) : From xen-devel-bounces@lists.xenproject.org Thu Apr 01 09:46:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 09:46:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104243.199146 (Exim 4.92) (envelope-from ) id 1lRtuZ-0004ym-RC; Thu, 01 Apr 2021 09:46:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104243.199146; Thu, 01 Apr 2021 09:46:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRtuZ-0004yf-O0; Thu, 01 Apr 2021 09:46:47 +0000 Received: by outflank-mailman (input) for mailman id 104243; Thu, 01 Apr 2021 09:46:47 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRtuZ-0004ya-6A for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 09:46:47 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cc901f13-5f8e-4bce-96b6-4acdf0a0893d; Thu, 01 Apr 2021 09:46:46 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4E513AEB6; Thu, 1 Apr 2021 09:46:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc901f13-5f8e-4bce-96b6-4acdf0a0893d X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617270405; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BW+wzkzMZPCZQCOdltyTqhUeMxSr4FMBEpHB0pwsBlk=; b=QA0d1jBVxRK9qyx0STCHg7XtbyTxZB614ga8ZOiQZDa7LJYDb9fpTIVSEgX0wpCAj5Uj/A PTMiFHE9C3KtfcDB069FojpWeBMvgco0MXy3CsEtMM9gTspbvzWklIQSyMY3PLvggsg57L 8s29XUIpgzcdhotAk7necnZHqSNmYUw= Subject: [PATCH 6/8] x86/EFI: avoid use of GNU ld's --disable-reloc-section when possible From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Message-ID: Date: Thu, 1 Apr 2021 11:46:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit As of commit 6fa7408d72b3 ("ld: don't generate base relocations in PE output for absolute symbols") I'm feeling sufficiently confident in GNU ld to use its logic for generating base relocations, which was enabled for executables at some point last year (prior to that this would have got done only for DLLs). GNU ld, seeing the original relocations coming from the ELF object files, generates different relocation types for our page tables (64-bit ones, while mkreloc produces 32-bit ones). This requires also permitting and handling that type in efi_arch_relocate_image(). Signed-off-by: Jan Beulich --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -120,18 +120,37 @@ $(TARGET): $(TARGET)-syms $(efi-y) boot/ mv $(TMP) $(TARGET) ifneq ($(efi-y),) + # Check if the compiler supports the MS ABI. export XEN_BUILD_EFI := $(shell $(CC) $(XEN_CFLAGS) -c efi/check.c -o efi/check.o 2>/dev/null && echo y) +CFLAGS-$(XEN_BUILD_EFI) += -DXEN_BUILD_EFI + # Check if the linker supports PE. EFI_LDFLAGS = $(patsubst -m%,-mi386pep,$(XEN_LDFLAGS)) --subsystem=10 --strip-debug XEN_BUILD_PE := $(if $(XEN_BUILD_EFI),$(shell $(LD) $(EFI_LDFLAGS) -o efi/check.efi efi/check.o 2>/dev/null && echo y)) -CFLAGS-$(XEN_BUILD_EFI) += -DXEN_BUILD_EFI -# Check if the linker produces fixups in PE by default (we need to disable it doing so for now). -XEN_NO_PE_FIXUPS := $(if $(XEN_BUILD_EFI), \ - $(shell $(LD) $(EFI_LDFLAGS) --disable-reloc-section -o efi/check.efi efi/check.o 2>/dev/null && \ - echo --disable-reloc-section)) + +ifeq ($(XEN_BUILD_PE),y) + +# Check if the linker produces fixups in PE by default +nr-fixups := $(shell $(OBJDUMP) -p efi/check.efi | grep '^[[:blank:]]*reloc[[:blank:]]*[0-9][[:blank:]].*DIR64$$' | wc -l) +ifeq ($(nr-fixups),2) +MKRELOC := : +relocs-dummy := +else +MKRELOC := efi/mkreloc +relocs-dummy := efi/relocs-dummy.o +# If the linker produced fixups but not precisely two of them, we need to +# disable it doing so. But if it didn't produce any fixups, it also wouldn't +# recognize the option. +ifneq ($(nr-fixups),0) +EFI_LDFLAGS += --disable-reloc-section +endif endif +endif # $(XEN_BUILD_PE) + +endif # $(efi-y) + ALL_OBJS := $(BASEDIR)/arch/x86/boot/built_in.o $(BASEDIR)/arch/x86/efi/built_in.o $(ALL_OBJS) ifeq ($(CONFIG_LTO),y) @@ -175,7 +194,7 @@ note.o: $(TARGET)-syms --rename-section=.data=.note.gnu.build-id -S $@.bin $@ rm -f $@.bin -EFI_LDFLAGS += --image-base=$(1) --stack=0,0 --heap=0,0 $(XEN_NO_PE_FIXUPS) +EFI_LDFLAGS += --image-base=$(1) --stack=0,0 --heap=0,0 EFI_LDFLAGS += --section-alignment=0x200000 --file-alignment=0x20 EFI_LDFLAGS += --major-image-version=$(XEN_VERSION) EFI_LDFLAGS += --minor-image-version=$(XEN_SUBVERSION) @@ -189,7 +208,11 @@ EFI_LDFLAGS += --no-insert-timestamp endif $(TARGET).efi: VIRT_BASE = 0x$(shell $(NM) efi/relocs-dummy.o | sed -n 's, A VIRT_START$$,,p') +ifeq ($(MKRELOC),:) +$(TARGET).efi: ALT_BASE := +else $(TARGET).efi: ALT_BASE = 0x$(shell $(NM) efi/relocs-dummy.o | sed -n 's, A ALT_START$$,,p') +endif ifneq ($(build_id_linker),) ifeq ($(call ld-ver-build-id,$(LD) $(filter -m%,$(EFI_LDFLAGS))),y) @@ -210,16 +233,16 @@ note_file_option ?= $(note_file) ifeq ($(XEN_BUILD_PE),y) $(TARGET).efi: prelink.o $(note_file) efi.lds efi/relocs-dummy.o efi/mkreloc $(foreach base, $(VIRT_BASE) $(ALT_BASE), \ - $(LD) $(call EFI_LDFLAGS,$(base)) -T efi.lds -N $< efi/relocs-dummy.o \ + $(LD) $(call EFI_LDFLAGS,$(base)) -T efi.lds -N $< $(relocs-dummy) \ $(BASEDIR)/common/symbols-dummy.o $(note_file_option) -o $(@D)/.$(@F).$(base).0 &&) : - efi/mkreloc $(foreach base,$(VIRT_BASE) $(ALT_BASE),$(@D)/.$(@F).$(base).0) >$(@D)/.$(@F).0r.S + $(MKRELOC) $(foreach base,$(VIRT_BASE) $(ALT_BASE),$(@D)/.$(@F).$(base).0) >$(@D)/.$(@F).0r.S $(NM) -pa --format=sysv $(@D)/.$(@F).$(VIRT_BASE).0 \ | $(BASEDIR)/tools/symbols $(all_symbols) --sysv --sort >$(@D)/.$(@F).0s.S $(MAKE) -f $(BASEDIR)/Rules.mk $(@D)/.$(@F).0r.o $(@D)/.$(@F).0s.o $(foreach base, $(VIRT_BASE) $(ALT_BASE), \ $(LD) $(call EFI_LDFLAGS,$(base)) -T efi.lds -N $< \ $(@D)/.$(@F).0r.o $(@D)/.$(@F).0s.o $(note_file_option) -o $(@D)/.$(@F).$(base).1 &&) : - efi/mkreloc $(foreach base,$(VIRT_BASE) $(ALT_BASE),$(@D)/.$(@F).$(base).1) >$(@D)/.$(@F).1r.S + $(MKRELOC) $(foreach base,$(VIRT_BASE) $(ALT_BASE),$(@D)/.$(@F).$(base).1) >$(@D)/.$(@F).1r.S $(NM) -pa --format=sysv $(@D)/.$(@F).$(VIRT_BASE).1 \ | $(BASEDIR)/tools/symbols $(all_symbols) --sysv --sort >$(@D)/.$(@F).1s.S $(MAKE) -f $(BASEDIR)/Rules.mk $(@D)/.$(@F).1r.o $(@D)/.$(@F).1s.o --- a/xen/arch/x86/efi/check.c +++ b/xen/arch/x86/efi/check.c @@ -2,3 +2,17 @@ int __attribute__((__ms_abi__)) test(int { return i; } + +/* + * Populate an array with "addresses" of relocatable and absolute values. + * This is to probe ld for (a) emitting base relocations at all and (b) not + * emitting base relocations for absolute symbols. + */ +extern const unsigned char __image_base__[], __file_alignment__[], + __section_alignment__[]; +const void *const data[] = { + __image_base__, + __file_alignment__, + __section_alignment__, + data, +}; --- a/xen/arch/x86/efi/efi-boot.h +++ b/xen/arch/x86/efi/efi-boot.h @@ -86,10 +86,12 @@ static void __init efi_arch_relocate_ima } break; case PE_BASE_RELOC_DIR64: - if ( in_page_tables(addr) ) - blexit(L"Unexpected relocation type"); if ( delta ) + { *(u64 *)addr += delta; + if ( in_page_tables(addr) ) + *(u64 *)addr += xen_phys_start; + } break; default: blexit(L"Unsupported relocation type"); From xen-devel-bounces@lists.xenproject.org Thu Apr 01 09:47:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 09:47:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104245.199158 (Exim 4.92) (envelope-from ) id 1lRtus-00054u-41; Thu, 01 Apr 2021 09:47:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104245.199158; Thu, 01 Apr 2021 09:47:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRtus-00054m-0K; Thu, 01 Apr 2021 09:47:06 +0000 Received: by outflank-mailman (input) for mailman id 104245; Thu, 01 Apr 2021 09:47:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRtur-00054Z-HI for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 09:47:05 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1cedc735-e67c-4fd3-b3fd-a3ade7a64f7d; Thu, 01 Apr 2021 09:47:04 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C87BFB0B6; Thu, 1 Apr 2021 09:47:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1cedc735-e67c-4fd3-b3fd-a3ade7a64f7d X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617270423; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o2EMpahlSBM5Magli3m1RMCkPQybjV8l/PK9GMnPLmI=; b=pyG33BoBKNqh7bKndDihnYJWbrqGNE5DK7MQa6a7s730/1pOyToVOEbh1ElA+RW8aP8mGI j6ExHf/YppHC+gqjtAicxfELVry+5DFPYeW1Ma1D2PcIFRKeQBxiJwmv/434TONklvlSWY ZyYuUyaFNeCaKtIWlLKyLb2shXC5okQ= Subject: [PATCH 7/8] x86/EFI: keep debug info in xen.efi From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Message-ID: <96cb4039-5f43-8eac-d855-c9f1587ed2d0@suse.com> Date: Thu, 1 Apr 2021 11:47:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit ... provided the linker supports it (which it does as of commit 2dfa8341e079 ["ELF DWARF in PE output"]). Without mentioning debugging sections, the linker would put them at VA 0, thus making them unreachable by 32-bit (relative or absolute) relocations. If relocations were resolvable (or absent) the resulting binary would have invalid section RVAs (0 - __image_base__, truncated to 32 bits). Mentioning debugging sections without specifying an address will result in the linker putting them all on the same RVA. A loader is, afaict, free to reject loading such an image, as sections shouldn't overlap. (The above describes GNU ld 2.36 behavior, which - if deemed buggy - could change.) Make sure our up-to-16Mb padding doesn't unnecessarily further extend the image. Take the opportunity and also switch to using $(call ld-option,...). Requested-by: Andrew Cooper Signed-off-by: Jan Beulich --- This way we could also avoid discarding .comment for xen.efi. I'd like to point out that the linking of the debug info takes far longer than the linking of the "normal" parts of the image. The change therefore has the downside of slowing down debug builds. --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -126,8 +126,14 @@ export XEN_BUILD_EFI := $(shell $(CC) $( CFLAGS-$(XEN_BUILD_EFI) += -DXEN_BUILD_EFI # Check if the linker supports PE. -EFI_LDFLAGS = $(patsubst -m%,-mi386pep,$(XEN_LDFLAGS)) --subsystem=10 --strip-debug -XEN_BUILD_PE := $(if $(XEN_BUILD_EFI),$(shell $(LD) $(EFI_LDFLAGS) -o efi/check.efi efi/check.o 2>/dev/null && echo y)) +EFI_LDFLAGS = $(patsubst -m%,-mi386pep,$(XEN_LDFLAGS)) --subsystem=10 +XEN_BUILD_PE := $(if $(XEN_BUILD_EFI),$(call ld-option,$(EFI_LDFLAGS) --image-base=0x100000000 -o efi/check.efi efi/check.o)) +# If the above failed, it may be merely because of the linker not dealing well +# with debug info. Try again with stripping it. +ifeq ($(CONFIG_DEBUG_INFO)-$(XEN_BUILD_PE),y-n) +EFI_LDFLAGS += --strip-debug +XEN_BUILD_PE := $(call ld-option,$(EFI_LDFLAGS) --image-base=0x100000000 -o efi/check.efi efi/check.o) +endif ifeq ($(XEN_BUILD_PE),y) @@ -232,6 +238,9 @@ note_file_option ?= $(note_file) ifeq ($(XEN_BUILD_PE),y) $(TARGET).efi: prelink.o $(note_file) efi.lds efi/relocs-dummy.o efi/mkreloc +ifeq ($(CONFIG_DEBUG_INFO),y) + $(if $(filter --strip-debug,$(EFI_LDFLAGS)),echo,:) "Will strip debug info from $(@F)" +endif $(foreach base, $(VIRT_BASE) $(ALT_BASE), \ $(LD) $(call EFI_LDFLAGS,$(base)) -T efi.lds -N $< $(relocs-dummy) \ $(BASEDIR)/common/symbols-dummy.o $(note_file_option) -o $(@D)/.$(@F).$(base).0 &&) : --- a/xen/arch/x86/xen.lds.S +++ b/xen/arch/x86/xen.lds.S @@ -312,10 +312,60 @@ SECTIONS *(.reloc) __base_relocs_end = .; } - /* Trick the linker into setting the image size to exactly 16Mb. */ - . = ALIGN(__section_alignment__); - DECL_SECTION(.pad) { - . = ALIGN(MB(16)); + .debug_abbrev ALIGN(1) (NOLOAD) : { + *(.debug_abbrev) + } + .debug_info ALIGN(1) (NOLOAD) : { + *(.debug_info) + *(.gnu.linkonce.wi.*) + } + .debug_types ALIGN(1) (NOLOAD) : { + *(.debug_types) + } + .debug_str ALIGN(1) (NOLOAD) : { + *(.debug_str) + } + .debug_line ALIGN(1) (NOLOAD) : { + *(.debug_line) + *(.debug_line.*) + } + .debug_line_str ALIGN(1) (NOLOAD) : { + *(.debug_line_str) + } + .debug_names ALIGN(4) (NOLOAD) : { + *(.debug_names) + } + .debug_frame ALIGN(4) (NOLOAD) : { + *(.debug_frame) + } + .debug_loc ALIGN(1) (NOLOAD) : { + *(.debug_loc) + } + .debug_loclists ALIGN(4) (NOLOAD) : { + *(.debug_loclists) + } + .debug_ranges ALIGN(8) (NOLOAD) : { + *(.debug_ranges) + } + .debug_rnglists ALIGN(4) (NOLOAD) : { + *(.debug_rnglists) + } + .debug_addr ALIGN(8) (NOLOAD) : { + *(.debug_addr) + } + .debug_aranges ALIGN(1) (NOLOAD) : { + *(.debug_aranges) + } + .debug_pubnames ALIGN(1) (NOLOAD) : { + *(.debug_pubnames) + } + .debug_pubtypes ALIGN(1) (NOLOAD) : { + *(.debug_pubtypes) + } + /* Trick the linker into setting the image size to no less than 16Mb. */ + __image_end__ = .; + .pad ALIGN(__section_alignment__) : { + . = __image_end__ < __image_base__ + MB(16) ? ALIGN(MB(16)) : .; } #elif defined(XEN_BUILD_EFI) /* From xen-devel-bounces@lists.xenproject.org Thu Apr 01 09:47:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 09:47:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104251.199170 (Exim 4.92) (envelope-from ) id 1lRtvO-0005DI-KV; Thu, 01 Apr 2021 09:47:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104251.199170; Thu, 01 Apr 2021 09:47:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRtvO-0005DB-HK; Thu, 01 Apr 2021 09:47:38 +0000 Received: by outflank-mailman (input) for mailman id 104251; Thu, 01 Apr 2021 09:47:37 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRtvN-0005Cz-4u for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 09:47:37 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 44e4df5d-2e9a-4bf3-98ab-d0a39461290f; Thu, 01 Apr 2021 09:47:36 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9BECEAEB6; Thu, 1 Apr 2021 09:47:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 44e4df5d-2e9a-4bf3-98ab-d0a39461290f X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617270455; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JPanjNLWZj0sfyOALMrDaazSMh9LoXOd8c9exdMQnew=; b=IGPv4OtotCts8m+MoUtRP6JYnk/FVJHi1tVHu/JVgErsRzCK/DksCt6VfCJYbaS2WHPC8/ dSl1Uso+7FMg0+S8GuLdj8/bLIO6JZupV0hAEY3eCi+vaSuCR79TyOkSdqOjFJ1QX3ntow VjABFEfXljVhN/pf9XhU83uNOl4knKM= Subject: [PATCH 8/8] x86/EFI: don't have an overly large image size From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Message-ID: <26ec4a83-cda9-5193-d797-357c05b26ab7@suse.com> Date: Thu, 1 Apr 2021 11:47:35 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit While without debug info the difference is benign (so far), since we pad the image to 16Mb anyway, forcing the .reloc section to a 2Mb boundary causes subsequent .debug_* sections to go farther beyond 16Mb than needed. There's no reason to advance . for establishing __2M_rwdata_end, as all data past _end is of no interest at runtime anymore anyway. Signed-off-by: Jan Beulich --- This makes more explicit a possible latent problem with the ELF image: It ends at _end, not __2M_rwdata_end (advancing . as was done here does not have the effect of increasing the image size). Interestingly the conversion xen-syms => xen rounds up the program header specified size suitably, as per the comment "Do not use p_memsz: it does not include BSS alignment padding" in mkelf32.c. I do think this would instead want taking care of in the linker script. Commit 7a95e0a2c572 ("x86: properly calculate xen ELF end of image address") clearly only hacked an existing hack rather than addressing the root cause. Thoughts? --- a/xen/arch/x86/xen.lds.S +++ b/xen/arch/x86/xen.lds.S @@ -303,8 +303,7 @@ SECTIONS } PHDR(text) _end = . ; - . = ALIGN(SECTION_ALIGN); - __2M_rwdata_end = .; + __2M_rwdata_end = ALIGN(SECTION_ALIGN); #ifdef EFI .reloc ALIGN(4) : { From xen-devel-bounces@lists.xenproject.org Thu Apr 01 09:51:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 09:51:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104254.199182 (Exim 4.92) (envelope-from ) id 1lRtyc-00066M-3i; Thu, 01 Apr 2021 09:50:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104254.199182; Thu, 01 Apr 2021 09:50:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRtyc-00066F-0f; Thu, 01 Apr 2021 09:50:58 +0000 Received: by outflank-mailman (input) for mailman id 104254; Thu, 01 Apr 2021 09:50:56 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRtyZ-00066A-VM for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 09:50:56 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 33041b3f-6611-48bd-8cfd-77b002683ab6; Thu, 01 Apr 2021 09:50:54 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 33041b3f-6611-48bd-8cfd-77b002683ab6 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617270654; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=GLBfyHpN38hVaa44ERXEym7AISBLwU7MwNIppvSFeNs=; b=Xoz6NRpq8SIwnRwCPbBSVePt9NtNwFgRYOP92koxZQ+3XrquF8/npFDz jAUfrK7qTjrhSSziVHT1ir7WLdoHtWTOt+SIrTmOzYQ67UgEx2HOXYPU8 xYF1AEnDh1xi9zfbQjVFcrjfCuZ+NyVZ+DPjy7KeiIEYS+ppariChKnR7 s=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: Abfrjz3cXdMX1fnzbRU4GUuJebJ3HGdEd+dP9pxL33nMgW4880sgBtAOhvghAr2he+MUEaBQAP gOEezJt9x3PNmk91nhzr8XTzM5HlWNpOC5NbYNZsmHg4UsVmscBOR9jCVPj+sUGKzZ7VQwXIhj 6HraLTV/maObd+S2W7UWFC22vpHXtr88qOZCy4Yz3YR6R1NB1uj/3Fs62p1S982lKJOlDM/RW3 7UXmKKm2Y12qQpql8FzDtgd/QxjRg5H9YqZ8bZzPgihJQ05vCLTAzgvqcFC//+JVix4kNI1ja4 k50= X-SBRS: 5.2 X-MesageID: 42127952 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:jWblPKDxeIg985/lHeh+sceALOonbusQ8zAX/mhsVB1YddGZnc iynPIdkST5kioVRWtIo729EYOLKEm9ybde544NMbC+GDT3oWfAFvAH0aLO4R3FXxf/+OlUyL t6f8FFYuHYIFBmga/BjzWQPM0nxLC8npyAocf74zNTQRpxa6dmhj0JbzqzNkFtXgFJCd4YOf Onl6l6jgGtc3gWcci3b0NtN4T+jubGiY78Zlo+DwMngTPksRqT9LX4HxKEty1uMQ9n/LFKyw n4uj283IqPmbWRyhjQ12jchq4m5efJ+594K+GnzuQQIjXooA60aIpmQK3qhkFInMifrGwEvf OJjxA8P9liy365RBDLnTLdnzPO/Rxry3j+xUSWiXHuyPaJOg4SOo56qq9yNj76gnBQ2+1U4e Zw8E+y86dzN1fmmh/w4tDZPisa7XackD4ZvsM4y0BEXZB2Us42kaUvuHl7Pb0nByzA5IUuAI BVfbvhzccTS1+cYnzD11MfueCEbzA2FheCdEAIptaY5ThQhGx41EsV3qUk7w89yK4= X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="42127952" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fKm2IHCG+C/ERQ6eTcA4Ls4K80FVxXZk1Gha6HPjUHD+znQ7o2YG2gpnwkqnnphzgN76K92Os85tQUi1hsfMg1XyEuHkqpMzVYGdpn8xhZZIgE9ViOo4kaCEGLwi9/UtAWDQIEZEAoSgUKbxgW7cXnvUeKmijg9s4DXVHI78uk+LZJJaDvGOse2XkZUhzV+t6kegE9dnZPGhIVUy6BvshWJt7VDtKRNTyrrLy2q1NwjWctCywef09I2GhGMZJHH7HafeFNBmXjgNbOtUwtak1/zSE3PNxpmvygOzglx9J5az49EwlQ9evFasYG6LTNtBw80Kj5hTC5FRPDORjdLj5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AXDgp5zLeEO6xJnCs7W1qeqPsJCujqLjiz1imtJdVcM=; b=R6w9HnhXrGFVGc3cUk7O6+31G4jvM1P0hdahG3KpZRtPp8pELSW/qoMH7MhOMbiZV3iNv8PVjk9xGrUg549R91e72ho7H11d8QKEVdD9qd22JO3i8cBG3GrTJYrna1Q8uBcOJvAufDLF+sP/WgxdvAf9TSUNkmJVC9IE147lE+3H2dILj7kfrW2uM63/Zd9NdtINFujaFqHmYS1Inc9C9/aKeJhLrFV2WHici0j4HpBOG0qwLEDt1Vtgoy0REB8PP2QAzBB/byPepn5F5sqmGAUJZYT86YsO9BNdHO71/dEVIRNbiGwM2/+Se/7IgerOlzkD/NBgYAEnqTXEN5W2zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AXDgp5zLeEO6xJnCs7W1qeqPsJCujqLjiz1imtJdVcM=; b=MjNcclqKzkW7XFpCmoxKWEiobqpB1ZjlGR/GrXYa7jrqCXCvsGp+croPKImtg1LafWmIzElv0+9XbAHJmtCDXIxilc0L2Jj+RyODVe3bdfRWwdYDwx0Vmbb7ZY6SzM6PjUQarMvtwBMzHwwogXP4bZLqrghdEobHwCIdBYo1Hwk= Date: Thu, 1 Apr 2021 11:50:40 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: Ian Jackson , "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Dario Faggioli Subject: Re: Revert NR_CPUS=1 fix from 4.15 (was: Re: [PATCH] fix for_each_cpu() again for NR_CPUS=1) Message-ID: References: <4d993e67-2bdf-9ac3-f78e-daf279642de1@suse.com> <59387a2d-e28d-4e12-6b91-5df464e8ab9a@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <59387a2d-e28d-4e12-6b91-5df464e8ab9a@suse.com> X-ClientProxiedBy: MR2P264CA0120.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:33::36) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d0a8680f-1ca2-44d2-1a8d-08d8f4f39f91 X-MS-TrafficTypeDiagnostic: DM6PR03MB4059: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1iaRul7NL4gdfzmp10NqgcWIMtFW+x0FOiDCaiSDsz+UX7oM2zZtVQUhhbH1t0m5YNxnrA6GeV9Q0jYFTUQ+VTV+2k5/rQtcxLwJ4XZuL1XNcDPn3nagTg/hDmB7NrlzkQLtd9LJan0g5bjz4cYDcJxQoNFvGwpB1De2aGLEkjj6rCBwZqEIJXRxOg53Z5HbZHE19m01xBV3uzvhCqVCWQJTykfbmfC+sBS0Og+CnhH3Yp/qjeSoB3+UkhoDRQc1ZUO0N6Ua92BXg3JzZ6NjbDDy/tbqcsjKVZTCLNoI1nhX/qYdjSk3M9GcZis31sDimegPg4LyTX1A87qSHt4obYEOOKSRFSPzFKpfm+yoQxNv0WR3O3opleXp8x3DGtw09bnFojv9NkJwu+60CNpcPq76El5ARrQoGdHY209ndiJnvHn/NLX+8twvgA7kccVZfMUJ4QxEaIVmK8mJiIU+hxtAA3iKmkjr6dhqZhs2mQh0N1HwBEJz2Q3Tj3gsg3haUjW08wD7HgPuMnXL2rROJgDClP6ojWB35SZZ3EF5QEeAK3QswUBq+dQbDHx33JXuYf9qhK0FwP7kp+f1QDiI8RLDUEI5pJq73byctRAYexVmVlL5rJo3/gbX2/WfRfbzk+/z9bUI6FI/R4NdgmrAhYTMVRsdKFPJkyLisWTizyY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(346002)(376002)(396003)(39850400004)(136003)(85182001)(6496006)(26005)(9686003)(956004)(66476007)(86362001)(53546011)(66556008)(66946007)(6916009)(6666004)(54906003)(4326008)(16526019)(186003)(33716001)(5660300002)(6486002)(8936002)(8676002)(478600001)(38100700001)(83380400001)(316002)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?YU9kVWJLdDJiYkFjMEVBWEJROWZFdk91YU5lajYxL0VrdFVxcjZYSzZzQ1k2?= =?utf-8?B?NGNSYTE0bHNwemhZVUpTaTYwVFlXRWdHWmhuRnBnSE1PMHdUMGVnY3ZjUzIy?= =?utf-8?B?OUhLWjN3VkJlMG8zU3JGYmg0TTR2TXByN25oVnlZSkk1dE0yREVRS0FwbFU3?= =?utf-8?B?bHBFMThCQkw0WktEQ3c3TXBuN1BFSHdDOGhzQ2tEVDBKWjEzNWV5bTM0bDY5?= =?utf-8?B?YmI4VHE2YzRhcTFNS00zdDRybVlQUHI5UktJQ3Ztc0xXRTlIYk9vTkdmdkQ1?= =?utf-8?B?cnIwbmI1cnZlcEJlMTdpTzJZemd1SjkwaWJNZjEvOEI5N2FGOGNtNVJJVVcx?= =?utf-8?B?dmxYM1UraWdBVGhLVU9IY1JjU21LaVRxRVA0b1R6blFpS2lUWktkTkpOUDVh?= =?utf-8?B?ZWoydWFEeExOS0gxdFhrZXdjdnZLRktZRllJYlJYa2hpVzJzZHBnS2RId0NV?= =?utf-8?B?MFVDWnY1ZjJKcTk5QXhzVVdkYlppMS94K3NzeGpZZmZGc3JNVTZOVUpZRTRF?= =?utf-8?B?ZXRacjZxNjJHZHQzOVpCbmRhMENFOWRqT2Rna1F4VmxycmVlNjhmK3gvWW1J?= =?utf-8?B?Z1pPYUdwekdHNDVMZkxkWHVFK01hOFVMSzZSWnB0N0srTFB4bWpUaTJ3bitU?= =?utf-8?B?cnU5ZVVnR1VqLytFL2hSV08vcEp1Y1RiSGNkOURPQkk0NUJkWHpCalc3Wml2?= =?utf-8?B?dVFvcGQ3aGQ5enQ5V1VPM1NBN0pwaHd4ZUtWbU13a1pNc1U5QmQzMWxZMTFo?= =?utf-8?B?OGRKYTUxY1dTdVRXRTdRWStxZnBLK1JkWGlJTDNpV3hqTFlEZXhNOGQ3RXdt?= =?utf-8?B?N2s5Z09FdGgyRzlpNjRncVdzVDNDaGY0ZmNVV2JzTWFIUmxTeHVKZGQyR3dW?= =?utf-8?B?VWJqVmhVOU42WUd1RlVFZWxhandJQTI3dm1YQlNLcE1zbDJDMUw4WjFGWWxj?= =?utf-8?B?aWNNWUs0OWhFa1F4NlRpT3dZQ3RqdzhCTjdyNlZZa3pHVHBPUVljUVhzWVZO?= =?utf-8?B?K2lwbEVMeEpTZ2RLUFBkSFBoYWNkK2MwaUw1R3FFOU1hTjd4QlVZZDMwZE8v?= =?utf-8?B?eUxsQXdPWkkrWlNza294b1lSYmlQTklZVXE4OGxUZ1I1bWNMMUd3UWpnSlhG?= =?utf-8?B?VndTU29OWFFKNW5EN3daZGU0OUQrUGFqaG9zL3FxTXdKV3dzVTBUL1JZMWRN?= =?utf-8?B?TWtWOFZBZnc4R1lqb29DbW41VXFRSGtFeitzK2hndUlpUlladm03aDZEa0hp?= =?utf-8?B?RzQ3Nys5NityT29qVTFsQVNxcUg2SFZuYVZxRzJDNm5SN3Zoa1liME1LWVB3?= =?utf-8?B?ZndBN0tTR3JjUENqd0ZwRE5sQUVkMjhFcWNzT29QU2NxSTNnY1I2bG5vUDZr?= =?utf-8?B?QmpjbkJkelRwNFF1R3VqcndyVWV2Tjhhd2RtUWtCWlZSbytMZ0NiU2VTTkxq?= =?utf-8?B?alhDNW95eTBuQVIwTzdRODdtWnR1RC8xTldzU2lNc1Y2TzZHbC94ZG9qdmY2?= =?utf-8?B?YndqbDFZRjY5eUlrL0cyTkpaMWNjK2dnTVV1Ym5oN0pucTFCQk8yMytKclZ3?= =?utf-8?B?ampwblk0dDRNRVdnQlA5OW83SzNkL1pDSlhwTlNUcXI5aWFUUlB1R3l6WS8v?= =?utf-8?B?Y2xxS1ZyZkh2ZDExM09iMmVxS0U4bUh0UjlSSkgzTlFKa05EUm9IUUxJSk01?= =?utf-8?B?d0h5K1FHdmhsMnpUNjNGVEY2cm5sbTc0RElKUTJWQS9JR3djVW5IMkdnVSth?= =?utf-8?B?MlNQZzFKYTJEaGZlSitFQVl4d21SQVVudU03aDVJL2lFd3hTaEZTeG8wRDNU?= =?utf-8?B?YzFUMU1KQWUwRmQxUlR3Zz09?= X-MS-Exchange-CrossTenant-Network-Message-Id: d0a8680f-1ca2-44d2-1a8d-08d8f4f39f91 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 09:50:46.6353 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rsAQ0voMslsi3NFsfoHXdcxsmhGxhVDiEknUbp7ZQb18ljDovJjeA/gO0K3MN0a2XIBhRJIILGZKFD2UenlL0w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4059 X-OriginatorOrg: citrix.com On Thu, Apr 01, 2021 at 11:26:03AM +0200, Jan Beulich wrote: > On 01.04.2021 11:00, Roger Pau Monné wrote: > > On Wed, Mar 31, 2021 at 04:52:47PM +0200, Jan Beulich wrote: > >> Unfortunately aa50f45332f1 ("xen: fix for_each_cpu when NR_CPUS=1") has > >> caused quite a bit of fallout with gcc10, e.g. (there are at least two > >> more similar ones, and I didn't bother trying to find them all): > >> > >> In file included from .../xen/include/xen/config.h:13, > >> from : > >> core_parking.c: In function ‘core_parking_power’: > >> .../xen/include/asm/percpu.h:12:51: error: array subscript 1 is above array bounds of ‘long unsigned int[1]’ [-Werror=array-bounds] > >> 12 | (*RELOC_HIDE(&per_cpu__##var, __per_cpu_offset[cpu])) > >> .../xen/include/xen/compiler.h:141:29: note: in definition of macro ‘RELOC_HIDE’ > >> 141 | (typeof(ptr)) (__ptr + (off)); }) > >> | ^~~ > >> core_parking.c:133:39: note: in expansion of macro ‘per_cpu’ > >> 133 | core_tmp = cpumask_weight(per_cpu(cpu_core_mask, cpu)); > >> | ^~~~~~~ > >> In file included from .../xen/include/xen/percpu.h:4, > >> from .../xen/include/asm/msr.h:7, > >> from .../xen/include/asm/time.h:5, > >> from .../xen/include/xen/time.h:76, > >> from .../xen/include/xen/spinlock.h:4, > >> from .../xen/include/xen/cpu.h:5, > >> from core_parking.c:19: > >> .../xen/include/asm/percpu.h:6:22: note: while referencing ‘__per_cpu_offset’ > >> 6 | extern unsigned long __per_cpu_offset[NR_CPUS]; > >> | ^~~~~~~~~~~~~~~~ > > > > At this point, should be consider reverting the original fix from the > > 4.15 branch, so that we don't release something that's build broken > > with gcc 10? > > Well, I didn't propose reverting (or taking this fix) because I think > build breakage is better than runtime breakage. But in the end, Ian, > it's up to you. Oh, right, sorry. The build issue only happens with NR_CPUS=1, in which case I agree, there's no need to do anything in 4.15 IMO. Sorry for bothering. Roger. From xen-devel-bounces@lists.xenproject.org Thu Apr 01 09:53:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 09:53:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104258.199194 (Exim 4.92) (envelope-from ) id 1lRu0e-0006Gp-Gq; Thu, 01 Apr 2021 09:53:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104258.199194; Thu, 01 Apr 2021 09:53:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRu0e-0006Gi-DP; Thu, 01 Apr 2021 09:53:04 +0000 Received: by outflank-mailman (input) for mailman id 104258; Thu, 01 Apr 2021 09:53:03 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRu0d-0006GN-CK for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 09:53:03 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id cc26323c-72f3-498e-ab02-fd8648a1f5f6; Thu, 01 Apr 2021 09:53:02 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4C8AFAEF5; Thu, 1 Apr 2021 09:53:01 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc26323c-72f3-498e-ab02-fd8648a1f5f6 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617270781; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vNiUNwZ+aiEw9xOsPoj4ZZ2Cw6r47zSUiseZb9FdFBQ=; b=sHYTkEGMb4g8QbEC7jeXduHsoZrBIi8HGDBqX1gLcCZXyW91j8M+GbGCUuQMQuAIDCagNE R/VPViDCkifgc4dSkXkVsu1aLDVq1zdozq+K1oFt875CDBy4F4jK9gchS++ZD3VzhToGyG 3em4PsP8ck/IZtLg2qG87an1aLyu4fk= From: Jan Beulich Subject: [PATCH v4 0/3] x86/time: calibration rendezvous adjustments To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Message-ID: Date: Thu, 1 Apr 2021 11:53:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit The first patch was, under a different title and with a different approach, already part of the prior series of the same subject. The other two patches are new, resulting from me spotting further room for improvement (or so I hope). 1: latch to-be-written TSC value early in rendezvous loop 2: yield to hyperthreads after updating TSC during rendezvous 3: avoid reading the platform timer in rendezvous functions Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 01 09:54:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 09:54:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104261.199206 (Exim 4.92) (envelope-from ) id 1lRu1g-0006Om-Qz; Thu, 01 Apr 2021 09:54:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104261.199206; Thu, 01 Apr 2021 09:54:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRu1g-0006Of-Nl; Thu, 01 Apr 2021 09:54:08 +0000 Received: by outflank-mailman (input) for mailman id 104261; Thu, 01 Apr 2021 09:54:07 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRu1f-0006OW-C9 for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 09:54:07 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ad03d872-721a-4051-970f-b25f37750982; Thu, 01 Apr 2021 09:54:06 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A7811AEA6; Thu, 1 Apr 2021 09:54:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad03d872-721a-4051-970f-b25f37750982 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617270845; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SRJupnLGMfszPfCGs6C2rPqjAEwXFCBQV3qorCClVzA=; b=KCAosS6xkauPgkpAGntfN1NQ3BkhEk3qijzYbYAZnEbC7f6X0J7Ha8TA8wzqnBu3ZlsSDI XPrD3il53j+BooEb/LRJjyocRLj/IWdCkcrRRX3pxADC3B/dQYoQLega5hbh/TzrZOrJJ4 chJ5IgF8SfqgmfG34j4jFu9H7XkVVOM= Subject: [PATCH v4 1/3] x86/time: latch to-be-written TSC value early in rendezvous loop From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Message-ID: <35bbad56-d0f0-a37d-674c-e635eaf9c94c@suse.com> Date: Thu, 1 Apr 2021 11:54:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit To reduce latency on time_calibration_tsc_rendezvous()'s last loop iteration, read the value to be written on the last iteration at the end of the loop body (i.e. in particular at the end of the second to last iteration). On my single-socket 18-core Skylake system this reduces the average loop exit time on CPU0 (from the TSC write on the last iteration to until after the main loop) from around 32k cycles to around 29k (albeit the values measured on separate runs vary quite significantly). Signed-off-by: Jan Beulich --- v4: Different approach. v3: New. --- Of course it would also be nice to avoid the pretty likely branch misprediction on the last iteration. But with the static prediction hints having been rather short-lived in the architecture, I don't see any good means to do so. --- a/xen/arch/x86/time.c +++ b/xen/arch/x86/time.c @@ -1683,7 +1683,7 @@ static void time_calibration_tsc_rendezv int i; struct calibration_rendezvous *r = _r; unsigned int total_cpus = cpumask_weight(&r->cpu_calibration_map); - uint64_t tsc = 0; + uint64_t tsc = 0, master_tsc = 0; /* Loop to get rid of cache effects on TSC skew. */ for ( i = 4; i >= 0; i-- ) @@ -1708,7 +1708,7 @@ static void time_calibration_tsc_rendezv atomic_inc(&r->semaphore); if ( i == 0 ) - write_tsc(r->master_tsc_stamp); + write_tsc(master_tsc); while ( atomic_read(&r->semaphore) != (2*total_cpus - 1) ) cpu_relax(); @@ -1730,7 +1730,7 @@ static void time_calibration_tsc_rendezv } if ( i == 0 ) - write_tsc(r->master_tsc_stamp); + write_tsc(master_tsc); atomic_inc(&r->semaphore); while ( atomic_read(&r->semaphore) > total_cpus ) @@ -1739,9 +1739,17 @@ static void time_calibration_tsc_rendezv /* Just in case a read above ended up reading zero. */ tsc += !tsc; + + /* + * To reduce latency of the TSC write on the last iteration, + * fetch the value to be written into a local variable. To avoid + * introducing yet another conditional branch (which the CPU may + * have difficulty predicting well) do this on all iterations. + */ + master_tsc = r->master_tsc_stamp; } - time_calibration_rendezvous_tail(r, tsc, r->master_tsc_stamp); + time_calibration_rendezvous_tail(r, tsc, master_tsc); } /* Ordinary rendezvous function which does not modify TSC values. */ From xen-devel-bounces@lists.xenproject.org Thu Apr 01 09:54:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 09:54:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104263.199218 (Exim 4.92) (envelope-from ) id 1lRu23-0006Vh-3B; Thu, 01 Apr 2021 09:54:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104263.199218; Thu, 01 Apr 2021 09:54:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRu23-0006Va-05; Thu, 01 Apr 2021 09:54:31 +0000 Received: by outflank-mailman (input) for mailman id 104263; Thu, 01 Apr 2021 09:54:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRu21-0006VT-IZ for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 09:54:29 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 162e1716-1d1c-432e-86aa-435eef0c2cd3; Thu, 01 Apr 2021 09:54:28 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 262E0B032; Thu, 1 Apr 2021 09:54:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 162e1716-1d1c-432e-86aa-435eef0c2cd3 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617270868; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QdS547I0MHs8GHpeGea/kzNdcUxE2McJtcRJ1hPnylM=; b=Yw2aNBfYvGgfmOIZZAydVv7NE5hING06Tbr1dHmF+WBYBdMmxtdW4AzLiCWY3VRhuyLZzc AZcIoARXZo0GVFdu7M7vh+nGvIdi9FjUUtTruyszBKAdP8hw88mvwJ6fS9zcFqMXoJgSoe Uj3Isdgek2k9ntlCRjq6CB31hRlAAnI= Subject: [PATCH v4 2/3] x86/time: yield to hyperthreads after updating TSC during rendezvous From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Message-ID: <81da85eb-2e8e-9b76-2fb3-2beddc33e9af@suse.com> Date: Thu, 1 Apr 2021 11:54:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Since we'd like the updates to be done as synchronously as possible, make an attempt at yielding immediately after the TSC write. Signed-off-by: Jan Beulich --- v4: New. --- a/xen/arch/x86/time.c +++ b/xen/arch/x86/time.c @@ -1708,7 +1708,14 @@ static void time_calibration_tsc_rendezv atomic_inc(&r->semaphore); if ( i == 0 ) + { write_tsc(master_tsc); + /* + * Try to give our hyperthread(s), if any, a chance to do + * the same as instantly as possible. + */ + cpu_relax(); + } while ( atomic_read(&r->semaphore) != (2*total_cpus - 1) ) cpu_relax(); @@ -1730,7 +1737,14 @@ static void time_calibration_tsc_rendezv } if ( i == 0 ) + { write_tsc(master_tsc); + /* + * Try to give our hyperthread(s), if any, a chance to do + * the same as instantly as possible. + */ + cpu_relax(); + } atomic_inc(&r->semaphore); while ( atomic_read(&r->semaphore) > total_cpus ) From xen-devel-bounces@lists.xenproject.org Thu Apr 01 09:55:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 09:55:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104267.199229 (Exim 4.92) (envelope-from ) id 1lRu2k-0006df-Cj; Thu, 01 Apr 2021 09:55:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104267.199229; Thu, 01 Apr 2021 09:55:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRu2k-0006dY-9h; Thu, 01 Apr 2021 09:55:14 +0000 Received: by outflank-mailman (input) for mailman id 104267; Thu, 01 Apr 2021 09:55:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRu2i-0006dG-Gy for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 09:55:12 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4a3658ca-cfbc-451f-9886-16fc96a54119; Thu, 01 Apr 2021 09:55:11 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 04D25B032; Thu, 1 Apr 2021 09:55:11 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a3658ca-cfbc-451f-9886-16fc96a54119 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617270911; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/4bBVDd6Hj6a8b8XlnvfpgQxmTCGoW9DQonxX1lum1U=; b=tMyzVyeb/17TZQ3RGutErR3hQvhLIo/di2rDhns5u9ADhQOQwn82UKhNTJ7TvTs6QzDZs0 HkEPXkeflxHNeOkL6+gRVOGiOLffJAxyv6z119bgPAg8CZNZTSZi/A2Fv1UJBDTFkKdWXP 73AhBd+cg2PvrtSrjiwQC+Qb0u/wEwM= Subject: [PATCH v4 3/3] x86/time: avoid reading the platform timer in rendezvous functions From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Message-ID: Date: Thu, 1 Apr 2021 11:55:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Reading the platform timer isn't cheap, so we'd better avoid it when the resulting value is of no interest to anyone. The consumer of master_stime, obtained by time_calibration_{std,tsc}_rendezvous() and propagated through this_cpu(cpu_calibration), is local_time_calibration(). With CONSTANT_TSC the latter function uses an early exit path, which doesn't explicitly use the field. While this_cpu(cpu_calibration) (including the master_stime field) gets propagated to this_cpu(cpu_time).stamp on that path, both structures' fields get consumed only by the !CONSTANT_TSC logic of the function. Signed-off-by: Jan Beulich --- v4: New. --- I realize there's some risk associated with potential new uses of the field down the road. What would people think about compiling time.c a 2nd time into a dummy object file, with a conditional enabled to force assuming CONSTANT_TSC, and with that conditional used to suppress presence of the field as well as all audited used of it (i.e. in particular that large part of local_time_calibration())? Unexpected new users of the field would then cause build time errors. --- a/xen/arch/x86/time.c +++ b/xen/arch/x86/time.c @@ -52,6 +52,7 @@ unsigned long pit0_ticks; struct cpu_time_stamp { u64 local_tsc; s_time_t local_stime; + /* Next field unconditionally valid only when !CONSTANT_TSC. */ s_time_t master_stime; }; @@ -1702,7 +1703,7 @@ static void time_calibration_tsc_rendezv * iteration. */ r->master_tsc_stamp = r->max_tsc_stamp; - else if ( i == 0 ) + else if ( !boot_cpu_has(X86_FEATURE_CONSTANT_TSC) && i == 0 ) r->master_stime = read_platform_stime(NULL); atomic_inc(&r->semaphore); @@ -1776,8 +1777,11 @@ static void time_calibration_std_rendezv { while ( atomic_read(&r->semaphore) != (total_cpus - 1) ) cpu_relax(); - r->master_stime = read_platform_stime(NULL); - smp_wmb(); /* write r->master_stime /then/ signal */ + if ( !boot_cpu_has(X86_FEATURE_CONSTANT_TSC) ) + { + r->master_stime = read_platform_stime(NULL); + smp_wmb(); /* write r->master_stime /then/ signal */ + } atomic_inc(&r->semaphore); } else From xen-devel-bounces@lists.xenproject.org Thu Apr 01 10:14:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 10:14:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104273.199241 (Exim 4.92) (envelope-from ) id 1lRuKz-0000FG-2O; Thu, 01 Apr 2021 10:14:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104273.199241; Thu, 01 Apr 2021 10:14:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuKy-0000F9-VV; Thu, 01 Apr 2021 10:14:04 +0000 Received: by outflank-mailman (input) for mailman id 104273; Thu, 01 Apr 2021 10:14:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuKx-0000Ei-9G; Thu, 01 Apr 2021 10:14:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuKw-0003Gv-VN; Thu, 01 Apr 2021 10:14:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuKw-0007LQ-JA; Thu, 01 Apr 2021 10:14:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lRuKw-0000XC-Ig; Thu, 01 Apr 2021 10:14:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4rj7ajJhNlIsJWFUUXxgfis2ZrvQA6MFGEgtnghDNu0=; b=vamu/s2E0Y6S8xJdfWjCwLB2ND 1Boiw5LL3kI3p2RlahnMqrAz7sMe6MNdhNkMYJ6uid6MOpodHi35Gq0Hu3J33TkxaXBcJ7xu3h7VC ErToAOAA3pAMRbTJlr4k39iKdmC9PDO0y5ul/tsiRoZN+ujumOFK+daE558p/A4iHuQE=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160625: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-localmigrate/x10:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-libvirt-vhd:guest-saverestore.2:fail:regression linux-linus:test-amd64-amd64-qemuu-freebsd12-amd64:guest-start/freebsd.repeat:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=d19cc4bfbff1ae72c3505a00fb8ce0d3fa519e6c X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Thu, 01 Apr 2021 10:14:02 +0000 flight 160625 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160625/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 19 guest-localmigrate/x10 fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-libvirt-vhd 17 guest-saverestore.2 fail REGR. vs. 152332 test-amd64-amd64-qemuu-freebsd12-amd64 21 guest-start/freebsd.repeat fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux d19cc4bfbff1ae72c3505a00fb8ce0d3fa519e6c baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 243 days Failing since 152366 2020-08-01 20:49:34 Z 242 days 413 attempts Testing same since 160625 2021-03-31 18:28:28 Z 0 days 1 attempts ------------------------------------------------------------ 5276 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1311742 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Apr 01 10:15:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 10:15:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104277.199257 (Exim 4.92) (envelope-from ) id 1lRuLt-0000Nu-Ee; Thu, 01 Apr 2021 10:15:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104277.199257; Thu, 01 Apr 2021 10:15:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuLt-0000Nn-B8; Thu, 01 Apr 2021 10:15:01 +0000 Received: by outflank-mailman (input) for mailman id 104277; Thu, 01 Apr 2021 10:15:00 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuLr-0000Ne-UC for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 10:14:59 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ef0fa20b-faed-45ce-be13-d0a8d0402ad1; Thu, 01 Apr 2021 10:14:59 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 315A3AEA6; Thu, 1 Apr 2021 10:14:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ef0fa20b-faed-45ce-be13-d0a8d0402ad1 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617272098; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xH4wjHy3MHm3MpA5OfQg5m/IJ+YbG9hbx8Zy+5IXfxo=; b=tydK5NWUI55HS5wCoTczdxtLYmoHEXm0erkuM8nnRMZy2oSA6OmJQuJIsQqkYdOoaHKAYI PULWKNdS1+FWh/9rm5Al6DVOy8nO1xYpRytglkQEWucX1SkzjquWeJ70U/AHaAJu9diu41 jNzOel7cbwWZCMN7e8r2OEuzFPkEXHA= From: Jan Beulich Subject: [PATCH 00/23] further population of xen/lib/ To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu Message-ID: Date: Thu, 1 Apr 2021 12:14:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit This is to dissolve / move xen/common/lib.c and xen/common/string.c. One benefit of moving these functions into an archive is that we can drop some of the related __HAVE_ARCH_* #define-s: By living in an archive, the per-arch functions will preempt any loading of the respective functions (objects) from the archive. (Down the road we may want to move the per-arch functions into archives as well, at which point the per-arch archive(s) would need to be specified ahead of the common one(s) to the linker.) 01: lib: move muldiv64() 02: lib: move 64-bit div/mod compiler helpers 03: string: drop redundant declarations 04: lib: move memset() 05: lib: move memcpy() 06: lib: move memmove() 07: lib: move memcmp() 08: lib: move memchr() 09: lib: move memchr_inv() 10: lib: move strlen() 11: lib: move strnlen() 12: lib: move strcmp() 13: lib: move strncmp() 14: lib: move strlcpy() 15: lib: move strlcat() 16: lib: move strchr() 17: lib: move strrchr() 18: lib: move strstr() 19: lib: move strcasecmp() 20: lib: move/rename strnicmp() to strncasecmp() 21: lib: move strspn() 22: lib: move strpbrk() 23: lib: move strsep() Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 01 10:19:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 10:19:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104280.199268 (Exim 4.92) (envelope-from ) id 1lRuQ5-0000cb-12; Thu, 01 Apr 2021 10:19:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104280.199268; Thu, 01 Apr 2021 10:19:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuQ4-0000cU-U2; Thu, 01 Apr 2021 10:19:20 +0000 Received: by outflank-mailman (input) for mailman id 104280; Thu, 01 Apr 2021 10:19:19 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuQ3-0000cP-CY for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 10:19:19 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 18698b2d-322e-4a69-a3c1-ecbb84983cfa; Thu, 01 Apr 2021 10:19:18 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A60E8AED7; Thu, 1 Apr 2021 10:19:17 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 18698b2d-322e-4a69-a3c1-ecbb84983cfa X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617272357; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9n+mI1T3eTMXqMQfpWtBTAwMJf+lLEmiOgcGI7/pMvs=; b=VFOQcT58NhjmucUyXOze1BHcqSKPdeJjv3E34UTJrUjtwxeQfDuqavnRIX+nBI4z/KGdQe hriJ50IRFM26dH19iKmqiAfkJQvnV8lW02MQB4ItZMfR/wAXt4eQ2mCRw8gsKACHjnSiQO bSmgHjUlLNKDEbVFv/j+z0liIoNsclg= Subject: [PATCH 01/23] lib: move muldiv64() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu References: Message-ID: Date: Thu, 1 Apr 2021 12:19:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Make this a separate archive member under lib/. While doing so, don't move latently broken x86 assembly though: Fix the constraints, such that properly extending inputs to 64-bit won't just be a side effect of needing to copy registers, and such that we won't fail to clobber %rdx. Signed-off-by: Jan Beulich --- a/xen/common/lib.c +++ b/xen/common/lib.c @@ -393,35 +393,6 @@ s64 __ldivmod_helper(s64 a, s64 b, s64 * } #endif /* BITS_PER_LONG == 32 */ -/* Compute with 96 bit intermediate result: (a*b)/c */ -uint64_t muldiv64(uint64_t a, uint32_t b, uint32_t c) -{ -#ifdef CONFIG_X86 - asm ( "mul %%rdx; div %%rcx" : "=a" (a) : "0" (a), "d" (b), "c" (c) ); - return a; -#else - union { - uint64_t ll; - struct { -#ifdef WORDS_BIGENDIAN - uint32_t high, low; -#else - uint32_t low, high; -#endif - } l; - } u, res; - uint64_t rl, rh; - - u.ll = a; - rl = (uint64_t)u.l.low * (uint64_t)b; - rh = (uint64_t)u.l.high * (uint64_t)b; - rh += (rl >> 32); - res.l.high = rh / c; - res.l.low = (((rh % c) << 32) + (rl & 0xffffffff)) / c; - return res.ll; -#endif -} - /* * Local variables: * mode: C --- a/xen/lib/Makefile +++ b/xen/lib/Makefile @@ -4,6 +4,7 @@ lib-y += bsearch.o lib-y += ctors.o lib-y += ctype.o lib-y += list-sort.o +lib-y += muldiv64.o lib-y += parse-size.o lib-y += rbtree.o lib-y += sort.o --- /dev/null +++ b/xen/lib/muldiv64.c @@ -0,0 +1,44 @@ +#include + +/* Compute with 96 bit intermediate result: (a*b)/c */ +uint64_t muldiv64(uint64_t a, uint32_t b, uint32_t c) +{ +#ifdef CONFIG_X86 + asm ( "mulq %1; divq %2" : "+a" (a) + : "rm" ((uint64_t)b), "rm" ((uint64_t)c) + : "rdx" ); + + return a; +#else + union { + uint64_t ll; + struct { +#ifdef WORDS_BIGENDIAN + uint32_t high, low; +#else + uint32_t low, high; +#endif + } l; + } u, res; + uint64_t rl, rh; + + u.ll = a; + rl = (uint64_t)u.l.low * (uint64_t)b; + rh = (uint64_t)u.l.high * (uint64_t)b; + rh += (rl >> 32); + res.l.high = rh / c; + res.l.low = (((rh % c) << 32) + (rl & 0xffffffff)) / c; + + return res.ll; +#endif +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ From xen-devel-bounces@lists.xenproject.org Thu Apr 01 10:19:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 10:19:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104284.199281 (Exim 4.92) (envelope-from ) id 1lRuQY-0000kK-E2; Thu, 01 Apr 2021 10:19:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104284.199281; Thu, 01 Apr 2021 10:19:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuQY-0000kD-AD; Thu, 01 Apr 2021 10:19:50 +0000 Received: by outflank-mailman (input) for mailman id 104284; Thu, 01 Apr 2021 10:19:48 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuQW-0000k1-GV for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 10:19:48 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ac7ed814-87d3-4e11-827f-e838f7f435b3; Thu, 01 Apr 2021 10:19:47 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B0B5DAEAE; Thu, 1 Apr 2021 10:19:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ac7ed814-87d3-4e11-827f-e838f7f435b3 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617272386; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MQq09dPyj92+Q29K/+2WpJlVyL1zFTQmPSHsHxroQCM=; b=asLWaYr+GzD+ctulBCqcr5J1Pe6NlJBNsZZSHGyEMskY7CGokeFC6ereCgztYhN+LJS5L3 iqA17xOzmzD6PcwQkMoN6dtghYvW8jzyEIXEpbYh67YB99mimu85p+6KWTfPEUHTI6Li/s 7EL87fAUJW/u9aIMMBtOnW+gEv4oo4k= Subject: [PATCH 02/23] lib: move 64-bit div/mod compiler helpers From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Message-ID: <0fec827f-bb0b-4ea1-7757-9c27e9138be7@suse.com> Date: Thu, 1 Apr 2021 12:19:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit These were built for 32-bit architectures only (the same code could, with some tweaking, sensibly be used to provide TI-mode helpers on 64-bit arch-es) - retain this property, while still avoiding to have a CU without any contents at all. For this, Arm's CONFIG_64BIT gets generalized. Signed-off-by: Jan Beulich --- xen/arch/Kconfig | 2 ++ xen/arch/arm/Kconfig | 12 +++--------- xen/arch/x86/Kconfig | 1 + xen/common/Makefile | 1 - xen/lib/Makefile | 4 ++++ xen/{common/lib.c => lib/divmod.c} | 2 -- 6 files changed, 10 insertions(+), 12 deletions(-) rename xen/{common/lib.c => lib/divmod.c} (99%) diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig index d144d4c8d3ee..f16eb0df43af 100644 --- a/xen/arch/Kconfig +++ b/xen/arch/Kconfig @@ -1,3 +1,5 @@ +config 64BIT + bool config NR_CPUS int "Maximum number of CPUs" diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 330bbf6232d4..ecfa6822e4d3 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -1,17 +1,11 @@ -config 64BIT - bool - default "$(ARCH)" != "arm32" - help - Say yes to build a 64-bit Xen - Say no to build a 32-bit Xen - config ARM_32 def_bool y - depends on !64BIT + depends on "$(ARCH)" = "arm32" config ARM_64 def_bool y - depends on 64BIT + depends on !ARM_32 + select 64BIT select HAS_FAST_MULTIPLY config ARM diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig index f79e6634db3f..4d6911ffa467 100644 --- a/xen/arch/x86/Kconfig +++ b/xen/arch/x86/Kconfig @@ -1,5 +1,6 @@ config X86_64 def_bool y + select 64BIT config X86 def_bool y diff --git a/xen/common/Makefile b/xen/common/Makefile index 71c1d466bd8f..e2a7e62d14bf 100644 --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -21,7 +21,6 @@ obj-y += kernel.o obj-y += keyhandler.o obj-$(CONFIG_KEXEC) += kexec.o obj-$(CONFIG_KEXEC) += kimage.o -obj-y += lib.o obj-$(CONFIG_LIVEPATCH) += livepatch.o livepatch_elf.o obj-$(CONFIG_MEM_ACCESS) += mem_access.o obj-y += memory.o diff --git a/xen/lib/Makefile b/xen/lib/Makefile index 0b274583ef0b..a5dc1442a422 100644 --- a/xen/lib/Makefile +++ b/xen/lib/Makefile @@ -10,3 +10,7 @@ lib-y += rbtree.o lib-y += sort.o lib-$(CONFIG_X86) += xxhash32.o lib-$(CONFIG_X86) += xxhash64.o + +lib32-y := divmod.o +lib32-$(CONFIG_64BIT) := +lib-y += $(lib32-y) diff --git a/xen/common/lib.c b/xen/lib/divmod.c similarity index 99% rename from xen/common/lib.c rename to xen/lib/divmod.c index 5b8f49153dad..0be6ccc70096 100644 --- a/xen/common/lib.c +++ b/xen/lib/divmod.c @@ -40,7 +40,6 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. */ -#if BITS_PER_LONG == 32 /* * Depending on the desired operation, we view a `long long' (aka quad_t) in @@ -391,7 +390,6 @@ s64 __ldivmod_helper(s64 a, s64 b, s64 *r) else return quot; } -#endif /* BITS_PER_LONG == 32 */ /* * Local variables: From xen-devel-bounces@lists.xenproject.org Thu Apr 01 10:20:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 10:20:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104288.199293 (Exim 4.92) (envelope-from ) id 1lRuR3-0001Xp-Mf; Thu, 01 Apr 2021 10:20:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104288.199293; Thu, 01 Apr 2021 10:20:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuR3-0001Xh-Je; Thu, 01 Apr 2021 10:20:21 +0000 Received: by outflank-mailman (input) for mailman id 104288; Thu, 01 Apr 2021 10:20:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuR2-0001Xa-CN for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 10:20:20 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4a2154c3-18a5-4c48-9603-4d3dc9c13d9b; Thu, 01 Apr 2021 10:20:19 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 811A6AE86; Thu, 1 Apr 2021 10:20:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a2154c3-18a5-4c48-9603-4d3dc9c13d9b X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617272418; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pPkeQToxrrrMgDYsF5+OEyCjKJhGCfAdjAB1QD105BY=; b=pfFcnH7t3pM/LgBQSszXHdKaTOpO8A45FuPaoYHiidjH6Asav228TrSkkL1WHsKLfaAb7a OtU+tsrVNsMAgMIqSHAhk7SubEazHg82ELaucIDsPkQGfd7ZjSFHUiODCMWpdZz+fWfwg3 rBZzvFL6dFw8K76vw6y1FLMMFB3FuT4= Subject: [PATCH 03/23] string: drop redundant declarations From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Message-ID: Date: Thu, 1 Apr 2021 12:20:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit These standard functions shouldn't need custom declarations. The only case where redundancy might be needed is if there were inline functions there. But we don't have any here (anymore). Prune the per-arch headers of duplicate declarations while moving the asm/string.h inclusion past the declarations. Signed-off-by: Jan Beulich --- a/xen/include/asm-arm/string.h +++ b/xen/include/asm-arm/string.h @@ -8,41 +8,21 @@ */ #define __HAVE_ARCH_STRRCHR -char *strrchr(const char *s, int c); - #define __HAVE_ARCH_STRCHR -char *strchr(const char *s, int c); - #if defined(CONFIG_ARM_64) #define __HAVE_ARCH_STRCMP -int strcmp(const char *, const char *); - #define __HAVE_ARCH_STRNCMP -int strncmp(const char *, const char *, size_t); - #define __HAVE_ARCH_STRLEN -size_t strlen(const char *); - #define __HAVE_ARCH_STRNLEN -size_t strnlen(const char *, size_t); #endif #define __HAVE_ARCH_MEMCPY -void *memcpy(void *, const void *, size_t); - #if defined(CONFIG_ARM_64) #define __HAVE_ARCH_MEMCMP -int memcmp(const void *, const void *, size_t); #endif - #define __HAVE_ARCH_MEMMOVE -void *memmove(void *dest, const void *src, size_t n); - #define __HAVE_ARCH_MEMSET -void *memset(void *, int, size_t); - #define __HAVE_ARCH_MEMCHR -void *memchr(const void *, int, size_t); #if defined(CONFIG_ARM_32) --- a/xen/include/asm-x86/string.h +++ b/xen/include/asm-x86/string.h @@ -2,15 +2,12 @@ #define __X86_STRING_H__ #define __HAVE_ARCH_MEMCPY -void *memcpy(void *dest, const void *src, size_t n); #define memcpy(d, s, n) __builtin_memcpy(d, s, n) #define __HAVE_ARCH_MEMMOVE -void *memmove(void *dest, const void *src, size_t n); #define memmove(d, s, n) __builtin_memmove(d, s, n) #define __HAVE_ARCH_MEMSET -void *memset(void *dest, int c, size_t n); #define memset(s, c, n) __builtin_memset(s, c, n) #endif /* __X86_STRING_H__ */ --- a/xen/include/xen/string.h +++ b/xen/include/xen/string.h @@ -4,11 +4,6 @@ #include /* for size_t */ /* - * Include machine specific inline routines - */ -#include - -/* * These string functions are considered too dangerous for normal use. * Use safe_strcpy(), safe_strcat(), strlcpy(), strlcat() as appropriate. */ @@ -17,97 +12,78 @@ #define strncpy __xen_has_no_strncpy__ #define strncat __xen_has_no_strncat__ -#ifndef __HAVE_ARCH_STRLCPY size_t strlcpy(char *, const char *, size_t); -#endif - -#ifndef __HAVE_ARCH_STRLCAT size_t strlcat(char *, const char *, size_t); -#endif +int strcmp(const char *, const char *); +int strncmp(const char *, const char *, size_t); +int strnicmp(const char *, const char *, size_t); +int strcasecmp(const char *, const char *); +char *strchr(const char *, int); +char *strrchr(const char *, int); +char *strstr(const char *, const char *); +size_t strlen(const char *); +size_t strnlen(const char *, size_t); +char *strpbrk(const char *, const char *); +char *strsep(char **, const char *); +size_t strspn(const char *, const char *); + +void *memset(void *, int, size_t); +void *memcpy(void *, const void *, size_t); +void *memmove(void *, const void *, size_t); +int memcmp(const void *, const void *, size_t); +void *memchr(const void *, int, size_t); +void *memchr_inv(const void *, int, size_t); + +#include #ifndef __HAVE_ARCH_STRCMP -int strcmp(const char *, const char *); #define strcmp(s1, s2) __builtin_strcmp(s1, s2) #endif #ifndef __HAVE_ARCH_STRNCMP -int strncmp(const char *, const char *, size_t); #define strncmp(s1, s2, n) __builtin_strncmp(s1, s2, n) #endif -#ifndef __HAVE_ARCH_STRNICMP -int strnicmp(const char *, const char *, size_t); -#endif - #ifndef __HAVE_ARCH_STRCASECMP -int strcasecmp(const char *, const char *); #define strcasecmp(s1, s2) __builtin_strcasecmp(s1, s2) #endif #ifndef __HAVE_ARCH_STRCHR -char *strchr(const char *, int); #define strchr(s1, c) __builtin_strchr(s1, c) #endif #ifndef __HAVE_ARCH_STRRCHR -char *strrchr(const char *, int); #define strrchr(s1, c) __builtin_strrchr(s1, c) #endif #ifndef __HAVE_ARCH_STRSTR -char *strstr(const char *, const char *); #define strstr(s1, s2) __builtin_strstr(s1, s2) #endif #ifndef __HAVE_ARCH_STRLEN -size_t strlen(const char *); #define strlen(s1) __builtin_strlen(s1) #endif -#ifndef __HAVE_ARCH_STRNLEN -size_t strnlen(const char *, size_t); -#endif - -#ifndef __HAVE_ARCH_STRPBRK -char *strpbrk(const char *, const char *); -#endif - -#ifndef __HAVE_ARCH_STRSEP -char *strsep(char **, const char *); -#endif - -#ifndef __HAVE_ARCH_STRSPN -size_t strspn(const char *, const char *); -#endif - - #ifndef __HAVE_ARCH_MEMSET -void *memset(void *, int, size_t); #define memset(s, c, n) __builtin_memset(s, c, n) #endif #ifndef __HAVE_ARCH_MEMCPY -void *memcpy(void *, const void *, size_t); #define memcpy(d, s, n) __builtin_memcpy(d, s, n) #endif #ifndef __HAVE_ARCH_MEMMOVE -void *memmove(void *, const void *, size_t); #define memmove(d, s, n) __builtin_memmove(d, s, n) #endif #ifndef __HAVE_ARCH_MEMCMP -int memcmp(const void *, const void *, size_t); #define memcmp(s1, s2, n) __builtin_memcmp(s1, s2, n) #endif #ifndef __HAVE_ARCH_MEMCHR -void *memchr(const void *, int, size_t); #define memchr(s, c, n) __builtin_memchr(s, c, n) #endif -void *memchr_inv(const void *, int, size_t); - #define is_char_array(x) __builtin_types_compatible_p(typeof(x), char[]) /* safe_xxx always NUL-terminates and returns !=0 if result is truncated. */ From xen-devel-bounces@lists.xenproject.org Thu Apr 01 10:20:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 10:20:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104291.199305 (Exim 4.92) (envelope-from ) id 1lRuRb-0001ec-Vg; Thu, 01 Apr 2021 10:20:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104291.199305; Thu, 01 Apr 2021 10:20:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuRb-0001eV-So; Thu, 01 Apr 2021 10:20:55 +0000 Received: by outflank-mailman (input) for mailman id 104291; Thu, 01 Apr 2021 10:20:54 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuRa-0001eO-T3 for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 10:20:54 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d9035512-b6ab-4b7c-a279-ff6205c89325; Thu, 01 Apr 2021 10:20:54 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2A61DAE86; Thu, 1 Apr 2021 10:20:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d9035512-b6ab-4b7c-a279-ff6205c89325 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617272453; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y/o0dWVTmD5cz4sBu9wV/IeNaEozXqujf7L4dzcBth8=; b=aK2cPZfJgJb2HHd8yK6Jibspp8y4aisZQvoNWVYGymyoY6ijt9wLNdxwTyIKvZFxtLdv+o QAQaUex2GZ995R2gecrbyNVqqtRv070ZYy3hKGAbZLLDGUvPh2lPDnCSlqPCCFXnDMV7CQ QMxhhTKl3tEQLQYc0kf41ZKztgCB/7g= Subject: [PATCH 04/23] lib: move memset() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Message-ID: Date: Thu, 1 Apr 2021 12:20:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit By moving the function into an archive, x86 doesn't need to announce anymore that is has its own implementation - symbol resolution by the linker will now guarantee that the generic function remains unused, and the forwarding to the compiler built-in gets done by the common header anyway. Signed-off-by: Jan Beulich --- a/xen/common/string.c +++ b/xen/common/string.c @@ -311,26 +311,6 @@ char *(strstr)(const char *s1, const cha } #endif -#ifndef __HAVE_ARCH_MEMSET -/** - * memset - Fill a region of memory with the given value - * @s: Pointer to the start of the area. - * @c: The byte to fill the area with - * @count: The size of the area. - * - * Do not use memset() to access IO space, use memset_io() instead. - */ -void *(memset)(void *s, int c, size_t count) -{ - char *xs = (char *) s; - - while (count--) - *xs++ = c; - - return s; -} -#endif - #ifndef __HAVE_ARCH_MEMCPY /** * memcpy - Copy one area of memory to another --- a/xen/include/asm-x86/string.h +++ b/xen/include/asm-x86/string.h @@ -7,9 +7,6 @@ #define __HAVE_ARCH_MEMMOVE #define memmove(d, s, n) __builtin_memmove(d, s, n) -#define __HAVE_ARCH_MEMSET -#define memset(s, c, n) __builtin_memset(s, c, n) - #endif /* __X86_STRING_H__ */ /* * Local variables: --- a/xen/lib/Makefile +++ b/xen/lib/Makefile @@ -4,6 +4,7 @@ lib-y += bsearch.o lib-y += ctors.o lib-y += ctype.o lib-y += list-sort.o +lib-y += memset.o lib-y += muldiv64.o lib-y += parse-size.o lib-y += rbtree.o --- /dev/null +++ b/xen/lib/memset.c @@ -0,0 +1,33 @@ +/* + * Copyright (C) 1991, 1992 Linus Torvalds + */ + +#include + +/** + * memset - Fill a region of memory with the given value + * @s: Pointer to the start of the area. + * @c: The byte to fill the area with + * @count: The size of the area. + * + * Do not use memset() to access IO space, use memset_io() instead. + */ +void *(memset)(void *s, int c, size_t count) +{ + char *xs = (char *) s; + + while (count--) + *xs++ = c; + + return s; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 8 + * tab-width: 8 + * indent-tabs-mode: t + * End: + */ From xen-devel-bounces@lists.xenproject.org Thu Apr 01 10:21:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 10:21:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104295.199317 (Exim 4.92) (envelope-from ) id 1lRuS2-0001n9-8D; Thu, 01 Apr 2021 10:21:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104295.199317; Thu, 01 Apr 2021 10:21:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuS2-0001n2-4v; Thu, 01 Apr 2021 10:21:22 +0000 Received: by outflank-mailman (input) for mailman id 104295; Thu, 01 Apr 2021 10:21:21 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuS1-0001mn-Ch for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 10:21:21 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4101fc9f-d401-4964-a52b-166a26fb6c06; Thu, 01 Apr 2021 10:21:20 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CDE0CB0B6; Thu, 1 Apr 2021 10:21:19 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4101fc9f-d401-4964-a52b-166a26fb6c06 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617272479; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oN+5vP1FCboLBZxZsCScrYUIPf9aJGtajya1l3gxAwM=; b=FvApu/I4xypS6JzaAEaRD3XXPxi2osemKQLvUHQR6rGAud2b9yn/Nk+wJ6oTuoJKlfCBDp wkdLc2NQ1C1INi03PVMetko0NXakIvXDidyMENaJ7iD0BxN62VKLlZLJK7nAmcowcyZD0Q dFA/ionmnepy6LUwJRmF3OcwbJp0VuE= Subject: [PATCH 05/23] lib: move memcpy() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Message-ID: Date: Thu, 1 Apr 2021 12:21:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit By moving the function into an archive, x86 doesn't need to announce anymore that is has its own implementation - symbol resolution by the linker will now guarantee that the generic function remains unused, and the forwarding to the compiler built-in gets done by the common header anyway. Signed-off-by: Jan Beulich --- a/xen/common/string.c +++ b/xen/common/string.c @@ -311,27 +311,6 @@ char *(strstr)(const char *s1, const cha } #endif -#ifndef __HAVE_ARCH_MEMCPY -/** - * memcpy - Copy one area of memory to another - * @dest: Where to copy to - * @src: Where to copy from - * @count: The size of the area. - * - * You should not use this function to access IO space, use memcpy_toio() - * or memcpy_fromio() instead. - */ -void *(memcpy)(void *dest, const void *src, size_t count) -{ - char *tmp = (char *) dest, *s = (char *) src; - - while (count--) - *tmp++ = *s++; - - return dest; -} -#endif - #ifndef __HAVE_ARCH_MEMMOVE /** * memmove - Copy one area of memory to another --- a/xen/include/asm-x86/string.h +++ b/xen/include/asm-x86/string.h @@ -1,9 +1,6 @@ #ifndef __X86_STRING_H__ #define __X86_STRING_H__ -#define __HAVE_ARCH_MEMCPY -#define memcpy(d, s, n) __builtin_memcpy(d, s, n) - #define __HAVE_ARCH_MEMMOVE #define memmove(d, s, n) __builtin_memmove(d, s, n) --- a/xen/lib/Makefile +++ b/xen/lib/Makefile @@ -4,6 +4,7 @@ lib-y += bsearch.o lib-y += ctors.o lib-y += ctype.o lib-y += list-sort.o +lib-y += memcpy.o lib-y += memset.o lib-y += muldiv64.o lib-y += parse-size.o --- /dev/null +++ b/xen/lib/memcpy.c @@ -0,0 +1,34 @@ +/* + * Copyright (C) 1991, 1992 Linus Torvalds + */ + +#include + +/** + * memcpy - Copy one area of memory to another + * @dest: Where to copy to + * @src: Where to copy from + * @count: The size of the area. + * + * You should not use this function to access IO space, use memcpy_toio() + * or memcpy_fromio() instead. + */ +void *(memcpy)(void *dest, const void *src, size_t count) +{ + char *tmp = (char *) dest, *s = (char *) src; + + while (count--) + *tmp++ = *s++; + + return dest; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 8 + * tab-width: 8 + * indent-tabs-mode: t + * End: + */ From xen-devel-bounces@lists.xenproject.org Thu Apr 01 10:21:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 10:21:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104298.199329 (Exim 4.92) (envelope-from ) id 1lRuSU-0001u2-IN; Thu, 01 Apr 2021 10:21:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104298.199329; Thu, 01 Apr 2021 10:21:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuSU-0001tv-Eh; Thu, 01 Apr 2021 10:21:50 +0000 Received: by outflank-mailman (input) for mailman id 104298; Thu, 01 Apr 2021 10:21:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuST-0001tl-ED for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 10:21:49 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 74a238bc-faa6-4588-a8a9-7155f24fd142; Thu, 01 Apr 2021 10:21:48 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B82A5AEA6; Thu, 1 Apr 2021 10:21:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 74a238bc-faa6-4588-a8a9-7155f24fd142 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617272507; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UlwL2DZgk5QMsxjKNY14U9Y4Ed0W95Lps/NjFQlhkyk=; b=kaDKC3HL34Id+gFUhxYyLvm99yhF4rXxMW7FIMhuxPTmBQiRmF3wmZ6EAe/0VgSE1bg0k7 sjlZn/fYs59zGaFD57At7atwibjezKifjFh5+D1MSUMYqwwwNMrJkAm95y3awCiDl9JBV6 rbnSbyOADKk+T2dJVYMBvg5oGLClW34= Subject: [PATCH 06/23] lib: move memmove() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Message-ID: <36449347-69e8-b963-597f-c9359207cf57@suse.com> Date: Thu, 1 Apr 2021 12:21:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit By moving the function into an archive, x86 doesn't need to announce anymore that is has its own implementation - symbol resolution by the linker will now guarantee that the generic function remains unused, and the forwarding to the compiler built-in gets done by the common header anyway. Signed-off-by: Jan Beulich --- a/xen/common/string.c +++ b/xen/common/string.c @@ -311,36 +311,6 @@ char *(strstr)(const char *s1, const cha } #endif -#ifndef __HAVE_ARCH_MEMMOVE -/** - * memmove - Copy one area of memory to another - * @dest: Where to copy to - * @src: Where to copy from - * @count: The size of the area. - * - * Unlike memcpy(), memmove() copes with overlapping areas. - */ -void *(memmove)(void *dest, const void *src, size_t count) -{ - char *tmp, *s; - - if (dest <= src) { - tmp = (char *) dest; - s = (char *) src; - while (count--) - *tmp++ = *s++; - } - else { - tmp = (char *) dest + count; - s = (char *) src + count; - while (count--) - *--tmp = *--s; - } - - return dest; -} -#endif - #ifndef __HAVE_ARCH_MEMCMP /** * memcmp - Compare two areas of memory --- a/xen/include/asm-x86/string.h +++ b/xen/include/asm-x86/string.h @@ -1,9 +1,6 @@ #ifndef __X86_STRING_H__ #define __X86_STRING_H__ -#define __HAVE_ARCH_MEMMOVE -#define memmove(d, s, n) __builtin_memmove(d, s, n) - #endif /* __X86_STRING_H__ */ /* * Local variables: --- a/xen/lib/Makefile +++ b/xen/lib/Makefile @@ -5,6 +5,7 @@ lib-y += ctors.o lib-y += ctype.o lib-y += list-sort.o lib-y += memcpy.o +lib-y += memmove.o lib-y += memset.o lib-y += muldiv64.o lib-y += parse-size.o --- /dev/null +++ b/xen/lib/memmove.c @@ -0,0 +1,42 @@ +/* + * Copyright (C) 1991, 1992 Linus Torvalds + */ + +#include + +/** + * memmove - Copy one area of memory to another + * @dest: Where to copy to + * @src: Where to copy from + * @count: The size of the area. + * + * Unlike memcpy(), memmove() copes with overlapping areas. + */ +void *(memmove)(void *dest, const void *src, size_t count) +{ + char *tmp, *s; + + if (dest <= src) { + tmp = (char *) dest; + s = (char *) src; + while (count--) + *tmp++ = *s++; + } else { + tmp = (char *) dest + count; + s = (char *) src + count; + while (count--) + *--tmp = *--s; + } + + return dest; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 8 + * tab-width: 8 + * indent-tabs-mode: t + * End: + */ From xen-devel-bounces@lists.xenproject.org Thu Apr 01 10:22:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 10:22:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104301.199341 (Exim 4.92) (envelope-from ) id 1lRuT5-00022C-Qt; Thu, 01 Apr 2021 10:22:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104301.199341; Thu, 01 Apr 2021 10:22:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuT5-000225-ND; Thu, 01 Apr 2021 10:22:27 +0000 Received: by outflank-mailman (input) for mailman id 104301; Thu, 01 Apr 2021 10:22:26 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuT3-00021n-UA for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 10:22:25 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4fb8832f-be95-4d20-ae58-4b50e73d5c12; Thu, 01 Apr 2021 10:22:25 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7CFFAAEA6; Thu, 1 Apr 2021 10:22:24 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4fb8832f-be95-4d20-ae58-4b50e73d5c12 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617272544; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e1kdSAKEAN16LJljjXzIk1aT1zZrsyx9ENiy36Xyzo4=; b=nRlQ+tI8dRA9xfib5Ur7UyMrq1n3GB4VeMrC6gyOVKmf3Zt4PdU4K/t8wvc1PHLd/VBtoS F6J1I3Ut7Ddqt8uy5ZlE1jQxTJ8fm5S4cum06Pnu8hG2N6ISsYnOEbti+Bebgk0uBLbC3e Uc68mOTctRb8XUG6lKVk5Xz1W7OecHI= Subject: [PATCH 07/23] lib: move memcmp() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu References: Message-ID: Date: Thu, 1 Apr 2021 12:22:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Signed-off-by: Jan Beulich --- a/xen/common/string.c +++ b/xen/common/string.c @@ -311,25 +311,6 @@ char *(strstr)(const char *s1, const cha } #endif -#ifndef __HAVE_ARCH_MEMCMP -/** - * memcmp - Compare two areas of memory - * @cs: One area of memory - * @ct: Another area of memory - * @count: The size of the area. - */ -int (memcmp)(const void *cs, const void *ct, size_t count) -{ - const unsigned char *su1, *su2; - int res = 0; - - for( su1 = cs, su2 = ct; 0 < count; ++su1, ++su2, count--) - if ((res = *su1 - *su2) != 0) - break; - return res; -} -#endif - #ifndef __HAVE_ARCH_MEMCHR /** * memchr - Find a character in an area of memory. --- a/xen/lib/Makefile +++ b/xen/lib/Makefile @@ -4,6 +4,7 @@ lib-y += bsearch.o lib-y += ctors.o lib-y += ctype.o lib-y += list-sort.o +lib-y += memcmp.o lib-y += memcpy.o lib-y += memmove.o lib-y += memset.o --- /dev/null +++ b/xen/lib/memcmp.c @@ -0,0 +1,32 @@ +/* + * Copyright (C) 1991, 1992 Linus Torvalds + */ + +#include + +/** + * memcmp - Compare two areas of memory + * @cs: One area of memory + * @ct: Another area of memory + * @count: The size of the area. + */ +int (memcmp)(const void *cs, const void *ct, size_t count) +{ + const unsigned char *su1, *su2; + int res = 0; + + for( su1 = cs, su2 = ct; 0 < count; ++su1, ++su2, count--) + if ((res = *su1 - *su2) != 0) + break; + return res; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 8 + * tab-width: 8 + * indent-tabs-mode: t + * End: + */ From xen-devel-bounces@lists.xenproject.org Thu Apr 01 10:22:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 10:22:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104304.199353 (Exim 4.92) (envelope-from ) id 1lRuTO-00028j-72; Thu, 01 Apr 2021 10:22:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104304.199353; Thu, 01 Apr 2021 10:22:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuTO-00028a-3b; Thu, 01 Apr 2021 10:22:46 +0000 Received: by outflank-mailman (input) for mailman id 104304; Thu, 01 Apr 2021 10:22:45 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuTN-00028Q-FU for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 10:22:45 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1ac8f106-5911-401b-9a4a-e6bb748213bf; Thu, 01 Apr 2021 10:22:44 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C0F65AEA6; Thu, 1 Apr 2021 10:22:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1ac8f106-5911-401b-9a4a-e6bb748213bf X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617272563; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KxBFJAZ2KdhCH/22RG50f65pG/J6rh981un4Qrrk7qs=; b=uOPVgUllDCy67MY+92BXsz4sL3+4fgw2GNxlRoKLLRqhOEXjpirWugQoKc3gsNO2LlXkmC FBABYsIsKCE0VhREqQFbix1lgQ1FJlnQ9Dt5FUr+do9hQGAZuFY3gpG/fBhtVAh0dMPYHl ReMYzkvJ2zFymUS/MLAa3ZD4XX6NxtE= Subject: [PATCH 08/23] lib: move memchr() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu References: Message-ID: Date: Thu, 1 Apr 2021 12:22:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Signed-off-by: Jan Beulich --- a/xen/common/string.c +++ b/xen/common/string.c @@ -311,28 +311,6 @@ char *(strstr)(const char *s1, const cha } #endif -#ifndef __HAVE_ARCH_MEMCHR -/** - * memchr - Find a character in an area of memory. - * @s: The memory area - * @c: The byte to search for - * @n: The size of the area. - * - * returns the address of the first occurrence of @c, or %NULL - * if @c is not found - */ -void *(memchr)(const void *s, int c, size_t n) -{ - const unsigned char *p = s; - - while (n--) - if ((unsigned char)c == *p++) - return (void *)(p - 1); - - return NULL; -} -#endif - /** * memchr_inv - Find an unmatching character in an area of memory. * @s: The memory area --- a/xen/lib/Makefile +++ b/xen/lib/Makefile @@ -4,6 +4,7 @@ lib-y += bsearch.o lib-y += ctors.o lib-y += ctype.o lib-y += list-sort.o +lib-y += memchr.o lib-y += memcmp.o lib-y += memcpy.o lib-y += memmove.o --- /dev/null +++ b/xen/lib/memchr.c @@ -0,0 +1,35 @@ +/* + * Copyright (C) 1991, 1992 Linus Torvalds + */ + +#include + +/** + * memchr - Find a character in an area of memory. + * @s: The memory area + * @c: The byte to search for + * @n: The size of the area. + * + * returns the address of the first occurrence of @c, or %NULL + * if @c is not found + */ +void *(memchr)(const void *s, int c, size_t n) +{ + const unsigned char *p = s; + + while (n--) + if ((unsigned char)c == *p++) + return (void *)(p - 1); + + return NULL; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 8 + * tab-width: 8 + * indent-tabs-mode: t + * End: + */ From xen-devel-bounces@lists.xenproject.org Thu Apr 01 10:23:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 10:23:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104309.199365 (Exim 4.92) (envelope-from ) id 1lRuTm-0002Fy-Gj; Thu, 01 Apr 2021 10:23:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104309.199365; Thu, 01 Apr 2021 10:23:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuTm-0002Fr-Dc; Thu, 01 Apr 2021 10:23:10 +0000 Received: by outflank-mailman (input) for mailman id 104309; Thu, 01 Apr 2021 10:23:09 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuTl-0002Ep-1a for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 10:23:09 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5993ffe6-787f-475b-b7ec-368f2c9a3671; Thu, 01 Apr 2021 10:23:07 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1529BAED7; Thu, 1 Apr 2021 10:23:07 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5993ffe6-787f-475b-b7ec-368f2c9a3671 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617272587; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5742tdH/lAsOCplYSlX/aqstUJg8Rlv97TdWNCdRmSk=; b=ANROaimZWyzPlbs+4BeRDilkJtvIDsazHfGxSUcZuaQRhSHX2z0Sjb4Bb/sOszH8YVl/lX PH6jFzbeGidL4IhDn7Gyi6zXcWSZFqKKxFmhYaCw6iNB74mjlsJniiTasoOgEV94SxvN6a 0W8/f1ceznKvCPDD+VZsPlyDN7H/Zbw= Subject: [PATCH 09/23] lib: move memchr_inv() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu References: Message-ID: Date: Thu, 1 Apr 2021 12:23:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Signed-off-by: Jan Beulich --- a/xen/common/string.c +++ b/xen/common/string.c @@ -311,26 +311,6 @@ char *(strstr)(const char *s1, const cha } #endif -/** - * memchr_inv - Find an unmatching character in an area of memory. - * @s: The memory area - * @c: The byte that is expected - * @n: The size of the area. - * - * returns the address of the first occurrence of a character other than @c, - * or %NULL if the whole buffer contains just @c. - */ -void *memchr_inv(const void *s, int c, size_t n) -{ - const unsigned char *p = s; - - while (n--) - if ((unsigned char)c != *p++) - return (void *)(p - 1); - - return NULL; -} - /* * Local variables: * mode: C --- a/xen/lib/Makefile +++ b/xen/lib/Makefile @@ -5,6 +5,7 @@ lib-y += ctors.o lib-y += ctype.o lib-y += list-sort.o lib-y += memchr.o +lib-y += memchr_inv.o lib-y += memcmp.o lib-y += memcpy.o lib-y += memmove.o --- /dev/null +++ b/xen/lib/memchr_inv.c @@ -0,0 +1,35 @@ +/* + * Copyright (C) 1991, 1992 Linus Torvalds + */ + +#include + +/** + * memchr_inv - Find an unmatching character in an area of memory. + * @s: The memory area + * @c: The byte that is expected + * @n: The size of the area. + * + * returns the address of the first occurrence of a character other than @c, + * or %NULL if the whole buffer contains just @c. + */ +void *memchr_inv(const void *s, int c, size_t n) +{ + const unsigned char *p = s; + + while (n--) + if ((unsigned char)c != *p++) + return (void *)(p - 1); + + return NULL; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 8 + * tab-width: 8 + * indent-tabs-mode: t + * End: + */ From xen-devel-bounces@lists.xenproject.org Thu Apr 01 10:23:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 10:23:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104310.199377 (Exim 4.92) (envelope-from ) id 1lRuTp-0002IO-Om; Thu, 01 Apr 2021 10:23:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104310.199377; Thu, 01 Apr 2021 10:23:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuTp-0002IE-LS; Thu, 01 Apr 2021 10:23:13 +0000 Received: by outflank-mailman (input) for mailman id 104310; Thu, 01 Apr 2021 10:23:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuTo-0002Hh-Cv for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 10:23:12 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5d23c387-a08c-4507-be66-d0669f50a43e; Thu, 01 Apr 2021 10:23:10 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d23c387-a08c-4507-be66-d0669f50a43e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617272590; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=FVzsZ0mkSIkxtRKP3p3PSvTjfw2kuq7GTDLAG4vG22o=; b=TZF+njdXjdpaQU9mnB+lorHIu1rD65SY5llUBc0YluDzpyRTTHNW5pBM rQbEWclV8d82QThPUoNroL/vL9hjQedc/PhWepfKQpuOZKY5ZMVBGj4SI mD/CKQWnXBTEsdHKwgWs3Q3ZTZYTy14NeLv2wjiB1NDlsw+bYEpJuQxtk I=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: qRYtQFagYKcNt4XqlQBWb8oK+bqim6YGuEFIfIlZW4pzcQSdcw7ez+KZM3VBE4Ch3Fwb1ynoxk 6U2Tk9D7INfcp2Wjupzl4NmO8hb0IA2pZZiOTQ/Qym/tOY44dBJYxcre83bH/iodYwFtWEgihZ yVJgHeHCYoodEYMRXQGnbJg+v5X6NzF8Uw/Q01uN5CTUN9tPQlAbNhHYYH0sq6My6vhyw5X2MY Jxit2drsjXkd00xL4ncqUzvBEBzRpeH4wJ6togB6B8RDNrCFHeV8ealK1CmeHMOeMhmfJXumqe /ms= X-SBRS: 5.2 X-MesageID: 40673825 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:C124Hq59MPwxKqZ6eAPXwSyEI+orLtY04lQ7vn1ZYSd+NuSFis Gjm+ka3xfoiDAXHEotg8yEJbPoexzh3LZPy800Ma25VAfr/FGpIoZr8Jf4z1TbdxHW3tV2kZ 1te60WMrDNJHBnkMf35xS5Gd48wN+BtJuln/va0m0Fd2BXQotLhj0JbjqzOEtwWQVAGN4FD5 Ka/MVKvH6Nfn4QY8S9CBA+LpL+jvfMk4/rZgNDOg4/5GC1/EiVwZPZMzzd5BcRVDtT3awvmF KqryXV7riu2svLrCP0+HTU6/1t6bnc4/9iIODJtcQPMDXrjW+TFfpccpmPpio8ru3qyHtCqq i0nz4aM85+62zccwiOyHOHsWmQs0df11bYxUKFmnymmMTlRVsBerV8rLhEeRjU4VdIhqAa7I t32Quixv9qJCKFtiH869/Ubgpth0q5rFEz+NRj80B3YM8wbqRcopcY+14QOJAcHDji4IRiK+ V2CtrAjcwmO2+yXjT8hC1C0dasVnM8ElOvRVUDgNWc13xzkGpix0UV6cQDlh47hd8AYqgBw9 6BHrVjlblIQMNTR7l6Hv09Tcy+DXGIaQ7QMUqJSG6XWp0vCjbokdra8b817OaldNgj150pgq nMV1teqCobZ1/uM8uTx5dGmyq9D1mVbHDI8IVz9pJ5srrzSP7AKiuYUm0jlMOmvrExGcved/ GvOI9HIvPqIGf0cLw5nzHWat13Ez0zQccVstE0VxalucTQMLDnseTdbbLyKdPWYHUZc1K6Jk FGcCn4Jc1G4EzucGT/mgLtV3TkfVG62ZpxFaPd7tUC0YRlDPwPjiElzXCCou2bIzxLtaI7OG FkJqn8r6+9rW6quUHF8ntuIRgYKkpO+r3vXzdrqGYxQg/JWIdGn+/aVXFZ3XOBKBM6ZdjRCh Rjq1N+/r/yCYeRyyAkA9eOKXmbkHMXmXKPQ/4n6+y+zPagXql9IoctWaR3GwmOPQdygxxWpG BKbxJBelXSDQr0iaKujIUdAcbWc9UUunbvHedk7Vbk8WmMr8AmQXUWGxqjS9SejwoVSz1IvV Fp6KMEjL2cmTGgFHsnjI0DQSxxQVXSJIgDIBWOZY1SlLyuQg12QGuQrRGxih04eAPRhgwvr1 2kCRfRVeDAA1JbtHwd773j90lscH6BO2hqbGphjIF7HWPam3p63OORfJCv22+JZlZq+JBYDB j1JR8pZi9+zdG+0xCY3AuYHXI935M0I6jzCq8gf7y74ALYFKS40YU9W9la85ZuOIqw7qslUe eDdxSUKz29IeUzwACRrmskPi4xiHRMq4Kb5DTVqEyDmFg4Cr7uBX4jYZcxCdSV9XLlSPaFy4 8Rt6NCgcKAdkHKLuebwqTWZQNZIhzdoWSKX/glwKokzp4ahf9WJd3nSjPG23FM4QUmIOr1nE 0YRr5n4LqpAP4bQ+UiPwZQ/l8kj720XTMWmz2zJu81Zlc2iXDHe/uP/rrTsLIqa3fx7DfYCB 268ydH+e3CUDbG/bkGC7goKWATTEQn8nxt8KejcILXYT/aPN1rzR6fMnWndqVaR7XAMbIMrg xi69XNptSpTUPDqXftlAo+BLlP/WahSd6zBwzJOdcgya3GBX28xo2w4MCyiz/rTyCccEpwv/ wDSXAt X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="40673825" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IGU3gj+fEVCLHlOzWdAXzgS9WAOQikTT8B6jnwO1zAzOsLXbDcohJiMxDv3FiIL3BBGiHnLRM1HaRy9adC4QsjLGZeazW7CCuhUiXT60/tUVxoL/n1Ikl5vGBHFBt83nVASD8BLl8xlg0LoguPbAUCilf2Fe+AgtB//G8EFY8+2ZBFpcHVDiMwQkn/5pTf9j6dFr4OTWKUzlX5GWRwXlL1nR7ROW8Xa94qsFTqfNRo0dqd/fHvLODosXaGI/lUVaNCwycTXqGlcCoVBbHnn0b/lIpfCLbAwUvfEb1jlRYWVq5223M+ON44UxwUD1hjgFgoLKNoH4pB5ben47dvFp1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fzignekplPfrIkofHKCad40QtmcSARFz8dyYlMrVaZk=; b=K7Ga2K26AnJQwOQmfuFWqXEzby63OKCrz8vrLsozqKD+UD2J2amq3NMx7igAorRerty2hdCfg/Lmo4d6vd2ki7cJNEBUlcOywGdr6blhHiQAX2/5yUQlbfen0ofw5y5mR3tVd+QdVUiiafcvIXFVKNVqrOm/Jhp59vKGxmH2i6ZVmbEL+tOPeO0eWkCIzpkLcts44sVSnPznCV1K4Cb46j4gg8zCYJSo4BLbwCAIc3mZ05bJ1+t6l5ERzGryUw1BjbHmcwFhAnttuiO7BINAZXX72Irun+5ktnG0/7f37644JLC8pxcb4aHgC1QCt/7UVuNQMpDIYMXh0lJeeYOOIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fzignekplPfrIkofHKCad40QtmcSARFz8dyYlMrVaZk=; b=aKvkySR9SH9CwxOCFjFMs8p9b+3mTNklgGE1n8tnjVY7zAzSiT9neB2mzSrpXvDcRCvMCIu5OTjim3ZC9GOCoc2zYdagQdQGCUCOhdpYRuaYqLopyMfBZ2nImNQhZeI9NI8WyraTqC/PT/79/LFIj6FiOD5i1mgPKqY+mr5dpps= From: Roger Pau Monne To: CC: Roger Pau Monne , Paul Durrant , Wei Liu , Jan Beulich , Andrew Cooper Subject: [PATCH] x86/viridian: EOI MSR should always happen in affected vCPU context Date: Thu, 1 Apr 2021 12:22:52 +0200 Message-ID: <20210401102252.95196-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0059.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:31::23) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3dba7f02-7c34-4e2c-72ab-08d8f4f82374 X-MS-TrafficTypeDiagnostic: DS7PR03MB5542: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Xi6Kmv7EzL+yS2ii24RDitySm7GjLu0/kwzHqo3oH+r+odlJad8B0JCNT+F2IQpAHvsM5nI+v5jRb57hKD7Y71FVqyyr3/o9t1JT+9Sbvy3XArnO8XEcJBZNqiUMlmuqibo8HC55vpkzfTvYFBdzYyjC4NXz4gLzI3STrNkCF+Ad2Y9OHho1eWrSv8E04733HA7JRtygtRgvcm7YvVWZ1I0HI2R4C6B35mqcO0hBBcC53W0sQ+aTRrNIGvtY5Y3oGGxzwGmEAKTBMu5fC8PRYR97LryJD2Z0EBoFG3OopO+c/wAaoN+sAz/UuNLwT0lDrgYsKifoxbQobJm+dlzgONn/+k6vx7E2YIbu1mLoiDSH+bzT7lPqdkJGs0ci71Ah0hW9U2wb8sU66ODGmH330ebFLXjBlMKviMM+YlkmRlq1oZVJruOgELjvnM03QKPwg+r73uEBEHt/qC9A4oSLt30+RvhvO51gfMiR2VPtSCQUvf1gh44kqi/XAUQU7wR87mx6MRgkb8788b8AN7HGOupmzfQBqr4+Bi8P9R16B6fRxFp1nIl8VuuBz8lgY3P89idB6syvRxBb34A60ih0UPwi6O+cr+Q1tax5K60hyhX796GAWxFmug3dj3XrKnyJmyfKww2NhUnSfyCp5o4H3Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(346002)(376002)(39850400004)(366004)(136003)(1076003)(6486002)(36756003)(186003)(16526019)(478600001)(66946007)(6666004)(26005)(8936002)(6496006)(38100700001)(4326008)(66556008)(2906002)(6916009)(54906003)(5660300002)(66476007)(2616005)(8676002)(107886003)(956004)(316002)(86362001)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?MWpGeVpQQXBOZmd2Z0hWc2NxMjJYUFdweWxvTFFCbWNiV2oyd0FmS0RNYTQz?= =?utf-8?B?eUtCLzdJeExQb0NjU1RYd0tMREd5TUM4dDY4WmM5YXhyT09jY25wR1VqRjBK?= =?utf-8?B?ZWFGZjJaNDJxNUVUSTdmVHpZMnZSMlJ3ZVBKaTZLcFRxRXhDbm52bWdBQ1Y0?= =?utf-8?B?WTRnblNzVHhIMytPdnlvZFljenQvTXFNdUUra2N2MVN0T0QxOG5ydXZKQUFU?= =?utf-8?B?MGJSUnRtdHlTQ1ZxbFFXU2RuZm9GN1BaNVpybTdrU2hJemNnZkJPSGorbzFh?= =?utf-8?B?OHQ1cWc1dEZGcDJsM3NLTXprWXNyS3FsNVJ0anVUNjlaNGhXcVhHVU5MU2Jz?= =?utf-8?B?a09VY0VjZVlsL0Y3K2xuR291UlpXQ1NuN0F2dkVmQXVxWVREb1FKcHFJMktV?= =?utf-8?B?bGF2VGNWZlErQTdBN05NK29jRlpRRUdzWjJRWUR4RFhKNWFJU3JpbFJxcFBL?= =?utf-8?B?Zi96V0V4SHJjcXJlT01FYTR2ckJTYUxtYWI2b3l2aDhucXVxVzZ0SG1FRE9K?= =?utf-8?B?M1FPSlN6RUw2dm9mVkFzOU9vdDJUaXpTaVVQZHRWa2V0SEovR25yVmdjS0Z5?= =?utf-8?B?bUFnR3F2ZkZBeDVyMTJXS1JCclA5M2hXcEZld2MrN0NJR1FkUllPd3hSK0Q5?= =?utf-8?B?djlFamRPakxDaWYxcVQ3cUhBQy9JQXh4M0NzRWpHdlAyU1pjaVRtdG9lWjJn?= =?utf-8?B?Z21tOUM3ejk1MHFRM0ZmV1JsMzlESVBGbFdGaXdyTDQyQlBaVnc5ZEdRY1lH?= =?utf-8?B?QlhjbUdCTEtJaGoxbVBCazFPSFd1MDlkV1ZUb3JPMjZKa0tNa3ZPNXEyM2RR?= =?utf-8?B?RE14MGFNSklHamkxZjNlVzVmNnNacks1dnlQTnY2QmtnM3Z0aW82N2trMWNy?= =?utf-8?B?ckh4NGIwWkdjcmlsdjdlQVp5TGdyV1lYT2NISWpuQlRsTGpTWjB1UzRLQUIv?= =?utf-8?B?bHFWOGpCYVh3ajc2T0U2bFpXVzk4VzJGQTJiOCtPaGowbmorMFpiU09wenFj?= =?utf-8?B?T1hRNzBZQk9jMlZyVmFNcHZQT0VlMVM4K3A1dml6aWdsaDNWa25EVHprVXdN?= =?utf-8?B?bml2bFNtTzcvZTNiY0k3RVJJbDFqVWIzc2thRDRKQXBQWVhwWW9xL0RYNEg0?= =?utf-8?B?aWVacmwrZlFaOEI0Uit5Yjk5OFpYQzZOakRhb3lteE1adnBhaXVBT3pzWDlp?= =?utf-8?B?YktpVlhXQ0JsdCt6MGV5WVp1MERmdy9uYWVUNHNjSmg4bWJHZTJIeUFjTjR3?= =?utf-8?B?WnhhT1o0NEpqVEdZVkhwNlhnYUR2dmo0a2YrZjJKMHpMQmRVa0NhSThoM3c0?= =?utf-8?B?TVdSd2J5WGkrSTJ4dTRHR09HNHhwa3FhMnc2aVgremVnbnNqbktMZUJ2ekNs?= =?utf-8?B?QWhGZTlFY2VTTi9LREtqbFlHTWpUaENCeXQwNjRRWnlaR2loUU5iOHc5UnU3?= =?utf-8?B?L3lhaU5ITTJ3WEFuR0xPK2FOR3FzL3NRQTE5Qm1iOFN3SURuY215anRyQjBN?= =?utf-8?B?S1d2OFM1M0xkZXhZZitFSU94N0lZaXZ0MTZIbkFVbTBLREhvQUIxOUVQNGpZ?= =?utf-8?B?WWtRNmQ2Zm5sSVpZMW9adDlKdFJGRUVINEFTN3RGOWdRUVVHM3FocE40VEoz?= =?utf-8?B?ZENseXFsNFRjcVZwdjJoYm4wRUNnWm1iM3FvV3JsMkhFR3Q3TFNQck03dVRG?= =?utf-8?B?aEZEZldnZEdMdGNBV3kyYjRmUUJmbkdtckpsOEtrOTQvS0gvdFZTcmZnNldE?= =?utf-8?B?MHFZSWVwMWRUN2U1bHZyNEZkczk2eTlQNEJwOWdCQkw4amFoMFRHQldOWFZI?= =?utf-8?B?MUIrNjgxMzd6a3ZSMXM4UT09?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3dba7f02-7c34-4e2c-72ab-08d8f4f82374 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 10:23:05.8906 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +b5TrogTHvmc/6j5HtK3X6uVkxdU0wj2wl7R12rk0JwFiFyLlyABjnH6MZPrliC44qz4k99P7+I1JSiDw7zmGA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5542 X-OriginatorOrg: citrix.com The HV_X64_MSR_EOI wrmsr should always happen with the target vCPU as current, as there's no support for EOI'ing interrupts on a remote vCPU. While there also turn the unconditional assert at the top of the function into an error on non-debug builds. No functional change intended. Requested-by: Jan Beulich Signed-off-by: Roger Pau Monné --- xen/arch/x86/hvm/viridian/synic.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/hvm/viridian/synic.c b/xen/arch/x86/hvm/viridian/synic.c index 22e2df27e5d..e18538c60a6 100644 --- a/xen/arch/x86/hvm/viridian/synic.c +++ b/xen/arch/x86/hvm/viridian/synic.c @@ -79,11 +79,20 @@ int viridian_synic_wrmsr(struct vcpu *v, uint32_t idx, uint64_t val) struct viridian_vcpu *vv = v->arch.hvm.viridian; struct domain *d = v->domain; - ASSERT(v == current || !v->is_running); + if ( v != current && v->is_running ) + { + ASSERT_UNREACHABLE(); + return X86EMUL_EXCEPTION; + } switch ( idx ) { case HV_X64_MSR_EOI: + if ( v != current ) + { + ASSERT_UNREACHABLE(); + return X86EMUL_EXCEPTION; + } vlapic_EOI_set(vcpu_vlapic(v)); break; -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 01 10:23:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 10:23:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104313.199389 (Exim 4.92) (envelope-from ) id 1lRuU7-0002RT-3d; Thu, 01 Apr 2021 10:23:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104313.199389; Thu, 01 Apr 2021 10:23:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuU6-0002RM-W1; Thu, 01 Apr 2021 10:23:30 +0000 Received: by outflank-mailman (input) for mailman id 104313; Thu, 01 Apr 2021 10:23:29 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuU5-0002Qp-2l for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 10:23:29 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8f259c5c-d47e-4d74-96f7-75188448331c; Thu, 01 Apr 2021 10:23:28 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A5E6EAE86; Thu, 1 Apr 2021 10:23:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8f259c5c-d47e-4d74-96f7-75188448331c X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617272607; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nBbweA3vL9rMSj+WwvAqtgbZp6SBSyR96p37O2EqfpE=; b=IQTMtGb9knfLlR5xxb9YeGf2M90KdEeJ9v8Ftz46dP/kUuwkZXjOhWzJkGswOBSTUCJpBJ qoLEbyC1jamnFozUKQzTW3yJed1Db/gbrVZZ5GxQNAj0SUeG63ki/MPWA8wZZBH0u96CV8 NDJGkjmZiVUdEszQX1pKTw9IDzrSbKY= Subject: [PATCH 10/23] lib: move strlen() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu References: Message-ID: <7e82929a-5eb0-a8a2-ec61-005311d74b44@suse.com> Date: Thu, 1 Apr 2021 12:23:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Signed-off-by: Jan Beulich --- a/xen/common/string.c +++ b/xen/common/string.c @@ -184,21 +184,6 @@ char *(strrchr)(const char *s, int c) } #endif -#ifndef __HAVE_ARCH_STRLEN -/** - * strlen - Find the length of a string - * @s: The string to be sized - */ -size_t (strlen)(const char * s) -{ - const char *sc; - - for (sc = s; *sc != '\0'; ++sc) - /* nothing */; - return sc - s; -} -#endif - #ifndef __HAVE_ARCH_STRNLEN /** * strnlen - Find the length of a length-limited string --- a/xen/lib/Makefile +++ b/xen/lib/Makefile @@ -14,6 +14,7 @@ lib-y += muldiv64.o lib-y += parse-size.o lib-y += rbtree.o lib-y += sort.o +lib-y += strlen.o lib-$(CONFIG_X86) += xxhash32.o lib-$(CONFIG_X86) += xxhash64.o --- /dev/null +++ b/xen/lib/strlen.c @@ -0,0 +1,28 @@ +/* + * Copyright (C) 1991, 1992 Linus Torvalds + */ + +#include + +/** + * strlen - Find the length of a string + * @s: The string to be sized + */ +size_t (strlen)(const char * s) +{ + const char *sc; + + for (sc = s; *sc != '\0'; ++sc) + /* nothing */; + return sc - s; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 8 + * tab-width: 8 + * indent-tabs-mode: t + * End: + */ From xen-devel-bounces@lists.xenproject.org Thu Apr 01 10:23:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 10:23:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104317.199401 (Exim 4.92) (envelope-from ) id 1lRuUQ-0002YZ-Bq; Thu, 01 Apr 2021 10:23:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104317.199401; Thu, 01 Apr 2021 10:23:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuUQ-0002YR-8V; Thu, 01 Apr 2021 10:23:50 +0000 Received: by outflank-mailman (input) for mailman id 104317; Thu, 01 Apr 2021 10:23:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuUP-0002YB-I4 for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 10:23:49 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 59e2009a-f191-4924-ab52-1b2717c39cc9; Thu, 01 Apr 2021 10:23:48 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1AD7AAED7; Thu, 1 Apr 2021 10:23:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 59e2009a-f191-4924-ab52-1b2717c39cc9 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617272628; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j90++h3cFk0QIuXtJzchPhaTge5uMVq3pz3OcoqtqAs=; b=ebPsdQB4HSGKgTai3XRPrGo+eMQXtcbAZIZt9BxS4EYl3absZHxQG6icjnL5RDhQ8fwJji 9yXRzYmkqNx8BXROayS9GwPh9ZtYsedsECPgeRzSaTok0HZogjEl8YTJRU3QfKxNsIH543 2yS9bsH6KoCa2lY3k5pImfBgf90tt4I= Subject: [PATCH 11/23] lib: move strnlen() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu References: Message-ID: <4545723a-44ec-6586-79bd-7b7f8442619b@suse.com> Date: Thu, 1 Apr 2021 12:23:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Signed-off-by: Jan Beulich --- a/xen/common/string.c +++ b/xen/common/string.c @@ -184,22 +184,6 @@ char *(strrchr)(const char *s, int c) } #endif -#ifndef __HAVE_ARCH_STRNLEN -/** - * strnlen - Find the length of a length-limited string - * @s: The string to be sized - * @count: The maximum number of bytes to search - */ -size_t strnlen(const char * s, size_t count) -{ - const char *sc; - - for (sc = s; count-- && *sc != '\0'; ++sc) - /* nothing */; - return sc - s; -} -#endif - #ifndef __HAVE_ARCH_STRSPN /** * strspn - Calculate the length of the initial substring of @s which only --- a/xen/lib/Makefile +++ b/xen/lib/Makefile @@ -15,6 +15,7 @@ lib-y += parse-size.o lib-y += rbtree.o lib-y += sort.o lib-y += strlen.o +lib-y += strnlen.o lib-$(CONFIG_X86) += xxhash32.o lib-$(CONFIG_X86) += xxhash64.o --- /dev/null +++ b/xen/lib/strnlen.c @@ -0,0 +1,29 @@ +/* + * Copyright (C) 1991, 1992 Linus Torvalds + */ + +#include + +/** + * strnlen - Find the length of a length-limited string + * @s: The string to be sized + * @count: The maximum number of bytes to search + */ +size_t strnlen(const char * s, size_t count) +{ + const char *sc; + + for (sc = s; count-- && *sc != '\0'; ++sc) + /* nothing */; + return sc - s; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 8 + * tab-width: 8 + * indent-tabs-mode: t + * End: + */ From xen-devel-bounces@lists.xenproject.org Thu Apr 01 10:24:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 10:24:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104320.199413 (Exim 4.92) (envelope-from ) id 1lRuUm-0002g2-NE; Thu, 01 Apr 2021 10:24:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104320.199413; Thu, 01 Apr 2021 10:24:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuUm-0002fv-J0; Thu, 01 Apr 2021 10:24:12 +0000 Received: by outflank-mailman (input) for mailman id 104320; Thu, 01 Apr 2021 10:24:11 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuUl-0002fc-07 for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 10:24:11 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 9ce87208-548f-49a6-90ca-36c4304d5841; Thu, 01 Apr 2021 10:24:10 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 68116AED7; Thu, 1 Apr 2021 10:24:09 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9ce87208-548f-49a6-90ca-36c4304d5841 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617272649; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NE7O51HBJ2kdFYFTIPJPJoUwkO79zqoySamP2nD1/Go=; b=E84cAT4Yqg1Gf6SKjQef8xh6xzWV+j2HJbYS/kPrH9y6E0819qvAtThuQ6tkhcHT9dv5yn VDu7pyMoUSo9Zy6Qed+wTfOlp7hjnAeA34eKcwKOHJbt9YuivQUy2NEd5CNTWn9CbUm0VK MtkniYyrLZfDRYCigd2gVp4nPIYvjw0= Subject: [PATCH 12/23] lib: move strcmp() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu References: Message-ID: <0b66b9ff-72c0-b645-87a7-13883e046d1f@suse.com> Date: Thu, 1 Apr 2021 12:24:08 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Signed-off-by: Jan Beulich --- a/xen/common/string.c +++ b/xen/common/string.c @@ -111,25 +111,6 @@ size_t strlcat(char *dest, const char *s EXPORT_SYMBOL(strlcat); #endif -#ifndef __HAVE_ARCH_STRCMP -/** - * strcmp - Compare two strings - * @cs: One string - * @ct: Another string - */ -int (strcmp)(const char *cs, const char *ct) -{ - register signed char __res; - - while (1) { - if ((__res = *cs - *ct++) != 0 || !*cs++) - break; - } - - return __res; -} -#endif - #ifndef __HAVE_ARCH_STRNCMP /** * strncmp - Compare two length-limited strings --- a/xen/lib/Makefile +++ b/xen/lib/Makefile @@ -14,6 +14,7 @@ lib-y += muldiv64.o lib-y += parse-size.o lib-y += rbtree.o lib-y += sort.o +lib-y += strcmp.o lib-y += strlen.o lib-y += strnlen.o lib-$(CONFIG_X86) += xxhash32.o --- /dev/null +++ b/xen/lib/strcmp.c @@ -0,0 +1,32 @@ +/* + * Copyright (C) 1991, 1992 Linus Torvalds + */ + +#include + +/** + * strcmp - Compare two strings + * @cs: One string + * @ct: Another string + */ +int (strcmp)(const char *cs, const char *ct) +{ + register signed char __res; + + while (1) { + if ((__res = *cs - *ct++) != 0 || !*cs++) + break; + } + + return __res; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 8 + * tab-width: 8 + * indent-tabs-mode: t + * End: + */ From xen-devel-bounces@lists.xenproject.org Thu Apr 01 10:25:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 10:25:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104326.199425 (Exim 4.92) (envelope-from ) id 1lRuVc-0002sP-4b; Thu, 01 Apr 2021 10:25:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104326.199425; Thu, 01 Apr 2021 10:25:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuVc-0002sI-1Q; Thu, 01 Apr 2021 10:25:04 +0000 Received: by outflank-mailman (input) for mailman id 104326; Thu, 01 Apr 2021 10:25:03 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuVa-0002s8-Va for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 10:25:03 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ce857047-d00c-4769-9c5d-97dcbe6962e9; Thu, 01 Apr 2021 10:25:01 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2B45EAE86; Thu, 1 Apr 2021 10:25:01 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ce857047-d00c-4769-9c5d-97dcbe6962e9 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617272701; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vdu1McyqjuuA+MC/um/kTIQJPhtl9yF8EaqHekvmKgo=; b=r6/NqASRM1dJYwp/MXnaampOR5t9AvcCQ/kvOT3tlATyaTFwO99W525Cl83vqSo0mRRjaq BKmsSK3P+FtfMGcv9DvdS4TeC1+6etDbjKx9/X/NngjkOVjohiG1Woy+lqlSadpj4miVuB 7LGHkVDYoSHPBpggcEBLaAYTZ5b/6e4= Subject: [PATCH 13/23] lib: move strncmp() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu References: Message-ID: Date: Thu, 1 Apr 2021 12:25:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Signed-off-by: Jan Beulich --- a/xen/common/string.c +++ b/xen/common/string.c @@ -111,27 +111,6 @@ size_t strlcat(char *dest, const char *s EXPORT_SYMBOL(strlcat); #endif -#ifndef __HAVE_ARCH_STRNCMP -/** - * strncmp - Compare two length-limited strings - * @cs: One string - * @ct: Another string - * @count: The maximum number of bytes to compare - */ -int (strncmp)(const char *cs, const char *ct, size_t count) -{ - register signed char __res = 0; - - while (count) { - if ((__res = *cs - *ct++) != 0 || !*cs++) - break; - count--; - } - - return __res; -} -#endif - #ifndef __HAVE_ARCH_STRCHR /** * strchr - Find the first occurrence of a character in a string --- a/xen/lib/Makefile +++ b/xen/lib/Makefile @@ -16,6 +16,7 @@ lib-y += rbtree.o lib-y += sort.o lib-y += strcmp.o lib-y += strlen.o +lib-y += strncmp.o lib-y += strnlen.o lib-$(CONFIG_X86) += xxhash32.o lib-$(CONFIG_X86) += xxhash64.o --- /dev/null +++ b/xen/lib/strncmp.c @@ -0,0 +1,34 @@ +/* + * Copyright (C) 1991, 1992 Linus Torvalds + */ + +#include + +/** + * strncmp - Compare two length-limited strings + * @cs: One string + * @ct: Another string + * @count: The maximum number of bytes to compare + */ +int (strncmp)(const char *cs, const char *ct, size_t count) +{ + register signed char __res = 0; + + while (count) { + if ((__res = *cs - *ct++) != 0 || !*cs++) + break; + count--; + } + + return __res; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 8 + * tab-width: 8 + * indent-tabs-mode: t + * End: + */ From xen-devel-bounces@lists.xenproject.org Thu Apr 01 10:25:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 10:25:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104329.199437 (Exim 4.92) (envelope-from ) id 1lRuVz-0002yS-Cf; Thu, 01 Apr 2021 10:25:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104329.199437; Thu, 01 Apr 2021 10:25:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuVz-0002yK-9a; Thu, 01 Apr 2021 10:25:27 +0000 Received: by outflank-mailman (input) for mailman id 104329; Thu, 01 Apr 2021 10:25:25 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuVx-0002xc-Dv for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 10:25:25 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 036094cf-81b8-4011-b6db-fe890cd78cbc; Thu, 01 Apr 2021 10:25:20 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D8D0EB032; Thu, 1 Apr 2021 10:25:19 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 036094cf-81b8-4011-b6db-fe890cd78cbc X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617272720; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4XwCcLrzETyMlxHJ7JOlZs5KVV79sUmD+2c2kdGaHMA=; b=C2+qIz97TYYRdaJ9CP7uqEwCvbZdml6YmzF5BZWsFZ44auIKOPBkDrUPwA4Yo3E3l0Z1zS yi2W7ZvuhJYTywOlHaCsP8f9vtCkja3IZfjAQgn9gpfHI83sWBkrGslU3hTiuPTO0T8ezt YR/UJJGm5GWHNuW2LQlTWsgVoYkKrLI= Subject: [PATCH 14/23] lib: move strlcpy() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu References: Message-ID: Date: Thu, 1 Apr 2021 12:25:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Signed-off-by: Jan Beulich --- a/xen/common/string.c +++ b/xen/common/string.c @@ -56,32 +56,6 @@ int (strcasecmp)(const char *s1, const c } #endif -#ifndef __HAVE_ARCH_STRLCPY -/** - * strlcpy - Copy a %NUL terminated string into a sized buffer - * @dest: Where to copy the string to - * @src: Where to copy the string from - * @size: size of destination buffer - * - * Compatible with *BSD: the result is always a valid - * NUL-terminated string that fits in the buffer (unless, - * of course, the buffer size is zero). It does not pad - * out the result like strncpy() does. - */ -size_t strlcpy(char *dest, const char *src, size_t size) -{ - size_t ret = strlen(src); - - if (size) { - size_t len = (ret >= size) ? size-1 : ret; - memcpy(dest, src, len); - dest[len] = '\0'; - } - return ret; -} -EXPORT_SYMBOL(strlcpy); -#endif - #ifndef __HAVE_ARCH_STRLCAT /** * strlcat - Append a %NUL terminated string into a sized buffer --- a/xen/lib/Makefile +++ b/xen/lib/Makefile @@ -15,6 +15,7 @@ lib-y += parse-size.o lib-y += rbtree.o lib-y += sort.o lib-y += strcmp.o +lib-y += strlcpy.o lib-y += strlen.o lib-y += strncmp.o lib-y += strnlen.o --- /dev/null +++ b/xen/lib/strlcpy.c @@ -0,0 +1,38 @@ +/* + * Copyright (C) 1991, 1992 Linus Torvalds + */ + +#include + +/** + * strlcpy - Copy a %NUL terminated string into a sized buffer + * @dest: Where to copy the string to + * @src: Where to copy the string from + * @size: size of destination buffer + * + * Compatible with *BSD: the result is always a valid + * NUL-terminated string that fits in the buffer (unless, + * of course, the buffer size is zero). It does not pad + * out the result like strncpy() does. + */ +size_t strlcpy(char *dest, const char *src, size_t size) +{ + size_t ret = strlen(src); + + if (size) { + size_t len = (ret >= size) ? size-1 : ret; + memcpy(dest, src, len); + dest[len] = '\0'; + } + return ret; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 8 + * tab-width: 8 + * indent-tabs-mode: t + * End: + */ From xen-devel-bounces@lists.xenproject.org Thu Apr 01 10:25:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 10:25:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104331.199449 (Exim 4.92) (envelope-from ) id 1lRuWC-00033W-M4; Thu, 01 Apr 2021 10:25:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104331.199449; Thu, 01 Apr 2021 10:25:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuWC-00033O-Ir; Thu, 01 Apr 2021 10:25:40 +0000 Received: by outflank-mailman (input) for mailman id 104331; Thu, 01 Apr 2021 10:25:39 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuWB-000337-PI for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 10:25:39 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 677c0a98-d866-4d9b-8b1c-3e8a1ba29d84; Thu, 01 Apr 2021 10:25:38 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2C59AAE86; Thu, 1 Apr 2021 10:25:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 677c0a98-d866-4d9b-8b1c-3e8a1ba29d84 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617272738; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7zV0Im6IiPxLCpobC1iQxqhPYJiA+5gcc1UKfDC95jE=; b=qIHew1rsKfuK2G8m4BneQjMHSn9siyKtHP3DEuIQq+5oQ1nJmQe+9C7nowdbf14CV0WPRy etbSo5fCeiotdcA1wIInQqazlEfXO1VD0T9Ry7knf37V9+41Dm7TpLxn7KbayQHofmtlsE p46FEbFxVz1EMvN4NvzMZGJH7SMAMQ4= Subject: [PATCH 15/23] lib: move strlcat() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu References: Message-ID: Date: Thu, 1 Apr 2021 12:25:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Signed-off-by: Jan Beulich --- a/xen/common/string.c +++ b/xen/common/string.c @@ -56,35 +56,6 @@ int (strcasecmp)(const char *s1, const c } #endif -#ifndef __HAVE_ARCH_STRLCAT -/** - * strlcat - Append a %NUL terminated string into a sized buffer - * @dest: Where to copy the string to - * @src: Where to copy the string from - * @size: size of destination buffer - * - * Compatible with *BSD: the result is always a valid - * NUL-terminated string that fits in the buffer (unless, - * of course, the buffer size is zero). - */ -size_t strlcat(char *dest, const char *src, size_t size) -{ - size_t slen = strlen(src); - size_t dlen = strnlen(dest, size); - char *p = dest + dlen; - - while ((p - dest) < size) - if ((*p++ = *src++) == '\0') - break; - - if (dlen < size) - *(p-1) = '\0'; - - return slen + dlen; -} -EXPORT_SYMBOL(strlcat); -#endif - #ifndef __HAVE_ARCH_STRCHR /** * strchr - Find the first occurrence of a character in a string --- a/xen/lib/Makefile +++ b/xen/lib/Makefile @@ -15,6 +15,7 @@ lib-y += parse-size.o lib-y += rbtree.o lib-y += sort.o lib-y += strcmp.o +lib-y += strlcat.o lib-y += strlcpy.o lib-y += strlen.o lib-y += strncmp.o --- /dev/null +++ b/xen/lib/strlcat.c @@ -0,0 +1,41 @@ +/* + * Copyright (C) 1991, 1992 Linus Torvalds + */ + +#include + +/** + * strlcat - Append a %NUL terminated string into a sized buffer + * @dest: Where to copy the string to + * @src: Where to copy the string from + * @size: size of destination buffer + * + * Compatible with *BSD: the result is always a valid + * NUL-terminated string that fits in the buffer (unless, + * of course, the buffer size is zero). + */ +size_t strlcat(char *dest, const char *src, size_t size) +{ + size_t slen = strlen(src); + size_t dlen = strnlen(dest, size); + char *p = dest + dlen; + + while ((p - dest) < size) + if ((*p++ = *src++) == '\0') + break; + + if (dlen < size) + *(p-1) = '\0'; + + return slen + dlen; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 8 + * tab-width: 8 + * indent-tabs-mode: t + * End: + */ From xen-devel-bounces@lists.xenproject.org Thu Apr 01 10:26:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 10:26:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104335.199460 (Exim 4.92) (envelope-from ) id 1lRuWa-0003BU-0L; Thu, 01 Apr 2021 10:26:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104335.199460; Thu, 01 Apr 2021 10:26:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuWZ-0003BN-TY; Thu, 01 Apr 2021 10:26:03 +0000 Received: by outflank-mailman (input) for mailman id 104335; Thu, 01 Apr 2021 10:26:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuWY-00039I-FF for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 10:26:02 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 02ab72af-98ca-4dc6-a62f-7c7dc437c736; Thu, 01 Apr 2021 10:25:58 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 525B3AEA6; Thu, 1 Apr 2021 10:25:57 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 02ab72af-98ca-4dc6-a62f-7c7dc437c736 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617272757; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JFsPHBSFCRbpswM140dIBX+K0lYDWe8o/0ZUhNbUxao=; b=sGJ4tbmKIwfb/xiCiCgT6875Pw/IKeNIwYR5si/L2whCsOoKqVFH1PA4xmzr4ohBkZ064U j+3tXw6o3Hyon76EnJ5IIg2TECUlaApHLOhDcMbl+OeKrqdikZDTzZSZfiWgWES9/c4t/T 94hpE5DenHFl9dCJp3cKyAp22WQT8jM= Subject: [PATCH 16/23] lib: move strchr() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu References: Message-ID: Date: Thu, 1 Apr 2021 12:25:56 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Signed-off-by: Jan Beulich --- a/xen/common/string.c +++ b/xen/common/string.c @@ -56,21 +56,6 @@ int (strcasecmp)(const char *s1, const c } #endif -#ifndef __HAVE_ARCH_STRCHR -/** - * strchr - Find the first occurrence of a character in a string - * @s: The string to be searched - * @c: The character to search for - */ -char *(strchr)(const char *s, int c) -{ - for(; *s != (char) c; ++s) - if (*s == '\0') - return NULL; - return (char *) s; -} -#endif - #ifndef __HAVE_ARCH_STRRCHR /** * strrchr - Find the last occurrence of a character in a string --- a/xen/lib/Makefile +++ b/xen/lib/Makefile @@ -14,6 +14,7 @@ lib-y += muldiv64.o lib-y += parse-size.o lib-y += rbtree.o lib-y += sort.o +lib-y += strchr.o lib-y += strcmp.o lib-y += strlcat.o lib-y += strlcpy.o --- /dev/null +++ b/xen/lib/strchr.c @@ -0,0 +1,28 @@ +/* + * Copyright (C) 1991, 1992 Linus Torvalds + */ + +#include + +/** + * strchr - Find the first occurrence of a character in a string + * @s: The string to be searched + * @c: The character to search for + */ +char *(strchr)(const char *s, int c) +{ + for(; *s != (char) c; ++s) + if (*s == '\0') + return NULL; + return (char *) s; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 8 + * tab-width: 8 + * indent-tabs-mode: t + * End: + */ From xen-devel-bounces@lists.xenproject.org Thu Apr 01 10:26:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 10:26:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104337.199473 (Exim 4.92) (envelope-from ) id 1lRuWn-0003Gx-An; Thu, 01 Apr 2021 10:26:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104337.199473; Thu, 01 Apr 2021 10:26:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuWn-0003Gp-6y; Thu, 01 Apr 2021 10:26:17 +0000 Received: by outflank-mailman (input) for mailman id 104337; Thu, 01 Apr 2021 10:26:15 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuWl-0003GV-JZ for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 10:26:15 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8cbf186b-7f8d-4fe7-ba1e-bd29d2d9e1e1; Thu, 01 Apr 2021 10:26:14 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2342DAEA6; Thu, 1 Apr 2021 10:26:14 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8cbf186b-7f8d-4fe7-ba1e-bd29d2d9e1e1 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617272774; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7CQlp/3jZ9dRZw9Vi/DgDQTsQjZRZ6m3Z3hDPiBuKzw=; b=IAa1jhudL+MvVkyP8zM15xMr+PfcQASoedZ1A6T5vVEAsPmx1hxXIgiJxAucDrI8Yv++mO KjPCT+RKtcPfoP+55OZhFppOEYBoA5IFNRTEnsf4kSjpZ4Flo+QGICfOavJ8BbuQPJwUGr 8q0Jf0PyY7n1Jj9XX3hzXpVzYjrsHqo= Subject: [PATCH 17/23] lib: move strrchr() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu References: Message-ID: <078a3947-5c1d-c84e-9f57-ad86ea415ec4@suse.com> Date: Thu, 1 Apr 2021 12:26:13 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Signed-off-by: Jan Beulich --- a/xen/common/string.c +++ b/xen/common/string.c @@ -56,24 +56,6 @@ int (strcasecmp)(const char *s1, const c } #endif -#ifndef __HAVE_ARCH_STRRCHR -/** - * strrchr - Find the last occurrence of a character in a string - * @s: The string to be searched - * @c: The character to search for - */ -char *(strrchr)(const char *s, int c) -{ - const char *p = s + strlen(s); - - for (; *p != (char)c; --p) - if (p == s) - return NULL; - - return (char *)p; -} -#endif - #ifndef __HAVE_ARCH_STRSPN /** * strspn - Calculate the length of the initial substring of @s which only --- a/xen/lib/Makefile +++ b/xen/lib/Makefile @@ -21,6 +21,7 @@ lib-y += strlcpy.o lib-y += strlen.o lib-y += strncmp.o lib-y += strnlen.o +lib-y += strrchr.o lib-$(CONFIG_X86) += xxhash32.o lib-$(CONFIG_X86) += xxhash64.o --- /dev/null +++ b/xen/lib/strrchr.c @@ -0,0 +1,31 @@ +/* + * Copyright (C) 1991, 1992 Linus Torvalds + */ + +#include + +/** + * strrchr - Find the last occurrence of a character in a string + * @s: The string to be searched + * @c: The character to search for + */ +char *(strrchr)(const char *s, int c) +{ + const char *p = s + strlen(s); + + for (; *p != (char)c; --p) + if (p == s) + return NULL; + + return (char *)p; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 8 + * tab-width: 8 + * indent-tabs-mode: t + * End: + */ From xen-devel-bounces@lists.xenproject.org Thu Apr 01 10:26:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 10:26:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104341.199484 (Exim 4.92) (envelope-from ) id 1lRuX8-0003P6-J7; Thu, 01 Apr 2021 10:26:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104341.199484; Thu, 01 Apr 2021 10:26:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuX8-0003Oz-G1; Thu, 01 Apr 2021 10:26:38 +0000 Received: by outflank-mailman (input) for mailman id 104341; Thu, 01 Apr 2021 10:26:36 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuX6-0003Ob-9q for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 10:26:36 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a7d08cfe-1552-42ff-bcc2-153e05ca75a5; Thu, 01 Apr 2021 10:26:35 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B7342AEAE; Thu, 1 Apr 2021 10:26:34 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a7d08cfe-1552-42ff-bcc2-153e05ca75a5 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617272794; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4Z8DfS5OHynFArmQHJ/930SfzIBU1VIyvdrzD+YeXk8=; b=Y0eyErH7fv+/zGHrXkC8sVM7VlNzapc1eFJpkUCvGBbk2xhxC6bGEZpbwoavXDaWa4tSZ8 6mKoZjZWNgY/UJPeSXOpB/iM0CKMoIacWLNSYFKRqcGSL/Wpb1w3gSBKEx4KHw24kUW7Mr k7X1xmXHsbDAGXV4viWVgG3YicHtknI= Subject: [PATCH 18/23] lib: move strstr() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu References: Message-ID: <168ae189-b247-af8f-a351-6e4df7e3c19f@suse.com> Date: Thu, 1 Apr 2021 12:26:34 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Signed-off-by: Jan Beulich --- a/xen/common/string.c +++ b/xen/common/string.c @@ -131,27 +131,6 @@ char * strsep(char **s, const char *ct) } #endif -#ifndef __HAVE_ARCH_STRSTR -/** - * strstr - Find the first substring in a %NUL terminated string - * @s1: The string to be searched - * @s2: The string to search for - */ -char *(strstr)(const char *s1, const char *s2) -{ - size_t l1, l2 = strlen(s2); - - if (!l2) - return (char *)s1; - - for (l1 = strlen(s1); l1 >= l2; --l1, ++s1) - if (!memcmp(s1, s2, l2)) - return (char *)s1; - - return NULL; -} -#endif - /* * Local variables: * mode: C --- a/xen/lib/Makefile +++ b/xen/lib/Makefile @@ -22,6 +22,7 @@ lib-y += strlen.o lib-y += strncmp.o lib-y += strnlen.o lib-y += strrchr.o +lib-y += strstr.o lib-$(CONFIG_X86) += xxhash32.o lib-$(CONFIG_X86) += xxhash64.o --- /dev/null +++ b/xen/lib/strstr.c @@ -0,0 +1,34 @@ +/* + * Copyright (C) 1991, 1992 Linus Torvalds + */ + +#include + +/** + * strstr - Find the first substring in a %NUL terminated string + * @s1: The string to be searched + * @s2: The string to search for + */ +char *(strstr)(const char *s1, const char *s2) +{ + size_t l1, l2 = strlen(s2); + + if (!l2) + return (char *)s1; + + for (l1 = strlen(s1); l1 >= l2; --l1, ++s1) + if (!memcmp(s1, s2, l2)) + return (char *)s1; + + return NULL; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 8 + * tab-width: 8 + * indent-tabs-mode: t + * End: + */ From xen-devel-bounces@lists.xenproject.org Thu Apr 01 10:26:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 10:26:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104343.199497 (Exim 4.92) (envelope-from ) id 1lRuXS-0003X1-T7; Thu, 01 Apr 2021 10:26:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104343.199497; Thu, 01 Apr 2021 10:26:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuXS-0003Wu-PF; Thu, 01 Apr 2021 10:26:58 +0000 Received: by outflank-mailman (input) for mailman id 104343; Thu, 01 Apr 2021 10:26:57 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuXR-0003Wf-Km for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 10:26:57 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 811f562e-6d16-4cd2-afd5-0cf9757c47c1; Thu, 01 Apr 2021 10:26:56 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 27128AED7; Thu, 1 Apr 2021 10:26:56 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 811f562e-6d16-4cd2-afd5-0cf9757c47c1 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617272816; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NxQjcpTUPkL0effw4pmC6gwxzyQLMUQ+vwEPhHr3nYI=; b=fLUGBvAiPxFNk7QC/qrTxuN05bRy5jsHomCamd/VgNaoU6RfxsFxtSV/vhg8yfRNX3YXR0 YoTqU/4KtcwEhBJjnASAVDlMlWJAlK7qaR93dn3xh37UDqFKBu9NRRAclWrOVeWwPLwY6u ZkFEPSvk0EVfDHTC88Maw77ashJn/vo= Subject: [PATCH 19/23] lib: move strcasecmp() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu References: Message-ID: Date: Thu, 1 Apr 2021 12:26:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Signed-off-by: Jan Beulich --- a/xen/common/string.c +++ b/xen/common/string.c @@ -41,21 +41,6 @@ int strnicmp(const char *s1, const char } #endif -#ifndef __HAVE_ARCH_STRCASECMP -int (strcasecmp)(const char *s1, const char *s2) -{ - int c1, c2; - - do - { - c1 = tolower(*s1++); - c2 = tolower(*s2++); - } while ( c1 == c2 && c1 != 0 ); - - return c1 - c2; -} -#endif - #ifndef __HAVE_ARCH_STRSPN /** * strspn - Calculate the length of the initial substring of @s which only --- a/xen/lib/Makefile +++ b/xen/lib/Makefile @@ -14,6 +14,7 @@ lib-y += muldiv64.o lib-y += parse-size.o lib-y += rbtree.o lib-y += sort.o +lib-y += strcasecmp.o lib-y += strchr.o lib-y += strcmp.o lib-y += strlcat.o --- /dev/null +++ b/xen/lib/strcasecmp.c @@ -0,0 +1,29 @@ +/* + * Copyright (C) 1991, 1992 Linus Torvalds + */ + +#include +#include + +int (strcasecmp)(const char *s1, const char *s2) +{ + int c1, c2; + + do + { + c1 = tolower(*s1++); + c2 = tolower(*s2++); + } while ( c1 == c2 && c1 != 0 ); + + return c1 - c2; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 8 + * tab-width: 8 + * indent-tabs-mode: t + * End: + */ From xen-devel-bounces@lists.xenproject.org Thu Apr 01 10:27:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 10:27:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104348.199508 (Exim 4.92) (envelope-from ) id 1lRuXq-0003fA-8n; Thu, 01 Apr 2021 10:27:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104348.199508; Thu, 01 Apr 2021 10:27:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuXq-0003f3-5d; Thu, 01 Apr 2021 10:27:22 +0000 Received: by outflank-mailman (input) for mailman id 104348; Thu, 01 Apr 2021 10:27:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuXo-0003es-OI for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 10:27:20 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1a81a439-b431-45db-9751-ccc66b09c34a; Thu, 01 Apr 2021 10:27:19 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E6FD4AED7; Thu, 1 Apr 2021 10:27:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1a81a439-b431-45db-9751-ccc66b09c34a X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617272839; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SjGtm5W7+Y86JR8RySHNQ6b5vRhziaOW7hdEkR5iKDg=; b=Jc31pHl8aesvIsWE6/VcRkjFdPLqtXGbS6KUplq9842osHVXpo22OVq/8laWFTKEJxRqGT TsqCP1bXFaz4fE3GfJODgxgMi/mCMui0kaDFWwUb1qOvnBIaj/AZo5WAyNwNkWUYgYTScm bAMHYSLcWkRl5Ebb4eis+/PhYSFrmW4= Subject: [PATCH 20/23] lib: move/rename strnicmp() to strncasecmp() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu References: Message-ID: <1db40fc3-df7d-530e-6288-261dbd200e26@suse.com> Date: Thu, 1 Apr 2021 12:27:18 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit While moving the implementation, also rename it to match strcasecmp(), allowing the similar use of a compiler builting in this case as well. Signed-off-by: Jan Beulich --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1223,8 +1223,8 @@ static int __init map_range_to_domain(co * They are not MMIO and therefore a domain should not be able to * manage them via the IOMEM interface. */ - if ( strnicmp(dt_node_full_name(dev), "/reserved-memory/", - strlen("/reserved-memory/")) != 0 ) + if ( strncasecmp(dt_node_full_name(dev), "/reserved-memory/", + strlen("/reserved-memory/")) != 0 ) { res = iomem_permit_access(d, paddr_to_pfn(addr), paddr_to_pfn(PAGE_ALIGN(addr + len - 1))); --- a/xen/common/string.c +++ b/xen/common/string.c @@ -8,39 +8,6 @@ #include #include -#ifndef __HAVE_ARCH_STRNICMP -/** - * strnicmp - Case insensitive, length-limited string comparison - * @s1: One string - * @s2: The other string - * @len: the maximum number of characters to compare - */ -int strnicmp(const char *s1, const char *s2, size_t len) -{ - /* Yes, Virginia, it had better be unsigned */ - unsigned char c1, c2; - - c1 = 0; c2 = 0; - if (len) { - do { - c1 = *s1; c2 = *s2; - s1++; s2++; - if (!c1) - break; - if (!c2) - break; - if (c1 == c2) - continue; - c1 = tolower(c1); - c2 = tolower(c2); - if (c1 != c2) - break; - } while (--len); - } - return (int)c1 - (int)c2; -} -#endif - #ifndef __HAVE_ARCH_STRSPN /** * strspn - Calculate the length of the initial substring of @s which only --- a/xen/drivers/acpi/pmstat.c +++ b/xen/drivers/acpi/pmstat.c @@ -275,14 +275,14 @@ static int get_cpufreq_para(struct xen_s strlcpy(op->u.get_para.scaling_governor, "Unknown", CPUFREQ_NAME_LEN); /* governor specific para */ - if ( !strnicmp(op->u.get_para.scaling_governor, - "userspace", CPUFREQ_NAME_LEN) ) + if ( !strncasecmp(op->u.get_para.scaling_governor, + "userspace", CPUFREQ_NAME_LEN) ) { op->u.get_para.u.userspace.scaling_setspeed = policy->cur; } - if ( !strnicmp(op->u.get_para.scaling_governor, - "ondemand", CPUFREQ_NAME_LEN) ) + if ( !strncasecmp(op->u.get_para.scaling_governor, + "ondemand", CPUFREQ_NAME_LEN) ) { ret = get_cpufreq_ondemand_para( &op->u.get_para.u.ondemand.sampling_rate_max, @@ -350,8 +350,8 @@ static int set_cpufreq_para(struct xen_s { unsigned int freq =op->u.set_para.ctrl_value; - if ( !strnicmp(policy->governor->name, - "userspace", CPUFREQ_NAME_LEN) ) + if ( !strncasecmp(policy->governor->name, + "userspace", CPUFREQ_NAME_LEN) ) ret = write_userspace_scaling_setspeed(op->cpuid, freq); else ret = -EINVAL; @@ -363,8 +363,8 @@ static int set_cpufreq_para(struct xen_s { unsigned int sampling_rate = op->u.set_para.ctrl_value; - if ( !strnicmp(policy->governor->name, - "ondemand", CPUFREQ_NAME_LEN) ) + if ( !strncasecmp(policy->governor->name, + "ondemand", CPUFREQ_NAME_LEN) ) ret = write_ondemand_sampling_rate(sampling_rate); else ret = -EINVAL; @@ -376,8 +376,8 @@ static int set_cpufreq_para(struct xen_s { unsigned int up_threshold = op->u.set_para.ctrl_value; - if ( !strnicmp(policy->governor->name, - "ondemand", CPUFREQ_NAME_LEN) ) + if ( !strncasecmp(policy->governor->name, + "ondemand", CPUFREQ_NAME_LEN) ) ret = write_ondemand_up_threshold(up_threshold); else ret = -EINVAL; --- a/xen/drivers/cpufreq/cpufreq.c +++ b/xen/drivers/cpufreq/cpufreq.c @@ -111,7 +111,7 @@ struct cpufreq_governor *__find_governor return NULL; list_for_each_entry(t, &cpufreq_governor_list, governor_list) - if (!strnicmp(governor, t->name, CPUFREQ_NAME_LEN)) + if (!strncasecmp(governor, t->name, CPUFREQ_NAME_LEN)) return t; return NULL; --- a/xen/include/xen/string.h +++ b/xen/include/xen/string.h @@ -16,8 +16,8 @@ size_t strlcpy(char *, const char *, siz size_t strlcat(char *, const char *, size_t); int strcmp(const char *, const char *); int strncmp(const char *, const char *, size_t); -int strnicmp(const char *, const char *, size_t); int strcasecmp(const char *, const char *); +int strncasecmp(const char *, const char *, size_t); char *strchr(const char *, int); char *strrchr(const char *, int); char *strstr(const char *, const char *); @@ -48,6 +48,10 @@ void *memchr_inv(const void *, int, size #define strcasecmp(s1, s2) __builtin_strcasecmp(s1, s2) #endif +#ifndef __HAVE_ARCH_STRCASECMP +#define strncasecmp(s1, s2, n) __builtin_strncasecmp(s1, s2, n) +#endif + #ifndef __HAVE_ARCH_STRCHR #define strchr(s1, c) __builtin_strchr(s1, c) #endif --- a/xen/lib/Makefile +++ b/xen/lib/Makefile @@ -20,6 +20,7 @@ lib-y += strcmp.o lib-y += strlcat.o lib-y += strlcpy.o lib-y += strlen.o +lib-y += strncasecmp.o lib-y += strncmp.o lib-y += strnlen.o lib-y += strrchr.o --- /dev/null +++ b/xen/lib/strncasecmp.c @@ -0,0 +1,47 @@ +/* + * Copyright (C) 1991, 1992 Linus Torvalds + */ + +#include +#include + +/** + * strncasecmp - Case insensitive, length-limited string comparison + * @s1: One string + * @s2: The other string + * @len: the maximum number of characters to compare + */ +int (strncasecmp)(const char *s1, const char *s2, size_t len) +{ + /* Yes, Virginia, it had better be unsigned */ + unsigned char c1, c2; + + c1 = 0; c2 = 0; + if (len) { + do { + c1 = *s1; c2 = *s2; + s1++; s2++; + if (!c1) + break; + if (!c2) + break; + if (c1 == c2) + continue; + c1 = tolower(c1); + c2 = tolower(c2); + if (c1 != c2) + break; + } while (--len); + } + return (int)c1 - (int)c2; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 8 + * tab-width: 8 + * indent-tabs-mode: t + * End: + */ From xen-devel-bounces@lists.xenproject.org Thu Apr 01 10:27:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 10:27:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104351.199521 (Exim 4.92) (envelope-from ) id 1lRuYF-0003mZ-Hn; Thu, 01 Apr 2021 10:27:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104351.199521; Thu, 01 Apr 2021 10:27:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuYF-0003mS-EK; Thu, 01 Apr 2021 10:27:47 +0000 Received: by outflank-mailman (input) for mailman id 104351; Thu, 01 Apr 2021 10:27:45 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuYD-0003m8-SO for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 10:27:45 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id bd0f8501-bf0b-47ff-b6d4-a846ea0fdb10; Thu, 01 Apr 2021 10:27:45 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4BCDEAED7; Thu, 1 Apr 2021 10:27:44 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bd0f8501-bf0b-47ff-b6d4-a846ea0fdb10 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617272864; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nM+SAR2VDtnfWZt6Cj4esRpAm2vc6rPFnc2zt/YNybg=; b=iG6kGnwhMHT1Ry4Y660ojHxK6QtEzq9Fc/RoUKRR02U4ZgSxTLIftFVWB6qAaEjjoJ061S 1eANE+OCSlJHbbXROPO2rS9FgoDRb72jy4CLIZL28RhWMM2MYjO8h2bUNWfG1D3ulx9GhV SrnuhvFkygUCWSrEEfPYu1eo5kVbkWc= Subject: [PATCH 21/23] lib: move strspn() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu References: Message-ID: <8d5d06fe-7e8b-6275-caa0-bc14c7dbd21f@suse.com> Date: Thu, 1 Apr 2021 12:27:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit In fact the function is unused at present, and hence will now get omitted from the final binaries. Signed-off-by: Jan Beulich --- a/xen/common/string.c +++ b/xen/common/string.c @@ -8,33 +8,6 @@ #include #include -#ifndef __HAVE_ARCH_STRSPN -/** - * strspn - Calculate the length of the initial substring of @s which only - * contain letters in @accept - * @s: The string to be searched - * @accept: The string to search for - */ -size_t strspn(const char *s, const char *accept) -{ - const char *p; - const char *a; - size_t count = 0; - - for (p = s; *p != '\0'; ++p) { - for (a = accept; *a != '\0'; ++a) { - if (*p == *a) - break; - } - if (*a == '\0') - return count; - ++count; - } - - return count; -} -#endif - #ifndef __HAVE_ARCH_STRPBRK /** * strpbrk - Find the first occurrence of a set of characters --- a/xen/lib/Makefile +++ b/xen/lib/Makefile @@ -24,6 +24,7 @@ lib-y += strncasecmp.o lib-y += strncmp.o lib-y += strnlen.o lib-y += strrchr.o +lib-y += strspn.o lib-y += strstr.o lib-$(CONFIG_X86) += xxhash32.o lib-$(CONFIG_X86) += xxhash64.o --- /dev/null +++ b/xen/lib/strspn.c @@ -0,0 +1,40 @@ +/* + * Copyright (C) 1991, 1992 Linus Torvalds + */ + +#include + +/** + * strspn - Calculate the length of the initial substring of @s which only + * contain letters in @accept + * @s: The string to be searched + * @accept: The string to search for + */ +size_t strspn(const char *s, const char *accept) +{ + const char *p; + const char *a; + size_t count = 0; + + for (p = s; *p != '\0'; ++p) { + for (a = accept; *a != '\0'; ++a) { + if (*p == *a) + break; + } + if (*a == '\0') + return count; + ++count; + } + + return count; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 8 + * tab-width: 8 + * indent-tabs-mode: t + * End: + */ From xen-devel-bounces@lists.xenproject.org Thu Apr 01 10:28:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 10:28:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104355.199533 (Exim 4.92) (envelope-from ) id 1lRuYf-0003uB-Qe; Thu, 01 Apr 2021 10:28:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104355.199533; Thu, 01 Apr 2021 10:28:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuYf-0003u4-N3; Thu, 01 Apr 2021 10:28:13 +0000 Received: by outflank-mailman (input) for mailman id 104355; Thu, 01 Apr 2021 10:28:11 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuYd-0003tJ-KD for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 10:28:11 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1478dab0-275f-40ce-b15b-7c79bc5c64d5; Thu, 01 Apr 2021 10:28:06 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2140FAEAE; Thu, 1 Apr 2021 10:28:06 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1478dab0-275f-40ce-b15b-7c79bc5c64d5 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617272886; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TDElynrA860OZeILtOTuJZZOjvaOuLrkyPrL9SlIZ48=; b=ih/DV0qn6PP0h4TaCI//rSw68v1Ey73GM+SKB8rNMyrkhGldQClNBDWKqERbdB7Vmyq9G1 KHw3dSAn+zrM2oiT/Vmj7HD/WYP7+tbgZowuwOMR1uvw39ZoIN42weLROytxkY1Pwc5Jt4 U8CZ/H72u8RQlA+qtMu9j2q/vO+vKyE= Subject: [PATCH 22/23] lib: move strpbrk() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu References: Message-ID: <8a492d52-7c2b-f926-9ba2-8e57ec0bbc97@suse.com> Date: Thu, 1 Apr 2021 12:28:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Signed-off-by: Jan Beulich --- a/xen/common/string.c +++ b/xen/common/string.c @@ -8,26 +8,6 @@ #include #include -#ifndef __HAVE_ARCH_STRPBRK -/** - * strpbrk - Find the first occurrence of a set of characters - * @cs: The string to be searched - * @ct: The characters to search for - */ -char * strpbrk(const char * cs,const char * ct) -{ - const char *sc1,*sc2; - - for( sc1 = cs; *sc1 != '\0'; ++sc1) { - for( sc2 = ct; *sc2 != '\0'; ++sc2) { - if (*sc1 == *sc2) - return (char *) sc1; - } - } - return NULL; -} -#endif - #ifndef __HAVE_ARCH_STRSEP /** * strsep - Split a string into tokens --- a/xen/lib/Makefile +++ b/xen/lib/Makefile @@ -23,6 +23,7 @@ lib-y += strlen.o lib-y += strncasecmp.o lib-y += strncmp.o lib-y += strnlen.o +lib-y += strpbrk.o lib-y += strrchr.o lib-y += strspn.o lib-y += strstr.o --- /dev/null +++ b/xen/lib/strpbrk.c @@ -0,0 +1,33 @@ +/* + * Copyright (C) 1991, 1992 Linus Torvalds + */ + +#include + +/** + * strpbrk - Find the first occurrence of a set of characters + * @cs: The string to be searched + * @ct: The characters to search for + */ +char *strpbrk(const char * cs,const char * ct) +{ + const char *sc1,*sc2; + + for( sc1 = cs; *sc1 != '\0'; ++sc1) { + for( sc2 = ct; *sc2 != '\0'; ++sc2) { + if (*sc1 == *sc2) + return (char *) sc1; + } + } + return NULL; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 8 + * tab-width: 8 + * indent-tabs-mode: t + * End: + */ From xen-devel-bounces@lists.xenproject.org Thu Apr 01 10:28:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 10:28:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104357.199545 (Exim 4.92) (envelope-from ) id 1lRuYu-0003zX-2w; Thu, 01 Apr 2021 10:28:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104357.199545; Thu, 01 Apr 2021 10:28:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuYt-0003zP-Vy; Thu, 01 Apr 2021 10:28:27 +0000 Received: by outflank-mailman (input) for mailman id 104357; Thu, 01 Apr 2021 10:28:27 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuYt-0003zD-FY for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 10:28:27 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d0afee1c-02a0-4d9d-9fb5-3fadceb45989; Thu, 01 Apr 2021 10:28:26 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id EF251AEAE; Thu, 1 Apr 2021 10:28:25 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d0afee1c-02a0-4d9d-9fb5-3fadceb45989 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617272906; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VvuuIHZDWbgJZbFTLmgAhc0Yr8Pw5QBP9Pn9CAur/LY=; b=ibt83e9cmBXcUUMeBS1l43oM1LDzCCnKqbQOTfC44+CqoRMy3pfwOBKX2++V1GWDfjjoSU 0f/Crb8UOD60/rmt1mdnAl6aai7z3jWlVTyq7sbrbV5q/bTaStnMTION02VMAuVM5zVgww RiDOucE/r7K9rehJxWeAjg/Jgg4T7hg= Subject: [PATCH 23/23] lib: move strsep() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu References: Message-ID: <692a24a5-c7a1-b6cc-b618-a620432a030d@suse.com> Date: Thu, 1 Apr 2021 12:28:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Signed-off-by: Jan Beulich --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -40,7 +40,6 @@ obj-y += softirq.o obj-y += smp.o obj-y += spinlock.o obj-y += stop_machine.o -obj-y += string.o obj-y += symbols.o obj-y += tasklet.o obj-y += time.o --- a/xen/common/string.c +++ /dev/null @@ -1,47 +0,0 @@ -/* - * linux/lib/string.c - * - * Copyright (C) 1991, 1992 Linus Torvalds - */ - -#include -#include -#include - -#ifndef __HAVE_ARCH_STRSEP -/** - * strsep - Split a string into tokens - * @s: The string to be searched - * @ct: The characters to search for - * - * strsep() updates @s to point after the token, ready for the next call. - * - * It returns empty tokens, too, behaving exactly like the libc function - * of that name. In fact, it was stolen from glibc2 and de-fancy-fied. - * Same semantics, slimmer shape. ;) - */ -char * strsep(char **s, const char *ct) -{ - char *sbegin = *s, *end; - - if (sbegin == NULL) - return NULL; - - end = strpbrk(sbegin, ct); - if (end) - *end++ = '\0'; - *s = end; - - return sbegin; -} -#endif - -/* - * Local variables: - * mode: C - * c-file-style: "BSD" - * c-basic-offset: 8 - * tab-width: 8 - * indent-tabs-mode: t - * End: - */ --- a/xen/lib/Makefile +++ b/xen/lib/Makefile @@ -25,6 +25,7 @@ lib-y += strncmp.o lib-y += strnlen.o lib-y += strpbrk.o lib-y += strrchr.o +lib-y += strsep.o lib-y += strspn.o lib-y += strstr.o lib-$(CONFIG_X86) += xxhash32.o --- /dev/null +++ b/xen/lib/strsep.c @@ -0,0 +1,41 @@ +/* + * Copyright (C) 1991, 1992 Linus Torvalds + */ + +#include + +/** + * strsep - Split a string into tokens + * @s: The string to be searched + * @ct: The characters to search for + * + * strsep() updates @s to point after the token, ready for the next call. + * + * It returns empty tokens, too, behaving exactly like the libc function + * of that name. In fact, it was stolen from glibc2 and de-fancy-fied. + * Same semantics, slimmer shape. ;) + */ +char *strsep(char **s, const char *ct) +{ + char *sbegin = *s, *end; + + if (sbegin == NULL) + return NULL; + + end = strpbrk(sbegin, ct); + if (end) + *end++ = '\0'; + *s = end; + + return sbegin; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 8 + * tab-width: 8 + * indent-tabs-mode: t + * End: + */ From xen-devel-bounces@lists.xenproject.org Thu Apr 01 10:50:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 10:50:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104368.199584 (Exim 4.92) (envelope-from ) id 1lRuuM-0006ph-6k; Thu, 01 Apr 2021 10:50:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104368.199584; Thu, 01 Apr 2021 10:50:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuuM-0006pa-3f; Thu, 01 Apr 2021 10:50:38 +0000 Received: by outflank-mailman (input) for mailman id 104368; Thu, 01 Apr 2021 10:50:36 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuuK-0006pU-Sb for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 10:50:36 +0000 Received: from mail-wr1-x436.google.com (unknown [2a00:1450:4864:20::436]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a00ff4ec-30ad-4c64-abcc-476bd3997a1d; Thu, 01 Apr 2021 10:50:35 +0000 (UTC) Received: by mail-wr1-x436.google.com with SMTP id j7so1365592wrd.1 for ; Thu, 01 Apr 2021 03:50:35 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:ac48:6475:41e4:208d? ([2a00:23c5:5785:9a01:ac48:6475:41e4:208d]) by smtp.gmail.com with ESMTPSA id m15sm8657504wrp.96.2021.04.01.03.50.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Apr 2021 03:50:34 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a00ff4ec-30ad-4c64-abcc-476bd3997a1d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=eeBlpa+LPXFDtgiKt0qcvo3MEbkWu2S5Fp2G4dTK3bE=; b=M1fvt9nISqei9ClE+PVnLbB1A3UW3N+v56I1RKzh0fgFdwhqjVuWJK3ZJ7yaFuDSkV lMtKg3/ojc9nUKwAauLZ0ahGUjWn2VPmwSfUR27NDQjLHghvMq4DYjHOm0uTw5Y8lwtD c1lmahjAhWQV8ImclMeuhsTvN2R/XqMrd7Bz/5u74nDkDagAWMUuZ5StcSAFdQ0gaYd9 R4aWrL35UjXHmady3jIa20q2cSD7qdzaVwrWcVJWOZp78v4mPIIgIMGVuT7SeCYuVOyf GRZBjgKBOPTVnFwZx7wJgwPGUJAIQY4jo94h8OyuNVrxGRMb06yJtT96H26CRkCEexe4 eLxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:cc:references :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=eeBlpa+LPXFDtgiKt0qcvo3MEbkWu2S5Fp2G4dTK3bE=; b=ja1AAooFriorlzkhnyM20IKG4oEU7cQOXPsrrC/e2BoMnt6nKdVTRvZzUi+m/21oEF uaWsnMnXm68dNaLXwTfL/xahPi6VgOpPFmiIiD/RgEH0+Eghx1Nt8jYYb8maU0sChqsD 9eGB4EsDFtg+/alFBVf9mXEpop0k19YDLjjypUHsswMa+Yr/ocPSRe3lxRd4TdKrD6XQ AnB1BJPDAn1PD4FHFMmG1Mu5C6TJpUD81fS0ulMtXRMYh3OL9KrXZORIWDSP+IqG8i3V EHNEyyHrDRjDVPs3llURD3sAPVV/EjxMPaD5uPIHvyLZAqqtjcf53bcfS6MSHxBas5gY Hnlg== X-Gm-Message-State: AOAM530fe3boThEUJNcwcsTL2oo4ytH3MWpKF6Leum0sAbjel0/tBe5S ujWixP3dpMsXo2V1yd76Qqs= X-Google-Smtp-Source: ABdhPJxKjBpsWIoE8kgY6W/qb93RgeBkNXANnBUQIcKVN3959hT1QD7XJx/JlM8K0ctLox3n2LLqtw== X-Received: by 2002:adf:f010:: with SMTP id j16mr9177774wro.251.1617274235115; Thu, 01 Apr 2021 03:50:35 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH] x86/viridian: EOI MSR should always happen in affected vCPU context To: Roger Pau Monne , xen-devel@lists.xenproject.org Cc: Wei Liu , Jan Beulich , Andrew Cooper References: <20210401102252.95196-1-roger.pau@citrix.com> Message-ID: <5b4ec824-8cfa-8795-3a96-fb18527d3c18@xen.org> Date: Thu, 1 Apr 2021 11:50:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210401102252.95196-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 01/04/2021 11:22, Roger Pau Monne wrote: > The HV_X64_MSR_EOI wrmsr should always happen with the target vCPU > as current, as there's no support for EOI'ing interrupts on a remote > vCPU. > > While there also turn the unconditional assert at the top of the > function into an error on non-debug builds. > > No functional change intended. > > Requested-by: Jan Beulich > Signed-off-by: Roger Pau Monné Reviewed-by: Paul Durrant > --- > xen/arch/x86/hvm/viridian/synic.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/x86/hvm/viridian/synic.c b/xen/arch/x86/hvm/viridian/synic.c > index 22e2df27e5d..e18538c60a6 100644 > --- a/xen/arch/x86/hvm/viridian/synic.c > +++ b/xen/arch/x86/hvm/viridian/synic.c > @@ -79,11 +79,20 @@ int viridian_synic_wrmsr(struct vcpu *v, uint32_t idx, uint64_t val) > struct viridian_vcpu *vv = v->arch.hvm.viridian; > struct domain *d = v->domain; > > - ASSERT(v == current || !v->is_running); > + if ( v != current && v->is_running ) > + { > + ASSERT_UNREACHABLE(); > + return X86EMUL_EXCEPTION; > + } > > switch ( idx ) > { > case HV_X64_MSR_EOI: > + if ( v != current ) > + { > + ASSERT_UNREACHABLE(); > + return X86EMUL_EXCEPTION; > + } > vlapic_EOI_set(vcpu_vlapic(v)); > break; > > From xen-devel-bounces@lists.xenproject.org Thu Apr 01 10:55:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 10:55:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104371.199597 (Exim 4.92) (envelope-from ) id 1lRuyp-000739-Pl; Thu, 01 Apr 2021 10:55:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104371.199597; Thu, 01 Apr 2021 10:55:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuyp-000732-M6; Thu, 01 Apr 2021 10:55:15 +0000 Received: by outflank-mailman (input) for mailman id 104371; Thu, 01 Apr 2021 10:55:14 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRuyo-00072x-2G for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 10:55:14 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 382cc294-1cbb-469d-825a-63f79450266c; Thu, 01 Apr 2021 10:55:12 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id BBA78AF1F; Thu, 1 Apr 2021 10:55:11 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 382cc294-1cbb-469d-825a-63f79450266c X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617274511; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6FuAGQnGmOZNlSaQzzz/Ce4FNkqpr4tvjcpEDuNr6/A=; b=kSlqY0Md4l4/o8If/01DMSOVN1z9snbhCVeJI7MMiSyNt/+dq0Rc2k8r1t+mGVEJRsnfqn FXMpzviQ6GTMwu6IY8xeMY9mBY0b/q3kHWJflAg5A09DBI2pXgl0OonJf7wo5dzhHuLD7p ezT6OsjlMDnhbf+jbc7Bdf4lO02/wEo= Subject: Re: [PATCH] x86/viridian: EOI MSR should always happen in affected vCPU context To: Roger Pau Monne Cc: Paul Durrant , Wei Liu , Andrew Cooper , xen-devel@lists.xenproject.org References: <20210401102252.95196-1-roger.pau@citrix.com> From: Jan Beulich Message-ID: Date: Thu, 1 Apr 2021 12:55:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210401102252.95196-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 01.04.2021 12:22, Roger Pau Monne wrote: > The HV_X64_MSR_EOI wrmsr should always happen with the target vCPU > as current, as there's no support for EOI'ing interrupts on a remote > vCPU. > > While there also turn the unconditional assert at the top of the > function into an error on non-debug builds. > > No functional change intended. > > Requested-by: Jan Beulich > Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich > --- a/xen/arch/x86/hvm/viridian/synic.c > +++ b/xen/arch/x86/hvm/viridian/synic.c > @@ -79,11 +79,20 @@ int viridian_synic_wrmsr(struct vcpu *v, uint32_t idx, uint64_t val) > struct viridian_vcpu *vv = v->arch.hvm.viridian; > struct domain *d = v->domain; > > - ASSERT(v == current || !v->is_running); > + if ( v != current && v->is_running ) > + { > + ASSERT_UNREACHABLE(); > + return X86EMUL_EXCEPTION; > + } > > switch ( idx ) > { > case HV_X64_MSR_EOI: > + if ( v != current ) > + { > + ASSERT_UNREACHABLE(); > + return X86EMUL_EXCEPTION; > + } > vlapic_EOI_set(vcpu_vlapic(v)); I suppose this function then also wants to lose its parameter. But I'll reply to patch 1 of the other series again as well. Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 01 11:06:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 11:06:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104377.199611 (Exim 4.92) (envelope-from ) id 1lRv9r-00084G-1b; Thu, 01 Apr 2021 11:06:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104377.199611; Thu, 01 Apr 2021 11:06:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRv9q-000849-Uk; Thu, 01 Apr 2021 11:06:38 +0000 Received: by outflank-mailman (input) for mailman id 104377; Thu, 01 Apr 2021 11:06:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRv9q-000844-56 for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 11:06:38 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d67fbdd7-89df-4ba2-b74e-6009903a086d; Thu, 01 Apr 2021 11:06:37 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 69583B1AC; Thu, 1 Apr 2021 11:06:36 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d67fbdd7-89df-4ba2-b74e-6009903a086d X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617275196; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u4iJHiMsZFzlQ/O/sp9kJ/RKkMMBzbfE+6qQl6oYlL8=; b=qdhFoe1p0uU+/cHTU0qFJopNBaVx3lIuzWUwhqEmGC+WglDOHkqHcEpsh35IE4Qp2aVIT1 1OhMDnO2iLvGG5RCsvlldkE/BjtmTdxCaAYu1XJLa3QbB/6AhkPDzMKFG1rl0TEyqOYc5p hm4rR1sVpOLnstsSvgi2GJdCb9rlxi8= Subject: Re: [PATCH v3 01/11] x86/hvm: drop vcpu parameter from vlapic EOI callbacks To: Roger Pau Monne Cc: Andrew Cooper , Wei Liu , Paul Durrant , Paul Durrant , xen-devel@lists.xenproject.org References: <20210331103303.79705-1-roger.pau@citrix.com> <20210331103303.79705-2-roger.pau@citrix.com> From: Jan Beulich Message-ID: <008d8d8c-f932-c3f3-e06d-99aa6721a59f@suse.com> Date: Thu, 1 Apr 2021 13:06:35 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210331103303.79705-2-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 31.03.2021 12:32, Roger Pau Monne wrote: > EOIs are always executed in guest vCPU context, so there's no reason to > pass a vCPU parameter around as can be fetched from current. While not overly problematic, I'd like to point out that there's not a single vcpu parameter being dropped here - in both cases it's struct domain *. > --- a/xen/arch/x86/hvm/vlapic.c > +++ b/xen/arch/x86/hvm/vlapic.c > @@ -459,13 +459,10 @@ void vlapic_EOI_set(struct vlapic *vlapic) > > void vlapic_handle_EOI(struct vlapic *vlapic, u8 vector) > { > - struct vcpu *v = vlapic_vcpu(vlapic); > - struct domain *d = v->domain; > - > if ( vlapic_test_vector(vector, &vlapic->regs->data[APIC_TMR]) ) > - vioapic_update_EOI(d, vector); > + vioapic_update_EOI(vector); > > - hvm_dpci_msi_eoi(d, vector); > + hvm_dpci_msi_eoi(vector); > } The Viridian path pointed out before was only an example. I'm afraid the call from vlapic_has_pending_irq() to vlapic_EOI_set() is also far from obvious that it always has "v == current". What we end up with here is a mix of passed in value (vlapic) and assumption of the call being for the vCPU / domain we're running on. At the very least I think this would want documenting here in some way (maybe ASSERT(), definitely mentioning in the description), but even better would perhaps be if the parameter of the function here as well as further ones involved would also be dropped then. Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 01 11:22:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 11:22:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104381.199626 (Exim 4.92) (envelope-from ) id 1lRvOz-0001Pk-AN; Thu, 01 Apr 2021 11:22:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104381.199626; Thu, 01 Apr 2021 11:22:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRvOz-0001Pd-7U; Thu, 01 Apr 2021 11:22:17 +0000 Received: by outflank-mailman (input) for mailman id 104381; Thu, 01 Apr 2021 11:22:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRvOy-0001PY-9L for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 11:22:16 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3b080904-f558-4b1e-b573-df4b48063e9a; Thu, 01 Apr 2021 11:22:14 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b080904-f558-4b1e-b573-df4b48063e9a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617276134; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=LGh3DD7gLPUnzQejmmgzvkBX3QsisjgN8KoXuZurEcA=; b=Ro+oGmZFS5D39AgXiD9kBLQcimK45712P+G45N/C++QcZC8Qz0gdgiie a5LpOhNvKuJZodUJOnaSMYKakRXLfwGYslUO9GdW+zQova1LJhFtq9n+v y4x/vrAyNxVmF3qxIDFgL+RKBH3DiwPD8EM+1GdiZzceXu9psdRiSIqLz E=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: WKkRGSlnfElOu1aBUu5IHveLyYJt2jwzLc4+qdwKPtR028rKFpTleEoyzCy4WX8eppJHVKCFKE m0sCYspzl1YAtNe01cjzHt2TNnqDJx8/wcvvLaD+46tcfjA36dbQ7zqTLG/0kUftgk8HchwU+f GuypLwt45RxREaOvmjplzhR3skhxcJCIwajjHe5xoB4FmZ2r4RPQfTK0OY6FfiouWmAnAdeH2F yWk48Dn5gPilb1pAoAYmAJYqkaVNaCh6H1sxjMD28OhfimAvsEK7dESnCvZ8ujpW0R7BUhq5M9 18o= X-SBRS: 5.2 X-MesageID: 41060203 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:tXhx66x48NM+CQH10lH0KrPx/uskLtp033Aq2lEZdDV8btGYm8 eynP4SyB/zj3IrVGs9nM2bUZPsfVr3//dOgbU5F7GkQQXgpS+UPJhvhLGSpwHINg/f0qpm1a lme7VjE9GYNzJHpOvz/QXQKbkd6fad9qTAv4nj5lNMaS0vVK169Qd+DW+gYyhLbS1LH4AwGp bZxucvnUvCRV0tYs62BmYIUoH4zrWmqLvcbQMbHBli0QGSjFqTg4LSKQSS3RsVTlp0sNUf2F XC+jaZ2oyT98uV5zWZ/G/V4pRQlrLau6Z+Lf3JsOc5AHHBjg6pYa5oRrGNuiskydvflGoCoZ 33jDoLe+h19nPNbkG5yCGdpDXI4XIVxFLJjX+enHf5rsTySFsBerR8rLMcSDT1wQ4EnrhHoc V29lPcjbV7J1f8uR64wN7yWxRjhiOP0AEfuN9WtVNze88jcrNLxLZvmn99IdM7Mw/RzpsoK+ VqBNG03octTXqqK0rUuWRi27WXLw0ONybDRkADv/qc2CRNkEZ4yFMFxNcekm1ozuNEd6V5 X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="41060203" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C9h7pw2zNbAsz/CdRPAjpmCfRK5K9FCdODfDVCLVphBM6N9jCCiqOcRxVoOdg/fa4Z+aRsoGYjowE/85mVgTs8T6/2DCFCFJpdWOikQhhOa5aEvjoBjl8p5uS9Wg0sTabwWh6uEWP+u6xFrsZCV+4pixssU+kslON0lAeiD1UaqzNDSUgr7pqB8PRTK6AbPfqP58hX32VKWqcEKQ/6CB0EgIBzV7frAqC2att3n5hN0sq1jZbpCjB/R6EbfEQWD9CGvjXwx4UCCRmqpOjQtGVJxI/n5GoUNETO84hOMrWe3m+NkRRY5OeMfGVO9QpQUyd/sGI81nIs/SWvEhTecRnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LGh3DD7gLPUnzQejmmgzvkBX3QsisjgN8KoXuZurEcA=; b=Q1LSSeRxrd/6+iKa5iVBGgpPJUAuM8ud+l7W3hWPH+ZvAXG1qme3p+uBx4k4/mB6rMXMgp0nt3VEI+ZubfJggsA0o1R2ZkBAl7zNIaqVjpYXJrmPuo78JS6z20N3UgL/oGyBXze28xDczeoRImjGsNHml+9qP+p7/GKYhSh4z3cxJbBDKawA+CGjz6S5CcHEGL4GcM4WlwHyXAkv56ocQ/JdcsonO3x1n6f5Onh8x0F3IxocdGUfMK+TqRzho6GTM2IJuPyzk5P3G5d1gh+m0v9PwA44A7R8AOCmz5XhqjL4cgaKJptSRcnl29g7X3SmXsWaFxUL0oyahTkSDNZv4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LGh3DD7gLPUnzQejmmgzvkBX3QsisjgN8KoXuZurEcA=; b=JnIC6n+Oe5pqsIErywgNLHBbNMMtWf5mks+oCL1CLSDKwqy7kWKJuhFMBPeShU0TbYkOf/GA/GyQx5TS255LY0iGzvOfsVZE2DwanO+jqC6PprNef6aV0mC7Q147eES08Htdq7d961lfZxlzGz9TEHVhLRVDsalvgmmskXCailU= To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: From: Andrew Cooper Subject: Re: [PATCH] x86/ucode: log blob date also for AMD Message-ID: Date: Thu, 1 Apr 2021 12:22:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0268.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:194::21) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3621977b-01dd-4342-1d50-08d8f50063cf X-MS-TrafficTypeDiagnostic: BN6PR03MB2769: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /FlB4fnuzrBtZv0d4/xOt5SHzNV+lPkr8Cb17QyyyX0saf95rt9dA7JGsBHU/HRq1rgRXWN+GnFnBjlMsmYOEsdyWz62NptIKm6xoA19i8tW21nC0iQ+WqeL5XmvYmhbw1D+YA8cMtRmhkwtioWAcjUkpXoIP7v3nU4NIbwr0u2tgMSGHVM+QZgWwhLw/VtKX24GdYgQwDp89sOzqOFJixC7KV+9UDlPRO9JXNEOwp74Nz1fpRtMx6Xjsb4OldbYUyHbOZfnsM4uehPlBU9nqA5JSwQVGXVPlJPLsgGtHywpqu4aR5eot6pPiGrwSPNEopkU2G4wFS2Hd7/wklleKZHtOvGPjGSNZ+h8LEs8A7m+SqNY9CeBEkI/oBts+HbVDVd3oIlB4sLocmIxnl6Htzr6Z03bG4yxtWyRCEQ8pU2tWcs7uyKm47sLkRxkpfa3mtJLGEQHIus3LVf6a+3Yhu4vEWMeCO3lyg8W7Fayx2dU9obsDieE2cmo7GmpViZWxRwW2tn1aq/+9c+qhtwFItjJI7D///KezCku+lBngc3gVtltgtzxCSk1G4CdPjY2c21oM+YmH8+HWv+ImCihtR8N6zhIkwbTT2zWMQZFTgUFZyOis8ZyCFHpLSC788YAOpLhfuF/Pd6ARy/R2sX4ezbTRwguKAMaDM8XiM5/q9zAZozqcnLCCT3+BIXn/8OFhqwqyKA9NdP/t8UNiyzahLvHhO3qn8Ew1zLUQDk0hTM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(396003)(136003)(39860400002)(366004)(53546011)(36756003)(956004)(107886003)(4326008)(66476007)(66556008)(38100700001)(6666004)(83380400001)(26005)(16526019)(186003)(66946007)(31696002)(86362001)(4744005)(2906002)(2616005)(54906003)(110136005)(16576012)(5660300002)(316002)(478600001)(8676002)(8936002)(31686004)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?UWppZngxRnlyOGl0Ym9NV2RRSURLeTIxZmE1c0UrRjRUWG9MRURUaGFOaEt6?= =?utf-8?B?RUJwVWpzc3JYVWd0OGZnYThDeUs4QkFFWFlCTDZFbXBrWTd0QU5ybVM5ZEs0?= =?utf-8?B?VzZoZlBoem1qU0gvODhIZ1dEbUUzOFFQdkJYdkhlNWVpSU9ReEl1U0pNS25s?= =?utf-8?B?bzZKRTJYaFhnY1pGTWdJQkdVTWZaZHhHcHZQMDE4bm9FVTBLMWZjUjBOZGRU?= =?utf-8?B?SDJ3SktQeitkamVWZmczUTFSSnpKK2czQXlrWG1tSEUwWXRoRjcyWUY5eisv?= =?utf-8?B?Tm01MGk5MUcxTStyTzlBc0o4SU1WaXBkNXMvY3AyRU9ZdFJFQW5tR2VUWEY2?= =?utf-8?B?RkxMQW02R0FTQkhYMFZOeXFHQk1haVh5dEhoN3M3NWErRFErMmpqRDVQREpu?= =?utf-8?B?ejZVY2Z6cDRoVTlFQ0wvZWc4d01rUW9oSndjenVINWZLM1NhTW0zOWhoUktz?= =?utf-8?B?VVdOZTl5Yk5GOFlNaktETHpxM09VZTluNUI2NFhvTjQ5R3RDNTNwaG1rNGpQ?= =?utf-8?B?YmI1Z25GYkt3Wmp1TTJvVXdpYjBhT2lKNDZjVzZqYTRVMlNYRUtDaHZJb0Zm?= =?utf-8?B?UzRoNno2Y0Nqakw2ZHBwWjVENmpsNmNrcjdvTnZjYkxpc2U0NHBlVlU0bldK?= =?utf-8?B?VnFBQ1VEWm5Dait5TUxzQysvQk5tN0RjeTg5bktEbWtsSCs5M3hkY1B6eE52?= =?utf-8?B?K1l0Tnl3aW9peGpvWkU1K1BuSnRCRjZ6bDlTZHlYTkowenAvVElrL0hiUEEx?= =?utf-8?B?NDZIbCs5eWVacnZKcjcxNUZUNmVXdUtIQUNPcldFdHJGdzJFOW10Q3JLVE1H?= =?utf-8?B?OXM1MWJVNWY3NXdkelpyY0MvRXdxZlg2UFAvOGc4LzExT09ia0dhV1pNc3RP?= =?utf-8?B?MmhtdWlxRFdQZFRKSXcxUzRIcSsrMmNxVjU0OW9BVjhKVnR5VHNkRzJXVllp?= =?utf-8?B?am1UVld2YnNwd3JidVpWWGUyYlY2ZERzamJvcnRXSGhWeW05VE9JNTNxWWIy?= =?utf-8?B?cDlOa0R6R3l5dVExMjM3ZDBMTzkrSjdQR25iYlc4SDl4TzFZYjh6M3gyT3Zl?= =?utf-8?B?V1djNTgvY1hoaTA2QUt1bGNVVnpSK3RGYVl4eUV0WWZUSm5oM2diZjFBeTVz?= =?utf-8?B?YThQdlN4U2M2WmkzaHRzUU9WbElob0VEcnhHMW8raHplVzNlVlJCZGthQ0g0?= =?utf-8?B?VWV1WjVBTXl4OEt6amJPdDEyNUE4OGxnY1JseGVuM05DZml5MGI1YVliWHdF?= =?utf-8?B?M2R1SzBiTmJqOXpwdkpOV09pQytFYU5BbllsckJtMkFoMjVuZzlWN2F3ZE5P?= =?utf-8?B?b3NVcm15djk3aXdtQWJFV2hMMDBWUzF2M0haalNWZFJ1WEovakZTQWdmVFIw?= =?utf-8?B?NW55Y1lqUzdBM1VvaDdWTFMzUmZCR0E5d0xRNVJNOEFheEMwZ0VzZlZFNHY1?= =?utf-8?B?S1VlYkF1OU1WcTM0ZU9TNkkyVWk1VUtJMVZ6NkhaTEZNZFdkY1QyNmFZaHRE?= =?utf-8?B?VVJXTVJYeGt0K1hFWmwxejRzdTZPRUlWM1RVT2Fmai82MTRTZERYSE5yTXJS?= =?utf-8?B?bVRZTERncXVGUE5jT0Z3blo0VFhjdytoQW1HRENpdUJ4WnBuajk3cjRiWDEv?= =?utf-8?B?NktTclhiUzJpcUNJY1B5eVNic2xxalljOVV6bjFqOGcvbi9XclZKMVAxRVZE?= =?utf-8?B?RXVHS3ZlZHUwd09wdGJraVBsb2IrNEJnayttSnFRQ282dnlZdjY4UUt5RnBh?= =?utf-8?Q?ttY7r+4f4NVOBMenkkOWFvaEdUL/zr0PE1cEf1V?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3621977b-01dd-4342-1d50-08d8f50063cf X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 11:22:09.8017 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0WbkVD42CzCAkWpqx2iD3JQOnqhZXA25c8Oy+4P/6xszB3XMGQK5v1H4U0NMIkkqi2l1fCjGn2GlK7XDGDd6TwQ9mnmVXf9LSvstXsJ6lEk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2769 X-OriginatorOrg: citrix.com On 01/04/2021 09:28, Jan Beulich wrote: > Like Intel, AMD also records the date in their blobs. The field was > merely misnamed as "data_code" so far; this was perhaps meant to be > "date_code". Split it into individual fields, just like we did for Intel > some time ago, and extend the message logged after a successful update. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper This was on my todo list, but I'd not got around to it yet.=C2=A0 There are several legitimate microcode blobs with incorrect dates. One has a date with a year earlier than its predecessor or successor, and two have day/month transpositions.=C2=A0 One transposition is obvious, having a 13 in it, while the other is ambiguous and guessed based on when the ucode was available. I wasn't going to bother doing anything about this, but it is something to be aware of if we get queries of wonky looking dates. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 01 11:33:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 11:33:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104384.199639 (Exim 4.92) (envelope-from ) id 1lRvZx-0002NZ-DB; Thu, 01 Apr 2021 11:33:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104384.199639; Thu, 01 Apr 2021 11:33:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRvZx-0002NS-A7; Thu, 01 Apr 2021 11:33:37 +0000 Received: by outflank-mailman (input) for mailman id 104384; Thu, 01 Apr 2021 11:33:36 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRvZw-0002NN-1H for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 11:33:36 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 81af3c79-b175-4bf5-8366-e0d5e750fdd1; Thu, 01 Apr 2021 11:33:34 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 81af3c79-b175-4bf5-8366-e0d5e750fdd1 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617276814; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=E9Bof/P9ivmijchbbNvr/d9Cs/Off1vuyFeRE3O+sMA=; b=H5zGFaPIB/enyJPrfTznVuNR31zuV6BcJatqolZDKBXuRjZ1k8XHPXpk NySOsFSBHKEcPeblKkbrUdWIhoJvy7oi6l9z5UF2m2Z7ORoyWSvRlqLkb EXdGWXgKDuwG428NSN7c4h4rqtFggbOclUobLliqjaQlo9SFJLuOpFBVA U=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: mscDtZEnalcGFKjeO3s1M7QK4wXEs7csF7O+08OM4S+MKx+ncWMFBEEGK7HKRfJJk63XeezxWt E+1oJbpKq17Okm3ud59Bi/21n89uvusUKl1gmZHehHD2MMvqBoBIzvjtsQJ/rDIcUEjsUk6zLv go1ScoVfRL88Iss57AhIU48ybLwHiMV8j+vwxZ0G8KmExkuR/vD5TBTQt1pXS0V2w0gxmN3LCR Xro8b+GqkbNxfPaOIeJSODhZL1rvKpzFhO9vne1Z3yCLIpTW4X1LUL3mqt1LUT3hyTkO7dJnrw hrw= X-SBRS: 5.2 X-MesageID: 40821259 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:KUE5rawHTCXz65q03Me9KrPxg+4kLtp033Aq2lEZdDV8Sebdv9 yynfgdyB//gCsQXnZlotybJKycWxrnm6JdybI6eZOvRhPvtmftFoFt6oP+3ybtcheQysd07o 0lSaR3DbTLYWRSpdrm4QW+DtYryMSG9qftvuvF03JxV2hRC51IxS0RMHf9LmRdQg5aCZ0lUL +V4cRarzStEE5nEPiTLH8DQuTFupn3j5rgexELHFoK7wOJgDOu5tfBYmel9z0ZVC5CxqpnzH jdn2XCl9memtyY6juZ7W/c6JxKhMDso+EjOOWggtUYQw+c8TqAS59mX9S5zUkIicGprG0nid zd5yonVv4Dlk/5WkGQjV/T1xL70DAogkWSu2OwpXf4u8T2SHYbJqN69PpkWyDU4UYho91wuZ gjtwny2us1fHGw6BjV3NTGWwpnkUC5uxMZ4IgupkdSTJcEb/tppZEflXklY6soJj7w64wsDY BVfaThzctRGGnqC0zxgnNi25iFUHg1A369MzI/k/3Q+T1XkHdl9lAf1cwSk1wRnahNO6Vs1q DqNL9lm6pJSdJTRaVhBP0ZSc/yMWDVRwnQWVjib2jPJeUiATbgupT36LI66KWDf4EJ9oI7nN DkXElDvWA/VkryAaS1rdx22yGIZF/4cSXmy8lY6ZQ8kKb7XqDXPSqKT01ru9e8ot0Ea/erGc qbCdZzObvOPGHuEYFG00nVQJ9JM0QTV8UTp5ISR0+OmMTWMYfn39arM8r7Ff7IK3IJS2n/Cn wMUHzYP8Nb9H2mXXf+nVz/QHXoVkvj/Y9hMaTT8uQJobJ9crFkg0wwsxCU98uLITpNvugdZ0 1lOo7qlau9uC2X8A/zniJUEysYKnwQzKTrUntMqwNPGVjza6w/t9KWfn0X+HOGIxR4Xv7HCQ I3nSUwxYuHa7irgQwyAdOuNWyXy1EJomiRcpsakqqfoeDoZ40/FZRjfKBqDw3EG1hUlG9R2S d+QT5BYnWaOiLliK2jgpBRLvrYbcNAjACiJtMRj2neu0WarcQGXWAaQDaqbM6SjW8VNn9pr2 w015VarKuLmD6pJ2d6qv8/KkdwZGOeB68DMB6If7xOmrfgeBh5SECDgTDysWBrRkPas2Epwk DxJyydfv/GRn5QoGpR3KrR/FRoTWmFZE5rZndmsYpyKHTeth9IoJq2T5v291HURkoJw+kbPj 2AWzcULw907/2c1RKeml+5ZDgb76RrGtaYIKUocrnV1H/oFZaBkrseGeRIuLx/Msr1j+MNWe WDWgOcIT/iEdk10wiNqntNAlgtlFAU1dfTnDH15mmx23AyRcfIKFN9XrcBPpWy6XPnS/vg6u QwsfsF+c+LdkP/Zd6NxfuJM3ptKhbPrXW3SO9tg5ZOpq42vKZyGZ6ecTag7gAw4DwOaOPP0G UZS+BHxZqEHKlFVckbYThY8Vokj87nFjpgjiXGRssFOWgwhHraNe6T67XGqbATElSMzTGATm W3wml4xbP5RCON2r4RNrIoLUlXYEY67m5+/OnqTfyYNCyaM8VC9kG9KHmzbft0T7WEA6wZqn 9Bkp21tt7SUyrzwwbLuzRnZopI7ma8WMu3RCaBA/RB/dD/GVOChMKRkYGOpQaybTuwcEIDg4 JZMWQWc8RYkzEnyLQN7RLacN29nmsV131E4T9mkVbx2o+ppEfjdHs2QDHxs9FxRjlcMn+BkM Lf1/OXvU6NuwR45Q== X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="40821259" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fMkVWnh2LgXamTSc5M5KLVBR5JIwjmm44a7564tUZ+9ek0s/YRgfnBlJJCDIH4fgP8mckdY1OTyCx5AiADRRIh+Q/hoPwZOEt4XPpE76+RFgwrn7/uQHelEkCRff3nnFir/2qlDCQ/c0YCiuiMP6GCsshJvMauz5U/JhYiOfB4AMGX5BuOqZhmFioxq8+1+z25vr93qamRDPc//F0H41PgFz1+InFm4AUIysddXg5bNgw5FOfMvahVP2PR9SWwIuL99yjdA9fvRzM7QDXWLjtVj+9LNp7QsUzizNcYtp0cVARFFn9cSWFna+SVSVGx1XZ7MOsg5Jagp0bsMaDeLFPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E9Bof/P9ivmijchbbNvr/d9Cs/Off1vuyFeRE3O+sMA=; b=mFqlwAtaWkMkvLbGE7cHKJ6131nyPSTEjfTRhnueAnczyfRLdpSaAkOHrg2arV024yYVhz1KuLVCZdhcMCA5YThubTTu36sTf+sXf1jpyvPQlXa2g3ghvTHnqR82R4Taz/68PxdDbcqA8G1SS6nl6lvH3UfdLH9j8kSpGq01LnNFwRoykyFTgaYLHCs+ZtyBxQHBqud6WHI8XbMyCTOQcmrKUwU/ToHHbG5+X5CiDUI1SzKuRd5rSKWTQLQJHJ1mHYY7wfLiuVtx6jgf+5h80P5WDYL9+q26M6QbQ/JjeaOGbxR1P3ImsLbtzatktQiIHQP5a30VyE9F/MTrN6lyWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E9Bof/P9ivmijchbbNvr/d9Cs/Off1vuyFeRE3O+sMA=; b=BiL9k/CVrAgc/PRQnKOVDKfte72dddbYjgylMbvEaDVHDcFcXrNJ/WE+Sh1LIbYjE9Pb1TAtGLAClBANF3Q6MpnJB1mKxPNmn5YySJ7xMZWAPN0zBfg7k0I0isJjtAOAfKbM2xB6UAKsBFp6vYiFr4G9e2QfFe6R9PDqPuDxdK0= Subject: Re: [PATCH] libxg: don't use max policy in xc_cpuid_xend_policy() To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Ian Jackson , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <4fa05759-24ac-5ff3-3db9-94537f6be95d@suse.com> From: Andrew Cooper Message-ID: <9abb7b1a-990d-3783-39cc-52503dffda16@citrix.com> Date: Thu, 1 Apr 2021 12:33:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <4fa05759-24ac-5ff3-3db9-94537f6be95d@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0460.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1aa::15) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d24397bc-0135-423f-208e-08d8f501f8cd X-MS-TrafficTypeDiagnostic: BN3PR03MB2129: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: z+567NJHXeSn+mRaGnVD683U4M32DmKLvdbYABTnmG3lqSBxYDkdMhpVezhBgZubf5mMzsv/ubHXf7uumJe20BwzNhQjMfWuhhpMIj6JtynGyn2sy+hCPo+rxMT5H5xQ2FM/jPvQH7C/YNYmjTpLrBdZSaDy80biple2AGsRrkz3Av5qeMwBY1wr0yEi10pZVsZxr+6l4lrWTXgo9cX7bQ5xjs1KrHGGiMNuRaDDvZbTQ1vTsI7NQsy8x1bWXQhcE6488hR7v8l0uRN0gvrl/sRyDZCinHBKembHeo6w6+uxcGDDUsm1kOggUHcq+hQFOtv97rdf5MhhOeBjSmqKi82iNmBbI4xZuiyqbWsCQcqGgFKliKCkLPhhcJxunF26GjfV+cCEchXkSC/uNZ84qGjpSAsVmA4VCnJeaSaNbZQPlwrAsRAYZa54gxwubabjmbk1nxVi7wyeg5IOB+6/BtX9BVb8GJW5ncc9nARdcYHEXkFpgSSPmAomuxXlQb720tnx7V6Bmugq6fwbR9JvlluJnx8pno3MWXDfK/mbFuRY4Fu/4qTdUjPvu3g4AtU15U9mtaiRtM5Hy38+J9USagq+3sChhUo879SnU8IWiijc2JHT50X3MM1WvQcMHW6ycwvUBa7+tivrPsC8rKW3sFoKiBvcfav9iXtrCRUft2bim4cC8wv0OY4z5wwNODf/AucfTbGyUsQfLHFPR7GmVE5Yb7ZV791uKz1bF11lG4s= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(498600001)(66946007)(31696002)(107886003)(66476007)(16576012)(66556008)(110136005)(5660300002)(53546011)(54906003)(31686004)(4326008)(6486002)(186003)(956004)(2616005)(86362001)(36756003)(16526019)(8676002)(8936002)(38100700001)(2906002)(83380400001)(6666004)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Vlg2Vm5XNHJpenlNaElleGJPMVR2a01SQ1ZULzRRSzNlRHA1VWhaSHJtbjdU?= =?utf-8?B?UkNLOWZxbisrYkZyNDFRajkrNUtaa1oxdHp0WTRkeVphM3c0bTdKT3NvWThW?= =?utf-8?B?aWpNdlo3cGtOUDJBdmRWVkFLTUgvYVg0aUR6R21GZC9MVExlZksyVk1sL3Nt?= =?utf-8?B?ZHpkTXhZK29TLy8vVzRCRFlCRTZLZ1huYmZhZUZoTmpyTDlBME5YaGF3bVJk?= =?utf-8?B?bmlWM2hFQndHUDQ4T0RMYzRLUE5WNlJUMEZLVkFlNUxEY01MOVFsU0JPZ1V6?= =?utf-8?B?bjJCL0JSd21FQ1V6SDRRM1VkUnlwRTdWWVA4Skp6V3ZXSHJJcWE2RG1FOXJU?= =?utf-8?B?SlplQk9WTjE3YmE1aXBmYnUyNlZnZGF2bXdYSGdWQm9yYXlROEwzQlU0U0NM?= =?utf-8?B?M3NPdUZsek04SmcrRFpSenN2QngxZW4zUnhEd20vYlVRV2w1d0hUekxYQk1m?= =?utf-8?B?V3ZKRFNrN1FKWUJyTVJJdG5DY3l4YlJQRHRHVi93amYrQXhNZGN5M296TVVU?= =?utf-8?B?UmhHUDZnNkVFenkrSllyT2dWTklrUkQ3VTVkSFB2aTdRZ2czcWJQK2lwZjFI?= =?utf-8?B?NG5HenlvSEJPQTkvYUJOUCtkZ0JGZjNicXFxb3k3Tm5scHJ1MTZzR2NrMG1y?= =?utf-8?B?QlgwWU94WE9CcGZLM0QrVTlGdTl4QkxtckpzeVNJN09TVm54OCtqVkZBRWt1?= =?utf-8?B?NDZHbXF3SHFGd1RaK2J5Y1JxVkNiTS9MUkJhemxLMlc4L2pHWTh1Y2RPNVdL?= =?utf-8?B?Z1ZvQmZvcFFadUVCaVJQY3Z1UCtsK1FlS21XOE5QMEdqRmZmSktqaHFTNStL?= =?utf-8?B?LzdTWSs5QU9mRzZHQ3dwQ0pZRzFiM1FmMlFYTkYyRVlSMzdJSVAwSFFBejlP?= =?utf-8?B?WEsrb3hNMmpLRGI4ZXRaYjhzbjQ5UTRaRnRESkhoUGxlSTVHcThETlZQODJ6?= =?utf-8?B?UGJrWnNONHNiWm9ZeDVabGMvV29OU1grWGJhOUthU3RuaytCenU4TVJrYndS?= =?utf-8?B?QW5uc3BmaFMrdDdaT3dkWi81R2VnQS8weWxBek16K1BYMWIyVzFtbWVlTnJp?= =?utf-8?B?TDdNeGFPNVgrQjhBRVpTOHBoZVU2QzM0K3pZb1lHM3lyYitpMWoyc1lFS2Fp?= =?utf-8?B?MytLYlFXeTNXSmpULzh0bFphUlhPMFZTUWZMZHRBdk8xRUwzZkRmWGxHajBE?= =?utf-8?B?eTNlM3VLOWw1U1R3ZDhoZkJsc0FkRXkyMnZxYjNCM2Z1SVlKZFJ4dGY4YWY3?= =?utf-8?B?SjYrVXcvL25XcTJrQ0dyNEovajN4amd6NU9YRm1KMzlnT1kyQmVBQlhXelJw?= =?utf-8?B?K3htOXZLMjc0eXhFS3JPdTNkVll0OUh5eU1LOTZKR04xWTlXSEFUdWhVL1R3?= =?utf-8?B?YVI4MHFVUFlKZUluOUNmTHBTdjdKZ1dJRHRDL2xLVHl4WUxTaFhUNGFqTVFa?= =?utf-8?B?UFFNWTY2WHBFTTd4bk1RVVdjQXNYdEJSVjBoblNXRHZsanRSWDFlU05tb1k0?= =?utf-8?B?YXhZakZ5MVFJcXd6MzFLd1VaOW9ZZEs3VVNwc2FNMWJVTit5UFFOYzRGZzJu?= =?utf-8?B?dkxZTXljREoyVkRXYmxkRWlybVZpbEdNVlBLQzRtREpzRFgyb3RBczd5NHJp?= =?utf-8?B?c3pxRTVCS3Y1OHd2Yld4ZzY5RXh3MEc0OTNJMVVPVEFDWEszdGF3QkpiS0I4?= =?utf-8?B?dG93bG50eGtNdWt5TCtGNlJNOW1kbUtCV3pTNDRBc2l2VEpRKzFaMVRBbXhX?= =?utf-8?Q?NHbomT+ebv7BaD/ZPLldkqz93emkxoaetWiwfOH?= X-MS-Exchange-CrossTenant-Network-Message-Id: d24397bc-0135-423f-208e-08d8f501f8cd X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 11:33:29.3319 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: muVuPaAk8WiTXviEQQo3R4vcgclBFZYGd+/7f9B73oe0fal+RpstumTU5J9DnzVP9iFIiIJ3Y1MQk+OaTyY5PTy6cehl+hd5uzL3GJeSp1I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2129 X-OriginatorOrg: citrix.com On 05/11/2020 15:56, Jan Beulich wrote: > Using max undermines the separation between default and max. For example, > turning off AVX512F on an MPX-capable system silently turns on MPX, > despite this not being part of the default policy anymore. Since the > information is used only for determining what to convert 'x' to (but not > to e.g. validate '1' settings), the effect of this change is identical > for guests with (suitable) "cpuid=" settings to that of the changes > separating default from max and then converting (e.g.) MPX from being > part of default to only being part of max for guests without (affected) > "cpuid=" settings. > > Signed-off-by: Jan Beulich This is a semantic change for how the xend string works.  However, I do agree with your reasoning. I'm pretty sure it won't be safe to backport across my change to effectively eliminate the s/k options, but that's fine because it was the same time period where I introduces a distinction between max and default. Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Thu Apr 01 11:52:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 11:52:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104387.199651 (Exim 4.92) (envelope-from ) id 1lRvrd-0004AR-W8; Thu, 01 Apr 2021 11:51:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104387.199651; Thu, 01 Apr 2021 11:51:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRvrd-0004AK-SZ; Thu, 01 Apr 2021 11:51:53 +0000 Received: by outflank-mailman (input) for mailman id 104387; Thu, 01 Apr 2021 11:51:52 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRvrc-0004AF-8K for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 11:51:52 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id bad752b4-6f0c-428d-b3f3-ee11ccb00475; Thu, 01 Apr 2021 11:51:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bad752b4-6f0c-428d-b3f3-ee11ccb00475 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617277911; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=d4jgKVieTHjDdONydkGo/SyR7h6s4QTs1b98ndlh0K4=; b=dvt6XEWm8BonrHVpX0MXWQY49EUe3Hnd/LgMOD7oL6XHThDmaS1xeUYk JSijEv4vtd5Rrt8JzAj1I/C/6oS8McAsiYalPb07J5XkKooXHypcslS/t gpfUC7+6wAomCIDvtyUL52XRrKLngeseJsGp3P6p7hLJeE2WoXvjX4Oep s=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: GHZsvZD3DZTaWFfnmKSwpRF0eKfEwnEUOtLE/xfH6ULO/58hG3Bt9HuOtP7diodbOjORx//4WE KjW49zG4qyik/Lt0rVkkaiBOkMpP7blP885jmRuWV8S1wndBkEJ6CSE+sg6D1tbDDtTTqAswtU 48G2Bv7QjJQzbOrXcVmtPfwT/BylrOuq/A/UdsKwIav+9wUV5mzbL+TK4em9ISyDpPIJPp4vun vUqhCF7lk3hZwKlOVOVubT64DCeJsglZmuSpoddRdZ8ibRKAWy+4WGBaj2y7yJ7Hdzl4fJSP5h D7o= X-SBRS: 5.2 X-MesageID: 40681546 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:GII2+64lif+rJXD/NAPXwUGEI+orLtY04lQ7vn1ZYRZeftWE0+ Wnm/oG3RH54QxhIE0IscycOaWGXHPX/YN0545UBru5QAz6ogKTXcNfxKHJqgeBJwTV8OlB2a B8N413D9PtBVZ35PyKpzWQOdAm3dWB7eSUlf7Tpk0dCz1CRoNBy0NCCgidGlBrXwUuP/EEPb eV+8YvnUvFRV05dcK+b0NqY8HioJnxmIvicVo6AXccmXCzpBeJzJK/LBSCxBcZVFp0sP4f2E zIiRbw6Knmk9zT8G6660bp455bmMTsx7J4baTn5qcoAw7hhQqyaINqV6fqhkFSnMiU9F0onN PQyi1QXPhb1nLLcmm55Tvr1gXwuQxejkPK9F6CjXPv5fH+XTIxYvAx575xTx2x0SsdleA59I gO42WYr4ZaZCmsoA3No/zzEz16nEu9pnQv1cQJiWZEbIcYYLhN6aQC4UJ8Cv47bWnHwbFiNN MrINDX5f5Qf1/fRWvepHNTzNulWWl2NguaQ3IFptee31Ft7TpE5npd4PZasmYL9Zo7RZUBzf /DKL5UmLZHSdJTSq5hGuEbQ4+SBnbWSRzBdEKeSG6XWZ0vCjbokdra8b817OaldNgj150pgq nMV1teqCo8YETrBcqS3IBa8xzETWmnNA6dhf121txcgPnRVbDrOSqMRBQFiM27ucgSBcXdRr KyNfttcrHeBFqrPbwM8xz1WpFUJ3VbetYSoMwHV1WHpd+OLoXrs+fcYevCPbaFK0dkZkrPRl 84GBTjLsRJ6U6mHlXihgLKZn/rckvjuZRqEKbb+OAXwJMXNpJFtxUUjVjR3LDGFRRy9ogNOG duKrLula224UOs+3zT0mlvMh1BSlpO7K74SHNMrw8SO0byebIO0u/vOVx67T+iHFtSXsnWGA lQqxBL4qqxNYWX3j1nIcmgKHimg3wao2+qQ58QlraY39rsfoo1A/8dKe9MPDSOMyYwuA5x7E 9fdQcPRybkZ0jToJTgqKZROcbyWJ1XhhyxLctdtHTF3H/s3/0Hdz8+XzqjW8aMnEIJXDpbhl p47qkF6YDw3QqHGC8agOA1OlVXdSCsGbpDSD6OYp5Z84qbPT1YfCOtnjyVixY6Z2zw0V4d71 aRZRG8aLXFBEFQtWtf1buv+FRodn+Fd0Y1cXxit5ZhfF62zkpbwKuOZqCp1XGWZUZHyuYBMC vdaT96GHId+/mnkBqUki2FD3Mo29EnOfHcFq0qd/XW1mm2IIOF0aEAEPk8xucRCPn+9usKW/ mYYQmbMXfxDP4owRWcojI9IzZvwUNU4M/AyVng9iy1zXQ/Cf3dLBBvQKwaOciV6yzhS+yT2J t0gNoptYKLQxLMQ8/DzbuSYy9IKxvVr2LzVe0upJxOta85tbd4HfDgIEj1/WAC2A97INb/lU sYTqg+/avIPZV3edcOPy1e5Vgkmb20XT0Wmx2zBvV7e14jj3XWZYzUp7XJrKciGU2Hqk/7P0 KF/yhU4vfCWG+C2Nchet0NCHUTbFJ57nJouP6GfcnXDg6hculY5lq0MnOnatZmOdi4MKRVqg w/+s2Cmu+cajHx1w/RtyZqO64myRfafeqiRAaXXfNS+9O0OV6QkrKn7c66gjDwUya6YS0j9P N4XF1VaN9ChDkkhJA21Sb3SrWfmDNZr2dj X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="40681546" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sbejz3DKoyaZiLEfnI0RSj9mvO9wey+04AZXo2EKNO30olK2ilY6QqbMSItR2HQu5gUhPqqogrUPiyfrKZXPS7Fq9DtBfVjq4zU13KSD/GGjUIbBx69NBJl/JtZv1l9knUNrzyyfN7wdhfK/RBCkICTzS4LxXz75Lz2OOU5R1J521HFN1yjjQJ3EdAYk9V1cNrmTotPAWXFab43NZNbZNPIVF6NpdSuBdrRnmonzPhbFhojWKkXFKG/HOkxS8vP0GSnUPvgPIdjSj9Q+VAPnn7jOBUR+x4ewqiW1mXT/9R2WfoR8JYr2njh1Dinw2iuYvUBC0pXHVtamUz+fH2O1Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d4jgKVieTHjDdONydkGo/SyR7h6s4QTs1b98ndlh0K4=; b=TIHOSzftfJL4Fr52q8nKehU0mzldOOO6Ak0kG+XTR0LvGHbrJm5S+tVjyWubMc2ekrEijbAwjTPOwsjlXSJIPLiXV0YwP2olVgvBVv9PVV8pJjT3kUGC1qV5CltUuj/1SK6nsqt+565SkHW/pfDf7QQs1Gbs6ECRxkprov+NizNfgZGdHpYIbsBbw/FSSi/QQKZjjOKTwikM2Lt8TV6pvxVMgHnfzkWgQWYXB5cca2gNKmrEOENvptfjDo+OKZGyUdU2mStHm0nkKBJ63RqND9khdrTcZbBE+Yf9PXAUS4rW7mrfgeyXGKEUr4Z7bmHhjP7DGa1RxFPb2KTWhIOZww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d4jgKVieTHjDdONydkGo/SyR7h6s4QTs1b98ndlh0K4=; b=eOmpsxyUZVeUSKd+QXXS0wFi+kR2bjBMlVzJKBm+MhAumRAzQsjPorcbHIsWWPeYIfnPqy1MzGH0xefzY9Sudl+SZ/T/Mrs20B9MP50V3Jp7LPTBKXqMdEknI7CQr6PL/qqdiIfl9SzXxVQ4laUo+zx0GkjVYS9pl1uag6tRHgc= Subject: Re: [PATCH 1/8] x86/EFI: drop stale section special casing when generating base relocs To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <63ad859f-82f0-62ea-5e55-9c6d3db6816e@suse.com> From: Andrew Cooper Message-ID: <5b42bfd1-7d54-8e2a-9fb9-3c153532bb1a@citrix.com> Date: Thu, 1 Apr 2021 12:51:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <63ad859f-82f0-62ea-5e55-9c6d3db6816e@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0333.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18c::14) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c45788be-d1a1-4eec-d10f-08d8f5048668 X-MS-TrafficTypeDiagnostic: BN6PR03MB2516: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:454; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dZT/+TusCsGa7PrSTxjtU3Rc3ndZVlr0fqvu2ZdgkYNJuzQOZpLWuFUc4IVSc9A6lhX6mDWue+Ap7IKH3vj99P3QcR2WzwwVQMFkKCt7n9QpU41PvaXuwF0qtw7AK6E3b/rNruoJiY92+Mo70GgPX8vORraJIIhTcOmv2YNTHFrWowQkDbSX7XL5mvxT9kDLsrohd+p/uZEiM1SsUAizaTtSoJP5QMLnTUxNO0mK/pR5gMGwN08OnlZWomYwRrDUXqwPNM7OEdurlVd6si+JF2l0MJByybDxbzIKqe6WVlYvcEXvgGtQ2CvW47R4lhAGQ/rDwtJ2CPT5qJSjHDsP8eagqYVcUnKKdXX74zza0HGWUn56NYCQ8oXxoA8JFw/XzK3RgDdvExw9kzHKnGYHI+DSKWuAxexTwPRuxF0FWymV7QwBFVKvQPH0J2scv/XTzXa/mryCk1jZ4fKghs8gddCO25qtEhk+g1Yip+H0jwWU61vvhbMeqJXK1hC5sTLY1ntEcTZ8hQxPyrruneEhpo3WIEF9BFbLcIwNssXIaNl7hXVLzIULYGT8E9H4sqlOacGk95SiyLX93LBnwQLGc/Es0V6TpeRcUqV7350OXMpjbio0+WU00boFZB60oLjPNNvK77BGoDGHxI2pbNooHzdZ8ViYR6XEMFWkbfUjcJP02WjiDbci0a3RGQbsPhDaEjB4TRzX7loM8p03K/IOLED130Kk9FhLZKqYI+ZmaLM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(136003)(376002)(396003)(39850400004)(366004)(107886003)(31686004)(54906003)(110136005)(4744005)(5660300002)(6486002)(31696002)(8936002)(86362001)(53546011)(16576012)(16526019)(186003)(4326008)(66556008)(66476007)(26005)(38100700001)(36756003)(478600001)(66946007)(956004)(2906002)(316002)(6666004)(2616005)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?VnlRTTBOdVhtUWtKZ25lc1ZBNHFONHk0cHpOMStzRHkwUlFWa3BDRjlZNkVB?= =?utf-8?B?TnhtSlhWdUJHbngrUUtqTHJWcGpvRHlzN0hlMGw0OXV0YjZBRTdwaitQUFZi?= =?utf-8?B?RGtaNGRJZ1lJSEhsamRycHh2Qll0cnJuTmJoUjREQ05vYVFVOHlWLzhtSUY0?= =?utf-8?B?c3BybHRNTjdQMUlablpubUR6NGpUM2VzY0FIT1NMRjNWYXI4eWRtSXVsUDJs?= =?utf-8?B?YzAyd2VteFdpdk9NSFlIdFJHci9zZElPS3M0dklGZHhhR3Nub2JYdTk5QUp2?= =?utf-8?B?KzJxSWVYSjVnSXozdXErQWJ0VmRsbGdWY0M4Z0FQQ2dlSzNkcFRmQ2ovUWY0?= =?utf-8?B?WHEyTCtobThUYTc5M0RHOTg5U1Z3QTJzWFV6L3pNdXlNUzFoLzhtb0xzRDA0?= =?utf-8?B?RnAyZTg1MjRBUW5Ubmp4YTU3MzlvNXVqd1NQcHRTQThGc09mSzc5cUtQRTho?= =?utf-8?B?Ty9rSkZUaEJaV0JFUkVvNDdpL3pMbUhOb21jWm0wK0N3UDVpNWFVZGszK3lF?= =?utf-8?B?NmxTUEs0Qis4aEIwVXJ5OXF2Q3oxUjFMT1FEM1ZkaHV0NGVBdjJnZkc0Vys5?= =?utf-8?B?WGlJcUM2WUxtVVl1Nk10L2N4bkhjY1JKSXI4eTZwMVlqb3dzZGVMWFZueERl?= =?utf-8?B?aEpGZCtSRW0xZTZmU0lOajl4WktZVXk0VngzMkJaVWtLUVBlTHVGWFVaL2dh?= =?utf-8?B?aGFSemxsMndqZ2RRcEExbHVNVGZKRldsR1BpNDEwRmliQTdmNkhLRnRaY2tv?= =?utf-8?B?Zkt4M1BIYTMvYVNSaXJLczRVZkZJb09ScG16UzBFYTBmb2dkV1JPTTFhYlho?= =?utf-8?B?SzFBaklMRHRkOWQwbnBqcWY4UkdhdnFnSDhSaXJ5RlZUN0dERGwreFZBNC9a?= =?utf-8?B?NXhsRk9lc0gybjhRNitKWHZSWlUwWFNGdVA3bGFGbUlENTVVd3QyU1BVN3E2?= =?utf-8?B?TmI5S2RjK2RQZDZLZ1pUclpKQ0RkNjNxUW1XdmVHMzdhNldDa3JTTjZJTWQ1?= =?utf-8?B?a1VZS2ZkU1FSN01OakpFYUQ4RWsyT2NROGJnWVkyb0l2T1VJTWFId2JXTDNB?= =?utf-8?B?QkNpc1J3YzdpdEVhWStsaXpIVDFjeGw3TDJIc1JCOWpOTVZ4Z0ZyVUpmc3Rm?= =?utf-8?B?L2d1L3pROVBLZFNzYUNmVEx3bGxrdEFpQWVpT09zblpsVmNZUE1NTnhoQ1dQ?= =?utf-8?B?cWpYVm01WFlHR2libGJCeWtZQWcxUW1udmdhL3ExYUFsVTErTlRKTnEvOXNp?= =?utf-8?B?SVp6TWM4WVAycmxkdW5mTGFSMFlqZE53UDRnckRuSjJxMkpldDJTQ1N2WlJx?= =?utf-8?B?NXBaU21VM0p0Wit5Z1dGcy8rdkVwSTFTbWFCbjVSdDVTZFJ0WWF4dG5qSHpS?= =?utf-8?B?Y2tmb1BZOHRSQkM1N3hWdzJXRHdpalBBNlExeUJzeVNBeG96TXBsWXd1cVpu?= =?utf-8?B?MjdRTm52OGtQZEZRaHUzbVFLd0RabXFnZm1Lb0tTbEpLRFQvWmk3WEszS29N?= =?utf-8?B?dlY0TjczN0R5blNFaU5BT1ZWYURZYjVqd3c0emFmOGNJV0RWZGg3ZWI2QWFU?= =?utf-8?B?enoyMEc0aFRia2RKWC9xVlhjVU1Kby90SHV3aDFTWnVtRmVnNjlhdVRkcHlE?= =?utf-8?B?a1U3VEJxRTIzTmFOSlVtOEJCUzZOR3pLTllGWm9ucVdBcUVGV1M5a2NRZ3dS?= =?utf-8?B?bWtsVG9oeDRncUJSeGRmK05qb3NrajdkTE5nU2ZRZVBKaXpMN3BFUTVLR1lm?= =?utf-8?Q?FrJOfEXNEp5URCAQoV0g9VrSjlr0vftSdiyqvtS?= X-MS-Exchange-CrossTenant-Network-Message-Id: c45788be-d1a1-4eec-d10f-08d8f5048668 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 11:51:45.8144 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AX3aD1zAyXazi4oj5LVVtMVKKWQOFhBsIJUFDsjiSoMfO4/hbingB9+kQOHZGis0v+PbBocuNf9526br/ZZ64pZUFNkwggn0m1gBDS0VL8E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2516 X-OriginatorOrg: citrix.com On 01/04/2021 10:44, Jan Beulich wrote: > As of commit a6066af5b142 ("xen/init: Annotate all command line > parameter infrastructure as const") .init.setup has been part of .init. > As of commit 544ad7f5caf5 ("xen/init: Move initcall infrastructure into > .init.data") .initcall* have been part of .init. Hence neither can be > encountered as a stand-alone section in the final binaries anymore. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Thu Apr 01 11:54:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 11:54:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104392.199663 (Exim 4.92) (envelope-from ) id 1lRvtw-0004Ix-Ie; Thu, 01 Apr 2021 11:54:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104392.199663; Thu, 01 Apr 2021 11:54:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRvtw-0004Iq-FA; Thu, 01 Apr 2021 11:54:16 +0000 Received: by outflank-mailman (input) for mailman id 104392; Thu, 01 Apr 2021 11:54:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRvtv-0004Ik-OZ for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 11:54:15 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRvtt-00051I-QW; Thu, 01 Apr 2021 11:54:13 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lRvtt-0006da-DH; Thu, 01 Apr 2021 11:54:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=iZ8kWEzj82J/Y8VRVzECs94V676ffQnEAzBnIRCm5cQ=; b=ADKL9IjxNp9azuHp+xvyBKxSSw QZWb6PGyYalr67zu+7gvlh9kin+FT3Uxhk0NApePaCtngYkM98/xYGizWZbf6XlOwL3nhduZ31Xo1 asZA8tQidKbElGj5JweFBdZmKEwVw3nROnNVaMbX2VOvBCN/m5bVArstrq4LVurAkIbY=; Subject: Re: [PATCH 00/23] further population of xen/lib/ To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu References: From: Julien Grall Message-ID: <27916fa0-9ebd-a49a-bbb9-1ef47c2b5bf6@xen.org> Date: Thu, 1 Apr 2021 12:54:11 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Jan, On 01/04/2021 11:14, Jan Beulich wrote: > This is to dissolve / move xen/common/lib.c and xen/common/string.c. > One benefit of moving these functions into an archive is that we can > drop some of the related __HAVE_ARCH_* #define-s: By living in an > archive, the per-arch functions will preempt any loading of the > respective functions (objects) from the archive. (Down the road we > may want to move the per-arch functions into archives as well, at > which point the per-arch archive(s) would need to be specified ahead > of the common one(s) to the linker.) While I think it is a good idea to move code in xen/lib, I am not convinced that having a single function per file is that beneficial. Do you have numbers showing how much Xen will shrink after this series? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Apr 01 12:01:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 12:01:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104414.199693 (Exim 4.92) (envelope-from ) id 1lRw0p-0005TM-5M; Thu, 01 Apr 2021 12:01:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104414.199693; Thu, 01 Apr 2021 12:01:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRw0p-0005TF-2A; Thu, 01 Apr 2021 12:01:23 +0000 Received: by outflank-mailman (input) for mailman id 104414; Thu, 01 Apr 2021 12:01:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRw0o-0005T8-8y for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 12:01:22 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 66b440e2-bae8-4cf6-a00c-55bb3e31f0d0; Thu, 01 Apr 2021 12:01:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 66b440e2-bae8-4cf6-a00c-55bb3e31f0d0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617278481; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=R6GBDxKhS3qtdNf++KnrNQw6MnOkE9dFm6CLdC2q+Nw=; b=ReVRMk5fwWI4snclHedcMrqWg8VRSglO0dU3ijn6WKL8QDsrlSRkCzHc J7sohT46wJtwhcvWabaxwUj71M4r4BWYYoL1/MjAGF3tAINFljwswdCef jBHGyJwuN/O2/qhc4Pos97fi6aXwPJ2zDukEDJnuOVG1RPcP7s6lKijEt A=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: Jaub2kREXajW/MpPqJOqLmWOhr0a6/H/Si9cJazw9ZSempVLcCvpwqLkDNxhdflWFXPZ4kYPjz I70z47dbB9ZlkbmQDTHmro9l/LdxzKIsky1t0u0MSME5uoKfQj1L5uMDxlkGJihfQhFEQOMEvf JU5Vhy7/KedMSFZla1HSU9HG9+koPSulFSkB5CLZm3SaAU4UL8sNksZ6Ea40ZwwO4mT0h3QdS9 KPrhLQ7+Pk8RVtf57LY2DS60W8PvJbz36G3Uvb97/raGmDpXSdplEl1bjC4uTFRdvgZJZQrBmi XWs= X-SBRS: 5.2 X-MesageID: 40664374 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:1KHQDqjCJ4/RgekKHXb8tERD13BQX3dw3DAbvn1ZSRFFG/Gwv/ uF2NwGyB75jysQUnk8mdaGfJKNW2/Y6IQd2+YsFJ+Ydk3DtHGzJI9vqbHjzTrpBjHk+odmuZ tIW5NVTOf9BV0St6vHySGlDtctx8SG+qi0heHYi0xgVx1udrsI1WZEIyywe3cGITVuL5w/CZ aa+45jrz2vZXwYYq2AdwY4dsLEoMDGk4+jXAUPAAQp5BLLoTSj7rP7FBbw5GZjbxpkx7A+/W /Z1zHo/6nLiYDH9jbw9U/2q65Xltzo18dZCKW35PQ9Bz3whm+TFfxccpKYujRdmpDJ1H8Ll5 32rw4kL4BP7RrqDxuIiD/M/yWl7zo08X/lzjaj8AjeiOj0XigzBcYEpa8xSGqh12MasNtx0L 1G0gui3vI9Z3Ow/1WJ2/HyWx5njUayq3Y5+NRj60B3aocCdKRX6bUW4UI9KuZxIAvB9IslHO NyZfusgsp+TFXyVQG6gkBS2tC2Glw8EhCaK3JywfC94nx9mXB0yFYg38oPnnsM34JVceg028 30dotvj71AVckQcOZUA/oAW9K+Dij3TQvLK3/6GyWpKIg3f1b277Ln6rQ84++nPLQO0ZsJgZ zEFHdVr3Q7dU7CAdCHtac7vCzlcSGYZ3DA28te7592tvnXX7zwKxCOT1gojo+Jv+gfKtezYY fxBLtmR9vYaUf+E4dA2APzH7NIL2MFbcETstEnH3qTv8PwLJHwvOCzSoeSGJPdVRIfHk/vCH oKWzb+YO9a6FqwZ3P+iB/NH1z3fEjS+o9xDbj68+AfxJNlDPwIjiElzXCCou2bIzxLtaI7OG FkJqn8r6+9rW6quUbEhl8ZfiZ1PwJw2vHNQnlKrQgFPwffarAYoeiSfmhUwT+iLh97RMXGLR 5Hqz1MiOWKBq3V4RpnJ8OsM2qcgXdWjmmNVY0glqqK4tqgXZ8kEJA8WuhUGR/QHxJ43SZmwV 0zKTMsdwv6LHfDmK+lhJsbCKX0bN9nmjqmJsZStDb4rkWTpcYmQ1MBRD6wWcurgQIjLgAkxG FZwus6uv6tiDyvIWwwjKATK1tXclmaB7pAEUC4folOo6vqfwtxVG+OojSfh3gICyzX3nRXol akATyfePnNDFYYnnxDyK7l/Gl5cXinc1tqZmp3tpB8Emr6qm9+uNX7FJab4i+0UB8v0+sdOD bKbX8pLgRiy8ue+TSVlDyBfE9WjKkGD6j4NvAOYrvT0nSiJMm0jqkABeZT54sgHsvpqPU3Xe WWfBK1IDv0B/gy4RGcom8oNUBP2SAZuMKt/CegwHmz3XY5D/aXHU9vQKsDJcqAq0fjXPSF3f xC/JsIlNr1Fl+0TNGIyavaNWEebjzSpHO7VOEup9R/u7kouL56ApncVn/p2Rh8rWIDBfaxsH lbZqJxpI3lEMtIWec5fipC5FonlNiVNiIQw0fLK957WWtotmPROtOC3qHBprUuCHCQvQeYAy jqzwRtu9P+GxaZ3bEUC6gMMX1bRUg15nNl5v6DfeTreXOXXtAG2FqxKXmmdrBBDICDBLULtx 5/iuv40tO/Rm7d2ArKuyF8Lb8L22G7QdmqCAbJPeJT6dS1NRCthaStifTDwAvfeH+ea04Cg5 dCelFVRsNfiiM6hIly6xOMcMXM0woYumobxypmmF7r0pWn52mePXguC3ymvrxmGR9JMnaJis zZ9/O/z3qV2kkc5aX+ X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="40664374" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sra4nDGMYlsgletTqRFWnEVZad0SW8Hbfw58z3jT6cjblMGwsVxon3DEoAOX62XMk6fTncAy+z8BSayWmpEcDlbGV6RjNod28FAddvWA+r+7RCrPI+bBrUSLG4uLMbtbnUX0zAPqrPTTl2vQQENfGt8hVPCdWhTw7kWRoT/t2/1jH0dKHuEqR6NT2UuKr7Wfljt8P5+uXalxAl9zyp+TE4TsndiI8mIt5chiTwVhxUUI0I80fJNUo8JAqnQ0v6DVb4nWDZuMgpfNPob+XVU3SgjyKh2DvcSZZqx2nLg8G03lcI/iPNISaLRFMYlQFLlULetJCH+8qYqUekiRZZZuqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R6GBDxKhS3qtdNf++KnrNQw6MnOkE9dFm6CLdC2q+Nw=; b=nt4fG60JcxFXRFnzRLaL5afL9Wx+63vpBssTIUDK20AYJq+AKRoQhYDffb4Qgyy9vpuhDvAMg4WPLZqJU4mQydoYBgd3ZXZ5v4OwJXcw8Uloh0ZGnYdDb3keX5ibagSc4/IiXHwt59DLxXYRZbFEqryvpH2Rokr/P39Z6Mi04ij6+qtQyOTeeexEm9Ce1VJNhFKIDPZdAEK5nBBYaZUrIr4NHi5T40bBw8JsOhcD4qfgmHJPuz7H6Lts/2jaJRmqtMUGpPuWyS3RmV5wEfpoEjqEwtoUfJ43BsllyTFGPWQuGWtg/byadOQCJe0g8ffcPc+Vp1p92sehVzcY4eleQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R6GBDxKhS3qtdNf++KnrNQw6MnOkE9dFm6CLdC2q+Nw=; b=f4jtNwupFuQ73JHuAh3PWBQ12jS4hFpcut3RBs4AbIwNgsByebP/pM9xS/5mtOxif5lttY9QZhOSYJ2C6UexTu+WW/DBV4W7xohpin2XwjMldVUFrOpMcPbOnSmgNKNT/KdHWyj6OBUgdS4hfxjW+lPoUVnLXgd1yv+wgy/IbfY= To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <5d7c61b0-8441-dccc-4917-cc8a436fd96f@suse.com> From: Andrew Cooper Subject: Re: [PATCH 2/8] x86/EFI: sections may not live at VA 0 in PE binaries Message-ID: Date: Thu, 1 Apr 2021 13:01:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <5d7c61b0-8441-dccc-4917-cc8a436fd96f@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0266.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::14) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 08c670dc-f1db-40d8-b902-08d8f505dac9 X-MS-TrafficTypeDiagnostic: BN6PR03MB2964: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: U0ReailU+1j4g8lLtu7Kg3qMtCeM/os4sNGLy6zX/+PipGyeVI8lUyBrZ6Jo7syuzhiYFz4YxawWqBb/uJGp3k72TzJGr52H4rvXF5lax5ijslwqdQX9duYbiFH7KA26ULvZo4jGsQIQCazepucMQcKoLOvL9rDoGdzvFcJO6J36vx5hmatnrvSO8ym0Gq8cWF0uCTJmvfwFzasCecvVrBYoiQbr5fjdUCnTPPCT/psbVkWZLJfM/0T6cWO8Ycs4av63bd+KSrOFyaWv7jm673Z9eA+nyOSwlOPz9BYv8AW5a5Qu6emQGZmWB5UTf8q+7PfXSuxiErZjpqkxJsQq7AU4bdSlfMBMBBx31b1QXv+/WHF7y0Qcs/3pSWXn/giG6FE/Ka+e/7en2Je86JfT7Qvc344mBhMIDGaC/DOOs+aWmmKLQjkclxEh7IXR/kmNfSMBF9OLNMA4pv/ItwRXUXNdI6+x9R2j0R+WHMsiTCOgBXVSmgBXC4kh+/YQ7ulrDHgyWqE7F3LHoEooN3GNLpnJjask8fOCV8cSEqNEa3xf38G9SouwBXj2qjpwFBGvPruKuBBDusftJ00KBojAwM8vfxuPoe8IUjucRSJOs5CMhWOvlFNbeageotlvPGL6nSNZfzAJqoS3wgyE47X+JRywZqsDCGARfPFgYGIX9XPxd647lXy0ugpBRdZmByfUxuzLklyptEuQj2CMpyTf0mnyQ5kx4q5+E4L8Ze9qvwo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39850400004)(376002)(366004)(346002)(136003)(66946007)(86362001)(8676002)(36756003)(53546011)(5660300002)(107886003)(6486002)(31686004)(16526019)(478600001)(26005)(316002)(38100700001)(16576012)(31696002)(6666004)(66556008)(4744005)(956004)(186003)(54906003)(2616005)(110136005)(2906002)(8936002)(66476007)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?RXpCYmVzb1IwRVoyV1ZWVEV4NTFMaUFKZUxHdlpGYTlLVWV1U0dnbHRFTWZN?= =?utf-8?B?aWQwTzFvbjhHeDlYMkJFbFlicU10NWtRZ0FpMVBmY2dJWnJvUGpZSVhqbklN?= =?utf-8?B?czBEK1lMMCtlYW81Wm0xZ0FIOXZsQ2lGc3NBQ2V1Qy93bnhxNUhVQnZnaHZH?= =?utf-8?B?bFAxajBMMGlwNWlDd0JKTzlXRVlxRU1wUjh4dzdSOUEvQmJsNy95dFZWVDRE?= =?utf-8?B?YnZpT0ZLWFovRUZlRjdDOG1pNFVrQkNnbTZNa0RYZDlEN2tJdnk3QVpTOEZT?= =?utf-8?B?L1FYWkxZVEtIK1RGRWl5RHFPZjcxRGFVWE53UXMxQmxnMUdzN0djMk1QZGZ4?= =?utf-8?B?cXhlb1gyaEh5TUhCOHlhQUt2enlHMjhOM2NuNW5hVzNJWUxMdzBpOGpFdW11?= =?utf-8?B?M24wWmRJM3NoOW1MYUJzdElWaGRaRkdCTGhDaHgvcTNlSjNHR0pLTU1DcXh5?= =?utf-8?B?VkNWQmpGbjMvRDBpRElCVUFNUmhWeGg5akZ0VzV0akZjYklGUTROR1E1VEZJ?= =?utf-8?B?M0NneTMzT08vYk5kbktsK2JVREVqdHp5dEJ3MWVYL25YODRTM1B3YXc0VXJX?= =?utf-8?B?U2FzWWE4M0dQdGpkbVplWHlicnkzTjBSSFUyd0VONHJNOGdkeXc0QTdsNFpj?= =?utf-8?B?ZllNeGNsZ3J3Njl6ZkkvSHpROFZ4RGpmYnRSa1YxMkl4MHd0NEdmdXBYT3p1?= =?utf-8?B?VklEWWd3Q2ZDRXZWalVWWVZWSXdIQ0Y0Q2dEcjZTZXR1Z25KR0NRbnlxcjdS?= =?utf-8?B?NHdma2ExSExpOVIxVGwvSzRXSGJtY21QN1ZubEVFbHBuMmlwUVA1Q25oM0w0?= =?utf-8?B?SEJDVUN2SFBiMU1rSm9NaFBycU9HekVMcEdQZXMvRkcvT3NGckxrVjNTZ2FB?= =?utf-8?B?dFpybUQ1UmxMMjFsWDQwTDgrbjNpbm5UdHQxemJzQ3ZDbG9Tb24vUkFENU9W?= =?utf-8?B?TUl0a2NYVzE5NWp4MlZsV2xyVGJXVFlNNk0yUEdxQ3lZRndiN0JmbExYYVlq?= =?utf-8?B?NkVwaHBKNm8xcGhHMm1rbVhoMHRrMElPNzlHVXovU0xJajdMcGE0ZS9DMlRY?= =?utf-8?B?OHdpUTZKdDBVU2k3NXFmWmp3UllKSHozTE44VnNGcXVYR0FEdWVMNzZUbnBD?= =?utf-8?B?ZGErQ0FTd0xVRDlPdU0ySkg0WG9WeGNSUDBCN2dFL0IwektadE5IMlpIMmFx?= =?utf-8?B?Vm5vbndDcFVvL0JTOGVLNkpXOWQ2TWhNSnQ2SXgrMnQ3bEg0RDNEU2pkdyt2?= =?utf-8?B?OHVtN1dhbC9FQm9OZ1prWGpkT2FQV3VXK3VEaWE1VWpzM2hzdjArRzVJaUFL?= =?utf-8?B?S3NneHhudVRDUzJOZ1Q4OThkdDhjR0JkR2xxVzJZdDMyUllCdHJpdU5ENHd4?= =?utf-8?B?S0ZCQ2N6VFVrWk1Wbkc2VXN2VVpSZ0VVTmJlWWFqNmNJS0hYNWEyU3k3TjB5?= =?utf-8?B?Y3MvWVlwelF1eVAyYXNLdmhWcHF1STl0UW5iYWdlZndNWjJvdmR1Z1FSNTE3?= =?utf-8?B?LzlsNzJoMk9xcXIzSDdjNFJZQjd2Y1dMa0lkNE5SbWtCTlZZZ3VNZkhZTnFW?= =?utf-8?B?TFFEdktEdlhZamdzTlJRNmZiNC9VUnQ5OGtFNFVSNnV2bk4yOS9tYk1yL0Ja?= =?utf-8?B?b0pQS3ppQTNObWpMaERxUXAwSEZjRmlZS1B2SVROSEtGWi9DcFFQTGp0WEY1?= =?utf-8?B?Ym15ZFBRaG5DYXR0WGxrcEtsK2ZJdW9SVlVpekxVN2pyNklKRm9yMzhjOVBT?= =?utf-8?Q?XFv6vDyYHxYWPEm4CNaHr/Q0ldoa9UiRetRySoh?= X-MS-Exchange-CrossTenant-Network-Message-Id: 08c670dc-f1db-40d8-b902-08d8f505dac9 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 12:01:16.8749 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mH4H1YaiTJugoyxqgeKlDdfDeDEKgskewVaYFReFj7/hNVmyOJ3oePjPTT/+jKRFocgozcSQfeG+XExQoUti1Ace7hhv8b+i8pmKAKJ2b24= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2964 X-OriginatorOrg: citrix.com On 01/04/2021 10:44, Jan Beulich wrote: > PE binaries specify section addresses by (32-bit) RVA. GNU ld up to at > least 2.36 would silently truncate the (negative) difference when a > section is placed below the image base. Such sections would also be > wrongly placed ahead of all "normal" ones. Since, for the time being, > we build xen.efi with --strip-debug anyway, .stab* can't appear. And > .comment has an entry in /DISCARD/ already anyway in the EFI case. > > Because of their unclear origin, keep the directives for the ELF case > though. > > Signed-off-by: Jan Beulich > --- > It's certainly odd that we have stabs section entries in the script, but > no Dwarf ones. Its not odd in the slightest, given the heritage and lack of anyone touching the linker file unless something is broken. We've got dwarf symbols in xen-syms, have we not? ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 01 12:42:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 12:42:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104428.199705 (Exim 4.92) (envelope-from ) id 1lRweg-0000cU-BD; Thu, 01 Apr 2021 12:42:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104428.199705; Thu, 01 Apr 2021 12:42:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRweg-0000cN-84; Thu, 01 Apr 2021 12:42:34 +0000 Received: by outflank-mailman (input) for mailman id 104428; Thu, 01 Apr 2021 12:42:33 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRwef-0000cI-5Z for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 12:42:33 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id af79d1b0-af77-4612-8a82-dbc6cadffa7b; Thu, 01 Apr 2021 12:42:31 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: af79d1b0-af77-4612-8a82-dbc6cadffa7b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617280951; h=from:to:subject:date:message-id:content-id: content-transfer-encoding:mime-version; bh=c2FAstd0dm59Kju/X4V60meqn2OKdaSyzGFeglxU81Y=; b=bzl2YjhGVSKqIdD7fTxoha7BaPm1HJlNzImuhPOqjJ1cuYRvyT+aaTNq uA+VDRp2ounrxoa6b5PLngA35J6nFecJq5GWBPRAC8l/F6L2VumeR0D1F IwBMVHKATpXYozZp/aY7WJ3ket+2H9xxB5LdX5QojmYqfYM9vA4BhhAkX g=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: v7T7UkFmw1OXSdFKt3kxpk18i+95BlV/TQ9nwClFkiLDJejp/YXrfofgAz23YGWcWYT1beVqRq PR+Is3xOwTf3HXHDTS5jc6upLUXca4r85uVOz+/RFvmYJ2gaI6KF0pCftZviS4jLNXY3ktm2pV 2YutuuEMrpVwq0V591dlj8zITtHwkh6MK3ZIUeetaKH/Qz6IxQ/OZUKid9G3uV1JaeQkISOS11 xPa1gSo+BssvADN3l5M8sBaYzZnBvf036v0ahcf4Pvrdnr0MPa7/oWD4BoPp8VXk17gZzKSs10 NnU= X-SBRS: 5.2 X-MesageID: 40547795 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:43yJG6gPa/oWHC/CAZZWV/zAEnBQX35w3DAbvn1ZSRFFG/Gwv/ uF2NwGyB75jysQUnk8mdaGfJKNW2/Y6IQd2+csFJ+Ydk3DtHGzJI9vqbHjzTrpBjHk+odmup tIW5NVTOf9BV0St6rHySGzGdo43Z2j+Kenme/Rwx5WPHpXQotn6Bp0DRveMmAefngLObMSEp 2A6s1b4x+pfnoKZsq2b0N1JdTrjdvNiZ7gfFo6HBYh8gaDlneF77T9Hhie0H4lInxy6J0l9n XIlBG827W7v5iAu1Lh/kLwz7ATotvuzdNfGNeB4/J1FhzAghulDb4RIoGqkysypIiUmTQXuf 3thztlAMhp8XPWeQiO0FXQ8i3tyiwn5XOn6XLwuwqaneXDSDg3C9VMiOtiG3OzgSdBzbJB+Z lGwn6DsN5vBQ7A9R6Nv+TgbQ1glUa/vBMZ4IoupkFfSocXZftwqoES7SpuYfE9NR/684wuHa 1SCtjd7p9tADSnRk3e11MfpeCEbzAWJFOrU0ICssua33x9h3Zi1XYVw8QZgzMp6I89Y4Ms3Z WEDo1Y0JV1CuMGZ6N0A+kMBeGtDHbWfB7KOGWOZXz6CaA8PW7XoZKf2sR02MiaPLgziLcikp XIV11V8UQofVj1NMGI1JpXtjfAXXu6Rjao7s1F/ZB2tvndSdPQQG6+YWFrt/Hlj+QUA8XdVf r2EolRGeXfIWznHpsM0Bb5X5VUNHkCQMwYsts2QDu104f2A7yvktaeXOfYJbLrHzphcHj4GG E/UD/6I9gF7k3DYA69vDHhH1fWPmDv95N5F6bXu8IJzpIWC4FKug8JzVCw5sSBLyxeorU7FX EOZ4/Po+eeny2b7GzI52JmNl52FUBO+ojtVHtMuEsNKEP7cbEKvt2FYmBM1H6bJhtyJvmmUj J3lhBSw+aaPpaQzSctB5aMKWSBlUYeo3qMUtMBgKGZ/NzkfZk5F54iX6R0GWzwZlpIsDcvjF 0GRB4PR0fZGD+rtL6si4YMAvrDM/Nmhh2wHMJSoXXDlEmVqM01XEEHVzq2XcP/u3d2exNkwn lKt44Wmv6phCumI2pXupVEDHR8LECsRI9gICvAToNOgbzvcBx3Vg6x9ECnoiB2XHHr+UUUjn HmNguOd5jwcwFgk3hFz6fn9051fG2Bf0R2Lmt3q5F5CH6ugAcM7cabIqW0yGefcV0E36UUNy zEeyIbJkd0y8mwzwP9okfLKVw2gpEnPunQF90YAs7u82LoLI2DjqcdGfBIuJ5jKdD1q+cOON jvDTO9PXf9C+kz3RaSqWtgMC5oqGM8mfet3BH+9mC30Do+BvXVSW4WDo0zMpWZ72L+QeyP34 g8hdUpvfGoOmG0c8WY08jsHkt+AwKWpXTzQ/AjqJhSs653vLxvH4PDWT+N0H1cxh0xIMr9iU t2etUx3JnRfot0O8ACcSNQ+VQk0M6CK0YmqQT6CO4zd1NFtQ6tA/qZp77T7bY/CEyIowX9fU SF+ypG5vHfQm+N06UZB69YGxUdVGEsrHB5uOWMeI3bBF/0K6VN/F+mPmS8d7EYQq6fArkUpg t75dbNn+L/TVuK5CnA+T9gZqRJ+CK7RMn3BgSGE+tB6ca7NlSBmbHC2r/GsB7nDT+gL10Fjo hEf1EKZstNijM+nJQ6uxLCOpDfswYgiR9C+jlpmV7mx5i+7GraFU9ANxfFgp8+Z0ggDlGYyc Lf8eaZ03zh4D9KnZnbfX0gD+1zJw== X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="40547795" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BRQVCnnwJ8L4T+RAQ0JB0TX5KlRs5wsCtR79MReFXVguIdtQYiQeHYMjkmcnBjpFiQIrQExmI7J8VXOx/14Iq9ixBgYFKrktrOFPbiB67GaB5PMd9ihQVKjPCgBOwgu8r/w7rJpNEDfho49i1s3bYIwLB6EGJDlAYf9Xxmm5C1KOtB7O4o/Iocqq1h3Ppn6byw1oBOKDEeIf9s8rjXPnz7wI/GgVKA7zo8PZxHoCIVDMq9i0S37MTqDOze4+7t8BeaxmaaeN8rAb65P1htomVTrqCH5E4HtkjntRkyzyEjvFbwPiJKBLcBaZG045RZFUupql7LELRCCmiX9ms9ug+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c2FAstd0dm59Kju/X4V60meqn2OKdaSyzGFeglxU81Y=; b=e8H+rnxjPxts/iveJFd0xrvBZptFGjaTtSaZ7jVgyH0Y77OXt8RoKRDcorFTPWGGeSW+BHPYwdX1uQlOkGhS5WMfU5AvWDsKzhjlS3Xr2haLtpE9S+DoBF9a/T8iOjj549w2c1b9Cbo+DG4U01dIb0it+/1xxSlgdEWQjoyalnngsf9SNhGY2VNIeWJfFQ8n2EG/32l1WdOIhAOVgeMt5H/odSqgF6Nf89u5YQ3fNja35ZSGSmGDg8vV/sG5lj/3DZmHZvN+6D9hEglSbx7PRGE0dw1x30icfBZ4+zG//W39dyEHAkpJmHpIvKCG6vnwE3PewYarYRqi6B2KpAEpGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c2FAstd0dm59Kju/X4V60meqn2OKdaSyzGFeglxU81Y=; b=oFpVmHcvAkPF9pwGvB24RDIg147MtPuVJuNZiAe0nPBOvjUJp6f1/a+MYU6wFgkT/LaTvnCDAysdggPaCReoCtrJdPGKaezd7nK5g0e3fy6OUHCIc8RptY8vx1uBMH6GyOk1pPOVxnrG3fBVW/wrM2GD+clOv6IWBEkY9k/YqXk= From: George Dunlap To: xen-devel , "xen-announce@lists.xenproject.org" Subject: [ANNOUNCEMENT] XenSummit CFP Extended to 9 April Thread-Topic: [ANNOUNCEMENT] XenSummit CFP Extended to 9 April Thread-Index: AQHXJvR5JYhNZD80kE+cotELBxeaNw== Date: Thu, 1 Apr 2021 12:42:27 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.20.0.2.21) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 26a618c5-eb11-4aa7-fa4f-08d8f50b9baf x-ms-traffictypediagnostic: PH0PR03MB5864: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xl1+bnPN/FAmKn/T+/e+8X8OFTeEJwihqspvQEg1PlsYjcNz9zViYxebgMLng89enWIJjpRA1H67Xop4gZyPDrHopfhxsAV5AXiJD/yT6yohLw7yj+RZk98yAALWE+wrTKjEcfUaShDTDTji+w2Ca3XOwXpgh+/SUDC3fz1u5UNH0eNsL6Ypo72XZyR+QW4pfOvGZuFMBndVZzy5sGq6zrCVyP9b43M0hBDi7K2SJG0XxmjtdcFsfCrE5QN6eBpBIIY5VlFmq87Dp2WjWsSPcoc+zMK5I8Xw/cBBpTSlJWBeNAbJe299uzyZzwoTwq2m0dQryeGn+6aH9tunYWMYvXFThSd315ivG93B4kPVhwViprNywyBMEBnHJQmVFkEFoNNwNPtHdBJS40PjHvr49/xDUmxQHA4v/2aw1i9T80Q4pYJfuQzy3+yHSUh02xwbJWgp+oHD49Y7pspHMDmK1Ecc9ZfCF0S/UxHlKCDF6XDJP7SUfhwkOn72jLZSQGjaQn5l/xcpW462SQJdysI2AzKLdHxxm//b14MGs9mRztXd1duFf10yqr3LMGShvM8neNE7PgcPWxT8/8ryo2HFNBuFyNoKK5cjMB7O1G6IflWJr85aXlC2z5VHNzFQvYCUTisjz3Af6LPe3erqDvU8ANsFBoiaUV4G8csbvfNs9I7TvjRrqVnnFtuvXDXYIbFB x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(376002)(39860400002)(366004)(346002)(136003)(76116006)(26005)(33656002)(8936002)(2906002)(86362001)(110136005)(6506007)(8676002)(186003)(450100002)(6512007)(36756003)(66476007)(66946007)(38100700001)(2616005)(66446008)(71200400001)(316002)(478600001)(64756008)(66556008)(91956017)(558084003)(6486002)(5660300002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?TtnFQZxff4Ctb0NIobWudCF8hiJ/8sUMRhzrYJss6/M6UL8ZkLJNKlM0fuQI?= =?us-ascii?Q?7RZHc+45LyN7FpkJ2r6fRNJkxfWuzlMnVYdJr1UGgy3e7EQngUmMvU69nuYz?= =?us-ascii?Q?w7BqYVP+jXPkHb/X8RQsF867JlAfxsOOtc/LHaeR0IRbYa1nSxsmwMKE1Vzs?= =?us-ascii?Q?tqvuFFAdwWFaU2FWTiVhFonKhBFViJU+CC83ZCoFqTOMX2yUT4e+7k82k4O4?= =?us-ascii?Q?htZuBRB+D1Ks0zEYG5YYpU176ld2jJv3S1X35RwWIxyhUsGmtx2u5Xm1eLXr?= =?us-ascii?Q?HeZhYt5IENvBjS+Gj5Fkq+5gVx4xZ+bCn60kshCUUeVTBKQKX2rhdTDCM/rm?= =?us-ascii?Q?iSHj1cL1Be38tNSM2X80x+OSUge8D4BBBTGwir81E5UZ3kcHE0quI9F+K7Ds?= =?us-ascii?Q?9g4kh5ZEhIV5HczMQAeoST7IwkX4eBYet4KdTrEcYbs4za7km7IzSGSbjVM5?= =?us-ascii?Q?oVc6lb8CjsdoHT/B53smpZClyQfzyBTW8AgQPybU3an+HGdmEmVljU7tvvE7?= =?us-ascii?Q?k5DEvVPBIOmIMT5OSMjEZZYEs7nOQuANIijTS88vfJ8NYGMR6K4ef3429yw5?= =?us-ascii?Q?XUzBejtp0+pLVTl/hPdY7eqeR+rcA1EmBasDcQpcI3rOC5pVm1kIE6HNueVC?= =?us-ascii?Q?Dn7vcWT8I7abAA11lPc1SL9ZxjfOq1HfjIR0enhoHY8mhYf0QBPRx7IxKS3I?= =?us-ascii?Q?UCrfu2L3jJrlpL6MflgA1Et8bL58EaWSDVNYCMggAmu180rteOTFMc+pJ7Kv?= =?us-ascii?Q?Rb7H94vduNK3B7Po/VjC7TMrQdrb+kHUx9vtLrQ1AxOZ13begyhz+Cw8SS2k?= =?us-ascii?Q?p9XoWfROA/ZZxhtBaL95LcTOD5zqhMshsEkF6Ce7SidRdcgV23lr+3ntMnSp?= =?us-ascii?Q?/6ETxXkp1D6FDfmwdsoYOdOsZRWWYnCe+Gj/zk3cfbTZ6oQkJNxSq84artYe?= =?us-ascii?Q?eO/+bqlVCGF+PFlND/WQXXPAPREdogMLnh9yrBDqEQhhcprSEGAbvS2pqdT+?= =?us-ascii?Q?bV+bTxG2zH+fdrfflilLIjc6JkqQTfXDdR83buw05EKgAq3iY8UNEqcZnAqA?= =?us-ascii?Q?pKrRnObUciYfKpQ26feBwPy5r0kVXNCkT4ntSr2vtDXaVOFuCP1iIEFt+9Vs?= =?us-ascii?Q?CVOi0EAPAJLxLPzuRuXgNp/wXrO1ZVrpoQgOxpwM/qwDgGJSofI1pNWsaUVL?= =?us-ascii?Q?5nkyaRaQFtU/fK9cOXoLQCyzKwhAx+d5euQqPydnjOgIyoCbXgNZb8LQzviv?= =?us-ascii?Q?vwDYXVn1QCgba3i82LNyar4xWPCEn5FRc/NanVb+Am1qMOWTsq5v8ySQyrny?= =?us-ascii?Q?3v/wotg0c2yson5v9cqwV4gmAzl45GYDWLViXK+3krtO9w=3D=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 26a618c5-eb11-4aa7-fa4f-08d8f50b9baf X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2021 12:42:27.7276 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +JQdQKB6XT6DT+VnNpO2GnEn5fP70gEbKwrlhGPDd8q2eJhuORZX/7M0A/QxjMwIt8GqylNdSu/1MOSG0tdyot7pgUw3IKgOBH4Eijp5GbI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5864 X-OriginatorOrg: citrix.com FYI, The CFP for the XenSummit has been extended from 2 April (tomorrow) to= 9 April. -George Dunlap= From xen-devel-bounces@lists.xenproject.org Thu Apr 01 12:45:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 12:45:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104433.199717 (Exim 4.92) (envelope-from ) id 1lRwhC-0000lm-RX; Thu, 01 Apr 2021 12:45:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104433.199717; Thu, 01 Apr 2021 12:45:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRwhC-0000lf-Ny; Thu, 01 Apr 2021 12:45:10 +0000 Received: by outflank-mailman (input) for mailman id 104433; Thu, 01 Apr 2021 12:45:09 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRwhB-0000la-5g for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 12:45:09 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a93e7ecb-6451-41a4-a496-3a6fdeecb0fa; Thu, 01 Apr 2021 12:45:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a93e7ecb-6451-41a4-a496-3a6fdeecb0fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617281108; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=Q5SvqruWEh86fsHbQhTT1l2XUOs2dVrfGE4EFDi2lHo=; b=LzA0y8AuqThiyI2943WupIeeeWn6IM9qjERCF8GqzfM6bdp0JxGcIezO unutXpKHPItRrAi5h0lAPdyXfCGuMYYZOv4VGFkLZ92tAjwjEQrNwIYR3 K3aLnDZUliaQSOqSnRDPJH2Ig0amdqW/NvznXOMqwQjq6tn5iswIqXWUj M=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 6OLotxVhkGUcDYlTwbbbwcs0wWb1nZNCXZrpc8tJjev88GUED73isIiTb9aNVQeZSZxgN9mxmS AY2EbKXDybnr3/OP6+Trf1q1x4o7oKsk1DrAiUZE8iqFYJnjdtnx2sYNjZO2ipKjoeB3XmITdB jKwfHvH/V0X2nHNH3S3pMtLiTYJWvtvNrBe6c9MBrrpDPsGJXFLTjYzbslVF4W2tQC5ON+rT4A vJQGEVTPdfRpVxgEVffQGJq4+7Yub0zrwpuszPS4s3msb1PR1YFOoq5zSe/h1mM8CuNgrpcRcJ ZSU= X-SBRS: 5.2 X-MesageID: 41066815 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:A2XP86jwXyJdBhGzcQ+oA2MjxXBQX3Vw3DAbvn1ZSRFFG/Gwv/ uF2NwGyB75jysQUnk8mdaGfJKNW2/Y6IQd2+csFJ+Ydk3DtHGzJI9vqbHjzTrpBjHk+odmup tIW5NVTOf9BV0St6rHySGlDtctx8SG+qi0heHYi0xgVx1udrsI1WdEIyywe3cGIDVuL5w/CZ aa+45jrz2vZXwYYq2Adwc4dsLEoMDGk4+jXAUPAAQp5BLLoTSj7rP7FBbw5GZgbxpkx7A+/W /Z1zHo/6nLiYDG9jbw9U/2q65Xltzo18dZCKW36/Q9Bz3whm+TFf9ccpKYujRdmpDI1H8Ll5 32rw4kL4BP7RrqDxyIiD/M/yWl7zo08X/lzjaj8AneiOj0XigzBcYEpa8xSGqg12MasNtx0L 1G0gui3vI9Z36w/1Welqz1fipnmUaurX0pnfR7tQ05baIkZKJMtotaxUtJEf47bVHHwbo6G+ pjBty03ocuTXqmaRnizwxS6eC3Um92NhmLRVVqgL3u7xFm2Fp9z0ce2fUFmGYB+J8XW/B/lp T5G5Utu7dUQsAMa6VhQM8HXMusE2TIBSnBKWSIPD3cZe86EkOIj6SyzKQ+5emsdpBN5JwumK 7ZWFcdkWIpYUrhBeCHwZUjyGGNfEyNGRDWju1O7ZlwvbPxAJDxNzeYdVwom8y8590CH8zyQZ +ISdBrKs6mCVGrNZdC3gX4VZUXA2IZStcpttEyXE/Lit7XK7ftqvfQfJ/oVfnQOAdhflm6Lm oIXTD1KskFxFusQGXEjB/YXG6oVVf4+b52DajG78kewIUALeR3w0wooGX8wvvOBSxJs6Qwck c7CqjgiLmHqW6/+nuNz2gBAGsbMm9lpJHbF19arw4DNE35NZwZvc+ERGxU1HybYjt2T8bcFh 9jt016kJjHaaC49GQHMZaKI2iah3wcqDahVJEHgJCO4s/jZ9ceAos5XrdyUSHGDQZ8lwoviG orUn5FembvUhfVzYm1hp0dA+/SM/Nmhh2wHMJSoXXD8WOGpc8uQXMfdyW0UdGehDsvQzY8vC w1z4YvxJ673Rq/I2o2h+o1dHdWbn6MPb5ABAOZILlPlqvTYwF2R2eSjTm8gxU+E1Carnk6ty jEF2m5aPvLCl1StjR93rzx+F15TGmbYnl9c2t3q4F7CGTAtEtiyOPjXNvH70KhLn85hs0NOj DMZjUfZjljwN26zza5sjePH3dO/ORiAsXtSJAYN53D0HKkL4OF0ZwcF/hP5ZB/KZTFqekQS9 +SfAeTMRL1A+4kwBauu34gISV4wUNUyc/A6VnA1iyVzXQ/Cf3dLBBaXLkdOcib9HWhaPCS0p l15OhF9deYAyHUUJqhxq7WZTIYdU+Wjm6yUu0yqZdb+Yg1r6B+GpHHUT3OkFFLtS9OWvvcpQ c7euBc5ruEB6pEO+o1UAhd9kAylNuOIFAw2zaGSNMWTBUItTvjI9iN47D0srIhDU2KmRvoNT Ckglpg1saAexHG6KUTBK0xK1lHcUQQ6Hxt++WZao3bYT/aPt1rzR6fMnWndqVaR7XAMbIMrg xi69XgpZ7aSwPInCTRtyB8OKRA7iKORt6zGhuFHapt/8ahMVqBxous78jbtka5dRKLL2AZj5 ZCb0oec4BqjSQjlpQ+1myKcZPMy3hV2Gd20HVAjV7i2o+v/WfdEwVnCGTi8+RrdAgWFGOJg8 TD+fWfz1Ln7lF+qML+KHs= X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="41066815" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fFNBtywWSXAM+eXbihiPCOYpRZDUvU1ttuFzCge3N0swjvYFQ4+kj128VGamAFwfCm9MRkfynSyqCUhuO5gDma/4gIBjgGptJ2F3EuQswui+QOW7hbI4EwVkwZOqOSkjgeJLs5kk+KmPH4sw+pzYUmjsnSsFsYomg652bF0G2YATDZYfOr5DhKMz6ZZstVV62awZmlM0iyc3w9auANt029Cf4EMzf9agBbLut99ln8Z3B5FTnEm/85ULT5Exc4Pwkj/HvMMq3jOkN/lWSWayjhJDMUMKmV2iSCVzmT7W0h1XQxXMbXII9XJX2gmgboShfXR3u54SaLjlntYoJFnk5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q94WzQ6SuSuvqMAlhYZcl9EGVF426lyxhYZHeF9slu8=; b=ES4t/n7FS3L1eIKZRG6VS3qluRtcL5+RRyRWb5vUxcONKTtyCcwWnw3DsEkX842a/oIG+N0Nl3oRuBhMOEli0laWkQSnq0pgKTNf9d+2wdXYKJO/wFZwlE/3Ys98QI2mATsdvwbJA82qAG7QqPeqV6eCaY32BkSa4YMaigSWMlYuEhUzvUkERJEJgAHsg7O8JtyWnMFJHbsrDZzhg4RzEC7zX9EwKU5RbOS8cnZFyIP45MCm5OduXyOuBo1mJMLcjVjKBcAgNS0lgMlJoAR6vC7qy69MKiNCSAPGqJBNDggH2t6Kc9HfPgdoyiKvJGrwz0rT7HRXC1zWl4g9R10UVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q94WzQ6SuSuvqMAlhYZcl9EGVF426lyxhYZHeF9slu8=; b=wPn4yO4ryIR/6L6wzZ/TjCRAChKm2zIKq5/iudQ05SBRdS2qLjWCgJf3tIf83GzxgdD/ANXW6XT8waRpk7byN8r5hvRd8kX7eqvKZYEs3oBnYVRjpYDDBMFRAVAU0x3rRU1G5nvmxemXOwiLwFDy6AdyTjU13C26npuxVS2REXs= To: Roger Pau Monne , CC: Paul Durrant , Wei Liu , Jan Beulich References: <20210401102252.95196-1-roger.pau@citrix.com> From: Andrew Cooper Subject: Re: [PATCH] x86/viridian: EOI MSR should always happen in affected vCPU context Message-ID: Date: Thu, 1 Apr 2021 13:44:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <20210401102252.95196-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LNXP265CA0051.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5d::15) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f146cac8-73c5-47e7-aae6-08d8f50bf937 X-MS-TrafficTypeDiagnostic: BN8PR03MB5138: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O/00PG380JJ7dXQokDD0BdVaCjQcM6t9QUvMTz0xg9tCZ4WizDUNLeOTtxvxlR6+n042hkueSXjq1zf/2VOK0e7VICBlrXRBJ4KDQO/2bAdF6a9/RscJXp76nCzZAyc16yWxQYgu4EZXJdd6nYf5D6lSELi8K3oR/29YQ/ZOauQ2sgVDras9X/LQ/HE8FPShIYbKpfyytmIZde1xAQUHc0KJGyf2n7qhOnQzMH30TE0e4i59n33plIZMGffLjvPfv5JdlNNSXektv1KTFZFtKiQxMNZNvGyWrOx4cGnPSvvijK/l4nOfOoNZNivMyvkxrUJwq6kSaJ0M311gTTZO+snNSn+yf3VepLHX1sGVuK3K1u8DxmZKAqnEijdbVf1o0dLzWt+GI0v9OoDBdsEzIWCS0YfuPfMU1ch/cerRMGbINR85S9RJZfKlqe8pf7J+m5uvk3Hf2GHWuJL0Onjo9JZ4G0ka8ZSPaPewcZQan2DmpDQvozeGxOLg6DnKQVM0rh8PzYTug+wVIR2t2BEEjB9u2q3nYVjLloXhwOa/AP3n57Hg2HrT/d+0o7A2t6m+aYmjsr/EjUoxIvBeWQZmM0HvcQY6jvknUdseVIqslWcDexGmBDg6fFR1gJbH05+iX0RL788ucqTGPqZvVkFpGFBwhAtEQbTGxgfHAIqC/73gQSq8OLwos0Oqx+RHNkyh2PHz+p5dKQM6Ayv44mHfdBvqz7npMwWRzcZhMsFkHlE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(346002)(376002)(366004)(39860400002)(136003)(478600001)(86362001)(6486002)(54906003)(16576012)(316002)(8936002)(31696002)(38100700001)(4326008)(8676002)(31686004)(5660300002)(16526019)(2906002)(36756003)(6666004)(66476007)(26005)(83380400001)(956004)(186003)(53546011)(66556008)(2616005)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?MUZtNVR3cS92R0cvUVlHaTFHNmhNZWxKaEVlOXo4S1NBUnNXRHBhTzFnbWdB?= =?utf-8?B?c21uZzkzdmlVL1FSelRzRDVpSmdrNnA0UVlOSHJKUGVyaW03ZXNGY1orUzVt?= =?utf-8?B?UWFLOFBKc05zNmhUUXVvaWRVWlNJRjRIeWo5bHNUMGlPaVM5cnpBOWdEbzBr?= =?utf-8?B?YnZ0VEpPeXczZzUveC9zSTdYODNoUG9oZ2VpdytFMkd6M2lyamN5TnY2dEJk?= =?utf-8?B?RDUycFcvQm5kNTAra2hocnhpakN3dS9KOGVVTThWdVEwc01qUXYraG43Vk9L?= =?utf-8?B?aUE2Smw0THF2bHcxZUYxMU5kd1ZyMm1JcmltVWpaZlFQR2NGQjA4MXFzZW1J?= =?utf-8?B?WkQrbFdVWFZWa2JQMFpKcWtZb2w5VEFhNnMrNXk0SHNDeHlXMnp2dFEwckJQ?= =?utf-8?B?SVdZcHI4R2pxV1laQWFnWHd0VGpJQTVNNWtzMkY3TUJtZGdUWjJqUFdUS0ZD?= =?utf-8?B?K0Rkb3kzL3hkbFMzZTV3MVlCcVYrVVNwZ1o1U0ttdWtSc0doYlFpREVtVnY0?= =?utf-8?B?QURkeGtsSjM3dUZhc3lpcUZkR3BXWDdzWXREYjlPQ1BHbUdxa3JwellxWXM4?= =?utf-8?B?SGEwM3MzTGd4Y3ZxWUIwYzNoTkZSVjIyZUxqV2pQYXIyUitmb092UnZTV0FN?= =?utf-8?B?NEE5SFZvcHRmODA0ZU1VM3FUUzhXSVM0OTJGenU1R1c0R0ZDUUhoaTZXREpX?= =?utf-8?B?dUJnRmlTN05KVGREenJqWFU5Y3lDRmNCOXVZV2o5cnFrRFU1V1NzWE5RbDhi?= =?utf-8?B?TXlNbzZBNjV2a0wyMDg0cUkrRWR5T1ZMNlF0S0lWbVJDQ0hmMnRZakVVd3FZ?= =?utf-8?B?Ry9Ub0lodXVqaTd3b0wrZnd3V1FVem9leEdielJSOCtQRVIyMitCaG5RUVRN?= =?utf-8?B?aGJVSUJNaStqWlhXdU9vQnpiUE9DeGhxTWJQejQ5TXJINXRENFhBaGs3dVZL?= =?utf-8?B?NXBaY1JqY05GOWtNSERwS3dIUkpOY3pYbjNCc3pVSGhsRlJqMW5hdndTbG93?= =?utf-8?B?dFlwVEdxVGQvRHNyaE5Cc01NdndwVjgxb0ZybWRLeTVNS21MSndDUlVZd2VK?= =?utf-8?B?WXBGa01aZDlwNjI2eWJoTEVqcnBPalZBSnVaN2ZPbndDcHpsZytTYTZqbFR3?= =?utf-8?B?eFJkdVRRS3R2T2t3aWhYY2tyUmNmVmJUdHQvL0JDOGlCeTlBaUpubVpUZGVN?= =?utf-8?B?UU1WbmlKeWlVODRpSkRHb3QzeDl2cWs5UFF4YTlEVGc0TC90WWJweWFqRWNV?= =?utf-8?B?MUZtQjBCWWlzYVVqUEFEbCtiTVR2UlIrN1JOSzlCc2RKZHBLcHMzdDhuWmMr?= =?utf-8?B?RFlsRjZibU9zaGkxZ0pjaGVQR0VZU0R5STRiak9hdW94KzNtU1VGV2ViWjli?= =?utf-8?B?QkdFYVpwZHgwTjFGeWwvWHZHK3NJVENyRDJSMmV4Qy91R3d5RmNhYzBEOEs4?= =?utf-8?B?cStaTzJPRnJPVzNOUUhRakZVZVdpajlBVmhzN1U1cW9VYXd4NnMxRWlqRnpF?= =?utf-8?B?Zm9MbkNTTzlNQWs1REkyRnY2U1RWaUJ2czZSZEV0TGxqZmdOV1dQT0w2ZjJM?= =?utf-8?B?UWNQNnEyWkN5dWdRQVNXMlhEWmpBTkpVVXNVZTVxemxtTEFYd2JzV3pTbFF5?= =?utf-8?B?QXo5RFZLbVRNL2lkUFRGcnFSc1IzamZVQ21RYVZsckczRmp2ZW1vckNjQmxT?= =?utf-8?B?VWZkZURPcXlVTWFMZ3pzZWRPT1poVnpSelYvSUZhblVtRExkRnNjWkUzTVgy?= =?utf-8?Q?WKn853SokbIXpFUN8W5s3NLdXiDcaejfSMmP4Uo?= X-MS-Exchange-CrossTenant-Network-Message-Id: f146cac8-73c5-47e7-aae6-08d8f50bf937 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 12:45:04.9124 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: m7YfYevSUkkX20NeuDE2W5gabYv0rxySK220iyniflL3iPMnV49TJ7lPnOYXSqlwatnaCvJWotdgMnFksP6md6RucpMh+t5TT1WYHdk5Zto= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB5138 X-OriginatorOrg: citrix.com On 01/04/2021 11:22, Roger Pau Monne wrote: > The HV_X64_MSR_EOI wrmsr should always happen with the target vCPU > as current, as there's no support for EOI'ing interrupts on a remote > vCPU. > > While there also turn the unconditional assert at the top of the > function into an error on non-debug builds. > > No functional change intended. > > Requested-by: Jan Beulich > Signed-off-by: Roger Pau Monn=C3=A9 > --- > xen/arch/x86/hvm/viridian/synic.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/x86/hvm/viridian/synic.c b/xen/arch/x86/hvm/viridia= n/synic.c > index 22e2df27e5d..e18538c60a6 100644 > --- a/xen/arch/x86/hvm/viridian/synic.c > +++ b/xen/arch/x86/hvm/viridian/synic.c > @@ -79,11 +79,20 @@ int viridian_synic_wrmsr(struct vcpu *v, uint32_t idx= , uint64_t val) > struct viridian_vcpu *vv =3D v->arch.hvm.viridian; > struct domain *d =3D v->domain; > =20 > - ASSERT(v =3D=3D current || !v->is_running); > + if ( v !=3D current && v->is_running ) > + { > + ASSERT_UNREACHABLE(); > + return X86EMUL_EXCEPTION; > + } The original ASSERT() was correct - both of these are easily reachable in control domain context. If you want EOI to not be used, you need to raise #GP from it, but that in principle breaks introspection which really does write MSRs on the guests behalf. It's perhaps fine in principle to leave that problem to whomever first wants to poke this MSR from introspection context, but the ASSERT_UNREACHABLE()s need dropping whatever the introspection angle. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 01 13:21:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 13:21:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104451.199749 (Exim 4.92) (envelope-from ) id 1lRxFr-0004Tb-2k; Thu, 01 Apr 2021 13:20:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104451.199749; Thu, 01 Apr 2021 13:20:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxFq-0004TU-Vk; Thu, 01 Apr 2021 13:20:58 +0000 Received: by outflank-mailman (input) for mailman id 104451; Thu, 01 Apr 2021 13:20:57 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxFp-0004TN-6P for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 13:20:57 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b4392d44-e5ca-496f-b9c7-2de643c40e69; Thu, 01 Apr 2021 13:20:55 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b4392d44-e5ca-496f-b9c7-2de643c40e69 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617283255; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=Ot1NR4kkHo35XY5Tw4cWLBaToELK32ub+ZiUd8PP1KI=; b=d54GNFsppOz9iFHg08pv6V/dB+JoP5Y6mo/ZLuy8JXUkUq54zBckJKot osvIlYn0YR+YvpvPkS4I7E6nOGA8eZB7nyT6yr+B8uxsfc/Vn7DQn/wKv dE9Q5hmJP+zv1+1dfVifR5UNomDDWLbVXN0i790tzkFxCvwLtmOlMSsHb w=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: mJryrkgdok5c80cSLcrSnpJOC0vh7kSpkZiFqGFwkqi6UvK+L7hed/H4KxM1CzmKEufEEf/X5j TzdBC9jX1y/NT9z9G+mQp1mdnA7f4rqHuO5d8/ACH6bC6LhX62nOPGs+ek2xBULTZk33UNQtq1 7DDpYICwWd6xqi79VcmEX1xJNyJNKKonPIM66fKbxrKi38eTVxa12AIXrtw3EBTFrpN0ZKJyNM Yi48d4COgGHn08inHlZudWHDcMJrvLG5X/CQkmd+xvf0xcQ6KEhIbDVbZjmTFo4YzPSCoAR5xI z0E= X-SBRS: 5.2 X-MesageID: 40555887 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:/rmui6vkQ73CWQaucu7UOrth7skC2YYji2hD6mlwRA09T+WxrO rrtOgH1BPylTYaUGwhn9fFA6WbXXbA7/dOj7U5FYyJGC3ronGhIo0n14vtxDX8Bzbzn9Qz6Y 5JSII7MtH5CDFB4frSyBWkEtom3dmM+L2pg+Cb9Ht2UQR2cchbjztRICzzKDwTeCBtA50lGJ 2Aou9OoDS9cXoaB/7LeEUtde7FutHNidbaehYAHREq802jijmv5b78HXGjr2gjehlIxqov9n WArhzh6syYwo2G4zL/90uW1ZRZn9P91sBObfbstuE5Iijh4zzYH7hJdKaFuFkO0YeSwXYs1O LBuhIxe/l0gkmhA12dhTvI903e3C0163nkoGXo80fLhcDiXjo1B45gqOtiA2PkwnEttt19z6 5Htljx3/E8YGKi7UaNk+TgbB1kmlG5pnAvi4co/htieLATdaNLqsgn9F5Vea1wbx7S0pwtE+ VlEajnlY9rWG6dBkqp21VH/MahRTAaEBuAXyE5y7ao+gkTtnV4w0wE/dcYj3cN+bksIqM0l9 jsA+BGkqpDQdQRar84LOAdQdGvAmiIeh7UNnmOSG6XWp0vCjbokdra8b817OaldNghy4Yzoo 3IVBd9uXQpc0zjJMWS1PRwg1HwaVT4eQ6o5tBV5pB/tLG5bqHsKze/RFcnlNbli+kDA+XAMs zDeq5+MrvGFy/DCIxJ1wrxV915Mn8FSvAYvd49Rhanvt/LEIv3rebWGcyjZ4bFIHIBYCfSE3 EDVD/8KIFr9UawQEL1hxDXRjfDYUr60ZVsELXL3uQaxYQXX7c89jQ9uBCc3IWmODdCuqs5cA 9VO7X8iJ62omGw4CLp4gxSS11gJ3cQxI+lf2JBpAcMPU+xW60Eoc+jdWdb22bCAhd+SsjRAT NOvlgfw9PwE7WggQQZT/63OGOTiHUe4FiQSY0Hp6GF7cD5PrQ1E4ghQ640MQnQDRR6lUJLpQ 54GU85b36aMgmrpbSujZQSCu2aXcJ7mh2XLcldrm+ak16dq8EpTn4yRCWvTsaTvAYrS1Nv9x hM2p5apIDFtSekKGM5juh9GkZLcn6rDLVPCxnAWJ9ZgYnxeAZ7TX6DgBuTjx1bQBuyy2wiwk jaaQGEc/DCBVRQ/lRVyLzj/l9PemKBRE5ocXxhvYphFWPJh2Zr3YawF9+O+lrUTmFH7vAWMT nDbzdXGA9oytyt/DO+mTqJFxwdt9gTF92YKI5mX6DY23urJoHNqLoPGOVM+o15cPr0tPUQbO 6ZcwiJDT/xBu8zwTaJrnI9NCQckgh9rdrYnDneqESo1n82BvTfZGl8T7YAOteG8izKQe2L3J gRt6N8gcKAdkHKLviIxqHcY2Qddlf9oWuqQ/oprp4Rl6Qor7d3F4TaVzyN9Hwv5mRJEO7E0G clBIJ86/T9H6UqWeo4USdQ5EAom9SCN1FDiH29PsYOOXUWy0bGNNaI6YfSobUhAke9tBL9UG PvhBF1zrPgZW+/zrYUBKI7HHROZGU94Hpk+vmed4e4MnTiS8hzuH67OGS6arlTVeysHqgRtA 9z57iz7qOqXhu9/ADbpj1gJK1St06hXMOpGQqJXcpF6cazN1jJoqyk5qeI/XjKYAr+T0QTno tec0MMKuxFlzk5lYUylhGIdZafmDNvr3JupRd9llDs3YC64GDUWWF+WDep86l+bH10KXiHjc PM7O6C8m/yiQI1gqX+KA== X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="40555887" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mLLnjO1dPcifTSOHaIGs8xIisJ7GBNJ4ftASX4+aUadtB9ZIWhr/XmwRd6BSMqG7BQMzfSCjrsiI8lNuSqdxLqbqLG0sHmJGf/DPeczg1h04Wi8CpRvoq9qKFwMxS9C7uPvKJkGgzamTAAyc8v+bUtWdYW8sCnHPoy52Z/ZIP7yHztBbq2VvUNaEQmLbGI8fnqzalRXOCrCpojgEHLY9N9hXZwL1iKvaVxXrCRvNdesfu4gYxSGppnAUIaUTtNq4jZMCxRxhorefWIndERRzN75UmVEw8Qpr3u/94BVcprJ537JwbgFPkjfk9P3EEd308+dlwM0zH4LWgxiJI4v9Fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/OyQ2vrdQax1SqwU6XUja7IVbjW+nUkz7HxDGveAYrc=; b=ZPg2PrUgUKNdBUlRz9V2R1cw6lUe+cjYllO8p22jeIH8HoXcALQ5BLi1/xOS3EcoX5iAV9k9fwkHMH4DUG7kIZwxsiR0zdT6MkpYNCQ0MxRdon9SvwvSt27HEFc9iYOWq8on3zD46AQZYUXzDoMd//shEdMu7R3XwFps2ywYOgg7uhR3H/CX8+aYhdVDkPEvPmdbHfpi55Z+IfSjkAg+8/xy0UPE5VdV5pqYP9LtOHQPMJOXd4IS53NhSmR+KQBM3mhdI8dUaKcwpPpdQqb+vuoEwkeNFW99hrySUN/Cxt+G0YHKgQ7HIGNVML5ZbCu1XRDRV2fZkhbkXXDl+P0fhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/OyQ2vrdQax1SqwU6XUja7IVbjW+nUkz7HxDGveAYrc=; b=lKaGnBY74GKP9LpFkktQ7jDV2UcqY+FJ9vDfhFkKX4uHSs6J7rauxiv+m3JQmttTvOSPWzOBqOh/fA25aYG5yGNsXdgKJGyMbU/ud9SacYSk8TCo/9YOz87sWYGWpSv3V3CCv84mEpsS9fgPyzn4A3dVnbTFWk8FiFhLrQv+a1w= To: Jan Beulich CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20210331133125.7072-1-andrew.cooper3@citrix.com> <95d8688b-2e54-ae02-09ce-45203959e08a@suse.com> From: Andrew Cooper Subject: Re: [PATCH] x86/hvm: Fix double free from vlapic_init() early error path Message-ID: Date: Thu, 1 Apr 2021 14:20:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <95d8688b-2e54-ae02-09ce-45203959e08a@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0053.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:60::17) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: be416b3d-b446-40e0-1cd2-08d8f510f8cc X-MS-TrafficTypeDiagnostic: BN8PR03MB4801: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7rKxCIc/bbBMVgebxX/S4RSdj/vHo2dOVL5DBrcrSYn2zYSdiquQ2g22u5QzDZpoTItgMz+yDMoJO11XnJuldXEZfSe05sffKBDpdBStng00v4Xrn+nN8kS++xbUU5f/NKSLPdL/8dnJThMk3pD+jE41W2DMMeqa5fgTwKzA+wtRtsPdETzSwHBzDUoZmWtERj4gKdn68QpJWK98hu9aH/2qZ38X94doUbvXx7L1hHuemstiA4uye+8PyTJ6kOdWkcFtpOOExXl2w2R0OCh7ojrvdYJQc4uWxKKIOCCKhthjkfuSc6vbLAGYSVgd3GkSw1mk/NMeoVUJjQWIuPsA1hqic4I+tLeD94QBZH5kSrxDmFyKylwbe4NJ8F+1WqaOifWnGfQRbg6bW1NJV3aJVB6Y1/cVMmvMsDhHZ6WLGGkcQH9VaJxZS0t6pSt5ewoI96YlHfmnwrlzL8E/uw3+kUumqMv1kc+FLxwISxmkhV5YogivetPlJ0mJhIBOw7cKPFjC3gFmDN8VEa5ycQLp+YeiQaLrM3k1lNNv8TouPKl/16hzhc4Vu4KaG80m86gCoy2d4UW1aPKRG8cPUVpx8qtSMTSrIWKBsiRpOa1DBj3hKHOL9EBa+pxCPI4VE4WgWw4rJ4CGLM0AM9j4e7HPBBLPSMq9i9LlVyvd0sfOjSycidcYk8XYdvEnbf35Vv49YLn5FtZsoJ8F0TI32hXKs9ZifNiwoWgGZOtEUUw6IpA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(136003)(376002)(396003)(366004)(39860400002)(2906002)(6916009)(86362001)(38100700001)(66946007)(6486002)(186003)(16576012)(316002)(54906003)(83380400001)(26005)(53546011)(16526019)(66556008)(5660300002)(478600001)(4326008)(8936002)(8676002)(6666004)(36756003)(31696002)(31686004)(66476007)(956004)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?dXc1aFlZMm1YYnViTFRlb0h6dGlVdUxOeDh0WnJaWGI4VHNsZiswN0JYN25J?= =?utf-8?B?eVhyUWxRS2drL21jU082Vk1md0cyOTZoYnNLRzVjb2ZXUEU4cUFzRGkyVW9M?= =?utf-8?B?TStlNzRkOEZWblpQWjExN3VvSUl2bzQrSEp6Z3lWNFN4TUlHQU1ZUjBOVzBF?= =?utf-8?B?SGZiMS8xM1JuaGthb0xHZ0crSFpNc1NUU2dVUTAzMmpmQ055MkNreW9DUHpT?= =?utf-8?B?TFZrYWkxWml0ZS9DYmRhMXpZYVRJMVl1VXA2UUFRUUZtMkdXdFB6cnNGYUhw?= =?utf-8?B?cHJDN1RoSSthVldxZFZUNlJvdldoTHIxNmU3WiszTzRDbFJPMDhib2JlYVkr?= =?utf-8?B?Ujh5UXlqRHJyb3l1QVhNZGhrbTQ1dGNlejd1SmpsY1NHcU1XY3JPMGxjenlC?= =?utf-8?B?SVhmK1YxeWRESjlTL2NoNTZYVTBCejZmbFM4MVpScXREMDdnVEE1VXlyUnNX?= =?utf-8?B?MWpFQlFQV1NQUm13Y3BkV0RzLzRnRGxGRUNPbzlia3hjc0dRNE9ZYnJjeGR5?= =?utf-8?B?ZFFHMDdocjVnQUtKUHRzd0thU0NtMVBTM0ZOZ3RZREZvQkNzOFVqL2FUMUYy?= =?utf-8?B?ZTA1OUlMQVBqSTZXZVBYSFEzdlcvV0txTGVLSkRTNVRGb3J6ZmxrZlRtaVRN?= =?utf-8?B?UGc0QXBOTFBNMjdqaEdLK1pwL1hzWVh1NHUxK3dpUjNNVjM2VW5GWVEreW9O?= =?utf-8?B?WE5LTE1VbEtvZE5tbHRxeU9lRThPVkJHMGNPUzljb2gvenpKRGljcURNdVkr?= =?utf-8?B?aDZLNjZ0cENNb2I4RDRRVDhvdEVLenUwYXNCUm1NSzRETzVzY0paa1B6dHJr?= =?utf-8?B?TkNsa3R5VFk0Y0VqUE53UXFTN2dvS3BnOHBpSXNQWndUNDBueEk3R003VDht?= =?utf-8?B?N3N6amRaVklsRVg3ckZQWVZyU3hIblVucDZweFZrYUswNHp5SjlCVFJOYjM4?= =?utf-8?B?MWR6cWdpU1FiK2dScVJJbkpTUVRMNTIyZno3OXdzZ2lEbXl0Z1dTQytGOGNO?= =?utf-8?B?Z3FtMHJrMVNSU3ZpcXd6UTJPbDJyRG8xV2VwT2ZKOXFaOGg2SXdWU0pLdUFY?= =?utf-8?B?bnd3ZldVaytmRmFhMHhUUGlVb2JncEV6d3lKR3llbERqdytyd2VGU25zTTgy?= =?utf-8?B?NGdBQUlMMWM2V3F5Yk9rTXdGWGh5dWk2OWNlVW9UUi9PN1BzKzFRTGc5T05G?= =?utf-8?B?bHFITm9wZ3dCb0lFMG1sakU3N1F6MXhDQktlOHljU1drSGpYdGk1VUVsWEly?= =?utf-8?B?S1Y4eG1xb2tzY3A1d3lMRFVPR0p6dk5tNWIyb2JuSXdhMHBpOFpsODBFSGNL?= =?utf-8?B?bWpTeEprNzhmTHhNZXlLTUV6L3h4RW12cWtkMlhLS0V2a2xBV3BHc3kxY3Bs?= =?utf-8?B?R3dyNzZGaGozVnVxYkpLRytrbEthQkxLUkN1RW5HVkhiMDhZSlFEMEZ1VkdG?= =?utf-8?B?cWYzWkh2WGZzWGVYWC9mSGZsOGYxZVdBV0M5R2VTYUpweG1DVHJqZ3l6dVJ3?= =?utf-8?B?ZFIwaXVuR1p5OTJQakRDY0JyWXhxcWx3TGM0UUNkUmdJWXYrblJhT0M1S213?= =?utf-8?B?WTJmYTBvNStPYVBOYlhaeTdmdnV5OWdkSkdmRU14dkJMWHlJcUZHQVBKZThx?= =?utf-8?B?WnYzR2VOZEFYeFVMUHkvT21iMEZpT0hZMCtsYTRjdWhJYm0wQTVGaHppU1Rv?= =?utf-8?B?TlNGaHBKbks3ZE9iT2dGQlJTdlRQU1AvbjM2QkJzR2RoWEdNU2JuMm1SQkRX?= =?utf-8?Q?Xsjy9LQvKFfenZCqH/dH5qrVX961SuImBUrwlpO?= X-MS-Exchange-CrossTenant-Network-Message-Id: be416b3d-b446-40e0-1cd2-08d8f510f8cc X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 13:20:51.7871 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BwZbrG6EGFslqxZX/eMZYk6zbW9ARDlZglLfX9oGdFywGrrTVgC4OSnNPNYaoHSqzsVCRrBCOSXxrMGPwUtM91J8MMtB34Xr8B495yAjdM4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB4801 X-OriginatorOrg: citrix.com On 31/03/2021 15:03, Jan Beulich wrote: > On 31.03.2021 15:31, Andrew Cooper wrote: >> vlapic_init()'s caller calls vlapic_destroy() on error. Therefore, the = error >> path from __map_domain_page_global() failing would doubly free >> vlapic->regs_page. > I'm having difficulty seeing this. What I find at present is > > rc =3D vlapic_init(v); > if ( rc !=3D 0 ) /* teardown: vlapic_destroy */ > goto fail2; > > and then > > fail3: > vlapic_destroy(v); > fail2: > > Am I missing some important aspect? No - I'm blind.=C2=A0 (although I do blame the code comment for being actively misleading.) I retract the patch at this point.=C2=A0 It needs to be part of a bigger series making changes like this consistently across the callers. >> Rework vlapic_destroy() to be properly idempotent, introducing the neces= sary >> UNMAP_DOMAIN_PAGE_GLOBAL() and FREE_DOMHEAP_PAGE() wrappers. >> >> Rearrange vlapic_init() to group all trivial initialisation, and leave a= ll >> cleanup to the caller, in line with our longer term plans. > Cleanup functions becoming idempotent is what I understand is the > longer term plan. I didn't think this necessarily included leaving > cleanup after failure in a function to it caller(s). That's literally the point of the exercise. > At least in the > general case I think it would be quite a bit better if functions > cleaned up after themselves - perhaps (using the example here) by > vlapic_init() calling vlapic_destroy() in such a case. That pattern is the cause of code duplication (not a problem per say), and many bugs (the problem needing solving) caused by the duplicated logic not being equivalent. We've got the start of the top-level pattern in progress, with {domain,vcpu}_create() calling {d,v}_teardown() then {d,v}_destroy() for errors. This top-level pattern is also necessary so we can remove the need to put partially constructed objects into full view of the system, and wait for a subsequent hypercall to clean them up.=C2=A0 This series of bugs is still active, and there are still a load of NULL pointer deferences reachable from out-of-order toolstack hypercalls in failure cases. We've also got some subsystems (vmtrace) moved into the new pattern, and some minor parts of existing mess moved over too, but the end goal is to have exactly one create() path and exactly one cleanup path, so its impossible to introduce mismatched duplicate cleanup logic. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 01 13:33:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 13:33:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104455.199761 (Exim 4.92) (envelope-from ) id 1lRxRa-0005TB-7d; Thu, 01 Apr 2021 13:33:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104455.199761; Thu, 01 Apr 2021 13:33:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxRa-0005T4-38; Thu, 01 Apr 2021 13:33:06 +0000 Received: by outflank-mailman (input) for mailman id 104455; Thu, 01 Apr 2021 13:33:04 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxRY-0005Sz-F8 for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 13:33:04 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2b51ede2-3768-4e82-96cd-66e5c45d1d2d; Thu, 01 Apr 2021 13:33:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2b51ede2-3768-4e82-96cd-66e5c45d1d2d DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617283982; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=WgvTekEWeEc0gEBpw9NIx3wGqTvh7izwE7TdeeV+6tQ=; b=NBPbPwx/jtpyGmn6T10z7fxqGQVx+ZPgQZaOZQRSN2cRNK7Urk9aSXOK C8r5q3H+KHNEDshnwK0/gnifYWF74yhukpH59Ou1KEwWOiPWverFo+0Tg CPeqEnwMk0HSfW1WntmhS7cf1ivbcNzgrInSM5p6tfH63ZmfK+PdpXG1E Y=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: t6PBrsHe+O5PWQWBtko7Y1XG1ug77vd2m5wkV+9Kh4jLt8tlA5XkpH5rg9u0Hu+nnypskeO63z EuVq+dG9b7ss+OopeI6KA5gyGATvfWF6AcjwUGFOum+A8HlUN1V6N3+QlasUhQyTbY/+gk4wZF zlVV6Ov3cFwHjjgh/b/QWu1BJe/b4tLCdggg4UqqU0yhPKw9xUj1FTAb4CBzMYbz8OQMUXRONY Ntgq3YLGR/6XNZmmcbd6PTvY93wfU04/L3vnOhdqbXsJmMMXU4TXW1urSTGTCvXvBAvQ34XcNy ay4= X-SBRS: 5.2 X-MesageID: 40697609 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:FFlMn6+N9qxkUzy3SCluk+F1cL1zdoIgy1knxilNYDRvWIixi9 2ukPMH1RX9lTYWXzUalcqdPbSbKEmyybdc2qNUGbu5RgHptC+TLI9k5Zb/2DGIIUHD38Zn/+ Nbf6B6YeecMXFTkdv67A6kE9wp3dmA9+SSif3Dymp2JDsKV4hLxW5Ce2OmO2dxQxRLAod8MZ Ka6NZOqTbIQwVpUu2QAH4ZU+/f4+DRnJX9bhIcQzIh4g+CjTSngYSKbySw9BEYTj9J3PMe4X HI+jaJm5mLntOa7lvn12HV54lLg9eJ8LV+LeGFl8R9EESVti+Gf4JkMofy2wwdgObq01oylc mJnhFIBbUI11r0XkWY5STgwBPh1jFG0Q6Q9Xa9jWH4qcL0ABIWYvAx/L5xSRfS50o+sNwU6s sitAj4xvkneC/opyjz68PFUBtnjCOP0B4fuNUekmBFVs8mYKJRxLZvjH99KosKHy7x9ekcYY 9TJfzbjcwmE2+yU2rUpS1GztCqQx0Ib2y7a3lHkMmU3z9KpWt+3ksVyecO901wha4Vet1q4f /JPb9vk6wLZsgKbbhlDONEesevDHfRKCi8f166EBDCLuUqKnjNo5n47PEc4/yrQoUByN8XlI 7aWF1VmGYucyvVeIOz9awO1iqIbHS2XDzrxM0bzYN+oKfASL3iNjDGYEwykuO7ys9vQfHzar KWAtZ7EvXjJWzhFcJixAvlQaRfLnEYTYk8pss7YVSTucjGQ7ea9tDzQbL2Hv7AADwkUmTwDj 8oRz7oPvhN6UitRzvWmx7Ud3TxelHu3J55HaTAltJjjbQlB8lpiEw4mF657saEJXlpqaotZn ZzJ7vhj+eaqACNjCL1xlQsHiAYIlde4b3mXX8PjxQNKVnIfbEKvMjaXWhT2XCANyJuVs++Kn 8Zm31HvYaMa7CAzyErDNyqdkiAiWEImX6MR5AA3oqO+NniYZF9Kpo9QqR+GUHqGnVO6EdXgV YGTDVBal7UFzvoh6ngpocTHvvje951hxruB9VVp3LZvUC1vtouWXMfYj6rXaes8EQTbgsRom c0374UgbKGlzrqA3A4mv4EPFpFb3nSPKhLFz2fZIJfmqnifSZ5SWviv03dtzgDPk7Rs2kCjG 3oKiOZPdXGGEBUtHxj3qH2y19sbWmGc0Vsand1jJ1lGQ39ywRO+N7OQpD2/3qaa1MEzO1YCj 3DbDcICi5Fxty81neu6Xy/PERj4q9rEv3WDbwlfb2W52ikL5eQk7oaW9VO+ox+CdzouugXcO 6WdgOPNgnkA+cx1wH9nAd9BABE7F0f1d/40hzs62a1mEMlCf3JOVJ8WvU1Jcqf42WMfYfA7L xJyfYO+c2+PWX6ZoTYleX5bztfJgjSpmDzZecyspxQtb8zsrw2P5Sza0q+6Fh3mDEFaOHznw ciZY4+xpbrEIpmZdYTdCJU5UBBrqXFEGIb9ijNRtYjdlQshULBN9yH47D0uaMia3fx0DfYCB 26yWlh5P/LUCuI6K4CB48xKWpQblIg6H4KxpL1S6TgTCGrffpE5ly0LzuUd6JcUrGMHdwr31 tHyuDNu++cbCzj3g/M+RN9P6JV6m6iBee/GhiFF+IN09u0Pz238+eXyf/2qDf8Uj2gbUsEwa VDaEwLd8xGzgAYs7df6Fn7doXH5mQ/k1Vf5jl7llninqieiV2rY31uAEn+mZVZXT5aL36Sq9 /KmNLojEjA3A== X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="40697609" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IdJWk2NxmslbdkFUGevaTWX8KS670H95SOb0WzGHt4WFGHoryjb26DIZsuqAIQ+82Lpp3SwN9XJb5Y/6+9jc21dQ6BqjMU2aJ8QK1ALfEPWYdeDXqRDUoB9Bkw6IZh1a/lJhpiHT66uKL6/AS4NGQL5ddReyB8GIdOoVkfQgCd92U89gU4U6cmGDXSs0cV0wGNusI+uIeMV/u1+lZ8/2IH8nIs0SD3eCvHBxpkpbfuO4pNGM4h3IfIHq87NylWH+qAc8NFpt9+3g7rGdIQPMVCZivdYAR+0yW2d1Ual28vp8tsURdNVDFlsRJbznfbX2NQUd9hNK9Rvjw3mB2mjaag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yqhfqYHbcZHVO7ustC/BjskR5c/CovCVK45ufO95EOQ=; b=Np4CGdeAKD/5c8ss8INDHHBjvpgkQ6xmouRfsK1dfo9oOvIdlZshTbof17OLpUFXZyRFpLsNfG1Uzx5GwjEGXMmndODgXqM5iE5mGJi5wBMoch0ow8oNpLExMBjcLKfgU6XqKexF0QMjIcZEmv8Lw8d/jb7ll3BuFmR3tsnqTlHc87PCqydvtBvM1AIDHC3cvEAag4i00FIW3ah/JGRX6Haj+4go0wssvsF/Cgkv725OcY2LmbwZricjzAY45R+n+NKUDrSAFAG+3wBLJ5xXzBafu4S52dRhLcDcO9VuHm+3SqVTvWaB9Qk5dH8K32xeeU/HhHiObt2GG7GXbGhorg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yqhfqYHbcZHVO7ustC/BjskR5c/CovCVK45ufO95EOQ=; b=HkFwt6o4w0Gx1sjwVlMvhY772pamacqJyM/M73VeBAkmZPDmfoxuJ6w7Nwkv2x0DS0kLTdWEYr2LAvPts9FdK5QB2AWPCK2DlLQcDOquQvtQAf2h5lIbgxb7yBGT2Ph97A80vZGQDYLJRzY/NT/nPN4QcYeLDMRAip1EdMa6tOk= To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jan Beulich CC: Ian Jackson , Wei Liu , References: <20210323095849.37858-1-roger.pau@citrix.com> <20210323095849.37858-6-roger.pau@citrix.com> <87d48996-6b8b-d801-c43b-30b919244fcb@suse.com> From: Andrew Cooper Subject: Re: [PATCH 05/21] libs/guest: introduce helper to fetch a domain cpu policy Message-ID: Date: Thu, 1 Apr 2021 14:32:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0166.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18a::9) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 662a7b76-68df-464c-b82b-08d8f5129db6 X-MS-TrafficTypeDiagnostic: BN6PR03MB2515: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aamXuZBm0H6zp58xvnaj3Uue5NTr7/kqYT44iO3a8TPRruaQAlO1RhXVplWzlSmiNxyE8u5u3MxVbifksIRLsrnLPiMJFVq31ysSRC8M+uFNC7kIGly4mSJqc0tpjhla6Av78tPoP7FNWy69JoO0r0gacrhR19hWDG+Sp6Oz8sI2yB7Wqr2+WoJJ3zAth2z2ttxhpOaNZMspxnTJQYSpGvy6N2wjByg7TlzHty0wNvlvJnqdnuFjXeZKDK7Qg0UrUnP64MERPX4FnF4K8AHIOPrR3l/jfb1t0ULUYowILpT+5CLmtQ8cDkQY7NtaV08QrpCGMe8J4AhGZ4UNQK7z2sXjfsyUpVDPwpANdpMEjw5FGfVQ4JSh8uSLa/I6ODzlHAkL5ewSamI7EuOpLxhbpy4pApWwbY0L8W5kLaQJugAT3D/IeBTHs+YvTL/Lmzv1wElqm8AYTtwf1GNe9rzOLbrDQJefVg8U54DBCqPFst7ZBsgiJbBiVKE/2yuYFpuSulkf2jOE0E4AZ+fgB3h62xqycVQctlh4R0IQ7hnsLVD/VM/b22OE1BX2KVUyucyVlBABQp4jlqzlnW/glp6/rSYtSYypXm/ZoOHoP77lvclbMdIFN9PWgKBzAkx94hurSbw5csBZ0+VETf4ZbLCudCugKhbB6cQGy5PihInXw2Ym76YTxqRxxzJfkt0dIVJtWqq6B1o9GLMYbnLKijjp+r/hZWmMwrMwut7HTWinUgE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(366004)(376002)(396003)(346002)(136003)(86362001)(31686004)(2906002)(5660300002)(2616005)(478600001)(36756003)(31696002)(66476007)(66946007)(110136005)(66556008)(54906003)(186003)(4326008)(53546011)(8676002)(6486002)(8936002)(316002)(16526019)(6666004)(956004)(26005)(38100700001)(16576012)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?WFFUWCs5TFlQZStSeC9JTzZjTVhsc2VWa2l6bWhuMnlIR0xDeWNUenNHZUQx?= =?utf-8?B?RnhEbGxVRmpnRDU4Q1Nsakk5eWR5V0ZhUFFPYWl3WVhUS1J2STk4M3J5TVlw?= =?utf-8?B?UHJmTTROQ1p5R2NXb3oxa1JGUkhxNStPS3V2aXZtZzY1bFBjNmQzVW94ODdO?= =?utf-8?B?WU1XRllESEgyRDFxM21SQWpyQTR5THVOVENUdFU5bWY4dFNYdTNjRFQ1WldR?= =?utf-8?B?d3J2eDNOWENmUHkrVm01dmRDa3VtSjVrOGlTTWlCcVBodEFVV3kwM1g3amcr?= =?utf-8?B?N0hla3Jvak1JaXV1UHJrNFJteWhSaTNDalljaW40Qy90S285eXA5WkZxRkh2?= =?utf-8?B?dFdnbVpsWXhGeE8yTzhGQkxucThkdWJhcW5XM1V6cG9HL2VnNHNLVDNZcmcz?= =?utf-8?B?QlBoc2ptSWxLTGU1TGNLZDMrN3ZIZnU2S1BNNjYzM01jTWd0VlptdEllK2xI?= =?utf-8?B?QWphWG9hK0lmMFhaRUoxZmdnckVNQ2xFejA3VmlHTk1CVFdvSHVuaGlpNUpi?= =?utf-8?B?aUlZcFlxYjQ2RFgwSjIzYVR4L2h4dENMMm9OZngzWGFlT3pxcHVHYndTeU01?= =?utf-8?B?ZEw1Ylh3bjlWV3B5Q3k2YUNGNml5Szk2THZudHVmbW55RkJLcHhhV2toNUJT?= =?utf-8?B?VXZVRnJOR2JiME1vUXI4WVk0ekZ0QnJxNjhubGtGSEdoV1hEYVJyMXVLQUpx?= =?utf-8?B?WjJua0xLRzFZSVNhZTh4RmFyeGs4VmFVcW11UmJ4RW4rLy82YWNZMGUzU00x?= =?utf-8?B?OWRYQUlIM3RURHRIb0FiTVdDOVFXVm9vVmxGcGY3bWNxRnphQ3NFSXh6YjB6?= =?utf-8?B?WU9xNDJJNHhEVkNDRlNwSzlMRVpWNk83VWdLVnFHUTZrZ1N2ZWgzQko1azlN?= =?utf-8?B?ZitydEdkb2dBNDZ1a0VkK3dyUXdpQkN5WmhiM3Uzcy9ucGU5aDBhWndDUVRG?= =?utf-8?B?ejh2RkdwdFZvYkxlbTdkWTN1Q0NOQWZ0dnlicFhzYzZHbTJ4RkZRSXMybXg5?= =?utf-8?B?bnYreS90aW1mWlppUmgyRm5zVzI1UjVIYmVXRnZIVFJzK0hnSUU4QWh4YTRa?= =?utf-8?B?S3R2YkZxYnRXcFgwMHUxK0lCMVlHMGtkaGNOTkxzTHFJbW0xRU4rVk5DQXFT?= =?utf-8?B?MFFmS3I2S3VPR25Ob0ZYN3BDeFZEU1hIWTZNRi9ZbFQ5dUFTZzJrdkY0Sjl6?= =?utf-8?B?YlVjVElJUmN6bTByMjBQZDJPTnEvcnB2NmU0ZzZBbnQ3Uklqcm81VUNYR2Y3?= =?utf-8?B?aWp4TlltZE9HZFJKc08raHVXU3lDcFFKZmxDV3JMQnFwam5pRXpCYXVNTXJp?= =?utf-8?B?V3FBd0VrTGpnVWJYWnk0dzlJU0s3V1JxQ3RMbnZ1aU5tTzFYM2VYMm1JV1l5?= =?utf-8?B?K3ZBczNzSXhraHh4NFBHZmxuRDBiMkk2eUMwV1d5UHpSY1F5aTNzRU9yVXBW?= =?utf-8?B?YUdrNnJ1VzhsMThQUVp5RFMyV1MzNjBXM1B6TG5yMEd0bUZCeTNxVzAwa3hh?= =?utf-8?B?RFhiUW1OVGsxZ2hyN3dBejFNK3N2K2ZnckRiVnp2M1dYdS9oQlJPSWZzY3ZM?= =?utf-8?B?ak9Ecm40dUtVRlNpTExsTWFyMWlDbC9hRnhnb2xEMGJ2WVpzUTVzaHArdG5K?= =?utf-8?B?SGNDbkw0VXdBMVVoS2VXNHA5TDYyWVRxMDVLK1NrM1VuTWswMTNGNHpjMndU?= =?utf-8?B?cHR4Vm53MjNvTmtPZXJ3L29RWXRDbDdTLzJoRjE4Ny9VeFB2V1IyRUF1d1NG?= =?utf-8?Q?2nhLSkER4Ddu+l5HM/iQnNv5MhGA2jTRUHMkLV0?= X-MS-Exchange-CrossTenant-Network-Message-Id: 662a7b76-68df-464c-b82b-08d8f5129db6 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 13:32:38.0257 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6J++VQbTp+l+Mzdk1aLsWOc+bjaCS4qvbnUxhSpKawjsCv2tCQx7PZS59H0zMSTslaMXiq+e6hW58p5tfbCgda8x0ps7rM2w4JCn6BRZQBI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2515 X-OriginatorOrg: citrix.com On 31/03/2021 12:06, Roger Pau Monn=C3=A9 wrote: > On Tue, Mar 30, 2021 at 05:37:02PM +0200, Jan Beulich wrote: >> On 23.03.2021 10:58, Roger Pau Monne wrote: >>> Such helper is based on the existing functions to fetch a CPUID and >>> MSR policies, but uses the xc_cpu_policy_t type to return the data to >>> the caller. >>> >>> No user of the interface introduced on the patch. >>> >>> Signed-off-by: Roger Pau Monn=C3=A9 >> Reviewed-by: Jan Beulich >> with again a minor remark (plus of course the same that I made for >> patch 4): >> >>> --- a/tools/include/xenctrl.h >>> +++ b/tools/include/xenctrl.h >>> @@ -2599,6 +2599,8 @@ void xc_cpu_policy_destroy(xc_cpu_policy_t policy= ); >>> /* Retrieve a system policy, or get/set a domains policy. */ >>> int xc_cpu_policy_get_system(xc_interface *xch, unsigned int idx, >>> xc_cpu_policy_t policy); >>> +int xc_cpu_policy_get_domain(xc_interface *xch, uint32_t domid, >>> + xc_cpu_policy_t policy); >> Generally I'd expect domid_t to be used for domain IDs. > Me too, but xenctrl.h seems to consistently use uint32_t for domain > ids. I'm fine to use domid_t here, but I assumed there was a reason > for using uint32_t uniformly there. There was a tools-wide change making everything uint32_t a while ago, but libxc itself has never used domid_t.=C2=A0 IIRC, it was to do with problems concerning the INVALID_DOMID constant. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 01 13:38:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 13:38:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104458.199773 (Exim 4.92) (envelope-from ) id 1lRxWm-0005dm-Rm; Thu, 01 Apr 2021 13:38:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104458.199773; Thu, 01 Apr 2021 13:38:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxWm-0005df-Of; Thu, 01 Apr 2021 13:38:28 +0000 Received: by outflank-mailman (input) for mailman id 104458; Thu, 01 Apr 2021 13:38:27 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxWk-0005dV-T7 for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 13:38:26 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b03c95cd-c0d9-455d-8b49-73c7e0a9183d; Thu, 01 Apr 2021 13:38:25 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id EA57AB0E6; Thu, 1 Apr 2021 13:38:24 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b03c95cd-c0d9-455d-8b49-73c7e0a9183d X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617284305; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YTyVyHfq5aXmFcqzWsVtaDBe2hBWqpTVqk6/vpdoImU=; b=Puh5c+7J9AL9Fr1Jhn9hilua2VmUG+8UqNSZZSAtb3OyOISHAWiO8mpSKfjibifkt2jNZ7 G3ok/41FItJOvRbZBXvhtVEEEJ7rj6D1Q6z4pl4npdybwI7avPUq7gtmTUWdASt6uzyxvz InZ66TA3bpDKnCMNy68uvtC1+ELaiIk= Subject: Re: [PATCH] x86/viridian: EOI MSR should always happen in affected vCPU context To: Andrew Cooper Cc: Paul Durrant , Wei Liu , xen-devel@lists.xenproject.org, Roger Pau Monne References: <20210401102252.95196-1-roger.pau@citrix.com> From: Jan Beulich Message-ID: <28f68328-9e5f-3f86-a56f-fcc9cf6ba303@suse.com> Date: Thu, 1 Apr 2021 15:38:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 01.04.2021 14:44, Andrew Cooper wrote: > On 01/04/2021 11:22, Roger Pau Monne wrote: >> The HV_X64_MSR_EOI wrmsr should always happen with the target vCPU >> as current, as there's no support for EOI'ing interrupts on a remote >> vCPU. >> >> While there also turn the unconditional assert at the top of the >> function into an error on non-debug builds. >> >> No functional change intended. >> >> Requested-by: Jan Beulich >> Signed-off-by: Roger Pau Monné >> --- >> xen/arch/x86/hvm/viridian/synic.c | 11 ++++++++++- >> 1 file changed, 10 insertions(+), 1 deletion(-) >> >> diff --git a/xen/arch/x86/hvm/viridian/synic.c b/xen/arch/x86/hvm/viridian/synic.c >> index 22e2df27e5d..e18538c60a6 100644 >> --- a/xen/arch/x86/hvm/viridian/synic.c >> +++ b/xen/arch/x86/hvm/viridian/synic.c >> @@ -79,11 +79,20 @@ int viridian_synic_wrmsr(struct vcpu *v, uint32_t idx, uint64_t val) >> struct viridian_vcpu *vv = v->arch.hvm.viridian; >> struct domain *d = v->domain; >> >> - ASSERT(v == current || !v->is_running); >> + if ( v != current && v->is_running ) >> + { >> + ASSERT_UNREACHABLE(); >> + return X86EMUL_EXCEPTION; >> + } > > The original ASSERT() was correct - both of these are easily reachable > in control domain context. > > If you want EOI to not be used, you need to raise #GP from it, but that > in principle breaks introspection which really does write MSRs on the > guests behalf. > > It's perhaps fine in principle to leave that problem to whomever first > wants to poke this MSR from introspection context, but the > ASSERT_UNREACHABLE()s need dropping whatever the introspection angle. But if the original ASSERT() was correct, how can the ASSERT_UNREACHABLE() above need dropping? Are you perhaps only talking about the other one? Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 01 13:38:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 13:38:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104459.199785 (Exim 4.92) (envelope-from ) id 1lRxWy-0005hS-80; Thu, 01 Apr 2021 13:38:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104459.199785; Thu, 01 Apr 2021 13:38:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxWy-0005hL-4b; Thu, 01 Apr 2021 13:38:40 +0000 Received: by outflank-mailman (input) for mailman id 104459; Thu, 01 Apr 2021 13:38:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxWx-0005gw-5G for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 13:38:39 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2b86e546-3146-44dc-87e6-bd7edd66feb3; Thu, 01 Apr 2021 13:38:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2b86e546-3146-44dc-87e6-bd7edd66feb3 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617284318; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=RENu4VPkq7CZTY2uubkOwUponbB37CjwAPN2tWb3QPQ=; b=LOWTcd7HNSrnLbdC1+oJgrFjBT9DhyPnupmV+3nqZPIalpafGIyhC1A0 Z+EU6A2ZNT2uxWEfFES5n/S/lkhZLjtqHty4a5uXRAbjslks/2aFPMQDr Lin1UKqlORPLnStGlwg90wPNWO9b4lfmzp0sQe40V6uxa+6wsHezcFAOk E=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: QD5jksNdSs0WP/dMFevs60ZrIP/RL8woQd2p9lshtz/hgXw5o3AXyMLBbZJuhOOLezLCzEabp6 mhjSvGnpmi3w9yArycdmjLmq8/trrFIcjV7gjYZNGhUHs5GcsQKBfeYjI3IhyCRZFaSGIQygO9 bHW8rgYRBGeNHezsbcwEAu1B6BwtnMuFZ7vU3G/e3goxgSUqP2csU0jBK2DgNtxe4cxieBnWvQ J3f0BWcMgdXhBri3Awzc0T/aHQ4EL/Zuzt9BC++lbsT+KXI9U6p6Gj0uKpbd/GnlW1iwYCEHAJ ec8= X-SBRS: 5.1 X-MesageID: 40698206 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:q3kK/ah1vk8FH5Cauu/9cbBHOnBQXyl13DAbvn1ZSRFFG/Gwv9 yynfgdyB//gCsQXnZlotybJKycWxrnmKJdy4N5B9efdSPhv3alK5wn0Jv6z1TbakvD38N+9Y MlSahxD9XsEUN35PyR3CCUG8stqePpzImGnuHbpk0CcShLbOVa4x59GkKnFCRNNWt7LL4YML bZ2cZdvTqnfh0sH6OGL10IRfLKqdGOtL+OW29kOzcd5AODjSyl5dfBenD14j4kXzxC2rsk+2 Te+jaJg5mLiP2n1gTak1ba8pU+orDc4+FeD8+BgNV9EESJti+UYu1aOoGqjXQOj8yErH0rl9 TNpBlIBbUN11rhOlubjDGo9w3p0DMF42Lvx1mCkRLY0LLEbQN/MeVtr8Z0dQbY9loBsbhHod N29lPcjbV7J1fhmznw/NfBXR0CrDvFnVMS1dQ9olYadKl2Us4pkaUvuHl7Pb1FIQfBrKcgK+ VqBNG03ocqTXqqK0r3k0Mq/MahRR0Ib2+7a3lHgOO5+R5Mkkt0ykMJrfZv4ksoxdYGR55I6/ +sCNUSqJh+CssfbadKDOwcW8eACmvUXRLWMG6JSG6Xbp06Bw== X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="40698206" From: George Dunlap To: CC: George Dunlap , Paul Durrant , "Ian Jackson" , Wei Liu Subject: [PATCH for-4.15 2/7] CHANGELOG.md: xl PCI configuration doc, xenstore MTU entries Date: Thu, 1 Apr 2021 14:38:22 +0100 Message-ID: <20210401133827.362216-2-george.dunlap@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210401133827.362216-1-george.dunlap@citrix.com> References: <20210401133827.362216-1-george.dunlap@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Signed-off-by: George Dunlap --- CC: Paul Durrant CC: Ian Jackson CC: Wei Liu --- CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f7ce6682b9..086a0e50d0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - Switched MSR accesses to deny by default policy. - Intel Processor Trace support (Tech Preview) - Named PCI devices for xl/libxl + - Improved documentation for xl PCI configuration format - Support for zstd-compressed dom0 (x86) and domU kernels - Library improvements from NetBSD ports upstreamed - CI loop: Add Alpine Linux, Ubuntu Focal targets; drop CentOS 6 @@ -23,7 +24,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - x86: Allow domains to use AVX-VNNI instructions - Factored out HVM-specific shadow code, improving code clarity and reducing the size of PV-only hypervisor builds - Added XEN_SCRIPT_DIR configuration option to specify location for Xen scripts, rather than hard-coding /etc/xen/scripts - + - xennet: Documented a way for the backend (or toolstack) to specify MTU to the frontend ### Removed / support downgraded -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Thu Apr 01 13:38:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 13:38:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104460.199792 (Exim 4.92) (envelope-from ) id 1lRxWy-0005iD-LB; Thu, 01 Apr 2021 13:38:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104460.199792; Thu, 01 Apr 2021 13:38:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxWy-0005hs-Ej; Thu, 01 Apr 2021 13:38:40 +0000 Received: by outflank-mailman (input) for mailman id 104460; Thu, 01 Apr 2021 13:38:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxWx-0005gw-9M for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 13:38:39 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1ebeda8f-f861-421f-9bee-65818108e557; Thu, 01 Apr 2021 13:38:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1ebeda8f-f861-421f-9bee-65818108e557 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617284317; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ELcf/BsHGsdjVKKgU0twdyS5n3PZCQDzd1s9Mf5xBZo=; b=YAb2Dp8zFe9QChW0VLhQ5V6kH9vTBhGrUPj/P/BU26ZEhbMf1yxDcM8l muP+dZiK7VkKYNl12pZT47JwR8ElKd6EtuHArE1z/9SqFeA9+xRvaL+oy eNkQlYPWh191tm9oCGajRSirulpxqtHN63CFIorRad7kwGZcTW83CZUEy Y=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: EByghpkyZ0qje9sG3P+qAgA3a8me0upou0kNG0fCwc2NpYHBoNrV7B1kQsPwVplUs0C739mSDe KkBtUjXcIOq2qLg0Nwh6H8ipZLnmyH/bVu/5X3uehQkO+ADxKnMBOqyE9oeZZ6tPhKSSaMzHOU TWwIJLVibcxGU6QSYRMyN6e1krwwSczqpymV97ziYvQuu7OJRPRxRoXVVpGjz7/ceVctALKT2R 2TZegb90QAV3RPyIRz4YGGsEMnOJ95N6qW/6WmfrojzRkyGrHTn2Jxc/tQkE2DCOztalXtH0EB cP4= X-SBRS: 5.1 X-MesageID: 40837413 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:gQR/Ca7JVoBHbaA1sgPXwADXdLJzesId70hD6mlaTxtJfsuE0/ 2/hfhz73DJoRsYRX1Io729EYaaR3e0z/5IyK0wGZvnYwX8omuvK+hZh7fK5zH7ASXx+qp8+M 5bH5RWM9H7AVhkgcuS2mDReOoI+9Wf9bDtuOG29QYPcShRd6pi4w1lYzz7LmRKQmB9dPgEPa vZ39FGoSGhZGR/VKqGOkU= X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="40837413" From: George Dunlap To: CC: George Dunlap , Igor Druzhinin , Jan Beulich , Ian Jackson Subject: [PATCH for-4.15 7/7] CHANGELOG.md: irq-max-guests Date: Thu, 1 Apr 2021 14:38:27 +0100 Message-ID: <20210401133827.362216-7-george.dunlap@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210401133827.362216-1-george.dunlap@citrix.com> References: <20210401133827.362216-1-george.dunlap@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Signed-off-by: George Dunlap --- CC: Igor Druzhinin CC: Jan Beulich CC: Ian Jackson --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9c272a0113..7237b0a020 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -33,6 +33,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - Some additional affordances in various xl subcommands. - Added the following ARM errata: Cortex A53 #843419, Cortex A55 #1530923, Cortex A72 #853709, Cortex A73 #858921, Cortex A76 #1286807, Neoverse-N1 #1165522 - On detecting a host crash, some debug key handlers can automatically triggered to aid in debugging + - Increase the maximum number of guests which can share a single IRQ from 7 to 16, and make this configurable with irq-max-guests ### Removed / support downgraded -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Thu Apr 01 13:38:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 13:38:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104462.199809 (Exim 4.92) (envelope-from ) id 1lRxX3-0005nt-Rt; Thu, 01 Apr 2021 13:38:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104462.199809; Thu, 01 Apr 2021 13:38:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxX3-0005nk-OS; Thu, 01 Apr 2021 13:38:45 +0000 Received: by outflank-mailman (input) for mailman id 104462; Thu, 01 Apr 2021 13:38:44 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxX2-0005gw-3m for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 13:38:44 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3f4b8ddc-efa6-402f-9079-fdde9fc8c75e; Thu, 01 Apr 2021 13:38:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f4b8ddc-efa6-402f-9079-fdde9fc8c75e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617284318; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=tb+mtbd8sswEGjjqgjwZtym2//EwdV/CLbEWHhvGtLk=; b=UlT7er/6/zqdZLP1tr6mNVVbAIwfZhgRKEBzzIrbfqsN7zxUolvuj51O 6CZR+PoDFskzV6ONLnTcPBkzAEO1IidBiNHZ5kfJ6GoaackdFgrTD1X0l q842sIXiEOJpgfIRMqrtr9VURP+KDV3DY/VYDnY9XB/VfeDmXX94Hrf2+ M=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: jSaamM3dsoXodOIIsnmIh+wSfAkf0Ja+qwWjNEiFEpVZT7CsQvjIHVVv8ejC69oBL7hanJigQE 2KhDGmhnFusHJgdzuGAhYUhxtg2K/gUgIS5OwH+5oqv7WPpQyjD0dUoqreq5y5hussoB0PBtbk hm5R/jwU6Lh9q5RA/UF+Z82XJzffLCTkXkRhmNPoASChPlqkWPsmNMaKc/lWGEghP71n6D8T7W W/zuVoA6ahNd23Lj5Sj+7qQITyNaw06qxYTjdbncbdl+pU/0okQzWNeXfODxA/2PAdxLB7//tM Fyk= X-SBRS: 5.1 X-MesageID: 40557943 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:cKqkoqHiA1fUPFGSpLqFRZTXdLJzesId70hD6mlYcjYQWtCEls yogfQQ3QL1jjFUY307hdWcIsC7Lk/03aVepa0cJ62rUgWjgmunK4l+8ZDvqgeNJwTXzcQY76 tpdsFFZeHYJURmjMr8/QmzG8shxt7Cy6yzmeLC1R5WLD1CQYsI1XYdNi+wFEpqSA5aQb8wE5 SB7sRKzgDQBkg/RMK9G3UDQqz/vNXNjp3relorABQg5QmIg1qTmcLHOjKf2QoTVC4K/Kc6/Q H+4nHEz4iAk9X+8B/T0GfP849b8eGO9vJvDNGB4/JlUgnEpR2vYO1aKtq/lRAz5Nqi8VM71O TLyi1QRfhbz1P0UiWLrQD22w/muQxemEPK7VODm3PsrYjYaVsBerN8rLlUeBfY9EYs1esUuM kgvxP7xu9qJCjNkyjn69/DWwsCrDvRnVMYnfMOlHsaaIMCadZq3Pwi1XlIG5QNFj+S0vFALM BSCqjnlZRrWG+BY2uclmdix8HEZAVJIj62BmIGusCTzgFMmmF4w0Yy1KUk7wY93aN4ZJ9e6+ veNKN00JlIU88NdKp4QNwMWM2tFwX2MF3xGVPXBW6iOLAMOnrLpZKyyLIp5NuycJhN6Jcpgp zOXH5RqGZaQTOhNeS+mLlwtjzdSmS0WjrgjutE4YJih7H6TL33dQWeVVEHiaKb0rYiK/yef8 z2FINdAvflI2erM51OxRfCV55bLmRbeNEJu+w8R0mFrqvwW83Xn92eVMyWCKvmED4iVG+6KG AERiLPKMJJ6V3udWT/hDTXRnPxam3y9Z99C8Hhjq0u4blIErcJnhkeiFy/6M3OAyZFqLYKcE x3J66isq7TnxjzwU/4q0FSfjZNBEdc57vtF1lQoxURDk/yebEf//GWeWVY2mq7NgZyJvmmVz J3lhBSw+aaPpaQzSctB5aMKWSBlUYeo3qMUtM6lrCc49zmPrc1FIwvVqA0NQijLW01pS9a7E N4LCMUTE7WET3jzY+/ioYPOe3Zf95gxCGxIcBVrnrbnV6Gpd4mQ0YaWzLGa7/UvS8eAx5vwn Fh+a4Wh7SN3Ry1L3Ekveg+OFpQLFiMDKl+FwSDboVMkrXNcAV9JF36wwCyulUWQC7H5k8Sjm vuIWmxdevQClRQgHxez53n6Uh5bGmbYkJ2ZE1rqIEVLxW1hl9DlcuwIoaj2WqYbVUPhtsQNz zIehM+CAJjzdLf7m/epB+yUVEdgrk+NO3UC7ouN4zJ0nS2MYuSiOUtBPlP5qtoM9jor84GWe +SYBWuMTv9Eu8lsjbl/0oNCW1Rkj0JgPno0Brq4CyEx3Y5G+PVO0kjaLcBId2QhlKUDsqg4d Fct5YSsuSxOGmqNYLD5qHTcjJZKhTc5USxVPolrJhIvaQ08Jt/dqOrJgfg5TVi5lEZKsyxqW Y1BIJcy5rFMpV0f8MTdzlCl2BZ3+inHQ8OiEjOHuQ6fVsRlHfVMNOC3qrQpdMUczm8jTq1HW PazjZU8PjEVRaSzLI2C6o/JmJNdUg3gU4Sit+qRsn1CA+wcftE80f/GnihcKVFQKztI8Rckj 9Kp/WJlfSQbSz2xUT5uiZ6OLtH9yKCTdmpCAyBXc5O/NrSAyXBvoKapOqyhizwUz21dgAxgp BEb1UZaoB7sQYZ5bdHmhSae+jQuUIqk1xX/DFhmBrM4+GdkRnmNHADFxbYjJVQVSRUKV6Sg6 3+gLCl6Eg= X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="40557943" From: George Dunlap To: CC: George Dunlap , Ian Jackson , Andrew Cooper , "Jan Beulich" , Roger Pau Monne Subject: [PATCH for-4.15 5/7] CHANGELOG.md: Various new entries, mostly x86 Date: Thu, 1 Apr 2021 14:38:25 +0100 Message-ID: <20210401133827.362216-5-george.dunlap@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210401133827.362216-1-george.dunlap@citrix.com> References: <20210401133827.362216-1-george.dunlap@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain ...Grouped mostly by submitter / maintainer Signed-off-by: George Dunlap --- CC: Ian Jackson CC: Andrew Cooper CC: Jan Beulich CC: Roger Pau Monne --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index b3325a8371..2f26cd5c87 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,6 +17,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - Named PCI devices for xl/libxl - Improved documentation for xl PCI configuration format - Support for zstd-compressed dom0 (x86) and domU kernels + - EFI: Enable booting unified hypervisor/kernel/initrd/DT images + - Reduce ACPI verbosity by default + - Add ucode=allow-same option to test late microcode loading path - Library improvements from NetBSD ports upstreamed - CI loop: Add Alpine Linux, Ubuntu Focal targets; drop CentOS 6 - CI loop: Add qemu-based dom0 / domU test for ARM -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Thu Apr 01 13:38:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 13:38:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104463.199821 (Exim 4.92) (envelope-from ) id 1lRxX8-0005sj-5w; Thu, 01 Apr 2021 13:38:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104463.199821; Thu, 01 Apr 2021 13:38:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxX8-0005sU-2B; Thu, 01 Apr 2021 13:38:50 +0000 Received: by outflank-mailman (input) for mailman id 104463; Thu, 01 Apr 2021 13:38:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxX7-0005gw-3r for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 13:38:49 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1b028f1f-acda-4ee9-a953-5abbd8b840bb; Thu, 01 Apr 2021 13:38:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1b028f1f-acda-4ee9-a953-5abbd8b840bb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617284319; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=YXv7m3eiV3hYcI7MMqbRpxWTnC+nXWuF664tG7aNhFw=; b=InjMt0I14wi8kYvcymGeiiHOJ/vtU9Isv3EuCCCl2pmhGt5XT4lb/6JZ QYrOF6CzXXp8DxnphFTEcPCOXLCEdebPG+qimTBpFMrN1ZFx7rA7ykPZX Dy6Saa0zostevP5s2Oy8UYLLyAkJPoVHQzlhqUk0Dnt8k5AxRf678GoWX Q=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: zQrNxEe9R7nv3DSPOkmYPcD4gnfVkNg4qTi3BIeO4ow5uzrHXZeFdzo+wBS4d3XMrtlGZXy5w1 ghORQpqqy0qx/LdcS4Veq/CT0x9dDPBSUoVgE0Trx1Bi1soFUFp6BQKnz7vYeW4FcRM7K8bWL8 w4Fki3Y3mRidef77b9XQl8NVxkktOekR8HiCzDZE+eIGlHZOHLRaoQFWHdLfk63QA+xmQBFOxS HSnu2dyfDiJU/J2sulHR20z5AVMlRyZJUZgufWaKvaWQxD84nxn4lKFb7jinNp1dSs3qBAcjZ/ 3vo= X-SBRS: 5.1 X-MesageID: 40698208 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:5sYPEa9lZyM6dJaWQxRuk+Erdb1zdoIgy1knxilNYDRIb82VkN 2vlvwH1RnyzA0cQm0khMroAsS9aFnXnKQU3aA6O7C+UA76/Fa5NY0K1/qF/xTMOQ3bstRc26 BpbrRkBLTLZ2RSoM7m7GCDfOoI78KA9MmT69v273Aodg1ybrEl0gERMHf4LmRTZC1rQaU0D4 Cd4M0vnUvGRV0yYt6gDncIG8jvzue7967OWhINCx455ATmt1rBhILSKBSW0gwTVDlC294ZgA 34ujf0+7m5tLWDwgLcvlW5071thNDjxtFfbfb87vQ9FzOEsGeVTbUkYZKulnQfoOaj6FEl+e O83CsIDoBIxF76Ok2wqRvp8QH83Dgp8G+K8y7nvVLT5fbXaRh/J81dhZ9IUhax0TtQgPhMlJ hl8kjcl51LAQjOlC7wjuK4Jy1Cpw6PjlcJ1csw5kYvKLc2WftqgqE0uH5xKtMmGhn37Yg2ed Mecf301bJtXn6xK0zCsnIH+q3VYl0DWi2ob2IlocKv3z1fjBlCvjcl7f1apHsG+Z4nIqM0nN jsA+BtnLFKeMcccbhwMucHWde2EWzAW3v3QRivHWg= X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="40698208" From: George Dunlap To: CC: George Dunlap , Olaf Hering , Ian Jackson Subject: [PATCH for-4.15 1/7] CHANGELOG.md: Mention XEN_SCRIPT_DIR Date: Thu, 1 Apr 2021 14:38:21 +0100 Message-ID: <20210401133827.362216-1-george.dunlap@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Signed-off-by: George Dunlap --- CC: Olaf Hering CC: Ian Jackson --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8964bacf73..f7ce6682b9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -22,6 +22,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - CI loop: Add dom0less aarch64 smoke test - x86: Allow domains to use AVX-VNNI instructions - Factored out HVM-specific shadow code, improving code clarity and reducing the size of PV-only hypervisor builds + - Added XEN_SCRIPT_DIR configuration option to specify location for Xen scripts, rather than hard-coding /etc/xen/scripts + ### Removed / support downgraded -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Thu Apr 01 13:38:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 13:38:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104466.199833 (Exim 4.92) (envelope-from ) id 1lRxXD-0005yq-GZ; Thu, 01 Apr 2021 13:38:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104466.199833; Thu, 01 Apr 2021 13:38:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxXD-0005yf-C7; Thu, 01 Apr 2021 13:38:55 +0000 Received: by outflank-mailman (input) for mailman id 104466; Thu, 01 Apr 2021 13:38:54 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxXC-0005gw-3w for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 13:38:54 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c74d724e-f2a8-4655-b977-c97b4aea5a0b; Thu, 01 Apr 2021 13:38:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c74d724e-f2a8-4655-b977-c97b4aea5a0b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617284319; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=/nfKp65BUMpoLSwVcKTcwd3UvwPRuboxyMAbRkTKwjk=; b=LhpytAPG2jmsMhwYHhSbXlivxEN6+RqkmUngXvaKgU/8nfBuclkvQirJ owSwD1tfo2IRz99hZlNQ2HGRTB7Ff6tPblVnjDHIsSObGe8BiPscJau3N RHYTIl8eqTnz/T6JRq6mZpjK7nBn00BJQMCwUqSuOc18UAHZz+kNd+Dnm A=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: TR3DXpggjJQChW4s+fKNp6wATEYaDhKr4u8Bk4o3QNx/qyF3yZ9F/lYE/CrPPGu7IMWPyhPew2 zMVzLo8YXcuFDL7MJ+JCV4UFhBxbgkKwaCLMl4DORwxfG7X11uFe7ccRcUmsRlJ8c3ADitW94i vqrxSBMfQGuBiBtz43PuLVFtIRoPbvF8MSzhoqF4gHWM2iMoJbrFWQtagBlv0qMu5z7dCCh8aM zCbjA+QcW1pRpDb9kqCi3Ty/NaaC9dStwpp4k/GZ+PzG3vjjdkfce7kGXcjEFG1Bk9b00MZlSP 72M= X-SBRS: 5.1 X-MesageID: 40698209 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:F17nQal7291yDsMUj+YNNieQD07pDfPfimdD5ilNYBxZY6Wkvu izgfUW0gL1gj4NWHcm3euNIrWEXGm0z/NIyKMaVI3DYCDNvmy0IIZ+qbbz2jGIIVyZysdx94 dFN5J/Btr5EERgga/BijWQPt48zLC8n5yAqvzZyx5WIz1CS6Yl1AthDxbeL0sefnglObMcNL 6xovVKvCChf3N/VLXdOlAgU/LYr9PG0LLKCCR2ZCIP0wWFgTO25LOSKXHxsis2aD9Bzawv9m LIiWXCl8Cemsq21wPG0Cvr54lW8eGL9vJ4GMeOhsIJQw+c7jqAWYIJYdy/lQFwms6DwhIAkN 7AoxAvVv4DlE/5TyWOjjbGnyXl2DYqwXf+xVGfmmuLm72GeBsKT/BvqKgcXhzF61cxnNwU6t M740up86B5IDmFvCPh68PGXxtn/3DE0UYKoKoooFF0Fa49AYUh1LA3zQduP7orWB/e0sQBFt JjCcnNjcwmDG+yXjTikUREhOC3Um9bJGb/fmEy/va7/hJxh35Dw04R1KUk7ws93aN4cZVC6u jeW54Y741mf4sTZaJ5Mu8LXdG6PGzLWQ7NK2KfOz3cZds6B04= X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="40698209" From: George Dunlap To: CC: George Dunlap , Ian Jackson Subject: [PATCH for-4.15 3/7] CHANGELOG.md: Some additional affordances in various xl subcommands Date: Thu, 1 Apr 2021 14:38:23 +0100 Message-ID: <20210401133827.362216-3-george.dunlap@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210401133827.362216-1-george.dunlap@citrix.com> References: <20210401133827.362216-1-george.dunlap@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Signed-off-by: George Dunlap Signed-off-by: Ian Jackson --- CC: Ian Jackson --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 086a0e50d0..a12dab1c33 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -25,6 +25,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - Factored out HVM-specific shadow code, improving code clarity and reducing the size of PV-only hypervisor builds - Added XEN_SCRIPT_DIR configuration option to specify location for Xen scripts, rather than hard-coding /etc/xen/scripts - xennet: Documented a way for the backend (or toolstack) to specify MTU to the frontend + - Some additional affordances in various xl subcommands. ### Removed / support downgraded -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Thu Apr 01 13:39:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 13:39:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104469.199845 (Exim 4.92) (envelope-from ) id 1lRxXI-00064n-RU; Thu, 01 Apr 2021 13:39:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104469.199845; Thu, 01 Apr 2021 13:39:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxXI-00064a-N6; Thu, 01 Apr 2021 13:39:00 +0000 Received: by outflank-mailman (input) for mailman id 104469; Thu, 01 Apr 2021 13:38:59 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxXH-0005gw-47 for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 13:38:59 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8e757902-a110-488d-a85f-50f8eca96c28; Thu, 01 Apr 2021 13:38:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e757902-a110-488d-a85f-50f8eca96c28 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617284319; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=E7PWP01YlYArqfPdyR9XpVrgVVm/Kk33xKnYE1YhnsI=; b=Q69Sa4a3vVt1DgZj+aqqLbZDxa5iZ7emWaz0KePVvS65Yy6UKuyM8Yu5 yINm6dyaOFimPuyUZPlpP/tG9h6eks+lar3jPG4nyqDvsXoilc0z2P/KA A5zO9mCzFX6tCYpjArsWK35KoXp3BWaLLlq42KmFI6zi/PnOh6EyicbRb c=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 2FbHTM9kD8m0dsEYumiLjx7uy99rlr8rMY73D0FWcKTP7Fp5VQNNdSZY8cNLMVkRCOxXfV6Gkh dv9vfn2x6dK7twJhhZ9N7bsXhkqmkfRK3Ld6GzDriSnRZ2Wm9sW+aj8zSjjWNm4iMDrGTB9Ohp StVbBnYllX4U8kGDAkm9Dzk8Ujt6pArz+XS2RBxndnrpiM+uCi6JFvVPI+erSDyHmrJjOAb8/v Qob6fMrOExVQxXgrVcfdIPj+VU4zwiixUcsAN7E8tTeGGOqNPb49Fsj8rUsPTRuPQd+lIOvZFz 8mc= X-SBRS: 5.1 X-MesageID: 40557944 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:DnbioK6q07ExB0gFygPXwWWEI+orLtY04lQ7vn1ZYSd+NuSFis Gjm+ka3xfoiDAXHEotg8yEJbPoexzh3LZPy800Ma25VAfr/FGpIoZr8Jf4z1TbdxHW3tV2kZ 1te60WMrDNJHBnkMf35xS5Gd48wN+BtJuln/va0m0Fd2BXQotLhj0JbzqzOEtwWQVAGN4dHJ 2T+sJIq1ObCAsqR+68AWQIWPWGmsbCk4jobQVDKxks7gSPij3A0s+HLzGz2BACXzRThYoz6G StqX2F2oyPkdGejiXd2Wja8ohMlLLapOdrKcSQhqEuW03RoymyYoAJYczkgBkUp6WV5E8ugJ 3wpX4bTr5OwlfwWk3wnhf3wQnn118Vmgzf4HuVm2Hqr8C8ZB9SMbs5uatjfhHU61UtsbhHuc ohtQLp1OsjMTr6kCvw/NTOXR1x/3DExUYKquIPk2dZFbIXdb45l/1uwGpuDJwCECjmgbpXdt VGMce03oc1TXqndXzD+kFgzNuwN05DZSuucwwpv8yY1CVuh3Zpz0cU79x3pAZwyLsND7ZD/O jKKaJuifVnSdIXd7t0AKM7TdKwEXGle2OCDEuiZXDcUI0XMXPErJD6pJ0z+eGRYZQNiL8/go 7IXl90vXM7EnieR/Gm7dluyFTgUW+9VTPixoV1/J5ioIDxQ7LtLGmqVE0uu9HImYRdPuTrH9 KIfL5GCf7qKmXjXaxT2RflZpVUIX4CFOUIp9cAXU6UqM6jEPyrisXrNNLoYJb9GzctXW3yRl EZWiLoGclG5ke3HlDihhz8XG7sZ1zf8Zp8HLOyxZlX9KE9cql39iQFg1Ww4c+GbRdYtLYtQU d4KLT71oO3zFPGuVrg3iFMAF5wH0xV6LLvXzdhvgkRKX75dr4FppG6cWBW132XGw9nQ6rtYU lijmUy3ZjyA42bxCgkBd7iGHmdlWEvqHWDSIpZvaGf+8H/eNcdAow9UKJ8USXHfiYF2DpCmS NmUkspV0XfHjThheGOl5oPHtzScNF6nUOMOs5bqXXWsG2GvsExTn4nXzqjOPTnwzoGdn5xvB lc4qUfiL2PlXKEMm0kmtk1N1VKdSCqGr5cNR+EY49Vg7jvXwl1QQ6x9HqnoiB2XlCv21QZh2 TnIyHRXf3QGFJStkpV1bvQ/Epuen+QeF9xbX5GoZRwfF62yEpb4KuuXO6ewmGRYlwNzqUmPD bJbSA7Dyluy9q0vSTl0gqqJDED/NEDL+bdBLMsf/XvwXurMpSPjrxDNeRT5oxZONfntfIrXe qTdxSOFi7xD/ok1mWu1y8YERgxjENhveLj2RXj4mT94WU2BuDKJk96A54cONOR4gHfNr+1+a Q8qehwm+S+Mm/8MIHbjY7WaiNOMRPVryqdSfoypZVdoKI1s/9SEvDgIEz1/UAC+C97CsH+0H 46auBcxpvqP4d0Zcwcey5D5DMS5Z+yBXpuljazO/M0eFEmsmTSMNyI6YfZsLZHODz0mCLAfX 2ktxBH9/jLXyG/xacXJqI5L2NRclU94h1ZjZW/XryVLAWhbOdY+lWmdle7bb9GUaCAcI9g4y pS0pWtn+WNcTD/1x2VlTxnIrhW+2LiZc+pGgqDFapp9NO9UG78zpeC0YqWjD3tTyG8ZFldrY pZdVYIZsAGswIctuQMo2CPY52yhFkknVtY6SxmkVCo+rHO2hakIWh2dSvDgptXWjFPNGOvls qty5nB6EjA X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="40557944" From: George Dunlap To: CC: George Dunlap , Juergen Gross , Jan Beulich , Ian Jackson Subject: [PATCH for-4.15 6/7] CHANGELOG.md: Various entries, mostly xenstore Date: Thu, 1 Apr 2021 14:38:26 +0100 Message-ID: <20210401133827.362216-6-george.dunlap@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210401133827.362216-1-george.dunlap@citrix.com> References: <20210401133827.362216-1-george.dunlap@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain ...grouped by submitters / maintainers Signed-off-by: George Dunlap --- CC: Juergen Gross CC: Jan Beulich CC: Ian Jackson --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2f26cd5c87..9c272a0113 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -28,8 +28,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - Factored out HVM-specific shadow code, improving code clarity and reducing the size of PV-only hypervisor builds - Added XEN_SCRIPT_DIR configuration option to specify location for Xen scripts, rather than hard-coding /etc/xen/scripts - xennet: Documented a way for the backend (or toolstack) to specify MTU to the frontend + - Fix permissions for watches on @introduceDomain and @releaseDomain: By default, only privileged domains can set watches; but specific domains can be given permission in order to allow disaggregation. + - xenstore can now be live-updated on a running system. - Some additional affordances in various xl subcommands. - Added the following ARM errata: Cortex A53 #843419, Cortex A55 #1530923, Cortex A72 #853709, Cortex A73 #858921, Cortex A76 #1286807, Neoverse-N1 #1165522 + - On detecting a host crash, some debug key handlers can automatically triggered to aid in debugging ### Removed / support downgraded -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Thu Apr 01 13:39:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 13:39:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104472.199857 (Exim 4.92) (envelope-from ) id 1lRxXO-0006AT-4Y; Thu, 01 Apr 2021 13:39:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104472.199857; Thu, 01 Apr 2021 13:39:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxXO-0006AK-19; Thu, 01 Apr 2021 13:39:06 +0000 Received: by outflank-mailman (input) for mailman id 104472; Thu, 01 Apr 2021 13:39:04 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxXM-0005gw-4G for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 13:39:04 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 74176d82-3484-4845-a7aa-d68fb9f381eb; Thu, 01 Apr 2021 13:38:40 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 74176d82-3484-4845-a7aa-d68fb9f381eb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617284320; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=9Cwda7hvpLKLiOQOMp9r6kfCTOsPTlqzOoOijVd/CF0=; b=B11ehphShE4o05dLLS8u2gojF28Y3e4T1PuLZs91UmV/nT/Vnwd3dYrX /HoxOL4BFDSCgdj2IGSMbJoD6apXUSo1r+nOQ/L7+5pz/NVzmqID4//T1 H9n1BN0f+Kw659Y9jiZBnX92yetVun9frBSVnQME3oMjI7IRwS4s+mhms s=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 2gFl06xf/DpDln0vux+wr1cKad4T7roFUaDLtEu+RG8dauZt8CqKby0tz5+BoqGPsWyX0kcQ3C mjwsweqFqrH3yuAvq90tMZR0WgF8GoGRlG+63AzjL09qHO6y3Ki9kyWTeH8/fDiJ3DsIEs3B0A vzg1OB3GOnbf5mVYIo9yCFyXGf/yqwVyAo+wqxaq/I3PO8dvcQL20BAxgxr74ZmrBFZNrFXVUz cBLi6bsip/2xbeSzpoLBFLMHE+QAUBiiy7pGUyChKb/LsIWKDg9q4NwLkBcaiWtUw5djHVfRi0 cgU= X-SBRS: 5.1 X-MesageID: 40698211 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:bH7E96h9uW3o+1PC2DFnize3nHBQXyl13DAbvn1ZSRFFG/Gwv9 yynfgdyB//gCsQXnZlotybJKycWxrnmKJdy4N5B9efdSPhv3alK5wn0Jv6z1TbakvD38N+9Y MlSahxD9XsEUN35PyR3CCUG8stqePpzImGnuHbpk0CcShLbOVa4x59GkKnFCRNNWt7LL4YML bZ2cZdvTqnfh0sH6OGL10IRfLKqdGOtL+OW29kOzcd5AODjSyl5dfBenD14j4kXzxC2rsk+2 Te+jaJg5mLiP2n1gTak1ba8pU+orDc4+FeD8+BgNV9EESJti+UYu1aOoGqjXQOj8yErH0rl9 TNpBlIBbUN11rhOlubjDGo9w3p0DMF42Lvx1mCkRLY0LLEbQN/MeVtr8Z0dQbY9loBsbhHod N29lPcjbV7J1fhmznw/NfBXR0CrDvFnVMS1dQ9olYadKl2Us4pkaUvuHl7Pb1FIQfBrKcgK+ VqBNG03ocqTXqqK0r3k0Mq/MahRR0Ib2+7a3lHgOO5+R5Mkkt0ykMJrfZv4ksoxdYGR55I6/ +sCNUSqJh+CssfbadKDOwcW8eACmvUXRLWMG6JSG6Xbp06Bw== X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="40698211" From: George Dunlap To: CC: George Dunlap , Ian Jackson , Stefano Stabellini , "Julien Grall" Subject: [PATCH for-4.15 4/7] CHANGELOG.md: Mention various ARM errata Date: Thu, 1 Apr 2021 14:38:24 +0100 Message-ID: <20210401133827.362216-4-george.dunlap@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210401133827.362216-1-george.dunlap@citrix.com> References: <20210401133827.362216-1-george.dunlap@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Signed-off-by: George Dunlap --- CC: Ian Jackson CC: Stefano Stabellini CC: Julien Grall --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index a12dab1c33..b3325a8371 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -26,6 +26,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - Added XEN_SCRIPT_DIR configuration option to specify location for Xen scripts, rather than hard-coding /etc/xen/scripts - xennet: Documented a way for the backend (or toolstack) to specify MTU to the frontend - Some additional affordances in various xl subcommands. + - Added the following ARM errata: Cortex A53 #843419, Cortex A55 #1530923, Cortex A72 #853709, Cortex A73 #858921, Cortex A76 #1286807, Neoverse-N1 #1165522 ### Removed / support downgraded -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Thu Apr 01 13:43:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 13:43:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104486.199869 (Exim 4.92) (envelope-from ) id 1lRxbT-0007L4-SD; Thu, 01 Apr 2021 13:43:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104486.199869; Thu, 01 Apr 2021 13:43:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxbT-0007Kx-Oy; Thu, 01 Apr 2021 13:43:19 +0000 Received: by outflank-mailman (input) for mailman id 104486; Thu, 01 Apr 2021 13:43:18 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxbS-0007Ks-AG for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 13:43:18 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8411d6d6-b774-4778-a803-b2d8168943f2; Thu, 01 Apr 2021 13:43:17 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D5F38AF23; Thu, 1 Apr 2021 13:43:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8411d6d6-b774-4778-a803-b2d8168943f2 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617284597; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KrgYsx1UP6iZuNfaU2C4DpL8Uvgwht3nbDd3oOYHCZk=; b=R0nfvDDx3MsC+2xnyhgScJVGsQ+wFaKMUepGsMk98XDnQW/nkyCLoVwv1mNkbxNJXpkNtL 3vMPn/RPOl3XtJDUQjfJnGYldwsq8QDCxfd8uXba4oQrj6YiOGTAySV9jxUFpqnGBCWQIV tqcmP3IpFKIsBKvk+UlzupZb7bIO9TU= Subject: Re: [PATCH 00/23] further population of xen/lib/ To: Julien Grall Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <27916fa0-9ebd-a49a-bbb9-1ef47c2b5bf6@xen.org> From: Jan Beulich Message-ID: <4f745d03-baa8-e9e6-692c-f9c9f401b766@suse.com> Date: Thu, 1 Apr 2021 15:43:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <27916fa0-9ebd-a49a-bbb9-1ef47c2b5bf6@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 01.04.2021 13:54, Julien Grall wrote: > On 01/04/2021 11:14, Jan Beulich wrote: >> This is to dissolve / move xen/common/lib.c and xen/common/string.c. >> One benefit of moving these functions into an archive is that we can >> drop some of the related __HAVE_ARCH_* #define-s: By living in an >> archive, the per-arch functions will preempt any loading of the >> respective functions (objects) from the archive. (Down the road we >> may want to move the per-arch functions into archives as well, at >> which point the per-arch archive(s) would need to be specified ahead >> of the common one(s) to the linker.) > > While I think it is a good idea to move code in xen/lib, I am not > convinced that having a single function per file is that beneficial. > > Do you have numbers showing how much Xen will shrink after this series? In the default build, from all I was able to tell, there's one function that's unused (strspn(), as mentioned in the respective patch description). I don't think I've been claiming any space savings here, though, so I wonder why you make this a criteria at all. The functions being one per CU is such that they can be individually overridden by an arch, without pulling in dead code. Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 01 13:45:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 13:45:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104490.199880 (Exim 4.92) (envelope-from ) id 1lRxdL-0007Tw-8O; Thu, 01 Apr 2021 13:45:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104490.199880; Thu, 01 Apr 2021 13:45:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxdL-0007Tp-5L; Thu, 01 Apr 2021 13:45:15 +0000 Received: by outflank-mailman (input) for mailman id 104490; Thu, 01 Apr 2021 13:45:13 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxdJ-0007Te-FQ for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 13:45:13 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ba5cc7f9-de0e-4828-9aea-da80d81bc17d; Thu, 01 Apr 2021 13:45:12 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9C5C0AF23; Thu, 1 Apr 2021 13:45:11 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ba5cc7f9-de0e-4828-9aea-da80d81bc17d X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617284711; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zi1iTupuL2Ht8KEZSjEM8o0HXNdVSkE57LdTRo3luNs=; b=Xx2nRWuP2giTPbGgg7FP823UWZakdk6IncdGxCOUL0u5RdTMWClKYBfGR/Az7Ctb69IoQG 1kxfr+EqDa8MZ5VN0huNZlwR7YJYjMP0T49wYhGR0/Xt92P2xnhxT4Iea6vYDOMsnL1TMA lUMCLrw/UnCmpsAmODuJXptAzqORBV8= Subject: Re: [PATCH] x86/hvm: Fix double free from vlapic_init() early error path To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20210331133125.7072-1-andrew.cooper3@citrix.com> <95d8688b-2e54-ae02-09ce-45203959e08a@suse.com> From: Jan Beulich Message-ID: Date: Thu, 1 Apr 2021 15:45:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 01.04.2021 15:20, Andrew Cooper wrote: > On 31/03/2021 15:03, Jan Beulich wrote: >> On 31.03.2021 15:31, Andrew Cooper wrote: >>> vlapic_init()'s caller calls vlapic_destroy() on error. Therefore, the error >>> path from __map_domain_page_global() failing would doubly free >>> vlapic->regs_page. >> I'm having difficulty seeing this. What I find at present is >> >> rc = vlapic_init(v); >> if ( rc != 0 ) /* teardown: vlapic_destroy */ >> goto fail2; >> >> and then >> >> fail3: >> vlapic_destroy(v); >> fail2: >> >> Am I missing some important aspect? > > No - I'm blind.  (although I do blame the code comment for being > actively misleading.) > > I retract the patch at this point.  It needs to be part of a bigger > series making changes like this consistently across the callers. > >>> Rework vlapic_destroy() to be properly idempotent, introducing the necessary >>> UNMAP_DOMAIN_PAGE_GLOBAL() and FREE_DOMHEAP_PAGE() wrappers. >>> >>> Rearrange vlapic_init() to group all trivial initialisation, and leave all >>> cleanup to the caller, in line with our longer term plans. >> Cleanup functions becoming idempotent is what I understand is the >> longer term plan. I didn't think this necessarily included leaving >> cleanup after failure in a function to it caller(s). > > That's literally the point of the exercise. > >> At least in the >> general case I think it would be quite a bit better if functions >> cleaned up after themselves - perhaps (using the example here) by >> vlapic_init() calling vlapic_destroy() in such a case. > > That pattern is the cause of code duplication (not a problem per say), > and many bugs (the problem needing solving) caused by the duplicated > logic not being equivalent. > > We've got the start of the top-level pattern in progress, with > {domain,vcpu}_create() calling {d,v}_teardown() then {d,v}_destroy() for > errors. Hmm, in which case you mean to shift the responsibility not to "the caller" (many instances) but "the top level caller" (a single instance)? Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 01 13:50:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 13:50:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104493.199893 (Exim 4.92) (envelope-from ) id 1lRxii-0008Lg-TU; Thu, 01 Apr 2021 13:50:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104493.199893; Thu, 01 Apr 2021 13:50:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxii-0008LT-QG; Thu, 01 Apr 2021 13:50:48 +0000 Received: by outflank-mailman (input) for mailman id 104493; Thu, 01 Apr 2021 13:50:47 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxih-0008LM-OJ for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 13:50:47 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e40da771-d78a-4ad9-ae9c-2453c5c395c6; Thu, 01 Apr 2021 13:50:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e40da771-d78a-4ad9-ae9c-2453c5c395c6 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617285046; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=KOhBR+TwmHONKP8NUKnlbDgNAxDW7eUvuXoXcKdhAdU=; b=IOAS6hji6Qch0kWYXEFeskyJeYlPcx9QFv/N5bXiS5zdlJyauwRig3e5 HnJNvzmerqqnMkoZDCeVmceOBjLPphdAw9aRXVFfwLRCll1nhUNzmplLG 2KRU5sVdJ/GTFiiC5zRYEW+W62yPw42xJ+coCOP2bOFqJCXgW0hw0xBE9 w=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: FIuuEByxvXXqzSTHx6zWX5n3C1J+XpSEZUJbsuwMN3BN43c+JZnDNk5et+/i2M5lB0U6qT5X6T VMl8/pTotN7LkmYBVsvnFXTJOp3hykT0R69DcpFuhK3uxmxaVRXpLYB51h7A6XR9eeu11I2UGa MCeT9LB48wnJZu0MJjzW7kn39ERik03MxDNY1Y7U5QLqA5lOA2vaJXozYJrXYkL/nYrEp8apMs Sq9Q4ktRlDr21IHpSX+zkxdtcJlFiyBObo8nG+8NFIgkZo5D5/+wt5tppsT0aOKLKhxT8SteZu 4Xc= X-SBRS: 5.2 X-MesageID: 41077323 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:c3prV6EocDe/9joJpLqFOpHXdLJzesId70hD6mlYVQFVfsuEl8 qngfQc0lvOhCwMXWw78OrsBICrSxrnlaJdy48XILukQU3aqHKlRbsSibfK7h/BP2nF9uBb3b p9aKQWMrfNJHVzkMqS2maFOvk6xt3vys6VrMP/61socg1wcaFn6G5Ce2OmO2l7XhNPC5Z8NL f03LslmxOadX4abtu2CxA+NoCum/TxmI/7ehlDPhY76WC15g+A0qLwEBSTw34lIlFy6IolmF KlryXJop+Nntv+4R/a2m/V4f1t6abc4+oGPuOgoIw4Lj3tjyyheYhuXaaT1QpF3N2H2RIRv/ Tn5zsmIsRv+1PdF1vF3ifF6k3b/xsFr1/k1FOCjnPoraXCNUwHIvsEv611WF/9ySMbzbZB+Z MO5U21nd5rKCmFuyLH693BR3hR5zGJiEtnq8E/pThiS4cEAYUhy7A3zQduP7orOjn104wjGP kGNrCn2N9mNWmXaH3UpQBUsaWRd0V2Gh+HR34LsdCO3w5Xm2hkz1AZyNZ3pAZ5yK4A X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="41077323" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fu4BJv4d/hweqghaY+7fAQSPqlyP3yToD9n+CpB68TeHDi8VjUONzQhrpaKAa2XNxg2dVwI2CH4MnLZ7Bl/Du+zu+lc9kvuOhicFMvICXNYrtoWMQOiS2fwACIPmxqlGuUBt9HU/50UklLpocSrJuH43ZR8xK3gRHMoMESbwoix8zi/9KGWpORbYAjUhqaTFNRdCiO/pjJGVpYRXpc+Nr5BIHMZG4dMHYw1fFSx3M/P4vttqaHPBj0NOb7tuY8Qy7EMKO6nnaZ9PsnshbMOFvvzLJafbUVm3CRyLb6CPwglakpmcrEZ8rhckJEPKQ6tcVk9r1aPPvU2LmmTtI9Ln0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7zwZqYz71LYljQ/uFikr8FzWhvV4VF3i5ow+RwmBpf0=; b=EYDHclIJbNKRwpNDaYlvpZ2Y/2T38/amvEDFYPa+vjdl+Uhp45hoV0ERaIGmFQH9Yt55uo3LRB7+xuzpDKTXSMIbNhyN3mHBGE68y/7zQuzJOfeJLiA6B/GJD+J+QtERYOYgA2s+qd97LsOrGPLjaiu5hAGKsfRrM+ySj6CM0GdVK//HUEUXwDNQ2ZwKeEqG1v0kBYJ8iHndpALNDxd0tmBUiM6PsRRUrKZDH8ueWsw5FOB3B2tzfym0IgWQijteWdGupoUxGLVmfw9Y9pVtB4mJJW7jb2MYA4eq0R4+lIwtG1uawsC49GEJwT6fxc7hhe2soQXMeOLHmN2hFCVUGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7zwZqYz71LYljQ/uFikr8FzWhvV4VF3i5ow+RwmBpf0=; b=ufu+aboN958pMtMo3Srb7LNFIY7vKjqaIRifl5ExtQHSHTKFUyh1MaFYsCYKkv7zT92CohiKlnKfpJtHbcOgbgVWijDFNEQUH45OiEU0jWgKxNyoFoYGbzF1WamAnIAni8j0NqCkNYy44TG0iH/7YmUKXMA8bnbST8y+uNqedmg= Subject: Re: [PATCH] x86/hvm: Fix double free from vlapic_init() early error path To: Jan Beulich CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20210331133125.7072-1-andrew.cooper3@citrix.com> <95d8688b-2e54-ae02-09ce-45203959e08a@suse.com> From: Andrew Cooper Message-ID: Date: Thu, 1 Apr 2021 14:50:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0028.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:151::15) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 27df3d95-37f7-409a-570d-08d8f51523f3 X-MS-TrafficTypeDiagnostic: BN3PR03MB2132: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TYla9HZ0Pc7n5EUT7IKFyXAqKfwvzeVN8vphDEr0jfBV5aTIBCBAWbUSEw8ndgnN/pN0UQ5a+f6aZ2oE2itYD9RIuKzluv1YLEX4QogKH9yeAbhBxopzsgsWfktg1rvIGQ1i+aWHEVNrv65Z38XBBZgsrMu9lqsHQ3sMsrtKinFRMzUHuFyCMoQgQYCKU7jo4oJMrbLoT96aG+MJ+RKc+PI495YIRquKC8QpTZ3BlPW8RFBLxBfjrxcG9ja7CSj6jdp5qRyhGgdzx1JIqBnPjEPU8tzikm9B+SNMnCxCGsbmP5PPObPi0Fg3JE4qNYoVsE2r4Bg0qRKO3adxdqnnhAJ11jjfcn1X2ny+xuJ7XbO3U2i1+OXg7kfiCxtHiHKTSTdQbAMLEGQgRp3mtDZCX1375Dy3c2dRNoouLuembTOBMMnznykFhib6YeotCwUI2XWh6tMxst4Z+C1NaH6xMvawUyvHz1zdAocmhP0X8rGqVX8rd25MDnncAoTAKL4ghsL2EgoTRGQX7UXWvRIwYXRRg19CrvKrbHWY/jcYdaC1zgvlpRan1pZfVdn9+yLp9A5o/72ezYLRTvq2FJtin22peVwy+gaxDJacYCpbfOBm45P2skTtuMb14rTVVr8G2CWCs/3hx3U6jlKvGobIip+eLgObktFU3pwTe/o2Ut6O4vwJZqlenNlSY9lLbKL5JMYuN+0/Rz0EnNqBHzahBxr/qGIP4TP+BUcaLPrReOI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(376002)(136003)(366004)(39860400002)(346002)(26005)(16576012)(36756003)(4326008)(54906003)(2906002)(5660300002)(16526019)(186003)(2616005)(316002)(956004)(6666004)(6486002)(478600001)(83380400001)(86362001)(8676002)(38100700001)(31696002)(6916009)(66556008)(66476007)(66946007)(8936002)(31686004)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?dlNGOGxkVXNKekRHOE02UlFZREVRYmpydFozMFhkT0pvYlV5SkJRUFhnU09L?= =?utf-8?B?cE9raGRQTUx4ZlI0SEh1d3FEL0E2TnJzb2hFRHRGd0dWSkQ1alJSbUQzWW9X?= =?utf-8?B?VytqTkxXZW1zTTY1eURoRTk2eDFWRXl5TEo4c2czQy9ZbFRLMzVWY2ZyOTJT?= =?utf-8?B?ZFZXZWFQM2krVmJiRXQvcUhIVUZTSUFLOWZJNGd2WEUzWWcra1JoQm10czN1?= =?utf-8?B?c20vSkxidjA1K2VCNnV2YmFDOUVZaVV3eGhYMHMvUEd0RlplcU05WEt6YWNO?= =?utf-8?B?eTdWclNpcUtvNU9mdHNPR0tBWVQ3ajZHRE5TNzArN3FXaW1BcXU3WkFDMjkw?= =?utf-8?B?UWF4OWI4S2pya3pocEk3VFNtekVHdlJ1NDd0dm9mUktxaUFnei82YkJBbUdo?= =?utf-8?B?ejlWUytQQlFLWHZEaTlETEFlZzlGL1Q4Z3BpalFxaFpJNU9FbVJ2eGxJV2Z2?= =?utf-8?B?U29QNTJhamV2Rm55Rld5em5iUVQyN1M1OCszaS83Y3k5RXptTmpWOHJPak9W?= =?utf-8?B?R1JHanNpVVNrSEIyZjdmeTRCeEZkLzVQSXA5bzJCUVFFT3FGTDYyM1pzNTdv?= =?utf-8?B?RzF6dUtQKzhzdEZtbFVCb2Q3dG5uVW1ob3ppOVJvSDZCVnlrbHYzZ2VIdFlh?= =?utf-8?B?YU5KNFc3VitiVkR1UC9Scjg3SHJ5VjBLTGw0b1kyVXROeEZ0cE82Ymd5SSsy?= =?utf-8?B?NytTcW40d0pyNUNnVFBnWWRSaUIyelMxSGFmQmtQWGpCWTlQbWJGVXh6cFdN?= =?utf-8?B?cVhEM3h6VDRSejIrdEo3Qkd3MXk0YWxxTVlQbTEzamI5ZXpDUE5zeEg0dFo1?= =?utf-8?B?cVZsdTRVMEhrSWJkZUNobmRMbFVsc3I0NlFZS0V2YTVzbU1oak1UNlowbTRj?= =?utf-8?B?Z3hUdmtKc05CRkRacTNTU01FV2w4Tm16SVpnRU5jbi83ZUJHdjVBUzlCMVlw?= =?utf-8?B?QjBlU0dpZWt4cFJKRmNVNERkK3d0ekR2NnROTEd3VGRZWVVaRjJwUXFQVlFR?= =?utf-8?B?RTdQSkJxNTdTdGpiaWthYkFlMjZqRnBFVDNVc1kxYXRrdjNYemMrNENON1Zq?= =?utf-8?B?TVlRaDZEWnZ4cWdGNDQ2NlZ2OU4xVWJyR2h6UDhUTExVMDNFejVFMUFnbkQw?= =?utf-8?B?ZGhNdnVpdFJWVkNNQWs0OThYM1FDU0VqS01HSktsVitwRDVXbmNmT05jbWJL?= =?utf-8?B?SEFpUXhibnFXdHJHVCtxTUVIS2tZSTBNdWJNRmhwNXorMFFFNEpETTZGdUFP?= =?utf-8?B?WXNTZFl0WjdiclFNclo1UUFIUlM3TEp3WEczeTRNWkNBQzJqWkR3TkNWdzlQ?= =?utf-8?B?YTdKaUpuNjVXUmhGcXo5UERMb1pkTitKbFJqOHFsZFJFcVJqU2F1WkMrZ1pt?= =?utf-8?B?bVlRSlZPOGZJRHh0TXkzZTVQL3JmekFxemhMODcvc01aeXYzOHVKT0MvekZm?= =?utf-8?B?ZWsreURWUThTMENxLzlCWFRielg5M2grdmpQazUzSzlkRngzMklXK0pFUjFL?= =?utf-8?B?alJORFZLajZob1FZQVJINlRsdkhJcWtnUXFMVVlWRmEzT0JGeUVBM1RXVkFj?= =?utf-8?B?RGlNZXBDWnRTdEc1blVVaGF2NWtEVlIzazZyZldwTG5aMmRjVkpQcS90VFpt?= =?utf-8?B?cUlKKzJEbmRlRzNOYUFTQnl0QkxiUUUxSkhBb1dwVkhnMzhodFhvblVoQ3NQ?= =?utf-8?B?V2JiMHNSTnlqS25DR2N3cVZJYmJoMkdJSDZyalFkOW9abEtHd1E5ZmxUa1di?= =?utf-8?Q?8JyVZNot22ys2mI0zDo0vOY94yrb/ljNzXtoYP/?= X-MS-Exchange-CrossTenant-Network-Message-Id: 27df3d95-37f7-409a-570d-08d8f51523f3 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 13:50:42.0752 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kKOfuio1+nMOxbZQ1o64EpnBZvqhu42eJG9zYxXhSwPOV8rVPbAmvZPeK6Lv1U10nzj51m0O0IV5yQy8xyfaUMRS1HfBVU+ulNXJz5HF/kQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2132 X-OriginatorOrg: citrix.com On 01/04/2021 14:45, Jan Beulich wrote: > On 01.04.2021 15:20, Andrew Cooper wrote: >> On 31/03/2021 15:03, Jan Beulich wrote: >>> On 31.03.2021 15:31, Andrew Cooper wrote: >>>> vlapic_init()'s caller calls vlapic_destroy() on error. Therefore, the error >>>> path from __map_domain_page_global() failing would doubly free >>>> vlapic->regs_page. >>> I'm having difficulty seeing this. What I find at present is >>> >>> rc = vlapic_init(v); >>> if ( rc != 0 ) /* teardown: vlapic_destroy */ >>> goto fail2; >>> >>> and then >>> >>> fail3: >>> vlapic_destroy(v); >>> fail2: >>> >>> Am I missing some important aspect? >> No - I'm blind.  (although I do blame the code comment for being >> actively misleading.) >> >> I retract the patch at this point.  It needs to be part of a bigger >> series making changes like this consistently across the callers. >> >>>> Rework vlapic_destroy() to be properly idempotent, introducing the necessary >>>> UNMAP_DOMAIN_PAGE_GLOBAL() and FREE_DOMHEAP_PAGE() wrappers. >>>> >>>> Rearrange vlapic_init() to group all trivial initialisation, and leave all >>>> cleanup to the caller, in line with our longer term plans. >>> Cleanup functions becoming idempotent is what I understand is the >>> longer term plan. I didn't think this necessarily included leaving >>> cleanup after failure in a function to it caller(s). >> That's literally the point of the exercise. >> >>> At least in the >>> general case I think it would be quite a bit better if functions >>> cleaned up after themselves - perhaps (using the example here) by >>> vlapic_init() calling vlapic_destroy() in such a case. >> That pattern is the cause of code duplication (not a problem per say), >> and many bugs (the problem needing solving) caused by the duplicated >> logic not being equivalent. >> >> We've got the start of the top-level pattern in progress, with >> {domain,vcpu}_create() calling {d,v}_teardown() then {d,v}_destroy() for >> errors. > Hmm, in which case you mean to shift the responsibility not to "the > caller" (many instances) but "the top level caller" (a single > instance)? Yes, but the route to managing that needs to move the responsibility up one level at a time for us not to break things. i.e. we'd next want to make {pv,hvm}_*_create/initialise() call the appropriate {pv,hvm}_*_destroy() covering the entire sub-call-tree. Moving the responsibility across the arch_{d,v}_*() boundaries in particular needs careful coordination. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 01 13:51:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 13:51:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104495.199905 (Exim 4.92) (envelope-from ) id 1lRxj7-0008Sk-6E; Thu, 01 Apr 2021 13:51:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104495.199905; Thu, 01 Apr 2021 13:51:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxj7-0008Sc-37; Thu, 01 Apr 2021 13:51:13 +0000 Received: by outflank-mailman (input) for mailman id 104495; Thu, 01 Apr 2021 13:51:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxj4-0008SP-V6 for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 13:51:10 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1052f36f-ff96-451d-9cef-c8c195c899cb; Thu, 01 Apr 2021 13:51:10 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5612EAF23; Thu, 1 Apr 2021 13:51:09 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1052f36f-ff96-451d-9cef-c8c195c899cb X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617285069; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fi8NRkLY2Xl21wSHVt+bFfZAgzXGbvhBo/c7Ah+W9Qc=; b=iqIRxM9FnyjkHG49s9M2j24tBxnPIIXOZJEumTejx5BnR1qcPgFnBFYcoM+6mKtOgRM1SD +a8VBpXolZKFTXMEC2/hNkLQpDo1NN11ZaDjpqLw3bxoK1M0AVV90mWFrdC86XFSbj10Un 1rfE6Lx227RcAjWdAgICAbsmjG6assQ= Subject: Re: [PATCH 2/8] x86/EFI: sections may not live at VA 0 in PE binaries To: Andrew Cooper Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <5d7c61b0-8441-dccc-4917-cc8a436fd96f@suse.com> From: Jan Beulich Message-ID: Date: Thu, 1 Apr 2021 15:51:08 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 01.04.2021 14:01, Andrew Cooper wrote: > On 01/04/2021 10:44, Jan Beulich wrote: >> PE binaries specify section addresses by (32-bit) RVA. GNU ld up to at >> least 2.36 would silently truncate the (negative) difference when a >> section is placed below the image base. Such sections would also be >> wrongly placed ahead of all "normal" ones. Since, for the time being, >> we build xen.efi with --strip-debug anyway, .stab* can't appear. And >> .comment has an entry in /DISCARD/ already anyway in the EFI case. >> >> Because of their unclear origin, keep the directives for the ELF case >> though. >> >> Signed-off-by: Jan Beulich >> --- >> It's certainly odd that we have stabs section entries in the script, but >> no Dwarf ones. > > Its not odd in the slightest, given the heritage and lack of anyone > touching the linker file unless something is broken. Heritage? Was stabs debug info ever used in any build of Xen? > We've got dwarf symbols in xen-syms, have we not? Yes, and that's why I mention the oddity: We have Dwarf debug info (and hence .debug_* sections) in xen-syms without mentioning them in the script, and we don't have stabs debug info in xen-syms yet we mention the sections. Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 01 13:54:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 13:54:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104499.199917 (Exim 4.92) (envelope-from ) id 1lRxm7-0000Be-L2; Thu, 01 Apr 2021 13:54:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104499.199917; Thu, 01 Apr 2021 13:54:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxm7-0000BX-Hj; Thu, 01 Apr 2021 13:54:19 +0000 Received: by outflank-mailman (input) for mailman id 104499; Thu, 01 Apr 2021 13:54:18 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxm6-0000BS-JQ for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 13:54:18 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 50fd7d08-69a2-40f9-a7ff-da202a5de55d; Thu, 01 Apr 2021 13:54:17 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B3899B032; Thu, 1 Apr 2021 13:54:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50fd7d08-69a2-40f9-a7ff-da202a5de55d X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617285256; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VMkDfyaXT3Qf+q9KsREN8LbjROKtMTKr0L1BcKRLbCQ=; b=DmwuQYiqYKz/GZs4tUCs7WtDBGLEO9fH3Iscn3zpv2+JtDdWIx0nbb9X/Dw1uq3YJtQKDY 0nFouf7R0brZQadDb0wZiJ7RjPZqVA7OdnSZOrDbDbrnMNQpa8BhNJ0e1lk6JyMZHgCJ/9 kUGH0S7J3QxHa0h3MlWB4A2ewlPLY5o= Subject: Re: [PATCH for-4.15 6/7] CHANGELOG.md: Various entries, mostly xenstore To: George Dunlap , xen-devel@lists.xenproject.org Cc: Jan Beulich , Ian Jackson References: <20210401133827.362216-1-george.dunlap@citrix.com> <20210401133827.362216-6-george.dunlap@citrix.com> From: Juergen Gross Message-ID: <0129aa3f-11fb-e0b2-67ce-adc123e2e570@suse.com> Date: Thu, 1 Apr 2021 15:54:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210401133827.362216-6-george.dunlap@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="txtaXjZtXwK228Hfcsao6lMM05R6M98RA" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --txtaXjZtXwK228Hfcsao6lMM05R6M98RA Content-Type: multipart/mixed; boundary="2AoFY3WGoMHVLNb07D1AI89dJZ1BS3HzO"; protected-headers="v1" From: Juergen Gross To: George Dunlap , xen-devel@lists.xenproject.org Cc: Jan Beulich , Ian Jackson Message-ID: <0129aa3f-11fb-e0b2-67ce-adc123e2e570@suse.com> Subject: Re: [PATCH for-4.15 6/7] CHANGELOG.md: Various entries, mostly xenstore References: <20210401133827.362216-1-george.dunlap@citrix.com> <20210401133827.362216-6-george.dunlap@citrix.com> In-Reply-To: <20210401133827.362216-6-george.dunlap@citrix.com> --2AoFY3WGoMHVLNb07D1AI89dJZ1BS3HzO Content-Type: multipart/mixed; boundary="------------11319C3BF0F1F4AAADE159BD" Content-Language: en-US This is a multi-part message in MIME format. --------------11319C3BF0F1F4AAADE159BD Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 01.04.21 15:38, George Dunlap wrote: > ...grouped by submitters / maintainers >=20 > Signed-off-by: George Dunlap Reviewed-by: Juergen Gross Juergen --------------11319C3BF0F1F4AAADE159BD Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------11319C3BF0F1F4AAADE159BD-- --2AoFY3WGoMHVLNb07D1AI89dJZ1BS3HzO-- --txtaXjZtXwK228Hfcsao6lMM05R6M98RA Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBl0IcFAwAAAAAACgkQsN6d1ii/Ey8c TAf/RjgETuP1fgwTCPi5deAALSBPtaRKKskwhoJsP0f3msXrcFDU2oe8EAMS0z+VQ7H6LUYEp3L9 6oM68ek/Qp2DTiT/OmuJJHgn05uxfgRKyLjSBmBLmx9vZl55959GnUG2e0rdh0FkJdipqXdGSLAG JYSNYgM91QvdkQFDxc5GiuxFEhwHJF6WPVb3J5Psro5Dm20uUCYMk7RVLuQmFz5qw590gP0UOMsu DHxKG1oRvDyktIQdggwBQsHNyImCrYqv+2LIf0rP8zru6MHFBNsFt5VCm7XNgQEC1tYG4qWEqxJL F39xK1b0a1eYr/Yi5LS49gwpMI6vRXlbc9ca6nvmzw== =23e7 -----END PGP SIGNATURE----- --txtaXjZtXwK228Hfcsao6lMM05R6M98RA-- From xen-devel-bounces@lists.xenproject.org Thu Apr 01 13:56:51 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 13:56:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104504.199929 (Exim 4.92) (envelope-from ) id 1lRxoW-0000MF-6n; Thu, 01 Apr 2021 13:56:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104504.199929; Thu, 01 Apr 2021 13:56:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxoW-0000M8-3P; Thu, 01 Apr 2021 13:56:48 +0000 Received: by outflank-mailman (input) for mailman id 104504; Thu, 01 Apr 2021 13:56:47 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxoV-0000M3-0V for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 13:56:47 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 79ab37f0-2baf-4b84-b319-adb9cf9b024c; Thu, 01 Apr 2021 13:56:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 79ab37f0-2baf-4b84-b319-adb9cf9b024c DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617285405; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=Ppq0oYnJWuRofMlk4/okEP9xt7+iPhYUXOxpxccoH7I=; b=ib5oMsaW7SQRtOeSmsH84fUnqbyC9MoQGWVRe3klgcoNIftDnMLteR/W mhWmiwXH/M0XPBKFdmWZT6aUcEtflZB5rwFU+hP8jSIMazQ4T7SZLknVs pFJlCnnR2tLW7KNr+KOS7GKfcCay2DzPJp+25eW1E6+hvNfLZqynrNybe 8=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 7JS8cJrRJ22H9cNL9IYCiec/zuCz66QRiHfo5/O79ZfNRu/0g6D4Ufz2m56NlLLqr91MIL04WN knCbw827tcywRaztZD5IlpWTeh8lROIeg6ztWp2nPB+JTaDb5TGUTsJeyBpf3ApZ1CfPYwrkmj Byfgmw0Xhk94nG7tCc+8NJLr6mSBHFw1JXPWrO9WWJEggVuM/bs1lquqczV42KAH/AWt5Ki6XA lk2/2/lWq4Ojn0x9bAf1tEXkPAgZGnXbb+mLkp8EgnY9KydbR/3Q3107q8ZM5eKsCLN3K1cQ58 jlg= X-SBRS: 5.2 X-MesageID: 42152682 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:hVKiUq+jb9UX0jyIBNZuk+FZcL1zdoIgy1knxilNYDRvWIixi9 2ukPMH1RX9lTYWXzUalcqdPbSbKEmwybdc2qNUGbu5RgHptC+TLI9k5Zb/2DGIIUfD38Zn/+ Nbf6B6YeeaMXFTh8z3+RT9Nt4mzsWO/qzAv5an815GSwZ2Z6Z8qyJwDQiGGkN7LTM2fqYRPp ya+8ZBun6caW0aB/7LTEUtcsrig5nwlJzgaQMbHBJP0mWzpB6h9bKSKWn94j4wSDVKqI1CzU HklEjD6ryno7WHzHbnphbuxrB3vPek9ddZHsyLjaEuW3jRoyKlfp5oVbHHnB1dmpDJ1H8QnN PBowgtMq1Ighu/EF2dmhfj1xLt1zwj8RbZuDmlqEH+qs/0Ti9SMbsjuatlcwDU40dlnNZw3L Mj5RP9i7NrDAjNlCm42t7QVxsCrDvXnVMel4co70B3YM87Uvt8vIYf9ERaHNMrByTh8r0qF+ FoEYX1+OtWWUnyVQGXgkBfhPiXGlgjFBaPRUYP/uaP1SJNoXx/x0wEgOQCg3Y78o4nQZUs3Z WLDo1Y0JV1CuMGZ6N0A+kMBeGtDHbWfB7KOGWOZXPqCb8AIHCIj5Ls+r066KWLdfUzvdoPsa WEdGkdmX85ekroB8HL9oZM6ArxTGK0WimoxdpZ45R/p73gVLvmOSCOUzkV4oidisRaJveed+ e4OZpQDfOmB3DpA5x10wr3XIQXKXR2arxWhv8LH3a15u7bIIzjseLWNNzJIqD2LDoiUmTjRn 8KXD35ItRc/lmmM0WIxST5ajfIQAjS7JhwGK/V86w4044WLLBBtQATlBC+/cGEKTpLt6QsZ0 tgKLb7kqe2zFPGvVrg3iFMAF5wH0xV6LLvXzdhvgkRKX75dr4FppGCY2xIxWCGIRV+VsvSFw Zaqz1MiOaKBq3V4RpnJ8OsM2qcgXdWmWmDSI0EnLafoe3/fIkjM5ogUKttNAnCGhBvgzx2oG NbZAJsfD6ZKhrezYGeyL0dHqX2asR1igbDG78vlVvv8WGn4fwJalRedTi0SsKTiRspXFNv9y BM2p5apqGBlzapIXY4m8IiPjR3GSiqKbpbEQWIY5hVkLj3eAd2CXyHnyCelgtbQBuUy2wPnG D7aSWbdfbXa2Atxkxww+Lk9kh5eX6aeF81YndmsZdlHWCDoXpr1/SXD5DDmle5ex8HwusHNi vCbiZXKgRyx8qv3Br9okf0KVw2gpEvNPfaFrItbvXa3W6sMpSBkeUDE+VP9JhocNDovelja5 PoRyaFaDf5AfguwQqbuzIsPzR1smAtlbfwwwL+hVLIrkIXEL7XOhBrVrsbK9aT4yztQOuJyo xwiZYwsfGrOmv8Z9aawcjsHnZ+AwKWpXTzQ/AjqJhSs653rrd1EpXBWTbD1X1M3nwFXbPJvV JbRL4+7KHKO4dpccBXZjlQ+UAxks+TaEQsqQ77D4YFDBoQpm6eO8nM5bXGqbAiWBLc4ATxPE SS6C1b8bPOWTCZ2bsTFqI3JiBXZSEHmQRf1fLHc5eVDgOgM/xH9h69NHS2dbdGUqiLGbkKtH 9BkqS1tv7SczC9wRzauDtwP7lH/GmmS96jGQ7kI584z/WqfVCXxraw6MG9jD3rWSK2ZkQRi4 pCb1ERZK14+0ofpZxy1DOzRKzxql8klFUb4SgPrC+S5rSb X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="42152682" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E6w0BnwO74mTKtkEQNBNIrliss3g77WX6uc9gOcmuUIlsed62w5icEkl5j4pt61Be1a6BNmU/puYLQtlMyG4FhtKHxaWTFFWisRWLuI8r4+r8G3ItDhKmMAzAG2QnDvvaycKeq5bu36GhjpKAo2HcOPARv8AnBWapn6dTSEZOKU+GktFNDeR3LCQ7KReCAgWfa14bgQGw1C3OqDv22PmZaVt/mBgN5jHYjfeyghqplP709IhK/GkKOp889kzB3STFECWZ0vzoEWpatFTFh9+BPAKxY1BJs7B1obJrYVvwy6kle4pOsg1Vii4stxnprU2zto5ewm2JdvGlat2NoZZ8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J5+D+aArvR5hMHffV4e5iFgHgIfMNVyNOY3VbxMJd5w=; b=ZW6a39PvHk0MwAgW+JjqA04zbvfTPhKzidL9/5DTFKFEWH1gvFZExlugfqIRevdY44eM+pOfEHYh6iG3d35zVUraatucjG2s3JzL231siwjxcqBA/TfR+zi4zhIj4IwRd5mzarOQQitazvXTvjVrdlTeWiZEMvJMp3VkVSEWX+Iv4986uFDKUhl++DugL7uBaJUUBmIPWbTSMSyVRGluJtRg+61mNaQYb6ehp7znguD4pw13ijVzcuDsMvgMkHrmC9XcWWepTnH4XJPijbG7Sj3JDRhh5ChcdKXaGF+12MqQ7G0OpQ/WleD4c1PytBjcaodq9HUGt9h5WspJ5psRfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J5+D+aArvR5hMHffV4e5iFgHgIfMNVyNOY3VbxMJd5w=; b=dWxsXcLIrV/lxs+XvN81Uj/7tRm2R8dOntL9PIgFhiomiTemF/BWXZH7SyeujS6oZdEUIA/fAjdIg43oiJAMtFmXW7roLi6WPRpiNhJ7Jb6bxg4XbKVwgWm11lC3YwuYtFdFbI2d4UvLnq84esfDxfXfjKManMtpZqSpQHEKBwc= To: Roger Pau Monne , CC: Ian Jackson , Wei Liu References: <20210323095849.37858-1-roger.pau@citrix.com> <20210323095849.37858-5-roger.pau@citrix.com> From: Andrew Cooper Subject: Re: [PATCH 04/21] libs/guest: introduce helper to fetch a system cpu policy Message-ID: Date: Thu, 1 Apr 2021 14:56:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <20210323095849.37858-5-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P123CA0011.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::23) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 936b6b9e-56b8-4ee3-1d0c-08d8f515faa8 X-MS-TrafficTypeDiagnostic: BN8PR03MB4882: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:324; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SAEp0h+coLl3+USDXgFk3HLZvWdZqyOBCpbfFh9vSVyz9piAldQopDlYdZ+TNyco34bEYgeBGooo9U9Ts6fcHIxNQESXdHGJlf2V22LTdg7VoVpXWsyS/YslGZKd+79yEIUTGh3e7LowWogm/KM/8hque5hLpzigOhDmUx9NfBLJBalcN7qdZgPYr83RhHVZZyOs01mcZel6ML2ZpBcm99hodHYnt8XFbQLPxOligs8Ih0LY3jloASy7rMsCFN++vsw/rNEYmofDVXYdJloVpfsSSklSmklrfmxwfU1MdWezDe86F1VA1rg7aQ9B/ovWiGLJyEV+tcybd/EJytjOve8kMx/CFOsedqdk/T9fa4MqodcWhLJtpPVy+x3VVWMGBEh2WwE6t+wtTSCSPq6vMRq5BJ0M3hKkkJwZqEsTzH9llVr6IjyD4f0hDmiUk2nbVO3ciPAS03xrFcI1/KQSDAxanZ7s92hIw3xXGylxo5hVVea6u1X4PQc2ljTxf8vIQ6IcSwAHSc9sEqoRiqvj4/D77aFmsRAMdwh36R0PdnNhblPssrUMyLZ6pDg11kkb1pl2Gcep7w9kdACiOIiQhzp+jeZAU2krjFpw1+ViONo0U3htkYtv7XfGB6To0Z/8DPj33aj88+GycE87pDpr6u2NVXZbNRiZ8RIL/VfI48KwIIfHYL2A8yWFNIDprrhlrECHfUPVTmjdYa3ZEQrIKn5Y4Im9d5OpgG21KbazAYQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(376002)(366004)(39860400002)(396003)(136003)(6486002)(2906002)(186003)(956004)(54906003)(16526019)(86362001)(316002)(2616005)(478600001)(31696002)(66946007)(6666004)(8936002)(16576012)(26005)(38100700001)(53546011)(31686004)(4326008)(8676002)(5660300002)(66556008)(66476007)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Mm5BaDhudWdGYnp5NGZIVU1DNlJSSkE4N2RSaFNtck5Ic05lWFpDQkZGVmhs?= =?utf-8?B?L09WdDJ6cTh1cWlkYjlGYTlBc05NYTE1aHozMlpNUG43d1BsVFJsYmFqTmRj?= =?utf-8?B?YUdZU3F2NVFjSXNReGJZVi9tcW1LcW1zU0pQelpJcmh4UzVXRGZqemw4Ylgw?= =?utf-8?B?TXlsWkR2SDJpYmN5RWJGWTczNWFraSt5R1lTSGk2aHhtb3hzK1NsclZGbEgw?= =?utf-8?B?YkY1bm1jRW0xcDIvOW9HMkpWZ1liTXd6eklPLzVndUw3OFk4S1ZhMzg2ekt6?= =?utf-8?B?M25PMVNBTmRlaytiWlBoMmdoTHhFM3J5VWJYU3J4aXdEaFM2cVg0dGw2cDdn?= =?utf-8?B?THh0aUZtRGNFQ0VJdVU1bDFIWElJd0ordmpwYTZFdXcxOCs3YXVSMzRMVThF?= =?utf-8?B?aG5lSkowcGlXdnNTZVk5dDFPSzJ4RkpQRlBBM1gvbHdBNDJGdVlxaVMyZEFB?= =?utf-8?B?OW1lVjhBOUtRTmo4M1VmQVV3YThlc1g1ZXBPUVhuVFI1ZzljbHlFTHNFWTVL?= =?utf-8?B?emJmSk9HUUFvU2E5WlpZeGVyaU1Ld0JRQXp5YnZwdktJczV0SC8rTTRaR2JK?= =?utf-8?B?RmpvdzNnK3E4M1Nxc3IyWXplUFVjeHMyRUhKWnZrVlhQZi9SWHVqV1U3U3o0?= =?utf-8?B?K2xWYUJKYXBBdUoyTFlscWtsYjgrd1pOZGJVc254UnZtNzJFS0JzRXRSUEhV?= =?utf-8?B?NGJiWEQvbTUyZjJtTDJMUTBQeDcwS2ZpRmtNRDdOQWVEMFlXVkhxYXljVzZ1?= =?utf-8?B?Zy9EVjkvWk9zSVNueU1udG9VbVp2MDJHSjd4d3JlMzh2T1gvYlhUSW16N2Zs?= =?utf-8?B?T3FHMWsvelVSOE9DZU5kOXpyeDhoZlhqWjhGQ3RCQXkvZnVOY29IZnJNNGRn?= =?utf-8?B?Mzk3ZUFDZnFEL1FzMlFKTUVPdGZtUjkyaHYrczlodkplL2ZIRENlSXFvYlBa?= =?utf-8?B?VkkzQ3d6K0RYY1dqU01QZ2F3T3BhSlpKRVZ1dUZ1eVhQclZDUHJuek5BZnpW?= =?utf-8?B?V1IxajFyT1A0RWlaZzRaRnpoQjg5Y1BVL2NOdklGd0FQOVk4K0NnYmNhZ0Rh?= =?utf-8?B?MzVRMFdGNzZKUnZqYkhwTGN6ZTRMbE5EcUR6YTREdkZJejhjT3NzMWJHb0lu?= =?utf-8?B?U3A1VGdmOWs0enBqT2htOUFMU1JzN0ordGNldXg5Rzh1WVBPUUVvaC9JSGY0?= =?utf-8?B?a1ZEaDY1RkRETmdISjQrNTB3dnY1NkljVjhPQ2xwUFlrRDBEaldlYTZ1ekc5?= =?utf-8?B?c1BUVWMzNWZQZExlb1JkNjhNRE5md2dpUXZTWDF3RWRLSy94d0x0WnBZdDAr?= =?utf-8?B?aVlacExpYURFV0Fxc2V4Z1NXcjJhNHpTTlR4TXdMbUVaYXEzZ08zUUYrd0VP?= =?utf-8?B?K1RkTHJUbWJqcDVtTEIzZzBxcTc3SmZya2ZWNVpjb1psbUhEM2pYSWJUU2VX?= =?utf-8?B?NG0yR3R5S0pQUmJDSWVKa25TVks3QlJMTzVZanpGVkJRclFoRWZhZHowQ0dN?= =?utf-8?B?bnRGVjVvaGc5YlNOZHRUZktQb1JBSnA0VzAvTmJxREpuMU5WM0VCdWZqSllO?= =?utf-8?B?elI4N1lzYzk3OURsMVZMSXBLSGxHTDduNGZobVhxTW9zZW80bUc1WVBwRTNo?= =?utf-8?B?Tkh2ZGhDWlpBaEZhdis1bDNEeHhYUmFQZm9INmFsYmt3YXNGZGo0SUE4UnFy?= =?utf-8?B?TzVxUXp0bDlLVTBXM3N0VmJBNHJvZjEvUFJFWHlmRGF2S1VRZDBPeU1kNnFK?= =?utf-8?Q?vD4MHmU2HerFvHNENfuhFKr0zjU5QVdHsm2DuqT?= X-MS-Exchange-CrossTenant-Network-Message-Id: 936b6b9e-56b8-4ee3-1d0c-08d8f515faa8 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 13:56:42.3163 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PAD8fNg9nzPwzg/eLF40hYpW+tCN5UivrBHzbh9eTRfFkZ9eQfVUeDRdBeUpN3GL/wbj/lxviq4RXvKtmVZzx/x2tO40/lunwJMxtHoIoGc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB4882 X-OriginatorOrg: citrix.com On 23/03/2021 09:58, Roger Pau Monne wrote: > Such helper is based on the existing functions to fetch a CPUID and > MSR policies, but uses the xc_cpu_policy_t type to return the data to > the caller. > > Note some helper functions are introduced, those are split from > xc_cpu_policy_get_system because they will be used by other functions > also. > > No user of the interface introduced on the patch. > > Signed-off-by: Roger Pau Monn=C3=A9 > --- > tools/include/xenctrl.h | 4 ++ > tools/libs/guest/xg_cpuid_x86.c | 90 +++++++++++++++++++++++++++++++++ > 2 files changed, 94 insertions(+) > > diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h > index ffb3024bfeb..fc8e4b28781 100644 > --- a/tools/include/xenctrl.h > +++ b/tools/include/xenctrl.h > @@ -2596,6 +2596,10 @@ typedef struct cpu_policy *xc_cpu_policy_t; > xc_cpu_policy_t xc_cpu_policy_init(void); > void xc_cpu_policy_destroy(xc_cpu_policy_t policy); > =20 > +/* Retrieve a system policy, or get/set a domains policy. */ > +int xc_cpu_policy_get_system(xc_interface *xch, unsigned int idx, > + xc_cpu_policy_t policy); I'd recommend "policy_idx" as the parameter name. > +static int deserialize_policy(xc_interface *xch, xc_cpu_policy_t policy, > + unsigned int nr_leaves, > + const xen_cpuid_leaf_t *leaves, > + unsigned int nr_msrs, const xen_msr_entry_= t *msrs) > +{ > + uint32_t err_leaf =3D -1, err_subleaf =3D -1, err_msr =3D -1; > + int rc; > + > + rc =3D x86_cpuid_copy_from_buffer(policy->cpuid, leaves, nr_leaves, > + &err_leaf, &err_subleaf); > + if ( rc ) > + { > + ERROR("Failed to deserialise CPUID (err leaf %#x, subleaf %#x) (= %d =3D %s)", > + err_leaf, err_subleaf, -rc, strerror(-rc)); > + return rc; > + } > + > + rc =3D x86_msr_copy_from_buffer(policy->msr, msrs, nr_msrs, &err_msr= ); > + if ( rc ) > + { > + ERROR("Failed to deserialise MSR (err MSR %#x) (%d =3D %s)", > + err_msr, -rc, strerror(-rc)); We possibly want to split out helpers to render the error information.=C2= =A0 For MSRs, it ought to be something like if ( msr =3D=3D -1 ) =C2=A0=C2=A0=C2=A0 // general -ENOMEM etc else =C2=A0=C2=A0=C2=A0 // MSR-specific error.=C2=A0 render index and value. I think we can probably even depend on MSR-specific errors always being -EINVAL. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 01 14:00:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 14:00:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104507.199941 (Exim 4.92) (envelope-from ) id 1lRxsN-0001ID-Nw; Thu, 01 Apr 2021 14:00:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104507.199941; Thu, 01 Apr 2021 14:00:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxsN-0001I6-Kp; Thu, 01 Apr 2021 14:00:47 +0000 Received: by outflank-mailman (input) for mailman id 104507; Thu, 01 Apr 2021 14:00:46 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxsM-0001I1-7y for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 14:00:46 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 58d20fec-1f3e-489c-ac47-f51429ad5397; Thu, 01 Apr 2021 14:00:44 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 58d20fec-1f3e-489c-ac47-f51429ad5397 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617285644; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=C73Pd4ceP/D/YEBjUB7YwX9APTcL/8vrdofjkKqfH3E=; b=fomrScFzysX2zkT6//obF7n3xOlelH/97n7w6E3eS0/EcXarGFh6kL9M S/EIU3craOFoV3//QEmZ5Dk+AbikjsBiUNCxyDh5kCTSPQt0eJC9lORN7 eX5o8DND6lvTTft6GUypwfPhG44dfartIxZb5BfajuOPJt76OuNVF4TSE w=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: szbrlNACxLrexQmE1Oc9RstcF2x+WnndYYhbsUgOlnOECH7bgMn/jClUCRck1hhNSABb1rt9Mv SVmcQKwLD3WOJdIUZk7YwN/UiUoxL3IALrqEHMG5aouh8qLikRx4C6fNUAVc1ryzhavj8sg3nl EyF4Ypi/NhjBTxd5DRjGh5DJyzS9p9Bqdi+qgtjs4ii5IoQgP4r3UTcUQUNsO3P+UX0ICrMP23 f7XRFSOCP3XN8oqGDIJA9Ov5qi7vt8hfqghkqe0wf0CPQZdph0hiaoJ4skWUQ8MnDDqVvKPtUS UCc= X-SBRS: 5.2 X-MesageID: 40700716 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:YsI9paoKu1xG8O5v6X8f0wkaV5uGKtV00zAX/kB9WHVpW+SivY SHgOkb2RjoiDwYRXEnnpS6NLOdRG7HnKQb3aA4Bp3neAX9omOnIMVZ7YXkyyD9ACGWzIJg/I 9aWexFBNX0ZGIWse/T/BS4H9E8wNOO7aCvgqPkw21wSBxxApsA0y5SIG+gYylLbSNBAoc0E4 fZw8JBqSapd3h/VLXFOlAuWe/fq9rX0K/8aRkdCBI9rCWIhzWk6Ln1eiLoois2eTVJ3Lsk7C z5gxX0j5/Tzs2T5z398yvo75pQkMb80dcrPqKxo+UcNzmEsHfRWK1PQLuH1QpFxt2HyFFvq9 XUpgdlAsIb0QKqQkiQgT/Anzbtyywv7XiK8y7qvVLGrdbiTDw3T+pt7LgpCyfx0EYrsNFi3K 8j5Qvw3PA2fHCw6RjV3NTGWwpnkUC5uxMZ4IkupkdSTJcEb/tppZEflXklYKsoJj7w64wsDY BVfaPhzctRGGnqCkzxgnNi25iFUHg1A369MzM/k/3Q+T1XkHdl9lAf1cwSk1wRnahNOqVs1q DqNL9lm6pJSdJTRaVhBP0ZSc/yMWDVRwnQWVjibmjPJeUiATbgupT36LI66KWDf4EJ9oI7nN DkXElDvWA/VkryAaS1rdN22yGIZF/4cSXmy8lY6ZQ8kKb7XqDXPSqKT01ru9e8ot0Ea/erGM qbCdZzObvOPGHuEYFG00nVQJ9JM0QTV8UTp5ISR0+OmMTWMYfn39arMMr7Ff7IK3IJS2n/Cn wMUHzYP8Nb9H2mXXf+nVz/QHXoVkvj/Y9hMaTT8uQJobJ9c7Fkg0wwsxCU98uLITpNvugdZ0 1lOo7qlau9uC2X8A/zniFUEysYKnwQzKTrUntMqwNPGVjza6w/t9KWfn0X+HOGIxR4Xv7HCQ I3nSUxxYuHa7irgQwyAdOuNWyXy1EJomiRcpsakqqfoeDoZ40/FZRjfKBqDw3EG1hUlG9R2S Z+QT5BYnWaOiLliK2jgpBRLvrYbcNAjACiJtMRj2neu0WarcQGXWAaQDaqbM6SjW8VNnhpr2 w015VarKuLmD6pJ2d6qv8/KkdwZGOeB68DMB6If7xOmrfgeBh5SECDgTDysWB0RkPas2Epwk DxJyydfv/GRn5QoGpR3KrR/FRoTWmFZE5rZndmsYpyKHTeth9IoJ22T5v291HURkoJw+kbPj 2AWzcULw907/2c1RKeml+5ZD8b76RrGtaYIKUocrnV1H/oFZaBkrseGeRIuLx/Msr1j+MNWe WDWgOcIT/iEdk10wiNqntNAlgslFAU1dfTnDH15mmx23AyRcfIKFN9XrcBPpWy6XPnS/vg6u QxsfsF+c+LdkP/Zd6NxfuJM3ptKhbPrXW3SO9tg5ZOpq42vKZyGZ6ecTag7gAx4DwOaOPP0G UZS+BHxZqEHKlFVckbYThY8Vokj87nFjphjiXGRssFOWgwhHraNe6T67XGqbATElSMzTGATW W3wml4xbP5RCON2r4RNrIoLUlXYEY67m5+/OnqTfynNCyaM8VC9kG9KHmzbft0T7WEA6wZqn 9Bkpy1tt7SUyrzwwbLuzRnZopI7ma8WMu3RCaBA/RB/dD/GVOChMKRkYKOpQaybTuwcEIDg4 JZMWQWc8RYkzEnyLQN7RLacN2+nmsV131E4T9mkVbx2o+ppEfjdHs2TzHxs9FxRjlcMn+BkM Lf1/OXvU6NuAR45Q== X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="40700716" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=chzLzPIBjaRAaMYlcGfOnEGgIpdxbUdjRWwD1hh5xE16qVlGz+yPxPGr1KEcGunUkbOBEH7Gm1DWuj+ECOhEpwgovo23ddQP1eLlj+WEKIn91uUSmBfNQ1uwvMZZiZlFMdxanoMEOQ1Vy4hfUT58FfwOU84I/HC7Nr0mUMBBkRZNRjSiXTu1YT/jqnsOU6Q++nZEWerlnAOt/op987FXBSUSRcLzuJPjueZaEvrtlwpC6lq2CCcGbPrWZ+/WC60qruCDsSdxqQSJoD1knOg6k66b5OyJS4tNEsrgstUJ+ZEqOQnraaxd+KrWpXi1uFRwHIouMDxUgT3sbnksYEu5Vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6ioUgUKguW/HD9IrIpUOvi0JBwfDa+xZmXShjaADYv8=; b=jBxTHCLb8P4eZ/TAUkCQTMa3xYjrwFoF6BFpbrYwFc2sfvXYFRpVRBdNF9IFlwOuGb4UhSngSCGWo/bQ0s92jNXJURknZ5a/qtCba6SnT07eJtNQ0cWIz1Op5Eac15KxzQ9QmmwVzJuKbXMNlCpIQsiLyvaRw7KYtD4Ver5cEE7rXLyBfzG5Ez8irBN2vgz6pM8bIYP+AyaKRFISMhaDSjg+EMPICiAIszuEN/Qvts5eNQ+3WmgCucOStXqODUVe71F7otgUZ6uh6JHSNj2AZnyw3eG9vGT2eHOfbTRbwuRpx+yDzggihgcXhn+Ea98w9qI9FNdYyBVD6uDgrSabRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6ioUgUKguW/HD9IrIpUOvi0JBwfDa+xZmXShjaADYv8=; b=pWi0P7bmnvaZnNU9e8h1AmzDS5MQAz0gMQr6RwyEkL+zo7rTuD2Tf0LLsxucN26OvDlzkhbJqNCCdIrzV7LM3pAnsBGMeL8Bx9jPjVUH+d5eZSxzSd3I3wxtlIhTGa0Zv6ku8n+ljBJVhVaMrVEuBH2jKMMq8aFC5ds6ofds6Xs= Subject: Re: [PATCH for-4.15 6/7] CHANGELOG.md: Various entries, mostly xenstore To: George Dunlap , CC: Juergen Gross , Jan Beulich , Ian Jackson References: <20210401133827.362216-1-george.dunlap@citrix.com> <20210401133827.362216-6-george.dunlap@citrix.com> From: Andrew Cooper Message-ID: <97d317fb-16d7-a14e-e74e-62fa83159838@citrix.com> Date: Thu, 1 Apr 2021 15:00:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <20210401133827.362216-6-george.dunlap@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0308.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:197::7) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5ee72e24-1ec9-476f-8ce4-08d8f516889d X-MS-TrafficTypeDiagnostic: BN3PR03MB2372: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eQ5vFuq045yHjtTWrMpB8ReU5LCzGRRk9mxZHMuABR3ae20PfJ5CSZcnXjP8ZmAJDqy4Ms11kVmMkKaRXZTcrNbRF1oZPfNZqHk0wRSFhSLFOeOXxyu40OpYFXIkH+IYsbe1bpE1ltPHNHwCuB39rQkXAoMKFQH6qb7irdgz8Bp1MLEf3wS9beqT6R6pSQpKSfx3KYYVjH02BGQeq0scV3z7SlWjV3kjdcDLGV413ev+UDIJ5WHcu4cT8KZ/FLWs4i/A3bn5UbNBcTBwZofqTnfWh8ksBAEI7vZn8uIRcGxJ9nk8qXT++pEt00HR34qFBxVu3JA0CYSt7aUgi4pLDEzoEhacMuqUqFRULzKEICbxg9/Yn63fO+YepWthCzFr+g9wVJE8zmYckvxIAPXxFETOFG0do1GU1HZ7eW7q3lIc3uBa4OLyJyuh9L5fSB/VtiAyKat+6+sCQY6zA6737NEUSrguTxbm244attXCD/oWc+pk3t0Czuyu6/Y90SOiqzoqaIjH3LyncBlJ4bmNtjvtv9NSFdgZngorH+N8PIckVO7GroGx1qGCcRaDDeJHeincp/OmeIyS/FbvDFXDsHfX3s5BlPyjfNWCLt5Vgs9v6NwpF/rkU6USuTBi46e/rKWoHh+5uVNuq/Y9dge7xfP7OA1RTgEoxjHnsXeI2gciLxPcLt0r0LIs2Ooz85YFsY7HU7KkmwHDaXfgfxX838iF9TJ7xbkyYmx+1qVC1aiXr5wC0bxRgLwC/oJOuqQX2S5lXZ6a2tdoh7qAqls8hpOSAIHgilgMiL3yo3EJzvzoCQIROeFZ/20Q2dwmg1USBOeAvKO/ClUvVKZA87iw7j/1jWYtuxLy4idgaNW+5zNtBbCvURsN8uJlt2EeDr+H X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(136003)(396003)(346002)(39860400002)(366004)(8676002)(31686004)(8936002)(31696002)(186003)(6666004)(2616005)(956004)(54906003)(107886003)(26005)(83380400001)(16526019)(6486002)(36756003)(86362001)(16576012)(316002)(478600001)(66946007)(4326008)(38100700001)(53546011)(66556008)(66476007)(5660300002)(2906002)(59356011)(207903002)(219803003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?OGpPWFU0SVZnRFBKQmJFK0JsQUtkdTdtZWJtUUxmWTUwUUg4Szl5M2x4S3lL?= =?utf-8?B?djQ5ZE9xb0p3NGx3WVFRSm5yZ0ZxU1FjKy9ISXpkZVIrLzBUeTZNVzNQYjZE?= =?utf-8?B?Q3FtUlRaWkFKOURnNTZDeG0zeTZFdExkeE16eExxKzlJY0xQb1RMdGpaaDIr?= =?utf-8?B?RFAvdHFqdWo4Y0pld1o1ZEtQWTV4WFRKa1VQelpwdGlkZWU0SEltRXlzazg0?= =?utf-8?B?UUJiNFRTZkJSc292NDd1T3FseHY4SlZmMDZ0Nm9jVURQcXhyRjh6RVJDVmV6?= =?utf-8?B?WTl3ZjlQMFRtV2VJMGlXL0RjTlllSmFBZ0hITkIyRzlZTk5nMGJ2VG8raC9S?= =?utf-8?B?cHZodjBPaVR2TDdIRUVDQjlPenY0SkpCd205d0RRREgrTVhkZ1pzQkxSK1M3?= =?utf-8?B?aExlWERFWUVQdXMrWnBnQUJLUzZ5dlg0UHJ6MzV0Zk04d2RnckZ6MElOUTR5?= =?utf-8?B?K3pQeExmb1YxTU0weEpiaWJFMzg2NUs4T2lGZDdhM2FVcjhVOWtQYTlobElO?= =?utf-8?B?bzVudDJVTlhaSGw0UmlJZnhqN2FDUG85TThoaDN6cUtMNUFWRk1naklQS2ZE?= =?utf-8?B?YkQ1c3RMSXY1dHRmSnlJdkRickU0MEZRWHlnbG4vZVJJVXNJR09IYWpGS2s5?= =?utf-8?B?bS9MMjM1V0F1TG9kZk00bENidmZxUkNFMUE2T3RCUFd3RTJZTDd4R25jRHJG?= =?utf-8?B?bjV1R0NoV2I3SGRUMUErWDFFMElVa2ozUG05YWRySGJjUy8rbC9uQXF2MmZO?= =?utf-8?B?eVdITzdiamZRLzFwSjZHbGFXcGU1aXZERVo4emx3R2JoaWI5blBCVW9mMjNS?= =?utf-8?B?WTdDVXNrZk1oSElzcHZYV25TQnZwUFdYZVhSemtGY0hUNWx4cVY0dEtYUk4x?= =?utf-8?B?NDRscEdoZnVRZmt3Nm9vYjZ3Y3VOeDUrU203MmZvK0lEeDFURi9INGQ5OC9n?= =?utf-8?B?TitoS1hvSzBFZDFMUWxqZmtpWWFNdVhRVXJTVGs0THViSFc4L3ZkYktSekFX?= =?utf-8?B?VTF4THhpeHUrMThlcFlWMC9TWHRzSWF0Vm5mQ0hrMHhGYWlQbjdackgwY3NW?= =?utf-8?B?bWJJZDlGQkE2MlRCWHYxelB6WDl0eTFGcHNlMnFmakYzVk0wdUZ3RDhXMmNu?= =?utf-8?B?Mnoyb01QUWxlVTFkZkdDQkRKZS91MnNBVVExUGlKN1hJTGhVZUtVWXFJRHpm?= =?utf-8?B?Q2Z0blhTVlV2L0VZdlg0L0dDUjQ4R0NoaGtLQnVHelJtSWtqZzhGUjAzVmFO?= =?utf-8?B?SkRGczExenJvMVZvM25MYStON2JMM0RacWxxVER5TnN0VnYyTUxvaHg1WHR4?= =?utf-8?B?N29QQmtvMTkveFZNRkRRT1lET1BDNkNvTUJGMXVwY2tGbU0vQWtGckM0QkQ2?= =?utf-8?B?QmZYOEhnTHJLbUpXRm81OEtscG1Qc2c0VXpnRXRDbE4rRnFmOGgxMFNZSnR2?= =?utf-8?B?ekQ3YXdYNnhRVGFyNkdTMHRPNFd0NER1dzloZ1dNaWlybjlLejNHOWpNZnEr?= =?utf-8?B?TkRaZ0NtNThHRTNITE5ZRnA0MkNGeE91eFllTnJTYWJoL054ekRGUXpPcEQy?= =?utf-8?B?ZVJaV3RRLzJwc3FQcEUvanl2blVyMkRUellJZHVpRG83QTBhQXdPbDE1dExl?= =?utf-8?B?UC9HMW9sWjAyZEdCWTVHWnhLdzlBZ1lKcXBjaHFXMUF5VVdTNW8zTkV1RENW?= =?utf-8?B?MmVmR2U2cmtWWnRWUUE5SU5MekRvSGtSR0hZWmJiaHQ3Qk10QmNyajhFWHQ2?= =?utf-8?Q?8l00K5ZHJKKH7NA2guUi02urs/O/Sh7PuQvWK1r?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5ee72e24-1ec9-476f-8ce4-08d8f516889d X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 14:00:40.5216 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VFqxlft8K+uWws3tExxmtOwS1j0BHGwOdoJ6uhYEdVuoK6N5WmYVxN3UIphzcpsR4aMKpPv9mPkTD7MJCBo6touDqtj1C5AOSb5bTqi1BzE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2372 X-OriginatorOrg: citrix.com On 01/04/2021 14:38, George Dunlap wrote: > ...grouped by submitters / maintainers > > Signed-off-by: George Dunlap > --- > CC: Juergen Gross > CC: Jan Beulich > CC: Ian Jackson > --- > CHANGELOG.md | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/CHANGELOG.md b/CHANGELOG.md > index 2f26cd5c87..9c272a0113 100644 > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -28,8 +28,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) > - Factored out HVM-specific shadow code, improving code clarity and reducing the size of PV-only hypervisor builds > - Added XEN_SCRIPT_DIR configuration option to specify location for Xen scripts, rather than hard-coding /etc/xen/scripts > - xennet: Documented a way for the backend (or toolstack) to specify MTU to the frontend > + - Fix permissions for watches on @introduceDomain and @releaseDomain: By default, only privileged domains can set watches; but specific domains can be given permission in order to allow disaggregation. This is XSA-115, and isn't something new in 4.15 vs 4.14.  (I think?) > + - xenstore can now be live-updated on a running system. This needs to be very clear that it is tech preview.  It does not currently work cleanly if a malicious VM deliberately holds a transaction open. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 01 14:02:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 14:02:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104510.199953 (Exim 4.92) (envelope-from ) id 1lRxth-0001Ql-47; Thu, 01 Apr 2021 14:02:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104510.199953; Thu, 01 Apr 2021 14:02:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxth-0001Qe-01; Thu, 01 Apr 2021 14:02:09 +0000 Received: by outflank-mailman (input) for mailman id 104510; Thu, 01 Apr 2021 14:02:07 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxtf-0001QY-K9 for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 14:02:07 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e11e5d9c-195f-406b-83a4-be3862b1d3bf; Thu, 01 Apr 2021 14:02:06 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e11e5d9c-195f-406b-83a4-be3862b1d3bf DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617285726; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=Ojivi11zgSPs6SiMidM26NiZuuczTbM1QnwxkLx85+4=; b=hql9pQwb9wv/zmPh7Gstm2NGo7BkHjqTyqkPVPEXbq1bErmVljC6/+lF yWR6sgw3NSnmDlrpwSXz7G1BC3hgYvCwUkhaqUceKENbl0EsmgxWcd5hn F3Ij1hnMwL4cPhxq5JKpyViJNwfk7ZbVNtXW4z4NfIOctVVx7yntQmTMw 4=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: pUB+Xd9Nf3TBudUyYBo7wbkgT5b+Vrd+gPQ14L5qkn4KqsleEDh+Na53IUGLE6eLt8vigSMn36 TqYZL5AAkfmHJ4oMZujWi56tAD93egz27HQegAdu8HqleWI+tm6ziqncJjsmfoJL/BaNooYCgT DFZqdqHORfTuVRzEakOPQ893T/D3AWC606c3xSJn2AAuhji6u16V3xw7Yv6MKhWskLOSLiUrkc hDyuakApo8HdVqIuEGVDoNOmpo5dxWuPkljJS/3SgKukcX79JTfq2DCazAqsgkboNnbRVbrcnl wTY= X-SBRS: 5.2 X-MesageID: 40840366 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:UcL8naivYaaT8xME4+DKJiZHTXBQX0tw3DAbvn1ZSRFFG/Gwv/ uF2NwGyB75jysQUnk8mdaGfJKNW2/Y6IQd2+YsFJ+Ydk3DtHGzJI9vqbHjzTrpBjHk+odmuZ tIW5NVTOf9BV0St6vHySGlDtctx8SG+qi0heHYi0xgVx1udrsI1WZEIyywe3cGIzVuL5w/CZ aa+45rpyC4f24Wc8S8ARA+LpL+jvfMk4/rZgNDOg4/5GC1/EiVwZPZMzzd5BcRVDtT3awvmF KqryXV7riu2svLqCP0+HTU6/1t6b7c4/tFQPeBk80Ebgjr4zzYGbhJf52nkHQLrPq06FAs+e O80isIG8ho8XveciWUjHLWqnDd+Q0j4XPj1lOU6EGLyaeSJENYerl8rLlUfRfD500rsMsU6t My40uju4dKFhSFpSzh5rHzJm9Xv3Cpqnkvm/N7tQ04baIibtZq3Ogi1XIQOpIBECXm0ZsgAe ljAerNjcwmDm+yXjT3uHJiz8erWWl2NhCaQlIassjQ6DROmmtlpnFoifA3rzMlztYQWpNE7+ PLPuBBk6xPdNYfaeZYCP0aScW6J2TRSXv3QS6vCGWiMJtCF2PGqpbx7rlwzvqtYoY0wJw7n4 mEeE9EtEYpEnieSPGm7dluyFTgUW+9VTPixoV1/J5ioIDxQ7LtLGmqVE0uqc29uP8Sa/erFc qbCdZzObvOPGHuEYFG00nVQJ9JM0QTV8UTp5IVQFSLjsXXKpD7l+DSffrJTYCdUgoMayfaOD 8uTTLzLMJP4gSAQXnjmiXcXHvrZwje8PtLYern1tlW7LJIGpxHswATh1j8zNqMMyd+vqs/e1 Y7BLvml6i8tFSn5Gqg1RQtBjNtSmJupJnwWXJDogEHd2nud6wYhtmZcWdOmFyKOwF4VMGTNA JEvVx49eaWIvWrtG8fIuPiFljfo2oYpXqMQZtZsLaE/93ZdpQxCYtjfrdwGwXNHxlcgh1rt2 9HVQ8BSibkZ3PToJTgqKZRKPDUdtF6jgvuC9VTs2jjuUKVotxqemEWRAe0UcmcgR8nQh1dgl EZyd5avJOw3RKUbUcviuUxN1NBLECaGqhPAgi+aIJIobzzYw1rQWCWhTuVtgErdgPRhjUvr1 2kCRfRVeDAA1JbtHwd6Krs/V9uXki2fk57aBlBwMVAPFWDnkw2/f6AZ6K13WfUV0ALxfsFNi rZJREIJBl1+tyx3BmJuTqLGHk83K8yNujFALlLScCV5lqdbKmz0Y0WFf5d+5hocO30uugQSO SFZku7Kij7B+5B4X3jml8VfA1P7F8qnvPj1Ee7sCyW3HsjDeHTJ1ojbbcBON2Y53XlQfHN8J gRt6NBgcKAdkHKLviBwuXrShQGDDX5i2u/VfspppBZprhajso7I7DrFR/zkEha1xA/JvrunE wQQK5H8KnMU7UfDfA6SmZ8xB4Vj9yBI0sgjxzuDsI/dV8riWXHP9nh2cu9lZMfRmmArhD3I1 +R7ml0+OrERTKK0dcheukNCFUTTEg383J5+uyeM6XWFQWxbulGuH63KGW0frMYaK+LH9wr31 xHyuDNu++cbCzj3g/M+RN9P6JV6m6iBfqIPzjkI58/z/WKfXKWgqWr58avjDD4DRuDAn5o+b FtRAg3dcRMij4rkYst9DO9I5aH5H4Yrw== X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="40840366" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rx2kTgjFNjhdZkQRbGQJJjzImCwDyPZfMXGoWfwl3cQH5lHA1/p+yDMTTHMzDFRXuL5z0bPrLowze32M8BtKccfQmJ6rYG42E2Xo+GLNrBgFlE+SzM5N3Lm7EwWr5DM0m8hhNlBe1oXQCw1F82gPnlUakz6rQ73NpwyoREyHBl7Fk5MbbtZsmq+U7KMV31MIQqbgTYtEThMeSWOWAGNtWMAYNLVvmVyMayMsF0CnKE4paEZMufzdSLrdexyg3TcEmBFfPPULT/Z8oXtbTFsvaHmoeXlzanPpUkk7k0kn5cD338yzv+lEvWlBb5buwSCFkRXFD1aPhkKuLO+EGoX4BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zbbjIKru2b5o3Z6Na/+GtpQrrUZlqjlPIiTbirVMMf0=; b=M8fMHbJDpssX0QJ8BAXJDAzAKRmz/3+EpYfiWJ/x0luB1eT+gkw9lM4ZycxbS0iPADzsFfJX8cMTZX2eRr2I2smPLWVYApe3Lb9taWvMqq5QlSXiqvYH1AEGZtRSrxxxViiM+/NoxreT1QsgavNX8RWhaV69UyJfpeRw8sXLl42zJGsJ5J5aRaa73z+ZqzA9n3wFVtEubZkRCDS3X3SZwpp1/l4MV7ltLEgvw6pDqbcxPssyFgC0kWshWm4Hif80WdxMrPcYw0CtZNbBY2VuZQYmGmY4KooVkLOod++bApaox+THT8pgqleURP3a34H3xN51pEnVLE1V7qqhIHFMBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zbbjIKru2b5o3Z6Na/+GtpQrrUZlqjlPIiTbirVMMf0=; b=BaPnM4iAkmvGeoeTobmqbw4d9h5F10AkhzAlmCLXC+lZY4FvZjMAcsdUt9ezSrNd9+rvXA9WRjzF04NKQyop+KAwtqrqqiFjdIsIUrnTJCACPHlRhu428WQHV7buxvhvZlgVp8s1vjyKrxumvi+T6b+gjqtYvzuCFsHVJxrPFwc= Date: Thu, 1 Apr 2021 16:01:55 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu Subject: Re: [PATCH 5/5] x86: don't build unused entry code when !PV32 Message-ID: References: <46d83c92-0b06-fc09-4832-7a7d7935d5c2@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MR2P264CA0017.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:1::29) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 492eb4b6-0fda-4339-c6f7-08d8f516b858 X-MS-TrafficTypeDiagnostic: DS7PR03MB5607: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ChL8GmfosG4MLd+gK+HNQMmjDO6qZAs36rUQMnuZs30o3cruMZ9p2b7f7wyhWGWvDi19IwSUF3jsGp58gVvFd1yopw8ZD65YJRRYgAxFTAWf+yN4o3LiqT6HEuvzYFtIbaonk48tOgNiI/2xthQBXEu8t/UE3Q1AgXkvthtByqtvSxF3avnIn4/6Ip0rg8tmqf5iTA8DTV8vDCaEnAPa3wytedPaxtVI0/iXHGLaerSMPq2Q7ffk2ZAe3A4SUUDvEZxr+OblxsnV0SqUIVdfJCO8luzPC4QaDycExSbwPdE1vFwsaM2Pnsbi3sm4KHfyKdqnRxIuOZIRjSmjPLw5uj+tkXRqPZRwHnvqysoyfSmsfsLOWx4m/OWOTGSXzQBefGnrQnORL7ipDqSXnHCBXQpznsxjqrSU8031I6qpZyDaPckp/+jPd5lT8JepC6wzb0xyUsXMEPF8mBS27/mcpV2wLp9/iNbGUq4d4cnD5TGF4kW8PMAsuinxI02CnKg+8+rAIqvKT9s1l+jS4ZWE36rDTtWHuk3mS4nF3pdWIuP0nyQ8UMzD1CAcVwOt4ovRBCwDKflMzgGkEzlMCrFNyqO76LKjpZScHUgBXJDzbD8H3NQN2QOITFuiX4GZcPMnD2ZZZKCg4W48xdVz2id5K19iDlrGBAZU82BpNdt6R+g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(346002)(39860400002)(136003)(396003)(366004)(376002)(8936002)(5660300002)(956004)(54906003)(66946007)(316002)(6496006)(478600001)(26005)(38100700001)(4326008)(2906002)(186003)(33716001)(83380400001)(85182001)(6486002)(16526019)(8676002)(86362001)(6666004)(9686003)(6916009)(66556008)(66476007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?bFQyYW9QbWxEN1FCbnd3RCtLMGdUYzF1UUtxbjJ5WlNFRE5ZYlV0T1NqL1NU?= =?utf-8?B?YlVmSm8wUWdLc0FPYlpRc3p0MkJsVU9WeHhYWGM1TU9uT0VHUXVqbnE3cjZQ?= =?utf-8?B?eDEzdFQ5YU1Hb1daM2pGNzZ0WHBUZzhuYWtrWnBIWFVsZWROeHJwbWhKR0JR?= =?utf-8?B?UDFXUHBQbWRXd01lWGtCMThqUlh5RnE5eFJhV1RUZjFjQmdvRm82RDhMY1Zq?= =?utf-8?B?RG1tUExtZTJHOVhkbitOa2hTN3lCY1VNMUJITnNVVGJCYWZHVUM0LzVpQm1x?= =?utf-8?B?Qmk2TW9iUDErcHVnS3FwNXRFSCtoakNTV2VLL3dFMmtnQnNlR21pWkZydnVF?= =?utf-8?B?TVhHNnpsYzU1MS9GNk1jTkFGbXMycy9hU1pjaVNuSHFrTU13anhVNGRvMXpX?= =?utf-8?B?a3FMTXhCaVRObzlObTNwK0M5MzZabEZoWjlOd2hKaE1JcmJCcGgxb0VqYnBh?= =?utf-8?B?U1hjblA1dWdpdGV5TkJ0a050ZGVEc1lpNU1HK1ZYd1Z0VXE4UmdwWEZOcGFD?= =?utf-8?B?UlVNUGdSdzNZTVpwWExib21FMktDeGJiMUVoZ2VZZUxYSnFYcHlsOXczZTJC?= =?utf-8?B?K2JyWTBjMWVnQXlqbUNyZWp0aTNnaU5XUmFJU3dTeHhNTlAvYk9kbnNoQjNX?= =?utf-8?B?bC9uUTlRaWtSVFpIWitvdUlxSldDZU5UcThWQkhHUmVyazc3STZwN2h3N1pV?= =?utf-8?B?UGptRC9EbGROSURLVHZiWHB2ZUdML3JmSXZIckYrNzBnTTZKWTc2Z3pVUlZ5?= =?utf-8?B?eTRtTEVWS1VLMEdUMmdpeGxrcFJ0bFMwODlrWW15Wnp3cVB5bDllTDEyajNB?= =?utf-8?B?cjhVc3pnell5UnhkdDV0RVYxK3BNcUVvSHhhaWxUYVRVY0NwSFRyNEdoWHhZ?= =?utf-8?B?YlE4SVU4R2wzWThTenJyNkp0SE1oRzl0K2VDOS9yU0gvbjNmZ0JIZkVEU0ho?= =?utf-8?B?Mi9WN01Hc1FBcGI0a0RiWEtzL1VpOTJUMytKY3p2WkFhYTdKY2lITHQwRW5N?= =?utf-8?B?MS9mY1I0a2htQTZtSFJTdkM2Q3BodVJEQllmbU5xdHJrK2hvSGNic1lybU5R?= =?utf-8?B?VU5PclpRWmV0d0lyQk5PZVVqbHZGKytleDRMN256bjR0TmNDdzBTK0lUajBM?= =?utf-8?B?Nk5zbkdJMzc5MWd2QmFjazU3SlZoejJab2w4M3BCRFZQSzJObk9CWGlFSWxE?= =?utf-8?B?cVdlaWkvaE8vbDViMW9XR0N4dVh5SVhya3UwSWZrRjZVNDh0Q0N3VUw5cDMv?= =?utf-8?B?Zi9zY1paS290TktnTmw3TDdtQzZTM1FVVDREZFhma3NuKzFyZmtscmZZcExq?= =?utf-8?B?K3pHR25QOFVkV0UzaE12NU9CZ3EvUmM0U2Y4MmY1WWp5UEszSnR4UU1mNmlF?= =?utf-8?B?REdqSUdkTmxSOVZDYnVPblY0K2wycnpCc1k3NkNXL3dwejNtejhWMjFrSEtP?= =?utf-8?B?ZWRoYWc0VjJyMmJUZFJsL3Y2UTNLYjdUUXYrL2lIblVXeUhHL0MzTmxIUWR1?= =?utf-8?B?cHVCekZTRmJqcmYxVEVGN0RlTER4bmZhZnVJUlh3Q2N5QlZneEtjMHN3UlEw?= =?utf-8?B?L1h6eHAxbmdiTzNiU0tVekExOWtQaWFadnNmVVVNMDlzR05YbEFpSjI0U1BO?= =?utf-8?B?cmtPNXRVSEc1WDUzWFZwZkpVdHFJS1U3eStwYWMvMk16L3dzR0t2YmN2TzIw?= =?utf-8?B?a1F0QjFvUDd4OTBaSVNzbjlEc3JlRnlnTTVIakV0Y3F0VFhNeng4bzhKaHlz?= =?utf-8?Q?a9clT509jVk1Z26zABrzhT5HfP+3DpfrDSzpX+h?= X-MS-Exchange-CrossTenant-Network-Message-Id: 492eb4b6-0fda-4339-c6f7-08d8f516b858 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 14:02:00.7689 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: e2WWikv0hpmL6FUV+IRY24s2TjkHl3aurhCMJBbyCHn8zmg08aPUVInUGj9TqMhXHafkPJXt6NZYzVDdGHUv4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5607 X-OriginatorOrg: citrix.com On Wed, Nov 25, 2020 at 09:51:33AM +0100, Jan Beulich wrote: > Except for the initial part of cstar_enter compat/entry.S is all dead > code in this case. Further, along the lines of the PV conditionals we > already have in entry.S, make code PV32-conditional there too (to a > fair part because this code actually references compat/entry.S). > > Signed-off-by: Jan Beulich > --- > TBD: I'm on the fence of whether (in a separate patch) to also make > conditional struct pv_domain's is_32bit field. > > --- a/xen/arch/x86/x86_64/asm-offsets.c > +++ b/xen/arch/x86/x86_64/asm-offsets.c > @@ -9,7 +9,7 @@ > #include > #endif > #include > -#ifdef CONFIG_PV > +#ifdef CONFIG_PV32 > #include > #endif > #include > @@ -102,19 +102,21 @@ void __dummy__(void) > BLANK(); > #endif > > -#ifdef CONFIG_PV > +#ifdef CONFIG_PV32 > OFFSET(DOMAIN_is_32bit_pv, struct domain, arch.pv.is_32bit); > BLANK(); > > - OFFSET(VCPUINFO_upcall_pending, struct vcpu_info, evtchn_upcall_pending); > - OFFSET(VCPUINFO_upcall_mask, struct vcpu_info, evtchn_upcall_mask); > - BLANK(); > - > OFFSET(COMPAT_VCPUINFO_upcall_pending, struct compat_vcpu_info, evtchn_upcall_pending); > OFFSET(COMPAT_VCPUINFO_upcall_mask, struct compat_vcpu_info, evtchn_upcall_mask); > BLANK(); > #endif > > +#ifdef CONFIG_PV > + OFFSET(VCPUINFO_upcall_pending, struct vcpu_info, evtchn_upcall_pending); > + OFFSET(VCPUINFO_upcall_mask, struct vcpu_info, evtchn_upcall_mask); > + BLANK(); > +#endif > + > OFFSET(CPUINFO_guest_cpu_user_regs, struct cpu_info, guest_cpu_user_regs); > OFFSET(CPUINFO_verw_sel, struct cpu_info, verw_sel); > OFFSET(CPUINFO_current_vcpu, struct cpu_info, current_vcpu); > --- a/xen/arch/x86/x86_64/compat/entry.S > +++ b/xen/arch/x86/x86_64/compat/entry.S > @@ -29,8 +29,6 @@ ENTRY(entry_int82) > mov %rsp, %rdi > call do_entry_int82 > > -#endif /* CONFIG_PV32 */ > - > /* %rbx: struct vcpu */ > ENTRY(compat_test_all_events) > ASSERT_NOT_IN_ATOMIC > @@ -197,6 +195,8 @@ ENTRY(cr4_pv32_restore) > xor %eax, %eax > ret > > +#endif /* CONFIG_PV32 */ > + > .section .text.entry, "ax", @progbits > > /* See lstar_enter for entry register state. */ > @@ -230,6 +230,13 @@ ENTRY(cstar_enter) > sti > > movq STACK_CPUINFO_FIELD(current_vcpu)(%rbx), %rbx > + > +#ifndef CONFIG_PV32 > + > + jmp switch_to_kernel > + > +#else > + > movq VCPU_domain(%rbx),%rcx > cmpb $0,DOMAIN_is_32bit_pv(%rcx) > je switch_to_kernel > @@ -393,3 +400,5 @@ compat_crash_page_fault: > jmp .Lft14 > .previous > _ASM_EXTABLE(.Lft14, .Lfx14) > + > +#endif /* CONFIG_PV32 */ Seeing this chunk, would it make sense to move the cstar_enter part relevant to !is_32bit_pv into the common entry.S and leave the rest here as compat_cstar_enter or some such? AFAICT we only need a tiny part of the compat stuff when !CONFIG_PV32, so I think we could make the hole compat/entry.S depend on CONFIG_PV32. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Apr 01 14:04:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 14:04:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104515.199965 (Exim 4.92) (envelope-from ) id 1lRxva-0001ZX-KW; Thu, 01 Apr 2021 14:04:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104515.199965; Thu, 01 Apr 2021 14:04:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxva-0001ZQ-Gc; Thu, 01 Apr 2021 14:04:06 +0000 Received: by outflank-mailman (input) for mailman id 104515; Thu, 01 Apr 2021 14:04:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxva-0001ZL-0B for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 14:04:06 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRxvY-0007IN-NU; Thu, 01 Apr 2021 14:04:04 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lRxvY-0007p5-HG; Thu, 01 Apr 2021 14:04:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=oxS3dMoshd19B3V90o3bmPWkqypn36Zp+eVdVJW1c4E=; b=DkDO9Rlno7NY5lYiCLZ7bBxP7X vlz9rOT7z1KvqT4SMU23FIwKKlETSMy1V9pkwtE+4xTDmBZcPVpnQegio9UEzJKaTICvhPVf84HLm JSY4fwB4lLmsxWimFO7ov096OovcG1wvF18i05MfPgsBGQNoa71vf6q/QR6g2OJaTj4Y=; Subject: Re: [PATCH 00/23] further population of xen/lib/ To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <27916fa0-9ebd-a49a-bbb9-1ef47c2b5bf6@xen.org> <4f745d03-baa8-e9e6-692c-f9c9f401b766@suse.com> From: Julien Grall Message-ID: <6a38f0db-938b-fd13-48e6-6b538c85fe42@xen.org> Date: Thu, 1 Apr 2021 15:04:02 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <4f745d03-baa8-e9e6-692c-f9c9f401b766@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Jan, On 01/04/2021 14:43, Jan Beulich wrote: > On 01.04.2021 13:54, Julien Grall wrote: >> On 01/04/2021 11:14, Jan Beulich wrote: >>> This is to dissolve / move xen/common/lib.c and xen/common/string.c. >>> One benefit of moving these functions into an archive is that we can >>> drop some of the related __HAVE_ARCH_* #define-s: By living in an >>> archive, the per-arch functions will preempt any loading of the >>> respective functions (objects) from the archive. (Down the road we >>> may want to move the per-arch functions into archives as well, at >>> which point the per-arch archive(s) would need to be specified ahead >>> of the common one(s) to the linker.) >> >> While I think it is a good idea to move code in xen/lib, I am not >> convinced that having a single function per file is that beneficial. >> >> Do you have numbers showing how much Xen will shrink after this series? > > In the default build, from all I was able to tell, there's one function > that's unused (strspn(), as mentioned in the respective patch description). > I don't think I've been claiming any space savings here, though, so I You didn't. I was trying to guess why you wrote this series given that your cover letter doesn't provide a lot of benefits (other than dropping __HAVE_ARCH_*). > wonder why you make this a criteria at all. Because this is the main reason I would be willing to ack this series. This outweight the increase number of files with just a single function implemented. > The functions being one per > CU is such that they can be individually overridden by an arch, without > pulling in dead code. I would agree with functions like memcpy/memset() because you can gain a lot to outweight the implementation in assembly. I am not convinced this would be true for functions such as strlen(). So overall, the number of functions requiring overriding will likely be pretty limited and #ifdef would be IMHO tolerable. Although, I would be OK with creating a file per function that are already overrided. For all the others, I think this is just pointless. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Apr 01 14:13:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 14:13:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104518.199977 (Exim 4.92) (envelope-from ) id 1lRy4X-0002W9-Ic; Thu, 01 Apr 2021 14:13:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104518.199977; Thu, 01 Apr 2021 14:13:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRy4X-0002W2-Dc; Thu, 01 Apr 2021 14:13:21 +0000 Received: by outflank-mailman (input) for mailman id 104518; Thu, 01 Apr 2021 14:13:20 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRy4V-0002Vx-U5 for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 14:13:19 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id da409f7a-6212-4446-9525-314178b2430f; Thu, 01 Apr 2021 14:13:18 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F09F8B21D; Thu, 1 Apr 2021 14:13:17 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: da409f7a-6212-4446-9525-314178b2430f X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617286398; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5R1iFocCrCea+Q5CcekCM394fJXvvNmfhZ4ckV/HZw4=; b=peDM+GzJLIOurWE/aJeXyz5Jit3ZlwNVPChscDbWL9L0PtWNknTu2s3kBn0GuooNVretBQ Y85W8cprQk+U6clKIYpmE3zz/nkmCX2GuZpr3+aXBkZ8jyzEU7C6M5vspYINSoL8nkTjMZ +uiWilsKU9NQywT9ycbQLdvOLjDvQRo= Subject: Re: [PATCH for-4.15 4/7] CHANGELOG.md: Mention various ARM errata To: George Dunlap Cc: Ian Jackson , Stefano Stabellini , Julien Grall , xen-devel@lists.xenproject.org References: <20210401133827.362216-1-george.dunlap@citrix.com> <20210401133827.362216-4-george.dunlap@citrix.com> From: Jan Beulich Message-ID: <330feed2-d601-8b79-3c1f-bd8be167b8eb@suse.com> Date: Thu, 1 Apr 2021 16:13:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210401133827.362216-4-george.dunlap@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 01.04.2021 15:38, George Dunlap wrote: > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -26,6 +26,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) > - Added XEN_SCRIPT_DIR configuration option to specify location for Xen scripts, rather than hard-coding /etc/xen/scripts > - xennet: Documented a way for the backend (or toolstack) to specify MTU to the frontend > - Some additional affordances in various xl subcommands. > + - Added the following ARM errata: Cortex A53 #843419, Cortex A55 #1530923, Cortex A72 #853709, Cortex A73 #858921, Cortex A76 #1286807, Neoverse-N1 #1165522 May I suggest "Added workarounds for ..."? Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 01 14:13:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 14:13:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104519.199989 (Exim 4.92) (envelope-from ) id 1lRy4k-0002ZP-Px; Thu, 01 Apr 2021 14:13:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104519.199989; Thu, 01 Apr 2021 14:13:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRy4k-0002ZI-M5; Thu, 01 Apr 2021 14:13:34 +0000 Received: by outflank-mailman (input) for mailman id 104519; Thu, 01 Apr 2021 14:13:32 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRy4i-0002Yr-QP for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 14:13:32 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6c1ce797-8b02-4a33-8acd-43dd9906a2c0; Thu, 01 Apr 2021 14:13:31 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6c1ce797-8b02-4a33-8acd-43dd9906a2c0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617286411; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=o/T2z5izFqeFlrvyG41eLfX0wa1j+CcD9qVBIetCGhU=; b=PMM/9qULSJLXaegPolR3YnsaFrDLdnVyET/O8umQ03sZpoq11ne48Zua NzS5rbYmhpFhtnmaH5SNkc+cYGp8PLsXAGDm0x3JWE9C35IqEIViKmVYV pqTiloKitU/M3hY5A2usfqqoPAHGnnepTlbpP2MMjlMcvntfDMTcUX2fi 8=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: /CoToxVt0p7OtTS0rPh6usII05wPspnEpsBlHbkGudq8QpttU5WUCRQg73LK9KP97zHpok/J8n DLtetwJioIKjXuDV0FTAvsg7JJfkzDkeN5fD7TH1qsBvKchmKr7e+ABT4i7gaNlbj7L5yTJ3df hAHkGeJoQvqnC2Zb+0UlrF5lRmBpQwEKa5Lb5j4vsZ6ode5mzVW9/1GSFucKNG314HaSztwUJ8 e4xHT1MC7y3rUF+axKQyoNiaij7gUoZ5AHsoccaJNGI37OtQyJS1PVGnvSJxoNbWTPCVpqJdHj BFw= X-SBRS: 5.2 X-MesageID: 40704382 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:1iQtd6myeJ146F07dg4LkW06YbPpDfOej2dD5ilNYBxZY6Wkvu iUtrAyyQL0hDENWHsphNCHP+26TWnB8INuiLN+AZ6LZyOjnGezNolt4c/ZwzPmEzDj7eI178 hdWoBEIpnLAVB+5PyX3CCRD8sgzN6b8KqhmOfZyDNXQRt3brx7hj0YNi+wOCRNNW97LLA+E4 eR4dcCijq7YHIMbtm6AH5tZZm/m/TgkpX6bRkaQyM94A6Vgj+yrJL8GR6U3hAROgk/vYsK22 7DjgD/++Gfo+i2oyWsrVP7wrZ3vJ/aytVFDNGRkcR9EFTRoyuheYgJYczmgBkbu+eqgWxa9O XkgxBlBMhr7mOUQ2fdm2qT5yDF8BIDr0Dv0kWZh3yLm72LeBsfB9BajYxUNjv1gnBQxO1U66 5A02KHu5c/N3qp906Rlru4NWAeqmOOrXUviuIVhXBEOLFuE4N5loAD4FhTVK4JASOS0vFWLM BVEMre6PxKGGnqFkzxg28H+q3KYl0DWj2CQkQEp/WP1SlXkH1T3yIjtb0it0ZF25QnR5Ze4e PYdoxuibFVV8cTKZlwHeEbXKKMeyPwaCOJFFjXDUXsFakBNX6Ig5nr4I8t7OXvXJAT1pM9lL nITVswjx99R2veTem1mLFb+BHER2uwGR73zNtF2pR/srrgAJL2LCyqUjkV4oidisRaJveed+ e4OZpQDfOmB3DpA5x10wr3XIQXAWUCUfcSps0wVzu104L2A7yvktaeXOfYJbLrHzphcHj4GG E/UD/6I9gFwVusXlP+nRjNS1LgckHy5vtLYe3n1tlW7LJIGpxHswATh1j8zNqMMyd+vqs/e1 Y7AL6PqNL+mUCGuULzq0l5MBtUCUhYpJ/6VWlRmAMMO0ToNZIKu9CVf3FuzGKKTyUPCP/+IU p6nRBa6Ki3J5ufyWQJENS8KF+XiHMVuTasQ4oDnLaAoePoYIkxAJpjeKEZL3SLKzVF3SJR7E tTYg4NQUHSUhn0j7++sZASDObDM/9mgAmqJsZQgWnFtVqVoPwuQndzZU/tbeenxSIVAxZEjF x49KESxJCanyy0FGc5iOMkdGFXZH+vG7JABgSdbIBykrTmETsAC1uitHi/sVUea2Dq/0Idii jEITePcf/GOFZbp0tVy73n6l9ya2WbcX9hc3wSi/wOKU32/lJIlcObbKu61GWcLmEPxewQKx npSzofKAEG/aH86Del3BK5UVk2zJQnOeLQSIk5e7bIw3W3NcmjjqcdBcJZ+55jKfHjuuIGSv ikZgeQNT/0YtlZgjC9lzIAAm1ZuXMkmfTn1FnZ92C+xmc4GueXD1J8Rb0XSuvsplTMdrKt6t Fegt00t+frbTm0Rd6C1K3NbzlMbjnUunW7Suk0qZZS+YI+3YEDaKXzYH/t7jVg2h57EeLf0G U5a45/6KraOoBuc9cJEhgptWYBpZCqFg8TrgfyAuUCZlkjgH/QAsOR79Pz2M4SK3zEgDG1BE KW/CJc9crURiev1bYVDKQrPGRdAXJMnkhKzaend4fKDh+tePwG1F2mMmWleLs1ctnJJZwg6j J76cqPhemZam7R3x3RpyJyJuZr/3y8Sc2/RCKKFuggya33BX28xo+r6tW0ljH5VH+SbFkZn5 RMcQgoVft44wNSxLEf42yVUaz4okUsjltY73VGrzfWq/abyVaeO1pHPw3fiohRRh9JPBGz/J z4zdQ= X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="40704382" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I91Rn0jFh8q/Wkya5RImjHk7qrqSHqASu+s7FyDUKeIrzOJRx4NowxvwTx2RQmdpjUheIbuXMT18ymp5vxQTBVIcdtKX6z5gbGHcXnITTHFf4LmpjpmKmA7mBnLeJeGwg6aqyOxQrvLMVqZt6xfgqmT8Vhk4jn9KW0G67PCHYr1pYk8uPg390j6whX7olPFCLUMetaHwBm9h1NGiP1SUUuA01o9nJzWgxM1/gL/HYWx54ZED8HoWutVZ4joGqAj3iWCKd0jmBZ+Vri+hF0xXecj27Uv/2/g414GSkVgl2H64aU/j9q80zuSVZ7tDkO4VZNO7zyVNz6ISQVvP3Z48hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mqXtbKToHbLI33LPAXGUP0ffz669ImFGlV5VdiPlG8I=; b=mLv4CCVsp41RiNePwSuUK6JvHZhWAk64yTaWFXfnxTNySHUAwkF7KkzD1LKEzKIJaQlwxCtVZIhMrPgzuQaN9KRhvzb38dxLYJMpQ+2RKZQ9tSrk5aGUZjkzTlikkvP77wQYADdupUvIhYLHb6TYmzr2QtLxnYTxzR4emnZKQ0dYPvv4+1NXYA3rtBa2K1pt4UAESMSqDGSv981Ahr8PSFimv9c22mf4m9Hw6IrTQu2sxmOQD81qJgKUaOpFAwVVGjRm22ANujgC9YkNQHihwEVAMgyBPEN6clAd6ra8d0UFHB0P5bvzhio3fpOSEZdaws4xbuy0MjA+KIyVwpoElA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mqXtbKToHbLI33LPAXGUP0ffz669ImFGlV5VdiPlG8I=; b=iLr5GOsmDPmk3uB21vRzwoqiF386lyLAMLAwSsqBpKahGGSTZzJ76qmg/z3YaX33iwVrsD8bVEAwvxVYPxbhEljMKT8KkL/d1nt8G/rF1pJNcVsbdMjsKoNsf8gOuwO49W3gF0KFWwy1wxthftvJi8g2Z25Td6FUDKfm5ehB/YM= Date: Thu, 1 Apr 2021 16:13:15 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , "Andrew Cooper" , Wei Liu Subject: Re: [PATCH] x86/CPUID: move some static masks into .init Message-ID: References: <2e3dfe1a-bc8b-6774-ef7e-efb565343c52@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2e3dfe1a-bc8b-6774-ef7e-efb565343c52@suse.com> X-ClientProxiedBy: MR2P264CA0081.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:32::21) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 446e2ad0-de9c-481d-7888-08d8f5184e53 X-MS-TrafficTypeDiagnostic: DM6PR03MB3915: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:843; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: E6YDHzyLQc4kLA5mYBFiaEHTEvfX3XoQJrh9iD3yvoYrip95SzkaXVR9j2crP3WM/lxS4oNr70qVcUXQAvg4duabNhJjQ97XiyQO6COjfJBvVbfV1/1daewTx8v9Il8CU/aoKHzTarRPsV92wjPFh3G/NzJPJaWU4rcDN7KhMdkIPqsUa5iyqvPvalcrES48kckVh7T7Qtw2Ifj8AYx7avqHc8SfRegrxd/OUHE1YRCZFU1rgCydOjB2WHS9TM/NpphDQ13qegV2RzEGN2DogC5lsAVlbdLrlLo/kuYa3rbbLH/W7VLErT4bHtX8HU80KNxejX+hClI982HbEkG0uN0+Qd+cIx40YBTAqMg/hGh5XQC6g7ZodX2a7z2g9INm4pcRchKEmyu5nRhyVkgiwjziUzJCGtMjADGWMZiAqu5+Sl9vMGR18cbgbIRGdrKMdPSTby0GRv/Ptlt5MS1iZJPE/QRENgPHUpFU9fCfFXSlTJbdB09/lLsDNnHdRwwTWJUZ7GTZco9fyQM5IcpEqOgD7U9kh1S8Z6c4AuFRTwnRqYRSk8o29kOKiuBqm3G99sgfc2y4c2rMUbCb+nP17wsSEOA50VI+ISusu5Bq4oQMqJxUHKdnSGp2/tyJEa0kunjOl+FXxtYnXPBjcxNw9U84EKHfP90npZse/GsEMNKLbksbuaLCFj4oWgI+t4Az X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(136003)(366004)(39860400002)(376002)(346002)(396003)(54906003)(16526019)(33716001)(8676002)(38100700001)(2906002)(316002)(8936002)(85182001)(5660300002)(66556008)(66476007)(6666004)(9686003)(956004)(86362001)(4744005)(26005)(186003)(6486002)(4326008)(478600001)(66946007)(6916009)(6496006)(142923001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?MnZpWnVFaU1rRnduQlZIUWRZdHlocU0rcTM1UllRTVE1K0pwWXMwdlUxWlk0?= =?utf-8?B?VUJxczRKK0Fmd2tVZFpwVlNRZ0w2OXlrSVZmbkZJM1AvYVJId2h1elIrQjNC?= =?utf-8?B?UEdhR3NYZTVvTEszZWlKOXlZVE5IakRmRmtudzd0ZlNUZnY1aGNBZ2lpM3F6?= =?utf-8?B?eVRMUVYyMmtySW45QSt2eTJBWDNkY2hEUE1HazNQSFgwdEtCZ2xoSHBXWWdq?= =?utf-8?B?V3VSWklpcnVFSDQ1MXBiNGM3RGdtSi9xZytlMkFBM2pReEpxNU5kMlFvUGZs?= =?utf-8?B?UVM0RXg3dVJtNC9wS0ZrQmxxOE52Vk1Id0pKVVZEUk5hTWcyMmxjaUNEV0hy?= =?utf-8?B?Q0VPbWNMaFlkZ25Gc2dyaDMzU2tYUjlONE9GSmplbGs5cmVST3dCWTAzNWxP?= =?utf-8?B?YXRJZGhhT3BuWGczU3Y4V2R6TTI5Q05OU2Jac0tHN3VHQmRHOTdJSWhJKzJG?= =?utf-8?B?WW9pNEZXZlhsS0V1b01MK1dDVStZYm5Mb3BTM1F4c3E4VThOdzV3WGptQmsz?= =?utf-8?B?YkhydTh4enQwQjR0MEpLWlB6dURmRXl2LytUM0N5VUFxRGc3UnY5Y2JRQk9a?= =?utf-8?B?Z0EySDlkNXExcGgvdHNJNzRaSTh3TVFpaTFsdkFqQmZqOC8xNEsrQVZGTGcv?= =?utf-8?B?YVRyQXJaYVNCWWhUKzdYbzNZbjdCSE80MVF2T2RYWlp0bTJRZnRLeTBJM2ds?= =?utf-8?B?bFJxNklrajVwd3E4Z0tBajJITU83RFEyWlhzemoyYTRuK1hQVURFZ09RekRU?= =?utf-8?B?b2JNS0lDcFF0Y3NFbzR2bjJNbHVWc2U0SFpNeWYyRW1rbjRaOStmN1lLVUFj?= =?utf-8?B?bVRiYUpOdHRmeDNXNU1NYmJORjM1dzJZRkl1cGdTcWh3YTVTRldkWTA2aTZK?= =?utf-8?B?SlJOdFFTWC9OUTdBNUhjZkVGUFlzTW52SmoxRFNUOTJKcERyOGxIRW10WmFF?= =?utf-8?B?RWFvRkV0eTAxSUJGNHIrR1BJcXFObkdFeXEzdStDaFJ3enNaeGJCSDBpL0hC?= =?utf-8?B?dUQ2dXdWRmZtbVR5OWViMWNYcEl4V2w2NXRBM0tUaEVRQ3RtY1I3eTE4d096?= =?utf-8?B?cEZQZHl0TmE3RmtsNk1qbnhHYTlBelk1WlV5SEdXV1RDZTVITWFObG5zUFY5?= =?utf-8?B?VHVEZ1BtMnlwQkt6MXJUUmhCaTZxTVk4VVVnVTRrR1NZdnBuVHAvY3h0ZjZF?= =?utf-8?B?d2cxMVpFOURwOGx4VnFEMytiQk0yUlc2L3pCMlZXN2psUnZUbVNWMGdvU1ZX?= =?utf-8?B?aUFEQXZ1OGxxR1VESnY5VlBTTlFyNHZJR2RRSHoyYlp4Zlo1VVNraUJKNTJ0?= =?utf-8?B?ZmhYY3BaaUxVUGxsbVNrbHVQZ2lMMHg3Mi8vdHdwOVFkTituUG9idFZqVThq?= =?utf-8?B?eXF1eURNRFhHek44RTkrY0plUUFwbWFRSkJ2SFZvU0RocUt1dkpHWVVBWG82?= =?utf-8?B?cFhFQWxOblhmNDBJU3dMbWROZHVCMGhUeFBvY3luTVpiQXNkWWlhdUtJWVhq?= =?utf-8?B?bzExK0tvdi83SUE0c0p4QVk1dGdPYkY0aUYrUC9SRkVZSGFJdi9yNmFLd0dV?= =?utf-8?B?aEdoTTZ0dkRPS1JQSjJ5WmJTa0hSaEl2TEtUaG1zYjFiODhkaGFwcW9pR3Bs?= =?utf-8?B?V3dOa3UxZE5VbDlmZS9EZEl5VG92U0VwUWpIWmYyMWhPRGFSV2NzT3dwWDZs?= =?utf-8?B?OStXUlRiNXQzTXM3NHlRK1d1b2drWEhmWFJPOFhVOEhPQkxVcTE2SEtHNndk?= =?utf-8?B?d1V3cnlKU1g0ZEtNNWlYSzFRcEpzUllzUm5IaUhpa1pYTnZZcm9qWEVpSng3?= =?utf-8?B?UFVNWTcxZXRVNUtoM2IrZz09?= X-MS-Exchange-CrossTenant-Network-Message-Id: 446e2ad0-de9c-481d-7888-08d8f5184e53 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 14:13:21.5785 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: y0RVUtY4ikaS+HQq1RpMMjPBW3mtoYz0N+XRNaOlDeeiWrZit1Pn2ts4OVSxaq3zdDJbY7bnC9Pym5b5JvQf5w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3915 X-OriginatorOrg: citrix.com On Wed, Jul 15, 2020 at 09:45:47AM +0200, Jan Beulich wrote: > Except for hvm_shadow_max_featuremask and deep_features they're > referenced by __init functions only. > > Signed-off-by: Jan Beulich AFAICT those are still only used by __init functions: Acked-by: Roger Pau Monné And making those non-init when required is trivial. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Apr 01 14:13:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 14:13:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104523.200001 (Exim 4.92) (envelope-from ) id 1lRy59-0002gO-3m; Thu, 01 Apr 2021 14:13:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104523.200001; Thu, 01 Apr 2021 14:13:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRy58-0002gG-Vt; Thu, 01 Apr 2021 14:13:58 +0000 Received: by outflank-mailman (input) for mailman id 104523; Thu, 01 Apr 2021 14:13:57 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRy57-0002g3-96 for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 14:13:57 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6a16ad22-58cc-4f9e-ab27-ca9120ad9a3e; Thu, 01 Apr 2021 14:13:56 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a16ad22-58cc-4f9e-ab27-ca9120ad9a3e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617286436; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=cOZ/xI/emguW5oKlhPWLjfpXpQISZ5k4MxVTlymcgYc=; b=Lw2FM0rPiyuo1PLQZMsi5GdmfHJVn8TITFFNybNPHEGfNwCG+LSnI1ZW LwyMukDOUpfQPCvy5pk+33PdwrFNdZLQ4Q/cvhSwSUQg9S1ieRKLYvyj3 XU6ImBiaCd1dhjNMi18Yw9Y9sca6YElyQdXxipnCKnJJWxZJolYbLyKas I=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: hedOiDKEWSy1774H3QXvtOwJ3AtPi3v9m9j4g3Aa4HTdwLVR3cbaiduS7KcI8KHcvho2iKw7SX /cQy3EMBIOZRZyG/oGlmRWjmOZDicKM4t/R+GUIv63ddRCgG9cC78ntj3EkSTSHpyfc7Y5wXvg 3WNdjCXhagvdh0cWaJ0wdr2yOuVek3jGv3qIADTb9gtUrEuC0tIMjkz2hxcP80CD/VxEFhvfjT Y5wY29BgFrza/TXhdX8c+PPqDExVHlllUg6kctlCG8iq/42wcUHL6ynHlOtGLOcuvw0CFUsvMx TXU= X-SBRS: 5.2 X-MesageID: 40685686 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:tIatg6vs00lmrAMUoe0kr8897skCC4cji2hD6mlwRA09T+WxrO rrtOgH1BPylTYaUGwhn9fFA6WbXXbA7/dOj7U5FYyJGC3ronGhIo0n14vtxDX8Bzbzn9Qz6Y 5JSII7MtH5CDFB4frSyAOzH888hPyO9661jenTpk0dMT1CQYsI1XYcNi+wFEpqSA5aQboVfa Dsp/ZvjTymZHgRc4CfDn4KQ+DMq7Tw5e3bSDQBAAMq7xTLsCih76T0HwPd8hAVVT5OxrlKyx mEryXS4KK/v/anjiLNzmO71eUZpPLN6PtmQPaNhM8cNyn2hm+TBbhJdrWesFkO0ZmSwXkwlt 2kmWZDA+1S7DfrcnixsV/R3WDboUsTwlvD7XPdvnf5u8z+Q1sBeol8rKZUaAHQ5UZlnPwU6t Mx40uju5BaDQzNkU3GjrCiPXwL5ymJiEEvnuIJg3tUXZF2Us4qkaUl8F5IC5BFJSrm6ekcYb RTJfvB7/Vbe07yVQG/gkBTwcehVnl2PhCKTllqgL3t7xFqnWt0x0Zd+coHnn1ozuNad7B44Y 3/Q8FVvYALavVTQbN2Be8HT8fyIHfKWwjwPGWbJkmiPL0bOlrWwqSHookd1aWPQtgl3ZEykJ POXBdzrmgpYX/jDsWIwdli7g3NemOgRj7go/suoqRRi/nZfv7GICeDQFchn4+LuPMEGPDWXP 61JdZwD+L8K3DtXaJExRf3VZUXCXR2arxQhv8LH3a15u7bIIzjseLWNNzJIqD2LDoiUmTjRn QZWjz+I9hB81CrVnf0jAO5YQKqRmXPubZLVITK9ekaz4YAcqdWtBIOtFi/7saXbT1O25ZGJX dWEffCqOeWtGO29WHH4yFCIRxGFHtY573mTjdPrQ8OOEXkbKYbt7ykCDhv9UrCAiU6Y9LdEQ ZZqVgy07mwNYasyScrDM/iNHmbgXsVrHeDVIwdhaWH+MfgdvoDf9EbcZ00MT+OOw1+mA5spm sGQhQDXFXjGjTnjrjgkIYZH/jFd953gB6iJMldrX63jzTGmegfAl8gGxK+W8+ehggjAwdOjl pq6qkFnf6rgjC0M1Yyh+w+LXxBYGmaG6h9EQyAfYlY84qbIj1YfCOvv3i6gwt2Unf2/08S71 aRUxG8SLXuOB5hnVx2lozt60h5c22BeVkYUAEKjaRNUULcunhy1ueXYLGUyGX5UCpf/sgULC zFbTwOIgln2tCw01qPlCyfEGg9r69eTdD1HfAtdare1WiqL5DNnaYaH+VM9JIgL9z2tPQXON jvNzO9PXf9A+Mt1xf9nAdUBABk7H0lm+jvwhvr8Syx22M+G+PbJD1dNvsmCsDZ62jvXPCT1p plydozoOurK230LtqL07veYTIGKhTdpweNPqwVgIERuaI5r71oGZbHFTPOyXFcxR07aN7ui1 l2etUz3JnRfot0O8ACcSNQ+VQk0NyJMUswqwTzRuszZ0skgXPXN86AioC45oYHEwmEvk/9KF Of+ypS87PeUyyP2aUTBqgwLW5VAXJMo0hK7aeHbcndGQ+qf+ZM8B6mKXe7aqZaU7XAFrMKrB p2iuv46dO/Zm79wkTXsjR6KK4VrDriTsO2HQ6WGelHt9a9Ik+Bh6O24Mi1yDf7IAHLH3gwlM lAbwgXaM8GlzwpyIsw2SK2Qrbsok0kn0BFiAsX3mLFy8yj+iPDAUpCMQfFmZ1YUjlYL2iQga 3+gJ2l/WW45CIAxILKG0hRdMxfAtQcToD4KCF1NMgb1YTYiJYHk2BEexchD2k1lTD70adnxN 6CqYfvZ9E= X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="40685686" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pab5V570b3uVVy8Xwyh+s3KstQBUM2HEM4mcBBjI9ZqtDSI3NgBiIA9eGO7nTW2IkAaSRhGURIONmn1Z23Zg0CuNAX/qtGUfri8sN9sn2xFBD3ADBC1SeASaGGnyw+W1VAL+Mz0YpqxPoMExPGTvmBEWooV5seP2PaPeXreWFRf7FUIjE1o5qXYvuTlFaVnTpehPX09riYnFZDqPdvIOLDfsSCivTP28C//bshMsx2NU+x3hgnJ9VUWLpCe+vI87mqZW+xra3+cVAeFrcujtoa4bF8iLPstjBy7cE+153WMZuj6RnxgzK5YjICPbKI7vEWiNGEz22BZh95d7w+id1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cOZ/xI/emguW5oKlhPWLjfpXpQISZ5k4MxVTlymcgYc=; b=Wk4KbsAzDUhSa+hn9VC/USL3Bqjtjacbn6wsUsxXWeHucLX81c8YTDhz65pQ1ZoOSd+6zP9621qQ59RPhlv4voYpATfLXrWTEx8OrUuw8UiNdQu0nQRG8GczIjC8kSscKJ4VaYeQtQ+ToEFcYx2fWS76cOs9lD5mC35rDFVayXQoArJ+RKZ37YB81mEpoZpJqajYbqm7HVmAIhWwkV1DKoNyiUw0oQZ4FUw30ZcHLCV2pmc65ljWXf1P92tLwzJgk56DHNroMhRswOjS+xhOR2b4MdPetj2HOKZmMrHy1z1hlmZ5C07bPlZ2a9CWn3R7oxOesYzKvl0QDwctHpwehw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cOZ/xI/emguW5oKlhPWLjfpXpQISZ5k4MxVTlymcgYc=; b=CxbUi0yilRfoRa9bz3nyj3bOOZYsxxAu8L9zlSBhVrJyrzKl5vDhQSJ/unXskFkBWSylVrLdTf+oclYwBxV740Ttn0EB3YT0Elj/5YrCtuUO6tWaTbsMs0tBtA16jnHIeY7ZKcpCFW40tWqAibImqmP95oEicEgFyLokdMEOrgo= From: George Dunlap To: Andrew Cooper CC: xen-devel , Juergen Gross , Jan Beulich , Ian Jackson Subject: Re: [PATCH for-4.15 6/7] CHANGELOG.md: Various entries, mostly xenstore Thread-Topic: [PATCH for-4.15 6/7] CHANGELOG.md: Various entries, mostly xenstore Thread-Index: AQHXJvxUtSxo6M4mo0iX7TVVNapv+6qfsM2AgAADtYA= Date: Thu, 1 Apr 2021 14:13:52 +0000 Message-ID: <07553207-90AA-4AD4-A5C2-C8F36411DDCB@citrix.com> References: <20210401133827.362216-1-george.dunlap@citrix.com> <20210401133827.362216-6-george.dunlap@citrix.com> <97d317fb-16d7-a14e-e74e-62fa83159838@citrix.com> In-Reply-To: <97d317fb-16d7-a14e-e74e-62fa83159838@citrix.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.20.0.2.21) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 45068017-cc19-4586-4270-08d8f51860bb x-ms-traffictypediagnostic: PH0PR03MB5832: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: N9YaA++I14yxmpydoj15OG2o7wnXZiO4amTjwTVhvIazTlzqXHzbF9s0y9ejZ/oc4Hf2lzxdcaBe5bBaJKpHu/k4oxlhq20T5lpoWh7UoP/GL7Scb4l7Yxg6kAtqMNuYus7m4bPNW7bzMhANRWVEebvzvkM/La16YDePL692DcQH0iQd/5QcL1uBbMV7Q26Bl75AXXcOY7xxR62yqj+V78qVgfANAGojDBlfWGCYvANWUe3WQmAbz/ehJmEHJi4GEb5MLW9zcQCdhUkGES4Uk1EuEDOJwYr7SY8HQGhqTebKOp9SP+xNVHCtdpfLAd6C+aVaVsXUSbJ8vAsriP6byam3Zvw75Dib0Mr5K6nhZM+DNKKrrk/c4WKAeR2P/9uR8f4gYWaOOOaQGQyNZcvkDyAJzZ9gbzVkABBHeYHhRNktPgwtN/ay0FmYOQKQQkNtS79RBE7cp/mZHKh4mfCBIlFaHK6YSSyQ2qhXKUYDWcSPjWymsjFSXN1iceGYJ4UZVZ5X5XV8vDed88cHZDtOodktrBit8uZ/ZaTF+sCPZChwhxYP8J8qMN7nyZjOfNbTqT4KqKsqH3SXRW8CY4fzhBwGanzAT4IiCDTHhmg1FWKHbvz4pSdX9pf7X+aGB9+J3Om4Cq0rMa3xkm6beak6pO9/9CGGwQiJv4EohVgNaw3rK7ElhnzEi/jSSFtBTAfVDaQ23E/T8yqC2PDeyIqfgFuKwkM19dt+hPLtO8JZ+BcsUkvqqIwwiGHnkM+49NdICYbKt5Wi6VrC/vWspzpAtlw2YIBqmyxs6WpVIVSDYv26Lgn9tM/sse5v/jyKcSzP x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(346002)(136003)(376002)(396003)(39860400002)(66476007)(6862004)(26005)(316002)(5660300002)(71200400001)(86362001)(6636002)(38100700001)(2906002)(8676002)(4326008)(6512007)(6486002)(37006003)(83380400001)(107886003)(76116006)(91956017)(8936002)(66946007)(66556008)(66446008)(64756008)(54906003)(33656002)(2616005)(186003)(478600001)(6506007)(53546011)(36756003)(207903002)(219803003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?TThzV0wrdm11dnZRK3EvOWpoT1dITThmMEhwdmpLUUUxVUx0L3BYNkx2NFBJ?= =?utf-8?B?RHRVZ3RwQzBWeE5ObHUyU3RpSWh2bks4aGZnN2NWMm81SVAvL1ZHTkU0eCtW?= =?utf-8?B?ZjllY0F5MXpLYnRCZmVVa2JybHEyOTA0Z0JvcXFSYklqTG1LYTU0Wmo1UzR6?= =?utf-8?B?dU5OMHhnc0ZXSm56c3dmeWsrdEE5Q2ZCd1hBUk01d1lwRDRienVUMHVVZ2Y4?= =?utf-8?B?SGIwUEVQR2JLVXB4ZWVPeDNIQ2h2WlNIUG9lVC91Qk1naE45c21vcTh0N0lQ?= =?utf-8?B?alBkelQ1ZWFSamdpU0h4a1IxbDR4eXJXYjVuTTl0L0xqQWZFVlp4bEI5V3RM?= =?utf-8?B?cU0yeW1OMXlYWDlSdXdSR0Nna29vM1p3YUFjekQ1c1p2RmNqZjNHd3pmYXV2?= =?utf-8?B?LzMrY2ZjZEtPenRrRU9DVExlQlVJWnAvY20vZWZHQ2Qzb1BGcWJ3akk1VmFC?= =?utf-8?B?MFRhKytUODFudzFHdHN6bGpxNFREKzRxUUQ0dmhLVU1rcm1IOHlDNFdGeGZ3?= =?utf-8?B?dHNqb0ZrckVkUDlDTlZCNjVYYzd3Tkp5ZUFlQkdNQXVVK094RGZKeE5zaGk0?= =?utf-8?B?L3ozeXRMeU9YV2hqMkdCWDJZSkY3cnJIZUpma2ZvSURnTURhMXFJelMwZzI4?= =?utf-8?B?TGpvTWdid0ZVUTR2ZCtwYUNMVFhhNFBXaExkVDR5T0ExV2paTGppM0QzOG40?= =?utf-8?B?QVBMb0c3cHBCK2ZXc1VVWDJnTk51SitXc2EyU1VEY0dEMDN2b2o3TVZSM2xT?= =?utf-8?B?ZEhOQ0RmZjgrZzgzRWVCZ0pMOGkxK1c5R3JYdFpOS1ZQa0lGSTRvVXB2Ujhj?= =?utf-8?B?YXI1VGtKWWhReGNCZjhkZzhGcEJVUUNOSkR3djRFN2tUT0pSMkM1Y3Z3b0NW?= =?utf-8?B?ZDdSK2Q2QTVSdlRlbjZXOU9qWk5lSFdXWjhDdzdkcUlISERuMnQ3NlcxUnlQ?= =?utf-8?B?VnliMG1uTlo1eWx3TXlNelBteDlQNGN1MnRRcHJqNkFCZmxtYnlFazRlL2xH?= =?utf-8?B?aWRDRUpZY0x4TEFUMWxJMjdNNUhVcVhtZ2JWK3pucEp3dGJ2M1pZM3AvdzBH?= =?utf-8?B?dXQybFpVSVR3UTRxS0VEeG55UUhQNktrSU51dy9VWHZoYTVOTXdaSUw0OWE4?= =?utf-8?B?Tk0zSHdMUERFV0NkTlFkcC9jU3VQdVRKRnphd1FETFpabURxbEhqVlZaUVRk?= =?utf-8?B?eEdmVVJhSkc1NlMxVTR4d1podENUZ1ZobFF4NUl6bU1oSFloaWlmRHNRMCsx?= =?utf-8?B?d0JyUUpReDk5WmpWSHNYTlZ1VkxRRkJXbEtmM1BSTjEyZ0VhUy9QOGw2dlZ4?= =?utf-8?B?RG1vOThMcXhJTVVVYnR4dGhRYmdTUjREejAvRXFadVBMQmZ4b2lHRlBlMTl2?= =?utf-8?B?dG5IdDRrMnQ4S3RjZFhaS3ZGdTRvRjM5eEQzZnZ4VU5lY00wcmZmcVF1NWRr?= =?utf-8?B?aHM2eVNLVDJkV2tCM0RncHZCcXZvOVlIUzJ1SkdwL1Z6VHg2OHZVS0N0RFNG?= =?utf-8?B?Q1BuYWJnUHpjM1pSc0J0eVl3VDhTTmVaRmZ6YlFGSHU0L0xrZzRuQWtaVC9R?= =?utf-8?B?OEcrYnM2R0VjRGM0Q1ZCUUxDNllXSnhJOU01ZmxYSVQ2bVNsOE9WVHNMMFNX?= =?utf-8?B?b3NrVUJaS0Q5WlV3cGhWZk14d21lT2xNbWN6ZXowZjFEc1YzQk1YOW9FblN6?= =?utf-8?B?RDJNNVV4dzV3YkZFZElOSlFNZUo0MVlpeVBNTVR2YnZCREdKUjVScmlLSU5O?= =?utf-8?B?cXhFSE00OHA3MXFxc1hMMHhuU3FQQWxsU0xpendxWlBvRmQ4UkxLVzdEVTBW?= =?utf-8?B?Wml1UDA0cDYvWjU2TitkUT09?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 45068017-cc19-4586-4270-08d8f51860bb X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2021 14:13:52.2376 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qQUKlA+p0H/rbpN+8gAO2XkPzKlUTLCzHvdIn2kszGCgSvx1ZiuaIgYfQGyX/hTjG6iF6vy0Wiz5QPG8ORgDH6ZD276nH5QEJLzTAYQyo0Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5832 X-OriginatorOrg: citrix.com DQoNCj4gT24gQXByIDEsIDIwMjEsIGF0IDM6MDAgUE0sIEFuZHJldyBDb29wZXIgPGFuZHJldy5j b29wZXIzQGNpdHJpeC5jb20+IHdyb3RlOg0KPiANCj4gT24gMDEvMDQvMjAyMSAxNDozOCwgR2Vv cmdlIER1bmxhcCB3cm90ZToNCj4+IC4uLmdyb3VwZWQgYnkgc3VibWl0dGVycyAvIG1haW50YWlu ZXJzDQo+PiANCj4+IFNpZ25lZC1vZmYtYnk6IEdlb3JnZSBEdW5sYXAgPGdlb3JnZS5kdW5sYXBA Y2l0cml4LmNvbT4NCj4+IC0tLQ0KPj4gQ0M6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNv bT4NCj4+IENDOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+PiBDQzogSWFuIEph Y2tzb24gPGlhbi5qYWNrc29uQGNpdHJpeC5jb20+DQo+PiAtLS0NCj4+IENIQU5HRUxPRy5tZCB8 IDMgKysrDQo+PiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspDQo+PiANCj4+IGRpZmYg LS1naXQgYS9DSEFOR0VMT0cubWQgYi9DSEFOR0VMT0cubWQNCj4+IGluZGV4IDJmMjZjZDVjODcu LjljMjcyYTAxMTMgMTAwNjQ0DQo+PiAtLS0gYS9DSEFOR0VMT0cubWQNCj4+ICsrKyBiL0NIQU5H RUxPRy5tZA0KPj4gQEAgLTI4LDggKzI4LDExIEBAIFRoZSBmb3JtYXQgaXMgYmFzZWQgb24gW0tl ZXAgYSBDaGFuZ2Vsb2ddKGh0dHBzOi8va2VlcGFjaGFuZ2Vsb2cuY29tL2VuLzEuMC4wLykNCj4+ ICAtIEZhY3RvcmVkIG91dCBIVk0tc3BlY2lmaWMgc2hhZG93IGNvZGUsIGltcHJvdmluZyBjb2Rl IGNsYXJpdHkgYW5kIHJlZHVjaW5nIHRoZSBzaXplIG9mIFBWLW9ubHkgaHlwZXJ2aXNvciBidWls ZHMNCj4+ICAtIEFkZGVkIFhFTl9TQ1JJUFRfRElSIGNvbmZpZ3VyYXRpb24gb3B0aW9uIHRvIHNw ZWNpZnkgbG9jYXRpb24gZm9yIFhlbiBzY3JpcHRzLCByYXRoZXIgdGhhbiBoYXJkLWNvZGluZyAv ZXRjL3hlbi9zY3JpcHRzDQo+PiAgLSB4ZW5uZXQ6IERvY3VtZW50ZWQgYSB3YXkgZm9yIHRoZSBi YWNrZW5kIChvciB0b29sc3RhY2spIHRvIHNwZWNpZnkgTVRVIHRvIHRoZSBmcm9udGVuZA0KPj4g KyAtIEZpeCBwZXJtaXNzaW9ucyBmb3Igd2F0Y2hlcyBvbiBAaW50cm9kdWNlRG9tYWluIGFuZCBA cmVsZWFzZURvbWFpbjogQnkgZGVmYXVsdCwgb25seSBwcml2aWxlZ2VkIGRvbWFpbnMgY2FuIHNl dCB3YXRjaGVzOyBidXQgc3BlY2lmaWMgZG9tYWlucyBjYW4gYmUgZ2l2ZW4gcGVybWlzc2lvbiBp biBvcmRlciB0byBhbGxvdyBkaXNhZ2dyZWdhdGlvbi4NCj4gDQo+IFRoaXMgaXMgWFNBLTExNSwg YW5kIGlzbid0IHNvbWV0aGluZyBuZXcgaW4gNC4xNSB2cyA0LjE0LiAgKEkgdGhpbms/KQ0KDQpY U0EtMTE1IHdlbnQgcHVibGljIGR1cmluZyB0aGUgNC4xNSBkZXZlbG9wbWVudCB3aW5kb3cuDQoN ClNvIG9uIHRoZSBvbmUgaGFuZCwgaXTigJlzIGNlcnRhaW5seSBlZmZvcnQgdGhhdCBoYXBwZW5l ZCBkdXJpbmcgdGhlIHdpbmRvdywgd2hpY2ggaXQgd291bGQgYmUgZ29vZCB0byBoaWdobGlnaHQu ICAgT24gdGhlIG90aGVyIGhhbmQsIGl0IHdhcyBiYWNrcG9ydGVkIHRvIGFsbCBzZWN1cml0eSBz dXBwb3J0ZWQgdHJlZXMgKD8pLCBzbyBpdOKAmXMgbm90IHNvbWV0aGluZyB5b3UgbmVlZCB0byB1 cGRhdGUgdG8gNC4xNSB0byBnZXQuDQoNCkhvbmVzdGx5IG5vdCBzdXJlIHRoZSBiZXN0IHRoaW5n IHRvIHN1Z2dlc3QgaGVyZS4NCg0KPiANCj4+ICsgLSB4ZW5zdG9yZSBjYW4gbm93IGJlIGxpdmUt dXBkYXRlZCBvbiBhIHJ1bm5pbmcgc3lzdGVtLg0KPiANCj4gVGhpcyBuZWVkcyB0byBiZSB2ZXJ5 IGNsZWFyIHRoYXQgaXQgaXMgdGVjaCBwcmV2aWV3LiAgSXQgZG9lcyBub3QNCj4gY3VycmVudGx5 IHdvcmsgY2xlYW5seSBpZiBhIG1hbGljaW91cyBWTSBkZWxpYmVyYXRlbHkgaG9sZHMgYQ0KPiB0 cmFuc2FjdGlvbiBvcGVuLg0KDQpPSywgSeKAmWxsIGFkZCAodGVjaCBwcmV2aWV3KSBhdCB0aGUg ZW5kLg0KDQpUaGFua3MsDQogLUdlb3JnZQ== From xen-devel-bounces@lists.xenproject.org Thu Apr 01 14:14:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 14:14:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104525.200013 (Exim 4.92) (envelope-from ) id 1lRy5C-0002iw-GX; Thu, 01 Apr 2021 14:14:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104525.200013; Thu, 01 Apr 2021 14:14:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRy5C-0002io-Co; Thu, 01 Apr 2021 14:14:02 +0000 Received: by outflank-mailman (input) for mailman id 104525; Thu, 01 Apr 2021 14:14:01 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRy5B-0002iT-I3 for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 14:14:01 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1ed5b708-1ae2-452b-9cec-5750334e0ebf; Thu, 01 Apr 2021 14:14:00 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 15963AEB9; Thu, 1 Apr 2021 14:14:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1ed5b708-1ae2-452b-9cec-5750334e0ebf X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617286440; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xpCVOHY80H//GRsONMEcUeWejoev2F5CSJsOZBHVfLU=; b=QKdfwdwPg8c+FXt3I9Whhyv7IWON66MZT9G4F2k7uVMUdwszRkSo3w1bfDAcv+L35sFNQP UMSgyzUbQHwk4dq8MggyfiMAkb5jhd06sAGb54CsCUMaO7yA/u19EtSoNTdiw5A4lqBoDN F+eD6nPqI/zE+Q1S+3+On5OjCIb3nS0= Subject: Re: [PATCH for-4.15 5/7] CHANGELOG.md: Various new entries, mostly x86 To: George Dunlap Cc: Ian Jackson , Andrew Cooper , Roger Pau Monne , xen-devel@lists.xenproject.org References: <20210401133827.362216-1-george.dunlap@citrix.com> <20210401133827.362216-5-george.dunlap@citrix.com> From: Jan Beulich Message-ID: <64e450c6-26de-453d-3b57-5d8c0daa85fa@suse.com> Date: Thu, 1 Apr 2021 16:13:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210401133827.362216-5-george.dunlap@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 01.04.2021 15:38, George Dunlap wrote: > ...Grouped mostly by submitter / maintainer > > Signed-off-by: George Dunlap Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Thu Apr 01 14:15:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 14:15:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104532.200026 (Exim 4.92) (envelope-from ) id 1lRy69-0002xz-Sl; Thu, 01 Apr 2021 14:15:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104532.200026; Thu, 01 Apr 2021 14:15:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRy69-0002xr-N0; Thu, 01 Apr 2021 14:15:01 +0000 Received: by outflank-mailman (input) for mailman id 104532; Thu, 01 Apr 2021 14:15:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRy68-0002xg-5m; Thu, 01 Apr 2021 14:15:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRy67-0007Sj-V2; Thu, 01 Apr 2021 14:14:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRy67-0002d9-LY; Thu, 01 Apr 2021 14:14:59 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lRy67-0007ZZ-K2; Thu, 01 Apr 2021 14:14:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7+GDFXYJ7Fg7fPny0vfQE89LDGIi9OPq4nL94pXaCrw=; b=LtTgmVBOQ/cn2fiOMi21K6gLXc NV7b6GYrCJItP3b14bfsUgBVFTQXSjMPX1Cl/Z5iTSfCfuc4NtHfKJQ1UZljRRhVfwrc5/qulM1GG OxW4RiJbrM8Hkmro3HqS8Hm3ENXO+ICsJQ7z3NADWP432mjONRGUuaAXO1StXpgOT6MA=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 160641: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=b0976d5c0441378b6348f5bfedbf431055bd0147 X-Osstest-Versions-That: xen=90629587e16e2efdb61da77f25c25fba3c4a5fd7 From: osstest service owner Date: Thu, 01 Apr 2021 14:14:59 +0000 flight 160641 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/160641/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen b0976d5c0441378b6348f5bfedbf431055bd0147 baseline version: xen 90629587e16e2efdb61da77f25c25fba3c4a5fd7 Last test of basis 160565 2021-03-30 17:00:31 Z 1 days Testing same since 160641 2021-04-01 11:00:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: George Dunlap Jan Beulich Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 90629587e1..b0976d5c04 b0976d5c0441378b6348f5bfedbf431055bd0147 -> smoke From xen-devel-bounces@lists.xenproject.org Thu Apr 01 14:16:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 14:16:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104536.200040 (Exim 4.92) (envelope-from ) id 1lRy7P-00036v-6X; Thu, 01 Apr 2021 14:16:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104536.200040; Thu, 01 Apr 2021 14:16:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRy7P-00036o-2z; Thu, 01 Apr 2021 14:16:19 +0000 Received: by outflank-mailman (input) for mailman id 104536; Thu, 01 Apr 2021 14:16:17 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRy7N-00036d-Eu for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 14:16:17 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 50b111d6-1cab-49a9-808a-7b11de934d13; Thu, 01 Apr 2021 14:16:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50b111d6-1cab-49a9-808a-7b11de934d13 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617286576; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=/AFZAxvtPkioA0oxc3Q9LLCMrNqNrN7KaPiE+TBdwfE=; b=VjPrQXOwikqVXTFQxM6nHeBjmZuk5+iCzA70hKgPRNCfCfiA4yFQC1aX Z4jj5VQt4856GOyx9ojntD3VFPPX+OolgWnf7gI1HXjINaMLaLrsQc+bX 4WZEQaS9bRrt18mzhw1z5s/rNCaDc8F2DUOINNc+FGIJfjtHy2PvgksnQ s=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: H4ExOqUTVgzKHJLmVWNYKa/9p/bIuv+Gi3OiRFppPL79J+YqAm9E6kvHdWnEMJY835w2HitBKp BSWWf8saC2ZGtFSUPyZLGgftc4ktqrS8VSrJnki2/I2x31EhMhIgswAqARQbOg5ftB9wbgAMfI ZjUU/IsEyo7yk+o/7z3plmqYVmu48ZUllZQFR/d37nB4+d+AbDrh7E4IVQqNAKYub0ntlbVuBx RWvqCy2pFylPQhMUbvSs7tvpXfdidrib12G0aR0vEv4HaimssTSVAALa7sWe9ul19IpRyvrk6l shY= X-SBRS: 5.2 X-MesageID: 40686574 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:CdjIK6scf2I5RdIYMK4iOAD/7skCWIYji2hD6mlwRA09T+WxrO rrtOgH1BPylTYaUGwhn9fFA6WbXXbA7/dOjrU5FYyJGC3ronGhIo0n14vtxDX8Bzbzn9Qw6Y 5JSII7MtH5CDFB4PrSyAOzH888hPyO9661jenTpk0dNz1CQYsI1XYaNi+wFEpqSA5aQb8wE5 SB7sRKzgDQBEg/RMK9G3UDQqz/t8TG/aiWLCIuKhY75GC1/FWVwZHgFRzw5HcjehNJhYwv6G 3U1zH+j5/TyM2T7j/5+yvt449NmN3no+EzSPCkrsQOMD3jhkKJSe1aKsS/lQs4qu2u91om+e Oky3xLUaVOwkjccW2vrRzm1xOI6kdX11bYxUKFmnymmMTlRVsBeo58rLhEeRjU4VdIhqAY7I t33nmUv5cSLRTMkDWV3amuazhWl1G5qXdnrOgLj3Y3a/p7VJZtq+UkjSBoOaZFOBi/xJEsEe FoAs2Zzu1Ra0mmY3fQuXQq6MCwX1wody32DXQqi4iw6Xx7jXp5x0wXyIg0hXEb7q8wTJFC+q DtLrlorrdTVcUbBJgNStspcI+SMCjgUBjMOGWdLRDMD6ccIU/ArJbx/fET6Py1focLiL8/go 7IXl8dlWNaQTOuNeS+mLlwtjzdSmS0WjrgjutE4YJih7H6TL33dSKZTlQjlNahvuUfDsXXV+ 3bAuMUP9bTaU/VXapZ1Qz3XJdfbVMEVtcOh9o9U1WS5sLHQ7ea9NDzQbL2Hv7AADwkUmTwDj 8oRz7oPvhN6UitRzv/mxjeW3Tkf0Tl5pJuGK3G/+weobJ9drFkg0wwsxCU98uLITpNvugKZ0 N4Oqrgib7+j3Kx53z042JgPQd9Ak5Z7K77aW5DoRYHPirPAPM+kuTaXVoX/XOcYjdjUsvdEW dk1ihK0JPyC6bV+AcPJJaMNHmAg34auXSQJq1s5ZGr1IPCYZM3DpEvRaprMx7EfiYF3jpCoH tfaQMCW0/UHi7vj6Lgl5APGOTDbbBH8XmWCN8RpnTFuUqGo8YzAnMdQj61SMaSxR0jXjxOmz RKguQiqavFnTakMm0khuskdFVKdWSMGbpDZT71Lbl8i/TueAtqS32NiiHfgxYvenDy/0FXgm D6NyWbdbXKBVVa00oomprC4Rdxdm+HeVh3ZW0/uYphFX7esnI2yPSVfMOIoh+sQ0pHxvtYPC DOYDMULA8rz9er1ASNkDLHEXk93J0hMuHUEbxLScCY5lq9bImT0a0WFf5d+5hocMrjteIGSu qTcQ6YJjGQMZJe5yWF4nI+fCVkongtlv3lnAD/5G+jxXglHL7cJk9lS7xzGaDo00H0A/KTlJ N3gtI+sbHubiH/atuaxbrWaDAGIBXJumKyR/wpr5cRva9ajsoBI7DLFT/TkHdA11EiKc2xkk UUSqFy+qrANY9iZNZ6QVMvwnM50NCUaFI2uQn3CPIkdV4jj3XHL8qEioC42YYHEwmEvk/sIl GR/C1W4ufdUyaC3bAcDbgsIW4+UjlP1F1yuOWYd4PRDw22d+ZMuFqiW0XNAYNgdA== X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="40686574" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fC4lZ+sheUYHanELUSClfLLk+/hQQrPWoPFDngBIvA+5qNXAA48Rf7UIVz21XtOaF+l8cTrwldtKqDmf6JE4zYf7Vjd6nAKJ9QoMaI4LJTWq3ZGACNdxVv8GRiglSGRTXOxZ/0Jt8LVdZfR07M0m6LCJ1euRWnIjYFyrQPSqwbclYwRNeC41bqLjiaknuUzhHW8ypQ5fpDWI/8LWmxlW7P6+WGXJQpwKOYrimSDjQSIYNY9+cnppq6leE6lf0Lv8W2IRShkFKBoQCfyTCZ9YCivVzhqOyXGtEohhHzP7S3TTHUZABGNien0aPdRqOIzmB609iEtnB/FXsKwqsbVmjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lN5z1D6OE0t0qCn/asYOcJEbcsKHwmaA4C8+DhC2aGw=; b=BhEQb/F1A2OaNh/XWsSG+azyKENMKeRMDobkLFjKwAohDxqVAqYHVO5G+CEG6El55tlwHWTbVPS46aLHvHJ37ExbPNvoqzUMVBMdfCkPcIsgwkKJNAEzAhRcycrF1ebh8mS7Hi2fFNXnrvICMy5ymThGPayM0u/KTWyF291fkE5C7xVvim8T7XOMp/3/BmEIo+fPjFXI7Y2ipiSyeZu+QVsh4N8co7VBWTnkYBL2p0en3PU3VFs/lAzdS/J4FijOAJuiRjwM19kIP9DTmcigUB0GoopLVhfECcUa6KPFdCcIS3U18f1xg1saV+xYcLlFfQDyyXP6ILUUBh2vKDhpVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lN5z1D6OE0t0qCn/asYOcJEbcsKHwmaA4C8+DhC2aGw=; b=LLGxGEtyOmMPa8w14rzdVJ7Q8l+wJeXzyuvutwi67p2AiE0cbd5uHeowsQKJwAmNQcTQlExi7Pehgdb8AtJ6upp39//ulwmSbt3oba6URetT67BXZpVIdrLxpp7mBDFzbaLsDReURzIGDKwJu/LoLqzq3JrPVANNF84+uXAJPAU= Subject: Re: [PATCH for-4.15 6/7] CHANGELOG.md: Various entries, mostly xenstore To: George Dunlap CC: xen-devel , Juergen Gross , Jan Beulich , Ian Jackson References: <20210401133827.362216-1-george.dunlap@citrix.com> <20210401133827.362216-6-george.dunlap@citrix.com> <97d317fb-16d7-a14e-e74e-62fa83159838@citrix.com> <07553207-90AA-4AD4-A5C2-C8F36411DDCB@citrix.com> From: Andrew Cooper Message-ID: Date: Thu, 1 Apr 2021 15:16:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <07553207-90AA-4AD4-A5C2-C8F36411DDCB@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0083.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::23) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 190249cf-1351-4dc1-5744-08d8f518b04b X-MS-TrafficTypeDiagnostic: BN8PR03MB5139: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KLR7ydKTB8B3dscs4uTG5IQ9ONnVaclDZjf4n2ymakR+dCf+C/MZGKfzyPX9j6icBt+RuCBkcHt2SkM+Cu0/26eIkJqhAT/fWmj+o9MRfynzIzcIpIlZ6khesQx9y7EkT69cl/SyC9CpEX1MQ1KbWRuCzquzxINkq6ZbE2JNKAToKcfusGLLXf1fp+H9I/MDAojPDecm9S7psEv7fnNlxjQSeHrsHiWzK2FeVgZxL2bY21vVh/ON53I/YSndi7gJYyIuroe2BfIoNyKWdb+3PYyYTB2C03fCJgr5AloTvPf6VHN9Kh6i6t94RfQelXozXQmZtldafTcQektColJjrTToBI2q82nGu0ivnjYbc1su4X6VKvUYJtDD7QWsBuXbaPI2aIbVoVERMPGe2fwTkiEGszV5bO9kNQclCPcN6jjYpqVZRfDVYDvEpDp5i1SAWHpAhR3AVWbkQwBW499fmG5XRZj5ecWkjnSJxq9x7HRnv/gRqyD0QtcX0HWhCXLQi8f8RzMENLPS8ZtUNIWD7d7Z9FoaIix24z9sqSY+1+v5Rmmk7KPFtSzgeKAHeSS2vkxY/NWL1hYlFn2B3nQZwU9Ph+5yZQD++SlbB8q+9jaNmzjuk/STSfJAj6PjOaRSJAw1Knos8pA9BOyLeKQusQplAQPdswPTEMWNDIWAxB7Kv/vUc589Wva3YtuiTpuUW6I3+S9l3HhH+ITPdSD0yc+V7gZjz3G0TtAydUBWdj9AKIUDIKKWO7Ar3qTNFehiFyYGzj7FtjV5H8X+DJvjpcMpgvTCChcFj6kLfOw4AEHa09QtC4j4le+NJmzgtnfpJ3+zzD4nIYF2g7Ob63k7mbLvwAsiC4iX9RszbprYTcebPHJO0lr6p8lhCDKJ83GB X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(396003)(346002)(39860400002)(136003)(366004)(8936002)(6862004)(66476007)(83380400001)(38100700001)(66556008)(31686004)(6666004)(66946007)(53546011)(54906003)(26005)(8676002)(36756003)(186003)(6486002)(31696002)(478600001)(16576012)(6636002)(2906002)(956004)(4326008)(107886003)(5660300002)(2616005)(316002)(37006003)(86362001)(16526019)(59356011)(207903002)(219803003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?YXlWeW10eFlSVXdvWmo4SzZWb3RpaWdsWVd3ZnRkYUJzM1hGcThGVWZqRUly?= =?utf-8?B?NnZCaXRTN0FWWGhzdWJMUEJlNGhzYTRkaU1BRFpzTlBZUlI0bG9oV0MxczNh?= =?utf-8?B?Skl3VWlqY0tRLytaQ3Vqc09VV2pTYWQ4VW80TTg2SlBkVXloWmYrWXM0eStn?= =?utf-8?B?T2JxakxWSXNSWFNLZlQ3anJrNDczWFpJMWVKWGc4VFduRDB6Nk1pZjdLdHBB?= =?utf-8?B?cVVMSkcrRHNCQXFWaHFscjJvSW1WZnpXR25NTE81S3hneVdQSGVqTXpsclZs?= =?utf-8?B?QnlZUUlKcVlONFYwTm9xODZaVjNGNGZRVjQ5RGwyYTRneWkvSFh0VE5lNVlK?= =?utf-8?B?dDQzVzAyMHJmMnZvaWh3UWY0UG8vV2QvbXROTE81NUs4SFVqYVluWkpHbTF0?= =?utf-8?B?Z256c2dFYmdiOUszanlTSERTT1U0b1VDYWFLeTJGeURNYkV0SHlxeDE5bklC?= =?utf-8?B?VmN6eG13ZVlUMGs0dTgrTFZUd3FiMXF5UFNoeHJZUWMxOXY4aE5CS2hyOU85?= =?utf-8?B?b0pLS0xWTnBMZGdsa05qOW85ZnptaXBGeDdhNWRmcUU4TGZ0dHRHaDlwcFc4?= =?utf-8?B?dWFNaERLMVIyMnhNS0FPbWk0TkVvYlJWT0pkb1R2RjExQ0RhYkRFN0ZyU0VV?= =?utf-8?B?NTlqVDlqVXFLWUpPbUFUYW9XQnA3eDdTU3RGaHBRdGlMajFoQXU3L1NCZ2hC?= =?utf-8?B?OVVPTDMweWhLNWxDVWRoZVR0cUxOZXcvN3N0Y09xQUtjWm1hRVVhdkg0cURq?= =?utf-8?B?eEdtK2ZkYm5FRnFTUlZuS3d4UktQaW1acDYwb0NBbUV2d1Uwc3pTak5UZTBC?= =?utf-8?B?Q01JQ2p4QVdXQnREc2lXQmtWRHYwYXI1T1kyYnFrbXRWMHhsay9UMUJ5aEFh?= =?utf-8?B?STMvV1J2RjZiMVFhUG9aQ2x3SW9uVzcwK0VqUVowc3V4L1hZdUI2UnJDZXhh?= =?utf-8?B?ZFdOWXRKVkVqcER1T0M0T0doTFRtQzdxbGdvNTJDZkRmSmFPM1dOVW5qaUtJ?= =?utf-8?B?ejhaZ0VKSGROWUNCTjhIQmVVaFZXMlgxOFRJV05RN21sM256TlZtZDdac1hY?= =?utf-8?B?Vys1Vm9oQy8rT1NLQUtNeVlDcmU4VFlVd2UxMEVXQzdBZ3VuOXZmU3ArMHpn?= =?utf-8?B?WHRhdXhhc1FFYTFhSkxmYUVTaU1EczRsVEJTeno0eEY5aFZSZGlLdGtVTVdo?= =?utf-8?B?Y1RaVkFHZEQrRllKeXhtWFJjUGpLOXl3YitzMkNRdDFIV01iaVpyQi9nQUxi?= =?utf-8?B?NWc2WC9hdTBvc2dlYUcxMTNnT21BY3kzNm1oRHpPWlNveUR4UVUzOEJiRlg4?= =?utf-8?B?bXMvOTg4NmI3cnZnT1hPRE43VTQyRU1WSmtteXpZOGRSeHBDblFhbnpCNUhs?= =?utf-8?B?RVMwaG55SFhUQWxaYmUyZEw1U0ZuSVY1ZjBnTzczR28rNzQ2YnRCWGpWMkhm?= =?utf-8?B?VnNzZit3dWx1VlkzTmFKc1RaNUl4SkR6NmhDUlZieHNHb1VwYWw1SytZQmd1?= =?utf-8?B?V3FmcytENEZiNEtONGQ4VDBMYjJOTkgrbC9RTEF5NklZVUZJV05OdlAxanhN?= =?utf-8?B?a1lBMHlNcUwwcTBSZURvVUU5K2FlVlB6ZVgzVlp1eFRTanVDdnkvSGt0cVFS?= =?utf-8?B?NWtkSE5QVWJjaWw2S3gyZE1VMVhkVzN5RWJIbDhIVk02VXNmVlNUaWpXQ3hJ?= =?utf-8?B?dy9VZXE1ZzZpcEJPYXV1UUV0andTUEhMRmcvd2JDNzJiWGk3bWEwU2VadXhT?= =?utf-8?Q?fbNt17oiH5DmhEcQOoVpSHFSm20nZsz6N0TDotz?= X-MS-Exchange-CrossTenant-Network-Message-Id: 190249cf-1351-4dc1-5744-08d8f518b04b X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 14:16:06.2051 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wA1bIG64Dda4b7kgDcp9Goh5W2EeDZ9zobsF2ACgq23LU6asI9KeHFLuz7X3HlzjfyO6TTy9tnckdl7stWVnuU349tee9M+if0LWnjBMCNU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB5139 X-OriginatorOrg: citrix.com On 01/04/2021 15:13, George Dunlap wrote: > >> On Apr 1, 2021, at 3:00 PM, Andrew Cooper wrote: >> >> On 01/04/2021 14:38, George Dunlap wrote: >>> ...grouped by submitters / maintainers >>> >>> Signed-off-by: George Dunlap >>> --- >>> CC: Juergen Gross >>> CC: Jan Beulich >>> CC: Ian Jackson >>> --- >>> CHANGELOG.md | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/CHANGELOG.md b/CHANGELOG.md >>> index 2f26cd5c87..9c272a0113 100644 >>> --- a/CHANGELOG.md >>> +++ b/CHANGELOG.md >>> @@ -28,8 +28,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) >>> - Factored out HVM-specific shadow code, improving code clarity and reducing the size of PV-only hypervisor builds >>> - Added XEN_SCRIPT_DIR configuration option to specify location for Xen scripts, rather than hard-coding /etc/xen/scripts >>> - xennet: Documented a way for the backend (or toolstack) to specify MTU to the frontend >>> + - Fix permissions for watches on @introduceDomain and @releaseDomain: By default, only privileged domains can set watches; but specific domains can be given permission in order to allow disaggregation. >> This is XSA-115, and isn't something new in 4.15 vs 4.14. (I think?) > XSA-115 went public during the 4.15 development window. > > So on the one hand, it’s certainly effort that happened during the window, which it would be good to highlight. On the other hand, it was backported to all security supported trees (?), so it’s not something you need to update to 4.15 to get. > > Honestly not sure the best thing to suggest here. We either want all XSAs discussed, or none of them.  Possibly as simple as "the following XSAs {...} where developed and released" ? I recall Lars making this part of the release notes in the past. > >>> + - xenstore can now be live-updated on a running system. >> This needs to be very clear that it is tech preview. It does not >> currently work cleanly if a malicious VM deliberately holds a >> transaction open. > OK, I’ll add (tech preview) at the end. SGTM. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 01 14:17:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 14:17:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104539.200051 (Exim 4.92) (envelope-from ) id 1lRy89-0003DW-Fp; Thu, 01 Apr 2021 14:17:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104539.200051; Thu, 01 Apr 2021 14:17:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRy89-0003DP-Ce; Thu, 01 Apr 2021 14:17:05 +0000 Received: by outflank-mailman (input) for mailman id 104539; Thu, 01 Apr 2021 14:17:03 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRy87-0003DG-Sh for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 14:17:03 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1741e65f-18c6-4991-8feb-2be4e4e6d6a0; Thu, 01 Apr 2021 14:17:02 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 24A23B15F; Thu, 1 Apr 2021 14:17:02 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1741e65f-18c6-4991-8feb-2be4e4e6d6a0 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617286622; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OvO5C0SRpjkQLKwcYLbhj9/Kcb0lIHrpUuAKPqxabU8=; b=cK1OAgb51tVnFKwGYSe8xiYno1mYAr6AEEfVrmgo4VT7isz68yxAbpfA+nwcqTM7Ld8HGB 5nI9S2ONaSIV9WkIKrrcQXso7CiwvUBJUAudc72S67O0L1zDL24amv6Xvuo2QBOM2bfv0K hIh/9a8ab76EtWpC+puTqyXEJL1J1AE= Subject: Re: [PATCH for-4.15 7/7] CHANGELOG.md: irq-max-guests To: George Dunlap Cc: Igor Druzhinin , Ian Jackson , xen-devel@lists.xenproject.org References: <20210401133827.362216-1-george.dunlap@citrix.com> <20210401133827.362216-7-george.dunlap@citrix.com> From: Jan Beulich Message-ID: <37b76a6d-e81b-1581-d89c-0d99a9d2eba9@suse.com> Date: Thu, 1 Apr 2021 16:17:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210401133827.362216-7-george.dunlap@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 01.04.2021 15:38, George Dunlap wrote: > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -33,6 +33,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) > - Some additional affordances in various xl subcommands. > - Added the following ARM errata: Cortex A53 #843419, Cortex A55 #1530923, Cortex A72 #853709, Cortex A73 #858921, Cortex A76 #1286807, Neoverse-N1 #1165522 > - On detecting a host crash, some debug key handlers can automatically triggered to aid in debugging > + - Increase the maximum number of guests which can share a single IRQ from 7 to 16, and make this configurable with irq-max-guests Acked-by: Jan Beulich albeit I again wonder if this isn't too small / niche a change to warrant an entry here. Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 01 14:20:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 14:20:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104542.200064 (Exim 4.92) (envelope-from ) id 1lRyBl-00046V-24; Thu, 01 Apr 2021 14:20:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104542.200064; Thu, 01 Apr 2021 14:20:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRyBk-00046O-TI; Thu, 01 Apr 2021 14:20:48 +0000 Received: by outflank-mailman (input) for mailman id 104542; Thu, 01 Apr 2021 14:20:48 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRyBk-00046J-05 for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 14:20:48 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 158914c4-a5a2-4f2d-a51d-9047524db5f4; Thu, 01 Apr 2021 14:20:47 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 49237B1D8; Thu, 1 Apr 2021 14:20:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 158914c4-a5a2-4f2d-a51d-9047524db5f4 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617286846; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VOqeogxbK6VN2FJQOF4re0MvTB3ZQ8p0SRm2kVH04DU=; b=a2R+AwBvkbxtxfqzk+A+eT+VW0c/cGJG0VL0NepV/MmCyFZLhRJ+UhhnRbCVlXVuv0Zzxf la1si4LPrenGY/N1mOfxd16YsnFUhdTWocZo8op5MBjKWgnIpSX/qoUy2YQFdrtwScvcIg tporoK5CwvqI8U5sIutZRbSh8pymBIk= Subject: Re: [PATCH 5/5] x86: don't build unused entry code when !PV32 To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu References: <46d83c92-0b06-fc09-4832-7a7d7935d5c2@suse.com> From: Jan Beulich Message-ID: <6b4e302f-2c50-5e6d-aadc-720c7efdd2e5@suse.com> Date: Thu, 1 Apr 2021 16:20:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 01.04.2021 16:01, Roger Pau Monné wrote: > On Wed, Nov 25, 2020 at 09:51:33AM +0100, Jan Beulich wrote: >> @@ -230,6 +230,13 @@ ENTRY(cstar_enter) >> sti >> >> movq STACK_CPUINFO_FIELD(current_vcpu)(%rbx), %rbx >> + >> +#ifndef CONFIG_PV32 >> + >> + jmp switch_to_kernel >> + >> +#else >> + >> movq VCPU_domain(%rbx),%rcx >> cmpb $0,DOMAIN_is_32bit_pv(%rcx) >> je switch_to_kernel >> @@ -393,3 +400,5 @@ compat_crash_page_fault: >> jmp .Lft14 >> .previous >> _ASM_EXTABLE(.Lft14, .Lfx14) >> + >> +#endif /* CONFIG_PV32 */ > > Seeing this chunk, would it make sense to move the cstar_enter part > relevant to !is_32bit_pv into the common entry.S and leave the rest > here as compat_cstar_enter or some such? > > AFAICT we only need a tiny part of the compat stuff when !CONFIG_PV32, > so I think we could make the hole compat/entry.S depend on > CONFIG_PV32. To be honest I was meaning to see whether this would work out reasonably well in a separate, follow-on change, as the code movement might make it harder to judge on the change here compared to the #ifdef insertions. But maybe I was wrong and should give this a try right away. Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 01 14:25:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 14:25:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104545.200076 (Exim 4.92) (envelope-from ) id 1lRyG6-0004Ia-K5; Thu, 01 Apr 2021 14:25:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104545.200076; Thu, 01 Apr 2021 14:25:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRyG6-0004IT-Fh; Thu, 01 Apr 2021 14:25:18 +0000 Received: by outflank-mailman (input) for mailman id 104545; Thu, 01 Apr 2021 14:25:17 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRyG5-0004IO-2k for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 14:25:17 +0000 Received: from mo6-p00-ob.smtp.rzone.de (unknown [2a01:238:400:100::b]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 32a6c0d1-7127-439c-9264-39585dc02db7; Thu, 01 Apr 2021 14:25:15 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.24.0 DYNA|AUTH) with ESMTPSA id 005bafx31EP99L9 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 1 Apr 2021 16:25:09 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 32a6c0d1-7127-439c-9264-39585dc02db7 ARC-Seal: i=1; a=rsa-sha256; t=1617287110; cv=none; d=strato.com; s=strato-dkim-0002; b=j4iAYUbgEisykYQRzKU0rugcUpNY7CL/gaqgVLpkf/lr8b/YHG4MoGK2zQzm2odIK/ tU41KXALKj1wrbTmWP0vrAfGdMaqd/k++X9rw8NYSik8eiLtDN06nRhvMmvINCP5+SgM K4AqBlwfQOmgGjCQLWzjclkyEcXP7/L/bnoc34boIM4vhZZGnwmX1OMGspSWRvqKhFy7 5lfTZEoNooxAsMj10en9SdfpcltIvSfHBPufE9Gb45jE8+QHYYx7RE3Qio3PTsPy/kgs tZMDIwB9+Sl8L/LfApEkmPI17K7405oAcwwV5wqcKuSUlZQJxdA9kOUYA6p1cNDrYaq1 sglw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1617287110; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=FM41hKIuLgnoLVd8uBVj7PEK15Ao/d5Jsy/Z+nsM4dU=; b=AwbgkmDOZE8QubP0r0NyehAL9JfvSvj95Yl6uybNBIaxSGPAX3DIKfz/vOzi8BnFkT s3fPO40PaEedLoerldGvruCkDXrhylA/ijRBHdSbb6DU78NRY4UjIaOmY8NwtHMcOEp0 tWYUlA8+wZcdyx5UiHphp8XJl3ZJ5By7P5+EGr9FJUQez4qbLm3v0ObGD1Stg9Y/Lt13 8g55h1JS7DBJj9teeEdc35YeVVug4GCSc9Jj5aciyM4/if9gq/ILXJedKX23Yidr+4eR Z7tt8AZtvR36hJ/gkFg9Ih/h8LrEndNeZagRk+3U/g5D0QFG5Ruy457EDYrr9lmE1etS 9uwQ== ARC-Authentication-Results: i=1; strato.com; dkim=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1617287110; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=FM41hKIuLgnoLVd8uBVj7PEK15Ao/d5Jsy/Z+nsM4dU=; b=MXVE+hGinVIwP1D8PSNVFCa9IOVjfgh8F7JhvBCPey7XbMJgAzzCOCd7yh+5tz8FG2 +98mLaIC2XC9d3XHZAgQZPGblkdwhnrdfONTd9SncK4aGbeEc5bWuGFxFRiE2vUT4SaE 6qXIcV5xB+RSO1y8bGWY8SBLWZ5fOBlsi/0wMpilIAXFKjKrUlbzW2IHlFv5wYdlE9Gj Tvvrj6IS3RahCR7v0ItY2uXPanYJL8IOgWGHMTbFRO7OaZzr4tGGDxiB+Y8tZ476KObN ISV+ggVJa42vpSc+NOjeE9KLBvBKcotOHTlupcKNjk1fse0FnmdkmvOz/GZK46MVMk1Z 8Zrg== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDXdoX8l8pYAcz5OTW+P6/A==" X-RZG-CLASS-ID: mo00 Date: Thu, 1 Apr 2021 16:24:54 +0200 From: Olaf Hering To: Anthony PERARD Cc: , Ian Jackson , Wei Liu Subject: Re: [XEN PATCH for-4.15] libxl: Replace deprecated QMP command by "query-cpus-fast" Message-ID: <20210401162454.78fb0290.olaf@aepfle.de> In-Reply-To: <20210322141744.522041-1-anthony.perard@citrix.com> References: <20210322141744.522041-1-anthony.perard@citrix.com> X-Mailer: Claws Mail 2021.03.05 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/4cFygLJ1LDJGH5ZoXulrxJK"; protocol="application/pgp-signature" --Sig_/4cFygLJ1LDJGH5ZoXulrxJK Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Am Mon, 22 Mar 2021 14:17:44 +0000 schrieb Anthony PERARD : > We use the deprecated QMP command "query-cpus" There is also the already removed "cpu-add" command used, which apparently = has to be replaced by "device_add". Do you happen to have a fix for this as well? Another thread suggests that more deprecated commands are used. I think the= y have to be adjusted as well, ideally before they finally disappear from u= pstream qemu. Olaf --Sig_/4cFygLJ1LDJGH5ZoXulrxJK Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmBl17cACgkQ86SN7mm1 DoBz+A//ZMJcUonxTlK57+9aisiRzk8Z7AQ7iM4r8iPX7athCtqpCplQNkhKvvx7 Ky3t3VR7+r4E+INxdtscZONRDS1RmhtJTy0Fa7VK8cpfeQo4YyHVBMk37gEN0CN/ 1m6K21Pc+EBMopoyBo6EvHPPibYt7bRjnhTRg/g/4OM0mWyTQPuzzhYAgsUo5g+d svnYW2hCNRXq0ZI0U5w+wM8oxO4ldRJQDM2DrPmeFeuBzid/QKXKd+M0PtTTEovr OjWdFBNtD9uGR0SbKy1ow6pS27muzJd3Ilo+E4FVehUm/Q45Xoxch5z1JbsqloDC IxQMrRYyOwNYyn2q22NrlEU7XsnU/SpJdsGuITiF0anShLLO8CpSmMvskwNlXQKA k1xaxPGm3N0LnqCnnvvmC0Jvt9wcrOw1BwVJfU9l7aLlGdQft57a3MDEtizCNlFx KUxyAURACD3oBhjiUwbNu7VQMj9BbUQSUI0zSV+0qPL32M5x5EDrWpDxr6/hz1o2 3mVf2rJuSQ5COKA3X/uEsaXDS0k4KB4fGDAHlMnSjLd+e0rcaJBbZ8ZjTzGP4TGr Bzqnpm1RVti7Ce1+1pkSCR+rP0NJUKhtYtRKPCR8SjzEbe3T5sRnwe10cmxkR1bk JX4ScbsAmsG4rr61YWqNJKYIEFmHyDgKM2vWUrVNI/zY0gLdHl8= =QY7s -----END PGP SIGNATURE----- --Sig_/4cFygLJ1LDJGH5ZoXulrxJK-- From xen-devel-bounces@lists.xenproject.org Thu Apr 01 14:27:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 14:27:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104551.200088 (Exim 4.92) (envelope-from ) id 1lRyId-0004R3-4m; Thu, 01 Apr 2021 14:27:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104551.200088; Thu, 01 Apr 2021 14:27:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRyId-0004Qw-1K; Thu, 01 Apr 2021 14:27:55 +0000 Received: by outflank-mailman (input) for mailman id 104551; Thu, 01 Apr 2021 14:27:53 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRyIb-0004Qq-HA for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 14:27:53 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6abfc8e0-307b-48a0-8f78-f7d7717b2082; Thu, 01 Apr 2021 14:27:52 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9CFFEB1BC; Thu, 1 Apr 2021 14:27:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6abfc8e0-307b-48a0-8f78-f7d7717b2082 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617287271; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uqjRHjMJw8JbA2dlMGmgldrt6ty/trqzJ0kd0jTS3x0=; b=T6OHUx5p4RbTA9CYGUOWblyujMjReWbQ0qY2dzRovS2e9vKkFK2OgTk2yLQNg8i9iKwK5N v4Pn3LeN8YcI6VX8SeV2py/tn7eJWdebUY9nQTBDVsc0PiVHIBGyXuiSt3bYVJZImsd3ax bUvpux0c5QaMfyh8VyHOoj7Xn9jp/1A= Subject: Re: [PATCH 00/23] further population of xen/lib/ To: Julien Grall Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <27916fa0-9ebd-a49a-bbb9-1ef47c2b5bf6@xen.org> <4f745d03-baa8-e9e6-692c-f9c9f401b766@suse.com> <6a38f0db-938b-fd13-48e6-6b538c85fe42@xen.org> From: Jan Beulich Message-ID: Date: Thu, 1 Apr 2021 16:27:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <6a38f0db-938b-fd13-48e6-6b538c85fe42@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 01.04.2021 16:04, Julien Grall wrote: > Hi Jan, > > On 01/04/2021 14:43, Jan Beulich wrote: >> On 01.04.2021 13:54, Julien Grall wrote: >>> On 01/04/2021 11:14, Jan Beulich wrote: >>>> This is to dissolve / move xen/common/lib.c and xen/common/string.c. >>>> One benefit of moving these functions into an archive is that we can >>>> drop some of the related __HAVE_ARCH_* #define-s: By living in an >>>> archive, the per-arch functions will preempt any loading of the >>>> respective functions (objects) from the archive. (Down the road we >>>> may want to move the per-arch functions into archives as well, at >>>> which point the per-arch archive(s) would need to be specified ahead >>>> of the common one(s) to the linker.) >>> >>> While I think it is a good idea to move code in xen/lib, I am not >>> convinced that having a single function per file is that beneficial. >>> >>> Do you have numbers showing how much Xen will shrink after this series? >> >> In the default build, from all I was able to tell, there's one function >> that's unused (strspn(), as mentioned in the respective patch description). >> I don't think I've been claiming any space savings here, though, so I > > You didn't. I was trying to guess why you wrote this series given that > your cover letter doesn't provide a lot of benefits (other than dropping > __HAVE_ARCH_*). > >> wonder why you make this a criteria at all. > > Because this is the main reason I would be willing to ack this series. > This outweight the increase number of files with just a single function > implemented. > >> The functions being one per >> CU is such that they can be individually overridden by an arch, without >> pulling in dead code. > > I would agree with functions like memcpy/memset() because you can gain a > lot to outweight the implementation in assembly. I am not convinced this > would be true for functions such as strlen(). strlen() is actually a pretty good candidate for overriding, and we may even want to on x86 with newer hardware's "Fast Short REP CMPSB/SCASB". > So overall, the number of functions requiring overriding will likely be > pretty limited and #ifdef would be IMHO tolerable. > > Although, I would be OK with creating a file per function that are > already overrided. For all the others, I think this is just pointless. Well, I don't see a reason to special case individual functions. Plus any reasonable static library should imo have one (global) function per object file in the normal case; there may be very few exceptions. Drawing an ad hoc boundary at what currently has an override somewhere doesn't look very attractive to me. Plus to be honest while I would find it unfair to ask to further split things if I did just a partial conversion (i.e. invest yet more time), I find it rather odd to be asked to undo some of the splitting when I've already taken the extra time to make things consistent. Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 01 14:31:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 14:31:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104554.200100 (Exim 4.92) (envelope-from ) id 1lRyMR-0005K3-Mp; Thu, 01 Apr 2021 14:31:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104554.200100; Thu, 01 Apr 2021 14:31:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRyMR-0005Jw-IX; Thu, 01 Apr 2021 14:31:51 +0000 Received: by outflank-mailman (input) for mailman id 104554; Thu, 01 Apr 2021 14:31:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRyMP-0005Jr-Ku for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 14:31:49 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2663b5a0-b1de-4a6a-b546-eb394d5d2eee; Thu, 01 Apr 2021 14:31:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2663b5a0-b1de-4a6a-b546-eb394d5d2eee DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617287507; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=90w5jA4jbGiIkJMuDTVp0iNzjgY4wW+DiB2ka72dg18=; b=fzFuVhVnivcV0fmZV76AQQCB9xwImubEZDZkgUfDqGe8t/P+OdVEYTjM H/8L/lekTegA8nZWX2Fz6gFCYQtblve8iARXIBLaEkb98n/KcRPbV7QKz QkB7EvXs1CuCJ50FM7jeOZVcMwhi8awkvX4rHjj+PeIgUya+vOUQhj8zq g=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: D2Qlt4VVMjKNS4+eJIO14HGPMG9+zWq6igtFUyICVMFCsYSNPC9Ewf/P3V68zhDoRx11Htna8i QnvXC+mqaTo98/nd0fH0QDisGZqq1tOf/tTtXpe9FcBMCmOUUVCES7Pj8iJBYw0CuV71ZVTwtN EPNHDb4LvTn6K1HmlX5SiUD55lQHnoFTTzvyUloArHAolVEPKIavQSkMe2pcVRx9+2DXapXy1d 2LBFhI0pVKOdbIiqT+UNwPlZs/+OXt/zKXfC9KraQu5ToIL4eglpoMxBKeRWNnkit1qlMT2QRg 970= X-SBRS: 5.2 X-MesageID: 40706608 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:PjZ3dKvKpLCOqbtp0uTmAO/V7skC54Yji2hD6mlwRA09T+WxrO rrtOgH1BPylTYaUGwhn9fFA6WbXXbA7/dOjLU5FYyJGC3ronGhIo0n14vtxDX8Bzbzn9Q26Y 5JSII7MtH5CDFB5vrSyAOzH888hPyO9661jenTpk0dNT1CQadm8gt/F0K/Gkp5WAFJCfMCZe Ghz+BAoCetfmlSU9SjChA+LqP+jvDotLajWx4JABY79BKD5AnF1JfWGwWVty1uNw9n7qwl9Q H+8jDRxqLmiP2jzw+Z6mm71eUupPLE6v9uQPOBkdIULDKEsHfjWK1EV6eZtD445MGDgWxa9+ XkmBsrM8Rt5365RAjcznXQ8jLt3zo053jpxUXwuwqEneXCWDk4B8Bd7LgpESfx1ks6sNlwlI JN0m6J3qAnaC/ooSXn69DEEyxtj0q/yEBS89I7sno3a+sjQY4UibZa0FJeEZ8GEi6/wpsgCv NSAMbV4+sTWU+GbljC11MfjOCEbzAWJFOrU0ICssua33x9h3Zi1XYVw8QZgzMp6I89cZ9Z/O 7JW54Y241mf4szV+ZQFe0BScy4BijmWhTXKl+fJlzhCeUhN2/SrYX0pJE4/vujdpBN7JZaou WObHpo8UoJP27+A8yH25NGtjrXRn+mYDjrwsZCo5djvLnxQ6fqLD2DRFgin9DImYRePuTrH9 KIfL5GCf7qKmXjXaxT2RflZpVUIX4CFM0Z0+xLGG6mk4buEMnHp+bbePHcKP7GCjA/QF7yBX MFQXz2LMVE5Ua7R2/gjHHqKjHQU3262ag1PLnR/uAVxoRIHJZLqBIphVOw4dzOLyZDvKwwdE 53O6jmjau/uGmz8Q/zniRUEysYKnwQzKTrUntMqwNPGVjza6w/t9KWfn0XwGGKPQZlT8TdEB dWolN+/a7fFe3U+QkST/acdk6KhXoao3yHC6oGkqqY/MH/Z9cTFZA9QpF8Eg3NCj14kQtns3 14dQcBX0PTfwmezZmNvdgxPqX/f8M5qBq3KcRUwEivz3m0lIUKfD8neBKAFeSQmh0jQjJIgE YZyd5jvJOw3RC1KWU+h+wkNkZrc2r/OsMKMC2MeJhUlrf3eAt5UGeNgniAhwsuf3fxnn9i+l DJPGmaf+rGDUFavW0d2qH28ElsfmHYZE5obGtm2LcNY1juqzJ20eWRYLC03HbUYlwewvsFOD WtW0pnHip+g9S23gWSgjCMCDEvwYgvJPXUCPAmf6vI0n2gbI2OmqduJY4iwL91cNTvuPQMS+ SRZkucKy75Efog30iNvWk+URME20UMgLftwlno/WK41HkwDb7bJ0lnXagSJ5WZ43L/T/iF3Z 1lhbsOzKKNG3S0bsTDxbDcbjZFJB+Wu2KwQu0yoZ1fvK45ttJIbuzmeCqN0GsC0AQ1Lc/ymk 9bXb9y56rZPJRzO8MVYCBU8zMS5ZyyBVputhazBOAwfVsg1SCGe9yI5qfFsropDAmKohDqNV yW7i1a+LPEUkK4pM8nIrN1JX4Tbk42rGlm9qeFcYbbDQ2xbeFN/FagKBaGAc1gYbnAHa9Vtw pw5tGDgvSeeCX50h3BpDcTGNMxz0+3BcepRB+WEeFG89amKU2Bj6uj7sm0lir2Q1KAGjQlrJ wAc1cRYMRFgiQji4Ny0jHacN2Jnn4Y X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="40706608" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jPBM5Tc+T0dH8I+EGBmklATit0fKTH31R+ewPuNlWOHRYmBThTs4VlNtg1/tE0fjbqy1ZkX4aNcOMw0orRTE7QF/LYpmnIl/75YWCNVhARo5eZ0PKQncjk9Mfp+SzSPAPeaNR7c0/CFPRa97ht3Y5TOQ3Zv4GeRIpKr207VKpS5/DvppVu1yudmcc2nrnJnUYRLkx6D3uJpiSskyfXDcN6zC5r6mUTQxz9J2oMwZC74ZwuOFlkrSDCR/zc45N4KvJVf7QeHXd3VfRFYVUtFrjZ+vDh2zLixGYwLI4M2eKkqNzYv0pUvmpxRbPNZXfoGBjc/oXrlQw3cXAIC8GwXqqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=udhhZcGEPQ7SLgOVIOZqqyiA5alT0Gfr+eK9vE2UNaM=; b=KSXejOBa0XbQQKU0Q4R/IpPjyUTR9Tzq4GuAYG498djAjnGYk3DHML+3hI23FAwvHiPJTM5jwsa7drtm55Tqi4LsYVuBFtZoz8mC7HECFIhkmnI83LOszwXdush7WWPMFAzcjBt8TRYIBSF0siaAmnWUSUdCfDtFihNk2YBLCFuEIGYd79ZDC68pKiMXlSDeWW8K8dAJazpsI3SJPQCsJP8CAeHAYPXI/L+ylBDTXT75v8Dh90KQMT1BJaK4r1Dc7N7Aq+v5rRPkL9abWlw75ChmQ8Y4yR6z8ItC4Ue1ID5HcXwtTTPLFv3Dw9+l6+rxxZBZ2pnnAEmlVy98xmdDIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=udhhZcGEPQ7SLgOVIOZqqyiA5alT0Gfr+eK9vE2UNaM=; b=VAy61kT7OJriddVvmdS5ToGf4dhI7gIkehXRPILs3qBJWk2sHJjxMewWEI3orbDZKyMbdMWac+RvqvLRIgNCBp7hCFMMWBiZ+sgff8MxJOwwTHu9oqTl5EvUxKtNPoibkkwCv954qu896qrGK3n3CagrFblbcOd3UCV4F6lY+YM= To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <46d83c92-0b06-fc09-4832-7a7d7935d5c2@suse.com> From: Andrew Cooper Subject: Re: [PATCH 5/5] x86: don't build unused entry code when !PV32 Message-ID: Date: Thu, 1 Apr 2021 15:31:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0146.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::7) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6782c09e-7f39-4750-d70a-08d8f51adf53 X-MS-TrafficTypeDiagnostic: BN9PR03MB6028: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S3+8g7kzoaJ07koB5UR2YlUJyntasq+eyz+Jfrsgx8ZrCAjP+i7vzs1pRPJBmPyMikBm68dt1nXyGfi4tE8d4KKhfqnJWW/gxF9+mJeFqBhGxlJ+lhZT4NF5SDbqt7upYtGyUonbc4ride88t1CG8gu/3KD10fV8tGec02+Vv6jXuHZifTej58cKOMpRAwX2PjXjUHodKdJvQe2vGCC7hdw2dn4f0EMjmdnkh1stZoAuZGRi53HwAxnc8laE38CjCMNP/yf2ooG86o7m2+/0zlibLbMfkl9Mp1Ue+cyInXKN4mcFUe7CurS2cHkplyaSCivLzXn2NhQV13Gtq6PP2E4kyxLQAYI4axW3IhEYuA8JOx0GvA3ooHrGGgr6rl0jNUY/3ELic0HRuyqQC5rjVoxECg7W9qiEefXxm3Xw3eYNf0Q9UIkJ/LMYeIs9tpIuvodU5AdvXXJohhN2WkDDevDayBdMQn3000BbIkDfheMjdZXEDBAW0GPvDTHJBJv4MGJHgQwSNz1DEnDV6ZszU+fkt51oJtqxrDHSbBMSQRQ+Q+9IITUyiNumNdSk+x1U5oJnV/7401JF2o8Bznh8mSJRKSqyH5772VPxaDtNJI/DivOBkyrTl7zYxF4jc2amwlbjM49GxdQwi1QLi8znZEPGLFAhrxj/FoiroWtpUdX2NmUwMHMIDNOCEEYp//DZzg+N2N/rvM3MK030tRbPJPysptcUPG1zwm68HC0DOic= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(346002)(39860400002)(366004)(376002)(396003)(31696002)(6666004)(38100700001)(54906003)(110136005)(16576012)(86362001)(316002)(16526019)(186003)(36756003)(5660300002)(66476007)(53546011)(66946007)(26005)(66556008)(4326008)(8676002)(8936002)(31686004)(107886003)(2906002)(956004)(2616005)(478600001)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?b29nODBFdDNwa1pONDlxeTdTOS81MXRGcExxd2dhUzRHbUVIajQwQXJldTQz?= =?utf-8?B?VGJrUHFWMkIyY3VLM0M2QS9wZStrdUVOaEY5TFdJYWZXY3NJOEF6U0ZQWUxY?= =?utf-8?B?MTVXWHZVUzVlQ3AyaUphL3l1QVR3VkJWdXlHbTZ6a0NaUEZXUWszRENpbG54?= =?utf-8?B?WVJnUngzYUpTbmdmbFZrajFvQnBNNXQwYjZ0aWsydHZwd2pSdDY4R1VvWEpH?= =?utf-8?B?R1BuS0I4SitsMzNhc1RRUlZOZFYwUXJEQlhmUGNER1JrZ2hRU3V1VHhyR2xl?= =?utf-8?B?N3NjcUZoZmJzYVh2QU5vcGczUVJvanBHTmtTSUl4Yk1JRm5QRzBlUElzWlE1?= =?utf-8?B?eWl4WDlydVJEVHBOM1I3RUc0ZVcvK0dMekRXQ0o1Q0kxd1BJdGljaCtJZ2ZP?= =?utf-8?B?TDE0TWFFTFZUVVFtWDlOdWw3ZndNdzQzZnVzbEltOVR6YWZlcVZXSGUyeW5R?= =?utf-8?B?TjM1VHZXOWZwQVBDSVdjK2FVVDBtU2dtT0s1bnRXMHRrTC9PbGxiRVdDMmJL?= =?utf-8?B?cFNGSVBMc2FONUJ1N1VPZTVEYm5sZThPTi83RktPMXVvSy9OSjNscEJsRTVW?= =?utf-8?B?c3REOXJQcEZ3U3NBb3BvSXVtbUZHRGdKaVdMMjQ1RTc4aUpaWkM4R0YrZWtx?= =?utf-8?B?ZUlWN3hnZjR5KzZ4ZGtsc0FVVFJvVGFzSWwzZjEwdllObGJSUVVaL2JIcGRo?= =?utf-8?B?bXI2S2dtdTNranhzUUxwSWNoQ0RTN0YydWdJeGo2NVNvQ1h1Q0hqcDR5cUY5?= =?utf-8?B?dGtpcDUxSkpQVW9IWlEwa0dDam53L2NFYTJSKzlIdnorUU9kUHJVSFVRZVF0?= =?utf-8?B?VGttVGRpVy8wQm1mREd4aTRGTTJHK05hWXRWSWtLdGdGM1p5OGE4ajZRalF0?= =?utf-8?B?REp3ZTk3M0NSZFBtRmNaSFM0NmJVYzBpYkZSczB3Q1dkT2Y4dVk5TEZmOVEv?= =?utf-8?B?Y3c0eEc5S1ZISFplT3lkSjM4US9nNXdFeTRJTE15dlpXcXY4SXhOSWp6WjRa?= =?utf-8?B?aGN3REpxVXZYM0RYR25vbmVoUE5qNkNpaG54RVgzQ2R0bUtkS2pJZ0JZM3Bu?= =?utf-8?B?MFlSa2d2bkpvUEZtd0VYV0t2M0dDaXhiQWZGNmxzczByaUh1Y3N1ZXBKUU9m?= =?utf-8?B?TjF1d2NnSU01ZlZiS1g0SkUrcml4UU9manB3UmNVbW1DRmk1V2RQeXZoSlE1?= =?utf-8?B?VFhoNlZVcER1emJES0s5Um92ZUgzMlVMejR2MWd3RmNMSHNiN1ZxM255NGJz?= =?utf-8?B?NHhrelF5ME1sRVZxZHY4Z0FWRlhST0tUSmlyQVJhNFJVTGRUVUpGS29uRGs2?= =?utf-8?B?MU1sQ1o4QW9ZL1FEZDhUdWlZUjVSOTlqOHRJMnB6WmQ4aGZmVVdhYmluWmQy?= =?utf-8?B?ZEtBclRHcjlGNUNidmEvcmpWUHIrbUdNMUhKUFdYOHd4b09Kb0tCUDV5YWk5?= =?utf-8?B?MXVlcVgvc0g5bHU0V1FHYzRZS1BzU1FoendoR1dNRGRTNHBQczFINFY3RVRJ?= =?utf-8?B?NC9JZThTanJpNXVaV1FsWlMzK2pnTDNPOWI0VG54eUJqWUhqN0RVcXhidmF0?= =?utf-8?B?aUcwQWVDbHRLYW1TQnpkMldncVdsMHJCSE5yWklGVFlPdEVLOE1jZEZDNUVi?= =?utf-8?B?YXUzcGdNZ1pIQ21Qd1o1V0hGbDg0dlQ4cEwvWkdKNnNsVTVINDJ0TWZVUmRK?= =?utf-8?B?SVlKbEZReDV4ejNGOHFxNnN4eXVET2Yvc2VhNjFLdkh6Vnc0S0drTTNWVm8z?= =?utf-8?Q?3e2t2Jt3/I1QWc5256afKE/5h4znDSyHzNtPL5c?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6782c09e-7f39-4750-d70a-08d8f51adf53 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 14:31:43.9052 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MlFm3YKNS0TxFTRcjkM6dZlzCF2z/veoUOzf0EcamD53ZzNrNTZxvpdwtC3Vm1JOt73wWghzyCbUOMkSVeKJ1w5H9BCZ5WjeBSsAQKUN50Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6028 X-OriginatorOrg: citrix.com On 25/11/2020 08:51, Jan Beulich wrote: > Except for the initial part of cstar_enter compat/entry.S is all dead > code in this case. Further, along the lines of the PV conditionals we > already have in entry.S, make code PV32-conditional there too (to a > fair part because this code actually references compat/entry.S). > > Signed-off-by: Jan Beulich > --- > TBD: I'm on the fence of whether (in a separate patch) to also make > conditional struct pv_domain's is_32bit field. > > --- a/xen/arch/x86/x86_64/asm-offsets.c > +++ b/xen/arch/x86/x86_64/asm-offsets.c > @@ -9,7 +9,7 @@ > #include > #endif > #include > -#ifdef CONFIG_PV > +#ifdef CONFIG_PV32 > #include > #endif > #include > @@ -102,19 +102,21 @@ void __dummy__(void) > BLANK(); > #endif > =20 > -#ifdef CONFIG_PV > +#ifdef CONFIG_PV32 > OFFSET(DOMAIN_is_32bit_pv, struct domain, arch.pv.is_32bit); Even if PV32 is compiled out, the is_32bit field still exists, and is still necessary for crash analysis.=C2=A0 XCA parses this offset informatio= n as part of dissecting /proc/vmcore. It's one single bool in a fixed size allocation which we've got plenty of room in.=C2=A0 It can and should stay to avoid impacting the existing diagnostic tools. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 01 14:37:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 14:37:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104557.200112 (Exim 4.92) (envelope-from ) id 1lRySF-0005Uo-CC; Thu, 01 Apr 2021 14:37:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104557.200112; Thu, 01 Apr 2021 14:37:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRySF-0005Uh-8x; Thu, 01 Apr 2021 14:37:51 +0000 Received: by outflank-mailman (input) for mailman id 104557; Thu, 01 Apr 2021 14:37:50 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRySE-0005Uc-BS for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 14:37:50 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e281673a-7101-4cf3-854e-da29a638444f; Thu, 01 Apr 2021 14:37:49 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 63CB9B270; Thu, 1 Apr 2021 14:37:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e281673a-7101-4cf3-854e-da29a638444f X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617287868; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sSntaQihOmKqz4Namw9j0NVOsW9jyy3UTXyERn521pU=; b=QBirR6L3b4FkkZWtnd9p6sYpq54TR10QYxuBVXvWiJQ/PBLNP7KJ0//RxNDk6WpkYHConO YOciCzF0wpBUtPiuhNtqkwbvu2pUtZAj6IFJToCYjZO3uTxMQOUYp6tMBeaRr45wAieA8r WkPniQ6z8s4YkzjD3ClKq09kcRlQ6es= Subject: Re: [PATCH 5/5] x86: don't build unused entry code when !PV32 To: Andrew Cooper Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <46d83c92-0b06-fc09-4832-7a7d7935d5c2@suse.com> From: Jan Beulich Message-ID: Date: Thu, 1 Apr 2021 16:37:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 01.04.2021 16:31, Andrew Cooper wrote: > On 25/11/2020 08:51, Jan Beulich wrote: >> @@ -102,19 +102,21 @@ void __dummy__(void) >> BLANK(); >> #endif >> >> -#ifdef CONFIG_PV >> +#ifdef CONFIG_PV32 >> OFFSET(DOMAIN_is_32bit_pv, struct domain, arch.pv.is_32bit); > > Even if PV32 is compiled out, the is_32bit field still exists, and is > still necessary for crash analysis.  XCA parses this offset information > as part of dissecting /proc/vmcore. > > It's one single bool in a fixed size allocation which we've got plenty > of room in.  It can and should stay to avoid impacting the existing > diagnostic tools. I'm afraid I don't understand at all: I'm not removing the field. All I'm removing is the entry for it in asm-offsets.h. I'm also unaware that the offset information gets added anywhere in the binary, except encoded in instructions. If a tool needs to know the offset, it ought to parse debug info? Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 01 14:41:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 14:41:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104561.200127 (Exim 4.92) (envelope-from ) id 1lRyW4-0006Nk-Ug; Thu, 01 Apr 2021 14:41:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104561.200127; Thu, 01 Apr 2021 14:41:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRyW4-0006Nd-RZ; Thu, 01 Apr 2021 14:41:48 +0000 Received: by outflank-mailman (input) for mailman id 104561; Thu, 01 Apr 2021 14:41:47 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRyW3-0006NY-D2 for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 14:41:47 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f39dbf3d-bdac-4c02-a137-b50b724c5aea; Thu, 01 Apr 2021 14:41:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f39dbf3d-bdac-4c02-a137-b50b724c5aea DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617288106; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=/X2Hzn0CPcdcMW36/7RyKPJCS9nBRAhgqyqiVCc7d1U=; b=bmNIAMO/fG4bV7y/OUnnSgr5eEFmcqZMNlv6LK4MdmvwGY1oM/Lh630C d+qKqXnsgAJQJ2mycdbMpaycSV4IbqrruGbXHUkpUk+EuncdrJrEKj7lh FCV0rVDbWWyu4c/iKf6B5yhm760z2/PSaGOFBXwuAOz2lm/lP1MpK7+4g Y=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: OmOanxswyiBeYzkZgXhdPixdxdUIhuiYcDszPZBaca1CgrtMsmGNnE5qxpxibWyVLl7xEiw+zN tjgjFSMk344gEVQlZzx/yvZGFL+SjSrc5RM8yM8ykIA/7LSMQOnKW8imxg8pXjacw/hp58Lv9l PjOyPIZmcI88aL7L46ZIen2P9Q5JULXMtz7VMUJ4MDOs7Ye71tkI4ErZ/shEPfCwza9h0Nndjp sU6CcGNpopRdRdq6FcY/MgCKnlMly50pn7NgW7P6GT+5qwLbrF/1fa1JshOt1HgV3LHNZ/pHx7 N4M= X-SBRS: 5.2 X-MesageID: 41083627 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Hmhh/qkRISdQzE4Hz/+EPcz1h+rpDfOcj2dD5ilNYBxZY6Wkvu iUtrAyyQL0hDENWHsphNCHP+26TWnB8INuiLN9AZ6LZyOjnGezNolt4c/ZwzPmEzDj7eI178 1dWoBEIpnLAVB+5PyQ3CCRGdwt2cTC1aiui/vXwXsFd3ATV4hL6QBlBgGHVmh/QwdbDZQ0fa DsnfZvjTymZHgRc4CHHXEDRefOvJnmk5jhbB4ACXccmUOzpBmv76P3FAXd4wcGX1p0sPwf2E Xmsyi83KWstPmn1gTRvlW+0716kMbso+EzYPCkpdMSLlzX6zqARIMkYLGauSBwnefH0idSrP DpgzMNe/t+8GnQeGbdm2qh5yDF3Cw143HvjX+06EGTxvDRfz4xB8pfiY8xSHKwhCQdlepx36 5R02WSu4A/N2KnoA3G+9PKWxt2/3DEwkYKrO8Jg3RTFasYZbNBxLZvmX99LZYaECr2rL0gCe llZfushsp+TFXyVRDkl1gq5ObpcmU4Hx+ATERHkNeSySJqkHdwyFZd7NADn18bnahNBKVs1q DhCOBFhbtORsgZYeZWH+EaW/a6DWTLXFblLH+SG1L6D6sKUki95aLf0fEQ3qWHaZYIxJw9lN DqS1VDr1M/fEroFImo0IBU9AvOBEGwRy7kxM0bx5URgMy8eJPbdQm4DHw+mcqppPsSRufBXe yoBZ5QC/j/aWT0H4JE2BD/RolSJXESXNZ9gKd5Z3u+5ubwbqH6vO3Sd/jeYJD3Fyw/Z2/5Cn wfGDj/Tf8wrHyDazvdulz8Snntckvw8dZbC67B5dUez4ALK8lJuggRglKp+9GTJVR5w+kLVX o7BImivrKwpGGw82qNxX5uIABhAkFc56ilVWhLqw8MO0b9aq0CpN2bZGBX0BK8V19CZvKTND Qai0V8+KqxIZDV7zslEcibPmWTiGZWuGiHVI4GmqqI5d7sf5QxCppOYt00KSz7UzhO3Sp6om ZKbwEJAnLFHjT1kKO/kdg/H+fEbeRxhw+tPO9ZoX/Srl+nuMkqX3cXNgTeFvK/sEILfX50jk c027IDiLCA8AzfU1cXsaAdChlwT0i5RJhBFx+IYY1InKuDQnAMcU66wRqAix8yfWL28V41nW KJF1zZRdjCHkddtndE0qzj7VNzcSGHc1htb21h2LcNaVjuqzJ91/SGabG01HbUYlwewvsFOD WAejcKJBhyrurHoiK9iXKHFX88wI8pMfGYBLM/c6vL0nfFEvz9qYgWW/tV9o1iLtbgr6sCVv +eYRacKHf9B/ky0wKY4nYjNy8ckghSrdr4nBnk5nO/xngxHL7bJ0lnXagSJ5WE9Hf/Lsz4o6 lRnJYwp6+9I2/xYtmJxeXeaCNCMArapSqzQ/szoZ5ZsKouvNJIbtDmeCqN0GsC0AQ1Lc/ymk 9bWqh97bzbMoJkfsAZeUtijy8UvcXKKFFuvh39A+c4c11okmTSOMmR5aHU7bUoGU+MqWLLSB Gi2jwY++2AWSSN1bQXUf1tZWtXbVUx83Rk8qeJcZbKBACjauFE+x67PxaGAc5gYbnAHa9VqB Bwp8yMlauQcSHz3QjLpzt1Iq5U6Q+cMLGPKRPJHfQN6sCwPFSHn7Cj78GyhirmUDfTUTVnua RVMUgLKtlZgjYsjIcrwjG/R6z+rEUiiUZf61hc5y7Q85nj5nzaE0FAORDYhZsTXSA7CAn2sf j4 X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="41083627" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Onzlnr8I7O9M67fvOGY/bKshC+JpdakDZUfirwu0JVtKy3YgMeWvFADVND25oUF7aWu6HRVNejNnGAig8rVmP0aHp8O2p4Ml1ZK+mU70nXt/2VXILA6Tg5IDxHDRWfG3wVWCYJcFv+sACRwzYaarQNJ9FuxHpJGi7tvuq+720RIcFjfFdCEaAVmbe1fYwJtYbopPPtY+TDitXHl2+hwV/sOugz+Cvu9pYgTwuJxoid0FXdPfxLt7gL8jmSm3vxzgE7w0m1j8DwqP3airddzKTc0DcKH3PQWmrx6ZVgCC/pFn2JOUwW5qr5R26gUc5o79issRUDlz3JOXx4Ik/bTuTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WIBgrf8rWSxNvI4UbkFBbnOvBhTRTt+1mPDmdjgQG8U=; b=Re0IFBc9MLO39ckJWRsSDgVMVKJpYryrLKgBRZW2wgcw210P+TnVgnNoG3BRCe+fd/0V8P+YcjI6LIpV7Wg91KDVItjzst/BlrBqg4ZWkahJxEQOMTlkFt8yyoXGBTaDYWAzO+rMuDAdPFvldOui/K2MnToGArxu0Om4laspWKGKWXiB+/47ozk446cNiYe2jHq5bfL0Rmowle6GK7uEB/HbPmGitizOce0K2qVjcIetBBrch6EqeIX4EapUIWM/m+DCSqlwHEGmxMg4uq5ZoGukL4QZ+Vo7BXFh6SuBtq/r3VYhxu8JSyV1JmcZmwTzu9tBRJlaNlD8SkU8A5lu+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WIBgrf8rWSxNvI4UbkFBbnOvBhTRTt+1mPDmdjgQG8U=; b=rddeDgrEBwWuNC/JbI6Q84qToonkpSAWgMOCvkEzcSp/WHIIVGt7tW7/NOt4rWIbxxZ/yUKa79MD0xs4wLOPtyGLrYQ8rBLaT5itdWCjYdUf9O6ppzPpuZAN7wFuCK3Q1zfxOyxKMcmIJDsuvJvELcbE0LUokMckbokeWOFvJug= Date: Thu, 1 Apr 2021 16:41:36 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper CC: , Paul Durrant , Wei Liu , Jan Beulich Subject: Re: [PATCH] x86/viridian: EOI MSR should always happen in affected vCPU context Message-ID: References: <20210401102252.95196-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: MR2P264CA0019.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:1::31) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3c3f9391-b398-4d43-2f60-08d8f51c43e3 X-MS-TrafficTypeDiagnostic: DM6PR03MB4140: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9zIppC7hW8avchGJWVOpPbHjSG7FEC6OwmJTsAaS78cFo/G/rOuUNMW1q6oQtSlCwEFmuiMQxjTomqlX+xxCJheiDl86+kFLQSP0WMNXqN17ZwSLrZFTrH4hosOdlJglbClOT8RI7Yt9AWJL3LLS2f8mKRPyz2ZmdozrrHej7UdHuQuk+fEnPg+mv5ReW70AlZbHw/mjkk+U35ZeWxtYlewHkEGmpjKwhxiMV2z8J+WP4x0lh7OU4LvieZK7TZj98m9IuDtiPyp5UVbOUMqBbmoVoSJGZaWBBCg5dEvPCpOyqR7SoVqPCCYsRhYBoPi/HAI5nF3raR46ujXFQKcrI6qpP2RH11SWksgVVmSaZfVT8av99BGeQ4um5sAK4DUqT8sJt3daalLNHNi3qs7mXJL07PkdvbhBWZedx5iqRd0iAJVfXeBTOZyfQ6Oha3tD6Zm/zBbNcTLT9ClqQR+Tws8ogE+3PKt2ZCr5hCwfGP/QOe4Plkv4iF3EprkphdTTZZLTX9h6jipDPpxqdwjzq8Bp5Db6ZR3To4ULIDJVGP0RxGyIFZ7KK3iSrdzsBnEIs7aqo8A+0Ye99MDlU/cTZdeKUyMqIey7LJb1NuJx/0ynMe/XQVlTu/YwWdZaLTzYQzGGyzVbGybiBCnnsCJyx+OWGvn1W7chQ8EEP10+rkQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(396003)(376002)(346002)(136003)(366004)(39860400002)(6636002)(8936002)(16526019)(86362001)(83380400001)(54906003)(66476007)(66946007)(478600001)(2906002)(8676002)(6486002)(53546011)(6666004)(6496006)(4326008)(33716001)(5660300002)(85182001)(26005)(956004)(9686003)(186003)(38100700001)(66556008)(6862004)(316002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?N0RQNEFlczFUc1N4a1puY1FNaXoyTWpkSENtZlZ2NldFYytQVnVFa2hEYVh6?= =?utf-8?B?dGhGcDhnUmN3Q3B1V3AzUnB2TVNyejFkSSs5YnVmMGt4SWYwV2VENFBLbi91?= =?utf-8?B?eEk0YXN6SWY5NjZFSUwyUEFvdWVEWXROZFZLMTdsN1JZakJMTGk0N0VPUGR5?= =?utf-8?B?UDNZdWVpTmE5emZJYXVrMnRtWDU0Vit5WlBXemZiN214MXpSZFdtZmZiUytq?= =?utf-8?B?OHNCYVRLZkk2eHpzeG9kTXFkUkt0bjlDQ3YxL1drSkxURFBJOFYyUmFXTk9G?= =?utf-8?B?Z21lcDVIVGtENVowS2kvOVRjS25ZcG1YKzB4eVlsOFlPbnh2Zzh1bFB4cXMz?= =?utf-8?B?c0ozZjBCSFY4V1cvS1lIWXcycWV6dWZTZ0tNK0U2aHE3bmpPUzFsNUJkUzJB?= =?utf-8?B?UGtJR283MTllcmhNTWdVL1JzSmpFUFlYRWs4TTlNeW1RaHVUdnVLWFBYZ0tB?= =?utf-8?B?cXNFRyt6N2d3M3VhN3l5WDBHSkV3eWhkV0h6cEZ6ZWh1ZEtIa2crU3JFck5p?= =?utf-8?B?ZnBESVU2dVhieGt6cTJnVmNSTzI4UG8vWnF2MndIQnA0cVlYYjZ4MnlsR2tH?= =?utf-8?B?bTZtUDZIL3dDSk5JWXNNOFk1dXNvQ0QxNC84TlVWZHZDVjI1WUV4S2xUc0pu?= =?utf-8?B?dmE3dVhMOUZIRXY5dHRBVlFVbzIwOGNOK24xMjZXWnJ1bFhqdmNmUjZ4WG5u?= =?utf-8?B?ZFRZNFo4MXNBWnpFbSs5bnhCUFZmVHJWdHUxdENrREdwSURjQVZNamY1anpk?= =?utf-8?B?MTdSV09mRjgwMnJidjlhU0F3a25WOWUyNldEbnAyN01DRmhVQmZaRkR3U0lW?= =?utf-8?B?akxHQ1VIeUJCMm9oanJ1bVBmb2dHbzlNMDVsbzFqL250SmdrMmRWN3VRdUlp?= =?utf-8?B?c05xY0VxdDg0WnBzOTd2MmoxaElrUDUwOVVadlVuUXN4RXc1alBHSzNsRktU?= =?utf-8?B?VTV2NUhPQ2JlTDkvTDN6KzJZeURhcjB3TG1vYm5KeXhPd0hpTjJ6UGtkb283?= =?utf-8?B?cndCNGhnVTlEVWU2N1doVzBkakhuMTlTcWZZMmRWRDM1cEF0L0VkcDA1c1hK?= =?utf-8?B?cnBKTWw4WlRlOVJnTDc1VkI0MDVHbzU0RW51d0g1Q0JPV1FpaU5nNm52TERq?= =?utf-8?B?ZE44SjJvTHJlM1luT01LcFhMZjgvUkVwNlU3VWpDNEsrT3I1aEtkb2Fzd2xQ?= =?utf-8?B?ZURvLy9pbmZncjkwZ3Npd2k0THRGalBUZThUTk9UeUx5QUJZZVp6MEd0UFpY?= =?utf-8?B?aXZQRis1RCtlMitpbEphVThwaUJhZjRIUnp5WkZJVlVaNEc3T3ZCZGRrTGh1?= =?utf-8?B?S3V6OWZUOEpGY2N3UnRzWGsrUFpMZ2lzb1hKVktzUDNBajNNbGZEQmVnWnZI?= =?utf-8?B?dFQ0NFFFeGNWOEJVSmJERnhFSktDTXYxWTRwY21MbTN4elNUakZoQ1BZM2RK?= =?utf-8?B?OTZTUDVYd1NZazhzczJqZ0lDQ0xxbENQU3NSVnRIcDVrb01Jd3RZb2dlU0JE?= =?utf-8?B?TjI0SHE2UVdRekt5aE9RNGd4Qnl0K2s5VS9oSThGWXdLWWJ3T09rZUYvTlpw?= =?utf-8?B?d3d2NmpteHZqeVhxZWYvWHMvYUdFZzI1czVYSXdVSDd6SXlCUXBPTllIRk15?= =?utf-8?B?ZlZwRnhRQ1BpMWZWdG1MYStKQnUySm8xZTFyNFZYZVEwZUdqWkFZNmVLcCt1?= =?utf-8?B?YU9FUnV5dURCcVkwMy9GZ3lRR3lUMXcyZlFUamN4TkQ1K3RlYlB1U1EyUTJG?= =?utf-8?B?VEt1cXdrVTgvS1M3emxyeG9Ob1BpQmEva0l5Sk1KODRiWHkwQjdaSGVXdHRv?= =?utf-8?B?ekNWSHU3dnlLbWZkUVc4UT09?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3c3f9391-b398-4d43-2f60-08d8f51c43e3 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 14:41:42.1728 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KZ1P7iL0e1pcEaPOlSW8onqgI87V1Fvi2LbHHFUSCHgNgu+TyI3GaapdPYMDd8v367e0P3HHqqJ3dx4hQJ+65A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4140 X-OriginatorOrg: citrix.com On Thu, Apr 01, 2021 at 01:44:59PM +0100, Andrew Cooper wrote: > On 01/04/2021 11:22, Roger Pau Monne wrote: > > The HV_X64_MSR_EOI wrmsr should always happen with the target vCPU > > as current, as there's no support for EOI'ing interrupts on a remote > > vCPU. > > > > While there also turn the unconditional assert at the top of the > > function into an error on non-debug builds. > > > > No functional change intended. > > > > Requested-by: Jan Beulich > > Signed-off-by: Roger Pau Monné > > --- > > xen/arch/x86/hvm/viridian/synic.c | 11 ++++++++++- > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/xen/arch/x86/hvm/viridian/synic.c b/xen/arch/x86/hvm/viridian/synic.c > > index 22e2df27e5d..e18538c60a6 100644 > > --- a/xen/arch/x86/hvm/viridian/synic.c > > +++ b/xen/arch/x86/hvm/viridian/synic.c > > @@ -79,11 +79,20 @@ int viridian_synic_wrmsr(struct vcpu *v, uint32_t idx, uint64_t val) > > struct viridian_vcpu *vv = v->arch.hvm.viridian; > > struct domain *d = v->domain; > > > > - ASSERT(v == current || !v->is_running); > > + if ( v != current && v->is_running ) > > + { > > + ASSERT_UNREACHABLE(); > > + return X86EMUL_EXCEPTION; > > + } > > The original ASSERT() was correct - both of these are easily reachable > in control domain context. I'm confused, if it's reachable from control domain context then it shouldn't be an assert? > If you want EOI to not be used, you need to raise #GP from it, but that > in principle breaks introspection which really does write MSRs on the > guests behalf. Looking at hvm_msr_write_intercept I see that indeed introspection can monitor an MSR and defer a write, but AFAICT the postponed write will be performed in guest vcpu context as part of hvm_vm_event_do_resume? Also AFAICT there's no way for a control domain to write to this MSR ATM, as the allowed list in hvm_load_cpu_msrs doesn't contain HV_X64_MSR_EOI. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Apr 01 14:45:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 14:45:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104566.200139 (Exim 4.92) (envelope-from ) id 1lRyZg-0006YV-Ix; Thu, 01 Apr 2021 14:45:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104566.200139; Thu, 01 Apr 2021 14:45:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRyZg-0006YO-FP; Thu, 01 Apr 2021 14:45:32 +0000 Received: by outflank-mailman (input) for mailman id 104566; Thu, 01 Apr 2021 14:45:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRyZf-0006YJ-78 for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 14:45:31 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9de1d262-dbe7-48b7-a6b9-abc347d03faf; Thu, 01 Apr 2021 14:45:30 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9de1d262-dbe7-48b7-a6b9-abc347d03faf DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617288330; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=+SMCs+kCKLmK4bYTHtUZXrRzZSCtcl8QipRQvnQOyGU=; b=YmXiZRu2fK7s4gSFEGHQDwxqZr4iaaUnw3zTQubYugKmsDKPlLHcze/S a+sQxSBBDLnjtA2PtvaL6hfoKEj/T/jy9OjJVT0M92lXDv3TF5IIU4LWI yCjo5tqWjDRpc6mo8Op6Jn6P3NJs/I7+Qk45xIC+BbWDIhTgk7MK0KXtX Q=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: uuWrwnbwGXfdGk8aKpRbwoiGe2/X46ihQTz+w1ZsoXp75cdAfpNd36WwGhbmoyWA3pptt8jZ9y cn61V0LhG2qa0w1pIHZDgQFDmf+0n6vOCX1UiuKc3+pORo9ZVTqd9LUg3sFusaO81ookd/fbd6 vBh2XlDJwuOKKfbHIogTTMPWbzpChlnR+HEKISeWUreuRPc1MUSGuBnZ2WZG6mHcGHtOLLS9Cy QPEr8jbBOjRGMuC2g8a2jnp8S/ndDKs8+rkqlt0JZScyvhjkm0tHbFVHPa+cjo4MY+5yIWG5Wp wVA= X-SBRS: 5.2 X-MesageID: 41083903 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:IP1c4qMh5oL3w8BcT8P155DYdL4zR+YMi2QD/UZ3VBBTb4ikh9 mj9c5rtyPcpT4NVBgb9eyoF7KHRRrnm6Jdxak0EfOcUBL9uG2uRbsSjrfK5zH7ASXx+qp8+M 5bAs1DIeb9B1R7ksr2iTPQe71LreWvy6ywgPeb8nEFd2FXQppt8htjDUKjGlB2LTM2YaYRLo aW5cZMulObGEg/U8LTPBY4dtmGmvmOvKijWAUBCgIs9U2wgSjA0s+cLzGomio7Fxt0hYwv63 TBjmXCl8OemsD+9zuZ/1WW045bg5/I08JZAtOBh4wuJjLghh3AXvUYZ5Sy+A0Q5MmUrGoxnM KJiBInNcZ+5jfqcma5rQCF4Xia7B8er0LHjWW+vEGmm+jFfVsBerZ8rLMcTz/w0WZlmNlg2q NG0lm4mvNsfGr9tRW42vzhbT0vrUavvX8++NRj9UB3YM8iTJdqgcgh8FhOEJEGdRiKlbwaLA == X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="41083903" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kkDRfJfiVW1EGZ0UDGaH71Bg2DFnQxPf7Vbz9DlcWM2EkfFke50+mRi9NIJnCNzC2/JbGl1B6K167qLZoqGalb6gzp+NQPDF4Py0lX03V2oKaR2xxqHpUfJpDgCo8RF7lWfzTXvXxM5E5b/GQquQDb3ba7K/DeeyWKWysEbsplR7xZlRTD8M36UQcVi2AkN6VNbfk0SiYlbpA/1TQq3YL62+PSNzvWJQSVIBS1UtsluK4s97mPM20nhD8QNHPXkUbF252eXWy+T9XAk7G/uFLd4sYjKzcTAub9oQgmREvVj4Km05RIikURTc3M35tGoTg4Afc1thVjOhbSh2x1cjDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+SMCs+kCKLmK4bYTHtUZXrRzZSCtcl8QipRQvnQOyGU=; b=mYGxnGVDi7Hu/uKgAHWG/H/Ld7lbioOEdsXwWcGYs1WRDKBjon4Vj5APPIuVFUHH4hWWnXjHqFBN2QLaPirGqDu9EruQlrB9f70xjJiu9aoM0h7SOL4SmqBkTBHvzlybLHGf9lzHNQOh0uKqWpnpFZJifyuD0FQxL/QFVW8/GL8DImodFcreu9yai6QKkgdonpytb823UZXuasr5Km7X9sA/wQhlO/oqr7dfChGSGmN3xf2WhliWxndkXgi9WFMxxF+Wgg9xSH7q8JeOzST5EW45obMOc7B4s94td96XaPE7A/2zZyc+/OHTcZvEyt4ynqDsWzTkgmT5aXr0nEKsDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+SMCs+kCKLmK4bYTHtUZXrRzZSCtcl8QipRQvnQOyGU=; b=eqL62Frk9qa1UobjV+7HBVZu9VGITn75zZQrSkIGH726eHzT5ytHJC9heVCLMzIArS1d8MvsnElRUdCziRtpPCTEuXnT03QWPbaX6XFTVxayPbN/1F84Eap/8H7TQ1pE445GrJBRnZNykivm7Ed1UExskm4w22U1wjGZq/ulqMQ= From: George Dunlap To: Andrew Cooper CC: xen-devel , Juergen Gross , Jan Beulich , Ian Jackson Subject: Re: [PATCH for-4.15 6/7] CHANGELOG.md: Various entries, mostly xenstore Thread-Topic: [PATCH for-4.15 6/7] CHANGELOG.md: Various entries, mostly xenstore Thread-Index: AQHXJvxUtSxo6M4mo0iX7TVVNapv+6qfsM2AgAADtYCAAACaAIAACDkA Date: Thu, 1 Apr 2021 14:45:26 +0000 Message-ID: References: <20210401133827.362216-1-george.dunlap@citrix.com> <20210401133827.362216-6-george.dunlap@citrix.com> <97d317fb-16d7-a14e-e74e-62fa83159838@citrix.com> <07553207-90AA-4AD4-A5C2-C8F36411DDCB@citrix.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.20.0.2.21) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e1dd0628-3755-4797-f32c-08d8f51cc9d5 x-ms-traffictypediagnostic: PH0PR03MB5734: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PY3Dpr8cgLQ9YSvNbUlZUxgMv1lyNMW0FohnV9QeTKBtr6HKS9oBaMSiVk+fAvEHWCicTy4nCuB312Dtf9f3SXZpkM0PCVDpo/8QtquFlTbCuZpHtKiazGW47Gk/y/Nm/kywQ5GnrOFQY6P9C74N1Kl0COkp2lIJq/zeDLKHDcvb0fOxa5llcQJXMbk/+fZdgBVYXuMcjF4vU5C+Jp7wa6nwWu9zHfN5YTPGh1BamjjdRNsgxH6jiGQKaRE3mxSxLPww5uBCMOa6iLki54hmJHh9hbmUE2ptCTu1RvsWllkLevKHmgBBrMQLK0LGMlP9302tohESNMOkmmB6PQOcLK+MoQVXHlaZXpqzigPfwx3GWx+gO9hewtydf5iGsytbwRssBAMy0S4Y4E8Xhk0G/bdYAWaSjF3VtwBnOVMWLkRmwYsIQ/HmuDGpPHI+W9aAHwVwu9v5b7K2zO1Wzhzi7NqjmDXLJVYhXhCV0j50kOcU/ezupnLS02i9GmowRtIWPYxC85mQH+S/ezYcfzV5eQmrUKCgJZ0FadKvUmv67VQOgovGHWeK549kSKjMZvhEoa1NxTEyI4XkYgVZGz9cC97pRYOCAqGK/4R/KbGJA6XF4mc1pp+F7m03S8ycIB/OXR83zOOp2poUCPwaRtWyHzLMpgjCPHvYjX3ZVAJKK7tHbjxRgpx05nbQK7IJyycDYNenvR/sbbMW1V7lu+23C75V9C8tQNktekNHab3ctXdcRmIUSsOXIsCs9AHuOA02TQYWznXIM882J6wdIo8OvsjEgqeZ4Nwf/QenzXmg8+4Nmupba3skAIwrxontJiAv x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(366004)(136003)(396003)(39860400002)(376002)(64756008)(6862004)(66946007)(83380400001)(107886003)(66556008)(66446008)(66476007)(4326008)(54906003)(76116006)(6512007)(91956017)(38100700001)(2616005)(86362001)(2906002)(6486002)(33656002)(36756003)(71200400001)(186003)(316002)(37006003)(478600001)(8936002)(53546011)(8676002)(6506007)(966005)(5660300002)(26005)(6636002)(207903002)(219803003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?Si81Sjc2R1JzcGl0YUJpbHhBWnY1ZXhsZllKRWVJbWhkaHBJMU44NC9KTXMv?= =?utf-8?B?WTRnYkJPbHkxYU8vVVc1QmRlRkIwWjMyZHcvVXE5TzF2WHlNeDVmSmpZb3g0?= =?utf-8?B?RW5uWVVEZXBlMWNEdXR6bGhLazF0MzBPSktEREVRNE84SzdSOTd2d1lKUTBj?= =?utf-8?B?MVJJd2ZmZVM1VW5XNGhDcW1tdnVEMEJmbHhKbjZqY1dnYkZJZXgzV0ZVRHRT?= =?utf-8?B?dk5oWmh3T292OEJ5VFZ3bVNqZ0dERUFtSnhVVmx1Yy9Ub0RaL3JsWkIxdEpm?= =?utf-8?B?bTdGdU5RektLNE5ta21RTEx3bkNrZ0hDNXhjYkpZKzdiYWYrNVNSbVZhUlBK?= =?utf-8?B?T1dOME8yN3lUZmQzdDI3a1NwLzJiVzZvNU40MTZTWXZlMDNnZXVhbFcvNGlN?= =?utf-8?B?RWVaMUNsckJ1R21nMzJoZ1VrdlFTaU8wSVMyUk1UdVJVOFBRZFYxeXNlRTR6?= =?utf-8?B?M0dEVk5iZ29jTkN4eEpqVWtBa1Q2WlZNSWJKbzZBU0RiUlZTVE4wWEJkZFIy?= =?utf-8?B?M1RiNlNodEgxNHMyUXIxOS9mYjJhOHMwa2JQM0NtZkdTMDFUY2hSZGV2SWgx?= =?utf-8?B?Y29sZXpHMWhsbFJRSVpyemZnK0lKQjlOOGRWeGdaUjJ5S2FiTXZtNHJNa2w0?= =?utf-8?B?Tm1abEI1WEJJVTA3a2h1LzBUS2ZGV2t1WTliTzJvU1ZXekVuc1QrT292aFFx?= =?utf-8?B?Y2ZPRHArZEo4THVZNGZKVU1HWUZTZjBweHBZUE5XTUl0b25QNURRYnNKaFF3?= =?utf-8?B?YnRvUVUwRHNNd0lJTlM0MTJFd2JOWGYrTEc1RnJDL3JGcmxwUjBoWlBmQlBm?= =?utf-8?B?UXlzYkN4bUpiNHFvNGdHU1BRQXdIdnRHcnhWMTVFajZLNDF3K2RpWldnMzN0?= =?utf-8?B?blFFSndKK0t4SWxhV0JsMnJmc1hxNlM3eHYwbWhqRktFdDQ3NGw5K015YkFD?= =?utf-8?B?c0lHMmp6QVdtcHlPdUZvbEQvaDhqMjBKUUV1Si9EZEZ5RklGekMrNzNjRGJB?= =?utf-8?B?S0xJemFKaVkrSVAzUElBcVZkMzhDWmlHN0FxZmdubmdWcSs2S2RvSXM5T3Z2?= =?utf-8?B?NGZQaytGQUhNQ1VRdlZBWEpXSjdzUnZMM2Y1VTFPaVQzRXlhYlBueDlWc0Nw?= =?utf-8?B?UVdISVJkVkFhVmtENDBwa280ZFcvVUt0aVgyTEI4MEx3U1dZaUd6bmdYMmVS?= =?utf-8?B?TzMybzZ5L3lQNzZNYTZCcG5XZlc3Umg2dmwyWGkvN1hBOStRdGFsOWNrUCtP?= =?utf-8?B?ZitqaVVYWUk3Q212eTYxd3JzNy9CSks4OVpyLzhWcldkZXJDRnRYYXJiOEtn?= =?utf-8?B?RHp3clY0VE5mSWxXUnhIdWhUMHZ2R2NYbHc4UkpZbURqbnowVDBWUFpDSUdF?= =?utf-8?B?WGg0NmVtS2F4NXBxbnE3YUM3c1hkbUxnSGRmZWs2UWtlQVBzZnk0ZVZXL2N1?= =?utf-8?B?T1o4VDRDbFZUU0dYYUFBZ1NBcXF1LzM0dTB3aUhCcVkyeHpPem5JTzZkVmx5?= =?utf-8?B?aHR4T01vZUk4M3crdVdkd1k5TmRDSHdlZzhqL1JEVlI3bWJHYTVrYkJqbHZ2?= =?utf-8?B?VDh2Yi9jNmFXOVcrWTlUcVFmODArNXdtd1pST3VqUzBOc0wxV2lraEhXczJs?= =?utf-8?B?V1BvcTd5VHpRQVBPQjAya25OUnJjUmxER0l6eTd5REl6OEk4N3NCTi9hck5I?= =?utf-8?B?UlhaQ3JWM3pmWkdZT2hJcUMrU3hRWStXMFpkZmRubFRKR0doaStDdEhTL2lJ?= =?utf-8?B?Q1Z6dW03TnZZdUc2L09mY0hVTUVBVkFyZWhkOFRCZUhRSWJHelAvNlJ6emJ4?= =?utf-8?B?d0RKbTVoRTJCV0w5b3NrZz09?= Content-Type: text/plain; charset="utf-8" Content-ID: <94467862BD31964D849F4B0CAEF668BF@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e1dd0628-3755-4797-f32c-08d8f51cc9d5 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2021 14:45:26.6339 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NibM+MqUfHMPYtXG6cMMLYVWsGhf2L38BRlXKSzP1XZJaQB4rkXzw3QbH82kmCPnvWvsBk0q0Es7VEMvOy2pZLH9oun9RPRXpNaxBBa6l8Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5734 X-OriginatorOrg: citrix.com DQoNCj4gT24gQXByIDEsIDIwMjEsIGF0IDM6MTYgUE0sIEFuZHJldyBDb29wZXIgPGFuZHJldy5j b29wZXIzQGNpdHJpeC5jb20+IHdyb3RlOg0KPiANCj4gT24gMDEvMDQvMjAyMSAxNToxMywgR2Vv cmdlIER1bmxhcCB3cm90ZToNCj4+IA0KPj4+IE9uIEFwciAxLCAyMDIxLCBhdCAzOjAwIFBNLCBB bmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPiB3cm90ZToNCj4+PiANCj4+ PiBPbiAwMS8wNC8yMDIxIDE0OjM4LCBHZW9yZ2UgRHVubGFwIHdyb3RlOg0KPj4+PiAuLi5ncm91 cGVkIGJ5IHN1Ym1pdHRlcnMgLyBtYWludGFpbmVycw0KPj4+PiANCj4+Pj4gU2lnbmVkLW9mZi1i eTogR2VvcmdlIER1bmxhcCA8Z2VvcmdlLmR1bmxhcEBjaXRyaXguY29tPg0KPj4+PiAtLS0NCj4+ Pj4gQ0M6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4+Pj4gQ0M6IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4+Pj4gQ0M6IElhbiBKYWNrc29uIDxpYW4uamFja3Nv bkBjaXRyaXguY29tPg0KPj4+PiAtLS0NCj4+Pj4gQ0hBTkdFTE9HLm1kIHwgMyArKysNCj4+Pj4g MSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKQ0KPj4+PiANCj4+Pj4gZGlmZiAtLWdpdCBh L0NIQU5HRUxPRy5tZCBiL0NIQU5HRUxPRy5tZA0KPj4+PiBpbmRleCAyZjI2Y2Q1Yzg3Li45YzI3 MmEwMTEzIDEwMDY0NA0KPj4+PiAtLS0gYS9DSEFOR0VMT0cubWQNCj4+Pj4gKysrIGIvQ0hBTkdF TE9HLm1kDQo+Pj4+IEBAIC0yOCw4ICsyOCwxMSBAQCBUaGUgZm9ybWF0IGlzIGJhc2VkIG9uIFtL ZWVwIGEgQ2hhbmdlbG9nXShodHRwczovL2tlZXBhY2hhbmdlbG9nLmNvbS9lbi8xLjAuMC8pDQo+ Pj4+IC0gRmFjdG9yZWQgb3V0IEhWTS1zcGVjaWZpYyBzaGFkb3cgY29kZSwgaW1wcm92aW5nIGNv ZGUgY2xhcml0eSBhbmQgcmVkdWNpbmcgdGhlIHNpemUgb2YgUFYtb25seSBoeXBlcnZpc29yIGJ1 aWxkcw0KPj4+PiAtIEFkZGVkIFhFTl9TQ1JJUFRfRElSIGNvbmZpZ3VyYXRpb24gb3B0aW9uIHRv IHNwZWNpZnkgbG9jYXRpb24gZm9yIFhlbiBzY3JpcHRzLCByYXRoZXIgdGhhbiBoYXJkLWNvZGlu ZyAvZXRjL3hlbi9zY3JpcHRzDQo+Pj4+IC0geGVubmV0OiBEb2N1bWVudGVkIGEgd2F5IGZvciB0 aGUgYmFja2VuZCAob3IgdG9vbHN0YWNrKSB0byBzcGVjaWZ5IE1UVSB0byB0aGUgZnJvbnRlbmQN Cj4+Pj4gKyAtIEZpeCBwZXJtaXNzaW9ucyBmb3Igd2F0Y2hlcyBvbiBAaW50cm9kdWNlRG9tYWlu IGFuZCBAcmVsZWFzZURvbWFpbjogQnkgZGVmYXVsdCwgb25seSBwcml2aWxlZ2VkIGRvbWFpbnMg Y2FuIHNldCB3YXRjaGVzOyBidXQgc3BlY2lmaWMgZG9tYWlucyBjYW4gYmUgZ2l2ZW4gcGVybWlz c2lvbiBpbiBvcmRlciB0byBhbGxvdyBkaXNhZ2dyZWdhdGlvbi4NCj4+PiBUaGlzIGlzIFhTQS0x MTUsIGFuZCBpc24ndCBzb21ldGhpbmcgbmV3IGluIDQuMTUgdnMgNC4xNC4gIChJIHRoaW5rPykN Cj4+IFhTQS0xMTUgd2VudCBwdWJsaWMgZHVyaW5nIHRoZSA0LjE1IGRldmVsb3BtZW50IHdpbmRv dy4NCj4+IA0KPj4gU28gb24gdGhlIG9uZSBoYW5kLCBpdOKAmXMgY2VydGFpbmx5IGVmZm9ydCB0 aGF0IGhhcHBlbmVkIGR1cmluZyB0aGUgd2luZG93LCB3aGljaCBpdCB3b3VsZCBiZSBnb29kIHRv IGhpZ2hsaWdodC4gICBPbiB0aGUgb3RoZXIgaGFuZCwgaXQgd2FzIGJhY2twb3J0ZWQgdG8gYWxs IHNlY3VyaXR5IHN1cHBvcnRlZCB0cmVlcyAoPyksIHNvIGl04oCZcyBub3Qgc29tZXRoaW5nIHlv dSBuZWVkIHRvIHVwZGF0ZSB0byA0LjE1IHRvIGdldC4NCj4+IA0KPj4gSG9uZXN0bHkgbm90IHN1 cmUgdGhlIGJlc3QgdGhpbmcgdG8gc3VnZ2VzdCBoZXJlLg0KPiANCj4gV2UgZWl0aGVyIHdhbnQg YWxsIFhTQXMgZGlzY3Vzc2VkLCBvciBub25lIG9mIHRoZW0uICBQb3NzaWJseSBhcyBzaW1wbGUN Cj4gYXMgInRoZSBmb2xsb3dpbmcgWFNBcyB7Li4ufSB3aGVyZSBkZXZlbG9wZWQgYW5kIHJlbGVh c2VkIiA/DQoNCkkgZG9u4oCZdCB0aGluayB0aGF04oCZcyB0cnVlLiAgVGhlIHZhc3QgbWFqb3Jp dHkgb2Ygb3VyIFhTQXMgYXJlLCDigJxNYWtlIGl0IHdvcmsgdGhlIHdheSBldmVyeW9uZSBhbHJl YWR5IHRob3VnaHQgaXQgd29ya2Vk4oCdLiAgVGhpcyBpcyBhIHVzZXItdmlzaWJsZSBjaGFuZ2Ug aW4gYmVoYXZpb3IuDQoNCkxpa2UgSSBzYWlkLCBJIGRvIHNlZSB5b3VyIHBvaW50OyBub3Qgc3Vy ZSB3aGF0IEkgdGhpbmsgdGhlIGJlc3QgdGhpbmcgaXMgdG8gZG8uDQoNCj4gSSByZWNhbGwgTGFy cyBtYWtpbmcgdGhpcyBwYXJ0IG9mIHRoZSByZWxlYXNlIG5vdGVzIGluIHRoZSBwYXN0Lg0KDQpM YXJzIGluY2x1ZGVkIGFuIFhTQSByZXBvcnQgb24gdGhlIHhlbnByb2plY3Qub3JnIGRvd25sb2Fk IHBhZ2UgZm9yIHBvaW50IHJlbGVhc2VzLCBub3QgZnVsbCByZWxlYXNlczsgc29tZXRoaW5nIEni gJl2ZSBjYXJyaWVkIG9uIGRvaW5nLiAgZS5nLjoNCg0KaHR0cHM6Ly94ZW5wcm9qZWN0Lm9yZy9k b3dubG9hZHMveGVuLXByb2plY3QtYXJjaGl2ZXMveGVuLXByb2plY3QtNC0xMy1zZXJpZXMveGVu LXByb2plY3QtNC0xMy0zLw0KDQogLUdlb3JnZQ0KDQoNCg== From xen-devel-bounces@lists.xenproject.org Thu Apr 01 14:46:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 14:46:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104569.200151 (Exim 4.92) (envelope-from ) id 1lRyau-0006f6-Tg; Thu, 01 Apr 2021 14:46:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104569.200151; Thu, 01 Apr 2021 14:46:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRyau-0006ez-QV; Thu, 01 Apr 2021 14:46:48 +0000 Received: by outflank-mailman (input) for mailman id 104569; Thu, 01 Apr 2021 14:46:48 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRyau-0006eu-Fs for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 14:46:48 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ffebad7c-9cee-42be-83ee-ac9693c9af7e; Thu, 01 Apr 2021 14:46:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ffebad7c-9cee-42be-83ee-ac9693c9af7e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617288407; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=T/X1/IcRwJR11b65tL6mpaHsmu4HvqDNJBrv71R5WXQ=; b=Ik0UuVo2xKYtP9/oeoi1dHvulmhGYhwqWqiEbhWmucnUokrffmG/Kxlz abgoCUbBV0zgJHsKmtCllQHfgWNXgDFVwOsUJZEsOViw8FjAD3amKOcnV K1V7RxWaSvZdbBd2W4KC1mTOJaCww7jb408K455q0YPlcpja8QZk4C6N3 8=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: ZUb06BzMYwzHpagEqqn7nzPo1bjRxfa7LkP/OPmqxqMJy0y6OkH1BrW6zHlxQPdUjRYQ6DBefm JS/ZC38YuIdRkevtAnBlXwCwptCyFUa66QUyQx6U0RZ3RDVnUqt8mIuk3p5W/LFlTPJYclGXX8 RAK4eIjSg2HHLWNJVPHSyZZ0/Qus735k1lLXhPT66SJtZ9t1nQP5sG3oTlDQjO5H13hxjz5wpH k85WrzP9l2HmZk3yRxQl+4dYsGNDCvS5tJ1jt+eksFyiW35jqIJb/DjZ9bnMEwR/C/RgpPuJ1r PsI= X-SBRS: 5.2 X-MesageID: 40845423 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:9xzeuqtAftW/m4XEB6zo9t3F7skCdIMji2hD6mlwRA09T+Wzkc eykPMHkSLlkTp5YgBDpfmsMLSNKEmxybdb+o8UVI3NYCDDmE+FaL5v9pHjxTqIIVycysd42b 17e6ZzTP3cZGIK6PrS2wWzH9Y+zNTvysnB7o2y815XQRhue+Vc6W5CajqzKUFqWBJAQaMwCZ v03LsimxObZX8VYs6nb0NlY8H/obTw+67OUFo6I1oO0k22ljWk9LTmVyeVxX4lIlRy6IZnzE yAuza83am4r/SnoyWssVP73tBqvJ/I8J9+HsCWzuANMy7rlQqkIL5sXLCPp1kO0ZmSwWdvrf 2Jiy1lA95+8Df7e2e+oxfhnzPt1zsj8BbZuCSlqEqmnOi8fhUGMY56ob9hGyGpl3YIjZVA9I pw8ya8v4dcDB/MpwTRjuK4Li1Cpw6IhVIZvaopg2ZCVJZ2Us4qkaUvuH5wOK0tWB3385omFu 4GNrCg2Mpr X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="40845423" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UB38Yb5agjSFBCQ9Gmsp+da3qJ4QX9Ss1E3QAqaj1x95GcBheDQudcgWqaF8MRP31DlH4In7LKgSqKhYVk5GXUG+rOVPrzf9JauTv/i23v7ogBm/W8evwi6+alE5Cq0j4DRSVyJ8DdFyoJNTH7OnQZ5Gsk5LqUxc3+HxYuv6LlEPUcc8ORZGLPvq3Fa07lgY3jIbNS1ppsU6yZ7qzEOrYTkQvmNeFdSSaqGpETeRQo0Zkt9qhTXbzbK6Ww5ziqgPgG/M3NOt1LCy9N9ZRXDmh72ZPCGXpw/I/Y12eqG+hUWZTouxnh47ETlILkqHk21JXaooXmpMpIXzsMcYbARZpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T/X1/IcRwJR11b65tL6mpaHsmu4HvqDNJBrv71R5WXQ=; b=Id1bXDq3sVNWL5NjWb+fjk9Jgye5bmv/C2NZNBE+ZUFPDvgCorN0EuBLet5bBT69t6xvdugvNkYIwJKLAn4sPViN4BG2cc5dOhjddA8p/dIxlIO+XxtwV6bjfs0stJ6jZ7jHpegdwP/cMa98eIsCFYoEZ5ez8PAxP/ANLOR7WNjv8peZPaZtnP4pzb6bvhQH8Nfe3LvjSesEX3u0abI6f882mCRN5PWTOjqwzw29CLZx/tMQeD7sX2anWYm5Z9lRR+yAUaUE5chh5GJ4YuU/dsTdoSL9kR2B470o2dWnoPyyODzMIkABs2gv0gc1jVtu+KeMS7voEV8p9Wdz3R+v6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T/X1/IcRwJR11b65tL6mpaHsmu4HvqDNJBrv71R5WXQ=; b=EYJnVnGDx36NhFh28hca3vMly03akcHcz6Aq65eXzeXgXTwJMB6bYayk3uMCYJyE2HlhDCM6jSnOh/UUc46pOMqrhNDJzPSbw/OY13zwKwkASWp81D6PWqmQ99ZvWzLKo4NO6djpROUiFQkLkJS/5x1Smz57FAqfqtYd1W3NGZ8= From: George Dunlap To: Jan Beulich CC: Igor Druzhinin , Ian Jackson , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH for-4.15 7/7] CHANGELOG.md: irq-max-guests Thread-Topic: [PATCH for-4.15 7/7] CHANGELOG.md: irq-max-guests Thread-Index: AQHXJvxUWijs3ZDWcU2QBjbhopWf8qqftWSAgAAITYA= Date: Thu, 1 Apr 2021 14:46:43 +0000 Message-ID: <75E92685-8930-4518-8D8F-CF8CA8A2312A@citrix.com> References: <20210401133827.362216-1-george.dunlap@citrix.com> <20210401133827.362216-7-george.dunlap@citrix.com> <37b76a6d-e81b-1581-d89c-0d99a9d2eba9@suse.com> In-Reply-To: <37b76a6d-e81b-1581-d89c-0d99a9d2eba9@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.20.0.2.21) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 66bbd925-85ac-475e-dfcb-08d8f51cf7c0 x-ms-traffictypediagnostic: PH0PR03MB5685: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8c9S3cq8CsONJZaRg3SmoIr3bE2ua+ngV7EBRhAururpgVqxJ7Yc6O3iIVhfG6fx+TaUTlLT9IVrR14qqVZuxWSEl6lDR6DxNUBV4bBBQPhzxvhBGVp/621JIHP2/GT3pXUnsJU+7JcjWKYVSvycpIZbw/aFO9o9WaYiXJjjAP2TGc0+B2iScfxK0AzNg8kk3TcudgZayv3dkyryQoHDjH+MzzteokVzfZJuegA/u1KkQvhL08GBupKTCCi8tNC2ZuWTZDhcGh90cNNkQtEQB+xp58D7PEATKZL2+BoxiLGqthZT09PAYQPvghT0nQXttma2lYvLE0l31I9sqR5j2XmW/8pI5uLIrJgE11KW1pk0scjP3vCe01t8bEIGHreJC9zyXI4vp4k4I6vGREMywg+CDmCqzV7E1tXOiwhPDoRZaWkMp57O7Jq82i+F7FG1ruf6wRSpYud49kMnRIBLBSnhqU5fWzN0ACR9VTBIm5TkloYxL5bMghG2uiWnZ6oBGc0RJ62JC+ClRxRRDOp13gPNhBoaXY5tO0503WJmlVzWoGdM01sZEKWpfrbP7UjWksPAFwX53sRwnUtcI7j4r4VYLMSv31L57eEv8nKAmuUvFfzRvAH5LzUvC2NaNF1imEuLJhq7ZcGcDkCny5HE/H07AhPPK8PCiGZzmIMA8smFPhAeTKUkqxzFhMCztBUVBCBRYbofGVIOSG8e25IRk3XOfB8YZnw1xWnQkIS4GqX/Stq+nSPBB4oi6yUvTe8RNddR8kdJCYWlK+y/lTTFiqtPL7hX3Z1qUGBWYrtSbLX4qQKrBG7Qt9csu9vZV7Y3 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(366004)(346002)(376002)(39860400002)(396003)(6512007)(33656002)(4326008)(2616005)(76116006)(186003)(6916009)(6506007)(6486002)(53546011)(71200400001)(478600001)(83380400001)(36756003)(8936002)(66476007)(54906003)(66946007)(316002)(2906002)(8676002)(66556008)(5660300002)(38100700001)(91956017)(66446008)(86362001)(26005)(64756008)(219803003)(207903002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?VWZKeWZjQlNreHVsVDB2Si9XbVRTK21BRUg3V1J6SDkzUHFCRHE3SzdFa1FW?= =?utf-8?B?QStIYjErQ0Nuc0Q5QjQyYmNhSXp2WXhTSVVCYjQ2T2w0ckNoZ0F4SFpqNE9V?= =?utf-8?B?NGNQYWwxSEh2TGhqcDFMT0p2cXJVa2FIZ3VBbjhHVmk3bnQwZzVjdFpxSDVq?= =?utf-8?B?dDNWblpBVWtLYkxqemN2bDZiTW1MaHY3c1NNcUtVRUxWQ1pvR05OaWwxYm9s?= =?utf-8?B?T0ZkclR2RlFEcUQzWWZTUXplSmNaQjBGK3JJcyttZGs4U1R1OThqYVMxaGx6?= =?utf-8?B?dCtkYy9JcmxTVWw5bW5UT2lKb2xGSmhyczAzUGhlR2owRzBhbnNHU21TazlS?= =?utf-8?B?VGVqRlByR2k2Y3BkV1lEaWJ4clF0SUpvbnVLSWpDVHc0K3V2VCtuRittQmZW?= =?utf-8?B?bW9tMGgyZnlOVDBjeTg3eGx1MUlYOTBoWERPVjIwYnNqQUNhZWZ5ZGgzeHhT?= =?utf-8?B?d01QWDJjQUtYTkJlVU0zQmQ4VEE1T1RkcjNZVzNFWjNCaldFSjFFbWRPaEVS?= =?utf-8?B?RzBHb0YwZmZidTl4WG1UUFJ0eUhZYjJ1STNMR3hLbWZUcUF2aHNpL0djdmdj?= =?utf-8?B?aHdIVXROc25oUWhWVWhCdVc0MkYwK0xIUXFuZEtyYnRFYWVtZFhkOElYL3Iv?= =?utf-8?B?T1h2K3hGN3JXN08ydlIrVFBXYTg4RjV3SWVEa2toaTIwMGRXZnB3Wnp6QTVo?= =?utf-8?B?R2dvR3JRbXF6RkpnMEx5Tk9MNXhZRXBhdWVnb0cvMVMzcE9CMGw2MnJYcVc2?= =?utf-8?B?RksvbkRueW9OUkIreHpkeEVqeDVaaTgxZmFBQTRCWDdLZjNpOWZpTGE4NFdx?= =?utf-8?B?S3R6ZjdEMzgyWStVdGF2eXI1MnBkQ1lSOXJvNkJ4VjRUeUZLQ3liQlVoSVEz?= =?utf-8?B?ZlVFYzVXd0NERFZHbTB2YzhjbzdXQVhBMXFoc2VueDhvNlpXOXZGZDQ1STg0?= =?utf-8?B?VnVERFpFOS9EM2JuQitHeDU4Uk9sdkF3b2pwcElsQllBVDVTelVNUjZ6TzRF?= =?utf-8?B?aFd6VlRWZ0dTcWdpUnB2K2VpUFJGdjgvTUgwdFdBTk1jaW9tSkZJTG5pa2M5?= =?utf-8?B?dzFoeUJMQmFVQUxLOGNVd3BzRWNaU29xM3I4ZGI4bUp4ZjcrZW1pRDNtV1Za?= =?utf-8?B?RXdaY24xSWRMSHZVME5xbU1pQXp4Z2ZvOGE3TkN6ejFzLzVCYS90bDFodFp1?= =?utf-8?B?bWN0aEZHU2FOMzVyc1dEbG0ySTE3M254ZXg1bDFzdVpzWGhibjUxNUFBa1BU?= =?utf-8?B?QlF0cFlRZkNjVFNGMTk3citSOEM2Vm5yTDkyd1JuNkVhdUxXMmhhZFVEQndT?= =?utf-8?B?elpXY3dtN0Z5OGM2M3FpQmViWHFLTHZmejF0bUROWVM3QlVVcXhyNmpqTDV6?= =?utf-8?B?SGJUK0FQOXRYejFqUVR1NEtLNElGSFJuRE5xUHZCUHdpa2NFbXY4YnNjK0RW?= =?utf-8?B?cjQ1MGtCQ0owV29ic0ZQbnFlOGpScWtaemlFUnc1cll6UlcyTUNmUnNtRkda?= =?utf-8?B?SXZySlVLV2JBK3hMZDluWkJZNkxEUXN1Qmx4VFA2TUp5QzNqbUpOWjdnRjdM?= =?utf-8?B?TzNwVlRtNHEzbDNXK1NFMC9sbkhpV0hZNzd5Vy9VWSs2enkzRHgwaGgrdGJs?= =?utf-8?B?UkQxS2JsbC9oNXpEekVWQ2JSOU9KaWNhWnRDaXFQa1pYTjJ1K0ZNbFJISDVa?= =?utf-8?B?RGQyS3B0bk1VSVZtdnNzSTVLUjlWVndpNWpZVkVvbWRDV1NQUnZ1dkJ1MmpL?= =?utf-8?B?WWNLZmFmVlRQTUkxQkhaMHNMSG4zNzkzL2NWTUQya2FqL3pkNUdzN0F6RXU5?= =?utf-8?B?MW54bFZHaDVSdDd5S3Nrdz09?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 66bbd925-85ac-475e-dfcb-08d8f51cf7c0 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2021 14:46:43.5903 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YzzM5pWsivAToVgLu8UbcLxiPf0TzO1p0Oguu33kfb10YOUvEyWV5Y+aD0fsX4ycKD0j2++IKUhYg4bauND+rNhIqSKjDKVMRm7p3T/Bcf4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5685 X-OriginatorOrg: citrix.com DQoNCj4gT24gQXByIDEsIDIwMjEsIGF0IDM6MTcgUE0sIEphbiBCZXVsaWNoIDxqYmV1bGljaEBz dXNlLmNvbT4gd3JvdGU6DQo+IA0KPiBPbiAwMS4wNC4yMDIxIDE1OjM4LCBHZW9yZ2UgRHVubGFw IHdyb3RlOg0KPj4gLS0tIGEvQ0hBTkdFTE9HLm1kDQo+PiArKysgYi9DSEFOR0VMT0cubWQNCj4+ IEBAIC0zMyw2ICszMyw3IEBAIFRoZSBmb3JtYXQgaXMgYmFzZWQgb24gW0tlZXAgYSBDaGFuZ2Vs b2ddKGh0dHBzOi8va2VlcGFjaGFuZ2Vsb2cuY29tL2VuLzEuMC4wLykNCj4+ICAtIFNvbWUgYWRk aXRpb25hbCBhZmZvcmRhbmNlcyBpbiB2YXJpb3VzIHhsIHN1YmNvbW1hbmRzLg0KPj4gIC0gQWRk ZWQgdGhlIGZvbGxvd2luZyBBUk0gZXJyYXRhOiBDb3J0ZXggQTUzICM4NDM0MTksIENvcnRleCBB NTUgIzE1MzA5MjMsIENvcnRleCBBNzIgIzg1MzcwOSwgQ29ydGV4IEE3MyAjODU4OTIxLCBDb3J0 ZXggQTc2ICMxMjg2ODA3LCBOZW92ZXJzZS1OMSAjMTE2NTUyMg0KPj4gIC0gT24gZGV0ZWN0aW5n IGEgaG9zdCBjcmFzaCwgc29tZSBkZWJ1ZyBrZXkgaGFuZGxlcnMgY2FuIGF1dG9tYXRpY2FsbHkg dHJpZ2dlcmVkIHRvIGFpZCBpbiBkZWJ1Z2dpbmcNCj4+ICsgLSBJbmNyZWFzZSB0aGUgbWF4aW11 bSBudW1iZXIgb2YgZ3Vlc3RzIHdoaWNoIGNhbiBzaGFyZSBhIHNpbmdsZSBJUlEgZnJvbSA3IHRv IDE2LCBhbmQgbWFrZSB0aGlzIGNvbmZpZ3VyYWJsZSB3aXRoIGlycS1tYXgtZ3Vlc3RzDQo+IA0K PiBBY2tlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiBhbGJlaXQgSSBh Z2FpbiB3b25kZXIgaWYgdGhpcyBpc24ndCB0b28gc21hbGwgLyBuaWNoZSBhIGNoYW5nZSB0byB3 YXJyYW50IGFuDQo+IGVudHJ5IGhlcmUuDQoNCkF0IGxlYXN0IGl04oCZcyBhIHVzZXItdmlzaWJs ZSBjaGFuZ2UgdGhpcyB0aW1lLiA6LSkNCg0KSXQgd2FzIGluIGEgbGlzdCBvZiBwb3RlbnRpYWwg aXRlbXMgcGFzc2VkIHRvIG15IGJ5IElhbjsgYXQgYW55IHJhdGUgSeKAmWxsIGxldCBoaW0gaGF2 ZSB0aGUgZmluYWwgc2F5ICh3aGVuIGhlIGNvbWVzIGJhY2sgVHVlc2RheSkuDQoNCiAtR2Vvcmdl From xen-devel-bounces@lists.xenproject.org Thu Apr 01 14:47:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 14:47:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104572.200163 (Exim 4.92) (envelope-from ) id 1lRybc-0006lM-8D; Thu, 01 Apr 2021 14:47:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104572.200163; Thu, 01 Apr 2021 14:47:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRybc-0006lF-4K; Thu, 01 Apr 2021 14:47:32 +0000 Received: by outflank-mailman (input) for mailman id 104572; Thu, 01 Apr 2021 14:47:31 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRyba-0006l7-U6 for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 14:47:30 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c26569a4-d98c-45c6-98cb-1e7ba1857eb4; Thu, 01 Apr 2021 14:47:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c26569a4-d98c-45c6-98cb-1e7ba1857eb4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617288449; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=bTrgLIOdK867y1sJMrIi4ZWeW4jmhLnYojvITth1ttI=; b=ifdzTrYMohL4WBUqPnPokW1xdDj5DNs2b/OoQS1AZu7JETnalECi0hie KffjExDxQ0GRCA9MBFeHUpqzN/+jxya3p7MKWLqDdlUkUoRXvj8utQCsK Aa3mR9nmM62omvZ9ZMYuG5ibdzrteuPt55/K93EWesBVnRxA68/GKmNjb 0=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: K5MO/ez6rLT1bri1vxUdscuqCOLn8iP0U2I/M5ELx5ImDbV59ijZD9lsRnAZy/MS2Z8KJiTsDY 5iBu/E37T7VY1CZxeJe5VgRA2cLklCsGffQ++vbUzpHuUQ/o3tpzV6aS4MCwd9cX27wQufvroE o5AfjmjYbT4kFsyEE/rmVjWTPEHysjuYQxnxcAUnlbTVTZ1bBpYKvtoq8jQVLxA3KHctJjdUku i6VMogeX9Ay6jtpz2MmgsqS2mdd0bAdNBhw4lzmEeda2D/LeQ+MNxRTY+AL+jfxi+9MZcdEgVI Grs= X-SBRS: 5.2 X-MesageID: 41084059 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:YFw1iq1a9f/Zr+2Dvr1TRwqjBbByeYIsi2QD101hICF9WMqeis yogbAnxQb54QxhOk0ItNicNMC7LU/02oVy5eAqU4uKeCnDlC+WIJp57Y3kqgeQeBHW0uJGz6 9vf+xfJbTLfD1HpP336gW5DNosqePvmMvD6Nv29Ht1SBEvVqcI1WdEIz2WD1FsQ01+DYc5fa DsgvZvnSaqengcc62AZ0UtYu6rnbL2vaOjXDpDLyRi0RKJgC+j9frEHwPw5GZ4bxp/hYoHtU D+1zf0/LmnrpiAu3nh/l6W0rATsOGk9sFOH4ilk9EPLCrhh0KTaINtV6bqhkFMnMifrGsP1P H35ys7M982wHbWdGO4rF/W1w7s3C1G0Q6Y9XaoxUbG5fbfeQh/Me59vOtiA2fkwntlgfVV6o 4O+2qFvZtaACjhsU3GlqH1fiAvq26dm1ZnquIIk3lDOLFuEoN5nMgj2GtuPNM+EDnh6IYhed Mecf3h2A== X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="41084059" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hpQIobgfWkvCqnFmU/olJ2NRUfSGJxdEOgcbcPbAcKmY6kjpp6JzmhDIR2A/xWCyahghu+gZwG0dkviqNVmEe493XOKeLTG3FTQUkuICposiCg4d37GMzcPpB0QStDrZadm2XsEMqgAL7L1n5aeKIAKPPdV2r1OtvmyV4wRP5zf3byAlIpeJtfXHVHGXMwMt/mrRxhbhdXmWeI2aa8EThTkz2ovEC8tBI5zatkMjbKmwcdO670S6B8q99EiS4Nz+tIprdhcS6r8xRxALOSWHz5FQ5/1gtvJ0CEp3TLl3ikXEVlGaVqEjqdnbBw9J96eEW0yIZQTlcNzRooqxkZUheA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n+qothyvfianGc+oCmDzsXnEORNndPWHYlCGJwKnB6I=; b=bJY97WrTUlG37036KM4rirDx8ExYMLVJS1cEYpd4SAm8TAJ04xI4hQyozuJGUldhn+SGsvpRtaG+DaoD6W+MfAcQXR50HeRb8Wz5d6zEGL1eWWuNbjyoOGhUJcltvfbCunofT9l8rLutWNv3HvSGPAFEsL+9/3enW5Ozf1Z3/Z5bYmy4MWXGtCpwoRn0IdlTL7/495y/TlgdJsF2F3VrUb/F8zI0Mro4ojl9l1Aig2ijkmLvW/dTEPRF7xZlVR6DN3P7aVHktdLaRjANY8GKHbp8MZzAprohbNl/FiKtE1mfpwYUv7Emcl8TbJlK38ItbpED75dypYIhtwvgyf8Aeg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n+qothyvfianGc+oCmDzsXnEORNndPWHYlCGJwKnB6I=; b=Xw0cfTq2CKw2a16q43znuzdfY2CWfV5h2m8FWJc4fuAsUtKXcPrRTO+NsMGkhryQiXNdnHIpSavwVAvihC1UwofcF/0gqLHE73LLJKJq4+rUcXLH3GyUn7YmwqOwDqGc5qwRc0PZsDsANYvB3iUE2A+gNKXvL8WmomBD4Lw292Q= To: Roger Pau Monne , CC: Ian Jackson , Wei Liu References: <20210323095849.37858-1-roger.pau@citrix.com> <20210323095849.37858-10-roger.pau@citrix.com> From: Andrew Cooper Subject: Re: [PATCH 09/21] libs/guest: allow fetching a specific CPUID leaf from a cpu policy Message-ID: Date: Thu, 1 Apr 2021 15:47:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <20210323095849.37858-10-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0391.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:f::19) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7566726c-8c43-4556-de52-08d8f51d1008 X-MS-TrafficTypeDiagnostic: BN7PR03MB4386: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jlevTzxGPaXetsM0z/VNqz0QL6QB5m8jdMqhjKQ7FFZrKLLrF+/6YwN/ExKmKg04OODqtzqd0RuAaBrwmJ6fE/sFkgNawNGjuJzwZ2axK/tDdwj3k9XfhEOwV8Gho2hYyfzKZpPRPQFJsVcWR9NoDCc3ABEgepJCveiuyPfRDhqVTFzsfmqgiGjaSmRTFH264XzFted+gk7DvTrV5upPWa5Oiw2w98zkNSabz2mxml/o7GgIv/oThScUtlA4G69e2Qkug0z4bBlHYpTC8uRdv+gN75SY3dqVhkV7i3MNxFsmJswHNY9zbisLs57Lejla646fbxcxzZlk90EkuuIrC72sT717KmDu9ivHd7hV4yasJ1WksR/AJG4/CyWx+knMTfSgj/sGWNyKScXCwh/smzbICkoTTLe8UVoiCdwZYR3tWZwhUFRKrdlVPHuKtqDdLaFxHmdaMnPzZNkrbmJFVyjq9AZNYu5ZzMWEk7OrpWkB3lJ57w2gqSPAUhF/Fe5526AZCmFc3sLZEUn0B0RFa4mgC7nfzsCyMh9e9ZrKQ9uNaVpcTh/54k5mXfuQ2Evb4vTU8xj8jTQS97jN+YJLaXHPe+qOGdT/yeygkQCQf1NotT6zT7omtxOyS+xs3LafG/xP1tl4sT3tSAcD11kfCdATJSmyPkkGyslegTTW2iDxD0U0GQSB9Z/Zn1iis4LJFcFrlVxJtCZnCQ/s+VjdiIGZ6wJ4d3+t79oP6S+yXEs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(31696002)(38100700001)(54906003)(16576012)(36756003)(6486002)(8676002)(16526019)(186003)(2616005)(66946007)(956004)(2906002)(26005)(66476007)(8936002)(31686004)(498600001)(66556008)(4326008)(5660300002)(53546011)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?VldUS21OdnNMdjNoaDZBOXlCdy9YMzY1YjJhOXpsNlFZdG9nZjN3TXhOVFAz?= =?utf-8?B?d0duZnp6MDFnVjhTTy82T05PNlBpWFVzMVJ5ZGplWG03UlFtQVE2Q0xtZEIr?= =?utf-8?B?bHRKMi80U0hXNGt1VFoyLzNpbURMTzRpeEV2WlFmWEtZNVhMSkFldW5ac2Zu?= =?utf-8?B?OXI2RGdqVHRIbGdOcXJLNmkzY1FYclJnU0U1RUEwTzBOdHRLNUJ3eklLYWhI?= =?utf-8?B?VXhiLzc1Q2taL0NacitRNVM0NE4zd09qS2R4M1BCaVkvTVBBbnNIM09xSDFy?= =?utf-8?B?OTd2bUNIWVlnUyt5bVcwdlBtSExad09rcnZzWjhoTFJZcUY3T3NKaFJkMHNs?= =?utf-8?B?VkJrR2d4b2N2NVlEUnYwVkQ3MkNXeDM1R2J1UDFGTU5JSzZtbW5JSnpVTmha?= =?utf-8?B?VnIwSUY5MGtyOTNsTVdlY3hvUmgxcEJsRmdZRXZuOG96VG4zbGRYTEpXMWJP?= =?utf-8?B?MUFKTy94SndxUUR2WHcrNVdIRTJ4VWxESmdJbHRaemdXbDdzT2s1OXdzRVpW?= =?utf-8?B?SXM2UnJpYTVjNlh0T1h4a1FOdFV1MVo1bVFSZTRjS3R3dk9jS3p3WFJVU2FP?= =?utf-8?B?dHlUVjUyMW44dE5aREg0TDRqTHFCY0NjdWh4MVdZRFlhRzhXeTFJRW0wK2d5?= =?utf-8?B?OHk3ZXovZWFPUFpHRi9aSjlmcjBTUjlocUxNTG5hckNUdUo3czNSdjRuaUl6?= =?utf-8?B?T0M1ZHIyVHRoa0VUTkd6YjhCSEdHdGN2c2oybnp1Vy94ZGFOa3dIRXRSU2hF?= =?utf-8?B?Z0U3N2wzUDNSdWhGRzg1SVRSdWF4ZXVHOFZEQ1BpRk9UNXYyRUlnUVFOZFhE?= =?utf-8?B?emYrYzBaK1kvaHVoZjRBR0xVL1NwQlZxdVhvUTBUS1pPc2Q1aE1JSlgwRHFP?= =?utf-8?B?NGtWZkZSM1hqbTJPVGpmWWE0TkxDakIyQmZFUlh1cmthME1reVMzMkhYMENY?= =?utf-8?B?TmlWL0tFTk5Lb3lFWnlBYjEwMTZaTEVrOTB6ZWQ2bXpvNzdhRmtvK1RVSGRJ?= =?utf-8?B?enJ1YUVNOFZTM2JtcVJ6bCs5VnBWUFV4UnpUUjRRc3Vlc0FBdzkxb2FIeEd1?= =?utf-8?B?b05RbTk4bUZsRW5VaDFQaHVHUEhUL2ZhelMvTGV6R0o1N2hNOTFnNXBIcXpu?= =?utf-8?B?akNKcGlxY3hJUUxlTnVIUTNDc2g4MXEveGtkd0hDSVBNMnFlSjRZcU5hOGpL?= =?utf-8?B?OE9XY1N5UjJzOVY3QnhoV015VVFub3VmSXZCTVh2TUhoYm1ieTl4ak01d1Zp?= =?utf-8?B?TXdWNkxldytnTEg3S2lxL2dxY1BUTkJtUVNnVGVtWTUrMDA0UzhVemx1RE1P?= =?utf-8?B?Uk5LVUpqV04rV2p2c29nMnBIQy8ycitiTEFONEIwRVNlbFRMSStWV2Jxd2Ft?= =?utf-8?B?MEZJd1hIRGVVTlVPWFJhWUZabDdzeUdZbGFVMnpvTHRmQzJndHlaU1lUWFpa?= =?utf-8?B?cEdMRmc4d2M3dUsvZFhVWTNBdW9EN0FQU2ZHSGZEc1ByTDFkakRnSGRmK3lT?= =?utf-8?B?WmNHdHhFZEthcjQ5alFrZlJ1bFpxcXB5WkZ1ZVlvb3lZT2tEdGNyTWpZajZD?= =?utf-8?B?ZmRPeVdDYzc3Wm10R3Vubm1hL3Fxb0ZpQWI2RktISXc1ZTRFQ1l1V1JTcUw0?= =?utf-8?B?RXNMa1VzekdyRTNENGthL1FuWDRWd1E4akNlcXRUdS9rZ3ZrbFZPbW1wVkxp?= =?utf-8?B?cExodDZoMktyUnp1SUUwdFI2blE0bTROczVwNTlCTXRuQUt6SndBam9kZXZ6?= =?utf-8?Q?6c7MeUpp7971+Ya69mc1QGivPCoFSw+NxeSsWUG?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7566726c-8c43-4556-de52-08d8f51d1008 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 14:47:24.7656 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: G4ubR7XIL4rlfPMrk+l4zl84Y2Iz7dvikiBZz0tSqhyyDKOoSIWRK0jwN2N3zMJF7Tt8TFAoJoHJrUJTrtzKKf0zGcg0AYpdPDhzNJS5JXA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB4386 X-OriginatorOrg: citrix.com On 23/03/2021 09:58, Roger Pau Monne wrote: > diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_= x86.c > index 48351f1c4c6..a1e1bf10d5c 100644 > --- a/tools/libs/guest/xg_cpuid_x86.c > +++ b/tools/libs/guest/xg_cpuid_x86.c > @@ -883,3 +883,45 @@ int xc_cpu_policy_serialise(xc_interface *xch, const= xc_cpu_policy_t p, > errno =3D 0; > return 0; > } > + > +int xc_cpu_policy_get_cpuid(xc_interface *xch, const xc_cpu_policy_t pol= icy, > + uint32_t leaf, uint32_t subleaf, > + xen_cpuid_leaf_t *out) > +{ > + unsigned int nr_leaves, nr_msrs, i; > + xen_cpuid_leaf_t *leaves; > + int rc =3D xc_cpu_policy_get_size(xch, &nr_leaves, &nr_msrs); > + > + if ( rc ) > + { > + PERROR("Failed to obtain policy info size"); > + return -1; > + } > + > + leaves =3D calloc(nr_leaves, sizeof(*leaves)); > + if ( !leaves ) > + { > + PERROR("Failed to allocate resources"); > + errno =3D ENOMEM; > + return -1; > + } > + > + rc =3D xc_cpu_policy_serialise(xch, policy, leaves, &nr_leaves, NULL= , 0); > + if ( rc ) > + goto out; > + > + for ( i =3D 0; i < nr_leaves; i++ ) > + if ( leaves[i].leaf =3D=3D leaf && leaves[i].subleaf =3D=3D subl= eaf ) > + { > + *out =3D leaves[i]; > + goto out; > + } Please adapt find_leaf(), probably by dropping xc_xend_cpuid and passing in leaf/subleaf parameters. Serialised leaves are sorted and there are plenty of them, so a log search is better. How frequent is this call going to be for the same policy?=C2=A0 With the arrays embedded in a policy, they're still around, and serialise is an expensive operation. I wonder if it makes sense to try and keep both forms in sync, so we can avoid redundant calls like this? ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 01 14:54:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 14:54:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104578.200178 (Exim 4.92) (envelope-from ) id 1lRyhm-0007hr-3C; Thu, 01 Apr 2021 14:53:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104578.200178; Thu, 01 Apr 2021 14:53:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRyhl-0007hk-VY; Thu, 01 Apr 2021 14:53:53 +0000 Received: by outflank-mailman (input) for mailman id 104578; Thu, 01 Apr 2021 14:53:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRyhl-0007hc-0X; Thu, 01 Apr 2021 14:53:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRyhj-000888-R9; Thu, 01 Apr 2021 14:53:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRyhj-0003xr-Gy; Thu, 01 Apr 2021 14:53:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lRyhj-0002Rd-GW; Thu, 01 Apr 2021 14:53:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vqiHAqlrTdpANp6bzNSTSj5Y6nK47cX/8uKZstN/qqw=; b=h7Uc9fkXo1Ee/xwI7kYP4wbp65 m7+Ll1+ooWOpeozxUFDz+wMH5l9vJlmoOpO4P3oiX9LFYD7Y9U16S9cVmN5comMYzIMAOdDJ4VCHO xLr/+L2y5bRg6FDuumOtaN4GjCoF/oUb/p9XLZvWCFLXUHltVqdGBf8nXZf4TUC0H1Ds=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 160630: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=90629587e16e2efdb61da77f25c25fba3c4a5fd7 X-Osstest-Versions-That: xen=90629587e16e2efdb61da77f25c25fba3c4a5fd7 From: osstest service owner Date: Thu, 01 Apr 2021 14:53:51 +0000 flight 160630 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/160630/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-examine 4 memdisk-try-append fail pass in 160581 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160581 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160581 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160581 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160581 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160581 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160581 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160581 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160581 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160581 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160581 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160581 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass version targeted for testing: xen 90629587e16e2efdb61da77f25c25fba3c4a5fd7 baseline version: xen 90629587e16e2efdb61da77f25c25fba3c4a5fd7 Last test of basis 160630 2021-04-01 01:51:44 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Thu Apr 01 14:55:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 14:55:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104584.200201 (Exim 4.92) (envelope-from ) id 1lRyjD-0007so-I4; Thu, 01 Apr 2021 14:55:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104584.200201; Thu, 01 Apr 2021 14:55:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRyjD-0007sh-Dy; Thu, 01 Apr 2021 14:55:23 +0000 Received: by outflank-mailman (input) for mailman id 104584; Thu, 01 Apr 2021 14:55:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRyjC-0007sT-78 for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 14:55:22 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRyjB-00089W-GM; Thu, 01 Apr 2021 14:55:21 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lRyjB-0003b8-9v; Thu, 01 Apr 2021 14:55:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=VvvUZolMET6kbgJUdtBpnHkZ4F0PIjOStve1wWcTpYc=; b=fybt1DEhszLUodsDMEWLhxqKTN 4dvMHw/PPvumAhLC5i8YqNc1pF8aw1EYVuMx7rkDw021N5qv/0yZvfotQ7xOy2fHedxHWA5vzZrE8 v28N/Z8ti/dvzeVZLhsNV865xvx4tVWbK5kZYk20F8f/zriDiEpjos5HuPIXe9NmTTi4=; Subject: Re: [PATCH 00/23] further population of xen/lib/ To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <27916fa0-9ebd-a49a-bbb9-1ef47c2b5bf6@xen.org> <4f745d03-baa8-e9e6-692c-f9c9f401b766@suse.com> <6a38f0db-938b-fd13-48e6-6b538c85fe42@xen.org> From: Julien Grall Message-ID: <3bdbd0ba-ce7d-3814-3280-c4f628b74d93@xen.org> Date: Thu, 1 Apr 2021 15:55:19 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 01/04/2021 15:27, Jan Beulich wrote: > On 01.04.2021 16:04, Julien Grall wrote: >> So overall, the number of functions requiring overriding will likely be >> pretty limited and #ifdef would be IMHO tolerable. >> >> Although, I would be OK with creating a file per function that are >> already overrided. For all the others, I think this is just pointless. > > Well, I don't see a reason to special case individual functions. > Plus any reasonable static library should imo have one (global) > function per object file in the normal case; there may be very > few exceptions. Drawing an ad hoc boundary at what currently has > an override somewhere doesn't look very attractive to me. Plus > to be honest while I would find it unfair to ask to further > split things if I did just a partial conversion (i.e. invest yet > more time), I find it rather odd to be asked to undo some of the > splitting when I've already taken the extra time to make things > consistent. I am sure each of us spent time working on a solution that some reviewers were not necessary convinced of the usefulness and they had to undo the series... In this case, you sent a large series with close to 0 commit message + a small cover letter. So I think it is fair for a reviewer to be unconvinced and ask for more input. You provided that now, I think we want a short summary (or a link to the conversation) in each commit message. This will be helpful to understand why the move was made without having to spend ages finding the original discussion. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Apr 01 14:55:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 14:55:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104589.200221 (Exim 4.92) (envelope-from ) id 1lRyji-00081H-Tn; Thu, 01 Apr 2021 14:55:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104589.200221; Thu, 01 Apr 2021 14:55:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRyji-00081A-QZ; Thu, 01 Apr 2021 14:55:54 +0000 Received: by outflank-mailman (input) for mailman id 104589; Thu, 01 Apr 2021 14:55:53 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRyjh-00080h-Q8 for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 14:55:53 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c087b886-7b28-4698-af1b-be56ee064a42; Thu, 01 Apr 2021 14:55:49 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c087b886-7b28-4698-af1b-be56ee064a42 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617288949; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=GNiFq6gfJoTHlrSodqaQhCyBrF/F4z/pUy32GVXeWdU=; b=HZUMuhdMs9AugCRHYGjriwDjAE7v5c0pM+Wum7tlm1OSwT5/ktjgJUZE PmjMKnqC3blDgdyrl/t5LphGrExwPm0tvPAo+lJc4U23vqtxUy4PuZyjO Xev2wondilASp0Y22xCRcs/vB0XLTzGFn1mP/duaVxHDQctcDn8qT2CKE s=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: JXuiZUcm8xyHmhfQEOQxQF1GX2B7x/aVj84rkPowYORxD1l7PeAPKZcGqKHgAwaDjDyLRVSL3A nJ1T9oHfht/fAmzV1ghqSAUQR/+ocCePkyzCYbMRbZoszsjK88u8uK9f3qEV04YC9Jfv/7yQhV NmFQuxHicOijo99ClOApve1FD60AMPlHwynF+xNkHfZmo6Z59YCVoRuJo1xUyGXlxvmoQsxwLH RgTAaVGjJOSD4LMkoPsx0YCANfBxAvjAFqkG/2manbitkukbL08SCfZDaRQHrnJCFVYwSxkcFd 0oA= X-SBRS: 5.2 X-MesageID: 40709139 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:U6ZuO6C0sqyK7LTlHegBtMeALOonbusQ8zAX/mhLY1h8btGYm8 eynP4SyB/zj3IrVGs9nM2bUZPufVr1zrQwxYUKJ7+tUE3duGWuJJx/9oeK+VHdMgXE3Kpm2a 9kGpISNPTZEUV6gcHm4AOxDtYnx529/Lq1gPrFpk0NcShBQchbnmJEIyycFVB7QxQDIJI/Go aV6MYvnUveRV08aMOnCn4ZG9XZr9rQm578JTIADRgr6A6B5AnYlILSOR6ewxsYTndz0a4vmF K17jDRy4eCl7WAyhHa33LO9Jg+orXc4/ZKGcDksLlsFhzCkQCtDb4RPIGqnDdwm+237UZvrd +kmWZbA+1Wy1f8Ol64ugHs3Q6I6kdc11bHxUWDiXXu5ezVLQhKcvZpvo5SfhvH50dIhrgVu8 gqrgHpwqZ/Nh/OkD/w4NLFTXhR5y6JiEEvjPIJiDhnWZYeAYUh3bA3xl9fE5sLAUvBmeYaOd RpZfushsp+TUmXdDTwsGVp3bWXLw8ONybDaE0DtsuJ6iNRjXB0wmAJrfZv70soxdYTTYJJ6P /DNbktvLZSTtUOZaY4P+sZR9CrY1a9Di7kASa3GxDKBasHM3XCp9re56g03vijfNgtwIEpkJ rMfVtEvQcJCgzTIPzL+KcO3gHGQW27Uzio4NpZ/YJFtrr1Q6euGTGfSXg1+vHQ4Mk3M4n+Yb KeKZhWC/jsIS/FAoBSxTDzXJFUND03TNAVgNAmQFiDy/i7arHCh6j+SrL+NbDtGTErVifUGX 0YRgX+I81G8wSFQXn9rB/NW278W0D28J5qeZKqutQ7+cwoDMlhowIVgVO26oWgMjtZqJE7e0 N4PffGn8qA1C2L1FeNy18sFgtWD05T7rmleWhNvxU2P0T9dqtGn92efGtVzUaWPxMXdbKQLC dv43BMvY6nJZ2Zwi4vT/i9NHiBsncVrHWWC7ARh7OE/sWgXp8jFJ4pVOhQGGzwZl1IsDcvjF 0GRB4PR0fZGD+ro76iloYoCObWcMQ5phyqL85SoXf2rl6duskre3seU1eVIIyqqDdrYwARqk x68qcZjrbFsy2oM3EDjOMxN0AJVH6aG4tcDAOOZJxdn5fifA0YdxbNuRWqzzUIPkb6/UQbgW LsaQmZY+vCDFZmtndE6ary619vemKBf0V/V2BiveRGZBb7k0c29dXOSru40mOXZFdH+O0bPT 3fSRY5Iw9lxbmMpVSosQfHMU9j6oQlP+TbArhmTqra3Wm1LpaU0YscGeVPwZpjPNfyk+MCXO 6FYTWJJDfgB+5B4X3Nml8VfA1P7FU0m/Lh3xPoqFWi1HkkGPzIPRBIQaoYL9z01Rmse9+4lL FCyfQ7suu7Pj+vNpqoyaTLYyVCLR2Wi2isVO0soY1Vu6V3lLYbJeitbRL4kFV8mDM5J4PIsW lbZoJRyrXIIJVucMwfYDgxxCtjqP2/aG8Q9jXrCeo/d2w3h3DVP9m186PFwIBfdnGplU/VAx 2j6CVT8PfOYjub2ZMbA6w2J35KaEJU0gUVwMqyM6nRAh6tbedN4R6TNWK8aqZUTMG+aPgthy c/x9GDhOmMcSXknCjWoDtgO6pLt0KqW9m7Dg7JOelG9bWBSBixq5rvxM64lzHsTzSnL2wemI 1ebEQVKv15tQNKtvx+7gGCDortokwklFNC4TZo0n7Vs7LWnlvzLAVhKg3WgpJfQD9JFGOH5P 61qdSl6A== X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="40709139" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lPOlaiP07uarOc2BD7xHcdyKQSFAw2aV6ieXKmk7ZgIJw8y+VLtN4XcYT5G+nHh3jKYUtFq7Re2SdeShIBd6WnWLVqFZHDjZl7DFkphnRvreT/3GujE66aA40hMo5StLKR8gUn3FfVmsLwDgiHn1eMzzmDbBt6u7ZUS9oeXIRC6WH3H4CDOPQxUGJBpA8YPtwjE5qfDbDATLUmZ1nCb9L0+OXAtQfAjFwZq7q1emk/Tcu7nl4z965hCieM1dWWYYMz29hIYqC8BPOx2JKTeQRDiz9d4JBzYBCOzw9gb9mWmdHLSuCH5/mTop7jXeqsfjB36lv6lLCoWQjANKJynqzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6gX4/P1sEkNtez5H5Jn1w49A21JyqnDvXYw72qVzBVU=; b=aivdR7Sgl8Thuo+AZcPjxIAZhnmvrF+CmMxUDL4Q1ZzyjfVRZOL9RBwP+g2+s877KPezxHsTFAy8MbR/z0S3rc48qdyOOfj40Zgdz8uaGOisjr6XNYm6NVEjf08B+BQ+eWDdeFr+0mmuzvbnwhgOJbjTQugaRtGKccDKjJy5dweHXmuiOl/eJ6K6LrsLaZum7/7PxB+dqYvD+7M5KoJ9H8wdB6nIJS8crwXZWlIlGCA8akIgh6prj6gvWWdLY7tiERS3OGcrXhUP/XGCOI4BDDERrl3Gn3UX+iog13+Vwi5wXZ6dAHjvAP3N65ZCiCXYF2tCkjvOWuj8JbX6Kr+hBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6gX4/P1sEkNtez5H5Jn1w49A21JyqnDvXYw72qVzBVU=; b=sbSV7pOmSvcf1qPkyvAlGd5Ngkm3SYJMd9YU/r4M3AJ5f84/uF2TboN696ljAotWs+VrV+dRnKlZ97DLtYZWFDCVJn52vNYwJRM5NadsW8YRobrL/sVj//0zPcl8h3rpb+DiY4vxVEIzQyLnASXtIUZnWICCRKirv9DhCHa1OZg= To: Roger Pau Monne , CC: Ian Jackson , Wei Liu References: <20210323095849.37858-1-roger.pau@citrix.com> <20210323095849.37858-12-roger.pau@citrix.com> From: Andrew Cooper Subject: Re: [PATCH 11/21] libs/guest: allow updating a cpu policy CPUID data Message-ID: Date: Thu, 1 Apr 2021 15:55:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <20210323095849.37858-12-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0134.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:193::13) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 63cd3859-1663-4876-c1e1-08d8f51e3ba7 X-MS-TrafficTypeDiagnostic: BN7PR03MB3731: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5236; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /B35zz3iZ+E7rg4NplHJ/nklrKp57j5mpFTwAKxsjkX9Vg9XeNw123I2MjQqXPoHDnOB4JrnWg+/JioVRitFPtP0FBhAT/s1rEEL1IiMW37RfdGk94lDZZRo3EC58E2lcs3BPzuHR9jL75SHRz7kRt4b6oeiKEQBqrOBy4SEjgQm19fzvsETn9oHIQFl1HzQKex3QoS8Eyu5zlvjJdeB3DzvDG8qDR+5xVq+Yy7Nj7cgSPxXtLbfZhB9/V3myMm1ZLfFhlkUyVlNbBJDBR76wLp4tRy41q0gbhEIYbckFJNxbcLgfWRuKgB20sL4JbXpGOr9JrwrnhVWeiipsVW6dyieu/JKgxCpeiiq1gKxy53JnRQO3xt8UUsedZSiae4ykg372RL1iYu1HT/FKD51Zw+R3cB31i+nbW7txwpunUOjcVl4BZwOThxJhArDZEumCyQQxGJqKEcFQvmVSoCTwgYzQsGlSVhMatxPmD/lIDAXMoQWoIok4AEA4595asem+Z0+/Z0pv8IxjVWn8CbD+zhbDUSVtvxMRlSP+50+QGFCUjTg7m7fzkQgEYYkkGjYE2Zhmh3lShV2gJ2VvzfPYS+bxe3nGsAikX+TWcF7Uv9aOK/Y2BrbMdIMQrSIpLtiCUiSep43dEo7ODtoTHQAJXs6fow4WkxJk6dvRXi95o/92pA0xrbYIZLlVz2DSr4NFXyRw5v762AlWVRGWr6Oo/s7LFQbrBysOTcPQqkOzqs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(366004)(136003)(396003)(346002)(376002)(2906002)(186003)(66946007)(53546011)(6486002)(66556008)(16526019)(316002)(5660300002)(478600001)(31696002)(36756003)(86362001)(66476007)(54906003)(6666004)(8676002)(956004)(16576012)(26005)(83380400001)(4326008)(8936002)(31686004)(2616005)(38100700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?dlhIMUlGL1pZc0JtYnJXN2ZONE5SbktVamxsWjZDaks3MTVDY1pHTlhVcHI3?= =?utf-8?B?ZkZXY0ZGa3lOQTQ5TmZmNndmMTFIQlBsWHZrTzFtQ0luaGlNYXdPY0RFcC9q?= =?utf-8?B?OXY3MGV3aXVZWlZncmErTTFPenRCRzJtcWJpUnpLMUtla0huektUbEhodit5?= =?utf-8?B?ZzlIcnBwUVhXanl4V21DWXVVaEVlKzNyM1Y5cmtFVjhranRSbTJ0OThrNmc2?= =?utf-8?B?VjhQZG5EekVvK0thMXdEVTFLTTZnTlVhMTRodWV2MlQweGxacnFnaTY1c1ll?= =?utf-8?B?WVVvbjJZbXFubjhFT2VuOVhkSm9TdjlGd3ZNZXhmMVNSeUdodjBTSkxVWW1u?= =?utf-8?B?cnlyMm1SQkpTZzEwYkNxUlNwV04xTk81VkRlUkxXTjVNZ2o1QktnUllERzE1?= =?utf-8?B?MmFneTNPNmI0YUdYUFlEb2NDbEszdmhTdyswbEFSY0RSUkJlR2N6bkdvdStT?= =?utf-8?B?cERJQXFDSW5odEd6N0dBR1paUFRzWnNHa01aQ2E5WE5velF5SElLOVh6b1ph?= =?utf-8?B?bWhGVkMxeUwzYmRoelZ5TStwMWNCblptNVpwY0RteSt4cnB5ZjUvSndiRTEy?= =?utf-8?B?Q3phb0R2UEhLdnF2VVZOazVvZmtaWXNqeS85MFZaZGx4ckR6TXpGRVNKY1dG?= =?utf-8?B?MytTNXNxNDZCVTRvcmFMNEE5MXRkNnRYQmdxNnlHc1FWRWR0VFZsSy9KSWFW?= =?utf-8?B?TDd1RTlsNEtOMm1qaGJYMkw5TGVMUXRKdFJ0L3o4cFJlM3ZGMElQODBvT2gr?= =?utf-8?B?YmRpWGpsODNJaitTbFp0Qm5xcHBrWGYrb2ZMZDhUWjM1VE4zS3RvdWZUbFYv?= =?utf-8?B?NXFQQTk1ZHplWmoxcnJ5Q1htRkRxeTJCVmlSYjAzVGtST2plVW1UcmVlQUt1?= =?utf-8?B?OFhlYUU5Qkd1V2gxV1NwYXcxQ2ptTE5jTFdpV1Q5VnhudDM5OVdtSHY0Nmdt?= =?utf-8?B?OGRTMHpwUkpDMkI4bzZ0Y0xpekNNdEpwdmluVmNTZnk1bFBVOW1Gc1ZXWjFG?= =?utf-8?B?Rlh5Y1ArbDgvcmNpM1hEYklaRkEvSmVQdkpWR2tkUGtkZXpBL0RVMnFKRkJP?= =?utf-8?B?LzlrUHFsVnQwSVNBbUNqSFBGVzYyUTFZb0hnUklYUkZhWDJ0V3FPSUpRbUd3?= =?utf-8?B?b2hZaXhrRUJraW5sUWxjUEUvMkZQNytTMG1URXZIVFk3S0dlbzg4ZXd2cTdu?= =?utf-8?B?MlZHMzBRSE9jaDh4c1ZDUjRWU3IxV1RqNWJQOHdZUzFEYVZ3ZUo4NkhmVzVl?= =?utf-8?B?eWpjeW5DK0g1TVpWZE1wdFJXSHFGZFN2eURRZ3BaRk1kckY3anVSVkk2VXhN?= =?utf-8?B?c0RzNnBIbncwaHFiMUI3cU1DVnI4WEdNZjhvd2draG1kR3YrcWp5OW40cVVz?= =?utf-8?B?aU5NeWNCeDNiejhMb3daSkZ0VFhFMjdnVTBJUTNnQmhjczVWU2FMWGkyVzZG?= =?utf-8?B?d24xREQyckxZOW1KNGNhcGlvQlBycElKbTZmeThRU0FwclhWeTBvbWg3V3BL?= =?utf-8?B?dlNrdXgwZGIvQTBIYXl4NVpnam1HRTVDQlMzMXVsZWZxNXJWSWZuVjRSWDBk?= =?utf-8?B?ZXhKM1owbHFyOGI2SmlWWFZzcUNwQXdKZWtVZjhZTHZRNjYrTlRMVVpUTllB?= =?utf-8?B?WVhEekx2bUJFb3hMYm15V2tLbjRNYmZwcFVCZDlJZTMzOFIyZk5EK2xuSXN2?= =?utf-8?B?TmREN0F5OWRRbXhLVklKZjA3bVhOS0lON1JtcFltWE1vZW0wTHdtZm5IdnFV?= =?utf-8?Q?h0yNycuFtMdWRq6EOPrQzLbL+dfYPaeU1mwEKqj?= X-MS-Exchange-CrossTenant-Network-Message-Id: 63cd3859-1663-4876-c1e1-08d8f51e3ba7 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 14:55:47.2998 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rf/XOa30StKwdqSe+SplVLFbekEALShaPcnmVxyjVrZQMLoX6ts+4pLhdrYtHpmnnY3eOEMnDecXKUYHOgeDy3DsqO0xBir43V55NFOf/o0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3731 X-OriginatorOrg: citrix.com On 23/03/2021 09:58, Roger Pau Monne wrote: > diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_= x86.c > index 091aeb70c9c..13c2972ccd3 100644 > --- a/tools/libs/guest/xg_cpuid_x86.c > +++ b/tools/libs/guest/xg_cpuid_x86.c > @@ -966,3 +966,70 @@ int xc_cpu_policy_get_msr(xc_interface *xch, const x= c_cpu_policy_t policy, > free(msrs); > return rc; > } > + > +int xc_cpu_policy_update_cpuid(xc_interface *xch, xc_cpu_policy_t policy= , > + const xen_cpuid_leaf_t *leaves, > + uint32_t nr) > +{ > + unsigned int err_leaf =3D -1, err_subleaf =3D -1; > + unsigned int nr_leaves, nr_msrs, i, j; > + xen_cpuid_leaf_t *current; > + int rc =3D xc_cpu_policy_get_size(xch, &nr_leaves, &nr_msrs); > + > + if ( rc ) > + { > + PERROR("Failed to obtain policy info size"); > + return -1; > + } > + > + current =3D calloc(nr_leaves, sizeof(*current)); > + if ( !current ) > + { > + PERROR("Failed to allocate resources"); > + errno =3D ENOMEM; > + return -1; > + } > + > + rc =3D xc_cpu_policy_serialise(xch, policy, current, &nr_leaves, NUL= L, 0); > + if ( rc ) > + goto out; > + > + for ( i =3D 0; i < nr; i++ ) > + { > + const xen_cpuid_leaf_t *update =3D &leaves[i]; > + > + for ( j =3D 0; j < nr_leaves; j++ ) > + if ( current[j].leaf =3D=3D update->leaf && > + current[j].subleaf =3D=3D update->subleaf ) > + { > + /* > + * NB: cannot use an assignation because of the const vs > + * non-const difference. > + */ > + memcpy(¤t[j], update, sizeof(*update)); > + break; > + } > + > + if ( j =3D=3D nr_leaves ) > + { > + /* Failed to find a matching leaf, append to the end. */ > + current =3D realloc(current, (nr_leaves + 1) * sizeof(*curre= nt)); > + memcpy(¤t[nr_leaves], update, sizeof(*update)); > + nr_leaves++; > + } > + } > + > + rc =3D x86_cpuid_copy_from_buffer(policy->cpuid, current, nr_leaves, > + &err_leaf, &err_subleaf); Why do you need any earlier logic?=C2=A0 x86_cpuid_copy_from_buffer() alrea= dy does exactly this operation. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 01 14:56:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 14:56:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104594.200233 (Exim 4.92) (envelope-from ) id 1lRykk-0008AH-BF; Thu, 01 Apr 2021 14:56:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104594.200233; Thu, 01 Apr 2021 14:56:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRykk-0008AA-7z; Thu, 01 Apr 2021 14:56:58 +0000 Received: by outflank-mailman (input) for mailman id 104594; Thu, 01 Apr 2021 14:56:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRykj-0008A4-1E for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 14:56:57 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRykh-0008B8-HE; Thu, 01 Apr 2021 14:56:55 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lRykh-0003kS-BF; Thu, 01 Apr 2021 14:56:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=rfgmK8b3v2wrnOQZH/HmOldZxQezvqRdiK53LCZCLKg=; b=Yht5N5XR3g4reB06REhcxUGQLI ticfeF3lexnbto1XPZ16QqDvXCkQdwHagsATzPoMkZihka5nXyJjhBvBfvI52JttLNemcyW2FItwX ceheQrAnkPcB8VCKeI5q5fJo156XcZq9uRd59EiHDsvK5WB9W2luiWjSF9So8XRpl6PE=; Subject: Re: [PATCH 02/23] lib: move 64-bit div/mod compiler helpers To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <0fec827f-bb0b-4ea1-7757-9c27e9138be7@suse.com> From: Julien Grall Message-ID: <008a8b14-8f58-2127-9e97-87c696e07b5e@xen.org> Date: Thu, 1 Apr 2021 15:56:53 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <0fec827f-bb0b-4ea1-7757-9c27e9138be7@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Jan, On 01/04/2021 11:19, Jan Beulich wrote: > These were built for 32-bit architectures only (the same code could, > with some tweaking, sensibly be used to provide TI-mode helpers on > 64-bit arch-es) - retain this property, while still avoiding to have > a CU without any contents at all. For this, Arm's CONFIG_64BIT gets > generalized. > > Signed-off-by: Jan Beulich > --- > xen/arch/Kconfig | 2 ++ > xen/arch/arm/Kconfig | 12 +++--------- > xen/arch/x86/Kconfig | 1 + > xen/common/Makefile | 1 - > xen/lib/Makefile | 4 ++++ > xen/{common/lib.c => lib/divmod.c} | 2 -- > 6 files changed, 10 insertions(+), 12 deletions(-) > rename xen/{common/lib.c => lib/divmod.c} (99%) > > diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig > index d144d4c8d3ee..f16eb0df43af 100644 > --- a/xen/arch/Kconfig > +++ b/xen/arch/Kconfig > @@ -1,3 +1,5 @@ > +config 64BIT > + bool > > config NR_CPUS > int "Maximum number of CPUs" > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index 330bbf6232d4..ecfa6822e4d3 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -1,17 +1,11 @@ > -config 64BIT > - bool > - default "$(ARCH)" != "arm32" > - help > - Say yes to build a 64-bit Xen > - Say no to build a 32-bit Xen > - > config ARM_32 > def_bool y > - depends on !64BIT > + depends on "$(ARCH)" = "arm32" > > config ARM_64 > def_bool y > - depends on 64BIT > + depends on !ARM_32 > + select 64BIT > select HAS_FAST_MULTIPLY > > config ARM > diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig > index f79e6634db3f..4d6911ffa467 100644 > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -1,5 +1,6 @@ > config X86_64 > def_bool y > + select 64BIT > > config X86 > def_bool y > diff --git a/xen/common/Makefile b/xen/common/Makefile > index 71c1d466bd8f..e2a7e62d14bf 100644 > --- a/xen/common/Makefile > +++ b/xen/common/Makefile > @@ -21,7 +21,6 @@ obj-y += kernel.o > obj-y += keyhandler.o > obj-$(CONFIG_KEXEC) += kexec.o > obj-$(CONFIG_KEXEC) += kimage.o > -obj-y += lib.o > obj-$(CONFIG_LIVEPATCH) += livepatch.o livepatch_elf.o > obj-$(CONFIG_MEM_ACCESS) += mem_access.o > obj-y += memory.o > diff --git a/xen/lib/Makefile b/xen/lib/Makefile > index 0b274583ef0b..a5dc1442a422 100644 > --- a/xen/lib/Makefile > +++ b/xen/lib/Makefile > @@ -10,3 +10,7 @@ lib-y += rbtree.o > lib-y += sort.o > lib-$(CONFIG_X86) += xxhash32.o > lib-$(CONFIG_X86) += xxhash64.o > + > +lib32-y := divmod.o > +lib32-$(CONFIG_64BIT) := > +lib-y += $(lib32-y) > diff --git a/xen/common/lib.c b/xen/lib/divmod.c > similarity index 99% > rename from xen/common/lib.c > rename to xen/lib/divmod.c > index 5b8f49153dad..0be6ccc70096 100644 > --- a/xen/common/lib.c > +++ b/xen/lib/divmod.c > @@ -40,7 +40,6 @@ > * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF > * SUCH DAMAGE. > */ > -#if BITS_PER_LONG == 32 In theory BITS_PER_LONG == 32 is not quite the same as 32-bit arch. Can you clarify whether this code is necessary on 64-bit arch where long is only 32-bit. Cheers? -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Apr 01 14:59:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 14:59:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104597.200245 (Exim 4.92) (envelope-from ) id 1lRymq-0008Ig-Ns; Thu, 01 Apr 2021 14:59:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104597.200245; Thu, 01 Apr 2021 14:59:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRymq-0008IZ-Kl; Thu, 01 Apr 2021 14:59:08 +0000 Received: by outflank-mailman (input) for mailman id 104597; Thu, 01 Apr 2021 14:59:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRymp-0008IE-FK for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 14:59:07 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRymn-0008Eg-K8; Thu, 01 Apr 2021 14:59:05 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lRymn-0003sq-AV; Thu, 01 Apr 2021 14:59:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=2B2XnEBGxheZeGJhpPXhoq9u+sbeaGLw7S4APvBqSFM=; b=QmZ/vYV2/VcLujh3+TKxC+AKnP +d3x793PJDQidsVwEb1carpRDFIu/dd3Ddw6+D/fXtNPid5ihyn4OWtMSXmtSE902wC4uB6e1TODh mC+zJ36qbJvySLlfP7u38FcWNXdsDlCxZu815jsvk0WcqyNXSBlWyNkMtvstk2+ep14o=; Subject: Re: [PATCH 03/23] string: drop redundant declarations To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: From: Julien Grall Message-ID: <69ccb1f4-12c8-b3ce-3271-16e19908cce1@xen.org> Date: Thu, 1 Apr 2021 15:59:03 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Jan, On 01/04/2021 11:20, Jan Beulich wrote: > These standard functions shouldn't need custom declarations. The only > case where redundancy might be needed is if there were inline functions > there. But we don't have any here (anymore). Prune the per-arch headers > of duplicate declarations while moving the asm/string.h inclusion past > the declarations. > > Signed-off-by: Jan Beulich Acked-by: Julien Grall Cheers, > > --- a/xen/include/asm-arm/string.h > +++ b/xen/include/asm-arm/string.h > @@ -8,41 +8,21 @@ > */ > > #define __HAVE_ARCH_STRRCHR > -char *strrchr(const char *s, int c); > - > #define __HAVE_ARCH_STRCHR > -char *strchr(const char *s, int c); > - > #if defined(CONFIG_ARM_64) > #define __HAVE_ARCH_STRCMP > -int strcmp(const char *, const char *); > - > #define __HAVE_ARCH_STRNCMP > -int strncmp(const char *, const char *, size_t); > - > #define __HAVE_ARCH_STRLEN > -size_t strlen(const char *); > - > #define __HAVE_ARCH_STRNLEN > -size_t strnlen(const char *, size_t); > #endif > > #define __HAVE_ARCH_MEMCPY > -void *memcpy(void *, const void *, size_t); > - > #if defined(CONFIG_ARM_64) > #define __HAVE_ARCH_MEMCMP > -int memcmp(const void *, const void *, size_t); > #endif > - > #define __HAVE_ARCH_MEMMOVE > -void *memmove(void *dest, const void *src, size_t n); > - > #define __HAVE_ARCH_MEMSET > -void *memset(void *, int, size_t); > - > #define __HAVE_ARCH_MEMCHR > -void *memchr(const void *, int, size_t); > > #if defined(CONFIG_ARM_32) > > --- a/xen/include/asm-x86/string.h > +++ b/xen/include/asm-x86/string.h > @@ -2,15 +2,12 @@ > #define __X86_STRING_H__ > > #define __HAVE_ARCH_MEMCPY > -void *memcpy(void *dest, const void *src, size_t n); > #define memcpy(d, s, n) __builtin_memcpy(d, s, n) > > #define __HAVE_ARCH_MEMMOVE > -void *memmove(void *dest, const void *src, size_t n); > #define memmove(d, s, n) __builtin_memmove(d, s, n) > > #define __HAVE_ARCH_MEMSET > -void *memset(void *dest, int c, size_t n); > #define memset(s, c, n) __builtin_memset(s, c, n) > > #endif /* __X86_STRING_H__ */ > --- a/xen/include/xen/string.h > +++ b/xen/include/xen/string.h > @@ -4,11 +4,6 @@ > #include /* for size_t */ > > /* > - * Include machine specific inline routines > - */ > -#include > - > -/* > * These string functions are considered too dangerous for normal use. > * Use safe_strcpy(), safe_strcat(), strlcpy(), strlcat() as appropriate. > */ > @@ -17,97 +12,78 @@ > #define strncpy __xen_has_no_strncpy__ > #define strncat __xen_has_no_strncat__ > > -#ifndef __HAVE_ARCH_STRLCPY > size_t strlcpy(char *, const char *, size_t); > -#endif > - > -#ifndef __HAVE_ARCH_STRLCAT > size_t strlcat(char *, const char *, size_t); > -#endif > +int strcmp(const char *, const char *); > +int strncmp(const char *, const char *, size_t); > +int strnicmp(const char *, const char *, size_t); > +int strcasecmp(const char *, const char *); > +char *strchr(const char *, int); > +char *strrchr(const char *, int); > +char *strstr(const char *, const char *); > +size_t strlen(const char *); > +size_t strnlen(const char *, size_t); > +char *strpbrk(const char *, const char *); > +char *strsep(char **, const char *); > +size_t strspn(const char *, const char *); > + > +void *memset(void *, int, size_t); > +void *memcpy(void *, const void *, size_t); > +void *memmove(void *, const void *, size_t); > +int memcmp(const void *, const void *, size_t); > +void *memchr(const void *, int, size_t); > +void *memchr_inv(const void *, int, size_t); > + > +#include > > #ifndef __HAVE_ARCH_STRCMP > -int strcmp(const char *, const char *); > #define strcmp(s1, s2) __builtin_strcmp(s1, s2) > #endif > > #ifndef __HAVE_ARCH_STRNCMP > -int strncmp(const char *, const char *, size_t); > #define strncmp(s1, s2, n) __builtin_strncmp(s1, s2, n) > #endif > > -#ifndef __HAVE_ARCH_STRNICMP > -int strnicmp(const char *, const char *, size_t); > -#endif > - > #ifndef __HAVE_ARCH_STRCASECMP > -int strcasecmp(const char *, const char *); > #define strcasecmp(s1, s2) __builtin_strcasecmp(s1, s2) > #endif > > #ifndef __HAVE_ARCH_STRCHR > -char *strchr(const char *, int); > #define strchr(s1, c) __builtin_strchr(s1, c) > #endif > > #ifndef __HAVE_ARCH_STRRCHR > -char *strrchr(const char *, int); > #define strrchr(s1, c) __builtin_strrchr(s1, c) > #endif > > #ifndef __HAVE_ARCH_STRSTR > -char *strstr(const char *, const char *); > #define strstr(s1, s2) __builtin_strstr(s1, s2) > #endif > > #ifndef __HAVE_ARCH_STRLEN > -size_t strlen(const char *); > #define strlen(s1) __builtin_strlen(s1) > #endif > > -#ifndef __HAVE_ARCH_STRNLEN > -size_t strnlen(const char *, size_t); > -#endif > - > -#ifndef __HAVE_ARCH_STRPBRK > -char *strpbrk(const char *, const char *); > -#endif > - > -#ifndef __HAVE_ARCH_STRSEP > -char *strsep(char **, const char *); > -#endif > - > -#ifndef __HAVE_ARCH_STRSPN > -size_t strspn(const char *, const char *); > -#endif > - > - > #ifndef __HAVE_ARCH_MEMSET > -void *memset(void *, int, size_t); > #define memset(s, c, n) __builtin_memset(s, c, n) > #endif > > #ifndef __HAVE_ARCH_MEMCPY > -void *memcpy(void *, const void *, size_t); > #define memcpy(d, s, n) __builtin_memcpy(d, s, n) > #endif > > #ifndef __HAVE_ARCH_MEMMOVE > -void *memmove(void *, const void *, size_t); > #define memmove(d, s, n) __builtin_memmove(d, s, n) > #endif > > #ifndef __HAVE_ARCH_MEMCMP > -int memcmp(const void *, const void *, size_t); > #define memcmp(s1, s2, n) __builtin_memcmp(s1, s2, n) > #endif > > #ifndef __HAVE_ARCH_MEMCHR > -void *memchr(const void *, int, size_t); > #define memchr(s, c, n) __builtin_memchr(s, c, n) > #endif > > -void *memchr_inv(const void *, int, size_t); > - > #define is_char_array(x) __builtin_types_compatible_p(typeof(x), char[]) > > /* safe_xxx always NUL-terminates and returns !=0 if result is truncated. */ > -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Apr 01 15:05:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 15:05:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104600.200257 (Exim 4.92) (envelope-from ) id 1lRysi-0000p2-E9; Thu, 01 Apr 2021 15:05:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104600.200257; Thu, 01 Apr 2021 15:05:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRysi-0000ov-B7; Thu, 01 Apr 2021 15:05:12 +0000 Received: by outflank-mailman (input) for mailman id 104600; Thu, 01 Apr 2021 15:05:10 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRysg-0000oq-8u for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 15:05:10 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b57ca2b0-371c-4283-9e96-969093e2fbb4; Thu, 01 Apr 2021 15:05:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b57ca2b0-371c-4283-9e96-969093e2fbb4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617289508; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=eoJCUGWPEZDvA6Yg8CLrgwQ24zajYTDTqaaCkalI14M=; b=J7+YD4kYfauGj2H8e3ahlzEbsqRA2hBdm8RfO+vM50zHJHNA/C/nibnW 9T2X3i2Fj3qbyIsenhvIIHBRfIFt6o9xGAiTntxAFr3cP5cchlpuVFO2N YXzD4aUKXRSp3b4pEgZ87HSGW7+brLsD1jHU6MoV28KyY0Cl0qg6hz3Uw s=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: TEVvGx3fX4bQ2WFKIFxySNFf/+g79IiNpFxBCyAuLGqRKvk7pe6zHM3Atvw2fp4XGvzKUNQSrB 7ccIdHdSMXgTnesm5tuHaqdwweySV7oTX2Pbgeh/3KtyPnOrzgvvAWFxH2eUITiujrJtUJc/Gx 3Csw7hYbISvoe29j9TdP3lKerLQphD9Kp71iJAq8ttXil20brlIoam7rEzjN71QdVWhhH1twEv 0IwcWYqajEkqH6lXQ59qExyPNXOhQuEKzZ7S0K9czMC9jSOsGxc0nxUmlSzkyUgL4gihMxcJIS CTE= X-SBRS: 5.2 X-MesageID: 40847832 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:L3WlXq7Jrncyz3aAkgPXwWWEI+orLtY04lQ7vn1ZYSd+NuSFis Gjm+ka3xfoiDAXHEotg8yEJbPoexzh3LZPy800Ma25VAfr/FGpIoZr8Jf4z1TbdxHW3tV2kZ 1te60WMrDNJHBnkMf35xS5Gd48wN+BtJuln/va0m0Fd2BXQotLhj0JbzqzOEtwWQVAGN4dHJ 2T+sJIq1ObCAsqR+68AWQIWPWGmsbCk4jobQVDKxks7gSPij3A0s+HLzGz2BACXzRThYoz6G StqX2F2oyPkdGejiXd2Wja8ohMlLLapOdrKcSQhqEuW03RoymyYoAJYczkgBkUp6WV5E8ugJ 3wpX4bTr5OwlfwWk3wnhf3wQnn118Vmgzf4HuVm2Hqr8C8ZB9SMbs5uatjfhHU61UtsbhHuc ohtQLp1OsjMTr6kCvw/NTOXR1x/3DExUYKquIPk2dZFbIXdb45l/1uwGpuDJwCECjmgbpXdt VGMce03oc1TXqndXzD+kFgzNuwN05DZSuucwwpv8yY1CVuh3Zpz0cU79x3pAZwyLsND7ZD/O jKKaJuifVnSdIXd7t0AKM7TdKwEXGle2OCDEuiZXDcUI0XMXPErJD6pJ0z+eGRYZQNiL8/go 7IXl90vXM7EnieR/Gm7dluyFTgUW+9VTPixoV1/J5ioIDxQ7LtLGmqVE0uu9HImYRdPuTrH9 KIfL5GCf7qKmXjXaxT2RflZpVUIX4CFOUIp9cAXU6UqM6jEPyrisXrNNLoYJb9GzctXW3yRl EZWiLoGclG5ke3HlDihhz8XG7sZ1zf8Zp8HLOyxZlX9KE9cql39iQFg1Ww4c+GbRdYtLYtQU d4KLT71oO3zFPGuVrg3iFMAF5wH0xV6LLvXzdhvgkRKX75dr4FppG6cWBW132XGw9nQ6rtYU lijmUy3ZjyA42bxCgkBd7iGHmdlWEvqHWDSIpZvaGf+8H/eNcdAow9UKJ8USXHfiYF2DpCmS NmUkspV0XfHjThheGOl5oPHtzScNF6nUOMOs5bqXXWsG2GvsExTn4nXzqjOPTnwzoGdn5xvB lc4qUfiL2PlXKEMm0kmtk1N1VKdSCqGr5cNR+EY49Vg7jvXwl1QQ6x9HqnoiB2XlCv21QZh2 TnIyHRXf3QGFJStkpV1bvQ/Epuen+QeF9xbX5GoZRwfF62yEpb4KuuXO6ewmGRYlwNzqUmPD bJbSA7Dyluy9q0vSTl0gqqJDED/NEDL+bdBLMsf/XvwXurMpSPjrxDNeRT5oxZONfntfIrXe qTdxSOFi7xD/ok1mWu1y8YERgxjENhveLj2RXj4mT94WU2BuDKJk96A54cONOR4gHfNr+1+a Q8qehwm+S+Mm/8MIHbjY7WaiNOMRPVryqdSfoypZVdoKI1s/9SEvDgIEz1/UAC+C97CsH+0H 46auBcxpvqP4d0Zcwcey5D5DMS5Z+yBXpuljazO/M0eFEmsmTSMNyI6YfZsLZHODz0mCLAfX 2ktxBH9/jLXyG/xacXJqI5L2NRclU94h1ZjZW/XryVLAWhbOdY+lWmdle7bb9GUaCAcI9g4y pS0pWtn+WNcTD/1x2VlTxnIrhW+2LiZc+pGgqDFapp9NO9UG78zpeC0YqWjD3tTyG8ZFldrY pZdVYIZsAGswIctuQMo2CPY52yhFkknVtY6SxmkVCo+rHO2hakIWh2dSvDgptXWjFPNGOvls qty5nB6EjA X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="40847832" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AP4xvwbSJzC4xHVWIkcJkPAfal38RfL1MwHrImyvfkJ/th8cqd6ps22RDBhBQiGB4Epwkdotcvq1iyRswfbE2fY8Kw5G34sOagykNdNZYNstQDkm5+/+56fwUuIVS3/n+zjRYHn6adMi/EGer0gElcMa0UCE4cBLoH/hry/ESivknJRrg4+2ULNlLD8FIMMBYq5p91aKN21hg+tfx0wCdhausAuVg0EYJxpMlrbI/pTHR+7eE6ptOP51qksEt55oXkKxdPV7uUnXjpf81kBlTqxv+1ZbCrQP/8n69894vyWecCghDwAhoEri/o3RXOAxuTR9T8YUol2I9qsFGciMMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mnfgfRZjGRorKcqd+4krhtohz7Ns1X3vDqoDDV02YgA=; b=lCbo92phgdio8S7R4uB+pceP/cf065JyoXPEw3GQhlT5Nji+gcjTZM4/IevKk2qG/cFAx7KWPfkQgbUJO3mr2jSrx695nyBkkcib3BbyV0upPEAf9lE1CwMN3mSUAM5ItXGIcClad5Dww0T33ppMsES8YrutsXMfsfPeF+h6Ig1It/xCzmCBTo+sBFK/LhBx/tL3pyuYFAnL2+95980epCBL0u5TuV2ORdtt1rJj+QvFklC9SqNuTrxyVH5ykilgAHqXvBVeG5OuThRiQrhFewmd3q7HSxRm2vt0Gqbrw2Qh398cYhyDFDbzstAZ9WlUOuiOLuuh+L2gswi7He5k/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mnfgfRZjGRorKcqd+4krhtohz7Ns1X3vDqoDDV02YgA=; b=YMRhrkkgeU1Bf7tXODY1TrDxpePioel1wXx2xDzkim43f9yyai3ziWuUKXPlcKlTrhOr2WdGcs+Vhcy0sEz+woCs7YJYRnQXECbULlpV2qRcaE29T5sbBPvE38wLcThQuPXo/MR/YFYhG0DvX8Uhrrkt6IsbhSwA3OlUz0WRSO8= To: Roger Pau Monne , CC: Ian Jackson , Wei Liu References: <20210323095849.37858-1-roger.pau@citrix.com> <20210323095849.37858-14-roger.pau@citrix.com> From: Andrew Cooper Subject: Re: [PATCH 13/21] libs/guest: switch users of xc_set_domain_cpu_policy Message-ID: <1cfae8d7-3708-79e2-715d-dea7f7ff5b2e@citrix.com> Date: Thu, 1 Apr 2021 16:04:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <20210323095849.37858-14-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0446.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::26) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 347cbfd8-3d57-427f-b132-08d8f51f7657 X-MS-TrafficTypeDiagnostic: BN3PR03MB2372: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1443; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x4/uLrhNxjHwZKfDRzuVA9gNKPJW79/eez13klzvnwVKiswKWKAPN89vg1Zw4dijfJTWKBxf5U4UbQTe6lJoj4mKyZPCt0fBQee0OUgiEQnQ/5yJsTGpoOpT9BE8dMj8yjvyTXHZ49VMGVGgnRanZcsXy11GJmDD6v1vKr+lYIwo7A9rCGUNrTBYRI1O2RUiH3IDWRT3CsBTyLokVHoxajzPga7oTChEBS3p4JIeJ2j+TRCuC1UUO6lcuO4O5no8UBqLBgQ2nXfxnddlFG6RDhvzRekdNA40utMgHSLd2Aq8IMedTQjVDY4RgazCFFclcybPGtrL/HV4t/+XBYz06yMae4RWAhb2J6whsVWqL6keaWKjVqloBut8gl/jmSSXEL0Yzl9HbHScV0QuDKCIW6qa0DGlA45pKkK9C2Jvs+CX7cIcdI1HU+2hoHsL0LECRkcCvCooQP2GJDRMtBLEaOhjdfMOL5X01ERk6Fpq28MJcvj6aMf7dYWWaUJqg8yuPoEcb3sdKgARwMu+dMW0MIuBWz4gNrItzC0roBkXt5PAVmeGDAKIBEjeeREuD4M21GJPrWlS5ABjF89l9X9L/5ojOEj1QQ88jqnZAnr1loElK2G4uc6D14tbLef2ToRVFwK7HHRqYWBpqxe7mrGbWT7T5OQuufT4+UDpLVip3J7n3aTgpTBdQP/ibtq6utpAxIZ5FQ18z9Iq55lpmJeMtjcVPdOyADmkgczvgUsgVpQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(376002)(366004)(346002)(396003)(39860400002)(8676002)(31686004)(8936002)(31696002)(6666004)(2616005)(186003)(956004)(54906003)(83380400001)(16526019)(26005)(6486002)(36756003)(86362001)(16576012)(66946007)(316002)(478600001)(4326008)(38100700001)(53546011)(66556008)(66476007)(5660300002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?VzJFdHBNWUU3ck1ISks1SmZScmk4bFlEaW1FcXRIYndHUGFuQVFESm01d29Z?= =?utf-8?B?SGYyeEljNXVtQkhYRkcwMUZueXJsSDk2WUV4VXNtVHlzWC9nN3ZKSmJONkNN?= =?utf-8?B?a2c1eHN2eEpPa3VDZ0NQWlRXTFJNTWNDUSs4RUZDN3NWSzFvWmtNNThYNDBV?= =?utf-8?B?bUNPcTNIUVNQUUxkK0tTdmxHNXl3RkJ1RUNMTnRKd1p1TVY4M05GZm11RnFx?= =?utf-8?B?WmxqZEFuNS85Ty9Oa3pDMmNSODlJVVZuRER1ZkVlaUNDRXY2VkNKYjJXSU1Q?= =?utf-8?B?Nmt2OGlFWW1QT3pWNEdPUzZBY3EwLy93UE94dGRicFRIbVF4b3BFc3k1WU5o?= =?utf-8?B?UWVQS3pKZFVVTFhBRVU0Y0hMK1B4UnNrV2tYaHpnK1hpUFh4dUR0c1hjMzZr?= =?utf-8?B?OEx4Uld1c25GWG9jYWJQaG04aVpreGsrOUV3OE5RcGNvVFRScHk0c2orYkVM?= =?utf-8?B?WXVJbEEwTFFMZnhLd1A1UUtuM3hsajdaRldoSmZ5U0ZsSVQrQ0YwdkJNeGVw?= =?utf-8?B?YlU1TFJvd0F3QUdldmxJN0lBaXMxZ3A3VkZJVkt1MEJLcld2V0FTSkdhR2Zy?= =?utf-8?B?dTY1S3VyL1VqZ3dINXJQNVVyTHJNTGp3OXoybytUVHkrN0tjL2ZRekE1SmpU?= =?utf-8?B?N1ZTNjhEQXNGZXFBOVdzYUpkS29qWk1QNE1FQSthdnNBcitQMWk1aFVlL21T?= =?utf-8?B?di9jNFIvc1NrM0dPQk9ZKzZDT0psWWMraGorSCtHZFFiMWhDc3JpRmIyT1Fp?= =?utf-8?B?TUVhb1Y0MG43cGhiS3NiTkJ2NlhDTmVGWXd3d0lrdUQxRWJTb3hQUzRHZDYz?= =?utf-8?B?eDcvVU5iUEh5MVhVSmwweFBjaXlDa2FQZ1dkOW5iSHRFVjBYb3BBc2FybUk4?= =?utf-8?B?ZTg4SkRhVDBHU081bU5wVzZUTTVoZzNrRitpYkIxdkdqbDJPNXo4QS9XbzRi?= =?utf-8?B?dkQ1V3doVjgzUEN0RFNMT0UzZktSZFVNSXUreGo1akNVaXFhb3BCQVJPalcy?= =?utf-8?B?aEw2MzV5NFY2TXhpSWN5ejJkMmhiODYvRmp3VUNJWnhKUDd1RXFMOTU5dGM4?= =?utf-8?B?OGhSM1VxaEVVZWM4MjYwUUJYYk5XSTRGekQxQkZyOGZmUElnRG9EaU1iODJy?= =?utf-8?B?SXZNU3h4K2h2S09COEw0L043Vy94bDY5c0xyaU1udHc2U3dNKzUwTktuU1Js?= =?utf-8?B?WmIyRjBtdXBlSXUyU0tsNjF3UVdDZGgxVEMxTC9uMkdIY3U2azZQclpSakdz?= =?utf-8?B?bVZGY2FQU0dLbE5QMTNhSHZwcEVFNFVGWERsakZUTkkvOHFHZnFsMGhYNTdV?= =?utf-8?B?dTlLdjN4bXVnTXRvZTNmYmZVUG4vcEsxeE5jbjlLZ0tDOTd6ZUt4K01VY2VR?= =?utf-8?B?d0EyNXZlN2tiaUJreGlTb29FdUsrVlNpQjI0aXVvenRyK05yK2ozYm1Xa1R5?= =?utf-8?B?WkhmTmplLzRzRDhsbXJMT0Y5NFhOdjNTMWdhaGlYbHlKcGlVSjZ3d0s4TnJQ?= =?utf-8?B?UWhMT1hvM09YOU5HMVVacmNxNmt1RFFUWTdIdlYzM0J0SlNZZHJBZ2xjZysx?= =?utf-8?B?Tk11eWMzd3JnQmwwQnlDVnAwZ0lBQ3B2ZDFOWWN3dlVoTzhUWEt2U3pOUUo5?= =?utf-8?B?RWNkOFl4QnpDby9CZEQ5dFRCTUY0OWZ5cWQ2ekdJc3lRbkZielFCVVBONUZN?= =?utf-8?B?L05tK0EyUXJ4dWJNTi82dVUrT1JYNzBHTGd4b3VTdFhDbHhVZVdBSEdHTlY5?= =?utf-8?Q?KlxZ5GpcjPFCicWWURbswndHoNvshTT8dHL0mKI?= X-MS-Exchange-CrossTenant-Network-Message-Id: 347cbfd8-3d57-427f-b132-08d8f51f7657 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 15:04:35.3403 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: C28o7fiYjatAfz0usAIXjYxok8YPgYyWnsLWNOclD5CxGw01FpBSmGrkuFNg9A4OqMPwSgGbpPBIG98SGHMrqZhmV1Crz9fzdEEbuHV2yms= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2372 X-OriginatorOrg: citrix.com On 23/03/2021 09:58, Roger Pau Monne wrote: > To use the new cpu policy interface xc_cpu_policy_set_domain. Note > that xc_set_domain_cpu_policy is removed from the interface and the > function is made static to xg_cpuid_x86.c for it's internal callers. > > Signed-off-by: Roger Pau Monn=C3=A9 > --- > tools/include/xenctrl.h | 5 ----- > tools/libs/guest/xg_cpuid_x86.c | 22 +++++++++++----------- > tools/libs/guest/xg_sr_common_x86.c | 28 +++++++++++++++++++++------- > 3 files changed, 32 insertions(+), 23 deletions(-) > > diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h > index 46f5026081c..164a287b367 100644 > --- a/tools/include/xenctrl.h > +++ b/tools/include/xenctrl.h > @@ -2625,11 +2625,6 @@ int xc_get_cpu_featureset(xc_interface *xch, uint3= 2_t index, > =20 > int xc_cpu_policy_get_size(xc_interface *xch, uint32_t *nr_leaves, > uint32_t *nr_msrs); > -int xc_set_domain_cpu_policy(xc_interface *xch, uint32_t domid, > - uint32_t nr_leaves, xen_cpuid_leaf_t *leave= s, > - uint32_t nr_msrs, xen_msr_entry_t *msrs, > - uint32_t *err_leaf_p, uint32_t *err_subleaf= _p, > - uint32_t *err_msr_p); > =20 > uint32_t xc_get_cpu_featureset_size(void); > =20 > diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_= x86.c > index 07756743e76..f7b662f31aa 100644 > --- a/tools/libs/guest/xg_cpuid_x86.c > +++ b/tools/libs/guest/xg_cpuid_x86.c > @@ -204,11 +204,11 @@ static int get_domain_cpu_policy(xc_interface *xch,= uint32_t domid, > return ret; > } > =20 > -int xc_set_domain_cpu_policy(xc_interface *xch, uint32_t domid, > - uint32_t nr_leaves, xen_cpuid_leaf_t *leave= s, > - uint32_t nr_msrs, xen_msr_entry_t *msrs, > - uint32_t *err_leaf_p, uint32_t *err_subleaf= _p, > - uint32_t *err_msr_p) > +static int set_domain_cpu_policy(xc_interface *xch, uint32_t domid, > + uint32_t nr_leaves, xen_cpuid_leaf_t *l= eaves, > + uint32_t nr_msrs, xen_msr_entry_t *msrs= , > + uint32_t *err_leaf_p, uint32_t *err_sub= leaf_p, > + uint32_t *err_msr_p) > { > DECLARE_DOMCTL; > DECLARE_HYPERCALL_BOUNCE(leaves, > @@ -405,8 +405,8 @@ static int xc_cpuid_xend_policy( > } > =20 > /* Feed the transformed currrent policy back up to Xen. */ > - rc =3D xc_set_domain_cpu_policy(xch, domid, nr_cur, cur, 0, NULL, > - &err_leaf, &err_subleaf, &err_msr); > + rc =3D set_domain_cpu_policy(xch, domid, nr_cur, cur, 0, NULL, > + &err_leaf, &err_subleaf, &err_msr); > if ( rc ) > { > PERROR("Failed to set d%d's policy (err leaf %#x, subleaf %#x, m= sr %#x)", > @@ -638,8 +638,8 @@ int xc_cpuid_apply_policy(xc_interface *xch, uint32_t= domid, bool restore, > goto out; > } > =20 > - rc =3D xc_set_domain_cpu_policy(xch, domid, nr_leaves, leaves, 0, NU= LL, > - &err_leaf, &err_subleaf, &err_msr); > + rc =3D set_domain_cpu_policy(xch, domid, nr_leaves, leaves, 0, NULL, > + &err_leaf, &err_subleaf, &err_msr); > if ( rc ) > { > PERROR("Failed to set d%d's policy (err leaf %#x, subleaf %#x, m= sr %#x)", > @@ -833,8 +833,8 @@ int xc_cpu_policy_set_domain(xc_interface *xch, uint3= 2_t domid, > if ( rc ) > goto out; > =20 > - rc =3D xc_set_domain_cpu_policy(xch, domid, nr_leaves, leaves, nr_ms= rs, msrs, > - &err_leaf, &err_subleaf, &err_msr); > + rc =3D set_domain_cpu_policy(xch, domid, nr_leaves, leaves, nr_msrs,= msrs, > + &err_leaf, &err_subleaf, &err_msr); > if ( rc ) > { > ERROR("Failed to set domain %u policy (%d =3D %s)", domid, -rc, > diff --git a/tools/libs/guest/xg_sr_common_x86.c b/tools/libs/guest/xg_sr= _common_x86.c > index 15265e7a331..02f0c3ae9ed 100644 > --- a/tools/libs/guest/xg_sr_common_x86.c > +++ b/tools/libs/guest/xg_sr_common_x86.c > @@ -151,7 +151,10 @@ int x86_static_data_complete(struct xc_sr_context *c= tx, unsigned int *missing) > { > xc_interface *xch =3D ctx->xch; > uint32_t nr_leaves =3D 0, nr_msrs =3D 0; > - uint32_t err_l =3D ~0, err_s =3D ~0, err_m =3D ~0; > + xc_cpu_policy_t policy =3D xc_cpu_policy_init(); > + > + if ( !policy ) > + return -1; > =20 > if ( ctx->x86.restore.cpuid.ptr ) > nr_leaves =3D ctx->x86.restore.cpuid.size / sizeof(xen_cpuid_lea= f_t); > @@ -163,14 +166,25 @@ int x86_static_data_complete(struct xc_sr_context *= ctx, unsigned int *missing) > else > *missing |=3D XGR_SDD_MISSING_MSR; > =20 > + if ( nr_leaves && > + xc_cpu_policy_update_cpuid(xch, policy, > + ctx->x86.restore.cpuid.ptr, nr_leave= s) ) > + { > + PERROR("Failed to update CPUID policy"); > + return -1; > + } > + if ( nr_msrs && > + xc_cpu_policy_update_msrs(xch, policy, > + ctx->x86.restore.msr.ptr, nr_msrs) ) > + { > + PERROR("Failed to update MSR policy"); > + return -1; > + } > + > if ( (nr_leaves || nr_msrs) && > - xc_set_domain_cpu_policy(xch, ctx->domid, > - nr_leaves, ctx->x86.restore.cpuid.ptr, > - nr_msrs, ctx->x86.restore.msr.ptr, > - &err_l, &err_s, &err_m) ) > + xc_cpu_policy_set_domain(xch, ctx->domid, policy) ) > { > - PERROR("Failed to set CPUID policy: leaf %08x, subleaf %08x, msr= %08x", > - err_l, err_s, err_m); > + PERROR("Failed to set CPUID policy"); > return -1; > } I don't think this is a good move. All it does is waste time shuffling data in userspace during the VM downtime window.=C2=A0 The format of CPUID/MSR data in the migration stream is (deliberately) already in the form to hand it straight back to Xen, and there will never be additional policy changes here (because that would break the VM). I'd just drop the patch entirely.=C2=A0 I'm not even certain if we want to remove the thin hypercall wrappers - I'm pretty sure some of my low level unit testing plans will want the raw accessors without being forced through the xc_cpuid_policy_t interface. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 01 15:05:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 15:05:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104601.200269 (Exim 4.92) (envelope-from ) id 1lRysv-0000sh-Tu; Thu, 01 Apr 2021 15:05:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104601.200269; Thu, 01 Apr 2021 15:05:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRysv-0000sa-PG; Thu, 01 Apr 2021 15:05:25 +0000 Received: by outflank-mailman (input) for mailman id 104601; Thu, 01 Apr 2021 15:05:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRysu-0000sI-Pa for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 15:05:24 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRyss-0008Md-Hy; Thu, 01 Apr 2021 15:05:22 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lRyss-0004QZ-9J; Thu, 01 Apr 2021 15:05:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=MagXW9LQlin9AFJg5UltlAylA3WVoqBWMoQH4QialPc=; b=s3ezXpeV0xGH4lwDtMkEwdEfST RFDJcHngZzSLDCln4WNncpkB1AMUi+9IxYF8nmIvWFnVHL6HkuW+aTTCCg0ehiOFiffdLdJEOC6dc uDIMNbBjzXYTTSHXi69zjx08N2wdBBvKBe0lfqSFulPF7oPtNBT3vrB3qebELuYdvFp8=; Subject: Re: [PATCH] build: centralize / unify asm-offsets generation To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: From: Julien Grall Message-ID: <089e3ff0-5633-02b4-baac-328ea8618469@xen.org> Date: Thu, 1 Apr 2021 16:05:20 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Jan, On 01/04/2021 09:33, Jan Beulich wrote: > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -341,7 +341,7 @@ _clean: delete-unfresh-files > find . \( -name "*.o" -o -name ".*.d" -o -name ".*.d2" \ > -o -name "*.gcno" -o -name ".*.cmd" \) -exec rm -f {} \; > rm -f include/asm $(TARGET) $(TARGET).gz $(TARGET).efi $(TARGET).efi.map $(TARGET)-syms $(TARGET)-syms.map *~ core > - rm -f include/asm-*/asm-offsets.h > + rm -f asm-offsets.s include/asm-*/asm-offsets.h > rm -f .banner > > .PHONY: _distclean > @@ -362,7 +362,7 @@ $(TARGET): delete-unfresh-files > done; \ > true > $(MAKE) -f $(BASEDIR)/Rules.mk -C include > - $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) asm-offsets.s > + $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) include > $(MAKE) -f $(BASEDIR)/Rules.mk include/asm-$(TARGET_ARCH)/asm-offsets.h > $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) $@ > > @@ -399,7 +399,11 @@ include/xen/compile.h: include/xen/compi > @sed -rf tools/process-banner.sed < .banner >> $@.new > @mv -f $@.new $@ > > -include/asm-$(TARGET_ARCH)/asm-offsets.h: arch/$(TARGET_ARCH)/asm-offsets.s > +asm-offsets.s: arch/$(TARGET_ARCH)/$(TARGET_SUBARCH)/asm-offsets.c > + $(CC) $(filter-out -Wa$(comma)% -flto,$(c_flags)) -S -g0 -o $@.new -MQ $@ $< > + $(call move-if-changed,$@.new,$@) > + > +include/asm-$(TARGET_ARCH)/asm-offsets.h: asm-offsets.s > @(set -e; \ > echo "/*"; \ > echo " * DO NOT MODIFY."; \ > --- a/xen/arch/arm/Makefile > +++ b/xen/arch/arm/Makefile > @@ -131,8 +131,8 @@ $(TARGET)-syms: prelink.o xen.lds > >$(@D)/$(@F).map > rm -f $(@D)/.$(@F).[0-9]* > > -asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c > - $(CC) $(filter-out -flto,$(c_flags)) -S -o $@ $< > +.PHONY: include > +include: From a generic PoV, this target is meant to generate arch-specific include. Is that correct? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Apr 01 15:09:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 15:09:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104608.200280 (Exim 4.92) (envelope-from ) id 1lRywc-00015A-Ey; Thu, 01 Apr 2021 15:09:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104608.200280; Thu, 01 Apr 2021 15:09:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRywc-000153-Bz; Thu, 01 Apr 2021 15:09:14 +0000 Received: by outflank-mailman (input) for mailman id 104608; Thu, 01 Apr 2021 15:09:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRywb-00014y-5C for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 15:09:13 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRywW-0008R0-Tb; Thu, 01 Apr 2021 15:09:08 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lRywW-0004gx-Io; Thu, 01 Apr 2021 15:09:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:References:Cc:To:From:Subject; bh=deMjVamMcrwEXOZ4vgqdc5eJf3mrR+dGWb86V9OmEgw=; b=sBdhLoBtFGLPEY7RMDDYHg1RLA hz7sXNkCl4sveLv0fEK3uCgxf45ED3H5zTb7hWBtGv+x6ox5EAnCibQy+e5964DSu7YX+FapiTC7d TrRxxJ1tYF9exKd/0Pq0hSN6EvQo/KPI1OQcTBaubHtclLbTqQ3AGylvGyUGEhO7VXco=; Subject: Re: [PATCH] xen/arm: Ensure the vCPU context is seen before clearing the _VPF_down From: Julien Grall To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, ash.j.wilding@gmail.com, Julien Grall , Volodymyr Babchuk , Dario Faggioli , George Dunlap References: <20210226205158.20991-1-julien@xen.org> <86165804-34a1-59e5-1b51-fecc60dbf796@xen.org> Message-ID: Date: Thu, 1 Apr 2021 16:09:06 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <86165804-34a1-59e5-1b51-fecc60dbf796@xen.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Hi, On 20/03/2021 11:47, Julien Grall wrote: > > > On 20/03/2021 00:01, Stefano Stabellini wrote: >> On Sat, 27 Feb 2021, Julien Grall wrote: >>> (+ Dario and George) >>> >>> Hi Stefano, >>> >>> I have added Dario and George to get some inputs from the scheduling >>> part. >>> >>> On 27/02/2021 01:58, Stefano Stabellini wrote: >>>> On Fri, 26 Feb 2021, Julien Grall wrote: >>>>> From: Julien Grall >>>>> >>>>> A vCPU can get scheduled as soon as _VPF_down is cleared. As there is >>>>> currently not ordering guarantee in arch_set_info_guest(), it may be >>>>> possible that flag can be observed cleared before the new values of >>>>> vCPU >>>>> registers are observed. >>>>> >>>>> Add an smp_mb() before the flag is cleared to prevent re-ordering. >>>>> >>>>> Signed-off-by: Julien Grall >>>>> >>>>> --- >>>>> >>>>> Barriers should work in pair. However, I am not entirely sure >>>>> whether to >>>>> put the other half. Maybe at the beginning of context_switch_to()? >>>> >>>> It should be right after VGCF_online is set or cleared, right? >>> >>> vcpu_guest_context_t is variable allocated on the heap just for the >>> purpose of >>> this call. So an ordering with VGFC_online is not going to do anything. >>> >>>> So it >>>> would be: >>>> >>>> xen/arch/arm/domctl.c:arch_get_info_guest >>>> xen/arch/arm/vpsci.c:do_common_cpu_on >>>> >>>> But I think it is impossible that either of them get called at the same >>>> time as arch_set_info_guest, which makes me wonder if we actually need >>>> the barrier... >>> arch_get_info_guest() is called without the domain lock held and I >>> can't see >>> any other lock that could prevent it to be called in // of >>> arch_set_info_guest(). >>> >>> So you could technically get corrupted information from >>> XEN_DOMCTL_getvcpucontext. For this case, we would want a smp_wmb() >>> before >>> writing to v->is_initialised. The corresponding read barrier would be in >>> vcpu_pause() -> vcpu_sleep_sync() -> sync_vcpu_execstate(). >>> >>> But this is not the issue I was originally trying to solve. Currently, >>> do_common_cpu_on() will roughly do: >>> >>>   1) domain_lock(d) >>> >>>   2) v->arch.sctlr = ... >>>      v->arch.ttbr0 = ... >>> >>>   3) clear_bit(_VFP_down, &v->pause_flags); >>> >>>   4) domain_unlock(d) >>> >>>   5) vcpu_wake(v); >>> >>> If we had only one pCPU on the system, then we would only wake the >>> vCPU in >>> step 5. We would be fine in this situation. But that's not the >>> interesting >>> case. >>> >>> If you add a second pCPU in the story, it may be possible to have >>> vcpu_wake() >>> happening in // (see more below). As there is no memory barrier, step >>> 3 may be >>> observed before 2. So, assuming the vcpu is runnable, we could start to >>> schedule a vCPU before any update to the registers (step 2) are >>> observed. >>> >>> This means that when context_switch_to() is called, we may end up to >>> restore >>> some old values. >>> >>> Now the question is can vcpu_wake() be called in // from another >>> pCPU? AFAICT, >>> it would be only called if a given flag in v->pause_flags is cleared >>> (e.g. >>> _VFP_blocked). But can we rely on that? >>> >>> Even if we can rely on it, v->pause_flags has other flags in it. I >>> couldn't >>> rule out that _VPF_down cannot be set at the same time as the other >>> _VPF_*. >>> >>> Therefore, I think a barrier is necessary to ensure the ordering. >>> >>> Do you agree with this analysis? >> Yes, I think this makes sense. The corresponding barrier in the >> scheduling code would have to be after reading _VPF_down and before >> reading v->arch.sctlr, etc. >> >> >>>>> The issues described here is also quite theoritical because there are >>>>> hundreds of instructions executed between the time a vCPU is seen >>>>> runnable and scheduled. But better be safe than sorry :). >>>>> --- >>>>>    xen/arch/arm/domain.c | 7 +++++++ >>>>>    1 file changed, 7 insertions(+) >>>>> >>>>> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c >>>>> index bdd3d3e5b5d5..2b705e66be81 100644 >>>>> --- a/xen/arch/arm/domain.c >>>>> +++ b/xen/arch/arm/domain.c >>>>> @@ -914,7 +914,14 @@ int arch_set_info_guest( >>>>>        v->is_initialised = 1; >>>>>          if ( ctxt->flags & VGCF_online ) >>>>> +    { >>>>> +        /* >>>>> +         * The vCPU can be scheduled as soon as _VPF_down is cleared. >>>>> +         * So clear the bit *after* the context was loaded. >>>>> +         */ >>>>> +        smp_mb(); >>> >>>  From the discussion above, I would move this barrier before >>> v->is_initialised. >>> So we also take care of the issue with arch_get_info_guest(). >>> >>> This barrier also can be reduced to a smp_wmb() as we only expect an >>> ordering >>> between writes. >>> >>> The barrier would be paired with the barrier in: >>>     - sync_vcpu_execstate() in the case of arch_get_vcpu_info_guest(). >>>     - context_switch_to() in the case of scheduling (The exact >>> barrier is TDB). >> >> OK, this makes sense, but why before: >> >>    v->is_initialised = 1; >> >> instead of right after it? It is just v->pause_flags we care about, >> right? > > The issue I originally tried to address was a race with v->pause_flags. > But I also discovered one with v->initialised while answering to your > previous e-mail. This was only briefly mentioned so let me expand it. > > A toolstack can take a snapshot of the vCPU context using > XEN_DOMCTL_get_vcpucontext. The helper will bail out if > v->is_initialized is 0. > > If v->is_initialized is 1, it will temporarily pause the vCPU and then > call arch_get_info_guest(). > > AFAICT, arch_get_info_guest() and arch_set_info_guest() (called from > PSCI CPU on) can run concurrently. > > If you put the barrier right after v->is_initialised, then a > processor/compiler is allowed to re-order the write with what comes > before. Therefore, the new value of v->is_initialised may be observed > before v->arch.{sctlr, ttbr0,...}. > > Hence, we need a barrier before setting v->is_initialized so the new > value is observed *after* the changes to v->arch.{sctlr, ttbr0, ...) > have been observed. > > A single smp_wmb() barrier before v->is_initialized should be sufficient > to cover the two problems discussed as I don't think we need to observe > v->is_initialized *before* v->pause_flags. Gentle ping. Does this makes sense to you? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Apr 01 15:23:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 15:23:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104611.200293 (Exim 4.92) (envelope-from ) id 1lRzAK-0002nA-Ox; Thu, 01 Apr 2021 15:23:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104611.200293; Thu, 01 Apr 2021 15:23:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRzAK-0002n3-LO; Thu, 01 Apr 2021 15:23:24 +0000 Received: by outflank-mailman (input) for mailman id 104611; Thu, 01 Apr 2021 15:23:22 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRzAI-0002my-M7 for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 15:23:22 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3e0f563c-c0bd-4f67-a4f7-83bf3d90e85b; Thu, 01 Apr 2021 15:23:21 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 63F60B178; Thu, 1 Apr 2021 15:23:20 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e0f563c-c0bd-4f67-a4f7-83bf3d90e85b X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617290600; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8IK3GLOdH0ou+vGzI9xfv152WM2AtTmLOx2bfWp3KnU=; b=gfZBD9Z3rJ5Bgg+vGhW3bQPhhLEGeysJGf+k/VQyfhxUEIbMu6+QRtOdPK81ddz0gRlamA HClKqd28r5Oc6ZmsrCRJ9M/ScA+O/yIbleX9WI1gzFnKB2/yoCjhQSqYNzfF0OtfArYtlN 2IrgyznNwJyTj5792AzQLGihHuYpnrY= Subject: Re: [PATCH 02/23] lib: move 64-bit div/mod compiler helpers To: Julien Grall Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <0fec827f-bb0b-4ea1-7757-9c27e9138be7@suse.com> <008a8b14-8f58-2127-9e97-87c696e07b5e@xen.org> From: Jan Beulich Message-ID: <0ddcecbb-dc42-ba4e-fccc-6988c7e54456@suse.com> Date: Thu, 1 Apr 2021 17:23:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <008a8b14-8f58-2127-9e97-87c696e07b5e@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 01.04.2021 16:56, Julien Grall wrote: > On 01/04/2021 11:19, Jan Beulich wrote: >> --- a/xen/common/lib.c >> +++ b/xen/lib/divmod.c >> @@ -40,7 +40,6 @@ >> * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF >> * SUCH DAMAGE. >> */ >> -#if BITS_PER_LONG == 32 > > In theory BITS_PER_LONG == 32 is not quite the same as 32-bit arch. Can > you clarify whether this code is necessary on 64-bit arch where long is > only 32-bit. Likely the compiler can get away without invoking these helpers, so the code would remain unused. I'm uncertain whether CONFIG_64BIT ought to be set for such an architecture, as we assume sizeof(long) == sizeof(void*), and hence pointers would then need to be 32-bit as well there. Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 01 15:26:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 15:26:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104614.200305 (Exim 4.92) (envelope-from ) id 1lRzCk-0002vw-6P; Thu, 01 Apr 2021 15:25:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104614.200305; Thu, 01 Apr 2021 15:25:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRzCk-0002vp-3D; Thu, 01 Apr 2021 15:25:54 +0000 Received: by outflank-mailman (input) for mailman id 104614; Thu, 01 Apr 2021 15:25:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRzCi-0002vk-RM for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 15:25:52 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 76727bc8-721c-4e13-8dbc-ad572b8c1aea; Thu, 01 Apr 2021 15:25:51 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E7607B134; Thu, 1 Apr 2021 15:25:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 76727bc8-721c-4e13-8dbc-ad572b8c1aea X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617290751; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cp8sJcc8VSQACwUA1v0L+jPn8fTDIgBPDFPOf0zdSG4=; b=EjMIx5tcO/hGjiPHTWLu79UfAk7NBf62yDZaC/TXWshu7k6hnnhrCmMT9G3dP4L97ZH8mO xG91bJQx/6LACsBHla2mqSsXU5pETSmC5i7PALkKQNFIsLUp2EiHIzudKEV3Y6euBTZruS pgxmZ0B7NZkd6Sm9aroRxW1NBm8MpxA= Subject: Re: [PATCH 00/23] further population of xen/lib/ To: Julien Grall Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <27916fa0-9ebd-a49a-bbb9-1ef47c2b5bf6@xen.org> <4f745d03-baa8-e9e6-692c-f9c9f401b766@suse.com> <6a38f0db-938b-fd13-48e6-6b538c85fe42@xen.org> <3bdbd0ba-ce7d-3814-3280-c4f628b74d93@xen.org> From: Jan Beulich Message-ID: <0d763d3a-6fcd-dd5c-803d-a52876a54f6c@suse.com> Date: Thu, 1 Apr 2021 17:25:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <3bdbd0ba-ce7d-3814-3280-c4f628b74d93@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 01.04.2021 16:55, Julien Grall wrote: > > > On 01/04/2021 15:27, Jan Beulich wrote: >> On 01.04.2021 16:04, Julien Grall wrote: >> So overall, the number of functions requiring overriding will likely be >>> pretty limited and #ifdef would be IMHO tolerable. >>> >>> Although, I would be OK with creating a file per function that are >>> already overrided. For all the others, I think this is just pointless. >> >> Well, I don't see a reason to special case individual functions. >> Plus any reasonable static library should imo have one (global) >> function per object file in the normal case; there may be very >> few exceptions. Drawing an ad hoc boundary at what currently has >> an override somewhere doesn't look very attractive to me. Plus >> to be honest while I would find it unfair to ask to further >> split things if I did just a partial conversion (i.e. invest yet >> more time), I find it rather odd to be asked to undo some of the >> splitting when I've already taken the extra time to make things >> consistent. > > I am sure each of us spent time working on a solution that some > reviewers were not necessary convinced of the usefulness and they had to > undo the series... > > In this case, you sent a large series with close to 0 commit message + a > small cover letter. So I think it is fair for a reviewer to be > unconvinced and ask for more input. > > You provided that now, I think we want a short summary (or a link to the > conversation) in each commit message. > > This will be helpful to understand why the move was made without having > to spend ages finding the original discussion. I'll add "Allow the function to be individually linkable, discardable, and overridable." to all the str*() and mem*() patch descriptions. Is that going to be good enough? Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 01 15:29:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 15:29:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104617.200317 (Exim 4.92) (envelope-from ) id 1lRzGZ-00035x-NV; Thu, 01 Apr 2021 15:29:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104617.200317; Thu, 01 Apr 2021 15:29:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRzGZ-00035q-KT; Thu, 01 Apr 2021 15:29:51 +0000 Received: by outflank-mailman (input) for mailman id 104617; Thu, 01 Apr 2021 15:29:50 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRzGY-00035l-4P for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 15:29:50 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3c554a93-b1e4-4b28-8bb5-04480519cf49; Thu, 01 Apr 2021 15:29:49 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2AA1DB134; Thu, 1 Apr 2021 15:29:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3c554a93-b1e4-4b28-8bb5-04480519cf49 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617290988; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OCvwoiBCyqyqKnKXHA4+IbDKdMQAdVKqAzcU+8F6908=; b=HJS5m5NDhHCQw4nP8ANEVkz0pIjRo05BddJ4ImBMmq36CQbVw/MbR+OJfdThgcxQRGgnP9 HeD7imCmVvlSenUvoKnt4M4lZ4aQ+RM3lPX1VkX0wt+WTIHKmGgrc9sBubkOeLYKaNQO4x o02sVmnZ3tiGWfX/qR0mU0lAahYCC+U= Subject: Re: [PATCH] build: centralize / unify asm-offsets generation To: Julien Grall Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <089e3ff0-5633-02b4-baac-328ea8618469@xen.org> From: Jan Beulich Message-ID: <7977e181-a2d4-42ac-2294-34a49f6812c3@suse.com> Date: Thu, 1 Apr 2021 17:29:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <089e3ff0-5633-02b4-baac-328ea8618469@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 01.04.2021 17:05, Julien Grall wrote: > On 01/04/2021 09:33, Jan Beulich wrote: >> --- a/xen/arch/arm/Makefile >> +++ b/xen/arch/arm/Makefile >> @@ -131,8 +131,8 @@ $(TARGET)-syms: prelink.o xen.lds >> >$(@D)/$(@F).map >> rm -f $(@D)/.$(@F).[0-9]* >> >> -asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c >> - $(CC) $(filter-out -flto,$(c_flags)) -S -o $@ $< >> +.PHONY: include >> +include: > > From a generic PoV, this target is meant to generate arch-specific > include. Is that correct? Yes, like is happening on x86 already. Jan From xen-devel-bounces@lists.xenproject.org Thu Apr 01 15:30:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 15:30:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104620.200329 (Exim 4.92) (envelope-from ) id 1lRzH3-0003tQ-1X; Thu, 01 Apr 2021 15:30:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104620.200329; Thu, 01 Apr 2021 15:30:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRzH2-0003tJ-UH; Thu, 01 Apr 2021 15:30:20 +0000 Received: by outflank-mailman (input) for mailman id 104620; Thu, 01 Apr 2021 15:30:19 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRzH1-0003tB-QP for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 15:30:19 +0000 Received: from mail-wm1-x333.google.com (unknown [2a00:1450:4864:20::333]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 842243dd-051f-4d1c-a6f8-2d0b98ec9554; Thu, 01 Apr 2021 15:30:18 +0000 (UTC) Received: by mail-wm1-x333.google.com with SMTP id y124-20020a1c32820000b029010c93864955so3044134wmy.5 for ; Thu, 01 Apr 2021 08:30:18 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:ac48:6475:41e4:208d? ([2a00:23c5:5785:9a01:ac48:6475:41e4:208d]) by smtp.gmail.com with ESMTPSA id u3sm10203825wrt.82.2021.04.01.08.30.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Apr 2021 08:30:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 842243dd-051f-4d1c-a6f8-2d0b98ec9554 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ctKzUn0Maxydea/rVCUEByI/2Y+D8SuD1VtC232Yjgo=; b=dQnXePUxnurTtxoXoogjlFshU8fZTtwvOA4oSh6RzkOic1OiH4fE7NZLB/1bKfAJiW ky3O554V+zfe2satPFK8sQHRPuz4uReUiv3vrvJgGP+RZZ6tjahkfcvlz/lPNCT+qJAT 0+WANOqWC+DemD5d0JmfcUcboKusItZH0XqoiOscK6fG2dE0VNe+k3CEadSAstFscDug WicZgXDngr9/PirWCXGxvpA70n2yiDm3VBN06CJ6gRZyGqbHNTQW+PtDS9VjNQ4CIpDj nuMrFAmdaooz3vlyB1HOjhQzxjMc/hJRF7AEnbtllC4bX/nP0+OWVByHVDwxQzMzk+I8 OJEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:cc:references :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=ctKzUn0Maxydea/rVCUEByI/2Y+D8SuD1VtC232Yjgo=; b=Cvt5Kt0re47UAEMRUOaT5pdawipMM2F2mX/x0kldpnSp2+wtRCxk30AQcDB0foNnFz 93hnPI+yKcrz4pdvaTLwLOErSKkt4zxgpRr88GEvfCoM8oz4UnhW5r71fH77uJ6bg33+ G98c3G92xMHcI9nwpfG3N4ycSfLAgAkXD8dVc6phKX3HTXZUBjAmZxgDKqXiwi6HfjML PK2V2Z/W2zYn7ZK6hFOy96K5FpXqNQkT6koJOq8G2pA7BUPJvlISSmXOCkSt+tyVoWgg oROq+C9zQKynUsw1ufEP3de01QKBv+FN0JYmL7+7I6MonM9ZNPZ7hmjXXAjv3mHqB/ms QXfg== X-Gm-Message-State: AOAM532AFaiIOkQvKvViWOD43dl5QmjkOzN3t8h6tTw9Gz+rXDdSqvig GH0dT9j7HMaWo2bkQvhDMDc= X-Google-Smtp-Source: ABdhPJywF4MI+2gExSCuT4k3JR5O617RLPZWeG6qw6CwDa/R4+Vl0UcXrU4xWkhePqvztFnAHz1+Iw== X-Received: by 2002:a05:600c:4f89:: with SMTP id n9mr8779799wmq.133.1617291017536; Thu, 01 Apr 2021 08:30:17 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH for-4.15 2/7] CHANGELOG.md: xl PCI configuration doc, xenstore MTU entries To: George Dunlap , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu References: <20210401133827.362216-1-george.dunlap@citrix.com> <20210401133827.362216-2-george.dunlap@citrix.com> Message-ID: <054f2098-0ec6-7809-74db-e71f45941c4b@xen.org> Date: Thu, 1 Apr 2021 16:30:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210401133827.362216-2-george.dunlap@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 01/04/2021 14:38, George Dunlap wrote: > Signed-off-by: George Dunlap > --- > CC: Paul Durrant > CC: Ian Jackson > CC: Wei Liu Reviewed-by: Paul Durrant > --- > CHANGELOG.md | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/CHANGELOG.md b/CHANGELOG.md > index f7ce6682b9..086a0e50d0 100644 > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -15,6 +15,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) > - Switched MSR accesses to deny by default policy. > - Intel Processor Trace support (Tech Preview) > - Named PCI devices for xl/libxl > + - Improved documentation for xl PCI configuration format > - Support for zstd-compressed dom0 (x86) and domU kernels > - Library improvements from NetBSD ports upstreamed > - CI loop: Add Alpine Linux, Ubuntu Focal targets; drop CentOS 6 > @@ -23,7 +24,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) > - x86: Allow domains to use AVX-VNNI instructions > - Factored out HVM-specific shadow code, improving code clarity and reducing the size of PV-only hypervisor builds > - Added XEN_SCRIPT_DIR configuration option to specify location for Xen scripts, rather than hard-coding /etc/xen/scripts > - > + - xennet: Documented a way for the backend (or toolstack) to specify MTU to the frontend > > ### Removed / support downgraded > > From xen-devel-bounces@lists.xenproject.org Thu Apr 01 15:33:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 15:33:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104625.200341 (Exim 4.92) (envelope-from ) id 1lRzJg-00045F-Lu; Thu, 01 Apr 2021 15:33:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104625.200341; Thu, 01 Apr 2021 15:33:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRzJg-000458-HS; Thu, 01 Apr 2021 15:33:04 +0000 Received: by outflank-mailman (input) for mailman id 104625; Thu, 01 Apr 2021 15:33:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRzJe-000453-Gx for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 15:33:02 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRzJc-0000Ol-OI; Thu, 01 Apr 2021 15:33:00 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lRzJc-0006CF-G6; Thu, 01 Apr 2021 15:33:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=4t09i6lJcaCeOqAFZogMPxgcn8hcZFRDYFfERFzoBiQ=; b=ZnqWjMdJOa/dPvy8ApezXvsCP6 fj9M7DibZQYRIX/WoivaGhYcBCKs7XkbdLjAVtQuq8vp3iJGrHPAAs7UBJKXAs5WPceDWEuhvDuzp 9ipmx6Ip+wrvmGyoUym+nhmlbCEXm8Ocj9ggX2GII3uPBmuBmoFtp8AIs9cNYWfDFS8o=; Subject: Re: [PATCH 00/23] further population of xen/lib/ To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <27916fa0-9ebd-a49a-bbb9-1ef47c2b5bf6@xen.org> <4f745d03-baa8-e9e6-692c-f9c9f401b766@suse.com> <6a38f0db-938b-fd13-48e6-6b538c85fe42@xen.org> <3bdbd0ba-ce7d-3814-3280-c4f628b74d93@xen.org> <0d763d3a-6fcd-dd5c-803d-a52876a54f6c@suse.com> From: Julien Grall Message-ID: <6eb1614d-fc16-9101-201d-9f63c2adcae7@xen.org> Date: Thu, 1 Apr 2021 16:32:58 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <0d763d3a-6fcd-dd5c-803d-a52876a54f6c@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 01/04/2021 16:25, Jan Beulich wrote: > On 01.04.2021 16:55, Julien Grall wrote: >> >> >> On 01/04/2021 15:27, Jan Beulich wrote: >>> On 01.04.2021 16:04, Julien Grall wrote: >> So overall, the number of functions requiring overriding will likely be >>>> pretty limited and #ifdef would be IMHO tolerable. >>>> >>>> Although, I would be OK with creating a file per function that are >>>> already overrided. For all the others, I think this is just pointless. >>> >>> Well, I don't see a reason to special case individual functions. >>> Plus any reasonable static library should imo have one (global) >>> function per object file in the normal case; there may be very >>> few exceptions. Drawing an ad hoc boundary at what currently has >>> an override somewhere doesn't look very attractive to me. Plus >>> to be honest while I would find it unfair to ask to further >>> split things if I did just a partial conversion (i.e. invest yet >>> more time), I find it rather odd to be asked to undo some of the >>> splitting when I've already taken the extra time to make things >>> consistent. >> >> I am sure each of us spent time working on a solution that some >> reviewers were not necessary convinced of the usefulness and they had to >> undo the series... >> >> In this case, you sent a large series with close to 0 commit message + a >> small cover letter. So I think it is fair for a reviewer to be >> unconvinced and ask for more input. >> >> You provided that now, I think we want a short summary (or a link to the >> conversation) in each commit message. >> >> This will be helpful to understand why the move was made without having >> to spend ages finding the original discussion. > > I'll add "Allow the function to be individually linkable, discardable, > and overridable." to all the str*() and mem*() patch descriptions. Is > that going to be good enough? It will be good for me. Cheers, > > Jan > -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Apr 01 16:02:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 16:02:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104628.200352 (Exim 4.92) (envelope-from ) id 1lRzm6-0007HT-UD; Thu, 01 Apr 2021 16:02:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104628.200352; Thu, 01 Apr 2021 16:02:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRzm6-0007HM-R3; Thu, 01 Apr 2021 16:02:26 +0000 Received: by outflank-mailman (input) for mailman id 104628; Thu, 01 Apr 2021 16:02:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRzm6-0007HH-9R for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 16:02:26 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRzm4-0001OQ-KH; Thu, 01 Apr 2021 16:02:24 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lRzm4-0000Gr-CV; Thu, 01 Apr 2021 16:02:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=Sv8RS+0wdbIiWMwwTW7Y/bRZsDmFGVjABoKk8ZFtJ9Y=; b=pe0YJGhRcxIzxEGjv0rYVUehP0 /d9RRrQ9nap11zTZFzUV2qvQiPPFCdgegruEUrkR5W2rpiZ2SbgJZYa0AbeW4ImDtbWe7gxZjbA4x TDe4HZIyn012wPMu1tMUOAZ9wzFKVxKz2uMYhqAKv1BWEN0fD2+TOzU3i1AXclGKVz9E=; Subject: Re: [PATCH v2 1/2] common: map_vcpu_info() cosmetics To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , Stefano Stabellini References: <2a08aa31-fdbf-89ee-cd49-813f818b709a@suse.com> <29514f9a-b630-f66e-286e-8b73fcf4d58a@suse.com> From: Julien Grall Message-ID: Date: Thu, 1 Apr 2021 17:02:22 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <29514f9a-b630-f66e-286e-8b73fcf4d58a@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Hi Jan, On 22/12/2020 08:14, Jan Beulich wrote: > Use ENXIO instead of EINVAL to cover the two cases of the address not > satisfying the requirements. This will make an issue here better stand > out at the call site. > > Also add a missing compat-mode related size check: If the sizes > differed, other code in the function would need changing. Accompany this > by a change to the initial sizeof() expression, tying it to the type of > the variable we're actually after (matching e.g. the alignof() added by > XSA-327). > > Signed-off-by: Jan Beulich > Reviewed-by: Roger Pau Monné Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Apr 01 16:14:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 16:14:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104631.200365 (Exim 4.92) (envelope-from ) id 1lRzxa-0008H4-28; Thu, 01 Apr 2021 16:14:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104631.200365; Thu, 01 Apr 2021 16:14:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRzxZ-0008Gx-Uv; Thu, 01 Apr 2021 16:14:17 +0000 Received: by outflank-mailman (input) for mailman id 104631; Thu, 01 Apr 2021 16:14:16 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRzxY-0008Gs-9o for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 16:14:16 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 189a4ce1-de21-4498-8edc-ab7bd97b2d60; Thu, 01 Apr 2021 16:14:14 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 189a4ce1-de21-4498-8edc-ab7bd97b2d60 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617293654; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=KGniY3TxAH1d6q4BTl85KomLpNVYpIDqhes70pRiAAk=; b=ZsoJqP3Ny4fXr+fc6A3K8V9/0MSaJWG2NynPAbnwlci/SOs9MZpVgaYj eKEAVuq1EtUs48+Mep7tU4OV4OkYlmhH+xBQw1Fglcza0clfWZk7xlrBW ssXtmy2dOVbFU4zlSTrgDt0YB2sytqh9B3c24eMG287yPCZSjJV8v5YzV 4=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: W+sSr3EsJ1r1kpe2A76NjLmxxPp4KwP8kQSEmwE204321Rf2jmgpCCx2I3uyy3Wt14XB9/o5KL U8vUy9Iu17P58+1T0fbBLf+6O0+b0NiFRiKt0bEFKdNvSS/u/a3ZUha2G5FvaYt1sRPM+PiodD 9HQbB4OxaxPomW2AKkh1xUKmo+JvqrNtA/CIb2hzQatmlhAbpVMgMO3wS278S7ApS3pjMOslr2 erUULXzNWtbWdA1oFuzGRB49rewuLCOAFZAwr2bDge7YVkou+5AlCVS3LRsU9myjhG9shMZMj6 hos= X-SBRS: 5.2 X-MesageID: 42172572 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:3sq7s62vahDeQfjxD/BxzAqjBR93eYIsi2QD101hICF9Wvez0+ izgfUW0gL1gj4NWHcm3euNIrWEXGm0z/FIyKErF/OHUBP9sGWlaLtj44zr3iH6F0TFmtJ1/Z xLN5JzANiYNzVHpO7n/Qi1FMshytGb8KauwdzT1WtpUBsCUcBdxi1SYzzrd3Febg9AGJY/Cd 647s1IuzKvdR0sH7uGL1MCWPXOoMCOqYnvZgQICwVixA6Fiz6p77CSKWnl4j41VTRTzbA+tV XUigCR3NTfj9iX6D/5k1XS4ZNfhcf7xrJ4avCkp8AJJlzX+36VTat7XbnqhkFTnMiO7xIQnM DIs1McOa1ImgnsV0WUhTeo5AX6yjYp7BbZuCylqF/uu9bwSj5/K+cpv/MhTjLj50AtvM5x3c twtgrz3fonbmK0oA3H69fFTB1snEavyEBS9dI7tHBDTZAYLIZYsI13xjIkLL47ACn45Io7ed Meav302fA+SyL5U1nkpGV1hPSjUnMvdy32OXQqi4i+1jhbm21B1E0IxMATtWdozuNNd7B0o8 vDKahmj7dIU4s/ar98Hv4IRY+NBnXKWg+kChPcHX3XUIU8f17doZ/+57s4oMmsZZwz1ZM33L DMSklRu2Iec1/nYPf+kqFjw1ToeiGQTD7twsZR69xSobvnXofmNiWFVRQHj9agi+93OLyZZ9 +DfLZtR9PzJ2rnHohEmyfkXYNJFHUYWMoJ/v4mRlO1pN7RIIGCjJ2aTN/jYJ7WVRo0UGL2BX UOGBLpIt9b00ytUnjkxDfLXXfAfVH+4IJQHKDW8/N78vlJCqR89iwuzXip7MCCLjNP9oYsel FlHb/hmqSn4Um6lFy4q1lBC154NAJ48b/gW3RFqUshKEXva4sOvN2ZZCR31HuDLRlvctPOHG dk1hNK0JPyC6bV6TEpCtqhPG7fpWAUvmi2Q5AVnbDGwsv5ZJUiDNIDVLZqHQvGUzx58Dwa6V trWUshfAvyBznugaKqgNg/H+fEbeRxhw+tPIpzsnLQtUKVoOk1XXsFVzuSUcqa6DxeBQZ8tx lUyesykbCAkTGgJS8Um+IjKmBBb2yRHfZ7FgifXZ5VnbrqYQl0am+PiVWh+lcOU1uv039Xqn 3qLCWSd/2OJlZGoHhX3pzn905OenyHc1h9bW17toNBBX3L00wDo9OjV+6W6S+8e1ECyuYSPH X+bTweLhhH6vq32BSW8QzyX0kO99ELBKjwHb4je7bc1jeRM4WOj7gBBOIR1o1iLsrSvugCVv +/dweZICjjMf4g3xWYqx8eSXBJgUhhtcmt9Azu7WC+0nJ6POHbJ05+QaoHZ/6b9GrpSp+zod xEpONwmdH1FGr/atSLk/6KKxFCLw7eum6wQaUDr4tOsac7qbt0GN36XFLzpQZ69SR7CP2xsk UUBJlfyvTmHKREesQJYSJX/lYzjr20XQAWmz2zJtV7RE0nin/QAsiA7LXJo4c+G0HpnnqFBX Cvtwlmu8rfVySN1bQmG7s9DGRfZk878mlj9oq5BvvtITTvU+FI51yhNHChNJdbVaieAL0Vxy wKru2grquydyDi3hrXsiY+CqVS83y/Scf3JA6XA+ZH/5ibPluL65HarPKbvXPSSTGhbV4fip AAXUsMbt5bgj1ntbYJ6EGJO+TKi3NgtUBf7zFhnkPs3YbjwF6zJzA5DSTpxrNMXTdSNXCUi9 /i6ubw7gWk3AR4 X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="42172572" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cmJT6q65j9OPctGFC89x7pQMIqKdHfcr1aC3jBSz4ZFiDKqBb9ilokiT12vUxkjrLJ8BSrJF2GOFQMOGXmHpOVmEPE52GqyRuZDcUff2aCBRZFEcCp5FPYwYSxXLyTxGgYptL7unvM8mrdb+p0qsIVnGqLQMx3i/ez7Oha0F4LUdxmigZ5Ij8/roXpGu0tRwxLALpL1CverLg7XEV8MnDeGkToAyAUrpfBJvwlXNWDL22EBlZDvgqKpIvt0UPEQGscpCSamgesWvqx6qWMyzpBoOrGVUjgID6UN4bdM6oBs6c0WORQoQARvfe4beAsvp6Xl4d060grYBAivGf+2E6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lfXPlgZ/bDUFcYMUMBa1Z1Lg5gOrCCz5BHQH0RgHPAI=; b=N89+M21xJKub4uvtScW0Z4nLriaQ5wBWaUl0pV9OMmdYW3bYPEFaFd3Oe2DmCmaHUMssbmCjDK+RU0xppWAnLj/POkZ/NisvkAoyW1wN09emZkeCMrwKDCkY0Zd8B8hwS3tgydUPznqrhTyoKfCRZw6W9m+DZhhSEHuQm2xun5o6lwVHwzm/0djF1Z1CPR7VbNJndcSHzEj4lU5WhLZK5LZDCD0HZ6K1/WppGtufpvf73o88zth/Psnoz4yk9e4LAlgFJhVHuBpfCCZPLL8CRApS+KWqnnMDYvLCMpZkEjhzo3MeJfVkUW/jPeHQKA4dydEt/8nkyt4aB3HXkHU6/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lfXPlgZ/bDUFcYMUMBa1Z1Lg5gOrCCz5BHQH0RgHPAI=; b=EwI8CQxYvfb9iy76rIEJ4WCk8MGDeyuytcJLxtm6+9SYm7n/I+PVg57tSPX+sh3r7uqYiSmToZFIvxCz7PIeIxlz4a6WcxEpqrvfZ75xlY5N85TXgDnXZsnFxW615pRgVupnjqUlpVBabqvQy7FbVoKjnqV9nFTzujRWhjgKzUA= To: Roger Pau Monne , CC: Ian Jackson , Wei Liu References: <20210323095849.37858-1-roger.pau@citrix.com> <20210323095849.37858-15-roger.pau@citrix.com> From: Andrew Cooper Subject: Re: [PATCH 14/21] libs/guest: introduce helper to check cpu policy compatibility Message-ID: Date: Thu, 1 Apr 2021 17:14:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <20210323095849.37858-15-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P123CA0047.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::35) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 609ab3b8-7e87-48f8-addb-08d8f5292e51 X-MS-TrafficTypeDiagnostic: BN9PR03MB6025: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W9eLXzk9pWQWXnr6jiLwjM/0cTSzHez54un0KxHzrtB6ql/wTCyFSWQhHD/SiKTReofppt8idnRlRTGUxZJTaNpb3agIoxktRR+BRHrjhFSgZBG6UyBgbhvIBeVBuVlbOv0nDD4f2nB5WLKroGEeucA4F5YuQIfxMK/KKYE1PN0YZTWGH/Ccy6u6SWoDka4O+rAD4u+LB30y1s0O/uYiJhWybzJupjtZ4c8oaNPfPvmxi9ikbLjQ5IVDRW9qUxtKfIOmAWAFHh1lR+/tD3wO8wFB+NWuBxsANYclYB0XCZ1zK1P+XT4acpnnxsp88FUD0GBFJVle/0m3xoUdOhlv8jESqkUwxnSDYIggq9VqCBYbqiFoLe5GHzZYXTEsG36vRJouxqZbkPZJ8/6IJ2OdxSfyI8JInj/jbDEnL39Es/hjumOtNpjJFSQmGJekd8HqlmFOuREt4gbomv4iRT1LP/fKKItJjfiTi7Ft6lpLbShlfIAWSnI11PdmiduiK5XKJ/2YrLBfA8VVIC1xKTLWQbGqGp5yYiMES2rgwvbkGpLDFQA2QR6EZ4RqnkncrWvzo/7o4adMPIyln1zXzO+0Ds8C751HOzRjK7HbNypxg5YZgHmV7yKlOUXnud9zpAvuJ4ZnaLJEg+PJCYCfcN1H/H4qJHhE7WEU44T5jHBe3G44XN9hc89nQlEcpWdziZLTxFhqLxio2FhujLuVGrq2EQikiTeqWFG7gZHijjMWI9g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(376002)(39860400002)(366004)(136003)(346002)(8676002)(31686004)(8936002)(31696002)(6666004)(2616005)(186003)(956004)(54906003)(16526019)(26005)(83380400001)(6486002)(36756003)(86362001)(66946007)(316002)(478600001)(4326008)(16576012)(38100700001)(53546011)(66556008)(66476007)(5660300002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?T0hSWWtENGFEVXBVMHRiQ1JJY1RQSXJGYXJvQ0pRcDVZM2wwY2FvNFZKczZE?= =?utf-8?B?dVR3R05BcW5WclFPQUkzZmk5NGswcFdrbHdvSXQ2b3g1OGpPeWxrZGVRdnFo?= =?utf-8?B?UGJTVGFBSmJqSHIwQW1nUzl3SzI1SjczeEVWY25UVWFGWGoxbmlpbCtwcnI1?= =?utf-8?B?RDBOZGRtQTN2cDBjdWhiSFlOMTdOYU41UjY2SGlYQW9XeWJNNE9WYnFpRVlJ?= =?utf-8?B?cHAzcHNUTURNQlhvZVM3ZlRJYmRXRzRRbWNEMmVKNkQ3Y3JSNFZwdk1OMnph?= =?utf-8?B?ZFVyQ1JRY1RBRU4rTlFRdkVKOTJiY2Q5aGU4UGpFRk5IRERFeTQzbXl5MnNI?= =?utf-8?B?Q2dnb3p2UStsT2VXckJIZi9pN3hvbmxSd2IxZ0pjeXJHM1doUENXNTFoaXN0?= =?utf-8?B?ZnNTRVZYcDFTS1V2UnJ6aWZNbjVKZlQwajZOK3Q0cmM5dGNnWkZRd0ppWnBC?= =?utf-8?B?YUJPZ2k5aEtvbzhJcHdCUnAyT3Y3OUFtSEVabEFaVGljbk5OUHZGcnAvTmdw?= =?utf-8?B?K2o2OTVLTU5nV1kvZnFCa2tYNE5DQm1RaVAxaUVHZE1wOExMekNPTDJJSTRV?= =?utf-8?B?TS9vWHBvd0s4ZVJpVy9zRlZIb1hWMFdlcUhHWnFpVGpKYXlTRUFCNHF3VDRq?= =?utf-8?B?Tm5Tc2h3OHhrVXpuUmxJYnFFY0xPaUkzcWRkTTlFSGc4bStvcmZUMkRBak0x?= =?utf-8?B?Smh1a3BuQUFia28xdGRJbUtvZ3lac0MxVGhwNU96UU1uMFJjbU1SN2F3QWRk?= =?utf-8?B?NUFuOGxjeW1vaXNoT280VmxZcGtRTjI0TUdXTFZzanNXZitaWFNsSWVZWWNC?= =?utf-8?B?RlJ1S0xnZWxxUDhYMWthbTlBa0JrY2xLTHpBTkhRNUcreXpsemtjYmdiTUxC?= =?utf-8?B?YUdpU0RJcjkyL0Y4eGFScjJCMmVHT0swM2ZDL0dGaHVVWWN2blVDNW5PNXh2?= =?utf-8?B?UFNkVjhRNkFWUElzRkNKUUVkcmQzaWRtZzBVdmRRVUgvc1YwUTdMUDRYbWNh?= =?utf-8?B?M0l6cEw4ekxIdHdmMTlWTi9TUzZJVThlc1RMTkFOMjNJSi94ZVRrR2dlbXY2?= =?utf-8?B?K2l6MkpFaWtQSFlvSVdkYVVFR1lBRllycTJySkg3VUZobTZTNy9EK0RPQmFP?= =?utf-8?B?WEF2MlhERzNFbCtVV01FWkpTeHhVNWdFOXU0WVdHYW1LemtVejR4dklLZjBW?= =?utf-8?B?NHdJWXZYMmpXd3VuSE1TcDFtVHBKbUFEaWNTMU5tdUdLTTZDNjZjQStHaTZQ?= =?utf-8?B?amlRTVQ3SitsN2xIWFRWazVTN0JpclVQeVpDL09SdnBmUkJpTy9Ic1lVcnRi?= =?utf-8?B?SWEwbWE5UytlMngxQm9IeE40WVdGWmh3NzBTU1VvdzZtdFJQR3V4NWVMYVcv?= =?utf-8?B?c2UvbzlUakhLanFpYXEwT1M5bm9mSk4vVjZ0bVpNMmZWdDRLWjl6T2VnWnJO?= =?utf-8?B?YzBlRFpCaDIyMFA0TE5nY2NnVGRkTHFUZklINFQ0U1FXZGxKb0p1d3dWaG8x?= =?utf-8?B?Y0lmQWxUaVVzK2lqdVBNUldCN3dyQ2d3SnN1N291TWZvSEZET2VwRWcvVDVj?= =?utf-8?B?VitxazZWaThsYXkxV3MxMmdIVVB2YThIcVVlWnFCU1VWYW5WdGxFbnNVUVpy?= =?utf-8?B?bmhrSXphM0dHK3V0RTRQNjkwbWtUdXV5LzQyWitkOGpZMXJ0TUN2S1EyOEta?= =?utf-8?B?NERjSDZUSGtweTcrSmI3MGlhcU9xd2JIS1JPaUJGSWwzdzF2TmF3NDBvd056?= =?utf-8?Q?veu5ihZlUBD+iHt8djVaKsbH2PSrCJ1PVv4UP1H?= X-MS-Exchange-CrossTenant-Network-Message-Id: 609ab3b8-7e87-48f8-addb-08d8f5292e51 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 16:14:09.4273 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VCeH0RWGcSCKRFX3fj1+KAbee3OzW8BX5cUMFlMhKraAF8V9qBftAs50Ae58d88phXXnGnO7Ey+B59EakAynZHwuOw9B3+xT4Y/bGe4xUCA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6025 X-OriginatorOrg: citrix.com On 23/03/2021 09:58, Roger Pau Monne wrote: > Such helpers is just a wrapper to the existing > x86_cpu_policies_are_compatible function. This requires building > policy.c from libx86 on user land also. > > No user of the interface introduced. > > Signed-off-by: Roger Pau Monn=C3=A9 > --- > tools/include/xenctrl.h | 4 ++++ > tools/libs/guest/Makefile | 2 +- > tools/libs/guest/xg_cpuid_x86.c | 17 +++++++++++++++++ > 3 files changed, 22 insertions(+), 1 deletion(-) > > diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h > index 164a287b367..165beff330f 100644 > --- a/tools/include/xenctrl.h > +++ b/tools/include/xenctrl.h > @@ -2619,6 +2619,10 @@ int xc_cpu_policy_update_cpuid(xc_interface *xch, = xc_cpu_policy_t policy, > int xc_cpu_policy_update_msrs(xc_interface *xch, xc_cpu_policy_t policy, > const xen_msr_entry_t *msrs, uint32_t nr); > =20 > +/* Compatibility calculations. */ > +bool xc_cpu_policy_is_compatible(xc_interface *xch, const xc_cpu_policy_= t p1, > + const xc_cpu_policy_t p2); Exposing this in the interface is useful and necessary. However, the operation is not commutative.=C2=A0 p1 and p2 are not interchangeable, is why the libx86 function has specifically named parameters. This distinction needs making clear at this level as well. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 01 16:14:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 16:14:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104634.200377 (Exim 4.92) (envelope-from ) id 1lRzyF-0008OA-AT; Thu, 01 Apr 2021 16:14:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104634.200377; Thu, 01 Apr 2021 16:14:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRzyF-0008O3-7N; Thu, 01 Apr 2021 16:14:59 +0000 Received: by outflank-mailman (input) for mailman id 104634; Thu, 01 Apr 2021 16:14:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRzyE-0008Nv-1k for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 16:14:58 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRzyD-0001aq-Su; Thu, 01 Apr 2021 16:14:57 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lRzyD-00015H-Ka; Thu, 01 Apr 2021 16:14:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=5qL28haLDRzebOuDwjl4n0DxnOE5PrUJOFsKvXYE9os=; b=dfhl3Byoj7EatGlpdlXjy4v0Fj mQR0yHNKMqX6GaZUNGXN+/lEeBgSUyN9HVRT2JvUn2uWhSoDTwrCufHMsgPxdquSZmcIuuloMYWsC TWx04UvNoOTvpjY8fcEG0aB4D0P1T5xkZSClnA0LPwR16dbbG5IDLyEuRCNTkG1soIAc=; Subject: Re: [PATCH for-4.15 4/7] CHANGELOG.md: Mention various ARM errata To: Jan Beulich , George Dunlap Cc: Ian Jackson , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20210401133827.362216-1-george.dunlap@citrix.com> <20210401133827.362216-4-george.dunlap@citrix.com> <330feed2-d601-8b79-3c1f-bd8be167b8eb@suse.com> From: Julien Grall Message-ID: <19cf79e4-f54b-874b-72a1-7fd6f2942c80@xen.org> Date: Thu, 1 Apr 2021 17:14:55 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <330feed2-d601-8b79-3c1f-bd8be167b8eb@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi, On 01/04/2021 15:13, Jan Beulich wrote: > On 01.04.2021 15:38, George Dunlap wrote: >> --- a/CHANGELOG.md >> +++ b/CHANGELOG.md >> @@ -26,6 +26,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) >> - Added XEN_SCRIPT_DIR configuration option to specify location for Xen scripts, rather than hard-coding /etc/xen/scripts >> - xennet: Documented a way for the backend (or toolstack) to specify MTU to the frontend >> - Some additional affordances in various xl subcommands. >> + - Added the following ARM errata: Cortex A53 #843419, Cortex A55 #1530923, Cortex A72 #853709, Cortex A73 #858921, Cortex A76 #1286807, Neoverse-N1 #1165522 > > May I suggest "Added workarounds for ..."? +1 With that: Acked-by: Julien Grall > > Jan > -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Apr 01 16:26:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 16:26:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104648.200432 (Exim 4.92) (envelope-from ) id 1lS098-0001Ay-Tt; Thu, 01 Apr 2021 16:26:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104648.200432; Thu, 01 Apr 2021 16:26:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS098-0001Ar-Qn; Thu, 01 Apr 2021 16:26:14 +0000 Received: by outflank-mailman (input) for mailman id 104648; Thu, 01 Apr 2021 16:26:14 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS098-0001Am-4o for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 16:26:14 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2301e438-3160-4975-af43-1ebefbb07aec; Thu, 01 Apr 2021 16:26:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2301e438-3160-4975-af43-1ebefbb07aec DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617294372; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=gmd06rszaos66SwKUdTiuscoqRXiPX4bsyvnbVAgmlA=; b=fWHMXDrva/CH8SH4R4JKZVL3ztCE+piAc/RHxyGDxiXIKtcZMdPblIRX Te2FQrW16ffAwvuxljffl/DArqZ2/TTzuEg+9+xcoiCs6WrGsMu+CJpXf xNuaGsZys7ymNHxN12mYeHu+yxsG+weyYK50QEXYXNgdwkKEVXC0Bw0wP 8=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: Lvmv5ILm1I3SOHhi9i8pbEIFJUjJqrGIAT1jPjGtKUjwr2vmLn8tMVIoPeCF6LSCn/n7A9doc+ XmBwKws5/Km+B4YNgrgrz4HcrwPa1vjfzoD3RdJpqt9KYk7K+WdsMn9dxUQKNyOBc3c+Bv1RxT C57SZInRTRS5y1TDm+jR2nSJneF+0IgJGnWPjzTRz+ODKEjNS2bIWXE9GlSeQDZiF9uoacssTk fp4GY90bsqK9xXUBHSFhazn/AbtXKtS2F6nq96woFCk7sVo7GQabbWb7xlh1FrVmQ/vucJanei wZE= X-SBRS: 5.2 X-MesageID: 41095869 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:DcgKqKPX6EE/pMBcT3Hw55DYdL4zR+YMi2QD/3taDTRIb82VkN 2vlvwH1RnyzA0cQm0khMroAsS9aFvm39pQ7ZMKNbmvGDPntmyhMZ144eLZqQHIMxbVstRQ3a IIScNDIfX7B1RikILe6A63D94vzLC8gdiVrM3ZyGpgShwvTqlm4RtwBArzKDwMeCBtA50lGJ 2Aovddrz27dngNKui9DH8JX+/Mzue73q7OSxgAGhIh9U2ynSqlgYSKWCSw8zU/d3d0wbkk+X XYiACR3Mmemtyy1xO07R620714g93ko+EjOOWtjYwvJizomkKUYu1aKsS/lRQUhM3q11owit nLpH4bTolOwlfcZHu8rxeo+ySI6kdI11bYxVWVgWTurKXCLVpUZfZpvo5XfgDU7EAtprhHoc R29liEvJlaBw6oplWf2/H0VgpnnkfxgX0unf97tQ07baIiaaRcpYFawUVNEJ1oJlOZ1KkbFo BVbP301bJzSxe3fnrZtm5gzJiHRXIoBCqLRUAEp4i8zyVWtGoR9TpW+OUv2lM7sL4tQZhN4O rJdo5ykqtVc8MQZaVhQM8cXMqMDHDXSx6kChPdHX3XUIU8f17doZ/+57s4oMuwfoYT8Zc0kJ PdFHRVqHA1YECrLcGVxpVE/lTsTQyGLHXQ4/Abw6I8lqz3RbLtPyHGYkspidGcr/IWBdCeVO 20PJ5QHv//PWrjEYtExGTFKtpvAEhbdPdQlscwWlqIrM6OAJbtrPbnfPHaI6eoETtMYBK8Pl IzGBzIYOlQ5EGiXXH1xDLLXWn2R0D59ZVsVKzT/+0ZzpkRJpRB2zJlzGiR14WuE3lvo6Y2dE xxLPfMiaWgv1S7+m7O8iFuIRpSDkFc5b36SHNUrQoWM0f5GIxz++m3SCR35j+qNxV/R8TZHE p0vFJs45+6KJSW2GQ/Ed69K3mbiHESvXqOSJ8ZlsS4lIPYU6J9KqxjdL16FA3NGRAwpB1jr3 1bbhQYAmXFECn1tKmjhJsIJe3WetVmmj23KcpMpX+3jzTamegfAl8gGx+nS4q+nBsnTTs8vC wKz4YvxJ673QuJBUR6quIiK1FIYHmQG9t9fXm4TbQRvKvqdgF2RXqNnhqAhXgICybX3k0Pm2 3sKjCVc/nXAlxb/mtVyLru7UkcTBTgQ2tgLn99qoFzDmLApzJ61vKKfLO61y+LZkIF2fx1Ck CyXRICZgdvzcuwzhibhXKLEmgn3IwnOoXmfcAeWqCW3nOmM4uTk64aW/dS4ZZ+Ldjr9usGS/ iWdQPQLDT2DYoSqnuoj2dgPCl/s38/l/z0nBXj8WijxXY6RePIP04OfcBpH/iMq2z/A/qY2p Rwitw4+eO2L2Xqc9aDjaXadSRKJB/fqXO/JttY4Kx8rOY3rv9+DpPbWTzH2DVc0BIyINz9mU keTK54iYqxT7NHbogXYWZU71ApnNOAIA83qQTwGPY5ZkxogHnBPd+FioC44YYHEwmEvk/3Nl ae+SEGoKuAUCuHyLIAC6U/ZW5Rc1Mx7Xx+/OWEM43cYT/aBt1r7R6/KDu6drQYVa2OXbMXpR x+68uTn+CWezHjsTqgzwdTM+ZL6SK/Xci2AAiQAuZG/NyxJESUjsKRkbCOpSayTSH+dl8Rio JEf1EBd8hPijEti4sszyi5I5aH0n4Ngh9Z+jFollnkx4ig7iPaBCh9QHLkvqk= X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="41095869" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NmR8a8zhWxHJ0XXCL6gN5fIyHVyxa9DHR6UNOtAnK/zhv+jg5uuAdct4Zrzkmsd3i1x3vxlD5O9YnX6Sb/0zsFBZT2IxjzlbG+iHldD3W7d0Yd5Xk+l9mRixqbXyTkI3hdm0sFJJQ/OkdafYmvl37Nad35UcYxTVuwHlQHugKMdrz0gVxUf3KXJ0YiJoUWKq3R7RLVEdRQk3bEkCdFeCPp1W7VHgIo6pQWalIIlQCDy7F2QXSe5jZhObKTCMZsBnbDN0oOrcMs/yy6NyYqvsRNDBSFNb5oA21Q/YdujGT2eFMYnwnTKGugD/YbA6EvrUEjH6Lp6DM3+MHSgpXq98qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gmd06rszaos66SwKUdTiuscoqRXiPX4bsyvnbVAgmlA=; b=N+7RHLs8EYm9Gmk5HBC9bPO357Tusl1U1DhQE+aFRjqs7hshpXAMTgRRi9uFJntNFctGq5LoTO4RrUWcR/Q/c0HKzGHRr2+rfKuYtz8kHvlya9hDuPhoRvdASTQQlMcynlV1sWknpnyVF3umEMSR9Xa7CmV2mOyC4GEfLfTZZPPduHsISDKNoa/FZPYEYNlnMKR1DR691QJ8vtpng0zENERBgcb6xK4kHU2RGnKfPK1cZHreeSwaaIYFW6yfIA3QNu+5XvtfX8nkB5yZ0XAsUxOL/oSkXsCdPwdJABEu3+6Ri6f7k4lVH6eIXfR5dOuTuyBTY3dMRIiPxIv3hnXCeg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gmd06rszaos66SwKUdTiuscoqRXiPX4bsyvnbVAgmlA=; b=n8/lQMkQcS792jeJAtPip3mtrN6A8V9MHbaQWjRCnPimfsZ2Q9bqR4oAaX1KhxKG27iVHDvMjCGjXGj1d/4b9ul0gVG0ytPYsNF+r3hW1Zm5W/A/aAfRHGaEe/fA3JtF3FfqgecSmER4wXbunF7OeUDriIThM75SHlxXLHmmSUs= To: Roger Pau Monne , CC: Ian Jackson , Wei Liu , Anthony PERARD References: <20210323095849.37858-1-roger.pau@citrix.com> <20210323095849.37858-16-roger.pau@citrix.com> From: Andrew Cooper Subject: Re: [PATCH 15/21] libs/guest: obtain a compatible cpu policy from two input ones Message-ID: Date: Thu, 1 Apr 2021 17:26:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <20210323095849.37858-16-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0498.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1ab::17) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 743c7773-c844-4f44-e715-08d8f52adb0e X-MS-TrafficTypeDiagnostic: BN8PR03MB5140: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wMb4XbMwZCN3LDdaYBxHZ7rPG+U1FPpk23XKbcb+3JD/5dwO7cajk5j3TvAncurVXQRjvnS2+UnGwfeF2U+rIUG8dGjcGxKY9P9tJqGoxbnpEt8Ko5thAMvu2eXbVL45kGg8Z1hSQPWMDBX+EYYXO1P3vyEjcVaru7o/agsFVwVm2MjT2DVpG3UvhumngMY2xHRBVuSP/2l5Am272mGZ3KenHewfENDy7bq6CeWmV5nXKxprXk+5WTEUHFmpCW5ydgjjErSe5ei8OVN//M/pydl8HNKtkpGMBYvrik9OBaIlGkhRXRqCI+5r2mSF3yqJCuQVYN2yXxytTowZMehV47WruTBzDKE7kshgX1w7ORoG8eQ/oExu4ntmETeVJMkc/7ryBh7oVLfQEejYgO9xbxcRW9xy3K708pMKwApgI3SB0KY69aBfgcW1yxcTD2fGqom6jQDcwdzmRwb5uab5TUevUqcRMAlsNjj3szLgckAhm1dghTxQOI+KzD25po799N4r5Qey2ujsivBsaDxLpur/uz6WbxjJUrg5CU1xRCx/2lnYDwFlKMngYAa/bXVt33OtuRcQM29fN4kT68mHNwQ5q9hjbg7rEQpcQbzJZa8Js06JjKs6nzbX3Q7K5M4eXMQGG6uh0kE5Mhz5l9asPABZSHDp/+n9p+qtE5sVYn49+ATizVZMRo9PDiya0ygR4Q+8ajnlZ5Qd77tx7T9GNA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(376002)(39860400002)(366004)(136003)(346002)(8676002)(31686004)(8936002)(31696002)(6666004)(2616005)(186003)(956004)(54906003)(107886003)(4744005)(16526019)(26005)(83380400001)(6486002)(36756003)(86362001)(66946007)(316002)(478600001)(4326008)(16576012)(38100700001)(53546011)(66556008)(66476007)(5660300002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?WWJaeG53VEQ0dUdybXRTbEFhRDM4eW42SGFXcDg1bmR5RUNlckc1QUJGdTRN?= =?utf-8?B?SEdCOFJKZ0R2NlBGSVlKN3phb3l5VDlmaTdkQ01RMWhYcGowWCtSbC9WWFRx?= =?utf-8?B?VmlTMFlHZk9GVFRVeEtjWFlFV1plRUQzUnNCTGV3L2F1UFZpVWhrVXZtam1j?= =?utf-8?B?b1YvbXdwT0taSHdSamZNU2NYaVdyUWNLZVliNlh3WWFpeWpuVXB3M1FqZzhS?= =?utf-8?B?LytwbmdkZ0VIZUVrTTZDRkFNNEZRR0xsNmVlYzBmVXBxek95a1lDT090dStu?= =?utf-8?B?WmRNSk5Sc1NKb3dYKytJZ1lUYTcwS25aSVg0ZStNTEJJK3A4VGhUZytkNnZP?= =?utf-8?B?NG01Q0ZZRXkxWm5qc0ppdGE2ejZWQmVxUWJNVkI0TXgxRUJ5WDN1Y21CUlRC?= =?utf-8?B?bi9kV3AzZFFVYW5FaDIzU3hTZHlOMkhCN1dHaUxmQ21WQVZYaHZ2Y2ZKbUZn?= =?utf-8?B?cFNFWEhMbEh6VWttd2xQdnpxd1lINHZtc01WNkJ1bUgxaUNJQ0FVNkVwaU1l?= =?utf-8?B?VUlrY2MrdXBCd0hmVTFHSkJhNlJWMURLYkhicTEwZENpcHNTZmFIdFZGdEpz?= =?utf-8?B?MU1oc1EwSG9HSm55YWY2ckVzN0k1bnFHNHY0TWMzeUFxM0JKT0pXVjk5WWtn?= =?utf-8?B?Umo5a0hBbGdmZzIyU2tWejBkeGpsY25pdnYzZW5iTUwyVGlqTWp2aDRCeTZ2?= =?utf-8?B?Y3pUaW9DcWFaVFlObnc2VUhpSWtOdWFGN2M0UXZHWFZJMnZkMTlManZ0bUt0?= =?utf-8?B?eDhFbU5yYVNpSUxoRUNqeWRUZXVhZDFuL29SalpmK2IxRThxOE5POEtNYkU1?= =?utf-8?B?QlkwbjlDL2pTSjhmbSszTklnTFVLMDdDRXZETno3akhCZG03RzBadmhBQ0Ry?= =?utf-8?B?d0ppalBpOGtqMTdZVjMrUmx6amN5Q2ZZUTJrbVZ2N05Oa1RKdTNDb2hUL2JR?= =?utf-8?B?ZFpkZjRNbmxnREpGV29xaHZkNnFhdjJOVWZWSzVqeFFuRVVRM0UzU3ZIaFRU?= =?utf-8?B?c3VnbFJhZ1ROb3BkendIMFVVMzRobEtUUjNBM0h6Ymp5aW1JemJFOGUrT2Ja?= =?utf-8?B?ZkNZbHh0ZFpKQ0hHc3VrNTdUcjdVT2V5aUZwNVlvMlF0VWNiUGtVM3RETms1?= =?utf-8?B?Z2poUjVXRjFyWWNWa0VwMXFVdC95YTVWQ25YM1Z2UU5hTWVwaHhiQ01wSUNU?= =?utf-8?B?QlJJcUtIcUxzajA1WFA5UzBQMmpRRHN6eTAweGwvOUFWUmZLOG16ZmRJalQ1?= =?utf-8?B?T1Y0dHVkU0VnbU5DS0tYOHlxUnMyblBTZktDOUZLZ1VSdFlReDVnQnNsZ0Fj?= =?utf-8?B?a1lvalFGMVh6RmRIUjdHa0gxdml2d0xPMzl2OElnUlF5TDIzQzFlU29BazVr?= =?utf-8?B?R1d6U1hjK2p3S29RalZLSDh1ZHFMRFV4VXNRODBHVkR2RWpqcHJRdlp2UVBv?= =?utf-8?B?Sy8zNzlaWWMxVmxxODVSbk1sbThOalpwMGFvaDJhZHQxMnVuS2pMOXVkenhE?= =?utf-8?B?dHVhVi81RlhuSXBUd3d0VG04eks5Z0RkclVCQTdFU0pKamNvaHpUYnFNRDlS?= =?utf-8?B?QnpIVFdlRzhSNXpRVExFZ1Z3YXFLdlB5d04rMVZTQjRwa2lDRWhCUmV3WGc5?= =?utf-8?B?SHEySHhBejJwNFNFTU5CWGEyYWJkZVNyZFcvM0xaMkJwUlNFNE1EOU9OMWcw?= =?utf-8?B?S1Y2SXFTbHBTS2k4Z2Z5RUdkemcvQ3dmbkIvc0xJNjZwTXQ3Mm9CRzU2UXpk?= =?utf-8?Q?806qh9OykyzlXjUI8LqComU9DpcDRU5FKlrg1uA?= X-MS-Exchange-CrossTenant-Network-Message-Id: 743c7773-c844-4f44-e715-08d8f52adb0e X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 16:26:08.7202 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VP0kBBxXqOEA1vSMJBTq/QlxcOyqyzzR8H8K1QfT0K4e3jNoxwDn4sQxVJ0ERTilNUFhwmF1jZfuvY9tQ+RRBIiNP6ilA+O30TBIQe7//ag= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB5140 X-OriginatorOrg: citrix.com On 23/03/2021 09:58, Roger Pau Monne wrote: > Introduce a helper to obtain a compatible cpu policy based on two > input cpu policies. Currently this is done by and'ing all CPUID leaves > and MSR entries, except for MSR_ARCH_CAPABILITIES which has the RSBA > bit or'ed. > > The _AC macro is pulled from libxl_internal.h into xen-tools/libs.h > since it's required in order to use the msr-index.h header. > > Note there's no need to place this helper in libx86, since the > calculation of a compatible policy shouldn't be done from the > hypervisor. > > No callers of the interface introduced. > > Signed-off-by: Roger Pau Monn=C3=A9 I think this wants to be in libx86, because we'll want it to replace the opencoded derivation logic in init_cpuid() Also, we absolutely want to unit test it.=C2=A0 (I could have sworn I alrea= dy started some work there - maybe its hidden in one of my WIP branches). ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 01 16:31:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 16:31:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104653.200445 (Exim 4.92) (envelope-from ) id 1lS0ED-00024j-Ns; Thu, 01 Apr 2021 16:31:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104653.200445; Thu, 01 Apr 2021 16:31:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS0ED-00024c-KH; Thu, 01 Apr 2021 16:31:29 +0000 Received: by outflank-mailman (input) for mailman id 104653; Thu, 01 Apr 2021 16:31:28 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS0EC-00024X-NR for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 16:31:28 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c896356e-41e1-481f-ac42-eed24845bd7e; Thu, 01 Apr 2021 16:31:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c896356e-41e1-481f-ac42-eed24845bd7e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617294687; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=H7Xc8co0G+8ePjlc3Al49an8ffCJ804pzv/RQcupsy4=; b=e/3Ao0kiLhe7NOPvWvaFI5a1MNXDi/gDQI6T6JTjxayEfXH/O+oZInQD NFtuHiJViJFxvFB1XqoJ2pqWwkB31TnMJJ5AcGgH/tvRzjxah6HO3KVQU 0U2bCp5Pd4UCBolXffvJETPJMkdK3D8E9xDHt0I1fdORM71q4SCoc1z8O U=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: l5AZFHmbPInJWg4it8rKdckWfHHSNur9aOoMkdY9MtQlM43e3y3p3tQTeBGKsiJNFiu2TY2YRO vgMfEM5U10oLARZVaIkBI4xH4SyuK9lV6Zjis2xOejdv2z1iQIgEJIOVeFhvMxpfQO2cZHm+6f fO8Da1L90M0EcHjNOS0nNC3nJX3dd/YR8Yb1uiQljptRkpdM/MKSvpUitxm21ce4ucFAyf1/pV nlB2OyMyOE1K3YgbjHw5Mil76ero9dyKcZ09CkGX/XB/llQ4gYlHUg1DSXai/y79gLzbasKMso RWg= X-SBRS: 5.2 X-MesageID: 41096457 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:YQ9mTK6q0XL0VAv8ZQPXwWeEI+orLtY04lQ7vn1ZYSd+NuSFis Gjm+ka3xfoiDAXHEotg8yEJbPoex3h3LZPy800Ma25VAfr/FGpIoZr8Jf4z1TbdBHW3tV2kZ 1te60WMrHNJHBnkMf35xS5Gd48wN+BtJuln/va0m0Fd2FXQotLhj0JbTqzOEtwWQVAGN4dHJ 2T+sJIq1ObCAoqR+68AWQIWPWGmsbCk4jobQVDKxks7gSPij3A0s+ELzGz2BACXzRThYoz6G StqX2E2oyPkdGejiXd2Wja8ohMlLLaq+drKcSQhqEuW07RoymyYoAJYcz6gBkUp6WV5E8ugJ 3wpX4bTrlOwlfwWk3wnhf3wQnn118Vmg3f4HuVm2Hqr8C8ZB9SMbs4uatjfhHU61UtsbhHuc ohtQ/p1Os0fGf9tR/w6NTSWxZhmlDcmwtFrccpg2FCSoxbUbdNrOUkjTBoOa0dFyH34p1PKp gKMOjg4p9tADenRkzCsnIq6NKhWWlbJGb9fmEy/uaR0zRQgUljyVoZyME1jh47heIAYqgByO LePqtykrZSCucQcKJmHe8EBfC6E2rXXHv3QSyvCGWiMJtCF2PGqpbx7rlwzOa2eKYQxJ93vJ jaSltXuUM7ZkqGM7zO4LR7tjT2BEmtVzXkzc9To7JjvKfnebbtOSqfDHgzjsqJuZwkc4/mcs f2HKgTL+7oLGPoF4oM9Rb5QYNuJX4XV9BQksonWmiJvtnAJuTRx6/mWceWAICoPScvW2v5DH dGdiP0Pt984keiXWK9rwPWX1/rZ0zj7bN9GKXX5IEoucwwH7wJljJQpUWy58mNJzEHmLcxZl FCLLTulb7+hWTexxeO00xZfj5mSmpF6rTpVH1H4SUQNVnvTLoFs9KDPURb3H6NIA5DX9rbeT Qv4WhfyOaSFdi91CoiA9WoPiaxlH0Ivk+HSJ8ah+ml6dr6fIg7SrIrQrZ4GwmONxEdo3crlE 5zLCs/AmPPHDLnjquoyLYOAvvEStV6iAC3ZehOqXzesk2Yjdo1RmQSWgOvVcL/u3dqexNkwn lKt4MPiruJnjiibUElhv4jDVFKYGOLRI5dAB+9f4VSkLDzcARWRWOH7Abq0i0bSy7PzQE/l2 bhJSqbdbXuDkBGsn5V6Krs7Wh5b36QZU52d3B8v7BsDGiugAcH7ca7Io6Il0eBYFoLxe8QdA vIZjYfOStC7dG63hz9okfOKVwWgrEVesDNBrUqdL/enk63IIqTjKccArt/55B+Lu3jtecNTM OScwKYNynDFusswgCZz0xVYBVcmT0Bq7fFyRfl5G+30DoDGvLUOk1hXKxeDNeG7WToLsz4mK lRvJYQh6+XPWrwYNLdlv2SQD5HNx/JoWm5C8svsotZuKoutL11W7nXOAG4ok1v7VEbFoPTkk hbfYFQpJbmEaVrd9YJey1Y8kEy/e7/ZncDg0jTOKsGYVopj3XnJNuH7LrDlKo3DiS61XzNEG ja1xcYwuzMUCSC34MLEq4cIWxZb04n9XRpldnyPrH4OUGPd+tZ+kC9PWL4WLhBSLKdEbF4lG c33/i428uWfTH/wgbeoH9SJb9P6X+uRYeXDBiXEeBFt/y8NlLkuNrk3OeDyBP2QyC8cUIWmM lsclERdN1Kjn0at7IMuxLCAZDfkwYCiFtR4TZui17r1MyH2Q7gbDB7GDycpI5XUzlVOmWPlu Lf/4GjpS/A3AQ= X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="41096457" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZueQAU9hR5QDzxjOvyJeqGIr/rFSqqz36pqOOVkKhUh6n23QLezPTLaXiS/X5cqz1zSGtZ7M/ydwtTaiwzBJl2HU+mgsWumX/x5lClciZm+FfffZUGInLVbtY7vPY6a9H4bLWvgIUaNFIdx4KIbDEiO44ZjNNuFdJpb6a+KegSw2ZUgNaZ6ex1w+/jxxw/FKmIBozu3XyKmC8FUU2jlsYjlbPIqZ7H9t46Mb7DhXM1q9758OH6KbCCs0Qy6R8BxZivtra0CPlYKYC01hdhqQGYvABHPOGdI09IMWnSTnhWPL0m4Rkcr3R9NfxwRdU3i0H9LnvmRlAHoIAX1Bh2k7Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xIJ+tZBCWziwfYboF2SRp6cUSYM25wcSDaFaNBRHWm0=; b=ZAN1lJtXJgNH2dp7bMD6lZcNiPJuFERjCNrLPwb65OZKc91yKoCiQlB1Ea05/eIM1WmpSXFo0xFP8EE+5EAvp4QDEEXYTFumgFbu6eh9b4cD0thXtuI3TVIl+/sCbVJJfw6i8d5nlvcEGsQhxkE8Gb/yRFmJZJuaen+O0pOK/6urqHGQJDo3CvV5tCdBklkhu/xaxqprmQUnBSsxNMJEHPa+chaL9Ro4XgxxlYTGXsnU3m2puiyG8674LP2mzkGNOUQerhD6OaBGthHha6ZG/JiAGunzTTmnrPPWZ14zCQJlvY19wWKjK7UkoF69Nap97aeoCsNcbetru1swblg1RA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xIJ+tZBCWziwfYboF2SRp6cUSYM25wcSDaFaNBRHWm0=; b=fmfBP4mOkSPxtunJfMy6lWbPKiGthS5O7v/wbxE3MZtaFYo25tzZbAuzItD4x/4RLNn0Ud2lP7KxH9xmXVpmxpQLap/dZP8nZhgs/m/8iAzQnJkLs5TdSr+Qvtt3GXVsSUW4fKGO4jdweIYsMZNIentqN3J6p0onEMKrHNkB3W4= Subject: Re: [PATCH 16/21] libs/guest: make a cpu policy compatible with older Xen versions To: Roger Pau Monne , CC: Ian Jackson , Wei Liu References: <20210323095849.37858-1-roger.pau@citrix.com> <20210323095849.37858-17-roger.pau@citrix.com> From: Andrew Cooper Message-ID: Date: Thu, 1 Apr 2021 17:31:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <20210323095849.37858-17-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0224.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a6::13) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 916233a7-f5e3-44d8-cec4-08d8f52b9681 X-MS-TrafficTypeDiagnostic: BN8PR03MB5124: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3513; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /HNMQYfefAvm1u68ki0GOVmWTQ1c77NfEQmg8u7Gyhq0eCUIGKgQEDvqqD7vKlekxOhmZSxgFz8lpbmw5C4p0wzLjeu3AIdcjM8GanUVyhpC131FZ9NSzq5ZdZzsnLM+Yo4n2ujyrdjT5emy8bVgSvZTkJacaJUA8eJt7+djtTT/gSQJFkZTkwv91ovejLu2cZl7J2p+DewjyHHNzFPSXcYMKvjac7af1Li2G00Yw2Vcrq26BL/cuq8MMZufunlXq/YbLB2sa8OLxWHUVTymBLtR09yGIBAIdIEeospsbQCtmTEN9LFg1NqXmEkMLYOwMu/VOyxBkeXHpgFp6z0p7e9UyFOnNLewNzHe2u/OTXWcBJyxSdqHmomBtRCfBm3fCqm5ZGkSfjgGEWBD0OU0YWIVXe7MFsgMxTbxaym+jIU0q7gIYsziltuZbFJ71EXtYOCmgRe3Wf4bvVsmiweqH0pdxBVGQZVRJldTia2WdQh3FjJwUkZ2QK4BnJ2LVsiXXBWeJW84u3HoLtnLptuysLN3Q62cTJer6u2wyxlr+abNl2JA+txO9TQq+elFUf1LFwpu0DXiOGXUwE9R26Oidt/R2zlr/2eweDsYHtYgTXvP3eBBC2MPy+OvYKM7pRJ7O/V0VssUkiZy9ejRbAmPm4Fp0RFVoTiV5i4WPOgg+8kN1BIov8brVzVdZZQ0lWxVRFSReUdF5FFaYPIbtmiHWZTNukbTuEDcMKD3qVCtG0I= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(396003)(376002)(366004)(346002)(136003)(86362001)(8676002)(8936002)(2616005)(31696002)(956004)(83380400001)(6486002)(186003)(31686004)(16526019)(26005)(66946007)(66476007)(316002)(16576012)(5660300002)(478600001)(54906003)(6666004)(4326008)(36756003)(53546011)(38100700001)(2906002)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?aFVBeDFQSXlnV0M1a3JERW1ZaFhGRWs4QVp6eENCM1ZqVXZKS3dWRTRTWlZ6?= =?utf-8?B?WTYzOFd5SzBqVmRUTWMzS1crajdoRXN2OUlxNFFFK1IzNzhkMDhwSFdLYUhN?= =?utf-8?B?YisxQzRQNFd3Q3hWVjBEbjQrWkdFOVRLSlFKbi9oT2lZWUJNT2VVVndOVTdp?= =?utf-8?B?NlFiWTc5WVZCWVhST2NYZHRVRFd6KzZvcXZ0cllxd0poKzR0TStRbkREdlJX?= =?utf-8?B?T0ZJUmdISlBlU3VyTisrcGIvdDAzd1VRNjZnSWd3OVNRa0EvNXQyV0Y3eXRV?= =?utf-8?B?NEk4ZDhJOWs3eXJIRmlWQXNpcVV1bmk2anlmQWcyMUxqL2tJeERFcXZHTFov?= =?utf-8?B?dTdXL2MzaExUd3lheFA2RWJzN0FLVHZSUWgxOXludFR5UTFYdnkwMEFJL0tx?= =?utf-8?B?bVJZM1hZZDdRMWxXNWFrQjZmbXZpc3oxbVJ1Skp2Vk13VkppOE0ydWs3Mmpo?= =?utf-8?B?K21Bem85bk1XbXhyYXVOSUtkd0pqREtIaEVpRHNIUDRPb0pxNERXY2dqWVVt?= =?utf-8?B?dThLTE9sZ01HYW1iU0cvNWFZWElsbWhPbnJNY1BJajhZZlhXcEticCtha2dt?= =?utf-8?B?UkVzbFlndVdZYXIrdHg4VVM1K2tXeXJ2QTR5YkVhVCsyQnUwRUQ3ZWhBZEdk?= =?utf-8?B?WlJhYnMvZk9XL01QTVF6Ui9nTkZ3ZWFHUjVDN1dZK2h5ZlUrR3lwZktZRnhN?= =?utf-8?B?cG5QeTJTcmVGeUViNXVrRmtmbXJYYUtPbW9FamQrT3BjLzlUNzdZdTNUTE9I?= =?utf-8?B?emJRWTBVK0hhemhtREQvQWVVRGdkbVBIOXdDcHljZVRBZjMyR3M5N2FHN1Nx?= =?utf-8?B?RDYrN1RRNGlyVFBTdkxITzl6SVNGVmhDbGhWdFNvVTJ6dUNQNXhVYUQxTlZ4?= =?utf-8?B?dncrcHRBdzlGNHV1MFFicnhhTVBiczV0WTQrckJUcmRKZStRcDdleXBFWXJy?= =?utf-8?B?WGVodHBFZWV5ZkJsMWZNblV6eFl1bEcraGV0UWFid3RjSTZpZUZ3YTY4RjRB?= =?utf-8?B?cnhLQU9xMVpDRk00UzVyY2prMTduYlNGZW9NK0FTS1VGWnhuNWlNY3ozcVcz?= =?utf-8?B?S1pYeFMxUXZOM052N09TNDByNmZXak91RHNFNG4rUFdDdTZZdzVKci9VNXcz?= =?utf-8?B?a29CWDFvSUY2ZE1XaVc0ckoxbk9QOTZjSU9ZQThlc3lJN1RqUHpFUWNoS0tO?= =?utf-8?B?anMwVllKUTJXMGpTMkp1SjJQamtweG1keUdTc1QwK1Fkbi8yaFNBR05sUjNv?= =?utf-8?B?WEQ0UEFmZ2FxUVZscGJaZ3FxK0JOd1lRd1BvRHh5OSs2RjBSSng0T2RCQXVi?= =?utf-8?B?TGp6ajJXR1daUm9LNlZyNVhmZ1dDdFR3R2VBekhPMDJqSktJTWxMdmZtOGZW?= =?utf-8?B?V3cvemJNQ0xKNG5UM25OZnFHSlg1S3RXL1QxOFJ5TlpOYUl6Ni81NW1PaHRy?= =?utf-8?B?ei83K3RyQlJoOXFXNFMzakdKNjNaTDN4VmRiODd6UDBUbUxtcE0wY1AvbFZD?= =?utf-8?B?Q2ptcTJVbnA5aFZPR1VWa0xTdnVhN1dnVUxCZCtLc2t4YlVkcGlueFA2Njd2?= =?utf-8?B?enR4YkhET2FLdWVLVm02QndRZEsvbTI3Z2I1WDVuL016VXJoK2dERU1wMXRF?= =?utf-8?B?Z2tlQ2c3TC8ySGdWR3o1OXkxT3E0K1FTN3dadnRQNHVVV25GckNyVU1MdkR2?= =?utf-8?B?ZUVxZC93WVJJMTZOUjZ1STU2a0o3bWlYeklQVWhhVEJQWFVXdjN3N2tOeWRn?= =?utf-8?Q?6JDkwQX7tQtQMsqmEiPge4kJiepDSlBPXBNU1SU?= X-MS-Exchange-CrossTenant-Network-Message-Id: 916233a7-f5e3-44d8-cec4-08d8f52b9681 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 16:31:23.3711 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: M0cdBZu9H+3DFhBI6gBEelKIZHKh26vOVezGWHWk1i2EuRSOgaiN/8pLcJLGrku2YIpYR1mldk4PHbxnjy7pIvnh5HJsPu39S1Q5j5Febig= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB5124 X-OriginatorOrg: citrix.com On 23/03/2021 09:58, Roger Pau Monne wrote: > Older Xen versions used to expose some CPUID bits which are no longer > exposed by default. In order to keep a compatible behavior with > guests migrated from versions of Xen that don't encode the CPUID data > on the migration stream introduce a function that sets the same bits > as older Xen versions. > > This is pulled out from xc_cpuid_apply_policy which already has this > logic present. > > No functional change intended. > > Signed-off-by: Roger Pau Monné > --- > tools/include/xenctrl.h | 4 ++++ > tools/libs/guest/xg_cpuid_x86.c | 39 ++++++++++++++++++++++++++++----- > 2 files changed, 37 insertions(+), 6 deletions(-) > > diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h > index 5f3e5e17e9d..6f7158156fa 100644 > --- a/tools/include/xenctrl.h > +++ b/tools/include/xenctrl.h > @@ -2627,6 +2627,10 @@ int xc_cpu_policy_calc_compatible(xc_interface *xch, > const xc_cpu_policy_t p2, > xc_cpu_policy_t out); > > +/* Make a policy compatible with previous Xen versions. */ > +int xc_cpu_policy_make_compatible(xc_interface *xch, xc_cpu_policy_t policy, > + bool hvm); I think this probably wants  "pre-4.14(?)" somewhere obvious, because "compatible" on its own is very ambiguous. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 01 16:44:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 16:44:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104673.200481 (Exim 4.92) (envelope-from ) id 1lS0RF-0003EZ-Bx; Thu, 01 Apr 2021 16:44:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104673.200481; Thu, 01 Apr 2021 16:44:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS0RF-0003ES-93; Thu, 01 Apr 2021 16:44:57 +0000 Received: by outflank-mailman (input) for mailman id 104673; Thu, 01 Apr 2021 16:44:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS0RE-0003EL-RR for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 16:44:56 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS0RE-00026i-Db; Thu, 01 Apr 2021 16:44:56 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lS0RD-0003Vh-VV; Thu, 01 Apr 2021 16:44:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=OiaaY8Ipo2EWvkLByzV6dgLZ0290eAYdoAl27NRpKL8=; b=2g2s2cZnVUu0gTEVl5aqFGGDN1 fZLcfEjRqub3Kb/XKr+ilVRemxHLPr6PLVpsavnsxxVKWMQGAXvDebKZx4JHg/vh4BCBuo1WYrEBi Cu7+nJzwl4zJB46dBg6RJTNKQqHPG6N403TiAO1NCkEnzEdBLl+XlO6pFEqz8kSszSgE=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, Julien Grall , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH v3 0/2] xen/arm: Mitigate straight-line speculation Date: Thu, 1 Apr 2021 17:44:42 +0100 Message-Id: <20210401164444.20377-1-julien@xen.org> X-Mailer: git-send-email 2.17.1 From: Julien Grall Hi all, Last year, Arm released a whitepaper about a new category of speculation. (see [1] and [2]). In short, a processor may be able to speculate past some of the unconditional control flow instructions (e.g eret, smc, br). In some of the cases, the registers will contain values controlled by the guest. While there is no known gadget afterwards, we still want to prevent any leakage in the future. The mitigation is planned in two parts: 1) Arm provided patches for both GCC and LLVM to add speculation barrier and remove problematic code sequence. 2) Inspection of assembly code and call to higher level (e.g smc in our case). I still haven't looked at 1) and how to mitigate properly Arm32 (see patch #1) and SMC call. So this issue is not fully addressed. Note that the ERET instruction was already addressed as part of XSA-312. Cheers, [1] https://developer.arm.com/support/arm-security-updates/speculative-processor-vulnerability [2] https://developer.arm.com/support/arm-security-updates/speculative-processor-vulnerability/downloads/straight-line-speculation Julien Grall (2): xen/arm: Include asm/asm-offsets.h and asm/macros.h on every assembly files xen/arm64: Place a speculation barrier following an ret instruction xen/arch/arm/Makefile | 2 +- xen/arch/arm/arm32/entry.S | 2 +- xen/arch/arm/arm32/head.S | 1 - xen/arch/arm/arm32/lib/lib1funcs.S | 1 + xen/arch/arm/arm32/proc-v7.S | 1 - xen/arch/arm/arm64/debug-cadence.inc | 1 - xen/arch/arm/arm64/debug-pl011.inc | 2 -- xen/arch/arm/arm64/entry.S | 2 -- xen/arch/arm/arm64/head.S | 2 -- xen/arch/arm/arm64/smc.S | 3 --- xen/include/asm-arm/arm64/macros.h | 6 ++++++ xen/include/asm-arm/config.h | 6 ++++++ xen/include/asm-arm/macros.h | 18 +++++++++--------- 13 files changed, 24 insertions(+), 23 deletions(-) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 01 16:44:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 16:44:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104674.200493 (Exim 4.92) (envelope-from ) id 1lS0RG-0003Fn-Jk; Thu, 01 Apr 2021 16:44:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104674.200493; Thu, 01 Apr 2021 16:44:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS0RG-0003Fg-GY; Thu, 01 Apr 2021 16:44:58 +0000 Received: by outflank-mailman (input) for mailman id 104674; Thu, 01 Apr 2021 16:44:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS0RF-0003FE-N5 for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 16:44:57 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS0RF-00026n-Br; Thu, 01 Apr 2021 16:44:57 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lS0RF-0003Vh-2c; Thu, 01 Apr 2021 16:44:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=4YIJNP3sWTEa4vKgS74NPmWXjoR7OyE6WG88MKH7VTw=; b=guT/9ZpPHn6MZTCpv+qMsJpHb xMtlyzFUHnsvz7WGxXHsFoIUtMw0Iz9Q5VRQjmNEo8aTq5qTK67iue4Xm2V0fg1BFvM1BojDTnQSc n9DCGx96NfxHisxpm9EvL10/UtlVFCzifxQNFPsvqaE5NYnBGyeDWwDxgo2nfgXchqgso=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, Julien Grall , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH v3 1/2] xen/arm: Include asm/asm-offsets.h and asm/macros.h on every assembly files Date: Thu, 1 Apr 2021 17:44:43 +0100 Message-Id: <20210401164444.20377-2-julien@xen.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210401164444.20377-1-julien@xen.org> References: <20210401164444.20377-1-julien@xen.org> From: Julien Grall In a follow-up patch we may want to automatically replace some mnemonics (such as ret) with a different sequence. To ensure all the assembly files will include asm/macros.h it is best to automatically include it on single assembly. This can be done via config.h. It was necessary to include a few more headers as dependency: - to define sizeof_* - which is already a latent issue given STACK_ORDER rely on PAGE_SIZE. Unfortunately the build system will use -D__ASSEMBLY__ when generating the linker script. A new option -D__LINKER__ is introduceed and used for the linker script to avoid including headers (such as asm/macros.h) that may not be compatible with the syntax. Lastly, take the opportunity to remove both asm/asm-offsets.h and asm/macros.h from the various assembly files as they are now automagically included. Signed-off-by: Julien Grall Reviewed-by: Bertrand Marquis --- Changes in v3: - Include rather than - Add Bertrand's reviewed-by tag Changes in v2: - Patch added --- xen/arch/arm/Makefile | 2 +- xen/arch/arm/arm32/entry.S | 1 - xen/arch/arm/arm32/head.S | 1 - xen/arch/arm/arm32/proc-v7.S | 1 - xen/arch/arm/arm64/debug-cadence.inc | 1 - xen/arch/arm/arm64/debug-pl011.inc | 2 -- xen/arch/arm/arm64/entry.S | 2 -- xen/arch/arm/arm64/head.S | 2 -- xen/arch/arm/arm64/smc.S | 3 --- xen/include/asm-arm/config.h | 6 ++++++ 10 files changed, 7 insertions(+), 14 deletions(-) diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index 46e6a95fec98..ca75f1040dcc 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -134,7 +134,7 @@ asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c $(CC) $(filter-out -flto,$(c_flags)) -S -o $@ $< xen.lds: xen.lds.S - $(CPP) -P $(a_flags) -MQ $@ -o $@ $< + $(CPP) -P $(a_flags) -D__LINKER__ -MQ $@ -o $@ $< dtb.o: $(patsubst "%",%,$(CONFIG_DTB_FILE)) diff --git a/xen/arch/arm/arm32/entry.S b/xen/arch/arm/arm32/entry.S index b228d44b190c..f2f1bc7a3158 100644 --- a/xen/arch/arm/arm32/entry.S +++ b/xen/arch/arm/arm32/entry.S @@ -1,4 +1,3 @@ -#include #include #include #include diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S index 50f019ed98ea..7178865f48c3 100644 --- a/xen/arch/arm/arm32/head.S +++ b/xen/arch/arm/arm32/head.S @@ -18,7 +18,6 @@ */ #include -#include #include #define ZIMAGE_MAGIC_NUMBER 0x016f2818 diff --git a/xen/arch/arm/arm32/proc-v7.S b/xen/arch/arm/arm32/proc-v7.S index 46bfc7a9074c..1efde2d72da0 100644 --- a/xen/arch/arm/arm32/proc-v7.S +++ b/xen/arch/arm/arm32/proc-v7.S @@ -17,7 +17,6 @@ * GNU General Public License for more details. */ -#include #include #include diff --git a/xen/arch/arm/arm64/debug-cadence.inc b/xen/arch/arm/arm64/debug-cadence.inc index 7df0abe4756f..0b6f2e094e18 100644 --- a/xen/arch/arm/arm64/debug-cadence.inc +++ b/xen/arch/arm/arm64/debug-cadence.inc @@ -17,7 +17,6 @@ * GNU General Public License for more details. */ -#include #include /* diff --git a/xen/arch/arm/arm64/debug-pl011.inc b/xen/arch/arm/arm64/debug-pl011.inc index 385deff49b1b..1928a2e3ffbb 100644 --- a/xen/arch/arm/arm64/debug-pl011.inc +++ b/xen/arch/arm/arm64/debug-pl011.inc @@ -16,8 +16,6 @@ * GNU General Public License for more details. */ -#include - /* * PL011 UART initialization * xb: register which containts the UART base address diff --git a/xen/arch/arm/arm64/entry.S b/xen/arch/arm/arm64/entry.S index 175ea2981e72..ab9a65fc1475 100644 --- a/xen/arch/arm/arm64/entry.S +++ b/xen/arch/arm/arm64/entry.S @@ -1,6 +1,4 @@ -#include #include -#include #include #include #include diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index f38a8dfca7dc..aa1f88c76498 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -21,11 +21,9 @@ */ #include -#include #include #include #include -#include #define PT_PT 0xf7f /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=1 P=1 */ #define PT_MEM 0xf7d /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=0 P=1 */ diff --git a/xen/arch/arm/arm64/smc.S b/xen/arch/arm/arm64/smc.S index b0752be57e8f..91bae62dd4d2 100644 --- a/xen/arch/arm/arm64/smc.S +++ b/xen/arch/arm/arm64/smc.S @@ -13,9 +13,6 @@ * GNU General Public License for more details. */ -#include -#include - /* * void __arm_smccc_1_0_smc(register_t a0, register_t a1, register_t a2, * register_t a3, register_t a4, register_t a5, diff --git a/xen/include/asm-arm/config.h b/xen/include/asm-arm/config.h index 5c10c755db46..c7b77912013e 100644 --- a/xen/include/asm-arm/config.h +++ b/xen/include/asm-arm/config.h @@ -69,6 +69,7 @@ #endif #include +#include /* * Common ARM32 and ARM64 layout: @@ -190,6 +191,11 @@ extern unsigned long frametable_virt_end; #define watchdog_disable() ((void)0) #define watchdog_enable() ((void)0) +#if defined(__ASSEMBLY__) && !defined(__LINKER__) +#include +#include +#endif + #endif /* __ARM_CONFIG_H__ */ /* * Local variables: -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 01 16:44:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 16:44:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104675.200504 (Exim 4.92) (envelope-from ) id 1lS0RH-0003Hv-SJ; Thu, 01 Apr 2021 16:44:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104675.200504; Thu, 01 Apr 2021 16:44:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS0RH-0003Hl-Op; Thu, 01 Apr 2021 16:44:59 +0000 Received: by outflank-mailman (input) for mailman id 104675; Thu, 01 Apr 2021 16:44:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS0RG-0003GQ-SR for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 16:44:58 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS0RG-00026v-GQ; Thu, 01 Apr 2021 16:44:58 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lS0RG-0003Vh-6A; Thu, 01 Apr 2021 16:44:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=xddeRGQJBt2UK1F3Jl0he+BipTAo3K2Gn54LJ/oQfD4=; b=cTAVbPP1IOE+LNC4PHMIXqXYx 1akX7cUB6Gl/Fg5qOEg9Eg3bqxL/CyqJZqmul0c3F2g7XDzdBDZwTYLW3GOTGWExZ2FcbdG0v540T MzhljtzYt4BRlyCaScynEQy8AKAU90l18XlWAhs6nl9OS+VTMtVqBrkE6GRKRNoZR1/Fs=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, Julien Grall , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH v3 2/2] xen/arm64: Place a speculation barrier following an ret instruction Date: Thu, 1 Apr 2021 17:44:44 +0100 Message-Id: <20210401164444.20377-3-julien@xen.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210401164444.20377-1-julien@xen.org> References: <20210401164444.20377-1-julien@xen.org> From: Julien Grall Some CPUs can speculate past a RET instruction and potentially perform speculative accesses to memory before processing the return. There is no known gadget available after the RET instruction today. However some of the registers (such as in check_pending_guest_serror()) may contain a value provided by the guest. In order to harden the code, it would be better to add a speculation barrier after each RET instruction. The performance impact is meant to be negligeable as the speculation barrier is not meant to be architecturally executed. Rather than manually inserting a speculation barrier, use a macro which overrides the mnemonic RET and replace with RET + SB. We need to use the opcode for RET to prevent any macro recursion. This patch is only covering the assembly code. C code would need to be covered separately using the compiler support. This is part of the work to mitigate straight-line speculation. Signed-off-by: Julien Grall Reviewed-by: Bertrand Marquis --- It is not clear to me whether Armv7 (we don't officially support 32-bit hypervisor on Armv8) is also affected by straight-line speculation. The LLVM website suggests it is: https://reviews.llvm.org/D92395 For now only focus on arm64. Changes in v3: - Add Bertrand's reviewed-by Changes in v2: - Use a macro rather than inserting the speculation barrier manually - Remove mitigation for arm32 --- xen/arch/arm/arm32/entry.S | 1 + xen/arch/arm/arm32/lib/lib1funcs.S | 1 + xen/include/asm-arm/arm64/macros.h | 6 ++++++ xen/include/asm-arm/macros.h | 18 +++++++++--------- 4 files changed, 17 insertions(+), 9 deletions(-) diff --git a/xen/arch/arm/arm32/entry.S b/xen/arch/arm/arm32/entry.S index f2f1bc7a3158..d0a066484f13 100644 --- a/xen/arch/arm/arm32/entry.S +++ b/xen/arch/arm/arm32/entry.S @@ -441,6 +441,7 @@ ENTRY(__context_switch) add r4, r1, #VCPU_arch_saved_context ldmia r4, {r4 - sl, fp, sp, pc} /* Load registers and return */ + sb /* * Local variables: diff --git a/xen/arch/arm/arm32/lib/lib1funcs.S b/xen/arch/arm/arm32/lib/lib1funcs.S index f1278bd6c139..8c33ffbbcc4c 100644 --- a/xen/arch/arm/arm32/lib/lib1funcs.S +++ b/xen/arch/arm/arm32/lib/lib1funcs.S @@ -382,5 +382,6 @@ UNWIND(.save {lr}) bl __div0 mov r0, #0 @ About as wrong as it could be. ldr pc, [sp], #8 + sb UNWIND(.fnend) ENDPROC(Ldiv0) diff --git a/xen/include/asm-arm/arm64/macros.h b/xen/include/asm-arm/arm64/macros.h index f981b4f43e84..4614394b3dd5 100644 --- a/xen/include/asm-arm/arm64/macros.h +++ b/xen/include/asm-arm/arm64/macros.h @@ -21,6 +21,12 @@ ldr \dst, [\dst, \tmp] .endm + .macro ret + // ret opcode + .inst 0xd65f03c0 + sb + .endm + /* * Register aliases. */ diff --git a/xen/include/asm-arm/macros.h b/xen/include/asm-arm/macros.h index 4833671f4ced..1aa373760f98 100644 --- a/xen/include/asm-arm/macros.h +++ b/xen/include/asm-arm/macros.h @@ -5,6 +5,15 @@ # error "This file should only be included in assembly file" #endif + /* + * Speculative barrier + * XXX: Add support for the 'sb' instruction + */ + .macro sb + dsb nsh + isb + .endm + #if defined (CONFIG_ARM_32) # include #elif defined(CONFIG_ARM_64) @@ -20,13 +29,4 @@ .endr .endm - /* - * Speculative barrier - * XXX: Add support for the 'sb' instruction - */ - .macro sb - dsb nsh - isb - .endm - #endif /* __ASM_ARM_MACROS_H */ -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Apr 01 17:22:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 17:22:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104692.200517 (Exim 4.92) (envelope-from ) id 1lS11S-00070S-WE; Thu, 01 Apr 2021 17:22:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104692.200517; Thu, 01 Apr 2021 17:22:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS11S-00070L-SH; Thu, 01 Apr 2021 17:22:22 +0000 Received: by outflank-mailman (input) for mailman id 104692; Thu, 01 Apr 2021 17:22:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS11Q-00070G-C0 for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 17:22:20 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4893c945-cb8e-4d37-a463-e7ca09be095f; Thu, 01 Apr 2021 17:22:19 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4893c945-cb8e-4d37-a463-e7ca09be095f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617297738; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=3Kiz4JFIKM6c/kx/VCnk1VOA6QYDvbWSCcgOD8hCqQs=; b=H6bsYjMp0QE4tLjU37ps5nZJPb72AJIF/xf52Q2MNMWwq66omR9uFqGz TJcEu2jCXVkCnMj1yxMSqZSYmMtllQdoUMHKDkUuYUwoKBzSDG0F7qV/m nRh3ZS2S8Mz8F8CebLNa639wVZAA8cIuvYVdih1/AiQjJHaUJsEnR7NtM M=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: dwTyhiCEtVrUGv2P9u7V1L5Cp+o/kLzRHnJ52XNjxw0zwYl3tiQa10x73TrqHBs8GcapBSvBUB C3g9hp7BAJH6wbuYNlYXUUPijUSXxk34q6RIlYkNMVevOh0p4OpA7jITA9Vktwd2ThBnzk5c7e y4jntoV6Ss1X9TU2kDzrOvSvlC2VjhYBEwLuy22uXBLt0LkyoFfOU20PTv8vsd05rpnHiShoo2 5PAVmt0ODuDQrboUAA/DL5acCQEsB1KyizuQstKmi0W1pytfbvhUwrq+qGPV0Cku2PquodpNbx gs4= X-SBRS: 5.2 X-MesageID: 40709502 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:aYU4X6p/Edtu6DJJ8kP2AfgaV5vYL9V00zAX/kB9WHVpW+SFis Gjm+ka3xfoiDAXHEotg8yEJbPoex7h3LR+iLNwAZ6JWg76tGy0aLxz9IeK+UyHJwTS1M54kZ 1hfa93FcHqATFB5/rSzQGkH78br+Wv37uvgY7loUtFbQYvUK146hc8NwDzKDwVeCBjJb4UUK WR/dBGoT3IQwVxUu2eCmMeV+bO4/3n/aiWAiIuPBIs5AmQgT7A0teTfySw5RsQXyhCxr0v6w H+4mnEz56uru2hzVvk33LThq48pPLa1tBBCMaQ4/JlTgnEtwDAXuVccozHhh8ZiqWF6FEmkN 7Dyi1QQPhb2jfqUUye5Tfo0wnk+j4y53Hl0k/wuwqcneXJAAgUJuAEqYVFcgbIy0dIhqAM7I t7m1i3mrASLRTckD/z79LFPisa5nackD4ZvsM4y1l8OLFuEYN5nMgk025+VKokJmbc7rsqFe F/Zfusmcp+QBehQF3y+lV0zMfEZAVKIj62BnIsl+ayyDZskHVw3yIjtbAit0ZFzp47RpVejt 60SZhApfVLRs8SW6p3GP0Md8uxEnDMWhLBKgupUC7aKJ0= X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="40709502" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U1go8m33G9lXdSVZdnODiF9LjE7z67ilqa2z2S78LHsBBj1IHJjp0tHhWB3LKtxqcVWOmoSBuhhWqymVfBoGNSSGtFj5XSnCojRRrBipaeoVaooHUQcpS6XMO5FNbEDNmBJZU/JGerluqB6WZxON+vERN1UJmkPxq7t5rZwfJUm3Okb2RJtmiQon6srRVRZv7Uo1owTqpXznmVaKbBf4Yj1Mpwwz9BE0tGZ9NsBuNuDnizE1ulsyhrmupSpSizyxXXGdNUwBpqCEmfwALfZsDR9jKC3cz4RJ5FqtmHK5lOJ4osqVla/oZFZO6Qa8Uqo3DNbiXlXgL85KEq5334sULw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z3YUm9V+BOHV9ZbU3NeP5q+b1SrtN2hvM18XgsGk8dE=; b=aPL/0MIr/vlotLlKfae4MMqbgF9VduEyQaIe1rdtfZOhqDvoTewSNuAhaAq+4+MU1tPD44zUlipfZG36HrhVYVFk9bZaG8cR0RwyUtIHMT/keljis7/RQu5V2AKVgfXoQB7D1ITV6/8zK3wIkixxyGVRHoQMLUYIcNTrTRuXHD6uj6hV1LE/V+u6d1PQ0zzIEJ610i7TTuntz+fqUl69EQSgv3ev2+ECUTtH80Oj0y8o9Ck4iFY3IG0nlAOvomvqdq4ovOL+epftzlXHY2RMZUHbKWwp3twxPOYKz5JJWZ1xvR8wl2QPau8i3xLWGDjvQJcaQqCJ4OsTuIxPXIvKjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z3YUm9V+BOHV9ZbU3NeP5q+b1SrtN2hvM18XgsGk8dE=; b=YXnobHSbjpLEb2PyH8uLVdfKDEc/1sOGPJ8Q6A4Zks5c8sae84JICruCp8VdU5fPg/CQejyIsRMBpmGoO4o9X5KqaqFiYFyS2PGHcbHdnLbohfg/cuRdrQ7P23FznyLisAOtyN1i9F1MhXbjGKMVPK8StzzizoZyLJrr8DjKb+w= To: Roger Pau Monne , CC: Ian Jackson , Wei Liu , Jan Beulich References: <20210323095849.37858-1-roger.pau@citrix.com> <20210323095849.37858-18-roger.pau@citrix.com> From: Andrew Cooper Subject: Re: [PATCH 17/21] libs/guest: introduce helper set cpu topology in cpu policy Message-ID: Date: Thu, 1 Apr 2021 18:22:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <20210323095849.37858-18-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0434.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a9::7) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2596c444-303a-4b20-e340-08d8f532b08f X-MS-TrafficTypeDiagnostic: BN8PR03MB5137: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J/Anlcn1MXOw5EQ/X10KtgUcsIXU9zlGcJHU4bWvOmelhYwbXl4ECmvTV4kVtRIxsIeC+vx8dnRd+jGTUBmfb0PSa9RV0zQz0wiWMSSoAdOr5VVEo6ZQYupOyqH6/+DiAh8rG4GiqlaHb0w2eTsPbMjMQtcrfwe7/6X8FJoqxBRiwGJicwJEjZNa/oTYiLCagQTrDQiBg0asF53/6/xknQsK8D020nzvA5tp1X8Lt2AYxBIzqRfx//mbF8lKjRo83zEZu34h/+XeGypuH/izKYa108csBSnOO3269ji34zdpxVb0fpQKprLhcYgRMYIsmucBBahIFWYHOmL3GosuITmXn4aKL1yxsl0rqO6DdMRn3SMri16CG5LbBoFRFv4GftI74t6JNrXk1Jzu60CgfncKQbP8hL6ArWbgD2oNF/++/q1GkZDXUTfEr0iug6z8lVUuHmpjCwJWTlxlwCiFEW3eltM4ZEdTEyIULuQf9n2+YvTlJAkjVjNPLIQHFj/1U7zwM5zRPWuQ96y6b/9A6aIA/bmKIjYoOXjfxN+oBr+QubFTNRIzJTWQM5jdj+17M/gGPnqxNPb5AchUYs28GLPjXtHGQAaVZwZ6pxGGYwtWl6mh2u5gI3z4aflOCcCj9hhFWseduW9UcjikVkVMnH1z0JHgrJE2br3szI/qnp5Itm+jxRZlEYhHJIhAM0pJ6tb+PYSyoHB05QUkRXg1kShyOXqWEVoWyL7ECZiBqBw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(136003)(396003)(366004)(39860400002)(346002)(36756003)(8936002)(16526019)(31686004)(186003)(8676002)(5660300002)(6486002)(6666004)(16576012)(2616005)(86362001)(66946007)(66476007)(66556008)(956004)(83380400001)(31696002)(53546011)(4326008)(54906003)(2906002)(26005)(316002)(38100700001)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Uis0b2l4U0huV0Zrcm9LS01mQlgvWUloazl0dGw3bjRRQXova1ZNMXA3VWlE?= =?utf-8?B?WlIyNXpZcWY5L3MrQ3c3YzRYcitoWldXcUVlWjJtdUVKam9xajZhQVRJMy9T?= =?utf-8?B?clE4cFFqYWpLcVdaOFpxZzE1TkJtMWFBbnViZ3dZL1Z2cG1DS3lFVVkzZlBs?= =?utf-8?B?SGVzTG0wb0p3eUphZDNDWmc3aCs2b3FDaUtLK0NsdUNheUc1dzZHdTF6cDV2?= =?utf-8?B?QUNKaGNzb2dIR3NTNS9MOU9QckxZcTlzSTJFOVkySXRqUWNBekZZcjIrUWRN?= =?utf-8?B?U2RBTnRaZUNQajFqNU5oWFhhTEdENGpoaC8xL2NwSXZmQytDYzNqSndKN3kv?= =?utf-8?B?eTBGV2hJVFUvNktiTE91TDF2K0d4VU5NUVhQSGN3RlA3djkxTVZXQjVRZDFm?= =?utf-8?B?RDRGRTRSWUY4UWdheFlpMG1YZThjNWY5RUxoL1cvS0FtU3hJbkdzUGdwTm92?= =?utf-8?B?emJHenN1RkFZYjcvbmZaaDl5dDBBTUs3Mm1sMlNGYXhiUDRRSXUvZjlaK2RR?= =?utf-8?B?N3RFcGxjKzlwdXJmcndJWkNVYmJRT0Uxcm1mUm1RR0sydm5MK2xGUnhPc0hs?= =?utf-8?B?bWFPTm5CaTNhb1dHcUhxemp2elBVcnJQdjFaSDNmRmtDVmhDdExvSHl0OTZZ?= =?utf-8?B?RTJPclovMGtsMFUvSXFWOUdhOXlFNTlGYjZhS2svWHQrWGFKSFgvb3p5NFMw?= =?utf-8?B?bjE4UDd0WTJXSmNFZWpMRmY5YkZuckVzMWd5d2VpYVoxS2orSTV1dHNBTC96?= =?utf-8?B?MmUveWZQbVlwdFV4c1ExaGtSUm1ZNkIxd25JVTk5NHNmeE0wVDVBZXJ0Q29V?= =?utf-8?B?ZG9iN0Q1bm81YVJUdGptakFPem9nNytZSDBmRHFzUVQyc1BVSEJmWVVReUxn?= =?utf-8?B?dzl6dGUyODk3N3h6VXNMdkNYMUswYk1WMThQTEExSnhoVGtsbmMxaUtWeUN5?= =?utf-8?B?dWtPaWRnTEd3Qzc1L0FURm5uS00yMGtqV09wdUt6SGxFaXVKWmZPNE9SdFBi?= =?utf-8?B?YXhyYlNuYm8wM1AxcC83TnhCOTVyZ0RONmtMZkF3VUxWQnVvcWpkTnlLeXl1?= =?utf-8?B?azI1eXhpMFN5RmVROWdmZGIzMmFXa1YyeStrTzNFTjNlZ29hYmpXczkrZVov?= =?utf-8?B?SXRRR3d0dGsxWklyWVVsRlNyL0I4L01GekpJUHJjM3ZRZ3lkd3YxaldaNStF?= =?utf-8?B?V3Q2NFJuRENPK3VXelBYNk5MOUdOcGhtWTlvT2cxdjNoazVpZnB1R1d2bk9N?= =?utf-8?B?aVlIT2xTcVJBK1d0Withbkg4aDArdmZVM0dmblV0NVAwT3Z4bUlDYks4Y2Z1?= =?utf-8?B?T25mV0E1aG9vWHVlTzRuV3AvK1pHRGdlQ05HYXVTQnZXVU5hQS9kN0lBMjF2?= =?utf-8?B?RVIwM0l4cHFJcG1oYVVPejhpdjVDU3lLKzQ2RHpHeDYwQ1I4enlMVG5IbE5u?= =?utf-8?B?N2NyOE9ia2txRzNWY3NZaFFWK1orZlRsbDl1WGNXYXNDRzcyN1FtaTF6SVV4?= =?utf-8?B?TnlmSDFXZDl2MlFXVjF1cEJ4Qi9SWmJGZlR5K2MySjlVVjJOaVR3b2NvdlRF?= =?utf-8?B?SnFWdmtTazVKbGU3bjFmS0Jid291VXExUjZnTHl6KzNtWHhDeTkyRHpKWUky?= =?utf-8?B?UDE3RU9sODY0QzNwc2R6UmFVQ2pzc3g5cVJlMUU1bGRXMU9zbHY1L0FlZUY2?= =?utf-8?B?NkQzZVhGSVowYldVS1VqSFgvYmdmYTFnQTdCMi8weERsMXBnZEtmaTdmNmFj?= =?utf-8?Q?/cPKQwsyIZcNqCwhtebYgG2cS5VHwrM3M4HdgaO?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2596c444-303a-4b20-e340-08d8f532b08f X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 17:22:13.4333 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CbJq5xtprhw648Htfry3/IOxPfHk1xZ1rUFWcrhA7/ShZF32ksDOJwjGFmjOg4Xf/o02vRz7dx+82nVxWpoHJiHoz4QLtB2wGADyEEuG0wc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB5137 X-OriginatorOrg: citrix.com On 23/03/2021 09:58, Roger Pau Monne wrote: > This logic is pulled out from xc_cpuid_apply_policy and placed into a > separate helper. > > No functional change intended. > > Signed-off-by: Roger Pau Monn=C3=A9 > --- > tools/include/xenctrl.h | 4 + > tools/libs/guest/xg_cpuid_x86.c | 181 +++++++++++++++++--------------- > 2 files changed, 102 insertions(+), 83 deletions(-) > > diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h > index 6f7158156fa..9f94e61523e 100644 > --- a/tools/include/xenctrl.h > +++ b/tools/include/xenctrl.h > @@ -2631,6 +2631,10 @@ int xc_cpu_policy_calc_compatible(xc_interface *xc= h, > int xc_cpu_policy_make_compatible(xc_interface *xch, xc_cpu_policy_t pol= icy, > bool hvm); > =20 > +/* Setup the policy topology. */ > +int xc_cpu_policy_topology(xc_interface *xch, xc_cpu_policy_t policy, > + bool hvm); I'm not sure how I feel about this.=C2=A0 It's repeating the mistake we've currently got with topology handling. One part of it needs to be part of "compatible".=C2=A0 We need to run the below logic, *in this form* as part of magic-ing a policy out of thin air for the incoming VM with no data. However, for any non-broken logic, the caller needs to specify the topology which wishes to be expressed. Do we want SMT at all?=C2=A0 Do we want 1, 2, 4 or other threads/core. How many cores per socket?=C2=A0 Its very common these days for non-power-of-2 numbers.=C2=A0 Our default case ought to be to match the hos= t topology. Do we want to support 3 threads/core?=C2=A0 Sure - its weird to think about= , but its semantically equivalent to using non-power-of-2 numbers at other levels, and would certainly be useful to express for testing purposes. What about Intel's leaf 0x1f with the SMT > Core > Module > Tile > Die topology layout? The answers to these questions also need to fix Xen so that APIC_ID isn't vcpu_id * 2 (which is horribly broken on non-Intel or Intel Knight* hardware).=C2=A0 It also needs to change how the MADT is written fo= r guests, and how the IO-APIC IDs are assigned (matters for the AMD topology algorithms). There are further implications.=C2=A0 Should we prohibit creating a 4-vcpu = VM with cores/socket=3D128?=C2=A0 A regular kernel will demand an IOMMU for th= is configuration as we end up with APIC IDs above 255.=C2=A0 OTOH, there are also virtualisation schemes now to support 32k vcpus without an IOMMU, which KVM and HyperV now speak. Fixing our topology problems is a monumental can of worms.=C2=A0 While we should keep it in mind, we should try not to conflate it with "make libxl/libxc's CPUID logic more sane, and include MSRs", which is large enough task on its own. What I suspect we want in the short term is xc_cpu_policy_legacy_adjust() or equivalent, which is very clear that it is a transitional API only, which for now can be used everywhere where xc_cpuid_apply_policy() is used.=C2=A0 As we pull various logical areas out of this, we'll adjust the callers appropriately, and eventually delete this function. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 01 17:44:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 17:44:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104695.200529 (Exim 4.92) (envelope-from ) id 1lS1Mc-0000N3-RZ; Thu, 01 Apr 2021 17:44:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104695.200529; Thu, 01 Apr 2021 17:44:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS1Mc-0000Mw-Mo; Thu, 01 Apr 2021 17:44:14 +0000 Received: by outflank-mailman (input) for mailman id 104695; Thu, 01 Apr 2021 17:44:13 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS1Mb-0000Mr-IP for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 17:44:13 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f2f63e19-1bb4-40ff-a719-d6786882b7c7; Thu, 01 Apr 2021 17:44:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f2f63e19-1bb4-40ff-a719-d6786882b7c7 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617299052; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=+791JNpeEdaqd7sL8/wPJrh4NVafG8GswQ+wOJdn8Cg=; b=DlY3T4FP+egsAd8OU51wzWYnG53JYh/IsVqJDlV5PocYqSISUFfFYn0x qzRSOUte0ma80bjxO2Dre6k33V70ClQIcmvZwEYPfHHL8p5nsPsrS8tQo uAc50t7zT+bilTWJ12K+oqtfwVqYEFobNEX+OAommtEemKZr+TV/2I2yL 0=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: lPQNur7rz93qhrVQe/y/aFmx6nG6P5Xq6ZfvKzbP4Pmmz5Vkp1FnJ8mZNMDCEWM4sG0Bda9MAg zn5Aqh+H/OfhhVQq5KfSOu85P6mX+LY2wdbcwL16ZtsWZ1bws+zSIFWFo2P5EYV90Zisdnf/cU vo7EGGuw5NvYsV2kAgGDKWXxsrB0w7gzxBZymSM9KgFIf92oUk9G4q5pFkctRiEThpxRHD1wSa loBgKCub0dPOGV6pYQgtPqgD1r+1rEXP5SDV+JBNw7hQ1oL/UZhGZ+SrZ9kH4ReFKoichBCLE3 ncY= X-SBRS: 5.2 X-MesageID: 40730594 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:UBRIVa//5mftcagWf5xuk+F1cL1zdoIgy1knxilNYDRvWIixi9 2ukPMH1RX9lTYWXzUalcqdPbSbKEmyybdc2qNUGbu5RgHptC+TLI9k5Zb/2DGIIUHD38Zn/+ Nbf6B6YeecMXFTkdv67A6kE9wp3dmA9+SSif3Dymp2JDsKV4hLxW5Ce2OmO2dxQxRLAod8MZ Ka6NZOqTbIQwVpUu2QAH4ZU+/f4+DRnJX9bhIcQzIh4g+CjTSngYSKbySw9BEYTj9J3PMe4X HI+jaJm5mLntOa7lvn12HV54lLg9eJ8LV+LeGFl8R9EESVti+Gf4JkMofy2wwdgObq01oylc mJnhFIBbUI11r0XkWY5STgwBPh1jFG0Q6Q9Xa9jWH4qcL0ABIWYvAx/L5xSRfS50o+sNwU6s sitAj4xvkneC/opyjz68PFUBtnjCOP0B4fuNUekmBFVs8mYKJRxLZvjH99KosKHy7x9ekcYY 9TJfzbjcwmE2+yU2rUpS1GztCqQx0Ib2y7a3lHkMmU3z9KpWt+3ksVyecO901wha4Vet1q4f /JPb9vk6wLZsgKbbhlDONEesevDHfRKCi8f166EBDCLuUqKnjNo5n47PEc4/yrQoUByN8XlI 7aWF1VmGYucyvVeIOz9awO1iqIbHS2XDzrxM0bzYN+oKfASL3iNjDGYEwykuO7ys9vQfHzar KWAtZ7EvXjJWzhFcJixAvlQaRfLnEYTYk8pss7YVSTucjGQ7ea9tDzQbL2Hv7AADwkUmTwDj 8oRz7oPvhN6UitRzvWmx7Ud3TxelHu3J55HaTAltJjjbQlB8lpiEw4mF657saEJXlpqaotZn ZzJ7vhj+eaqACNjCL1xlQsHiAYIlde4b3mXX8PjxQNKVnIfbEKvMjaXWhT2XCANyJuVs++Kn 8Zm31HvYaMa7CAzyErDNyqdkiAiWEImX6MR5AA3oqO+NniYZF9Kpo9QqR+GUHqGnVO6EdXgV YGTDVBal7UFzvoh6ngpocTHvvje951hxruB9VVp3LZvUC1vtouWXMfYj6rXaes8EQTbgsRom c0374UgbKGlzrqA3A4mv4EPFpFb3nSPKhLFz2fZIJfmqnifSZ5SWviv03dtzgDPk7Rs2kCjG 3oKiOZPdXGGEBUtHxj3qH2y19sbWmGc0Vsand1jJ1lGQ39ywRO+N7OQpD2/3qaa1MEzO1YCj 3DbDcICi5Fxty81neu6Xy/PERj4q9rEv3WDbwlfb2W52ikL5eQk7oaW9VO+ox+CdzouugXcO 6WdgOPNgnkA+cx1wH9nAd9BABE7F0f1d/40hzs62a1mEMlCf3JOVJ8WvU1Jcqf42WMfYfA7L xJyfYO+c2+PWX6ZoTYleX5bztfJgjSpmDzZecyspxQtb8zsrw2P5Sza0q+6Fh3mDEFaOHznw ciZY4+xpbrEIpmZdYTdCJU5UBBrqXFEGIb9ijNRtYjdlQshULBN9yH47D0uaMia3fx0DfYCB 26yWlh5P/LUCuI6K4CB48xKWpQblIg6H4KxpL1S6TgTCGrffpE5ly0LzuUd6JcUrGMHdwr31 tHyuDNu++cbCzj3g/M+RN9P6JV6m6iBee/GhiFF+IN09u0Pz238+eXyf/2qDf8Uj2gbUsEwa VDaEwLd8xGzgAYs7df6Fn7doXH5mQ/k1Vf5jl7llninqieiV2rY31uAEn+mZVZXT5aL36Sq9 /KmNLojEjA3A== X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="40730594" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SeVm0ZCRELaqX9eG9DkrJd405agACnmMP2L5JXfCHOlAs3lz8jKOfL7VyrhSOZgYLHLKbcKO76Rtk+2PtAS60hKRJ6w34ddQKiOR0x2JT+sjTPZnnbu8k7ZCRn0zZHLFPZ1qGAtALACGPQPAeDduMLrtLZVckqTEREghwvgBfsz3b66yEpgex0DYBdiDB0RDD99dsodqbw+pJLCBJvDIxglYkUYZxiQMY3R58TyNU3j4hlk/08C0nIcNvCYaVSWwapuf/rDU/p0m0Mmi++MFxEXT/KIM8Xal4BVtYRlfrvFcBIzHf9rW9jOyIcIEqqvkqyxzgKkDvgaGBMgdmUcmaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+791JNpeEdaqd7sL8/wPJrh4NVafG8GswQ+wOJdn8Cg=; b=j9XlgDMaSoTjBmIMTaSdDB6gXQQznmi5VLhRdMbqKFBCddd/mT9akQNm/FWpHzmkEN6MhZvlZpUarUeuiRw6QbW80k16Jdm2Q245AiteUdC9qKTBIo7XdvUsqy5EVuyitPF+YATbgXZUdOtgsgQjbLvBAewe75c5h+rG9g+R8HTze7ZNfA6WUquPGhrUFwW30PmuxxZRR61klPy1M7bTBJ6MA7m5+sb1GUROMJ6gYVyYIdw33BkxPEVio99dF6xJUPzVuaipVqRqwlurpchKd/8ddP1jaG5FicagdPTq8TrNCAec1IeZZ/zXa9+3zLpqIQ5ItdmcCgMmxdmyovVrsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+791JNpeEdaqd7sL8/wPJrh4NVafG8GswQ+wOJdn8Cg=; b=tvmlld+60Wcs8ZKk3CppQaspm/TrK2jvEyxzQoZXunzKITRiKEGJOcZuS8a464nAscxTv27PM9ssLyGCuJxfjHNmiOj9Ef1d5wETWrowsmjnqapwfgLnA3ySzUf+FMGQ/ex4FsHbRI7JPYy74eshnmsqKhCDpGABwq3KRp2vXz0= To: Roger Pau Monne , CC: Ian Jackson , Wei Liu , Anthony PERARD References: <20210323095849.37858-1-roger.pau@citrix.com> <20210323095849.37858-21-roger.pau@citrix.com> From: Andrew Cooper Subject: Re: [PATCH 20/21] libs/{light,guest}: implement xc_cpuid_apply_policy in libxl Message-ID: Date: Thu, 1 Apr 2021 18:44:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <20210323095849.37858-21-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0099.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::15) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f630900c-c3ce-4dde-675a-08d8f535c045 X-MS-TrafficTypeDiagnostic: BN3PR03MB2276: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oANtb03pswGLSbkAgG891PHakjXodvWU1e7OdC3IzBoCwlZuKOv5wJ5OUT0XGTcyTDYJkdp6l99J/4XWuBBxsJklFKcIkgWdc4WKhDG5cP5XSvivUjpaiSFCGp7DNnL8Nges787R2l8SGWKw33WFfK3z6lSQsfadzFsTQnm+FtCECIaV7Ka4us5nyoKwED/27KG31Env0kza+oJAo4blQ+Eb7Dta3WPbCfCpvyZSMt2cs4JyUSEmxdiNET9FcJw3w8lTUp4VzQMqlHOqf4O99jez2g3vLTrF4rJGgSb+F5SvZ+tlq8RMjpVOcvCz1G87Pp4AJlM0rysLyjHdreiOVBt7svVC0HFFLm4G7xvxtM0kCa/aaBwJSh3IvYJAPxesTPrL8Ts+JTWHLvX9uzPfU98GaoVRYJyXvcjE/n+puUzlwr3rVxu0CXj95kY1tgJ8bgp+R5tKuv+TkgDmwW15xDK4eGgN/VuI/1XOfBx5WnoLoXwWb+SecT2yEKgB6sd+ldTdmuAMAXizwpPDMwuOR16OvhahXYXSONroflh+hFMeNuPeUzXy2y9EMp13PDJYLz3J9FzdZp01RN1bS8DYQ/sb7AF62z8npjFXA6E7XG2ES5s06PXE2qOZFKpGysHEo15+4xGrxAWOB7EXzw9fWAi0gOha190/qwxSSOQHNzCW5/1Owoi/2XGU8rpQjhRtR6lRzxF418xZ5jpm+dzDA9MBlyhlUckYX+avklzWOJY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(346002)(376002)(39860400002)(366004)(136003)(8936002)(478600001)(54906003)(2616005)(4326008)(38100700001)(956004)(6666004)(2906002)(6486002)(8676002)(66946007)(31686004)(86362001)(107886003)(316002)(66556008)(16576012)(5660300002)(186003)(26005)(36756003)(53546011)(16526019)(31696002)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?SDNVSFFOWHF2R0E0b0dHTS83d0ZRMHF1bWJpckNZZ05pTXhoNTNPdEdhWEF3?= =?utf-8?B?NEVjZDVMM3liWW5YRVZBbXRlZTYzSTRhVFg0enFVRndEbkZ4RTJ3SkZ4ZVg4?= =?utf-8?B?eW1jaTRNUmdDZW05RjloWUw1WGY4SmRlb0tka0d6M25YZ1d2cDI0Y2hVeWc2?= =?utf-8?B?YTVnS1JMR3Fka1dlVUZqSytQZ09KdnRDQnhpcW56a213SVlxcUN4WS9mUHkx?= =?utf-8?B?cVpVNU5QSnVibW0rWlJoVyt3STcvNlY3RVpCSXJuc3J6NWtaT2x3emM2RTFx?= =?utf-8?B?YWwzaDdlVHNLbWsvaUxZejFZQ25JakxxTXlsdDlNY01ub0UvbjAydmI4Y09j?= =?utf-8?B?dUVCS3RDUDJOL2pZSkZLM1FPdlRLeUhuOXJGMEhWVlVPZGpvUDFWekE4WFNZ?= =?utf-8?B?OUVQR3RteEtlVlhWclpMaE4veFVudXpBd002ekQxSXllTlBnNW83aVgrNHZG?= =?utf-8?B?Qi9uZk1hT0lFRGZNQ1IvRVdQNlprOGFwcHVWWTNrK0lrQ0RFZEdXbUV5c3FB?= =?utf-8?B?NVFSZjEzZHd6b1FUbWQxcHpETm5qRjcyQ0x5blBDOHRabGQ3T1RKTXdFR09W?= =?utf-8?B?N0I4cUlGNXVvWVNSVVEwRjFDeGhET1c0blhiMUxHZHNrb20rd2NGVUZDZ2Ru?= =?utf-8?B?VkRqQlZlSDJJRzZ0Wlh5ajZhbnpoT0RQY1lWUHU3Qk1JcEZ2cTNqWHRsclRR?= =?utf-8?B?Vk50aHBiUWV2dWRjMG01V1YzUlE4S0hKNzlrQmErYWFGNFdDTlNiczRieXUv?= =?utf-8?B?ZHBpOWw1cmV4VzJpZ016bUxsak9ld1lPRDZ5QTRQUlYrVlV2K2NYTk5ZVnpp?= =?utf-8?B?YXVOZWtPVzlGU0RlaTNZRWx6ZnRIRUZ3Mi8zcWhkcU81cldESWF6UXZQY245?= =?utf-8?B?dWFERmYvTmZnaUJoTlBoZ1ZhbGh1Zm52Yzc0T1l1RjFkanBtOE56d0sxa0wr?= =?utf-8?B?WE9QWmlKZmN3bFB2b29pYnVQODkzb2FKeGhvb2lSWERSWkljUHYzc0NXdmdl?= =?utf-8?B?Z1hoOGdjMDBPWkhSNFl1V1d5RHhCUXJPUk9xK3FwNFN3Q1JLK1pEVnhPaUlN?= =?utf-8?B?U25vbDg2TzZXUzQzcHdkb3dSRVJ1YjREMnk1NGJUL2FJb1B4cVBZejUyb0l4?= =?utf-8?B?MHhoeEFsYVdCWTFRRnpXY05vdTRHeXA3d2taN3FIK0hkYkNYMVFOajZuSXR5?= =?utf-8?B?VFlaREdsWXVEaXFVeDA4TlRtVWZUOWhaZktoWDFaWjUrSndBOEZKN0VmR09K?= =?utf-8?B?VzVMN2xJOW11Y3hyMXdoWklPV0NjVS9EY09VNFEyalZQTEx4YjdSWDhoVFd4?= =?utf-8?B?Zy9IN2dxUUZSY2tWcWtZVUJJWVRheXd5OVk4NjdKcVYxT2dKcEg4NTNkd1ky?= =?utf-8?B?TU9oNk5VNlFpRHk0b2x3VFJZS0xad00xUzVWMnVwTWpiMU5EUHRDUWFGUHAy?= =?utf-8?B?RGVhQk5DbjkrUUJ0MWt0cWtvNmVwTHRmVmkxNWtwUjg3ano5ekpPYlUwaExQ?= =?utf-8?B?UDlqL2RrYnJSQW1DV2dmRGgxR0N6cS9CQTNweVNtU3ZxRW9XYWtxYVNXZS9F?= =?utf-8?B?Y2RJSGUxY2NqNG9NcVMzNXQ5ZFpLS2c5NUlPczFsMDJIZmpMOVFyYm9mUEJE?= =?utf-8?B?eFNaR3VQbllCT2xsc2R6aFRZTTVZZllDV2xUQS84b2dpVXB3VDVQY1Z2TXBJ?= =?utf-8?B?TkFrdTBJaHJrQ3dtSXlFbHc4NDJ3RnlOdzFySk10bGg4NjBPZlhSZWFaTDV1?= =?utf-8?Q?stCrBhjffUADomFAiT0yBTdHS4F4YjMaHxbbEjC?= X-MS-Exchange-CrossTenant-Network-Message-Id: f630900c-c3ce-4dde-675a-08d8f535c045 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 17:44:08.2639 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ve9tOgWQoDNu8uikKDz/PYRleluodQKnG2osYU0HtAbRLI1bMkjDlFj3xmxX4PK3uTEo8dMlAEmTm5CKpgkBCCjK5LiKj0SDQk4n9x1ZdYU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2276 X-OriginatorOrg: citrix.com On 23/03/2021 09:58, Roger Pau Monne wrote: > With the addition of the xc_cpu_policy_* now libxl can have better > control over the cpu policy, this allows removing the > xc_cpuid_apply_policy function and instead coding the required bits by > libxl in libxl__cpuid_legacy directly. > > Remove xc_cpuid_apply_policy. > > Signed-off-by: Roger Pau Monn=C3=A9 > --- > I'm unsure why this is called libxl__cpuid_legacy, mostly because I > don't seem to be able to spot a libxl__cpuid (ie: non-legacy version). > Should this be renamed to libxl__cpuid? > > 1b3cec69bf300e012a mentions the process of switching to a new cpuid > interface, but I'm not sure we need to keep libxl__cpuid_legacy, since > that's an internal interface that's not exposed to libxl clients > anyway. "legacy" was referring to the pre-4.14 migrate-in problem.=C2=A0 It was the best I could come up with without having a firm plan of how this series was going to look like. That said, the resulting function is still very definitely doing thing's I'd consider "legacy", so perhaps it wants to stay named like this until we've got a better plan for how to enable non-trivial features. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 01 17:53:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 17:53:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104698.200541 (Exim 4.92) (envelope-from ) id 1lS1Vt-0001J4-No; Thu, 01 Apr 2021 17:53:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104698.200541; Thu, 01 Apr 2021 17:53:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS1Vt-0001Ix-KN; Thu, 01 Apr 2021 17:53:49 +0000 Received: by outflank-mailman (input) for mailman id 104698; Thu, 01 Apr 2021 17:53:48 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS1Vs-0001Is-DY for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 17:53:48 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1e794911-75cd-40ff-96b3-4fdbb5303e00; Thu, 01 Apr 2021 17:53:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e794911-75cd-40ff-96b3-4fdbb5303e00 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617299626; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=J0mB+ca1/dHzwyG5wpDRMwjhv25AphJTBpchIQNnlvQ=; b=JvqB90gp/uUjFZq+sNIzONL1SzKRxsSh+ibcDL071ueEve7xwNGJ6UqQ 88QyXnKtFfcSuAIluKoJYGt8RXssFz79wfwxVLO+/6+gcgVfF6o2NjGRp WnncO4YkUEMTX8tR1MKGIOhI4lFuhOjwuQp0tDmFu1Ek61nEXhUd4VTpN Q=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: J+cM7BNsWdteVoJ+raiVGyBmkNbp7nusQdg5h2H8jyko8zw+NAaixsSgiB16B9PPz5orL9g+8q ky9ZVOc2vu+NtpMBSsn0lKRlzIaSKZ5+9vWyx0WWutdSl9/Kr6e0MRCj1V8ZVDXWytQxPORTHu M3TE7Ou3C6yGjXrspRJpfghqy0Yb9QGxe+i3Y3Ou5PTC233kLGbllQdmrVxjVtdBsxTcAXrvR9 K9xC2WoAjL45g1TtBb6DHbcHTsigxSyM5OVzNm1DXgV6Q7T39TI356cU9lxoX7VUA60oorjD3r DXs= X-SBRS: 5.2 X-MesageID: 42185845 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:lt96rq+WKHEw3K50DY1uk+F3cL1zdoIgy1knxilNYDRvWIixi9 2ukPMH1RX9lTYWXzUalcqdPbSbKEmzybdc2qNUGbu5RgHptC+TLI9k5Zb/2DGIIULD38Zn/+ Nbf6B6YeedMXFTkdv67A6kE9wp3dmA9+SSif3Dymp2JDsLV4hLxW5Ce2KmO2dxQxRLAod8MZ Ka6NZOqTbIQwVoUu2QAH4ZU+/f4+DRnJX9bhIcQzIh4g+CjTSngYSKbCSw9BEYTj9J3PMe4X HI+jaJmpmLntOa7lvn12HV54lLg9eJ8Lp+LeGFl8R9EESWti+Gf4JkMofy2gwdgObq01oylc mJnhFIBbUP11r0XkWY5STgwBPh1jFG0Q6R9Xa9jWH4qcL0ABIWYvAx/b5xSRfS50o+sNwU6s sitAj1xvknb2K1oA3H69fFTB1snEavyEBS9tI7tHBDTZAYLIZYsI13xjInLL47ACn45Io7ed Medf302fA+SyL+U1nkpGV1hPSjUnMvdy32OHQqi4i+1jhbm21B1E0IxMATtWdozuNMd7B0o8 vDKahmj7dIU4s/ar98Hv4IRY+NBnXKWg+kChPdHX3XUIU8f17doZ/+57s4oMmsZZwz1ZM33L DMSklRu2Iec1/nYPf+naFjw1ToeiGQTD7twsZR69xSobvnXofmNiWFVRQHj9agi+93OLyYZ9 +DfLZtR9PzJ2rnHohEmyfkXYNJFHUYWMoJ/v4mRlO1pN7RIIGCjJ2ZTN/jYJ7WVRo0UGL2BX UOGBLpIt9b00ytUnjkxDfLXXfAfVH+4IJQHKDW8/N78vlICqR89iwuzXip7MCCLjNP9oYsel FlHb/hmqSn4Um6lFy4qFlBC154NAJ48b/gW3RFqUshKEXva4sOvN2ZZCR31HuDLRlvctPOHG dk1hJK0JPyC6bV6TEpCtqhPG7fpWAUvmi2Q5AVnbDGwsv5ZJUiDNIDVLZqHQvGUzx58Dwa6F trWUshfAvyBznugaKqgNg/H+fEbeRxhw+tPIpzsnLQtUKVoOk1XXsFVzuSUcqa6DxeAgZ8tx lUyesykbCAkTGgJS8Um+IjKmBBb2yRHfZ7FgifXZ5VnbrqYQl0am+PiVWh+kgOU1uv039Xqn 3qLCWSd/2OJlZGoHhX3pzn905OenyHc1h9bW17toNBBX3L00wDpNOjV+6W6S+8e1ECyuYSPH X+bTweLhhH6vq32BSW8QzyWEkO99ELBKjwHb4je7bc1jeRM4WOj7gBBOIR1o1iLsrSvugCVv +/dweZICjjMf4g3xWYqx8eSXFJgUhhtcmt9Azu7WC+0nJ6POHbJ05+QaoHZ/6b9GrpSp+zod 1EpONwmdH1FGr/atSLk/6KKxFCLw7eum6wQaUDr4tOsac7qbt0GN36XFLzpQd69SR7CP2xsk UUBJlfyvTmHKREesQJYSJX/lYzjr20XQEWmz2zJtV7RE0nin/QAsiA7LXJo4c+G0HpnnqGBX Cvtwlmu8rfVySN1bQmG7s9DGRfZk878mlj9oq5BsTtITTvU+FI51yhNHChNJdbVaieAL0Vxy wKr+2grquydyDi3hrXsiY+CqVS83y/Scf3JA6XA+ZH/5ibPluL65Har/KbvXPSSTGhbV4fip AAXUsMbt5bgj1ntbYJ6EGJO+fKi3NgtUBf7zFhnkPs3YbjwF6zJzA2DSTpxrNMXTdSNXCUi9 /i6ubw7gWn3AR4 X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="42185845" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KDx5vURnzyPsw6rBUZ/bSSh6v0L56pyM6d1D2WbqO8hptLRPWoWotwwvot/4COvkP26IKYZPKifFSF2NXMzg4afhFfPeAzz7rzAXItGzhFTa3GqkM+CAwpTJ56FVl4rLi+f9lb0ZgYm14Lv6Z1bCoffHz5eokN5EEKEV88dqvR5YiwAY/xgwUOyRQidyn5hiDYGd4X6+3i5EK2KnXik4YVj4Ibkd2i5dgr1j5mu377bFFu0+h1gfNOMGzJW89S1+0IKbZftQTY0hw3xMAOVnntbJtK7LtNWbemikJ40J12AUXEbePHn3UmsvPD2RbwJgo5TnPEFgK1ybRfTm0/ZQIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J0mB+ca1/dHzwyG5wpDRMwjhv25AphJTBpchIQNnlvQ=; b=TOE+U+iOdRLDihPztCs8N4LDR6Ml813QTflspwT0NHUMWhor2g6tSTSQBWce0LbxNrq7+C4eETmh05wrzkCN2ErmAP0rBGb8SDWcQOHhboWcuXipEowXMBlu2LB8Y8VvpBcDYC5XOua/EVSVx+rKEM9s5n1y261cZS5sX5IoNHB/uyv0Jb5Oi+WrIVDzA5fjjVDVHdQXNDFfxMGyXKUwbMXK6mndMObsfm6b2jkUPD2Wg6u9zaOSsQCiVGPyRNmIBH3f95OJh0zOiX67azIfGXN0LAKv3vBp2vRx9UUkMV7pulQwJ1jd36qDrMUWa+EhPYrjGoXeDleE0BHjd+OpSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J0mB+ca1/dHzwyG5wpDRMwjhv25AphJTBpchIQNnlvQ=; b=nx6RbP8XZJNPegAJrucSeTFyIeUEj3ajU/Ov3ecw3iRJsf8NdsqCDZxKRxSFG3zU2YDQ0FO4g6eZqf40F04Lvon6YdzoIP7xoZTV1N+ilpBnGcXRoX2nZe1gnhE/n/vYzrYVOv4yV6MX0DRP3j+QGXF05mT56oLkVaFwvjoi+D0= To: Roger Pau Monne , CC: Ian Jackson , Wei Liu , Anthony PERARD References: <20210323095849.37858-1-roger.pau@citrix.com> <20210323095849.37858-22-roger.pau@citrix.com> From: Andrew Cooper Subject: Re: [PATCH 21/21] libs/guest: (re)move xc_cpu_policy_apply_cpuid Message-ID: <67f7251e-dbe6-37d9-472f-79937e9b1a01@citrix.com> Date: Thu, 1 Apr 2021 18:53:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <20210323095849.37858-22-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0445.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a9::18) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 87b978fe-e29c-4530-c935-08d8f53717a9 X-MS-TrafficTypeDiagnostic: BN3PR03MB2371: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6Ty1iysBRvDGwxyLtsXABzTrmJ0WYHbutxjKG4jvYrF0mv5+CTAOT+7IvvncNPQQXPQ0B1wHOJdnedxQY2ogsEbJ86Y4r1PAiWY2WyTloCsAQZUaWcomtax6LAAyVD/ylLaJlBrSloi9hkTzpgmy50w1B1Uj6eB/RQXAwcx08G8Vod7roNCIRU2PFgsEQRXItb6BkTxXlN04aXvc5em5zjmTI/TdKDb/pY0nwCItfy+c3apxFDobAIbES87UZAl0ogJRFQis4YuRA5J+vIs42mLBzFRs4PAEuxAcMFqW6iQg4ERIYNag4TdA+oWrhTtOv5g10/ZBXypbrtfHR9AicIatWvPbXcKXg8aBnayRXKjChq0AX3qYEzd/HKdkGfD/ark6RkOqdrbCVkC8HlBFvbTmQwfyhiss2hQO6JCgu+WDIfr/HpW4k39mWflhRfKy0Oj2n4EMQs0PO2BiqjBrnV8BoyQjId9HahlLr8R/kkCu4jQmAaous9FGIr9viDfFZByrvNmW6PtDTy64TkzH35xL6KebF3HXQLT251uU8FUkLL1IFkgGgVZYTf7dLTT1NdfyGTE0/tZxx1sbDFWBwFEkH+uqv2DjiOy3WCLmqjibFcF0xKP5mUzqn2B7tNUTCWhdS1j4tJqMfjHbpgt2PnzKt8eRrWRNhShdWXapd8y+VvjD89XCwUWgp8VcEcY7RRGB9IJ3L+FTJVjgvASxf8Mo1wnT7S8+so9qFsSTiaQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(376002)(346002)(366004)(39860400002)(136003)(107886003)(6666004)(36756003)(16526019)(66556008)(8676002)(186003)(5660300002)(26005)(31696002)(8936002)(53546011)(31686004)(956004)(478600001)(54906003)(6486002)(2616005)(66946007)(4326008)(16576012)(66476007)(38100700001)(86362001)(316002)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?SnJBd0VOUlphM05ySENXaGttM0E3MGhFSGdSOXZuZnpLYXFhcGlPMThLSEZM?= =?utf-8?B?cUpVVm83emxwNDJHY3VUUU5IYi8xYVBjOFA0cUVienY5UXBYdFFDWHVIWXIr?= =?utf-8?B?RWN3NittWmFNVTh5N1RRek5VTTFqMTZYNmRzdzIrakZaOUVLL1JuWnd4dkk0?= =?utf-8?B?REFMWVVMRXFPR0I2ZXVoeVZLYTJSdUZIWE9TRDlOM20vWGlMMWFOSjErMVNx?= =?utf-8?B?SWd1czZha2hCanZxT08zb2hITk1XbmdSZ3Vkeit1bmlMZ0hLaFQ5TndiMXo3?= =?utf-8?B?MnEvMUhRbWF0L2lOd2V3WjgzLzBWaWg2OHE2TnBiZE5oM0cvRkdtRC8zTThE?= =?utf-8?B?VEh0Y1ZjSFA5ZWxVRjE5MHh4Y2ZIYnJGdi9wSFlSS203NmRMVUFhR2NYWXJa?= =?utf-8?B?YWtwMnEvQllXQ1FLMU9DU2ZaTW0rQmovZjVWNEdObVFHWnppR0c2aUIzb2RP?= =?utf-8?B?WWlwVENnRk1oMGJueUYxOExXcVZ4QzVBeGtwZmRQcE5uZ1Nocnk4RDQwYXBi?= =?utf-8?B?anJVKzRUdDhka0F6WTkxcXRuWFVCL0FPQ2lIYTl4ay95YzAxelFVaHc2WHdV?= =?utf-8?B?V3NSaGMyeXE3NWpKS2xManJMdkdEMlhRdEFOdmhGajlFYndzcUc5U3FVUFBv?= =?utf-8?B?MG5VNm4rQXdNZDAvTHpCYkpaL3Qzd3hmOWdwTkhJNzk2SWhiVFc0NVVaTlBj?= =?utf-8?B?OHdUZEVRYTNzRElZcEJXdndJVk1hWENTNEQzVXlwSnJJNURnQi9lcTR3N2hY?= =?utf-8?B?UnlKc3RlRXJVWVQvZkxNaFhCL1BTRjMyeVdCdTl3TG9Xa0xyMHFYbW5WenRp?= =?utf-8?B?VC9oYStCN3pJZjlFOVZoRFQxdXZIanZXczAwRmVnRE41aHZUakpKeENBNlla?= =?utf-8?B?Y2pRR0NuUUtLVlBxZS9ZVnJ3VWZ3enl0RkQvamJaMVlPLzA0Yk1TT0lYQlUv?= =?utf-8?B?em5YNXBOM1lSOTFjTG1OOUMzZ0lXaVhNRjJML3lxaTlJRUlwZG45SnU0S1Va?= =?utf-8?B?N2VKWm9GUHV3NTUrMnNHVnFGMjZpREpaK0Y1by8vZFQ1ZytEVndoNm9HbkRt?= =?utf-8?B?UXVtYm5hS3NwVzhEZWtibjRiU01LS3hhOHZTaHZtSDNSalRod29reVowNk9Y?= =?utf-8?B?QVIwNXV2OWJab3JuSUF2UWVsRFZxM2E0WnRlUlU4SFAya2NjaGtiTnNqSkh4?= =?utf-8?B?MlBMc0hsNFMzcTdTcng1ME5SYmhHQzFVZ1Ftb2tERnNvWGwzcjhQZmJkV3hj?= =?utf-8?B?NWR2WVJZOXFoTUxzc3BqWXovbnVTT1U5Tk1IOXJORVZPdEUvdUdMalVXWThi?= =?utf-8?B?MWkyYWJDWXI0dlhkN2dTUzBhNzcza3ZSN0xCS3VTeE5ucFgwdUN5bTVocGkv?= =?utf-8?B?anZVbXRBOWlxeE5DeUx4ZVpTejgxWkZGb3VYOUtZeDhKTW10SHJiY3UyUnkw?= =?utf-8?B?R1d6MlVYMXBhamNUekxCV1AzeGZwbWlSYXVLYnRCdGtIeW00NVpjb0FuNG5l?= =?utf-8?B?SFBwTFFBbTEwSmpnbG9IQzBzMjEvU1A5Skw3WVBOdXdnZUNQTTB2Z0MrOE9C?= =?utf-8?B?ZE81eXgvLy8rNGROL1RkYzlKL1ptbzZaeHhXbWIrL1kvNjNRakIrQUNGS1VY?= =?utf-8?B?Vlp5eXd3QWp0NGxGMTZKNXFUUDNJSGFFcFZ3ckE1U1VVdVd1amtiVDZlZ1JI?= =?utf-8?B?ejRUbHFmcHRzQlhOTjJzL2tMaTYzcGFGSGgzNmxpdkRPQmxVWXU0eWVIQ0NJ?= =?utf-8?Q?c3qBaoQikIqb63fzk6iesYexPPPoAOERcIgfZyo?= X-MS-Exchange-CrossTenant-Network-Message-Id: 87b978fe-e29c-4530-c935-08d8f53717a9 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 17:53:44.3153 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tWuDEf4nVCi+iorOf1zsZM2J7pKQmmYmM52sdB2sUjuGl+Bgzr/mcwtYA52Xa9Q0XZMo8EYuUjMnCPIuEx/3IhT020zuwp8OfBPBRAyJOlI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2371 X-OriginatorOrg: citrix.com On 23/03/2021 09:58, Roger Pau Monne wrote: > Move the logic from xc_cpu_policy_apply_cpuid into libxl, now that the > xc_cpu_policy_* helpers allow modifying a cpu policy. Having xenguest > parsing CPUID data in xend format was a layering violation, and by > moving such parsing into libxl directly we can get rid of > xc_xend_cpuid, as libxl will now implement it's own private type for > storing CPUID information, which currently matches xc_xend_cpuid. > > Note the function logic is moved as-is, but requires adapting to the > libxl coding style. > > No functional change intended. > > Signed-off-by: Roger Pau Monn=C3=A9 Its not a layering violation IMO. It was only in 4.14 that I dropped the Python and Ocaml bindings for xend-format strings, in an effort to simplify this work.=C2=A0 Before then, libxc was absolutely the correct place for the logic to live. I do intend to re-add python bindings in due course, but I really don't expect that to extend to the xend format.=C2=A0 So moving this logic probab= ly fine, unless we're expecting to re-introduce it elsewhere? ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 01 17:56:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 17:56:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104703.200553 (Exim 4.92) (envelope-from ) id 1lS1YD-0001TK-99; Thu, 01 Apr 2021 17:56:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104703.200553; Thu, 01 Apr 2021 17:56:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS1YD-0001TD-61; Thu, 01 Apr 2021 17:56:13 +0000 Received: by outflank-mailman (input) for mailman id 104703; Thu, 01 Apr 2021 17:56:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS1YC-0001T5-1r; Thu, 01 Apr 2021 17:56:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS1YB-0003HT-PI; Thu, 01 Apr 2021 17:56:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS1YB-0007iC-IF; Thu, 01 Apr 2021 17:56:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lS1YB-0006ck-Ho; Thu, 01 Apr 2021 17:56:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1ZO7oKU/bkLPRw0PZdX3qiwwwvg+v0HUEr5CUYObJw0=; b=lViUSi291l1jo6W3w4/k2ntXAK X+urEP/8+xPwn15xdlKN8XrFjDOnHfKdFIpMjP+tbRQj48U1zm1S1ejPNLItaFLKcJ1Pgwy7vsEFY qaB939LKq5PTAC9QxZMXtMunlIH2rtfREbIM83X/3BK8V+0bfhe/ExhBNAjwCQBan8h4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 160645: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=5c3c410bd2ea8d2cc520e8e8f83ad143c9c5cff7 X-Osstest-Versions-That: xen=b0976d5c0441378b6348f5bfedbf431055bd0147 From: osstest service owner Date: Thu, 01 Apr 2021 17:56:11 +0000 flight 160645 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/160645/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 5c3c410bd2ea8d2cc520e8e8f83ad143c9c5cff7 baseline version: xen b0976d5c0441378b6348f5bfedbf431055bd0147 Last test of basis 160641 2021-04-01 11:00:28 Z 0 days Testing same since 160645 2021-04-01 15:01:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Roger Pau Monné jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git b0976d5c04..5c3c410bd2 5c3c410bd2ea8d2cc520e8e8f83ad143c9c5cff7 -> smoke From xen-devel-bounces@lists.xenproject.org Thu Apr 01 18:18:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 18:18:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104707.200567 (Exim 4.92) (envelope-from ) id 1lS1te-0003MD-4y; Thu, 01 Apr 2021 18:18:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104707.200567; Thu, 01 Apr 2021 18:18:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS1te-0003M6-1t; Thu, 01 Apr 2021 18:18:22 +0000 Received: by outflank-mailman (input) for mailman id 104707; Thu, 01 Apr 2021 18:18:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS1td-0003Ly-5F; Thu, 01 Apr 2021 18:18:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS1tc-0003ly-RX; Thu, 01 Apr 2021 18:18:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS1tc-0000KY-FV; Thu, 01 Apr 2021 18:18:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lS1tc-0000Pl-Ez; Thu, 01 Apr 2021 18:18:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=viqhVoenmfIYSSUcoFKsOXAcQhk8+Rqbg68wdci3RK4=; b=1/zLukLa4tW9l9KmxeRe/BUOze TvYHVM5KbLZ8Bvj03DHhRFweTr35m0ca1zKyNqlsK/1DfifrWQ0g7BvVnWgNWcdArTfl5jpCZ5dZV t/k4y+r1eLUsZV5M0Ql2XEL50fUUlUHikr7+/pCURjwgbVC3dqXYbbcYWve5bR6xEdi4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160632: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-amd64-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-freebsd10-i386:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-freebsd10-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-amd64-xl-credit2:guest-start:fail:regression qemu-mainline:test-amd64-i386-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-arm64-arm64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install/l1/l2:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-armhf-armhf-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=6ee55e1d10c25c2f6bf5ce2084ad2327e17affa5 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Thu, 01 Apr 2021 18:18:20 +0000 flight 160632 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/160632/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-qemuu-freebsd12-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-freebsd10-i386 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-freebsd10-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-amd64-xl-credit2 14 guest-start fail REGR. vs. 152631 test-amd64-i386-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-arm64-arm64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-qemuu-nested-intel 20 debian-hvm-install/l1/l2 fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: qemuu 6ee55e1d10c25c2f6bf5ce2084ad2327e17affa5 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 224 days Failing since 152659 2020-08-21 14:07:39 Z 223 days 421 attempts Testing same since 160632 2021-04-01 04:02:58 Z 0 days 1 attempts ------------------------------------------------------------ 469 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair fail test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 139001 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Apr 01 19:44:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 19:44:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104715.200588 (Exim 4.92) (envelope-from ) id 1lS3EU-0002Z2-Bm; Thu, 01 Apr 2021 19:43:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104715.200588; Thu, 01 Apr 2021 19:43:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS3EU-0002Yv-8Z; Thu, 01 Apr 2021 19:43:58 +0000 Received: by outflank-mailman (input) for mailman id 104715; Thu, 01 Apr 2021 19:43:57 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS3ET-0002Yq-AC for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 19:43:57 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 38150d97-88d7-4de6-9fe3-6380c3cdb12d; Thu, 01 Apr 2021 19:43:55 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 38150d97-88d7-4de6-9fe3-6380c3cdb12d DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617306235; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=5WTsbL6fVOVHN7q/idb6GJ+u9Mko5Q++oDqeEXsO4sI=; b=Dhbo/n0jHDzvsfEIJDSjNBAZU2AoO/cd3XVxZl8kIaoD0v7SG7hWW30y m/E7wj3VzjAgguBhamAAxOyyLVXrhUpfS8fDTzAq6aGiF3ycut8pW6Gn9 2PtbpwuX+bG7H0E+h8UL3STw4u5EY8I+sysuZDiYJkkO1JlMrGPY+GNFK 4=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: fVaHt3/uAjG1dlHl5keeAZrfvAdrskLPEnNBoLTHy4C6VGPtRsEiav9rv3Tzdimu1ypjb9GuSX SLvKP6EIrG5kFEvrpb1UY/ueWXnLklDHzD+1J2MmdAgx+ZcZwOL9Pmffsu+zVyRZuGam2KpzM+ XM1IYsqmT/TQWpQEVmjTvgvJK22PF2HRnLx4KMOZv/FiV0moJOTc7FK/hSjMSQGPWBBSCKVzcP l8WnQCx6uSmrhDFlVquqp0pzDO41uzehPsH9wUDl4Wq5gYVVajEzGsVDd1KaiGKOtGwe7ZqsHy x4E= X-SBRS: 5.2 X-MesageID: 40740297 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:uvAQM66ScUeRPzZZ0wPXwWeEI+orLtY04lQ7vn1ZYSd+NuSFis Gjm+ka3xfoiDAXHEotg8yEJbPoex3h3LZPy800Ma25VAfr/FGpIoZr8Jf4z1TbdBHW3tV2kZ 1te60WMrHNJHBnkMf35xS5Gd48wN+BtJuln/va0m0Fd2FXQotLhj0JbjqzOEtwWQVAGN4dHJ 2T+sJIq1ObCAoqR+68AWQIWPWGmsbCk4jobQVDKxks7gSPij3A0s+ELzGz2BACXzRThYoz6G StqX2E2oyPkdGejiXd2Wja8ohMlLLaq+drKcSQhqEuW07RoymyYoAJYczlgBkUp6WV5E8ugJ 3wpX4bTrlOwlfwWk3wnhf3wQnn118Vmg3f4HuVm2Hqr8C8ZB9SMbs4uatjfhHU61UtsbhHuc ohtQ/p1Os0fGf9tR/w6NTSWxZhmlDcmwtErccpg2FCSoxbUbdNrOUkjTBoOa0dFyH34p1PKp gWMOjg4p9tADanRkzCsnIq6NKhWWlbJGb9fmEy/uaR0zRQgUljyVoZyME1jh47heIAYqgByO LePqtykrZSCucQcKJmHe8EBfC6E2rXXHv3QSyvCGWiMJtCF2PGqpbx7rlwzOa2eKYQxJ93vJ jaSltXuUM7ZkqGM7zO4LR7tjT2BEmtVzXkzc9To7JjvKfnebbtOSqfDHgzjsqJuZwkc4/mcs f2HKgTL+7oLGPoF4oM9Rb5QYNuJX4XV9BQksonWmiJvtnAJuTRx6/mWceWAICoPScvW2v5DH dGdiP0Pt984keiXWK9rwPWX1/rZ0zj7bN9GKXX5IEoucwwH7wJljJQpUWy58mNJzEHmLcxZl FCLLTulb7+hWTexxeO00xZfj5mSmpF6rTpVH1H4SUQNVnvTLoFs9KDPURb3H6NIA5DX9rbeT Qv4WhfyOaSFdi91CoiA9WoPiaxlH0Ivk+HSJ8ah+ml6dr6fIg7SrIrQrZ4GwmONxEdo3crlE 5zLCs/AmPPHDLnjquoyLYOAvvEStV6iAC3ZehOqXzesk2Yjdo1RmQSWgOvVcL/u3dqexNkwn lKt4MPiruJnjiibUElhv4jDVFKYGOLRI5dAB+9f4VSkLDzcARWRWOH7Abq0i0bSy7PzQE/l2 bhJSqbdbXuDkBGsn5V6Krs7Wh5b36QZU52d3B8v7BsDGiugAcH7ca7Io6Il0eBYFoLxe8QdA vIZjYfOStC7dG63hz9okfOKVwWgrEVesDNBrUqdL/enk63IIqTjKccArt/55B+Lu3jtecNTM OScwKYNynDFusswgCZz0xVYBVcmT0Bq7fFyRfl5G+30DoDGvLUOk1hXKxeDNeG7WToLsz4mK lRvJYQh6+XPWrwYNLdlv2SQD5HNx/JoWm5C8svsotZuKoutL11W7nXOAG4ok1v7VEbFoPTkk hbfYFQpJbmEaVrd9YJey1Y8kEy/e7/ZncDg0jTOKsGYVopj3XnJNuH7LrDlKo3DiS61XzNEG ja1xcYwuzMUCSC34MLEq4cIWxZb04n9XRpldnyPrH4OUGPd+tZ+kC9PWL4WLhBSLKdEbF4lG c33/i428uWfTH/wgbeoH9SJb9P6X+uRYeXDBiXEeBFt/y8NlLkuNrk3OeDyBP2QyC8cUIWmM lsclERdN1Kjn0at7IMuxLCAZDfkwYCiFtR4TZui17r1MyH2Q7gbDB7GDycpI5XUzlVOmWPlu Lf/4GjpS/A3AQ= X-IronPort-AV: E=Sophos;i="5.81,296,1610427600"; d="scan'208";a="40740297" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QTqaZzQIS1lpKDX5TZpGN0IWAQMz3UJ2jBtzEeaV/3p2RtqKvlV8+I4Vh5UbqtCO3HjrnSnqByfKfVHvDCqKd4rXYZqN6sGHA8ZF4nQgzxa8cBSGCh6Z346PipLI9sJ1AObkYcmJkJxOWZynELlFig3KUFDkJRb01l4v/LRPiBBzpb+Ky9kD69EKEYsfhhkvUUSxXUOjZpPiE9gNpgZDetKfZ1VpmzKPfSm7Fd2priKOg+2kH5h8tr/2ZOHSwcfRqcSGGdff73d72gtqA3oUHityhGxNMpzWfo4IE8/8hOu6Y2dsBayWo3tIxwCJ96YXkSRfLw0u27QzMNOGhT9DsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5WTsbL6fVOVHN7q/idb6GJ+u9Mko5Q++oDqeEXsO4sI=; b=i1qgxVGETMoIe3s4cRcEODpvbOwDSnzVbfeJ+GqKwAG6FBfk9RKuiJIa6m8YmeOjO400kbxQFi/MgHk+flGvPFmFanTxBouCvdDrERSnHuTMiYh83X/UfaJZ47tMB8aWOQNC2Bs/KY0qegHLYICn1BMqGK4i+vD1T3BdUBNPA32q/aA3Mj7XHKA3WN2LqN/bREF56+P97rBAqQkqEpGWoPEEM/XtQpU3ctRaoHI6NOSch66UypAkSLmVZl8k61IpD5FwJMKrZijPpvjxn+lR0u7IV9faScPIHjlrddEj/1R1ljri0vIMUpICOFKigcM2L1qDSs1/vCOeK2I+BCrt9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5WTsbL6fVOVHN7q/idb6GJ+u9Mko5Q++oDqeEXsO4sI=; b=GLy0jvrT6w6bERK4CWuolM8dSdtHDt7EnUvVW2I7ul8HmIicYd2KPf1hUiISMIpNadhPDGVotjIgxMOoaGKluwsntaXU+/BqJvqzYf1yeJUoI1S26LwNa+jgHb7VK1nSPlWd4DXg/HHnIuEanScyTyFQsfIOvDaZeHIUlBLxlF8= To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jan Beulich CC: Roman Shaposhnik , Xen-devel , References: <23baec07-a3ae-949a-a1fb-09100efd53e5@citrix.com> From: Andrew Cooper Subject: Re: multiboot2 and module2 boot issues via GRUB2 Message-ID: Date: Thu, 1 Apr 2021 20:43:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0286.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:195::21) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b3f42fc8-3f6b-49c8-ee31-08d8f5467a9b X-MS-TrafficTypeDiagnostic: BN8PR03MB5122: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bPaCSVpcFVU3JQI+36AwWs0qG6d98Yiq6YWsuECcGUg0WqIAv4aai1Eudkbv8i0ET33Hudq58itTfO4BF/VJg5i5+Nvrw5naVvIPiSDYqvxKMCAkyAXCdOzfrfTZfseCQFA7zqVM8VUn4UVaqTU6ret+BVqc6ts+QT3cGfa3dE3HQig7uYMowUi7tAu2sBEJsEROG0m5ZLktz6wlqeNVJVfwZWXP9BDprCz1o8TukzUFgDZZxON/cJBpOYX08xD5zmO8AtMELbtJKCmSz5fL4nJr6k/cO68FbrdeSAbAp+85ATueFBXcr9IaN4HS2zYKddiacU34uvM6OIXF9Cpc/uklcPS4zFVQtj5JKMvzF+X6U/Sxk7gCfNAPld+RTa3ET8rlknUMk4zCqnVJElS3//xJ+qTVpY3wQVgGp/zfHhI6j5R18bJIVhk3itUqtouz6MkcFAgK+mpzrK7muzKse2v7PnwBXbagdzxA6uRAgxIgWJPZW11WrpKrDsglnGe3bYjQ7EmEGUVl3nv97dCIzXdG9zKFWs4SbIBFWGOqUroeicZXzsvLxquyaUBxQs08v6YWX8WhuwNILz+pZe5l6DmDHFcBuYoLUir1ogc/ZbVWVbUUvfPmNpCxUVpCayL+jtBA2pCJXx1c9opGDctO0QqnNORzpsR1l2knPw0bd9boYF9z5zEQG2fTapZy78Yg2ugmYMBsJGHFMy254UL2UI0aWy8WRwSH8RM4YQGKGxo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(39860400002)(136003)(366004)(376002)(396003)(54906003)(6666004)(26005)(31686004)(110136005)(53546011)(6486002)(16526019)(316002)(31696002)(8676002)(86362001)(186003)(4326008)(956004)(2616005)(66946007)(66476007)(5660300002)(66556008)(38100700001)(2906002)(16576012)(8936002)(36756003)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?dVJ6OXM5MjBGejJvSDZmUW54Nm1LZE1vc3VkNWNuSk03dXJ4Z1hJN0xBNGNp?= =?utf-8?B?dFFYMlJnaUtmYXFuM2k2STVYSU55RFZqdXdYRnRpZWNtdjlmbFEwbkxIekJ6?= =?utf-8?B?ZHNWMjdveEZJMnp1eHR3ZFQ0SFNkZmhRdHlQWmNLWlhmQ1gvTEpNNXllelln?= =?utf-8?B?YnFSem1NUHdwTUV5dzhTaGFBaFI3VEp6TEg5U0tIRDJUeXdRbjlEWVpFb1BR?= =?utf-8?B?Rnl5NHN6WXk1UzYvNkdHckxpZUNRM0pEcEhkdWY2REZQalc4NzdobVJSOWN5?= =?utf-8?B?NVdjdUpqclc0TVJWcmpsQVNSdkRyYzdYdHZqVStsYXJwcXo4T0dPUDd0K2Fx?= =?utf-8?B?QjdiZW5RQjUrdm4vNkxRU2FkQmYyYTRIcTNEa0FweXRPM09JalVvZXA3cFFY?= =?utf-8?B?TGt6QlUyU2Z0RzJTOFRUVG9zOVFkT1NRcUxIK3BJdjJIdFMvbnJrMlJNRks3?= =?utf-8?B?K3RDYWVwZ05xZDZMVkxveW9sVUh4dllqTkNkb3lCRFZOQ1p4OE5Cb3NjdmRh?= =?utf-8?B?MXFzc242VDJnMHl6bDRuQldsT1B6VjBlQXUvVXlCTzNlekw5MjVXVHg4c04x?= =?utf-8?B?VUZCMDFDVDdHZkttSHl5RlFFTTdxSEU1TDNkY2hKV2ZBbXlSczVnU21idUdn?= =?utf-8?B?TUZTcUxpODRpMzd1K1FQUXpVRTgwZlBhZ3dTemMyeE9YMG1XalREYjF4YWdF?= =?utf-8?B?dkhkSDNhQWpiemROSVY2THNMVTlZUXhGZ0I4UzU4QkI1emJZMzdRUlpnNEts?= =?utf-8?B?amF3WmJ3ZlJHQ2JOWFJRTVVGYlprK1ZHNlp2ek1LYVo1Z21ySkx1NlVWcmlB?= =?utf-8?B?UGV6OUdnTFdFWHdFLzduMmVZelQrMHBCY2xNeFBTZTBUdWFoYlE5SWhHc3R1?= =?utf-8?B?enZremNGZ2pOR3U1aE1jRnNRR0JWL2pHMnc2Tm8xQ0JmZU9vRkFsYUxsM0dl?= =?utf-8?B?SUxRVEhyN0loOVBFNUJpdSs4WVRDRk82a1FnMHJLRVZOM0NrZGNISUdKQWV5?= =?utf-8?B?bDEwRVcxcjJNaEdid2E2YUN0cEtNTmZJRW12SXBKb0NzY1JGcFV3NmUwa0Ir?= =?utf-8?B?SGhSMEltUThPY1VqTDJxanR6ZzMxSEl4UTRvWjhlWktYSStwTkhHY1lFWFpT?= =?utf-8?B?Nnc2dVNrbWY5elRwYmFNZm5QMzhiV29CaWdzSENSMEVFM0xxbzZNVFhXZ0Z5?= =?utf-8?B?MERqUDN1S3NPcFlGZGhxUWV2dDloWlBTV29LUTZYbCtBYXhBaU1jVjFuMVpY?= =?utf-8?B?SytMSzBOQXMyOVlIYytZL1MraU9SY3pYanpFQmcxK0p3WDVqTTU0QmxsMElM?= =?utf-8?B?bE5WU2VsZ2tGN1lGeXcxVEhacUlMY2ZSbFR4Z2FyZlBnMTlNZ1ptVWphclNi?= =?utf-8?B?U1ZOS0NkK0NXYnErcjViNEg2Z0tvTHZ0K3J6cE9sNTFBTlpEazFlaDB5emNR?= =?utf-8?B?ZlJzL24wNmpUczVIL3BiUjg0cHQ3UkNpZEdOVDVUUm5NcGIxRTNuTlI4MExC?= =?utf-8?B?S3FMVlZzakVoZEVjczBxQUlUWHBWR2FoOEpjOEZYZUZzWmNKalRZaEdLVmRo?= =?utf-8?B?Yk54WDNnZnROaEh5dE9xV3VhSUxGdDNERHhBeW82VXFJdTVrT0tKZWtjVThu?= =?utf-8?B?Vm93OFc0MnJPckt3dG9SYUFBOUoyK3FEajlsczZydmlvUjVsWXZMNVRDU1dj?= =?utf-8?B?NUlXd1RmeDNSRlB1WUZKOUtSNE1IM0VOOXJCRDdyWk1sTkI5ME1xTllUQWVt?= =?utf-8?Q?xAHatfmPpP1wsUCnR49ksFZsNFSqYerLUlk2j1f?= X-MS-Exchange-CrossTenant-Network-Message-Id: b3f42fc8-3f6b-49c8-ee31-08d8f5467a9b X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 19:43:52.9468 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RUsx0PUKubj8xWxev1iZX6eth3cgYbdNJY9UYbSqGte7wlWoAaVfrMkJUNH+39veDF0eGl7rnuFBgFHLrkIaGjhc0++sTlz1GDC5YIKWR88= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB5122 X-OriginatorOrg: citrix.com On 01/04/2021 09:44, Roger Pau Monn=C3=A9 wrote: > On Thu, Apr 01, 2021 at 09:31:07AM +0200, Jan Beulich wrote: >> On 01.04.2021 03:06, Roman Shaposhnik wrote: >>> And the obvious next question: is my EVE usecase esoteric enough that >>> I should just go ahead and do a custom GRUB patch or is there a more >>> general interest in this? >> Not sure if it ought to be a grub patch - the issue could as well >> be dealt with in Xen, by concatenating modules to form a monolithic >> initrd. > I would rather have it done in the loader than Xen, mostly because > it's a Linux boot specific format, and hence I don't think Xen should > have any knowledge about it. > > If it turns out to be impossible to implement on the loader side we > should consider doing it in Xen, but that's not my first option. Concatenating random things which may or may not be initrds is absolutely not something Xen should do.=C2=A0 We don't have enough context = to do it safely/sensibly. Honestly, I like the idea of supporting something like this generally in grub.=C2=A0 Linux already commonly has initrd preparation prepending an uncompressed microcode CPIO archive, and I can see a usability advantage from maintaining the initrd fragments separately. Looking at the grub manual, this behaviour of the `initrd` command isn't even documented.=C2=A0 Perhaps that should be fixed first, and then maybe `module2_multi` added too? ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Apr 01 21:07:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 21:07:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104746.200625 (Exim 4.92) (envelope-from ) id 1lS4Wy-0001OV-4H; Thu, 01 Apr 2021 21:07:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104746.200625; Thu, 01 Apr 2021 21:07:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS4Wy-0001OO-11; Thu, 01 Apr 2021 21:07:08 +0000 Received: by outflank-mailman (input) for mailman id 104746; Thu, 01 Apr 2021 21:07:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS4Wx-0001OD-IZ; Thu, 01 Apr 2021 21:07:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS4Wx-0006ZZ-88; Thu, 01 Apr 2021 21:07:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS4Ww-0000sd-VI; Thu, 01 Apr 2021 21:07:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lS4Ww-0003Vp-Uo; Thu, 01 Apr 2021 21:07:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=qusF9awHk26VGwGrc2yanEbfLHbxEZusDsZwlHtOd0w=; b=hdaeztjZTNgCB656+gSNKbi0YE uIVX6d5CrxNpA9ugp3jiqhUtFNzJQHCLFr5AfF36aiVXZkdad1ARKUJhw2V7syWTZUWPbx8Ll60F2 G3Y4umlQizuQZZQIlhumK8D0Ihsk2zYJE4f+jraPP1hfWKvTr9vlasirzvtmShieLqX4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 160648: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=0435784cc75dcfef3b5f59c29deb1dbb84265ddb X-Osstest-Versions-That: xen=5c3c410bd2ea8d2cc520e8e8f83ad143c9c5cff7 From: osstest service owner Date: Thu, 01 Apr 2021 21:07:06 +0000 flight 160648 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/160648/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 0435784cc75dcfef3b5f59c29deb1dbb84265ddb baseline version: xen 5c3c410bd2ea8d2cc520e8e8f83ad143c9c5cff7 Last test of basis 160645 2021-04-01 15:01:28 Z 0 days Testing same since 160648 2021-04-01 18:00:27 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Bertrand Marquis Julien Grall Michal Orzel Norbert Manthey Rahul Singh Stefano Stabellini Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 5c3c410bd2..0435784cc7 0435784cc75dcfef3b5f59c29deb1dbb84265ddb -> smoke From xen-devel-bounces@lists.xenproject.org Thu Apr 01 22:42:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Apr 2021 22:42:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104753.200646 (Exim 4.92) (envelope-from ) id 1lS60j-0001Rn-9Y; Thu, 01 Apr 2021 22:41:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104753.200646; Thu, 01 Apr 2021 22:41:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS60j-0001Rg-6R; Thu, 01 Apr 2021 22:41:57 +0000 Received: by outflank-mailman (input) for mailman id 104753; Thu, 01 Apr 2021 22:41:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS60h-0001RY-Q3; Thu, 01 Apr 2021 22:41:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS60h-00082p-G7; Thu, 01 Apr 2021 22:41:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS60h-0005Je-5F; Thu, 01 Apr 2021 22:41:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lS60h-0003gW-4h; Thu, 01 Apr 2021 22:41:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pvNAPrW7QEp9jkH7VC/vmnF7VGsz9dkudnCnq3Qetwk=; b=Ifs6Y9cRH8FmX/KR8yEwNz/i/a IKJu4rxRSpS098KL4GVXzt3YsmoeTRru+8fBpwgaFDETcG/5Uz7yohSDdfnCwzy4jazT0tpB3NyBR GXGHbtYQLNhfB1Zxca1UiY8o91hgladRPvo8fF0yi2jUSWs8RJlagI9pw0J3zlrqkkSU=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.12-testing test] 160638: regressions - FAIL X-Osstest-Failures: xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-localmigrate/x10:fail:regression xen-4.12-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-saverestore.2:fail:heisenbug xen-4.12-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=5b280a59c4dd8dad6cc8da28db981b193d10acee X-Osstest-Versions-That: xen=4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 From: osstest service owner Date: Thu, 01 Apr 2021 22:41:55 +0000 flight 160638 xen-4.12-testing real [real] flight 160653 xen-4.12-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160638/ http://logs.test-lab.xenproject.org/osstest/logs/160653/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 19 guest-localmigrate/x10 fail in 160549 REGR. vs. 159418 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 160549 pass in 160638 test-amd64-amd64-xl-qcow2 18 guest-saverestore.2 fail pass in 160549 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159418 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159418 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159418 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 5b280a59c4dd8dad6cc8da28db981b193d10acee baseline version: xen 4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 Last test of basis 159418 2021-02-16 15:06:11 Z 44 days Failing since 160128 2021-03-18 14:36:18 Z 14 days 16 attempts Testing same since 160150 2021-03-20 04:11:48 Z 12 days 14 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Christian Lindig Edwin Török Igor Druzhinin Jan Beulich Julien Grall Olaf Hering Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 311 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Apr 02 00:43:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Apr 2021 00:43:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104764.200673 (Exim 4.92) (envelope-from ) id 1lS7u5-00042k-Lk; Fri, 02 Apr 2021 00:43:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104764.200673; Fri, 02 Apr 2021 00:43:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS7u5-00042d-Ia; Fri, 02 Apr 2021 00:43:13 +0000 Received: by outflank-mailman (input) for mailman id 104764; Fri, 02 Apr 2021 00:43:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS7u3-00042T-HA; Fri, 02 Apr 2021 00:43:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS7u3-0002BH-7W; Fri, 02 Apr 2021 00:43:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lS7u2-0002Cx-TC; Fri, 02 Apr 2021 00:43:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lS7u2-00020k-Sf; Fri, 02 Apr 2021 00:43:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=j612omWyOiNfrRFGPKmEoH4bodVc68VwDW7ml7KE0to=; b=d5696UQnH25tD1JXohzrfgTMdD 0Jd8lAwS9u+1pw4plWs/SyRqtYOmpg8U2aZ6UpTFB7+ugvFE2Cx45ibEoXTmmuuLmA6bab+pTQt7c N/PE1U+oMCaQvQn8T1Z+yqJV497unhRl6w4RYRzy8b1mPxrJg3g8dyOwsScEL4cDCspo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160640: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=d19cc4bfbff1ae72c3505a00fb8ce0d3fa519e6c X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Fri, 02 Apr 2021 00:43:10 +0000 flight 160640 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160640/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux d19cc4bfbff1ae72c3505a00fb8ce0d3fa519e6c baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 244 days Failing since 152366 2020-08-01 20:49:34 Z 243 days 414 attempts Testing same since 160625 2021-03-31 18:28:28 Z 1 days 2 attempts ------------------------------------------------------------ 5276 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1311742 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Apr 02 04:43:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Apr 2021 04:43:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104778.200700 (Exim 4.92) (envelope-from ) id 1lSBdf-0007iE-Fz; Fri, 02 Apr 2021 04:42:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104778.200700; Fri, 02 Apr 2021 04:42:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSBdf-0007i4-82; Fri, 02 Apr 2021 04:42:31 +0000 Received: by outflank-mailman (input) for mailman id 104778; Fri, 02 Apr 2021 04:42:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSBdd-0007ht-A0; Fri, 02 Apr 2021 04:42:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSBdd-0005kC-4A; Fri, 02 Apr 2021 04:42:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSBdc-0005Qm-T0; Fri, 02 Apr 2021 04:42:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lSBdc-0005fe-SP; Fri, 02 Apr 2021 04:42:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=tJk++8356KwP48sI6ZA/W3V/4IQCoS7FawzzhKK+gHQ=; b=s1K79wRKOzGIQYllMrDI7Yn/an z5ZNGMF2xtRwzR2Mfr08cxRrpVQF/cZo37T4NVM8nno9NyShMSan9lqOOTfz6BdyI/70MJ0uyCcsP A8YqKoX3wbMdkvQ8u6tTLL/9AZNaIHBpM1ix9CkbH+mlk+0Pxz6AP0wLj3CQuOwfmgM4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Subject: [qemu-mainline bisection] complete test-amd64-i386-libvirt-xsm Message-Id: From: osstest service owner Date: Fri, 02 Apr 2021 04:42:28 +0000 branch xen-unstable xenbranch xen-unstable job test-amd64-i386-libvirt-xsm testid guest-start Tree: libvirt git://xenbits.xen.org/libvirt.git Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://git.qemu.org/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: qemuu git://git.qemu.org/qemu.git Bug introduced: 8d17adf34f501ded65a106572740760f0a75577c Bug not present: e67d8e2928200e24ecb47c7be3ea8270077f2996 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/160660/ commit 8d17adf34f501ded65a106572740760f0a75577c Author: Daniel P. Berrangé Date: Mon Feb 22 11:16:32 2021 +0000 block: remove support for using "file" driver with block/char devices The 'host_device' and 'host_cdrom' drivers must be used instead. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/qemu-mainline/test-amd64-i386-libvirt-xsm.guest-start.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/qemu-mainline/test-amd64-i386-libvirt-xsm.guest-start --summary-out=tmp/160660.bisection-summary --basis-template=152631 --blessings=real,real-bisect,real-retry qemu-mainline test-amd64-i386-libvirt-xsm guest-start Searching for failure / basis pass: 160632 fail [host=albana0] / 160125 [host=pinot1] 160119 [host=albana1] 160113 [host=chardonnay0] 160104 [host=chardonnay0] 160097 [host=chardonnay1] 160091 [host=elbling1] 160082 [host=pinot0] 160079 ok. Failure / basis pass flights: 160632 / 160079 (tree with no url: minios) Tree: libvirt git://xenbits.xen.org/libvirt.git Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://git.qemu.org/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git Latest 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 62bad17dcae18f55cb3bdc19909543dfdf928a2b 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6ee55e1d10c25c2f6bf5ce2084ad2327e17affa5 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 90629587e16e2efdb61da77f25c25fba3c4a5fd7 Basis pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6f8a81fc296535f73c48cf9563862e088cc71c57 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 14b95b3b8546db201e7efd0636ae0e215fae98f3 Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/libvirt.git#2c846fa6bcc11929c9fb857a22430fb9945654ad-2c846fa6bcc11929c9fb857a22430fb9945654ad https://gitlab.com/keycodemap/keycodemapdb.git#27acf0ef828bf719b2053ba398b195829413dbdd-27acf0ef828bf719b2053ba398b195829413dbdd git://xenbits.xen.org/linux-pvops.git#c3038e718a19fc596f7b1baba0f83d5146dc7784-c3038e718a19fc596f7b1baba0f83d5146dc7784 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0\ dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/osstest/ovmf.git#4751a48aeb2ab828b0a5cbdc585fd3642967cda1-62bad17dcae18f55cb3bdc19909543dfdf928a2b git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://git.qemu.org/qemu.git#6f8a81fc296535f73c48cf9563862e088cc71c57-6ee55e1d10c25c2f6bf5ce2084ad2327e17affa5 git://xenbits.xen.org/osstest/seabios.git#b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee-b0d61ec\ ef66eb05bd7a4eb7ada88ec5dab06dfee git://xenbits.xen.org/xen.git#14b95b3b8546db201e7efd0636ae0e215fae98f3-90629587e16e2efdb61da77f25c25fba3c4a5fd7 Loaded 25205 nodes in revision graph Searching for test results: 160079 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6f8a81fc296535f73c48cf9563862e088cc71c57 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 14b95b3b8546db201e7efd0636ae0e215fae98f3 160082 [host=pinot0] 160088 [] 160091 [host=elbling1] 160097 [host=chardonnay1] 160104 [host=chardonnay0] 160113 [host=chardonnay0] 160119 [host=albana1] 160125 [host=pinot1] 160134 fail irrelevant 160147 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 2e1293cbaac75e84f541f9acfa8e26749f4c3562 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160167 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 ca318882714080fb81fe9eb89a7b7934efc5bfae 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 bdee969c0e65d4d509932b1d70e3a3b2ffbff6d5 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160328 fail irrelevant 160361 fail irrelevant 160392 fail irrelevant 160418 fail irrelevant 160448 fail irrelevant 160477 fail irrelevant 160501 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b33cf5bfcb4c941370739dfbbe1532ff508fd29d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7b9a3c9f94bcac23c534bc9f42a9e914b433b299 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee e680cc48b7184d3489873d6776f84ba1fc238ced 160522 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b33cf5bfcb4c941370739dfbbe1532ff508fd29d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7b9a3c9f94bcac23c534bc9f42a9e914b433b299 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee e680cc48b7184d3489873d6776f84ba1fc238ced 160541 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b33cf5bfcb4c941370739dfbbe1532ff508fd29d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 ec2e6e016d24bd429792d08cf607e4c5350dcdaa b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee e680cc48b7184d3489873d6776f84ba1fc238ced 160577 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6f8a81fc296535f73c48cf9563862e088cc71c57 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 14b95b3b8546db201e7efd0636ae0e215fae98f3 160579 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b33cf5bfcb4c941370739dfbbe1532ff508fd29d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 ec2e6e016d24bd429792d08cf607e4c5350dcdaa b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee e680cc48b7184d3489873d6776f84ba1fc238ced 160580 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 f2a9a6c2a86570ccbf8c5c30cbb8bf723168c459 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160563 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b33cf5bfcb4c941370739dfbbe1532ff508fd29d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7993b0f83fe5c3f8555e79781d5d098f99751a94 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee cead8c0d17462f3a1150b5657d3f4eaa88faf1cb 160618 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b33cf5bfcb4c941370739dfbbe1532ff508fd29d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7993b0f83fe5c3f8555e79781d5d098f99751a94 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee cead8c0d17462f3a1150b5657d3f4eaa88faf1cb 160620 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8a40754bca14df63c6d2ffe473b68a270dc50679 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160623 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7286d62d4e259be8cecf3dc2deea80ecc14489a5 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160624 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 2255564fd21059960966b47212def9069cb56077 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160626 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6e71c36557ed41017e634ae392fa80f03ced7fa1 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160627 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 5d1428d6c43942cfb40a909e4c30a5cbb81bda8f b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160628 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8b858f9998a9d59a9a7188f2c5c6ffb99eff6115 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160629 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 30ca7eddc486646fa19c9619fcf233ceaa65e28c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160619 fail irrelevant 160631 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 571d413b5da6bc6f1c2aaca8484717642255ddb0 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160633 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6f8a81fc296535f73c48cf9563862e088cc71c57 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 14b95b3b8546db201e7efd0636ae0e215fae98f3 160635 fail irrelevant 160637 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 f2e8319d456724c3d8514d943dc4607e2f08e88a b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee b4011741e6b39a8fd0ed5aded96c16c45ead5888 160639 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 ab5b8a3fb41d035ea320ce85593ba505ea5305bc b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160642 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f3bdfc41866edf7c256e689deb9d091a950c8fca 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6e31b3a5c34c6e5be7ef60773e607f189eaa15f3 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee b4011741e6b39a8fd0ed5aded96c16c45ead5888 160643 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8d17adf34f501ded65a106572740760f0a75577c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160644 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b50101833987b47e0740f1621de48637c468c3d1 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160632 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 62bad17dcae18f55cb3bdc19909543dfdf928a2b 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6ee55e1d10c25c2f6bf5ce2084ad2327e17affa5 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 90629587e16e2efdb61da77f25c25fba3c4a5fd7 160647 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 e67d8e2928200e24ecb47c7be3ea8270077f2996 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160649 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 62bad17dcae18f55cb3bdc19909543dfdf928a2b 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6ee55e1d10c25c2f6bf5ce2084ad2327e17affa5 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 90629587e16e2efdb61da77f25c25fba3c4a5fd7 160651 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8d17adf34f501ded65a106572740760f0a75577c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160652 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8d17adf34f501ded65a106572740760f0a75577c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160654 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 e67d8e2928200e24ecb47c7be3ea8270077f2996 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160657 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8d17adf34f501ded65a106572740760f0a75577c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160659 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 e67d8e2928200e24ecb47c7be3ea8270077f2996 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160660 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8d17adf34f501ded65a106572740760f0a75577c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 Searching for interesting versions Result found: flight 160079 (pass), for basis pass Result found: flight 160632 (fail), for basis failure Repro found: flight 160633 (pass), for basis pass Repro found: flight 160649 (fail), for basis failure 0 revisions at 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 e67d8e2928200e24ecb47c7be3ea8270077f2996 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 No revisions left to test, checking graph state. Result found: flight 160647 (pass), for last pass Result found: flight 160652 (fail), for first failure Repro found: flight 160654 (pass), for last pass Repro found: flight 160657 (fail), for first failure Repro found: flight 160659 (pass), for last pass Repro found: flight 160660 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: qemuu git://git.qemu.org/qemu.git Bug introduced: 8d17adf34f501ded65a106572740760f0a75577c Bug not present: e67d8e2928200e24ecb47c7be3ea8270077f2996 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/160660/ commit 8d17adf34f501ded65a106572740760f0a75577c Author: Daniel P. Berrangé Date: Mon Feb 22 11:16:32 2021 +0000 block: remove support for using "file" driver with block/char devices The 'host_device' and 'host_cdrom' drivers must be used instead. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé Revision graph left in /home/logs/results/bisect/qemu-mainline/test-amd64-i386-libvirt-xsm.guest-start.{dot,ps,png,html,svg}. ---------------------------------------- 160660: tolerable FAIL flight 160660 qemu-mainline real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/160660/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: test-amd64-i386-libvirt-xsm 14 guest-start fail baseline untested jobs: build-i386-libvirt pass test-amd64-i386-libvirt-xsm fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Fri Apr 02 07:37:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Apr 2021 07:37:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104799.200757 (Exim 4.92) (envelope-from ) id 1lSEMJ-0005pr-Rh; Fri, 02 Apr 2021 07:36:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104799.200757; Fri, 02 Apr 2021 07:36:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSEMJ-0005pk-Op; Fri, 02 Apr 2021 07:36:47 +0000 Received: by outflank-mailman (input) for mailman id 104799; Fri, 02 Apr 2021 07:36:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSEMJ-0005pc-4q; Fri, 02 Apr 2021 07:36:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSEMI-0000T4-Se; Fri, 02 Apr 2021 07:36:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSEMI-0004TP-EX; Fri, 02 Apr 2021 07:36:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lSEMI-0006yN-Dx; Fri, 02 Apr 2021 07:36:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=8xB5PhpdUZm/7D908c0RS9RpKsBhiYJWPXWRSIyOrBI=; b=wraGLAFi88j+bNhWtwP4H8zAKA Y9nQJe/O9vwpPXlGiMkbwR7ZR+twTz2pkJTVxqHeAlo44MeN/VTOpjb8SAXL2FFbGUZKrSTE3nYCw eeAyXXLo7DreqVzvME/PHhU9US9LjjNSY2BeVXygCGA2mkQzATUtnHtbPwfjfkyZZCP0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 160646: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=b0976d5c0441378b6348f5bfedbf431055bd0147 X-Osstest-Versions-That: xen=90629587e16e2efdb61da77f25c25fba3c4a5fd7 From: osstest service owner Date: Fri, 02 Apr 2021 07:36:46 +0000 flight 160646 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/160646/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160630 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160630 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160630 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160630 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160630 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160630 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160630 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160630 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160630 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160630 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160630 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass version targeted for testing: xen b0976d5c0441378b6348f5bfedbf431055bd0147 baseline version: xen 90629587e16e2efdb61da77f25c25fba3c4a5fd7 Last test of basis 160630 2021-04-01 01:51:44 Z 1 days Testing same since 160646 2021-04-01 15:07:43 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: George Dunlap Jan Beulich Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 90629587e1..b0976d5c04 b0976d5c0441378b6348f5bfedbf431055bd0147 -> master From xen-devel-bounces@lists.xenproject.org Fri Apr 02 10:21:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Apr 2021 10:21:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104829.200791 (Exim 4.92) (envelope-from ) id 1lSGvP-0003qq-E6; Fri, 02 Apr 2021 10:21:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104829.200791; Fri, 02 Apr 2021 10:21:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSGvP-0003qj-AI; Fri, 02 Apr 2021 10:21:11 +0000 Received: by outflank-mailman (input) for mailman id 104829; Fri, 02 Apr 2021 10:21:09 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSGvN-0003qe-HW for xen-devel@lists.xenproject.org; Fri, 02 Apr 2021 10:21:09 +0000 Received: from kirsty.vergenet.net (unknown [202.4.237.240]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 73c10569-e52c-45ac-bf19-7d7f8e5753b4; Fri, 02 Apr 2021 10:21:08 +0000 (UTC) Received: from madeliefje.horms.nl (tulip.horms.nl [83.161.246.101]) by kirsty.vergenet.net (Postfix) with ESMTPA id 893C625BE8B; Fri, 2 Apr 2021 21:01:20 +1100 (AEDT) Received: by madeliefje.horms.nl (Postfix, from userid 7100) id 9A2A53602; Fri, 2 Apr 2021 12:01:18 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 73c10569-e52c-45ac-bf19-7d7f8e5753b4 Date: Fri, 2 Apr 2021 12:01:18 +0200 From: Simon Horman To: Raphael Ning Cc: kexec@lists.infradead.org, Julien Grall , Hongyan Xia , xen-devel@lists.xenproject.org, Raphael Ning Subject: Re: [PATCH] kexec-xen: Use correct image type for Live Update Message-ID: <20210402100118.GF18086@vergenet.net> References: <20210323175923.7342-1-raphning@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210323175923.7342-1-raphning@gmail.com> Organisation: Horms Solutions BV User-Agent: Mutt/1.10.1 (2018-07-13) On Tue, Mar 23, 2021 at 05:59:23PM +0000, Raphael Ning wrote: > From: Raphael Ning > > Unlike xen_kexec_load(), xen_kexec_unload() and xen_kexec_status() > fail to distinguish between normal kexec and Xen Live Update image > types. > > Fix that by introducing a new helper function that maps internal > flags to KEXEC_TYPE_*, and using it throughout kexec-xen.c. > > Signed-off-by: Raphael Ning Thanks, applied. From xen-devel-bounces@lists.xenproject.org Fri Apr 02 10:54:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Apr 2021 10:54:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104835.200803 (Exim 4.92) (envelope-from ) id 1lSHRp-0006U0-4V; Fri, 02 Apr 2021 10:54:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104835.200803; Fri, 02 Apr 2021 10:54:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSHRp-0006Tt-19; Fri, 02 Apr 2021 10:54:41 +0000 Received: by outflank-mailman (input) for mailman id 104835; Fri, 02 Apr 2021 10:54:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSHRn-0006Tl-NE; Fri, 02 Apr 2021 10:54:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSHRn-0004Hb-EK; Fri, 02 Apr 2021 10:54:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSHRn-0000eK-37; Fri, 02 Apr 2021 10:54:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lSHRn-0000ff-2Y; Fri, 02 Apr 2021 10:54:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=fHmKJHJKYxZnUmjD6w31Zk6G1nNCnYH7ywHQUZ1hYzs=; b=BgwC24BIxJPAmeR3xKxpMVxMx6 a58lXM8CybI/EDzoxf+idEnEa+mz30PNlkTR3cdr8NQjJfKQuev8EipjEFMs7bqcagkMhLyg/rQdB 3ojpEJ4b7GludyO5mrBwkk3Iw8WZIxHXlN62I02RGS3Awdn7zlnDHYXpGQytJgm4gdeg=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160650: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-amd64-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-freebsd10-i386:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-freebsd10-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-i386-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-arm64-arm64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install/l1/l2:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-armhf-armhf-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=00084bab87c43be20638de7f191d1a1faed134cc X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Fri, 02 Apr 2021 10:54:39 +0000 flight 160650 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/160650/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-qemuu-freebsd12-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-freebsd10-i386 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-freebsd10-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-i386-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-arm64-arm64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-qemuu-nested-intel 20 debian-hvm-install/l1/l2 fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: qemuu 00084bab87c43be20638de7f191d1a1faed134cc baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 225 days Failing since 152659 2020-08-21 14:07:39 Z 223 days 422 attempts Testing same since 160650 2021-04-01 18:40:40 Z 0 days 1 attempts ------------------------------------------------------------ 469 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair fail test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 139464 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Apr 02 11:37:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Apr 2021 11:37:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104844.200824 (Exim 4.92) (envelope-from ) id 1lSI6t-0001dK-Hj; Fri, 02 Apr 2021 11:37:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104844.200824; Fri, 02 Apr 2021 11:37:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSI6t-0001dD-Dl; Fri, 02 Apr 2021 11:37:07 +0000 Received: by outflank-mailman (input) for mailman id 104844; Fri, 02 Apr 2021 11:37:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSI6s-0001d5-6B; Fri, 02 Apr 2021 11:37:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSI6r-0004x4-UM; Fri, 02 Apr 2021 11:37:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSI6r-0002fM-Nn; Fri, 02 Apr 2021 11:37:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lSI6r-0008Lg-ND; Fri, 02 Apr 2021 11:37:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=VhKPHJVGp/BmuK1ZkvQk1wEdqg8lH487cHQvIkL5A4o=; b=qQp8IdU1ORTwOTddc8B2xhq2Ae pjFuaO31LIKnxoir5N0XFS91gEPOp71iPLfUTMnsssN/15u5wmr+d7jWYOuPxQq8xXSmFtVkdhC/z fpiuhjcukC0aAr9FFiiqRO5FlrCmiNA9aP3Ktb+YjwKgY9bVh78pRsLGP4ERAQi30dek=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 160661: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=2fc3a704e7083afab0537cf0777521afa9cc1db6 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Fri, 02 Apr 2021 11:37:05 +0000 flight 160661 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/160661/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt 2fc3a704e7083afab0537cf0777521afa9cc1db6 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 266 days Failing since 151818 2020-07-11 04:18:52 Z 265 days 258 attempts Testing same since 160661 2021-04-02 04:19:00 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei simmon Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin WangJian Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yaroslav Kargin Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 49860 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Apr 02 12:53:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Apr 2021 12:53:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104863.200839 (Exim 4.92) (envelope-from ) id 1lSJIL-00007C-IK; Fri, 02 Apr 2021 12:53:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104863.200839; Fri, 02 Apr 2021 12:53:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSJIL-000073-EM; Fri, 02 Apr 2021 12:53:01 +0000 Received: by outflank-mailman (input) for mailman id 104863; Fri, 02 Apr 2021 12:52:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSJIJ-00006v-Kk; Fri, 02 Apr 2021 12:52:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSJIJ-0006B5-Bu; Fri, 02 Apr 2021 12:52:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSJIJ-00064d-34; Fri, 02 Apr 2021 12:52:59 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lSJIJ-0003XY-2e; Fri, 02 Apr 2021 12:52:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=lyw8dqIWc1dXiZUuFs+af52G0kpRC3Gc5/fidQGG9aI=; b=qnBxOssgwc/7p7++WynYigxMdx Z0pznoxokR3znAhxjDoCGFUENh1b3dGRHcbrcaCJpJNZ8M4hdLez078uaKF1uE5llxK1UKeHoWCuH f4ksiXsJfk5BGZ+75m+93zaj5yb49wyscfIDpaaK2dLM9zV8AoGgGZ5tOEnRUEdFEGLk=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 160656: all pass - PUSHED X-Osstest-Versions-This: ovmf=8c8922988544d31e8c87dd595f209828edcee962 X-Osstest-Versions-That: ovmf=62bad17dcae18f55cb3bdc19909543dfdf928a2b From: osstest service owner Date: Fri, 02 Apr 2021 12:52:59 +0000 flight 160656 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/160656/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 8c8922988544d31e8c87dd595f209828edcee962 baseline version: ovmf 62bad17dcae18f55cb3bdc19909543dfdf928a2b Last test of basis 160578 2021-03-31 06:11:04 Z 2 days Testing same since 160656 2021-04-01 23:40:07 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michael D Kinney jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 62bad17dca..8c89229885 8c8922988544d31e8c87dd595f209828edcee962 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Apr 02 13:56:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Apr 2021 13:56:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104873.200859 (Exim 4.92) (envelope-from ) id 1lSKHb-0005GV-AP; Fri, 02 Apr 2021 13:56:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104873.200859; Fri, 02 Apr 2021 13:56:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSKHb-0005GO-7X; Fri, 02 Apr 2021 13:56:19 +0000 Received: by outflank-mailman (input) for mailman id 104873; Fri, 02 Apr 2021 13:56:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSKHa-0005GG-OD; Fri, 02 Apr 2021 13:56:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSKHa-0007AO-IA; Fri, 02 Apr 2021 13:56:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSKHa-0000k2-89; Fri, 02 Apr 2021 13:56:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lSKHa-000633-7e; Fri, 02 Apr 2021 13:56:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=wXfvjr+kx+UKflE5VNxq75Yc++Flb4EJI6lAeJCmwv8=; b=KiURYaydvzO4I9JMcN2M9ordcH Zi7o5e3UMItFU1N/CUBqHvYhu7TuTNsj/PQIWGS81JMu0OR7MrEmoTNEIvL0zWB4DnL5jm0mWCi4R Ew7CICeSFgoCeWwp86T5fGhCPbEw5NTsYe3gF/bF9oa6a8DjANHKkigHyfJq0IokljDo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.12-testing test] 160655: regressions - trouble: broken/fail/pass X-Osstest-Failures: xen-4.12-testing:test-armhf-armhf-libvirt-raw::broken:regression xen-4.12-testing:test-armhf-armhf-xl-credit1::broken:regression xen-4.12-testing:test-armhf-armhf-xl-vhd::broken:regression xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-localmigrate/x10:fail:regression xen-4.12-testing:test-armhf-armhf-xl-vhd:host-install(5):broken:heisenbug xen-4.12-testing:test-armhf-armhf-libvirt-raw:host-install(5):broken:heisenbug xen-4.12-testing:test-armhf-armhf-xl-credit1:host-install(5):broken:heisenbug xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-saverestore.2:fail:heisenbug xen-4.12-testing:test-armhf-armhf-xl:debian-install:fail:heisenbug xen-4.12-testing:test-armhf-armhf-libvirt:guest-start/debian.repeat:fail:heisenbug xen-4.12-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=5b280a59c4dd8dad6cc8da28db981b193d10acee X-Osstest-Versions-That: xen=4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 From: osstest service owner Date: Fri, 02 Apr 2021 13:56:18 +0000 flight 160655 xen-4.12-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/160655/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt-raw broken test-armhf-armhf-xl-credit1 broken test-armhf-armhf-xl-vhd broken test-amd64-amd64-xl-qcow2 19 guest-localmigrate/x10 fail REGR. vs. 159418 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-vhd 5 host-install(5) broken pass in 160638 test-armhf-armhf-libvirt-raw 5 host-install(5) broken pass in 160638 test-armhf-armhf-xl-credit1 5 host-install(5) broken pass in 160638 test-amd64-amd64-xl-qcow2 18 guest-saverestore.2 fail in 160638 pass in 160655 test-armhf-armhf-xl 12 debian-install fail pass in 160638 test-armhf-armhf-libvirt 18 guest-start/debian.repeat fail pass in 160638 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 160638 like 159418 test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 160638 never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 160638 never pass test-armhf-armhf-xl 15 migrate-support-check fail in 160638 never pass test-armhf-armhf-xl 16 saverestore-support-check fail in 160638 never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 160638 never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail in 160638 never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail in 160638 never pass test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159418 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159418 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass version targeted for testing: xen 5b280a59c4dd8dad6cc8da28db981b193d10acee baseline version: xen 4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 Last test of basis 159418 2021-02-16 15:06:11 Z 44 days Failing since 160128 2021-03-18 14:36:18 Z 14 days 17 attempts Testing same since 160150 2021-03-20 04:11:48 Z 13 days 15 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Christian Lindig Edwin Török Igor Druzhinin Jan Beulich Julien Grall Olaf Hering Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 broken test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw broken test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd broken ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-libvirt-raw broken broken-job test-armhf-armhf-xl-credit1 broken broken-job test-armhf-armhf-xl-vhd broken broken-step test-armhf-armhf-xl-vhd host-install(5) broken-step test-armhf-armhf-libvirt-raw host-install(5) broken-step test-armhf-armhf-xl-credit1 host-install(5) Not pushing. (No revision log; it would be 311 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Apr 02 15:21:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Apr 2021 15:21:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104889.200893 (Exim 4.92) (envelope-from ) id 1lSLbk-0004TO-2z; Fri, 02 Apr 2021 15:21:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104889.200893; Fri, 02 Apr 2021 15:21:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSLbj-0004TC-US; Fri, 02 Apr 2021 15:21:11 +0000 Received: by outflank-mailman (input) for mailman id 104889; Fri, 02 Apr 2021 15:21:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSLbi-0004Sg-Ki for xen-devel@lists.xenproject.org; Fri, 02 Apr 2021 15:21:10 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSLbh-00009b-4a; Fri, 02 Apr 2021 15:21:09 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lSLbg-00050B-Lx; Fri, 02 Apr 2021 15:21:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=te5kaNXq8bksPb82UmeoTorpvM3eU7KlnC/ugaiKlh0=; b=i5VnM/fHHX4xETLMqpi8WbN7dy w4RtyLji/syt7qaC2kl3m9Ao9qoVrd8kfXS6KEQNVAj0W1DCzzxBqyOz2gzaGdJf1ESA7TxhswHjW CGVQ8JKhNMZBUoQ0/ZeT0HnVFqftOrR6iukqSDh9PO47Z8vQKOWO9FuO/kYg1a9Ymmnk=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, Julien Grall , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu Subject: [PATCH 0/2] xen/arm: Couple of bug fixes when decompressing kernels Date: Fri, 2 Apr 2021 16:21:03 +0100 Message-Id: <20210402152105.29387-1-julien@xen.org> X-Mailer: git-send-email 2.17.1 From: Julien Grall Hi all, The main goal of this series is to address the bug report [1]. It is not possible While testing the series, I also noticed that it is not possible to re-use the same compressed kernel for multiple domains as the module will be overwritten during the first decompression. I am still a bit undecided how to fix it. We can either create a new module for the uncompressed kernel and link with the compressed kernel. Or we could decompress everytime. One inconvenience to kernel to only decompress once is we have to keep it until all the domains have booted. This may means a lot of memory to be wasted just for keeping the uncompressed kernel (one my setup, it takes ~3 times more space). Any opinions on how to approach it? Cheers, [1] https://lists.xenproject.org/archives/html/xen-users/2021-02/msg00027.html Julien Grall (2): xen/arm: kernel: Propagate the error if we fail to decompress the kernel xen/gunzip: Allow perform_gunzip() to be called multiple times xen/arch/arm/kernel.c | 8 +++++++- xen/common/gunzip.c | 5 +++++ xen/common/inflate.c | 6 ++++++ 3 files changed, 18 insertions(+), 1 deletion(-) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri Apr 02 15:21:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Apr 2021 15:21:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104890.200910 (Exim 4.92) (envelope-from ) id 1lSLbl-0004Uz-GG; Fri, 02 Apr 2021 15:21:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104890.200910; Fri, 02 Apr 2021 15:21:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSLbl-0004Us-Cn; Fri, 02 Apr 2021 15:21:13 +0000 Received: by outflank-mailman (input) for mailman id 104890; Fri, 02 Apr 2021 15:21:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSLbk-0004Ui-Nm for xen-devel@lists.xenproject.org; Fri, 02 Apr 2021 15:21:12 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSLbj-00009o-PF; Fri, 02 Apr 2021 15:21:11 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lSLbj-00050B-EP; Fri, 02 Apr 2021 15:21:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=jQfOL7sF0Ax2+OqBBQai2IFHdDIfjtAQ7KE5lYnqt0Y=; b=gv+DsuaLbFWMDN4dwFQLxy6t+ yuFXCq5ZQAMJkrwLTwuX0Mz/MJBvTbulaBmBt1Q993VWbR+PTA8mZvm0SPlKUUtkOsmBexrEYRcY1 V4KrLOu6zWgicNymonlWP8bQMNSCMfRcu2B0/nM/rq54VdUONKLKDjvhiUF7BpzaFui2k=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH 2/2] xen/gunzip: Allow perform_gunzip() to be called multiple times Date: Fri, 2 Apr 2021 16:21:05 +0100 Message-Id: <20210402152105.29387-3-julien@xen.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210402152105.29387-1-julien@xen.org> References: <20210402152105.29387-1-julien@xen.org> From: Julien Grall Currently perform_gunzip() can only be called once because the the internal state (e.g allocate) is not fully re-initialized. This works fine if you are only booting dom0. But this will break when booting multiple using the dom0less that uses compressed kernel images. This can be resolved by re-initializing bytes_out, malloc_ptr, malloc_count every time perform_gunzip() is called. Note the latter is only re-initialized for hardening purpose as there is no guarantee that every malloc() are followed by free() (It should in theory!). Take the opportunity to check the return of alloc_heap_pages() to return an error rather than dereferencing a NULL pointer later on failure. Reported-by: Charles Chiou Signed-off-by: Julien Grall --- xen/common/gunzip.c | 5 +++++ xen/common/inflate.c | 6 ++++++ 2 files changed, 11 insertions(+) diff --git a/xen/common/gunzip.c b/xen/common/gunzip.c index db4efcd34b77..425d64e904d8 100644 --- a/xen/common/gunzip.c +++ b/xen/common/gunzip.c @@ -114,11 +114,16 @@ __init int perform_gunzip(char *output, char *image, unsigned long image_len) window = (unsigned char *)output; free_mem_ptr = (unsigned long)alloc_xenheap_pages(HEAPORDER, 0); + if ( !free_mem_ptr ) + return -ENOMEM; + free_mem_end_ptr = free_mem_ptr + (PAGE_SIZE << HEAPORDER); + init_allocator(); inbuf = (unsigned char *)image; insize = image_len; inptr = 0; + bytes_out = 0; makecrc(); diff --git a/xen/common/inflate.c b/xen/common/inflate.c index f99c985d6135..d8c28a3e9593 100644 --- a/xen/common/inflate.c +++ b/xen/common/inflate.c @@ -238,6 +238,12 @@ STATIC const ush mask_bits[] = { static unsigned long INITDATA malloc_ptr; static int INITDATA malloc_count; +static void init_allocator(void) +{ + malloc_ptr = free_mem_ptr; + malloc_count = 0; +} + static void *INIT malloc(int size) { void *p; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri Apr 02 15:21:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Apr 2021 15:21:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104888.200887 (Exim 4.92) (envelope-from ) id 1lSLbj-0004Ss-QA; Fri, 02 Apr 2021 15:21:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104888.200887; Fri, 02 Apr 2021 15:21:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSLbj-0004Sl-Ml; Fri, 02 Apr 2021 15:21:11 +0000 Received: by outflank-mailman (input) for mailman id 104888; Fri, 02 Apr 2021 15:21:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSLbi-0004Sb-Hy for xen-devel@lists.xenproject.org; Fri, 02 Apr 2021 15:21:10 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSLbi-00009f-3w; Fri, 02 Apr 2021 15:21:10 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lSLbh-00050B-Qp; Fri, 02 Apr 2021 15:21:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=8l2SWhRF4hXjT/n8ib3kpA3rAz6cYAQdMNmVVhQCfJc=; b=sZgkbqyKP4h660FFtsmJw+U7d uaIGvr6cJxJHac3CJ7UWPOxUrkgFZx9cJLjwUMP05gOTM4RpUSF92RdZB2tKqWCZev1SdMqOuhUj5 ugMJhLkS52TzXfkeCIviCGmyFyEb/7PQ0l93y2sgniwl8KgThtDnO6trrZGAwSlv/VIKU=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, Julien Grall , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH 1/2] xen/arm: kernel: Propagate the error if we fail to decompress the kernel Date: Fri, 2 Apr 2021 16:21:04 +0100 Message-Id: <20210402152105.29387-2-julien@xen.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210402152105.29387-1-julien@xen.org> References: <20210402152105.29387-1-julien@xen.org> From: Julien Grall Currently, we are ignoring any error from perform_gunzip() and replacing the compressed kernel with the "uncompressed" kernel. If there is a gzip failure, then it means that the output buffer may contain garbagge. So it can result to various sort of behavior that may be difficult to root cause. In case of failure, free the output buffer and propagate the error. We also need to adjust the return check for kernel_compress() as perform_gunzip() may return a positive value. Take the opportunity to adjust the code style for the check. Signed-off-by: Julien Grall --- xen/arch/arm/kernel.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c index ab78689ed2a6..f6b60ab77355 100644 --- a/xen/arch/arm/kernel.c +++ b/xen/arch/arm/kernel.c @@ -292,6 +292,12 @@ static __init int kernel_decompress(struct bootmodule *mod) iounmap(input); vunmap(output); + if ( rc ) + { + free_domheap_pages(pages); + return rc; + } + mod->start = page_to_maddr(pages); mod->size = output_size; @@ -503,7 +509,7 @@ int __init kernel_probe(struct kernel_info *info, /* if it is a gzip'ed image, 32bit or 64bit, uncompress it */ rc = kernel_decompress(mod); - if (rc < 0 && rc != -EINVAL) + if ( rc && rc != -EINVAL ) return rc; #ifdef CONFIG_ARM_64 -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri Apr 02 15:51:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Apr 2021 15:51:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104905.200925 (Exim 4.92) (envelope-from ) id 1lSM4l-0007GX-Tl; Fri, 02 Apr 2021 15:51:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104905.200925; Fri, 02 Apr 2021 15:51:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSM4l-0007GQ-Qc; Fri, 02 Apr 2021 15:51:11 +0000 Received: by outflank-mailman (input) for mailman id 104905; Fri, 02 Apr 2021 15:51:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSM4k-0007GL-Rs for xen-devel@lists.xenproject.org; Fri, 02 Apr 2021 15:51:10 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSM4k-0000dr-G1; Fri, 02 Apr 2021 15:51:10 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lSM4k-0007En-4r; Fri, 02 Apr 2021 15:51:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=96ZKz1XmVWDUX9O90srYP7TKBuT4+NLELAxUsP7ryl8=; b=R4hgIoOsFE7yXyA2OwciAkNIAM JOsokbamE5Wb/jU0E4TABqEXBTjR3KJMCyLKaSuKiOUaZlExQin/Uf04QYirrtLJbNs9xv3ohN1mv j9fF0TE7/Cz4Lg2kYmRaPBXDiJY2zMj8SlRnE3SoZM4qyefXe14SJ8Wcnaboog22DjBY=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, Julien Grall , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH v2] xen/iommu: smmu: Silence clang in arm_smmu_device_dt_probe() Date: Fri, 2 Apr 2021 16:51:06 +0100 Message-Id: <20210402155106.15486-1-julien@xen.org> X-Mailer: git-send-email 2.17.1 From: Julien Grall Clang 11 will throw the following error: smmu.c:2284:18: error: cast to smaller integer type 'enum arm_smmu_arch_version' from 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast] smmu->version = (enum arm_smmu_arch_version)of_id->data; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ The error can be prevented by initially casting to (uintptr_t) and then enum. Signed-off-by: Julien Grall --- Changes in v2: - Cast to (uintptr_t) rather than introduce separate pointer (requested by Andrew). Only build tested --- xen/drivers/passthrough/arm/smmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c index 20ac672e91b6..fab7be8b48bb 100644 --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -2382,7 +2382,7 @@ static int arm_smmu_device_dt_probe(struct platform_device *pdev) smmu->dev = dev; of_id = of_match_node(arm_smmu_of_match, dev->of_node); - smmu->version = (enum arm_smmu_arch_version)of_id->data; + smmu->version = (enum arm_smmu_arch_version)(uintptr_t)of_id->data; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); smmu->base = devm_ioremap_resource(dev, res); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri Apr 02 16:12:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Apr 2021 16:12:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104911.200941 (Exim 4.92) (envelope-from ) id 1lSMP7-0001EX-NY; Fri, 02 Apr 2021 16:12:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104911.200941; Fri, 02 Apr 2021 16:12:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSMP7-0001EQ-KH; Fri, 02 Apr 2021 16:12:13 +0000 Received: by outflank-mailman (input) for mailman id 104911; Fri, 02 Apr 2021 16:12:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSMP6-0001EH-2v; Fri, 02 Apr 2021 16:12:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSMP5-0001Y1-NQ; Fri, 02 Apr 2021 16:12:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSMP5-0006Hg-Cv; Fri, 02 Apr 2021 16:12:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lSMP5-0005Hc-CR; Fri, 02 Apr 2021 16:12:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=JRsA7CEVOFkO+dsUkLWfUnIIxcAxAGtmwio7aTcW1OQ=; b=cJkzlL4J0NGFV6zoIciaopvj8D zR/poBsv7wyfCyw174GOpiL9oX1GjO0/kVsnGOBn3vwXeXJtt1VDUozszPUHuCO3PzpDoAFZXSYwZ bVOiUbIVFu77j8hRG92qRPSwH0fBZwHSgkM4PH/wtBKOJxV04fM36iGFB1eNBkMspG0M=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160658: regressions - trouble: broken/fail/pass X-Osstest-Failures: linux-linus:test-armhf-armhf-libvirt::broken:regression linux-linus:test-armhf-armhf-libvirt-raw::broken:regression linux-linus:test-armhf-armhf-xl::broken:regression linux-linus:test-armhf-armhf-xl-arndale::broken:regression linux-linus:test-armhf-armhf-xl-credit1::broken:regression linux-linus:test-armhf-armhf-xl-credit2::broken:regression linux-linus:test-armhf-armhf-xl-multivcpu::broken:regression linux-linus:test-armhf-armhf-xl-rtds::broken:regression linux-linus:test-armhf-armhf-xl-vhd::broken:regression linux-linus:test-armhf-armhf-examine:host-install:broken:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-armhf-armhf-libvirt:host-install(5):broken:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:host-install(5):broken:nonblocking linux-linus:test-armhf-armhf-xl-rtds:host-install(5):broken:nonblocking linux-linus:test-armhf-armhf-xl-credit2:host-install(5):broken:nonblocking linux-linus:test-armhf-armhf-xl-vhd:host-install(5):broken:nonblocking linux-linus:test-armhf-armhf-xl:host-install(5):broken:nonblocking linux-linus:test-armhf-armhf-xl-arndale:host-install(5):broken:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:host-install(5):broken:nonblocking linux-linus:test-armhf-armhf-xl-credit1:host-install(5):broken:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=1678e493d530e7977cce34e59a86bb86f3c5631e X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Fri, 02 Apr 2021 16:12:11 +0000 flight 160658 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160658/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt broken test-armhf-armhf-libvirt-raw broken test-armhf-armhf-xl broken test-armhf-armhf-xl-arndale broken test-armhf-armhf-xl-credit1 broken test-armhf-armhf-xl-credit2 broken test-armhf-armhf-xl-multivcpu broken test-armhf-armhf-xl-rtds broken test-armhf-armhf-xl-vhd broken test-armhf-armhf-examine 5 host-install broken REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 5 host-install(5) broken blocked in 152332 test-armhf-armhf-libvirt-raw 5 host-install(5) broken blocked in 152332 test-armhf-armhf-xl-rtds 5 host-install(5) broken blocked in 152332 test-armhf-armhf-xl-credit2 5 host-install(5) broken blocked in 152332 test-armhf-armhf-xl-vhd 5 host-install(5) broken blocked in 152332 test-armhf-armhf-xl 5 host-install(5) broken blocked in 152332 test-armhf-armhf-xl-arndale 5 host-install(5) broken blocked in 152332 test-armhf-armhf-xl-multivcpu 5 host-install(5) broken blocked in 152332 test-armhf-armhf-xl-credit1 5 host-install(5) broken blocked in 152332 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 1678e493d530e7977cce34e59a86bb86f3c5631e baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 244 days Failing since 152366 2020-08-01 20:49:34 Z 243 days 415 attempts Testing same since 160658 2021-04-02 01:11:10 Z 0 days 1 attempts ------------------------------------------------------------ 5283 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl broken test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale broken test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 broken test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 broken test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt broken test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu broken test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw broken test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds broken test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd broken ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-libvirt broken broken-job test-armhf-armhf-libvirt-raw broken broken-job test-armhf-armhf-xl broken broken-job test-armhf-armhf-xl-arndale broken broken-job test-armhf-armhf-xl-credit1 broken broken-job test-armhf-armhf-xl-credit2 broken broken-job test-armhf-armhf-xl-multivcpu broken broken-job test-armhf-armhf-xl-rtds broken broken-job test-armhf-armhf-xl-vhd broken broken-step test-armhf-armhf-libvirt host-install(5) broken-step test-armhf-armhf-libvirt-raw host-install(5) broken-step test-armhf-armhf-xl-rtds host-install(5) broken-step test-armhf-armhf-xl-credit2 host-install(5) broken-step test-armhf-armhf-xl-vhd host-install(5) broken-step test-armhf-armhf-xl host-install(5) broken-step test-armhf-armhf-xl-arndale host-install(5) broken-step test-armhf-armhf-xl-multivcpu host-install(5) broken-step test-armhf-armhf-examine host-install broken-step test-armhf-armhf-xl-credit1 host-install(5) Not pushing. (No revision log; it would be 1312937 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Apr 02 21:18:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Apr 2021 21:18:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104992.201008 (Exim 4.92) (envelope-from ) id 1lSRAh-0001QA-0m; Fri, 02 Apr 2021 21:17:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104992.201008; Fri, 02 Apr 2021 21:17:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSRAg-0001Q3-Ty; Fri, 02 Apr 2021 21:17:38 +0000 Received: by outflank-mailman (input) for mailman id 104992; Fri, 02 Apr 2021 21:17:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSRAf-0001Pv-O9; Fri, 02 Apr 2021 21:17:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSRAf-0006fD-Gy; Fri, 02 Apr 2021 21:17:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSRAf-0004n2-3M; Fri, 02 Apr 2021 21:17:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lSRAf-0004a0-2s; Fri, 02 Apr 2021 21:17:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=g6s8RGwPsuKMFnc08nsXkAcVpCtR1SXQEApPEufzGFE=; b=XoTBuNa0hXJGI2ditxXwAJrmfF emblDLeWNif59JbzDlAkiTELCri3AoLLZSO33dbKcWYvsJNWJktXa0ZbKFV4B2TBiSLSdGC/3LqE3 qRIDJcoMwdQKjo5i/2eLosYOVNuxeVTnOw7OrqifWxatfKxUHddtzmwEgHNn18qNwtJM=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 160665: regressions - trouble: broken/fail/pass X-Osstest-Failures: xen-unstable:test-armhf-armhf-libvirt::broken:regression xen-unstable:test-armhf-armhf-libvirt:host-install(5):broken:regression xen-unstable:test-arm64-arm64-xl-seattle:xen-boot:fail:regression xen-unstable:test-armhf-armhf-xl-arndale:xen-boot:fail:regression xen-unstable:test-armhf-armhf-xl-vhd:xen-boot:fail:regression xen-unstable:test-armhf-armhf-examine:reboot:fail:regression xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression xen-unstable:test-armhf-armhf-xl-credit1:guest-start:fail:regression xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=0435784cc75dcfef3b5f59c29deb1dbb84265ddb X-Osstest-Versions-That: xen=b0976d5c0441378b6348f5bfedbf431055bd0147 From: osstest service owner Date: Fri, 02 Apr 2021 21:17:37 +0000 flight 160665 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/160665/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt broken test-armhf-armhf-libvirt 5 host-install(5) broken REGR. vs. 160646 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 160646 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 160646 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 160646 test-armhf-armhf-examine 8 reboot fail REGR. vs. 160646 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 160646 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REGR. vs. 160646 test-armhf-armhf-xl-credit1 14 guest-start fail REGR. vs. 160646 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 160646 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160646 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160646 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160646 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160646 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160646 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160646 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160646 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160646 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160646 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160646 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass version targeted for testing: xen 0435784cc75dcfef3b5f59c29deb1dbb84265ddb baseline version: xen b0976d5c0441378b6348f5bfedbf431055bd0147 Last test of basis 160646 2021-04-01 15:07:43 Z 1 days Testing same since 160665 2021-04-02 07:40:09 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Bertrand Marquis Jan Beulich Julien Grall Michal Orzel Norbert Manthey Rahul Singh Roger Pau Monné Stefano Stabellini Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt broken test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-libvirt broken broken-step test-armhf-armhf-libvirt host-install(5) Not pushing. (No revision log; it would be 412 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Apr 03 00:49:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Apr 2021 00:49:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105009.201041 (Exim 4.92) (envelope-from ) id 1lSUTq-0002vI-Ao; Sat, 03 Apr 2021 00:49:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105009.201041; Sat, 03 Apr 2021 00:49:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSUTq-0002vB-6G; Sat, 03 Apr 2021 00:49:38 +0000 Received: by outflank-mailman (input) for mailman id 105009; Sat, 03 Apr 2021 00:49:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSUTo-0002v3-6n; Sat, 03 Apr 2021 00:49:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSUTn-0002Co-Oj; Sat, 03 Apr 2021 00:49:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSUTn-0008EL-F1; Sat, 03 Apr 2021 00:49:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lSUTn-0001GA-EW; Sat, 03 Apr 2021 00:49:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ul9LNMX8nqzR2ehAV0f5ci26bEj3GVmzMLKiRplabpQ=; b=zUEKF1yPzY6GmmhoF+K6rMRM3D 8tac7/ma7NcST6RnqutVDmqK+Unju6CRhLtfG+dvu7HmTSckYhtKVBQpjPVeBQBG1R1+Wa3pZ0D/G 64nQUgDKUbtoJ64XckqqdcJvgvoARrY8Qzq+nk3VvPFQd7fBPs29dceIeO5etEKxefN8=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160669: regressions - trouble: broken/fail/pass X-Osstest-Failures: qemu-mainline:test-armhf-armhf-libvirt::broken:regression qemu-mainline:test-armhf-armhf-libvirt-raw::broken:regression qemu-mainline:test-armhf-armhf-xl::broken:regression qemu-mainline:test-armhf-armhf-xl-arndale::broken:regression qemu-mainline:test-armhf-armhf-xl-credit1::broken:regression qemu-mainline:test-armhf-armhf-xl-multivcpu::broken:regression qemu-mainline:test-armhf-armhf-xl-vhd::broken:regression qemu-mainline:test-armhf-armhf-xl-cubietruck::broken:regression qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-amd64-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-freebsd10-i386:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-freebsd10-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-i386-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-arm64-arm64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install/l1/l2:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-multivcpu:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-armhf-armhf-xl:host-install(5):broken:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:host-install(5):broken:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:host-install(5):broken:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:host-install(5):broken:nonblocking qemu-mainline:test-armhf-armhf-libvirt:host-install(5):broken:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:host-install(5):broken:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:host-install(5):broken:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:host-install(5):broken:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=415fa2fe91e2a49fe8d56d6aacc8f8db82c74775 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Sat, 03 Apr 2021 00:49:35 +0000 flight 160669 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/160669/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt broken test-armhf-armhf-libvirt-raw broken test-armhf-armhf-xl broken test-armhf-armhf-xl-arndale broken test-armhf-armhf-xl-credit1 broken test-armhf-armhf-xl-multivcpu broken test-armhf-armhf-xl-vhd broken test-armhf-armhf-xl-cubietruck broken test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-qemuu-freebsd12-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-freebsd10-i386 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-freebsd10-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-i386-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-arm64-arm64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-qemuu-nested-intel 20 debian-hvm-install/l1/l2 fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-multivcpu 22 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl 5 host-install(5) broken blocked in 152631 test-armhf-armhf-xl-vhd 5 host-install(5) broken blocked in 152631 test-armhf-armhf-xl-credit1 5 host-install(5) broken blocked in 152631 test-armhf-armhf-xl-arndale 5 host-install(5) broken blocked in 152631 test-armhf-armhf-libvirt 5 host-install(5) broken blocked in 152631 test-armhf-armhf-libvirt-raw 5 host-install(5) broken blocked in 152631 test-armhf-armhf-xl-cubietruck 5 host-install(5) broken blocked in 152631 test-armhf-armhf-xl-multivcpu 5 host-install(5) broken blocked in 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: qemuu 415fa2fe91e2a49fe8d56d6aacc8f8db82c74775 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 225 days Failing since 152659 2020-08-21 14:07:39 Z 224 days 423 attempts Testing same since 160669 2021-04-02 10:56:34 Z 0 days 1 attempts ------------------------------------------------------------ 471 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl broken test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale broken test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 broken test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck broken test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt broken test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu broken test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair fail test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw broken test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd broken ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-libvirt broken broken-job test-armhf-armhf-libvirt-raw broken broken-job test-armhf-armhf-xl broken broken-job test-armhf-armhf-xl-arndale broken broken-job test-armhf-armhf-xl-credit1 broken broken-job test-armhf-armhf-xl-multivcpu broken broken-job test-armhf-armhf-xl-vhd broken broken-job test-armhf-armhf-xl-cubietruck broken broken-step test-armhf-armhf-xl host-install(5) broken-step test-armhf-armhf-xl-vhd host-install(5) broken-step test-armhf-armhf-xl-credit1 host-install(5) broken-step test-armhf-armhf-xl-arndale host-install(5) broken-step test-armhf-armhf-libvirt host-install(5) broken-step test-armhf-armhf-libvirt-raw host-install(5) broken-step test-armhf-armhf-xl-cubietruck host-install(5) broken-step test-armhf-armhf-xl-multivcpu host-install(5) Not pushing. (No revision log; it would be 139682 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Apr 03 04:21:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Apr 2021 04:21:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105023.201074 (Exim 4.92) (envelope-from ) id 1lSXmp-0001vW-De; Sat, 03 Apr 2021 04:21:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105023.201074; Sat, 03 Apr 2021 04:21:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSXmp-0001vO-85; Sat, 03 Apr 2021 04:21:27 +0000 Received: by outflank-mailman (input) for mailman id 105023; Sat, 03 Apr 2021 04:21:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSXmn-0001vG-VZ; Sat, 03 Apr 2021 04:21:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSXmn-0003Af-Ku; Sat, 03 Apr 2021 04:21:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSXmn-0002Rb-CF; Sat, 03 Apr 2021 04:21:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lSXmn-0006RZ-Bi; Sat, 03 Apr 2021 04:21:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=IIbu19qVM/+CbYss0vn1YZuQ49QdA+kLbGJTVsQdweo=; b=2tc/yjcSu4oGtSmwr4uf34o2ko Yzr73XTQYeexz7Hcc09lt95N92v4oUKVC9yelkLQGfHDgoZ1ad2ZHTqidiKszHvroMl1KQcN0zH30 teXFox3OnMD0kWGpjta2tP0TeJxNIRt1fzg8obc9qmMEt3d5wtBi2wvcnICt58KJY0yc=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.12-testing test] 160672: regressions - trouble: blocked/broken/fail/pass X-Osstest-Failures: xen-4.12-testing:build-armhf::broken:regression xen-4.12-testing:build-armhf:host-install(4):broken:regression xen-4.12-testing:test-armhf-armhf-xl-credit1::broken:regression xen-4.12-testing:test-armhf-armhf-libvirt-raw::broken:regression xen-4.12-testing:test-armhf-armhf-xl-vhd::broken:regression xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-localmigrate/x10:fail:regression xen-4.12-testing:test-armhf-armhf-xl-vhd:host-install(5):broken:heisenbug xen-4.12-testing:test-armhf-armhf-libvirt-raw:host-install(5):broken:heisenbug xen-4.12-testing:test-armhf-armhf-xl-credit1:host-install(5):broken:heisenbug xen-4.12-testing:test-armhf-armhf-xl:debian-install:fail:heisenbug xen-4.12-testing:test-armhf-armhf-libvirt:guest-start/debian.repeat:fail:heisenbug xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-saverestore.2:fail:heisenbug xen-4.12-testing:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking xen-4.12-testing:build-armhf-libvirt:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=5b280a59c4dd8dad6cc8da28db981b193d10acee X-Osstest-Versions-That: xen=4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 From: osstest service owner Date: Sat, 03 Apr 2021 04:21:25 +0000 flight 160672 xen-4.12-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/160672/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 4 host-install(4) broken REGR. vs. 159418 test-armhf-armhf-xl-credit1 broken in 160655 test-armhf-armhf-libvirt-raw broken in 160655 test-armhf-armhf-xl-vhd broken in 160655 test-amd64-amd64-xl-qcow2 19 guest-localmigrate/x10 fail in 160655 REGR. vs. 159418 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-vhd 5 host-install(5) broken in 160655 pass in 160638 test-armhf-armhf-libvirt-raw 5 host-install(5) broken in 160655 pass in 160638 test-armhf-armhf-xl-credit1 5 host-install(5) broken in 160655 pass in 160638 test-armhf-armhf-xl 12 debian-install fail in 160655 pass in 160638 test-armhf-armhf-libvirt 18 guest-start/debian.repeat fail in 160655 pass in 160638 test-amd64-amd64-xl-qcow2 18 guest-saverestore.2 fail pass in 160655 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 160638 like 159418 test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 160638 never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 160638 never pass test-armhf-armhf-xl 15 migrate-support-check fail in 160638 never pass test-armhf-armhf-xl 16 saverestore-support-check fail in 160638 never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 160638 never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail in 160638 never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail in 160638 never pass test-armhf-armhf-libvirt 16 saverestore-support-check fail in 160655 like 159418 test-armhf-armhf-xl-arndale 15 migrate-support-check fail in 160655 never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail in 160655 never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 160655 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 160655 never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 160655 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 160655 never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail in 160655 never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail in 160655 never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 160655 never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 160655 never pass test-armhf-armhf-libvirt 15 migrate-support-check fail in 160655 never pass test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159418 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass version targeted for testing: xen 5b280a59c4dd8dad6cc8da28db981b193d10acee baseline version: xen 4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 Last test of basis 159418 2021-02-16 15:06:11 Z 45 days Failing since 160128 2021-03-18 14:36:18 Z 15 days 18 attempts Testing same since 160150 2021-03-20 04:11:48 Z 14 days 16 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Christian Lindig Edwin Török Igor Druzhinin Jan Beulich Julien Grall Olaf Hering Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf broken build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt blocked build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl blocked test-amd64-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale blocked test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw blocked test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds blocked test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-step build-armhf host-install(4) broken-job test-armhf-armhf-xl-credit1 broken broken-job test-armhf-armhf-libvirt-raw broken broken-job test-armhf-armhf-xl-vhd broken Not pushing. (No revision log; it would be 311 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Apr 03 06:34:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Apr 2021 06:34:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105034.201107 (Exim 4.92) (envelope-from ) id 1lSZre-0004vv-Cn; Sat, 03 Apr 2021 06:34:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105034.201107; Sat, 03 Apr 2021 06:34:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSZre-0004vo-9U; Sat, 03 Apr 2021 06:34:34 +0000 Received: by outflank-mailman (input) for mailman id 105034; Sat, 03 Apr 2021 06:34:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSZrd-0004vg-Pj; Sat, 03 Apr 2021 06:34:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSZrd-0005ea-Ho; Sat, 03 Apr 2021 06:34:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSZrd-0000G1-B2; Sat, 03 Apr 2021 06:34:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lSZrd-0003vI-AT; Sat, 03 Apr 2021 06:34:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=UvkN3pl99g1uachxWczFoE10spa+CYfiH7MpvOpIqG4=; b=DrFyXQJRsU3l/KQAcjzOsw4gl2 l4eSTC0PfCSDWU4IbZdVHhNHT4GOpIxArhojPoMnxjZj36F377I+wxql6N0RfFMZ4ELg+v9NtQPhK x27YZSTdRB9W2Wy0NxEipCcEysCmL+Vo+CIsyiUPFemMgmVdBfs0BLmDQXJk3o6XZL50=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Subject: [qemu-mainline bisection] complete test-amd64-i386-freebsd10-amd64 Message-Id: From: osstest service owner Date: Sat, 03 Apr 2021 06:34:33 +0000 branch xen-unstable xenbranch xen-unstable job test-amd64-i386-freebsd10-amd64 testid guest-saverestore Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://git.qemu.org/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: qemuu git://git.qemu.org/qemu.git Bug introduced: 8af54b9172ff3b9bbdbb3191ed84994d275a0d81 Bug not present: cbde7be900d2a2279cbc4becb91d1ddd6a014def Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/160694/ commit 8af54b9172ff3b9bbdbb3191ed84994d275a0d81 Author: Daniel P. Berrangé Date: Mon Feb 22 12:54:55 2021 +0000 machine: remove 'query-cpus' QMP command The newer 'query-cpus-fast' command avoids side effects on the guest execution. Note that some of the field names are different in the 'query-cpus-fast' command. Reviewed-by: Wainer dos Santos Moschetta Tested-by: Wainer dos Santos Moschetta Signed-off-by: Daniel P. Berrangé For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/qemu-mainline/test-amd64-i386-freebsd10-amd64.guest-saverestore.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/qemu-mainline/test-amd64-i386-freebsd10-amd64.guest-saverestore --summary-out=tmp/160694.bisection-summary --basis-template=152631 --blessings=real,real-bisect,real-retry qemu-mainline test-amd64-i386-freebsd10-amd64 guest-saverestore Searching for failure / basis pass: 160650 fail [host=fiano0] / 160125 [host=albana1] 160119 [host=huxelrebe1] 160113 [host=elbling0] 160104 [host=chardonnay0] 160097 [host=albana0] 160091 [host=chardonnay1] 160088 [host=albana1] 160082 [host=pinot0] 160079 [host=fiano1] 160070 [host=pinot1] 160066 ok. Failure / basis pass flights: 160650 / 160066 (tree with no url: minios) Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://git.qemu.org/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git Latest c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 62bad17dcae18f55cb3bdc19909543dfdf928a2b 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 00084bab87c43be20638de7f191d1a1faed134cc b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 90629587e16e2efdb61da77f25c25fba3c4a5fd7 Basis pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 3f8d1885e48e4d72eab0688f604de62e0aea7a38 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 9dc46386d89d83c73c41c2b19be83a73957c4393 Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/linux-pvops.git#c3038e718a19fc596f7b1baba0f83d5146dc7784-c3038e718a19fc596f7b1baba0f83d5146dc7784 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/osstest/ovmf.git#4751a48aeb2ab828b0a5cbdc585fd3642967cda1-62bad17dcae18f55cb3bdc19909543dfdf928a2b git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c74\ 37ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://git.qemu.org/qemu.git#3f8d1885e48e4d72eab0688f604de62e0aea7a38-00084bab87c43be20638de7f191d1a1faed134cc git://xenbits.xen.org/osstest/seabios.git#b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee-b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee git://xenbits.xen.org/xen.git#9dc46386d89d83c73c41c2b19be83a73957c4393-90629587e16e2efdb61da77f25c25fba3c4a5fd7 Loaded 44459 nodes in revision graph Searching for test results: 160048 [] 160050 [] 160057 [] 160062 [] 160064 [] 160066 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 3f8d1885e48e4d72eab0688f604de62e0aea7a38 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 9dc46386d89d83c73c41c2b19be83a73957c4393 160070 [host=pinot1] 160079 [host=fiano1] 160082 [host=pinot0] 160088 [host=albana1] 160091 [host=chardonnay1] 160097 [host=albana0] 160104 [host=chardonnay0] 160113 [host=elbling0] 160119 [host=huxelrebe1] 160125 [host=albana1] 160134 fail irrelevant 160147 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 2e1293cbaac75e84f541f9acfa8e26749f4c3562 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160167 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 ca318882714080fb81fe9eb89a7b7934efc5bfae 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 bdee969c0e65d4d509932b1d70e3a3b2ffbff6d5 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160328 fail irrelevant 160361 fail irrelevant 160392 fail irrelevant 160418 fail irrelevant 160448 fail irrelevant 160477 fail irrelevant 160501 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b33cf5bfcb4c941370739dfbbe1532ff508fd29d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7b9a3c9f94bcac23c534bc9f42a9e914b433b299 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee e680cc48b7184d3489873d6776f84ba1fc238ced 160522 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b33cf5bfcb4c941370739dfbbe1532ff508fd29d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7b9a3c9f94bcac23c534bc9f42a9e914b433b299 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee e680cc48b7184d3489873d6776f84ba1fc238ced 160541 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b33cf5bfcb4c941370739dfbbe1532ff508fd29d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 ec2e6e016d24bd429792d08cf607e4c5350dcdaa b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee e680cc48b7184d3489873d6776f84ba1fc238ced 160563 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b33cf5bfcb4c941370739dfbbe1532ff508fd29d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7993b0f83fe5c3f8555e79781d5d098f99751a94 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee cead8c0d17462f3a1150b5657d3f4eaa88faf1cb 160619 fail irrelevant 160632 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 62bad17dcae18f55cb3bdc19909543dfdf928a2b 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6ee55e1d10c25c2f6bf5ce2084ad2327e17affa5 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 90629587e16e2efdb61da77f25c25fba3c4a5fd7 160662 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 3f8d1885e48e4d72eab0688f604de62e0aea7a38 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 9dc46386d89d83c73c41c2b19be83a73957c4393 160663 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 62bad17dcae18f55cb3bdc19909543dfdf928a2b 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6ee55e1d10c25c2f6bf5ce2084ad2327e17affa5 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 90629587e16e2efdb61da77f25c25fba3c4a5fd7 160664 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 f2a9a6c2a86570ccbf8c5c30cbb8bf723168c459 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160666 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8a40754bca14df63c6d2ffe473b68a270dc50679 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160667 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7286d62d4e259be8cecf3dc2deea80ecc14489a5 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160650 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 62bad17dcae18f55cb3bdc19909543dfdf928a2b 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 00084bab87c43be20638de7f191d1a1faed134cc b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 90629587e16e2efdb61da77f25c25fba3c4a5fd7 160668 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 2255564fd21059960966b47212def9069cb56077 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160670 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 62bad17dcae18f55cb3bdc19909543dfdf928a2b 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 00084bab87c43be20638de7f191d1a1faed134cc b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 90629587e16e2efdb61da77f25c25fba3c4a5fd7 160671 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 5e8892db93f3fb6a7221f2d47f3c952a7e489737 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160673 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 9e7118023fda7c29016038e2292d4d14129b63da b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160674 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8b858f9998a9d59a9a7188f2c5c6ffb99eff6115 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160675 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 773b0bc2838ede154c6de9d78401b91fafa91062 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 affc55e761ea4c96b9b2de582d813787a317aeda b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160677 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 30ca7eddc486646fa19c9619fcf233ceaa65e28c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160678 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 e7c6a8cf9f5c82aa152273e1c9e80d07b1b0c32c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee b4011741e6b39a8fd0ed5aded96c16c45ead5888 160679 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 f2e8319d456724c3d8514d943dc4607e2f08e88a b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee b4011741e6b39a8fd0ed5aded96c16c45ead5888 160680 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 ee2e67da8f882fcdef2c49fcc58e9962aa695f5a b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160682 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 81cbfd5088690c53541ffd0d74851c8ab055a829 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160683 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 283d845c9164f57f5dba020a4783bb290493802f b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160684 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 445a5b4087567bf4d4ce76d394adf78d9d5c88a5 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160686 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 cbde7be900d2a2279cbc4becb91d1ddd6a014def b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160688 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8af54b9172ff3b9bbdbb3191ed84994d275a0d81 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160689 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 cbde7be900d2a2279cbc4becb91d1ddd6a014def b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160692 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8af54b9172ff3b9bbdbb3191ed84994d275a0d81 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160693 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 cbde7be900d2a2279cbc4becb91d1ddd6a014def b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160694 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8af54b9172ff3b9bbdbb3191ed84994d275a0d81 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 Searching for interesting versions Result found: flight 160066 (pass), for basis pass Result found: flight 160650 (fail), for basis failure Repro found: flight 160662 (pass), for basis pass Repro found: flight 160670 (fail), for basis failure 0 revisions at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 cbde7be900d2a2279cbc4becb91d1ddd6a014def b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 No revisions left to test, checking graph state. Result found: flight 160686 (pass), for last pass Result found: flight 160688 (fail), for first failure Repro found: flight 160689 (pass), for last pass Repro found: flight 160692 (fail), for first failure Repro found: flight 160693 (pass), for last pass Repro found: flight 160694 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: qemuu git://git.qemu.org/qemu.git Bug introduced: 8af54b9172ff3b9bbdbb3191ed84994d275a0d81 Bug not present: cbde7be900d2a2279cbc4becb91d1ddd6a014def Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/160694/ commit 8af54b9172ff3b9bbdbb3191ed84994d275a0d81 Author: Daniel P. Berrangé Date: Mon Feb 22 12:54:55 2021 +0000 machine: remove 'query-cpus' QMP command The newer 'query-cpus-fast' command avoids side effects on the guest execution. Note that some of the field names are different in the 'query-cpus-fast' command. Reviewed-by: Wainer dos Santos Moschetta Tested-by: Wainer dos Santos Moschetta Signed-off-by: Daniel P. Berrangé Revision graph left in /home/logs/results/bisect/qemu-mainline/test-amd64-i386-freebsd10-amd64.guest-saverestore.{dot,ps,png,html,svg}. ---------------------------------------- 160694: tolerable ALL FAIL flight 160694 qemu-mainline real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/160694/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: test-amd64-i386-freebsd10-amd64 16 guest-saverestore fail baseline untested jobs: test-amd64-i386-freebsd10-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Sat Apr 03 08:03:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Apr 2021 08:03:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105045.201125 (Exim 4.92) (envelope-from ) id 1lSbFW-0004im-Dw; Sat, 03 Apr 2021 08:03:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105045.201125; Sat, 03 Apr 2021 08:03:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSbFW-0004if-AQ; Sat, 03 Apr 2021 08:03:18 +0000 Received: by outflank-mailman (input) for mailman id 105045; Sat, 03 Apr 2021 08:03:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSbFV-0004iX-1x; Sat, 03 Apr 2021 08:03:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSbFU-0007bN-RT; Sat, 03 Apr 2021 08:03:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSbFU-0004T1-JO; Sat, 03 Apr 2021 08:03:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lSbFU-0000FJ-GG; Sat, 03 Apr 2021 08:03:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2704Jfrbg5X5ZtYdZpEICdfxA9IZS/faGhhEnkdaOoY=; b=mo53i6Z/jJNHJ5J+T092TQX7Wf VeVwgBIseFK5dDKbhN8M/orDDfhn9fsHCW263zi91OJcYc4RkX+PkSmHvU40TZVB9YShLobCbUFCT iRQzEoeNY/WOZW2piHJWOL3XYC7s32U0k5oaKJYBDZjXNSpRLp8gSCy0lkx+emtXB7SA=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160676: regressions - trouble: blocked/broken/fail/pass X-Osstest-Failures: linux-linus:build-armhf::broken:regression linux-linus:build-armhf:host-install(4):broken:regression linux-linus:test-armhf-armhf-xl-rtds::broken:regression linux-linus:test-armhf-armhf-xl-arndale::broken:regression linux-linus:test-armhf-armhf-xl-multivcpu::broken:regression linux-linus:test-armhf-armhf-libvirt::broken:regression linux-linus:test-armhf-armhf-xl-credit2::broken:regression linux-linus:test-armhf-armhf-xl::broken:regression linux-linus:test-armhf-armhf-xl-credit1::broken:regression linux-linus:test-armhf-armhf-xl-vhd::broken:regression linux-linus:test-armhf-armhf-libvirt-raw::broken:regression linux-linus:test-armhf-armhf-examine:host-install:broken:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-localmigrate/x10:fail:heisenbug linux-linus:test-amd64-amd64-qemuu-freebsd11-amd64:guest-start/freebsd.repeat:fail:heisenbug linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug linux-linus:test-armhf-armhf-examine:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking linux-linus:build-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt:host-install(5):broken:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:host-install(5):broken:nonblocking linux-linus:test-armhf-armhf-xl-rtds:host-install(5):broken:nonblocking linux-linus:test-armhf-armhf-xl-credit2:host-install(5):broken:nonblocking linux-linus:test-armhf-armhf-xl-vhd:host-install(5):broken:nonblocking linux-linus:test-armhf-armhf-xl:host-install(5):broken:nonblocking linux-linus:test-armhf-armhf-xl-arndale:host-install(5):broken:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:host-install(5):broken:nonblocking linux-linus:test-armhf-armhf-xl-credit1:host-install(5):broken:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=1678e493d530e7977cce34e59a86bb86f3c5631e X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Sat, 03 Apr 2021 08:03:16 +0000 flight 160676 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160676/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 4 host-install(4) broken REGR. vs. 152332 test-armhf-armhf-xl-rtds broken in 160658 test-armhf-armhf-xl-arndale broken in 160658 test-armhf-armhf-xl-multivcpu broken in 160658 test-armhf-armhf-libvirt broken in 160658 test-armhf-armhf-xl-credit2 broken in 160658 test-armhf-armhf-xl broken in 160658 test-armhf-armhf-xl-credit1 broken in 160658 test-armhf-armhf-xl-vhd broken in 160658 test-armhf-armhf-libvirt-raw broken in 160658 test-armhf-armhf-examine 5 host-install broken in 160658 REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail in 160658 REGR. vs. 152332 Tests which are failing intermittently (not blocking): test-amd64-amd64-i386-pvgrub 19 guest-localmigrate/x10 fail pass in 160658 test-amd64-amd64-qemuu-freebsd11-amd64 21 guest-start/freebsd.repeat fail pass in 160658 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail pass in 160658 Tests which did not succeed, but are not blocking: test-armhf-armhf-examine 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 5 host-install(5) broken in 160658 blocked in 152332 test-armhf-armhf-libvirt-raw 5 host-install(5) broken in 160658 blocked in 152332 test-armhf-armhf-xl-rtds 5 host-install(5) broken in 160658 blocked in 152332 test-armhf-armhf-xl-credit2 5 host-install(5) broken in 160658 blocked in 152332 test-armhf-armhf-xl-vhd 5 host-install(5) broken in 160658 blocked in 152332 test-armhf-armhf-xl 5 host-install(5) broken in 160658 blocked in 152332 test-armhf-armhf-xl-arndale 5 host-install(5) broken in 160658 blocked in 152332 test-armhf-armhf-xl-multivcpu 5 host-install(5) broken in 160658 blocked in 152332 test-armhf-armhf-xl-credit1 5 host-install(5) broken in 160658 blocked in 152332 test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail in 160658 never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail in 160658 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass version targeted for testing: linux 1678e493d530e7977cce34e59a86bb86f3c5631e baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 245 days Failing since 152366 2020-08-01 20:49:34 Z 244 days 416 attempts Testing same since 160658 2021-04-02 01:11:10 Z 1 days 2 attempts ------------------------------------------------------------ 5283 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf broken build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt blocked build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl blocked test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale blocked test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine blocked test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw blocked test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds blocked test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-step build-armhf host-install(4) broken-job test-armhf-armhf-xl-rtds broken broken-job test-armhf-armhf-xl-arndale broken broken-job test-armhf-armhf-xl-multivcpu broken broken-job test-armhf-armhf-libvirt broken broken-job test-armhf-armhf-xl-credit2 broken broken-job test-armhf-armhf-xl broken broken-job test-armhf-armhf-xl-credit1 broken broken-job test-armhf-armhf-xl-vhd broken broken-job test-armhf-armhf-libvirt-raw broken Not pushing. (No revision log; it would be 1312937 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Apr 03 11:49:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Apr 2021 11:49:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105054.201152 (Exim 4.92) (envelope-from ) id 1lSem1-0006Gf-Tp; Sat, 03 Apr 2021 11:49:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105054.201152; Sat, 03 Apr 2021 11:49:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSem1-0006GY-Qe; Sat, 03 Apr 2021 11:49:05 +0000 Received: by outflank-mailman (input) for mailman id 105054; Sat, 03 Apr 2021 11:49:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSem0-0006GQ-8I; Sat, 03 Apr 2021 11:49:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSelz-0002vL-Sd; Sat, 03 Apr 2021 11:49:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSelz-00084h-Ja; Sat, 03 Apr 2021 11:49:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lSelz-0004bU-J8; Sat, 03 Apr 2021 11:49:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=X5vTFt2/BMlrMOcZfgU7DLDFcK7kWHvOCyOJV/DPt8U=; b=uI2v0LDbt51KrsbMh0kNhf2QMk QeSLmY/cTRLwXPXuMENp9iDfgBUigTHZpom9VZSE4ACV/NplL120b2jmM0tm9XG8IiE5rVnhGnbP8 O+pxo1L0BWStlUh08LGmYtjEh/j4PlZaYZZVlFt9u36Xgpnk/NGI2ueqUj+SUiut8Pho=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 160690: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=2fc3a704e7083afab0537cf0777521afa9cc1db6 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sat, 03 Apr 2021 11:49:03 +0000 flight 160690 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/160690/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt 2fc3a704e7083afab0537cf0777521afa9cc1db6 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 267 days Failing since 151818 2020-07-11 04:18:52 Z 266 days 259 attempts Testing same since 160661 2021-04-02 04:19:00 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei simmon Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin WangJian Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yaroslav Kargin Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 49860 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Apr 03 13:19:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Apr 2021 13:19:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105069.201173 (Exim 4.92) (envelope-from ) id 1lSgBY-0005UQ-NY; Sat, 03 Apr 2021 13:19:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105069.201173; Sat, 03 Apr 2021 13:19:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSgBY-0005UJ-KO; Sat, 03 Apr 2021 13:19:32 +0000 Received: by outflank-mailman (input) for mailman id 105069; Sat, 03 Apr 2021 13:19:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSgBX-0005UB-ED; Sat, 03 Apr 2021 13:19:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSgBX-0004f9-7n; Sat, 03 Apr 2021 13:19:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSgBW-0003Fe-T0; Sat, 03 Apr 2021 13:19:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lSgBW-0007DZ-SU; Sat, 03 Apr 2021 13:19:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=15rcOwrBxuXqq9EClIDRm+XhHRTs8qa5il5WXudFkEs=; b=QfBpL4zCt4Xw/ZCS/SEAxHmSqj p6hlgeA/HiSO9baws2VuAldZlRoSfBSdxDDzM9TKrnRh9LKQjsxs7zh+0vOQ5BWfwMij4oTYH9c1V rBV/6cFaCbw7ziV6BRiYwOha1eJ0E0R0Eb/AhaaKFz+j6h9EHXKVEM+Kj6KKLcnII9qY=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 160681: regressions - trouble: broken/fail/pass X-Osstest-Failures: xen-unstable:test-armhf-armhf-xl-arndale::broken:regression xen-unstable:test-armhf-armhf-xl-credit1::broken:regression xen-unstable:test-armhf-armhf-xl-credit2::broken:regression xen-unstable:test-armhf-armhf-libvirt::broken:regression xen-unstable:test-armhf-armhf-libvirt:xen-boot:fail:regression xen-unstable:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression xen-unstable:test-armhf-armhf-xl-arndale:xen-boot:fail:regression xen-unstable:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression xen-unstable:test-armhf-armhf-xl-credit1:guest-start:fail:regression xen-unstable:test-armhf-armhf-libvirt:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-xl-arndale:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-xl-credit2:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-xl-credit1:host-install(5):broken:heisenbug xen-unstable:test-arm64-arm64-xl-seattle:xen-boot:fail:heisenbug xen-unstable:test-armhf-armhf-xl-vhd:xen-boot:fail:heisenbug xen-unstable:test-armhf-armhf-examine:reboot:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:xen-boot:fail:heisenbug xen-unstable:test-armhf-armhf-xl-multivcpu:debian-install:fail:heisenbug xen-unstable:test-armhf-armhf-xl:xen-boot:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt-raw:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=0435784cc75dcfef3b5f59c29deb1dbb84265ddb X-Osstest-Versions-That: xen=b0976d5c0441378b6348f5bfedbf431055bd0147 From: osstest service owner Date: Sat, 03 Apr 2021 13:19:30 +0000 flight 160681 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/160681/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-arndale broken test-armhf-armhf-xl-credit1 broken test-armhf-armhf-xl-credit2 broken test-armhf-armhf-libvirt broken in 160665 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 160646 test-armhf-armhf-xl-vhd 12 debian-di-install fail REGR. vs. 160646 test-armhf-armhf-xl-arndale 8 xen-boot fail in 160665 REGR. vs. 160646 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 160665 REGR. vs. 160646 test-armhf-armhf-xl-credit1 14 guest-start fail in 160665 REGR. vs. 160646 Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt 5 host-install(5) broken in 160665 pass in 160681 test-armhf-armhf-xl-arndale 5 host-install(5) broken pass in 160665 test-armhf-armhf-xl-credit2 5 host-install(5) broken pass in 160665 test-armhf-armhf-xl-credit1 5 host-install(5) broken pass in 160665 test-arm64-arm64-xl-seattle 8 xen-boot fail in 160665 pass in 160681 test-armhf-armhf-xl-vhd 8 xen-boot fail in 160665 pass in 160681 test-armhf-armhf-examine 8 reboot fail in 160665 pass in 160681 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 160665 pass in 160681 test-armhf-armhf-xl-rtds 8 xen-boot fail pass in 160665 test-armhf-armhf-xl-multivcpu 12 debian-install fail pass in 160665 test-armhf-armhf-xl 8 xen-boot fail pass in 160665 test-armhf-armhf-libvirt-raw 17 guest-start/debian.repeat fail pass in 160665 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 160665 REGR. vs. 160646 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 160665 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 160665 never pass test-armhf-armhf-xl 15 migrate-support-check fail in 160665 never pass test-armhf-armhf-xl 16 saverestore-support-check fail in 160665 never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 160665 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 160665 never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 160665 never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 160665 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160646 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160646 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160646 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160646 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160646 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160646 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160646 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160646 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160646 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160646 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: xen 0435784cc75dcfef3b5f59c29deb1dbb84265ddb baseline version: xen b0976d5c0441378b6348f5bfedbf431055bd0147 Last test of basis 160646 2021-04-01 15:07:43 Z 1 days Testing same since 160665 2021-04-02 07:40:09 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Bertrand Marquis Jan Beulich Julien Grall Michal Orzel Norbert Manthey Rahul Singh Roger Pau Monné Stefano Stabellini Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale broken test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 broken test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 broken test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw fail test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-xl-arndale broken broken-job test-armhf-armhf-xl-credit1 broken broken-job test-armhf-armhf-xl-credit2 broken broken-step test-armhf-armhf-xl-arndale host-install(5) broken-step test-armhf-armhf-xl-credit2 host-install(5) broken-step test-armhf-armhf-xl-credit1 host-install(5) broken-job test-armhf-armhf-libvirt broken Not pushing. (No revision log; it would be 412 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Apr 03 13:22:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Apr 2021 13:22:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105074.201188 (Exim 4.92) (envelope-from ) id 1lSgEm-0006KT-8R; Sat, 03 Apr 2021 13:22:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105074.201188; Sat, 03 Apr 2021 13:22:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSgEm-0006KM-4I; Sat, 03 Apr 2021 13:22:52 +0000 Received: by outflank-mailman (input) for mailman id 105074; Sat, 03 Apr 2021 13:22:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSgEl-0006KE-9R; Sat, 03 Apr 2021 13:22:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSgEl-0004j1-54; Sat, 03 Apr 2021 13:22:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSgEk-0003Ki-Os; Sat, 03 Apr 2021 13:22:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lSgEk-0001kM-OP; Sat, 03 Apr 2021 13:22:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=L23KO64JtxPOP3a+tBCezKJ7BJhQaWC0biCI+3Eo+gU=; b=4N1DYlJe/LumMoerVmD5rHJ3D1 2nK1iHdrGqhelx8AvRaGd13svH6Mg4yLAYsUFYxNneuOT6qdQWpEfSgSHKFSZ8CaeC8G8neKoTl0t tBHurOPw4EPsgj5bJ9YpiiwyHqasgbCkltF4qCm7OaxIoB9KobV+eAFxCEMKNafdANgs=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 160687: all pass - PUSHED X-Osstest-Versions-This: ovmf=f95cdd316c3d56e8f76b5044be54b9645e1dc60f X-Osstest-Versions-That: ovmf=8c8922988544d31e8c87dd595f209828edcee962 From: osstest service owner Date: Sat, 03 Apr 2021 13:22:50 +0000 flight 160687 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/160687/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf f95cdd316c3d56e8f76b5044be54b9645e1dc60f baseline version: ovmf 8c8922988544d31e8c87dd595f209828edcee962 Last test of basis 160656 2021-04-01 23:40:07 Z 1 days Testing same since 160687 2021-04-03 01:55:05 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michael D Kinney jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 8c89229885..f95cdd316c f95cdd316c3d56e8f76b5044be54b9645e1dc60f -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Apr 03 13:37:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Apr 2021 13:37:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105081.201208 (Exim 4.92) (envelope-from ) id 1lSgSV-0007Ku-IB; Sat, 03 Apr 2021 13:37:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105081.201208; Sat, 03 Apr 2021 13:37:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSgSV-0007Kn-F6; Sat, 03 Apr 2021 13:37:03 +0000 Received: by outflank-mailman (input) for mailman id 105081; Sat, 03 Apr 2021 13:37:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSgST-0007Ki-Mm for xen-devel@lists.xenproject.org; Sat, 03 Apr 2021 13:37:01 +0000 Received: from sonic309-13.consmr.mail.bf2.yahoo.com (unknown [74.6.129.123]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 45434e47-8e29-4436-ae62-84019e2fa3ee; Sat, 03 Apr 2021 13:37:00 +0000 (UTC) Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.bf2.yahoo.com with HTTP; Sat, 3 Apr 2021 13:37:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 45434e47-8e29-4436-ae62-84019e2fa3ee DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1617457020; bh=frNwGYHqCnadvbec+VrFdhIQ0kNGbh7FuDVaI9wxMLg=; h=Date:From:To:Subject:References:From:Subject:Reply-To; b=I2JxQ7lq2ocdLqgw9b/8iR/HU7KoGc5t6uEXT5vXVji2fX44nzl4eAHyvO05LcydQiWYaWM3z6acWTU3htkPzP2/YO+X37cQZFyGRvtJBPTQ9LS+Y/VPDOZC65clDb1eV68Wyho/YZ4Qm5HXIcvey6nir9ToSWCiGFCTMpKMycwn0hbq/qgnVeKuYGWmZau78BawFMQYl+m+RmH1cG1ciq2YFRdNBQ5iYmp7oj0swsXIaZf9tJeoRMbJ3dVmZblH7CQZL2SDHqilKX40Hy0pvEF0ZIWNxNa+hoEpDtduNE8zkV3XzAQfmG/oMZ4lznV4DK+wzlkHcmwFLm8BTGhFFA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1617457020; bh=bslqVk2NQewVuNnogv67oKmfj6UO44c/KMqMs0U3zgx=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=TjwqL39BvawqmoE9nsBa6erTqSkLBv+AeDm8zILVKzQZ4pIFYawCzDEwZIoARsYSmIhBu70321rd1bsrM0bhVXwAzb0ncEdxpv3Gkd8gUMQQxeU8CZ5j2YHsCwwCxdXayXAZTCuplSgUApxYI3OUy7zHgikAow3h+9Fk6ZnYfRZ/jxuV8+UwzjU9f0vS65Tcq0PprbYi5eDtoCrLbaFdlEDUfzRzoEFoIFvOipZ6+wZ70oEK2b3E904q6vhGUsfSS7rdN3e7uVvYTSW1FFhnyZTtCu+DJ1Pus7WLjLehjwZwwULWo7Mm5fKKW2X9Nx5FrQ/8oatcP+dr0FgLmh5kQQ== X-YMail-OSG: JdcGbCQVM1nFhTFHDSoKvNF3R5muJ7c6dgN.bI7Si5qCasxJhk5NS1b0vm_GJQq 5SiFC7Ky.oIuXm7qpcAnflkKVBaYHaKICHwwAiNWh01kpEKf_yZeFXafmdT6Wz4Bl3m44M8PzYMq IyArndK1YSv_Sv_ZnH_.qfPCgdSVk0LQpLFggBDmF6zJz0GWNNlEk5o0lVCRu81G.idVn4BYayd8 Uhwl4PTDEcXeQj.fETcdH0jP9nRBHs_61CvbKWRBF.aqvTBCg9q27hbu7Xi9FlqMlC9WSzuVpNUu Rf6hig9.A3E.V3fHMSG7xcY07WdcO7pc8Hld8Ys7E.KYDg_YBOVQesUz_rl1J3Dl_s8RqKn57J6U GCze1y1ooEkG48TwaYzQF.M..UsEv6r5NmZz1y51Llbz7OEcyVdd7dfC6QuOwxLnvs10eihkXNBm KONOk4bxE8nVYpraa_FrkoK_l7cpIXi0nZZ9V1qTFf.f0WqI6vaoSiGfzlTi7bcTldTBi3_CHg4Q EJrk6wz10geloYl_f2XXZzLarQXIamRhFNLoB2cXP1bqp35FUHPwLbi3sTZ5am2IuSG59a2Q6GHB fg492iUf6OxRU8FDqkNZUBVZJXElq9arDq2DYHKJMyO1507U.5tPgc6F0eGMxm3z5dfL1qByvBca 8eTjoopxCfi0lagWTd_T.044ZJurwSKzbFYSQEzGNL6quS.ciIsbMCI7oVL2EJbk797W.pMiZRSR jg5H.VNh2vyLdbHzyhT6IZW.7Chx67F00RCKWwqIocdJRuqwAwnZ9baZcvb0n2b09ZXiLMNuSaEO CGcMB7EYAqgOEoAvSzwbyLZ6iOtfvhen_wJ3xB2iqOgLp7YQRe.1j4_uRioHXC_YZnlBGKcMViKE EYEN71qTPK1OPQOCmdBWxVC8cbF5sB4zm1xEg_.SnCCFo8B_0Zi5hiGixL0r.G8QnacJR3E5CppO IGqSyKalEMimqWQXvOdEpyUe9eo1RoW.7NNXYIxsG1m2sjxMawF9A_uC7HyCVZyUyAbUJyifs.VA UDWym9Aj7ayJ9XPDnjmdBKB8lRcycCdyzaDZ8nmifwz77Dz97L_xswLNWmCRSU0FmcUZnL4TZo.Z 9FY67sWhKoVC9jawX_ULPfulBpSq9N2Spu5kWUWl5_p9HNZq1q6ikBCapZV.Gm89_7F_UJkrlVGu FPO7aDA1pUYk_oR1Kt.z6clmYeveWdpOtA2C51R9UZB3KG6h4qeMOr.Z.xFXsMGpQOXeSeQgJdO4 BacA7kG7IlzWwnl7y3rf6OSOPlIjiV70kxw13PmvIcGYVorwFcpawUOMSDO7kv53DvEYHsVfrPNQ 7fcAouWXmF10k5toxTK_ojLpvxT6sxKczZCHN.QePAYQjQZCs1jcOO9nLQaWW80ek0WCAL70LGl3 G9H1pQvsx_Miqkt6Zg_imGPpGHUHcHsPOsu9oY44W6ImOuNVjcku3h4Xy5t4ctbg1FNu1KWWVY4t nRK2Fw1WXU.sff_694.cWbwrNBRCpbbCNxeIdFBFZzcSMDkvnTSADhbE46BZwYF7mhsWTEy3v3y7 CC1Cv6vA3cEpZS3MhSapnA8hF5924CpsjvWWg6gjyehw3rjJbpeLQuK3yRplDo51ie5tRmc1__V2 54ELkx3GwG5oKzgrQJnNaupioU98raH7RzCoYZWzoSD6raw5SJyslEpOPsxc2w4QCghWlBNgYO_2 X_96wNci4KYE13yRtBpKEJTQ6Hv0k3WBAdWgsMuNN07A6fJX.yKkNhEAfD1X5j8oFB_Gk.V7ykbj _mpoQtc9ln_T3U8NELxfl9Hc1y5EQTDOBjBItucD_DF7QEWetE6Bjx8agKrPdt_WPX23gGpRrb.Q n6V8d0KeQKIzDpisfmCu0jMWBi5k5_6IOgZJFOcWs3TUQpk65MTWkEZ04p3OSNE58kn78hgIqn8_ 3O8RzQt2w20JFp3hTO.SzgAnmAAwh60wvFTaYkoLBc3Uvt9MPpbf6DnG8PEOhFMFqGEVgrvLWbRQ 6S9ea0R6pObzJGK5gQmvdvFFwg0dEjtdqRtLzbqJ59pW.iRDiu4mim8_5g4p4FrTwBFYmZGnQgw4 WCzL9JIXgiifIMnfLqHCVJGddJOw5QX8hVc4g7n7aWRHfloLTVJ613MXmWWMb64ODQJ5nz2NB8Nc bN2qZe.CMKmTTNvXslZocLi85uX2aZFZDIe1c20ukYH__gYXhws7EB2O0FDpqmui5lnhk1bW1uc9 0QzTsMc4WfvmfnUUwaqB1PXWCRHL.dYpudAS3ivKKW3KZXynhpKuO_1U1TFbCDVd0QYR.HBilg2x KAL.cPRl6RV8FbajEygjDL7nSQRQB1Q4ivRzAOsWnemvbUZVDHu0qnLEPloyKABmmSoIENyvwZjJ dpyU2Ga6p.2LR3BMU01PQA7PkP28t1l8Vr5g- X-Sonic-MF: Date: Sat, 3 Apr 2021 13:36:59 +0000 (UTC) From: Jason Long To: Xen-devel Message-ID: <2007893190.1974412.1617457019974@mail.yahoo.com> Subject: Xen for AlmaLinux and Rocky Linux. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable References: <2007893190.1974412.1617457019974.ref@mail.yahoo.com> X-Mailer: WebService/1.1.17936 YMailNorrin Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.114 Safari/537.36 Content-Length: 146 Hello, As CentOS there will be no soon, the Xen Project team has any plan to build= Xen Hypervisor for=C2=A0AlmaLinux and Rocky Linux? Thanks. From xen-devel-bounces@lists.xenproject.org Sat Apr 03 17:10:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Apr 2021 17:10:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105094.201245 (Exim 4.92) (envelope-from ) id 1lSjme-0000Z5-9K; Sat, 03 Apr 2021 17:10:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105094.201245; Sat, 03 Apr 2021 17:10:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSjme-0000Yb-5X; Sat, 03 Apr 2021 17:10:04 +0000 Received: by outflank-mailman (input) for mailman id 105094; Sat, 03 Apr 2021 17:10:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSjmd-0000Rf-I1; Sat, 03 Apr 2021 17:10:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSjmd-0000gK-C9; Sat, 03 Apr 2021 17:10:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSjmd-0000MX-3r; Sat, 03 Apr 2021 17:10:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lSjmd-0003Jb-2w; Sat, 03 Apr 2021 17:10:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=9bN49VPkAx6dpDIsEa9sbI0oXTkw4lwv6mRkmyGGONg=; b=qoslU31+SZDPvtnHPeSHUj+ygC 2y0tjpm2mwsXyHo8oW/6RlQZl/FAgpYZVOaKoxhh8JUxgCFEGwWOU0w3NE3Fy9cCAB51blLxquHAv XY7gCK4dzh2cnKeRyp9DNGOjcwV4OjXPpIHSNilWjQmYazWVXVkR/nr2G3/MP5V2eSBg=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160685: regressions - trouble: broken/fail/pass X-Osstest-Failures: qemu-mainline:test-armhf-armhf-libvirt::broken:regression qemu-mainline:test-armhf-armhf-libvirt-raw::broken:regression qemu-mainline:test-armhf-armhf-xl-credit1::broken:regression qemu-mainline:test-armhf-armhf-xl-multivcpu::broken:regression qemu-mainline:test-armhf-armhf-xl-rtds::broken:regression qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-amd64-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-freebsd10-i386:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-freebsd10-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-i386-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-arm64-arm64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install/l1/l2:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-armhf-armhf-xl-credit2:debian-install:fail:regression qemu-mainline:test-armhf-armhf-libvirt:host-install(5):broken:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:host-install(5):broken:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:host-install(5):broken:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:host-install(5):broken:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:host-install(5):broken:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=50a9b4499ca99a439b400f715f9475b1702f4e87 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Sat, 03 Apr 2021 17:10:03 +0000 flight 160685 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/160685/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt broken test-armhf-armhf-libvirt-raw broken test-armhf-armhf-xl-credit1 broken test-armhf-armhf-xl-multivcpu broken test-armhf-armhf-xl-rtds broken test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-qemuu-freebsd12-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-freebsd10-i386 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-freebsd10-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-i386-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-arm64-arm64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-qemuu-nested-intel 20 debian-hvm-install/l1/l2 fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-armhf-armhf-xl-credit2 12 debian-install fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 5 host-install(5) broken blocked in 152631 test-armhf-armhf-xl-credit1 5 host-install(5) broken blocked in 152631 test-armhf-armhf-libvirt-raw 5 host-install(5) broken blocked in 152631 test-armhf-armhf-xl-rtds 5 host-install(5) broken blocked in 152631 test-armhf-armhf-xl-multivcpu 5 host-install(5) broken blocked in 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: qemuu 50a9b4499ca99a439b400f715f9475b1702f4e87 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 226 days Failing since 152659 2020-08-21 14:07:39 Z 225 days 424 attempts Testing same since 160685 2021-04-03 01:07:58 Z 0 days 1 attempts ------------------------------------------------------------ 473 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 broken test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt broken test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu broken test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair fail test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw broken test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds broken test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-libvirt broken broken-job test-armhf-armhf-libvirt-raw broken broken-job test-armhf-armhf-xl-credit1 broken broken-job test-armhf-armhf-xl-multivcpu broken broken-job test-armhf-armhf-xl-rtds broken broken-step test-armhf-armhf-libvirt host-install(5) broken-step test-armhf-armhf-xl-credit1 host-install(5) broken-step test-armhf-armhf-libvirt-raw host-install(5) broken-step test-armhf-armhf-xl-rtds host-install(5) broken-step test-armhf-armhf-xl-multivcpu host-install(5) Not pushing. (No revision log; it would be 139953 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Apr 03 21:26:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Apr 2021 21:26:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105107.201284 (Exim 4.92) (envelope-from ) id 1lSnmp-0004xv-CM; Sat, 03 Apr 2021 21:26:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105107.201284; Sat, 03 Apr 2021 21:26:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSnmp-0004xn-6q; Sat, 03 Apr 2021 21:26:31 +0000 Received: by outflank-mailman (input) for mailman id 105107; Sat, 03 Apr 2021 21:26:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSnmn-0004xZ-WB; Sat, 03 Apr 2021 21:26:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSnmn-0004uh-Fe; Sat, 03 Apr 2021 21:26:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSnmn-00033T-2Q; Sat, 03 Apr 2021 21:26:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lSnmn-0008Ok-1m; Sat, 03 Apr 2021 21:26:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=WJo+I7qrRAJ3BvbeJMrDGaS4Cf0+LFqlBaVkzXxSdUA=; b=AdmLNykJKR7O51Dr1mxU1YfU9L NOi8Woo94ZEJkO0siYYLDzJHFeo2slcgxG3WdwShMOr21BCDl9OmtgBDbG41HSe3t6aukZ/8uy74P RoGIKjfPjwMRsUN545Ou1XBjziHs/gMrW36Z0OUjj7ZdoAvBNktrz0r+JPSQ1m3cQG5E=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.12-testing test] 160691: regressions - trouble: broken/fail/pass X-Osstest-Failures: xen-4.12-testing:test-armhf-armhf-libvirt::broken:regression xen-4.12-testing:test-armhf-armhf-xl::broken:regression xen-4.12-testing:test-armhf-armhf-xl-credit1::broken:regression xen-4.12-testing:test-armhf-armhf-xl-credit2::broken:regression xen-4.12-testing:test-armhf-armhf-xl-cubietruck::broken:regression xen-4.12-testing:test-armhf-armhf-xl-rtds::broken:regression xen-4.12-testing:test-armhf-armhf-libvirt-raw::broken:regression xen-4.12-testing:test-armhf-armhf-xl-vhd::broken:regression xen-4.12-testing:build-armhf::broken:regression xen-4.12-testing:build-armhf:host-install(4):broken:regression xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-localmigrate/x10:fail:regression xen-4.12-testing:test-armhf-armhf-xl-vhd:host-install(5):broken:heisenbug xen-4.12-testing:test-armhf-armhf-libvirt-raw:host-install(5):broken:heisenbug xen-4.12-testing:test-armhf-armhf-xl-credit1:host-install(5):broken:heisenbug xen-4.12-testing:test-armhf-armhf-xl-credit2:host-install(5):broken:heisenbug xen-4.12-testing:test-armhf-armhf-xl-rtds:host-install(5):broken:heisenbug xen-4.12-testing:test-armhf-armhf-libvirt:host-install(5):broken:heisenbug xen-4.12-testing:test-armhf-armhf-xl:host-install(5):broken:heisenbug xen-4.12-testing:test-armhf-armhf-xl-cubietruck:host-install(5):broken:heisenbug xen-4.12-testing:test-armhf-armhf-xl:debian-install:fail:heisenbug xen-4.12-testing:test-armhf-armhf-libvirt:guest-start/debian.repeat:fail:heisenbug xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-saverestore.2:fail:heisenbug xen-4.12-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:heisenbug xen-4.12-testing:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:heisenbug xen-4.12-testing:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking xen-4.12-testing:build-armhf-libvirt:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=5b280a59c4dd8dad6cc8da28db981b193d10acee X-Osstest-Versions-That: xen=4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 From: osstest service owner Date: Sat, 03 Apr 2021 21:26:29 +0000 flight 160691 xen-4.12-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/160691/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt broken test-armhf-armhf-xl broken test-armhf-armhf-xl-credit1 broken test-armhf-armhf-xl-credit2 broken test-armhf-armhf-xl-cubietruck broken test-armhf-armhf-xl-rtds broken test-armhf-armhf-libvirt-raw broken in 160655 test-armhf-armhf-xl-vhd broken in 160655 build-armhf broken in 160672 build-armhf 4 host-install(4) broken in 160672 REGR. vs. 159418 test-amd64-amd64-xl-qcow2 19 guest-localmigrate/x10 fail REGR. vs. 159418 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-vhd 5 host-install(5) broken in 160655 pass in 160691 test-armhf-armhf-libvirt-raw 5 host-install(5) broken in 160655 pass in 160691 test-armhf-armhf-xl-credit1 5 host-install(5) broken pass in 160638 test-armhf-armhf-xl-credit2 5 host-install(5) broken pass in 160655 test-armhf-armhf-xl-rtds 5 host-install(5) broken pass in 160655 test-armhf-armhf-libvirt 5 host-install(5) broken pass in 160655 test-armhf-armhf-xl 5 host-install(5) broken pass in 160655 test-armhf-armhf-xl-cubietruck 5 host-install(5) broken pass in 160655 test-armhf-armhf-xl 12 debian-install fail in 160655 pass in 160638 test-armhf-armhf-libvirt 18 guest-start/debian.repeat fail in 160655 pass in 160638 test-amd64-amd64-xl-qcow2 18 guest-saverestore.2 fail in 160672 pass in 160691 test-armhf-armhf-libvirt-raw 12 debian-di-install fail pass in 160638 test-amd64-i386-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail pass in 160672 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 1 build-check(1) blocked in 160672 n/a build-armhf-libvirt 1 build-check(1) blocked in 160672 n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked in 160672 n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked in 160672 n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked in 160672 n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked in 160672 n/a test-armhf-armhf-libvirt 1 build-check(1) blocked in 160672 n/a test-armhf-armhf-xl 1 build-check(1) blocked in 160672 n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked in 160672 n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked in 160672 n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked in 160672 n/a test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 160638 like 159418 test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 160638 never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 160638 never pass test-armhf-armhf-xl 15 migrate-support-check fail in 160638 never pass test-armhf-armhf-xl 16 saverestore-support-check fail in 160638 never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 160638 never pass test-armhf-armhf-libvirt 16 saverestore-support-check fail in 160655 like 159418 test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 160655 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 160655 never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 160655 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 160655 never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail in 160655 never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail in 160655 never pass test-armhf-armhf-libvirt 15 migrate-support-check fail in 160655 never pass test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159418 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 5b280a59c4dd8dad6cc8da28db981b193d10acee baseline version: xen 4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 Last test of basis 159418 2021-02-16 15:06:11 Z 46 days Failing since 160128 2021-03-18 14:36:18 Z 16 days 19 attempts Testing same since 160150 2021-03-20 04:11:48 Z 14 days 17 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Christian Lindig Edwin Török Igor Druzhinin Jan Beulich Julien Grall Olaf Hering Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl broken test-amd64-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 broken test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 broken test-armhf-armhf-xl-cubietruck broken test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt broken test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw fail test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds broken test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-libvirt broken broken-job test-armhf-armhf-xl broken broken-job test-armhf-armhf-xl-credit1 broken broken-job test-armhf-armhf-xl-credit2 broken broken-job test-armhf-armhf-xl-cubietruck broken broken-job test-armhf-armhf-xl-rtds broken broken-step test-armhf-armhf-xl-credit2 host-install(5) broken-step test-armhf-armhf-xl-rtds host-install(5) broken-step test-armhf-armhf-libvirt host-install(5) broken-step test-armhf-armhf-xl host-install(5) broken-step test-armhf-armhf-xl-cubietruck host-install(5) broken-step test-armhf-armhf-xl-credit1 host-install(5) broken-job build-armhf broken broken-job test-armhf-armhf-libvirt-raw broken broken-job test-armhf-armhf-xl-credit1 broken broken-job test-armhf-armhf-xl-vhd broken Not pushing. (No revision log; it would be 311 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Apr 03 23:45:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Apr 2021 23:45:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105116.201305 (Exim 4.92) (envelope-from ) id 1lSpwn-0008Lj-P8; Sat, 03 Apr 2021 23:44:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105116.201305; Sat, 03 Apr 2021 23:44:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSpwn-0008Lc-Ku; Sat, 03 Apr 2021 23:44:57 +0000 Received: by outflank-mailman (input) for mailman id 105116; Sat, 03 Apr 2021 23:44:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSpwm-0008LM-N0; Sat, 03 Apr 2021 23:44:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSpwm-00074i-E2; Sat, 03 Apr 2021 23:44:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSpwm-0000le-4S; Sat, 03 Apr 2021 23:44:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lSpwm-0005rs-3x; Sat, 03 Apr 2021 23:44:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=OqFNG9TuK7v/H0ZbZZ6QzgNMdrQ4F4VixC4lCT9A9mY=; b=bqzd5cfs26cn6UPd6oI41mA6Ax 2LkIQ9ssAobKF1+CeqaqOenZfQnOFDRQF4VvF3ptADEe582h53CHbqT1ZYb86DjTvPCKPkps6Id3F awKt92GtJ57RniQASNHf6UNcO+MFh/bhY8lDGqhAcfOAbSFU7UswPp6Z8jqquankryxk=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160696: regressions - trouble: blocked/broken/fail/pass X-Osstest-Failures: linux-linus:build-armhf::broken:regression linux-linus:build-armhf:host-install(4):broken:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-qemuu-freebsd12-amd64:guest-start.2:fail:regression linux-linus:test-armhf-armhf-examine:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking linux-linus:build-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=d93a0d43e3d0ba9e19387be4dae4a8d5b175a8d7 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Sat, 03 Apr 2021 23:44:56 +0000 flight 160696 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160696/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 4 host-install(4) broken REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-qemuu-freebsd12-amd64 22 guest-start.2 fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-armhf-armhf-examine 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass version targeted for testing: linux d93a0d43e3d0ba9e19387be4dae4a8d5b175a8d7 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 246 days Failing since 152366 2020-08-01 20:49:34 Z 245 days 417 attempts Testing same since 160696 2021-04-03 08:07:18 Z 0 days 1 attempts ------------------------------------------------------------ 5283 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf broken build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt blocked build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl blocked test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale blocked test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine blocked test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw blocked test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds blocked test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-step build-armhf host-install(4) Not pushing. (No revision log; it would be 1313675 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Apr 04 03:46:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Apr 2021 03:46:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105126.201335 (Exim 4.92) (envelope-from ) id 1lStiO-0001JM-GI; Sun, 04 Apr 2021 03:46:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105126.201335; Sun, 04 Apr 2021 03:46:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lStiO-0001JC-6y; Sun, 04 Apr 2021 03:46:20 +0000 Received: by outflank-mailman (input) for mailman id 105126; Sun, 04 Apr 2021 03:46:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lStiM-0001J4-C8; Sun, 04 Apr 2021 03:46:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lStiM-0000PO-03; Sun, 04 Apr 2021 03:46:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lStiL-00030F-Gm; Sun, 04 Apr 2021 03:46:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lStiL-0000cF-GH; Sun, 04 Apr 2021 03:46:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=aro+o9k/5Y3yHapwrthie5OaHjm+uudSVAcCx+KCJ7A=; b=yJKn1eOSLbHxc2NN8uYln+hPAj Iqbipbe+biDFslDLnlHg1NftuBf6zzm2LV+rms7XpDzDfLBDGBjZQo8qjxHQCU8AEx6TyBYAGJf21 0z/5K3XLWK2vSaAiERyTi62NGEm1MF3ZDTFFaDKYrPCHBWa0YNZ89PC5mBSO3JqsPCF8=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 160700: regressions - trouble: broken/fail/pass X-Osstest-Failures: xen-unstable:test-armhf-armhf-libvirt-raw::broken:regression xen-unstable:test-armhf-armhf-xl::broken:regression xen-unstable:test-armhf-armhf-xl-arndale::broken:regression xen-unstable:test-armhf-armhf-xl-credit1::broken:regression xen-unstable:test-armhf-armhf-xl-credit2::broken:regression xen-unstable:test-armhf-armhf-xl-cubietruck::broken:regression xen-unstable:test-armhf-armhf-xl-multivcpu::broken:regression xen-unstable:test-armhf-armhf-xl-rtds::broken:regression xen-unstable:test-armhf-armhf-xl-vhd::broken:regression xen-unstable:test-armhf-armhf-libvirt::broken:regression xen-unstable:test-armhf-armhf-xl-arndale:xen-boot:fail:regression xen-unstable:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression xen-unstable:test-armhf-armhf-xl-credit1:guest-start:fail:regression xen-unstable:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression xen-unstable:test-armhf-armhf-libvirt:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-xl-arndale:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-xl-credit1:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-xl-credit2:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-xl:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-xl-multivcpu:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-xl-vhd:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-libvirt-raw:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-xl-cubietruck:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-examine:host-install:broken:heisenbug xen-unstable:test-armhf-armhf-xl-vhd:xen-boot:fail:heisenbug xen-unstable:test-armhf-armhf-examine:reboot:fail:heisenbug xen-unstable:test-arm64-arm64-xl-seattle:xen-boot:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:xen-boot:fail:heisenbug xen-unstable:test-armhf-armhf-xl-multivcpu:debian-install:fail:heisenbug xen-unstable:test-armhf-armhf-xl:xen-boot:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt-raw:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt:xen-boot:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=0435784cc75dcfef3b5f59c29deb1dbb84265ddb X-Osstest-Versions-That: xen=b0976d5c0441378b6348f5bfedbf431055bd0147 From: osstest service owner Date: Sun, 04 Apr 2021 03:46:17 +0000 flight 160700 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/160700/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt-raw broken test-armhf-armhf-xl broken test-armhf-armhf-xl-arndale broken test-armhf-armhf-xl-credit1 broken test-armhf-armhf-xl-credit2 broken test-armhf-armhf-xl-cubietruck broken test-armhf-armhf-xl-multivcpu broken test-armhf-armhf-xl-rtds broken test-armhf-armhf-xl-vhd broken test-armhf-armhf-libvirt broken in 160665 test-armhf-armhf-xl-arndale 8 xen-boot fail in 160665 REGR. vs. 160646 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 160665 REGR. vs. 160646 test-armhf-armhf-xl-credit1 14 guest-start fail in 160665 REGR. vs. 160646 test-armhf-armhf-xl-vhd 12 debian-di-install fail in 160681 REGR. vs. 160646 Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt 5 host-install(5) broken in 160665 pass in 160700 test-armhf-armhf-xl-arndale 5 host-install(5) broken pass in 160665 test-armhf-armhf-xl-credit1 5 host-install(5) broken pass in 160665 test-armhf-armhf-xl-credit2 5 host-install(5) broken pass in 160665 test-armhf-armhf-xl 5 host-install(5) broken pass in 160681 test-armhf-armhf-xl-multivcpu 5 host-install(5) broken pass in 160681 test-armhf-armhf-xl-rtds 5 host-install(5) broken pass in 160681 test-armhf-armhf-xl-vhd 5 host-install(5) broken pass in 160681 test-armhf-armhf-libvirt-raw 5 host-install(5) broken pass in 160681 test-armhf-armhf-xl-cubietruck 5 host-install(5) broken pass in 160681 test-armhf-armhf-examine 5 host-install broken pass in 160681 test-armhf-armhf-xl-vhd 8 xen-boot fail in 160665 pass in 160681 test-armhf-armhf-examine 8 reboot fail in 160665 pass in 160681 test-arm64-arm64-xl-seattle 8 xen-boot fail in 160665 pass in 160700 test-armhf-armhf-xl-rtds 8 xen-boot fail in 160681 pass in 160665 test-armhf-armhf-xl-multivcpu 12 debian-install fail in 160681 pass in 160665 test-armhf-armhf-xl 8 xen-boot fail in 160681 pass in 160665 test-armhf-armhf-libvirt-raw 17 guest-start/debian.repeat fail in 160681 pass in 160665 test-armhf-armhf-libvirt 8 xen-boot fail in 160681 pass in 160700 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 160681 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 160665 REGR. vs. 160646 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 160665 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 160665 never pass test-armhf-armhf-xl 15 migrate-support-check fail in 160665 never pass test-armhf-armhf-xl 16 saverestore-support-check fail in 160665 never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 160665 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 160665 never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 160665 never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 160665 never pass test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 160681 like 160646 test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 160681 never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail in 160681 never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail in 160681 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160646 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160646 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160646 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160646 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160646 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160646 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160646 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160646 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160646 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160646 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass version targeted for testing: xen 0435784cc75dcfef3b5f59c29deb1dbb84265ddb baseline version: xen b0976d5c0441378b6348f5bfedbf431055bd0147 Last test of basis 160646 2021-04-01 15:07:43 Z 2 days Testing same since 160665 2021-04-02 07:40:09 Z 1 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Bertrand Marquis Jan Beulich Julien Grall Michal Orzel Norbert Manthey Rahul Singh Roger Pau Monné Stefano Stabellini Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl broken test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale broken test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 broken test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 broken test-armhf-armhf-xl-cubietruck broken test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu broken test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw broken test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds broken test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd broken ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-libvirt-raw broken broken-job test-armhf-armhf-xl broken broken-job test-armhf-armhf-xl-arndale broken broken-job test-armhf-armhf-xl-credit1 broken broken-job test-armhf-armhf-xl-credit2 broken broken-job test-armhf-armhf-xl-cubietruck broken broken-job test-armhf-armhf-xl-multivcpu broken broken-job test-armhf-armhf-xl-rtds broken broken-job test-armhf-armhf-xl-vhd broken broken-step test-armhf-armhf-xl host-install(5) broken-step test-armhf-armhf-xl-arndale host-install(5) broken-step test-armhf-armhf-xl-multivcpu host-install(5) broken-step test-armhf-armhf-xl-rtds host-install(5) broken-step test-armhf-armhf-xl-vhd host-install(5) broken-step test-armhf-armhf-xl-credit1 host-install(5) broken-step test-armhf-armhf-libvirt-raw host-install(5) broken-step test-armhf-armhf-xl-cubietruck host-install(5) broken-step test-armhf-armhf-examine host-install broken-step test-armhf-armhf-xl-credit2 host-install(5) broken-job test-armhf-armhf-xl-credit2 broken broken-job test-armhf-armhf-xl-arndale broken broken-job test-armhf-armhf-xl-credit1 broken broken-job test-armhf-armhf-libvirt broken Not pushing. (No revision log; it would be 412 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Apr 04 07:04:03 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Apr 2021 07:04:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105138.201365 (Exim 4.92) (envelope-from ) id 1lSwnO-0001kE-DT; Sun, 04 Apr 2021 07:03:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105138.201365; Sun, 04 Apr 2021 07:03:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSwnO-0001k7-AG; Sun, 04 Apr 2021 07:03:42 +0000 Received: by outflank-mailman (input) for mailman id 105138; Sun, 04 Apr 2021 07:03:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSwnM-0001jz-R0; Sun, 04 Apr 2021 07:03:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSwnM-0004Ae-Jk; Sun, 04 Apr 2021 07:03:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSwnM-0005mL-CO; Sun, 04 Apr 2021 07:03:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lSwnM-0000NA-Bq; Sun, 04 Apr 2021 07:03:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dKWSiOQMfQMVJ/zEc74orytaN9e5XaTfahZkGSASn8g=; b=4TVsyH1vSQZXrGEh62k5sVkFfW zaqY3qnZZv8r2nB+JRnqACOYuUGx1xcwsSZtbw7f52eH1Jtzk3DTKiLQXC6wI9BtaaRuQecJHRTqa GeS/c7ke/ELW1izXN0ks2rFofIWOm1Ur6a9rxEk6mNjBeoRbJl0NAxpH6pHkeLyMUi1E=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160704: regressions - trouble: blocked/broken/fail/pass X-Osstest-Failures: qemu-mainline:build-armhf::broken:regression qemu-mainline:build-armhf:host-install(4):broken:regression qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-amd64-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-freebsd10-i386:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-freebsd10-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-i386-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-arm64-arm64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install/l1/l2:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=50a9b4499ca99a439b400f715f9475b1702f4e87 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Sun, 04 Apr 2021 07:03:40 +0000 flight 160704 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/160704/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 4 host-install(4) broken REGR. vs. 152631 test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-qemuu-freebsd12-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-freebsd10-i386 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-freebsd10-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-i386-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-arm64-arm64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-qemuu-nested-intel 20 debian-hvm-install/l1/l2 fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass version targeted for testing: qemuu 50a9b4499ca99a439b400f715f9475b1702f4e87 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 226 days Failing since 152659 2020-08-21 14:07:39 Z 225 days 425 attempts Testing same since 160685 2021-04-03 01:07:58 Z 1 days 2 attempts ------------------------------------------------------------ 473 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf broken build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt blocked build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl blocked test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale blocked test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair fail test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw blocked test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds blocked test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-step build-armhf host-install(4) Not pushing. (No revision log; it would be 139953 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Apr 04 09:47:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Apr 2021 09:47:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105148.201386 (Exim 4.92) (envelope-from ) id 1lSzLw-0007UX-Hp; Sun, 04 Apr 2021 09:47:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105148.201386; Sun, 04 Apr 2021 09:47:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSzLw-0007UQ-EI; Sun, 04 Apr 2021 09:47:32 +0000 Received: by outflank-mailman (input) for mailman id 105148; Sun, 04 Apr 2021 09:47:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSzLv-0007UI-7k; Sun, 04 Apr 2021 09:47:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSzLu-0007Ed-VD; Sun, 04 Apr 2021 09:47:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lSzLu-0006VO-LY; Sun, 04 Apr 2021 09:47:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lSzLu-0003QY-L3; Sun, 04 Apr 2021 09:47:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GUHguF6xzWVNRVhlyZffUcog/ErQ8tJ2oMuP0u9Ev8o=; b=k26gNmjBLX7KKLP6PIvb7kKdwx xqdGQPx6CxhLDgFk9sE7A2kcaOIjIhzUzdyMwlZnv3Y2Vj0BuUv5h0w39NlAATXmm7lqLYJlAntOW eAAdkaoykwxfjhuf42/oo0WqbrkrMpUT8lc/PzNi0oZXSfc4vHNpWsCYYnHWdLqKGd4k=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-coverity test] 160721: all pass - PUSHED X-Osstest-Versions-This: xen=0435784cc75dcfef3b5f59c29deb1dbb84265ddb X-Osstest-Versions-That: xen=90629587e16e2efdb61da77f25c25fba3c4a5fd7 From: osstest service owner Date: Sun, 04 Apr 2021 09:47:30 +0000 flight 160721 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/160721/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 0435784cc75dcfef3b5f59c29deb1dbb84265ddb baseline version: xen 90629587e16e2efdb61da77f25c25fba3c4a5fd7 Last test of basis 160582 2021-03-31 09:18:34 Z 4 days Testing same since 160721 2021-04-04 09:18:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Bertrand Marquis George Dunlap Jan Beulich Julien Grall Michal Orzel Norbert Manthey Rahul Singh Roger Pau Monné Stefano Stabellini Stefano Stabellini jobs: coverity-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 90629587e1..0435784cc7 0435784cc75dcfef3b5f59c29deb1dbb84265ddb -> coverity-tested/smoke From xen-devel-bounces@lists.xenproject.org Sun Apr 04 11:17:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Apr 2021 11:17:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105156.201412 (Exim 4.92) (envelope-from ) id 1lT0kf-0006is-EN; Sun, 04 Apr 2021 11:17:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105156.201412; Sun, 04 Apr 2021 11:17:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lT0kf-0006il-BO; Sun, 04 Apr 2021 11:17:09 +0000 Received: by outflank-mailman (input) for mailman id 105156; Sun, 04 Apr 2021 11:17:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lT0ke-0006id-Er; Sun, 04 Apr 2021 11:17:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lT0ke-0000JA-47; Sun, 04 Apr 2021 11:17:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lT0kd-0001so-SH; Sun, 04 Apr 2021 11:17:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lT0kd-000280-Rn; Sun, 04 Apr 2021 11:17:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=xHnuxZRwsdR+uikOVCSV3smscIvn5zcX5N9F9XfUfVk=; b=JI70xkZmy9+LFlleYInPVyfxcf BqbeUZegCCXLONIjlffd2u1K+9CngA7o+I6yIzDDd0E8GJ4vm+Euk0MDsn2MeURRFMi80b7y01tsR FNUh7MJU8fKfisrt/8o9PZhnwZzzi0xHFHMeDZhDG2d2CCnoy4wwBNUfyGv4dtHhdHUM=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.12-testing test] 160709: regressions - trouble: blocked/broken/fail/pass X-Osstest-Failures: xen-4.12-testing:build-armhf::broken:regression xen-4.12-testing:build-armhf:host-install(4):broken:regression xen-4.12-testing:test-armhf-armhf-libvirt-raw::broken:regression xen-4.12-testing:test-armhf-armhf-xl-vhd::broken:regression xen-4.12-testing:test-armhf-armhf-xl-rtds::broken:regression xen-4.12-testing:test-armhf-armhf-xl-credit1::broken:regression xen-4.12-testing:test-armhf-armhf-xl-credit2::broken:regression xen-4.12-testing:test-armhf-armhf-xl::broken:regression xen-4.12-testing:test-armhf-armhf-libvirt::broken:regression xen-4.12-testing:test-armhf-armhf-xl-cubietruck::broken:regression xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-localmigrate/x10:fail:regression xen-4.12-testing:test-armhf-armhf-xl-vhd:host-install(5):broken:heisenbug xen-4.12-testing:test-armhf-armhf-libvirt-raw:host-install(5):broken:heisenbug xen-4.12-testing:test-armhf-armhf-xl-credit1:host-install(5):broken:heisenbug xen-4.12-testing:test-armhf-armhf-xl-credit2:host-install(5):broken:heisenbug xen-4.12-testing:test-armhf-armhf-xl-rtds:host-install(5):broken:heisenbug xen-4.12-testing:test-armhf-armhf-libvirt:host-install(5):broken:heisenbug xen-4.12-testing:test-armhf-armhf-xl:host-install(5):broken:heisenbug xen-4.12-testing:test-armhf-armhf-xl-cubietruck:host-install(5):broken:heisenbug xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-saverestore.2:fail:heisenbug xen-4.12-testing:test-armhf-armhf-xl:debian-install:fail:heisenbug xen-4.12-testing:test-armhf-armhf-libvirt:guest-start/debian.repeat:fail:heisenbug xen-4.12-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:heisenbug xen-4.12-testing:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:heisenbug xen-4.12-testing:test-amd64-amd64-libvirt-pair:guests-nbd-mirror/debian:fail:heisenbug xen-4.12-testing:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking xen-4.12-testing:build-armhf-libvirt:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=5b280a59c4dd8dad6cc8da28db981b193d10acee X-Osstest-Versions-That: xen=4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 From: osstest service owner Date: Sun, 04 Apr 2021 11:17:07 +0000 flight 160709 xen-4.12-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/160709/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 4 host-install(4) broken REGR. vs. 159418 test-armhf-armhf-libvirt-raw broken in 160655 test-armhf-armhf-xl-vhd broken in 160655 test-armhf-armhf-xl-rtds broken in 160691 test-armhf-armhf-xl-credit1 broken in 160691 test-armhf-armhf-xl-credit2 broken in 160691 test-armhf-armhf-xl broken in 160691 test-armhf-armhf-libvirt broken in 160691 test-armhf-armhf-xl-cubietruck broken in 160691 test-amd64-amd64-xl-qcow2 19 guest-localmigrate/x10 fail REGR. vs. 159418 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-vhd 5 host-install(5) broken in 160655 pass in 160691 test-armhf-armhf-libvirt-raw 5 host-install(5) broken in 160655 pass in 160691 test-armhf-armhf-xl-credit1 5 host-install(5) broken in 160691 pass in 160638 test-armhf-armhf-xl-credit2 5 host-install(5) broken in 160691 pass in 160655 test-armhf-armhf-xl-rtds 5 host-install(5) broken in 160691 pass in 160655 test-armhf-armhf-libvirt 5 host-install(5) broken in 160691 pass in 160655 test-armhf-armhf-xl 5 host-install(5) broken in 160691 pass in 160655 test-armhf-armhf-xl-cubietruck 5 host-install(5) broken in 160691 pass in 160655 test-amd64-amd64-xl-qcow2 18 guest-saverestore.2 fail in 160638 pass in 160709 test-armhf-armhf-xl 12 debian-install fail in 160655 pass in 160638 test-armhf-armhf-libvirt 18 guest-start/debian.repeat fail in 160655 pass in 160638 test-armhf-armhf-libvirt-raw 12 debian-di-install fail in 160691 pass in 160638 test-amd64-i386-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail in 160691 pass in 160709 test-amd64-amd64-libvirt-pair 22 guests-nbd-mirror/debian fail pass in 160691 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 160638 like 159418 test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 160638 never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 160638 never pass test-armhf-armhf-xl 15 migrate-support-check fail in 160638 never pass test-armhf-armhf-xl 16 saverestore-support-check fail in 160638 never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 160638 never pass test-armhf-armhf-libvirt 16 saverestore-support-check fail in 160655 like 159418 test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 160655 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 160655 never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 160655 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 160655 never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail in 160655 never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail in 160655 never pass test-armhf-armhf-libvirt 15 migrate-support-check fail in 160655 never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 160691 never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 160691 never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail in 160691 never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail in 160691 never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail in 160691 never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail in 160691 never pass test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159418 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass version targeted for testing: xen 5b280a59c4dd8dad6cc8da28db981b193d10acee baseline version: xen 4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 Last test of basis 159418 2021-02-16 15:06:11 Z 46 days Failing since 160128 2021-03-18 14:36:18 Z 16 days 20 attempts Testing same since 160150 2021-03-20 04:11:48 Z 15 days 18 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Christian Lindig Edwin Török Igor Druzhinin Jan Beulich Julien Grall Olaf Hering Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf broken build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt blocked build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl blocked test-amd64-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale blocked test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair fail test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw blocked test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds blocked test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-step build-armhf host-install(4) broken-job test-armhf-armhf-xl-rtds broken broken-job test-armhf-armhf-xl-credit1 broken broken-job test-armhf-armhf-xl-credit2 broken broken-job test-armhf-armhf-xl broken broken-job test-armhf-armhf-libvirt broken broken-job test-armhf-armhf-xl-cubietruck broken broken-job test-armhf-armhf-xl-credit1 broken broken-job test-armhf-armhf-libvirt-raw broken broken-job test-armhf-armhf-xl-vhd broken Not pushing. (No revision log; it would be 311 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Apr 04 12:19:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Apr 2021 12:19:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105166.201433 (Exim 4.92) (envelope-from ) id 1lT1j7-0003Sp-EQ; Sun, 04 Apr 2021 12:19:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105166.201433; Sun, 04 Apr 2021 12:19:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lT1j7-0003Si-BP; Sun, 04 Apr 2021 12:19:37 +0000 Received: by outflank-mailman (input) for mailman id 105166; Sun, 04 Apr 2021 12:19:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lT1j6-0003Sa-BK; Sun, 04 Apr 2021 12:19:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lT1j6-0001J7-3p; Sun, 04 Apr 2021 12:19:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lT1j5-0004d0-RN; Sun, 04 Apr 2021 12:19:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lT1j5-0005Ab-Qv; Sun, 04 Apr 2021 12:19:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1nce9yFvFPqbJGarR37f6qI/vt1ee541Sk3kU957mDk=; b=IZWpzV1W7tlTg/IUsG3s7mnvKW RIrZDafe9l6EXY1mG6JJUCO4Agu5JTQZ4kefXA/ueBF0ImU/r6jICcK3DlCOZI56+JpF3gh4xdaW1 gRZZ5OE0xLTA37azxUWjo/HPssW5CkAJmu2mmvXFghN2Smyd7UmbAvMcZsQzlQcKOj1M=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 160716: regressions - trouble: blocked/broken/fail/pass X-Osstest-Failures: libvirt:build-armhf::broken:regression libvirt:build-armhf:host-install(4):broken:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=2fc3a704e7083afab0537cf0777521afa9cc1db6 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sun, 04 Apr 2021 12:19:35 +0000 flight 160716 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/160716/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 4 host-install(4) broken REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: build-armhf-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt 2fc3a704e7083afab0537cf0777521afa9cc1db6 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 268 days Failing since 151818 2020-07-11 04:18:52 Z 267 days 260 attempts Testing same since 160661 2021-04-02 04:19:00 Z 2 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei simmon Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin WangJian Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yaroslav Kargin Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf broken build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt blocked build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-step build-armhf host-install(4) Not pushing. (No revision log; it would be 49860 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Apr 04 15:20:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Apr 2021 15:20:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105173.201455 (Exim 4.92) (envelope-from ) id 1lT4XV-0001ul-69; Sun, 04 Apr 2021 15:19:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105173.201455; Sun, 04 Apr 2021 15:19:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lT4XV-0001ue-2L; Sun, 04 Apr 2021 15:19:49 +0000 Received: by outflank-mailman (input) for mailman id 105173; Sun, 04 Apr 2021 15:19:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lT4XT-0001uW-PR; Sun, 04 Apr 2021 15:19:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lT4XT-0004CA-EH; Sun, 04 Apr 2021 15:19:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lT4XS-0005JR-Sw; Sun, 04 Apr 2021 15:19:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lT4XS-0003Di-SQ; Sun, 04 Apr 2021 15:19:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=9Kz8wvx7ZbHXkYTiamXm0aaiuYB5HbF7/08uVB9XisQ=; b=CiiLqOwd8Ze4T4W1Au4eU2swPh sVyXlTvedoQgw9FqJ8FQ4d9WWTnqstBL7/eRQKqsdClOmSfY1hzkVvn2H//dsrb8kXvw501Ise5GM WbXNcqkvzi3AT2l6AQES4w9qII8Fm+AkP21WQ8SV2bT6nFfbAl6KDHd9z09SdDxnKrzw=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160711: regressions - trouble: broken/fail/pass X-Osstest-Failures: linux-linus:test-armhf-armhf-libvirt::broken:regression linux-linus:test-armhf-armhf-xl-credit2::broken:regression linux-linus:test-armhf-armhf-xl-cubietruck::broken:regression linux-linus:test-armhf-armhf-xl-multivcpu::broken:regression linux-linus:test-armhf-armhf-xl-rtds::broken:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-armhf-armhf-xl-credit1:debian-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt:host-install(5):broken:nonblocking linux-linus:test-armhf-armhf-xl-rtds:host-install(5):broken:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:host-install(5):broken:nonblocking linux-linus:test-armhf-armhf-xl-credit2:host-install(5):broken:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:host-install(5):broken:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=2023a53bdf41b7646b1d384b6816af06309f73a5 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Sun, 04 Apr 2021 15:19:46 +0000 flight 160711 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160711/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt broken test-armhf-armhf-xl-credit2 broken test-armhf-armhf-xl-cubietruck broken test-armhf-armhf-xl-multivcpu broken test-armhf-armhf-xl-rtds broken test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 test-armhf-armhf-xl-credit1 12 debian-install fail REGR. vs. 152332 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 152332 test-armhf-armhf-xl-vhd 12 debian-di-install fail REGR. vs. 152332 test-armhf-armhf-libvirt-raw 12 debian-di-install fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 5 host-install(5) broken blocked in 152332 test-armhf-armhf-xl-rtds 5 host-install(5) broken blocked in 152332 test-armhf-armhf-xl-multivcpu 5 host-install(5) broken blocked in 152332 test-armhf-armhf-xl-credit2 5 host-install(5) broken blocked in 152332 test-armhf-armhf-xl-cubietruck 5 host-install(5) broken blocked in 152332 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux 2023a53bdf41b7646b1d384b6816af06309f73a5 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 246 days Failing since 152366 2020-08-01 20:49:34 Z 245 days 418 attempts Testing same since 160711 2021-04-04 00:11:23 Z 0 days 1 attempts ------------------------------------------------------------ 5291 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 broken test-armhf-armhf-xl-cubietruck broken test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt broken test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu broken test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw fail test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds broken test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-libvirt broken broken-job test-armhf-armhf-xl-credit2 broken broken-job test-armhf-armhf-xl-cubietruck broken broken-job test-armhf-armhf-xl-multivcpu broken broken-job test-armhf-armhf-xl-rtds broken broken-step test-armhf-armhf-libvirt host-install(5) broken-step test-armhf-armhf-xl-rtds host-install(5) broken-step test-armhf-armhf-xl-multivcpu host-install(5) broken-step test-armhf-armhf-xl-credit2 host-install(5) broken-step test-armhf-armhf-xl-cubietruck host-install(5) Not pushing. (No revision log; it would be 1315124 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Apr 04 21:07:03 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Apr 2021 21:07:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105215.201518 (Exim 4.92) (envelope-from ) id 1lT9x5-00070X-5C; Sun, 04 Apr 2021 21:06:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105215.201518; Sun, 04 Apr 2021 21:06:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lT9x5-00070Q-1Q; Sun, 04 Apr 2021 21:06:35 +0000 Received: by outflank-mailman (input) for mailman id 105215; Sun, 04 Apr 2021 21:06:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lT9x3-00070I-U7; Sun, 04 Apr 2021 21:06:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lT9x3-00024a-Ki; Sun, 04 Apr 2021 21:06:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lT9x3-0005Wl-Ar; Sun, 04 Apr 2021 21:06:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lT9x3-0008CD-AI; Sun, 04 Apr 2021 21:06:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5hBpJuucFSIA09DtXI6aKIqXTS+LZjzSU6pIoI+ZVxQ=; b=r3H+Gyj1yru6TUqVJfQtAs8qTb A5JG8f7KQiwbrqZn5cZJHdM+d9xT+lcltX9yP9WgQ9/LeR0bUTRVI/X7XVkrXs0nKePnHsIG2eWe2 lz6cC2JYjfyGu9lhvlQ0HZPlKpJwVYteaqdOO4K6LXhCt+n7DvukHnxk1794oGniBDJo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 160715: regressions - trouble: broken/fail/pass X-Osstest-Failures: xen-unstable:test-armhf-armhf-xl-arndale::broken:regression xen-unstable:test-armhf-armhf-xl-cubietruck::broken:regression xen-unstable:test-armhf-armhf-libvirt::broken:regression xen-unstable:test-armhf-armhf-xl-credit1::broken:regression xen-unstable:test-armhf-armhf-libvirt-raw::broken:regression xen-unstable:test-armhf-armhf-xl::broken:regression xen-unstable:test-armhf-armhf-xl-credit2::broken:regression xen-unstable:test-armhf-armhf-xl-rtds::broken:regression xen-unstable:test-armhf-armhf-xl-multivcpu::broken:regression xen-unstable:test-armhf-armhf-xl-vhd::broken:regression xen-unstable:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression xen-unstable:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression xen-unstable:test-armhf-armhf-xl-arndale:xen-boot:fail:regression xen-unstable:test-armhf-armhf-libvirt:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-xl:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-xl-multivcpu:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-xl-vhd:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-xl-credit1:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-libvirt-raw:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-examine:host-install:broken:heisenbug xen-unstable:test-armhf-armhf-xl-credit2:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-xl-arndale:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-xl-cubietruck:host-install(5):broken:heisenbug xen-unstable:test-arm64-arm64-xl-seattle:xen-boot:fail:heisenbug xen-unstable:test-armhf-armhf-xl-vhd:xen-boot:fail:heisenbug xen-unstable:test-armhf-armhf-examine:reboot:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-armhf-armhf-xl-credit1:guest-start:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt:xen-boot:fail:heisenbug xen-unstable:test-armhf-armhf-xl-multivcpu:debian-install:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt-raw:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-armhf-armhf-xl-credit2:guest-start:fail:heisenbug xen-unstable:test-armhf-armhf-xl:xen-boot:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:xen-boot:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt:guest-start:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=0435784cc75dcfef3b5f59c29deb1dbb84265ddb X-Osstest-Versions-That: xen=b0976d5c0441378b6348f5bfedbf431055bd0147 From: osstest service owner Date: Sun, 04 Apr 2021 21:06:33 +0000 flight 160715 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/160715/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-arndale broken test-armhf-armhf-xl-cubietruck broken test-armhf-armhf-libvirt broken in 160665 test-armhf-armhf-xl-credit1 broken in 160700 test-armhf-armhf-libvirt-raw broken in 160700 test-armhf-armhf-xl broken in 160700 test-armhf-armhf-xl-credit2 broken in 160700 test-armhf-armhf-xl-rtds broken in 160700 test-armhf-armhf-xl-multivcpu broken in 160700 test-armhf-armhf-xl-vhd broken in 160700 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REGR. vs. 160646 test-armhf-armhf-xl-vhd 12 debian-di-install fail REGR. vs. 160646 test-armhf-armhf-xl-arndale 8 xen-boot fail in 160665 REGR. vs. 160646 Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt 5 host-install(5) broken in 160665 pass in 160715 test-armhf-armhf-xl 5 host-install(5) broken in 160700 pass in 160715 test-armhf-armhf-xl-rtds 5 host-install(5) broken in 160700 pass in 160715 test-armhf-armhf-xl-multivcpu 5 host-install(5) broken in 160700 pass in 160715 test-armhf-armhf-xl-vhd 5 host-install(5) broken in 160700 pass in 160715 test-armhf-armhf-xl-credit1 5 host-install(5) broken in 160700 pass in 160715 test-armhf-armhf-libvirt-raw 5 host-install(5) broken in 160700 pass in 160715 test-armhf-armhf-examine 5 host-install broken in 160700 pass in 160715 test-armhf-armhf-xl-credit2 5 host-install(5) broken in 160700 pass in 160715 test-armhf-armhf-xl-arndale 5 host-install(5) broken pass in 160665 test-armhf-armhf-xl-cubietruck 5 host-install(5) broken pass in 160681 test-arm64-arm64-xl-seattle 8 xen-boot fail in 160665 pass in 160715 test-armhf-armhf-xl-vhd 8 xen-boot fail in 160665 pass in 160715 test-armhf-armhf-examine 8 reboot fail in 160665 pass in 160715 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 160665 pass in 160715 test-armhf-armhf-xl-credit1 14 guest-start fail in 160665 pass in 160715 test-armhf-armhf-libvirt 8 xen-boot fail in 160681 pass in 160715 test-armhf-armhf-xl-multivcpu 12 debian-install fail in 160681 pass in 160715 test-armhf-armhf-libvirt-raw 17 guest-start/debian.repeat fail in 160681 pass in 160715 test-armhf-armhf-xl-credit2 14 guest-start fail pass in 160665 test-armhf-armhf-xl 8 xen-boot fail pass in 160665 test-armhf-armhf-xl-rtds 8 xen-boot fail pass in 160665 test-armhf-armhf-libvirt 14 guest-start fail pass in 160700 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 160665 REGR. vs. 160646 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 160665 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 160665 never pass test-armhf-armhf-xl 15 migrate-support-check fail in 160665 never pass test-armhf-armhf-xl 16 saverestore-support-check fail in 160665 never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 160665 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 160665 never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail in 160665 never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail in 160665 never pass test-armhf-armhf-libvirt 16 saverestore-support-check fail in 160700 like 160646 test-armhf-armhf-libvirt 15 migrate-support-check fail in 160700 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160646 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160646 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160646 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160646 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160646 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160646 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160646 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160646 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160646 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160646 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 0435784cc75dcfef3b5f59c29deb1dbb84265ddb baseline version: xen b0976d5c0441378b6348f5bfedbf431055bd0147 Last test of basis 160646 2021-04-01 15:07:43 Z 3 days Testing same since 160665 2021-04-02 07:40:09 Z 2 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Bertrand Marquis Jan Beulich Julien Grall Michal Orzel Norbert Manthey Rahul Singh Roger Pau Monné Stefano Stabellini Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale broken test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck broken test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-xl-arndale broken broken-job test-armhf-armhf-xl-cubietruck broken broken-step test-armhf-armhf-xl-arndale host-install(5) broken-step test-armhf-armhf-xl-cubietruck host-install(5) broken-job test-armhf-armhf-libvirt broken broken-job test-armhf-armhf-xl-credit1 broken broken-job test-armhf-armhf-libvirt-raw broken broken-job test-armhf-armhf-xl-arndale broken broken-job test-armhf-armhf-xl broken broken-job test-armhf-armhf-xl-credit2 broken broken-job test-armhf-armhf-xl-cubietruck broken broken-job test-armhf-armhf-xl-rtds broken broken-job test-armhf-armhf-xl-multivcpu broken broken-job test-armhf-armhf-xl-vhd broken broken-job test-armhf-armhf-xl-arndale broken broken-job test-armhf-armhf-xl-credit1 broken broken-job test-armhf-armhf-xl-credit2 broken Not pushing. (No revision log; it would be 412 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Apr 04 23:56:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Apr 2021 23:56:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105224.201545 (Exim 4.92) (envelope-from ) id 1lTCaq-0004Rp-Id; Sun, 04 Apr 2021 23:55:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105224.201545; Sun, 04 Apr 2021 23:55:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTCaq-0004Ri-Fe; Sun, 04 Apr 2021 23:55:48 +0000 Received: by outflank-mailman (input) for mailman id 105224; Sun, 04 Apr 2021 23:55:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTCap-0004Ra-Ca; Sun, 04 Apr 2021 23:55:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTCap-0004ja-0U; Sun, 04 Apr 2021 23:55:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTCao-0008U7-Mv; Sun, 04 Apr 2021 23:55:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lTCao-0002Lg-MR; Sun, 04 Apr 2021 23:55:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=VrL8lM+tVh+yHDAX+w46+3m4CEhWfW+jlRIreSgr+do=; b=wWYUgE8jMqF1+YiVPkhuuM/bc+ Wj6Twp6cXKgH58Aiei/APly0gsLwc/oaIr0cQW/d89CWE4oDi17/RHIQVfK+nIjwSfljMN+bQx0ZK XN0ugRqEXlN15QMcF5AreUL1y+2fvMNF+0sdnxPeBf6J1a86f6A3ol275HBJzh65NtRY=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160719: regressions - trouble: broken/fail/pass X-Osstest-Failures: qemu-mainline:test-armhf-armhf-xl-rtds::broken:regression qemu-mainline:build-armhf::broken:regression qemu-mainline:build-armhf:host-install(4):broken:regression qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-amd64-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-freebsd10-i386:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-freebsd10-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-i386-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-arm64-arm64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install/l1/l2:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-armhf-armhf-libvirt:guest-start:fail:regression qemu-mainline:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression qemu-mainline:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:host-install(5):broken:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=50a9b4499ca99a439b400f715f9475b1702f4e87 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Sun, 04 Apr 2021 23:55:46 +0000 flight 160719 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/160719/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-rtds broken build-armhf broken in 160704 build-armhf 4 host-install(4) broken in 160704 REGR. vs. 152631 test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-qemuu-freebsd12-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-freebsd10-i386 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-freebsd10-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-i386-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-arm64-arm64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-qemuu-nested-intel 20 debian-hvm-install/l1/l2 fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 152631 test-armhf-armhf-libvirt-raw 12 debian-di-install fail REGR. vs. 152631 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail pass in 160704 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 1 build-check(1) blocked in 160704 n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked in 160704 n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked in 160704 n/a test-armhf-armhf-xl 1 build-check(1) blocked in 160704 n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked in 160704 n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked in 160704 n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked in 160704 n/a build-armhf-libvirt 1 build-check(1) blocked in 160704 n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked in 160704 n/a test-armhf-armhf-libvirt 1 build-check(1) blocked in 160704 n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked in 160704 n/a test-armhf-armhf-xl-rtds 5 host-install(5) broken blocked in 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: qemuu 50a9b4499ca99a439b400f715f9475b1702f4e87 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 227 days Failing since 152659 2020-08-21 14:07:39 Z 226 days 426 attempts Testing same since 160685 2021-04-03 01:07:58 Z 1 days 3 attempts ------------------------------------------------------------ 473 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair fail test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw fail test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds broken test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-xl-rtds broken broken-step test-armhf-armhf-xl-rtds host-install(5) broken-job build-armhf broken Not pushing. (No revision log; it would be 139953 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Apr 05 01:01:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Apr 2021 01:01:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105231.201559 (Exim 4.92) (envelope-from ) id 1lTDce-00083t-NZ; Mon, 05 Apr 2021 01:01:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105231.201559; Mon, 05 Apr 2021 01:01:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTDce-000830-KH; Mon, 05 Apr 2021 01:01:44 +0000 Received: by outflank-mailman (input) for mailman id 105231; Mon, 05 Apr 2021 01:01:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTDcc-0007GT-IR; Mon, 05 Apr 2021 01:01:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTDcc-00043F-7g; Mon, 05 Apr 2021 01:01:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTDcb-0002R8-V2; Mon, 05 Apr 2021 01:01:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lTDcb-0000CI-UZ; Mon, 05 Apr 2021 01:01:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=wG6NxV5BnQrGLjEo7xQQKZ3H3Rzbswl5ZpgWf8FwGHk=; b=RLFRzzbt9o4U40oTNs6IEjzU/A HUXmO+KQiL0rNZPqAfBFQjM+HYFkP+MQC2wWO0P2+JvXxWMy6dSGv3FsZ7bev337MTpc6cKPLWVjC PYgSGyAM0ToDk4wX2NZPXXhhHPFet+RFAXmD6I1UhCnZ5VcLcqb/HBbXb/PuNVzuu6pQ=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Subject: [qemu-mainline bisection] complete test-amd64-amd64-libvirt-pair Message-Id: From: osstest service owner Date: Mon, 05 Apr 2021 01:01:41 +0000 branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-libvirt-pair testid guest-start/debian Tree: libvirt git://xenbits.xen.org/libvirt.git Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://git.qemu.org/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: qemuu git://git.qemu.org/qemu.git Bug introduced: 8d17adf34f501ded65a106572740760f0a75577c Bug not present: e67d8e2928200e24ecb47c7be3ea8270077f2996 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/160735/ commit 8d17adf34f501ded65a106572740760f0a75577c Author: Daniel P. Berrangé Date: Mon Feb 22 11:16:32 2021 +0000 block: remove support for using "file" driver with block/char devices The 'host_device' and 'host_cdrom' drivers must be used instead. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/qemu-mainline/test-amd64-amd64-libvirt-pair.guest-start--debian.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/qemu-mainline/test-amd64-amd64-libvirt-pair.guest-start--debian --summary-out=tmp/160735.bisection-summary --basis-template=152631 --blessings=real,real-bisect,real-retry qemu-mainline test-amd64-amd64-libvirt-pair guest-start/debian Searching for failure / basis pass: 160650 fail [dst_host=fiano0,src_host=fiano1] / 160125 [dst_host=albana0,src_host=albana1] 160119 [dst_host=elbling1,src_host=elbling0] 160113 [dst_host=godello1,src_host=godello0] 160104 [dst_host=godello0,src_host=godello1] 160097 [dst_host=chardonnay1,src_host=chardonnay0] 160091 [dst_host=chardonnay0,src_host=chardonnay1] 160088 [dst_host=albana1,src_host=albana0] 160082 [dst_host=pinot0,src_host=pinot1] 160079 [dst_host=elbling0,src_host=elbling1] 160070 [dst_host=godello1,src_host=godello\ 0] 160066 [dst_host=fiano1,src_host=fiano0] 160002 ok. Failure / basis pass flights: 160650 / 160002 (tree with no url: minios) Tree: libvirt git://xenbits.xen.org/libvirt.git Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://git.qemu.org/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git Latest 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 62bad17dcae18f55cb3bdc19909543dfdf928a2b 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 00084bab87c43be20638de7f191d1a1faed134cc b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 90629587e16e2efdb61da77f25c25fba3c4a5fd7 Basis pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6f34661b6c97a37a5efc27d31c037ddeda4547e2 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee e4bdcc8aef6707027168ea29caed844a7da67b4d Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/libvirt.git#2c846fa6bcc11929c9fb857a22430fb9945654ad-2c846fa6bcc11929c9fb857a22430fb9945654ad https://gitlab.com/keycodemap/keycodemapdb.git#27acf0ef828bf719b2053ba398b195829413dbdd-27acf0ef828bf719b2053ba398b195829413dbdd git://xenbits.xen.org/linux-pvops.git#c3038e718a19fc596f7b1baba0f83d5146dc7784-c3038e718a19fc596f7b1baba0f83d5146dc7784 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0\ dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/osstest/ovmf.git#4751a48aeb2ab828b0a5cbdc585fd3642967cda1-62bad17dcae18f55cb3bdc19909543dfdf928a2b git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://git.qemu.org/qemu.git#6f34661b6c97a37a5efc27d31c037ddeda4547e2-00084bab87c43be20638de7f191d1a1faed134cc git://xenbits.xen.org/osstest/seabios.git#b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee-b0d61ec\ ef66eb05bd7a4eb7ada88ec5dab06dfee git://xenbits.xen.org/xen.git#e4bdcc8aef6707027168ea29caed844a7da67b4d-90629587e16e2efdb61da77f25c25fba3c4a5fd7 Loaded 35153 nodes in revision graph Searching for test results: 159947 [dst_host=albana0,src_host=albana1] 160002 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6f34661b6c97a37a5efc27d31c037ddeda4547e2 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee e4bdcc8aef6707027168ea29caed844a7da67b4d 160048 [] 160050 [] 160057 [] 160062 [] 160064 [] 160066 [dst_host=fiano1,src_host=fiano0] 160070 [dst_host=godello1,src_host=godello0] 160079 [dst_host=elbling0,src_host=elbling1] 160082 [dst_host=pinot0,src_host=pinot1] 160088 [dst_host=albana1,src_host=albana0] 160091 [dst_host=chardonnay0,src_host=chardonnay1] 160097 [dst_host=chardonnay1,src_host=chardonnay0] 160104 [dst_host=godello0,src_host=godello1] 160113 [dst_host=godello1,src_host=godello0] 160119 [dst_host=elbling1,src_host=elbling0] 160125 [dst_host=albana0,src_host=albana1] 160134 fail irrelevant 160147 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 2e1293cbaac75e84f541f9acfa8e26749f4c3562 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160167 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 ca318882714080fb81fe9eb89a7b7934efc5bfae 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 bdee969c0e65d4d509932b1d70e3a3b2ffbff6d5 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160328 fail irrelevant 160361 fail irrelevant 160392 fail irrelevant 160418 fail irrelevant 160448 fail irrelevant 160477 fail irrelevant 160501 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b33cf5bfcb4c941370739dfbbe1532ff508fd29d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7b9a3c9f94bcac23c534bc9f42a9e914b433b299 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee e680cc48b7184d3489873d6776f84ba1fc238ced 160522 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b33cf5bfcb4c941370739dfbbe1532ff508fd29d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7b9a3c9f94bcac23c534bc9f42a9e914b433b299 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee e680cc48b7184d3489873d6776f84ba1fc238ced 160541 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b33cf5bfcb4c941370739dfbbe1532ff508fd29d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 ec2e6e016d24bd429792d08cf607e4c5350dcdaa b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee e680cc48b7184d3489873d6776f84ba1fc238ced 160563 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b33cf5bfcb4c941370739dfbbe1532ff508fd29d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7993b0f83fe5c3f8555e79781d5d098f99751a94 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee cead8c0d17462f3a1150b5657d3f4eaa88faf1cb 160619 fail irrelevant 160632 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 62bad17dcae18f55cb3bdc19909543dfdf928a2b 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6ee55e1d10c25c2f6bf5ce2084ad2327e17affa5 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 90629587e16e2efdb61da77f25c25fba3c4a5fd7 160650 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 62bad17dcae18f55cb3bdc19909543dfdf928a2b 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 00084bab87c43be20638de7f191d1a1faed134cc b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 90629587e16e2efdb61da77f25c25fba3c4a5fd7 160695 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6f34661b6c97a37a5efc27d31c037ddeda4547e2 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee e4bdcc8aef6707027168ea29caed844a7da67b4d 160697 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 62bad17dcae18f55cb3bdc19909543dfdf928a2b 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 00084bab87c43be20638de7f191d1a1faed134cc b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 90629587e16e2efdb61da77f25c25fba3c4a5fd7 160698 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 f2a9a6c2a86570ccbf8c5c30cbb8bf723168c459 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160699 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8a40754bca14df63c6d2ffe473b68a270dc50679 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160701 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7286d62d4e259be8cecf3dc2deea80ecc14489a5 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160702 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 69259911f948ad2755bd1f2c999dd60ac322c890 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160703 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6e71c36557ed41017e634ae392fa80f03ced7fa1 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160705 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 81cbfd5088690c53541ffd0d74851c8ab055a829 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160706 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 2255564fd21059960966b47212def9069cb56077 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160707 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8b858f9998a9d59a9a7188f2c5c6ffb99eff6115 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160708 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6e31b3a5c34c6e5be7ef60773e607f189eaa15f3 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee b4011741e6b39a8fd0ed5aded96c16c45ead5888 160710 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 2e51b27fed31eb7b2a2cb4245806c8c7859207f7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 0693602a23276b076a679b1e7ed9125a444336b6 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160712 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 51204c2f188ec1e2a38f14718d38a3772f850a4b b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee b4011741e6b39a8fd0ed5aded96c16c45ead5888 160713 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 757acb9a8295e8be4a37b2cfc1cd947e357fd29c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 14b95b3b8546db201e7efd0636ae0e215fae98f3 160714 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 dbcbda2cd846ab70bb25418f246604d0b546505f b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160717 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 30ca7eddc486646fa19c9619fcf233ceaa65e28c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160718 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 549d039667b92f6ff86fac1948d61ac558026996 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160720 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 773b0bc2838ede154c6de9d78401b91fafa91062 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 56b89f455894e4628ad7994fe5dd348145d1a9c5 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160722 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 313d86c956d4599054a9dcd524668f67797d317a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 5e8892db93f3fb6a7221f2d47f3c952a7e489737 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160723 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 146f720c55637410062041f68dc908645cd18aaa b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160725 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 4083904bc9fe5da580f7ca397b1e828fbc322732 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160726 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 516990f4df4f7bf9f86d38af71ead7175df15c19 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160728 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8d17adf34f501ded65a106572740760f0a75577c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160729 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 e67d8e2928200e24ecb47c7be3ea8270077f2996 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160730 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8d17adf34f501ded65a106572740760f0a75577c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160731 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 e67d8e2928200e24ecb47c7be3ea8270077f2996 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160732 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8d17adf34f501ded65a106572740760f0a75577c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160734 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 e67d8e2928200e24ecb47c7be3ea8270077f2996 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160735 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8d17adf34f501ded65a106572740760f0a75577c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 Searching for interesting versions Result found: flight 160002 (pass), for basis pass Result found: flight 160650 (fail), for basis failure Repro found: flight 160695 (pass), for basis pass Repro found: flight 160697 (fail), for basis failure 0 revisions at 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 e67d8e2928200e24ecb47c7be3ea8270077f2996 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 No revisions left to test, checking graph state. Result found: flight 160729 (pass), for last pass Result found: flight 160730 (fail), for first failure Repro found: flight 160731 (pass), for last pass Repro found: flight 160732 (fail), for first failure Repro found: flight 160734 (pass), for last pass Repro found: flight 160735 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: qemuu git://git.qemu.org/qemu.git Bug introduced: 8d17adf34f501ded65a106572740760f0a75577c Bug not present: e67d8e2928200e24ecb47c7be3ea8270077f2996 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/160735/ commit 8d17adf34f501ded65a106572740760f0a75577c Author: Daniel P. Berrangé Date: Mon Feb 22 11:16:32 2021 +0000 block: remove support for using "file" driver with block/char devices The 'host_device' and 'host_cdrom' drivers must be used instead. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé Revision graph left in /home/logs/results/bisect/qemu-mainline/test-amd64-amd64-libvirt-pair.guest-start--debian.{dot,ps,png,html,svg}. ---------------------------------------- 160735: tolerable FAIL flight 160735 qemu-mainline real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/160735/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: test-amd64-amd64-libvirt-pair 25 guest-start/debian fail baseline untested jobs: build-amd64-libvirt pass test-amd64-amd64-libvirt-pair fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Mon Apr 05 02:53:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Apr 2021 02:53:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105237.201578 (Exim 4.92) (envelope-from ) id 1lTFMt-00011s-B9; Mon, 05 Apr 2021 02:53:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105237.201578; Mon, 05 Apr 2021 02:53:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTFMt-00011j-2s; Mon, 05 Apr 2021 02:53:35 +0000 Received: by outflank-mailman (input) for mailman id 105237; Mon, 05 Apr 2021 02:53:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTFMr-00011b-Gc; Mon, 05 Apr 2021 02:53:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTFMr-0005YO-6I; Mon, 05 Apr 2021 02:53:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTFMq-0008Aq-RY; Mon, 05 Apr 2021 02:53:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lTFMq-0000Ox-Qm; Mon, 05 Apr 2021 02:53:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MNFpkNxPxem0eAcZcw1pM7ToFXeBz7WFcdoXI8SiwjI=; b=DwymG0407FeL707uhWmhe60rR9 m4jhLN0MBti6j8yrkR5SLifC44Sf8L+eEPK680jmbIWu2NYqSi1Qz85DQQ5x7YGuuJ3xaU7XSt9eb c9vBm7liurvykHKgP4JpbizVjJzi96s1DbMKvgOn4jsfPnLSIVTH2nGpwPhXlBgIIWv4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.12-testing test] 160724: regressions - FAIL X-Osstest-Failures: xen-4.12-testing:build-armhf::broken:regression xen-4.12-testing:build-armhf:host-install(4):broken:regression xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-localmigrate/x10:fail:regression xen-4.12-testing:test-amd64-amd64-libvirt-pair:guests-nbd-mirror/debian:fail:heisenbug xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-saverestore.2:fail:heisenbug xen-4.12-testing:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-4.12-testing:build-armhf-libvirt:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=5b280a59c4dd8dad6cc8da28db981b193d10acee X-Osstest-Versions-That: xen=4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 From: osstest service owner Date: Mon, 05 Apr 2021 02:53:32 +0000 flight 160724 xen-4.12-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/160724/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken in 160709 build-armhf 4 host-install(4) broken in 160709 REGR. vs. 159418 test-amd64-amd64-xl-qcow2 19 guest-localmigrate/x10 fail in 160709 REGR. vs. 159418 Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-pair 22 guests-nbd-mirror/debian fail in 160709 pass in 160724 test-amd64-amd64-xl-qcow2 18 guest-saverestore.2 fail pass in 160709 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 1 build-check(1) blocked in 160709 n/a test-armhf-armhf-xl 1 build-check(1) blocked in 160709 n/a test-armhf-armhf-libvirt 1 build-check(1) blocked in 160709 n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked in 160709 n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked in 160709 n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked in 160709 n/a build-armhf-libvirt 1 build-check(1) blocked in 160709 n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked in 160709 n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked in 160709 n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked in 160709 n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked in 160709 n/a test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159418 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159418 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159418 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: xen 5b280a59c4dd8dad6cc8da28db981b193d10acee baseline version: xen 4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 Last test of basis 159418 2021-02-16 15:06:11 Z 47 days Failing since 160128 2021-03-18 14:36:18 Z 17 days 21 attempts Testing same since 160150 2021-03-20 04:11:48 Z 15 days 19 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Christian Lindig Edwin Török Igor Druzhinin Jan Beulich Julien Grall Olaf Hering Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken Not pushing. (No revision log; it would be 311 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Apr 05 05:14:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Apr 2021 05:14:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105248.201605 (Exim 4.92) (envelope-from ) id 1lTHYb-0005U0-PN; Mon, 05 Apr 2021 05:13:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105248.201605; Mon, 05 Apr 2021 05:13:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTHYb-0005Tt-M7; Mon, 05 Apr 2021 05:13:49 +0000 Received: by outflank-mailman (input) for mailman id 105248; Mon, 05 Apr 2021 05:13:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTHYb-0005Tl-1J; Mon, 05 Apr 2021 05:13:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTHYa-0000Jp-Mg; Mon, 05 Apr 2021 05:13:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTHYa-0006CK-Aw; Mon, 05 Apr 2021 05:13:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lTHYa-00029l-AU; Mon, 05 Apr 2021 05:13:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=uL5kZ5fO7VICHVwJ1LB2BS7lEz0p5X7JJTk4txpF3yc=; b=N03LhDTbSB5w6nkHsOpWrAEX9F +LEdS7E6gnag3y6fKo6qS3hWCN9LMzDv9Dz1PEn90ijaZ2MjZXqPsQ0fp6tV1hwVXfIhrSEn0UDjT 6ZsfUodft70HB84yHPg/kSgPHvtJhAwT9Jp+KDmvAt935yZytJ859RNFoT5m+kIut1RI=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160727: regressions - FAIL X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-cubietruck::broken:regression linux-linus:test-armhf-armhf-xl-multivcpu::broken:regression linux-linus:test-armhf-armhf-xl-rtds::broken:regression linux-linus:test-armhf-armhf-xl-credit2::broken:regression linux-linus:test-armhf-armhf-libvirt::broken:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-armhf-armhf-xl-credit1:debian-install:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-linus:test-armhf-armhf-xl-vhd:debian-di-install:fail:heisenbug linux-linus:test-armhf-armhf-libvirt-raw:debian-di-install:fail:heisenbug linux-linus:test-amd64-amd64-i386-pvgrub:guest-localmigrate/x10:fail:heisenbug linux-linus:test-armhf-armhf-libvirt:host-install(5):broken:nonblocking linux-linus:test-armhf-armhf-xl-rtds:host-install(5):broken:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:host-install(5):broken:nonblocking linux-linus:test-armhf-armhf-xl-credit2:host-install(5):broken:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:host-install(5):broken:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=2023a53bdf41b7646b1d384b6816af06309f73a5 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Mon, 05 Apr 2021 05:13:48 +0000 flight 160727 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160727/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-cubietruck broken in 160711 test-armhf-armhf-xl-multivcpu broken in 160711 test-armhf-armhf-xl-rtds broken in 160711 test-armhf-armhf-xl-credit2 broken in 160711 test-armhf-armhf-libvirt broken in 160711 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail in 160711 REGR. vs. 152332 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-credit1 12 debian-install fail in 160711 pass in 160727 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 160711 pass in 160727 test-armhf-armhf-xl-vhd 12 debian-di-install fail in 160711 pass in 160727 test-armhf-armhf-libvirt-raw 12 debian-di-install fail in 160711 pass in 160727 test-amd64-amd64-i386-pvgrub 19 guest-localmigrate/x10 fail pass in 160711 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 5 host-install(5) broken in 160711 blocked in 152332 test-armhf-armhf-xl-rtds 5 host-install(5) broken in 160711 blocked in 152332 test-armhf-armhf-xl-multivcpu 5 host-install(5) broken in 160711 blocked in 152332 test-armhf-armhf-xl-credit2 5 host-install(5) broken in 160711 blocked in 152332 test-armhf-armhf-xl-cubietruck 5 host-install(5) broken in 160711 blocked in 152332 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 2023a53bdf41b7646b1d384b6816af06309f73a5 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 247 days Failing since 152366 2020-08-01 20:49:34 Z 246 days 419 attempts Testing same since 160711 2021-04-04 00:11:23 Z 1 days 2 attempts ------------------------------------------------------------ 5291 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-xl-cubietruck broken broken-job test-armhf-armhf-xl-multivcpu broken broken-job test-armhf-armhf-xl-rtds broken broken-job test-armhf-armhf-xl-credit2 broken broken-job test-armhf-armhf-libvirt broken Not pushing. (No revision log; it would be 1315124 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Apr 05 09:08:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Apr 2021 09:08:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105279.201631 (Exim 4.92) (envelope-from ) id 1lTLDG-0000EA-H5; Mon, 05 Apr 2021 09:08:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105279.201631; Mon, 05 Apr 2021 09:08:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTLDG-0000E3-Dx; Mon, 05 Apr 2021 09:08:02 +0000 Received: by outflank-mailman (input) for mailman id 105279; Mon, 05 Apr 2021 09:08:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTLDF-0000Dv-Jx; Mon, 05 Apr 2021 09:08:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTLDF-0004cd-8N; Mon, 05 Apr 2021 09:08:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTLDF-0001Fp-1p; Mon, 05 Apr 2021 09:08:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lTLDF-0001wo-1J; Mon, 05 Apr 2021 09:08:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2O96qeXtOV6pU5R+WsFNT1foxV9bzQKMn1WXKTqBrxY=; b=UuP12rfXo8dBOuxIZ7p6fRsiFH l9EiUf1SFczHgfCvW36EUjmP3co3vX7pzFYl0xJnBn9X+A0Ouma34uOMM8bVleb3GMdM6URmtQp45 Wha8EUVRLMzTzkBNwrV6UnpK1fZ2h8IvVFUQC5+Svsf+QG20bHb026mtJNRcoJ1/LdkE=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 160740: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=2fc3a704e7083afab0537cf0777521afa9cc1db6 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Mon, 05 Apr 2021 09:08:01 +0000 flight 160740 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/160740/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt 2fc3a704e7083afab0537cf0777521afa9cc1db6 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 269 days Failing since 151818 2020-07-11 04:18:52 Z 268 days 261 attempts Testing same since 160661 2021-04-02 04:19:00 Z 3 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei simmon Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin WangJian Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yaroslav Kargin Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 49860 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Apr 05 10:19:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Apr 2021 10:19:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105295.201647 (Exim 4.92) (envelope-from ) id 1lTMKI-0006H0-5f; Mon, 05 Apr 2021 10:19:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105295.201647; Mon, 05 Apr 2021 10:19:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTMKI-0006Gt-2P; Mon, 05 Apr 2021 10:19:22 +0000 Received: by outflank-mailman (input) for mailman id 105295; Mon, 05 Apr 2021 10:19:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTMKH-0006Gl-0j; Mon, 05 Apr 2021 10:19:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTMKG-0005pH-NE; Mon, 05 Apr 2021 10:19:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTMKG-0003dV-DS; Mon, 05 Apr 2021 10:19:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lTMKG-0008W1-Cx; Mon, 05 Apr 2021 10:19:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=sN7dOpD1lbgDwIwMt30mLdh0we54FItkjRp2vOjTWfE=; b=oh4SxP4xWKAJVB87giD4qa8S/I 8YsAS4dw4F7ir0VPNw7za7QLnsEytKBrbvKQk6jFYXmY9SyQY6uuGOrvdaXQec+RapLgUv5H0AWav iSMLrgUphBcVPmYoGzhvZdTDfbNjtp+j3/Nkh+aFMZxadbKict717yjHAreteEYZHaws=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 160733: regressions - FAIL X-Osstest-Failures: xen-unstable:test-armhf-armhf-libvirt::broken:regression xen-unstable:test-armhf-armhf-libvirt-raw::broken:regression xen-unstable:test-armhf-armhf-xl::broken:regression xen-unstable:test-armhf-armhf-xl-rtds::broken:regression xen-unstable:test-armhf-armhf-xl-credit1::broken:regression xen-unstable:test-armhf-armhf-xl-credit2::broken:regression xen-unstable:test-armhf-armhf-xl-multivcpu::broken:regression xen-unstable:test-armhf-armhf-xl-vhd::broken:regression xen-unstable:test-armhf-armhf-xl-cubietruck::broken:regression xen-unstable:test-armhf-armhf-xl-arndale::broken:regression xen-unstable:test-armhf-armhf-xl-arndale:guest-start.2:fail:regression xen-unstable:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression xen-unstable:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression xen-unstable:test-armhf-armhf-libvirt:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-xl:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-xl-multivcpu:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-xl-vhd:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-xl-credit1:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-libvirt-raw:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-examine:host-install:broken:heisenbug xen-unstable:test-armhf-armhf-xl-credit2:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-xl-arndale:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-xl-cubietruck:host-install(5):broken:heisenbug xen-unstable:test-arm64-arm64-xl-seattle:xen-boot:fail:heisenbug xen-unstable:test-armhf-armhf-xl-arndale:xen-boot:fail:heisenbug xen-unstable:test-armhf-armhf-xl-vhd:xen-boot:fail:heisenbug xen-unstable:test-armhf-armhf-examine:reboot:fail:heisenbug xen-unstable:test-armhf-armhf-xl-credit1:guest-start:fail:heisenbug xen-unstable:test-armhf-armhf-xl:xen-boot:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt:guest-start:fail:heisenbug xen-unstable:test-armhf-armhf-xl-vhd:debian-di-install:fail:heisenbug xen-unstable:test-armhf-armhf-xl-credit2:guest-start:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:xen-boot:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt-raw:debian-di-install:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=0435784cc75dcfef3b5f59c29deb1dbb84265ddb X-Osstest-Versions-That: xen=b0976d5c0441378b6348f5bfedbf431055bd0147 From: osstest service owner Date: Mon, 05 Apr 2021 10:19:20 +0000 flight 160733 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/160733/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt broken in 160665 test-armhf-armhf-libvirt-raw broken in 160700 test-armhf-armhf-xl broken in 160700 test-armhf-armhf-xl-rtds broken in 160700 test-armhf-armhf-xl-credit1 broken in 160700 test-armhf-armhf-xl-credit2 broken in 160700 test-armhf-armhf-xl-multivcpu broken in 160700 test-armhf-armhf-xl-vhd broken in 160700 test-armhf-armhf-xl-cubietruck broken in 160715 test-armhf-armhf-xl-arndale broken in 160715 test-armhf-armhf-xl-arndale 19 guest-start.2 fail REGR. vs. 160646 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REGR. vs. 160646 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 160646 Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt 5 host-install(5) broken in 160665 pass in 160733 test-armhf-armhf-xl 5 host-install(5) broken in 160700 pass in 160733 test-armhf-armhf-xl-rtds 5 host-install(5) broken in 160700 pass in 160733 test-armhf-armhf-xl-multivcpu 5 host-install(5) broken in 160700 pass in 160733 test-armhf-armhf-xl-vhd 5 host-install(5) broken in 160700 pass in 160733 test-armhf-armhf-xl-credit1 5 host-install(5) broken in 160700 pass in 160733 test-armhf-armhf-libvirt-raw 5 host-install(5) broken in 160700 pass in 160733 test-armhf-armhf-examine 5 host-install broken in 160700 pass in 160733 test-armhf-armhf-xl-credit2 5 host-install(5) broken in 160700 pass in 160733 test-armhf-armhf-xl-arndale 5 host-install(5) broken in 160715 pass in 160733 test-armhf-armhf-xl-cubietruck 5 host-install(5) broken in 160715 pass in 160733 test-arm64-arm64-xl-seattle 8 xen-boot fail in 160665 pass in 160733 test-armhf-armhf-xl-arndale 8 xen-boot fail in 160665 pass in 160733 test-armhf-armhf-xl-vhd 8 xen-boot fail in 160665 pass in 160733 test-armhf-armhf-examine 8 reboot fail in 160665 pass in 160733 test-armhf-armhf-xl-credit1 14 guest-start fail in 160665 pass in 160733 test-armhf-armhf-xl 8 xen-boot fail in 160715 pass in 160733 test-armhf-armhf-libvirt 14 guest-start fail in 160715 pass in 160733 test-armhf-armhf-xl-vhd 12 debian-di-install fail in 160715 pass in 160733 test-armhf-armhf-xl-credit2 14 guest-start fail pass in 160665 test-armhf-armhf-xl-rtds 8 xen-boot fail pass in 160665 test-armhf-armhf-libvirt 18 guest-start/debian.repeat fail pass in 160700 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 160715 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail pass in 160715 test-armhf-armhf-libvirt-raw 12 debian-di-install fail pass in 160715 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 160665 REGR. vs. 160646 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 160665 like 160646 test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 160665 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 160665 never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 160665 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 160665 never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 160665 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160646 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160646 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160646 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160646 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160646 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160646 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160646 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160646 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160646 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160646 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: xen 0435784cc75dcfef3b5f59c29deb1dbb84265ddb baseline version: xen b0976d5c0441378b6348f5bfedbf431055bd0147 Last test of basis 160646 2021-04-01 15:07:43 Z 3 days Testing same since 160665 2021-04-02 07:40:09 Z 3 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Bertrand Marquis Jan Beulich Julien Grall Michal Orzel Norbert Manthey Rahul Singh Roger Pau Monné Stefano Stabellini Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw fail test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-libvirt broken broken-job test-armhf-armhf-xl-cubietruck broken broken-job test-armhf-armhf-xl-arndale broken broken-job test-armhf-armhf-libvirt-raw broken broken-job test-armhf-armhf-xl broken broken-job test-armhf-armhf-xl-rtds broken broken-job test-armhf-armhf-xl-arndale broken broken-job test-armhf-armhf-xl-credit1 broken broken-job test-armhf-armhf-xl-credit2 broken broken-job test-armhf-armhf-xl-multivcpu broken broken-job test-armhf-armhf-xl-cubietruck broken broken-job test-armhf-armhf-xl-vhd broken Not pushing. (No revision log; it would be 412 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Apr 05 13:29:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Apr 2021 13:29:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105338.201674 (Exim 4.92) (envelope-from ) id 1lTPHz-0005sQ-JJ; Mon, 05 Apr 2021 13:29:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105338.201674; Mon, 05 Apr 2021 13:29:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTPHz-0005sJ-Fn; Mon, 05 Apr 2021 13:29:11 +0000 Received: by outflank-mailman (input) for mailman id 105338; Mon, 05 Apr 2021 13:29:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTPHy-0005sB-4G; Mon, 05 Apr 2021 13:29:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTPHx-0000Od-SJ; Mon, 05 Apr 2021 13:29:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTPHx-00067Q-HR; Mon, 05 Apr 2021 13:29:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lTPHx-0005ir-Gv; Mon, 05 Apr 2021 13:29:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=nAnIy3DgSys8KBVaeOz8EjKmpkCDFAC74rDL8PxDl2g=; b=CDG2B5U/QfB1fuk7zpOmpgl1tQ QGKZJiT2CM2CeJdF0hjDqqbxLTnek/Q3JDqwWk1fPfU+qvEmledsNl26GE/W+DHXtxjeK4hjaKCkv unTfFG3mEbfljzyTMhxNyI1R33zVnDAuH2F6i2w3D+++Cf9IC0CGgqXtkqgxR90sDySY=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160736: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-amd64-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-freebsd10-i386:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-freebsd10-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-i386-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-arm64-arm64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install/l1/l2:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-armhf-armhf-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=11577d85b1a6939380bd16ed9a861653194de044 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Mon, 05 Apr 2021 13:29:09 +0000 flight 160736 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/160736/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-qemuu-freebsd12-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-freebsd10-i386 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-freebsd10-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-i386-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-arm64-arm64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-qemuu-nested-intel 20 debian-hvm-install/l1/l2 fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: qemuu 11577d85b1a6939380bd16ed9a861653194de044 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 228 days Failing since 152659 2020-08-21 14:07:39 Z 226 days 427 attempts Testing same since 160736 2021-04-05 00:08:23 Z 0 days 1 attempts ------------------------------------------------------------ 473 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair fail test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 140239 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Apr 05 15:23:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Apr 2021 15:23:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105384.201713 (Exim 4.92) (envelope-from ) id 1lTR4K-0007tD-In; Mon, 05 Apr 2021 15:23:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105384.201713; Mon, 05 Apr 2021 15:23:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTR4K-0007t6-FB; Mon, 05 Apr 2021 15:23:12 +0000 Received: by outflank-mailman (input) for mailman id 105384; Mon, 05 Apr 2021 15:23:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTR4I-0007t0-Ra for xen-devel@lists.xenproject.org; Mon, 05 Apr 2021 15:23:10 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTR4H-0002IC-6z; Mon, 05 Apr 2021 15:23:09 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lTR4G-0002lq-Ta; Mon, 05 Apr 2021 15:23:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=W5ihRJJDL5BZpDAbRofYPevwvtdzt1aQrYD3bamf+Q4=; b=bkwMAbUFUcf5YP7p3q06OV9/QJ 5OuvBmw2ujcxYRBdpPNXL1wSSgGhW2U419DDr0q0DAe2o/1JTtXIFxdnwj9WngvUCYiGsA+DWTriD WpPCnFf0vnGVT2fNY6AzxMqlr3tA/U2D9U5ykeFaEB1gzDfxofcBVGx/OzyAan7Qf0Ik=; Subject: Re: [PATCH v3 0/3] Generic SMMU Bindings To: Stefano Stabellini , xen-devel Cc: Bertrand.Marquis@arm.com, Volodymyr_Babchuk@epam.com, rahul.singh@arm.com, brian.woods@xilinx.com References: From: Julien Grall Message-ID: <80de3eb5-b338-af4e-42eb-d358f51d0bd7@xen.org> Date: Mon, 5 Apr 2021 16:23:06 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 26/01/2021 22:58, Stefano Stabellini wrote: > Hi all, Hi Stefano, > This series introduces support for the generic SMMU bindings to > xen/drivers/passthrough/arm/smmu.c. > > The last version of the series was > https://marc.info/?l=xen-devel&m=159539053406643 Some changes in the SMMU drivers went in recently. I believe this touched similar area to this series. Would you be able to check that this series still work as intented? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Apr 05 15:57:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Apr 2021 15:57:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105395.201745 (Exim 4.92) (envelope-from ) id 1lTRbO-00029S-UG; Mon, 05 Apr 2021 15:57:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105395.201745; Mon, 05 Apr 2021 15:57:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRbO-00029F-Oe; Mon, 05 Apr 2021 15:57:22 +0000 Received: by outflank-mailman (input) for mailman id 105395; Mon, 05 Apr 2021 15:57:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRbN-00027f-5b for xen-devel@lists.xenproject.org; Mon, 05 Apr 2021 15:57:21 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRbM-0002nH-LS; Mon, 05 Apr 2021 15:57:20 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTRbM-00053b-Cu; Mon, 05 Apr 2021 15:57:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=FL2yQM6+D2+NHIgkPxbbHrXWAKmxpnXf59OkWXn01Qw=; b=olnT+4wdfgOmsFVK0XVuv2Zrh FMugV25jq7TYAhXZfOZEa1zDLyx93/ejxZ9Kv3epsIjZOdLbwoUjxytoUG0qNy0SpfHXWj414Viu6 dMzKuBnjkGhNhdaD4dSgcQkaO8bEOSxwtvGYoAOt7gg6LdiOOvfVpuZRzaIu/bgntk344=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , George Dunlap , Dario Faggioli Subject: [PATCH 02/14] xen/sched: Constify name and opt_name in struct scheduler Date: Mon, 5 Apr 2021 16:57:01 +0100 Message-Id: <20210405155713.29754-3-julien@xen.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210405155713.29754-1-julien@xen.org> References: <20210405155713.29754-1-julien@xen.org> From: Julien Grall Both name and opt_name are pointing to literal string. So mark both of the fields as const. Signed-off-by: Julien Grall --- xen/common/sched/private.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/common/sched/private.h b/xen/common/sched/private.h index 92d0d4961063..a870320146ef 100644 --- a/xen/common/sched/private.h +++ b/xen/common/sched/private.h @@ -272,8 +272,8 @@ static inline spinlock_t *pcpu_schedule_trylock(unsigned int cpu) } struct scheduler { - char *name; /* full name for this scheduler */ - char *opt_name; /* option name for this scheduler */ + const char *name; /* full name for this scheduler */ + const char *opt_name; /* option name for this scheduler */ unsigned int sched_id; /* ID for this scheduler */ void *sched_data; /* global data pointer */ struct cpupool *cpupool;/* points to this scheduler's pool */ -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Apr 05 15:57:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Apr 2021 15:57:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105394.201732 (Exim 4.92) (envelope-from ) id 1lTRbO-00028K-Ff; Mon, 05 Apr 2021 15:57:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105394.201732; Mon, 05 Apr 2021 15:57:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRbO-00028B-91; Mon, 05 Apr 2021 15:57:22 +0000 Received: by outflank-mailman (input) for mailman id 105394; Mon, 05 Apr 2021 15:57:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRbM-00027a-OL for xen-devel@lists.xenproject.org; Mon, 05 Apr 2021 15:57:20 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRbL-0002nA-Ls; Mon, 05 Apr 2021 15:57:19 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTRbL-00053b-CT; Mon, 05 Apr 2021 15:57:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=wM0arhOfbdXKBnD+kuNFkMVWLt0+0LE5S6yLwtX1v4g=; b=yK+fPDTfexuES8exRK8gSibPD 5zO9GPsi3gdF5Mf4ClqCwHiYojBQ0lPqt3biOe2NYHQS8U7TkQpf07ciBZ/Uupf5iWlihZ4qUJVet fFfEDFAbtETs+5V43M++oc3DKQHkyR0VSuHoR/nXgt89UcadmAND2MN1cuB/X065weMpE=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu Subject: [PATCH 01/14] xen: Constify the second parameter of rangeset_new() Date: Mon, 5 Apr 2021 16:57:00 +0100 Message-Id: <20210405155713.29754-2-julien@xen.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210405155713.29754-1-julien@xen.org> References: <20210405155713.29754-1-julien@xen.org> From: Julien Grall The string 'name' will never get modified by the function, so mark it as const. Signed-off-by: Julien Grall --- xen/common/rangeset.c | 2 +- xen/include/xen/rangeset.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/common/rangeset.c b/xen/common/rangeset.c index 4ebba30ba303..d997d7bce9e2 100644 --- a/xen/common/rangeset.c +++ b/xen/common/rangeset.c @@ -421,7 +421,7 @@ bool_t rangeset_is_empty( } struct rangeset *rangeset_new( - struct domain *d, char *name, unsigned int flags) + struct domain *d, const char *name, unsigned int flags) { struct rangeset *r; diff --git a/xen/include/xen/rangeset.h b/xen/include/xen/rangeset.h index 5f62a9797170..135f33f6066f 100644 --- a/xen/include/xen/rangeset.h +++ b/xen/include/xen/rangeset.h @@ -36,7 +36,7 @@ void rangeset_domain_destroy( * rangeset_destroy(r). */ struct rangeset *rangeset_new( - struct domain *d, char *name, unsigned int flags); + struct domain *d, const char *name, unsigned int flags); void rangeset_destroy( struct rangeset *r); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Apr 05 15:57:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Apr 2021 15:57:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105397.201767 (Exim 4.92) (envelope-from ) id 1lTRbR-0002D7-M5; Mon, 05 Apr 2021 15:57:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105397.201767; Mon, 05 Apr 2021 15:57:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRbR-0002Cs-Cc; Mon, 05 Apr 2021 15:57:25 +0000 Received: by outflank-mailman (input) for mailman id 105397; Mon, 05 Apr 2021 15:57:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRbQ-0002BR-Dp for xen-devel@lists.xenproject.org; Mon, 05 Apr 2021 15:57:24 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRbP-0002nu-J8; Mon, 05 Apr 2021 15:57:23 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTRbP-00053b-Ac; Mon, 05 Apr 2021 15:57:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=lOO8LxgjP7mfnbj4AR6O+AWqc4xBBvOnf0MxiUn+xT8=; b=nzCnexDfy6V5fekkYmcoVJHtI x8Fw26jDm+t15L03/PZnBhfbg0aMQoaEkyJzu7NnS9z0XgKqddyUx8/jOSxhsR52zgpVzT3wS5nnG Q0TQ/MaTBPAaO7eKnps6yl0ItuhcZXqeY9CDzSPWD1TnNwkO8TDdQUCPnCHTVTfs7e6Ds=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu Subject: [PATCH 04/14] xen/char: console: Use const whenever we point to literal strings Date: Mon, 5 Apr 2021 16:57:03 +0100 Message-Id: <20210405155713.29754-5-julien@xen.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210405155713.29754-1-julien@xen.org> References: <20210405155713.29754-1-julien@xen.org> From: Julien Grall literal strings are not meant to be modified. So we should use const char * rather than char * when we want to store a pointer to them. Signed-off-by: Julien Grall --- xen/drivers/char/console.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c index 23583751709c..72a7cd1c32c1 100644 --- a/xen/drivers/char/console.c +++ b/xen/drivers/char/console.c @@ -168,7 +168,7 @@ static int parse_guest_loglvl(const char *s); static char xenlog_val[LOGLVL_VAL_SZ]; static char xenlog_guest_val[LOGLVL_VAL_SZ]; -static char *lvl2opt[] = { "none", "error", "warning", "info", "all" }; +static const char *lvl2opt[] = { "none", "error", "warning", "info", "all" }; static void xenlog_update_val(int lower, int upper, char *val) { @@ -262,7 +262,7 @@ static int parse_guest_loglvl(const char *s) return ret; } -static char *loglvl_str(int lvl) +static const char *loglvl_str(int lvl) { switch ( lvl ) { -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Apr 05 15:57:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Apr 2021 15:57:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105393.201724 (Exim 4.92) (envelope-from ) id 1lTRbO-00027r-4H; Mon, 05 Apr 2021 15:57:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105393.201724; Mon, 05 Apr 2021 15:57:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRbO-00027k-1O; Mon, 05 Apr 2021 15:57:22 +0000 Received: by outflank-mailman (input) for mailman id 105393; Mon, 05 Apr 2021 15:57:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRbM-00027V-9M for xen-devel@lists.xenproject.org; Mon, 05 Apr 2021 15:57:20 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRbK-0002n6-Cy; Mon, 05 Apr 2021 15:57:18 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTRbJ-00053b-TX; Mon, 05 Apr 2021 15:57:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=1GqICW/O9fKSb94+mzq/HGQFUX5If7mWeUd6pvOkBFY=; b=bvu0XCkxaPx45nkPtYZpTbXk0g swkcbZyG1lETz8WlL3dplJSKeAnjacM5cZurrefJ2FyB1+5Is9apqGs8Dqk4un0JHN/MKM/oMu5dU ZMRORl0p7ZC0GsS+PE9efyXL9D/F0pj5Dpy3n/zTjzVhKQiEGll+aOI0POhkL8F2zbik=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu , Dario Faggioli , Tim Deegan , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Anthony PERARD Subject: [PATCH 00/14] Use const whether we point to literal strings (take 1) Date: Mon, 5 Apr 2021 16:56:59 +0100 Message-Id: <20210405155713.29754-1-julien@xen.org> X-Mailer: git-send-email 2.17.1 From: Julien Grall Hi all, By default, both Clang and GCC will happily compile C code where non-const char * point to literal strings. This means the following code will be accepted: char *str = "test"; str[0] = 'a'; Literal strings will reside in rodata, so they are not modifiable. This will result to an permission fault at runtime if the permissions are enforced in the page-tables (this is the case in Xen). I am not aware of code trying to modify literal strings in Xen. However, there is a frequent use of non-const char * to point to literal strings. Given the size of the codebase, there is a risk to involuntarily introduce code that will modify literal strings. Therefore it would be better to enforce using const when pointing to such strings. Both GCC and Clang provide an option to warn for such case (see -Wwrite-strings) and therefore could be used by Xen. This series doesn't yet make use of -Wwrite-strings because the tree is not fully converted. Instead, it contains some easy and likely non-controversial use const in the code. The major blockers to enable -Wwrite-strings are the following: - xen/common/efi: union string is used in both const and non-const situation. It doesn't feel right to specific one member const and the other non-const. - libxl: the major block is the flexarray framework as we would use it with string (now const char*). I thought it would be possible to make the interface const, but it looks like there are a couple of places where we need to modify the content (such as in libxl_json.c). Ideally, I would like to have -Wwrite-strings unconditionally used tree-wide. But, some of the area may required some heavy refactoring. One solution would be to enable it tree-wide but turned it off at a directroy/file level. Any opinions? Cheers, Julien Grall (14): xen: Constify the second parameter of rangeset_new() xen/sched: Constify name and opt_name in struct scheduler xen/x86: shadow: The return type of sh_audit_flags() should be const xen/char: console: Use const whenever we point to literal strings tools/libs: guest: Use const whenever we point to literal strings tools/libs: stat: Use const whenever we point to literal strings tools/xl: Use const whenever we point to literal strings tools/firmware: hvmloader: Use const in __bug() and __assert_failed() tools/console: Use const whenever we point to literal strings tools/kdd: Use const whenever we point to literal strings tools/misc: Use const whenever we point to literal strings tools/top: The string parameter in set_prompt() and set_delay() should be const tools/xenmon: xenbaked: Mark const the field text in stat_map_t tools/xentrace: Use const whenever we point to literal strings tools/console/client/main.c | 4 +- tools/console/daemon/io.c | 10 ++-- tools/debugger/kdd/kdd.c | 10 ++-- tools/firmware/hvmloader/util.c | 4 +- tools/firmware/hvmloader/util.h | 4 +- tools/include/xenguest.h | 10 ++-- tools/libs/guest/xg_dom_core.c | 8 ++-- tools/libs/guest/xg_dom_elfloader.c | 4 +- tools/libs/guest/xg_dom_hvmloader.c | 2 +- tools/libs/guest/xg_dom_x86.c | 9 ++-- tools/libs/guest/xg_private.h | 2 +- tools/libs/stat/xenstat_linux.c | 4 +- tools/libs/stat/xenstat_qmp.c | 12 ++--- tools/misc/xen-detect.c | 2 +- tools/misc/xenhypfs.c | 6 +-- tools/xenmon/xenbaked.c | 2 +- tools/xentop/xentop.c | 12 ++--- tools/xentrace/xenalyze.c | 71 +++++++++++++++-------------- tools/xentrace/xenctx.c | 4 +- tools/xl/xl.h | 8 ++-- tools/xl/xl_console.c | 2 +- tools/xl/xl_utils.c | 4 +- tools/xl/xl_utils.h | 4 +- xen/arch/x86/mm/shadow/multi.c | 12 ++--- xen/common/rangeset.c | 2 +- xen/common/sched/private.h | 4 +- xen/drivers/char/console.c | 4 +- xen/include/xen/rangeset.h | 2 +- 28 files changed, 113 insertions(+), 109 deletions(-) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Apr 05 15:57:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Apr 2021 15:57:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105396.201761 (Exim 4.92) (envelope-from ) id 1lTRbR-0002CF-5O; Mon, 05 Apr 2021 15:57:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105396.201761; Mon, 05 Apr 2021 15:57:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRbR-0002C7-1f; Mon, 05 Apr 2021 15:57:25 +0000 Received: by outflank-mailman (input) for mailman id 105396; Mon, 05 Apr 2021 15:57:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRbP-0002AY-BS for xen-devel@lists.xenproject.org; Mon, 05 Apr 2021 15:57:23 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRbO-0002nT-3j; Mon, 05 Apr 2021 15:57:22 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTRbN-00053b-Rj; Mon, 05 Apr 2021 15:57:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=+qpe2Q4MYVn+N9AOgWxQnBcvE9Q4UEVlLyVO20fEAig=; b=0s6PRARc2L7Ols9se5qmubITO gCphmgCs7lKIQzI5hW9F5lftz96cYZXIWqh44Nvg3k88t04xh2WXceIGv1LD5/oFrnBHoWEiz1uBO WH5HjSuPJUx+pmj180WxZlco8v+Pv8RpV0pKgXiRbET7wZNbUDGLZDTU9xIQ3kSC7NJFE=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Tim Deegan , Jan Beulich , Andrew Cooper , George Dunlap , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 03/14] xen/x86: shadow: The return type of sh_audit_flags() should be const Date: Mon, 5 Apr 2021 16:57:02 +0100 Message-Id: <20210405155713.29754-4-julien@xen.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210405155713.29754-1-julien@xen.org> References: <20210405155713.29754-1-julien@xen.org> From: Julien Grall The function sh_audit_flags() is returning pointer to literal strings. They should not be modified, so the return is now const and this is propagated to the callers. Take the opportunity to fix the coding style in the declaration of sh_audit_flags. Signed-off-by: Julien Grall --- xen/arch/x86/mm/shadow/multi.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/xen/arch/x86/mm/shadow/multi.c b/xen/arch/x86/mm/shadow/multi.c index 9b43cb116c47..0342de81d2c1 100644 --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -4290,8 +4290,8 @@ static void sh_pagetable_dying(paddr_t gpa) done = 1; \ } while (0) -static char * sh_audit_flags(struct vcpu *v, int level, - int gflags, int sflags) +static const char *sh_audit_flags(struct vcpu *v, int level, + int gflags, int sflags) /* Common code for auditing flag bits */ { if ( (sflags & _PAGE_PRESENT) && !(gflags & _PAGE_PRESENT) ) @@ -4324,7 +4324,7 @@ int sh_audit_l1_table(struct vcpu *v, mfn_t sl1mfn, mfn_t x) mfn_t mfn, gmfn, gl1mfn; gfn_t gfn; p2m_type_t p2mt; - char *s; + const char *s; int done = 0; /* Follow the backpointer */ @@ -4419,7 +4419,7 @@ int sh_audit_l2_table(struct vcpu *v, mfn_t sl2mfn, mfn_t x) mfn_t mfn, gmfn, gl2mfn; gfn_t gfn; p2m_type_t p2mt; - char *s; + const char *s; int done = 0; /* Follow the backpointer */ @@ -4471,7 +4471,7 @@ int sh_audit_l3_table(struct vcpu *v, mfn_t sl3mfn, mfn_t x) mfn_t mfn, gmfn, gl3mfn; gfn_t gfn; p2m_type_t p2mt; - char *s; + const char *s; int done = 0; /* Follow the backpointer */ @@ -4521,7 +4521,7 @@ int sh_audit_l4_table(struct vcpu *v, mfn_t sl4mfn, mfn_t x) mfn_t mfn, gmfn, gl4mfn; gfn_t gfn; p2m_type_t p2mt; - char *s; + const char *s; int done = 0; /* Follow the backpointer */ -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Apr 05 15:57:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Apr 2021 15:57:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105398.201784 (Exim 4.92) (envelope-from ) id 1lTRbS-0002Gm-Vj; Mon, 05 Apr 2021 15:57:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105398.201784; Mon, 05 Apr 2021 15:57:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRbS-0002GD-Pd; Mon, 05 Apr 2021 15:57:26 +0000 Received: by outflank-mailman (input) for mailman id 105398; Mon, 05 Apr 2021 15:57:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRbR-0002D6-ES for xen-devel@lists.xenproject.org; Mon, 05 Apr 2021 15:57:25 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRbQ-0002o2-JW; Mon, 05 Apr 2021 15:57:24 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTRbQ-00053b-B0; Mon, 05 Apr 2021 15:57:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=UP5LznC0lJpah31eRGW2Mg+D4mlUlr8pP6zrBCltxpg=; b=fKxVMUNl5gG7H5iOYrMWGq7B/ 4p1nXE90RFkkuduYWN53HB64IKH3pa5RMwTXxDTvi1CUAIJI2YKX22vcUSR5YKlWhBSGMgi5rFup0 9yKFSloAfysJdwIXEO4F1qE29cF1ODgxDWlpwNnia2kgV1mV3qiiwtwcwRx5t4TsEmLBc=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Ian Jackson , Wei Liu Subject: [PATCH 05/14] tools/libs: guest: Use const whenever we point to literal strings Date: Mon, 5 Apr 2021 16:57:04 +0100 Message-Id: <20210405155713.29754-6-julien@xen.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210405155713.29754-1-julien@xen.org> References: <20210405155713.29754-1-julien@xen.org> From: Julien Grall literal strings are not meant to be modified. So we should use const *char rather than char * when we want to store a pointer to them. Signed-off-by: Julien Grall --- tools/include/xenguest.h | 10 +++++----- tools/libs/guest/xg_dom_core.c | 8 ++++---- tools/libs/guest/xg_dom_elfloader.c | 4 ++-- tools/libs/guest/xg_dom_hvmloader.c | 2 +- tools/libs/guest/xg_dom_x86.c | 9 +++++---- tools/libs/guest/xg_private.h | 2 +- 6 files changed, 18 insertions(+), 17 deletions(-) diff --git a/tools/include/xenguest.h b/tools/include/xenguest.h index 217022b6e767..a4492038cf3a 100644 --- a/tools/include/xenguest.h +++ b/tools/include/xenguest.h @@ -108,7 +108,7 @@ struct xc_dom_image { /* info from (elf) kernel image */ struct elf_dom_parms *parms; - char *guest_type; + const char *guest_type; /* memory layout */ struct xc_dom_seg kernel_seg; @@ -266,8 +266,8 @@ struct xc_dom_arch { /* arch-specific memory initialization. */ int (*meminit) (struct xc_dom_image * dom); - char *guest_type; - char *native_protocol; + const char *guest_type; + const char *native_protocol; int page_shift; int sizeof_pfn; int p2m_base_supported; @@ -374,9 +374,9 @@ char *xc_dom_strdup(struct xc_dom_image *dom, const char *str); /* --- alloc memory pool ------------------------------------------- */ -xen_pfn_t xc_dom_alloc_page(struct xc_dom_image *dom, char *name); +xen_pfn_t xc_dom_alloc_page(struct xc_dom_image *dom, const char *name); int xc_dom_alloc_segment(struct xc_dom_image *dom, - struct xc_dom_seg *seg, char *name, + struct xc_dom_seg *seg, const char *name, xen_vaddr_t start, xen_vaddr_t size); /* --- misc bits --------------------------------------------------- */ diff --git a/tools/libs/guest/xg_dom_core.c b/tools/libs/guest/xg_dom_core.c index 98ef8e8fc9ca..4918ee517bdd 100644 --- a/tools/libs/guest/xg_dom_core.c +++ b/tools/libs/guest/xg_dom_core.c @@ -422,7 +422,7 @@ void *xc_dom_pfn_to_ptr_retcount(struct xc_dom_image *dom, xen_pfn_t pfn, struct xc_dom_phys *phys; xen_pfn_t offset; unsigned int page_shift = XC_DOM_PAGE_SHIFT(dom); - char *mode = "unset"; + const char *mode = "unset"; *count_out = 0; @@ -525,7 +525,7 @@ void *xc_dom_pfn_to_ptr_retcount(struct xc_dom_image *dom, xen_pfn_t pfn, return phys->ptr; } -static int xc_dom_chk_alloc_pages(struct xc_dom_image *dom, char *name, +static int xc_dom_chk_alloc_pages(struct xc_dom_image *dom, const char *name, xen_pfn_t pages) { unsigned int page_size = XC_DOM_PAGE_SIZE(dom); @@ -576,7 +576,7 @@ static int xc_dom_alloc_pad(struct xc_dom_image *dom, xen_vaddr_t boundary) } int xc_dom_alloc_segment(struct xc_dom_image *dom, - struct xc_dom_seg *seg, char *name, + struct xc_dom_seg *seg, const char *name, xen_vaddr_t start, xen_vaddr_t size) { unsigned int page_size = XC_DOM_PAGE_SIZE(dom); @@ -611,7 +611,7 @@ int xc_dom_alloc_segment(struct xc_dom_image *dom, return 0; } -xen_pfn_t xc_dom_alloc_page(struct xc_dom_image *dom, char *name) +xen_pfn_t xc_dom_alloc_page(struct xc_dom_image *dom, const char *name) { xen_vaddr_t start; xen_pfn_t pfn; diff --git a/tools/libs/guest/xg_dom_elfloader.c b/tools/libs/guest/xg_dom_elfloader.c index 06e713fe1119..0d6247db5d08 100644 --- a/tools/libs/guest/xg_dom_elfloader.c +++ b/tools/libs/guest/xg_dom_elfloader.c @@ -50,8 +50,8 @@ void xc_elf_set_logfile(xc_interface *xch, struct elf_binary *elf, /* ------------------------------------------------------------------------ */ -static char *xc_dom_guest_type(struct xc_dom_image *dom, - struct elf_binary *elf) +static const char *xc_dom_guest_type(struct xc_dom_image *dom, + struct elf_binary *elf) { uint64_t machine = elf_uval(elf, elf->ehdr, e_machine); diff --git a/tools/libs/guest/xg_dom_hvmloader.c b/tools/libs/guest/xg_dom_hvmloader.c index ec6ebad7fd52..4e6f30858a59 100644 --- a/tools/libs/guest/xg_dom_hvmloader.c +++ b/tools/libs/guest/xg_dom_hvmloader.c @@ -130,7 +130,7 @@ static elf_errorstatus xc_dom_parse_hvm_kernel(struct xc_dom_image *dom) static int module_init_one(struct xc_dom_image *dom, struct xc_hvm_firmware_module *module, - char *name) + const char *name) { struct xc_dom_seg seg; void *dest; diff --git a/tools/libs/guest/xg_dom_x86.c b/tools/libs/guest/xg_dom_x86.c index 2953aeb90b35..e379b07f9945 100644 --- a/tools/libs/guest/xg_dom_x86.c +++ b/tools/libs/guest/xg_dom_x86.c @@ -1148,11 +1148,12 @@ static int vcpu_hvm(struct xc_dom_image *dom) /* ------------------------------------------------------------------------ */ -static int x86_compat(xc_interface *xch, uint32_t domid, char *guest_type) +static int x86_compat(xc_interface *xch, uint32_t domid, + const char *guest_type) { static const struct { - char *guest; - uint32_t size; + const char *guest; + uint32_t size; } types[] = { { "xen-3.0-x86_32p", 32 }, { "xen-3.0-x86_64", 64 }, @@ -1664,7 +1665,7 @@ static int bootearly(struct xc_dom_image *dom) static int bootlate_pv(struct xc_dom_image *dom) { static const struct { - char *guest; + const char *guest; unsigned long pgd_type; } types[] = { { "xen-3.0-x86_32", MMUEXT_PIN_L2_TABLE}, diff --git a/tools/libs/guest/xg_private.h b/tools/libs/guest/xg_private.h index 8f9b257a2f3d..25e46d7ce195 100644 --- a/tools/libs/guest/xg_private.h +++ b/tools/libs/guest/xg_private.h @@ -43,7 +43,7 @@ #endif struct xc_dom_loader { - char *name; + const char *name; /* Sadly the error returns from these functions are not consistent: */ elf_negerrnoval (*probe) (struct xc_dom_image * dom); elf_negerrnoval (*parser) (struct xc_dom_image * dom); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Apr 05 15:57:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Apr 2021 15:57:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105399.201797 (Exim 4.92) (envelope-from ) id 1lTRbU-0002Jr-Cr; Mon, 05 Apr 2021 15:57:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105399.201797; Mon, 05 Apr 2021 15:57:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRbU-0002Jg-8S; Mon, 05 Apr 2021 15:57:28 +0000 Received: by outflank-mailman (input) for mailman id 105399; Mon, 05 Apr 2021 15:57:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRbS-0002FR-Em for xen-devel@lists.xenproject.org; Mon, 05 Apr 2021 15:57:26 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRbR-0002oD-LU; Mon, 05 Apr 2021 15:57:25 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTRbR-00053b-BX; Mon, 05 Apr 2021 15:57:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=KksYVhRFyICjFP1ckAs027N7azKI8dI/+aHOnCC8ZNM=; b=MD7lFwzB7Qwcvo0bxHk/cU5DD RDZ8pugfP5wNpM9iE+LoFxmAAi2+x82jDVBUktTbN6r6/v2vcj9yuZjWSYgpW2W0xRNfbj9t7DzP0 nQzHyJ7I6AWMzbE+8yGh9lZhyWHM+s2kJjj+joi1uiclMGvy7Yvo8TBfIv8mrZULTD6KY=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Ian Jackson , Wei Liu Subject: [PATCH 06/14] tools/libs: stat: Use const whenever we point to literal strings Date: Mon, 5 Apr 2021 16:57:05 +0100 Message-Id: <20210405155713.29754-7-julien@xen.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210405155713.29754-1-julien@xen.org> References: <20210405155713.29754-1-julien@xen.org> From: Julien Grall literal strings are not meant to be modified. So we should use const char * rather than char * when we want to store a pointer to them. Signed-off-by: Julien Grall --- tools/libs/stat/xenstat_linux.c | 4 ++-- tools/libs/stat/xenstat_qmp.c | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/tools/libs/stat/xenstat_linux.c b/tools/libs/stat/xenstat_linux.c index c00b26d4d898..875a0617ade8 100644 --- a/tools/libs/stat/xenstat_linux.c +++ b/tools/libs/stat/xenstat_linux.c @@ -66,7 +66,7 @@ static const char PROCNETDEV_HEADER[] = /* We need to get the name of the bridge interface for use with bonding interfaces */ /* Use excludeName parameter to avoid adding bridges we don't care about, eg. virbr0 */ -static void getBridge(char *excludeName, char *result, size_t resultLen) +static void getBridge(const char *excludeName, char *result, size_t resultLen) { struct dirent *de; DIR *d; @@ -113,7 +113,7 @@ static int parseNetDevLine(char *line, char *iface, unsigned long long *rxBytes, int num = 19; /* Regular exception to parse all the information from /proc/net/dev line */ - char *regex = "([^:]*):([^ ]*)[ ]*([^ ]*)[ ]*([^ ]*)[ ]*([^ ]*)[ ]*([^ ]*)[ ]*([^ ]*)" + const char *regex = "([^:]*):([^ ]*)[ ]*([^ ]*)[ ]*([^ ]*)[ ]*([^ ]*)[ ]*([^ ]*)[ ]*([^ ]*)" "[ ]*([^ ]*)[ ]*([^ ]*)[ ]*([^ ]*)[ ]*([^ ]*)[ ]*([^ ]*)[ ]*([^ ]*)[ ]*" "([^ ]*)[ ]*([^ ]*)[ ]*([^ ]*)[ ]*([^ ]*)[ ]*([^ ]*)"; diff --git a/tools/libs/stat/xenstat_qmp.c b/tools/libs/stat/xenstat_qmp.c index 0c5748ba68b3..2205a041313b 100644 --- a/tools/libs/stat/xenstat_qmp.c +++ b/tools/libs/stat/xenstat_qmp.c @@ -38,7 +38,7 @@ #include -static unsigned char *qmp_query(int, char *); +static unsigned char *qmp_query(int, const char *); enum query_blockstats { QMP_STATS_RETURN = 0, @@ -80,7 +80,7 @@ enum query_block { static char *qmp_get_block_image(xenstat_node *node, char *qmp_devname, int qfd) { char *tmp, *file = NULL; - char *query_block_cmd = "{ \"execute\": \"query-block\" }"; + const char *query_block_cmd = "{ \"execute\": \"query-block\" }"; static const char *const qblock[] = { [ QMP_BLOCK_RETURN ] = "return", [ QMP_BLOCK_DEVICE ] = "device", @@ -264,7 +264,7 @@ done: } /* Write a command via the QMP. Returns number of bytes written */ -static size_t qmp_write(int qfd, char *cmd, size_t cmd_len) +static size_t qmp_write(int qfd, const char *cmd, size_t cmd_len) { size_t pos = 0; ssize_t res; @@ -317,7 +317,7 @@ static int qmp_read(int qfd, unsigned char **qstats) } /* With the given cmd, query QMP for requested data. Returns allocated buffer containing data or NULL */ -static unsigned char *qmp_query(int qfd, char *cmd) +static unsigned char *qmp_query(int qfd, const char *cmd) { unsigned char *qstats = NULL; int n; @@ -385,8 +385,8 @@ static int qmp_connect(char *path) */ static void read_attributes_qdisk_dom(xenstat_node *node, domid_t domain) { - char *cmd_mode = "{ \"execute\": \"qmp_capabilities\" }"; - char *query_blockstats_cmd = "{ \"execute\": \"query-blockstats\" }"; + const char *cmd_mode = "{ \"execute\": \"qmp_capabilities\" }"; + const char *query_blockstats_cmd = "{ \"execute\": \"query-blockstats\" }"; unsigned char *qmp_stats, *val; char path[80]; int qfd; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Apr 05 15:57:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Apr 2021 15:57:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105400.201803 (Exim 4.92) (envelope-from ) id 1lTRbV-0002LF-09; Mon, 05 Apr 2021 15:57:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105400.201803; Mon, 05 Apr 2021 15:57:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRbU-0002Kq-MN; Mon, 05 Apr 2021 15:57:28 +0000 Received: by outflank-mailman (input) for mailman id 105400; Mon, 05 Apr 2021 15:57:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRbT-0002Hp-Ab for xen-devel@lists.xenproject.org; Mon, 05 Apr 2021 15:57:27 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRbS-0002oL-Nz; Mon, 05 Apr 2021 15:57:26 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTRbS-00053b-Fh; Mon, 05 Apr 2021 15:57:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=fSnIgvoSjbUt91Rc+3WKbTs8Y6JmyyNkB+9IjjcALAg=; b=49TpKmuxcFkNIHf0NZn/D91QM liDzLY1pqQul9K2C/SIHFl+oM8o+pki3Cl4fUQm2psyk8/+nCbY6jUqjIBBEBzoI4Zap7OFnIWMr5 UKWnKZ9aH40D6z1jqY5HMTS537E5FENgqwyZiQgXenW3kkRonsxeLecm88Ks4xK7sd1Fk=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Ian Jackson , Wei Liu , Anthony PERARD Subject: [PATCH 07/14] tools/xl: Use const whenever we point to literal strings Date: Mon, 5 Apr 2021 16:57:06 +0100 Message-Id: <20210405155713.29754-8-julien@xen.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210405155713.29754-1-julien@xen.org> References: <20210405155713.29754-1-julien@xen.org> From: Julien Grall literal strings are not meant to be modified. So we should use const char * rather than char * when we want to store a pointer to them. Signed-off-by: Julien Grall --- tools/xl/xl.h | 8 ++++---- tools/xl/xl_console.c | 2 +- tools/xl/xl_utils.c | 4 ++-- tools/xl/xl_utils.h | 4 ++-- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/tools/xl/xl.h b/tools/xl/xl.h index 137a29077c1e..3052e3db0072 100644 --- a/tools/xl/xl.h +++ b/tools/xl/xl.h @@ -21,13 +21,13 @@ #include struct cmd_spec { - char *cmd_name; + const char *cmd_name; int (*cmd_impl)(int argc, char **argv); int can_dryrun; int modifies; - char *cmd_desc; - char *cmd_usage; - char *cmd_option; + const char *cmd_desc; + const char *cmd_usage; + const char *cmd_option; }; struct domain_create { diff --git a/tools/xl/xl_console.c b/tools/xl/xl_console.c index 4e65d7386733..b27f9e013697 100644 --- a/tools/xl/xl_console.c +++ b/tools/xl/xl_console.c @@ -27,7 +27,7 @@ int main_console(int argc, char **argv) uint32_t domid; int opt = 0, num = 0; libxl_console_type type = 0; - char *console_names = "pv, serial, vuart"; + const char *console_names = "pv, serial, vuart"; SWITCH_FOREACH_OPT(opt, "n:t:", NULL, "console", 1) { case 't': diff --git a/tools/xl/xl_utils.c b/tools/xl/xl_utils.c index 4503ac7ea03c..17489d182954 100644 --- a/tools/xl/xl_utils.c +++ b/tools/xl/xl_utils.c @@ -27,7 +27,7 @@ #include "xl.h" #include "xl_utils.h" -void dolog(const char *file, int line, const char *func, char *fmt, ...) +void dolog(const char *file, int line, const char *func, const char *fmt, ...) { va_list ap; char *s = NULL; @@ -248,7 +248,7 @@ void print_bitmap(uint8_t *map, int maplen, FILE *stream) } } -int do_daemonize(char *name, const char *pidfile) +int do_daemonize(const char *name, const char *pidfile) { char *fullname; pid_t child1; diff --git a/tools/xl/xl_utils.h b/tools/xl/xl_utils.h index d98b419f1075..0c337ede954b 100644 --- a/tools/xl/xl_utils.h +++ b/tools/xl/xl_utils.h @@ -123,7 +123,7 @@ int def_getopt(int argc, char * const argv[], const struct option *longopts, const char* helpstr, int reqargs); -void dolog(const char *file, int line, const char *func, char *fmt, ...) +void dolog(const char *file, int line, const char *func, const char *fmt, ...) __attribute__((format(printf,4,5))); void xvasprintf(char **strp, const char *fmt, va_list ap) @@ -143,7 +143,7 @@ uint32_t find_domain(const char *p) __attribute__((warn_unused_result)); void print_bitmap(uint8_t *map, int maplen, FILE *stream); -int do_daemonize(char *name, const char *pidfile); +int do_daemonize(const char *name, const char *pidfile); #endif /* XL_UTILS_H */ /* -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Apr 05 15:57:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Apr 2021 15:57:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105401.201821 (Exim 4.92) (envelope-from ) id 1lTRbX-0002S9-MZ; Mon, 05 Apr 2021 15:57:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105401.201821; Mon, 05 Apr 2021 15:57:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRbX-0002Rn-GV; Mon, 05 Apr 2021 15:57:31 +0000 Received: by outflank-mailman (input) for mailman id 105401; Mon, 05 Apr 2021 15:57:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRbU-0002LQ-RY for xen-devel@lists.xenproject.org; Mon, 05 Apr 2021 15:57:28 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRbU-0002oS-3D; Mon, 05 Apr 2021 15:57:28 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTRbT-00053b-RA; Mon, 05 Apr 2021 15:57:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=lyhRqrnLbAOU2YP7TBUMqJqT/uwbvMLMSBzL3B6aYDM=; b=3Gr5r9LZKz7autrB/fEbv7nk4 Ly3bxyt5lzdn97NLfjISrWngoQbegaXsde6Lwr3CrIngHV7M9hPpwSlT3WDkIRs7LsBNZ5GJCJlKG /dNxd9cj8TTaG/oNE7j4QlTNDneyiXVGPBsqpVmSar+7k68jy6uvQS9gzHYz79qx6eaRg=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Ian Jackson Subject: [PATCH 08/14] tools/firmware: hvmloader: Use const in __bug() and __assert_failed() Date: Mon, 5 Apr 2021 16:57:07 +0100 Message-Id: <20210405155713.29754-9-julien@xen.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210405155713.29754-1-julien@xen.org> References: <20210405155713.29754-1-julien@xen.org> From: Julien Grall __bug() and __assert_failed() are not meant to modify the string parameters. So mark them as const. Signed-off-by: Julien Grall --- tools/firmware/hvmloader/util.c | 4 ++-- tools/firmware/hvmloader/util.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/firmware/hvmloader/util.c b/tools/firmware/hvmloader/util.c index 7da144b0bb15..581b35e5cfb5 100644 --- a/tools/firmware/hvmloader/util.c +++ b/tools/firmware/hvmloader/util.c @@ -722,14 +722,14 @@ static void __attribute__((noreturn)) crash(void) asm volatile ( "hlt" ); } -void __assert_failed(char *assertion, char *file, int line) +void __assert_failed(const char *assertion, const char *file, int line) { printf("*** HVMLoader assertion '%s' failed at %s:%d\n", assertion, file, line); crash(); } -void __bug(char *file, int line) +void __bug(const char *file, int line) { printf("*** HVMLoader bug at %s:%d\n", file, line); crash(); diff --git a/tools/firmware/hvmloader/util.h b/tools/firmware/hvmloader/util.h index 4f0baade0e6c..8d95eab28a65 100644 --- a/tools/firmware/hvmloader/util.h +++ b/tools/firmware/hvmloader/util.h @@ -34,11 +34,11 @@ enum { #undef NULL #define NULL ((void*)0) -void __assert_failed(char *assertion, char *file, int line) +void __assert_failed(const char *assertion, const char *file, int line) __attribute__((noreturn)); #define ASSERT(p) \ do { if (!(p)) __assert_failed(#p, __FILE__, __LINE__); } while (0) -void __bug(char *file, int line) __attribute__((noreturn)); +void __bug(const char *file, int line) __attribute__((noreturn)); #define BUG() __bug(__FILE__, __LINE__) #define BUG_ON(p) do { if (p) BUG(); } while (0) #define BUILD_BUG_ON(p) ((void)sizeof(char[1 - 2 * !!(p)])) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Apr 05 15:57:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Apr 2021 15:57:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105402.201829 (Exim 4.92) (envelope-from ) id 1lTRbY-0002TX-IF; Mon, 05 Apr 2021 15:57:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105402.201829; Mon, 05 Apr 2021 15:57:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRbY-0002T5-0E; Mon, 05 Apr 2021 15:57:32 +0000 Received: by outflank-mailman (input) for mailman id 105402; Mon, 05 Apr 2021 15:57:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRbV-0002OA-Qm for xen-devel@lists.xenproject.org; Mon, 05 Apr 2021 15:57:29 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRbV-0002oY-3V; Mon, 05 Apr 2021 15:57:29 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTRbU-00053b-RZ; Mon, 05 Apr 2021 15:57:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=UgMhryuGQDNF+IkibD7yNt0PjYxYcwu1lo/PGDlCLKY=; b=bK51hyrcTT4viBqIAN1cWJGfC wDeFEzPJc59SCRpH4goiKY8qLNzgak/3/yWAPp2fjlQ9lW7KuFNoY4jzspPaP1t6GwB6rUSdOvqpg Owg7mfSgH7KOQZAOK0O0XUR62ee/usQYpI9yOoglRBSfzkeKH1Y0WXik9zTTeH6PVtzaY=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Ian Jackson , Wei Liu Subject: [PATCH 09/14] tools/console: Use const whenever we point to literal strings Date: Mon, 5 Apr 2021 16:57:08 +0100 Message-Id: <20210405155713.29754-10-julien@xen.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210405155713.29754-1-julien@xen.org> References: <20210405155713.29754-1-julien@xen.org> From: Julien Grall literal strings are not meant to be modified. So we should use const char * rather than char * when we want to store a pointer to them. Signed-off-by: Julien Grall --- tools/console/client/main.c | 4 ++-- tools/console/daemon/io.c | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/tools/console/client/main.c b/tools/console/client/main.c index 088be28dff02..80157be42144 100644 --- a/tools/console/client/main.c +++ b/tools/console/client/main.c @@ -325,7 +325,7 @@ int main(int argc, char **argv) { struct termios attr; int domid; - char *sopt = "hn:"; + const char *sopt = "hn:"; int ch; unsigned int num = 0; int opt_ind=0; @@ -345,7 +345,7 @@ int main(int argc, char **argv) char *end; console_type type = CONSOLE_INVAL; bool interactive = 0; - char *console_names = "serial, pv, vuart"; + const char *console_names = "serial, pv, vuart"; while((ch = getopt_long(argc, argv, sopt, lopt, &opt_ind)) != -1) { switch(ch) { diff --git a/tools/console/daemon/io.c b/tools/console/daemon/io.c index 4af27ffc5d02..6a8a94e31b65 100644 --- a/tools/console/daemon/io.c +++ b/tools/console/daemon/io.c @@ -87,14 +87,14 @@ struct buffer { }; struct console { - char *ttyname; + const char *ttyname; int master_fd; int master_pollfd_idx; int slave_fd; int log_fd; struct buffer buffer; char *xspath; - char *log_suffix; + const char *log_suffix; int ring_ref; xenevtchn_handle *xce_handle; int xce_pollfd_idx; @@ -109,9 +109,9 @@ struct console { }; struct console_type { - char *xsname; - char *ttyname; - char *log_suffix; + const char *xsname; + const char *ttyname; + const char *log_suffix; bool optional; bool use_gnttab; }; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Apr 05 16:14:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Apr 2021 16:14:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105452.201851 (Exim 4.92) (envelope-from ) id 1lTRsA-0005V5-Ct; Mon, 05 Apr 2021 16:14:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105452.201851; Mon, 05 Apr 2021 16:14:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRsA-0005Uu-6H; Mon, 05 Apr 2021 16:14:42 +0000 Received: by outflank-mailman (input) for mailman id 105452; Mon, 05 Apr 2021 16:14:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRs7-0005U6-PK for xen-devel@lists.xenproject.org; Mon, 05 Apr 2021 16:14:39 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRs6-0003eu-H5; Mon, 05 Apr 2021 16:14:38 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTRbW-00053b-W8; Mon, 05 Apr 2021 15:57:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=fOozlpcQqX3U35FdV5utWkSVhrMD0HRaxwSjYqjDLQU=; b=s3UuLNW5J0CRb7QQWuy3WCObx 9Gdg6FRWFWbkIYxzFKoZOv2val092fE4cOQzcRm4YVQZ31kwcWJ3NT60CRP2B9jujZTo3yvvEONJz 7FInxspUOxEYrqmX/FCyAO/5RTJMMjSXJx9QixNpURGdf4BHNYESij6Ke2nVKGjrv2FC4=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Ian Jackson , Wei Liu Subject: [PATCH 11/14] tools/misc: Use const whenever we point to literal strings Date: Mon, 5 Apr 2021 16:57:10 +0100 Message-Id: <20210405155713.29754-12-julien@xen.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210405155713.29754-1-julien@xen.org> References: <20210405155713.29754-1-julien@xen.org> From: Julien Grall literal strings are not meant to be modified. So we should use const char * rather than char * when we we to store a pointer to them. Signed-off-by: Julien Grall --- tools/misc/xen-detect.c | 2 +- tools/misc/xenhypfs.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/misc/xen-detect.c b/tools/misc/xen-detect.c index eac9e46a35bb..18b28dabf311 100644 --- a/tools/misc/xen-detect.c +++ b/tools/misc/xen-detect.c @@ -44,7 +44,7 @@ enum guest_type { XEN_NONE = 3 }; -static char *type; +static const char *type; static char *ver; static void cpuid(uint32_t idx, uint32_t *regs, int pv_context) diff --git a/tools/misc/xenhypfs.c b/tools/misc/xenhypfs.c index 5da24aed905c..df398b07bdc0 100644 --- a/tools/misc/xenhypfs.c +++ b/tools/misc/xenhypfs.c @@ -81,9 +81,9 @@ static int xenhypfs_wr(char *path, char *val) return ret; } -static char *xenhypfs_type(struct xenhypfs_dirent *ent) +static const char *xenhypfs_type(struct xenhypfs_dirent *ent) { - char *res; + const char *res; switch (ent->type) { case xenhypfs_type_dir: @@ -134,7 +134,7 @@ static int xenhypfs_ls(char *path) return ret; } -static int xenhypfs_tree_sub(char *path, unsigned int depth) +static int xenhypfs_tree_sub(const char *path, unsigned int depth) { struct xenhypfs_dirent *ent; unsigned int n, i; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Apr 05 16:14:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Apr 2021 16:14:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105453.201861 (Exim 4.92) (envelope-from ) id 1lTRsA-0005Vl-Nb; Mon, 05 Apr 2021 16:14:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105453.201861; Mon, 05 Apr 2021 16:14:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRsA-0005VW-G5; Mon, 05 Apr 2021 16:14:42 +0000 Received: by outflank-mailman (input) for mailman id 105453; Mon, 05 Apr 2021 16:14:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRs7-0005U5-PK for xen-devel@lists.xenproject.org; Mon, 05 Apr 2021 16:14:39 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRs6-0003f0-O5; Mon, 05 Apr 2021 16:14:38 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTRbY-00053b-0I; Mon, 05 Apr 2021 15:57:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=1rVbgSKi2I81qCiY+TmphdtF7pMSqnTa8m6g9BTXjUI=; b=QZuh8HPVEcn1Kzdt/lFtkO/nW RtCGPYMVw2cVNrH0epDwZ5Eo55VeWcPPnYZT8x4dAa7KnvS6EKNMGh53IcV1wAp0/Y2tMhN95jMbC tD7vY3/eGnfiQp7Tuz+9FF1nTVSjCvFIfTP0BR/89L2N12L2cY/ZBBtCMBXG2pWY291NI=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Ian Jackson , Wei Liu Subject: [PATCH 12/14] tools/top: The string parameter in set_prompt() and set_delay() should be const Date: Mon, 5 Apr 2021 16:57:11 +0100 Message-Id: <20210405155713.29754-13-julien@xen.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210405155713.29754-1-julien@xen.org> References: <20210405155713.29754-1-julien@xen.org> From: Julien Grall Neither string parameter in set_prompt() and set_delay() are meant to be modified. In particular, new_prompt can point to a literal string. So mark the two parameters as const and propagate it. Signed-off-by: Julien Grall --- tools/xentop/xentop.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/xentop/xentop.c b/tools/xentop/xentop.c index ebed070c0fa2..950e8935c4c1 100644 --- a/tools/xentop/xentop.c +++ b/tools/xentop/xentop.c @@ -81,8 +81,8 @@ static int current_row(void); static int lines(void); static void print(const char *, ...) __attribute__((format(printf,1,2))); static void attr_addstr(int attr, const char *str); -static void set_delay(char *value); -static void set_prompt(char *new_prompt, void (*func)(char *)); +static void set_delay(const char *value); +static void set_prompt(const char *new_prompt, void (*func)(const char *)); static int handle_key(int); static int compare(unsigned long long, unsigned long long); static int compare_domains(xenstat_domain **, xenstat_domain **); @@ -212,10 +212,10 @@ int show_vbds = 0; int repeat_header = 0; int show_full_name = 0; #define PROMPT_VAL_LEN 80 -char *prompt = NULL; +const char *prompt = NULL; char prompt_val[PROMPT_VAL_LEN]; int prompt_val_len = 0; -void (*prompt_complete_func)(char *); +void (*prompt_complete_func)(const char *); static WINDOW *cwin; @@ -331,7 +331,7 @@ static void attr_addstr(int attr, const char *str) } /* Handle setting the delay from the user-supplied value in prompt_val */ -static void set_delay(char *value) +static void set_delay(const char *value) { int new_delay; new_delay = atoi(value); @@ -341,7 +341,7 @@ static void set_delay(char *value) /* Enable prompting mode with the given prompt string; call the given function * when a value is available. */ -static void set_prompt(char *new_prompt, void (*func)(char *)) +static void set_prompt(const char *new_prompt, void (*func)(const char *)) { prompt = new_prompt; prompt_val[0] = '\0'; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Apr 05 16:14:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Apr 2021 16:14:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105451.201845 (Exim 4.92) (envelope-from ) id 1lTRsA-0005Ua-1o; Mon, 05 Apr 2021 16:14:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105451.201845; Mon, 05 Apr 2021 16:14:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRs9-0005UT-Uf; Mon, 05 Apr 2021 16:14:41 +0000 Received: by outflank-mailman (input) for mailman id 105451; Mon, 05 Apr 2021 16:14:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRs7-0005U4-PK for xen-devel@lists.xenproject.org; Mon, 05 Apr 2021 16:14:39 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRs6-0003ey-MJ; Mon, 05 Apr 2021 16:14:38 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTRbZ-00053b-0i; Mon, 05 Apr 2021 15:57:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=Gq4ESA+bbIOEoTSTMGcB7GGXPzKwaa55TZ5zrqKmigw=; b=kW8nFemdtlQUkKpZjaUYbvq/a mF1OLiI2f3BLuq+h3OaS05P4bbOnfGec/wzj6vAAaKTQ8WQg+62jP5LCSAxuheympoBsBRDPSVO8d RXGq2eHcME2KHZkSmUjGjf73rw1dIaZOBLGWbmwZ6X62LwsvgixCuTfLRmZxxrZzcLEXc=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Ian Jackson , Wei Liu Subject: [PATCH 13/14] tools/xenmon: xenbaked: Mark const the field text in stat_map_t Date: Mon, 5 Apr 2021 16:57:12 +0100 Message-Id: <20210405155713.29754-14-julien@xen.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210405155713.29754-1-julien@xen.org> References: <20210405155713.29754-1-julien@xen.org> From: Julien Grall The field text in stat_map_t will point to string literals. So mark it as const to allow the compiler to catch any modified of the string. Signed-off-by: Julien Grall --- tools/xenmon/xenbaked.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/xenmon/xenbaked.c b/tools/xenmon/xenbaked.c index d3f940a26bb2..1ed34334c824 100644 --- a/tools/xenmon/xenbaked.c +++ b/tools/xenmon/xenbaked.c @@ -182,7 +182,7 @@ typedef struct { int event_count; int event_id; - char *text; + const char *text; } stat_map_t; stat_map_t stat_map[] = { -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Apr 05 16:14:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Apr 2021 16:14:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105454.201873 (Exim 4.92) (envelope-from ) id 1lTRsB-0005WT-4d; Mon, 05 Apr 2021 16:14:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105454.201873; Mon, 05 Apr 2021 16:14:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRsA-0005WD-PM; Mon, 05 Apr 2021 16:14:42 +0000 Received: by outflank-mailman (input) for mailman id 105454; Mon, 05 Apr 2021 16:14:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRs7-0005U7-PX for xen-devel@lists.xenproject.org; Mon, 05 Apr 2021 16:14:39 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRs6-0003es-Eb; Mon, 05 Apr 2021 16:14:38 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTRba-00053b-4i; Mon, 05 Apr 2021 15:57:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=YW9oGuy3t6k1yVdYEyjW8Earg8hRQJeA+vjl3JWhoBo=; b=ajbC8nh8c9j/DoiYvRFOnAVoe O5EupfUULfhonKEdYyMbDWJW/YSBR5etebR61NKpX1W+xrnE1gbqV/zuTC1wffKx5CGN53f9JBpV4 XKdytp7Mle026VbMKzLKx2n3NAbieCtndaGdNZIp3fN007vIWM4Vl7HxngnhmUC7On9v8=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , George Dunlap , Ian Jackson , Wei Liu Subject: [PATCH 14/14] tools/xentrace: Use const whenever we point to literal strings Date: Mon, 5 Apr 2021 16:57:13 +0100 Message-Id: <20210405155713.29754-15-julien@xen.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210405155713.29754-1-julien@xen.org> References: <20210405155713.29754-1-julien@xen.org> From: Julien Grall literal strings are not meant to be modified. So we should use const char * rather than char * when we want to store a pointer to them. Signed-off-by: Julien Grall --- tools/xentrace/xenalyze.c | 71 ++++++++++++++++++++------------------- tools/xentrace/xenctx.c | 4 +-- 2 files changed, 39 insertions(+), 36 deletions(-) diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c index b7f4e2bea83d..5de167031e01 100644 --- a/tools/xentrace/xenalyze.c +++ b/tools/xentrace/xenalyze.c @@ -356,7 +356,7 @@ void parse_symbol_file(char *fn) { char * find_symbol(unsigned long long addr) { struct symbol_struct * p=G.symbols; int i; - char * lastname="ZERO"; + const char * lastname="ZERO"; unsigned long long offset=addr; static char name[144]; @@ -495,7 +495,7 @@ struct { #define HVM_VMX_EXIT_REASON_MAX (EXIT_REASON_XSETBV+1) -char * hvm_vmx_exit_reason_name[HVM_VMX_EXIT_REASON_MAX] = { +const char * hvm_vmx_exit_reason_name[HVM_VMX_EXIT_REASON_MAX] = { [EXIT_REASON_EXCEPTION_NMI]="EXCEPTION_NMI", [EXIT_REASON_EXTERNAL_INTERRUPT]="EXTERNAL_INTERRUPT", [EXIT_REASON_TRIPLE_FAULT]="TRIPLE_FAULT", @@ -698,7 +698,7 @@ enum VMEXIT_EXITCODE }; #define HVM_SVM_EXIT_REASON_MAX 1025 -char * hvm_svm_exit_reason_name[HVM_SVM_EXIT_REASON_MAX] = { +const char * hvm_svm_exit_reason_name[HVM_SVM_EXIT_REASON_MAX] = { /* 0-15 */ "VMEXIT_CR0_READ", "VMEXIT_CR1_READ", @@ -875,7 +875,7 @@ char * hvm_svm_exit_reason_name[HVM_SVM_EXIT_REASON_MAX] = { #define EXTERNAL_INTERRUPT_MAX 256 /* Stringify numbers */ -char * hvm_extint_vector_name[EXTERNAL_INTERRUPT_MAX] = { +const char * hvm_extint_vector_name[EXTERNAL_INTERRUPT_MAX] = { [SPURIOUS_APIC_VECTOR] = "SPURIOS_APIC", [ERROR_APIC_VECTOR] = "ERROR_APIC", [INVALIDATE_TLB_VECTOR]= "INVALIDATE_TLB", @@ -887,7 +887,7 @@ char * hvm_extint_vector_name[EXTERNAL_INTERRUPT_MAX] = { #define HVM_TRAP_MAX 20 -char * hvm_trap_name[HVM_TRAP_MAX] = { +const char * hvm_trap_name[HVM_TRAP_MAX] = { [0] = "Divide", [1] = "RESERVED", [2] = "NMI", @@ -947,7 +947,7 @@ enum { HVM_EVENT_VLAPIC, HVM_EVENT_HANDLER_MAX }; -char * hvm_event_handler_name[HVM_EVENT_HANDLER_MAX] = { +const char * hvm_event_handler_name[HVM_EVENT_HANDLER_MAX] = { "(no handler)", "pf_xen", "pf_inject", @@ -1001,7 +1001,7 @@ enum { GUEST_INTERRUPT_CASE_MAX, }; -char *guest_interrupt_case_name[] = { +const char *guest_interrupt_case_name[] = { [GUEST_INTERRUPT_CASE_WAKE_TO_HALT_ALONE]="wake to halt alone", /* This interrupt woke, maybe another interrupt before halt */ [GUEST_INTERRUPT_CASE_WAKE_TO_HALT_ANY] ="wake to halt any ", @@ -1009,7 +1009,7 @@ char *guest_interrupt_case_name[] = { [GUEST_INTERRUPT_CASE_INTERRUPT_TO_HALT] ="intr to halt ", }; -char *hvm_vol_name[HVM_VOL_MAX] = { +const char *hvm_vol_name[HVM_VOL_MAX] = { [HVM_VOL_VMENTRY]="vmentry", [HVM_VOL_VMEXIT] ="vmexit", [HVM_VOL_HANDLER]="handler", @@ -1056,7 +1056,7 @@ enum { HYPERCALL_MAX }; -char *hypercall_name[HYPERCALL_MAX] = { +const char *hypercall_name[HYPERCALL_MAX] = { [HYPERCALL_set_trap_table]="set_trap_table", [HYPERCALL_mmu_update]="mmu_update", [HYPERCALL_set_gdt]="set_gdt", @@ -1114,7 +1114,7 @@ enum { PF_XEN_EMUL_MAX, }; -char * pf_xen_emul_name[PF_XEN_EMUL_MAX] = { +const char * pf_xen_emul_name[PF_XEN_EMUL_MAX] = { [PF_XEN_EMUL_LVL_0]="non-linmap", [PF_XEN_EMUL_LVL_1]="linmap l1", [PF_XEN_EMUL_LVL_2]="linmap l2", @@ -1140,7 +1140,7 @@ enum { PF_XEN_NON_EMUL_MAX, }; -char * pf_xen_non_emul_name[PF_XEN_NON_EMUL_MAX] = { +const char * pf_xen_non_emul_name[PF_XEN_NON_EMUL_MAX] = { [PF_XEN_NON_EMUL_VA_USER]="va user", [PF_XEN_NON_EMUL_VA_KERNEL]="va kernel", [PF_XEN_NON_EMUL_EIP_USER]="eip user", @@ -1160,7 +1160,7 @@ enum { PF_XEN_FIXUP_MAX, }; -char * pf_xen_fixup_name[PF_XEN_FIXUP_MAX] = { +const char * pf_xen_fixup_name[PF_XEN_FIXUP_MAX] = { [PF_XEN_FIXUP_PREALLOC_UNPIN] = "unpin", [PF_XEN_FIXUP_PREALLOC_UNHOOK] = "unhook", [PF_XEN_FIXUP_UNSYNC] = "unsync", @@ -1195,7 +1195,7 @@ enum { #define SHADOW_RESYNC_FULL 14 #define SHADOW_RESYNC_ONLY 15 -char * pf_xen_name[PF_XEN_MAX] = { +const char * pf_xen_name[PF_XEN_MAX] = { [PF_XEN_NOT_SHADOW]="propagate", [PF_XEN_FAST_PROPAGATE]="fast propagate", [PF_XEN_FAST_MMIO]="fast mmio", @@ -1304,7 +1304,7 @@ struct hvm_data { struct vcpu_data *v; /* up-pointer */ /* SVM / VMX compatibility. FIXME - should be global */ - char ** exit_reason_name; + const char ** exit_reason_name; int exit_reason_max; struct hvm_summary_handler_node *exit_reason_summary_handler_list[HVM_EXIT_REASON_MAX]; @@ -1408,7 +1408,7 @@ enum { HVM_SHORT_SUMMARY_MAX, }; -char *hvm_short_summary_name[HVM_SHORT_SUMMARY_MAX] = { +const char *hvm_short_summary_name[HVM_SHORT_SUMMARY_MAX] = { [HVM_SHORT_SUMMARY_EMULATE] ="emulate", [HVM_SHORT_SUMMARY_UNSYNC] ="unsync", [HVM_SHORT_SUMMARY_FIXUP] ="fixup", @@ -1478,7 +1478,7 @@ enum { PV_MAX }; -char *pv_name[PV_MAX] = { +const char *pv_name[PV_MAX] = { [PV_HYPERCALL]="hypercall", [PV_TRAP]="trap", [PV_PAGE_FAULT]="page_fault", @@ -1527,7 +1527,7 @@ int runstate_graph[RUNSTATE_MAX] = [RUNSTATE_INIT]=-2, }; -char * runstate_name[RUNSTATE_MAX]={ +const char * runstate_name[RUNSTATE_MAX]={ [RUNSTATE_RUNNING]= "running", [RUNSTATE_RUNNABLE]="runnable", [RUNSTATE_BLOCKED]= "blocked", /* to be blocked */ @@ -1545,7 +1545,7 @@ enum { RUNNABLE_STATE_MAX }; -char * runnable_state_name[RUNNABLE_STATE_MAX]={ +const char * runnable_state_name[RUNNABLE_STATE_MAX]={ [RUNNABLE_STATE_INVALID]="invalid", /* Should never show up */ [RUNNABLE_STATE_WAKE]="wake", [RUNNABLE_STATE_PREEMPT]="preempt", @@ -1565,7 +1565,7 @@ enum { MEM_MAX }; -char *mem_name[MEM_MAX] = { +const char *mem_name[MEM_MAX] = { [MEM_PAGE_GRANT_MAP] = "grant-map", [MEM_PAGE_GRANT_UNMAP] = "grant-unmap", [MEM_PAGE_GRANT_TRANSFER] = "grant-transfer", @@ -1681,7 +1681,7 @@ enum { DOMAIN_RUNSTATE_MAX }; -char * domain_runstate_name[] = { +const char * domain_runstate_name[] = { [DOMAIN_RUNSTATE_BLOCKED]="blocked", [DOMAIN_RUNSTATE_PARTIAL_RUN]="partial run", [DOMAIN_RUNSTATE_FULL_RUN]="full run", @@ -1698,7 +1698,7 @@ enum { POD_RECLAIM_CONTEXT_MAX }; -char * pod_reclaim_context_name[] = { +const char * pod_reclaim_context_name[] = { [POD_RECLAIM_CONTEXT_UNKNOWN]="unknown", [POD_RECLAIM_CONTEXT_FAULT]="fault", [POD_RECLAIM_CONTEXT_BALLOON]="balloon", @@ -1756,7 +1756,7 @@ enum { TOPLEVEL_MAX=TOPLEVEL_HW+1, }; -char * toplevel_name[TOPLEVEL_MAX] = { +const char * toplevel_name[TOPLEVEL_MAX] = { [TOPLEVEL_GEN]="gen", [TOPLEVEL_SCHED]="sched", [TOPLEVEL_DOM0OP]="dom0op", @@ -2263,7 +2263,7 @@ static inline void clear_interval_cycles(struct interval_element *e) { e->instructions = 0; } -static inline void print_cpu_affinity(struct cycle_summary *s, char *p) { +static inline void print_cpu_affinity(struct cycle_summary *s, const char *p) { if(s->count) { long long avg; @@ -2326,7 +2326,8 @@ static inline void print_cycle_percent_summary(struct cycle_summary *s, } } -static inline void print_cycle_summary(struct cycle_summary *s, char *p) { +static inline void print_cycle_summary(struct cycle_summary *s, + const char *p) { if(s->count) { long long avg; @@ -2938,7 +2939,7 @@ void hvm_update_short_summary(struct hvm_data *h, int element) { } void hvm_short_summary(struct hvm_short_summary_struct *hss, - tsc_t total, char *prefix) { + tsc_t total, const char *prefix) { char desc[80]; int i; @@ -3352,7 +3353,7 @@ void hvm_pf_xen_process(struct record_info *ri, struct hvm_data *h) { fprintf(warn, "%s: Strange, postprocess already set\n", __func__); } -char * hvm_vlapic_icr_dest_shorthand_name[4] = { +const char * hvm_vlapic_icr_dest_shorthand_name[4] = { "dest_field", "self", "all-inc", "all-exc" }; @@ -3800,7 +3801,7 @@ void update_io_address(struct io_address ** list, unsigned int pa, int dir, update_cycles(&p->summary[dir], arc_cycles); } -void hvm_io_address_summary(struct io_address *list, char * s) { +void hvm_io_address_summary(struct io_address *list, const char * s) { if(!list) return; @@ -4484,7 +4485,7 @@ void hvm_intr_window_process(struct record_info *ri, struct hvm_data *h) int32_t intr; } *r = (typeof(r))h->d; - char *intsrc_name[] = { + const char *intsrc_name[] = { "none", "pic", "lapic", @@ -4687,14 +4688,15 @@ void hvm_generic_postprocess(struct hvm_data *h) } } -void hvm_generic_dump(struct record_info *ri, char * prefix) +void hvm_generic_dump(struct record_info *ri, const char * prefix) { struct { unsigned vcpu:16, domain:16; unsigned d[4]; } *cr = (typeof(cr))ri->d; - char *evt_string, evt_number[256]; + const char *evt_string; + char evt_number[256]; int i, evt, is_64 = 0; evt = ri->event - TRC_HVM_HANDLER; @@ -6042,10 +6044,11 @@ void shadow_propagate_process(struct record_info *ri, struct hvm_data *h) fprintf(warn, "%s: Strange, postprocess already set\n", __func__); } -void shadow_fault_generic_dump(unsigned int event, uint32_t *d, char *prefix, - char * dump_header) +void shadow_fault_generic_dump(unsigned int event, uint32_t *d, + const char *prefix, const char * dump_header) { - char *evt_string, evt_number[10]; + const char *evt_string; + char evt_number[10]; union shadow_event sevt = { .event = event }; int i; @@ -8643,7 +8646,7 @@ void dump_generic(FILE * f, struct record_info *ri) fprintf(f, " ]\n"); } -void dump_raw(char * s, struct record_info *ri) +void dump_raw(const char * s, struct record_info *ri) { int i; diff --git a/tools/xentrace/xenctx.c b/tools/xentrace/xenctx.c index 2fa864f86723..972f473dbf02 100644 --- a/tools/xentrace/xenctx.c +++ b/tools/xentrace/xenctx.c @@ -302,7 +302,7 @@ static void read_symbol_table(const char *symtab) #if defined(__i386__) || defined(__x86_64__) #define CR0_PE 0x1 -char *flag_values[22][2] = +const char *flag_values[22][2] = {/* clear, set, bit# */ { NULL, "c" }, // 0 Carry { NULL, NULL }, // 1 @@ -334,7 +334,7 @@ static void print_flags(uint64_t flags) printf("\nflags: %08" PRIx64, flags); for (i = 21; i >= 0; i--) { - char *s = flag_values[i][(flags >> i) & 1]; + const char *s = flag_values[i][(flags >> i) & 1]; if (s != NULL) printf(" %s", s); } -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Apr 05 16:14:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Apr 2021 16:14:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105455.201885 (Exim 4.92) (envelope-from ) id 1lTRsB-0005Y0-Nf; Mon, 05 Apr 2021 16:14:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105455.201885; Mon, 05 Apr 2021 16:14:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRsB-0005Xf-E2; Mon, 05 Apr 2021 16:14:43 +0000 Received: by outflank-mailman (input) for mailman id 105455; Mon, 05 Apr 2021 16:14:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRs8-0005UO-TX for xen-devel@lists.xenproject.org; Mon, 05 Apr 2021 16:14:40 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRs6-0003ew-KW; Mon, 05 Apr 2021 16:14:38 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTRbV-00053b-Vi; Mon, 05 Apr 2021 15:57:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=sR7NYKPgQAvYGz7bA4ItKG/zjd8QeLXKq9gu3Bw4Bo0=; b=6Lhk6beOV2W/H6rvRwFqdqbM7 xp78Qoz4oBW2SFdz8d8l3y2Paat0sOf9+y7S1K12LJJE49qqmdANkIOT+xghkfXeTTbEOYkhjGGB5 uAfW2i7iNvKAEdJnXHGnCjneTV67dMcXpnMTecvO+Ok96QJlUL0Mmz6CdHJXKkzFiL3sQ=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Tim Deegan , Ian Jackson , Wei Liu Subject: [PATCH 10/14] tools/kdd: Use const whenever we point to literal strings Date: Mon, 5 Apr 2021 16:57:09 +0100 Message-Id: <20210405155713.29754-11-julien@xen.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210405155713.29754-1-julien@xen.org> References: <20210405155713.29754-1-julien@xen.org> From: Julien Grall literal strings are not meant to be modified. So we should use const char * rather than char * when we want to shore a pointer to them. Signed-off-by: Julien Grall --- tools/debugger/kdd/kdd.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/debugger/kdd/kdd.c b/tools/debugger/kdd/kdd.c index a7d0976ea4a8..17513c26505e 100644 --- a/tools/debugger/kdd/kdd.c +++ b/tools/debugger/kdd/kdd.c @@ -67,7 +67,7 @@ typedef struct { uint32_t build; int w64; int mp; - char *name; + const char *name; uint64_t base; /* KernBase: start looking here */ uint32_t range; /* | and search an area this size */ uint32_t version; /* +-> NtBuildNumber */ @@ -237,7 +237,7 @@ static size_t blocking_write(int fd, const void *buf, size_t count) } /* Dump the contents of a complete serial packet into a log file. */ -static void kdd_log_pkt(kdd_state *s, char *name, kdd_pkt *p) +static void kdd_log_pkt(kdd_state *s, const char *name, kdd_pkt *p) { uint32_t sum = 0; unsigned int i, j; @@ -504,8 +504,8 @@ static int check_os(kdd_state *s) * @return -1 on failure to find the section name * @return 0 on success */ -static int get_pe64_sections(kdd_state *s, uint64_t filebase, char *sectname, - uint64_t *vaddr, uint32_t *vsize) +static int get_pe64_sections(kdd_state *s, uint64_t filebase, + const char *sectname, uint64_t *vaddr, uint32_t *vsize) { uint64_t pe_hdr = 0; uint64_t sect_start = 0; @@ -781,7 +781,7 @@ static void kdd_send_cmd(kdd_state *s, uint32_t subtype, size_t extra) } /* Cause the client to print a string */ -static void kdd_send_string(kdd_state *s, char *fmt, ...) +static void kdd_send_string(kdd_state *s, const char *fmt, ...) { uint32_t len = 0xffff - sizeof (kdd_msg); char *buf = (char *) s->txb + sizeof (kdd_hdr) + sizeof (kdd_msg); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Apr 05 16:20:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Apr 2021 16:20:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105478.201905 (Exim 4.92) (envelope-from ) id 1lTRy7-0006oT-Dn; Mon, 05 Apr 2021 16:20:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105478.201905; Mon, 05 Apr 2021 16:20:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRy7-0006oM-Ai; Mon, 05 Apr 2021 16:20:51 +0000 Received: by outflank-mailman (input) for mailman id 105478; Mon, 05 Apr 2021 16:20:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRy6-0006oH-5V for xen-devel@lists.xenproject.org; Mon, 05 Apr 2021 16:20:50 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTRy5-0003nA-Lv; Mon, 05 Apr 2021 16:20:49 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTRy5-0006s9-6E; Mon, 05 Apr 2021 16:20:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=G7kWW3Yee948/4gVKI8EIYkzCzCA2WmxX7OBr0mGBPM=; b=VZEUs7kUQXqyd06zeIoAcyROov arwrzalmW4XJFwB0cnHPwCAjE2FHcv+RC2OLjHzuf4q1QfR2mXc6/+sPOH9pEYgjK3R1wzQ7iavyd GDNO/4fPAmkLB13rMe4Fl105D5zQhRNC3WXgS9uk14L9m2RIGu8egO88Qx9yR7ez9jhs=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, Julien Grall , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Julien Grall Subject: [PATCH] xen/arm: guest_walk: Only generate necessary offsets/masks Date: Mon, 5 Apr 2021 17:20:46 +0100 Message-Id: <20210405162046.9353-1-julien@xen.org> X-Mailer: git-send-email 2.17.1 From: Julien Grall At the moment, we are computing offsets/masks for each level and granularity. This is a bit of waste given that we only need to know the offsets/masks for the granularity used by the guest. All the LPAE information can easily be inferred with just the page shift for a given granularity and the level. So rather than providing a set of helpers per granularity, we can provide a single set that takes the granularity and the level in parameters. With the new helpers in place, we can rework guest_walk_ld() to only compute necessary information. Signed-off-by: Julien Grall --- xen/arch/arm/guest_walk.c | 37 ++--------------- xen/include/asm-arm/lpae.h | 82 +++++++++++++------------------------- 2 files changed, 30 insertions(+), 89 deletions(-) diff --git a/xen/arch/arm/guest_walk.c b/xen/arch/arm/guest_walk.c index b4496c4c86c6..87de40d0cb68 100644 --- a/xen/arch/arm/guest_walk.c +++ b/xen/arch/arm/guest_walk.c @@ -372,38 +372,6 @@ static bool guest_walk_ld(const struct vcpu *v, register_t tcr = READ_SYSREG(TCR_EL1); struct domain *d = v->domain; -#define OFFSETS(gva, gran) \ -{ \ - zeroeth_table_offset_##gran(gva), \ - first_table_offset_##gran(gva), \ - second_table_offset_##gran(gva), \ - third_table_offset_##gran(gva) \ -} - - const paddr_t offsets[3][4] = { - OFFSETS(gva, 4K), - OFFSETS(gva, 16K), - OFFSETS(gva, 64K) - }; - -#undef OFFSETS - -#define MASKS(gran) \ -{ \ - zeroeth_size(gran) - 1, \ - first_size(gran) - 1, \ - second_size(gran) - 1, \ - third_size(gran) - 1 \ -} - - static const paddr_t masks[3][4] = { - MASKS(4K), - MASKS(16K), - MASKS(64K) - }; - -#undef MASKS - static const unsigned int grainsizes[3] = { PAGE_SHIFT_4K, PAGE_SHIFT_16K, @@ -519,7 +487,7 @@ static bool guest_walk_ld(const struct vcpu *v, * Add offset given by the GVA to the translation table base address. * Shift the offset by 3 as it is 8-byte aligned. */ - paddr |= offsets[gran][level] << 3; + paddr |= LPAE_TABLE_INDEX_GS(grainsizes[gran], level, gva) << 3; /* Access the guest's memory to read only one PTE. */ ret = access_guest_memory_by_ipa(d, paddr, &pte, sizeof(lpae_t), false); @@ -572,7 +540,8 @@ static bool guest_walk_ld(const struct vcpu *v, /* Make sure that the lower bits of the PTE's base address are zero. */ mask = GENMASK_ULL(47, grainsizes[gran]); - *ipa = (pfn_to_paddr(pte.walk.base) & mask) | (gva & masks[gran][level]); + *ipa = (pfn_to_paddr(pte.walk.base) & mask) | + (gva & (LEVEL_SIZE_GS(grainsizes[gran], level) - 1)); /* * Set permissions so that the caller can check the flags by herself. Note diff --git a/xen/include/asm-arm/lpae.h b/xen/include/asm-arm/lpae.h index 4797f9cee494..e94de2e7d8e8 100644 --- a/xen/include/asm-arm/lpae.h +++ b/xen/include/asm-arm/lpae.h @@ -160,63 +160,35 @@ static inline bool lpae_is_superpage(lpae_t pte, unsigned int level) #define lpae_set_mfn(pte, mfn) ((pte).walk.base = mfn_x(mfn)) /* - * AArch64 supports pages with different sizes (4K, 16K, and 64K). To enable - * page table walks for various configurations, the following helpers enable - * walking the translation table with varying page size granularities. + * AArch64 supports pages with different sizes (4K, 16K, and 64K). + * Provide a set of generic helpers that will compute various + * information based on the page granularity. + * + * Note the parameter 'gs' is the page shift of the granularity used. + * Some macro will evaluate 'gs' twice rather than storing in a + * variable. This is to allow using the macros in assembly. + */ + +/* + * Granularity | PAGE_SHIFT | LPAE_SHIFT + * ------------------------------------- + * 4K | 12 | 9 + * 16K | 14 | 11 + * 64K | 16 | 13 + * + * This is equivalent to LPAE_SHIFT = PAGE_SHIFT - 3 */ +#define LPAE_SHIFT_GS(gs) ((gs) - 3) +#define LPAE_ENTRIES_GS(gs) (_AC(1, U) << LPAE_SHIFT_GS(gs)) +#define LPAE_ENTRIES_MASK_GS(gs) (LPAE_ENTRIES_GS(gs) - 1) + +#define LEVEL_ORDER_GS(gs, lvl) ((3 - (lvl)) * LPAE_SHIFT_GS(gs)) +#define LEVEL_SHIFT_GS(gs, lvl) (LEVEL_ORDER_GS(gs, lvl) + (gs)) +#define LEVEL_SIZE_GS(gs, lvl) (_AT(paddr_t, 1) << LEVEL_SHIFT_GS(gs, lvl)) -#define LPAE_SHIFT_4K (9) -#define LPAE_SHIFT_16K (11) -#define LPAE_SHIFT_64K (13) - -#define lpae_entries(gran) (_AC(1,U) << LPAE_SHIFT_##gran) -#define lpae_entry_mask(gran) (lpae_entries(gran) - 1) - -#define third_shift(gran) (PAGE_SHIFT_##gran) -#define third_size(gran) ((paddr_t)1 << third_shift(gran)) - -#define second_shift(gran) (third_shift(gran) + LPAE_SHIFT_##gran) -#define second_size(gran) ((paddr_t)1 << second_shift(gran)) - -#define first_shift(gran) (second_shift(gran) + LPAE_SHIFT_##gran) -#define first_size(gran) ((paddr_t)1 << first_shift(gran)) - -/* Note that there is no zeroeth lookup level with a 64K granule size. */ -#define zeroeth_shift(gran) (first_shift(gran) + LPAE_SHIFT_##gran) -#define zeroeth_size(gran) ((paddr_t)1 << zeroeth_shift(gran)) - -#define TABLE_OFFSET(offs, gran) (offs & lpae_entry_mask(gran)) -#define TABLE_OFFSET_HELPERS(gran) \ -static inline paddr_t third_table_offset_##gran##K(paddr_t va) \ -{ \ - return TABLE_OFFSET((va >> third_shift(gran##K)), gran##K); \ -} \ - \ -static inline paddr_t second_table_offset_##gran##K(paddr_t va) \ -{ \ - return TABLE_OFFSET((va >> second_shift(gran##K)), gran##K); \ -} \ - \ -static inline paddr_t first_table_offset_##gran##K(paddr_t va) \ -{ \ - return TABLE_OFFSET((va >> first_shift(gran##K)), gran##K); \ -} \ - \ -static inline paddr_t zeroeth_table_offset_##gran##K(paddr_t va) \ -{ \ - /* Note that there is no zeroeth lookup level with 64K granule sizes. */\ - if ( gran == 64 ) \ - return 0; \ - else \ - return TABLE_OFFSET((va >> zeroeth_shift(gran##K)), gran##K); \ -} \ - -TABLE_OFFSET_HELPERS(4); -TABLE_OFFSET_HELPERS(16); -TABLE_OFFSET_HELPERS(64); - -#undef TABLE_OFFSET -#undef TABLE_OFFSET_HELPERS +/* Offset in the table at level 'lvl' */ +#define LPAE_TABLE_INDEX_GS(gs, lvl, addr) \ + (((addr) >> LEVEL_SHIFT_GS(gs, lvl)) & LPAE_ENTRIES_MASK_GS(gs)) /* Generate an array @var containing the offset for each level from @addr */ #define DECLARE_OFFSETS(var, addr) \ -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Apr 05 17:01:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Apr 2021 17:01:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105489.201921 (Exim 4.92) (envelope-from ) id 1lTSbI-0001wE-KU; Mon, 05 Apr 2021 17:01:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105489.201921; Mon, 05 Apr 2021 17:01:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTSbI-0001w6-GT; Mon, 05 Apr 2021 17:01:20 +0000 Received: by outflank-mailman (input) for mailman id 105489; Mon, 05 Apr 2021 17:01:19 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTSbH-0001w1-6L for xen-devel@lists.xenproject.org; Mon, 05 Apr 2021 17:01:19 +0000 Received: from mailhost.m5p.com (unknown [74.104.188.4]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id efbfb9b8-6b8b-4728-bcf3-c18cd5d75080; Mon, 05 Apr 2021 17:01:18 +0000 (UTC) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 135H12mh072531 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 5 Apr 2021 13:01:07 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 135H11Rr072530; Mon, 5 Apr 2021 10:01:01 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: efbfb9b8-6b8b-4728-bcf3-c18cd5d75080 Date: Mon, 5 Apr 2021 10:01:01 -0700 From: Elliott Mitchell To: Julien Grall Cc: xen-devel@lists.xenproject.org, Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu , Dario Faggioli , Tim Deegan , Roger Pau Monn?? , Anthony PERARD Subject: Re: [PATCH 00/14] Use const whether we point to literal strings (take 1) Message-ID: References: <20210405155713.29754-1-julien@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210405155713.29754-1-julien@xen.org> X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.5 X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com On Mon, Apr 05, 2021 at 04:56:59PM +0100, Julien Grall wrote: > I am not aware of code trying to modify literal strings in Xen. > However, there is a frequent use of non-const char * to point to > literal strings. Given the size of the codebase, there is a risk > to involuntarily introduce code that will modify literal strings. > > Therefore it would be better to enforce using const when pointing > to such strings. Both GCC and Clang provide an option to warn > for such case (see -Wwrite-strings) and therefore could be used > by Xen. > > This series doesn't yet make use of -Wwrite-strings because > the tree is not fully converted. Instead, it contains some easy > and likely non-controversial use const in the code. > > The major blockers to enable -Wwrite-strings are the following: > - xen/common/efi: union string is used in both const and > non-const situation. It doesn't feel right to specific one member > const and the other non-const. > - libxl: the major block is the flexarray framework as we would use > it with string (now const char*). I thought it would be possible to > make the interface const, but it looks like there are a couple of > places where we need to modify the content (such as in > libxl_json.c). > > Ideally, I would like to have -Wwrite-strings unconditionally used > tree-wide. But, some of the area may required some heavy refactoring. > > One solution would be to enable it tree-wide but turned it off at a > directroy/file level. > > Any opinions? I think doing such is a Good Idea(tm). Adding consts adds opportunities for greater optimization. Both by compilers which can avoid extra copies, and developers who then know they don't need to generate extra copies to sacrific them to an API. In particular the consts also function as documentation. So you're certainly not the only person who thinks additional consts would be a good thing: https://lists.xenproject.org/archives/html/xen-devel/2021-01/msg00132.html Alas merely getting the two const patches into the latest release apparently wasn't even worthy of response: https://lists.xenproject.org/archives/html/xen-devel/2021-02/msg01040.html I agree this should be done, though I'm aware many developers hate bothering with constants. -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Mon Apr 05 19:49:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Apr 2021 19:49:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105518.201944 (Exim 4.92) (envelope-from ) id 1lTVDn-0007Y6-EY; Mon, 05 Apr 2021 19:49:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105518.201944; Mon, 05 Apr 2021 19:49:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTVDn-0007Xz-BZ; Mon, 05 Apr 2021 19:49:15 +0000 Received: by outflank-mailman (input) for mailman id 105518; Mon, 05 Apr 2021 19:49:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTVDm-0007Xr-6A; Mon, 05 Apr 2021 19:49:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTVDl-0007DR-Pm; Mon, 05 Apr 2021 19:49:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTVDl-0000rf-G6; Mon, 05 Apr 2021 19:49:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lTVDl-0000Rp-Fa; Mon, 05 Apr 2021 19:49:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Wjq23yCLfuunPu3sCwPKL/+8ZcLFeDUOd9xBKbh6/+4=; b=IVmOGCcYIz7nQWVAIiR5reRbTH buIgPv10dHYLVXxP5ol0ZN4LlVyIObc/j9jpCwWPWNsiDhcgyyhPMzsQOxnqJI4GiqXEz8+qpN39T Fx63qcfySnn7tF/Y1x2Q9nYZuLdrZv3R394CHxICX7/3b7KGVkmu0iMvlRFoTPCPeq9I=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.12-testing test] 160738: regressions - FAIL X-Osstest-Failures: xen-4.12-testing:build-armhf::broken:regression xen-4.12-testing:build-armhf:host-install(4):broken:regression xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-localmigrate/x10:fail:regression xen-4.12-testing:test-amd64-amd64-libvirt-pair:guests-nbd-mirror/debian:fail:heisenbug xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-saverestore.2:fail:heisenbug xen-4.12-testing:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-4.12-testing:build-armhf-libvirt:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl:build-check(1):blocked:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=5b280a59c4dd8dad6cc8da28db981b193d10acee X-Osstest-Versions-That: xen=4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 From: osstest service owner Date: Mon, 05 Apr 2021 19:49:13 +0000 flight 160738 xen-4.12-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/160738/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken in 160709 build-armhf 4 host-install(4) broken in 160709 REGR. vs. 159418 test-amd64-amd64-xl-qcow2 19 guest-localmigrate/x10 fail in 160709 REGR. vs. 159418 Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-pair 22 guests-nbd-mirror/debian fail in 160709 pass in 160738 test-amd64-amd64-xl-qcow2 18 guest-saverestore.2 fail pass in 160709 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked in 160709 n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked in 160709 n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked in 160709 n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked in 160709 n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked in 160709 n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked in 160709 n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked in 160709 n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked in 160709 n/a test-armhf-armhf-libvirt 1 build-check(1) blocked in 160709 n/a build-armhf-libvirt 1 build-check(1) blocked in 160709 n/a test-armhf-armhf-xl 1 build-check(1) blocked in 160709 n/a test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159418 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159418 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159418 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: xen 5b280a59c4dd8dad6cc8da28db981b193d10acee baseline version: xen 4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 Last test of basis 159418 2021-02-16 15:06:11 Z 48 days Failing since 160128 2021-03-18 14:36:18 Z 18 days 22 attempts Testing same since 160150 2021-03-20 04:11:48 Z 16 days 20 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Christian Lindig Edwin Török Igor Druzhinin Jan Beulich Julien Grall Olaf Hering Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken Not pushing. (No revision log; it would be 311 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Apr 05 21:32:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Apr 2021 21:32:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105542.201966 (Exim 4.92) (envelope-from ) id 1lTWpE-000066-D2; Mon, 05 Apr 2021 21:32:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105542.201966; Mon, 05 Apr 2021 21:32:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTWpE-00005z-94; Mon, 05 Apr 2021 21:32:00 +0000 Received: by outflank-mailman (input) for mailman id 105542; Mon, 05 Apr 2021 21:31:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTWpD-00005r-C8; Mon, 05 Apr 2021 21:31:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTWpD-0000Uh-39; Mon, 05 Apr 2021 21:31:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTWpC-0006Dp-QY; Mon, 05 Apr 2021 21:31:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lTWpC-0003b3-Q4; Mon, 05 Apr 2021 21:31:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0zA02NYBuF6mzGavhELoQnvjZUDzYBGKXyeEgtl5OUU=; b=aW3xxyKkvJigN18AD7YVjESCXw QXVtnE1cxPQlAvPpR6S7MIkwTpOK6SJ0bqpaXzoY/u13Y77aPqX/JNPVG83Q3hOV+8zfWfMtCWsdX 6qj0rDagl5vFCugKhUcu/Aj9wjV2+Wfp73GMOLlu5kJUdMUJiMFKmmRYk3aIi/9odJ2E=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160742: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-qemuu-freebsd12-amd64:guest-localmigrate/x10:fail:regression linux-linus:test-amd64-amd64-examine:memdisk-try-append:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=e49d033bddf5b565044e2abe4241353959bc9120 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Mon, 05 Apr 2021 21:31:58 +0000 flight 160742 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160742/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-qemuu-freebsd12-amd64 19 guest-localmigrate/x10 fail REGR. vs. 152332 test-amd64-amd64-examine 4 memdisk-try-append fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux e49d033bddf5b565044e2abe4241353959bc9120 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 248 days Failing since 152366 2020-08-01 20:49:34 Z 247 days 420 attempts Testing same since 160742 2021-04-05 05:16:49 Z 0 days 1 attempts ------------------------------------------------------------ 5292 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1315206 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Apr 06 02:07:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Apr 2021 02:07:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105580.201993 (Exim 4.92) (envelope-from ) id 1lTb7m-0004cF-H6; Tue, 06 Apr 2021 02:07:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105580.201993; Tue, 06 Apr 2021 02:07:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTb7m-0004c8-DF; Tue, 06 Apr 2021 02:07:26 +0000 Received: by outflank-mailman (input) for mailman id 105580; Tue, 06 Apr 2021 02:07:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTb7l-0004bz-JH; Tue, 06 Apr 2021 02:07:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTb7l-0002me-A1; Tue, 06 Apr 2021 02:07:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTb7k-00030d-UR; Tue, 06 Apr 2021 02:07:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lTb7k-0002pc-Tu; Tue, 06 Apr 2021 02:07:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Xdqjw0XgQhNOopiuhp4cuEexlBgKOR3pAugXag/sWAQ=; b=l/SmVvEw2rl4XB8pmRi/WMrovH PdwEb62TH2VxOwA5snCraib+ILWHdl3+RAq+OPP+9nIFO2jz8XPI7VskERJYwJe7a6Lgtw+lMZrN3 Zx1lSUbdjYLNNNhSWJpDFGsPbzR+UYgEIeaf8DK0tV4jxuOgz8ABbGRncQofB9xX4PWk=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 160745: regressions - FAIL X-Osstest-Failures: xen-unstable:test-armhf-armhf-libvirt::broken:regression xen-unstable:test-armhf-armhf-xl::broken:regression xen-unstable:test-armhf-armhf-xl-credit1::broken:regression xen-unstable:test-armhf-armhf-xl-credit2::broken:regression xen-unstable:test-armhf-armhf-xl-vhd::broken:regression xen-unstable:test-armhf-armhf-xl-rtds::broken:regression xen-unstable:test-armhf-armhf-xl-multivcpu::broken:regression xen-unstable:test-armhf-armhf-xl-cubietruck::broken:regression xen-unstable:test-armhf-armhf-xl-arndale::broken:regression xen-unstable:test-armhf-armhf-libvirt-raw::broken:regression xen-unstable:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression xen-unstable:test-armhf-armhf-xl-arndale:guest-start.2:fail:regression xen-unstable:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression xen-unstable:test-armhf-armhf-libvirt:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-xl:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-xl-vhd:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-xl-multivcpu:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-xl-arndale:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-xl-credit1:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-libvirt-raw:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-examine:host-install:broken:heisenbug xen-unstable:test-armhf-armhf-xl-credit2:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-xl-cubietruck:host-install(5):broken:heisenbug xen-unstable:test-arm64-arm64-xl-seattle:xen-boot:fail:heisenbug xen-unstable:test-armhf-armhf-xl-vhd:xen-boot:fail:heisenbug xen-unstable:test-armhf-armhf-examine:reboot:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-armhf-armhf-xl-arndale:xen-boot:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt:guest-start:fail:heisenbug xen-unstable:test-armhf-armhf-xl:xen-boot:fail:heisenbug xen-unstable:test-armhf-armhf-xl-vhd:debian-di-install:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt-raw:debian-di-install:fail:heisenbug xen-unstable:test-armhf-armhf-xl-credit2:guest-start:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:xen-boot:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt-raw:guest-start:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:heisenbug xen-unstable:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt:xen-boot:fail:heisenbug xen-unstable:test-armhf-armhf-xl-vhd:guest-start:fail:heisenbug xen-unstable:test-armhf-armhf-xl-credit1:guest-start:fail:heisenbug xen-unstable:test-armhf-armhf-xl-arndale:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=0435784cc75dcfef3b5f59c29deb1dbb84265ddb X-Osstest-Versions-That: xen=b0976d5c0441378b6348f5bfedbf431055bd0147 From: osstest service owner Date: Tue, 06 Apr 2021 02:07:24 +0000 flight 160745 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/160745/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt broken in 160665 test-armhf-armhf-xl broken in 160700 test-armhf-armhf-xl-credit1 broken in 160700 test-armhf-armhf-xl-credit2 broken in 160700 test-armhf-armhf-xl-vhd broken in 160700 test-armhf-armhf-xl-rtds broken in 160700 test-armhf-armhf-xl-multivcpu broken in 160700 test-armhf-armhf-xl-cubietruck broken in 160700 test-armhf-armhf-xl-arndale broken in 160700 test-armhf-armhf-libvirt-raw broken in 160700 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 160665 REGR. vs. 160646 test-armhf-armhf-xl-arndale 19 guest-start.2 fail in 160733 REGR. vs. 160646 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail in 160733 REGR. vs. 160646 Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt 5 host-install(5) broken in 160665 pass in 160745 test-armhf-armhf-xl 5 host-install(5) broken in 160700 pass in 160745 test-armhf-armhf-xl-vhd 5 host-install(5) broken in 160700 pass in 160745 test-armhf-armhf-xl-rtds 5 host-install(5) broken in 160700 pass in 160745 test-armhf-armhf-xl-multivcpu 5 host-install(5) broken in 160700 pass in 160745 test-armhf-armhf-xl-arndale 5 host-install(5) broken in 160700 pass in 160745 test-armhf-armhf-xl-credit1 5 host-install(5) broken in 160700 pass in 160745 test-armhf-armhf-libvirt-raw 5 host-install(5) broken in 160700 pass in 160745 test-armhf-armhf-examine 5 host-install broken in 160700 pass in 160745 test-armhf-armhf-xl-credit2 5 host-install(5) broken in 160700 pass in 160745 test-armhf-armhf-xl-cubietruck 5 host-install(5) broken in 160700 pass in 160745 test-arm64-arm64-xl-seattle 8 xen-boot fail in 160665 pass in 160745 test-armhf-armhf-xl-vhd 8 xen-boot fail in 160665 pass in 160745 test-armhf-armhf-examine 8 reboot fail in 160665 pass in 160745 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 160665 pass in 160745 test-armhf-armhf-xl-arndale 8 xen-boot fail in 160665 pass in 160745 test-armhf-armhf-libvirt 14 guest-start fail in 160715 pass in 160733 test-armhf-armhf-xl 8 xen-boot fail in 160715 pass in 160745 test-armhf-armhf-xl-vhd 12 debian-di-install fail in 160715 pass in 160745 test-armhf-armhf-libvirt 18 guest-start/debian.repeat fail in 160733 pass in 160700 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail in 160733 pass in 160715 test-armhf-armhf-libvirt-raw 12 debian-di-install fail in 160733 pass in 160745 test-armhf-armhf-xl-credit2 14 guest-start fail pass in 160665 test-armhf-armhf-xl-rtds 8 xen-boot fail pass in 160665 test-armhf-armhf-libvirt-raw 13 guest-start fail pass in 160715 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail pass in 160733 test-armhf-armhf-xl-multivcpu 14 guest-start fail pass in 160733 test-armhf-armhf-libvirt 8 xen-boot fail pass in 160733 test-armhf-armhf-xl-vhd 13 guest-start fail pass in 160733 test-armhf-armhf-xl-credit1 14 guest-start fail pass in 160733 test-armhf-armhf-xl-arndale 18 guest-start/debian.repeat fail pass in 160733 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 160665 REGR. vs. 160646 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 160665 like 160646 test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 160665 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 160665 never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 160665 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 160665 never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 160665 never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 160665 never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 160665 never pass test-armhf-armhf-libvirt 16 saverestore-support-check fail in 160733 like 160646 test-armhf-armhf-libvirt 15 migrate-support-check fail in 160733 never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail in 160733 never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail in 160733 never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 160733 never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 160733 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160646 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160646 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160646 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160646 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160646 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160646 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160646 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160646 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160646 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: xen 0435784cc75dcfef3b5f59c29deb1dbb84265ddb baseline version: xen b0976d5c0441378b6348f5bfedbf431055bd0147 Last test of basis 160646 2021-04-01 15:07:43 Z 4 days Testing same since 160665 2021-04-02 07:40:09 Z 3 days 6 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Bertrand Marquis Jan Beulich Julien Grall Michal Orzel Norbert Manthey Rahul Singh Roger Pau Monné Stefano Stabellini Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw fail test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-libvirt broken broken-job test-armhf-armhf-xl broken broken-job test-armhf-armhf-xl-credit1 broken broken-job test-armhf-armhf-xl-credit2 broken broken-job test-armhf-armhf-xl-vhd broken broken-job test-armhf-armhf-xl-rtds broken broken-job test-armhf-armhf-xl-multivcpu broken broken-job test-armhf-armhf-xl-cubietruck broken broken-job test-armhf-armhf-xl-arndale broken broken-job test-armhf-armhf-libvirt-raw broken broken-job test-armhf-armhf-xl-arndale broken broken-job test-armhf-armhf-xl-cubietruck broken Not pushing. (No revision log; it would be 412 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Apr 06 05:35:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Apr 2021 05:35:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105617.202023 (Exim 4.92) (envelope-from ) id 1lTeMq-0006Ko-Ta; Tue, 06 Apr 2021 05:35:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105617.202023; Tue, 06 Apr 2021 05:35:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTeMq-0006Kh-QZ; Tue, 06 Apr 2021 05:35:12 +0000 Received: by outflank-mailman (input) for mailman id 105617; Tue, 06 Apr 2021 05:35:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTeMq-0006KZ-8i; Tue, 06 Apr 2021 05:35:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTeMp-0006bD-T6; Tue, 06 Apr 2021 05:35:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTeMp-0007Pe-JP; Tue, 06 Apr 2021 05:35:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lTeMp-0004Bt-Ig; Tue, 06 Apr 2021 05:35:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bhvSV6s0s6Zlh/ycQbx0A8eHW7J2NeVcwq1A/Ye4gfk=; b=XQQPiZJHggBbeJsYrs9tHqXQIg rjsxxkdZDy9BdAKNcjjr0UbsEhiLLjWqVKBgtX12cMDfmKe7Jn5oqDXKKRmUc1neyllH+BEx0bUW6 flUS9v2UMfNyaaY5Zw4kbHy8U4Xsz3TSVD60oAh3ML55fVjm9y2jDpID8cVStmtbnGEk=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160748: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-amd64-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-freebsd10-i386:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-freebsd10-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-i386-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-arm64-arm64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install/l1/l2:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-armhf-armhf-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=11577d85b1a6939380bd16ed9a861653194de044 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Tue, 06 Apr 2021 05:35:11 +0000 flight 160748 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/160748/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-qemuu-freebsd12-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-freebsd10-i386 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-freebsd10-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-i386-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-arm64-arm64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-qemuu-nested-intel 20 debian-hvm-install/l1/l2 fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail in 160736 REGR. vs. 152631 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 160736 Tests which did not succeed, but are not blocking: test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: qemuu 11577d85b1a6939380bd16ed9a861653194de044 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 228 days Failing since 152659 2020-08-21 14:07:39 Z 227 days 428 attempts Testing same since 160736 2021-04-05 00:08:23 Z 1 days 2 attempts ------------------------------------------------------------ 473 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair fail test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 140239 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Apr 06 07:24:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Apr 2021 07:24:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105638.202047 (Exim 4.92) (envelope-from ) id 1lTg4d-0007Rk-Us; Tue, 06 Apr 2021 07:24:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105638.202047; Tue, 06 Apr 2021 07:24:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTg4d-0007Rd-Qs; Tue, 06 Apr 2021 07:24:31 +0000 Received: by outflank-mailman (input) for mailman id 105638; Tue, 06 Apr 2021 07:24:31 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTg4c-0007RY-TQ for xen-devel@lists.xenproject.org; Tue, 06 Apr 2021 07:24:31 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 9facefb6-ad17-4bbb-a395-e5931d064ab2; Tue, 06 Apr 2021 07:24:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9facefb6-ad17-4bbb-a395-e5931d064ab2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617693869; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Dic6IK8QayCg/s6bayaGiGRZd2WYKi2gNIf366dtmlU=; b=hUP/6W5pkznEm9r89v6Q4iRlV4dutSzF4Qcpigz9U/lr3n35cr6hlifT 57lMWXyVFVbExU6f+y3pOKBA2V7T79CoMStors/RV+ski3N8jmDVMD/WR +no5Sg2LlAvJ+5JV2GSObSxfs94nYZGgK69sVoF6J8PPr4Y9m/pjpbgIH w=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: IUXWMJwBvs8i2u+9Fn5+w1/8ZuIbJ37i+TBlzbuDT5meXP8k0oEqWkyzvL4Pdadal7YLEVetS9 skecLr5rAk0bzbxPEbznn6CVCL+rn1/etWD965joPzemRuEzdEkiuLo2XATz4fDXjt0I0lAL0J EpOETdhwpJtRPuvgw86Otn5LKDnra+daDt6urBGJWGJvtUkzYrUK4UNKMe0gjy632R3CPzNkgG 9z5olP3DMv8pg90ccfxbGtcp2eCw/4oBFQc18lWAlbrxUks9RGBQ7KQJx0An89YcaSkrMUhEx+ lBw= X-SBRS: 5.2 X-MesageID: 41322658 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:3oZioK2rNy3iIrFc+YeymwqjBQ93eYIsi2QD101hICF9Wvez0+ izgfUW0gL1gj4NWHcm3euNIrWEXGm0z/NIyKErF/OHUBP9sGWlaLtj44zr3iH6F0TFnNJ1/Z xLN5JzANiYNzNHpO7x6gWgDpIEyN6I7KiniY7lvgxQZCtBApsQjDtRIACdD0FwWU1iDZ02CJ KT6qN81kCdUF4Qadm2AWRAYvjbq7Tw5d/bSDMlJzpi0gmBiju09KX3eiL14j4yWy5CqI1Sll TtvBf+4syY0s2T6hiZ7GPL6oQTpd2J8Ko6OOWpquw4bgrhkRypYoMJYczPgBkQrPu04Fgn1P ngyi1QWfhb0H/acmGrrRaF4WCJv1gTwkTvxlOCjXzordaRfkNCN+N6mYlbfhHFgnBQ3u1U7a NR02qV87pRAB/Q9R6Ng+TgahBwmkK45UcliO4Y5kYvNLc2Vbk5l+wi1XIQNK1FMDPx6YghHu UrJtrb/uxqfVSTaG2clnVzwfS3N05DUCuucwwngIi4wjJWlHd2ww8z38oEhEoN85o7Vt1t+/ nECKJ1j7tDJ/VmLJ5VNaMke4+aG2bNSRXDPCa5OlL8DpwKPHrLttrR7Kgq4vqpPLgF1oE7lp iEcF4wjx9zR2veTem1mLFb+BHER2uwGR73zNtF2pR/srrgALXxNymOT00vjtugr/0TDtazYY fwBLtmR9vYaUf+E4dA2APzH7NIL2MFbcETstEnH1KCy/i7b7HCh6j+SrL+NbDtGTErVifUGX 0YRgX+I81G8wSuUn/8ix7BRmP1diXEjNZNOZmf29JW5JkGN4VKvARQo0++/Nu3JTpLtbFzel B/LrPhmqayvnK34m7M8mVsNnNmfwVoyYSld0kPiR4BMkvyf7pGkc6YY3pu0HyOIQI6U9nbCx dFp1N8+bu+KpuZwSxKMaPhDkuqy18o4F6aRZYVnaOOofr/cpQjF5A8RehaDgPQDSF4ng5stU ZOYAIJXVXkCzvrkKmp5aZkQt33Rp1ZukOLKdQRgW/DvU+czPtfO0czbnqLa4qrpioAAxBTnU Z89qcDhqHoo0fSFUIPxMIiMFNNb2yLBqlhFwrtXvQappniZBxwQWCWhTaTlhE0fS7w+18Pg3 H6RBfkBs3jEx5TvGtV3b3t904xfmKBf1hoYnQ/qoFlE3/a00wDmtOjd+633i+JcV0JzvsGPD ytW0phHip+g9S23gWSgjCMCDEvwYgvJPXUCN0YAvju82LoLI2DjqcdGfBIuJ5jKdD1q+cOFe aSYRWcIj+9C+Qn3WWu1z4YETgxrHkvivXz3hL5qGC+wX4kGPLXZE18WKtzGaDp00H0A/KTlJ lph9M8uuW9dm33d96d0KnSKzpOMAnar2K6R/whwKok954apf92Bd3WQDHI3HZI0FElIMD4mF gXTa577LrCU7UfCfA6amZc5B4khd6PJEwkvkjqGec4Z0gqlGKeMNWT4bbEwIBfd3GptU/1Ix 2Y/CJc9fueAHfG2r4eFq4qIWNZLEI7829v+eued4vWTAWmHtszjGaSIzu4avtaTqPABLAb6h B96NuMl/WMdyX51BvL1AELVZ5m4iKiW4eqHAmIGeRU6NS0NlSHn7uy7KeI/UbKYCr+b15dmJ ZMekMRZNlSkzUujIU41S6pV6z8y3hV4Gd28HVgjV7i2o+v/WfdEwVHKGTi8+trYQU= X-IronPort-AV: E=Sophos;i="5.81,308,1610427600"; d="scan'208";a="41322658" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DECKNk2CxHQZ3LUFQ8v+gMV/JTTiJ+PmmZFMb5hByvUOtZFfOWLea2CBcUMFA/8fUsSmXhbnFx/x/d/1LuTOuT1q78viHnI8xhmfpeLw+CRdRmu50JeacL3HG0Cn9HyufYqjgtYKO9KMQfWZtuTNQI/Fbpuf51Qu3RrrQ8SIPaiidhrrt3TL3MULcOwORPWHODeUeghkQwttbs98fEBRsWEcxNAaetUPs+rrsIfU4fDwhAbUd/eJ16Ual1jkQ6CyLfzTBKEjXTauCSg5M7ZpMJ50WQLz7aAyDtYmxunH2FD8xw4qibjyWzIJ3UjkpqoXolEcWIkW0bTtpUvIpEeTPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LaSM8NYnKk7QGM96Sa85FsEJn1s/VgUk15oZYdXJ8w0=; b=KVahHK7Z2oDdD2kVgsJOwF5Uw0uo7foWCVWmb+700f2sWWPWYg5yeV7JY2CA+xHXiT4JLoMQCQj/usM1Yx9YARvDblRxwyxlcy0DEnp1De6KWi3GygOcTCKZN9qgpA8RJq2jUQaVyivdaagWp6EZxdJpXD8+XN5UQWbdhgijEtqAJZZGqlZbdZoJQUzUEKz8W7Mf5ryveBD79xAe7yjq/I+/RV6yTG/kbtArT6xNtoHKF4R9CLUByEv7s22U6pyjQ4sAPOBd4Tff620bACDGbRfc31zxfMcLv4navBnr6/d2WSzMXFbtOsydrDBZ3CcOjKM3wf/sQ510N3HkOGhrAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LaSM8NYnKk7QGM96Sa85FsEJn1s/VgUk15oZYdXJ8w0=; b=CWgZfduCy8GQ6AdBFt+1AwWQbhp2mqHnm7OLUAVw/TWkJ+KktxR5IFbRg25pfv7sjlccXJstoDe2MBcWSAtJ/3iAMxvdXT7rXYRtIPa5C6tG/UsaUapMrbgTzEPUlmoyNvFYe9iBCbhiltuvcz1OWCuppP+CpZkH/DVZd1FTIJs= Date: Tue, 6 Apr 2021 09:24:18 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Julien Grall CC: , Julien Grall , "Tim Deegan" , Jan Beulich , Andrew Cooper , George Dunlap , "Wei Liu" Subject: Re: [PATCH 03/14] xen/x86: shadow: The return type of sh_audit_flags() should be const Message-ID: References: <20210405155713.29754-1-julien@xen.org> <20210405155713.29754-4-julien@xen.org> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210405155713.29754-4-julien@xen.org> X-ClientProxiedBy: MRXP264CA0005.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:15::17) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8fbbd864-2399-4ee4-a4de-08d8f8cd0176 X-MS-TrafficTypeDiagnostic: DM4PR03MB5967: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6FjElxC0VJ8bVo+oQQodvDvcd/6JI/dJM5hzXZoKDuEW6e4YjrKKvc9s79KtDCR+nHBaZK8q1XEM4Ue+CJlYEamRC7aMEqeQVTv+Mwj9Y+H2+NhwliDOIWoVRZYH2EthxJ3QxBZJPMvmsJ605yB+P2z3HWUO4uuw5NIt1AJLO1+Skpw1i0iSoGj+aRyhKYyaY3lzM+2IMAH3+rWmzDGVrlKf8KqHjcTnB83xBF9mPBEFnxKLIZhgI2xwF9s/BMIauxQKAC6RYu2ud0ikX1OZON5EN9urZRD9xh0N1BhFGZmWD2JRgE6jYOtOzghKDrU19PrbUaN7PzeOTD9VzuZVHaPG59tladNpgi8yrvEbd0/vxKDy3UUqWQMU2bhGxMGECyTV9AIY/hYc68caNPgvm3MyJBgHMi0UGBO5jisIuAJNFEbyKilZUioL5vBOhuMvx6oIYwsSTH+KXjFx2AJR4oiYsuXvCoVTA8nugEpKnxbRdfa4bYre0rOcstM6zrCrFMXRj46UiRqSGxJYEeTNATVbZ0Q/jtwFIwWzn1d1JoMW2YUbI9aIGEZmj3OEXPf9ZLIAcijpNYuejt8SxXSrxSkCEoiMSEUHkb3esaLFwO5mgATP9LhAq8PbNYKrM99qsqlLVnbyXaYhSCficrG8aA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(376002)(366004)(346002)(396003)(39860400002)(136003)(6916009)(26005)(6666004)(6496006)(478600001)(66556008)(66476007)(2906002)(186003)(66946007)(54906003)(316002)(4744005)(33716001)(86362001)(85182001)(16526019)(8936002)(956004)(8676002)(38100700001)(5660300002)(4326008)(9686003)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Wit2eEZWVHR1ZGZIbU4zSVlmdWlIQk1ZM1JSNk5MVnhwbHFNNFdHUCtyL2Rx?= =?utf-8?B?SDFTbGxheWtHZktkckJxdVFRQ1NvTjZQRlhndXBVU0dORUVsMEo1Y014d2lZ?= =?utf-8?B?eGtveEJZSUFzdi9Nb3ZUVFI1SW9lbmNORjhCTVFZRDg4UG5yQW5tN3pUNzNY?= =?utf-8?B?bDNQY3BuM0pka2x1bGhBZFpVNVNFVnd1QlF2eDFNTFhNMW9EdFpEZ29LNWMx?= =?utf-8?B?UURwL0IwYVdzOTJUeFp4SWo1TDhyY0ZXWHpCckgvMkx0T21za2RHVDBZWjBV?= =?utf-8?B?Z25HWXB1OWxmQzJSZHBRZ0JuaHFPVmI4NTVMVXRmUFQ2Z1RFWERNVlFZK1lI?= =?utf-8?B?Z2d1WVRTYmdtS1hLNnFhdU9zbTFVNUFkRGQ5b2FoN0UzbHVRWDNCc3dJNEQx?= =?utf-8?B?Z0pDS2RuQmdseFloVGdoWmp3NG9pdXJhaVZSOGVDWkJpalFaZGYycjZlWGpU?= =?utf-8?B?TTZ6K1ZMSWZoTzZHeUZpRU92T3hydTl0VkoxKzJhSE83SXJxUzRUWUpTd25m?= =?utf-8?B?eWVZVmp4TEFNZnNyMFFoMklyaEJnOXNhUzRncVVIeDFaV3pVbitzZ2Nza0ZM?= =?utf-8?B?aW1jTFhCTytKbTVxTU8xckZMRG1SVXdoZ0x4S3hlckNOTjVjV3hFRnVrdlFG?= =?utf-8?B?RWEySlVpd0xWSWc1NlZnMndPUC9QbkRKL3ZVYXUyOFZjWjQ1YlRyQ1FmV3l6?= =?utf-8?B?MzluWjEyMERhNG10bm9hQUtza055YUZKWXpaTXlqb1Y4S0cyNEV4eE5aU1lr?= =?utf-8?B?NndIaVA5QVVrUUdnK2hHWCtKYURyOEtwSFFraXk0VzVrNmJQd1daNzcxRGx4?= =?utf-8?B?dFY5ZFZZNVpNRlMrbTQ2dGpieXIxeVBmM2tzOU9uTnd0RDVvTGVublN0TnA5?= =?utf-8?B?dmgwck9UN3g5VGl5blZzR1NGZVZqdytrZWlyZ2FZSU4rb0pNdVdKQ1d3aGdn?= =?utf-8?B?MS9uM2pCS3ZSdUtINGQ5SlluZkhKZlZaVWgzVWh6c3VYUDE0bmhMN3gvZ1Vj?= =?utf-8?B?dTE5ZTJycDVtaHRZaWZpdVZrN0UyVnpyRzdoQTdTT1hDc1lKSkxZQ0lJL0ZD?= =?utf-8?B?ZkYycUVzejhlaDlZaDBJUUl3c0RGbzNxUmJsTFJJbTdUak13TmpOdlpmQjJU?= =?utf-8?B?ZzhhZm1lMlJZTDdPM2l0aEVQaFpJZG9OSXczNVlxaGZFOVQ1ZjE4RHU2cWw4?= =?utf-8?B?Q2lOcDFaUmg5bHpNcVQ5eFcwOUlReDVLRkZ1SEwzMndCV0NqTHA0K3N6Tjdi?= =?utf-8?B?cTR3WnFVL09DZUFUa1FwVFhHYmZoWjc0SFIvVW5uNWlSbkQrcjlXY0hobzJK?= =?utf-8?B?ZGhxMnR3cDNBa0U1c2pMcVpWVklPdzFlaHBzaVhHZ0RhS0p2cTVHajYxL09y?= =?utf-8?B?QSt6b1JtM0Z1Unk0eWhMS3o2WXptYUlyOXpPOUk0bzZ4bmxZd2xXQzUwcHBp?= =?utf-8?B?SUtXWGQwMHlROWVQR0hlQ3YyeG11ZVpzT0lwTVh5UVNYMXg2V0QwRkZMZG5x?= =?utf-8?B?Z2c4bWx2bGZObUNyVlRJbmVTb2lKVjdoeVNDL3dBZ1JrOHFoK3AzY05BdVYw?= =?utf-8?B?bnBwZ0xiWnV3OHZrZ3Bmb21vTjZMbFJ6T0JTbzQwam5mZ1FlNnF1REJZWE4r?= =?utf-8?B?dldDY2oyK1lyWTNPclVFV2VIV2s0Yy9EYkVzSGlkSUpkUDdPRGhZSHc2VVAw?= =?utf-8?B?QmhKWEZsaWRQSnBoNU5aZHJOeGRVdld3RjdHaDU2a1RvZndyNnpDb3RKU2Fl?= =?utf-8?Q?DsSXOO7cnCf4bufh3rb7KswbvEJNmmS8Ft7NB2+?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8fbbd864-2399-4ee4-a4de-08d8f8cd0176 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2021 07:24:25.0671 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: H+cTUxA/aScMAFU57zJRaVJ1GOuo9zMhOZTAgAU2m8EDGmF+CuDMIOaZPC5S1YEL9R1sebkBAvwWIVxdz78Y+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB5967 X-OriginatorOrg: citrix.com On Mon, Apr 05, 2021 at 04:57:02PM +0100, Julien Grall wrote: > From: Julien Grall > > The function sh_audit_flags() is returning pointer to literal strings. > They should not be modified, so the return is now const and this is > propagated to the callers. > > Take the opportunity to fix the coding style in the declaration of > sh_audit_flags. > > Signed-off-by: Julien Grall While doing the cleanup I think you could narrow the scope of the 's' variables also, but doesn't need to be part of this patch: Reviewed-by: Roger Pau Monné Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Apr 06 07:29:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Apr 2021 07:29:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105649.202059 (Exim 4.92) (envelope-from ) id 1lTg9U-0007dT-KW; Tue, 06 Apr 2021 07:29:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105649.202059; Tue, 06 Apr 2021 07:29:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTg9U-0007dM-HY; Tue, 06 Apr 2021 07:29:32 +0000 Received: by outflank-mailman (input) for mailman id 105649; Tue, 06 Apr 2021 07:29:31 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTg9T-0007dH-8L for xen-devel@lists.xenproject.org; Tue, 06 Apr 2021 07:29:31 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2e98721e-934c-4694-adfe-7ec3994501b0; Tue, 06 Apr 2021 07:29:30 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e98721e-934c-4694-adfe-7ec3994501b0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617694170; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=4Ww9wXXPGkM2/E52FDo0SFlPVEKaXXM1ywRi2WExDMc=; b=UVwETZ0CK8t7TtOvB3OS6puxpMY7BjadO5vzFnZwUpoWlsvi9Bp5dTru Bf0N+YjR85Prw2ofC8Sq/gWFNIbtYPDbAu0QPvspYEKydA1ikQni3NTMb echKAzmMKUjUF98hlmKuFx/fwP2FofUNq5OgbNth/lrxPcHUKeaFSkc+W k=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: N/DowTvzGPe2tJNuA73e7yFPMSJNXsXjwiWLTQQaQZfb9p0B/8tlpEfJu3iGf5auscHR259JCj DFjGbn+MpGNzxmcf1hoKMdQMzt6VMSCBaH5IMxbSDYrIqCT2/z6m4HEDSPZbE9SVgmxWRNMrb1 3Q5DrzKlfhTwEt7HD+Qq9TtQuBw0VJDWAWzFhQH1ZEgZR+l72K4CzuvDp7qdCnmyR1bX2ekOnp ENMLlvkRhfhYd037IzVJE09xszbYAZUVQbSuGX6Amd+C9YhKXdt2c0ld6OSnvyTpdJwnxXR3uI wY0= X-SBRS: 5.2 X-MesageID: 40946663 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:vr2Yba2rJPzdM5SwsIN/MwqjBE0kLtp033Aq2lEZdDV+dMuEm8 ey2MkKzBOcsloscVwDufTFAqmPRnvA6YV4iLN7AZ6OVBTr0VHGEKhM9o3nqgePJwTb+vRG3a ltN4hSYeeAbmRSqcb/7E2GH807wN+BmZrIuc7kw31gTR5nZshbhm8SZzqzKFF8RwVNGPMCZf ihz/dAzgDBRV0nKui9G3kZT6ziirTw5fbbSC9DPTBixCmi5AnYjYLHLw== X-IronPort-AV: E=Sophos;i="5.81,308,1610427600"; d="scan'208";a="40946663" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AlG9DxylwRe43blyWG4UQnRgTrRB5NdYCRXzYTYFDB7PHyz2OZGzO0YjMSyXeSB5BuUf9YACwvH7W1QDSiSLia+Njgt0fkOpEZS3vbZ6UvQsLsHRLkfXYe7D4BxSMsEzWxpSI8xjOMQS1E98L+6PcGRCGCQ/H6frqnDeRnncYp/2F4P+bBtgrxE/0Oy/cev9kXBDGhpMYpxyjbHX0QODSAz9pJoh8kLZlbWv+MDpFUM10E5s9iHhKlCZ+VhbUcLEZ3fBmxQV2TODA1poV4CzpsjV3vIpgDo3mh6McLMkAq85hztDe5p7jp/4IT25bLYOLUta2ionzsOzUYksl1a63w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GC/Nd7vUo+zO40AkbW/KhsU7bPjZbbPFHxSbzenE5pk=; b=VxXRH+0OapZcWHOFHNG7XGXzFeLyLJYKIa+EppdYa0uuiS16qwJsm056KFLzzW56ZUrYsSQw1RhHepTLFXWSGTSkskjGixg4YUyUEhwl1qJSYYDv14kGNfeTMZpK7E+Ag1lWIzwZzV3qzgMdfj2YUqkc4RHougAOD77Bs3tD74EFABSoEA8xni0wV3XosS0Tyr1BKCtmO3SWlvH7Rj8aPDhBDDxhdVQomIOecWvBE/GF/HQ/Ih+CVQadzMqPwh7YQc/jA4LMulab0ENNHk/YNd4FMvomufPpuXS11rvkIiAQSWallZqShb0PUysG8NSUaniRMeTf4PLGY8Hid9Di6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GC/Nd7vUo+zO40AkbW/KhsU7bPjZbbPFHxSbzenE5pk=; b=UMZDrV8M69Z3oIQS80mSLX7X61istfN65I4YiIFaa2w0P2/2BfJzvrPDj79iPYJ+F08NKPJLjexrz4ds3qkQUKn8bCAPpb+3GjUF05++6tNn9LuqNrDwXmkjjOUVcsj4DKj1YfDSWhwwlS+mIwHfO465Lf20fdbPizGNLLXG/dY= Date: Tue, 6 Apr 2021 09:29:19 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Julien Grall CC: , Julien Grall , Jan Beulich , Andrew Cooper , Wei Liu , Ian Jackson Subject: Re: [PATCH 08/14] tools/firmware: hvmloader: Use const in __bug() and __assert_failed() Message-ID: References: <20210405155713.29754-1-julien@xen.org> <20210405155713.29754-9-julien@xen.org> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210405155713.29754-9-julien@xen.org> X-ClientProxiedBy: MR2P264CA0148.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:1::11) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9d176ede-b133-4449-8d59-08d8f8cdb4fe X-MS-TrafficTypeDiagnostic: DM6PR03MB4682: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: w3S72kco+yECnIixrukGcpzWr/cEE7f8CgERzXdqRhVk+vH5KWITPVobzMXsDw+dxSJnJ3RJOGtjJ8pWPlnBPy3yVcs4a20oHrm1Fzc9oTLxYdVzWLvgSiC8850Ay6CRTd85BB0pee9MY6KkYKYPCY/nWEdW8TRegrOx8T2fb9KClLt3jvA2J5z56ACDORSq3iEuWTgWw++chUY0ojRtQZI7+2U0T5oA2bw5/cdPioEICMAmh9CPhcun2LSD5IydQIe9Dt8fPar0xiXNL66qxAE9fnVjlVZEAerxCqqlmbVc5jWG0SjoTJqSY0jOyTQfJ9lL8xCHMCGztqO0s7bzh1cSs5VvY7chWnXUQOuZdfOUeEZoVcOtyrRjQHs+bHhYDsUajrwhJAfjsYhBrF6D5BEBxqmLcanqUtCYOaRV1dtwRFLTVItoCXrnItYGfTOTRT+a/sAgkF0KAeHqNfwTqBzYw5LSdKrXKD5QOpgIoNPx6tb9e9/L4VLLfSvQ+Izo/wM8Rpql3CPmlJY4lljiFdnQgQKPtLaZmma/JzTTGlgiI6EECUJEPqKERm/HTtzSx2blATTGUV7Su7yRAHCvOtnXKfGNt3Ge2A85SvCgedZBZR+8KkqpXVtwQaWEWLPmAPNfk0wsXcZgJGXq80U0nH1TVO5WaY6pFXFUA4h8FeBD+RSyNwcxgaVAYfI/7AYs X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(376002)(136003)(39860400002)(396003)(346002)(2906002)(956004)(4326008)(5660300002)(66946007)(4744005)(86362001)(66556008)(6486002)(6916009)(9686003)(316002)(54906003)(8936002)(478600001)(33716001)(85182001)(66476007)(186003)(26005)(6666004)(16526019)(8676002)(38100700001)(6496006)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?SmlKR0ZiaFZuZ3ZwbVhPeFhkRUVtdUpZNE1PclVJYjNnMzlXNzBGMGtYak5Z?= =?utf-8?B?K2N5TGVNR1dibEk3QTRKb0lVTzRoeVFZQ0hpK3NYR0gxM2QyS1g2WWxVMEVP?= =?utf-8?B?M3BwRTRQRTFDQnlWZHRYbkdhRGFKWlUrUm82bDBNQ2VPMHpxajVORFhheGZK?= =?utf-8?B?VDhWRVhScU5LVTFidTB1ZTY2V2gvMEY5QjhJNVQrdlNhalg3K3JTWDJZUEVw?= =?utf-8?B?b3V5M2NKVHdrdXlESUtTSk5lYVVRLzBrK1BhWHVjU2dKSlRSN3ZRaWpKcEx6?= =?utf-8?B?MzBXYy9YTGdZK1VhVU43R2srQm1LNFh5amNVWnlSbWozOW9Ec1gxMWVrMURu?= =?utf-8?B?ZXpVOFNLUkFtOUQ0RkQ1N3RYdmovbUpzMUEzK1VhbkkvZEgrT2IxSmRNNEZG?= =?utf-8?B?OEhENExHeE5NUW1wTkZIQ0YzdzhkanJMSjBtNDRud0haVW1ZQjc0WEUxa1hS?= =?utf-8?B?elJUQno0cGVnVWJOOXJmbXQwTitZZlgrdi9wYmJpbmNxWWpKaDZyR1lGdXEr?= =?utf-8?B?L2Q1TTNMYkVNMTRLeXZYUExIbTZvenBCTzRFV1hKUzdrSHVhOFd1VkhCWjJK?= =?utf-8?B?Zmw3ZXVLeitkUzNSTGdxUlo3MHNmb3c5NTFVREY3emRuSjlXcEJQQnNDQTg2?= =?utf-8?B?aW04aEZsdnA2NE93WVhUNkJnRU10WTdKK1R4bXU3WEhmTm8vLyt6bDN3dkti?= =?utf-8?B?eWZMVzYyNW9IcFkzQ2pKNmNmNUU4blpwMXZ4SVgzQ216ZXBGcDJjOVhkUEZJ?= =?utf-8?B?OWFuZ2huTndmUXkrMHBENG4vNkE0TkphSlZPOWdMc25NSVE1WFc4TlFaeE8v?= =?utf-8?B?dVVWYVdIc01oN1pzeDB6SEdSWm5iT0ZuMHlpUnVBSlpLbUlzTXdwNjBXQ0o2?= =?utf-8?B?d0VrQ0FqU2duOE93ZXNTa2NuR29aWHkvYnJEN3BqTGlPR3MzRVFuc3pveEZa?= =?utf-8?B?ZHpUWktYR0JNeUJ3djVRNWRUT3RYWTVjOEk5Mi9tWlZHSE12MGc1RkdoZXd0?= =?utf-8?B?NkNhT1lBSzFnMTVmVGE4ZXNsNEpwa0pVanA1T2ZxTVc1Uy9FZkxFclhkSXZN?= =?utf-8?B?SmlHY3ZWM1FVU3Q4NlRPWlBUbWFhODJSZUM3WEZTM20zQW1SL21qNGMrekV4?= =?utf-8?B?Nk1DY2RRZHZVMFBVSkZiYVV4ci85RUlhU2VqcmdiOU13S1JDenVZYnJwSkZa?= =?utf-8?B?bjVLejlWV2szWDUwaG5sV0hKS3pWUWl2TVA3MnlkK25PS2ZOdFN6TWNscTFU?= =?utf-8?B?M0RENmZqTDdKT3BiaVJ5RlhjRzNJL3dWRmNIQkp6M1V3amxYT1ZzY3VPRDY3?= =?utf-8?B?Q1Q1N201UyswUTVqeTZJN2c0eW8rYU1iUFVwdGlqa21yTGJlaWhrVmNnb0Zi?= =?utf-8?B?UHludW9jQ0JDRDlEYUpmeXRyRTd4VWlHbC9aVUErVi9XRUZjWnBnaW81WjNk?= =?utf-8?B?MkFDN0c4U3kxeXpheWp2b1dFVnVXWUtRNUJ1MUk5V1IrK205cVA4Y2cwZnlV?= =?utf-8?B?WFlmUkEyNENEYTZzdWhzeVRvcVE4T1hnODErK0h5eEtFWnVFVVp2OHRuLzNT?= =?utf-8?B?TkdwR3hYaGluUkdHVU5ueHpVNkJQL3BaQis2Z0kzK2dJYW43RWkyYUxRdHhs?= =?utf-8?B?b3MvbElmUDV5YXlqblpZVno0T2lScmw2cm11L3BVM0RpR0c3OTZ6ZVNOMkZq?= =?utf-8?B?Nld2VS91QU1HdVV4b0Z1Uk50VWpEVm53U1hGcVNzLytaVE1TTjlicDdBb1Ru?= =?utf-8?Q?QbNR6/HGlxGlbdym0vJ8CbbQxY9zmfUyMHCS6PM?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9d176ede-b133-4449-8d59-08d8f8cdb4fe X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2021 07:29:26.2784 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3FO2IU6tWCVwiQlWlh2tOH8AQESGcfYWKfJDlvceyo5yrWUpUgMHs9++uaktJq/QXDaG3/QZiSpGOfltSVqgUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4682 X-OriginatorOrg: citrix.com On Mon, Apr 05, 2021 at 04:57:07PM +0100, Julien Grall wrote: > From: Julien Grall > > __bug() and __assert_failed() are not meant to modify the string > parameters. So mark them as const. > > Signed-off-by: Julien Grall Reviewed-by: Roger Pau Monné While looking at this I think we should also make the line parameter unsigned, but again doesn't need to be part of this patch. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Apr 06 07:40:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Apr 2021 07:40:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105653.202070 (Exim 4.92) (envelope-from ) id 1lTgKH-0000uA-M0; Tue, 06 Apr 2021 07:40:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105653.202070; Tue, 06 Apr 2021 07:40:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTgKH-0000u3-It; Tue, 06 Apr 2021 07:40:41 +0000 Received: by outflank-mailman (input) for mailman id 105653; Tue, 06 Apr 2021 07:40:39 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTgKF-0000ty-Is for xen-devel@lists.xenproject.org; Tue, 06 Apr 2021 07:40:39 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 91e4aaed-fa06-48fd-96ba-223fd7648f79; Tue, 06 Apr 2021 07:40:38 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9119EB013; Tue, 6 Apr 2021 07:40:37 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 91e4aaed-fa06-48fd-96ba-223fd7648f79 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617694837; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qiGvOmOcRxUSbOGwO40D2AIMHnVfU1thnCDMr4W8rEI=; b=g2sHFeMS1lvRDaPKK26/pmdN5tJylETBoEESgLHKuNscAuMmpiPnf5Xzy+oTTqBXEv0Cyz BYpl4qZawqIg79cC7/slo0ufeKv+GJkns/MS4uI8CyggyMvDTWY+WWqbLvX3MCZYV0EAJa 2qjJMlsMoQvjkqh0PZ38f78Oup9koA0= Subject: Re: [PATCH 2/2] xen/gunzip: Allow perform_gunzip() to be called multiple times To: Julien Grall Cc: bertrand.marquis@arm.com, Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20210402152105.29387-1-julien@xen.org> <20210402152105.29387-3-julien@xen.org> From: Jan Beulich Message-ID: <43460d2d-b259-5010-62a7-47ded0ec623b@suse.com> Date: Tue, 6 Apr 2021 09:40:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210402152105.29387-3-julien@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 02.04.2021 17:21, Julien Grall wrote: > From: Julien Grall > > Currently perform_gunzip() can only be called once because the > the internal state (e.g allocate) is not fully re-initialized. > > This works fine if you are only booting dom0. But this will break when > booting multiple using the dom0less that uses compressed kernel images. > > This can be resolved by re-initializing bytes_out, malloc_ptr, > malloc_count every time perform_gunzip() is called. > > Note the latter is only re-initialized for hardening purpose as there is > no guarantee that every malloc() are followed by free() (It should in > theory!). > > Take the opportunity to check the return of alloc_heap_pages() to return > an error rather than dereferencing a NULL pointer later on failure. > > Reported-by: Charles Chiou > Signed-off-by: Julien Grall Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue Apr 06 07:45:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Apr 2021 07:45:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105658.202083 (Exim 4.92) (envelope-from ) id 1lTgPI-00016x-9v; Tue, 06 Apr 2021 07:45:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105658.202083; Tue, 06 Apr 2021 07:45:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTgPI-00016q-6P; Tue, 06 Apr 2021 07:45:52 +0000 Received: by outflank-mailman (input) for mailman id 105658; Tue, 06 Apr 2021 07:45:50 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTgPG-00016l-TF for xen-devel@lists.xenproject.org; Tue, 06 Apr 2021 07:45:50 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5ca01984-3766-4172-a421-be673badd0cc; Tue, 06 Apr 2021 07:45:50 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 35B3CAF5A; Tue, 6 Apr 2021 07:45:49 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5ca01984-3766-4172-a421-be673badd0cc X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617695149; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g1SCRcNKBxEFCPFDNOXIJ+kQKt2OChDK6vWjs45jKWk=; b=boORjMmZjvdjw3TfEW5NA94l+9J3/NFoSyI8Mg+ObLFWgcMGy8zsxi8idG7mRGbZ5BisSi JZ1HIGlWrq9jn1+zgqhpUdW8El34qVqaN85M3Z5OLp4co7CN1M2s4wNzvrtTzT2xzeRwjB uMan7Mf8N9T4paVWDuNksDGJiaD1Mjs= Subject: Re: [PATCH 0/2] xen/arm: Couple of bug fixes when decompressing kernels To: Julien Grall Cc: bertrand.marquis@arm.com, Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , xen-devel@lists.xenproject.org References: <20210402152105.29387-1-julien@xen.org> From: Jan Beulich Message-ID: <7a65f71b-e5a6-22aa-d360-4045b266229e@suse.com> Date: Tue, 6 Apr 2021 09:45:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210402152105.29387-1-julien@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 02.04.2021 17:21, Julien Grall wrote: > From: Julien Grall > > Hi all, > > The main goal of this series is to address the bug report [1]. It is not > possible ...? > While testing the series, I also noticed that it is not possible to > re-use the same compressed kernel for multiple domains as the module > will be overwritten during the first decompression. > > I am still a bit undecided how to fix it. We can either create a new > module for the uncompressed kernel and link with the compressed kernel. > Or we could decompress everytime. > > One inconvenience to kernel to only decompress once is we have to keep > it until all the domains have booted. This may means a lot of memory to be > wasted just for keeping the uncompressed kernel (one my setup, it takes > ~3 times more space). > > Any opinions on how to approach it? Well, it's not "until all the domains have booted", but until all the domains have had their kernel image placed in the designated piece of memory. So while for the time being multiple decompression may indeed be a reasonable approach, longer term one could populate all the domains' memory in two steps - first just the kernel space for all of them, then load the kernel(s), then populate the rest of the memory. Jan From xen-devel-bounces@lists.xenproject.org Tue Apr 06 07:50:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Apr 2021 07:50:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105663.202095 (Exim 4.92) (envelope-from ) id 1lTgTz-0001yF-Tf; Tue, 06 Apr 2021 07:50:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105663.202095; Tue, 06 Apr 2021 07:50:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTgTz-0001y8-Pk; Tue, 06 Apr 2021 07:50:43 +0000 Received: by outflank-mailman (input) for mailman id 105663; Tue, 06 Apr 2021 07:50:43 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTgTy-0001y3-Uy for xen-devel@lists.xenproject.org; Tue, 06 Apr 2021 07:50:42 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 825afaef-827f-4d03-bf4e-d7c001191e12; Tue, 06 Apr 2021 07:50:42 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8B9D1AFCB; Tue, 6 Apr 2021 07:50:41 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 825afaef-827f-4d03-bf4e-d7c001191e12 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617695441; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XEbKX/Z1ETdz+l1++th0T2qOpGnkM3VaHCw6qeEZGt4=; b=WaWbsrn2ZuLWhNWodEyEB/p0zQfyLi/1M3nqb/OAP80ypUdgjgyt4LYSawdVXj7rUPa4w8 CA1WeSp+2lhtsXM4s6hKqEZ+T3NGaGQhFedvbnCQMLFHRUEknu3/eWlYK2n/OW6GSikzUf kVXyDqAfGQHNcqbK7+RZHIpAc+8mcDY= Subject: Re: [PATCH 00/14] Use const whether we point to literal strings (take 1) To: Julien Grall Cc: Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , Dario Faggioli , Tim Deegan , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Anthony PERARD , xen-devel@lists.xenproject.org References: <20210405155713.29754-1-julien@xen.org> From: Jan Beulich Message-ID: Date: Tue, 6 Apr 2021 09:50:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210405155713.29754-1-julien@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05.04.2021 17:56, Julien Grall wrote: > From: Julien Grall > > Hi all, > > By default, both Clang and GCC will happily compile C code where > non-const char * point to literal strings. This means the following > code will be accepted: > > char *str = "test"; > > str[0] = 'a'; > > Literal strings will reside in rodata, so they are not modifiable. > This will result to an permission fault at runtime if the permissions > are enforced in the page-tables (this is the case in Xen). > > I am not aware of code trying to modify literal strings in Xen. > However, there is a frequent use of non-const char * to point to > literal strings. Given the size of the codebase, there is a risk > to involuntarily introduce code that will modify literal strings. > > Therefore it would be better to enforce using const when pointing > to such strings. Both GCC and Clang provide an option to warn > for such case (see -Wwrite-strings) and therefore could be used > by Xen. > > This series doesn't yet make use of -Wwrite-strings because > the tree is not fully converted. Instead, it contains some easy > and likely non-controversial use const in the code. > > The major blockers to enable -Wwrite-strings are the following: > - xen/common/efi: union string is used in both const and > non-const situation. It doesn't feel right to specific one member > const and the other non-const. I'd be happy to see a suggestion of how to avoid this in a not overly intrusive way. > - libxl: the major block is the flexarray framework as we would use > it with string (now const char*). I thought it would be possible to > make the interface const, but it looks like there are a couple of > places where we need to modify the content (such as in > libxl_json.c). > > Ideally, I would like to have -Wwrite-strings unconditionally used > tree-wide. But, some of the area may required some heavy refactoring. > > One solution would be to enable it tree-wide but turned it off at a > directroy/file level. At least as a transient approach I think this would make sense. EFI in particular has other reasons already to specify a custom option (-fshort-wchar). Jan From xen-devel-bounces@lists.xenproject.org Tue Apr 06 07:57:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Apr 2021 07:57:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105669.202107 (Exim 4.92) (envelope-from ) id 1lTgaU-0002CC-JM; Tue, 06 Apr 2021 07:57:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105669.202107; Tue, 06 Apr 2021 07:57:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTgaU-0002C4-GF; Tue, 06 Apr 2021 07:57:26 +0000 Received: by outflank-mailman (input) for mailman id 105669; Tue, 06 Apr 2021 07:57:25 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTgaT-0002Bw-Dn for xen-devel@lists.xenproject.org; Tue, 06 Apr 2021 07:57:25 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b37bdff3-65e0-4534-aad8-72b7a68e097e; Tue, 06 Apr 2021 07:57:24 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id BC57CB12A; Tue, 6 Apr 2021 07:57:23 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b37bdff3-65e0-4534-aad8-72b7a68e097e X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617695843; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EOsNinbCvHtgx2zCpCcQBiUJ0C9jVc1IKprXgBnJ0Z0=; b=HykimJKD4vBf8e7D8flZmBDMyTYStHylthGMsgfZbAFOtX0yCbJRsNbQ8lDMvS0kGttj3n EgU8ikQ1lUvtrX5PL9iuDKgec7rcMyMnVPlU4RTadLqVoBeDdySxbgK3AgUBVrKhH9b+iv ds8iZFPvjetPcn32d+ZYD/+HuSzQgoY= Subject: Re: [PATCH 01/14] xen: Constify the second parameter of rangeset_new() To: Julien Grall Cc: Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20210405155713.29754-1-julien@xen.org> <20210405155713.29754-2-julien@xen.org> From: Jan Beulich Message-ID: Date: Tue, 6 Apr 2021 09:57:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210405155713.29754-2-julien@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05.04.2021 17:57, Julien Grall wrote: > From: Julien Grall > > The string 'name' will never get modified by the function, so mark it > as const. > > Signed-off-by: Julien Grall Reviewed-by: Jan Beulich > --- a/xen/common/rangeset.c > +++ b/xen/common/rangeset.c > @@ -421,7 +421,7 @@ bool_t rangeset_is_empty( > } > > struct rangeset *rangeset_new( > - struct domain *d, char *name, unsigned int flags) > + struct domain *d, const char *name, unsigned int flags) > { > struct rangeset *r; Remotely along these lines the function also has no need anymore to use snprintf() - safe_strcpy() very well fits both purposes. But quite likely for another patch. Jan From xen-devel-bounces@lists.xenproject.org Tue Apr 06 08:07:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Apr 2021 08:07:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105679.202119 (Exim 4.92) (envelope-from ) id 1lTgjk-0003he-Ni; Tue, 06 Apr 2021 08:07:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105679.202119; Tue, 06 Apr 2021 08:07:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTgjk-0003hX-JL; Tue, 06 Apr 2021 08:07:00 +0000 Received: by outflank-mailman (input) for mailman id 105679; Tue, 06 Apr 2021 08:06:58 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTgji-0003hS-Ig for xen-devel@lists.xenproject.org; Tue, 06 Apr 2021 08:06:58 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3ba5ffdd-a4ec-465a-8274-13cf2507fe51; Tue, 06 Apr 2021 08:06:57 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E3DDCAFCB; Tue, 6 Apr 2021 08:06:56 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ba5ffdd-a4ec-465a-8274-13cf2507fe51 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617696417; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MIS3ZmqM+YwG/nmancgSNx2znAgMGmwMb0QdegUPzk8=; b=E+yPFAvWfithZm8M4A1hGR4ZBZ8OC4FPaUWBbn7yvtpEYu9x1zXFkDtaD8lwXyOPInTLdJ IZi44/27k5hsZiqAjlMYN0UwWXOY85MdUyD75OCRz0/+esgI5YKPLBc/LaLVTEDCIZTKHz 5M10x5tea4NfY8Z/2yz+MfBSSkc/rLw= Subject: Re: [PATCH 02/14] xen/sched: Constify name and opt_name in struct scheduler To: Julien Grall Cc: Julien Grall , George Dunlap , Dario Faggioli , xen-devel@lists.xenproject.org References: <20210405155713.29754-1-julien@xen.org> <20210405155713.29754-3-julien@xen.org> From: Jan Beulich Message-ID: <5618bed6-a213-d2c9-4cbf-d95cb4dc02b4@suse.com> Date: Tue, 6 Apr 2021 10:07:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210405155713.29754-3-julien@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05.04.2021 17:57, Julien Grall wrote: > From: Julien Grall > > Both name and opt_name are pointing to literal string. So mark both of > the fields as const. > > Signed-off-by: Julien Grall Reviewed-by: Jan Beulich albeit ... > --- a/xen/common/sched/private.h > +++ b/xen/common/sched/private.h > @@ -272,8 +272,8 @@ static inline spinlock_t *pcpu_schedule_trylock(unsigned int cpu) > } > > struct scheduler { > - char *name; /* full name for this scheduler */ > - char *opt_name; /* option name for this scheduler */ > + const char *name; /* full name for this scheduler */ > + const char *opt_name; /* option name for this scheduler */ ... I'd like to suggest considering at least the latter to become an array instead of a pointer - there's little point wasting 8 bytes of storage for the pointer when the strings pointed to are all at most 9 bytes long (right now; I don't expect much longer ones to appear). Jan From xen-devel-bounces@lists.xenproject.org Tue Apr 06 08:10:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Apr 2021 08:10:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105686.202130 (Exim 4.92) (envelope-from ) id 1lTgmx-0004Zy-BO; Tue, 06 Apr 2021 08:10:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105686.202130; Tue, 06 Apr 2021 08:10:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTgmx-0004Zr-8W; Tue, 06 Apr 2021 08:10:19 +0000 Received: by outflank-mailman (input) for mailman id 105686; Tue, 06 Apr 2021 08:10:18 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTgmv-0004Zm-Ua for xen-devel@lists.xenproject.org; Tue, 06 Apr 2021 08:10:17 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id bd38c486-1bed-4ecc-8e17-37e36dcf9d49; Tue, 06 Apr 2021 08:10:17 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 947A3B0C6; Tue, 6 Apr 2021 08:10:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bd38c486-1bed-4ecc-8e17-37e36dcf9d49 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617696616; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zG0LLFY+tU19ClXuT00E9c31o4nZ1CrujqJZ8DUtc0Q=; b=tRl8/dkbVx72x0a8/dlPu1xHnnwq4ckascB1ByFNVO1rVtDG+xg1rqcaaLAGSRAgaDZU/Q hXNfTS+h/xfLzeAmEFq1Ir0mMifuWbcHxjj7G6urT520cjJ4McSG59A0DgZ3TSUBgXuqcZ 1Do3ByDFQ1P7Q2oGbZTCTF1to3b5R6c= Subject: Re: [PATCH 04/14] xen/char: console: Use const whenever we point to literal strings To: Julien Grall Cc: Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20210405155713.29754-1-julien@xen.org> <20210405155713.29754-5-julien@xen.org> From: Jan Beulich Message-ID: <507452bf-9a9c-a48c-d8f5-cba99ac2e646@suse.com> Date: Tue, 6 Apr 2021 10:10:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210405155713.29754-5-julien@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05.04.2021 17:57, Julien Grall wrote: > --- a/xen/drivers/char/console.c > +++ b/xen/drivers/char/console.c > @@ -168,7 +168,7 @@ static int parse_guest_loglvl(const char *s); > static char xenlog_val[LOGLVL_VAL_SZ]; > static char xenlog_guest_val[LOGLVL_VAL_SZ]; > > -static char *lvl2opt[] = { "none", "error", "warning", "info", "all" }; > +static const char *lvl2opt[] = { "none", "error", "warning", "info", "all" }; If you add any const here, then I think you should go to full way and also add the second missing one. Then Reviewed-by: Jan Beulich Arguably the array should also be local to xenlog_update_val(). Jan From xen-devel-bounces@lists.xenproject.org Tue Apr 06 08:19:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Apr 2021 08:19:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105691.202142 (Exim 4.92) (envelope-from ) id 1lTgva-0004og-7o; Tue, 06 Apr 2021 08:19:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105691.202142; Tue, 06 Apr 2021 08:19:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTgva-0004oZ-4e; Tue, 06 Apr 2021 08:19:14 +0000 Received: by outflank-mailman (input) for mailman id 105691; Tue, 06 Apr 2021 08:19:13 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTgvZ-0004oU-AQ for xen-devel@lists.xenproject.org; Tue, 06 Apr 2021 08:19:13 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3ff048b1-9b51-45e9-b074-3db47ea43af8; Tue, 06 Apr 2021 08:19:12 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7178FB0B7; Tue, 6 Apr 2021 08:19:11 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ff048b1-9b51-45e9-b074-3db47ea43af8 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617697151; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O1MsyF6f/jXjbaMOsUf7g78jDGOjiDV17R4ULgvuVgo=; b=qqSlZHT3ojYZSOToLD/KiNxLV0dEkyVaJfnl7/76QrrjPgDj3UgNVo/z/6MWv/Ytas6f46 mZfqkoQMxGQzv/RBklgw+6XU8jX6KQndTGCrjqL7VTlD2k1TWMRqwNfihF9NO7ACbZuxx4 +0rSe/zoB/QhTCWL9C2QxQYVlN/HBv4= Subject: Re: multiboot2 and module2 boot issues via GRUB2 To: Andrew Cooper Cc: Roman Shaposhnik , Xen-devel , grub-devel@gnu.org, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <23baec07-a3ae-949a-a1fb-09100efd53e5@citrix.com> From: Jan Beulich Message-ID: Date: Tue, 6 Apr 2021 10:19:14 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 01.04.2021 21:43, Andrew Cooper wrote: > On 01/04/2021 09:44, Roger Pau Monné wrote: >> On Thu, Apr 01, 2021 at 09:31:07AM +0200, Jan Beulich wrote: >>> On 01.04.2021 03:06, Roman Shaposhnik wrote: >>>> And the obvious next question: is my EVE usecase esoteric enough that >>>> I should just go ahead and do a custom GRUB patch or is there a more >>>> general interest in this? >>> Not sure if it ought to be a grub patch - the issue could as well >>> be dealt with in Xen, by concatenating modules to form a monolithic >>> initrd. >> I would rather have it done in the loader than Xen, mostly because >> it's a Linux boot specific format, and hence I don't think Xen should >> have any knowledge about it. >> >> If it turns out to be impossible to implement on the loader side we >> should consider doing it in Xen, but that's not my first option. > > Concatenating random things which may or may not be initrds is > absolutely not something Xen should do.  We don't have enough context to > do it safely/sensibly. Well, I wasn't suggesting anywhere to concatenate random things. Instead I was envisioning a command line option giving us the context we need (e.g. "initrd=3+5"). Jan From xen-devel-bounces@lists.xenproject.org Tue Apr 06 08:47:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Apr 2021 08:47:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105701.202158 (Exim 4.92) (envelope-from ) id 1lThMV-0007T4-I5; Tue, 06 Apr 2021 08:47:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105701.202158; Tue, 06 Apr 2021 08:47:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lThMV-0007Sx-EG; Tue, 06 Apr 2021 08:47:03 +0000 Received: by outflank-mailman (input) for mailman id 105701; Tue, 06 Apr 2021 08:47:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lThMU-0007Sp-8l; Tue, 06 Apr 2021 08:47:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lThMU-0002dP-1k; Tue, 06 Apr 2021 08:47:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lThMT-00077y-Ni; Tue, 06 Apr 2021 08:47:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lThMT-0000Gh-NE; Tue, 06 Apr 2021 08:47:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=k1RWlb033urEHx9GIrgBmqR8yhu4EQpVsMsY7ARRZDE=; b=HwlXLkKngxzc4PRsyUaAt/wEAw 1ynJtxE3V8pZfLdFGLKDpltK74KHJWYatIJZ0xIOFEV6sCDJW9GolCmQz+WST3gG05uXDfwjELyT+ XdCNh4h0dSQUd9T+nlEA8i6KCZXkujIWk30EyohxNRTVUotQsrwDjLGAfmYFKD+YKubc=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 160761: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=2fc3a704e7083afab0537cf0777521afa9cc1db6 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Tue, 06 Apr 2021 08:47:01 +0000 flight 160761 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/160761/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt 2fc3a704e7083afab0537cf0777521afa9cc1db6 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 270 days Failing since 151818 2020-07-11 04:18:52 Z 269 days 262 attempts Testing same since 160661 2021-04-02 04:19:00 Z 4 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei simmon Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin WangJian Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yaroslav Kargin Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 49860 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Apr 06 08:50:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Apr 2021 08:50:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105706.202173 (Exim 4.92) (envelope-from ) id 1lThPr-0008Jq-2G; Tue, 06 Apr 2021 08:50:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105706.202173; Tue, 06 Apr 2021 08:50:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lThPq-0008Jj-VP; Tue, 06 Apr 2021 08:50:30 +0000 Received: by outflank-mailman (input) for mailman id 105706; Tue, 06 Apr 2021 08:50:30 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lThPq-0008Je-CB for xen-devel@lists.xenproject.org; Tue, 06 Apr 2021 08:50:30 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e3d3f93f-2b6e-4e6c-a03b-ae529ff7086c; Tue, 06 Apr 2021 08:50:29 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C48E1AE06; Tue, 6 Apr 2021 08:50:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e3d3f93f-2b6e-4e6c-a03b-ae529ff7086c X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617699028; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5u7mnATsOHEwtJcO87Og7ZVqkhZiBkCd9r/JcsIFqzw=; b=bbGRrpgfrWtcCoeepinsT0AQkm/Siwr6fgDqubRVJErNzhkwlV7OXM0SPYQPlwFfF5xbOj 2Nrztxp//upBl0e/SYOoViKWAebj5k8KuAq/JvCOqFzh2y86NSVI30jiHDH0kyDPEz2gPb kXOSAviWRvTZJjbcKKsEVB/QAvtEL9Q= To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu From: Jan Beulich Subject: [PATCH] rangeset: no need to use snprintf() Message-ID: <2338703b-3613-41c6-8ae6-387ba2869408@suse.com> Date: Tue, 6 Apr 2021 10:50:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit As of the conversion to safe_strcpy() years ago there has been no need anymore to use snprintf() to prevent storing a not-nul-terminated string. Signed-off-by: Jan Beulich --- a/xen/common/rangeset.c +++ b/xen/common/rangeset.c @@ -436,14 +436,7 @@ struct rangeset *rangeset_new( BUG_ON(flags & ~RANGESETF_prettyprint_hex); r->flags = flags; - if ( name != NULL ) - { - safe_strcpy(r->name, name); - } - else - { - snprintf(r->name, sizeof(r->name), "(no name)"); - } + safe_strcpy(r->name, name ?: "(no name)"); if ( (r->domain = d) != NULL ) { From xen-devel-bounces@lists.xenproject.org Tue Apr 06 08:52:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Apr 2021 08:52:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105712.202188 (Exim 4.92) (envelope-from ) id 1lThRl-0008Ub-Go; Tue, 06 Apr 2021 08:52:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105712.202188; Tue, 06 Apr 2021 08:52:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lThRl-0008UU-Cs; Tue, 06 Apr 2021 08:52:29 +0000 Received: by outflank-mailman (input) for mailman id 105712; Tue, 06 Apr 2021 08:52:28 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lThRk-0008UP-A7 for xen-devel@lists.xenproject.org; Tue, 06 Apr 2021 08:52:28 +0000 Received: from mail-wr1-x431.google.com (unknown [2a00:1450:4864:20::431]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b3ae95d4-c32e-4159-bc3e-52f3b204efb9; Tue, 06 Apr 2021 08:52:27 +0000 (UTC) Received: by mail-wr1-x431.google.com with SMTP id e12so242108wro.11 for ; Tue, 06 Apr 2021 01:52:26 -0700 (PDT) Received: from dell ([91.110.221.193]) by smtp.gmail.com with ESMTPSA id i8sm32058595wrx.43.2021.04.06.01.52.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 01:52:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b3ae95d4-c32e-4159-bc3e-52f3b204efb9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=3BgNDMl40dnCwKRmhOLm+B9cf4ULCtKCWabOrS4ebcw=; b=Asdziv4oEb1GmkAaeVVDLWI3Znln2RaErCLNpsXLzuYFdOjFmI+wtm1ABBb8Qzrhny TcmAdlweTBezZn6bLWI5bxAO6sixQ1qoRcBGyyLqdiQLPIYhlFyN1h+5meYfiH4JkWto p6pFe2LqKb8alZFUYIMjJAMVfORnDXryC0wNScdPtyGiNK6QyfD0bVL+lTSMwej9pLcV iQzMPvscomIPMUzjFxPNO4iPBn4L4vhotDqv492YkhoERqcLIfLNP5vCfCnxSMMP6sSJ KcvhK8JYrWbX7nPWHQ5J91FkPJXnbjYB6Ap1ZgdEBSg2YwCnF2NloEpC1gpS/cLHXxVn QScw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=3BgNDMl40dnCwKRmhOLm+B9cf4ULCtKCWabOrS4ebcw=; b=FxJSYKCOF0TmpCyGgJTRhJhnZkl/aOrLXM4ARyaknun7i9ouY/RywVyvwOvUYoFaly riEItBMEOQ1wVMs88dgK21Yknp36/Gjkcg6Wrhf7foJ6w91nFtlALjARMgNzFqcw2xsD QxqXccsuqI5gteQP887WsCFtlHXWyF4ve/MAy6VBl+Uue4nZv7G/Oul/FwbbDuLGNzv2 UnF2VDBrZ+Y3drAOucOk9Byh2pwSkj2AWmI2GMo2UDfdvIcbThc8VcLDlGsTiJfqL/dC 4W2nFo9bYxCl2QkTqMUKlhA+j+ZOVmWQ+yNR2Do6e3q7W6fHGlhlg4g1lfBD6XBjXM6O wtaw== X-Gm-Message-State: AOAM531u1fw3EZ6S4TaPcb802a/gOICN9I3x2H/+FrFMDGjnZLesfnVY eN/64e+p1aJ++cpbi2fhd8kfLQ== X-Google-Smtp-Source: ABdhPJyxLFG0M7WFSnkeNEm7vMCed81i1TOhAivLtyeLJw56m312VuEzXAMWCWyLobQLxSOjXKutyg== X-Received: by 2002:adf:90f0:: with SMTP id i103mr32839523wri.318.1617699146143; Tue, 06 Apr 2021 01:52:26 -0700 (PDT) Date: Tue, 6 Apr 2021 09:52:23 +0100 From: Lee Jones To: linux-kernel@vger.kernel.org, Boris Ostrovsky , drbd-dev@lists.linbit.com, Jens Axboe , Joshua Morris , Juergen Gross , Konrad Rzeszutek Wilk , Lars Ellenberg , linux-block@vger.kernel.org, Philip Kelleher , Philipp Reisner , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Stefano Stabellini , xen-devel@lists.xenproject.org Subject: Re: [PATCH 00/11] Rid W=1 warnings from Block Message-ID: <20210406085223.GR2916463@dell> References: <20210312105530.2219008-1-lee.jones@linaro.org> <20210330132130.GK2916463@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210330132130.GK2916463@dell> On Tue, 30 Mar 2021, Lee Jones wrote: > On Fri, 12 Mar 2021, Lee Jones wrote: > > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > > > Lee Jones (11): > > block: rsxx: core: Remove superfluous const qualifier > > block: drbd: drbd_interval: Demote some kernel-doc abuses and fix > > another header > > block: mtip32xx: mtip32xx: Mark debugging variable 'start' as > > __maybe_unused > > block: drbd: drbd_state: Fix some function documentation issues > > block: drbd: drbd_receiver: Demote non-conformant kernel-doc headers > > block: drbd: drbd_main: Remove duplicate field initialisation > > block: drbd: drbd_nl: Make conversion to 'enum drbd_ret_code' explicit > > block: drbd: drbd_main: Fix a bunch of function documentation > > discrepancies > > block: drbd: drbd_receiver: Demote less than half complete kernel-doc > > header > > block: xen-blkfront: Demote kernel-doc abuses > > block: drbd: drbd_nl: Demote half-complete kernel-doc headers > > Would you like me to resubmit these? It's been 3.5 weeks since these were submitted. We are now at -rc6, so these should be merged soon. Is there anything you'd like me to do to help? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From xen-devel-bounces@lists.xenproject.org Tue Apr 06 09:06:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Apr 2021 09:06:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105724.202200 (Exim 4.92) (envelope-from ) id 1lThfI-00018K-U3; Tue, 06 Apr 2021 09:06:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105724.202200; Tue, 06 Apr 2021 09:06:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lThfI-00018D-Qg; Tue, 06 Apr 2021 09:06:28 +0000 Received: by outflank-mailman (input) for mailman id 105724; Tue, 06 Apr 2021 09:06:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lThfH-000185-Ho; Tue, 06 Apr 2021 09:06:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lThfH-0002yk-88; Tue, 06 Apr 2021 09:06:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lThfG-0007ii-W1; Tue, 06 Apr 2021 09:06:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lThfG-0005cH-VS; Tue, 06 Apr 2021 09:06:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=shW1A4LbaSfzfW1PBgHyPHuJiNLAHQgnqblrNZ4X2so=; b=QkSu93q+MqdAVeUN+FHqGQeLky ztuUWOnQKbnn3amSxgGp4trQ1EwaPNp0xE55ySw3VuS0EKE7jpN2fLe6hT5iL2Y4boE5jzywsWhwY wMN62Sg9o3vkImUwxjRSUjDAZ+fQ4JYYKwqgssh+sI8ttXZEYgt7akxb//gewoOJ6bSo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 160757: all pass - PUSHED X-Osstest-Versions-This: ovmf=4ac02962017c77bf38b462f970c884c2dc7931cf X-Osstest-Versions-That: ovmf=f95cdd316c3d56e8f76b5044be54b9645e1dc60f From: osstest service owner Date: Tue, 06 Apr 2021 09:06:26 +0000 flight 160757 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/160757/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 4ac02962017c77bf38b462f970c884c2dc7931cf baseline version: ovmf f95cdd316c3d56e8f76b5044be54b9645e1dc60f Last test of basis 160687 2021-04-03 01:55:05 Z 3 days Testing same since 160757 2021-04-06 01:11:18 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jiaxin Wu Zhang Hongbin1 jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git f95cdd316c..4ac0296201 4ac02962017c77bf38b462f970c884c2dc7931cf -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Apr 06 09:09:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Apr 2021 09:09:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105729.202215 (Exim 4.92) (envelope-from ) id 1lThiI-0001IB-EY; Tue, 06 Apr 2021 09:09:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105729.202215; Tue, 06 Apr 2021 09:09:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lThiI-0001I4-B7; Tue, 06 Apr 2021 09:09:34 +0000 Received: by outflank-mailman (input) for mailman id 105729; Tue, 06 Apr 2021 09:09:32 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lThiF-0001Hw-VE for xen-devel@lists.xenproject.org; Tue, 06 Apr 2021 09:09:32 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5a879349-f200-47de-9be9-8e3efacf9c5f; Tue, 06 Apr 2021 09:09:30 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a879349-f200-47de-9be9-8e3efacf9c5f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617700170; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=VNu3Oxb0+wnZs4qKmrS/q4mFGlDFsROdeBbj4/ByVT4=; b=O7KKIONIYP8J2FbrzOX0MU/5NxHxzsakt9c7uqYPit1V00rrygr5AwZx 0PGnBMxucsgxq9M2XBGspIfTo2VGCiprPmLhTcQ+3JAJxNWa5d/Mc/snX Dz7hLRQOAxR8rOXjWr4WB0Q0NVTwF6lUIzsy40903cPYOEy4UAP/RHnpf 0=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: KjS5IpdQ5jlXtWB7FqaBEtSmtknOZjyadZOVxQ9cRTSSopydjPIGRZyozBe7FhbmLpUqNcOGeD Nos5Wkq4OLFtBs6qv23wWY0YGSp3Bp5C8qQdKv6yTHqtJ9MycX3vjAE/v4kqi/4pmFczo2xWkB DuZtA8ndGyTciy5wYY8ZOdhm5oENGbkeDhF/7R5HRaRDuBA+PhiHwELzh4U2TZBfHJos9t4vJs f2DSSVI9hgz+dtcoEiMZ6Js3MjXG/4uhWVtsbpyxxj7hxdxzSLtKox7kN5H/LiVpGmL846O7UU mZg= X-SBRS: 5.2 X-MesageID: 40938035 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:n45OhagzEBTRt9P8W5/WrFvOGHBQX7N13DAbvn1ZSRFFG/Gwv8 qlkO0HkTr9jzgMUH8t8OrwX5Woa1m0z/FIyKMWOqqvWxSjnWOuIp1r44eK+UyHJwTV8OlB2a B8N5VvEdGYNykBse/W6BS1euxQo+Wv37uvgY7loktFbQYvUK146hc8NwDzKDwTeCBjJb4UUK WR/dBGoT3IQwVrUu2eCmMeV+bO4/3n/aiWAyIuPBIs5AmQgT7A0teTeHKl9ywTXD9VzbAp/X KtqX2d2oyYr/q5xhXAvlW8071qmcDswtYGJMuAhtl9EFXRozuof4hoVvm+uik0qoiUiWoCrd +kmXsdFvU2z0mUX2mu5TPxxgHr0V8Vmgbf4G7dpUGmnOvUa3YRDdFbiYdQbx3DgnBQxO1Uwe ZMxGKWt51eEBPGkmD8/rHzJmpXqnY= X-IronPort-AV: E=Sophos;i="5.81,309,1610427600"; d="scan'208";a="40938035" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ck3cJktkKirISMHpSGmISpWGVlSipjdm9xI14M54jIIITBmN3JmI6yxHsLV3OsC4yZ/RfEs8Nd767H18jefqtUUJdo/eTK9kngDOxRpYw6g4lMEfngfAMQA4oARWC68WGy+RUG733jXjWbjQGHFGbqtfcwQnfwNcScODNxLdsYtfPXXHW1gYPJB8X4i9oYPNqtLHLAJHjD+QVvb4np/CaZX/Kbs1H7Om0PsOuDE3feymmf7Tx++bdKz/rT295uLZXCxLBcI2lh5XtBfKxOra6U3wajqAAF13EW5GmWlTTjavz/lNeHNLwEqxCWPDOph8UVN4COsIBVtoOdApMdIdsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7z7WMDrE7g3ZUqn8Gbw2JUMn4tnRJm1w3CiFvtFGwbU=; b=Fzz172QEK0KAy/z+4RPY2j4y4w9Pq8NIYfRy8VdgRjo8UlxTTGHgMJh/D8xv8FDhaO4pg2SIY+XJ29GF4Hedxa+j/8cjUuTraRcOkHsT2TkjgkkS0FyhAz4XycToFZ0PMoUfPKsmx7hnJjMfglMHoZQ7O1sZX6NR5bhmJhI49AVTgCknB+fww84C3o+aO/GVQ64hyXfZhA6ho3bgDJDuDMuJ7D7KaAS5BdWoYZQlSFMl/iwLkOisfoO39UAWboRkc2JawD8cinMgHRAtgukohFxnuJyiLgQtoOmzVqtpUpZw7mDkQghJOlU/6RPYrnEI/5eBf3ytCkkCdc7fPr2xfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7z7WMDrE7g3ZUqn8Gbw2JUMn4tnRJm1w3CiFvtFGwbU=; b=pFN4WGflltsAi/Xr2sRwQN+cw92vNGzoCY5Hlo0CGBLMwX1BTp8FtoIZUpQtKpIYC8WUG7nrolVUrEfbEYzjMiMupuI77M23bxoLzJMmtPpfgiw5BvVcyPC1dz37xRrV9tU8znbx3JNTJgaqVzvKjnoa8vV0G+X+OOubswIxkSM= Date: Tue, 6 Apr 2021 11:09:19 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Lee Jones CC: , Konrad Rzeszutek Wilk , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Jens Axboe , , Subject: Re: [PATCH 10/11] block: xen-blkfront: Demote kernel-doc abuses Message-ID: References: <20210312105530.2219008-1-lee.jones@linaro.org> <20210312105530.2219008-11-lee.jones@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210312105530.2219008-11-lee.jones@linaro.org> X-ClientProxiedBy: MR2P264CA0034.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500::22) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: db911e2a-8520-4476-3013-08d8f8dbad98 X-MS-TrafficTypeDiagnostic: DM6PR03MB4476: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NB6ewCwzTzxrBmCk7Aa0YxsSwzzU+++x4rrM///D2KnhYVwWDdSzJkt95tBWOCtm+3we6jD4Q8b+NAvIhYRnkpouRiMzt/f9aspu+Fb+UCKUofLtIChFohLyZrqFIzTz0ka8nQdALooSFjIX1M2x4M/5yv7e4dawyFhr8cqy+PLedjhI4u7VyXigfEIY5EJNjE9k0oz1kL81EbyILQ7PCwp3phfs7f+pqh1Vxo4pyuImd1h9DSjrRxag0LKF/4OvnYQZgap8+I4kHt3v3p7Is6s15O+oiz31mhpEASZ/0uYWjaboE5jr0/9sWPLpldrRGrYJBJkGuTuvMmrwyzwxyA1XSoOwuimDUIKvq8eIZTtWbY5Nya2hHx67s3Od7DjXSRmP9/D1goIWdzvnZcJplwmmwDeHZajoaUQwe7tDqHWZ+MhgBvWlKgFKaWKLVFTdGnguLlZ4CdwNo0UWeSX3ppA3L6xC/TK5J5jOx3iQUH3ulODeqHccFsaBVq80XrXpkaBqrdQzNU3WWbqmpCsVSUTF8PPE/5B7q+cDTgGADDssBikYBMFwgj8csFKpYqftVWikqVRMa/M7f+b1DwVYHdc10KQzj6Ur892foVQwr3ysEl5AVBCRVBhfYvgtHW8Yb4lg/mFuEGN23wEoV6C5ccBLiNpJEYRzozHdhlZQz8c= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(39860400002)(136003)(396003)(346002)(376002)(4326008)(66946007)(85182001)(26005)(66556008)(8676002)(66476007)(478600001)(186003)(86362001)(38100700001)(83380400001)(9686003)(6666004)(2906002)(8936002)(6496006)(6486002)(54906003)(5660300002)(316002)(33716001)(6916009)(16526019)(956004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?dkVtajM3T3B4bTJNWkhUaTRFMHNybU9kMFVPcXZzUSszbEJ0UC9UNVM4VnBV?= =?utf-8?B?YUgrSlRPQWhKUnhoQ3ZlQklmS2o4ZTFmOHJqQVRsN3JpQVQ5RnpTRVJjT20r?= =?utf-8?B?Sk9vQU1vNEx6SmIzRytSdTRjYy9zRnZoM0dzRW54VXBXb0Z0MlpQT1NCV2ZZ?= =?utf-8?B?bTY3bFFtYjBUTTltVnlvK1RBN0ZjWWRaWUlraENydklYcDhmdENKS3UwNHdz?= =?utf-8?B?ZmI2SWMwQ0U1bU1kYUZheGVPUE5xMDNHTU55ZnF4eldZWlBEclJURkNFdjg5?= =?utf-8?B?enVtUUprZjBUNDdNamxKNmx3bnM0VmxoT0VZNkNPMm13aEY1ays0R2hMVGVN?= =?utf-8?B?RU1FaVRzMzVjUFZhRFJFWUxFdUFlTjZEaDJWUmc2WXUwSks5V0toMVdCTzBl?= =?utf-8?B?Y2V1MFdHalRZNXlhS3kxM1hZYkluQUc0NTd6ZmVWUkdTVHJ1dy9CZ21TKytO?= =?utf-8?B?dE4wMi9VSFp6bUhtVEpGL2tVQ2VrendjZHl2NmhueTh2cjBDWERkWk56cUsr?= =?utf-8?B?bnJKYzkzRXAvM09XS0VLWjRoL1Y5djUyZktKQXN6L2p4RlQrVjFMSlp6bkhS?= =?utf-8?B?Yk40Rk9sVFdlZStzOU5nUWNWNE5yVTdRaFFKMnlNcFZiZ2F2Y2pxQU5nV0Fm?= =?utf-8?B?dE9QL2lmLy9LQU1nTVkzUWNWMWFNLzFxWXMyVU55T0xEdkR1Qk5jWVByZENR?= =?utf-8?B?QWRDYnRxNEtWRFgzVmhUNklNeTFQdk9LY0l4citjcWZLZVFhelRMUzAvZjJs?= =?utf-8?B?SUo2d3JyS2xIVWdyUE9xQ2ZMTjF2UUplczdVczNTOVFoUjFhWlREK2NrcVl2?= =?utf-8?B?bWY0NGs2bFE1Nkt0dVljdnMrcjAwTjJGaVg1UGRNWUdZT2FDNGhGQ3BacDJJ?= =?utf-8?B?MnNoMWtFRE9mM3ovL3dCUHpPMmswRmJkR3hWeDFkMklHNE5LWEVXbVVyc211?= =?utf-8?B?OVYzQ3pPaVVVWGlRWXh6Z1hKNUJIWmhaYzZ4eUNLZitrbmlmd0FvUmR6cExF?= =?utf-8?B?citxaE9zWHlabkxWdXdMWTg0cEZ5OG5raGpUT3NHRHZJenpoOEdiWkhIZUVW?= =?utf-8?B?MkRWYWxvNDN5bUIrLzlVTWlza1lrNmk5UmJGUHRCVHIzQnJiNGNtOU9oN2JR?= =?utf-8?B?WU9nU21FNFlUd0k5M3ZYNE04dnUxZjdwV05PWmczZ3hFM2V4V3hHNXNTY0t4?= =?utf-8?B?bnZRYy9qUmwvWFRYNTFoRnNRWHh1UmtnWWlCQUVpRkdxWXhpeFpmWUU2bGJZ?= =?utf-8?B?ODZmdVlUc0lJckE4ZC96OFhuUXYxZExuZDkzV1RKcy9lZ1pYZW9VMGVIZ2RE?= =?utf-8?B?S0VkeXc1OWdLanlKRkdiWFFYTmpJbjYxelQ0Mm1wN3ZrSmVtN2RMMmtwRU1Q?= =?utf-8?B?dEdodEdtZFVMaVlGaEp2WENsKzhFRlNtZTJiWEltZ041MlM5b1dxS0tha25V?= =?utf-8?B?OUV4bTRObmxPSnVwYkhtcFAwTmlGMWl0RTRjU3dIZ1ZYVFlMWGdXR2lUUCtx?= =?utf-8?B?K09CZ00zVjBObGdrKzNWaEdxbmk0M3lUbTdlc0Z2d0tjT1l3S2hYMnY4RlVT?= =?utf-8?B?NjN0ZThPcXArSzdFdE9id1BoRHRFTlgwV2IzTEdieUFxcTlvOVVYUndscWNi?= =?utf-8?B?T3ZBWXg3MEF3OW92L2dHVUMyOXgwNTdjbFNLNS9mcnlmR2Z5Q0lXdEwxeUc2?= =?utf-8?B?ZzBhMkJDanFvaGFldFErc2dNOUh3d214SThlamZrdGlMN2JuUy9uUGlFcHAv?= =?utf-8?Q?ULTzxNMYyndxc5cGGu0TfwbbzaMcxCMELdg6Ldq?= X-MS-Exchange-CrossTenant-Network-Message-Id: db911e2a-8520-4476-3013-08d8f8dbad98 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2021 09:09:26.9163 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7TSWjgtC1ggF6EDuoJF4clzV9NqlRstH6nuTAL9A/bEK2bfHePB5410dK04WEPFKJePKalo00/uxHCClAty5zA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4476 X-OriginatorOrg: citrix.com On Fri, Mar 12, 2021 at 10:55:29AM +0000, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/block/xen-blkfront.c:1960: warning: Function parameter or member 'dev' not described in 'blkfront_probe' > drivers/block/xen-blkfront.c:1960: warning: Function parameter or member 'id' not described in 'blkfront_probe' > drivers/block/xen-blkfront.c:1960: warning: expecting prototype for Allocate the basic(). Prototype was for blkfront_probe() instead > drivers/block/xen-blkfront.c:2085: warning: Function parameter or member 'dev' not described in 'blkfront_resume' > drivers/block/xen-blkfront.c:2085: warning: expecting prototype for or a backend(). Prototype was for blkfront_resume() instead > drivers/block/xen-blkfront.c:2444: warning: wrong kernel-doc identifier on line: > > Cc: Konrad Rzeszutek Wilk > Cc: "Roger Pau Monné" > Cc: Boris Ostrovsky > Cc: Juergen Gross > Cc: Stefano Stabellini > Cc: Jens Axboe > Cc: xen-devel@lists.xenproject.org > Cc: linux-block@vger.kernel.org > Signed-off-by: Lee Jones Acked-by: Roger Pau Monné Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Apr 06 09:50:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Apr 2021 09:50:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105739.202227 (Exim 4.92) (envelope-from ) id 1lTiLv-0005SS-KZ; Tue, 06 Apr 2021 09:50:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105739.202227; Tue, 06 Apr 2021 09:50:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTiLv-0005SL-Ga; Tue, 06 Apr 2021 09:50:31 +0000 Received: by outflank-mailman (input) for mailman id 105739; Tue, 06 Apr 2021 09:50:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTiLu-0005SG-Aq for xen-devel@lists.xenproject.org; Tue, 06 Apr 2021 09:50:30 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTiLu-0003hG-7T for xen-devel@lists.xenproject.org; Tue, 06 Apr 2021 09:50:30 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lTiLu-0004f9-6Q for xen-devel@lists.xenproject.org; Tue, 06 Apr 2021 09:50:30 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lTiLp-00073N-G3; Tue, 06 Apr 2021 10:50:25 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=3mDWDMDObA83DoZTUHamCtYJHXFJGuO9l2nxbUqTg9I=; b=eQE1yYuPd1vd1L1a9EIQcBtsSd /NIerKE306ReqAaxfUx/mHaJHozINYml87sJejKsvFKz7bhVsegBkIdu89ONTdyeg/I18iX+XAUrb GND4GOBvzKWZKlRmE0XmOeNVDL8VbYdnWTxTMfCoUYNUg1yqDwpKR7gvUidSEKYDdwoM=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24684.12001.296614.926923@mariner.uk.xensource.com> Date: Tue, 6 Apr 2021 10:50:25 +0100 To: Roger Pau =?iso-8859-1?Q?Monn=E9?= Cc: Jan Beulich , "xen-devel\@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Dario Faggioli Subject: Revert NR_CPUS=1 fix from 4.15 (was: Re: [PATCH] fix for_each_cpu() again for NR_CPUS=1) In-Reply-To: References: <4d993e67-2bdf-9ac3-f78e-daf279642de1@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Roger Pau Monn writes ("Revert NR_CPUS=1 fix from 4.15 (was: Re: [PATCH] fix for_each_cpu() again for NR_CPUS=1)"): > At this point, should be consider reverting the original fix from the > 4.15 branch, so that we don't release something that's build broken > with gcc 10? Yes. I think so. Release-Acked-by: Ian Jackson But please leave it to me to commit it. I will do so at or after around 14:00 UK time (13:00 UTC) today unless someone objects. Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Tue Apr 06 09:52:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Apr 2021 09:52:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105743.202239 (Exim 4.92) (envelope-from ) id 1lTiNS-0005ZL-WA; Tue, 06 Apr 2021 09:52:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105743.202239; Tue, 06 Apr 2021 09:52:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTiNS-0005ZE-Sw; Tue, 06 Apr 2021 09:52:06 +0000 Received: by outflank-mailman (input) for mailman id 105743; Tue, 06 Apr 2021 09:52:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTiNS-0005Z9-0M for xen-devel@lists.xenproject.org; Tue, 06 Apr 2021 09:52:06 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTiNR-0003j7-Vn for xen-devel@lists.xenproject.org; Tue, 06 Apr 2021 09:52:05 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lTiNR-0004ni-UB for xen-devel@lists.xenproject.org; Tue, 06 Apr 2021 09:52:05 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lTiNN-00074A-8N; Tue, 06 Apr 2021 10:52:01 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=xi0zxzD5z7v5EphnH1i0hhgeVLrYw7TsuSAgVsIt8kI=; b=dLCdCFOKjk342+r83iDPigZbdn fKZIT8ToW8nzvBvGaEYRcUbe+xTJRjk0TxwuwvtQ8iDlJWw7q1XNC2NSpy++mmRNs9fEnea0G87L7 SItmEahEj51dFJBEfZsRLtlGz9Xnt9SbZ5b9oAzcDZPqSNEpFl9CCNniD28yccHvsarw=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24684.12097.5068.371887@mariner.uk.xensource.com> Date: Tue, 6 Apr 2021 10:52:01 +0100 To: Roger Pau =?iso-8859-1?Q?Monn=E9?= Cc: Jan Beulich , "xen-devel\@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Dario Faggioli Subject: Re: Revert NR_CPUS=1 fix from 4.15 (was: Re: [PATCH] fix for_each_cpu() again for NR_CPUS=1) In-Reply-To: References: <4d993e67-2bdf-9ac3-f78e-daf279642de1@suse.com> <59387a2d-e28d-4e12-6b91-5df464e8ab9a@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Roger Pau Monn writes ("Re: Revert NR_CPUS=1 fix from 4.15 (was: Re: [PATCH] fix for_each_cpu() again for NR_CPUS=1)"): > On Thu, Apr 01, 2021 at 11:26:03AM +0200, Jan Beulich wrote: > > Well, I didn't propose reverting (or taking this fix) because I think > > build breakage is better than runtime breakage. But in the end, Ian, > > it's up to you. > > Oh, right, sorry. The build issue only happens with NR_CPUS=1, in > which case I agree, there's no need to do anything in 4.15 IMO. Oh. Right. I had the impression that the build breakage broke other configurations too. Since you're saying that's not the case, please disregard my earlier mail. Ian. From xen-devel-bounces@lists.xenproject.org Tue Apr 06 09:52:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Apr 2021 09:52:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105745.202250 (Exim 4.92) (envelope-from ) id 1lTiNh-0005dg-7w; Tue, 06 Apr 2021 09:52:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105745.202250; Tue, 06 Apr 2021 09:52:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTiNh-0005dZ-4x; Tue, 06 Apr 2021 09:52:21 +0000 Received: by outflank-mailman (input) for mailman id 105745; Tue, 06 Apr 2021 09:52:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTiNg-0005dJ-12 for xen-devel@lists.xenproject.org; Tue, 06 Apr 2021 09:52:20 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6e6ae3ea-f623-42b8-8477-93b2dc0387b8; Tue, 06 Apr 2021 09:52:19 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4D190B12A; Tue, 6 Apr 2021 09:52:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e6ae3ea-f623-42b8-8477-93b2dc0387b8 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617702738; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NDzO4YMW0UmO2XNf+QEIEAJwv6NwHHygQyBCqYoj37Q=; b=Olx1hCPB1eNN62PkjcMr1C5XEy96HgbJQ28VInhfx78+WvyxCSFmkIubjDM0qVLJmdHgcK NKV610l8ViRGDv2zSqUq2w73tcPsA564nESyL+g/dCSzgawyF0tb9Gjko8oosG9AHPLUZ0 BDxi2nNwsXdOvIsGiI8bxGciuwa+Dm0= Subject: Re: [PATCH 5/5] x86: don't build unused entry code when !PV32 To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu References: <46d83c92-0b06-fc09-4832-7a7d7935d5c2@suse.com> From: Jan Beulich Message-ID: <47137b21-c146-89d1-1996-28d64575ddc4@suse.com> Date: Tue, 6 Apr 2021 11:52:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 01.04.2021 16:01, Roger Pau Monné wrote: > On Wed, Nov 25, 2020 at 09:51:33AM +0100, Jan Beulich wrote: >> Except for the initial part of cstar_enter compat/entry.S is all dead >> code in this case. Further, along the lines of the PV conditionals we >> already have in entry.S, make code PV32-conditional there too (to a >> fair part because this code actually references compat/entry.S). >> >> Signed-off-by: Jan Beulich >> --- >> TBD: I'm on the fence of whether (in a separate patch) to also make >> conditional struct pv_domain's is_32bit field. >> >> --- a/xen/arch/x86/x86_64/asm-offsets.c >> +++ b/xen/arch/x86/x86_64/asm-offsets.c >> @@ -9,7 +9,7 @@ >> #include >> #endif >> #include >> -#ifdef CONFIG_PV >> +#ifdef CONFIG_PV32 >> #include >> #endif >> #include >> @@ -102,19 +102,21 @@ void __dummy__(void) >> BLANK(); >> #endif >> >> -#ifdef CONFIG_PV >> +#ifdef CONFIG_PV32 >> OFFSET(DOMAIN_is_32bit_pv, struct domain, arch.pv.is_32bit); >> BLANK(); >> >> - OFFSET(VCPUINFO_upcall_pending, struct vcpu_info, evtchn_upcall_pending); >> - OFFSET(VCPUINFO_upcall_mask, struct vcpu_info, evtchn_upcall_mask); >> - BLANK(); >> - >> OFFSET(COMPAT_VCPUINFO_upcall_pending, struct compat_vcpu_info, evtchn_upcall_pending); >> OFFSET(COMPAT_VCPUINFO_upcall_mask, struct compat_vcpu_info, evtchn_upcall_mask); >> BLANK(); >> #endif >> >> +#ifdef CONFIG_PV >> + OFFSET(VCPUINFO_upcall_pending, struct vcpu_info, evtchn_upcall_pending); >> + OFFSET(VCPUINFO_upcall_mask, struct vcpu_info, evtchn_upcall_mask); >> + BLANK(); >> +#endif >> + >> OFFSET(CPUINFO_guest_cpu_user_regs, struct cpu_info, guest_cpu_user_regs); >> OFFSET(CPUINFO_verw_sel, struct cpu_info, verw_sel); >> OFFSET(CPUINFO_current_vcpu, struct cpu_info, current_vcpu); >> --- a/xen/arch/x86/x86_64/compat/entry.S >> +++ b/xen/arch/x86/x86_64/compat/entry.S >> @@ -29,8 +29,6 @@ ENTRY(entry_int82) >> mov %rsp, %rdi >> call do_entry_int82 >> >> -#endif /* CONFIG_PV32 */ >> - >> /* %rbx: struct vcpu */ >> ENTRY(compat_test_all_events) >> ASSERT_NOT_IN_ATOMIC >> @@ -197,6 +195,8 @@ ENTRY(cr4_pv32_restore) >> xor %eax, %eax >> ret >> >> +#endif /* CONFIG_PV32 */ >> + >> .section .text.entry, "ax", @progbits >> >> /* See lstar_enter for entry register state. */ >> @@ -230,6 +230,13 @@ ENTRY(cstar_enter) >> sti >> >> movq STACK_CPUINFO_FIELD(current_vcpu)(%rbx), %rbx >> + >> +#ifndef CONFIG_PV32 >> + >> + jmp switch_to_kernel >> + >> +#else >> + >> movq VCPU_domain(%rbx),%rcx >> cmpb $0,DOMAIN_is_32bit_pv(%rcx) >> je switch_to_kernel >> @@ -393,3 +400,5 @@ compat_crash_page_fault: >> jmp .Lft14 >> .previous >> _ASM_EXTABLE(.Lft14, .Lfx14) >> + >> +#endif /* CONFIG_PV32 */ > > Seeing this chunk, would it make sense to move the cstar_enter part > relevant to !is_32bit_pv into the common entry.S and leave the rest > here as compat_cstar_enter or some such? > > AFAICT we only need a tiny part of the compat stuff when !CONFIG_PV32, > so I think we could make the hole compat/entry.S depend on > CONFIG_PV32. While it grows the patch, doing things this way looks to work out nicely. v2 in the works (making in fact compat/ as a whole build only when PV32, as it's really only the one object file that gets built there) ... Jan From xen-devel-bounces@lists.xenproject.org Tue Apr 06 10:14:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Apr 2021 10:14:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105759.202265 (Exim 4.92) (envelope-from ) id 1lTiix-0007Xh-1N; Tue, 06 Apr 2021 10:14:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105759.202265; Tue, 06 Apr 2021 10:14:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTiiw-0007Xa-Ub; Tue, 06 Apr 2021 10:14:18 +0000 Received: by outflank-mailman (input) for mailman id 105759; Tue, 06 Apr 2021 10:14:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTiiv-0007XS-2i; Tue, 06 Apr 2021 10:14:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTiiu-0004Bw-Sd; Tue, 06 Apr 2021 10:14:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTiiu-0002n7-GU; Tue, 06 Apr 2021 10:14:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lTiiu-0003bf-G1; Tue, 06 Apr 2021 10:14:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NKwhZ4k8SK2SMHYjTQCeTdDl8js4cXqTfS8AfsHLmJ4=; b=bfKbYeUfjQ9BpECnTs9xV5vruj 331OO3p97WDXN8P9GRSPMD+6Frowc9/kqdOjuyv3U3KXflcjP3+ewOQcqCyXz2JrYppAzBSaz6+Td d0RrYPD4FaZGxqoTG7LBNTyEtRvpqqlVdboFMshQkDxPGp1Q2/gtn5NRWAR9sMNN2/bM=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.12-testing test] 160752: regressions - FAIL X-Osstest-Failures: xen-4.12-testing:build-armhf::broken:regression xen-4.12-testing:build-armhf:host-install(4):broken:regression xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-localmigrate/x10:fail:regression xen-4.12-testing:test-amd64-amd64-libvirt-pair:guests-nbd-mirror/debian:fail:heisenbug xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-saverestore.2:fail:heisenbug xen-4.12-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-4.12-testing:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-4.12-testing:build-armhf-libvirt:build-check(1):blocked:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=5b280a59c4dd8dad6cc8da28db981b193d10acee X-Osstest-Versions-That: xen=4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 From: osstest service owner Date: Tue, 06 Apr 2021 10:14:16 +0000 flight 160752 xen-4.12-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/160752/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken in 160709 build-armhf 4 host-install(4) broken in 160709 REGR. vs. 159418 test-amd64-amd64-xl-qcow2 19 guest-localmigrate/x10 fail in 160709 REGR. vs. 159418 Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-pair 22 guests-nbd-mirror/debian fail in 160709 pass in 160752 test-amd64-amd64-xl-qcow2 18 guest-saverestore.2 fail pass in 160709 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 160738 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked in 160709 n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked in 160709 n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked in 160709 n/a test-armhf-armhf-xl 1 build-check(1) blocked in 160709 n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked in 160709 n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked in 160709 n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked in 160709 n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked in 160709 n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked in 160709 n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked in 160709 n/a build-armhf-libvirt 1 build-check(1) blocked in 160709 n/a test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159418 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159418 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159418 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: xen 5b280a59c4dd8dad6cc8da28db981b193d10acee baseline version: xen 4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 Last test of basis 159418 2021-02-16 15:06:11 Z 48 days Failing since 160128 2021-03-18 14:36:18 Z 18 days 23 attempts Testing same since 160150 2021-03-20 04:11:48 Z 17 days 21 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Christian Lindig Edwin Török Igor Druzhinin Jan Beulich Julien Grall Olaf Hering Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken Not pushing. (No revision log; it would be 311 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Apr 06 10:37:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Apr 2021 10:37:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105768.202283 (Exim 4.92) (envelope-from ) id 1lTj4u-0000xU-4t; Tue, 06 Apr 2021 10:37:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105768.202283; Tue, 06 Apr 2021 10:37:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTj4u-0000xN-14; Tue, 06 Apr 2021 10:37:00 +0000 Received: by outflank-mailman (input) for mailman id 105768; Tue, 06 Apr 2021 10:36:59 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTj4t-0000xI-Ca for xen-devel@lists.xenproject.org; Tue, 06 Apr 2021 10:36:59 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 2ea966c9-eb16-48ed-b71a-9ef8607421c6; Tue, 06 Apr 2021 10:36:57 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CA40031B; Tue, 6 Apr 2021 03:36:56 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.197.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7816B3F73D; Tue, 6 Apr 2021 03:36:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2ea966c9-eb16-48ed-b71a-9ef8607421c6 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH 0/3] Use Doxygen and sphinx for html documentation Date: Tue, 6 Apr 2021 11:36:00 +0100 Message-Id: <20210406103603.8530-1-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 This serie introduce doxygen in the sphinx html docs generation. One benefit is to keep most of the documentation in the source files of xen so that it's more maintainable, on the other hand there are some limitation of doxygen that must be addressed modifying the current codebase (for example doxygen can't parse anonymous structure/union). To reproduce the documentation xen must be compiled because most of the headers are generated on compilation time from the makefiles. Here follows the steps to generate the sphinx html docs, some package may be required on your machine, everything is suggested by the autoconf script. Here I'm building the arm64 docs (the only introduced for now by this serie): ./configure make -C xen XEN_TARGET_ARCH="arm64" CROSS_COMPILE="aarch64-linux-gnu-" menuconfig make -C xen XEN_TARGET_ARCH="arm64" CROSS_COMPILE="aarch64-linux-gnu-" make -C docs XEN_TARGET_ARCH="arm64" sphinx-html now in docs/sphinx/html/ we have the generated docs starting from the index.html page. Luca Fancellu (3): docs: add doxygen support for html documentation docs: hypercalls sphinx skeleton for generated html docs/doxygen: doxygen documentation for grant_table.h .gitignore | 7 + config/Docs.mk.in | 2 + docs/Makefile | 51 +- docs/conf.py | 48 +- docs/configure | 258 ++ docs/configure.ac | 15 + docs/hypercall-interfaces/arm32.rst | 4 + docs/hypercall-interfaces/arm64.rst | 33 + .../arm64/grant_tables.rst | 8 + docs/hypercall-interfaces/index.rst.in | 7 + docs/hypercall-interfaces/x86_64.rst | 4 + docs/index.rst | 8 + docs/xen-doxygen/customdoxygen.css | 36 + docs/xen-doxygen/doxy_input.list | 1 + docs/xen-doxygen/doxy_input_template.in | 21 + docs/xen-doxygen/footer.html | 21 + docs/xen-doxygen/header.html | 56 + docs/xen-doxygen/mainpage.md | 5 + docs/xen-doxygen/xen_project_logo_165x67.png | Bin 0 -> 18223 bytes docs/xen.doxyfile.in | 2314 +++++++++++++++++ m4/ax_python_module.m4 | 56 + m4/docs_tool.m4 | 9 + xen/include/public/grant_table.h | 79 +- 23 files changed, 3007 insertions(+), 36 deletions(-) create mode 100644 docs/hypercall-interfaces/arm32.rst create mode 100644 docs/hypercall-interfaces/arm64.rst create mode 100644 docs/hypercall-interfaces/arm64/grant_tables.rst create mode 100644 docs/hypercall-interfaces/index.rst.in create mode 100644 docs/hypercall-interfaces/x86_64.rst create mode 100644 docs/xen-doxygen/customdoxygen.css create mode 100644 docs/xen-doxygen/doxy_input.list create mode 100644 docs/xen-doxygen/doxy_input_template.in create mode 100644 docs/xen-doxygen/footer.html create mode 100644 docs/xen-doxygen/header.html create mode 100644 docs/xen-doxygen/mainpage.md create mode 100644 docs/xen-doxygen/xen_project_logo_165x67.png create mode 100644 docs/xen.doxyfile.in create mode 100644 m4/ax_python_module.m4 -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Apr 06 10:37:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Apr 2021 10:37:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.105769.202296 (Exim 4.92) (envelope-from ) id 1lTj4z-0000zB-Ct; Tue, 06 Apr 2021 10:37:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105769.202296; Tue, 06 Apr 2021 10:37:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTj4z-0000z4-94; Tue, 06 Apr 2021 10:37:05 +0000 Received: by outflank-mailman (input) for mailman id 105769; Tue, 06 Apr 2021 10:37:04 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTj4y-0000yp-Iz for xen-devel@lists.xenproject.org; Tue, 06 Apr 2021 10:37:04 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id e4c3ca21-fac3-43c6-aaee-2b4d764a7891; Tue, 06 Apr 2021 10:37:02 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4F0FCED1; Tue, 6 Apr 2021 03:37:02 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.197.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 680363F73D; Tue, 6 Apr 2021 03:37:00 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e4c3ca21-fac3-43c6-aaee-2b4d764a7891 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH 1/3] docs: add doxygen support for html documentation Date: Tue, 6 Apr 2021 11:36:01 +0100 Message-Id: <20210406103603.8530-2-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210406103603.8530-1-luca.fancellu@arm.com> References: <20210406103603.8530-1-luca.fancellu@arm.com> Add doxygen support to build html documentation with sphinx, to do that the following modification are applied: 1) Modify docs/configure.ac and consequently configure script to check, through the ./configure script, the presence in the system of the sphinx-build binary, if it is found then it checks also the presence of the doxygen binary, breathe and sphinx-rtd-theme python packages. Doxygen and the packages are required only if sphinx-build is found, otherwise the Makefile will simply skip the sphinx html generation. The ax_python_module.m4 support is needed to check for python packages. 2) Add doxygen templates and configuration file 3) Modify docs/Makefile to call in sequence doxygen and sphinx-build, the doxygen configuration file will be modified to include the xen absolute path and a list of folder to check. A doxygen_input.h file is generated to include every header listed in the doxy_input.list file. Signed-off-by: Luca Fancellu --- .gitignore | 6 + config/Docs.mk.in | 2 + docs/Makefile | 47 +- docs/conf.py | 48 +- docs/configure | 258 ++ docs/configure.ac | 15 + docs/xen-doxygen/customdoxygen.css | 36 + docs/xen-doxygen/doxy_input.list | 0 docs/xen-doxygen/doxy_input_template.in | 21 + docs/xen-doxygen/footer.html | 21 + docs/xen-doxygen/header.html | 56 + docs/xen-doxygen/mainpage.md | 5 + docs/xen-doxygen/xen_project_logo_165x67.png | Bin 0 -> 18223 bytes docs/xen.doxyfile.in | 2314 ++++++++++++++++++ m4/ax_python_module.m4 | 56 + m4/docs_tool.m4 | 9 + 16 files changed, 2888 insertions(+), 6 deletions(-) create mode 100644 docs/xen-doxygen/customdoxygen.css create mode 100644 docs/xen-doxygen/doxy_input.list create mode 100644 docs/xen-doxygen/doxy_input_template.in create mode 100644 docs/xen-doxygen/footer.html create mode 100644 docs/xen-doxygen/header.html create mode 100644 docs/xen-doxygen/mainpage.md create mode 100644 docs/xen-doxygen/xen_project_logo_165x67.png create mode 100644 docs/xen.doxyfile.in create mode 100644 m4/ax_python_module.m4 diff --git a/.gitignore b/.gitignore index 1c2fa1530b..a5eebf1213 100644 --- a/.gitignore +++ b/.gitignore @@ -58,6 +58,12 @@ docs/man7/ docs/man8/ docs/pdf/ docs/txt/ +docs/doxygen-output +docs/sphinx +docs/xen.doxyfile +docs/xen.doxyfile.tmp +docs/doxygen_input.h +docs/doxygen_input.h.tmp extras/mini-os* install/* stubdom/*-minios-config.mk diff --git a/config/Docs.mk.in b/config/Docs.mk.in index e76e5cd5ff..dfd4a02838 100644 --- a/config/Docs.mk.in +++ b/config/Docs.mk.in @@ -7,3 +7,5 @@ POD2HTML := @POD2HTML@ POD2TEXT := @POD2TEXT@ PANDOC := @PANDOC@ PERL := @PERL@ +SPHINXBUILD := @SPHINXBUILD@ +DOXYGEN := @DOXYGEN@ diff --git a/docs/Makefile b/docs/Makefile index 8de1efb6f5..dd651e9a93 100644 --- a/docs/Makefile +++ b/docs/Makefile @@ -17,6 +17,22 @@ TXTSRC-y := $(sort $(shell find misc -name '*.txt' -print)) PANDOCSRC-y := $(sort $(shell find designs/ features/ misc/ process/ specs/ \( -name '*.pandoc' -o -name '*.md' \) -print)) +# Directory in which the doxygen documentation is created +# This must be kept in sync with breathe_projects value in conf.py +DOXYGEN_OUTPUT = doxygen-output + +# Doxygen input headers from xen-doxygen/doxy_input.list file +DOXY_LIST_SOURCES != cat "xen-doxygen/doxy_input.list" +DOXY_LIST_SOURCES := $(realpath $(addprefix $(XEN_ROOT)/,$(DOXY_LIST_SOURCES))) + +# Get folder path for all input headers and delete duplicates +DOXY_LIST_DIRS := $(foreach inc,$(DOXY_LIST_SOURCES),$(dir $(realpath $(inc)))) +DOXY_LIST_DIRS := $(sort $(DOXY_LIST_DIRS)) + +DOXY_DEPS := xen.doxyfile \ + xen-doxygen/mainpage.md \ + doxygen_input.h + # Documentation targets $(foreach i,$(MAN_SECTIONS), \ $(eval DOC_MAN$(i) := $(patsubst man/%.$(i),man$(i)/%.$(i), \ @@ -46,8 +62,29 @@ all: build build: html txt pdf man-pages figs .PHONY: sphinx-html -sphinx-html: - sphinx-build -b html . sphinx/html +sphinx-html: $(DOXY_DEPS) $(DOXY_LIST_SOURCES) +ifneq ($(SPHINXBUILD),) + $(DOXYGEN) xen.doxyfile + XEN_ROOT=$(realpath $(XEN_ROOT)) $(SPHINXBUILD) -b html . sphinx/html +else + @echo "Sphinx is not installed; skipping sphinx-html documentation." +endif + +xen.doxyfile: xen.doxyfile.in xen-doxygen/doxy_input.list + @echo "Generating $@" + @sed -e "s,@XEN_BASE@,$(realpath $(XEN_ROOT)),g" $< \ + | sed -e "s,@DOXY_OUT@,$(DOXYGEN_OUTPUT),g" > $@.tmp + @$(foreach dir,\ + $(DOXY_LIST_DIRS),\ + echo "INCLUDE_PATH += \"$(dir)\"" >> $@.tmp; \ + ) + mv $@.tmp $@ + +doxygen_input.h: xen-doxygen/doxy_input_template.in xen-doxygen/doxy_input.list + @echo "Generating $@" + @sed -e "s,@XEN_BASE@,$(realpath $(XEN_ROOT)),g" $< > $@.tmp + @$(foreach inc,$(DOXY_LIST_SOURCES),cat "$(inc)" >> $@.tmp;) + @mv $@.tmp $@ .PHONY: html html: $(DOC_HTML) html/index.html @@ -71,7 +108,11 @@ clean: clean-man-pages $(MAKE) -C figs clean rm -rf .word_count *.aux *.dvi *.bbl *.blg *.glo *.idx *~ rm -rf *.ilg *.log *.ind *.toc *.bak *.tmp core - rm -rf html txt pdf sphinx/html + rm -rf html txt pdf sphinx $(DOXYGEN_OUTPUT) + rm -f xen.doxyfile + rm -f xen.doxyfile.tmp + rm -f doxygen_input.h + rm -f doxygen_input.h.tmp .PHONY: distclean distclean: clean diff --git a/docs/conf.py b/docs/conf.py index 50e41501db..a48de42331 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -13,13 +13,17 @@ # add these directories to sys.path here. If the directory is relative to the # documentation root, use os.path.abspath to make it absolute, like shown here. # -# import os -# import sys +import os +import sys # sys.path.insert(0, os.path.abspath('.')) # -- Project information ----------------------------------------------------- +if "XEN_ROOT" not in os.environ: + sys.exit("$XEN_ROOT environment variable undefined.") +XEN_ROOT = os.path.abspath(os.environ["XEN_ROOT"]) + project = u'Xen' copyright = u'2019, The Xen development community' author = u'The Xen development community' @@ -35,6 +39,7 @@ try: xen_subver = line.split(u"=")[1].strip() elif line.startswith(u"export XEN_EXTRAVERSION"): xen_extra = line.split(u"=")[1].split(u"$", 1)[0].strip() + except: pass finally: @@ -44,6 +49,15 @@ finally: else: version = release = u"unknown version" +try: + xen_doxygen_output = None + + for line in open(u"Makefile"): + if line.startswith(u"DOXYGEN_OUTPUT"): + xen_doxygen_output = line.split(u"=")[1].strip() +except: + sys.exit("DOXYGEN_OUTPUT variable undefined.") + # -- General configuration --------------------------------------------------- # If your documentation needs a minimal Sphinx version, state it here. @@ -53,7 +67,8 @@ needs_sphinx = '1.4' # Add any Sphinx extension module names here, as strings. They can be # extensions coming with Sphinx (named 'sphinx.ext.*') or your custom # ones. -extensions = [] +# breathe -> extension that integrates doxygen xml output with sphinx +extensions = ['breathe'] # Add any paths that contain templates here, relative to this directory. templates_path = ['_templates'] @@ -175,6 +190,33 @@ texinfo_documents = [ 'Miscellaneous'), ] +# -- Options for Breathe extension ------------------------------------------- + +breathe_projects = { + "Xen": "{}/docs/{}/xml".format(XEN_ROOT, xen_doxygen_output) +} +breathe_default_project = "Xen" + +breathe_domain_by_extension = { + "h": "c", + "c": "c", +} +breathe_separate_member_pages = True +breathe_show_enumvalue_initializer = True +breathe_show_define_initializer = True + +# Qualifiers to a function are causing Sphihx/Breathe to warn about +# Error when parsing function declaration and more. This is a list +# of strings that the parser additionally should accept as +# attributes. +cpp_id_attributes = [ + '__syscall', '__deprecated', '__may_alias', + '__used', '__unused', '__weak', + '__DEPRECATED_MACRO', 'FUNC_NORETURN', + '__subsystem', +] +c_id_attributes = cpp_id_attributes + # -- Options for Epub output ------------------------------------------------- diff --git a/docs/configure b/docs/configure index 569bd4c2ff..0ebf046a79 100755 --- a/docs/configure +++ b/docs/configure @@ -588,6 +588,8 @@ ac_unique_file="misc/xen-command-line.pandoc" ac_subst_vars='LTLIBOBJS LIBOBJS PERL +DOXYGEN +SPHINXBUILD PANDOC POD2TEXT POD2HTML @@ -673,6 +675,7 @@ POD2MAN POD2HTML POD2TEXT PANDOC +DOXYGEN PERL' @@ -1318,6 +1321,7 @@ Some influential environment variables: POD2HTML Path to pod2html tool POD2TEXT Path to pod2text tool PANDOC Path to pandoc tool + DOXYGEN Path to doxygen tool PERL Path to Perl parser Use these variables to override the choices made by `configure' or to help @@ -1800,6 +1804,7 @@ ac_configure="$SHELL $ac_aux_dir/configure" # Please don't use this var. + case "$host_os" in *freebsd*) XENSTORED_KVA=/dev/xen/xenstored ;; *) XENSTORED_KVA=/proc/xen/xsd_kva ;; @@ -1812,6 +1817,53 @@ case "$host_os" in esac +# =========================================================================== +# https://www.gnu.org/software/autoconf-archive/ax_python_module.html +# =========================================================================== +# +# SYNOPSIS +# +# AX_PYTHON_MODULE(modname[, fatal, python]) +# +# DESCRIPTION +# +# Checks for Python module. +# +# If fatal is non-empty then absence of a module will trigger an error. +# The third parameter can either be "python" for Python 2 or "python3" for +# Python 3; defaults to Python 3. +# +# LICENSE +# +# Copyright (c) 2008 Andrew Collier +# +# Copying and distribution of this file, with or without modification, are +# permitted in any medium without royalty provided the copyright notice +# and this notice are preserved. This file is offered as-is, without any +# warranty. + +#serial 9 + +# This is what autoupdate's m4 run will expand. It fires +# the warning (with _au_warn_XXX), outputs it into the +# updated configure.ac (with AC_DIAGNOSE), and then outputs +# the replacement expansion. + + +# This is an auxiliary macro that is also run when +# autoupdate runs m4. It simply calls m4_warning, but +# we need a wrapper so that each warning is emitted only +# once. We break the quoting in m4_warning's argument in +# order to expand this macro's arguments, not AU_DEFUN's. + + +# Finally, this is the expansion that is picked up by +# autoconf. It tells the user to run autoupdate, and +# then outputs the replacement expansion. We do not care +# about autoupdate's warning because that contains +# information on what to do *after* running autoupdate. + + test "x$prefix" = "xNONE" && prefix=$ac_default_prefix @@ -2232,6 +2284,212 @@ $as_echo "$as_me: WARNING: pandoc is not available so some documentation won't b fi +# If sphinx is installed, make sure to have also the dependencies to build +# Sphinx documentation. +for ac_prog in sphinx-build +do + # Extract the first word of "$ac_prog", so it can be a program name with args. +set dummy $ac_prog; ac_word=$2 +{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for $ac_word" >&5 +$as_echo_n "checking for $ac_word... " >&6; } +if ${ac_cv_prog_SPHINXBUILD+:} false; then : + $as_echo_n "(cached) " >&6 +else + if test -n "$SPHINXBUILD"; then + ac_cv_prog_SPHINXBUILD="$SPHINXBUILD" # Let the user override the test. +else +as_save_IFS=$IFS; IFS=$PATH_SEPARATOR +for as_dir in $PATH +do + IFS=$as_save_IFS + test -z "$as_dir" && as_dir=. + for ac_exec_ext in '' $ac_executable_extensions; do + if as_fn_executable_p "$as_dir/$ac_word$ac_exec_ext"; then + ac_cv_prog_SPHINXBUILD="$ac_prog" + $as_echo "$as_me:${as_lineno-$LINENO}: found $as_dir/$ac_word$ac_exec_ext" >&5 + break 2 + fi +done + done +IFS=$as_save_IFS + +fi +fi +SPHINXBUILD=$ac_cv_prog_SPHINXBUILD +if test -n "$SPHINXBUILD"; then + { $as_echo "$as_me:${as_lineno-$LINENO}: result: $SPHINXBUILD" >&5 +$as_echo "$SPHINXBUILD" >&6; } +else + { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5 +$as_echo "no" >&6; } +fi + + + test -n "$SPHINXBUILD" && break +done +test -n "$SPHINXBUILD" || SPHINXBUILD="no" + + if test "x$SPHINXBUILD" = xno; then : + { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: sphinx-build is not available so sphinx documentation \ +won't be built" >&5 +$as_echo "$as_me: WARNING: sphinx-build is not available so sphinx documentation \ +won't be built" >&2;} +else + + # Extract the first word of "sphinx-build", so it can be a program name with args. +set dummy sphinx-build; ac_word=$2 +{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for $ac_word" >&5 +$as_echo_n "checking for $ac_word... " >&6; } +if ${ac_cv_path_SPHINXBUILD+:} false; then : + $as_echo_n "(cached) " >&6 +else + case $SPHINXBUILD in + [\\/]* | ?:[\\/]*) + ac_cv_path_SPHINXBUILD="$SPHINXBUILD" # Let the user override the test with a path. + ;; + *) + as_save_IFS=$IFS; IFS=$PATH_SEPARATOR +for as_dir in $PATH +do + IFS=$as_save_IFS + test -z "$as_dir" && as_dir=. + for ac_exec_ext in '' $ac_executable_extensions; do + if as_fn_executable_p "$as_dir/$ac_word$ac_exec_ext"; then + ac_cv_path_SPHINXBUILD="$as_dir/$ac_word$ac_exec_ext" + $as_echo "$as_me:${as_lineno-$LINENO}: found $as_dir/$ac_word$ac_exec_ext" >&5 + break 2 + fi +done + done +IFS=$as_save_IFS + + ;; +esac +fi +SPHINXBUILD=$ac_cv_path_SPHINXBUILD +if test -n "$SPHINXBUILD"; then + { $as_echo "$as_me:${as_lineno-$LINENO}: result: $SPHINXBUILD" >&5 +$as_echo "$SPHINXBUILD" >&6; } +else + { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5 +$as_echo "no" >&6; } +fi + + + + + # Extract the first word of "doxygen", so it can be a program name with args. +set dummy doxygen; ac_word=$2 +{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for $ac_word" >&5 +$as_echo_n "checking for $ac_word... " >&6; } +if ${ac_cv_path_DOXYGEN+:} false; then : + $as_echo_n "(cached) " >&6 +else + case $DOXYGEN in + [\\/]* | ?:[\\/]*) + ac_cv_path_DOXYGEN="$DOXYGEN" # Let the user override the test with a path. + ;; + *) + as_save_IFS=$IFS; IFS=$PATH_SEPARATOR +for as_dir in $PATH +do + IFS=$as_save_IFS + test -z "$as_dir" && as_dir=. + for ac_exec_ext in '' $ac_executable_extensions; do + if as_fn_executable_p "$as_dir/$ac_word$ac_exec_ext"; then + ac_cv_path_DOXYGEN="$as_dir/$ac_word$ac_exec_ext" + $as_echo "$as_me:${as_lineno-$LINENO}: found $as_dir/$ac_word$ac_exec_ext" >&5 + break 2 + fi +done + done +IFS=$as_save_IFS + + ;; +esac +fi +DOXYGEN=$ac_cv_path_DOXYGEN +if test -n "$DOXYGEN"; then + { $as_echo "$as_me:${as_lineno-$LINENO}: result: $DOXYGEN" >&5 +$as_echo "$DOXYGEN" >&6; } +else + { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5 +$as_echo "no" >&6; } +fi + + + if ! test -x "$ac_cv_path_DOXYGEN"; then : + + as_fn_error $? "doxygen is needed" "$LINENO" 5 + +fi + + + if test -z $PYTHON; + then + if test -z ""; + then + PYTHON="python3" + else + PYTHON="" + fi + fi + PYTHON_NAME=`basename $PYTHON` + { $as_echo "$as_me:${as_lineno-$LINENO}: checking $PYTHON_NAME module: breathe" >&5 +$as_echo_n "checking $PYTHON_NAME module: breathe... " >&6; } + $PYTHON -c "import breathe" 2>/dev/null + if test $? -eq 0; + then + { $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5 +$as_echo "yes" >&6; } + eval HAVE_PYMOD_BREATHE=yes + else + { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5 +$as_echo "no" >&6; } + eval HAVE_PYMOD_BREATHE=no + # + if test -n "yes" + then + as_fn_error $? "failed to find required module breathe" "$LINENO" 5 + exit 1 + fi + fi + + + if test -z $PYTHON; + then + if test -z ""; + then + PYTHON="python3" + else + PYTHON="" + fi + fi + PYTHON_NAME=`basename $PYTHON` + { $as_echo "$as_me:${as_lineno-$LINENO}: checking $PYTHON_NAME module: sphinx_rtd_theme" >&5 +$as_echo_n "checking $PYTHON_NAME module: sphinx_rtd_theme... " >&6; } + $PYTHON -c "import sphinx_rtd_theme" 2>/dev/null + if test $? -eq 0; + then + { $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5 +$as_echo "yes" >&6; } + eval HAVE_PYMOD_SPHINX_RTD_THEME=yes + else + { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5 +$as_echo "no" >&6; } + eval HAVE_PYMOD_SPHINX_RTD_THEME=no + # + if test -n "yes" + then + as_fn_error $? "failed to find required module sphinx_rtd_theme" "$LINENO" 5 + exit 1 + fi + fi + + + +fi + # Extract the first word of "perl", so it can be a program name with args. set dummy perl; ac_word=$2 diff --git a/docs/configure.ac b/docs/configure.ac index c2e5edd3b3..a2ff55f30a 100644 --- a/docs/configure.ac +++ b/docs/configure.ac @@ -20,6 +20,7 @@ m4_include([../m4/docs_tool.m4]) m4_include([../m4/path_or_fail.m4]) m4_include([../m4/features.m4]) m4_include([../m4/paths.m4]) +m4_include([../m4/ax_python_module.m4]) AX_XEN_EXPAND_CONFIG() @@ -29,6 +30,20 @@ AX_DOCS_TOOL_PROG([POD2HTML], [pod2html]) AX_DOCS_TOOL_PROG([POD2TEXT], [pod2text]) AX_DOCS_TOOL_PROG([PANDOC], [pandoc]) +# If sphinx is installed, make sure to have also the dependencies to build +# Sphinx documentation. +AC_CHECK_PROGS([SPHINXBUILD], [sphinx-build], [no]) + AS_IF([test "x$SPHINXBUILD" = xno], + [AC_MSG_WARN(sphinx-build is not available so sphinx documentation \ +won't be built)], + [ + AC_PATH_PROG([SPHINXBUILD], [sphinx-build]) + AX_DOCS_TOOL_REQ_PROG([DOXYGEN], [doxygen]) + AX_PYTHON_MODULE([breathe],[yes]) + AX_PYTHON_MODULE([sphinx_rtd_theme], [yes]) + ] + ) + AC_ARG_VAR([PERL], [Path to Perl parser]) AX_PATH_PROG_OR_FAIL([PERL], [perl]) diff --git a/docs/xen-doxygen/customdoxygen.css b/docs/xen-doxygen/customdoxygen.css new file mode 100644 index 0000000000..4735e41cf5 --- /dev/null +++ b/docs/xen-doxygen/customdoxygen.css @@ -0,0 +1,36 @@ +/* Custom CSS for Doxygen-generated HTML + * Copyright (c) 2015 Intel Corporation + * SPDX-License-Identifier: Apache-2.0 + */ + +code { + font-family: Monaco,Menlo,Consolas,"Courier New",monospace; + background-color: #D8D8D8; + padding: 0 0.25em 0 0.25em; +} + +pre.fragment { + display: block; + font-family: Monaco,Menlo,Consolas,"Courier New",monospace; + padding: 1rem; + word-break: break-all; + word-wrap: break-word; + white-space: pre; + background-color: #D8D8D8; +} + +#projectlogo +{ + vertical-align: middle; +} + +#projectname +{ + font: 200% Tahoma, Arial,sans-serif; + color: #3D578C; +} + +#projectbrief +{ + color: #3D578C; +} diff --git a/docs/xen-doxygen/doxy_input.list b/docs/xen-doxygen/doxy_input.list new file mode 100644 index 0000000000..e69de29bb2 diff --git a/docs/xen-doxygen/doxy_input_template.in b/docs/xen-doxygen/doxy_input_template.in new file mode 100644 index 0000000000..fc7565ab5b --- /dev/null +++ b/docs/xen-doxygen/doxy_input_template.in @@ -0,0 +1,21 @@ +#define __XEN__ + +#include "@XEN_BASE@/xen/include/xen/config.h" + +#if defined(CONFIG_X86_64) + +#define __x86_64__ 1 + +#elif defined(CONFIG_ARM_64) + +#define __aarch64__ 1 + +#elif defined(CONFIG_ARM_32) + +#define __arm__ 1 + +#else + +#error Architecture not supported/recognized. + +#endif diff --git a/docs/xen-doxygen/footer.html b/docs/xen-doxygen/footer.html new file mode 100644 index 0000000000..a24bf2b9b4 --- /dev/null +++ b/docs/xen-doxygen/footer.html @@ -0,0 +1,21 @@ + + + + + + +
+$generatedby   +doxygen + $doxygenversion +
+ + + diff --git a/docs/xen-doxygen/header.html b/docs/xen-doxygen/header.html new file mode 100644 index 0000000000..83ac2f1835 --- /dev/null +++ b/docs/xen-doxygen/header.html @@ -0,0 +1,56 @@ + + + + + + + + +$projectname: $title +$title + + + +$treeview +$search +$mathjax + +$extrastylesheet + + +
+ + +
+ + + + + + + + + + + + + + + + + + + + + +
+
$projectname +  $projectnumber +
+
$projectbrief
+ 		+
$projectbrief
+ 		$searchbox
+
+ + diff --git a/docs/xen-doxygen/mainpage.md b/docs/xen-doxygen/mainpage.md new file mode 100644 index 0000000000..ff548b87fc --- /dev/null +++ b/docs/xen-doxygen/mainpage.md @@ -0,0 +1,5 @@ +# API Documentation {#index} + +## Introduction + +## Licensing diff --git a/docs/xen-doxygen/xen_project_logo_165x67.png b/docs/xen-doxygen/xen_project_logo_165x67.png new file mode 100644 index 0000000000000000000000000000000000000000..7244959d59cdeb9f23c5202160ea45508dfc7265 GIT binary patch literal 18223 zcmV+NKn=f%P)1^@s6{Wir#00004XF*Lt006O$ zeEU(80000WV@Og>004&%004{+008|`004nN004b?008NW002DY000@xb3BE2000U( zX+uL$P-t&-Z*ypGa3D!TLm+T+Z)Rz1WdHz3$DNjUR8-d%htIutdZEoQ0#b(FyTAa_ zdy`&8VVD_UC<6{NG_fI~0ue<-nj%P0#DLLIBvwSR5EN9f2P6n6F&ITuEN@2Ei>|D^ z_ww@lRz|vC zuzLs)$;-`!o*{AqUjza0dRV*yaMRE;fKCVhpQKsoe1Yhg01=zBIT!&C1$=TK@rP|Ibo3vKKm@PqnO#LJhq6%Ij6Hz*<$V$@wQAMN5qJ)hzm2h zoGcOF60t^#FqJFfH{#e-4l@G)6iI9sa9D{VHW4w29}?su;^hF~NC{tY+*d5%WDCTX za!E_i;d2ub1#}&jF5T4HnnCyEWTkKf0>c0%E1Ah>(_PY1)0w;+02c53Su*0<(nUqK zG_|(0G&D0Z{i;y^b@OjZ+}lNZ8Th$p5Uu}MTtq^NHl*T1?CO*}7&0ztZsv2j*bmJyf3G7=Z`5B*PvzoDiKdLpOAxi2$L0#SX*@cY z_n(^h55xYX#km%V()bZjV~l{*bt*u9?FT3d5g^g~#a;iSZ@&02Abxq_DwB(I|L-^b zXThc7C4-yrInE_0gw7K3GZ**7&k~>k0Z0NWkO#^@9q0fwx1%qj zZ=)yBuQ3=54Wo^*!gyjLF-e%Um=erBOdIALW)L%unZshS@>qSW9o8Sq#0s#5*edK% z>{;v(b^`kbN5rY%%y90wC>#%$kE_5P!JWYk;U;klcqzOl-UjcFXXA75rT9jCH~u<) z0>40zCTJ7v2qAyk54cquI@7b&LHdZ`+zlTss6bJ7%PQ)z$cROu4wBhpu-r)01) zS~6}jY?%U?gEALn#wiFzo#H}aQ8rT=DHkadR18&{>P1bW7E`~Y4p3)hWn`DhhRJ5j z*2tcg9i<^OEt(fCg;q*CP8+7ZTcWhYX$fb^_9d-LhL+6BEtPYWVlfKTBusSTASKKb%HuWJzl+By+?gkLq)?+BTu761 zjmyXF)a;mc^>(B7bo*HQ1NNg1st!zt28YLv>W*y3CdWx9U8f|cqfXDAO`Q48?auQq zHZJR2&bcD49Ip>EY~kKEPV6Wm+eXFV)D)_R=tM0@&p?(!V*Qu1PXHG9o^ zTY0bZ?)4%01p8F`JoeS|<@=<@RE7GY07EYX@lwd>4oW|Yi!o+Su@M`;WuSK z8LKk71XR(_RKHM1xJ5XYX`fk>`6eqY>qNG6HZQwBM=xi4&Sb88?zd}EYguc1@>KIS z<&CX#T35dwS|7K*XM_5Nf(;WJJvJWRMA($P>8E^?{IdL4o5MGE7bq2MEEwP7v8AO@ zqL5!WvekBL-8R%V?zVyL=G&{be=K4bT`e{#t|)$A!YaA?jp;X)-+bB;zhj`(vULAW z%ue3U;av{94wp%n<(7@__S@Z2PA@Mif3+uO&y|X06?J#oSi8M;ejj_^(0<4Lt#wLu#dYrva1Y$6_o(k^&}yhSh&h;f@JVA>W8b%o zZ=0JGnu?n~9O4}sJsfnnx7n(>`H13?(iXTy*fM=I`sj`CT)*pTHEgYKqqP+u1IL8N zo_-(u{qS+0<2@%BCt82d{Gqm;(q7a7b>wu+b|!X?c13m#p7cK1({0<`{-e>4hfb-U zsyQuty7Ua;Ou?B?XLHZaol8GAb3Wnxcu!2v{R_`T4=x`(GvqLI{-*2AOSimk zUAw*F_TX^n@STz9kDQ z$NC=!KfXWC8h`dn#xL(D3Z9UkR7|Q&Hcy#Notk!^zVUSB(}`#4&lYA1f0h2V_PNgU zAAWQEt$#LRcH#y9#i!p(Udq2b^lI6wp1FXzN3T;~FU%Lck$-deE#qz9yYP3D3t8{6 z?<+s(e(3(_^YOu_)K8!O1p}D#{JO;G(*OVf32;bRa{vGf4*&oQ4*`<-1El}}02*{f zSaefwW^{L9a%BKeVQFr3E>1;MAa*k@H7+qQF!XYv002BXNkl1$+-w06x=a`rA|vr~**(wFP#~E32=hh>6`k4PSh1Z`vdHU@7wd+^* z?%lU7ARy4EXV0EvkdBI3DMdQ~?D{JKrGd}%nSMu>im&!4}Ld-qc1+`03zf8TytnYch*H?@DaIi{(_{Yrpb#JFO=|E zS&WyBYw34aC9jU}(WB>Bq)!HAH&01S-IQv=XXgA&3Y7=gowf(q#gZ8{6ILWFefi?m zi=3QX0Yl2ehmXK)mt@z@J(7@+D3Oto;^X5hvuDqiY15{Ot*xyM~Pi0 zyJ{LP>{f?_hJ^ZOJbd&pCtJWoSqd}Vx^-JFT(}^|jvWJ&?UVKE*GpVnoP>mg$btn6 z#MRYRoSd9w)~s2wXwf1G4GmT9uUofHcJACMM~)m(q$;H=r7RgUH%EZnoC60AZ12*g zi>hmg{Yuu}m=I^Jg!?kdGxJ;}N9f zLon1mxpL)-!eC@hV)N$Bl9-q$HOYuPMn^}>#*G_g|Ni}Q>eMMoNlB3tCr-%Kt5+pG zJzbtXd!}^hxw%q6Z$O(iZAz|MwdzQeh5BY=fDPs|WBwl@TD;W(4%JY19GaB4CNc9( zj=X-IDNmm~lSdhk!IaMxqa_#IL*0-Jb?Ve<*}8SBczJor`0?XKPft$<4<0PNdi4@W zJL%rNy9^jGKr}Tq#n8}Drc9Y4OO`B=-Me?o_3Jla{5+9YuU<(`4#ec!1SY+E_wLO; zefn6SOl&C4fbW1(z-Rg&CQ3*e6|}6?t5m6?bNJBllxI(0%Hzk+APv*xe)@fMvCkDg zfdG@+w{I)bjuJ6EJY2lJy~V}FMXar@MPFZEh7KJny?ghTK7IO1zkdBiU0q#9j2Iy% zCMF6~y1BW@;>C-VxLdYtQKT&;<=e#WoV@zv@zZCMCQX`w@=={=18_9pGh_ab(zgI5 zq{5KhyY;lVaQ^C@jEtv}mYObCuUu2QXi7yg<;|Nnm9Co1xMIZ$S+;DM!dQO3{^IB` zJ=Z|rI9o?&RF~5hlZe>LjW=+M+QE3<^N;E3jG1-45({q zYTI49c;i`m+5@?M?WUYPdrofL$m?Ej-MXbPV@ynp0vap{2?^rk?U!w3W&Og`)HD@F z&FO^;7j6#-2uO&ChzO63ja{^S`SN+d0x)kdbj!G)prDN~dX6|dJ6{LGKD4#5e-#(E zJcs%w^hZVSgps4D1srN(xBl|QOQ;ZU6f6Dps~lOgYQt)jmyF2)cMchSw#xs9h(-e? z&Y*T}J6N1Je(uT58@J`mnR9aZ@L@TB{=6a?j~+cLU@Qp^4i+$*BHe-lgR;#`&F+B_ zkDwcl0mIEmPEOX}yLayZ#Os!kk>p94`7A_)MQT(Xin#OaH1>f6(8yWpC=GOIM*M9#@8Is4tQ!XpH#!`YQULpP!!u z2ZiRKJ5B{7?E^zCTC--2{^`@FyMcLHg83Q(wSj5?8U8nvf4vsa0B8mY+#Y!hg>;+_ zD}4iW%?m&V8Ip{z=$o6j$b$zD6dm^Z_3M%f{WedMr-`$Zn=g{3Rn8e8>cw9HpXn1N zcH7h=y92`m1D700NjWLowr&@6xys-+CDzKsmCE3^gM)+2m@z}_Y#m>Y9z8k*U2iCu z)Er%MA9UgEAw8QQ9Zp4l`>%if>r2qTaQ>Hw3<@dQ77}#mx^?T^U@&b4)1M0q4a??O zCk-M>=rd=|$e}}rWbfX6N@F>CPe_PoAs{?a+EAIK0!P%P%i*epy>vdn*i> zXhTE85HP48ENu@0hRkepb92YirAt#CC=15?f*Ji40%MlUXU+~MPMk1>L{8|^rOR18 zJ-y6f!-mPAL4#!M*s;ni5od>-ojF4^UuHPFilxQGr~Uf%OGda59UUDn#F?)u6Jcy@ z>}G9kJsD~SJ(EiQod)xn{&Per$?3zs)vMPu3k!*UwPVLlRQ3#6jBfh;wQJyy52wiJ z=mSW*Go(_fzsmrShV{I>yn3svt1mj0U@;mb)SRR&(;D46& z+~rG3*)QF=ro=sa`68wNm69b(+9K^1#flaC_A^s{e8h^U_jm7>E!xfSobMx>Hg1uH z3l}PL)n;a9^1}~5$lm??<=*}KayLC)uEW5%1nGJ4>Q%W6L*tK-@${*}nAdLKe$}v1 zqp8T}M=-%3>T&r@LY=R}gb5R(pFMl_hG|@d)z5t2m5-`CJTlzPyLXlHrote)hce&7 z|C1+A=4feYokO~AKriI;1MoHQx%>Xeh)VxYfaVw@t204?q2li!AfBF{io*mQCu-HI zC2DGFas?Hhp7Btgym+qQ;giSm;PE3c-V+6no;@vq>KgB>Xz$*=cae_*>oE%6(o-y`QdF>6MT%74#u=^XAPLwQJWNkG!jbIf~)PvBNHoj*f}1UcLIg z2gY9{&Wm%lhjZn-cI}ep&6~>)RjZ3ygGO7?0Qvw`07Zv{RHl?19 zbE*)fAkm9`3=GV2;6VMKfO>}x9V`tD4CYLlG$|PR z^J=Io>j-rBt4vKzeKa*Soe^#rK!;+E;gVs?fU)1JhmwIooJFGl0P~_#3-ja3&UX3N z=$l#?%>g=4Q}Z@SIhhoyZDh8P%3%9k&%lsiw-_mukenq)R<(j;ug zj2WxfuU~)W%9ShksYc`{@u!rUn)+nt&Yc&1eSJ4}?%a7Yo}Ua>jm-Bp1K>ZIsj8)= zr6bCdcJ=Djbmm9w-o5)W^M4x~Hf%V(Wy_XhXc!)dOU7rtv_YB8{QdnmpE`Bw_RE(q zl@W+{5uQIA@9-A%^_Aaz^9>j9{gAJpe{xg;;5wI)n#1(&I63Ccim1A7yi`R>jvA$x zHDJI1&Ev<9*FSpnXc@fpvUp&&cKgAD2VWpF(82dZ2=Q`J;ji-l{%s;dqO!;|oR`m~ zWJkFaAI-jf`zn&2&vEkP$^01q9)hlV50aE~?37>?@J(;I3$ZYwy|1#aUaU-LD|Nc%$rw)XzqO*TWL`hk_SkYoeqxDR(X1cnI zOMchQp&(W&nR0}d_7z=S-A>RUE8&@GF;mB)YZzBDdZ0^BfAr{)(tZ9XiTWe;TDs4z zS+gb!68B8Sij{KMZMSOG3JuIzVc7Q(nSg1qK`E|q2uq2}=lH9Vf8)lD=c-n%s*U$h z1@A=Z(s86OD(CEfbprj1q@$yA7}EIU-;v_)A{dG<)YR0>Q4Sh)pVSBgC1sszKh$tC zG%yp-`FV@FIG0R)l3h2^s#UvS3k!?-cvj9uE8P`9>y_(vxa>6$UHkK=PoFB4{C6l9 zznntDMSn&N`})mm1$15GaLLZP#N!psvr#{i`%zv zE8Q*Qs=#=Kk(HgLluJeErr+6$ScbxRzD=t8ET8fpWe*7nIfHU^LYY1(FDY7bYCkn? z9WYAQ2s-2(MUSKd1_#c`kQ@#wS+dkHbVZf%tX~2uX+XxL70cxkTF~JVH*MaOdHe1i zx&QD%0Ukce_#GZ(Je2eY_Y2Nd;Z$*W?d|{f(o*Hto!fHl#&x;M>CTH6;^NLD{x48#xD=yq%T}$t8D5o!3aV#PL6s)& zJ>moajw~C?e)IM%B@gDOdLM<;QlW79_>4^NHl7y^_6^FSU#wU$TIinyQKVB+Hfhtk z)AG@JW5A4a6^7*aB$<=?*zn<+)X}=c$H$kzyZ=o$0EYYmD2azw!(Wp+b?ffhzI%7h zNl2ZPQ>WxOq}2&XpLgNd>C;LWLUqogDh`jTG*X}s9yoeb_8vSaJNE36&D*z2d_qEY z^A;^mBHy{lUlT|5zWw^epc~G8imvz|!XHdYkt4^C7o?-YiTq<+Lc*JGOPA*O<$S;b z5>6jSOTY(Ab>Y)fio~4(+?wwZMjUwNFa}-8e)nK_ z*rEW3NI0xv)4fNJbK7?A0`u&ZUHkUS?)?Ye3*Ik`x9{!PvrjqSzI%^s*s@htt=}L? zYu3t4_t~$?SE#TV`Po4-(f6}W^%^zo($dmiK6vs>wjlp)yLQXYy?OC@WLiA#IdD)x z%E{BxxJi>kh&vhO{~1sNIPKU7X>t)-`1(zovsn(tD_lm^k!fy4UfcPs_^&-`)EdO& z4jzM?oSmo#qcgjK6^hiVLa`0cmfayoP?u(y4Oj;VYeRaoZz zHh7)oRAJA-LvrZoF=^De@nWRG=lUe{N-`LS44QZ9(0$9OQAP?=a$1qzQdl#y zaoGq%@1gfT6dss{PX)9{F2i-#H!@D!unjMH%QjiNdFuyZ&897~X5(h%xN5^DiBC+D z*cFMQJ6iuC^5Bw(v5=6h(HJ;de0pPlx-T=oUx%{ld>x7zNJ=EKgo7A(2rzU?Qpk{(u#pPZ#fW9L}R$X1PCSS>BaS zVJK+=49hZ=D_?#N8d;rBg(*p#1!&x{efKSTU`mfUbCo5r1SKWM`NoYKmxC}Il;zOE zd%FNUGz}jP7LNc{dk2NQiC?uwmL;wFV8pIWmS`~JQZS=mXhcrycI`O;&XzwMc~P>_ z-L8JK7A+RAtNIVRa*SNeDzv6ef0)6Ovr|D^YqfCOBt#$L=|xD zA@AMFcp^*USG*UI%i<*h;CURFYRE9neSH3srAoOjO<0-ByqIUifO^Ux3%F#@_zk_6)R3&vu4fRhgpIbogiVc z@gI!vWy^6~E-tg@Wqx0!%6_Cj9g?GWer3^Fn1)(cQ_Jxe_oSSX;H9w=8WSfWOP49f z!fC0l^E@Pa8PZ-Mu}N!W1te?I#;uYJ$-*O%uzr(7tw@rfs2K4JUm^h!OWz6qh$!(1 zi4ecAB}(2s`t;q2@));l(>8(WheRV!pl~?~gZEgjV3cQ3U`P(6eiY)9AvyI*Ba*5S zhu(Db$C}4W&i&Dl???mL;IF<8n)U^9}VY2UHq|H~4~CVKlPnZ>j6-KIchf{7NN1e=y5C^ToA*$Y|y0 z8y+RzA>lxT_=2GrCm=trUsx0vF-kf235^8PMJi$52JbQcqQFq`3JAfqNNLr!{aTb~ z!cff-CpYXl@cy#omq)pebLM9?#qJ5>+Toe%0R^)}IC6e_l=W1{^yTX|y+1ty_xOwi z%h;n&KN^BVkOrrcKYjv376mBXsx)fYJV0}}t~feQld!NbWw|U@3=SMPP(jtI)l3nN zFNfWIfwaWK@|=v(aq{HJu`gb{$UJiXI$AB6DPBQn%<>OHSnLW}w_~4VWQ$C&wZDTr z%m7Nr!WG7qkrRTJEXxgxS)s%WiGF{cED!JdM?`~}!o<@zP!{+FgQ>#sKU}iOt2!bNXZUjAXPmnJ~({FCS7F=#2IFY>PTWA!-1?SOPBP(FSFLly%# zrdIZcsx|C}Ym5>r%LxiIMny$Qe0;pJFpG=B3=PN7AgBhAi4|!HsYM2*XU(9<$jBo| zOSbG!k?^=giNecMVQJ!;LiqK1-o3Z){}!>y>*e;7Ou6$kQ-*43(-*QGDv2WoN`;{e zKb9?9&Lw8$x`Mp^DBb9lNHb}@jJ2Hbs!qN7x9T=fyHHQ9;aQ@7A-w&+@b$vsmGcH_ zJU`l`S&Nk@78|d#PgvBOgbmvY%JgpJzXM>&@+4{6yybet{RPj(*&u~*&PHGVr{*m~ zmaW==@~>6my*s^MpFINUc?E`1pLE4LYJhY;ovB9fQMts##LC5r7E>QOSSL$=w2?$c zL@GO7aFYRUNX5N>X3UtGhTvQ-OE)g|*JRE*jT<+%IC}J`GJ>42Zkt5L!6?CtSq5f` zNnEQi0MB_OY#{MsW;W(W~3%*bF z8a4gnR&A6xFp(<%cR^LY=!7*A616-Bmi9b6PZK;B->pJ8=jcdBjS)Hr_MSMe#8JJQ zcY)8nEO`SA!_{JK>qvca9MYgO^LuT9kB(5+oWSq8xc|6J$I zHQgE-8ZvdNJ%@!jRKn>q>L)FAbaWP_r>DQTl=?(MqtRucy9kR-1altn>7h%(ShF3{U?&Yo<@1RMKX zTMry7c&z;5g(p)_tMxOETM^ zrOEq?f+CP^gw(22kLm;s!%st>R1w~5DWI08r)T?mbs8hS$c_Je!eV9Sd>?UJ;3u;e1G8L{(Ntl>6uqP_l5rA?iHZqvwVG?)J3Dai0AS{eEnX%dO2{#VKT|XtI@gzr=CthGS-e>;r1>S`#%IW6mD-E0c z#M!CtV4%YKB$=~jC8#I!eM4myo7)AOlB9sF?k@ZnCi zYSq#lqOS8?M_W%B7UIrn1n0tk`Q;aB)~p#lSe|W8xg^u(ERv}+=ZT~H0_EIkwwD5) zzx|&_`CYD18BE_p0rR$V1(f_2NND^zd7-f8uf+e6Nn6BazHdRk z3`;o70^B^s-fg~2MLJVZ_Q}Y{*lNnlij}{MLH^vdwMB_Us3KAQHC*GMB!Sr~X?jc%wV>s(&i8MIp z{pskFDneaUc>MTrYdbr;kzG3V-mjx=Aof!olzk@IjdQxOXRlsz<>5nF9JN}k>}LUP zGQn}SSWlZP6P)JAL}Hpp9`gSy_YlT%s+*YGx{A4tih&u+!o84gO|j@&h>fevgPRjVF1jmU%!4%UA4wyU@=9;T04sA zWM>&?GadQPz%d_FW}qxCO8HfJsnS-Rk9Tla?pxZ;MA>IDAH;PLvnkWX#M((rCOV0} zxlL}Hj$PBf_@XGMI}Opzvg>YNuVK?TzMpXjtDtb+Z@~;@F`eWr!*s_yMO@Cm*8mFZ zlXRBp(`(T1OP2OCmHhua&FNx>=SJB$RmoW|cK@Fqfho%Zjgyj+hBs^0%3W7`Ozvn{ z;XXb-Vr69|4({%<>w2b4a`O>`@s46J!AXoK%@E_sGsI}pbmcf^vWs$5uIJw~oH$MN z5q`9ly^J!q6J0YK89LfLr^=5tFCyEd;$MBWXYeS~tkG5uO4zs4D-6{=p7UrubFqZ3 zKPm%98qHG+$31xm-_S`C@osH5zm;l;=S^)j2b^fG{@S= z2(zi8ZSEl2;~Zq0Ig+CchZ<>UZ+uup!!YQoUYTT z`K{Uwo2C5`5aw=!W^K<^`0fX9#N_~Yfj&vXe=Zp7-l$c_O?4Z$yofk=-%jIg)NRz_ zR>Kw@jw7BK^li=zeUfW*6arIL;+~MuB_~w*{)gn6YOQiZc3cvB?|2z*YAYIGn&BpP zq6KF76<|IbHNi{-|7)5~m0@7Up~hfFFq^vm1R11nB`rJmc~Z1!u>@o_4qY89vpyJ; z^XYEQI`()l)MygYw=GC3FTM9e6ODuUIf5z8oEJ%@s?}xW$dMAYBuZJu$Tc}_+qRS1 zHS0;SqF;0Rj?-=XzA05YrF`Wo=YFi)=vFPYW~uo|%SURB`c3ZO{sk}!!_$+U`l1)W zu}C`0_C?uS0i0RlrdV`B;dEzlJP+48@l!7RFaXsG?!r+RGvC5AfU{KHVUSSwE6^uN z_|K_ZuE*zUPYyY;F}$6|+u*n<8$5@)*maZ9IpoKoE_!-#*o&hUAHSZ-LZUKTjvhVQ zX_&G3`Gix?#d204m<)^v1{g_6W$6S=%LmU@$h*cc3`^!34#v~~W2!?6)oap;rTJXoS=PI0Z<_NGjaba>k@O(jQo@S~aUGRjSwnj)h=fwrp7r%Ig7r!N8P^Edb88 zd=Kz_e35eMWDy0YPbq1FxJZw>W@Dfwzy|S0_z9q!8W*y$>sAX33yVofNx6FT=+SFS zVq%UpP*dxSM)39N^XH44ICEOb@5qT`MGhZJDRTHkN|B={Pbk-U|J>z^Mb2Njtbpfd zE}SoN^4uAvd-F&>Y|pYMkajg5mtcLc{wf4BPccZ34c%BxzdPMxuSF)>%R zTz(}J-Mqzc5_CD6nKH(9mU1+j;;J0q2Co}J*E4`#rVqVL4|=37bT$n`tL*Qq)!+aw z$2SL|Ae@O&_U&Pz0IqH3dgd`zs@FQAHy#GWMCf+ZA>WZtVW`T&vQ2XLm#7`*(Cv;D zOX$E*LBz;#tQZ?v$iM-^PFq`ByDnO^sE?_sDJzW5uG9f}PNpbaq5R(rpvxG`%1yY) zgk%hs^}QPs;5w&1JD}n(K7aoFH8gRDgN15*dzbx&I6dM`x8{s8=q57_xHh+WRNYof9yN>^X2C1NR0);+IK# z^r*-kZaAH4-$yLzG3zvI)d&j!FyK|Sj zf(3TJBiulP{TD5~1|2(gv^#U=Oxor%sp2>r~!IQ_5 zn($>?boBBpu6BCnARM@NS$FGWqUxaW>%*E4BrqA<{X&#Hk z*~43$=Xxvu-v!=d7>+mE&+?T1L$#h4EA}Ow3#QgbP?CF3SL zX8u`zDk$NA8S{K)j&HaexR5Gq_nZ{9#y?5FzQeP%N9yi`O5$++`gQKP{=0qF|6PRg zv!T_fSFheIyvM9JS((ZzOEmJ_Lx&FK9653%hhIAE%Y0|_F@i_R; zvQc+z#B>18F0rel{>MdmR2NhYghGTXNV&@gzv@fpYlf=~CRFxDBID$jsalO1HOxni z8nu7u(4iN#w6sn)Yu3z%@o=9#78#e!!Tgv8m%K1N4sU%|I6Z>QhN80pQp#}_jJ+HM z3RfFYU*-4Rxh#e~FI9)OFgOFisLEPpeqyG3_wK5%cW|`;pCym-3(Ps}K2}rgcgL;U zni~)mC*Gk;Wl>P1EbtGN`M$w2&nHOc;mGqp0>gML4wPA5zS6d17cMd2a0y-Tbtnb# zaD36s?{~z92H4&30gda_Z;&!)ae&PA4SHu@Z$ni^mf1TrT0&x1icfg7RH#_#KDzPH zy?gie!u$9U_{UcBq3o=Lmiqeo>-h4yZX69E7fg4%Ql&~qDp#(2pjNF~7kqqtUh*E7 zzCsG|V^&Fs*LBR8G2_>*TXz5w{V4QdR+{d#Y12ZFA3uH(|Ci%`9lS$Ua*fiZOZRtj za*Eixb?aGfh5*LDla!QnOixdbIx*KsmCk>sEK@z`((ZwQfz125gM$NoQVqd0RAI;v zbVY2Vt*z~nkdSbMJ8+yofBxQ#PJef|2iQdjuTay0JRwW~#NaPU?% zx@(s&UrvY4dSmI*rMrIm=_eXloUU!@>+8F2|Ni|2-2% zP^jXKnl^1UXQB78$hZ{}xP*?ak>aiR2L{OkKl&KvVWIz@!z&~=%j+~g3Bl} z&CJX~@glh_f*AtAql`#^8Kz?aYEz5Dj<%fx$LhU;AaLwB}$sK|3% z6VHtfC`kU3)Edv#%Y~=wxlnya$;Cy$TEG#ViE?&Htt^@=X-YkI| z7l28qE^&s7j6@x`y=sRJ=6L}6B(9BsK1lB|$qV!6&*$hv zD+m^{cSMM&E?QyNzbzaq| zRVx>ew}Eidu3bB2NQR$G=4X=Wi;0SPk(`{&Zk!u0DIccK2c0S2#t<+jEmNoB#fz^% z{+IqJ&-VdwGEx4tZasQ#)*C%qFDfdE7V}@y3qO=l$&|vQQR&Lgu-xzq@8CYJ*&^@O zxZf1#hLC2;=3U$X0Tq^`rl!WF4-R|w?77eDB(58xH035;+{O^yUj)J!LF(+{ebx4c z+&qCgBAHvYT@EYW%F2pESPhXcrQpyF8#X9AbWnAG6;976EucZurcK8{!rdp6a5IK0 zSFZ5;NZCxAd61wx=5*=Og`0b+RE$B8eAn{t$(=iQlyY!)5`H>{arp&0dwcu!RjO2( z&yU8kY%CYkWEhs29|eOXW@DqOkVhymsUnzw4g{2B#sG&(3i}mWRjXEQT8kDf=JxH| zH?CK&UdI|YYI3`GuR+;^25QKlL4(D}$XFa59hJ2_bPC?FV}~3(cu-caUafq-jz@mp zWc&8*a^%R-H@J5d*H@#^9G_#pDkfF;_xJZh7q)NBnlgm$kprD`A(?j%tPgQU$}fZD-{*` z01TFnisOzS=$_xKSh0fskPFSmjoV5_xPAAo!T`{dU!Xp2v~Jz{s*R1!$|t^+{w*Aqj(O9k9WNn;eSTM>gg8{ph$3*0}?wIb@8Ze+qPGJ{`uz{kkT)> zZ8uaH8gO>it5%T^Xs-#9zDiSsm9Wlawm@AT=@%F9ek zOH*3;rAwEUk3aFdJ76^BJKpQpuU9^0$ImMh{1_;~uiWy;dt_vKC(-+z>xAfN%&<(0 zpI+X!ZJPuI1ssWRTm8kj6r7Ph%)DEH7^ZvwMULqiz=iQOFKXE#RO>K~*0^qUMA zI53f$C0xKeAX7#}MBGDnej+F+=n$U$0=lfst$2oHyoYso);|6E9Y#C{95?Mda)e*0 zke&PX$-2#(bARd9?KaX)#{C7QN|o|WTD$humYq9=m}Fx^M+@qr+&p0pkZ5af|717f z?}0$redthD{RRy<*4h>6MDIO(SoWu+$N`{DyLMbZWH4mdu;pYfUfZ~Rdls1S1g=xU z1_GO0-QAxaI&ne{9X~Gf7B0MoYsQ^AclNywX50+Hvu)3w+-^O3(AAC~Rd5G9P~Na6 zO`B5xr8^*dKHb`N>TG1*e7?Ph4oTBy&A5dOXRqiF+X;+L1NT=#B2OKg;8XaL9boA zu6#O=l9UXrVo-hvl#IylE)pt9O9p4Rz^;HyPO(o3!TY|xe&XilE^e-K08g>Ab<5Nq zIqEW)Fg`judJN*Xg7VL)zrQu4^PzKemXp{{_1p^53a9S06ed{W-h;QoWuInh81nFfO)(%pOF z{1u5!TqWU4NAA@|m0NnF(QqMkpFRom-QC6&8CvhuRW&c>C26eiT+Ipi? z4jezFTt~i{rM~@^3}NLm+vDz`6K7=4(c^OA!iCJx(9qOn%a+}MFt`R|<<5cQr(eh8 zIpUMn%H*jIHxS2loaMv|2Tq)pWr@k+;pO!L*Mia0a&m!|dA+z_HC^k@$7)6h{L zrZqC<$mt7`xOSr~iCvyuu3Y&gxIP&7Dex!|OW^;96W(tP=m#yJ$ZA2F`MJ2b92sM5 zmNwJHD=R2qse}YAk?^o3vSssDxpDo5qU@6?sUK0vrtU%sLQv6VcS43r%Jddh# z>MhiFjzR)OL`2F0&xJC7-Xigw?<;d>`{$aOT0b*08+Qg0DHzgLGc`4}3Cc+&{y#=| zv7GZBq(9c|O7dnjn$SpD96~2!7>z-pvM3-FhFA~`FMqL|Z2OXHc@UlqNwvjf!j!4^ zLSvT;R~}BZwO1+|P)E8P^3k<%bWTm)x>LAZ*W7wCrKAfa3Kl9jT{(jmwaI zLLKylnTTgYo z8!(Lhu8o2iVN2qXqKd~{SS1(w#PUxC8TU%RSH5qI1c)|RT zoUo8(5*iHaH!@lh(drK#JOriorov!k%s(PBEv-Lp$45rx=j_(6-yk6&q5K-IEb{Ub z??re~USVQA!SNOJ+1t=}wn1{c9y@ldKcur7lKE|S@E;(&WLowHGv_aQ#Fd1;s8oAb z_iP=5F)v0LnLO3eH-6lIutsVGOSqUPUfX2IH*|^X+$;q9CW>)%aIZ4T|Nqa7ZxbrN9;8`2FwO|*iwhPnUcAS`!s5nw zt0^zMy&`fWLYGTK*fLof6)(|C`I+S;=!ARa*sy4Hex8CEYnqh^? z+BNGSaU=QhQ3-&Q3Gk1QK>sKS^otgUsqSw^k2bhBb?VgpFowL){p%o|wkS^>;2#?t ze;?(y^y<}X)SMl$JSm&2I74DrNT*-A(VcD;zz+>@JdR_C<4_meWPr079J8(WeU++i zp)o76!sAy$0vZ^_qX!4HN7*{NJfJi?b0bZjym*nLuCC5ir5w%ZQm0NG z8yHNtqgJez;AoCBM`o4!wlpQ}i0Uv*UWSG z@w3vi-++6#PD_|00nuQxHKwMfbVi8<_-#v_ufP7- zm)(P7q)@-Mlq^}2Lw|g>>XpCy-Wd%ob0r$n@yoXadyWP(E(M|`EF=a@9S>%Vkr~tHW}BOhe`RE7lnx_?pK1<(@nir- z?g-U@U&iIk$A5+JVmY_lvUArS>-;0)WUhCR%=Zq;tx>Z!H>Dbj+dTm~b0~Tiz{=oM zCdUw)x9|LOvUl(jna6lO!MQbS*QHyWYQ%uUO#M6m(*5XcFMpZm6D%C`gN~jFPR=VgwOhD0ZbowM873Kc7Hw4rhBy7hhL`G(~BghmVJur6J?^Z`8v!ucXR zF8Pk@yv1j}EnSAsND2GT5b~=5G=c8-%Yg$2j8?8(xiBOoWFsv03lkjqigI&(EDZ zcOxwEg-tINJF3x7rb&Se9 zbuKa@r&(2wC}heW1BQ+`&v=ua+{9#p?JLA_MqK(pQs1K68i(xMwDgRhO>}S(+v&5# z(cMd?&&!)$wRfE-Q=DgsrHxZ|{f13a5Y`Toj#GZ>y#@?94pFHrL$R`Re)IL$CESrd zcY_;Pvv$3W7B)_~)($h3r4tUbJjHR=0%f_#B$Q>6(=5>%J?32T;$P82O8KI3`3jX{ z%qBVHaJdPWT;xsf`iS$K#WEFn*dxA?x%IWuWy(@lZeF!o^+jBk!t^FP&lX!(4<_~OaY;HhTJhouLf~2spFpq?U1QUL|{`T$L9UvLW zjK5Az{g(+ZmQ!wh`VJd)edwsMZ-$IA$?VcwokJ*kxJOTzcj`|071FcM5S=TGH&o9I z@dnc(r{gf)*i@q;oa0t6Rl00+o6bER4AC8%r8{nlj5fEE(UwzXu=beO?Ys85U#46I zcE22op*7wN7^i7um2Ny~x)_XiklsUeXykDHcU>?h=d~@X)vUX}TYrt`T85Un+GDLn z*L1RsFdm=Xd+^A|4V$&$Yzy7&=t)%$(o&fM{=Qm`9l!J)@(gL`j><2Gj@gu)K0|e$ zG-=hIT|RwITO*H##fp7t*12c@JHzzNb4HGxDB30ybMbzj)UMw+3}MA7pyu9553t+ND!%|O?)AU;0cFE%z7{2IO#T|h*1bhLj=OpIq-T-3&fzFrrxa{f z?91X-h~o=z+duknva(cj*914CrIQ0c88{o^lgd@9a;S3E>c`8JuSETmdLNf$=z$U1 z7cE+>ZS#&j9CXIdI5;gZDR-#RWEld~ZQ7ci=p2fnV+^-zr1J!wivvo2TV`9uDnA~r zROQD*B}#tF;U=!`tq8_R0*U{W;X(SN|gF`3&J0(_XbR93oGE0N$iuf2B}0`KLAp~JH(9?z9{ z=F=AzF?050ICl5+5aI+!J1`TyYseU!OCOD{o-SzZ0L7P}e5LOVM@^XadeWRA(Kfdi zP17kdP}l6u*WZ-n_$1W{su9ea!#8SRc=~km0|L}T#{irc?}2-K1~Me)yeYLw^j5Er z`;^9f#D6{~9gr0(9oIfS0@GCm{-fiH|4zb- zWra~!q*UY>oobwp760C058eab8_y#srie#CbP;#IC56M%BIovilrnTc=5h=&4%47+ zTcbgvpXN+)oiF2^+{I$5ix^qiX4bCXkZYoJ!4RBKASoV102zn*@;VuXpi?uik$D;B zU$gzASO&&X%>t648BP_4@!6Odhs3a|GLw;6W;QDN(=u(<809}YsqvZqCau`8waD^y zn~N-4y|GA4^7Nk5Z?4!zMr3>KU6{8m>Jmwa)